Remove src/s/irix6-5.h
[bpt/emacs.git] / src / ChangeLog
CommitLineData
14c114ae
JD
12012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (openFiles): Fix previous checkin.
4
3bd21e82
PE
52012-07-31 Paul Eggert <eggert@cs.ucla.edu>
6
7 * indent.c (compute_motion): Remove unused local.
8
c1529ded
GM
92012-07-31 Glenn Morris <rgm@gnu.org>
10
7552f3ee
GM
11 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
12 * s/irix6-5.h: Remove file.
13
6a381852
GM
14 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
15 * s/darwin.h: Remove file.
16
c1529ded
GM
17 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
18 * s/hpux10-20.h: Remove file, which is now empty.
19
b429a4ee
GM
202012-07-30 Glenn Morris <rgm@gnu.org>
21
22 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
23 * Makefile.in (config_h): Add conf_post.h.
24 * makefile.w32-in (CONFIG_H): Add conf_post.h.
25
adff3182
JD
262012-07-30 Jan Djärv <jan.h.d@swipnet.se>
27
28 * nsterm.m (ns_do_open_file): New variable.
29 (ns_term_init): Set ns_do_open_file to NO after run returns.
30 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
31 files only if ns_do_open_file.
32
c32af1e4
PE
332012-07-30 Paul Eggert <eggert@cs.ucla.edu>
34
7393bcbb
PE
35 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
36 This no-op macro hasn't been needed for many years.
37 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
38
c32af1e4
PE
39 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
40 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
41 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
42 gdb_make_enums_visible.
43 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
44 (DIRECTORY_SEP): Now a constant, not a macro.
45
302fc036
EZ
462012-07-30 Eli Zaretskii <eliz@gnu.org>
47
48 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
49 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
50
51 * w32term.c <w32_keyboard_codepage>: Renamed from
52 keyboard_codepage and now external. All users changed.
53
54 * w32term.h: Add declaration of w32_keyboard_codepage.
55
56 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
57 the codepage to translate keys to Unicode. If this argument is
58 -1, use the value returned by GetConsoleCP. All callers changed.
59
88fb40b4
PE
602012-07-30 Paul Eggert <eggert@cs.ucla.edu>
61
0aee6912
PE
62 Update .PHONY listings in makefiles.
63 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
64 bootstrap-clean, distclean, maintainer-clean, versioclean,
65 extraclean, frc.
66
88fb40b4
PE
67 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
68 This is a bit clearer. Fix some commentary typos.
69
0a763bd1
GM
702012-07-30 Glenn Morris <rgm@gnu.org>
71
32bac6d6
GM
72 * s/netbsd.h: Let configure include signal.h if needed.
73 Remove file, which is now empty.
74
b65e7c46
GM
75 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
76 Let configure set them.
77 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
78 No more need to undefine.
0a763bd1 79
169304bd
AS
802012-07-30 Andreas Schwab <schwab@linux-m68k.org>
81
82 * keymap.c (Fkey_description): Don't remove 0x80 bit from
83 non-single-byte char when adding meta modifier. (Bug#12090)
84
6cd7a139
DA
852012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Convert safe_call to use variable number of arguments.
88 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
89 (safe_call2): Fix comment.
90 * lisp.h (safe_call): Adjust prototype.
91 * coding.c (encode_coding_object): Change to use safe_call2.
92 * xfaces.c (merge_face_heights): Change to use safe_call1.
93
d34d6ffc
GM
942012-07-30 Glenn Morris <rgm@gnu.org>
95
7b8a48e4 96 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 97 does that unconditionally. Remove file, which is now empty.
7b8a48e4 98
d34d6ffc
GM
99 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
100 Remove empty files.
101
03a660a6
PE
1022012-07-30 Paul Eggert <eggert@cs.ucla.edu>
103
104 Export to GDB most of lisp.h's remaining object-like macros.
105 * lisp.h (min, max): Move earlier, because they're used earlier now.
106 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
107 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
108 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
109 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
110 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
111 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
112 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
113 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
114 Now constants, for GDB. They need not be macros.
115 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
116 Now constants, for GDB, as well as macros, for static initializers.
117 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
118 Move to after the definition of struct Lisp_Char_Table,
119 since the former now needs that type defined.
120 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
121 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
122 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
123 New enums, for gdb_make_enums_visible.
124 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 125 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
126 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
127 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
128 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
129 enum maxargs, enum MAX_ALLOCA.
130 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
131 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
132 no longer needed, now that they are done in lisp.h.
133
e499d0ee
DA
1342012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
135
136 Cleanup string bytes checking.
137 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
138 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
139 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
140 (check_sblock, compact_small_strings): Simplify.
141
d5040d2d
PE
1422012-07-29 Paul Eggert <eggert@cs.ucla.edu>
143
144 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
145 These macros are confusing and no longer need to be defined, as
146 the enum values now suffice. All uses replaced with definiens.
147 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
148
7f259ae6
JB
1492012-07-29 Juanma Barranquero <lekktu@gmail.com>
150
151 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
152 ($(BLD)/w32console.$(O)): Update dependencies.
153
7e63e0c3
DA
1542012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
155
156 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
157 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
158 time. Adjust users.
159 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
160
ffd817eb
JD
1612012-07-29 Jan Djärv <jan.h.d@swipnet.se>
162
163 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
164 setting sitelisp (Bug#12010).
165
417a7a0e
EZ
1662012-07-29 Eli Zaretskii <eliz@gnu.org>
167
168 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
169
170 * w32heap.c (cache_system_info):
171 * w32.c (sys_rename):
172 * w32proc.c (find_child_console, sys_kill): All users changed.
173
387d4d92
PE
1742012-07-29 Paul Eggert <eggert@cs.ucla.edu>
175
176 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
177
55a6cca6
EZ
1782012-07-29 Eli Zaretskii <eliz@gnu.org>
179
180 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
181
dbcf001c
DA
1822012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
183
184 Cleanup statistics calculation in Fgarbage_collect.
185 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
186 zombies percentage calculation. Simplify elapsed time calculation.
187
e2688e4a
DA
1882012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Generalize marker debugging code under MARKER_DEBUG and use eassert.
191 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
192 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
193 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
194 (replace_range, replace_range_2, del_range_2): Change to eassert.
195 * marker.c (byte_char_debug_check): Adjust style.
196
b46a6a83
PE
1972012-07-29 Paul Eggert <eggert@cs.ucla.edu>
198
199 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
200 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
201 long-ago-commented-out code that talks about "WIN32".
202 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
203 All uses changed.
204
e32a5799
PE
2052012-07-28 Paul Eggert <eggert@cs.ucla.edu>
206
207 Use Gnulib stdalign module (Bug#9772, Bug#9960).
208 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
209 Simplify by using alignof.
210 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
211 * lisp.h: Include <stdalign.h>.
212 (GCALIGNMENT): New macro and constant.
213 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
214 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
215 (stdalign): New macro, if not already defined.
216
df81cd29
EZ
2172012-07-28 Eli Zaretskii <eliz@gnu.org>
218
01bd1b0d
EZ
219 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
220 * w32inevt.c: Include w32inevt.h.
221 (w32_read_console_input): New inline function, calls either
222 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
223 w32_console_unicode_input.
224 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
225 (w32_kbd_patch_key, key_event): Use the codepage returned by
226 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
227 (key_event): use uChar.UnicodeChar only if
228 w32_console_unicode_input is non-zero.
229
230 * w32console.c: Include w32heap.h.
231 <w32_console_unicode_input>: New global variable.
232 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
233 family of Windows, zero otherwise.
234
235 * w32inevt.h: Declare w32_console_unicode_input.
236
df81cd29
EZ
237 * xdisp.c (init_iterator): Don't reference tip_frame in a build
238 --without-x. (Bug#11742)
239
c20fdd9e
PE
2402012-07-27 Paul Eggert <eggert@cs.ucla.edu>
241
242 Adjust GDB to reflect pvec_type changes (Bug#12036).
243 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
244 2012-07-04 changes to pseudovector representation. Problem
245 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
246
32770973 2472012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
248
249 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
250 bus address.
251 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
252
3438fe21
EZ
2532012-07-27 Eli Zaretskii <eliz@gnu.org>
254
bcfbc9de
EZ
255 * alloc.c (listn): Fix the order the arguments are consed onto the
256 list.
257
3438fe21
EZ
258 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
259 enumeration constants, as PURE and HEAP are too general, and clash
260 with other headers and sources, such as gmalloc.c and the
261 MS-Windows system headers. All users changed.
262
eeaea515
DA
2632012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Revert last save_excursion_save and save_excursion_restore changes.
266 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
267 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
268
073c88c2
DA
2692012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Fix recently-introduced typos in Windows port.
272 Reported by Martin Rudalics <rudalics@gmx.at>.
273 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 274 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 275
4706125e
PE
2762012-07-27 Paul Eggert <eggert@cs.ucla.edu>
277
278 Improve GDB symbol export (Bug#12036).
279 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
280 arms of an 'if', not using conditional expressions; otherwise GDB
281 complains about the types in the unevaluated arm when the argument
282 is an integer literal.
283 (xgetint): Simplify expression.
284 * alloc.c (gdb_make_enums_visible): New constant. This ports to
285 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
286 Zaretskii in <http://bugs.gnu.org/12036#13>.
287 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
288 needed now that we have gdb_make_enums_visible.
289 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
290 (enum enum_USE_LSB_TAG):
291 New enum types, packaging up enums that need to be exported to GDB.
292
694b6c97
DA
2932012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
294
295 Utility function to make a list from specified amount of objects.
296 * lisp.h (enum constype): New datatype.
297 (listn): New prototype.
298 * alloc.c (listn): New function.
299 (Fmemory_use_count, syms_of_alloc): Use it.
300 * buffer.c (syms_of_buffer): Likewise.
301 * callint.c (syms_of_callint): Likewise.
302 * charset.c (define_charset_internal): Likewise.
303 * coding.c (syms_of_coding): Likewise.
304 * keymap.c (syms_of_keymap): Likewise.
305 * search.c (syms_of_search): Likewise.
306 * syntax.c (syms_of_syntax): Likewise.
307 * w32.c (init_environment): Likewise.
308 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
309 * xdisp.c (syms_of_xdisp): Likewise.
310 * xfns.c (syms_of_xfns): Likewise.
311
6195f384
DA
3122012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
313
314 Fast save_excursion_save and save_excursion_restore.
315 * lisp.h (struct Lisp_Excursion): New data type.
316 (PVEC_EXCURSION): New pseudovector type.
317 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
318 to deal with it. Adjust comments.
319 (init_marker, attach_marker): New prototype.
320 (unchain_marker): Adjust prototype.
321 * marker.c (attach_marker): Change to global.
322 (init_marker): New function.
323 * alloc.c (Fmake_marker, build_marker): Use it.
324 (build_marker): More easserts.
325 (mark_object): Handle struct Lisp_Excursion.
326 * editfns.c (save_excursion_save, save_excursion_restore):
327 Reimplement to use struct Lisp_Excursion. Add comments.
328
5eceb8fb
PE
3292012-07-26 Paul Eggert <eggert@cs.ucla.edu>
330
331 Fix export of symbols to GDB (Bug#12036).
332 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
333 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
334 emacs.c, as this is a more-suitable home. Had this been done earlier
335 the fix for 12036 would have avoided some of the problems noted in
336 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
337 would have been more obvious.
562157c8
PE
338 * emacs.c: Do not include <verify.h>; no longer needed.
339 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
340 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
341 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
342 Remove; now done in lisp.h.
343 * lisp.h (PUBLISH_TO_GDB): New macro.
344 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
345 (DATA_SEG_BITS): Use it.
346 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
347 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
348 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
349 not be usable in #if. This simplifies things.
350
d6749401
JB
3512012-07-26 Juanma Barranquero <lekktu@gmail.com>
352
353 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
354
1781b9e9
PE
3552012-07-26 Paul Eggert <eggert@cs.ucla.edu>
356
d89518db 357 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
358 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
359 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
360 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
361 Adjust to changes in lisp.h and emacs.c, by using
362 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
363 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
364 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
365 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
366 instead of gdb_valbits.
367 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
368 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
369 instead of gdb_array_mark_flag.
370 (xboolvector): Get size from $->size, not $->header.size.
371 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
372 (xreload, hook-run, hookpost-run): Remove.
373 * emacs.c: Include <verify.h>.
374 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
375 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
376 Remove.
377 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
378 (gdb_USE_LSB_TAG): New enum constants.
379 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
380 Also define these as enum constants, so they're visible to GDB.
381 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
382 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
383 as constants, so they're visible to GDB.
384 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
385 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
386 Now enum constants, not macros, so they're visible to GDB.
387 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
388 more convenient now. All uses changed.
389 (VALMASK) [USE_LSB_TAG]: Also define in this case.
390 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
391
3628596a
DA
3922012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
393
394 Explicitly free restriction data that are not needed anymore.
395 * editfns.c (save_restriction_restore): Free restriction data.
396
7abaf5cc
SM
3972012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
398
399 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
400 add argument, tune behavior, and adjust all callers.
401
71f88e00
PE
4022012-07-25 Paul Eggert <eggert@cs.ucla.edu>
403
404 Use typedef for EMACS_INT, EMACS_UINT.
405 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
406 than macros. This simplifies debugging in the usual case, since
407 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
408 and it allows expressions involving EMACS_INT casts.
409 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
410
57ec3034
JD
4112012-07-25 Jan Djärv <jan.h.d@swipnet.se>
412
413 * nsterm.m (ns_read_socket): Return early if there is a modal
414 window (Bug#12043).
415
8137e7b3
MR
4162012-07-25 Martin Rudalics <rudalics@gmx.at>
417
418 * frame.c (Fredirect_frame_focus): In doc-string don't mention
419 that FOCUS-FRAME can be omitted.
420
04e9897c
DA
4212012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
422
423 Adjust buffer text indirection counters at the end of Fkill_buffer.
424 * buffer.c (Fkill_buffer): Adjust indirection counters when the
425 buffer is definitely dead. This should really fix an issue reported
426 by Christoph Scholtes again. (Bug#12007).
427 (init_buffer_once): Initialize indirection counters of
428 buffer_defaults and buffer_local_symbols (for sanity and safety).
429
8a0484e1
EZ
4302012-07-24 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (init_iterator): Don't compute dimensions of truncation
433 and continuation glyphs on tooltip frames, leave them at zero.
434 Avoids continued lines in tooltips. (Bug#11832)
435
fa691a83
DA
4362012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
437
438 Simplify copy_overlay.
04e9897c 439 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
440 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
441
436bc8e0
EZ
4422012-07-23 Eli Zaretskii <eliz@gnu.org>
443
444 * print.c (print_object): Don't crash when a frame's name is nil
445 or invalid. (Bug#12025)
446
447 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
448 it signals an error when a tooltip frame is being created.
449
d7a7fda3
DA
4502012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
451
452 Cleanup miscellaneous objects allocation and initialization.
453 * alloc.c (allocate_misc): Change to static. Add argument to
454 specify the subtype. Adjust comment and users.
455 (build_overlay): New function.
456 * buffer.c (copy_overlays, Fmake_overlay): Use it.
457 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
458 (allocate_misc): Remove prototype.
459 (build_overlay): Add prototype.
460
4612012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
462
463 Swap buffer text indirection counters in Fbuffer_swap_text.
464 * buffer.c (Fbuffer_swap_text): Swap indirections too.
465 This avoids crash reported by Christoph Scholtes at
466 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
467
9d7fa573
JD
4682012-07-22 Jan Djärv <jan.h.d@swipnet.se>
469
470 * nsmenu.m (Popdown_data): New struct.
471 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
472 free Popdown_data.
473 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
474 (initWithContentRect): Make imgView and contentView non-static
475 and autorelease them. Also autorelease img and matrix (Bug#12005).
476 (dealloc): Remove (Bug#12005).
477
0dd6d66d
DA
4782012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
479
480 Adjust consing_since_gc when objects are explicitly freed.
481 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
482 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
483 (free_cons, free_misc): Subtract object size from consing_since_gc.
484
d36d71df
DA
4852012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
486
487 Simplify and cleanup markers positioning code.
488 * marker.c (attach_marker): More useful eassert.
489 (live_buffer, set_marker_internal): New function.
490 (Fset_marker, set_marker_restricted): Use set_marker_internal.
491 (set_marker_both, set_marker_restricted_both): Use live_buffer.
492
fb9ea40f
PE
4932012-07-22 Paul Eggert <eggert@cs.ucla.edu>
494
495 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
496 as it's limited by the amount of memory, not by INT_MAX.
497
2d5c5f7d
EZ
4982012-07-21 Eli Zaretskii <eliz@gnu.org>
499
07fb592e
EZ
500 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
501 in special-event-map. See the discussion at
502 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
503 for the reasons.
504
37a9eac8 505 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
506 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
507 Fabrice Popineau <fabrice.popineau@supelec.fr>.
508
c4328746
JD
5092012-07-21 Jan Djärv <jan.h.d@swipnet.se>
510
511 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 512 (conversationIdentifier): Return value is NSInteger.
784051c4 513 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 514
6e5d1c12
CY
5152012-07-21 Chong Yidong <cyd@gnu.org>
516
517 * window.c (decode_any_window): Signal an error if the window is
518 on a dead frame (Bug#11984).
519
9928463d
DA
5202012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
521
522 Add indirection counting to speed up Fkill_buffer.
523 * buffer.h (struct buffer): New member.
524 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
525 (Fmake_indirect_buffer): Set indirection counter to -1, increment
526 base buffer indirection counter.
527 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
528 (Fkill_buffer): Adjust indirection counters as needed, don't walk
529 through buffer list if indirection counter is 0.
530
f8643a6b
DA
5312012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
532
533 Extend the value returned by Fgarbage_collect with heap statistics.
534 * alloc.c (Qheap): New symbol.
535 (syms_of_alloc): DEFSYM it.
536 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
537 (Fmemory_free): Remove.
538 (syms_of_alloc): Don't defsubr it.
539 * buffer.c (Fcompact_buffer): Remove.
540 (syms_of_buffer): Don't defsubr it.
541
dac616ff
DA
5422012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
543
544 Make maybe_gc inline.
545 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
546 * lisp.h (consing_since_gc, gc_relative_threshold)
547 (memory_full_cons_threshold): Revert declaration.
548 (maybe_gc): Remove prototype, define as inline.
549 * alloc.c: Remove old commented-out code.
550 (consing_since_gc, gc_relative_threshold)
551 (memory_full_cons_threshold): Revert to global.
552 (maybe_gc): Remove.
553
d7ea76b4
DA
5542012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
555
556 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
557 * lisp.h (build_unibyte_string): New function.
558 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
559 * sysdep.c, w32fns.c, xfns.c: Use it.
560 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
561 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
562 Adjust users accordingly.
563 * font.h (font_open_by_name): Adjust prototype.
564
765e61e3
DA
5652012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
566
567 Cleanup calls to Fgarbage_collect.
568 * lisp.h (maybe_gc): New prototype.
569 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
570 Remove declarations.
571 * alloc.c (maybe_gc): New function.
572 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
573 Make them static.
574 * bytecode.c (MAYBE_GC): Use maybe_gc.
575 * eval.c (eval_sub, Ffuncall): Likewise.
576 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
577 to avoid dependency from auto-save feature.
578
52b852c7
PE
5792012-07-19 Paul Eggert <eggert@cs.ucla.edu>
580
581 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
582 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
583 'for_each_per_buffer_object_at'.
584 All uses changed. It's better to use upper-case for macros that
585 cannot be implemented as functions, to give the reader a clue
586 that they're special.
587
5db81e33
SM
5882012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
589
590 * alloc.c (Fgarbage_collect): Tweak docstring.
591
5b835e1d
DA
5922012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
593
594 Tweak the value returned from Fgarbage_collect again.
595 * alloc.c (Fgarbage_collect): New return value, as confirmed in
596 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
597 Adjust documentation.
598 (total_vector_bytes): Rename to total_vector_slots, adjust
599 accounting.
600 (total_free_vector_bytes): Rename to total_free_vector_slots,
601 adjust accounting.
602 (Qstring_bytes, Qvector_slots): New symbols.
603 (syms_of_alloc): DEFSYM them.
604
9cd47b72
DA
6052012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
606
607 Buffer compaction primitive which may be used from Lisp.
608 * buffer.c (compact_buffer, Fcompact_buffer): New function.
609 (syms_of_buffer): Register Fcompact_buffer.
610 * alloc.c (Fgarbage_collect): Use compact_buffer.
611 * buffer.h (compact_buffer): New prototype.
612 (struct buffer_text): New member.
613
d17337e5
DA
6142012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
615
616 New macro to iterate over all buffers, miscellaneous cleanups.
617 * lisp.h (all_buffers): Remove declaration.
618 * buffer.h (all_buffers): Add declaration, with comment.
619 (for_each_buffer): New macro.
620 * alloc.c (Fgarbage_collect, mark_object): Use it.
621 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
622 (init_buffer): Likewise.
623 * data.c (Fset_default): Likewise.
624 * coding.c (code_conversion_restore): Remove redundant check
625 for dead buffer.
626 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
627
60cfd278
AS
6282012-07-18 Andreas Schwab <schwab@linux-m68k.org>
629
630 Fix bug that created negative-length intervals.
631 * intervals.c (merge_interval_right, merge_interval_left):
632 Do not zero out this interval if it is absorbed by its children,
633 as this interval's total length doesn't change in that case. See
634 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
635
d06714cb
PE
6362012-07-18 Paul Eggert <eggert@cs.ucla.edu>
637
83713154
PE
638 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
639 when invoking (make-bool-vector N t) and N is a positive
640 multiple of 8 -- the last 8 bits were mistakenly cleared.
641
d06714cb
PE
642 Remove some struct layout assumptions in bool vectors.
643 * alloc.c (bool_header_size): New constant.
644 (header_size, word_size): Move earlier, as they're now used earlier.
645 Use 'word_size' in a few more places, where it's appropriate.
646 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
647 padding before the data member of a bool vector.
648 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
649 than doing the check by hand with an abort ().
650
464d5a5e
SM
6512012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
652
5fbc0409
SM
653 * eval.c (Fdefvar): Don't check constants since we only set the var if
654 it's not yet defined anyway (bug#11904).
655
464d5a5e
SM
656 * lisp.h (last_undo_boundary): Declare new var.
657 * keyboard.c (command_loop_1): Set it.
658 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
659 were auto-added by the command loop (bug#11774).
660
8dc2e44a
AS
6612012-07-18 Andreas Schwab <schwab@linux-m68k.org>
662
663 * w32font.c (Qsymbol): Remove local definition.
664 (syms_of_w32font): Don't DEFSYM it.
665
169925ec
DA
6662012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Fix sweep_vectors to handle large bool vectors correctly.
669 * alloc.c (sweep_vectors): Account total_vector_bytes for
670 bool vectors larger than VBLOCK_BYTES_MAX.
671
5fbfb018
CY
6722012-07-18 Chong Yidong <cyd@gnu.org>
673
674 * frame.c (x_set_frame_parameters): Revert bogus change introduced
675 in 2012-05-25 commit by Paul Eggert (Bug#11738).
676
3ab6e069
DA
6772012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
678
679 Return more descriptive data from Fgarbage_collect.
680 Suggested by Stefan Monnier in
681 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
682 * alloc.c (bounded_number): New function.
683 (total_buffers, total_vectors): New variable.
684 (total_string_size): Rename to total_string_bytes, adjust users.
685 (total_vector_size): Rename to total_vector_bytes, adjust users.
686 (sweep_vectors): Account total_vectors and total_vector_bytes.
687 (Fgarbage_collect): New return value. Adjust documentation.
688 (gc_sweep): Account total_buffers.
689 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
690 (VECTOR_SIZE): Remove.
691 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
692 (Qinterval, Qmisc): New symbols.
693 (syms_of_data): Initialize them.
694 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
695 (Qcons, Qbuffer): New declarations.
696
6d02fe5b
PE
6972012-07-17 Paul Eggert <eggert@cs.ucla.edu>
698
699 * alloc.c (Fmemory_free): Account for memory-free's own storage.
700 Round up, not down. Improve doc.
701
b7ffe040
DA
7022012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
703
704 Restore old code in allocate_string_data to avoid Faset breakage.
705 Reported by Julien Danjou <julien@danjou.info> in
706 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
707 * alloc.c (allocate_string_data): Restore old code with minor
708 adjustments, fix comment to explain this subtle issue.
709
4dc7c8d5
SM
7102012-07-17 Eli Zaretskii <eliz@gnu.org>
711
712 Remove FILE_SYSTEM_CASE.
713 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
714
715 * fileio.c (FILE_SYSTEM_CASE): Don't define.
716 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
717 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
718 call-process-region passes it through expand-file-name.
719
720 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
721
7222012-07-17 Andreas Schwab <schwab@linux-m68k.org>
723
724 Fix crash when creating indirect buffer (Bug#11917)
725 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
726 Don't handle unbound variables specially if non-zero.
727 (Fbuffer_local_variables): Pass zero.
728 (clone_per_buffer_values): Pass non-zero.
729
7302012-07-17 Andreas Schwab <schwab@linux-m68k.org>
731
732 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
733 to make the loop interruptible.
734
7352012-07-17 Andreas Schwab <schwab@linux-m68k.org>
736
737 * gnutls.c (emacs_gnutls_handshake): Only retry if
738 GNUTLS_E_INTERRUPTED.
739
cce7fefc
DA
7402012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
741
742 Cleanup and convert miscellaneous checks to eassert.
743 * alloc.c (mark_interval): Fix comment, partially rephrase
744 old comment from intervals.h (see below).
745 * intervals.c (find_interval, adjust_intervals_for_insertion)
746 (delete_interval, adjust_intervals_for_deletion)
747 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
748 Convert to eassert.
749 (adjust_intervals_for_insertion, make_new_interval):
750 Remove obsolete and unused code.
751 * intervals.h (struct interval): Remove obsolete comment.
752 * textprotp.c (erase_properties): Remove unused code.
753 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
754 (Fremove_list_of_text_properties): Convert to eassert.
755
9ea10cc3
CY
7562012-07-17 Chong Yidong <cyd@gnu.org>
757
758 * editfns.c (Finsert_char): Doc fix.
759
3900d5de
DA
7602012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
761
762 Fix previous change to make Fmemory_free always accurate.
763 * alloc.c (make_interval): Update total_free_intervals.
764 (make_float): Likewise for total_free_floats.
765 (free_cons, Fcons): Likewise for total_free_conses.
766 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
767 Likewise for total_free_vector_bytes.
768 (Fmake_symbol): Likewise for total_free_symbols.
769 (bytes_free): Remove.
770
7098646f
DA
7712012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
772
773 Simple free memory accounting feature.
774 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
775 (sweep_vectors): Accumulate size of free vectors.
776 (Fgarbage_collect): Setup bytes_free.
777 (Fmemory_free): New function.
778 (syms_of_alloc): Register it.
779
22657b40
DA
7802012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
781
782 Cleanup overlays checking.
783 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
784 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
785 eassert and OVERLAYP.
786 (sort_overlays): Change to use OVERLAYP.
787
ddfc8813
RK
7882012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
789
790 * editfns.c (Finsert_char): Make it interactive, and make the
791 second arg optional. Copy interactive spec and docstring from
792 ucs-insert.
793
7c26cf3c
PE
7942012-07-17 Paul Eggert <eggert@cs.ucla.edu>
795
796 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
797 Unlike the other wrapped functions, fabs has an unspecified
798 effect on errno.
799
5d127af9
JD
8002012-07-16 Jan Djärv <jan.h.d@swipnet.se>
801
802 * nsterm.m (keyDown): Interpret flags without left/right bits
803 as the left key (Bug#11670).
804
6a0dd1d7
DA
8052012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
806
807 Remove empty and useless init functions.
808 * lisp.h (init_character_once, init_fns, init_image)
809 (init_filelock, init_sound): Remove prototype.
810 * character.c (init_character_once): Remove.
811 * filelock.c (init_filelock): Likewise.
812 * fns.c (init_fns): Likewise.
813 * image.c (init_image): Likewise.
814 * sound.c (init_sound): Likewise.
815 * emacs.c (main): Adjust accordingly.
816
7a6136fd
DA
8172012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
818
819 * gtkutil.h: Tiny cleanups.
820 (use_old_gtk_file_dialog): Remove useless declaration.
821 (xg_uses_old_file_dialog): Add suggested const attribute.
822
ce811ad9
EZ
8232012-07-15 Eli Zaretskii <eliz@gnu.org>
824
825 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
826 (bidi_paragraph_init): Use it to limit search forward for a strong
827 directional character in abnormally large paragraphs full of
828 neutral or weak characters. (Bug#11943)
829
c9adfeaa
SF
8302012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
831
832 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
833 the toolbar (Bug#9451).
834 (xg_make_tool_item): Give the widget event box a transparent
835 background.
836
fff62aa9
DA
8372012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
838
839 Cleanup basic allocation variables and functions.
840 * alloc.c (ignore_warnings, init_intervals, init_float)
841 (init_cons, init_symbol, init_marker): Remove.
842 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
843 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
844 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
845 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
846 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
847 (staticidx, init_alloc_once, init_strings, free_ablock):
848 Remove redundant initialization.
849 * fns.c (init_weak_hash_tables): Remove.
850 * lisp.h (init_weak_hash_tables): Remove prototype.
851
9730daca
DA
8522012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
853
854 Use zero_vector where appropriate.
855 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
856 accordingly.
857 * lisp.h (zero_vector): New declaration.
858 * font.c (null_vector): Remove.
859 (syms_of_font): Remove initialization and staticpro.
860 (font_list_entities, font_find_for_lface): Change to use zero_vector.
861 * keymap.c (Faccessible_keymaps): Likewise.
862
2e2d2a13
LL
8632012-07-15 Leo Liu <sdl.web@gmail.com>
864
865 * fringe.c: Fix typo in comments.
866
cd276f6e
LL
8672012-07-14 Leo Liu <sdl.web@gmail.com>
868
869 * fringe.c: Add a new bitmap exclamation-mark.
870
5a1131d9
EZ
8712012-07-14 Eli Zaretskii <eliz@gnu.org>
872
873 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
874
875 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
876 (HAVE_MENUS): Don't define, defined by editing config.in with
877 msdos/sed2v2.inp.
878 (GMALLOC_INHIBIT_VALLOC): Don't define.
879 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
880
22e983b7
JB
8812012-07-14 Juanma Barranquero <lekktu@gmail.com>
882
883 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
884
5b3f250f
GM
8852012-07-14 Glenn Morris <rgm@gnu.org>
886
887 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
888 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
889 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
890
33d63ff4
GM
8912012-07-13 Glenn Morris <rgm@gnu.org>
892
5b633342
GM
893 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
894
33d63ff4
GM
895 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
896 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
897
b55b9f85
JD
8982012-07-13 Jan Djärv <jan.h.d@swipnet.se>
899
0dc8cf50
JD
900 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
901 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
902 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
903 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
904 where appropriate.
905 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
906 as boolean expression.
907 (x_set_window_size): Remove unused variable toolbar.
908 (ns_get_color_default, ns_mod_to_lisp): Remove.
909 (ns_mouse_position): Remove unused variables xchar and ychar.
910 (ns_compute_glyph_string_overhangs): Remove unused variable face.
911 (ns_set_vertical_scroll_bar): Remove unused variable count.
912 (ns_delete_terminal): Remove unused variable i.
913 (ns_term_init): Remove unused variables r, g and b.
914 (mouseDown): Remove unused variable window.
915 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
916 (initFrameFromEmacs): Remove unused variable vbextra.
917 (mouseEntered): Remove unused variables p and dpyinfo.
918 (mouseExited): Remove unused variables p and r.
919 (ns_define_frame_cursor, ns_clear_frame_area)
920 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
921 (menuDown): Assign [sender tag] to variable and cast the variable.
922
923 * nsterm.h (menuDown): Add id as type to argument sender.
924 (ns_display_info_for_name): Add Lisp_Object argument.
925 (ns_term_init): Add Lisp_Object argument.
926 (ns_map_event_to_object): Add void argument.
927 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
928 prototype with arguments and only declare if __OBJC__.
929 (nxatoms_of_nsselect): Add void argument.
930 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
931 (ns_alloc_autorelease_pool): Add void argument.
932 (ns_release_autorelease_pool): Add void* argument.
933 (ns_get_defaults_value): Add const char* argument.
934
935 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
936 (initFromContents): Use SSDATA where appropriate.
937 (ns_update_menubar): Add braces to ambigous if-else.
938 (initWithTitle): Put () around assignment in if statement.
939 (ns_menu_show): Remove unused variables window and keymap.
940 (update_frame_tool_bar): Remove unused variable selected_p.
941 (initWithContentRect): Remove unused variable this_cmd_name.
942
943 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
944 appropriate.
945 (setXBMColor): Remove unused variable len.
946 (setPixmapData): Put () around assignment in loop statement.
947
948 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
949 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
950 where appropriate.
951 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
952 around assignment in loop statement.
953 (nsfont_open): Remove unused variable i.
954 (nsfont_open): Remove unused variable len.
955 (nsfont_draw): Remove unused variable cs.
956
957 * nsfns.m (x_set_icon_name, ns_set_name_internal)
958 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
959 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
960 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
961 (Fns_font_name, Fns_perform_service)
962 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
963 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
964 (ns_set_name): Remove unused variable view.
965 (x_set_menu_bar_lines): Remove unused variable olines.
966 (x_set_tool_bar_lines): Remove unused variable root_window.
967 (Fns_list_colors): Put () around assignment in while statement.
968 (Fns_perform_service): Remove unused variable len.
969 (Fns_display_usable_bounds): Remove unused variable top.
970 (syms_of_nsfns): Remove unused variable i.
971
b55b9f85
JD
972 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
973 memcpy (Bug#11907).
974
ed9265fc 9752012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
976
977 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
978 and free it with DestroyExceptionInfo (Bug#11558).
979
ef099b57
JB
9802012-07-13 Juanma Barranquero <lekktu@gmail.com>
981
982 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
983 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
984 Set here, not in nt/config.nt.
985
ea814a5d
EZ
9862012-07-13 Eli Zaretskii <eliz@gnu.org>
987
988 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
989 cursor overflow into the last glyph on display line when the right
990 fringe is off. (Bug#11832)
991
1a952767
PE
9922012-07-13 Paul Eggert <eggert@cs.ucla.edu>
993
994 * xdisp.c (produce_special_glyphs): Now static.
995 * dispextern.h (produce_special_glyphs): Remove decl.
996
983188fd
GM
9972012-07-13 Glenn Morris <rgm@gnu.org>
998
32fb4bb6
GM
999 * s/bsd-common, s/cygwin.h: Remove empty files.
1000 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1001
983188fd
GM
1002 * s/usg5-4-common.h (USG, USG5):
1003 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1004 * s/sol2-6.h (SOLARIS2):
1005 * s/irix6-5.h (IRIX6_5):
1006 * s/hpux10-20.h (USG, USG5, HPUX):
1007 * s/gnu-linux.h (USG, GNU_LINUX):
1008 * s/freebsd.h (BSD_SYSTEM):
1009 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1010 * s/cygwin.h (CYGWIN):
1011 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1012 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1013
d1e68667 10142012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1015
1016 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1017
6de0e799
GM
10182012-07-13 Glenn Morris <rgm@gnu.org>
1019
739ae010
GM
1020 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1021
dbee5793
GM
1022 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1023
6de0e799
GM
1024 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1025 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1026
b82da769
GM
10272012-07-12 Glenn Morris <rgm@gnu.org>
1028
4fae5a7a 1029 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1030
1031 * process.c (init_process_emacs): Rename from init_process.
1032 The old name is also the name of a Mach system call.
1033 * lisp.h, emacs.c: Update for this name change.
1034 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1035 longer needed.
1036
5a979817
EZ
10372012-07-12 Eli Zaretskii <eliz@gnu.org>
1038
1039 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1040 memmove call that removes glyphs covered by the left truncation
1041 glyph. Improve commentary.
1042 (display_line): Fix display of continuation glyphs on GUI frames
1043 when the right fringe is turned off and variable-size fonts are
1044 used in the window. Move the code that appends a stretch glyph to
1045 produce_special_glyphs, so that it could be used for truncation
1046 and continuation glyphs alike.
1047 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1048 glyph of a suitably computed width, to align the special glyphs at
1049 the window margin. Code moved from display_line. (Bug#11832)
1050
3e91a053
GM
10512012-07-12 Glenn Morris <rgm@gnu.org>
1052
ba9e4b84
GM
1053 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1054
1055 * s/gnu-linux.h, s/hpux10-20.h:
1056 Do not unconditionally define HAVE_XRMSETDATABASE.
1057
3e91a053
GM
1058 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1059
b300b1f4
PE
10602012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 Fix typos that broke OS X build.
1063 Reported by Randal L. Schwartz in
1064 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1065 * nsterm.m (ns_timeout): Add missing local decl.
1066 (ns_get_color): snprintf -> sprintf, to fix typo.
1067
6e777848
GM
10682012-07-12 Glenn Morris <rgm@gnu.org>
1069
3f922c37
GM
1070 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1071 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1072 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1073 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1074
0ab7b23a
GM
1075 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1076 Move PTY_OPEN to configure.
1077
6e777848
GM
1078 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1079 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1080 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1081
4a7edc24
DA
10822012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1083
1084 Use empty_unibyte_string where applicable.
1085 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1086 * lread.c (read1): Likewise.
1087 * xsettings.c (syms_of_xsettings): Likewise.
1088
308aab79
GM
10892012-07-12 Glenn Morris <rgm@gnu.org>
1090
42bd1719
GM
1091 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1092 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1093 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1094 * s/hpux10-20.h (RUN_TIME_REMAP):
1095 * s/bsd-common.h (TABDLY): Move to configure.
1096
1097 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1098
1099 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1100
ea0bbd17 1101 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1102 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1103
1104 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1105
308aab79
GM
1106 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1107 * s/template.h: Move NARROWPROTO to configure.
1108
ee1cf5cf
GM
11092012-07-11 Glenn Morris <rgm@gnu.org>
1110
30fe9bf4
GM
1111 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1112 unused since 2011-01-17 change to systty.h.
1113
ee1cf5cf
GM
1114 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1115 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1116 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1117
63e47e07
PE
11182012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1121
c43fb4c3
GM
11222012-07-11 Glenn Morris <rgm@gnu.org>
1123
1124 * s/darwin.h, s/gnu-linux.h, s/template.h:
1125 Move INTERRUPT_INPUT to configure.
1126
e8df9267
DA
11272012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1128
1129 Minor adjustments to interning code.
1130 * lisp.h (intern, intern_c_string): Redefine as static inline
1131 wrappers for intern_1 and intern_c_string_1, respectively.
1132 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1133 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1134 Vobarray checking.
e8df9267
DA
1135 * font.c (font_intern_prop): Likewise. Adjust comment.
1136 * w32font.c (intern_font_name): Likewise.
1137
34348bd4
AS
11382012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1139
d96a1e0c
AS
1140 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1141
34348bd4
AS
1142 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1143 of Fcar/Fcdr if possible.
1144 * font.c (check_otf_features): Likewise.
1145 * fontset.c (Fnew_fontset): Likewise.
1146 * gnutls.c (Fgnutls_boot): Likewise.
1147 * minibuf.c (read_minibuf): Likewise.
1148 * msdos.c (IT_set_frame_parameters): Likewise.
1149 * xmenu.c (Fx_popup_dialog): Likewise.
1150 * w32menu.c (Fx_popup_dialog): Likewise.
1151
c8add24e
GM
11522012-07-11 Glenn Morris <rgm@gnu.org>
1153
4b575b3c
GM
1154 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1155 since nothing has defined it on these platforms.
1156
09f4e3b0
GM
1157 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1158 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1159
172bedef
GM
1160 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1161 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1162 Move CLASH_DETECTION to configure.
1163
249685df
GM
1164 * s/gnu.h: Remove file, which is now empty.
1165
c8add24e
GM
1166 * s/gnu.h, s/gnu-linux.h:
1167 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1168
b41253a3
JW
11692012-07-11 John Wiegley <johnw@newartisans.com>
1170
1171 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1172 function attribute, so we only use it if it exists in the
1173 compiler.
1174
d923b542
DA
11752012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1176
1177 Avoid call to strlen in fast_c_string_match_ignore_case.
1178 * search.c (fast_c_string_match_ignore_case): Change to use
1179 length argument. Adjust users accordingly.
1180 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1181
5ebbef1d
PE
11822012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1183
bb352260
PE
1184 Assume mkdir, rmdir.
1185 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1186 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1187
57054ddd
PE
1188 Assume rename.
1189 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1190
b747d3f7
PE
1191 Assume perror.
1192 * s/hpux10-20.h (HAVE_PERROR): Remove.
1193 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1194 Remove dummy definition, as this problem was obsolete long ago.
1195
5ebbef1d
PE
1196 Assume strerror.
1197 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1198
984e7f30
DA
11992012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1200
1201 Avoid calls to strlen in font processing functions.
1202 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1203 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1204 users accordingly.
d923b542
DA
1205 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1206 Adjust prototypes.
1207 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1208 Change to return ptrdiff_t.
984e7f30
DA
1209 (xfont_list_pattern, xfont_match): Use length returned by
1210 xfont_decode_coding_xlfd.
1211 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1212
20e94fdd
GM
12132012-07-11 Glenn Morris <rgm@gnu.org>
1214
9d596af3
GM
1215 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1216 Move DONT_REOPEN_PTY to configure.
1217
20e94fdd
GM
1218 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1219 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1220
e99a530f
PE
12212012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1222
22ffb973
PE
1223 Remove "#define unix" that is no longer needed (Bug#11905).
1224 * s/aix4-2.h (unix): Remove; no longer needed.
1225
e9a9ae03
PE
1226 EMACS_TIME simplification (Bug#11875).
1227 This replaces macros (which typically do not work in GDB)
1228 with functions, typedefs and enums, making the code easier to debug.
1229 The functional style also makes code easier to read and maintain.
1230 * systime.h: Include <sys/time.h> on all hosts, not just if
1231 WINDOWSNT, since 'struct timeval' is needed in general.
1232 (EMACS_TIME): Now a typedef, not a macro.
1233 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1234 not macros.
1235 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1236 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1237 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1238 (EMACS_TIME_LE): Now functions, not macros.
1239 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1240 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1241 which are not functions. All uses rewritten to use:
1242 (make_emacs_time): New function.
1243 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1244 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1245 not functions. All uses rewritten to use the following, respectively:
1246 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1247 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1248 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1249 * fileio.c (Fcopy_file):
1250 * xterm.c (XTflash): Get the current time closer to when it's used.
1251 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1252
ffacb126
PE
1253 * bytecode.c (targets): Suppress -Woverride-init warnings.
1254
e99a530f
PE
1255 Simplify by avoiding confusing use of strncpy etc.
1256 * doc.c (Fsnarf_documentation):
1257 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1258 * frame.c (Fmake_terminal_frame):
1259 * gtkutil.c (get_utf8_string):
1260 * lread.c (openp):
1261 * nsmenu.m (ns_update_menubar):
1262 * regex.c (regerror):
1263 Prefer memcpy to strncpy and strncat when either will do.
1264 * fileio.c (Fsubstitute_in_file_name):
1265 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1266 (menu_separator_name_p):
1267 * nsmenu.m (ns_update_menubar):
1268 Prefer memcmp to strncmp when either will do.
1269 * nsterm.m: Include <ftoastr.h>.
1270 (ns_get_color):
1271 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1272 Prefer snprintf to strncpy.
1273 * nsterm.m (ns_term_init):
1274 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1275 * nsterm.m (ns_term_init):
1276 Avoid the need for strncpy, by using build_string or
1277 make_unibyte_string directly. Use dtoastr, not snprintf.
1278 * process.c (Fmake_network_process): Diagnose service names that
1279 are too long, rather than silently truncating them or creating
1280 non-null-terminated names.
1281 (Fnetwork_interface_info): Likewise, for interface names.
1282 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1283 Prefer sprintf to strncat.
1284 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1285 Prefer vsnprintf to vsprintf + strncpy.
1286
c59592b3
GM
12872012-07-10 Glenn Morris <rgm@gnu.org>
1288
1289 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1290 Clarify fallback case.
1291
7d7bbefd
DA
12922012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1293
1294 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1295 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1296 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1297 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1298 where argument type is known to be a Lisp_Cons.
1299
3a4c8000
TT
13002012-07-10 Tom Tromey <tromey@redhat.com>
1301
1302 * bytecode.c (BYTE_CODE_THREADED): New macro.
1303 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1304 (enum byte_code_op): New type.
1305 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1306 (exec_byte_code): Use them. Use token threading when applicable.
1307
2a0213a6
DA
13082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1309
1310 Optimize pure C strings initialization.
1311 * lisp.h (make_pure_string): Fix prototype.
1312 (build_pure_c_string): New function, defined as static inline. This
1313 provides a better opportunity to optimize away calls to strlen when
1314 the function is called with compile-time constant argument.
1315 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1316 argument, adjust users accordingly. Use build_pure_c_string where
1317 appropriate.
1318 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1319 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1320 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1321
cb1caeaf
DA
13222012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1323
1324 Avoid calls to strlen in miscellaneous functions.
1325 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1326 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1327 * lread.c (openp): Likewise.
1328
c293e30c
DA
13292012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1330
1331 Avoid calls to strlen in path processing functions.
1332 * fileio.c (file_name_as_directory): Add comment. Change to add
1333 srclen argument and return the length of result. Adjust users
1334 accordingly.
1335 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1336 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1337 users accordingly.
1338 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1339
9e059e3f
GM
13402012-07-10 Glenn Morris <rgm@gnu.org>
1341
d02eb359
GM
1342 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1343 Move PENDING_OUTPUT_COUNT definition to configure.
1344
882cf227
GM
1345 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1346 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1347 * s/gnu.h (DATA_START): Move definitions to configure.
1348
af6e839f
GM
1349 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1350 We include usg5-4-common.h, which defines them both.
1351
40289a12
GM
1352 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1353 O_RDONLY already includes it).
1354
9e059e3f
GM
1355 Stop ns builds setting the EMACSLOADPATH environment variable.
1356 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1357 Now it does not set EMACSLOADPATH, just returns the load-path string.
1358 * nsterm.h: Update accordingly.
1359 * lread.c [HAVE_NS]: Include nsterm.h.
1360 (init_lread) [HAVE_NS]: Use ns_load_path.
1361 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1362
7c4e8ec0
GM
13632012-07-09 Glenn Morris <rgm@gnu.org>
1364
d4f600ff
GM
1365 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1366 since the included bsd-common.h does so.
1367
cbb31951
GM
1368 Stop ns builds setting the EMACSPATH environment variable.
1369 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1370 (ns_init_paths): Do not set EMACSPATH.
1371 * nsterm.h (ns_exec_path): Add it.
1372 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1373 Use ns_exec_path.
1374
7c4e8ec0
GM
1375 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1376
26bccfae
PE
13772012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1378
a0bee46f
PE
1379 * process.c (wait_reading_process_output): 'waitchannels' was unset
1380 when read_kbd || !NILP (wait_for_cell); fix this.
1381
5994c183
PE
1382 Add GCC-style 'const' attribute to functions that can use it.
1383 * character.h (char_resolve_modifier_mask):
1384 * keyboard.h (make_ctrl_char):
1385 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1386 (init_character_once, next_almost_prime, init_fns, init_image)
1387 (flush_pending_output, init_sound):
1388 * mem-limits.h (start_of_data):
1389 * menu.h (finish_menu_items):
1390 Add ATTRIBUTE_CONST.
1391 * emacs.c (DEFINE_DUMMY_FUNCTION):
1392 Declare the dummy function with ATTRIBUTE_CONST.
1393 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1394 Add decls with ATTRIBUTE_CONST.
1395
26bccfae
PE
1396 Minor improvements to make_formatted_string.
1397 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1398 where int is good enough, as vsprintf returns an int.
1399 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1400
a8290ec3
DA
14012012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 Use make_formatted_string to avoid double length calculation.
1404 * lisp.h (make_formatted_string): New prototype.
1405 * alloc.c (make_formatted_string): New function.
1406 * buffer.c (Fgenerate_new_buffer_name): Use it.
1407 * dbus.c (syms_of_dbusbind): Likewise.
1408 * editfns.c (Fcurrent_time_zone): Likewise.
1409 * filelock.c (get_boot_time): Likewise.
1410 * frame.c (make_terminal_frame, set_term_frame_name)
1411 (x_report_frame_params): Likewise.
1412 * image.c (gs_load): Likewise.
1413 * minibuf.c (get_minibuffer): Likewise.
1414 * msdos.c (dos_set_window_size): Likewise.
1415 * process.c (make_process): Likewise.
1416 * xdisp.c (ensure_echo_area_buffers): Likewise.
1417 * xsettings.c (apply_xft_settings): Likewise.
1418
d01ba2f1
GM
14192012-07-09 Glenn Morris <rgm@gnu.org>
1420
1421 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1422 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1423 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1424 * nsterm.h (ns_etc_directory): Add it.
1425 * callproc.c [HAVE_NS]: Include nsterm.h.
1426 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1427
f1f924b6
DA
14282012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1429
1430 Move marker debugging code under MARKER_DEBUG.
1431 * marker.c (MARKER_DEBUG): Move marker debugging code under
1432 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1433 for bootstrap with --enable-checking (~3x slowdown reported
1434 by Juanma Barranquero <lekktu@gmail.com>).
1435 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1436
ab531b66
PE
14372012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1438
1439 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1440 See <http://bugs.gnu.org/11825#29>.
1441
c4b3bc8a
EZ
14422012-07-08 Eli Zaretskii <eliz@gnu.org>
1443
1444 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1445 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1446 (display_line): Add commentary about displaying truncation glyphs
1447 on GUI frames.
1448 (produce_special_glyphs): Move here from term.c.
1449
1450 * term.c (produce_special_glyphs): Move to xdisp.c.
1451
1452 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1453 section.
c4b3bc8a 1454
b676b881
AS
14552012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1456
f17c5273
AS
1457 * xdisp.c (display_line): Avoid warning about implicit declaration
1458 of FRAME_FONT.
1459
298819b9
AS
1460 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1461
b676b881
AS
1462 * lisp.h: Remove empty conditional.
1463
6045c4fd
PE
14642012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1465
b3350bf9
PE
1466 * lread.c (load_path_check): Now static.
1467
6045c4fd
PE
1468 Fix some minor --with-ns problems found by static checking.
1469 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1470 (x_set_font) [!HAVE_X_WINDOWS]:
1471 * image.c (xpm_load_image) [HAVE_NS]:
1472 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1473 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1474 Remove unused local.
1475 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1476 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1477 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1478 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1479 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1480 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1481 Fix pointer signedness problem.
1482 * xfaces.c (FRAME_X_FONT_TABLE):
1483 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1484
929e7845
GM
14852012-07-07 Glenn Morris <rgm@gnu.org>
1486
1487 * lread.c (load_path_check): New function, split from init_lread.
1488 (init_lread): Reorganize. Motivation:
1489 If EMACSLOADPATH is set, check/warn about that rather than the
1490 defaults, which we are not going to use. Hence we can remove
1491 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1492 Don't warn if site-lisp directories are missing.
1493 If not installed, start from a blank load-path, since
1494 PATH_LOADSEARCH refers to the eventual installation directories.
1495
58dd0aa4
EZ
14962012-07-07 Eli Zaretskii <eliz@gnu.org>
1497
1498 Support truncation and continuation glyphs on GUI frames, when
1499 fringes are disabled. (Bug#11832)
1500 * xdisp.c (init_iterator): Get dimensions of truncation and
1501 continuation glyphs even if on GUI frames. Adjust
1502 it->last_visible_x on GUI frames when the left or right fringes,
1503 or both, are absent.
1504 (start_display, move_it_in_display_line_to): Handle the case of a
1505 GUI frame without a fringe to display continuation or truncation
1506 glyphs.
1507 (insert_left_trunc_glyphs): Support GUI frames: make sure
1508 truncation glyphs overwrite enough glyphs from the current line to
1509 have sufficient space in pixels.
1510 (display_line): Support truncation and continuation glyphs on GUI
1511 frames. If some spare pixels are left on the line after inserting
1512 the truncation glyphs, fill that space with a stretch glyph of a
1513 suitably computed width.
1514
1515 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1516 produce_glyphs, to support GUI sessions.
1517
31571fd7
PE
15182012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1519
5a16b9bc
PE
1520 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1521
f3047c75
PE
1522 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1523
31571fd7
PE
1524 Do not require float-time's arg to fit in time_t (Bug#11825).
1525 This works better on hosts where time_t is unsigned, and where
1526 float-time is applied to the (negative) difference between two times.
1527 * editfns.c (decode_time_components): Last arg is now double *,
1528 not int *, and means to store all the result as a double, without
1529 worrying about whether the seconds part fits in time_t.
1530 All callers changed.
1531 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1532 All callers changed.
1533 (Ffloat_time): Do not fail merely because the specified time falls
1534 outside of time_t range.
1535
4516fbef
GM
15362012-07-07 Glenn Morris <rgm@gnu.org>
1537
1538 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1539 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1540 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1541
07adc2c6
JB
15422012-07-07 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1545 Update dependencies.
1546
1547 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1548
fd573f31
PE
15492012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1550
fee5959d
PE
1551 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1552 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1553 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1554 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1555 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1556 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1557
fd573f31
PE
1558 * xfont.c (compare_font_names): Redo to omit the need for casts.
1559
ddadbc0e
AS
15602012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1561
fca8d6b6
AS
1562 * xfns.c (Fx_change_window_property): Doc fix.
1563 * w32fns.c (Fx_change_window_property): Doc fix.
1564
ddadbc0e
AS
1565 * w32fns.c (Fx_window_property): Accept the same arguments as the
1566 X Windows version. Doc fix.
1567 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1568
ed9265fc 15692012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1570 Eli Zaretskii <eliz@gnu.org>
1571
1572 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1573 Windows-specific code from nt/config.nt moved here.
1574 Obsolete settings removed.
1575
216ee680
PE
15762012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1577
1578 * process.c: Avoid unnecessary calls to gettime.
1579 (wait_reading_process_output): Don't get the time of day
1580 when gobbling data immediately and not waiting, as there's no need
1581 for it in that case. This removes a FIXME.
1582
bdd091e4
JD
15832012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1584
1585 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1586 is defined (Bug#11768).
1587
9d44f8ce
DA
15882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1589
1590 Fix marker debugging code.
1591 * marker.c (byte_char_debug_check): Do not perform the check
1592 if buffer is not multibyte.
090bd7cb
JB
1593 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1594 Call byte_char_debug_check with correct arguments.
9d44f8ce 1595
90fc4786
DA
15962012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1597
1598 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1599 * marker.c (byte_char_debug_check, count_markers):
1600 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1601 (byte_debug_flag): Remove.
1602 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1603 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1604
7b7ae965
DA
16052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1606
4e57b342
DA
1607 Avoid code repetition in marker-related functions.
1608 * marker.c (attach_marker): New function.
1609 (Fset_marker, set_marker_restricted, set_marker_both)
1610 (set_marker_restricted_both): Use it.
1611 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1612 Consistently rename charno to charpos.
1613 (marker_position): Add eassert.
1614 (marker_byte_position): Convert to eassert.
1615
16162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1617
1618 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1619 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1620 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1621
657924ff
DA
16222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1623
1624 Introduce fast path for the widely used marker operation.
1625 * alloc.c (build_marker): New function.
1626 * lisp.h (build_marker): New prototype.
1627 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1628 * composite.c (autocmp_chars): Likewise.
1629 * editfns.c (buildmark): Remove.
1630 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1631 (save_restriction_save): Use build_marker.
1632 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1633 * window.c (save_window_save): Likewise.
1634
041a49a6
DA
16352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 Do not use Fdelete_overlay in delete_all_overlays
1638 to avoid redundant calls to unchain_overlay.
1639 * buffer.c (drop_overlay): New function.
1640 (delete_all_overlays, Fdelete_overlay): Use it.
1641 * minibuf.c (get_minibuffer): Fix comment.
1642
7dca65a4
PE
16432012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 Port to OpenBSD 5.1 amd64.
1646 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1647 This is needed for OpenBSD, and should be harmless on all BSD systems.
1648 Also, include <sys/sysctl.h>, as it should be available on all
1649 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1650 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1651 use p_pid member, not kp_proc.pid.
1652
8eb876e2
GM
16532012-07-06 Glenn Morris <rgm@gnu.org>
1654
1655 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1656
38182d90
PE
16572012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 More xmalloc and related cleanup.
1660 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1661 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1662 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1663 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1664 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1665 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1666 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1667 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1668 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1669 * xterm.c:
1670 Omit needless casts involving void * pointers and allocation.
1671 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1672 as the former is more robust if P's type is changed.
1673 Prefer xzalloc to xmalloc + memset 0.
1674 Simplify malloc-or-realloc to realloc.
1675 Don't worry about xmalloc returning a null pointer.
1676 Prefer xstrdup to xmalloc + strcpy.
1677 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1678 growing it.
1679 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1680 alloca of a constant.
1681
6dd5a677
EZ
16822012-07-05 Eli Zaretskii <eliz@gnu.org>
1683
1684 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1685 hscroll is larger than the line width. Fixes long and futile
1686 looping inside extend_face_to_end_of_line (on a TTY) producing
1687 glyphs that are not needed and thrown away.
1688
6b312f0f
DA
16892012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1690
1691 * marker.c (set_marker_restricted_both): Simplify by using
1692 clip_to_bounds.
1693
f520ef9b
PE
16942012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1695
1696 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1697
383b7c95
JD
16982012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1699
1700 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1701 not defined (Bug#11768).
1702 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1703 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1704 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1705 followed by gtk_box_set_homogeneous (Bug#11768).
1706 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1707 (update_theme_scrollbar_width, xg_create_scroll_bar):
1708 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1709 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1710 (is_box_type): New function (Bug#11768).
1711 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1712 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1713 with default display (Bug#11768).
1714
d6e7bf45
EZ
17152012-07-05 Eli Zaretskii <eliz@gnu.org>
1716
1717 * xdisp.c (window_hscroll_limited): New function.
1718 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1719 coordinates when window's hscroll is set to insanely large
1720 values. (Bug#11857)
1721
431391ec
JB
17222012-07-05 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1725 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1726
23f86fce
DA
17272012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1728
1729 Cleanup xmalloc.
1730 * lisp.h (xzalloc): New prototype. Omit needless casts.
1731 * alloc.c (xzalloc): New function. Omit needless casts.
1732 * charset.c: Omit needless casts. Convert all calls to
1733 xmalloc with following memset to xzalloc.
1734 * dispnew.c: Likewise.
1735 * fringe.c: Likewise.
1736 * image.c: Likewise.
1737 * sound.c: Likewise.
1738 * term.c: Likewise.
1739 * w32fns.c: Likewise.
1740 * w32font.c: Likewise.
1741 * w32term.c: Likewise.
1742 * xfaces.c: Likewise.
1743 * xfns.c: Likewise.
1744 * xterm.c: Likewise.
1745 * atimer.c: Omit needless casts.
1746 * buffer.c: Likewise.
1747 * callproc.c: Likewise.
1748 * ccl.c: Likewise.
1749 * coding.c: Likewise.
1750 * composite.c: Likewise.
1751 * doc.c: Likewise.
1752 * doprnt.c: Likewise.
1753 * editfns.c: Likewise.
1754 * emacs.c: Likewise.
1755 * eval.c: Likewise.
1756 * filelock.c: Likewise.
1757 * fns.c: Likewise.
1758 * gtkutil.c: Likewise.
1759 * keyboard.c: Likewise.
1760 * lisp.h: Likewise.
1761 * lread.c: Likewise.
1762 * minibuf.c: Likewise.
1763 * msdos.c: Likewise.
1764 * print.c: Likewise.
1765 * process.c: Likewise.
1766 * region-cache.c: Likewise.
1767 * search.c: Likewise.
1768 * sysdep.c: Likewise.
1769 * termcap.c: Likewise.
1770 * terminal.c: Likewise.
1771 * tparam.c: Likewise.
1772 * w16select.c: Likewise.
1773 * w32.c: Likewise.
1774 * w32reg.c: Likewise.
1775 * w32select.c: Likewise.
1776 * w32uniscribe.c: Likewise.
1777 * widget.c: Likewise.
1778 * xdisp.c: Likewise.
1779 * xmenu.c: Likewise.
1780 * xrdb.c: Likewise.
1781 * xselect.c: Likewise.
1782
0497dc44
PE
17832012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1784
1785 * fileio.c (time_error_value): Check the right error number.
1786 Problem reported by Troels Nielsen in
1787 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1788
356e7178
PE
17892012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1790
4e71fd89
PE
1791 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1792 This should be fixed in a better way; see Eli Zaretskii in
1793 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1794 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1795
f0941253
PE
1796 * fileio.c (time_error_value): Rename from special_mtime.
1797 The old name's problems were noted by Eli Zaretskii in
1798 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1799
065c9eb4
PE
1800 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1801 This variable's comment says Emacs needs at least one GDB-visible
1802 symbol of type enum pvec_type, to work around GDB problems.
1803 The symbol's value doesn't matter.
1804
356e7178
PE
1805 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1806 that causes compilation to fail on pre-C99 compilers.
1807
ed9265fc 18082012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1809
1810 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1811 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1812
3884d954
DA
18132012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1814
d209e2fb 1815 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1816 headers for buffer_defaults and buffer_local_symbols.
1817 Reported by Juanma Barranquero <lekktu@gmail.com>.
1818
ee28be33
SM
18192012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1820
1821 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1822 * lisp.h (enum pvec_type): Use fewer bits.
1823 (PSEUDOVECTOR_SIZE_BITS): New constant.
1824 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1825 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1826 change in pvec_type.
1827 (PSEUDOVECTOR_TYPEP): New macro.
1828 (TYPED_PSEUDOVECTORP): Use it.
1829 * fns.c (internal_equal): Adapt code to extract pvectype.
1830 * emacs.c (gdb_pvec_type): Update type.
1831 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1832 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1833 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1834 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1835 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1836 abusing vector->header.next.nbytes.
1837 (live_vector_p): Use PVEC_TYPE.
1838 (mark_object): Adapt code to extract pvectype. Use switch.
1839
c7f2cd7f
PE
18402012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1841
1842 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1843 Tighten new eassert a bit.
1844
8ce70ed2
DA
18452012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1846
1847 Fix compilation with --enable-gcc-warnings and -O1
1848 optimization level.
1849 * doprnt.c (doprnt): Change type of tem to int, initialize
1850 to avoid compiler warning. Add eassert.
1851 * search.c (simple_search): Initialize match_byte to avoid
1852 compiler warning. Add eassert.
1853
dea7f1e5
PE
18542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1855
24a212eb
PE
1856 Avoid weird behavior with large horizontal scrolls.
1857 Without this change, for example, large hscroll values would
1858 mess up Emacs's display on Fedora 15 x86, presumably due to
1859 overflows in int calculations in the display code.
1860 Also, if buffers had long lines, Emacs would freeze.
1861 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1862 (set_window_hscroll): New function, containing the old guts of
1863 Fset_window_hscroll. Return the clipped value.
1864 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1865 This avoids the need to check against PTRDIFF_MAX.
1866
dea7f1e5
PE
1867 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1868
76046526
DA
18692012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1870
1871 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1872
39adff0d
PE
18732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1874
63807d47
PE
1875 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1876 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1877 since GCC 4.4.6 issues a bogus warning for them.
1878
39adff0d
PE
1879 Fix bugs in file timestamp newness comparisons.
1880 * fileio.c (Ffile_newer_than_file_p):
1881 * lread.c (Fload): Use full timestamp resolution of files,
1882 not just the 1-second resolution, so that files that are only
1883 slightly newer still count as newer.
1884 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1885 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1886
dbeed9a6
PE
18872012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1888
1889 * fileio.c: Improve handling of file time marker. (Bug#11852)
1890 (special_mtime): New function.
1891 (Finsert_file_contents, Fverify_visited_file_modtime):
1892 Use it to set special mtime values consistently.
1893
636334d6
AS
18942012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1895
1896 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1897 marker for non-existing file. (Bug#11852)
1898
e2017fe2
GM
18992012-07-03 Glenn Morris <rgm@gnu.org>
1900
1901 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1902 and did not make it into globals.h).
1903
404dbd37
TT
19042012-07-03 Tom Tromey <tromey@redhat.com>
1905
1906 * window.c (Fset_window_margins, Fset_window_fringes)
1907 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1908 * textprop.c (Fprevious_property_change): No longer static.
1909 * syntax.c (Fsyntax_table_p): No longer static.
1910 * process.c (Fget_process, Fprocess_datagram_address): No longer
1911 static.
1912 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1913 * keyboard.c (Fcommand_execute): No longer static.
1914 Remove EXFUN.
1915 * insdel.c (Fcombine_after_change_execute): No longer static.
1916 * image.c (Finit_image_library): No longer static.
1917 * fileio.c (Fmake_symbolic_link): No longer static.
1918 * eval.c (Ffetch_bytecode): No longer static.
1919 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1920 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1921 No longer static.
404dbd37
TT
1922 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1923 static.
1924 * dired.c (Ffile_attributes): No longer static.
1925 * composite.c (Fcomposition_get_gstring): No longer static.
1926 * callproc.c (Fgetenv_internal): No longer static.
1927
1928 * ccl.h: Remove EXFUNs.
1929 * buffer.h: Remove EXFUNs.
1930 * dispextern.h: Remove EXFUNs.
1931 * intervals.h: Remove EXFUNs.
1932 * fontset.h: Remove EXFUN.
1933 * font.h: Remove EXFUNs.
1934 * dosfns.c (system_process_attributes): Remove EXFUN.
1935 * keymap.h: Remove EXFUNs.
1936 * lisp.h: Remove EXFUNs.
1937 * w32term.h: Remove EXFUNs.
1938 * window.h: Remove EXFUNs.
1939 * xsettings.h: Remove EXFUN.
1940 * xterm.h: Remove EXFUN.
1941
8e4fd1e1
GM
19422012-07-03 Glenn Morris <rgm@gnu.org>
1943
1944 * lisp.h (Frandom): Make it visible to C.
1945 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1946 buffer for invisible buffers. (Bug#1229)
1947
ca95b3eb
DA
19482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1949
1950 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1951 values which aren't power of 2.
1952 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1953 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1954 accordingly.
1955
7555c33f
SM
19562012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1957
1958 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1959
1960 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1961
d12e8f5a
DA
19622012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1963
1964 * alloc.c (allocate_vector_block): Remove redundant
1965 calls to mallopt if DOUG_LEA_MALLOC is defined.
1966 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1967 avoid calls to mallopt if zero_vector is returned.
1968
296094c3
DA
19692012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1970
1971 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1972 is enabled, avoid dereferencing NULL current_sblock if
1973 running undumped.
1974
36429c89
DA
19752012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1976
1977 Cleanup basic buffer management.
1978 * buffer.h (struct buffer): Change layout to use generic vector
1979 marking code. Fix some comments. Change type of 'clip_changed'
1980 to bitfield. Remove unused #ifndef old.
1981 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1982 (GET_OVERLAYS_AT): Fix indentation.
1983 (for_each_per_buffer_object_at): New macro.
1984 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1985 (Fbuffer_local_variables): Use it.
1986 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1987 * alloc.c (allocate_buffer): Adjust to match new layout of
1988 struct buffer. Fix comment.
1989 (mark_overlay): New function.
1990 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1991 Lisp area of struct buffer.
1992 (mark_object): Use it. Adjust marking of misc objects
1993 and related comments.
1994
3b3e4cac
PE
19952012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1996
1997 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1998 wrapper that is not needed because the wrapped code is a no-op (zero
1999 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2000 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2001
cf5c0175
DA
20022012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2003
2004 * alloc.c (mark_buffer): Simplify. Remove prototype.
2005 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2006 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2007 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2008 redundant calls to mark_vectorlike for bool vectors.
2009
ca26824c
GM
20102012-06-30 Glenn Morris <rgm@gnu.org>
2011
2e4c5312
GM
2012 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2013
ca26824c
GM
2014 * epaths.in (PATH_SITELOADSEARCH): New.
2015 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2016 This is rather than relying on --enable-locallisppath elements
2017 having "site-lisp" in their names. (Bug#10208#25, 11658)
2018
0d23c240
EZ
20192012-06-30 Eli Zaretskii <eliz@gnu.org>
2020
c9240d7a
EZ
2021 * w32proc.c (sys_select): Accept and ignore one more argument.
2022
2023 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2024
0d23c240 2025 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2026 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2027
2028 * sysdep.c: Don't include dos.h and dosfns.h.
2029
2030 * process.c (sys_select):
2031 * msdos.c (sys_select): Accept one more argument and ignore it.
2032
2033 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2034 adapt data types and code to that.
2035
2036 * dosfns.c:
2037 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2038 which clashes with the gnulib function of the same name.
2039
af5a5a98
AS
20402012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2041
c5e4379c
AS
2042 * font.c (font_style_to_value, font_style_symbolic)
2043 (font_prop_validate_style): Add type checks for values in
2044 font_style_table.
2045
af5a5a98
AS
2046 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2047 argument.
2048 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2049 uses.
2050
8d38f461
EZ
20512012-06-29 Eli Zaretskii <eliz@gnu.org>
2052
2e5a6631
EZ
2053 * xdisp.c (try_window_id): Undo last change.
2054
8d38f461
EZ
2055 * w32.c (getwd): Adjust commentary about startup_dir.
2056 (init_environment): Always call sys_access, even in non-MSVC
2057 builds. Don't chdir to the directory of the Emacs executable.
2058 This undoes code from 1997 which was justified by the need to
2059 "avoid conflicts when removing and renaming directories". But its
2060 downside was that every relative file name was being interpreted
2061 relative to the directory of the Emacs executable, which can never
2062 be TRT. In particular, it broke sys_access when called with
2063 relative file names.
2064 (sys_access): Map GetLastError to errno.
2065
2af3565e
DA
20662012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2067
2068 * window.h (struct window): Change type of 'fringes_outside_margins'
2069 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2070 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2071 Adjust comment.
2072 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2073 to ptrdiff_t.
2074
c8d3a25c 20752012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2076
c8d3a25c
GM
2077 * gnutls.c (emacs_gnutls_handshake):
2078 Add QUIT to make the loop interruptible.
57570cd3 2079
c8d3a25c 20802012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2081
c8d3a25c
GM
2082 * charset.c (init_charset): Make lack of etc/charsets fatal.
2083
3e984ee8
DA
20842012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2085
2086 * editfns.c (region_limit): Fix type mismatch.
2087
ef884f23
DA
20882012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2089
2090 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2091 undefined. Convert from xassert to eassert.
2092 * nsmenu.m: Convert from xassert to eassert.
2093 * nsterm.m: Likewise.
2094
7d7e0027
SM
20952012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2096
2097 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2098
aa754e6a
PE
20992012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 Avoid integer overflow on scroll-left and scroll-right.
2102 * window.c (HSCROLL_MAX): New macro.
2103 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2104 overflow when requested scroll falls outside ptrdiff_t range.
2105
80b00b08
DA
21062012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2107
2108 * window.h (struct window): Change type of 'hscroll',
2109 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2110 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2111 Adjust users accordingly.
2112 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2113 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2114 from EMACS_INT to ptrdiff_t.
2115 (make_window): Omit redundant initialization.
2116
62b2bcf6
JB
21172012-06-28 Juanma Barranquero <lekktu@gmail.com>
2118
2119 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2120
45942c7d
DA
21212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2122
2123 * window.h (struct window): Change type of 'use_time' and
2124 'sequence_number' from Lisp_Object to int.
2125 * frame.c (make_frame): Adjust users accordingly.
2126 * print.c (print_object): Likewise.
2127 * window.c (select_window, Fwindow_use_time, make_parent_window)
2128 (make_window): Likewise.
2129
e509cfa6
DA
21302012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2131
2132 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2133 enabled with --enable-checking=[all,glyphs] configure option.
2134 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2135 adjust comments accordingly.
2136 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2137 undefined, adjust comments accordingly.
2138 * image.c: Likewise.
2139 * scroll.c: Likewise.
2140 * w32fns.c: Likewise.
2141 * w32term.c: Likewise.
2142 * xdisp.c: Likewise.
2143 * xfaces.c: Likewise.
2144 * xfns.c: Likewise.
2145 * xterm.c: Likewise.
2146
a54e2c05
DA
21472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2148
2149 Generalize run-time debugging checks.
2150 * dispextern.h (XASSERTS): Remove.
2151 * fontset.c (xassert): Remove.
2152 Convert from xassert to eassert.
2153 * alloc.c: Convert from xassert to eassert.
2154 * bidi.c: Likewise.
2155 * dispnew.c: Likewise.
2156 * fns.c: Likewise.
2157 * fringe.c: Likewise.
2158 * ftfont.c: Likewise.
2159 * gtkutil.c: Likewise.
2160 * image.c: Likewise.
2161 * keyboard.c: Likewise.
2162 * menu.c: Likewise.
2163 * process.c: Likewise.
2164 * scroll.c: Likewise.
2165 * sound.c: Likewise.
2166 * term.c: Likewise.
2167 * w32console.c: Likewise.
2168 * w32fns.c: Likewise.
2169 * w32term.c: Likewise.
2170 * window.c: Likewise.
2171 * xdisp.c: Likewise.
2172 * xfaces.c: Likewise.
2173 * xfns.c: Likewise.
2174 * xselect.c: Likewise.
2175 * xterm.c: Likewise.
2176
1ec4b7b2
SM
21772012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * fns.c (maybe_resize_hash_table): Output message when growing the
2180 purify-hashtable.
2181
2014308a
DA
21822012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2183
2184 * alloc.c (allocate_string_data): Remove dead code.
2185 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2186 avoid GCC warning about unused macro.
2187
246155eb
DA
21882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2189
2190 * alloc.c (allocate_string): Omit intervals initialization.
2191 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2192 as in make_pure_string and make_pure_c_string.
2193
43184b7b
DA
21942012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2195
d209e2fb 2196 * alloc.c (allocate_string): Fix last change.
43184b7b 2197
3fe6dd74
DA
21982012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2199
d209e2fb 2200 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2201 to memset, add explicit initialization where appropriate.
2202
1ba6038a
GM
22032012-06-27 Glenn Morris <rgm@gnu.org>
2204
2205 * lisp.mk (lisp): Remove paths.elc.
2206
c89926a5
CY
22072012-06-27 Chong Yidong <cyd@gnu.org>
2208
2209 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2210
ed6b3510
JW
22112012-06-26 John Wiegley <johnw@newartisans.com>
2212
1ec4b7b2 2213 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2214 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2215
ed6b3510
JW
2216 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2217 when building with Clang.
2218
8edd4a2b
SM
22192012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2220
2221 * eval.c (Fapply): Allow calling it with a single argument.
2222
f6f62d1b
EZ
22232012-06-26 Eli Zaretskii <eliz@gnu.org>
2224
2225 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2226 _stricmp and _strnicmp.
2227 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2228
62efea5e
DA
22292012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2230
2231 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2232 allocated window.
2233 (allocate_process): Likewise for new process.
8edd4a2b 2234 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2235 (allocate_frame): Likewise.
2236 * frame.c (make_frame): Omit redundant initialization.
2237 * window.c (make_parent_window): Use memset.
2238 (make_window): Omit redundant initialization.
2239 * process.c (make_process): Omit redundant initialization.
2240 * terminal.c (create_terminal): Likewise.
2241
42997f4d
DA
22422012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2243
2244 * term.c (delete_tty): Remove redundant call to memset.
2245
1130ecfc
DA
22462012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2247
2248 * alloc.c: Remove build_string.
2249 * lisp.h: Define build_string as static inline. This provides
2250 a better opportunity to optimize away calls to strlen when the
2251 function is called with compile-time constant argument.
2252 * image.c (imagemagick_error): Convert to build_string.
2253 * w32proc.c (sys_spawnve): Likewise.
2254 * xterm.c (x_term_init): Likewise.
2255
cf38a720
PE
22562012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2257
99027bdd
PE
2258 Use sprintf return value instead of invoking strlen on result.
2259 In the old days this wasn't portable, since some sprintf
2260 implementations returned char *. But they died out years ago and
2261 Emacs already assumes sprintf returns int.
2262 Similarly for float_to_string.
2263 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2264 * ccl.c (ccl_driver):
2265 * character.c (string_escape_byte8):
2266 * data.c (Fnumber_to_string):
2267 * doprnt.c (doprnt):
2268 * print.c (print_object):
2269 * xdisp.c (message_dolog):
2270 * xfns.c (syms_of_xfns):
2271 Use sprintf or float_to_string result to avoid need to call strlen.
2272 * data.c (Fnumber_to_string):
2273 Use make_unibyte_string, since the string must be ASCII.
2274 * lisp.h, print.c (float_to_string): Now returns int length.
2275 * term.c (produce_glyphless_glyph):
2276 Use sprintf result rather than recomputing it.
2277
cf38a720
PE
2278 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2279 * Makefile.in (ALL_CFLAGS):
2280 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2281 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2282
3511c784
DA
22832012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2284
0a08eb21 2285 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2286 strcasecmp if available.
2287 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2288
fb7da12e
AS
22892012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2290
2291 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2292 Avoid comma operator.
2293 * menu.c (push_submenu_start, push_submenu_end)
2294 (push_left_right_boundary, push_menu_pane): Likewise.
2295 * msdos.c (dos_rawgetc): Likewise.
2296
afa2ffd8
DA
22972012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2298
2299 * xfns.c (xic_create_fontsetname): Remove redundant calls
2300 to memset.
2301
b3b4476b
PE
23022012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2303
4495ff38
PE
2304 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2305 sprintf already null-terminates its output.
2306
b3b4476b
PE
2307 * xfns.c (x_window): Remove redundant cast.
2308
b00876c9
DA
23092012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2310
2311 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2312 `const char *' to `char *' to avoid compiler warning.
2313
d188e26b
PE
23142012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2315
885d1d74
PE
2316 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2317 instead of truncating it to 63 (admittedly a generous limit).
2318
d188e26b
PE
2319 * process.c: Fix spelling and caps in comments.
2320
e2f560b1
DN
23212012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2322
e86db54b 2323 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2324 * sysdep.c (setpgrp): Remove definition, not used in this file.
2325
7583a3a1
JB
23262012-06-24 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * makefile.w32-in: Update dependencies.
2329
696056c2
EZ
23302012-06-24 Eli Zaretskii <eliz@gnu.org>
2331
2332 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2333 (SYSTIME_H): Add nt/inc/sys/time.h.
2334
2335 * systime.h [WINDOWSNT]: Include sys/time.h.
2336
2337 * s/ms-w32.h (struct timespec): Definition moved from
2338 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2339
845ca893
PE
23402012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2341
2342 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2343 * buffer.h (buffer_slot_type_mismatch):
2344 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2345 * eval.c (unwind_to_catch):
2346 * image.c (my_png_error, my_error_exit):
2347 * keyboard.c (quit_throw_to_read_char, user_error)
2348 (Fexit_recursive_edit, Fabort_recursive_edit):
2349 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2350 (wrong_type_argument, buffer_overflow, __executable_start)
2351 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2352 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2353 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2354 (fatal):
2355 (child_setup) [!DOS_NT]:
2356 * lread.c (end_of_file_error, invalid_syntax):
2357 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2358 * puresize.h (pure_write_error):
2359 * search.c (matcher_overflow):
2360 * sound.c (sound_perror, alsa_sound_perror):
2361 * sysdep.c, syssignal.h (croak):
2362 * term.c (maybe_fatal, vfatal):
2363 * textprop.c (text_read_only):
2364 * undo.c (user_error):
2365 * unexmacosx.c (unexec_error):
2366 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2367 Use _Noreturn rather than NO_RETURN.
2368 No need for separate decl merely because of _Noreturn.
2369 * sound.c (sound_warning, parse_sound):
2370 Remove unnecessary forward decls.
2371
f1dd8073
PE
23722012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2373
2374 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2375 * lisp.h (WAIT_READING_MAX): New macro.
2376 * dispnew.c (Fsleep_for, sit_for):
2377 * keyboard.c (kbd_buffer_get_event):
2378 * process.c (Faccept_process_output):
2379 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2380 This improves on the previous patch, which introduced a bug
2381 when time_t is unsigned and as wide as intmax_t.
2382 See <http://bugs.gnu.org/9000#51>.
2383
b82c1755
EZ
23842012-06-23 Eli Zaretskii <eliz@gnu.org>
2385
2386 * dispnew.c (sit_for, Fsleep_for):
2387 * keyboard.c (kbd_buffer_get_event):
2388 * process.c (Faccept_process_output): Avoid compiler warnings when
2389 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2390
ca300656
JB
23912012-06-23 Juanma Barranquero <lekktu@gmail.com>
2392
049ec95b
JB
2393 * makefile.w32-in: Update dependencies.
2394
ca300656
JB
2395 * w32.c (ltime): Add return type and declare static.
2396 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2397
db7b8d06
PE
23982012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2401 Privately reported by Herbert J. Skuhra.
2402 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2403 All uses changed.
2404 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2405 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2406
0bd8297f
EZ
24072012-06-23 Eli Zaretskii <eliz@gnu.org>
2408
96512555
EZ
2409 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2410 last argument of make_unibyte_string.
2411
0bd8297f
EZ
2412 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2413 language ID in the event parameters.
2414
2415 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2416 event.code, not the obscure "character set ID".
2417
63def6b6
CY
24182012-06-23 Chong Yidong <cyd@gnu.org>
2419
2420 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2421
e8a02204
EZ
24222012-06-23 Eli Zaretskii <eliz@gnu.org>
2423
388cdec0
EZ
2424 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2425 * w32.c (fdutimens): New function.
2426
2427 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2428
2429 * s/ms-w32.h (pselect): Redirect to sys_select.
2430
2431 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2432
e8a02204
EZ
2433 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2434 in the logic of incrementing and decrementing the value of
2435 use_relocatable_buffers.
2436
d054f3fb
PE
24372012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2440 Privately reported by Herbert J. Skuhra.
2441 [__FreeBSD__]: Remove "*/" typo after "#include".
2442 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2443 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2444 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2445 Don't assume EMACS_TIME and struct timeval are the same type.
2446
d35af63c
PE
24472012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 Support higher-resolution time stamps (Bug#9000).
2450 The time stamps are only nanosecond-resolution at the C level,
2451 since that's the best that any real-world system supports now.
2452 But they are picosecond-resolution at the Lisp level, as that's
2453 easy, and leaves room for future OS improvements.
2454
2455 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2456 (LIBES): Use it.
2457
2458 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2459 Don't get current time unless it's needed.
2460
2461 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2462 now provides it if it's absent.
2463 (start_atimer): Port to higher-res time stamps.
2464 Check for time stamp overflow. Don't get current time more
2465 often than is needed.
2466
2467 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2468 Include systime.h, not time.h.
2469 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2470
2471 * dired.c: Include stat-time.h.
2472 (Ffile-attributes): File times now have higher resolution.
2473
2474 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2475 (struct image): Timestamp now has higher resolution.
2476
2477 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2478 has at least microseconds now. All uses removed.
2479 (update_frame, update_single_window, update_window, update_frame_1)
2480 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2481
2482 * editfns.c (time_overflow): Now extern.
2483 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2484 (float-time, Fformat_time_string, Fcurrent_time_string)
2485 (Fcurrent_time_zone): Accept and generate higher-resolution
2486 time stamps.
2487 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2488 (decode_time_components, lisp_seconds_argument): New functions.
2489 (make_time): Now static.
2490 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2491 Report an error if the time is invalid, rather than having the caller
2492 do that.
2493
2494 * fileio.c: Include <stat-time.h>
2495 (Fcopy_file): Copy higher-resolution time stamps.
2496 Prefer to set the time stamp via a file descriptor if that works.
2497 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2498 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2499 (Fvisited_file_modtime, Fset_visited_file_modtime):
2500 Support higher-resolution time stamps.
2501
2502 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2503
2504 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2505
2506 * image.c (prepare_image_for_display, clear_image_cache)
2507 (lookup_image): Port to higer-resolution time stamps.
2508
2509 * keyboard.c (start_polling, bind_polling_period):
2510 Check for time stamp overflow.
2511 (read_char, kbd_buffer_get_event, timer_start_idle)
2512 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2513 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2514 Port to higher-resolution time stamps. Do not assume time_t is signed.
2515 (decode_timer): New function. Timers are now vectors of length 9,
2516 not 8, to accommodate the picosecond component.
2517 (timer_check_2): Use it.
2518
2519 * nsterm.m (select_timeout, timeval_subtract): Remove.
2520 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2521 as they're a bit more accurate and handle overflow better.
2522 (ns_select): Change prototype to be compatible with pselect.
2523 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2524 * nsterm.h (ns_select): Adjust prototype.
2525
2526 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2527 us-resolution time stamps.
2528 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2529
2530 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2531
2532 * lisp.h (time_overflow): New decl.
2533 (wait_reading_process_output): First arg is now intmax_t, not int,
2534 to accommodate larger waits.
2535
2536 * process.h (struct Lisp_Process.read_output_delay):
2537 Now counts nanoseconds, not microseconds.
2538 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2539 EMACS_HAS_USECS.
2540 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2541 (wait_reading_process_output):
2542 Port to ns-resolution time stamps.
2543 (Faccept_process_output, wait_reading_process_output):
2544 Check for time stamp overflow. Do not assume time_t is signed.
2545 (select_wrapper): Remove; we now use pselect.
2546 (Fprocess_attributes): Now generates ns-resolution time stamps.
2547
2548 * sysdep.c: Include utimens.h. Don't include utime.h
2549 or worry about struct utimbuf; gnulib does that for us now.
2550 (gettimeofday): Remove; gnulib provides a substitute.
2551 (make_timeval): New function.
2552 (set_file_times): Now sets ns-resolution time stamps.
2553 New arg FD; all uses changed.
2554 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2555 (system_process_attributes):
2556 Now returns ns-resolution time stamp. All uses changed.
2557 Check for time stamp overflow.
2558
2559 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2560 provides a substitute now.
2561
2562 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2563 since it guarantees struct timespec.
2564 (EMACS_TIME): Now struct timespec, so that we can support
2565 ns-resolution time stamps.
2566 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2567 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2568 (EMACS_USECS): Remove.
2569 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2570 so multiply the arg by 1000 before storing it.
2571 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2572 New macros.
2573 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2574 Port to ns-resolution time stamps.
2575 (EMACS_TIME_NEG_P): Remove; replaced by....
2576 (EMACS_TIME_SIGN): New macro.
2577 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2578 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2579 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2580 (make_timeval, make_lisp_time, decode_time_components): New decls.
2581 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2582 that it mishandled time_t overflow. You can't compare by subtracting!
2583 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2584 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2585
2586 * term.c: Include <sys/time.h>.
2587 (timeval_to_Time): New function, for proper overflow wraparound.
2588 (term_mouse_position, term_mouse_click): Use it.
2589
2590 * undo.c (record_first_change): Support higher-resolution time stamps
2591 in the undo buffer.
2592 (Fprimitive_undo): Use them when restoring time stamps.
2593
2594 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2595 (w32_get_internal_run_time):
2596 Port to higher-resolution Emacs time stamps.
2597 (ltime): Now accepts single 64-bit integer, as that's more convenient
2598 for callers.
2599
2600 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2601
2602 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2603 for compatibility with pselect. Support ns-resolution time stamps.
2604
2605 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2606
2607 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2608 Check for time stamp overflow, and support ns-resolution time stamps.
2609
2610 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2611 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2612 (timeval_subtract): Remove; no longer needed.
2613 (XTflash, XTring_bell, x_wait_for_event):
2614 Port to ns-resolution time stamps. Don't assume time_t is signed.
2615
b6a92dfe
CY
26162012-06-22 Chong Yidong <cyd@gnu.org>
2617
2618 * xdisp.c (x_consider_frame_title): Revert last change.
2619
d251c37c
EZ
26202012-06-22 Eli Zaretskii <eliz@gnu.org>
2621
2622 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2623 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2624 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2625 staticidx goes up to 1597 out of 1600 = 0x640.)
2626
f10deafb
PE
26272012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2630 Otherwise, the umask might be mistakenly 0 while handling input signals.
2631
ec6de1e2
SM
26322012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2633
2634 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2635
28be1ada
DA
26362012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2637
2638 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2639 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2640 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2641 access to `contents' member of Lisp_Vector objects with AREF and ASET
2642 where appropriate.
2643
c6bf3022
CY
26442012-06-19 Chong Yidong <cyd@gnu.org>
2645
2646 * frame.c (delete_frame): When selecting a frame on a different
2647 text terminal, do not alter the terminal's top-frame.
2648
2649 * xdisp.c (format_mode_line_unwind_data): Record the target
2650 frame's selected window and its terminal's top-frame.
2651 (unwind_format_mode_line): Restore them.
2652 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2653 Callers changed.
2654 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2655 since tty frames can be explicitly named.
2656 (prepare_menu_bars): Likewise.
2657
2658 * term.c (Ftty_top_frame): New function.
2659
defd4196
PE
26602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2661
2662 Port byte-code-meter to modern targets.
2663 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2664 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2665 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2666 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2667 (METER_1, METER_2): Simplify.
2668
1053a871
SM
26692012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2670
2671 * data.c (Fdefalias): Return `symbol' (bug#11686).
2672
b7e8d081
MR
26732012-06-18 Martin Rudalics <rudalics@gmx.at>
2674
2675 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2676 gets killed during executing of this function (Bug#11665).
2677 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2678 (Vkill_buffer_query_functions): In doc-string say that functions
2679 run by this hook should not change the current buffer.
2680
7ea2b339
PE
26812012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 Fix recently-introduced process.c problems found by static checking.
2684 * process.c (write_queue_push, write_queue_pop, send_process):
2685 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2686 (write_queue_pop): Fix pointer signedness problem.
2687 (send_process): Remove unused local.
2688
96a313a1
CY
26892012-06-17 Chong Yidong <cyd@gnu.org>
2690
2691 * xdisp.c (redisplay_internal): No need to redisplay terminal
2692 frames that are not on top.
2693
20ca2e94
TN
26942012-06-17 Troels Nielsen <bn.troels@gmail.com>
2695
2696 * process.c (make_process): Initialize write_queue.
2697 (write_queue_push, write_queue_pop): New functions.
2698 (send_process): Use them to maintain correct ordering of process
2699 writes (Bug#10815).
2700
9a900ca9
PE
27012012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2702
310fbfa8
PE
2703 * lisp.h (eassert): Assume C89 or later.
2704 This removes the need for CHECK.
2705 (CHECK): Remove. Its comments about always evaluating its
2706 argument were confusing, as 'eassert' typically does not evaluate
2707 its argument.
2708
27bb1ca4
PE
2709 * coding.c (produce_chars): Use ptrdiff_t, not int.
2710
9a900ca9
PE
2711 * xterm.c (x_draw_underwave): Check for integer overflow.
2712 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2713
41b7f8bc 27142012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2715
2716 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2717 referenced (Bug#11583).
2718
9b0e3eba
AA
27192012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2720
2721 Implement wave-style variant of underlining.
2722 * dispextern.h (face_underline_type): New enum.
2723 (face): Add field for underline type.
2724 * nsterm.m (ns_draw_underwave): New function.
2725 (ns_draw_text_decoration): Use it.
2726 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2727 New functions.
2728 (x_draw_glyph_string): Use them.
2729 * xfaces.c (Qline, Qwave): New Lisp objects.
2730 (check_lface_attrs, merge_face_ref)
1053a871
SM
2731 (Finternal_set_lisp_face_attribute, realize_x_face):
2732 Handle wave-style underline face attributes.
9b0e3eba
AA
2733 * xterm.c (x_draw_underwave): New function.
2734 (x_draw_glyph_string): Use it.
2735
0fb52f11
JB
27362012-06-16 Juanma Barranquero <lekktu@gmail.com>
2737
2738 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2739 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2740 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2741 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2742 ($(BLD)/w32select.$(O)): Update dependencies.
2743
e5560ff7
AS
27442012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2745
2746 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2747 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2748 * character.c (_fetch_multibyte_char_p): Remove.
2749 * alloc.c: Include "character.h" before "buffer.h".
2750 * bidi.c: Likewise.
2751 * buffer.c: Likewise.
2752 * bytecode.c: Likewise.
2753 * callint.c: Likewise.
2754 * callproc.c: Likewise.
2755 * casefiddle.c: Likewise.
2756 * casetab.c: Likewise.
2757 * category.c: Likewise.
2758 * cmds.c: Likewise.
2759 * coding.c: Likewise.
2760 * composite.c: Likewise.
2761 * dired.c: Likewise.
2762 * dispnew.c: Likewise.
2763 * doc.c: Likewise.
2764 * dosfns.c: Likewise.
2765 * editfns.c: Likewise.
2766 * emacs.c: Likewise.
2767 * fileio.c: Likewise.
2768 * filelock.c: Likewise.
2769 * font.c: Likewise.
2770 * fontset.c: Likewise.
2771 * fringe.c: Likewise.
2772 * indent.c: Likewise.
2773 * insdel.c: Likewise.
2774 * intervals.c: Likewise.
2775 * keyboard.c: Likewise.
2776 * keymap.c: Likewise.
2777 * lread.c: Likewise.
2778 * macros.c: Likewise.
2779 * marker.c: Likewise.
2780 * minibuf.c: Likewise.
2781 * nsfns.m: Likewise.
2782 * nsmenu.m: Likewise.
2783 * print.c: Likewise.
2784 * process.c: Likewise.
2785 * regex.c: Likewise.
2786 * region-cache.c: Likewise.
2787 * search.c: Likewise.
2788 * syntax.c: Likewise.
2789 * term.c: Likewise.
2790 * textprop.c: Likewise.
2791 * undo.c: Likewise.
2792 * unexsol.c: Likewise.
2793 * w16select.c: Likewise.
2794 * w32fns.c: Likewise.
2795 * w32menu.c: Likewise.
2796 * window.c: Likewise.
2797 * xdisp.c: Likewise.
2798 * xfns.c: Likewise.
2799 * xmenu.c: Likewise.
2800 * xml.c: Likewise.
2801 * xselect.c: Likewise.
2802
2f07e6af
EZ
28032012-06-16 Eli Zaretskii <eliz@gnu.org>
2804
1053a871
SM
2805 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2806 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2807 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2808 row.
2809 (handle_face_prop): Use chunk-relative overlay string index when
2810 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2811 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2812 the rightmost. (Bug#11720)
2f07e6af 2813
29b83cec
AS
28142012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2815
2816 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2817 (CATEGORY_MEMBER): Enforce 1/0 value.
2818 * category.c (_temp_category_set): Remove.
2819
4c5501e9
EZ
28202012-06-16 Eli Zaretskii <eliz@gnu.org>
2821
2822 * window.c (Fdelete_other_windows_internal)
2823 (Fdelete_window_internal): Don't access frame's mouse highlight
2824 info of the initial frame. (Bug#11677)
2825
2b570124
PE
28262012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2827
e93864f9
PE
2828 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2829 Assume USE_2_TAGS_FOR_INTS.
2830 (xreload): Adjust $tagmask width to match recent lisp.h change.
2831
2b570124
PE
2832 Simplify lisp.h in minor ways that should not affect code.
2833 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2834 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2835 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2836 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2837 (INTTYPEBITS): New macro, for clarity.
2838 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2839 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2840 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2841 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2842 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2843
81755f69
JB
28442012-06-13 Juanma Barranquero <lekktu@gmail.com>
2845
2846 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2847
16192a57
GM
28482012-06-13 Glenn Morris <rgm@gnu.org>
2849
2850 * s/bsd-common.h (BSD4_3):
2851 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2852
646b5f55
AS
28532012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2854
2855 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2856 instead of union.
2857 (XLI, XIL): Define.
1053a871
SM
2858 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2859 Use them.
2860 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2861 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2862 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2863 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2864 * frame.c (delete_frame): Remove outdated comment.
2865 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2866 USE_LISP_UNION_TYPE.
2867 (Fw32_unregister_hot_key): Likewise.
2868 (Fw32_toggle_lock_key): Likewise.
2869 * w32menu.c (add_menu_item): Likewise.
2870 (w32_menu_display_help): Use XIL instead of checking
2871 USE_LISP_UNION_TYPE.
2872 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2873 (init_heap): Likewise.
2874 * w32term.c (w32_read_socket): Update comment.
2875
1d3823c9
GM
28762012-06-13 Glenn Morris <rgm@gnu.org>
2877
c62ff706
GM
2878 * s/usg5-4-common.h, src/s/unixware.h:
2879 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2880
1d3823c9
GM
2881 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2882
bfe3e0a2
PE
28832012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2884
2885 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2886 * alloc.c (make_number) [!defined make_number]:
2887 Remove, as lisp.h always defines this now.
2888 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2889 (roundup_size): Verify that it is a power of 2.
2890 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2891 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2892 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2893 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2894 USE_LSB_TAG now is always defined to be either 0 or 1.
2895 All uses changed.
2896 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2897 code works fine either way, and efficiency is not a concern here,
2898 as the union type is for debugging, not for production.
2899 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2900 Use an inline function on all platforms when using the union type,
2901 since this is simpler and 'static inline' can be used portably
2902 within Emacs now.
2903 (LISP_INITIALLY_ZERO): New macro.
2904 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2905 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2906
45fa9c0f
GM
29072012-06-12 Glenn Morris <rgm@gnu.org>
2908
b4492cba
GM
2909 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2910
2911 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2912
45fa9c0f
GM
2913 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2914 Move BROKEN_SIGIO to configure.
2915
2916 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2917 Move NO_TERMIO to configure.
2918
0e25d334
CY
29192012-06-12 Chong Yidong <cyd@gnu.org>
2920
2921 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2922 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2923 MagickExportImagePixels is undefined.
2924
43682bb6
PE
29252012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2926
2927 * image.c (imagemagick_load_image): Remove unused label.
2928
a9be7d2b
GM
29292012-06-11 Glenn Morris <rgm@gnu.org>
2930
2931 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2932 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2933 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2934 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2935
3017f87f
SM
29362012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2937
2938 * alloc.c (make_byte_code): New function.
2939 (Fmake_byte_code): Use it. Don't purify here.
2940 * lread.c (read1): Use it as well to avoid extra allocation.
2941
1b9b4cf4
CY
29422012-06-11 Chong Yidong <cyd@gnu.org>
2943
2944 * image.c (imagemagick_load_image): Implement transparency.
2945
95988fcf
AS
29462012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2947
2948 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2949 account for preceding backslashes. (Bug#11663)
2950
cd4eb164
CY
29512012-06-09 Chong Yidong <cyd@gnu.org>
2952
2953 * term.c: Support italics in capable terminals (Bug#9652).
2954 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2955 (turn_on_face): Output using TS_enter_italic_mode if available.
2956 Don't handle unused blinking and alt-charset cases.
2957 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2958 and tty_alt_charset_p cases.
2959 (tty_capable_p, init_tty): Support italics.
2960
2961 * termchar.h (struct tty_display_info): Add field for italics.
2962 Remove unused blink field.
2963
2964 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2965 Handle slant.
2966
2967 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2968 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2969 tty_alt_charset_p. Add tty_italic_p.
2970
ff88beb8
MA
29712012-06-09 Michael Albinus <michael.albinus@gmx.de>
2972
2973 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2974 dbus_type_is_basic if available.
2975 (xd_extract_signed, xd_extract_unsigned): Rename from
2976 extract_signed and extract_unsigned, respectively. Adapt callers.
2977
44286096
CY
29782012-06-09 Chong Yidong <cyd@gnu.org>
2979
1682701f
CY
2980 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2981
44286096
CY
2982 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2983 case (Bug#9752).
2984
d86feb17
PE
29852012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2986
2987 * xdisp.c (vmessage): Treat frame message as multibyte.
2988 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2989 would generate the diagnostic "Making \302\247 buffer-local while
2990 let-bound!".
2991
d5c20fe8
EZ
29922012-06-08 Eli Zaretskii <eliz@gnu.org>
2993
2994 * dispnew.c (showing_window_margins_p): Undo last change, which
2995 was done due to an inadvertent commit.
2996 (adjust_frame_glyphs_for_frame_redisplay): Do call
2997 showing_window_margins_p.
2998
513749ee
SM
29992012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 * eval.c (Fmake_var_non_special): New primitive.
3002 (syms_of_eval): Defsubr it.
3003 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3004
d4a8f5c1
JB
30052012-06-08 Juanma Barranquero <lekktu@gmail.com>
3006
3007 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3008 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3009
8bbbc977
EZ
30102012-06-08 Eli Zaretskii <eliz@gnu.org>
3011
3012 * alloc.c (allocate_vectorlike): Fix last change.
3013
f3372c87
DA
30142012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3015
3016 Block-based vector allocation of small vectors.
3017 * lisp.h (struct vectorlike_header): New field `nbytes',
3018 adjust comment accordingly.
3019 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3020 to denote vector blocks. Adjust users (live_vector_p,
3021 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3022 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3023 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3024 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3025 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3026 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3027 (roundup_size): New constant.
3028 (struct vector_block): New data type.
3029 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3030 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3031 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3032 (sweep_vectors): New functions.
3033 (allocate_vectorlike): Return `zero_vector' as the only vector of
3034 0 items. Allocate new vector from block if vector size is less than
3035 or equal to VBLOCK_BYTES_MAX.
3036 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3037 (init_alloc_once): Add call to init_vectors.
3038
4f18a4ed
SM
30392012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3040
3041 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3042
86f158bc
PE
30432012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * doprnt.c (doprnt): Truncate multibyte char correctly.
3046 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3047 would mishandle a string argument "Xc" if X was a multibyte
3048 character of length 2: it would truncate after X's first byte
3049 rather than including all of X.
3050
c5cfcbe0
CY
30512012-06-06 Chong Yidong <cyd@gnu.org>
3052
3053 * buffer.c (word_wrap): Doc fix.
3054
c05cf390
PE
30552012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3056
3057 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3058
0c3461de
GM
30592012-06-03 Glenn Morris <rgm@gnu.org>
3060
3061 * xdisp.c (tool-bar-style): Doc fix.
3062
c71232db
UM
30632012-06-03 Ulrich Müller <ulm@gentoo.org>
3064
3065 * Makefile.in (PAXCTL): Define.
3066 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3067 binary via PaX flags if the paxctl utility is available.
3068 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3069 Restore PaX flags to their default. (Bug#11398)
3070
383f7350
CY
30712012-06-03 Chong Yidong <cyd@gnu.org>
3072
3073 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3074 buffer (Bug#11226).
3075
5f2c76c6
CY
30762012-06-03 Chong Yidong <cyd@gnu.org>
3077
3078 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3079 (note_mode_line_or_margin_highlight): If there is no help echo,
3080 use mode-line-default-help-echo. Handle the case where the mouse
3081 position is past the end of the mode line string.
3082
3083 * buffer.c (buffer_local_value_1): New function, split from
3084 Fbuffer_local_value; can return Qunbound.
3085 (Fbuffer_local_value): Use it.
3086 (Vmode_line_format): Docstring tweaks.
3087
773d47f6
PE
30882012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3089
3090 * sysdep.c (system_process_attributes): Improve comment.
3091
f2d6a3df
SM
30922012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3093
3094 * keyboard.c: Export real-this-command to Elisp.
3095 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3096 and DEFVAR it. Update all users.
3097
63810350
PE
30982012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3099
7bd5c1f4
PE
3100 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3101
63810350
PE
3102 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3103 Convert pctcpu and pctmem to Lisp float properly.
3104 Let the compiler fold better, as 100.0/0x8000 is exact.
3105
a2821611
AS
31062012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3107
3108 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3109 cons_block.
3110
5fceba1d
PE
31112012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3114
c98ff5dd
DA
31152012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3116
3117 For a 'struct window', replace some Lisp_Object fields to
3118 bitfields where appropriate, remove unused fields.
3119 * window.h (struct window): Remove unused 'last_mark_x' and
3120 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3121 change it's type from Lisp_Object to bitfield.
3122 Change type of 'force_start', 'optional_new_start',
3123 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3124 fields from Lisp_Object to bitfield. Adjust users accordingly.
3125
ca34e0be
PE
31262012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 Pacify gcc -Wdouble-precision when using Xaw.
3129 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3130 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3131 Use 'float' consistently, rather than 'float' in most places
3132 and 'double' in a couple of places.
3133
efc00ab1 31342012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3135
3136 * xdisp.c (handle_stop): Detect whether we have overlay strings
3137 loaded by testing it->current.overlay_string_index to be
3138 non-negative, instead of checking whether n_overlay_strings is
3139 positive. (Bug#11587)
3140
efc00ab1 31412012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3142
3143 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3144
3145 * doc.c (Fsubstitute_command_keys): Doc fix.
3146
efc00ab1 31472012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3148
3149 * search.c (search_buffer): Remove calls to
3150 r_alloc_inhibit_buffer_relocation, as it is now called by
3151 maybe_unify_char, which was the cause of relocation of buffer text
3152 in bug#11519.
3153
efc00ab1 31542012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3155
3156 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3157 for the duration of call to load_charset, to avoid problems with
3158 callers of maybe_unify_char that access buffer text through C
3159 pointers.
3160
3161 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3162 decrement the inhibition flag, instead of just setting or
3163 resetting it.
3164
ba93a187
PE
31652012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 Remove obsolete '#define static' cruft.
3168 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3169 This #undef was "temporary" in 2000; it is no longer needed
3170 now that '#define static' has gone away.
3171 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3172 (gray_bitmap_bits): Remove; no longer needed.
3173 All uses replaced with definiens.
3174 * xterm.c: Include "bitmaps/gray.xbm".
3175
9e4bf381
PE
31762012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3177
3178 Clean up __executable_start, monstartup when --enable-profiling.
3179 The following changes affect the code only when profiling.
3180 * dispnew.c (__executable_start): Rename from safe_bcopy.
3181 Define only on platforms that need it.
3182 * emacs.c: Include <sys/gmon.h> when profiling.
3183 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3184 (__executable_start): Remove decl, since lisp.h does it now.
3185 (safe_bcopy): Remove decl; no longer has that name.
3186 (main): Coalesce #if into single bit of code, for simplicity.
3187 Cast pointers to uintptr_t, since standard libraries want integers
3188 and not pointers.
3189 * lisp.h (__executable_start): New decl.
3190
32d72c2f
GM
31912012-05-31 Glenn Morris <rgm@gnu.org>
3192
3193 * image.c (Fimagemagick_types): Doc fix.
3194
baac5bc7
JM
31952012-05-30 Jim Meyering <meyering@redhat.com>
3196
3197 * callproc.c (Fcall_process_region): Include directory component
3198 in mkstemp error message (Bug#11586).
3199
72cb32cf
PE
32002012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 * alloc.c, lisp.h (make_pure_vector): Now static.
3203
61b108cc
SM
32042012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3205
3206 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3207 Move to byte-run.el.
3208 (Fautoload): Do the hash-doc more carefully.
3209 * data.c (Fdefalias): Purify definition, except for keymaps.
3210 (Qdefun): Move from eval.c.
3211 * lisp.h (Qdefun): Remove.
3212 * lread.c (read1): Tiny simplification.
3213
471fe23d
TN
32142012-05-29 Troels Nielsen <bn.troels@gmail.com>
3215
934f3f58 3216 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3217 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3218 Bug#9642, but explicitly check that the buffer the overlay would
3219 be moved to is live and rearrange lines to make sure that errors
3220 will not put the overlay in an inconsistent state.
3221 (Fdelete_overlay): Cosmetics.
3222
85d0efd1
EZ
32232012-05-28 Eli Zaretskii <eliz@gnu.org>
3224
3225 * w32term.c (my_bring_window_to_top): New function.
3226 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3227 could be different from the original one.
3228 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3229 (Bug#11513)
3230
3231 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3232 by calling BringWindowToTop.
3233
3234 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3235 (WM_EMACS_END): Increase by one.
3236
da92a98c
PE
32372012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3238
3239 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3240 This avoids undefined behavior that might cause the eassert
3241 to not catch an out-of-range value.
3242
74d1f848
JB
32432012-05-28 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3246 Update dependencies.
3247
9e1a06fc
EZ
32482012-05-27 Eli Zaretskii <eliz@gnu.org>
3249
3250 * bidi.c (bidi_mirror_char): Fix last change.
3251
f3dd7312
AS
32522012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3253
3254 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3255 when referring to sectname field in printf format.
3256
81899c91
PE
32572012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3258
57b81a9f
PE
3259 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3260 Only r_alloc_inhibit_buffer_relocation needed to be added;
3261 the others were already declared.
3262
81899c91
PE
3263 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3264 before checking whether it's out of range. Put the check inside
3265 eassert. See
3266 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3267
33017faf 32682012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3269
3270 * callproc.c (Fcall_process): Restore a line that was accidentally
3271 commented out in the 2011-02-13 change (bug#11547).
3272
33017faf 32732012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3274
3275 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3276 defined on ralloc.c.
3277
3278 * buffer.c [REL_ALLOC]: Remove prototypes of
3279 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3280 they are now on lisp.h.
3281
3282 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3283
3284 * search.c (search_buffer): Use it to inhibit relocation of buffer
3285 text while re_search_2 is doing its job, because re_search_2 is
3286 passed C pointers to buffer text. (Bug#11519)
3287
23415acf
EZ
3288 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3289 Update value to 24.
3290
44e27368
EZ
3291 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3292 state after an additional call to move_it_in_display_line_to, keep
3293 the values of it->max_ascent and it->max_descent found for the
3294 entire line.
3295 (pos_visible_p): Revert the comparison against bottom_y to what it
3296 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3297 (Bug#11464)
3298
c1892f11
PE
32992012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 Fix coding-related core dumps with gcc -ftrapv.
3302 The code was computing A - B, where A and B are pointers, and B is
3303 random garbage. This can lead to core dumps on platforms that
3304 have special pointer registers, and it also leads to core dumps on
3305 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3306 A - B only when B is initialized properly.
3307 * coding.c (coding_set_source, coding_set_destination): Return void.
3308 (coding_change_source, coding_change_destinations): New functions,
3309 with the old behaviors of coding_set_source and coding_set_destination.
3310 All callers that need an offset changed to use these new functions.
3311
eb7afdad
GM
33122012-05-26 Glenn Morris <rgm@gnu.org>
3313
3314 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3315
f12fdf02
EZ
33162012-05-26 Eli Zaretskii <eliz@gnu.org>
3317
53a63be6 3318 Extend mouse support on W32 text-mode console.
61b108cc
SM
3319 * xdisp.c (draw_row_with_mouse_face):
3320 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3321
eb3f6f01 3322 * w32console.c: Include window.h.
61b108cc
SM
3323 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3324 New functions.
eb3f6f01
EZ
3325 (initialize_w32_display): Initialize mouse-highlight data.
3326
53a63be6
EZ
3327 * w32inevt.c: Include termchar.h and window.h.
3328 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3329 moves, call note_mouse_highlight. If help_echo changed, call
3330 gen_help_event to produce help-echo message in the echo area.
3331 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3332 highlight info.
3333
4cfd81f6
PE
33342012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 * lread.c (read1): Simplify slightly to avoid an overflow warning
3337 with GCC 4.7.0 on x86-64.
3338
4446092a
EZ
33392012-05-26 Eli Zaretskii <eliz@gnu.org>
3340
3341 * bidi.c (bidi_mirror_char): Revert last change: an int is
3342 definitely wide enough here.
3343
42b2a986 33442012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3345
42b2a986 3346 Fix integer width and related bugs (Bug#9874).
eb106a49 3347 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3348 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3349 (string_bytes, check_sblock, allocate_string_data):
3350 (compact_small_strings, Fmake_bool_vector, make_string)
3351 (make_unibyte_string, make_multibyte_string)
3352 (make_string_from_bytes, make_specified_string)
3353 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3354 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3355 (mark_vectorlike):
3356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3357 (allocate_pseudovector):
3358 Use int, not EMACS_INT, where int is wide enough.
3359 (inhibit_garbage_collection, Fgarbage_collect):
3360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3361 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3362 int might not be wide enough.
3363 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3364 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3365 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3366 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3367 (bidi_level_of_next_char, bidi_move_to_visually_next):
3368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3369 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3370 (Fkill_buffer, Fset_buffer_major_mode)
3371 (advance_to_char_boundary, Fbuffer_swap_text)
3372 (Fset_buffer_multibyte, overlays_at, overlays_in)
3373 (overlay_touches_p, struct sortvec, record_overlay_string)
3374 (overlay_strings, recenter_overlay_lists)
3375 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3376 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3377 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3378 (Foverlay_recenter, last_overlay_modification_hooks_used)
3379 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3381 (validate_region): Omit unnecessary test for b <= e,
3382 since that's guaranteed by the previous test.
d311d28c
PE
3383 (adjust_overlays_for_delete): Avoid pos + length overflow.
3384 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3385 (report_overlay_modification):
3386 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3387 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3388 Omit pointer cast, which isn't needed anyway, and doesn't work
3389 after the EMACS_INT -> ptrdiff_t change.
02481186 3390 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3391 * buffer.h: Adjust decls to match defn changes elsewhere.
3392 (struct buffer_text, struct buffer):
3393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3394 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3395 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3396 not int, to avoid needless 32-bit limit on 64-bit hosts.
3397 (exec_byte_code): Use tighter memory-full test, one that checks
3398 for alloca overflow. Don't compute the address of the object just
3399 before an array, as that's not portable. Use EMACS_INT, not
3400 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3401 * callint.c (Fcall_interactively):
3402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3403 * callproc.c (call_process_kill, Fcall_process):
3404 Don't assume pid_t fits into an Emacs fixnum.
3405 (call_process_cleanup, Fcall_process, child_setup):
3406 Don't assume pid_t fits into int.
3407 (call_process_cleanup, Fcall_process, delete_temp_file)
3408 (Fcall_process_region):
3409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3410 (Fcall_process): Simplify handling of volatile integers.
3411 Use int, not EMACS_INT, where int will do.
3412 * casefiddle.c (casify_object, casify_region, operate_on_word)
3413 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3415 (casify_object): Avoid integer overflow when overallocating buffer.
3416 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3417 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3418 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3419 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3420 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3421 integers are now checked earlier. All uses replaced with XINT.
3422 (ccl_driver):
3423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3424 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3425 (ccl_driver, Fregister_code_conversion_map):
3426 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3427 (resolve_symbol_ccl_program): Check that vector header is in range.
3428 Always copy the vector, so that we can check its contents reliably
3429 now rather than having to recheck each instruction as it's being
3430 executed. Check that vector words fit in 'int'.
3431 (ccl_get_compiled_code, Fregister_ccl_program)
3432 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3433 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3434 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3435 contents are in range.
3436 (Fccl_execute_on_string): Check that status is in range.
3437 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3438 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3439 Accept and return EMACS_INT, not int, because callers can pass values
3440 out of 'int' range.
3441 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3442 (multibyte_chars_in_text, parse_str_as_multibyte)
3443 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3444 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3445 (string_escape_byte8, Fget_byte):
3446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3447 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3448 avoid mishandling large integers.
3449 * character.h: Adjust decls to match defn changes elsewhere.
3450 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3451 (Ffind_charset_region):
3452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3453 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3454 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3455 Don't assume fixnum fits in int.
d311d28c
PE
3456 (load_charset_map_from_vector, Fmap_charset_chars):
3457 Remove now-unnecessary CHECK_NATNUMs.
3458 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3459 Don't rely on undefined behavior with signed left shift overflow.
3460 Don't assume unsigned int fits into fixnum, or that fixnum fits
3461 into unsigned int. Don't require max_code to be a valid fixnum;
3462 that's not true for gb10830 4-byte on a 32-bit host. Allow
3463 invalid_code to be a cons, for the same reason. Require code_offset
3464 to be a character. Avoid int overflow if max_char is close
3465 to INT_MAX.
3466 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3467 this is intended anyway and avoids some undefined behavior.
3468 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3469 INDEX_TO_CODE_POINT, as that's what it expects.
3470 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3471 * charset.h (DECODE_CHAR): Return int, not unsigned;
3472 this is what was intended anyway, and it avoids undefined behavior.
3473 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3474 integer-overflow issues.
3475 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3476 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3477 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3478 * chartab.c (Fmake_char_table, Fset_char_table_range)
3479 (uniprop_get_decoder, uniprop_get_encoder):
3480 Don't assume fixnum fits in int.
3481 * cmds.c (move_point): New function, that does the gist of
3482 Fforward_char and Fbackward_char, but does so while checking
3483 for integer overflow more accurately.
c96e5d6a 3484 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3485 (Fforward_line, Fend_of_line, internal_self_insert)
3486 (internal_self_insert):
3487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3488 Fix a FIXME, by checking for integer overflow when calculating
3489 target_clm and actual_clm.
3490 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3491 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3492 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3493 (coding_alloc_by_making_gap, alloc_destination)
3494 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3495 (encode_coding_utf_16, detect_coding_emacs_mule)
3496 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3497 (detect_coding_iso_2022, decode_coding_iso_2022)
3498 (encode_invocation_designation, encode_designation_at_bol)
3499 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3500 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3501 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3502 (encode_coding_ccl, encode_coding_raw_text)
3503 (detect_coding_charset, decode_coding_charset)
3504 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3505 (produce_composition, produce_charset, produce_annotation)
3506 (decode_coding, handle_composition_annotation)
3507 (handle_charset_annotation, consume_chars, decode_coding_gap)
3508 (decode_coding_object, encode_coding_object, detect_coding_system)
3509 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3510 (code_convert_region, code_convert_string)
8f50130c
PE
3511 (Fdefine_coding_system_internal)
3512 (coding_set_source, coding_set_destination):
d311d28c
PE
3513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3514 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3515 (Fdefine_coding_system_internal):
3516 Don't assume fixnums fit in int.
3517 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3518 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3519 (Funencodable_char_position, Fcheck_coding_systems_region)
3520 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3522 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3523 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3524 Don't access memory outside of the args array.
d311d28c 3525 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3526 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3527 result of ENCODE_CHAR.
d311d28c
PE
3528 * coding.h: Adjust decls to match defn changes elsewhere.
3529 (struct coding_system):
3530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3531 * composite.c (get_composition_id, find_composition)
3532 (run_composition_function, update_compositions)
3533 (compose_text, composition_gstring_put_cache)
3534 (composition_gstring_p, composition_gstring_width)
3535 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3536 (composition_compute_stop_pos, composition_reseat_it)
3537 (composition_update_it, struct position_record)
3538 (find_automatic_composition, composition_adjust_point)
3539 (Fcomposition_get_gstring, Ffind_composition_internal):
3540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3541 (update_compositions):
3542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3543 * composite.h: Adjust decls to match defn changes elsewhere.
3544 (struct composition):
3545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3546 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3547 Do not attempt to compute the address of the object just before a
3548 buffer; this is not portable.
3549 (Faref, Faset):
3550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3551 (Faset): Use int, not EMACS_INT, where int is wide enough.
3552 (Fstring_to_number): Don't assume fixnums fit in int.
3553 (Frem): Don't assume arg is nonnegative.
3554 * dbusbind.c (xd_append_arg): Check for integers out of range.
3555 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3556 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3557 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3558 (xd_get_connection_references): Return ptrdiff_t, not int.
3559 All uses changed.
3560 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3561 (xd_read_message_1):
3562 Use int, not unsigned, where the dbus API uses int.
3563 (Fdbus_message_internal): Don't overflow mtype.
3564 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3565 * dired.c (directory_files_internal, file_name_completion, scmp)
3566 (file_name_completion_stat):
3567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3568 (file_name_completion): Don't overflow matchcount.
3569 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3570 * dispextern.h: Adjust decls to match defn changes elsewhere.
3571 (struct text_pos, struct glyph, struct bidi_saved_info)
3572 (struct bidi_string_data, struct bidi_it, struct composition_it)
3573 (struct it):
3574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3575 (struct display_pos, struct composition_it, struct it):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 * dispnew.c (increment_matrix_positions)
3578 (increment_row_positions, mode_line_string)
3579 (marginal_area_string):
3580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3581 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3583 (duration_to_sec_usec): New function, to check for overflow better.
3584 (Fsleep_for, sit_for): Use it.
3585 * doc.c (get_doc_string, store_function_docstring):
3586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3587 (get_doc_string, Fsnarf_documentation):
3588 Use int, not EMACS_INT, where int is wide enough.
3589 (get_doc_string):
3590 Use SAFE_ALLOCA, not alloca.
3591 Check for overflow when converting EMACS_INT to off_t.
3592 * doprnt.c (doprnt):
3593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3594 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3595 Don't assume uid_t fits into fixnum.
3596 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3597 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3598 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3599 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3600 (general_insert_function)
3601 (Finsert_char, make_buffer_string, make_buffer_string_both)
3602 (update_buffer_properties, Fbuffer_substring)
3603 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3604 (Fsubst_char_in_region, check_translation)
3605 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3606 (transpose_markers, Ftranspose_regions):
3607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3608 (clip_to_bounds): Move to lisp.h as an inline function).
3609 (Fconstrain_to_field): Don't assume integers are nonnegative.
3610 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3611 (Fsubst_char_in_region, Fsave_restriction):
3612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3613 (Femacs_pid): Don't assume pid_t fits into fixnum.
3614 (lo_time): Use int, not EMACS_INT, when int suffices.
3615 (lisp_time_argument): Check for usec out of range.
3616 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3617 (Fuser_login_name, Fuser_full_name): Signal an error
3618 if a uid argument is out of range, rather than relying on
3619 undefined behavior.
c8d5c857
PE
3620 (Fformat_time_string): Remove now-unnecessary check.
3621 lisp_time_argument checks for out-of-range usec now.
243e0530 3622 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3623 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3624 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3625 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3626 (init_cmdargs, Fdump_emacs):
3627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3628 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3629 the bottom (typically) 32 bits of the fixnum.
3630 * eval.c (specpdl_size, call_debugger):
3631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3632 (when_entered_debugger, Fbacktrace_debug):
3633 Don't assume fixnum can fit in int.
3634 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3635 the object just before a buffer; this is not portable.
3636 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3637 (grow_specpdl, unbind_to):
3638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3639 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3640 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3641 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3642 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3643 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3645 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3646 (a_write, e_write):
3647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3648 (Fcopy_file, non_regular_nbytes, read_non_regular)
3649 (Finsert_file_contents):
3650 Use int, not EMACS_INT, where int is wide enough.
3651 (READ_BUF_SIZE): Verify that it fits in int.
3652 (Finsert_file_contents): Check that counts are in proper range,
3653 rather than assuming fixnums fit into ptrdiff_t etc.
3654 Don't assume fixnums fit into int.
125b3835 3655 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3656 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3657 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3658 (string_char_to_byte, string_byte_to_char)
3659 (string_make_multibyte, string_to_multibyte)
3660 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3661 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3662 (substring_both, Fdelete, internal_equal, Ffillarray)
3663 (Fclear_string, mapcar1)
3664 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3665 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3666 (larger_vector, make_hash_table, maybe_resize_hash_table)
3667 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3668 (Fmaphash, secure_hash):
3669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3670 (concat): Check for string index and length overflow.
3671 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3672 (Frequire):
3673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3674 (larger_vector): New API (vec, incr_min, size_max) replaces old
3675 one (vec, new_size, init). This catches size overflow.
3676 INIT was removed because it was always Qnil.
3677 All callers changed.
3678 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3679 the upper bound on a hash table index size.
3680 (make_hash_table, maybe_resize_hash_table): Use it.
3681 (secure_hash): Computer start_byte and end_byte only after
3682 they're known to be in ptrdiff_t range.
3683 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3684 (Ffont_get_glyphs, Ffont_at):
3685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3686 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3687 (Flist_fonts, Fopen_font):
3688 Don't assume fixnum can fit in int.
3689 (check_gstring): Don't assume index can fit in int.
3690 (font_match_p): Check that fixnum is a character, not a nonnegative
3691 fixnum, since the later code needs to stuff it into an int.
3692 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3693 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3694 conversion overflow issues.
3695 (Fopen_font): Check for integer out of range.
3696 (Ffont_get_glyphs): Don't assume index can fit in int.
3697 * font.h: Adjust decls to match defn changes elsewhere.
3698 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3699 integer overflow.
3700 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3701 printmax_t, where ptrdiff_t is wide enough.
3702 (Finternal_char_font):
3703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3704 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3705 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3706 (Fset_frame_position, x_set_frame_parameters)
3707 (x_set_line_spacing, x_set_border_width)
3708 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3709 Check that fixnums are in proper range for system types.
3710 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3712 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3713 Use SAFE_ALLOCA_LISP, not alloca.
3714 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3715 intptr_t is wide enough.
3716 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3717 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3718 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3719 Check for fixnum out of range.
3720 * ftfont.c (ftfont_list): Don't assume index fits in int.
3721 Check that fixnums are in proper range for system types.
3722 (ftfont_shape_by_flt):
3723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3724 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3726 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3727 Check that fixnums are in proper range for system types.
3728 * gnutls.h: Adjust decls to match defn changes elsewhere.
3729 * gtkutil.c (xg_dialog_run):
3730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3731 (update_frame_tool_bar):
3732 Check that fixnums are in proper range for system types.
3733 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3734 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3735 * indent.c (last_known_column, last_known_column_point):
3736 (current_column_bol_cache):
3737 (skip_invisible, current_column, check_display_width):
3738 (check_display_width, scan_for_column, current_column_1)
3739 (Findent_to, Fcurrent_indentation, position_indentation)
3740 (indented_beyond_p, Fmove_to_column, compute_motion):
3741 (Fcompute_motion, Fvertical_motion):
3742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3743 (last_known_column_modified): Use EMACS_INT, not int.
3744 (check_display_width):
3745 (Fcompute_motion):
3746 Check that fixnums and floats are in proper range for system types.
3747 (compute_motion): Don't assume index or fixnum fits in int.
3748 (compute_motion, Fcompute_motion):
3749 Use int, not EMACS_INT, when it is wide enough.
3750 (vmotion): Omit local var start_hpos that is always 0; that way
3751 we don't need to worry about overflow in expressions involving it.
3752 * indent.h: Adjust decls to match defn changes elsewhere.
3753 (struct position):
3754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3755 Use int, not EMACS_INT, where int is wide enough.
3756 Remove unused members ovstring_chars_done and tab_offset;
3757 all uses removed.
3758 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3759 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3760 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3761 (make_gap, copy_text, insert, insert_and_inherit)
3762 (insert_before_markers, insert_before_markers_and_inherit)
3763 (insert_1, count_combining_before, count_combining_after)
3764 (insert_1_both, insert_from_string)
3765 (insert_from_string_before_markers, insert_from_string_1)
3766 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3767 (adjust_after_replace, adjust_after_insert, replace_range)
3768 (replace_range_2, del_range, del_range_1, del_range_byte)
3769 (del_range_both, del_range_2, modify_region)
3770 (prepare_to_modify_buffer, signal_before_change)
3771 (signal_after_change, Fcombine_after_change_execute):
3772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3773 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3774 (balance_an_interval, split_interval_right, split_interval_left)
3775 (find_interval, next_interval, update_interval)
3776 (adjust_intervals_for_insertion, delete_node, delete_interval)
3777 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3778 (static_offset_intervals, offset_intervals)
3779 (merge_interval_right, merge_interval_left, make_new_interval)
3780 (graft_intervals_into_buffer, temp_set_point_both)
3781 (temp_set_point, set_point, adjust_for_invis_intang)
3782 (set_point_both, move_if_not_intangible, get_property_and_range)
3783 (get_local_map, copy_intervals, copy_intervals_to_string)
3784 (compare_string_intervals, set_intervals_multibyte_1):
3785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3786 * intervals.h: Adjust decls to match defn changes elsewhere.
3787 (struct interval):
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 * keyboard.c (this_command_key_count, this_single_command_key_start)
3790 (before_command_key_count, before_command_echo_length, echo_now)
3791 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3792 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3793 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3794 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3796 (last_non_minibuf_size, last_point_position, echo_truncate)
3797 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3798 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3799 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3800 (stuff_buffered_input):
3801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3802 (last_auto_save, command_loop_1, read_char):
3803 Use EMACS_INT, not int, to avoid integer overflow.
3804 (record_char): Avoid overflow in total_keys computation.
3805 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3806 * keyboard.h: Adjust decls to match defn changes elsewhere.
3807 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3808 (Fkey_description, Fdescribe_vector, Flookup_key):
3809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3810 (click_position): New function, to check that positions are in range.
3811 (Fcurrent_active_maps):
3812 (describe_command):
3813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3814 (Faccessible_keymaps, Fkey_description):
3815 (preferred_sequence_p):
3816 Don't assume fixnum can fit into int.
3817 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3818 Check for integer overflow in size calculations.
3819 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3820 avoid mishandling large integers.
3821 * lisp.h: Adjust decls to match defn changes elsewhere.
3822 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3823 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3824 (struct Lisp_Marker):
3825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3826 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3827 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3828 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3829 All callers changed.
3830 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3831 Assume the arg has valid form, since it always does.
3832 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3833 unsigned integer system type.
3834 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3835 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3836 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3837 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3838 (duration_to_sec_usec): New decl.
3839 * lread.c (read_from_string_index, read_from_string_index_byte)
3840 (read_from_string_limit, readchar, unreadchar, openp)
3841 (read_internal_start, read1, oblookup):
3842 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3843 (Fload, readevalloop, Feval_buffer, Feval_region):
3844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3845 (openp): Check for out-of-range argument to 'access'.
3846 (read1): Use int, not EMACS_INT, where int is wide enough.
3847 Don't assume fixnum fits into int.
6efdadfd 3848 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3849 (read_filtered_event): Use duration_to_sec_usec
3850 to do proper overflow checking on durations.
d311d28c
PE
3851 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3852 in size calculation.
3853 (Fexecute_kbd_macro):
3854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3855 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3856 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3857 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3858 (set_marker_both, set_marker_restricted_both, marker_position)
3859 (marker_byte_position, Fbuffer_has_markers_at):
3860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3861 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3862 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3863 It now merely ensures that the menu is large enough, without
3864 necessarily growing it, as this avoids some integer overflow issues.
3865 All callers changed.
3866 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3868 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3869 Use SAFE_ALLOCA_LISP, not alloca.
3870 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3871 to EMACS_INT. Check that fixnums are in proper range for system types.
3872 * minibuf.c (minibuf_prompt_width, string_to_object)
3873 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3874 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3876 (get_minibuffer, read_minibuf_unwind):
3877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3878 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3879 this simplifies overflow checking. All callers changed.
3880 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3881 (Ftest_completion):
3882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3883 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3884 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3885 Check that fixnums are in proper range for system types.
3886 (Fx_create_frame, Fx_show_tip):
3887 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3888 * nsfont.m (ns_findfonts, nsfont_list_family):
3889 Don't assume fixnum fits in long.
3890 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3892 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3893 wide enough.
17fdb222 3894 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3896 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3897 (PRINTDECLARE, PRINTPREPARE):
3898 (strout, print_string):
3899 (print, print_preprocess, print_check_string_charset_prop)
3900 (print_object):
3901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3902 (PRINTDECLARE):
3903 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3905 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3906 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3907 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3908 (print_error_message): Use SAFE_ALLOCA, not alloca.
3909 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3910 (print_depth, new_backquote_output, print_number_index):
3911 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3912 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3913 (Fset_process_window_size, Fformat_network_address)
3914 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3915 (sigchld_handler):
d311d28c 3916 Check that fixnums are in proper range for system types.
d44287d4 3917 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3918 Check for process-ids out of pid_t range rather than relying on
3919 undefined behavior.
e4d81efc 3920 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3921 (Fformat_network_address, read_process_output, send_process)
3922 (Fprocess_send_region, status_notify):
3923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3924 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3925 (wait_reading_process_output, read_process_output, exec_sentinel):
3926 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3927 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3928 (Faccept_process_output): Use duration_to_sec_usec to do proper
3929 overflow checking on durations.
dde14581
PE
3930 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3931 Don't assume pid_t fits in int.
02481186
PE
3932 * process.h (struct Lisp_Process): Members tick and update_tick
3933 are now of type EMACS_INT, not int.
b62b53e8
PE
3934 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3935 configured --with-wide-int.
d311d28c
PE
3936 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3937 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3938 * search.c (looking_at_1, string_match_1):
3939 (fast_string_match, fast_c_string_match_ignore_case)
3940 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3941 (scan_newline, find_before_next_newline, search_command)
3942 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3943 (set_search_regs, wordify):
3944 (Freplace_match):
3945 (Fmatch_data):
3946 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3947 (string_match_1, search_buffer, set_search_regs):
3948 (Fmatch_data):
3949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3950 (wordify): Check for overflow in size calculation.
3951 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3952 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3953 Check that fixnums are in proper range for system types.
3954 * sound.c (struct sound_device)
3955 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3957 (Fplay_sound_internal):
3958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3959 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3960 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3961 (Fparse_partial_sexp):
3962 Don't assume fixnums can fit in int.
3963 (struct lisp_parse_state, find_start_pos, find_start_value)
3964 (find_start_value_byte, find_start_begv)
3965 (update_syntax_table, char_quoted, dec_bytepos)
3966 (find_defun_start, prev_char_comend_first, back_comment):
3967 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3968 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3970 (Finternal_describe_syntax_value): Check that match_lisp is a
3971 character, not an integer, since the code stuffs it into int.
3972 (scan_words, scan_sexps_forward):
3973 Check that fixnums are in proper range for system types.
3974 (Fforward_word):
3975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3976 (scan_sexps_forward):
3977 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3978 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3979 * syntax.h: Adjust decls to match defn changes elsewhere.
3980 (struct gl_state_s):
3981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3982 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3983 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3984 * sysdep.c (wait_for_termination_1, wait_for_termination)
3985 (interruptible_wait_for_termination, mkdir):
3986 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3987 (emacs_read, emacs_write):
3988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3989 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3990 and double all fit in int.
d311d28c
PE
3991 * term.c (set_tty_color_mode):
3992 Check that fixnums are in proper range for system types.
3993 * termhooks.h (struct input_event):
3994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3995 * textprop.c (validate_interval_range, interval_of)
3996 (Fadd_text_properties, set_text_properties_1)
3997 (Fremove_text_properties, Fremove_list_of_text_properties)
3998 (Ftext_property_any, Ftext_property_not_all)
3999 (copy_text_properties, text_property_list, extend_property_ranges)
4000 (verify_interval_modification):
4001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4002 (Fnext_single_char_property_change)
4003 (Fprevious_single_char_property_change):
4004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4005 (copy_text_properties):
4006 Check for integer overflow in index calculation.
d311d28c
PE
4007 * undo.c (last_boundary_position, record_point, record_insert)
4008 (record_delete, record_marker_adjustment, record_change)
4009 (record_property_change):
4010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4011 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4013 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4014 (Fx_hide_tip, Fx_file_dialog):
4015 * w32menu.c (set_frame_menubar):
4016 Use ptrdiff_t, not int, for consistency with rest of code.
4017 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4018 (select_window, Fdelete_other_windows_internal)
4019 (window_scroll_pixel_based, window_scroll_line_based)
4020 (Frecenter, Fset_window_configuration):
4021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4022 (Fset_window_hscroll, run_window_configuration_change_hook)
4023 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4024 (Fscroll_other_window, Frecenter):
d311d28c
PE
4025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4026 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4027 Don't assume fixnum fits in int.
4028 (Fset_window_scroll_bars):
4029 Check that fixnums are in proper range for system types.
4030 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4031 (string_pos, c_string_pos, number_of_chars, init_iterator)
4032 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4033 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4034 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4035 (face_before_or_after_it_pos, handle_invisible_prop)
4036 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4037 (display_prop_intangible_p, string_buffer_position_lim)
4038 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4039 (get_overlay_strings_1, get_overlay_strings)
4040 (iterate_out_of_display_property, forward_to_next_line_start)
4041 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4042 (get_next_display_element, set_iterator_to_next)
4043 (get_visually_first_element, compute_stop_pos_backwards)
4044 (handle_stop_backwards, next_element_from_buffer)
4045 (move_it_in_display_line_to, move_it_in_display_line)
4046 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4047 (add_to_log, message_dolog, message_log_check_duplicate)
4048 (message2, message2_nolog, message3, message3_nolog
4049 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4050 (current_message_1, truncate_echo_area, truncate_message_1)
4051 (set_message, set_message_1, store_mode_line_noprop)
4052 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4053 (text_outside_line_unchanged_p, check_point_in_composition)
4054 (reconsider_clip_changes)
4055 (redisplay_internal, set_cursor_from_row, try_scrolling)
4056 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4057 (redisplay_window, find_last_unchanged_at_beg_row)
4058 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4059 (trailing_whitespace_p, find_row_edges, display_line)
4060 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4061 (display_mode_element, store_mode_line_string)
4062 (pint2str, pint2hrstr, decode_mode_spec)
4063 (display_count_lines, display_string, draw_glyphs)
4064 (x_produce_glyphs, x_insert_glyphs)
4065 (rows_from_pos_range, mouse_face_from_buffer_pos)
4066 (fast_find_string_pos, mouse_face_from_string_pos)
4067 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4069 (safe_call, init_from_display_pos, handle_fontified_prop)
4070 (handle_single_display_spec, load_overlay_strings)
4071 (with_echo_area_buffer, setup_echo_area_for_printing)
4072 (display_echo_area, echo_area_display)
4073 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4074 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4075 (redisplay_window, dump_glyph_row, display_mode_line)
4076 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4077 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4079 (handle_single_display_spec, build_desired_tool_bar_string)
4080 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4081 (get_specified_cursor_type):
4082 Check that fixnums are in proper range for system types.
4083 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4084 (Flookup_image_map):
4085 Don't assume fixnums fit in int.
4086 (compare_overlay_entries):
4087 Avoid mishandling comparisons due to subtraction overflow.
4088 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4089 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4090 (handle_tool_bar_click):
4091 Use int, not unsigned, since we prefer signed and the signedness
4092 doesn't matter here.
4093 (get_next_display_element, next_element_from_display_vector):
4094 Use int, not EMACS_INT, when int is wide enough.
4095 (start_hourglass): Use duration_to_sec_usec to do proper
4096 overflow checking on durations.
4097 * xfaces.c (Fbitmap_spec_p):
4098 Check that fixnums are in proper range for system types.
4099 (compare_fonts_by_sort_order):
4100 Avoid mishandling comparisons due to subtraction overflow.
4101 (Fx_family_fonts, realize_basic_faces):
4102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4103 (Fx_family_fonts):
4104 Don't assume fixnum fits in int.
4105 Use SAFE_ALLOCA_LISP, not alloca.
4106 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4107 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4108 (face_at_buffer_position, face_for_overlay_string)
4109 (face_at_string_position):
4110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4111 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4112 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4113 (Fx_show_tip):
4114 Check that fixnums are in proper range for system types.
4115 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4116 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4118 (Fx_change_window_property): Don't assume fixnums fit in int.
4119 * xfont.c (xfont_chars_supported):
4120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4121 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4122 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 * xml.c (parse_region):
4125 * xrdb.c (magic_file_p):
4126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4127 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4128 (x_get_local_selection, x_reply_selection_request)
4129 (x_handle_selection_request, wait_for_property_change):
4130 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4131 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4132 short is wide enough.
4133 (x_send_client_event): Don't assume fixnum fits in int.
4134 * xterm.c (x_x_to_emacs_modifiers):
4135 Don't assume EMACS_INT overflows nicely into int.
4136 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4137 may come from Lisp.
4138 (handle_one_xevent): NATNUMP can eval its arg twice.
4139 (x_connection_closed):
4140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4141 * xterm.h: Adjust decls to match defn changes elsewhere.
4142 (struct scroll_bar): Use struct vectorlike_header
4143 rather than rolling our own approximation.
4144 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4145
c6574eb5
GM
41462012-05-25 Glenn Morris <rgm@gnu.org>
4147
4148 * lisp.mk (lisp): Update for more files being compiled now.
4149
e8d32c7e
SM
41502012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4151
48def666
SM
4152 * lread.c: Remove `read_pure' which makes no difference.
4153 (read_pure): Remove var.
4154 (unreadpure): Remove function.
4155 (readevalloop): Don't call read_list with -1 flag.
4156 (read1, read_vector): Don't test read_pure any more.
4157 (read_list): Simplify.
4158
e8d32c7e
SM
4159 * fileio.c, character.h: Minor style tweaks.
4160
4b2addb7
DA
41612012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4162
4163 * window.h (clip_changed): Remove useless declaration.
4164
584461b2
JB
41652012-05-22 Juanma Barranquero <lekktu@gmail.com>
4166
4167 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4168 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4169
34374650
PE
41702012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 Remove src/m/*.
4173 This directory predates autoconf and is no longer needed nowadays.
4174 Move its few remaining bits of functionality to where they're needed.
4175 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4176 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4177 * m/template.h: Remove.
4178 * Makefile.in (M_FILE): Remove. All uses removed.
4179 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4180 * lisp.h (USE_LSB_TAG):
4181 * mem-limits.h (EXCEEDS_LISP_PTR):
4182 Use VAL_MAX, not VALBITS, in #if.
4183 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4184 (EMACS_UINT): Define unconditionally now.
4185 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4186 (BITS_PER_EMACS_INT): New constants, replacing
4187 what used to be in config.h, but not useful in #if.
4188 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4189 define them any more.
4190 (VAL_MAX): New macro.
4191 (VALMASK): Use it.
4192 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4193 BITS_PER_EMACS_INT, in #if.
4194 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4195 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4196 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4197 * s/ms-w32.h (DATA_START):
4198 Move here from removed file m/intel386.h.
4199 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4200 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4201
261cb4bb
PE
42022012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4203
4204 Assume C89 or later.
4205 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4206 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4207 (xrealloc):
4208 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4209 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4210 * textprop.c, tparam.c (NULL): Remove.
4211 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4212 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4213 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4214 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4215 * xterm.c (input_signal_count): Assume volatile works.
4216
ff23cd9f
KB
42172012-05-21 Ken Brown <kbrown@cornell.edu>
4218
4219 * xgselect.c (xg_select): Fix first argument in call to 'select'
4220 (bug#11508).
4221
1b170bc6
KB
42222012-05-20 Ken Brown <kbrown@cornell.edu>
4223
4224 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4225 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4226
b2f4d39f
KB
42272012-05-19 Ken Brown <kbrown@cornell.edu>
4228
4229 * xfns.c (x_in_use): Remove `static' qualifier.
4230 * xterm.h (x_in_use): Declare.
4231 * xgselect.c: Include xterm.h.
4232 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4233 and `display_arg' (bug#9754).
4234
003fdae2
PE
42352012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4236
9232a6d9
PE
4237 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4238
003fdae2
PE
4239 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4240 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4241
784b56e2
EZ
42422012-05-18 Eli Zaretskii <eliz@gnu.org>
4243
4244 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4245
4246 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4247 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4248
4249 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4250 reference to image_cache->refcount.
4251 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4252
a0a79cde
JL
42532012-05-17 Juri Linkov <juri@jurta.org>
4254
4255 * search.c (Fword_search_regexp, Fword_search_backward)
4256 (Fword_search_forward, Fword_search_backward_lax)
4257 (Fword_search_forward_lax): Move functions to isearch.el
4258 (bug#10145, bug#11381).
4259
b0572523
PE
42602012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4261
4262 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4263
9660f5fc
SM
42642012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4265
4266 * lread.c (init_obarray): Declare Qt and Qnil as special.
4267
4374de83
GM
42682012-05-14 Glenn Morris <rgm@gnu.org>
4269
4270 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4271 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4272
dc44c39a
PE
42732012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4274
078c97cb
PE
4275 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4276
dc44c39a
PE
4277 * unexaix.c: Port to more-recent AIX compilers.
4278 (report_error, report_error_1, make_hdr, copy_sym)
4279 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4280 Make arguments const char *, not char *, to avoid violations of C
4281 standard and to fix some AIX warnings reported by Gilles Pion.
4282
e18afed7 42832012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4284
4285 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4286 already have overlays loaded.
4287 (handle_single_display_spec): Before returning without displaying
4288 fringe bitmap, synchronize the bidi iterator with the main display
4289 iterator, by calling iterate_out_of_display_property.
4290 (iterate_out_of_display_property): Detect buffer iteration by
4291 testing that it->string is a Lisp string.
4292 (get_next_display_element): When the current object is exhausted,
4293 and there's something on it->stack, call set_iterator_to_next to
4294 proceed with what's on the stack, instead of returning zero.
4295 (set_iterator_to_next): If called at the end of a Lisp string,
4296 proceed to consider_string_end without incrementing string
4297 position. Don't increment display vector index past the end of
4298 the display vector. (Bug#11417)
c8fb9dc6
EZ
4299 (pos_visible_p): Don't report a position visible when move_it_to
4300 stopped at the last line of window, which happens to be scanned
4301 backwards by the bidi iteration. (Bug#11464)
ac268e67 4302
e18afed7 43032012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4304
4305 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4306 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4307 are on a TTY, and thus unable to display on the fringes.
4308 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4309 so we need to signal to the caller that this is a "replacing"
4310 display spec. This fixes display when the spec is invalid or we
4311 are on a TTY.
4312
e18afed7 43132012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4314
4315 * unexaix.c (make_hdr): Fix typo in prototype.
4316 This bug broke the build on AIX. Problem reported by Gilles Pion.
4317
9d0a235a
MA
43182012-05-14 Michael Albinus <michael.albinus@gmx.de>
4319
4320 * keyboard.c (kbd_buffer_get_event): Read special events also in
4321 batch mode. (Bug#11415)
4322
9e6b06ed
GM
43232012-05-12 Glenn Morris <rgm@gnu.org>
4324
4325 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4326
c1a1d7a3
EZ
43272012-05-12 Eli Zaretskii <eliz@gnu.org>
4328
4329 * lisp.mk (lisp): Add newcomment.elc.
4330
3fe7cdc8
GM
43312012-05-12 Glenn Morris <rgm@gnu.org>
4332
4333 * Makefile.in (MKDIR_P): New, set by configure.
4334 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4335
53f7d2c0
PE
43362012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4337
4338 Remove unused function hourglass_started.
4339 * dispextern.h (hourglass_started):
4340 * w32fns.c (hourglass_started):
4341 * xdisp.c (hourglass_started): Remove.
4342
75aafb17
JB
43432012-05-10 Juanma Barranquero <lekktu@gmail.com>
4344
4345 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4346 Update dependencies.
4347
12959e8e
PE
43482012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4349
97107e2e
PE
4350 * xgselect.c (xg_select): Put maxfds+1 into a var.
4351 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4352
12959e8e
PE
4353 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4354
836d29b3
DA
43552012-05-10 Dave Abrahams <dave@boostpro.com>
4356
4357 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4358 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4359
5cb67954
MA
43602012-05-09 Michael Albinus <michael.albinus@gmx.de>
4361
4362 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4363 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4364 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4365 Initialize xd_registered_buses.
4366
3478ec45
PE
43672012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4368
b263a6b0
PE
4369 Untag more efficiently if USE_LSB_TAG.
4370 This is based on a proposal by YAMAMOTO Mitsuharu in
4371 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4372 For an admittedly artificial (nth 8000 longlist) benchmark on
4373 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4374 Emacs's overall text size by 1%.
4375 * lisp.h (XUNTAG): New macro.
4376 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4377 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4378 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4379 * eval.c (Fautoload):
4380 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4381 * frame.h (XFRAME): Use XUNTAG.
4382
3478ec45
PE
4383 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4384 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4385 Remove unportable assumptions about print widths of types like
4386 dbus_uint32_t.
4387 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4388 intptr_t when converting between pointer and integer, to avoid GCC
4389 warnings about wrong width.
4390
666b903b 43912012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4392
4393 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4394 stack for each reader_thread, instead of defaulting to 8MB
4395 determined by the linker. This avoids failures in creating
4396 subprocesses on Windows 7, see the discussion in this thread:
4397 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4398
b120cc17
JC
43992012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4400
4401 Fix up display of the *Minibuf-0* buffer in the mini window.
4402 * keyboard.c (read_char): Don't clear the echo area if there's no
4403 message to clear.
4404 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4405 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4406
9a4b36f8
MA
44072012-05-07 Michael Albinus <michael.albinus@gmx.de>
4408
4409 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4410 batch mode.
4411
e5f9458f
CY
44122012-05-06 Chong Yidong <cyd@gnu.org>
4413
4414 * lisp.mk (lisp): Update.
4415
eceeb5fc 44162012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4417
4418 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4419
71873e2b
SM
44202012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4421
4422 * data.c (PUT_ERROR): New macro.
4423 (syms_of_data): Use it. Add new error type `user-error'.
4424 * undo.c (user_error): New function.
4425 (Fprimitive_undo): Use it.
4426 * print.c (print_error_message): Adjust print style for `user-error'.
4427 * keyboard.c (user_error): New function.
4428 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4429
ab0fa4e4
PE
44302012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4431
4432 Do not limit current-time-string to years 1000..9999.
4433 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4434 (Fcurrent_time_string): Support any year that is supported by the
4435 underlying localtime representation. Don't use asctime, as it
4436 has undefined behavior for years outside the range -999..9999.
4437
7ed806a7
PE
44382012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4439
4440 Fix race conditions involving setenv, gmtime, localtime, asctime.
4441 Without this fix, interrupts could mess up code that uses these
4442 nonreentrant functions, since setting TZ invalidates existing
4443 tm_zone or tzname values, and since most of these functions return
4444 pointers to static storage.
4445 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4446 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4447 Grow the critical sections to include not just invoking
4448 localtime/gmtime, but also accessing these functions' results
4449 including their tm_zone values if any, and any related TZ setting.
4450 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4451 so that the struct tm is saved in the critical section.
4452 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4453 motivated by the fact that memory allocation needs to be outside
4454 the critical section.
4455
0c16dfed
DA
44562012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4457
4458 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4459 with RESET_INTERVAL.
4460
4461 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4462 Remove duplicated buffer name initialization.
4463
3f83ace8
JM
44642012-05-02 Jim Meyering <jim@meyering.net>
4465
4466 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4467
c7b8541e
JM
4468 * xfns.c (x_window): Use xstrdup (Bug#11375).
4469
90207a15 44702012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4471
4472 * xdisp.c (pos_visible_p): If already at a newline from the
4473 display string before the 'while' loop, don't walk back the glyphs
4474 from it3.glyph_row. Solves assertion violation when the display
4475 string begins with a newline (egg.el). (Bug#11367)
4476
b593d6a9
AH
44772012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4478
4479 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4480 Move to simple.el.
4481
4737362e
GM
44822012-05-01 Glenn Morris <rgm@gnu.org>
4483
99cf43f9
GM
4484 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4485 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4486 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4487 All were removed before 23.1.
4488
9311dcff
GM
4489 * dispnew.c: Remove HAVE_LIBNCURSES test;
4490 it is always true on relevant platforms.
4491
4d5c6349
GM
4492 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4493 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4494
4737362e
GM
4495 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4496
74dd3a6b
AS
44972012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4498
4499 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4500 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4501 Remove.
4502
13c379ee
PE
45032012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4504
4505 Do not avoid creating empty evaporating overlays (Bug#9642).
4506 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4507 That is, do not delete an evaporating overlay if it becomes
4508 empty after its bounds are adjusted to fit within its buffer.
4509 This fix caused other problems, and I'm reverting it until we get
4510 to the bottom of them.
4511
a8e7d6d7 45122012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4513
4514 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4515
a8e7d6d7 45162012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4517
4518 * xdisp.c (pos_visible_p): If the window start position is beyond
4519 ZV, start the display from buffer beginning. Prevents assertion
4520 violation in init_iterator when the minibuffer window is scrolled
4521 via the scroll bar.
4522
4523 * window.c (window_scroll_pixel_based): Likewise.
4524
a8e7d6d7 45252012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4526
4527 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4528
a8e7d6d7 45292012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4530
4531 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4532 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4533
a8e7d6d7 45342012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4535
b593d6a9
AH
4536 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4537 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4538
1c6900d9
EZ
45392012-04-26 Eli Zaretskii <eliz@gnu.org>
4540
4c3fa1d9
EZ
4541 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4542 display element, check also the underlying string or buffer
4543 character. (Bug#11341)
4544
1c6900d9
EZ
4545 * w32menu.c: Include w32heap.h.
4546 (add_menu_item): If the call to AppendMenuW (via
4547 unicode_append_menu) fails, disable Unicode menus only if we are
4548 running on Windows 9X/Me.
4549
42bf8205
AS
45502012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4551
4552 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4553 (xgetint): Add missing shift for LSB tags.
4554
b1bac16e
MR
45552012-04-24 Martin Rudalics <rudalics@gmx.at>
4556
4557 * keyboard.c (read_char): Don't wipe echo area for select window
4558 events: These might get delayed via `mouse-autoselect-window'
4559 (Bug#11304).
4560
d69621cc
JB
45612012-04-24 Juanma Barranquero <lekktu@gmail.com>
4562
4563 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4564 manipulation of :loaded-from data.
4565
02fd101b
JB
45662012-04-23 Juanma Barranquero <lekktu@gmail.com>
4567
4568 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4569 now a cons (bug#11311).
4570
888bec30
PE
45712012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4572
89a438bd
PE
4573 Do not create empty overlays with the evaporate property (Bug#9642).
4574 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4575 if it becomes empty after its bounds are adjusted to fit within
4576 its buffer. Without this fix, in a nonempty buffer (let ((o
4577 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4578 yields an empty overlay that has the evaporate property, which is
4579 not supposed to happen.
4580
1068fe4d
PE
4581 Fix minor GTK3 problems found by static checking.
4582 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4583 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4584 (struct _EmacsFixedClass, emacs_fixed_get_type):
4585 Move decls here from emacsgtkfixed.h, since they needn't be public.
4586 (emacs_fixed_get_type): Now static.
4587 (emacs_fixed_class_init): Omit unused local.
4588 (emacs_fixed_child_type): Remove; unused.
4589 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4590 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4591 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4592 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4593 (EMACS_FIXED_GET_CLASS): Remove; unused.
4594 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4595
888bec30
PE
4596 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4597 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4598
de85e130
PE
45992012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4600
d0baac98 4601 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4602 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4603 (__malloc_size_t, __malloc_ptrdiff_t):
4604 Remove. All uses removed, replaced by the definiens if needed,
4605 since we can assume C89 or better now.
4606 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4607 (protect_malloc_state, align, get_contiguous_space)
4608 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4609 (malloc_atfork_handler_child, malloc_enable_thread)
4610 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4611 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4612 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4613 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4614 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4615 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4616 Define using prototypes, not old style.
4617 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4618 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4619 (align): Don't assume that signed integer overflow wraps around.
4620 Omit unused local var.
4621 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4622 (_free_internal_nolock, memalign, mallochook, reallochook):
4623 Omit no-longer-needed casts.
4624 (valloc): Use getpagesize, not __getpagesize.
4625 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4626 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4627
de85e130
PE
4628 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4629
dcbf5805
MA
46302012-04-22 Michael Albinus <michael.albinus@gmx.de>
4631
4632 Move functions from C to Lisp. Make non-blocking method calls
4633 the default. Implement further D-Bus standard interfaces.
4634
4635 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4636 (QCdbus_request_name_allow_replacement)
4637 (QCdbus_request_name_replace_existing)
4638 (QCdbus_request_name_do_not_queue)
4639 (QCdbus_request_name_reply_primary_owner)
4640 (QCdbus_request_name_reply_in_queue)
4641 (QCdbus_request_name_reply_exists)
4642 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4643 (QCdbus_registered_serial, QCdbus_registered_method)
4644 (QCdbus_registered_signal): New Lisp objects.
4645 (XD_DEBUG_MESSAGE): Use sizeof.
4646 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4647 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4648 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4649 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4650 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4651 (xd_signature, xd_append_arg): Allow float for integer types.
4652 (xd_get_connection_references): New function.
b593d6a9
AH
4653 (xd_get_connection_address): Rename from xd_initialize.
4654 Return cached address.
dcbf5805
MA
4655 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4656 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4657 level.
4658 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4659 Return number of refcounts.
dcbf5805
MA
4660 (Fdbus_get_unique_name): Make stronger parameter check.
4661 (Fdbus_message_internal): New defun.
4662 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4663 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4664 (Fdbus_send_signal, Fdbus_register_service)
4665 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4666 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4667 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4668 (Vdbus_compiled_version, Vdbus_runtime_version)
4669 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4670 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4671 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4672 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4673 Adapt docstring.
dcbf5805 4674
52828e02
PE
46752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4676
da05bc4c
PE
4677 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4678 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4679 Do not assume ptrdiff_t is the same width as 'int'.
4680
52828e02
PE
4681 * alloc.c: Handle unusual debugging option combinations.
4682 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4683 since the two debugging options are incompatible.
4684 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4685 is defined.
4686 (mem_init, mem_insert, mem_insert_fixup):
4687 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4688 (NEED_MEM_INSERT): Remove; no longer needed.
4689
f01769f9
LL
46902012-04-22 Leo Liu <sdl.web@gmail.com>
4691
4692 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4693
5790543d
PE
46942012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 * sysdep.c [__FreeBSD__]: Minor cleanups.
4697 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4698 Use Emacs indenting style more consistently. Avoid some casts.
4699 Use 'double' consistently rather than mixing 'float' and 'double'.
4700
b91b7e4d
EW
47012012-04-21 Eduard Wiebe <usenet@pusto.de>
4702
b593d6a9
AH
4703 * sysdep.c (list_system_processes, system_process_attributes):
4704 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4705
6114eb15
AS
47062012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4707
4708 * lisp.mk (lisp): Update.
4709
2f38dff7
PE
47102012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4711
4712 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4713 It is never used otherwise.
4714
4ae29f89
SM
47152012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4716
4717 * print.c (print_preprocess): Only check print_depth if print-circle
4718 is nil.
4719 (print_object): Check for cycles even when print-circle is nil and
4720 print-gensym is t, but only check print_depth if print-circle is nil.
4721
f30d612a
CY
47222012-04-20 Chong Yidong <cyd@gnu.org>
4723
4724 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4725 set the status to "failed" and ensure that sentinel is run.
4726
c07a4c0b 47272012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4728
4729 * process.c (Fset_process_inherit_coding_system_flag)
4730 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4731 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4732
c07a4c0b 47332012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4734
4735 * xdisp.c (string_buffer_position_lim): Limit starting position to
4736 BEGV.
4737 (set_cursor_from_row): If called for a mode-line or header-line
4738 row, return zero immediately.
4739 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4740 farther than the first row after the header line, if any.
4741 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4742 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4743
c07a4c0b 47442012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4745
4ae29f89
SM
4746 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4747 (bug#11238).
ad3a2b41 4748
c07a4c0b 47492012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47502012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4751
4752 configure: new option --enable-gcc-warnings (Bug#11207)
4753 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4754 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4755 (ALL_CFLAGS): Use new macros rather than old.
4756 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4757 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4758 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4759 -Wunused-result, -Wunused-variable. This should go away once
4760 the Emacs and Gnulib regex code is merged.
4761 (xmalloc, xrealloc): Now static.
4762
aba027e8
PE
47632012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 * dired.c (Fsystem_groups): Remove unused local.
4766
e5a36063
GM
47672012-04-17 Glenn Morris <rgm@gnu.org>
4768
4769 * dired.c (Fsystem_users): Doc fix.
4770
316411f0
DA
47712012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4772
4773 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4774 (syms_of_dired): Add them.
4775
9426aba4
PE
47762012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4777
b62a57be
PE
4778 Fix minor alloc.c problems found by static checking.
4779 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4780 New extern decls, to avoid calling undeclared functions.
4781 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4782 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4783 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4784 (NEED_MEM_INSERT): New macro.
4785 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4786 Remove one incorrect comment and fix another.
b62a57be 4787
3539f31f
PE
4788 Fix minor ralloc.c problems found by static checking.
4789 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4790 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4791 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4792 (r_alloc_sbrk): Now static.
4793
a041960a
PE
4794 Improve ralloc.c interface checking.
4795 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4796 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4797 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4798 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4799 [REL_ALLOC]: ... to here, to check interface.
4800 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4801 Remove decls. This fixes an "It stinks!".
4802
9426aba4
PE
4803 * alloc.c (which_symbols): Fix alignment issue / type clash.
4804
d55c12ed
AS
48052012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4806
4807 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4808 (struct Lisp_Misc_Any): Likewise.
4809 (struct Lisp_Free): Likewise.
4810 * alloc.c (union aligned_Lisp_Symbol): Define.
4811 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4812 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4813 (union aligned_Lisp_Misc): Define.
4814 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4815 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4816 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4817
b948ce8b
PE
48182012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4819
4820 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4821 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4822 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4823 * s/netbsd.h, s/sol2-6.h:
4824 Remove definition of GC_MARK_STACK, since the default now works.
4825 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4826 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4827 no longer the default.
4828 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4829
35dc09a1 48302012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4831
35dc09a1
GM
4832 * lread.c (lisp_file_lexically_bound_p):
4833 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4834
35dc09a1
GM
48352012-04-14 Eli Zaretskii <eliz@gnu.org>
4836
4837 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4838 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4839
48402012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4841
4842 * nsterm.m (constrainFrameRect): Always constrain when there is only
4843 one screen (Bug#10962).
4844
bcd86815
KB
48452012-04-13 Ken Brown <kbrown@cornell.edu>
4846
4847 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4848
c25df26e
RT
48492012-04-13 Reuben Thomas <rrt@sc3d.org>
4850
4851 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4852
0fc59f1e
DC
48532012-04-11 Daniel Colascione <dancol@dancol.org>
4854
4855 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4856 against is gone. It's better to use vfork now so that when Cygwin
4857 gains a new, working vfork, we use it automatically (bug#10398).
4858
de8c03dc
SM
48592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4860
4861 * window.c (save_window_save): Obey window-point-insertion-type.
4862
2f097256
GM
48632012-04-11 Glenn Morris <rgm@gnu.org>
4864
4865 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4866
453b951e
SM
48672012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4868
4869 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4870
75f1671a 48712012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4872
4873 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4874 (force_quit_count): New var.
4875 (handle_interrupt): Use it.
4876
2a8ce227
JB
48772012-04-10 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * w32.c (w32_delayed_load): Record the full path of the library
4880 being loaded (bug#10424).
4881
935396c0
GM
48822012-04-09 Glenn Morris <rgm@gnu.org>
4883
05920a43
GM
4884 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4885 not just in the obarray, before snarfing them. (Bug#11036)
4886
935396c0
GM
4887 * Makefile.in ($(leimdir)/leim-list.el):
4888 Pass EMACS rather than BUILT_EMACS.
4889
a18ecafa
TZ
48902012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4891
4892 * process.c (make_process):
4893 * process.h: Add integer `gnutls_handshakes_tried' member to
4894 process struct.
4895
6bbef4e5
JC
4896 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4897 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4898
4899 * gnutls.c (gnutls_log_function2i): Convenience log function.
4900 (emacs_gnutls_read): Use new log functions,
4901 `gnutls_handshakes_tried' process member, and
4902 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4903 attempts per process (connection).
4904
b4d3bc10
CY
49052012-04-09 Chong Yidong <cyd@gnu.org>
4906
4907 * eval.c (Fuser_variable_p, user_variable_p_eh)
4908 (lisp_indirect_variable): Functions deleted.
4909 (Fdefvar): Caller changed.
4910
4911 * callint.c (Finteractive, Fcall_interactively):
4912 * minibuf.c (Fread_variable): Callers changed.
4913
70f4d973
EZ
49142012-04-09 Eli Zaretskii <eliz@gnu.org>
4915
4916 * xdisp.c (set_cursor_from_row): If the display string appears in
4917 the buffer at position that is closer to point than the position
4918 after the display string, display the cursor on the first glyph of
4919 the display string. Fixes cursor display when a 'display' text
4920 property immediately follows invisible text. (Bug#11094)
4921
cb3c2e3e
PE
49222012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4923
4924 composite.c: use 'double' consistently
4925 * composite.c (get_composition_id): Use 'double' consistently
4926 instead of converting 'float' to 'double' and vice versa; this is
4927 easier to understand and avoids a GCC warning.
4928
fd06db5d
GM
49292012-04-09 Glenn Morris <rgm@gnu.org>
4930
50fe702a
GM
4931 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4932 preparation for dumping it with emacs. (Bug#4789)
4933 (leimdir): New variable.
4934 ($(leimdir)/leim-list.el): New rule.
4935 (emacs$(EXEEXT)): Depend on leim-list.el.
4936
fd06db5d
GM
4937 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4938 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4939 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4940
55c131ee
AS
49412012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4942
4943 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4944 proper alignment.
4945
9209588f
JB
49462012-04-07 Juanma Barranquero <lekktu@gmail.com>
4947
4948 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4949 Remove unused local variable.
4950
e3fb2efb
PE
49512012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4954 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4955 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4956 objects, as mark_maybe_pointer will catch them otherwise.
4957 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4958 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4959
b5385551
PE
49602012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4961
4962 Fix typo that broke non-Windows builds.
4963 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4964
9078ead6
EZ
49652012-04-07 Eli Zaretskii <eliz@gnu.org>
4966
4967 Support building on MS-Windows with libxml2.
4968
4969 * makefile.w32-in (OBJ2): Add xml.$(O).
4970 (GLOBAL_SOURCES): Add xml.c.
4971 ($(BLD)/xml.$(O)): New dependency list.
4972
4973 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4974 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4975 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4976 [!WINDOWSNT]: New macros.
4977 (init_libxml2_functions, libxml2_loaded_p): New functions.
4978 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4979 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4980 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4981 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4982 linked in).
6bbef4e5
JC
4983 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4984 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4985 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4986
4987 * emacs.c: Don't include libxml/parser.h.
4988 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4989 xmlCleanupParser directly.
4990
4991 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4992
3811fdf3
EZ
49932012-04-07 Eli Zaretskii <eliz@gnu.org>
4994
4995 * indent.c (Fvertical_motion): If there is a display string at
4996 point, use it.vpos to compute how many lines to backtrack after
4997 move_it_to point. (Bug#11133)
4998
2f8e16b2
EZ
49992012-04-06 Eli Zaretskii <eliz@gnu.org>
5000
5001 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5002 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5003 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5004 macros related to unification of CJK characters. For the details,
5005 see the discussion following the message here:
5006 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5007
3d439cd1
CY
50082012-04-04 Chong Yidong <cyd@gnu.org>
5009
5010 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5011
8bc53d00
EZ
50122012-04-01 Eli Zaretskii <eliz@gnu.org>
5013
5014 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5015 instead of alloca. (Bug#11138)
5016
3b0512a3
AS
50172012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5018
5019 * w32menu.c (is_simple_dialog): Properly check lisp types.
5020 (Bug#11141)
5021
8427ddd2
EZ
50222012-03-31 Eli Zaretskii <eliz@gnu.org>
5023
979022ef
EZ
5024 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5025 position we get to after a call to move_it_to fails the
5026 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5027 only if we wind up in a string from display property. (Bug#11063)
5028
a6b1c7cc
EZ
5029 * window.c (Fdelete_other_windows_internal): Invalidate the row
5030 and column information about mouse highlight, so that redisplay
5031 restores it after reallocating the glyph matrices. (Bug#7464)
5032
8427ddd2
EZ
5033 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5034 string comes from a `display' text property, use the buffer
5035 position of that property as if we actually saw that position in
5036 the row's glyphs.
697ba24b
EZ
5037 (move_it_by_lines): Remove the assertion that
5038 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5039 violated when there's a before-string at the beginning of a line.
5040 (Bug#11063)
8427ddd2 5041
65a0a738
EZ
50422012-03-30 Eli Zaretskii <eliz@gnu.org>
5043
5044 * xdisp.c (append_space_for_newline): If the default face was
5045 remapped, use the remapped face for the appended newline.
5046 (extend_face_to_end_of_line): Use the remapped default face for
5047 extending the face to the end of the line.
5048 (display_line): Call extend_face_to_end_of_line when the default
5049 face was remapped. (Bug#11068)
5050
581355cc
EZ
50512012-03-29 Eli Zaretskii <eliz@gnu.org>
5052
5053 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5054
e8fc049f
SM
50552012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5056
5057 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5058
4fb9a543
GM
50592012-03-27 Glenn Morris <rgm@gnu.org>
5060
5061 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5062 Doc fixes.
5063
679910f1
KH
50642012-03-26 Kenichi Handa <handa@m17n.org>
5065
5066 * dispextern.h (struct glyph): Fix previous change. Change the
5067 bit length of glyphless.ch to 25 (Bug#11082).
5068
90d49b7f
CY
50692012-03-26 Chong Yidong <cyd@gnu.org>
5070
5071 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5072 (command_loop_1): Use it; inhibit selection update for
5073 handle-select-window too (Bug#8996).
5074
f514f6f0
FP
50752012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5076
e8fc049f 5077 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5078
bf43fa51
KH
50792012-03-25 Kenichi Handa <handa@m17n.org>
5080
5081 * dispextern.h (struct glyph): Change the bit length of
5082 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5083
8a0c01dd
EZ
50842012-03-24 Eli Zaretskii <eliz@gnu.org>
5085
5086 * s/ms-w32.h (tzname): Include time.h before redirecting to
5087 _tzname. Fixes the MSVC build. (Bug#9960)
5088
7d1c3a76
AS
50892012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5090
8ed79523
AS
5091 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5092 characters.
5093
7d1c3a76
AS
5094 * xterm.c (XTread_socket): Only modify handling_signal if
5095 !SYNC_INPUT. (Bug#11080)
5096
e99a9b8b
EZ
50972012-03-23 Eli Zaretskii <eliz@gnu.org>
5098
5099 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5100 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5101 when fetching a multibyte character consumes more bytes than
5102 CHAR_BYTES returns, due to unification of CJK characters in
5103 string_char. (Bug#11073)
5104
5063c0e1
TN
51052012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5106
5107 * process.c (wait_reading_process_output): Handle pty disconnect
5108 by refraining from sending oneself a SIGCHLD (bug#10933).
5109
9f851fbd
CY
51102012-03-22 Chong Yidong <cyd@gnu.org>
5111
5112 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5113
5063c0e1 5114 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5115 Mark string as coming from a prefix property.
5116 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5117 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5118
fb5b8aca
CY
51192012-03-21 Chong Yidong <cyd@gnu.org>
5120
5121 * xfaces.c (Vface_remapping_alist): Doc fix.
5122
62356a1b
EZ
51232012-03-20 Eli Zaretskii <eliz@gnu.org>
5124
5125 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5126 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5127 Doc fixes.
62356a1b 5128
025de85b
CY
51292012-03-20 Chong Yidong <cyd@gnu.org>
5130
5131 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5132 to reflect default non-nil value of redisplay-dont-pause.
5133
4827f94e
KH
51342012-03-19 Kenichi Handa <handa@m17n.org>
5135
5136 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5137 it fit in a valid range (Bug#11003).
5138
e50a24a2
EZ
51392012-03-18 Eli Zaretskii <eliz@gnu.org>
5140
5141 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5142 that is not from display property, accept the row as a "cursor
5143 row" if one of the string's character has a non-nil `cursor'
5144 property. Fixes cursor positioning when there are newlines in
5145 overlay strings, e.g. in icomplete.el. (Bug#11035)
5146
9af5ed87
PE
51472012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5148
5149 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5150
d1f55f16
CY
51512012-03-12 Chong Yidong <cyd@gnu.org>
5152
5153 * eval.c (inhibit_lisp_code): Rename from
5154 inhibit_window_configuration_change_hook; move from window.c.
5155
5156 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5157 * window.c (run_window_configuration_change_hook)
5158 (syms_of_window): Callers changed.
5159
66c5eebd
CY
51602012-03-11 Chong Yidong <cyd@gnu.org>
5161
413df973
CY
5162 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5163
66c5eebd
CY
5164 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5165
1de11f56
CY
51662012-03-10 Chong Yidong <cyd@gnu.org>
5167
5168 * frame.c (other_visible_frames): Don't assume the selected frame
5169 is visible (Bug#10955).
5170
cae07000
SM
51712012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5172
5173 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5174
89c94350
JD
51752012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5176
5177 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5178 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5179 zero (Bug#10954).
5180
999dd333
GM
51812012-03-03 Glenn Morris <rgm@gnu.org>
5182
01a6dcc8 5183 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5184
de0100f2
EZ
51852012-03-02 Eli Zaretskii <eliz@gnu.org>
5186
5187 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5188 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5189 (redisplay_window, next_element_from_string): Fix typos in
5190 comments.
3e441275
EZ
5191 (redisplay_window): Pass to move_it_vertically the margin in
5192 pixels, not in screen lines.
de0100f2 5193
96a72ee9
GM
51942012-03-02 Glenn Morris <rgm@gnu.org>
5195
5196 * buffer.c (buffer-list-update-hook): Doc fix.
5197
312508d7
EZ
51982012-02-29 Eli Zaretskii <eliz@gnu.org>
5199
5200 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5201 push_it before setting up the iterator for the first overlay
5202 string, even if we have an empty string loaded.
5203 (next_overlay_string): If there's an empty string on the iterator
5204 stack, pop the stack. (Bug#10903)
5205
27f3c637
PE
52062012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5207
5208 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5209 Suggested by Stefan Monnier in
5210 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5211 * alloc.c (widen_to_Lisp_Object): New static function.
5212 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5213 and widening them to Lisp_Objects. This would work even if
5214 USE_LSB_TAG is defined and wide integers are used, which might
5215 happen in a future version of Emacs.
5216
3c9dfce6
CY
52172012-02-25 Chong Yidong <cyd@gnu.org>
5218
fa74b241
CY
5219 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5220 Doc fix.
5221
3c9dfce6
CY
5222 * xselect.c (Fx_selection_exists_p): Doc fix.
5223 (x_clipboard_manager_save_all): Print an informative message
5224 before saving to clipboard manager.
5225
9486df08
CY
52262012-02-24 Chong Yidong <cyd@gnu.org>
5227
5228 * keyboard.c (process_special_events): Handle all X selection
5229 requests in kbd_buffer, not just the next one (Bug#8869).
5230
f01d3321
CY
52312012-02-23 Chong Yidong <cyd@gnu.org>
5232
5233 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5234 call when setting menu-bar-lines and tool-bar-lines parameters.
5235 (unwind_create_frame_1): New helper function.
5236
5237 * window.c (inhibit_window_configuration_change_hook): New var.
5238 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5239 (syms_of_window): Initialize it.
f01d3321 5240
86b847b6
CY
52412012-02-22 Chong Yidong <cyd@gnu.org>
5242
5243 * xterm.c (x_draw_image_relief): Add missing type check for
5244 Vtool_bar_button_margin (Bug#10743).
5245
a59225b1
CY
52462012-02-21 Chong Yidong <cyd@gnu.org>
5247
5248 * fileio.c (Vfile_name_handler_alist): Doc fix.
5249
5250 * buffer.c (Fget_file_buffer): Protect against invalid file
5251 handler return value.
5252
310f5bd4
PE
52532012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5254
cb3a28cc
PE
5255 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5256 when computing $valmask.
5257
310f5bd4
PE
5258 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5259 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5260 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5261 It's useless in that case, and it can cause problems on hosts
5262 that allocate halves of EMACS_INT values separately.
5263 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5264 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5265 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5266 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5267 it avoids undefined behavior on hosts where shifting right by more
5268 than the word width has undefined behavior.
5269
2375c96a
CY
52702012-02-19 Chong Yidong <cyd@gnu.org>
5271
5272 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5273 (Funhandled_file_name_directory, Ffile_name_as_directory)
5274 (Fdirectory_file_name, Fexpand_file_name)
5275 (Fsubstitute_in_file_name): Protect against invalid file handler
5276 return values (Bug#10845).
5277
3eb49e71
EZ
52782012-02-18 Eli Zaretskii <eliz@gnu.org>
5279
5280 * .gdbinit (pitx): Fix incorrect references to fields of the
5281 iterator stack.
5282
7b926f3f
CY
52832012-02-17 Chong Yidong <cyd@gnu.org>
5284
5285 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5286
11273115
PE
52872012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5288
5289 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5290 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5291
c3a70e2b
CY
52922012-02-15 Chong Yidong <cyd@gnu.org>
5293
5294 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5295 marked as special. Also, starting docstrings with * is obsolete.
5296
0ca43699
AS
52972012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5298
5299 * gnutls.c (emacs_gnutls_write): Fix last change.
5300
2e8f3c56
LI
53012012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5302
5303 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5304 send_process.
5305
af70074f
SM
53062012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5307
5308 * keymap.c (Fsingle_key_description): Handle char ranges.
5309
95986d52
CY
53102012-02-12 Chong Yidong <cyd@gnu.org>
5311
afd83bd1
CY
5312 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5313 as that creates a dangerous corner case.
5314
95986d52
CY
5315 * window.c (Fdelete_window_internal): Invalidate the mouse
5316 highlight (Bug#9904).
5317
bd7da63e
GM
53182012-02-12 Glenn Morris <rgm@gnu.org>
5319
5320 * xselect.c (Fx_own_selection_internal)
5321 (Fx_get_selection_internal, Fx_disown_selection_internal)
5322 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5323 * nsselect.m (Fx_own_selection_internal)
5324 (Fx_disown_selection_internal, Fx_selection_exists_p)
5325 (Fx_selection_owner_p, Fx_get_selection_internal):
5326 Sync docs and argument specs with the xselect.c versions.
5327
77abcbc2
LI
53282012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5329
5330 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5331
90b671e2
EZ
53322012-02-11 Eli Zaretskii <eliz@gnu.org>
5333
1c0ca0b7
EZ
5334 * w32select.c (Fx_selection_exists_p): Sync doc string and
5335 argument list with xselect.c. (Bug#10783)
5336
5337 * w16select.c (Fx_selection_exists_p): Sync doc string and
5338 argument list with xselect.c. (Bug#10783)
90b671e2 5339
49241268
GM
53402012-02-10 Glenn Morris <rgm@gnu.org>
5341
5342 * fns.c (Fsecure_hash): Doc fix.
5343
f998bbe7 53442012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5345
5346 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5347
0992bd9c
CY
53482012-02-07 Chong Yidong <cyd@gnu.org>
5349
5350 * buffer.c (Fbuffer_local_variables)
5351 (buffer_lisp_local_variables): Handle unbound vars correctly;
5352 don't let Qunbound leak into Lisp.
5353
af008560
GM
53542012-02-07 Glenn Morris <rgm@gnu.org>
5355
dd605cc4
GM
5356 * image.c (Fimagemagick_types): Doc fix.
5357
af008560
GM
5358 * image.c (imagemagick-render-type): Change it from a lisp object
5359 to an integer. Move the doc here from the lisp manual.
5360 Treat all values not equal to 0 the same.
5361
1449fa1d
CY
53622012-02-06 Chong Yidong <cyd@gnu.org>
5363
5364 * doc.c (store_function_docstring): Avoid applying docstring of
5365 alias to base function (Bug#2603).
5366
3723ec07
AS
53672012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5368
5369 * .gdbinit (pp1, pv1): Remove redundant defines.
5370 (pr): Use pp.
5371
79c1cc1e
CY
53722012-02-04 Chong Yidong <cyd@gnu.org>
5373
5374 * nsterm.m: Declare a global (Bug#10694).
5375
d7f29f8e
EZ
53762012-02-04 Eli Zaretskii <eliz@gnu.org>
5377
cae07000
SM
5378 * w32.c (get_emacs_configuration_options):
5379 Include --enable-checking, if specified, in the return value.
d7f29f8e 5380
3b95a6f9
MR
53812012-02-04 Martin Rudalics <rudalics@gmx.at>
5382
5383 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5384 after rounding frame sizes. (Bug#9723)
5385
d6fa96a6
EZ
53862012-02-04 Eli Zaretskii <eliz@gnu.org>
5387
5388 * keyboard.c (adjust_point_for_property): Don't position point
5389 before BEGV. (Bug#10696)
5390
df0b2940
PE
53912012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5392
5393 Handle overflow when computing char display width (Bug#9496).
5394 * character.c (char_width): Return EMACS_INT, not int.
5395 (char_width, c_string_width): Check for overflow when
5396 computing the width; this is possible now that individual
5397 characters can have unbounded width. Problem introduced
5398 by merge from Emacs 23 on 2012-01-19.
5399
6bee44d6
MA
54002012-02-02 Michael Albinus <michael.albinus@gmx.de>
5401
5402 * dbusbind.c (Fdbus_register_method): Mention the return value
5403 :ignore in the docstring.
5404
44f92739
GM
54052012-02-02 Glenn Morris <rgm@gnu.org>
5406
1b9f60cc
GM
5407 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5408
44f92739
GM
5409 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5410 Unconditionally set to t. (Bug#10673)
5411 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5412 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5413 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5414
c5d3843c
KH
54152012-02-02 Kenichi Handa <handa@m17n.org>
5416
5417 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5418 0, do not call append_composite_glyph.
5419
159462d4 54202012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5421
5422 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5423 NULL (Bug#6988).
5424 (x_produce_glyphs): If the component of a composition is a null
5425 string, set it->pixel_width to 1 to avoid zero-width glyph.
5426
78cef877
EZ
54272012-02-01 Eli Zaretskii <eliz@gnu.org>
5428
5429 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5430 first 2 arguments are identical. This makes inserting large
5431 output from a subprocess an order of magnitude faster on
5432 MS-Windows, where all sbrk'ed memory is always contiguous.
5433
97897668
GM
54342012-01-31 Glenn Morris <rgm@gnu.org>
5435
5436 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5437 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5438 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5439
31fd3586
GM
54402012-01-29 Glenn Morris <rgm@gnu.org>
5441
5442 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5443
0e24a8b2
CY
54442012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5445
5446 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5447
cc0adcb0
CY
54482012-01-28 Chong Yidong <cyd@gnu.org>
5449
5450 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5451
acc28cb9
CY
54522012-01-26 Chong Yidong <cyd@gnu.org>
5453
9c69cfb7
CY
5454 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5455
acc28cb9
CY
5456 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5457 repeat counts (Bug#10507).
5458
48da7392
GM
54592012-01-26 Glenn Morris <rgm@gnu.org>
5460
5461 * lread.c (syms_of_lread): Doc fix.
5462
14af5f7f
CY
54632012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5464
5465 * coding.c (encode_designation_at_bol): Change return value to
5466 EMACS_INT.
5467
0b21c100
CY
54682012-01-25 Chong Yidong <cyd@gnu.org>
5469
5470 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5471
3c2907f7
CY
54722012-01-21 Chong Yidong <cyd@gnu.org>
5473
5474 * floatfns.c (Fcopysign): Make the second argument non-optional,
5475 since nil is not allowed anyway.
5476
959ad23f
AS
54772012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5478
5479 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5480 (send_process): Likewise.
5481
34a02f46
MR
54822012-01-19 Martin Rudalics <rudalics@gmx.at>
5483
5484 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5485 (Vwindow_persistent_parameters): Do not use Qstate.
5486 Rewrite doc-strings.
34a02f46 5487
1259009a 54882012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5489
5490 * character.c (char_width): New function.
70d4fdf6
GM
5491 (Fchar_width, c_string_width, lisp_string_width):
5492 Use char_width (Bug#9496).
25ed9e61 5493
6a6ee00d
MR
54942012-01-16 Martin Rudalics <rudalics@gmx.at>
5495
5496 * window.c (Vwindow_persistent_parameters): New variable.
5497 (Fset_window_configuration, save_window_save): Handle persistent
5498 window parameters.
5499
c85efaf7
EZ
55002012-01-14 Eli Zaretskii <eliz@gnu.org>
5501
5502 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5503 thrashing the stack of the thread. (Bug#9087)
5504
5944709e
PE
55052012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5508
e71f5d99
EZ
55092012-01-11 Eli Zaretskii <eliz@gnu.org>
5510
5511 * xdisp.c (rows_from_pos_range): Handle the case where the
5512 highlight ends on a newline. (Bug#10464)
5513 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5514 he end column for display of highlight that ends on a newline
5515 before a R2L line.
5516
ce316182
GM
55172012-01-11 Glenn Morris <rgm@gnu.org>
5518
5519 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5520 from load-path also when installation-directory is nil. (Bug#10208)
5521
5b43da69
GM
55222012-01-10 Glenn Morris <rgm@gnu.org>
5523
74cc8ff9
GM
5524 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5525
7d8d6e4e
GM
5526 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5527 Update template values to be closer to their typical values these days.
5b43da69 5528
a0db8d43
EZ
55292012-01-09 Eli Zaretskii <eliz@gnu.org>
5530
5531 * xdisp.c (rows_from_pos_range): Accept additional argument
5532 DISP_STRING, and accept any glyph in a row whose object is that
5533 string as eligible for mouse highlight. Fixes mouse highlight of
5534 display strings from overlays. (Bug#10464)
5535
9a0115ab 55362012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5537
b9110d6a 5538 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5539 * fileio.c (auto_saving_dir_umask): New static var.
5540 (Fmake_directory_internal): Use it.
5541 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5542 creating the directory. The old code temporarily assigns
5543 too-generous permissions to the directory.
5544 (do_auto_save_eh): Clear it.
b9110d6a 5545 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5546 that the var is always cleared.
5547
6c1bd3f3
EZ
55482012-01-07 Eli Zaretskii <eliz@gnu.org>
5549
5550 * search.c (scan_buffer): Pass character positions to
5551 know_region_cache, not byte positions. (Bug#6540)
5552
069d2b50
L
55532012-01-07 LynX <_LynX@bk.ru> (tiny change)
5554
5555 * w32.c (sys_rename): Report EXDEV when rename of a directory
5556 fails because the target is on another logical disk. (Bug#10284)
5557
75bf0d33
DB
55582012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5559
5560 * xterm.c (x_embed_request_focus): New function.
5561
5562 * xterm.h: Add prototype.
5563
5564 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5565
1c6e5a32
GM
55662012-01-05 Glenn Morris <rgm@gnu.org>
5567
5568 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5569
651e947e
EZ
55702012-01-01 Eli Zaretskii <eliz@gnu.org>
5571
5572 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5573 Load gnutls_transport_set_lowat only if GnuTLS version is below
5574 2.11.1.
5575 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5576 GnuTLS versions below 2.11.1.
5577
3778cdd8
AL
55782011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5579
5580 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5581 to the doc string advising against its use for altering the way
5582 windows are scrolled.
5583
0e5317f7
KH
55842011-12-28 Kenichi Handa <handa@m17n.org>
5585
5586 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5587 coding-system ASCII compatible only when it does not produce BOM
5588 on encoding (Bug#10383).
5589
93d5ca1f
JD
55902011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5591
5592 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5593 can scroll.
5594 (create_and_show_popup_menu): Always use menu_position_func for
5595 Gtk3 (Bug#10361).
5596
ca22b785
AS
55972011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5598
5599 * callint.c (Fcall_interactively): Don't truncate prompt string.
5600
d048e1e6
EZ
56012011-12-23 Eli Zaretskii <eliz@gnu.org>
5602
5603 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5604 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5605 resumed from there (after widening). (Bug#10360)
d048e1e6 5606
5ccaba1f
JD
56072011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5608
5609 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5610
204ee57f
JD
56112011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5612
b81d40f0
JB
5613 * nsterm.m (x_free_frame_resources):
5614 Release f->output_data.ns->miniimage.
204ee57f
JD
5615 (ns_index_color): Fix indentation. Do not retain
5616 color_table->colors[i].
5617
5618 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5619 before returning.
5620
5621 * nsfns.m (x_set_background_color): Assign return value from
5622 ns_index_color to face-background instead of NSColor*.
5623 (ns_implicitly_set_icon_type): Fix indentation.
5624 Change assignment in for loop to comparison.
5625
5626 * emacs.c (ns_pool): New variable.
5627 (main): Assign ns_pool.
5628 (Fkill_emacs): Call ns_release_autorelease_pool.
5629
5630 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5631 autorelease fdesc, release fdAttrs and tdict.
5632 (ns_get_covering_families): Release charset.
5633 (ns_findfonts): Release NSFontDescriptor created with new.
5634 (ns_uni_to_glyphs): Fix indentation.
5635 (setString): Release attrStr before assigning new value.
5636
c803b2b7
JD
56372011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5638
678f4426
JD
5639 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5640 and NS_IMPL_COCOA.
5641 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5642 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5643
cd394be1 56442011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5645
5fecd5fc
JD
5646 * nsterm.m (ns_term_init): Subscribe for notifications
5647 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5648 to method trackingNotification in EmacsMenu.
5649
5650 * nsmenu.m (trackingMenu): New variable.
3771cb17 5651 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5652 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5653 from Aquamacs (Bug#7030).
678f4426
JD
5654
56552011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5656
c803b2b7
JD
5657 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5658 (symbol_to_nsstring): Fix indentation.
5659 (ns_symbol_to_pb): New function.
cae07000
SM
5660 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5661 (Fns_rotate_cut_buffers_internal): Remove.
5662 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5663 Fns_store_cut_buffer_internal.
5664 (ns_get_foreign_selection, Fx_own_selection_internal)
5665 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5666 (Fns_get_selection_internal, Fns_store_selection_internal):
5667 Use ns_symbol_to_pb and check if return value is nil.
5668 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5669 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5670 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5671 renamed to Sns_store_selection_internal.
5672 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5673 and remove this function.
5674 (ns_handle_selection_clear): Remove, never used.
5675 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5676 here.
5677
e1b01a3a
KB
56782011-12-17 Ken Brown <kbrown@cornell.edu>
5679
5680 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5681 GID is unknown (Bug#10257).
5682
2adb6e85
PE
56832011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5684
5685 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5686 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5687 which caused a build failure on GNU/Linux IA-64. This problem was
5688 introduced by my 2011-10-07 patch.
5689
d1d7b339
JL
56902011-12-15 Juri Linkov <juri@jurta.org>
5691
5692 * image.c (imagemagick_error): New function. (Bug#10112)
5693 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5694 Use `imagemagick_error' where ImageMagick functions return
5695 `MagickFalse'.
5696 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5697 proper order.
5698
100d5755
KH
56992011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5700
5701 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5702 fill background (Bug#8992).
5703
454592a6
MR
57042011-12-13 Martin Rudalics <rudalics@gmx.at>
5705
5706 * window.c (Vwindow_combination_resize)
5707 (Vwindow_combination_limit): Use t instead of non-nil in
5708 doc-strings.
61d4b438
MR
5709 (Vrecenter_redisplay): Add first sentence of doc-string on
5710 separate line.
53524d93 5711 (Frecenter): Fix doc-string typo.
454592a6 5712
3633e3aa
KH
57132011-12-11 Kenichi Handa <handa@m17n.org>
5714
5715 * coding.c (Funencodable_char_position): Pay attention to the
5716 buffer text relocation (Bug#9389).
5717
7b9d523a 57182011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5719
7b9d523a
JD
5720 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5721 gtk_init (Bug#10100).
5722
b73189c6
EZ
57232011-12-10 Eli Zaretskii <eliz@gnu.org>
5724
5725 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5726 IT->string is nil. (Bug#10263)
5727
f7dfe5d6
JD
57282011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5729
83faebb4
JD
5730 * nsterm.h (x_free_frame_resources): Declare.
5731
f7dfe5d6
JD
5732 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5733 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5734
5735 * nsterm.h (ns_get_defaults_value): Declare.
5736
5737 * nsterm.m (ns_default): Call ns_get_defaults_value.
5738
7cd4e72c
EZ
57392011-12-09 Eli Zaretskii <eliz@gnu.org>
5740
5741 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5742 (Bug#10170)
5743
b34d7317
YM
57442011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5745
5746 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5747 that where the value of an _OBJC_* symbol points to is in the .bss
5748 section (Bug#10240).
5749
76470ad1
KH
57502011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5751
5752 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5753 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5754
745fff94
KH
57552011-12-08 Kenichi Handa <handa@m17n.org>
5756
5757 * ftfont.c (get_adstyle_property): Fix previous change
5758 (Bug#10233).
5759
6e44397c
JB
57602011-12-07 Juanma Barranquero <lekktu@gmail.com>
5761
5762 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5763 dirs from the default value of EMACSLOADPATH (bug#10208).
5764
7efa6272
GM
57652011-12-07 Glenn Morris <rgm@gnu.org>
5766
5767 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5768 installation and source directories as well. (Bug#10208)
5769
f6fc4d87
CY
57702011-12-06 Chong Yidong <cyd@gnu.org>
5771
5772 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5773
2bf26180
GM
57742011-12-06 Glenn Morris <rgm@gnu.org>
5775
5776 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5777 as an error, not just -1. (Bug#10217)
5778
3a6ad4f0
CY
57792011-12-05 Chong Yidong <cyd@gnu.org>
5780
5781 * keyboard.c (process_special_events): New function.
5782 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5783
75a3b399
PE
57842011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5785
5786 * coding.c (encode_designation_at_bol): Don't use uninitialized
5787 local variable (Bug#9318).
5788
c3c9e25e
KH
57892011-12-05 Kenichi Handa <handa@m17n.org>
5790
5791 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5792 return Qnil (Bug#8046, Bug#10193).
5793
5eb05ea3
KH
57942011-12-05 Kenichi Handa <handa@m17n.org>
5795
5796 * coding.c (encode_designation_at_bol): New args charbuf_end and
5797 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5798 (coding_set_source): Return how many bytes coding->source was
5799 relocated.
5800 (coding_set_destination): Return how many bytes
5801 coding->destination was relocated.
5802 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5803 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5804
58052011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5806
5807 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5808 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5809 macro (Bug#9318).
5810
58112011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5812
5813 The following changes are to fix Bug#9318.
5814
a79703f5 5815 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5816 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5817 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5818 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5819
7dbda6df
JB
58202011-12-05 Juanma Barranquero <lekktu@gmail.com>
5821
5822 * lisp.h (process_quit_flag): Fix external declaration.
5823
6d5eb5b0
SM
58242011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5825
5826 Don't macro-inline non-performance-critical code.
5827 * eval.c (process_quit_flag): New function.
5828 * lisp.h (QUIT): Use it.
5829
a0c3fad0
JD
58302011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5831
5832 * nsfns.m (get_geometry_from_preferences): New function.
5833 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5834
6c07aac2
AS
58352011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5836
5837 * emacs.c (Qkill_emacs): Define.
5838 (syms_of_emacs): Initialize it.
5839 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5840 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5841 (quit_throw_to_read_char): Add parameter `from_signal'.
5842 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5843 * lisp.h (QUIT): Call Fkill_emacs if requested.
5844
c052ead4
JD
58452011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5846
5847 * widget.c (update_wm_hints): Return if wmshell is null.
5848 (widget_update_wm_size_hints): New function.
5849
5850 * widget.h (widget_update_wm_size_hints): Declare.
5851
5852 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5853 widget_update_wm_size_hints (Bug#10104).
5854
9e49252b
EZ
58552011-12-03 Eli Zaretskii <eliz@gnu.org>
5856
5857 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5858 before a newline, prepare the bidi iterator for consuming the
5859 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5860 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5861
02b16839
JL
58622011-12-02 Juri Linkov <juri@jurta.org>
5863
5864 * search.c (Fword_search_regexp): New Lisp function created from
5865 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5866 (Fword_search_backward, Fword_search_forward)
5867 (Fword_search_backward_lax, Fword_search_forward_lax):
5868 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5869 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5870
0068070e
SM
58712011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5872
5873 * fileio.c (Finsert_file_contents): Move after-change-function call
5874 to before the "handled:" label, since all "goto handled" appear in
5875 cases where the *-change-functions have already been properly called
5876 (bug#10117).
5877
3360a3fc
AS
58782011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5879
5880 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5881 waiting for input. (Bug#10169)
5882
73d6c093
EZ
58832011-11-30 Eli Zaretskii <eliz@gnu.org>
5884
5885 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5886 verifies glyph row's hash code--we have just reallocated the
5887 glyphs, so their contents can be complete garbage. (Bug#10164)
5888
febe6bea
JB
58892011-11-30 Juanma Barranquero <lekktu@gmail.com>
5890
5891 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5892
801a4313
EZ
58932011-11-30 Eli Zaretskii <eliz@gnu.org>
5894
5895 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5896 attributes are tested _before_ calling verify_row_hash, to protect
5897 against GCC re-ordering of the tests. (Bug#10164)
5898
2b56b87e
JD
58992011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5900
5901 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5902
5903 * xterm.c (handle_one_xevent): Only set async_visible and friends
5904 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5905 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5906 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5907
dbf31225
PE
59082011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5909
5910 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5911 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5912 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5913 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5914 All uses changed to use GCPRO1 etc.
5915 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5916 Revert to old implementation (i.e., before 2011-03-11).
5917
1305621b
YM
59182011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5919
5920 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5921 of scroll runs so as to avoid assigning disabled bogus rows and
5922 unnecessary graphics copy operations.
5923
8c9afb46
EZ
59242011-11-27 Eli Zaretskii <eliz@gnu.org>
5925
5926 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5927 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5928 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5929 (malloc, free, realloc, calloc): Redirect to e_* only when
5930 compiling Emacs.
5931
5932 * lisp.h (GCTYPEBITS): Move before first use.
5933 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5934 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5935 this macro definition.
5936
5937 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5938 _MSC_VER.
5939
54e9e3bf
JD
59402011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5941
6d5eb5b0
SM
5942 * gtkutil.c (xg_create_frame_widgets):
5943 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5944 present with Gtk+ 2.0.
5945
83aca1cb
PE
59462011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5947
5948 * fileio.c (Finsert_file_contents): Undo previous change; see
5949 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5950
5b76caa4
PE
59512011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5952
5953 Rename locals to avoid shadowing.
5954 * fileio.c (Finsert_file_contents):
5955 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5956 * process.c (wait_reading_process_output):
5957 Rename inner 'proc' to 'p' to avoid shadowing.
5958 Indent for consistency with usual Emacs style.
5959
8c535114
EZ
59602011-11-25 Eli Zaretskii <eliz@gnu.org>
5961
5962 * xdisp.c (redisplay_window): If cursor row is not fully visible
5963 after recentering, and scroll-conservatively is set to a large
5964 number, scroll window by a few more lines to make the cursor fully
5965 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5966 (start_display): Don't move to the next line if the display should
5967 start at a newline that is part of a display vector or an overlay
5968 string. (Bug#10119)
8c535114 5969
fa4fdb5c
JL
59702011-11-24 Juri Linkov <juri@jurta.org>
5971
5972 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5973 after the `MagickPingImage' call. (Bug#10112)
5974
90ec88df
CY
59752011-11-23 Chong Yidong <cyd@gnu.org>
5976
5977 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5978
56e2e794
MR
59792011-11-23 Martin Rudalics <rudalics@gmx.at>
5980
5981 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5982 making another buffer current. (Bug#10114)
5983
b6e64c41
GM
59842011-11-23 Glenn Morris <rgm@gnu.org>
5985
5986 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5987
6b21de18
CY
59882011-11-23 Chong Yidong <cyd@gnu.org>
5989
5990 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5991 using it (Bug#5984).
5992
b12cd789
EZ
59932011-11-22 Eli Zaretskii <eliz@gnu.org>
5994
5995 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5996 and header-lines, as they don't have one computed for them.
5997 (Bug#10098)
5998
5999 * .gdbinit (prow): Make displayed values more self-explaining.
6000 Add row's hash code.
6001
261b6fd4
LMI
60022011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6003
6004 * process.c (wait_reading_process_output): Fix asynchrounous
6005 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6006 (wait_reading_process_output): Add comment and URL.
261b6fd4 6007
e7cfd277
JD
60082011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6009
6010 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6011
a9b9b7f5
CY
60122011-11-21 Chong Yidong <cyd@gnu.org>
6013
6014 * window.c (Fnext_window, Fprevious_window): Doc fix.
6015
b0d15b4f
SM
60162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6017
6018 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6019
fe7a3057
JB
60202011-11-20 Juanma Barranquero <lekktu@gmail.com>
6021
6022 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6023
d2999b1a
MR
60242011-11-20 Martin Rudalics <rudalics@gmx.at>
6025
6026 * window.c (Fset_window_combination_limit): Rename argument
6027 STATUS to LIMIT.
6028 (Vwindow_combination_limit): Remove "status" from doc-string.
6029
d5ff9cd0
AS
60302011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6031
6032 * m/ibms390.h: Remove.
6033 * m/ibms390x.h: Don't include "ibms390.h".
6034
a5bb9bd3
SM
60352011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6036
6037 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6038 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6039
cd1181db
JB
60402011-11-20 Juanma Barranquero <lekktu@gmail.com>
6041
6042 * casetab.c (Fset_case_table):
6043 * charset.c (Fcharset_after): Fix typos.
6044
615a3b8d 60452011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6046
17e845af
PE
6047 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6048 Otherwise, valgrind does not work on some platforms.
6049 Problem reported by Andreas Schwab in
6a0bf43d
PE
6050 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6051 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6052 is set, removing the need for VIRT_ADDRESS_VARIES.
6053 (PURE_P): Use a more-efficient implementation that needs just one
6054 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6055 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6056 to 4 (xorl, subq, cmpq, setbe).
6057 * alloc.c (pure): Always extern now, since that's the
6058 VIRT_ADDR_VARIES behavior.
6059 (PURE_POINTER_P): Use a single comparison, not two, for
6060 consistency with the new puresize.h.
6061 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6062 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6063 Remove VIRT_ADDR_VARIES no longer needed.
6064
f8fe6f96
EZ
60652011-11-19 Eli Zaretskii <eliz@gnu.org>
6066
6067 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6068 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6069 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6070 behave as if the cursor position were at the window margin.
6071
6072 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6073 and the cursor position is out of bounds, behave as if the cursor
6074 position were at the window margin. (Bug#10075)
6075
df05a53c
CY
60762011-11-18 Chong Yidong <cyd@gnu.org>
6077
6078 * window.c (Fwindow_combination_limit): Make first argument
6079 non-optional, since it is meaningless for live windows like the
6080 selected window.
61ccba97 6081
2071918e
DA
60822011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6083
6084 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6085
b50a28de
SM
60862011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6087
6088 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6089 (graft_intervals_into_buffer): Simplify.
6090
015137db
EZ
60912011-11-18 Eli Zaretskii <eliz@gnu.org>
6092
6093 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6094 hash values of the two rows.
6095 (copy_row_except_pointers): Preserve the used[] arrays and the
6096 hash values of the two rows. (Bug#10035)
68c95424 6097 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6098
6099 * xdisp.c (row_hash): New function, body extracted from
6100 compute_line_metrics.
6101 (compute_line_metrics): Call row_hash, instead of computing the
6102 hash code inline.
6103
6104 * dispnew.c (verify_row_hash): Call row_hash for computing the
6105 hash code of a row, instead of duplicating code from xdisp.c.
6106
6107 * dispextern.h (row_hash): Add prototype.
6108
a2addb04
TH
61092011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6110
6111 * frame.c (delete_frame): Don't delete the terminal when the last
6112 X frame is closed if emacs is built with GTK toolkit.
6113
df85d315
JB
61142011-11-17 Juanma Barranquero <lekktu@gmail.com>
6115
6116 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6117
a0c2d0ae
MR
61182011-11-17 Martin Rudalics <rudalics@gmx.at>
6119
6120 * window.c (Vwindow_splits): Rename to
6121 Vwindow_combination_resize. Suggested by Juri Linkov.
6122 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6123 of Vwindow_splits.
6124
58179cce
JB
61252011-11-16 Juanma Barranquero <lekktu@gmail.com>
6126
7877f373
JB
6127 * nsfns.m (Fns_font_name):
6128 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6129
b6f67890
MR
61302011-11-16 Martin Rudalics <rudalics@gmx.at>
6131
6132 * window.h (window): Rename slot "nest" to "combination_limit".
6133 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6134 (Fset_window_nest): Rename to Fset_window_combination_limit.
6135 (Vwindow_nest): Rename to Vwindow_combination_limit.
6136 (recombine_windows, make_parent_window, make_window)
6137 (Fsplit_window_internal, saved_window)
6138 (Fset_window_configuration, save_window_save): Rename all
6139 occurrences of window_nest to window_combination_limit.
6140
c7015153
JB
61412011-11-15 Juanma Barranquero <lekktu@gmail.com>
6142
6143 * image.c (imagemagick_load_image): Fix typo.
6144
322ad6ec
EZ
61452011-11-14 Eli Zaretskii <eliz@gnu.org>
6146
6147 * xdisp.c (display_line): Move the call to
6148 highlight_trailing_whitespace before the call to
6149 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6150 faces of all the glyphs to compute ROW's hash value.
6151 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6152
f067b8ec
JB
61532011-11-14 Juanma Barranquero <lekktu@gmail.com>
6154
6155 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6156 just return (bug#10044).
6157
1e5b2111
EZ
61582011-11-12 Eli Zaretskii <eliz@gnu.org>
6159
7ef3cbd5
EZ
6160 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6161 with user-defined heap size. Bump the default size of the temacs
6162 heap to 27MB, to avoid memory warning when running temacs.
6163 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6164
1e5b2111
EZ
6165 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6166 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6167 (verify_row_hash) [XASSERTS]: New function.
6168 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6169 that the hash value of glyph rows is correct.
1e5b2111 6170
89d61221
MR
61712011-11-12 Martin Rudalics <rudalics@gmx.at>
6172
6173 * window.h (window): Remove splits slot.
6174 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6175 (Fdelete_other_windows_internal, make_parent_window)
6176 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6177 (Fset_window_configuration, save_window_save): Don't deal with
6178 split status of windows.
6179 (saved_window): Remove splits slot.
6180 (Vwindow_splits): Rewrite doc-string.
6181
97f18cc8
JD
61822011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6183
6184 * xfns.c (unwind_create_frame):
6185 * nsfns.m (unwind_create_frame):
6186 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6187 Vframe_list (Bug#9999).
6188
22a648b4
DA
61892011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6190
0b381c7e 6191 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6192
659afede
KH
61932011-11-11 Kenichi Handa <handa@m17n.org>
6194
6195 * callproc.c (Fcall_process): Set the member dst_multibyte of
6196 process_coding.
6197
9ac0394b
KH
61982011-11-11 Johan Bockgård <bojohan@gnu.org>
6199
6200 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6201 avoid a crash (bug#9496).
6202
2fbdc249
CY
62032011-11-09 Chong Yidong <cyd@gnu.org>
6204
6205 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6206 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6207
ac6b1f81
PE
62082011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6209
6210 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6211
09db192c
PE
62122011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6213
6214 Avoid some portability problems by eschewing 'extern inline' functions.
6215 The trivial performance wins aren't worth the portability hassles; see
6216 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6217 et seq.
6218 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6219 (window_box_width, window_box_left, window_box_left_offset)
6220 (window_box_right, window_box_right_offset): Undo previous change,
6221 by removing the "extern"s.
6222 * intervals.c (adjust_intervals_for_insertion)
6223 (adjust_intervals_for_deletion): Undo previous change,
6224 making these static again.
6225 (offset_intervals, temp_set_point_both, temp_set_point)
6226 (copy_intervals_to_string): No longer inline.
6227 * xdisp.c (window_text_bottom_y, window_box_width)
6228 (window_box_height, window_box_left_offset)
6229 (window_box_right_offset, window_box_left, window_box_right)
6230 (window_box): No longer inline.
6231
105216ed
CY
62322011-11-08 Chong Yidong <cyd@gnu.org>
6233
6234 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6235 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6236 Signal an error if not a live window.
105216ed
CY
6237 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6238 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6239
ae9e237f
JB
62402011-11-07 Juanma Barranquero <lekktu@gmail.com>
6241
6242 * lisp.h (syms_of_abbrev): Remove declaration.
6243 Reported by CHENG Gao <chenggao@royau.me>.
6244
c7aa8333
EZ
62452011-11-07 Eli Zaretskii <eliz@gnu.org>
6246
6247 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6248 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6249 of temacs in GUI mode.
6250
be7f5545
MR
62512011-11-07 Martin Rudalics <rudalics@gmx.at>
6252
6253 * window.h: Declare delete_all_child_windows instead of
6254 delete_all_subwindows.
6255 * window.c (Fwindow_nest, Fset_window_nest)
6256 (Fset_window_new_total, Fset_window_new_normal)
6257 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6258 (delete_all_subwindows): Rename to delete_all_child_windows.
6259 (Fdelete_other_windows_internal, Fset_window_configuration):
6260 Call delete_all_child_windows instead of delete_all_subwindows.
6261 * frame.c (delete_frame): Call delete_all_child_windows instead
6262 of delete_all_subwindows.
6263
ca78dc43
PE
62642011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6265
6266 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6267 This is also needed for porting to any host where GC_MARK_STACK is
6268 not GC_MAKE_GCPROS_NOOPS.
6269 (which_symbols): Use it.
6270
a0241d01
KH
62712011-11-07 Kenichi Handa <handa@m17n.org>
6272
6273 * coding.c (coding_set_destination): Check coding->src_pos only
6274 when coding->src_object is a buffer (bug#9910).
6275
6276 * process.c (send_process): Set the member src_multibyte of coding
6277 to 0 (bug#9911) when sending a unibyte text.
6278
6279 * callproc.c (Fcall_process): Set the member src_multibyte of
6280 process_coding to 0 (bug#9912).
6281
a64bfdfa 62822011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6283
6284 * xmenu.c (cleanup_widget_value_tree): New function.
6285 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6286 calling free_menubar_widget_value_tree directly (Bug#9830).
6287
cb41b32a
PE
62882011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6289
6290 Fix some portability problems with 'inline'.
6291 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6292 (window_box_width, window_box_left, window_box_left_offset)
6293 (window_box_right, window_box_right_offset): Declare extern.
6294 Otherwise, these inline functions do not conform to C99 and
6295 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6296 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6297 * intervals.c (adjust_intervals_for_insertion)
6298 (adjust_intervals_for_deletion): Now extern, because otherwise the
6299 extern inline functions 'offset_intervals' couldn't refer to it.
6300 (static_offset_intervals): Remove.
6301 (offset_intervals): Rewrite using the old contents of
6302 static_offset_intervals. The old version didn't conform to C99
6303 because an extern inline function contained a reference to an
6304 identifier with static linkage.
6305
b7041366
AS
63062011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6307
6308 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6309 GC.
6310
88a37c4d
EZ
63112011-11-06 Eli Zaretskii <eliz@gnu.org>
6312
6313 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6314 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6315 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6316 return Qleft_to_right.
6317
49745b39
CY
63182011-11-06 Chong Yidong <cyd@gnu.org>
6319
6320 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6321 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6322 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6323 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6324 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6325 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6326 (Fwindow_vscroll): Doc fix.
6327 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6328 argument, since it makes no sense to pass a live window and for
6329 consistency with window-child.
6330
1f05cd82
CS
63312011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6332
6333 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6334 support MSVC.
6335
22610910
JR
63362011-11-05 Jason Rumney <jasonr@gnu.org>
6337
6338 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6339 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6340 fonts (Bug#6029).
6341 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6342 bitwise arithmetic preventing use of unicode-sip and non-truetype
6343 opentype fonts.
6344
a06776b2
EZ
63452011-11-05 Eli Zaretskii <eliz@gnu.org>
6346
3ad924ba
EZ
6347 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6348 "emacs"-only part.
6349
a06776b2
EZ
6350 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6351 initialization code to keep similarity to xfns.c after changes
6352 from 2011-11-05.
6353
c9e7db78
JD
63542011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6355
a97f8f3f
JD
6356 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6357 (unwind_create_frame): New function (Bug#9943).
6358 (Fx_create_frame): Restructure code to be more similar to the one in
6359 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6360 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6361 Move terminal->reference_count++ just before making the frame official
6362 (Bug#9943).
6363
6364 * nsterm.m (x_free_frame_resources): New function.
6365 (x_destroy_window): Move code to x_free_frame_resources.
6366
c9e7db78 6367 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6368 (Fx_create_frame, x_create_tip_frame):
6369 Move terminal->reference_count++ just before making the frame
75f1671a 6370 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6371 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6372
a6fc3b5c
EZ
63732011-11-05 Eli Zaretskii <eliz@gnu.org>
6374
6375 Support MSVC build with newer versions of Visual Studio.
6376 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6377 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6378 nt/gmake.defs.
6379
6380 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6381 which are not supported by MSVC.
6382 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6383 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6384 bitfields.
6385 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6386 types in bitfields.
6387 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6388
6389 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6390
58179cce 63912011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6392
6393 Support MSVC build with newer versions of Visual Studio.
6394 * w32.c: Don't include w32api.h for MSVC.
6395 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6396
6397 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6398 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6399 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6400 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6401 e_* cousins.
6402 (alloca) [_MSC_VER]: Define to _alloca.
6403
6404 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6405
6406 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6407
a58c13ed
EZ
64082011-11-04 Eli Zaretskii <eliz@gnu.org>
6409
6410 * xdisp.c (note_mouse_highlight): If either of
6411 previous/next-single-property-change returns nil, treat that as
6412 the beginning or the end of the buffer. (Bug#9955)
6413
fe0b6370
JD
64142011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6415
a58c13ed 6416 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6417 label is not null (Bug#9951).
6418 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6419 may be NULL.
6420
89bd5ee1
EZ
64212011-11-04 Eli Zaretskii <eliz@gnu.org>
6422
6423 * window.c (Fwindow_body_size): Mention in the doc string that the
6424 return value is in frame's canonical units. (Bug#9949)
6425
84c3edb9
EZ
64262011-11-03 Eli Zaretskii <eliz@gnu.org>
6427
4e2fb5c7
EZ
6428 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6429
84c3edb9 6430 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6431 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6432 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6433
bc17a887
EZ
64342011-11-01 Eli Zaretskii <eliz@gnu.org>
6435
6436 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6437 Don't stop backward scan on the continuation glyph, even though
6438 its CHARPOS is positive.
6d5eb5b0
SM
6439 (mouse_face_from_buffer_pos, note_mouse_highlight):
6440 Rename cover_string to disp_string.
bc17a887 6441
4ee88440
MR
64422011-11-01 Martin Rudalics <rudalics@gmx.at>
6443
6444 * window.c (temp_output_buffer_show): Don't use
6445 Vtemp_buffer_show_specifiers.
6446 (Vtemp_buffer_show_specifiers): Remove unused variable.
6447
c2ff3c02
EZ
64482011-10-30 Eli Zaretskii <eliz@gnu.org>
6449
6450 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6451 past the beginning of the current glyph matrix.
6452
58179cce 64532011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6454
6455 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6456 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6457 HAVE_GTK3 (Bug#9869).
b77a6a7f 6458
3b574623
JD
6459 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6460 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6461
b77a6a7f
JD
6462 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6463
6464 * xterm.c: Declare x_handle_net_wm_state to return int.
6465 (handle_one_xevent): Check if we are iconified but don't have
6466 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6467 (get_current_wm_state): Return non-zero if not hidden,
6468 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6469 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6470 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6471 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6472
196e41e4
PE
64732011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6474
6475 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6476 so that this new function doesn't get optimized away by a
6477 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6478
021f2e1a
AS
64792011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6480
6481 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6482
8b058d44
EZ
64832011-10-29 Eli Zaretskii <eliz@gnu.org>
6484
6485 Fix the `xbytecode' command.
6486 * .gdbinit (xprintbytestr): New command.
b50a28de 6487 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6488 (xbytecode): Print the byte-code string as well.
6489
4452fb80
EZ
64902011-10-29 Kim Storm <storm@cua.dk>
6491
8b058d44
EZ
6492 * alloc.c (which_symbols): New function.
6493
21b72067
AS
64942011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6495
6496 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6497 line. (Bug#9903)
6498
83ed7b5c
GM
64992011-10-29 Glenn Morris <rgm@gnu.org>
6500
6501 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6502 Not clear what it was for, and it causes various bugs. (Bug#9839)
6503
5a7a728b
EZ
65042011-10-28 Eli Zaretskii <eliz@gnu.org>
6505
6506 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6507 possible random value that matches one of those tested as
6508 condition to clear the mouse face.
6509
d3d0842f
CY
65102011-10-28 Chong Yidong <cyd@gnu.org>
6511
6512 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6513
31b39d13
DN
65142011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6515
6516 * window.c (make_window): Initialize phys_cursor_on_p.
6517
9aba6043
SM
65182011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6519
6520 * lisp.h (struct Lisp_Symbol): Update comments.
6521
c20992f4
JB
65222011-10-28 Juanma Barranquero <lekktu@gmail.com>
6523
6524 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6525
db4f02f2
EZ
65262011-10-28 Eli Zaretskii <eliz@gnu.org>
6527
6528 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6529 <oslsachem@gmail.com> for helping to debug this.
6530
6531 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6532 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6533 (g_b_init_get_glyph_outline_w): New static variables.
6534 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6535 (GetGlyphOutlineW_Proc): New typedefs.
6536 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6537 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6538 New functions.
6539 (w32font_open_internal, compute_metrics):
6540 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6541 instead of calling the "wide" APIs directly.
6542
6543 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6544
6545 * w32.h (syms_of_w32font): Add prototype.
6546
87e68db4
JB
65472011-10-27 Juanma Barranquero <lekktu@gmail.com>
6548
6549 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6550 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6551 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6552 (Fmove_to_window_line): Doc fix.
6553
435c1d67
CY
65542011-10-27 Chong Yidong <cyd@gnu.org>
6555
6556 * process.c (make_process): Set gnutls_state to NULL.
6557
6558 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6559 non-NULL, regardless of GNUTLS_INITSTAGE.
6560 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6561 an error. Set process slots as soon as we allocate them.
6562
6563 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6564
9c6c6f49
CY
65652011-10-27 Chong Yidong <cyd@gnu.org>
6566
9aba6043
SM
6567 * gnutls.c (emacs_gnutls_deinit): New function.
6568 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6569 (Fgnutls_deinit, Fgnutls_boot): Use it.
6570
6571 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6572 (deactivate_process): Call emacs_gnutls_deinit.
6573
657d08d3
JB
65742011-10-27 Juanma Barranquero <lekktu@gmail.com>
6575
6576 * image.c (x_create_x_image_and_pixmap):
6577 * w32.c (sys_rename, w32_delayed_load):
6578 * w32font.c (fill_in_logfont):
6579 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6580
5430d399
JB
65812011-10-26 Juanma Barranquero <lekktu@gmail.com>
6582
6583 * w32fns.c (w32_default_color_map): New function,
6584 extracted from Fw32_default_color_map.
a7ef684b 6585 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6586
fe0055fa
PE
65872011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6588
6589 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6590
e6346438
SM
65912011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6592
6593 * keyboard.c (test_undefined): New function (bug#9751).
6594 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6595
e112cc37
ET
65962011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6597
6598 * sysdep.c (init_sys_modes): Fix the check for the controlling
6599 terminal (Bug#6649).
6600
7b5d6677
EZ
66012011-10-20 Eli Zaretskii <eliz@gnu.org>
6602
6603 * dispextern.h (struct bidi_it): New member next_en_type.
6604
6605 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6606 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6607 current character, check also for next_en_type being WEAK_EN.
6608 (bidi_resolve_weak): Don't enter the expensive loop if the current
6609 position is before next_en_pos. Record the bidi type of the first
6610 non-ET, non-BN character we find, in addition to its position.
6611 (bidi_level_of_next_char): Invalidate next_en_type when
6612 next_en_pos is over-stepped.
6613
7da0b018
PE
66142011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6615
6616 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6617 * editfns.c: Rewrite current-time-zone so that it invokes
6618 the equivalent of (format-time-string "%Z") to get the time zone name.
6619 This fixes a bug when the time zone name contains characters that
6620 need converting from the system time locale to Emacs internal format.
6621 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6622 that patch fixed format-time-string to do the conversion, but
6623 I forgot to fix current-time-zone.
6624 (format_time_string): New function, containing most of
6625 what Fformat_time_string used to contain.
6626 (Fformat_time_string): Rewrite in terms of format_time_string.
6627 This doesn't change this function's behavior.
6628 (current-time-zone): Rewrite to use format_time_string.
6629 This fixes the bug reported by Michael Schierl in
6630 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6631 Jason Rumney's 2007-06-07 change worked around this bug, but
6632 didn't fix it.
6633 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6634
8547b010
EZ
66352011-10-19 Eli Zaretskii <eliz@gnu.org>
6636
6637 * xdisp.c (start_display): If the character at POS is displayed
6638 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6639 (try_window_reusing_current_matrix): If a line ends in a display
6640 vector or the next line starts in a display vector, continue
6641 redrawing the window even though the character position of
6642 start_row was reached.
8547b010
EZ
6643 (Bug#9771, part 2)
6644
4e948d15
CY
66452011-10-18 Chong Yidong <cyd@gnu.org>
6646
6647 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6648 with nobreak-char-display too.
6649
4787455f
EZ
66502011-10-18 Eli Zaretskii <eliz@gnu.org>
6651
6652 Fix part 3 of bug#9771.
6653 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6654 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6655 non-neutral characters if the current character is a paragraph
6656 separator (a.k.a. Newline). This avoids running the same
6657 expensive loop twice, once when we consume the preceding newline
6658 and the other time when the line actually needs to be displayed.
6659 Avoid the loop when we see neutrals on the base embedding level
6660 following a character whose directionality is the same as the
6661 paragraph's. This avoids running the expensive loop when a line
6662 ends in a long sequence of neutrals, like control characters.
6663 Add assertion against STRONG_AL type. Slightly rearrange code
6664 that determines the type of a neutral given the first non-neutral
6665 that follows it.
6666 (bidi_level_of_next_char): Set next_en_pos to zero when
6667 invalidating its info.
6668
2c91f553
EZ
66692011-10-17 Eli Zaretskii <eliz@gnu.org>
6670
6671 * xdisp.c (push_display_prop): Determine whether to record string
6672 or buffer position by IT->string, not by IT->method. Allow
6673 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6674 (move_it_vertically_backward): Don't look for character position
6675 immediately after the newline when in a continuation line.
6676 (Bug#9771, part 1)
2c91f553 6677
c7b08b0d
MR
66782011-10-15 Martin Rudalics <rudalics@gmx.at>
6679
6680 * window.c (coordinates_in_window): Rewrite and delabelize
6681 vertical border check. (Bug#5357) (Bug#9618)
6682
6b02f655
SM
66832011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6684
6685 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6686 errors in XSetWindowBorder (bug#9310).
6687
81d40c92
DA
66882011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6689
6690 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6691 avoid crash when xmalloc overrun checking is enabled.
6692
d4172c3b
EZ
66932011-10-13 Eli Zaretskii <eliz@gnu.org>
6694
6695 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6696 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6697 cursor motion with <left> and <right> arrow keys.
6698
6699 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6700 some callers set that themselves.
6701
b00eea75
EZ
67022011-10-12 Eli Zaretskii <eliz@gnu.org>
6703
6704 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6705 display string and the previous row comes from the same string and
6706 is empty. (Bug#9739) (Bug#9738)
6707
8fe012c4
SM
67082011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6709
6710 * doc.c (get_doc_string): Encode file name (bug#9735).
6711
0074aef2
EZ
67122011-10-12 Eli Zaretskii <eliz@gnu.org>
6713
79beb178
EZ
6714 * bidi.c (bidi_level_of_next_char):
6715 * xdisp.c (get_visually_first_element): Remove old incorrect
6716 comments regarding the Unicode Line Separator character.
6717
0074aef2
EZ
6718 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6719
6e4b3fbe
DA
67202011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6721
6722 * alloc.c (Fgc_status): Do not access beyond zombies array
6723 boundary if nzombies > MAX_ZOMBIES.
6724 * alloc.c (dump_zombies): Add missing format specifier.
6725
0324f3af
PE
67262011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6727
b5525cac
PE
6728 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6729 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6730
0324f3af
PE
6731 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6732 Some packages use them to denote characters with modifiers.
6733
e9b5f888
AS
67342011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6735
6736 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6737 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6738 matching a pp-number. Rename parameter var to var1.
6739
127827c0
SM
67402011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6741
6742 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6743
c8fd3bd0
GM
67442011-10-08 Glenn Morris <rgm@gnu.org>
6745
6746 * callint.c (Fcall_interactively): Give a more explicit error for the
6747 'c' case with a non-character input. (Bug#8479)
6748
352ec8ff
EZ
67492011-10-08 Eli Zaretskii <eliz@gnu.org>
6750
03669ccb
EZ
6751 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6752 lines.
7061c986
EZ
6753 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6754 lines that are hscrolled on the left.
03669ccb 6755
352ec8ff
EZ
6756 * dispnew.c (buffer_posn_from_coords): Account for a possible
6757 presence of header-line. (Bug#4426)
6758
a66cfb1c
SM
67592011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6760
6b02f655
SM
6761 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6762 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6763
7c5ee88e
PE
67642011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6765
6766 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6767 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6768 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6769 this makes Emacs dump core during garbage collection on rare
6770 occasions. sizeof is obviously inferior to offsetof here, so
6771 stick with offsetof.
6772 (GC_POINTER_ALIGNMENT): New macro.
6773 (mark_memory): Omit 3rd (offset) arg; caller changed.
6774 Don't assume EMACS_INT alignment is the same as pointer alignment.
6775
df1bbe5b
SM
67762011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6777
6778 * keyboard.c (read_key_sequence_remapped): New var.
6779 (read_key_sequence): Compute remapping in the right buffer.
6780 (command_loop_1): Use read_key_sequence's remapping directly.
6781
51553db6
SM
67822011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6783
32c1fffd
SM
6784 * dired.c (file_name_completion): Don't expand file name.
6785 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6786 before checking file name handler.
6787
51553db6
SM
6788 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6789 they've been requested explicitly (bug#9591).
6790
b6bd1599 67912011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6792
6793 * keymap.c (Fsingle_key_description): Use make_specified_string
6794 instead of build_string to build string from push_key_description.
6795 (Bug#5193)
6796
f701dc2a
PE
67972011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6798
4222c55d
PE
6799 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6800 This fixes a Y2038 bug on 64-bit hosts.
6801 * buffer.c (reset_buffer):
6802 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6803 (Fclear_buffer_auto_save_failure):
6804 Use 0, not -1, to represent an unset failure time, since time_t
6805 might not be signed.
6806
f701dc2a
PE
6807 Remove dependency on glibc malloc internals.
6808 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6809 Move back here from lisp.h, but with their new implementations.
6810 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6811 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6812 * charset.c (charset_table_init): New static var.
6813 (syms_of_charset): Use it instead of xmalloc. This removes a
6814 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6815 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6816 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6817 Move back to alloc.c.
6818 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6819 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6820
9ceebf39
JD
68212011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6822
6823 * nsterm.m (windowDidResize): Call x_set_window_size only when
6824 ns_in_resize is true. Otherwise set pixelwidth/height and
6825 call change_frame_size (Bug#9628).
6826
cb993c58
PE
68272011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6828
3930c88b
PE
6829 Port --enable-checking=all to Fedora 14 x86-64.
6830 * charset.c (syms_of_charset): Also account for glibc malloc's
6831 internal overhead when calculating the initial malloc maximum.
6832
cb993c58
PE
6833 Port --enable-checking=all to Fedora 14 x86.
6834 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6835 Move to lisp.h.
6836 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6837 (overrun_check_realloc, overrun_check_free):
6838 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6839 That way, xmalloc returns a properly-aligned pointer even if
6840 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6841 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6842 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6843 into account when calculating the initial malloc maximum.
6844 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6845 Move here from alloc.c, so that charset.c can use it too.
6846 Properly align; the old code wasn't right for common 32-bit hosts
6847 when configured with --enable-checking=all.
6848 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6849 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6850
31bed486
EZ
68512011-09-29 Eli Zaretskii <eliz@gnu.org>
6852
04c70788 6853 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6854 use EDOM.
6855
fbcaa2f3
EZ
68562011-09-28 Eli Zaretskii <eliz@gnu.org>
6857
6858 * xdisp.c (compute_display_string_end): If there's no display
6859 string at CHARPOS, return -1.
6860
6861 * bidi.c (bidi_fetch_char): When compute_display_string_end
6862 returns a negative value, treat the character as a normal
6863 character not covered by a display string. (Bug#9624)
6864
a239d4e9
JB
68652011-09-28 Juanma Barranquero <lekktu@gmail.com>
6866
6867 * lread.c (Fread_from_string): Fix typo in docstring.
6868
88652fd5
EZ
68692011-09-27 Eli Zaretskii <eliz@gnu.org>
6870
6871 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6872 newline, reseat the iterator instead of bidi-iterating there one
6873 character at a time. (Bug#9610)
32c1fffd
SM
6874 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6875 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6876
ed497dd4
AS
68772011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6878
6879 * lread.c (readevalloop): Use correct code for NBSP.
6880 (read1): Likewise. (Bug#9608)
6881
b2bf61aa
MA
68822011-09-25 Michael Albinus <michael.albinus@gmx.de>
6883
6884 * dbusbind.c (Fdbus_register_signal): When service is not
6885 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6886
32bbb17c
GM
68872011-09-25 Glenn Morris <rgm@gnu.org>
6888
6889 * buffer.c (truncate-lines): Doc fix.
6890
94e0933e
CY
68912011-09-24 Chong Yidong <cyd@stupidchicken.com>
6892
6893 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6894 (Fset_window_next_buffers): Doc fix.
6895
cddde921
GM
68962011-09-24 Glenn Morris <rgm@gnu.org>
6897
6898 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6899
1260aef1
PE
69002011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6901
25b4bfa0
PE
6902 Fix minor problems found by static checking.
6903 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6904 * indent.c (Fvertical_motion): Fix == vs = typo.
6905
e3cbd34b
EZ
69062011-09-24 Eli Zaretskii <eliz@gnu.org>
6907
a66cfb1c
SM
6908 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6909 Default value is now t. Doc fix.
6bf7006f 6910
e3cbd34b 6911 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6912 logic when moving up, not only when moving down. Fix the
e3cbd34b 6913 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6914 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6915
6916 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6917 CHARPOS is covered by a display string which includes newlines.
6918 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6919 is covered by a display string with embedded newlines.
6920
a3de0cbd
MA
69212011-09-24 Michael Albinus <michael.albinus@gmx.de>
6922
6923 * dbusbind.c (Fdbus_register_signal): Add match rule to
6924 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6925 (Fdbus_register_method, Vdbus_registered_objects_table):
6926 Fix docstring.
a3de0cbd 6927
b260039d
JM
69282011-09-24 Jim Meyering <meyering@redhat.com>
6929
32c1fffd 6930 do not ignore write error for any output size
b260039d
JM
6931 The previous change was incomplete.
6932 While it makes emacs --batch detect the vast majority of stdout
6933 write failures, errors were still ignored whenever the output size is
6934 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6935 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6936 && echo FAIL: ignored write error
6937 FAIL: ignored write error
6938 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6939 && echo FAIL: ignored write error
6940 FAIL: ignored write error
6941 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6942
8eca8a7c
AS
69432011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6944
6945 * emacs.c (Fkill_emacs): In noninteractive mode exit
6946 non-successfully if a write error occurred on stdout. (Bug#9574)
6947
3341db62
EZ
69482011-09-21 Eli Zaretskii <eliz@gnu.org>
6949
6950 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6951 the xassert test.
6952
6953 * dispextern.h (struct it): Update the comment documenting what
6954 can it->OBJECT be.
6955
8c203dbf
EZ
69562011-09-20 Eli Zaretskii <eliz@gnu.org>
6957
6958 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6959 a display string, extend search for cursor position to end of row.
6960 (find_row_edges): If the row ends in a newline from a display
6961 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6962 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6963 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6964 non-empty line. Fixes confusing cursor motion with arrow keys at
6965 the beginning of a line that starts with whitespace.
8c203dbf 6966
a4824228
LMI
69672011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6968
6969 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6970 (bug#9493).
6971
33ed493b
CY
69722011-09-18 Chong Yidong <cyd@stupidchicken.com>
6973
6974 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6975 boolean (Bug#9154).
6976
56cd55c8
EZ
69772011-09-18 Eli Zaretskii <eliz@gnu.org>
6978
6979 * xdisp.c (display_line): Record maximum and minimum buffer
6980 positions even if no glyphs were produced (e.g., by a zero-width
6981 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6982 buffer positions that will be removed from the glyph row because
6983 they don't fit.
c02dcedf
EZ
6984 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6985 column is beyond frame width: don't subtract 1 "pixel" when
6986 computing width of the stretch.
3e62b7e0
EZ
6987 (reseat_at_next_visible_line_start): Undo the change made on
6988 2011-09-17 that saved paragraph information and restored it after
6989 the call to `reseat'. (Bug#9545)
56cd55c8 6990
5ed99d36 69912011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6992
6993 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6994 and turn window cursor on if cleared (Bug#9415).
6995
5ed99d36 69962011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6997
6998 * search.c (boyer_moore): Take unibyte characters from pattern
6999 literally. (Bug#9458)
7000
9bade7b2
EZ
70012011-09-18 Eli Zaretskii <eliz@gnu.org>
7002
7003 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7004
e5e9d610
PE
70052011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7006
87e4427a
PE
7007 Fix minor problem found by static checking.
7008 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7009 initialized, to pacify gcc -Wuninitialized.
7010
e5e9d610
PE
7011 * fileio.c: Report proper errno when syscall falls.
7012 (Finsert_file_contents): Save and restore errno,
7013 so that report_file_error outputs the correct diagnostic.
7014 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7015
a1674f0b
EZ
70162011-09-18 Eli Zaretskii <eliz@gnu.org>
7017
7018 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7019
fbfb6dd4
EZ
70202011-09-17 Eli Zaretskii <eliz@gnu.org>
7021
7022 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7023 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7024
bb187662
EZ
70252011-09-17 Eli Zaretskii <eliz@gnu.org>
7026
1137e8b8 7027 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7028 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7029
7030 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7031 (bidi_find_paragraph_start): Search back for paragraph beginning
7032 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7033 (bidi_move_to_visually_next): Only trigger paragraph-related
7034 computations when the last character is a newline or at EOB, not
7035 just any NEUTRAL_B. (Bug#9470)
7036
bb187662
EZ
7037 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7038 truncated lines if point is covered by a display string. (Bug#9524)
7039
2e621251
PE
70402011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7041
7042 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7043 (cons_to_x_long): New function.
7044 (lisp_data_to_selection_data): Use it. Correct the test for
7045 short-versus-long data; it was negated. Break out of vector
7046 loop, for efficiency, when a long datum is discovered.
7047
91a15bc6
SM
70482011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7049
7050 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7051
b41c3a35
EZ
70522011-09-16 Eli Zaretskii <eliz@gnu.org>
7053
7054 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7055 GCC PR/17406) by declaring this function with external scope.
7056
7812ba2d
PE
70572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7058
7059 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7060 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7061
cf7edc2a
AS
70622011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7063
7064 * editfns.c (Fformat): Correctly handle text properties on "%%".
7065
bd01620e
EZ
70662011-09-15 Eli Zaretskii <eliz@gnu.org>
7067
7068 * xterm.c (x_draw_composite_glyph_string_foreground):
7069 * w32term.c (x_draw_composite_glyph_string_foreground):
7070 * term.c (encode_terminal_code):
7071 * composite.c (composition_update_it, get_composition_id):
7072 * xdisp.c (get_next_display_element)
7073 (fill_composite_glyph_string): Add comments about special meaning
7074 of TAB characters in a composition.
7075
a02719a3
PE
70762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7077
7078 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7079 This occurs when processing a multibyte format.
7080 Problem reported by Wolfgang Jenker.
a02719a3 7081
72589a3c
JB
70822011-09-15 Johan Bockgård <bojohan@gnu.org>
7083
7084 * xdisp.c (try_cursor_movement): Only check for exact match if
7085 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7086
1c14176c
PE
70872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7088
7089 Remove unused external symbols.
7090 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7091 * xdisp.c (calc_pixel_width_or_height): Now static.
7092 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7093 * indent.c (check_display_width):
7094 * w32term.c: Fix comment to match code.
7095 * xterm.c, xterm.h (x_catching_errors): Remove.
7096
d2eea5b5
PE
70972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7098
7099 * xselect.c: Use signed conversions more consistently (Bug#9498).
7100 (selection_data_to_lisp_data): Assume incoming selection data are
7101 signed integers, not unsigned. This is to be consistent with
7102 outgoing selection data, which was modified to use signed integers
7103 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7104 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7105 expects long, not unsigned long.
7106
46888499
EZ
71072011-09-14 Eli Zaretskii <eliz@gnu.org>
7108
7109 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7110 computation of loop end. Reported by Johan Bockgård
7111 <bojohan@gnu.org>.
7112
ef8ef9fb
CY
71132011-09-13 Chong Yidong <cyd@stupidchicken.com>
7114
7115 * frame.c (Fother_visible_frames_p): Function deleted.
7116
fa819fed
EZ
71172011-09-12 Eli Zaretskii <eliz@gnu.org>
7118
7119 * indent.c (compute_motion): Process display vector front to back
7120 rather than the other way around. (Bug#2496)
7121
2ba8e008
SM
71222011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7123
7124 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7125
20f53c69
CY
71262011-09-11 Chong Yidong <cyd@stupidchicken.com>
7127
7128 * minibuf.c (Fread_from_minibuffer): Doc fix.
7129
d562d7a4
EZ
71302011-09-11 Eli Zaretskii <eliz@gnu.org>
7131
7132 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7133 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7134
1c4d7f3d
LMI
71352011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7136
7137 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7138 value for non-existent files.
7139
b885bf36
EZ
71402011-09-11 Eli Zaretskii <eliz@gnu.org>
7141
7142 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7143 set its "size" to -1. This will set the modtime_size field of
7144 the corresponding buffer to -1, which is what
7145 verify-visited-file-modtime expects for files that do not exist.
7146 (Bug#9139)
7147
6612f0bf
PE
71482011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7149
7150 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7151 here ...
7152 * lisp.h: ... from here. push_key_description is no longer
7153 defined in keyboard.c, so its declaration should not be in
7154 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7155 logically belongs with push_key_description.
7156
dfb3f755
PE
71572011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7158
7159 * buffer.h: Include <sys/types.h> instead of <time.h>.
7160 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7161 Problem reported by Herbert J. Skuhra.
7162
3134906c
LMI
71632011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7164
7165 * xml.c (parse_region): Make the parsing work for
7166 non-comment-starting XML files again (bug#9144).
7167
8d903f4e
AS
71682011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7169
7170 * image.c (gif_load): Fix calculation of bottom and right corner.
7171 (Bug#9468)
7172
80ad64f4
EZ
71732011-09-10 Eli Zaretskii <eliz@gnu.org>
7174
7175 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7176 redisplay in small windows.
7177
208a048d
EZ
71782011-09-09 Eli Zaretskii <eliz@gnu.org>
7179
7180 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7181
9b1c252e
MR
71822011-09-08 Martin Rudalics <rudalics@gmx.at>
7183
7184 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7185 Operate on live windows only.
7186
2949f33b
JB
71872011-09-08 Juanma Barranquero <lekktu@gmail.com>
7188
7189 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7190
e08dcafd
EZ
71912011-09-07 Eli Zaretskii <eliz@gnu.org>
7192
7193 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7194 only under bidi iteration.
7195
115b96bd
JD
71962011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7197
7198 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7199
c8199d0f
PE
72002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7201
7202 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7203 Without this fix, the command to link temacs failed due to an
7204 undefined symbol __builtin_isnan. This is because
7205 /usr/include/iso/math_c99.h #defines isnan(x) to
7206 __builtin_isnan(x), but the bundled gcc, which identifies itself
7207 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7208 a __builtin_isnan.
7209 * floatfns.c (isnan): #undef, and then #define to a clone of
7210 what's in data.c.
7211 (Fisnan): Always define, since it's always available now.
7212 (syms_of_floatfns): Always define isnan at the Lisp level.
7213
e39b275c 72142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7215
7216 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7217
b2db44d9 72182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7219
f4af5137 7220 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7221 The previous code assumed that file offsets (off_t values) fit in
7222 EMACS_INT variables, which is not true on typical 32-bit hosts.
7223 The code messed up by falsely reporting buffer overflow in cases
7224 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7225 when "big" contains more than 2**29 bytes, even though this
7226 inserts just one byte and does not overflow the buffer.
7227 (Finsert_file_contents): Store file offsets as off_t
7228 values, not as EMACS_INT values. Check for overflow when
7229 converting between EMACS_INT and off_t. When checking for
7230 buffer overflow or for overlap, take the offsets into account.
7231 Don't use EMACS_INT for small values where int suffices.
7232 When checking for overlap, fix a typo: ZV was used where
7233 ZV_BYTE was intended.
7234 (Fwrite_region): Don't assume off_t fits into 'long'.
7235 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7236
ecfc0a49
MA
72372011-09-05 Michael Albinus <michael.albinus@gmx.de>
7238
7239 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7240
6511acf2 72412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7242
0999621a 7243 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7244
7245 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7246 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7247 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7248 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7249 (modify_event_symbol): Do not assume that the length of
7250 name_alist_or_stem is safe to alloca and fits in int.
7251 (Fexecute_extended_command): Likewise for function name and binding.
7252 (Frecursion_depth): Wrap around reliably on integer overflow.
7253 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7254 since some callers pass EMACS_INT values.
7255 (Fsingle_key_description): Don't crash if symbol name contains more
7256 than MAX_ALLOCA bytes.
7257 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7258 (get_minibuffer): Arg is now EMACS_INT, not int.
7259 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7260 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7261 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7262
2be7d702
PE
7263 * dbusbind.c (signature_cat): New function.
7264 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7265 Do not overrun buffer; instead, report string overflow.
7266
9d1df220
PE
7267 * dispnew.c (add_window_display_history): Don't overrun buffer.
7268 Truncate instead; this is OK since it's just a log.
7269
33ef5c64
PE
7270 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7271 even if the time zone offset is outlandishly large.
7272 Don't mishandle offset == INT_MIN.
7273
66c6fdd5
PE
7274 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7275 when creating daemon; the previous buffer-overflow check was incorrect.
7276
d749b01b
PE
7277 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7278 which has the guts of the old verror function.
7279
b5cd1905
PE
7280 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7281 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7282
6e1a67fb
PE
7283 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7284 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7285 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7286 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7287 length of string rather than counting it via multiple sprintfs;
7288 that's simpler and more reliable.
c21721cc
PE
7289 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7290 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7291 sprintf, in case result does not fit in int.
7292
c57b67fc
PE
7293 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7294 (fontset_from_font): Print it.
7295
8a401434
PE
7296 * frame.c (tty_frame_count): Now printmax_t, not int.
7297 (make_terminal_frame, set_term_frame_name): Print it.
7298 (x_report_frame_params): In X, window IDs are unsigned long,
7299 not signed long, so print them as unsigned.
7300 (validate_x_resource_name): Check for implausibly long names,
7301 and don't assume name length fits in 'int'.
7302 (x_get_resource_string): Don't blindly alloca invocation name;
7303 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7304 not fit in int.
7305
6e1a67fb
PE
7306 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7307 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7308 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7309
0df02bf3
PE
7310 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7311 Use esprintf, not sprintf, in case result does not fit in int.
7312
48e30793
PE
7313 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7314 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7315 it as a large positive number.
7316 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7317 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7318
a66ff6d8
PE
7319 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7320 in case result does not fit in int.
7321
aca216ff
PE
7322 * print.c (float_to_string): Detect width overflow more reliably.
7323 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7324 buffer overrun. Don't assume list length fits in 'int'. Treat
7325 print length of 0 as 0, not as infinity; to be consistent with other
7326 uses of print length in this function. Don't overflow print length
7327 index. Don't assume hash table size fits in 'long', or that
7328 vectorlike size fits in 'unsigned long'.
7329
31c286f7
PE
7330 * process.c (make_process): Use printmax_t, not int, to format
7331 process-name gensyms.
7332
55e5faa1
PE
7333 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7334
80f2e268
PE
7335 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7336 to avoid potential buffer overrun.
7337
670741ab
PE
7338 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7339 if X resource line is longer than 512 bytes.
7340
b7163a50
PE
7341 * xfns.c (x_window): Make sprintf buffer a bit bigger
7342 to avoid potential buffer overrun.
7343
ae58ff1f
PE
7344 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7345
c43c8a6a
PE
7346 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7347
3f8236f4
PE
73482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7349
53e9fe90 7350 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7351 Without these, Emacs silently mishandles large integers sometimes.
7352 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7353 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7354
6511acf2
PE
7355 * xdisp.c (try_window_id): Check Emacs fixnum range before
7356 converting to 'int'.
806add1d 7357
6511acf2 7358 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7359 Check that an Emacs fixnum is in range before assigning it to 'int'.
7360 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7361 values converted from Emacs fixnums.
7362 (Frecenter): Don't wrap around a line count if it is out of 'int'
7363 range; instead, treat it as an extreme value.
7364 (Fset_window_configuration, compare_window_configurations):
7365 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7366
6511acf2
PE
7367 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7368 that can exceed INT_MAX. Check that EMACS_INT value is in range
7369 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7370 (match_limit): Don't assume that a fixnum can fit in 'int'.
7371
6511acf2 7372 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7373 exceed INT_MAX.
7374
6511acf2 7375 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7376 (Fvertical_motion): Don't wrap around LINES values that don't fit
7377 in 'int'. Instead, treat them as extreme values. This is good
7378 enough for windows, which can't have more than INT_MAX lines anyway.
7379
fcb901a7
LMI
73802011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7381
0f2f6b6d
LMI
7382 * Require libxml/parser.h to avoid compilation warning.
7383
fcb901a7
LMI
7384 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7385
7386 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7387 since this reportedly can destroy thread storage.
7388
6e20a0d4
CY
73892011-08-30 Chong Yidong <cyd@stupidchicken.com>
7390
7391 * syntax.c (find_defun_start): Update all cache variables if
7392 exiting early (Bug#9401).
7393
148ae00e
EZ
73942011-08-30 Eli Zaretskii <eliz@gnu.org>
7395
f6cfbd8f
EZ
7396 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7397
148ae00e
EZ
7398 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7399 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7400 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7401
7402 * term.c (tty_append_glyph): New function.
7403 (produce_stretch_glyph): Static function and its prototype deleted.
7404
a66cfb1c
SM
7405 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7406 Add prototypes.
148ae00e 7407
c4a07a4c
PE
74082011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7409
7410 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7411 when checking :margin (Bug#9390).
7412 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7413 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7414 so that the name doesn't mislead. All uses changed.
7415
6bc8cd65
JB
74162011-08-28 Johan Bockgård <bojohan@gnu.org>
7417
7418 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7419 set_tty_hooks.
7420
dca4927e
EZ
74212011-08-27 Eli Zaretskii <eliz@gnu.org>
7422
7423 * xdisp.c (move_it_to): Don't bail out early when reaching
7424 position beyond to_charpos, if we are scanning backwards.
7425 (move_it_vertically_backward): When DY == 0, make sure we get to
7426 the first character in the line after the newline.
7427
f2cad773
PE
74282011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7429
7430 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7431 (ccl_driver): Do not generate an out-of-range pointer.
7432 (Fccl_execute_on_string): Remove unnecessary check for
7433 integer overflow, noted by Stefan Monnier in
7434 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7435 Remove a FIXME that didn't need fixing.
7436 Simplify the newly-introduced buffer reallocation code.
7437
0cae2cdb
JB
74382011-08-27 Juanma Barranquero <lekktu@gmail.com>
7439
7440 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7441
5fc295a4 74422011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7443
70c60eb2 7444 Integer and memory overflow issues (Bug#9196).
726e0ab1 7445
d31850da
PE
7446 * doc.c (get_doc_string): Rework so that
7447 get_doc_string_buffer_size is the actual buffer size, rather than
7448 being 1 less than the actual buffer size; this makes xpalloc more
7449 convenient.
7450
a69fbedb
PE
7451 * image.c (x_allocate_bitmap_record, cache_image):
7452 * xselect.c (Fx_register_dnd_atom):
7453 Simplify previous changes by using xpalloc.
7454
fe5c5d37
PE
7455 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7456 since either will do and ptrdiff_t is convenient with xpalloc.
7457
0065d054
PE
7458 * charset.c (charset_table_size)
7459 (struct charset_sort_data.priority): Now ptrdiff_t.
7460 (charset_compare): Don't overflow if priorities differ greatly.
7461 (Fsort_charsets): Don't assume list length fits in int.
7462 Check for size-calculation overflow when allocating sort data.
7463 (syms_of_charset): Allocate an initial charset table that is
7464 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7465
7466 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7467
7468 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7469 The actual value is always <= INT_MAX, and leaving it unsigned made
7470 overflow checking harder.
7471
7472 * dispextern.h (struct glyph_matrix.rows_allocated)
7473 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7474 with xpalloc. The values are still always <= INT_MAX.
7475
7476 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7477
7478 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7479 (SAFE_NALLOCA): New macro.
7480
7481 * region-cache.c (struct boundary.pos, find_cache_boundary)
7482 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7483 (set_cache_region, invalidate_region_cache)
7484 (revalidate_region_cache, know_region_cache, region_cache_forward)
7485 (region_cache_backward, pp_cache):
7486 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7487 so that ptrdiff_t * can be passed to xpalloc.
7488 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7489 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7490 (pp_cache): Don't assume cache_len fits in int.
7491 * region-cache.h: Adjust extern decls to match.
7492
7493 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7494 EMACS_INT, since either will do, for xpalloc.
7495
7496 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7497 (xnmalloc, xnrealloc, xpalloc): New functions.
7498
726e0ab1
PE
7499 * bidi.c (bidi_shelve_header_size): New constant.
7500 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7501 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7502
51f30bc5 7503 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7504 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7505 (overlay_strings):
7506 Don't update size of array until after memory allocation succeeds,
7507 because xmalloc/xrealloc may not return.
0065d054
PE
7508 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7509 now that we have proper integer overflow checking.
7510 (record_overlay_string, overlay_strings): Catch overflows when
7511 calculating size of overlay_str_buf.
726e0ab1 7512
0065d054
PE
7513 * callproc.c (Fcall_process): Check for size overflow when
7514 calculating size of args2.
7515 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7516 Normally we prefer signed values, but sticking with ptrdiff_t would
7517 require adding more-complicated checks.
726e0ab1
PE
7518
7519 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7520 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7521 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7522 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7523
7524 * character.c (Fstring): Check for size-calculation overflow.
7525
7526 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7527 unnecessary integer overflow. Check for size overflow.
7528 (encode_coding_object): Don't update size until xmalloc succeeds.
7529
7530 * composite.c (get_composition_id): Check for overflow in glyph
7531 length calculations.
7532
7533 Integer and memory overflow fixes for display code.
7534 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7535 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7536 (scrolling_window): Check for overflow in size calculations.
7537 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7538 Don't assume glyph table len fits in int.
7539 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7540 (row_table_size): Now ptrdiff_t, not int.
7541 (scrolling_window): Avoid overflow in size calculations.
7542 Don't update size until allocation succeeds.
7543 * fns.c (concat): Check for overflow in size calculations.
7544 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7545 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7546 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7547
7548 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7549 (get_doc_string): Check for size calculation overflow.
7550 Don't update size until allocation succeeds.
7551 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7552 EMACS_INT, where ptrdiff_t will do.
7553 (Fsubstitute_command_keys): Check for string overflow.
7554
7555 * editfns.c (set_time_zone_rule): Don't assume environment length
7556 fits in int.
7557 (message_length): Now ptrdiff_t, not int.
7558 (Fmessage_box): Don't update size until allocation succeeds.
7559 Don't assume message length fits in int.
7560 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7561
0065d054
PE
7562 * emacs.c (main): Do not reallocate argv, since there is a null at
7563 the end that can be overwritten, and this way there's no need to
7564 worry about size-calculation overflow.
7565 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7566
7567 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7568 alloc succeeds.
7569 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7570
7571 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7572 (x_set_scroll_bar_width, x_figure_window_size):
7573 Check for integer overflow.
7574 (x_set_alpha): Do not assume XINT fits in int.
7575
7576 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7577 This is for the members text_lines, text_cols, total_lines, total_cols,
7578 where the system imposes an 'int' limit.
7579
7580 * fringe.c (Fdefine_fringe_bitmap):
7581 Don't update size until alloc works.
7582
7583 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7584 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7585
7586 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7587 Check for size-calculation overflow.
7588 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7589 do, as we prefer signed integers.
7590 (id_to_widget.max_size, id_to_widget.used)
7591 (xg_store_widget_in_map, xg_remove_widget_from_map)
7592 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7593 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7594 Use and return ptrdiff_t, not int.
7595 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7596 * gtkutil.h: Change prototypes to match the above.
7597
7598 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7599 are duplicate now that they've been promoted to lisp.h.
7600 (x_allocate_bitmap_record, x_alloc_image_color)
7601 (make_image_cache, cache_image, xpm_load):
7602 Don't update size until alloc is done.
7603 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7604 (x_detect_edges):
3256efce 7605 Check for size calculation overflow.
726e0ab1
PE
7606 (ct_colors_allocated_max): New constant.
7607 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7608 overflow.
3256efce 7609
726e0ab1
PE
7610 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7611 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7612 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7613 Use ptrdiff_t, not int, to count maps.
7614 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7615 calculations. Don't update size until allocation succeeds.
7616 Redo calculations to avoid overflow.
726e0ab1
PE
7617 * keyboard.h: Change prototypes to match the above.
7618
7619 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7620 to count maps.
7621 (current_minor_maps): Check for size calculation overflow.
7622 * keymap.h: Change prototypes to match the above.
7623
7624 * lread.c (read1, init_obarray): Don't update size until alloc done.
7625
7626 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7627 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7628
726e0ab1
PE
7629 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7630 Now ptrdiff_t, not int.
7631 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7632 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7633
7634 * process.c (Fnetwork_interface_list): Check for overflow
7635 in size calculation.
7636
7637 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7638
7639 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7640 overflow. Don't bother calling xmalloc when xrealloc will do.
7641
7642 * search.c (Freplace_match): Check for size calculation overflow.
7643 (Fset_match_data): Don't assume list lengths fit in 'int'.
7644
7645 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7646 for command line length. Do not attempt to address one before the
7647 beginning of an array, as that's not portable.
7648
7649 * term.c (max_frame_lines): Remove; unused.
7650 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7651 not int.
7652 (encode_terminal_code, calculate_costs): Check for size
7653 calculation overflow.
7654 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7655 table lengths and related sizes. Don't update size until alloc
7656 done. Redo calculations to avoid overflow.
7657 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7658
7659 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7660 subtracting pointers.
7661 (gobble_line): Check for overflow more carefully. Don't update size
7662 until alloc done.
7663
7664 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7665 Don't update size until alloc done.
7666 Redo size calculations to avoid overflow.
7667 Check for size calculation overflow.
0065d054 7668 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7669
7670 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7671 Use ptrdiff_t, not int, for sizes.
7672 (store_mode_line_noprop_char): Don't update size until alloc done.
7673
0065d054
PE
7674 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7675 Use ptrdiff_t, not int, for sizes.
7676 (Finternal_make_lisp_face, cache_face):
7677 Check for size calculation overflow.
7678 (cache_face): Treat size calculation overflows as if they were
7679 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7680
7681 * xfns.c (x_encode_text, x_set_name_internal)
7682 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7683 sizes, since they can exceed INT_MAX in size. Check for size
7684 calculation overflow.
7685
0065d054
PE
7686 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7687 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7688 Don't update size until alloc done.
7689
0065d054 7690 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7691 as sprintf is limited to int lengths.
1d526e2f 7692
252c5ee1
PE
7693 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7694 (X_LONG_MIN): New macros.
864d7ce7
PE
7695 Use them to make the following changes clearer.
7696 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7697 This change doesn't affect the value now, but it may help remind
7698 future maintainers not to raise the value too much later.
7699 (SELECTION_QUANTUM): Remove, replacing with ...
7700 (selection_quantum): ... new function, which avoids overflow.
7701 All uses changed.
7702 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7703 assumption that selection length fits in 'int'.
7704 (x_reply_selection_request, x_handle_selection_request)
7705 (x_get_window_property, receive_incremental_selection)
7706 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7707 (lisp_data_to_selection_data, clean_local_selection_data):
7708 Use ptrdiff_t, not int, to record length of selection.
7709 (x_reply_selection_request, x_get_window_property)
7710 (receive_incremental_selection, x_property_data_to_lisp):
7711 Redo calculations to avoid overflow.
7712 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7713 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7714 something.
7715 (x_get_window_property, receive_incremental_selection)
7716 (lisp_data_to_selection_data, x_property_data_to_lisp):
7717 Check for size-calculation overflow.
7718 (x_get_window_property, receive_incremental_selection)
7719 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7720 Don't store size until memory allocation succeeds.
7721 (x_get_window_property): Plug memory leak on memory exhaustion.
7722 Don't double-block input; malloc is safe here. Don't assume 2**34
7723 - 4 fits in unsigned long. Add an xassert to check
7724 XGetWindowProperty overflow. Be more careful about overflow
7725 calculations, and distinguish size from memory overflow better.
7726 (receive_incremental_selection): When tracing, don't assume
7727 unsigned int is less than INT_MAX.
7728 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7729 harmful) conversions of unsigned short to int.
7730 (lisp_data_to_selection_data): Don't assume that integers
7731 in the range -65535 through -1 fit in an X unsigned short.
7732 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7733 result parameters unless successful. Rely on cons_to_unsigned
7734 to report problems with elements; the old code wasn't right anyway.
7735 (x_check_property_data): Check for int overflow; we cannot use
7736 a wider type due to X limits.
7737 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7738
726e0ab1 7739 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7740
0065d054
PE
7741 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7742 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7743 (x_color_cells): Don't store size until memory allocation succeeds.
7744 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7745 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7746 (x_term_init): Don't assume length fits in int (sprintf is limited
7747 to int size).
bc18e09d 7748
ebfa62c0
PE
7749 Use ptrdiff_t for composition IDs.
7750 * character.c (lisp_string_width):
7751 * composite.c (composition_table_size, n_compositions)
7752 (get_composition_id, composition_gstring_from_id):
7753 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7754 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7755 * window.c (Frecenter):
7756 Use ptrdiff_t, not int, for composition IDs.
7757 * composite.c (get_composition_id): Check for integer overflow.
7758 * composite.h: Adjust prototypes to match the above changes.
7759
d3411f89
PE
7760 Use ptrdiff_t for hash table indexes.
7761 * category.c (hash_get_category_set):
7762 * ccl.c (ccl_driver):
7763 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7764 * coding.c (coding_system_charset_list, detect_coding_system):
7765 * coding.h (struct coding_system.id):
7766 * composite.c (get_composition_id, gstring_lookup_cache):
7767 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7768 * image.c (xpm_get_color_table_h):
7769 * lisp.h (hash_lookup, hash_put):
7770 * minibuf.c (Ftest_completion):
7771 Use ptrdiff_t for hash table indexes, not int (which is too
7772 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7773 32-bit --with-wide-int hosts).
7774
e097a6fa
PE
7775 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7776 Add a FIXME comment about memory leaks.
7777 (syms_of_charset): Don't assume xmalloc returns.
7778
5637687f
PE
7779 Don't assume that stated character widths fit in int.
7780 * character.c (Fchar_width, c_string_width, lisp_string_width):
7781 * character.h (CHAR_WIDTH):
7782 * indent.c (MULTIBYTE_BYTES_WIDTH):
7783 Use sanitize_char_width to avoid undefined and/or bad behavior
7784 with outlandish widths.
a66cfb1c 7785 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7786 now that we have two such functions. All uses changed.
7787 (sanitize_char_width): New inline function.
7788
a2271ba2
PE
7789 Don't assume that tab-width fits in int.
7790 * character.h (sanitize_width): New inline function.
7791 (SANE_TAB_WIDTH): New macro.
7792 (ASCII_CHAR_WIDTH): Use it.
7793 * indent.c (sane_tab_width): Remove. All uses replaced by
7794 SANE_TAB_WIDTH (current_buffer).
7795 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7796
18c52557
PE
7797 * fileio.c: Integer overflow issues with file modes.
7798 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7799
caeeedc1
PE
7800 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7801 Remove unreachable code.
7802 (read_hex, load_charset_map_from_file): Check for integer overflow.
7803
6df6ae42 7804 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7805 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7806 (x_send_scroll_bar_event): Likewise. Check that the size does not
7807 exceed limits imposed by XClientMessageEvent, as well as the usual
7808 ptrdiff_t and size_t limits.
7809
b13995db
PE
7810 * keyboard.c: Overflow, signedness and related fixes.
7811 (make_lispy_movement): Use same integer type in forward decl
7812 that is used in the definition.
7813 (read_key_sequence, keyremap_step):
7814 Change bufsize argument back to int, undoing my 2011-03-30 change.
7815 We prefer signed types, and int is wide enough here.
7816 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7817 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7818 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7819 length, not size_t. Use ptrdiff_t for index, not int.
7820 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7821 possibility of integer overflow.
7822
13464394
PE
7823 Overflow, signedness and related fixes for images.
7824
7825 * dispextern.h (struct it.stack[0].u.image.image_id)
7826 (struct_it.image_id, struct image.id, struct image_cache.size)
7827 (struct image_cache.used, struct image_cache.ref_count):
7828 * gtkutil.c (update_frame_tool_bar):
7829 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7830 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7831 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7832 * nsmenu.m (update_frame_tool_bar):
7833 * xdisp.c (calc_pixel_width_or_height):
7834 * xfns.c (image_cache_refcount):
7835 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7836 on typical 64-bit hosts.
7837
7838 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7839 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7840 Omit unnecessary casts to int.
7841 (parse_image_spec): Check that integers fall into 'int' range
7842 when the callers expect that.
7843 (image_ascent): Redo ascent calculation to avoid int overflow.
7844 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7845 (lookup_image): Remove unnecessary tests.
7846 (xbm_image_p): Locals are now of int, not EMACS_INT,
7847 since parse_image_check makes sure they fit into int.
7848 (png_load, gif_load, svg_load_image):
7849 Prefer int to unsigned where either will do.
7850 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7851 old tiff_error_handler and tiff_warning_handler.
7852 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7853 stack buffer overflows. It uses only the features of vsnprintf
7854 that are common to both POSIX and native Microsoft.
7855 (tiff_error_handler, tiff_warning_handler): Use it.
7856 (tiff_load, gif_load, imagemagick_load_image):
7857 Don't assume :index value fits in 'int'.
7858 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7859 (imagemagick_load_image): Check that crop parameters fit into
7860 the integer types that MagickCropImage accepts. Don't assume
7861 Vimagemagick_render_type has a nonnegative value. Don't assume
7862 size_t fits in 'long'.
7863 (gs_load): Use printmax_t to print the widest integers possible.
7864 Check for integer overflow when computing image height and width.
7865
c11821d4
EZ
78662011-08-26 Eli Zaretskii <eliz@gnu.org>
7867
7868 * xdisp.c (redisplay_window): Don't force window start if point
7869 will be invisible in the resulting window. (Bug#9324)
7870
0c95fcf7
EZ
78712011-08-25 Eli Zaretskii <eliz@gnu.org>
7872
7873 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7874 the display spec is of the form `(space ...)'.
7875 (handle_display_spec): Return the value returned by
7876 handle_single_display_spec, not just 1 or zero.
7877 (handle_single_display_spec): If the display spec is of the form
7878 `(space ...)', and specifies display in the text area, return 2
7879 rather than 1.
fee65a97 7880 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7881 accurately, and prefer exact match for point under bidi.
7882 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7883
7884 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7885 into disp_prop; all users changed.
7886
7887 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7888 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7889 for the text covered by the display property.
7890
e4ed06f1
CY
78912011-08-25 Chong Yidong <cyd@stupidchicken.com>
7892
7893 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7894 Change return value to nil.
7895 (Frecord_buffer): Delete unused function.
7896
f67cdd7f
EZ
78972011-08-24 Eli Zaretskii <eliz@gnu.org>
7898
5980d4c6
EZ
7899 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7900 buffers, return left-to-right.
8610fe8b
EZ
7901 (set_cursor_from_row): Consider candidate row a win if its glyph
7902 represents a newline and point is on that newline. Fixes cursor
7903 positioning on the newline at EOL of R2L text within L2R
7904 paragraph, and vice versa.
7905 (try_cursor_movement): Check continued rows, in addition to
7906 continuation rows. Fixes unwarranted scroll when point enters a
7907 continued line of R2L text within an L2R paragraph, or vice versa.
7908 (cursor_row_p): Consider the case of point being equal to
7909 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7910 from the end of a short line to the beginning of a continued line
7911 of R2L text within L2R paragraph.
7912 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7913 composed characters.
5980d4c6 7914
f67cdd7f
EZ
7915 * bidi.c (bidi_check_type): Use xassert.
7916 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7917 members.
7918
bca633fb
EZ
79192011-08-23 Eli Zaretskii <eliz@gnu.org>
7920
7921 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7922 a character.
7923
4a5885a7
CY
79242011-08-23 Chong Yidong <cyd@stupidchicken.com>
7925
7926 * nsfont.m (ns_otf_to_script): Fix typo.
7927
0902a04e
KH
79282011-08-22 Kenichi Handa <handa@m17n.org>
7929
7930 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7931 extra slot even if the purpose is char-code-property-table.
7932
1a2e6670
EZ
79332011-08-23 Eli Zaretskii <eliz@gnu.org>
7934
8ddde651
EZ
7935 * xdisp.c (redisplay_window): When computing centering_position,
7936 account for the height of the header line. (Bug#8874)
7937
425cc014
EZ
7938 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7939 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7940 candidate is selected by the mouse, and that candidate has a
7941 composed character under the mouse.
7942
1a2e6670
EZ
7943 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7944 coordinates reported by pos-visible-in-window-p for a composed
7945 character in column zero.
7946
8b76d6f8
SM
79472011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7948
7949 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7950
dac347dd
EZ
79512011-08-22 Eli Zaretskii <eliz@gnu.org>
7952
7953 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7954 consider it a hit if to_charpos is anywhere in the range of the
7955 composed buffer positions.
7956
e013fb34
CY
79572011-08-22 Chong Yidong <cyd@stupidchicken.com>
7958
7959 * image.c (gif_load): Don't assume that each subimage has the same
7960 dimensions as the base image. Handle disposal method that is
7961 "undefined" by the gif spec (Bug#9335).
7962
bd1ba3e8
CY
79632011-08-20 Chong Yidong <cyd@stupidchicken.com>
7964
7965 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7966 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7967
54a1215b
EZ
79682011-08-19 Eli Zaretskii <eliz@gnu.org>
7969
823564e5
EZ
7970 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7971 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7972 from an Org mode buffer to a Speedbar frame.
7973
54a1215b
EZ
7974 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7975 a composition, take its buffer position from IT->cmp_it.charpos.
7976 Fixes cursor positioning at the beginning of a line that begins
7977 with a composed character.
7978
9778ebcc
EZ
79792011-08-18 Eli Zaretskii <eliz@gnu.org>
7980
0be6ee06
EZ
7981 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7982 character bidirectional type, use STRONG_L instead. Fixes crashes
7983 in a buffer produced by `describe-categories'.
7984
9778ebcc
EZ
7985 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7986 members before the level stack, so they would be saved and
7987 restored when copying iterator state. Fixes incorrect reordering
7988 around TABs covered by display properties.
7989
156bffbe
AS
79902011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7991
6b02f655 7992 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7993
72ad093b
CY
79942011-08-17 Chong Yidong <cyd@stupidchicken.com>
7995
7996 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7997 (internal_condition_case_2, internal_condition_case_n):
7998 Remove unnecessary aborts (Bug#9081).
72ad093b 7999
35774242
EZ
80002011-08-17 Eli Zaretskii <eliz@gnu.org>
8001
8002 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8003 has no `load' handler, try opening the file locally. (Bug#9311)
8004
db76dd85
KB
80052011-08-16 Ken Brown <kbrown@cornell.edu>
8006
8007 * gmalloc.c: Expand comment.
8008
b215eee5
EZ
80092011-08-16 Eli Zaretskii <eliz@gnu.org>
8010
8011 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8012 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8013
a4579d33
KB
80142011-08-16 Ken Brown <kbrown@cornell.edu>
8015
8016 Fix memory allocation problems in Cygwin build (Bug#9273).
8017
8018 * unexcw.c ( __malloc_initialized): Declare external variable.
8019 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8020
8b76d6f8
SM
8021 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8022 New variables.
a4579d33
KB
8023 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8024 dumped emacs.
8025 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8026 in the static heap.
8027 [CYGWIN] (special_realloc): New function.
8028 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8029 requests to realloc storage in the static heap.
8030
3ebec551
PE
80312011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8032
8033 * bidi.c (bidi_initialize): Remove unused local.
8034
9fd8be00
EZ
80352011-08-15 Eli Zaretskii <eliz@gnu.org>
8036
6b02f655
SM
8037 * bidimirror.h:
8038 * biditype.h: Remove file.
8039 * makefile.w32-in ($(BLD)/bidi.$(O)):
8040 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8041
8042 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8043
8044 * chartab.c: Improve commentary for the uniprop_table API.
8045
32413314
EZ
8046 * bidi.c (bidi_paragraph_init): Support zero value of
8047 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8048 (bidi_initialize): Use uniprop_table instead of including
8049 biditype.h and bidimirror.h.
32413314 8050
9fd8be00
EZ
8051 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8052 coordinates of the iterator when restoring from ppos_it.
8053 (Bug#9296)
8054
5cf2b69b
KH
80552011-08-14 Kenichi Handa <handa@m17n.org>
8056
8057 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8058 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8059
daf17d00
EZ
80602011-08-14 Eli Zaretskii <eliz@gnu.org>
8061
8062 * xdisp.c (move_it_in_display_line_to): Don't invoke
8063 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8064 ppos_it. Fixes vertical cursor motion when line beginning is
8065 covered by an image. (Bug#9296)
8066
08e3161a
JD
80672011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8068
8069 * nsterm.h (ns_run_ascript): Declare.
8070 (NSAPP_DATA2_RUNASSCRIPT): Define.
8071
8072 * nsfns.m (as_script, as_result, as_status): New static variables.
8073 (ns_run_ascript): New function.
5e617bc2 8074 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8075 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8076 the event loop. Get status from as_status (Bug#7276).
8077
8078 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8079 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8080 the event loop (Bug#7276).
8081
a3720aa2
AS
80822011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8083
8084 * gnutls.c (QCgnutls_bootprop_priority)
8085 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8086 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8087 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8088 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8089 (QCgnutls_bootprop_verify_hostname_error)
8090 (QCgnutls_bootprop_callbacks_verify): Rename from
8091 Qgnutls_bootprop_..., all uses changed.
8092
8093 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8094 uses changed.
8095
0a0d27fb
PE
80962011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8097
19d5c50c
PE
8098 * xfaces.c (Qframe_set_background_mode): Now static.
8099 * dispextern.h (Qframe_set_background_mode): Remove decl.
8100
0a0d27fb
PE
8101 * process.c (Fnetwork_interface_info): Declare local only if needed.
8102
377538cb
JD
81032011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8104
8105 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8106 (Fnetwork_interface_list): Allocate in increments of bytes instead
8107 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8108 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8109 sockaddr.
8110 (struct ifflag_def): notrailers is smart on OSX.
8111 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8112 Get hardware address with getifaddrs if available.
8113
08fff70c
EZ
81142011-08-12 Eli Zaretskii <eliz@gnu.org>
8115
8116 * xdisp.c (iterate_out_of_display_property): xassert that
8117 IT->position is set to within IT->object's boundaries. Break from
8118 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8119 when IT->position is set up wrongly due to some bug.
8120 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8121 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8122 entry. Force push_it to save on the stack the current
8123 buffer/string position, to be restored by pop_it. Fix flags in
8124 the iterator structure wrt the object coming from a display
8125 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8126 properties. (Bug#9284)
8127
7be1c708 81282011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8129
7be1c708
CY
8130 * fontset.c (fontset_get_font_group): Add proper type checks.
8131 (Bug#9172)
aac0c6e3 8132
7be1c708 81332011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8134
7be1c708
CY
8135 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8136 and LC_VERSION_MIN_MACOSX.
8137 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8138 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8139
97bb72a6
EZ
81402011-08-08 Eli Zaretskii <eliz@gnu.org>
8141
8142 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8143 no-display-properties-and-no-overlays under bidi display.
8144 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8145 properties and overlays.
97bb72a6 8146
d5617611
CY
81472011-08-08 Chong Yidong <cyd@stupidchicken.com>
8148
37e11a63
CY
8149 * editfns.c (Fset_time_zone_rule): Document relationship with the
8150 setenv function.
8151
d5617611
CY
8152 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8153 the font entity extracted from the cache (Bug#8109).
8154
58872834
CY
81552011-08-07 Chong Yidong <cyd@stupidchicken.com>
8156
8157 * composite.c (autocmp_chars): Don't reset point. That is done by
8158 restore_point_unwind (Bug#5984).
8159
75bfc667
JL
81602011-08-07 Juri Linkov <juri@jurta.org>
8161
8162 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8163 to show the arg `TIME' instead of `TIMEVAL'.
8164
d1410150
EZ
81652011-08-06 Eli Zaretskii <eliz@gnu.org>
8166
8167 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8168 display property strides EOL and includes a newline, as in
8169 longlines-mode. (Bug#9254)
75b771e4
EZ
8170 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8171 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8172
8173 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8174 is non-zero, even if the data buffer is NULL. Fixes a crash in
8175 vertical-motion with longlines-mode. (Bug#9254)
8176
35928349
EZ
81772011-08-05 Eli Zaretskii <eliz@gnu.org>
8178
ec7cc85b
EZ
8179 * bidi.c <bidi_cache_total_alloc>: Now static.
8180 (bidi_initialize): Initialize bidi_cache_total_alloc.
8181
8b76d6f8 8182 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8183 cache. (Bug#9221)
8184
8185 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8186 amount allocated this far in `bidi_cache_total_alloc'.
8187 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8188 non-zero, only free the data buffer without restoring the cache
8189 contents. All callers changed.
8190
8191 * dispextern.h (bidi_unshelve_cache): Update prototype.
8192
8193 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8194 (move_it_in_display_line, move_it_to)
8195 (move_it_vertically_backward, move_it_by_lines): Replace the call
8196 to xfree to an equivalent call to bidi_unshelve_cache.
8197 (move_it_in_display_line_to): Fix logic of returning
412b6358 8198 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8199
e2e2423b
EZ
82002011-08-05 Eli Zaretskii <eliz@gnu.org>
8201
8202 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8203 came from a string character with a `cursor' property. (Bug#9229)
8204
ae9e757a
JD
82052011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8206
8207 * Makefile.in (LIB_PTHREAD): New variable.
8208 (LIBES): Add LIB_PTHREAD (Bug#9216).
8209
8210 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8211 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8212
213bd7f2
AS
82132011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8214
6b02f655 8215 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8216
99aaf75f
JD
82172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8218
8219 * xterm.c (x_find_topmost_parent): New function.
8220 (x_set_frame_alpha): Find topmost parent window with
8221 x_find_topmost_parent and set the property there also (bug#9181).
8222 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8223
c74e9d86
PE
82242011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8225
8226 * callproc.c (Fcall_process): Avoid vfork clobbering
8227 the local vars buffer, coding_systems, current_dir.
8228
640c8776
SM
82292011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8230
8231 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8232
f26d0e4c
PE
82332011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8234
8a10d76c
PE
8235 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8236 so that it is not optimized away.
8237
f26d0e4c
PE
8238 * xdisp.c (compute_display_string_pos): Remove unused local.
8239
55439c61
EZ
82402011-08-02 Eli Zaretskii <eliz@gnu.org>
8241
8242 Fix slow cursor motion and scrolling in large buffers with
8243 selective display, like Org Mode buffers. (Bug#9218)
8244
8245 * dispextern.h (struct bidi_it): New member disp_prop_p.
8246
8247 * xdisp.c: Remove one-slot cache of display string positions.
8248 (compute_display_string_pos): Accept an additional argument
5e617bc2 8249 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8250 for a display string or property. If found, set DISP_PROP_P
8251 non-zero.
8252
8253 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8254 DISP_PROP_P, and pass it to compute_display_string_pos.
8255 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8256 non-zero. All callers of bidi_fetch_char changed.
8257
fb33fa43
SM
82582011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8259
8260 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8261
b099e063
DM
82622010-12-03 Don March <don@ohspite.net>
8263
8264 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8265 last character M-[char] is translated to ESC [char] (bug#7541).
8266
5cc7f7af
KH
82672011-08-02 Kenichi Handa <handa@m17n.org>
8268
d0fffa3f 8269 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8270
8271 * chartab.c (uniprop_table): Make it non-static.
8272
525d5e6e
EZ
82732011-08-01 Eli Zaretskii <eliz@gnu.org>
8274
8275 * xdisp.c (forward_to_next_line_start): Accept additional argument
8276 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8277 on the newline.
8278 (reseat_at_next_visible_line_start): Use the bidi iterator state
8279 returned by forward_to_next_line_start to restore the state of
8280 it->bidi_it after backing up to previous newline. (Bug#9212)
8281
31011111
AS
82822011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8283
8284 * regex.c (re_comp): Protoize.
8285 (re_exec): Fix return type.
8286 (regexec): Fix type of `ret'. (Bug#9203)
8287
476371c4
PE
82882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8289
e5d76069
PE
8290 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8291 This is needed if max-image-size is a floating-point number.
8292
9a79b20c
AS
82932011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8294
8295 * print.c (print_object): Print empty symbol as ##.
8296
8297 * lread.c (read1): Read ## as empty symbol.
8298
d8c2fa78
AA
82992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8300
8301 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8302 setting frame foreground color (Bug#9175).
8303 (x_set_background_color): Likewise.
8304
ffe57a7a
AA
8305 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8306 contents (Bug#9176).
8307 (EmacsTooltip -init): Remove bezels and add shadows to
8308 tooltip windows.
8309
bf3492a5
AA
8310 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8311 or scroll bar (Bug#8470).
8312
d55e9c53
AA
8313 * nsfont.m (nsfont_open): Remove assignment to voffset and
8314 unnecessary vars hshink, expand, hd, full_height, min_height.
8315 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8316
8317 * nsterm.h (nsfont_info): Remove voffset field.
8318
d8c2fa78 83192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8320
8321 Implement strike-through and overline on NextStep (Bug#8863).
8322
8323 * nsfont.m (nsfont_open): Use underline position provided by font,
8324 instead of hard-coded value of 2.
8325 (nsfont_draw): Call ns_draw_text_decoration instead.
8326
8327 * nsterm.h: Add declaration for ns_draw_text_decoration.
8328
8329 * nsterm.m (ns_draw_text_decoration): New function for drawing
8330 underline, overline, and strike-through.
8331 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8332 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8333 accommodate underlining, etc.
4843aac3 8334
4cc60b9b
EZ
83352011-07-28 Eli Zaretskii <eliz@gnu.org>
8336
bc7ece87
EZ
8337 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8338 default.
4cc60b9b 8339
476371c4
PE
83402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8341
66606eea
PE
8342 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8343 Without this fix, if a signal arrives just after memory fills up,
8344 'malloc' might be invoked reentrantly.
8345
476371c4
PE
8346 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8347 In other words, assume that every image size is allowed, on non-X
8348 hosts. This assumption is probably wrong, but it lets Emacs compile.
8349
f3fcc40d
AS
83502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8351
8352 * regex.c (re_iswctype): Convert return values to boolean.
8353
350c992f
EZ
83542011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8355
8356 * xdisp.c (compute_display_string_pos): Don't use cached display
8357 string position if the buffer had its restriction changed.
8358 (Bug#9184)
8359
5266b4bb
PE
83602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8361
8362 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8363
2573a837 83642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8365
41f55ccd 8366 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8367
39e378da
PE
8368 * bidi.c: Integer size and overflow fixes.
8369 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8370 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8371 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8372 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8373 (bidi_find_other_level_edge):
8374 Use ptrdiff_t instead of EMACS_INT where either will do.
8375 This works better on 32-bit hosts configured --with-wide-int.
8376 (bidi_cache_ensure_space): Check for size-calculation overflow.
8377 Use % rather than repeated addition, for better worst-case speed.
8378 Don't set bidi_cache_size until after xrealloc returns, because it
8379 might not return.
8380 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8381 (bidi_cache_ensure_space): Also check that the bidi cache size
8382 does not exceed that of the largest Lisp string or buffer. See Eli
8383 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8384
5e927815
PE
8385 * alloc.c (__malloc_size_t): Remove.
8386 All uses replaced by size_t. See Andreas Schwab's note
8387 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8388
ca4aa935
PE
8389 * image.c: Improve checking for integer overflow.
8390 (check_image_size): Assume that f is nonnull, since
8391 it is always nonnull in practice. This is one less thing to
8392 worry about when checking for integer overflow later.
8393 (x_check_image_size): New function, which checks for integer
8394 overflow issues inside X.
8395 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8396 This removes the need for a memory_full check.
8397 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8398 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8399 (xbm_read_bitmap_data): Change locals back to 'int', since
8400 their values must fit in 'int'.
8401 (xpm_load_image, png_load, tiff_load):
8402 Invoke x_create_x_image_and_pixmap earlier,
8403 to avoid much needless work if the image is too large.
8404 (tiff_load): Treat overly large images as if
8405 x_create_x_image_and_pixmap failed, not as malloc failures.
8406 (gs_load): Use x_check_image_size.
8407
5f8f9cc2
PE
8408 * gtkutil.c: Omit integer casts.
8409 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8410 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8411
5adf60bc
PE
8412 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8413
c8907a93
PE
8414 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8415 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8416 would wrongly return t on a 64-bit host.
8417
e3c25c68
PE
8418 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8419 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8420 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8421 and therefore cause GCC to emit a bogus diagnostic in some cases.
8422
3f791afe
PE
8423 * image.c: Integer signedness and overflow and related fixes.
8424 This is not an exhaustive set of fixes, but it's time to
8425 record what I've got.
8426 (lookup_pixel_color, check_image_size): Remove redundant decls.
8427 (check_image_size): Don't assume that arbitrary EMACS_INT values
8428 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8429 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8430 (tiff_load, imagemagick_load_image):
8431 Check for overflow in size calculations.
8432 (x_create_x_image_and_pixmap): Remove unnecessary test for
8433 xmalloc returning NULL; that can't happen.
8434 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8435 (xpm_color_bucket): Use better integer hashing function.
8436 (xpm_cache_color): Don't possibly over-allocate memory.
8437 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8438 (gif_memory_source):
8439 Use ptrdiff_t, not int or size_t, to record sizes.
8440 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8441 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8442 either works, as we prefer signed integers.
8443 (tiff_read_from_memory, tiff_write_from_memory):
8444 Return tsize_t, not size_t, since that's what the TIFF API wants.
8445 (tiff_read_from_memory): Don't fail simply because the read would
8446 go past EOF; instead, return a short read.
8447 (tiff_load): Omit no-longer-needed casts.
8448 (Fimagemagick_types): Don't assume size fits into 'int'.
8449
3cc5a532
PE
8450 Improve hashing quality when configured --with-wide-int.
8451 * fns.c (hash_string): New function, taken from sxhash_string.
8452 Do not discard information about ASCII character case; this
8453 discarding is no longer needed.
8454 (sxhash-string): Use it. Change sig to match it. Caller changed.
8455 * lisp.h: Declare it.
8456 * lread.c (hash_string): Remove, since we now use fns.c's version.
8457 The fns.c version returns a wider integer if --with-wide-int is
8458 specified, so this should help the quality of the hashing a bit.
8459
b312a492
PE
8460 * emacs.c: Integer overflow minor fix.
8461 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8462 Define only if GNU_LINUX.
8463 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8464
dfd153ae
PE
8465 * dispnew.c: Integer signedness and overflow fixes.
8466 Remove unnecessary forward decls, that were a maintenance hassle.
8467 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8468 All uses changed.
8469 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8470 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8471 (prepare_desired_row, line_draw_cost):
8472 Use int, not unsigned, where either works.
8473 (save_current_matrix, restore_current_matrix):
8474 Use ptrdiff_t, not size_t, where either works.
8475 (init_display): Check for overflow more accurately, and without
8476 relying on undefined behavior.
8477
a81d11a3
PE
8478 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8479 Remove, replacing with the new symbols in lisp.h. All uses changed.
8480 * fileio.c (make_temp_name):
8481 * filelock.c (lock_file_1, lock_file):
8482 * xdisp.c (message_dolog):
8483 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8484 Use pMd etc. instead.
8485 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8486 replacing the pWIDE etc. symbols removed from editfns.c.
8487
3300e6fd
PE
8488 * keyboard.h (num_input_events): Now uintmax_t.
8489 This is (very slightly) less likely to mess up due to wraparound.
8490 All uses changed.
8491
fd05c7e9
PE
8492 * buffer.c: Integer signedness fixes.
8493 (alloc_buffer_text, enlarge_buffer_text):
8494 Use ptrdiff_t rather than size_t when either will do, as we prefer
8495 signed integers.
8496
903fe15d
PE
8497 * alloc.c: Integer signedness and overflow fixes.
8498 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8499 (__malloc_size_t): Default to size_t, not to int.
8500 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8501 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8502 Prefer ptrdiff_t to size_t when either would do, as we prefer
8503 signed integers.
8504 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8505 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8506 Now const. Initialize with values that are in range even if char
8507 is signed.
8508 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8509 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8510 These functions do the right thing with sizes > 2**32.
8511 (check_depth): Now ptrdiff_t, not int.
8512 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8513 Adjust to new way of storing sizes. Check for size overflow bugs
8514 in rest of code.
8515 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8516 slightly wrong anyway, as it missed one instance of
8517 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8518 (refill_memory_reserve): Omit needless cast to size_t.
8519 (mark_object_loop_halt): Mark as externally visible.
8520
ac82cc6a
PE
8521 * xselect.c: Integer signedness and overflow fixes.
8522 (Fx_register_dnd_atom, x_handle_dnd_message):
8523 Use ptrdiff_t, not size_t, since we prefer signed.
8524 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8525 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8526 x_dnd_atoms_size and x_dnd_atoms_length.
8527
c2d1e36d
PE
8528 * doprnt.c: Prefer signed to unsigned when either works.
8529 * eval.c (verror):
8530 * doprnt.c (doprnt):
8531 * lisp.h (doprnt):
8532 * xdisp.c (vmessage):
8533 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8534 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8535 prefer signed arithmetic to avoid comparison confusion.
8536 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8537 but is a bit tricky.
8538
0e926e56
PE
8539 Assume freestanding C89 headers, string.h, stdlib.h.
8540 * data.c, doprnt.c, floatfns.c, print.c:
8541 Include float.h unconditionally.
8542 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8543 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8544 * regex.c: Likewise for stddef.h, string.h.
8545 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8546 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8547 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8548 (STDC_HEADERS): Remove obsolete defines.
8549 * sysdep.c: Include limits.h unconditionally.
8550
9cfdb3ec
PE
8551 Assume support for memcmp, memcpy, memmove, memset.
8552 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8553 * regex.c (memcmp, memcpy):
8554 Remove; we assume C89 now.
8555
8556 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8557 (__malloc_safe_bcopy): Remove; no longer needed.
8558
cf950e6b 8559 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8560 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8561 well either way, and we prefer signed to unsigned.
8562
dbf38e02
LMI
85632011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8564
8565 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8566 closes the connection while we're reading (bug#9182).
8567
d6f0886c 85682011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8569
d6f0886c
JD
8570 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8571 are specified (Bug#9168).
24e0f6b1 8572
2eb1f9e6
PE
85732011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8574
8575 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8576 Found by GCC static checking and --with-wide-int on a 32-bit host.
8577
22381272 85782011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8579
8580 * xdisp.c (compute_display_string_pos): Fix logic of caching
8581 previous display string position. Initialize cached_prev_pos to
8582 -1. Fixes slow-down at the beginning of a buffer.
8583
f25e39b4
EZ
85842011-07-24 Eli Zaretskii <eliz@gnu.org>
8585
8586 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8587 for attrs[LFACE_FONTSET_INDEX].
8588
04c4b52e
PE
85892011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8590
8591 * xml.c (parse_region): Remove unused local
8592 that was recently introduced.
8593
c1734fbd
EZ
85942011-07-23 Eli Zaretskii <eliz@gnu.org>
8595
be18c5a5
EZ
8596 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8597 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8598
c1734fbd
EZ
8599 * xdisp.c (move_it_in_display_line_to): Record the best matching
8600 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8601 exit if none of the characters scanned was an exact match.
8602 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8603 when exact match is impossible due to invisible text, and the
8604 lines are truncated.
8605
a258d627
JD
86062011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8607
8608 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8609 for OSX >= 10.7.
8610
b6d5a689
EZ
86112011-07-22 Eli Zaretskii <eliz@gnu.org>
8612
0f74f785
EZ
8613 Fix a significant slow-down of cursor motion with C-n, C-p,
8614 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8615 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8616 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8617 (next_element_from_buffer): Call compute_stop_pos_backwards to
8618 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8619 base_level_stop.
8620 (reseat): Don't look for prev_stop, as that could mean a very long
8621 run.
8622 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8623 <cached_disp_overlay_modiff>: Cache for last found display string
8624 position.
551918c1 8625 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8626 about the same buffer in the same area of character positions, and
8627 the buffer wasn't changed since the time the display string
8628 position was cached.
551918c1 8629
b2d0c91a
EZ
86302011-07-22 Eli Zaretskii <eliz@gnu.org>
8631
8632 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8633 is an integer, which is important for empty lines. (Bug#9149)
8634
043604ee
CY
86352011-07-22 Chong Yidong <cyd@stupidchicken.com>
8636
8637 * frame.c (Fmodify_frame_parameters): In tty case, update the
8638 default face if necessary (Bug#4238).
8639
da4adb04
CY
86402011-07-21 Chong Yidong <cyd@stupidchicken.com>
8641
8642 * editfns.c (Fstring_to_char): No need to explain what a character
8643 is in the docstring (Bug#6576).
8644
9abd0532
LMI
86452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8646
8647 * xml.c (parse_region): Make sure we always return a tree.
8648
36881d16
HK
86492011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8650
8651 * xml.c (parse_region): If a document contains only comments,
8652 return that, too.
8653
1e98674d
LMI
86542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8655
8656 * xml.c (make_dom): Return comments, too.
8657
590bd467
PE
86582011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8659
8660 Port to OpenBSD.
8661 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8662 and the surrounding thread.
8663 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8664 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8665 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8666 timer goes off.
8667 * s/openbsd.h (BROKEN_SIGIO): Define.
8668 * unexelf.c (unexec) [__OpenBSD__]:
8669 Don't update the .mdebug section of the Alpha COFF symbol table.
8670
f41628b2
LMI
86712011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8672
8673 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8674 (bug#8460).
8675
b59b67c5
PE
86762011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8677
15e3a074
PE
8678 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8679 This fixes some race conditions on the permissions of any newly
8680 created file.
8681
41bed37d
PE
8682 * alloc.c (valid_pointer_p): Use pipe, not open.
8683 This fixes some permissions issues when debugging.
8684
b59b67c5
PE
8685 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8686 If fchown fails to set both uid and gid, try to set just gid,
8687 as that is sometimes allowed. Adjust the file's mode to eliminate
8688 setuid or setgid bits that are inappropriate if fchown fails.
8689
925a6be7
SM
86902011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8691
8692 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8693 to compare Lisp_Objects.
8694 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8695 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8696 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8697
52968808
AS
86982011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8699
0a6a104b
AS
8700 * lread.c (read_integer): Unread even EOF character.
8701 (read1): Likewise. Properly record start position of symbol.
8702
52968808
AS
8703 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8704 symbol character follows.
8705
9e381cdd
PE
87062011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8707
8708 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8709 This works around a problem with the previous change to Fcopy_file.
8710 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8711 and without this change, GCC might complain about discarding
8712 fchown's return value.
8713
b5641435
JB
87142011-07-16 Juanma Barranquero <lekktu@gmail.com>
8715
8716 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8717
a8031457
PE
87182011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8719
8720 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8721
dd889327
LMI
87222011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8723
750c33f7
LMI
8724 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8725 it's used from the C level.
8726
dd889327
LMI
8727 * process.c: Use the same condition for POLL_FOR_INPUT in both
8728 keyboard.c and process.c (bug#1858).
8729
87e86684
LM
87302011-07-09 Lawrence Mitchell <wence@gmx.li>
8731
8732 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8733 (Fgnutls_boot): Use it.
8734
64348f40
AS
87352011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8736
8737 * doc.c (Fsubstitute_command_keys): Revert last change.
8738
1d698799
LMI
87392011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8740
f863868c
LMI
8741 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8742 quotes the next character, and doesn't affect other longer
8743 sequences (bug#8935).
8744
1d698799
LMI
8745 * lread.c (syms_of_lread): Clarify that is isn't only
8746 `eval-buffer' and `eval-defun' that's affected by
8747 `lexical-binding' (bug#8460).
8748
aa4b6df6
EZ
87492011-07-15 Eli Zaretskii <eliz@gnu.org>
8750
8751 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8752 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8753
5d856da6
PE
87542011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8755
ad6042bb
PE
8756 Fix minor problems found by static checking.
8757 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8758 (elsz): Now a signed constant, not a size_t var. We prefer signed
8759 types to unsigned, to avoid integer comparison confusion. Without
8760 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8761 "cannot optimize loop, the loop counter may overflow", a symptom
8762 of the confusion.
f00bbb22 8763 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8764 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8765
6468f31c
LMI
87662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8767
49080b10
LMI
8768 * search.c (Fre_search_backward): Mention `case-fold-search' in
8769 all the re_search_* functions (bug#8138).
8770
6468f31c
LMI
8771 * keyboard.c (Fopen_dribble_file): Document when the file is
8772 closed (bug#8056).
8773
c965adc5
EZ
87742011-07-14 Eli Zaretskii <eliz@gnu.org>
8775
df9733bf
EZ
8776 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8777 bidi_cache_idx.
8778
0bb23927
EZ
8779 Support bidi reordering of display and overlay strings.
8780 * xdisp.c (compute_display_string_pos)
8781 (compute_display_string_end): Accept additional argument STRING.
8782 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8783 (reseat_to_string): Initialize bidi_it->string.s and
8784 bidi_it->string.schars.
8785 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8786 NULL (avoids a crash in bidi_paragraph_init).
8787 Initialize itb.string.lstring.
0bb23927
EZ
8788 (init_iterator): Call bidi_init_it only of a valid
8789 buffer position was specified. Initialize paragraph_embedding to
8790 L2R.
8791 (reseat_to_string): Initialize the bidi iterator.
8792 (display_string): If we need to ignore text properties of
8793 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8794 original value of -1 will not work with bidi.)
8795 (compute_display_string_pos): First arg is now struct
8796 `text_pos *'; all callers changed. Support display properties on
8797 Lisp strings.
8798 (compute_display_string_end): Support display properties on Lisp
8799 strings.
8800 (init_iterator, reseat_1, reseat_to_string): Initialize the
8801 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8802 when iterating on a string not from display properties).
640c8776
SM
8803 (compute_display_string_pos, compute_display_string_end):
8804 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8805 arrow keys.
8806 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8807 base_level_stop; instead, set base_level_stop to BEGV.
8808 Fixes crashes in vertical-motion.
0bb23927
EZ
8809 (next_element_from_buffer): Improve commentary for when
8810 the iterator is before prev_stop.
8811 (init_iterator): Initialize bidi_p from the default value of
8812 bidi-display-reordering, not from buffer-local value. Use the
8813 buffer-local value only if initializing for buffer iteration.
8814 (handle_invisible_prop): Support invisible properties on strings
8815 that are being bidi-reordered.
8816 (set_iterator_to_next): Support bidi reordering of C strings and
8817 Lisp strings.
8818 (next_element_from_string): Support bidi reordering of Lisp
8819 strings.
8820 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8821 (display_string): Support display of R2L glyph rows.
8822 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8823 (init_iterator): Don't initialize it->bidi_p for strings
8824 here.
8825 (reseat_to_string): Initialize it->bidi_p for strings here.
8826 (next_element_from_string, next_element_from_c_string)
8827 (next_element_from_buffer): Add xassert's for correspondence
8828 between IT's object being iterated and it->bidi_it.string
8829 structure.
8830 (face_before_or_after_it_pos): Support bidi iteration.
8831 (next_element_from_c_string): Handle the case of the first string
8832 character that is not the first one in the visual order.
8833 (get_visually_first_element): New function, refactored from common
8834 parts of next_element_from_buffer, next_element_from_string, and
8835 next_element_from_c_string.
8836 (tool_bar_lines_needed, redisplay_tool_bar)
8837 (display_menu_bar): Force left-to-right direction. Add a FIXME
8838 comment for making that be controlled by a user option.
8839 (push_it, pop_it): Save and restore the state of the
8840 bidi iterator. Save and restore the bidi_p flag.
8841 (pop_it): Iterate out of display property for string iteration as
8842 well.
8843 (iterate_out_of_display_property): Support iteration over strings.
8844 (handle_single_display_spec): Set up it->bidi_it for iteration
8845 over a display string, and call bidi_init_it.
8846 (handle_single_display_spec, next_overlay_string)
8847 (get_overlay_strings_1, push_display_prop): Set up the bidi
8848 iterator for displaying display or overlay strings.
8849 (forward_to_next_line_start): Don't use the shortcut if
8850 bidi-iterating.
8851 (back_to_previous_visible_line_start): If handle_display_prop
8852 pushed the iterator stack, restore the internal state of the bidi
8853 iterator by calling bidi_pop_it same number of times.
8854 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8855 and we are bidi-iterating, don't decrement the iterator position;
8856 instead, set the first_elt flag in the bidi iterator, to produce
8857 the same effect.
8858 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8859 (push_display_prop): xassert that we are iterating a buffer.
8860 (push_it, pop_it): Save and restore paragraph_embedding member.
8861 (handle_single_display_spec, next_overlay_string)
8862 (get_overlay_strings_1, reseat_1, reseat_to_string)
8863 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8864 correctly. Don't assume unibyte strings are not bidi-reordered.
8865 (compute_display_string_pos)
8866 (compute_display_string_end): Fix handling the case of C string.
8867 (push_it, pop_it): Save and restore from_disp_prop_p.
8868 (handle_single_display_spec, push_display_prop): Set the
8869 from_disp_prop_p flag.
8870 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8871 (pop_it): Call iterate_out_of_display_property only if we are
8872 popping after iteration over a string that came from a display
8873 property. Fix a typo in popping stretch info. Add an assertion
8874 for verifying that the iterator position is in sync with the bidi
8875 iterator.
8876 (handle_single_display_spec, get_overlay_strings_1)
8877 (push_display_prop): Fix initialization of paragraph direction for
8878 string when that of the parent object is not yet determined.
8879 (reseat_1): Call bidi_init_it to resync the bidi
8880 iterator with IT's position. (Bug#7616)
8881 (find_row_edges): If ROW->start.pos gives position
8882 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8883 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8884 Reset the from_disp_prop_p flag.
8885 (SAVE_IT, RESTORE_IT): New macros.
8886 (pos_visible_p, face_before_or_after_it_pos)
8887 (back_to_previous_visible_line_start)
8888 (move_it_in_display_line_to, move_it_in_display_line)
8889 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8890 (try_scrolling, redisplay_window, display_line): Use them when
8891 saving a temporary copy of the iterator and restoring it back.
8892 (back_to_previous_visible_line_start, reseat_1)
8893 (init_iterator): Empty the bidi cache "stack".
8894 (move_it_in_display_line_to): If iterator ended up at
8895 EOL, but we never saw any buffer positions smaller than
8896 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8897 motion in bidi-reordered lines.
8898 (move_it_in_display_line_to): Record prev_method and prev_pos
8899 immediately before the call to set_iterator_to_next. Fixes cursor
8900 motion in bidi-reordered lines with stretch glyphs and strings
8901 displayed in margins. (Bug#8133) (Bug#8867)
8902 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8903 TO_CHARPOS.
640c8776
SM
8904 (pos_visible_p): Support positions in bidi-reordered lines.
8905 Save and restore bidi cache.
0bb23927
EZ
8906
8907 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8908 (bidi_paragraph_info): Delete unused struct.
8909 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8910 (bidi_cache_start): New variable.
8911 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8912 to zero.
8913 (bidi_cache_fetch_state, bidi_cache_search)
8914 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8915 (bidi_cache_find, bidi_peek_at_next_level)
8916 (bidi_level_of_next_char, bidi_find_other_level_edge)
8917 (bidi_move_to_visually_next): Compare cache index with
8918 bidi_cache_start rather than with zero.
8919 (bidi_fetch_char): Accept new argument STRING; all callers
8920 changed. Support iteration over a string. Support strings with
8921 display properties. Support unibyte strings. Fix the type of
8922 `len' according to what STRING_CHAR_AND_LENGTH expects.
8923 (bidi_paragraph_init, bidi_resolve_explicit_1)
8924 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8925 (bidi_level_of_next_char, bidi_move_to_visually_next):
8926 Support iteration over a string.
0bb23927
EZ
8927 (bidi_set_sor_type, bidi_resolve_explicit_1)
8928 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8929 can now be zero (for strings); special values 0 and -1 were
8930 changed to -1 and -2, respectively.
8931 (bidi_char_at_pos): New function.
8932 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8933 Call it instead of FETCH_MULTIBYTE_CHAR.
8934 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8935 initialized to valid values.
8936 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8937 values.
8938 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8939 the test for valid cached positions. Fix the logic for looking up
8940 the sentinel state in the cache. GCPRO the Lisp string we are
8941 iterating.
8942 (bidi_push_it, bidi_pop_it): New functions.
8943 (bidi_initialize): Initialize the bidi cache start stack pointer.
8944 (bidi_cache_ensure_space): New function, refactored from part of
8945 bidi_cache_iterator_state. Don't assume the required size is just
8946 one BIDI_CACHE_CHUNK away.
8947 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8948 (bidi_count_bytes, bidi_char_at_pos): New functions.
8949 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8950 always valid if bidi_cache_idx is valid.
8951 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8952 is valid if it's going to be used.
8953 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8954 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8955 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8956 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8957 (bidi_find_other_level_edge, bidi_cache_start_stack):
8958 All variables related to cache indices are now EMACS_INT.
c965adc5 8959
0bb23927
EZ
8960 * dispextern.h (struct bidi_string_data): New structure.
8961 (struct bidi_it): New member `string'. Make flag members be 1-bit
8962 fields, and put them last in the struct.
640c8776
SM
8963 (compute_display_string_pos, compute_display_string_end):
8964 Update prototypes.
0bb23927
EZ
8965 (bidi_push_it, bidi_pop_it): Add prototypes.
8966 (struct iterator_stack_entry): New members bidi_p,
8967 paragraph_embedding, and from_disp_prop_p.
8968 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8969 (bidi_shelve_cache, bidi_unshelve_cache):
8970 Declare prototypes.
0bb23927
EZ
8971
8972 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8973 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8974 and vector-like objects.
8975
8976 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8977 cache around display iteration.
8978
8979 * window.c (Fwindow_end, window_scroll_pixel_based)
8980 (displayed_window_lines, Frecenter): Save and restore the bidi
8981 cache around display iteration.
8982
3bbd2265
LMI
89832011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8984
8985 * editfns.c (Fdelete_region): Clarify the use of the named
8986 parameters (bug#6788).
8987
adc47434
MR
89882011-07-14 Martin Rudalics <rudalics@gmx.at>
8989
8990 * indent.c (Fvertical_motion): Set and restore w->pointm when
8991 saving and restoring the window's buffer (Bug#9006).
8992
837c31f8
LMI
89932011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8994
8995 * editfns.c (Fstring_to_char): Clarify just what is returned
8996 (bug#6576). Text by Eli Zaretskii.
8997
ac389d0c
JB
89982011-07-13 Juanma Barranquero <lekktu@gmail.com>
8999
9000 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9001
0be0ce47
EZ
90022011-07-13 Eli Zaretskii <eliz@gnu.org>
9003
9004 * buffer.c (mmap_find): Fix a typo.
9005
cd18e7e3
JB
90062011-07-13 Johan Bockgård <bojohan@gnu.org>
9007
9008 Fix execution of x selection hooks.
9009 * xselect.c (Qx_lost_selection_functions)
9010 (Qx_sent_selection_functions): New vars.
9011 (syms_of_xselect): DEFSYM them.
9012 (x_handle_selection_request): Pass Qx_sent_selection_functions
9013 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9014 (x_handle_selection_clear,x_clear_frame_selections):
9015 Pass Qx_lost_selection_functions rather than
9016 Vx_lost_selection_functions to Frun_hook_with_args.
9017
47ea7f44
PE
90182011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9019
ac389d0c 9020 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9021 The old code sometimes used this field without initializing it.
9022
47ea7f44
PE
9023 * alloc.c (gc_sweep): Don't read past end of array.
9024 In theory, the old code could also have corrupted Emacs internals,
9025 though it'd be very unlikely.
9026
bc985c87
AS
90272011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9028
9029 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9030 argument. (Bug#4026)
bc985c87 9031
0cf34688
LMI
90322011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9033
b3dadd76
LMI
9034 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9035 key" (bug#4257).
9036
0cf34688
LMI
9037 * window.c (Fset_window_start): Doc fix (bug#4199).
9038 (Fset_window_hscroll): Ditto.
9039
270768cd
PE
90402011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9041
077e3dda 9042 Fix minor new problems caught by GCC 4.6.1.
270768cd 9043 * term.c (init_tty): Remove unused local.
490011a6 9044 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9045 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9046 not used otherwise.
270768cd 9047
b1f58454
CY
90482011-07-12 Chong Yidong <cyd@stupidchicken.com>
9049
9050 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9051
22b9578d
LMI
90522011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9053
6e70ab07
LMI
9054 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9055 are the mini-buffer and the echo area (bug#3320).
9056
22b9578d
LMI
9057 * term.c (init_tty): Remove support for supdup, c10 and perq
9058 terminals, which are no longer supported (bug#1482).
9059
8974cc9f
JB
90602011-07-10 Johan Bockgård <bojohan@gnu.org>
9061
9062 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9063
a560d974
JD
90642011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9065
9066 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9067 for non-popups (Bug#3642).
9068
1dae0f0a
AS
90692011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9070
268c2c36 9071 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9072 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9073 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9074 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9075 * data.c (fmod): Likewise.
9076 * dispnew.c (swap_glyphs_in_rows): Likewise.
9077 * emacs.c (memory_warning_signal): Likewise.
9078 * floatfns.c (float_error): Likewise.
9079 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9080 (otf_open, font_otf_capability, generate_otf_features)
9081 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9082 Likewise.
9083 * image.c (pbm_read_file): Likewise.
9084 * indent.c (string_display_width): Likewise.
9085 * intervals.c (check_for_interval, search_for_interval)
9086 (inc_interval_count, count_intervals, root_interval)
9087 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9088 * lread.c (defalias): Likewise.
268c2c36 9089 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9090 * regex.c (set_image_of_range_1, set_image_of_range)
9091 (regex_grow_registers): Likewise.
9092 * sysdep.c (strerror): Likewise.
9093 * termcap.c (valid_filename_p, tprint, main): Likewise.
9094 * tparam.c (main): Likewise.
9095 * unexhp9k800.c (run_time_remap, save_data_space)
9096 (update_file_ptrs, read_header, write_header, calculate_checksum)
9097 (copy_file, copy_rest, display_header): Likewise.
9098 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9099 Likewise.
9100 * xdisp.c (check_it): Likewise.
9101 * xfaces.c (register_color, unregister_color, unregister_colors):
9102 Likewise.
9103 * xfns.c (print_fontset_result): Likewise.
9104 * xrdb.c (member, fatal, main): Likewise.
9105
99033785
PE
91062011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9107
9108 Fix minor problems found by static checking (Bug#9031).
9109 * chartab.c (char_table_set_range, map_sub_char_table):
9110 Remove unused locals.
9111 (uniprop_table): Now static.
9112 * composite.c (_work_char): Remove unused static var.
9113
9cb2ac56
JB
91142011-07-09 Juanma Barranquero <lekktu@gmail.com>
9115
9116 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9117
f25661f0
JD
91182011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9119
9120 * gtkutil.c (qttip_cb): Remove code without function.
9121
8278c4fe
EZ
91222011-07-09 Eli Zaretskii <eliz@gnu.org>
9123
9124 * w32.c (pthread_sigmask): New stub.
9125
1692ae2d 91262011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9127
8a6ebd58 9128 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9129 sigprocmask is portable only for single-threaded applications, and
9130 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9131 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9132 (LIBES): Use it.
9133 * callproc.c (Fcall_process):
9134 * process.c (create_process):
9135 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9136 Use pthread_sigmask, not sigprocmask.
123403e4 9137
1b854618
JD
91382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9139
9140 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9141 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9142 wrong (Bug#8591).
9143
3fe4b549
JD
91442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9145
0ce7e563
JD
9146 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9147 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9148 (xg_hide_tooltip): Fix comment.
9149
3fe4b549
JD
9150 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9151 in registerServicesMenuSendTypes.
9152 (validRequestorForSendType): Don't check ns_return_types.
9153
9154 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9155 ns_return_type.
9156
5df75e47
JR
91572011-07-08 Jason Rumney <jasonr@gnu.org>
9158
22610910
JR
9159 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9160 SH_SHOW for hidden windows (Bug#5482).
9161
5df75e47
JR
9162 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9163 frame struct members of non-existent frames (Bug#6284).
9164
699c10bd
JD
91652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9166
4393663b
JD
9167 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9168 variable firstTime not needed on OSX >= 10.6.
9169 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9170 >= 10.5. Use setKnobProportion, setDoubleValue.
9171
9172 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9173 (MAC_OS_X_VERSION_10_5): Define if not defined.
9174 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9175 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9176 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9177
9178 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9179 cString and lossyCString on OSX >= 10.4.
4393663b 9180
58179cce 9181 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9182 sizeToFit on OSX >= 10.2.
9183
9184 * nsimage.m (allocInitFromFile): Don't use deprecated method
9185 bestRepresentationForDevice on OSX >= 10.6.
9186
9187 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9188 to avoid warning.
9189
9190 * emacs.c: Declare unexec_init_emacs_zone.
9191
a63e0781
JD
9192 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9193
699c10bd
JD
9194 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9195
9196 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9197 on svcsMenu (Bug#8842).
9198
9199 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9200 ns_return_types.
9201 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9202
9203 * nsterm.m (QUTF8_STRING): Declare.
9204 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9205 (validRequestorForSendType): Return type is (id).
9206 Change indexOfObjectIdenticalTo to indexOfObject.
9207 Check if we have local selection before returning self (Bug#8842).
9208 (writeSelectionToPasteboard): Put local selection into paste board
9209 if we have a local selection (Bug#8842).
9210 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9211
9212 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9213 (ns_get_local_selection): Declare.
9214
54e10184
LMI
92152011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9216
9888ff71
LMI
9217 * keymap.c (describe_map_tree): Don't insert a double newline at
9218 the end of the buffer (bug#1169) and return whether we inserted
9219 something.
9220
54e10184
LMI
9221 * callint.c (Fcall_interactively): Change "reading args" to
9222 "providing args" to try to clarify what it does (bug#1010).
9223
15fa4783
KH
92242011-07-07 Kenichi Handa <handa@m17n.org>
9225
9226 * composite.c (composition_compute_stop_pos): Ignore a static
9227 composition starting before CHARPOS (Bug#8915).
9228
9229 * xdisp.c (handle_composition_prop): Likewise.
9230
a8815b00
EZ
92312011-07-07 Eli Zaretskii <eliz@gnu.org>
9232
9233 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9234 (Bug#9015)
9235
ef7b981d 92362011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9237
9238 * character.h (unicode_category_t): New enum type.
9239
9240 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9241 (Qchar_code_property_table): New variable.
9242 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9243 (UNIPROP_COMPRESSED_FORM_P): New macros.
9244 (char_table_ascii): Uncompress the compressed values.
9245 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9246 Uncompress the compressed values.
ac389d0c 9247 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9248 (char_table_ref_and_range): Uncompress the compressed values.
9249 (sub_char_table_set): New arg is_uniprop. Callers changed.
9250 Uncompress the compressed values.
9251 (sub_char_table_set_range): Args changed. Callers changed.
9252 (char_table_set_range): Adjuted for the above change.
9253 (map_sub_char_table): Delete args default_val and parent. Add arg
9254 top. Give decoded values to a Lisp function.
640c8776 9255 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9256 values to a Lisp function. Gcpro more variables.
9257 (uniprop_table_uncompress)
9258 (uniprop_decode_value_run_length): New functions.
9259 (uniprop_decoder, uniprop_decoder_count): New variables.
9260 (uniprop_get_decoder, uniprop_encode_value_character)
9261 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9262 New functions.
9263 (uniprop_encoder, uniprop_encoder_count): New variables.
9264 (uniprop_get_encoder, uniprop_table)
9265 (Funicode_property_table_internal, Fget_unicode_property_internal)
9266 (Fput_unicode_property_internal): New functions.
9267 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9268 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9269 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9270 char-code-property-alist.
9271
640c8776 9272 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9273 Vunicode_category_table.
9274
640c8776 9275 * font.c (font_range): Adjust for the change of
c805dec0
KH
9276 Vunicode_category_table.
9277
76b397fb
DN
92782011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9279
9280 * m/iris4d.h: Remove file, move contents ...
9281 * s/irix6-5.h: ... here.
9282
22b4128e
PE
92832011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9284
9285 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9286 * alloc.c (mark_buffer):
9287 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9288 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9289 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9290 This isn't true in general, and it's particularly not true
9291 if Emacs is configured with --with-wide-int.
9292 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9293 New macros, used in the buffer.c change.
9294
869795d6
JD
92952011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9296
9297 * xsettings.c: Use both GConf and GSettings if both are available.
9298 (store_config_changed_event): Add comment.
9299 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9300 (store_tool_bar_style_changed): New functions.
5e617bc2 9301 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9302 (struct xsettings): Move font inside HAVE_XFT.
9303 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9304 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9305 Move inside HAVE_XFT.
640c8776 9306 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9307 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9308 also.
9309 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9310 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9311 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9312 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9313 (parse_settings): Move check for font inside HAVE_XFT.
9314 (read_settings, apply_xft_settings): Add comment.
9315 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9316 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9317 call store_font_name_changed.
9318 (xft_settings_event): Add comment.
9319 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9320 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9321 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9322 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9323 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9324 (xsettings_get_system_font, xsettings_get_system_normal_font):
9325 Add comment.
869795d6 9326
d8ed26bd
PE
93272011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9328
9329 Random fixes. E.g., (random) never returned negative values.
9330 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9331 subseconds part to the entropy, as that's a bit more random.
9332 Prefer signed to unsigned, since the signedness doesn't matter and
9333 in general we prefer signed. When given a limit, use a
9334 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9335 latter isn't right if USE_2_TAGS_FOR_INTS.
9336 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9337 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9338
cabf1cac
SM
93392011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9340
9341 * textprop.c (text_property_stickiness):
9342 Obey Vtext_property_default_nonsticky.
9343 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9344 * w32fns.c (syms_of_w32fns):
9345 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9346
6e9b2be9
PE
93472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9348
9349 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9350 This is more efficient than Ffile_directory_p and avoids a minor race.
9351
90186c68
LMI
93522011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9353
7c301272
LMI
9354 * buffer.c (Foverlay_put): Say what the return value is
9355 (bug#7835).
9356
c4f2d8d4
LMI
9357 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9358 is a directory before asking whether to use the file name
9359 (bug#7564).
ad637907
LMI
9360 (barf_or_query_if_file_exists): Make the "File is a directory"
9361 error be more correct.
c4f2d8d4 9362
90186c68
LMI
9363 * fns.c (Frequire): Remove the mention of the .gz files, since
9364 that's installation-specific, but keep the mention of
9365 `get-load-suffixes'.
9366
da64016e
PE
93672011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9368
9369 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9370 Report string overflow if the output is too long.
9371
7d47b580
JB
93722011-07-04 Juanma Barranquero <lekktu@gmail.com>
9373
a555cb87
JB
9374 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9375 (syms_of_gnutls): Remove duplicate DEFSYM for
9376 Qgnutls_bootprop_verify_hostname_error, an error for
9377 Qgnutls_bootprop_verify_error (which is no longer used).
9378
7d47b580
JB
9379 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9380 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9381 Also (re)move comments that are misplaced or no longer relevant.
9382
1e49bfab
LMI
93832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9384
9385 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9386
1485f4c0
CY
93872011-07-03 Chong Yidong <cyd@stupidchicken.com>
9388
9389 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9390 and background color parameters if they have been changed.
9391
a9ab721e
LMI
93922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9393
9394 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9395
cf7cff57
PE
93962011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9397
2e13213d
PE
9398 * xsettings.c (SYSTEM_FONT): Define only when used.
9399 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9400
cf7cff57
PE
9401 * keymap.c (access_keymap_1): Now static.
9402
7a8e04f7
CY
94032011-07-02 Chong Yidong <cyd@stupidchicken.com>
9404
9405 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9406 leave any prefix arg for the up event (Bug#1586).
9407
61352f62
LMI
94082011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9409
69bb1ef7
LMI
9410 * lread.c (syms_of_lread): Mention single symbols defined by
9411 `defvar' or `defconst' (bug#7154).
9412
61352f62 9413 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9414 (Frequire): Mention get-load-suffixes.
61352f62 9415
28545e04
MR
94162011-07-02 Martin Rudalics <rudalics@gmx.at>
9417
9418 * window.h (window): Remove clone_number slot.
9419 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9420 Remove.
9421 (make_parent_window, make_window, saved_window)
9422 (Fset_window_configuration, save_window_save): Don't deal with
9423 clone numbers.
9424 * buffer.c (Qclone_number): Remove declaration.
9425 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9426
3349e122
SM
94272011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9428
9429 Add multiple inheritance to keymaps.
9430 * keymap.c (Fmake_composed_keymap): New function.
9431 (Fset_keymap_parent): Simplify.
9432 (fix_submap_inheritance): Remove.
9433 (access_keymap_1): New function extracted from access_keymap to handle
9434 embedded parents and handle lists of maps.
9435 (access_keymap): Use it.
9436 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9437 (Fcopy_keymap): Handle embedded parents.
9438 (Fcommand_remapping, define_as_prefix): Simplify.
9439 (Fkey_binding): Simplify.
9440 (syms_of_keymap): Move minibuffer-local-completion-map,
9441 minibuffer-local-filename-completion-map,
9442 minibuffer-local-must-match-map, and
9443 minibuffer-local-filename-must-match-map to Elisp.
9444 (syms_of_keymap): Defsubr make-composed-keymap.
9445 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9446 (parse_menu_item): Trivial simplification.
9447
3279eb87
GM
94482011-07-01 Glenn Morris <rgm@gnu.org>
9449
9450 * Makefile.in (SETTINGS_LIBS): Fix typo.
9451
4550efdf
KI
94522011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9453
9454 * coding.c (Fencode_coding_string): Record the last coding system
9455 used, as the function doc string says (bug#8738).
9456
0949d2b6
JD
94572011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9458
9459 * xsettings.c (store_monospaced_changed): Take new font as arg and
9460 check for change against current_mono_font.
9461 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9462 (emacs_settings_constructor, emacs_settings_get_property)
9463 (emacs_settings_set_property, emacs_settings_class_init)
9464 (emacs_settings_init, gsettings_obj): Remove.
9465 (something_changedCB): New function for HAVE_GSETTINGS.
9466 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9467 with value as argument.
9468 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9469 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9470 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9471 "changed".
9472
9473 * xgselect.c: Add defined (HAVE_GSETTINGS).
9474 (xgselect_initialize): Ditto.
9475
9476 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9477 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9478 xg_select.
9479
bbc6b304
PE
94802011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9481
9482 * eval.c (struct backtrace): Simplify and port the data structure.
9483 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9484 signed bit field, as this assumption is not portable and it makes
9485 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9486 "char debug_on_exit : 1" as this is not portable either; instead,
9487 use the portable "unsigned int debug_on_exit : 1". Remove unused
9488 member evalargs. Remove obsolete comments about cc bombing out.
9489
9851bfc5
JD
94902011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9491
51bb811f 9492 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9493 Let HAVE_GSETTINGS override HAVE_GCONF.
9494 (store_monospaced_changed): New function.
9495 (EMACS_SETTINGS): A new type derived from GObject to handle
9496 GSettings notifications.
9497 (emacs_settings_constructor, emacs_settings_get_property)
9498 (emacs_settings_set_property, emacs_settings_class_init):
9499 New functions.
9500 (gsettings_client, gsettings_obj): New variables.
9501 (GSETTINGS_SCHEMA): New define.
9502 (something_changedCB): Call store_monospaced_changed.
9503 (init_gsettings): New function.
9504 (xsettings_initialize): Call init_gsettings.
9505 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9506 to NULL.
9507
640c8776 9508 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9509 GCONF_CFLAGS/LIBS.
9510
5386012d
MR
95112011-06-29 Martin Rudalics <rudalics@gmx.at>
9512
9513 * window.c (resize_root_window, grow_mini_window)
9514 (shrink_mini_window): Rename Qresize_root_window to
9515 Qwindow_resize_root_window and Qresize_root_window_vertically to
9516 Qwindow_resize_root_window_vertically.
9517
f13e0b08
PE
95182011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9519
9520 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9521
94515237
JB
95222011-06-27 Juanma Barranquero <lekktu@gmail.com>
9523
9524 * makefile.w32-in: Redesign dependencies so they reflect more
9525 clearly which files are directly included by each source file,
9526 and not through other includes.
9527
e43b6e43
MR
95282011-06-27 Martin Rudalics <rudalics@gmx.at>
9529
9530 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9531 (sort_overlays, overlay_strings): When an overlay's clone number
9532 matches the window's clone number process the overlay even if
9533 the overlay's window property doesn't match the current window.
9534
d68443dc
MR
9535 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9536 (Fwindow_hchild): Rename to Fwindow_left_child.
9537 (Fwindow_next): Rename to Fwindow_next_sibling.
9538 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9539 (resize_window_check): Rename to window_resize_check.
9540 (resize_window_apply): Rename to window_resize_apply.
9541 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9542 (Fdelete_other_windows_internal, resize_frame_windows)
9543 (Fsplit_window_internal, Fdelete_window_internal)
9544 (grow_mini_window, shrink_mini_window)
9545 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9546
c7e73be5
JD
95472011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9548
9549 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9550 (emacs_fixed_set_min_size): Remove.
9551 (emacs_fixed_new): Take frame as argument.
9552
9553 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9554 (_EmacsFixedPrivate): Remove minwidth/height.
9555 Add struct frame *f.
9556 (emacs_fixed_init): Initialize priv->f.
9557 (get_parent_class, emacs_fixed_set_min_size): Remove.
9558 (emacs_fixed_new): Set priv->f to argument.
9559 (emacs_fixed_get_preferred_width)
9560 (emacs_fixed_get_preferred_height): Use min_width/height from
9561 frames size_hint to set minimum and natural (Bug#8919).
9562 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9563 and use min_width/height from frames size_hint to set
9564 min_width/height (Bug#8919).
9565
9566 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9567 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9568 Fix indentation.
c7e73be5 9569
cf99dcf8
EZ
95702011-06-26 Eli Zaretskii <eliz@gnu.org>
9571
9572 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9573 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9574 called at ZV.
9575
029529ac
CY
95762011-06-26 Chong Yidong <cyd@stupidchicken.com>
9577
9578 * process.c (wait_reading_process_output): Bypass select if
9579 waiting for a cell while ignoring keyboard input, and input is
9580 pending. Suggested by Jan Djärv (Bug#8869).
9581
7a7ef429
PE
95822011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9583
9584 Use gnulib's dup2 module instead of rolling our own.
9585 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9586
11fdef7d 95872011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9588
9589 * dispnew.c (scrolling_window): Before scrolling, turn off a
9590 mouse-highlight in the window being scrolled.
9591
cd3520a4
JB
95922011-06-24 Juanma Barranquero <lekktu@gmail.com>
9593
9594 Move DEFSYM to lisp.h and use everywhere.
9595
9596 * character.h (DEFSYM): Move declaration...
9597 * lisp.h (DEFSYM): ...here.
9598
9599 * gnutls.c:
9600 * minibuf.c:
9601 * w32menu.c:
9602 * w32proc.c:
9603 * w32select.c: Don't include character.h.
9604
9605 * alloc.c (syms_of_alloc):
9606 * buffer.c (syms_of_buffer):
9607 * bytecode.c (syms_of_bytecode):
9608 * callint.c (syms_of_callint):
9609 * casefiddle.c (syms_of_casefiddle):
9610 * casetab.c (init_casetab_once):
9611 * category.c (init_category_once, syms_of_category):
9612 * ccl.c (syms_of_ccl):
9613 * cmds.c (syms_of_cmds):
9614 * composite.c (syms_of_composite):
9615 * dbusbind.c (syms_of_dbusbind):
9616 * dired.c (syms_of_dired):
9617 * dispnew.c (syms_of_display):
9618 * doc.c (syms_of_doc):
9619 * editfns.c (syms_of_editfns):
9620 * emacs.c (syms_of_emacs):
9621 * eval.c (syms_of_eval):
9622 * fileio.c (syms_of_fileio):
9623 * fns.c (syms_of_fns):
9624 * frame.c (syms_of_frame):
9625 * fringe.c (syms_of_fringe):
9626 * insdel.c (syms_of_insdel):
9627 * keymap.c (syms_of_keymap):
9628 * lread.c (init_obarray, syms_of_lread):
9629 * macros.c (syms_of_macros):
9630 * msdos.c (syms_of_msdos):
9631 * print.c (syms_of_print):
9632 * process.c (syms_of_process):
9633 * search.c (syms_of_search):
9634 * sound.c (syms_of_sound):
9635 * syntax.c (init_syntax_once, syms_of_syntax):
9636 * terminal.c (syms_of_terminal):
9637 * textprop.c (syms_of_textprop):
9638 * undo.c (syms_of_undo):
9639 * w32.c (globals_of_w32):
9640 * window.c (syms_of_window):
9641 * xdisp.c (syms_of_xdisp):
9642 * xfaces.c (syms_of_xfaces):
9643 * xfns.c (syms_of_xfns):
9644 * xmenu.c (syms_of_xmenu):
9645 * xsettings.c (syms_of_xsettings):
9646 * xterm.c (syms_of_xterm): Use DEFSYM.
9647
4228cf16
TZ
96482011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9649
cd3520a4 9650 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9651
7fcccf1e
PE
96522011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9653
7efb4e0e
PE
9654 Integer and buffer overflow fixes (Bug#8873).
9655
ff5844ad
PE
9656 * print.c (printchar, strout): Check for string overflow.
9657 (PRINTPREPARE, printchar, strout):
9658 Don't set size unless allocation succeeds.
9659
90532f02
PE
9660 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9661 for sizes. Check for string overflow more accurately.
9662 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9663
6d84508d
PE
9664 * macros.c: Integer and buffer overflow fixes.
9665 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9666 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9667 Use ptrdiff_t, not int, for sizes.
9668 Don't increment bufsize until after realloc succeeds.
9669 Check for size-calculation overflow.
9670 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9671
437b2cb4
PE
9672 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9673
8b9ac8b4
PE
9674 * lread.c: Integer overflow fixes.
9675 (read_integer): Radix is now EMACS_INT, not int,
9676 to improve quality of diagnostics for out-of-range radices.
9677 Calculate buffer size correctly for out-of-range radices.
9678 (read1): Check for integer overflow in radices, and in
9679 read-circle numbers.
82cb60d3
PE
9680 (read_escape): Avoid int overflow.
9681 (Fload, openp, read_buffer_size, read1)
9682 (substitute_object_recurse, read_vector, read_list, map_obarray):
9683 Use ptrdiff_t, not int, for sizes.
9684 (read1): Use EMACS_INT, not int, for sizes.
20270765 9685 Check for size overflow.
8b9ac8b4 9686
7fcccf1e
PE
9687 * image.c (cache_image): Check for size arithmetic overflow.
9688
bfbbd7e7
PE
9689 * lread.c: Integer overflow issues.
9690 (saved_doc_string_size, saved_doc_string_length)
9691 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9692 Now ptrdiff_t, not int.
9693 (read1): Don't assume doc string length fits in int. Check for
9694 out-of-range doc string lengths.
9695 (read_list): Don't assume file position fits in int.
39019e54 9696 (read_escape): Check for hex character overflow.
bfbbd7e7 9697
4e323265
LL
96982011-06-22 Leo Liu <sdl.web@gmail.com>
9699
9700 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9701 Move to minibuffer.el.
9702
85fece3e
PE
97032011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9704
20b84ce9 9705 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9706 The following patches are for when GLYPH_DEBUG && !XASSERT.
9707 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9708 * dispnew.c (flush_stdout):
9709 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9710 Mark as externally visible.
9711 * dispnew.c (check_window_matrix_pointers): Now static.
9712 * dispnew.c (window_to_frame_vpos):
9713 * xfns.c (unwind_create_frame):
9714 * xterm.c (x_check_font): Remove unused local.
9715 * scroll.c (CHECK_BOUNDS):
9716 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9717 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9718 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9719 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9720 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9721 Now static.
9722 (debug_method_add): Use va_list and vsprintf rather than relying
9723 on undefined behavior with wrong number of arguments.
9724 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9725 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9726 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9727 since we're not interested in debugging glyphs with old libraries.
9728 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9729 GCC 4.6.0's static checking.
9730
0766b489
PE
97312011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9732
31fd4b32
PE
9733 Integer overflow and signedness fixes (Bug#8873).
9734 A few related buffer overrun fixes, too.
9735
b79e8648
PE
9736 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9737
0766b489
PE
9738 * dispextern.h (struct face.stipple):
9739 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9740 (x_bitmap_mask, x_allocate_bitmap_record)
9741 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9742 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9743 (x_create_bitmap_from_xpm_data):
9744 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9745 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9746 (.bitmaps_last):
9747 * xfaces.c (load_pixmap):
9748 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9749 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9750 (.bitmaps_last, struct x_output.icon_bitmap):
9751 Use ptrdiff_t, not int, for bitmap indexes.
9752 (x_allocate_bitmap_record): Check for size overflow.
9753 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9754
b081724f
PE
9755 Use ptrdiff_t, not int, for overlay counts.
9756 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9757 * editfns.c (overlays_around, get_pos_property):
9758 * textprop.c (get_char_property_and_overlay):
9759 * xdisp.c (next_overlay_change, note_mouse_highlight):
9760 * xfaces.c (face_at_buffer_position):
21514da7
PE
9761 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9762 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9763 (Fnext_overlay_change, Fprevious_overlay_change)
9764 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9765 Use ptrdiff_t, not int, for sizes.
21514da7 9766 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9767
3de73e5e
PE
9768 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9769
2606c57b
PE
9770 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9771 (x_session_initialize): Do not assume string length fits in int.
9772
aaafe47a
PE
9773 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9774 This is unlikely, but can occur if DPI is outlandish.
9775
2674ddc8 9776 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9777 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9778
28154962
PE
9779 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9780 * xrdb.c (magic_file_p, search_magic_path):
9781 Omit last arg SUFFIX; it was always 0. All callers changed.
9782 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9783
7de51af5
PE
9784 * xfont.c (xfont_match): Avoid need for strlen.
9785
25ed6cc3
PE
9786 * xfns.c: Don't assume strlen fits in int.
9787 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9788
4eab31dd
PE
9789 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9790 not unsigned long, as we prefer signed integers. All callers changed.
9791 Detect integer overflow in repeat count.
9792 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9793 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9794
171e2a58
PE
9795 * termcap.c: Don't assume sizes fit in int and never overflow.
9796 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9797 (gobble_line): Check for size-calculation overflow.
9798
ad39faca 9799 * minibuf.c (Fread_buffer):
6e5bb2dc 9800 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9801 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9802 Don't assume string length fits in int.
9803
52c61c22 9804 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9805 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9806
b5b8c9e5
PE
9807 * font.c: Don't assume string length fits in int.
9808 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9809 Use ptrdiff_t, not int.
ccd6111c
PE
9810 (font_intern_prop): Don't assume string length fits in int.
9811 Don't assume integer property fits in fixnum.
9812 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9813
882f0d81 9814 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9815 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9816 Reformulate so as not to need the command string.
9817 Invoke gzip -cd rather than gunzip, as it's more portable.
9818 (lock_info_type, lock_file_1, lock_file):
9819 Don't assume pid_t and time_t fit in unsigned long.
9820 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9821 (current_lock_owner): Prefer signed type for sizes.
9822 Use memcpy, not strncpy, where memcpy is what is really wanted.
9823 Don't assume (via atoi) that time_t and pid_t fit in int.
9824 Check for time_t and/or pid_t out of range, e.g., via a network share.
9825 Don't alloca where an auto var works fine.
9826
93f4cf88
PE
9827 * fileio.c: Fix some integer overflow issues.
9828 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9829 Don't assume string length fits in int.
9830 (directory_file_name): Don't assume string length fits in long.
9831 (make_temp_name): Don't assume pid fits in int, or that its print
9832 length is less than 20.
9833
f3e92b69
PE
9834 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9835
1bfdaf10
PE
9836 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9837
35016e9a
PE
9838 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9839
3d1e65a1
PE
9840 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9841 We prefer signed integers, even for size calculations.
9842
0b963a93
PE
9843 * emacs.c: Don't assume string length fits in 'int'.
9844 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9845 (main): Don't invoke strlen when not needed.
9846
573f4b54
PE
9847 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9848 (XD_DEBUG_MESSAGE): Don't waste a byte.
9849
989f33ba
PE
9850 * callproc.c (getenv_internal_1, getenv_internal)
9851 (Fgetenv_internal):
965d34eb
PE
9852 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9853
e4d29b33
PE
9854 * lread.c (invalid_syntax): Omit length argument.
9855 All uses changed. This doesn't fix a bug, but it simplifies the
9856 code away from its former Hollerith-constant appearance, and it's
9857 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9858 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9859
eb49b136
PE
9860 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9861 This didn't break anything, but it didn't help either.
9862 It's confusing to put a bogus integer in a place where the actual
9863 value does not matter.
9f62aeb1 9864 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9865 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9866
15375a22
PE
9867 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9868 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9869 implementation.
b61cc01c
PE
9870 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9871 We prefer signed types, and the value cannot exceed the EMACS_INT
9872 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9873 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9874 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9875 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9876
53b2623d
PE
9877 * indent.c (sane_tab_width): New function.
9878 (current_column, scan_for_column, Findent_to, position_indentation)
9879 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9880 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9881
51cab52b 9882 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9883
f2ed8a70
PE
9884 * lisp.h (lint_assume): New macro.
9885 * composite.c (composition_gstring_put_cache):
9886 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9887
abe80cc6
PE
9888 * editfns.c, insdel.c:
9889 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9890
b02c740e
PE
9891 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9892
ebc96716
PE
9893 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9894
b4e50fa0 9895 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9896 Use much-faster test for byte-length change.
311d5d7c 9897 Don't assume string byte-length fits in 'int'.
a4cf38e4 9898 Check that character arg fits in 'int'.
85461888 9899 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9900
c0c1ee9f
PE
9901 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9902
a498d7f4
PE
9903 * fns.c (concat): Catch string overflow earlier.
9904 Do not rely on integer wraparound.
9905
51cab52b
PE
9906 * dispextern.h (struct it.overlay_strings_charpos)
9907 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9908 * xdisp.c (forward_to_next_line_start)
9909 (back_to_previous_visible_line_start)
9910 (reseat_at_next_visible_line_start, next_element_from_buffer):
9911 Don't arbitrarily truncate the value of 'selective' to int.
9912
76031fad
PE
9913 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9914
5eb55db9
PE
9915 * composite.c: Don't truncate sizes to 'int'.
9916 (composition_gstring_p, composition_reseat_it)
9917 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9918 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9919 not EMACS_UINT, for indexes.
5eb55db9 9920
0703a717
PE
9921 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9922
d6202519
PE
9923 * buffer.c: Include <verify.h>.
9924 (struct sortvec.priority, struct sortstr.priority):
8961a454 9925 Now EMACS_INT, not int.
c20998a7 9926 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9927 (struct sortstr.size, record_overlay_string)
9928 (struct sortstrlist.size, struct sortlist.used):
9929 Don't truncate size to int.
9930 (record_overlay_string): Check for size-calculation overflow.
d6202519 9931 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9932
d5a19415
JM
99332011-06-22 Jim Meyering <meyering@redhat.com>
9934
029529ac 9935 Don't leak an XBM-image-sized buffer
d5a19415
JM
9936 * image.c (xbm_load): Free the image buffer after using it.
9937
a9041e6c
PE
99382011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9939
9940 Port to Sun C.
9941 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9942 that Sun C diagnosed.
9943 * fns.c (secure_hash): Fix pointer signedness issue.
9944 * intervals.c (static_offset_intervals): New function.
9945 (offset_intervals): Use it.
9946
7f3f739f
LL
99472011-06-21 Leo Liu <sdl.web@gmail.com>
9948
9949 * deps.mk (fns.o):
9950 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9951 sha512.h.
9952
9953 * fns.c (secure_hash): Rename from crypto_hash_function and change
9954 the first arg to accept symbols.
5b66d427 9955 (Fsecure_hash): New primitive.
7f3f739f
LL
9956 (syms_of_fns): New symbols.
9957
76147d94
DD
99582011-06-20 Deniz Dogan <deniz@dogan.se>
9959
9960 * process.c (Fset_process_buffer): Clarify return value in
9961 docstring.
9962
7d7d0045
CY
99632011-06-18 Chong Yidong <cyd@stupidchicken.com>
9964
9965 * dispnew.c (add_window_display_history): Use BVAR.
9966
9967 * xdisp.c (debug_method_add): Use BVAR.
9968 (check_window_end, dump_glyph_matrix, dump_glyph)
9969 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9970
9971 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9972 Likewise.
9973
9974 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9975 check till after the cache is created in init_frame_faces.
9976
ff2bc410
SM
99772011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9978
9979 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9980
28177add
PE
99812011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9982
dd3482fe
PE
9983 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9984 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9985 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9986
393d71f3 9987 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9988 * fileio.c (Finsert_file_contents):
9989 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9990 Remove the old (too-loose) buffer overflow checks.
9991 They weren't needed, since make_gap checks for buffer overflow.
9992 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9993 The old code merely checked for Emacs fixnum overflow, and relied
9994 on undefined (wraparound) behavior. The new code avoids undefined
9995 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9996
2e6813b0 9997 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9998 Tune. Don't use wider integers than needed. Don't use alloca.
9999 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10000
599a9e4f
PE
10001 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10002
99561444
PE
10003 * insdel.c, lisp.h (buffer_overflow): New function.
10004 (insert_from_buffer_1, replace_range, replace_range_2):
10005 * insdel.c (make_gap_larger):
10006 * editfns.c (Finsert_char):
10007 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10008
28177add
PE
10009 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10010
e69dafad
PE
100112011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10012
4baa020d 10013 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10014
b1c46f02
PE
10015 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10016 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10017
e69dafad
PE
10018 * fileio.c: Don't assume EMACS_INT fits in off_t.
10019 (emacs_lseek): New static function.
10020 (Finsert_file_contents, Fwrite_region): Use it.
10021 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10022
566684ea
PE
10023 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10024
e6966cd6
PE
10025 * fns.c: Don't overflow int when computing a list length.
10026 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10027 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10028 truncation on 64-bit hosts. Check for QUIT every
10029 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10030 faster and is responsive enough.
10031 (Flength): Report an error instead of overflowing an integer.
10032 (Fsafe_length): Return a float if the value is not representable
10033 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10034 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10035 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10036
dd0b0efb
PE
10037 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10038 (header_size, word_size): New constants.
10039 (allocate_vectorlike): Don't check size overflow here.
10040 (allocate_vector): Check it here instead, since this is the only
10041 caller of allocate_vectorlike that could cause overflow.
10042 Check that the new vector's length is representable as a fixnum.
10043
86fe5cfe
PE
10044 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10045 The previous code was bogus. For example, next_almost_prime (32)
10046 returned 39, which is undesirable as it is a multiple of 3; and
10047 next_almost_prime (24) returned 25, which is a multiple of 5 so
10048 why was the code bothering to check for multiples of 7?
10049
80e88859
PE
10050 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10051
4a2f0ad6
PE
10052 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10053
f66c7cf8
PE
10054 Variadic C functions now count arguments with ptrdiff_t.
10055 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10056 Back then I didn't know that the Emacs coding style prefers signed int.
10057 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10058 were being counted with int, which may truncate counts on 64-bit
10059 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10060 * lisp.h (struct Lisp_Subr.function.aMANY)
10061 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10062 Arg counts are now ptrdiff_t, not size_t.
10063 All variadic functions and their callers changed accordingly.
10064 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10065 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10066 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10067 * callint.c (Fcall_interactively): Check arg count for overflow,
10068 to avoid potential buffer overrun. Use signed char, not 'int',
10069 for 'varies' array, so that we needn't bother to check its size
10070 calculation for overflow.
10071 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10072 * eval.c (apply_lambda):
10073 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10074 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10075 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10076
a1759b76
PE
10077 * callint.c (Fcall_interactively): Don't use index var as event count.
10078
d96be9fc
PE
10079 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10080 * mem-limits.h (SIZE): Remove; no longer used.
10081
a690a978 10082 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10083
578c21e6
PE
10084 Remove unnecessary casts.
10085 * xterm.c (x_term_init):
10086 * xfns.c (x_set_border_pixel):
10087 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10088 These aren't needed now that we assume ANSI C.
10089
96f53c6c
PE
10090 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10091 It's more likely to cause problems (due to unsigned overflow)
10092 than to cure them.
10093
83c77d31
PE
10094 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10095
ee2079f1
PE
10096 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10097
6da65536
PE
10098 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10099
7147c4a4
PE
10100 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10101
193e32d9
PE
10102 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10103
e5533da6
PE
10104 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10105
9910e595
PE
10106 GLYPH_CODE_FACE returns EMACS_INT, not int.
10107 * dispextern.h (merge_faces):
10108 * xfaces.c (merge_faces):
01103c44
PE
10109 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10110 Don't assume EMACS_INT fits in int.
9910e595 10111
2638320e
PE
10112 * character.h (CHAR_VALID_P): Remove unused parameter.
10113 * fontset.c, lisp.h, xdisp.c: All uses changed.
10114
045eb8d9
PE
10115 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10116
c1f134b5
PE
10117 * fns.c (concat): Minor tuning based on overflow analysis.
10118 This doesn't fix any bugs. Use int to hold character, instead
10119 of constantly refetching from Emacs object. Use XFASTINT, not
10120 XINT, for value known to be a character. Don't bother comparing
10121 a single byte to 0400, as it's always less.
10122
395fcb93 10123 * floatfns.c (Fexpt):
327eeec8
PE
10124 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10125
abbd3d23
PE
10126 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10127 for characters.
10128
684a03ef
PE
10129 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10130
0fed43f3
PE
10131 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10132 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10133 incorrectly succeed when S was a string, because 4294967386 was
10134 truncated before it was used.
10135
8fd02eb7
PE
10136 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10137 Otherwise, an out-of-range integer could cause undefined behavior
10138 on a 64-bit host.
10139
f8c86b69
PE
10140 * composite.c: Use int, not EMACS_INT, for characters.
10141 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10142 EMACS_INT, for values that are known to be in character range.
10143 This doesn't fix any bugs but is the usual style inside Emacs and
10144 may generate better code on 32-bit machines.
10145
34206dd2
PE
10146 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10147 This is for reasons similar to the recent CHAR_STRING fix.
10148 * charset.c (Fencode_char): Check that character arg is actually
10149 a character. Pass an int to ENCODE_CHAR.
10150 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10151 wider than 'int', as a compile-time check to prevent future regressions
10152 in this area.
10153
c5958d4c 10154 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10155
10156 Make sure a 64-bit char is never passed to CHAR_STRING.
10157 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10158 by silently ignoring the top 32 bits, allowing some values
10159 that were far too large to be valid characters.
10160 * character.h: Include <verify.h>.
10161 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10162 arguments are no wider than unsigned, as a compile-time check
10163 to prevent future regressions in this area.
10164 * data.c (Faset):
01103c44 10165 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10166 (Fsubst_char_in_region):
10167 * fns.c (concat):
10168 * xdisp.c (decode_mode_spec_coding):
10169 Adjust to CHAR_STRING's new requirement.
10170 * editfns.c (Finsert_char, Fsubst_char_in_region):
10171 * fns.c (concat): Check that character args are actually
10172 characters. Without this test, these functions did the wrong
10173 thing with wildly out-of-range values on 64-bit hosts.
10174
d37ca623
PE
10175 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10176 These casts should not be needed on 32-bit hosts, either.
10177 * keyboard.c (read_char):
10178 * lread.c (Fload): Remove casts to unsigned.
10179
ea204efb
PE
10180 * lisp.h (UNSIGNED_CMP): New macro.
10181 This fixes comparison bugs on 64-bit hosts.
10182 (ASCII_CHAR_P): Use it.
10183 * casefiddle.c (casify_object):
01103c44 10184 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10185 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10186 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10187 * dispextern.h (FACE_FROM_ID):
10188 * keyboard.c (read_char): Use UNSIGNED_CMP.
10189
41cb286c
PE
10190 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10191 not to EMACS_INT, to avoid GCC warning.
10192
4a1b9832
PE
10193 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10194
55daad71
PE
10195 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10196 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10197 isn't needed on 32-bit machines.
8f95c75c 10198
01103c44
PE
10199 * buffer.c (Fgenerate_new_buffer_name):
10200 Use EMACS_INT for count, not int.
0ceccced 10201 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10202
10203 * data.c (Qcompiled_function): Now static.
10204
c6f072e7
PE
10205 * window.c (window_body_lines): Now static.
10206
20ce5912
PE
10207 * image.c (gif_load): Rename local to avoid shadowing.
10208
9c4c5f81
PE
10209 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10210 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10211 * alloc.c (make_save_value): Integer argument is now of type
10212 ptrdiff_t, not int.
10213 (mark_object): Use ptrdiff_t, not int.
10214 * lisp.h (pD): New macro.
10215 * print.c (print_object): Use it.
10216
c0c5c8ae
PE
10217 * alloc.c: Use EMACS_INT, not int, to count objects.
10218 (total_conses, total_markers, total_symbols, total_vector_size)
10219 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10220 (total_free_floats, total_floats, total_free_intervals)
10221 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10222 Now EMACS_INT, not int. All uses changed.
10223 (Fgarbage_collect): Compute overall total using a double, so that
10224 integer overflow is less likely to be a problem. Check for overflow
10225 when converting back to an integer.
5a25e253
PE
10226 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10227 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10228 These were 'int' variables that could overflow on 64-bit hosts;
10229 they were never used, so remove them instead of repairing them.
211a0b2a 10230 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10231 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10232 Previously, this ceilinged at INT_MAX, but that doesn't work on
10233 64-bit machines.
e46bb31a 10234 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10235
c78baabf 10236 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10237 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10238 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10239 when a (possibly-narrower) signed value would do just as well.
10240 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10241
c9d624c6
PE
10242 * alloc.c: Catch some string size overflows that we were missing.
10243 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10244 for convenience in STRING_BYTES_MAX.
10245 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10246 The definition here is exact; the one in lisp.h was approximate.
10247 (allocate_string_data): Check for string overflow. This catches
10248 some instances we weren't catching before. Also, it catches
10249 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10250 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10251 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10252
c9d624c6
PE
10253 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10254 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10255 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10256
353032ce
PE
10257 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10258
2bccce07
PE
10259 * alloc.c (Fmake_string): Check for out-of-range init.
10260
0ac30604
SM
102612011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10262
10263 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10264
c195f2de
JD
102652011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10266
10267 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10268 xg_get_default_scrollbar_width.
10269
10270 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10271 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10272 (style_changed_cb): Call update_theme_scrollbar_width and call
10273 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10274 all frames (Bug#8505).
10275 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10276 Call gtk_window_set_resizable if HAVE_GTK3.
10277 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10278 and height if HAVE_GTK3 (Bug#8505).
10279 (scroll_bar_width_for_theme): New variable.
10280 (update_theme_scrollbar_width): New function.
10281 (xg_get_default_scrollbar_width): Move code to
10282 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10283 (xg_initialize): Call update_theme_scrollbar_width.
10284
10285 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10286
10287 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10288
e10ac9f1
MR
102892011-06-12 Martin Rudalics <rudalics@gmx.at>
10290
10291 * frame.c (make_frame): Call other_buffer_safely instead of
10292 other_buffer.
10293
10294 * window.c (temp_output_buffer_show): Call display_buffer with
10295 second argument Vtemp_buffer_show_specifiers and reset latter
10296 immediately after the call.
10297 (Vtemp_buffer_show_specifiers): New variable.
10298 (auto_window_vscroll_p, next_screen_context_lines)
10299 (Vscroll_preserve_screen_position): Remove leading asterisks from
10300 doc-strings.
10301
2d3c217e 103022011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10303
7b7f97e8 10304 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10305 * buffer.c (Qclone_number): Remove for now, as it's unused.
10306 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10307 (record_buffer): Remove unused local.
10308 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10309 (set_frame_buffer_list): Remove; unused.
10310 * frame.h (other_visible_frames): Remove decl.
10311 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10312 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10313 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10314 if HAVE_GPM.
10315 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10316 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10317 Define only if HAVE_GPM.
10318 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10319 (update_hints_inhibit): Remove; never set. All uses removed.
10320 * widgetprv.h (emacsFrameClassRec): Remove decl.
10321 * window.c (delete_deletable_window): Now returns void, since it
10322 wasn't returning anything.
10323 (compare_window_configurations): Remove unused locals.
10324 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10325 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10326 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10327 the same widths as pointers. This follows up on the 2011-05-06 patch.
10328 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10329 * xterm.h: Likewise.
10330 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10331
1384b89e
JB
103322011-06-12 Juanma Barranquero <lekktu@gmail.com>
10333
10334 * makefile.w32-in: Update dependencies.
10335 (LISP_H): Add lib/intprops.h.
10336
1100a63c
CY
103372011-06-11 Chong Yidong <cyd@stupidchicken.com>
10338
10339 * image.c (gif_load): Add animation frame delay to the metadata.
10340 (syms_of_image): Use DEFSYM. New symbol `delay'.
10341
6198ccd0
MR
103422011-06-11 Martin Rudalics <rudalics@gmx.at>
10343
10344 * window.c (delete_deletable_window): Re-add.
10345 (Fset_window_configuration): Rewrite to handle dead buffers and
10346 consequently deletable windows.
10347 (window_tree, Fwindow_tree): Remove. Supply functionality in
10348 window.el.
10349 (compare_window_configurations): Simplify code.
10350
b6e3633c
AS
103512011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10352
1ab0dee5
AS
10353 * image.c (imagemagick_load_image): Fix type mismatch.
10354 (Fimagemagick_types): Likewise.
10355
b6e3633c
AS
10356 * window.h (replace_buffer_in_windows): Declare.
10357
9397e56f
MR
103582011-06-11 Martin Rudalics <rudalics@gmx.at>
10359
10360 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10361 Qclone_number. Remove external declaration of Qdelete_window.
10362 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10363 code.
640c8776
SM
10364 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10365 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10366 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10367 buffer list implementation.
10368 (other_buffer_safely): New function.
10369 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10370 calls to replace_buffer_in_windows and
10371 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10372 if allowed.
10373 (record_buffer): Inhibit quitting and rewrite using quittable
10374 functions. Run Qbuffer_list_update_hook if allowed.
10375 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10376 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10377 Move switch-to-buffer to window.el.
9397e56f
MR
10378 (bury-buffer): Move to window.el.
10379 (Vbuffer_list_update_hook): New variable.
10380
10381 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10382 section.
10383
10384 * window.h (resize_frame_windows): Move up in code.
10385 (Fwindow_frame): Remove EXFUN.
10386 (replace_buffer_in_all_windows): Remove prototype.
10387 (replace_buffer_in_windows_safely): Add prototype.
10388
10389 * window.c: Declare Qdelete_window static again. Move down
10390 declaration of select_count.
10391 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10392 (Fother_window): Move to window.el.
10393 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10394 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10395 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10396 window.el.
10397 (replace_buffer_in_windows): Implement by calling
10398 Qreplace_buffer_in_windows.
10399 (replace_buffer_in_all_windows): Remove with some functionality
10400 moved into replace_buffer_in_windows_safely.
10401 (replace_buffer_in_windows_safely): New function.
10402 (select_window_norecord, select_frame_norecord): Move in front
10403 of run_window_configuration_change_hook. Remove now obsolete
10404 declarations.
640c8776
SM
10405 (Fset_window_buffer): Rewrite doc-string.
10406 Call Qrecord_window_buffer.
9397e56f
MR
10407 (keys_of_window): Move binding for other-window to window.el.
10408
b50691aa
CY
104092011-06-11 Chong Yidong <cyd@stupidchicken.com>
10410
10411 * dispextern.h (struct image): Replace data member, whose int_val
10412 and ptr_val fields were not used by anything, with a single
10413 lisp_val object.
10414
10415 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10416 (gif_clear_image, gif_load, imagemagick_load_image)
10417 (gs_clear_image, gs_load): Callers changed.
10418
3f754b86
PE
104192011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10420
cca69397
PE
10421 * buffer.h: Include <time.h>, for time_t.
10422 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10423
109e28d0
PE
10424 Fix minor problems found by static checking.
10425
60737f02
PE
10426 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10427
4b66faf3
PE
10428 Make identifiers static if they are not used in other modules.
10429 * data.c (Qcompiled_function, Qframe, Qvector):
10430 * image.c (QimageMagick, Qsvg):
10431 * minibuf.c (Qmetadata):
10432 * window.c (resize_window_check, resize_root_window): Now static.
10433 * window.h (resize_window_check, resize_root_window): Remove decls.
10434
109e28d0
PE
10435 * window.c (window_deletion_count, delete_deletable_window):
10436 Remove; unused.
46a4ce9e
PE
10437 (window_body_lines): Now static.
10438 (Fdelete_other_windows_internal): Mark vars as initialized.
10439 Make sure 'resize_failed' is initialized.
10440 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10441 (resize_window_apply): Remove unused local.
10442 * window.h (delete_deletable_window): Remove decl.
10443
109e28d0 10444 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10445 (imagemagick_load_image): Fix pointer signedness problem by changing
10446 last arg from unsigned char * to char *. All uses changed.
10447 Also, fix a local for similar reasons.
10448 Remove unused locals. Remove locals to avoid shadowing.
10449 (fn_rsvg_handle_free): Remove; unused.
10450 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10451 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10452
3f754b86
PE
10453 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10454
2547adb1
CY
104552011-06-10 Chong Yidong <cyd@stupidchicken.com>
10456
10457 * image.c (gif_load): Fix omitted cast error introduced by
10458 2011-06-06 change.
10459
2c8e37d4
MR
104602011-06-10 Martin Rudalics <rudalics@gmx.at>
10461
10462 * window.h (resize_proportionally, orig_total_lines)
10463 (orig_top_line): Remove from window structure.
10464 (set_window_height, set_window_width, change_window_heights)
10465 (Fdelete_window): Remove prototypes.
10466 (resize_frame_windows): Remove duplicate declaration.
10467
440a42e3
EZ
104682011-06-10 Eli Zaretskii <eliz@gnu.org>
10469
10470 * window.h (resize_frame_windows, resize_window_check)
10471 (delete_deletable_window, resize_root_window)
10472 (resize_frame_windows): Declare prototypes.
10473
10474 * window.c (resize_window_apply): Make definition be "static" to
10475 match the prototype.
10476
562dd5e9
MR
104772011-06-10 Martin Rudalics <rudalics@gmx.at>
10478
10479 * window.c: Remove declarations of Qwindow_size_fixed,
10480 window_min_size_1, window_min_size_2, window_min_size,
10481 size_window, window_fixed_size_p, enlarge_window, delete_window.
10482 Remove static from declaration of Qdelete_window, it's
10483 temporarily needed by Fbury_buffer.
10484 (replace_window): Don't assign orig_top_line and
10485 orig_total_lines.
10486 (Fdelete_window, delete_window): Remove. Window deletion is
10487 handled by window.el.
640c8776
SM
10488 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10489 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10490 (Fdelete_other_windows): Remove. Deleting other windows is
10491 handled by window.el.
10492 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10493 handled in window.el.
10494 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10495 Window minimum sizes are handled in window.el.
10496 (shrink_windows, size_window, set_window_height)
10497 (set_window_width, change_window_heights, window_height)
10498 (window_width, CURBEG, CURSIZE, enlarge_window)
10499 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10500 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10501 handled in window.el.
10502 (make_dummy_parent): Rename to make_parent_window and give it a
10503 second argument horflag.
10504 (make_window): Don't set resize_proportionally any more.
10505 (Fsplit_window): Remove. Windows are split in window.el.
10506 (save_restore_action, save_restore_orig_size)
10507 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10508 Resize mini windows in window.el.
10509 (grow_mini_window, shrink_mini_window): Implement by calling
10510 Qresize_root_window_vertically, resize_window_check and
10511 resize_window_apply.
640c8776
SM
10512 (saved_window, Fset_window_configuration, save_window_save):
10513 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10514 resize_proportionally.
10515 (window_min_height, window_min_width): Move to window.el.
10516 (keys_of_window): Move bindings for delete-other-windows,
10517 split-window, delete-window and enlarge-window to window.el.
10518
10519 * buffer.c: Temporarily extern Qdelete_window.
10520 (Fbury_buffer): Temporarily call Qdelete_window instead of
10521 Fdelete_window (Fbury_buffer will move to window.el soon).
10522
10523 * frame.c (set_menu_bar_lines_1): Remove code handling
10524 orig_top_line and orig_total_lines.
10525
10526 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10527 set_window_height but set heights directly.
10528 (change_frame_size_1): Use resize_frame_windows.
10529
10530 * xdisp.c (init_xdisp): Don't use set_window_height but set
10531 heights directly.
10532
640c8776
SM
10533 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10534 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10535 run_window_configuration_change_hook.
10536
10537 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10538 instead of change_window_heights and run
10539 run_window_configuration_change_hook.
10540
1a13852e
MR
105412011-06-09 Martin Rudalics <rudalics@gmx.at>
10542
10543 * window.c (replace_window): Rename second argument REPLACEMENT to
10544 NEW. New third argument SETFLAG. Rewrite.
10545 (delete_window, make_dummy_parent): Call replace_window with
10546 third argument 1.
10547 (window_list_1): Move down in code.
10548 (run_window_configuration_change_hook): Move set_buffer part
10549 before select_frame_norecord part in order to unwind correctly.
10550 Rename count1 to count.
10551 (recombine_windows, delete_deletable_window, resize_root_window)
10552 (Fdelete_other_windows_internal)
10553 (Frun_window_configuration_change_hook, make_parent_window)
10554 (resize_window_check, resize_window_apply, Fresize_window_apply)
10555 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10556 (Fdelete_window_internal, Fresize_mini_window_internal):
10557 New functions.
1a13852e
MR
10558 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10559
f3d1777e
MR
105602011-06-08 Martin Rudalics <rudalics@gmx.at>
10561
496e208e
MR
10562 * window.h (window): Add some new members to window structure -
10563 normal_lines, normal_cols, new_total, new_normal, clone_number,
10564 splits, nest, prev_buffers, next_buffers.
10565 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10566 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10567
f3d1777e
MR
10568 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10569 Remove.
496e208e
MR
10570 (make_dummy_parent): Set new members of windows structure.
10571 (make_window): Move down in code. Handle new members of window
10572 structure.
10573 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10574 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10575 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10576 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10577 (Fset_window_next_buffers, Fset_window_clone_number):
10578 New functions.
496e208e
MR
10579 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10580 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10581 Doc-string fixes.
10582 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10583 Argument WINDOW can be now internal window too.
10584 (Fwindow_use_time): Move up in code.
10585 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10586 Rewrite doc-string.
10587 (Fset_window_configuration, saved_window)
10588 (Fcurrent_window_configuration, save_window_save): Handle new
10589 members of window structure.
b9e809c2
MR
10590 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10591 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10592 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10593 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10594 Qget_mru_window, Qresize_root_window,
10595 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10596 Qauto_buffer_name; staticpro them.
f3d1777e 10597
abde8f8c
MR
105982011-06-07 Martin Rudalics <rudalics@gmx.at>
10599
10600 * window.c (Fwindow_total_size, Fwindow_left_column)
10601 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10602 (Fwindow_list_1): New functions.
10603 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10604 (Fwindow_width, Fscroll_left, Fscroll_right):
10605 Use window_body_cols instead of window_box_text_cols.
10606 (delete_window, Fset_window_configuration):
10607 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10608 (delete_all_subwindows): Take a window as argument and not a
10609 structure. Rewrite.
190b47e6
MR
10610 (window_loop): Remove handling of GET_LRU_WINDOW and
10611 GET_LARGEST_WINDOW.
10612 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10613
10614 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10615 window_box_text_cols. delete_all_subwindows now takes a
10616 Lisp_Object as argument.
abde8f8c 10617
640c8776
SM
10618 * indent.c (compute_motion, Fcompute_motion):
10619 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10620
fa8a67e6
MR
10621 * frame.c (delete_frame): Call delete_all_subwindows with root
10622 window as argument.
10623
a54e3482
DC
106242011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10625
10626 * fns.c (Fputhash): Document return value.
10627
60002bf5
CY
106282011-06-06 Chong Yidong <cyd@stupidchicken.com>
10629
10630 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10631
0c671da6 106322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10633
b862a52a 10634 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10635
be44ca6c
PE
10636 Check for overflow when converting integer to cons and back.
10637 * charset.c (Fdefine_charset_internal, Fdecode_char):
10638 Use cons_to_unsigned to catch overflow.
10639 (Fencode_char): Use INTEGER_TO_CONS.
10640 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10641 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10642 * data.c (long_to_cons, cons_to_long): Remove.
10643 (cons_to_unsigned, cons_to_signed): New functions.
10644 These signal an error for invalid or out-of-range values.
10645 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10646 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10647 * font.c (Ffont_variation_glyphs):
10648 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10649 * lisp.h: Include <intprops.h>.
10650 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10651 (cons_to_signed, cons_to_unsigned): New decls.
10652 (long_to_cons, cons_to_long): Remove decls.
10653 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10654 (Fprimitive_undo): Use CONS_TO_INTEGER.
10655 * xfns.c (Fx_window_property): Likewise.
10656 * xselect.c: Include <limits.h>.
10657 (x_own_selection, selection_data_to_lisp_data):
10658 Use INTEGER_TO_CONS.
10659 (x_handle_selection_request, x_handle_selection_clear)
10660 (x_get_foreign_selection, Fx_disown_selection_internal)
10661 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10662 (lisp_data_to_selection_data): Use cons_to_unsigned.
10663 (x_fill_property_data): Use cons_to_signed.
10664 Report values out of range.
10665
d1f3d2af
PE
10666 Check for buffer and string overflow more precisely.
10667 * buffer.h (BUF_BYTES_MAX): New macro.
10668 * lisp.h (STRING_BYTES_MAX): New macro.
10669 * alloc.c (Fmake_string):
10670 * character.c (string_escape_byte8):
10671 * coding.c (coding_alloc_by_realloc):
10672 * doprnt.c (doprnt):
10673 * editfns.c (Fformat):
10674 * eval.c (verror):
10675 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10676 since they may not be the same number.
10677 * editfns.c (Finsert_char):
10678 * fileio.c (Finsert_file_contents):
10679 Likewise for BUF_BYTES_MAX.
10680
dd52fcea
PE
10681 * image.c: Use ptrdiff_t, not int, for sizes.
10682 (slurp_file): Switch from int to ptrdiff_t.
10683 All uses changed.
10684 (slurp_file): Check that file size fits in both size_t (for
10685 malloc) and ptrdiff_t (for sanity and safety).
10686
7f9bbdbb
PE
10687 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10688 if b->modtime has its maximal value.
10689
dfe18f82
PE
10690 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10691
84acfcf0
PE
10692 Don't assume time_t can fit into int.
10693 * buffer.h (struct buffer.modtime): Now time_t, not int.
10694 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10695 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10696
ccd9a01a
PE
10697 Minor fixes for signed vs unsigned integers.
10698 * character.h (MAYBE_UNIFY_CHAR):
10699 * charset.c (maybe_unify_char):
10700 * keyboard.c (read_char, reorder_modifiers):
10701 XINT -> XFASTINT, since the integer must be nonnegative.
10702 * ftfont.c (ftfont_spec_pattern):
10703 * keymap.c (access_keymap, silly_event_symbol_error):
10704 XUINT -> XFASTINT, since the integer must be nonnegative.
10705 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10706 since it makes no difference and we prefer signed.
10707 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10708 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10709 nonnegative.
10710
d6d100dd
SM
107112011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10712
10713 * window.h (Fwindow_frame): Declare.
10714
2b6148e4
PE
107152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10716
10717 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10718 (SPARE_MEMORY): Always define.
10719 (LARGE_REQUEST): Remove.
10720 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10721
f230ecc9
MR
107222011-06-06 Martin Rudalics <rudalics@gmx.at>
10723
727e958e
MR
10724 * lisp.h: Move EXFUNS for Fframe_root_window,
10725 Fframe_first_window and Fset_frame_selected_window to window.h.
10726
10727 * window.h: Move EXFUNS for Fframe_root_window,
10728 Fframe_first_window and Fset_frame_selected_window here from
10729 lisp.h.
10730
10731 * frame.c (Fwindow_frame, Fframe_first_window)
10732 (Fframe_root_window, Fframe_selected_window)
10733 (Fset_frame_selected_window): Move to window.c.
10734 (Factive_minibuffer_window): Move to minibuf.c.
10735 (Fother_visible_frames_p): New function.
10736
10737 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10738
f230ecc9
MR
10739 * window.c (decode_window, decode_any_window): Move up in code.
10740 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10741 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10742 (Fwindow_buffer): Move up and rewrite doc-string.
10743 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10744 (Fwindow_prev): New functions.
727e958e
MR
10745 (Fwindow_frame): Move here from frame.c. Accept any window as
10746 argument.
10747 (Fframe_root_window, Fframe_first_window)
10748 (Fframe_selected_window): Move here from frame.c. Accept frame
10749 or arbitrary window as argument. Update doc-strings.
10750 (Fminibuffer_window): Move up in code.
10751 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10752 (Fset_frame_selected_window): Move here from frame.c.
10753 Marginal rewrite.
727e958e
MR
10754 (Fselected_window, select_window, Fselect_window): Move up in
10755 code. Minor doc-string fixes.
f230ecc9 10756
4d09bcf6
PE
107572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10758
10759 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10760 Do not assume that spare memory exists; that assumption is valid
10761 only if SYSTEM_MALLOC.
10762 (LARGE_REQUEST): New macro, so that the issue of large requests
10763 is separated from the issue of spare memory.
10764
810928a2
AS
107652011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10766
172418ad
AS
10767 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10768 format. (Bug#8806)
10769
43f862f7
AS
10770 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10771
810928a2
AS
10772 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10773 before statements.
10774
a059fe24
JD
107752011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10776
10777 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10778
10779 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10780
10781 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10782 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10783
989bf368
JB
107842011-06-05 Juanma Barranquero <lekktu@gmail.com>
10785
10786 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10787
4b80f674
CY
107882011-06-04 Chong Yidong <cyd@stupidchicken.com>
10789
10790 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10791 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10792 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10793 New error handlers.
4b80f674
CY
10794 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10795 Obey Vx_select_enable_clipboard_manager. Catch errors in
10796 x_clipboard_manager_save (Bug#8779).
10797 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10798 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10799
99a33b77 108002011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10801
10802 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10803
99a33b77 108042011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10805
10806 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10807 in the current matrix if keep_current_p is non-zero.
10808
8264569d
EZ
108092011-06-04 Eli Zaretskii <eliz@gnu.org>
10810
10811 * bidi.c (bidi_level_of_next_char): Fix last change.
10812
57f97249
EZ
108132011-06-03 Eli Zaretskii <eliz@gnu.org>
10814
fec2107c 10815 Support bidi reordering of text covered by display properties.
57f97249 10816
fec2107c
EZ
10817 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10818 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10819 (bidi_cache_search, bidi_cache_iterator_state)
10820 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10821 (bidi_level_of_next_char, bidi_move_to_visually_next):
10822 Support character positions inside a run of characters covered by a
fec2107c
EZ
10823 display string.
10824 (bidi_paragraph_init, bidi_resolve_explicit_1)
10825 (bidi_level_of_next_char): Call bidi_fetch_char and
10826 bidi_fetch_char_advance instead of FETCH_CHAR and
10827 FETCH_CHAR_ADVANCE.
10828 (bidi_init_it): Initialize new members.
10829 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10830 definitions.
10831 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10832 instead of using explicit *_CHAR codes.
d6d100dd
SM
10833 (bidi_resolve_explicit, bidi_resolve_weak):
10834 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10835 bidirectional text is supported only in multibyte buffers.
10836 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10837 it to initialize the frame_window_p member of struct bidi_it.
10838 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10839 (bidi_resolve_explicit, bidi_resolve_weak)
10840 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10841 bidi_it->nchars is non-positive.
10842 (bidi_level_of_next_char): Don't try to lookup the cache for the
10843 next/previous character if nothing is cached there yet, or if we
10844 were just reseat()'ed to a new position.
c40e2fb2 10845
0e14fe90
EZ
10846 * xdisp.c (set_cursor_from_row): Set start and stop points
10847 according to the row's direction when priming the loop that looks
10848 for the glyph on which to display cursor.
10849 (single_display_spec_intangible_p): Function deleted.
10850 (display_prop_intangible_p): Reimplement to call
10851 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10852 Accept 3 additional arguments needed by handle_display_spec.
10853 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10854 values: lists, `(when COND...)' forms, etc.
10855 (single_display_spec_string_p): Support property values that are
10856 lists with the argument STRING its top-level element.
10857 (display_prop_string_p): Fix the condition for processing a
10858 property that is a list to be consistent with handle_display_spec.
fec2107c 10859 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10860 last portion of handle_display_prop.
10861 (compute_display_string_pos): Accept additional argument
10862 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10863 value of a `display' property is a "replacing spec".
10864 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10865 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10866 the display property, but just return a value indicating whether
10867 the display property will replace the characters it covers.
10868 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10869 frame_window_p members of struct bidi_it.
d6d100dd
SM
10870 (compute_display_string_pos, compute_display_string_end):
10871 New functions.
fec2107c
EZ
10872 (push_it): Accept second argument POSITION, where pop_it should
10873 jump to continue iteration.
10874 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10875
fec2107c
EZ
10876 * keyboard.c (adjust_point_for_property): Adjust the call to
10877 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10878
10879 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10880 (bidi_init_it): Update prototypes.
10881 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10882 (compute_display_string_pos, compute_display_string_end):
10883 Declare prototypes.
fec2107c
EZ
10884 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10885 EMACS_INT.
fc6f18ce 10886
40087514 108872011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10888
57f53182
PE
10889 Malloc failure behavior now depends on size of allocation.
10890 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10891 * lisp.h: Change signatures accordingly.
10892 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10893 All callers changed. (Bug#8762)
10894
10895 * gnutls.c: Use Emacs's memory allocators.
10896 Without this change, the gnutls library would invoke malloc etc.
10897 directly, which causes problems on non-SYNC_INPUT hosts, and which
10898 runs afoul of improving memory_full behavior. (Bug#8761)
10899 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10900 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10901 xfree instead of the default malloc, realloc, free.
10902 (Fgnutls_boot): No need to check for memory allocation failure,
10903 since xmalloc does that for us.
10904
ac32cd99 10905 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10906 * category.c (hash_get_category_set):
10907 * ccl.c (ccl_driver):
10908 * charset.c (Fdefine_charset_internal):
10909 * charset.h (struct charset.hash_index):
10910 * composite.c (get_composition_id, gstring_lookup_cache)
10911 (composition_gstring_put_cache):
10912 * composite.h (struct composition.hash_index):
10913 * dispextern.h (struct image.hash):
10914 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10915 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10916 (hashfn_equal, hashfn_user_defined, make_hash_table)
10917 (maybe_resize_hash_table, hash_lookup, hash_put)
10918 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10919 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10920 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10921 * image.c (make_image, search_image_cache, lookup_image)
10922 (xpm_put_color_table_h):
10923 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10924 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10925 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10926 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10927 * alloc.c (allocate_vectorlike):
10928 Check for overflow in vector size calculations.
10929 * ccl.c (ccl_driver):
10930 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10931 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10932 need to be updated by these changes.
40087514
PE
10933 * fns.c (make_hash_table, maybe_resize_hash_table):
10934 Check for integer overflow with large hash tables.
0de4bb68
PE
10935 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10936 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10937 (SXHASH_REDUCE): New macro.
10938 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10939 Use it instead of discarding useful hash info with large hash values.
10940 (sxhash_float): New function.
10941 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10942 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10943 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10944 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10945 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10946 Adjust signatures to match updated version of code.
10947 (consing_since_gc): Now EMACS_INT, since a single hash table can
10948 use more than INT_MAX bytes.
10949
698d32e2
DN
109502011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10951
10952 Make it possible to build with GCC-4.6+ -O2 -flto.
10953
10954 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10955
fd6fa53f
SM
109562011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10957
10958 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10959 Call minibuffer-inactive-mode.
10960
864db017
JB
109612011-05-31 Juanma Barranquero <lekktu@gmail.com>
10962
10963 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10964 Update dependencies.
10965
2ad0baf4
DN
109662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10967
10968 * data.c (init_data): Remove code for UTS, this system is not
10969 supported anymore.
10970
4fcc2638
DN
109712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10972
10973 Don't force ./temacs to start in terminal mode.
10974
10975 * frame.c (make_initial_frame): Initialize faces in all cases, not
10976 only when CANNOT_DUMP is defined.
10977 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10978
c56e0fd5
DN
109792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10980
10981 * dispnew.c (add_window_display_history): Use const for the string
10982 pointer. Remove declaration, not needed.
10983
333d54da 109842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10985
55d4c1b2 10986 Use 'inline', not 'INLINE'.
333d54da 10987 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10988 * alloc.c, fontset.c (INLINE): Remove.
10989 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10990 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10991 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10992 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10993 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10994
738db178
DN
109952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10996
10997 Make it possible to run ./temacs.
10998
10999 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11000 syms_of_callproc does the same thing. Remove test for
11001 "initialized", do it in the caller.
11002 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11003
620c53a6
SM
110042011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11005
11006 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11007 (read_minibuf): Use get_minibuffer.
11008 (syms_of_minibuf): Use DEFSYM.
11009 (Qmetadata): New var.
11010 * data.c (Qbuffer): Don't make it static.
11011 (syms_of_data): Use DEFSYM.
11012
e003a292
PE
110132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11014
11015 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11016 (CCL_CODE_MIN): New macro.
11017
ed008a6d
PE
110182011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11019
3687c2ef
PE
11020 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11021
ed008a6d
PE
11022 * eval.c (Qdebug): Now static.
11023 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11024 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11025 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11026
d66c4c7c
CY
110272011-05-29 Chong Yidong <cyd@stupidchicken.com>
11028
11029 * image.c: Various fixes to ImageMagick code comments.
11030 (Fimagemagick_types): Doc fix.
11031
5fbc2025
PE
110322011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11033
0196f88a
PE
11034 Minor fixes prompted by GCC 4.6.0 warnings.
11035
11036 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11037
5fbc2025
PE
11038 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11039 (x_clipboard_manager_save_all): Move extern decl to ...
11040 * xterm.h: ... here, so that it can be checked for consistency.
11041
1dd3c2d9
CY
110422011-05-29 Chong Yidong <cyd@stupidchicken.com>
11043
11044 * xselect.c (x_clipboard_manager_save_frame)
11045 (x_clipboard_manager_save_all): New functions.
11046 (Fx_clipboard_manager_save): Lisp function deleted.
11047
11048 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11049 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11050
11051 * xterm.h: Update prototype.
11052
5ba6571d
WX
110532011-05-28 William Xu <william.xwl@gmail.com>
11054
11055 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11056 exiting (Bug#8239).
11057
3eaff834
JM
110582011-05-28 Jim Meyering <meyering@redhat.com>
11059
e1900994 11060 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11061 * fns.c (to_uchar): Define.
11062 (crypto_hash_function): Use it to convert some newly-signed
11063 variables to unsigned, to avoid sign-extension bugs. For example,
11064 without this change, (md5 "truc") would evaluate to
11065 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11066 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11067 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11068
0f6990a7
PE
110692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11070
11071 Integer overflow fixes.
c8a9ca5a 11072
08686060
PE
11073 * dbusbind.c: Serial number integer overflow fixes.
11074 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11075 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11076 to hold a serial number that is too large for a fixnum.
11077 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11078 Check for serial numbers out of range. Decode any serial number
59568bf0 11079 that was so large that it became a float. (Bug#8722)
08686060 11080
2d1fc3c7
PE
11081 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11082 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11083 Use XFASTINT rather than XUINT when numbers are nonnegative.
11084 (xd_append_arg, Fdbus_method_return_internal):
11085 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11086 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11087 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11088 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11089 (Bug#8722)
2d1fc3c7 11090
c8a9ca5a
PE
11091 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11092
519e1d69
PE
11093 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11094
6df6ae42 11095 ccl: Add integer overflow checks.
30569699
PE
11096 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11097 (IN_INT_RANGE): New macros.
11098 (ccl_driver): Use them to check for integer overflow when
11099 decoding a CCL program. Many of the new checks are whether XINT (x)
11100 fits in int; it doesn't always, on 64-bit hosts. The new version
11101 doesn't catch all possible integer overflows, but it's an
847044ea 11102 improvement. (Bug#8719)
30569699 11103
c11285dc
PE
11104 * alloc.c (make_event_array): Use XINT, not XUINT.
11105 There's no need for unsigned here.
11106
fdccd48e
PE
11107 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11108 This follows up to the 2011-05-06 change that substituted uintptr_t
11109 for EMACS_INT. This case wasn't caught back then.
11110
37910ab2
PE
11111 Rework Fformat to avoid integer overflow issues.
11112 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11113 now (part of C89). Include <verify.h>.
11114 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11115 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11116 (Fformat): Avoid the prepass trying to compute sizes; it was only
11117 approximate and thus did not catch overflow reliably. Instead, walk
11118 through the format just once, formatting and computing sizes as we go,
11119 checking for integer overflow at every step, and allocating a larger
11120 buffer as needed. Keep track separately whether the format is
11121 multibyte. Keep only the most-recently calculated precision, rather
11122 than them all. Record whether each argument has been converted to
11123 string. Use EMACS_INT, not int, for byte and char and arg counts.
11124 Support field widths and precisions larger than INT_MAX. Avoid
11125 sprintf's undefined behavior with conversion specifications such as %#d
11126 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11127 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11128 formatting out-of-range floating point numbers with int
9173deec 11129 formats. (Bug#8668)
37910ab2 11130
2e6578fb
PE
11131 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11132
0ae6bdee
PE
11133 * data.c: Avoid integer truncation in expressions involving floats.
11134 * data.c: Include <intprops.h>.
11135 (arith_driver): When there's an integer overflow in an expression
11136 involving floating point, convert the integers to floating point
11137 so that the resulting value does not suffer from catastrophic
11138 integer truncation. For example, on a 64-bit host (* 4
11139 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11140 Do not rely on undefined behavior after integer overflow.
11141
de883a70
PE
11142 merge count_size_as_multibyte, parse_str_to_multibyte
11143 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11144 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11145 Check for integer overflow.
11146 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11147 since it's now a duplicate of the other. This is more of
11148 a character than a buffer op, so better that it's in character.c.
11149 * fns.c, print.c: Adjust to above changes.
11150
2ff916cb
PE
111512011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11152
11153 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11154
f1b54466
PE
111552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11156
fb1ac845
PE
11157 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11158 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11159 (x_clipboard_manager_save): Now static.
11160 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11161
f1b54466
PE
11162 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11163 (crypto_hash_function): Now static.
11164 Fix pointer signedness problems. Avoid unnecessary initializations.
11165
a9f737ee
CY
111662011-05-27 Chong Yidong <cyd@stupidchicken.com>
11167
11168 * termhooks.h (Vselection_alist): Make it terminal-local.
11169
11170 * terminal.c (create_terminal): Initialize it.
11171
11172 * xselect.c: Support for clipboard managers.
11173 (Vselection_alist): Move to termhooks.h as terminal-local var.
11174 (LOCAL_SELECTION): New macro.
11175 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11176 (symbol_to_x_atom): Remove gratuitous arg.
11177 (x_handle_selection_request, lisp_data_to_selection_data)
11178 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11179 (x_own_selection, x_get_local_selection, x_convert_selection):
11180 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11181 (some_frame_on_display): Delete unused function.
11182 (Fx_own_selection_internal, Fx_get_selection_internal)
11183 (Fx_disown_selection_internal, Fx_selection_owner_p)
11184 (Fx_selection_exists_p): New optional frame arg.
11185 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11186 (x_handle_selection_clear): Don't treat other terminals with the
11187 same keyboard specially. Use the terminal-local Vselection_alist.
11188 (x_clear_frame_selections): Use Frun_hook_with_args.
11189
11190 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11191
11192 * xterm.h: Add support for those atoms.
11193
e067f0c1
CY
111942011-05-26 Chong Yidong <cyd@stupidchicken.com>
11195
11196 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11197 (converted_selections, conversion_fail_tag): New global variables.
11198 (x_selection_request_lisp_error): Free the above.
11199 (x_get_local_selection): Remove unnecessary code.
11200 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11201 of converted selections stored in converted_selections.
11202 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11203 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11204 (x_convert_selection): New function.
11205 (x_handle_selection_event): Simplify.
11206 (x_get_foreign_selection): Don't ignore incoming requests while
11207 waiting for an answer; this will fail when we implement
11208 SAVE_TARGETS, and seems unnecessary anyway.
11209 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11210 (Vx_sent_selection_functions): Doc fix.
11211
0f4aebc0
LL
112122011-05-26 Leo Liu <sdl.web@gmail.com>
11213
11214 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11215
e61124cd
YM
112162011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11217
11218 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11219
11220 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11221 for fringe update if it has periodic bitmap.
ac389d0c 11222 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11223 and fringe_bitmap_periodic_p.
11224
11225 * fringe.c (get_fringe_bitmap_data): New function.
11226 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11227 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11228 row. Mark glyph row for fringe update if periodicity changed.
11229
11230 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11231 for fringe update unless it has periodic bitmap.
11232
f16d9837
KH
112332011-05-25 Kenichi Handa <handa@m17n.org>
11234
11235 * xdisp.c (get_next_display_element): Set correct it->face_id for
11236 a static composition.
11237
e1b90ef6
LL
112382011-05-24 Leo Liu <sdl.web@gmail.com>
11239
11240 * deps.mk (fns.o):
11241 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11242
11243 * fns.c (crypto_hash_function, Fsha1): New function.
11244 (Fmd5): Use crypto_hash_function.
11245 (syms_of_fns): Add Ssha1.
11246
7400048f
PE
112472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11248
11249 * gnutls.c: Remove unused macros.
11250 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11251 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11252 Remove macros that are defined and never used.
11253 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11254
abb71cf4
CY
112552011-05-22 Chong Yidong <cyd@stupidchicken.com>
11256
11257 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11258 (Fx_get_selection_internal): Minor cleanup.
11259 (Fx_own_selection_internal): Rename arguments for consistency with
11260 select.el.
11261
6307db39
PE
112622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11263
11264 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11265
f3d4e0a4
CY
112662011-05-22 Chong Yidong <cyd@stupidchicken.com>
11267
11268 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11269
4d8ade89
YM
112702011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11271
11272 * dispnew.c (scrolling_window): Don't exclude the case that the
11273 last enabled row in the desired matrix touches the bottom boundary.
11274
32078c8d
GM
112752011-05-21 Glenn Morris <rgm@gnu.org>
11276
11277 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11278 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11279 and add some more files.
32078c8d 11280
7285dc67
EZ
112812011-05-20 Eli Zaretskii <eliz@gnu.org>
11282
11283 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11284 report_file_error introduced by the change from 2011-05-07.
11285
89d1bd22
PE
112862011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11287
11288 * systime.h (Time): Define only if emacs is defined.
11289 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11290 where the include path doesn't have X11/X.h by default. See
11291 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11292
cd394be1 112932011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11294
11295 * composite.c (find_automatic_composition): Fix previous change.
11296
b9704ad9
GM
112972011-05-20 Glenn Morris <rgm@gnu.org>
11298
11299 * lisp.mk: New file, split from Makefile.in.
11300 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11301 (shortlisp): Remove.
11302 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11303
4a720484
GM
113042011-05-19 Glenn Morris <rgm@gnu.org>
11305
11306 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11307 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11308 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11309 (lisp): Set the order to that of loadup.el.
11310 (shortlisp): Make it a copy of $lisp.
11311 (SOME_MACHINE_LISP): Remove.
11312 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11313 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11314
a28d4396
KH
113152011-05-18 Kenichi Handa <handa@m17n.org>
11316
11317 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11318 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11319 (find_automatic_composition): Mostly rewrite for efficiency.
11320
a2b1fa8e
JB
113212011-05-18 Juanma Barranquero <lekktu@gmail.com>
11322
11323 * makefile.w32-in: Update dependencies.
11324
8e1f5610
CS
113252011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11326
11327 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11328 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11329
7025ee00 113302011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11331
cdfa6eab
PE
11332 Fix some integer overflow issues, such as string length overflow.
11333
06d6db33
PE
11334 * insdel.c (count_size_as_multibyte): Check for string overflow.
11335
2b4560a8
PE
11336 * character.c (lisp_string_width): Check for string overflow.
11337 Use EMACS_INT, not int, for string indexes and lengths; in
11338 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11339 the resulting string length overflows an EMACS_INT; instead,
11340 report a string overflow if no precision given. When checking for
11341 precision exhaustion, use a check that cannot possibly have
11342 integer overflow. (Bug#8675)
11343 * character.h (lisp_string_width): Adjust to new signature.
11344
cb93f9be
PE
11345 * alloc.c (string_overflow): New function.
11346 (Fmake_string): Use it. This doesn't change behavior, but saves
11347 a few bytes and will simplify future changes.
11348 * character.c (string_escape_byte8): Likewise.
11349 * lisp.h (string_overflow): New decl.
11350
1a1f3366
PE
11351 Fixups, following up to the user-interface timestamp change.
11352 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11353 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11354 * msdos.c (mouse_get_pos): Likewise.
11355 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11356 * w32gui.h (Time): Define by including "systime.h" rather than by
11357 declaring it ourselves. (Bug#8664)
11358
d4e3e4d3
PE
11359 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11360 * image.c (clear_image_cache): Likewise.
11361
f6a24d19
PE
11362 * term.c (term_mouse_position): Don't assume time_t wraparound.
11363
08dc5ae6
PE
11364 Be more systematic about user-interface timestamps.
11365 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11366 and sometimes 'EMACS_UINT', to represent these timestamps.
11367 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11368 This makes the code easier to follow, and makes it easier to catch
11369 integer overflow bugs such as Bug#8664.
11370 * frame.c (Fmouse_position, Fmouse_pixel_position):
11371 Use Time, not unsigned long, for user-interface timestamps.
11372 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11373 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11374 * keyboard.h (last_event_timestamp): Likewise.
11375 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11376 * menu.h (xmenu_show): Likewise.
11377 * term.c (term_mouse_position): Likewise.
11378 * termhooks.h (struct input_event.timestamp): Likewise.
11379 (struct terminal.mouse_position_hook): Likewise.
11380 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11381 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11382 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11383 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11384 what it was before.
11385 * menu.h, termhooks.h: Include "systime.h", for Time.
11386
8e55734a
PE
11387 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11388 Don't assume that the difference between two unsigned long values
11389 can fit into an integer. At this point, we know button_down_time
11390 <= event->timestamp, so the difference must be nonnegative, so
11391 there's no need to cast the result if double-click-time is
11392 nonnegative, as it should be; check that it's nonnegative, just in
11393 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11394 apart (about 25 days). (Bug#8664)
8e55734a 11395
841f1b75 11396 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11397 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11398
3e26f69c
PE
11399 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11400 that always fit in int. Use a sentinel instead of a counter, to
11401 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11402 * frame.h (struct frame): Use int for menu_bar_items_used
11403 instead of EMACS_INT, since it always fits in int.
3e26f69c 11404
5cc152c0
PE
11405 * menu.c (grow_menu_items): Check for int overflow.
11406
d89eb65e
PE
11407 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11408
5235bd3e
PE
11409 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11410 Before, the code was not consistent. These values cannot exceed
11411 2**31 - 1 so there's no need to make them unsigned.
11412 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11413 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11414 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11415 as modifiers.
11416 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11417
bc827e23
PE
11418 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11419 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11420 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11421 presumably because the widths might not match.
11422
78eb494e
PE
11423 * window.c (size_window): Avoid needless test at loop start.
11424
04f2d78b
CB
114252011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11426
11427 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11428
d2fc7e3d 114292011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11430
11431 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11432
d2fc7e3d 114332011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11434
11435 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11436 `width' to `bar_area_x' and `bar_area_width', respectively.
11437 (x_scroll_run): Take account of fringe background extension.
11438
04f2d78b
CB
11439 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11440 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11441 `bar_area_width', respectively.
11442 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11443 background extension.
11444
79b70037
GM
114452011-05-10 Jim Meyering <meyering@redhat.com>
11446
11447 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11448
2f142cc5
JB
114492011-05-10 Juanma Barranquero <lekktu@gmail.com>
11450
11451 * image.c (Finit_image_library): Return t for built-in image types,
11452 like pbm and xbm. (Bug#8640)
11453
57679c86
AS
114542011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11455
11456 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11457
888c9e86
EZ
114582011-05-07 Eli Zaretskii <eliz@gnu.org>
11459
b0512a1d
EZ
11460 * w32console.c (Fset_screen_color): Doc fix.
11461 (Fget_screen_color): New function.
11462 (syms_of_ntterm): Defsubr it.
11463
7285dc67
EZ
11464 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11465 unlink the temporary file if Fcall_process didn't create it in the
11466 first place.
11467 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11468 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11469 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11470 cue to call_process_cleanup not to close that handle.
11471
4d3fcc8e
BK
114722011-05-07 Ben Key <bkey76@gmail.com>
11473
11474 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11475 one of two shell specific rules, either bootstrap-temacs-CMD or
11476 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11477 to the previous implementation of the bootstrap-temacs rule.
11478 The bootstrap-temacs-CMD rule is similar to the previous
11479 implementation of the bootstrap-temacs rule except that it
11480 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11481 variable.
11482
11483 These changes, along with some changes to nt/configure.bat,
11484 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11485 earlier fix to add support for --cflags and --ldflags options
11486 that include quotes so that it works whether make uses cmd or
11487 sh as the shell.
11488
b4289b64
MA
114892011-05-06 Michael Albinus <michael.albinus@gmx.de>
11490
11491 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11492 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11493 is a constant.
11494 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11495 a string. Handle both cases.
11496 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11497 (Fdbus_register_method): Use Qinvalid_function.
11498
af4c0e28
JB
114992011-05-06 Juanma Barranquero <lekktu@gmail.com>
11500
11501 * makefile.w32-in: Update dependencies.
11502 (LISP_H): Add inttypes.h and stdin.h.
11503 (PROCESS_H): Add unistd.h.
11504
c51453d9
EZ
115052011-05-06 Eli Zaretskii <eliz@gnu.org>
11506
11507 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11508 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11509
8ff0ac3c 115102011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11511
4c4b566b
PE
11512 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11513
aab2b9b5
PE
11514 * term.c (vfatal): Remove stray call to va_end.
11515 It's not needed and the C Standard doesn't allow it here anyway.
11516
c378da0b
PE
11517 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11518 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11519
288b08c7
PE
11520 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11521 bytes.
11522
e3601888
PE
11523 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11524
db6c0e74
PE
11525 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11526
dd5963ea
PE
11527 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11528
88c9450f
PE
11529 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11530
2f9442b8
PE
11531 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11532
c032b5f8
PE
11533 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11534 * charset.c (Fdefine_charset_internal): Don't initialize
11535 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11536 32-bit int (Bug#8600).
a108c10b
PE
11537
11538 * lread.c (read_integer): Be more consistent with string-to-number.
11539 Use string_to_number to do the actual conversion; this avoids
11540 rounding errors and fixes some other screwups. Without this fix,
11541 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11542 (digit_to_number): Move earlier, for benefit of read_integer.
11543 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11544 not a digit in any supported base. (Bug#8602)
a108c10b 11545
ad5f9eea
PE
11546 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11547
aec1708a
PE
11548 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11549 to match comment at start of function. This also removes a
11550 GCC warning about overflow in a 32+64-bit port.
11551
47be4ab5
PE
11552 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11553
371cac43
PE
11554 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11555 Reported by Stefan Monnier in
11556 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11557 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11558 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11559
d01a7826
PE
11560 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11561 (EMACS_UINTPTR): Likewise, with uintptr_t.
11562
7fd47d5c
PE
11563 * lisp.h: Prefer 64-bit EMACS_INT if available.
11564 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11565 on 32-bit hosts that have 64-bit int, so that they can access
11566 large files.
122b0c86
PE
11567 However, temporarily disable this change unless the temporary
11568 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11569
8727937b
PE
11570 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11571
8ac068ac
PE
11572 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11573 This removes an assumption that EMACS_INT and long are the same
11574 width as pointers. The assumption is true for Emacs porting targets
11575 now, but we want to make other targets possible.
11576 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11577 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11578 In the rest of the code, change types of integers that hold casted
11579 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11580 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11581 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11582 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11583 No need to cast type when ORing.
11584 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11585 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11586 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11587 assume EMACS_INT is the same width as char *.
11588 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11589 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11590 Remove no-longer-needed casts.
11591 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11592 (xg_tool_bar_help_callback, xg_make_tool_item):
11593 Use EMACS_INTPTR to hold an integer
11594 that will be cast to void *; this can avoid a GCC warning
11595 if EMACS_INT is not the same width as void *.
11596 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11597 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11598 (current_message_1, set_message_1):
11599 Use a local to convert to proper width without a cast.
11600 * xmenu.c (dialog_selection_callback): Likewise.
11601
ede49d71
PE
11602 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11603 Also, don't assume VALBITS / RAND_BITS is less than 5,
11604 and don't rely on undefined behavior when shifting a 1 left into
11605 the sign bit.
11606 * lisp.h (get_random): Change signature to match.
11607
2f30ecd0
PE
11608 * lread.c (hash_string): Use size_t, not int, for hash computation.
11609 Normally we prefer signed values; but hashing is special, because
11610 it's better to use unsigned division on hash table sizes so that
11611 the remainder is nonnegative. Also, size_t is the natural width
11612 for hashing into memory. The previous code used 'int', which doesn't
11613 retain enough info to hash well into very large tables.
11614 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11615
2a866e7b
PE
11616 * dbusbind.c: Don't possibly lose pointer info when converting.
11617 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11618 Use XPNTR rather than XHASH, so that the high-order bits of
11619 the pointer aren't lost when converting through void *.
11620
51639eac
PE
11621 * eval.c (Fautoload): Don't double-shift a pointer.
11622
92394119
PE
11623 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11624
dbdb9a7c
JB
116252011-05-06 Juanma Barranquero <lekktu@gmail.com>
11626
11627 * gnutls.c (DEF_GNUTLS_FN):
11628 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11629
db7a0b4f
AS
116302011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11631
11632 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11633 marker. (Bug#8610)
11634
cd394be1 116352011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11636
11637 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11638 New version that can reserve upto 2GB of heap space.
11639
f7ff1b0f 116402011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11641
11642 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11643
639c109b
TZ
116442011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11645
11646 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11647 `gnutls_certificate_set_x509_key_file'.
11648
d2127135
JB
116492011-05-05 Juanma Barranquero <lekktu@gmail.com>
11650
11651 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11652 Update dependencies.
11653
e968f4f3
JB
116542011-05-04 Juanma Barranquero <lekktu@gmail.com>
11655
11656 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11657 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11658 Remove unused parameter `fildes'.
11659 * process.c (read_process_output, send_process): Don't pass it.
11660
84d358f0
JB
116612011-05-04 Juanma Barranquero <lekktu@gmail.com>
11662
11663 Fix previous change: the library cache is defined in w32.c.
11664 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11665 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11666
0898ca10
JB
116672011-05-04 Juanma Barranquero <lekktu@gmail.com>
11668
11669 Implement dynamic loading of GnuTLS on Windows.
11670
11671 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11672 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11673 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11674 Declare.
11675
11676 * gnutls.c (Qgnutls_dll): Define.
11677 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11678 (gnutls_*): Declare function pointers.
11679 (init_gnutls_functions): New function to initialize function pointers.
11680 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11681 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11682 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11683 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11684 (emacs_gnutls_write, emacs_gnutls_read)
11685 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11686 (Fgnutls_available_p): New function.
11687 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11688 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11689 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11690
11691 * image.c: Include w32.h.
11692 (Vimage_type_cache): Delete.
11693 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11694 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11695 (w32_delayed_load): Move to w32.c.
11696
11697 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11698
11699 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11700 (w32_delayed_load): Move from image.c. When loading a library, record
11701 its filename in the :loaded-from property of the library id.
11702 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11703 Initialize and staticpro them.
11704 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11705
11706 * process.c: Include lisp.h before w32.h, not after.
11707 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11708 instead of gnutls_record_check_pending.
11709
11710 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11711
ff4de4aa
TZ
117122011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11713
11714 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11715 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11716 as passed in.
11717
abe95abb
JD
117182011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11719
11720 * xterm.c (x_set_frame_alpha): Do not set property on anything
11721 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11722
e16e55d4
JB
117232011-05-02 Juanma Barranquero <lekktu@gmail.com>
11724
11725 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11726
bafcf6a5
JB
117272011-05-02 Juanma Barranquero <lekktu@gmail.com>
11728
11729 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11730 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11731 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11732 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11733 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11734 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11735 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11736 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11737 (Qgnutls_bootprop_callbacks_verify): Make static.
11738
e7a6747f
AS
117392011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11740
19ed11ba
AS
11741 * callproc.c: Indentation fixup.
11742
e7a6747f 11743 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11744 (wait_for_termination, interruptible_wait_for_termination):
11745 Move after wait_for_termination_1.
e7a6747f 11746
1ef14cb4
LMI
117472011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11748
11749 * sysdep.c (interruptible_wait_for_termination): New function
11750 which is like wait_for_termination, but allows keyboard
11751 interruptions.
11752
11753 * callproc.c (Fcall_process): Add (:file "file") as an option for
11754 the STDOUT buffer.
11755 (Fcall_process_region): Ditto.
11756
330d880c
EZ
117572011-04-30 Eli Zaretskii <eliz@gnu.org>
11758
8db90b73
EZ
11759 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11760 rather than `XVECTOR (FOO)->size'.
11761
330d880c
EZ
11762 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11763 inttypes.h, as a gnulib replacement is used if it not available in
11764 system headers.
11765
15cbd324
EZ
117662011-04-21 Eli Zaretskii <eliz@gnu.org>
11767
11768 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11769 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11770 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11771
11772 * coding.c (coding_alloc_by_realloc): Error out if destination
11773 will grow beyond MOST_POSITIVE_FIXNUM.
11774 (decode_coding_emacs_mule): Abort if there isn't enough place in
11775 charbuf for the composition carryover bytes. Reserve an extra
11776 space for up to 2 characters produced in a loop.
11777 (decode_coding_iso_2022): Abort if there isn't enough place in
11778 charbuf for the composition carryover bytes.
11779
117802011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11781
ae940cca
EZ
11782 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11783 aborting when %lld or %lll format is passed.
11784 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11785 %llo or %llx format is passed. (Bug#8545)
11786
03ab8921
EZ
11787 * window.c (window_scroll_line_based): Use a marker instead of
11788 simple variables to record original value of point. (Bug#7952)
11789
afda1437
EZ
11790 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11791 produced by %s or %c overflows available buffer space. (Bug#8545)
11792
f76dee0c
PE
117932011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11794
11795 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11796 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11797
fdc5744d
JB
117982011-04-28 Juanma Barranquero <lekktu@gmail.com>
11799
11800 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11801
638f053a
JB
118022011-04-28 Juanma Barranquero <lekktu@gmail.com>
11803
11804 * keyboard.c (Qdelayed_warnings_hook): Define.
11805 (command_loop_1): Run `delayed-warnings-hook'
11806 if Vdelayed_warnings_list is non-nil.
11807 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11808 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11809
d178f871
EZ
118102011-04-28 Eli Zaretskii <eliz@gnu.org>
11811
11812 * doprnt.c (doprnt): Don't return value smaller than the buffer
11813 size if the message was truncated. (Bug#8545).
11814
b124fd93
JB
118152011-04-28 Juanma Barranquero <lekktu@gmail.com>
11816
11817 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11818 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11819
e810457d
PE
118202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11821
11822 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11823
ea51cceb
JB
118242011-04-27 Juanma Barranquero <lekktu@gmail.com>
11825
11826 * makefile.w32-in: Update dependencies.
11827
94dcfacf
EZ
118282011-04-27 Eli Zaretskii <eliz@gnu.org>
11829
11830 Improve `doprnt' and its usage. (Bug#8545)
11831 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11832 `format_end'. Remove support for %l as a conversion specifier.
11833 Don't use xrealloc. Improve diagnostics when the %l size modifier
11834 is used. Update the commentary.
11835
11836 * eval.c (verror): Simplify calculation of size_t.
11837
11838 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11839 messages.
11840
f61f41d7
PE
118412011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11842
11843 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11844 change.
11845
96fb4434
PE
118462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11847
11848 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11849 This makes this file independent of the recent pseudovector change.
11850
671875da 118512011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11852
69e9b5a3
PE
11853 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11854
b5f869a7 11855 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11856 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11857 Remove unused local.
c8926152 11858 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11859
841a1577 11860 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11861 GCC 4.6.0 optimizes based on type-based alias analysis.
11862 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11863 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11864 != &v->size, and therefore "v->size = 1; b->size = 2; return
11865 v->size;" must therefore return 1. This assumption is incorrect
11866 for Emacs, since it type-puns struct Lisp_Vector * with many other
11867 types. To fix this problem, this patch adds a new type struct
f904488f 11868 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11869 and pseudovectors, and helps optimizing compilers not get fooled
11870 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11871 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11872 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11873 the size member.
eab3844f
PE
11874 (XSETPVECTYPE): Rewrite in terms of new macro.
11875 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11876 This is a bit clearer, and further avoids the possibility of
11877 undesirable aliasing.
11878 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11879 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11880 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11881 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11882 (ASIZE): Now uses header.size rather than size.
11883 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11884 to avoid the hassle of writing XVECTOR (foo)->header.size.
11885 (struct vectorlike_header): New type.
eab3844f
PE
11886 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11887 object, to help avoid aliasing.
11888 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11889 (SUBRP): Likewise, since Lisp_Subr is a special case.
11890 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11891 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11892 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11893 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11894 changed to be "header.size" and "header.next".
11895 * buffer.h (struct buffer): Likewise.
11896 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11897 * frame.h (struct frame): Likewise.
11898 * process.h (struct Lisp_Process): Likewise.
11899 * termhooks.h (struct terminal): Likewise.
11900 * window.c (struct save_window_data, struct saved_window): Likewise.
11901 * window.h (struct window): Likewise.
11902 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11903 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11904 * buffer.c (init_buffer_once): Likewise.
11905 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11906 special case.
11907 * process.c (Fformat_network_address): Use local var for size,
11908 for brevity.
11909
0df1eac5
PE
11910 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11911
847ab9d1 11912 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11913 * data.c (atof): Remove decl; no longer used or needed.
11914 (digit_to_number): Move to lread.c.
11915 (Fstring_to_number): Use new string_to_number function, to be
11916 consistent with how the Lisp reader treats infinities and NaNs.
11917 Do not assume that floating-point numbers represent EMACS_INT
11918 without losing information; this is not true on most 64-bit hosts.
11919 Avoid double-rounding errors, by insisting on integers when
11920 parsing non-base-10 numbers, as the documentation specifies.
11921 * lisp.h (string_to_number): New decl, replacing ...
11922 (isfloat_string): Remove.
bc0a5c13 11923 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11924 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11925 appears to have been a coding error. Similarly, do not accept
11926 strings like +-1e0 as floating point numbers. Do not report
11927 overflow for integer overflows unless the base is not 10 which
11928 means we have no simple and reliable way to continue.
11929 Break out the floating-point parsing into a new
11930 function string_to_number, so that Fstring_to_number parses
11931 floating point numbers consistently with the Lisp reader.
04f2d78b 11932 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11933 (E_CHAR, EXP_INT): Remove, replacing with ...
11934 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11935 (string_to_number): New function, replacing isfloat_string.
11936 This function checks for valid syntax and produces the resulting
11937 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11938 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11939 so that overflow for non-base-10 numbers is reported only when
11940 there's no portable and simple way to convert to floating point.
452f4150 11941
67769ffc
PE
11942 * textprop.c (set_text_properties_1): Rewrite for clarity,
11943 and to avoid GCC warning about integer overflow.
11944
c20db43f
PE
11945 * intervals.h (struct interval): Use EMACS_INT for members
11946 where EMACS_UINT might cause problems. See
11947 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11948 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11949 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11950 All uses changed.
37aa2f85
PE
11951 (offset_intervals): Tell GCC not to worry about length overflow
11952 when negating a negative length.
c20db43f 11953
2538aa2f
PE
11954 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11955 (overrun_check_free): Likewise.
11956
f2d3008d
PE
11957 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11958 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11959 word size.
11960
ec8df744
PE
11961 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11962 (gnutls_make_error): Rename local to avoid shadowing.
11963 (gnutls_emacs_global_deinit): ifdef out; not used.
11964 (Fgnutls_boot): Use const for pointer to readonly storage.
11965 Comment out unused local. Fix pointer signedness problems.
11966
640ee02d
PE
11967 * lread.c (openp): Don't stuff size_t into an 'int'.
11968 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11969 about possible signed overflow.
11970
6048fb2a
PE
11971 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11972 (GDK_KEY_g): Don't define if already defined.
11973 (xg_prepare_tooltip): Avoid pointer signedness problem.
11974 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11975
fa3c87e1
PE
11976 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11977 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11978
2172544b
PE
11979 * xfns.c (Fx_window_property): Simplify a bit,
11980 to make a bit faster and to avoid GCC 4.6.0 warning.
11981 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11982
9b821a21
PE
11983 * fns.c (internal_equal): Don't assume size_t fits in int.
11984
3c616cfa
PE
11985 * alloc.c (compact_small_strings): Tighten assertion a little.
11986
c2982e87
PE
11987 Replace pEd with more-general pI, and fix some printf arg casts.
11988 * lisp.h (pI): New macro, generalizing old pEd macro to other
11989 conversion specifiers. For example, use "...%"pI"d..." rather
11990 than "...%"pEd"...".
11991 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11992 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11993 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11994 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11995 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11996 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11997 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11998 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11999 64-bit hosts.
12000 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12001 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12002 * print.c (safe_debug_print, print_object): Likewise.
12003 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12004 to int.
6f04d126
PE
12005 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12006 avoiding the 0 flag, which is not portable.
c2982e87
PE
12007 * process.c (Fmake_network_process): Use pI to avoid cast.
12008 * region-cache.c (pp_cache): Likewise.
12009 * xdisp.c (decode_mode_spec): Likewise.
12010 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12011 behavior on 64-bit hosts with printf arg.
6f04d126 12012 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12013 (x_stop_queuing_selection_requests): Likewise.
12014 (x_get_window_property): Don't truncate byte count to an 'int'
12015 when tracing.
0b432f21 12016
5e073ec7
PE
12017 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12018 here, since it parses constructs like leading '-' and spaces,
12019 which are not wanted; and it overflows with large numbers.
12020 Instead, simply match F[0-9]+, which is what is wanted anyway.
12021
36372bf9
PE
12022 * alloc.c: Remove unportable assumptions about struct layout.
12023 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12024 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12025 (allocate_vectorlike, make_pure_vector): Use the new macros,
12026 plus offsetof, to remove unportable assumptions about struct layout.
12027 These assumptions hold on all porting targets that I know of, but
12028 they are not guaranteed, they're easy to remove, and removing them
12029 makes further changes easier.
12030
0b432f21
PE
12031 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12032 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12033 (string_overrun_cookie): Now const. Use initializers that
12034 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12035 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12036 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12037 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12038 multiple of sizeof (EMACS_INT); it need not be, if
12039 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12040 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12041
895009e1
JB
120422011-04-26 Juanma Barranquero <lekktu@gmail.com>
12043
12044 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12045
6a7a1b0b
TZ
120462011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12047
12048 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12049 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12050 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12051
841a1577 120522011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12053
12054 * lisp.h (Qdebug): List symbol.
895009e1 12055 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12056 * keyboard.c (debug-on-event): New variable.
12057 (handle_user_signal): Break into debugger when debug-on-event
12058 matches the current signal symbol.
12059
f2d3ba6f
DN
120602011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12061
12062 * alloc.c (check_sblock, check_string_bytes)
12063 (check_string_free_list): Convert to standard C.
12064
42ce4c63
TZ
120652011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12066
12067 * w32.c (emacs_gnutls_push): Fix typo.
12068
825cd63c
EZ
120692011-04-25 Eli Zaretskii <eliz@gnu.org>
12070
fb11d64d
EZ
12071 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12072 "cast to pointer from integer of different size".
12073
825cd63c
EZ
12074 Improve doprnt and its use in verror. (Bug#8545)
12075 * doprnt.c (doprnt): Document the set of format control sequences
12076 supported by the function. Use SAFE_ALLOCA instead of always
12077 using `alloca'.
12078
12079 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12080 is one byte too soon. Don't use xrealloc; instead xfree and
12081 xmalloc anew.
12082
e061a11b
TZ
120832011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12084
12085 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12086 callbacks stage.
12087
12088 * gnutls.c: Renamed global_initialized to
12089 gnutls_global_initialized. Added internals for the
12090 :verify-hostname-error, :verify-error, and :verify-flags
12091 parameters of `gnutls-boot' and documented those parameters in the
12092 docstring. Start callback support.
9173deec
JB
12093 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12094 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12095 on error. Return error code.
e061a11b
TZ
12096 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12097 (emacs_gnutls_read): Likewise.
12098 (Fgnutls_boot): Return handshake error code.
12099 (emacs_gnutls_handle_error): New function.
12100 (wsaerror_to_errno): Likewise.
12101
12102 * w32.h (emacs_gnutls_pull): Add prototype.
12103 (emacs_gnutls_push): Likewise.
12104
12105 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12106 (emacs_gnutls_push): Likewise.
12107
121082011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12109
12110 * process.c (wait_reading_process_output): Check if GnuTLS
12111 buffered some data internally if no FDs are set for TLS
12112 connections.
12113
12114 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12115 (LIBS): Link to USER_LIBS.
12116 ($(BLD)/gnutls.$(0)): New target.
12117
fa6996bc
EZ
121182011-04-24 Eli Zaretskii <eliz@gnu.org>
12119
eb35682e
EZ
12120 * xdisp.c (handle_single_display_spec): Rename the
12121 display_replaced_before_p argument into display_replaced_p, to
12122 make it consistent with the commentary. Fix typos in the
12123 commentary.
12124
e2ad650c
EZ
12125 * textprop.c (syms_of_textprop): Remove dead code.
12126 (copy_text_properties): Delete obsolete commentary about an
12127 interface that was deleted long ago. Fix typos in the description
12128 of arguments.
12129
1b2de274
EZ
12130 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12131 to changes in oldXMenu/XMenu.h from 2011-04-16.
12132 <menu_help_message, prev_menu_help_message>: Constify.
12133 (IT_menu_make_room): menu->help_text is now `const char **';
12134 adjust.
12135
12136 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12137 to changes in oldXMenu/XMenu.h from 2011-04-16.
12138 (struct XMenu): Declare `help_text' `const char **'.
12139
12140 * xfaces.c <Qunspecified>: Make extern again.
12141
12142 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12143 required by POSIX.
1b2de274 12144
762b15be
EZ
12145 * doc.c (get_doc_string): Improve the format passed to `error'.
12146
12147 * doprnt.c (doprnt): Improve commentary.
12148
12149 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12150
12151 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12152 them with etags.
12153
f1052e5d
EZ
12154 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12155 changes in globals.h immediately force recompilation.
762b15be
EZ
12156 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12157 $(CURDIR)/s/ms-w32.h.
12158 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12159
fa6996bc
EZ
12160 * character.c (Fchar_direction): Function deleted.
12161 (syms_of_character): Don't defsubr it.
12162 <char-direction-table>: Deleted.
12163
e6c3da20
EZ
121642011-04-23 Eli Zaretskii <eliz@gnu.org>
12165
12166 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12167 * doprnt.c: Include limits.h.
12168 (SIZE_MAX): New macro.
04f2d78b
CB
12169 (doprnt): Return a size_t value. 2nd arg is now size_t.
12170 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12171 Improve overflow protection. Support `l' modifier for integer
12172 conversions. Support %l conversion. Don't assume an EMACS_INT
12173 argument for integer conversions and for %c.
12174
12175 * lisp.h (doprnt): Restore prototype.
12176
12177 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12178 $(SRC)/character.h.
12179
12180 * Makefile.in (base_obj): Add back doprnt.o.
12181
12182 * deps.mk (doprnt.o): Add back prerequisites.
12183 (callint.o): Depend on character.h.
12184
12185 * eval.c (internal_lisp_condition_case): Include the handler
12186 representation in the error message.
12187 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12188 when breaking from the loop.
12189
12190 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12191
12192 * callint.c (Fcall_interactively): When displaying error message
12193 about invalid control letter, pass the character's codepoint, not
12194 a pointer to its multibyte form. Improve display of the character
12195 in octal and display also its hex code.
12196
12197 * character.c (char_string): Use %x to display the (unsigned)
12198 codepoint of an invalid character, to avoid displaying a bogus
12199 negative value.
12200
12201 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12202 `error', not SYMBOL_NAME itself.
12203
12204 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12205 character arguments to `error'.
12206
12207 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12208 to `error' in error message about FINAL_CHAR argument. Make sure
12209 FINAL_CHAR is a character, and use %c when it is passed as
12210 argument to `error'.
12211
4ffd0d6b 122122011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12213
12214 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12215
12216 * w32.c: Include <time.h>.
12217 (sys_localtime): New function.
12218
4ffd0d6b 122192011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12220
12221 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12222
4ffd0d6b 12223 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12224
4ffd0d6b 122252011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12226
4ffd0d6b
GM
12227 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12228 zombies (Bug#8467).
aac0c6e3 12229
04c56954
EZ
122302011-04-19 Eli Zaretskii <eliz@gnu.org>
12231
12232 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12233 gl_state.e_property when gl_state.object is Qt.
12234
12235 * insdel.c (make_gap_larger): Remove limitation of buffer size
12236 to <= INT_MAX.
12237
16a43933
CY
122382011-04-18 Chong Yidong <cyd@stupidchicken.com>
12239
12240 * xdisp.c (lookup_glyphless_char_display)
12241 (produce_glyphless_glyph): Handle cons cell entry in
12242 glyphless-char-display.
12243 (Vglyphless_char_display): Document it.
12244
12245 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12246 glyphless-char-display.
12247
4581706e
CY
122482011-04-17 Chong Yidong <cyd@stupidchicken.com>
12249
12250 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12251
12252 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12253
12254 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12255 definition for no-X builds.
12256
4887c6e2 122572011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12258
fd35b6f9
PE
12259 Static checks with GCC 4.6.0 and non-default toolkits.
12260
5c1ccb01
PE
12261 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12262
006c5daa
PE
12263 * process.c (keyboard_bit_set): Define only if SIGIO.
12264 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12265 (send_process): Repair possible setjmp clobbering.
12266
efc736d3
PE
12267 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12268
4e2fe2e6
PE
12269 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12270
f97334a2
PE
12271 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12272
4e75f29d
PE
12273 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12274 Define only if needed.
12275
90efadd1
PE
12276 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12277 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12278 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12279
3c647824
PE
12280 * dispextern.h (struct redisplay_interface): Rename param
12281 to avoid shadowing.
e264f262 12282 * termhooks.h (struct terminal): Likewise.
761383f4 12283 * xterm.c (xembed_send_message): Likewise.
3c647824 12284
b58c5c4a
PE
12285 * insdel.c (make_gap_smaller): Define only if
12286 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12287
cad59032
PE
12288 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12289 it.
12290
c339dc2e
PE
12291 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12292 so that we aren't warned about unused symbols.
12293
91a3e27b
PE
12294 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12295
399c71d3 12296 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12297
8ffc96f5
PE
12298 * xfns.c (x_real_positions): Mark locals as initialized.
12299
eef9bc79
PE
12300 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12301
098db9dd
PE
12302 * xterm.c: Fix problems found by static analysis with other toolkits.
12303 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12304 (x_dispatch_event): Declare static if USE_GTK, and
12305 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12306 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12307 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12308 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12309 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12310
eb18f6cc
PE
12311 * xmenu.c (menu_help_callback): Pointer type fixes.
12312 Use const pointers when pointing at readonly data. Avoid pointer
12313 signedness clashes.
12314 (FALSE): Remove unused macro.
12315 (update_frame_menubar): Remove unused decl.
12316
1fe72bf8
PE
12317 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12318
60d9e1db
PE
12319 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12320 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12321 (single_menu_item): Rename local to avoid shadowing.
12322
39261c26
PE
12323 * keyboard.c (make_lispy_event): Remove unused local var.
12324
018c5e19
PE
12325 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12326 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12327
63d2b86e
PE
12328 * bitmaps: Change bitmaps from unsigned char back to the X11
12329 compatible char. Avoid the old compiler warnings about
12330 out-of-range initializers by using, for example, '\xab' rather
12331 than 0xab.
12332
aefd87e1
PE
12333 * xgselect.c (xgselect_initialize): Check vs interface
12334 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12335
bf501fb9
PE
12336 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12337
e9829fdf
PE
12338 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12339 to read-only memory.
12340
1086c095
PE
12341 * fns.c (vector): Remove; this old hack is no longer needed.
12342
2baccd04 12343 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12344 Remove unused var.
dde42981 12345 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12346
72391843 12347 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12348
436c16df 12349 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12350 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12351 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12352
92bb796d 12353 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12354 (x_term_init): Remove local to avoid shadowing.
92bb796d 12355
764430a3 12356 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12357
12358 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12359 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12360
d1dfb56c
EZ
123612011-04-16 Eli Zaretskii <eliz@gnu.org>
12362
c4354cb4
EZ
12363 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12364
d1dfb56c
EZ
12365 Fix regex.c, syntax.c and friends for buffers > 2GB.
12366 * syntax.h (struct gl_state_s): Declare character position members
12367 EMACS_INT.
12368
12369 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12370
04f2d78b
CB
12371 * textprop.c (verify_interval_modification, interval_of):
12372 Declare arguments EMACS_INT.
d1dfb56c
EZ
12373
12374 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12375 EMACS_INT.
12376
12377 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12378
12379 * indent.c (Fvertical_motion): Local variable it_start is now
12380 EMACS_INT.
12381
12382 * regex.c (re_match, re_match_2, re_match_2_internal)
12383 (bcmp_translate, regcomp, regexec, print_double_string)
12384 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12385 (re_compile_pattern, re_exec): Declare arguments and local
12386 variables `size_t' and `ssize_t' and return values `regoff_t', as
12387 appropriate.
12388 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12389 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12390 <compile_stack_type>: `size' and `avail' are now `size_t'.
12391
12392 * regex.h <regoff_t>: Use ssize_t, not int.
12393 (re_search, re_search_2, re_match, re_match_2): Arguments that
12394 specify buffer/string position and length are now ssize_t and
12395 size_t. Return type is regoff_t.
12396
613052cd
BK
123972011-04-16 Ben Key <bkey76@gmail.com>
12398
12399 * nsfont.m: Fixed bugs in ns_get_family and
12400 ns_descriptor_to_entity that were caused by using free to
12401 deallocate memory blocks that were allocated by xmalloc (via
12402 xstrdup). This caused Emacs to crash when compiled with
12403 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12404 --enable-checking=xmallocoverrun). xfree is now used to
12405 deallocate these memory blocks.
12406
4170f62f 124072011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12408
71b41406
PE
12409 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12410
9587a89d
PE
12411 emacs_write: Accept and return EMACS_INT for sizes.
12412 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12413 et seq.
12414 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12415 Accept and return EMACS_INT.
12416 (emacs_gnutls_write): Return the number of bytes written on
12417 partial writes.
12418 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12419 (emacs_read, emacs_write): Remove check for negative size, as the
12420 Emacs source code has been audited now.
9587a89d
PE
12421 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12422 (emacs_read, emacs_write): Use it.
273a5f82
PE
12423 * process.c (send_process): Adjust to the new signatures of
12424 emacs_write and emacs_gnutls_write. Do not attempt to store
12425 a byte offset into an 'int'; it might overflow.
9587a89d 12426 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12427
3e047f51
PE
12428 * sound.c: Don't assume sizes fit in 'int'.
12429 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12430 Return EMACS_INT, not int.
3e047f51 12431 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12432 Accept EMACS_INT, not int.
12433 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12434 record read return values.
12435
cc39a9db
BK
124362011-04-15 Ben Key <bkey76@gmail.com>
12437
c9d0ec6d
JB
12438 * keyboard.c (Qundefined): Don't declare static since it is used
12439 in nsfns.m.
12440 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12441 static since they are used in nsfont.m.
cc39a9db 12442
6c60eb9f
SM
124432011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12444
12445 * process.c (Qprocessp): Don't declare static.
12446 * lisp.h (Qprocessp): Declare again.
12447
7990b61a
JB
124482011-04-15 Juanma Barranquero <lekktu@gmail.com>
12449
12450 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12451
5d4cb038
PE
124522011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12453
8bd7b830 12454 Improve C-level modularity by making more things 'static'.
cd64ea1d 12455
e3b27b31
PE
12456 Don't publish debugger-only interfaces to other modules.
12457 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12458 (verify_bytepos, count_markers): Move decls to the only modules
12459 that need them.
12460 * region-cache.h (pp_cache): Likewise.
12461 * window.h (check_all_windows): Likewise.
12462 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12463
5d4cb038
PE
12464 * sysdep.c (croak): Now static, if
12465 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12466 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12467
12468 * alloc.c (refill_memory_reserve): Now static if
12469 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12470 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12471
e87b6180
PE
12472 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12473 Define only if USE_LUCID.
12474
ac64929e
PE
12475 * xrdb.c (x_customization_string, x_rm_string): Now static.
12476
6f37259d
PE
12477 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12478 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12479
1683e3ab
PE
12480 * xdisp.c (draw_row_with_mouse_face): Now static.
12481 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12482
de9c2632
PE
12483 * window.h (check_all_windows): Mark externally visible.
12484
2b96acb7
PE
12485 * window.c (window_deletion_count): Now static.
12486
12487 * undo.c: Make symbols static if they're not exported.
12488 (last_undo_buffer, last_boundary_position, pending_boundary):
12489 Now static.
12490
50436f33
PE
12491 * textprop.c (interval_insert_behind_hooks): Now static.
12492 (interval_insert_in_front_hooks): Likewise.
12493
64520e5c
PE
12494 * term.c: Make symbols static if they're not exported.
12495 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12496 (max_frame_lines, tty_set_terminal_modes):
12497 (tty_reset_terminal_modes, tty_turn_off_highlight):
12498 (get_tty_terminal): Now static.
12499 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12500 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12501 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12502 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12503 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12504
1fa53021
PE
12505 * sysdep.c: Make symbols static if they're not exported.
12506 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12507 Now static.
12508 (sigprocmask_set, full_mask): Remove; unused.
12509 (wait_debugging): Mark as visible.
12510 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12511 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12512
d4b43b22
PE
12513 * syntax.c (syntax_temp): Define only if !__GNUC__.
12514
b7c513d0
PE
12515 * sound.c (current_sound_device, current_sound): Now static.
12516
989b29ad
PE
12517 * search.c (searchbufs, searchbuf_head): Now static.
12518
13a55a78
PE
12519 * scroll.c (scroll_cost): Remove; unused.
12520 * dispextern.h (scroll_cost): Remove decl.
12521
de68a1fc
PE
12522 * region-cache.h (pp_cache): Mark as externally visible.
12523
40ccffa6
PE
12524 * process.c: Make symbols static if they're not exported.
12525 (process_tick, update_tick, create_process, chan_process):
12526 (Vprocess_alist, proc_buffered_char, datagram_access):
12527 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12528 (deactivate_process): Mark defn as static, as well as decl.
12529 * lisp.h (create_process): Remove decl.
12530 * process.h (chan_process, Vprocess_alist): Remove decls.
12531
ad64fc97
PE
12532 * print.c: Make symbols static if they're not exported.
12533 (print_depth, new_backquote_output, being_printed, print_buffer):
12534 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12535 (print_interval, print_number_index, initial_stderr_stream):
12536 Now static.
12537 * lisp.h (Fprinc): Remove decl.
12538 (debug_output_compilation_hack): Mark as externally visible.
12539
adddb265
PE
12540 * sysdep.c (croak): Move decl from here to syssignal.h.
12541 * syssignal.h (croak): Put it here, so the API can be checked when
12542 'croak' is called from dissociate_if_controlling_tty.
12543
1717ede2
PE
12544 * minibuf.c: Make symbols static if they're not exported.
12545 (minibuf_save_list, choose_minibuf_frame): Now static.
12546 * lisp.h (choose_minibuf_frame): Remove decl.
12547
fa5fb2bc
PE
12548 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12549
1e3890d1
PE
12550 * lread.c: Make symbols static if they're not exported.
12551 (read_objects, initial_obarray, oblookup_last_bucket_number):
12552 Now static.
12553 (make_symbol): Remove; unused.
12554 * lisp.h (initial_obarray, make_symbol): Remove decls.
12555
8a1414fa
PE
12556 * keyboard.c: Make symbols static if they're not exported.
12557 (single_kboard, recent_keys_index, total_keys, recent_keys):
12558 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12559 (this_single_command_key_start, echoing, last_auto_save):
12560 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12561 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12562 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12563 (Vlispy_mouse_stem, double_click_count):
12564 Now static.
12565 (force_auto_save_soon): Define only if SIGDANGER.
12566 (ignore_mouse_drag_p): Now static if
12567 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12568 (print_help): Remove; unused.
12569 (stop_character, last_timer_event): Mark as externally visible.
12570 * keyboard.h (ignore_mouse_drag_p): Declare only if
12571 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12572 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12573 * lisp.h (echoing): Remove decl.
12574 (force_auto_save_soon): Declare only if SIGDANGER.
12575 * xdisp.c (redisplay_window): Simplify code, to make it more
12576 obvious that ignore_mouse_drag_p is not accessed if !defined
12577 USE_GTK && !defined HAVE_NS.
12578
93ea6e8f
PE
12579 * intervals.c: Make symbols static if they're not exported.
12580 (merge_properties_sticky, merge_interval_right, delete_interval):
12581 Now static.
12582 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12583
77382fcc
PE
12584 * insdel.c: Make symbols static if they're not exported.
12585 However, leave prepare_to_modify_buffer alone. It's never
12586 called from outside this function, but that appears to be a bug.
12587 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12588 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12589 (adjust_after_replace_noundo): Remove; unused.
12590 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12591 (signal_before_change): Remove decls.
77382fcc 12592
9306c32e
PE
12593 * indent.c (val_compute_motion, val_vmotion): Now static.
12594
cd44d2eb
PE
12595 * image.c: Make symbols static if they're not exported.
12596 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12597 if USE_GTK.
12598 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12599 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12600
ad9a7a06
PE
12601 * fringe.c (standard_bitmaps): Now static.
12602 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12603
81626931
PE
12604 * frame.c: Make symbols static if they're not exported.
12605 (x_report_frame_params, make_terminal_frame): Now static.
12606 (get_frame_param): Now static, unless HAVE_NS.
12607 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12608 (x_get_resource_string): Remove; not used.
12609 * frame.h (make_terminal_frame, x_report_frame_params):
12610 (x_get_resource_string); Remove decls.
12611 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12612 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12613
239f9db9
PE
12614 * font.c, fontset.c: Make symbols static if they're not exported.
12615 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12616 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12617 * font.c (font_close_object): Now static.
12618 * font.h (font_close_object): Remove.
12619 * fontset.c (FONTSET_OBJLIST): Remove.
12620 (free_realized_fontset) #if-0 the body, which does nothing.
12621 (face_suitable_for_char_p): #if-0, as it's never called.
12622 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12623 * xfaces.c (face_at_string_position):
12624 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12625 since 0 is always ASCII.
12626
dfcf3579
PE
12627 * fns.c (weak_hash_tables): Now static.
12628
5045092b
PE
12629 * fileio.c: Make symbols static if they're not exported.
12630 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12631 (Vwrite_region_annotation_buffers): Now static.
12632
57a96f5c
PE
12633 * eval.c: Make symbols static if they're not exported.
12634 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12635 * lisp.h (backtrace_list): Remove decl.
12636
35f08c38
PE
12637 * emacs.c: Make symbols static if they're not exported.
12638 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12639 (fatal_error_code, fatal_error_signal_hook, standard_args):
12640 Now static.
12641 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12642 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12643 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12644 * lisp.h (fatal_error_signal_hook): Remove decl.
12645 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12646
f44bd759
PE
12647 * editfns.c: Move a (normally-unused) function to its only use.
12648 * editfns.c, lisp.h (get_operating_system_release): Remove.
12649 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12650 worth the hassle of breaking this out.
12651
b532497d
PE
12652 * xterm.c: Make symbols static if they're not exported.
12653 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12654 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12655 (x_destroy_window, x_delete_display):
12656 Now static.
12657 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12658 (x_mouse_leave): Remove; unused.
12659 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12660 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12661 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12662 Remove decls.
12663 (x_mouse_leave): Declare only if WINDOWSNT.
12664 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12665 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12666 USE_X_TOOLKIT.
12667
1675728f
PE
12668 * ftxfont.c: Make symbols static if they're not exported.
12669 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12670 HAVE_FREETYPE.
12671 * font.h (ftxfont_driver): Likewise.
12672
e4cebfca
PE
12673 * xfns.c: Make symbols static if they're not exported.
12674 (x_last_font_name, x_display_info_for_name):
12675 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12676 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12677 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12678 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12679 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12680 (last_show_tip_args): Now static.
12681 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12682 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12683 (x_screen_planes): Remove; unused.
12684 * dispextern.h (x_screen_planes): Remove decl.
12685
5bf46f05
PE
12686 * dispnew.c: Make symbols static if they're not exported.
12687 * dispextern.h (redraw_garbaged_frames, scrolling):
12688 (increment_row_positions): Remove.
12689 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12690 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12691 Now static.
12692 (redraw_garbaged_frames): Remove; unused.
12693
435f4c28
PE
12694 * xfaces.c: Make symbols static if they're not exported.
12695 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12696 Remove decls.
12697 * xterm.h (defined_color): Remove decls.
12698 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12699 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12700 (menu_face_changed_default, defined_color, free_realized_face):
12701 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12702 (ascii_face_of_lisp_face): Remove; unused.
12703
8524aef3
PE
12704 * xdisp.c: Make symbols static if they're not exported.
12705 * dispextern.h (scratch_glyph_row, window_box_edges):
12706 (glyph_to_pixel_coords, set_cursor_from_row):
12707 (get_next_display_element, set_iterator_to_next):
12708 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12709 (show_mouse_face): Remove decls
12710 * frame.h (message_buf_print): Likewise.
12711 * lisp.h (pop_message, set_message, check_point_in_composition):
12712 Likewise.
12713 * xterm.h (set_vertical_scroll_bar): Likewise.
12714 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12715 (message_buf_print, scratch_glyph_row, displayed_buffer):
12716 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12717 (get_next_display_element, show_mouse_face, window_box_edges):
12718 (frame_to_window_pixel_xy, check_point_in_composition):
12719 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12720 (glyph_to_pixel_coords): Remove; unused.
12721
16390cd2
PE
12722 * dired.c (file_name_completion): Now static.
12723
12724 * dbusbind.c (xd_in_read_queued_messages): Now static.
12725
a25f4dfa
PE
12726 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12727 * data.c (circular_list_error): Remove.
12728
14a9c8df
PE
12729 * commands.h (last_point_position, last_point_position_buffer):
12730 (last_point_position_window): Remove decls.
12731 * keyboard.c: Make these variables static.
12732
04f2d78b
CB
12733 * coding.h (coding, code_convert_region, encode_coding_gap):
12734 Remove decls.
74ab6df5
PE
12735 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12736 (iso_code_class, detect_coding, code_convert_region): Now static.
12737 (encode_coding_gap): Remove; unused.
12738
38dfbee1
PE
12739 * chartab.c (chartab_chars, chartab_bits): Now static.
12740
a2cb4e63
PE
12741 * charset.h (charset_iso_8859_1): Remove decl.
12742 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12743 Now static.
12744
127198fd
PE
12745 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12746 * ccl.c (Vccl_program_table): Now static.
12747 (check_ccl_update): Remove; unused.
12748
d85b608f
PE
12749 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12750 * category.h: ... from here.
12751 * category.c (check_category_table, set_category_set): Now static.
12752
31cd66f3
PE
12753 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12754 * lisp.h: Remove these decls.
12755
c358e587
PE
12756 * buffer.c (buffer_count): Remove unused var.
12757
e78aecca
PE
12758 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12759 so that it's not optimized away.
12760 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12761 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12762 exported only to the debugger.
12763
e192d7d3 12764 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12765 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12766
92470028
PE
12767 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12768 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12769 was inaccessible from Lisp.
12770 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12771 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12772
244ed907
PE
12773 alloc.c: Import and export fewer symbols, and remove unused items.
12774 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12775 is defined.
12776 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12777 it's not optimized away by whole-program optimization.
12778 (message_enable_multibyte, free_misc): Remove.
12779 (catchlist, handlerlist, mark_backtrace):
12780 Declare only if BYTE_MARK_STACK.
12781 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12782 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12783 (message_enable_multibyte): Remove decl.
12784 (free_misc, interval_free_list, float_block, float_block_index):
12785 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12786 (cons_free_list, last_marked_index):
12787 Now static.
12788 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12789 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12790 (mark_backtrace): Define only if BYTE_MARK_STACK.
12791 * xdisp.c (message_enable_multibyte): Now static.
12792
61c2b50e 12793 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12794 This makes it easier for human readers (and static analyzers)
12795 to see whether these variables are used from other modules.
12796 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12797 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12798 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12799 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12800 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12801 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12802 * xmenu.c, xselect.c:
12803 Declare Q* vars static if they are not used in other modules.
12804 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12805 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12806 Remove decls of unexported vars.
12807 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12808
95c82688
PE
12809 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12810
16a97296
PE
12811 Make Emacs functions such as Fatom 'static' by default.
12812 This makes it easier for human readers (and static analyzers)
12813 to see whether these functions can be called from other modules.
12814 DEFUN now defines a static function. To make the function external
12815 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12816 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12817 (Finit_image_library):
16a97296
PE
12818 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12819 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12820 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12821 Remove decls, since these functions are now static.
12822 (Funintern, Fget_internal_run_time): New decls, since these functions
12823 were already external.
95c82688 12824
16a97296
PE
12825 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12826 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12827 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12828 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12829 * keyboard.c, keymap.c, lread.c:
12830 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12831 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12832 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12833 Mark functions with DEFUE instead of DEFUN,
12834 if they are used in other modules.
12835 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12836 decls for now-static functions.
12837 * buffer.h (Fdelete_overlay): Remove decl.
12838 * callproc.c (Fgetenv_internal): Mark as internal.
12839 * composite.c (Fremove_list_of_text_properties): Remove decl.
12840 (Fcomposition_get_gstring): New forward static decl.
12841 * composite.h (Fcomposite_get_gstring): Remove decl.
12842 * dired.c (Ffile_attributes): New forward static decl.
12843 * doc.c (Fdocumntation_property): New forward static decl.
12844 * eval.c (Ffetch_bytecode): New forward static decl.
12845 (Funintern): Remove extern decl; now in .h file where it belongs.
12846 * fileio.c (Fmake_symbolic_link): New forward static decl.
12847 * image.c (Finit_image_library): New forward static decl.
12848 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12849 * intervals.h (Fprevious_property_change):
12850 (Fremove_list_of_text_properties): Remove decls.
12851 * keyboard.c (Fthis_command_keys): Remove decl.
12852 (Fcommand_execute): New forward static decl.
12853 * keymap.c (Flookup_key): New forward static decl.
12854 (Fcopy_keymap): Now static.
12855 * keymap.h (Flookup_key): Remove decl.
12856 * process.c (Fget_process): New forward static decl.
12857 (Fprocess_datagram_address): Mark as internal.
12858 * syntax.c (Fsyntax_table_p): New forward static decl.
12859 (skip_chars): Remove duplicate decl.
12860 * textprop.c (Fprevious_property_change): New forward static decl.
12861 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12862 Now internal.
12863 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12864 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12865
785bbd42
PE
12866 * editfns.c (Fformat): Remove unreachable code.
12867
8b913b57
AS
128682011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12869
12870 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12871 change. (Bug#8496)
12872
a6744a35
EZ
128732011-04-13 Eli Zaretskii <eliz@gnu.org>
12874
12875 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12876 when at ZV. (Bug#8487)
12877
e7974947
AS
128782011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12879
baad03f0
AS
12880 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12881 (Bug#8437)
12882 * keyboard.c (parse_tool_bar_item): Likewise.
12883 * sound.c (sound_cleanup, alsa_close): Likewise.
12884 * termcap.c (tgetent): Likewise.
12885 * xfns.c (x_default_font_parameter): Likewise.
12886 * xsettings.c (read_and_apply_settings): Likewise.
12887
e7974947
AS
12888 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12889 (overrun_check_free): Protoize.
12890
28272684
PE
128912011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12892
12893 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12894 since callers should never pass a negative size.
12895 Change the signature to match that of plain 'read' and 'write'; see
12896 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12897 * lisp.h: Update prototypes of emacs_write and emacs_read.
12898
11997c76
EZ
128992011-04-11 Eli Zaretskii <eliz@gnu.org>
12900
12901 * xdisp.c (redisplay_window): Don't try to determine the character
12902 position of the scroll margin if the window start point w->startp
e896f03c 12903 is outside the buffer's accessible region. (Bug#8468)
11997c76 12904
8a2cbd72
EZ
129052011-04-10 Eli Zaretskii <eliz@gnu.org>
12906
12907 Fix write-region and its subroutines for buffers > 2GB.
12908 * fileio.c (a_write, e_write): Modify declaration of arguments and
12909 local variables to support buffers larger than 2GB.
12910 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12911
12912 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12913 argument, local variables, and return value.
12914
12915 * lisp.h: Update prototypes of emacs_write and emacs_read.
12916
12917 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12918
4073e537 129192011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12920
1ebfdcb6
PE
12921 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12922
b2ded58d
PE
12923 Fix more problems found by GCC 4.6.0's static checks.
12924
7d66342c
PE
12925 * xdisp.c (vmessage): Use a better test for character truncation.
12926
bbf47d44
PE
12927 * charset.c (load_charset_map): <, not <=, for optimization,
12928 and to avoid potential problems with integer overflow.
9248994d 12929 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12930 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12931 * editfns.c (Fformat): Likewise.
1e69125e 12932 * syntax.c (skip_chars): Likewise.
3befa583 12933
e3019616
PE
12934 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12935 This also lets GCC 4.6.0 generate slightly better loop code.
12936
becfa255
PE
12937 * callint.c (Fcall_interactively): <, not <=, for optimization.
12938 (Fcall_interactively): Count the number of arguments produced,
12939 not the number of arguments given. This is simpler and lets GCC
12940 4.6.0 generate slightly better code.
12941
dae0cd48
PE
12942 * ftfont.c: Distingish more carefully between FcChar8 and char.
12943 The previous code passed unsigned char * to a functions like
12944 strlen and xstrcasecmp that expect char *, which does not
12945 conform to the C standard.
12946 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12947 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12948 char * when the C standard requires it.
12949
76032d70
PE
12950 * keyboard.c (read_char): Remove unused var.
12951
eb3f1cc8
PE
12952 * eval.c: Port to Windows vsnprintf (Bug#8435).
12953 Include <limits.h>.
12954 (SIZE_MAX): Define if the headers do not.
12955 (verror): Do not give up if vsnprintf returns a negative count.
12956 Instead, grow the buffer. This ports to Windows vsnprintf, which
12957 does not conform to C99. Problem reported by Eli Zaretskii.
12958 Also, simplify the allocation scheme, by avoiding the need for
12959 calling realloc, and removing the ALLOCATED variable.
12960
70476b54
PE
12961 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12962
12020a9e
PE
12963 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12964 But keep the doprint source code for now, as we might revamp it
12965 and use it again (Bug#8435).
ea6c7ae6
PE
12966 * lisp.h (doprnt): Remove.
12967 * Makefile.in (base_obj): Remove doprnt.o.
12968 * deps.mk (doprnt.o): Remove.
12969
5fdb398c
PE
12970 error: Print 32- and 64-bit integers portably (Bug#8435).
12971 Without this change, on typical 64-bit hosts error ("...%d...", N)
12972 was used to print both 32- and 64-bit integers N, which relied on
12973 undefined behavior.
61bdb816 12974 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12975 * lisp.h (error, verror): Mark as printf-like functions.
12976 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12977 Report overflow in size calculations when allocating printf buffer.
12978 Do not truncate output string at its first null byte.
12979 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12980 Truncate the output at a character boundary, since vsnprintf does not
12981 do that.
12982 * charset.c (check_iso_charset_parameter): Convert internal
12983 character to string before calling 'error', since %c now has the
12984 printf meaning.
12985 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12986 overflow when computing char to be passed to 'error'. Do not
12987 pass Lisp_Object to 'error'; pass the integer instead.
12988 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12989 formatted with plain %d.
12990
b189fa66
PE
12991 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12992
bff87ef0
PE
12993 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12994
7e2cac20
PE
12995 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12996
ce4d90b5
PE
12997 * xterm.c (x_catch_errors): Remove duplicate declaration.
12998
266c9547
PE
12999 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13000
79c49ad2
PE
13001 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13002
368f4090
JM
130032011-04-10 Jim Meyering <meyering@redhat.com>
13004
13005 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13006 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13007 return ssize_t not "int", and use size_t as the buffer length.
13008 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13009 * gnutls.h: Update declarations.
13010 * process.c (read_process_output): Use ssize_t, to match.
13011 (send_process): Likewise.
13012
a32d4040
CY
130132011-04-09 Chong Yidong <cyd@stupidchicken.com>
13014
13015 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13016
8546720e 130172011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13018
04f2d78b
CB
13019 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13020 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13021
8546720e
GM
13022 * xterm.c (handle_one_xevent):
13023 * xmenu.c (create_and_show_popup_menu):
13024 * xselect.c (x_decline_selection_request)
13025 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13026
0a2f5c1a 130272011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13028
13029 Fix some uses of `int' instead of EMACS_INT.
13030 * search.c (string_match_1, fast_string_match)
13031 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13032 (scan_buffer, find_next_newline_no_quit)
13033 (find_before_next_newline, search_command, Freplace_match)
13034 (Fmatch_data): Make some `int' variables be EMACS_INT.
13035
13036 * xdisp.c (display_count_lines): 3rd argument and return value now
13037 EMACS_INT. All callers changed.
13038 (pint2hrstr): Last argument is now EMACS_INT.
13039
13040 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13041 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13042 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13043 (decode_coding_utf_16, decode_coding_emacs_mule)
13044 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13045 (decode_coding_ccl, decode_coding_charset)
13046 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13047 (decode_coding_iso_2022, decode_coding_emacs_mule)
13048 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13049 <char_offset, last_offset>: Declare EMACS_INT.
13050 (encode_coding_utf_8, encode_coding_utf_16)
13051 (encode_coding_emacs_mule, encode_invocation_designation)
13052 (encode_designation_at_bol, encode_coding_iso_2022)
13053 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13054 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13055 Declare EMACS_INT.
13056 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13057 (encode_invocation_designation): Last argument P_NCHARS is now
13058 EMACS_INT.
13059 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13060 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13061
13062 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13063 All users changed.
13064
13065 * ccl.c (Fccl_execute_on_string): Declare some variables
13066 EMACS_INT.
13067
8546720e 130682011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13069
13070 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13071
4e19a977
CS
130722011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13073
13074 * process.c (Fformat_network_address): Doc fix.
13075
87302331
R
130762011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13077
ee7683eb 13078 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13079
cbb59342
CY
130802011-04-08 Chong Yidong <cyd@stupidchicken.com>
13081
13082 * keyboard.c (read_char): Call Lisp function help-form-show,
13083 instead of using internal_with_output_to_temp_buffer.
13084 (Qhelp_form_show): New var.
e0d38eeb 13085 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13086
13087 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13088
13089 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13090
e67a13ab
CY
130912011-04-06 Chong Yidong <cyd@stupidchicken.com>
13092
04f2d78b
CB
13093 * process.c (Flist_processes): Remove to Lisp.
13094 (list_processes_1): Delete.
e67a13ab 13095
973f782d
EZ
130962011-04-06 Eli Zaretskii <eliz@gnu.org>
13097
7c106b1e
EZ
13098 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13099
973f782d
EZ
13100 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13101
41cf7d1a 131022011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13103
ca23cc88
PE
13104 Fix more problems found by GCC 4.6.0's static checks.
13105
f390e2d5
PE
13106 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13107
42eea0d0
PE
13108 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13109
b69769da 13110 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13111
f9541e84
PE
13112 * xdisp.c (vmessage): Mark as a printf-like function.
13113
13841b55
PE
13114 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13115
c136c10f
PE
13116 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13117
5e2d4a30
PE
13118 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13119 printf-like functions.
13120 (tiff_load): Add casts to remove these marks before passing them
13121 to system-supplied API.
13122
583f48b9
PE
13123 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13124
b25d760e
PE
13125 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13126 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13127 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13128 directly, rather than having caller test rule sign. This avoids
13129 some unnecessary tests.
13130 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13131 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13132 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13133
bc7b6697 13134 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13135 (xfont_open): Avoid unnecessary tests.
bc7b6697 13136
27ccc379
PE
13137 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13138
dcd5c89a
PE
13139 * composite.h, composite.c (composition_gstring_put_cache):
13140 Use EMACS_INT, not int, for length.
13141
b13a45c6
PE
13142 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13143 breaking out part of COMPOSITION_DECODE_RULE.
13144 (COMPOSITION_DECODE_RULE): Use it.
13145 * composite.c (get_composition_id): Remove unused local vars,
13146 by using the new macro.
13147
1e792e4d
PE
13148 * textprop.c (set_text_properties_1): Change while to do-while,
13149 since the condition is always true at first.
13150
dc6c6455 13151 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13152 (interval_deletion_adjustment): Return unsigned value.
13153 All uses changed.
dc6c6455 13154
aba7731a
PE
13155 * process.c (list_processes_1, create_pty, read_process_output):
13156 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13157 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13158 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13159 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13160 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13161
fdfc4bf3
PE
13162 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13163
fca8fe46 13164 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13165 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13166
06a0259a 13167 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13168 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13169 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13170
e7b9e80f
PE
13171 * print.c (print_error_message): Avoid int overflow.
13172
56201685
PE
13173 * font.c (font_list_entities): Redo for clarity,
13174 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13175
78834453 13176 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13177 (font_score): Avoid potential overflow in diff calculation.
78834453 13178
0bc0b309 13179 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13180 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13181
e610eaca
PE
13182 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13183
b895abce
PE
13184 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13185 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13186 can always succeed if overflow has undefined behavior.
13187
1f1d9321 13188 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13189 (wordify): Omit three unnecessary tests.
1f1d9321 13190
c59478bc
PE
13191 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13192 All callers changed. This avoids the need for an unused var.
13193
79b73827
PE
13194 * casefiddle.c (casify_region): Remove var that is set but not used.
13195
a4db5dfe
PE
13196 * dired.c (file_name_completion): Remove var that is set but not used.
13197
43aae36e
PE
13198 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13199
2a47c44d 13200 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13201 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13202
a37c69bf
PE
13203 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13204 Check for integer overflow on size calculations.
13205
328ab8e7
PE
13206 * buffer.c (Fprevious_overlay_change): Remove var that is set
13207 but not used.
13208
e5a2a5cb
PE
13209 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13210 Remove vars that are set but not used.
8d84a6eb 13211 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13212 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13213
a60e5f68
PE
13214 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13215
f661cb61 13216 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13217 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13218
f0397f5a
PE
13219 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13220 that are set but not used.
13221
8664db06 13222 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13223 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13224
6abdaa4a
PE
13225 * xselect.c (x_get_local_selection, x_handle_property_notify):
13226 Remove vars that are set but not used.
13227
0ce7538d 13228 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13229 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13230
9ae848fc
PE
13231 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13232 Remove var that is set but not used.
0b918413
PE
13233 (scroll_bar_windows_size): Now size_t, not int.
13234 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13235 Check for overflow.
9ae848fc 13236
a5a62657
PE
13237 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13238 (map_tty_color) [!defined MSDOS]: Likewise.
13239
5c5cdd39
PE
13240 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13241
66ebf983
PE
13242 * coding.c: Remove vars that are set but not used.
13243 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13244 All callers changed.
13245 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13246 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13247 (decode_coding_charset): Remove vars that are set but not used.
13248
1be4d761
PE
13249 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13250 that is set but not used.
13251
47553fa8
PE
13252 * print.c (print_object): Remove var that is set but not used.
13253
1f7196bf 13254 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13255 The gnulib version avoids calling malloc in the usual case,
13256 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13257 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13258 * filelock.c (current_lock_owner): Likewise.
13259 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13260 * sysdep.c: Include allocator.h, careadlinkat.h.
13261 (emacs_no_realloc_allocator): New static constant.
13262 (emacs_readlink): New function.
fdb61804
PE
13263 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13264 ../lib/careadlinkat.h.
d1fdcab7 13265
f84c17c7
SM
132662011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13267
13268 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13269 first non-nil return value).
13270
ef3862ad
JD
132712011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13272
13273 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13274 if not defined (Bug#8403).
13275
376a7006
JB
132762011-04-02 Juanma Barranquero <lekktu@gmail.com>
13277
13278 * xdisp.c (display_count_lines): Remove parameter `start',
13279 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13280 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13281 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13282 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13283 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13284 and thereabouts. All callers changed.
13285 (get_per_char_metric): Remove parameter `f', unused since
13286 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13287
6ca3801d
JM
132882011-04-02 Jim Meyering <meyering@redhat.com>
13289
13290 do not dereference NULL upon failed strdup
13291 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13292 (ns_get_family): Likewise.
13293
d8e2b5ba
JB
132942011-04-02 Juanma Barranquero <lekktu@gmail.com>
13295
13296 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13297
8c74fcbd
JD
132982011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13299
13300 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13301 later (Bug#8403).
13302
7200d79c
SM
133032011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13304
03408648 13305 Add lexical binding.
7200d79c 13306
03408648
SM
13307 * window.c (Ftemp_output_buffer_show): New fun.
13308 (Fsave_window_excursion):
13309 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13310
13311 * lread.c (lisp_file_lexically_bound_p): New function.
13312 (Fload): Bind Qlexical_binding.
13313 (readevalloop): Remove `evalfun' arg.
13314 Bind Qinternal_interpreter_environment.
13315 (Feval_buffer): Bind Qlexical_binding.
13316 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13317 Mark as dynamic.
13318 (syms_of_lread): Declare `lexical-binding'.
13319
13320 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13321
13322 * keyboard.c (eval_dyn): New fun.
13323 (menu_item_eval_property): Use it.
ca105506
SM
13324
13325 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13326
03408648
SM
13327 * fns.c (concat, mapcar1): Accept byte-code-functions.
13328
13329 * eval.c (Fsetq): Handle lexical vars.
13330 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13331 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13332 (FletX, Flet): Obey lexical binding.
13333 (Fcommandp): Handle closures.
13334 (Feval): New `lexical' arg.
13335 (eval_sub): New function extracted from Feval. Use it almost
13336 everywhere where Feval was used. Look up vars in lexical env.
13337 Handle closures.
13338 (Ffunctionp): Move from subr.el.
13339 (Ffuncall): Handle closures.
13340 (apply_lambda): Remove `eval_flags'.
13341 (funcall_lambda): Handle closures and new byte-code-functions.
13342 (Fspecial_variable_p): New function.
13343 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13344 but without exporting it to Lisp.
23aba0ea 13345
23aba0ea 13346 * doc.c (Fdocumentation, store_function_docstring):
03408648 13347 * data.c (Finteractive_form): Handle closures.
23aba0ea 13348
03408648
SM
13349 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13350 interactive spec.
ba83908c 13351
04f2d78b
CB
13352 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13353 New byte-codes.
03408648
SM
13354 (exec_byte_code): New function extracted from Fbyte_code to handle new
13355 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13356
03408648 13357 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13358
03408648 13359 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13360
e2abce01
JB
133612011-03-31 Juanma Barranquero <lekktu@gmail.com>
13362
13363 * xdisp.c (redisplay_internal): Fix prototype.
13364
63696a73 133652011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13366
63696a73 13367 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13368 (try_scrolling): Use it when setting scroll_limit.
13369 Limit scrolling to 100 screen lines.
63696a73
EZ
13370 (redisplay_window): Even when falling back on "recentering",
13371 position point in the window according to scroll-conservatively,
13372 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13373
13374 (try_scrolling): When point is above the window, allow searching
13375 as far as scroll_max, or one screenful, to compute vertical
13376 distance from PT to the scroll margin position. This prevents
13377 try_scrolling from unnecessarily failing when
13378 scroll-conservatively is set to a value slightly larger than the
13379 window height. Clean up the case of PT below the margin at bottom
13380 of window: scroll_max can no longer be INT_MAX. When aggressive
13381 scrolling is in use, don't let point enter the opposite scroll
13382 margin as result of the scroll.
13383 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13384 threshold of 100 lines for never-recentering scrolling.
13385
e4cc2dfc
JB
133862011-03-31 Juanma Barranquero <lekktu@gmail.com>
13387
13388 * dispextern.h (move_it_by_lines):
13389 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13390 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13391 (message_log_check_duplicate): Remove parameters `prev_bol' and
13392 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13393 (redisplay_internal): Remove parameter `preserve_echo_area',
13394 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13395
13396 * indent.c (Fvertical_motion):
13397 * window.c (window_scroll_pixel_based, Frecenter):
13398 Don't pass `need_y_p' to `move_it_by_lines'.
13399
1c470562
SM
134002011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13401
44f230aa
SM
13402 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13403 steal a few bits to be more compact.
13404 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13405 Remove unneeded casts.
13406
1c470562
SM
13407 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13408
888adce9
ZK
134092011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13410
13411 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13412 binding" message (bug#7967).
13413
f838ed7b
PE
134142011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13415
77861b95
PE
13416 Fix more problems found by GCC 4.6.0's static checks.
13417
de6dbc14
PE
13418 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13419 Remove unused local var.
13420
f838ed7b
PE
13421 * editfns.c (Fmessage_box): Remove unused local var.
13422
792c7b2b
PE
13423 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13424 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13425 Omit unused local vars.
c499e557 13426 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13427 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13428 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13429 Omit unused local var.
13430
ba0165e1
PE
13431 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13432 Don't assume string length fits in int.
32ad8845 13433 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13434 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13435
3c59b4c9
PE
13436 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13437 instead of alloca (Bug#8344).
13438
a3eed478 13439 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13440 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13441
eb4d412d
PE
13442 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13443
1658b401
PE
13444 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13445 concerns.
13446
13447 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13448
13449 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13450
9a2c6e05
PE
13451 * keyboard.c (syms_of_keyboard): Use the same style as later
13452 in this function when indexing through an array. This also
13453 works around GCC bug 48267.
13454
03d0a109
PE
13455 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13456
44f730c8
PE
13457 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13458
fe75f926
PE
13459 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13460 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13461
ffa8c828
PE
13462 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13463 This avoids undefined behavior on integer overflow, and is a bit
13464 more convenient anyway since it is compared to a size_t variable.
13465
c5101a77
PE
13466 Variadic C functions now count arguments with size_t, not int.
13467 This avoids an unnecessary limitation on 64-bit machines, which
13468 caused (substring ...) to crash on large vectors (Bug#8344).
13469 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13470 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13471 All variadic functions and their callers changed accordingly.
c5101a77
PE
13472 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13473 * data.c (arith_driver, float_arith_driver): Likewise.
13474 * editfns.c (general_insert_function): Likewise.
13475 * eval.c (struct backtrace.nargs, interactive_p)
13476 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13477 (funcall_lambda, mark_backtrace): Likewise.
13478 * fns.c (concat): Likewise.
13479 * frame.c (x_set_frame_parameters): Likewise.
13480 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13481 0 if not found, not -1. All callers changed.
13482
dd3f25f7
PE
13483 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13484 (stack_copy_size): Now size_t, not int.
13485 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13486
461c2ab9
JB
134872011-03-28 Juanma Barranquero <lekktu@gmail.com>
13488
13489 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13490 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13491 All callers changed.
13492
13493 * lisp.h (multibyte_char_to_unibyte):
13494 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13495 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13496 * character.h (CHAR_TO_BYTE8):
13497 * cmds.c (internal_self_insert):
13498 * editfns.c (general_insert_function):
13499 * keymap.c (push_key_description):
13500 * search.c (Freplace_match):
13501 * xdisp.c (message_dolog, set_message_1): All callers changed.
13502
f6d62986
SM
135032011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13504
13505 * keyboard.c (safe_run_hook_funcall): New function.
13506 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13507 don't set the hook to nil, but remove the offending function instead.
13508 (Qcommand_hook_internal): Remove, unused.
13509 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13510 Vcommand_hook_internal.
13511
13512 * eval.c (enum run_hooks_condition): Remove.
13513 (funcall_nil, funcall_not): New functions.
13514 (run_hook_with_args): Call each function through a `funcall' argument.
13515 Remove `cond' argument, now redundant.
13516 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13517 (Frun_hook_with_args_until_failure): Adjust accordingly.
13518 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13519
1db5b1ad
JB
135202011-03-28 Juanma Barranquero <lekktu@gmail.com>
13521
13522 * dispextern.h (string_buffer_position): Remove declaration.
13523
13524 * print.c (strout): Remove parameter `multibyte', unused since
13525 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13526
13527 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13528 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13529 All callers changed.
13530
13531 * w32.c (_wsa_errlist): Use braces for struct initializers.
13532
13533 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13534 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13535 All callers changed.
13536 (string_buffer_position): Likewise. Also, make static (it's never
13537 used outside xdisp.c).
13538 (cursor_row_p): Remove parameter `w', unused since
13539 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13540 (decode_mode_spec): Remove parameter `precision', introduced during
13541 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13542 All callers changed.
13543
5ffb62aa
JD
135442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13545
13546 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13547
461c2ab9 135482011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13549
13550 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13551 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13552 (ns_update_auto_hide_menu_bar): New functions.
13553 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13554 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13555 ns_constrain_all_frames.
13556 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13557 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13558
5c380ffb
JD
135592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13560
13561 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13562
9af30bdf
GM
135632011-03-27 Glenn Morris <rgm@gnu.org>
13564
13565 * syssignal.h: Replace RETSIGTYPE with void.
13566 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13567 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13568 Replace SIGTYPE with void everywhere.
13569 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13570 * s/template.h (SIGTYPE): Remove commented out definition.
13571
e2abce01
JB
135722011-03-26 Eli Zaretskii <eliz@gnu.org>
13573
13574 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13575 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13576
f868cd8a
JB
135772011-03-26 Juanma Barranquero <lekktu@gmail.com>
13578
59eb0929
JB
13579 * w32.c (read_unc_volume): Use parameter `henum', instead of
13580 global variable `wget_enum_handle'.
13581
13582 * keymap.c (describe_vector): Remove parameters `indices' and
13583 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13584 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13585
f868cd8a
JB
13586 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13587
13588 * keyboard.c (timer_check): Remove parameter `do_it_now',
13589 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13590 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13591 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13592
13593 * keyboard.c (read_char):
13594 * w32menu.c (w32_menu_display_help):
13595 * xmenu.c (show_help_event, menu_help_callback):
13596 Adjust calls to `show_help_echo'.
13597
13598 * gtkutil.c (xg_maybe_add_timer):
13599 * keyboard.c (readable_events):
13600 * process.c (wait_reading_process_output):
13601 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13602
13603 * insdel.c (adjust_markers_gap_motion):
13604 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13605 (gap_left, gap_right): Don't call it.
13606
2ecf6fdb
CY
136072011-03-25 Chong Yidong <cyd@stupidchicken.com>
13608
13609 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13610 incurred during fontification.
13611
6b1f9ba4
JB
136122011-03-25 Juanma Barranquero <lekktu@gmail.com>
13613
13614 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13615 (DEFVAR_PER_BUFFER): Don't pass it.
13616
13617 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13618 (scrolling_window): Don't pass it.
13619
0f4a96b5
JB
136202011-03-25 Juanma Barranquero <lekktu@gmail.com>
13621
13622 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13623
13624 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13625 and `suffix'.
13626 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13627 of variables specific to SELinux and computation of `encoded_absname'.
13628
13629 * image.c (XPutPixel): Remove unused variable `height'.
13630
13631 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13632
13633 * unexw32.c (get_section_info): Remove unused variable `section'.
13634
13635 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13636 (system_process_attributes): Remove unused variable `sess'.
13637 (sys_read): Remove unused variable `err'.
13638
13639 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13640 (w32_wnd_proc): Remove unused variable `isdead'.
13641 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13642 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13643 (x_create_tip_frame): Remove unused variable `tem'.
13644
13645 * w32inevt.c (w32_console_read_socket):
13646 Remove unused variable `no_events'.
13647
13648 * w32term.c (x_draw_composite_glyph_string_foreground):
13649 Remove unused variable `width'.
13650
1149507c
JB
136512011-03-24 Juanma Barranquero <lekktu@gmail.com>
13652
13653 * w32term.c (x_set_glyph_string_clipping):
13654 Don't pass uninitialized region to CombineRgn.
13655
9c88f339
JB
136562011-03-23 Juanma Barranquero <lekktu@gmail.com>
13657
13658 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13659 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13660 (Fx_close_connection): Remove unused variable `i'.
13661
13662 * w32font.c (w32font_draw): Return number of glyphs.
13663 (w32font_open_internal): Remove unused variable `i'.
13664 (w32font_driver): Add missing initializer.
13665
13666 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13667 (fill_in_menu): Remove unused variable `items_added'.
13668
13669 * w32term.c (last_mouse_press_frame): Remove static global variable.
13670 (w32_clip_to_row): Remove unused variable `f'.
13671 (x_delete_terminal): Remove unused variable `i'.
13672
13673 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13674 (NOTHING): Remove unused static global variable.
13675 (uniscribe_check_otf): Remove unused variable `table'.
13676 (uniscribe_font_driver): Add missing initializers.
13677
dee091a3
JD
136782011-03-23 Julien Danjou <julien@danjou.info>
13679
13680 * term.c (Fsuspend_tty, Fresume_tty):
13681 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13682 * window.c (temp_output_buffer_show):
13683 * insdel.c (signal_before_change):
13684 * frame.c (Fhandle_switch_frame):
13685 * fileio.c (Fdo_auto_save):
13686 * emacs.c (Fkill_emacs):
13687 * editfns.c (save_excursion_restore):
13688 * cmds.c (internal_self_insert):
13689 * callint.c (Fcall_interactively):
13690 * buffer.c (Fkill_all_local_variables):
13691 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13692 Use Frun_hooks.
0f4a96b5 13693 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13694 unconditionally since it does the check itself.
dee091a3 13695
2c520ab5 136962011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13697
c9c49752
PE
13698 Fix more problems found by GCC 4.5.2's static checks.
13699
8abc3f12
PE
13700 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13701 the first time through the loop, since we know p0 < p1 then.
13702 This also avoids a gcc -Wstrict-overflow warning.
13703
a2d26660
PE
13704 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13705 leading to a memory leak, possible in functions like
13706 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13707 of objects (Bug#8318).
a2d26660 13708
916c72e9
PE
13709 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13710 that could (at least in theory) be that large.
13711
19ab8a18
PE
13712 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13713 This is less likely to overflow, and avoids undefined behavior if
13714 overflow does occur. All callers changed. Use strtoul to scan
13715 for the unsigned long integer.
b7cbbd6f
PE
13716 (pint2hrstr): Simplify and tune code slightly.
13717 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13718
f0641eff
PE
13719 * scroll.c (do_scrolling): Work around GCC bug 48228.
13720 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13721
7f650bb9
PE
13722 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13723 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13724 (validate_x_resource_name): Simplify count usage.
13725 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13726
37dd57d1
PE
13727 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13728 fail (Bug#8306).
81e56e61 13729
699979fc 13730 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13731
401bf9b4
PE
13732 * process.c (Fmake_network_process): Use socklen_t, not int,
13733 where POSIX says socklen_t is required in portable programs.
13734 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13735 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13736 (Fmake_network_process, server_accept_connection):
13737 (wait_reading_process_output, read_process_output):
13738 Likewise.
13739
b93aacde
PE
13740 * process.c: Rename or move locals to avoid shadowing.
13741 (list_processes_1, Fmake_network_process):
13742 (read_process_output_error_handler, exec_sentinel_error_handler):
13743 Rename or move locals.
4dc343ee 13744 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13745 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13746 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13747 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13748 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13749
af8a867c 13750 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13751 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13752 Include tparam.h instead, since it declares them.
af8a867c
PE
13753 * cm.h (PC): Remove extern decl; tparam.h now does this.
13754 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13755 * terminfo.c: Include tparam.h, to check interfaces.
13756 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13757 (tparam): Adjust signature to match interface in tparam.h;
13758 this removes some undefined behavior. Check that outstring and len
13759 are zero, which they always are with Emacs.
13760 * tparam.h (PC, BC, UP): New extern decls.
13761
0248044d 13762 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13763 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13764
8ff096c1 13765 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13766 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13767 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13768 (ftfont_list): Remove unused local.
49eaafba
PE
13769 (get_adstyle_property, ftfont_pattern_entity):
13770 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13771 Rename locals to avoid shadowing.
8ff096c1 13772
e2be39f6
PE
13773 * xfont.c (xfont_list_family): Mark var as initialized.
13774
c9735e30
PE
13775 * xml.c (make_dom): Now static.
13776
8f5201ae
PE
13777 * composite.c (composition_compute_stop_pos): Rename local to
13778 avoid shadowing.
b246f932
PE
13779 (composition_reseat_it): Remove unused locals.
13780 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13781 (composition_update_it): Mark var as initialized.
11b61122
PE
13782 (find_automatic_composition): Mark vars as initialized,
13783 with a FIXME (Bug#8290).
8f5201ae 13784
760fbc2c
PE
13785 character.h: Rename locals to avoid shadowing.
13786 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13787 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13788 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13789 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13790 to avoid shadowing.
13791
ff08eb85
PE
13792 * textprop.c (property_change_between_p): Remove; unused.
13793
fc7bf025
PE
13794 * intervals.c (interval_start_pos): Now static.
13795
235d7abc
PE
13796 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13797
44f230aa
SM
13798 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13799 Rename locals to avoid shadowing.
3e7d6594 13800
50060332
PE
13801 * sound.c (wav_play, au_play, Fplay_sound_internal):
13802 Fix pointer signedness.
d01f234b 13803 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13804 (wav_play): Initialize a variable to 0, to prevent undefined
13805 behavior (Bug#8278).
50060332 13806
c4fc4e30
PE
13807 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13808
918436ed
PE
13809 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13810
c939f91b
PE
13811 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13812 clobbering (Bug#8298).
b9c7f648
PE
13813 * sysdep.c (sys_subshell): Likewise.
13814 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13815
6bd8c144
PE
13816 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13817 This should get cleaned up, so that child_setup has the
13818 same signature on all platforms.
13819
7710357c 13820 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13821 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13822
c59da222
CY
138232011-03-22 Chong Yidong <cyd@stupidchicken.com>
13824
13825 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13826 not to be necessary, and produces flickering.
13827
66b87493
GM
138282011-03-20 Glenn Morris <rgm@gnu.org>
13829
13830 * config.in: Remove file.
13831
45b6f6d5
JB
138322011-03-20 Juanma Barranquero <lekktu@gmail.com>
13833
13834 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13835 are now in src/globals.h.
13836 (syms_of_minibuf): Remove spurious & from previous change.
13837
cd394be1 138382011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13839
13840 * minibuf.c (completing-read-function): New variable.
13841 (completing-read-default): Rename from completing-read.
13842 (completing-read): Call completing-read-function.
13843
b14e3e21
CY
138442011-03-19 Juanma Barranquero <lekktu@gmail.com>
13845
13846 * xfaces.c (Fx_load_color_file):
13847 Read color file from absolute filename (bug#8250).
13848
f2b726e6
JB
138492011-03-19 Juanma Barranquero <lekktu@gmail.com>
13850
13851 * makefile.w32-in: Update dependencies.
13852
09f6ff02
EZ
138532011-03-17 Eli Zaretskii <eliz@gnu.org>
13854
13855 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13856
29a6015a
PE
138572011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13858
a3a6c54e
PE
13859 Fix more problems found by GCC 4.5.2's static checks.
13860
b766f867
PE
13861 * process.c (make_serial_process_unwind, send_process_trap):
13862 (sigchld_handler): Now static.
13863
be02381c
PE
13864 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13865 That way, the code declares only the vars that it needs.
13866 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13867 * s/cygwin.h (PTY_ITERATION): Likewise.
13868 * s/darwin.h (PTY_ITERATION): Likewise.
13869 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13870
57048744
PE
13871 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13872 * process.c (allocate_pty): Don't declare stb unless it's needed.
13873
7914961c 13874 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13875 (CONSTANTLIM): Remove; unused.
13876 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13877 Define only if needed.
7914961c 13878
b3967b18
PE
13879 * unexelf.c (unexec): Name an expression,
13880 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13881 Use a different way to cause a compilation error if anyone uses
13882 n rather than nn, a way that does not involve shadowing.
73366a00 13883 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13884
29a6015a
PE
13885 * deps.mk (unexalpha.o): Remove; unused.
13886
43cfc33e 13887 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13888 * unexec.h: New file.
ce701a33
PE
13889 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13890 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13891 Depend on unexec.h.
13892 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13893 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13894 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13895 Change as necessary to match prototype in unexec.h.
ce701a33 13896
01f44d5a
PE
13897 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13898 shadowing.
4f63c6bb 13899 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13900
a6670b0b
PE
13901 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13902 Rename locals to avoid shadowing.
13903
cef2010d 13904 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13905 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13906
d4d7173a
PE
13907 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13908
f08b802a
PE
13909 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13910 warning when compiling print.c.
13911
3ddb0639
PE
13912 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13913 instead of using an uninitialized var.
5ad03b97 13914 (font_sort_entities): Mark var as initialized.
3ddb0639 13915
170a2692
PE
13916 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13917
e663c700
PE
13918 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13919 pointers to constants.
89bc529a 13920 (font_parse_fcname): Remove unused vars.
7b81e2d0 13921 (font_delete_unmatched): Now static.
ea838e10 13922 (font_get_spec): Remove; unused.
13a547c6
PE
13923 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13924 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13925 Rename or move locals to avoid shadowing.
e663c700 13926
2a80c887 13927 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13928 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13929
1384fa33 13930 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13931 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13932
8b2c52e9
PE
13933 * alloc.c (mark_backtrace): Move decl from here ...
13934 * lisp.h: ... to here, so that it can be checked.
13935
475545b5 13936 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13937 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13938 (lisp_indirect_variable): Name an expression,
13939 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13940 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13941
b1349114 13942 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13943 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13944 Use const pointer when appropriate.
b1349114 13945
a2928364
PE
13946 * lisp.h (get_system_name, get_operating_system_release):
13947 Move decls here, to check interfaces.
13948 * process.c (get_operating_system_release): Move decl to lisp.h.
13949 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13950 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13951 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13952 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13953 (Fformat_time_string, Fencode_time, Finsert_char):
13954 (Ftranslate_region_internal, Fformat):
13955 Rename or remove local vars to avoid shadowing.
9710023e 13956 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13957
a415e694
PE
13958 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13959 avoid shadowing.
13960
8ef4622d
PE
13961 * lisp.h (eassert): Check that the argument compiles, even if
13962 ENABLE_CHECKING is not defined.
13963
946f9a5b
PE
13964 * data.c (Findirect_variable): Name an expression, to avoid
13965 gcc -Wbad-function-cast warning.
112396d6 13966 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13967 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13968 (Fmake_variable_buffer_local, Fmake_local_variable):
13969 Mark variables as initialized.
52746918 13970 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13971
e5aab7e7 13972 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13973 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13974 Rename locals to avoid shadowing.
dff45157
PE
13975 (mark_stack): Move local variables into the #ifdef region where
13976 they're used.
7bc26fdb
PE
13977 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13978 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13979 needed otherwise.
13980 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13981 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13982 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13983
e5aab7e7
PE
13984 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13985 avoids undefined behavior in theory.
13986
4da60324
PE
13987 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13988
88043301
PE
13989 Use functions, not macros, for up- and down-casing (Bug#8254).
13990 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13991 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13992 to use the following functions instead of these macros.
13993 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13994 EMACS_INT, since callers assume the returned value fits in int.
13995 (upcase1): Likewise, for UPCASE_TABLE.
13996 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13997 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13998 the race-condition problem in the old DOWNCASE.
88043301 13999
19ed5445
PE
14000 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14001 Rename locals to avoid shadowing.
14002 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14003 (regex_compile, re_search_2, re_match_2_internal):
14004 Remove unused local vars.
952db0d7
PE
14005 (FREE_VAR): Rewrite so as not to use empty "else",
14006 which gcc can warn about.
da053e48 14007 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14008 (RETALLOC_IF): Define only if needed.
14009 (WORDCHAR_P): Likewise. This one is never needed, but is used
14010 only in a comment talking about a compiler bug, so put inside
14011 the #if 0 of that comment.
14012 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14013 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14014 Remove; unused.
19ed5445 14015
1f3561e4 14016 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14017 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14018 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14019
ded6f8f7
PE
14020 * search.c (simple_search): Remove unused var.
14021
dbd37a95
PE
14022 * dired.c (compile_pattern): Move decl from here ...
14023 * lisp.h: ... to here, so that it can be checked.
14024 (struct re_registers): New forward decl.
14025
7e47afad
PE
14026 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14027
85f24f61
PE
14028 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14029 All uses changed.
14030 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14031 Rename locals to avoid shadowing.
5671df8f 14032 (Fvertical_motion): Mark locals as initialized.
85f24f61 14033
181aa2be 14034 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14035 (casify_region): Mark local as initialized.
181aa2be 14036
930d429c
PE
14037 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14038
7082eac6
PE
14039 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14040 New macros, so that the caller can use some names other than
14041 gcpro1, gcpro2, etc.
14042 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14043 of the new macros.
14044 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14045 argument, for consistency with GCPRO2_VAR, etc: it is now the
14046 prefix of the variable, not the variable itself. All uses
14047 changed.
38b2c076
PE
14048 * dired.c (directory_files_internal, file_name_completion):
14049 Rename locals to avoid shadowing.
14050
15206ed9
PE
14051 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14052 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14053 dired.c's scmp function, had undefined behavior.
14054 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14055 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14056 * buffer.h: ... to here, because these macros use current_buffer,
14057 and the new implementation with inline functions needs to have
14058 current_buffer in scope now, rather than later when the macros
14059 are used.
14060 (downcase, upcase1): New static inline functions.
14061 (DOWNCASE, UPCASE1): Reimplement using these functions.
14062 This avoids undefined behavior in expressions like
14063 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14064 from race conditions in accessing the global variables
14065 case_temp1 and case_temp2.
14066 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14067 * lisp.h (case_temp1, case_temp2): Remove their decls.
14068 * character.h (ASCII_CHAR_P): Move from here ...
14069 * lisp.h: ... to here, so that the inline functions mentioned
14070 above can use them.
14071
4a6bea26
PE
14072 * dired.c (directory_files_internal_unwind): Now static.
14073
f14b7e14
PE
14074 * fileio.c (file_name_as_directory, directory_file_name):
14075 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14076 Now static.
2893f146
PE
14077 (file_name_as_directory): Use const pointers when appropriate.
14078 (Fexpand_file_name): Likewise. In particular, newdir might
14079 point at constant storage, so make it a const pointer.
fd4ead52 14080 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14081 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14082 signedness issues.
f839df0c
PE
14083 (Fset_file_times, Finsert_file_contents, auto_save_error):
14084 Rename locals to avoid shadowing.
f14b7e14 14085
5716756e 14086 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14087 (Ftry_completion, Fall_completions): Rename or remove locals
14088 to avoid shadowing.
5716756e 14089
b4c3046a
PE
14090 * marker.c (bytepos_to_charpos): Remove; unused.
14091
b45db522
PE
14092 * lisp.h (verify_bytepos, count_markers): New decls,
14093 so that gcc does not warn that these functions aren't declared.
14094
85876d07
PE
14095 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14096 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14097 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14098 (copy_text): Remove unused local var.
85876d07 14099
03d78a21 14100 * filelock.c (within_one_second): Now static.
b3dd38ab 14101 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14102
5df8f01b
PE
14103 * buffer.c (fix_overlays_before): Mark locals as initialized.
14104 (fix_start_end_in_overlays): Likewise. This function should be
14105 simplified by using pointers-to-pointers, but that's a different
14106 matter.
b1d876f1 14107 (switch_to_buffer_1): Now static.
8f54f30a
PE
14108 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14109 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14110
a70072c9 14111 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14112 Fix pointer signedness issue.
edced198
PE
14113 (sys_subshell): Mark local as volatile if checking for lint,
14114 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14115 (MAXPATHLEN): Define only if needed.
a70072c9 14116
a0977c44
PE
14117 * process.c (serial_open, serial_configure): Move decls from here ...
14118 * systty.h: ... to here, so that they can be checked.
14119
a884fdcc
PE
14120 * fns.c (get_random, seed_random): Move extern decls from here ...
14121 * lisp.h: ... to here, so that they can be checked.
14122
604efe86 14123 * sysdep.c (reset_io): Now static.
b8950c94 14124 (wait_for_termination_signal): Remove; unused.
604efe86 14125
38fc62d9
PE
14126 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14127 (copy_keymap_item, append_key, push_text_char_description):
14128 Now static.
1004a21a 14129 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14130 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14131 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14132 (describe_map_tree):
14133 Rename locals to avoid shadowing.
38fc62d9 14134
2f2650da
PE
14135 * keyboard.c: Declare functions static if they are not used elsewhere.
14136 (echo_char, echo_dash, cmd_error, top_level_2):
14137 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14138 (read_char, kbd_buffer_get_event, make_lispy_position):
14139 (make_lispy_event, make_lispy_movement, apply_modifiers):
14140 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14141 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14142 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14143 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14144 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14145
a053e86c 14146 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14147 (mark_kboards): Move decl here ...
14148 * alloc.c (mark_kboards): ... from here.
a053e86c 14149
4752793e
PE
14150 * lisp.h (force_auto_save_soon): New decl.
14151
74f10ca7 14152 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14153 (DEFINE_DUMMY_FUNCTION): New macro.
14154 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14155 Use it.
c03cd23f
PE
14156 (main): Add casts to avoid warnings
14157 if GCC considers string literals to be constants.
74f10ca7 14158
022e70d4
PE
14159 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14160
59d6fe83
PE
14161 * dbusbind.c: Pointer signedness fixes.
14162 (xd_signature, xd_append_arg, xd_initialize):
14163 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14164 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14165 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14166 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14167
78320123
PE
14168 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14169 if GCC considers string literals to be constants.
49cebcca 14170 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14171
35ac2a97
SM
141722011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14173
fb103ca9
SM
14174 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14175 (print_preprocess, print_object): New macro to fix last change.
14176
35ac2a97
SM
14177 * print.c (print_preprocess): Don't forget font objects.
14178
62973b41
JB
141792011-03-16 Juanma Barranquero <lekktu@gmail.com>
14180
14181 * emacs.c (USAGE3): Doc fixes.
14182
0e48bb22
AS
141832011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14184
14185 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14186 structure.
14187
7684e57b
JB
141882011-03-14 Juanma Barranquero <lekktu@gmail.com>
14189
14190 * lisp.h (VWindow_system, Qfile_name_history):
14191 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14192 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14193 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14194
14195 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14196 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14197
14198 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14199 * w32console.c (detect_input_pending, read_input_pending)
14200 (encode_terminal_code):
14201 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14202 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14203 (w32_system_caret_y, Qfile_name_history):
14204 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14205 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14206 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14207 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14208 * w32proc.c (Qlocal, report_file_error):
14209 * w32term.c (Vwindow_system, updating_frame):
14210 * w32uniscribe.c (initialized, uniscribe_font_driver):
14211 Remove unneeded extern declarations.
14212
2aa46d6c
CY
142132011-03-14 Chong Yidong <cyd@stupidchicken.com>
14214
c96bbc66 14215 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14216
cffc6f3b
CY
142172011-03-13 Chong Yidong <cyd@stupidchicken.com>
14218
14219 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14220 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14221 These macros can no longer be used for assignment.
14222
44f230aa
SM
14223 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14224 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14225 (record_buffer_markers, fetch_buffer_markers): New functions for
14226 recording and fetching special buffer markers.
14227 (set_buffer_internal_1, set_buffer_temp): Use them.
14228
14229 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14230
14231 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14232
14233 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14234 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14235
14236 * xdisp.c (hscroll_window_tree):
14237 (reconsider_clip_changes): Use PT instead of BUF_PT.
14238
d251f04b
EZ
142392011-03-13 Eli Zaretskii <eliz@gnu.org>
14240
14241 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14242 $(EMACS_ROOT)/lib/intprops.h.
14243
f0c77cd1
PE
142442011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14245
3eca4629
PE
14246 Fix more problems found by GCC 4.5.2's static checks.
14247
7c86ee98
PE
14248 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14249 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14250 (xg_free_frame_widgets): Make it clear that a local variable is
14251 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14252 (gdk_window_get_screen): Make it clear that this macro is needed
14253 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14254 (int_gtk_range_get_value): New function, which avoids a diagnostic
14255 from gcc -Wbad-function-cast.
14256 (xg_set_toolkit_scroll_bar_thumb): Use it.
14257 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14258 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14259 (get_utf8_string, xg_get_file_with_chooser):
14260 Rename locals to avoid shadowing.
14261 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14262
41729b81
PE
14263 * xgselect.c (xg_select): Remove unused var.
14264
f0c77cd1
PE
14265 * image.c (four_corners_best): Mark locals as initialized.
14266 (gif_load): Initialize transparent_p to zero (Bug#8238).
14267 Mark another local as initialized.
ec6cf4c6 14268 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14269
ce0ad53d 14270 * image.c (clear_image_cache): Now static.
d5d5a617 14271 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14272 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14273 (x_edge_detection): Remove unnecessary cast that
14274 gcc -Wbad-function-cast diagnoses.
2037898d 14275 (gif_load): Fix pointer signedness.
6ae141d6
PE
14276 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14277 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14278
33383987 142792011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14280
d32df629
PE
14281 Improve quality of tests for time stamp overflow.
14282 For example, without this patch (encode-time 0 0 0 1 1
14283 1152921504606846976) returns the obviously-bogus value (-948597
14284 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14285 reports time overflow. See
14286 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14287 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14288 * editfns.c: Include limits.h and intprops.h.
14289 (TIME_T_MIN, TIME_T_MAX): New macros.
14290 (time_overflow): Move earlier, to before first use.
14291 (hi_time, lo_time): New functions, for an accurate test for
14292 out-of-range times.
14293 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14294 (Fget_internal_run_time): Don't assume time_t fits in int.
14295 (make_time): Use list2 instead of Fcons twice.
14296 (Fdecode_time): More accurate test for out-of-range times.
14297 (check_tm_member): New function.
14298 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14299 (lisp_time_argument): Don't rely on undefined left-shift and
14300 right-shift behavior when checking for time stamp overflow.
8be6f318 14301
fe31d94c
PE
14302 * editfns.c (time_overflow): New function, refactoring common code.
14303 (Fformat_time_string, Fdecode_time, Fencode_time):
14304 (Fcurrent_time_string): Use it.
14305
8be6f318
PE
14306 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14307 * dired.c (make_time): Move to ...
14308 * editfns.c (make_time): ... here.
14309 * systime.h: Note the move.
14310
09d9db2c 143112011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14312
126bc0dc
YM
14313 * fringe.c (update_window_fringes): Remove unused variables.
14314
c47cbdfd
YM
14315 * unexmacosx.c (copy_data_segment): Also copy __got section.
14316 (Bug#8223)
14317
7ac80be9
EZ
143182011-03-12 Eli Zaretskii <eliz@gnu.org>
14319
c96bbc66 14320 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14321 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14322 Constify `char *' arguments and their references according to
14323 prototypes in tparam.h.
14324
ecb0f94d 14325 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14326
7ac80be9
EZ
14327 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14328 Adapt all references accordingly.
14329
14330 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14331
ef1fd07e
TT
143322011-03-11 Tom Tromey <tromey@redhat.com>
14333
14334 * buffer.c (syms_of_buffer): Remove obsolete comment.
14335
7ef4b50c
EZ
143362011-03-11 Eli Zaretskii <eliz@gnu.org>
14337
14338 * termhooks.h (encode_terminal_code): Declare prototype.
14339
14340 * msdos.c (encode_terminal_code): Don't declare prototype.
14341
14342 * term.c (encode_terminal_code): Now external again, used by
14343 w32console.c and msdos.c.
14344
44f230aa
SM
14345 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14346 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14347
4b1ec863 143482011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14349
1714f52b 14350 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14351
4b1ec863
PE
14352 * fringe.c (update_window_fringes): Mark locals as initialized
14353 (Bug#8227).
14354 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14355
524c7aa6
PE
14356 * alloc.c (mark_fringe_data): Move decl from here ...
14357 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14358 to check its interface.
14359 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14360
a5c0af81 14361 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14362 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14363 (fontset_font): Mark local as initialized.
a9a06e0b 14364 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14365
b4716021
PE
14366 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14367
811e9bac 14368 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14369 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14370 (x_own_selection, Fx_disown_selection_internal): Rename locals
14371 to avoid shadowing.
14372 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14373
7e3ab302
PE
14374 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14375 so that the caller can use some name other than gcpro1.
14376 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14377 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14378 (Fx_backspace_delete_keys_p):
14379 Use them to avoid shadowing, and rename vars to avoid shadowing.
14380 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14381 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14382 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14383 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14384 Remove unused locals.
7e3ab302
PE
14385 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14386 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14387 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14388 macros.
f78faa98 14389
e2b13473
PE
14390 * xterm.h (x_mouse_leave): New decl.
14391
77f23912
PE
14392 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14393 Remove unused functions.
cdf4ba58
PE
14394 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14395 (x_calc_absolute_position): Now static.
7411c686 14396 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14397 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14398 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14399 unless they are used.
38d0b34a
PE
14400 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14401 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14402 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14403 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14404 (x_error_catcher, x_connection_closed, x_error_handler):
14405 (x_error_quitter, xembed_send_message, x_iconify_frame):
14406 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14407 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14408 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14409
44f230aa
SM
14410 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14411 Rename or move locals to avoid shadowing.
6b463e58 14412 (tty_defined_color, merge_face_heights): Now static.
5967d051 14413 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14414 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14415 does not deduce is never used uninitialized.
73719eba
PE
14416 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14417 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14418
426994c3 14419 * terminal.c (store_terminal_param): Now static.
5489860b 14420
032f1620 14421 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14422 (set_frame_menubar): Remove unused local.
d4323972 14423 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14424 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14425 since they might point to immutable storage.
281585b0
PE
14426 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14427 since it's unused otherwise.
032f1620 14428
367c19e5 14429 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14430 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14431 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14432 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14433 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14434 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14435 does not deduce are never used uninitialized.
70739cbe 14436
07b48fa9
PE
14437 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14438
8868a238 14439 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14440 * window.c (window_loop, size_window):
14441 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14442
7e5cf297 14443 * window.c (display_buffer): Now static.
d6550a9f
PE
14444 (size_window): Mark variables that gcc -Wuninitialized
14445 does not deduce are never used uninitialized.
a586633d
PE
14446 * window.h (check_all_windows): New decl, to forestall
14447 gcc -Wmissing-prototypes diagnostic.
5b555da1 14448 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14449
f6095868
PE
14450 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14451 shadowing.
14452 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14453 Include <limits.h>.
14454 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14455 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14456 (load_charset_map): Mark variables that gcc -Wuninitialized
14457 does not deduce are never used uninitialized.
53df7c11 14458 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14459
f38b440c
PE
14460 * coding.c (coding_set_source, coding_set_destination):
14461 Use "else { /* comment */ }" rather than "else /* comment */;"
14462 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14463 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14464 a block, when the outer 'i' will do.
14465 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14466 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14467 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14468 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14469 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14470 Rename locals to avoid shadowing.
14471 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14472 * coding.c (emacs_mule_char, encode_invocation_designation):
14473 Now static, since they're not used elsewhere.
413bb2db 14474 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14475 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14476 (decode_coding_emacs_mule): Mark variables that gcc
14477 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14478 (detect_coding_iso_2022): Initialize a local variable that might
14479 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14480 this initialization is needed. (Bug#8211)
5f58e762
PE
14481 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14482 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14483 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14484 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14485 Remove unused macros.
f38b440c 14486
232b38b9 14487 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14488 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14489 * character.c (string_count_byte8): Likewise.
232b38b9 14490
fb90da1b
PE
14491 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14492 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14493
fb93dbc2
PE
14494 * chartab.c (copy_sub_char_table): Now static, since it's not used
14495 elsewhere.
5c156ace
PE
14496 (sub_char_table_ref_and_range, char_table_ref_and_range):
14497 Rename locals to avoid shadowing.
bbcd0949 14498 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14499
7d3b3862 14500 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14501 (BIDI_BOB): Remove unused macro.
7d3b3862 14502
6be7d3da
PE
14503 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14504 deduce are never used uninitialized.
c2ed9c8b 14505 * term.c (encode_terminal_code): Likewise.
6be7d3da 14506
75f8807f 14507 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14508
50938595
PE
14509 * tparam.h: New file.
14510 * term.c, tparam.h: Include it.
14511 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14512 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14513 Move these decls to tparam.h, and make them agree with what
14514 is actually in tparam.c. The previous trick of using incompatible
14515 decls in different modules does not conform to the C standard.
14516 All callers of tparam changed to use tparam's actual API.
14517 * tparam.c (tparam1, tparam, tgoto):
14518 Use const pointers where appropriate.
14519
fbceeba2
PE
14520 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14521 * cm.h (struct cm): Likewise.
14522 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14523 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14524 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14525 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14526 (turn_on_face, init_tty): Likewise.
14527 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14528
7f3f1250
PE
14529 * term.c (term_mouse_position): Rename local to avoid shadowing.
14530
e6ca6543
PE
14531 * alloc.c (mark_ttys): Move decl from here ...
14532 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14533
c40f8d15
AS
145342011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14535
14536 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14537
cfe0661d
JB
145382011-03-09 Juanma Barranquero <lekktu@gmail.com>
14539
14540 * search.c (compile_pattern_1): Remove argument regp, unused since
14541 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14542 (compile_pattern): Don't pass it.
14543
0afb4571
J
145442011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14545
14546 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14547 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14548 for ! HAVE_GTK3.
14549 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14550
14551 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14552
14553 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14554 gdk_window_get_screen, gdk_window_get_geometry,
14555 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14556 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14557 (xg_get_pixbuf_from_pixmap): New function.
14558 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14559 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14560 Call xg_get_pixbuf_from_pixmap instead of
14561 gdk_pixbuf_get_from_drawable.
14562 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14563 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14564 (xg_check_special_colors): Use GtkStyleContext and its functions
14565 for HAVE_GTK3.
14566 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14567 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14568 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14569 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14570 Call gtk_widget_get_preferred_size.
0afb4571
J
14571 (xg_frame_resized): gdk_window_get_geometry only takes 5
14572 parameters.
44f230aa
SM
14573 (xg_win_to_widget, xg_event_is_for_menubar):
14574 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14575 (xg_set_widget_bg): New function.
14576 (delete_cb): New function.
895009e1 14577 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14578 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14579 (xg_set_background_color): Call xg_set_widget_bg.
14580 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14581 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14582 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14583 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14584 if ! HAVE_GTK3.
14585 (update_frame_tool_bar): Call gtk_widget_hide.
14586 (xg_initialize): Use GDK_KEY_g.
14587
14588 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14589 if ! HAVE_GTK3
14590 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14591
14592 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14593 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14594 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14595
1c2cc4ef
JB
145962011-03-08 Juanma Barranquero <lekktu@gmail.com>
14597
14598 * w32xfns.c (select_palette): Check success of RealizePalette against
14599 GDI_ERROR, not zero.
14600
33383987 14601See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14602
14603;; Local Variables:
14604;; coding: utf-8
aac0c6e3
MR
14605;; End:
14606
2f097256 14607 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14608
14609 This file is part of GNU Emacs.
14610
14611 GNU Emacs is free software: you can redistribute it and/or modify
14612 it under the terms of the GNU General Public License as published by
14613 the Free Software Foundation, either version 3 of the License, or
14614 (at your option) any later version.
14615
14616 GNU Emacs is distributed in the hope that it will be useful,
14617 but WITHOUT ANY WARRANTY; without even the implied warranty of
14618 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14619 GNU General Public License for more details.
14620
14621 You should have received a copy of the GNU General Public License
14622 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.