Merge: Fix minor problems found by static checking.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3f754b86
PE
12011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2
109e28d0
PE
3 Fix minor problems found by static checking.
4
60737f02
PE
5 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6
4b66faf3
PE
7 Make identifiers static if they are not used in other modules.
8 * data.c (Qcompiled_function, Qframe, Qvector):
9 * image.c (QimageMagick, Qsvg):
10 * minibuf.c (Qmetadata):
11 * window.c (resize_window_check, resize_root_window): Now static.
12 * window.h (resize_window_check, resize_root_window): Remove decls.
13
109e28d0
PE
14 * window.c (window_deletion_count, delete_deletable_window):
15 Remove; unused.
46a4ce9e
PE
16 (window_body_lines): Now static.
17 (Fdelete_other_windows_internal): Mark vars as initialized.
18 Make sure 'resize_failed' is initialized.
19 (run_window_configuration_change_hook): Rename local to avoid shadowing.
20 (resize_window_apply): Remove unused local.
21 * window.h (delete_deletable_window): Remove decl.
22
109e28d0 23 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
24 (imagemagick_load_image): Fix pointer signedness problem by changing
25 last arg from unsigned char * to char *. All uses changed.
26 Also, fix a local for similar reasons.
27 Remove unused locals. Remove locals to avoid shadowing.
28 (fn_rsvg_handle_free): Remove; unused.
29 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 30 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 31
3f754b86
PE
32 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
33
2547adb1
CY
342011-06-10 Chong Yidong <cyd@stupidchicken.com>
35
36 * image.c (gif_load): Fix omitted cast error introduced by
37 2011-06-06 change.
38
2c8e37d4
MR
392011-06-10 Martin Rudalics <rudalics@gmx.at>
40
41 * window.h (resize_proportionally, orig_total_lines)
42 (orig_top_line): Remove from window structure.
43 (set_window_height, set_window_width, change_window_heights)
44 (Fdelete_window): Remove prototypes.
45 (resize_frame_windows): Remove duplicate declaration.
46
440a42e3
EZ
472011-06-10 Eli Zaretskii <eliz@gnu.org>
48
49 * window.h (resize_frame_windows, resize_window_check)
50 (delete_deletable_window, resize_root_window)
51 (resize_frame_windows): Declare prototypes.
52
53 * window.c (resize_window_apply): Make definition be "static" to
54 match the prototype.
55
562dd5e9
MR
562011-06-10 Martin Rudalics <rudalics@gmx.at>
57
58 * window.c: Remove declarations of Qwindow_size_fixed,
59 window_min_size_1, window_min_size_2, window_min_size,
60 size_window, window_fixed_size_p, enlarge_window, delete_window.
61 Remove static from declaration of Qdelete_window, it's
62 temporarily needed by Fbury_buffer.
63 (replace_window): Don't assign orig_top_line and
64 orig_total_lines.
65 (Fdelete_window, delete_window): Remove. Window deletion is
66 handled by window.el.
67 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
68 Fdelete_window calls with calls to Qdelete_window.
69 (Fdelete_other_windows): Remove. Deleting other windows is
70 handled by window.el.
71 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
72 handled in window.el.
73 (window_min_size_2, window_min_size_1, window_min_size): Remove.
74 Window minimum sizes are handled in window.el.
75 (shrink_windows, size_window, set_window_height)
76 (set_window_width, change_window_heights, window_height)
77 (window_width, CURBEG, CURSIZE, enlarge_window)
78 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
79 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
80 handled in window.el.
81 (make_dummy_parent): Rename to make_parent_window and give it a
82 second argument horflag.
83 (make_window): Don't set resize_proportionally any more.
84 (Fsplit_window): Remove. Windows are split in window.el.
85 (save_restore_action, save_restore_orig_size)
86 (shrink_window_lowest_first, save_restore_orig_size): Remove.
87 Resize mini windows in window.el.
88 (grow_mini_window, shrink_mini_window): Implement by calling
89 Qresize_root_window_vertically, resize_window_check and
90 resize_window_apply.
91 (saved_window, Fset_window_configuration, save_window_save): Do
92 not handle orig_top_line, orig_total_lines, and
93 resize_proportionally.
94 (window_min_height, window_min_width): Move to window.el.
95 (keys_of_window): Move bindings for delete-other-windows,
96 split-window, delete-window and enlarge-window to window.el.
97
98 * buffer.c: Temporarily extern Qdelete_window.
99 (Fbury_buffer): Temporarily call Qdelete_window instead of
100 Fdelete_window (Fbury_buffer will move to window.el soon).
101
102 * frame.c (set_menu_bar_lines_1): Remove code handling
103 orig_top_line and orig_total_lines.
104
105 * dispnew.c (adjust_frame_glyphs_initially): Don't use
106 set_window_height but set heights directly.
107 (change_frame_size_1): Use resize_frame_windows.
108
109 * xdisp.c (init_xdisp): Don't use set_window_height but set
110 heights directly.
111
112 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
113 resize_frame_windows instead of change_window_heights and run
114 run_window_configuration_change_hook.
115
116 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
117 instead of change_window_heights and run
118 run_window_configuration_change_hook.
119
1a13852e
MR
1202011-06-09 Martin Rudalics <rudalics@gmx.at>
121
122 * window.c (replace_window): Rename second argument REPLACEMENT to
123 NEW. New third argument SETFLAG. Rewrite.
124 (delete_window, make_dummy_parent): Call replace_window with
125 third argument 1.
126 (window_list_1): Move down in code.
127 (run_window_configuration_change_hook): Move set_buffer part
128 before select_frame_norecord part in order to unwind correctly.
129 Rename count1 to count.
130 (recombine_windows, delete_deletable_window, resize_root_window)
131 (Fdelete_other_windows_internal)
132 (Frun_window_configuration_change_hook, make_parent_window)
133 (resize_window_check, resize_window_apply, Fresize_window_apply)
134 (resize_frame_windows, Fsplit_window_internal)
135 (Fdelete_window_internal, Fresize_mini_window_internal): New
136 functions.
137 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
138
f3d1777e
MR
1392011-06-08 Martin Rudalics <rudalics@gmx.at>
140
496e208e
MR
141 * window.h (window): Add some new members to window structure -
142 normal_lines, normal_cols, new_total, new_normal, clone_number,
143 splits, nest, prev_buffers, next_buffers.
144 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 145 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 146
f3d1777e
MR
147 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
148 Remove.
496e208e
MR
149 (make_dummy_parent): Set new members of windows structure.
150 (make_window): Move down in code. Handle new members of window
151 structure.
152 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
153 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
154 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
155 (Fset_window_prev_buffers, Fwindow_next_buffers)
156 (Fset_window_next_buffers, Fset_window_clone_number): New
157 functions.
158 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
159 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
160 Doc-string fixes.
161 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
162 Argument WINDOW can be now internal window too.
163 (Fwindow_use_time): Move up in code.
164 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
165 Rewrite doc-string.
166 (Fset_window_configuration, saved_window)
167 (Fcurrent_window_configuration, save_window_save): Handle new
168 members of window structure.
b9e809c2
MR
169 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
170 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
171 (syms_of_window): New Lisp objects Qrecord_window_buffer,
172 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
173 Qget_mru_window, Qresize_root_window,
174 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
175 Qauto_buffer_name; staticpro them.
f3d1777e 176
abde8f8c
MR
1772011-06-07 Martin Rudalics <rudalics@gmx.at>
178
179 * window.c (Fwindow_total_size, Fwindow_left_column)
180 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
181 (Fwindow_list_1): New functions.
182 (window_box_text_cols): Replace with window_body_cols.
183 (Fwindow_width, Fscroll_left, Fscroll_right): Use
184 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
185 (delete_window, Fset_window_configuration): Call
186 delete_all_subwindows with window as argument.
187 (delete_all_subwindows): Take a window as argument and not a
188 structure. Rewrite.
190b47e6
MR
189 (window_loop): Remove handling of GET_LRU_WINDOW and
190 GET_LARGEST_WINDOW.
191 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
192
193 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
194 window_box_text_cols. delete_all_subwindows now takes a
195 Lisp_Object as argument.
abde8f8c
MR
196
197 * indent.c (compute_motion, Fcompute_motion): Use
198 window_body_cols instead of window_box_text_cols.
199
fa8a67e6
MR
200 * frame.c (delete_frame): Call delete_all_subwindows with root
201 window as argument.
202
a54e3482
DC
2032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
204
205 * fns.c (Fputhash): Document return value.
206
60002bf5
CY
2072011-06-06 Chong Yidong <cyd@stupidchicken.com>
208
209 * image.c (gif_load): Implement gif89a spec "no disposal" method.
210
0c671da6 2112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 212
b862a52a 213 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 214
be44ca6c
PE
215 Check for overflow when converting integer to cons and back.
216 * charset.c (Fdefine_charset_internal, Fdecode_char):
217 Use cons_to_unsigned to catch overflow.
218 (Fencode_char): Use INTEGER_TO_CONS.
219 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
220 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
221 * data.c (long_to_cons, cons_to_long): Remove.
222 (cons_to_unsigned, cons_to_signed): New functions.
223 These signal an error for invalid or out-of-range values.
224 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
225 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
226 * font.c (Ffont_variation_glyphs):
227 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
228 * lisp.h: Include <intprops.h>.
229 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
230 (cons_to_signed, cons_to_unsigned): New decls.
231 (long_to_cons, cons_to_long): Remove decls.
232 * undo.c (record_first_change): Use INTEGER_TO_CONS.
233 (Fprimitive_undo): Use CONS_TO_INTEGER.
234 * xfns.c (Fx_window_property): Likewise.
235 * xselect.c: Include <limits.h>.
236 (x_own_selection, selection_data_to_lisp_data):
237 Use INTEGER_TO_CONS.
238 (x_handle_selection_request, x_handle_selection_clear)
239 (x_get_foreign_selection, Fx_disown_selection_internal)
240 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
241 (lisp_data_to_selection_data): Use cons_to_unsigned.
242 (x_fill_property_data): Use cons_to_signed.
243 Report values out of range.
244
d1f3d2af
PE
245 Check for buffer and string overflow more precisely.
246 * buffer.h (BUF_BYTES_MAX): New macro.
247 * lisp.h (STRING_BYTES_MAX): New macro.
248 * alloc.c (Fmake_string):
249 * character.c (string_escape_byte8):
250 * coding.c (coding_alloc_by_realloc):
251 * doprnt.c (doprnt):
252 * editfns.c (Fformat):
253 * eval.c (verror):
254 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
255 since they may not be the same number.
256 * editfns.c (Finsert_char):
257 * fileio.c (Finsert_file_contents):
258 Likewise for BUF_BYTES_MAX.
259
dd52fcea
PE
260 * image.c: Use ptrdiff_t, not int, for sizes.
261 (slurp_file): Switch from int to ptrdiff_t.
262 All uses changed.
263 (slurp_file): Check that file size fits in both size_t (for
264 malloc) and ptrdiff_t (for sanity and safety).
265
7f9bbdbb
PE
266 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
267 if b->modtime has its maximal value.
268
dfe18f82
PE
269 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
270
84acfcf0
PE
271 Don't assume time_t can fit into int.
272 * buffer.h (struct buffer.modtime): Now time_t, not int.
273 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
274 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
275
ccd9a01a
PE
276 Minor fixes for signed vs unsigned integers.
277 * character.h (MAYBE_UNIFY_CHAR):
278 * charset.c (maybe_unify_char):
279 * keyboard.c (read_char, reorder_modifiers):
280 XINT -> XFASTINT, since the integer must be nonnegative.
281 * ftfont.c (ftfont_spec_pattern):
282 * keymap.c (access_keymap, silly_event_symbol_error):
283 XUINT -> XFASTINT, since the integer must be nonnegative.
284 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
285 since it makes no difference and we prefer signed.
286 * keyboard.c (record_char): Use XUINT when all the neighbors do.
287 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
288 nonnegative.
289
d6d100dd
SM
2902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
291
292 * window.h (Fwindow_frame): Declare.
293
2b6148e4
PE
2942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
295
296 * alloc.c: Simplify handling of large-request failures (Bug#8800).
297 (SPARE_MEMORY): Always define.
298 (LARGE_REQUEST): Remove.
299 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
300
f230ecc9
MR
3012011-06-06 Martin Rudalics <rudalics@gmx.at>
302
727e958e
MR
303 * lisp.h: Move EXFUNS for Fframe_root_window,
304 Fframe_first_window and Fset_frame_selected_window to window.h.
305
306 * window.h: Move EXFUNS for Fframe_root_window,
307 Fframe_first_window and Fset_frame_selected_window here from
308 lisp.h.
309
310 * frame.c (Fwindow_frame, Fframe_first_window)
311 (Fframe_root_window, Fframe_selected_window)
312 (Fset_frame_selected_window): Move to window.c.
313 (Factive_minibuffer_window): Move to minibuf.c.
314 (Fother_visible_frames_p): New function.
315
316 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
317
f230ecc9
MR
318 * window.c (decode_window, decode_any_window): Move up in code.
319 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
320 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
321 (Fwindow_buffer): Move up and rewrite doc-string.
322 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
323 (Fwindow_prev): New functions.
727e958e
MR
324 (Fwindow_frame): Move here from frame.c. Accept any window as
325 argument.
326 (Fframe_root_window, Fframe_first_window)
327 (Fframe_selected_window): Move here from frame.c. Accept frame
328 or arbitrary window as argument. Update doc-strings.
329 (Fminibuffer_window): Move up in code.
330 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
331 (Fset_frame_selected_window): Move here from frame.c.
332 Marginal rewrite.
727e958e
MR
333 (Fselected_window, select_window, Fselect_window): Move up in
334 code. Minor doc-string fixes.
f230ecc9 335
4d09bcf6
PE
3362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
337
338 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
339 Do not assume that spare memory exists; that assumption is valid
340 only if SYSTEM_MALLOC.
341 (LARGE_REQUEST): New macro, so that the issue of large requests
342 is separated from the issue of spare memory.
343
810928a2
AS
3442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
345
172418ad
AS
346 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
347 format. (Bug#8806)
348
43f862f7
AS
349 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
350
810928a2
AS
351 * xfns.c (x_set_scroll_bar_default_width): Move declarations
352 before statements.
353
a059fe24
JD
3542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
355
356 * gtkutil.c (xg_get_default_scrollbar_width): New function.
357
358 * gtkutil.h: Declare xg_get_default_scrollbar_width.
359
360 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
361 min width by calling x_set_scroll_bar_default_width (Bug#8505).
362
989bf368
JB
3632011-06-05 Juanma Barranquero <lekktu@gmail.com>
364
365 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
366
4b80f674
CY
3672011-06-04 Chong Yidong <cyd@stupidchicken.com>
368
369 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
370 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
371 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
372 New error handlers.
4b80f674
CY
373 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
374 Obey Vx_select_enable_clipboard_manager. Catch errors in
375 x_clipboard_manager_save (Bug#8779).
376 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 377 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 378
99a33b77 3792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
380
381 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
382
99a33b77 3832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
384
385 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
386 in the current matrix if keep_current_p is non-zero.
387
8264569d
EZ
3882011-06-04 Eli Zaretskii <eliz@gnu.org>
389
390 * bidi.c (bidi_level_of_next_char): Fix last change.
391
57f97249
EZ
3922011-06-03 Eli Zaretskii <eliz@gnu.org>
393
fec2107c 394 Support bidi reordering of text covered by display properties.
57f97249 395
fec2107c
EZ
396 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
397 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
398 (bidi_cache_search, bidi_cache_iterator_state)
399 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
400 (bidi_level_of_next_char, bidi_move_to_visually_next):
401 Support character positions inside a run of characters covered by a
fec2107c
EZ
402 display string.
403 (bidi_paragraph_init, bidi_resolve_explicit_1)
404 (bidi_level_of_next_char): Call bidi_fetch_char and
405 bidi_fetch_char_advance instead of FETCH_CHAR and
406 FETCH_CHAR_ADVANCE.
407 (bidi_init_it): Initialize new members.
408 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
409 definitions.
410 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
411 instead of using explicit *_CHAR codes.
d6d100dd
SM
412 (bidi_resolve_explicit, bidi_resolve_weak):
413 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
414 bidirectional text is supported only in multibyte buffers.
415 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
416 it to initialize the frame_window_p member of struct bidi_it.
417 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
418 (bidi_resolve_explicit, bidi_resolve_weak)
419 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
420 bidi_it->nchars is non-positive.
421 (bidi_level_of_next_char): Don't try to lookup the cache for the
422 next/previous character if nothing is cached there yet, or if we
423 were just reseat()'ed to a new position.
c40e2fb2 424
0e14fe90
EZ
425 * xdisp.c (set_cursor_from_row): Set start and stop points
426 according to the row's direction when priming the loop that looks
427 for the glyph on which to display cursor.
428 (single_display_spec_intangible_p): Function deleted.
429 (display_prop_intangible_p): Reimplement to call
430 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
431 Accept 3 additional arguments needed by handle_display_spec.
432 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
433 values: lists, `(when COND...)' forms, etc.
434 (single_display_spec_string_p): Support property values that are
435 lists with the argument STRING its top-level element.
436 (display_prop_string_p): Fix the condition for processing a
437 property that is a list to be consistent with handle_display_spec.
fec2107c 438 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
439 last portion of handle_display_prop.
440 (compute_display_string_pos): Accept additional argument
441 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
442 value of a `display' property is a "replacing spec".
443 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
444 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
445 the display property, but just return a value indicating whether
446 the display property will replace the characters it covers.
447 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
448 frame_window_p members of struct bidi_it.
d6d100dd
SM
449 (compute_display_string_pos, compute_display_string_end):
450 New functions.
fec2107c
EZ
451 (push_it): Accept second argument POSITION, where pop_it should
452 jump to continue iteration.
453 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 454
fec2107c
EZ
455 * keyboard.c (adjust_point_for_property): Adjust the call to
456 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
457
458 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
459 (bidi_init_it): Update prototypes.
460 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
461 (compute_display_string_pos, compute_display_string_end):
462 Declare prototypes.
fec2107c
EZ
463 (struct bidi_it): New members nchars and disp_pos. ch_len is now
464 EMACS_INT.
fc6f18ce 465
40087514 4662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 467
57f53182
PE
468 Malloc failure behavior now depends on size of allocation.
469 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
470 * lisp.h: Change signatures accordingly.
471 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
472 All callers changed. (Bug#8762)
473
474 * gnutls.c: Use Emacs's memory allocators.
475 Without this change, the gnutls library would invoke malloc etc.
476 directly, which causes problems on non-SYNC_INPUT hosts, and which
477 runs afoul of improving memory_full behavior. (Bug#8761)
478 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
479 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
480 xfree instead of the default malloc, realloc, free.
481 (Fgnutls_boot): No need to check for memory allocation failure,
482 since xmalloc does that for us.
483
ac32cd99 484 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
485 * category.c (hash_get_category_set):
486 * ccl.c (ccl_driver):
487 * charset.c (Fdefine_charset_internal):
488 * charset.h (struct charset.hash_index):
489 * composite.c (get_composition_id, gstring_lookup_cache)
490 (composition_gstring_put_cache):
491 * composite.h (struct composition.hash_index):
492 * dispextern.h (struct image.hash):
493 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
494 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
495 (hashfn_equal, hashfn_user_defined, make_hash_table)
496 (maybe_resize_hash_table, hash_lookup, hash_put)
497 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
498 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
499 (Fsxhash, Fgethash, Fputhash, Fmaphash):
500 * image.c (make_image, search_image_cache, lookup_image)
501 (xpm_put_color_table_h):
502 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 503 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
504 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
505 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
506 * alloc.c (allocate_vectorlike):
507 Check for overflow in vector size calculations.
508 * ccl.c (ccl_driver):
509 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
510 * fns.c, image.c: Remove unnecessary static decls that would otherwise
511 need to be updated by these changes.
40087514
PE
512 * fns.c (make_hash_table, maybe_resize_hash_table):
513 Check for integer overflow with large hash tables.
0de4bb68
PE
514 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
515 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
516 (SXHASH_REDUCE): New macro.
517 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
518 Use it instead of discarding useful hash info with large hash values.
519 (sxhash_float): New function.
520 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
521 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
522 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
523 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
524 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
525 Adjust signatures to match updated version of code.
526 (consing_since_gc): Now EMACS_INT, since a single hash table can
527 use more than INT_MAX bytes.
528
698d32e2
DN
5292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
530
531 Make it possible to build with GCC-4.6+ -O2 -flto.
532
533 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
534
fd6fa53f
SM
5352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
536
537 * minibuf.c (get_minibuffer, read_minibuf_unwind):
538 Call minibuffer-inactive-mode.
539
864db017
JB
5402011-05-31 Juanma Barranquero <lekktu@gmail.com>
541
542 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
543 Update dependencies.
544
2ad0baf4
DN
5452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
546
547 * data.c (init_data): Remove code for UTS, this system is not
548 supported anymore.
549
4fcc2638
DN
5502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
551
552 Don't force ./temacs to start in terminal mode.
553
554 * frame.c (make_initial_frame): Initialize faces in all cases, not
555 only when CANNOT_DUMP is defined.
556 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
557
c56e0fd5
DN
5582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
559
560 * dispnew.c (add_window_display_history): Use const for the string
561 pointer. Remove declaration, not needed.
562
333d54da 5632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 564
55d4c1b2 565 Use 'inline', not 'INLINE'.
333d54da 566 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
567 * alloc.c, fontset.c (INLINE): Remove.
568 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
569 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
570 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
571 * gmalloc.c (register_heapinfo): Use inline unconditionally.
572 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
573
738db178
DN
5742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
575
576 Make it possible to run ./temacs.
577
578 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
579 syms_of_callproc does the same thing. Remove test for
580 "initialized", do it in the caller.
581 * emacs.c (main): Avoid calling set_initial_environment when dumping.
582
620c53a6
SM
5832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
584
585 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
586 (read_minibuf): Use get_minibuffer.
587 (syms_of_minibuf): Use DEFSYM.
588 (Qmetadata): New var.
589 * data.c (Qbuffer): Don't make it static.
590 (syms_of_data): Use DEFSYM.
591
e003a292
PE
5922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
593
594 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
595 (CCL_CODE_MIN): New macro.
596
ed008a6d
PE
5972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
598
3687c2ef
PE
599 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
600
ed008a6d
PE
601 * eval.c (Qdebug): Now static.
602 * lisp.h (Qdebug): Remove decl. This reverts a part of the
603 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
604 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
605
d66c4c7c
CY
6062011-05-29 Chong Yidong <cyd@stupidchicken.com>
607
608 * image.c: Various fixes to ImageMagick code comments.
609 (Fimagemagick_types): Doc fix.
610
5fbc2025
PE
6112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
612
0196f88a
PE
613 Minor fixes prompted by GCC 4.6.0 warnings.
614
615 * xselect.c (converted_selections, conversion_fail_tag): Now static.
616
5fbc2025
PE
617 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
618 (x_clipboard_manager_save_all): Move extern decl to ...
619 * xterm.h: ... here, so that it can be checked for consistency.
620
1dd3c2d9
CY
6212011-05-29 Chong Yidong <cyd@stupidchicken.com>
622
623 * xselect.c (x_clipboard_manager_save_frame)
624 (x_clipboard_manager_save_all): New functions.
625 (Fx_clipboard_manager_save): Lisp function deleted.
626
627 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
628 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
629
630 * xterm.h: Update prototype.
631
5ba6571d
WX
6322011-05-28 William Xu <william.xwl@gmail.com>
633
634 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
635 exiting (Bug#8239).
636
3eaff834
JM
6372011-05-28 Jim Meyering <meyering@redhat.com>
638
e1900994 639 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
640 * fns.c (to_uchar): Define.
641 (crypto_hash_function): Use it to convert some newly-signed
642 variables to unsigned, to avoid sign-extension bugs. For example,
643 without this change, (md5 "truc") would evaluate to
644 45723a2aff78ff4fff7fff1114760e62 rather than the expected
645 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 646 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 647
0f6990a7
PE
6482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
649
650 Integer overflow fixes.
c8a9ca5a 651
08686060
PE
652 * dbusbind.c: Serial number integer overflow fixes.
653 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
654 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
655 to hold a serial number that is too large for a fixnum.
656 (Fdbus_method_return_internal, Fdbus_method_error_internal):
657 Check for serial numbers out of range. Decode any serial number
59568bf0 658 that was so large that it became a float. (Bug#8722)
08686060 659
2d1fc3c7
PE
660 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
661 (Fdbus_call_method, Fdbus_call_method_asynchronously):
662 Use XFASTINT rather than XUINT when numbers are nonnegative.
663 (xd_append_arg, Fdbus_method_return_internal):
664 (Fdbus_method_error_internal): Likewise. Also, for unsigned
665 arguments, check that Lisp number is nonnegative, rather than
59568bf0 666 silently wrapping negative numbers around. (Bug#8722)
30217ff0 667 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 668 (Bug#8722)
2d1fc3c7 669
c8a9ca5a
PE
670 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
671
519e1d69
PE
672 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
673
30569699
PE
674 ccl: add integer overflow checks
675 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
676 (IN_INT_RANGE): New macros.
677 (ccl_driver): Use them to check for integer overflow when
678 decoding a CCL program. Many of the new checks are whether XINT (x)
679 fits in int; it doesn't always, on 64-bit hosts. The new version
680 doesn't catch all possible integer overflows, but it's an
847044ea 681 improvement. (Bug#8719)
30569699 682
c11285dc
PE
683 * alloc.c (make_event_array): Use XINT, not XUINT.
684 There's no need for unsigned here.
685
fdccd48e
PE
686 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
687 This follows up to the 2011-05-06 change that substituted uintptr_t
688 for EMACS_INT. This case wasn't caught back then.
689
37910ab2
PE
690 Rework Fformat to avoid integer overflow issues.
691 * editfns.c: Include <float.h> unconditionally, as it's everywhere
692 now (part of C89). Include <verify.h>.
693 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
694 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
695 (Fformat): Avoid the prepass trying to compute sizes; it was only
696 approximate and thus did not catch overflow reliably. Instead, walk
697 through the format just once, formatting and computing sizes as we go,
698 checking for integer overflow at every step, and allocating a larger
699 buffer as needed. Keep track separately whether the format is
700 multibyte. Keep only the most-recently calculated precision, rather
701 than them all. Record whether each argument has been converted to
702 string. Use EMACS_INT, not int, for byte and char and arg counts.
703 Support field widths and precisions larger than INT_MAX. Avoid
704 sprintf's undefined behavior with conversion specifications such as %#d
705 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
706 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
707 formatting out-of-range floating point numbers with int
708 formats. (Bug#8668)
709
2e6578fb
PE
710 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
711
0ae6bdee
PE
712 * data.c: Avoid integer truncation in expressions involving floats.
713 * data.c: Include <intprops.h>.
714 (arith_driver): When there's an integer overflow in an expression
715 involving floating point, convert the integers to floating point
716 so that the resulting value does not suffer from catastrophic
717 integer truncation. For example, on a 64-bit host (* 4
718 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
719 Do not rely on undefined behavior after integer overflow.
720
de883a70
PE
721 merge count_size_as_multibyte, parse_str_to_multibyte
722 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 723 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
724 Check for integer overflow.
725 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
726 since it's now a duplicate of the other. This is more of
727 a character than a buffer op, so better that it's in character.c.
728 * fns.c, print.c: Adjust to above changes.
729
2ff916cb
PE
7302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
731
732 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
733
f1b54466
PE
7342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
735
fb1ac845
PE
736 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
737 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
738 (x_clipboard_manager_save): Now static.
739 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
740
f1b54466
PE
741 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
742 (crypto_hash_function): Now static.
743 Fix pointer signedness problems. Avoid unnecessary initializations.
744
a9f737ee
CY
7452011-05-27 Chong Yidong <cyd@stupidchicken.com>
746
747 * termhooks.h (Vselection_alist): Make it terminal-local.
748
749 * terminal.c (create_terminal): Initialize it.
750
751 * xselect.c: Support for clipboard managers.
752 (Vselection_alist): Move to termhooks.h as terminal-local var.
753 (LOCAL_SELECTION): New macro.
754 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
755 (symbol_to_x_atom): Remove gratuitous arg.
756 (x_handle_selection_request, lisp_data_to_selection_data)
757 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
758 (x_own_selection, x_get_local_selection, x_convert_selection):
759 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
760 (some_frame_on_display): Delete unused function.
761 (Fx_own_selection_internal, Fx_get_selection_internal)
762 (Fx_disown_selection_internal, Fx_selection_owner_p)
763 (Fx_selection_exists_p): New optional frame arg.
764 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
765 (x_handle_selection_clear): Don't treat other terminals with the
766 same keyboard specially. Use the terminal-local Vselection_alist.
767 (x_clear_frame_selections): Use Frun_hook_with_args.
768
769 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
770
771 * xterm.h: Add support for those atoms.
772
e067f0c1
CY
7732011-05-26 Chong Yidong <cyd@stupidchicken.com>
774
775 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
776 (converted_selections, conversion_fail_tag): New global variables.
777 (x_selection_request_lisp_error): Free the above.
778 (x_get_local_selection): Remove unnecessary code.
779 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
780 of converted selections stored in converted_selections.
781 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
782 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
783 (x_convert_selection): New function.
784 (x_handle_selection_event): Simplify.
785 (x_get_foreign_selection): Don't ignore incoming requests while
786 waiting for an answer; this will fail when we implement
787 SAVE_TARGETS, and seems unnecessary anyway.
788 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
789 (Vx_sent_selection_functions): Doc fix.
790
0f4aebc0
LL
7912011-05-26 Leo Liu <sdl.web@gmail.com>
792
793 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
794
e61124cd
YM
7952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
796
797 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
798
799 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
800 for fringe update if it has periodic bitmap.
801 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
802 and fringe_bitmap_periodic_p.
803
804 * fringe.c (get_fringe_bitmap_data): New function.
805 (draw_fringe_bitmap_1, update_window_fringes): Use it.
806 (update_window_fringes): Record periodicity of fringe bitmap in glyph
807 row. Mark glyph row for fringe update if periodicity changed.
808
809 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
810 for fringe update unless it has periodic bitmap.
811
f16d9837
KH
8122011-05-25 Kenichi Handa <handa@m17n.org>
813
814 * xdisp.c (get_next_display_element): Set correct it->face_id for
815 a static composition.
816
e1b90ef6
LL
8172011-05-24 Leo Liu <sdl.web@gmail.com>
818
819 * deps.mk (fns.o):
820 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
821
822 * fns.c (crypto_hash_function, Fsha1): New function.
823 (Fmd5): Use crypto_hash_function.
824 (syms_of_fns): Add Ssha1.
825
7400048f
PE
8262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
827
828 * gnutls.c: Remove unused macros.
829 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
830 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
831 Remove macros that are defined and never used.
832 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
833
abb71cf4
CY
8342011-05-22 Chong Yidong <cyd@stupidchicken.com>
835
836 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
837 (Fx_get_selection_internal): Minor cleanup.
838 (Fx_own_selection_internal): Rename arguments for consistency with
839 select.el.
840
6307db39
PE
8412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
842
843 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
844
f3d4e0a4
CY
8452011-05-22 Chong Yidong <cyd@stupidchicken.com>
846
847 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
848
4d8ade89
YM
8492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
850
851 * dispnew.c (scrolling_window): Don't exclude the case that the
852 last enabled row in the desired matrix touches the bottom boundary.
853
32078c8d
GM
8542011-05-21 Glenn Morris <rgm@gnu.org>
855
856 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
857 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
858 and add some more files.
32078c8d 859
7285dc67
EZ
8602011-05-20 Eli Zaretskii <eliz@gnu.org>
861
862 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
863 report_file_error introduced by the change from 2011-05-07.
864
89d1bd22
PE
8652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
866
867 * systime.h (Time): Define only if emacs is defined.
868 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
869 where the include path doesn't have X11/X.h by default. See
870 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
871
e23640bb 8722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
873
874 * composite.c (find_automatic_composition): Fix previous change.
875
b9704ad9
GM
8762011-05-20 Glenn Morris <rgm@gnu.org>
877
878 * lisp.mk: New file, split from Makefile.in.
879 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
880 (shortlisp): Remove.
881 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
882
4a720484
GM
8832011-05-19 Glenn Morris <rgm@gnu.org>
884
885 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
886 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
887 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
888 (lisp): Set the order to that of loadup.el.
889 (shortlisp): Make it a copy of $lisp.
890 (SOME_MACHINE_LISP): Remove.
891 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
892 Use just $shortlisp, not $SOME_MACHINE_LISP too.
893
a28d4396
KH
8942011-05-18 Kenichi Handa <handa@m17n.org>
895
896 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
897 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
898 (find_automatic_composition): Mostly rewrite for efficiency.
899
a2b1fa8e
JB
9002011-05-18 Juanma Barranquero <lekktu@gmail.com>
901
902 * makefile.w32-in: Update dependencies.
903
8e1f5610
CS
9042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
905
906 * menu.c: Include limits.h (fixes the MS-Windows build broken by
907 revision 104625).
908
7025ee00 9092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 910
cdfa6eab
PE
911 Fix some integer overflow issues, such as string length overflow.
912
06d6db33
PE
913 * insdel.c (count_size_as_multibyte): Check for string overflow.
914
2b4560a8
PE
915 * character.c (lisp_string_width): Check for string overflow.
916 Use EMACS_INT, not int, for string indexes and lengths; in
917 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
918 the resulting string length overflows an EMACS_INT; instead,
919 report a string overflow if no precision given. When checking for
920 precision exhaustion, use a check that cannot possibly have
921 integer overflow. (Bug#8675)
922 * character.h (lisp_string_width): Adjust to new signature.
923
cb93f9be
PE
924 * alloc.c (string_overflow): New function.
925 (Fmake_string): Use it. This doesn't change behavior, but saves
926 a few bytes and will simplify future changes.
927 * character.c (string_escape_byte8): Likewise.
928 * lisp.h (string_overflow): New decl.
929
1a1f3366
PE
930 Fixups, following up to the user-interface timestamp change.
931 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
932 for UI timestamps, instead of unsigned long.
9fbd6841
PE
933 * msdos.c (mouse_get_pos): Likewise.
934 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
935 * w32gui.h (Time): Define by including "systime.h" rather than by
936 declaring it ourselves. (Bug#8664)
937
d4e3e4d3
PE
938 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
939 * image.c (clear_image_cache): Likewise.
940
f6a24d19
PE
941 * term.c (term_mouse_position): Don't assume time_t wraparound.
942
08dc5ae6
PE
943 Be more systematic about user-interface timestamps.
944 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
945 and sometimes 'EMACS_UINT', to represent these timestamps.
946 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
947 This makes the code easier to follow, and makes it easier to catch
948 integer overflow bugs such as Bug#8664.
949 * frame.c (Fmouse_position, Fmouse_pixel_position):
950 Use Time, not unsigned long, for user-interface timestamps.
951 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
952 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
953 * keyboard.h (last_event_timestamp): Likewise.
954 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
955 * menu.h (xmenu_show): Likewise.
956 * term.c (term_mouse_position): Likewise.
957 * termhooks.h (struct input_event.timestamp): Likewise.
958 (struct terminal.mouse_position_hook): Likewise.
959 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
960 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
961 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
962 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
963 what it was before.
964 * menu.h, termhooks.h: Include "systime.h", for Time.
965
8e55734a
PE
966 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
967 Don't assume that the difference between two unsigned long values
968 can fit into an integer. At this point, we know button_down_time
969 <= event->timestamp, so the difference must be nonnegative, so
970 there's no need to cast the result if double-click-time is
971 nonnegative, as it should be; check that it's nonnegative, just in
972 case. This bug is triggered when events are more than 2**31 ms
86db42d2 973 apart (about 25 days). (Bug#8664)
8e55734a 974
841f1b75 975 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 976 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 977
3e26f69c
PE
978 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
979 that always fit in int. Use a sentinel instead of a counter, to
980 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
981 * frame.h (struct frame): Use int for menu_bar_items_used
982 instead of EMACS_INT, since it always fits in int.
3e26f69c 983
5cc152c0
PE
984 * menu.c (grow_menu_items): Check for int overflow.
985
d89eb65e
PE
986 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
987
5235bd3e
PE
988 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
989 Before, the code was not consistent. These values cannot exceed
990 2**31 - 1 so there's no need to make them unsigned.
991 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
992 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
993 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
994 as modifiers.
995 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
996
bc827e23
PE
997 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
998 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
999 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1000 presumably because the widths might not match.
1001
78eb494e
PE
1002 * window.c (size_window): Avoid needless test at loop start.
1003
04f2d78b
CB
10042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1005
1006 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1007
d2fc7e3d 10082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1009
1010 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1011
d2fc7e3d 10122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1013
1014 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1015 `width' to `bar_area_x' and `bar_area_width', respectively.
1016 (x_scroll_run): Take account of fringe background extension.
1017
04f2d78b
CB
1018 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1019 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1020 `bar_area_width', respectively.
1021 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1022 background extension.
1023
79b70037
GM
10242011-05-10 Jim Meyering <meyering@redhat.com>
1025
1026 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1027
2f142cc5
JB
10282011-05-10 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * image.c (Finit_image_library): Return t for built-in image types,
1031 like pbm and xbm. (Bug#8640)
1032
57679c86
AS
10332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1034
1035 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1036
888c9e86
EZ
10372011-05-07 Eli Zaretskii <eliz@gnu.org>
1038
b0512a1d
EZ
1039 * w32console.c (Fset_screen_color): Doc fix.
1040 (Fget_screen_color): New function.
1041 (syms_of_ntterm): Defsubr it.
1042
7285dc67
EZ
1043 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1044 unlink the temporary file if Fcall_process didn't create it in the
1045 first place.
1046 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1047 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1048 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1049 cue to call_process_cleanup not to close that handle.
1050
4d3fcc8e
BK
10512011-05-07 Ben Key <bkey76@gmail.com>
1052
1053 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1054 one of two shell specific rules, either bootstrap-temacs-CMD or
1055 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1056 to the previous implementation of the bootstrap-temacs rule.
1057 The bootstrap-temacs-CMD rule is similar to the previous
1058 implementation of the bootstrap-temacs rule except that it
1059 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1060 variable.
1061
1062 These changes, along with some changes to nt/configure.bat,
1063 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1064 earlier fix to add support for --cflags and --ldflags options
1065 that include quotes so that it works whether make uses cmd or
1066 sh as the shell.
1067
b4289b64
MA
10682011-05-06 Michael Albinus <michael.albinus@gmx.de>
1069
1070 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1071 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1072 is a constant.
1073 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1074 a string. Handle both cases.
1075 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1076 (Fdbus_register_method): Use Qinvalid_function.
1077
af4c0e28
JB
10782011-05-06 Juanma Barranquero <lekktu@gmail.com>
1079
1080 * makefile.w32-in: Update dependencies.
1081 (LISP_H): Add inttypes.h and stdin.h.
1082 (PROCESS_H): Add unistd.h.
1083
c51453d9
EZ
10842011-05-06 Eli Zaretskii <eliz@gnu.org>
1085
1086 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1087 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1088
8ff0ac3c 10892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1090
4c4b566b
PE
1091 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1092
aab2b9b5
PE
1093 * term.c (vfatal): Remove stray call to va_end.
1094 It's not needed and the C Standard doesn't allow it here anyway.
1095
c378da0b
PE
1096 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1097 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1098
288b08c7
PE
1099 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1100 bytes.
1101
e3601888
PE
1102 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1103
db6c0e74
PE
1104 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1105
dd5963ea
PE
1106 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1107
88c9450f
PE
1108 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1109
2f9442b8
PE
1110 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1111
c032b5f8
PE
1112 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1113 * charset.c (Fdefine_charset_internal): Don't initialize
1114 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1115 32-bit int (Bug#8600).
a108c10b
PE
1116
1117 * lread.c (read_integer): Be more consistent with string-to-number.
1118 Use string_to_number to do the actual conversion; this avoids
1119 rounding errors and fixes some other screwups. Without this fix,
1120 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1121 (digit_to_number): Move earlier, for benefit of read_integer.
1122 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1123 not a digit in any supported base. (Bug#8602)
a108c10b 1124
ad5f9eea
PE
1125 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1126
aec1708a
PE
1127 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1128 to match comment at start of function. This also removes a
1129 GCC warning about overflow in a 32+64-bit port.
1130
47be4ab5
PE
1131 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1132
371cac43
PE
1133 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1134 Reported by Stefan Monnier in
1135 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1136 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1137 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1138
d01a7826
PE
1139 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1140 (EMACS_UINTPTR): Likewise, with uintptr_t.
1141
7fd47d5c
PE
1142 * lisp.h: Prefer 64-bit EMACS_INT if available.
1143 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1144 on 32-bit hosts that have 64-bit int, so that they can access
1145 large files.
122b0c86
PE
1146 However, temporarily disable this change unless the temporary
1147 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1148
8727937b
PE
1149 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1150
8ac068ac
PE
1151 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1152 This removes an assumption that EMACS_INT and long are the same
1153 width as pointers. The assumption is true for Emacs porting targets
1154 now, but we want to make other targets possible.
1155 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1156 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1157 In the rest of the code, change types of integers that hold casted
1158 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1159 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1160 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1161 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1162 No need to cast type when ORing.
1163 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1164 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1165 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1166 assume EMACS_INT is the same width as char *.
1167 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1168 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1169 Remove no-longer-needed casts.
1170 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1171 (xg_tool_bar_help_callback, xg_make_tool_item):
1172 Use EMACS_INTPTR to hold an integer
1173 that will be cast to void *; this can avoid a GCC warning
1174 if EMACS_INT is not the same width as void *.
1175 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1176 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1177 (current_message_1, set_message_1):
1178 Use a local to convert to proper width without a cast.
1179 * xmenu.c (dialog_selection_callback): Likewise.
1180
ede49d71
PE
1181 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1182 Also, don't assume VALBITS / RAND_BITS is less than 5,
1183 and don't rely on undefined behavior when shifting a 1 left into
1184 the sign bit.
1185 * lisp.h (get_random): Change signature to match.
1186
2f30ecd0
PE
1187 * lread.c (hash_string): Use size_t, not int, for hash computation.
1188 Normally we prefer signed values; but hashing is special, because
1189 it's better to use unsigned division on hash table sizes so that
1190 the remainder is nonnegative. Also, size_t is the natural width
1191 for hashing into memory. The previous code used 'int', which doesn't
1192 retain enough info to hash well into very large tables.
1193 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1194
2a866e7b
PE
1195 * dbusbind.c: Don't possibly lose pointer info when converting.
1196 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1197 Use XPNTR rather than XHASH, so that the high-order bits of
1198 the pointer aren't lost when converting through void *.
1199
51639eac
PE
1200 * eval.c (Fautoload): Don't double-shift a pointer.
1201
92394119
PE
1202 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1203
dbdb9a7c
JB
12042011-05-06 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * gnutls.c (DEF_GNUTLS_FN):
1207 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1208
db7a0b4f
AS
12092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1210
1211 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1212 marker. (Bug#8610)
1213
f7ff1b0f 12142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1215
1216 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1217 New version that can reserve upto 2GB of heap space.
1218
f7ff1b0f 12192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1220
1221 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1222
639c109b
TZ
12232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1224
1225 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1226 `gnutls_certificate_set_x509_key_file'.
1227
d2127135
JB
12282011-05-05 Juanma Barranquero <lekktu@gmail.com>
1229
1230 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1231 Update dependencies.
1232
e968f4f3
JB
12332011-05-04 Juanma Barranquero <lekktu@gmail.com>
1234
1235 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1236 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1237 Remove unused parameter `fildes'.
1238 * process.c (read_process_output, send_process): Don't pass it.
1239
84d358f0
JB
12402011-05-04 Juanma Barranquero <lekktu@gmail.com>
1241
1242 Fix previous change: the library cache is defined in w32.c.
1243 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1244 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1245
0898ca10
JB
12462011-05-04 Juanma Barranquero <lekktu@gmail.com>
1247
1248 Implement dynamic loading of GnuTLS on Windows.
1249
1250 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1251 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1252 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1253 Declare.
1254
1255 * gnutls.c (Qgnutls_dll): Define.
1256 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1257 (gnutls_*): Declare function pointers.
1258 (init_gnutls_functions): New function to initialize function pointers.
1259 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1260 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1261 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1262 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1263 (emacs_gnutls_write, emacs_gnutls_read)
1264 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1265 (Fgnutls_available_p): New function.
1266 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1267 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1268 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1269
1270 * image.c: Include w32.h.
1271 (Vimage_type_cache): Delete.
1272 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1273 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1274 (w32_delayed_load): Move to w32.c.
1275
1276 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1277
1278 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1279 (w32_delayed_load): Move from image.c. When loading a library, record
1280 its filename in the :loaded-from property of the library id.
1281 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1282 Initialize and staticpro them.
1283 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1284
1285 * process.c: Include lisp.h before w32.h, not after.
1286 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1287 instead of gnutls_record_check_pending.
1288
1289 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1290
ff4de4aa
TZ
12912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1292
1293 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1294 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1295 as passed in.
1296
abe95abb
JD
12972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1298
1299 * xterm.c (x_set_frame_alpha): Do not set property on anything
1300 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1301
e16e55d4
JB
13022011-05-02 Juanma Barranquero <lekktu@gmail.com>
1303
1304 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1305
bafcf6a5
JB
13062011-05-02 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1309 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1310 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1311 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1312 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1313 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1314 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1315 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1316 (Qgnutls_bootprop_callbacks_verify): Make static.
1317
e7a6747f
AS
13182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1319
19ed11ba
AS
1320 * callproc.c: Indentation fixup.
1321
e7a6747f 1322 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1323 (wait_for_termination, interruptible_wait_for_termination):
1324 Move after wait_for_termination_1.
e7a6747f 1325
1ef14cb4
LMI
13262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1327
1328 * sysdep.c (interruptible_wait_for_termination): New function
1329 which is like wait_for_termination, but allows keyboard
1330 interruptions.
1331
1332 * callproc.c (Fcall_process): Add (:file "file") as an option for
1333 the STDOUT buffer.
1334 (Fcall_process_region): Ditto.
1335
330d880c
EZ
13362011-04-30 Eli Zaretskii <eliz@gnu.org>
1337
8db90b73
EZ
1338 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1339 rather than `XVECTOR (FOO)->size'.
1340
330d880c
EZ
1341 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1342 inttypes.h, as a gnulib replacement is used if it not available in
1343 system headers.
1344
15cbd324
EZ
13452011-04-21 Eli Zaretskii <eliz@gnu.org>
1346
1347 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1348 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1349 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1350
1351 * coding.c (coding_alloc_by_realloc): Error out if destination
1352 will grow beyond MOST_POSITIVE_FIXNUM.
1353 (decode_coding_emacs_mule): Abort if there isn't enough place in
1354 charbuf for the composition carryover bytes. Reserve an extra
1355 space for up to 2 characters produced in a loop.
1356 (decode_coding_iso_2022): Abort if there isn't enough place in
1357 charbuf for the composition carryover bytes.
1358
13592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1360
ae940cca
EZ
1361 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1362 aborting when %lld or %lll format is passed.
1363 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1364 %llo or %llx format is passed. (Bug#8545)
1365
03ab8921
EZ
1366 * window.c (window_scroll_line_based): Use a marker instead of
1367 simple variables to record original value of point. (Bug#7952)
1368
afda1437
EZ
1369 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1370 produced by %s or %c overflows available buffer space. (Bug#8545)
1371
f76dee0c
PE
13722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1373
1374 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1375 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1376
fdc5744d
JB
13772011-04-28 Juanma Barranquero <lekktu@gmail.com>
1378
1379 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1380
638f053a
JB
13812011-04-28 Juanma Barranquero <lekktu@gmail.com>
1382
1383 * keyboard.c (Qdelayed_warnings_hook): Define.
1384 (command_loop_1): Run `delayed-warnings-hook'
1385 if Vdelayed_warnings_list is non-nil.
1386 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1387 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1388
d178f871
EZ
13892011-04-28 Eli Zaretskii <eliz@gnu.org>
1390
1391 * doprnt.c (doprnt): Don't return value smaller than the buffer
1392 size if the message was truncated. (Bug#8545).
1393
b124fd93
JB
13942011-04-28 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1397 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1398
e810457d
PE
13992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1402
ea51cceb
JB
14032011-04-27 Juanma Barranquero <lekktu@gmail.com>
1404
1405 * makefile.w32-in: Update dependencies.
1406
94dcfacf
EZ
14072011-04-27 Eli Zaretskii <eliz@gnu.org>
1408
1409 Improve `doprnt' and its usage. (Bug#8545)
1410 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1411 `format_end'. Remove support for %l as a conversion specifier.
1412 Don't use xrealloc. Improve diagnostics when the %l size modifier
1413 is used. Update the commentary.
1414
1415 * eval.c (verror): Simplify calculation of size_t.
1416
1417 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1418 messages.
1419
f61f41d7
PE
14202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1421
1422 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1423 change.
1424
96fb4434
PE
14252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1428 This makes this file independent of the recent pseudovector change.
1429
671875da 14302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1431
69e9b5a3
PE
1432 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1433
b5f869a7 1434 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1435 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1436 Remove unused local.
c8926152 1437 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1438
841a1577 1439 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1440 GCC 4.6.0 optimizes based on type-based alias analysis.
1441 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1442 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1443 != &v->size, and therefore "v->size = 1; b->size = 2; return
1444 v->size;" must therefore return 1. This assumption is incorrect
1445 for Emacs, since it type-puns struct Lisp_Vector * with many other
1446 types. To fix this problem, this patch adds a new type struct
f904488f 1447 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1448 and pseudovectors, and helps optimizing compilers not get fooled
1449 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1450 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1451 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1452 the size member.
eab3844f
PE
1453 (XSETPVECTYPE): Rewrite in terms of new macro.
1454 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1455 This is a bit clearer, and further avoids the possibility of
1456 undesirable aliasing.
1457 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1458 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1459 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1460 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1461 (ASIZE): Now uses header.size rather than size.
1462 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1463 to avoid the hassle of writing XVECTOR (foo)->header.size.
1464 (struct vectorlike_header): New type.
eab3844f
PE
1465 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1466 object, to help avoid aliasing.
1467 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1468 (SUBRP): Likewise, since Lisp_Subr is a special case.
1469 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1470 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1471 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1472 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1473 changed to be "header.size" and "header.next".
1474 * buffer.h (struct buffer): Likewise.
1475 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1476 * frame.h (struct frame): Likewise.
1477 * process.h (struct Lisp_Process): Likewise.
1478 * termhooks.h (struct terminal): Likewise.
1479 * window.c (struct save_window_data, struct saved_window): Likewise.
1480 * window.h (struct window): Likewise.
1481 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1482 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1483 * buffer.c (init_buffer_once): Likewise.
1484 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1485 special case.
1486 * process.c (Fformat_network_address): Use local var for size,
1487 for brevity.
1488
0df1eac5
PE
1489 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1490
847ab9d1 1491 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1492 * data.c (atof): Remove decl; no longer used or needed.
1493 (digit_to_number): Move to lread.c.
1494 (Fstring_to_number): Use new string_to_number function, to be
1495 consistent with how the Lisp reader treats infinities and NaNs.
1496 Do not assume that floating-point numbers represent EMACS_INT
1497 without losing information; this is not true on most 64-bit hosts.
1498 Avoid double-rounding errors, by insisting on integers when
1499 parsing non-base-10 numbers, as the documentation specifies.
1500 * lisp.h (string_to_number): New decl, replacing ...
1501 (isfloat_string): Remove.
bc0a5c13 1502 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1503 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1504 appears to have been a coding error. Similarly, do not accept
1505 strings like +-1e0 as floating point numbers. Do not report
1506 overflow for integer overflows unless the base is not 10 which
1507 means we have no simple and reliable way to continue.
1508 Break out the floating-point parsing into a new
1509 function string_to_number, so that Fstring_to_number parses
1510 floating point numbers consistently with the Lisp reader.
04f2d78b 1511 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1512 (E_CHAR, EXP_INT): Remove, replacing with ...
1513 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1514 (string_to_number): New function, replacing isfloat_string.
1515 This function checks for valid syntax and produces the resulting
1516 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1517 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1518 so that overflow for non-base-10 numbers is reported only when
1519 there's no portable and simple way to convert to floating point.
452f4150 1520
67769ffc
PE
1521 * textprop.c (set_text_properties_1): Rewrite for clarity,
1522 and to avoid GCC warning about integer overflow.
1523
c20db43f
PE
1524 * intervals.h (struct interval): Use EMACS_INT for members
1525 where EMACS_UINT might cause problems. See
1526 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1527 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1528 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1529 All uses changed.
37aa2f85
PE
1530 (offset_intervals): Tell GCC not to worry about length overflow
1531 when negating a negative length.
c20db43f 1532
2538aa2f
PE
1533 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1534 (overrun_check_free): Likewise.
1535
f2d3008d
PE
1536 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1537 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1538 word size.
1539
ec8df744
PE
1540 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1541 (gnutls_make_error): Rename local to avoid shadowing.
1542 (gnutls_emacs_global_deinit): ifdef out; not used.
1543 (Fgnutls_boot): Use const for pointer to readonly storage.
1544 Comment out unused local. Fix pointer signedness problems.
1545
640ee02d
PE
1546 * lread.c (openp): Don't stuff size_t into an 'int'.
1547 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1548 about possible signed overflow.
1549
6048fb2a
PE
1550 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1551 (GDK_KEY_g): Don't define if already defined.
1552 (xg_prepare_tooltip): Avoid pointer signedness problem.
1553 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1554
fa3c87e1
PE
1555 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1556 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1557
2172544b
PE
1558 * xfns.c (Fx_window_property): Simplify a bit,
1559 to make a bit faster and to avoid GCC 4.6.0 warning.
1560 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1561
9b821a21
PE
1562 * fns.c (internal_equal): Don't assume size_t fits in int.
1563
3c616cfa
PE
1564 * alloc.c (compact_small_strings): Tighten assertion a little.
1565
c2982e87
PE
1566 Replace pEd with more-general pI, and fix some printf arg casts.
1567 * lisp.h (pI): New macro, generalizing old pEd macro to other
1568 conversion specifiers. For example, use "...%"pI"d..." rather
1569 than "...%"pEd"...".
1570 (pEd): Remove. All uses replaced with similar uses of pI.
1571 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1572 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1573 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1574 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1575 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1576 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1577 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1578 64-bit hosts.
1579 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1580 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1581 * print.c (safe_debug_print, print_object): Likewise.
1582 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1583 to int.
6f04d126
PE
1584 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1585 avoiding the 0 flag, which is not portable.
c2982e87
PE
1586 * process.c (Fmake_network_process): Use pI to avoid cast.
1587 * region-cache.c (pp_cache): Likewise.
1588 * xdisp.c (decode_mode_spec): Likewise.
1589 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1590 behavior on 64-bit hosts with printf arg.
6f04d126 1591 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1592 (x_stop_queuing_selection_requests): Likewise.
1593 (x_get_window_property): Don't truncate byte count to an 'int'
1594 when tracing.
0b432f21 1595
5e073ec7
PE
1596 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1597 here, since it parses constructs like leading '-' and spaces,
1598 which are not wanted; and it overflows with large numbers.
1599 Instead, simply match F[0-9]+, which is what is wanted anyway.
1600
36372bf9
PE
1601 * alloc.c: Remove unportable assumptions about struct layout.
1602 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1603 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1604 (allocate_vectorlike, make_pure_vector): Use the new macros,
1605 plus offsetof, to remove unportable assumptions about struct layout.
1606 These assumptions hold on all porting targets that I know of, but
1607 they are not guaranteed, they're easy to remove, and removing them
1608 makes further changes easier.
1609
0b432f21
PE
1610 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1611 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1612 (string_overrun_cookie): Now const. Use initializers that
1613 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1614 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1615 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1616 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1617 multiple of sizeof (EMACS_INT); it need not be, if
1618 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1619 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1620
895009e1
JB
16212011-04-26 Juanma Barranquero <lekktu@gmail.com>
1622
1623 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1624
6a7a1b0b
TZ
16252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1626
1627 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1628 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1629 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1630
841a1577 16312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1632
1633 * lisp.h (Qdebug): List symbol.
895009e1 1634 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1635 * keyboard.c (debug-on-event): New variable.
1636 (handle_user_signal): Break into debugger when debug-on-event
1637 matches the current signal symbol.
1638
f2d3ba6f
DN
16392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1640
1641 * alloc.c (check_sblock, check_string_bytes)
1642 (check_string_free_list): Convert to standard C.
1643
42ce4c63
TZ
16442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1645
1646 * w32.c (emacs_gnutls_push): Fix typo.
1647
825cd63c
EZ
16482011-04-25 Eli Zaretskii <eliz@gnu.org>
1649
fb11d64d
EZ
1650 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1651 "cast to pointer from integer of different size".
1652
825cd63c
EZ
1653 Improve doprnt and its use in verror. (Bug#8545)
1654 * doprnt.c (doprnt): Document the set of format control sequences
1655 supported by the function. Use SAFE_ALLOCA instead of always
1656 using `alloca'.
1657
1658 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1659 is one byte too soon. Don't use xrealloc; instead xfree and
1660 xmalloc anew.
1661
e061a11b
TZ
16622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1663
1664 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1665 callbacks stage.
1666
1667 * gnutls.c: Renamed global_initialized to
1668 gnutls_global_initialized. Added internals for the
1669 :verify-hostname-error, :verify-error, and :verify-flags
1670 parameters of `gnutls-boot' and documented those parameters in the
1671 docstring. Start callback support.
1672 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1673 unless a fatal error occured. Call gnutls_alert_send_appropriate
1674 on error. Return error code.
1675 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1676 (emacs_gnutls_read): Likewise.
1677 (Fgnutls_boot): Return handshake error code.
1678 (emacs_gnutls_handle_error): New function.
1679 (wsaerror_to_errno): Likewise.
1680
1681 * w32.h (emacs_gnutls_pull): Add prototype.
1682 (emacs_gnutls_push): Likewise.
1683
1684 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1685 (emacs_gnutls_push): Likewise.
1686
16872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1688
1689 * process.c (wait_reading_process_output): Check if GnuTLS
1690 buffered some data internally if no FDs are set for TLS
1691 connections.
1692
1693 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1694 (LIBS): Link to USER_LIBS.
1695 ($(BLD)/gnutls.$(0)): New target.
1696
fa6996bc
EZ
16972011-04-24 Eli Zaretskii <eliz@gnu.org>
1698
eb35682e
EZ
1699 * xdisp.c (handle_single_display_spec): Rename the
1700 display_replaced_before_p argument into display_replaced_p, to
1701 make it consistent with the commentary. Fix typos in the
1702 commentary.
1703
e2ad650c
EZ
1704 * textprop.c (syms_of_textprop): Remove dead code.
1705 (copy_text_properties): Delete obsolete commentary about an
1706 interface that was deleted long ago. Fix typos in the description
1707 of arguments.
1708
1b2de274
EZ
1709 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1710 to changes in oldXMenu/XMenu.h from 2011-04-16.
1711 <menu_help_message, prev_menu_help_message>: Constify.
1712 (IT_menu_make_room): menu->help_text is now `const char **';
1713 adjust.
1714
1715 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1716 to changes in oldXMenu/XMenu.h from 2011-04-16.
1717 (struct XMenu): Declare `help_text' `const char **'.
1718
1719 * xfaces.c <Qunspecified>: Make extern again.
1720
1721 * syntax.c: Include sys/types.h before including regex.h, as
1722 required by Posix.
1723
762b15be
EZ
1724 * doc.c (get_doc_string): Improve the format passed to `error'.
1725
1726 * doprnt.c (doprnt): Improve commentary.
1727
1728 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1729
1730 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1731 them with etags.
1732
f1052e5d
EZ
1733 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1734 changes in globals.h immediately force recompilation.
762b15be
EZ
1735 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1736 $(CURDIR)/s/ms-w32.h.
1737 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1738
fa6996bc
EZ
1739 * character.c (Fchar_direction): Function deleted.
1740 (syms_of_character): Don't defsubr it.
1741 <char-direction-table>: Deleted.
1742
e6c3da20
EZ
17432011-04-23 Eli Zaretskii <eliz@gnu.org>
1744
1745 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1746 * doprnt.c: Include limits.h.
1747 (SIZE_MAX): New macro.
04f2d78b
CB
1748 (doprnt): Return a size_t value. 2nd arg is now size_t.
1749 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1750 Improve overflow protection. Support `l' modifier for integer
1751 conversions. Support %l conversion. Don't assume an EMACS_INT
1752 argument for integer conversions and for %c.
1753
1754 * lisp.h (doprnt): Restore prototype.
1755
1756 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1757 $(SRC)/character.h.
1758
1759 * Makefile.in (base_obj): Add back doprnt.o.
1760
1761 * deps.mk (doprnt.o): Add back prerequisites.
1762 (callint.o): Depend on character.h.
1763
1764 * eval.c (internal_lisp_condition_case): Include the handler
1765 representation in the error message.
1766 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1767 when breaking from the loop.
1768
1769 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1770
1771 * callint.c (Fcall_interactively): When displaying error message
1772 about invalid control letter, pass the character's codepoint, not
1773 a pointer to its multibyte form. Improve display of the character
1774 in octal and display also its hex code.
1775
1776 * character.c (char_string): Use %x to display the (unsigned)
1777 codepoint of an invalid character, to avoid displaying a bogus
1778 negative value.
1779
1780 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1781 `error', not SYMBOL_NAME itself.
1782
1783 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1784 character arguments to `error'.
1785
1786 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1787 to `error' in error message about FINAL_CHAR argument. Make sure
1788 FINAL_CHAR is a character, and use %c when it is passed as
1789 argument to `error'.
1790
4ffd0d6b 17912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1792
1793 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1794
1795 * w32.c: Include <time.h>.
1796 (sys_localtime): New function.
1797
4ffd0d6b 17982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1799
1800 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1801
4ffd0d6b 1802 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1803
4ffd0d6b 18042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1805
4ffd0d6b
GM
1806 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1807 zombies (Bug#8467).
aac0c6e3 1808
04c56954
EZ
18092011-04-19 Eli Zaretskii <eliz@gnu.org>
1810
1811 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1812 gl_state.e_property when gl_state.object is Qt.
1813
1814 * insdel.c (make_gap_larger): Remove limitation of buffer size
1815 to <= INT_MAX.
1816
16a43933
CY
18172011-04-18 Chong Yidong <cyd@stupidchicken.com>
1818
1819 * xdisp.c (lookup_glyphless_char_display)
1820 (produce_glyphless_glyph): Handle cons cell entry in
1821 glyphless-char-display.
1822 (Vglyphless_char_display): Document it.
1823
1824 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1825 glyphless-char-display.
1826
4581706e
CY
18272011-04-17 Chong Yidong <cyd@stupidchicken.com>
1828
1829 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1830
1831 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1832
1833 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1834 definition for no-X builds.
1835
4887c6e2 18362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1837
fd35b6f9
PE
1838 Static checks with GCC 4.6.0 and non-default toolkits.
1839
5c1ccb01
PE
1840 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1841
006c5daa
PE
1842 * process.c (keyboard_bit_set): Define only if SIGIO.
1843 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1844 (send_process): Repair possible setjmp clobbering.
1845
efc736d3
PE
1846 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1847
4e2fe2e6
PE
1848 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1849
f97334a2
PE
1850 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1851
4e75f29d
PE
1852 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1853 Define only if needed.
1854
90efadd1
PE
1855 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1856 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1857 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1858
3c647824
PE
1859 * dispextern.h (struct redisplay_interface): Rename param
1860 to avoid shadowing.
e264f262 1861 * termhooks.h (struct terminal): Likewise.
761383f4 1862 * xterm.c (xembed_send_message): Likewise.
3c647824 1863
b58c5c4a
PE
1864 * insdel.c (make_gap_smaller): Define only if
1865 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1866
cad59032
PE
1867 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1868 it.
1869
c339dc2e
PE
1870 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1871 so that we aren't warned about unused symbols.
1872
91a3e27b
PE
1873 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1874
399c71d3 1875 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1876
8ffc96f5
PE
1877 * xfns.c (x_real_positions): Mark locals as initialized.
1878
eef9bc79
PE
1879 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1880
098db9dd
PE
1881 * xterm.c: Fix problems found by static analysis with other toolkits.
1882 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1883 (x_dispatch_event): Declare static if USE_GTK, and
1884 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1885 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1886 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1887 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1888 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1889
eb18f6cc
PE
1890 * xmenu.c (menu_help_callback): Pointer type fixes.
1891 Use const pointers when pointing at readonly data. Avoid pointer
1892 signedness clashes.
1893 (FALSE): Remove unused macro.
1894 (update_frame_menubar): Remove unused decl.
1895
1fe72bf8
PE
1896 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1897
60d9e1db
PE
1898 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1899 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1900 (single_menu_item): Rename local to avoid shadowing.
1901
39261c26
PE
1902 * keyboard.c (make_lispy_event): Remove unused local var.
1903
018c5e19
PE
1904 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1905 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1906
63d2b86e
PE
1907 * bitmaps: Change bitmaps from unsigned char back to the X11
1908 compatible char. Avoid the old compiler warnings about
1909 out-of-range initializers by using, for example, '\xab' rather
1910 than 0xab.
1911
aefd87e1
PE
1912 * xgselect.c (xgselect_initialize): Check vs interface
1913 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1914
bf501fb9
PE
1915 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1916
e9829fdf
PE
1917 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1918 to read-only memory.
1919
1086c095
PE
1920 * fns.c (vector): Remove; this old hack is no longer needed.
1921
2baccd04 1922 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1923 Remove unused var.
dde42981 1924 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1925
72391843 1926 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1927
436c16df 1928 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1929 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1930 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1931
92bb796d 1932 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1933 (x_term_init): Remove local to avoid shadowing.
92bb796d 1934
764430a3 1935 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1936
1937 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1938 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1939
d1dfb56c
EZ
19402011-04-16 Eli Zaretskii <eliz@gnu.org>
1941
c4354cb4
EZ
1942 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1943
d1dfb56c
EZ
1944 Fix regex.c, syntax.c and friends for buffers > 2GB.
1945 * syntax.h (struct gl_state_s): Declare character position members
1946 EMACS_INT.
1947
1948 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1949
04f2d78b
CB
1950 * textprop.c (verify_interval_modification, interval_of):
1951 Declare arguments EMACS_INT.
d1dfb56c
EZ
1952
1953 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1954 EMACS_INT.
1955
1956 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1957
1958 * indent.c (Fvertical_motion): Local variable it_start is now
1959 EMACS_INT.
1960
1961 * regex.c (re_match, re_match_2, re_match_2_internal)
1962 (bcmp_translate, regcomp, regexec, print_double_string)
1963 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1964 (re_compile_pattern, re_exec): Declare arguments and local
1965 variables `size_t' and `ssize_t' and return values `regoff_t', as
1966 appropriate.
1967 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1968 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1969 <compile_stack_type>: `size' and `avail' are now `size_t'.
1970
1971 * regex.h <regoff_t>: Use ssize_t, not int.
1972 (re_search, re_search_2, re_match, re_match_2): Arguments that
1973 specify buffer/string position and length are now ssize_t and
1974 size_t. Return type is regoff_t.
1975
613052cd
BK
19762011-04-16 Ben Key <bkey76@gmail.com>
1977
1978 * nsfont.m: Fixed bugs in ns_get_family and
1979 ns_descriptor_to_entity that were caused by using free to
1980 deallocate memory blocks that were allocated by xmalloc (via
1981 xstrdup). This caused Emacs to crash when compiled with
1982 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1983 --enable-checking=xmallocoverrun). xfree is now used to
1984 deallocate these memory blocks.
1985
4170f62f 19862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1987
71b41406
PE
1988 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1989
9587a89d
PE
1990 emacs_write: Accept and return EMACS_INT for sizes.
1991 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1992 et seq.
1993 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1994 Accept and return EMACS_INT.
1995 (emacs_gnutls_write): Return the number of bytes written on
1996 partial writes.
1997 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1998 (emacs_read, emacs_write): Remove check for negative size, as the
1999 Emacs source code has been audited now.
9587a89d
PE
2000 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2001 (emacs_read, emacs_write): Use it.
273a5f82
PE
2002 * process.c (send_process): Adjust to the new signatures of
2003 emacs_write and emacs_gnutls_write. Do not attempt to store
2004 a byte offset into an 'int'; it might overflow.
9587a89d 2005 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2006
3e047f51
PE
2007 * sound.c: Don't assume sizes fit in 'int'.
2008 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2009 Return EMACS_INT, not int.
3e047f51 2010 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2011 Accept EMACS_INT, not int.
2012 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2013 record read return values.
2014
cc39a9db
BK
20152011-04-15 Ben Key <bkey76@gmail.com>
2016
c9d0ec6d
JB
2017 * keyboard.c (Qundefined): Don't declare static since it is used
2018 in nsfns.m.
2019 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2020 static since they are used in nsfont.m.
cc39a9db 2021
6c60eb9f
SM
20222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2023
2024 * process.c (Qprocessp): Don't declare static.
2025 * lisp.h (Qprocessp): Declare again.
2026
7990b61a
JB
20272011-04-15 Juanma Barranquero <lekktu@gmail.com>
2028
2029 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2030
5d4cb038
PE
20312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2032
8bd7b830 2033 Improve C-level modularity by making more things 'static'.
cd64ea1d 2034
e3b27b31
PE
2035 Don't publish debugger-only interfaces to other modules.
2036 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2037 (verify_bytepos, count_markers): Move decls to the only modules
2038 that need them.
2039 * region-cache.h (pp_cache): Likewise.
2040 * window.h (check_all_windows): Likewise.
2041 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2042
5d4cb038
PE
2043 * sysdep.c (croak): Now static, if
2044 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2045 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2046
2047 * alloc.c (refill_memory_reserve): Now static if
2048 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2049 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2050
e87b6180
PE
2051 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2052 Define only if USE_LUCID.
2053
ac64929e
PE
2054 * xrdb.c (x_customization_string, x_rm_string): Now static.
2055
6f37259d
PE
2056 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2057 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2058
1683e3ab
PE
2059 * xdisp.c (draw_row_with_mouse_face): Now static.
2060 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2061
de9c2632
PE
2062 * window.h (check_all_windows): Mark externally visible.
2063
2b96acb7
PE
2064 * window.c (window_deletion_count): Now static.
2065
2066 * undo.c: Make symbols static if they're not exported.
2067 (last_undo_buffer, last_boundary_position, pending_boundary):
2068 Now static.
2069
50436f33
PE
2070 * textprop.c (interval_insert_behind_hooks): Now static.
2071 (interval_insert_in_front_hooks): Likewise.
2072
64520e5c
PE
2073 * term.c: Make symbols static if they're not exported.
2074 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2075 (max_frame_lines, tty_set_terminal_modes):
2076 (tty_reset_terminal_modes, tty_turn_off_highlight):
2077 (get_tty_terminal): Now static.
2078 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2079 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2080 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2081 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2082 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2083
1fa53021
PE
2084 * sysdep.c: Make symbols static if they're not exported.
2085 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2086 Now static.
2087 (sigprocmask_set, full_mask): Remove; unused.
2088 (wait_debugging): Mark as visible.
2089 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2090 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2091
d4b43b22
PE
2092 * syntax.c (syntax_temp): Define only if !__GNUC__.
2093
b7c513d0
PE
2094 * sound.c (current_sound_device, current_sound): Now static.
2095
989b29ad
PE
2096 * search.c (searchbufs, searchbuf_head): Now static.
2097
13a55a78
PE
2098 * scroll.c (scroll_cost): Remove; unused.
2099 * dispextern.h (scroll_cost): Remove decl.
2100
de68a1fc
PE
2101 * region-cache.h (pp_cache): Mark as externally visible.
2102
40ccffa6
PE
2103 * process.c: Make symbols static if they're not exported.
2104 (process_tick, update_tick, create_process, chan_process):
2105 (Vprocess_alist, proc_buffered_char, datagram_access):
2106 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2107 (deactivate_process): Mark defn as static, as well as decl.
2108 * lisp.h (create_process): Remove decl.
2109 * process.h (chan_process, Vprocess_alist): Remove decls.
2110
ad64fc97
PE
2111 * print.c: Make symbols static if they're not exported.
2112 (print_depth, new_backquote_output, being_printed, print_buffer):
2113 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2114 (print_interval, print_number_index, initial_stderr_stream):
2115 Now static.
2116 * lisp.h (Fprinc): Remove decl.
2117 (debug_output_compilation_hack): Mark as externally visible.
2118
adddb265
PE
2119 * sysdep.c (croak): Move decl from here to syssignal.h.
2120 * syssignal.h (croak): Put it here, so the API can be checked when
2121 'croak' is called from dissociate_if_controlling_tty.
2122
1717ede2
PE
2123 * minibuf.c: Make symbols static if they're not exported.
2124 (minibuf_save_list, choose_minibuf_frame): Now static.
2125 * lisp.h (choose_minibuf_frame): Remove decl.
2126
fa5fb2bc
PE
2127 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2128
1e3890d1
PE
2129 * lread.c: Make symbols static if they're not exported.
2130 (read_objects, initial_obarray, oblookup_last_bucket_number):
2131 Now static.
2132 (make_symbol): Remove; unused.
2133 * lisp.h (initial_obarray, make_symbol): Remove decls.
2134
8a1414fa
PE
2135 * keyboard.c: Make symbols static if they're not exported.
2136 (single_kboard, recent_keys_index, total_keys, recent_keys):
2137 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2138 (this_single_command_key_start, echoing, last_auto_save):
2139 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2140 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2141 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2142 (Vlispy_mouse_stem, double_click_count):
2143 Now static.
2144 (force_auto_save_soon): Define only if SIGDANGER.
2145 (ignore_mouse_drag_p): Now static if
2146 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2147 (print_help): Remove; unused.
2148 (stop_character, last_timer_event): Mark as externally visible.
2149 * keyboard.h (ignore_mouse_drag_p): Declare only if
2150 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2151 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2152 * lisp.h (echoing): Remove decl.
2153 (force_auto_save_soon): Declare only if SIGDANGER.
2154 * xdisp.c (redisplay_window): Simplify code, to make it more
2155 obvious that ignore_mouse_drag_p is not accessed if !defined
2156 USE_GTK && !defined HAVE_NS.
2157
93ea6e8f
PE
2158 * intervals.c: Make symbols static if they're not exported.
2159 (merge_properties_sticky, merge_interval_right, delete_interval):
2160 Now static.
2161 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2162
77382fcc
PE
2163 * insdel.c: Make symbols static if they're not exported.
2164 However, leave prepare_to_modify_buffer alone. It's never
2165 called from outside this function, but that appears to be a bug.
2166 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2167 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2168 (adjust_after_replace_noundo): Remove; unused.
2169 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2170 (signal_before_change): Remove decls.
77382fcc 2171
9306c32e
PE
2172 * indent.c (val_compute_motion, val_vmotion): Now static.
2173
cd44d2eb
PE
2174 * image.c: Make symbols static if they're not exported.
2175 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2176 if USE_GTK.
2177 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2178 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2179
ad9a7a06
PE
2180 * fringe.c (standard_bitmaps): Now static.
2181 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2182
81626931
PE
2183 * frame.c: Make symbols static if they're not exported.
2184 (x_report_frame_params, make_terminal_frame): Now static.
2185 (get_frame_param): Now static, unless HAVE_NS.
2186 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2187 (x_get_resource_string): Remove; not used.
2188 * frame.h (make_terminal_frame, x_report_frame_params):
2189 (x_get_resource_string); Remove decls.
2190 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2191 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2192
239f9db9
PE
2193 * font.c, fontset.c: Make symbols static if they're not exported.
2194 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2195 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2196 * font.c (font_close_object): Now static.
2197 * font.h (font_close_object): Remove.
2198 * fontset.c (FONTSET_OBJLIST): Remove.
2199 (free_realized_fontset) #if-0 the body, which does nothing.
2200 (face_suitable_for_char_p): #if-0, as it's never called.
2201 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2202 * xfaces.c (face_at_string_position):
2203 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2204 since 0 is always ASCII.
2205
dfcf3579
PE
2206 * fns.c (weak_hash_tables): Now static.
2207
5045092b
PE
2208 * fileio.c: Make symbols static if they're not exported.
2209 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2210 (Vwrite_region_annotation_buffers): Now static.
2211
57a96f5c
PE
2212 * eval.c: Make symbols static if they're not exported.
2213 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2214 * lisp.h (backtrace_list): Remove decl.
2215
35f08c38
PE
2216 * emacs.c: Make symbols static if they're not exported.
2217 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2218 (fatal_error_code, fatal_error_signal_hook, standard_args):
2219 Now static.
2220 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2221 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2222 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2223 * lisp.h (fatal_error_signal_hook): Remove decl.
2224 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2225
f44bd759
PE
2226 * editfns.c: Move a (normally-unused) function to its only use.
2227 * editfns.c, lisp.h (get_operating_system_release): Remove.
2228 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2229 worth the hassle of breaking this out.
2230
b532497d
PE
2231 * xterm.c: Make symbols static if they're not exported.
2232 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2233 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2234 (x_destroy_window, x_delete_display):
2235 Now static.
2236 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2237 (x_mouse_leave): Remove; unused.
2238 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2239 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2240 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2241 Remove decls.
2242 (x_mouse_leave): Declare only if WINDOWSNT.
2243 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2244 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2245 USE_X_TOOLKIT.
2246
1675728f
PE
2247 * ftxfont.c: Make symbols static if they're not exported.
2248 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2249 HAVE_FREETYPE.
2250 * font.h (ftxfont_driver): Likewise.
2251
e4cebfca
PE
2252 * xfns.c: Make symbols static if they're not exported.
2253 (x_last_font_name, x_display_info_for_name):
2254 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2255 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2256 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2257 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2258 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2259 (last_show_tip_args): Now static.
2260 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2261 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2262 (x_screen_planes): Remove; unused.
2263 * dispextern.h (x_screen_planes): Remove decl.
2264
5bf46f05
PE
2265 * dispnew.c: Make symbols static if they're not exported.
2266 * dispextern.h (redraw_garbaged_frames, scrolling):
2267 (increment_row_positions): Remove.
2268 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2269 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2270 Now static.
2271 (redraw_garbaged_frames): Remove; unused.
2272
435f4c28
PE
2273 * xfaces.c: Make symbols static if they're not exported.
2274 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2275 Remove decls.
2276 * xterm.h (defined_color): Remove decls.
2277 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2278 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2279 (menu_face_changed_default, defined_color, free_realized_face):
2280 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2281 (ascii_face_of_lisp_face): Remove; unused.
2282
8524aef3
PE
2283 * xdisp.c: Make symbols static if they're not exported.
2284 * dispextern.h (scratch_glyph_row, window_box_edges):
2285 (glyph_to_pixel_coords, set_cursor_from_row):
2286 (get_next_display_element, set_iterator_to_next):
2287 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2288 (show_mouse_face): Remove decls
2289 * frame.h (message_buf_print): Likewise.
2290 * lisp.h (pop_message, set_message, check_point_in_composition):
2291 Likewise.
2292 * xterm.h (set_vertical_scroll_bar): Likewise.
2293 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2294 (message_buf_print, scratch_glyph_row, displayed_buffer):
2295 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2296 (get_next_display_element, show_mouse_face, window_box_edges):
2297 (frame_to_window_pixel_xy, check_point_in_composition):
2298 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2299 (glyph_to_pixel_coords): Remove; unused.
2300
16390cd2
PE
2301 * dired.c (file_name_completion): Now static.
2302
2303 * dbusbind.c (xd_in_read_queued_messages): Now static.
2304
a25f4dfa
PE
2305 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2306 * data.c (circular_list_error): Remove.
2307
14a9c8df
PE
2308 * commands.h (last_point_position, last_point_position_buffer):
2309 (last_point_position_window): Remove decls.
2310 * keyboard.c: Make these variables static.
2311
04f2d78b
CB
2312 * coding.h (coding, code_convert_region, encode_coding_gap):
2313 Remove decls.
74ab6df5
PE
2314 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2315 (iso_code_class, detect_coding, code_convert_region): Now static.
2316 (encode_coding_gap): Remove; unused.
2317
38dfbee1
PE
2318 * chartab.c (chartab_chars, chartab_bits): Now static.
2319
a2cb4e63
PE
2320 * charset.h (charset_iso_8859_1): Remove decl.
2321 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2322 Now static.
2323
127198fd
PE
2324 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2325 * ccl.c (Vccl_program_table): Now static.
2326 (check_ccl_update): Remove; unused.
2327
d85b608f
PE
2328 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2329 * category.h: ... from here.
2330 * category.c (check_category_table, set_category_set): Now static.
2331
31cd66f3
PE
2332 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2333 * lisp.h: Remove these decls.
2334
c358e587
PE
2335 * buffer.c (buffer_count): Remove unused var.
2336
e78aecca
PE
2337 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2338 so that it's not optimized away.
2339 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2340 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2341 exported only to the debugger.
2342
e192d7d3 2343 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2344 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2345
92470028
PE
2346 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2347 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2348 was inaccessible from Lisp.
2349 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2350 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2351
244ed907
PE
2352 alloc.c: Import and export fewer symbols, and remove unused items.
2353 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2354 is defined.
2355 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2356 it's not optimized away by whole-program optimization.
2357 (message_enable_multibyte, free_misc): Remove.
2358 (catchlist, handlerlist, mark_backtrace):
2359 Declare only if BYTE_MARK_STACK.
2360 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2361 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2362 (message_enable_multibyte): Remove decl.
2363 (free_misc, interval_free_list, float_block, float_block_index):
2364 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2365 (cons_free_list, last_marked_index):
2366 Now static.
2367 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2368 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2369 (mark_backtrace): Define only if BYTE_MARK_STACK.
2370 * xdisp.c (message_enable_multibyte): Now static.
2371
61c2b50e 2372 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2373 This makes it easier for human readers (and static analyzers)
2374 to see whether these variables are used from other modules.
2375 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2376 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2377 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2378 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2379 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2380 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2381 * xmenu.c, xselect.c:
2382 Declare Q* vars static if they are not used in other modules.
2383 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2384 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2385 Remove decls of unexported vars.
2386 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2387
95c82688
PE
2388 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2389
16a97296
PE
2390 Make Emacs functions such as Fatom 'static' by default.
2391 This makes it easier for human readers (and static analyzers)
2392 to see whether these functions can be called from other modules.
2393 DEFUN now defines a static function. To make the function external
2394 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2395 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2396 (Finit_image_library):
16a97296
PE
2397 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2398 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2399 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2400 Remove decls, since these functions are now static.
2401 (Funintern, Fget_internal_run_time): New decls, since these functions
2402 were already external.
95c82688 2403
16a97296
PE
2404 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2405 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2406 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2407 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2408 * keyboard.c, keymap.c, lread.c:
2409 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2410 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2411 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2412 Mark functions with DEFUE instead of DEFUN,
2413 if they are used in other modules.
2414 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2415 decls for now-static functions.
2416 * buffer.h (Fdelete_overlay): Remove decl.
2417 * callproc.c (Fgetenv_internal): Mark as internal.
2418 * composite.c (Fremove_list_of_text_properties): Remove decl.
2419 (Fcomposition_get_gstring): New forward static decl.
2420 * composite.h (Fcomposite_get_gstring): Remove decl.
2421 * dired.c (Ffile_attributes): New forward static decl.
2422 * doc.c (Fdocumntation_property): New forward static decl.
2423 * eval.c (Ffetch_bytecode): New forward static decl.
2424 (Funintern): Remove extern decl; now in .h file where it belongs.
2425 * fileio.c (Fmake_symbolic_link): New forward static decl.
2426 * image.c (Finit_image_library): New forward static decl.
2427 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2428 * intervals.h (Fprevious_property_change):
2429 (Fremove_list_of_text_properties): Remove decls.
2430 * keyboard.c (Fthis_command_keys): Remove decl.
2431 (Fcommand_execute): New forward static decl.
2432 * keymap.c (Flookup_key): New forward static decl.
2433 (Fcopy_keymap): Now static.
2434 * keymap.h (Flookup_key): Remove decl.
2435 * process.c (Fget_process): New forward static decl.
2436 (Fprocess_datagram_address): Mark as internal.
2437 * syntax.c (Fsyntax_table_p): New forward static decl.
2438 (skip_chars): Remove duplicate decl.
2439 * textprop.c (Fprevious_property_change): New forward static decl.
2440 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2441 Now internal.
2442 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2443 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2444
785bbd42
PE
2445 * editfns.c (Fformat): Remove unreachable code.
2446
8b913b57
AS
24472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2448
2449 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2450 change. (Bug#8496)
2451
a6744a35
EZ
24522011-04-13 Eli Zaretskii <eliz@gnu.org>
2453
2454 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2455 when at ZV. (Bug#8487)
2456
e7974947
AS
24572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2458
baad03f0
AS
2459 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2460 (Bug#8437)
2461 * keyboard.c (parse_tool_bar_item): Likewise.
2462 * sound.c (sound_cleanup, alsa_close): Likewise.
2463 * termcap.c (tgetent): Likewise.
2464 * xfns.c (x_default_font_parameter): Likewise.
2465 * xsettings.c (read_and_apply_settings): Likewise.
2466
e7974947
AS
2467 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2468 (overrun_check_free): Protoize.
2469
28272684
PE
24702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2473 since callers should never pass a negative size.
2474 Change the signature to match that of plain 'read' and 'write'; see
2475 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2476 * lisp.h: Update prototypes of emacs_write and emacs_read.
2477
11997c76
EZ
24782011-04-11 Eli Zaretskii <eliz@gnu.org>
2479
2480 * xdisp.c (redisplay_window): Don't try to determine the character
2481 position of the scroll margin if the window start point w->startp
e896f03c 2482 is outside the buffer's accessible region. (Bug#8468)
11997c76 2483
8a2cbd72
EZ
24842011-04-10 Eli Zaretskii <eliz@gnu.org>
2485
2486 Fix write-region and its subroutines for buffers > 2GB.
2487 * fileio.c (a_write, e_write): Modify declaration of arguments and
2488 local variables to support buffers larger than 2GB.
2489 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2490
2491 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2492 argument, local variables, and return value.
2493
2494 * lisp.h: Update prototypes of emacs_write and emacs_read.
2495
2496 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2497
4073e537 24982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2499
1ebfdcb6
PE
2500 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2501
b2ded58d
PE
2502 Fix more problems found by GCC 4.6.0's static checks.
2503
7d66342c
PE
2504 * xdisp.c (vmessage): Use a better test for character truncation.
2505
bbf47d44
PE
2506 * charset.c (load_charset_map): <, not <=, for optimization,
2507 and to avoid potential problems with integer overflow.
9248994d 2508 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2509 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2510 * editfns.c (Fformat): Likewise.
1e69125e 2511 * syntax.c (skip_chars): Likewise.
3befa583 2512
e3019616
PE
2513 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2514 This also lets GCC 4.6.0 generate slightly better loop code.
2515
becfa255
PE
2516 * callint.c (Fcall_interactively): <, not <=, for optimization.
2517 (Fcall_interactively): Count the number of arguments produced,
2518 not the number of arguments given. This is simpler and lets GCC
2519 4.6.0 generate slightly better code.
2520
dae0cd48
PE
2521 * ftfont.c: Distingish more carefully between FcChar8 and char.
2522 The previous code passed unsigned char * to a functions like
2523 strlen and xstrcasecmp that expect char *, which does not
2524 conform to the C standard.
2525 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2526 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2527 char * when the C standard requires it.
2528
76032d70
PE
2529 * keyboard.c (read_char): Remove unused var.
2530
eb3f1cc8
PE
2531 * eval.c: Port to Windows vsnprintf (Bug#8435).
2532 Include <limits.h>.
2533 (SIZE_MAX): Define if the headers do not.
2534 (verror): Do not give up if vsnprintf returns a negative count.
2535 Instead, grow the buffer. This ports to Windows vsnprintf, which
2536 does not conform to C99. Problem reported by Eli Zaretskii.
2537 Also, simplify the allocation scheme, by avoiding the need for
2538 calling realloc, and removing the ALLOCATED variable.
2539
70476b54
PE
2540 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2541
12020a9e
PE
2542 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2543 But keep the doprint source code for now, as we might revamp it
2544 and use it again (Bug#8435).
ea6c7ae6
PE
2545 * lisp.h (doprnt): Remove.
2546 * Makefile.in (base_obj): Remove doprnt.o.
2547 * deps.mk (doprnt.o): Remove.
2548
5fdb398c
PE
2549 error: Print 32- and 64-bit integers portably (Bug#8435).
2550 Without this change, on typical 64-bit hosts error ("...%d...", N)
2551 was used to print both 32- and 64-bit integers N, which relied on
2552 undefined behavior.
2553 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2554 New macro.
2555 * lisp.h (error, verror): Mark as printf-like functions.
2556 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2557 Report overflow in size calculations when allocating printf buffer.
2558 Do not truncate output string at its first null byte.
2559 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2560 Truncate the output at a character boundary, since vsnprintf does not
2561 do that.
2562 * charset.c (check_iso_charset_parameter): Convert internal
2563 character to string before calling 'error', since %c now has the
2564 printf meaning.
2565 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2566 overflow when computing char to be passed to 'error'. Do not
2567 pass Lisp_Object to 'error'; pass the integer instead.
2568 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2569 formatted with plain %d.
2570
b189fa66
PE
2571 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2572
bff87ef0
PE
2573 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2574
7e2cac20
PE
2575 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2576
ce4d90b5
PE
2577 * xterm.c (x_catch_errors): Remove duplicate declaration.
2578
266c9547
PE
2579 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2580
79c49ad2
PE
2581 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2582
368f4090
JM
25832011-04-10 Jim Meyering <meyering@redhat.com>
2584
2585 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2586 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2587 return ssize_t not "int", and use size_t as the buffer length.
2588 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2589 * gnutls.h: Update declarations.
2590 * process.c (read_process_output): Use ssize_t, to match.
2591 (send_process): Likewise.
2592
a32d4040
CY
25932011-04-09 Chong Yidong <cyd@stupidchicken.com>
2594
2595 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2596
8546720e 25972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2598
04f2d78b
CB
2599 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2600 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2601
8546720e
GM
2602 * xterm.c (handle_one_xevent):
2603 * xmenu.c (create_and_show_popup_menu):
2604 * xselect.c (x_decline_selection_request)
2605 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2606
0a2f5c1a 26072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2608
2609 Fix some uses of `int' instead of EMACS_INT.
2610 * search.c (string_match_1, fast_string_match)
2611 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2612 (scan_buffer, find_next_newline_no_quit)
2613 (find_before_next_newline, search_command, Freplace_match)
2614 (Fmatch_data): Make some `int' variables be EMACS_INT.
2615
2616 * xdisp.c (display_count_lines): 3rd argument and return value now
2617 EMACS_INT. All callers changed.
2618 (pint2hrstr): Last argument is now EMACS_INT.
2619
2620 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2621 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2622 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2623 (decode_coding_utf_16, decode_coding_emacs_mule)
2624 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2625 (decode_coding_ccl, decode_coding_charset)
2626 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2627 (decode_coding_iso_2022, decode_coding_emacs_mule)
2628 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2629 <char_offset, last_offset>: Declare EMACS_INT.
2630 (encode_coding_utf_8, encode_coding_utf_16)
2631 (encode_coding_emacs_mule, encode_invocation_designation)
2632 (encode_designation_at_bol, encode_coding_iso_2022)
2633 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2634 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2635 Declare EMACS_INT.
2636 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2637 (encode_invocation_designation): Last argument P_NCHARS is now
2638 EMACS_INT.
2639 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2640 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2641
2642 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2643 All users changed.
2644
2645 * ccl.c (Fccl_execute_on_string): Declare some variables
2646 EMACS_INT.
2647
8546720e 26482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2649
2650 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2651
4e19a977
CS
26522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2653
2654 * process.c (Fformat_network_address): Doc fix.
2655
87302331
R
26562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2657
2658 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2659
cbb59342
CY
26602011-04-08 Chong Yidong <cyd@stupidchicken.com>
2661
2662 * keyboard.c (read_char): Call Lisp function help-form-show,
2663 instead of using internal_with_output_to_temp_buffer.
2664 (Qhelp_form_show): New var.
e0d38eeb 2665 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2666
2667 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2668
2669 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2670
e67a13ab
CY
26712011-04-06 Chong Yidong <cyd@stupidchicken.com>
2672
04f2d78b
CB
2673 * process.c (Flist_processes): Remove to Lisp.
2674 (list_processes_1): Delete.
e67a13ab 2675
973f782d
EZ
26762011-04-06 Eli Zaretskii <eliz@gnu.org>
2677
7c106b1e
EZ
2678 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2679
973f782d
EZ
2680 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2681
41cf7d1a 26822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2683
ca23cc88
PE
2684 Fix more problems found by GCC 4.6.0's static checks.
2685
f390e2d5
PE
2686 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2687
42eea0d0
PE
2688 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2689
b69769da 2690 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2691
f9541e84
PE
2692 * xdisp.c (vmessage): Mark as a printf-like function.
2693
13841b55
PE
2694 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2695
c136c10f
PE
2696 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2697
5e2d4a30
PE
2698 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2699 printf-like functions.
2700 (tiff_load): Add casts to remove these marks before passing them
2701 to system-supplied API.
2702
583f48b9
PE
2703 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2704
b25d760e
PE
2705 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2706 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2707 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2708 directly, rather than having caller test rule sign. This avoids
2709 some unnecessary tests.
2710 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2711 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2712 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2713
bc7b6697 2714 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2715 (xfont_open): Avoid unnecessary tests.
bc7b6697 2716
27ccc379
PE
2717 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2718
dcd5c89a
PE
2719 * composite.h, composite.c (composition_gstring_put_cache):
2720 Use EMACS_INT, not int, for length.
2721
b13a45c6
PE
2722 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2723 breaking out part of COMPOSITION_DECODE_RULE.
2724 (COMPOSITION_DECODE_RULE): Use it.
2725 * composite.c (get_composition_id): Remove unused local vars,
2726 by using the new macro.
2727
1e792e4d
PE
2728 * textprop.c (set_text_properties_1): Change while to do-while,
2729 since the condition is always true at first.
2730
dc6c6455 2731 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2732 (interval_deletion_adjustment): Return unsigned value.
2733 All uses changed.
dc6c6455 2734
aba7731a
PE
2735 * process.c (list_processes_1, create_pty, read_process_output):
2736 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2737 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2738 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2739 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2740 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2741
fdfc4bf3
PE
2742 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2743
fca8fe46 2744 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2745 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2746
06a0259a 2747 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2748 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2749 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2750
e7b9e80f
PE
2751 * print.c (print_error_message): Avoid int overflow.
2752
56201685
PE
2753 * font.c (font_list_entities): Redo for clarity,
2754 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2755
78834453 2756 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2757 (font_score): Avoid potential overflow in diff calculation.
78834453 2758
0bc0b309 2759 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2760 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2761
e610eaca
PE
2762 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2763
b895abce
PE
2764 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2765 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2766 can always succeed if overflow has undefined behavior.
2767
1f1d9321 2768 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2769 (wordify): Omit three unnecessary tests.
1f1d9321 2770
c59478bc
PE
2771 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2772 All callers changed. This avoids the need for an unused var.
2773
79b73827
PE
2774 * casefiddle.c (casify_region): Remove var that is set but not used.
2775
a4db5dfe
PE
2776 * dired.c (file_name_completion): Remove var that is set but not used.
2777
43aae36e
PE
2778 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2779
2a47c44d 2780 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2781 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2782
a37c69bf
PE
2783 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2784 Check for integer overflow on size calculations.
2785
328ab8e7
PE
2786 * buffer.c (Fprevious_overlay_change): Remove var that is set
2787 but not used.
2788
e5a2a5cb
PE
2789 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2790 Remove vars that are set but not used.
8d84a6eb 2791 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2792 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2793
a60e5f68
PE
2794 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2795
f661cb61 2796 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2797 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2798
f0397f5a
PE
2799 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2800 that are set but not used.
2801
8664db06 2802 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2803 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2804
6abdaa4a
PE
2805 * xselect.c (x_get_local_selection, x_handle_property_notify):
2806 Remove vars that are set but not used.
2807
0ce7538d 2808 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2809 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2810
9ae848fc
PE
2811 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2812 Remove var that is set but not used.
0b918413
PE
2813 (scroll_bar_windows_size): Now size_t, not int.
2814 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2815 Check for overflow.
9ae848fc 2816
a5a62657
PE
2817 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2818 (map_tty_color) [!defined MSDOS]: Likewise.
2819
5c5cdd39
PE
2820 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2821
66ebf983
PE
2822 * coding.c: Remove vars that are set but not used.
2823 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2824 All callers changed.
2825 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2826 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2827 (decode_coding_charset): Remove vars that are set but not used.
2828
1be4d761
PE
2829 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2830 that is set but not used.
2831
47553fa8
PE
2832 * print.c (print_object): Remove var that is set but not used.
2833
1f7196bf 2834 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2835 The gnulib version avoids calling malloc in the usual case,
2836 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2837 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2838 * filelock.c (current_lock_owner): Likewise.
2839 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2840 * sysdep.c: Include allocator.h, careadlinkat.h.
2841 (emacs_no_realloc_allocator): New static constant.
2842 (emacs_readlink): New function.
fdb61804
PE
2843 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2844 ../lib/careadlinkat.h.
d1fdcab7 2845
f84c17c7
SM
28462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2847
2848 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2849 first non-nil return value).
2850
ef3862ad
JD
28512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2852
2853 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2854 if not defined (Bug#8403).
2855
376a7006
JB
28562011-04-02 Juanma Barranquero <lekktu@gmail.com>
2857
2858 * xdisp.c (display_count_lines): Remove parameter `start',
2859 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2860 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2861 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2862 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2863 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2864 and thereabouts. All callers changed.
2865 (get_per_char_metric): Remove parameter `f', unused since
2866 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2867
6ca3801d
JM
28682011-04-02 Jim Meyering <meyering@redhat.com>
2869
2870 do not dereference NULL upon failed strdup
2871 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2872 (ns_get_family): Likewise.
2873
d8e2b5ba
JB
28742011-04-02 Juanma Barranquero <lekktu@gmail.com>
2875
2876 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2877
8c74fcbd
JD
28782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2879
2880 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2881 later (Bug#8403).
2882
7200d79c
SM
28832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2884
03408648 2885 Add lexical binding.
7200d79c 2886
03408648
SM
2887 * window.c (Ftemp_output_buffer_show): New fun.
2888 (Fsave_window_excursion):
2889 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2890
2891 * lread.c (lisp_file_lexically_bound_p): New function.
2892 (Fload): Bind Qlexical_binding.
2893 (readevalloop): Remove `evalfun' arg.
2894 Bind Qinternal_interpreter_environment.
2895 (Feval_buffer): Bind Qlexical_binding.
2896 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2897 Mark as dynamic.
2898 (syms_of_lread): Declare `lexical-binding'.
2899
2900 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2901
2902 * keyboard.c (eval_dyn): New fun.
2903 (menu_item_eval_property): Use it.
ca105506
SM
2904
2905 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2906
03408648
SM
2907 * fns.c (concat, mapcar1): Accept byte-code-functions.
2908
2909 * eval.c (Fsetq): Handle lexical vars.
2910 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2911 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2912 (FletX, Flet): Obey lexical binding.
2913 (Fcommandp): Handle closures.
2914 (Feval): New `lexical' arg.
2915 (eval_sub): New function extracted from Feval. Use it almost
2916 everywhere where Feval was used. Look up vars in lexical env.
2917 Handle closures.
2918 (Ffunctionp): Move from subr.el.
2919 (Ffuncall): Handle closures.
2920 (apply_lambda): Remove `eval_flags'.
2921 (funcall_lambda): Handle closures and new byte-code-functions.
2922 (Fspecial_variable_p): New function.
2923 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2924 but without exporting it to Lisp.
23aba0ea 2925
23aba0ea 2926 * doc.c (Fdocumentation, store_function_docstring):
03408648 2927 * data.c (Finteractive_form): Handle closures.
23aba0ea 2928
03408648
SM
2929 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2930 interactive spec.
ba83908c 2931
04f2d78b
CB
2932 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2933 New byte-codes.
03408648
SM
2934 (exec_byte_code): New function extracted from Fbyte_code to handle new
2935 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2936
03408648 2937 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2938
03408648 2939 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2940
e2abce01
JB
29412011-03-31 Juanma Barranquero <lekktu@gmail.com>
2942
2943 * xdisp.c (redisplay_internal): Fix prototype.
2944
63696a73 29452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2946
63696a73 2947 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2948 (try_scrolling): Use it when setting scroll_limit.
2949 Limit scrolling to 100 screen lines.
63696a73
EZ
2950 (redisplay_window): Even when falling back on "recentering",
2951 position point in the window according to scroll-conservatively,
2952 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2953
2954 (try_scrolling): When point is above the window, allow searching
2955 as far as scroll_max, or one screenful, to compute vertical
2956 distance from PT to the scroll margin position. This prevents
2957 try_scrolling from unnecessarily failing when
2958 scroll-conservatively is set to a value slightly larger than the
2959 window height. Clean up the case of PT below the margin at bottom
2960 of window: scroll_max can no longer be INT_MAX. When aggressive
2961 scrolling is in use, don't let point enter the opposite scroll
2962 margin as result of the scroll.
2963 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2964 threshold of 100 lines for never-recentering scrolling.
2965
e4cc2dfc
JB
29662011-03-31 Juanma Barranquero <lekktu@gmail.com>
2967
2968 * dispextern.h (move_it_by_lines):
2969 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2970 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2971 (message_log_check_duplicate): Remove parameters `prev_bol' and
2972 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2973 (redisplay_internal): Remove parameter `preserve_echo_area',
2974 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2975
2976 * indent.c (Fvertical_motion):
2977 * window.c (window_scroll_pixel_based, Frecenter):
2978 Don't pass `need_y_p' to `move_it_by_lines'.
2979
1c470562
SM
29802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2981
44f230aa
SM
2982 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2983 steal a few bits to be more compact.
2984 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2985 Remove unneeded casts.
2986
1c470562
SM
2987 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2988
888adce9
ZK
29892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2990
2991 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2992 binding" message (bug#7967).
2993
f838ed7b
PE
29942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2995
77861b95
PE
2996 Fix more problems found by GCC 4.6.0's static checks.
2997
de6dbc14
PE
2998 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2999 Remove unused local var.
3000
f838ed7b
PE
3001 * editfns.c (Fmessage_box): Remove unused local var.
3002
792c7b2b
PE
3003 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3004 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3005 Omit unused local vars.
c499e557 3006 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3007 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3008 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3009 Omit unused local var.
3010
ba0165e1
PE
3011 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3012 Don't assume string length fits in int.
32ad8845 3013 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3014 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3015
3c59b4c9
PE
3016 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3017 instead of alloca (Bug#8344).
3018
a3eed478 3019 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3020 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3021
eb4d412d
PE
3022 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3023
1658b401
PE
3024 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3025 concerns.
3026
3027 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3028
3029 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3030
9a2c6e05
PE
3031 * keyboard.c (syms_of_keyboard): Use the same style as later
3032 in this function when indexing through an array. This also
3033 works around GCC bug 48267.
3034
03d0a109
PE
3035 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3036
44f730c8
PE
3037 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3038
fe75f926
PE
3039 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3040 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3041
ffa8c828
PE
3042 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3043 This avoids undefined behavior on integer overflow, and is a bit
3044 more convenient anyway since it is compared to a size_t variable.
3045
c5101a77
PE
3046 Variadic C functions now count arguments with size_t, not int.
3047 This avoids an unnecessary limitation on 64-bit machines, which
3048 caused (substring ...) to crash on large vectors (Bug#8344).
3049 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3050 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3051 All variadic functions and their callers changed accordingly.
c5101a77
PE
3052 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3053 * data.c (arith_driver, float_arith_driver): Likewise.
3054 * editfns.c (general_insert_function): Likewise.
3055 * eval.c (struct backtrace.nargs, interactive_p)
3056 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3057 (funcall_lambda, mark_backtrace): Likewise.
3058 * fns.c (concat): Likewise.
3059 * frame.c (x_set_frame_parameters): Likewise.
3060 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3061 0 if not found, not -1. All callers changed.
3062
dd3f25f7
PE
3063 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3064 (stack_copy_size): Now size_t, not int.
3065 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3066
461c2ab9
JB
30672011-03-28 Juanma Barranquero <lekktu@gmail.com>
3068
3069 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3070 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3071 All callers changed.
3072
3073 * lisp.h (multibyte_char_to_unibyte):
3074 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3075 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3076 * character.h (CHAR_TO_BYTE8):
3077 * cmds.c (internal_self_insert):
3078 * editfns.c (general_insert_function):
3079 * keymap.c (push_key_description):
3080 * search.c (Freplace_match):
3081 * xdisp.c (message_dolog, set_message_1): All callers changed.
3082
f6d62986
SM
30832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3084
3085 * keyboard.c (safe_run_hook_funcall): New function.
3086 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3087 don't set the hook to nil, but remove the offending function instead.
3088 (Qcommand_hook_internal): Remove, unused.
3089 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3090 Vcommand_hook_internal.
3091
3092 * eval.c (enum run_hooks_condition): Remove.
3093 (funcall_nil, funcall_not): New functions.
3094 (run_hook_with_args): Call each function through a `funcall' argument.
3095 Remove `cond' argument, now redundant.
3096 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3097 (Frun_hook_with_args_until_failure): Adjust accordingly.
3098 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3099
1db5b1ad
JB
31002011-03-28 Juanma Barranquero <lekktu@gmail.com>
3101
3102 * dispextern.h (string_buffer_position): Remove declaration.
3103
3104 * print.c (strout): Remove parameter `multibyte', unused since
3105 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3106
3107 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3108 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3109 All callers changed.
3110
3111 * w32.c (_wsa_errlist): Use braces for struct initializers.
3112
3113 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3114 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3115 All callers changed.
3116 (string_buffer_position): Likewise. Also, make static (it's never
3117 used outside xdisp.c).
3118 (cursor_row_p): Remove parameter `w', unused since
3119 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3120 (decode_mode_spec): Remove parameter `precision', introduced during
3121 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3122 All callers changed.
3123
5ffb62aa
JD
31242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3125
3126 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3127
461c2ab9 31282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3129
3130 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3131 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3132 (ns_update_auto_hide_menu_bar): New functions.
3133 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3134 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3135 ns_constrain_all_frames.
3136 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3137 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3138
5c380ffb
JD
31392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3140
3141 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3142
9af30bdf
GM
31432011-03-27 Glenn Morris <rgm@gnu.org>
3144
3145 * syssignal.h: Replace RETSIGTYPE with void.
3146 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3147 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3148 Replace SIGTYPE with void everywhere.
3149 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3150 * s/template.h (SIGTYPE): Remove commented out definition.
3151
e2abce01
JB
31522011-03-26 Eli Zaretskii <eliz@gnu.org>
3153
3154 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3155 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3156
f868cd8a
JB
31572011-03-26 Juanma Barranquero <lekktu@gmail.com>
3158
59eb0929
JB
3159 * w32.c (read_unc_volume): Use parameter `henum', instead of
3160 global variable `wget_enum_handle'.
3161
3162 * keymap.c (describe_vector): Remove parameters `indices' and
3163 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3164 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3165
f868cd8a
JB
3166 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3167
3168 * keyboard.c (timer_check): Remove parameter `do_it_now',
3169 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3170 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3171 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3172
3173 * keyboard.c (read_char):
3174 * w32menu.c (w32_menu_display_help):
3175 * xmenu.c (show_help_event, menu_help_callback):
3176 Adjust calls to `show_help_echo'.
3177
3178 * gtkutil.c (xg_maybe_add_timer):
3179 * keyboard.c (readable_events):
3180 * process.c (wait_reading_process_output):
3181 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3182
3183 * insdel.c (adjust_markers_gap_motion):
3184 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3185 (gap_left, gap_right): Don't call it.
3186
2ecf6fdb
CY
31872011-03-25 Chong Yidong <cyd@stupidchicken.com>
3188
3189 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3190 incurred during fontification.
3191
6b1f9ba4
JB
31922011-03-25 Juanma Barranquero <lekktu@gmail.com>
3193
3194 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3195 (DEFVAR_PER_BUFFER): Don't pass it.
3196
3197 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3198 (scrolling_window): Don't pass it.
3199
0f4a96b5
JB
32002011-03-25 Juanma Barranquero <lekktu@gmail.com>
3201
3202 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3203
3204 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3205 and `suffix'.
3206 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3207 of variables specific to SELinux and computation of `encoded_absname'.
3208
3209 * image.c (XPutPixel): Remove unused variable `height'.
3210
3211 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3212
3213 * unexw32.c (get_section_info): Remove unused variable `section'.
3214
3215 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3216 (system_process_attributes): Remove unused variable `sess'.
3217 (sys_read): Remove unused variable `err'.
3218
3219 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3220 (w32_wnd_proc): Remove unused variable `isdead'.
3221 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3222 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3223 (x_create_tip_frame): Remove unused variable `tem'.
3224
3225 * w32inevt.c (w32_console_read_socket):
3226 Remove unused variable `no_events'.
3227
3228 * w32term.c (x_draw_composite_glyph_string_foreground):
3229 Remove unused variable `width'.
3230
1149507c
JB
32312011-03-24 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * w32term.c (x_set_glyph_string_clipping):
3234 Don't pass uninitialized region to CombineRgn.
3235
9c88f339
JB
32362011-03-23 Juanma Barranquero <lekktu@gmail.com>
3237
3238 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3239 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3240 (Fx_close_connection): Remove unused variable `i'.
3241
3242 * w32font.c (w32font_draw): Return number of glyphs.
3243 (w32font_open_internal): Remove unused variable `i'.
3244 (w32font_driver): Add missing initializer.
3245
3246 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3247 (fill_in_menu): Remove unused variable `items_added'.
3248
3249 * w32term.c (last_mouse_press_frame): Remove static global variable.
3250 (w32_clip_to_row): Remove unused variable `f'.
3251 (x_delete_terminal): Remove unused variable `i'.
3252
3253 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3254 (NOTHING): Remove unused static global variable.
3255 (uniscribe_check_otf): Remove unused variable `table'.
3256 (uniscribe_font_driver): Add missing initializers.
3257
dee091a3
JD
32582011-03-23 Julien Danjou <julien@danjou.info>
3259
3260 * term.c (Fsuspend_tty, Fresume_tty):
3261 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3262 * window.c (temp_output_buffer_show):
3263 * insdel.c (signal_before_change):
3264 * frame.c (Fhandle_switch_frame):
3265 * fileio.c (Fdo_auto_save):
3266 * emacs.c (Fkill_emacs):
3267 * editfns.c (save_excursion_restore):
3268 * cmds.c (internal_self_insert):
3269 * callint.c (Fcall_interactively):
3270 * buffer.c (Fkill_all_local_variables):
3271 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3272 Use Frun_hooks.
0f4a96b5 3273 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3274 unconditionnaly since it does the check itself.
3275
2c520ab5 32762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3277
c9c49752
PE
3278 Fix more problems found by GCC 4.5.2's static checks.
3279
8abc3f12
PE
3280 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3281 the first time through the loop, since we know p0 < p1 then.
3282 This also avoids a gcc -Wstrict-overflow warning.
3283
a2d26660
PE
3284 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3285 leading to a memory leak, possible in functions like
3286 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3287 of objects (Bug#8318).
a2d26660 3288
916c72e9
PE
3289 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3290 that could (at least in theory) be that large.
3291
19ab8a18
PE
3292 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3293 This is less likely to overflow, and avoids undefined behavior if
3294 overflow does occur. All callers changed. Use strtoul to scan
3295 for the unsigned long integer.
b7cbbd6f
PE
3296 (pint2hrstr): Simplify and tune code slightly.
3297 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3298
f0641eff
PE
3299 * scroll.c (do_scrolling): Work around GCC bug 48228.
3300 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3301
7f650bb9
PE
3302 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3303 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3304 (validate_x_resource_name): Simplify count usage.
3305 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3306
37dd57d1
PE
3307 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3308 fail (Bug#8306).
81e56e61 3309
699979fc 3310 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3311
401bf9b4
PE
3312 * process.c (Fmake_network_process): Use socklen_t, not int,
3313 where POSIX says socklen_t is required in portable programs.
3314 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3315 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3316 (Fmake_network_process, server_accept_connection):
3317 (wait_reading_process_output, read_process_output):
3318 Likewise.
3319
b93aacde
PE
3320 * process.c: Rename or move locals to avoid shadowing.
3321 (list_processes_1, Fmake_network_process):
3322 (read_process_output_error_handler, exec_sentinel_error_handler):
3323 Rename or move locals.
4dc343ee 3324 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3325 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3326 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3327 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3328 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3329
af8a867c 3330 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3331 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3332 Include tparam.h instead, since it declares them.
af8a867c
PE
3333 * cm.h (PC): Remove extern decl; tparam.h now does this.
3334 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3335 * terminfo.c: Include tparam.h, to check interfaces.
3336 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3337 (tparam): Adjust signature to match interface in tparam.h;
3338 this removes some undefined behavior. Check that outstring and len
3339 are zero, which they always are with Emacs.
3340 * tparam.h (PC, BC, UP): New extern decls.
3341
0248044d 3342 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3343 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3344
8ff096c1 3345 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3346 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3347 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3348 (ftfont_list): Remove unused local.
49eaafba
PE
3349 (get_adstyle_property, ftfont_pattern_entity):
3350 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3351 Rename locals to avoid shadowing.
8ff096c1 3352
e2be39f6
PE
3353 * xfont.c (xfont_list_family): Mark var as initialized.
3354
c9735e30
PE
3355 * xml.c (make_dom): Now static.
3356
8f5201ae
PE
3357 * composite.c (composition_compute_stop_pos): Rename local to
3358 avoid shadowing.
b246f932
PE
3359 (composition_reseat_it): Remove unused locals.
3360 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3361 (composition_update_it): Mark var as initialized.
11b61122
PE
3362 (find_automatic_composition): Mark vars as initialized,
3363 with a FIXME (Bug#8290).
8f5201ae 3364
760fbc2c
PE
3365 character.h: Rename locals to avoid shadowing.
3366 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3367 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3368 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3369 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3370 to avoid shadowing.
3371
ff08eb85
PE
3372 * textprop.c (property_change_between_p): Remove; unused.
3373
fc7bf025
PE
3374 * intervals.c (interval_start_pos): Now static.
3375
235d7abc
PE
3376 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3377
44f230aa
SM
3378 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3379 Rename locals to avoid shadowing.
3e7d6594 3380
50060332
PE
3381 * sound.c (wav_play, au_play, Fplay_sound_internal):
3382 Fix pointer signedness.
d01f234b 3383 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3384 (wav_play): Initialize a variable to 0, to prevent undefined
3385 behavior (Bug#8278).
50060332 3386
c4fc4e30
PE
3387 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3388
918436ed
PE
3389 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3390
c939f91b
PE
3391 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3392 clobbering (Bug#8298).
b9c7f648
PE
3393 * sysdep.c (sys_subshell): Likewise.
3394 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3395
6bd8c144
PE
3396 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3397 This should get cleaned up, so that child_setup has the
3398 same signature on all platforms.
3399
7710357c 3400 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3401 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3402
c59da222
CY
34032011-03-22 Chong Yidong <cyd@stupidchicken.com>
3404
3405 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3406 not to be necessary, and produces flickering.
3407
66b87493
GM
34082011-03-20 Glenn Morris <rgm@gnu.org>
3409
3410 * config.in: Remove file.
3411
45b6f6d5
JB
34122011-03-20 Juanma Barranquero <lekktu@gmail.com>
3413
3414 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3415 are now in src/globals.h.
3416 (syms_of_minibuf): Remove spurious & from previous change.
3417
3ec03f7e
LL
34182011-03-20 Leo <sdl.web@gmail.com>
3419
3420 * minibuf.c (completing-read-function): New variable.
3421 (completing-read-default): Rename from completing-read.
3422 (completing-read): Call completing-read-function.
3423
b14e3e21
CY
34242011-03-19 Juanma Barranquero <lekktu@gmail.com>
3425
3426 * xfaces.c (Fx_load_color_file):
3427 Read color file from absolute filename (bug#8250).
3428
f2b726e6
JB
34292011-03-19 Juanma Barranquero <lekktu@gmail.com>
3430
3431 * makefile.w32-in: Update dependencies.
3432
09f6ff02
EZ
34332011-03-17 Eli Zaretskii <eliz@gnu.org>
3434
3435 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3436
29a6015a
PE
34372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3438
a3a6c54e
PE
3439 Fix more problems found by GCC 4.5.2's static checks.
3440
b766f867
PE
3441 * process.c (make_serial_process_unwind, send_process_trap):
3442 (sigchld_handler): Now static.
3443
be02381c
PE
3444 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3445 That way, the code declares only the vars that it needs.
3446 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3447 * s/cygwin.h (PTY_ITERATION): Likewise.
3448 * s/darwin.h (PTY_ITERATION): Likewise.
3449 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3450
57048744
PE
3451 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3452 * process.c (allocate_pty): Don't declare stb unless it's needed.
3453
7914961c 3454 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3455 (CONSTANTLIM): Remove; unused.
3456 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3457 Define only if needed.
7914961c 3458
b3967b18
PE
3459 * unexelf.c (unexec): Name an expression,
3460 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3461 Use a different way to cause a compilation error if anyone uses
3462 n rather than nn, a way that does not involve shadowing.
73366a00 3463 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3464
29a6015a
PE
3465 * deps.mk (unexalpha.o): Remove; unused.
3466
43cfc33e 3467 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3468 * unexec.h: New file.
ce701a33
PE
3469 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3470 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3471 Depend on unexec.h.
3472 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3473 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3474 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3475 Change as necessary to match prototype in unexec.h.
ce701a33 3476
01f44d5a
PE
3477 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3478 shadowing.
4f63c6bb 3479 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3480
a6670b0b
PE
3481 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3482 Rename locals to avoid shadowing.
3483
cef2010d 3484 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3485 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3486
d4d7173a
PE
3487 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3488
f08b802a
PE
3489 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3490 warning when compiling print.c.
3491
3ddb0639
PE
3492 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3493 instead of using an uninitialized var.
5ad03b97 3494 (font_sort_entities): Mark var as initialized.
3ddb0639 3495
170a2692
PE
3496 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3497
e663c700
PE
3498 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3499 pointers to constants.
89bc529a 3500 (font_parse_fcname): Remove unused vars.
7b81e2d0 3501 (font_delete_unmatched): Now static.
ea838e10 3502 (font_get_spec): Remove; unused.
13a547c6
PE
3503 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3504 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3505 Rename or move locals to avoid shadowing.
e663c700 3506
2a80c887 3507 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3508 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3509
1384fa33 3510 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3511 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3512
8b2c52e9
PE
3513 * alloc.c (mark_backtrace): Move decl from here ...
3514 * lisp.h: ... to here, so that it can be checked.
3515
475545b5 3516 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3517 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3518 (lisp_indirect_variable): Name an expression,
3519 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3520 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3521
b1349114 3522 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3523 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3524 Use const pointer when appropriate.
b1349114 3525
a2928364
PE
3526 * lisp.h (get_system_name, get_operating_system_release):
3527 Move decls here, to check interfaces.
3528 * process.c (get_operating_system_release): Move decl to lisp.h.
3529 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3530 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3531 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3532 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3533 (Fformat_time_string, Fencode_time, Finsert_char):
3534 (Ftranslate_region_internal, Fformat):
3535 Rename or remove local vars to avoid shadowing.
9710023e 3536 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3537
a415e694
PE
3538 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3539 avoid shadowing.
3540
8ef4622d
PE
3541 * lisp.h (eassert): Check that the argument compiles, even if
3542 ENABLE_CHECKING is not defined.
3543
946f9a5b
PE
3544 * data.c (Findirect_variable): Name an expression, to avoid
3545 gcc -Wbad-function-cast warning.
112396d6 3546 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3547 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3548 (Fmake_variable_buffer_local, Fmake_local_variable):
3549 Mark variables as initialized.
52746918 3550 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3551
e5aab7e7 3552 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3553 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3554 Rename locals to avoid shadowing.
dff45157
PE
3555 (mark_stack): Move local variables into the #ifdef region where
3556 they're used.
7bc26fdb
PE
3557 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3558 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3559 needed otherwise.
3560 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3561 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3562 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3563
e5aab7e7
PE
3564 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3565 avoids undefined behavior in theory.
3566
4da60324
PE
3567 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3568
88043301
PE
3569 Use functions, not macros, for up- and down-casing (Bug#8254).
3570 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3571 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3572 to use the following functions instead of these macros.
3573 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3574 EMACS_INT, since callers assume the returned value fits in int.
3575 (upcase1): Likewise, for UPCASE_TABLE.
3576 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3577 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3578 the race-condition problem in the old DOWNCASE.
88043301 3579
19ed5445
PE
3580 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3581 Rename locals to avoid shadowing.
3582 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3583 (regex_compile, re_search_2, re_match_2_internal):
3584 Remove unused local vars.
952db0d7
PE
3585 (FREE_VAR): Rewrite so as not to use empty "else",
3586 which gcc can warn about.
da053e48 3587 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3588 (RETALLOC_IF): Define only if needed.
3589 (WORDCHAR_P): Likewise. This one is never needed, but is used
3590 only in a comment talking about a compiler bug, so put inside
3591 the #if 0 of that comment.
3592 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3593 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3594 Remove; unused.
19ed5445 3595
1f3561e4 3596 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3597 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3598 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3599
ded6f8f7
PE
3600 * search.c (simple_search): Remove unused var.
3601
dbd37a95
PE
3602 * dired.c (compile_pattern): Move decl from here ...
3603 * lisp.h: ... to here, so that it can be checked.
3604 (struct re_registers): New forward decl.
3605
7e47afad
PE
3606 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3607
85f24f61
PE
3608 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3609 All uses changed.
3610 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3611 Rename locals to avoid shadowing.
5671df8f 3612 (Fvertical_motion): Mark locals as initialized.
85f24f61 3613
181aa2be 3614 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3615 (casify_region): Mark local as initialized.
181aa2be 3616
930d429c
PE
3617 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3618
7082eac6
PE
3619 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3620 New macros, so that the caller can use some names other than
3621 gcpro1, gcpro2, etc.
3622 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3623 of the new macros.
3624 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3625 argument, for consistency with GCPRO2_VAR, etc: it is now the
3626 prefix of the variable, not the variable itself. All uses
3627 changed.
38b2c076
PE
3628 * dired.c (directory_files_internal, file_name_completion):
3629 Rename locals to avoid shadowing.
3630
15206ed9
PE
3631 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3632 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3633 dired.c's scmp function, had undefined behavior.
3634 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3635 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3636 * buffer.h: ... to here, because these macros use current_buffer,
3637 and the new implementation with inline functions needs to have
3638 current_buffer in scope now, rather than later when the macros
3639 are used.
3640 (downcase, upcase1): New static inline functions.
3641 (DOWNCASE, UPCASE1): Reimplement using these functions.
3642 This avoids undefined behavior in expressions like
3643 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3644 from race conditions in accessing the global variables
3645 case_temp1 and case_temp2.
3646 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3647 * lisp.h (case_temp1, case_temp2): Remove their decls.
3648 * character.h (ASCII_CHAR_P): Move from here ...
3649 * lisp.h: ... to here, so that the inline functions mentioned
3650 above can use them.
3651
4a6bea26
PE
3652 * dired.c (directory_files_internal_unwind): Now static.
3653
f14b7e14
PE
3654 * fileio.c (file_name_as_directory, directory_file_name):
3655 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3656 Now static.
2893f146
PE
3657 (file_name_as_directory): Use const pointers when appropriate.
3658 (Fexpand_file_name): Likewise. In particular, newdir might
3659 point at constant storage, so make it a const pointer.
fd4ead52 3660 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3661 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3662 signedness issues.
f839df0c
PE
3663 (Fset_file_times, Finsert_file_contents, auto_save_error):
3664 Rename locals to avoid shadowing.
f14b7e14 3665
5716756e 3666 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3667 (Ftry_completion, Fall_completions): Rename or remove locals
3668 to avoid shadowing.
5716756e 3669
b4c3046a
PE
3670 * marker.c (bytepos_to_charpos): Remove; unused.
3671
b45db522
PE
3672 * lisp.h (verify_bytepos, count_markers): New decls,
3673 so that gcc does not warn that these functions aren't declared.
3674
85876d07
PE
3675 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3676 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3677 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3678 (copy_text): Remove unused local var.
85876d07 3679
03d78a21 3680 * filelock.c (within_one_second): Now static.
b3dd38ab 3681 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3682
5df8f01b
PE
3683 * buffer.c (fix_overlays_before): Mark locals as initialized.
3684 (fix_start_end_in_overlays): Likewise. This function should be
3685 simplified by using pointers-to-pointers, but that's a different
3686 matter.
b1d876f1 3687 (switch_to_buffer_1): Now static.
8f54f30a
PE
3688 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3689 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3690
a70072c9 3691 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3692 Fix pointer signedness issue.
edced198
PE
3693 (sys_subshell): Mark local as volatile if checking for lint,
3694 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3695 (MAXPATHLEN): Define only if needed.
a70072c9 3696
a0977c44
PE
3697 * process.c (serial_open, serial_configure): Move decls from here ...
3698 * systty.h: ... to here, so that they can be checked.
3699
a884fdcc
PE
3700 * fns.c (get_random, seed_random): Move extern decls from here ...
3701 * lisp.h: ... to here, so that they can be checked.
3702
604efe86 3703 * sysdep.c (reset_io): Now static.
b8950c94 3704 (wait_for_termination_signal): Remove; unused.
604efe86 3705
38fc62d9
PE
3706 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3707 (copy_keymap_item, append_key, push_text_char_description):
3708 Now static.
1004a21a 3709 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3710 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3711 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3712 (describe_map_tree):
3713 Rename locals to avoid shadowing.
38fc62d9 3714
2f2650da
PE
3715 * keyboard.c: Declare functions static if they are not used elsewhere.
3716 (echo_char, echo_dash, cmd_error, top_level_2):
3717 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3718 (read_char, kbd_buffer_get_event, make_lispy_position):
3719 (make_lispy_event, make_lispy_movement, apply_modifiers):
3720 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3721 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3722 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3723 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3724 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3725
a053e86c 3726 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3727 (mark_kboards): Move decl here ...
3728 * alloc.c (mark_kboards): ... from here.
a053e86c 3729
4752793e
PE
3730 * lisp.h (force_auto_save_soon): New decl.
3731
74f10ca7 3732 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3733 (DEFINE_DUMMY_FUNCTION): New macro.
3734 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3735 Use it.
c03cd23f
PE
3736 (main): Add casts to avoid warnings
3737 if GCC considers string literals to be constants.
74f10ca7 3738
022e70d4
PE
3739 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3740
59d6fe83
PE
3741 * dbusbind.c: Pointer signedness fixes.
3742 (xd_signature, xd_append_arg, xd_initialize):
3743 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3744 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3745 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3746 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3747
78320123
PE
3748 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3749 if GCC considers string literals to be constants.
49cebcca 3750 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3751
35ac2a97
SM
37522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3753
fb103ca9
SM
3754 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3755 (print_preprocess, print_object): New macro to fix last change.
3756
35ac2a97
SM
3757 * print.c (print_preprocess): Don't forget font objects.
3758
62973b41
JB
37592011-03-16 Juanma Barranquero <lekktu@gmail.com>
3760
3761 * emacs.c (USAGE3): Doc fixes.
3762
0e48bb22
AS
37632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3764
3765 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3766 structure.
3767
7684e57b
JB
37682011-03-14 Juanma Barranquero <lekktu@gmail.com>
3769
3770 * lisp.h (VWindow_system, Qfile_name_history):
3771 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3772 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3773 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3774
3775 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3776 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3777
3778 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3779 * w32console.c (detect_input_pending, read_input_pending)
3780 (encode_terminal_code):
3781 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3782 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3783 (w32_system_caret_y, Qfile_name_history):
3784 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3785 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3786 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3787 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3788 * w32proc.c (Qlocal, report_file_error):
3789 * w32term.c (Vwindow_system, updating_frame):
3790 * w32uniscribe.c (initialized, uniscribe_font_driver):
3791 Remove unneeded extern declarations.
3792
2aa46d6c
CY
37932011-03-14 Chong Yidong <cyd@stupidchicken.com>
3794
c96bbc66 3795 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3796
cffc6f3b
CY
37972011-03-13 Chong Yidong <cyd@stupidchicken.com>
3798
3799 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3800 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3801 These macros can no longer be used for assignment.
3802
44f230aa
SM
3803 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3804 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3805 (record_buffer_markers, fetch_buffer_markers): New functions for
3806 recording and fetching special buffer markers.
3807 (set_buffer_internal_1, set_buffer_temp): Use them.
3808
3809 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3810
3811 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3812
3813 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3814 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3815
3816 * xdisp.c (hscroll_window_tree):
3817 (reconsider_clip_changes): Use PT instead of BUF_PT.
3818
d251f04b
EZ
38192011-03-13 Eli Zaretskii <eliz@gnu.org>
3820
3821 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3822 $(EMACS_ROOT)/lib/intprops.h.
3823
f0c77cd1
PE
38242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3825
3eca4629
PE
3826 Fix more problems found by GCC 4.5.2's static checks.
3827
7c86ee98
PE
3828 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3829 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3830 (xg_free_frame_widgets): Make it clear that a local variable is
3831 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3832 (gdk_window_get_screen): Make it clear that this macro is needed
3833 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3834 (int_gtk_range_get_value): New function, which avoids a diagnostic
3835 from gcc -Wbad-function-cast.
3836 (xg_set_toolkit_scroll_bar_thumb): Use it.
3837 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3838 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3839 (get_utf8_string, xg_get_file_with_chooser):
3840 Rename locals to avoid shadowing.
3841 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3842
41729b81
PE
3843 * xgselect.c (xg_select): Remove unused var.
3844
f0c77cd1
PE
3845 * image.c (four_corners_best): Mark locals as initialized.
3846 (gif_load): Initialize transparent_p to zero (Bug#8238).
3847 Mark another local as initialized.
ec6cf4c6 3848 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3849
ce0ad53d 3850 * image.c (clear_image_cache): Now static.
d5d5a617 3851 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3852 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3853 (x_edge_detection): Remove unnecessary cast that
3854 gcc -Wbad-function-cast diagnoses.
2037898d 3855 (gif_load): Fix pointer signedness.
6ae141d6
PE
3856 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3857 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3858
33383987 38592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3860
d32df629
PE
3861 Improve quality of tests for time stamp overflow.
3862 For example, without this patch (encode-time 0 0 0 1 1
3863 1152921504606846976) returns the obviously-bogus value (-948597
3864 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3865 reports time overflow. See
3866 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3867 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3868 * editfns.c: Include limits.h and intprops.h.
3869 (TIME_T_MIN, TIME_T_MAX): New macros.
3870 (time_overflow): Move earlier, to before first use.
3871 (hi_time, lo_time): New functions, for an accurate test for
3872 out-of-range times.
3873 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3874 (Fget_internal_run_time): Don't assume time_t fits in int.
3875 (make_time): Use list2 instead of Fcons twice.
3876 (Fdecode_time): More accurate test for out-of-range times.
3877 (check_tm_member): New function.
3878 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3879 (lisp_time_argument): Don't rely on undefined left-shift and
3880 right-shift behavior when checking for time stamp overflow.
8be6f318 3881
fe31d94c
PE
3882 * editfns.c (time_overflow): New function, refactoring common code.
3883 (Fformat_time_string, Fdecode_time, Fencode_time):
3884 (Fcurrent_time_string): Use it.
3885
8be6f318
PE
3886 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3887 * dired.c (make_time): Move to ...
3888 * editfns.c (make_time): ... here.
3889 * systime.h: Note the move.
3890
09d9db2c 38912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3892
126bc0dc
YM
3893 * fringe.c (update_window_fringes): Remove unused variables.
3894
c47cbdfd
YM
3895 * unexmacosx.c (copy_data_segment): Also copy __got section.
3896 (Bug#8223)
3897
7ac80be9
EZ
38982011-03-12 Eli Zaretskii <eliz@gnu.org>
3899
c96bbc66 3900 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3901 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3902 Constify `char *' arguments and their references according to
3903 prototypes in tparam.h.
3904
ecb0f94d 3905 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3906
7ac80be9
EZ
3907 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3908 Adapt all references accordingly.
3909
3910 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3911
ef1fd07e
TT
39122011-03-11 Tom Tromey <tromey@redhat.com>
3913
3914 * buffer.c (syms_of_buffer): Remove obsolete comment.
3915
7ef4b50c
EZ
39162011-03-11 Eli Zaretskii <eliz@gnu.org>
3917
3918 * termhooks.h (encode_terminal_code): Declare prototype.
3919
3920 * msdos.c (encode_terminal_code): Don't declare prototype.
3921
3922 * term.c (encode_terminal_code): Now external again, used by
3923 w32console.c and msdos.c.
3924
44f230aa
SM
3925 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3926 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3927
4b1ec863 39282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3929
1714f52b 3930 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3931
4b1ec863
PE
3932 * fringe.c (update_window_fringes): Mark locals as initialized
3933 (Bug#8227).
3934 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3935
524c7aa6
PE
3936 * alloc.c (mark_fringe_data): Move decl from here ...
3937 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3938 to check its interface.
3939 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3940
a5c0af81 3941 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3942 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3943 (fontset_font): Mark local as initialized.
a9a06e0b 3944 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3945
b4716021
PE
3946 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3947
811e9bac 3948 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3949 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3950 (x_own_selection, Fx_disown_selection_internal): Rename locals
3951 to avoid shadowing.
3952 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3953
7e3ab302
PE
3954 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3955 so that the caller can use some name other than gcpro1.
3956 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3957 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3958 (Fx_backspace_delete_keys_p):
3959 Use them to avoid shadowing, and rename vars to avoid shadowing.
3960 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3961 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3962 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3963 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3964 Remove unused locals.
7e3ab302
PE
3965 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3966 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3967 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3968 macros.
f78faa98 3969
e2b13473
PE
3970 * xterm.h (x_mouse_leave): New decl.
3971
77f23912
PE
3972 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3973 Remove unused functions.
cdf4ba58
PE
3974 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3975 (x_calc_absolute_position): Now static.
7411c686 3976 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3977 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3978 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3979 unless they are used.
38d0b34a
PE
3980 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3981 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3982 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3983 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3984 (x_error_catcher, x_connection_closed, x_error_handler):
3985 (x_error_quitter, xembed_send_message, x_iconify_frame):
3986 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3987 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3988 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3989
44f230aa
SM
3990 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3991 Rename or move locals to avoid shadowing.
6b463e58 3992 (tty_defined_color, merge_face_heights): Now static.
5967d051 3993 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3994 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3995 does not deduce is never used uninitialized.
73719eba
PE
3996 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3997 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3998
426994c3 3999 * terminal.c (store_terminal_param): Now static.
5489860b 4000
032f1620 4001 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4002 (set_frame_menubar): Remove unused local.
d4323972 4003 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4004 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4005 since they might point to immutable storage.
281585b0
PE
4006 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4007 since it's unused otherwise.
032f1620 4008
367c19e5 4009 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4010 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4011 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4012 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4013 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4014 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4015 does not deduce are never used uninitialized.
70739cbe 4016
07b48fa9
PE
4017 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4018
8868a238 4019 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4020 * window.c (window_loop, size_window):
4021 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4022
7e5cf297 4023 * window.c (display_buffer): Now static.
d6550a9f
PE
4024 (size_window): Mark variables that gcc -Wuninitialized
4025 does not deduce are never used uninitialized.
a586633d
PE
4026 * window.h (check_all_windows): New decl, to forestall
4027 gcc -Wmissing-prototypes diagnostic.
5b555da1 4028 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4029
f6095868
PE
4030 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4031 shadowing.
4032 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4033 Include <limits.h>.
4034 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4035 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4036 (load_charset_map): Mark variables that gcc -Wuninitialized
4037 does not deduce are never used uninitialized.
53df7c11 4038 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4039
f38b440c
PE
4040 * coding.c (coding_set_source, coding_set_destination):
4041 Use "else { /* comment */ }" rather than "else /* comment */;"
4042 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4043 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4044 a block, when the outer 'i' will do.
4045 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4046 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4047 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4048 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4049 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4050 Rename locals to avoid shadowing.
4051 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4052 * coding.c (emacs_mule_char, encode_invocation_designation):
4053 Now static, since they're not used elsewhere.
413bb2db 4054 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4055 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4056 (decode_coding_emacs_mule): Mark variables that gcc
4057 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4058 (detect_coding_iso_2022): Initialize a local variable that might
4059 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4060 this initialization is needed. (Bug#8211)
5f58e762
PE
4061 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4062 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4063 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4064 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4065 Remove unused macros.
f38b440c 4066
232b38b9 4067 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4068 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4069 * character.c (string_count_byte8): Likewise.
232b38b9 4070
fb90da1b
PE
4071 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4072 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4073
fb93dbc2
PE
4074 * chartab.c (copy_sub_char_table): Now static, since it's not used
4075 elsewhere.
5c156ace
PE
4076 (sub_char_table_ref_and_range, char_table_ref_and_range):
4077 Rename locals to avoid shadowing.
bbcd0949 4078 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4079
7d3b3862 4080 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4081 (BIDI_BOB): Remove unused macro.
7d3b3862 4082
6be7d3da
PE
4083 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4084 deduce are never used uninitialized.
c2ed9c8b 4085 * term.c (encode_terminal_code): Likewise.
6be7d3da 4086
75f8807f 4087 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4088
50938595
PE
4089 * tparam.h: New file.
4090 * term.c, tparam.h: Include it.
4091 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4092 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4093 Move these decls to tparam.h, and make them agree with what
4094 is actually in tparam.c. The previous trick of using incompatible
4095 decls in different modules does not conform to the C standard.
4096 All callers of tparam changed to use tparam's actual API.
4097 * tparam.c (tparam1, tparam, tgoto):
4098 Use const pointers where appropriate.
4099
fbceeba2
PE
4100 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4101 * cm.h (struct cm): Likewise.
4102 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4103 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4104 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4105 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4106 (turn_on_face, init_tty): Likewise.
4107 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4108
7f3f1250
PE
4109 * term.c (term_mouse_position): Rename local to avoid shadowing.
4110
e6ca6543
PE
4111 * alloc.c (mark_ttys): Move decl from here ...
4112 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4113
c40f8d15
AS
41142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4117
cfe0661d
JB
41182011-03-09 Juanma Barranquero <lekktu@gmail.com>
4119
4120 * search.c (compile_pattern_1): Remove argument regp, unused since
4121 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4122 (compile_pattern): Don't pass it.
4123
0afb4571
J
41242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4125
4126 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4127 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4128 for ! HAVE_GTK3.
4129 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4130
4131 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4132
4133 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4134 gdk_window_get_screen, gdk_window_get_geometry,
4135 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4136 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4137 (xg_get_pixbuf_from_pixmap): New function.
4138 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4139 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4140 Call xg_get_pixbuf_from_pixmap instead of
4141 gdk_pixbuf_get_from_drawable.
4142 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4143 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4144 (xg_check_special_colors): Use GtkStyleContext and its functions
4145 for HAVE_GTK3.
4146 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4147 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4148 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4149 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4150 Call gtk_widget_get_preferred_size.
0afb4571
J
4151 (xg_frame_resized): gdk_window_get_geometry only takes 5
4152 parameters.
44f230aa
SM
4153 (xg_win_to_widget, xg_event_is_for_menubar):
4154 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4155 (xg_set_widget_bg): New function.
4156 (delete_cb): New function.
895009e1 4157 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4158 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4159 (xg_set_background_color): Call xg_set_widget_bg.
4160 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4161 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4162 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4163 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4164 if ! HAVE_GTK3.
4165 (update_frame_tool_bar): Call gtk_widget_hide.
4166 (xg_initialize): Use GDK_KEY_g.
4167
4168 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4169 if ! HAVE_GTK3
4170 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4171
4172 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4173 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4174 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4175
1c2cc4ef
JB
41762011-03-08 Juanma Barranquero <lekktu@gmail.com>
4177
4178 * w32xfns.c (select_palette): Check success of RealizePalette against
4179 GDI_ERROR, not zero.
4180
33383987 4181See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4182
4183;; Local Variables:
4184;; coding: utf-8
aac0c6e3
MR
4185;; End:
4186
33383987 4187 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4188
4189 This file is part of GNU Emacs.
4190
4191 GNU Emacs is free software: you can redistribute it and/or modify
4192 it under the terms of the GNU General Public License as published by
4193 the Free Software Foundation, either version 3 of the License, or
4194 (at your option) any later version.
4195
4196 GNU Emacs is distributed in the hope that it will be useful,
4197 but WITHOUT ANY WARRANTY; without even the implied warranty of
4198 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4199 GNU General Public License for more details.
4200
4201 You should have received a copy of the GNU General Public License
4202 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.