A few new functions and rewrites in window.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f3d1777e
MR
12011-06-08 Martin Rudalics <rudalics@gmx.at>
2
496e208e
MR
3 * window.h (window): Add some new members to window structure -
4 normal_lines, normal_cols, new_total, new_normal, clone_number,
5 splits, nest, prev_buffers, next_buffers.
6 (WINDOW_TOTAL_SIZE): Move here from window.c.
7 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define.
8
f3d1777e
MR
9 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10 Remove.
496e208e
MR
11 (make_dummy_parent): Set new members of windows structure.
12 (make_window): Move down in code. Handle new members of window
13 structure.
14 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
15 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
16 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
17 (Fset_window_prev_buffers, Fwindow_next_buffers)
18 (Fset_window_next_buffers, Fset_window_clone_number): New
19 functions.
20 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
21 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
22 Doc-string fixes.
23 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
24 Argument WINDOW can be now internal window too.
25 (Fwindow_use_time): Move up in code.
26 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
27 Rewrite doc-string.
28 (Fset_window_configuration, saved_window)
29 (Fcurrent_window_configuration, save_window_save): Handle new
30 members of window structure.
31 (WINDOW_TOTAL_SIZE): Move to window.h.
f3d1777e 32
abde8f8c
MR
332011-06-07 Martin Rudalics <rudalics@gmx.at>
34
35 * window.c (Fwindow_total_size, Fwindow_left_column)
36 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
37 (Fwindow_list_1): New functions.
38 (window_box_text_cols): Replace with window_body_cols.
39 (Fwindow_width, Fscroll_left, Fscroll_right): Use
40 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
41 (delete_window, Fset_window_configuration): Call
42 delete_all_subwindows with window as argument.
43 (delete_all_subwindows): Take a window as argument and not a
44 structure. Rewrite.
190b47e6
MR
45 (window_loop): Remove handling of GET_LRU_WINDOW and
46 GET_LARGEST_WINDOW.
47 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
48
49 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
50 window_box_text_cols. delete_all_subwindows now takes a
51 Lisp_Object as argument.
abde8f8c
MR
52
53 * indent.c (compute_motion, Fcompute_motion): Use
54 window_body_cols instead of window_box_text_cols.
55
fa8a67e6
MR
56 * frame.c (delete_frame): Call delete_all_subwindows with root
57 window as argument.
58
a54e3482
DC
592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
60
61 * fns.c (Fputhash): Document return value.
62
60002bf5
CY
632011-06-06 Chong Yidong <cyd@stupidchicken.com>
64
65 * image.c (gif_load): Implement gif89a spec "no disposal" method.
66
0c671da6 672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 68
b862a52a 69 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 70
be44ca6c
PE
71 Check for overflow when converting integer to cons and back.
72 * charset.c (Fdefine_charset_internal, Fdecode_char):
73 Use cons_to_unsigned to catch overflow.
74 (Fencode_char): Use INTEGER_TO_CONS.
75 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
76 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
77 * data.c (long_to_cons, cons_to_long): Remove.
78 (cons_to_unsigned, cons_to_signed): New functions.
79 These signal an error for invalid or out-of-range values.
80 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
81 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
82 * font.c (Ffont_variation_glyphs):
83 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
84 * lisp.h: Include <intprops.h>.
85 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
86 (cons_to_signed, cons_to_unsigned): New decls.
87 (long_to_cons, cons_to_long): Remove decls.
88 * undo.c (record_first_change): Use INTEGER_TO_CONS.
89 (Fprimitive_undo): Use CONS_TO_INTEGER.
90 * xfns.c (Fx_window_property): Likewise.
91 * xselect.c: Include <limits.h>.
92 (x_own_selection, selection_data_to_lisp_data):
93 Use INTEGER_TO_CONS.
94 (x_handle_selection_request, x_handle_selection_clear)
95 (x_get_foreign_selection, Fx_disown_selection_internal)
96 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
97 (lisp_data_to_selection_data): Use cons_to_unsigned.
98 (x_fill_property_data): Use cons_to_signed.
99 Report values out of range.
100
d1f3d2af
PE
101 Check for buffer and string overflow more precisely.
102 * buffer.h (BUF_BYTES_MAX): New macro.
103 * lisp.h (STRING_BYTES_MAX): New macro.
104 * alloc.c (Fmake_string):
105 * character.c (string_escape_byte8):
106 * coding.c (coding_alloc_by_realloc):
107 * doprnt.c (doprnt):
108 * editfns.c (Fformat):
109 * eval.c (verror):
110 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
111 since they may not be the same number.
112 * editfns.c (Finsert_char):
113 * fileio.c (Finsert_file_contents):
114 Likewise for BUF_BYTES_MAX.
115
dd52fcea
PE
116 * image.c: Use ptrdiff_t, not int, for sizes.
117 (slurp_file): Switch from int to ptrdiff_t.
118 All uses changed.
119 (slurp_file): Check that file size fits in both size_t (for
120 malloc) and ptrdiff_t (for sanity and safety).
121
7f9bbdbb
PE
122 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
123 if b->modtime has its maximal value.
124
dfe18f82
PE
125 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
126
84acfcf0
PE
127 Don't assume time_t can fit into int.
128 * buffer.h (struct buffer.modtime): Now time_t, not int.
129 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
130 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
131
ccd9a01a
PE
132 Minor fixes for signed vs unsigned integers.
133 * character.h (MAYBE_UNIFY_CHAR):
134 * charset.c (maybe_unify_char):
135 * keyboard.c (read_char, reorder_modifiers):
136 XINT -> XFASTINT, since the integer must be nonnegative.
137 * ftfont.c (ftfont_spec_pattern):
138 * keymap.c (access_keymap, silly_event_symbol_error):
139 XUINT -> XFASTINT, since the integer must be nonnegative.
140 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
141 since it makes no difference and we prefer signed.
142 * keyboard.c (record_char): Use XUINT when all the neighbors do.
143 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
144 nonnegative.
145
d6d100dd
SM
1462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
147
148 * window.h (Fwindow_frame): Declare.
149
2b6148e4
PE
1502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
151
152 * alloc.c: Simplify handling of large-request failures (Bug#8800).
153 (SPARE_MEMORY): Always define.
154 (LARGE_REQUEST): Remove.
155 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
156
f230ecc9
MR
1572011-06-06 Martin Rudalics <rudalics@gmx.at>
158
727e958e
MR
159 * lisp.h: Move EXFUNS for Fframe_root_window,
160 Fframe_first_window and Fset_frame_selected_window to window.h.
161
162 * window.h: Move EXFUNS for Fframe_root_window,
163 Fframe_first_window and Fset_frame_selected_window here from
164 lisp.h.
165
166 * frame.c (Fwindow_frame, Fframe_first_window)
167 (Fframe_root_window, Fframe_selected_window)
168 (Fset_frame_selected_window): Move to window.c.
169 (Factive_minibuffer_window): Move to minibuf.c.
170 (Fother_visible_frames_p): New function.
171
172 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
173
f230ecc9
MR
174 * window.c (decode_window, decode_any_window): Move up in code.
175 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
176 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
177 (Fwindow_buffer): Move up and rewrite doc-string.
178 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
179 (Fwindow_prev): New functions.
727e958e
MR
180 (Fwindow_frame): Move here from frame.c. Accept any window as
181 argument.
182 (Fframe_root_window, Fframe_first_window)
183 (Fframe_selected_window): Move here from frame.c. Accept frame
184 or arbitrary window as argument. Update doc-strings.
185 (Fminibuffer_window): Move up in code.
186 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
187 (Fset_frame_selected_window): Move here from frame.c.
188 Marginal rewrite.
727e958e
MR
189 (Fselected_window, select_window, Fselect_window): Move up in
190 code. Minor doc-string fixes.
f230ecc9 191
4d09bcf6
PE
1922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
193
194 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
195 Do not assume that spare memory exists; that assumption is valid
196 only if SYSTEM_MALLOC.
197 (LARGE_REQUEST): New macro, so that the issue of large requests
198 is separated from the issue of spare memory.
199
810928a2
AS
2002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
201
172418ad
AS
202 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
203 format. (Bug#8806)
204
43f862f7
AS
205 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
206
810928a2
AS
207 * xfns.c (x_set_scroll_bar_default_width): Move declarations
208 before statements.
209
a059fe24
JD
2102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
211
212 * gtkutil.c (xg_get_default_scrollbar_width): New function.
213
214 * gtkutil.h: Declare xg_get_default_scrollbar_width.
215
216 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
217 min width by calling x_set_scroll_bar_default_width (Bug#8505).
218
989bf368
JB
2192011-06-05 Juanma Barranquero <lekktu@gmail.com>
220
221 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
222
4b80f674
CY
2232011-06-04 Chong Yidong <cyd@stupidchicken.com>
224
225 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
226 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
227 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
228 New error handlers.
4b80f674
CY
229 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
230 Obey Vx_select_enable_clipboard_manager. Catch errors in
231 x_clipboard_manager_save (Bug#8779).
232 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 233 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 234
99a33b77 2352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
236
237 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
238
99a33b77 2392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
240
241 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
242 in the current matrix if keep_current_p is non-zero.
243
8264569d
EZ
2442011-06-04 Eli Zaretskii <eliz@gnu.org>
245
246 * bidi.c (bidi_level_of_next_char): Fix last change.
247
57f97249
EZ
2482011-06-03 Eli Zaretskii <eliz@gnu.org>
249
fec2107c 250 Support bidi reordering of text covered by display properties.
57f97249 251
fec2107c
EZ
252 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
253 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
254 (bidi_cache_search, bidi_cache_iterator_state)
255 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
256 (bidi_level_of_next_char, bidi_move_to_visually_next):
257 Support character positions inside a run of characters covered by a
fec2107c
EZ
258 display string.
259 (bidi_paragraph_init, bidi_resolve_explicit_1)
260 (bidi_level_of_next_char): Call bidi_fetch_char and
261 bidi_fetch_char_advance instead of FETCH_CHAR and
262 FETCH_CHAR_ADVANCE.
263 (bidi_init_it): Initialize new members.
264 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
265 definitions.
266 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
267 instead of using explicit *_CHAR codes.
d6d100dd
SM
268 (bidi_resolve_explicit, bidi_resolve_weak):
269 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
270 bidirectional text is supported only in multibyte buffers.
271 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
272 it to initialize the frame_window_p member of struct bidi_it.
273 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
274 (bidi_resolve_explicit, bidi_resolve_weak)
275 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
276 bidi_it->nchars is non-positive.
277 (bidi_level_of_next_char): Don't try to lookup the cache for the
278 next/previous character if nothing is cached there yet, or if we
279 were just reseat()'ed to a new position.
c40e2fb2 280
0e14fe90
EZ
281 * xdisp.c (set_cursor_from_row): Set start and stop points
282 according to the row's direction when priming the loop that looks
283 for the glyph on which to display cursor.
284 (single_display_spec_intangible_p): Function deleted.
285 (display_prop_intangible_p): Reimplement to call
286 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
287 Accept 3 additional arguments needed by handle_display_spec.
288 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
289 values: lists, `(when COND...)' forms, etc.
290 (single_display_spec_string_p): Support property values that are
291 lists with the argument STRING its top-level element.
292 (display_prop_string_p): Fix the condition for processing a
293 property that is a list to be consistent with handle_display_spec.
fec2107c 294 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
295 last portion of handle_display_prop.
296 (compute_display_string_pos): Accept additional argument
297 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
298 value of a `display' property is a "replacing spec".
299 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
300 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
301 the display property, but just return a value indicating whether
302 the display property will replace the characters it covers.
303 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
304 frame_window_p members of struct bidi_it.
d6d100dd
SM
305 (compute_display_string_pos, compute_display_string_end):
306 New functions.
fec2107c
EZ
307 (push_it): Accept second argument POSITION, where pop_it should
308 jump to continue iteration.
309 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 310
fec2107c
EZ
311 * keyboard.c (adjust_point_for_property): Adjust the call to
312 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
313
314 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
315 (bidi_init_it): Update prototypes.
316 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
317 (compute_display_string_pos, compute_display_string_end):
318 Declare prototypes.
fec2107c
EZ
319 (struct bidi_it): New members nchars and disp_pos. ch_len is now
320 EMACS_INT.
fc6f18ce 321
40087514 3222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 323
57f53182
PE
324 Malloc failure behavior now depends on size of allocation.
325 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
326 * lisp.h: Change signatures accordingly.
327 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
328 All callers changed. (Bug#8762)
329
330 * gnutls.c: Use Emacs's memory allocators.
331 Without this change, the gnutls library would invoke malloc etc.
332 directly, which causes problems on non-SYNC_INPUT hosts, and which
333 runs afoul of improving memory_full behavior. (Bug#8761)
334 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
335 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
336 xfree instead of the default malloc, realloc, free.
337 (Fgnutls_boot): No need to check for memory allocation failure,
338 since xmalloc does that for us.
339
ac32cd99 340 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
341 * category.c (hash_get_category_set):
342 * ccl.c (ccl_driver):
343 * charset.c (Fdefine_charset_internal):
344 * charset.h (struct charset.hash_index):
345 * composite.c (get_composition_id, gstring_lookup_cache)
346 (composition_gstring_put_cache):
347 * composite.h (struct composition.hash_index):
348 * dispextern.h (struct image.hash):
349 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
350 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
351 (hashfn_equal, hashfn_user_defined, make_hash_table)
352 (maybe_resize_hash_table, hash_lookup, hash_put)
353 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
354 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
355 (Fsxhash, Fgethash, Fputhash, Fmaphash):
356 * image.c (make_image, search_image_cache, lookup_image)
357 (xpm_put_color_table_h):
358 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 359 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
360 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
361 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
362 * alloc.c (allocate_vectorlike):
363 Check for overflow in vector size calculations.
364 * ccl.c (ccl_driver):
365 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
366 * fns.c, image.c: Remove unnecessary static decls that would otherwise
367 need to be updated by these changes.
40087514
PE
368 * fns.c (make_hash_table, maybe_resize_hash_table):
369 Check for integer overflow with large hash tables.
0de4bb68
PE
370 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
371 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
372 (SXHASH_REDUCE): New macro.
373 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
374 Use it instead of discarding useful hash info with large hash values.
375 (sxhash_float): New function.
376 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
377 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
378 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
379 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
380 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
381 Adjust signatures to match updated version of code.
382 (consing_since_gc): Now EMACS_INT, since a single hash table can
383 use more than INT_MAX bytes.
384
698d32e2
DN
3852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
386
387 Make it possible to build with GCC-4.6+ -O2 -flto.
388
389 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
390
fd6fa53f
SM
3912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
392
393 * minibuf.c (get_minibuffer, read_minibuf_unwind):
394 Call minibuffer-inactive-mode.
395
864db017
JB
3962011-05-31 Juanma Barranquero <lekktu@gmail.com>
397
398 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
399 Update dependencies.
400
2ad0baf4
DN
4012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
402
403 * data.c (init_data): Remove code for UTS, this system is not
404 supported anymore.
405
4fcc2638
DN
4062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
407
408 Don't force ./temacs to start in terminal mode.
409
410 * frame.c (make_initial_frame): Initialize faces in all cases, not
411 only when CANNOT_DUMP is defined.
412 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
413
c56e0fd5
DN
4142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
415
416 * dispnew.c (add_window_display_history): Use const for the string
417 pointer. Remove declaration, not needed.
418
333d54da 4192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 420
55d4c1b2 421 Use 'inline', not 'INLINE'.
333d54da 422 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
423 * alloc.c, fontset.c (INLINE): Remove.
424 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
425 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
426 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
427 * gmalloc.c (register_heapinfo): Use inline unconditionally.
428 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
429
738db178
DN
4302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
431
432 Make it possible to run ./temacs.
433
434 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
435 syms_of_callproc does the same thing. Remove test for
436 "initialized", do it in the caller.
437 * emacs.c (main): Avoid calling set_initial_environment when dumping.
438
620c53a6
SM
4392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
440
441 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
442 (read_minibuf): Use get_minibuffer.
443 (syms_of_minibuf): Use DEFSYM.
444 (Qmetadata): New var.
445 * data.c (Qbuffer): Don't make it static.
446 (syms_of_data): Use DEFSYM.
447
e003a292
PE
4482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
449
450 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
451 (CCL_CODE_MIN): New macro.
452
ed008a6d
PE
4532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
454
3687c2ef
PE
455 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
456
ed008a6d
PE
457 * eval.c (Qdebug): Now static.
458 * lisp.h (Qdebug): Remove decl. This reverts a part of the
459 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
460 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
461
d66c4c7c
CY
4622011-05-29 Chong Yidong <cyd@stupidchicken.com>
463
464 * image.c: Various fixes to ImageMagick code comments.
465 (Fimagemagick_types): Doc fix.
466
5fbc2025
PE
4672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
468
0196f88a
PE
469 Minor fixes prompted by GCC 4.6.0 warnings.
470
471 * xselect.c (converted_selections, conversion_fail_tag): Now static.
472
5fbc2025
PE
473 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
474 (x_clipboard_manager_save_all): Move extern decl to ...
475 * xterm.h: ... here, so that it can be checked for consistency.
476
1dd3c2d9
CY
4772011-05-29 Chong Yidong <cyd@stupidchicken.com>
478
479 * xselect.c (x_clipboard_manager_save_frame)
480 (x_clipboard_manager_save_all): New functions.
481 (Fx_clipboard_manager_save): Lisp function deleted.
482
483 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
484 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
485
486 * xterm.h: Update prototype.
487
5ba6571d
WX
4882011-05-28 William Xu <william.xwl@gmail.com>
489
490 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
491 exiting (Bug#8239).
492
3eaff834
JM
4932011-05-28 Jim Meyering <meyering@redhat.com>
494
e1900994 495 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
496 * fns.c (to_uchar): Define.
497 (crypto_hash_function): Use it to convert some newly-signed
498 variables to unsigned, to avoid sign-extension bugs. For example,
499 without this change, (md5 "truc") would evaluate to
500 45723a2aff78ff4fff7fff1114760e62 rather than the expected
501 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 502 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 503
0f6990a7
PE
5042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
505
506 Integer overflow fixes.
c8a9ca5a 507
08686060
PE
508 * dbusbind.c: Serial number integer overflow fixes.
509 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
510 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
511 to hold a serial number that is too large for a fixnum.
512 (Fdbus_method_return_internal, Fdbus_method_error_internal):
513 Check for serial numbers out of range. Decode any serial number
59568bf0 514 that was so large that it became a float. (Bug#8722)
08686060 515
2d1fc3c7
PE
516 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
517 (Fdbus_call_method, Fdbus_call_method_asynchronously):
518 Use XFASTINT rather than XUINT when numbers are nonnegative.
519 (xd_append_arg, Fdbus_method_return_internal):
520 (Fdbus_method_error_internal): Likewise. Also, for unsigned
521 arguments, check that Lisp number is nonnegative, rather than
59568bf0 522 silently wrapping negative numbers around. (Bug#8722)
30217ff0 523 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 524 (Bug#8722)
2d1fc3c7 525
c8a9ca5a
PE
526 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
527
519e1d69
PE
528 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
529
30569699
PE
530 ccl: add integer overflow checks
531 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
532 (IN_INT_RANGE): New macros.
533 (ccl_driver): Use them to check for integer overflow when
534 decoding a CCL program. Many of the new checks are whether XINT (x)
535 fits in int; it doesn't always, on 64-bit hosts. The new version
536 doesn't catch all possible integer overflows, but it's an
847044ea 537 improvement. (Bug#8719)
30569699 538
c11285dc
PE
539 * alloc.c (make_event_array): Use XINT, not XUINT.
540 There's no need for unsigned here.
541
fdccd48e
PE
542 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
543 This follows up to the 2011-05-06 change that substituted uintptr_t
544 for EMACS_INT. This case wasn't caught back then.
545
37910ab2
PE
546 Rework Fformat to avoid integer overflow issues.
547 * editfns.c: Include <float.h> unconditionally, as it's everywhere
548 now (part of C89). Include <verify.h>.
549 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
550 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
551 (Fformat): Avoid the prepass trying to compute sizes; it was only
552 approximate and thus did not catch overflow reliably. Instead, walk
553 through the format just once, formatting and computing sizes as we go,
554 checking for integer overflow at every step, and allocating a larger
555 buffer as needed. Keep track separately whether the format is
556 multibyte. Keep only the most-recently calculated precision, rather
557 than them all. Record whether each argument has been converted to
558 string. Use EMACS_INT, not int, for byte and char and arg counts.
559 Support field widths and precisions larger than INT_MAX. Avoid
560 sprintf's undefined behavior with conversion specifications such as %#d
561 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
562 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
563 formatting out-of-range floating point numbers with int
564 formats. (Bug#8668)
565
2e6578fb
PE
566 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
567
0ae6bdee
PE
568 * data.c: Avoid integer truncation in expressions involving floats.
569 * data.c: Include <intprops.h>.
570 (arith_driver): When there's an integer overflow in an expression
571 involving floating point, convert the integers to floating point
572 so that the resulting value does not suffer from catastrophic
573 integer truncation. For example, on a 64-bit host (* 4
574 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
575 Do not rely on undefined behavior after integer overflow.
576
de883a70
PE
577 merge count_size_as_multibyte, parse_str_to_multibyte
578 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 579 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
580 Check for integer overflow.
581 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
582 since it's now a duplicate of the other. This is more of
583 a character than a buffer op, so better that it's in character.c.
584 * fns.c, print.c: Adjust to above changes.
585
2ff916cb
PE
5862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
587
588 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
589
f1b54466
PE
5902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
591
fb1ac845
PE
592 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
593 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
594 (x_clipboard_manager_save): Now static.
595 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
596
f1b54466
PE
597 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
598 (crypto_hash_function): Now static.
599 Fix pointer signedness problems. Avoid unnecessary initializations.
600
a9f737ee
CY
6012011-05-27 Chong Yidong <cyd@stupidchicken.com>
602
603 * termhooks.h (Vselection_alist): Make it terminal-local.
604
605 * terminal.c (create_terminal): Initialize it.
606
607 * xselect.c: Support for clipboard managers.
608 (Vselection_alist): Move to termhooks.h as terminal-local var.
609 (LOCAL_SELECTION): New macro.
610 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
611 (symbol_to_x_atom): Remove gratuitous arg.
612 (x_handle_selection_request, lisp_data_to_selection_data)
613 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
614 (x_own_selection, x_get_local_selection, x_convert_selection):
615 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
616 (some_frame_on_display): Delete unused function.
617 (Fx_own_selection_internal, Fx_get_selection_internal)
618 (Fx_disown_selection_internal, Fx_selection_owner_p)
619 (Fx_selection_exists_p): New optional frame arg.
620 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
621 (x_handle_selection_clear): Don't treat other terminals with the
622 same keyboard specially. Use the terminal-local Vselection_alist.
623 (x_clear_frame_selections): Use Frun_hook_with_args.
624
625 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
626
627 * xterm.h: Add support for those atoms.
628
e067f0c1
CY
6292011-05-26 Chong Yidong <cyd@stupidchicken.com>
630
631 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
632 (converted_selections, conversion_fail_tag): New global variables.
633 (x_selection_request_lisp_error): Free the above.
634 (x_get_local_selection): Remove unnecessary code.
635 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
636 of converted selections stored in converted_selections.
637 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
638 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
639 (x_convert_selection): New function.
640 (x_handle_selection_event): Simplify.
641 (x_get_foreign_selection): Don't ignore incoming requests while
642 waiting for an answer; this will fail when we implement
643 SAVE_TARGETS, and seems unnecessary anyway.
644 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
645 (Vx_sent_selection_functions): Doc fix.
646
0f4aebc0
LL
6472011-05-26 Leo Liu <sdl.web@gmail.com>
648
649 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
650
e61124cd
YM
6512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
652
653 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
654
655 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
656 for fringe update if it has periodic bitmap.
657 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
658 and fringe_bitmap_periodic_p.
659
660 * fringe.c (get_fringe_bitmap_data): New function.
661 (draw_fringe_bitmap_1, update_window_fringes): Use it.
662 (update_window_fringes): Record periodicity of fringe bitmap in glyph
663 row. Mark glyph row for fringe update if periodicity changed.
664
665 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
666 for fringe update unless it has periodic bitmap.
667
f16d9837
KH
6682011-05-25 Kenichi Handa <handa@m17n.org>
669
670 * xdisp.c (get_next_display_element): Set correct it->face_id for
671 a static composition.
672
e1b90ef6
LL
6732011-05-24 Leo Liu <sdl.web@gmail.com>
674
675 * deps.mk (fns.o):
676 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
677
678 * fns.c (crypto_hash_function, Fsha1): New function.
679 (Fmd5): Use crypto_hash_function.
680 (syms_of_fns): Add Ssha1.
681
7400048f
PE
6822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
683
684 * gnutls.c: Remove unused macros.
685 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
686 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
687 Remove macros that are defined and never used.
688 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
689
abb71cf4
CY
6902011-05-22 Chong Yidong <cyd@stupidchicken.com>
691
692 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
693 (Fx_get_selection_internal): Minor cleanup.
694 (Fx_own_selection_internal): Rename arguments for consistency with
695 select.el.
696
6307db39
PE
6972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
698
699 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
700
f3d4e0a4
CY
7012011-05-22 Chong Yidong <cyd@stupidchicken.com>
702
703 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
704
4d8ade89
YM
7052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
706
707 * dispnew.c (scrolling_window): Don't exclude the case that the
708 last enabled row in the desired matrix touches the bottom boundary.
709
32078c8d
GM
7102011-05-21 Glenn Morris <rgm@gnu.org>
711
712 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
713 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
714 and add some more files.
32078c8d 715
7285dc67
EZ
7162011-05-20 Eli Zaretskii <eliz@gnu.org>
717
718 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
719 report_file_error introduced by the change from 2011-05-07.
720
89d1bd22
PE
7212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
722
723 * systime.h (Time): Define only if emacs is defined.
724 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
725 where the include path doesn't have X11/X.h by default. See
726 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
727
e23640bb 7282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
729
730 * composite.c (find_automatic_composition): Fix previous change.
731
b9704ad9
GM
7322011-05-20 Glenn Morris <rgm@gnu.org>
733
734 * lisp.mk: New file, split from Makefile.in.
735 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
736 (shortlisp): Remove.
737 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
738
4a720484
GM
7392011-05-19 Glenn Morris <rgm@gnu.org>
740
741 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
742 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
743 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
744 (lisp): Set the order to that of loadup.el.
745 (shortlisp): Make it a copy of $lisp.
746 (SOME_MACHINE_LISP): Remove.
747 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
748 Use just $shortlisp, not $SOME_MACHINE_LISP too.
749
a28d4396
KH
7502011-05-18 Kenichi Handa <handa@m17n.org>
751
752 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
753 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
754 (find_automatic_composition): Mostly rewrite for efficiency.
755
a2b1fa8e
JB
7562011-05-18 Juanma Barranquero <lekktu@gmail.com>
757
758 * makefile.w32-in: Update dependencies.
759
8e1f5610
CS
7602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
761
762 * menu.c: Include limits.h (fixes the MS-Windows build broken by
763 revision 104625).
764
7025ee00 7652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 766
cdfa6eab
PE
767 Fix some integer overflow issues, such as string length overflow.
768
06d6db33
PE
769 * insdel.c (count_size_as_multibyte): Check for string overflow.
770
2b4560a8
PE
771 * character.c (lisp_string_width): Check for string overflow.
772 Use EMACS_INT, not int, for string indexes and lengths; in
773 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
774 the resulting string length overflows an EMACS_INT; instead,
775 report a string overflow if no precision given. When checking for
776 precision exhaustion, use a check that cannot possibly have
777 integer overflow. (Bug#8675)
778 * character.h (lisp_string_width): Adjust to new signature.
779
cb93f9be
PE
780 * alloc.c (string_overflow): New function.
781 (Fmake_string): Use it. This doesn't change behavior, but saves
782 a few bytes and will simplify future changes.
783 * character.c (string_escape_byte8): Likewise.
784 * lisp.h (string_overflow): New decl.
785
1a1f3366
PE
786 Fixups, following up to the user-interface timestamp change.
787 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
788 for UI timestamps, instead of unsigned long.
9fbd6841
PE
789 * msdos.c (mouse_get_pos): Likewise.
790 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
791 * w32gui.h (Time): Define by including "systime.h" rather than by
792 declaring it ourselves. (Bug#8664)
793
d4e3e4d3
PE
794 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
795 * image.c (clear_image_cache): Likewise.
796
f6a24d19
PE
797 * term.c (term_mouse_position): Don't assume time_t wraparound.
798
08dc5ae6
PE
799 Be more systematic about user-interface timestamps.
800 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
801 and sometimes 'EMACS_UINT', to represent these timestamps.
802 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
803 This makes the code easier to follow, and makes it easier to catch
804 integer overflow bugs such as Bug#8664.
805 * frame.c (Fmouse_position, Fmouse_pixel_position):
806 Use Time, not unsigned long, for user-interface timestamps.
807 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
808 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
809 * keyboard.h (last_event_timestamp): Likewise.
810 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
811 * menu.h (xmenu_show): Likewise.
812 * term.c (term_mouse_position): Likewise.
813 * termhooks.h (struct input_event.timestamp): Likewise.
814 (struct terminal.mouse_position_hook): Likewise.
815 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
816 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
817 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
818 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
819 what it was before.
820 * menu.h, termhooks.h: Include "systime.h", for Time.
821
8e55734a
PE
822 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
823 Don't assume that the difference between two unsigned long values
824 can fit into an integer. At this point, we know button_down_time
825 <= event->timestamp, so the difference must be nonnegative, so
826 there's no need to cast the result if double-click-time is
827 nonnegative, as it should be; check that it's nonnegative, just in
828 case. This bug is triggered when events are more than 2**31 ms
86db42d2 829 apart (about 25 days). (Bug#8664)
8e55734a 830
841f1b75 831 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 832 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 833
3e26f69c
PE
834 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
835 that always fit in int. Use a sentinel instead of a counter, to
836 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
837 * frame.h (struct frame): Use int for menu_bar_items_used
838 instead of EMACS_INT, since it always fits in int.
3e26f69c 839
5cc152c0
PE
840 * menu.c (grow_menu_items): Check for int overflow.
841
d89eb65e
PE
842 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
843
5235bd3e
PE
844 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
845 Before, the code was not consistent. These values cannot exceed
846 2**31 - 1 so there's no need to make them unsigned.
847 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
848 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
849 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
850 as modifiers.
851 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
852
bc827e23
PE
853 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
854 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
855 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
856 presumably because the widths might not match.
857
78eb494e
PE
858 * window.c (size_window): Avoid needless test at loop start.
859
04f2d78b
CB
8602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
861
862 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
863
d2fc7e3d 8642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
865
866 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
867
d2fc7e3d 8682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
869
870 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
871 `width' to `bar_area_x' and `bar_area_width', respectively.
872 (x_scroll_run): Take account of fringe background extension.
873
04f2d78b
CB
874 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
875 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
876 `bar_area_width', respectively.
877 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
878 background extension.
879
79b70037
GM
8802011-05-10 Jim Meyering <meyering@redhat.com>
881
882 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
883
2f142cc5
JB
8842011-05-10 Juanma Barranquero <lekktu@gmail.com>
885
886 * image.c (Finit_image_library): Return t for built-in image types,
887 like pbm and xbm. (Bug#8640)
888
57679c86
AS
8892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
890
891 * w32menu.c (set_frame_menubar): Fix submenu allocation.
892
888c9e86
EZ
8932011-05-07 Eli Zaretskii <eliz@gnu.org>
894
b0512a1d
EZ
895 * w32console.c (Fset_screen_color): Doc fix.
896 (Fget_screen_color): New function.
897 (syms_of_ntterm): Defsubr it.
898
7285dc67
EZ
899 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
900 unlink the temporary file if Fcall_process didn't create it in the
901 first place.
902 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
903 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
904 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
905 cue to call_process_cleanup not to close that handle.
906
4d3fcc8e
BK
9072011-05-07 Ben Key <bkey76@gmail.com>
908
909 * makefile.w32-in: The bootstrap-temacs rule now makes use of
910 one of two shell specific rules, either bootstrap-temacs-CMD or
911 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
912 to the previous implementation of the bootstrap-temacs rule.
913 The bootstrap-temacs-CMD rule is similar to the previous
914 implementation of the bootstrap-temacs rule except that it
915 makes use of the ESC_CFLAGS variable instead of the CFLAGS
916 variable.
917
918 These changes, along with some changes to nt/configure.bat,
919 nt/gmake.defs, and nt/nmake.defs, are required to extend my
920 earlier fix to add support for --cflags and --ldflags options
921 that include quotes so that it works whether make uses cmd or
922 sh as the shell.
923
b4289b64
MA
9242011-05-06 Michael Albinus <michael.albinus@gmx.de>
925
926 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
927 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
928 is a constant.
929 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
930 a string. Handle both cases.
931 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
932 (Fdbus_register_method): Use Qinvalid_function.
933
af4c0e28
JB
9342011-05-06 Juanma Barranquero <lekktu@gmail.com>
935
936 * makefile.w32-in: Update dependencies.
937 (LISP_H): Add inttypes.h and stdin.h.
938 (PROCESS_H): Add unistd.h.
939
c51453d9
EZ
9402011-05-06 Eli Zaretskii <eliz@gnu.org>
941
942 * lread.c: Include limits.h (fixes the MS-Windows build broken by
943 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
944
8ff0ac3c 9452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 946
4c4b566b
PE
947 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
948
aab2b9b5
PE
949 * term.c (vfatal): Remove stray call to va_end.
950 It's not needed and the C Standard doesn't allow it here anyway.
951
c378da0b
PE
952 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
953 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
954
288b08c7
PE
955 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
956 bytes.
957
e3601888
PE
958 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
959
db6c0e74
PE
960 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
961
dd5963ea
PE
962 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
963
88c9450f
PE
964 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
965
2f9442b8
PE
966 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
967
c032b5f8
PE
968 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
969 * charset.c (Fdefine_charset_internal): Don't initialize
970 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 971 32-bit int (Bug#8600).
a108c10b
PE
972
973 * lread.c (read_integer): Be more consistent with string-to-number.
974 Use string_to_number to do the actual conversion; this avoids
975 rounding errors and fixes some other screwups. Without this fix,
976 for example, #x1fffffffffffffff was misread as -2305843009213693952.
977 (digit_to_number): Move earlier, for benefit of read_integer.
978 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 979 not a digit in any supported base. (Bug#8602)
a108c10b 980
ad5f9eea
PE
981 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
982
aec1708a
PE
983 * dispnew.c (scrolling_window): Return 1 if we scrolled,
984 to match comment at start of function. This also removes a
985 GCC warning about overflow in a 32+64-bit port.
986
47be4ab5
PE
987 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
988
371cac43
PE
989 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
990 Reported by Stefan Monnier in
991 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
992 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
993 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 994
d01a7826
PE
995 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
996 (EMACS_UINTPTR): Likewise, with uintptr_t.
997
7fd47d5c
PE
998 * lisp.h: Prefer 64-bit EMACS_INT if available.
999 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1000 on 32-bit hosts that have 64-bit int, so that they can access
1001 large files.
122b0c86
PE
1002 However, temporarily disable this change unless the temporary
1003 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1004
8727937b
PE
1005 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1006
8ac068ac
PE
1007 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1008 This removes an assumption that EMACS_INT and long are the same
1009 width as pointers. The assumption is true for Emacs porting targets
1010 now, but we want to make other targets possible.
1011 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1012 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1013 In the rest of the code, change types of integers that hold casted
1014 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1015 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1016 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1017 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1018 No need to cast type when ORing.
1019 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1020 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1021 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1022 assume EMACS_INT is the same width as char *.
1023 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1024 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1025 Remove no-longer-needed casts.
1026 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1027 (xg_tool_bar_help_callback, xg_make_tool_item):
1028 Use EMACS_INTPTR to hold an integer
1029 that will be cast to void *; this can avoid a GCC warning
1030 if EMACS_INT is not the same width as void *.
1031 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1032 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1033 (current_message_1, set_message_1):
1034 Use a local to convert to proper width without a cast.
1035 * xmenu.c (dialog_selection_callback): Likewise.
1036
ede49d71
PE
1037 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1038 Also, don't assume VALBITS / RAND_BITS is less than 5,
1039 and don't rely on undefined behavior when shifting a 1 left into
1040 the sign bit.
1041 * lisp.h (get_random): Change signature to match.
1042
2f30ecd0
PE
1043 * lread.c (hash_string): Use size_t, not int, for hash computation.
1044 Normally we prefer signed values; but hashing is special, because
1045 it's better to use unsigned division on hash table sizes so that
1046 the remainder is nonnegative. Also, size_t is the natural width
1047 for hashing into memory. The previous code used 'int', which doesn't
1048 retain enough info to hash well into very large tables.
1049 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1050
2a866e7b
PE
1051 * dbusbind.c: Don't possibly lose pointer info when converting.
1052 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1053 Use XPNTR rather than XHASH, so that the high-order bits of
1054 the pointer aren't lost when converting through void *.
1055
51639eac
PE
1056 * eval.c (Fautoload): Don't double-shift a pointer.
1057
92394119
PE
1058 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1059
dbdb9a7c
JB
10602011-05-06 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * gnutls.c (DEF_GNUTLS_FN):
1063 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1064
db7a0b4f
AS
10652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1066
1067 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1068 marker. (Bug#8610)
1069
f7ff1b0f 10702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1071
1072 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1073 New version that can reserve upto 2GB of heap space.
1074
f7ff1b0f 10752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1076
1077 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1078
639c109b
TZ
10792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1080
1081 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1082 `gnutls_certificate_set_x509_key_file'.
1083
d2127135
JB
10842011-05-05 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1087 Update dependencies.
1088
e968f4f3
JB
10892011-05-04 Juanma Barranquero <lekktu@gmail.com>
1090
1091 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1092 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1093 Remove unused parameter `fildes'.
1094 * process.c (read_process_output, send_process): Don't pass it.
1095
84d358f0
JB
10962011-05-04 Juanma Barranquero <lekktu@gmail.com>
1097
1098 Fix previous change: the library cache is defined in w32.c.
1099 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1100 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1101
0898ca10
JB
11022011-05-04 Juanma Barranquero <lekktu@gmail.com>
1103
1104 Implement dynamic loading of GnuTLS on Windows.
1105
1106 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1107 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1108 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1109 Declare.
1110
1111 * gnutls.c (Qgnutls_dll): Define.
1112 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1113 (gnutls_*): Declare function pointers.
1114 (init_gnutls_functions): New function to initialize function pointers.
1115 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1116 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1117 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1118 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1119 (emacs_gnutls_write, emacs_gnutls_read)
1120 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1121 (Fgnutls_available_p): New function.
1122 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1123 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1124 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1125
1126 * image.c: Include w32.h.
1127 (Vimage_type_cache): Delete.
1128 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1129 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1130 (w32_delayed_load): Move to w32.c.
1131
1132 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1133
1134 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1135 (w32_delayed_load): Move from image.c. When loading a library, record
1136 its filename in the :loaded-from property of the library id.
1137 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1138 Initialize and staticpro them.
1139 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1140
1141 * process.c: Include lisp.h before w32.h, not after.
1142 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1143 instead of gnutls_record_check_pending.
1144
1145 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1146
ff4de4aa
TZ
11472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1148
1149 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1150 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1151 as passed in.
1152
abe95abb
JD
11532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1154
1155 * xterm.c (x_set_frame_alpha): Do not set property on anything
1156 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1157
e16e55d4
JB
11582011-05-02 Juanma Barranquero <lekktu@gmail.com>
1159
1160 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1161
bafcf6a5
JB
11622011-05-02 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1165 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1166 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1167 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1168 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1169 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1170 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1171 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1172 (Qgnutls_bootprop_callbacks_verify): Make static.
1173
e7a6747f
AS
11742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1175
19ed11ba
AS
1176 * callproc.c: Indentation fixup.
1177
e7a6747f 1178 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1179 (wait_for_termination, interruptible_wait_for_termination):
1180 Move after wait_for_termination_1.
e7a6747f 1181
1ef14cb4
LMI
11822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1183
1184 * sysdep.c (interruptible_wait_for_termination): New function
1185 which is like wait_for_termination, but allows keyboard
1186 interruptions.
1187
1188 * callproc.c (Fcall_process): Add (:file "file") as an option for
1189 the STDOUT buffer.
1190 (Fcall_process_region): Ditto.
1191
330d880c
EZ
11922011-04-30 Eli Zaretskii <eliz@gnu.org>
1193
8db90b73
EZ
1194 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1195 rather than `XVECTOR (FOO)->size'.
1196
330d880c
EZ
1197 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1198 inttypes.h, as a gnulib replacement is used if it not available in
1199 system headers.
1200
15cbd324
EZ
12012011-04-21 Eli Zaretskii <eliz@gnu.org>
1202
1203 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1204 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1205 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1206
1207 * coding.c (coding_alloc_by_realloc): Error out if destination
1208 will grow beyond MOST_POSITIVE_FIXNUM.
1209 (decode_coding_emacs_mule): Abort if there isn't enough place in
1210 charbuf for the composition carryover bytes. Reserve an extra
1211 space for up to 2 characters produced in a loop.
1212 (decode_coding_iso_2022): Abort if there isn't enough place in
1213 charbuf for the composition carryover bytes.
1214
12152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1216
ae940cca
EZ
1217 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1218 aborting when %lld or %lll format is passed.
1219 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1220 %llo or %llx format is passed. (Bug#8545)
1221
03ab8921
EZ
1222 * window.c (window_scroll_line_based): Use a marker instead of
1223 simple variables to record original value of point. (Bug#7952)
1224
afda1437
EZ
1225 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1226 produced by %s or %c overflows available buffer space. (Bug#8545)
1227
f76dee0c
PE
12282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1231 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1232
fdc5744d
JB
12332011-04-28 Juanma Barranquero <lekktu@gmail.com>
1234
1235 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1236
638f053a
JB
12372011-04-28 Juanma Barranquero <lekktu@gmail.com>
1238
1239 * keyboard.c (Qdelayed_warnings_hook): Define.
1240 (command_loop_1): Run `delayed-warnings-hook'
1241 if Vdelayed_warnings_list is non-nil.
1242 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1243 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1244
d178f871
EZ
12452011-04-28 Eli Zaretskii <eliz@gnu.org>
1246
1247 * doprnt.c (doprnt): Don't return value smaller than the buffer
1248 size if the message was truncated. (Bug#8545).
1249
b124fd93
JB
12502011-04-28 Juanma Barranquero <lekktu@gmail.com>
1251
1252 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1253 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1254
e810457d
PE
12552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1256
1257 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1258
ea51cceb
JB
12592011-04-27 Juanma Barranquero <lekktu@gmail.com>
1260
1261 * makefile.w32-in: Update dependencies.
1262
94dcfacf
EZ
12632011-04-27 Eli Zaretskii <eliz@gnu.org>
1264
1265 Improve `doprnt' and its usage. (Bug#8545)
1266 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1267 `format_end'. Remove support for %l as a conversion specifier.
1268 Don't use xrealloc. Improve diagnostics when the %l size modifier
1269 is used. Update the commentary.
1270
1271 * eval.c (verror): Simplify calculation of size_t.
1272
1273 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1274 messages.
1275
f61f41d7
PE
12762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1277
1278 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1279 change.
1280
96fb4434
PE
12812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1282
1283 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1284 This makes this file independent of the recent pseudovector change.
1285
671875da 12862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1287
69e9b5a3
PE
1288 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1289
b5f869a7 1290 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1291 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1292 Remove unused local.
c8926152 1293 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1294
841a1577 1295 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1296 GCC 4.6.0 optimizes based on type-based alias analysis.
1297 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1298 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1299 != &v->size, and therefore "v->size = 1; b->size = 2; return
1300 v->size;" must therefore return 1. This assumption is incorrect
1301 for Emacs, since it type-puns struct Lisp_Vector * with many other
1302 types. To fix this problem, this patch adds a new type struct
f904488f 1303 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1304 and pseudovectors, and helps optimizing compilers not get fooled
1305 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1306 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1307 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1308 the size member.
eab3844f
PE
1309 (XSETPVECTYPE): Rewrite in terms of new macro.
1310 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1311 This is a bit clearer, and further avoids the possibility of
1312 undesirable aliasing.
1313 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1314 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1315 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1316 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1317 (ASIZE): Now uses header.size rather than size.
1318 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1319 to avoid the hassle of writing XVECTOR (foo)->header.size.
1320 (struct vectorlike_header): New type.
eab3844f
PE
1321 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1322 object, to help avoid aliasing.
1323 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1324 (SUBRP): Likewise, since Lisp_Subr is a special case.
1325 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1326 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1327 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1328 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1329 changed to be "header.size" and "header.next".
1330 * buffer.h (struct buffer): Likewise.
1331 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1332 * frame.h (struct frame): Likewise.
1333 * process.h (struct Lisp_Process): Likewise.
1334 * termhooks.h (struct terminal): Likewise.
1335 * window.c (struct save_window_data, struct saved_window): Likewise.
1336 * window.h (struct window): Likewise.
1337 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1338 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1339 * buffer.c (init_buffer_once): Likewise.
1340 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1341 special case.
1342 * process.c (Fformat_network_address): Use local var for size,
1343 for brevity.
1344
0df1eac5
PE
1345 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1346
847ab9d1 1347 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1348 * data.c (atof): Remove decl; no longer used or needed.
1349 (digit_to_number): Move to lread.c.
1350 (Fstring_to_number): Use new string_to_number function, to be
1351 consistent with how the Lisp reader treats infinities and NaNs.
1352 Do not assume that floating-point numbers represent EMACS_INT
1353 without losing information; this is not true on most 64-bit hosts.
1354 Avoid double-rounding errors, by insisting on integers when
1355 parsing non-base-10 numbers, as the documentation specifies.
1356 * lisp.h (string_to_number): New decl, replacing ...
1357 (isfloat_string): Remove.
bc0a5c13 1358 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1359 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1360 appears to have been a coding error. Similarly, do not accept
1361 strings like +-1e0 as floating point numbers. Do not report
1362 overflow for integer overflows unless the base is not 10 which
1363 means we have no simple and reliable way to continue.
1364 Break out the floating-point parsing into a new
1365 function string_to_number, so that Fstring_to_number parses
1366 floating point numbers consistently with the Lisp reader.
04f2d78b 1367 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1368 (E_CHAR, EXP_INT): Remove, replacing with ...
1369 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1370 (string_to_number): New function, replacing isfloat_string.
1371 This function checks for valid syntax and produces the resulting
1372 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1373 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1374 so that overflow for non-base-10 numbers is reported only when
1375 there's no portable and simple way to convert to floating point.
452f4150 1376
67769ffc
PE
1377 * textprop.c (set_text_properties_1): Rewrite for clarity,
1378 and to avoid GCC warning about integer overflow.
1379
c20db43f
PE
1380 * intervals.h (struct interval): Use EMACS_INT for members
1381 where EMACS_UINT might cause problems. See
1382 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1383 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1384 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1385 All uses changed.
37aa2f85
PE
1386 (offset_intervals): Tell GCC not to worry about length overflow
1387 when negating a negative length.
c20db43f 1388
2538aa2f
PE
1389 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1390 (overrun_check_free): Likewise.
1391
f2d3008d
PE
1392 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1393 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1394 word size.
1395
ec8df744
PE
1396 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1397 (gnutls_make_error): Rename local to avoid shadowing.
1398 (gnutls_emacs_global_deinit): ifdef out; not used.
1399 (Fgnutls_boot): Use const for pointer to readonly storage.
1400 Comment out unused local. Fix pointer signedness problems.
1401
640ee02d
PE
1402 * lread.c (openp): Don't stuff size_t into an 'int'.
1403 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1404 about possible signed overflow.
1405
6048fb2a
PE
1406 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1407 (GDK_KEY_g): Don't define if already defined.
1408 (xg_prepare_tooltip): Avoid pointer signedness problem.
1409 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1410
fa3c87e1
PE
1411 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1412 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1413
2172544b
PE
1414 * xfns.c (Fx_window_property): Simplify a bit,
1415 to make a bit faster and to avoid GCC 4.6.0 warning.
1416 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1417
9b821a21
PE
1418 * fns.c (internal_equal): Don't assume size_t fits in int.
1419
3c616cfa
PE
1420 * alloc.c (compact_small_strings): Tighten assertion a little.
1421
c2982e87
PE
1422 Replace pEd with more-general pI, and fix some printf arg casts.
1423 * lisp.h (pI): New macro, generalizing old pEd macro to other
1424 conversion specifiers. For example, use "...%"pI"d..." rather
1425 than "...%"pEd"...".
1426 (pEd): Remove. All uses replaced with similar uses of pI.
1427 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1428 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1429 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1430 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1431 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1432 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1433 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1434 64-bit hosts.
1435 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1436 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1437 * print.c (safe_debug_print, print_object): Likewise.
1438 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1439 to int.
6f04d126
PE
1440 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1441 avoiding the 0 flag, which is not portable.
c2982e87
PE
1442 * process.c (Fmake_network_process): Use pI to avoid cast.
1443 * region-cache.c (pp_cache): Likewise.
1444 * xdisp.c (decode_mode_spec): Likewise.
1445 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1446 behavior on 64-bit hosts with printf arg.
6f04d126 1447 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1448 (x_stop_queuing_selection_requests): Likewise.
1449 (x_get_window_property): Don't truncate byte count to an 'int'
1450 when tracing.
0b432f21 1451
5e073ec7
PE
1452 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1453 here, since it parses constructs like leading '-' and spaces,
1454 which are not wanted; and it overflows with large numbers.
1455 Instead, simply match F[0-9]+, which is what is wanted anyway.
1456
36372bf9
PE
1457 * alloc.c: Remove unportable assumptions about struct layout.
1458 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1459 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1460 (allocate_vectorlike, make_pure_vector): Use the new macros,
1461 plus offsetof, to remove unportable assumptions about struct layout.
1462 These assumptions hold on all porting targets that I know of, but
1463 they are not guaranteed, they're easy to remove, and removing them
1464 makes further changes easier.
1465
0b432f21
PE
1466 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1467 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1468 (string_overrun_cookie): Now const. Use initializers that
1469 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1470 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1471 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1472 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1473 multiple of sizeof (EMACS_INT); it need not be, if
1474 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1475 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1476
895009e1
JB
14772011-04-26 Juanma Barranquero <lekktu@gmail.com>
1478
1479 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1480
6a7a1b0b
TZ
14812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1482
1483 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1484 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1485 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1486
841a1577 14872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1488
1489 * lisp.h (Qdebug): List symbol.
895009e1 1490 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1491 * keyboard.c (debug-on-event): New variable.
1492 (handle_user_signal): Break into debugger when debug-on-event
1493 matches the current signal symbol.
1494
f2d3ba6f
DN
14952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1496
1497 * alloc.c (check_sblock, check_string_bytes)
1498 (check_string_free_list): Convert to standard C.
1499
42ce4c63
TZ
15002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1501
1502 * w32.c (emacs_gnutls_push): Fix typo.
1503
825cd63c
EZ
15042011-04-25 Eli Zaretskii <eliz@gnu.org>
1505
fb11d64d
EZ
1506 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1507 "cast to pointer from integer of different size".
1508
825cd63c
EZ
1509 Improve doprnt and its use in verror. (Bug#8545)
1510 * doprnt.c (doprnt): Document the set of format control sequences
1511 supported by the function. Use SAFE_ALLOCA instead of always
1512 using `alloca'.
1513
1514 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1515 is one byte too soon. Don't use xrealloc; instead xfree and
1516 xmalloc anew.
1517
e061a11b
TZ
15182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1519
1520 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1521 callbacks stage.
1522
1523 * gnutls.c: Renamed global_initialized to
1524 gnutls_global_initialized. Added internals for the
1525 :verify-hostname-error, :verify-error, and :verify-flags
1526 parameters of `gnutls-boot' and documented those parameters in the
1527 docstring. Start callback support.
1528 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1529 unless a fatal error occured. Call gnutls_alert_send_appropriate
1530 on error. Return error code.
1531 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1532 (emacs_gnutls_read): Likewise.
1533 (Fgnutls_boot): Return handshake error code.
1534 (emacs_gnutls_handle_error): New function.
1535 (wsaerror_to_errno): Likewise.
1536
1537 * w32.h (emacs_gnutls_pull): Add prototype.
1538 (emacs_gnutls_push): Likewise.
1539
1540 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1541 (emacs_gnutls_push): Likewise.
1542
15432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1544
1545 * process.c (wait_reading_process_output): Check if GnuTLS
1546 buffered some data internally if no FDs are set for TLS
1547 connections.
1548
1549 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1550 (LIBS): Link to USER_LIBS.
1551 ($(BLD)/gnutls.$(0)): New target.
1552
fa6996bc
EZ
15532011-04-24 Eli Zaretskii <eliz@gnu.org>
1554
eb35682e
EZ
1555 * xdisp.c (handle_single_display_spec): Rename the
1556 display_replaced_before_p argument into display_replaced_p, to
1557 make it consistent with the commentary. Fix typos in the
1558 commentary.
1559
e2ad650c
EZ
1560 * textprop.c (syms_of_textprop): Remove dead code.
1561 (copy_text_properties): Delete obsolete commentary about an
1562 interface that was deleted long ago. Fix typos in the description
1563 of arguments.
1564
1b2de274
EZ
1565 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1566 to changes in oldXMenu/XMenu.h from 2011-04-16.
1567 <menu_help_message, prev_menu_help_message>: Constify.
1568 (IT_menu_make_room): menu->help_text is now `const char **';
1569 adjust.
1570
1571 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1572 to changes in oldXMenu/XMenu.h from 2011-04-16.
1573 (struct XMenu): Declare `help_text' `const char **'.
1574
1575 * xfaces.c <Qunspecified>: Make extern again.
1576
1577 * syntax.c: Include sys/types.h before including regex.h, as
1578 required by Posix.
1579
762b15be
EZ
1580 * doc.c (get_doc_string): Improve the format passed to `error'.
1581
1582 * doprnt.c (doprnt): Improve commentary.
1583
1584 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1585
1586 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1587 them with etags.
1588
f1052e5d
EZ
1589 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1590 changes in globals.h immediately force recompilation.
762b15be
EZ
1591 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1592 $(CURDIR)/s/ms-w32.h.
1593 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1594
fa6996bc
EZ
1595 * character.c (Fchar_direction): Function deleted.
1596 (syms_of_character): Don't defsubr it.
1597 <char-direction-table>: Deleted.
1598
e6c3da20
EZ
15992011-04-23 Eli Zaretskii <eliz@gnu.org>
1600
1601 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1602 * doprnt.c: Include limits.h.
1603 (SIZE_MAX): New macro.
04f2d78b
CB
1604 (doprnt): Return a size_t value. 2nd arg is now size_t.
1605 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1606 Improve overflow protection. Support `l' modifier for integer
1607 conversions. Support %l conversion. Don't assume an EMACS_INT
1608 argument for integer conversions and for %c.
1609
1610 * lisp.h (doprnt): Restore prototype.
1611
1612 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1613 $(SRC)/character.h.
1614
1615 * Makefile.in (base_obj): Add back doprnt.o.
1616
1617 * deps.mk (doprnt.o): Add back prerequisites.
1618 (callint.o): Depend on character.h.
1619
1620 * eval.c (internal_lisp_condition_case): Include the handler
1621 representation in the error message.
1622 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1623 when breaking from the loop.
1624
1625 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1626
1627 * callint.c (Fcall_interactively): When displaying error message
1628 about invalid control letter, pass the character's codepoint, not
1629 a pointer to its multibyte form. Improve display of the character
1630 in octal and display also its hex code.
1631
1632 * character.c (char_string): Use %x to display the (unsigned)
1633 codepoint of an invalid character, to avoid displaying a bogus
1634 negative value.
1635
1636 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1637 `error', not SYMBOL_NAME itself.
1638
1639 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1640 character arguments to `error'.
1641
1642 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1643 to `error' in error message about FINAL_CHAR argument. Make sure
1644 FINAL_CHAR is a character, and use %c when it is passed as
1645 argument to `error'.
1646
4ffd0d6b 16472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1648
1649 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1650
1651 * w32.c: Include <time.h>.
1652 (sys_localtime): New function.
1653
4ffd0d6b 16542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1655
1656 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1657
4ffd0d6b 1658 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1659
4ffd0d6b 16602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1661
4ffd0d6b
GM
1662 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1663 zombies (Bug#8467).
aac0c6e3 1664
04c56954
EZ
16652011-04-19 Eli Zaretskii <eliz@gnu.org>
1666
1667 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1668 gl_state.e_property when gl_state.object is Qt.
1669
1670 * insdel.c (make_gap_larger): Remove limitation of buffer size
1671 to <= INT_MAX.
1672
16a43933
CY
16732011-04-18 Chong Yidong <cyd@stupidchicken.com>
1674
1675 * xdisp.c (lookup_glyphless_char_display)
1676 (produce_glyphless_glyph): Handle cons cell entry in
1677 glyphless-char-display.
1678 (Vglyphless_char_display): Document it.
1679
1680 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1681 glyphless-char-display.
1682
4581706e
CY
16832011-04-17 Chong Yidong <cyd@stupidchicken.com>
1684
1685 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1686
1687 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1688
1689 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1690 definition for no-X builds.
1691
4887c6e2 16922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1693
fd35b6f9
PE
1694 Static checks with GCC 4.6.0 and non-default toolkits.
1695
5c1ccb01
PE
1696 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1697
006c5daa
PE
1698 * process.c (keyboard_bit_set): Define only if SIGIO.
1699 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1700 (send_process): Repair possible setjmp clobbering.
1701
efc736d3
PE
1702 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1703
4e2fe2e6
PE
1704 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1705
f97334a2
PE
1706 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1707
4e75f29d
PE
1708 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1709 Define only if needed.
1710
90efadd1
PE
1711 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1712 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1713 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1714
3c647824
PE
1715 * dispextern.h (struct redisplay_interface): Rename param
1716 to avoid shadowing.
e264f262 1717 * termhooks.h (struct terminal): Likewise.
761383f4 1718 * xterm.c (xembed_send_message): Likewise.
3c647824 1719
b58c5c4a
PE
1720 * insdel.c (make_gap_smaller): Define only if
1721 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1722
cad59032
PE
1723 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1724 it.
1725
c339dc2e
PE
1726 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1727 so that we aren't warned about unused symbols.
1728
91a3e27b
PE
1729 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1730
399c71d3 1731 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1732
8ffc96f5
PE
1733 * xfns.c (x_real_positions): Mark locals as initialized.
1734
eef9bc79
PE
1735 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1736
098db9dd
PE
1737 * xterm.c: Fix problems found by static analysis with other toolkits.
1738 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1739 (x_dispatch_event): Declare static if USE_GTK, and
1740 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1741 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1742 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1743 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1744 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1745
eb18f6cc
PE
1746 * xmenu.c (menu_help_callback): Pointer type fixes.
1747 Use const pointers when pointing at readonly data. Avoid pointer
1748 signedness clashes.
1749 (FALSE): Remove unused macro.
1750 (update_frame_menubar): Remove unused decl.
1751
1fe72bf8
PE
1752 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1753
60d9e1db
PE
1754 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1755 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1756 (single_menu_item): Rename local to avoid shadowing.
1757
39261c26
PE
1758 * keyboard.c (make_lispy_event): Remove unused local var.
1759
018c5e19
PE
1760 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1761 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1762
63d2b86e
PE
1763 * bitmaps: Change bitmaps from unsigned char back to the X11
1764 compatible char. Avoid the old compiler warnings about
1765 out-of-range initializers by using, for example, '\xab' rather
1766 than 0xab.
1767
aefd87e1
PE
1768 * xgselect.c (xgselect_initialize): Check vs interface
1769 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1770
bf501fb9
PE
1771 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1772
e9829fdf
PE
1773 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1774 to read-only memory.
1775
1086c095
PE
1776 * fns.c (vector): Remove; this old hack is no longer needed.
1777
2baccd04 1778 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1779 Remove unused var.
dde42981 1780 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1781
72391843 1782 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1783
436c16df 1784 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1785 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1786 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1787
92bb796d 1788 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1789 (x_term_init): Remove local to avoid shadowing.
92bb796d 1790
764430a3 1791 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1792
1793 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1794 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1795
d1dfb56c
EZ
17962011-04-16 Eli Zaretskii <eliz@gnu.org>
1797
c4354cb4
EZ
1798 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1799
d1dfb56c
EZ
1800 Fix regex.c, syntax.c and friends for buffers > 2GB.
1801 * syntax.h (struct gl_state_s): Declare character position members
1802 EMACS_INT.
1803
1804 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1805
04f2d78b
CB
1806 * textprop.c (verify_interval_modification, interval_of):
1807 Declare arguments EMACS_INT.
d1dfb56c
EZ
1808
1809 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1810 EMACS_INT.
1811
1812 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1813
1814 * indent.c (Fvertical_motion): Local variable it_start is now
1815 EMACS_INT.
1816
1817 * regex.c (re_match, re_match_2, re_match_2_internal)
1818 (bcmp_translate, regcomp, regexec, print_double_string)
1819 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1820 (re_compile_pattern, re_exec): Declare arguments and local
1821 variables `size_t' and `ssize_t' and return values `regoff_t', as
1822 appropriate.
1823 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1824 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1825 <compile_stack_type>: `size' and `avail' are now `size_t'.
1826
1827 * regex.h <regoff_t>: Use ssize_t, not int.
1828 (re_search, re_search_2, re_match, re_match_2): Arguments that
1829 specify buffer/string position and length are now ssize_t and
1830 size_t. Return type is regoff_t.
1831
613052cd
BK
18322011-04-16 Ben Key <bkey76@gmail.com>
1833
1834 * nsfont.m: Fixed bugs in ns_get_family and
1835 ns_descriptor_to_entity that were caused by using free to
1836 deallocate memory blocks that were allocated by xmalloc (via
1837 xstrdup). This caused Emacs to crash when compiled with
1838 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1839 --enable-checking=xmallocoverrun). xfree is now used to
1840 deallocate these memory blocks.
1841
4170f62f 18422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1843
71b41406
PE
1844 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1845
9587a89d
PE
1846 emacs_write: Accept and return EMACS_INT for sizes.
1847 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1848 et seq.
1849 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1850 Accept and return EMACS_INT.
1851 (emacs_gnutls_write): Return the number of bytes written on
1852 partial writes.
1853 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1854 (emacs_read, emacs_write): Remove check for negative size, as the
1855 Emacs source code has been audited now.
9587a89d
PE
1856 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1857 (emacs_read, emacs_write): Use it.
273a5f82
PE
1858 * process.c (send_process): Adjust to the new signatures of
1859 emacs_write and emacs_gnutls_write. Do not attempt to store
1860 a byte offset into an 'int'; it might overflow.
9587a89d 1861 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1862
3e047f51
PE
1863 * sound.c: Don't assume sizes fit in 'int'.
1864 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1865 Return EMACS_INT, not int.
3e047f51 1866 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1867 Accept EMACS_INT, not int.
1868 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1869 record read return values.
1870
cc39a9db
BK
18712011-04-15 Ben Key <bkey76@gmail.com>
1872
c9d0ec6d
JB
1873 * keyboard.c (Qundefined): Don't declare static since it is used
1874 in nsfns.m.
1875 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1876 static since they are used in nsfont.m.
cc39a9db 1877
6c60eb9f
SM
18782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1879
1880 * process.c (Qprocessp): Don't declare static.
1881 * lisp.h (Qprocessp): Declare again.
1882
7990b61a
JB
18832011-04-15 Juanma Barranquero <lekktu@gmail.com>
1884
1885 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1886
5d4cb038
PE
18872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1888
8bd7b830 1889 Improve C-level modularity by making more things 'static'.
cd64ea1d 1890
e3b27b31
PE
1891 Don't publish debugger-only interfaces to other modules.
1892 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1893 (verify_bytepos, count_markers): Move decls to the only modules
1894 that need them.
1895 * region-cache.h (pp_cache): Likewise.
1896 * window.h (check_all_windows): Likewise.
1897 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1898
5d4cb038
PE
1899 * sysdep.c (croak): Now static, if
1900 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1901 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1902
1903 * alloc.c (refill_memory_reserve): Now static if
1904 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1905 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1906
e87b6180
PE
1907 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1908 Define only if USE_LUCID.
1909
ac64929e
PE
1910 * xrdb.c (x_customization_string, x_rm_string): Now static.
1911
6f37259d
PE
1912 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1913 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1914
1683e3ab
PE
1915 * xdisp.c (draw_row_with_mouse_face): Now static.
1916 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1917
de9c2632
PE
1918 * window.h (check_all_windows): Mark externally visible.
1919
2b96acb7
PE
1920 * window.c (window_deletion_count): Now static.
1921
1922 * undo.c: Make symbols static if they're not exported.
1923 (last_undo_buffer, last_boundary_position, pending_boundary):
1924 Now static.
1925
50436f33
PE
1926 * textprop.c (interval_insert_behind_hooks): Now static.
1927 (interval_insert_in_front_hooks): Likewise.
1928
64520e5c
PE
1929 * term.c: Make symbols static if they're not exported.
1930 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1931 (max_frame_lines, tty_set_terminal_modes):
1932 (tty_reset_terminal_modes, tty_turn_off_highlight):
1933 (get_tty_terminal): Now static.
1934 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1935 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1936 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1937 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1938 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1939
1fa53021
PE
1940 * sysdep.c: Make symbols static if they're not exported.
1941 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1942 Now static.
1943 (sigprocmask_set, full_mask): Remove; unused.
1944 (wait_debugging): Mark as visible.
1945 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1946 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1947
d4b43b22
PE
1948 * syntax.c (syntax_temp): Define only if !__GNUC__.
1949
b7c513d0
PE
1950 * sound.c (current_sound_device, current_sound): Now static.
1951
989b29ad
PE
1952 * search.c (searchbufs, searchbuf_head): Now static.
1953
13a55a78
PE
1954 * scroll.c (scroll_cost): Remove; unused.
1955 * dispextern.h (scroll_cost): Remove decl.
1956
de68a1fc
PE
1957 * region-cache.h (pp_cache): Mark as externally visible.
1958
40ccffa6
PE
1959 * process.c: Make symbols static if they're not exported.
1960 (process_tick, update_tick, create_process, chan_process):
1961 (Vprocess_alist, proc_buffered_char, datagram_access):
1962 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1963 (deactivate_process): Mark defn as static, as well as decl.
1964 * lisp.h (create_process): Remove decl.
1965 * process.h (chan_process, Vprocess_alist): Remove decls.
1966
ad64fc97
PE
1967 * print.c: Make symbols static if they're not exported.
1968 (print_depth, new_backquote_output, being_printed, print_buffer):
1969 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1970 (print_interval, print_number_index, initial_stderr_stream):
1971 Now static.
1972 * lisp.h (Fprinc): Remove decl.
1973 (debug_output_compilation_hack): Mark as externally visible.
1974
adddb265
PE
1975 * sysdep.c (croak): Move decl from here to syssignal.h.
1976 * syssignal.h (croak): Put it here, so the API can be checked when
1977 'croak' is called from dissociate_if_controlling_tty.
1978
1717ede2
PE
1979 * minibuf.c: Make symbols static if they're not exported.
1980 (minibuf_save_list, choose_minibuf_frame): Now static.
1981 * lisp.h (choose_minibuf_frame): Remove decl.
1982
fa5fb2bc
PE
1983 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1984
1e3890d1
PE
1985 * lread.c: Make symbols static if they're not exported.
1986 (read_objects, initial_obarray, oblookup_last_bucket_number):
1987 Now static.
1988 (make_symbol): Remove; unused.
1989 * lisp.h (initial_obarray, make_symbol): Remove decls.
1990
8a1414fa
PE
1991 * keyboard.c: Make symbols static if they're not exported.
1992 (single_kboard, recent_keys_index, total_keys, recent_keys):
1993 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1994 (this_single_command_key_start, echoing, last_auto_save):
1995 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1996 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1997 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1998 (Vlispy_mouse_stem, double_click_count):
1999 Now static.
2000 (force_auto_save_soon): Define only if SIGDANGER.
2001 (ignore_mouse_drag_p): Now static if
2002 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2003 (print_help): Remove; unused.
2004 (stop_character, last_timer_event): Mark as externally visible.
2005 * keyboard.h (ignore_mouse_drag_p): Declare only if
2006 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2007 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2008 * lisp.h (echoing): Remove decl.
2009 (force_auto_save_soon): Declare only if SIGDANGER.
2010 * xdisp.c (redisplay_window): Simplify code, to make it more
2011 obvious that ignore_mouse_drag_p is not accessed if !defined
2012 USE_GTK && !defined HAVE_NS.
2013
93ea6e8f
PE
2014 * intervals.c: Make symbols static if they're not exported.
2015 (merge_properties_sticky, merge_interval_right, delete_interval):
2016 Now static.
2017 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2018
77382fcc
PE
2019 * insdel.c: Make symbols static if they're not exported.
2020 However, leave prepare_to_modify_buffer alone. It's never
2021 called from outside this function, but that appears to be a bug.
2022 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2023 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2024 (adjust_after_replace_noundo): Remove; unused.
2025 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2026 (signal_before_change): Remove decls.
77382fcc 2027
9306c32e
PE
2028 * indent.c (val_compute_motion, val_vmotion): Now static.
2029
cd44d2eb
PE
2030 * image.c: Make symbols static if they're not exported.
2031 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2032 if USE_GTK.
2033 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2034 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2035
ad9a7a06
PE
2036 * fringe.c (standard_bitmaps): Now static.
2037 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2038
81626931
PE
2039 * frame.c: Make symbols static if they're not exported.
2040 (x_report_frame_params, make_terminal_frame): Now static.
2041 (get_frame_param): Now static, unless HAVE_NS.
2042 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2043 (x_get_resource_string): Remove; not used.
2044 * frame.h (make_terminal_frame, x_report_frame_params):
2045 (x_get_resource_string); Remove decls.
2046 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2047 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2048
239f9db9
PE
2049 * font.c, fontset.c: Make symbols static if they're not exported.
2050 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2051 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2052 * font.c (font_close_object): Now static.
2053 * font.h (font_close_object): Remove.
2054 * fontset.c (FONTSET_OBJLIST): Remove.
2055 (free_realized_fontset) #if-0 the body, which does nothing.
2056 (face_suitable_for_char_p): #if-0, as it's never called.
2057 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2058 * xfaces.c (face_at_string_position):
2059 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2060 since 0 is always ASCII.
2061
dfcf3579
PE
2062 * fns.c (weak_hash_tables): Now static.
2063
5045092b
PE
2064 * fileio.c: Make symbols static if they're not exported.
2065 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2066 (Vwrite_region_annotation_buffers): Now static.
2067
57a96f5c
PE
2068 * eval.c: Make symbols static if they're not exported.
2069 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2070 * lisp.h (backtrace_list): Remove decl.
2071
35f08c38
PE
2072 * emacs.c: Make symbols static if they're not exported.
2073 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2074 (fatal_error_code, fatal_error_signal_hook, standard_args):
2075 Now static.
2076 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2077 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2078 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2079 * lisp.h (fatal_error_signal_hook): Remove decl.
2080 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2081
f44bd759
PE
2082 * editfns.c: Move a (normally-unused) function to its only use.
2083 * editfns.c, lisp.h (get_operating_system_release): Remove.
2084 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2085 worth the hassle of breaking this out.
2086
b532497d
PE
2087 * xterm.c: Make symbols static if they're not exported.
2088 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2089 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2090 (x_destroy_window, x_delete_display):
2091 Now static.
2092 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2093 (x_mouse_leave): Remove; unused.
2094 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2095 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2096 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2097 Remove decls.
2098 (x_mouse_leave): Declare only if WINDOWSNT.
2099 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2100 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2101 USE_X_TOOLKIT.
2102
1675728f
PE
2103 * ftxfont.c: Make symbols static if they're not exported.
2104 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2105 HAVE_FREETYPE.
2106 * font.h (ftxfont_driver): Likewise.
2107
e4cebfca
PE
2108 * xfns.c: Make symbols static if they're not exported.
2109 (x_last_font_name, x_display_info_for_name):
2110 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2111 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2112 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2113 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2114 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2115 (last_show_tip_args): Now static.
2116 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2117 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2118 (x_screen_planes): Remove; unused.
2119 * dispextern.h (x_screen_planes): Remove decl.
2120
5bf46f05
PE
2121 * dispnew.c: Make symbols static if they're not exported.
2122 * dispextern.h (redraw_garbaged_frames, scrolling):
2123 (increment_row_positions): Remove.
2124 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2125 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2126 Now static.
2127 (redraw_garbaged_frames): Remove; unused.
2128
435f4c28
PE
2129 * xfaces.c: Make symbols static if they're not exported.
2130 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2131 Remove decls.
2132 * xterm.h (defined_color): Remove decls.
2133 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2134 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2135 (menu_face_changed_default, defined_color, free_realized_face):
2136 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2137 (ascii_face_of_lisp_face): Remove; unused.
2138
8524aef3
PE
2139 * xdisp.c: Make symbols static if they're not exported.
2140 * dispextern.h (scratch_glyph_row, window_box_edges):
2141 (glyph_to_pixel_coords, set_cursor_from_row):
2142 (get_next_display_element, set_iterator_to_next):
2143 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2144 (show_mouse_face): Remove decls
2145 * frame.h (message_buf_print): Likewise.
2146 * lisp.h (pop_message, set_message, check_point_in_composition):
2147 Likewise.
2148 * xterm.h (set_vertical_scroll_bar): Likewise.
2149 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2150 (message_buf_print, scratch_glyph_row, displayed_buffer):
2151 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2152 (get_next_display_element, show_mouse_face, window_box_edges):
2153 (frame_to_window_pixel_xy, check_point_in_composition):
2154 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2155 (glyph_to_pixel_coords): Remove; unused.
2156
16390cd2
PE
2157 * dired.c (file_name_completion): Now static.
2158
2159 * dbusbind.c (xd_in_read_queued_messages): Now static.
2160
a25f4dfa
PE
2161 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2162 * data.c (circular_list_error): Remove.
2163
14a9c8df
PE
2164 * commands.h (last_point_position, last_point_position_buffer):
2165 (last_point_position_window): Remove decls.
2166 * keyboard.c: Make these variables static.
2167
04f2d78b
CB
2168 * coding.h (coding, code_convert_region, encode_coding_gap):
2169 Remove decls.
74ab6df5
PE
2170 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2171 (iso_code_class, detect_coding, code_convert_region): Now static.
2172 (encode_coding_gap): Remove; unused.
2173
38dfbee1
PE
2174 * chartab.c (chartab_chars, chartab_bits): Now static.
2175
a2cb4e63
PE
2176 * charset.h (charset_iso_8859_1): Remove decl.
2177 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2178 Now static.
2179
127198fd
PE
2180 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2181 * ccl.c (Vccl_program_table): Now static.
2182 (check_ccl_update): Remove; unused.
2183
d85b608f
PE
2184 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2185 * category.h: ... from here.
2186 * category.c (check_category_table, set_category_set): Now static.
2187
31cd66f3
PE
2188 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2189 * lisp.h: Remove these decls.
2190
c358e587
PE
2191 * buffer.c (buffer_count): Remove unused var.
2192
e78aecca
PE
2193 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2194 so that it's not optimized away.
2195 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2196 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2197 exported only to the debugger.
2198
e192d7d3 2199 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2200 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2201
92470028
PE
2202 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2203 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2204 was inaccessible from Lisp.
2205 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2206 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2207
244ed907
PE
2208 alloc.c: Import and export fewer symbols, and remove unused items.
2209 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2210 is defined.
2211 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2212 it's not optimized away by whole-program optimization.
2213 (message_enable_multibyte, free_misc): Remove.
2214 (catchlist, handlerlist, mark_backtrace):
2215 Declare only if BYTE_MARK_STACK.
2216 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2217 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2218 (message_enable_multibyte): Remove decl.
2219 (free_misc, interval_free_list, float_block, float_block_index):
2220 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2221 (cons_free_list, last_marked_index):
2222 Now static.
2223 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2224 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2225 (mark_backtrace): Define only if BYTE_MARK_STACK.
2226 * xdisp.c (message_enable_multibyte): Now static.
2227
61c2b50e 2228 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2229 This makes it easier for human readers (and static analyzers)
2230 to see whether these variables are used from other modules.
2231 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2232 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2233 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2234 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2235 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2236 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2237 * xmenu.c, xselect.c:
2238 Declare Q* vars static if they are not used in other modules.
2239 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2240 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2241 Remove decls of unexported vars.
2242 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2243
95c82688
PE
2244 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2245
16a97296
PE
2246 Make Emacs functions such as Fatom 'static' by default.
2247 This makes it easier for human readers (and static analyzers)
2248 to see whether these functions can be called from other modules.
2249 DEFUN now defines a static function. To make the function external
2250 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2251 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2252 (Finit_image_library):
16a97296
PE
2253 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2254 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2255 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2256 Remove decls, since these functions are now static.
2257 (Funintern, Fget_internal_run_time): New decls, since these functions
2258 were already external.
95c82688 2259
16a97296
PE
2260 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2261 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2262 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2263 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2264 * keyboard.c, keymap.c, lread.c:
2265 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2266 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2267 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2268 Mark functions with DEFUE instead of DEFUN,
2269 if they are used in other modules.
2270 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2271 decls for now-static functions.
2272 * buffer.h (Fdelete_overlay): Remove decl.
2273 * callproc.c (Fgetenv_internal): Mark as internal.
2274 * composite.c (Fremove_list_of_text_properties): Remove decl.
2275 (Fcomposition_get_gstring): New forward static decl.
2276 * composite.h (Fcomposite_get_gstring): Remove decl.
2277 * dired.c (Ffile_attributes): New forward static decl.
2278 * doc.c (Fdocumntation_property): New forward static decl.
2279 * eval.c (Ffetch_bytecode): New forward static decl.
2280 (Funintern): Remove extern decl; now in .h file where it belongs.
2281 * fileio.c (Fmake_symbolic_link): New forward static decl.
2282 * image.c (Finit_image_library): New forward static decl.
2283 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2284 * intervals.h (Fprevious_property_change):
2285 (Fremove_list_of_text_properties): Remove decls.
2286 * keyboard.c (Fthis_command_keys): Remove decl.
2287 (Fcommand_execute): New forward static decl.
2288 * keymap.c (Flookup_key): New forward static decl.
2289 (Fcopy_keymap): Now static.
2290 * keymap.h (Flookup_key): Remove decl.
2291 * process.c (Fget_process): New forward static decl.
2292 (Fprocess_datagram_address): Mark as internal.
2293 * syntax.c (Fsyntax_table_p): New forward static decl.
2294 (skip_chars): Remove duplicate decl.
2295 * textprop.c (Fprevious_property_change): New forward static decl.
2296 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2297 Now internal.
2298 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2299 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2300
785bbd42
PE
2301 * editfns.c (Fformat): Remove unreachable code.
2302
8b913b57
AS
23032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2304
2305 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2306 change. (Bug#8496)
2307
a6744a35
EZ
23082011-04-13 Eli Zaretskii <eliz@gnu.org>
2309
2310 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2311 when at ZV. (Bug#8487)
2312
e7974947
AS
23132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2314
baad03f0
AS
2315 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2316 (Bug#8437)
2317 * keyboard.c (parse_tool_bar_item): Likewise.
2318 * sound.c (sound_cleanup, alsa_close): Likewise.
2319 * termcap.c (tgetent): Likewise.
2320 * xfns.c (x_default_font_parameter): Likewise.
2321 * xsettings.c (read_and_apply_settings): Likewise.
2322
e7974947
AS
2323 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2324 (overrun_check_free): Protoize.
2325
28272684
PE
23262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2327
2328 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2329 since callers should never pass a negative size.
2330 Change the signature to match that of plain 'read' and 'write'; see
2331 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2332 * lisp.h: Update prototypes of emacs_write and emacs_read.
2333
11997c76
EZ
23342011-04-11 Eli Zaretskii <eliz@gnu.org>
2335
2336 * xdisp.c (redisplay_window): Don't try to determine the character
2337 position of the scroll margin if the window start point w->startp
e896f03c 2338 is outside the buffer's accessible region. (Bug#8468)
11997c76 2339
8a2cbd72
EZ
23402011-04-10 Eli Zaretskii <eliz@gnu.org>
2341
2342 Fix write-region and its subroutines for buffers > 2GB.
2343 * fileio.c (a_write, e_write): Modify declaration of arguments and
2344 local variables to support buffers larger than 2GB.
2345 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2346
2347 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2348 argument, local variables, and return value.
2349
2350 * lisp.h: Update prototypes of emacs_write and emacs_read.
2351
2352 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2353
4073e537 23542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2355
1ebfdcb6
PE
2356 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2357
b2ded58d
PE
2358 Fix more problems found by GCC 4.6.0's static checks.
2359
7d66342c
PE
2360 * xdisp.c (vmessage): Use a better test for character truncation.
2361
bbf47d44
PE
2362 * charset.c (load_charset_map): <, not <=, for optimization,
2363 and to avoid potential problems with integer overflow.
9248994d 2364 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2365 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2366 * editfns.c (Fformat): Likewise.
1e69125e 2367 * syntax.c (skip_chars): Likewise.
3befa583 2368
e3019616
PE
2369 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2370 This also lets GCC 4.6.0 generate slightly better loop code.
2371
becfa255
PE
2372 * callint.c (Fcall_interactively): <, not <=, for optimization.
2373 (Fcall_interactively): Count the number of arguments produced,
2374 not the number of arguments given. This is simpler and lets GCC
2375 4.6.0 generate slightly better code.
2376
dae0cd48
PE
2377 * ftfont.c: Distingish more carefully between FcChar8 and char.
2378 The previous code passed unsigned char * to a functions like
2379 strlen and xstrcasecmp that expect char *, which does not
2380 conform to the C standard.
2381 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2382 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2383 char * when the C standard requires it.
2384
76032d70
PE
2385 * keyboard.c (read_char): Remove unused var.
2386
eb3f1cc8
PE
2387 * eval.c: Port to Windows vsnprintf (Bug#8435).
2388 Include <limits.h>.
2389 (SIZE_MAX): Define if the headers do not.
2390 (verror): Do not give up if vsnprintf returns a negative count.
2391 Instead, grow the buffer. This ports to Windows vsnprintf, which
2392 does not conform to C99. Problem reported by Eli Zaretskii.
2393 Also, simplify the allocation scheme, by avoiding the need for
2394 calling realloc, and removing the ALLOCATED variable.
2395
70476b54
PE
2396 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2397
12020a9e
PE
2398 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2399 But keep the doprint source code for now, as we might revamp it
2400 and use it again (Bug#8435).
ea6c7ae6
PE
2401 * lisp.h (doprnt): Remove.
2402 * Makefile.in (base_obj): Remove doprnt.o.
2403 * deps.mk (doprnt.o): Remove.
2404
5fdb398c
PE
2405 error: Print 32- and 64-bit integers portably (Bug#8435).
2406 Without this change, on typical 64-bit hosts error ("...%d...", N)
2407 was used to print both 32- and 64-bit integers N, which relied on
2408 undefined behavior.
2409 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2410 New macro.
2411 * lisp.h (error, verror): Mark as printf-like functions.
2412 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2413 Report overflow in size calculations when allocating printf buffer.
2414 Do not truncate output string at its first null byte.
2415 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2416 Truncate the output at a character boundary, since vsnprintf does not
2417 do that.
2418 * charset.c (check_iso_charset_parameter): Convert internal
2419 character to string before calling 'error', since %c now has the
2420 printf meaning.
2421 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2422 overflow when computing char to be passed to 'error'. Do not
2423 pass Lisp_Object to 'error'; pass the integer instead.
2424 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2425 formatted with plain %d.
2426
b189fa66
PE
2427 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2428
bff87ef0
PE
2429 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2430
7e2cac20
PE
2431 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2432
ce4d90b5
PE
2433 * xterm.c (x_catch_errors): Remove duplicate declaration.
2434
266c9547
PE
2435 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2436
79c49ad2
PE
2437 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2438
368f4090
JM
24392011-04-10 Jim Meyering <meyering@redhat.com>
2440
2441 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2442 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2443 return ssize_t not "int", and use size_t as the buffer length.
2444 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2445 * gnutls.h: Update declarations.
2446 * process.c (read_process_output): Use ssize_t, to match.
2447 (send_process): Likewise.
2448
a32d4040
CY
24492011-04-09 Chong Yidong <cyd@stupidchicken.com>
2450
2451 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2452
8546720e 24532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2454
04f2d78b
CB
2455 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2456 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2457
8546720e
GM
2458 * xterm.c (handle_one_xevent):
2459 * xmenu.c (create_and_show_popup_menu):
2460 * xselect.c (x_decline_selection_request)
2461 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2462
0a2f5c1a 24632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2464
2465 Fix some uses of `int' instead of EMACS_INT.
2466 * search.c (string_match_1, fast_string_match)
2467 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2468 (scan_buffer, find_next_newline_no_quit)
2469 (find_before_next_newline, search_command, Freplace_match)
2470 (Fmatch_data): Make some `int' variables be EMACS_INT.
2471
2472 * xdisp.c (display_count_lines): 3rd argument and return value now
2473 EMACS_INT. All callers changed.
2474 (pint2hrstr): Last argument is now EMACS_INT.
2475
2476 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2477 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2478 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2479 (decode_coding_utf_16, decode_coding_emacs_mule)
2480 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2481 (decode_coding_ccl, decode_coding_charset)
2482 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2483 (decode_coding_iso_2022, decode_coding_emacs_mule)
2484 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2485 <char_offset, last_offset>: Declare EMACS_INT.
2486 (encode_coding_utf_8, encode_coding_utf_16)
2487 (encode_coding_emacs_mule, encode_invocation_designation)
2488 (encode_designation_at_bol, encode_coding_iso_2022)
2489 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2490 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2491 Declare EMACS_INT.
2492 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2493 (encode_invocation_designation): Last argument P_NCHARS is now
2494 EMACS_INT.
2495 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2496 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2497
2498 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2499 All users changed.
2500
2501 * ccl.c (Fccl_execute_on_string): Declare some variables
2502 EMACS_INT.
2503
8546720e 25042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2505
2506 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2507
4e19a977
CS
25082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2509
2510 * process.c (Fformat_network_address): Doc fix.
2511
87302331
R
25122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2513
2514 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2515
cbb59342
CY
25162011-04-08 Chong Yidong <cyd@stupidchicken.com>
2517
2518 * keyboard.c (read_char): Call Lisp function help-form-show,
2519 instead of using internal_with_output_to_temp_buffer.
2520 (Qhelp_form_show): New var.
e0d38eeb 2521 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2522
2523 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2524
2525 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2526
e67a13ab
CY
25272011-04-06 Chong Yidong <cyd@stupidchicken.com>
2528
04f2d78b
CB
2529 * process.c (Flist_processes): Remove to Lisp.
2530 (list_processes_1): Delete.
e67a13ab 2531
973f782d
EZ
25322011-04-06 Eli Zaretskii <eliz@gnu.org>
2533
7c106b1e
EZ
2534 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2535
973f782d
EZ
2536 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2537
41cf7d1a 25382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2539
ca23cc88
PE
2540 Fix more problems found by GCC 4.6.0's static checks.
2541
f390e2d5
PE
2542 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2543
42eea0d0
PE
2544 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2545
b69769da 2546 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2547
f9541e84
PE
2548 * xdisp.c (vmessage): Mark as a printf-like function.
2549
13841b55
PE
2550 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2551
c136c10f
PE
2552 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2553
5e2d4a30
PE
2554 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2555 printf-like functions.
2556 (tiff_load): Add casts to remove these marks before passing them
2557 to system-supplied API.
2558
583f48b9
PE
2559 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2560
b25d760e
PE
2561 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2562 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2563 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2564 directly, rather than having caller test rule sign. This avoids
2565 some unnecessary tests.
2566 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2567 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2568 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2569
bc7b6697 2570 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2571 (xfont_open): Avoid unnecessary tests.
bc7b6697 2572
27ccc379
PE
2573 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2574
dcd5c89a
PE
2575 * composite.h, composite.c (composition_gstring_put_cache):
2576 Use EMACS_INT, not int, for length.
2577
b13a45c6
PE
2578 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2579 breaking out part of COMPOSITION_DECODE_RULE.
2580 (COMPOSITION_DECODE_RULE): Use it.
2581 * composite.c (get_composition_id): Remove unused local vars,
2582 by using the new macro.
2583
1e792e4d
PE
2584 * textprop.c (set_text_properties_1): Change while to do-while,
2585 since the condition is always true at first.
2586
dc6c6455 2587 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2588 (interval_deletion_adjustment): Return unsigned value.
2589 All uses changed.
dc6c6455 2590
aba7731a
PE
2591 * process.c (list_processes_1, create_pty, read_process_output):
2592 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2593 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2594 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2595 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2596 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2597
fdfc4bf3
PE
2598 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2599
fca8fe46 2600 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2601 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2602
06a0259a 2603 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2604 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2605 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2606
e7b9e80f
PE
2607 * print.c (print_error_message): Avoid int overflow.
2608
56201685
PE
2609 * font.c (font_list_entities): Redo for clarity,
2610 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2611
78834453 2612 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2613 (font_score): Avoid potential overflow in diff calculation.
78834453 2614
0bc0b309 2615 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2616 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2617
e610eaca
PE
2618 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2619
b895abce
PE
2620 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2621 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2622 can always succeed if overflow has undefined behavior.
2623
1f1d9321 2624 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2625 (wordify): Omit three unnecessary tests.
1f1d9321 2626
c59478bc
PE
2627 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2628 All callers changed. This avoids the need for an unused var.
2629
79b73827
PE
2630 * casefiddle.c (casify_region): Remove var that is set but not used.
2631
a4db5dfe
PE
2632 * dired.c (file_name_completion): Remove var that is set but not used.
2633
43aae36e
PE
2634 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2635
2a47c44d 2636 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2637 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2638
a37c69bf
PE
2639 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2640 Check for integer overflow on size calculations.
2641
328ab8e7
PE
2642 * buffer.c (Fprevious_overlay_change): Remove var that is set
2643 but not used.
2644
e5a2a5cb
PE
2645 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2646 Remove vars that are set but not used.
8d84a6eb 2647 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2648 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2649
a60e5f68
PE
2650 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2651
f661cb61 2652 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2653 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2654
f0397f5a
PE
2655 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2656 that are set but not used.
2657
8664db06 2658 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2659 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2660
6abdaa4a
PE
2661 * xselect.c (x_get_local_selection, x_handle_property_notify):
2662 Remove vars that are set but not used.
2663
0ce7538d 2664 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2665 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2666
9ae848fc
PE
2667 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2668 Remove var that is set but not used.
0b918413
PE
2669 (scroll_bar_windows_size): Now size_t, not int.
2670 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2671 Check for overflow.
9ae848fc 2672
a5a62657
PE
2673 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2674 (map_tty_color) [!defined MSDOS]: Likewise.
2675
5c5cdd39
PE
2676 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2677
66ebf983
PE
2678 * coding.c: Remove vars that are set but not used.
2679 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2680 All callers changed.
2681 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2682 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2683 (decode_coding_charset): Remove vars that are set but not used.
2684
1be4d761
PE
2685 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2686 that is set but not used.
2687
47553fa8
PE
2688 * print.c (print_object): Remove var that is set but not used.
2689
1f7196bf 2690 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2691 The gnulib version avoids calling malloc in the usual case,
2692 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2693 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2694 * filelock.c (current_lock_owner): Likewise.
2695 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2696 * sysdep.c: Include allocator.h, careadlinkat.h.
2697 (emacs_no_realloc_allocator): New static constant.
2698 (emacs_readlink): New function.
fdb61804
PE
2699 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2700 ../lib/careadlinkat.h.
d1fdcab7 2701
f84c17c7
SM
27022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2703
2704 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2705 first non-nil return value).
2706
ef3862ad
JD
27072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2708
2709 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2710 if not defined (Bug#8403).
2711
376a7006
JB
27122011-04-02 Juanma Barranquero <lekktu@gmail.com>
2713
2714 * xdisp.c (display_count_lines): Remove parameter `start',
2715 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2716 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2717 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2718 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2719 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2720 and thereabouts. All callers changed.
2721 (get_per_char_metric): Remove parameter `f', unused since
2722 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2723
6ca3801d
JM
27242011-04-02 Jim Meyering <meyering@redhat.com>
2725
2726 do not dereference NULL upon failed strdup
2727 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2728 (ns_get_family): Likewise.
2729
d8e2b5ba
JB
27302011-04-02 Juanma Barranquero <lekktu@gmail.com>
2731
2732 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2733
8c74fcbd
JD
27342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2735
2736 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2737 later (Bug#8403).
2738
7200d79c
SM
27392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2740
03408648 2741 Add lexical binding.
7200d79c 2742
03408648
SM
2743 * window.c (Ftemp_output_buffer_show): New fun.
2744 (Fsave_window_excursion):
2745 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2746
2747 * lread.c (lisp_file_lexically_bound_p): New function.
2748 (Fload): Bind Qlexical_binding.
2749 (readevalloop): Remove `evalfun' arg.
2750 Bind Qinternal_interpreter_environment.
2751 (Feval_buffer): Bind Qlexical_binding.
2752 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2753 Mark as dynamic.
2754 (syms_of_lread): Declare `lexical-binding'.
2755
2756 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2757
2758 * keyboard.c (eval_dyn): New fun.
2759 (menu_item_eval_property): Use it.
ca105506
SM
2760
2761 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2762
03408648
SM
2763 * fns.c (concat, mapcar1): Accept byte-code-functions.
2764
2765 * eval.c (Fsetq): Handle lexical vars.
2766 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2767 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2768 (FletX, Flet): Obey lexical binding.
2769 (Fcommandp): Handle closures.
2770 (Feval): New `lexical' arg.
2771 (eval_sub): New function extracted from Feval. Use it almost
2772 everywhere where Feval was used. Look up vars in lexical env.
2773 Handle closures.
2774 (Ffunctionp): Move from subr.el.
2775 (Ffuncall): Handle closures.
2776 (apply_lambda): Remove `eval_flags'.
2777 (funcall_lambda): Handle closures and new byte-code-functions.
2778 (Fspecial_variable_p): New function.
2779 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2780 but without exporting it to Lisp.
23aba0ea 2781
23aba0ea 2782 * doc.c (Fdocumentation, store_function_docstring):
03408648 2783 * data.c (Finteractive_form): Handle closures.
23aba0ea 2784
03408648
SM
2785 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2786 interactive spec.
ba83908c 2787
04f2d78b
CB
2788 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2789 New byte-codes.
03408648
SM
2790 (exec_byte_code): New function extracted from Fbyte_code to handle new
2791 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2792
03408648 2793 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2794
03408648 2795 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2796
e2abce01
JB
27972011-03-31 Juanma Barranquero <lekktu@gmail.com>
2798
2799 * xdisp.c (redisplay_internal): Fix prototype.
2800
63696a73 28012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2802
63696a73 2803 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2804 (try_scrolling): Use it when setting scroll_limit.
2805 Limit scrolling to 100 screen lines.
63696a73
EZ
2806 (redisplay_window): Even when falling back on "recentering",
2807 position point in the window according to scroll-conservatively,
2808 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2809
2810 (try_scrolling): When point is above the window, allow searching
2811 as far as scroll_max, or one screenful, to compute vertical
2812 distance from PT to the scroll margin position. This prevents
2813 try_scrolling from unnecessarily failing when
2814 scroll-conservatively is set to a value slightly larger than the
2815 window height. Clean up the case of PT below the margin at bottom
2816 of window: scroll_max can no longer be INT_MAX. When aggressive
2817 scrolling is in use, don't let point enter the opposite scroll
2818 margin as result of the scroll.
2819 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2820 threshold of 100 lines for never-recentering scrolling.
2821
e4cc2dfc
JB
28222011-03-31 Juanma Barranquero <lekktu@gmail.com>
2823
2824 * dispextern.h (move_it_by_lines):
2825 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2826 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2827 (message_log_check_duplicate): Remove parameters `prev_bol' and
2828 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2829 (redisplay_internal): Remove parameter `preserve_echo_area',
2830 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2831
2832 * indent.c (Fvertical_motion):
2833 * window.c (window_scroll_pixel_based, Frecenter):
2834 Don't pass `need_y_p' to `move_it_by_lines'.
2835
1c470562
SM
28362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2837
44f230aa
SM
2838 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2839 steal a few bits to be more compact.
2840 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2841 Remove unneeded casts.
2842
1c470562
SM
2843 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2844
888adce9
ZK
28452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2846
2847 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2848 binding" message (bug#7967).
2849
f838ed7b
PE
28502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2851
77861b95
PE
2852 Fix more problems found by GCC 4.6.0's static checks.
2853
de6dbc14
PE
2854 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2855 Remove unused local var.
2856
f838ed7b
PE
2857 * editfns.c (Fmessage_box): Remove unused local var.
2858
792c7b2b
PE
2859 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2860 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2861 Omit unused local vars.
c499e557 2862 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2863 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2864 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2865 Omit unused local var.
2866
ba0165e1
PE
2867 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2868 Don't assume string length fits in int.
32ad8845 2869 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2870 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2871
3c59b4c9
PE
2872 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2873 instead of alloca (Bug#8344).
2874
a3eed478 2875 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2876 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2877
eb4d412d
PE
2878 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2879
1658b401
PE
2880 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2881 concerns.
2882
2883 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2884
2885 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2886
9a2c6e05
PE
2887 * keyboard.c (syms_of_keyboard): Use the same style as later
2888 in this function when indexing through an array. This also
2889 works around GCC bug 48267.
2890
03d0a109
PE
2891 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2892
44f730c8
PE
2893 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2894
fe75f926
PE
2895 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2896 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2897
ffa8c828
PE
2898 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2899 This avoids undefined behavior on integer overflow, and is a bit
2900 more convenient anyway since it is compared to a size_t variable.
2901
c5101a77
PE
2902 Variadic C functions now count arguments with size_t, not int.
2903 This avoids an unnecessary limitation on 64-bit machines, which
2904 caused (substring ...) to crash on large vectors (Bug#8344).
2905 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2906 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2907 All variadic functions and their callers changed accordingly.
c5101a77
PE
2908 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2909 * data.c (arith_driver, float_arith_driver): Likewise.
2910 * editfns.c (general_insert_function): Likewise.
2911 * eval.c (struct backtrace.nargs, interactive_p)
2912 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2913 (funcall_lambda, mark_backtrace): Likewise.
2914 * fns.c (concat): Likewise.
2915 * frame.c (x_set_frame_parameters): Likewise.
2916 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2917 0 if not found, not -1. All callers changed.
2918
dd3f25f7
PE
2919 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2920 (stack_copy_size): Now size_t, not int.
2921 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2922
461c2ab9
JB
29232011-03-28 Juanma Barranquero <lekktu@gmail.com>
2924
2925 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2926 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2927 All callers changed.
2928
2929 * lisp.h (multibyte_char_to_unibyte):
2930 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2931 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2932 * character.h (CHAR_TO_BYTE8):
2933 * cmds.c (internal_self_insert):
2934 * editfns.c (general_insert_function):
2935 * keymap.c (push_key_description):
2936 * search.c (Freplace_match):
2937 * xdisp.c (message_dolog, set_message_1): All callers changed.
2938
f6d62986
SM
29392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2940
2941 * keyboard.c (safe_run_hook_funcall): New function.
2942 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2943 don't set the hook to nil, but remove the offending function instead.
2944 (Qcommand_hook_internal): Remove, unused.
2945 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2946 Vcommand_hook_internal.
2947
2948 * eval.c (enum run_hooks_condition): Remove.
2949 (funcall_nil, funcall_not): New functions.
2950 (run_hook_with_args): Call each function through a `funcall' argument.
2951 Remove `cond' argument, now redundant.
2952 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2953 (Frun_hook_with_args_until_failure): Adjust accordingly.
2954 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2955
1db5b1ad
JB
29562011-03-28 Juanma Barranquero <lekktu@gmail.com>
2957
2958 * dispextern.h (string_buffer_position): Remove declaration.
2959
2960 * print.c (strout): Remove parameter `multibyte', unused since
2961 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2962
2963 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2964 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2965 All callers changed.
2966
2967 * w32.c (_wsa_errlist): Use braces for struct initializers.
2968
2969 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2970 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2971 All callers changed.
2972 (string_buffer_position): Likewise. Also, make static (it's never
2973 used outside xdisp.c).
2974 (cursor_row_p): Remove parameter `w', unused since
2975 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2976 (decode_mode_spec): Remove parameter `precision', introduced during
2977 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2978 All callers changed.
2979
5ffb62aa
JD
29802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2981
2982 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2983
461c2ab9 29842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2985
2986 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2987 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2988 (ns_update_auto_hide_menu_bar): New functions.
2989 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2990 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2991 ns_constrain_all_frames.
2992 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2993 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2994
5c380ffb
JD
29952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2996
2997 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2998
9af30bdf
GM
29992011-03-27 Glenn Morris <rgm@gnu.org>
3000
3001 * syssignal.h: Replace RETSIGTYPE with void.
3002 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3003 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3004 Replace SIGTYPE with void everywhere.
3005 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3006 * s/template.h (SIGTYPE): Remove commented out definition.
3007
e2abce01
JB
30082011-03-26 Eli Zaretskii <eliz@gnu.org>
3009
3010 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3011 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3012
f868cd8a
JB
30132011-03-26 Juanma Barranquero <lekktu@gmail.com>
3014
59eb0929
JB
3015 * w32.c (read_unc_volume): Use parameter `henum', instead of
3016 global variable `wget_enum_handle'.
3017
3018 * keymap.c (describe_vector): Remove parameters `indices' and
3019 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3020 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3021
f868cd8a
JB
3022 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3023
3024 * keyboard.c (timer_check): Remove parameter `do_it_now',
3025 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3026 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3027 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3028
3029 * keyboard.c (read_char):
3030 * w32menu.c (w32_menu_display_help):
3031 * xmenu.c (show_help_event, menu_help_callback):
3032 Adjust calls to `show_help_echo'.
3033
3034 * gtkutil.c (xg_maybe_add_timer):
3035 * keyboard.c (readable_events):
3036 * process.c (wait_reading_process_output):
3037 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3038
3039 * insdel.c (adjust_markers_gap_motion):
3040 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3041 (gap_left, gap_right): Don't call it.
3042
2ecf6fdb
CY
30432011-03-25 Chong Yidong <cyd@stupidchicken.com>
3044
3045 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3046 incurred during fontification.
3047
6b1f9ba4
JB
30482011-03-25 Juanma Barranquero <lekktu@gmail.com>
3049
3050 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3051 (DEFVAR_PER_BUFFER): Don't pass it.
3052
3053 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3054 (scrolling_window): Don't pass it.
3055
0f4a96b5
JB
30562011-03-25 Juanma Barranquero <lekktu@gmail.com>
3057
3058 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3059
3060 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3061 and `suffix'.
3062 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3063 of variables specific to SELinux and computation of `encoded_absname'.
3064
3065 * image.c (XPutPixel): Remove unused variable `height'.
3066
3067 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3068
3069 * unexw32.c (get_section_info): Remove unused variable `section'.
3070
3071 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3072 (system_process_attributes): Remove unused variable `sess'.
3073 (sys_read): Remove unused variable `err'.
3074
3075 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3076 (w32_wnd_proc): Remove unused variable `isdead'.
3077 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3078 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3079 (x_create_tip_frame): Remove unused variable `tem'.
3080
3081 * w32inevt.c (w32_console_read_socket):
3082 Remove unused variable `no_events'.
3083
3084 * w32term.c (x_draw_composite_glyph_string_foreground):
3085 Remove unused variable `width'.
3086
1149507c
JB
30872011-03-24 Juanma Barranquero <lekktu@gmail.com>
3088
3089 * w32term.c (x_set_glyph_string_clipping):
3090 Don't pass uninitialized region to CombineRgn.
3091
9c88f339
JB
30922011-03-23 Juanma Barranquero <lekktu@gmail.com>
3093
3094 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3095 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3096 (Fx_close_connection): Remove unused variable `i'.
3097
3098 * w32font.c (w32font_draw): Return number of glyphs.
3099 (w32font_open_internal): Remove unused variable `i'.
3100 (w32font_driver): Add missing initializer.
3101
3102 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3103 (fill_in_menu): Remove unused variable `items_added'.
3104
3105 * w32term.c (last_mouse_press_frame): Remove static global variable.
3106 (w32_clip_to_row): Remove unused variable `f'.
3107 (x_delete_terminal): Remove unused variable `i'.
3108
3109 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3110 (NOTHING): Remove unused static global variable.
3111 (uniscribe_check_otf): Remove unused variable `table'.
3112 (uniscribe_font_driver): Add missing initializers.
3113
dee091a3
JD
31142011-03-23 Julien Danjou <julien@danjou.info>
3115
3116 * term.c (Fsuspend_tty, Fresume_tty):
3117 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3118 * window.c (temp_output_buffer_show):
3119 * insdel.c (signal_before_change):
3120 * frame.c (Fhandle_switch_frame):
3121 * fileio.c (Fdo_auto_save):
3122 * emacs.c (Fkill_emacs):
3123 * editfns.c (save_excursion_restore):
3124 * cmds.c (internal_self_insert):
3125 * callint.c (Fcall_interactively):
3126 * buffer.c (Fkill_all_local_variables):
3127 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3128 Use Frun_hooks.
0f4a96b5 3129 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3130 unconditionnaly since it does the check itself.
3131
2c520ab5 31322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3133
c9c49752
PE
3134 Fix more problems found by GCC 4.5.2's static checks.
3135
8abc3f12
PE
3136 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3137 the first time through the loop, since we know p0 < p1 then.
3138 This also avoids a gcc -Wstrict-overflow warning.
3139
a2d26660
PE
3140 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3141 leading to a memory leak, possible in functions like
3142 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3143 of objects (Bug#8318).
a2d26660 3144
916c72e9
PE
3145 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3146 that could (at least in theory) be that large.
3147
19ab8a18
PE
3148 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3149 This is less likely to overflow, and avoids undefined behavior if
3150 overflow does occur. All callers changed. Use strtoul to scan
3151 for the unsigned long integer.
b7cbbd6f
PE
3152 (pint2hrstr): Simplify and tune code slightly.
3153 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3154
f0641eff
PE
3155 * scroll.c (do_scrolling): Work around GCC bug 48228.
3156 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3157
7f650bb9
PE
3158 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3159 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3160 (validate_x_resource_name): Simplify count usage.
3161 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3162
37dd57d1
PE
3163 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3164 fail (Bug#8306).
81e56e61 3165
699979fc 3166 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3167
401bf9b4
PE
3168 * process.c (Fmake_network_process): Use socklen_t, not int,
3169 where POSIX says socklen_t is required in portable programs.
3170 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3171 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3172 (Fmake_network_process, server_accept_connection):
3173 (wait_reading_process_output, read_process_output):
3174 Likewise.
3175
b93aacde
PE
3176 * process.c: Rename or move locals to avoid shadowing.
3177 (list_processes_1, Fmake_network_process):
3178 (read_process_output_error_handler, exec_sentinel_error_handler):
3179 Rename or move locals.
4dc343ee 3180 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3181 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3182 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3183 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3184 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3185
af8a867c 3186 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3187 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3188 Include tparam.h instead, since it declares them.
af8a867c
PE
3189 * cm.h (PC): Remove extern decl; tparam.h now does this.
3190 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3191 * terminfo.c: Include tparam.h, to check interfaces.
3192 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3193 (tparam): Adjust signature to match interface in tparam.h;
3194 this removes some undefined behavior. Check that outstring and len
3195 are zero, which they always are with Emacs.
3196 * tparam.h (PC, BC, UP): New extern decls.
3197
0248044d 3198 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3199 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3200
8ff096c1 3201 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3202 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3203 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3204 (ftfont_list): Remove unused local.
49eaafba
PE
3205 (get_adstyle_property, ftfont_pattern_entity):
3206 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3207 Rename locals to avoid shadowing.
8ff096c1 3208
e2be39f6
PE
3209 * xfont.c (xfont_list_family): Mark var as initialized.
3210
c9735e30
PE
3211 * xml.c (make_dom): Now static.
3212
8f5201ae
PE
3213 * composite.c (composition_compute_stop_pos): Rename local to
3214 avoid shadowing.
b246f932
PE
3215 (composition_reseat_it): Remove unused locals.
3216 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3217 (composition_update_it): Mark var as initialized.
11b61122
PE
3218 (find_automatic_composition): Mark vars as initialized,
3219 with a FIXME (Bug#8290).
8f5201ae 3220
760fbc2c
PE
3221 character.h: Rename locals to avoid shadowing.
3222 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3223 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3224 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3225 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3226 to avoid shadowing.
3227
ff08eb85
PE
3228 * textprop.c (property_change_between_p): Remove; unused.
3229
fc7bf025
PE
3230 * intervals.c (interval_start_pos): Now static.
3231
235d7abc
PE
3232 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3233
44f230aa
SM
3234 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3235 Rename locals to avoid shadowing.
3e7d6594 3236
50060332
PE
3237 * sound.c (wav_play, au_play, Fplay_sound_internal):
3238 Fix pointer signedness.
d01f234b 3239 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3240 (wav_play): Initialize a variable to 0, to prevent undefined
3241 behavior (Bug#8278).
50060332 3242
c4fc4e30
PE
3243 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3244
918436ed
PE
3245 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3246
c939f91b
PE
3247 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3248 clobbering (Bug#8298).
b9c7f648
PE
3249 * sysdep.c (sys_subshell): Likewise.
3250 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3251
6bd8c144
PE
3252 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3253 This should get cleaned up, so that child_setup has the
3254 same signature on all platforms.
3255
7710357c 3256 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3257 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3258
c59da222
CY
32592011-03-22 Chong Yidong <cyd@stupidchicken.com>
3260
3261 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3262 not to be necessary, and produces flickering.
3263
66b87493
GM
32642011-03-20 Glenn Morris <rgm@gnu.org>
3265
3266 * config.in: Remove file.
3267
45b6f6d5
JB
32682011-03-20 Juanma Barranquero <lekktu@gmail.com>
3269
3270 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3271 are now in src/globals.h.
3272 (syms_of_minibuf): Remove spurious & from previous change.
3273
3ec03f7e
LL
32742011-03-20 Leo <sdl.web@gmail.com>
3275
3276 * minibuf.c (completing-read-function): New variable.
3277 (completing-read-default): Rename from completing-read.
3278 (completing-read): Call completing-read-function.
3279
b14e3e21
CY
32802011-03-19 Juanma Barranquero <lekktu@gmail.com>
3281
3282 * xfaces.c (Fx_load_color_file):
3283 Read color file from absolute filename (bug#8250).
3284
f2b726e6
JB
32852011-03-19 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * makefile.w32-in: Update dependencies.
3288
09f6ff02
EZ
32892011-03-17 Eli Zaretskii <eliz@gnu.org>
3290
3291 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3292
29a6015a
PE
32932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3294
a3a6c54e
PE
3295 Fix more problems found by GCC 4.5.2's static checks.
3296
b766f867
PE
3297 * process.c (make_serial_process_unwind, send_process_trap):
3298 (sigchld_handler): Now static.
3299
be02381c
PE
3300 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3301 That way, the code declares only the vars that it needs.
3302 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3303 * s/cygwin.h (PTY_ITERATION): Likewise.
3304 * s/darwin.h (PTY_ITERATION): Likewise.
3305 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3306
57048744
PE
3307 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3308 * process.c (allocate_pty): Don't declare stb unless it's needed.
3309
7914961c 3310 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3311 (CONSTANTLIM): Remove; unused.
3312 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3313 Define only if needed.
7914961c 3314
b3967b18
PE
3315 * unexelf.c (unexec): Name an expression,
3316 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3317 Use a different way to cause a compilation error if anyone uses
3318 n rather than nn, a way that does not involve shadowing.
73366a00 3319 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3320
29a6015a
PE
3321 * deps.mk (unexalpha.o): Remove; unused.
3322
43cfc33e 3323 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3324 * unexec.h: New file.
ce701a33
PE
3325 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3326 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3327 Depend on unexec.h.
3328 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3329 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3330 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3331 Change as necessary to match prototype in unexec.h.
ce701a33 3332
01f44d5a
PE
3333 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3334 shadowing.
4f63c6bb 3335 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3336
a6670b0b
PE
3337 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3338 Rename locals to avoid shadowing.
3339
cef2010d 3340 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3341 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3342
d4d7173a
PE
3343 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3344
f08b802a
PE
3345 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3346 warning when compiling print.c.
3347
3ddb0639
PE
3348 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3349 instead of using an uninitialized var.
5ad03b97 3350 (font_sort_entities): Mark var as initialized.
3ddb0639 3351
170a2692
PE
3352 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3353
e663c700
PE
3354 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3355 pointers to constants.
89bc529a 3356 (font_parse_fcname): Remove unused vars.
7b81e2d0 3357 (font_delete_unmatched): Now static.
ea838e10 3358 (font_get_spec): Remove; unused.
13a547c6
PE
3359 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3360 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3361 Rename or move locals to avoid shadowing.
e663c700 3362
2a80c887 3363 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3364 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3365
1384fa33 3366 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3367 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3368
8b2c52e9
PE
3369 * alloc.c (mark_backtrace): Move decl from here ...
3370 * lisp.h: ... to here, so that it can be checked.
3371
475545b5 3372 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3373 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3374 (lisp_indirect_variable): Name an expression,
3375 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3376 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3377
b1349114 3378 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3379 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3380 Use const pointer when appropriate.
b1349114 3381
a2928364
PE
3382 * lisp.h (get_system_name, get_operating_system_release):
3383 Move decls here, to check interfaces.
3384 * process.c (get_operating_system_release): Move decl to lisp.h.
3385 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3386 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3387 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3388 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3389 (Fformat_time_string, Fencode_time, Finsert_char):
3390 (Ftranslate_region_internal, Fformat):
3391 Rename or remove local vars to avoid shadowing.
9710023e 3392 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3393
a415e694
PE
3394 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3395 avoid shadowing.
3396
8ef4622d
PE
3397 * lisp.h (eassert): Check that the argument compiles, even if
3398 ENABLE_CHECKING is not defined.
3399
946f9a5b
PE
3400 * data.c (Findirect_variable): Name an expression, to avoid
3401 gcc -Wbad-function-cast warning.
112396d6 3402 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3403 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3404 (Fmake_variable_buffer_local, Fmake_local_variable):
3405 Mark variables as initialized.
52746918 3406 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3407
e5aab7e7 3408 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3409 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3410 Rename locals to avoid shadowing.
dff45157
PE
3411 (mark_stack): Move local variables into the #ifdef region where
3412 they're used.
7bc26fdb
PE
3413 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3414 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3415 needed otherwise.
3416 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3417 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3418 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3419
e5aab7e7
PE
3420 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3421 avoids undefined behavior in theory.
3422
4da60324
PE
3423 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3424
88043301
PE
3425 Use functions, not macros, for up- and down-casing (Bug#8254).
3426 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3427 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3428 to use the following functions instead of these macros.
3429 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3430 EMACS_INT, since callers assume the returned value fits in int.
3431 (upcase1): Likewise, for UPCASE_TABLE.
3432 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3433 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3434 the race-condition problem in the old DOWNCASE.
88043301 3435
19ed5445
PE
3436 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3437 Rename locals to avoid shadowing.
3438 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3439 (regex_compile, re_search_2, re_match_2_internal):
3440 Remove unused local vars.
952db0d7
PE
3441 (FREE_VAR): Rewrite so as not to use empty "else",
3442 which gcc can warn about.
da053e48 3443 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3444 (RETALLOC_IF): Define only if needed.
3445 (WORDCHAR_P): Likewise. This one is never needed, but is used
3446 only in a comment talking about a compiler bug, so put inside
3447 the #if 0 of that comment.
3448 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3449 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3450 Remove; unused.
19ed5445 3451
1f3561e4 3452 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3453 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3454 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3455
ded6f8f7
PE
3456 * search.c (simple_search): Remove unused var.
3457
dbd37a95
PE
3458 * dired.c (compile_pattern): Move decl from here ...
3459 * lisp.h: ... to here, so that it can be checked.
3460 (struct re_registers): New forward decl.
3461
7e47afad
PE
3462 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3463
85f24f61
PE
3464 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3465 All uses changed.
3466 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3467 Rename locals to avoid shadowing.
5671df8f 3468 (Fvertical_motion): Mark locals as initialized.
85f24f61 3469
181aa2be 3470 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3471 (casify_region): Mark local as initialized.
181aa2be 3472
930d429c
PE
3473 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3474
7082eac6
PE
3475 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3476 New macros, so that the caller can use some names other than
3477 gcpro1, gcpro2, etc.
3478 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3479 of the new macros.
3480 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3481 argument, for consistency with GCPRO2_VAR, etc: it is now the
3482 prefix of the variable, not the variable itself. All uses
3483 changed.
38b2c076
PE
3484 * dired.c (directory_files_internal, file_name_completion):
3485 Rename locals to avoid shadowing.
3486
15206ed9
PE
3487 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3488 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3489 dired.c's scmp function, had undefined behavior.
3490 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3491 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3492 * buffer.h: ... to here, because these macros use current_buffer,
3493 and the new implementation with inline functions needs to have
3494 current_buffer in scope now, rather than later when the macros
3495 are used.
3496 (downcase, upcase1): New static inline functions.
3497 (DOWNCASE, UPCASE1): Reimplement using these functions.
3498 This avoids undefined behavior in expressions like
3499 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3500 from race conditions in accessing the global variables
3501 case_temp1 and case_temp2.
3502 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3503 * lisp.h (case_temp1, case_temp2): Remove their decls.
3504 * character.h (ASCII_CHAR_P): Move from here ...
3505 * lisp.h: ... to here, so that the inline functions mentioned
3506 above can use them.
3507
4a6bea26
PE
3508 * dired.c (directory_files_internal_unwind): Now static.
3509
f14b7e14
PE
3510 * fileio.c (file_name_as_directory, directory_file_name):
3511 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3512 Now static.
2893f146
PE
3513 (file_name_as_directory): Use const pointers when appropriate.
3514 (Fexpand_file_name): Likewise. In particular, newdir might
3515 point at constant storage, so make it a const pointer.
fd4ead52 3516 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3517 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3518 signedness issues.
f839df0c
PE
3519 (Fset_file_times, Finsert_file_contents, auto_save_error):
3520 Rename locals to avoid shadowing.
f14b7e14 3521
5716756e 3522 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3523 (Ftry_completion, Fall_completions): Rename or remove locals
3524 to avoid shadowing.
5716756e 3525
b4c3046a
PE
3526 * marker.c (bytepos_to_charpos): Remove; unused.
3527
b45db522
PE
3528 * lisp.h (verify_bytepos, count_markers): New decls,
3529 so that gcc does not warn that these functions aren't declared.
3530
85876d07
PE
3531 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3532 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3533 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3534 (copy_text): Remove unused local var.
85876d07 3535
03d78a21 3536 * filelock.c (within_one_second): Now static.
b3dd38ab 3537 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3538
5df8f01b
PE
3539 * buffer.c (fix_overlays_before): Mark locals as initialized.
3540 (fix_start_end_in_overlays): Likewise. This function should be
3541 simplified by using pointers-to-pointers, but that's a different
3542 matter.
b1d876f1 3543 (switch_to_buffer_1): Now static.
8f54f30a
PE
3544 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3545 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3546
a70072c9 3547 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3548 Fix pointer signedness issue.
edced198
PE
3549 (sys_subshell): Mark local as volatile if checking for lint,
3550 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3551 (MAXPATHLEN): Define only if needed.
a70072c9 3552
a0977c44
PE
3553 * process.c (serial_open, serial_configure): Move decls from here ...
3554 * systty.h: ... to here, so that they can be checked.
3555
a884fdcc
PE
3556 * fns.c (get_random, seed_random): Move extern decls from here ...
3557 * lisp.h: ... to here, so that they can be checked.
3558
604efe86 3559 * sysdep.c (reset_io): Now static.
b8950c94 3560 (wait_for_termination_signal): Remove; unused.
604efe86 3561
38fc62d9
PE
3562 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3563 (copy_keymap_item, append_key, push_text_char_description):
3564 Now static.
1004a21a 3565 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3566 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3567 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3568 (describe_map_tree):
3569 Rename locals to avoid shadowing.
38fc62d9 3570
2f2650da
PE
3571 * keyboard.c: Declare functions static if they are not used elsewhere.
3572 (echo_char, echo_dash, cmd_error, top_level_2):
3573 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3574 (read_char, kbd_buffer_get_event, make_lispy_position):
3575 (make_lispy_event, make_lispy_movement, apply_modifiers):
3576 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3577 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3578 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3579 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3580 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3581
a053e86c 3582 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3583 (mark_kboards): Move decl here ...
3584 * alloc.c (mark_kboards): ... from here.
a053e86c 3585
4752793e
PE
3586 * lisp.h (force_auto_save_soon): New decl.
3587
74f10ca7 3588 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3589 (DEFINE_DUMMY_FUNCTION): New macro.
3590 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3591 Use it.
c03cd23f
PE
3592 (main): Add casts to avoid warnings
3593 if GCC considers string literals to be constants.
74f10ca7 3594
022e70d4
PE
3595 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3596
59d6fe83
PE
3597 * dbusbind.c: Pointer signedness fixes.
3598 (xd_signature, xd_append_arg, xd_initialize):
3599 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3600 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3601 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3602 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3603
78320123
PE
3604 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3605 if GCC considers string literals to be constants.
49cebcca 3606 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3607
35ac2a97
SM
36082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3609
fb103ca9
SM
3610 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3611 (print_preprocess, print_object): New macro to fix last change.
3612
35ac2a97
SM
3613 * print.c (print_preprocess): Don't forget font objects.
3614
62973b41
JB
36152011-03-16 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * emacs.c (USAGE3): Doc fixes.
3618
0e48bb22
AS
36192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3620
3621 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3622 structure.
3623
7684e57b
JB
36242011-03-14 Juanma Barranquero <lekktu@gmail.com>
3625
3626 * lisp.h (VWindow_system, Qfile_name_history):
3627 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3628 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3629 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3630
3631 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3632 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3633
3634 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3635 * w32console.c (detect_input_pending, read_input_pending)
3636 (encode_terminal_code):
3637 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3638 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3639 (w32_system_caret_y, Qfile_name_history):
3640 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3641 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3642 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3643 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3644 * w32proc.c (Qlocal, report_file_error):
3645 * w32term.c (Vwindow_system, updating_frame):
3646 * w32uniscribe.c (initialized, uniscribe_font_driver):
3647 Remove unneeded extern declarations.
3648
2aa46d6c
CY
36492011-03-14 Chong Yidong <cyd@stupidchicken.com>
3650
c96bbc66 3651 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3652
cffc6f3b
CY
36532011-03-13 Chong Yidong <cyd@stupidchicken.com>
3654
3655 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3656 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3657 These macros can no longer be used for assignment.
3658
44f230aa
SM
3659 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3660 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3661 (record_buffer_markers, fetch_buffer_markers): New functions for
3662 recording and fetching special buffer markers.
3663 (set_buffer_internal_1, set_buffer_temp): Use them.
3664
3665 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3666
3667 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3668
3669 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3670 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3671
3672 * xdisp.c (hscroll_window_tree):
3673 (reconsider_clip_changes): Use PT instead of BUF_PT.
3674
d251f04b
EZ
36752011-03-13 Eli Zaretskii <eliz@gnu.org>
3676
3677 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3678 $(EMACS_ROOT)/lib/intprops.h.
3679
f0c77cd1
PE
36802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3681
3eca4629
PE
3682 Fix more problems found by GCC 4.5.2's static checks.
3683
7c86ee98
PE
3684 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3685 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3686 (xg_free_frame_widgets): Make it clear that a local variable is
3687 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3688 (gdk_window_get_screen): Make it clear that this macro is needed
3689 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3690 (int_gtk_range_get_value): New function, which avoids a diagnostic
3691 from gcc -Wbad-function-cast.
3692 (xg_set_toolkit_scroll_bar_thumb): Use it.
3693 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3694 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3695 (get_utf8_string, xg_get_file_with_chooser):
3696 Rename locals to avoid shadowing.
3697 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3698
41729b81
PE
3699 * xgselect.c (xg_select): Remove unused var.
3700
f0c77cd1
PE
3701 * image.c (four_corners_best): Mark locals as initialized.
3702 (gif_load): Initialize transparent_p to zero (Bug#8238).
3703 Mark another local as initialized.
ec6cf4c6 3704 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3705
ce0ad53d 3706 * image.c (clear_image_cache): Now static.
d5d5a617 3707 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3708 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3709 (x_edge_detection): Remove unnecessary cast that
3710 gcc -Wbad-function-cast diagnoses.
2037898d 3711 (gif_load): Fix pointer signedness.
6ae141d6
PE
3712 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3713 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3714
33383987 37152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3716
d32df629
PE
3717 Improve quality of tests for time stamp overflow.
3718 For example, without this patch (encode-time 0 0 0 1 1
3719 1152921504606846976) returns the obviously-bogus value (-948597
3720 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3721 reports time overflow. See
3722 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3723 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3724 * editfns.c: Include limits.h and intprops.h.
3725 (TIME_T_MIN, TIME_T_MAX): New macros.
3726 (time_overflow): Move earlier, to before first use.
3727 (hi_time, lo_time): New functions, for an accurate test for
3728 out-of-range times.
3729 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3730 (Fget_internal_run_time): Don't assume time_t fits in int.
3731 (make_time): Use list2 instead of Fcons twice.
3732 (Fdecode_time): More accurate test for out-of-range times.
3733 (check_tm_member): New function.
3734 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3735 (lisp_time_argument): Don't rely on undefined left-shift and
3736 right-shift behavior when checking for time stamp overflow.
8be6f318 3737
fe31d94c
PE
3738 * editfns.c (time_overflow): New function, refactoring common code.
3739 (Fformat_time_string, Fdecode_time, Fencode_time):
3740 (Fcurrent_time_string): Use it.
3741
8be6f318
PE
3742 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3743 * dired.c (make_time): Move to ...
3744 * editfns.c (make_time): ... here.
3745 * systime.h: Note the move.
3746
09d9db2c 37472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3748
126bc0dc
YM
3749 * fringe.c (update_window_fringes): Remove unused variables.
3750
c47cbdfd
YM
3751 * unexmacosx.c (copy_data_segment): Also copy __got section.
3752 (Bug#8223)
3753
7ac80be9
EZ
37542011-03-12 Eli Zaretskii <eliz@gnu.org>
3755
c96bbc66 3756 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3757 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3758 Constify `char *' arguments and their references according to
3759 prototypes in tparam.h.
3760
ecb0f94d 3761 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3762
7ac80be9
EZ
3763 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3764 Adapt all references accordingly.
3765
3766 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3767
ef1fd07e
TT
37682011-03-11 Tom Tromey <tromey@redhat.com>
3769
3770 * buffer.c (syms_of_buffer): Remove obsolete comment.
3771
7ef4b50c
EZ
37722011-03-11 Eli Zaretskii <eliz@gnu.org>
3773
3774 * termhooks.h (encode_terminal_code): Declare prototype.
3775
3776 * msdos.c (encode_terminal_code): Don't declare prototype.
3777
3778 * term.c (encode_terminal_code): Now external again, used by
3779 w32console.c and msdos.c.
3780
44f230aa
SM
3781 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3782 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3783
4b1ec863 37842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3785
1714f52b 3786 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3787
4b1ec863
PE
3788 * fringe.c (update_window_fringes): Mark locals as initialized
3789 (Bug#8227).
3790 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3791
524c7aa6
PE
3792 * alloc.c (mark_fringe_data): Move decl from here ...
3793 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3794 to check its interface.
3795 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3796
a5c0af81 3797 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3798 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3799 (fontset_font): Mark local as initialized.
a9a06e0b 3800 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3801
b4716021
PE
3802 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3803
811e9bac 3804 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3805 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3806 (x_own_selection, Fx_disown_selection_internal): Rename locals
3807 to avoid shadowing.
3808 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3809
7e3ab302
PE
3810 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3811 so that the caller can use some name other than gcpro1.
3812 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3813 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3814 (Fx_backspace_delete_keys_p):
3815 Use them to avoid shadowing, and rename vars to avoid shadowing.
3816 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3817 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3818 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3819 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3820 Remove unused locals.
7e3ab302
PE
3821 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3822 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3823 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3824 macros.
f78faa98 3825
e2b13473
PE
3826 * xterm.h (x_mouse_leave): New decl.
3827
77f23912
PE
3828 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3829 Remove unused functions.
cdf4ba58
PE
3830 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3831 (x_calc_absolute_position): Now static.
7411c686 3832 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3833 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3834 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3835 unless they are used.
38d0b34a
PE
3836 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3837 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3838 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3839 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3840 (x_error_catcher, x_connection_closed, x_error_handler):
3841 (x_error_quitter, xembed_send_message, x_iconify_frame):
3842 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3843 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3844 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3845
44f230aa
SM
3846 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3847 Rename or move locals to avoid shadowing.
6b463e58 3848 (tty_defined_color, merge_face_heights): Now static.
5967d051 3849 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3850 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3851 does not deduce is never used uninitialized.
73719eba
PE
3852 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3853 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3854
426994c3 3855 * terminal.c (store_terminal_param): Now static.
5489860b 3856
032f1620 3857 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3858 (set_frame_menubar): Remove unused local.
d4323972 3859 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3860 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3861 since they might point to immutable storage.
281585b0
PE
3862 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3863 since it's unused otherwise.
032f1620 3864
367c19e5 3865 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3866 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3867 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3868 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3869 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3870 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3871 does not deduce are never used uninitialized.
70739cbe 3872
07b48fa9
PE
3873 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3874
8868a238 3875 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3876 * window.c (window_loop, size_window):
3877 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3878
7e5cf297 3879 * window.c (display_buffer): Now static.
d6550a9f
PE
3880 (size_window): Mark variables that gcc -Wuninitialized
3881 does not deduce are never used uninitialized.
a586633d
PE
3882 * window.h (check_all_windows): New decl, to forestall
3883 gcc -Wmissing-prototypes diagnostic.
5b555da1 3884 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3885
f6095868
PE
3886 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3887 shadowing.
3888 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3889 Include <limits.h>.
3890 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3891 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3892 (load_charset_map): Mark variables that gcc -Wuninitialized
3893 does not deduce are never used uninitialized.
53df7c11 3894 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3895
f38b440c
PE
3896 * coding.c (coding_set_source, coding_set_destination):
3897 Use "else { /* comment */ }" rather than "else /* comment */;"
3898 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3899 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3900 a block, when the outer 'i' will do.
3901 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3902 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3903 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3904 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3905 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3906 Rename locals to avoid shadowing.
3907 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3908 * coding.c (emacs_mule_char, encode_invocation_designation):
3909 Now static, since they're not used elsewhere.
413bb2db 3910 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3911 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3912 (decode_coding_emacs_mule): Mark variables that gcc
3913 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3914 (detect_coding_iso_2022): Initialize a local variable that might
3915 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3916 this initialization is needed. (Bug#8211)
5f58e762
PE
3917 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3918 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3919 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3920 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3921 Remove unused macros.
f38b440c 3922
232b38b9 3923 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3924 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3925 * character.c (string_count_byte8): Likewise.
232b38b9 3926
fb90da1b
PE
3927 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3928 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3929
fb93dbc2
PE
3930 * chartab.c (copy_sub_char_table): Now static, since it's not used
3931 elsewhere.
5c156ace
PE
3932 (sub_char_table_ref_and_range, char_table_ref_and_range):
3933 Rename locals to avoid shadowing.
bbcd0949 3934 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3935
7d3b3862 3936 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3937 (BIDI_BOB): Remove unused macro.
7d3b3862 3938
6be7d3da
PE
3939 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3940 deduce are never used uninitialized.
c2ed9c8b 3941 * term.c (encode_terminal_code): Likewise.
6be7d3da 3942
75f8807f 3943 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3944
50938595
PE
3945 * tparam.h: New file.
3946 * term.c, tparam.h: Include it.
3947 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3948 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3949 Move these decls to tparam.h, and make them agree with what
3950 is actually in tparam.c. The previous trick of using incompatible
3951 decls in different modules does not conform to the C standard.
3952 All callers of tparam changed to use tparam's actual API.
3953 * tparam.c (tparam1, tparam, tgoto):
3954 Use const pointers where appropriate.
3955
fbceeba2
PE
3956 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3957 * cm.h (struct cm): Likewise.
3958 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3959 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3960 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3961 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3962 (turn_on_face, init_tty): Likewise.
3963 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3964
7f3f1250
PE
3965 * term.c (term_mouse_position): Rename local to avoid shadowing.
3966
e6ca6543
PE
3967 * alloc.c (mark_ttys): Move decl from here ...
3968 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3969
c40f8d15
AS
39702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3971
3972 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3973
cfe0661d
JB
39742011-03-09 Juanma Barranquero <lekktu@gmail.com>
3975
3976 * search.c (compile_pattern_1): Remove argument regp, unused since
3977 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3978 (compile_pattern): Don't pass it.
3979
0afb4571
J
39802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3981
3982 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3983 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3984 for ! HAVE_GTK3.
3985 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3986
3987 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3988
3989 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3990 gdk_window_get_screen, gdk_window_get_geometry,
3991 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3992 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3993 (xg_get_pixbuf_from_pixmap): New function.
3994 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3995 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3996 Call xg_get_pixbuf_from_pixmap instead of
3997 gdk_pixbuf_get_from_drawable.
3998 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3999 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4000 (xg_check_special_colors): Use GtkStyleContext and its functions
4001 for HAVE_GTK3.
4002 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4003 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4004 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4005 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4006 Call gtk_widget_get_preferred_size.
0afb4571
J
4007 (xg_frame_resized): gdk_window_get_geometry only takes 5
4008 parameters.
44f230aa
SM
4009 (xg_win_to_widget, xg_event_is_for_menubar):
4010 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4011 (xg_set_widget_bg): New function.
4012 (delete_cb): New function.
895009e1 4013 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4014 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4015 (xg_set_background_color): Call xg_set_widget_bg.
4016 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4017 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4018 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4019 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4020 if ! HAVE_GTK3.
4021 (update_frame_tool_bar): Call gtk_widget_hide.
4022 (xg_initialize): Use GDK_KEY_g.
4023
4024 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4025 if ! HAVE_GTK3
4026 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4027
4028 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4029 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4030 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4031
1c2cc4ef
JB
40322011-03-08 Juanma Barranquero <lekktu@gmail.com>
4033
4034 * w32xfns.c (select_palette): Check success of RealizePalette against
4035 GDI_ERROR, not zero.
4036
33383987 4037See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4038
4039;; Local Variables:
4040;; coding: utf-8
aac0c6e3
MR
4041;; End:
4042
33383987 4043 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4044
4045 This file is part of GNU Emacs.
4046
4047 GNU Emacs is free software: you can redistribute it and/or modify
4048 it under the terms of the GNU General Public License as published by
4049 the Free Software Foundation, either version 3 of the License, or
4050 (at your option) any later version.
4051
4052 GNU Emacs is distributed in the hope that it will be useful,
4053 but WITHOUT ANY WARRANTY; without even the implied warranty of
4054 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4055 GNU General Public License for more details.
4056
4057 You should have received a copy of the GNU General Public License
4058 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.