Better fix that keeps corret margins in tooltip.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
1b854618
JD
12011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2
3 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5 wrong (Bug#8591).
6
3fe4b549
JD
72011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8
0ce7e563
JD
9 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
11 (xg_hide_tooltip): Fix comment.
12
3fe4b549
JD
13 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
14 in registerServicesMenuSendTypes.
15 (validRequestorForSendType): Don't check ns_return_types.
16
17 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
18 ns_return_type.
19
5df75e47
JR
202011-07-08 Jason Rumney <jasonr@gnu.org>
21
22 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
23 frame struct members of non-existent frames (Bug#6284).
24
699c10bd
JD
252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
26
4393663b
JD
27 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
28 variable firstTime not needed on OSX >= 10.6.
29 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
30 >= 10.5. Use setKnobProportion, setDoubleValue.
31
32 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
33 (MAC_OS_X_VERSION_10_5): Define if not defined.
34 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
35 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
36 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
37
38 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
39 cString and lossyCString on OSX >= 10.4
40
41 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
42 sizeToFit on OSX >= 10.2.
43
44 * nsimage.m (allocInitFromFile): Don't use deprecated method
45 bestRepresentationForDevice on OSX >= 10.6.
46
47 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
48 to avoid warning.
49
50 * emacs.c: Declare unexec_init_emacs_zone.
51
a63e0781
JD
52 * nsgui.h: Fix compiler warning about gnulib redefining verify.
53
699c10bd
JD
54 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
55
56 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
57 on svcsMenu (Bug#8842).
58
59 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
60 ns_return_types.
61 (Fns_list_services): Just return Qnil on 10.6, code not working there.
62
63 * nsterm.m (QUTF8_STRING): Declare.
64 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
65 (validRequestorForSendType): Return type is (id).
66 Change indexOfObjectIdenticalTo to indexOfObject.
67 Check if we have local selection before returning self (Bug#8842).
68 (writeSelectionToPasteboard): Put local selection into paste board
69 if we have a local selection (Bug#8842).
70 (syms_of_nsterm): DEFSYM QUTF8_STRING.
71
72 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
73 (ns_get_local_selection): Declare.
74
54e10184
LMI
752011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
76
9888ff71
LMI
77 * keymap.c (describe_map_tree): Don't insert a double newline at
78 the end of the buffer (bug#1169) and return whether we inserted
79 something.
80
54e10184
LMI
81 * callint.c (Fcall_interactively): Change "reading args" to
82 "providing args" to try to clarify what it does (bug#1010).
83
15fa4783
KH
842011-07-07 Kenichi Handa <handa@m17n.org>
85
86 * composite.c (composition_compute_stop_pos): Ignore a static
87 composition starting before CHARPOS (Bug#8915).
88
89 * xdisp.c (handle_composition_prop): Likewise.
90
a8815b00
EZ
912011-07-07 Eli Zaretskii <eliz@gnu.org>
92
93 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
94 (Bug#9015)
95
ef7b981d 962011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
97
98 * character.h (unicode_category_t): New enum type.
99
100 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
101 (Qchar_code_property_table): New variable.
102 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
103 (UNIPROP_COMPRESSED_FORM_P): New macros.
104 (char_table_ascii): Uncompress the compressed values.
105 (sub_char_table_ref): New arg is_uniprop. Callers changed.
106 Uncompress the compressed values.
107 (sub_char_table_ref_and_range): Likewise.
108 (char_table_ref_and_range): Uncompress the compressed values.
109 (sub_char_table_set): New arg is_uniprop. Callers changed.
110 Uncompress the compressed values.
111 (sub_char_table_set_range): Args changed. Callers changed.
112 (char_table_set_range): Adjuted for the above change.
113 (map_sub_char_table): Delete args default_val and parent. Add arg
114 top. Give decoded values to a Lisp function.
115 (map_char_table): Adjusted for the above change. Give decoded
116 values to a Lisp function. Gcpro more variables.
117 (uniprop_table_uncompress)
118 (uniprop_decode_value_run_length): New functions.
119 (uniprop_decoder, uniprop_decoder_count): New variables.
120 (uniprop_get_decoder, uniprop_encode_value_character)
121 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
122 New functions.
123 (uniprop_encoder, uniprop_encoder_count): New variables.
124 (uniprop_get_encoder, uniprop_table)
125 (Funicode_property_table_internal, Fget_unicode_property_internal)
126 (Fput_unicode_property_internal): New functions.
127 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
128 Sunicode_property_table_internal, Sget_unicode_property_internal,
129 and Sput_unicode_property_internal. Defvar_lisp
130 char-code-property-alist.
131
132 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
133 Vunicode_category_table.
134
135 * font.c (font_range): Adjusted for the change of
136 Vunicode_category_table.
137
76b397fb
DN
1382011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
139
140 * m/iris4d.h: Remove file, move contents ...
141 * s/irix6-5.h: ... here.
142
22b4128e
PE
1432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
144
145 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
146 * alloc.c (mark_buffer):
147 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
148 (clone_per_buffer_values): Don't assume that
22b4128e
PE
149 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
150 This isn't true in general, and it's particularly not true
151 if Emacs is configured with --with-wide-int.
152 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
153 New macros, used in the buffer.c change.
154
869795d6
JD
1552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
156
157 * xsettings.c: Use both GConf and GSettings if both are available.
158 (store_config_changed_event): Add comment.
159 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
160 (store_tool_bar_style_changed): New functions.
161 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
162 (struct xsettings): Move font inside HAVE_XFT.
163 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
164 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
165 Move inside HAVE_XFT.
166 (something_changed_gsettingsCB): Renamed from something_changedCB.
167 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
168 also.
169 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
170 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
171 (something_changed_gconfCB): Renamed from something_changedCB.
172 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
173 (parse_settings): Move check for font inside HAVE_XFT.
174 (read_settings, apply_xft_settings): Add comment.
175 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
176 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
177 call store_font_name_changed.
178 (xft_settings_event): Add comment.
179 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
180 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
181 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
182 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
183 (xsettings_initialize): Call init_gsettings last.
184 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
185 comment.
186
d8ed26bd
PE
1872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
188
189 Random fixes. E.g., (random) never returned negative values.
190 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
191 subseconds part to the entropy, as that's a bit more random.
192 Prefer signed to unsigned, since the signedness doesn't matter and
193 in general we prefer signed. When given a limit, use a
194 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
195 latter isn't right if USE_2_TAGS_FOR_INTS.
196 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
197 not 0..VALMASK. Don't discard "excess" bits that random () returns.
198
cabf1cac
SM
1992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
200
201 * textprop.c (text_property_stickiness):
202 Obey Vtext_property_default_nonsticky.
203 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
204 * w32fns.c (syms_of_w32fns):
205 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
206
6e9b2be9
PE
2072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
208
209 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
210 This is more efficient than Ffile_directory_p and avoids a minor race.
211
90186c68
LMI
2122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
213
7c301272
LMI
214 * buffer.c (Foverlay_put): Say what the return value is
215 (bug#7835).
216
c4f2d8d4
LMI
217 * fileio.c (barf_or_query_if_file_exists): Check first if the file
218 is a directory before asking whether to use the file name
219 (bug#7564).
ad637907
LMI
220 (barf_or_query_if_file_exists): Make the "File is a directory"
221 error be more correct.
c4f2d8d4 222
90186c68
LMI
223 * fns.c (Frequire): Remove the mention of the .gz files, since
224 that's installation-specific, but keep the mention of
225 `get-load-suffixes'.
226
da64016e
PE
2272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
228
229 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
230 Report string overflow if the output is too long.
231
7d47b580
JB
2322011-07-04 Juanma Barranquero <lekktu@gmail.com>
233
a555cb87
JB
234 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
235 (syms_of_gnutls): Remove duplicate DEFSYM for
236 Qgnutls_bootprop_verify_hostname_error, an error for
237 Qgnutls_bootprop_verify_error (which is no longer used).
238
7d47b580
JB
239 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
240 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
241 Also (re)move comments that are misplaced or no longer relevant.
242
1e49bfab
LMI
2432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
244
245 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
246
1485f4c0
CY
2472011-07-03 Chong Yidong <cyd@stupidchicken.com>
248
249 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
250 and background color parameters if they have been changed.
251
a9ab721e
LMI
2522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
253
254 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
255
cf7cff57
PE
2562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
257
2e13213d
PE
258 * xsettings.c (SYSTEM_FONT): Define only when used.
259 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
260
cf7cff57
PE
261 * keymap.c (access_keymap_1): Now static.
262
7a8e04f7
CY
2632011-07-02 Chong Yidong <cyd@stupidchicken.com>
264
265 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
266 leave any prefix arg for the up event (Bug#1586).
267
61352f62
LMI
2682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
269
69bb1ef7
LMI
270 * lread.c (syms_of_lread): Mention single symbols defined by
271 `defvar' or `defconst' (bug#7154).
272
61352f62 273 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 274 (Frequire): Mention get-load-suffixes.
61352f62 275
28545e04
MR
2762011-07-02 Martin Rudalics <rudalics@gmx.at>
277
278 * window.h (window): Remove clone_number slot.
279 * window.c (Fwindow_clone_number, Fset_window_clone_number):
280 Remove.
281 (make_parent_window, make_window, saved_window)
282 (Fset_window_configuration, save_window_save): Don't deal with
283 clone numbers.
284 * buffer.c (Qclone_number): Remove declaration.
285 (sort_overlays, overlay_strings): Don't deal with clone numbers.
286
3349e122
SM
2872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
288
289 Add multiple inheritance to keymaps.
290 * keymap.c (Fmake_composed_keymap): New function.
291 (Fset_keymap_parent): Simplify.
292 (fix_submap_inheritance): Remove.
293 (access_keymap_1): New function extracted from access_keymap to handle
294 embedded parents and handle lists of maps.
295 (access_keymap): Use it.
296 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
297 (Fcopy_keymap): Handle embedded parents.
298 (Fcommand_remapping, define_as_prefix): Simplify.
299 (Fkey_binding): Simplify.
300 (syms_of_keymap): Move minibuffer-local-completion-map,
301 minibuffer-local-filename-completion-map,
302 minibuffer-local-must-match-map, and
303 minibuffer-local-filename-must-match-map to Elisp.
304 (syms_of_keymap): Defsubr make-composed-keymap.
305 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
306 (parse_menu_item): Trivial simplification.
307
3279eb87
GM
3082011-07-01 Glenn Morris <rgm@gnu.org>
309
310 * Makefile.in (SETTINGS_LIBS): Fix typo.
311
4550efdf
KI
3122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
313
314 * coding.c (Fencode_coding_string): Record the last coding system
315 used, as the function doc string says (bug#8738).
316
0949d2b6
JD
3172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
318
319 * xsettings.c (store_monospaced_changed): Take new font as arg and
320 check for change against current_mono_font.
321 (EMACS_TYPE_SETTINGS): Remove this and related defines.
322 (emacs_settings_constructor, emacs_settings_get_property)
323 (emacs_settings_set_property, emacs_settings_class_init)
324 (emacs_settings_init, gsettings_obj): Remove.
325 (something_changedCB): New function for HAVE_GSETTINGS.
326 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
327 with value as argument.
328 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
329 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 330 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
331 "changed".
332
333 * xgselect.c: Add defined (HAVE_GSETTINGS).
334 (xgselect_initialize): Ditto.
335
336 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
337 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
338 xg_select.
339
bbc6b304
PE
3402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
341
342 * eval.c (struct backtrace): Simplify and port the data structure.
343 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
344 signed bit field, as this assumption is not portable and it makes
345 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
346 "char debug_on_exit : 1" as this is not portable either; instead,
347 use the portable "unsigned int debug_on_exit : 1". Remove unused
348 member evalargs. Remove obsolete comments about cc bombing out.
349
9851bfc5
JD
3502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
351
51bb811f 352 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
353 Let HAVE_GSETTINGS override HAVE_GCONF.
354 (store_monospaced_changed): New function.
355 (EMACS_SETTINGS): A new type derived from GObject to handle
356 GSettings notifications.
357 (emacs_settings_constructor, emacs_settings_get_property)
358 (emacs_settings_set_property, emacs_settings_class_init):
359 New functions.
360 (gsettings_client, gsettings_obj): New variables.
361 (GSETTINGS_SCHEMA): New define.
362 (something_changedCB): Call store_monospaced_changed.
363 (init_gsettings): New function.
364 (xsettings_initialize): Call init_gsettings.
365 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
366 to NULL.
367
368 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
369 GCONF_CFLAGS/LIBS.
370
5386012d
MR
3712011-06-29 Martin Rudalics <rudalics@gmx.at>
372
373 * window.c (resize_root_window, grow_mini_window)
374 (shrink_mini_window): Rename Qresize_root_window to
375 Qwindow_resize_root_window and Qresize_root_window_vertically to
376 Qwindow_resize_root_window_vertically.
377
f13e0b08
PE
3782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
379
380 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
381
94515237
JB
3822011-06-27 Juanma Barranquero <lekktu@gmail.com>
383
384 * makefile.w32-in: Redesign dependencies so they reflect more
385 clearly which files are directly included by each source file,
386 and not through other includes.
387
e43b6e43
MR
3882011-06-27 Martin Rudalics <rudalics@gmx.at>
389
390 * buffer.c (Qclone_number): Declare static and DEFSYM it.
391 (sort_overlays, overlay_strings): When an overlay's clone number
392 matches the window's clone number process the overlay even if
393 the overlay's window property doesn't match the current window.
394
d68443dc
MR
395 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
396 (Fwindow_hchild): Rename to Fwindow_left_child.
397 (Fwindow_next): Rename to Fwindow_next_sibling.
398 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
399 (resize_window_check): Rename to window_resize_check.
400 (resize_window_apply): Rename to window_resize_apply.
401 (Fresize_window_apply): Rename to Fwindow_resize_apply.
402 (Fdelete_other_windows_internal, resize_frame_windows)
403 (Fsplit_window_internal, Fdelete_window_internal)
404 (grow_mini_window, shrink_mini_window)
405 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 406
c7e73be5
JD
4072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
408
409 * emacsgtkfixed.h: State that this is only used with Gtk+3.
410 (emacs_fixed_set_min_size): Remove.
411 (emacs_fixed_new): Take frame as argument.
412
413 * emacsgtkfixed.c: State that this is only used with Gtk+3.
414 (_EmacsFixedPrivate): Remove minwidth/height.
415 Add struct frame *f.
416 (emacs_fixed_init): Initialize priv->f.
417 (get_parent_class, emacs_fixed_set_min_size): Remove.
418 (emacs_fixed_new): Set priv->f to argument.
419 (emacs_fixed_get_preferred_width)
420 (emacs_fixed_get_preferred_height): Use min_width/height from
421 frames size_hint to set minimum and natural (Bug#8919).
422 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
423 and use min_width/height from frames size_hint to set
424 min_width/height (Bug#8919).
425
426 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
427 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
428 Fix indentation.
c7e73be5 429
cf99dcf8
EZ
4302011-06-26 Eli Zaretskii <eliz@gnu.org>
431
432 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
433 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
434 called at ZV.
435
029529ac
CY
4362011-06-26 Chong Yidong <cyd@stupidchicken.com>
437
438 * process.c (wait_reading_process_output): Bypass select if
439 waiting for a cell while ignoring keyboard input, and input is
440 pending. Suggested by Jan Djärv (Bug#8869).
441
7a7ef429
PE
4422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
443
444 Use gnulib's dup2 module instead of rolling our own.
445 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
446
11fdef7d 4472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
448
449 * dispnew.c (scrolling_window): Before scrolling, turn off a
450 mouse-highlight in the window being scrolled.
451
cd3520a4
JB
4522011-06-24 Juanma Barranquero <lekktu@gmail.com>
453
454 Move DEFSYM to lisp.h and use everywhere.
455
456 * character.h (DEFSYM): Move declaration...
457 * lisp.h (DEFSYM): ...here.
458
459 * gnutls.c:
460 * minibuf.c:
461 * w32menu.c:
462 * w32proc.c:
463 * w32select.c: Don't include character.h.
464
465 * alloc.c (syms_of_alloc):
466 * buffer.c (syms_of_buffer):
467 * bytecode.c (syms_of_bytecode):
468 * callint.c (syms_of_callint):
469 * casefiddle.c (syms_of_casefiddle):
470 * casetab.c (init_casetab_once):
471 * category.c (init_category_once, syms_of_category):
472 * ccl.c (syms_of_ccl):
473 * cmds.c (syms_of_cmds):
474 * composite.c (syms_of_composite):
475 * dbusbind.c (syms_of_dbusbind):
476 * dired.c (syms_of_dired):
477 * dispnew.c (syms_of_display):
478 * doc.c (syms_of_doc):
479 * editfns.c (syms_of_editfns):
480 * emacs.c (syms_of_emacs):
481 * eval.c (syms_of_eval):
482 * fileio.c (syms_of_fileio):
483 * fns.c (syms_of_fns):
484 * frame.c (syms_of_frame):
485 * fringe.c (syms_of_fringe):
486 * insdel.c (syms_of_insdel):
487 * keymap.c (syms_of_keymap):
488 * lread.c (init_obarray, syms_of_lread):
489 * macros.c (syms_of_macros):
490 * msdos.c (syms_of_msdos):
491 * print.c (syms_of_print):
492 * process.c (syms_of_process):
493 * search.c (syms_of_search):
494 * sound.c (syms_of_sound):
495 * syntax.c (init_syntax_once, syms_of_syntax):
496 * terminal.c (syms_of_terminal):
497 * textprop.c (syms_of_textprop):
498 * undo.c (syms_of_undo):
499 * w32.c (globals_of_w32):
500 * window.c (syms_of_window):
501 * xdisp.c (syms_of_xdisp):
502 * xfaces.c (syms_of_xfaces):
503 * xfns.c (syms_of_xfns):
504 * xmenu.c (syms_of_xmenu):
505 * xsettings.c (syms_of_xsettings):
506 * xterm.c (syms_of_xterm): Use DEFSYM.
507
4228cf16
TZ
5082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
509
cd3520a4 510 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 511
7fcccf1e
PE
5122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
513
7efb4e0e
PE
514 Integer and buffer overflow fixes (Bug#8873).
515
ff5844ad
PE
516 * print.c (printchar, strout): Check for string overflow.
517 (PRINTPREPARE, printchar, strout):
518 Don't set size unless allocation succeeds.
519
90532f02
PE
520 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
521 for sizes. Check for string overflow more accurately.
522 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
523
6d84508d
PE
524 * macros.c: Integer and buffer overflow fixes.
525 * keyboard.h (struct keyboard.kbd_macro_bufsize):
526 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
527 Use ptrdiff_t, not int, for sizes.
528 Don't increment bufsize until after realloc succeeds.
529 Check for size-calculation overflow.
530 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
531
437b2cb4
PE
532 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
533
8b9ac8b4
PE
534 * lread.c: Integer overflow fixes.
535 (read_integer): Radix is now EMACS_INT, not int,
536 to improve quality of diagnostics for out-of-range radices.
537 Calculate buffer size correctly for out-of-range radices.
538 (read1): Check for integer overflow in radices, and in
539 read-circle numbers.
82cb60d3
PE
540 (read_escape): Avoid int overflow.
541 (Fload, openp, read_buffer_size, read1)
542 (substitute_object_recurse, read_vector, read_list, map_obarray):
543 Use ptrdiff_t, not int, for sizes.
544 (read1): Use EMACS_INT, not int, for sizes.
20270765 545 Check for size overflow.
8b9ac8b4 546
7fcccf1e
PE
547 * image.c (cache_image): Check for size arithmetic overflow.
548
bfbbd7e7
PE
549 * lread.c: Integer overflow issues.
550 (saved_doc_string_size, saved_doc_string_length)
551 (prev_saved_doc_string_size, prev_saved_doc_string_length):
552 Now ptrdiff_t, not int.
553 (read1): Don't assume doc string length fits in int. Check for
554 out-of-range doc string lengths.
555 (read_list): Don't assume file position fits in int.
39019e54 556 (read_escape): Check for hex character overflow.
bfbbd7e7 557
4e323265
LL
5582011-06-22 Leo Liu <sdl.web@gmail.com>
559
560 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
561 Move to minibuffer.el.
562
85fece3e
PE
5632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
564
20b84ce9 565 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
566 The following patches are for when GLYPH_DEBUG && !XASSERT.
567 * dispextern.h (trace_redisplay_p, dump_glyph_string):
568 * dispnew.c (flush_stdout):
569 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
570 Mark as externally visible.
571 * dispnew.c (check_window_matrix_pointers): Now static.
572 * dispnew.c (window_to_frame_vpos):
573 * xfns.c (unwind_create_frame):
574 * xterm.c (x_check_font): Remove unused local.
575 * scroll.c (CHECK_BOUNDS):
576 * xfaces.c (cache_fache): Rename local to avoid shadowing.
577 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
578 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
579 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
580 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
581 Now static.
582 (debug_method_add): Use va_list and vsprintf rather than relying
583 on undefined behavior with wrong number of arguments.
584 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
585 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
586 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
587 since we're not interested in debugging glyphs with old libraries.
588 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
589 GCC 4.6.0's static checking.
590
0766b489
PE
5912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
592
31fd4b32
PE
593 Integer overflow and signedness fixes (Bug#8873).
594 A few related buffer overrun fixes, too.
595
b79e8648
PE
596 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
597
0766b489
PE
598 * dispextern.h (struct face.stipple):
599 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
600 (x_bitmap_mask, x_allocate_bitmap_record)
601 (x_create_bitmap_from_data, x_create_bitmap_from_file)
602 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
603 (x_create_bitmap_from_xpm_data):
604 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
605 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
606 (.bitmaps_last):
607 * xfaces.c (load_pixmap):
608 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
609 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
610 (.bitmaps_last, struct x_output.icon_bitmap):
611 Use ptrdiff_t, not int, for bitmap indexes.
612 (x_allocate_bitmap_record): Check for size overflow.
613 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
614
b081724f
PE
615 Use ptrdiff_t, not int, for overlay counts.
616 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
617 * editfns.c (overlays_around, get_pos_property):
618 * textprop.c (get_char_property_and_overlay):
619 * xdisp.c (next_overlay_change, note_mouse_highlight):
620 * xfaces.c (face_at_buffer_position):
21514da7
PE
621 * buffer.c (OVERLAY_COUNT_MAX): New macro.
622 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
623 (Fnext_overlay_change, Fprevious_overlay_change)
624 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 625 Use ptrdiff_t, not int, for sizes.
21514da7 626 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 627
3de73e5e
PE
628 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
629
2606c57b
PE
630 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
631 (x_session_initialize): Do not assume string length fits in int.
632
aaafe47a
PE
633 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
634 This is unlikely, but can occur if DPI is outlandish.
635
2674ddc8 636 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
637 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
638
28154962
PE
639 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
640 * xrdb.c (magic_file_p, search_magic_path):
641 Omit last arg SUFFIX; it was always 0. All callers changed.
642 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
643
7de51af5
PE
644 * xfont.c (xfont_match): Avoid need for strlen.
645
25ed6cc3
PE
646 * xfns.c: Don't assume strlen fits in int.
647 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
648
4eab31dd
PE
649 * xdisp.c (message_log_check_duplicate): Return intmax_t,
650 not unsigned long, as we prefer signed integers. All callers changed.
651 Detect integer overflow in repeat count.
652 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 653 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 654
171e2a58
PE
655 * termcap.c: Don't assume sizes fit in int and never overflow.
656 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
657 (gobble_line): Check for size-calculation overflow.
658
ad39faca 659 * minibuf.c (Fread_buffer):
6e5bb2dc 660 * lread.c (intern, intern_c_string):
74ca2eb3
PE
661 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
662 Don't assume string length fits in int.
663
52c61c22 664 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
665 * gtkutil.c (style_changed_cb): Avoid need for strlen.
666
b5b8c9e5
PE
667 * font.c: Don't assume string length fits in int.
668 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
669 Use ptrdiff_t, not int.
ccd6111c
PE
670 (font_intern_prop): Don't assume string length fits in int.
671 Don't assume integer property fits in fixnum.
672 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 673
882f0d81 674 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 675 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
676 Reformulate so as not to need the command string.
677 Invoke gzip -cd rather than gunzip, as it's more portable.
678 (lock_info_type, lock_file_1, lock_file):
679 Don't assume pid_t and time_t fit in unsigned long.
680 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
681 (current_lock_owner): Prefer signed type for sizes.
682 Use memcpy, not strncpy, where memcpy is what is really wanted.
683 Don't assume (via atoi) that time_t and pid_t fit in int.
684 Check for time_t and/or pid_t out of range, e.g., via a network share.
685 Don't alloca where an auto var works fine.
686
93f4cf88
PE
687 * fileio.c: Fix some integer overflow issues.
688 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
689 Don't assume string length fits in int.
690 (directory_file_name): Don't assume string length fits in long.
691 (make_temp_name): Don't assume pid fits in int, or that its print
692 length is less than 20.
693
f3e92b69
PE
694 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
695
1bfdaf10
PE
696 * coding.c (make_subsidiaries): Don't assume string length fits in int.
697
35016e9a
PE
698 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
699
3d1e65a1
PE
700 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
701 We prefer signed integers, even for size calculations.
702
0b963a93
PE
703 * emacs.c: Don't assume string length fits in 'int'.
704 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
705 (main): Don't invoke strlen when not needed.
706
573f4b54
PE
707 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
708 (XD_DEBUG_MESSAGE): Don't waste a byte.
709
989f33ba
PE
710 * callproc.c (getenv_internal_1, getenv_internal)
711 (Fgetenv_internal):
965d34eb
PE
712 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
713
e4d29b33
PE
714 * lread.c (invalid_syntax): Omit length argument.
715 All uses changed. This doesn't fix a bug, but it simplifies the
716 code away from its former Hollerith-constant appearance, and it's
717 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 718 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 719
eb49b136
PE
720 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
721 This didn't break anything, but it didn't help either.
722 It's confusing to put a bogus integer in a place where the actual
723 value does not matter.
9f62aeb1 724 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 725 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 726
15375a22
PE
727 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
728 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
729 implementation.
b61cc01c
PE
730 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
731 We prefer signed types, and the value cannot exceed the EMACS_INT
732 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
733 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
734 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
735 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 736
53b2623d
PE
737 * indent.c (sane_tab_width): New function.
738 (current_column, scan_for_column, Findent_to, position_indentation)
739 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 740 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 741
51cab52b 742 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 743
f2ed8a70
PE
744 * lisp.h (lint_assume): New macro.
745 * composite.c (composition_gstring_put_cache):
746 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
747
abe80cc6
PE
748 * editfns.c, insdel.c:
749 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 750
b02c740e
PE
751 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
752
ebc96716
PE
753 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
754
b4e50fa0 755 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 756 Use much-faster test for byte-length change.
311d5d7c 757 Don't assume string byte-length fits in 'int'.
a4cf38e4 758 Check that character arg fits in 'int'.
85461888 759 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 760
c0c1ee9f
PE
761 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
762
a498d7f4
PE
763 * fns.c (concat): Catch string overflow earlier.
764 Do not rely on integer wraparound.
765
51cab52b
PE
766 * dispextern.h (struct it.overlay_strings_charpos)
767 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
768 * xdisp.c (forward_to_next_line_start)
769 (back_to_previous_visible_line_start)
770 (reseat_at_next_visible_line_start, next_element_from_buffer):
771 Don't arbitrarily truncate the value of 'selective' to int.
772
76031fad
PE
773 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
774
5eb55db9
PE
775 * composite.c: Don't truncate sizes to 'int'.
776 (composition_gstring_p, composition_reseat_it)
777 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
778 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
779 not EMACS_UINT, for indexes.
5eb55db9 780
0703a717
PE
781 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
782
d6202519
PE
783 * buffer.c: Include <verify.h>.
784 (struct sortvec.priority, struct sortstr.priority):
8961a454 785 Now EMACS_INT, not int.
c20998a7 786 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
787 (struct sortstr.size, record_overlay_string)
788 (struct sortstrlist.size, struct sortlist.used):
789 Don't truncate size to int.
790 (record_overlay_string): Check for size-calculation overflow.
d6202519 791 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 792
d5a19415
JM
7932011-06-22 Jim Meyering <meyering@redhat.com>
794
029529ac 795 Don't leak an XBM-image-sized buffer
d5a19415
JM
796 * image.c (xbm_load): Free the image buffer after using it.
797
a9041e6c
PE
7982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
799
800 Port to Sun C.
801 * composite.c (find_automatic_composition): Omit needless 'return 0;'
802 that Sun C diagnosed.
803 * fns.c (secure_hash): Fix pointer signedness issue.
804 * intervals.c (static_offset_intervals): New function.
805 (offset_intervals): Use it.
806
7f3f739f
LL
8072011-06-21 Leo Liu <sdl.web@gmail.com>
808
809 * deps.mk (fns.o):
810 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
811 sha512.h.
812
813 * fns.c (secure_hash): Rename from crypto_hash_function and change
814 the first arg to accept symbols.
5b66d427 815 (Fsecure_hash): New primitive.
7f3f739f
LL
816 (syms_of_fns): New symbols.
817
76147d94
DD
8182011-06-20 Deniz Dogan <deniz@dogan.se>
819
820 * process.c (Fset_process_buffer): Clarify return value in
821 docstring.
822
7d7d0045
CY
8232011-06-18 Chong Yidong <cyd@stupidchicken.com>
824
825 * dispnew.c (add_window_display_history): Use BVAR.
826
827 * xdisp.c (debug_method_add): Use BVAR.
828 (check_window_end, dump_glyph_matrix, dump_glyph)
829 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
830
831 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
832 Likewise.
833
834 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
835 check till after the cache is created in init_frame_faces.
836
ff2bc410
SM
8372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
838
839 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
840
28177add
PE
8412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
842
dd3482fe
PE
843 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
844 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
845 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
846
393d71f3 847 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
848 * fileio.c (Finsert_file_contents):
849 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
850 Remove the old (too-loose) buffer overflow checks.
851 They weren't needed, since make_gap checks for buffer overflow.
852 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
853 The old code merely checked for Emacs fixnum overflow, and relied
854 on undefined (wraparound) behavior. The new code avoids undefined
855 behavior, and also checks for ptrdiff_t and/or size_t overflow.
856
2e6813b0 857 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
858 Tune. Don't use wider integers than needed. Don't use alloca.
859 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 860
599a9e4f
PE
861 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
862
99561444
PE
863 * insdel.c, lisp.h (buffer_overflow): New function.
864 (insert_from_buffer_1, replace_range, replace_range_2):
865 * insdel.c (make_gap_larger):
866 * editfns.c (Finsert_char):
867 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
868
28177add
PE
869 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
870
e69dafad
PE
8712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
872
a7af7fde 873 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 874
b1c46f02
PE
875 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
876 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
877
e69dafad
PE
878 * fileio.c: Don't assume EMACS_INT fits in off_t.
879 (emacs_lseek): New static function.
880 (Finsert_file_contents, Fwrite_region): Use it.
881 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
882
566684ea
PE
883 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
884
e6966cd6
PE
885 * fns.c: Don't overflow int when computing a list length.
886 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
887 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
888 truncation on 64-bit hosts. Check for QUIT every
889 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
890 faster and is responsive enough.
891 (Flength): Report an error instead of overflowing an integer.
892 (Fsafe_length): Return a float if the value is not representable
893 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 894 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 895 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 896
dd0b0efb
PE
897 * alloc.c: Check that resized vectors' lengths fit in fixnums.
898 (header_size, word_size): New constants.
899 (allocate_vectorlike): Don't check size overflow here.
900 (allocate_vector): Check it here instead, since this is the only
901 caller of allocate_vectorlike that could cause overflow.
902 Check that the new vector's length is representable as a fixnum.
903
86fe5cfe
PE
904 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
905 The previous code was bogus. For example, next_almost_prime (32)
906 returned 39, which is undesirable as it is a multiple of 3; and
907 next_almost_prime (24) returned 25, which is a multiple of 5 so
908 why was the code bothering to check for multiples of 7?
909
80e88859
PE
910 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
911
4a2f0ad6
PE
912 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
913
f66c7cf8
PE
914 Variadic C functions now count arguments with ptrdiff_t.
915 This partly undoes my 2011-03-30 change, which replaced int with size_t.
916 Back then I didn't know that the Emacs coding style prefers signed int.
917 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
918 were being counted with int, which may truncate counts on 64-bit
919 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
920 * lisp.h (struct Lisp_Subr.function.aMANY)
921 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
922 Arg counts are now ptrdiff_t, not size_t.
923 All variadic functions and their callers changed accordingly.
924 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
925 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
926 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
927 * callint.c (Fcall_interactively): Check arg count for overflow,
928 to avoid potential buffer overrun. Use signed char, not 'int',
929 for 'varies' array, so that we needn't bother to check its size
930 calculation for overflow.
931 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
932 * eval.c (apply_lambda):
933 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
934 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
935 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
936
a1759b76
PE
937 * callint.c (Fcall_interactively): Don't use index var as event count.
938
d96be9fc
PE
939 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
940 * mem-limits.h (SIZE): Remove; no longer used.
941
a690a978 942 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 943
578c21e6
PE
944 Remove unnecessary casts.
945 * xterm.c (x_term_init):
946 * xfns.c (x_set_border_pixel):
947 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
948 These aren't needed now that we assume ANSI C.
949
96f53c6c
PE
950 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
951 It's more likely to cause problems (due to unsigned overflow)
952 than to cure them.
953
83c77d31
PE
954 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
955
ee2079f1
PE
956 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
957
6da65536
PE
958 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
959
7147c4a4
PE
960 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
961
193e32d9
PE
962 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
963
e5533da6
PE
964 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
965
9910e595
PE
966 GLYPH_CODE_FACE returns EMACS_INT, not int.
967 * dispextern.h (merge_faces):
968 * xfaces.c (merge_faces):
01103c44
PE
969 * xdisp.c (get_next_display_element, next_element_from_display_vector):
970 Don't assume EMACS_INT fits in int.
9910e595 971
2638320e
PE
972 * character.h (CHAR_VALID_P): Remove unused parameter.
973 * fontset.c, lisp.h, xdisp.c: All uses changed.
974
045eb8d9
PE
975 * editfns.c (Ftranslate_region_internal): Omit redundant test.
976
c1f134b5
PE
977 * fns.c (concat): Minor tuning based on overflow analysis.
978 This doesn't fix any bugs. Use int to hold character, instead
979 of constantly refetching from Emacs object. Use XFASTINT, not
980 XINT, for value known to be a character. Don't bother comparing
981 a single byte to 0400, as it's always less.
982
395fcb93 983 * floatfns.c (Fexpt):
327eeec8
PE
984 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
985
abbd3d23
PE
986 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
987 for characters.
988
684a03ef
PE
989 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
990
0fed43f3
PE
991 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
992 Without this fix, on a 64-bit host (aset S 0 4294967386) would
993 incorrectly succeed when S was a string, because 4294967386 was
994 truncated before it was used.
995
8fd02eb7
PE
996 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
997 Otherwise, an out-of-range integer could cause undefined behavior
998 on a 64-bit host.
999
f8c86b69
PE
1000 * composite.c: Use int, not EMACS_INT, for characters.
1001 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1002 EMACS_INT, for values that are known to be in character range.
1003 This doesn't fix any bugs but is the usual style inside Emacs and
1004 may generate better code on 32-bit machines.
1005
34206dd2
PE
1006 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1007 This is for reasons similar to the recent CHAR_STRING fix.
1008 * charset.c (Fencode_char): Check that character arg is actually
1009 a character. Pass an int to ENCODE_CHAR.
1010 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1011 wider than 'int', as a compile-time check to prevent future regressions
1012 in this area.
1013
c5958d4c 1014 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1015
1016 Make sure a 64-bit char is never passed to CHAR_STRING.
1017 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1018 by silently ignoring the top 32 bits, allowing some values
1019 that were far too large to be valid characters.
1020 * character.h: Include <verify.h>.
1021 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1022 arguments are no wider than unsigned, as a compile-time check
1023 to prevent future regressions in this area.
1024 * data.c (Faset):
01103c44 1025 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1026 (Fsubst_char_in_region):
1027 * fns.c (concat):
1028 * xdisp.c (decode_mode_spec_coding):
1029 Adjust to CHAR_STRING's new requirement.
1030 * editfns.c (Finsert_char, Fsubst_char_in_region):
1031 * fns.c (concat): Check that character args are actually
1032 characters. Without this test, these functions did the wrong
1033 thing with wildly out-of-range values on 64-bit hosts.
1034
d37ca623
PE
1035 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1036 These casts should not be needed on 32-bit hosts, either.
1037 * keyboard.c (read_char):
1038 * lread.c (Fload): Remove casts to unsigned.
1039
ea204efb
PE
1040 * lisp.h (UNSIGNED_CMP): New macro.
1041 This fixes comparison bugs on 64-bit hosts.
1042 (ASCII_CHAR_P): Use it.
1043 * casefiddle.c (casify_object):
01103c44 1044 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1045 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1046 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1047 * dispextern.h (FACE_FROM_ID):
1048 * keyboard.c (read_char): Use UNSIGNED_CMP.
1049
41cb286c
PE
1050 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1051 not to EMACS_INT, to avoid GCC warning.
1052
4a1b9832
PE
1053 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1054
55daad71
PE
1055 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1056 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1057 isn't needed on 32-bit machines.
8f95c75c 1058
01103c44
PE
1059 * buffer.c (Fgenerate_new_buffer_name):
1060 Use EMACS_INT for count, not int.
0ceccced 1061 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1062
1063 * data.c (Qcompiled_function): Now static.
1064
c6f072e7
PE
1065 * window.c (window_body_lines): Now static.
1066
20ce5912
PE
1067 * image.c (gif_load): Rename local to avoid shadowing.
1068
9c4c5f81
PE
1069 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1070 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1071 * alloc.c (make_save_value): Integer argument is now of type
1072 ptrdiff_t, not int.
1073 (mark_object): Use ptrdiff_t, not int.
1074 * lisp.h (pD): New macro.
1075 * print.c (print_object): Use it.
1076
c0c5c8ae
PE
1077 * alloc.c: Use EMACS_INT, not int, to count objects.
1078 (total_conses, total_markers, total_symbols, total_vector_size)
1079 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1080 (total_free_floats, total_floats, total_free_intervals)
1081 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1082 Now EMACS_INT, not int. All uses changed.
1083 (Fgarbage_collect): Compute overall total using a double, so that
1084 integer overflow is less likely to be a problem. Check for overflow
1085 when converting back to an integer.
5a25e253
PE
1086 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1087 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1088 These were 'int' variables that could overflow on 64-bit hosts;
1089 they were never used, so remove them instead of repairing them.
211a0b2a 1090 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1091 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1092 Previously, this ceilinged at INT_MAX, but that doesn't work on
1093 64-bit machines.
e46bb31a 1094 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1095
c78baabf 1096 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1097 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1098 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1099 when a (possibly-narrower) signed value would do just as well.
1100 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1101
c9d624c6
PE
1102 * alloc.c: Catch some string size overflows that we were missing.
1103 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1104 for convenience in STRING_BYTES_MAX.
1105 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1106 The definition here is exact; the one in lisp.h was approximate.
1107 (allocate_string_data): Check for string overflow. This catches
1108 some instances we weren't catching before. Also, it catches
1109 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1110 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1111 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1112
c9d624c6
PE
1113 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1114 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1115 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1116
353032ce
PE
1117 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1118
2bccce07
PE
1119 * alloc.c (Fmake_string): Check for out-of-range init.
1120
0ac30604
SM
11212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1122
1123 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1124
c195f2de
JD
11252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1126
1127 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1128 xg_get_default_scrollbar_width.
1129
1130 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1131 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1132 (style_changed_cb): Call update_theme_scrollbar_width and call
1133 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1134 all frames (Bug#8505).
1135 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1136 Call gtk_window_set_resizable if HAVE_GTK3.
1137 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1138 and height if HAVE_GTK3 (Bug#8505).
1139 (scroll_bar_width_for_theme): New variable.
1140 (update_theme_scrollbar_width): New function.
1141 (xg_get_default_scrollbar_width): Move code to
1142 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1143 (xg_initialize): Call update_theme_scrollbar_width.
1144
1145 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1146
1147 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1148
e10ac9f1
MR
11492011-06-12 Martin Rudalics <rudalics@gmx.at>
1150
1151 * frame.c (make_frame): Call other_buffer_safely instead of
1152 other_buffer.
1153
1154 * window.c (temp_output_buffer_show): Call display_buffer with
1155 second argument Vtemp_buffer_show_specifiers and reset latter
1156 immediately after the call.
1157 (Vtemp_buffer_show_specifiers): New variable.
1158 (auto_window_vscroll_p, next_screen_context_lines)
1159 (Vscroll_preserve_screen_position): Remove leading asterisks from
1160 doc-strings.
1161
2d3c217e 11622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1163
7b7f97e8 1164 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1165 * buffer.c (Qclone_number): Remove for now, as it's unused.
1166 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1167 (record_buffer): Remove unused local.
1168 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1169 (set_frame_buffer_list): Remove; unused.
1170 * frame.h (other_visible_frames): Remove decl.
1171 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1172 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1173 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1174 if HAVE_GPM.
1175 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1176 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1177 Define only if HAVE_GPM.
1178 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1179 (update_hints_inhibit): Remove; never set. All uses removed.
1180 * widgetprv.h (emacsFrameClassRec): Remove decl.
1181 * window.c (delete_deletable_window): Now returns void, since it
1182 wasn't returning anything.
1183 (compare_window_configurations): Remove unused locals.
1184 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1185 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1186 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1187 the same widths as pointers. This follows up on the 2011-05-06 patch.
1188 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1189 * xterm.h: Likewise.
1190 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1191
1384b89e
JB
11922011-06-12 Juanma Barranquero <lekktu@gmail.com>
1193
1194 * makefile.w32-in: Update dependencies.
1195 (LISP_H): Add lib/intprops.h.
1196
1100a63c
CY
11972011-06-11 Chong Yidong <cyd@stupidchicken.com>
1198
1199 * image.c (gif_load): Add animation frame delay to the metadata.
1200 (syms_of_image): Use DEFSYM. New symbol `delay'.
1201
6198ccd0
MR
12022011-06-11 Martin Rudalics <rudalics@gmx.at>
1203
1204 * window.c (delete_deletable_window): Re-add.
1205 (Fset_window_configuration): Rewrite to handle dead buffers and
1206 consequently deletable windows.
1207 (window_tree, Fwindow_tree): Remove. Supply functionality in
1208 window.el.
1209 (compare_window_configurations): Simplify code.
1210
b6e3633c
AS
12112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1212
1ab0dee5
AS
1213 * image.c (imagemagick_load_image): Fix type mismatch.
1214 (Fimagemagick_types): Likewise.
1215
b6e3633c
AS
1216 * window.h (replace_buffer_in_windows): Declare.
1217
9397e56f
MR
12182011-06-11 Martin Rudalics <rudalics@gmx.at>
1219
1220 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1221 Qclone_number. Remove external declaration of Qdelete_window.
1222 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1223 code.
1224 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1225 Qbuffer_list_update_hook if allowed.
1226 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1227 buffer list implementation.
1228 (other_buffer_safely): New function.
1229 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1230 calls to replace_buffer_in_windows and
1231 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1232 if allowed.
1233 (record_buffer): Inhibit quitting and rewrite using quittable
1234 functions. Run Qbuffer_list_update_hook if allowed.
1235 (Frecord_buffer, Funrecord_buffer): New functions.
1236 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1237 switch-to-buffer to window.el.
1238 (bury-buffer): Move to window.el.
1239 (Vbuffer_list_update_hook): New variable.
1240
1241 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1242 section.
1243
1244 * window.h (resize_frame_windows): Move up in code.
1245 (Fwindow_frame): Remove EXFUN.
1246 (replace_buffer_in_all_windows): Remove prototype.
1247 (replace_buffer_in_windows_safely): Add prototype.
1248
1249 * window.c: Declare Qdelete_window static again. Move down
1250 declaration of select_count.
1251 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1252 (Fother_window): Move to window.el.
1253 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1254 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1255 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1256 window.el.
1257 (replace_buffer_in_windows): Implement by calling
1258 Qreplace_buffer_in_windows.
1259 (replace_buffer_in_all_windows): Remove with some functionality
1260 moved into replace_buffer_in_windows_safely.
1261 (replace_buffer_in_windows_safely): New function.
1262 (select_window_norecord, select_frame_norecord): Move in front
1263 of run_window_configuration_change_hook. Remove now obsolete
1264 declarations.
1265 (Fset_window_buffer): Rewrite doc-string. Call
1266 Qrecord_window_buffer.
1267 (keys_of_window): Move binding for other-window to window.el.
1268
b50691aa
CY
12692011-06-11 Chong Yidong <cyd@stupidchicken.com>
1270
1271 * dispextern.h (struct image): Replace data member, whose int_val
1272 and ptr_val fields were not used by anything, with a single
1273 lisp_val object.
1274
1275 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1276 (gif_clear_image, gif_load, imagemagick_load_image)
1277 (gs_clear_image, gs_load): Callers changed.
1278
3f754b86
PE
12792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1280
cca69397
PE
1281 * buffer.h: Include <time.h>, for time_t.
1282 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1283
109e28d0
PE
1284 Fix minor problems found by static checking.
1285
60737f02
PE
1286 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1287
4b66faf3
PE
1288 Make identifiers static if they are not used in other modules.
1289 * data.c (Qcompiled_function, Qframe, Qvector):
1290 * image.c (QimageMagick, Qsvg):
1291 * minibuf.c (Qmetadata):
1292 * window.c (resize_window_check, resize_root_window): Now static.
1293 * window.h (resize_window_check, resize_root_window): Remove decls.
1294
109e28d0
PE
1295 * window.c (window_deletion_count, delete_deletable_window):
1296 Remove; unused.
46a4ce9e
PE
1297 (window_body_lines): Now static.
1298 (Fdelete_other_windows_internal): Mark vars as initialized.
1299 Make sure 'resize_failed' is initialized.
1300 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1301 (resize_window_apply): Remove unused local.
1302 * window.h (delete_deletable_window): Remove decl.
1303
109e28d0 1304 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1305 (imagemagick_load_image): Fix pointer signedness problem by changing
1306 last arg from unsigned char * to char *. All uses changed.
1307 Also, fix a local for similar reasons.
1308 Remove unused locals. Remove locals to avoid shadowing.
1309 (fn_rsvg_handle_free): Remove; unused.
1310 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1311 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1312
3f754b86
PE
1313 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1314
2547adb1
CY
13152011-06-10 Chong Yidong <cyd@stupidchicken.com>
1316
1317 * image.c (gif_load): Fix omitted cast error introduced by
1318 2011-06-06 change.
1319
2c8e37d4
MR
13202011-06-10 Martin Rudalics <rudalics@gmx.at>
1321
1322 * window.h (resize_proportionally, orig_total_lines)
1323 (orig_top_line): Remove from window structure.
1324 (set_window_height, set_window_width, change_window_heights)
1325 (Fdelete_window): Remove prototypes.
1326 (resize_frame_windows): Remove duplicate declaration.
1327
440a42e3
EZ
13282011-06-10 Eli Zaretskii <eliz@gnu.org>
1329
1330 * window.h (resize_frame_windows, resize_window_check)
1331 (delete_deletable_window, resize_root_window)
1332 (resize_frame_windows): Declare prototypes.
1333
1334 * window.c (resize_window_apply): Make definition be "static" to
1335 match the prototype.
1336
562dd5e9
MR
13372011-06-10 Martin Rudalics <rudalics@gmx.at>
1338
1339 * window.c: Remove declarations of Qwindow_size_fixed,
1340 window_min_size_1, window_min_size_2, window_min_size,
1341 size_window, window_fixed_size_p, enlarge_window, delete_window.
1342 Remove static from declaration of Qdelete_window, it's
1343 temporarily needed by Fbury_buffer.
1344 (replace_window): Don't assign orig_top_line and
1345 orig_total_lines.
1346 (Fdelete_window, delete_window): Remove. Window deletion is
1347 handled by window.el.
1348 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1349 Fdelete_window calls with calls to Qdelete_window.
1350 (Fdelete_other_windows): Remove. Deleting other windows is
1351 handled by window.el.
1352 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1353 handled in window.el.
1354 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1355 Window minimum sizes are handled in window.el.
1356 (shrink_windows, size_window, set_window_height)
1357 (set_window_width, change_window_heights, window_height)
1358 (window_width, CURBEG, CURSIZE, enlarge_window)
1359 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1360 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1361 handled in window.el.
1362 (make_dummy_parent): Rename to make_parent_window and give it a
1363 second argument horflag.
1364 (make_window): Don't set resize_proportionally any more.
1365 (Fsplit_window): Remove. Windows are split in window.el.
1366 (save_restore_action, save_restore_orig_size)
1367 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1368 Resize mini windows in window.el.
1369 (grow_mini_window, shrink_mini_window): Implement by calling
1370 Qresize_root_window_vertically, resize_window_check and
1371 resize_window_apply.
1372 (saved_window, Fset_window_configuration, save_window_save): Do
1373 not handle orig_top_line, orig_total_lines, and
1374 resize_proportionally.
1375 (window_min_height, window_min_width): Move to window.el.
1376 (keys_of_window): Move bindings for delete-other-windows,
1377 split-window, delete-window and enlarge-window to window.el.
1378
1379 * buffer.c: Temporarily extern Qdelete_window.
1380 (Fbury_buffer): Temporarily call Qdelete_window instead of
1381 Fdelete_window (Fbury_buffer will move to window.el soon).
1382
1383 * frame.c (set_menu_bar_lines_1): Remove code handling
1384 orig_top_line and orig_total_lines.
1385
1386 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1387 set_window_height but set heights directly.
1388 (change_frame_size_1): Use resize_frame_windows.
1389
1390 * xdisp.c (init_xdisp): Don't use set_window_height but set
1391 heights directly.
1392
1393 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1394 resize_frame_windows instead of change_window_heights and run
1395 run_window_configuration_change_hook.
1396
1397 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1398 instead of change_window_heights and run
1399 run_window_configuration_change_hook.
1400
1a13852e
MR
14012011-06-09 Martin Rudalics <rudalics@gmx.at>
1402
1403 * window.c (replace_window): Rename second argument REPLACEMENT to
1404 NEW. New third argument SETFLAG. Rewrite.
1405 (delete_window, make_dummy_parent): Call replace_window with
1406 third argument 1.
1407 (window_list_1): Move down in code.
1408 (run_window_configuration_change_hook): Move set_buffer part
1409 before select_frame_norecord part in order to unwind correctly.
1410 Rename count1 to count.
1411 (recombine_windows, delete_deletable_window, resize_root_window)
1412 (Fdelete_other_windows_internal)
1413 (Frun_window_configuration_change_hook, make_parent_window)
1414 (resize_window_check, resize_window_apply, Fresize_window_apply)
1415 (resize_frame_windows, Fsplit_window_internal)
1416 (Fdelete_window_internal, Fresize_mini_window_internal): New
1417 functions.
1418 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1419
f3d1777e
MR
14202011-06-08 Martin Rudalics <rudalics@gmx.at>
1421
496e208e
MR
1422 * window.h (window): Add some new members to window structure -
1423 normal_lines, normal_cols, new_total, new_normal, clone_number,
1424 splits, nest, prev_buffers, next_buffers.
1425 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1426 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1427
f3d1777e
MR
1428 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1429 Remove.
496e208e
MR
1430 (make_dummy_parent): Set new members of windows structure.
1431 (make_window): Move down in code. Handle new members of window
1432 structure.
1433 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1434 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1435 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1436 (Fset_window_prev_buffers, Fwindow_next_buffers)
1437 (Fset_window_next_buffers, Fset_window_clone_number): New
1438 functions.
1439 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1440 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1441 Doc-string fixes.
1442 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1443 Argument WINDOW can be now internal window too.
1444 (Fwindow_use_time): Move up in code.
1445 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1446 Rewrite doc-string.
1447 (Fset_window_configuration, saved_window)
1448 (Fcurrent_window_configuration, save_window_save): Handle new
1449 members of window structure.
b9e809c2
MR
1450 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1451 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1452 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1453 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1454 Qget_mru_window, Qresize_root_window,
1455 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1456 Qauto_buffer_name; staticpro them.
f3d1777e 1457
abde8f8c
MR
14582011-06-07 Martin Rudalics <rudalics@gmx.at>
1459
1460 * window.c (Fwindow_total_size, Fwindow_left_column)
1461 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1462 (Fwindow_list_1): New functions.
1463 (window_box_text_cols): Replace with window_body_cols.
1464 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1465 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1466 (delete_window, Fset_window_configuration): Call
1467 delete_all_subwindows with window as argument.
1468 (delete_all_subwindows): Take a window as argument and not a
1469 structure. Rewrite.
190b47e6
MR
1470 (window_loop): Remove handling of GET_LRU_WINDOW and
1471 GET_LARGEST_WINDOW.
1472 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1473
1474 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1475 window_box_text_cols. delete_all_subwindows now takes a
1476 Lisp_Object as argument.
abde8f8c
MR
1477
1478 * indent.c (compute_motion, Fcompute_motion): Use
1479 window_body_cols instead of window_box_text_cols.
1480
fa8a67e6
MR
1481 * frame.c (delete_frame): Call delete_all_subwindows with root
1482 window as argument.
1483
a54e3482
DC
14842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1485
1486 * fns.c (Fputhash): Document return value.
1487
60002bf5
CY
14882011-06-06 Chong Yidong <cyd@stupidchicken.com>
1489
1490 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1491
0c671da6 14922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1493
b862a52a 1494 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1495
be44ca6c
PE
1496 Check for overflow when converting integer to cons and back.
1497 * charset.c (Fdefine_charset_internal, Fdecode_char):
1498 Use cons_to_unsigned to catch overflow.
1499 (Fencode_char): Use INTEGER_TO_CONS.
1500 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1501 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1502 * data.c (long_to_cons, cons_to_long): Remove.
1503 (cons_to_unsigned, cons_to_signed): New functions.
1504 These signal an error for invalid or out-of-range values.
1505 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1506 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1507 * font.c (Ffont_variation_glyphs):
1508 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1509 * lisp.h: Include <intprops.h>.
1510 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1511 (cons_to_signed, cons_to_unsigned): New decls.
1512 (long_to_cons, cons_to_long): Remove decls.
1513 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1514 (Fprimitive_undo): Use CONS_TO_INTEGER.
1515 * xfns.c (Fx_window_property): Likewise.
1516 * xselect.c: Include <limits.h>.
1517 (x_own_selection, selection_data_to_lisp_data):
1518 Use INTEGER_TO_CONS.
1519 (x_handle_selection_request, x_handle_selection_clear)
1520 (x_get_foreign_selection, Fx_disown_selection_internal)
1521 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1522 (lisp_data_to_selection_data): Use cons_to_unsigned.
1523 (x_fill_property_data): Use cons_to_signed.
1524 Report values out of range.
1525
d1f3d2af
PE
1526 Check for buffer and string overflow more precisely.
1527 * buffer.h (BUF_BYTES_MAX): New macro.
1528 * lisp.h (STRING_BYTES_MAX): New macro.
1529 * alloc.c (Fmake_string):
1530 * character.c (string_escape_byte8):
1531 * coding.c (coding_alloc_by_realloc):
1532 * doprnt.c (doprnt):
1533 * editfns.c (Fformat):
1534 * eval.c (verror):
1535 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1536 since they may not be the same number.
1537 * editfns.c (Finsert_char):
1538 * fileio.c (Finsert_file_contents):
1539 Likewise for BUF_BYTES_MAX.
1540
dd52fcea
PE
1541 * image.c: Use ptrdiff_t, not int, for sizes.
1542 (slurp_file): Switch from int to ptrdiff_t.
1543 All uses changed.
1544 (slurp_file): Check that file size fits in both size_t (for
1545 malloc) and ptrdiff_t (for sanity and safety).
1546
7f9bbdbb
PE
1547 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1548 if b->modtime has its maximal value.
1549
dfe18f82
PE
1550 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1551
84acfcf0
PE
1552 Don't assume time_t can fit into int.
1553 * buffer.h (struct buffer.modtime): Now time_t, not int.
1554 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1555 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1556
ccd9a01a
PE
1557 Minor fixes for signed vs unsigned integers.
1558 * character.h (MAYBE_UNIFY_CHAR):
1559 * charset.c (maybe_unify_char):
1560 * keyboard.c (read_char, reorder_modifiers):
1561 XINT -> XFASTINT, since the integer must be nonnegative.
1562 * ftfont.c (ftfont_spec_pattern):
1563 * keymap.c (access_keymap, silly_event_symbol_error):
1564 XUINT -> XFASTINT, since the integer must be nonnegative.
1565 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1566 since it makes no difference and we prefer signed.
1567 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1568 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1569 nonnegative.
1570
d6d100dd
SM
15712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1572
1573 * window.h (Fwindow_frame): Declare.
1574
2b6148e4
PE
15752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1578 (SPARE_MEMORY): Always define.
1579 (LARGE_REQUEST): Remove.
1580 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1581
f230ecc9
MR
15822011-06-06 Martin Rudalics <rudalics@gmx.at>
1583
727e958e
MR
1584 * lisp.h: Move EXFUNS for Fframe_root_window,
1585 Fframe_first_window and Fset_frame_selected_window to window.h.
1586
1587 * window.h: Move EXFUNS for Fframe_root_window,
1588 Fframe_first_window and Fset_frame_selected_window here from
1589 lisp.h.
1590
1591 * frame.c (Fwindow_frame, Fframe_first_window)
1592 (Fframe_root_window, Fframe_selected_window)
1593 (Fset_frame_selected_window): Move to window.c.
1594 (Factive_minibuffer_window): Move to minibuf.c.
1595 (Fother_visible_frames_p): New function.
1596
1597 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1598
f230ecc9
MR
1599 * window.c (decode_window, decode_any_window): Move up in code.
1600 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1601 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1602 (Fwindow_buffer): Move up and rewrite doc-string.
1603 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1604 (Fwindow_prev): New functions.
727e958e
MR
1605 (Fwindow_frame): Move here from frame.c. Accept any window as
1606 argument.
1607 (Fframe_root_window, Fframe_first_window)
1608 (Fframe_selected_window): Move here from frame.c. Accept frame
1609 or arbitrary window as argument. Update doc-strings.
1610 (Fminibuffer_window): Move up in code.
1611 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1612 (Fset_frame_selected_window): Move here from frame.c.
1613 Marginal rewrite.
727e958e
MR
1614 (Fselected_window, select_window, Fselect_window): Move up in
1615 code. Minor doc-string fixes.
f230ecc9 1616
4d09bcf6
PE
16172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1620 Do not assume that spare memory exists; that assumption is valid
1621 only if SYSTEM_MALLOC.
1622 (LARGE_REQUEST): New macro, so that the issue of large requests
1623 is separated from the issue of spare memory.
1624
810928a2
AS
16252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1626
172418ad
AS
1627 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1628 format. (Bug#8806)
1629
43f862f7
AS
1630 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1631
810928a2
AS
1632 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1633 before statements.
1634
a059fe24
JD
16352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1636
1637 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1638
1639 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1640
1641 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1642 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1643
989bf368
JB
16442011-06-05 Juanma Barranquero <lekktu@gmail.com>
1645
1646 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1647
4b80f674
CY
16482011-06-04 Chong Yidong <cyd@stupidchicken.com>
1649
1650 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1651 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1652 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1653 New error handlers.
4b80f674
CY
1654 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1655 Obey Vx_select_enable_clipboard_manager. Catch errors in
1656 x_clipboard_manager_save (Bug#8779).
1657 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1658 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1659
99a33b77 16602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1661
1662 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1663
99a33b77 16642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1665
1666 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1667 in the current matrix if keep_current_p is non-zero.
1668
8264569d
EZ
16692011-06-04 Eli Zaretskii <eliz@gnu.org>
1670
1671 * bidi.c (bidi_level_of_next_char): Fix last change.
1672
57f97249
EZ
16732011-06-03 Eli Zaretskii <eliz@gnu.org>
1674
fec2107c 1675 Support bidi reordering of text covered by display properties.
57f97249 1676
fec2107c
EZ
1677 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1678 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1679 (bidi_cache_search, bidi_cache_iterator_state)
1680 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1681 (bidi_level_of_next_char, bidi_move_to_visually_next):
1682 Support character positions inside a run of characters covered by a
fec2107c
EZ
1683 display string.
1684 (bidi_paragraph_init, bidi_resolve_explicit_1)
1685 (bidi_level_of_next_char): Call bidi_fetch_char and
1686 bidi_fetch_char_advance instead of FETCH_CHAR and
1687 FETCH_CHAR_ADVANCE.
1688 (bidi_init_it): Initialize new members.
1689 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1690 definitions.
1691 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1692 instead of using explicit *_CHAR codes.
d6d100dd
SM
1693 (bidi_resolve_explicit, bidi_resolve_weak):
1694 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1695 bidirectional text is supported only in multibyte buffers.
1696 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1697 it to initialize the frame_window_p member of struct bidi_it.
1698 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1699 (bidi_resolve_explicit, bidi_resolve_weak)
1700 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1701 bidi_it->nchars is non-positive.
1702 (bidi_level_of_next_char): Don't try to lookup the cache for the
1703 next/previous character if nothing is cached there yet, or if we
1704 were just reseat()'ed to a new position.
c40e2fb2 1705
0e14fe90
EZ
1706 * xdisp.c (set_cursor_from_row): Set start and stop points
1707 according to the row's direction when priming the loop that looks
1708 for the glyph on which to display cursor.
1709 (single_display_spec_intangible_p): Function deleted.
1710 (display_prop_intangible_p): Reimplement to call
1711 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1712 Accept 3 additional arguments needed by handle_display_spec.
1713 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1714 values: lists, `(when COND...)' forms, etc.
1715 (single_display_spec_string_p): Support property values that are
1716 lists with the argument STRING its top-level element.
1717 (display_prop_string_p): Fix the condition for processing a
1718 property that is a list to be consistent with handle_display_spec.
fec2107c 1719 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1720 last portion of handle_display_prop.
1721 (compute_display_string_pos): Accept additional argument
1722 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1723 value of a `display' property is a "replacing spec".
1724 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1725 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1726 the display property, but just return a value indicating whether
1727 the display property will replace the characters it covers.
1728 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1729 frame_window_p members of struct bidi_it.
d6d100dd
SM
1730 (compute_display_string_pos, compute_display_string_end):
1731 New functions.
fec2107c
EZ
1732 (push_it): Accept second argument POSITION, where pop_it should
1733 jump to continue iteration.
1734 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1735
fec2107c
EZ
1736 * keyboard.c (adjust_point_for_property): Adjust the call to
1737 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1738
1739 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1740 (bidi_init_it): Update prototypes.
1741 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1742 (compute_display_string_pos, compute_display_string_end):
1743 Declare prototypes.
fec2107c
EZ
1744 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1745 EMACS_INT.
fc6f18ce 1746
40087514 17472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1748
57f53182
PE
1749 Malloc failure behavior now depends on size of allocation.
1750 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1751 * lisp.h: Change signatures accordingly.
1752 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1753 All callers changed. (Bug#8762)
1754
1755 * gnutls.c: Use Emacs's memory allocators.
1756 Without this change, the gnutls library would invoke malloc etc.
1757 directly, which causes problems on non-SYNC_INPUT hosts, and which
1758 runs afoul of improving memory_full behavior. (Bug#8761)
1759 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1760 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1761 xfree instead of the default malloc, realloc, free.
1762 (Fgnutls_boot): No need to check for memory allocation failure,
1763 since xmalloc does that for us.
1764
ac32cd99 1765 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1766 * category.c (hash_get_category_set):
1767 * ccl.c (ccl_driver):
1768 * charset.c (Fdefine_charset_internal):
1769 * charset.h (struct charset.hash_index):
1770 * composite.c (get_composition_id, gstring_lookup_cache)
1771 (composition_gstring_put_cache):
1772 * composite.h (struct composition.hash_index):
1773 * dispextern.h (struct image.hash):
1774 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1775 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1776 (hashfn_equal, hashfn_user_defined, make_hash_table)
1777 (maybe_resize_hash_table, hash_lookup, hash_put)
1778 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1779 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1780 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1781 * image.c (make_image, search_image_cache, lookup_image)
1782 (xpm_put_color_table_h):
1783 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1784 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1785 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1786 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1787 * alloc.c (allocate_vectorlike):
1788 Check for overflow in vector size calculations.
1789 * ccl.c (ccl_driver):
1790 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1791 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1792 need to be updated by these changes.
40087514
PE
1793 * fns.c (make_hash_table, maybe_resize_hash_table):
1794 Check for integer overflow with large hash tables.
0de4bb68
PE
1795 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1796 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1797 (SXHASH_REDUCE): New macro.
1798 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1799 Use it instead of discarding useful hash info with large hash values.
1800 (sxhash_float): New function.
1801 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1802 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1803 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1804 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1805 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1806 Adjust signatures to match updated version of code.
1807 (consing_since_gc): Now EMACS_INT, since a single hash table can
1808 use more than INT_MAX bytes.
1809
698d32e2
DN
18102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1811
1812 Make it possible to build with GCC-4.6+ -O2 -flto.
1813
1814 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1815
fd6fa53f
SM
18162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1817
1818 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1819 Call minibuffer-inactive-mode.
1820
864db017
JB
18212011-05-31 Juanma Barranquero <lekktu@gmail.com>
1822
1823 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1824 Update dependencies.
1825
2ad0baf4
DN
18262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1827
1828 * data.c (init_data): Remove code for UTS, this system is not
1829 supported anymore.
1830
4fcc2638
DN
18312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1832
1833 Don't force ./temacs to start in terminal mode.
1834
1835 * frame.c (make_initial_frame): Initialize faces in all cases, not
1836 only when CANNOT_DUMP is defined.
1837 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1838
c56e0fd5
DN
18392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1840
1841 * dispnew.c (add_window_display_history): Use const for the string
1842 pointer. Remove declaration, not needed.
1843
333d54da 18442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1845
55d4c1b2 1846 Use 'inline', not 'INLINE'.
333d54da 1847 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1848 * alloc.c, fontset.c (INLINE): Remove.
1849 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1850 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1851 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1852 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1853 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1854
738db178
DN
18552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1856
1857 Make it possible to run ./temacs.
1858
1859 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1860 syms_of_callproc does the same thing. Remove test for
1861 "initialized", do it in the caller.
1862 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1863
620c53a6
SM
18642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1865
1866 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1867 (read_minibuf): Use get_minibuffer.
1868 (syms_of_minibuf): Use DEFSYM.
1869 (Qmetadata): New var.
1870 * data.c (Qbuffer): Don't make it static.
1871 (syms_of_data): Use DEFSYM.
1872
e003a292
PE
18732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1876 (CCL_CODE_MIN): New macro.
1877
ed008a6d
PE
18782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1879
3687c2ef
PE
1880 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1881
ed008a6d
PE
1882 * eval.c (Qdebug): Now static.
1883 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1884 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1885 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1886
d66c4c7c
CY
18872011-05-29 Chong Yidong <cyd@stupidchicken.com>
1888
1889 * image.c: Various fixes to ImageMagick code comments.
1890 (Fimagemagick_types): Doc fix.
1891
5fbc2025
PE
18922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1893
0196f88a
PE
1894 Minor fixes prompted by GCC 4.6.0 warnings.
1895
1896 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1897
5fbc2025
PE
1898 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1899 (x_clipboard_manager_save_all): Move extern decl to ...
1900 * xterm.h: ... here, so that it can be checked for consistency.
1901
1dd3c2d9
CY
19022011-05-29 Chong Yidong <cyd@stupidchicken.com>
1903
1904 * xselect.c (x_clipboard_manager_save_frame)
1905 (x_clipboard_manager_save_all): New functions.
1906 (Fx_clipboard_manager_save): Lisp function deleted.
1907
1908 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1909 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1910
1911 * xterm.h: Update prototype.
1912
5ba6571d
WX
19132011-05-28 William Xu <william.xwl@gmail.com>
1914
1915 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1916 exiting (Bug#8239).
1917
3eaff834
JM
19182011-05-28 Jim Meyering <meyering@redhat.com>
1919
e1900994 1920 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1921 * fns.c (to_uchar): Define.
1922 (crypto_hash_function): Use it to convert some newly-signed
1923 variables to unsigned, to avoid sign-extension bugs. For example,
1924 without this change, (md5 "truc") would evaluate to
1925 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1926 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1927 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1928
0f6990a7
PE
19292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 Integer overflow fixes.
c8a9ca5a 1932
08686060
PE
1933 * dbusbind.c: Serial number integer overflow fixes.
1934 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1935 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1936 to hold a serial number that is too large for a fixnum.
1937 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1938 Check for serial numbers out of range. Decode any serial number
59568bf0 1939 that was so large that it became a float. (Bug#8722)
08686060 1940
2d1fc3c7
PE
1941 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1943 Use XFASTINT rather than XUINT when numbers are nonnegative.
1944 (xd_append_arg, Fdbus_method_return_internal):
1945 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1946 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1947 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1948 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1949 (Bug#8722)
2d1fc3c7 1950
c8a9ca5a
PE
1951 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1952
519e1d69
PE
1953 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1954
30569699
PE
1955 ccl: add integer overflow checks
1956 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1957 (IN_INT_RANGE): New macros.
1958 (ccl_driver): Use them to check for integer overflow when
1959 decoding a CCL program. Many of the new checks are whether XINT (x)
1960 fits in int; it doesn't always, on 64-bit hosts. The new version
1961 doesn't catch all possible integer overflows, but it's an
847044ea 1962 improvement. (Bug#8719)
30569699 1963
c11285dc
PE
1964 * alloc.c (make_event_array): Use XINT, not XUINT.
1965 There's no need for unsigned here.
1966
fdccd48e
PE
1967 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1968 This follows up to the 2011-05-06 change that substituted uintptr_t
1969 for EMACS_INT. This case wasn't caught back then.
1970
37910ab2
PE
1971 Rework Fformat to avoid integer overflow issues.
1972 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1973 now (part of C89). Include <verify.h>.
1974 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1975 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1976 (Fformat): Avoid the prepass trying to compute sizes; it was only
1977 approximate and thus did not catch overflow reliably. Instead, walk
1978 through the format just once, formatting and computing sizes as we go,
1979 checking for integer overflow at every step, and allocating a larger
1980 buffer as needed. Keep track separately whether the format is
1981 multibyte. Keep only the most-recently calculated precision, rather
1982 than them all. Record whether each argument has been converted to
1983 string. Use EMACS_INT, not int, for byte and char and arg counts.
1984 Support field widths and precisions larger than INT_MAX. Avoid
1985 sprintf's undefined behavior with conversion specifications such as %#d
1986 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1987 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1988 formatting out-of-range floating point numbers with int
9173deec 1989 formats. (Bug#8668)
37910ab2 1990
2e6578fb
PE
1991 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1992
0ae6bdee
PE
1993 * data.c: Avoid integer truncation in expressions involving floats.
1994 * data.c: Include <intprops.h>.
1995 (arith_driver): When there's an integer overflow in an expression
1996 involving floating point, convert the integers to floating point
1997 so that the resulting value does not suffer from catastrophic
1998 integer truncation. For example, on a 64-bit host (* 4
1999 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2000 Do not rely on undefined behavior after integer overflow.
2001
de883a70
PE
2002 merge count_size_as_multibyte, parse_str_to_multibyte
2003 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2004 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2005 Check for integer overflow.
2006 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2007 since it's now a duplicate of the other. This is more of
2008 a character than a buffer op, so better that it's in character.c.
2009 * fns.c, print.c: Adjust to above changes.
2010
2ff916cb
PE
20112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2012
2013 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2014
f1b54466
PE
20152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2016
fb1ac845
PE
2017 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2018 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2019 (x_clipboard_manager_save): Now static.
2020 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2021
f1b54466
PE
2022 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2023 (crypto_hash_function): Now static.
2024 Fix pointer signedness problems. Avoid unnecessary initializations.
2025
a9f737ee
CY
20262011-05-27 Chong Yidong <cyd@stupidchicken.com>
2027
2028 * termhooks.h (Vselection_alist): Make it terminal-local.
2029
2030 * terminal.c (create_terminal): Initialize it.
2031
2032 * xselect.c: Support for clipboard managers.
2033 (Vselection_alist): Move to termhooks.h as terminal-local var.
2034 (LOCAL_SELECTION): New macro.
2035 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2036 (symbol_to_x_atom): Remove gratuitous arg.
2037 (x_handle_selection_request, lisp_data_to_selection_data)
2038 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2039 (x_own_selection, x_get_local_selection, x_convert_selection):
2040 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2041 (some_frame_on_display): Delete unused function.
2042 (Fx_own_selection_internal, Fx_get_selection_internal)
2043 (Fx_disown_selection_internal, Fx_selection_owner_p)
2044 (Fx_selection_exists_p): New optional frame arg.
2045 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2046 (x_handle_selection_clear): Don't treat other terminals with the
2047 same keyboard specially. Use the terminal-local Vselection_alist.
2048 (x_clear_frame_selections): Use Frun_hook_with_args.
2049
2050 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2051
2052 * xterm.h: Add support for those atoms.
2053
e067f0c1
CY
20542011-05-26 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2057 (converted_selections, conversion_fail_tag): New global variables.
2058 (x_selection_request_lisp_error): Free the above.
2059 (x_get_local_selection): Remove unnecessary code.
2060 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2061 of converted selections stored in converted_selections.
2062 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2063 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2064 (x_convert_selection): New function.
2065 (x_handle_selection_event): Simplify.
2066 (x_get_foreign_selection): Don't ignore incoming requests while
2067 waiting for an answer; this will fail when we implement
2068 SAVE_TARGETS, and seems unnecessary anyway.
2069 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2070 (Vx_sent_selection_functions): Doc fix.
2071
0f4aebc0
LL
20722011-05-26 Leo Liu <sdl.web@gmail.com>
2073
2074 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2075
e61124cd
YM
20762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2077
2078 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2079
2080 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2081 for fringe update if it has periodic bitmap.
2082 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2083 and fringe_bitmap_periodic_p.
2084
2085 * fringe.c (get_fringe_bitmap_data): New function.
2086 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2087 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2088 row. Mark glyph row for fringe update if periodicity changed.
2089
2090 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2091 for fringe update unless it has periodic bitmap.
2092
f16d9837
KH
20932011-05-25 Kenichi Handa <handa@m17n.org>
2094
2095 * xdisp.c (get_next_display_element): Set correct it->face_id for
2096 a static composition.
2097
e1b90ef6
LL
20982011-05-24 Leo Liu <sdl.web@gmail.com>
2099
2100 * deps.mk (fns.o):
2101 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2102
2103 * fns.c (crypto_hash_function, Fsha1): New function.
2104 (Fmd5): Use crypto_hash_function.
2105 (syms_of_fns): Add Ssha1.
2106
7400048f
PE
21072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 * gnutls.c: Remove unused macros.
2110 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2111 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2112 Remove macros that are defined and never used.
2113 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2114
abb71cf4
CY
21152011-05-22 Chong Yidong <cyd@stupidchicken.com>
2116
2117 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2118 (Fx_get_selection_internal): Minor cleanup.
2119 (Fx_own_selection_internal): Rename arguments for consistency with
2120 select.el.
2121
6307db39
PE
21222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2125
f3d4e0a4
CY
21262011-05-22 Chong Yidong <cyd@stupidchicken.com>
2127
2128 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2129
4d8ade89
YM
21302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2131
2132 * dispnew.c (scrolling_window): Don't exclude the case that the
2133 last enabled row in the desired matrix touches the bottom boundary.
2134
32078c8d
GM
21352011-05-21 Glenn Morris <rgm@gnu.org>
2136
2137 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2138 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2139 and add some more files.
32078c8d 2140
7285dc67
EZ
21412011-05-20 Eli Zaretskii <eliz@gnu.org>
2142
2143 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2144 report_file_error introduced by the change from 2011-05-07.
2145
89d1bd22
PE
21462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 * systime.h (Time): Define only if emacs is defined.
2149 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2150 where the include path doesn't have X11/X.h by default. See
2151 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2152
e23640bb 21532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2154
2155 * composite.c (find_automatic_composition): Fix previous change.
2156
b9704ad9
GM
21572011-05-20 Glenn Morris <rgm@gnu.org>
2158
2159 * lisp.mk: New file, split from Makefile.in.
2160 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2161 (shortlisp): Remove.
2162 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2163
4a720484
GM
21642011-05-19 Glenn Morris <rgm@gnu.org>
2165
2166 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2167 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2168 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2169 (lisp): Set the order to that of loadup.el.
2170 (shortlisp): Make it a copy of $lisp.
2171 (SOME_MACHINE_LISP): Remove.
2172 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2173 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2174
a28d4396
KH
21752011-05-18 Kenichi Handa <handa@m17n.org>
2176
2177 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2178 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2179 (find_automatic_composition): Mostly rewrite for efficiency.
2180
a2b1fa8e
JB
21812011-05-18 Juanma Barranquero <lekktu@gmail.com>
2182
2183 * makefile.w32-in: Update dependencies.
2184
8e1f5610
CS
21852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2186
2187 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2188 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2189
7025ee00 21902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2191
cdfa6eab
PE
2192 Fix some integer overflow issues, such as string length overflow.
2193
06d6db33
PE
2194 * insdel.c (count_size_as_multibyte): Check for string overflow.
2195
2b4560a8
PE
2196 * character.c (lisp_string_width): Check for string overflow.
2197 Use EMACS_INT, not int, for string indexes and lengths; in
2198 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2199 the resulting string length overflows an EMACS_INT; instead,
2200 report a string overflow if no precision given. When checking for
2201 precision exhaustion, use a check that cannot possibly have
2202 integer overflow. (Bug#8675)
2203 * character.h (lisp_string_width): Adjust to new signature.
2204
cb93f9be
PE
2205 * alloc.c (string_overflow): New function.
2206 (Fmake_string): Use it. This doesn't change behavior, but saves
2207 a few bytes and will simplify future changes.
2208 * character.c (string_escape_byte8): Likewise.
2209 * lisp.h (string_overflow): New decl.
2210
1a1f3366
PE
2211 Fixups, following up to the user-interface timestamp change.
2212 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2213 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2214 * msdos.c (mouse_get_pos): Likewise.
2215 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2216 * w32gui.h (Time): Define by including "systime.h" rather than by
2217 declaring it ourselves. (Bug#8664)
2218
d4e3e4d3
PE
2219 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2220 * image.c (clear_image_cache): Likewise.
2221
f6a24d19
PE
2222 * term.c (term_mouse_position): Don't assume time_t wraparound.
2223
08dc5ae6
PE
2224 Be more systematic about user-interface timestamps.
2225 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2226 and sometimes 'EMACS_UINT', to represent these timestamps.
2227 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2228 This makes the code easier to follow, and makes it easier to catch
2229 integer overflow bugs such as Bug#8664.
2230 * frame.c (Fmouse_position, Fmouse_pixel_position):
2231 Use Time, not unsigned long, for user-interface timestamps.
2232 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2233 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2234 * keyboard.h (last_event_timestamp): Likewise.
2235 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2236 * menu.h (xmenu_show): Likewise.
2237 * term.c (term_mouse_position): Likewise.
2238 * termhooks.h (struct input_event.timestamp): Likewise.
2239 (struct terminal.mouse_position_hook): Likewise.
2240 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2241 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2242 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2243 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2244 what it was before.
2245 * menu.h, termhooks.h: Include "systime.h", for Time.
2246
8e55734a
PE
2247 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2248 Don't assume that the difference between two unsigned long values
2249 can fit into an integer. At this point, we know button_down_time
2250 <= event->timestamp, so the difference must be nonnegative, so
2251 there's no need to cast the result if double-click-time is
2252 nonnegative, as it should be; check that it's nonnegative, just in
2253 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2254 apart (about 25 days). (Bug#8664)
8e55734a 2255
841f1b75 2256 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2257 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2258
3e26f69c
PE
2259 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2260 that always fit in int. Use a sentinel instead of a counter, to
2261 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2262 * frame.h (struct frame): Use int for menu_bar_items_used
2263 instead of EMACS_INT, since it always fits in int.
3e26f69c 2264
5cc152c0
PE
2265 * menu.c (grow_menu_items): Check for int overflow.
2266
d89eb65e
PE
2267 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2268
5235bd3e
PE
2269 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2270 Before, the code was not consistent. These values cannot exceed
2271 2**31 - 1 so there's no need to make them unsigned.
2272 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2273 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2274 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2275 as modifiers.
2276 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2277
bc827e23
PE
2278 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2279 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2280 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2281 presumably because the widths might not match.
2282
78eb494e
PE
2283 * window.c (size_window): Avoid needless test at loop start.
2284
04f2d78b
CB
22852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2286
2287 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2288
d2fc7e3d 22892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2290
2291 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2292
d2fc7e3d 22932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2294
2295 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2296 `width' to `bar_area_x' and `bar_area_width', respectively.
2297 (x_scroll_run): Take account of fringe background extension.
2298
04f2d78b
CB
2299 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2300 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2301 `bar_area_width', respectively.
2302 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2303 background extension.
2304
79b70037
GM
23052011-05-10 Jim Meyering <meyering@redhat.com>
2306
2307 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2308
2f142cc5
JB
23092011-05-10 Juanma Barranquero <lekktu@gmail.com>
2310
2311 * image.c (Finit_image_library): Return t for built-in image types,
2312 like pbm and xbm. (Bug#8640)
2313
57679c86
AS
23142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2315
2316 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2317
888c9e86
EZ
23182011-05-07 Eli Zaretskii <eliz@gnu.org>
2319
b0512a1d
EZ
2320 * w32console.c (Fset_screen_color): Doc fix.
2321 (Fget_screen_color): New function.
2322 (syms_of_ntterm): Defsubr it.
2323
7285dc67
EZ
2324 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2325 unlink the temporary file if Fcall_process didn't create it in the
2326 first place.
2327 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2328 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2329 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2330 cue to call_process_cleanup not to close that handle.
2331
4d3fcc8e
BK
23322011-05-07 Ben Key <bkey76@gmail.com>
2333
2334 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2335 one of two shell specific rules, either bootstrap-temacs-CMD or
2336 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2337 to the previous implementation of the bootstrap-temacs rule.
2338 The bootstrap-temacs-CMD rule is similar to the previous
2339 implementation of the bootstrap-temacs rule except that it
2340 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2341 variable.
2342
2343 These changes, along with some changes to nt/configure.bat,
2344 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2345 earlier fix to add support for --cflags and --ldflags options
2346 that include quotes so that it works whether make uses cmd or
2347 sh as the shell.
2348
b4289b64
MA
23492011-05-06 Michael Albinus <michael.albinus@gmx.de>
2350
2351 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2352 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2353 is a constant.
2354 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2355 a string. Handle both cases.
2356 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2357 (Fdbus_register_method): Use Qinvalid_function.
2358
af4c0e28
JB
23592011-05-06 Juanma Barranquero <lekktu@gmail.com>
2360
2361 * makefile.w32-in: Update dependencies.
2362 (LISP_H): Add inttypes.h and stdin.h.
2363 (PROCESS_H): Add unistd.h.
2364
c51453d9
EZ
23652011-05-06 Eli Zaretskii <eliz@gnu.org>
2366
2367 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2368 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2369
8ff0ac3c 23702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2371
4c4b566b
PE
2372 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2373
aab2b9b5
PE
2374 * term.c (vfatal): Remove stray call to va_end.
2375 It's not needed and the C Standard doesn't allow it here anyway.
2376
c378da0b
PE
2377 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2378 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2379
288b08c7
PE
2380 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2381 bytes.
2382
e3601888
PE
2383 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2384
db6c0e74
PE
2385 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2386
dd5963ea
PE
2387 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2388
88c9450f
PE
2389 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2390
2f9442b8
PE
2391 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2392
c032b5f8
PE
2393 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2394 * charset.c (Fdefine_charset_internal): Don't initialize
2395 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2396 32-bit int (Bug#8600).
a108c10b
PE
2397
2398 * lread.c (read_integer): Be more consistent with string-to-number.
2399 Use string_to_number to do the actual conversion; this avoids
2400 rounding errors and fixes some other screwups. Without this fix,
2401 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2402 (digit_to_number): Move earlier, for benefit of read_integer.
2403 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2404 not a digit in any supported base. (Bug#8602)
a108c10b 2405
ad5f9eea
PE
2406 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2407
aec1708a
PE
2408 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2409 to match comment at start of function. This also removes a
2410 GCC warning about overflow in a 32+64-bit port.
2411
47be4ab5
PE
2412 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2413
371cac43
PE
2414 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2415 Reported by Stefan Monnier in
2416 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2417 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2418 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2419
d01a7826
PE
2420 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2421 (EMACS_UINTPTR): Likewise, with uintptr_t.
2422
7fd47d5c
PE
2423 * lisp.h: Prefer 64-bit EMACS_INT if available.
2424 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2425 on 32-bit hosts that have 64-bit int, so that they can access
2426 large files.
122b0c86
PE
2427 However, temporarily disable this change unless the temporary
2428 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2429
8727937b
PE
2430 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2431
8ac068ac
PE
2432 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2433 This removes an assumption that EMACS_INT and long are the same
2434 width as pointers. The assumption is true for Emacs porting targets
2435 now, but we want to make other targets possible.
2436 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2437 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2438 In the rest of the code, change types of integers that hold casted
2439 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2440 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2441 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2442 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2443 No need to cast type when ORing.
2444 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2445 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2446 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2447 assume EMACS_INT is the same width as char *.
2448 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2449 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2450 Remove no-longer-needed casts.
2451 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2452 (xg_tool_bar_help_callback, xg_make_tool_item):
2453 Use EMACS_INTPTR to hold an integer
2454 that will be cast to void *; this can avoid a GCC warning
2455 if EMACS_INT is not the same width as void *.
2456 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2457 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2458 (current_message_1, set_message_1):
2459 Use a local to convert to proper width without a cast.
2460 * xmenu.c (dialog_selection_callback): Likewise.
2461
ede49d71
PE
2462 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2463 Also, don't assume VALBITS / RAND_BITS is less than 5,
2464 and don't rely on undefined behavior when shifting a 1 left into
2465 the sign bit.
2466 * lisp.h (get_random): Change signature to match.
2467
2f30ecd0
PE
2468 * lread.c (hash_string): Use size_t, not int, for hash computation.
2469 Normally we prefer signed values; but hashing is special, because
2470 it's better to use unsigned division on hash table sizes so that
2471 the remainder is nonnegative. Also, size_t is the natural width
2472 for hashing into memory. The previous code used 'int', which doesn't
2473 retain enough info to hash well into very large tables.
2474 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2475
2a866e7b
PE
2476 * dbusbind.c: Don't possibly lose pointer info when converting.
2477 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2478 Use XPNTR rather than XHASH, so that the high-order bits of
2479 the pointer aren't lost when converting through void *.
2480
51639eac
PE
2481 * eval.c (Fautoload): Don't double-shift a pointer.
2482
92394119
PE
2483 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2484
dbdb9a7c
JB
24852011-05-06 Juanma Barranquero <lekktu@gmail.com>
2486
2487 * gnutls.c (DEF_GNUTLS_FN):
2488 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2489
db7a0b4f
AS
24902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2491
2492 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2493 marker. (Bug#8610)
2494
f7ff1b0f 24952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2496
2497 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2498 New version that can reserve upto 2GB of heap space.
2499
f7ff1b0f 25002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2501
2502 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2503
639c109b
TZ
25042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2505
2506 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2507 `gnutls_certificate_set_x509_key_file'.
2508
d2127135
JB
25092011-05-05 Juanma Barranquero <lekktu@gmail.com>
2510
2511 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2512 Update dependencies.
2513
e968f4f3
JB
25142011-05-04 Juanma Barranquero <lekktu@gmail.com>
2515
2516 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2517 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2518 Remove unused parameter `fildes'.
2519 * process.c (read_process_output, send_process): Don't pass it.
2520
84d358f0
JB
25212011-05-04 Juanma Barranquero <lekktu@gmail.com>
2522
2523 Fix previous change: the library cache is defined in w32.c.
2524 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2525 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2526
0898ca10
JB
25272011-05-04 Juanma Barranquero <lekktu@gmail.com>
2528
2529 Implement dynamic loading of GnuTLS on Windows.
2530
2531 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2532 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2533 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2534 Declare.
2535
2536 * gnutls.c (Qgnutls_dll): Define.
2537 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2538 (gnutls_*): Declare function pointers.
2539 (init_gnutls_functions): New function to initialize function pointers.
2540 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2541 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2542 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2543 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2544 (emacs_gnutls_write, emacs_gnutls_read)
2545 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2546 (Fgnutls_available_p): New function.
2547 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2548 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2549 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2550
2551 * image.c: Include w32.h.
2552 (Vimage_type_cache): Delete.
2553 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2554 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2555 (w32_delayed_load): Move to w32.c.
2556
2557 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2558
2559 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2560 (w32_delayed_load): Move from image.c. When loading a library, record
2561 its filename in the :loaded-from property of the library id.
2562 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2563 Initialize and staticpro them.
2564 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2565
2566 * process.c: Include lisp.h before w32.h, not after.
2567 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2568 instead of gnutls_record_check_pending.
2569
2570 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2571
ff4de4aa
TZ
25722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2573
2574 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2575 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2576 as passed in.
2577
abe95abb
JD
25782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2579
2580 * xterm.c (x_set_frame_alpha): Do not set property on anything
2581 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2582
e16e55d4
JB
25832011-05-02 Juanma Barranquero <lekktu@gmail.com>
2584
2585 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2586
bafcf6a5
JB
25872011-05-02 Juanma Barranquero <lekktu@gmail.com>
2588
2589 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2590 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2591 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2592 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2593 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2594 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2595 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2596 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2597 (Qgnutls_bootprop_callbacks_verify): Make static.
2598
e7a6747f
AS
25992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2600
19ed11ba
AS
2601 * callproc.c: Indentation fixup.
2602
e7a6747f 2603 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2604 (wait_for_termination, interruptible_wait_for_termination):
2605 Move after wait_for_termination_1.
e7a6747f 2606
1ef14cb4
LMI
26072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2608
2609 * sysdep.c (interruptible_wait_for_termination): New function
2610 which is like wait_for_termination, but allows keyboard
2611 interruptions.
2612
2613 * callproc.c (Fcall_process): Add (:file "file") as an option for
2614 the STDOUT buffer.
2615 (Fcall_process_region): Ditto.
2616
330d880c
EZ
26172011-04-30 Eli Zaretskii <eliz@gnu.org>
2618
8db90b73
EZ
2619 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2620 rather than `XVECTOR (FOO)->size'.
2621
330d880c
EZ
2622 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2623 inttypes.h, as a gnulib replacement is used if it not available in
2624 system headers.
2625
15cbd324
EZ
26262011-04-21 Eli Zaretskii <eliz@gnu.org>
2627
2628 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2629 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2630 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2631
2632 * coding.c (coding_alloc_by_realloc): Error out if destination
2633 will grow beyond MOST_POSITIVE_FIXNUM.
2634 (decode_coding_emacs_mule): Abort if there isn't enough place in
2635 charbuf for the composition carryover bytes. Reserve an extra
2636 space for up to 2 characters produced in a loop.
2637 (decode_coding_iso_2022): Abort if there isn't enough place in
2638 charbuf for the composition carryover bytes.
2639
26402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2641
ae940cca
EZ
2642 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2643 aborting when %lld or %lll format is passed.
2644 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2645 %llo or %llx format is passed. (Bug#8545)
2646
03ab8921
EZ
2647 * window.c (window_scroll_line_based): Use a marker instead of
2648 simple variables to record original value of point. (Bug#7952)
2649
afda1437
EZ
2650 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2651 produced by %s or %c overflows available buffer space. (Bug#8545)
2652
f76dee0c
PE
26532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2654
2655 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2656 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2657
fdc5744d
JB
26582011-04-28 Juanma Barranquero <lekktu@gmail.com>
2659
2660 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2661
638f053a
JB
26622011-04-28 Juanma Barranquero <lekktu@gmail.com>
2663
2664 * keyboard.c (Qdelayed_warnings_hook): Define.
2665 (command_loop_1): Run `delayed-warnings-hook'
2666 if Vdelayed_warnings_list is non-nil.
2667 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2668 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2669
d178f871
EZ
26702011-04-28 Eli Zaretskii <eliz@gnu.org>
2671
2672 * doprnt.c (doprnt): Don't return value smaller than the buffer
2673 size if the message was truncated. (Bug#8545).
2674
b124fd93
JB
26752011-04-28 Juanma Barranquero <lekktu@gmail.com>
2676
2677 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2678 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2679
e810457d
PE
26802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2681
2682 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2683
ea51cceb
JB
26842011-04-27 Juanma Barranquero <lekktu@gmail.com>
2685
2686 * makefile.w32-in: Update dependencies.
2687
94dcfacf
EZ
26882011-04-27 Eli Zaretskii <eliz@gnu.org>
2689
2690 Improve `doprnt' and its usage. (Bug#8545)
2691 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2692 `format_end'. Remove support for %l as a conversion specifier.
2693 Don't use xrealloc. Improve diagnostics when the %l size modifier
2694 is used. Update the commentary.
2695
2696 * eval.c (verror): Simplify calculation of size_t.
2697
2698 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2699 messages.
2700
f61f41d7
PE
27012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2702
2703 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2704 change.
2705
96fb4434
PE
27062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2707
2708 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2709 This makes this file independent of the recent pseudovector change.
2710
671875da 27112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2712
69e9b5a3
PE
2713 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2714
b5f869a7 2715 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2716 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2717 Remove unused local.
c8926152 2718 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2719
841a1577 2720 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2721 GCC 4.6.0 optimizes based on type-based alias analysis.
2722 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2723 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2724 != &v->size, and therefore "v->size = 1; b->size = 2; return
2725 v->size;" must therefore return 1. This assumption is incorrect
2726 for Emacs, since it type-puns struct Lisp_Vector * with many other
2727 types. To fix this problem, this patch adds a new type struct
f904488f 2728 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2729 and pseudovectors, and helps optimizing compilers not get fooled
2730 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2731 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2732 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2733 the size member.
eab3844f
PE
2734 (XSETPVECTYPE): Rewrite in terms of new macro.
2735 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2736 This is a bit clearer, and further avoids the possibility of
2737 undesirable aliasing.
2738 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2739 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2740 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2741 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2742 (ASIZE): Now uses header.size rather than size.
2743 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2744 to avoid the hassle of writing XVECTOR (foo)->header.size.
2745 (struct vectorlike_header): New type.
eab3844f
PE
2746 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2747 object, to help avoid aliasing.
2748 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2749 (SUBRP): Likewise, since Lisp_Subr is a special case.
2750 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2751 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2752 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2753 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2754 changed to be "header.size" and "header.next".
2755 * buffer.h (struct buffer): Likewise.
2756 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2757 * frame.h (struct frame): Likewise.
2758 * process.h (struct Lisp_Process): Likewise.
2759 * termhooks.h (struct terminal): Likewise.
2760 * window.c (struct save_window_data, struct saved_window): Likewise.
2761 * window.h (struct window): Likewise.
2762 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2763 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2764 * buffer.c (init_buffer_once): Likewise.
2765 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2766 special case.
2767 * process.c (Fformat_network_address): Use local var for size,
2768 for brevity.
2769
0df1eac5
PE
2770 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2771
847ab9d1 2772 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2773 * data.c (atof): Remove decl; no longer used or needed.
2774 (digit_to_number): Move to lread.c.
2775 (Fstring_to_number): Use new string_to_number function, to be
2776 consistent with how the Lisp reader treats infinities and NaNs.
2777 Do not assume that floating-point numbers represent EMACS_INT
2778 without losing information; this is not true on most 64-bit hosts.
2779 Avoid double-rounding errors, by insisting on integers when
2780 parsing non-base-10 numbers, as the documentation specifies.
2781 * lisp.h (string_to_number): New decl, replacing ...
2782 (isfloat_string): Remove.
bc0a5c13 2783 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2784 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2785 appears to have been a coding error. Similarly, do not accept
2786 strings like +-1e0 as floating point numbers. Do not report
2787 overflow for integer overflows unless the base is not 10 which
2788 means we have no simple and reliable way to continue.
2789 Break out the floating-point parsing into a new
2790 function string_to_number, so that Fstring_to_number parses
2791 floating point numbers consistently with the Lisp reader.
04f2d78b 2792 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2793 (E_CHAR, EXP_INT): Remove, replacing with ...
2794 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2795 (string_to_number): New function, replacing isfloat_string.
2796 This function checks for valid syntax and produces the resulting
2797 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2798 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2799 so that overflow for non-base-10 numbers is reported only when
2800 there's no portable and simple way to convert to floating point.
452f4150 2801
67769ffc
PE
2802 * textprop.c (set_text_properties_1): Rewrite for clarity,
2803 and to avoid GCC warning about integer overflow.
2804
c20db43f
PE
2805 * intervals.h (struct interval): Use EMACS_INT for members
2806 where EMACS_UINT might cause problems. See
2807 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2808 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2809 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2810 All uses changed.
37aa2f85
PE
2811 (offset_intervals): Tell GCC not to worry about length overflow
2812 when negating a negative length.
c20db43f 2813
2538aa2f
PE
2814 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2815 (overrun_check_free): Likewise.
2816
f2d3008d
PE
2817 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2818 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2819 word size.
2820
ec8df744
PE
2821 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2822 (gnutls_make_error): Rename local to avoid shadowing.
2823 (gnutls_emacs_global_deinit): ifdef out; not used.
2824 (Fgnutls_boot): Use const for pointer to readonly storage.
2825 Comment out unused local. Fix pointer signedness problems.
2826
640ee02d
PE
2827 * lread.c (openp): Don't stuff size_t into an 'int'.
2828 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2829 about possible signed overflow.
2830
6048fb2a
PE
2831 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2832 (GDK_KEY_g): Don't define if already defined.
2833 (xg_prepare_tooltip): Avoid pointer signedness problem.
2834 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2835
fa3c87e1
PE
2836 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2837 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2838
2172544b
PE
2839 * xfns.c (Fx_window_property): Simplify a bit,
2840 to make a bit faster and to avoid GCC 4.6.0 warning.
2841 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2842
9b821a21
PE
2843 * fns.c (internal_equal): Don't assume size_t fits in int.
2844
3c616cfa
PE
2845 * alloc.c (compact_small_strings): Tighten assertion a little.
2846
c2982e87
PE
2847 Replace pEd with more-general pI, and fix some printf arg casts.
2848 * lisp.h (pI): New macro, generalizing old pEd macro to other
2849 conversion specifiers. For example, use "...%"pI"d..." rather
2850 than "...%"pEd"...".
2851 (pEd): Remove. All uses replaced with similar uses of pI.
2852 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2853 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2854 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2855 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2856 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2857 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2858 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2859 64-bit hosts.
2860 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2861 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2862 * print.c (safe_debug_print, print_object): Likewise.
2863 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2864 to int.
6f04d126
PE
2865 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2866 avoiding the 0 flag, which is not portable.
c2982e87
PE
2867 * process.c (Fmake_network_process): Use pI to avoid cast.
2868 * region-cache.c (pp_cache): Likewise.
2869 * xdisp.c (decode_mode_spec): Likewise.
2870 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2871 behavior on 64-bit hosts with printf arg.
6f04d126 2872 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2873 (x_stop_queuing_selection_requests): Likewise.
2874 (x_get_window_property): Don't truncate byte count to an 'int'
2875 when tracing.
0b432f21 2876
5e073ec7
PE
2877 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2878 here, since it parses constructs like leading '-' and spaces,
2879 which are not wanted; and it overflows with large numbers.
2880 Instead, simply match F[0-9]+, which is what is wanted anyway.
2881
36372bf9
PE
2882 * alloc.c: Remove unportable assumptions about struct layout.
2883 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2884 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2885 (allocate_vectorlike, make_pure_vector): Use the new macros,
2886 plus offsetof, to remove unportable assumptions about struct layout.
2887 These assumptions hold on all porting targets that I know of, but
2888 they are not guaranteed, they're easy to remove, and removing them
2889 makes further changes easier.
2890
0b432f21
PE
2891 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2892 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2893 (string_overrun_cookie): Now const. Use initializers that
2894 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2895 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2896 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2897 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2898 multiple of sizeof (EMACS_INT); it need not be, if
2899 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2900 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2901
895009e1
JB
29022011-04-26 Juanma Barranquero <lekktu@gmail.com>
2903
2904 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2905
6a7a1b0b
TZ
29062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2907
2908 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2909 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2910 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2911
841a1577 29122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2913
2914 * lisp.h (Qdebug): List symbol.
895009e1 2915 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2916 * keyboard.c (debug-on-event): New variable.
2917 (handle_user_signal): Break into debugger when debug-on-event
2918 matches the current signal symbol.
2919
f2d3ba6f
DN
29202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2921
2922 * alloc.c (check_sblock, check_string_bytes)
2923 (check_string_free_list): Convert to standard C.
2924
42ce4c63
TZ
29252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2926
2927 * w32.c (emacs_gnutls_push): Fix typo.
2928
825cd63c
EZ
29292011-04-25 Eli Zaretskii <eliz@gnu.org>
2930
fb11d64d
EZ
2931 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2932 "cast to pointer from integer of different size".
2933
825cd63c
EZ
2934 Improve doprnt and its use in verror. (Bug#8545)
2935 * doprnt.c (doprnt): Document the set of format control sequences
2936 supported by the function. Use SAFE_ALLOCA instead of always
2937 using `alloca'.
2938
2939 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2940 is one byte too soon. Don't use xrealloc; instead xfree and
2941 xmalloc anew.
2942
e061a11b
TZ
29432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2944
2945 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2946 callbacks stage.
2947
2948 * gnutls.c: Renamed global_initialized to
2949 gnutls_global_initialized. Added internals for the
2950 :verify-hostname-error, :verify-error, and :verify-flags
2951 parameters of `gnutls-boot' and documented those parameters in the
2952 docstring. Start callback support.
9173deec
JB
2953 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2954 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2955 on error. Return error code.
e061a11b
TZ
2956 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2957 (emacs_gnutls_read): Likewise.
2958 (Fgnutls_boot): Return handshake error code.
2959 (emacs_gnutls_handle_error): New function.
2960 (wsaerror_to_errno): Likewise.
2961
2962 * w32.h (emacs_gnutls_pull): Add prototype.
2963 (emacs_gnutls_push): Likewise.
2964
2965 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2966 (emacs_gnutls_push): Likewise.
2967
29682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2969
2970 * process.c (wait_reading_process_output): Check if GnuTLS
2971 buffered some data internally if no FDs are set for TLS
2972 connections.
2973
2974 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2975 (LIBS): Link to USER_LIBS.
2976 ($(BLD)/gnutls.$(0)): New target.
2977
fa6996bc
EZ
29782011-04-24 Eli Zaretskii <eliz@gnu.org>
2979
eb35682e
EZ
2980 * xdisp.c (handle_single_display_spec): Rename the
2981 display_replaced_before_p argument into display_replaced_p, to
2982 make it consistent with the commentary. Fix typos in the
2983 commentary.
2984
e2ad650c
EZ
2985 * textprop.c (syms_of_textprop): Remove dead code.
2986 (copy_text_properties): Delete obsolete commentary about an
2987 interface that was deleted long ago. Fix typos in the description
2988 of arguments.
2989
1b2de274
EZ
2990 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2991 to changes in oldXMenu/XMenu.h from 2011-04-16.
2992 <menu_help_message, prev_menu_help_message>: Constify.
2993 (IT_menu_make_room): menu->help_text is now `const char **';
2994 adjust.
2995
2996 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2997 to changes in oldXMenu/XMenu.h from 2011-04-16.
2998 (struct XMenu): Declare `help_text' `const char **'.
2999
3000 * xfaces.c <Qunspecified>: Make extern again.
3001
3002 * syntax.c: Include sys/types.h before including regex.h, as
3003 required by Posix.
3004
762b15be
EZ
3005 * doc.c (get_doc_string): Improve the format passed to `error'.
3006
3007 * doprnt.c (doprnt): Improve commentary.
3008
3009 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3010
3011 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3012 them with etags.
3013
f1052e5d
EZ
3014 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3015 changes in globals.h immediately force recompilation.
762b15be
EZ
3016 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3017 $(CURDIR)/s/ms-w32.h.
3018 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3019
fa6996bc
EZ
3020 * character.c (Fchar_direction): Function deleted.
3021 (syms_of_character): Don't defsubr it.
3022 <char-direction-table>: Deleted.
3023
e6c3da20
EZ
30242011-04-23 Eli Zaretskii <eliz@gnu.org>
3025
3026 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3027 * doprnt.c: Include limits.h.
3028 (SIZE_MAX): New macro.
04f2d78b
CB
3029 (doprnt): Return a size_t value. 2nd arg is now size_t.
3030 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3031 Improve overflow protection. Support `l' modifier for integer
3032 conversions. Support %l conversion. Don't assume an EMACS_INT
3033 argument for integer conversions and for %c.
3034
3035 * lisp.h (doprnt): Restore prototype.
3036
3037 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3038 $(SRC)/character.h.
3039
3040 * Makefile.in (base_obj): Add back doprnt.o.
3041
3042 * deps.mk (doprnt.o): Add back prerequisites.
3043 (callint.o): Depend on character.h.
3044
3045 * eval.c (internal_lisp_condition_case): Include the handler
3046 representation in the error message.
3047 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3048 when breaking from the loop.
3049
3050 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3051
3052 * callint.c (Fcall_interactively): When displaying error message
3053 about invalid control letter, pass the character's codepoint, not
3054 a pointer to its multibyte form. Improve display of the character
3055 in octal and display also its hex code.
3056
3057 * character.c (char_string): Use %x to display the (unsigned)
3058 codepoint of an invalid character, to avoid displaying a bogus
3059 negative value.
3060
3061 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3062 `error', not SYMBOL_NAME itself.
3063
3064 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3065 character arguments to `error'.
3066
3067 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3068 to `error' in error message about FINAL_CHAR argument. Make sure
3069 FINAL_CHAR is a character, and use %c when it is passed as
3070 argument to `error'.
3071
4ffd0d6b 30722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3073
3074 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3075
3076 * w32.c: Include <time.h>.
3077 (sys_localtime): New function.
3078
4ffd0d6b 30792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3080
3081 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3082
4ffd0d6b 3083 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3084
4ffd0d6b 30852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3086
4ffd0d6b
GM
3087 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3088 zombies (Bug#8467).
aac0c6e3 3089
04c56954
EZ
30902011-04-19 Eli Zaretskii <eliz@gnu.org>
3091
3092 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3093 gl_state.e_property when gl_state.object is Qt.
3094
3095 * insdel.c (make_gap_larger): Remove limitation of buffer size
3096 to <= INT_MAX.
3097
16a43933
CY
30982011-04-18 Chong Yidong <cyd@stupidchicken.com>
3099
3100 * xdisp.c (lookup_glyphless_char_display)
3101 (produce_glyphless_glyph): Handle cons cell entry in
3102 glyphless-char-display.
3103 (Vglyphless_char_display): Document it.
3104
3105 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3106 glyphless-char-display.
3107
4581706e
CY
31082011-04-17 Chong Yidong <cyd@stupidchicken.com>
3109
3110 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3111
3112 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3113
3114 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3115 definition for no-X builds.
3116
4887c6e2 31172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3118
fd35b6f9
PE
3119 Static checks with GCC 4.6.0 and non-default toolkits.
3120
5c1ccb01
PE
3121 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3122
006c5daa
PE
3123 * process.c (keyboard_bit_set): Define only if SIGIO.
3124 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3125 (send_process): Repair possible setjmp clobbering.
3126
efc736d3
PE
3127 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3128
4e2fe2e6
PE
3129 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3130
f97334a2
PE
3131 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3132
4e75f29d
PE
3133 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3134 Define only if needed.
3135
90efadd1
PE
3136 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3137 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3138 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3139
3c647824
PE
3140 * dispextern.h (struct redisplay_interface): Rename param
3141 to avoid shadowing.
e264f262 3142 * termhooks.h (struct terminal): Likewise.
761383f4 3143 * xterm.c (xembed_send_message): Likewise.
3c647824 3144
b58c5c4a
PE
3145 * insdel.c (make_gap_smaller): Define only if
3146 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3147
cad59032
PE
3148 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3149 it.
3150
c339dc2e
PE
3151 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3152 so that we aren't warned about unused symbols.
3153
91a3e27b
PE
3154 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3155
399c71d3 3156 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3157
8ffc96f5
PE
3158 * xfns.c (x_real_positions): Mark locals as initialized.
3159
eef9bc79
PE
3160 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3161
098db9dd
PE
3162 * xterm.c: Fix problems found by static analysis with other toolkits.
3163 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3164 (x_dispatch_event): Declare static if USE_GTK, and
3165 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3166 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3167 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3168 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3169 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3170
eb18f6cc
PE
3171 * xmenu.c (menu_help_callback): Pointer type fixes.
3172 Use const pointers when pointing at readonly data. Avoid pointer
3173 signedness clashes.
3174 (FALSE): Remove unused macro.
3175 (update_frame_menubar): Remove unused decl.
3176
1fe72bf8
PE
3177 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3178
60d9e1db
PE
3179 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3180 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3181 (single_menu_item): Rename local to avoid shadowing.
3182
39261c26
PE
3183 * keyboard.c (make_lispy_event): Remove unused local var.
3184
018c5e19
PE
3185 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3186 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3187
63d2b86e
PE
3188 * bitmaps: Change bitmaps from unsigned char back to the X11
3189 compatible char. Avoid the old compiler warnings about
3190 out-of-range initializers by using, for example, '\xab' rather
3191 than 0xab.
3192
aefd87e1
PE
3193 * xgselect.c (xgselect_initialize): Check vs interface
3194 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3195
bf501fb9
PE
3196 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3197
e9829fdf
PE
3198 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3199 to read-only memory.
3200
1086c095
PE
3201 * fns.c (vector): Remove; this old hack is no longer needed.
3202
2baccd04 3203 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3204 Remove unused var.
dde42981 3205 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3206
72391843 3207 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3208
436c16df 3209 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3210 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3211 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3212
92bb796d 3213 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3214 (x_term_init): Remove local to avoid shadowing.
92bb796d 3215
764430a3 3216 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3217
3218 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3219 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3220
d1dfb56c
EZ
32212011-04-16 Eli Zaretskii <eliz@gnu.org>
3222
c4354cb4
EZ
3223 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3224
d1dfb56c
EZ
3225 Fix regex.c, syntax.c and friends for buffers > 2GB.
3226 * syntax.h (struct gl_state_s): Declare character position members
3227 EMACS_INT.
3228
3229 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3230
04f2d78b
CB
3231 * textprop.c (verify_interval_modification, interval_of):
3232 Declare arguments EMACS_INT.
d1dfb56c
EZ
3233
3234 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3235 EMACS_INT.
3236
3237 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3238
3239 * indent.c (Fvertical_motion): Local variable it_start is now
3240 EMACS_INT.
3241
3242 * regex.c (re_match, re_match_2, re_match_2_internal)
3243 (bcmp_translate, regcomp, regexec, print_double_string)
3244 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3245 (re_compile_pattern, re_exec): Declare arguments and local
3246 variables `size_t' and `ssize_t' and return values `regoff_t', as
3247 appropriate.
3248 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3249 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3250 <compile_stack_type>: `size' and `avail' are now `size_t'.
3251
3252 * regex.h <regoff_t>: Use ssize_t, not int.
3253 (re_search, re_search_2, re_match, re_match_2): Arguments that
3254 specify buffer/string position and length are now ssize_t and
3255 size_t. Return type is regoff_t.
3256
613052cd
BK
32572011-04-16 Ben Key <bkey76@gmail.com>
3258
3259 * nsfont.m: Fixed bugs in ns_get_family and
3260 ns_descriptor_to_entity that were caused by using free to
3261 deallocate memory blocks that were allocated by xmalloc (via
3262 xstrdup). This caused Emacs to crash when compiled with
3263 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3264 --enable-checking=xmallocoverrun). xfree is now used to
3265 deallocate these memory blocks.
3266
4170f62f 32672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3268
71b41406
PE
3269 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3270
9587a89d
PE
3271 emacs_write: Accept and return EMACS_INT for sizes.
3272 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3273 et seq.
3274 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3275 Accept and return EMACS_INT.
3276 (emacs_gnutls_write): Return the number of bytes written on
3277 partial writes.
3278 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3279 (emacs_read, emacs_write): Remove check for negative size, as the
3280 Emacs source code has been audited now.
9587a89d
PE
3281 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3282 (emacs_read, emacs_write): Use it.
273a5f82
PE
3283 * process.c (send_process): Adjust to the new signatures of
3284 emacs_write and emacs_gnutls_write. Do not attempt to store
3285 a byte offset into an 'int'; it might overflow.
9587a89d 3286 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3287
3e047f51
PE
3288 * sound.c: Don't assume sizes fit in 'int'.
3289 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3290 Return EMACS_INT, not int.
3e047f51 3291 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3292 Accept EMACS_INT, not int.
3293 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3294 record read return values.
3295
cc39a9db
BK
32962011-04-15 Ben Key <bkey76@gmail.com>
3297
c9d0ec6d
JB
3298 * keyboard.c (Qundefined): Don't declare static since it is used
3299 in nsfns.m.
3300 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3301 static since they are used in nsfont.m.
cc39a9db 3302
6c60eb9f
SM
33032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3304
3305 * process.c (Qprocessp): Don't declare static.
3306 * lisp.h (Qprocessp): Declare again.
3307
7990b61a
JB
33082011-04-15 Juanma Barranquero <lekktu@gmail.com>
3309
3310 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3311
5d4cb038
PE
33122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3313
8bd7b830 3314 Improve C-level modularity by making more things 'static'.
cd64ea1d 3315
e3b27b31
PE
3316 Don't publish debugger-only interfaces to other modules.
3317 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3318 (verify_bytepos, count_markers): Move decls to the only modules
3319 that need them.
3320 * region-cache.h (pp_cache): Likewise.
3321 * window.h (check_all_windows): Likewise.
3322 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3323
5d4cb038
PE
3324 * sysdep.c (croak): Now static, if
3325 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3326 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3327
3328 * alloc.c (refill_memory_reserve): Now static if
3329 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3330 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3331
e87b6180
PE
3332 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3333 Define only if USE_LUCID.
3334
ac64929e
PE
3335 * xrdb.c (x_customization_string, x_rm_string): Now static.
3336
6f37259d
PE
3337 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3338 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3339
1683e3ab
PE
3340 * xdisp.c (draw_row_with_mouse_face): Now static.
3341 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3342
de9c2632
PE
3343 * window.h (check_all_windows): Mark externally visible.
3344
2b96acb7
PE
3345 * window.c (window_deletion_count): Now static.
3346
3347 * undo.c: Make symbols static if they're not exported.
3348 (last_undo_buffer, last_boundary_position, pending_boundary):
3349 Now static.
3350
50436f33
PE
3351 * textprop.c (interval_insert_behind_hooks): Now static.
3352 (interval_insert_in_front_hooks): Likewise.
3353
64520e5c
PE
3354 * term.c: Make symbols static if they're not exported.
3355 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3356 (max_frame_lines, tty_set_terminal_modes):
3357 (tty_reset_terminal_modes, tty_turn_off_highlight):
3358 (get_tty_terminal): Now static.
3359 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3360 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3361 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3362 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3363 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3364
1fa53021
PE
3365 * sysdep.c: Make symbols static if they're not exported.
3366 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3367 Now static.
3368 (sigprocmask_set, full_mask): Remove; unused.
3369 (wait_debugging): Mark as visible.
3370 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3371 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3372
d4b43b22
PE
3373 * syntax.c (syntax_temp): Define only if !__GNUC__.
3374
b7c513d0
PE
3375 * sound.c (current_sound_device, current_sound): Now static.
3376
989b29ad
PE
3377 * search.c (searchbufs, searchbuf_head): Now static.
3378
13a55a78
PE
3379 * scroll.c (scroll_cost): Remove; unused.
3380 * dispextern.h (scroll_cost): Remove decl.
3381
de68a1fc
PE
3382 * region-cache.h (pp_cache): Mark as externally visible.
3383
40ccffa6
PE
3384 * process.c: Make symbols static if they're not exported.
3385 (process_tick, update_tick, create_process, chan_process):
3386 (Vprocess_alist, proc_buffered_char, datagram_access):
3387 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3388 (deactivate_process): Mark defn as static, as well as decl.
3389 * lisp.h (create_process): Remove decl.
3390 * process.h (chan_process, Vprocess_alist): Remove decls.
3391
ad64fc97
PE
3392 * print.c: Make symbols static if they're not exported.
3393 (print_depth, new_backquote_output, being_printed, print_buffer):
3394 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3395 (print_interval, print_number_index, initial_stderr_stream):
3396 Now static.
3397 * lisp.h (Fprinc): Remove decl.
3398 (debug_output_compilation_hack): Mark as externally visible.
3399
adddb265
PE
3400 * sysdep.c (croak): Move decl from here to syssignal.h.
3401 * syssignal.h (croak): Put it here, so the API can be checked when
3402 'croak' is called from dissociate_if_controlling_tty.
3403
1717ede2
PE
3404 * minibuf.c: Make symbols static if they're not exported.
3405 (minibuf_save_list, choose_minibuf_frame): Now static.
3406 * lisp.h (choose_minibuf_frame): Remove decl.
3407
fa5fb2bc
PE
3408 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3409
1e3890d1
PE
3410 * lread.c: Make symbols static if they're not exported.
3411 (read_objects, initial_obarray, oblookup_last_bucket_number):
3412 Now static.
3413 (make_symbol): Remove; unused.
3414 * lisp.h (initial_obarray, make_symbol): Remove decls.
3415
8a1414fa
PE
3416 * keyboard.c: Make symbols static if they're not exported.
3417 (single_kboard, recent_keys_index, total_keys, recent_keys):
3418 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3419 (this_single_command_key_start, echoing, last_auto_save):
3420 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3421 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3422 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3423 (Vlispy_mouse_stem, double_click_count):
3424 Now static.
3425 (force_auto_save_soon): Define only if SIGDANGER.
3426 (ignore_mouse_drag_p): Now static if
3427 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3428 (print_help): Remove; unused.
3429 (stop_character, last_timer_event): Mark as externally visible.
3430 * keyboard.h (ignore_mouse_drag_p): Declare only if
3431 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3432 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3433 * lisp.h (echoing): Remove decl.
3434 (force_auto_save_soon): Declare only if SIGDANGER.
3435 * xdisp.c (redisplay_window): Simplify code, to make it more
3436 obvious that ignore_mouse_drag_p is not accessed if !defined
3437 USE_GTK && !defined HAVE_NS.
3438
93ea6e8f
PE
3439 * intervals.c: Make symbols static if they're not exported.
3440 (merge_properties_sticky, merge_interval_right, delete_interval):
3441 Now static.
3442 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3443
77382fcc
PE
3444 * insdel.c: Make symbols static if they're not exported.
3445 However, leave prepare_to_modify_buffer alone. It's never
3446 called from outside this function, but that appears to be a bug.
3447 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3448 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3449 (adjust_after_replace_noundo): Remove; unused.
3450 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3451 (signal_before_change): Remove decls.
77382fcc 3452
9306c32e
PE
3453 * indent.c (val_compute_motion, val_vmotion): Now static.
3454
cd44d2eb
PE
3455 * image.c: Make symbols static if they're not exported.
3456 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3457 if USE_GTK.
3458 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3459 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3460
ad9a7a06
PE
3461 * fringe.c (standard_bitmaps): Now static.
3462 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3463
81626931
PE
3464 * frame.c: Make symbols static if they're not exported.
3465 (x_report_frame_params, make_terminal_frame): Now static.
3466 (get_frame_param): Now static, unless HAVE_NS.
3467 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3468 (x_get_resource_string): Remove; not used.
3469 * frame.h (make_terminal_frame, x_report_frame_params):
3470 (x_get_resource_string); Remove decls.
3471 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3472 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3473
239f9db9
PE
3474 * font.c, fontset.c: Make symbols static if they're not exported.
3475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3476 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3477 * font.c (font_close_object): Now static.
3478 * font.h (font_close_object): Remove.
3479 * fontset.c (FONTSET_OBJLIST): Remove.
3480 (free_realized_fontset) #if-0 the body, which does nothing.
3481 (face_suitable_for_char_p): #if-0, as it's never called.
3482 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3483 * xfaces.c (face_at_string_position):
3484 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3485 since 0 is always ASCII.
3486
dfcf3579
PE
3487 * fns.c (weak_hash_tables): Now static.
3488
5045092b
PE
3489 * fileio.c: Make symbols static if they're not exported.
3490 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3491 (Vwrite_region_annotation_buffers): Now static.
3492
57a96f5c
PE
3493 * eval.c: Make symbols static if they're not exported.
3494 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3495 * lisp.h (backtrace_list): Remove decl.
3496
35f08c38
PE
3497 * emacs.c: Make symbols static if they're not exported.
3498 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3499 (fatal_error_code, fatal_error_signal_hook, standard_args):
3500 Now static.
3501 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3502 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3503 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3504 * lisp.h (fatal_error_signal_hook): Remove decl.
3505 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3506
f44bd759
PE
3507 * editfns.c: Move a (normally-unused) function to its only use.
3508 * editfns.c, lisp.h (get_operating_system_release): Remove.
3509 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3510 worth the hassle of breaking this out.
3511
b532497d
PE
3512 * xterm.c: Make symbols static if they're not exported.
3513 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3514 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3515 (x_destroy_window, x_delete_display):
3516 Now static.
3517 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3518 (x_mouse_leave): Remove; unused.
3519 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3520 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3521 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3522 Remove decls.
3523 (x_mouse_leave): Declare only if WINDOWSNT.
3524 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3525 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3526 USE_X_TOOLKIT.
3527
1675728f
PE
3528 * ftxfont.c: Make symbols static if they're not exported.
3529 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3530 HAVE_FREETYPE.
3531 * font.h (ftxfont_driver): Likewise.
3532
e4cebfca
PE
3533 * xfns.c: Make symbols static if they're not exported.
3534 (x_last_font_name, x_display_info_for_name):
3535 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3536 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3537 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3538 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3539 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3540 (last_show_tip_args): Now static.
3541 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3542 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3543 (x_screen_planes): Remove; unused.
3544 * dispextern.h (x_screen_planes): Remove decl.
3545
5bf46f05
PE
3546 * dispnew.c: Make symbols static if they're not exported.
3547 * dispextern.h (redraw_garbaged_frames, scrolling):
3548 (increment_row_positions): Remove.
3549 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3550 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3551 Now static.
3552 (redraw_garbaged_frames): Remove; unused.
3553
435f4c28
PE
3554 * xfaces.c: Make symbols static if they're not exported.
3555 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3556 Remove decls.
3557 * xterm.h (defined_color): Remove decls.
3558 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3559 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3560 (menu_face_changed_default, defined_color, free_realized_face):
3561 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3562 (ascii_face_of_lisp_face): Remove; unused.
3563
8524aef3
PE
3564 * xdisp.c: Make symbols static if they're not exported.
3565 * dispextern.h (scratch_glyph_row, window_box_edges):
3566 (glyph_to_pixel_coords, set_cursor_from_row):
3567 (get_next_display_element, set_iterator_to_next):
3568 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3569 (show_mouse_face): Remove decls
3570 * frame.h (message_buf_print): Likewise.
3571 * lisp.h (pop_message, set_message, check_point_in_composition):
3572 Likewise.
3573 * xterm.h (set_vertical_scroll_bar): Likewise.
3574 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3575 (message_buf_print, scratch_glyph_row, displayed_buffer):
3576 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3577 (get_next_display_element, show_mouse_face, window_box_edges):
3578 (frame_to_window_pixel_xy, check_point_in_composition):
3579 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3580 (glyph_to_pixel_coords): Remove; unused.
3581
16390cd2
PE
3582 * dired.c (file_name_completion): Now static.
3583
3584 * dbusbind.c (xd_in_read_queued_messages): Now static.
3585
a25f4dfa
PE
3586 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3587 * data.c (circular_list_error): Remove.
3588
14a9c8df
PE
3589 * commands.h (last_point_position, last_point_position_buffer):
3590 (last_point_position_window): Remove decls.
3591 * keyboard.c: Make these variables static.
3592
04f2d78b
CB
3593 * coding.h (coding, code_convert_region, encode_coding_gap):
3594 Remove decls.
74ab6df5
PE
3595 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3596 (iso_code_class, detect_coding, code_convert_region): Now static.
3597 (encode_coding_gap): Remove; unused.
3598
38dfbee1
PE
3599 * chartab.c (chartab_chars, chartab_bits): Now static.
3600
a2cb4e63
PE
3601 * charset.h (charset_iso_8859_1): Remove decl.
3602 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3603 Now static.
3604
127198fd
PE
3605 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3606 * ccl.c (Vccl_program_table): Now static.
3607 (check_ccl_update): Remove; unused.
3608
d85b608f
PE
3609 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3610 * category.h: ... from here.
3611 * category.c (check_category_table, set_category_set): Now static.
3612
31cd66f3
PE
3613 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3614 * lisp.h: Remove these decls.
3615
c358e587
PE
3616 * buffer.c (buffer_count): Remove unused var.
3617
e78aecca
PE
3618 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3619 so that it's not optimized away.
3620 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3621 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3622 exported only to the debugger.
3623
e192d7d3 3624 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3625 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3626
92470028
PE
3627 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3628 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3629 was inaccessible from Lisp.
3630 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3631 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3632
244ed907
PE
3633 alloc.c: Import and export fewer symbols, and remove unused items.
3634 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3635 is defined.
3636 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3637 it's not optimized away by whole-program optimization.
3638 (message_enable_multibyte, free_misc): Remove.
3639 (catchlist, handlerlist, mark_backtrace):
3640 Declare only if BYTE_MARK_STACK.
3641 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3642 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3643 (message_enable_multibyte): Remove decl.
3644 (free_misc, interval_free_list, float_block, float_block_index):
3645 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3646 (cons_free_list, last_marked_index):
3647 Now static.
3648 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3649 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3650 (mark_backtrace): Define only if BYTE_MARK_STACK.
3651 * xdisp.c (message_enable_multibyte): Now static.
3652
61c2b50e 3653 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3654 This makes it easier for human readers (and static analyzers)
3655 to see whether these variables are used from other modules.
3656 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3657 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3658 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3659 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3660 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3661 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3662 * xmenu.c, xselect.c:
3663 Declare Q* vars static if they are not used in other modules.
3664 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3665 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3666 Remove decls of unexported vars.
3667 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3668
95c82688
PE
3669 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3670
16a97296
PE
3671 Make Emacs functions such as Fatom 'static' by default.
3672 This makes it easier for human readers (and static analyzers)
3673 to see whether these functions can be called from other modules.
3674 DEFUN now defines a static function. To make the function external
3675 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3676 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3677 (Finit_image_library):
16a97296
PE
3678 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3679 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3680 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3681 Remove decls, since these functions are now static.
3682 (Funintern, Fget_internal_run_time): New decls, since these functions
3683 were already external.
95c82688 3684
16a97296
PE
3685 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3686 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3687 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3688 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3689 * keyboard.c, keymap.c, lread.c:
3690 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3691 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3692 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3693 Mark functions with DEFUE instead of DEFUN,
3694 if they are used in other modules.
3695 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3696 decls for now-static functions.
3697 * buffer.h (Fdelete_overlay): Remove decl.
3698 * callproc.c (Fgetenv_internal): Mark as internal.
3699 * composite.c (Fremove_list_of_text_properties): Remove decl.
3700 (Fcomposition_get_gstring): New forward static decl.
3701 * composite.h (Fcomposite_get_gstring): Remove decl.
3702 * dired.c (Ffile_attributes): New forward static decl.
3703 * doc.c (Fdocumntation_property): New forward static decl.
3704 * eval.c (Ffetch_bytecode): New forward static decl.
3705 (Funintern): Remove extern decl; now in .h file where it belongs.
3706 * fileio.c (Fmake_symbolic_link): New forward static decl.
3707 * image.c (Finit_image_library): New forward static decl.
3708 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3709 * intervals.h (Fprevious_property_change):
3710 (Fremove_list_of_text_properties): Remove decls.
3711 * keyboard.c (Fthis_command_keys): Remove decl.
3712 (Fcommand_execute): New forward static decl.
3713 * keymap.c (Flookup_key): New forward static decl.
3714 (Fcopy_keymap): Now static.
3715 * keymap.h (Flookup_key): Remove decl.
3716 * process.c (Fget_process): New forward static decl.
3717 (Fprocess_datagram_address): Mark as internal.
3718 * syntax.c (Fsyntax_table_p): New forward static decl.
3719 (skip_chars): Remove duplicate decl.
3720 * textprop.c (Fprevious_property_change): New forward static decl.
3721 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3722 Now internal.
3723 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3724 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3725
785bbd42
PE
3726 * editfns.c (Fformat): Remove unreachable code.
3727
8b913b57
AS
37282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3729
3730 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3731 change. (Bug#8496)
3732
a6744a35
EZ
37332011-04-13 Eli Zaretskii <eliz@gnu.org>
3734
3735 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3736 when at ZV. (Bug#8487)
3737
e7974947
AS
37382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3739
baad03f0
AS
3740 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3741 (Bug#8437)
3742 * keyboard.c (parse_tool_bar_item): Likewise.
3743 * sound.c (sound_cleanup, alsa_close): Likewise.
3744 * termcap.c (tgetent): Likewise.
3745 * xfns.c (x_default_font_parameter): Likewise.
3746 * xsettings.c (read_and_apply_settings): Likewise.
3747
e7974947
AS
3748 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3749 (overrun_check_free): Protoize.
3750
28272684
PE
37512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3752
3753 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3754 since callers should never pass a negative size.
3755 Change the signature to match that of plain 'read' and 'write'; see
3756 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3757 * lisp.h: Update prototypes of emacs_write and emacs_read.
3758
11997c76
EZ
37592011-04-11 Eli Zaretskii <eliz@gnu.org>
3760
3761 * xdisp.c (redisplay_window): Don't try to determine the character
3762 position of the scroll margin if the window start point w->startp
e896f03c 3763 is outside the buffer's accessible region. (Bug#8468)
11997c76 3764
8a2cbd72
EZ
37652011-04-10 Eli Zaretskii <eliz@gnu.org>
3766
3767 Fix write-region and its subroutines for buffers > 2GB.
3768 * fileio.c (a_write, e_write): Modify declaration of arguments and
3769 local variables to support buffers larger than 2GB.
3770 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3771
3772 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3773 argument, local variables, and return value.
3774
3775 * lisp.h: Update prototypes of emacs_write and emacs_read.
3776
3777 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3778
4073e537 37792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3780
1ebfdcb6
PE
3781 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3782
b2ded58d
PE
3783 Fix more problems found by GCC 4.6.0's static checks.
3784
7d66342c
PE
3785 * xdisp.c (vmessage): Use a better test for character truncation.
3786
bbf47d44
PE
3787 * charset.c (load_charset_map): <, not <=, for optimization,
3788 and to avoid potential problems with integer overflow.
9248994d 3789 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3790 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3791 * editfns.c (Fformat): Likewise.
1e69125e 3792 * syntax.c (skip_chars): Likewise.
3befa583 3793
e3019616
PE
3794 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3795 This also lets GCC 4.6.0 generate slightly better loop code.
3796
becfa255
PE
3797 * callint.c (Fcall_interactively): <, not <=, for optimization.
3798 (Fcall_interactively): Count the number of arguments produced,
3799 not the number of arguments given. This is simpler and lets GCC
3800 4.6.0 generate slightly better code.
3801
dae0cd48
PE
3802 * ftfont.c: Distingish more carefully between FcChar8 and char.
3803 The previous code passed unsigned char * to a functions like
3804 strlen and xstrcasecmp that expect char *, which does not
3805 conform to the C standard.
3806 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3807 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3808 char * when the C standard requires it.
3809
76032d70
PE
3810 * keyboard.c (read_char): Remove unused var.
3811
eb3f1cc8
PE
3812 * eval.c: Port to Windows vsnprintf (Bug#8435).
3813 Include <limits.h>.
3814 (SIZE_MAX): Define if the headers do not.
3815 (verror): Do not give up if vsnprintf returns a negative count.
3816 Instead, grow the buffer. This ports to Windows vsnprintf, which
3817 does not conform to C99. Problem reported by Eli Zaretskii.
3818 Also, simplify the allocation scheme, by avoiding the need for
3819 calling realloc, and removing the ALLOCATED variable.
3820
70476b54
PE
3821 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3822
12020a9e
PE
3823 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3824 But keep the doprint source code for now, as we might revamp it
3825 and use it again (Bug#8435).
ea6c7ae6
PE
3826 * lisp.h (doprnt): Remove.
3827 * Makefile.in (base_obj): Remove doprnt.o.
3828 * deps.mk (doprnt.o): Remove.
3829
5fdb398c
PE
3830 error: Print 32- and 64-bit integers portably (Bug#8435).
3831 Without this change, on typical 64-bit hosts error ("...%d...", N)
3832 was used to print both 32- and 64-bit integers N, which relied on
3833 undefined behavior.
3834 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3835 New macro.
3836 * lisp.h (error, verror): Mark as printf-like functions.
3837 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3838 Report overflow in size calculations when allocating printf buffer.
3839 Do not truncate output string at its first null byte.
3840 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3841 Truncate the output at a character boundary, since vsnprintf does not
3842 do that.
3843 * charset.c (check_iso_charset_parameter): Convert internal
3844 character to string before calling 'error', since %c now has the
3845 printf meaning.
3846 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3847 overflow when computing char to be passed to 'error'. Do not
3848 pass Lisp_Object to 'error'; pass the integer instead.
3849 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3850 formatted with plain %d.
3851
b189fa66
PE
3852 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3853
bff87ef0
PE
3854 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3855
7e2cac20
PE
3856 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3857
ce4d90b5
PE
3858 * xterm.c (x_catch_errors): Remove duplicate declaration.
3859
266c9547
PE
3860 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3861
79c49ad2
PE
3862 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3863
368f4090
JM
38642011-04-10 Jim Meyering <meyering@redhat.com>
3865
3866 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3867 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3868 return ssize_t not "int", and use size_t as the buffer length.
3869 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3870 * gnutls.h: Update declarations.
3871 * process.c (read_process_output): Use ssize_t, to match.
3872 (send_process): Likewise.
3873
a32d4040
CY
38742011-04-09 Chong Yidong <cyd@stupidchicken.com>
3875
3876 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3877
8546720e 38782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3879
04f2d78b
CB
3880 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3881 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3882
8546720e
GM
3883 * xterm.c (handle_one_xevent):
3884 * xmenu.c (create_and_show_popup_menu):
3885 * xselect.c (x_decline_selection_request)
3886 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3887
0a2f5c1a 38882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3889
3890 Fix some uses of `int' instead of EMACS_INT.
3891 * search.c (string_match_1, fast_string_match)
3892 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3893 (scan_buffer, find_next_newline_no_quit)
3894 (find_before_next_newline, search_command, Freplace_match)
3895 (Fmatch_data): Make some `int' variables be EMACS_INT.
3896
3897 * xdisp.c (display_count_lines): 3rd argument and return value now
3898 EMACS_INT. All callers changed.
3899 (pint2hrstr): Last argument is now EMACS_INT.
3900
3901 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3902 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3903 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3904 (decode_coding_utf_16, decode_coding_emacs_mule)
3905 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3906 (decode_coding_ccl, decode_coding_charset)
3907 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3908 (decode_coding_iso_2022, decode_coding_emacs_mule)
3909 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3910 <char_offset, last_offset>: Declare EMACS_INT.
3911 (encode_coding_utf_8, encode_coding_utf_16)
3912 (encode_coding_emacs_mule, encode_invocation_designation)
3913 (encode_designation_at_bol, encode_coding_iso_2022)
3914 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3915 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3916 Declare EMACS_INT.
3917 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3918 (encode_invocation_designation): Last argument P_NCHARS is now
3919 EMACS_INT.
3920 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3921 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3922
3923 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3924 All users changed.
3925
3926 * ccl.c (Fccl_execute_on_string): Declare some variables
3927 EMACS_INT.
3928
8546720e 39292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3930
3931 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3932
4e19a977
CS
39332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3934
3935 * process.c (Fformat_network_address): Doc fix.
3936
87302331
R
39372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3938
3939 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3940
cbb59342
CY
39412011-04-08 Chong Yidong <cyd@stupidchicken.com>
3942
3943 * keyboard.c (read_char): Call Lisp function help-form-show,
3944 instead of using internal_with_output_to_temp_buffer.
3945 (Qhelp_form_show): New var.
e0d38eeb 3946 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3947
3948 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3949
3950 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3951
e67a13ab
CY
39522011-04-06 Chong Yidong <cyd@stupidchicken.com>
3953
04f2d78b
CB
3954 * process.c (Flist_processes): Remove to Lisp.
3955 (list_processes_1): Delete.
e67a13ab 3956
973f782d
EZ
39572011-04-06 Eli Zaretskii <eliz@gnu.org>
3958
7c106b1e
EZ
3959 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3960
973f782d
EZ
3961 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3962
41cf7d1a 39632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3964
ca23cc88
PE
3965 Fix more problems found by GCC 4.6.0's static checks.
3966
f390e2d5
PE
3967 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3968
42eea0d0
PE
3969 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3970
b69769da 3971 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3972
f9541e84
PE
3973 * xdisp.c (vmessage): Mark as a printf-like function.
3974
13841b55
PE
3975 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3976
c136c10f
PE
3977 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3978
5e2d4a30
PE
3979 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3980 printf-like functions.
3981 (tiff_load): Add casts to remove these marks before passing them
3982 to system-supplied API.
3983
583f48b9
PE
3984 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3985
b25d760e
PE
3986 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3987 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3988 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3989 directly, rather than having caller test rule sign. This avoids
3990 some unnecessary tests.
3991 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3992 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3993 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3994
bc7b6697 3995 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3996 (xfont_open): Avoid unnecessary tests.
bc7b6697 3997
27ccc379
PE
3998 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3999
dcd5c89a
PE
4000 * composite.h, composite.c (composition_gstring_put_cache):
4001 Use EMACS_INT, not int, for length.
4002
b13a45c6
PE
4003 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4004 breaking out part of COMPOSITION_DECODE_RULE.
4005 (COMPOSITION_DECODE_RULE): Use it.
4006 * composite.c (get_composition_id): Remove unused local vars,
4007 by using the new macro.
4008
1e792e4d
PE
4009 * textprop.c (set_text_properties_1): Change while to do-while,
4010 since the condition is always true at first.
4011
dc6c6455 4012 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4013 (interval_deletion_adjustment): Return unsigned value.
4014 All uses changed.
dc6c6455 4015
aba7731a
PE
4016 * process.c (list_processes_1, create_pty, read_process_output):
4017 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4018 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4019 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4020 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4021 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4022
fdfc4bf3
PE
4023 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4024
fca8fe46 4025 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4026 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4027
06a0259a 4028 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4029 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4030 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4031
e7b9e80f
PE
4032 * print.c (print_error_message): Avoid int overflow.
4033
56201685
PE
4034 * font.c (font_list_entities): Redo for clarity,
4035 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4036
78834453 4037 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4038 (font_score): Avoid potential overflow in diff calculation.
78834453 4039
0bc0b309 4040 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4041 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4042
e610eaca
PE
4043 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4044
b895abce
PE
4045 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4046 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4047 can always succeed if overflow has undefined behavior.
4048
1f1d9321 4049 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4050 (wordify): Omit three unnecessary tests.
1f1d9321 4051
c59478bc
PE
4052 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4053 All callers changed. This avoids the need for an unused var.
4054
79b73827
PE
4055 * casefiddle.c (casify_region): Remove var that is set but not used.
4056
a4db5dfe
PE
4057 * dired.c (file_name_completion): Remove var that is set but not used.
4058
43aae36e
PE
4059 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4060
2a47c44d 4061 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4062 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4063
a37c69bf
PE
4064 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4065 Check for integer overflow on size calculations.
4066
328ab8e7
PE
4067 * buffer.c (Fprevious_overlay_change): Remove var that is set
4068 but not used.
4069
e5a2a5cb
PE
4070 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4071 Remove vars that are set but not used.
8d84a6eb 4072 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4073 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4074
a60e5f68
PE
4075 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4076
f661cb61 4077 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4078 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4079
f0397f5a
PE
4080 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4081 that are set but not used.
4082
8664db06 4083 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4084 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4085
6abdaa4a
PE
4086 * xselect.c (x_get_local_selection, x_handle_property_notify):
4087 Remove vars that are set but not used.
4088
0ce7538d 4089 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4090 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4091
9ae848fc
PE
4092 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4093 Remove var that is set but not used.
0b918413
PE
4094 (scroll_bar_windows_size): Now size_t, not int.
4095 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4096 Check for overflow.
9ae848fc 4097
a5a62657
PE
4098 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4099 (map_tty_color) [!defined MSDOS]: Likewise.
4100
5c5cdd39
PE
4101 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4102
66ebf983
PE
4103 * coding.c: Remove vars that are set but not used.
4104 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4105 All callers changed.
4106 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4107 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4108 (decode_coding_charset): Remove vars that are set but not used.
4109
1be4d761
PE
4110 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4111 that is set but not used.
4112
47553fa8
PE
4113 * print.c (print_object): Remove var that is set but not used.
4114
1f7196bf 4115 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4116 The gnulib version avoids calling malloc in the usual case,
4117 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4118 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4119 * filelock.c (current_lock_owner): Likewise.
4120 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4121 * sysdep.c: Include allocator.h, careadlinkat.h.
4122 (emacs_no_realloc_allocator): New static constant.
4123 (emacs_readlink): New function.
fdb61804
PE
4124 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4125 ../lib/careadlinkat.h.
d1fdcab7 4126
f84c17c7
SM
41272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4128
4129 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4130 first non-nil return value).
4131
ef3862ad
JD
41322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4133
4134 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4135 if not defined (Bug#8403).
4136
376a7006
JB
41372011-04-02 Juanma Barranquero <lekktu@gmail.com>
4138
4139 * xdisp.c (display_count_lines): Remove parameter `start',
4140 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4141 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4142 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4143 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4144 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4145 and thereabouts. All callers changed.
4146 (get_per_char_metric): Remove parameter `f', unused since
4147 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4148
6ca3801d
JM
41492011-04-02 Jim Meyering <meyering@redhat.com>
4150
4151 do not dereference NULL upon failed strdup
4152 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4153 (ns_get_family): Likewise.
4154
d8e2b5ba
JB
41552011-04-02 Juanma Barranquero <lekktu@gmail.com>
4156
4157 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4158
8c74fcbd
JD
41592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4160
4161 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4162 later (Bug#8403).
4163
7200d79c
SM
41642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4165
03408648 4166 Add lexical binding.
7200d79c 4167
03408648
SM
4168 * window.c (Ftemp_output_buffer_show): New fun.
4169 (Fsave_window_excursion):
4170 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4171
4172 * lread.c (lisp_file_lexically_bound_p): New function.
4173 (Fload): Bind Qlexical_binding.
4174 (readevalloop): Remove `evalfun' arg.
4175 Bind Qinternal_interpreter_environment.
4176 (Feval_buffer): Bind Qlexical_binding.
4177 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4178 Mark as dynamic.
4179 (syms_of_lread): Declare `lexical-binding'.
4180
4181 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4182
4183 * keyboard.c (eval_dyn): New fun.
4184 (menu_item_eval_property): Use it.
ca105506
SM
4185
4186 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4187
03408648
SM
4188 * fns.c (concat, mapcar1): Accept byte-code-functions.
4189
4190 * eval.c (Fsetq): Handle lexical vars.
4191 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4192 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4193 (FletX, Flet): Obey lexical binding.
4194 (Fcommandp): Handle closures.
4195 (Feval): New `lexical' arg.
4196 (eval_sub): New function extracted from Feval. Use it almost
4197 everywhere where Feval was used. Look up vars in lexical env.
4198 Handle closures.
4199 (Ffunctionp): Move from subr.el.
4200 (Ffuncall): Handle closures.
4201 (apply_lambda): Remove `eval_flags'.
4202 (funcall_lambda): Handle closures and new byte-code-functions.
4203 (Fspecial_variable_p): New function.
4204 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4205 but without exporting it to Lisp.
23aba0ea 4206
23aba0ea 4207 * doc.c (Fdocumentation, store_function_docstring):
03408648 4208 * data.c (Finteractive_form): Handle closures.
23aba0ea 4209
03408648
SM
4210 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4211 interactive spec.
ba83908c 4212
04f2d78b
CB
4213 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4214 New byte-codes.
03408648
SM
4215 (exec_byte_code): New function extracted from Fbyte_code to handle new
4216 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4217
03408648 4218 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4219
03408648 4220 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4221
e2abce01
JB
42222011-03-31 Juanma Barranquero <lekktu@gmail.com>
4223
4224 * xdisp.c (redisplay_internal): Fix prototype.
4225
63696a73 42262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4227
63696a73 4228 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4229 (try_scrolling): Use it when setting scroll_limit.
4230 Limit scrolling to 100 screen lines.
63696a73
EZ
4231 (redisplay_window): Even when falling back on "recentering",
4232 position point in the window according to scroll-conservatively,
4233 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4234
4235 (try_scrolling): When point is above the window, allow searching
4236 as far as scroll_max, or one screenful, to compute vertical
4237 distance from PT to the scroll margin position. This prevents
4238 try_scrolling from unnecessarily failing when
4239 scroll-conservatively is set to a value slightly larger than the
4240 window height. Clean up the case of PT below the margin at bottom
4241 of window: scroll_max can no longer be INT_MAX. When aggressive
4242 scrolling is in use, don't let point enter the opposite scroll
4243 margin as result of the scroll.
4244 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4245 threshold of 100 lines for never-recentering scrolling.
4246
e4cc2dfc
JB
42472011-03-31 Juanma Barranquero <lekktu@gmail.com>
4248
4249 * dispextern.h (move_it_by_lines):
4250 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4251 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4252 (message_log_check_duplicate): Remove parameters `prev_bol' and
4253 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4254 (redisplay_internal): Remove parameter `preserve_echo_area',
4255 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4256
4257 * indent.c (Fvertical_motion):
4258 * window.c (window_scroll_pixel_based, Frecenter):
4259 Don't pass `need_y_p' to `move_it_by_lines'.
4260
1c470562
SM
42612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4262
44f230aa
SM
4263 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4264 steal a few bits to be more compact.
4265 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4266 Remove unneeded casts.
4267
1c470562
SM
4268 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4269
888adce9
ZK
42702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4271
4272 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4273 binding" message (bug#7967).
4274
f838ed7b
PE
42752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4276
77861b95
PE
4277 Fix more problems found by GCC 4.6.0's static checks.
4278
de6dbc14
PE
4279 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4280 Remove unused local var.
4281
f838ed7b
PE
4282 * editfns.c (Fmessage_box): Remove unused local var.
4283
792c7b2b
PE
4284 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4285 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4286 Omit unused local vars.
c499e557 4287 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4288 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4289 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4290 Omit unused local var.
4291
ba0165e1
PE
4292 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4293 Don't assume string length fits in int.
32ad8845 4294 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4295 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4296
3c59b4c9
PE
4297 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4298 instead of alloca (Bug#8344).
4299
a3eed478 4300 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4301 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4302
eb4d412d
PE
4303 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4304
1658b401
PE
4305 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4306 concerns.
4307
4308 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4309
4310 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4311
9a2c6e05
PE
4312 * keyboard.c (syms_of_keyboard): Use the same style as later
4313 in this function when indexing through an array. This also
4314 works around GCC bug 48267.
4315
03d0a109
PE
4316 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4317
44f730c8
PE
4318 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4319
fe75f926
PE
4320 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4321 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4322
ffa8c828
PE
4323 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4324 This avoids undefined behavior on integer overflow, and is a bit
4325 more convenient anyway since it is compared to a size_t variable.
4326
c5101a77
PE
4327 Variadic C functions now count arguments with size_t, not int.
4328 This avoids an unnecessary limitation on 64-bit machines, which
4329 caused (substring ...) to crash on large vectors (Bug#8344).
4330 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4331 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4332 All variadic functions and their callers changed accordingly.
c5101a77
PE
4333 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4334 * data.c (arith_driver, float_arith_driver): Likewise.
4335 * editfns.c (general_insert_function): Likewise.
4336 * eval.c (struct backtrace.nargs, interactive_p)
4337 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4338 (funcall_lambda, mark_backtrace): Likewise.
4339 * fns.c (concat): Likewise.
4340 * frame.c (x_set_frame_parameters): Likewise.
4341 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4342 0 if not found, not -1. All callers changed.
4343
dd3f25f7
PE
4344 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4345 (stack_copy_size): Now size_t, not int.
4346 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4347
461c2ab9
JB
43482011-03-28 Juanma Barranquero <lekktu@gmail.com>
4349
4350 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4351 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4352 All callers changed.
4353
4354 * lisp.h (multibyte_char_to_unibyte):
4355 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4356 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4357 * character.h (CHAR_TO_BYTE8):
4358 * cmds.c (internal_self_insert):
4359 * editfns.c (general_insert_function):
4360 * keymap.c (push_key_description):
4361 * search.c (Freplace_match):
4362 * xdisp.c (message_dolog, set_message_1): All callers changed.
4363
f6d62986
SM
43642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4365
4366 * keyboard.c (safe_run_hook_funcall): New function.
4367 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4368 don't set the hook to nil, but remove the offending function instead.
4369 (Qcommand_hook_internal): Remove, unused.
4370 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4371 Vcommand_hook_internal.
4372
4373 * eval.c (enum run_hooks_condition): Remove.
4374 (funcall_nil, funcall_not): New functions.
4375 (run_hook_with_args): Call each function through a `funcall' argument.
4376 Remove `cond' argument, now redundant.
4377 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4378 (Frun_hook_with_args_until_failure): Adjust accordingly.
4379 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4380
1db5b1ad
JB
43812011-03-28 Juanma Barranquero <lekktu@gmail.com>
4382
4383 * dispextern.h (string_buffer_position): Remove declaration.
4384
4385 * print.c (strout): Remove parameter `multibyte', unused since
4386 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4387
4388 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4389 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4390 All callers changed.
4391
4392 * w32.c (_wsa_errlist): Use braces for struct initializers.
4393
4394 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4395 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4396 All callers changed.
4397 (string_buffer_position): Likewise. Also, make static (it's never
4398 used outside xdisp.c).
4399 (cursor_row_p): Remove parameter `w', unused since
4400 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4401 (decode_mode_spec): Remove parameter `precision', introduced during
4402 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4403 All callers changed.
4404
5ffb62aa
JD
44052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4406
4407 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4408
461c2ab9 44092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4410
4411 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4412 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4413 (ns_update_auto_hide_menu_bar): New functions.
4414 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4415 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4416 ns_constrain_all_frames.
4417 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4418 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4419
5c380ffb
JD
44202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4421
4422 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4423
9af30bdf
GM
44242011-03-27 Glenn Morris <rgm@gnu.org>
4425
4426 * syssignal.h: Replace RETSIGTYPE with void.
4427 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4428 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4429 Replace SIGTYPE with void everywhere.
4430 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4431 * s/template.h (SIGTYPE): Remove commented out definition.
4432
e2abce01
JB
44332011-03-26 Eli Zaretskii <eliz@gnu.org>
4434
4435 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4436 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4437
f868cd8a
JB
44382011-03-26 Juanma Barranquero <lekktu@gmail.com>
4439
59eb0929
JB
4440 * w32.c (read_unc_volume): Use parameter `henum', instead of
4441 global variable `wget_enum_handle'.
4442
4443 * keymap.c (describe_vector): Remove parameters `indices' and
4444 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4445 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4446
f868cd8a
JB
4447 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4448
4449 * keyboard.c (timer_check): Remove parameter `do_it_now',
4450 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4451 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4452 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4453
4454 * keyboard.c (read_char):
4455 * w32menu.c (w32_menu_display_help):
4456 * xmenu.c (show_help_event, menu_help_callback):
4457 Adjust calls to `show_help_echo'.
4458
4459 * gtkutil.c (xg_maybe_add_timer):
4460 * keyboard.c (readable_events):
4461 * process.c (wait_reading_process_output):
4462 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4463
4464 * insdel.c (adjust_markers_gap_motion):
4465 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4466 (gap_left, gap_right): Don't call it.
4467
2ecf6fdb
CY
44682011-03-25 Chong Yidong <cyd@stupidchicken.com>
4469
4470 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4471 incurred during fontification.
4472
6b1f9ba4
JB
44732011-03-25 Juanma Barranquero <lekktu@gmail.com>
4474
4475 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4476 (DEFVAR_PER_BUFFER): Don't pass it.
4477
4478 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4479 (scrolling_window): Don't pass it.
4480
0f4a96b5
JB
44812011-03-25 Juanma Barranquero <lekktu@gmail.com>
4482
4483 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4484
4485 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4486 and `suffix'.
4487 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4488 of variables specific to SELinux and computation of `encoded_absname'.
4489
4490 * image.c (XPutPixel): Remove unused variable `height'.
4491
4492 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4493
4494 * unexw32.c (get_section_info): Remove unused variable `section'.
4495
4496 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4497 (system_process_attributes): Remove unused variable `sess'.
4498 (sys_read): Remove unused variable `err'.
4499
4500 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4501 (w32_wnd_proc): Remove unused variable `isdead'.
4502 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4503 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4504 (x_create_tip_frame): Remove unused variable `tem'.
4505
4506 * w32inevt.c (w32_console_read_socket):
4507 Remove unused variable `no_events'.
4508
4509 * w32term.c (x_draw_composite_glyph_string_foreground):
4510 Remove unused variable `width'.
4511
1149507c
JB
45122011-03-24 Juanma Barranquero <lekktu@gmail.com>
4513
4514 * w32term.c (x_set_glyph_string_clipping):
4515 Don't pass uninitialized region to CombineRgn.
4516
9c88f339
JB
45172011-03-23 Juanma Barranquero <lekktu@gmail.com>
4518
4519 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4520 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4521 (Fx_close_connection): Remove unused variable `i'.
4522
4523 * w32font.c (w32font_draw): Return number of glyphs.
4524 (w32font_open_internal): Remove unused variable `i'.
4525 (w32font_driver): Add missing initializer.
4526
4527 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4528 (fill_in_menu): Remove unused variable `items_added'.
4529
4530 * w32term.c (last_mouse_press_frame): Remove static global variable.
4531 (w32_clip_to_row): Remove unused variable `f'.
4532 (x_delete_terminal): Remove unused variable `i'.
4533
4534 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4535 (NOTHING): Remove unused static global variable.
4536 (uniscribe_check_otf): Remove unused variable `table'.
4537 (uniscribe_font_driver): Add missing initializers.
4538
dee091a3
JD
45392011-03-23 Julien Danjou <julien@danjou.info>
4540
4541 * term.c (Fsuspend_tty, Fresume_tty):
4542 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4543 * window.c (temp_output_buffer_show):
4544 * insdel.c (signal_before_change):
4545 * frame.c (Fhandle_switch_frame):
4546 * fileio.c (Fdo_auto_save):
4547 * emacs.c (Fkill_emacs):
4548 * editfns.c (save_excursion_restore):
4549 * cmds.c (internal_self_insert):
4550 * callint.c (Fcall_interactively):
4551 * buffer.c (Fkill_all_local_variables):
4552 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4553 Use Frun_hooks.
0f4a96b5 4554 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4555 unconditionnaly since it does the check itself.
4556
2c520ab5 45572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4558
c9c49752
PE
4559 Fix more problems found by GCC 4.5.2's static checks.
4560
8abc3f12
PE
4561 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4562 the first time through the loop, since we know p0 < p1 then.
4563 This also avoids a gcc -Wstrict-overflow warning.
4564
a2d26660
PE
4565 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4566 leading to a memory leak, possible in functions like
4567 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4568 of objects (Bug#8318).
a2d26660 4569
916c72e9
PE
4570 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4571 that could (at least in theory) be that large.
4572
19ab8a18
PE
4573 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4574 This is less likely to overflow, and avoids undefined behavior if
4575 overflow does occur. All callers changed. Use strtoul to scan
4576 for the unsigned long integer.
b7cbbd6f
PE
4577 (pint2hrstr): Simplify and tune code slightly.
4578 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4579
f0641eff
PE
4580 * scroll.c (do_scrolling): Work around GCC bug 48228.
4581 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4582
7f650bb9
PE
4583 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4584 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4585 (validate_x_resource_name): Simplify count usage.
4586 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4587
37dd57d1
PE
4588 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4589 fail (Bug#8306).
81e56e61 4590
699979fc 4591 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4592
401bf9b4
PE
4593 * process.c (Fmake_network_process): Use socklen_t, not int,
4594 where POSIX says socklen_t is required in portable programs.
4595 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4596 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4597 (Fmake_network_process, server_accept_connection):
4598 (wait_reading_process_output, read_process_output):
4599 Likewise.
4600
b93aacde
PE
4601 * process.c: Rename or move locals to avoid shadowing.
4602 (list_processes_1, Fmake_network_process):
4603 (read_process_output_error_handler, exec_sentinel_error_handler):
4604 Rename or move locals.
4dc343ee 4605 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4606 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4607 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4608 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4609 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4610
af8a867c 4611 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4612 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4613 Include tparam.h instead, since it declares them.
af8a867c
PE
4614 * cm.h (PC): Remove extern decl; tparam.h now does this.
4615 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4616 * terminfo.c: Include tparam.h, to check interfaces.
4617 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4618 (tparam): Adjust signature to match interface in tparam.h;
4619 this removes some undefined behavior. Check that outstring and len
4620 are zero, which they always are with Emacs.
4621 * tparam.h (PC, BC, UP): New extern decls.
4622
0248044d 4623 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4624 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4625
8ff096c1 4626 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4627 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4628 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4629 (ftfont_list): Remove unused local.
49eaafba
PE
4630 (get_adstyle_property, ftfont_pattern_entity):
4631 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4632 Rename locals to avoid shadowing.
8ff096c1 4633
e2be39f6
PE
4634 * xfont.c (xfont_list_family): Mark var as initialized.
4635
c9735e30
PE
4636 * xml.c (make_dom): Now static.
4637
8f5201ae
PE
4638 * composite.c (composition_compute_stop_pos): Rename local to
4639 avoid shadowing.
b246f932
PE
4640 (composition_reseat_it): Remove unused locals.
4641 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4642 (composition_update_it): Mark var as initialized.
11b61122
PE
4643 (find_automatic_composition): Mark vars as initialized,
4644 with a FIXME (Bug#8290).
8f5201ae 4645
760fbc2c
PE
4646 character.h: Rename locals to avoid shadowing.
4647 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4648 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4649 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4650 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4651 to avoid shadowing.
4652
ff08eb85
PE
4653 * textprop.c (property_change_between_p): Remove; unused.
4654
fc7bf025
PE
4655 * intervals.c (interval_start_pos): Now static.
4656
235d7abc
PE
4657 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4658
44f230aa
SM
4659 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4660 Rename locals to avoid shadowing.
3e7d6594 4661
50060332
PE
4662 * sound.c (wav_play, au_play, Fplay_sound_internal):
4663 Fix pointer signedness.
d01f234b 4664 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4665 (wav_play): Initialize a variable to 0, to prevent undefined
4666 behavior (Bug#8278).
50060332 4667
c4fc4e30
PE
4668 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4669
918436ed
PE
4670 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4671
c939f91b
PE
4672 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4673 clobbering (Bug#8298).
b9c7f648
PE
4674 * sysdep.c (sys_subshell): Likewise.
4675 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4676
6bd8c144
PE
4677 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4678 This should get cleaned up, so that child_setup has the
4679 same signature on all platforms.
4680
7710357c 4681 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4682 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4683
c59da222
CY
46842011-03-22 Chong Yidong <cyd@stupidchicken.com>
4685
4686 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4687 not to be necessary, and produces flickering.
4688
66b87493
GM
46892011-03-20 Glenn Morris <rgm@gnu.org>
4690
4691 * config.in: Remove file.
4692
45b6f6d5
JB
46932011-03-20 Juanma Barranquero <lekktu@gmail.com>
4694
4695 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4696 are now in src/globals.h.
4697 (syms_of_minibuf): Remove spurious & from previous change.
4698
3ec03f7e
LL
46992011-03-20 Leo <sdl.web@gmail.com>
4700
4701 * minibuf.c (completing-read-function): New variable.
4702 (completing-read-default): Rename from completing-read.
4703 (completing-read): Call completing-read-function.
4704
b14e3e21
CY
47052011-03-19 Juanma Barranquero <lekktu@gmail.com>
4706
4707 * xfaces.c (Fx_load_color_file):
4708 Read color file from absolute filename (bug#8250).
4709
f2b726e6
JB
47102011-03-19 Juanma Barranquero <lekktu@gmail.com>
4711
4712 * makefile.w32-in: Update dependencies.
4713
09f6ff02
EZ
47142011-03-17 Eli Zaretskii <eliz@gnu.org>
4715
4716 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4717
29a6015a
PE
47182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4719
a3a6c54e
PE
4720 Fix more problems found by GCC 4.5.2's static checks.
4721
b766f867
PE
4722 * process.c (make_serial_process_unwind, send_process_trap):
4723 (sigchld_handler): Now static.
4724
be02381c
PE
4725 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4726 That way, the code declares only the vars that it needs.
4727 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4728 * s/cygwin.h (PTY_ITERATION): Likewise.
4729 * s/darwin.h (PTY_ITERATION): Likewise.
4730 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4731
57048744
PE
4732 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4733 * process.c (allocate_pty): Don't declare stb unless it's needed.
4734
7914961c 4735 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4736 (CONSTANTLIM): Remove; unused.
4737 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4738 Define only if needed.
7914961c 4739
b3967b18
PE
4740 * unexelf.c (unexec): Name an expression,
4741 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4742 Use a different way to cause a compilation error if anyone uses
4743 n rather than nn, a way that does not involve shadowing.
73366a00 4744 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4745
29a6015a
PE
4746 * deps.mk (unexalpha.o): Remove; unused.
4747
43cfc33e 4748 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4749 * unexec.h: New file.
ce701a33
PE
4750 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4751 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4752 Depend on unexec.h.
4753 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4754 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4755 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4756 Change as necessary to match prototype in unexec.h.
ce701a33 4757
01f44d5a
PE
4758 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4759 shadowing.
4f63c6bb 4760 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4761
a6670b0b
PE
4762 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4763 Rename locals to avoid shadowing.
4764
cef2010d 4765 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4766 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4767
d4d7173a
PE
4768 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4769
f08b802a
PE
4770 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4771 warning when compiling print.c.
4772
3ddb0639
PE
4773 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4774 instead of using an uninitialized var.
5ad03b97 4775 (font_sort_entities): Mark var as initialized.
3ddb0639 4776
170a2692
PE
4777 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4778
e663c700
PE
4779 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4780 pointers to constants.
89bc529a 4781 (font_parse_fcname): Remove unused vars.
7b81e2d0 4782 (font_delete_unmatched): Now static.
ea838e10 4783 (font_get_spec): Remove; unused.
13a547c6
PE
4784 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4785 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4786 Rename or move locals to avoid shadowing.
e663c700 4787
2a80c887 4788 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4789 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4790
1384fa33 4791 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4792 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4793
8b2c52e9
PE
4794 * alloc.c (mark_backtrace): Move decl from here ...
4795 * lisp.h: ... to here, so that it can be checked.
4796
475545b5 4797 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4798 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4799 (lisp_indirect_variable): Name an expression,
4800 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4801 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4802
b1349114 4803 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4804 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4805 Use const pointer when appropriate.
b1349114 4806
a2928364
PE
4807 * lisp.h (get_system_name, get_operating_system_release):
4808 Move decls here, to check interfaces.
4809 * process.c (get_operating_system_release): Move decl to lisp.h.
4810 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4811 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4812 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4813 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4814 (Fformat_time_string, Fencode_time, Finsert_char):
4815 (Ftranslate_region_internal, Fformat):
4816 Rename or remove local vars to avoid shadowing.
9710023e 4817 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4818
a415e694
PE
4819 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4820 avoid shadowing.
4821
8ef4622d
PE
4822 * lisp.h (eassert): Check that the argument compiles, even if
4823 ENABLE_CHECKING is not defined.
4824
946f9a5b
PE
4825 * data.c (Findirect_variable): Name an expression, to avoid
4826 gcc -Wbad-function-cast warning.
112396d6 4827 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4828 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4829 (Fmake_variable_buffer_local, Fmake_local_variable):
4830 Mark variables as initialized.
52746918 4831 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4832
e5aab7e7 4833 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4834 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4835 Rename locals to avoid shadowing.
dff45157
PE
4836 (mark_stack): Move local variables into the #ifdef region where
4837 they're used.
7bc26fdb
PE
4838 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4839 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4840 needed otherwise.
4841 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4842 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4843 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4844
e5aab7e7
PE
4845 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4846 avoids undefined behavior in theory.
4847
4da60324
PE
4848 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4849
88043301
PE
4850 Use functions, not macros, for up- and down-casing (Bug#8254).
4851 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4852 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4853 to use the following functions instead of these macros.
4854 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4855 EMACS_INT, since callers assume the returned value fits in int.
4856 (upcase1): Likewise, for UPCASE_TABLE.
4857 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4858 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4859 the race-condition problem in the old DOWNCASE.
88043301 4860
19ed5445
PE
4861 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4862 Rename locals to avoid shadowing.
4863 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4864 (regex_compile, re_search_2, re_match_2_internal):
4865 Remove unused local vars.
952db0d7
PE
4866 (FREE_VAR): Rewrite so as not to use empty "else",
4867 which gcc can warn about.
da053e48 4868 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4869 (RETALLOC_IF): Define only if needed.
4870 (WORDCHAR_P): Likewise. This one is never needed, but is used
4871 only in a comment talking about a compiler bug, so put inside
4872 the #if 0 of that comment.
4873 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4874 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4875 Remove; unused.
19ed5445 4876
1f3561e4 4877 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4878 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4879 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4880
ded6f8f7
PE
4881 * search.c (simple_search): Remove unused var.
4882
dbd37a95
PE
4883 * dired.c (compile_pattern): Move decl from here ...
4884 * lisp.h: ... to here, so that it can be checked.
4885 (struct re_registers): New forward decl.
4886
7e47afad
PE
4887 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4888
85f24f61
PE
4889 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4890 All uses changed.
4891 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4892 Rename locals to avoid shadowing.
5671df8f 4893 (Fvertical_motion): Mark locals as initialized.
85f24f61 4894
181aa2be 4895 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4896 (casify_region): Mark local as initialized.
181aa2be 4897
930d429c
PE
4898 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4899
7082eac6
PE
4900 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4901 New macros, so that the caller can use some names other than
4902 gcpro1, gcpro2, etc.
4903 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4904 of the new macros.
4905 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4906 argument, for consistency with GCPRO2_VAR, etc: it is now the
4907 prefix of the variable, not the variable itself. All uses
4908 changed.
38b2c076
PE
4909 * dired.c (directory_files_internal, file_name_completion):
4910 Rename locals to avoid shadowing.
4911
15206ed9
PE
4912 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4913 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4914 dired.c's scmp function, had undefined behavior.
4915 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4916 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4917 * buffer.h: ... to here, because these macros use current_buffer,
4918 and the new implementation with inline functions needs to have
4919 current_buffer in scope now, rather than later when the macros
4920 are used.
4921 (downcase, upcase1): New static inline functions.
4922 (DOWNCASE, UPCASE1): Reimplement using these functions.
4923 This avoids undefined behavior in expressions like
4924 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4925 from race conditions in accessing the global variables
4926 case_temp1 and case_temp2.
4927 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4928 * lisp.h (case_temp1, case_temp2): Remove their decls.
4929 * character.h (ASCII_CHAR_P): Move from here ...
4930 * lisp.h: ... to here, so that the inline functions mentioned
4931 above can use them.
4932
4a6bea26
PE
4933 * dired.c (directory_files_internal_unwind): Now static.
4934
f14b7e14
PE
4935 * fileio.c (file_name_as_directory, directory_file_name):
4936 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4937 Now static.
2893f146
PE
4938 (file_name_as_directory): Use const pointers when appropriate.
4939 (Fexpand_file_name): Likewise. In particular, newdir might
4940 point at constant storage, so make it a const pointer.
fd4ead52 4941 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4942 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4943 signedness issues.
f839df0c
PE
4944 (Fset_file_times, Finsert_file_contents, auto_save_error):
4945 Rename locals to avoid shadowing.
f14b7e14 4946
5716756e 4947 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4948 (Ftry_completion, Fall_completions): Rename or remove locals
4949 to avoid shadowing.
5716756e 4950
b4c3046a
PE
4951 * marker.c (bytepos_to_charpos): Remove; unused.
4952
b45db522
PE
4953 * lisp.h (verify_bytepos, count_markers): New decls,
4954 so that gcc does not warn that these functions aren't declared.
4955
85876d07
PE
4956 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4957 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4958 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4959 (copy_text): Remove unused local var.
85876d07 4960
03d78a21 4961 * filelock.c (within_one_second): Now static.
b3dd38ab 4962 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4963
5df8f01b
PE
4964 * buffer.c (fix_overlays_before): Mark locals as initialized.
4965 (fix_start_end_in_overlays): Likewise. This function should be
4966 simplified by using pointers-to-pointers, but that's a different
4967 matter.
b1d876f1 4968 (switch_to_buffer_1): Now static.
8f54f30a
PE
4969 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4970 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4971
a70072c9 4972 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4973 Fix pointer signedness issue.
edced198
PE
4974 (sys_subshell): Mark local as volatile if checking for lint,
4975 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4976 (MAXPATHLEN): Define only if needed.
a70072c9 4977
a0977c44
PE
4978 * process.c (serial_open, serial_configure): Move decls from here ...
4979 * systty.h: ... to here, so that they can be checked.
4980
a884fdcc
PE
4981 * fns.c (get_random, seed_random): Move extern decls from here ...
4982 * lisp.h: ... to here, so that they can be checked.
4983
604efe86 4984 * sysdep.c (reset_io): Now static.
b8950c94 4985 (wait_for_termination_signal): Remove; unused.
604efe86 4986
38fc62d9
PE
4987 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4988 (copy_keymap_item, append_key, push_text_char_description):
4989 Now static.
1004a21a 4990 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4991 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4992 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4993 (describe_map_tree):
4994 Rename locals to avoid shadowing.
38fc62d9 4995
2f2650da
PE
4996 * keyboard.c: Declare functions static if they are not used elsewhere.
4997 (echo_char, echo_dash, cmd_error, top_level_2):
4998 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4999 (read_char, kbd_buffer_get_event, make_lispy_position):
5000 (make_lispy_event, make_lispy_movement, apply_modifiers):
5001 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5002 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5003 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5004 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5005 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5006
a053e86c 5007 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5008 (mark_kboards): Move decl here ...
5009 * alloc.c (mark_kboards): ... from here.
a053e86c 5010
4752793e
PE
5011 * lisp.h (force_auto_save_soon): New decl.
5012
74f10ca7 5013 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5014 (DEFINE_DUMMY_FUNCTION): New macro.
5015 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5016 Use it.
c03cd23f
PE
5017 (main): Add casts to avoid warnings
5018 if GCC considers string literals to be constants.
74f10ca7 5019
022e70d4
PE
5020 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5021
59d6fe83
PE
5022 * dbusbind.c: Pointer signedness fixes.
5023 (xd_signature, xd_append_arg, xd_initialize):
5024 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5025 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5026 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5027 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5028
78320123
PE
5029 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5030 if GCC considers string literals to be constants.
49cebcca 5031 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5032
35ac2a97
SM
50332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5034
fb103ca9
SM
5035 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5036 (print_preprocess, print_object): New macro to fix last change.
5037
35ac2a97
SM
5038 * print.c (print_preprocess): Don't forget font objects.
5039
62973b41
JB
50402011-03-16 Juanma Barranquero <lekktu@gmail.com>
5041
5042 * emacs.c (USAGE3): Doc fixes.
5043
0e48bb22
AS
50442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5045
5046 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5047 structure.
5048
7684e57b
JB
50492011-03-14 Juanma Barranquero <lekktu@gmail.com>
5050
5051 * lisp.h (VWindow_system, Qfile_name_history):
5052 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5053 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5054 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5055
5056 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5057 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5058
5059 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5060 * w32console.c (detect_input_pending, read_input_pending)
5061 (encode_terminal_code):
5062 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5063 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5064 (w32_system_caret_y, Qfile_name_history):
5065 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5066 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5067 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5068 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5069 * w32proc.c (Qlocal, report_file_error):
5070 * w32term.c (Vwindow_system, updating_frame):
5071 * w32uniscribe.c (initialized, uniscribe_font_driver):
5072 Remove unneeded extern declarations.
5073
2aa46d6c
CY
50742011-03-14 Chong Yidong <cyd@stupidchicken.com>
5075
c96bbc66 5076 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5077
cffc6f3b
CY
50782011-03-13 Chong Yidong <cyd@stupidchicken.com>
5079
5080 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5081 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5082 These macros can no longer be used for assignment.
5083
44f230aa
SM
5084 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5085 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5086 (record_buffer_markers, fetch_buffer_markers): New functions for
5087 recording and fetching special buffer markers.
5088 (set_buffer_internal_1, set_buffer_temp): Use them.
5089
5090 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5091
5092 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5093
5094 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5095 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5096
5097 * xdisp.c (hscroll_window_tree):
5098 (reconsider_clip_changes): Use PT instead of BUF_PT.
5099
d251f04b
EZ
51002011-03-13 Eli Zaretskii <eliz@gnu.org>
5101
5102 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5103 $(EMACS_ROOT)/lib/intprops.h.
5104
f0c77cd1
PE
51052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5106
3eca4629
PE
5107 Fix more problems found by GCC 4.5.2's static checks.
5108
7c86ee98
PE
5109 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5110 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5111 (xg_free_frame_widgets): Make it clear that a local variable is
5112 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5113 (gdk_window_get_screen): Make it clear that this macro is needed
5114 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5115 (int_gtk_range_get_value): New function, which avoids a diagnostic
5116 from gcc -Wbad-function-cast.
5117 (xg_set_toolkit_scroll_bar_thumb): Use it.
5118 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5119 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5120 (get_utf8_string, xg_get_file_with_chooser):
5121 Rename locals to avoid shadowing.
5122 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5123
41729b81
PE
5124 * xgselect.c (xg_select): Remove unused var.
5125
f0c77cd1
PE
5126 * image.c (four_corners_best): Mark locals as initialized.
5127 (gif_load): Initialize transparent_p to zero (Bug#8238).
5128 Mark another local as initialized.
ec6cf4c6 5129 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5130
ce0ad53d 5131 * image.c (clear_image_cache): Now static.
d5d5a617 5132 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5133 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5134 (x_edge_detection): Remove unnecessary cast that
5135 gcc -Wbad-function-cast diagnoses.
2037898d 5136 (gif_load): Fix pointer signedness.
6ae141d6
PE
5137 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5138 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5139
33383987 51402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5141
d32df629
PE
5142 Improve quality of tests for time stamp overflow.
5143 For example, without this patch (encode-time 0 0 0 1 1
5144 1152921504606846976) returns the obviously-bogus value (-948597
5145 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5146 reports time overflow. See
5147 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5148 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5149 * editfns.c: Include limits.h and intprops.h.
5150 (TIME_T_MIN, TIME_T_MAX): New macros.
5151 (time_overflow): Move earlier, to before first use.
5152 (hi_time, lo_time): New functions, for an accurate test for
5153 out-of-range times.
5154 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5155 (Fget_internal_run_time): Don't assume time_t fits in int.
5156 (make_time): Use list2 instead of Fcons twice.
5157 (Fdecode_time): More accurate test for out-of-range times.
5158 (check_tm_member): New function.
5159 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5160 (lisp_time_argument): Don't rely on undefined left-shift and
5161 right-shift behavior when checking for time stamp overflow.
8be6f318 5162
fe31d94c
PE
5163 * editfns.c (time_overflow): New function, refactoring common code.
5164 (Fformat_time_string, Fdecode_time, Fencode_time):
5165 (Fcurrent_time_string): Use it.
5166
8be6f318
PE
5167 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5168 * dired.c (make_time): Move to ...
5169 * editfns.c (make_time): ... here.
5170 * systime.h: Note the move.
5171
09d9db2c 51722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5173
126bc0dc
YM
5174 * fringe.c (update_window_fringes): Remove unused variables.
5175
c47cbdfd
YM
5176 * unexmacosx.c (copy_data_segment): Also copy __got section.
5177 (Bug#8223)
5178
7ac80be9
EZ
51792011-03-12 Eli Zaretskii <eliz@gnu.org>
5180
c96bbc66 5181 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5182 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5183 Constify `char *' arguments and their references according to
5184 prototypes in tparam.h.
5185
ecb0f94d 5186 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5187
7ac80be9
EZ
5188 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5189 Adapt all references accordingly.
5190
5191 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5192
ef1fd07e
TT
51932011-03-11 Tom Tromey <tromey@redhat.com>
5194
5195 * buffer.c (syms_of_buffer): Remove obsolete comment.
5196
7ef4b50c
EZ
51972011-03-11 Eli Zaretskii <eliz@gnu.org>
5198
5199 * termhooks.h (encode_terminal_code): Declare prototype.
5200
5201 * msdos.c (encode_terminal_code): Don't declare prototype.
5202
5203 * term.c (encode_terminal_code): Now external again, used by
5204 w32console.c and msdos.c.
5205
44f230aa
SM
5206 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5207 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5208
4b1ec863 52092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5210
1714f52b 5211 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5212
4b1ec863
PE
5213 * fringe.c (update_window_fringes): Mark locals as initialized
5214 (Bug#8227).
5215 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5216
524c7aa6
PE
5217 * alloc.c (mark_fringe_data): Move decl from here ...
5218 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5219 to check its interface.
5220 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5221
a5c0af81 5222 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5223 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5224 (fontset_font): Mark local as initialized.
a9a06e0b 5225 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5226
b4716021
PE
5227 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5228
811e9bac 5229 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5230 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5231 (x_own_selection, Fx_disown_selection_internal): Rename locals
5232 to avoid shadowing.
5233 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5234
7e3ab302
PE
5235 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5236 so that the caller can use some name other than gcpro1.
5237 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5238 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5239 (Fx_backspace_delete_keys_p):
5240 Use them to avoid shadowing, and rename vars to avoid shadowing.
5241 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5242 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5243 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5244 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5245 Remove unused locals.
7e3ab302
PE
5246 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5247 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5248 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5249 macros.
f78faa98 5250
e2b13473
PE
5251 * xterm.h (x_mouse_leave): New decl.
5252
77f23912
PE
5253 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5254 Remove unused functions.
cdf4ba58
PE
5255 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5256 (x_calc_absolute_position): Now static.
7411c686 5257 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5258 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5259 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5260 unless they are used.
38d0b34a
PE
5261 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5262 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5263 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5264 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5265 (x_error_catcher, x_connection_closed, x_error_handler):
5266 (x_error_quitter, xembed_send_message, x_iconify_frame):
5267 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5268 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5269 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5270
44f230aa
SM
5271 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5272 Rename or move locals to avoid shadowing.
6b463e58 5273 (tty_defined_color, merge_face_heights): Now static.
5967d051 5274 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5275 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5276 does not deduce is never used uninitialized.
73719eba
PE
5277 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5278 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5279
426994c3 5280 * terminal.c (store_terminal_param): Now static.
5489860b 5281
032f1620 5282 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5283 (set_frame_menubar): Remove unused local.
d4323972 5284 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5285 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5286 since they might point to immutable storage.
281585b0
PE
5287 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5288 since it's unused otherwise.
032f1620 5289
367c19e5 5290 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5291 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5292 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5293 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5294 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5295 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5296 does not deduce are never used uninitialized.
70739cbe 5297
07b48fa9
PE
5298 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5299
8868a238 5300 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5301 * window.c (window_loop, size_window):
5302 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5303
7e5cf297 5304 * window.c (display_buffer): Now static.
d6550a9f
PE
5305 (size_window): Mark variables that gcc -Wuninitialized
5306 does not deduce are never used uninitialized.
a586633d
PE
5307 * window.h (check_all_windows): New decl, to forestall
5308 gcc -Wmissing-prototypes diagnostic.
5b555da1 5309 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5310
f6095868
PE
5311 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5312 shadowing.
5313 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5314 Include <limits.h>.
5315 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5316 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5317 (load_charset_map): Mark variables that gcc -Wuninitialized
5318 does not deduce are never used uninitialized.
53df7c11 5319 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5320
f38b440c
PE
5321 * coding.c (coding_set_source, coding_set_destination):
5322 Use "else { /* comment */ }" rather than "else /* comment */;"
5323 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5324 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5325 a block, when the outer 'i' will do.
5326 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5327 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5328 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5329 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5330 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5331 Rename locals to avoid shadowing.
5332 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5333 * coding.c (emacs_mule_char, encode_invocation_designation):
5334 Now static, since they're not used elsewhere.
413bb2db 5335 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5336 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5337 (decode_coding_emacs_mule): Mark variables that gcc
5338 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5339 (detect_coding_iso_2022): Initialize a local variable that might
5340 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5341 this initialization is needed. (Bug#8211)
5f58e762
PE
5342 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5343 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5344 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5345 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5346 Remove unused macros.
f38b440c 5347
232b38b9 5348 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5349 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5350 * character.c (string_count_byte8): Likewise.
232b38b9 5351
fb90da1b
PE
5352 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5353 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5354
fb93dbc2
PE
5355 * chartab.c (copy_sub_char_table): Now static, since it's not used
5356 elsewhere.
5c156ace
PE
5357 (sub_char_table_ref_and_range, char_table_ref_and_range):
5358 Rename locals to avoid shadowing.
bbcd0949 5359 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5360
7d3b3862 5361 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5362 (BIDI_BOB): Remove unused macro.
7d3b3862 5363
6be7d3da
PE
5364 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5365 deduce are never used uninitialized.
c2ed9c8b 5366 * term.c (encode_terminal_code): Likewise.
6be7d3da 5367
75f8807f 5368 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5369
50938595
PE
5370 * tparam.h: New file.
5371 * term.c, tparam.h: Include it.
5372 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5373 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5374 Move these decls to tparam.h, and make them agree with what
5375 is actually in tparam.c. The previous trick of using incompatible
5376 decls in different modules does not conform to the C standard.
5377 All callers of tparam changed to use tparam's actual API.
5378 * tparam.c (tparam1, tparam, tgoto):
5379 Use const pointers where appropriate.
5380
fbceeba2
PE
5381 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5382 * cm.h (struct cm): Likewise.
5383 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5384 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5385 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5386 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5387 (turn_on_face, init_tty): Likewise.
5388 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5389
7f3f1250
PE
5390 * term.c (term_mouse_position): Rename local to avoid shadowing.
5391
e6ca6543
PE
5392 * alloc.c (mark_ttys): Move decl from here ...
5393 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5394
c40f8d15
AS
53952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5396
5397 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5398
cfe0661d
JB
53992011-03-09 Juanma Barranquero <lekktu@gmail.com>
5400
5401 * search.c (compile_pattern_1): Remove argument regp, unused since
5402 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5403 (compile_pattern): Don't pass it.
5404
0afb4571
J
54052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5406
5407 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5408 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5409 for ! HAVE_GTK3.
5410 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5411
5412 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5413
5414 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5415 gdk_window_get_screen, gdk_window_get_geometry,
5416 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5417 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5418 (xg_get_pixbuf_from_pixmap): New function.
5419 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5420 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5421 Call xg_get_pixbuf_from_pixmap instead of
5422 gdk_pixbuf_get_from_drawable.
5423 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5424 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5425 (xg_check_special_colors): Use GtkStyleContext and its functions
5426 for HAVE_GTK3.
5427 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5428 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5429 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5430 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5431 Call gtk_widget_get_preferred_size.
0afb4571
J
5432 (xg_frame_resized): gdk_window_get_geometry only takes 5
5433 parameters.
44f230aa
SM
5434 (xg_win_to_widget, xg_event_is_for_menubar):
5435 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5436 (xg_set_widget_bg): New function.
5437 (delete_cb): New function.
895009e1 5438 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5439 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5440 (xg_set_background_color): Call xg_set_widget_bg.
5441 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5442 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5443 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5444 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5445 if ! HAVE_GTK3.
5446 (update_frame_tool_bar): Call gtk_widget_hide.
5447 (xg_initialize): Use GDK_KEY_g.
5448
5449 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5450 if ! HAVE_GTK3
5451 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5452
5453 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5454 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5455 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5456
1c2cc4ef
JB
54572011-03-08 Juanma Barranquero <lekktu@gmail.com>
5458
5459 * w32xfns.c (select_palette): Check success of RealizePalette against
5460 GDI_ERROR, not zero.
5461
33383987 5462See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5463
5464;; Local Variables:
5465;; coding: utf-8
aac0c6e3
MR
5466;; End:
5467
33383987 5468 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5469
5470 This file is part of GNU Emacs.
5471
5472 GNU Emacs is free software: you can redistribute it and/or modify
5473 it under the terms of the GNU General Public License as published by
5474 the Free Software Foundation, either version 3 of the License, or
5475 (at your option) any later version.
5476
5477 GNU Emacs is distributed in the hope that it will be useful,
5478 but WITHOUT ANY WARRANTY; without even the implied warranty of
5479 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5480 GNU General Public License for more details.
5481
5482 You should have received a copy of the GNU General Public License
5483 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.