* progmodes/python.el (run-python-internal): Disable font lock for
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c1529ded
GM
12012-07-31 Glenn Morris <rgm@gnu.org>
2
6a381852
GM
3 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
4 * s/darwin.h: Remove file.
5
c1529ded
GM
6 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
7 * s/hpux10-20.h: Remove file, which is now empty.
8
b429a4ee
GM
92012-07-30 Glenn Morris <rgm@gnu.org>
10
11 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
12 * Makefile.in (config_h): Add conf_post.h.
13 * makefile.w32-in (CONFIG_H): Add conf_post.h.
14
adff3182
JD
152012-07-30 Jan Djärv <jan.h.d@swipnet.se>
16
17 * nsterm.m (ns_do_open_file): New variable.
18 (ns_term_init): Set ns_do_open_file to NO after run returns.
19 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
20 files only if ns_do_open_file.
21
c32af1e4
PE
222012-07-30 Paul Eggert <eggert@cs.ucla.edu>
23
7393bcbb
PE
24 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
25 This no-op macro hasn't been needed for many years.
26 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
27
c32af1e4
PE
28 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
29 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
30 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
31 gdb_make_enums_visible.
32 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
33 (DIRECTORY_SEP): Now a constant, not a macro.
34
302fc036
EZ
352012-07-30 Eli Zaretskii <eliz@gnu.org>
36
37 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
38 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
39
40 * w32term.c <w32_keyboard_codepage>: Renamed from
41 keyboard_codepage and now external. All users changed.
42
43 * w32term.h: Add declaration of w32_keyboard_codepage.
44
45 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
46 the codepage to translate keys to Unicode. If this argument is
47 -1, use the value returned by GetConsoleCP. All callers changed.
48
88fb40b4
PE
492012-07-30 Paul Eggert <eggert@cs.ucla.edu>
50
0aee6912
PE
51 Update .PHONY listings in makefiles.
52 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
53 bootstrap-clean, distclean, maintainer-clean, versioclean,
54 extraclean, frc.
55
88fb40b4
PE
56 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
57 This is a bit clearer. Fix some commentary typos.
58
0a763bd1
GM
592012-07-30 Glenn Morris <rgm@gnu.org>
60
32bac6d6
GM
61 * s/netbsd.h: Let configure include signal.h if needed.
62 Remove file, which is now empty.
63
b65e7c46
GM
64 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
65 Let configure set them.
66 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
67 No more need to undefine.
0a763bd1 68
169304bd
AS
692012-07-30 Andreas Schwab <schwab@linux-m68k.org>
70
71 * keymap.c (Fkey_description): Don't remove 0x80 bit from
72 non-single-byte char when adding meta modifier. (Bug#12090)
73
6cd7a139
DA
742012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
75
76 Convert safe_call to use variable number of arguments.
77 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
78 (safe_call2): Fix comment.
79 * lisp.h (safe_call): Adjust prototype.
80 * coding.c (encode_coding_object): Change to use safe_call2.
81 * xfaces.c (merge_face_heights): Change to use safe_call1.
82
d34d6ffc
GM
832012-07-30 Glenn Morris <rgm@gnu.org>
84
7b8a48e4 85 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 86 does that unconditionally. Remove file, which is now empty.
7b8a48e4 87
d34d6ffc
GM
88 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
89 Remove empty files.
90
03a660a6
PE
912012-07-30 Paul Eggert <eggert@cs.ucla.edu>
92
93 Export to GDB most of lisp.h's remaining object-like macros.
94 * lisp.h (min, max): Move earlier, because they're used earlier now.
95 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
96 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
97 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
98 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
99 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
100 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
101 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
102 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
103 Now constants, for GDB. They need not be macros.
104 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
105 Now constants, for GDB, as well as macros, for static initializers.
106 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
107 Move to after the definition of struct Lisp_Char_Table,
108 since the former now needs that type defined.
109 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
110 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
111 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
112 New enums, for gdb_make_enums_visible.
113 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 114 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
115 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
116 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
117 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
118 enum maxargs, enum MAX_ALLOCA.
119 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
120 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
121 no longer needed, now that they are done in lisp.h.
122
e499d0ee
DA
1232012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
124
125 Cleanup string bytes checking.
126 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
127 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
128 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
129 (check_sblock, compact_small_strings): Simplify.
130
d5040d2d
PE
1312012-07-29 Paul Eggert <eggert@cs.ucla.edu>
132
133 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
134 These macros are confusing and no longer need to be defined, as
135 the enum values now suffice. All uses replaced with definiens.
136 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
137
7f259ae6
JB
1382012-07-29 Juanma Barranquero <lekktu@gmail.com>
139
140 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
141 ($(BLD)/w32console.$(O)): Update dependencies.
142
7e63e0c3
DA
1432012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
144
145 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
146 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
147 time. Adjust users.
148 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
149
ffd817eb
JD
1502012-07-29 Jan Djärv <jan.h.d@swipnet.se>
151
152 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
153 setting sitelisp (Bug#12010).
154
417a7a0e
EZ
1552012-07-29 Eli Zaretskii <eliz@gnu.org>
156
157 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
158
159 * w32heap.c (cache_system_info):
160 * w32.c (sys_rename):
161 * w32proc.c (find_child_console, sys_kill): All users changed.
162
387d4d92
PE
1632012-07-29 Paul Eggert <eggert@cs.ucla.edu>
164
165 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
166
55a6cca6
EZ
1672012-07-29 Eli Zaretskii <eliz@gnu.org>
168
169 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
170
dbcf001c
DA
1712012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
172
173 Cleanup statistics calculation in Fgarbage_collect.
174 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
175 zombies percentage calculation. Simplify elapsed time calculation.
176
e2688e4a
DA
1772012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
178
179 Generalize marker debugging code under MARKER_DEBUG and use eassert.
180 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
181 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
182 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
183 (replace_range, replace_range_2, del_range_2): Change to eassert.
184 * marker.c (byte_char_debug_check): Adjust style.
185
b46a6a83
PE
1862012-07-29 Paul Eggert <eggert@cs.ucla.edu>
187
188 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
189 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
190 long-ago-commented-out code that talks about "WIN32".
191 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
192 All uses changed.
193
e32a5799
PE
1942012-07-28 Paul Eggert <eggert@cs.ucla.edu>
195
196 Use Gnulib stdalign module (Bug#9772, Bug#9960).
197 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
198 Simplify by using alignof.
199 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
200 * lisp.h: Include <stdalign.h>.
201 (GCALIGNMENT): New macro and constant.
202 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
203 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
204 (stdalign): New macro, if not already defined.
205
df81cd29
EZ
2062012-07-28 Eli Zaretskii <eliz@gnu.org>
207
01bd1b0d
EZ
208 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
209 * w32inevt.c: Include w32inevt.h.
210 (w32_read_console_input): New inline function, calls either
211 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
212 w32_console_unicode_input.
213 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
214 (w32_kbd_patch_key, key_event): Use the codepage returned by
215 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
216 (key_event): use uChar.UnicodeChar only if
217 w32_console_unicode_input is non-zero.
218
219 * w32console.c: Include w32heap.h.
220 <w32_console_unicode_input>: New global variable.
221 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
222 family of Windows, zero otherwise.
223
224 * w32inevt.h: Declare w32_console_unicode_input.
225
df81cd29
EZ
226 * xdisp.c (init_iterator): Don't reference tip_frame in a build
227 --without-x. (Bug#11742)
228
c20fdd9e
PE
2292012-07-27 Paul Eggert <eggert@cs.ucla.edu>
230
231 Adjust GDB to reflect pvec_type changes (Bug#12036).
232 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
233 2012-07-04 changes to pseudovector representation. Problem
234 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
235
32770973 2362012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
237
238 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
239 bus address.
240 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
241
3438fe21
EZ
2422012-07-27 Eli Zaretskii <eliz@gnu.org>
243
bcfbc9de
EZ
244 * alloc.c (listn): Fix the order the arguments are consed onto the
245 list.
246
3438fe21
EZ
247 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
248 enumeration constants, as PURE and HEAP are too general, and clash
249 with other headers and sources, such as gmalloc.c and the
250 MS-Windows system headers. All users changed.
251
eeaea515
DA
2522012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
253
254 Revert last save_excursion_save and save_excursion_restore changes.
255 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
256 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
257
073c88c2
DA
2582012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Fix recently-introduced typos in Windows port.
261 Reported by Martin Rudalics <rudalics@gmx.at>.
262 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 263 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 264
4706125e
PE
2652012-07-27 Paul Eggert <eggert@cs.ucla.edu>
266
267 Improve GDB symbol export (Bug#12036).
268 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
269 arms of an 'if', not using conditional expressions; otherwise GDB
270 complains about the types in the unevaluated arm when the argument
271 is an integer literal.
272 (xgetint): Simplify expression.
273 * alloc.c (gdb_make_enums_visible): New constant. This ports to
274 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
275 Zaretskii in <http://bugs.gnu.org/12036#13>.
276 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
277 needed now that we have gdb_make_enums_visible.
278 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
279 (enum enum_USE_LSB_TAG):
280 New enum types, packaging up enums that need to be exported to GDB.
281
694b6c97
DA
2822012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
283
284 Utility function to make a list from specified amount of objects.
285 * lisp.h (enum constype): New datatype.
286 (listn): New prototype.
287 * alloc.c (listn): New function.
288 (Fmemory_use_count, syms_of_alloc): Use it.
289 * buffer.c (syms_of_buffer): Likewise.
290 * callint.c (syms_of_callint): Likewise.
291 * charset.c (define_charset_internal): Likewise.
292 * coding.c (syms_of_coding): Likewise.
293 * keymap.c (syms_of_keymap): Likewise.
294 * search.c (syms_of_search): Likewise.
295 * syntax.c (syms_of_syntax): Likewise.
296 * w32.c (init_environment): Likewise.
297 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
298 * xdisp.c (syms_of_xdisp): Likewise.
299 * xfns.c (syms_of_xfns): Likewise.
300
6195f384
DA
3012012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
302
303 Fast save_excursion_save and save_excursion_restore.
304 * lisp.h (struct Lisp_Excursion): New data type.
305 (PVEC_EXCURSION): New pseudovector type.
306 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
307 to deal with it. Adjust comments.
308 (init_marker, attach_marker): New prototype.
309 (unchain_marker): Adjust prototype.
310 * marker.c (attach_marker): Change to global.
311 (init_marker): New function.
312 * alloc.c (Fmake_marker, build_marker): Use it.
313 (build_marker): More easserts.
314 (mark_object): Handle struct Lisp_Excursion.
315 * editfns.c (save_excursion_save, save_excursion_restore):
316 Reimplement to use struct Lisp_Excursion. Add comments.
317
5eceb8fb
PE
3182012-07-26 Paul Eggert <eggert@cs.ucla.edu>
319
320 Fix export of symbols to GDB (Bug#12036).
321 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
322 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
323 emacs.c, as this is a more-suitable home. Had this been done earlier
324 the fix for 12036 would have avoided some of the problems noted in
325 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
326 would have been more obvious.
562157c8
PE
327 * emacs.c: Do not include <verify.h>; no longer needed.
328 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
329 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
330 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
331 Remove; now done in lisp.h.
332 * lisp.h (PUBLISH_TO_GDB): New macro.
333 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
334 (DATA_SEG_BITS): Use it.
335 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
336 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
337 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
338 not be usable in #if. This simplifies things.
339
d6749401
JB
3402012-07-26 Juanma Barranquero <lekktu@gmail.com>
341
342 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
343
1781b9e9
PE
3442012-07-26 Paul Eggert <eggert@cs.ucla.edu>
345
d89518db 346 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
347 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
348 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
349 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
350 Adjust to changes in lisp.h and emacs.c, by using
351 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
352 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
353 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
354 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
355 instead of gdb_valbits.
356 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
357 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
358 instead of gdb_array_mark_flag.
359 (xboolvector): Get size from $->size, not $->header.size.
360 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
361 (xreload, hook-run, hookpost-run): Remove.
362 * emacs.c: Include <verify.h>.
363 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
364 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
365 Remove.
366 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
367 (gdb_USE_LSB_TAG): New enum constants.
368 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
369 Also define these as enum constants, so they're visible to GDB.
370 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
371 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
372 as constants, so they're visible to GDB.
373 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
374 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
375 Now enum constants, not macros, so they're visible to GDB.
376 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
377 more convenient now. All uses changed.
378 (VALMASK) [USE_LSB_TAG]: Also define in this case.
379 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
380
3628596a
DA
3812012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
382
383 Explicitly free restriction data that are not needed anymore.
384 * editfns.c (save_restriction_restore): Free restriction data.
385
7abaf5cc
SM
3862012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
387
388 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
389 add argument, tune behavior, and adjust all callers.
390
71f88e00
PE
3912012-07-25 Paul Eggert <eggert@cs.ucla.edu>
392
393 Use typedef for EMACS_INT, EMACS_UINT.
394 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
395 than macros. This simplifies debugging in the usual case, since
396 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
397 and it allows expressions involving EMACS_INT casts.
398 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
399
57ec3034
JD
4002012-07-25 Jan Djärv <jan.h.d@swipnet.se>
401
402 * nsterm.m (ns_read_socket): Return early if there is a modal
403 window (Bug#12043).
404
8137e7b3
MR
4052012-07-25 Martin Rudalics <rudalics@gmx.at>
406
407 * frame.c (Fredirect_frame_focus): In doc-string don't mention
408 that FOCUS-FRAME can be omitted.
409
04e9897c
DA
4102012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
411
412 Adjust buffer text indirection counters at the end of Fkill_buffer.
413 * buffer.c (Fkill_buffer): Adjust indirection counters when the
414 buffer is definitely dead. This should really fix an issue reported
415 by Christoph Scholtes again. (Bug#12007).
416 (init_buffer_once): Initialize indirection counters of
417 buffer_defaults and buffer_local_symbols (for sanity and safety).
418
8a0484e1
EZ
4192012-07-24 Eli Zaretskii <eliz@gnu.org>
420
421 * xdisp.c (init_iterator): Don't compute dimensions of truncation
422 and continuation glyphs on tooltip frames, leave them at zero.
423 Avoids continued lines in tooltips. (Bug#11832)
424
fa691a83
DA
4252012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
426
427 Simplify copy_overlay.
04e9897c 428 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
429 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
430
436bc8e0
EZ
4312012-07-23 Eli Zaretskii <eliz@gnu.org>
432
433 * print.c (print_object): Don't crash when a frame's name is nil
434 or invalid. (Bug#12025)
435
436 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
437 it signals an error when a tooltip frame is being created.
438
d7a7fda3
DA
4392012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
440
441 Cleanup miscellaneous objects allocation and initialization.
442 * alloc.c (allocate_misc): Change to static. Add argument to
443 specify the subtype. Adjust comment and users.
444 (build_overlay): New function.
445 * buffer.c (copy_overlays, Fmake_overlay): Use it.
446 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
447 (allocate_misc): Remove prototype.
448 (build_overlay): Add prototype.
449
4502012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
451
452 Swap buffer text indirection counters in Fbuffer_swap_text.
453 * buffer.c (Fbuffer_swap_text): Swap indirections too.
454 This avoids crash reported by Christoph Scholtes at
455 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
456
9d7fa573
JD
4572012-07-22 Jan Djärv <jan.h.d@swipnet.se>
458
459 * nsmenu.m (Popdown_data): New struct.
460 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
461 free Popdown_data.
462 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
463 (initWithContentRect): Make imgView and contentView non-static
464 and autorelease them. Also autorelease img and matrix (Bug#12005).
465 (dealloc): Remove (Bug#12005).
466
0dd6d66d
DA
4672012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
468
469 Adjust consing_since_gc when objects are explicitly freed.
470 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
471 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
472 (free_cons, free_misc): Subtract object size from consing_since_gc.
473
d36d71df
DA
4742012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
475
476 Simplify and cleanup markers positioning code.
477 * marker.c (attach_marker): More useful eassert.
478 (live_buffer, set_marker_internal): New function.
479 (Fset_marker, set_marker_restricted): Use set_marker_internal.
480 (set_marker_both, set_marker_restricted_both): Use live_buffer.
481
fb9ea40f
PE
4822012-07-22 Paul Eggert <eggert@cs.ucla.edu>
483
484 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
485 as it's limited by the amount of memory, not by INT_MAX.
486
2d5c5f7d
EZ
4872012-07-21 Eli Zaretskii <eliz@gnu.org>
488
07fb592e
EZ
489 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
490 in special-event-map. See the discussion at
491 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
492 for the reasons.
493
37a9eac8 494 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
495 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
496 Fabrice Popineau <fabrice.popineau@supelec.fr>.
497
c4328746
JD
4982012-07-21 Jan Djärv <jan.h.d@swipnet.se>
499
500 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 501 (conversationIdentifier): Return value is NSInteger.
784051c4 502 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 503
6e5d1c12
CY
5042012-07-21 Chong Yidong <cyd@gnu.org>
505
506 * window.c (decode_any_window): Signal an error if the window is
507 on a dead frame (Bug#11984).
508
9928463d
DA
5092012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
510
511 Add indirection counting to speed up Fkill_buffer.
512 * buffer.h (struct buffer): New member.
513 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
514 (Fmake_indirect_buffer): Set indirection counter to -1, increment
515 base buffer indirection counter.
516 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
517 (Fkill_buffer): Adjust indirection counters as needed, don't walk
518 through buffer list if indirection counter is 0.
519
f8643a6b
DA
5202012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
521
522 Extend the value returned by Fgarbage_collect with heap statistics.
523 * alloc.c (Qheap): New symbol.
524 (syms_of_alloc): DEFSYM it.
525 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
526 (Fmemory_free): Remove.
527 (syms_of_alloc): Don't defsubr it.
528 * buffer.c (Fcompact_buffer): Remove.
529 (syms_of_buffer): Don't defsubr it.
530
dac616ff
DA
5312012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
532
533 Make maybe_gc inline.
534 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
535 * lisp.h (consing_since_gc, gc_relative_threshold)
536 (memory_full_cons_threshold): Revert declaration.
537 (maybe_gc): Remove prototype, define as inline.
538 * alloc.c: Remove old commented-out code.
539 (consing_since_gc, gc_relative_threshold)
540 (memory_full_cons_threshold): Revert to global.
541 (maybe_gc): Remove.
542
d7ea76b4
DA
5432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
544
545 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
546 * lisp.h (build_unibyte_string): New function.
547 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
548 * sysdep.c, w32fns.c, xfns.c: Use it.
549 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
550 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
551 Adjust users accordingly.
552 * font.h (font_open_by_name): Adjust prototype.
553
765e61e3
DA
5542012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
555
556 Cleanup calls to Fgarbage_collect.
557 * lisp.h (maybe_gc): New prototype.
558 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
559 Remove declarations.
560 * alloc.c (maybe_gc): New function.
561 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
562 Make them static.
563 * bytecode.c (MAYBE_GC): Use maybe_gc.
564 * eval.c (eval_sub, Ffuncall): Likewise.
565 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
566 to avoid dependency from auto-save feature.
567
52b852c7
PE
5682012-07-19 Paul Eggert <eggert@cs.ucla.edu>
569
570 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
571 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
572 'for_each_per_buffer_object_at'.
573 All uses changed. It's better to use upper-case for macros that
574 cannot be implemented as functions, to give the reader a clue
575 that they're special.
576
5db81e33
SM
5772012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
578
579 * alloc.c (Fgarbage_collect): Tweak docstring.
580
5b835e1d
DA
5812012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
582
583 Tweak the value returned from Fgarbage_collect again.
584 * alloc.c (Fgarbage_collect): New return value, as confirmed in
585 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
586 Adjust documentation.
587 (total_vector_bytes): Rename to total_vector_slots, adjust
588 accounting.
589 (total_free_vector_bytes): Rename to total_free_vector_slots,
590 adjust accounting.
591 (Qstring_bytes, Qvector_slots): New symbols.
592 (syms_of_alloc): DEFSYM them.
593
9cd47b72
DA
5942012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
595
596 Buffer compaction primitive which may be used from Lisp.
597 * buffer.c (compact_buffer, Fcompact_buffer): New function.
598 (syms_of_buffer): Register Fcompact_buffer.
599 * alloc.c (Fgarbage_collect): Use compact_buffer.
600 * buffer.h (compact_buffer): New prototype.
601 (struct buffer_text): New member.
602
d17337e5
DA
6032012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
604
605 New macro to iterate over all buffers, miscellaneous cleanups.
606 * lisp.h (all_buffers): Remove declaration.
607 * buffer.h (all_buffers): Add declaration, with comment.
608 (for_each_buffer): New macro.
609 * alloc.c (Fgarbage_collect, mark_object): Use it.
610 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
611 (init_buffer): Likewise.
612 * data.c (Fset_default): Likewise.
613 * coding.c (code_conversion_restore): Remove redundant check
614 for dead buffer.
615 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
616
60cfd278
AS
6172012-07-18 Andreas Schwab <schwab@linux-m68k.org>
618
619 Fix bug that created negative-length intervals.
620 * intervals.c (merge_interval_right, merge_interval_left):
621 Do not zero out this interval if it is absorbed by its children,
622 as this interval's total length doesn't change in that case. See
623 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
624
d06714cb
PE
6252012-07-18 Paul Eggert <eggert@cs.ucla.edu>
626
83713154
PE
627 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
628 when invoking (make-bool-vector N t) and N is a positive
629 multiple of 8 -- the last 8 bits were mistakenly cleared.
630
d06714cb
PE
631 Remove some struct layout assumptions in bool vectors.
632 * alloc.c (bool_header_size): New constant.
633 (header_size, word_size): Move earlier, as they're now used earlier.
634 Use 'word_size' in a few more places, where it's appropriate.
635 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
636 padding before the data member of a bool vector.
637 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
638 than doing the check by hand with an abort ().
639
464d5a5e
SM
6402012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
641
5fbc0409
SM
642 * eval.c (Fdefvar): Don't check constants since we only set the var if
643 it's not yet defined anyway (bug#11904).
644
464d5a5e
SM
645 * lisp.h (last_undo_boundary): Declare new var.
646 * keyboard.c (command_loop_1): Set it.
647 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
648 were auto-added by the command loop (bug#11774).
649
8dc2e44a
AS
6502012-07-18 Andreas Schwab <schwab@linux-m68k.org>
651
652 * w32font.c (Qsymbol): Remove local definition.
653 (syms_of_w32font): Don't DEFSYM it.
654
169925ec
DA
6552012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
656
657 Fix sweep_vectors to handle large bool vectors correctly.
658 * alloc.c (sweep_vectors): Account total_vector_bytes for
659 bool vectors larger than VBLOCK_BYTES_MAX.
660
5fbfb018
CY
6612012-07-18 Chong Yidong <cyd@gnu.org>
662
663 * frame.c (x_set_frame_parameters): Revert bogus change introduced
664 in 2012-05-25 commit by Paul Eggert (Bug#11738).
665
3ab6e069
DA
6662012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
667
668 Return more descriptive data from Fgarbage_collect.
669 Suggested by Stefan Monnier in
670 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
671 * alloc.c (bounded_number): New function.
672 (total_buffers, total_vectors): New variable.
673 (total_string_size): Rename to total_string_bytes, adjust users.
674 (total_vector_size): Rename to total_vector_bytes, adjust users.
675 (sweep_vectors): Account total_vectors and total_vector_bytes.
676 (Fgarbage_collect): New return value. Adjust documentation.
677 (gc_sweep): Account total_buffers.
678 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
679 (VECTOR_SIZE): Remove.
680 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
681 (Qinterval, Qmisc): New symbols.
682 (syms_of_data): Initialize them.
683 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
684 (Qcons, Qbuffer): New declarations.
685
6d02fe5b
PE
6862012-07-17 Paul Eggert <eggert@cs.ucla.edu>
687
688 * alloc.c (Fmemory_free): Account for memory-free's own storage.
689 Round up, not down. Improve doc.
690
b7ffe040
DA
6912012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Restore old code in allocate_string_data to avoid Faset breakage.
694 Reported by Julien Danjou <julien@danjou.info> in
695 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
696 * alloc.c (allocate_string_data): Restore old code with minor
697 adjustments, fix comment to explain this subtle issue.
698
4dc7c8d5
SM
6992012-07-17 Eli Zaretskii <eliz@gnu.org>
700
701 Remove FILE_SYSTEM_CASE.
702 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
703
704 * fileio.c (FILE_SYSTEM_CASE): Don't define.
705 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
706 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
707 call-process-region passes it through expand-file-name.
708
709 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
710
7112012-07-17 Andreas Schwab <schwab@linux-m68k.org>
712
713 Fix crash when creating indirect buffer (Bug#11917)
714 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
715 Don't handle unbound variables specially if non-zero.
716 (Fbuffer_local_variables): Pass zero.
717 (clone_per_buffer_values): Pass non-zero.
718
7192012-07-17 Andreas Schwab <schwab@linux-m68k.org>
720
721 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
722 to make the loop interruptible.
723
7242012-07-17 Andreas Schwab <schwab@linux-m68k.org>
725
726 * gnutls.c (emacs_gnutls_handshake): Only retry if
727 GNUTLS_E_INTERRUPTED.
728
cce7fefc
DA
7292012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
730
731 Cleanup and convert miscellaneous checks to eassert.
732 * alloc.c (mark_interval): Fix comment, partially rephrase
733 old comment from intervals.h (see below).
734 * intervals.c (find_interval, adjust_intervals_for_insertion)
735 (delete_interval, adjust_intervals_for_deletion)
736 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
737 Convert to eassert.
738 (adjust_intervals_for_insertion, make_new_interval):
739 Remove obsolete and unused code.
740 * intervals.h (struct interval): Remove obsolete comment.
741 * textprotp.c (erase_properties): Remove unused code.
742 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
743 (Fremove_list_of_text_properties): Convert to eassert.
744
9ea10cc3
CY
7452012-07-17 Chong Yidong <cyd@gnu.org>
746
747 * editfns.c (Finsert_char): Doc fix.
748
3900d5de
DA
7492012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
750
751 Fix previous change to make Fmemory_free always accurate.
752 * alloc.c (make_interval): Update total_free_intervals.
753 (make_float): Likewise for total_free_floats.
754 (free_cons, Fcons): Likewise for total_free_conses.
755 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
756 Likewise for total_free_vector_bytes.
757 (Fmake_symbol): Likewise for total_free_symbols.
758 (bytes_free): Remove.
759
7098646f
DA
7602012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
761
762 Simple free memory accounting feature.
763 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
764 (sweep_vectors): Accumulate size of free vectors.
765 (Fgarbage_collect): Setup bytes_free.
766 (Fmemory_free): New function.
767 (syms_of_alloc): Register it.
768
22657b40
DA
7692012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
770
771 Cleanup overlays checking.
772 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
773 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
774 eassert and OVERLAYP.
775 (sort_overlays): Change to use OVERLAYP.
776
ddfc8813
RK
7772012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
778
779 * editfns.c (Finsert_char): Make it interactive, and make the
780 second arg optional. Copy interactive spec and docstring from
781 ucs-insert.
782
7c26cf3c
PE
7832012-07-17 Paul Eggert <eggert@cs.ucla.edu>
784
785 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
786 Unlike the other wrapped functions, fabs has an unspecified
787 effect on errno.
788
5d127af9
JD
7892012-07-16 Jan Djärv <jan.h.d@swipnet.se>
790
791 * nsterm.m (keyDown): Interpret flags without left/right bits
792 as the left key (Bug#11670).
793
6a0dd1d7
DA
7942012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
795
796 Remove empty and useless init functions.
797 * lisp.h (init_character_once, init_fns, init_image)
798 (init_filelock, init_sound): Remove prototype.
799 * character.c (init_character_once): Remove.
800 * filelock.c (init_filelock): Likewise.
801 * fns.c (init_fns): Likewise.
802 * image.c (init_image): Likewise.
803 * sound.c (init_sound): Likewise.
804 * emacs.c (main): Adjust accordingly.
805
7a6136fd
DA
8062012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
807
808 * gtkutil.h: Tiny cleanups.
809 (use_old_gtk_file_dialog): Remove useless declaration.
810 (xg_uses_old_file_dialog): Add suggested const attribute.
811
ce811ad9
EZ
8122012-07-15 Eli Zaretskii <eliz@gnu.org>
813
814 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
815 (bidi_paragraph_init): Use it to limit search forward for a strong
816 directional character in abnormally large paragraphs full of
817 neutral or weak characters. (Bug#11943)
818
c9adfeaa
SF
8192012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
820
821 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
822 the toolbar (Bug#9451).
823 (xg_make_tool_item): Give the widget event box a transparent
824 background.
825
fff62aa9
DA
8262012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
827
828 Cleanup basic allocation variables and functions.
829 * alloc.c (ignore_warnings, init_intervals, init_float)
830 (init_cons, init_symbol, init_marker): Remove.
831 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
832 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
833 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
834 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
835 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
836 (staticidx, init_alloc_once, init_strings, free_ablock):
837 Remove redundant initialization.
838 * fns.c (init_weak_hash_tables): Remove.
839 * lisp.h (init_weak_hash_tables): Remove prototype.
840
9730daca
DA
8412012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
842
843 Use zero_vector where appropriate.
844 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
845 accordingly.
846 * lisp.h (zero_vector): New declaration.
847 * font.c (null_vector): Remove.
848 (syms_of_font): Remove initialization and staticpro.
849 (font_list_entities, font_find_for_lface): Change to use zero_vector.
850 * keymap.c (Faccessible_keymaps): Likewise.
851
2e2d2a13
LL
8522012-07-15 Leo Liu <sdl.web@gmail.com>
853
854 * fringe.c: Fix typo in comments.
855
cd276f6e
LL
8562012-07-14 Leo Liu <sdl.web@gmail.com>
857
858 * fringe.c: Add a new bitmap exclamation-mark.
859
5a1131d9
EZ
8602012-07-14 Eli Zaretskii <eliz@gnu.org>
861
862 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
863
864 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
865 (HAVE_MENUS): Don't define, defined by editing config.in with
866 msdos/sed2v2.inp.
867 (GMALLOC_INHIBIT_VALLOC): Don't define.
868 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
869
22e983b7
JB
8702012-07-14 Juanma Barranquero <lekktu@gmail.com>
871
872 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
873
5b3f250f
GM
8742012-07-14 Glenn Morris <rgm@gnu.org>
875
876 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
877 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
878 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
879
33d63ff4
GM
8802012-07-13 Glenn Morris <rgm@gnu.org>
881
5b633342
GM
882 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
883
33d63ff4
GM
884 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
885 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
886
b55b9f85
JD
8872012-07-13 Jan Djärv <jan.h.d@swipnet.se>
888
0dc8cf50
JD
889 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
890 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
891 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
892 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
893 where appropriate.
894 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
895 as boolean expression.
896 (x_set_window_size): Remove unused variable toolbar.
897 (ns_get_color_default, ns_mod_to_lisp): Remove.
898 (ns_mouse_position): Remove unused variables xchar and ychar.
899 (ns_compute_glyph_string_overhangs): Remove unused variable face.
900 (ns_set_vertical_scroll_bar): Remove unused variable count.
901 (ns_delete_terminal): Remove unused variable i.
902 (ns_term_init): Remove unused variables r, g and b.
903 (mouseDown): Remove unused variable window.
904 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
905 (initFrameFromEmacs): Remove unused variable vbextra.
906 (mouseEntered): Remove unused variables p and dpyinfo.
907 (mouseExited): Remove unused variables p and r.
908 (ns_define_frame_cursor, ns_clear_frame_area)
909 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
910 (menuDown): Assign [sender tag] to variable and cast the variable.
911
912 * nsterm.h (menuDown): Add id as type to argument sender.
913 (ns_display_info_for_name): Add Lisp_Object argument.
914 (ns_term_init): Add Lisp_Object argument.
915 (ns_map_event_to_object): Add void argument.
916 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
917 prototype with arguments and only declare if __OBJC__.
918 (nxatoms_of_nsselect): Add void argument.
919 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
920 (ns_alloc_autorelease_pool): Add void argument.
921 (ns_release_autorelease_pool): Add void* argument.
922 (ns_get_defaults_value): Add const char* argument.
923
924 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
925 (initFromContents): Use SSDATA where appropriate.
926 (ns_update_menubar): Add braces to ambigous if-else.
927 (initWithTitle): Put () around assignment in if statement.
928 (ns_menu_show): Remove unused variables window and keymap.
929 (update_frame_tool_bar): Remove unused variable selected_p.
930 (initWithContentRect): Remove unused variable this_cmd_name.
931
932 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
933 appropriate.
934 (setXBMColor): Remove unused variable len.
935 (setPixmapData): Put () around assignment in loop statement.
936
937 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
938 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
939 where appropriate.
940 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
941 around assignment in loop statement.
942 (nsfont_open): Remove unused variable i.
943 (nsfont_open): Remove unused variable len.
944 (nsfont_draw): Remove unused variable cs.
945
946 * nsfns.m (x_set_icon_name, ns_set_name_internal)
947 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
948 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
949 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
950 (Fns_font_name, Fns_perform_service)
951 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
952 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
953 (ns_set_name): Remove unused variable view.
954 (x_set_menu_bar_lines): Remove unused variable olines.
955 (x_set_tool_bar_lines): Remove unused variable root_window.
956 (Fns_list_colors): Put () around assignment in while statement.
957 (Fns_perform_service): Remove unused variable len.
958 (Fns_display_usable_bounds): Remove unused variable top.
959 (syms_of_nsfns): Remove unused variable i.
960
b55b9f85
JD
961 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
962 memcpy (Bug#11907).
963
ed9265fc 9642012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
965
966 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
967 and free it with DestroyExceptionInfo (Bug#11558).
968
ef099b57
JB
9692012-07-13 Juanma Barranquero <lekktu@gmail.com>
970
971 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
972 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
973 Set here, not in nt/config.nt.
974
ea814a5d
EZ
9752012-07-13 Eli Zaretskii <eliz@gnu.org>
976
977 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
978 cursor overflow into the last glyph on display line when the right
979 fringe is off. (Bug#11832)
980
1a952767
PE
9812012-07-13 Paul Eggert <eggert@cs.ucla.edu>
982
983 * xdisp.c (produce_special_glyphs): Now static.
984 * dispextern.h (produce_special_glyphs): Remove decl.
985
983188fd
GM
9862012-07-13 Glenn Morris <rgm@gnu.org>
987
32fb4bb6
GM
988 * s/bsd-common, s/cygwin.h: Remove empty files.
989 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
990
983188fd
GM
991 * s/usg5-4-common.h (USG, USG5):
992 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
993 * s/sol2-6.h (SOLARIS2):
994 * s/irix6-5.h (IRIX6_5):
995 * s/hpux10-20.h (USG, USG5, HPUX):
996 * s/gnu-linux.h (USG, GNU_LINUX):
997 * s/freebsd.h (BSD_SYSTEM):
998 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
999 * s/cygwin.h (CYGWIN):
1000 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1001 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1002
d1e68667 10032012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1004
1005 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1006
6de0e799
GM
10072012-07-13 Glenn Morris <rgm@gnu.org>
1008
739ae010
GM
1009 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1010
dbee5793
GM
1011 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1012
6de0e799
GM
1013 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1014 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1015
b82da769
GM
10162012-07-12 Glenn Morris <rgm@gnu.org>
1017
4fae5a7a 1018 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1019
1020 * process.c (init_process_emacs): Rename from init_process.
1021 The old name is also the name of a Mach system call.
1022 * lisp.h, emacs.c: Update for this name change.
1023 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1024 longer needed.
1025
5a979817
EZ
10262012-07-12 Eli Zaretskii <eliz@gnu.org>
1027
1028 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1029 memmove call that removes glyphs covered by the left truncation
1030 glyph. Improve commentary.
1031 (display_line): Fix display of continuation glyphs on GUI frames
1032 when the right fringe is turned off and variable-size fonts are
1033 used in the window. Move the code that appends a stretch glyph to
1034 produce_special_glyphs, so that it could be used for truncation
1035 and continuation glyphs alike.
1036 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1037 glyph of a suitably computed width, to align the special glyphs at
1038 the window margin. Code moved from display_line. (Bug#11832)
1039
3e91a053
GM
10402012-07-12 Glenn Morris <rgm@gnu.org>
1041
ba9e4b84
GM
1042 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1043
1044 * s/gnu-linux.h, s/hpux10-20.h:
1045 Do not unconditionally define HAVE_XRMSETDATABASE.
1046
3e91a053
GM
1047 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1048
b300b1f4
PE
10492012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 Fix typos that broke OS X build.
1052 Reported by Randal L. Schwartz in
1053 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1054 * nsterm.m (ns_timeout): Add missing local decl.
1055 (ns_get_color): snprintf -> sprintf, to fix typo.
1056
6e777848
GM
10572012-07-12 Glenn Morris <rgm@gnu.org>
1058
3f922c37
GM
1059 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1060 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1061 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1062 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1063
0ab7b23a
GM
1064 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1065 Move PTY_OPEN to configure.
1066
6e777848
GM
1067 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1068 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1069 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1070
4a7edc24
DA
10712012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 Use empty_unibyte_string where applicable.
1074 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1075 * lread.c (read1): Likewise.
1076 * xsettings.c (syms_of_xsettings): Likewise.
1077
308aab79
GM
10782012-07-12 Glenn Morris <rgm@gnu.org>
1079
42bd1719
GM
1080 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1081 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1082 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1083 * s/hpux10-20.h (RUN_TIME_REMAP):
1084 * s/bsd-common.h (TABDLY): Move to configure.
1085
1086 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1087
1088 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1089
ea0bbd17 1090 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1091 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1092
1093 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1094
308aab79
GM
1095 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1096 * s/template.h: Move NARROWPROTO to configure.
1097
ee1cf5cf
GM
10982012-07-11 Glenn Morris <rgm@gnu.org>
1099
30fe9bf4
GM
1100 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1101 unused since 2011-01-17 change to systty.h.
1102
ee1cf5cf
GM
1103 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1104 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1105 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1106
63e47e07
PE
11072012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1110
c43fb4c3
GM
11112012-07-11 Glenn Morris <rgm@gnu.org>
1112
1113 * s/darwin.h, s/gnu-linux.h, s/template.h:
1114 Move INTERRUPT_INPUT to configure.
1115
e8df9267
DA
11162012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1117
1118 Minor adjustments to interning code.
1119 * lisp.h (intern, intern_c_string): Redefine as static inline
1120 wrappers for intern_1 and intern_c_string_1, respectively.
1121 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1122 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1123 Vobarray checking.
e8df9267
DA
1124 * font.c (font_intern_prop): Likewise. Adjust comment.
1125 * w32font.c (intern_font_name): Likewise.
1126
34348bd4
AS
11272012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1128
d96a1e0c
AS
1129 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1130
34348bd4
AS
1131 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1132 of Fcar/Fcdr if possible.
1133 * font.c (check_otf_features): Likewise.
1134 * fontset.c (Fnew_fontset): Likewise.
1135 * gnutls.c (Fgnutls_boot): Likewise.
1136 * minibuf.c (read_minibuf): Likewise.
1137 * msdos.c (IT_set_frame_parameters): Likewise.
1138 * xmenu.c (Fx_popup_dialog): Likewise.
1139 * w32menu.c (Fx_popup_dialog): Likewise.
1140
c8add24e
GM
11412012-07-11 Glenn Morris <rgm@gnu.org>
1142
4b575b3c
GM
1143 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1144 since nothing has defined it on these platforms.
1145
09f4e3b0
GM
1146 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1147 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1148
172bedef
GM
1149 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1150 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1151 Move CLASH_DETECTION to configure.
1152
249685df
GM
1153 * s/gnu.h: Remove file, which is now empty.
1154
c8add24e
GM
1155 * s/gnu.h, s/gnu-linux.h:
1156 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1157
b41253a3
JW
11582012-07-11 John Wiegley <johnw@newartisans.com>
1159
1160 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1161 function attribute, so we only use it if it exists in the
1162 compiler.
1163
d923b542
DA
11642012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1165
1166 Avoid call to strlen in fast_c_string_match_ignore_case.
1167 * search.c (fast_c_string_match_ignore_case): Change to use
1168 length argument. Adjust users accordingly.
1169 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1170
5ebbef1d
PE
11712012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1172
bb352260
PE
1173 Assume mkdir, rmdir.
1174 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1175 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1176
57054ddd
PE
1177 Assume rename.
1178 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1179
b747d3f7
PE
1180 Assume perror.
1181 * s/hpux10-20.h (HAVE_PERROR): Remove.
1182 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1183 Remove dummy definition, as this problem was obsolete long ago.
1184
5ebbef1d
PE
1185 Assume strerror.
1186 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1187
984e7f30
DA
11882012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1189
1190 Avoid calls to strlen in font processing functions.
1191 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1192 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1193 users accordingly.
d923b542
DA
1194 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1195 Adjust prototypes.
1196 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1197 Change to return ptrdiff_t.
984e7f30
DA
1198 (xfont_list_pattern, xfont_match): Use length returned by
1199 xfont_decode_coding_xlfd.
1200 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1201
20e94fdd
GM
12022012-07-11 Glenn Morris <rgm@gnu.org>
1203
9d596af3
GM
1204 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1205 Move DONT_REOPEN_PTY to configure.
1206
20e94fdd
GM
1207 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1208 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1209
e99a530f
PE
12102012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1211
22ffb973
PE
1212 Remove "#define unix" that is no longer needed (Bug#11905).
1213 * s/aix4-2.h (unix): Remove; no longer needed.
1214
e9a9ae03
PE
1215 EMACS_TIME simplification (Bug#11875).
1216 This replaces macros (which typically do not work in GDB)
1217 with functions, typedefs and enums, making the code easier to debug.
1218 The functional style also makes code easier to read and maintain.
1219 * systime.h: Include <sys/time.h> on all hosts, not just if
1220 WINDOWSNT, since 'struct timeval' is needed in general.
1221 (EMACS_TIME): Now a typedef, not a macro.
1222 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1223 not macros.
1224 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1225 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1226 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1227 (EMACS_TIME_LE): Now functions, not macros.
1228 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1229 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1230 which are not functions. All uses rewritten to use:
1231 (make_emacs_time): New function.
1232 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1233 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1234 not functions. All uses rewritten to use the following, respectively:
1235 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1236 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1237 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1238 * fileio.c (Fcopy_file):
1239 * xterm.c (XTflash): Get the current time closer to when it's used.
1240 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1241
ffacb126
PE
1242 * bytecode.c (targets): Suppress -Woverride-init warnings.
1243
e99a530f
PE
1244 Simplify by avoiding confusing use of strncpy etc.
1245 * doc.c (Fsnarf_documentation):
1246 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1247 * frame.c (Fmake_terminal_frame):
1248 * gtkutil.c (get_utf8_string):
1249 * lread.c (openp):
1250 * nsmenu.m (ns_update_menubar):
1251 * regex.c (regerror):
1252 Prefer memcpy to strncpy and strncat when either will do.
1253 * fileio.c (Fsubstitute_in_file_name):
1254 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1255 (menu_separator_name_p):
1256 * nsmenu.m (ns_update_menubar):
1257 Prefer memcmp to strncmp when either will do.
1258 * nsterm.m: Include <ftoastr.h>.
1259 (ns_get_color):
1260 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1261 Prefer snprintf to strncpy.
1262 * nsterm.m (ns_term_init):
1263 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1264 * nsterm.m (ns_term_init):
1265 Avoid the need for strncpy, by using build_string or
1266 make_unibyte_string directly. Use dtoastr, not snprintf.
1267 * process.c (Fmake_network_process): Diagnose service names that
1268 are too long, rather than silently truncating them or creating
1269 non-null-terminated names.
1270 (Fnetwork_interface_info): Likewise, for interface names.
1271 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1272 Prefer sprintf to strncat.
1273 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1274 Prefer vsnprintf to vsprintf + strncpy.
1275
c59592b3
GM
12762012-07-10 Glenn Morris <rgm@gnu.org>
1277
1278 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1279 Clarify fallback case.
1280
7d7bbefd
DA
12812012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1282
1283 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1284 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1285 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1286 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1287 where argument type is known to be a Lisp_Cons.
1288
3a4c8000
TT
12892012-07-10 Tom Tromey <tromey@redhat.com>
1290
1291 * bytecode.c (BYTE_CODE_THREADED): New macro.
1292 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1293 (enum byte_code_op): New type.
1294 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1295 (exec_byte_code): Use them. Use token threading when applicable.
1296
2a0213a6
DA
12972012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 Optimize pure C strings initialization.
1300 * lisp.h (make_pure_string): Fix prototype.
1301 (build_pure_c_string): New function, defined as static inline. This
1302 provides a better opportunity to optimize away calls to strlen when
1303 the function is called with compile-time constant argument.
1304 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1305 argument, adjust users accordingly. Use build_pure_c_string where
1306 appropriate.
1307 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1308 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1309 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1310
cb1caeaf
DA
13112012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 Avoid calls to strlen in miscellaneous functions.
1314 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1315 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1316 * lread.c (openp): Likewise.
1317
c293e30c
DA
13182012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1319
1320 Avoid calls to strlen in path processing functions.
1321 * fileio.c (file_name_as_directory): Add comment. Change to add
1322 srclen argument and return the length of result. Adjust users
1323 accordingly.
1324 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1325 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1326 users accordingly.
1327 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1328
9e059e3f
GM
13292012-07-10 Glenn Morris <rgm@gnu.org>
1330
d02eb359
GM
1331 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1332 Move PENDING_OUTPUT_COUNT definition to configure.
1333
882cf227
GM
1334 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1335 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1336 * s/gnu.h (DATA_START): Move definitions to configure.
1337
af6e839f
GM
1338 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1339 We include usg5-4-common.h, which defines them both.
1340
40289a12
GM
1341 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1342 O_RDONLY already includes it).
1343
9e059e3f
GM
1344 Stop ns builds setting the EMACSLOADPATH environment variable.
1345 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1346 Now it does not set EMACSLOADPATH, just returns the load-path string.
1347 * nsterm.h: Update accordingly.
1348 * lread.c [HAVE_NS]: Include nsterm.h.
1349 (init_lread) [HAVE_NS]: Use ns_load_path.
1350 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1351
7c4e8ec0
GM
13522012-07-09 Glenn Morris <rgm@gnu.org>
1353
d4f600ff
GM
1354 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1355 since the included bsd-common.h does so.
1356
cbb31951
GM
1357 Stop ns builds setting the EMACSPATH environment variable.
1358 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1359 (ns_init_paths): Do not set EMACSPATH.
1360 * nsterm.h (ns_exec_path): Add it.
1361 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1362 Use ns_exec_path.
1363
7c4e8ec0
GM
1364 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1365
26bccfae
PE
13662012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1367
a0bee46f
PE
1368 * process.c (wait_reading_process_output): 'waitchannels' was unset
1369 when read_kbd || !NILP (wait_for_cell); fix this.
1370
5994c183
PE
1371 Add GCC-style 'const' attribute to functions that can use it.
1372 * character.h (char_resolve_modifier_mask):
1373 * keyboard.h (make_ctrl_char):
1374 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1375 (init_character_once, next_almost_prime, init_fns, init_image)
1376 (flush_pending_output, init_sound):
1377 * mem-limits.h (start_of_data):
1378 * menu.h (finish_menu_items):
1379 Add ATTRIBUTE_CONST.
1380 * emacs.c (DEFINE_DUMMY_FUNCTION):
1381 Declare the dummy function with ATTRIBUTE_CONST.
1382 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1383 Add decls with ATTRIBUTE_CONST.
1384
26bccfae
PE
1385 Minor improvements to make_formatted_string.
1386 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1387 where int is good enough, as vsprintf returns an int.
1388 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1389
a8290ec3
DA
13902012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1391
1392 Use make_formatted_string to avoid double length calculation.
1393 * lisp.h (make_formatted_string): New prototype.
1394 * alloc.c (make_formatted_string): New function.
1395 * buffer.c (Fgenerate_new_buffer_name): Use it.
1396 * dbus.c (syms_of_dbusbind): Likewise.
1397 * editfns.c (Fcurrent_time_zone): Likewise.
1398 * filelock.c (get_boot_time): Likewise.
1399 * frame.c (make_terminal_frame, set_term_frame_name)
1400 (x_report_frame_params): Likewise.
1401 * image.c (gs_load): Likewise.
1402 * minibuf.c (get_minibuffer): Likewise.
1403 * msdos.c (dos_set_window_size): Likewise.
1404 * process.c (make_process): Likewise.
1405 * xdisp.c (ensure_echo_area_buffers): Likewise.
1406 * xsettings.c (apply_xft_settings): Likewise.
1407
d01ba2f1
GM
14082012-07-09 Glenn Morris <rgm@gnu.org>
1409
1410 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1411 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1412 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1413 * nsterm.h (ns_etc_directory): Add it.
1414 * callproc.c [HAVE_NS]: Include nsterm.h.
1415 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1416
f1f924b6
DA
14172012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1418
1419 Move marker debugging code under MARKER_DEBUG.
1420 * marker.c (MARKER_DEBUG): Move marker debugging code under
1421 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1422 for bootstrap with --enable-checking (~3x slowdown reported
1423 by Juanma Barranquero <lekktu@gmail.com>).
1424 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1425
ab531b66
PE
14262012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1429 See <http://bugs.gnu.org/11825#29>.
1430
c4b3bc8a
EZ
14312012-07-08 Eli Zaretskii <eliz@gnu.org>
1432
1433 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1434 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1435 (display_line): Add commentary about displaying truncation glyphs
1436 on GUI frames.
1437 (produce_special_glyphs): Move here from term.c.
1438
1439 * term.c (produce_special_glyphs): Move to xdisp.c.
1440
1441 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1442 section.
c4b3bc8a 1443
b676b881
AS
14442012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1445
f17c5273
AS
1446 * xdisp.c (display_line): Avoid warning about implicit declaration
1447 of FRAME_FONT.
1448
298819b9
AS
1449 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1450
b676b881
AS
1451 * lisp.h: Remove empty conditional.
1452
6045c4fd
PE
14532012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1454
b3350bf9
PE
1455 * lread.c (load_path_check): Now static.
1456
6045c4fd
PE
1457 Fix some minor --with-ns problems found by static checking.
1458 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1459 (x_set_font) [!HAVE_X_WINDOWS]:
1460 * image.c (xpm_load_image) [HAVE_NS]:
1461 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1462 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1463 Remove unused local.
1464 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1465 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1466 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1467 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1468 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1469 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1470 Fix pointer signedness problem.
1471 * xfaces.c (FRAME_X_FONT_TABLE):
1472 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1473
929e7845
GM
14742012-07-07 Glenn Morris <rgm@gnu.org>
1475
1476 * lread.c (load_path_check): New function, split from init_lread.
1477 (init_lread): Reorganize. Motivation:
1478 If EMACSLOADPATH is set, check/warn about that rather than the
1479 defaults, which we are not going to use. Hence we can remove
1480 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1481 Don't warn if site-lisp directories are missing.
1482 If not installed, start from a blank load-path, since
1483 PATH_LOADSEARCH refers to the eventual installation directories.
1484
58dd0aa4
EZ
14852012-07-07 Eli Zaretskii <eliz@gnu.org>
1486
1487 Support truncation and continuation glyphs on GUI frames, when
1488 fringes are disabled. (Bug#11832)
1489 * xdisp.c (init_iterator): Get dimensions of truncation and
1490 continuation glyphs even if on GUI frames. Adjust
1491 it->last_visible_x on GUI frames when the left or right fringes,
1492 or both, are absent.
1493 (start_display, move_it_in_display_line_to): Handle the case of a
1494 GUI frame without a fringe to display continuation or truncation
1495 glyphs.
1496 (insert_left_trunc_glyphs): Support GUI frames: make sure
1497 truncation glyphs overwrite enough glyphs from the current line to
1498 have sufficient space in pixels.
1499 (display_line): Support truncation and continuation glyphs on GUI
1500 frames. If some spare pixels are left on the line after inserting
1501 the truncation glyphs, fill that space with a stretch glyph of a
1502 suitably computed width.
1503
1504 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1505 produce_glyphs, to support GUI sessions.
1506
31571fd7
PE
15072012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1508
5a16b9bc
PE
1509 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1510
f3047c75
PE
1511 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1512
31571fd7
PE
1513 Do not require float-time's arg to fit in time_t (Bug#11825).
1514 This works better on hosts where time_t is unsigned, and where
1515 float-time is applied to the (negative) difference between two times.
1516 * editfns.c (decode_time_components): Last arg is now double *,
1517 not int *, and means to store all the result as a double, without
1518 worrying about whether the seconds part fits in time_t.
1519 All callers changed.
1520 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1521 All callers changed.
1522 (Ffloat_time): Do not fail merely because the specified time falls
1523 outside of time_t range.
1524
4516fbef
GM
15252012-07-07 Glenn Morris <rgm@gnu.org>
1526
1527 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1528 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1529 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1530
07adc2c6
JB
15312012-07-07 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1534 Update dependencies.
1535
1536 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1537
fd573f31
PE
15382012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1539
fee5959d
PE
1540 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1541 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1542 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1543 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1544 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1545 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1546
fd573f31
PE
1547 * xfont.c (compare_font_names): Redo to omit the need for casts.
1548
ddadbc0e
AS
15492012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1550
fca8d6b6
AS
1551 * xfns.c (Fx_change_window_property): Doc fix.
1552 * w32fns.c (Fx_change_window_property): Doc fix.
1553
ddadbc0e
AS
1554 * w32fns.c (Fx_window_property): Accept the same arguments as the
1555 X Windows version. Doc fix.
1556 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1557
ed9265fc 15582012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1559 Eli Zaretskii <eliz@gnu.org>
1560
1561 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1562 Windows-specific code from nt/config.nt moved here.
1563 Obsolete settings removed.
1564
216ee680
PE
15652012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1566
1567 * process.c: Avoid unnecessary calls to gettime.
1568 (wait_reading_process_output): Don't get the time of day
1569 when gobbling data immediately and not waiting, as there's no need
1570 for it in that case. This removes a FIXME.
1571
bdd091e4
JD
15722012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1573
1574 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1575 is defined (Bug#11768).
1576
9d44f8ce
DA
15772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1578
1579 Fix marker debugging code.
1580 * marker.c (byte_char_debug_check): Do not perform the check
1581 if buffer is not multibyte.
090bd7cb
JB
1582 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1583 Call byte_char_debug_check with correct arguments.
9d44f8ce 1584
90fc4786
DA
15852012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1586
1587 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1588 * marker.c (byte_char_debug_check, count_markers):
1589 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1590 (byte_debug_flag): Remove.
1591 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1592 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1593
7b7ae965
DA
15942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1595
4e57b342
DA
1596 Avoid code repetition in marker-related functions.
1597 * marker.c (attach_marker): New function.
1598 (Fset_marker, set_marker_restricted, set_marker_both)
1599 (set_marker_restricted_both): Use it.
1600 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1601 Consistently rename charno to charpos.
1602 (marker_position): Add eassert.
1603 (marker_byte_position): Convert to eassert.
1604
16052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1606
1607 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1608 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1609 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1610
657924ff
DA
16112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1612
1613 Introduce fast path for the widely used marker operation.
1614 * alloc.c (build_marker): New function.
1615 * lisp.h (build_marker): New prototype.
1616 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1617 * composite.c (autocmp_chars): Likewise.
1618 * editfns.c (buildmark): Remove.
1619 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1620 (save_restriction_save): Use build_marker.
1621 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1622 * window.c (save_window_save): Likewise.
1623
041a49a6
DA
16242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1625
1626 Do not use Fdelete_overlay in delete_all_overlays
1627 to avoid redundant calls to unchain_overlay.
1628 * buffer.c (drop_overlay): New function.
1629 (delete_all_overlays, Fdelete_overlay): Use it.
1630 * minibuf.c (get_minibuffer): Fix comment.
1631
7dca65a4
PE
16322012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 Port to OpenBSD 5.1 amd64.
1635 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1636 This is needed for OpenBSD, and should be harmless on all BSD systems.
1637 Also, include <sys/sysctl.h>, as it should be available on all
1638 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1639 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1640 use p_pid member, not kp_proc.pid.
1641
8eb876e2
GM
16422012-07-06 Glenn Morris <rgm@gnu.org>
1643
1644 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1645
38182d90
PE
16462012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 More xmalloc and related cleanup.
1649 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1650 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1651 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1652 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1653 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1654 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1655 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1656 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1657 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1658 * xterm.c:
1659 Omit needless casts involving void * pointers and allocation.
1660 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1661 as the former is more robust if P's type is changed.
1662 Prefer xzalloc to xmalloc + memset 0.
1663 Simplify malloc-or-realloc to realloc.
1664 Don't worry about xmalloc returning a null pointer.
1665 Prefer xstrdup to xmalloc + strcpy.
1666 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1667 growing it.
1668 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1669 alloca of a constant.
1670
6dd5a677
EZ
16712012-07-05 Eli Zaretskii <eliz@gnu.org>
1672
1673 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1674 hscroll is larger than the line width. Fixes long and futile
1675 looping inside extend_face_to_end_of_line (on a TTY) producing
1676 glyphs that are not needed and thrown away.
1677
6b312f0f
DA
16782012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1679
1680 * marker.c (set_marker_restricted_both): Simplify by using
1681 clip_to_bounds.
1682
f520ef9b
PE
16832012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1684
1685 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1686
383b7c95
JD
16872012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1688
1689 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1690 not defined (Bug#11768).
1691 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1692 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1693 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1694 followed by gtk_box_set_homogeneous (Bug#11768).
1695 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1696 (update_theme_scrollbar_width, xg_create_scroll_bar):
1697 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1698 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1699 (is_box_type): New function (Bug#11768).
1700 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1701 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1702 with default display (Bug#11768).
1703
d6e7bf45
EZ
17042012-07-05 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (window_hscroll_limited): New function.
1707 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1708 coordinates when window's hscroll is set to insanely large
1709 values. (Bug#11857)
1710
431391ec
JB
17112012-07-05 Juanma Barranquero <lekktu@gmail.com>
1712
1713 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1714 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1715
23f86fce
DA
17162012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1717
1718 Cleanup xmalloc.
1719 * lisp.h (xzalloc): New prototype. Omit needless casts.
1720 * alloc.c (xzalloc): New function. Omit needless casts.
1721 * charset.c: Omit needless casts. Convert all calls to
1722 xmalloc with following memset to xzalloc.
1723 * dispnew.c: Likewise.
1724 * fringe.c: Likewise.
1725 * image.c: Likewise.
1726 * sound.c: Likewise.
1727 * term.c: Likewise.
1728 * w32fns.c: Likewise.
1729 * w32font.c: Likewise.
1730 * w32term.c: Likewise.
1731 * xfaces.c: Likewise.
1732 * xfns.c: Likewise.
1733 * xterm.c: Likewise.
1734 * atimer.c: Omit needless casts.
1735 * buffer.c: Likewise.
1736 * callproc.c: Likewise.
1737 * ccl.c: Likewise.
1738 * coding.c: Likewise.
1739 * composite.c: Likewise.
1740 * doc.c: Likewise.
1741 * doprnt.c: Likewise.
1742 * editfns.c: Likewise.
1743 * emacs.c: Likewise.
1744 * eval.c: Likewise.
1745 * filelock.c: Likewise.
1746 * fns.c: Likewise.
1747 * gtkutil.c: Likewise.
1748 * keyboard.c: Likewise.
1749 * lisp.h: Likewise.
1750 * lread.c: Likewise.
1751 * minibuf.c: Likewise.
1752 * msdos.c: Likewise.
1753 * print.c: Likewise.
1754 * process.c: Likewise.
1755 * region-cache.c: Likewise.
1756 * search.c: Likewise.
1757 * sysdep.c: Likewise.
1758 * termcap.c: Likewise.
1759 * terminal.c: Likewise.
1760 * tparam.c: Likewise.
1761 * w16select.c: Likewise.
1762 * w32.c: Likewise.
1763 * w32reg.c: Likewise.
1764 * w32select.c: Likewise.
1765 * w32uniscribe.c: Likewise.
1766 * widget.c: Likewise.
1767 * xdisp.c: Likewise.
1768 * xmenu.c: Likewise.
1769 * xrdb.c: Likewise.
1770 * xselect.c: Likewise.
1771
0497dc44
PE
17722012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 * fileio.c (time_error_value): Check the right error number.
1775 Problem reported by Troels Nielsen in
1776 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1777
356e7178
PE
17782012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1779
4e71fd89
PE
1780 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1781 This should be fixed in a better way; see Eli Zaretskii in
1782 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1783 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1784
f0941253
PE
1785 * fileio.c (time_error_value): Rename from special_mtime.
1786 The old name's problems were noted by Eli Zaretskii in
1787 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1788
065c9eb4
PE
1789 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1790 This variable's comment says Emacs needs at least one GDB-visible
1791 symbol of type enum pvec_type, to work around GDB problems.
1792 The symbol's value doesn't matter.
1793
356e7178
PE
1794 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1795 that causes compilation to fail on pre-C99 compilers.
1796
ed9265fc 17972012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1798
1799 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1800 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1801
3884d954
DA
18022012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1803
d209e2fb 1804 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1805 headers for buffer_defaults and buffer_local_symbols.
1806 Reported by Juanma Barranquero <lekktu@gmail.com>.
1807
ee28be33
SM
18082012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1809
1810 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1811 * lisp.h (enum pvec_type): Use fewer bits.
1812 (PSEUDOVECTOR_SIZE_BITS): New constant.
1813 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1814 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1815 change in pvec_type.
1816 (PSEUDOVECTOR_TYPEP): New macro.
1817 (TYPED_PSEUDOVECTORP): Use it.
1818 * fns.c (internal_equal): Adapt code to extract pvectype.
1819 * emacs.c (gdb_pvec_type): Update type.
1820 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1821 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1822 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1823 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1824 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1825 abusing vector->header.next.nbytes.
1826 (live_vector_p): Use PVEC_TYPE.
1827 (mark_object): Adapt code to extract pvectype. Use switch.
1828
c7f2cd7f
PE
18292012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1830
1831 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1832 Tighten new eassert a bit.
1833
8ce70ed2
DA
18342012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1835
1836 Fix compilation with --enable-gcc-warnings and -O1
1837 optimization level.
1838 * doprnt.c (doprnt): Change type of tem to int, initialize
1839 to avoid compiler warning. Add eassert.
1840 * search.c (simple_search): Initialize match_byte to avoid
1841 compiler warning. Add eassert.
1842
dea7f1e5
PE
18432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1844
24a212eb
PE
1845 Avoid weird behavior with large horizontal scrolls.
1846 Without this change, for example, large hscroll values would
1847 mess up Emacs's display on Fedora 15 x86, presumably due to
1848 overflows in int calculations in the display code.
1849 Also, if buffers had long lines, Emacs would freeze.
1850 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1851 (set_window_hscroll): New function, containing the old guts of
1852 Fset_window_hscroll. Return the clipped value.
1853 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1854 This avoids the need to check against PTRDIFF_MAX.
1855
dea7f1e5
PE
1856 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1857
76046526
DA
18582012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1859
1860 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1861
39adff0d
PE
18622012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1863
63807d47
PE
1864 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1865 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1866 since GCC 4.4.6 issues a bogus warning for them.
1867
39adff0d
PE
1868 Fix bugs in file timestamp newness comparisons.
1869 * fileio.c (Ffile_newer_than_file_p):
1870 * lread.c (Fload): Use full timestamp resolution of files,
1871 not just the 1-second resolution, so that files that are only
1872 slightly newer still count as newer.
1873 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1874 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1875
dbeed9a6
PE
18762012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1877
1878 * fileio.c: Improve handling of file time marker. (Bug#11852)
1879 (special_mtime): New function.
1880 (Finsert_file_contents, Fverify_visited_file_modtime):
1881 Use it to set special mtime values consistently.
1882
636334d6
AS
18832012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1884
1885 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1886 marker for non-existing file. (Bug#11852)
1887
e2017fe2
GM
18882012-07-03 Glenn Morris <rgm@gnu.org>
1889
1890 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1891 and did not make it into globals.h).
1892
404dbd37
TT
18932012-07-03 Tom Tromey <tromey@redhat.com>
1894
1895 * window.c (Fset_window_margins, Fset_window_fringes)
1896 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1897 * textprop.c (Fprevious_property_change): No longer static.
1898 * syntax.c (Fsyntax_table_p): No longer static.
1899 * process.c (Fget_process, Fprocess_datagram_address): No longer
1900 static.
1901 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1902 * keyboard.c (Fcommand_execute): No longer static.
1903 Remove EXFUN.
1904 * insdel.c (Fcombine_after_change_execute): No longer static.
1905 * image.c (Finit_image_library): No longer static.
1906 * fileio.c (Fmake_symbolic_link): No longer static.
1907 * eval.c (Ffetch_bytecode): No longer static.
1908 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1909 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1910 No longer static.
404dbd37
TT
1911 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1912 static.
1913 * dired.c (Ffile_attributes): No longer static.
1914 * composite.c (Fcomposition_get_gstring): No longer static.
1915 * callproc.c (Fgetenv_internal): No longer static.
1916
1917 * ccl.h: Remove EXFUNs.
1918 * buffer.h: Remove EXFUNs.
1919 * dispextern.h: Remove EXFUNs.
1920 * intervals.h: Remove EXFUNs.
1921 * fontset.h: Remove EXFUN.
1922 * font.h: Remove EXFUNs.
1923 * dosfns.c (system_process_attributes): Remove EXFUN.
1924 * keymap.h: Remove EXFUNs.
1925 * lisp.h: Remove EXFUNs.
1926 * w32term.h: Remove EXFUNs.
1927 * window.h: Remove EXFUNs.
1928 * xsettings.h: Remove EXFUN.
1929 * xterm.h: Remove EXFUN.
1930
8e4fd1e1
GM
19312012-07-03 Glenn Morris <rgm@gnu.org>
1932
1933 * lisp.h (Frandom): Make it visible to C.
1934 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1935 buffer for invisible buffers. (Bug#1229)
1936
ca95b3eb
DA
19372012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1938
1939 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1940 values which aren't power of 2.
1941 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1942 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1943 accordingly.
1944
7555c33f
SM
19452012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1946
1947 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1948
1949 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1950
d12e8f5a
DA
19512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1952
1953 * alloc.c (allocate_vector_block): Remove redundant
1954 calls to mallopt if DOUG_LEA_MALLOC is defined.
1955 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1956 avoid calls to mallopt if zero_vector is returned.
1957
296094c3
DA
19582012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1959
1960 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1961 is enabled, avoid dereferencing NULL current_sblock if
1962 running undumped.
1963
36429c89
DA
19642012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1965
1966 Cleanup basic buffer management.
1967 * buffer.h (struct buffer): Change layout to use generic vector
1968 marking code. Fix some comments. Change type of 'clip_changed'
1969 to bitfield. Remove unused #ifndef old.
1970 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1971 (GET_OVERLAYS_AT): Fix indentation.
1972 (for_each_per_buffer_object_at): New macro.
1973 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1974 (Fbuffer_local_variables): Use it.
1975 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1976 * alloc.c (allocate_buffer): Adjust to match new layout of
1977 struct buffer. Fix comment.
1978 (mark_overlay): New function.
1979 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1980 Lisp area of struct buffer.
1981 (mark_object): Use it. Adjust marking of misc objects
1982 and related comments.
1983
3b3e4cac
PE
19842012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1985
1986 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1987 wrapper that is not needed because the wrapped code is a no-op (zero
1988 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1989 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1990
cf5c0175
DA
19912012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1992
1993 * alloc.c (mark_buffer): Simplify. Remove prototype.
1994 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1995 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1996 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1997 redundant calls to mark_vectorlike for bool vectors.
1998
ca26824c
GM
19992012-06-30 Glenn Morris <rgm@gnu.org>
2000
2e4c5312
GM
2001 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2002
ca26824c
GM
2003 * epaths.in (PATH_SITELOADSEARCH): New.
2004 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2005 This is rather than relying on --enable-locallisppath elements
2006 having "site-lisp" in their names. (Bug#10208#25, 11658)
2007
0d23c240
EZ
20082012-06-30 Eli Zaretskii <eliz@gnu.org>
2009
c9240d7a
EZ
2010 * w32proc.c (sys_select): Accept and ignore one more argument.
2011
2012 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2013
0d23c240 2014 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2015 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2016
2017 * sysdep.c: Don't include dos.h and dosfns.h.
2018
2019 * process.c (sys_select):
2020 * msdos.c (sys_select): Accept one more argument and ignore it.
2021
2022 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2023 adapt data types and code to that.
2024
2025 * dosfns.c:
2026 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2027 which clashes with the gnulib function of the same name.
2028
af5a5a98
AS
20292012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2030
c5e4379c
AS
2031 * font.c (font_style_to_value, font_style_symbolic)
2032 (font_prop_validate_style): Add type checks for values in
2033 font_style_table.
2034
af5a5a98
AS
2035 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2036 argument.
2037 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2038 uses.
2039
8d38f461
EZ
20402012-06-29 Eli Zaretskii <eliz@gnu.org>
2041
2e5a6631
EZ
2042 * xdisp.c (try_window_id): Undo last change.
2043
8d38f461
EZ
2044 * w32.c (getwd): Adjust commentary about startup_dir.
2045 (init_environment): Always call sys_access, even in non-MSVC
2046 builds. Don't chdir to the directory of the Emacs executable.
2047 This undoes code from 1997 which was justified by the need to
2048 "avoid conflicts when removing and renaming directories". But its
2049 downside was that every relative file name was being interpreted
2050 relative to the directory of the Emacs executable, which can never
2051 be TRT. In particular, it broke sys_access when called with
2052 relative file names.
2053 (sys_access): Map GetLastError to errno.
2054
2af3565e
DA
20552012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2056
2057 * window.h (struct window): Change type of 'fringes_outside_margins'
2058 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2059 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2060 Adjust comment.
2061 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2062 to ptrdiff_t.
2063
c8d3a25c 20642012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2065
c8d3a25c
GM
2066 * gnutls.c (emacs_gnutls_handshake):
2067 Add QUIT to make the loop interruptible.
57570cd3 2068
c8d3a25c 20692012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2070
c8d3a25c
GM
2071 * charset.c (init_charset): Make lack of etc/charsets fatal.
2072
3e984ee8
DA
20732012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2074
2075 * editfns.c (region_limit): Fix type mismatch.
2076
ef884f23
DA
20772012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2078
2079 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2080 undefined. Convert from xassert to eassert.
2081 * nsmenu.m: Convert from xassert to eassert.
2082 * nsterm.m: Likewise.
2083
7d7e0027
SM
20842012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2087
aa754e6a
PE
20882012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 Avoid integer overflow on scroll-left and scroll-right.
2091 * window.c (HSCROLL_MAX): New macro.
2092 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2093 overflow when requested scroll falls outside ptrdiff_t range.
2094
80b00b08
DA
20952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2096
2097 * window.h (struct window): Change type of 'hscroll',
2098 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2099 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2100 Adjust users accordingly.
2101 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2102 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2103 from EMACS_INT to ptrdiff_t.
2104 (make_window): Omit redundant initialization.
2105
62b2bcf6
JB
21062012-06-28 Juanma Barranquero <lekktu@gmail.com>
2107
2108 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2109
45942c7d
DA
21102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2111
2112 * window.h (struct window): Change type of 'use_time' and
2113 'sequence_number' from Lisp_Object to int.
2114 * frame.c (make_frame): Adjust users accordingly.
2115 * print.c (print_object): Likewise.
2116 * window.c (select_window, Fwindow_use_time, make_parent_window)
2117 (make_window): Likewise.
2118
e509cfa6
DA
21192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2120
2121 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2122 enabled with --enable-checking=[all,glyphs] configure option.
2123 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2124 adjust comments accordingly.
2125 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2126 undefined, adjust comments accordingly.
2127 * image.c: Likewise.
2128 * scroll.c: Likewise.
2129 * w32fns.c: Likewise.
2130 * w32term.c: Likewise.
2131 * xdisp.c: Likewise.
2132 * xfaces.c: Likewise.
2133 * xfns.c: Likewise.
2134 * xterm.c: Likewise.
2135
a54e2c05
DA
21362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 Generalize run-time debugging checks.
2139 * dispextern.h (XASSERTS): Remove.
2140 * fontset.c (xassert): Remove.
2141 Convert from xassert to eassert.
2142 * alloc.c: Convert from xassert to eassert.
2143 * bidi.c: Likewise.
2144 * dispnew.c: Likewise.
2145 * fns.c: Likewise.
2146 * fringe.c: Likewise.
2147 * ftfont.c: Likewise.
2148 * gtkutil.c: Likewise.
2149 * image.c: Likewise.
2150 * keyboard.c: Likewise.
2151 * menu.c: Likewise.
2152 * process.c: Likewise.
2153 * scroll.c: Likewise.
2154 * sound.c: Likewise.
2155 * term.c: Likewise.
2156 * w32console.c: Likewise.
2157 * w32fns.c: Likewise.
2158 * w32term.c: Likewise.
2159 * window.c: Likewise.
2160 * xdisp.c: Likewise.
2161 * xfaces.c: Likewise.
2162 * xfns.c: Likewise.
2163 * xselect.c: Likewise.
2164 * xterm.c: Likewise.
2165
1ec4b7b2
SM
21662012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2167
2168 * fns.c (maybe_resize_hash_table): Output message when growing the
2169 purify-hashtable.
2170
2014308a
DA
21712012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2172
2173 * alloc.c (allocate_string_data): Remove dead code.
2174 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2175 avoid GCC warning about unused macro.
2176
246155eb
DA
21772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2178
2179 * alloc.c (allocate_string): Omit intervals initialization.
2180 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2181 as in make_pure_string and make_pure_c_string.
2182
43184b7b
DA
21832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2184
d209e2fb 2185 * alloc.c (allocate_string): Fix last change.
43184b7b 2186
3fe6dd74
DA
21872012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2188
d209e2fb 2189 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2190 to memset, add explicit initialization where appropriate.
2191
1ba6038a
GM
21922012-06-27 Glenn Morris <rgm@gnu.org>
2193
2194 * lisp.mk (lisp): Remove paths.elc.
2195
c89926a5
CY
21962012-06-27 Chong Yidong <cyd@gnu.org>
2197
2198 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2199
ed6b3510
JW
22002012-06-26 John Wiegley <johnw@newartisans.com>
2201
1ec4b7b2 2202 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2203 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2204
ed6b3510
JW
2205 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2206 when building with Clang.
2207
8edd4a2b
SM
22082012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2209
2210 * eval.c (Fapply): Allow calling it with a single argument.
2211
f6f62d1b
EZ
22122012-06-26 Eli Zaretskii <eliz@gnu.org>
2213
2214 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2215 _stricmp and _strnicmp.
2216 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2217
62efea5e
DA
22182012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2219
2220 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2221 allocated window.
2222 (allocate_process): Likewise for new process.
8edd4a2b 2223 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2224 (allocate_frame): Likewise.
2225 * frame.c (make_frame): Omit redundant initialization.
2226 * window.c (make_parent_window): Use memset.
2227 (make_window): Omit redundant initialization.
2228 * process.c (make_process): Omit redundant initialization.
2229 * terminal.c (create_terminal): Likewise.
2230
42997f4d
DA
22312012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2232
2233 * term.c (delete_tty): Remove redundant call to memset.
2234
1130ecfc
DA
22352012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2236
2237 * alloc.c: Remove build_string.
2238 * lisp.h: Define build_string as static inline. This provides
2239 a better opportunity to optimize away calls to strlen when the
2240 function is called with compile-time constant argument.
2241 * image.c (imagemagick_error): Convert to build_string.
2242 * w32proc.c (sys_spawnve): Likewise.
2243 * xterm.c (x_term_init): Likewise.
2244
cf38a720
PE
22452012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2246
99027bdd
PE
2247 Use sprintf return value instead of invoking strlen on result.
2248 In the old days this wasn't portable, since some sprintf
2249 implementations returned char *. But they died out years ago and
2250 Emacs already assumes sprintf returns int.
2251 Similarly for float_to_string.
2252 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2253 * ccl.c (ccl_driver):
2254 * character.c (string_escape_byte8):
2255 * data.c (Fnumber_to_string):
2256 * doprnt.c (doprnt):
2257 * print.c (print_object):
2258 * xdisp.c (message_dolog):
2259 * xfns.c (syms_of_xfns):
2260 Use sprintf or float_to_string result to avoid need to call strlen.
2261 * data.c (Fnumber_to_string):
2262 Use make_unibyte_string, since the string must be ASCII.
2263 * lisp.h, print.c (float_to_string): Now returns int length.
2264 * term.c (produce_glyphless_glyph):
2265 Use sprintf result rather than recomputing it.
2266
cf38a720
PE
2267 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2268 * Makefile.in (ALL_CFLAGS):
2269 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2270 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2271
3511c784
DA
22722012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2273
0a08eb21 2274 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2275 strcasecmp if available.
2276 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2277
fb7da12e
AS
22782012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2279
2280 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2281 Avoid comma operator.
2282 * menu.c (push_submenu_start, push_submenu_end)
2283 (push_left_right_boundary, push_menu_pane): Likewise.
2284 * msdos.c (dos_rawgetc): Likewise.
2285
afa2ffd8
DA
22862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2287
2288 * xfns.c (xic_create_fontsetname): Remove redundant calls
2289 to memset.
2290
b3b4476b
PE
22912012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2292
4495ff38
PE
2293 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2294 sprintf already null-terminates its output.
2295
b3b4476b
PE
2296 * xfns.c (x_window): Remove redundant cast.
2297
b00876c9
DA
22982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2299
2300 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2301 `const char *' to `char *' to avoid compiler warning.
2302
d188e26b
PE
23032012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2304
885d1d74
PE
2305 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2306 instead of truncating it to 63 (admittedly a generous limit).
2307
d188e26b
PE
2308 * process.c: Fix spelling and caps in comments.
2309
e2f560b1
DN
23102012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2311
e86db54b 2312 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2313 * sysdep.c (setpgrp): Remove definition, not used in this file.
2314
7583a3a1
JB
23152012-06-24 Juanma Barranquero <lekktu@gmail.com>
2316
2317 * makefile.w32-in: Update dependencies.
2318
696056c2
EZ
23192012-06-24 Eli Zaretskii <eliz@gnu.org>
2320
2321 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2322 (SYSTIME_H): Add nt/inc/sys/time.h.
2323
2324 * systime.h [WINDOWSNT]: Include sys/time.h.
2325
2326 * s/ms-w32.h (struct timespec): Definition moved from
2327 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2328
845ca893
PE
23292012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2332 * buffer.h (buffer_slot_type_mismatch):
2333 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2334 * eval.c (unwind_to_catch):
2335 * image.c (my_png_error, my_error_exit):
2336 * keyboard.c (quit_throw_to_read_char, user_error)
2337 (Fexit_recursive_edit, Fabort_recursive_edit):
2338 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2339 (wrong_type_argument, buffer_overflow, __executable_start)
2340 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2341 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2342 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2343 (fatal):
2344 (child_setup) [!DOS_NT]:
2345 * lread.c (end_of_file_error, invalid_syntax):
2346 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2347 * puresize.h (pure_write_error):
2348 * search.c (matcher_overflow):
2349 * sound.c (sound_perror, alsa_sound_perror):
2350 * sysdep.c, syssignal.h (croak):
2351 * term.c (maybe_fatal, vfatal):
2352 * textprop.c (text_read_only):
2353 * undo.c (user_error):
2354 * unexmacosx.c (unexec_error):
2355 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2356 Use _Noreturn rather than NO_RETURN.
2357 No need for separate decl merely because of _Noreturn.
2358 * sound.c (sound_warning, parse_sound):
2359 Remove unnecessary forward decls.
2360
f1dd8073
PE
23612012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2362
2363 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2364 * lisp.h (WAIT_READING_MAX): New macro.
2365 * dispnew.c (Fsleep_for, sit_for):
2366 * keyboard.c (kbd_buffer_get_event):
2367 * process.c (Faccept_process_output):
2368 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2369 This improves on the previous patch, which introduced a bug
2370 when time_t is unsigned and as wide as intmax_t.
2371 See <http://bugs.gnu.org/9000#51>.
2372
b82c1755
EZ
23732012-06-23 Eli Zaretskii <eliz@gnu.org>
2374
2375 * dispnew.c (sit_for, Fsleep_for):
2376 * keyboard.c (kbd_buffer_get_event):
2377 * process.c (Faccept_process_output): Avoid compiler warnings when
2378 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2379
ca300656
JB
23802012-06-23 Juanma Barranquero <lekktu@gmail.com>
2381
049ec95b
JB
2382 * makefile.w32-in: Update dependencies.
2383
ca300656
JB
2384 * w32.c (ltime): Add return type and declare static.
2385 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2386
db7b8d06
PE
23872012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2390 Privately reported by Herbert J. Skuhra.
2391 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2392 All uses changed.
2393 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2394 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2395
0bd8297f
EZ
23962012-06-23 Eli Zaretskii <eliz@gnu.org>
2397
96512555
EZ
2398 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2399 last argument of make_unibyte_string.
2400
0bd8297f
EZ
2401 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2402 language ID in the event parameters.
2403
2404 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2405 event.code, not the obscure "character set ID".
2406
63def6b6
CY
24072012-06-23 Chong Yidong <cyd@gnu.org>
2408
2409 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2410
e8a02204
EZ
24112012-06-23 Eli Zaretskii <eliz@gnu.org>
2412
388cdec0
EZ
2413 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2414 * w32.c (fdutimens): New function.
2415
2416 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2417
2418 * s/ms-w32.h (pselect): Redirect to sys_select.
2419
2420 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2421
e8a02204
EZ
2422 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2423 in the logic of incrementing and decrementing the value of
2424 use_relocatable_buffers.
2425
d054f3fb
PE
24262012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2427
2428 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2429 Privately reported by Herbert J. Skuhra.
2430 [__FreeBSD__]: Remove "*/" typo after "#include".
2431 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2432 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2433 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2434 Don't assume EMACS_TIME and struct timeval are the same type.
2435
d35af63c
PE
24362012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 Support higher-resolution time stamps (Bug#9000).
2439 The time stamps are only nanosecond-resolution at the C level,
2440 since that's the best that any real-world system supports now.
2441 But they are picosecond-resolution at the Lisp level, as that's
2442 easy, and leaves room for future OS improvements.
2443
2444 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2445 (LIBES): Use it.
2446
2447 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2448 Don't get current time unless it's needed.
2449
2450 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2451 now provides it if it's absent.
2452 (start_atimer): Port to higher-res time stamps.
2453 Check for time stamp overflow. Don't get current time more
2454 often than is needed.
2455
2456 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2457 Include systime.h, not time.h.
2458 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2459
2460 * dired.c: Include stat-time.h.
2461 (Ffile-attributes): File times now have higher resolution.
2462
2463 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2464 (struct image): Timestamp now has higher resolution.
2465
2466 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2467 has at least microseconds now. All uses removed.
2468 (update_frame, update_single_window, update_window, update_frame_1)
2469 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2470
2471 * editfns.c (time_overflow): Now extern.
2472 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2473 (float-time, Fformat_time_string, Fcurrent_time_string)
2474 (Fcurrent_time_zone): Accept and generate higher-resolution
2475 time stamps.
2476 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2477 (decode_time_components, lisp_seconds_argument): New functions.
2478 (make_time): Now static.
2479 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2480 Report an error if the time is invalid, rather than having the caller
2481 do that.
2482
2483 * fileio.c: Include <stat-time.h>
2484 (Fcopy_file): Copy higher-resolution time stamps.
2485 Prefer to set the time stamp via a file descriptor if that works.
2486 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2487 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2488 (Fvisited_file_modtime, Fset_visited_file_modtime):
2489 Support higher-resolution time stamps.
2490
2491 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2492
2493 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2494
2495 * image.c (prepare_image_for_display, clear_image_cache)
2496 (lookup_image): Port to higer-resolution time stamps.
2497
2498 * keyboard.c (start_polling, bind_polling_period):
2499 Check for time stamp overflow.
2500 (read_char, kbd_buffer_get_event, timer_start_idle)
2501 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2502 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2503 Port to higher-resolution time stamps. Do not assume time_t is signed.
2504 (decode_timer): New function. Timers are now vectors of length 9,
2505 not 8, to accommodate the picosecond component.
2506 (timer_check_2): Use it.
2507
2508 * nsterm.m (select_timeout, timeval_subtract): Remove.
2509 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2510 as they're a bit more accurate and handle overflow better.
2511 (ns_select): Change prototype to be compatible with pselect.
2512 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2513 * nsterm.h (ns_select): Adjust prototype.
2514
2515 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2516 us-resolution time stamps.
2517 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2518
2519 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2520
2521 * lisp.h (time_overflow): New decl.
2522 (wait_reading_process_output): First arg is now intmax_t, not int,
2523 to accommodate larger waits.
2524
2525 * process.h (struct Lisp_Process.read_output_delay):
2526 Now counts nanoseconds, not microseconds.
2527 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2528 EMACS_HAS_USECS.
2529 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2530 (wait_reading_process_output):
2531 Port to ns-resolution time stamps.
2532 (Faccept_process_output, wait_reading_process_output):
2533 Check for time stamp overflow. Do not assume time_t is signed.
2534 (select_wrapper): Remove; we now use pselect.
2535 (Fprocess_attributes): Now generates ns-resolution time stamps.
2536
2537 * sysdep.c: Include utimens.h. Don't include utime.h
2538 or worry about struct utimbuf; gnulib does that for us now.
2539 (gettimeofday): Remove; gnulib provides a substitute.
2540 (make_timeval): New function.
2541 (set_file_times): Now sets ns-resolution time stamps.
2542 New arg FD; all uses changed.
2543 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2544 (system_process_attributes):
2545 Now returns ns-resolution time stamp. All uses changed.
2546 Check for time stamp overflow.
2547
2548 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2549 provides a substitute now.
2550
2551 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2552 since it guarantees struct timespec.
2553 (EMACS_TIME): Now struct timespec, so that we can support
2554 ns-resolution time stamps.
2555 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2556 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2557 (EMACS_USECS): Remove.
2558 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2559 so multiply the arg by 1000 before storing it.
2560 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2561 New macros.
2562 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2563 Port to ns-resolution time stamps.
2564 (EMACS_TIME_NEG_P): Remove; replaced by....
2565 (EMACS_TIME_SIGN): New macro.
2566 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2567 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2568 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2569 (make_timeval, make_lisp_time, decode_time_components): New decls.
2570 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2571 that it mishandled time_t overflow. You can't compare by subtracting!
2572 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2573 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2574
2575 * term.c: Include <sys/time.h>.
2576 (timeval_to_Time): New function, for proper overflow wraparound.
2577 (term_mouse_position, term_mouse_click): Use it.
2578
2579 * undo.c (record_first_change): Support higher-resolution time stamps
2580 in the undo buffer.
2581 (Fprimitive_undo): Use them when restoring time stamps.
2582
2583 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2584 (w32_get_internal_run_time):
2585 Port to higher-resolution Emacs time stamps.
2586 (ltime): Now accepts single 64-bit integer, as that's more convenient
2587 for callers.
2588
2589 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2590
2591 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2592 for compatibility with pselect. Support ns-resolution time stamps.
2593
2594 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2595
2596 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2597 Check for time stamp overflow, and support ns-resolution time stamps.
2598
2599 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2600 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2601 (timeval_subtract): Remove; no longer needed.
2602 (XTflash, XTring_bell, x_wait_for_event):
2603 Port to ns-resolution time stamps. Don't assume time_t is signed.
2604
b6a92dfe
CY
26052012-06-22 Chong Yidong <cyd@gnu.org>
2606
2607 * xdisp.c (x_consider_frame_title): Revert last change.
2608
d251c37c
EZ
26092012-06-22 Eli Zaretskii <eliz@gnu.org>
2610
2611 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2612 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2613 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2614 staticidx goes up to 1597 out of 1600 = 0x640.)
2615
f10deafb
PE
26162012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2617
2618 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2619 Otherwise, the umask might be mistakenly 0 while handling input signals.
2620
ec6de1e2
SM
26212012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2622
2623 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2624
28be1ada
DA
26252012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2626
2627 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2628 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2629 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2630 access to `contents' member of Lisp_Vector objects with AREF and ASET
2631 where appropriate.
2632
c6bf3022
CY
26332012-06-19 Chong Yidong <cyd@gnu.org>
2634
2635 * frame.c (delete_frame): When selecting a frame on a different
2636 text terminal, do not alter the terminal's top-frame.
2637
2638 * xdisp.c (format_mode_line_unwind_data): Record the target
2639 frame's selected window and its terminal's top-frame.
2640 (unwind_format_mode_line): Restore them.
2641 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2642 Callers changed.
2643 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2644 since tty frames can be explicitly named.
2645 (prepare_menu_bars): Likewise.
2646
2647 * term.c (Ftty_top_frame): New function.
2648
defd4196
PE
26492012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2650
2651 Port byte-code-meter to modern targets.
2652 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2653 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2654 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2655 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2656 (METER_1, METER_2): Simplify.
2657
1053a871
SM
26582012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2659
2660 * data.c (Fdefalias): Return `symbol' (bug#11686).
2661
b7e8d081
MR
26622012-06-18 Martin Rudalics <rudalics@gmx.at>
2663
2664 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2665 gets killed during executing of this function (Bug#11665).
2666 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2667 (Vkill_buffer_query_functions): In doc-string say that functions
2668 run by this hook should not change the current buffer.
2669
7ea2b339
PE
26702012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 Fix recently-introduced process.c problems found by static checking.
2673 * process.c (write_queue_push, write_queue_pop, send_process):
2674 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2675 (write_queue_pop): Fix pointer signedness problem.
2676 (send_process): Remove unused local.
2677
96a313a1
CY
26782012-06-17 Chong Yidong <cyd@gnu.org>
2679
2680 * xdisp.c (redisplay_internal): No need to redisplay terminal
2681 frames that are not on top.
2682
20ca2e94
TN
26832012-06-17 Troels Nielsen <bn.troels@gmail.com>
2684
2685 * process.c (make_process): Initialize write_queue.
2686 (write_queue_push, write_queue_pop): New functions.
2687 (send_process): Use them to maintain correct ordering of process
2688 writes (Bug#10815).
2689
9a900ca9
PE
26902012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2691
310fbfa8
PE
2692 * lisp.h (eassert): Assume C89 or later.
2693 This removes the need for CHECK.
2694 (CHECK): Remove. Its comments about always evaluating its
2695 argument were confusing, as 'eassert' typically does not evaluate
2696 its argument.
2697
27bb1ca4
PE
2698 * coding.c (produce_chars): Use ptrdiff_t, not int.
2699
9a900ca9
PE
2700 * xterm.c (x_draw_underwave): Check for integer overflow.
2701 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2702
41b7f8bc 27032012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2704
2705 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2706 referenced (Bug#11583).
2707
9b0e3eba
AA
27082012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2709
2710 Implement wave-style variant of underlining.
2711 * dispextern.h (face_underline_type): New enum.
2712 (face): Add field for underline type.
2713 * nsterm.m (ns_draw_underwave): New function.
2714 (ns_draw_text_decoration): Use it.
2715 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2716 New functions.
2717 (x_draw_glyph_string): Use them.
2718 * xfaces.c (Qline, Qwave): New Lisp objects.
2719 (check_lface_attrs, merge_face_ref)
1053a871
SM
2720 (Finternal_set_lisp_face_attribute, realize_x_face):
2721 Handle wave-style underline face attributes.
9b0e3eba
AA
2722 * xterm.c (x_draw_underwave): New function.
2723 (x_draw_glyph_string): Use it.
2724
0fb52f11
JB
27252012-06-16 Juanma Barranquero <lekktu@gmail.com>
2726
2727 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2728 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2729 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2730 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2731 ($(BLD)/w32select.$(O)): Update dependencies.
2732
e5560ff7
AS
27332012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2734
2735 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2736 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2737 * character.c (_fetch_multibyte_char_p): Remove.
2738 * alloc.c: Include "character.h" before "buffer.h".
2739 * bidi.c: Likewise.
2740 * buffer.c: Likewise.
2741 * bytecode.c: Likewise.
2742 * callint.c: Likewise.
2743 * callproc.c: Likewise.
2744 * casefiddle.c: Likewise.
2745 * casetab.c: Likewise.
2746 * category.c: Likewise.
2747 * cmds.c: Likewise.
2748 * coding.c: Likewise.
2749 * composite.c: Likewise.
2750 * dired.c: Likewise.
2751 * dispnew.c: Likewise.
2752 * doc.c: Likewise.
2753 * dosfns.c: Likewise.
2754 * editfns.c: Likewise.
2755 * emacs.c: Likewise.
2756 * fileio.c: Likewise.
2757 * filelock.c: Likewise.
2758 * font.c: Likewise.
2759 * fontset.c: Likewise.
2760 * fringe.c: Likewise.
2761 * indent.c: Likewise.
2762 * insdel.c: Likewise.
2763 * intervals.c: Likewise.
2764 * keyboard.c: Likewise.
2765 * keymap.c: Likewise.
2766 * lread.c: Likewise.
2767 * macros.c: Likewise.
2768 * marker.c: Likewise.
2769 * minibuf.c: Likewise.
2770 * nsfns.m: Likewise.
2771 * nsmenu.m: Likewise.
2772 * print.c: Likewise.
2773 * process.c: Likewise.
2774 * regex.c: Likewise.
2775 * region-cache.c: Likewise.
2776 * search.c: Likewise.
2777 * syntax.c: Likewise.
2778 * term.c: Likewise.
2779 * textprop.c: Likewise.
2780 * undo.c: Likewise.
2781 * unexsol.c: Likewise.
2782 * w16select.c: Likewise.
2783 * w32fns.c: Likewise.
2784 * w32menu.c: Likewise.
2785 * window.c: Likewise.
2786 * xdisp.c: Likewise.
2787 * xfns.c: Likewise.
2788 * xmenu.c: Likewise.
2789 * xml.c: Likewise.
2790 * xselect.c: Likewise.
2791
2f07e6af
EZ
27922012-06-16 Eli Zaretskii <eliz@gnu.org>
2793
1053a871
SM
2794 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2795 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2796 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2797 row.
2798 (handle_face_prop): Use chunk-relative overlay string index when
2799 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2800 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2801 the rightmost. (Bug#11720)
2f07e6af 2802
29b83cec
AS
28032012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2804
2805 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2806 (CATEGORY_MEMBER): Enforce 1/0 value.
2807 * category.c (_temp_category_set): Remove.
2808
4c5501e9
EZ
28092012-06-16 Eli Zaretskii <eliz@gnu.org>
2810
2811 * window.c (Fdelete_other_windows_internal)
2812 (Fdelete_window_internal): Don't access frame's mouse highlight
2813 info of the initial frame. (Bug#11677)
2814
2b570124
PE
28152012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2816
e93864f9
PE
2817 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2818 Assume USE_2_TAGS_FOR_INTS.
2819 (xreload): Adjust $tagmask width to match recent lisp.h change.
2820
2b570124
PE
2821 Simplify lisp.h in minor ways that should not affect code.
2822 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2823 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2824 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2825 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2826 (INTTYPEBITS): New macro, for clarity.
2827 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2828 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2829 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2830 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2831 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2832
81755f69
JB
28332012-06-13 Juanma Barranquero <lekktu@gmail.com>
2834
2835 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2836
16192a57
GM
28372012-06-13 Glenn Morris <rgm@gnu.org>
2838
2839 * s/bsd-common.h (BSD4_3):
2840 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2841
646b5f55
AS
28422012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2843
2844 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2845 instead of union.
2846 (XLI, XIL): Define.
1053a871
SM
2847 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2848 Use them.
2849 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2850 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2851 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2852 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2853 * frame.c (delete_frame): Remove outdated comment.
2854 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2855 USE_LISP_UNION_TYPE.
2856 (Fw32_unregister_hot_key): Likewise.
2857 (Fw32_toggle_lock_key): Likewise.
2858 * w32menu.c (add_menu_item): Likewise.
2859 (w32_menu_display_help): Use XIL instead of checking
2860 USE_LISP_UNION_TYPE.
2861 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2862 (init_heap): Likewise.
2863 * w32term.c (w32_read_socket): Update comment.
2864
1d3823c9
GM
28652012-06-13 Glenn Morris <rgm@gnu.org>
2866
c62ff706
GM
2867 * s/usg5-4-common.h, src/s/unixware.h:
2868 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2869
1d3823c9
GM
2870 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2871
bfe3e0a2
PE
28722012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2875 * alloc.c (make_number) [!defined make_number]:
2876 Remove, as lisp.h always defines this now.
2877 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2878 (roundup_size): Verify that it is a power of 2.
2879 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2880 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2881 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2882 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2883 USE_LSB_TAG now is always defined to be either 0 or 1.
2884 All uses changed.
2885 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2886 code works fine either way, and efficiency is not a concern here,
2887 as the union type is for debugging, not for production.
2888 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2889 Use an inline function on all platforms when using the union type,
2890 since this is simpler and 'static inline' can be used portably
2891 within Emacs now.
2892 (LISP_INITIALLY_ZERO): New macro.
2893 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2894 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2895
45fa9c0f
GM
28962012-06-12 Glenn Morris <rgm@gnu.org>
2897
b4492cba
GM
2898 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2899
2900 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2901
45fa9c0f
GM
2902 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2903 Move BROKEN_SIGIO to configure.
2904
2905 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2906 Move NO_TERMIO to configure.
2907
0e25d334
CY
29082012-06-12 Chong Yidong <cyd@gnu.org>
2909
2910 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2911 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2912 MagickExportImagePixels is undefined.
2913
43682bb6
PE
29142012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 * image.c (imagemagick_load_image): Remove unused label.
2917
a9be7d2b
GM
29182012-06-11 Glenn Morris <rgm@gnu.org>
2919
2920 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2921 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2922 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2923 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2924
3017f87f
SM
29252012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2926
2927 * alloc.c (make_byte_code): New function.
2928 (Fmake_byte_code): Use it. Don't purify here.
2929 * lread.c (read1): Use it as well to avoid extra allocation.
2930
1b9b4cf4
CY
29312012-06-11 Chong Yidong <cyd@gnu.org>
2932
2933 * image.c (imagemagick_load_image): Implement transparency.
2934
95988fcf
AS
29352012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2936
2937 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2938 account for preceding backslashes. (Bug#11663)
2939
cd4eb164
CY
29402012-06-09 Chong Yidong <cyd@gnu.org>
2941
2942 * term.c: Support italics in capable terminals (Bug#9652).
2943 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2944 (turn_on_face): Output using TS_enter_italic_mode if available.
2945 Don't handle unused blinking and alt-charset cases.
2946 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2947 and tty_alt_charset_p cases.
2948 (tty_capable_p, init_tty): Support italics.
2949
2950 * termchar.h (struct tty_display_info): Add field for italics.
2951 Remove unused blink field.
2952
2953 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2954 Handle slant.
2955
2956 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2957 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2958 tty_alt_charset_p. Add tty_italic_p.
2959
ff88beb8
MA
29602012-06-09 Michael Albinus <michael.albinus@gmx.de>
2961
2962 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2963 dbus_type_is_basic if available.
2964 (xd_extract_signed, xd_extract_unsigned): Rename from
2965 extract_signed and extract_unsigned, respectively. Adapt callers.
2966
44286096
CY
29672012-06-09 Chong Yidong <cyd@gnu.org>
2968
1682701f
CY
2969 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2970
44286096
CY
2971 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2972 case (Bug#9752).
2973
d86feb17
PE
29742012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 * xdisp.c (vmessage): Treat frame message as multibyte.
2977 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2978 would generate the diagnostic "Making \302\247 buffer-local while
2979 let-bound!".
2980
d5c20fe8
EZ
29812012-06-08 Eli Zaretskii <eliz@gnu.org>
2982
2983 * dispnew.c (showing_window_margins_p): Undo last change, which
2984 was done due to an inadvertent commit.
2985 (adjust_frame_glyphs_for_frame_redisplay): Do call
2986 showing_window_margins_p.
2987
513749ee
SM
29882012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2989
2990 * eval.c (Fmake_var_non_special): New primitive.
2991 (syms_of_eval): Defsubr it.
2992 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2993
d4a8f5c1
JB
29942012-06-08 Juanma Barranquero <lekktu@gmail.com>
2995
2996 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2997 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2998
8bbbc977
EZ
29992012-06-08 Eli Zaretskii <eliz@gnu.org>
3000
3001 * alloc.c (allocate_vectorlike): Fix last change.
3002
f3372c87
DA
30032012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3004
3005 Block-based vector allocation of small vectors.
3006 * lisp.h (struct vectorlike_header): New field `nbytes',
3007 adjust comment accordingly.
3008 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3009 to denote vector blocks. Adjust users (live_vector_p,
3010 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3011 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3012 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3013 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3014 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3015 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3016 (roundup_size): New constant.
3017 (struct vector_block): New data type.
3018 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3019 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3020 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3021 (sweep_vectors): New functions.
3022 (allocate_vectorlike): Return `zero_vector' as the only vector of
3023 0 items. Allocate new vector from block if vector size is less than
3024 or equal to VBLOCK_BYTES_MAX.
3025 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3026 (init_alloc_once): Add call to init_vectors.
3027
4f18a4ed
SM
30282012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3029
3030 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3031
86f158bc
PE
30322012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3033
3034 * doprnt.c (doprnt): Truncate multibyte char correctly.
3035 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3036 would mishandle a string argument "Xc" if X was a multibyte
3037 character of length 2: it would truncate after X's first byte
3038 rather than including all of X.
3039
c5cfcbe0
CY
30402012-06-06 Chong Yidong <cyd@gnu.org>
3041
3042 * buffer.c (word_wrap): Doc fix.
3043
c05cf390
PE
30442012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3045
3046 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3047
0c3461de
GM
30482012-06-03 Glenn Morris <rgm@gnu.org>
3049
3050 * xdisp.c (tool-bar-style): Doc fix.
3051
c71232db
UM
30522012-06-03 Ulrich Müller <ulm@gentoo.org>
3053
3054 * Makefile.in (PAXCTL): Define.
3055 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3056 binary via PaX flags if the paxctl utility is available.
3057 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3058 Restore PaX flags to their default. (Bug#11398)
3059
383f7350
CY
30602012-06-03 Chong Yidong <cyd@gnu.org>
3061
3062 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3063 buffer (Bug#11226).
3064
5f2c76c6
CY
30652012-06-03 Chong Yidong <cyd@gnu.org>
3066
3067 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3068 (note_mode_line_or_margin_highlight): If there is no help echo,
3069 use mode-line-default-help-echo. Handle the case where the mouse
3070 position is past the end of the mode line string.
3071
3072 * buffer.c (buffer_local_value_1): New function, split from
3073 Fbuffer_local_value; can return Qunbound.
3074 (Fbuffer_local_value): Use it.
3075 (Vmode_line_format): Docstring tweaks.
3076
773d47f6
PE
30772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 * sysdep.c (system_process_attributes): Improve comment.
3080
f2d6a3df
SM
30812012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3082
3083 * keyboard.c: Export real-this-command to Elisp.
3084 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3085 and DEFVAR it. Update all users.
3086
63810350
PE
30872012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3088
7bd5c1f4
PE
3089 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3090
63810350
PE
3091 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3092 Convert pctcpu and pctmem to Lisp float properly.
3093 Let the compiler fold better, as 100.0/0x8000 is exact.
3094
a2821611
AS
30952012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3096
3097 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3098 cons_block.
3099
5fceba1d
PE
31002012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3101
3102 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3103
c98ff5dd
DA
31042012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3105
3106 For a 'struct window', replace some Lisp_Object fields to
3107 bitfields where appropriate, remove unused fields.
3108 * window.h (struct window): Remove unused 'last_mark_x' and
3109 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3110 change it's type from Lisp_Object to bitfield.
3111 Change type of 'force_start', 'optional_new_start',
3112 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3113 fields from Lisp_Object to bitfield. Adjust users accordingly.
3114
ca34e0be
PE
31152012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 Pacify gcc -Wdouble-precision when using Xaw.
3118 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3119 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3120 Use 'float' consistently, rather than 'float' in most places
3121 and 'double' in a couple of places.
3122
efc00ab1 31232012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3124
3125 * xdisp.c (handle_stop): Detect whether we have overlay strings
3126 loaded by testing it->current.overlay_string_index to be
3127 non-negative, instead of checking whether n_overlay_strings is
3128 positive. (Bug#11587)
3129
efc00ab1 31302012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3131
3132 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3133
3134 * doc.c (Fsubstitute_command_keys): Doc fix.
3135
efc00ab1 31362012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3137
3138 * search.c (search_buffer): Remove calls to
3139 r_alloc_inhibit_buffer_relocation, as it is now called by
3140 maybe_unify_char, which was the cause of relocation of buffer text
3141 in bug#11519.
3142
efc00ab1 31432012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3144
3145 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3146 for the duration of call to load_charset, to avoid problems with
3147 callers of maybe_unify_char that access buffer text through C
3148 pointers.
3149
3150 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3151 decrement the inhibition flag, instead of just setting or
3152 resetting it.
3153
ba93a187
PE
31542012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 Remove obsolete '#define static' cruft.
3157 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3158 This #undef was "temporary" in 2000; it is no longer needed
3159 now that '#define static' has gone away.
3160 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3161 (gray_bitmap_bits): Remove; no longer needed.
3162 All uses replaced with definiens.
3163 * xterm.c: Include "bitmaps/gray.xbm".
3164
9e4bf381
PE
31652012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 Clean up __executable_start, monstartup when --enable-profiling.
3168 The following changes affect the code only when profiling.
3169 * dispnew.c (__executable_start): Rename from safe_bcopy.
3170 Define only on platforms that need it.
3171 * emacs.c: Include <sys/gmon.h> when profiling.
3172 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3173 (__executable_start): Remove decl, since lisp.h does it now.
3174 (safe_bcopy): Remove decl; no longer has that name.
3175 (main): Coalesce #if into single bit of code, for simplicity.
3176 Cast pointers to uintptr_t, since standard libraries want integers
3177 and not pointers.
3178 * lisp.h (__executable_start): New decl.
3179
32d72c2f
GM
31802012-05-31 Glenn Morris <rgm@gnu.org>
3181
3182 * image.c (Fimagemagick_types): Doc fix.
3183
baac5bc7
JM
31842012-05-30 Jim Meyering <meyering@redhat.com>
3185
3186 * callproc.c (Fcall_process_region): Include directory component
3187 in mkstemp error message (Bug#11586).
3188
72cb32cf
PE
31892012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 * alloc.c, lisp.h (make_pure_vector): Now static.
3192
61b108cc
SM
31932012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3194
3195 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3196 Move to byte-run.el.
3197 (Fautoload): Do the hash-doc more carefully.
3198 * data.c (Fdefalias): Purify definition, except for keymaps.
3199 (Qdefun): Move from eval.c.
3200 * lisp.h (Qdefun): Remove.
3201 * lread.c (read1): Tiny simplification.
3202
471fe23d
TN
32032012-05-29 Troels Nielsen <bn.troels@gmail.com>
3204
934f3f58 3205 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3206 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3207 Bug#9642, but explicitly check that the buffer the overlay would
3208 be moved to is live and rearrange lines to make sure that errors
3209 will not put the overlay in an inconsistent state.
3210 (Fdelete_overlay): Cosmetics.
3211
85d0efd1
EZ
32122012-05-28 Eli Zaretskii <eliz@gnu.org>
3213
3214 * w32term.c (my_bring_window_to_top): New function.
3215 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3216 could be different from the original one.
3217 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3218 (Bug#11513)
3219
3220 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3221 by calling BringWindowToTop.
3222
3223 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3224 (WM_EMACS_END): Increase by one.
3225
da92a98c
PE
32262012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3229 This avoids undefined behavior that might cause the eassert
3230 to not catch an out-of-range value.
3231
74d1f848
JB
32322012-05-28 Juanma Barranquero <lekktu@gmail.com>
3233
3234 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3235 Update dependencies.
3236
9e1a06fc
EZ
32372012-05-27 Eli Zaretskii <eliz@gnu.org>
3238
3239 * bidi.c (bidi_mirror_char): Fix last change.
3240
f3dd7312
AS
32412012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3242
3243 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3244 when referring to sectname field in printf format.
3245
81899c91
PE
32462012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3247
57b81a9f
PE
3248 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3249 Only r_alloc_inhibit_buffer_relocation needed to be added;
3250 the others were already declared.
3251
81899c91
PE
3252 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3253 before checking whether it's out of range. Put the check inside
3254 eassert. See
3255 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3256
33017faf 32572012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3258
3259 * callproc.c (Fcall_process): Restore a line that was accidentally
3260 commented out in the 2011-02-13 change (bug#11547).
3261
33017faf 32622012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3263
3264 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3265 defined on ralloc.c.
3266
3267 * buffer.c [REL_ALLOC]: Remove prototypes of
3268 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3269 they are now on lisp.h.
3270
3271 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3272
3273 * search.c (search_buffer): Use it to inhibit relocation of buffer
3274 text while re_search_2 is doing its job, because re_search_2 is
3275 passed C pointers to buffer text. (Bug#11519)
3276
23415acf
EZ
3277 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3278 Update value to 24.
3279
44e27368
EZ
3280 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3281 state after an additional call to move_it_in_display_line_to, keep
3282 the values of it->max_ascent and it->max_descent found for the
3283 entire line.
3284 (pos_visible_p): Revert the comparison against bottom_y to what it
3285 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3286 (Bug#11464)
3287
c1892f11
PE
32882012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3289
3290 Fix coding-related core dumps with gcc -ftrapv.
3291 The code was computing A - B, where A and B are pointers, and B is
3292 random garbage. This can lead to core dumps on platforms that
3293 have special pointer registers, and it also leads to core dumps on
3294 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3295 A - B only when B is initialized properly.
3296 * coding.c (coding_set_source, coding_set_destination): Return void.
3297 (coding_change_source, coding_change_destinations): New functions,
3298 with the old behaviors of coding_set_source and coding_set_destination.
3299 All callers that need an offset changed to use these new functions.
3300
eb7afdad
GM
33012012-05-26 Glenn Morris <rgm@gnu.org>
3302
3303 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3304
f12fdf02
EZ
33052012-05-26 Eli Zaretskii <eliz@gnu.org>
3306
53a63be6 3307 Extend mouse support on W32 text-mode console.
61b108cc
SM
3308 * xdisp.c (draw_row_with_mouse_face):
3309 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3310
eb3f6f01 3311 * w32console.c: Include window.h.
61b108cc
SM
3312 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3313 New functions.
eb3f6f01
EZ
3314 (initialize_w32_display): Initialize mouse-highlight data.
3315
53a63be6
EZ
3316 * w32inevt.c: Include termchar.h and window.h.
3317 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3318 moves, call note_mouse_highlight. If help_echo changed, call
3319 gen_help_event to produce help-echo message in the echo area.
3320 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3321 highlight info.
3322
4cfd81f6
PE
33232012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 * lread.c (read1): Simplify slightly to avoid an overflow warning
3326 with GCC 4.7.0 on x86-64.
3327
4446092a
EZ
33282012-05-26 Eli Zaretskii <eliz@gnu.org>
3329
3330 * bidi.c (bidi_mirror_char): Revert last change: an int is
3331 definitely wide enough here.
3332
42b2a986 33332012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3334
42b2a986 3335 Fix integer width and related bugs (Bug#9874).
eb106a49 3336 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3337 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3338 (string_bytes, check_sblock, allocate_string_data):
3339 (compact_small_strings, Fmake_bool_vector, make_string)
3340 (make_unibyte_string, make_multibyte_string)
3341 (make_string_from_bytes, make_specified_string)
3342 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3343 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3344 (mark_vectorlike):
3345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3346 (allocate_pseudovector):
3347 Use int, not EMACS_INT, where int is wide enough.
3348 (inhibit_garbage_collection, Fgarbage_collect):
3349 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3350 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3351 int might not be wide enough.
3352 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3353 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3354 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3355 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3356 (bidi_level_of_next_char, bidi_move_to_visually_next):
3357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3358 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3359 (Fkill_buffer, Fset_buffer_major_mode)
3360 (advance_to_char_boundary, Fbuffer_swap_text)
3361 (Fset_buffer_multibyte, overlays_at, overlays_in)
3362 (overlay_touches_p, struct sortvec, record_overlay_string)
3363 (overlay_strings, recenter_overlay_lists)
3364 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3365 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3366 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3367 (Foverlay_recenter, last_overlay_modification_hooks_used)
3368 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3370 (validate_region): Omit unnecessary test for b <= e,
3371 since that's guaranteed by the previous test.
d311d28c
PE
3372 (adjust_overlays_for_delete): Avoid pos + length overflow.
3373 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3374 (report_overlay_modification):
3375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3376 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3377 Omit pointer cast, which isn't needed anyway, and doesn't work
3378 after the EMACS_INT -> ptrdiff_t change.
02481186 3379 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3380 * buffer.h: Adjust decls to match defn changes elsewhere.
3381 (struct buffer_text, struct buffer):
3382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3383 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3384 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3385 not int, to avoid needless 32-bit limit on 64-bit hosts.
3386 (exec_byte_code): Use tighter memory-full test, one that checks
3387 for alloca overflow. Don't compute the address of the object just
3388 before an array, as that's not portable. Use EMACS_INT, not
3389 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3390 * callint.c (Fcall_interactively):
3391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3392 * callproc.c (call_process_kill, Fcall_process):
3393 Don't assume pid_t fits into an Emacs fixnum.
3394 (call_process_cleanup, Fcall_process, child_setup):
3395 Don't assume pid_t fits into int.
3396 (call_process_cleanup, Fcall_process, delete_temp_file)
3397 (Fcall_process_region):
3398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3399 (Fcall_process): Simplify handling of volatile integers.
3400 Use int, not EMACS_INT, where int will do.
3401 * casefiddle.c (casify_object, casify_region, operate_on_word)
3402 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3404 (casify_object): Avoid integer overflow when overallocating buffer.
3405 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3406 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3407 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3408 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3409 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3410 integers are now checked earlier. All uses replaced with XINT.
3411 (ccl_driver):
3412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3413 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3414 (ccl_driver, Fregister_code_conversion_map):
3415 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3416 (resolve_symbol_ccl_program): Check that vector header is in range.
3417 Always copy the vector, so that we can check its contents reliably
3418 now rather than having to recheck each instruction as it's being
3419 executed. Check that vector words fit in 'int'.
3420 (ccl_get_compiled_code, Fregister_ccl_program)
3421 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3422 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3423 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3424 contents are in range.
3425 (Fccl_execute_on_string): Check that status is in range.
3426 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3427 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3428 Accept and return EMACS_INT, not int, because callers can pass values
3429 out of 'int' range.
3430 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3431 (multibyte_chars_in_text, parse_str_as_multibyte)
3432 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3433 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3434 (string_escape_byte8, Fget_byte):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3436 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3437 avoid mishandling large integers.
3438 * character.h: Adjust decls to match defn changes elsewhere.
3439 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3440 (Ffind_charset_region):
3441 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3442 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3443 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3444 Don't assume fixnum fits in int.
d311d28c
PE
3445 (load_charset_map_from_vector, Fmap_charset_chars):
3446 Remove now-unnecessary CHECK_NATNUMs.
3447 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3448 Don't rely on undefined behavior with signed left shift overflow.
3449 Don't assume unsigned int fits into fixnum, or that fixnum fits
3450 into unsigned int. Don't require max_code to be a valid fixnum;
3451 that's not true for gb10830 4-byte on a 32-bit host. Allow
3452 invalid_code to be a cons, for the same reason. Require code_offset
3453 to be a character. Avoid int overflow if max_char is close
3454 to INT_MAX.
3455 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3456 this is intended anyway and avoids some undefined behavior.
3457 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3458 INDEX_TO_CODE_POINT, as that's what it expects.
3459 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3460 * charset.h (DECODE_CHAR): Return int, not unsigned;
3461 this is what was intended anyway, and it avoids undefined behavior.
3462 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3463 integer-overflow issues.
3464 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3465 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3466 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3467 * chartab.c (Fmake_char_table, Fset_char_table_range)
3468 (uniprop_get_decoder, uniprop_get_encoder):
3469 Don't assume fixnum fits in int.
3470 * cmds.c (move_point): New function, that does the gist of
3471 Fforward_char and Fbackward_char, but does so while checking
3472 for integer overflow more accurately.
c96e5d6a 3473 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3474 (Fforward_line, Fend_of_line, internal_self_insert)
3475 (internal_self_insert):
3476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3477 Fix a FIXME, by checking for integer overflow when calculating
3478 target_clm and actual_clm.
3479 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3480 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3481 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3482 (coding_alloc_by_making_gap, alloc_destination)
3483 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3484 (encode_coding_utf_16, detect_coding_emacs_mule)
3485 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3486 (detect_coding_iso_2022, decode_coding_iso_2022)
3487 (encode_invocation_designation, encode_designation_at_bol)
3488 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3489 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3490 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3491 (encode_coding_ccl, encode_coding_raw_text)
3492 (detect_coding_charset, decode_coding_charset)
3493 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3494 (produce_composition, produce_charset, produce_annotation)
3495 (decode_coding, handle_composition_annotation)
3496 (handle_charset_annotation, consume_chars, decode_coding_gap)
3497 (decode_coding_object, encode_coding_object, detect_coding_system)
3498 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3499 (code_convert_region, code_convert_string)
8f50130c
PE
3500 (Fdefine_coding_system_internal)
3501 (coding_set_source, coding_set_destination):
d311d28c
PE
3502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3503 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3504 (Fdefine_coding_system_internal):
3505 Don't assume fixnums fit in int.
3506 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3507 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3508 (Funencodable_char_position, Fcheck_coding_systems_region)
3509 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3511 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3512 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3513 Don't access memory outside of the args array.
d311d28c 3514 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3515 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3516 result of ENCODE_CHAR.
d311d28c
PE
3517 * coding.h: Adjust decls to match defn changes elsewhere.
3518 (struct coding_system):
3519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3520 * composite.c (get_composition_id, find_composition)
3521 (run_composition_function, update_compositions)
3522 (compose_text, composition_gstring_put_cache)
3523 (composition_gstring_p, composition_gstring_width)
3524 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3525 (composition_compute_stop_pos, composition_reseat_it)
3526 (composition_update_it, struct position_record)
3527 (find_automatic_composition, composition_adjust_point)
3528 (Fcomposition_get_gstring, Ffind_composition_internal):
3529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3530 (update_compositions):
3531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3532 * composite.h: Adjust decls to match defn changes elsewhere.
3533 (struct composition):
3534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3535 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3536 Do not attempt to compute the address of the object just before a
3537 buffer; this is not portable.
3538 (Faref, Faset):
3539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3540 (Faset): Use int, not EMACS_INT, where int is wide enough.
3541 (Fstring_to_number): Don't assume fixnums fit in int.
3542 (Frem): Don't assume arg is nonnegative.
3543 * dbusbind.c (xd_append_arg): Check for integers out of range.
3544 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3545 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3546 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3547 (xd_get_connection_references): Return ptrdiff_t, not int.
3548 All uses changed.
3549 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3550 (xd_read_message_1):
3551 Use int, not unsigned, where the dbus API uses int.
3552 (Fdbus_message_internal): Don't overflow mtype.
3553 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3554 * dired.c (directory_files_internal, file_name_completion, scmp)
3555 (file_name_completion_stat):
3556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3557 (file_name_completion): Don't overflow matchcount.
3558 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3559 * dispextern.h: Adjust decls to match defn changes elsewhere.
3560 (struct text_pos, struct glyph, struct bidi_saved_info)
3561 (struct bidi_string_data, struct bidi_it, struct composition_it)
3562 (struct it):
3563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3564 (struct display_pos, struct composition_it, struct it):
3565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3566 * dispnew.c (increment_matrix_positions)
3567 (increment_row_positions, mode_line_string)
3568 (marginal_area_string):
3569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3570 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3572 (duration_to_sec_usec): New function, to check for overflow better.
3573 (Fsleep_for, sit_for): Use it.
3574 * doc.c (get_doc_string, store_function_docstring):
3575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3576 (get_doc_string, Fsnarf_documentation):
3577 Use int, not EMACS_INT, where int is wide enough.
3578 (get_doc_string):
3579 Use SAFE_ALLOCA, not alloca.
3580 Check for overflow when converting EMACS_INT to off_t.
3581 * doprnt.c (doprnt):
3582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3583 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3584 Don't assume uid_t fits into fixnum.
3585 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3586 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3587 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3588 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3589 (general_insert_function)
3590 (Finsert_char, make_buffer_string, make_buffer_string_both)
3591 (update_buffer_properties, Fbuffer_substring)
3592 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3593 (Fsubst_char_in_region, check_translation)
3594 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3595 (transpose_markers, Ftranspose_regions):
3596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3597 (clip_to_bounds): Move to lisp.h as an inline function).
3598 (Fconstrain_to_field): Don't assume integers are nonnegative.
3599 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3600 (Fsubst_char_in_region, Fsave_restriction):
3601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3602 (Femacs_pid): Don't assume pid_t fits into fixnum.
3603 (lo_time): Use int, not EMACS_INT, when int suffices.
3604 (lisp_time_argument): Check for usec out of range.
3605 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3606 (Fuser_login_name, Fuser_full_name): Signal an error
3607 if a uid argument is out of range, rather than relying on
3608 undefined behavior.
c8d5c857
PE
3609 (Fformat_time_string): Remove now-unnecessary check.
3610 lisp_time_argument checks for out-of-range usec now.
243e0530 3611 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3612 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3613 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3614 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3615 (init_cmdargs, Fdump_emacs):
3616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3617 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3618 the bottom (typically) 32 bits of the fixnum.
3619 * eval.c (specpdl_size, call_debugger):
3620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3621 (when_entered_debugger, Fbacktrace_debug):
3622 Don't assume fixnum can fit in int.
3623 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3624 the object just before a buffer; this is not portable.
3625 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3626 (grow_specpdl, unbind_to):
3627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3628 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3629 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3630 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3631 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3632 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3634 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3635 (a_write, e_write):
3636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3637 (Fcopy_file, non_regular_nbytes, read_non_regular)
3638 (Finsert_file_contents):
3639 Use int, not EMACS_INT, where int is wide enough.
3640 (READ_BUF_SIZE): Verify that it fits in int.
3641 (Finsert_file_contents): Check that counts are in proper range,
3642 rather than assuming fixnums fit into ptrdiff_t etc.
3643 Don't assume fixnums fit into int.
125b3835 3644 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3645 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3646 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3647 (string_char_to_byte, string_byte_to_char)
3648 (string_make_multibyte, string_to_multibyte)
3649 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3650 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3651 (substring_both, Fdelete, internal_equal, Ffillarray)
3652 (Fclear_string, mapcar1)
3653 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3654 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3655 (larger_vector, make_hash_table, maybe_resize_hash_table)
3656 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3657 (Fmaphash, secure_hash):
3658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3659 (concat): Check for string index and length overflow.
3660 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3661 (Frequire):
3662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3663 (larger_vector): New API (vec, incr_min, size_max) replaces old
3664 one (vec, new_size, init). This catches size overflow.
3665 INIT was removed because it was always Qnil.
3666 All callers changed.
3667 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3668 the upper bound on a hash table index size.
3669 (make_hash_table, maybe_resize_hash_table): Use it.
3670 (secure_hash): Computer start_byte and end_byte only after
3671 they're known to be in ptrdiff_t range.
3672 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3673 (Ffont_get_glyphs, Ffont_at):
3674 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3675 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3676 (Flist_fonts, Fopen_font):
3677 Don't assume fixnum can fit in int.
3678 (check_gstring): Don't assume index can fit in int.
3679 (font_match_p): Check that fixnum is a character, not a nonnegative
3680 fixnum, since the later code needs to stuff it into an int.
3681 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3682 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3683 conversion overflow issues.
3684 (Fopen_font): Check for integer out of range.
3685 (Ffont_get_glyphs): Don't assume index can fit in int.
3686 * font.h: Adjust decls to match defn changes elsewhere.
3687 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3688 integer overflow.
3689 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3690 printmax_t, where ptrdiff_t is wide enough.
3691 (Finternal_char_font):
3692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3693 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3694 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3695 (Fset_frame_position, x_set_frame_parameters)
3696 (x_set_line_spacing, x_set_border_width)
3697 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3698 Check that fixnums are in proper range for system types.
3699 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3701 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3702 Use SAFE_ALLOCA_LISP, not alloca.
3703 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3704 intptr_t is wide enough.
3705 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3706 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3707 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3708 Check for fixnum out of range.
3709 * ftfont.c (ftfont_list): Don't assume index fits in int.
3710 Check that fixnums are in proper range for system types.
3711 (ftfont_shape_by_flt):
3712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3713 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3715 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3716 Check that fixnums are in proper range for system types.
3717 * gnutls.h: Adjust decls to match defn changes elsewhere.
3718 * gtkutil.c (xg_dialog_run):
3719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3720 (update_frame_tool_bar):
3721 Check that fixnums are in proper range for system types.
3722 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3723 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3724 * indent.c (last_known_column, last_known_column_point):
3725 (current_column_bol_cache):
3726 (skip_invisible, current_column, check_display_width):
3727 (check_display_width, scan_for_column, current_column_1)
3728 (Findent_to, Fcurrent_indentation, position_indentation)
3729 (indented_beyond_p, Fmove_to_column, compute_motion):
3730 (Fcompute_motion, Fvertical_motion):
3731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3732 (last_known_column_modified): Use EMACS_INT, not int.
3733 (check_display_width):
3734 (Fcompute_motion):
3735 Check that fixnums and floats are in proper range for system types.
3736 (compute_motion): Don't assume index or fixnum fits in int.
3737 (compute_motion, Fcompute_motion):
3738 Use int, not EMACS_INT, when it is wide enough.
3739 (vmotion): Omit local var start_hpos that is always 0; that way
3740 we don't need to worry about overflow in expressions involving it.
3741 * indent.h: Adjust decls to match defn changes elsewhere.
3742 (struct position):
3743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3744 Use int, not EMACS_INT, where int is wide enough.
3745 Remove unused members ovstring_chars_done and tab_offset;
3746 all uses removed.
3747 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3748 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3749 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3750 (make_gap, copy_text, insert, insert_and_inherit)
3751 (insert_before_markers, insert_before_markers_and_inherit)
3752 (insert_1, count_combining_before, count_combining_after)
3753 (insert_1_both, insert_from_string)
3754 (insert_from_string_before_markers, insert_from_string_1)
3755 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3756 (adjust_after_replace, adjust_after_insert, replace_range)
3757 (replace_range_2, del_range, del_range_1, del_range_byte)
3758 (del_range_both, del_range_2, modify_region)
3759 (prepare_to_modify_buffer, signal_before_change)
3760 (signal_after_change, Fcombine_after_change_execute):
3761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3762 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3763 (balance_an_interval, split_interval_right, split_interval_left)
3764 (find_interval, next_interval, update_interval)
3765 (adjust_intervals_for_insertion, delete_node, delete_interval)
3766 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3767 (static_offset_intervals, offset_intervals)
3768 (merge_interval_right, merge_interval_left, make_new_interval)
3769 (graft_intervals_into_buffer, temp_set_point_both)
3770 (temp_set_point, set_point, adjust_for_invis_intang)
3771 (set_point_both, move_if_not_intangible, get_property_and_range)
3772 (get_local_map, copy_intervals, copy_intervals_to_string)
3773 (compare_string_intervals, set_intervals_multibyte_1):
3774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3775 * intervals.h: Adjust decls to match defn changes elsewhere.
3776 (struct interval):
3777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3778 * keyboard.c (this_command_key_count, this_single_command_key_start)
3779 (before_command_key_count, before_command_echo_length, echo_now)
3780 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3781 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3782 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3783 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3785 (last_non_minibuf_size, last_point_position, echo_truncate)
3786 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3787 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3788 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3789 (stuff_buffered_input):
3790 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3791 (last_auto_save, command_loop_1, read_char):
3792 Use EMACS_INT, not int, to avoid integer overflow.
3793 (record_char): Avoid overflow in total_keys computation.
3794 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3795 * keyboard.h: Adjust decls to match defn changes elsewhere.
3796 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3797 (Fkey_description, Fdescribe_vector, Flookup_key):
3798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3799 (click_position): New function, to check that positions are in range.
3800 (Fcurrent_active_maps):
3801 (describe_command):
3802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3803 (Faccessible_keymaps, Fkey_description):
3804 (preferred_sequence_p):
3805 Don't assume fixnum can fit into int.
3806 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3807 Check for integer overflow in size calculations.
3808 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3809 avoid mishandling large integers.
3810 * lisp.h: Adjust decls to match defn changes elsewhere.
3811 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3812 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3813 (struct Lisp_Marker):
3814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3815 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3816 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3817 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3818 All callers changed.
3819 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3820 Assume the arg has valid form, since it always does.
3821 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3822 unsigned integer system type.
3823 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3824 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3826 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3827 (duration_to_sec_usec): New decl.
3828 * lread.c (read_from_string_index, read_from_string_index_byte)
3829 (read_from_string_limit, readchar, unreadchar, openp)
3830 (read_internal_start, read1, oblookup):
3831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3832 (Fload, readevalloop, Feval_buffer, Feval_region):
3833 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3834 (openp): Check for out-of-range argument to 'access'.
3835 (read1): Use int, not EMACS_INT, where int is wide enough.
3836 Don't assume fixnum fits into int.
6efdadfd 3837 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3838 (read_filtered_event): Use duration_to_sec_usec
3839 to do proper overflow checking on durations.
d311d28c
PE
3840 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3841 in size calculation.
3842 (Fexecute_kbd_macro):
3843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3844 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3845 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3846 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3847 (set_marker_both, set_marker_restricted_both, marker_position)
3848 (marker_byte_position, Fbuffer_has_markers_at):
3849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3850 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3851 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3852 It now merely ensures that the menu is large enough, without
3853 necessarily growing it, as this avoids some integer overflow issues.
3854 All callers changed.
3855 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3857 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3858 Use SAFE_ALLOCA_LISP, not alloca.
3859 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3860 to EMACS_INT. Check that fixnums are in proper range for system types.
3861 * minibuf.c (minibuf_prompt_width, string_to_object)
3862 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3863 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3865 (get_minibuffer, read_minibuf_unwind):
3866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3867 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3868 this simplifies overflow checking. All callers changed.
3869 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3870 (Ftest_completion):
3871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3872 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3873 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3874 Check that fixnums are in proper range for system types.
3875 (Fx_create_frame, Fx_show_tip):
3876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3877 * nsfont.m (ns_findfonts, nsfont_list_family):
3878 Don't assume fixnum fits in long.
3879 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3881 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3882 wide enough.
17fdb222 3883 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3885 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3886 (PRINTDECLARE, PRINTPREPARE):
3887 (strout, print_string):
3888 (print, print_preprocess, print_check_string_charset_prop)
3889 (print_object):
3890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3891 (PRINTDECLARE):
3892 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3894 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3895 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3896 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3897 (print_error_message): Use SAFE_ALLOCA, not alloca.
3898 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3899 (print_depth, new_backquote_output, print_number_index):
3900 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3901 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3902 (Fset_process_window_size, Fformat_network_address)
3903 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3904 (sigchld_handler):
d311d28c 3905 Check that fixnums are in proper range for system types.
d44287d4 3906 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3907 Check for process-ids out of pid_t range rather than relying on
3908 undefined behavior.
e4d81efc 3909 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3910 (Fformat_network_address, read_process_output, send_process)
3911 (Fprocess_send_region, status_notify):
3912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3913 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3914 (wait_reading_process_output, read_process_output, exec_sentinel):
3915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3916 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3917 (Faccept_process_output): Use duration_to_sec_usec to do proper
3918 overflow checking on durations.
dde14581
PE
3919 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3920 Don't assume pid_t fits in int.
02481186
PE
3921 * process.h (struct Lisp_Process): Members tick and update_tick
3922 are now of type EMACS_INT, not int.
b62b53e8
PE
3923 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3924 configured --with-wide-int.
d311d28c
PE
3925 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3926 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3927 * search.c (looking_at_1, string_match_1):
3928 (fast_string_match, fast_c_string_match_ignore_case)
3929 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3930 (scan_newline, find_before_next_newline, search_command)
3931 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3932 (set_search_regs, wordify):
3933 (Freplace_match):
3934 (Fmatch_data):
3935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3936 (string_match_1, search_buffer, set_search_regs):
3937 (Fmatch_data):
3938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3939 (wordify): Check for overflow in size calculation.
3940 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3941 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3942 Check that fixnums are in proper range for system types.
3943 * sound.c (struct sound_device)
3944 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3946 (Fplay_sound_internal):
3947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3948 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3949 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3950 (Fparse_partial_sexp):
3951 Don't assume fixnums can fit in int.
3952 (struct lisp_parse_state, find_start_pos, find_start_value)
3953 (find_start_value_byte, find_start_begv)
3954 (update_syntax_table, char_quoted, dec_bytepos)
3955 (find_defun_start, prev_char_comend_first, back_comment):
3956 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3957 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3959 (Finternal_describe_syntax_value): Check that match_lisp is a
3960 character, not an integer, since the code stuffs it into int.
3961 (scan_words, scan_sexps_forward):
3962 Check that fixnums are in proper range for system types.
3963 (Fforward_word):
3964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3965 (scan_sexps_forward):
3966 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3967 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3968 * syntax.h: Adjust decls to match defn changes elsewhere.
3969 (struct gl_state_s):
3970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3971 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3972 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3973 * sysdep.c (wait_for_termination_1, wait_for_termination)
3974 (interruptible_wait_for_termination, mkdir):
3975 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3976 (emacs_read, emacs_write):
3977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3978 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3979 and double all fit in int.
d311d28c
PE
3980 * term.c (set_tty_color_mode):
3981 Check that fixnums are in proper range for system types.
3982 * termhooks.h (struct input_event):
3983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3984 * textprop.c (validate_interval_range, interval_of)
3985 (Fadd_text_properties, set_text_properties_1)
3986 (Fremove_text_properties, Fremove_list_of_text_properties)
3987 (Ftext_property_any, Ftext_property_not_all)
3988 (copy_text_properties, text_property_list, extend_property_ranges)
3989 (verify_interval_modification):
3990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3991 (Fnext_single_char_property_change)
3992 (Fprevious_single_char_property_change):
3993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3994 (copy_text_properties):
3995 Check for integer overflow in index calculation.
d311d28c
PE
3996 * undo.c (last_boundary_position, record_point, record_insert)
3997 (record_delete, record_marker_adjustment, record_change)
3998 (record_property_change):
3999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4000 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4002 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4003 (Fx_hide_tip, Fx_file_dialog):
4004 * w32menu.c (set_frame_menubar):
4005 Use ptrdiff_t, not int, for consistency with rest of code.
4006 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4007 (select_window, Fdelete_other_windows_internal)
4008 (window_scroll_pixel_based, window_scroll_line_based)
4009 (Frecenter, Fset_window_configuration):
4010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4011 (Fset_window_hscroll, run_window_configuration_change_hook)
4012 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4013 (Fscroll_other_window, Frecenter):
d311d28c
PE
4014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4015 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4016 Don't assume fixnum fits in int.
4017 (Fset_window_scroll_bars):
4018 Check that fixnums are in proper range for system types.
4019 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4020 (string_pos, c_string_pos, number_of_chars, init_iterator)
4021 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4022 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4023 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4024 (face_before_or_after_it_pos, handle_invisible_prop)
4025 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4026 (display_prop_intangible_p, string_buffer_position_lim)
4027 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4028 (get_overlay_strings_1, get_overlay_strings)
4029 (iterate_out_of_display_property, forward_to_next_line_start)
4030 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4031 (get_next_display_element, set_iterator_to_next)
4032 (get_visually_first_element, compute_stop_pos_backwards)
4033 (handle_stop_backwards, next_element_from_buffer)
4034 (move_it_in_display_line_to, move_it_in_display_line)
4035 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4036 (add_to_log, message_dolog, message_log_check_duplicate)
4037 (message2, message2_nolog, message3, message3_nolog
4038 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4039 (current_message_1, truncate_echo_area, truncate_message_1)
4040 (set_message, set_message_1, store_mode_line_noprop)
4041 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4042 (text_outside_line_unchanged_p, check_point_in_composition)
4043 (reconsider_clip_changes)
4044 (redisplay_internal, set_cursor_from_row, try_scrolling)
4045 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4046 (redisplay_window, find_last_unchanged_at_beg_row)
4047 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4048 (trailing_whitespace_p, find_row_edges, display_line)
4049 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4050 (display_mode_element, store_mode_line_string)
4051 (pint2str, pint2hrstr, decode_mode_spec)
4052 (display_count_lines, display_string, draw_glyphs)
4053 (x_produce_glyphs, x_insert_glyphs)
4054 (rows_from_pos_range, mouse_face_from_buffer_pos)
4055 (fast_find_string_pos, mouse_face_from_string_pos)
4056 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4058 (safe_call, init_from_display_pos, handle_fontified_prop)
4059 (handle_single_display_spec, load_overlay_strings)
4060 (with_echo_area_buffer, setup_echo_area_for_printing)
4061 (display_echo_area, echo_area_display)
4062 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4063 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4064 (redisplay_window, dump_glyph_row, display_mode_line)
4065 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4066 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4067 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4068 (handle_single_display_spec, build_desired_tool_bar_string)
4069 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4070 (get_specified_cursor_type):
4071 Check that fixnums are in proper range for system types.
4072 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4073 (Flookup_image_map):
4074 Don't assume fixnums fit in int.
4075 (compare_overlay_entries):
4076 Avoid mishandling comparisons due to subtraction overflow.
4077 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4078 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4079 (handle_tool_bar_click):
4080 Use int, not unsigned, since we prefer signed and the signedness
4081 doesn't matter here.
4082 (get_next_display_element, next_element_from_display_vector):
4083 Use int, not EMACS_INT, when int is wide enough.
4084 (start_hourglass): Use duration_to_sec_usec to do proper
4085 overflow checking on durations.
4086 * xfaces.c (Fbitmap_spec_p):
4087 Check that fixnums are in proper range for system types.
4088 (compare_fonts_by_sort_order):
4089 Avoid mishandling comparisons due to subtraction overflow.
4090 (Fx_family_fonts, realize_basic_faces):
4091 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4092 (Fx_family_fonts):
4093 Don't assume fixnum fits in int.
4094 Use SAFE_ALLOCA_LISP, not alloca.
4095 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4096 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4097 (face_at_buffer_position, face_for_overlay_string)
4098 (face_at_string_position):
4099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4100 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4101 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4102 (Fx_show_tip):
4103 Check that fixnums are in proper range for system types.
4104 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4105 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4107 (Fx_change_window_property): Don't assume fixnums fit in int.
4108 * xfont.c (xfont_chars_supported):
4109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4110 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4111 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4112 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4113 * xml.c (parse_region):
4114 * xrdb.c (magic_file_p):
4115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4116 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4117 (x_get_local_selection, x_reply_selection_request)
4118 (x_handle_selection_request, wait_for_property_change):
4119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4120 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4121 short is wide enough.
4122 (x_send_client_event): Don't assume fixnum fits in int.
4123 * xterm.c (x_x_to_emacs_modifiers):
4124 Don't assume EMACS_INT overflows nicely into int.
4125 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4126 may come from Lisp.
4127 (handle_one_xevent): NATNUMP can eval its arg twice.
4128 (x_connection_closed):
4129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4130 * xterm.h: Adjust decls to match defn changes elsewhere.
4131 (struct scroll_bar): Use struct vectorlike_header
4132 rather than rolling our own approximation.
4133 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4134
c6574eb5
GM
41352012-05-25 Glenn Morris <rgm@gnu.org>
4136
4137 * lisp.mk (lisp): Update for more files being compiled now.
4138
e8d32c7e
SM
41392012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4140
48def666
SM
4141 * lread.c: Remove `read_pure' which makes no difference.
4142 (read_pure): Remove var.
4143 (unreadpure): Remove function.
4144 (readevalloop): Don't call read_list with -1 flag.
4145 (read1, read_vector): Don't test read_pure any more.
4146 (read_list): Simplify.
4147
e8d32c7e
SM
4148 * fileio.c, character.h: Minor style tweaks.
4149
4b2addb7
DA
41502012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4151
4152 * window.h (clip_changed): Remove useless declaration.
4153
584461b2
JB
41542012-05-22 Juanma Barranquero <lekktu@gmail.com>
4155
4156 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4157 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4158
34374650
PE
41592012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4160
4161 Remove src/m/*.
4162 This directory predates autoconf and is no longer needed nowadays.
4163 Move its few remaining bits of functionality to where they're needed.
4164 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4165 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4166 * m/template.h: Remove.
4167 * Makefile.in (M_FILE): Remove. All uses removed.
4168 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4169 * lisp.h (USE_LSB_TAG):
4170 * mem-limits.h (EXCEEDS_LISP_PTR):
4171 Use VAL_MAX, not VALBITS, in #if.
4172 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4173 (EMACS_UINT): Define unconditionally now.
4174 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4175 (BITS_PER_EMACS_INT): New constants, replacing
4176 what used to be in config.h, but not useful in #if.
4177 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4178 define them any more.
4179 (VAL_MAX): New macro.
4180 (VALMASK): Use it.
4181 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4182 BITS_PER_EMACS_INT, in #if.
4183 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4184 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4185 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4186 * s/ms-w32.h (DATA_START):
4187 Move here from removed file m/intel386.h.
4188 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4189 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4190
261cb4bb
PE
41912012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 Assume C89 or later.
4194 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4195 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4196 (xrealloc):
4197 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4198 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4199 * textprop.c, tparam.c (NULL): Remove.
4200 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4201 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4202 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4203 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4204 * xterm.c (input_signal_count): Assume volatile works.
4205
ff23cd9f
KB
42062012-05-21 Ken Brown <kbrown@cornell.edu>
4207
4208 * xgselect.c (xg_select): Fix first argument in call to 'select'
4209 (bug#11508).
4210
1b170bc6
KB
42112012-05-20 Ken Brown <kbrown@cornell.edu>
4212
4213 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4214 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4215
b2f4d39f
KB
42162012-05-19 Ken Brown <kbrown@cornell.edu>
4217
4218 * xfns.c (x_in_use): Remove `static' qualifier.
4219 * xterm.h (x_in_use): Declare.
4220 * xgselect.c: Include xterm.h.
4221 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4222 and `display_arg' (bug#9754).
4223
003fdae2
PE
42242012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4225
9232a6d9
PE
4226 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4227
003fdae2
PE
4228 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4229 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4230
784b56e2
EZ
42312012-05-18 Eli Zaretskii <eliz@gnu.org>
4232
4233 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4234
4235 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4236 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4237
4238 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4239 reference to image_cache->refcount.
4240 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4241
a0a79cde
JL
42422012-05-17 Juri Linkov <juri@jurta.org>
4243
4244 * search.c (Fword_search_regexp, Fword_search_backward)
4245 (Fword_search_forward, Fword_search_backward_lax)
4246 (Fword_search_forward_lax): Move functions to isearch.el
4247 (bug#10145, bug#11381).
4248
b0572523
PE
42492012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4250
4251 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4252
9660f5fc
SM
42532012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4254
4255 * lread.c (init_obarray): Declare Qt and Qnil as special.
4256
4374de83
GM
42572012-05-14 Glenn Morris <rgm@gnu.org>
4258
4259 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4260 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4261
dc44c39a
PE
42622012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4263
078c97cb
PE
4264 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4265
dc44c39a
PE
4266 * unexaix.c: Port to more-recent AIX compilers.
4267 (report_error, report_error_1, make_hdr, copy_sym)
4268 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4269 Make arguments const char *, not char *, to avoid violations of C
4270 standard and to fix some AIX warnings reported by Gilles Pion.
4271
e18afed7 42722012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4273
4274 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4275 already have overlays loaded.
4276 (handle_single_display_spec): Before returning without displaying
4277 fringe bitmap, synchronize the bidi iterator with the main display
4278 iterator, by calling iterate_out_of_display_property.
4279 (iterate_out_of_display_property): Detect buffer iteration by
4280 testing that it->string is a Lisp string.
4281 (get_next_display_element): When the current object is exhausted,
4282 and there's something on it->stack, call set_iterator_to_next to
4283 proceed with what's on the stack, instead of returning zero.
4284 (set_iterator_to_next): If called at the end of a Lisp string,
4285 proceed to consider_string_end without incrementing string
4286 position. Don't increment display vector index past the end of
4287 the display vector. (Bug#11417)
c8fb9dc6
EZ
4288 (pos_visible_p): Don't report a position visible when move_it_to
4289 stopped at the last line of window, which happens to be scanned
4290 backwards by the bidi iteration. (Bug#11464)
ac268e67 4291
e18afed7 42922012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4293
4294 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4295 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4296 are on a TTY, and thus unable to display on the fringes.
4297 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4298 so we need to signal to the caller that this is a "replacing"
4299 display spec. This fixes display when the spec is invalid or we
4300 are on a TTY.
4301
e18afed7 43022012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4303
4304 * unexaix.c (make_hdr): Fix typo in prototype.
4305 This bug broke the build on AIX. Problem reported by Gilles Pion.
4306
9d0a235a
MA
43072012-05-14 Michael Albinus <michael.albinus@gmx.de>
4308
4309 * keyboard.c (kbd_buffer_get_event): Read special events also in
4310 batch mode. (Bug#11415)
4311
9e6b06ed
GM
43122012-05-12 Glenn Morris <rgm@gnu.org>
4313
4314 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4315
c1a1d7a3
EZ
43162012-05-12 Eli Zaretskii <eliz@gnu.org>
4317
4318 * lisp.mk (lisp): Add newcomment.elc.
4319
3fe7cdc8
GM
43202012-05-12 Glenn Morris <rgm@gnu.org>
4321
4322 * Makefile.in (MKDIR_P): New, set by configure.
4323 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4324
53f7d2c0
PE
43252012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4326
4327 Remove unused function hourglass_started.
4328 * dispextern.h (hourglass_started):
4329 * w32fns.c (hourglass_started):
4330 * xdisp.c (hourglass_started): Remove.
4331
75aafb17
JB
43322012-05-10 Juanma Barranquero <lekktu@gmail.com>
4333
4334 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4335 Update dependencies.
4336
12959e8e
PE
43372012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4338
97107e2e
PE
4339 * xgselect.c (xg_select): Put maxfds+1 into a var.
4340 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4341
12959e8e
PE
4342 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4343
836d29b3
DA
43442012-05-10 Dave Abrahams <dave@boostpro.com>
4345
4346 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4347 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4348
5cb67954
MA
43492012-05-09 Michael Albinus <michael.albinus@gmx.de>
4350
4351 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4352 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4353 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4354 Initialize xd_registered_buses.
4355
3478ec45
PE
43562012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4357
b263a6b0
PE
4358 Untag more efficiently if USE_LSB_TAG.
4359 This is based on a proposal by YAMAMOTO Mitsuharu in
4360 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4361 For an admittedly artificial (nth 8000 longlist) benchmark on
4362 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4363 Emacs's overall text size by 1%.
4364 * lisp.h (XUNTAG): New macro.
4365 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4366 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4367 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4368 * eval.c (Fautoload):
4369 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4370 * frame.h (XFRAME): Use XUNTAG.
4371
3478ec45
PE
4372 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4373 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4374 Remove unportable assumptions about print widths of types like
4375 dbus_uint32_t.
4376 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4377 intptr_t when converting between pointer and integer, to avoid GCC
4378 warnings about wrong width.
4379
666b903b 43802012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4381
4382 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4383 stack for each reader_thread, instead of defaulting to 8MB
4384 determined by the linker. This avoids failures in creating
4385 subprocesses on Windows 7, see the discussion in this thread:
4386 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4387
b120cc17
JC
43882012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4389
4390 Fix up display of the *Minibuf-0* buffer in the mini window.
4391 * keyboard.c (read_char): Don't clear the echo area if there's no
4392 message to clear.
4393 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4394 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4395
9a4b36f8
MA
43962012-05-07 Michael Albinus <michael.albinus@gmx.de>
4397
4398 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4399 batch mode.
4400
e5f9458f
CY
44012012-05-06 Chong Yidong <cyd@gnu.org>
4402
4403 * lisp.mk (lisp): Update.
4404
eceeb5fc 44052012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4406
4407 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4408
71873e2b
SM
44092012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4410
4411 * data.c (PUT_ERROR): New macro.
4412 (syms_of_data): Use it. Add new error type `user-error'.
4413 * undo.c (user_error): New function.
4414 (Fprimitive_undo): Use it.
4415 * print.c (print_error_message): Adjust print style for `user-error'.
4416 * keyboard.c (user_error): New function.
4417 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4418
ab0fa4e4
PE
44192012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4420
4421 Do not limit current-time-string to years 1000..9999.
4422 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4423 (Fcurrent_time_string): Support any year that is supported by the
4424 underlying localtime representation. Don't use asctime, as it
4425 has undefined behavior for years outside the range -999..9999.
4426
7ed806a7
PE
44272012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4428
4429 Fix race conditions involving setenv, gmtime, localtime, asctime.
4430 Without this fix, interrupts could mess up code that uses these
4431 nonreentrant functions, since setting TZ invalidates existing
4432 tm_zone or tzname values, and since most of these functions return
4433 pointers to static storage.
4434 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4435 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4436 Grow the critical sections to include not just invoking
4437 localtime/gmtime, but also accessing these functions' results
4438 including their tm_zone values if any, and any related TZ setting.
4439 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4440 so that the struct tm is saved in the critical section.
4441 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4442 motivated by the fact that memory allocation needs to be outside
4443 the critical section.
4444
0c16dfed
DA
44452012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4446
4447 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4448 with RESET_INTERVAL.
4449
4450 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4451 Remove duplicated buffer name initialization.
4452
3f83ace8
JM
44532012-05-02 Jim Meyering <jim@meyering.net>
4454
4455 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4456
c7b8541e
JM
4457 * xfns.c (x_window): Use xstrdup (Bug#11375).
4458
90207a15 44592012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4460
4461 * xdisp.c (pos_visible_p): If already at a newline from the
4462 display string before the 'while' loop, don't walk back the glyphs
4463 from it3.glyph_row. Solves assertion violation when the display
4464 string begins with a newline (egg.el). (Bug#11367)
4465
b593d6a9
AH
44662012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4467
4468 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4469 Move to simple.el.
4470
4737362e
GM
44712012-05-01 Glenn Morris <rgm@gnu.org>
4472
99cf43f9
GM
4473 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4474 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4475 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4476 All were removed before 23.1.
4477
9311dcff
GM
4478 * dispnew.c: Remove HAVE_LIBNCURSES test;
4479 it is always true on relevant platforms.
4480
4d5c6349
GM
4481 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4482 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4483
4737362e
GM
4484 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4485
74dd3a6b
AS
44862012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4487
4488 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4489 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4490 Remove.
4491
13c379ee
PE
44922012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4493
4494 Do not avoid creating empty evaporating overlays (Bug#9642).
4495 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4496 That is, do not delete an evaporating overlay if it becomes
4497 empty after its bounds are adjusted to fit within its buffer.
4498 This fix caused other problems, and I'm reverting it until we get
4499 to the bottom of them.
4500
a8e7d6d7 45012012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4502
4503 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4504
a8e7d6d7 45052012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4506
4507 * xdisp.c (pos_visible_p): If the window start position is beyond
4508 ZV, start the display from buffer beginning. Prevents assertion
4509 violation in init_iterator when the minibuffer window is scrolled
4510 via the scroll bar.
4511
4512 * window.c (window_scroll_pixel_based): Likewise.
4513
a8e7d6d7 45142012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4515
4516 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4517
a8e7d6d7 45182012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4519
4520 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4521 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4522
a8e7d6d7 45232012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4524
b593d6a9
AH
4525 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4526 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4527
1c6900d9
EZ
45282012-04-26 Eli Zaretskii <eliz@gnu.org>
4529
4c3fa1d9
EZ
4530 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4531 display element, check also the underlying string or buffer
4532 character. (Bug#11341)
4533
1c6900d9
EZ
4534 * w32menu.c: Include w32heap.h.
4535 (add_menu_item): If the call to AppendMenuW (via
4536 unicode_append_menu) fails, disable Unicode menus only if we are
4537 running on Windows 9X/Me.
4538
42bf8205
AS
45392012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4540
4541 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4542 (xgetint): Add missing shift for LSB tags.
4543
b1bac16e
MR
45442012-04-24 Martin Rudalics <rudalics@gmx.at>
4545
4546 * keyboard.c (read_char): Don't wipe echo area for select window
4547 events: These might get delayed via `mouse-autoselect-window'
4548 (Bug#11304).
4549
d69621cc
JB
45502012-04-24 Juanma Barranquero <lekktu@gmail.com>
4551
4552 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4553 manipulation of :loaded-from data.
4554
02fd101b
JB
45552012-04-23 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4558 now a cons (bug#11311).
4559
888bec30
PE
45602012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4561
89a438bd
PE
4562 Do not create empty overlays with the evaporate property (Bug#9642).
4563 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4564 if it becomes empty after its bounds are adjusted to fit within
4565 its buffer. Without this fix, in a nonempty buffer (let ((o
4566 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4567 yields an empty overlay that has the evaporate property, which is
4568 not supposed to happen.
4569
1068fe4d
PE
4570 Fix minor GTK3 problems found by static checking.
4571 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4572 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4573 (struct _EmacsFixedClass, emacs_fixed_get_type):
4574 Move decls here from emacsgtkfixed.h, since they needn't be public.
4575 (emacs_fixed_get_type): Now static.
4576 (emacs_fixed_class_init): Omit unused local.
4577 (emacs_fixed_child_type): Remove; unused.
4578 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4579 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4580 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4581 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4582 (EMACS_FIXED_GET_CLASS): Remove; unused.
4583 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4584
888bec30
PE
4585 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4586 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4587
de85e130
PE
45882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4589
d0baac98 4590 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4591 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4592 (__malloc_size_t, __malloc_ptrdiff_t):
4593 Remove. All uses removed, replaced by the definiens if needed,
4594 since we can assume C89 or better now.
4595 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4596 (protect_malloc_state, align, get_contiguous_space)
4597 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4598 (malloc_atfork_handler_child, malloc_enable_thread)
4599 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4600 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4601 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4602 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4603 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4604 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4605 Define using prototypes, not old style.
4606 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4607 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4608 (align): Don't assume that signed integer overflow wraps around.
4609 Omit unused local var.
4610 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4611 (_free_internal_nolock, memalign, mallochook, reallochook):
4612 Omit no-longer-needed casts.
4613 (valloc): Use getpagesize, not __getpagesize.
4614 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4615 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4616
de85e130
PE
4617 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4618
dcbf5805
MA
46192012-04-22 Michael Albinus <michael.albinus@gmx.de>
4620
4621 Move functions from C to Lisp. Make non-blocking method calls
4622 the default. Implement further D-Bus standard interfaces.
4623
4624 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4625 (QCdbus_request_name_allow_replacement)
4626 (QCdbus_request_name_replace_existing)
4627 (QCdbus_request_name_do_not_queue)
4628 (QCdbus_request_name_reply_primary_owner)
4629 (QCdbus_request_name_reply_in_queue)
4630 (QCdbus_request_name_reply_exists)
4631 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4632 (QCdbus_registered_serial, QCdbus_registered_method)
4633 (QCdbus_registered_signal): New Lisp objects.
4634 (XD_DEBUG_MESSAGE): Use sizeof.
4635 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4636 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4637 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4638 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4639 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4640 (xd_signature, xd_append_arg): Allow float for integer types.
4641 (xd_get_connection_references): New function.
b593d6a9
AH
4642 (xd_get_connection_address): Rename from xd_initialize.
4643 Return cached address.
dcbf5805
MA
4644 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4645 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4646 level.
4647 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4648 Return number of refcounts.
dcbf5805
MA
4649 (Fdbus_get_unique_name): Make stronger parameter check.
4650 (Fdbus_message_internal): New defun.
4651 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4652 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4653 (Fdbus_send_signal, Fdbus_register_service)
4654 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4655 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4656 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4657 (Vdbus_compiled_version, Vdbus_runtime_version)
4658 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4659 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4660 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4661 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4662 Adapt docstring.
dcbf5805 4663
52828e02
PE
46642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4665
da05bc4c
PE
4666 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4667 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4668 Do not assume ptrdiff_t is the same width as 'int'.
4669
52828e02
PE
4670 * alloc.c: Handle unusual debugging option combinations.
4671 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4672 since the two debugging options are incompatible.
4673 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4674 is defined.
4675 (mem_init, mem_insert, mem_insert_fixup):
4676 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4677 (NEED_MEM_INSERT): Remove; no longer needed.
4678
f01769f9
LL
46792012-04-22 Leo Liu <sdl.web@gmail.com>
4680
4681 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4682
5790543d
PE
46832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 * sysdep.c [__FreeBSD__]: Minor cleanups.
4686 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4687 Use Emacs indenting style more consistently. Avoid some casts.
4688 Use 'double' consistently rather than mixing 'float' and 'double'.
4689
b91b7e4d
EW
46902012-04-21 Eduard Wiebe <usenet@pusto.de>
4691
b593d6a9
AH
4692 * sysdep.c (list_system_processes, system_process_attributes):
4693 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4694
6114eb15
AS
46952012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4696
4697 * lisp.mk (lisp): Update.
4698
2f38dff7
PE
46992012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4700
4701 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4702 It is never used otherwise.
4703
4ae29f89
SM
47042012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4705
4706 * print.c (print_preprocess): Only check print_depth if print-circle
4707 is nil.
4708 (print_object): Check for cycles even when print-circle is nil and
4709 print-gensym is t, but only check print_depth if print-circle is nil.
4710
f30d612a
CY
47112012-04-20 Chong Yidong <cyd@gnu.org>
4712
4713 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4714 set the status to "failed" and ensure that sentinel is run.
4715
c07a4c0b 47162012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4717
4718 * process.c (Fset_process_inherit_coding_system_flag)
4719 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4720 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4721
c07a4c0b 47222012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4723
4724 * xdisp.c (string_buffer_position_lim): Limit starting position to
4725 BEGV.
4726 (set_cursor_from_row): If called for a mode-line or header-line
4727 row, return zero immediately.
4728 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4729 farther than the first row after the header line, if any.
4730 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4731 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4732
c07a4c0b 47332012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4734
4ae29f89
SM
4735 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4736 (bug#11238).
ad3a2b41 4737
c07a4c0b 47382012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47392012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4740
4741 configure: new option --enable-gcc-warnings (Bug#11207)
4742 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4743 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4744 (ALL_CFLAGS): Use new macros rather than old.
4745 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4746 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4747 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4748 -Wunused-result, -Wunused-variable. This should go away once
4749 the Emacs and Gnulib regex code is merged.
4750 (xmalloc, xrealloc): Now static.
4751
aba027e8
PE
47522012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 * dired.c (Fsystem_groups): Remove unused local.
4755
e5a36063
GM
47562012-04-17 Glenn Morris <rgm@gnu.org>
4757
4758 * dired.c (Fsystem_users): Doc fix.
4759
316411f0
DA
47602012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4761
4762 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4763 (syms_of_dired): Add them.
4764
9426aba4
PE
47652012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4766
b62a57be
PE
4767 Fix minor alloc.c problems found by static checking.
4768 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4769 New extern decls, to avoid calling undeclared functions.
4770 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4771 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4772 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4773 (NEED_MEM_INSERT): New macro.
4774 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4775 Remove one incorrect comment and fix another.
b62a57be 4776
3539f31f
PE
4777 Fix minor ralloc.c problems found by static checking.
4778 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4779 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4780 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4781 (r_alloc_sbrk): Now static.
4782
a041960a
PE
4783 Improve ralloc.c interface checking.
4784 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4785 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4786 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4787 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4788 [REL_ALLOC]: ... to here, to check interface.
4789 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4790 Remove decls. This fixes an "It stinks!".
4791
9426aba4
PE
4792 * alloc.c (which_symbols): Fix alignment issue / type clash.
4793
d55c12ed
AS
47942012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4795
4796 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4797 (struct Lisp_Misc_Any): Likewise.
4798 (struct Lisp_Free): Likewise.
4799 * alloc.c (union aligned_Lisp_Symbol): Define.
4800 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4801 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4802 (union aligned_Lisp_Misc): Define.
4803 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4804 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4805 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4806
b948ce8b
PE
48072012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4808
4809 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4810 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4811 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4812 * s/netbsd.h, s/sol2-6.h:
4813 Remove definition of GC_MARK_STACK, since the default now works.
4814 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4815 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4816 no longer the default.
4817 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4818
35dc09a1 48192012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4820
35dc09a1
GM
4821 * lread.c (lisp_file_lexically_bound_p):
4822 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4823
35dc09a1
GM
48242012-04-14 Eli Zaretskii <eliz@gnu.org>
4825
4826 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4827 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4828
48292012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4830
4831 * nsterm.m (constrainFrameRect): Always constrain when there is only
4832 one screen (Bug#10962).
4833
bcd86815
KB
48342012-04-13 Ken Brown <kbrown@cornell.edu>
4835
4836 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4837
c25df26e
RT
48382012-04-13 Reuben Thomas <rrt@sc3d.org>
4839
4840 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4841
0fc59f1e
DC
48422012-04-11 Daniel Colascione <dancol@dancol.org>
4843
4844 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4845 against is gone. It's better to use vfork now so that when Cygwin
4846 gains a new, working vfork, we use it automatically (bug#10398).
4847
de8c03dc
SM
48482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4849
4850 * window.c (save_window_save): Obey window-point-insertion-type.
4851
2f097256
GM
48522012-04-11 Glenn Morris <rgm@gnu.org>
4853
4854 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4855
453b951e
SM
48562012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4857
4858 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4859
75f1671a 48602012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4861
4862 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4863 (force_quit_count): New var.
4864 (handle_interrupt): Use it.
4865
2a8ce227
JB
48662012-04-10 Juanma Barranquero <lekktu@gmail.com>
4867
4868 * w32.c (w32_delayed_load): Record the full path of the library
4869 being loaded (bug#10424).
4870
935396c0
GM
48712012-04-09 Glenn Morris <rgm@gnu.org>
4872
05920a43
GM
4873 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4874 not just in the obarray, before snarfing them. (Bug#11036)
4875
935396c0
GM
4876 * Makefile.in ($(leimdir)/leim-list.el):
4877 Pass EMACS rather than BUILT_EMACS.
4878
a18ecafa
TZ
48792012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4880
4881 * process.c (make_process):
4882 * process.h: Add integer `gnutls_handshakes_tried' member to
4883 process struct.
4884
6bbef4e5
JC
4885 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4886 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4887
4888 * gnutls.c (gnutls_log_function2i): Convenience log function.
4889 (emacs_gnutls_read): Use new log functions,
4890 `gnutls_handshakes_tried' process member, and
4891 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4892 attempts per process (connection).
4893
b4d3bc10
CY
48942012-04-09 Chong Yidong <cyd@gnu.org>
4895
4896 * eval.c (Fuser_variable_p, user_variable_p_eh)
4897 (lisp_indirect_variable): Functions deleted.
4898 (Fdefvar): Caller changed.
4899
4900 * callint.c (Finteractive, Fcall_interactively):
4901 * minibuf.c (Fread_variable): Callers changed.
4902
70f4d973
EZ
49032012-04-09 Eli Zaretskii <eliz@gnu.org>
4904
4905 * xdisp.c (set_cursor_from_row): If the display string appears in
4906 the buffer at position that is closer to point than the position
4907 after the display string, display the cursor on the first glyph of
4908 the display string. Fixes cursor display when a 'display' text
4909 property immediately follows invisible text. (Bug#11094)
4910
cb3c2e3e
PE
49112012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4912
4913 composite.c: use 'double' consistently
4914 * composite.c (get_composition_id): Use 'double' consistently
4915 instead of converting 'float' to 'double' and vice versa; this is
4916 easier to understand and avoids a GCC warning.
4917
fd06db5d
GM
49182012-04-09 Glenn Morris <rgm@gnu.org>
4919
50fe702a
GM
4920 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4921 preparation for dumping it with emacs. (Bug#4789)
4922 (leimdir): New variable.
4923 ($(leimdir)/leim-list.el): New rule.
4924 (emacs$(EXEEXT)): Depend on leim-list.el.
4925
fd06db5d
GM
4926 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4927 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4928 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4929
55c131ee
AS
49302012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4931
4932 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4933 proper alignment.
4934
9209588f
JB
49352012-04-07 Juanma Barranquero <lekktu@gmail.com>
4936
4937 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4938 Remove unused local variable.
4939
e3fb2efb
PE
49402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4943 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4944 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4945 objects, as mark_maybe_pointer will catch them otherwise.
4946 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4947 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4948
b5385551
PE
49492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4950
4951 Fix typo that broke non-Windows builds.
4952 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4953
9078ead6
EZ
49542012-04-07 Eli Zaretskii <eliz@gnu.org>
4955
4956 Support building on MS-Windows with libxml2.
4957
4958 * makefile.w32-in (OBJ2): Add xml.$(O).
4959 (GLOBAL_SOURCES): Add xml.c.
4960 ($(BLD)/xml.$(O)): New dependency list.
4961
4962 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4963 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4964 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4965 [!WINDOWSNT]: New macros.
4966 (init_libxml2_functions, libxml2_loaded_p): New functions.
4967 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4968 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4969 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4970 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4971 linked in).
6bbef4e5
JC
4972 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4973 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4974 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4975
4976 * emacs.c: Don't include libxml/parser.h.
4977 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4978 xmlCleanupParser directly.
4979
4980 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4981
3811fdf3
EZ
49822012-04-07 Eli Zaretskii <eliz@gnu.org>
4983
4984 * indent.c (Fvertical_motion): If there is a display string at
4985 point, use it.vpos to compute how many lines to backtrack after
4986 move_it_to point. (Bug#11133)
4987
2f8e16b2
EZ
49882012-04-06 Eli Zaretskii <eliz@gnu.org>
4989
4990 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4991 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4992 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4993 macros related to unification of CJK characters. For the details,
4994 see the discussion following the message here:
4995 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4996
3d439cd1
CY
49972012-04-04 Chong Yidong <cyd@gnu.org>
4998
4999 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5000
8bc53d00
EZ
50012012-04-01 Eli Zaretskii <eliz@gnu.org>
5002
5003 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5004 instead of alloca. (Bug#11138)
5005
3b0512a3
AS
50062012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5007
5008 * w32menu.c (is_simple_dialog): Properly check lisp types.
5009 (Bug#11141)
5010
8427ddd2
EZ
50112012-03-31 Eli Zaretskii <eliz@gnu.org>
5012
979022ef
EZ
5013 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5014 position we get to after a call to move_it_to fails the
5015 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5016 only if we wind up in a string from display property. (Bug#11063)
5017
a6b1c7cc
EZ
5018 * window.c (Fdelete_other_windows_internal): Invalidate the row
5019 and column information about mouse highlight, so that redisplay
5020 restores it after reallocating the glyph matrices. (Bug#7464)
5021
8427ddd2
EZ
5022 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5023 string comes from a `display' text property, use the buffer
5024 position of that property as if we actually saw that position in
5025 the row's glyphs.
697ba24b
EZ
5026 (move_it_by_lines): Remove the assertion that
5027 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5028 violated when there's a before-string at the beginning of a line.
5029 (Bug#11063)
8427ddd2 5030
65a0a738
EZ
50312012-03-30 Eli Zaretskii <eliz@gnu.org>
5032
5033 * xdisp.c (append_space_for_newline): If the default face was
5034 remapped, use the remapped face for the appended newline.
5035 (extend_face_to_end_of_line): Use the remapped default face for
5036 extending the face to the end of the line.
5037 (display_line): Call extend_face_to_end_of_line when the default
5038 face was remapped. (Bug#11068)
5039
581355cc
EZ
50402012-03-29 Eli Zaretskii <eliz@gnu.org>
5041
5042 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5043
e8fc049f
SM
50442012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5045
5046 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5047
4fb9a543
GM
50482012-03-27 Glenn Morris <rgm@gnu.org>
5049
5050 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5051 Doc fixes.
5052
679910f1
KH
50532012-03-26 Kenichi Handa <handa@m17n.org>
5054
5055 * dispextern.h (struct glyph): Fix previous change. Change the
5056 bit length of glyphless.ch to 25 (Bug#11082).
5057
90d49b7f
CY
50582012-03-26 Chong Yidong <cyd@gnu.org>
5059
5060 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5061 (command_loop_1): Use it; inhibit selection update for
5062 handle-select-window too (Bug#8996).
5063
f514f6f0
FP
50642012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5065
e8fc049f 5066 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5067
bf43fa51
KH
50682012-03-25 Kenichi Handa <handa@m17n.org>
5069
5070 * dispextern.h (struct glyph): Change the bit length of
5071 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5072
8a0c01dd
EZ
50732012-03-24 Eli Zaretskii <eliz@gnu.org>
5074
5075 * s/ms-w32.h (tzname): Include time.h before redirecting to
5076 _tzname. Fixes the MSVC build. (Bug#9960)
5077
7d1c3a76
AS
50782012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5079
8ed79523
AS
5080 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5081 characters.
5082
7d1c3a76
AS
5083 * xterm.c (XTread_socket): Only modify handling_signal if
5084 !SYNC_INPUT. (Bug#11080)
5085
e99a9b8b
EZ
50862012-03-23 Eli Zaretskii <eliz@gnu.org>
5087
5088 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5089 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5090 when fetching a multibyte character consumes more bytes than
5091 CHAR_BYTES returns, due to unification of CJK characters in
5092 string_char. (Bug#11073)
5093
5063c0e1
TN
50942012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5095
5096 * process.c (wait_reading_process_output): Handle pty disconnect
5097 by refraining from sending oneself a SIGCHLD (bug#10933).
5098
9f851fbd
CY
50992012-03-22 Chong Yidong <cyd@gnu.org>
5100
5101 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5102
5063c0e1 5103 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5104 Mark string as coming from a prefix property.
5105 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5106 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5107
fb5b8aca
CY
51082012-03-21 Chong Yidong <cyd@gnu.org>
5109
5110 * xfaces.c (Vface_remapping_alist): Doc fix.
5111
62356a1b
EZ
51122012-03-20 Eli Zaretskii <eliz@gnu.org>
5113
5114 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5115 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5116 Doc fixes.
62356a1b 5117
025de85b
CY
51182012-03-20 Chong Yidong <cyd@gnu.org>
5119
5120 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5121 to reflect default non-nil value of redisplay-dont-pause.
5122
4827f94e
KH
51232012-03-19 Kenichi Handa <handa@m17n.org>
5124
5125 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5126 it fit in a valid range (Bug#11003).
5127
e50a24a2
EZ
51282012-03-18 Eli Zaretskii <eliz@gnu.org>
5129
5130 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5131 that is not from display property, accept the row as a "cursor
5132 row" if one of the string's character has a non-nil `cursor'
5133 property. Fixes cursor positioning when there are newlines in
5134 overlay strings, e.g. in icomplete.el. (Bug#11035)
5135
9af5ed87
PE
51362012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5139
d1f55f16
CY
51402012-03-12 Chong Yidong <cyd@gnu.org>
5141
5142 * eval.c (inhibit_lisp_code): Rename from
5143 inhibit_window_configuration_change_hook; move from window.c.
5144
5145 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5146 * window.c (run_window_configuration_change_hook)
5147 (syms_of_window): Callers changed.
5148
66c5eebd
CY
51492012-03-11 Chong Yidong <cyd@gnu.org>
5150
413df973
CY
5151 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5152
66c5eebd
CY
5153 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5154
1de11f56
CY
51552012-03-10 Chong Yidong <cyd@gnu.org>
5156
5157 * frame.c (other_visible_frames): Don't assume the selected frame
5158 is visible (Bug#10955).
5159
cae07000
SM
51602012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5161
5162 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5163
89c94350
JD
51642012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5165
5166 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5167 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5168 zero (Bug#10954).
5169
999dd333
GM
51702012-03-03 Glenn Morris <rgm@gnu.org>
5171
01a6dcc8 5172 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5173
de0100f2
EZ
51742012-03-02 Eli Zaretskii <eliz@gnu.org>
5175
5176 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5177 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5178 (redisplay_window, next_element_from_string): Fix typos in
5179 comments.
3e441275
EZ
5180 (redisplay_window): Pass to move_it_vertically the margin in
5181 pixels, not in screen lines.
de0100f2 5182
96a72ee9
GM
51832012-03-02 Glenn Morris <rgm@gnu.org>
5184
5185 * buffer.c (buffer-list-update-hook): Doc fix.
5186
312508d7
EZ
51872012-02-29 Eli Zaretskii <eliz@gnu.org>
5188
5189 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5190 push_it before setting up the iterator for the first overlay
5191 string, even if we have an empty string loaded.
5192 (next_overlay_string): If there's an empty string on the iterator
5193 stack, pop the stack. (Bug#10903)
5194
27f3c637
PE
51952012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5196
5197 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5198 Suggested by Stefan Monnier in
5199 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5200 * alloc.c (widen_to_Lisp_Object): New static function.
5201 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5202 and widening them to Lisp_Objects. This would work even if
5203 USE_LSB_TAG is defined and wide integers are used, which might
5204 happen in a future version of Emacs.
5205
3c9dfce6
CY
52062012-02-25 Chong Yidong <cyd@gnu.org>
5207
fa74b241
CY
5208 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5209 Doc fix.
5210
3c9dfce6
CY
5211 * xselect.c (Fx_selection_exists_p): Doc fix.
5212 (x_clipboard_manager_save_all): Print an informative message
5213 before saving to clipboard manager.
5214
9486df08
CY
52152012-02-24 Chong Yidong <cyd@gnu.org>
5216
5217 * keyboard.c (process_special_events): Handle all X selection
5218 requests in kbd_buffer, not just the next one (Bug#8869).
5219
f01d3321
CY
52202012-02-23 Chong Yidong <cyd@gnu.org>
5221
5222 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5223 call when setting menu-bar-lines and tool-bar-lines parameters.
5224 (unwind_create_frame_1): New helper function.
5225
5226 * window.c (inhibit_window_configuration_change_hook): New var.
5227 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5228 (syms_of_window): Initialize it.
f01d3321 5229
86b847b6
CY
52302012-02-22 Chong Yidong <cyd@gnu.org>
5231
5232 * xterm.c (x_draw_image_relief): Add missing type check for
5233 Vtool_bar_button_margin (Bug#10743).
5234
a59225b1
CY
52352012-02-21 Chong Yidong <cyd@gnu.org>
5236
5237 * fileio.c (Vfile_name_handler_alist): Doc fix.
5238
5239 * buffer.c (Fget_file_buffer): Protect against invalid file
5240 handler return value.
5241
310f5bd4
PE
52422012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5243
cb3a28cc
PE
5244 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5245 when computing $valmask.
5246
310f5bd4
PE
5247 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5248 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5249 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5250 It's useless in that case, and it can cause problems on hosts
5251 that allocate halves of EMACS_INT values separately.
5252 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5253 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5254 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5255 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5256 it avoids undefined behavior on hosts where shifting right by more
5257 than the word width has undefined behavior.
5258
2375c96a
CY
52592012-02-19 Chong Yidong <cyd@gnu.org>
5260
5261 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5262 (Funhandled_file_name_directory, Ffile_name_as_directory)
5263 (Fdirectory_file_name, Fexpand_file_name)
5264 (Fsubstitute_in_file_name): Protect against invalid file handler
5265 return values (Bug#10845).
5266
3eb49e71
EZ
52672012-02-18 Eli Zaretskii <eliz@gnu.org>
5268
5269 * .gdbinit (pitx): Fix incorrect references to fields of the
5270 iterator stack.
5271
7b926f3f
CY
52722012-02-17 Chong Yidong <cyd@gnu.org>
5273
5274 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5275
11273115
PE
52762012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5277
5278 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5279 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5280
c3a70e2b
CY
52812012-02-15 Chong Yidong <cyd@gnu.org>
5282
5283 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5284 marked as special. Also, starting docstrings with * is obsolete.
5285
0ca43699
AS
52862012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5287
5288 * gnutls.c (emacs_gnutls_write): Fix last change.
5289
2e8f3c56
LI
52902012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5291
5292 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5293 send_process.
5294
af70074f
SM
52952012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5296
5297 * keymap.c (Fsingle_key_description): Handle char ranges.
5298
95986d52
CY
52992012-02-12 Chong Yidong <cyd@gnu.org>
5300
afd83bd1
CY
5301 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5302 as that creates a dangerous corner case.
5303
95986d52
CY
5304 * window.c (Fdelete_window_internal): Invalidate the mouse
5305 highlight (Bug#9904).
5306
bd7da63e
GM
53072012-02-12 Glenn Morris <rgm@gnu.org>
5308
5309 * xselect.c (Fx_own_selection_internal)
5310 (Fx_get_selection_internal, Fx_disown_selection_internal)
5311 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5312 * nsselect.m (Fx_own_selection_internal)
5313 (Fx_disown_selection_internal, Fx_selection_exists_p)
5314 (Fx_selection_owner_p, Fx_get_selection_internal):
5315 Sync docs and argument specs with the xselect.c versions.
5316
77abcbc2
LI
53172012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5318
5319 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5320
90b671e2
EZ
53212012-02-11 Eli Zaretskii <eliz@gnu.org>
5322
1c0ca0b7
EZ
5323 * w32select.c (Fx_selection_exists_p): Sync doc string and
5324 argument list with xselect.c. (Bug#10783)
5325
5326 * w16select.c (Fx_selection_exists_p): Sync doc string and
5327 argument list with xselect.c. (Bug#10783)
90b671e2 5328
49241268
GM
53292012-02-10 Glenn Morris <rgm@gnu.org>
5330
5331 * fns.c (Fsecure_hash): Doc fix.
5332
f998bbe7 53332012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5334
5335 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5336
0992bd9c
CY
53372012-02-07 Chong Yidong <cyd@gnu.org>
5338
5339 * buffer.c (Fbuffer_local_variables)
5340 (buffer_lisp_local_variables): Handle unbound vars correctly;
5341 don't let Qunbound leak into Lisp.
5342
af008560
GM
53432012-02-07 Glenn Morris <rgm@gnu.org>
5344
dd605cc4
GM
5345 * image.c (Fimagemagick_types): Doc fix.
5346
af008560
GM
5347 * image.c (imagemagick-render-type): Change it from a lisp object
5348 to an integer. Move the doc here from the lisp manual.
5349 Treat all values not equal to 0 the same.
5350
1449fa1d
CY
53512012-02-06 Chong Yidong <cyd@gnu.org>
5352
5353 * doc.c (store_function_docstring): Avoid applying docstring of
5354 alias to base function (Bug#2603).
5355
3723ec07
AS
53562012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5357
5358 * .gdbinit (pp1, pv1): Remove redundant defines.
5359 (pr): Use pp.
5360
79c1cc1e
CY
53612012-02-04 Chong Yidong <cyd@gnu.org>
5362
5363 * nsterm.m: Declare a global (Bug#10694).
5364
d7f29f8e
EZ
53652012-02-04 Eli Zaretskii <eliz@gnu.org>
5366
cae07000
SM
5367 * w32.c (get_emacs_configuration_options):
5368 Include --enable-checking, if specified, in the return value.
d7f29f8e 5369
3b95a6f9
MR
53702012-02-04 Martin Rudalics <rudalics@gmx.at>
5371
5372 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5373 after rounding frame sizes. (Bug#9723)
5374
d6fa96a6
EZ
53752012-02-04 Eli Zaretskii <eliz@gnu.org>
5376
5377 * keyboard.c (adjust_point_for_property): Don't position point
5378 before BEGV. (Bug#10696)
5379
df0b2940
PE
53802012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5381
5382 Handle overflow when computing char display width (Bug#9496).
5383 * character.c (char_width): Return EMACS_INT, not int.
5384 (char_width, c_string_width): Check for overflow when
5385 computing the width; this is possible now that individual
5386 characters can have unbounded width. Problem introduced
5387 by merge from Emacs 23 on 2012-01-19.
5388
6bee44d6
MA
53892012-02-02 Michael Albinus <michael.albinus@gmx.de>
5390
5391 * dbusbind.c (Fdbus_register_method): Mention the return value
5392 :ignore in the docstring.
5393
44f92739
GM
53942012-02-02 Glenn Morris <rgm@gnu.org>
5395
1b9f60cc
GM
5396 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5397
44f92739
GM
5398 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5399 Unconditionally set to t. (Bug#10673)
5400 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5401 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5402 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5403
c5d3843c
KH
54042012-02-02 Kenichi Handa <handa@m17n.org>
5405
5406 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5407 0, do not call append_composite_glyph.
5408
159462d4 54092012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5410
5411 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5412 NULL (Bug#6988).
5413 (x_produce_glyphs): If the component of a composition is a null
5414 string, set it->pixel_width to 1 to avoid zero-width glyph.
5415
78cef877
EZ
54162012-02-01 Eli Zaretskii <eliz@gnu.org>
5417
5418 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5419 first 2 arguments are identical. This makes inserting large
5420 output from a subprocess an order of magnitude faster on
5421 MS-Windows, where all sbrk'ed memory is always contiguous.
5422
97897668
GM
54232012-01-31 Glenn Morris <rgm@gnu.org>
5424
5425 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5426 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5427 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5428
31fd3586
GM
54292012-01-29 Glenn Morris <rgm@gnu.org>
5430
5431 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5432
0e24a8b2
CY
54332012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5434
5435 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5436
cc0adcb0
CY
54372012-01-28 Chong Yidong <cyd@gnu.org>
5438
5439 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5440
acc28cb9
CY
54412012-01-26 Chong Yidong <cyd@gnu.org>
5442
9c69cfb7
CY
5443 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5444
acc28cb9
CY
5445 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5446 repeat counts (Bug#10507).
5447
48da7392
GM
54482012-01-26 Glenn Morris <rgm@gnu.org>
5449
5450 * lread.c (syms_of_lread): Doc fix.
5451
14af5f7f
CY
54522012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5453
5454 * coding.c (encode_designation_at_bol): Change return value to
5455 EMACS_INT.
5456
0b21c100
CY
54572012-01-25 Chong Yidong <cyd@gnu.org>
5458
5459 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5460
3c2907f7
CY
54612012-01-21 Chong Yidong <cyd@gnu.org>
5462
5463 * floatfns.c (Fcopysign): Make the second argument non-optional,
5464 since nil is not allowed anyway.
5465
959ad23f
AS
54662012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5467
5468 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5469 (send_process): Likewise.
5470
34a02f46
MR
54712012-01-19 Martin Rudalics <rudalics@gmx.at>
5472
5473 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5474 (Vwindow_persistent_parameters): Do not use Qstate.
5475 Rewrite doc-strings.
34a02f46 5476
1259009a 54772012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5478
5479 * character.c (char_width): New function.
70d4fdf6
GM
5480 (Fchar_width, c_string_width, lisp_string_width):
5481 Use char_width (Bug#9496).
25ed9e61 5482
6a6ee00d
MR
54832012-01-16 Martin Rudalics <rudalics@gmx.at>
5484
5485 * window.c (Vwindow_persistent_parameters): New variable.
5486 (Fset_window_configuration, save_window_save): Handle persistent
5487 window parameters.
5488
c85efaf7
EZ
54892012-01-14 Eli Zaretskii <eliz@gnu.org>
5490
5491 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5492 thrashing the stack of the thread. (Bug#9087)
5493
5944709e
PE
54942012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5495
5496 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5497
e71f5d99
EZ
54982012-01-11 Eli Zaretskii <eliz@gnu.org>
5499
5500 * xdisp.c (rows_from_pos_range): Handle the case where the
5501 highlight ends on a newline. (Bug#10464)
5502 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5503 he end column for display of highlight that ends on a newline
5504 before a R2L line.
5505
ce316182
GM
55062012-01-11 Glenn Morris <rgm@gnu.org>
5507
5508 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5509 from load-path also when installation-directory is nil. (Bug#10208)
5510
5b43da69
GM
55112012-01-10 Glenn Morris <rgm@gnu.org>
5512
74cc8ff9
GM
5513 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5514
7d8d6e4e
GM
5515 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5516 Update template values to be closer to their typical values these days.
5b43da69 5517
a0db8d43
EZ
55182012-01-09 Eli Zaretskii <eliz@gnu.org>
5519
5520 * xdisp.c (rows_from_pos_range): Accept additional argument
5521 DISP_STRING, and accept any glyph in a row whose object is that
5522 string as eligible for mouse highlight. Fixes mouse highlight of
5523 display strings from overlays. (Bug#10464)
5524
9a0115ab 55252012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5526
b9110d6a 5527 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5528 * fileio.c (auto_saving_dir_umask): New static var.
5529 (Fmake_directory_internal): Use it.
5530 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5531 creating the directory. The old code temporarily assigns
5532 too-generous permissions to the directory.
5533 (do_auto_save_eh): Clear it.
b9110d6a 5534 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5535 that the var is always cleared.
5536
6c1bd3f3
EZ
55372012-01-07 Eli Zaretskii <eliz@gnu.org>
5538
5539 * search.c (scan_buffer): Pass character positions to
5540 know_region_cache, not byte positions. (Bug#6540)
5541
069d2b50
L
55422012-01-07 LynX <_LynX@bk.ru> (tiny change)
5543
5544 * w32.c (sys_rename): Report EXDEV when rename of a directory
5545 fails because the target is on another logical disk. (Bug#10284)
5546
75bf0d33
DB
55472012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5548
5549 * xterm.c (x_embed_request_focus): New function.
5550
5551 * xterm.h: Add prototype.
5552
5553 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5554
1c6e5a32
GM
55552012-01-05 Glenn Morris <rgm@gnu.org>
5556
5557 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5558
651e947e
EZ
55592012-01-01 Eli Zaretskii <eliz@gnu.org>
5560
5561 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5562 Load gnutls_transport_set_lowat only if GnuTLS version is below
5563 2.11.1.
5564 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5565 GnuTLS versions below 2.11.1.
5566
3778cdd8
AL
55672011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5568
5569 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5570 to the doc string advising against its use for altering the way
5571 windows are scrolled.
5572
0e5317f7
KH
55732011-12-28 Kenichi Handa <handa@m17n.org>
5574
5575 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5576 coding-system ASCII compatible only when it does not produce BOM
5577 on encoding (Bug#10383).
5578
93d5ca1f
JD
55792011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5580
5581 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5582 can scroll.
5583 (create_and_show_popup_menu): Always use menu_position_func for
5584 Gtk3 (Bug#10361).
5585
ca22b785
AS
55862011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5587
5588 * callint.c (Fcall_interactively): Don't truncate prompt string.
5589
d048e1e6
EZ
55902011-12-23 Eli Zaretskii <eliz@gnu.org>
5591
5592 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5593 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5594 resumed from there (after widening). (Bug#10360)
d048e1e6 5595
5ccaba1f
JD
55962011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5597
5598 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5599
204ee57f
JD
56002011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5601
b81d40f0
JB
5602 * nsterm.m (x_free_frame_resources):
5603 Release f->output_data.ns->miniimage.
204ee57f
JD
5604 (ns_index_color): Fix indentation. Do not retain
5605 color_table->colors[i].
5606
5607 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5608 before returning.
5609
5610 * nsfns.m (x_set_background_color): Assign return value from
5611 ns_index_color to face-background instead of NSColor*.
5612 (ns_implicitly_set_icon_type): Fix indentation.
5613 Change assignment in for loop to comparison.
5614
5615 * emacs.c (ns_pool): New variable.
5616 (main): Assign ns_pool.
5617 (Fkill_emacs): Call ns_release_autorelease_pool.
5618
5619 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5620 autorelease fdesc, release fdAttrs and tdict.
5621 (ns_get_covering_families): Release charset.
5622 (ns_findfonts): Release NSFontDescriptor created with new.
5623 (ns_uni_to_glyphs): Fix indentation.
5624 (setString): Release attrStr before assigning new value.
5625
c803b2b7
JD
56262011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5627
678f4426
JD
5628 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5629 and NS_IMPL_COCOA.
5630 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5631 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5632
cd394be1 56332011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5634
5fecd5fc
JD
5635 * nsterm.m (ns_term_init): Subscribe for notifications
5636 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5637 to method trackingNotification in EmacsMenu.
5638
5639 * nsmenu.m (trackingMenu): New variable.
3771cb17 5640 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5641 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5642 from Aquamacs (Bug#7030).
678f4426
JD
5643
56442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5645
c803b2b7
JD
5646 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5647 (symbol_to_nsstring): Fix indentation.
5648 (ns_symbol_to_pb): New function.
cae07000
SM
5649 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5650 (Fns_rotate_cut_buffers_internal): Remove.
5651 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5652 Fns_store_cut_buffer_internal.
5653 (ns_get_foreign_selection, Fx_own_selection_internal)
5654 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5655 (Fns_get_selection_internal, Fns_store_selection_internal):
5656 Use ns_symbol_to_pb and check if return value is nil.
5657 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5658 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5659 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5660 renamed to Sns_store_selection_internal.
5661 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5662 and remove this function.
5663 (ns_handle_selection_clear): Remove, never used.
5664 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5665 here.
5666
e1b01a3a
KB
56672011-12-17 Ken Brown <kbrown@cornell.edu>
5668
5669 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5670 GID is unknown (Bug#10257).
5671
2adb6e85
PE
56722011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5673
5674 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5675 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5676 which caused a build failure on GNU/Linux IA-64. This problem was
5677 introduced by my 2011-10-07 patch.
5678
d1d7b339
JL
56792011-12-15 Juri Linkov <juri@jurta.org>
5680
5681 * image.c (imagemagick_error): New function. (Bug#10112)
5682 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5683 Use `imagemagick_error' where ImageMagick functions return
5684 `MagickFalse'.
5685 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5686 proper order.
5687
100d5755
KH
56882011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5689
5690 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5691 fill background (Bug#8992).
5692
454592a6
MR
56932011-12-13 Martin Rudalics <rudalics@gmx.at>
5694
5695 * window.c (Vwindow_combination_resize)
5696 (Vwindow_combination_limit): Use t instead of non-nil in
5697 doc-strings.
61d4b438
MR
5698 (Vrecenter_redisplay): Add first sentence of doc-string on
5699 separate line.
53524d93 5700 (Frecenter): Fix doc-string typo.
454592a6 5701
3633e3aa
KH
57022011-12-11 Kenichi Handa <handa@m17n.org>
5703
5704 * coding.c (Funencodable_char_position): Pay attention to the
5705 buffer text relocation (Bug#9389).
5706
7b9d523a 57072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5708
7b9d523a
JD
5709 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5710 gtk_init (Bug#10100).
5711
b73189c6
EZ
57122011-12-10 Eli Zaretskii <eliz@gnu.org>
5713
5714 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5715 IT->string is nil. (Bug#10263)
5716
f7dfe5d6
JD
57172011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5718
83faebb4
JD
5719 * nsterm.h (x_free_frame_resources): Declare.
5720
f7dfe5d6
JD
5721 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5722 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5723
5724 * nsterm.h (ns_get_defaults_value): Declare.
5725
5726 * nsterm.m (ns_default): Call ns_get_defaults_value.
5727
7cd4e72c
EZ
57282011-12-09 Eli Zaretskii <eliz@gnu.org>
5729
5730 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5731 (Bug#10170)
5732
b34d7317
YM
57332011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5734
5735 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5736 that where the value of an _OBJC_* symbol points to is in the .bss
5737 section (Bug#10240).
5738
76470ad1
KH
57392011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5740
5741 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5742 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5743
745fff94
KH
57442011-12-08 Kenichi Handa <handa@m17n.org>
5745
5746 * ftfont.c (get_adstyle_property): Fix previous change
5747 (Bug#10233).
5748
6e44397c
JB
57492011-12-07 Juanma Barranquero <lekktu@gmail.com>
5750
5751 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5752 dirs from the default value of EMACSLOADPATH (bug#10208).
5753
7efa6272
GM
57542011-12-07 Glenn Morris <rgm@gnu.org>
5755
5756 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5757 installation and source directories as well. (Bug#10208)
5758
f6fc4d87
CY
57592011-12-06 Chong Yidong <cyd@gnu.org>
5760
5761 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5762
2bf26180
GM
57632011-12-06 Glenn Morris <rgm@gnu.org>
5764
5765 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5766 as an error, not just -1. (Bug#10217)
5767
3a6ad4f0
CY
57682011-12-05 Chong Yidong <cyd@gnu.org>
5769
5770 * keyboard.c (process_special_events): New function.
5771 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5772
75a3b399
PE
57732011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5774
5775 * coding.c (encode_designation_at_bol): Don't use uninitialized
5776 local variable (Bug#9318).
5777
c3c9e25e
KH
57782011-12-05 Kenichi Handa <handa@m17n.org>
5779
5780 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5781 return Qnil (Bug#8046, Bug#10193).
5782
5eb05ea3
KH
57832011-12-05 Kenichi Handa <handa@m17n.org>
5784
5785 * coding.c (encode_designation_at_bol): New args charbuf_end and
5786 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5787 (coding_set_source): Return how many bytes coding->source was
5788 relocated.
5789 (coding_set_destination): Return how many bytes
5790 coding->destination was relocated.
5791 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5792 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5793
57942011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5795
5796 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5797 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5798 macro (Bug#9318).
5799
58002011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5801
5802 The following changes are to fix Bug#9318.
5803
a79703f5 5804 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5805 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5806 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5807 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5808
7dbda6df
JB
58092011-12-05 Juanma Barranquero <lekktu@gmail.com>
5810
5811 * lisp.h (process_quit_flag): Fix external declaration.
5812
6d5eb5b0
SM
58132011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5814
5815 Don't macro-inline non-performance-critical code.
5816 * eval.c (process_quit_flag): New function.
5817 * lisp.h (QUIT): Use it.
5818
a0c3fad0
JD
58192011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5820
5821 * nsfns.m (get_geometry_from_preferences): New function.
5822 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5823
6c07aac2
AS
58242011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5825
5826 * emacs.c (Qkill_emacs): Define.
5827 (syms_of_emacs): Initialize it.
5828 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5829 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5830 (quit_throw_to_read_char): Add parameter `from_signal'.
5831 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5832 * lisp.h (QUIT): Call Fkill_emacs if requested.
5833
c052ead4
JD
58342011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5835
5836 * widget.c (update_wm_hints): Return if wmshell is null.
5837 (widget_update_wm_size_hints): New function.
5838
5839 * widget.h (widget_update_wm_size_hints): Declare.
5840
5841 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5842 widget_update_wm_size_hints (Bug#10104).
5843
9e49252b
EZ
58442011-12-03 Eli Zaretskii <eliz@gnu.org>
5845
5846 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5847 before a newline, prepare the bidi iterator for consuming the
5848 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5849 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5850
02b16839
JL
58512011-12-02 Juri Linkov <juri@jurta.org>
5852
5853 * search.c (Fword_search_regexp): New Lisp function created from
5854 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5855 (Fword_search_backward, Fword_search_forward)
5856 (Fword_search_backward_lax, Fword_search_forward_lax):
5857 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5858 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5859
0068070e
SM
58602011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5861
5862 * fileio.c (Finsert_file_contents): Move after-change-function call
5863 to before the "handled:" label, since all "goto handled" appear in
5864 cases where the *-change-functions have already been properly called
5865 (bug#10117).
5866
3360a3fc
AS
58672011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5868
5869 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5870 waiting for input. (Bug#10169)
5871
73d6c093
EZ
58722011-11-30 Eli Zaretskii <eliz@gnu.org>
5873
5874 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5875 verifies glyph row's hash code--we have just reallocated the
5876 glyphs, so their contents can be complete garbage. (Bug#10164)
5877
febe6bea
JB
58782011-11-30 Juanma Barranquero <lekktu@gmail.com>
5879
5880 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5881
801a4313
EZ
58822011-11-30 Eli Zaretskii <eliz@gnu.org>
5883
5884 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5885 attributes are tested _before_ calling verify_row_hash, to protect
5886 against GCC re-ordering of the tests. (Bug#10164)
5887
2b56b87e
JD
58882011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5889
5890 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5891
5892 * xterm.c (handle_one_xevent): Only set async_visible and friends
5893 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5894 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5895 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5896
dbf31225
PE
58972011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5898
5899 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5900 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5901 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5902 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5903 All uses changed to use GCPRO1 etc.
5904 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5905 Revert to old implementation (i.e., before 2011-03-11).
5906
1305621b
YM
59072011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5908
5909 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5910 of scroll runs so as to avoid assigning disabled bogus rows and
5911 unnecessary graphics copy operations.
5912
8c9afb46
EZ
59132011-11-27 Eli Zaretskii <eliz@gnu.org>
5914
5915 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5916 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5917 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5918 (malloc, free, realloc, calloc): Redirect to e_* only when
5919 compiling Emacs.
5920
5921 * lisp.h (GCTYPEBITS): Move before first use.
5922 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5923 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5924 this macro definition.
5925
5926 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5927 _MSC_VER.
5928
54e9e3bf
JD
59292011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5930
6d5eb5b0
SM
5931 * gtkutil.c (xg_create_frame_widgets):
5932 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5933 present with Gtk+ 2.0.
5934
83aca1cb
PE
59352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5936
5937 * fileio.c (Finsert_file_contents): Undo previous change; see
5938 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5939
5b76caa4
PE
59402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5941
5942 Rename locals to avoid shadowing.
5943 * fileio.c (Finsert_file_contents):
5944 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5945 * process.c (wait_reading_process_output):
5946 Rename inner 'proc' to 'p' to avoid shadowing.
5947 Indent for consistency with usual Emacs style.
5948
8c535114
EZ
59492011-11-25 Eli Zaretskii <eliz@gnu.org>
5950
5951 * xdisp.c (redisplay_window): If cursor row is not fully visible
5952 after recentering, and scroll-conservatively is set to a large
5953 number, scroll window by a few more lines to make the cursor fully
5954 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5955 (start_display): Don't move to the next line if the display should
5956 start at a newline that is part of a display vector or an overlay
5957 string. (Bug#10119)
8c535114 5958
fa4fdb5c
JL
59592011-11-24 Juri Linkov <juri@jurta.org>
5960
5961 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5962 after the `MagickPingImage' call. (Bug#10112)
5963
90ec88df
CY
59642011-11-23 Chong Yidong <cyd@gnu.org>
5965
5966 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5967
56e2e794
MR
59682011-11-23 Martin Rudalics <rudalics@gmx.at>
5969
5970 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5971 making another buffer current. (Bug#10114)
5972
b6e64c41
GM
59732011-11-23 Glenn Morris <rgm@gnu.org>
5974
5975 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5976
6b21de18
CY
59772011-11-23 Chong Yidong <cyd@gnu.org>
5978
5979 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5980 using it (Bug#5984).
5981
b12cd789
EZ
59822011-11-22 Eli Zaretskii <eliz@gnu.org>
5983
5984 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5985 and header-lines, as they don't have one computed for them.
5986 (Bug#10098)
5987
5988 * .gdbinit (prow): Make displayed values more self-explaining.
5989 Add row's hash code.
5990
261b6fd4
LMI
59912011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5992
5993 * process.c (wait_reading_process_output): Fix asynchrounous
5994 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5995 (wait_reading_process_output): Add comment and URL.
261b6fd4 5996
e7cfd277
JD
59972011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5998
5999 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6000
a9b9b7f5
CY
60012011-11-21 Chong Yidong <cyd@gnu.org>
6002
6003 * window.c (Fnext_window, Fprevious_window): Doc fix.
6004
b0d15b4f
SM
60052011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6006
6007 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6008
fe7a3057
JB
60092011-11-20 Juanma Barranquero <lekktu@gmail.com>
6010
6011 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6012
d2999b1a
MR
60132011-11-20 Martin Rudalics <rudalics@gmx.at>
6014
6015 * window.c (Fset_window_combination_limit): Rename argument
6016 STATUS to LIMIT.
6017 (Vwindow_combination_limit): Remove "status" from doc-string.
6018
d5ff9cd0
AS
60192011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6020
6021 * m/ibms390.h: Remove.
6022 * m/ibms390x.h: Don't include "ibms390.h".
6023
a5bb9bd3
SM
60242011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6025
6026 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6027 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6028
cd1181db
JB
60292011-11-20 Juanma Barranquero <lekktu@gmail.com>
6030
6031 * casetab.c (Fset_case_table):
6032 * charset.c (Fcharset_after): Fix typos.
6033
615a3b8d 60342011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6035
17e845af
PE
6036 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6037 Otherwise, valgrind does not work on some platforms.
6038 Problem reported by Andreas Schwab in
6a0bf43d
PE
6039 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6040 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6041 is set, removing the need for VIRT_ADDRESS_VARIES.
6042 (PURE_P): Use a more-efficient implementation that needs just one
6043 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6044 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6045 to 4 (xorl, subq, cmpq, setbe).
6046 * alloc.c (pure): Always extern now, since that's the
6047 VIRT_ADDR_VARIES behavior.
6048 (PURE_POINTER_P): Use a single comparison, not two, for
6049 consistency with the new puresize.h.
6050 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6051 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6052 Remove VIRT_ADDR_VARIES no longer needed.
6053
f8fe6f96
EZ
60542011-11-19 Eli Zaretskii <eliz@gnu.org>
6055
6056 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6057 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6058 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6059 behave as if the cursor position were at the window margin.
6060
6061 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6062 and the cursor position is out of bounds, behave as if the cursor
6063 position were at the window margin. (Bug#10075)
6064
df05a53c
CY
60652011-11-18 Chong Yidong <cyd@gnu.org>
6066
6067 * window.c (Fwindow_combination_limit): Make first argument
6068 non-optional, since it is meaningless for live windows like the
6069 selected window.
61ccba97 6070
2071918e
DA
60712011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6072
6073 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6074
b50a28de
SM
60752011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6076
6077 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6078 (graft_intervals_into_buffer): Simplify.
6079
015137db
EZ
60802011-11-18 Eli Zaretskii <eliz@gnu.org>
6081
6082 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6083 hash values of the two rows.
6084 (copy_row_except_pointers): Preserve the used[] arrays and the
6085 hash values of the two rows. (Bug#10035)
68c95424 6086 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6087
6088 * xdisp.c (row_hash): New function, body extracted from
6089 compute_line_metrics.
6090 (compute_line_metrics): Call row_hash, instead of computing the
6091 hash code inline.
6092
6093 * dispnew.c (verify_row_hash): Call row_hash for computing the
6094 hash code of a row, instead of duplicating code from xdisp.c.
6095
6096 * dispextern.h (row_hash): Add prototype.
6097
a2addb04
TH
60982011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6099
6100 * frame.c (delete_frame): Don't delete the terminal when the last
6101 X frame is closed if emacs is built with GTK toolkit.
6102
df85d315
JB
61032011-11-17 Juanma Barranquero <lekktu@gmail.com>
6104
6105 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6106
a0c2d0ae
MR
61072011-11-17 Martin Rudalics <rudalics@gmx.at>
6108
6109 * window.c (Vwindow_splits): Rename to
6110 Vwindow_combination_resize. Suggested by Juri Linkov.
6111 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6112 of Vwindow_splits.
6113
58179cce
JB
61142011-11-16 Juanma Barranquero <lekktu@gmail.com>
6115
7877f373
JB
6116 * nsfns.m (Fns_font_name):
6117 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6118
b6f67890
MR
61192011-11-16 Martin Rudalics <rudalics@gmx.at>
6120
6121 * window.h (window): Rename slot "nest" to "combination_limit".
6122 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6123 (Fset_window_nest): Rename to Fset_window_combination_limit.
6124 (Vwindow_nest): Rename to Vwindow_combination_limit.
6125 (recombine_windows, make_parent_window, make_window)
6126 (Fsplit_window_internal, saved_window)
6127 (Fset_window_configuration, save_window_save): Rename all
6128 occurrences of window_nest to window_combination_limit.
6129
c7015153
JB
61302011-11-15 Juanma Barranquero <lekktu@gmail.com>
6131
6132 * image.c (imagemagick_load_image): Fix typo.
6133
322ad6ec
EZ
61342011-11-14 Eli Zaretskii <eliz@gnu.org>
6135
6136 * xdisp.c (display_line): Move the call to
6137 highlight_trailing_whitespace before the call to
6138 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6139 faces of all the glyphs to compute ROW's hash value.
6140 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6141
f067b8ec
JB
61422011-11-14 Juanma Barranquero <lekktu@gmail.com>
6143
6144 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6145 just return (bug#10044).
6146
1e5b2111
EZ
61472011-11-12 Eli Zaretskii <eliz@gnu.org>
6148
7ef3cbd5
EZ
6149 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6150 with user-defined heap size. Bump the default size of the temacs
6151 heap to 27MB, to avoid memory warning when running temacs.
6152 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6153
1e5b2111
EZ
6154 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6155 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6156 (verify_row_hash) [XASSERTS]: New function.
6157 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6158 that the hash value of glyph rows is correct.
1e5b2111 6159
89d61221
MR
61602011-11-12 Martin Rudalics <rudalics@gmx.at>
6161
6162 * window.h (window): Remove splits slot.
6163 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6164 (Fdelete_other_windows_internal, make_parent_window)
6165 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6166 (Fset_window_configuration, save_window_save): Don't deal with
6167 split status of windows.
6168 (saved_window): Remove splits slot.
6169 (Vwindow_splits): Rewrite doc-string.
6170
97f18cc8
JD
61712011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6172
6173 * xfns.c (unwind_create_frame):
6174 * nsfns.m (unwind_create_frame):
6175 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6176 Vframe_list (Bug#9999).
6177
22a648b4
DA
61782011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6179
0b381c7e 6180 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6181
659afede
KH
61822011-11-11 Kenichi Handa <handa@m17n.org>
6183
6184 * callproc.c (Fcall_process): Set the member dst_multibyte of
6185 process_coding.
6186
9ac0394b
KH
61872011-11-11 Johan Bockgård <bojohan@gnu.org>
6188
6189 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6190 avoid a crash (bug#9496).
6191
2fbdc249
CY
61922011-11-09 Chong Yidong <cyd@gnu.org>
6193
6194 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6195 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6196
ac6b1f81
PE
61972011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6198
6199 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6200
09db192c
PE
62012011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6202
6203 Avoid some portability problems by eschewing 'extern inline' functions.
6204 The trivial performance wins aren't worth the portability hassles; see
6205 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6206 et seq.
6207 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6208 (window_box_width, window_box_left, window_box_left_offset)
6209 (window_box_right, window_box_right_offset): Undo previous change,
6210 by removing the "extern"s.
6211 * intervals.c (adjust_intervals_for_insertion)
6212 (adjust_intervals_for_deletion): Undo previous change,
6213 making these static again.
6214 (offset_intervals, temp_set_point_both, temp_set_point)
6215 (copy_intervals_to_string): No longer inline.
6216 * xdisp.c (window_text_bottom_y, window_box_width)
6217 (window_box_height, window_box_left_offset)
6218 (window_box_right_offset, window_box_left, window_box_right)
6219 (window_box): No longer inline.
6220
105216ed
CY
62212011-11-08 Chong Yidong <cyd@gnu.org>
6222
6223 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6224 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6225 Signal an error if not a live window.
105216ed
CY
6226 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6227 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6228
ae9e237f
JB
62292011-11-07 Juanma Barranquero <lekktu@gmail.com>
6230
6231 * lisp.h (syms_of_abbrev): Remove declaration.
6232 Reported by CHENG Gao <chenggao@royau.me>.
6233
c7aa8333
EZ
62342011-11-07 Eli Zaretskii <eliz@gnu.org>
6235
6236 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6237 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6238 of temacs in GUI mode.
6239
be7f5545
MR
62402011-11-07 Martin Rudalics <rudalics@gmx.at>
6241
6242 * window.h: Declare delete_all_child_windows instead of
6243 delete_all_subwindows.
6244 * window.c (Fwindow_nest, Fset_window_nest)
6245 (Fset_window_new_total, Fset_window_new_normal)
6246 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6247 (delete_all_subwindows): Rename to delete_all_child_windows.
6248 (Fdelete_other_windows_internal, Fset_window_configuration):
6249 Call delete_all_child_windows instead of delete_all_subwindows.
6250 * frame.c (delete_frame): Call delete_all_child_windows instead
6251 of delete_all_subwindows.
6252
ca78dc43
PE
62532011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6254
6255 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6256 This is also needed for porting to any host where GC_MARK_STACK is
6257 not GC_MAKE_GCPROS_NOOPS.
6258 (which_symbols): Use it.
6259
a0241d01
KH
62602011-11-07 Kenichi Handa <handa@m17n.org>
6261
6262 * coding.c (coding_set_destination): Check coding->src_pos only
6263 when coding->src_object is a buffer (bug#9910).
6264
6265 * process.c (send_process): Set the member src_multibyte of coding
6266 to 0 (bug#9911) when sending a unibyte text.
6267
6268 * callproc.c (Fcall_process): Set the member src_multibyte of
6269 process_coding to 0 (bug#9912).
6270
a64bfdfa 62712011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6272
6273 * xmenu.c (cleanup_widget_value_tree): New function.
6274 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6275 calling free_menubar_widget_value_tree directly (Bug#9830).
6276
cb41b32a
PE
62772011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 Fix some portability problems with 'inline'.
6280 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6281 (window_box_width, window_box_left, window_box_left_offset)
6282 (window_box_right, window_box_right_offset): Declare extern.
6283 Otherwise, these inline functions do not conform to C99 and
6284 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6285 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6286 * intervals.c (adjust_intervals_for_insertion)
6287 (adjust_intervals_for_deletion): Now extern, because otherwise the
6288 extern inline functions 'offset_intervals' couldn't refer to it.
6289 (static_offset_intervals): Remove.
6290 (offset_intervals): Rewrite using the old contents of
6291 static_offset_intervals. The old version didn't conform to C99
6292 because an extern inline function contained a reference to an
6293 identifier with static linkage.
6294
b7041366
AS
62952011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6296
6297 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6298 GC.
6299
88a37c4d
EZ
63002011-11-06 Eli Zaretskii <eliz@gnu.org>
6301
6302 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6303 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6304 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6305 return Qleft_to_right.
6306
49745b39
CY
63072011-11-06 Chong Yidong <cyd@gnu.org>
6308
6309 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6310 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6311 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6312 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6313 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6314 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6315 (Fwindow_vscroll): Doc fix.
6316 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6317 argument, since it makes no sense to pass a live window and for
6318 consistency with window-child.
6319
1f05cd82
CS
63202011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6321
6322 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6323 support MSVC.
6324
22610910
JR
63252011-11-05 Jason Rumney <jasonr@gnu.org>
6326
6327 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6328 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6329 fonts (Bug#6029).
6330 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6331 bitwise arithmetic preventing use of unicode-sip and non-truetype
6332 opentype fonts.
6333
a06776b2
EZ
63342011-11-05 Eli Zaretskii <eliz@gnu.org>
6335
3ad924ba
EZ
6336 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6337 "emacs"-only part.
6338
a06776b2
EZ
6339 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6340 initialization code to keep similarity to xfns.c after changes
6341 from 2011-11-05.
6342
c9e7db78
JD
63432011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6344
a97f8f3f
JD
6345 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6346 (unwind_create_frame): New function (Bug#9943).
6347 (Fx_create_frame): Restructure code to be more similar to the one in
6348 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6349 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6350 Move terminal->reference_count++ just before making the frame official
6351 (Bug#9943).
6352
6353 * nsterm.m (x_free_frame_resources): New function.
6354 (x_destroy_window): Move code to x_free_frame_resources.
6355
c9e7db78 6356 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6357 (Fx_create_frame, x_create_tip_frame):
6358 Move terminal->reference_count++ just before making the frame
75f1671a 6359 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6360 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6361
a6fc3b5c
EZ
63622011-11-05 Eli Zaretskii <eliz@gnu.org>
6363
6364 Support MSVC build with newer versions of Visual Studio.
6365 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6366 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6367 nt/gmake.defs.
6368
6369 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6370 which are not supported by MSVC.
6371 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6372 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6373 bitfields.
6374 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6375 types in bitfields.
6376 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6377
6378 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6379
58179cce 63802011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6381
6382 Support MSVC build with newer versions of Visual Studio.
6383 * w32.c: Don't include w32api.h for MSVC.
6384 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6385
6386 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6387 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6388 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6389 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6390 e_* cousins.
6391 (alloca) [_MSC_VER]: Define to _alloca.
6392
6393 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6394
6395 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6396
a58c13ed
EZ
63972011-11-04 Eli Zaretskii <eliz@gnu.org>
6398
6399 * xdisp.c (note_mouse_highlight): If either of
6400 previous/next-single-property-change returns nil, treat that as
6401 the beginning or the end of the buffer. (Bug#9955)
6402
fe0b6370
JD
64032011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6404
a58c13ed 6405 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6406 label is not null (Bug#9951).
6407 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6408 may be NULL.
6409
89bd5ee1
EZ
64102011-11-04 Eli Zaretskii <eliz@gnu.org>
6411
6412 * window.c (Fwindow_body_size): Mention in the doc string that the
6413 return value is in frame's canonical units. (Bug#9949)
6414
84c3edb9
EZ
64152011-11-03 Eli Zaretskii <eliz@gnu.org>
6416
4e2fb5c7
EZ
6417 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6418
84c3edb9 6419 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6420 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6421 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6422
bc17a887
EZ
64232011-11-01 Eli Zaretskii <eliz@gnu.org>
6424
6425 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6426 Don't stop backward scan on the continuation glyph, even though
6427 its CHARPOS is positive.
6d5eb5b0
SM
6428 (mouse_face_from_buffer_pos, note_mouse_highlight):
6429 Rename cover_string to disp_string.
bc17a887 6430
4ee88440
MR
64312011-11-01 Martin Rudalics <rudalics@gmx.at>
6432
6433 * window.c (temp_output_buffer_show): Don't use
6434 Vtemp_buffer_show_specifiers.
6435 (Vtemp_buffer_show_specifiers): Remove unused variable.
6436
c2ff3c02
EZ
64372011-10-30 Eli Zaretskii <eliz@gnu.org>
6438
6439 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6440 past the beginning of the current glyph matrix.
6441
58179cce 64422011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6443
6444 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6445 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6446 HAVE_GTK3 (Bug#9869).
b77a6a7f 6447
3b574623
JD
6448 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6449 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6450
b77a6a7f
JD
6451 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6452
6453 * xterm.c: Declare x_handle_net_wm_state to return int.
6454 (handle_one_xevent): Check if we are iconified but don't have
6455 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6456 (get_current_wm_state): Return non-zero if not hidden,
6457 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6458 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6459 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6460 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6461
196e41e4
PE
64622011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6463
6464 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6465 so that this new function doesn't get optimized away by a
6466 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6467
021f2e1a
AS
64682011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6469
6470 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6471
8b058d44
EZ
64722011-10-29 Eli Zaretskii <eliz@gnu.org>
6473
6474 Fix the `xbytecode' command.
6475 * .gdbinit (xprintbytestr): New command.
b50a28de 6476 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6477 (xbytecode): Print the byte-code string as well.
6478
4452fb80
EZ
64792011-10-29 Kim Storm <storm@cua.dk>
6480
8b058d44
EZ
6481 * alloc.c (which_symbols): New function.
6482
21b72067
AS
64832011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6484
6485 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6486 line. (Bug#9903)
6487
83ed7b5c
GM
64882011-10-29 Glenn Morris <rgm@gnu.org>
6489
6490 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6491 Not clear what it was for, and it causes various bugs. (Bug#9839)
6492
5a7a728b
EZ
64932011-10-28 Eli Zaretskii <eliz@gnu.org>
6494
6495 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6496 possible random value that matches one of those tested as
6497 condition to clear the mouse face.
6498
d3d0842f
CY
64992011-10-28 Chong Yidong <cyd@gnu.org>
6500
6501 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6502
31b39d13
DN
65032011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6504
6505 * window.c (make_window): Initialize phys_cursor_on_p.
6506
9aba6043
SM
65072011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6508
6509 * lisp.h (struct Lisp_Symbol): Update comments.
6510
c20992f4
JB
65112011-10-28 Juanma Barranquero <lekktu@gmail.com>
6512
6513 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6514
db4f02f2
EZ
65152011-10-28 Eli Zaretskii <eliz@gnu.org>
6516
6517 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6518 <oslsachem@gmail.com> for helping to debug this.
6519
6520 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6521 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6522 (g_b_init_get_glyph_outline_w): New static variables.
6523 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6524 (GetGlyphOutlineW_Proc): New typedefs.
6525 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6526 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6527 New functions.
6528 (w32font_open_internal, compute_metrics):
6529 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6530 instead of calling the "wide" APIs directly.
6531
6532 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6533
6534 * w32.h (syms_of_w32font): Add prototype.
6535
87e68db4
JB
65362011-10-27 Juanma Barranquero <lekktu@gmail.com>
6537
6538 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6539 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6540 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6541 (Fmove_to_window_line): Doc fix.
6542
435c1d67
CY
65432011-10-27 Chong Yidong <cyd@gnu.org>
6544
6545 * process.c (make_process): Set gnutls_state to NULL.
6546
6547 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6548 non-NULL, regardless of GNUTLS_INITSTAGE.
6549 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6550 an error. Set process slots as soon as we allocate them.
6551
6552 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6553
9c6c6f49
CY
65542011-10-27 Chong Yidong <cyd@gnu.org>
6555
9aba6043
SM
6556 * gnutls.c (emacs_gnutls_deinit): New function.
6557 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6558 (Fgnutls_deinit, Fgnutls_boot): Use it.
6559
6560 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6561 (deactivate_process): Call emacs_gnutls_deinit.
6562
657d08d3
JB
65632011-10-27 Juanma Barranquero <lekktu@gmail.com>
6564
6565 * image.c (x_create_x_image_and_pixmap):
6566 * w32.c (sys_rename, w32_delayed_load):
6567 * w32font.c (fill_in_logfont):
6568 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6569
5430d399
JB
65702011-10-26 Juanma Barranquero <lekktu@gmail.com>
6571
6572 * w32fns.c (w32_default_color_map): New function,
6573 extracted from Fw32_default_color_map.
a7ef684b 6574 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6575
fe0055fa
PE
65762011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6577
6578 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6579
e6346438
SM
65802011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6581
6582 * keyboard.c (test_undefined): New function (bug#9751).
6583 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6584
e112cc37
ET
65852011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6586
6587 * sysdep.c (init_sys_modes): Fix the check for the controlling
6588 terminal (Bug#6649).
6589
7b5d6677
EZ
65902011-10-20 Eli Zaretskii <eliz@gnu.org>
6591
6592 * dispextern.h (struct bidi_it): New member next_en_type.
6593
6594 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6595 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6596 current character, check also for next_en_type being WEAK_EN.
6597 (bidi_resolve_weak): Don't enter the expensive loop if the current
6598 position is before next_en_pos. Record the bidi type of the first
6599 non-ET, non-BN character we find, in addition to its position.
6600 (bidi_level_of_next_char): Invalidate next_en_type when
6601 next_en_pos is over-stepped.
6602
7da0b018
PE
66032011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6604
6605 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6606 * editfns.c: Rewrite current-time-zone so that it invokes
6607 the equivalent of (format-time-string "%Z") to get the time zone name.
6608 This fixes a bug when the time zone name contains characters that
6609 need converting from the system time locale to Emacs internal format.
6610 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6611 that patch fixed format-time-string to do the conversion, but
6612 I forgot to fix current-time-zone.
6613 (format_time_string): New function, containing most of
6614 what Fformat_time_string used to contain.
6615 (Fformat_time_string): Rewrite in terms of format_time_string.
6616 This doesn't change this function's behavior.
6617 (current-time-zone): Rewrite to use format_time_string.
6618 This fixes the bug reported by Michael Schierl in
6619 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6620 Jason Rumney's 2007-06-07 change worked around this bug, but
6621 didn't fix it.
6622 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6623
8547b010
EZ
66242011-10-19 Eli Zaretskii <eliz@gnu.org>
6625
6626 * xdisp.c (start_display): If the character at POS is displayed
6627 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6628 (try_window_reusing_current_matrix): If a line ends in a display
6629 vector or the next line starts in a display vector, continue
6630 redrawing the window even though the character position of
6631 start_row was reached.
8547b010
EZ
6632 (Bug#9771, part 2)
6633
4e948d15
CY
66342011-10-18 Chong Yidong <cyd@gnu.org>
6635
6636 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6637 with nobreak-char-display too.
6638
4787455f
EZ
66392011-10-18 Eli Zaretskii <eliz@gnu.org>
6640
6641 Fix part 3 of bug#9771.
6642 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6643 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6644 non-neutral characters if the current character is a paragraph
6645 separator (a.k.a. Newline). This avoids running the same
6646 expensive loop twice, once when we consume the preceding newline
6647 and the other time when the line actually needs to be displayed.
6648 Avoid the loop when we see neutrals on the base embedding level
6649 following a character whose directionality is the same as the
6650 paragraph's. This avoids running the expensive loop when a line
6651 ends in a long sequence of neutrals, like control characters.
6652 Add assertion against STRONG_AL type. Slightly rearrange code
6653 that determines the type of a neutral given the first non-neutral
6654 that follows it.
6655 (bidi_level_of_next_char): Set next_en_pos to zero when
6656 invalidating its info.
6657
2c91f553
EZ
66582011-10-17 Eli Zaretskii <eliz@gnu.org>
6659
6660 * xdisp.c (push_display_prop): Determine whether to record string
6661 or buffer position by IT->string, not by IT->method. Allow
6662 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6663 (move_it_vertically_backward): Don't look for character position
6664 immediately after the newline when in a continuation line.
6665 (Bug#9771, part 1)
2c91f553 6666
c7b08b0d
MR
66672011-10-15 Martin Rudalics <rudalics@gmx.at>
6668
6669 * window.c (coordinates_in_window): Rewrite and delabelize
6670 vertical border check. (Bug#5357) (Bug#9618)
6671
6b02f655
SM
66722011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6673
6674 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6675 errors in XSetWindowBorder (bug#9310).
6676
81d40c92
DA
66772011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6678
6679 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6680 avoid crash when xmalloc overrun checking is enabled.
6681
d4172c3b
EZ
66822011-10-13 Eli Zaretskii <eliz@gnu.org>
6683
6684 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6685 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6686 cursor motion with <left> and <right> arrow keys.
6687
6688 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6689 some callers set that themselves.
6690
b00eea75
EZ
66912011-10-12 Eli Zaretskii <eliz@gnu.org>
6692
6693 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6694 display string and the previous row comes from the same string and
6695 is empty. (Bug#9739) (Bug#9738)
6696
8fe012c4
SM
66972011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6698
6699 * doc.c (get_doc_string): Encode file name (bug#9735).
6700
0074aef2
EZ
67012011-10-12 Eli Zaretskii <eliz@gnu.org>
6702
79beb178
EZ
6703 * bidi.c (bidi_level_of_next_char):
6704 * xdisp.c (get_visually_first_element): Remove old incorrect
6705 comments regarding the Unicode Line Separator character.
6706
0074aef2
EZ
6707 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6708
6e4b3fbe
DA
67092011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6710
6711 * alloc.c (Fgc_status): Do not access beyond zombies array
6712 boundary if nzombies > MAX_ZOMBIES.
6713 * alloc.c (dump_zombies): Add missing format specifier.
6714
0324f3af
PE
67152011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6716
b5525cac
PE
6717 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6718 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6719
0324f3af
PE
6720 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6721 Some packages use them to denote characters with modifiers.
6722
e9b5f888
AS
67232011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6724
6725 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6726 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6727 matching a pp-number. Rename parameter var to var1.
6728
127827c0
SM
67292011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6730
6731 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6732
c8fd3bd0
GM
67332011-10-08 Glenn Morris <rgm@gnu.org>
6734
6735 * callint.c (Fcall_interactively): Give a more explicit error for the
6736 'c' case with a non-character input. (Bug#8479)
6737
352ec8ff
EZ
67382011-10-08 Eli Zaretskii <eliz@gnu.org>
6739
03669ccb
EZ
6740 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6741 lines.
7061c986
EZ
6742 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6743 lines that are hscrolled on the left.
03669ccb 6744
352ec8ff
EZ
6745 * dispnew.c (buffer_posn_from_coords): Account for a possible
6746 presence of header-line. (Bug#4426)
6747
a66cfb1c
SM
67482011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6749
6b02f655
SM
6750 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6751 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6752
7c5ee88e
PE
67532011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6754
6755 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6756 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6757 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6758 this makes Emacs dump core during garbage collection on rare
6759 occasions. sizeof is obviously inferior to offsetof here, so
6760 stick with offsetof.
6761 (GC_POINTER_ALIGNMENT): New macro.
6762 (mark_memory): Omit 3rd (offset) arg; caller changed.
6763 Don't assume EMACS_INT alignment is the same as pointer alignment.
6764
df1bbe5b
SM
67652011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6766
6767 * keyboard.c (read_key_sequence_remapped): New var.
6768 (read_key_sequence): Compute remapping in the right buffer.
6769 (command_loop_1): Use read_key_sequence's remapping directly.
6770
51553db6
SM
67712011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6772
32c1fffd
SM
6773 * dired.c (file_name_completion): Don't expand file name.
6774 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6775 before checking file name handler.
6776
51553db6
SM
6777 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6778 they've been requested explicitly (bug#9591).
6779
b6bd1599 67802011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6781
6782 * keymap.c (Fsingle_key_description): Use make_specified_string
6783 instead of build_string to build string from push_key_description.
6784 (Bug#5193)
6785
f701dc2a
PE
67862011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6787
4222c55d
PE
6788 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6789 This fixes a Y2038 bug on 64-bit hosts.
6790 * buffer.c (reset_buffer):
6791 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6792 (Fclear_buffer_auto_save_failure):
6793 Use 0, not -1, to represent an unset failure time, since time_t
6794 might not be signed.
6795
f701dc2a
PE
6796 Remove dependency on glibc malloc internals.
6797 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6798 Move back here from lisp.h, but with their new implementations.
6799 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6800 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6801 * charset.c (charset_table_init): New static var.
6802 (syms_of_charset): Use it instead of xmalloc. This removes a
6803 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6804 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6805 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6806 Move back to alloc.c.
6807 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6808 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6809
9ceebf39
JD
68102011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6811
6812 * nsterm.m (windowDidResize): Call x_set_window_size only when
6813 ns_in_resize is true. Otherwise set pixelwidth/height and
6814 call change_frame_size (Bug#9628).
6815
cb993c58
PE
68162011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6817
3930c88b
PE
6818 Port --enable-checking=all to Fedora 14 x86-64.
6819 * charset.c (syms_of_charset): Also account for glibc malloc's
6820 internal overhead when calculating the initial malloc maximum.
6821
cb993c58
PE
6822 Port --enable-checking=all to Fedora 14 x86.
6823 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6824 Move to lisp.h.
6825 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6826 (overrun_check_realloc, overrun_check_free):
6827 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6828 That way, xmalloc returns a properly-aligned pointer even if
6829 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6830 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6831 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6832 into account when calculating the initial malloc maximum.
6833 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6834 Move here from alloc.c, so that charset.c can use it too.
6835 Properly align; the old code wasn't right for common 32-bit hosts
6836 when configured with --enable-checking=all.
6837 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6838 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6839
31bed486
EZ
68402011-09-29 Eli Zaretskii <eliz@gnu.org>
6841
04c70788 6842 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6843 use EDOM.
6844
fbcaa2f3
EZ
68452011-09-28 Eli Zaretskii <eliz@gnu.org>
6846
6847 * xdisp.c (compute_display_string_end): If there's no display
6848 string at CHARPOS, return -1.
6849
6850 * bidi.c (bidi_fetch_char): When compute_display_string_end
6851 returns a negative value, treat the character as a normal
6852 character not covered by a display string. (Bug#9624)
6853
a239d4e9
JB
68542011-09-28 Juanma Barranquero <lekktu@gmail.com>
6855
6856 * lread.c (Fread_from_string): Fix typo in docstring.
6857
88652fd5
EZ
68582011-09-27 Eli Zaretskii <eliz@gnu.org>
6859
6860 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6861 newline, reseat the iterator instead of bidi-iterating there one
6862 character at a time. (Bug#9610)
32c1fffd
SM
6863 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6864 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6865
ed497dd4
AS
68662011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6867
6868 * lread.c (readevalloop): Use correct code for NBSP.
6869 (read1): Likewise. (Bug#9608)
6870
b2bf61aa
MA
68712011-09-25 Michael Albinus <michael.albinus@gmx.de>
6872
6873 * dbusbind.c (Fdbus_register_signal): When service is not
6874 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6875
32bbb17c
GM
68762011-09-25 Glenn Morris <rgm@gnu.org>
6877
6878 * buffer.c (truncate-lines): Doc fix.
6879
94e0933e
CY
68802011-09-24 Chong Yidong <cyd@stupidchicken.com>
6881
6882 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6883 (Fset_window_next_buffers): Doc fix.
6884
cddde921
GM
68852011-09-24 Glenn Morris <rgm@gnu.org>
6886
6887 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6888
1260aef1
PE
68892011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6890
25b4bfa0
PE
6891 Fix minor problems found by static checking.
6892 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6893 * indent.c (Fvertical_motion): Fix == vs = typo.
6894
e3cbd34b
EZ
68952011-09-24 Eli Zaretskii <eliz@gnu.org>
6896
a66cfb1c
SM
6897 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6898 Default value is now t. Doc fix.
6bf7006f 6899
e3cbd34b 6900 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6901 logic when moving up, not only when moving down. Fix the
e3cbd34b 6902 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6903 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6904
6905 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6906 CHARPOS is covered by a display string which includes newlines.
6907 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6908 is covered by a display string with embedded newlines.
6909
a3de0cbd
MA
69102011-09-24 Michael Albinus <michael.albinus@gmx.de>
6911
6912 * dbusbind.c (Fdbus_register_signal): Add match rule to
6913 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6914 (Fdbus_register_method, Vdbus_registered_objects_table):
6915 Fix docstring.
a3de0cbd 6916
b260039d
JM
69172011-09-24 Jim Meyering <meyering@redhat.com>
6918
32c1fffd 6919 do not ignore write error for any output size
b260039d
JM
6920 The previous change was incomplete.
6921 While it makes emacs --batch detect the vast majority of stdout
6922 write failures, errors were still ignored whenever the output size is
6923 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6924 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6925 && echo FAIL: ignored write error
6926 FAIL: ignored write error
6927 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6928 && echo FAIL: ignored write error
6929 FAIL: ignored write error
6930 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6931
8eca8a7c
AS
69322011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6933
6934 * emacs.c (Fkill_emacs): In noninteractive mode exit
6935 non-successfully if a write error occurred on stdout. (Bug#9574)
6936
3341db62
EZ
69372011-09-21 Eli Zaretskii <eliz@gnu.org>
6938
6939 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6940 the xassert test.
6941
6942 * dispextern.h (struct it): Update the comment documenting what
6943 can it->OBJECT be.
6944
8c203dbf
EZ
69452011-09-20 Eli Zaretskii <eliz@gnu.org>
6946
6947 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6948 a display string, extend search for cursor position to end of row.
6949 (find_row_edges): If the row ends in a newline from a display
6950 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6951 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6952 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6953 non-empty line. Fixes confusing cursor motion with arrow keys at
6954 the beginning of a line that starts with whitespace.
8c203dbf 6955
a4824228
LMI
69562011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6957
6958 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6959 (bug#9493).
6960
33ed493b
CY
69612011-09-18 Chong Yidong <cyd@stupidchicken.com>
6962
6963 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6964 boolean (Bug#9154).
6965
56cd55c8
EZ
69662011-09-18 Eli Zaretskii <eliz@gnu.org>
6967
6968 * xdisp.c (display_line): Record maximum and minimum buffer
6969 positions even if no glyphs were produced (e.g., by a zero-width
6970 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6971 buffer positions that will be removed from the glyph row because
6972 they don't fit.
c02dcedf
EZ
6973 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6974 column is beyond frame width: don't subtract 1 "pixel" when
6975 computing width of the stretch.
3e62b7e0
EZ
6976 (reseat_at_next_visible_line_start): Undo the change made on
6977 2011-09-17 that saved paragraph information and restored it after
6978 the call to `reseat'. (Bug#9545)
56cd55c8 6979
5ed99d36 69802011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6981
6982 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6983 and turn window cursor on if cleared (Bug#9415).
6984
5ed99d36 69852011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6986
6987 * search.c (boyer_moore): Take unibyte characters from pattern
6988 literally. (Bug#9458)
6989
9bade7b2
EZ
69902011-09-18 Eli Zaretskii <eliz@gnu.org>
6991
6992 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6993
e5e9d610
PE
69942011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6995
87e4427a
PE
6996 Fix minor problem found by static checking.
6997 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6998 initialized, to pacify gcc -Wuninitialized.
6999
e5e9d610
PE
7000 * fileio.c: Report proper errno when syscall falls.
7001 (Finsert_file_contents): Save and restore errno,
7002 so that report_file_error outputs the correct diagnostic.
7003 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7004
a1674f0b
EZ
70052011-09-18 Eli Zaretskii <eliz@gnu.org>
7006
7007 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7008
fbfb6dd4
EZ
70092011-09-17 Eli Zaretskii <eliz@gnu.org>
7010
7011 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7012 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7013
bb187662
EZ
70142011-09-17 Eli Zaretskii <eliz@gnu.org>
7015
1137e8b8 7016 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7017 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7018
7019 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7020 (bidi_find_paragraph_start): Search back for paragraph beginning
7021 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7022 (bidi_move_to_visually_next): Only trigger paragraph-related
7023 computations when the last character is a newline or at EOB, not
7024 just any NEUTRAL_B. (Bug#9470)
7025
bb187662
EZ
7026 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7027 truncated lines if point is covered by a display string. (Bug#9524)
7028
2e621251
PE
70292011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7030
7031 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7032 (cons_to_x_long): New function.
7033 (lisp_data_to_selection_data): Use it. Correct the test for
7034 short-versus-long data; it was negated. Break out of vector
7035 loop, for efficiency, when a long datum is discovered.
7036
91a15bc6
SM
70372011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7038
7039 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7040
b41c3a35
EZ
70412011-09-16 Eli Zaretskii <eliz@gnu.org>
7042
7043 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7044 GCC PR/17406) by declaring this function with external scope.
7045
7812ba2d
PE
70462011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7049 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7050
cf7edc2a
AS
70512011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7052
7053 * editfns.c (Fformat): Correctly handle text properties on "%%".
7054
bd01620e
EZ
70552011-09-15 Eli Zaretskii <eliz@gnu.org>
7056
7057 * xterm.c (x_draw_composite_glyph_string_foreground):
7058 * w32term.c (x_draw_composite_glyph_string_foreground):
7059 * term.c (encode_terminal_code):
7060 * composite.c (composition_update_it, get_composition_id):
7061 * xdisp.c (get_next_display_element)
7062 (fill_composite_glyph_string): Add comments about special meaning
7063 of TAB characters in a composition.
7064
a02719a3
PE
70652011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7066
7067 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7068 This occurs when processing a multibyte format.
7069 Problem reported by Wolfgang Jenker.
a02719a3 7070
72589a3c
JB
70712011-09-15 Johan Bockgård <bojohan@gnu.org>
7072
7073 * xdisp.c (try_cursor_movement): Only check for exact match if
7074 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7075
1c14176c
PE
70762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7077
7078 Remove unused external symbols.
7079 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7080 * xdisp.c (calc_pixel_width_or_height): Now static.
7081 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7082 * indent.c (check_display_width):
7083 * w32term.c: Fix comment to match code.
7084 * xterm.c, xterm.h (x_catching_errors): Remove.
7085
d2eea5b5
PE
70862011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7087
7088 * xselect.c: Use signed conversions more consistently (Bug#9498).
7089 (selection_data_to_lisp_data): Assume incoming selection data are
7090 signed integers, not unsigned. This is to be consistent with
7091 outgoing selection data, which was modified to use signed integers
7092 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7093 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7094 expects long, not unsigned long.
7095
46888499
EZ
70962011-09-14 Eli Zaretskii <eliz@gnu.org>
7097
7098 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7099 computation of loop end. Reported by Johan Bockgård
7100 <bojohan@gnu.org>.
7101
ef8ef9fb
CY
71022011-09-13 Chong Yidong <cyd@stupidchicken.com>
7103
7104 * frame.c (Fother_visible_frames_p): Function deleted.
7105
fa819fed
EZ
71062011-09-12 Eli Zaretskii <eliz@gnu.org>
7107
7108 * indent.c (compute_motion): Process display vector front to back
7109 rather than the other way around. (Bug#2496)
7110
2ba8e008
SM
71112011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7112
7113 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7114
20f53c69
CY
71152011-09-11 Chong Yidong <cyd@stupidchicken.com>
7116
7117 * minibuf.c (Fread_from_minibuffer): Doc fix.
7118
d562d7a4
EZ
71192011-09-11 Eli Zaretskii <eliz@gnu.org>
7120
7121 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7122 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7123
1c4d7f3d
LMI
71242011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7125
7126 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7127 value for non-existent files.
7128
b885bf36
EZ
71292011-09-11 Eli Zaretskii <eliz@gnu.org>
7130
7131 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7132 set its "size" to -1. This will set the modtime_size field of
7133 the corresponding buffer to -1, which is what
7134 verify-visited-file-modtime expects for files that do not exist.
7135 (Bug#9139)
7136
6612f0bf
PE
71372011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7138
7139 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7140 here ...
7141 * lisp.h: ... from here. push_key_description is no longer
7142 defined in keyboard.c, so its declaration should not be in
7143 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7144 logically belongs with push_key_description.
7145
dfb3f755
PE
71462011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7147
7148 * buffer.h: Include <sys/types.h> instead of <time.h>.
7149 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7150 Problem reported by Herbert J. Skuhra.
7151
3134906c
LMI
71522011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7153
7154 * xml.c (parse_region): Make the parsing work for
7155 non-comment-starting XML files again (bug#9144).
7156
8d903f4e
AS
71572011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7158
7159 * image.c (gif_load): Fix calculation of bottom and right corner.
7160 (Bug#9468)
7161
80ad64f4
EZ
71622011-09-10 Eli Zaretskii <eliz@gnu.org>
7163
7164 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7165 redisplay in small windows.
7166
208a048d
EZ
71672011-09-09 Eli Zaretskii <eliz@gnu.org>
7168
7169 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7170
9b1c252e
MR
71712011-09-08 Martin Rudalics <rudalics@gmx.at>
7172
7173 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7174 Operate on live windows only.
7175
2949f33b
JB
71762011-09-08 Juanma Barranquero <lekktu@gmail.com>
7177
7178 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7179
e08dcafd
EZ
71802011-09-07 Eli Zaretskii <eliz@gnu.org>
7181
7182 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7183 only under bidi iteration.
7184
115b96bd
JD
71852011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7186
7187 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7188
c8199d0f
PE
71892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7190
7191 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7192 Without this fix, the command to link temacs failed due to an
7193 undefined symbol __builtin_isnan. This is because
7194 /usr/include/iso/math_c99.h #defines isnan(x) to
7195 __builtin_isnan(x), but the bundled gcc, which identifies itself
7196 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7197 a __builtin_isnan.
7198 * floatfns.c (isnan): #undef, and then #define to a clone of
7199 what's in data.c.
7200 (Fisnan): Always define, since it's always available now.
7201 (syms_of_floatfns): Always define isnan at the Lisp level.
7202
e39b275c 72032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7204
7205 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7206
b2db44d9 72072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7208
f4af5137 7209 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7210 The previous code assumed that file offsets (off_t values) fit in
7211 EMACS_INT variables, which is not true on typical 32-bit hosts.
7212 The code messed up by falsely reporting buffer overflow in cases
7213 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7214 when "big" contains more than 2**29 bytes, even though this
7215 inserts just one byte and does not overflow the buffer.
7216 (Finsert_file_contents): Store file offsets as off_t
7217 values, not as EMACS_INT values. Check for overflow when
7218 converting between EMACS_INT and off_t. When checking for
7219 buffer overflow or for overlap, take the offsets into account.
7220 Don't use EMACS_INT for small values where int suffices.
7221 When checking for overlap, fix a typo: ZV was used where
7222 ZV_BYTE was intended.
7223 (Fwrite_region): Don't assume off_t fits into 'long'.
7224 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7225
ecfc0a49
MA
72262011-09-05 Michael Albinus <michael.albinus@gmx.de>
7227
7228 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7229
6511acf2 72302011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7231
0999621a 7232 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7233
7234 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7235 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7236 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7237 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7238 (modify_event_symbol): Do not assume that the length of
7239 name_alist_or_stem is safe to alloca and fits in int.
7240 (Fexecute_extended_command): Likewise for function name and binding.
7241 (Frecursion_depth): Wrap around reliably on integer overflow.
7242 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7243 since some callers pass EMACS_INT values.
7244 (Fsingle_key_description): Don't crash if symbol name contains more
7245 than MAX_ALLOCA bytes.
7246 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7247 (get_minibuffer): Arg is now EMACS_INT, not int.
7248 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7249 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7250 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7251
2be7d702
PE
7252 * dbusbind.c (signature_cat): New function.
7253 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7254 Do not overrun buffer; instead, report string overflow.
7255
9d1df220
PE
7256 * dispnew.c (add_window_display_history): Don't overrun buffer.
7257 Truncate instead; this is OK since it's just a log.
7258
33ef5c64
PE
7259 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7260 even if the time zone offset is outlandishly large.
7261 Don't mishandle offset == INT_MIN.
7262
66c6fdd5
PE
7263 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7264 when creating daemon; the previous buffer-overflow check was incorrect.
7265
d749b01b
PE
7266 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7267 which has the guts of the old verror function.
7268
b5cd1905
PE
7269 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7270 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7271
6e1a67fb
PE
7272 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7273 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7274 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7275 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7276 length of string rather than counting it via multiple sprintfs;
7277 that's simpler and more reliable.
c21721cc
PE
7278 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7279 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7280 sprintf, in case result does not fit in int.
7281
c57b67fc
PE
7282 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7283 (fontset_from_font): Print it.
7284
8a401434
PE
7285 * frame.c (tty_frame_count): Now printmax_t, not int.
7286 (make_terminal_frame, set_term_frame_name): Print it.
7287 (x_report_frame_params): In X, window IDs are unsigned long,
7288 not signed long, so print them as unsigned.
7289 (validate_x_resource_name): Check for implausibly long names,
7290 and don't assume name length fits in 'int'.
7291 (x_get_resource_string): Don't blindly alloca invocation name;
7292 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7293 not fit in int.
7294
6e1a67fb
PE
7295 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7296 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7297 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7298
0df02bf3
PE
7299 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7300 Use esprintf, not sprintf, in case result does not fit in int.
7301
48e30793
PE
7302 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7303 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7304 it as a large positive number.
7305 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7306 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7307
a66ff6d8
PE
7308 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7309 in case result does not fit in int.
7310
aca216ff
PE
7311 * print.c (float_to_string): Detect width overflow more reliably.
7312 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7313 buffer overrun. Don't assume list length fits in 'int'. Treat
7314 print length of 0 as 0, not as infinity; to be consistent with other
7315 uses of print length in this function. Don't overflow print length
7316 index. Don't assume hash table size fits in 'long', or that
7317 vectorlike size fits in 'unsigned long'.
7318
31c286f7
PE
7319 * process.c (make_process): Use printmax_t, not int, to format
7320 process-name gensyms.
7321
55e5faa1
PE
7322 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7323
80f2e268
PE
7324 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7325 to avoid potential buffer overrun.
7326
670741ab
PE
7327 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7328 if X resource line is longer than 512 bytes.
7329
b7163a50
PE
7330 * xfns.c (x_window): Make sprintf buffer a bit bigger
7331 to avoid potential buffer overrun.
7332
ae58ff1f
PE
7333 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7334
c43c8a6a
PE
7335 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7336
3f8236f4
PE
73372011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7338
53e9fe90 7339 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7340 Without these, Emacs silently mishandles large integers sometimes.
7341 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7342 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7343
6511acf2
PE
7344 * xdisp.c (try_window_id): Check Emacs fixnum range before
7345 converting to 'int'.
806add1d 7346
6511acf2 7347 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7348 Check that an Emacs fixnum is in range before assigning it to 'int'.
7349 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7350 values converted from Emacs fixnums.
7351 (Frecenter): Don't wrap around a line count if it is out of 'int'
7352 range; instead, treat it as an extreme value.
7353 (Fset_window_configuration, compare_window_configurations):
7354 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7355
6511acf2
PE
7356 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7357 that can exceed INT_MAX. Check that EMACS_INT value is in range
7358 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7359 (match_limit): Don't assume that a fixnum can fit in 'int'.
7360
6511acf2 7361 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7362 exceed INT_MAX.
7363
6511acf2 7364 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7365 (Fvertical_motion): Don't wrap around LINES values that don't fit
7366 in 'int'. Instead, treat them as extreme values. This is good
7367 enough for windows, which can't have more than INT_MAX lines anyway.
7368
fcb901a7
LMI
73692011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7370
0f2f6b6d
LMI
7371 * Require libxml/parser.h to avoid compilation warning.
7372
fcb901a7
LMI
7373 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7374
7375 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7376 since this reportedly can destroy thread storage.
7377
6e20a0d4
CY
73782011-08-30 Chong Yidong <cyd@stupidchicken.com>
7379
7380 * syntax.c (find_defun_start): Update all cache variables if
7381 exiting early (Bug#9401).
7382
148ae00e
EZ
73832011-08-30 Eli Zaretskii <eliz@gnu.org>
7384
f6cfbd8f
EZ
7385 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7386
148ae00e
EZ
7387 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7388 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7389 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7390
7391 * term.c (tty_append_glyph): New function.
7392 (produce_stretch_glyph): Static function and its prototype deleted.
7393
a66cfb1c
SM
7394 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7395 Add prototypes.
148ae00e 7396
c4a07a4c
PE
73972011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7398
7399 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7400 when checking :margin (Bug#9390).
7401 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7402 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7403 so that the name doesn't mislead. All uses changed.
7404
6bc8cd65
JB
74052011-08-28 Johan Bockgård <bojohan@gnu.org>
7406
7407 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7408 set_tty_hooks.
7409
dca4927e
EZ
74102011-08-27 Eli Zaretskii <eliz@gnu.org>
7411
7412 * xdisp.c (move_it_to): Don't bail out early when reaching
7413 position beyond to_charpos, if we are scanning backwards.
7414 (move_it_vertically_backward): When DY == 0, make sure we get to
7415 the first character in the line after the newline.
7416
f2cad773
PE
74172011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7418
7419 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7420 (ccl_driver): Do not generate an out-of-range pointer.
7421 (Fccl_execute_on_string): Remove unnecessary check for
7422 integer overflow, noted by Stefan Monnier in
7423 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7424 Remove a FIXME that didn't need fixing.
7425 Simplify the newly-introduced buffer reallocation code.
7426
0cae2cdb
JB
74272011-08-27 Juanma Barranquero <lekktu@gmail.com>
7428
7429 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7430
5fc295a4 74312011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7432
70c60eb2 7433 Integer and memory overflow issues (Bug#9196).
726e0ab1 7434
d31850da
PE
7435 * doc.c (get_doc_string): Rework so that
7436 get_doc_string_buffer_size is the actual buffer size, rather than
7437 being 1 less than the actual buffer size; this makes xpalloc more
7438 convenient.
7439
a69fbedb
PE
7440 * image.c (x_allocate_bitmap_record, cache_image):
7441 * xselect.c (Fx_register_dnd_atom):
7442 Simplify previous changes by using xpalloc.
7443
fe5c5d37
PE
7444 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7445 since either will do and ptrdiff_t is convenient with xpalloc.
7446
0065d054
PE
7447 * charset.c (charset_table_size)
7448 (struct charset_sort_data.priority): Now ptrdiff_t.
7449 (charset_compare): Don't overflow if priorities differ greatly.
7450 (Fsort_charsets): Don't assume list length fits in int.
7451 Check for size-calculation overflow when allocating sort data.
7452 (syms_of_charset): Allocate an initial charset table that is
7453 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7454
7455 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7456
7457 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7458 The actual value is always <= INT_MAX, and leaving it unsigned made
7459 overflow checking harder.
7460
7461 * dispextern.h (struct glyph_matrix.rows_allocated)
7462 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7463 with xpalloc. The values are still always <= INT_MAX.
7464
7465 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7466
7467 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7468 (SAFE_NALLOCA): New macro.
7469
7470 * region-cache.c (struct boundary.pos, find_cache_boundary)
7471 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7472 (set_cache_region, invalidate_region_cache)
7473 (revalidate_region_cache, know_region_cache, region_cache_forward)
7474 (region_cache_backward, pp_cache):
7475 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7476 so that ptrdiff_t * can be passed to xpalloc.
7477 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7478 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7479 (pp_cache): Don't assume cache_len fits in int.
7480 * region-cache.h: Adjust extern decls to match.
7481
7482 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7483 EMACS_INT, since either will do, for xpalloc.
7484
7485 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7486 (xnmalloc, xnrealloc, xpalloc): New functions.
7487
726e0ab1
PE
7488 * bidi.c (bidi_shelve_header_size): New constant.
7489 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7490 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7491
51f30bc5 7492 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7493 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7494 (overlay_strings):
7495 Don't update size of array until after memory allocation succeeds,
7496 because xmalloc/xrealloc may not return.
0065d054
PE
7497 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7498 now that we have proper integer overflow checking.
7499 (record_overlay_string, overlay_strings): Catch overflows when
7500 calculating size of overlay_str_buf.
726e0ab1 7501
0065d054
PE
7502 * callproc.c (Fcall_process): Check for size overflow when
7503 calculating size of args2.
7504 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7505 Normally we prefer signed values, but sticking with ptrdiff_t would
7506 require adding more-complicated checks.
726e0ab1
PE
7507
7508 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7509 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7510 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7511 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7512
7513 * character.c (Fstring): Check for size-calculation overflow.
7514
7515 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7516 unnecessary integer overflow. Check for size overflow.
7517 (encode_coding_object): Don't update size until xmalloc succeeds.
7518
7519 * composite.c (get_composition_id): Check for overflow in glyph
7520 length calculations.
7521
7522 Integer and memory overflow fixes for display code.
7523 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7524 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7525 (scrolling_window): Check for overflow in size calculations.
7526 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7527 Don't assume glyph table len fits in int.
7528 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7529 (row_table_size): Now ptrdiff_t, not int.
7530 (scrolling_window): Avoid overflow in size calculations.
7531 Don't update size until allocation succeeds.
7532 * fns.c (concat): Check for overflow in size calculations.
7533 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7534 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7535 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7536
7537 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7538 (get_doc_string): Check for size calculation overflow.
7539 Don't update size until allocation succeeds.
7540 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7541 EMACS_INT, where ptrdiff_t will do.
7542 (Fsubstitute_command_keys): Check for string overflow.
7543
7544 * editfns.c (set_time_zone_rule): Don't assume environment length
7545 fits in int.
7546 (message_length): Now ptrdiff_t, not int.
7547 (Fmessage_box): Don't update size until allocation succeeds.
7548 Don't assume message length fits in int.
7549 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7550
0065d054
PE
7551 * emacs.c (main): Do not reallocate argv, since there is a null at
7552 the end that can be overwritten, and this way there's no need to
7553 worry about size-calculation overflow.
7554 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7555
7556 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7557 alloc succeeds.
7558 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7559
7560 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7561 (x_set_scroll_bar_width, x_figure_window_size):
7562 Check for integer overflow.
7563 (x_set_alpha): Do not assume XINT fits in int.
7564
7565 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7566 This is for the members text_lines, text_cols, total_lines, total_cols,
7567 where the system imposes an 'int' limit.
7568
7569 * fringe.c (Fdefine_fringe_bitmap):
7570 Don't update size until alloc works.
7571
7572 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7573 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7574
7575 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7576 Check for size-calculation overflow.
7577 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7578 do, as we prefer signed integers.
7579 (id_to_widget.max_size, id_to_widget.used)
7580 (xg_store_widget_in_map, xg_remove_widget_from_map)
7581 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7582 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7583 Use and return ptrdiff_t, not int.
7584 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7585 * gtkutil.h: Change prototypes to match the above.
7586
7587 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7588 are duplicate now that they've been promoted to lisp.h.
7589 (x_allocate_bitmap_record, x_alloc_image_color)
7590 (make_image_cache, cache_image, xpm_load):
7591 Don't update size until alloc is done.
7592 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7593 (x_detect_edges):
3256efce 7594 Check for size calculation overflow.
726e0ab1
PE
7595 (ct_colors_allocated_max): New constant.
7596 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7597 overflow.
3256efce 7598
726e0ab1
PE
7599 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7600 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7601 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7602 Use ptrdiff_t, not int, to count maps.
7603 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7604 calculations. Don't update size until allocation succeeds.
7605 Redo calculations to avoid overflow.
726e0ab1
PE
7606 * keyboard.h: Change prototypes to match the above.
7607
7608 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7609 to count maps.
7610 (current_minor_maps): Check for size calculation overflow.
7611 * keymap.h: Change prototypes to match the above.
7612
7613 * lread.c (read1, init_obarray): Don't update size until alloc done.
7614
7615 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7616 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7617
726e0ab1
PE
7618 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7619 Now ptrdiff_t, not int.
7620 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7621 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7622
7623 * process.c (Fnetwork_interface_list): Check for overflow
7624 in size calculation.
7625
7626 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7627
7628 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7629 overflow. Don't bother calling xmalloc when xrealloc will do.
7630
7631 * search.c (Freplace_match): Check for size calculation overflow.
7632 (Fset_match_data): Don't assume list lengths fit in 'int'.
7633
7634 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7635 for command line length. Do not attempt to address one before the
7636 beginning of an array, as that's not portable.
7637
7638 * term.c (max_frame_lines): Remove; unused.
7639 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7640 not int.
7641 (encode_terminal_code, calculate_costs): Check for size
7642 calculation overflow.
7643 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7644 table lengths and related sizes. Don't update size until alloc
7645 done. Redo calculations to avoid overflow.
7646 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7647
7648 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7649 subtracting pointers.
7650 (gobble_line): Check for overflow more carefully. Don't update size
7651 until alloc done.
7652
7653 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7654 Don't update size until alloc done.
7655 Redo size calculations to avoid overflow.
7656 Check for size calculation overflow.
0065d054 7657 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7658
7659 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7660 Use ptrdiff_t, not int, for sizes.
7661 (store_mode_line_noprop_char): Don't update size until alloc done.
7662
0065d054
PE
7663 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7664 Use ptrdiff_t, not int, for sizes.
7665 (Finternal_make_lisp_face, cache_face):
7666 Check for size calculation overflow.
7667 (cache_face): Treat size calculation overflows as if they were
7668 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7669
7670 * xfns.c (x_encode_text, x_set_name_internal)
7671 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7672 sizes, since they can exceed INT_MAX in size. Check for size
7673 calculation overflow.
7674
0065d054
PE
7675 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7676 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7677 Don't update size until alloc done.
7678
0065d054 7679 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7680 as sprintf is limited to int lengths.
1d526e2f 7681
252c5ee1
PE
7682 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7683 (X_LONG_MIN): New macros.
864d7ce7
PE
7684 Use them to make the following changes clearer.
7685 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7686 This change doesn't affect the value now, but it may help remind
7687 future maintainers not to raise the value too much later.
7688 (SELECTION_QUANTUM): Remove, replacing with ...
7689 (selection_quantum): ... new function, which avoids overflow.
7690 All uses changed.
7691 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7692 assumption that selection length fits in 'int'.
7693 (x_reply_selection_request, x_handle_selection_request)
7694 (x_get_window_property, receive_incremental_selection)
7695 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7696 (lisp_data_to_selection_data, clean_local_selection_data):
7697 Use ptrdiff_t, not int, to record length of selection.
7698 (x_reply_selection_request, x_get_window_property)
7699 (receive_incremental_selection, x_property_data_to_lisp):
7700 Redo calculations to avoid overflow.
7701 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7702 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7703 something.
7704 (x_get_window_property, receive_incremental_selection)
7705 (lisp_data_to_selection_data, x_property_data_to_lisp):
7706 Check for size-calculation overflow.
7707 (x_get_window_property, receive_incremental_selection)
7708 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7709 Don't store size until memory allocation succeeds.
7710 (x_get_window_property): Plug memory leak on memory exhaustion.
7711 Don't double-block input; malloc is safe here. Don't assume 2**34
7712 - 4 fits in unsigned long. Add an xassert to check
7713 XGetWindowProperty overflow. Be more careful about overflow
7714 calculations, and distinguish size from memory overflow better.
7715 (receive_incremental_selection): When tracing, don't assume
7716 unsigned int is less than INT_MAX.
7717 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7718 harmful) conversions of unsigned short to int.
7719 (lisp_data_to_selection_data): Don't assume that integers
7720 in the range -65535 through -1 fit in an X unsigned short.
7721 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7722 result parameters unless successful. Rely on cons_to_unsigned
7723 to report problems with elements; the old code wasn't right anyway.
7724 (x_check_property_data): Check for int overflow; we cannot use
7725 a wider type due to X limits.
7726 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7727
726e0ab1 7728 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7729
0065d054
PE
7730 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7731 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7732 (x_color_cells): Don't store size until memory allocation succeeds.
7733 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7734 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7735 (x_term_init): Don't assume length fits in int (sprintf is limited
7736 to int size).
bc18e09d 7737
ebfa62c0
PE
7738 Use ptrdiff_t for composition IDs.
7739 * character.c (lisp_string_width):
7740 * composite.c (composition_table_size, n_compositions)
7741 (get_composition_id, composition_gstring_from_id):
7742 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7743 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7744 * window.c (Frecenter):
7745 Use ptrdiff_t, not int, for composition IDs.
7746 * composite.c (get_composition_id): Check for integer overflow.
7747 * composite.h: Adjust prototypes to match the above changes.
7748
d3411f89
PE
7749 Use ptrdiff_t for hash table indexes.
7750 * category.c (hash_get_category_set):
7751 * ccl.c (ccl_driver):
7752 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7753 * coding.c (coding_system_charset_list, detect_coding_system):
7754 * coding.h (struct coding_system.id):
7755 * composite.c (get_composition_id, gstring_lookup_cache):
7756 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7757 * image.c (xpm_get_color_table_h):
7758 * lisp.h (hash_lookup, hash_put):
7759 * minibuf.c (Ftest_completion):
7760 Use ptrdiff_t for hash table indexes, not int (which is too
7761 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7762 32-bit --with-wide-int hosts).
7763
e097a6fa
PE
7764 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7765 Add a FIXME comment about memory leaks.
7766 (syms_of_charset): Don't assume xmalloc returns.
7767
5637687f
PE
7768 Don't assume that stated character widths fit in int.
7769 * character.c (Fchar_width, c_string_width, lisp_string_width):
7770 * character.h (CHAR_WIDTH):
7771 * indent.c (MULTIBYTE_BYTES_WIDTH):
7772 Use sanitize_char_width to avoid undefined and/or bad behavior
7773 with outlandish widths.
a66cfb1c 7774 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7775 now that we have two such functions. All uses changed.
7776 (sanitize_char_width): New inline function.
7777
a2271ba2
PE
7778 Don't assume that tab-width fits in int.
7779 * character.h (sanitize_width): New inline function.
7780 (SANE_TAB_WIDTH): New macro.
7781 (ASCII_CHAR_WIDTH): Use it.
7782 * indent.c (sane_tab_width): Remove. All uses replaced by
7783 SANE_TAB_WIDTH (current_buffer).
7784 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7785
18c52557
PE
7786 * fileio.c: Integer overflow issues with file modes.
7787 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7788
caeeedc1
PE
7789 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7790 Remove unreachable code.
7791 (read_hex, load_charset_map_from_file): Check for integer overflow.
7792
6df6ae42 7793 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7794 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7795 (x_send_scroll_bar_event): Likewise. Check that the size does not
7796 exceed limits imposed by XClientMessageEvent, as well as the usual
7797 ptrdiff_t and size_t limits.
7798
b13995db
PE
7799 * keyboard.c: Overflow, signedness and related fixes.
7800 (make_lispy_movement): Use same integer type in forward decl
7801 that is used in the definition.
7802 (read_key_sequence, keyremap_step):
7803 Change bufsize argument back to int, undoing my 2011-03-30 change.
7804 We prefer signed types, and int is wide enough here.
7805 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7806 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7807 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7808 length, not size_t. Use ptrdiff_t for index, not int.
7809 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7810 possibility of integer overflow.
7811
13464394
PE
7812 Overflow, signedness and related fixes for images.
7813
7814 * dispextern.h (struct it.stack[0].u.image.image_id)
7815 (struct_it.image_id, struct image.id, struct image_cache.size)
7816 (struct image_cache.used, struct image_cache.ref_count):
7817 * gtkutil.c (update_frame_tool_bar):
7818 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7819 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7820 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7821 * nsmenu.m (update_frame_tool_bar):
7822 * xdisp.c (calc_pixel_width_or_height):
7823 * xfns.c (image_cache_refcount):
7824 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7825 on typical 64-bit hosts.
7826
7827 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7828 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7829 Omit unnecessary casts to int.
7830 (parse_image_spec): Check that integers fall into 'int' range
7831 when the callers expect that.
7832 (image_ascent): Redo ascent calculation to avoid int overflow.
7833 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7834 (lookup_image): Remove unnecessary tests.
7835 (xbm_image_p): Locals are now of int, not EMACS_INT,
7836 since parse_image_check makes sure they fit into int.
7837 (png_load, gif_load, svg_load_image):
7838 Prefer int to unsigned where either will do.
7839 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7840 old tiff_error_handler and tiff_warning_handler.
7841 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7842 stack buffer overflows. It uses only the features of vsnprintf
7843 that are common to both POSIX and native Microsoft.
7844 (tiff_error_handler, tiff_warning_handler): Use it.
7845 (tiff_load, gif_load, imagemagick_load_image):
7846 Don't assume :index value fits in 'int'.
7847 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7848 (imagemagick_load_image): Check that crop parameters fit into
7849 the integer types that MagickCropImage accepts. Don't assume
7850 Vimagemagick_render_type has a nonnegative value. Don't assume
7851 size_t fits in 'long'.
7852 (gs_load): Use printmax_t to print the widest integers possible.
7853 Check for integer overflow when computing image height and width.
7854
c11821d4
EZ
78552011-08-26 Eli Zaretskii <eliz@gnu.org>
7856
7857 * xdisp.c (redisplay_window): Don't force window start if point
7858 will be invisible in the resulting window. (Bug#9324)
7859
0c95fcf7
EZ
78602011-08-25 Eli Zaretskii <eliz@gnu.org>
7861
7862 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7863 the display spec is of the form `(space ...)'.
7864 (handle_display_spec): Return the value returned by
7865 handle_single_display_spec, not just 1 or zero.
7866 (handle_single_display_spec): If the display spec is of the form
7867 `(space ...)', and specifies display in the text area, return 2
7868 rather than 1.
fee65a97 7869 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7870 accurately, and prefer exact match for point under bidi.
7871 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7872
7873 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7874 into disp_prop; all users changed.
7875
7876 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7877 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7878 for the text covered by the display property.
7879
e4ed06f1
CY
78802011-08-25 Chong Yidong <cyd@stupidchicken.com>
7881
7882 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7883 Change return value to nil.
7884 (Frecord_buffer): Delete unused function.
7885
f67cdd7f
EZ
78862011-08-24 Eli Zaretskii <eliz@gnu.org>
7887
5980d4c6
EZ
7888 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7889 buffers, return left-to-right.
8610fe8b
EZ
7890 (set_cursor_from_row): Consider candidate row a win if its glyph
7891 represents a newline and point is on that newline. Fixes cursor
7892 positioning on the newline at EOL of R2L text within L2R
7893 paragraph, and vice versa.
7894 (try_cursor_movement): Check continued rows, in addition to
7895 continuation rows. Fixes unwarranted scroll when point enters a
7896 continued line of R2L text within an L2R paragraph, or vice versa.
7897 (cursor_row_p): Consider the case of point being equal to
7898 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7899 from the end of a short line to the beginning of a continued line
7900 of R2L text within L2R paragraph.
7901 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7902 composed characters.
5980d4c6 7903
f67cdd7f
EZ
7904 * bidi.c (bidi_check_type): Use xassert.
7905 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7906 members.
7907
bca633fb
EZ
79082011-08-23 Eli Zaretskii <eliz@gnu.org>
7909
7910 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7911 a character.
7912
4a5885a7
CY
79132011-08-23 Chong Yidong <cyd@stupidchicken.com>
7914
7915 * nsfont.m (ns_otf_to_script): Fix typo.
7916
0902a04e
KH
79172011-08-22 Kenichi Handa <handa@m17n.org>
7918
7919 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7920 extra slot even if the purpose is char-code-property-table.
7921
1a2e6670
EZ
79222011-08-23 Eli Zaretskii <eliz@gnu.org>
7923
8ddde651
EZ
7924 * xdisp.c (redisplay_window): When computing centering_position,
7925 account for the height of the header line. (Bug#8874)
7926
425cc014
EZ
7927 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7928 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7929 candidate is selected by the mouse, and that candidate has a
7930 composed character under the mouse.
7931
1a2e6670
EZ
7932 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7933 coordinates reported by pos-visible-in-window-p for a composed
7934 character in column zero.
7935
8b76d6f8
SM
79362011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7937
7938 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7939
dac347dd
EZ
79402011-08-22 Eli Zaretskii <eliz@gnu.org>
7941
7942 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7943 consider it a hit if to_charpos is anywhere in the range of the
7944 composed buffer positions.
7945
e013fb34
CY
79462011-08-22 Chong Yidong <cyd@stupidchicken.com>
7947
7948 * image.c (gif_load): Don't assume that each subimage has the same
7949 dimensions as the base image. Handle disposal method that is
7950 "undefined" by the gif spec (Bug#9335).
7951
bd1ba3e8
CY
79522011-08-20 Chong Yidong <cyd@stupidchicken.com>
7953
7954 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7955 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7956
54a1215b
EZ
79572011-08-19 Eli Zaretskii <eliz@gnu.org>
7958
823564e5
EZ
7959 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7960 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7961 from an Org mode buffer to a Speedbar frame.
7962
54a1215b
EZ
7963 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7964 a composition, take its buffer position from IT->cmp_it.charpos.
7965 Fixes cursor positioning at the beginning of a line that begins
7966 with a composed character.
7967
9778ebcc
EZ
79682011-08-18 Eli Zaretskii <eliz@gnu.org>
7969
0be6ee06
EZ
7970 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7971 character bidirectional type, use STRONG_L instead. Fixes crashes
7972 in a buffer produced by `describe-categories'.
7973
9778ebcc
EZ
7974 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7975 members before the level stack, so they would be saved and
7976 restored when copying iterator state. Fixes incorrect reordering
7977 around TABs covered by display properties.
7978
156bffbe
AS
79792011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7980
6b02f655 7981 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7982
72ad093b
CY
79832011-08-17 Chong Yidong <cyd@stupidchicken.com>
7984
7985 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7986 (internal_condition_case_2, internal_condition_case_n):
7987 Remove unnecessary aborts (Bug#9081).
72ad093b 7988
35774242
EZ
79892011-08-17 Eli Zaretskii <eliz@gnu.org>
7990
7991 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7992 has no `load' handler, try opening the file locally. (Bug#9311)
7993
db76dd85
KB
79942011-08-16 Ken Brown <kbrown@cornell.edu>
7995
7996 * gmalloc.c: Expand comment.
7997
b215eee5
EZ
79982011-08-16 Eli Zaretskii <eliz@gnu.org>
7999
8000 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8001 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8002
a4579d33
KB
80032011-08-16 Ken Brown <kbrown@cornell.edu>
8004
8005 Fix memory allocation problems in Cygwin build (Bug#9273).
8006
8007 * unexcw.c ( __malloc_initialized): Declare external variable.
8008 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8009
8b76d6f8
SM
8010 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8011 New variables.
a4579d33
KB
8012 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8013 dumped emacs.
8014 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8015 in the static heap.
8016 [CYGWIN] (special_realloc): New function.
8017 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8018 requests to realloc storage in the static heap.
8019
3ebec551
PE
80202011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8021
8022 * bidi.c (bidi_initialize): Remove unused local.
8023
9fd8be00
EZ
80242011-08-15 Eli Zaretskii <eliz@gnu.org>
8025
6b02f655
SM
8026 * bidimirror.h:
8027 * biditype.h: Remove file.
8028 * makefile.w32-in ($(BLD)/bidi.$(O)):
8029 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8030
8031 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8032
8033 * chartab.c: Improve commentary for the uniprop_table API.
8034
32413314
EZ
8035 * bidi.c (bidi_paragraph_init): Support zero value of
8036 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8037 (bidi_initialize): Use uniprop_table instead of including
8038 biditype.h and bidimirror.h.
32413314 8039
9fd8be00
EZ
8040 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8041 coordinates of the iterator when restoring from ppos_it.
8042 (Bug#9296)
8043
5cf2b69b
KH
80442011-08-14 Kenichi Handa <handa@m17n.org>
8045
8046 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8047 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8048
daf17d00
EZ
80492011-08-14 Eli Zaretskii <eliz@gnu.org>
8050
8051 * xdisp.c (move_it_in_display_line_to): Don't invoke
8052 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8053 ppos_it. Fixes vertical cursor motion when line beginning is
8054 covered by an image. (Bug#9296)
8055
08e3161a
JD
80562011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8057
8058 * nsterm.h (ns_run_ascript): Declare.
8059 (NSAPP_DATA2_RUNASSCRIPT): Define.
8060
8061 * nsfns.m (as_script, as_result, as_status): New static variables.
8062 (ns_run_ascript): New function.
5e617bc2 8063 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8064 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8065 the event loop. Get status from as_status (Bug#7276).
8066
8067 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8068 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8069 the event loop (Bug#7276).
8070
a3720aa2
AS
80712011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8072
8073 * gnutls.c (QCgnutls_bootprop_priority)
8074 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8075 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8076 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8077 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8078 (QCgnutls_bootprop_verify_hostname_error)
8079 (QCgnutls_bootprop_callbacks_verify): Rename from
8080 Qgnutls_bootprop_..., all uses changed.
8081
8082 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8083 uses changed.
8084
0a0d27fb
PE
80852011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8086
19d5c50c
PE
8087 * xfaces.c (Qframe_set_background_mode): Now static.
8088 * dispextern.h (Qframe_set_background_mode): Remove decl.
8089
0a0d27fb
PE
8090 * process.c (Fnetwork_interface_info): Declare local only if needed.
8091
377538cb
JD
80922011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8093
8094 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8095 (Fnetwork_interface_list): Allocate in increments of bytes instead
8096 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8097 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8098 sockaddr.
8099 (struct ifflag_def): notrailers is smart on OSX.
8100 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8101 Get hardware address with getifaddrs if available.
8102
08fff70c
EZ
81032011-08-12 Eli Zaretskii <eliz@gnu.org>
8104
8105 * xdisp.c (iterate_out_of_display_property): xassert that
8106 IT->position is set to within IT->object's boundaries. Break from
8107 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8108 when IT->position is set up wrongly due to some bug.
8109 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8110 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8111 entry. Force push_it to save on the stack the current
8112 buffer/string position, to be restored by pop_it. Fix flags in
8113 the iterator structure wrt the object coming from a display
8114 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8115 properties. (Bug#9284)
8116
7be1c708 81172011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8118
7be1c708
CY
8119 * fontset.c (fontset_get_font_group): Add proper type checks.
8120 (Bug#9172)
aac0c6e3 8121
7be1c708 81222011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8123
7be1c708
CY
8124 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8125 and LC_VERSION_MIN_MACOSX.
8126 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8127 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8128
97bb72a6
EZ
81292011-08-08 Eli Zaretskii <eliz@gnu.org>
8130
8131 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8132 no-display-properties-and-no-overlays under bidi display.
8133 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8134 properties and overlays.
97bb72a6 8135
d5617611
CY
81362011-08-08 Chong Yidong <cyd@stupidchicken.com>
8137
37e11a63
CY
8138 * editfns.c (Fset_time_zone_rule): Document relationship with the
8139 setenv function.
8140
d5617611
CY
8141 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8142 the font entity extracted from the cache (Bug#8109).
8143
58872834
CY
81442011-08-07 Chong Yidong <cyd@stupidchicken.com>
8145
8146 * composite.c (autocmp_chars): Don't reset point. That is done by
8147 restore_point_unwind (Bug#5984).
8148
75bfc667
JL
81492011-08-07 Juri Linkov <juri@jurta.org>
8150
8151 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8152 to show the arg `TIME' instead of `TIMEVAL'.
8153
d1410150
EZ
81542011-08-06 Eli Zaretskii <eliz@gnu.org>
8155
8156 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8157 display property strides EOL and includes a newline, as in
8158 longlines-mode. (Bug#9254)
75b771e4
EZ
8159 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8160 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8161
8162 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8163 is non-zero, even if the data buffer is NULL. Fixes a crash in
8164 vertical-motion with longlines-mode. (Bug#9254)
8165
35928349
EZ
81662011-08-05 Eli Zaretskii <eliz@gnu.org>
8167
ec7cc85b
EZ
8168 * bidi.c <bidi_cache_total_alloc>: Now static.
8169 (bidi_initialize): Initialize bidi_cache_total_alloc.
8170
8b76d6f8 8171 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8172 cache. (Bug#9221)
8173
8174 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8175 amount allocated this far in `bidi_cache_total_alloc'.
8176 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8177 non-zero, only free the data buffer without restoring the cache
8178 contents. All callers changed.
8179
8180 * dispextern.h (bidi_unshelve_cache): Update prototype.
8181
8182 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8183 (move_it_in_display_line, move_it_to)
8184 (move_it_vertically_backward, move_it_by_lines): Replace the call
8185 to xfree to an equivalent call to bidi_unshelve_cache.
8186 (move_it_in_display_line_to): Fix logic of returning
412b6358 8187 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8188
e2e2423b
EZ
81892011-08-05 Eli Zaretskii <eliz@gnu.org>
8190
8191 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8192 came from a string character with a `cursor' property. (Bug#9229)
8193
ae9e757a
JD
81942011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8195
8196 * Makefile.in (LIB_PTHREAD): New variable.
8197 (LIBES): Add LIB_PTHREAD (Bug#9216).
8198
8199 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8200 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8201
213bd7f2
AS
82022011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8203
6b02f655 8204 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8205
99aaf75f
JD
82062011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8207
8208 * xterm.c (x_find_topmost_parent): New function.
8209 (x_set_frame_alpha): Find topmost parent window with
8210 x_find_topmost_parent and set the property there also (bug#9181).
8211 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8212
c74e9d86
PE
82132011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8214
8215 * callproc.c (Fcall_process): Avoid vfork clobbering
8216 the local vars buffer, coding_systems, current_dir.
8217
640c8776
SM
82182011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8219
8220 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8221
f26d0e4c
PE
82222011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8223
8a10d76c
PE
8224 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8225 so that it is not optimized away.
8226
f26d0e4c
PE
8227 * xdisp.c (compute_display_string_pos): Remove unused local.
8228
55439c61
EZ
82292011-08-02 Eli Zaretskii <eliz@gnu.org>
8230
8231 Fix slow cursor motion and scrolling in large buffers with
8232 selective display, like Org Mode buffers. (Bug#9218)
8233
8234 * dispextern.h (struct bidi_it): New member disp_prop_p.
8235
8236 * xdisp.c: Remove one-slot cache of display string positions.
8237 (compute_display_string_pos): Accept an additional argument
5e617bc2 8238 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8239 for a display string or property. If found, set DISP_PROP_P
8240 non-zero.
8241
8242 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8243 DISP_PROP_P, and pass it to compute_display_string_pos.
8244 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8245 non-zero. All callers of bidi_fetch_char changed.
8246
fb33fa43
SM
82472011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8248
8249 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8250
b099e063
DM
82512010-12-03 Don March <don@ohspite.net>
8252
8253 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8254 last character M-[char] is translated to ESC [char] (bug#7541).
8255
5cc7f7af
KH
82562011-08-02 Kenichi Handa <handa@m17n.org>
8257
d0fffa3f 8258 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8259
8260 * chartab.c (uniprop_table): Make it non-static.
8261
525d5e6e
EZ
82622011-08-01 Eli Zaretskii <eliz@gnu.org>
8263
8264 * xdisp.c (forward_to_next_line_start): Accept additional argument
8265 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8266 on the newline.
8267 (reseat_at_next_visible_line_start): Use the bidi iterator state
8268 returned by forward_to_next_line_start to restore the state of
8269 it->bidi_it after backing up to previous newline. (Bug#9212)
8270
31011111
AS
82712011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8272
8273 * regex.c (re_comp): Protoize.
8274 (re_exec): Fix return type.
8275 (regexec): Fix type of `ret'. (Bug#9203)
8276
476371c4
PE
82772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8278
e5d76069
PE
8279 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8280 This is needed if max-image-size is a floating-point number.
8281
9a79b20c
AS
82822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8283
8284 * print.c (print_object): Print empty symbol as ##.
8285
8286 * lread.c (read1): Read ## as empty symbol.
8287
d8c2fa78
AA
82882011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8289
8290 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8291 setting frame foreground color (Bug#9175).
8292 (x_set_background_color): Likewise.
8293
ffe57a7a
AA
8294 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8295 contents (Bug#9176).
8296 (EmacsTooltip -init): Remove bezels and add shadows to
8297 tooltip windows.
8298
bf3492a5
AA
8299 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8300 or scroll bar (Bug#8470).
8301
d55e9c53
AA
8302 * nsfont.m (nsfont_open): Remove assignment to voffset and
8303 unnecessary vars hshink, expand, hd, full_height, min_height.
8304 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8305
8306 * nsterm.h (nsfont_info): Remove voffset field.
8307
d8c2fa78 83082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8309
8310 Implement strike-through and overline on NextStep (Bug#8863).
8311
8312 * nsfont.m (nsfont_open): Use underline position provided by font,
8313 instead of hard-coded value of 2.
8314 (nsfont_draw): Call ns_draw_text_decoration instead.
8315
8316 * nsterm.h: Add declaration for ns_draw_text_decoration.
8317
8318 * nsterm.m (ns_draw_text_decoration): New function for drawing
8319 underline, overline, and strike-through.
8320 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8321 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8322 accommodate underlining, etc.
4843aac3 8323
4cc60b9b
EZ
83242011-07-28 Eli Zaretskii <eliz@gnu.org>
8325
bc7ece87
EZ
8326 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8327 default.
4cc60b9b 8328
476371c4
PE
83292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8330
66606eea
PE
8331 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8332 Without this fix, if a signal arrives just after memory fills up,
8333 'malloc' might be invoked reentrantly.
8334
476371c4
PE
8335 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8336 In other words, assume that every image size is allowed, on non-X
8337 hosts. This assumption is probably wrong, but it lets Emacs compile.
8338
f3fcc40d
AS
83392011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8340
8341 * regex.c (re_iswctype): Convert return values to boolean.
8342
350c992f
EZ
83432011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8344
8345 * xdisp.c (compute_display_string_pos): Don't use cached display
8346 string position if the buffer had its restriction changed.
8347 (Bug#9184)
8348
5266b4bb
PE
83492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8350
8351 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8352
2573a837 83532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8354
41f55ccd 8355 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8356
39e378da
PE
8357 * bidi.c: Integer size and overflow fixes.
8358 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8359 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8360 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8361 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8362 (bidi_find_other_level_edge):
8363 Use ptrdiff_t instead of EMACS_INT where either will do.
8364 This works better on 32-bit hosts configured --with-wide-int.
8365 (bidi_cache_ensure_space): Check for size-calculation overflow.
8366 Use % rather than repeated addition, for better worst-case speed.
8367 Don't set bidi_cache_size until after xrealloc returns, because it
8368 might not return.
8369 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8370 (bidi_cache_ensure_space): Also check that the bidi cache size
8371 does not exceed that of the largest Lisp string or buffer. See Eli
8372 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8373
5e927815
PE
8374 * alloc.c (__malloc_size_t): Remove.
8375 All uses replaced by size_t. See Andreas Schwab's note
8376 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8377
ca4aa935
PE
8378 * image.c: Improve checking for integer overflow.
8379 (check_image_size): Assume that f is nonnull, since
8380 it is always nonnull in practice. This is one less thing to
8381 worry about when checking for integer overflow later.
8382 (x_check_image_size): New function, which checks for integer
8383 overflow issues inside X.
8384 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8385 This removes the need for a memory_full check.
8386 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8387 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8388 (xbm_read_bitmap_data): Change locals back to 'int', since
8389 their values must fit in 'int'.
8390 (xpm_load_image, png_load, tiff_load):
8391 Invoke x_create_x_image_and_pixmap earlier,
8392 to avoid much needless work if the image is too large.
8393 (tiff_load): Treat overly large images as if
8394 x_create_x_image_and_pixmap failed, not as malloc failures.
8395 (gs_load): Use x_check_image_size.
8396
5f8f9cc2
PE
8397 * gtkutil.c: Omit integer casts.
8398 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8399 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8400
5adf60bc
PE
8401 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8402
c8907a93
PE
8403 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8404 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8405 would wrongly return t on a 64-bit host.
8406
e3c25c68
PE
8407 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8408 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8409 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8410 and therefore cause GCC to emit a bogus diagnostic in some cases.
8411
3f791afe
PE
8412 * image.c: Integer signedness and overflow and related fixes.
8413 This is not an exhaustive set of fixes, but it's time to
8414 record what I've got.
8415 (lookup_pixel_color, check_image_size): Remove redundant decls.
8416 (check_image_size): Don't assume that arbitrary EMACS_INT values
8417 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8418 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8419 (tiff_load, imagemagick_load_image):
8420 Check for overflow in size calculations.
8421 (x_create_x_image_and_pixmap): Remove unnecessary test for
8422 xmalloc returning NULL; that can't happen.
8423 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8424 (xpm_color_bucket): Use better integer hashing function.
8425 (xpm_cache_color): Don't possibly over-allocate memory.
8426 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8427 (gif_memory_source):
8428 Use ptrdiff_t, not int or size_t, to record sizes.
8429 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8430 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8431 either works, as we prefer signed integers.
8432 (tiff_read_from_memory, tiff_write_from_memory):
8433 Return tsize_t, not size_t, since that's what the TIFF API wants.
8434 (tiff_read_from_memory): Don't fail simply because the read would
8435 go past EOF; instead, return a short read.
8436 (tiff_load): Omit no-longer-needed casts.
8437 (Fimagemagick_types): Don't assume size fits into 'int'.
8438
3cc5a532
PE
8439 Improve hashing quality when configured --with-wide-int.
8440 * fns.c (hash_string): New function, taken from sxhash_string.
8441 Do not discard information about ASCII character case; this
8442 discarding is no longer needed.
8443 (sxhash-string): Use it. Change sig to match it. Caller changed.
8444 * lisp.h: Declare it.
8445 * lread.c (hash_string): Remove, since we now use fns.c's version.
8446 The fns.c version returns a wider integer if --with-wide-int is
8447 specified, so this should help the quality of the hashing a bit.
8448
b312a492
PE
8449 * emacs.c: Integer overflow minor fix.
8450 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8451 Define only if GNU_LINUX.
8452 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8453
dfd153ae
PE
8454 * dispnew.c: Integer signedness and overflow fixes.
8455 Remove unnecessary forward decls, that were a maintenance hassle.
8456 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8457 All uses changed.
8458 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8459 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8460 (prepare_desired_row, line_draw_cost):
8461 Use int, not unsigned, where either works.
8462 (save_current_matrix, restore_current_matrix):
8463 Use ptrdiff_t, not size_t, where either works.
8464 (init_display): Check for overflow more accurately, and without
8465 relying on undefined behavior.
8466
a81d11a3
PE
8467 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8468 Remove, replacing with the new symbols in lisp.h. All uses changed.
8469 * fileio.c (make_temp_name):
8470 * filelock.c (lock_file_1, lock_file):
8471 * xdisp.c (message_dolog):
8472 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8473 Use pMd etc. instead.
8474 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8475 replacing the pWIDE etc. symbols removed from editfns.c.
8476
3300e6fd
PE
8477 * keyboard.h (num_input_events): Now uintmax_t.
8478 This is (very slightly) less likely to mess up due to wraparound.
8479 All uses changed.
8480
fd05c7e9
PE
8481 * buffer.c: Integer signedness fixes.
8482 (alloc_buffer_text, enlarge_buffer_text):
8483 Use ptrdiff_t rather than size_t when either will do, as we prefer
8484 signed integers.
8485
903fe15d
PE
8486 * alloc.c: Integer signedness and overflow fixes.
8487 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8488 (__malloc_size_t): Default to size_t, not to int.
8489 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8490 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8491 Prefer ptrdiff_t to size_t when either would do, as we prefer
8492 signed integers.
8493 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8494 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8495 Now const. Initialize with values that are in range even if char
8496 is signed.
8497 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8498 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8499 These functions do the right thing with sizes > 2**32.
8500 (check_depth): Now ptrdiff_t, not int.
8501 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8502 Adjust to new way of storing sizes. Check for size overflow bugs
8503 in rest of code.
8504 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8505 slightly wrong anyway, as it missed one instance of
8506 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8507 (refill_memory_reserve): Omit needless cast to size_t.
8508 (mark_object_loop_halt): Mark as externally visible.
8509
ac82cc6a
PE
8510 * xselect.c: Integer signedness and overflow fixes.
8511 (Fx_register_dnd_atom, x_handle_dnd_message):
8512 Use ptrdiff_t, not size_t, since we prefer signed.
8513 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8514 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8515 x_dnd_atoms_size and x_dnd_atoms_length.
8516
c2d1e36d
PE
8517 * doprnt.c: Prefer signed to unsigned when either works.
8518 * eval.c (verror):
8519 * doprnt.c (doprnt):
8520 * lisp.h (doprnt):
8521 * xdisp.c (vmessage):
8522 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8523 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8524 prefer signed arithmetic to avoid comparison confusion.
8525 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8526 but is a bit tricky.
8527
0e926e56
PE
8528 Assume freestanding C89 headers, string.h, stdlib.h.
8529 * data.c, doprnt.c, floatfns.c, print.c:
8530 Include float.h unconditionally.
8531 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8532 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8533 * regex.c: Likewise for stddef.h, string.h.
8534 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8535 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8536 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8537 (STDC_HEADERS): Remove obsolete defines.
8538 * sysdep.c: Include limits.h unconditionally.
8539
9cfdb3ec
PE
8540 Assume support for memcmp, memcpy, memmove, memset.
8541 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8542 * regex.c (memcmp, memcpy):
8543 Remove; we assume C89 now.
8544
8545 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8546 (__malloc_safe_bcopy): Remove; no longer needed.
8547
cf950e6b 8548 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8549 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8550 well either way, and we prefer signed to unsigned.
8551
dbf38e02
LMI
85522011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8553
8554 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8555 closes the connection while we're reading (bug#9182).
8556
d6f0886c 85572011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8558
d6f0886c
JD
8559 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8560 are specified (Bug#9168).
24e0f6b1 8561
2eb1f9e6
PE
85622011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8563
8564 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8565 Found by GCC static checking and --with-wide-int on a 32-bit host.
8566
22381272 85672011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8568
8569 * xdisp.c (compute_display_string_pos): Fix logic of caching
8570 previous display string position. Initialize cached_prev_pos to
8571 -1. Fixes slow-down at the beginning of a buffer.
8572
f25e39b4
EZ
85732011-07-24 Eli Zaretskii <eliz@gnu.org>
8574
8575 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8576 for attrs[LFACE_FONTSET_INDEX].
8577
04c4b52e
PE
85782011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8579
8580 * xml.c (parse_region): Remove unused local
8581 that was recently introduced.
8582
c1734fbd
EZ
85832011-07-23 Eli Zaretskii <eliz@gnu.org>
8584
be18c5a5
EZ
8585 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8586 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8587
c1734fbd
EZ
8588 * xdisp.c (move_it_in_display_line_to): Record the best matching
8589 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8590 exit if none of the characters scanned was an exact match.
8591 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8592 when exact match is impossible due to invisible text, and the
8593 lines are truncated.
8594
a258d627
JD
85952011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8598 for OSX >= 10.7.
8599
b6d5a689
EZ
86002011-07-22 Eli Zaretskii <eliz@gnu.org>
8601
0f74f785
EZ
8602 Fix a significant slow-down of cursor motion with C-n, C-p,
8603 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8604 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8605 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8606 (next_element_from_buffer): Call compute_stop_pos_backwards to
8607 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8608 base_level_stop.
8609 (reseat): Don't look for prev_stop, as that could mean a very long
8610 run.
8611 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8612 <cached_disp_overlay_modiff>: Cache for last found display string
8613 position.
551918c1 8614 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8615 about the same buffer in the same area of character positions, and
8616 the buffer wasn't changed since the time the display string
8617 position was cached.
551918c1 8618
b2d0c91a
EZ
86192011-07-22 Eli Zaretskii <eliz@gnu.org>
8620
8621 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8622 is an integer, which is important for empty lines. (Bug#9149)
8623
043604ee
CY
86242011-07-22 Chong Yidong <cyd@stupidchicken.com>
8625
8626 * frame.c (Fmodify_frame_parameters): In tty case, update the
8627 default face if necessary (Bug#4238).
8628
da4adb04
CY
86292011-07-21 Chong Yidong <cyd@stupidchicken.com>
8630
8631 * editfns.c (Fstring_to_char): No need to explain what a character
8632 is in the docstring (Bug#6576).
8633
9abd0532
LMI
86342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8635
8636 * xml.c (parse_region): Make sure we always return a tree.
8637
36881d16
HK
86382011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8639
8640 * xml.c (parse_region): If a document contains only comments,
8641 return that, too.
8642
1e98674d
LMI
86432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8644
8645 * xml.c (make_dom): Return comments, too.
8646
590bd467
PE
86472011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8648
8649 Port to OpenBSD.
8650 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8651 and the surrounding thread.
8652 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8653 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8654 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8655 timer goes off.
8656 * s/openbsd.h (BROKEN_SIGIO): Define.
8657 * unexelf.c (unexec) [__OpenBSD__]:
8658 Don't update the .mdebug section of the Alpha COFF symbol table.
8659
f41628b2
LMI
86602011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8661
8662 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8663 (bug#8460).
8664
b59b67c5
PE
86652011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8666
15e3a074
PE
8667 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8668 This fixes some race conditions on the permissions of any newly
8669 created file.
8670
41bed37d
PE
8671 * alloc.c (valid_pointer_p): Use pipe, not open.
8672 This fixes some permissions issues when debugging.
8673
b59b67c5
PE
8674 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8675 If fchown fails to set both uid and gid, try to set just gid,
8676 as that is sometimes allowed. Adjust the file's mode to eliminate
8677 setuid or setgid bits that are inappropriate if fchown fails.
8678
925a6be7
SM
86792011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8680
8681 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8682 to compare Lisp_Objects.
8683 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8684 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8685 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8686
52968808
AS
86872011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8688
0a6a104b
AS
8689 * lread.c (read_integer): Unread even EOF character.
8690 (read1): Likewise. Properly record start position of symbol.
8691
52968808
AS
8692 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8693 symbol character follows.
8694
9e381cdd
PE
86952011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8696
8697 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8698 This works around a problem with the previous change to Fcopy_file.
8699 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8700 and without this change, GCC might complain about discarding
8701 fchown's return value.
8702
b5641435
JB
87032011-07-16 Juanma Barranquero <lekktu@gmail.com>
8704
8705 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8706
a8031457
PE
87072011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8708
8709 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8710
dd889327
LMI
87112011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8712
750c33f7
LMI
8713 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8714 it's used from the C level.
8715
dd889327
LMI
8716 * process.c: Use the same condition for POLL_FOR_INPUT in both
8717 keyboard.c and process.c (bug#1858).
8718
87e86684
LM
87192011-07-09 Lawrence Mitchell <wence@gmx.li>
8720
8721 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8722 (Fgnutls_boot): Use it.
8723
64348f40
AS
87242011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8725
8726 * doc.c (Fsubstitute_command_keys): Revert last change.
8727
1d698799
LMI
87282011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8729
f863868c
LMI
8730 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8731 quotes the next character, and doesn't affect other longer
8732 sequences (bug#8935).
8733
1d698799
LMI
8734 * lread.c (syms_of_lread): Clarify that is isn't only
8735 `eval-buffer' and `eval-defun' that's affected by
8736 `lexical-binding' (bug#8460).
8737
aa4b6df6
EZ
87382011-07-15 Eli Zaretskii <eliz@gnu.org>
8739
8740 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8741 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8742
5d856da6
PE
87432011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8744
ad6042bb
PE
8745 Fix minor problems found by static checking.
8746 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8747 (elsz): Now a signed constant, not a size_t var. We prefer signed
8748 types to unsigned, to avoid integer comparison confusion. Without
8749 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8750 "cannot optimize loop, the loop counter may overflow", a symptom
8751 of the confusion.
f00bbb22 8752 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8753 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8754
6468f31c
LMI
87552011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8756
49080b10
LMI
8757 * search.c (Fre_search_backward): Mention `case-fold-search' in
8758 all the re_search_* functions (bug#8138).
8759
6468f31c
LMI
8760 * keyboard.c (Fopen_dribble_file): Document when the file is
8761 closed (bug#8056).
8762
c965adc5
EZ
87632011-07-14 Eli Zaretskii <eliz@gnu.org>
8764
df9733bf
EZ
8765 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8766 bidi_cache_idx.
8767
0bb23927
EZ
8768 Support bidi reordering of display and overlay strings.
8769 * xdisp.c (compute_display_string_pos)
8770 (compute_display_string_end): Accept additional argument STRING.
8771 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8772 (reseat_to_string): Initialize bidi_it->string.s and
8773 bidi_it->string.schars.
8774 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8775 NULL (avoids a crash in bidi_paragraph_init).
8776 Initialize itb.string.lstring.
0bb23927
EZ
8777 (init_iterator): Call bidi_init_it only of a valid
8778 buffer position was specified. Initialize paragraph_embedding to
8779 L2R.
8780 (reseat_to_string): Initialize the bidi iterator.
8781 (display_string): If we need to ignore text properties of
8782 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8783 original value of -1 will not work with bidi.)
8784 (compute_display_string_pos): First arg is now struct
8785 `text_pos *'; all callers changed. Support display properties on
8786 Lisp strings.
8787 (compute_display_string_end): Support display properties on Lisp
8788 strings.
8789 (init_iterator, reseat_1, reseat_to_string): Initialize the
8790 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8791 when iterating on a string not from display properties).
640c8776
SM
8792 (compute_display_string_pos, compute_display_string_end):
8793 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8794 arrow keys.
8795 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8796 base_level_stop; instead, set base_level_stop to BEGV.
8797 Fixes crashes in vertical-motion.
0bb23927
EZ
8798 (next_element_from_buffer): Improve commentary for when
8799 the iterator is before prev_stop.
8800 (init_iterator): Initialize bidi_p from the default value of
8801 bidi-display-reordering, not from buffer-local value. Use the
8802 buffer-local value only if initializing for buffer iteration.
8803 (handle_invisible_prop): Support invisible properties on strings
8804 that are being bidi-reordered.
8805 (set_iterator_to_next): Support bidi reordering of C strings and
8806 Lisp strings.
8807 (next_element_from_string): Support bidi reordering of Lisp
8808 strings.
8809 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8810 (display_string): Support display of R2L glyph rows.
8811 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8812 (init_iterator): Don't initialize it->bidi_p for strings
8813 here.
8814 (reseat_to_string): Initialize it->bidi_p for strings here.
8815 (next_element_from_string, next_element_from_c_string)
8816 (next_element_from_buffer): Add xassert's for correspondence
8817 between IT's object being iterated and it->bidi_it.string
8818 structure.
8819 (face_before_or_after_it_pos): Support bidi iteration.
8820 (next_element_from_c_string): Handle the case of the first string
8821 character that is not the first one in the visual order.
8822 (get_visually_first_element): New function, refactored from common
8823 parts of next_element_from_buffer, next_element_from_string, and
8824 next_element_from_c_string.
8825 (tool_bar_lines_needed, redisplay_tool_bar)
8826 (display_menu_bar): Force left-to-right direction. Add a FIXME
8827 comment for making that be controlled by a user option.
8828 (push_it, pop_it): Save and restore the state of the
8829 bidi iterator. Save and restore the bidi_p flag.
8830 (pop_it): Iterate out of display property for string iteration as
8831 well.
8832 (iterate_out_of_display_property): Support iteration over strings.
8833 (handle_single_display_spec): Set up it->bidi_it for iteration
8834 over a display string, and call bidi_init_it.
8835 (handle_single_display_spec, next_overlay_string)
8836 (get_overlay_strings_1, push_display_prop): Set up the bidi
8837 iterator for displaying display or overlay strings.
8838 (forward_to_next_line_start): Don't use the shortcut if
8839 bidi-iterating.
8840 (back_to_previous_visible_line_start): If handle_display_prop
8841 pushed the iterator stack, restore the internal state of the bidi
8842 iterator by calling bidi_pop_it same number of times.
8843 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8844 and we are bidi-iterating, don't decrement the iterator position;
8845 instead, set the first_elt flag in the bidi iterator, to produce
8846 the same effect.
8847 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8848 (push_display_prop): xassert that we are iterating a buffer.
8849 (push_it, pop_it): Save and restore paragraph_embedding member.
8850 (handle_single_display_spec, next_overlay_string)
8851 (get_overlay_strings_1, reseat_1, reseat_to_string)
8852 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8853 correctly. Don't assume unibyte strings are not bidi-reordered.
8854 (compute_display_string_pos)
8855 (compute_display_string_end): Fix handling the case of C string.
8856 (push_it, pop_it): Save and restore from_disp_prop_p.
8857 (handle_single_display_spec, push_display_prop): Set the
8858 from_disp_prop_p flag.
8859 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8860 (pop_it): Call iterate_out_of_display_property only if we are
8861 popping after iteration over a string that came from a display
8862 property. Fix a typo in popping stretch info. Add an assertion
8863 for verifying that the iterator position is in sync with the bidi
8864 iterator.
8865 (handle_single_display_spec, get_overlay_strings_1)
8866 (push_display_prop): Fix initialization of paragraph direction for
8867 string when that of the parent object is not yet determined.
8868 (reseat_1): Call bidi_init_it to resync the bidi
8869 iterator with IT's position. (Bug#7616)
8870 (find_row_edges): If ROW->start.pos gives position
8871 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8872 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8873 Reset the from_disp_prop_p flag.
8874 (SAVE_IT, RESTORE_IT): New macros.
8875 (pos_visible_p, face_before_or_after_it_pos)
8876 (back_to_previous_visible_line_start)
8877 (move_it_in_display_line_to, move_it_in_display_line)
8878 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8879 (try_scrolling, redisplay_window, display_line): Use them when
8880 saving a temporary copy of the iterator and restoring it back.
8881 (back_to_previous_visible_line_start, reseat_1)
8882 (init_iterator): Empty the bidi cache "stack".
8883 (move_it_in_display_line_to): If iterator ended up at
8884 EOL, but we never saw any buffer positions smaller than
8885 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8886 motion in bidi-reordered lines.
8887 (move_it_in_display_line_to): Record prev_method and prev_pos
8888 immediately before the call to set_iterator_to_next. Fixes cursor
8889 motion in bidi-reordered lines with stretch glyphs and strings
8890 displayed in margins. (Bug#8133) (Bug#8867)
8891 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8892 TO_CHARPOS.
640c8776
SM
8893 (pos_visible_p): Support positions in bidi-reordered lines.
8894 Save and restore bidi cache.
0bb23927
EZ
8895
8896 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8897 (bidi_paragraph_info): Delete unused struct.
8898 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8899 (bidi_cache_start): New variable.
8900 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8901 to zero.
8902 (bidi_cache_fetch_state, bidi_cache_search)
8903 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8904 (bidi_cache_find, bidi_peek_at_next_level)
8905 (bidi_level_of_next_char, bidi_find_other_level_edge)
8906 (bidi_move_to_visually_next): Compare cache index with
8907 bidi_cache_start rather than with zero.
8908 (bidi_fetch_char): Accept new argument STRING; all callers
8909 changed. Support iteration over a string. Support strings with
8910 display properties. Support unibyte strings. Fix the type of
8911 `len' according to what STRING_CHAR_AND_LENGTH expects.
8912 (bidi_paragraph_init, bidi_resolve_explicit_1)
8913 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8914 (bidi_level_of_next_char, bidi_move_to_visually_next):
8915 Support iteration over a string.
0bb23927
EZ
8916 (bidi_set_sor_type, bidi_resolve_explicit_1)
8917 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8918 can now be zero (for strings); special values 0 and -1 were
8919 changed to -1 and -2, respectively.
8920 (bidi_char_at_pos): New function.
8921 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8922 Call it instead of FETCH_MULTIBYTE_CHAR.
8923 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8924 initialized to valid values.
8925 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8926 values.
8927 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8928 the test for valid cached positions. Fix the logic for looking up
8929 the sentinel state in the cache. GCPRO the Lisp string we are
8930 iterating.
8931 (bidi_push_it, bidi_pop_it): New functions.
8932 (bidi_initialize): Initialize the bidi cache start stack pointer.
8933 (bidi_cache_ensure_space): New function, refactored from part of
8934 bidi_cache_iterator_state. Don't assume the required size is just
8935 one BIDI_CACHE_CHUNK away.
8936 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8937 (bidi_count_bytes, bidi_char_at_pos): New functions.
8938 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8939 always valid if bidi_cache_idx is valid.
8940 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8941 is valid if it's going to be used.
8942 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8943 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8944 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8945 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8946 (bidi_find_other_level_edge, bidi_cache_start_stack):
8947 All variables related to cache indices are now EMACS_INT.
c965adc5 8948
0bb23927
EZ
8949 * dispextern.h (struct bidi_string_data): New structure.
8950 (struct bidi_it): New member `string'. Make flag members be 1-bit
8951 fields, and put them last in the struct.
640c8776
SM
8952 (compute_display_string_pos, compute_display_string_end):
8953 Update prototypes.
0bb23927
EZ
8954 (bidi_push_it, bidi_pop_it): Add prototypes.
8955 (struct iterator_stack_entry): New members bidi_p,
8956 paragraph_embedding, and from_disp_prop_p.
8957 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8958 (bidi_shelve_cache, bidi_unshelve_cache):
8959 Declare prototypes.
0bb23927
EZ
8960
8961 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8962 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8963 and vector-like objects.
8964
8965 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8966 cache around display iteration.
8967
8968 * window.c (Fwindow_end, window_scroll_pixel_based)
8969 (displayed_window_lines, Frecenter): Save and restore the bidi
8970 cache around display iteration.
8971
3bbd2265
LMI
89722011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8973
8974 * editfns.c (Fdelete_region): Clarify the use of the named
8975 parameters (bug#6788).
8976
adc47434
MR
89772011-07-14 Martin Rudalics <rudalics@gmx.at>
8978
8979 * indent.c (Fvertical_motion): Set and restore w->pointm when
8980 saving and restoring the window's buffer (Bug#9006).
8981
837c31f8
LMI
89822011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8983
8984 * editfns.c (Fstring_to_char): Clarify just what is returned
8985 (bug#6576). Text by Eli Zaretskii.
8986
ac389d0c
JB
89872011-07-13 Juanma Barranquero <lekktu@gmail.com>
8988
8989 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8990
0be0ce47
EZ
89912011-07-13 Eli Zaretskii <eliz@gnu.org>
8992
8993 * buffer.c (mmap_find): Fix a typo.
8994
cd18e7e3
JB
89952011-07-13 Johan Bockgård <bojohan@gnu.org>
8996
8997 Fix execution of x selection hooks.
8998 * xselect.c (Qx_lost_selection_functions)
8999 (Qx_sent_selection_functions): New vars.
9000 (syms_of_xselect): DEFSYM them.
9001 (x_handle_selection_request): Pass Qx_sent_selection_functions
9002 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9003 (x_handle_selection_clear,x_clear_frame_selections):
9004 Pass Qx_lost_selection_functions rather than
9005 Vx_lost_selection_functions to Frun_hook_with_args.
9006
47ea7f44
PE
90072011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9008
ac389d0c 9009 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9010 The old code sometimes used this field without initializing it.
9011
47ea7f44
PE
9012 * alloc.c (gc_sweep): Don't read past end of array.
9013 In theory, the old code could also have corrupted Emacs internals,
9014 though it'd be very unlikely.
9015
bc985c87
AS
90162011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9017
9018 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9019 argument. (Bug#4026)
bc985c87 9020
0cf34688
LMI
90212011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9022
b3dadd76
LMI
9023 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9024 key" (bug#4257).
9025
0cf34688
LMI
9026 * window.c (Fset_window_start): Doc fix (bug#4199).
9027 (Fset_window_hscroll): Ditto.
9028
270768cd
PE
90292011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9030
077e3dda 9031 Fix minor new problems caught by GCC 4.6.1.
270768cd 9032 * term.c (init_tty): Remove unused local.
490011a6 9033 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9034 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9035 not used otherwise.
270768cd 9036
b1f58454
CY
90372011-07-12 Chong Yidong <cyd@stupidchicken.com>
9038
9039 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9040
22b9578d
LMI
90412011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9042
6e70ab07
LMI
9043 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9044 are the mini-buffer and the echo area (bug#3320).
9045
22b9578d
LMI
9046 * term.c (init_tty): Remove support for supdup, c10 and perq
9047 terminals, which are no longer supported (bug#1482).
9048
8974cc9f
JB
90492011-07-10 Johan Bockgård <bojohan@gnu.org>
9050
9051 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9052
a560d974
JD
90532011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9054
9055 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9056 for non-popups (Bug#3642).
9057
1dae0f0a
AS
90582011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9059
268c2c36 9060 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9061 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9062 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9063 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9064 * data.c (fmod): Likewise.
9065 * dispnew.c (swap_glyphs_in_rows): Likewise.
9066 * emacs.c (memory_warning_signal): Likewise.
9067 * floatfns.c (float_error): Likewise.
9068 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9069 (otf_open, font_otf_capability, generate_otf_features)
9070 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9071 Likewise.
9072 * image.c (pbm_read_file): Likewise.
9073 * indent.c (string_display_width): Likewise.
9074 * intervals.c (check_for_interval, search_for_interval)
9075 (inc_interval_count, count_intervals, root_interval)
9076 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9077 * lread.c (defalias): Likewise.
268c2c36 9078 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9079 * regex.c (set_image_of_range_1, set_image_of_range)
9080 (regex_grow_registers): Likewise.
9081 * sysdep.c (strerror): Likewise.
9082 * termcap.c (valid_filename_p, tprint, main): Likewise.
9083 * tparam.c (main): Likewise.
9084 * unexhp9k800.c (run_time_remap, save_data_space)
9085 (update_file_ptrs, read_header, write_header, calculate_checksum)
9086 (copy_file, copy_rest, display_header): Likewise.
9087 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9088 Likewise.
9089 * xdisp.c (check_it): Likewise.
9090 * xfaces.c (register_color, unregister_color, unregister_colors):
9091 Likewise.
9092 * xfns.c (print_fontset_result): Likewise.
9093 * xrdb.c (member, fatal, main): Likewise.
9094
99033785
PE
90952011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9096
9097 Fix minor problems found by static checking (Bug#9031).
9098 * chartab.c (char_table_set_range, map_sub_char_table):
9099 Remove unused locals.
9100 (uniprop_table): Now static.
9101 * composite.c (_work_char): Remove unused static var.
9102
9cb2ac56
JB
91032011-07-09 Juanma Barranquero <lekktu@gmail.com>
9104
9105 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9106
f25661f0
JD
91072011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9108
9109 * gtkutil.c (qttip_cb): Remove code without function.
9110
8278c4fe
EZ
91112011-07-09 Eli Zaretskii <eliz@gnu.org>
9112
9113 * w32.c (pthread_sigmask): New stub.
9114
1692ae2d 91152011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9116
8a6ebd58 9117 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9118 sigprocmask is portable only for single-threaded applications, and
9119 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9120 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9121 (LIBES): Use it.
9122 * callproc.c (Fcall_process):
9123 * process.c (create_process):
9124 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9125 Use pthread_sigmask, not sigprocmask.
123403e4 9126
1b854618
JD
91272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9128
9129 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9130 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9131 wrong (Bug#8591).
9132
3fe4b549
JD
91332011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9134
0ce7e563
JD
9135 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9136 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9137 (xg_hide_tooltip): Fix comment.
9138
3fe4b549
JD
9139 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9140 in registerServicesMenuSendTypes.
9141 (validRequestorForSendType): Don't check ns_return_types.
9142
9143 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9144 ns_return_type.
9145
5df75e47
JR
91462011-07-08 Jason Rumney <jasonr@gnu.org>
9147
22610910
JR
9148 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9149 SH_SHOW for hidden windows (Bug#5482).
9150
5df75e47
JR
9151 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9152 frame struct members of non-existent frames (Bug#6284).
9153
699c10bd
JD
91542011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9155
4393663b
JD
9156 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9157 variable firstTime not needed on OSX >= 10.6.
9158 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9159 >= 10.5. Use setKnobProportion, setDoubleValue.
9160
9161 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9162 (MAC_OS_X_VERSION_10_5): Define if not defined.
9163 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9164 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9165 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9166
9167 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9168 cString and lossyCString on OSX >= 10.4.
4393663b 9169
58179cce 9170 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9171 sizeToFit on OSX >= 10.2.
9172
9173 * nsimage.m (allocInitFromFile): Don't use deprecated method
9174 bestRepresentationForDevice on OSX >= 10.6.
9175
9176 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9177 to avoid warning.
9178
9179 * emacs.c: Declare unexec_init_emacs_zone.
9180
a63e0781
JD
9181 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9182
699c10bd
JD
9183 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9184
9185 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9186 on svcsMenu (Bug#8842).
9187
9188 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9189 ns_return_types.
9190 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9191
9192 * nsterm.m (QUTF8_STRING): Declare.
9193 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9194 (validRequestorForSendType): Return type is (id).
9195 Change indexOfObjectIdenticalTo to indexOfObject.
9196 Check if we have local selection before returning self (Bug#8842).
9197 (writeSelectionToPasteboard): Put local selection into paste board
9198 if we have a local selection (Bug#8842).
9199 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9200
9201 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9202 (ns_get_local_selection): Declare.
9203
54e10184
LMI
92042011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9205
9888ff71
LMI
9206 * keymap.c (describe_map_tree): Don't insert a double newline at
9207 the end of the buffer (bug#1169) and return whether we inserted
9208 something.
9209
54e10184
LMI
9210 * callint.c (Fcall_interactively): Change "reading args" to
9211 "providing args" to try to clarify what it does (bug#1010).
9212
15fa4783
KH
92132011-07-07 Kenichi Handa <handa@m17n.org>
9214
9215 * composite.c (composition_compute_stop_pos): Ignore a static
9216 composition starting before CHARPOS (Bug#8915).
9217
9218 * xdisp.c (handle_composition_prop): Likewise.
9219
a8815b00
EZ
92202011-07-07 Eli Zaretskii <eliz@gnu.org>
9221
9222 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9223 (Bug#9015)
9224
ef7b981d 92252011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9226
9227 * character.h (unicode_category_t): New enum type.
9228
9229 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9230 (Qchar_code_property_table): New variable.
9231 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9232 (UNIPROP_COMPRESSED_FORM_P): New macros.
9233 (char_table_ascii): Uncompress the compressed values.
9234 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9235 Uncompress the compressed values.
ac389d0c 9236 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9237 (char_table_ref_and_range): Uncompress the compressed values.
9238 (sub_char_table_set): New arg is_uniprop. Callers changed.
9239 Uncompress the compressed values.
9240 (sub_char_table_set_range): Args changed. Callers changed.
9241 (char_table_set_range): Adjuted for the above change.
9242 (map_sub_char_table): Delete args default_val and parent. Add arg
9243 top. Give decoded values to a Lisp function.
640c8776 9244 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9245 values to a Lisp function. Gcpro more variables.
9246 (uniprop_table_uncompress)
9247 (uniprop_decode_value_run_length): New functions.
9248 (uniprop_decoder, uniprop_decoder_count): New variables.
9249 (uniprop_get_decoder, uniprop_encode_value_character)
9250 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9251 New functions.
9252 (uniprop_encoder, uniprop_encoder_count): New variables.
9253 (uniprop_get_encoder, uniprop_table)
9254 (Funicode_property_table_internal, Fget_unicode_property_internal)
9255 (Fput_unicode_property_internal): New functions.
9256 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9257 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9258 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9259 char-code-property-alist.
9260
640c8776 9261 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9262 Vunicode_category_table.
9263
640c8776 9264 * font.c (font_range): Adjust for the change of
c805dec0
KH
9265 Vunicode_category_table.
9266
76b397fb
DN
92672011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9268
9269 * m/iris4d.h: Remove file, move contents ...
9270 * s/irix6-5.h: ... here.
9271
22b4128e
PE
92722011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9273
9274 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9275 * alloc.c (mark_buffer):
9276 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9277 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9278 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9279 This isn't true in general, and it's particularly not true
9280 if Emacs is configured with --with-wide-int.
9281 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9282 New macros, used in the buffer.c change.
9283
869795d6
JD
92842011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9285
9286 * xsettings.c: Use both GConf and GSettings if both are available.
9287 (store_config_changed_event): Add comment.
9288 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9289 (store_tool_bar_style_changed): New functions.
5e617bc2 9290 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9291 (struct xsettings): Move font inside HAVE_XFT.
9292 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9293 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9294 Move inside HAVE_XFT.
640c8776 9295 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9296 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9297 also.
9298 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9299 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9300 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9301 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9302 (parse_settings): Move check for font inside HAVE_XFT.
9303 (read_settings, apply_xft_settings): Add comment.
9304 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9305 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9306 call store_font_name_changed.
9307 (xft_settings_event): Add comment.
9308 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9309 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9310 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9311 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9312 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9313 (xsettings_get_system_font, xsettings_get_system_normal_font):
9314 Add comment.
869795d6 9315
d8ed26bd
PE
93162011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9317
9318 Random fixes. E.g., (random) never returned negative values.
9319 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9320 subseconds part to the entropy, as that's a bit more random.
9321 Prefer signed to unsigned, since the signedness doesn't matter and
9322 in general we prefer signed. When given a limit, use a
9323 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9324 latter isn't right if USE_2_TAGS_FOR_INTS.
9325 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9326 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9327
cabf1cac
SM
93282011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9329
9330 * textprop.c (text_property_stickiness):
9331 Obey Vtext_property_default_nonsticky.
9332 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9333 * w32fns.c (syms_of_w32fns):
9334 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9335
6e9b2be9
PE
93362011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9337
9338 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9339 This is more efficient than Ffile_directory_p and avoids a minor race.
9340
90186c68
LMI
93412011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9342
7c301272
LMI
9343 * buffer.c (Foverlay_put): Say what the return value is
9344 (bug#7835).
9345
c4f2d8d4
LMI
9346 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9347 is a directory before asking whether to use the file name
9348 (bug#7564).
ad637907
LMI
9349 (barf_or_query_if_file_exists): Make the "File is a directory"
9350 error be more correct.
c4f2d8d4 9351
90186c68
LMI
9352 * fns.c (Frequire): Remove the mention of the .gz files, since
9353 that's installation-specific, but keep the mention of
9354 `get-load-suffixes'.
9355
da64016e
PE
93562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9357
9358 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9359 Report string overflow if the output is too long.
9360
7d47b580
JB
93612011-07-04 Juanma Barranquero <lekktu@gmail.com>
9362
a555cb87
JB
9363 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9364 (syms_of_gnutls): Remove duplicate DEFSYM for
9365 Qgnutls_bootprop_verify_hostname_error, an error for
9366 Qgnutls_bootprop_verify_error (which is no longer used).
9367
7d47b580
JB
9368 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9369 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9370 Also (re)move comments that are misplaced or no longer relevant.
9371
1e49bfab
LMI
93722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9373
9374 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9375
1485f4c0
CY
93762011-07-03 Chong Yidong <cyd@stupidchicken.com>
9377
9378 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9379 and background color parameters if they have been changed.
9380
a9ab721e
LMI
93812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9382
9383 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9384
cf7cff57
PE
93852011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9386
2e13213d
PE
9387 * xsettings.c (SYSTEM_FONT): Define only when used.
9388 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9389
cf7cff57
PE
9390 * keymap.c (access_keymap_1): Now static.
9391
7a8e04f7
CY
93922011-07-02 Chong Yidong <cyd@stupidchicken.com>
9393
9394 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9395 leave any prefix arg for the up event (Bug#1586).
9396
61352f62
LMI
93972011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9398
69bb1ef7
LMI
9399 * lread.c (syms_of_lread): Mention single symbols defined by
9400 `defvar' or `defconst' (bug#7154).
9401
61352f62 9402 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9403 (Frequire): Mention get-load-suffixes.
61352f62 9404
28545e04
MR
94052011-07-02 Martin Rudalics <rudalics@gmx.at>
9406
9407 * window.h (window): Remove clone_number slot.
9408 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9409 Remove.
9410 (make_parent_window, make_window, saved_window)
9411 (Fset_window_configuration, save_window_save): Don't deal with
9412 clone numbers.
9413 * buffer.c (Qclone_number): Remove declaration.
9414 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9415
3349e122
SM
94162011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9417
9418 Add multiple inheritance to keymaps.
9419 * keymap.c (Fmake_composed_keymap): New function.
9420 (Fset_keymap_parent): Simplify.
9421 (fix_submap_inheritance): Remove.
9422 (access_keymap_1): New function extracted from access_keymap to handle
9423 embedded parents and handle lists of maps.
9424 (access_keymap): Use it.
9425 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9426 (Fcopy_keymap): Handle embedded parents.
9427 (Fcommand_remapping, define_as_prefix): Simplify.
9428 (Fkey_binding): Simplify.
9429 (syms_of_keymap): Move minibuffer-local-completion-map,
9430 minibuffer-local-filename-completion-map,
9431 minibuffer-local-must-match-map, and
9432 minibuffer-local-filename-must-match-map to Elisp.
9433 (syms_of_keymap): Defsubr make-composed-keymap.
9434 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9435 (parse_menu_item): Trivial simplification.
9436
3279eb87
GM
94372011-07-01 Glenn Morris <rgm@gnu.org>
9438
9439 * Makefile.in (SETTINGS_LIBS): Fix typo.
9440
4550efdf
KI
94412011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9442
9443 * coding.c (Fencode_coding_string): Record the last coding system
9444 used, as the function doc string says (bug#8738).
9445
0949d2b6
JD
94462011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9447
9448 * xsettings.c (store_monospaced_changed): Take new font as arg and
9449 check for change against current_mono_font.
9450 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9451 (emacs_settings_constructor, emacs_settings_get_property)
9452 (emacs_settings_set_property, emacs_settings_class_init)
9453 (emacs_settings_init, gsettings_obj): Remove.
9454 (something_changedCB): New function for HAVE_GSETTINGS.
9455 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9456 with value as argument.
9457 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9458 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9459 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9460 "changed".
9461
9462 * xgselect.c: Add defined (HAVE_GSETTINGS).
9463 (xgselect_initialize): Ditto.
9464
9465 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9466 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9467 xg_select.
9468
bbc6b304
PE
94692011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9470
9471 * eval.c (struct backtrace): Simplify and port the data structure.
9472 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9473 signed bit field, as this assumption is not portable and it makes
9474 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9475 "char debug_on_exit : 1" as this is not portable either; instead,
9476 use the portable "unsigned int debug_on_exit : 1". Remove unused
9477 member evalargs. Remove obsolete comments about cc bombing out.
9478
9851bfc5
JD
94792011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9480
51bb811f 9481 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9482 Let HAVE_GSETTINGS override HAVE_GCONF.
9483 (store_monospaced_changed): New function.
9484 (EMACS_SETTINGS): A new type derived from GObject to handle
9485 GSettings notifications.
9486 (emacs_settings_constructor, emacs_settings_get_property)
9487 (emacs_settings_set_property, emacs_settings_class_init):
9488 New functions.
9489 (gsettings_client, gsettings_obj): New variables.
9490 (GSETTINGS_SCHEMA): New define.
9491 (something_changedCB): Call store_monospaced_changed.
9492 (init_gsettings): New function.
9493 (xsettings_initialize): Call init_gsettings.
9494 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9495 to NULL.
9496
640c8776 9497 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9498 GCONF_CFLAGS/LIBS.
9499
5386012d
MR
95002011-06-29 Martin Rudalics <rudalics@gmx.at>
9501
9502 * window.c (resize_root_window, grow_mini_window)
9503 (shrink_mini_window): Rename Qresize_root_window to
9504 Qwindow_resize_root_window and Qresize_root_window_vertically to
9505 Qwindow_resize_root_window_vertically.
9506
f13e0b08
PE
95072011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9508
9509 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9510
94515237
JB
95112011-06-27 Juanma Barranquero <lekktu@gmail.com>
9512
9513 * makefile.w32-in: Redesign dependencies so they reflect more
9514 clearly which files are directly included by each source file,
9515 and not through other includes.
9516
e43b6e43
MR
95172011-06-27 Martin Rudalics <rudalics@gmx.at>
9518
9519 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9520 (sort_overlays, overlay_strings): When an overlay's clone number
9521 matches the window's clone number process the overlay even if
9522 the overlay's window property doesn't match the current window.
9523
d68443dc
MR
9524 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9525 (Fwindow_hchild): Rename to Fwindow_left_child.
9526 (Fwindow_next): Rename to Fwindow_next_sibling.
9527 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9528 (resize_window_check): Rename to window_resize_check.
9529 (resize_window_apply): Rename to window_resize_apply.
9530 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9531 (Fdelete_other_windows_internal, resize_frame_windows)
9532 (Fsplit_window_internal, Fdelete_window_internal)
9533 (grow_mini_window, shrink_mini_window)
9534 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9535
c7e73be5
JD
95362011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9537
9538 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9539 (emacs_fixed_set_min_size): Remove.
9540 (emacs_fixed_new): Take frame as argument.
9541
9542 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9543 (_EmacsFixedPrivate): Remove minwidth/height.
9544 Add struct frame *f.
9545 (emacs_fixed_init): Initialize priv->f.
9546 (get_parent_class, emacs_fixed_set_min_size): Remove.
9547 (emacs_fixed_new): Set priv->f to argument.
9548 (emacs_fixed_get_preferred_width)
9549 (emacs_fixed_get_preferred_height): Use min_width/height from
9550 frames size_hint to set minimum and natural (Bug#8919).
9551 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9552 and use min_width/height from frames size_hint to set
9553 min_width/height (Bug#8919).
9554
9555 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9556 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9557 Fix indentation.
c7e73be5 9558
cf99dcf8
EZ
95592011-06-26 Eli Zaretskii <eliz@gnu.org>
9560
9561 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9562 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9563 called at ZV.
9564
029529ac
CY
95652011-06-26 Chong Yidong <cyd@stupidchicken.com>
9566
9567 * process.c (wait_reading_process_output): Bypass select if
9568 waiting for a cell while ignoring keyboard input, and input is
9569 pending. Suggested by Jan Djärv (Bug#8869).
9570
7a7ef429
PE
95712011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9572
9573 Use gnulib's dup2 module instead of rolling our own.
9574 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9575
11fdef7d 95762011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9577
9578 * dispnew.c (scrolling_window): Before scrolling, turn off a
9579 mouse-highlight in the window being scrolled.
9580
cd3520a4
JB
95812011-06-24 Juanma Barranquero <lekktu@gmail.com>
9582
9583 Move DEFSYM to lisp.h and use everywhere.
9584
9585 * character.h (DEFSYM): Move declaration...
9586 * lisp.h (DEFSYM): ...here.
9587
9588 * gnutls.c:
9589 * minibuf.c:
9590 * w32menu.c:
9591 * w32proc.c:
9592 * w32select.c: Don't include character.h.
9593
9594 * alloc.c (syms_of_alloc):
9595 * buffer.c (syms_of_buffer):
9596 * bytecode.c (syms_of_bytecode):
9597 * callint.c (syms_of_callint):
9598 * casefiddle.c (syms_of_casefiddle):
9599 * casetab.c (init_casetab_once):
9600 * category.c (init_category_once, syms_of_category):
9601 * ccl.c (syms_of_ccl):
9602 * cmds.c (syms_of_cmds):
9603 * composite.c (syms_of_composite):
9604 * dbusbind.c (syms_of_dbusbind):
9605 * dired.c (syms_of_dired):
9606 * dispnew.c (syms_of_display):
9607 * doc.c (syms_of_doc):
9608 * editfns.c (syms_of_editfns):
9609 * emacs.c (syms_of_emacs):
9610 * eval.c (syms_of_eval):
9611 * fileio.c (syms_of_fileio):
9612 * fns.c (syms_of_fns):
9613 * frame.c (syms_of_frame):
9614 * fringe.c (syms_of_fringe):
9615 * insdel.c (syms_of_insdel):
9616 * keymap.c (syms_of_keymap):
9617 * lread.c (init_obarray, syms_of_lread):
9618 * macros.c (syms_of_macros):
9619 * msdos.c (syms_of_msdos):
9620 * print.c (syms_of_print):
9621 * process.c (syms_of_process):
9622 * search.c (syms_of_search):
9623 * sound.c (syms_of_sound):
9624 * syntax.c (init_syntax_once, syms_of_syntax):
9625 * terminal.c (syms_of_terminal):
9626 * textprop.c (syms_of_textprop):
9627 * undo.c (syms_of_undo):
9628 * w32.c (globals_of_w32):
9629 * window.c (syms_of_window):
9630 * xdisp.c (syms_of_xdisp):
9631 * xfaces.c (syms_of_xfaces):
9632 * xfns.c (syms_of_xfns):
9633 * xmenu.c (syms_of_xmenu):
9634 * xsettings.c (syms_of_xsettings):
9635 * xterm.c (syms_of_xterm): Use DEFSYM.
9636
4228cf16
TZ
96372011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9638
cd3520a4 9639 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9640
7fcccf1e
PE
96412011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9642
7efb4e0e
PE
9643 Integer and buffer overflow fixes (Bug#8873).
9644
ff5844ad
PE
9645 * print.c (printchar, strout): Check for string overflow.
9646 (PRINTPREPARE, printchar, strout):
9647 Don't set size unless allocation succeeds.
9648
90532f02
PE
9649 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9650 for sizes. Check for string overflow more accurately.
9651 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9652
6d84508d
PE
9653 * macros.c: Integer and buffer overflow fixes.
9654 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9655 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9656 Use ptrdiff_t, not int, for sizes.
9657 Don't increment bufsize until after realloc succeeds.
9658 Check for size-calculation overflow.
9659 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9660
437b2cb4
PE
9661 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9662
8b9ac8b4
PE
9663 * lread.c: Integer overflow fixes.
9664 (read_integer): Radix is now EMACS_INT, not int,
9665 to improve quality of diagnostics for out-of-range radices.
9666 Calculate buffer size correctly for out-of-range radices.
9667 (read1): Check for integer overflow in radices, and in
9668 read-circle numbers.
82cb60d3
PE
9669 (read_escape): Avoid int overflow.
9670 (Fload, openp, read_buffer_size, read1)
9671 (substitute_object_recurse, read_vector, read_list, map_obarray):
9672 Use ptrdiff_t, not int, for sizes.
9673 (read1): Use EMACS_INT, not int, for sizes.
20270765 9674 Check for size overflow.
8b9ac8b4 9675
7fcccf1e
PE
9676 * image.c (cache_image): Check for size arithmetic overflow.
9677
bfbbd7e7
PE
9678 * lread.c: Integer overflow issues.
9679 (saved_doc_string_size, saved_doc_string_length)
9680 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9681 Now ptrdiff_t, not int.
9682 (read1): Don't assume doc string length fits in int. Check for
9683 out-of-range doc string lengths.
9684 (read_list): Don't assume file position fits in int.
39019e54 9685 (read_escape): Check for hex character overflow.
bfbbd7e7 9686
4e323265
LL
96872011-06-22 Leo Liu <sdl.web@gmail.com>
9688
9689 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9690 Move to minibuffer.el.
9691
85fece3e
PE
96922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9693
20b84ce9 9694 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9695 The following patches are for when GLYPH_DEBUG && !XASSERT.
9696 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9697 * dispnew.c (flush_stdout):
9698 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9699 Mark as externally visible.
9700 * dispnew.c (check_window_matrix_pointers): Now static.
9701 * dispnew.c (window_to_frame_vpos):
9702 * xfns.c (unwind_create_frame):
9703 * xterm.c (x_check_font): Remove unused local.
9704 * scroll.c (CHECK_BOUNDS):
9705 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9706 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9707 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9708 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9709 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9710 Now static.
9711 (debug_method_add): Use va_list and vsprintf rather than relying
9712 on undefined behavior with wrong number of arguments.
9713 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9714 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9715 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9716 since we're not interested in debugging glyphs with old libraries.
9717 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9718 GCC 4.6.0's static checking.
9719
0766b489
PE
97202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9721
31fd4b32
PE
9722 Integer overflow and signedness fixes (Bug#8873).
9723 A few related buffer overrun fixes, too.
9724
b79e8648
PE
9725 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9726
0766b489
PE
9727 * dispextern.h (struct face.stipple):
9728 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9729 (x_bitmap_mask, x_allocate_bitmap_record)
9730 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9731 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9732 (x_create_bitmap_from_xpm_data):
9733 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9734 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9735 (.bitmaps_last):
9736 * xfaces.c (load_pixmap):
9737 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9738 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9739 (.bitmaps_last, struct x_output.icon_bitmap):
9740 Use ptrdiff_t, not int, for bitmap indexes.
9741 (x_allocate_bitmap_record): Check for size overflow.
9742 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9743
b081724f
PE
9744 Use ptrdiff_t, not int, for overlay counts.
9745 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9746 * editfns.c (overlays_around, get_pos_property):
9747 * textprop.c (get_char_property_and_overlay):
9748 * xdisp.c (next_overlay_change, note_mouse_highlight):
9749 * xfaces.c (face_at_buffer_position):
21514da7
PE
9750 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9751 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9752 (Fnext_overlay_change, Fprevious_overlay_change)
9753 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9754 Use ptrdiff_t, not int, for sizes.
21514da7 9755 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9756
3de73e5e
PE
9757 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9758
2606c57b
PE
9759 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9760 (x_session_initialize): Do not assume string length fits in int.
9761
aaafe47a
PE
9762 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9763 This is unlikely, but can occur if DPI is outlandish.
9764
2674ddc8 9765 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9766 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9767
28154962
PE
9768 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9769 * xrdb.c (magic_file_p, search_magic_path):
9770 Omit last arg SUFFIX; it was always 0. All callers changed.
9771 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9772
7de51af5
PE
9773 * xfont.c (xfont_match): Avoid need for strlen.
9774
25ed6cc3
PE
9775 * xfns.c: Don't assume strlen fits in int.
9776 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9777
4eab31dd
PE
9778 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9779 not unsigned long, as we prefer signed integers. All callers changed.
9780 Detect integer overflow in repeat count.
9781 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9782 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9783
171e2a58
PE
9784 * termcap.c: Don't assume sizes fit in int and never overflow.
9785 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9786 (gobble_line): Check for size-calculation overflow.
9787
ad39faca 9788 * minibuf.c (Fread_buffer):
6e5bb2dc 9789 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9790 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9791 Don't assume string length fits in int.
9792
52c61c22 9793 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9794 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9795
b5b8c9e5
PE
9796 * font.c: Don't assume string length fits in int.
9797 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9798 Use ptrdiff_t, not int.
ccd6111c
PE
9799 (font_intern_prop): Don't assume string length fits in int.
9800 Don't assume integer property fits in fixnum.
9801 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9802
882f0d81 9803 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9804 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9805 Reformulate so as not to need the command string.
9806 Invoke gzip -cd rather than gunzip, as it's more portable.
9807 (lock_info_type, lock_file_1, lock_file):
9808 Don't assume pid_t and time_t fit in unsigned long.
9809 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9810 (current_lock_owner): Prefer signed type for sizes.
9811 Use memcpy, not strncpy, where memcpy is what is really wanted.
9812 Don't assume (via atoi) that time_t and pid_t fit in int.
9813 Check for time_t and/or pid_t out of range, e.g., via a network share.
9814 Don't alloca where an auto var works fine.
9815
93f4cf88
PE
9816 * fileio.c: Fix some integer overflow issues.
9817 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9818 Don't assume string length fits in int.
9819 (directory_file_name): Don't assume string length fits in long.
9820 (make_temp_name): Don't assume pid fits in int, or that its print
9821 length is less than 20.
9822
f3e92b69
PE
9823 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9824
1bfdaf10
PE
9825 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9826
35016e9a
PE
9827 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9828
3d1e65a1
PE
9829 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9830 We prefer signed integers, even for size calculations.
9831
0b963a93
PE
9832 * emacs.c: Don't assume string length fits in 'int'.
9833 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9834 (main): Don't invoke strlen when not needed.
9835
573f4b54
PE
9836 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9837 (XD_DEBUG_MESSAGE): Don't waste a byte.
9838
989f33ba
PE
9839 * callproc.c (getenv_internal_1, getenv_internal)
9840 (Fgetenv_internal):
965d34eb
PE
9841 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9842
e4d29b33
PE
9843 * lread.c (invalid_syntax): Omit length argument.
9844 All uses changed. This doesn't fix a bug, but it simplifies the
9845 code away from its former Hollerith-constant appearance, and it's
9846 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9847 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9848
eb49b136
PE
9849 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9850 This didn't break anything, but it didn't help either.
9851 It's confusing to put a bogus integer in a place where the actual
9852 value does not matter.
9f62aeb1 9853 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9854 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9855
15375a22
PE
9856 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9857 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9858 implementation.
b61cc01c
PE
9859 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9860 We prefer signed types, and the value cannot exceed the EMACS_INT
9861 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9862 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9863 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9864 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9865
53b2623d
PE
9866 * indent.c (sane_tab_width): New function.
9867 (current_column, scan_for_column, Findent_to, position_indentation)
9868 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9869 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9870
51cab52b 9871 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9872
f2ed8a70
PE
9873 * lisp.h (lint_assume): New macro.
9874 * composite.c (composition_gstring_put_cache):
9875 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9876
abe80cc6
PE
9877 * editfns.c, insdel.c:
9878 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9879
b02c740e
PE
9880 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9881
ebc96716
PE
9882 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9883
b4e50fa0 9884 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9885 Use much-faster test for byte-length change.
311d5d7c 9886 Don't assume string byte-length fits in 'int'.
a4cf38e4 9887 Check that character arg fits in 'int'.
85461888 9888 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9889
c0c1ee9f
PE
9890 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9891
a498d7f4
PE
9892 * fns.c (concat): Catch string overflow earlier.
9893 Do not rely on integer wraparound.
9894
51cab52b
PE
9895 * dispextern.h (struct it.overlay_strings_charpos)
9896 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9897 * xdisp.c (forward_to_next_line_start)
9898 (back_to_previous_visible_line_start)
9899 (reseat_at_next_visible_line_start, next_element_from_buffer):
9900 Don't arbitrarily truncate the value of 'selective' to int.
9901
76031fad
PE
9902 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9903
5eb55db9
PE
9904 * composite.c: Don't truncate sizes to 'int'.
9905 (composition_gstring_p, composition_reseat_it)
9906 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9907 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9908 not EMACS_UINT, for indexes.
5eb55db9 9909
0703a717
PE
9910 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9911
d6202519
PE
9912 * buffer.c: Include <verify.h>.
9913 (struct sortvec.priority, struct sortstr.priority):
8961a454 9914 Now EMACS_INT, not int.
c20998a7 9915 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9916 (struct sortstr.size, record_overlay_string)
9917 (struct sortstrlist.size, struct sortlist.used):
9918 Don't truncate size to int.
9919 (record_overlay_string): Check for size-calculation overflow.
d6202519 9920 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9921
d5a19415
JM
99222011-06-22 Jim Meyering <meyering@redhat.com>
9923
029529ac 9924 Don't leak an XBM-image-sized buffer
d5a19415
JM
9925 * image.c (xbm_load): Free the image buffer after using it.
9926
a9041e6c
PE
99272011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9928
9929 Port to Sun C.
9930 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9931 that Sun C diagnosed.
9932 * fns.c (secure_hash): Fix pointer signedness issue.
9933 * intervals.c (static_offset_intervals): New function.
9934 (offset_intervals): Use it.
9935
7f3f739f
LL
99362011-06-21 Leo Liu <sdl.web@gmail.com>
9937
9938 * deps.mk (fns.o):
9939 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9940 sha512.h.
9941
9942 * fns.c (secure_hash): Rename from crypto_hash_function and change
9943 the first arg to accept symbols.
5b66d427 9944 (Fsecure_hash): New primitive.
7f3f739f
LL
9945 (syms_of_fns): New symbols.
9946
76147d94
DD
99472011-06-20 Deniz Dogan <deniz@dogan.se>
9948
9949 * process.c (Fset_process_buffer): Clarify return value in
9950 docstring.
9951
7d7d0045
CY
99522011-06-18 Chong Yidong <cyd@stupidchicken.com>
9953
9954 * dispnew.c (add_window_display_history): Use BVAR.
9955
9956 * xdisp.c (debug_method_add): Use BVAR.
9957 (check_window_end, dump_glyph_matrix, dump_glyph)
9958 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9959
9960 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9961 Likewise.
9962
9963 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9964 check till after the cache is created in init_frame_faces.
9965
ff2bc410
SM
99662011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9967
9968 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9969
28177add
PE
99702011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9971
dd3482fe
PE
9972 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9973 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9974 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9975
393d71f3 9976 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9977 * fileio.c (Finsert_file_contents):
9978 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9979 Remove the old (too-loose) buffer overflow checks.
9980 They weren't needed, since make_gap checks for buffer overflow.
9981 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9982 The old code merely checked for Emacs fixnum overflow, and relied
9983 on undefined (wraparound) behavior. The new code avoids undefined
9984 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9985
2e6813b0 9986 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9987 Tune. Don't use wider integers than needed. Don't use alloca.
9988 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9989
599a9e4f
PE
9990 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9991
99561444
PE
9992 * insdel.c, lisp.h (buffer_overflow): New function.
9993 (insert_from_buffer_1, replace_range, replace_range_2):
9994 * insdel.c (make_gap_larger):
9995 * editfns.c (Finsert_char):
9996 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9997
28177add
PE
9998 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9999
e69dafad
PE
100002011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10001
4baa020d 10002 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10003
b1c46f02
PE
10004 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10005 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10006
e69dafad
PE
10007 * fileio.c: Don't assume EMACS_INT fits in off_t.
10008 (emacs_lseek): New static function.
10009 (Finsert_file_contents, Fwrite_region): Use it.
10010 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10011
566684ea
PE
10012 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10013
e6966cd6
PE
10014 * fns.c: Don't overflow int when computing a list length.
10015 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10016 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10017 truncation on 64-bit hosts. Check for QUIT every
10018 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10019 faster and is responsive enough.
10020 (Flength): Report an error instead of overflowing an integer.
10021 (Fsafe_length): Return a float if the value is not representable
10022 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10023 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10024 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10025
dd0b0efb
PE
10026 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10027 (header_size, word_size): New constants.
10028 (allocate_vectorlike): Don't check size overflow here.
10029 (allocate_vector): Check it here instead, since this is the only
10030 caller of allocate_vectorlike that could cause overflow.
10031 Check that the new vector's length is representable as a fixnum.
10032
86fe5cfe
PE
10033 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10034 The previous code was bogus. For example, next_almost_prime (32)
10035 returned 39, which is undesirable as it is a multiple of 3; and
10036 next_almost_prime (24) returned 25, which is a multiple of 5 so
10037 why was the code bothering to check for multiples of 7?
10038
80e88859
PE
10039 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10040
4a2f0ad6
PE
10041 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10042
f66c7cf8
PE
10043 Variadic C functions now count arguments with ptrdiff_t.
10044 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10045 Back then I didn't know that the Emacs coding style prefers signed int.
10046 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10047 were being counted with int, which may truncate counts on 64-bit
10048 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10049 * lisp.h (struct Lisp_Subr.function.aMANY)
10050 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10051 Arg counts are now ptrdiff_t, not size_t.
10052 All variadic functions and their callers changed accordingly.
10053 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10054 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10055 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10056 * callint.c (Fcall_interactively): Check arg count for overflow,
10057 to avoid potential buffer overrun. Use signed char, not 'int',
10058 for 'varies' array, so that we needn't bother to check its size
10059 calculation for overflow.
10060 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10061 * eval.c (apply_lambda):
10062 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10063 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10064 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10065
a1759b76
PE
10066 * callint.c (Fcall_interactively): Don't use index var as event count.
10067
d96be9fc
PE
10068 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10069 * mem-limits.h (SIZE): Remove; no longer used.
10070
a690a978 10071 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10072
578c21e6
PE
10073 Remove unnecessary casts.
10074 * xterm.c (x_term_init):
10075 * xfns.c (x_set_border_pixel):
10076 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10077 These aren't needed now that we assume ANSI C.
10078
96f53c6c
PE
10079 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10080 It's more likely to cause problems (due to unsigned overflow)
10081 than to cure them.
10082
83c77d31
PE
10083 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10084
ee2079f1
PE
10085 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10086
6da65536
PE
10087 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10088
7147c4a4
PE
10089 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10090
193e32d9
PE
10091 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10092
e5533da6
PE
10093 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10094
9910e595
PE
10095 GLYPH_CODE_FACE returns EMACS_INT, not int.
10096 * dispextern.h (merge_faces):
10097 * xfaces.c (merge_faces):
01103c44
PE
10098 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10099 Don't assume EMACS_INT fits in int.
9910e595 10100
2638320e
PE
10101 * character.h (CHAR_VALID_P): Remove unused parameter.
10102 * fontset.c, lisp.h, xdisp.c: All uses changed.
10103
045eb8d9
PE
10104 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10105
c1f134b5
PE
10106 * fns.c (concat): Minor tuning based on overflow analysis.
10107 This doesn't fix any bugs. Use int to hold character, instead
10108 of constantly refetching from Emacs object. Use XFASTINT, not
10109 XINT, for value known to be a character. Don't bother comparing
10110 a single byte to 0400, as it's always less.
10111
395fcb93 10112 * floatfns.c (Fexpt):
327eeec8
PE
10113 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10114
abbd3d23
PE
10115 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10116 for characters.
10117
684a03ef
PE
10118 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10119
0fed43f3
PE
10120 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10121 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10122 incorrectly succeed when S was a string, because 4294967386 was
10123 truncated before it was used.
10124
8fd02eb7
PE
10125 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10126 Otherwise, an out-of-range integer could cause undefined behavior
10127 on a 64-bit host.
10128
f8c86b69
PE
10129 * composite.c: Use int, not EMACS_INT, for characters.
10130 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10131 EMACS_INT, for values that are known to be in character range.
10132 This doesn't fix any bugs but is the usual style inside Emacs and
10133 may generate better code on 32-bit machines.
10134
34206dd2
PE
10135 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10136 This is for reasons similar to the recent CHAR_STRING fix.
10137 * charset.c (Fencode_char): Check that character arg is actually
10138 a character. Pass an int to ENCODE_CHAR.
10139 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10140 wider than 'int', as a compile-time check to prevent future regressions
10141 in this area.
10142
c5958d4c 10143 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10144
10145 Make sure a 64-bit char is never passed to CHAR_STRING.
10146 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10147 by silently ignoring the top 32 bits, allowing some values
10148 that were far too large to be valid characters.
10149 * character.h: Include <verify.h>.
10150 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10151 arguments are no wider than unsigned, as a compile-time check
10152 to prevent future regressions in this area.
10153 * data.c (Faset):
01103c44 10154 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10155 (Fsubst_char_in_region):
10156 * fns.c (concat):
10157 * xdisp.c (decode_mode_spec_coding):
10158 Adjust to CHAR_STRING's new requirement.
10159 * editfns.c (Finsert_char, Fsubst_char_in_region):
10160 * fns.c (concat): Check that character args are actually
10161 characters. Without this test, these functions did the wrong
10162 thing with wildly out-of-range values on 64-bit hosts.
10163
d37ca623
PE
10164 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10165 These casts should not be needed on 32-bit hosts, either.
10166 * keyboard.c (read_char):
10167 * lread.c (Fload): Remove casts to unsigned.
10168
ea204efb
PE
10169 * lisp.h (UNSIGNED_CMP): New macro.
10170 This fixes comparison bugs on 64-bit hosts.
10171 (ASCII_CHAR_P): Use it.
10172 * casefiddle.c (casify_object):
01103c44 10173 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10174 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10175 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10176 * dispextern.h (FACE_FROM_ID):
10177 * keyboard.c (read_char): Use UNSIGNED_CMP.
10178
41cb286c
PE
10179 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10180 not to EMACS_INT, to avoid GCC warning.
10181
4a1b9832
PE
10182 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10183
55daad71
PE
10184 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10185 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10186 isn't needed on 32-bit machines.
8f95c75c 10187
01103c44
PE
10188 * buffer.c (Fgenerate_new_buffer_name):
10189 Use EMACS_INT for count, not int.
0ceccced 10190 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10191
10192 * data.c (Qcompiled_function): Now static.
10193
c6f072e7
PE
10194 * window.c (window_body_lines): Now static.
10195
20ce5912
PE
10196 * image.c (gif_load): Rename local to avoid shadowing.
10197
9c4c5f81
PE
10198 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10199 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10200 * alloc.c (make_save_value): Integer argument is now of type
10201 ptrdiff_t, not int.
10202 (mark_object): Use ptrdiff_t, not int.
10203 * lisp.h (pD): New macro.
10204 * print.c (print_object): Use it.
10205
c0c5c8ae
PE
10206 * alloc.c: Use EMACS_INT, not int, to count objects.
10207 (total_conses, total_markers, total_symbols, total_vector_size)
10208 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10209 (total_free_floats, total_floats, total_free_intervals)
10210 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10211 Now EMACS_INT, not int. All uses changed.
10212 (Fgarbage_collect): Compute overall total using a double, so that
10213 integer overflow is less likely to be a problem. Check for overflow
10214 when converting back to an integer.
5a25e253
PE
10215 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10216 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10217 These were 'int' variables that could overflow on 64-bit hosts;
10218 they were never used, so remove them instead of repairing them.
211a0b2a 10219 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10220 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10221 Previously, this ceilinged at INT_MAX, but that doesn't work on
10222 64-bit machines.
e46bb31a 10223 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10224
c78baabf 10225 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10226 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10227 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10228 when a (possibly-narrower) signed value would do just as well.
10229 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10230
c9d624c6
PE
10231 * alloc.c: Catch some string size overflows that we were missing.
10232 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10233 for convenience in STRING_BYTES_MAX.
10234 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10235 The definition here is exact; the one in lisp.h was approximate.
10236 (allocate_string_data): Check for string overflow. This catches
10237 some instances we weren't catching before. Also, it catches
10238 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10239 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10240 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10241
c9d624c6
PE
10242 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10243 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10244 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10245
353032ce
PE
10246 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10247
2bccce07
PE
10248 * alloc.c (Fmake_string): Check for out-of-range init.
10249
0ac30604
SM
102502011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10251
10252 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10253
c195f2de
JD
102542011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10255
10256 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10257 xg_get_default_scrollbar_width.
10258
10259 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10260 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10261 (style_changed_cb): Call update_theme_scrollbar_width and call
10262 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10263 all frames (Bug#8505).
10264 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10265 Call gtk_window_set_resizable if HAVE_GTK3.
10266 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10267 and height if HAVE_GTK3 (Bug#8505).
10268 (scroll_bar_width_for_theme): New variable.
10269 (update_theme_scrollbar_width): New function.
10270 (xg_get_default_scrollbar_width): Move code to
10271 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10272 (xg_initialize): Call update_theme_scrollbar_width.
10273
10274 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10275
10276 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10277
e10ac9f1
MR
102782011-06-12 Martin Rudalics <rudalics@gmx.at>
10279
10280 * frame.c (make_frame): Call other_buffer_safely instead of
10281 other_buffer.
10282
10283 * window.c (temp_output_buffer_show): Call display_buffer with
10284 second argument Vtemp_buffer_show_specifiers and reset latter
10285 immediately after the call.
10286 (Vtemp_buffer_show_specifiers): New variable.
10287 (auto_window_vscroll_p, next_screen_context_lines)
10288 (Vscroll_preserve_screen_position): Remove leading asterisks from
10289 doc-strings.
10290
2d3c217e 102912011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10292
7b7f97e8 10293 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10294 * buffer.c (Qclone_number): Remove for now, as it's unused.
10295 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10296 (record_buffer): Remove unused local.
10297 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10298 (set_frame_buffer_list): Remove; unused.
10299 * frame.h (other_visible_frames): Remove decl.
10300 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10301 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10302 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10303 if HAVE_GPM.
10304 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10305 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10306 Define only if HAVE_GPM.
10307 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10308 (update_hints_inhibit): Remove; never set. All uses removed.
10309 * widgetprv.h (emacsFrameClassRec): Remove decl.
10310 * window.c (delete_deletable_window): Now returns void, since it
10311 wasn't returning anything.
10312 (compare_window_configurations): Remove unused locals.
10313 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10314 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10315 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10316 the same widths as pointers. This follows up on the 2011-05-06 patch.
10317 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10318 * xterm.h: Likewise.
10319 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10320
1384b89e
JB
103212011-06-12 Juanma Barranquero <lekktu@gmail.com>
10322
10323 * makefile.w32-in: Update dependencies.
10324 (LISP_H): Add lib/intprops.h.
10325
1100a63c
CY
103262011-06-11 Chong Yidong <cyd@stupidchicken.com>
10327
10328 * image.c (gif_load): Add animation frame delay to the metadata.
10329 (syms_of_image): Use DEFSYM. New symbol `delay'.
10330
6198ccd0
MR
103312011-06-11 Martin Rudalics <rudalics@gmx.at>
10332
10333 * window.c (delete_deletable_window): Re-add.
10334 (Fset_window_configuration): Rewrite to handle dead buffers and
10335 consequently deletable windows.
10336 (window_tree, Fwindow_tree): Remove. Supply functionality in
10337 window.el.
10338 (compare_window_configurations): Simplify code.
10339
b6e3633c
AS
103402011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10341
1ab0dee5
AS
10342 * image.c (imagemagick_load_image): Fix type mismatch.
10343 (Fimagemagick_types): Likewise.
10344
b6e3633c
AS
10345 * window.h (replace_buffer_in_windows): Declare.
10346
9397e56f
MR
103472011-06-11 Martin Rudalics <rudalics@gmx.at>
10348
10349 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10350 Qclone_number. Remove external declaration of Qdelete_window.
10351 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10352 code.
640c8776
SM
10353 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10354 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10355 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10356 buffer list implementation.
10357 (other_buffer_safely): New function.
10358 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10359 calls to replace_buffer_in_windows and
10360 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10361 if allowed.
10362 (record_buffer): Inhibit quitting and rewrite using quittable
10363 functions. Run Qbuffer_list_update_hook if allowed.
10364 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10365 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10366 Move switch-to-buffer to window.el.
9397e56f
MR
10367 (bury-buffer): Move to window.el.
10368 (Vbuffer_list_update_hook): New variable.
10369
10370 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10371 section.
10372
10373 * window.h (resize_frame_windows): Move up in code.
10374 (Fwindow_frame): Remove EXFUN.
10375 (replace_buffer_in_all_windows): Remove prototype.
10376 (replace_buffer_in_windows_safely): Add prototype.
10377
10378 * window.c: Declare Qdelete_window static again. Move down
10379 declaration of select_count.
10380 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10381 (Fother_window): Move to window.el.
10382 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10383 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10384 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10385 window.el.
10386 (replace_buffer_in_windows): Implement by calling
10387 Qreplace_buffer_in_windows.
10388 (replace_buffer_in_all_windows): Remove with some functionality
10389 moved into replace_buffer_in_windows_safely.
10390 (replace_buffer_in_windows_safely): New function.
10391 (select_window_norecord, select_frame_norecord): Move in front
10392 of run_window_configuration_change_hook. Remove now obsolete
10393 declarations.
640c8776
SM
10394 (Fset_window_buffer): Rewrite doc-string.
10395 Call Qrecord_window_buffer.
9397e56f
MR
10396 (keys_of_window): Move binding for other-window to window.el.
10397
b50691aa
CY
103982011-06-11 Chong Yidong <cyd@stupidchicken.com>
10399
10400 * dispextern.h (struct image): Replace data member, whose int_val
10401 and ptr_val fields were not used by anything, with a single
10402 lisp_val object.
10403
10404 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10405 (gif_clear_image, gif_load, imagemagick_load_image)
10406 (gs_clear_image, gs_load): Callers changed.
10407
3f754b86
PE
104082011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10409
cca69397
PE
10410 * buffer.h: Include <time.h>, for time_t.
10411 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10412
109e28d0
PE
10413 Fix minor problems found by static checking.
10414
60737f02
PE
10415 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10416
4b66faf3
PE
10417 Make identifiers static if they are not used in other modules.
10418 * data.c (Qcompiled_function, Qframe, Qvector):
10419 * image.c (QimageMagick, Qsvg):
10420 * minibuf.c (Qmetadata):
10421 * window.c (resize_window_check, resize_root_window): Now static.
10422 * window.h (resize_window_check, resize_root_window): Remove decls.
10423
109e28d0
PE
10424 * window.c (window_deletion_count, delete_deletable_window):
10425 Remove; unused.
46a4ce9e
PE
10426 (window_body_lines): Now static.
10427 (Fdelete_other_windows_internal): Mark vars as initialized.
10428 Make sure 'resize_failed' is initialized.
10429 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10430 (resize_window_apply): Remove unused local.
10431 * window.h (delete_deletable_window): Remove decl.
10432
109e28d0 10433 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10434 (imagemagick_load_image): Fix pointer signedness problem by changing
10435 last arg from unsigned char * to char *. All uses changed.
10436 Also, fix a local for similar reasons.
10437 Remove unused locals. Remove locals to avoid shadowing.
10438 (fn_rsvg_handle_free): Remove; unused.
10439 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10440 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10441
3f754b86
PE
10442 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10443
2547adb1
CY
104442011-06-10 Chong Yidong <cyd@stupidchicken.com>
10445
10446 * image.c (gif_load): Fix omitted cast error introduced by
10447 2011-06-06 change.
10448
2c8e37d4
MR
104492011-06-10 Martin Rudalics <rudalics@gmx.at>
10450
10451 * window.h (resize_proportionally, orig_total_lines)
10452 (orig_top_line): Remove from window structure.
10453 (set_window_height, set_window_width, change_window_heights)
10454 (Fdelete_window): Remove prototypes.
10455 (resize_frame_windows): Remove duplicate declaration.
10456
440a42e3
EZ
104572011-06-10 Eli Zaretskii <eliz@gnu.org>
10458
10459 * window.h (resize_frame_windows, resize_window_check)
10460 (delete_deletable_window, resize_root_window)
10461 (resize_frame_windows): Declare prototypes.
10462
10463 * window.c (resize_window_apply): Make definition be "static" to
10464 match the prototype.
10465
562dd5e9
MR
104662011-06-10 Martin Rudalics <rudalics@gmx.at>
10467
10468 * window.c: Remove declarations of Qwindow_size_fixed,
10469 window_min_size_1, window_min_size_2, window_min_size,
10470 size_window, window_fixed_size_p, enlarge_window, delete_window.
10471 Remove static from declaration of Qdelete_window, it's
10472 temporarily needed by Fbury_buffer.
10473 (replace_window): Don't assign orig_top_line and
10474 orig_total_lines.
10475 (Fdelete_window, delete_window): Remove. Window deletion is
10476 handled by window.el.
640c8776
SM
10477 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10478 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10479 (Fdelete_other_windows): Remove. Deleting other windows is
10480 handled by window.el.
10481 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10482 handled in window.el.
10483 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10484 Window minimum sizes are handled in window.el.
10485 (shrink_windows, size_window, set_window_height)
10486 (set_window_width, change_window_heights, window_height)
10487 (window_width, CURBEG, CURSIZE, enlarge_window)
10488 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10489 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10490 handled in window.el.
10491 (make_dummy_parent): Rename to make_parent_window and give it a
10492 second argument horflag.
10493 (make_window): Don't set resize_proportionally any more.
10494 (Fsplit_window): Remove. Windows are split in window.el.
10495 (save_restore_action, save_restore_orig_size)
10496 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10497 Resize mini windows in window.el.
10498 (grow_mini_window, shrink_mini_window): Implement by calling
10499 Qresize_root_window_vertically, resize_window_check and
10500 resize_window_apply.
640c8776
SM
10501 (saved_window, Fset_window_configuration, save_window_save):
10502 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10503 resize_proportionally.
10504 (window_min_height, window_min_width): Move to window.el.
10505 (keys_of_window): Move bindings for delete-other-windows,
10506 split-window, delete-window and enlarge-window to window.el.
10507
10508 * buffer.c: Temporarily extern Qdelete_window.
10509 (Fbury_buffer): Temporarily call Qdelete_window instead of
10510 Fdelete_window (Fbury_buffer will move to window.el soon).
10511
10512 * frame.c (set_menu_bar_lines_1): Remove code handling
10513 orig_top_line and orig_total_lines.
10514
10515 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10516 set_window_height but set heights directly.
10517 (change_frame_size_1): Use resize_frame_windows.
10518
10519 * xdisp.c (init_xdisp): Don't use set_window_height but set
10520 heights directly.
10521
640c8776
SM
10522 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10523 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10524 run_window_configuration_change_hook.
10525
10526 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10527 instead of change_window_heights and run
10528 run_window_configuration_change_hook.
10529
1a13852e
MR
105302011-06-09 Martin Rudalics <rudalics@gmx.at>
10531
10532 * window.c (replace_window): Rename second argument REPLACEMENT to
10533 NEW. New third argument SETFLAG. Rewrite.
10534 (delete_window, make_dummy_parent): Call replace_window with
10535 third argument 1.
10536 (window_list_1): Move down in code.
10537 (run_window_configuration_change_hook): Move set_buffer part
10538 before select_frame_norecord part in order to unwind correctly.
10539 Rename count1 to count.
10540 (recombine_windows, delete_deletable_window, resize_root_window)
10541 (Fdelete_other_windows_internal)
10542 (Frun_window_configuration_change_hook, make_parent_window)
10543 (resize_window_check, resize_window_apply, Fresize_window_apply)
10544 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10545 (Fdelete_window_internal, Fresize_mini_window_internal):
10546 New functions.
1a13852e
MR
10547 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10548
f3d1777e
MR
105492011-06-08 Martin Rudalics <rudalics@gmx.at>
10550
496e208e
MR
10551 * window.h (window): Add some new members to window structure -
10552 normal_lines, normal_cols, new_total, new_normal, clone_number,
10553 splits, nest, prev_buffers, next_buffers.
10554 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10555 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10556
f3d1777e
MR
10557 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10558 Remove.
496e208e
MR
10559 (make_dummy_parent): Set new members of windows structure.
10560 (make_window): Move down in code. Handle new members of window
10561 structure.
10562 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10563 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10564 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10565 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10566 (Fset_window_next_buffers, Fset_window_clone_number):
10567 New functions.
496e208e
MR
10568 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10569 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10570 Doc-string fixes.
10571 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10572 Argument WINDOW can be now internal window too.
10573 (Fwindow_use_time): Move up in code.
10574 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10575 Rewrite doc-string.
10576 (Fset_window_configuration, saved_window)
10577 (Fcurrent_window_configuration, save_window_save): Handle new
10578 members of window structure.
b9e809c2
MR
10579 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10580 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10581 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10582 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10583 Qget_mru_window, Qresize_root_window,
10584 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10585 Qauto_buffer_name; staticpro them.
f3d1777e 10586
abde8f8c
MR
105872011-06-07 Martin Rudalics <rudalics@gmx.at>
10588
10589 * window.c (Fwindow_total_size, Fwindow_left_column)
10590 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10591 (Fwindow_list_1): New functions.
10592 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10593 (Fwindow_width, Fscroll_left, Fscroll_right):
10594 Use window_body_cols instead of window_box_text_cols.
10595 (delete_window, Fset_window_configuration):
10596 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10597 (delete_all_subwindows): Take a window as argument and not a
10598 structure. Rewrite.
190b47e6
MR
10599 (window_loop): Remove handling of GET_LRU_WINDOW and
10600 GET_LARGEST_WINDOW.
10601 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10602
10603 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10604 window_box_text_cols. delete_all_subwindows now takes a
10605 Lisp_Object as argument.
abde8f8c 10606
640c8776
SM
10607 * indent.c (compute_motion, Fcompute_motion):
10608 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10609
fa8a67e6
MR
10610 * frame.c (delete_frame): Call delete_all_subwindows with root
10611 window as argument.
10612
a54e3482
DC
106132011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10614
10615 * fns.c (Fputhash): Document return value.
10616
60002bf5
CY
106172011-06-06 Chong Yidong <cyd@stupidchicken.com>
10618
10619 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10620
0c671da6 106212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10622
b862a52a 10623 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10624
be44ca6c
PE
10625 Check for overflow when converting integer to cons and back.
10626 * charset.c (Fdefine_charset_internal, Fdecode_char):
10627 Use cons_to_unsigned to catch overflow.
10628 (Fencode_char): Use INTEGER_TO_CONS.
10629 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10630 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10631 * data.c (long_to_cons, cons_to_long): Remove.
10632 (cons_to_unsigned, cons_to_signed): New functions.
10633 These signal an error for invalid or out-of-range values.
10634 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10635 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10636 * font.c (Ffont_variation_glyphs):
10637 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10638 * lisp.h: Include <intprops.h>.
10639 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10640 (cons_to_signed, cons_to_unsigned): New decls.
10641 (long_to_cons, cons_to_long): Remove decls.
10642 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10643 (Fprimitive_undo): Use CONS_TO_INTEGER.
10644 * xfns.c (Fx_window_property): Likewise.
10645 * xselect.c: Include <limits.h>.
10646 (x_own_selection, selection_data_to_lisp_data):
10647 Use INTEGER_TO_CONS.
10648 (x_handle_selection_request, x_handle_selection_clear)
10649 (x_get_foreign_selection, Fx_disown_selection_internal)
10650 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10651 (lisp_data_to_selection_data): Use cons_to_unsigned.
10652 (x_fill_property_data): Use cons_to_signed.
10653 Report values out of range.
10654
d1f3d2af
PE
10655 Check for buffer and string overflow more precisely.
10656 * buffer.h (BUF_BYTES_MAX): New macro.
10657 * lisp.h (STRING_BYTES_MAX): New macro.
10658 * alloc.c (Fmake_string):
10659 * character.c (string_escape_byte8):
10660 * coding.c (coding_alloc_by_realloc):
10661 * doprnt.c (doprnt):
10662 * editfns.c (Fformat):
10663 * eval.c (verror):
10664 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10665 since they may not be the same number.
10666 * editfns.c (Finsert_char):
10667 * fileio.c (Finsert_file_contents):
10668 Likewise for BUF_BYTES_MAX.
10669
dd52fcea
PE
10670 * image.c: Use ptrdiff_t, not int, for sizes.
10671 (slurp_file): Switch from int to ptrdiff_t.
10672 All uses changed.
10673 (slurp_file): Check that file size fits in both size_t (for
10674 malloc) and ptrdiff_t (for sanity and safety).
10675
7f9bbdbb
PE
10676 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10677 if b->modtime has its maximal value.
10678
dfe18f82
PE
10679 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10680
84acfcf0
PE
10681 Don't assume time_t can fit into int.
10682 * buffer.h (struct buffer.modtime): Now time_t, not int.
10683 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10684 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10685
ccd9a01a
PE
10686 Minor fixes for signed vs unsigned integers.
10687 * character.h (MAYBE_UNIFY_CHAR):
10688 * charset.c (maybe_unify_char):
10689 * keyboard.c (read_char, reorder_modifiers):
10690 XINT -> XFASTINT, since the integer must be nonnegative.
10691 * ftfont.c (ftfont_spec_pattern):
10692 * keymap.c (access_keymap, silly_event_symbol_error):
10693 XUINT -> XFASTINT, since the integer must be nonnegative.
10694 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10695 since it makes no difference and we prefer signed.
10696 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10697 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10698 nonnegative.
10699
d6d100dd
SM
107002011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10701
10702 * window.h (Fwindow_frame): Declare.
10703
2b6148e4
PE
107042011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10705
10706 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10707 (SPARE_MEMORY): Always define.
10708 (LARGE_REQUEST): Remove.
10709 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10710
f230ecc9
MR
107112011-06-06 Martin Rudalics <rudalics@gmx.at>
10712
727e958e
MR
10713 * lisp.h: Move EXFUNS for Fframe_root_window,
10714 Fframe_first_window and Fset_frame_selected_window to window.h.
10715
10716 * window.h: Move EXFUNS for Fframe_root_window,
10717 Fframe_first_window and Fset_frame_selected_window here from
10718 lisp.h.
10719
10720 * frame.c (Fwindow_frame, Fframe_first_window)
10721 (Fframe_root_window, Fframe_selected_window)
10722 (Fset_frame_selected_window): Move to window.c.
10723 (Factive_minibuffer_window): Move to minibuf.c.
10724 (Fother_visible_frames_p): New function.
10725
10726 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10727
f230ecc9
MR
10728 * window.c (decode_window, decode_any_window): Move up in code.
10729 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10730 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10731 (Fwindow_buffer): Move up and rewrite doc-string.
10732 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10733 (Fwindow_prev): New functions.
727e958e
MR
10734 (Fwindow_frame): Move here from frame.c. Accept any window as
10735 argument.
10736 (Fframe_root_window, Fframe_first_window)
10737 (Fframe_selected_window): Move here from frame.c. Accept frame
10738 or arbitrary window as argument. Update doc-strings.
10739 (Fminibuffer_window): Move up in code.
10740 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10741 (Fset_frame_selected_window): Move here from frame.c.
10742 Marginal rewrite.
727e958e
MR
10743 (Fselected_window, select_window, Fselect_window): Move up in
10744 code. Minor doc-string fixes.
f230ecc9 10745
4d09bcf6
PE
107462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10747
10748 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10749 Do not assume that spare memory exists; that assumption is valid
10750 only if SYSTEM_MALLOC.
10751 (LARGE_REQUEST): New macro, so that the issue of large requests
10752 is separated from the issue of spare memory.
10753
810928a2
AS
107542011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10755
172418ad
AS
10756 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10757 format. (Bug#8806)
10758
43f862f7
AS
10759 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10760
810928a2
AS
10761 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10762 before statements.
10763
a059fe24
JD
107642011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10765
10766 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10767
10768 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10769
10770 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10771 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10772
989bf368
JB
107732011-06-05 Juanma Barranquero <lekktu@gmail.com>
10774
10775 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10776
4b80f674
CY
107772011-06-04 Chong Yidong <cyd@stupidchicken.com>
10778
10779 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10780 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10781 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10782 New error handlers.
4b80f674
CY
10783 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10784 Obey Vx_select_enable_clipboard_manager. Catch errors in
10785 x_clipboard_manager_save (Bug#8779).
10786 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10787 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10788
99a33b77 107892011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10790
10791 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10792
99a33b77 107932011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10794
10795 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10796 in the current matrix if keep_current_p is non-zero.
10797
8264569d
EZ
107982011-06-04 Eli Zaretskii <eliz@gnu.org>
10799
10800 * bidi.c (bidi_level_of_next_char): Fix last change.
10801
57f97249
EZ
108022011-06-03 Eli Zaretskii <eliz@gnu.org>
10803
fec2107c 10804 Support bidi reordering of text covered by display properties.
57f97249 10805
fec2107c
EZ
10806 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10807 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10808 (bidi_cache_search, bidi_cache_iterator_state)
10809 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10810 (bidi_level_of_next_char, bidi_move_to_visually_next):
10811 Support character positions inside a run of characters covered by a
fec2107c
EZ
10812 display string.
10813 (bidi_paragraph_init, bidi_resolve_explicit_1)
10814 (bidi_level_of_next_char): Call bidi_fetch_char and
10815 bidi_fetch_char_advance instead of FETCH_CHAR and
10816 FETCH_CHAR_ADVANCE.
10817 (bidi_init_it): Initialize new members.
10818 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10819 definitions.
10820 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10821 instead of using explicit *_CHAR codes.
d6d100dd
SM
10822 (bidi_resolve_explicit, bidi_resolve_weak):
10823 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10824 bidirectional text is supported only in multibyte buffers.
10825 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10826 it to initialize the frame_window_p member of struct bidi_it.
10827 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10828 (bidi_resolve_explicit, bidi_resolve_weak)
10829 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10830 bidi_it->nchars is non-positive.
10831 (bidi_level_of_next_char): Don't try to lookup the cache for the
10832 next/previous character if nothing is cached there yet, or if we
10833 were just reseat()'ed to a new position.
c40e2fb2 10834
0e14fe90
EZ
10835 * xdisp.c (set_cursor_from_row): Set start and stop points
10836 according to the row's direction when priming the loop that looks
10837 for the glyph on which to display cursor.
10838 (single_display_spec_intangible_p): Function deleted.
10839 (display_prop_intangible_p): Reimplement to call
10840 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10841 Accept 3 additional arguments needed by handle_display_spec.
10842 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10843 values: lists, `(when COND...)' forms, etc.
10844 (single_display_spec_string_p): Support property values that are
10845 lists with the argument STRING its top-level element.
10846 (display_prop_string_p): Fix the condition for processing a
10847 property that is a list to be consistent with handle_display_spec.
fec2107c 10848 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10849 last portion of handle_display_prop.
10850 (compute_display_string_pos): Accept additional argument
10851 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10852 value of a `display' property is a "replacing spec".
10853 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10854 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10855 the display property, but just return a value indicating whether
10856 the display property will replace the characters it covers.
10857 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10858 frame_window_p members of struct bidi_it.
d6d100dd
SM
10859 (compute_display_string_pos, compute_display_string_end):
10860 New functions.
fec2107c
EZ
10861 (push_it): Accept second argument POSITION, where pop_it should
10862 jump to continue iteration.
10863 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10864
fec2107c
EZ
10865 * keyboard.c (adjust_point_for_property): Adjust the call to
10866 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10867
10868 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10869 (bidi_init_it): Update prototypes.
10870 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10871 (compute_display_string_pos, compute_display_string_end):
10872 Declare prototypes.
fec2107c
EZ
10873 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10874 EMACS_INT.
fc6f18ce 10875
40087514 108762011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10877
57f53182
PE
10878 Malloc failure behavior now depends on size of allocation.
10879 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10880 * lisp.h: Change signatures accordingly.
10881 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10882 All callers changed. (Bug#8762)
10883
10884 * gnutls.c: Use Emacs's memory allocators.
10885 Without this change, the gnutls library would invoke malloc etc.
10886 directly, which causes problems on non-SYNC_INPUT hosts, and which
10887 runs afoul of improving memory_full behavior. (Bug#8761)
10888 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10889 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10890 xfree instead of the default malloc, realloc, free.
10891 (Fgnutls_boot): No need to check for memory allocation failure,
10892 since xmalloc does that for us.
10893
ac32cd99 10894 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10895 * category.c (hash_get_category_set):
10896 * ccl.c (ccl_driver):
10897 * charset.c (Fdefine_charset_internal):
10898 * charset.h (struct charset.hash_index):
10899 * composite.c (get_composition_id, gstring_lookup_cache)
10900 (composition_gstring_put_cache):
10901 * composite.h (struct composition.hash_index):
10902 * dispextern.h (struct image.hash):
10903 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10904 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10905 (hashfn_equal, hashfn_user_defined, make_hash_table)
10906 (maybe_resize_hash_table, hash_lookup, hash_put)
10907 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10908 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10909 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10910 * image.c (make_image, search_image_cache, lookup_image)
10911 (xpm_put_color_table_h):
10912 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10913 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10914 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10915 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10916 * alloc.c (allocate_vectorlike):
10917 Check for overflow in vector size calculations.
10918 * ccl.c (ccl_driver):
10919 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10920 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10921 need to be updated by these changes.
40087514
PE
10922 * fns.c (make_hash_table, maybe_resize_hash_table):
10923 Check for integer overflow with large hash tables.
0de4bb68
PE
10924 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10925 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10926 (SXHASH_REDUCE): New macro.
10927 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10928 Use it instead of discarding useful hash info with large hash values.
10929 (sxhash_float): New function.
10930 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10931 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10932 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10933 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10934 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10935 Adjust signatures to match updated version of code.
10936 (consing_since_gc): Now EMACS_INT, since a single hash table can
10937 use more than INT_MAX bytes.
10938
698d32e2
DN
109392011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10940
10941 Make it possible to build with GCC-4.6+ -O2 -flto.
10942
10943 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10944
fd6fa53f
SM
109452011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10946
10947 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10948 Call minibuffer-inactive-mode.
10949
864db017
JB
109502011-05-31 Juanma Barranquero <lekktu@gmail.com>
10951
10952 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10953 Update dependencies.
10954
2ad0baf4
DN
109552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10956
10957 * data.c (init_data): Remove code for UTS, this system is not
10958 supported anymore.
10959
4fcc2638
DN
109602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10961
10962 Don't force ./temacs to start in terminal mode.
10963
10964 * frame.c (make_initial_frame): Initialize faces in all cases, not
10965 only when CANNOT_DUMP is defined.
10966 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10967
c56e0fd5
DN
109682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10969
10970 * dispnew.c (add_window_display_history): Use const for the string
10971 pointer. Remove declaration, not needed.
10972
333d54da 109732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10974
55d4c1b2 10975 Use 'inline', not 'INLINE'.
333d54da 10976 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10977 * alloc.c, fontset.c (INLINE): Remove.
10978 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10979 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10980 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10981 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10982 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10983
738db178
DN
109842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10985
10986 Make it possible to run ./temacs.
10987
10988 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10989 syms_of_callproc does the same thing. Remove test for
10990 "initialized", do it in the caller.
10991 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10992
620c53a6
SM
109932011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10994
10995 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10996 (read_minibuf): Use get_minibuffer.
10997 (syms_of_minibuf): Use DEFSYM.
10998 (Qmetadata): New var.
10999 * data.c (Qbuffer): Don't make it static.
11000 (syms_of_data): Use DEFSYM.
11001
e003a292
PE
110022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11003
11004 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11005 (CCL_CODE_MIN): New macro.
11006
ed008a6d
PE
110072011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11008
3687c2ef
PE
11009 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11010
ed008a6d
PE
11011 * eval.c (Qdebug): Now static.
11012 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11013 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11014 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11015
d66c4c7c
CY
110162011-05-29 Chong Yidong <cyd@stupidchicken.com>
11017
11018 * image.c: Various fixes to ImageMagick code comments.
11019 (Fimagemagick_types): Doc fix.
11020
5fbc2025
PE
110212011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11022
0196f88a
PE
11023 Minor fixes prompted by GCC 4.6.0 warnings.
11024
11025 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11026
5fbc2025
PE
11027 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11028 (x_clipboard_manager_save_all): Move extern decl to ...
11029 * xterm.h: ... here, so that it can be checked for consistency.
11030
1dd3c2d9
CY
110312011-05-29 Chong Yidong <cyd@stupidchicken.com>
11032
11033 * xselect.c (x_clipboard_manager_save_frame)
11034 (x_clipboard_manager_save_all): New functions.
11035 (Fx_clipboard_manager_save): Lisp function deleted.
11036
11037 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11038 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11039
11040 * xterm.h: Update prototype.
11041
5ba6571d
WX
110422011-05-28 William Xu <william.xwl@gmail.com>
11043
11044 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11045 exiting (Bug#8239).
11046
3eaff834
JM
110472011-05-28 Jim Meyering <meyering@redhat.com>
11048
e1900994 11049 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11050 * fns.c (to_uchar): Define.
11051 (crypto_hash_function): Use it to convert some newly-signed
11052 variables to unsigned, to avoid sign-extension bugs. For example,
11053 without this change, (md5 "truc") would evaluate to
11054 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11055 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11056 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11057
0f6990a7
PE
110582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11059
11060 Integer overflow fixes.
c8a9ca5a 11061
08686060
PE
11062 * dbusbind.c: Serial number integer overflow fixes.
11063 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11064 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11065 to hold a serial number that is too large for a fixnum.
11066 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11067 Check for serial numbers out of range. Decode any serial number
59568bf0 11068 that was so large that it became a float. (Bug#8722)
08686060 11069
2d1fc3c7
PE
11070 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11071 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11072 Use XFASTINT rather than XUINT when numbers are nonnegative.
11073 (xd_append_arg, Fdbus_method_return_internal):
11074 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11075 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11076 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11077 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11078 (Bug#8722)
2d1fc3c7 11079
c8a9ca5a
PE
11080 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11081
519e1d69
PE
11082 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11083
6df6ae42 11084 ccl: Add integer overflow checks.
30569699
PE
11085 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11086 (IN_INT_RANGE): New macros.
11087 (ccl_driver): Use them to check for integer overflow when
11088 decoding a CCL program. Many of the new checks are whether XINT (x)
11089 fits in int; it doesn't always, on 64-bit hosts. The new version
11090 doesn't catch all possible integer overflows, but it's an
847044ea 11091 improvement. (Bug#8719)
30569699 11092
c11285dc
PE
11093 * alloc.c (make_event_array): Use XINT, not XUINT.
11094 There's no need for unsigned here.
11095
fdccd48e
PE
11096 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11097 This follows up to the 2011-05-06 change that substituted uintptr_t
11098 for EMACS_INT. This case wasn't caught back then.
11099
37910ab2
PE
11100 Rework Fformat to avoid integer overflow issues.
11101 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11102 now (part of C89). Include <verify.h>.
11103 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11104 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11105 (Fformat): Avoid the prepass trying to compute sizes; it was only
11106 approximate and thus did not catch overflow reliably. Instead, walk
11107 through the format just once, formatting and computing sizes as we go,
11108 checking for integer overflow at every step, and allocating a larger
11109 buffer as needed. Keep track separately whether the format is
11110 multibyte. Keep only the most-recently calculated precision, rather
11111 than them all. Record whether each argument has been converted to
11112 string. Use EMACS_INT, not int, for byte and char and arg counts.
11113 Support field widths and precisions larger than INT_MAX. Avoid
11114 sprintf's undefined behavior with conversion specifications such as %#d
11115 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11116 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11117 formatting out-of-range floating point numbers with int
9173deec 11118 formats. (Bug#8668)
37910ab2 11119
2e6578fb
PE
11120 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11121
0ae6bdee
PE
11122 * data.c: Avoid integer truncation in expressions involving floats.
11123 * data.c: Include <intprops.h>.
11124 (arith_driver): When there's an integer overflow in an expression
11125 involving floating point, convert the integers to floating point
11126 so that the resulting value does not suffer from catastrophic
11127 integer truncation. For example, on a 64-bit host (* 4
11128 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11129 Do not rely on undefined behavior after integer overflow.
11130
de883a70
PE
11131 merge count_size_as_multibyte, parse_str_to_multibyte
11132 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11133 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11134 Check for integer overflow.
11135 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11136 since it's now a duplicate of the other. This is more of
11137 a character than a buffer op, so better that it's in character.c.
11138 * fns.c, print.c: Adjust to above changes.
11139
2ff916cb
PE
111402011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11141
11142 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11143
f1b54466
PE
111442011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11145
fb1ac845
PE
11146 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11147 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11148 (x_clipboard_manager_save): Now static.
11149 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11150
f1b54466
PE
11151 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11152 (crypto_hash_function): Now static.
11153 Fix pointer signedness problems. Avoid unnecessary initializations.
11154
a9f737ee
CY
111552011-05-27 Chong Yidong <cyd@stupidchicken.com>
11156
11157 * termhooks.h (Vselection_alist): Make it terminal-local.
11158
11159 * terminal.c (create_terminal): Initialize it.
11160
11161 * xselect.c: Support for clipboard managers.
11162 (Vselection_alist): Move to termhooks.h as terminal-local var.
11163 (LOCAL_SELECTION): New macro.
11164 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11165 (symbol_to_x_atom): Remove gratuitous arg.
11166 (x_handle_selection_request, lisp_data_to_selection_data)
11167 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11168 (x_own_selection, x_get_local_selection, x_convert_selection):
11169 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11170 (some_frame_on_display): Delete unused function.
11171 (Fx_own_selection_internal, Fx_get_selection_internal)
11172 (Fx_disown_selection_internal, Fx_selection_owner_p)
11173 (Fx_selection_exists_p): New optional frame arg.
11174 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11175 (x_handle_selection_clear): Don't treat other terminals with the
11176 same keyboard specially. Use the terminal-local Vselection_alist.
11177 (x_clear_frame_selections): Use Frun_hook_with_args.
11178
11179 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11180
11181 * xterm.h: Add support for those atoms.
11182
e067f0c1
CY
111832011-05-26 Chong Yidong <cyd@stupidchicken.com>
11184
11185 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11186 (converted_selections, conversion_fail_tag): New global variables.
11187 (x_selection_request_lisp_error): Free the above.
11188 (x_get_local_selection): Remove unnecessary code.
11189 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11190 of converted selections stored in converted_selections.
11191 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11192 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11193 (x_convert_selection): New function.
11194 (x_handle_selection_event): Simplify.
11195 (x_get_foreign_selection): Don't ignore incoming requests while
11196 waiting for an answer; this will fail when we implement
11197 SAVE_TARGETS, and seems unnecessary anyway.
11198 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11199 (Vx_sent_selection_functions): Doc fix.
11200
0f4aebc0
LL
112012011-05-26 Leo Liu <sdl.web@gmail.com>
11202
11203 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11204
e61124cd
YM
112052011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11206
11207 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11208
11209 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11210 for fringe update if it has periodic bitmap.
ac389d0c 11211 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11212 and fringe_bitmap_periodic_p.
11213
11214 * fringe.c (get_fringe_bitmap_data): New function.
11215 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11216 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11217 row. Mark glyph row for fringe update if periodicity changed.
11218
11219 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11220 for fringe update unless it has periodic bitmap.
11221
f16d9837
KH
112222011-05-25 Kenichi Handa <handa@m17n.org>
11223
11224 * xdisp.c (get_next_display_element): Set correct it->face_id for
11225 a static composition.
11226
e1b90ef6
LL
112272011-05-24 Leo Liu <sdl.web@gmail.com>
11228
11229 * deps.mk (fns.o):
11230 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11231
11232 * fns.c (crypto_hash_function, Fsha1): New function.
11233 (Fmd5): Use crypto_hash_function.
11234 (syms_of_fns): Add Ssha1.
11235
7400048f
PE
112362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11237
11238 * gnutls.c: Remove unused macros.
11239 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11240 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11241 Remove macros that are defined and never used.
11242 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11243
abb71cf4
CY
112442011-05-22 Chong Yidong <cyd@stupidchicken.com>
11245
11246 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11247 (Fx_get_selection_internal): Minor cleanup.
11248 (Fx_own_selection_internal): Rename arguments for consistency with
11249 select.el.
11250
6307db39
PE
112512011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11252
11253 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11254
f3d4e0a4
CY
112552011-05-22 Chong Yidong <cyd@stupidchicken.com>
11256
11257 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11258
4d8ade89
YM
112592011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11260
11261 * dispnew.c (scrolling_window): Don't exclude the case that the
11262 last enabled row in the desired matrix touches the bottom boundary.
11263
32078c8d
GM
112642011-05-21 Glenn Morris <rgm@gnu.org>
11265
11266 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11267 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11268 and add some more files.
32078c8d 11269
7285dc67
EZ
112702011-05-20 Eli Zaretskii <eliz@gnu.org>
11271
11272 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11273 report_file_error introduced by the change from 2011-05-07.
11274
89d1bd22
PE
112752011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11276
11277 * systime.h (Time): Define only if emacs is defined.
11278 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11279 where the include path doesn't have X11/X.h by default. See
11280 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11281
cd394be1 112822011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11283
11284 * composite.c (find_automatic_composition): Fix previous change.
11285
b9704ad9
GM
112862011-05-20 Glenn Morris <rgm@gnu.org>
11287
11288 * lisp.mk: New file, split from Makefile.in.
11289 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11290 (shortlisp): Remove.
11291 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11292
4a720484
GM
112932011-05-19 Glenn Morris <rgm@gnu.org>
11294
11295 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11296 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11297 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11298 (lisp): Set the order to that of loadup.el.
11299 (shortlisp): Make it a copy of $lisp.
11300 (SOME_MACHINE_LISP): Remove.
11301 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11302 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11303
a28d4396
KH
113042011-05-18 Kenichi Handa <handa@m17n.org>
11305
11306 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11307 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11308 (find_automatic_composition): Mostly rewrite for efficiency.
11309
a2b1fa8e
JB
113102011-05-18 Juanma Barranquero <lekktu@gmail.com>
11311
11312 * makefile.w32-in: Update dependencies.
11313
8e1f5610
CS
113142011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11315
11316 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11317 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11318
7025ee00 113192011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11320
cdfa6eab
PE
11321 Fix some integer overflow issues, such as string length overflow.
11322
06d6db33
PE
11323 * insdel.c (count_size_as_multibyte): Check for string overflow.
11324
2b4560a8
PE
11325 * character.c (lisp_string_width): Check for string overflow.
11326 Use EMACS_INT, not int, for string indexes and lengths; in
11327 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11328 the resulting string length overflows an EMACS_INT; instead,
11329 report a string overflow if no precision given. When checking for
11330 precision exhaustion, use a check that cannot possibly have
11331 integer overflow. (Bug#8675)
11332 * character.h (lisp_string_width): Adjust to new signature.
11333
cb93f9be
PE
11334 * alloc.c (string_overflow): New function.
11335 (Fmake_string): Use it. This doesn't change behavior, but saves
11336 a few bytes and will simplify future changes.
11337 * character.c (string_escape_byte8): Likewise.
11338 * lisp.h (string_overflow): New decl.
11339
1a1f3366
PE
11340 Fixups, following up to the user-interface timestamp change.
11341 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11342 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11343 * msdos.c (mouse_get_pos): Likewise.
11344 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11345 * w32gui.h (Time): Define by including "systime.h" rather than by
11346 declaring it ourselves. (Bug#8664)
11347
d4e3e4d3
PE
11348 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11349 * image.c (clear_image_cache): Likewise.
11350
f6a24d19
PE
11351 * term.c (term_mouse_position): Don't assume time_t wraparound.
11352
08dc5ae6
PE
11353 Be more systematic about user-interface timestamps.
11354 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11355 and sometimes 'EMACS_UINT', to represent these timestamps.
11356 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11357 This makes the code easier to follow, and makes it easier to catch
11358 integer overflow bugs such as Bug#8664.
11359 * frame.c (Fmouse_position, Fmouse_pixel_position):
11360 Use Time, not unsigned long, for user-interface timestamps.
11361 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11362 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11363 * keyboard.h (last_event_timestamp): Likewise.
11364 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11365 * menu.h (xmenu_show): Likewise.
11366 * term.c (term_mouse_position): Likewise.
11367 * termhooks.h (struct input_event.timestamp): Likewise.
11368 (struct terminal.mouse_position_hook): Likewise.
11369 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11370 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11371 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11372 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11373 what it was before.
11374 * menu.h, termhooks.h: Include "systime.h", for Time.
11375
8e55734a
PE
11376 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11377 Don't assume that the difference between two unsigned long values
11378 can fit into an integer. At this point, we know button_down_time
11379 <= event->timestamp, so the difference must be nonnegative, so
11380 there's no need to cast the result if double-click-time is
11381 nonnegative, as it should be; check that it's nonnegative, just in
11382 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11383 apart (about 25 days). (Bug#8664)
8e55734a 11384
841f1b75 11385 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11386 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11387
3e26f69c
PE
11388 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11389 that always fit in int. Use a sentinel instead of a counter, to
11390 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11391 * frame.h (struct frame): Use int for menu_bar_items_used
11392 instead of EMACS_INT, since it always fits in int.
3e26f69c 11393
5cc152c0
PE
11394 * menu.c (grow_menu_items): Check for int overflow.
11395
d89eb65e
PE
11396 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11397
5235bd3e
PE
11398 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11399 Before, the code was not consistent. These values cannot exceed
11400 2**31 - 1 so there's no need to make them unsigned.
11401 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11402 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11403 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11404 as modifiers.
11405 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11406
bc827e23
PE
11407 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11408 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11409 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11410 presumably because the widths might not match.
11411
78eb494e
PE
11412 * window.c (size_window): Avoid needless test at loop start.
11413
04f2d78b
CB
114142011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11415
11416 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11417
d2fc7e3d 114182011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11419
11420 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11421
d2fc7e3d 114222011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11423
11424 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11425 `width' to `bar_area_x' and `bar_area_width', respectively.
11426 (x_scroll_run): Take account of fringe background extension.
11427
04f2d78b
CB
11428 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11429 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11430 `bar_area_width', respectively.
11431 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11432 background extension.
11433
79b70037
GM
114342011-05-10 Jim Meyering <meyering@redhat.com>
11435
11436 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11437
2f142cc5
JB
114382011-05-10 Juanma Barranquero <lekktu@gmail.com>
11439
11440 * image.c (Finit_image_library): Return t for built-in image types,
11441 like pbm and xbm. (Bug#8640)
11442
57679c86
AS
114432011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11444
11445 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11446
888c9e86
EZ
114472011-05-07 Eli Zaretskii <eliz@gnu.org>
11448
b0512a1d
EZ
11449 * w32console.c (Fset_screen_color): Doc fix.
11450 (Fget_screen_color): New function.
11451 (syms_of_ntterm): Defsubr it.
11452
7285dc67
EZ
11453 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11454 unlink the temporary file if Fcall_process didn't create it in the
11455 first place.
11456 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11457 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11458 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11459 cue to call_process_cleanup not to close that handle.
11460
4d3fcc8e
BK
114612011-05-07 Ben Key <bkey76@gmail.com>
11462
11463 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11464 one of two shell specific rules, either bootstrap-temacs-CMD or
11465 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11466 to the previous implementation of the bootstrap-temacs rule.
11467 The bootstrap-temacs-CMD rule is similar to the previous
11468 implementation of the bootstrap-temacs rule except that it
11469 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11470 variable.
11471
11472 These changes, along with some changes to nt/configure.bat,
11473 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11474 earlier fix to add support for --cflags and --ldflags options
11475 that include quotes so that it works whether make uses cmd or
11476 sh as the shell.
11477
b4289b64
MA
114782011-05-06 Michael Albinus <michael.albinus@gmx.de>
11479
11480 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11481 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11482 is a constant.
11483 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11484 a string. Handle both cases.
11485 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11486 (Fdbus_register_method): Use Qinvalid_function.
11487
af4c0e28
JB
114882011-05-06 Juanma Barranquero <lekktu@gmail.com>
11489
11490 * makefile.w32-in: Update dependencies.
11491 (LISP_H): Add inttypes.h and stdin.h.
11492 (PROCESS_H): Add unistd.h.
11493
c51453d9
EZ
114942011-05-06 Eli Zaretskii <eliz@gnu.org>
11495
11496 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11497 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11498
8ff0ac3c 114992011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11500
4c4b566b
PE
11501 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11502
aab2b9b5
PE
11503 * term.c (vfatal): Remove stray call to va_end.
11504 It's not needed and the C Standard doesn't allow it here anyway.
11505
c378da0b
PE
11506 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11507 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11508
288b08c7
PE
11509 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11510 bytes.
11511
e3601888
PE
11512 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11513
db6c0e74
PE
11514 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11515
dd5963ea
PE
11516 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11517
88c9450f
PE
11518 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11519
2f9442b8
PE
11520 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11521
c032b5f8
PE
11522 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11523 * charset.c (Fdefine_charset_internal): Don't initialize
11524 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11525 32-bit int (Bug#8600).
a108c10b
PE
11526
11527 * lread.c (read_integer): Be more consistent with string-to-number.
11528 Use string_to_number to do the actual conversion; this avoids
11529 rounding errors and fixes some other screwups. Without this fix,
11530 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11531 (digit_to_number): Move earlier, for benefit of read_integer.
11532 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11533 not a digit in any supported base. (Bug#8602)
a108c10b 11534
ad5f9eea
PE
11535 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11536
aec1708a
PE
11537 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11538 to match comment at start of function. This also removes a
11539 GCC warning about overflow in a 32+64-bit port.
11540
47be4ab5
PE
11541 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11542
371cac43
PE
11543 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11544 Reported by Stefan Monnier in
11545 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11546 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11547 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11548
d01a7826
PE
11549 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11550 (EMACS_UINTPTR): Likewise, with uintptr_t.
11551
7fd47d5c
PE
11552 * lisp.h: Prefer 64-bit EMACS_INT if available.
11553 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11554 on 32-bit hosts that have 64-bit int, so that they can access
11555 large files.
122b0c86
PE
11556 However, temporarily disable this change unless the temporary
11557 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11558
8727937b
PE
11559 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11560
8ac068ac
PE
11561 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11562 This removes an assumption that EMACS_INT and long are the same
11563 width as pointers. The assumption is true for Emacs porting targets
11564 now, but we want to make other targets possible.
11565 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11566 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11567 In the rest of the code, change types of integers that hold casted
11568 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11569 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11570 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11571 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11572 No need to cast type when ORing.
11573 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11574 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11575 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11576 assume EMACS_INT is the same width as char *.
11577 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11578 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11579 Remove no-longer-needed casts.
11580 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11581 (xg_tool_bar_help_callback, xg_make_tool_item):
11582 Use EMACS_INTPTR to hold an integer
11583 that will be cast to void *; this can avoid a GCC warning
11584 if EMACS_INT is not the same width as void *.
11585 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11586 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11587 (current_message_1, set_message_1):
11588 Use a local to convert to proper width without a cast.
11589 * xmenu.c (dialog_selection_callback): Likewise.
11590
ede49d71
PE
11591 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11592 Also, don't assume VALBITS / RAND_BITS is less than 5,
11593 and don't rely on undefined behavior when shifting a 1 left into
11594 the sign bit.
11595 * lisp.h (get_random): Change signature to match.
11596
2f30ecd0
PE
11597 * lread.c (hash_string): Use size_t, not int, for hash computation.
11598 Normally we prefer signed values; but hashing is special, because
11599 it's better to use unsigned division on hash table sizes so that
11600 the remainder is nonnegative. Also, size_t is the natural width
11601 for hashing into memory. The previous code used 'int', which doesn't
11602 retain enough info to hash well into very large tables.
11603 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11604
2a866e7b
PE
11605 * dbusbind.c: Don't possibly lose pointer info when converting.
11606 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11607 Use XPNTR rather than XHASH, so that the high-order bits of
11608 the pointer aren't lost when converting through void *.
11609
51639eac
PE
11610 * eval.c (Fautoload): Don't double-shift a pointer.
11611
92394119
PE
11612 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11613
dbdb9a7c
JB
116142011-05-06 Juanma Barranquero <lekktu@gmail.com>
11615
11616 * gnutls.c (DEF_GNUTLS_FN):
11617 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11618
db7a0b4f
AS
116192011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11620
11621 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11622 marker. (Bug#8610)
11623
cd394be1 116242011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11625
11626 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11627 New version that can reserve upto 2GB of heap space.
11628
f7ff1b0f 116292011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11630
11631 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11632
639c109b
TZ
116332011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11634
11635 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11636 `gnutls_certificate_set_x509_key_file'.
11637
d2127135
JB
116382011-05-05 Juanma Barranquero <lekktu@gmail.com>
11639
11640 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11641 Update dependencies.
11642
e968f4f3
JB
116432011-05-04 Juanma Barranquero <lekktu@gmail.com>
11644
11645 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11646 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11647 Remove unused parameter `fildes'.
11648 * process.c (read_process_output, send_process): Don't pass it.
11649
84d358f0
JB
116502011-05-04 Juanma Barranquero <lekktu@gmail.com>
11651
11652 Fix previous change: the library cache is defined in w32.c.
11653 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11654 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11655
0898ca10
JB
116562011-05-04 Juanma Barranquero <lekktu@gmail.com>
11657
11658 Implement dynamic loading of GnuTLS on Windows.
11659
11660 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11661 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11662 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11663 Declare.
11664
11665 * gnutls.c (Qgnutls_dll): Define.
11666 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11667 (gnutls_*): Declare function pointers.
11668 (init_gnutls_functions): New function to initialize function pointers.
11669 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11670 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11671 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11672 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11673 (emacs_gnutls_write, emacs_gnutls_read)
11674 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11675 (Fgnutls_available_p): New function.
11676 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11677 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11678 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11679
11680 * image.c: Include w32.h.
11681 (Vimage_type_cache): Delete.
11682 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11683 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11684 (w32_delayed_load): Move to w32.c.
11685
11686 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11687
11688 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11689 (w32_delayed_load): Move from image.c. When loading a library, record
11690 its filename in the :loaded-from property of the library id.
11691 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11692 Initialize and staticpro them.
11693 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11694
11695 * process.c: Include lisp.h before w32.h, not after.
11696 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11697 instead of gnutls_record_check_pending.
11698
11699 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11700
ff4de4aa
TZ
117012011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11702
11703 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11704 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11705 as passed in.
11706
abe95abb
JD
117072011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11708
11709 * xterm.c (x_set_frame_alpha): Do not set property on anything
11710 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11711
e16e55d4
JB
117122011-05-02 Juanma Barranquero <lekktu@gmail.com>
11713
11714 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11715
bafcf6a5
JB
117162011-05-02 Juanma Barranquero <lekktu@gmail.com>
11717
11718 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11719 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11720 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11721 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11722 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11723 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11724 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11725 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11726 (Qgnutls_bootprop_callbacks_verify): Make static.
11727
e7a6747f
AS
117282011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11729
19ed11ba
AS
11730 * callproc.c: Indentation fixup.
11731
e7a6747f 11732 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11733 (wait_for_termination, interruptible_wait_for_termination):
11734 Move after wait_for_termination_1.
e7a6747f 11735
1ef14cb4
LMI
117362011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11737
11738 * sysdep.c (interruptible_wait_for_termination): New function
11739 which is like wait_for_termination, but allows keyboard
11740 interruptions.
11741
11742 * callproc.c (Fcall_process): Add (:file "file") as an option for
11743 the STDOUT buffer.
11744 (Fcall_process_region): Ditto.
11745
330d880c
EZ
117462011-04-30 Eli Zaretskii <eliz@gnu.org>
11747
8db90b73
EZ
11748 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11749 rather than `XVECTOR (FOO)->size'.
11750
330d880c
EZ
11751 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11752 inttypes.h, as a gnulib replacement is used if it not available in
11753 system headers.
11754
15cbd324
EZ
117552011-04-21 Eli Zaretskii <eliz@gnu.org>
11756
11757 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11758 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11759 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11760
11761 * coding.c (coding_alloc_by_realloc): Error out if destination
11762 will grow beyond MOST_POSITIVE_FIXNUM.
11763 (decode_coding_emacs_mule): Abort if there isn't enough place in
11764 charbuf for the composition carryover bytes. Reserve an extra
11765 space for up to 2 characters produced in a loop.
11766 (decode_coding_iso_2022): Abort if there isn't enough place in
11767 charbuf for the composition carryover bytes.
11768
117692011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11770
ae940cca
EZ
11771 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11772 aborting when %lld or %lll format is passed.
11773 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11774 %llo or %llx format is passed. (Bug#8545)
11775
03ab8921
EZ
11776 * window.c (window_scroll_line_based): Use a marker instead of
11777 simple variables to record original value of point. (Bug#7952)
11778
afda1437
EZ
11779 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11780 produced by %s or %c overflows available buffer space. (Bug#8545)
11781
f76dee0c
PE
117822011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11783
11784 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11785 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11786
fdc5744d
JB
117872011-04-28 Juanma Barranquero <lekktu@gmail.com>
11788
11789 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11790
638f053a
JB
117912011-04-28 Juanma Barranquero <lekktu@gmail.com>
11792
11793 * keyboard.c (Qdelayed_warnings_hook): Define.
11794 (command_loop_1): Run `delayed-warnings-hook'
11795 if Vdelayed_warnings_list is non-nil.
11796 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11797 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11798
d178f871
EZ
117992011-04-28 Eli Zaretskii <eliz@gnu.org>
11800
11801 * doprnt.c (doprnt): Don't return value smaller than the buffer
11802 size if the message was truncated. (Bug#8545).
11803
b124fd93
JB
118042011-04-28 Juanma Barranquero <lekktu@gmail.com>
11805
11806 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11807 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11808
e810457d
PE
118092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11810
11811 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11812
ea51cceb
JB
118132011-04-27 Juanma Barranquero <lekktu@gmail.com>
11814
11815 * makefile.w32-in: Update dependencies.
11816
94dcfacf
EZ
118172011-04-27 Eli Zaretskii <eliz@gnu.org>
11818
11819 Improve `doprnt' and its usage. (Bug#8545)
11820 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11821 `format_end'. Remove support for %l as a conversion specifier.
11822 Don't use xrealloc. Improve diagnostics when the %l size modifier
11823 is used. Update the commentary.
11824
11825 * eval.c (verror): Simplify calculation of size_t.
11826
11827 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11828 messages.
11829
f61f41d7
PE
118302011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11831
11832 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11833 change.
11834
96fb4434
PE
118352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11836
11837 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11838 This makes this file independent of the recent pseudovector change.
11839
671875da 118402011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11841
69e9b5a3
PE
11842 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11843
b5f869a7 11844 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11845 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11846 Remove unused local.
c8926152 11847 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11848
841a1577 11849 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11850 GCC 4.6.0 optimizes based on type-based alias analysis.
11851 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11852 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11853 != &v->size, and therefore "v->size = 1; b->size = 2; return
11854 v->size;" must therefore return 1. This assumption is incorrect
11855 for Emacs, since it type-puns struct Lisp_Vector * with many other
11856 types. To fix this problem, this patch adds a new type struct
f904488f 11857 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11858 and pseudovectors, and helps optimizing compilers not get fooled
11859 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11860 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11861 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11862 the size member.
eab3844f
PE
11863 (XSETPVECTYPE): Rewrite in terms of new macro.
11864 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11865 This is a bit clearer, and further avoids the possibility of
11866 undesirable aliasing.
11867 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11868 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11869 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11870 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11871 (ASIZE): Now uses header.size rather than size.
11872 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11873 to avoid the hassle of writing XVECTOR (foo)->header.size.
11874 (struct vectorlike_header): New type.
eab3844f
PE
11875 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11876 object, to help avoid aliasing.
11877 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11878 (SUBRP): Likewise, since Lisp_Subr is a special case.
11879 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11880 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11881 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11882 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11883 changed to be "header.size" and "header.next".
11884 * buffer.h (struct buffer): Likewise.
11885 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11886 * frame.h (struct frame): Likewise.
11887 * process.h (struct Lisp_Process): Likewise.
11888 * termhooks.h (struct terminal): Likewise.
11889 * window.c (struct save_window_data, struct saved_window): Likewise.
11890 * window.h (struct window): Likewise.
11891 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11892 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11893 * buffer.c (init_buffer_once): Likewise.
11894 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11895 special case.
11896 * process.c (Fformat_network_address): Use local var for size,
11897 for brevity.
11898
0df1eac5
PE
11899 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11900
847ab9d1 11901 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11902 * data.c (atof): Remove decl; no longer used or needed.
11903 (digit_to_number): Move to lread.c.
11904 (Fstring_to_number): Use new string_to_number function, to be
11905 consistent with how the Lisp reader treats infinities and NaNs.
11906 Do not assume that floating-point numbers represent EMACS_INT
11907 without losing information; this is not true on most 64-bit hosts.
11908 Avoid double-rounding errors, by insisting on integers when
11909 parsing non-base-10 numbers, as the documentation specifies.
11910 * lisp.h (string_to_number): New decl, replacing ...
11911 (isfloat_string): Remove.
bc0a5c13 11912 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11913 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11914 appears to have been a coding error. Similarly, do not accept
11915 strings like +-1e0 as floating point numbers. Do not report
11916 overflow for integer overflows unless the base is not 10 which
11917 means we have no simple and reliable way to continue.
11918 Break out the floating-point parsing into a new
11919 function string_to_number, so that Fstring_to_number parses
11920 floating point numbers consistently with the Lisp reader.
04f2d78b 11921 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11922 (E_CHAR, EXP_INT): Remove, replacing with ...
11923 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11924 (string_to_number): New function, replacing isfloat_string.
11925 This function checks for valid syntax and produces the resulting
11926 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11927 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11928 so that overflow for non-base-10 numbers is reported only when
11929 there's no portable and simple way to convert to floating point.
452f4150 11930
67769ffc
PE
11931 * textprop.c (set_text_properties_1): Rewrite for clarity,
11932 and to avoid GCC warning about integer overflow.
11933
c20db43f
PE
11934 * intervals.h (struct interval): Use EMACS_INT for members
11935 where EMACS_UINT might cause problems. See
11936 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11937 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11938 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11939 All uses changed.
37aa2f85
PE
11940 (offset_intervals): Tell GCC not to worry about length overflow
11941 when negating a negative length.
c20db43f 11942
2538aa2f
PE
11943 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11944 (overrun_check_free): Likewise.
11945
f2d3008d
PE
11946 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11947 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11948 word size.
11949
ec8df744
PE
11950 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11951 (gnutls_make_error): Rename local to avoid shadowing.
11952 (gnutls_emacs_global_deinit): ifdef out; not used.
11953 (Fgnutls_boot): Use const for pointer to readonly storage.
11954 Comment out unused local. Fix pointer signedness problems.
11955
640ee02d
PE
11956 * lread.c (openp): Don't stuff size_t into an 'int'.
11957 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11958 about possible signed overflow.
11959
6048fb2a
PE
11960 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11961 (GDK_KEY_g): Don't define if already defined.
11962 (xg_prepare_tooltip): Avoid pointer signedness problem.
11963 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11964
fa3c87e1
PE
11965 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11966 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11967
2172544b
PE
11968 * xfns.c (Fx_window_property): Simplify a bit,
11969 to make a bit faster and to avoid GCC 4.6.0 warning.
11970 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11971
9b821a21
PE
11972 * fns.c (internal_equal): Don't assume size_t fits in int.
11973
3c616cfa
PE
11974 * alloc.c (compact_small_strings): Tighten assertion a little.
11975
c2982e87
PE
11976 Replace pEd with more-general pI, and fix some printf arg casts.
11977 * lisp.h (pI): New macro, generalizing old pEd macro to other
11978 conversion specifiers. For example, use "...%"pI"d..." rather
11979 than "...%"pEd"...".
11980 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11981 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11982 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11983 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11984 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11985 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11986 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11987 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11988 64-bit hosts.
11989 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11990 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11991 * print.c (safe_debug_print, print_object): Likewise.
11992 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11993 to int.
6f04d126
PE
11994 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11995 avoiding the 0 flag, which is not portable.
c2982e87
PE
11996 * process.c (Fmake_network_process): Use pI to avoid cast.
11997 * region-cache.c (pp_cache): Likewise.
11998 * xdisp.c (decode_mode_spec): Likewise.
11999 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12000 behavior on 64-bit hosts with printf arg.
6f04d126 12001 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12002 (x_stop_queuing_selection_requests): Likewise.
12003 (x_get_window_property): Don't truncate byte count to an 'int'
12004 when tracing.
0b432f21 12005
5e073ec7
PE
12006 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12007 here, since it parses constructs like leading '-' and spaces,
12008 which are not wanted; and it overflows with large numbers.
12009 Instead, simply match F[0-9]+, which is what is wanted anyway.
12010
36372bf9
PE
12011 * alloc.c: Remove unportable assumptions about struct layout.
12012 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12013 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12014 (allocate_vectorlike, make_pure_vector): Use the new macros,
12015 plus offsetof, to remove unportable assumptions about struct layout.
12016 These assumptions hold on all porting targets that I know of, but
12017 they are not guaranteed, they're easy to remove, and removing them
12018 makes further changes easier.
12019
0b432f21
PE
12020 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12021 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12022 (string_overrun_cookie): Now const. Use initializers that
12023 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12024 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12025 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12026 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12027 multiple of sizeof (EMACS_INT); it need not be, if
12028 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12029 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12030
895009e1
JB
120312011-04-26 Juanma Barranquero <lekktu@gmail.com>
12032
12033 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12034
6a7a1b0b
TZ
120352011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12036
12037 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12038 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12039 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12040
841a1577 120412011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12042
12043 * lisp.h (Qdebug): List symbol.
895009e1 12044 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12045 * keyboard.c (debug-on-event): New variable.
12046 (handle_user_signal): Break into debugger when debug-on-event
12047 matches the current signal symbol.
12048
f2d3ba6f
DN
120492011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12050
12051 * alloc.c (check_sblock, check_string_bytes)
12052 (check_string_free_list): Convert to standard C.
12053
42ce4c63
TZ
120542011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12055
12056 * w32.c (emacs_gnutls_push): Fix typo.
12057
825cd63c
EZ
120582011-04-25 Eli Zaretskii <eliz@gnu.org>
12059
fb11d64d
EZ
12060 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12061 "cast to pointer from integer of different size".
12062
825cd63c
EZ
12063 Improve doprnt and its use in verror. (Bug#8545)
12064 * doprnt.c (doprnt): Document the set of format control sequences
12065 supported by the function. Use SAFE_ALLOCA instead of always
12066 using `alloca'.
12067
12068 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12069 is one byte too soon. Don't use xrealloc; instead xfree and
12070 xmalloc anew.
12071
e061a11b
TZ
120722011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12073
12074 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12075 callbacks stage.
12076
12077 * gnutls.c: Renamed global_initialized to
12078 gnutls_global_initialized. Added internals for the
12079 :verify-hostname-error, :verify-error, and :verify-flags
12080 parameters of `gnutls-boot' and documented those parameters in the
12081 docstring. Start callback support.
9173deec
JB
12082 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12083 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12084 on error. Return error code.
e061a11b
TZ
12085 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12086 (emacs_gnutls_read): Likewise.
12087 (Fgnutls_boot): Return handshake error code.
12088 (emacs_gnutls_handle_error): New function.
12089 (wsaerror_to_errno): Likewise.
12090
12091 * w32.h (emacs_gnutls_pull): Add prototype.
12092 (emacs_gnutls_push): Likewise.
12093
12094 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12095 (emacs_gnutls_push): Likewise.
12096
120972011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12098
12099 * process.c (wait_reading_process_output): Check if GnuTLS
12100 buffered some data internally if no FDs are set for TLS
12101 connections.
12102
12103 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12104 (LIBS): Link to USER_LIBS.
12105 ($(BLD)/gnutls.$(0)): New target.
12106
fa6996bc
EZ
121072011-04-24 Eli Zaretskii <eliz@gnu.org>
12108
eb35682e
EZ
12109 * xdisp.c (handle_single_display_spec): Rename the
12110 display_replaced_before_p argument into display_replaced_p, to
12111 make it consistent with the commentary. Fix typos in the
12112 commentary.
12113
e2ad650c
EZ
12114 * textprop.c (syms_of_textprop): Remove dead code.
12115 (copy_text_properties): Delete obsolete commentary about an
12116 interface that was deleted long ago. Fix typos in the description
12117 of arguments.
12118
1b2de274
EZ
12119 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12120 to changes in oldXMenu/XMenu.h from 2011-04-16.
12121 <menu_help_message, prev_menu_help_message>: Constify.
12122 (IT_menu_make_room): menu->help_text is now `const char **';
12123 adjust.
12124
12125 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12126 to changes in oldXMenu/XMenu.h from 2011-04-16.
12127 (struct XMenu): Declare `help_text' `const char **'.
12128
12129 * xfaces.c <Qunspecified>: Make extern again.
12130
12131 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12132 required by POSIX.
1b2de274 12133
762b15be
EZ
12134 * doc.c (get_doc_string): Improve the format passed to `error'.
12135
12136 * doprnt.c (doprnt): Improve commentary.
12137
12138 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12139
12140 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12141 them with etags.
12142
f1052e5d
EZ
12143 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12144 changes in globals.h immediately force recompilation.
762b15be
EZ
12145 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12146 $(CURDIR)/s/ms-w32.h.
12147 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12148
fa6996bc
EZ
12149 * character.c (Fchar_direction): Function deleted.
12150 (syms_of_character): Don't defsubr it.
12151 <char-direction-table>: Deleted.
12152
e6c3da20
EZ
121532011-04-23 Eli Zaretskii <eliz@gnu.org>
12154
12155 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12156 * doprnt.c: Include limits.h.
12157 (SIZE_MAX): New macro.
04f2d78b
CB
12158 (doprnt): Return a size_t value. 2nd arg is now size_t.
12159 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12160 Improve overflow protection. Support `l' modifier for integer
12161 conversions. Support %l conversion. Don't assume an EMACS_INT
12162 argument for integer conversions and for %c.
12163
12164 * lisp.h (doprnt): Restore prototype.
12165
12166 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12167 $(SRC)/character.h.
12168
12169 * Makefile.in (base_obj): Add back doprnt.o.
12170
12171 * deps.mk (doprnt.o): Add back prerequisites.
12172 (callint.o): Depend on character.h.
12173
12174 * eval.c (internal_lisp_condition_case): Include the handler
12175 representation in the error message.
12176 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12177 when breaking from the loop.
12178
12179 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12180
12181 * callint.c (Fcall_interactively): When displaying error message
12182 about invalid control letter, pass the character's codepoint, not
12183 a pointer to its multibyte form. Improve display of the character
12184 in octal and display also its hex code.
12185
12186 * character.c (char_string): Use %x to display the (unsigned)
12187 codepoint of an invalid character, to avoid displaying a bogus
12188 negative value.
12189
12190 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12191 `error', not SYMBOL_NAME itself.
12192
12193 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12194 character arguments to `error'.
12195
12196 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12197 to `error' in error message about FINAL_CHAR argument. Make sure
12198 FINAL_CHAR is a character, and use %c when it is passed as
12199 argument to `error'.
12200
4ffd0d6b 122012011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12202
12203 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12204
12205 * w32.c: Include <time.h>.
12206 (sys_localtime): New function.
12207
4ffd0d6b 122082011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12209
12210 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12211
4ffd0d6b 12212 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12213
4ffd0d6b 122142011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12215
4ffd0d6b
GM
12216 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12217 zombies (Bug#8467).
aac0c6e3 12218
04c56954
EZ
122192011-04-19 Eli Zaretskii <eliz@gnu.org>
12220
12221 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12222 gl_state.e_property when gl_state.object is Qt.
12223
12224 * insdel.c (make_gap_larger): Remove limitation of buffer size
12225 to <= INT_MAX.
12226
16a43933
CY
122272011-04-18 Chong Yidong <cyd@stupidchicken.com>
12228
12229 * xdisp.c (lookup_glyphless_char_display)
12230 (produce_glyphless_glyph): Handle cons cell entry in
12231 glyphless-char-display.
12232 (Vglyphless_char_display): Document it.
12233
12234 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12235 glyphless-char-display.
12236
4581706e
CY
122372011-04-17 Chong Yidong <cyd@stupidchicken.com>
12238
12239 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12240
12241 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12242
12243 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12244 definition for no-X builds.
12245
4887c6e2 122462011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12247
fd35b6f9
PE
12248 Static checks with GCC 4.6.0 and non-default toolkits.
12249
5c1ccb01
PE
12250 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12251
006c5daa
PE
12252 * process.c (keyboard_bit_set): Define only if SIGIO.
12253 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12254 (send_process): Repair possible setjmp clobbering.
12255
efc736d3
PE
12256 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12257
4e2fe2e6
PE
12258 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12259
f97334a2
PE
12260 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12261
4e75f29d
PE
12262 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12263 Define only if needed.
12264
90efadd1
PE
12265 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12266 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12267 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12268
3c647824
PE
12269 * dispextern.h (struct redisplay_interface): Rename param
12270 to avoid shadowing.
e264f262 12271 * termhooks.h (struct terminal): Likewise.
761383f4 12272 * xterm.c (xembed_send_message): Likewise.
3c647824 12273
b58c5c4a
PE
12274 * insdel.c (make_gap_smaller): Define only if
12275 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12276
cad59032
PE
12277 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12278 it.
12279
c339dc2e
PE
12280 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12281 so that we aren't warned about unused symbols.
12282
91a3e27b
PE
12283 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12284
399c71d3 12285 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12286
8ffc96f5
PE
12287 * xfns.c (x_real_positions): Mark locals as initialized.
12288
eef9bc79
PE
12289 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12290
098db9dd
PE
12291 * xterm.c: Fix problems found by static analysis with other toolkits.
12292 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12293 (x_dispatch_event): Declare static if USE_GTK, and
12294 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12295 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12296 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12297 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12298 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12299
eb18f6cc
PE
12300 * xmenu.c (menu_help_callback): Pointer type fixes.
12301 Use const pointers when pointing at readonly data. Avoid pointer
12302 signedness clashes.
12303 (FALSE): Remove unused macro.
12304 (update_frame_menubar): Remove unused decl.
12305
1fe72bf8
PE
12306 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12307
60d9e1db
PE
12308 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12309 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12310 (single_menu_item): Rename local to avoid shadowing.
12311
39261c26
PE
12312 * keyboard.c (make_lispy_event): Remove unused local var.
12313
018c5e19
PE
12314 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12315 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12316
63d2b86e
PE
12317 * bitmaps: Change bitmaps from unsigned char back to the X11
12318 compatible char. Avoid the old compiler warnings about
12319 out-of-range initializers by using, for example, '\xab' rather
12320 than 0xab.
12321
aefd87e1
PE
12322 * xgselect.c (xgselect_initialize): Check vs interface
12323 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12324
bf501fb9
PE
12325 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12326
e9829fdf
PE
12327 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12328 to read-only memory.
12329
1086c095
PE
12330 * fns.c (vector): Remove; this old hack is no longer needed.
12331
2baccd04 12332 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12333 Remove unused var.
dde42981 12334 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12335
72391843 12336 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12337
436c16df 12338 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12339 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12340 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12341
92bb796d 12342 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12343 (x_term_init): Remove local to avoid shadowing.
92bb796d 12344
764430a3 12345 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12346
12347 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12348 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12349
d1dfb56c
EZ
123502011-04-16 Eli Zaretskii <eliz@gnu.org>
12351
c4354cb4
EZ
12352 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12353
d1dfb56c
EZ
12354 Fix regex.c, syntax.c and friends for buffers > 2GB.
12355 * syntax.h (struct gl_state_s): Declare character position members
12356 EMACS_INT.
12357
12358 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12359
04f2d78b
CB
12360 * textprop.c (verify_interval_modification, interval_of):
12361 Declare arguments EMACS_INT.
d1dfb56c
EZ
12362
12363 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12364 EMACS_INT.
12365
12366 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12367
12368 * indent.c (Fvertical_motion): Local variable it_start is now
12369 EMACS_INT.
12370
12371 * regex.c (re_match, re_match_2, re_match_2_internal)
12372 (bcmp_translate, regcomp, regexec, print_double_string)
12373 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12374 (re_compile_pattern, re_exec): Declare arguments and local
12375 variables `size_t' and `ssize_t' and return values `regoff_t', as
12376 appropriate.
12377 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12378 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12379 <compile_stack_type>: `size' and `avail' are now `size_t'.
12380
12381 * regex.h <regoff_t>: Use ssize_t, not int.
12382 (re_search, re_search_2, re_match, re_match_2): Arguments that
12383 specify buffer/string position and length are now ssize_t and
12384 size_t. Return type is regoff_t.
12385
613052cd
BK
123862011-04-16 Ben Key <bkey76@gmail.com>
12387
12388 * nsfont.m: Fixed bugs in ns_get_family and
12389 ns_descriptor_to_entity that were caused by using free to
12390 deallocate memory blocks that were allocated by xmalloc (via
12391 xstrdup). This caused Emacs to crash when compiled with
12392 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12393 --enable-checking=xmallocoverrun). xfree is now used to
12394 deallocate these memory blocks.
12395
4170f62f 123962011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12397
71b41406
PE
12398 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12399
9587a89d
PE
12400 emacs_write: Accept and return EMACS_INT for sizes.
12401 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12402 et seq.
12403 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12404 Accept and return EMACS_INT.
12405 (emacs_gnutls_write): Return the number of bytes written on
12406 partial writes.
12407 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12408 (emacs_read, emacs_write): Remove check for negative size, as the
12409 Emacs source code has been audited now.
9587a89d
PE
12410 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12411 (emacs_read, emacs_write): Use it.
273a5f82
PE
12412 * process.c (send_process): Adjust to the new signatures of
12413 emacs_write and emacs_gnutls_write. Do not attempt to store
12414 a byte offset into an 'int'; it might overflow.
9587a89d 12415 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12416
3e047f51
PE
12417 * sound.c: Don't assume sizes fit in 'int'.
12418 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12419 Return EMACS_INT, not int.
3e047f51 12420 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12421 Accept EMACS_INT, not int.
12422 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12423 record read return values.
12424
cc39a9db
BK
124252011-04-15 Ben Key <bkey76@gmail.com>
12426
c9d0ec6d
JB
12427 * keyboard.c (Qundefined): Don't declare static since it is used
12428 in nsfns.m.
12429 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12430 static since they are used in nsfont.m.
cc39a9db 12431
6c60eb9f
SM
124322011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12433
12434 * process.c (Qprocessp): Don't declare static.
12435 * lisp.h (Qprocessp): Declare again.
12436
7990b61a
JB
124372011-04-15 Juanma Barranquero <lekktu@gmail.com>
12438
12439 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12440
5d4cb038
PE
124412011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12442
8bd7b830 12443 Improve C-level modularity by making more things 'static'.
cd64ea1d 12444
e3b27b31
PE
12445 Don't publish debugger-only interfaces to other modules.
12446 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12447 (verify_bytepos, count_markers): Move decls to the only modules
12448 that need them.
12449 * region-cache.h (pp_cache): Likewise.
12450 * window.h (check_all_windows): Likewise.
12451 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12452
5d4cb038
PE
12453 * sysdep.c (croak): Now static, if
12454 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12455 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12456
12457 * alloc.c (refill_memory_reserve): Now static if
12458 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12459 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12460
e87b6180
PE
12461 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12462 Define only if USE_LUCID.
12463
ac64929e
PE
12464 * xrdb.c (x_customization_string, x_rm_string): Now static.
12465
6f37259d
PE
12466 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12467 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12468
1683e3ab
PE
12469 * xdisp.c (draw_row_with_mouse_face): Now static.
12470 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12471
de9c2632
PE
12472 * window.h (check_all_windows): Mark externally visible.
12473
2b96acb7
PE
12474 * window.c (window_deletion_count): Now static.
12475
12476 * undo.c: Make symbols static if they're not exported.
12477 (last_undo_buffer, last_boundary_position, pending_boundary):
12478 Now static.
12479
50436f33
PE
12480 * textprop.c (interval_insert_behind_hooks): Now static.
12481 (interval_insert_in_front_hooks): Likewise.
12482
64520e5c
PE
12483 * term.c: Make symbols static if they're not exported.
12484 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12485 (max_frame_lines, tty_set_terminal_modes):
12486 (tty_reset_terminal_modes, tty_turn_off_highlight):
12487 (get_tty_terminal): Now static.
12488 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12489 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12490 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12491 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12492 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12493
1fa53021
PE
12494 * sysdep.c: Make symbols static if they're not exported.
12495 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12496 Now static.
12497 (sigprocmask_set, full_mask): Remove; unused.
12498 (wait_debugging): Mark as visible.
12499 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12500 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12501
d4b43b22
PE
12502 * syntax.c (syntax_temp): Define only if !__GNUC__.
12503
b7c513d0
PE
12504 * sound.c (current_sound_device, current_sound): Now static.
12505
989b29ad
PE
12506 * search.c (searchbufs, searchbuf_head): Now static.
12507
13a55a78
PE
12508 * scroll.c (scroll_cost): Remove; unused.
12509 * dispextern.h (scroll_cost): Remove decl.
12510
de68a1fc
PE
12511 * region-cache.h (pp_cache): Mark as externally visible.
12512
40ccffa6
PE
12513 * process.c: Make symbols static if they're not exported.
12514 (process_tick, update_tick, create_process, chan_process):
12515 (Vprocess_alist, proc_buffered_char, datagram_access):
12516 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12517 (deactivate_process): Mark defn as static, as well as decl.
12518 * lisp.h (create_process): Remove decl.
12519 * process.h (chan_process, Vprocess_alist): Remove decls.
12520
ad64fc97
PE
12521 * print.c: Make symbols static if they're not exported.
12522 (print_depth, new_backquote_output, being_printed, print_buffer):
12523 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12524 (print_interval, print_number_index, initial_stderr_stream):
12525 Now static.
12526 * lisp.h (Fprinc): Remove decl.
12527 (debug_output_compilation_hack): Mark as externally visible.
12528
adddb265
PE
12529 * sysdep.c (croak): Move decl from here to syssignal.h.
12530 * syssignal.h (croak): Put it here, so the API can be checked when
12531 'croak' is called from dissociate_if_controlling_tty.
12532
1717ede2
PE
12533 * minibuf.c: Make symbols static if they're not exported.
12534 (minibuf_save_list, choose_minibuf_frame): Now static.
12535 * lisp.h (choose_minibuf_frame): Remove decl.
12536
fa5fb2bc
PE
12537 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12538
1e3890d1
PE
12539 * lread.c: Make symbols static if they're not exported.
12540 (read_objects, initial_obarray, oblookup_last_bucket_number):
12541 Now static.
12542 (make_symbol): Remove; unused.
12543 * lisp.h (initial_obarray, make_symbol): Remove decls.
12544
8a1414fa
PE
12545 * keyboard.c: Make symbols static if they're not exported.
12546 (single_kboard, recent_keys_index, total_keys, recent_keys):
12547 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12548 (this_single_command_key_start, echoing, last_auto_save):
12549 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12550 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12551 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12552 (Vlispy_mouse_stem, double_click_count):
12553 Now static.
12554 (force_auto_save_soon): Define only if SIGDANGER.
12555 (ignore_mouse_drag_p): Now static if
12556 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12557 (print_help): Remove; unused.
12558 (stop_character, last_timer_event): Mark as externally visible.
12559 * keyboard.h (ignore_mouse_drag_p): Declare only if
12560 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12561 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12562 * lisp.h (echoing): Remove decl.
12563 (force_auto_save_soon): Declare only if SIGDANGER.
12564 * xdisp.c (redisplay_window): Simplify code, to make it more
12565 obvious that ignore_mouse_drag_p is not accessed if !defined
12566 USE_GTK && !defined HAVE_NS.
12567
93ea6e8f
PE
12568 * intervals.c: Make symbols static if they're not exported.
12569 (merge_properties_sticky, merge_interval_right, delete_interval):
12570 Now static.
12571 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12572
77382fcc
PE
12573 * insdel.c: Make symbols static if they're not exported.
12574 However, leave prepare_to_modify_buffer alone. It's never
12575 called from outside this function, but that appears to be a bug.
12576 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12577 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12578 (adjust_after_replace_noundo): Remove; unused.
12579 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12580 (signal_before_change): Remove decls.
77382fcc 12581
9306c32e
PE
12582 * indent.c (val_compute_motion, val_vmotion): Now static.
12583
cd44d2eb
PE
12584 * image.c: Make symbols static if they're not exported.
12585 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12586 if USE_GTK.
12587 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12588 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12589
ad9a7a06
PE
12590 * fringe.c (standard_bitmaps): Now static.
12591 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12592
81626931
PE
12593 * frame.c: Make symbols static if they're not exported.
12594 (x_report_frame_params, make_terminal_frame): Now static.
12595 (get_frame_param): Now static, unless HAVE_NS.
12596 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12597 (x_get_resource_string): Remove; not used.
12598 * frame.h (make_terminal_frame, x_report_frame_params):
12599 (x_get_resource_string); Remove decls.
12600 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12601 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12602
239f9db9
PE
12603 * font.c, fontset.c: Make symbols static if they're not exported.
12604 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12605 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12606 * font.c (font_close_object): Now static.
12607 * font.h (font_close_object): Remove.
12608 * fontset.c (FONTSET_OBJLIST): Remove.
12609 (free_realized_fontset) #if-0 the body, which does nothing.
12610 (face_suitable_for_char_p): #if-0, as it's never called.
12611 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12612 * xfaces.c (face_at_string_position):
12613 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12614 since 0 is always ASCII.
12615
dfcf3579
PE
12616 * fns.c (weak_hash_tables): Now static.
12617
5045092b
PE
12618 * fileio.c: Make symbols static if they're not exported.
12619 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12620 (Vwrite_region_annotation_buffers): Now static.
12621
57a96f5c
PE
12622 * eval.c: Make symbols static if they're not exported.
12623 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12624 * lisp.h (backtrace_list): Remove decl.
12625
35f08c38
PE
12626 * emacs.c: Make symbols static if they're not exported.
12627 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12628 (fatal_error_code, fatal_error_signal_hook, standard_args):
12629 Now static.
12630 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12631 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12632 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12633 * lisp.h (fatal_error_signal_hook): Remove decl.
12634 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12635
f44bd759
PE
12636 * editfns.c: Move a (normally-unused) function to its only use.
12637 * editfns.c, lisp.h (get_operating_system_release): Remove.
12638 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12639 worth the hassle of breaking this out.
12640
b532497d
PE
12641 * xterm.c: Make symbols static if they're not exported.
12642 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12643 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12644 (x_destroy_window, x_delete_display):
12645 Now static.
12646 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12647 (x_mouse_leave): Remove; unused.
12648 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12649 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12650 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12651 Remove decls.
12652 (x_mouse_leave): Declare only if WINDOWSNT.
12653 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12654 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12655 USE_X_TOOLKIT.
12656
1675728f
PE
12657 * ftxfont.c: Make symbols static if they're not exported.
12658 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12659 HAVE_FREETYPE.
12660 * font.h (ftxfont_driver): Likewise.
12661
e4cebfca
PE
12662 * xfns.c: Make symbols static if they're not exported.
12663 (x_last_font_name, x_display_info_for_name):
12664 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12665 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12666 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12667 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12668 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12669 (last_show_tip_args): Now static.
12670 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12671 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12672 (x_screen_planes): Remove; unused.
12673 * dispextern.h (x_screen_planes): Remove decl.
12674
5bf46f05
PE
12675 * dispnew.c: Make symbols static if they're not exported.
12676 * dispextern.h (redraw_garbaged_frames, scrolling):
12677 (increment_row_positions): Remove.
12678 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12679 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12680 Now static.
12681 (redraw_garbaged_frames): Remove; unused.
12682
435f4c28
PE
12683 * xfaces.c: Make symbols static if they're not exported.
12684 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12685 Remove decls.
12686 * xterm.h (defined_color): Remove decls.
12687 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12688 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12689 (menu_face_changed_default, defined_color, free_realized_face):
12690 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12691 (ascii_face_of_lisp_face): Remove; unused.
12692
8524aef3
PE
12693 * xdisp.c: Make symbols static if they're not exported.
12694 * dispextern.h (scratch_glyph_row, window_box_edges):
12695 (glyph_to_pixel_coords, set_cursor_from_row):
12696 (get_next_display_element, set_iterator_to_next):
12697 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12698 (show_mouse_face): Remove decls
12699 * frame.h (message_buf_print): Likewise.
12700 * lisp.h (pop_message, set_message, check_point_in_composition):
12701 Likewise.
12702 * xterm.h (set_vertical_scroll_bar): Likewise.
12703 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12704 (message_buf_print, scratch_glyph_row, displayed_buffer):
12705 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12706 (get_next_display_element, show_mouse_face, window_box_edges):
12707 (frame_to_window_pixel_xy, check_point_in_composition):
12708 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12709 (glyph_to_pixel_coords): Remove; unused.
12710
16390cd2
PE
12711 * dired.c (file_name_completion): Now static.
12712
12713 * dbusbind.c (xd_in_read_queued_messages): Now static.
12714
a25f4dfa
PE
12715 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12716 * data.c (circular_list_error): Remove.
12717
14a9c8df
PE
12718 * commands.h (last_point_position, last_point_position_buffer):
12719 (last_point_position_window): Remove decls.
12720 * keyboard.c: Make these variables static.
12721
04f2d78b
CB
12722 * coding.h (coding, code_convert_region, encode_coding_gap):
12723 Remove decls.
74ab6df5
PE
12724 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12725 (iso_code_class, detect_coding, code_convert_region): Now static.
12726 (encode_coding_gap): Remove; unused.
12727
38dfbee1
PE
12728 * chartab.c (chartab_chars, chartab_bits): Now static.
12729
a2cb4e63
PE
12730 * charset.h (charset_iso_8859_1): Remove decl.
12731 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12732 Now static.
12733
127198fd
PE
12734 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12735 * ccl.c (Vccl_program_table): Now static.
12736 (check_ccl_update): Remove; unused.
12737
d85b608f
PE
12738 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12739 * category.h: ... from here.
12740 * category.c (check_category_table, set_category_set): Now static.
12741
31cd66f3
PE
12742 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12743 * lisp.h: Remove these decls.
12744
c358e587
PE
12745 * buffer.c (buffer_count): Remove unused var.
12746
e78aecca
PE
12747 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12748 so that it's not optimized away.
12749 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12750 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12751 exported only to the debugger.
12752
e192d7d3 12753 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12754 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12755
92470028
PE
12756 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12757 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12758 was inaccessible from Lisp.
12759 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12760 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12761
244ed907
PE
12762 alloc.c: Import and export fewer symbols, and remove unused items.
12763 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12764 is defined.
12765 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12766 it's not optimized away by whole-program optimization.
12767 (message_enable_multibyte, free_misc): Remove.
12768 (catchlist, handlerlist, mark_backtrace):
12769 Declare only if BYTE_MARK_STACK.
12770 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12771 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12772 (message_enable_multibyte): Remove decl.
12773 (free_misc, interval_free_list, float_block, float_block_index):
12774 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12775 (cons_free_list, last_marked_index):
12776 Now static.
12777 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12778 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12779 (mark_backtrace): Define only if BYTE_MARK_STACK.
12780 * xdisp.c (message_enable_multibyte): Now static.
12781
61c2b50e 12782 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12783 This makes it easier for human readers (and static analyzers)
12784 to see whether these variables are used from other modules.
12785 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12786 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12787 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12788 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12789 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12790 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12791 * xmenu.c, xselect.c:
12792 Declare Q* vars static if they are not used in other modules.
12793 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12794 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12795 Remove decls of unexported vars.
12796 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12797
95c82688
PE
12798 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12799
16a97296
PE
12800 Make Emacs functions such as Fatom 'static' by default.
12801 This makes it easier for human readers (and static analyzers)
12802 to see whether these functions can be called from other modules.
12803 DEFUN now defines a static function. To make the function external
12804 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12805 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12806 (Finit_image_library):
16a97296
PE
12807 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12808 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12809 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12810 Remove decls, since these functions are now static.
12811 (Funintern, Fget_internal_run_time): New decls, since these functions
12812 were already external.
95c82688 12813
16a97296
PE
12814 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12815 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12816 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12817 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12818 * keyboard.c, keymap.c, lread.c:
12819 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12820 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12821 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12822 Mark functions with DEFUE instead of DEFUN,
12823 if they are used in other modules.
12824 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12825 decls for now-static functions.
12826 * buffer.h (Fdelete_overlay): Remove decl.
12827 * callproc.c (Fgetenv_internal): Mark as internal.
12828 * composite.c (Fremove_list_of_text_properties): Remove decl.
12829 (Fcomposition_get_gstring): New forward static decl.
12830 * composite.h (Fcomposite_get_gstring): Remove decl.
12831 * dired.c (Ffile_attributes): New forward static decl.
12832 * doc.c (Fdocumntation_property): New forward static decl.
12833 * eval.c (Ffetch_bytecode): New forward static decl.
12834 (Funintern): Remove extern decl; now in .h file where it belongs.
12835 * fileio.c (Fmake_symbolic_link): New forward static decl.
12836 * image.c (Finit_image_library): New forward static decl.
12837 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12838 * intervals.h (Fprevious_property_change):
12839 (Fremove_list_of_text_properties): Remove decls.
12840 * keyboard.c (Fthis_command_keys): Remove decl.
12841 (Fcommand_execute): New forward static decl.
12842 * keymap.c (Flookup_key): New forward static decl.
12843 (Fcopy_keymap): Now static.
12844 * keymap.h (Flookup_key): Remove decl.
12845 * process.c (Fget_process): New forward static decl.
12846 (Fprocess_datagram_address): Mark as internal.
12847 * syntax.c (Fsyntax_table_p): New forward static decl.
12848 (skip_chars): Remove duplicate decl.
12849 * textprop.c (Fprevious_property_change): New forward static decl.
12850 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12851 Now internal.
12852 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12853 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12854
785bbd42
PE
12855 * editfns.c (Fformat): Remove unreachable code.
12856
8b913b57
AS
128572011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12858
12859 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12860 change. (Bug#8496)
12861
a6744a35
EZ
128622011-04-13 Eli Zaretskii <eliz@gnu.org>
12863
12864 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12865 when at ZV. (Bug#8487)
12866
e7974947
AS
128672011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12868
baad03f0
AS
12869 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12870 (Bug#8437)
12871 * keyboard.c (parse_tool_bar_item): Likewise.
12872 * sound.c (sound_cleanup, alsa_close): Likewise.
12873 * termcap.c (tgetent): Likewise.
12874 * xfns.c (x_default_font_parameter): Likewise.
12875 * xsettings.c (read_and_apply_settings): Likewise.
12876
e7974947
AS
12877 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12878 (overrun_check_free): Protoize.
12879
28272684
PE
128802011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12881
12882 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12883 since callers should never pass a negative size.
12884 Change the signature to match that of plain 'read' and 'write'; see
12885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12886 * lisp.h: Update prototypes of emacs_write and emacs_read.
12887
11997c76
EZ
128882011-04-11 Eli Zaretskii <eliz@gnu.org>
12889
12890 * xdisp.c (redisplay_window): Don't try to determine the character
12891 position of the scroll margin if the window start point w->startp
e896f03c 12892 is outside the buffer's accessible region. (Bug#8468)
11997c76 12893
8a2cbd72
EZ
128942011-04-10 Eli Zaretskii <eliz@gnu.org>
12895
12896 Fix write-region and its subroutines for buffers > 2GB.
12897 * fileio.c (a_write, e_write): Modify declaration of arguments and
12898 local variables to support buffers larger than 2GB.
12899 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12900
12901 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12902 argument, local variables, and return value.
12903
12904 * lisp.h: Update prototypes of emacs_write and emacs_read.
12905
12906 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12907
4073e537 129082011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12909
1ebfdcb6
PE
12910 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12911
b2ded58d
PE
12912 Fix more problems found by GCC 4.6.0's static checks.
12913
7d66342c
PE
12914 * xdisp.c (vmessage): Use a better test for character truncation.
12915
bbf47d44
PE
12916 * charset.c (load_charset_map): <, not <=, for optimization,
12917 and to avoid potential problems with integer overflow.
9248994d 12918 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12919 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12920 * editfns.c (Fformat): Likewise.
1e69125e 12921 * syntax.c (skip_chars): Likewise.
3befa583 12922
e3019616
PE
12923 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12924 This also lets GCC 4.6.0 generate slightly better loop code.
12925
becfa255
PE
12926 * callint.c (Fcall_interactively): <, not <=, for optimization.
12927 (Fcall_interactively): Count the number of arguments produced,
12928 not the number of arguments given. This is simpler and lets GCC
12929 4.6.0 generate slightly better code.
12930
dae0cd48
PE
12931 * ftfont.c: Distingish more carefully between FcChar8 and char.
12932 The previous code passed unsigned char * to a functions like
12933 strlen and xstrcasecmp that expect char *, which does not
12934 conform to the C standard.
12935 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12936 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12937 char * when the C standard requires it.
12938
76032d70
PE
12939 * keyboard.c (read_char): Remove unused var.
12940
eb3f1cc8
PE
12941 * eval.c: Port to Windows vsnprintf (Bug#8435).
12942 Include <limits.h>.
12943 (SIZE_MAX): Define if the headers do not.
12944 (verror): Do not give up if vsnprintf returns a negative count.
12945 Instead, grow the buffer. This ports to Windows vsnprintf, which
12946 does not conform to C99. Problem reported by Eli Zaretskii.
12947 Also, simplify the allocation scheme, by avoiding the need for
12948 calling realloc, and removing the ALLOCATED variable.
12949
70476b54
PE
12950 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12951
12020a9e
PE
12952 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12953 But keep the doprint source code for now, as we might revamp it
12954 and use it again (Bug#8435).
ea6c7ae6
PE
12955 * lisp.h (doprnt): Remove.
12956 * Makefile.in (base_obj): Remove doprnt.o.
12957 * deps.mk (doprnt.o): Remove.
12958
5fdb398c
PE
12959 error: Print 32- and 64-bit integers portably (Bug#8435).
12960 Without this change, on typical 64-bit hosts error ("...%d...", N)
12961 was used to print both 32- and 64-bit integers N, which relied on
12962 undefined behavior.
61bdb816 12963 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12964 * lisp.h (error, verror): Mark as printf-like functions.
12965 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12966 Report overflow in size calculations when allocating printf buffer.
12967 Do not truncate output string at its first null byte.
12968 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12969 Truncate the output at a character boundary, since vsnprintf does not
12970 do that.
12971 * charset.c (check_iso_charset_parameter): Convert internal
12972 character to string before calling 'error', since %c now has the
12973 printf meaning.
12974 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12975 overflow when computing char to be passed to 'error'. Do not
12976 pass Lisp_Object to 'error'; pass the integer instead.
12977 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12978 formatted with plain %d.
12979
b189fa66
PE
12980 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12981
bff87ef0
PE
12982 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12983
7e2cac20
PE
12984 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12985
ce4d90b5
PE
12986 * xterm.c (x_catch_errors): Remove duplicate declaration.
12987
266c9547
PE
12988 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12989
79c49ad2
PE
12990 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12991
368f4090
JM
129922011-04-10 Jim Meyering <meyering@redhat.com>
12993
12994 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12995 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12996 return ssize_t not "int", and use size_t as the buffer length.
12997 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12998 * gnutls.h: Update declarations.
12999 * process.c (read_process_output): Use ssize_t, to match.
13000 (send_process): Likewise.
13001
a32d4040
CY
130022011-04-09 Chong Yidong <cyd@stupidchicken.com>
13003
13004 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13005
8546720e 130062011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13007
04f2d78b
CB
13008 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13009 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13010
8546720e
GM
13011 * xterm.c (handle_one_xevent):
13012 * xmenu.c (create_and_show_popup_menu):
13013 * xselect.c (x_decline_selection_request)
13014 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13015
0a2f5c1a 130162011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13017
13018 Fix some uses of `int' instead of EMACS_INT.
13019 * search.c (string_match_1, fast_string_match)
13020 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13021 (scan_buffer, find_next_newline_no_quit)
13022 (find_before_next_newline, search_command, Freplace_match)
13023 (Fmatch_data): Make some `int' variables be EMACS_INT.
13024
13025 * xdisp.c (display_count_lines): 3rd argument and return value now
13026 EMACS_INT. All callers changed.
13027 (pint2hrstr): Last argument is now EMACS_INT.
13028
13029 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13030 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13031 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13032 (decode_coding_utf_16, decode_coding_emacs_mule)
13033 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13034 (decode_coding_ccl, decode_coding_charset)
13035 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13036 (decode_coding_iso_2022, decode_coding_emacs_mule)
13037 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13038 <char_offset, last_offset>: Declare EMACS_INT.
13039 (encode_coding_utf_8, encode_coding_utf_16)
13040 (encode_coding_emacs_mule, encode_invocation_designation)
13041 (encode_designation_at_bol, encode_coding_iso_2022)
13042 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13043 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13044 Declare EMACS_INT.
13045 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13046 (encode_invocation_designation): Last argument P_NCHARS is now
13047 EMACS_INT.
13048 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13049 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13050
13051 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13052 All users changed.
13053
13054 * ccl.c (Fccl_execute_on_string): Declare some variables
13055 EMACS_INT.
13056
8546720e 130572011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13058
13059 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13060
4e19a977
CS
130612011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13062
13063 * process.c (Fformat_network_address): Doc fix.
13064
87302331
R
130652011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13066
ee7683eb 13067 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13068
cbb59342
CY
130692011-04-08 Chong Yidong <cyd@stupidchicken.com>
13070
13071 * keyboard.c (read_char): Call Lisp function help-form-show,
13072 instead of using internal_with_output_to_temp_buffer.
13073 (Qhelp_form_show): New var.
e0d38eeb 13074 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13075
13076 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13077
13078 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13079
e67a13ab
CY
130802011-04-06 Chong Yidong <cyd@stupidchicken.com>
13081
04f2d78b
CB
13082 * process.c (Flist_processes): Remove to Lisp.
13083 (list_processes_1): Delete.
e67a13ab 13084
973f782d
EZ
130852011-04-06 Eli Zaretskii <eliz@gnu.org>
13086
7c106b1e
EZ
13087 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13088
973f782d
EZ
13089 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13090
41cf7d1a 130912011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13092
ca23cc88
PE
13093 Fix more problems found by GCC 4.6.0's static checks.
13094
f390e2d5
PE
13095 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13096
42eea0d0
PE
13097 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13098
b69769da 13099 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13100
f9541e84
PE
13101 * xdisp.c (vmessage): Mark as a printf-like function.
13102
13841b55
PE
13103 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13104
c136c10f
PE
13105 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13106
5e2d4a30
PE
13107 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13108 printf-like functions.
13109 (tiff_load): Add casts to remove these marks before passing them
13110 to system-supplied API.
13111
583f48b9
PE
13112 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13113
b25d760e
PE
13114 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13115 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13116 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13117 directly, rather than having caller test rule sign. This avoids
13118 some unnecessary tests.
13119 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13120 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13121 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13122
bc7b6697 13123 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13124 (xfont_open): Avoid unnecessary tests.
bc7b6697 13125
27ccc379
PE
13126 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13127
dcd5c89a
PE
13128 * composite.h, composite.c (composition_gstring_put_cache):
13129 Use EMACS_INT, not int, for length.
13130
b13a45c6
PE
13131 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13132 breaking out part of COMPOSITION_DECODE_RULE.
13133 (COMPOSITION_DECODE_RULE): Use it.
13134 * composite.c (get_composition_id): Remove unused local vars,
13135 by using the new macro.
13136
1e792e4d
PE
13137 * textprop.c (set_text_properties_1): Change while to do-while,
13138 since the condition is always true at first.
13139
dc6c6455 13140 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13141 (interval_deletion_adjustment): Return unsigned value.
13142 All uses changed.
dc6c6455 13143
aba7731a
PE
13144 * process.c (list_processes_1, create_pty, read_process_output):
13145 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13146 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13147 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13148 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13149 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13150
fdfc4bf3
PE
13151 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13152
fca8fe46 13153 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13154 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13155
06a0259a 13156 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13157 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13158 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13159
e7b9e80f
PE
13160 * print.c (print_error_message): Avoid int overflow.
13161
56201685
PE
13162 * font.c (font_list_entities): Redo for clarity,
13163 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13164
78834453 13165 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13166 (font_score): Avoid potential overflow in diff calculation.
78834453 13167
0bc0b309 13168 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13169 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13170
e610eaca
PE
13171 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13172
b895abce
PE
13173 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13174 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13175 can always succeed if overflow has undefined behavior.
13176
1f1d9321 13177 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13178 (wordify): Omit three unnecessary tests.
1f1d9321 13179
c59478bc
PE
13180 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13181 All callers changed. This avoids the need for an unused var.
13182
79b73827
PE
13183 * casefiddle.c (casify_region): Remove var that is set but not used.
13184
a4db5dfe
PE
13185 * dired.c (file_name_completion): Remove var that is set but not used.
13186
43aae36e
PE
13187 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13188
2a47c44d 13189 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13190 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13191
a37c69bf
PE
13192 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13193 Check for integer overflow on size calculations.
13194
328ab8e7
PE
13195 * buffer.c (Fprevious_overlay_change): Remove var that is set
13196 but not used.
13197
e5a2a5cb
PE
13198 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13199 Remove vars that are set but not used.
8d84a6eb 13200 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13201 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13202
a60e5f68
PE
13203 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13204
f661cb61 13205 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13206 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13207
f0397f5a
PE
13208 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13209 that are set but not used.
13210
8664db06 13211 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13212 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13213
6abdaa4a
PE
13214 * xselect.c (x_get_local_selection, x_handle_property_notify):
13215 Remove vars that are set but not used.
13216
0ce7538d 13217 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13218 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13219
9ae848fc
PE
13220 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13221 Remove var that is set but not used.
0b918413
PE
13222 (scroll_bar_windows_size): Now size_t, not int.
13223 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13224 Check for overflow.
9ae848fc 13225
a5a62657
PE
13226 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13227 (map_tty_color) [!defined MSDOS]: Likewise.
13228
5c5cdd39
PE
13229 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13230
66ebf983
PE
13231 * coding.c: Remove vars that are set but not used.
13232 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13233 All callers changed.
13234 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13235 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13236 (decode_coding_charset): Remove vars that are set but not used.
13237
1be4d761
PE
13238 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13239 that is set but not used.
13240
47553fa8
PE
13241 * print.c (print_object): Remove var that is set but not used.
13242
1f7196bf 13243 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13244 The gnulib version avoids calling malloc in the usual case,
13245 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13246 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13247 * filelock.c (current_lock_owner): Likewise.
13248 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13249 * sysdep.c: Include allocator.h, careadlinkat.h.
13250 (emacs_no_realloc_allocator): New static constant.
13251 (emacs_readlink): New function.
fdb61804
PE
13252 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13253 ../lib/careadlinkat.h.
d1fdcab7 13254
f84c17c7
SM
132552011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13256
13257 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13258 first non-nil return value).
13259
ef3862ad
JD
132602011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13261
13262 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13263 if not defined (Bug#8403).
13264
376a7006
JB
132652011-04-02 Juanma Barranquero <lekktu@gmail.com>
13266
13267 * xdisp.c (display_count_lines): Remove parameter `start',
13268 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13269 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13270 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13271 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13272 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13273 and thereabouts. All callers changed.
13274 (get_per_char_metric): Remove parameter `f', unused since
13275 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13276
6ca3801d
JM
132772011-04-02 Jim Meyering <meyering@redhat.com>
13278
13279 do not dereference NULL upon failed strdup
13280 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13281 (ns_get_family): Likewise.
13282
d8e2b5ba
JB
132832011-04-02 Juanma Barranquero <lekktu@gmail.com>
13284
13285 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13286
8c74fcbd
JD
132872011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13288
13289 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13290 later (Bug#8403).
13291
7200d79c
SM
132922011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13293
03408648 13294 Add lexical binding.
7200d79c 13295
03408648
SM
13296 * window.c (Ftemp_output_buffer_show): New fun.
13297 (Fsave_window_excursion):
13298 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13299
13300 * lread.c (lisp_file_lexically_bound_p): New function.
13301 (Fload): Bind Qlexical_binding.
13302 (readevalloop): Remove `evalfun' arg.
13303 Bind Qinternal_interpreter_environment.
13304 (Feval_buffer): Bind Qlexical_binding.
13305 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13306 Mark as dynamic.
13307 (syms_of_lread): Declare `lexical-binding'.
13308
13309 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13310
13311 * keyboard.c (eval_dyn): New fun.
13312 (menu_item_eval_property): Use it.
ca105506
SM
13313
13314 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13315
03408648
SM
13316 * fns.c (concat, mapcar1): Accept byte-code-functions.
13317
13318 * eval.c (Fsetq): Handle lexical vars.
13319 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13320 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13321 (FletX, Flet): Obey lexical binding.
13322 (Fcommandp): Handle closures.
13323 (Feval): New `lexical' arg.
13324 (eval_sub): New function extracted from Feval. Use it almost
13325 everywhere where Feval was used. Look up vars in lexical env.
13326 Handle closures.
13327 (Ffunctionp): Move from subr.el.
13328 (Ffuncall): Handle closures.
13329 (apply_lambda): Remove `eval_flags'.
13330 (funcall_lambda): Handle closures and new byte-code-functions.
13331 (Fspecial_variable_p): New function.
13332 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13333 but without exporting it to Lisp.
23aba0ea 13334
23aba0ea 13335 * doc.c (Fdocumentation, store_function_docstring):
03408648 13336 * data.c (Finteractive_form): Handle closures.
23aba0ea 13337
03408648
SM
13338 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13339 interactive spec.
ba83908c 13340
04f2d78b
CB
13341 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13342 New byte-codes.
03408648
SM
13343 (exec_byte_code): New function extracted from Fbyte_code to handle new
13344 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13345
03408648 13346 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13347
03408648 13348 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13349
e2abce01
JB
133502011-03-31 Juanma Barranquero <lekktu@gmail.com>
13351
13352 * xdisp.c (redisplay_internal): Fix prototype.
13353
63696a73 133542011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13355
63696a73 13356 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13357 (try_scrolling): Use it when setting scroll_limit.
13358 Limit scrolling to 100 screen lines.
63696a73
EZ
13359 (redisplay_window): Even when falling back on "recentering",
13360 position point in the window according to scroll-conservatively,
13361 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13362
13363 (try_scrolling): When point is above the window, allow searching
13364 as far as scroll_max, or one screenful, to compute vertical
13365 distance from PT to the scroll margin position. This prevents
13366 try_scrolling from unnecessarily failing when
13367 scroll-conservatively is set to a value slightly larger than the
13368 window height. Clean up the case of PT below the margin at bottom
13369 of window: scroll_max can no longer be INT_MAX. When aggressive
13370 scrolling is in use, don't let point enter the opposite scroll
13371 margin as result of the scroll.
13372 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13373 threshold of 100 lines for never-recentering scrolling.
13374
e4cc2dfc
JB
133752011-03-31 Juanma Barranquero <lekktu@gmail.com>
13376
13377 * dispextern.h (move_it_by_lines):
13378 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13379 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13380 (message_log_check_duplicate): Remove parameters `prev_bol' and
13381 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13382 (redisplay_internal): Remove parameter `preserve_echo_area',
13383 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13384
13385 * indent.c (Fvertical_motion):
13386 * window.c (window_scroll_pixel_based, Frecenter):
13387 Don't pass `need_y_p' to `move_it_by_lines'.
13388
1c470562
SM
133892011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13390
44f230aa
SM
13391 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13392 steal a few bits to be more compact.
13393 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13394 Remove unneeded casts.
13395
1c470562
SM
13396 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13397
888adce9
ZK
133982011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13399
13400 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13401 binding" message (bug#7967).
13402
f838ed7b
PE
134032011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13404
77861b95
PE
13405 Fix more problems found by GCC 4.6.0's static checks.
13406
de6dbc14
PE
13407 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13408 Remove unused local var.
13409
f838ed7b
PE
13410 * editfns.c (Fmessage_box): Remove unused local var.
13411
792c7b2b
PE
13412 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13413 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13414 Omit unused local vars.
c499e557 13415 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13416 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13417 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13418 Omit unused local var.
13419
ba0165e1
PE
13420 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13421 Don't assume string length fits in int.
32ad8845 13422 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13423 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13424
3c59b4c9
PE
13425 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13426 instead of alloca (Bug#8344).
13427
a3eed478 13428 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13429 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13430
eb4d412d
PE
13431 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13432
1658b401
PE
13433 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13434 concerns.
13435
13436 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13437
13438 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13439
9a2c6e05
PE
13440 * keyboard.c (syms_of_keyboard): Use the same style as later
13441 in this function when indexing through an array. This also
13442 works around GCC bug 48267.
13443
03d0a109
PE
13444 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13445
44f730c8
PE
13446 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13447
fe75f926
PE
13448 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13449 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13450
ffa8c828
PE
13451 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13452 This avoids undefined behavior on integer overflow, and is a bit
13453 more convenient anyway since it is compared to a size_t variable.
13454
c5101a77
PE
13455 Variadic C functions now count arguments with size_t, not int.
13456 This avoids an unnecessary limitation on 64-bit machines, which
13457 caused (substring ...) to crash on large vectors (Bug#8344).
13458 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13459 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13460 All variadic functions and their callers changed accordingly.
c5101a77
PE
13461 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13462 * data.c (arith_driver, float_arith_driver): Likewise.
13463 * editfns.c (general_insert_function): Likewise.
13464 * eval.c (struct backtrace.nargs, interactive_p)
13465 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13466 (funcall_lambda, mark_backtrace): Likewise.
13467 * fns.c (concat): Likewise.
13468 * frame.c (x_set_frame_parameters): Likewise.
13469 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13470 0 if not found, not -1. All callers changed.
13471
dd3f25f7
PE
13472 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13473 (stack_copy_size): Now size_t, not int.
13474 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13475
461c2ab9
JB
134762011-03-28 Juanma Barranquero <lekktu@gmail.com>
13477
13478 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13479 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13480 All callers changed.
13481
13482 * lisp.h (multibyte_char_to_unibyte):
13483 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13484 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13485 * character.h (CHAR_TO_BYTE8):
13486 * cmds.c (internal_self_insert):
13487 * editfns.c (general_insert_function):
13488 * keymap.c (push_key_description):
13489 * search.c (Freplace_match):
13490 * xdisp.c (message_dolog, set_message_1): All callers changed.
13491
f6d62986
SM
134922011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13493
13494 * keyboard.c (safe_run_hook_funcall): New function.
13495 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13496 don't set the hook to nil, but remove the offending function instead.
13497 (Qcommand_hook_internal): Remove, unused.
13498 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13499 Vcommand_hook_internal.
13500
13501 * eval.c (enum run_hooks_condition): Remove.
13502 (funcall_nil, funcall_not): New functions.
13503 (run_hook_with_args): Call each function through a `funcall' argument.
13504 Remove `cond' argument, now redundant.
13505 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13506 (Frun_hook_with_args_until_failure): Adjust accordingly.
13507 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13508
1db5b1ad
JB
135092011-03-28 Juanma Barranquero <lekktu@gmail.com>
13510
13511 * dispextern.h (string_buffer_position): Remove declaration.
13512
13513 * print.c (strout): Remove parameter `multibyte', unused since
13514 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13515
13516 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13517 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13518 All callers changed.
13519
13520 * w32.c (_wsa_errlist): Use braces for struct initializers.
13521
13522 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13523 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13524 All callers changed.
13525 (string_buffer_position): Likewise. Also, make static (it's never
13526 used outside xdisp.c).
13527 (cursor_row_p): Remove parameter `w', unused since
13528 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13529 (decode_mode_spec): Remove parameter `precision', introduced during
13530 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13531 All callers changed.
13532
5ffb62aa
JD
135332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13534
13535 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13536
461c2ab9 135372011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13538
13539 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13540 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13541 (ns_update_auto_hide_menu_bar): New functions.
13542 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13543 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13544 ns_constrain_all_frames.
13545 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13546 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13547
5c380ffb
JD
135482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13549
13550 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13551
9af30bdf
GM
135522011-03-27 Glenn Morris <rgm@gnu.org>
13553
13554 * syssignal.h: Replace RETSIGTYPE with void.
13555 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13556 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13557 Replace SIGTYPE with void everywhere.
13558 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13559 * s/template.h (SIGTYPE): Remove commented out definition.
13560
e2abce01
JB
135612011-03-26 Eli Zaretskii <eliz@gnu.org>
13562
13563 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13564 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13565
f868cd8a
JB
135662011-03-26 Juanma Barranquero <lekktu@gmail.com>
13567
59eb0929
JB
13568 * w32.c (read_unc_volume): Use parameter `henum', instead of
13569 global variable `wget_enum_handle'.
13570
13571 * keymap.c (describe_vector): Remove parameters `indices' and
13572 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13573 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13574
f868cd8a
JB
13575 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13576
13577 * keyboard.c (timer_check): Remove parameter `do_it_now',
13578 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13579 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13580 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13581
13582 * keyboard.c (read_char):
13583 * w32menu.c (w32_menu_display_help):
13584 * xmenu.c (show_help_event, menu_help_callback):
13585 Adjust calls to `show_help_echo'.
13586
13587 * gtkutil.c (xg_maybe_add_timer):
13588 * keyboard.c (readable_events):
13589 * process.c (wait_reading_process_output):
13590 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13591
13592 * insdel.c (adjust_markers_gap_motion):
13593 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13594 (gap_left, gap_right): Don't call it.
13595
2ecf6fdb
CY
135962011-03-25 Chong Yidong <cyd@stupidchicken.com>
13597
13598 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13599 incurred during fontification.
13600
6b1f9ba4
JB
136012011-03-25 Juanma Barranquero <lekktu@gmail.com>
13602
13603 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13604 (DEFVAR_PER_BUFFER): Don't pass it.
13605
13606 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13607 (scrolling_window): Don't pass it.
13608
0f4a96b5
JB
136092011-03-25 Juanma Barranquero <lekktu@gmail.com>
13610
13611 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13612
13613 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13614 and `suffix'.
13615 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13616 of variables specific to SELinux and computation of `encoded_absname'.
13617
13618 * image.c (XPutPixel): Remove unused variable `height'.
13619
13620 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13621
13622 * unexw32.c (get_section_info): Remove unused variable `section'.
13623
13624 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13625 (system_process_attributes): Remove unused variable `sess'.
13626 (sys_read): Remove unused variable `err'.
13627
13628 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13629 (w32_wnd_proc): Remove unused variable `isdead'.
13630 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13631 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13632 (x_create_tip_frame): Remove unused variable `tem'.
13633
13634 * w32inevt.c (w32_console_read_socket):
13635 Remove unused variable `no_events'.
13636
13637 * w32term.c (x_draw_composite_glyph_string_foreground):
13638 Remove unused variable `width'.
13639
1149507c
JB
136402011-03-24 Juanma Barranquero <lekktu@gmail.com>
13641
13642 * w32term.c (x_set_glyph_string_clipping):
13643 Don't pass uninitialized region to CombineRgn.
13644
9c88f339
JB
136452011-03-23 Juanma Barranquero <lekktu@gmail.com>
13646
13647 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13648 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13649 (Fx_close_connection): Remove unused variable `i'.
13650
13651 * w32font.c (w32font_draw): Return number of glyphs.
13652 (w32font_open_internal): Remove unused variable `i'.
13653 (w32font_driver): Add missing initializer.
13654
13655 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13656 (fill_in_menu): Remove unused variable `items_added'.
13657
13658 * w32term.c (last_mouse_press_frame): Remove static global variable.
13659 (w32_clip_to_row): Remove unused variable `f'.
13660 (x_delete_terminal): Remove unused variable `i'.
13661
13662 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13663 (NOTHING): Remove unused static global variable.
13664 (uniscribe_check_otf): Remove unused variable `table'.
13665 (uniscribe_font_driver): Add missing initializers.
13666
dee091a3
JD
136672011-03-23 Julien Danjou <julien@danjou.info>
13668
13669 * term.c (Fsuspend_tty, Fresume_tty):
13670 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13671 * window.c (temp_output_buffer_show):
13672 * insdel.c (signal_before_change):
13673 * frame.c (Fhandle_switch_frame):
13674 * fileio.c (Fdo_auto_save):
13675 * emacs.c (Fkill_emacs):
13676 * editfns.c (save_excursion_restore):
13677 * cmds.c (internal_self_insert):
13678 * callint.c (Fcall_interactively):
13679 * buffer.c (Fkill_all_local_variables):
13680 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13681 Use Frun_hooks.
0f4a96b5 13682 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13683 unconditionally since it does the check itself.
dee091a3 13684
2c520ab5 136852011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13686
c9c49752
PE
13687 Fix more problems found by GCC 4.5.2's static checks.
13688
8abc3f12
PE
13689 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13690 the first time through the loop, since we know p0 < p1 then.
13691 This also avoids a gcc -Wstrict-overflow warning.
13692
a2d26660
PE
13693 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13694 leading to a memory leak, possible in functions like
13695 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13696 of objects (Bug#8318).
a2d26660 13697
916c72e9
PE
13698 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13699 that could (at least in theory) be that large.
13700
19ab8a18
PE
13701 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13702 This is less likely to overflow, and avoids undefined behavior if
13703 overflow does occur. All callers changed. Use strtoul to scan
13704 for the unsigned long integer.
b7cbbd6f
PE
13705 (pint2hrstr): Simplify and tune code slightly.
13706 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13707
f0641eff
PE
13708 * scroll.c (do_scrolling): Work around GCC bug 48228.
13709 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13710
7f650bb9
PE
13711 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13712 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13713 (validate_x_resource_name): Simplify count usage.
13714 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13715
37dd57d1
PE
13716 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13717 fail (Bug#8306).
81e56e61 13718
699979fc 13719 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13720
401bf9b4
PE
13721 * process.c (Fmake_network_process): Use socklen_t, not int,
13722 where POSIX says socklen_t is required in portable programs.
13723 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13724 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13725 (Fmake_network_process, server_accept_connection):
13726 (wait_reading_process_output, read_process_output):
13727 Likewise.
13728
b93aacde
PE
13729 * process.c: Rename or move locals to avoid shadowing.
13730 (list_processes_1, Fmake_network_process):
13731 (read_process_output_error_handler, exec_sentinel_error_handler):
13732 Rename or move locals.
4dc343ee 13733 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13734 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13735 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13736 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13737 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13738
af8a867c 13739 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13740 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13741 Include tparam.h instead, since it declares them.
af8a867c
PE
13742 * cm.h (PC): Remove extern decl; tparam.h now does this.
13743 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13744 * terminfo.c: Include tparam.h, to check interfaces.
13745 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13746 (tparam): Adjust signature to match interface in tparam.h;
13747 this removes some undefined behavior. Check that outstring and len
13748 are zero, which they always are with Emacs.
13749 * tparam.h (PC, BC, UP): New extern decls.
13750
0248044d 13751 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13752 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13753
8ff096c1 13754 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13755 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13756 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13757 (ftfont_list): Remove unused local.
49eaafba
PE
13758 (get_adstyle_property, ftfont_pattern_entity):
13759 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13760 Rename locals to avoid shadowing.
8ff096c1 13761
e2be39f6
PE
13762 * xfont.c (xfont_list_family): Mark var as initialized.
13763
c9735e30
PE
13764 * xml.c (make_dom): Now static.
13765
8f5201ae
PE
13766 * composite.c (composition_compute_stop_pos): Rename local to
13767 avoid shadowing.
b246f932
PE
13768 (composition_reseat_it): Remove unused locals.
13769 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13770 (composition_update_it): Mark var as initialized.
11b61122
PE
13771 (find_automatic_composition): Mark vars as initialized,
13772 with a FIXME (Bug#8290).
8f5201ae 13773
760fbc2c
PE
13774 character.h: Rename locals to avoid shadowing.
13775 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13776 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13777 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13778 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13779 to avoid shadowing.
13780
ff08eb85
PE
13781 * textprop.c (property_change_between_p): Remove; unused.
13782
fc7bf025
PE
13783 * intervals.c (interval_start_pos): Now static.
13784
235d7abc
PE
13785 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13786
44f230aa
SM
13787 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13788 Rename locals to avoid shadowing.
3e7d6594 13789
50060332
PE
13790 * sound.c (wav_play, au_play, Fplay_sound_internal):
13791 Fix pointer signedness.
d01f234b 13792 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13793 (wav_play): Initialize a variable to 0, to prevent undefined
13794 behavior (Bug#8278).
50060332 13795
c4fc4e30
PE
13796 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13797
918436ed
PE
13798 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13799
c939f91b
PE
13800 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13801 clobbering (Bug#8298).
b9c7f648
PE
13802 * sysdep.c (sys_subshell): Likewise.
13803 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13804
6bd8c144
PE
13805 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13806 This should get cleaned up, so that child_setup has the
13807 same signature on all platforms.
13808
7710357c 13809 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13810 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13811
c59da222
CY
138122011-03-22 Chong Yidong <cyd@stupidchicken.com>
13813
13814 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13815 not to be necessary, and produces flickering.
13816
66b87493
GM
138172011-03-20 Glenn Morris <rgm@gnu.org>
13818
13819 * config.in: Remove file.
13820
45b6f6d5
JB
138212011-03-20 Juanma Barranquero <lekktu@gmail.com>
13822
13823 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13824 are now in src/globals.h.
13825 (syms_of_minibuf): Remove spurious & from previous change.
13826
cd394be1 138272011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13828
13829 * minibuf.c (completing-read-function): New variable.
13830 (completing-read-default): Rename from completing-read.
13831 (completing-read): Call completing-read-function.
13832
b14e3e21
CY
138332011-03-19 Juanma Barranquero <lekktu@gmail.com>
13834
13835 * xfaces.c (Fx_load_color_file):
13836 Read color file from absolute filename (bug#8250).
13837
f2b726e6
JB
138382011-03-19 Juanma Barranquero <lekktu@gmail.com>
13839
13840 * makefile.w32-in: Update dependencies.
13841
09f6ff02
EZ
138422011-03-17 Eli Zaretskii <eliz@gnu.org>
13843
13844 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13845
29a6015a
PE
138462011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13847
a3a6c54e
PE
13848 Fix more problems found by GCC 4.5.2's static checks.
13849
b766f867
PE
13850 * process.c (make_serial_process_unwind, send_process_trap):
13851 (sigchld_handler): Now static.
13852
be02381c
PE
13853 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13854 That way, the code declares only the vars that it needs.
13855 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13856 * s/cygwin.h (PTY_ITERATION): Likewise.
13857 * s/darwin.h (PTY_ITERATION): Likewise.
13858 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13859
57048744
PE
13860 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13861 * process.c (allocate_pty): Don't declare stb unless it's needed.
13862
7914961c 13863 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13864 (CONSTANTLIM): Remove; unused.
13865 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13866 Define only if needed.
7914961c 13867
b3967b18
PE
13868 * unexelf.c (unexec): Name an expression,
13869 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13870 Use a different way to cause a compilation error if anyone uses
13871 n rather than nn, a way that does not involve shadowing.
73366a00 13872 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13873
29a6015a
PE
13874 * deps.mk (unexalpha.o): Remove; unused.
13875
43cfc33e 13876 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13877 * unexec.h: New file.
ce701a33
PE
13878 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13879 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13880 Depend on unexec.h.
13881 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13882 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13883 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13884 Change as necessary to match prototype in unexec.h.
ce701a33 13885
01f44d5a
PE
13886 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13887 shadowing.
4f63c6bb 13888 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13889
a6670b0b
PE
13890 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13891 Rename locals to avoid shadowing.
13892
cef2010d 13893 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13894 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13895
d4d7173a
PE
13896 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13897
f08b802a
PE
13898 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13899 warning when compiling print.c.
13900
3ddb0639
PE
13901 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13902 instead of using an uninitialized var.
5ad03b97 13903 (font_sort_entities): Mark var as initialized.
3ddb0639 13904
170a2692
PE
13905 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13906
e663c700
PE
13907 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13908 pointers to constants.
89bc529a 13909 (font_parse_fcname): Remove unused vars.
7b81e2d0 13910 (font_delete_unmatched): Now static.
ea838e10 13911 (font_get_spec): Remove; unused.
13a547c6
PE
13912 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13913 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13914 Rename or move locals to avoid shadowing.
e663c700 13915
2a80c887 13916 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13917 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13918
1384fa33 13919 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13920 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13921
8b2c52e9
PE
13922 * alloc.c (mark_backtrace): Move decl from here ...
13923 * lisp.h: ... to here, so that it can be checked.
13924
475545b5 13925 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13926 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13927 (lisp_indirect_variable): Name an expression,
13928 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13929 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13930
b1349114 13931 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13932 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13933 Use const pointer when appropriate.
b1349114 13934
a2928364
PE
13935 * lisp.h (get_system_name, get_operating_system_release):
13936 Move decls here, to check interfaces.
13937 * process.c (get_operating_system_release): Move decl to lisp.h.
13938 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13939 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13940 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13941 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13942 (Fformat_time_string, Fencode_time, Finsert_char):
13943 (Ftranslate_region_internal, Fformat):
13944 Rename or remove local vars to avoid shadowing.
9710023e 13945 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13946
a415e694
PE
13947 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13948 avoid shadowing.
13949
8ef4622d
PE
13950 * lisp.h (eassert): Check that the argument compiles, even if
13951 ENABLE_CHECKING is not defined.
13952
946f9a5b
PE
13953 * data.c (Findirect_variable): Name an expression, to avoid
13954 gcc -Wbad-function-cast warning.
112396d6 13955 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13956 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13957 (Fmake_variable_buffer_local, Fmake_local_variable):
13958 Mark variables as initialized.
52746918 13959 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13960
e5aab7e7 13961 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13962 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13963 Rename locals to avoid shadowing.
dff45157
PE
13964 (mark_stack): Move local variables into the #ifdef region where
13965 they're used.
7bc26fdb
PE
13966 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13967 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13968 needed otherwise.
13969 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13970 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13971 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13972
e5aab7e7
PE
13973 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13974 avoids undefined behavior in theory.
13975
4da60324
PE
13976 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13977
88043301
PE
13978 Use functions, not macros, for up- and down-casing (Bug#8254).
13979 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13980 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13981 to use the following functions instead of these macros.
13982 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13983 EMACS_INT, since callers assume the returned value fits in int.
13984 (upcase1): Likewise, for UPCASE_TABLE.
13985 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13986 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13987 the race-condition problem in the old DOWNCASE.
88043301 13988
19ed5445
PE
13989 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13990 Rename locals to avoid shadowing.
13991 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13992 (regex_compile, re_search_2, re_match_2_internal):
13993 Remove unused local vars.
952db0d7
PE
13994 (FREE_VAR): Rewrite so as not to use empty "else",
13995 which gcc can warn about.
da053e48 13996 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13997 (RETALLOC_IF): Define only if needed.
13998 (WORDCHAR_P): Likewise. This one is never needed, but is used
13999 only in a comment talking about a compiler bug, so put inside
14000 the #if 0 of that comment.
14001 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14002 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14003 Remove; unused.
19ed5445 14004
1f3561e4 14005 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14006 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14007 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14008
ded6f8f7
PE
14009 * search.c (simple_search): Remove unused var.
14010
dbd37a95
PE
14011 * dired.c (compile_pattern): Move decl from here ...
14012 * lisp.h: ... to here, so that it can be checked.
14013 (struct re_registers): New forward decl.
14014
7e47afad
PE
14015 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14016
85f24f61
PE
14017 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14018 All uses changed.
14019 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14020 Rename locals to avoid shadowing.
5671df8f 14021 (Fvertical_motion): Mark locals as initialized.
85f24f61 14022
181aa2be 14023 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14024 (casify_region): Mark local as initialized.
181aa2be 14025
930d429c
PE
14026 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14027
7082eac6
PE
14028 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14029 New macros, so that the caller can use some names other than
14030 gcpro1, gcpro2, etc.
14031 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14032 of the new macros.
14033 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14034 argument, for consistency with GCPRO2_VAR, etc: it is now the
14035 prefix of the variable, not the variable itself. All uses
14036 changed.
38b2c076
PE
14037 * dired.c (directory_files_internal, file_name_completion):
14038 Rename locals to avoid shadowing.
14039
15206ed9
PE
14040 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14041 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14042 dired.c's scmp function, had undefined behavior.
14043 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14044 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14045 * buffer.h: ... to here, because these macros use current_buffer,
14046 and the new implementation with inline functions needs to have
14047 current_buffer in scope now, rather than later when the macros
14048 are used.
14049 (downcase, upcase1): New static inline functions.
14050 (DOWNCASE, UPCASE1): Reimplement using these functions.
14051 This avoids undefined behavior in expressions like
14052 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14053 from race conditions in accessing the global variables
14054 case_temp1 and case_temp2.
14055 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14056 * lisp.h (case_temp1, case_temp2): Remove their decls.
14057 * character.h (ASCII_CHAR_P): Move from here ...
14058 * lisp.h: ... to here, so that the inline functions mentioned
14059 above can use them.
14060
4a6bea26
PE
14061 * dired.c (directory_files_internal_unwind): Now static.
14062
f14b7e14
PE
14063 * fileio.c (file_name_as_directory, directory_file_name):
14064 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14065 Now static.
2893f146
PE
14066 (file_name_as_directory): Use const pointers when appropriate.
14067 (Fexpand_file_name): Likewise. In particular, newdir might
14068 point at constant storage, so make it a const pointer.
fd4ead52 14069 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14070 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14071 signedness issues.
f839df0c
PE
14072 (Fset_file_times, Finsert_file_contents, auto_save_error):
14073 Rename locals to avoid shadowing.
f14b7e14 14074
5716756e 14075 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14076 (Ftry_completion, Fall_completions): Rename or remove locals
14077 to avoid shadowing.
5716756e 14078
b4c3046a
PE
14079 * marker.c (bytepos_to_charpos): Remove; unused.
14080
b45db522
PE
14081 * lisp.h (verify_bytepos, count_markers): New decls,
14082 so that gcc does not warn that these functions aren't declared.
14083
85876d07
PE
14084 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14085 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14086 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14087 (copy_text): Remove unused local var.
85876d07 14088
03d78a21 14089 * filelock.c (within_one_second): Now static.
b3dd38ab 14090 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14091
5df8f01b
PE
14092 * buffer.c (fix_overlays_before): Mark locals as initialized.
14093 (fix_start_end_in_overlays): Likewise. This function should be
14094 simplified by using pointers-to-pointers, but that's a different
14095 matter.
b1d876f1 14096 (switch_to_buffer_1): Now static.
8f54f30a
PE
14097 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14098 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14099
a70072c9 14100 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14101 Fix pointer signedness issue.
edced198
PE
14102 (sys_subshell): Mark local as volatile if checking for lint,
14103 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14104 (MAXPATHLEN): Define only if needed.
a70072c9 14105
a0977c44
PE
14106 * process.c (serial_open, serial_configure): Move decls from here ...
14107 * systty.h: ... to here, so that they can be checked.
14108
a884fdcc
PE
14109 * fns.c (get_random, seed_random): Move extern decls from here ...
14110 * lisp.h: ... to here, so that they can be checked.
14111
604efe86 14112 * sysdep.c (reset_io): Now static.
b8950c94 14113 (wait_for_termination_signal): Remove; unused.
604efe86 14114
38fc62d9
PE
14115 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14116 (copy_keymap_item, append_key, push_text_char_description):
14117 Now static.
1004a21a 14118 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14119 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14120 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14121 (describe_map_tree):
14122 Rename locals to avoid shadowing.
38fc62d9 14123
2f2650da
PE
14124 * keyboard.c: Declare functions static if they are not used elsewhere.
14125 (echo_char, echo_dash, cmd_error, top_level_2):
14126 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14127 (read_char, kbd_buffer_get_event, make_lispy_position):
14128 (make_lispy_event, make_lispy_movement, apply_modifiers):
14129 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14130 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14131 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14132 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14133 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14134
a053e86c 14135 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14136 (mark_kboards): Move decl here ...
14137 * alloc.c (mark_kboards): ... from here.
a053e86c 14138
4752793e
PE
14139 * lisp.h (force_auto_save_soon): New decl.
14140
74f10ca7 14141 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14142 (DEFINE_DUMMY_FUNCTION): New macro.
14143 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14144 Use it.
c03cd23f
PE
14145 (main): Add casts to avoid warnings
14146 if GCC considers string literals to be constants.
74f10ca7 14147
022e70d4
PE
14148 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14149
59d6fe83
PE
14150 * dbusbind.c: Pointer signedness fixes.
14151 (xd_signature, xd_append_arg, xd_initialize):
14152 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14153 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14154 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14155 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14156
78320123
PE
14157 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14158 if GCC considers string literals to be constants.
49cebcca 14159 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14160
35ac2a97
SM
141612011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14162
fb103ca9
SM
14163 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14164 (print_preprocess, print_object): New macro to fix last change.
14165
35ac2a97
SM
14166 * print.c (print_preprocess): Don't forget font objects.
14167
62973b41
JB
141682011-03-16 Juanma Barranquero <lekktu@gmail.com>
14169
14170 * emacs.c (USAGE3): Doc fixes.
14171
0e48bb22
AS
141722011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14173
14174 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14175 structure.
14176
7684e57b
JB
141772011-03-14 Juanma Barranquero <lekktu@gmail.com>
14178
14179 * lisp.h (VWindow_system, Qfile_name_history):
14180 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14181 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14182 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14183
14184 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14185 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14186
14187 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14188 * w32console.c (detect_input_pending, read_input_pending)
14189 (encode_terminal_code):
14190 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14191 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14192 (w32_system_caret_y, Qfile_name_history):
14193 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14194 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14195 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14196 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14197 * w32proc.c (Qlocal, report_file_error):
14198 * w32term.c (Vwindow_system, updating_frame):
14199 * w32uniscribe.c (initialized, uniscribe_font_driver):
14200 Remove unneeded extern declarations.
14201
2aa46d6c
CY
142022011-03-14 Chong Yidong <cyd@stupidchicken.com>
14203
c96bbc66 14204 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14205
cffc6f3b
CY
142062011-03-13 Chong Yidong <cyd@stupidchicken.com>
14207
14208 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14209 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14210 These macros can no longer be used for assignment.
14211
44f230aa
SM
14212 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14213 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14214 (record_buffer_markers, fetch_buffer_markers): New functions for
14215 recording and fetching special buffer markers.
14216 (set_buffer_internal_1, set_buffer_temp): Use them.
14217
14218 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14219
14220 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14221
14222 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14223 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14224
14225 * xdisp.c (hscroll_window_tree):
14226 (reconsider_clip_changes): Use PT instead of BUF_PT.
14227
d251f04b
EZ
142282011-03-13 Eli Zaretskii <eliz@gnu.org>
14229
14230 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14231 $(EMACS_ROOT)/lib/intprops.h.
14232
f0c77cd1
PE
142332011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14234
3eca4629
PE
14235 Fix more problems found by GCC 4.5.2's static checks.
14236
7c86ee98
PE
14237 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14238 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14239 (xg_free_frame_widgets): Make it clear that a local variable is
14240 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14241 (gdk_window_get_screen): Make it clear that this macro is needed
14242 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14243 (int_gtk_range_get_value): New function, which avoids a diagnostic
14244 from gcc -Wbad-function-cast.
14245 (xg_set_toolkit_scroll_bar_thumb): Use it.
14246 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14247 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14248 (get_utf8_string, xg_get_file_with_chooser):
14249 Rename locals to avoid shadowing.
14250 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14251
41729b81
PE
14252 * xgselect.c (xg_select): Remove unused var.
14253
f0c77cd1
PE
14254 * image.c (four_corners_best): Mark locals as initialized.
14255 (gif_load): Initialize transparent_p to zero (Bug#8238).
14256 Mark another local as initialized.
ec6cf4c6 14257 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14258
ce0ad53d 14259 * image.c (clear_image_cache): Now static.
d5d5a617 14260 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14261 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14262 (x_edge_detection): Remove unnecessary cast that
14263 gcc -Wbad-function-cast diagnoses.
2037898d 14264 (gif_load): Fix pointer signedness.
6ae141d6
PE
14265 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14266 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14267
33383987 142682011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14269
d32df629
PE
14270 Improve quality of tests for time stamp overflow.
14271 For example, without this patch (encode-time 0 0 0 1 1
14272 1152921504606846976) returns the obviously-bogus value (-948597
14273 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14274 reports time overflow. See
14275 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14276 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14277 * editfns.c: Include limits.h and intprops.h.
14278 (TIME_T_MIN, TIME_T_MAX): New macros.
14279 (time_overflow): Move earlier, to before first use.
14280 (hi_time, lo_time): New functions, for an accurate test for
14281 out-of-range times.
14282 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14283 (Fget_internal_run_time): Don't assume time_t fits in int.
14284 (make_time): Use list2 instead of Fcons twice.
14285 (Fdecode_time): More accurate test for out-of-range times.
14286 (check_tm_member): New function.
14287 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14288 (lisp_time_argument): Don't rely on undefined left-shift and
14289 right-shift behavior when checking for time stamp overflow.
8be6f318 14290
fe31d94c
PE
14291 * editfns.c (time_overflow): New function, refactoring common code.
14292 (Fformat_time_string, Fdecode_time, Fencode_time):
14293 (Fcurrent_time_string): Use it.
14294
8be6f318
PE
14295 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14296 * dired.c (make_time): Move to ...
14297 * editfns.c (make_time): ... here.
14298 * systime.h: Note the move.
14299
09d9db2c 143002011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14301
126bc0dc
YM
14302 * fringe.c (update_window_fringes): Remove unused variables.
14303
c47cbdfd
YM
14304 * unexmacosx.c (copy_data_segment): Also copy __got section.
14305 (Bug#8223)
14306
7ac80be9
EZ
143072011-03-12 Eli Zaretskii <eliz@gnu.org>
14308
c96bbc66 14309 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14310 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14311 Constify `char *' arguments and their references according to
14312 prototypes in tparam.h.
14313
ecb0f94d 14314 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14315
7ac80be9
EZ
14316 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14317 Adapt all references accordingly.
14318
14319 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14320
ef1fd07e
TT
143212011-03-11 Tom Tromey <tromey@redhat.com>
14322
14323 * buffer.c (syms_of_buffer): Remove obsolete comment.
14324
7ef4b50c
EZ
143252011-03-11 Eli Zaretskii <eliz@gnu.org>
14326
14327 * termhooks.h (encode_terminal_code): Declare prototype.
14328
14329 * msdos.c (encode_terminal_code): Don't declare prototype.
14330
14331 * term.c (encode_terminal_code): Now external again, used by
14332 w32console.c and msdos.c.
14333
44f230aa
SM
14334 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14335 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14336
4b1ec863 143372011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14338
1714f52b 14339 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14340
4b1ec863
PE
14341 * fringe.c (update_window_fringes): Mark locals as initialized
14342 (Bug#8227).
14343 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14344
524c7aa6
PE
14345 * alloc.c (mark_fringe_data): Move decl from here ...
14346 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14347 to check its interface.
14348 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14349
a5c0af81 14350 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14351 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14352 (fontset_font): Mark local as initialized.
a9a06e0b 14353 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14354
b4716021
PE
14355 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14356
811e9bac 14357 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14358 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14359 (x_own_selection, Fx_disown_selection_internal): Rename locals
14360 to avoid shadowing.
14361 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14362
7e3ab302
PE
14363 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14364 so that the caller can use some name other than gcpro1.
14365 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14366 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14367 (Fx_backspace_delete_keys_p):
14368 Use them to avoid shadowing, and rename vars to avoid shadowing.
14369 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14370 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14371 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14372 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14373 Remove unused locals.
7e3ab302
PE
14374 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14375 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14376 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14377 macros.
f78faa98 14378
e2b13473
PE
14379 * xterm.h (x_mouse_leave): New decl.
14380
77f23912
PE
14381 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14382 Remove unused functions.
cdf4ba58
PE
14383 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14384 (x_calc_absolute_position): Now static.
7411c686 14385 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14386 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14387 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14388 unless they are used.
38d0b34a
PE
14389 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14390 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14391 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14392 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14393 (x_error_catcher, x_connection_closed, x_error_handler):
14394 (x_error_quitter, xembed_send_message, x_iconify_frame):
14395 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14396 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14397 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14398
44f230aa
SM
14399 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14400 Rename or move locals to avoid shadowing.
6b463e58 14401 (tty_defined_color, merge_face_heights): Now static.
5967d051 14402 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14403 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14404 does not deduce is never used uninitialized.
73719eba
PE
14405 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14406 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14407
426994c3 14408 * terminal.c (store_terminal_param): Now static.
5489860b 14409
032f1620 14410 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14411 (set_frame_menubar): Remove unused local.
d4323972 14412 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14413 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14414 since they might point to immutable storage.
281585b0
PE
14415 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14416 since it's unused otherwise.
032f1620 14417
367c19e5 14418 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14419 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14420 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14421 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14422 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14423 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14424 does not deduce are never used uninitialized.
70739cbe 14425
07b48fa9
PE
14426 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14427
8868a238 14428 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14429 * window.c (window_loop, size_window):
14430 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14431
7e5cf297 14432 * window.c (display_buffer): Now static.
d6550a9f
PE
14433 (size_window): Mark variables that gcc -Wuninitialized
14434 does not deduce are never used uninitialized.
a586633d
PE
14435 * window.h (check_all_windows): New decl, to forestall
14436 gcc -Wmissing-prototypes diagnostic.
5b555da1 14437 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14438
f6095868
PE
14439 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14440 shadowing.
14441 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14442 Include <limits.h>.
14443 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14444 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14445 (load_charset_map): Mark variables that gcc -Wuninitialized
14446 does not deduce are never used uninitialized.
53df7c11 14447 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14448
f38b440c
PE
14449 * coding.c (coding_set_source, coding_set_destination):
14450 Use "else { /* comment */ }" rather than "else /* comment */;"
14451 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14452 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14453 a block, when the outer 'i' will do.
14454 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14455 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14456 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14457 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14458 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14459 Rename locals to avoid shadowing.
14460 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14461 * coding.c (emacs_mule_char, encode_invocation_designation):
14462 Now static, since they're not used elsewhere.
413bb2db 14463 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14464 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14465 (decode_coding_emacs_mule): Mark variables that gcc
14466 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14467 (detect_coding_iso_2022): Initialize a local variable that might
14468 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14469 this initialization is needed. (Bug#8211)
5f58e762
PE
14470 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14471 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14472 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14473 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14474 Remove unused macros.
f38b440c 14475
232b38b9 14476 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14477 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14478 * character.c (string_count_byte8): Likewise.
232b38b9 14479
fb90da1b
PE
14480 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14481 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14482
fb93dbc2
PE
14483 * chartab.c (copy_sub_char_table): Now static, since it's not used
14484 elsewhere.
5c156ace
PE
14485 (sub_char_table_ref_and_range, char_table_ref_and_range):
14486 Rename locals to avoid shadowing.
bbcd0949 14487 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14488
7d3b3862 14489 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14490 (BIDI_BOB): Remove unused macro.
7d3b3862 14491
6be7d3da
PE
14492 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14493 deduce are never used uninitialized.
c2ed9c8b 14494 * term.c (encode_terminal_code): Likewise.
6be7d3da 14495
75f8807f 14496 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14497
50938595
PE
14498 * tparam.h: New file.
14499 * term.c, tparam.h: Include it.
14500 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14501 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14502 Move these decls to tparam.h, and make them agree with what
14503 is actually in tparam.c. The previous trick of using incompatible
14504 decls in different modules does not conform to the C standard.
14505 All callers of tparam changed to use tparam's actual API.
14506 * tparam.c (tparam1, tparam, tgoto):
14507 Use const pointers where appropriate.
14508
fbceeba2
PE
14509 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14510 * cm.h (struct cm): Likewise.
14511 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14512 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14513 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14514 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14515 (turn_on_face, init_tty): Likewise.
14516 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14517
7f3f1250
PE
14518 * term.c (term_mouse_position): Rename local to avoid shadowing.
14519
e6ca6543
PE
14520 * alloc.c (mark_ttys): Move decl from here ...
14521 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14522
c40f8d15
AS
145232011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14524
14525 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14526
cfe0661d
JB
145272011-03-09 Juanma Barranquero <lekktu@gmail.com>
14528
14529 * search.c (compile_pattern_1): Remove argument regp, unused since
14530 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14531 (compile_pattern): Don't pass it.
14532
0afb4571
J
145332011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14534
14535 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14536 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14537 for ! HAVE_GTK3.
14538 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14539
14540 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14541
14542 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14543 gdk_window_get_screen, gdk_window_get_geometry,
14544 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14545 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14546 (xg_get_pixbuf_from_pixmap): New function.
14547 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14548 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14549 Call xg_get_pixbuf_from_pixmap instead of
14550 gdk_pixbuf_get_from_drawable.
14551 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14552 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14553 (xg_check_special_colors): Use GtkStyleContext and its functions
14554 for HAVE_GTK3.
14555 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14556 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14557 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14558 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14559 Call gtk_widget_get_preferred_size.
0afb4571
J
14560 (xg_frame_resized): gdk_window_get_geometry only takes 5
14561 parameters.
44f230aa
SM
14562 (xg_win_to_widget, xg_event_is_for_menubar):
14563 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14564 (xg_set_widget_bg): New function.
14565 (delete_cb): New function.
895009e1 14566 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14567 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14568 (xg_set_background_color): Call xg_set_widget_bg.
14569 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14570 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14571 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14572 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14573 if ! HAVE_GTK3.
14574 (update_frame_tool_bar): Call gtk_widget_hide.
14575 (xg_initialize): Use GDK_KEY_g.
14576
14577 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14578 if ! HAVE_GTK3
14579 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14580
14581 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14582 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14583 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14584
1c2cc4ef
JB
145852011-03-08 Juanma Barranquero <lekktu@gmail.com>
14586
14587 * w32xfns.c (select_palette): Check success of RealizePalette against
14588 GDI_ERROR, not zero.
14589
33383987 14590See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14591
14592;; Local Variables:
14593;; coding: utf-8
aac0c6e3
MR
14594;; End:
14595
2f097256 14596 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14597
14598 This file is part of GNU Emacs.
14599
14600 GNU Emacs is free software: you can redistribute it and/or modify
14601 it under the terms of the GNU General Public License as published by
14602 the Free Software Foundation, either version 3 of the License, or
14603 (at your option) any later version.
14604
14605 GNU Emacs is distributed in the hope that it will be useful,
14606 but WITHOUT ANY WARRANTY; without even the implied warranty of
14607 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14608 GNU General Public License for more details.
14609
14610 You should have received a copy of the GNU General Public License
14611 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.