Check pkg-config exit status when configuring (Bug#10626).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e3fb2efb
PE
12012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2
3 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6 objects, as mark_maybe_pointer will catch them otherwise.
7 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
9
b5385551
PE
102012-04-07 Paul Eggert <eggert@cs.ucla.edu>
11
12 Fix typo that broke non-Windows builds.
13 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
14
9078ead6
EZ
152012-04-07 Eli Zaretskii <eliz@gnu.org>
16
17 Support building on MS-Windows with libxml2.
18
19 * makefile.w32-in (OBJ2): Add xml.$(O).
20 (GLOBAL_SOURCES): Add xml.c.
21 ($(BLD)/xml.$(O)): New dependency list.
22
23 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
24 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
25 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
26 [!WINDOWSNT]: New macros.
27 (init_libxml2_functions, libxml2_loaded_p): New functions.
28 (parse_region): Call fn_xmlCheckVersion instead of using the macro
29 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
30 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
31 Calls xmlCleanupParser only if libxml2 was loaded (or statically
32 linked in).
33 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
34 init_libxml2_functions before calling libxml2 functions.
35 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
36
37 * emacs.c: Don't include libxml/parser.h.
38 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
39 xmlCleanupParser directly.
40
41 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
42
3811fdf3
EZ
432012-04-07 Eli Zaretskii <eliz@gnu.org>
44
45 * indent.c (Fvertical_motion): If there is a display string at
46 point, use it.vpos to compute how many lines to backtrack after
47 move_it_to point. (Bug#11133)
48
2f8e16b2
EZ
492012-04-06 Eli Zaretskii <eliz@gnu.org>
50
51 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
52 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
53 about subtle differences between FETCH_CHAR* and STRING_CHAR*
54 macros related to unification of CJK characters. For the details,
55 see the discussion following the message here:
56 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
57
3d439cd1
CY
582012-04-04 Chong Yidong <cyd@gnu.org>
59
60 * keyboard.c (Vdelayed_warnings_list): Doc fix.
61
8bc53d00
EZ
622012-04-01 Eli Zaretskii <eliz@gnu.org>
63
64 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
65 instead of alloca. (Bug#11138)
66
3b0512a3
AS
672012-04-01 Andreas Schwab <schwab@linux-m68k.org>
68
69 * w32menu.c (is_simple_dialog): Properly check lisp types.
70 (Bug#11141)
71
8427ddd2
EZ
722012-03-31 Eli Zaretskii <eliz@gnu.org>
73
979022ef
EZ
74 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
75 position we get to after a call to move_it_to fails the
76 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
77 only if we wind up in a string from display property. (Bug#11063)
78
a6b1c7cc
EZ
79 * window.c (Fdelete_other_windows_internal): Invalidate the row
80 and column information about mouse highlight, so that redisplay
81 restores it after reallocating the glyph matrices. (Bug#7464)
82
8427ddd2
EZ
83 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
84 string comes from a `display' text property, use the buffer
85 position of that property as if we actually saw that position in
86 the row's glyphs.
697ba24b
EZ
87 (move_it_by_lines): Remove the assertion that
88 "it->current_x == 0 && it->hpos == 0" which can be legitimately
89 violated when there's a before-string at the beginning of a line.
90 (Bug#11063)
8427ddd2 91
65a0a738
EZ
922012-03-30 Eli Zaretskii <eliz@gnu.org>
93
94 * xdisp.c (append_space_for_newline): If the default face was
95 remapped, use the remapped face for the appended newline.
96 (extend_face_to_end_of_line): Use the remapped default face for
97 extending the face to the end of the line.
98 (display_line): Call extend_face_to_end_of_line when the default
99 face was remapped. (Bug#11068)
100
581355cc
EZ
1012012-03-29 Eli Zaretskii <eliz@gnu.org>
102
103 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
104
e8fc049f
SM
1052012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
106
107 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
108
4fb9a543
GM
1092012-03-27 Glenn Morris <rgm@gnu.org>
110
111 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
112 Doc fixes.
113
679910f1
KH
1142012-03-26 Kenichi Handa <handa@m17n.org>
115
116 * dispextern.h (struct glyph): Fix previous change. Change the
117 bit length of glyphless.ch to 25 (Bug#11082).
118
90d49b7f
CY
1192012-03-26 Chong Yidong <cyd@gnu.org>
120
121 * keyboard.c (Vselection_inhibit_update_commands): New variable.
122 (command_loop_1): Use it; inhibit selection update for
123 handle-select-window too (Bug#8996).
124
f514f6f0
FP
1252012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
126
e8fc049f 127 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 128
bf43fa51
KH
1292012-03-25 Kenichi Handa <handa@m17n.org>
130
131 * dispextern.h (struct glyph): Change the bit length of
132 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
133
8a0c01dd
EZ
1342012-03-24 Eli Zaretskii <eliz@gnu.org>
135
136 * s/ms-w32.h (tzname): Include time.h before redirecting to
137 _tzname. Fixes the MSVC build. (Bug#9960)
138
7d1c3a76
AS
1392012-03-24 Andreas Schwab <schwab@linux-m68k.org>
140
8ed79523
AS
141 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
142 characters.
143
7d1c3a76
AS
144 * xterm.c (XTread_socket): Only modify handling_signal if
145 !SYNC_INPUT. (Bug#11080)
146
e99a9b8b
EZ
1472012-03-23 Eli Zaretskii <eliz@gnu.org>
148
149 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
150 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
151 when fetching a multibyte character consumes more bytes than
152 CHAR_BYTES returns, due to unification of CJK characters in
153 string_char. (Bug#11073)
154
5063c0e1
TN
1552012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
156
157 * process.c (wait_reading_process_output): Handle pty disconnect
158 by refraining from sending oneself a SIGCHLD (bug#10933).
159
9f851fbd
CY
1602012-03-22 Chong Yidong <cyd@gnu.org>
161
162 * dispextern.h (struct it): New member string_from_prefix_prop_p.
163
5063c0e1 164 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
165 Mark string as coming from a prefix property.
166 (handle_face_prop): Use default face for prefix strings (Bug#4281).
167 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
168
fb5b8aca
CY
1692012-03-21 Chong Yidong <cyd@gnu.org>
170
171 * xfaces.c (Vface_remapping_alist): Doc fix.
172
62356a1b
EZ
1732012-03-20 Eli Zaretskii <eliz@gnu.org>
174
175 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
176 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
177 Doc fixes.
62356a1b 178
025de85b
CY
1792012-03-20 Chong Yidong <cyd@gnu.org>
180
181 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
182 to reflect default non-nil value of redisplay-dont-pause.
183
4827f94e
KH
1842012-03-19 Kenichi Handa <handa@m17n.org>
185
186 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
187 it fit in a valid range (Bug#11003).
188
e50a24a2
EZ
1892012-03-18 Eli Zaretskii <eliz@gnu.org>
190
191 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
192 that is not from display property, accept the row as a "cursor
193 row" if one of the string's character has a non-nil `cursor'
194 property. Fixes cursor positioning when there are newlines in
195 overlay strings, e.g. in icomplete.el. (Bug#11035)
196
9af5ed87
PE
1972012-03-12 Paul Eggert <eggert@cs.ucla.edu>
198
199 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
200
d1f55f16
CY
2012012-03-12 Chong Yidong <cyd@gnu.org>
202
203 * eval.c (inhibit_lisp_code): Rename from
204 inhibit_window_configuration_change_hook; move from window.c.
205
206 * xfns.c (unwind_create_frame_1, Fx_create_frame):
207 * window.c (run_window_configuration_change_hook)
208 (syms_of_window): Callers changed.
209
66c5eebd
CY
2102012-03-11 Chong Yidong <cyd@gnu.org>
211
413df973
CY
212 * keymap.c (Fkey_description): Doc fix (Bug#9700).
213
66c5eebd
CY
214 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
215
1de11f56
CY
2162012-03-10 Chong Yidong <cyd@gnu.org>
217
218 * frame.c (other_visible_frames): Don't assume the selected frame
219 is visible (Bug#10955).
220
cae07000
SM
2212012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
222
223 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
224
89c94350
JD
2252012-03-08 Jan Djärv <jan.h.d@swipnet.se>
226
227 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
228 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
229 zero (Bug#10954).
230
999dd333
GM
2312012-03-03 Glenn Morris <rgm@gnu.org>
232
01a6dcc8 233 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 234
de0100f2
EZ
2352012-03-02 Eli Zaretskii <eliz@gnu.org>
236
237 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
238 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
239 (redisplay_window, next_element_from_string): Fix typos in
240 comments.
3e441275
EZ
241 (redisplay_window): Pass to move_it_vertically the margin in
242 pixels, not in screen lines.
de0100f2 243
96a72ee9
GM
2442012-03-02 Glenn Morris <rgm@gnu.org>
245
246 * buffer.c (buffer-list-update-hook): Doc fix.
247
312508d7
EZ
2482012-02-29 Eli Zaretskii <eliz@gnu.org>
249
250 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
251 push_it before setting up the iterator for the first overlay
252 string, even if we have an empty string loaded.
253 (next_overlay_string): If there's an empty string on the iterator
254 stack, pop the stack. (Bug#10903)
255
27f3c637
PE
2562012-02-25 Paul Eggert <eggert@cs.ucla.edu>
257
258 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
259 Suggested by Stefan Monnier in
260 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
261 * alloc.c (widen_to_Lisp_Object): New static function.
262 (mark_memory): Also mark Lisp_Objects by fetching pointer words
263 and widening them to Lisp_Objects. This would work even if
264 USE_LSB_TAG is defined and wide integers are used, which might
265 happen in a future version of Emacs.
266
3c9dfce6
CY
2672012-02-25 Chong Yidong <cyd@gnu.org>
268
fa74b241
CY
269 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
270 Doc fix.
271
3c9dfce6
CY
272 * xselect.c (Fx_selection_exists_p): Doc fix.
273 (x_clipboard_manager_save_all): Print an informative message
274 before saving to clipboard manager.
275
9486df08
CY
2762012-02-24 Chong Yidong <cyd@gnu.org>
277
278 * keyboard.c (process_special_events): Handle all X selection
279 requests in kbd_buffer, not just the next one (Bug#8869).
280
f01d3321
CY
2812012-02-23 Chong Yidong <cyd@gnu.org>
282
283 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
284 call when setting menu-bar-lines and tool-bar-lines parameters.
285 (unwind_create_frame_1): New helper function.
286
287 * window.c (inhibit_window_configuration_change_hook): New var.
288 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 289 (syms_of_window): Initialize it.
f01d3321 290
86b847b6
CY
2912012-02-22 Chong Yidong <cyd@gnu.org>
292
293 * xterm.c (x_draw_image_relief): Add missing type check for
294 Vtool_bar_button_margin (Bug#10743).
295
a59225b1
CY
2962012-02-21 Chong Yidong <cyd@gnu.org>
297
298 * fileio.c (Vfile_name_handler_alist): Doc fix.
299
300 * buffer.c (Fget_file_buffer): Protect against invalid file
301 handler return value.
302
310f5bd4
PE
3032012-02-20 Paul Eggert <eggert@cs.ucla.edu>
304
cb3a28cc
PE
305 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
306 when computing $valmask.
307
310f5bd4
PE
308 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
309 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
310 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
311 It's useless in that case, and it can cause problems on hosts
312 that allocate halves of EMACS_INT values separately.
313 Reported by Dan Horák. Diagnosed by Andreas Schwab in
314 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
315 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
316 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
317 it avoids undefined behavior on hosts where shifting right by more
318 than the word width has undefined behavior.
319
2375c96a
CY
3202012-02-19 Chong Yidong <cyd@gnu.org>
321
322 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
323 (Funhandled_file_name_directory, Ffile_name_as_directory)
324 (Fdirectory_file_name, Fexpand_file_name)
325 (Fsubstitute_in_file_name): Protect against invalid file handler
326 return values (Bug#10845).
327
3eb49e71
EZ
3282012-02-18 Eli Zaretskii <eliz@gnu.org>
329
330 * .gdbinit (pitx): Fix incorrect references to fields of the
331 iterator stack.
332
7b926f3f
CY
3332012-02-17 Chong Yidong <cyd@gnu.org>
334
335 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
336
11273115
PE
3372012-02-15 Paul Eggert <eggert@cs.ucla.edu>
338
339 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
340 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
341
c3a70e2b
CY
3422012-02-15 Chong Yidong <cyd@gnu.org>
343
344 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
345 marked as special. Also, starting docstrings with * is obsolete.
346
0ca43699
AS
3472012-02-13 Andreas Schwab <schwab@linux-m68k.org>
348
349 * gnutls.c (emacs_gnutls_write): Fix last change.
350
2e8f3c56
LI
3512012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
352
353 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
354 send_process.
355
af70074f
SM
3562012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
357
358 * keymap.c (Fsingle_key_description): Handle char ranges.
359
95986d52
CY
3602012-02-12 Chong Yidong <cyd@gnu.org>
361
afd83bd1
CY
362 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
363 as that creates a dangerous corner case.
364
95986d52
CY
365 * window.c (Fdelete_window_internal): Invalidate the mouse
366 highlight (Bug#9904).
367
bd7da63e
GM
3682012-02-12 Glenn Morris <rgm@gnu.org>
369
370 * xselect.c (Fx_own_selection_internal)
371 (Fx_get_selection_internal, Fx_disown_selection_internal)
372 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
373 * nsselect.m (Fx_own_selection_internal)
374 (Fx_disown_selection_internal, Fx_selection_exists_p)
375 (Fx_selection_owner_p, Fx_get_selection_internal):
376 Sync docs and argument specs with the xselect.c versions.
377
77abcbc2
LI
3782012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
379
380 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
381
90b671e2
EZ
3822012-02-11 Eli Zaretskii <eliz@gnu.org>
383
1c0ca0b7
EZ
384 * w32select.c (Fx_selection_exists_p): Sync doc string and
385 argument list with xselect.c. (Bug#10783)
386
387 * w16select.c (Fx_selection_exists_p): Sync doc string and
388 argument list with xselect.c. (Bug#10783)
90b671e2 389
49241268
GM
3902012-02-10 Glenn Morris <rgm@gnu.org>
391
392 * fns.c (Fsecure_hash): Doc fix.
393
f998bbe7 3942012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
395
396 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
397
0992bd9c
CY
3982012-02-07 Chong Yidong <cyd@gnu.org>
399
400 * buffer.c (Fbuffer_local_variables)
401 (buffer_lisp_local_variables): Handle unbound vars correctly;
402 don't let Qunbound leak into Lisp.
403
af008560
GM
4042012-02-07 Glenn Morris <rgm@gnu.org>
405
dd605cc4
GM
406 * image.c (Fimagemagick_types): Doc fix.
407
af008560
GM
408 * image.c (imagemagick-render-type): Change it from a lisp object
409 to an integer. Move the doc here from the lisp manual.
410 Treat all values not equal to 0 the same.
411
1449fa1d
CY
4122012-02-06 Chong Yidong <cyd@gnu.org>
413
414 * doc.c (store_function_docstring): Avoid applying docstring of
415 alias to base function (Bug#2603).
416
3723ec07
AS
4172012-02-04 Andreas Schwab <schwab@linux-m68k.org>
418
419 * .gdbinit (pp1, pv1): Remove redundant defines.
420 (pr): Use pp.
421
79c1cc1e
CY
4222012-02-04 Chong Yidong <cyd@gnu.org>
423
424 * nsterm.m: Declare a global (Bug#10694).
425
d7f29f8e
EZ
4262012-02-04 Eli Zaretskii <eliz@gnu.org>
427
cae07000
SM
428 * w32.c (get_emacs_configuration_options):
429 Include --enable-checking, if specified, in the return value.
d7f29f8e 430
3b95a6f9
MR
4312012-02-04 Martin Rudalics <rudalics@gmx.at>
432
433 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
434 after rounding frame sizes. (Bug#9723)
435
d6fa96a6
EZ
4362012-02-04 Eli Zaretskii <eliz@gnu.org>
437
438 * keyboard.c (adjust_point_for_property): Don't position point
439 before BEGV. (Bug#10696)
440
df0b2940
PE
4412012-02-03 Paul Eggert <eggert@cs.ucla.edu>
442
443 Handle overflow when computing char display width (Bug#9496).
444 * character.c (char_width): Return EMACS_INT, not int.
445 (char_width, c_string_width): Check for overflow when
446 computing the width; this is possible now that individual
447 characters can have unbounded width. Problem introduced
448 by merge from Emacs 23 on 2012-01-19.
449
6bee44d6
MA
4502012-02-02 Michael Albinus <michael.albinus@gmx.de>
451
452 * dbusbind.c (Fdbus_register_method): Mention the return value
453 :ignore in the docstring.
454
44f92739
GM
4552012-02-02 Glenn Morris <rgm@gnu.org>
456
1b9f60cc
GM
457 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
458
44f92739
GM
459 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
460 Unconditionally set to t. (Bug#10673)
461 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
462 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
463 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
464
c5d3843c
KH
4652012-02-02 Kenichi Handa <handa@m17n.org>
466
467 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
468 0, do not call append_composite_glyph.
469
159462d4 4702012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
471
472 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
473 NULL (Bug#6988).
474 (x_produce_glyphs): If the component of a composition is a null
475 string, set it->pixel_width to 1 to avoid zero-width glyph.
476
78cef877
EZ
4772012-02-01 Eli Zaretskii <eliz@gnu.org>
478
479 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
480 first 2 arguments are identical. This makes inserting large
481 output from a subprocess an order of magnitude faster on
482 MS-Windows, where all sbrk'ed memory is always contiguous.
483
97897668
GM
4842012-01-31 Glenn Morris <rgm@gnu.org>
485
486 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 487 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
488 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
489
31fd3586
GM
4902012-01-29 Glenn Morris <rgm@gnu.org>
491
492 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
493
0e24a8b2
CY
4942012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
495
496 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
497
cc0adcb0
CY
4982012-01-28 Chong Yidong <cyd@gnu.org>
499
500 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
501
acc28cb9
CY
5022012-01-26 Chong Yidong <cyd@gnu.org>
503
9c69cfb7
CY
504 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
505
acc28cb9
CY
506 * search.c (Fsearch_forward, Fsearch_backward): Document negative
507 repeat counts (Bug#10507).
508
48da7392
GM
5092012-01-26 Glenn Morris <rgm@gnu.org>
510
511 * lread.c (syms_of_lread): Doc fix.
512
14af5f7f
CY
5132012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
514
515 * coding.c (encode_designation_at_bol): Change return value to
516 EMACS_INT.
517
0b21c100
CY
5182012-01-25 Chong Yidong <cyd@gnu.org>
519
520 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
521
3c2907f7
CY
5222012-01-21 Chong Yidong <cyd@gnu.org>
523
524 * floatfns.c (Fcopysign): Make the second argument non-optional,
525 since nil is not allowed anyway.
526
959ad23f
AS
5272012-01-21 Andreas Schwab <schwab@linux-m68k.org>
528
529 * process.c (read_process_output): Use p instead of XPROCESS (proc).
530 (send_process): Likewise.
531
34a02f46
MR
5322012-01-19 Martin Rudalics <rudalics@gmx.at>
533
534 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
535 (Vwindow_persistent_parameters): Do not use Qstate.
536 Rewrite doc-strings.
34a02f46 537
1259009a 5382012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
539
540 * character.c (char_width): New function.
70d4fdf6
GM
541 (Fchar_width, c_string_width, lisp_string_width):
542 Use char_width (Bug#9496).
25ed9e61 543
6a6ee00d
MR
5442012-01-16 Martin Rudalics <rudalics@gmx.at>
545
546 * window.c (Vwindow_persistent_parameters): New variable.
547 (Fset_window_configuration, save_window_save): Handle persistent
548 window parameters.
549
c85efaf7
EZ
5502012-01-14 Eli Zaretskii <eliz@gnu.org>
551
552 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
553 thrashing the stack of the thread. (Bug#9087)
554
5944709e
PE
5552012-01-12 Paul Eggert <eggert@cs.ucla.edu>
556
557 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
558
e71f5d99
EZ
5592012-01-11 Eli Zaretskii <eliz@gnu.org>
560
561 * xdisp.c (rows_from_pos_range): Handle the case where the
562 highlight ends on a newline. (Bug#10464)
563 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
564 he end column for display of highlight that ends on a newline
565 before a R2L line.
566
ce316182
GM
5672012-01-11 Glenn Morris <rgm@gnu.org>
568
569 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
570 from load-path also when installation-directory is nil. (Bug#10208)
571
5b43da69
GM
5722012-01-10 Glenn Morris <rgm@gnu.org>
573
74cc8ff9
GM
574 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
575
7d8d6e4e
GM
576 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
577 Update template values to be closer to their typical values these days.
5b43da69 578
a0db8d43
EZ
5792012-01-09 Eli Zaretskii <eliz@gnu.org>
580
581 * xdisp.c (rows_from_pos_range): Accept additional argument
582 DISP_STRING, and accept any glyph in a row whose object is that
583 string as eligible for mouse highlight. Fixes mouse highlight of
584 display strings from overlays. (Bug#10464)
585
9a0115ab 5862012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 587
b9110d6a 588 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
589 * fileio.c (auto_saving_dir_umask): New static var.
590 (Fmake_directory_internal): Use it.
591 (do_auto_save_make_dir): Set it, instead of invoking chmod after
592 creating the directory. The old code temporarily assigns
593 too-generous permissions to the directory.
594 (do_auto_save_eh): Clear it.
b9110d6a 595 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
596 that the var is always cleared.
597
6c1bd3f3
EZ
5982012-01-07 Eli Zaretskii <eliz@gnu.org>
599
600 * search.c (scan_buffer): Pass character positions to
601 know_region_cache, not byte positions. (Bug#6540)
602
069d2b50
L
6032012-01-07 LynX <_LynX@bk.ru> (tiny change)
604
605 * w32.c (sys_rename): Report EXDEV when rename of a directory
606 fails because the target is on another logical disk. (Bug#10284)
607
75bf0d33
DB
6082012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
609
610 * xterm.c (x_embed_request_focus): New function.
611
612 * xterm.h: Add prototype.
613
614 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
615
1c6e5a32
GM
6162012-01-05 Glenn Morris <rgm@gnu.org>
617
618 * emacs.c (emacs_copyright): Update short copyright year to 2012.
619
651e947e
EZ
6202012-01-01 Eli Zaretskii <eliz@gnu.org>
621
622 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
623 Load gnutls_transport_set_lowat only if GnuTLS version is below
624 2.11.1.
625 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
626 GnuTLS versions below 2.11.1.
627
3778cdd8
AL
6282011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
629
630 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
631 to the doc string advising against its use for altering the way
632 windows are scrolled.
633
0e5317f7
KH
6342011-12-28 Kenichi Handa <handa@m17n.org>
635
636 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
637 coding-system ASCII compatible only when it does not produce BOM
638 on encoding (Bug#10383).
639
93d5ca1f
JD
6402011-12-26 Jan Djärv <jan.h.d@swipnet.se>
641
642 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
643 can scroll.
644 (create_and_show_popup_menu): Always use menu_position_func for
645 Gtk3 (Bug#10361).
646
ca22b785
AS
6472011-12-24 Andreas Schwab <schwab@linux-m68k.org>
648
649 * callint.c (Fcall_interactively): Don't truncate prompt string.
650
d048e1e6
EZ
6512011-12-23 Eli Zaretskii <eliz@gnu.org>
652
653 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
654 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 655 resumed from there (after widening). (Bug#10360)
d048e1e6 656
5ccaba1f
JD
6572011-12-22 Jan Djärv <jan.h.d@swipnet.se>
658
659 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
660
204ee57f
JD
6612011-12-21 Jan Djärv <jan.h.d@swipnet.se>
662
b81d40f0
JB
663 * nsterm.m (x_free_frame_resources):
664 Release f->output_data.ns->miniimage.
204ee57f
JD
665 (ns_index_color): Fix indentation. Do not retain
666 color_table->colors[i].
667
668 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
669 before returning.
670
671 * nsfns.m (x_set_background_color): Assign return value from
672 ns_index_color to face-background instead of NSColor*.
673 (ns_implicitly_set_icon_type): Fix indentation.
674 Change assignment in for loop to comparison.
675
676 * emacs.c (ns_pool): New variable.
677 (main): Assign ns_pool.
678 (Fkill_emacs): Call ns_release_autorelease_pool.
679
680 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
681 autorelease fdesc, release fdAttrs and tdict.
682 (ns_get_covering_families): Release charset.
683 (ns_findfonts): Release NSFontDescriptor created with new.
684 (ns_uni_to_glyphs): Fix indentation.
685 (setString): Release attrStr before assigning new value.
686
c803b2b7
JD
6872011-12-18 Jan Djärv <jan.h.d@swipnet.se>
688
678f4426
JD
689 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
690 and NS_IMPL_COCOA.
691 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
692 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
693
cd394be1 6942011-12-18 David Reitter <reitter@cmu.edu>
678f4426 695
5fecd5fc
JD
696 * nsterm.m (ns_term_init): Subscribe for notifications
697 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
698 to method trackingNotification in EmacsMenu.
699
700 * nsmenu.m (trackingMenu): New variable.
3771cb17 701 (trackingNotification): New method (from Aquamacs).
5fecd5fc 702 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 703 from Aquamacs (Bug#7030).
678f4426
JD
704
7052011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 706
c803b2b7
JD
707 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
708 (symbol_to_nsstring): Fix indentation.
709 (ns_symbol_to_pb): New function.
cae07000
SM
710 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
711 (Fns_rotate_cut_buffers_internal): Remove.
712 (Fns_store_selection_internal): Rename from
c803b2b7
JD
713 Fns_store_cut_buffer_internal.
714 (ns_get_foreign_selection, Fx_own_selection_internal)
715 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
716 (Fns_get_selection_internal, Fns_store_selection_internal):
717 Use ns_symbol_to_pb and check if return value is nil.
718 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
719 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
720 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
721 renamed to Sns_store_selection_internal.
722 (ns_handle_selection_request): Move code to Fx_own_selection_internal
723 and remove this function.
724 (ns_handle_selection_clear): Remove, never used.
725 (Fx_own_selection_internal): Move code from ns_handle_selection_request
726 here.
727
e1b01a3a
KB
7282011-12-17 Ken Brown <kbrown@cornell.edu>
729
730 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
731 GID is unknown (Bug#10257).
732
2adb6e85
PE
7332011-12-17 Paul Eggert <eggert@cs.ucla.edu>
734
735 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
736 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
737 which caused a build failure on GNU/Linux IA-64. This problem was
738 introduced by my 2011-10-07 patch.
739
d1d7b339
JL
7402011-12-15 Juri Linkov <juri@jurta.org>
741
742 * image.c (imagemagick_error): New function. (Bug#10112)
743 (imagemagick_load_image): Comment out `MagickSetResolution' call.
744 Use `imagemagick_error' where ImageMagick functions return
745 `MagickFalse'.
746 (Fimagemagick_types): Add `Fnreverse' to return the list in the
747 proper order.
748
100d5755
KH
7492011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
750
751 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
752 fill background (Bug#8992).
753
454592a6
MR
7542011-12-13 Martin Rudalics <rudalics@gmx.at>
755
756 * window.c (Vwindow_combination_resize)
757 (Vwindow_combination_limit): Use t instead of non-nil in
758 doc-strings.
61d4b438
MR
759 (Vrecenter_redisplay): Add first sentence of doc-string on
760 separate line.
53524d93 761 (Frecenter): Fix doc-string typo.
454592a6 762
3633e3aa
KH
7632011-12-11 Kenichi Handa <handa@m17n.org>
764
765 * coding.c (Funencodable_char_position): Pay attention to the
766 buffer text relocation (Bug#9389).
767
7b9d523a
JD
7682011-12-10 Jan Djärv <jan.h.d@swipnet.se>
769
770 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
771 gtk_init (Bug#10100).
772
b73189c6
EZ
7732011-12-10 Eli Zaretskii <eliz@gnu.org>
774
775 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
776 IT->string is nil. (Bug#10263)
777
f7dfe5d6
JD
7782011-12-10 Jan Djärv <jan.h.d@swipnet.se>
779
83faebb4
JD
780 * nsterm.h (x_free_frame_resources): Declare.
781
f7dfe5d6
JD
782 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
783 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
784
785 * nsterm.h (ns_get_defaults_value): Declare.
786
787 * nsterm.m (ns_default): Call ns_get_defaults_value.
788
7cd4e72c
EZ
7892011-12-09 Eli Zaretskii <eliz@gnu.org>
790
791 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
792 (Bug#10170)
793
b34d7317
YM
7942011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
795
796 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
797 that where the value of an _OBJC_* symbol points to is in the .bss
798 section (Bug#10240).
799
76470ad1
KH
8002011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
801
802 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 803 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 804
745fff94
KH
8052011-12-08 Kenichi Handa <handa@m17n.org>
806
807 * ftfont.c (get_adstyle_property): Fix previous change
808 (Bug#10233).
809
6e44397c
JB
8102011-12-07 Juanma Barranquero <lekktu@gmail.com>
811
812 * w32.c (init_environment): If no_site_lisp, remove site-lisp
813 dirs from the default value of EMACSLOADPATH (bug#10208).
814
7efa6272
GM
8152011-12-07 Glenn Morris <rgm@gnu.org>
816
817 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
818 installation and source directories as well. (Bug#10208)
819
f6fc4d87
CY
8202011-12-06 Chong Yidong <cyd@gnu.org>
821
822 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
823
2bf26180
GM
8242011-12-06 Glenn Morris <rgm@gnu.org>
825
826 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
827 as an error, not just -1. (Bug#10217)
828
3a6ad4f0
CY
8292011-12-05 Chong Yidong <cyd@gnu.org>
830
831 * keyboard.c (process_special_events): New function.
832 (swallow_events, Finput_pending_p): Use it (Bug#10195).
833
75a3b399
PE
8342011-12-05 Paul Eggert <eggert@cs.ucla.edu>
835
836 * coding.c (encode_designation_at_bol): Don't use uninitialized
837 local variable (Bug#9318).
838
c3c9e25e
KH
8392011-12-05 Kenichi Handa <handa@m17n.org>
840
841 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
842 return Qnil (Bug#8046, Bug#10193).
843
5eb05ea3
KH
8442011-12-05 Kenichi Handa <handa@m17n.org>
845
846 * coding.c (encode_designation_at_bol): New args charbuf_end and
847 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
848 (coding_set_source): Return how many bytes coding->source was
849 relocated.
850 (coding_set_destination): Return how many bytes
851 coding->destination was relocated.
852 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 853 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
854
8552011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
856
857 * coding.c (CODING_CHAR_CHARSET_P): New macro.
858 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
859 macro (Bug#9318).
860
8612011-12-05 Andreas Schwab <schwab@linux-m68k.org>
862
863 The following changes are to fix Bug#9318.
864
a79703f5 865 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
866 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
867 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 868 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 869
7dbda6df
JB
8702011-12-05 Juanma Barranquero <lekktu@gmail.com>
871
872 * lisp.h (process_quit_flag): Fix external declaration.
873
6d5eb5b0
SM
8742011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
875
876 Don't macro-inline non-performance-critical code.
877 * eval.c (process_quit_flag): New function.
878 * lisp.h (QUIT): Use it.
879
a0c3fad0
JD
8802011-12-04 Jan Djärv <jan.h.d@swipnet.se>
881
882 * nsfns.m (get_geometry_from_preferences): New function.
883 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
884
6c07aac2
AS
8852011-12-04 Andreas Schwab <schwab@linux-m68k.org>
886
887 * emacs.c (Qkill_emacs): Define.
888 (syms_of_emacs): Initialize it.
889 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
890 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
891 (quit_throw_to_read_char): Add parameter `from_signal'.
892 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
893 * lisp.h (QUIT): Call Fkill_emacs if requested.
894
c052ead4
JD
8952011-12-03 Jan Djärv <jan.h.d@swipnet.se>
896
897 * widget.c (update_wm_hints): Return if wmshell is null.
898 (widget_update_wm_size_hints): New function.
899
900 * widget.h (widget_update_wm_size_hints): Declare.
901
902 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
903 widget_update_wm_size_hints (Bug#10104).
904
9e49252b
EZ
9052011-12-03 Eli Zaretskii <eliz@gnu.org>
906
907 * xdisp.c (handle_invisible_prop): If the invisible text ends just
908 before a newline, prepare the bidi iterator for consuming the
909 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 910 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 911
02b16839
JL
9122011-12-02 Juri Linkov <juri@jurta.org>
913
914 * search.c (Fword_search_regexp): New Lisp function created from
915 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
916 (Fword_search_backward, Fword_search_forward)
917 (Fword_search_backward_lax, Fword_search_forward_lax):
918 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
919 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
920
0068070e
SM
9212011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
922
923 * fileio.c (Finsert_file_contents): Move after-change-function call
924 to before the "handled:" label, since all "goto handled" appear in
925 cases where the *-change-functions have already been properly called
926 (bug#10117).
927
3360a3fc
AS
9282011-12-01 Andreas Schwab <schwab@linux-m68k.org>
929
930 * keyboard.c (interrupt_signal): Don't call kill-emacs when
931 waiting for input. (Bug#10169)
932
73d6c093
EZ
9332011-11-30 Eli Zaretskii <eliz@gnu.org>
934
935 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
936 verifies glyph row's hash code--we have just reallocated the
937 glyphs, so their contents can be complete garbage. (Bug#10164)
938
febe6bea
JB
9392011-11-30 Juanma Barranquero <lekktu@gmail.com>
940
941 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
942
801a4313
EZ
9432011-11-30 Eli Zaretskii <eliz@gnu.org>
944
945 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
946 attributes are tested _before_ calling verify_row_hash, to protect
947 against GCC re-ordering of the tests. (Bug#10164)
948
2b56b87e
JD
9492011-11-29 Jan Djärv <jan.h.d@swipnet.se>
950
951 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
952
953 * xterm.c (handle_one_xevent): Only set async_visible and friends
954 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 955 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
956 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
957
dbf31225
PE
9582011-11-28 Paul Eggert <eggert@cs.ucla.edu>
959
960 Remove GCPRO-related macros that exist only to avoid shadowing locals.
961 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
962 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
963 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
964 All uses changed to use GCPRO1 etc.
965 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
966 Revert to old implementation (i.e., before 2011-03-11).
967
1305621b
YM
9682011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
969
970 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
971 of scroll runs so as to avoid assigning disabled bogus rows and
972 unnecessary graphics copy operations.
973
8c9afb46
EZ
9742011-11-27 Eli Zaretskii <eliz@gnu.org>
975
976 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
977 (snprintf) [_MSC_VER]: Redirect to _snprintf.
978 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
979 (malloc, free, realloc, calloc): Redirect to e_* only when
980 compiling Emacs.
981
982 * lisp.h (GCTYPEBITS): Move before first use.
983 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
984 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
985 this macro definition.
986
987 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
988 _MSC_VER.
989
54e9e3bf
JD
9902011-11-27 Jan Djärv <jan.h.d@swipnet.se>
991
6d5eb5b0
SM
992 * gtkutil.c (xg_create_frame_widgets):
993 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
994 present with Gtk+ 2.0.
995
83aca1cb
PE
9962011-11-26 Paul Eggert <eggert@cs.ucla.edu>
997
998 * fileio.c (Finsert_file_contents): Undo previous change; see
999 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1000
5b76caa4
PE
10012011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1002
1003 Rename locals to avoid shadowing.
1004 * fileio.c (Finsert_file_contents):
1005 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1006 * process.c (wait_reading_process_output):
1007 Rename inner 'proc' to 'p' to avoid shadowing.
1008 Indent for consistency with usual Emacs style.
1009
8c535114
EZ
10102011-11-25 Eli Zaretskii <eliz@gnu.org>
1011
1012 * xdisp.c (redisplay_window): If cursor row is not fully visible
1013 after recentering, and scroll-conservatively is set to a large
1014 number, scroll window by a few more lines to make the cursor fully
1015 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1016 (start_display): Don't move to the next line if the display should
1017 start at a newline that is part of a display vector or an overlay
1018 string. (Bug#10119)
8c535114 1019
fa4fdb5c
JL
10202011-11-24 Juri Linkov <juri@jurta.org>
1021
1022 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1023 after the `MagickPingImage' call. (Bug#10112)
1024
90ec88df
CY
10252011-11-23 Chong Yidong <cyd@gnu.org>
1026
1027 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1028
56e2e794
MR
10292011-11-23 Martin Rudalics <rudalics@gmx.at>
1030
1031 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1032 making another buffer current. (Bug#10114)
1033
b6e64c41
GM
10342011-11-23 Glenn Morris <rgm@gnu.org>
1035
1036 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1037
6b21de18
CY
10382011-11-23 Chong Yidong <cyd@gnu.org>
1039
1040 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1041 using it (Bug#5984).
1042
b12cd789
EZ
10432011-11-22 Eli Zaretskii <eliz@gnu.org>
1044
1045 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1046 and header-lines, as they don't have one computed for them.
1047 (Bug#10098)
1048
1049 * .gdbinit (prow): Make displayed values more self-explaining.
1050 Add row's hash code.
1051
261b6fd4
LMI
10522011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1053
1054 * process.c (wait_reading_process_output): Fix asynchrounous
1055 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1056 (wait_reading_process_output): Add comment and URL.
261b6fd4 1057
e7cfd277
JD
10582011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1059
1060 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1061
a9b9b7f5
CY
10622011-11-21 Chong Yidong <cyd@gnu.org>
1063
1064 * window.c (Fnext_window, Fprevious_window): Doc fix.
1065
b0d15b4f
SM
10662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1067
1068 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1069
fe7a3057
JB
10702011-11-20 Juanma Barranquero <lekktu@gmail.com>
1071
1072 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1073
d2999b1a
MR
10742011-11-20 Martin Rudalics <rudalics@gmx.at>
1075
1076 * window.c (Fset_window_combination_limit): Rename argument
1077 STATUS to LIMIT.
1078 (Vwindow_combination_limit): Remove "status" from doc-string.
1079
d5ff9cd0
AS
10802011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1081
1082 * m/ibms390.h: Remove.
1083 * m/ibms390x.h: Don't include "ibms390.h".
1084
a5bb9bd3
SM
10852011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1086
1087 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1088 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1089
cd1181db
JB
10902011-11-20 Juanma Barranquero <lekktu@gmail.com>
1091
1092 * casetab.c (Fset_case_table):
1093 * charset.c (Fcharset_after): Fix typos.
1094
615a3b8d 10952011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1096
17e845af
PE
1097 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1098 Otherwise, valgrind does not work on some platforms.
1099 Problem reported by Andreas Schwab in
6a0bf43d
PE
1100 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1101 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1102 is set, removing the need for VIRT_ADDRESS_VARIES.
1103 (PURE_P): Use a more-efficient implementation that needs just one
1104 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1105 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1106 to 4 (xorl, subq, cmpq, setbe).
1107 * alloc.c (pure): Always extern now, since that's the
1108 VIRT_ADDR_VARIES behavior.
1109 (PURE_POINTER_P): Use a single comparison, not two, for
1110 consistency with the new puresize.h.
1111 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1112 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1113 Remove VIRT_ADDR_VARIES no longer needed.
1114
f8fe6f96
EZ
11152011-11-19 Eli Zaretskii <eliz@gnu.org>
1116
1117 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1118 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1119 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1120 behave as if the cursor position were at the window margin.
1121
1122 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1123 and the cursor position is out of bounds, behave as if the cursor
1124 position were at the window margin. (Bug#10075)
1125
df05a53c
CY
11262011-11-18 Chong Yidong <cyd@gnu.org>
1127
1128 * window.c (Fwindow_combination_limit): Make first argument
1129 non-optional, since it is meaningless for live windows like the
1130 selected window.
1131
2071918e
DA
11322011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1133
1134 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1135
b50a28de
SM
11362011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1137
1138 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1139 (graft_intervals_into_buffer): Simplify.
1140
015137db
EZ
11412011-11-18 Eli Zaretskii <eliz@gnu.org>
1142
1143 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1144 hash values of the two rows.
1145 (copy_row_except_pointers): Preserve the used[] arrays and the
1146 hash values of the two rows. (Bug#10035)
68c95424 1147 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1148
1149 * xdisp.c (row_hash): New function, body extracted from
1150 compute_line_metrics.
1151 (compute_line_metrics): Call row_hash, instead of computing the
1152 hash code inline.
1153
1154 * dispnew.c (verify_row_hash): Call row_hash for computing the
1155 hash code of a row, instead of duplicating code from xdisp.c.
1156
1157 * dispextern.h (row_hash): Add prototype.
1158
a2addb04
TH
11592011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1160
1161 * frame.c (delete_frame): Don't delete the terminal when the last
1162 X frame is closed if emacs is built with GTK toolkit.
1163
df85d315
JB
11642011-11-17 Juanma Barranquero <lekktu@gmail.com>
1165
1166 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1167
a0c2d0ae
MR
11682011-11-17 Martin Rudalics <rudalics@gmx.at>
1169
1170 * window.c (Vwindow_splits): Rename to
1171 Vwindow_combination_resize. Suggested by Juri Linkov.
1172 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1173 of Vwindow_splits.
1174
58179cce
JB
11752011-11-16 Juanma Barranquero <lekktu@gmail.com>
1176
7877f373
JB
1177 * nsfns.m (Fns_font_name):
1178 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1179
b6f67890
MR
11802011-11-16 Martin Rudalics <rudalics@gmx.at>
1181
1182 * window.h (window): Rename slot "nest" to "combination_limit".
1183 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1184 (Fset_window_nest): Rename to Fset_window_combination_limit.
1185 (Vwindow_nest): Rename to Vwindow_combination_limit.
1186 (recombine_windows, make_parent_window, make_window)
1187 (Fsplit_window_internal, saved_window)
1188 (Fset_window_configuration, save_window_save): Rename all
1189 occurrences of window_nest to window_combination_limit.
1190
c7015153
JB
11912011-11-15 Juanma Barranquero <lekktu@gmail.com>
1192
1193 * image.c (imagemagick_load_image): Fix typo.
1194
322ad6ec
EZ
11952011-11-14 Eli Zaretskii <eliz@gnu.org>
1196
1197 * xdisp.c (display_line): Move the call to
1198 highlight_trailing_whitespace before the call to
1199 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1200 faces of all the glyphs to compute ROW's hash value.
1201 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1202
f067b8ec
JB
12032011-11-14 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1206 just return (bug#10044).
1207
1e5b2111
EZ
12082011-11-12 Eli Zaretskii <eliz@gnu.org>
1209
7ef3cbd5
EZ
1210 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1211 with user-defined heap size. Bump the default size of the temacs
1212 heap to 27MB, to avoid memory warning when running temacs.
1213 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1214
1e5b2111
EZ
1215 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1216 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1217 (verify_row_hash) [XASSERTS]: New function.
1218 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1219 that the hash value of glyph rows is correct.
1e5b2111 1220
89d61221
MR
12212011-11-12 Martin Rudalics <rudalics@gmx.at>
1222
1223 * window.h (window): Remove splits slot.
1224 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1225 (Fdelete_other_windows_internal, make_parent_window)
1226 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1227 (Fset_window_configuration, save_window_save): Don't deal with
1228 split status of windows.
1229 (saved_window): Remove splits slot.
1230 (Vwindow_splits): Rewrite doc-string.
1231
97f18cc8
JD
12322011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1233
1234 * xfns.c (unwind_create_frame):
1235 * nsfns.m (unwind_create_frame):
1236 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1237 Vframe_list (Bug#9999).
1238
22a648b4
DA
12392011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1240
0b381c7e 1241 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1242
659afede
KH
12432011-11-11 Kenichi Handa <handa@m17n.org>
1244
1245 * callproc.c (Fcall_process): Set the member dst_multibyte of
1246 process_coding.
1247
9ac0394b
KH
12482011-11-11 Johan Bockgård <bojohan@gnu.org>
1249
1250 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1251 avoid a crash (bug#9496).
1252
2fbdc249
CY
12532011-11-09 Chong Yidong <cyd@gnu.org>
1254
1255 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1256 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1257
ac6b1f81
PE
12582011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1261
09db192c
PE
12622011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Avoid some portability problems by eschewing 'extern inline' functions.
1265 The trivial performance wins aren't worth the portability hassles; see
1266 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1267 et seq.
1268 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1269 (window_box_width, window_box_left, window_box_left_offset)
1270 (window_box_right, window_box_right_offset): Undo previous change,
1271 by removing the "extern"s.
1272 * intervals.c (adjust_intervals_for_insertion)
1273 (adjust_intervals_for_deletion): Undo previous change,
1274 making these static again.
1275 (offset_intervals, temp_set_point_both, temp_set_point)
1276 (copy_intervals_to_string): No longer inline.
1277 * xdisp.c (window_text_bottom_y, window_box_width)
1278 (window_box_height, window_box_left_offset)
1279 (window_box_right_offset, window_box_left, window_box_right)
1280 (window_box): No longer inline.
1281
105216ed
CY
12822011-11-08 Chong Yidong <cyd@gnu.org>
1283
1284 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1285 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1286 Signal an error if not a live window.
105216ed
CY
1287 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1288 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1289
ae9e237f
JB
12902011-11-07 Juanma Barranquero <lekktu@gmail.com>
1291
1292 * lisp.h (syms_of_abbrev): Remove declaration.
1293 Reported by CHENG Gao <chenggao@royau.me>.
1294
c7aa8333
EZ
12952011-11-07 Eli Zaretskii <eliz@gnu.org>
1296
1297 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1298 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1299 of temacs in GUI mode.
1300
be7f5545
MR
13012011-11-07 Martin Rudalics <rudalics@gmx.at>
1302
1303 * window.h: Declare delete_all_child_windows instead of
1304 delete_all_subwindows.
1305 * window.c (Fwindow_nest, Fset_window_nest)
1306 (Fset_window_new_total, Fset_window_new_normal)
1307 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1308 (delete_all_subwindows): Rename to delete_all_child_windows.
1309 (Fdelete_other_windows_internal, Fset_window_configuration):
1310 Call delete_all_child_windows instead of delete_all_subwindows.
1311 * frame.c (delete_frame): Call delete_all_child_windows instead
1312 of delete_all_subwindows.
1313
ca78dc43
PE
13142011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1317 This is also needed for porting to any host where GC_MARK_STACK is
1318 not GC_MAKE_GCPROS_NOOPS.
1319 (which_symbols): Use it.
1320
a0241d01
KH
13212011-11-07 Kenichi Handa <handa@m17n.org>
1322
1323 * coding.c (coding_set_destination): Check coding->src_pos only
1324 when coding->src_object is a buffer (bug#9910).
1325
1326 * process.c (send_process): Set the member src_multibyte of coding
1327 to 0 (bug#9911) when sending a unibyte text.
1328
1329 * callproc.c (Fcall_process): Set the member src_multibyte of
1330 process_coding to 0 (bug#9912).
1331
a64bfdfa 13322011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1333
1334 * xmenu.c (cleanup_widget_value_tree): New function.
1335 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1336 calling free_menubar_widget_value_tree directly (Bug#9830).
1337
cb41b32a
PE
13382011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 Fix some portability problems with 'inline'.
1341 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1342 (window_box_width, window_box_left, window_box_left_offset)
1343 (window_box_right, window_box_right_offset): Declare extern.
1344 Otherwise, these inline functions do not conform to C99 and
1345 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1346 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1347 * intervals.c (adjust_intervals_for_insertion)
1348 (adjust_intervals_for_deletion): Now extern, because otherwise the
1349 extern inline functions 'offset_intervals' couldn't refer to it.
1350 (static_offset_intervals): Remove.
1351 (offset_intervals): Rewrite using the old contents of
1352 static_offset_intervals. The old version didn't conform to C99
1353 because an extern inline function contained a reference to an
1354 identifier with static linkage.
1355
b7041366
AS
13562011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1357
1358 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1359 GC.
1360
88a37c4d
EZ
13612011-11-06 Eli Zaretskii <eliz@gnu.org>
1362
1363 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1364 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1365 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1366 return Qleft_to_right.
1367
49745b39
CY
13682011-11-06 Chong Yidong <cyd@gnu.org>
1369
1370 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1371 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1372 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1373 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1374 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1375 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1376 (Fwindow_vscroll): Doc fix.
1377 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1378 argument, since it makes no sense to pass a live window and for
1379 consistency with window-child.
1380
1f05cd82
CS
13812011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1382
1383 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1384 support MSVC.
1385
22610910
JR
13862011-11-05 Jason Rumney <jasonr@gnu.org>
1387
1388 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1389 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1390 fonts (Bug#6029).
1391 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1392 bitwise arithmetic preventing use of unicode-sip and non-truetype
1393 opentype fonts.
1394
a06776b2
EZ
13952011-11-05 Eli Zaretskii <eliz@gnu.org>
1396
3ad924ba
EZ
1397 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1398 "emacs"-only part.
1399
a06776b2
EZ
1400 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1401 initialization code to keep similarity to xfns.c after changes
1402 from 2011-11-05.
1403
c9e7db78
JD
14042011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1405
a97f8f3f
JD
1406 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1407 (unwind_create_frame): New function (Bug#9943).
1408 (Fx_create_frame): Restructure code to be more similar to the one in
1409 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1410 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1411 Move terminal->reference_count++ just before making the frame official
1412 (Bug#9943).
1413
1414 * nsterm.m (x_free_frame_resources): New function.
1415 (x_destroy_window): Move code to x_free_frame_resources.
1416
c9e7db78 1417 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1418 (Fx_create_frame, x_create_tip_frame):
1419 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1420 official. Move initialization of image_cache_refcount and
1421 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1422
a6fc3b5c
EZ
14232011-11-05 Eli Zaretskii <eliz@gnu.org>
1424
1425 Support MSVC build with newer versions of Visual Studio.
1426 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1427 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1428 nt/gmake.defs.
1429
1430 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1431 which are not supported by MSVC.
1432 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1433 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1434 bitfields.
1435 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1436 types in bitfields.
1437 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1438
1439 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1440
58179cce 14412011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1442
1443 Support MSVC build with newer versions of Visual Studio.
1444 * w32.c: Don't include w32api.h for MSVC.
1445 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1446
1447 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1448 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1449 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1450 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1451 e_* cousins.
1452 (alloca) [_MSC_VER]: Define to _alloca.
1453
1454 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1455
1456 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1457
a58c13ed
EZ
14582011-11-04 Eli Zaretskii <eliz@gnu.org>
1459
1460 * xdisp.c (note_mouse_highlight): If either of
1461 previous/next-single-property-change returns nil, treat that as
1462 the beginning or the end of the buffer. (Bug#9955)
1463
fe0b6370
JD
14642011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1465
a58c13ed 1466 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1467 label is not null (Bug#9951).
1468 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1469 may be NULL.
1470
89bd5ee1
EZ
14712011-11-04 Eli Zaretskii <eliz@gnu.org>
1472
1473 * window.c (Fwindow_body_size): Mention in the doc string that the
1474 return value is in frame's canonical units. (Bug#9949)
1475
84c3edb9
EZ
14762011-11-03 Eli Zaretskii <eliz@gnu.org>
1477
4e2fb5c7
EZ
1478 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1479
84c3edb9 1480 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1481 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1482 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1483
bc17a887
EZ
14842011-11-01 Eli Zaretskii <eliz@gnu.org>
1485
1486 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1487 Don't stop backward scan on the continuation glyph, even though
1488 its CHARPOS is positive.
6d5eb5b0
SM
1489 (mouse_face_from_buffer_pos, note_mouse_highlight):
1490 Rename cover_string to disp_string.
bc17a887 1491
4ee88440
MR
14922011-11-01 Martin Rudalics <rudalics@gmx.at>
1493
1494 * window.c (temp_output_buffer_show): Don't use
1495 Vtemp_buffer_show_specifiers.
1496 (Vtemp_buffer_show_specifiers): Remove unused variable.
1497
c2ff3c02
EZ
14982011-10-30 Eli Zaretskii <eliz@gnu.org>
1499
1500 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1501 past the beginning of the current glyph matrix.
1502
58179cce 15032011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1504
1505 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1506 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1507 HAVE_GTK3 (Bug#9869).
b77a6a7f 1508
3b574623
JD
1509 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1510 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1511
b77a6a7f
JD
1512 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1513
1514 * xterm.c: Declare x_handle_net_wm_state to return int.
1515 (handle_one_xevent): Check if we are iconified but don't have
1516 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1517 (get_current_wm_state): Return non-zero if not hidden,
1518 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1519 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1520 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1521 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1522
196e41e4
PE
15232011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1526 so that this new function doesn't get optimized away by a
1527 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1528
021f2e1a
AS
15292011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1532
8b058d44
EZ
15332011-10-29 Eli Zaretskii <eliz@gnu.org>
1534
1535 Fix the `xbytecode' command.
1536 * .gdbinit (xprintbytestr): New command.
b50a28de 1537 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1538 (xbytecode): Print the byte-code string as well.
1539
4452fb80
EZ
15402011-10-29 Kim Storm <storm@cua.dk>
1541
8b058d44
EZ
1542 * alloc.c (which_symbols): New function.
1543
21b72067
AS
15442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1545
1546 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1547 line. (Bug#9903)
1548
83ed7b5c
GM
15492011-10-29 Glenn Morris <rgm@gnu.org>
1550
1551 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1552 Not clear what it was for, and it causes various bugs. (Bug#9839)
1553
5a7a728b
EZ
15542011-10-28 Eli Zaretskii <eliz@gnu.org>
1555
1556 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1557 possible random value that matches one of those tested as
1558 condition to clear the mouse face.
1559
d3d0842f
CY
15602011-10-28 Chong Yidong <cyd@gnu.org>
1561
1562 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1563
31b39d13
DN
15642011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1565
1566 * window.c (make_window): Initialize phys_cursor_on_p.
1567
9aba6043
SM
15682011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1569
1570 * lisp.h (struct Lisp_Symbol): Update comments.
1571
c20992f4
JB
15722011-10-28 Juanma Barranquero <lekktu@gmail.com>
1573
1574 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1575
db4f02f2
EZ
15762011-10-28 Eli Zaretskii <eliz@gnu.org>
1577
1578 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1579 <oslsachem@gmail.com> for helping to debug this.
1580
1581 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1582 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1583 (g_b_init_get_glyph_outline_w): New static variables.
1584 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1585 (GetGlyphOutlineW_Proc): New typedefs.
1586 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1587 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1588 New functions.
1589 (w32font_open_internal, compute_metrics):
1590 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1591 instead of calling the "wide" APIs directly.
1592
1593 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1594
1595 * w32.h (syms_of_w32font): Add prototype.
1596
87e68db4
JB
15972011-10-27 Juanma Barranquero <lekktu@gmail.com>
1598
1599 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1600 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1601 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1602 (Fmove_to_window_line): Doc fix.
1603
435c1d67
CY
16042011-10-27 Chong Yidong <cyd@gnu.org>
1605
1606 * process.c (make_process): Set gnutls_state to NULL.
1607
1608 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1609 non-NULL, regardless of GNUTLS_INITSTAGE.
1610 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1611 an error. Set process slots as soon as we allocate them.
1612
1613 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1614
9c6c6f49
CY
16152011-10-27 Chong Yidong <cyd@gnu.org>
1616
9aba6043
SM
1617 * gnutls.c (emacs_gnutls_deinit): New function.
1618 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1619 (Fgnutls_deinit, Fgnutls_boot): Use it.
1620
1621 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1622 (deactivate_process): Call emacs_gnutls_deinit.
1623
657d08d3
JB
16242011-10-27 Juanma Barranquero <lekktu@gmail.com>
1625
1626 * image.c (x_create_x_image_and_pixmap):
1627 * w32.c (sys_rename, w32_delayed_load):
1628 * w32font.c (fill_in_logfont):
1629 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1630
5430d399
JB
16312011-10-26 Juanma Barranquero <lekktu@gmail.com>
1632
1633 * w32fns.c (w32_default_color_map): New function,
1634 extracted from Fw32_default_color_map.
a7ef684b 1635 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1636
fe0055fa
PE
16372011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1638
1639 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1640
e6346438
SM
16412011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1642
1643 * keyboard.c (test_undefined): New function (bug#9751).
1644 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1645
e112cc37
ET
16462011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1647
1648 * sysdep.c (init_sys_modes): Fix the check for the controlling
1649 terminal (Bug#6649).
1650
7b5d6677
EZ
16512011-10-20 Eli Zaretskii <eliz@gnu.org>
1652
1653 * dispextern.h (struct bidi_it): New member next_en_type.
1654
1655 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1656 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1657 current character, check also for next_en_type being WEAK_EN.
1658 (bidi_resolve_weak): Don't enter the expensive loop if the current
1659 position is before next_en_pos. Record the bidi type of the first
1660 non-ET, non-BN character we find, in addition to its position.
1661 (bidi_level_of_next_char): Invalidate next_en_type when
1662 next_en_pos is over-stepped.
1663
7da0b018
PE
16642011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1667 * editfns.c: Rewrite current-time-zone so that it invokes
1668 the equivalent of (format-time-string "%Z") to get the time zone name.
1669 This fixes a bug when the time zone name contains characters that
1670 need converting from the system time locale to Emacs internal format.
1671 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1672 that patch fixed format-time-string to do the conversion, but
1673 I forgot to fix current-time-zone.
1674 (format_time_string): New function, containing most of
1675 what Fformat_time_string used to contain.
1676 (Fformat_time_string): Rewrite in terms of format_time_string.
1677 This doesn't change this function's behavior.
1678 (current-time-zone): Rewrite to use format_time_string.
1679 This fixes the bug reported by Michael Schierl in
1680 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1681 Jason Rumney's 2007-06-07 change worked around this bug, but
1682 didn't fix it.
1683 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1684
8547b010
EZ
16852011-10-19 Eli Zaretskii <eliz@gnu.org>
1686
1687 * xdisp.c (start_display): If the character at POS is displayed
1688 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1689 (try_window_reusing_current_matrix): If a line ends in a display
1690 vector or the next line starts in a display vector, continue
1691 redrawing the window even though the character position of
1692 start_row was reached.
8547b010
EZ
1693 (Bug#9771, part 2)
1694
4e948d15
CY
16952011-10-18 Chong Yidong <cyd@gnu.org>
1696
1697 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1698 with nobreak-char-display too.
1699
4787455f
EZ
17002011-10-18 Eli Zaretskii <eliz@gnu.org>
1701
1702 Fix part 3 of bug#9771.
1703 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1704 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1705 non-neutral characters if the current character is a paragraph
1706 separator (a.k.a. Newline). This avoids running the same
1707 expensive loop twice, once when we consume the preceding newline
1708 and the other time when the line actually needs to be displayed.
1709 Avoid the loop when we see neutrals on the base embedding level
1710 following a character whose directionality is the same as the
1711 paragraph's. This avoids running the expensive loop when a line
1712 ends in a long sequence of neutrals, like control characters.
1713 Add assertion against STRONG_AL type. Slightly rearrange code
1714 that determines the type of a neutral given the first non-neutral
1715 that follows it.
1716 (bidi_level_of_next_char): Set next_en_pos to zero when
1717 invalidating its info.
1718
2c91f553
EZ
17192011-10-17 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (push_display_prop): Determine whether to record string
1722 or buffer position by IT->string, not by IT->method. Allow
1723 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1724 (move_it_vertically_backward): Don't look for character position
1725 immediately after the newline when in a continuation line.
1726 (Bug#9771, part 1)
2c91f553 1727
c7b08b0d
MR
17282011-10-15 Martin Rudalics <rudalics@gmx.at>
1729
1730 * window.c (coordinates_in_window): Rewrite and delabelize
1731 vertical border check. (Bug#5357) (Bug#9618)
1732
6b02f655
SM
17332011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1734
1735 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1736 errors in XSetWindowBorder (bug#9310).
1737
81d40c92
DA
17382011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1739
1740 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1741 avoid crash when xmalloc overrun checking is enabled.
1742
d4172c3b
EZ
17432011-10-13 Eli Zaretskii <eliz@gnu.org>
1744
1745 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1746 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1747 cursor motion with <left> and <right> arrow keys.
1748
1749 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1750 some callers set that themselves.
1751
b00eea75
EZ
17522011-10-12 Eli Zaretskii <eliz@gnu.org>
1753
1754 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1755 display string and the previous row comes from the same string and
1756 is empty. (Bug#9739) (Bug#9738)
1757
8fe012c4
SM
17582011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1759
1760 * doc.c (get_doc_string): Encode file name (bug#9735).
1761
0074aef2
EZ
17622011-10-12 Eli Zaretskii <eliz@gnu.org>
1763
79beb178
EZ
1764 * bidi.c (bidi_level_of_next_char):
1765 * xdisp.c (get_visually_first_element): Remove old incorrect
1766 comments regarding the Unicode Line Separator character.
1767
0074aef2
EZ
1768 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1769
6e4b3fbe
DA
17702011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1771
1772 * alloc.c (Fgc_status): Do not access beyond zombies array
1773 boundary if nzombies > MAX_ZOMBIES.
1774 * alloc.c (dump_zombies): Add missing format specifier.
1775
0324f3af
PE
17762011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1777
b5525cac
PE
1778 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1779 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1780
0324f3af
PE
1781 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1782 Some packages use them to denote characters with modifiers.
1783
e9b5f888
AS
17842011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1785
1786 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1787 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1788 matching a pp-number. Rename parameter var to var1.
1789
127827c0
SM
17902011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1791
1792 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1793
c8fd3bd0
GM
17942011-10-08 Glenn Morris <rgm@gnu.org>
1795
1796 * callint.c (Fcall_interactively): Give a more explicit error for the
1797 'c' case with a non-character input. (Bug#8479)
1798
352ec8ff
EZ
17992011-10-08 Eli Zaretskii <eliz@gnu.org>
1800
03669ccb
EZ
1801 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1802 lines.
7061c986
EZ
1803 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1804 lines that are hscrolled on the left.
03669ccb 1805
352ec8ff
EZ
1806 * dispnew.c (buffer_posn_from_coords): Account for a possible
1807 presence of header-line. (Bug#4426)
1808
a66cfb1c
SM
18092011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1810
6b02f655
SM
1811 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1812 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1813
7c5ee88e
PE
18142011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1815
1816 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1817 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1818 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1819 this makes Emacs dump core during garbage collection on rare
1820 occasions. sizeof is obviously inferior to offsetof here, so
1821 stick with offsetof.
1822 (GC_POINTER_ALIGNMENT): New macro.
1823 (mark_memory): Omit 3rd (offset) arg; caller changed.
1824 Don't assume EMACS_INT alignment is the same as pointer alignment.
1825
df1bbe5b
SM
18262011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1827
1828 * keyboard.c (read_key_sequence_remapped): New var.
1829 (read_key_sequence): Compute remapping in the right buffer.
1830 (command_loop_1): Use read_key_sequence's remapping directly.
1831
51553db6
SM
18322011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1833
32c1fffd
SM
1834 * dired.c (file_name_completion): Don't expand file name.
1835 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1836 before checking file name handler.
1837
51553db6
SM
1838 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1839 they've been requested explicitly (bug#9591).
1840
b6bd1599 18412011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1842
1843 * keymap.c (Fsingle_key_description): Use make_specified_string
1844 instead of build_string to build string from push_key_description.
1845 (Bug#5193)
1846
f701dc2a
PE
18472011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1848
4222c55d
PE
1849 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1850 This fixes a Y2038 bug on 64-bit hosts.
1851 * buffer.c (reset_buffer):
1852 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1853 (Fclear_buffer_auto_save_failure):
1854 Use 0, not -1, to represent an unset failure time, since time_t
1855 might not be signed.
1856
f701dc2a
PE
1857 Remove dependency on glibc malloc internals.
1858 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1859 Move back here from lisp.h, but with their new implementations.
1860 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1861 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1862 * charset.c (charset_table_init): New static var.
1863 (syms_of_charset): Use it instead of xmalloc. This removes a
1864 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1865 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1866 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1867 Move back to alloc.c.
1868 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1869 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1870
9ceebf39
JD
18712011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1872
1873 * nsterm.m (windowDidResize): Call x_set_window_size only when
1874 ns_in_resize is true. Otherwise set pixelwidth/height and
1875 call change_frame_size (Bug#9628).
1876
cb993c58
PE
18772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1878
3930c88b
PE
1879 Port --enable-checking=all to Fedora 14 x86-64.
1880 * charset.c (syms_of_charset): Also account for glibc malloc's
1881 internal overhead when calculating the initial malloc maximum.
1882
cb993c58
PE
1883 Port --enable-checking=all to Fedora 14 x86.
1884 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1885 Move to lisp.h.
1886 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1887 (overrun_check_realloc, overrun_check_free):
1888 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1889 That way, xmalloc returns a properly-aligned pointer even if
1890 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1891 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1892 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1893 into account when calculating the initial malloc maximum.
1894 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1895 Move here from alloc.c, so that charset.c can use it too.
1896 Properly align; the old code wasn't right for common 32-bit hosts
1897 when configured with --enable-checking=all.
1898 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1899 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1900
31bed486
EZ
19012011-09-29 Eli Zaretskii <eliz@gnu.org>
1902
04c70788 1903 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1904 use EDOM.
1905
fbcaa2f3
EZ
19062011-09-28 Eli Zaretskii <eliz@gnu.org>
1907
1908 * xdisp.c (compute_display_string_end): If there's no display
1909 string at CHARPOS, return -1.
1910
1911 * bidi.c (bidi_fetch_char): When compute_display_string_end
1912 returns a negative value, treat the character as a normal
1913 character not covered by a display string. (Bug#9624)
1914
a239d4e9
JB
19152011-09-28 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * lread.c (Fread_from_string): Fix typo in docstring.
1918
88652fd5
EZ
19192011-09-27 Eli Zaretskii <eliz@gnu.org>
1920
1921 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1922 newline, reseat the iterator instead of bidi-iterating there one
1923 character at a time. (Bug#9610)
32c1fffd
SM
1924 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1925 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1926
ed497dd4
AS
19272011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1928
1929 * lread.c (readevalloop): Use correct code for NBSP.
1930 (read1): Likewise. (Bug#9608)
1931
b2bf61aa
MA
19322011-09-25 Michael Albinus <michael.albinus@gmx.de>
1933
1934 * dbusbind.c (Fdbus_register_signal): When service is not
1935 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1936
32bbb17c
GM
19372011-09-25 Glenn Morris <rgm@gnu.org>
1938
1939 * buffer.c (truncate-lines): Doc fix.
1940
94e0933e
CY
19412011-09-24 Chong Yidong <cyd@stupidchicken.com>
1942
1943 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1944 (Fset_window_next_buffers): Doc fix.
1945
cddde921
GM
19462011-09-24 Glenn Morris <rgm@gnu.org>
1947
1948 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1949
1260aef1
PE
19502011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1951
25b4bfa0
PE
1952 Fix minor problems found by static checking.
1953 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1954 * indent.c (Fvertical_motion): Fix == vs = typo.
1955
e3cbd34b
EZ
19562011-09-24 Eli Zaretskii <eliz@gnu.org>
1957
a66cfb1c
SM
1958 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1959 Default value is now t. Doc fix.
6bf7006f 1960
e3cbd34b 1961 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1962 logic when moving up, not only when moving down. Fix the
e3cbd34b 1963 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1964 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1965
1966 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1967 CHARPOS is covered by a display string which includes newlines.
1968 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1969 is covered by a display string with embedded newlines.
1970
a3de0cbd
MA
19712011-09-24 Michael Albinus <michael.albinus@gmx.de>
1972
1973 * dbusbind.c (Fdbus_register_signal): Add match rule to
1974 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1975 (Fdbus_register_method, Vdbus_registered_objects_table):
1976 Fix docstring.
a3de0cbd 1977
b260039d
JM
19782011-09-24 Jim Meyering <meyering@redhat.com>
1979
32c1fffd 1980 do not ignore write error for any output size
b260039d
JM
1981 The previous change was incomplete.
1982 While it makes emacs --batch detect the vast majority of stdout
1983 write failures, errors were still ignored whenever the output size is
1984 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1985 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1986 && echo FAIL: ignored write error
1987 FAIL: ignored write error
1988 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1989 && echo FAIL: ignored write error
1990 FAIL: ignored write error
1991 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1992
8eca8a7c
AS
19932011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1994
1995 * emacs.c (Fkill_emacs): In noninteractive mode exit
1996 non-successfully if a write error occurred on stdout. (Bug#9574)
1997
3341db62
EZ
19982011-09-21 Eli Zaretskii <eliz@gnu.org>
1999
2000 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2001 the xassert test.
2002
2003 * dispextern.h (struct it): Update the comment documenting what
2004 can it->OBJECT be.
2005
8c203dbf
EZ
20062011-09-20 Eli Zaretskii <eliz@gnu.org>
2007
2008 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2009 a display string, extend search for cursor position to end of row.
2010 (find_row_edges): If the row ends in a newline from a display
2011 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2012 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2013 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2014 non-empty line. Fixes confusing cursor motion with arrow keys at
2015 the beginning of a line that starts with whitespace.
8c203dbf 2016
a4824228
LMI
20172011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2018
2019 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2020 (bug#9493).
2021
33ed493b
CY
20222011-09-18 Chong Yidong <cyd@stupidchicken.com>
2023
2024 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2025 boolean (Bug#9154).
2026
56cd55c8
EZ
20272011-09-18 Eli Zaretskii <eliz@gnu.org>
2028
2029 * xdisp.c (display_line): Record maximum and minimum buffer
2030 positions even if no glyphs were produced (e.g., by a zero-width
2031 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2032 buffer positions that will be removed from the glyph row because
2033 they don't fit.
c02dcedf
EZ
2034 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2035 column is beyond frame width: don't subtract 1 "pixel" when
2036 computing width of the stretch.
3e62b7e0
EZ
2037 (reseat_at_next_visible_line_start): Undo the change made on
2038 2011-09-17 that saved paragraph information and restored it after
2039 the call to `reseat'. (Bug#9545)
56cd55c8 2040
5ed99d36 20412011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2042
2043 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2044 and turn window cursor on if cleared (Bug#9415).
2045
5ed99d36 20462011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2047
2048 * search.c (boyer_moore): Take unibyte characters from pattern
2049 literally. (Bug#9458)
2050
9bade7b2
EZ
20512011-09-18 Eli Zaretskii <eliz@gnu.org>
2052
2053 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2054
e5e9d610
PE
20552011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2056
87e4427a
PE
2057 Fix minor problem found by static checking.
2058 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2059 initialized, to pacify gcc -Wuninitialized.
2060
e5e9d610
PE
2061 * fileio.c: Report proper errno when syscall falls.
2062 (Finsert_file_contents): Save and restore errno,
2063 so that report_file_error outputs the correct diagnostic.
2064 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2065
a1674f0b
EZ
20662011-09-18 Eli Zaretskii <eliz@gnu.org>
2067
2068 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2069
fbfb6dd4
EZ
20702011-09-17 Eli Zaretskii <eliz@gnu.org>
2071
2072 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2073 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2074
bb187662
EZ
20752011-09-17 Eli Zaretskii <eliz@gnu.org>
2076
1137e8b8 2077 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2078 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2079
2080 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2081 (bidi_find_paragraph_start): Search back for paragraph beginning
2082 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2083 (bidi_move_to_visually_next): Only trigger paragraph-related
2084 computations when the last character is a newline or at EOB, not
2085 just any NEUTRAL_B. (Bug#9470)
2086
bb187662
EZ
2087 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2088 truncated lines if point is covered by a display string. (Bug#9524)
2089
2e621251
PE
20902011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2091
2092 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2093 (cons_to_x_long): New function.
2094 (lisp_data_to_selection_data): Use it. Correct the test for
2095 short-versus-long data; it was negated. Break out of vector
2096 loop, for efficiency, when a long datum is discovered.
2097
91a15bc6
SM
20982011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2099
2100 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2101
b41c3a35
EZ
21022011-09-16 Eli Zaretskii <eliz@gnu.org>
2103
2104 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2105 GCC PR/17406) by declaring this function with external scope.
2106
7812ba2d
PE
21072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2110 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2111
cf7edc2a
AS
21122011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * editfns.c (Fformat): Correctly handle text properties on "%%".
2115
bd01620e
EZ
21162011-09-15 Eli Zaretskii <eliz@gnu.org>
2117
2118 * xterm.c (x_draw_composite_glyph_string_foreground):
2119 * w32term.c (x_draw_composite_glyph_string_foreground):
2120 * term.c (encode_terminal_code):
2121 * composite.c (composition_update_it, get_composition_id):
2122 * xdisp.c (get_next_display_element)
2123 (fill_composite_glyph_string): Add comments about special meaning
2124 of TAB characters in a composition.
2125
a02719a3
PE
21262011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2127
2128 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2129 This occurs when processing a multibyte format.
2130 Problem reported by Wolfgang Jenker.
a02719a3 2131
72589a3c
JB
21322011-09-15 Johan Bockgård <bojohan@gnu.org>
2133
2134 * xdisp.c (try_cursor_movement): Only check for exact match if
2135 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2136
1c14176c
PE
21372011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 Remove unused external symbols.
2140 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2141 * xdisp.c (calc_pixel_width_or_height): Now static.
2142 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2143 * indent.c (check_display_width):
2144 * w32term.c: Fix comment to match code.
2145 * xterm.c, xterm.h (x_catching_errors): Remove.
2146
d2eea5b5
PE
21472011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 * xselect.c: Use signed conversions more consistently (Bug#9498).
2150 (selection_data_to_lisp_data): Assume incoming selection data are
2151 signed integers, not unsigned. This is to be consistent with
2152 outgoing selection data, which was modified to use signed integers
2153 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2154 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2155 expects long, not unsigned long.
2156
46888499
EZ
21572011-09-14 Eli Zaretskii <eliz@gnu.org>
2158
2159 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2160 computation of loop end. Reported by Johan Bockgård
2161 <bojohan@gnu.org>.
2162
ef8ef9fb
CY
21632011-09-13 Chong Yidong <cyd@stupidchicken.com>
2164
2165 * frame.c (Fother_visible_frames_p): Function deleted.
2166
fa819fed
EZ
21672011-09-12 Eli Zaretskii <eliz@gnu.org>
2168
2169 * indent.c (compute_motion): Process display vector front to back
2170 rather than the other way around. (Bug#2496)
2171
2ba8e008
SM
21722011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2173
2174 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2175
20f53c69
CY
21762011-09-11 Chong Yidong <cyd@stupidchicken.com>
2177
2178 * minibuf.c (Fread_from_minibuffer): Doc fix.
2179
d562d7a4
EZ
21802011-09-11 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2183 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2184
1c4d7f3d
LMI
21852011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2186
2187 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2188 value for non-existent files.
2189
b885bf36
EZ
21902011-09-11 Eli Zaretskii <eliz@gnu.org>
2191
2192 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2193 set its "size" to -1. This will set the modtime_size field of
2194 the corresponding buffer to -1, which is what
2195 verify-visited-file-modtime expects for files that do not exist.
2196 (Bug#9139)
2197
6612f0bf
PE
21982011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2201 here ...
2202 * lisp.h: ... from here. push_key_description is no longer
2203 defined in keyboard.c, so its declaration should not be in
2204 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2205 logically belongs with push_key_description.
2206
dfb3f755
PE
22072011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 * buffer.h: Include <sys/types.h> instead of <time.h>.
2210 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2211 Problem reported by Herbert J. Skuhra.
2212
3134906c
LMI
22132011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2214
2215 * xml.c (parse_region): Make the parsing work for
2216 non-comment-starting XML files again (bug#9144).
2217
8d903f4e
AS
22182011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2219
2220 * image.c (gif_load): Fix calculation of bottom and right corner.
2221 (Bug#9468)
2222
80ad64f4
EZ
22232011-09-10 Eli Zaretskii <eliz@gnu.org>
2224
2225 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2226 redisplay in small windows.
2227
208a048d
EZ
22282011-09-09 Eli Zaretskii <eliz@gnu.org>
2229
2230 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2231
9b1c252e
MR
22322011-09-08 Martin Rudalics <rudalics@gmx.at>
2233
2234 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2235 Operate on live windows only.
2236
2949f33b
JB
22372011-09-08 Juanma Barranquero <lekktu@gmail.com>
2238
2239 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2240
e08dcafd
EZ
22412011-09-07 Eli Zaretskii <eliz@gnu.org>
2242
2243 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2244 only under bidi iteration.
2245
115b96bd
JD
22462011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2247
2248 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2249
c8199d0f
PE
22502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2251
2252 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2253 Without this fix, the command to link temacs failed due to an
2254 undefined symbol __builtin_isnan. This is because
2255 /usr/include/iso/math_c99.h #defines isnan(x) to
2256 __builtin_isnan(x), but the bundled gcc, which identifies itself
2257 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2258 a __builtin_isnan.
2259 * floatfns.c (isnan): #undef, and then #define to a clone of
2260 what's in data.c.
2261 (Fisnan): Always define, since it's always available now.
2262 (syms_of_floatfns): Always define isnan at the Lisp level.
2263
e39b275c 22642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2265
2266 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2267
b2db44d9 22682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2269
f4af5137 2270 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2271 The previous code assumed that file offsets (off_t values) fit in
2272 EMACS_INT variables, which is not true on typical 32-bit hosts.
2273 The code messed up by falsely reporting buffer overflow in cases
2274 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2275 when "big" contains more than 2**29 bytes, even though this
2276 inserts just one byte and does not overflow the buffer.
2277 (Finsert_file_contents): Store file offsets as off_t
2278 values, not as EMACS_INT values. Check for overflow when
2279 converting between EMACS_INT and off_t. When checking for
2280 buffer overflow or for overlap, take the offsets into account.
2281 Don't use EMACS_INT for small values where int suffices.
2282 When checking for overlap, fix a typo: ZV was used where
2283 ZV_BYTE was intended.
2284 (Fwrite_region): Don't assume off_t fits into 'long'.
2285 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2286
ecfc0a49
MA
22872011-09-05 Michael Albinus <michael.albinus@gmx.de>
2288
2289 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2290
6511acf2 22912011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2292
0999621a 2293 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2294
2295 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2296 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2297 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2298 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2299 (modify_event_symbol): Do not assume that the length of
2300 name_alist_or_stem is safe to alloca and fits in int.
2301 (Fexecute_extended_command): Likewise for function name and binding.
2302 (Frecursion_depth): Wrap around reliably on integer overflow.
2303 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2304 since some callers pass EMACS_INT values.
2305 (Fsingle_key_description): Don't crash if symbol name contains more
2306 than MAX_ALLOCA bytes.
2307 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2308 (get_minibuffer): Arg is now EMACS_INT, not int.
2309 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2310 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2311 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2312
2be7d702
PE
2313 * dbusbind.c (signature_cat): New function.
2314 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2315 Do not overrun buffer; instead, report string overflow.
2316
9d1df220
PE
2317 * dispnew.c (add_window_display_history): Don't overrun buffer.
2318 Truncate instead; this is OK since it's just a log.
2319
33ef5c64
PE
2320 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2321 even if the time zone offset is outlandishly large.
2322 Don't mishandle offset == INT_MIN.
2323
66c6fdd5
PE
2324 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2325 when creating daemon; the previous buffer-overflow check was incorrect.
2326
d749b01b
PE
2327 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2328 which has the guts of the old verror function.
2329
b5cd1905
PE
2330 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2331 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2332
6e1a67fb
PE
2333 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2334 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2335 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2336 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2337 length of string rather than counting it via multiple sprintfs;
2338 that's simpler and more reliable.
c21721cc
PE
2339 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2340 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2341 sprintf, in case result does not fit in int.
2342
c57b67fc
PE
2343 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2344 (fontset_from_font): Print it.
2345
8a401434
PE
2346 * frame.c (tty_frame_count): Now printmax_t, not int.
2347 (make_terminal_frame, set_term_frame_name): Print it.
2348 (x_report_frame_params): In X, window IDs are unsigned long,
2349 not signed long, so print them as unsigned.
2350 (validate_x_resource_name): Check for implausibly long names,
2351 and don't assume name length fits in 'int'.
2352 (x_get_resource_string): Don't blindly alloca invocation name;
2353 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2354 not fit in int.
2355
6e1a67fb
PE
2356 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2357 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2358 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2359
0df02bf3
PE
2360 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2361 Use esprintf, not sprintf, in case result does not fit in int.
2362
48e30793
PE
2363 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2364 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2365 it as a large positive number.
2366 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2367 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2368
a66ff6d8
PE
2369 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2370 in case result does not fit in int.
2371
aca216ff
PE
2372 * print.c (float_to_string): Detect width overflow more reliably.
2373 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2374 buffer overrun. Don't assume list length fits in 'int'. Treat
2375 print length of 0 as 0, not as infinity; to be consistent with other
2376 uses of print length in this function. Don't overflow print length
2377 index. Don't assume hash table size fits in 'long', or that
2378 vectorlike size fits in 'unsigned long'.
2379
31c286f7
PE
2380 * process.c (make_process): Use printmax_t, not int, to format
2381 process-name gensyms.
2382
55e5faa1
PE
2383 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2384
80f2e268
PE
2385 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2386 to avoid potential buffer overrun.
2387
670741ab
PE
2388 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2389 if X resource line is longer than 512 bytes.
2390
b7163a50
PE
2391 * xfns.c (x_window): Make sprintf buffer a bit bigger
2392 to avoid potential buffer overrun.
2393
ae58ff1f
PE
2394 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2395
c43c8a6a
PE
2396 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2397
3f8236f4
PE
23982011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2399
53e9fe90 2400 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2401 Without these, Emacs silently mishandles large integers sometimes.
2402 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2403 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2404
6511acf2
PE
2405 * xdisp.c (try_window_id): Check Emacs fixnum range before
2406 converting to 'int'.
806add1d 2407
6511acf2 2408 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2409 Check that an Emacs fixnum is in range before assigning it to 'int'.
2410 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2411 values converted from Emacs fixnums.
2412 (Frecenter): Don't wrap around a line count if it is out of 'int'
2413 range; instead, treat it as an extreme value.
2414 (Fset_window_configuration, compare_window_configurations):
2415 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2416
6511acf2
PE
2417 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2418 that can exceed INT_MAX. Check that EMACS_INT value is in range
2419 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2420 (match_limit): Don't assume that a fixnum can fit in 'int'.
2421
6511acf2 2422 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2423 exceed INT_MAX.
2424
6511acf2 2425 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2426 (Fvertical_motion): Don't wrap around LINES values that don't fit
2427 in 'int'. Instead, treat them as extreme values. This is good
2428 enough for windows, which can't have more than INT_MAX lines anyway.
2429
fcb901a7
LMI
24302011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2431
0f2f6b6d
LMI
2432 * Require libxml/parser.h to avoid compilation warning.
2433
fcb901a7
LMI
2434 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2435
2436 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2437 since this reportedly can destroy thread storage.
2438
6e20a0d4
CY
24392011-08-30 Chong Yidong <cyd@stupidchicken.com>
2440
2441 * syntax.c (find_defun_start): Update all cache variables if
2442 exiting early (Bug#9401).
2443
148ae00e
EZ
24442011-08-30 Eli Zaretskii <eliz@gnu.org>
2445
f6cfbd8f
EZ
2446 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2447
148ae00e
EZ
2448 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2449 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2450 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2451
2452 * term.c (tty_append_glyph): New function.
2453 (produce_stretch_glyph): Static function and its prototype deleted.
2454
a66cfb1c
SM
2455 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2456 Add prototypes.
148ae00e 2457
c4a07a4c
PE
24582011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2461 when checking :margin (Bug#9390).
2462 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2463 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2464 so that the name doesn't mislead. All uses changed.
2465
6bc8cd65
JB
24662011-08-28 Johan Bockgård <bojohan@gnu.org>
2467
2468 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2469 set_tty_hooks.
2470
dca4927e
EZ
24712011-08-27 Eli Zaretskii <eliz@gnu.org>
2472
2473 * xdisp.c (move_it_to): Don't bail out early when reaching
2474 position beyond to_charpos, if we are scanning backwards.
2475 (move_it_vertically_backward): When DY == 0, make sure we get to
2476 the first character in the line after the newline.
2477
f2cad773
PE
24782011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2479
2480 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2481 (ccl_driver): Do not generate an out-of-range pointer.
2482 (Fccl_execute_on_string): Remove unnecessary check for
2483 integer overflow, noted by Stefan Monnier in
2484 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2485 Remove a FIXME that didn't need fixing.
2486 Simplify the newly-introduced buffer reallocation code.
2487
0cae2cdb
JB
24882011-08-27 Juanma Barranquero <lekktu@gmail.com>
2489
2490 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2491
5fc295a4 24922011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2493
70c60eb2 2494 Integer and memory overflow issues (Bug#9196).
726e0ab1 2495
d31850da
PE
2496 * doc.c (get_doc_string): Rework so that
2497 get_doc_string_buffer_size is the actual buffer size, rather than
2498 being 1 less than the actual buffer size; this makes xpalloc more
2499 convenient.
2500
a69fbedb
PE
2501 * image.c (x_allocate_bitmap_record, cache_image):
2502 * xselect.c (Fx_register_dnd_atom):
2503 Simplify previous changes by using xpalloc.
2504
fe5c5d37
PE
2505 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2506 since either will do and ptrdiff_t is convenient with xpalloc.
2507
0065d054
PE
2508 * charset.c (charset_table_size)
2509 (struct charset_sort_data.priority): Now ptrdiff_t.
2510 (charset_compare): Don't overflow if priorities differ greatly.
2511 (Fsort_charsets): Don't assume list length fits in int.
2512 Check for size-calculation overflow when allocating sort data.
2513 (syms_of_charset): Allocate an initial charset table that is
2514 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2515
2516 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2517
2518 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2519 The actual value is always <= INT_MAX, and leaving it unsigned made
2520 overflow checking harder.
2521
2522 * dispextern.h (struct glyph_matrix.rows_allocated)
2523 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2524 with xpalloc. The values are still always <= INT_MAX.
2525
2526 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2527
2528 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2529 (SAFE_NALLOCA): New macro.
2530
2531 * region-cache.c (struct boundary.pos, find_cache_boundary)
2532 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2533 (set_cache_region, invalidate_region_cache)
2534 (revalidate_region_cache, know_region_cache, region_cache_forward)
2535 (region_cache_backward, pp_cache):
2536 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2537 so that ptrdiff_t * can be passed to xpalloc.
2538 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2539 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2540 (pp_cache): Don't assume cache_len fits in int.
2541 * region-cache.h: Adjust extern decls to match.
2542
2543 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2544 EMACS_INT, since either will do, for xpalloc.
2545
2546 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2547 (xnmalloc, xnrealloc, xpalloc): New functions.
2548
726e0ab1
PE
2549 * bidi.c (bidi_shelve_header_size): New constant.
2550 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2551 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2552
51f30bc5 2553 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2554 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2555 (overlay_strings):
2556 Don't update size of array until after memory allocation succeeds,
2557 because xmalloc/xrealloc may not return.
0065d054
PE
2558 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2559 now that we have proper integer overflow checking.
2560 (record_overlay_string, overlay_strings): Catch overflows when
2561 calculating size of overlay_str_buf.
726e0ab1 2562
0065d054
PE
2563 * callproc.c (Fcall_process): Check for size overflow when
2564 calculating size of args2.
2565 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2566 Normally we prefer signed values, but sticking with ptrdiff_t would
2567 require adding more-complicated checks.
726e0ab1
PE
2568
2569 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2570 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2571 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2572 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2573
2574 * character.c (Fstring): Check for size-calculation overflow.
2575
2576 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2577 unnecessary integer overflow. Check for size overflow.
2578 (encode_coding_object): Don't update size until xmalloc succeeds.
2579
2580 * composite.c (get_composition_id): Check for overflow in glyph
2581 length calculations.
2582
2583 Integer and memory overflow fixes for display code.
2584 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2585 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2586 (scrolling_window): Check for overflow in size calculations.
2587 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2588 Don't assume glyph table len fits in int.
2589 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2590 (row_table_size): Now ptrdiff_t, not int.
2591 (scrolling_window): Avoid overflow in size calculations.
2592 Don't update size until allocation succeeds.
2593 * fns.c (concat): Check for overflow in size calculations.
2594 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2595 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2596 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2597
2598 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2599 (get_doc_string): Check for size calculation overflow.
2600 Don't update size until allocation succeeds.
2601 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2602 EMACS_INT, where ptrdiff_t will do.
2603 (Fsubstitute_command_keys): Check for string overflow.
2604
2605 * editfns.c (set_time_zone_rule): Don't assume environment length
2606 fits in int.
2607 (message_length): Now ptrdiff_t, not int.
2608 (Fmessage_box): Don't update size until allocation succeeds.
2609 Don't assume message length fits in int.
2610 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2611
0065d054
PE
2612 * emacs.c (main): Do not reallocate argv, since there is a null at
2613 the end that can be overwritten, and this way there's no need to
2614 worry about size-calculation overflow.
2615 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2616
2617 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2618 alloc succeeds.
2619 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2620
2621 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2622 (x_set_scroll_bar_width, x_figure_window_size):
2623 Check for integer overflow.
2624 (x_set_alpha): Do not assume XINT fits in int.
2625
2626 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2627 This is for the members text_lines, text_cols, total_lines, total_cols,
2628 where the system imposes an 'int' limit.
2629
2630 * fringe.c (Fdefine_fringe_bitmap):
2631 Don't update size until alloc works.
2632
2633 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2634 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2635
2636 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2637 Check for size-calculation overflow.
2638 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2639 do, as we prefer signed integers.
2640 (id_to_widget.max_size, id_to_widget.used)
2641 (xg_store_widget_in_map, xg_remove_widget_from_map)
2642 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2643 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2644 Use and return ptrdiff_t, not int.
2645 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2646 * gtkutil.h: Change prototypes to match the above.
2647
2648 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2649 are duplicate now that they've been promoted to lisp.h.
2650 (x_allocate_bitmap_record, x_alloc_image_color)
2651 (make_image_cache, cache_image, xpm_load):
2652 Don't update size until alloc is done.
2653 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2654 (x_detect_edges):
3256efce 2655 Check for size calculation overflow.
726e0ab1
PE
2656 (ct_colors_allocated_max): New constant.
2657 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2658 overflow.
3256efce 2659
726e0ab1
PE
2660 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2661 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2662 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2663 Use ptrdiff_t, not int, to count maps.
2664 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2665 calculations. Don't update size until allocation succeeds.
2666 Redo calculations to avoid overflow.
726e0ab1
PE
2667 * keyboard.h: Change prototypes to match the above.
2668
2669 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2670 to count maps.
2671 (current_minor_maps): Check for size calculation overflow.
2672 * keymap.h: Change prototypes to match the above.
2673
2674 * lread.c (read1, init_obarray): Don't update size until alloc done.
2675
2676 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2677 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2678
726e0ab1
PE
2679 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2680 Now ptrdiff_t, not int.
2681 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2682 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2683
2684 * process.c (Fnetwork_interface_list): Check for overflow
2685 in size calculation.
2686
2687 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2688
2689 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2690 overflow. Don't bother calling xmalloc when xrealloc will do.
2691
2692 * search.c (Freplace_match): Check for size calculation overflow.
2693 (Fset_match_data): Don't assume list lengths fit in 'int'.
2694
2695 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2696 for command line length. Do not attempt to address one before the
2697 beginning of an array, as that's not portable.
2698
2699 * term.c (max_frame_lines): Remove; unused.
2700 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2701 not int.
2702 (encode_terminal_code, calculate_costs): Check for size
2703 calculation overflow.
2704 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2705 table lengths and related sizes. Don't update size until alloc
2706 done. Redo calculations to avoid overflow.
2707 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2708
2709 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2710 subtracting pointers.
2711 (gobble_line): Check for overflow more carefully. Don't update size
2712 until alloc done.
2713
2714 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2715 Don't update size until alloc done.
2716 Redo size calculations to avoid overflow.
2717 Check for size calculation overflow.
0065d054 2718 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2719
2720 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2721 Use ptrdiff_t, not int, for sizes.
2722 (store_mode_line_noprop_char): Don't update size until alloc done.
2723
0065d054
PE
2724 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2725 Use ptrdiff_t, not int, for sizes.
2726 (Finternal_make_lisp_face, cache_face):
2727 Check for size calculation overflow.
2728 (cache_face): Treat size calculation overflows as if they were
2729 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2730
2731 * xfns.c (x_encode_text, x_set_name_internal)
2732 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2733 sizes, since they can exceed INT_MAX in size. Check for size
2734 calculation overflow.
2735
0065d054
PE
2736 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2737 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2738 Don't update size until alloc done.
2739
0065d054 2740 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2741 as sprintf is limited to int lengths.
1d526e2f 2742
252c5ee1
PE
2743 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2744 (X_LONG_MIN): New macros.
864d7ce7
PE
2745 Use them to make the following changes clearer.
2746 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2747 This change doesn't affect the value now, but it may help remind
2748 future maintainers not to raise the value too much later.
2749 (SELECTION_QUANTUM): Remove, replacing with ...
2750 (selection_quantum): ... new function, which avoids overflow.
2751 All uses changed.
2752 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2753 assumption that selection length fits in 'int'.
2754 (x_reply_selection_request, x_handle_selection_request)
2755 (x_get_window_property, receive_incremental_selection)
2756 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2757 (lisp_data_to_selection_data, clean_local_selection_data):
2758 Use ptrdiff_t, not int, to record length of selection.
2759 (x_reply_selection_request, x_get_window_property)
2760 (receive_incremental_selection, x_property_data_to_lisp):
2761 Redo calculations to avoid overflow.
2762 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2763 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2764 something.
2765 (x_get_window_property, receive_incremental_selection)
2766 (lisp_data_to_selection_data, x_property_data_to_lisp):
2767 Check for size-calculation overflow.
2768 (x_get_window_property, receive_incremental_selection)
2769 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2770 Don't store size until memory allocation succeeds.
2771 (x_get_window_property): Plug memory leak on memory exhaustion.
2772 Don't double-block input; malloc is safe here. Don't assume 2**34
2773 - 4 fits in unsigned long. Add an xassert to check
2774 XGetWindowProperty overflow. Be more careful about overflow
2775 calculations, and distinguish size from memory overflow better.
2776 (receive_incremental_selection): When tracing, don't assume
2777 unsigned int is less than INT_MAX.
2778 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2779 harmful) conversions of unsigned short to int.
2780 (lisp_data_to_selection_data): Don't assume that integers
2781 in the range -65535 through -1 fit in an X unsigned short.
2782 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2783 result parameters unless successful. Rely on cons_to_unsigned
2784 to report problems with elements; the old code wasn't right anyway.
2785 (x_check_property_data): Check for int overflow; we cannot use
2786 a wider type due to X limits.
2787 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2788
726e0ab1 2789 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2790
0065d054
PE
2791 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2792 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2793 (x_color_cells): Don't store size until memory allocation succeeds.
2794 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2795 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2796 (x_term_init): Don't assume length fits in int (sprintf is limited
2797 to int size).
bc18e09d 2798
ebfa62c0
PE
2799 Use ptrdiff_t for composition IDs.
2800 * character.c (lisp_string_width):
2801 * composite.c (composition_table_size, n_compositions)
2802 (get_composition_id, composition_gstring_from_id):
2803 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2804 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2805 * window.c (Frecenter):
2806 Use ptrdiff_t, not int, for composition IDs.
2807 * composite.c (get_composition_id): Check for integer overflow.
2808 * composite.h: Adjust prototypes to match the above changes.
2809
d3411f89
PE
2810 Use ptrdiff_t for hash table indexes.
2811 * category.c (hash_get_category_set):
2812 * ccl.c (ccl_driver):
2813 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2814 * coding.c (coding_system_charset_list, detect_coding_system):
2815 * coding.h (struct coding_system.id):
2816 * composite.c (get_composition_id, gstring_lookup_cache):
2817 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2818 * image.c (xpm_get_color_table_h):
2819 * lisp.h (hash_lookup, hash_put):
2820 * minibuf.c (Ftest_completion):
2821 Use ptrdiff_t for hash table indexes, not int (which is too
2822 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2823 32-bit --with-wide-int hosts).
2824
e097a6fa
PE
2825 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2826 Add a FIXME comment about memory leaks.
2827 (syms_of_charset): Don't assume xmalloc returns.
2828
5637687f
PE
2829 Don't assume that stated character widths fit in int.
2830 * character.c (Fchar_width, c_string_width, lisp_string_width):
2831 * character.h (CHAR_WIDTH):
2832 * indent.c (MULTIBYTE_BYTES_WIDTH):
2833 Use sanitize_char_width to avoid undefined and/or bad behavior
2834 with outlandish widths.
a66cfb1c 2835 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2836 now that we have two such functions. All uses changed.
2837 (sanitize_char_width): New inline function.
2838
a2271ba2
PE
2839 Don't assume that tab-width fits in int.
2840 * character.h (sanitize_width): New inline function.
2841 (SANE_TAB_WIDTH): New macro.
2842 (ASCII_CHAR_WIDTH): Use it.
2843 * indent.c (sane_tab_width): Remove. All uses replaced by
2844 SANE_TAB_WIDTH (current_buffer).
2845 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2846
18c52557
PE
2847 * fileio.c: Integer overflow issues with file modes.
2848 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2849
caeeedc1
PE
2850 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2851 Remove unreachable code.
2852 (read_hex, load_charset_map_from_file): Check for integer overflow.
2853
6df6ae42 2854 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2855 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2856 (x_send_scroll_bar_event): Likewise. Check that the size does not
2857 exceed limits imposed by XClientMessageEvent, as well as the usual
2858 ptrdiff_t and size_t limits.
2859
b13995db
PE
2860 * keyboard.c: Overflow, signedness and related fixes.
2861 (make_lispy_movement): Use same integer type in forward decl
2862 that is used in the definition.
2863 (read_key_sequence, keyremap_step):
2864 Change bufsize argument back to int, undoing my 2011-03-30 change.
2865 We prefer signed types, and int is wide enough here.
2866 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2867 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2868 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2869 length, not size_t. Use ptrdiff_t for index, not int.
2870 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2871 possibility of integer overflow.
2872
13464394
PE
2873 Overflow, signedness and related fixes for images.
2874
2875 * dispextern.h (struct it.stack[0].u.image.image_id)
2876 (struct_it.image_id, struct image.id, struct image_cache.size)
2877 (struct image_cache.used, struct image_cache.ref_count):
2878 * gtkutil.c (update_frame_tool_bar):
2879 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2880 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2881 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2882 * nsmenu.m (update_frame_tool_bar):
2883 * xdisp.c (calc_pixel_width_or_height):
2884 * xfns.c (image_cache_refcount):
2885 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2886 on typical 64-bit hosts.
2887
2888 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2889 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2890 Omit unnecessary casts to int.
2891 (parse_image_spec): Check that integers fall into 'int' range
2892 when the callers expect that.
2893 (image_ascent): Redo ascent calculation to avoid int overflow.
2894 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2895 (lookup_image): Remove unnecessary tests.
2896 (xbm_image_p): Locals are now of int, not EMACS_INT,
2897 since parse_image_check makes sure they fit into int.
2898 (png_load, gif_load, svg_load_image):
2899 Prefer int to unsigned where either will do.
2900 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2901 old tiff_error_handler and tiff_warning_handler.
2902 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2903 stack buffer overflows. It uses only the features of vsnprintf
2904 that are common to both POSIX and native Microsoft.
2905 (tiff_error_handler, tiff_warning_handler): Use it.
2906 (tiff_load, gif_load, imagemagick_load_image):
2907 Don't assume :index value fits in 'int'.
2908 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2909 (imagemagick_load_image): Check that crop parameters fit into
2910 the integer types that MagickCropImage accepts. Don't assume
2911 Vimagemagick_render_type has a nonnegative value. Don't assume
2912 size_t fits in 'long'.
2913 (gs_load): Use printmax_t to print the widest integers possible.
2914 Check for integer overflow when computing image height and width.
2915
c11821d4
EZ
29162011-08-26 Eli Zaretskii <eliz@gnu.org>
2917
2918 * xdisp.c (redisplay_window): Don't force window start if point
2919 will be invisible in the resulting window. (Bug#9324)
2920
0c95fcf7
EZ
29212011-08-25 Eli Zaretskii <eliz@gnu.org>
2922
2923 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2924 the display spec is of the form `(space ...)'.
2925 (handle_display_spec): Return the value returned by
2926 handle_single_display_spec, not just 1 or zero.
2927 (handle_single_display_spec): If the display spec is of the form
2928 `(space ...)', and specifies display in the text area, return 2
2929 rather than 1.
fee65a97 2930 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2931 accurately, and prefer exact match for point under bidi.
2932 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2933
2934 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2935 into disp_prop; all users changed.
2936
2937 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2938 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2939 for the text covered by the display property.
2940
e4ed06f1
CY
29412011-08-25 Chong Yidong <cyd@stupidchicken.com>
2942
2943 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2944 Change return value to nil.
2945 (Frecord_buffer): Delete unused function.
2946
f67cdd7f
EZ
29472011-08-24 Eli Zaretskii <eliz@gnu.org>
2948
5980d4c6
EZ
2949 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2950 buffers, return left-to-right.
8610fe8b
EZ
2951 (set_cursor_from_row): Consider candidate row a win if its glyph
2952 represents a newline and point is on that newline. Fixes cursor
2953 positioning on the newline at EOL of R2L text within L2R
2954 paragraph, and vice versa.
2955 (try_cursor_movement): Check continued rows, in addition to
2956 continuation rows. Fixes unwarranted scroll when point enters a
2957 continued line of R2L text within an L2R paragraph, or vice versa.
2958 (cursor_row_p): Consider the case of point being equal to
2959 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2960 from the end of a short line to the beginning of a continued line
2961 of R2L text within L2R paragraph.
2962 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2963 composed characters.
5980d4c6 2964
f67cdd7f
EZ
2965 * bidi.c (bidi_check_type): Use xassert.
2966 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2967 members.
2968
bca633fb
EZ
29692011-08-23 Eli Zaretskii <eliz@gnu.org>
2970
2971 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2972 a character.
2973
4a5885a7
CY
29742011-08-23 Chong Yidong <cyd@stupidchicken.com>
2975
2976 * nsfont.m (ns_otf_to_script): Fix typo.
2977
0902a04e
KH
29782011-08-22 Kenichi Handa <handa@m17n.org>
2979
2980 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2981 extra slot even if the purpose is char-code-property-table.
2982
1a2e6670
EZ
29832011-08-23 Eli Zaretskii <eliz@gnu.org>
2984
8ddde651
EZ
2985 * xdisp.c (redisplay_window): When computing centering_position,
2986 account for the height of the header line. (Bug#8874)
2987
425cc014
EZ
2988 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2989 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2990 candidate is selected by the mouse, and that candidate has a
2991 composed character under the mouse.
2992
1a2e6670
EZ
2993 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2994 coordinates reported by pos-visible-in-window-p for a composed
2995 character in column zero.
2996
8b76d6f8
SM
29972011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2998
2999 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3000
dac347dd
EZ
30012011-08-22 Eli Zaretskii <eliz@gnu.org>
3002
3003 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3004 consider it a hit if to_charpos is anywhere in the range of the
3005 composed buffer positions.
3006
e013fb34
CY
30072011-08-22 Chong Yidong <cyd@stupidchicken.com>
3008
3009 * image.c (gif_load): Don't assume that each subimage has the same
3010 dimensions as the base image. Handle disposal method that is
3011 "undefined" by the gif spec (Bug#9335).
3012
bd1ba3e8
CY
30132011-08-20 Chong Yidong <cyd@stupidchicken.com>
3014
3015 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3016 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3017
54a1215b
EZ
30182011-08-19 Eli Zaretskii <eliz@gnu.org>
3019
823564e5
EZ
3020 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3021 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3022 from an Org mode buffer to a Speedbar frame.
3023
54a1215b
EZ
3024 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3025 a composition, take its buffer position from IT->cmp_it.charpos.
3026 Fixes cursor positioning at the beginning of a line that begins
3027 with a composed character.
3028
9778ebcc
EZ
30292011-08-18 Eli Zaretskii <eliz@gnu.org>
3030
0be6ee06
EZ
3031 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3032 character bidirectional type, use STRONG_L instead. Fixes crashes
3033 in a buffer produced by `describe-categories'.
3034
9778ebcc
EZ
3035 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3036 members before the level stack, so they would be saved and
3037 restored when copying iterator state. Fixes incorrect reordering
3038 around TABs covered by display properties.
3039
156bffbe
AS
30402011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3041
6b02f655 3042 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3043
72ad093b
CY
30442011-08-17 Chong Yidong <cyd@stupidchicken.com>
3045
3046 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3047 (internal_condition_case_2, internal_condition_case_n):
3048 Remove unnecessary aborts (Bug#9081).
72ad093b 3049
35774242
EZ
30502011-08-17 Eli Zaretskii <eliz@gnu.org>
3051
3052 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3053 has no `load' handler, try opening the file locally. (Bug#9311)
3054
db76dd85
KB
30552011-08-16 Ken Brown <kbrown@cornell.edu>
3056
3057 * gmalloc.c: Expand comment.
3058
b215eee5
EZ
30592011-08-16 Eli Zaretskii <eliz@gnu.org>
3060
3061 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3062 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3063
a4579d33
KB
30642011-08-16 Ken Brown <kbrown@cornell.edu>
3065
3066 Fix memory allocation problems in Cygwin build (Bug#9273).
3067
3068 * unexcw.c ( __malloc_initialized): Declare external variable.
3069 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3070
8b76d6f8
SM
3071 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3072 New variables.
a4579d33
KB
3073 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3074 dumped emacs.
3075 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3076 in the static heap.
3077 [CYGWIN] (special_realloc): New function.
3078 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3079 requests to realloc storage in the static heap.
3080
3ebec551
PE
30812011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * bidi.c (bidi_initialize): Remove unused local.
3084
9fd8be00
EZ
30852011-08-15 Eli Zaretskii <eliz@gnu.org>
3086
6b02f655
SM
3087 * bidimirror.h:
3088 * biditype.h: Remove file.
3089 * makefile.w32-in ($(BLD)/bidi.$(O)):
3090 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3091
3092 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3093
3094 * chartab.c: Improve commentary for the uniprop_table API.
3095
32413314
EZ
3096 * bidi.c (bidi_paragraph_init): Support zero value of
3097 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3098 (bidi_initialize): Use uniprop_table instead of including
3099 biditype.h and bidimirror.h.
32413314 3100
9fd8be00
EZ
3101 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3102 coordinates of the iterator when restoring from ppos_it.
3103 (Bug#9296)
3104
5cf2b69b
KH
31052011-08-14 Kenichi Handa <handa@m17n.org>
3106
3107 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3108 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3109
daf17d00
EZ
31102011-08-14 Eli Zaretskii <eliz@gnu.org>
3111
3112 * xdisp.c (move_it_in_display_line_to): Don't invoke
3113 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3114 ppos_it. Fixes vertical cursor motion when line beginning is
3115 covered by an image. (Bug#9296)
3116
08e3161a
JD
31172011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3118
3119 * nsterm.h (ns_run_ascript): Declare.
3120 (NSAPP_DATA2_RUNASSCRIPT): Define.
3121
3122 * nsfns.m (as_script, as_result, as_status): New static variables.
3123 (ns_run_ascript): New function.
5e617bc2 3124 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3125 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3126 the event loop. Get status from as_status (Bug#7276).
3127
3128 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3129 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3130 the event loop (Bug#7276).
3131
a3720aa2
AS
31322011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3133
3134 * gnutls.c (QCgnutls_bootprop_priority)
3135 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3136 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3137 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3138 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3139 (QCgnutls_bootprop_verify_hostname_error)
3140 (QCgnutls_bootprop_callbacks_verify): Rename from
3141 Qgnutls_bootprop_..., all uses changed.
3142
3143 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3144 uses changed.
3145
0a0d27fb
PE
31462011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3147
19d5c50c
PE
3148 * xfaces.c (Qframe_set_background_mode): Now static.
3149 * dispextern.h (Qframe_set_background_mode): Remove decl.
3150
0a0d27fb
PE
3151 * process.c (Fnetwork_interface_info): Declare local only if needed.
3152
377538cb
JD
31532011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3154
3155 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3156 (Fnetwork_interface_list): Allocate in increments of bytes instead
3157 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3158 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3159 sockaddr.
3160 (struct ifflag_def): notrailers is smart on OSX.
3161 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3162 Get hardware address with getifaddrs if available.
3163
08fff70c
EZ
31642011-08-12 Eli Zaretskii <eliz@gnu.org>
3165
3166 * xdisp.c (iterate_out_of_display_property): xassert that
3167 IT->position is set to within IT->object's boundaries. Break from
3168 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3169 when IT->position is set up wrongly due to some bug.
3170 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3171 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3172 entry. Force push_it to save on the stack the current
3173 buffer/string position, to be restored by pop_it. Fix flags in
3174 the iterator structure wrt the object coming from a display
3175 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3176 properties. (Bug#9284)
3177
7be1c708 31782011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3179
7be1c708
CY
3180 * fontset.c (fontset_get_font_group): Add proper type checks.
3181 (Bug#9172)
aac0c6e3 3182
7be1c708 31832011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3184
7be1c708
CY
3185 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3186 and LC_VERSION_MIN_MACOSX.
3187 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3188 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3189
97bb72a6
EZ
31902011-08-08 Eli Zaretskii <eliz@gnu.org>
3191
3192 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3193 no-display-properties-and-no-overlays under bidi display.
3194 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3195 properties and overlays.
97bb72a6 3196
d5617611
CY
31972011-08-08 Chong Yidong <cyd@stupidchicken.com>
3198
37e11a63
CY
3199 * editfns.c (Fset_time_zone_rule): Document relationship with the
3200 setenv function.
3201
d5617611
CY
3202 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3203 the font entity extracted from the cache (Bug#8109).
3204
58872834
CY
32052011-08-07 Chong Yidong <cyd@stupidchicken.com>
3206
3207 * composite.c (autocmp_chars): Don't reset point. That is done by
3208 restore_point_unwind (Bug#5984).
3209
75bfc667
JL
32102011-08-07 Juri Linkov <juri@jurta.org>
3211
3212 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3213 to show the arg `TIME' instead of `TIMEVAL'.
3214
d1410150
EZ
32152011-08-06 Eli Zaretskii <eliz@gnu.org>
3216
3217 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3218 display property strides EOL and includes a newline, as in
3219 longlines-mode. (Bug#9254)
75b771e4
EZ
3220 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3221 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3222
3223 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3224 is non-zero, even if the data buffer is NULL. Fixes a crash in
3225 vertical-motion with longlines-mode. (Bug#9254)
3226
35928349
EZ
32272011-08-05 Eli Zaretskii <eliz@gnu.org>
3228
ec7cc85b
EZ
3229 * bidi.c <bidi_cache_total_alloc>: Now static.
3230 (bidi_initialize): Initialize bidi_cache_total_alloc.
3231
8b76d6f8 3232 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3233 cache. (Bug#9221)
3234
3235 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3236 amount allocated this far in `bidi_cache_total_alloc'.
3237 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3238 non-zero, only free the data buffer without restoring the cache
3239 contents. All callers changed.
3240
3241 * dispextern.h (bidi_unshelve_cache): Update prototype.
3242
3243 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3244 (move_it_in_display_line, move_it_to)
3245 (move_it_vertically_backward, move_it_by_lines): Replace the call
3246 to xfree to an equivalent call to bidi_unshelve_cache.
3247 (move_it_in_display_line_to): Fix logic of returning
412b6358 3248 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3249
e2e2423b
EZ
32502011-08-05 Eli Zaretskii <eliz@gnu.org>
3251
3252 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3253 came from a string character with a `cursor' property. (Bug#9229)
3254
ae9e757a
JD
32552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3256
3257 * Makefile.in (LIB_PTHREAD): New variable.
3258 (LIBES): Add LIB_PTHREAD (Bug#9216).
3259
3260 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3261 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3262
213bd7f2
AS
32632011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3264
6b02f655 3265 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3266
99aaf75f
JD
32672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3268
3269 * xterm.c (x_find_topmost_parent): New function.
3270 (x_set_frame_alpha): Find topmost parent window with
3271 x_find_topmost_parent and set the property there also (bug#9181).
3272 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3273
c74e9d86
PE
32742011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3275
3276 * callproc.c (Fcall_process): Avoid vfork clobbering
3277 the local vars buffer, coding_systems, current_dir.
3278
640c8776
SM
32792011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3280
3281 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3282
f26d0e4c
PE
32832011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3284
8a10d76c
PE
3285 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3286 so that it is not optimized away.
3287
f26d0e4c
PE
3288 * xdisp.c (compute_display_string_pos): Remove unused local.
3289
55439c61
EZ
32902011-08-02 Eli Zaretskii <eliz@gnu.org>
3291
3292 Fix slow cursor motion and scrolling in large buffers with
3293 selective display, like Org Mode buffers. (Bug#9218)
3294
3295 * dispextern.h (struct bidi_it): New member disp_prop_p.
3296
3297 * xdisp.c: Remove one-slot cache of display string positions.
3298 (compute_display_string_pos): Accept an additional argument
5e617bc2 3299 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3300 for a display string or property. If found, set DISP_PROP_P
3301 non-zero.
3302
3303 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3304 DISP_PROP_P, and pass it to compute_display_string_pos.
3305 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3306 non-zero. All callers of bidi_fetch_char changed.
3307
fb33fa43
SM
33082011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3309
3310 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3311
b099e063
DM
33122010-12-03 Don March <don@ohspite.net>
3313
3314 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3315 last character M-[char] is translated to ESC [char] (bug#7541).
3316
5cc7f7af
KH
33172011-08-02 Kenichi Handa <handa@m17n.org>
3318
d0fffa3f 3319 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3320
3321 * chartab.c (uniprop_table): Make it non-static.
3322
525d5e6e
EZ
33232011-08-01 Eli Zaretskii <eliz@gnu.org>
3324
3325 * xdisp.c (forward_to_next_line_start): Accept additional argument
3326 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3327 on the newline.
3328 (reseat_at_next_visible_line_start): Use the bidi iterator state
3329 returned by forward_to_next_line_start to restore the state of
3330 it->bidi_it after backing up to previous newline. (Bug#9212)
3331
31011111
AS
33322011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3333
3334 * regex.c (re_comp): Protoize.
3335 (re_exec): Fix return type.
3336 (regexec): Fix type of `ret'. (Bug#9203)
3337
476371c4
PE
33382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3339
e5d76069
PE
3340 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3341 This is needed if max-image-size is a floating-point number.
3342
9a79b20c
AS
33432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3344
3345 * print.c (print_object): Print empty symbol as ##.
3346
3347 * lread.c (read1): Read ## as empty symbol.
3348
d8c2fa78
AA
33492011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3350
3351 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3352 setting frame foreground color (Bug#9175).
3353 (x_set_background_color): Likewise.
3354
ffe57a7a
AA
3355 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3356 contents (Bug#9176).
3357 (EmacsTooltip -init): Remove bezels and add shadows to
3358 tooltip windows.
3359
bf3492a5
AA
3360 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3361 or scroll bar (Bug#8470).
3362
d55e9c53
AA
3363 * nsfont.m (nsfont_open): Remove assignment to voffset and
3364 unnecessary vars hshink, expand, hd, full_height, min_height.
3365 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3366
3367 * nsterm.h (nsfont_info): Remove voffset field.
3368
d8c2fa78 33692011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3370
3371 Implement strike-through and overline on NextStep (Bug#8863).
3372
3373 * nsfont.m (nsfont_open): Use underline position provided by font,
3374 instead of hard-coded value of 2.
3375 (nsfont_draw): Call ns_draw_text_decoration instead.
3376
3377 * nsterm.h: Add declaration for ns_draw_text_decoration.
3378
3379 * nsterm.m (ns_draw_text_decoration): New function for drawing
3380 underline, overline, and strike-through.
3381 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3382 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3383 accommodate underlining, etc.
4843aac3 3384
4cc60b9b
EZ
33852011-07-28 Eli Zaretskii <eliz@gnu.org>
3386
bc7ece87
EZ
3387 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3388 default.
4cc60b9b 3389
476371c4
PE
33902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3391
66606eea
PE
3392 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3393 Without this fix, if a signal arrives just after memory fills up,
3394 'malloc' might be invoked reentrantly.
3395
476371c4
PE
3396 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3397 In other words, assume that every image size is allowed, on non-X
3398 hosts. This assumption is probably wrong, but it lets Emacs compile.
3399
f3fcc40d
AS
34002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3401
3402 * regex.c (re_iswctype): Convert return values to boolean.
3403
350c992f
EZ
34042011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3405
3406 * xdisp.c (compute_display_string_pos): Don't use cached display
3407 string position if the buffer had its restriction changed.
3408 (Bug#9184)
3409
5266b4bb
PE
34102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3411
3412 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3413
2573a837 34142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3415
41f55ccd 3416 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3417
39e378da
PE
3418 * bidi.c: Integer size and overflow fixes.
3419 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3420 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3421 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3422 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3423 (bidi_find_other_level_edge):
3424 Use ptrdiff_t instead of EMACS_INT where either will do.
3425 This works better on 32-bit hosts configured --with-wide-int.
3426 (bidi_cache_ensure_space): Check for size-calculation overflow.
3427 Use % rather than repeated addition, for better worst-case speed.
3428 Don't set bidi_cache_size until after xrealloc returns, because it
3429 might not return.
3430 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3431 (bidi_cache_ensure_space): Also check that the bidi cache size
3432 does not exceed that of the largest Lisp string or buffer. See Eli
3433 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3434
5e927815
PE
3435 * alloc.c (__malloc_size_t): Remove.
3436 All uses replaced by size_t. See Andreas Schwab's note
3437 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3438
ca4aa935
PE
3439 * image.c: Improve checking for integer overflow.
3440 (check_image_size): Assume that f is nonnull, since
3441 it is always nonnull in practice. This is one less thing to
3442 worry about when checking for integer overflow later.
3443 (x_check_image_size): New function, which checks for integer
3444 overflow issues inside X.
3445 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3446 This removes the need for a memory_full check.
3447 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3448 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3449 (xbm_read_bitmap_data): Change locals back to 'int', since
3450 their values must fit in 'int'.
3451 (xpm_load_image, png_load, tiff_load):
3452 Invoke x_create_x_image_and_pixmap earlier,
3453 to avoid much needless work if the image is too large.
3454 (tiff_load): Treat overly large images as if
3455 x_create_x_image_and_pixmap failed, not as malloc failures.
3456 (gs_load): Use x_check_image_size.
3457
5f8f9cc2
PE
3458 * gtkutil.c: Omit integer casts.
3459 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3460 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3461
5adf60bc
PE
3462 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3463
c8907a93
PE
3464 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3465 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3466 would wrongly return t on a 64-bit host.
3467
e3c25c68
PE
3468 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3469 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3470 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3471 and therefore cause GCC to emit a bogus diagnostic in some cases.
3472
3f791afe
PE
3473 * image.c: Integer signedness and overflow and related fixes.
3474 This is not an exhaustive set of fixes, but it's time to
3475 record what I've got.
3476 (lookup_pixel_color, check_image_size): Remove redundant decls.
3477 (check_image_size): Don't assume that arbitrary EMACS_INT values
3478 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3479 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3480 (tiff_load, imagemagick_load_image):
3481 Check for overflow in size calculations.
3482 (x_create_x_image_and_pixmap): Remove unnecessary test for
3483 xmalloc returning NULL; that can't happen.
3484 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3485 (xpm_color_bucket): Use better integer hashing function.
3486 (xpm_cache_color): Don't possibly over-allocate memory.
3487 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3488 (gif_memory_source):
3489 Use ptrdiff_t, not int or size_t, to record sizes.
3490 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3491 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3492 either works, as we prefer signed integers.
3493 (tiff_read_from_memory, tiff_write_from_memory):
3494 Return tsize_t, not size_t, since that's what the TIFF API wants.
3495 (tiff_read_from_memory): Don't fail simply because the read would
3496 go past EOF; instead, return a short read.
3497 (tiff_load): Omit no-longer-needed casts.
3498 (Fimagemagick_types): Don't assume size fits into 'int'.
3499
3cc5a532
PE
3500 Improve hashing quality when configured --with-wide-int.
3501 * fns.c (hash_string): New function, taken from sxhash_string.
3502 Do not discard information about ASCII character case; this
3503 discarding is no longer needed.
3504 (sxhash-string): Use it. Change sig to match it. Caller changed.
3505 * lisp.h: Declare it.
3506 * lread.c (hash_string): Remove, since we now use fns.c's version.
3507 The fns.c version returns a wider integer if --with-wide-int is
3508 specified, so this should help the quality of the hashing a bit.
3509
b312a492
PE
3510 * emacs.c: Integer overflow minor fix.
3511 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3512 Define only if GNU_LINUX.
3513 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3514
dfd153ae
PE
3515 * dispnew.c: Integer signedness and overflow fixes.
3516 Remove unnecessary forward decls, that were a maintenance hassle.
3517 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3518 All uses changed.
3519 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3520 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3521 (prepare_desired_row, line_draw_cost):
3522 Use int, not unsigned, where either works.
3523 (save_current_matrix, restore_current_matrix):
3524 Use ptrdiff_t, not size_t, where either works.
3525 (init_display): Check for overflow more accurately, and without
3526 relying on undefined behavior.
3527
a81d11a3
PE
3528 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3529 Remove, replacing with the new symbols in lisp.h. All uses changed.
3530 * fileio.c (make_temp_name):
3531 * filelock.c (lock_file_1, lock_file):
3532 * xdisp.c (message_dolog):
3533 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3534 Use pMd etc. instead.
3535 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3536 replacing the pWIDE etc. symbols removed from editfns.c.
3537
3300e6fd
PE
3538 * keyboard.h (num_input_events): Now uintmax_t.
3539 This is (very slightly) less likely to mess up due to wraparound.
3540 All uses changed.
3541
fd05c7e9
PE
3542 * buffer.c: Integer signedness fixes.
3543 (alloc_buffer_text, enlarge_buffer_text):
3544 Use ptrdiff_t rather than size_t when either will do, as we prefer
3545 signed integers.
3546
903fe15d
PE
3547 * alloc.c: Integer signedness and overflow fixes.
3548 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3549 (__malloc_size_t): Default to size_t, not to int.
3550 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3551 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3552 Prefer ptrdiff_t to size_t when either would do, as we prefer
3553 signed integers.
3554 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3555 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3556 Now const. Initialize with values that are in range even if char
3557 is signed.
3558 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3559 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3560 These functions do the right thing with sizes > 2**32.
3561 (check_depth): Now ptrdiff_t, not int.
3562 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3563 Adjust to new way of storing sizes. Check for size overflow bugs
3564 in rest of code.
3565 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3566 slightly wrong anyway, as it missed one instance of
3567 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3568 (refill_memory_reserve): Omit needless cast to size_t.
3569 (mark_object_loop_halt): Mark as externally visible.
3570
ac82cc6a
PE
3571 * xselect.c: Integer signedness and overflow fixes.
3572 (Fx_register_dnd_atom, x_handle_dnd_message):
3573 Use ptrdiff_t, not size_t, since we prefer signed.
3574 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3575 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3576 x_dnd_atoms_size and x_dnd_atoms_length.
3577
c2d1e36d
PE
3578 * doprnt.c: Prefer signed to unsigned when either works.
3579 * eval.c (verror):
3580 * doprnt.c (doprnt):
3581 * lisp.h (doprnt):
3582 * xdisp.c (vmessage):
3583 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3584 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3585 prefer signed arithmetic to avoid comparison confusion.
3586 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3587 but is a bit tricky.
3588
0e926e56
PE
3589 Assume freestanding C89 headers, string.h, stdlib.h.
3590 * data.c, doprnt.c, floatfns.c, print.c:
3591 Include float.h unconditionally.
3592 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3593 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3594 * regex.c: Likewise for stddef.h, string.h.
3595 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3596 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3597 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3598 (STDC_HEADERS): Remove obsolete defines.
3599 * sysdep.c: Include limits.h unconditionally.
3600
9cfdb3ec
PE
3601 Assume support for memcmp, memcpy, memmove, memset.
3602 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3603 * regex.c (memcmp, memcpy):
3604 Remove; we assume C89 now.
3605
3606 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3607 (__malloc_safe_bcopy): Remove; no longer needed.
3608
cf950e6b 3609 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3610 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3611 well either way, and we prefer signed to unsigned.
3612
dbf38e02
LMI
36132011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3614
3615 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3616 closes the connection while we're reading (bug#9182).
3617
d6f0886c 36182011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3619
d6f0886c
JD
3620 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3621 are specified (Bug#9168).
24e0f6b1 3622
2eb1f9e6
PE
36232011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3624
3625 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3626 Found by GCC static checking and --with-wide-int on a 32-bit host.
3627
22381272 36282011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3629
3630 * xdisp.c (compute_display_string_pos): Fix logic of caching
3631 previous display string position. Initialize cached_prev_pos to
3632 -1. Fixes slow-down at the beginning of a buffer.
3633
f25e39b4
EZ
36342011-07-24 Eli Zaretskii <eliz@gnu.org>
3635
3636 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3637 for attrs[LFACE_FONTSET_INDEX].
3638
04c4b52e
PE
36392011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3640
3641 * xml.c (parse_region): Remove unused local
3642 that was recently introduced.
3643
c1734fbd
EZ
36442011-07-23 Eli Zaretskii <eliz@gnu.org>
3645
be18c5a5
EZ
3646 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3647 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3648
c1734fbd
EZ
3649 * xdisp.c (move_it_in_display_line_to): Record the best matching
3650 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3651 exit if none of the characters scanned was an exact match.
3652 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3653 when exact match is impossible due to invisible text, and the
3654 lines are truncated.
3655
a258d627
JD
36562011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3657
3658 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3659 for OSX >= 10.7.
3660
b6d5a689
EZ
36612011-07-22 Eli Zaretskii <eliz@gnu.org>
3662
0f74f785
EZ
3663 Fix a significant slow-down of cursor motion with C-n, C-p,
3664 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3665 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3666 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3667 (next_element_from_buffer): Call compute_stop_pos_backwards to
3668 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3669 base_level_stop.
3670 (reseat): Don't look for prev_stop, as that could mean a very long
3671 run.
3672 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3673 <cached_disp_overlay_modiff>: Cache for last found display string
3674 position.
551918c1 3675 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3676 about the same buffer in the same area of character positions, and
3677 the buffer wasn't changed since the time the display string
3678 position was cached.
551918c1 3679
b2d0c91a
EZ
36802011-07-22 Eli Zaretskii <eliz@gnu.org>
3681
3682 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3683 is an integer, which is important for empty lines. (Bug#9149)
3684
043604ee
CY
36852011-07-22 Chong Yidong <cyd@stupidchicken.com>
3686
3687 * frame.c (Fmodify_frame_parameters): In tty case, update the
3688 default face if necessary (Bug#4238).
3689
da4adb04
CY
36902011-07-21 Chong Yidong <cyd@stupidchicken.com>
3691
3692 * editfns.c (Fstring_to_char): No need to explain what a character
3693 is in the docstring (Bug#6576).
3694
9abd0532
LMI
36952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3696
3697 * xml.c (parse_region): Make sure we always return a tree.
3698
36881d16
HK
36992011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3700
3701 * xml.c (parse_region): If a document contains only comments,
3702 return that, too.
3703
1e98674d
LMI
37042011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3705
3706 * xml.c (make_dom): Return comments, too.
3707
590bd467
PE
37082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3709
3710 Port to OpenBSD.
3711 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3712 and the surrounding thread.
3713 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3714 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3715 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3716 timer goes off.
3717 * s/openbsd.h (BROKEN_SIGIO): Define.
3718 * unexelf.c (unexec) [__OpenBSD__]:
3719 Don't update the .mdebug section of the Alpha COFF symbol table.
3720
f41628b2
LMI
37212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3722
3723 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3724 (bug#8460).
3725
b59b67c5
PE
37262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3727
15e3a074
PE
3728 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3729 This fixes some race conditions on the permissions of any newly
3730 created file.
3731
41bed37d
PE
3732 * alloc.c (valid_pointer_p): Use pipe, not open.
3733 This fixes some permissions issues when debugging.
3734
b59b67c5
PE
3735 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3736 If fchown fails to set both uid and gid, try to set just gid,
3737 as that is sometimes allowed. Adjust the file's mode to eliminate
3738 setuid or setgid bits that are inappropriate if fchown fails.
3739
925a6be7
SM
37402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3741
3742 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3743 to compare Lisp_Objects.
3744 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3745 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3746 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3747
52968808
AS
37482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3749
0a6a104b
AS
3750 * lread.c (read_integer): Unread even EOF character.
3751 (read1): Likewise. Properly record start position of symbol.
3752
52968808
AS
3753 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3754 symbol character follows.
3755
9e381cdd
PE
37562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3757
3758 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3759 This works around a problem with the previous change to Fcopy_file.
3760 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3761 and without this change, GCC might complain about discarding
3762 fchown's return value.
3763
b5641435
JB
37642011-07-16 Juanma Barranquero <lekktu@gmail.com>
3765
3766 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3767
a8031457
PE
37682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3771
dd889327
LMI
37722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3773
750c33f7
LMI
3774 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3775 it's used from the C level.
3776
dd889327
LMI
3777 * process.c: Use the same condition for POLL_FOR_INPUT in both
3778 keyboard.c and process.c (bug#1858).
3779
87e86684
LM
37802011-07-09 Lawrence Mitchell <wence@gmx.li>
3781
3782 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3783 (Fgnutls_boot): Use it.
3784
64348f40
AS
37852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3786
3787 * doc.c (Fsubstitute_command_keys): Revert last change.
3788
1d698799
LMI
37892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3790
f863868c
LMI
3791 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3792 quotes the next character, and doesn't affect other longer
3793 sequences (bug#8935).
3794
1d698799
LMI
3795 * lread.c (syms_of_lread): Clarify that is isn't only
3796 `eval-buffer' and `eval-defun' that's affected by
3797 `lexical-binding' (bug#8460).
3798
aa4b6df6
EZ
37992011-07-15 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3802 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3803
5d856da6
PE
38042011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3805
ad6042bb
PE
3806 Fix minor problems found by static checking.
3807 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3808 (elsz): Now a signed constant, not a size_t var. We prefer signed
3809 types to unsigned, to avoid integer comparison confusion. Without
3810 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3811 "cannot optimize loop, the loop counter may overflow", a symptom
3812 of the confusion.
f00bbb22 3813 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3814 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3815
6468f31c
LMI
38162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3817
49080b10
LMI
3818 * search.c (Fre_search_backward): Mention `case-fold-search' in
3819 all the re_search_* functions (bug#8138).
3820
6468f31c
LMI
3821 * keyboard.c (Fopen_dribble_file): Document when the file is
3822 closed (bug#8056).
3823
c965adc5
EZ
38242011-07-14 Eli Zaretskii <eliz@gnu.org>
3825
df9733bf
EZ
3826 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3827 bidi_cache_idx.
3828
0bb23927
EZ
3829 Support bidi reordering of display and overlay strings.
3830 * xdisp.c (compute_display_string_pos)
3831 (compute_display_string_end): Accept additional argument STRING.
3832 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3833 (reseat_to_string): Initialize bidi_it->string.s and
3834 bidi_it->string.schars.
3835 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3836 NULL (avoids a crash in bidi_paragraph_init).
3837 Initialize itb.string.lstring.
0bb23927
EZ
3838 (init_iterator): Call bidi_init_it only of a valid
3839 buffer position was specified. Initialize paragraph_embedding to
3840 L2R.
3841 (reseat_to_string): Initialize the bidi iterator.
3842 (display_string): If we need to ignore text properties of
3843 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3844 original value of -1 will not work with bidi.)
3845 (compute_display_string_pos): First arg is now struct
3846 `text_pos *'; all callers changed. Support display properties on
3847 Lisp strings.
3848 (compute_display_string_end): Support display properties on Lisp
3849 strings.
3850 (init_iterator, reseat_1, reseat_to_string): Initialize the
3851 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3852 when iterating on a string not from display properties).
640c8776
SM
3853 (compute_display_string_pos, compute_display_string_end):
3854 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3855 arrow keys.
3856 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3857 base_level_stop; instead, set base_level_stop to BEGV.
3858 Fixes crashes in vertical-motion.
0bb23927
EZ
3859 (next_element_from_buffer): Improve commentary for when
3860 the iterator is before prev_stop.
3861 (init_iterator): Initialize bidi_p from the default value of
3862 bidi-display-reordering, not from buffer-local value. Use the
3863 buffer-local value only if initializing for buffer iteration.
3864 (handle_invisible_prop): Support invisible properties on strings
3865 that are being bidi-reordered.
3866 (set_iterator_to_next): Support bidi reordering of C strings and
3867 Lisp strings.
3868 (next_element_from_string): Support bidi reordering of Lisp
3869 strings.
3870 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3871 (display_string): Support display of R2L glyph rows.
3872 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3873 (init_iterator): Don't initialize it->bidi_p for strings
3874 here.
3875 (reseat_to_string): Initialize it->bidi_p for strings here.
3876 (next_element_from_string, next_element_from_c_string)
3877 (next_element_from_buffer): Add xassert's for correspondence
3878 between IT's object being iterated and it->bidi_it.string
3879 structure.
3880 (face_before_or_after_it_pos): Support bidi iteration.
3881 (next_element_from_c_string): Handle the case of the first string
3882 character that is not the first one in the visual order.
3883 (get_visually_first_element): New function, refactored from common
3884 parts of next_element_from_buffer, next_element_from_string, and
3885 next_element_from_c_string.
3886 (tool_bar_lines_needed, redisplay_tool_bar)
3887 (display_menu_bar): Force left-to-right direction. Add a FIXME
3888 comment for making that be controlled by a user option.
3889 (push_it, pop_it): Save and restore the state of the
3890 bidi iterator. Save and restore the bidi_p flag.
3891 (pop_it): Iterate out of display property for string iteration as
3892 well.
3893 (iterate_out_of_display_property): Support iteration over strings.
3894 (handle_single_display_spec): Set up it->bidi_it for iteration
3895 over a display string, and call bidi_init_it.
3896 (handle_single_display_spec, next_overlay_string)
3897 (get_overlay_strings_1, push_display_prop): Set up the bidi
3898 iterator for displaying display or overlay strings.
3899 (forward_to_next_line_start): Don't use the shortcut if
3900 bidi-iterating.
3901 (back_to_previous_visible_line_start): If handle_display_prop
3902 pushed the iterator stack, restore the internal state of the bidi
3903 iterator by calling bidi_pop_it same number of times.
3904 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3905 and we are bidi-iterating, don't decrement the iterator position;
3906 instead, set the first_elt flag in the bidi iterator, to produce
3907 the same effect.
3908 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3909 (push_display_prop): xassert that we are iterating a buffer.
3910 (push_it, pop_it): Save and restore paragraph_embedding member.
3911 (handle_single_display_spec, next_overlay_string)
3912 (get_overlay_strings_1, reseat_1, reseat_to_string)
3913 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3914 correctly. Don't assume unibyte strings are not bidi-reordered.
3915 (compute_display_string_pos)
3916 (compute_display_string_end): Fix handling the case of C string.
3917 (push_it, pop_it): Save and restore from_disp_prop_p.
3918 (handle_single_display_spec, push_display_prop): Set the
3919 from_disp_prop_p flag.
3920 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3921 (pop_it): Call iterate_out_of_display_property only if we are
3922 popping after iteration over a string that came from a display
3923 property. Fix a typo in popping stretch info. Add an assertion
3924 for verifying that the iterator position is in sync with the bidi
3925 iterator.
3926 (handle_single_display_spec, get_overlay_strings_1)
3927 (push_display_prop): Fix initialization of paragraph direction for
3928 string when that of the parent object is not yet determined.
3929 (reseat_1): Call bidi_init_it to resync the bidi
3930 iterator with IT's position. (Bug#7616)
3931 (find_row_edges): If ROW->start.pos gives position
3932 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3933 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3934 Reset the from_disp_prop_p flag.
3935 (SAVE_IT, RESTORE_IT): New macros.
3936 (pos_visible_p, face_before_or_after_it_pos)
3937 (back_to_previous_visible_line_start)
3938 (move_it_in_display_line_to, move_it_in_display_line)
3939 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3940 (try_scrolling, redisplay_window, display_line): Use them when
3941 saving a temporary copy of the iterator and restoring it back.
3942 (back_to_previous_visible_line_start, reseat_1)
3943 (init_iterator): Empty the bidi cache "stack".
3944 (move_it_in_display_line_to): If iterator ended up at
3945 EOL, but we never saw any buffer positions smaller than
3946 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3947 motion in bidi-reordered lines.
3948 (move_it_in_display_line_to): Record prev_method and prev_pos
3949 immediately before the call to set_iterator_to_next. Fixes cursor
3950 motion in bidi-reordered lines with stretch glyphs and strings
3951 displayed in margins. (Bug#8133) (Bug#8867)
3952 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3953 TO_CHARPOS.
640c8776
SM
3954 (pos_visible_p): Support positions in bidi-reordered lines.
3955 Save and restore bidi cache.
0bb23927
EZ
3956
3957 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3958 (bidi_paragraph_info): Delete unused struct.
3959 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3960 (bidi_cache_start): New variable.
3961 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3962 to zero.
3963 (bidi_cache_fetch_state, bidi_cache_search)
3964 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3965 (bidi_cache_find, bidi_peek_at_next_level)
3966 (bidi_level_of_next_char, bidi_find_other_level_edge)
3967 (bidi_move_to_visually_next): Compare cache index with
3968 bidi_cache_start rather than with zero.
3969 (bidi_fetch_char): Accept new argument STRING; all callers
3970 changed. Support iteration over a string. Support strings with
3971 display properties. Support unibyte strings. Fix the type of
3972 `len' according to what STRING_CHAR_AND_LENGTH expects.
3973 (bidi_paragraph_init, bidi_resolve_explicit_1)
3974 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3975 (bidi_level_of_next_char, bidi_move_to_visually_next):
3976 Support iteration over a string.
0bb23927
EZ
3977 (bidi_set_sor_type, bidi_resolve_explicit_1)
3978 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3979 can now be zero (for strings); special values 0 and -1 were
3980 changed to -1 and -2, respectively.
3981 (bidi_char_at_pos): New function.
3982 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3983 Call it instead of FETCH_MULTIBYTE_CHAR.
3984 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3985 initialized to valid values.
3986 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3987 values.
3988 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3989 the test for valid cached positions. Fix the logic for looking up
3990 the sentinel state in the cache. GCPRO the Lisp string we are
3991 iterating.
3992 (bidi_push_it, bidi_pop_it): New functions.
3993 (bidi_initialize): Initialize the bidi cache start stack pointer.
3994 (bidi_cache_ensure_space): New function, refactored from part of
3995 bidi_cache_iterator_state. Don't assume the required size is just
3996 one BIDI_CACHE_CHUNK away.
3997 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3998 (bidi_count_bytes, bidi_char_at_pos): New functions.
3999 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4000 always valid if bidi_cache_idx is valid.
4001 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4002 is valid if it's going to be used.
4003 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4004 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4005 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4006 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4007 (bidi_find_other_level_edge, bidi_cache_start_stack):
4008 All variables related to cache indices are now EMACS_INT.
c965adc5 4009
0bb23927
EZ
4010 * dispextern.h (struct bidi_string_data): New structure.
4011 (struct bidi_it): New member `string'. Make flag members be 1-bit
4012 fields, and put them last in the struct.
640c8776
SM
4013 (compute_display_string_pos, compute_display_string_end):
4014 Update prototypes.
0bb23927
EZ
4015 (bidi_push_it, bidi_pop_it): Add prototypes.
4016 (struct iterator_stack_entry): New members bidi_p,
4017 paragraph_embedding, and from_disp_prop_p.
4018 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4019 (bidi_shelve_cache, bidi_unshelve_cache):
4020 Declare prototypes.
0bb23927
EZ
4021
4022 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4023 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4024 and vector-like objects.
4025
4026 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4027 cache around display iteration.
4028
4029 * window.c (Fwindow_end, window_scroll_pixel_based)
4030 (displayed_window_lines, Frecenter): Save and restore the bidi
4031 cache around display iteration.
4032
3bbd2265
LMI
40332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4034
4035 * editfns.c (Fdelete_region): Clarify the use of the named
4036 parameters (bug#6788).
4037
adc47434
MR
40382011-07-14 Martin Rudalics <rudalics@gmx.at>
4039
4040 * indent.c (Fvertical_motion): Set and restore w->pointm when
4041 saving and restoring the window's buffer (Bug#9006).
4042
837c31f8
LMI
40432011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4044
4045 * editfns.c (Fstring_to_char): Clarify just what is returned
4046 (bug#6576). Text by Eli Zaretskii.
4047
ac389d0c
JB
40482011-07-13 Juanma Barranquero <lekktu@gmail.com>
4049
4050 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4051
0be0ce47
EZ
40522011-07-13 Eli Zaretskii <eliz@gnu.org>
4053
4054 * buffer.c (mmap_find): Fix a typo.
4055
cd18e7e3
JB
40562011-07-13 Johan Bockgård <bojohan@gnu.org>
4057
4058 Fix execution of x selection hooks.
4059 * xselect.c (Qx_lost_selection_functions)
4060 (Qx_sent_selection_functions): New vars.
4061 (syms_of_xselect): DEFSYM them.
4062 (x_handle_selection_request): Pass Qx_sent_selection_functions
4063 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4064 (x_handle_selection_clear,x_clear_frame_selections):
4065 Pass Qx_lost_selection_functions rather than
4066 Vx_lost_selection_functions to Frun_hook_with_args.
4067
47ea7f44
PE
40682011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4069
ac389d0c 4070 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4071 The old code sometimes used this field without initializing it.
4072
47ea7f44
PE
4073 * alloc.c (gc_sweep): Don't read past end of array.
4074 In theory, the old code could also have corrupted Emacs internals,
4075 though it'd be very unlikely.
4076
bc985c87
AS
40772011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4078
4079 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4080 argument. (Bug#4026)
bc985c87 4081
0cf34688
LMI
40822011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4083
b3dadd76
LMI
4084 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4085 key" (bug#4257).
4086
0cf34688
LMI
4087 * window.c (Fset_window_start): Doc fix (bug#4199).
4088 (Fset_window_hscroll): Ditto.
4089
270768cd
PE
40902011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4091
077e3dda 4092 Fix minor new problems caught by GCC 4.6.1.
270768cd 4093 * term.c (init_tty): Remove unused local.
490011a6 4094 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4095 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4096 not used otherwise.
270768cd 4097
b1f58454
CY
40982011-07-12 Chong Yidong <cyd@stupidchicken.com>
4099
4100 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4101
22b9578d
LMI
41022011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4103
6e70ab07
LMI
4104 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4105 are the mini-buffer and the echo area (bug#3320).
4106
22b9578d
LMI
4107 * term.c (init_tty): Remove support for supdup, c10 and perq
4108 terminals, which are no longer supported (bug#1482).
4109
8974cc9f
JB
41102011-07-10 Johan Bockgård <bojohan@gnu.org>
4111
4112 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4113
a560d974
JD
41142011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4115
4116 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4117 for non-popups (Bug#3642).
4118
1dae0f0a
AS
41192011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4120
268c2c36 4121 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4122 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4123 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4124 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4125 * data.c (fmod): Likewise.
4126 * dispnew.c (swap_glyphs_in_rows): Likewise.
4127 * emacs.c (memory_warning_signal): Likewise.
4128 * floatfns.c (float_error): Likewise.
4129 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4130 (otf_open, font_otf_capability, generate_otf_features)
4131 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4132 Likewise.
4133 * image.c (pbm_read_file): Likewise.
4134 * indent.c (string_display_width): Likewise.
4135 * intervals.c (check_for_interval, search_for_interval)
4136 (inc_interval_count, count_intervals, root_interval)
4137 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4138 * lread.c (defalias): Likewise.
268c2c36 4139 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4140 * regex.c (set_image_of_range_1, set_image_of_range)
4141 (regex_grow_registers): Likewise.
4142 * sysdep.c (strerror): Likewise.
4143 * termcap.c (valid_filename_p, tprint, main): Likewise.
4144 * tparam.c (main): Likewise.
4145 * unexhp9k800.c (run_time_remap, save_data_space)
4146 (update_file_ptrs, read_header, write_header, calculate_checksum)
4147 (copy_file, copy_rest, display_header): Likewise.
4148 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4149 Likewise.
4150 * xdisp.c (check_it): Likewise.
4151 * xfaces.c (register_color, unregister_color, unregister_colors):
4152 Likewise.
4153 * xfns.c (print_fontset_result): Likewise.
4154 * xrdb.c (member, fatal, main): Likewise.
4155
99033785
PE
41562011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4157
4158 Fix minor problems found by static checking (Bug#9031).
4159 * chartab.c (char_table_set_range, map_sub_char_table):
4160 Remove unused locals.
4161 (uniprop_table): Now static.
4162 * composite.c (_work_char): Remove unused static var.
4163
9cb2ac56
JB
41642011-07-09 Juanma Barranquero <lekktu@gmail.com>
4165
4166 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4167
f25661f0
JD
41682011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4169
4170 * gtkutil.c (qttip_cb): Remove code without function.
4171
8278c4fe
EZ
41722011-07-09 Eli Zaretskii <eliz@gnu.org>
4173
4174 * w32.c (pthread_sigmask): New stub.
4175
1692ae2d 41762011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4177
8a6ebd58 4178 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4179 sigprocmask is portable only for single-threaded applications, and
4180 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4181 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4182 (LIBES): Use it.
4183 * callproc.c (Fcall_process):
4184 * process.c (create_process):
4185 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4186 Use pthread_sigmask, not sigprocmask.
123403e4 4187
1b854618
JD
41882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4189
4190 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4191 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4192 wrong (Bug#8591).
4193
3fe4b549
JD
41942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4195
0ce7e563
JD
4196 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4197 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4198 (xg_hide_tooltip): Fix comment.
4199
3fe4b549
JD
4200 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4201 in registerServicesMenuSendTypes.
4202 (validRequestorForSendType): Don't check ns_return_types.
4203
4204 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4205 ns_return_type.
4206
5df75e47
JR
42072011-07-08 Jason Rumney <jasonr@gnu.org>
4208
22610910
JR
4209 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4210 SH_SHOW for hidden windows (Bug#5482).
4211
5df75e47
JR
4212 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4213 frame struct members of non-existent frames (Bug#6284).
4214
699c10bd
JD
42152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4216
4393663b
JD
4217 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4218 variable firstTime not needed on OSX >= 10.6.
4219 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4220 >= 10.5. Use setKnobProportion, setDoubleValue.
4221
4222 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4223 (MAC_OS_X_VERSION_10_5): Define if not defined.
4224 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4225 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4226 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4227
4228 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4229 cString and lossyCString on OSX >= 10.4
4230
58179cce 4231 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4232 sizeToFit on OSX >= 10.2.
4233
4234 * nsimage.m (allocInitFromFile): Don't use deprecated method
4235 bestRepresentationForDevice on OSX >= 10.6.
4236
4237 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4238 to avoid warning.
4239
4240 * emacs.c: Declare unexec_init_emacs_zone.
4241
a63e0781
JD
4242 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4243
699c10bd
JD
4244 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4245
4246 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4247 on svcsMenu (Bug#8842).
4248
4249 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4250 ns_return_types.
4251 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4252
4253 * nsterm.m (QUTF8_STRING): Declare.
4254 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4255 (validRequestorForSendType): Return type is (id).
4256 Change indexOfObjectIdenticalTo to indexOfObject.
4257 Check if we have local selection before returning self (Bug#8842).
4258 (writeSelectionToPasteboard): Put local selection into paste board
4259 if we have a local selection (Bug#8842).
4260 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4261
4262 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4263 (ns_get_local_selection): Declare.
4264
54e10184
LMI
42652011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4266
9888ff71
LMI
4267 * keymap.c (describe_map_tree): Don't insert a double newline at
4268 the end of the buffer (bug#1169) and return whether we inserted
4269 something.
4270
54e10184
LMI
4271 * callint.c (Fcall_interactively): Change "reading args" to
4272 "providing args" to try to clarify what it does (bug#1010).
4273
15fa4783
KH
42742011-07-07 Kenichi Handa <handa@m17n.org>
4275
4276 * composite.c (composition_compute_stop_pos): Ignore a static
4277 composition starting before CHARPOS (Bug#8915).
4278
4279 * xdisp.c (handle_composition_prop): Likewise.
4280
a8815b00
EZ
42812011-07-07 Eli Zaretskii <eliz@gnu.org>
4282
4283 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4284 (Bug#9015)
4285
ef7b981d 42862011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4287
4288 * character.h (unicode_category_t): New enum type.
4289
4290 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4291 (Qchar_code_property_table): New variable.
4292 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4293 (UNIPROP_COMPRESSED_FORM_P): New macros.
4294 (char_table_ascii): Uncompress the compressed values.
4295 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4296 Uncompress the compressed values.
ac389d0c 4297 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4298 (char_table_ref_and_range): Uncompress the compressed values.
4299 (sub_char_table_set): New arg is_uniprop. Callers changed.
4300 Uncompress the compressed values.
4301 (sub_char_table_set_range): Args changed. Callers changed.
4302 (char_table_set_range): Adjuted for the above change.
4303 (map_sub_char_table): Delete args default_val and parent. Add arg
4304 top. Give decoded values to a Lisp function.
640c8776 4305 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4306 values to a Lisp function. Gcpro more variables.
4307 (uniprop_table_uncompress)
4308 (uniprop_decode_value_run_length): New functions.
4309 (uniprop_decoder, uniprop_decoder_count): New variables.
4310 (uniprop_get_decoder, uniprop_encode_value_character)
4311 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4312 New functions.
4313 (uniprop_encoder, uniprop_encoder_count): New variables.
4314 (uniprop_get_encoder, uniprop_table)
4315 (Funicode_property_table_internal, Fget_unicode_property_internal)
4316 (Fput_unicode_property_internal): New functions.
4317 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4318 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4319 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4320 char-code-property-alist.
4321
640c8776 4322 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4323 Vunicode_category_table.
4324
640c8776 4325 * font.c (font_range): Adjust for the change of
c805dec0
KH
4326 Vunicode_category_table.
4327
76b397fb
DN
43282011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4329
4330 * m/iris4d.h: Remove file, move contents ...
4331 * s/irix6-5.h: ... here.
4332
22b4128e
PE
43332011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4334
4335 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4336 * alloc.c (mark_buffer):
4337 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4338 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4339 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4340 This isn't true in general, and it's particularly not true
4341 if Emacs is configured with --with-wide-int.
4342 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4343 New macros, used in the buffer.c change.
4344
869795d6
JD
43452011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4346
4347 * xsettings.c: Use both GConf and GSettings if both are available.
4348 (store_config_changed_event): Add comment.
4349 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4350 (store_tool_bar_style_changed): New functions.
5e617bc2 4351 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4352 (struct xsettings): Move font inside HAVE_XFT.
4353 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4354 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4355 Move inside HAVE_XFT.
640c8776 4356 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4357 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4358 also.
4359 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4360 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4361 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4362 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4363 (parse_settings): Move check for font inside HAVE_XFT.
4364 (read_settings, apply_xft_settings): Add comment.
4365 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4366 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4367 call store_font_name_changed.
4368 (xft_settings_event): Add comment.
4369 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4370 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4371 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4372 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4373 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4374 (xsettings_get_system_font, xsettings_get_system_normal_font):
4375 Add comment.
869795d6 4376
d8ed26bd
PE
43772011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4378
4379 Random fixes. E.g., (random) never returned negative values.
4380 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4381 subseconds part to the entropy, as that's a bit more random.
4382 Prefer signed to unsigned, since the signedness doesn't matter and
4383 in general we prefer signed. When given a limit, use a
4384 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4385 latter isn't right if USE_2_TAGS_FOR_INTS.
4386 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4387 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4388
cabf1cac
SM
43892011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4390
4391 * textprop.c (text_property_stickiness):
4392 Obey Vtext_property_default_nonsticky.
4393 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4394 * w32fns.c (syms_of_w32fns):
4395 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4396
6e9b2be9
PE
43972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4398
4399 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4400 This is more efficient than Ffile_directory_p and avoids a minor race.
4401
90186c68
LMI
44022011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4403
7c301272
LMI
4404 * buffer.c (Foverlay_put): Say what the return value is
4405 (bug#7835).
4406
c4f2d8d4
LMI
4407 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4408 is a directory before asking whether to use the file name
4409 (bug#7564).
ad637907
LMI
4410 (barf_or_query_if_file_exists): Make the "File is a directory"
4411 error be more correct.
c4f2d8d4 4412
90186c68
LMI
4413 * fns.c (Frequire): Remove the mention of the .gz files, since
4414 that's installation-specific, but keep the mention of
4415 `get-load-suffixes'.
4416
da64016e
PE
44172011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4420 Report string overflow if the output is too long.
4421
7d47b580
JB
44222011-07-04 Juanma Barranquero <lekktu@gmail.com>
4423
a555cb87
JB
4424 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4425 (syms_of_gnutls): Remove duplicate DEFSYM for
4426 Qgnutls_bootprop_verify_hostname_error, an error for
4427 Qgnutls_bootprop_verify_error (which is no longer used).
4428
7d47b580
JB
4429 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4430 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4431 Also (re)move comments that are misplaced or no longer relevant.
4432
1e49bfab
LMI
44332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4434
4435 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4436
1485f4c0
CY
44372011-07-03 Chong Yidong <cyd@stupidchicken.com>
4438
4439 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4440 and background color parameters if they have been changed.
4441
a9ab721e
LMI
44422011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4443
4444 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4445
cf7cff57
PE
44462011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4447
2e13213d
PE
4448 * xsettings.c (SYSTEM_FONT): Define only when used.
4449 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4450
cf7cff57
PE
4451 * keymap.c (access_keymap_1): Now static.
4452
7a8e04f7
CY
44532011-07-02 Chong Yidong <cyd@stupidchicken.com>
4454
4455 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4456 leave any prefix arg for the up event (Bug#1586).
4457
61352f62
LMI
44582011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4459
69bb1ef7
LMI
4460 * lread.c (syms_of_lread): Mention single symbols defined by
4461 `defvar' or `defconst' (bug#7154).
4462
61352f62 4463 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4464 (Frequire): Mention get-load-suffixes.
61352f62 4465
28545e04
MR
44662011-07-02 Martin Rudalics <rudalics@gmx.at>
4467
4468 * window.h (window): Remove clone_number slot.
4469 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4470 Remove.
4471 (make_parent_window, make_window, saved_window)
4472 (Fset_window_configuration, save_window_save): Don't deal with
4473 clone numbers.
4474 * buffer.c (Qclone_number): Remove declaration.
4475 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4476
3349e122
SM
44772011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4478
4479 Add multiple inheritance to keymaps.
4480 * keymap.c (Fmake_composed_keymap): New function.
4481 (Fset_keymap_parent): Simplify.
4482 (fix_submap_inheritance): Remove.
4483 (access_keymap_1): New function extracted from access_keymap to handle
4484 embedded parents and handle lists of maps.
4485 (access_keymap): Use it.
4486 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4487 (Fcopy_keymap): Handle embedded parents.
4488 (Fcommand_remapping, define_as_prefix): Simplify.
4489 (Fkey_binding): Simplify.
4490 (syms_of_keymap): Move minibuffer-local-completion-map,
4491 minibuffer-local-filename-completion-map,
4492 minibuffer-local-must-match-map, and
4493 minibuffer-local-filename-must-match-map to Elisp.
4494 (syms_of_keymap): Defsubr make-composed-keymap.
4495 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4496 (parse_menu_item): Trivial simplification.
4497
3279eb87
GM
44982011-07-01 Glenn Morris <rgm@gnu.org>
4499
4500 * Makefile.in (SETTINGS_LIBS): Fix typo.
4501
4550efdf
KI
45022011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4503
4504 * coding.c (Fencode_coding_string): Record the last coding system
4505 used, as the function doc string says (bug#8738).
4506
0949d2b6
JD
45072011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4508
4509 * xsettings.c (store_monospaced_changed): Take new font as arg and
4510 check for change against current_mono_font.
4511 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4512 (emacs_settings_constructor, emacs_settings_get_property)
4513 (emacs_settings_set_property, emacs_settings_class_init)
4514 (emacs_settings_init, gsettings_obj): Remove.
4515 (something_changedCB): New function for HAVE_GSETTINGS.
4516 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4517 with value as argument.
4518 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4519 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4520 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4521 "changed".
4522
4523 * xgselect.c: Add defined (HAVE_GSETTINGS).
4524 (xgselect_initialize): Ditto.
4525
4526 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4527 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4528 xg_select.
4529
bbc6b304
PE
45302011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4531
4532 * eval.c (struct backtrace): Simplify and port the data structure.
4533 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4534 signed bit field, as this assumption is not portable and it makes
4535 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4536 "char debug_on_exit : 1" as this is not portable either; instead,
4537 use the portable "unsigned int debug_on_exit : 1". Remove unused
4538 member evalargs. Remove obsolete comments about cc bombing out.
4539
9851bfc5
JD
45402011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4541
51bb811f 4542 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4543 Let HAVE_GSETTINGS override HAVE_GCONF.
4544 (store_monospaced_changed): New function.
4545 (EMACS_SETTINGS): A new type derived from GObject to handle
4546 GSettings notifications.
4547 (emacs_settings_constructor, emacs_settings_get_property)
4548 (emacs_settings_set_property, emacs_settings_class_init):
4549 New functions.
4550 (gsettings_client, gsettings_obj): New variables.
4551 (GSETTINGS_SCHEMA): New define.
4552 (something_changedCB): Call store_monospaced_changed.
4553 (init_gsettings): New function.
4554 (xsettings_initialize): Call init_gsettings.
4555 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4556 to NULL.
4557
640c8776 4558 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4559 GCONF_CFLAGS/LIBS.
4560
5386012d
MR
45612011-06-29 Martin Rudalics <rudalics@gmx.at>
4562
4563 * window.c (resize_root_window, grow_mini_window)
4564 (shrink_mini_window): Rename Qresize_root_window to
4565 Qwindow_resize_root_window and Qresize_root_window_vertically to
4566 Qwindow_resize_root_window_vertically.
4567
f13e0b08
PE
45682011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4569
4570 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4571
94515237
JB
45722011-06-27 Juanma Barranquero <lekktu@gmail.com>
4573
4574 * makefile.w32-in: Redesign dependencies so they reflect more
4575 clearly which files are directly included by each source file,
4576 and not through other includes.
4577
e43b6e43
MR
45782011-06-27 Martin Rudalics <rudalics@gmx.at>
4579
4580 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4581 (sort_overlays, overlay_strings): When an overlay's clone number
4582 matches the window's clone number process the overlay even if
4583 the overlay's window property doesn't match the current window.
4584
d68443dc
MR
4585 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4586 (Fwindow_hchild): Rename to Fwindow_left_child.
4587 (Fwindow_next): Rename to Fwindow_next_sibling.
4588 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4589 (resize_window_check): Rename to window_resize_check.
4590 (resize_window_apply): Rename to window_resize_apply.
4591 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4592 (Fdelete_other_windows_internal, resize_frame_windows)
4593 (Fsplit_window_internal, Fdelete_window_internal)
4594 (grow_mini_window, shrink_mini_window)
4595 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4596
c7e73be5
JD
45972011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4598
4599 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4600 (emacs_fixed_set_min_size): Remove.
4601 (emacs_fixed_new): Take frame as argument.
4602
4603 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4604 (_EmacsFixedPrivate): Remove minwidth/height.
4605 Add struct frame *f.
4606 (emacs_fixed_init): Initialize priv->f.
4607 (get_parent_class, emacs_fixed_set_min_size): Remove.
4608 (emacs_fixed_new): Set priv->f to argument.
4609 (emacs_fixed_get_preferred_width)
4610 (emacs_fixed_get_preferred_height): Use min_width/height from
4611 frames size_hint to set minimum and natural (Bug#8919).
4612 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4613 and use min_width/height from frames size_hint to set
4614 min_width/height (Bug#8919).
4615
4616 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4617 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4618 Fix indentation.
c7e73be5 4619
cf99dcf8
EZ
46202011-06-26 Eli Zaretskii <eliz@gnu.org>
4621
4622 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4623 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4624 called at ZV.
4625
029529ac
CY
46262011-06-26 Chong Yidong <cyd@stupidchicken.com>
4627
4628 * process.c (wait_reading_process_output): Bypass select if
4629 waiting for a cell while ignoring keyboard input, and input is
4630 pending. Suggested by Jan Djärv (Bug#8869).
4631
7a7ef429
PE
46322011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4633
4634 Use gnulib's dup2 module instead of rolling our own.
4635 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4636
11fdef7d 46372011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4638
4639 * dispnew.c (scrolling_window): Before scrolling, turn off a
4640 mouse-highlight in the window being scrolled.
4641
cd3520a4
JB
46422011-06-24 Juanma Barranquero <lekktu@gmail.com>
4643
4644 Move DEFSYM to lisp.h and use everywhere.
4645
4646 * character.h (DEFSYM): Move declaration...
4647 * lisp.h (DEFSYM): ...here.
4648
4649 * gnutls.c:
4650 * minibuf.c:
4651 * w32menu.c:
4652 * w32proc.c:
4653 * w32select.c: Don't include character.h.
4654
4655 * alloc.c (syms_of_alloc):
4656 * buffer.c (syms_of_buffer):
4657 * bytecode.c (syms_of_bytecode):
4658 * callint.c (syms_of_callint):
4659 * casefiddle.c (syms_of_casefiddle):
4660 * casetab.c (init_casetab_once):
4661 * category.c (init_category_once, syms_of_category):
4662 * ccl.c (syms_of_ccl):
4663 * cmds.c (syms_of_cmds):
4664 * composite.c (syms_of_composite):
4665 * dbusbind.c (syms_of_dbusbind):
4666 * dired.c (syms_of_dired):
4667 * dispnew.c (syms_of_display):
4668 * doc.c (syms_of_doc):
4669 * editfns.c (syms_of_editfns):
4670 * emacs.c (syms_of_emacs):
4671 * eval.c (syms_of_eval):
4672 * fileio.c (syms_of_fileio):
4673 * fns.c (syms_of_fns):
4674 * frame.c (syms_of_frame):
4675 * fringe.c (syms_of_fringe):
4676 * insdel.c (syms_of_insdel):
4677 * keymap.c (syms_of_keymap):
4678 * lread.c (init_obarray, syms_of_lread):
4679 * macros.c (syms_of_macros):
4680 * msdos.c (syms_of_msdos):
4681 * print.c (syms_of_print):
4682 * process.c (syms_of_process):
4683 * search.c (syms_of_search):
4684 * sound.c (syms_of_sound):
4685 * syntax.c (init_syntax_once, syms_of_syntax):
4686 * terminal.c (syms_of_terminal):
4687 * textprop.c (syms_of_textprop):
4688 * undo.c (syms_of_undo):
4689 * w32.c (globals_of_w32):
4690 * window.c (syms_of_window):
4691 * xdisp.c (syms_of_xdisp):
4692 * xfaces.c (syms_of_xfaces):
4693 * xfns.c (syms_of_xfns):
4694 * xmenu.c (syms_of_xmenu):
4695 * xsettings.c (syms_of_xsettings):
4696 * xterm.c (syms_of_xterm): Use DEFSYM.
4697
4228cf16
TZ
46982011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4699
cd3520a4 4700 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4701
7fcccf1e
PE
47022011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4703
7efb4e0e
PE
4704 Integer and buffer overflow fixes (Bug#8873).
4705
ff5844ad
PE
4706 * print.c (printchar, strout): Check for string overflow.
4707 (PRINTPREPARE, printchar, strout):
4708 Don't set size unless allocation succeeds.
4709
90532f02
PE
4710 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4711 for sizes. Check for string overflow more accurately.
4712 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4713
6d84508d
PE
4714 * macros.c: Integer and buffer overflow fixes.
4715 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4716 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4717 Use ptrdiff_t, not int, for sizes.
4718 Don't increment bufsize until after realloc succeeds.
4719 Check for size-calculation overflow.
4720 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4721
437b2cb4
PE
4722 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4723
8b9ac8b4
PE
4724 * lread.c: Integer overflow fixes.
4725 (read_integer): Radix is now EMACS_INT, not int,
4726 to improve quality of diagnostics for out-of-range radices.
4727 Calculate buffer size correctly for out-of-range radices.
4728 (read1): Check for integer overflow in radices, and in
4729 read-circle numbers.
82cb60d3
PE
4730 (read_escape): Avoid int overflow.
4731 (Fload, openp, read_buffer_size, read1)
4732 (substitute_object_recurse, read_vector, read_list, map_obarray):
4733 Use ptrdiff_t, not int, for sizes.
4734 (read1): Use EMACS_INT, not int, for sizes.
20270765 4735 Check for size overflow.
8b9ac8b4 4736
7fcccf1e
PE
4737 * image.c (cache_image): Check for size arithmetic overflow.
4738
bfbbd7e7
PE
4739 * lread.c: Integer overflow issues.
4740 (saved_doc_string_size, saved_doc_string_length)
4741 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4742 Now ptrdiff_t, not int.
4743 (read1): Don't assume doc string length fits in int. Check for
4744 out-of-range doc string lengths.
4745 (read_list): Don't assume file position fits in int.
39019e54 4746 (read_escape): Check for hex character overflow.
bfbbd7e7 4747
4e323265
LL
47482011-06-22 Leo Liu <sdl.web@gmail.com>
4749
4750 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4751 Move to minibuffer.el.
4752
85fece3e
PE
47532011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4754
20b84ce9 4755 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4756 The following patches are for when GLYPH_DEBUG && !XASSERT.
4757 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4758 * dispnew.c (flush_stdout):
4759 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4760 Mark as externally visible.
4761 * dispnew.c (check_window_matrix_pointers): Now static.
4762 * dispnew.c (window_to_frame_vpos):
4763 * xfns.c (unwind_create_frame):
4764 * xterm.c (x_check_font): Remove unused local.
4765 * scroll.c (CHECK_BOUNDS):
4766 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4767 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4768 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4769 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4770 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4771 Now static.
4772 (debug_method_add): Use va_list and vsprintf rather than relying
4773 on undefined behavior with wrong number of arguments.
4774 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4775 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4776 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4777 since we're not interested in debugging glyphs with old libraries.
4778 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4779 GCC 4.6.0's static checking.
4780
0766b489
PE
47812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4782
31fd4b32
PE
4783 Integer overflow and signedness fixes (Bug#8873).
4784 A few related buffer overrun fixes, too.
4785
b79e8648
PE
4786 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4787
0766b489
PE
4788 * dispextern.h (struct face.stipple):
4789 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4790 (x_bitmap_mask, x_allocate_bitmap_record)
4791 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4792 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4793 (x_create_bitmap_from_xpm_data):
4794 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4795 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4796 (.bitmaps_last):
4797 * xfaces.c (load_pixmap):
4798 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4799 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4800 (.bitmaps_last, struct x_output.icon_bitmap):
4801 Use ptrdiff_t, not int, for bitmap indexes.
4802 (x_allocate_bitmap_record): Check for size overflow.
4803 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4804
b081724f
PE
4805 Use ptrdiff_t, not int, for overlay counts.
4806 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4807 * editfns.c (overlays_around, get_pos_property):
4808 * textprop.c (get_char_property_and_overlay):
4809 * xdisp.c (next_overlay_change, note_mouse_highlight):
4810 * xfaces.c (face_at_buffer_position):
21514da7
PE
4811 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4812 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4813 (Fnext_overlay_change, Fprevious_overlay_change)
4814 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4815 Use ptrdiff_t, not int, for sizes.
21514da7 4816 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4817
3de73e5e
PE
4818 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4819
2606c57b
PE
4820 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4821 (x_session_initialize): Do not assume string length fits in int.
4822
aaafe47a
PE
4823 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4824 This is unlikely, but can occur if DPI is outlandish.
4825
2674ddc8 4826 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4827 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4828
28154962
PE
4829 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4830 * xrdb.c (magic_file_p, search_magic_path):
4831 Omit last arg SUFFIX; it was always 0. All callers changed.
4832 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4833
7de51af5
PE
4834 * xfont.c (xfont_match): Avoid need for strlen.
4835
25ed6cc3
PE
4836 * xfns.c: Don't assume strlen fits in int.
4837 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4838
4eab31dd
PE
4839 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4840 not unsigned long, as we prefer signed integers. All callers changed.
4841 Detect integer overflow in repeat count.
4842 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4843 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4844
171e2a58
PE
4845 * termcap.c: Don't assume sizes fit in int and never overflow.
4846 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4847 (gobble_line): Check for size-calculation overflow.
4848
ad39faca 4849 * minibuf.c (Fread_buffer):
6e5bb2dc 4850 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4851 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4852 Don't assume string length fits in int.
4853
52c61c22 4854 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4855 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4856
b5b8c9e5
PE
4857 * font.c: Don't assume string length fits in int.
4858 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4859 Use ptrdiff_t, not int.
ccd6111c
PE
4860 (font_intern_prop): Don't assume string length fits in int.
4861 Don't assume integer property fits in fixnum.
4862 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4863
882f0d81 4864 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4865 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4866 Reformulate so as not to need the command string.
4867 Invoke gzip -cd rather than gunzip, as it's more portable.
4868 (lock_info_type, lock_file_1, lock_file):
4869 Don't assume pid_t and time_t fit in unsigned long.
4870 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4871 (current_lock_owner): Prefer signed type for sizes.
4872 Use memcpy, not strncpy, where memcpy is what is really wanted.
4873 Don't assume (via atoi) that time_t and pid_t fit in int.
4874 Check for time_t and/or pid_t out of range, e.g., via a network share.
4875 Don't alloca where an auto var works fine.
4876
93f4cf88
PE
4877 * fileio.c: Fix some integer overflow issues.
4878 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4879 Don't assume string length fits in int.
4880 (directory_file_name): Don't assume string length fits in long.
4881 (make_temp_name): Don't assume pid fits in int, or that its print
4882 length is less than 20.
4883
f3e92b69
PE
4884 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4885
1bfdaf10
PE
4886 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4887
35016e9a
PE
4888 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4889
3d1e65a1
PE
4890 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4891 We prefer signed integers, even for size calculations.
4892
0b963a93
PE
4893 * emacs.c: Don't assume string length fits in 'int'.
4894 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4895 (main): Don't invoke strlen when not needed.
4896
573f4b54
PE
4897 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4898 (XD_DEBUG_MESSAGE): Don't waste a byte.
4899
989f33ba
PE
4900 * callproc.c (getenv_internal_1, getenv_internal)
4901 (Fgetenv_internal):
965d34eb
PE
4902 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4903
e4d29b33
PE
4904 * lread.c (invalid_syntax): Omit length argument.
4905 All uses changed. This doesn't fix a bug, but it simplifies the
4906 code away from its former Hollerith-constant appearance, and it's
4907 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4908 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4909
eb49b136
PE
4910 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4911 This didn't break anything, but it didn't help either.
4912 It's confusing to put a bogus integer in a place where the actual
4913 value does not matter.
9f62aeb1 4914 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4915 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4916
15375a22
PE
4917 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4918 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4919 implementation.
b61cc01c
PE
4920 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4921 We prefer signed types, and the value cannot exceed the EMACS_INT
4922 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4923 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4924 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4925 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4926
53b2623d
PE
4927 * indent.c (sane_tab_width): New function.
4928 (current_column, scan_for_column, Findent_to, position_indentation)
4929 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4930 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4931
51cab52b 4932 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4933
f2ed8a70
PE
4934 * lisp.h (lint_assume): New macro.
4935 * composite.c (composition_gstring_put_cache):
4936 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4937
abe80cc6
PE
4938 * editfns.c, insdel.c:
4939 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4940
b02c740e
PE
4941 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4942
ebc96716
PE
4943 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4944
b4e50fa0 4945 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4946 Use much-faster test for byte-length change.
311d5d7c 4947 Don't assume string byte-length fits in 'int'.
a4cf38e4 4948 Check that character arg fits in 'int'.
85461888 4949 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4950
c0c1ee9f
PE
4951 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4952
a498d7f4
PE
4953 * fns.c (concat): Catch string overflow earlier.
4954 Do not rely on integer wraparound.
4955
51cab52b
PE
4956 * dispextern.h (struct it.overlay_strings_charpos)
4957 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4958 * xdisp.c (forward_to_next_line_start)
4959 (back_to_previous_visible_line_start)
4960 (reseat_at_next_visible_line_start, next_element_from_buffer):
4961 Don't arbitrarily truncate the value of 'selective' to int.
4962
76031fad
PE
4963 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4964
5eb55db9
PE
4965 * composite.c: Don't truncate sizes to 'int'.
4966 (composition_gstring_p, composition_reseat_it)
4967 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4968 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4969 not EMACS_UINT, for indexes.
5eb55db9 4970
0703a717
PE
4971 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4972
d6202519
PE
4973 * buffer.c: Include <verify.h>.
4974 (struct sortvec.priority, struct sortstr.priority):
8961a454 4975 Now EMACS_INT, not int.
c20998a7 4976 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4977 (struct sortstr.size, record_overlay_string)
4978 (struct sortstrlist.size, struct sortlist.used):
4979 Don't truncate size to int.
4980 (record_overlay_string): Check for size-calculation overflow.
d6202519 4981 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4982
d5a19415
JM
49832011-06-22 Jim Meyering <meyering@redhat.com>
4984
029529ac 4985 Don't leak an XBM-image-sized buffer
d5a19415
JM
4986 * image.c (xbm_load): Free the image buffer after using it.
4987
a9041e6c
PE
49882011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 Port to Sun C.
4991 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4992 that Sun C diagnosed.
4993 * fns.c (secure_hash): Fix pointer signedness issue.
4994 * intervals.c (static_offset_intervals): New function.
4995 (offset_intervals): Use it.
4996
7f3f739f
LL
49972011-06-21 Leo Liu <sdl.web@gmail.com>
4998
4999 * deps.mk (fns.o):
5000 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5001 sha512.h.
5002
5003 * fns.c (secure_hash): Rename from crypto_hash_function and change
5004 the first arg to accept symbols.
5b66d427 5005 (Fsecure_hash): New primitive.
7f3f739f
LL
5006 (syms_of_fns): New symbols.
5007
76147d94
DD
50082011-06-20 Deniz Dogan <deniz@dogan.se>
5009
5010 * process.c (Fset_process_buffer): Clarify return value in
5011 docstring.
5012
7d7d0045
CY
50132011-06-18 Chong Yidong <cyd@stupidchicken.com>
5014
5015 * dispnew.c (add_window_display_history): Use BVAR.
5016
5017 * xdisp.c (debug_method_add): Use BVAR.
5018 (check_window_end, dump_glyph_matrix, dump_glyph)
5019 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5020
5021 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5022 Likewise.
5023
5024 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5025 check till after the cache is created in init_frame_faces.
5026
ff2bc410
SM
50272011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5028
5029 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5030
28177add
PE
50312011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5032
dd3482fe
PE
5033 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5034 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5035 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5036
393d71f3 5037 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5038 * fileio.c (Finsert_file_contents):
5039 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5040 Remove the old (too-loose) buffer overflow checks.
5041 They weren't needed, since make_gap checks for buffer overflow.
5042 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5043 The old code merely checked for Emacs fixnum overflow, and relied
5044 on undefined (wraparound) behavior. The new code avoids undefined
5045 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5046
2e6813b0 5047 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5048 Tune. Don't use wider integers than needed. Don't use alloca.
5049 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5050
599a9e4f
PE
5051 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5052
99561444
PE
5053 * insdel.c, lisp.h (buffer_overflow): New function.
5054 (insert_from_buffer_1, replace_range, replace_range_2):
5055 * insdel.c (make_gap_larger):
5056 * editfns.c (Finsert_char):
5057 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5058
28177add
PE
5059 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5060
e69dafad
PE
50612011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5062
4baa020d 5063 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5064
b1c46f02
PE
5065 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5066 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5067
e69dafad
PE
5068 * fileio.c: Don't assume EMACS_INT fits in off_t.
5069 (emacs_lseek): New static function.
5070 (Finsert_file_contents, Fwrite_region): Use it.
5071 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5072
566684ea
PE
5073 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5074
e6966cd6
PE
5075 * fns.c: Don't overflow int when computing a list length.
5076 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5077 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5078 truncation on 64-bit hosts. Check for QUIT every
5079 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5080 faster and is responsive enough.
5081 (Flength): Report an error instead of overflowing an integer.
5082 (Fsafe_length): Return a float if the value is not representable
5083 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5084 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5085 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5086
dd0b0efb
PE
5087 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5088 (header_size, word_size): New constants.
5089 (allocate_vectorlike): Don't check size overflow here.
5090 (allocate_vector): Check it here instead, since this is the only
5091 caller of allocate_vectorlike that could cause overflow.
5092 Check that the new vector's length is representable as a fixnum.
5093
86fe5cfe
PE
5094 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5095 The previous code was bogus. For example, next_almost_prime (32)
5096 returned 39, which is undesirable as it is a multiple of 3; and
5097 next_almost_prime (24) returned 25, which is a multiple of 5 so
5098 why was the code bothering to check for multiples of 7?
5099
80e88859
PE
5100 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5101
4a2f0ad6
PE
5102 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5103
f66c7cf8
PE
5104 Variadic C functions now count arguments with ptrdiff_t.
5105 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5106 Back then I didn't know that the Emacs coding style prefers signed int.
5107 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5108 were being counted with int, which may truncate counts on 64-bit
5109 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5110 * lisp.h (struct Lisp_Subr.function.aMANY)
5111 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5112 Arg counts are now ptrdiff_t, not size_t.
5113 All variadic functions and their callers changed accordingly.
5114 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5115 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5116 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5117 * callint.c (Fcall_interactively): Check arg count for overflow,
5118 to avoid potential buffer overrun. Use signed char, not 'int',
5119 for 'varies' array, so that we needn't bother to check its size
5120 calculation for overflow.
5121 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5122 * eval.c (apply_lambda):
5123 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5124 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5125 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5126
a1759b76
PE
5127 * callint.c (Fcall_interactively): Don't use index var as event count.
5128
d96be9fc
PE
5129 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5130 * mem-limits.h (SIZE): Remove; no longer used.
5131
a690a978 5132 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5133
578c21e6
PE
5134 Remove unnecessary casts.
5135 * xterm.c (x_term_init):
5136 * xfns.c (x_set_border_pixel):
5137 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5138 These aren't needed now that we assume ANSI C.
5139
96f53c6c
PE
5140 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5141 It's more likely to cause problems (due to unsigned overflow)
5142 than to cure them.
5143
83c77d31
PE
5144 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5145
ee2079f1
PE
5146 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5147
6da65536
PE
5148 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5149
7147c4a4
PE
5150 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5151
193e32d9
PE
5152 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5153
e5533da6
PE
5154 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5155
9910e595
PE
5156 GLYPH_CODE_FACE returns EMACS_INT, not int.
5157 * dispextern.h (merge_faces):
5158 * xfaces.c (merge_faces):
01103c44
PE
5159 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5160 Don't assume EMACS_INT fits in int.
9910e595 5161
2638320e
PE
5162 * character.h (CHAR_VALID_P): Remove unused parameter.
5163 * fontset.c, lisp.h, xdisp.c: All uses changed.
5164
045eb8d9
PE
5165 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5166
c1f134b5
PE
5167 * fns.c (concat): Minor tuning based on overflow analysis.
5168 This doesn't fix any bugs. Use int to hold character, instead
5169 of constantly refetching from Emacs object. Use XFASTINT, not
5170 XINT, for value known to be a character. Don't bother comparing
5171 a single byte to 0400, as it's always less.
5172
395fcb93 5173 * floatfns.c (Fexpt):
327eeec8
PE
5174 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5175
abbd3d23
PE
5176 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5177 for characters.
5178
684a03ef
PE
5179 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5180
0fed43f3
PE
5181 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5182 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5183 incorrectly succeed when S was a string, because 4294967386 was
5184 truncated before it was used.
5185
8fd02eb7
PE
5186 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5187 Otherwise, an out-of-range integer could cause undefined behavior
5188 on a 64-bit host.
5189
f8c86b69
PE
5190 * composite.c: Use int, not EMACS_INT, for characters.
5191 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5192 EMACS_INT, for values that are known to be in character range.
5193 This doesn't fix any bugs but is the usual style inside Emacs and
5194 may generate better code on 32-bit machines.
5195
34206dd2
PE
5196 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5197 This is for reasons similar to the recent CHAR_STRING fix.
5198 * charset.c (Fencode_char): Check that character arg is actually
5199 a character. Pass an int to ENCODE_CHAR.
5200 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5201 wider than 'int', as a compile-time check to prevent future regressions
5202 in this area.
5203
c5958d4c 5204 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5205
5206 Make sure a 64-bit char is never passed to CHAR_STRING.
5207 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5208 by silently ignoring the top 32 bits, allowing some values
5209 that were far too large to be valid characters.
5210 * character.h: Include <verify.h>.
5211 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5212 arguments are no wider than unsigned, as a compile-time check
5213 to prevent future regressions in this area.
5214 * data.c (Faset):
01103c44 5215 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5216 (Fsubst_char_in_region):
5217 * fns.c (concat):
5218 * xdisp.c (decode_mode_spec_coding):
5219 Adjust to CHAR_STRING's new requirement.
5220 * editfns.c (Finsert_char, Fsubst_char_in_region):
5221 * fns.c (concat): Check that character args are actually
5222 characters. Without this test, these functions did the wrong
5223 thing with wildly out-of-range values on 64-bit hosts.
5224
d37ca623
PE
5225 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5226 These casts should not be needed on 32-bit hosts, either.
5227 * keyboard.c (read_char):
5228 * lread.c (Fload): Remove casts to unsigned.
5229
ea204efb
PE
5230 * lisp.h (UNSIGNED_CMP): New macro.
5231 This fixes comparison bugs on 64-bit hosts.
5232 (ASCII_CHAR_P): Use it.
5233 * casefiddle.c (casify_object):
01103c44 5234 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5235 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5236 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5237 * dispextern.h (FACE_FROM_ID):
5238 * keyboard.c (read_char): Use UNSIGNED_CMP.
5239
41cb286c
PE
5240 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5241 not to EMACS_INT, to avoid GCC warning.
5242
4a1b9832
PE
5243 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5244
55daad71
PE
5245 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5246 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5247 isn't needed on 32-bit machines.
8f95c75c 5248
01103c44
PE
5249 * buffer.c (Fgenerate_new_buffer_name):
5250 Use EMACS_INT for count, not int.
0ceccced 5251 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5252
5253 * data.c (Qcompiled_function): Now static.
5254
c6f072e7
PE
5255 * window.c (window_body_lines): Now static.
5256
20ce5912
PE
5257 * image.c (gif_load): Rename local to avoid shadowing.
5258
9c4c5f81
PE
5259 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5260 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5261 * alloc.c (make_save_value): Integer argument is now of type
5262 ptrdiff_t, not int.
5263 (mark_object): Use ptrdiff_t, not int.
5264 * lisp.h (pD): New macro.
5265 * print.c (print_object): Use it.
5266
c0c5c8ae
PE
5267 * alloc.c: Use EMACS_INT, not int, to count objects.
5268 (total_conses, total_markers, total_symbols, total_vector_size)
5269 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5270 (total_free_floats, total_floats, total_free_intervals)
5271 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5272 Now EMACS_INT, not int. All uses changed.
5273 (Fgarbage_collect): Compute overall total using a double, so that
5274 integer overflow is less likely to be a problem. Check for overflow
5275 when converting back to an integer.
5a25e253
PE
5276 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5277 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5278 These were 'int' variables that could overflow on 64-bit hosts;
5279 they were never used, so remove them instead of repairing them.
211a0b2a 5280 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5281 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5282 Previously, this ceilinged at INT_MAX, but that doesn't work on
5283 64-bit machines.
e46bb31a 5284 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5285
c78baabf 5286 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5287 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5288 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5289 when a (possibly-narrower) signed value would do just as well.
5290 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5291
c9d624c6
PE
5292 * alloc.c: Catch some string size overflows that we were missing.
5293 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5294 for convenience in STRING_BYTES_MAX.
5295 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5296 The definition here is exact; the one in lisp.h was approximate.
5297 (allocate_string_data): Check for string overflow. This catches
5298 some instances we weren't catching before. Also, it catches
5299 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5300 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5301 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5302
c9d624c6
PE
5303 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5304 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5305 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5306
353032ce
PE
5307 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5308
2bccce07
PE
5309 * alloc.c (Fmake_string): Check for out-of-range init.
5310
0ac30604
SM
53112011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5312
5313 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5314
c195f2de
JD
53152011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5316
5317 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5318 xg_get_default_scrollbar_width.
5319
5320 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5321 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5322 (style_changed_cb): Call update_theme_scrollbar_width and call
5323 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5324 all frames (Bug#8505).
5325 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5326 Call gtk_window_set_resizable if HAVE_GTK3.
5327 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5328 and height if HAVE_GTK3 (Bug#8505).
5329 (scroll_bar_width_for_theme): New variable.
5330 (update_theme_scrollbar_width): New function.
5331 (xg_get_default_scrollbar_width): Move code to
5332 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5333 (xg_initialize): Call update_theme_scrollbar_width.
5334
5335 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5336
5337 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5338
e10ac9f1
MR
53392011-06-12 Martin Rudalics <rudalics@gmx.at>
5340
5341 * frame.c (make_frame): Call other_buffer_safely instead of
5342 other_buffer.
5343
5344 * window.c (temp_output_buffer_show): Call display_buffer with
5345 second argument Vtemp_buffer_show_specifiers and reset latter
5346 immediately after the call.
5347 (Vtemp_buffer_show_specifiers): New variable.
5348 (auto_window_vscroll_p, next_screen_context_lines)
5349 (Vscroll_preserve_screen_position): Remove leading asterisks from
5350 doc-strings.
5351
2d3c217e 53522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5353
7b7f97e8 5354 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5355 * buffer.c (Qclone_number): Remove for now, as it's unused.
5356 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5357 (record_buffer): Remove unused local.
5358 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5359 (set_frame_buffer_list): Remove; unused.
5360 * frame.h (other_visible_frames): Remove decl.
5361 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5362 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5363 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5364 if HAVE_GPM.
5365 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5366 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5367 Define only if HAVE_GPM.
5368 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5369 (update_hints_inhibit): Remove; never set. All uses removed.
5370 * widgetprv.h (emacsFrameClassRec): Remove decl.
5371 * window.c (delete_deletable_window): Now returns void, since it
5372 wasn't returning anything.
5373 (compare_window_configurations): Remove unused locals.
5374 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5375 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5376 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5377 the same widths as pointers. This follows up on the 2011-05-06 patch.
5378 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5379 * xterm.h: Likewise.
5380 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5381
1384b89e
JB
53822011-06-12 Juanma Barranquero <lekktu@gmail.com>
5383
5384 * makefile.w32-in: Update dependencies.
5385 (LISP_H): Add lib/intprops.h.
5386
1100a63c
CY
53872011-06-11 Chong Yidong <cyd@stupidchicken.com>
5388
5389 * image.c (gif_load): Add animation frame delay to the metadata.
5390 (syms_of_image): Use DEFSYM. New symbol `delay'.
5391
6198ccd0
MR
53922011-06-11 Martin Rudalics <rudalics@gmx.at>
5393
5394 * window.c (delete_deletable_window): Re-add.
5395 (Fset_window_configuration): Rewrite to handle dead buffers and
5396 consequently deletable windows.
5397 (window_tree, Fwindow_tree): Remove. Supply functionality in
5398 window.el.
5399 (compare_window_configurations): Simplify code.
5400
b6e3633c
AS
54012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5402
1ab0dee5
AS
5403 * image.c (imagemagick_load_image): Fix type mismatch.
5404 (Fimagemagick_types): Likewise.
5405
b6e3633c
AS
5406 * window.h (replace_buffer_in_windows): Declare.
5407
9397e56f
MR
54082011-06-11 Martin Rudalics <rudalics@gmx.at>
5409
5410 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5411 Qclone_number. Remove external declaration of Qdelete_window.
5412 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5413 code.
640c8776
SM
5414 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5415 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5416 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5417 buffer list implementation.
5418 (other_buffer_safely): New function.
5419 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5420 calls to replace_buffer_in_windows and
5421 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5422 if allowed.
5423 (record_buffer): Inhibit quitting and rewrite using quittable
5424 functions. Run Qbuffer_list_update_hook if allowed.
5425 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5426 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5427 Move switch-to-buffer to window.el.
9397e56f
MR
5428 (bury-buffer): Move to window.el.
5429 (Vbuffer_list_update_hook): New variable.
5430
5431 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5432 section.
5433
5434 * window.h (resize_frame_windows): Move up in code.
5435 (Fwindow_frame): Remove EXFUN.
5436 (replace_buffer_in_all_windows): Remove prototype.
5437 (replace_buffer_in_windows_safely): Add prototype.
5438
5439 * window.c: Declare Qdelete_window static again. Move down
5440 declaration of select_count.
5441 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5442 (Fother_window): Move to window.el.
5443 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5444 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5445 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5446 window.el.
5447 (replace_buffer_in_windows): Implement by calling
5448 Qreplace_buffer_in_windows.
5449 (replace_buffer_in_all_windows): Remove with some functionality
5450 moved into replace_buffer_in_windows_safely.
5451 (replace_buffer_in_windows_safely): New function.
5452 (select_window_norecord, select_frame_norecord): Move in front
5453 of run_window_configuration_change_hook. Remove now obsolete
5454 declarations.
640c8776
SM
5455 (Fset_window_buffer): Rewrite doc-string.
5456 Call Qrecord_window_buffer.
9397e56f
MR
5457 (keys_of_window): Move binding for other-window to window.el.
5458
b50691aa
CY
54592011-06-11 Chong Yidong <cyd@stupidchicken.com>
5460
5461 * dispextern.h (struct image): Replace data member, whose int_val
5462 and ptr_val fields were not used by anything, with a single
5463 lisp_val object.
5464
5465 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5466 (gif_clear_image, gif_load, imagemagick_load_image)
5467 (gs_clear_image, gs_load): Callers changed.
5468
3f754b86
PE
54692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5470
cca69397
PE
5471 * buffer.h: Include <time.h>, for time_t.
5472 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5473
109e28d0
PE
5474 Fix minor problems found by static checking.
5475
60737f02
PE
5476 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5477
4b66faf3
PE
5478 Make identifiers static if they are not used in other modules.
5479 * data.c (Qcompiled_function, Qframe, Qvector):
5480 * image.c (QimageMagick, Qsvg):
5481 * minibuf.c (Qmetadata):
5482 * window.c (resize_window_check, resize_root_window): Now static.
5483 * window.h (resize_window_check, resize_root_window): Remove decls.
5484
109e28d0
PE
5485 * window.c (window_deletion_count, delete_deletable_window):
5486 Remove; unused.
46a4ce9e
PE
5487 (window_body_lines): Now static.
5488 (Fdelete_other_windows_internal): Mark vars as initialized.
5489 Make sure 'resize_failed' is initialized.
5490 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5491 (resize_window_apply): Remove unused local.
5492 * window.h (delete_deletable_window): Remove decl.
5493
109e28d0 5494 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5495 (imagemagick_load_image): Fix pointer signedness problem by changing
5496 last arg from unsigned char * to char *. All uses changed.
5497 Also, fix a local for similar reasons.
5498 Remove unused locals. Remove locals to avoid shadowing.
5499 (fn_rsvg_handle_free): Remove; unused.
5500 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5501 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5502
3f754b86
PE
5503 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5504
2547adb1
CY
55052011-06-10 Chong Yidong <cyd@stupidchicken.com>
5506
5507 * image.c (gif_load): Fix omitted cast error introduced by
5508 2011-06-06 change.
5509
2c8e37d4
MR
55102011-06-10 Martin Rudalics <rudalics@gmx.at>
5511
5512 * window.h (resize_proportionally, orig_total_lines)
5513 (orig_top_line): Remove from window structure.
5514 (set_window_height, set_window_width, change_window_heights)
5515 (Fdelete_window): Remove prototypes.
5516 (resize_frame_windows): Remove duplicate declaration.
5517
440a42e3
EZ
55182011-06-10 Eli Zaretskii <eliz@gnu.org>
5519
5520 * window.h (resize_frame_windows, resize_window_check)
5521 (delete_deletable_window, resize_root_window)
5522 (resize_frame_windows): Declare prototypes.
5523
5524 * window.c (resize_window_apply): Make definition be "static" to
5525 match the prototype.
5526
562dd5e9
MR
55272011-06-10 Martin Rudalics <rudalics@gmx.at>
5528
5529 * window.c: Remove declarations of Qwindow_size_fixed,
5530 window_min_size_1, window_min_size_2, window_min_size,
5531 size_window, window_fixed_size_p, enlarge_window, delete_window.
5532 Remove static from declaration of Qdelete_window, it's
5533 temporarily needed by Fbury_buffer.
5534 (replace_window): Don't assign orig_top_line and
5535 orig_total_lines.
5536 (Fdelete_window, delete_window): Remove. Window deletion is
5537 handled by window.el.
640c8776
SM
5538 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5539 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5540 (Fdelete_other_windows): Remove. Deleting other windows is
5541 handled by window.el.
5542 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5543 handled in window.el.
5544 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5545 Window minimum sizes are handled in window.el.
5546 (shrink_windows, size_window, set_window_height)
5547 (set_window_width, change_window_heights, window_height)
5548 (window_width, CURBEG, CURSIZE, enlarge_window)
5549 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5550 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5551 handled in window.el.
5552 (make_dummy_parent): Rename to make_parent_window and give it a
5553 second argument horflag.
5554 (make_window): Don't set resize_proportionally any more.
5555 (Fsplit_window): Remove. Windows are split in window.el.
5556 (save_restore_action, save_restore_orig_size)
5557 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5558 Resize mini windows in window.el.
5559 (grow_mini_window, shrink_mini_window): Implement by calling
5560 Qresize_root_window_vertically, resize_window_check and
5561 resize_window_apply.
640c8776
SM
5562 (saved_window, Fset_window_configuration, save_window_save):
5563 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5564 resize_proportionally.
5565 (window_min_height, window_min_width): Move to window.el.
5566 (keys_of_window): Move bindings for delete-other-windows,
5567 split-window, delete-window and enlarge-window to window.el.
5568
5569 * buffer.c: Temporarily extern Qdelete_window.
5570 (Fbury_buffer): Temporarily call Qdelete_window instead of
5571 Fdelete_window (Fbury_buffer will move to window.el soon).
5572
5573 * frame.c (set_menu_bar_lines_1): Remove code handling
5574 orig_top_line and orig_total_lines.
5575
5576 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5577 set_window_height but set heights directly.
5578 (change_frame_size_1): Use resize_frame_windows.
5579
5580 * xdisp.c (init_xdisp): Don't use set_window_height but set
5581 heights directly.
5582
640c8776
SM
5583 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5584 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5585 run_window_configuration_change_hook.
5586
5587 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5588 instead of change_window_heights and run
5589 run_window_configuration_change_hook.
5590
1a13852e
MR
55912011-06-09 Martin Rudalics <rudalics@gmx.at>
5592
5593 * window.c (replace_window): Rename second argument REPLACEMENT to
5594 NEW. New third argument SETFLAG. Rewrite.
5595 (delete_window, make_dummy_parent): Call replace_window with
5596 third argument 1.
5597 (window_list_1): Move down in code.
5598 (run_window_configuration_change_hook): Move set_buffer part
5599 before select_frame_norecord part in order to unwind correctly.
5600 Rename count1 to count.
5601 (recombine_windows, delete_deletable_window, resize_root_window)
5602 (Fdelete_other_windows_internal)
5603 (Frun_window_configuration_change_hook, make_parent_window)
5604 (resize_window_check, resize_window_apply, Fresize_window_apply)
5605 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5606 (Fdelete_window_internal, Fresize_mini_window_internal):
5607 New functions.
1a13852e
MR
5608 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5609
f3d1777e
MR
56102011-06-08 Martin Rudalics <rudalics@gmx.at>
5611
496e208e
MR
5612 * window.h (window): Add some new members to window structure -
5613 normal_lines, normal_cols, new_total, new_normal, clone_number,
5614 splits, nest, prev_buffers, next_buffers.
5615 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5616 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5617
f3d1777e
MR
5618 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5619 Remove.
496e208e
MR
5620 (make_dummy_parent): Set new members of windows structure.
5621 (make_window): Move down in code. Handle new members of window
5622 structure.
5623 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5624 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5625 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5626 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5627 (Fset_window_next_buffers, Fset_window_clone_number):
5628 New functions.
496e208e
MR
5629 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5630 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5631 Doc-string fixes.
5632 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5633 Argument WINDOW can be now internal window too.
5634 (Fwindow_use_time): Move up in code.
5635 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5636 Rewrite doc-string.
5637 (Fset_window_configuration, saved_window)
5638 (Fcurrent_window_configuration, save_window_save): Handle new
5639 members of window structure.
b9e809c2
MR
5640 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5641 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5642 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5643 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5644 Qget_mru_window, Qresize_root_window,
5645 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5646 Qauto_buffer_name; staticpro them.
f3d1777e 5647
abde8f8c
MR
56482011-06-07 Martin Rudalics <rudalics@gmx.at>
5649
5650 * window.c (Fwindow_total_size, Fwindow_left_column)
5651 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5652 (Fwindow_list_1): New functions.
5653 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5654 (Fwindow_width, Fscroll_left, Fscroll_right):
5655 Use window_body_cols instead of window_box_text_cols.
5656 (delete_window, Fset_window_configuration):
5657 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5658 (delete_all_subwindows): Take a window as argument and not a
5659 structure. Rewrite.
190b47e6
MR
5660 (window_loop): Remove handling of GET_LRU_WINDOW and
5661 GET_LARGEST_WINDOW.
5662 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5663
5664 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5665 window_box_text_cols. delete_all_subwindows now takes a
5666 Lisp_Object as argument.
abde8f8c 5667
640c8776
SM
5668 * indent.c (compute_motion, Fcompute_motion):
5669 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5670
fa8a67e6
MR
5671 * frame.c (delete_frame): Call delete_all_subwindows with root
5672 window as argument.
5673
a54e3482
DC
56742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5675
5676 * fns.c (Fputhash): Document return value.
5677
60002bf5
CY
56782011-06-06 Chong Yidong <cyd@stupidchicken.com>
5679
5680 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5681
0c671da6 56822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5683
b862a52a 5684 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5685
be44ca6c
PE
5686 Check for overflow when converting integer to cons and back.
5687 * charset.c (Fdefine_charset_internal, Fdecode_char):
5688 Use cons_to_unsigned to catch overflow.
5689 (Fencode_char): Use INTEGER_TO_CONS.
5690 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5691 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5692 * data.c (long_to_cons, cons_to_long): Remove.
5693 (cons_to_unsigned, cons_to_signed): New functions.
5694 These signal an error for invalid or out-of-range values.
5695 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5696 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5697 * font.c (Ffont_variation_glyphs):
5698 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5699 * lisp.h: Include <intprops.h>.
5700 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5701 (cons_to_signed, cons_to_unsigned): New decls.
5702 (long_to_cons, cons_to_long): Remove decls.
5703 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5704 (Fprimitive_undo): Use CONS_TO_INTEGER.
5705 * xfns.c (Fx_window_property): Likewise.
5706 * xselect.c: Include <limits.h>.
5707 (x_own_selection, selection_data_to_lisp_data):
5708 Use INTEGER_TO_CONS.
5709 (x_handle_selection_request, x_handle_selection_clear)
5710 (x_get_foreign_selection, Fx_disown_selection_internal)
5711 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5712 (lisp_data_to_selection_data): Use cons_to_unsigned.
5713 (x_fill_property_data): Use cons_to_signed.
5714 Report values out of range.
5715
d1f3d2af
PE
5716 Check for buffer and string overflow more precisely.
5717 * buffer.h (BUF_BYTES_MAX): New macro.
5718 * lisp.h (STRING_BYTES_MAX): New macro.
5719 * alloc.c (Fmake_string):
5720 * character.c (string_escape_byte8):
5721 * coding.c (coding_alloc_by_realloc):
5722 * doprnt.c (doprnt):
5723 * editfns.c (Fformat):
5724 * eval.c (verror):
5725 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5726 since they may not be the same number.
5727 * editfns.c (Finsert_char):
5728 * fileio.c (Finsert_file_contents):
5729 Likewise for BUF_BYTES_MAX.
5730
dd52fcea
PE
5731 * image.c: Use ptrdiff_t, not int, for sizes.
5732 (slurp_file): Switch from int to ptrdiff_t.
5733 All uses changed.
5734 (slurp_file): Check that file size fits in both size_t (for
5735 malloc) and ptrdiff_t (for sanity and safety).
5736
7f9bbdbb
PE
5737 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5738 if b->modtime has its maximal value.
5739
dfe18f82
PE
5740 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5741
84acfcf0
PE
5742 Don't assume time_t can fit into int.
5743 * buffer.h (struct buffer.modtime): Now time_t, not int.
5744 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5745 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5746
ccd9a01a
PE
5747 Minor fixes for signed vs unsigned integers.
5748 * character.h (MAYBE_UNIFY_CHAR):
5749 * charset.c (maybe_unify_char):
5750 * keyboard.c (read_char, reorder_modifiers):
5751 XINT -> XFASTINT, since the integer must be nonnegative.
5752 * ftfont.c (ftfont_spec_pattern):
5753 * keymap.c (access_keymap, silly_event_symbol_error):
5754 XUINT -> XFASTINT, since the integer must be nonnegative.
5755 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5756 since it makes no difference and we prefer signed.
5757 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5758 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5759 nonnegative.
5760
d6d100dd
SM
57612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5762
5763 * window.h (Fwindow_frame): Declare.
5764
2b6148e4
PE
57652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5768 (SPARE_MEMORY): Always define.
5769 (LARGE_REQUEST): Remove.
5770 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5771
f230ecc9
MR
57722011-06-06 Martin Rudalics <rudalics@gmx.at>
5773
727e958e
MR
5774 * lisp.h: Move EXFUNS for Fframe_root_window,
5775 Fframe_first_window and Fset_frame_selected_window to window.h.
5776
5777 * window.h: Move EXFUNS for Fframe_root_window,
5778 Fframe_first_window and Fset_frame_selected_window here from
5779 lisp.h.
5780
5781 * frame.c (Fwindow_frame, Fframe_first_window)
5782 (Fframe_root_window, Fframe_selected_window)
5783 (Fset_frame_selected_window): Move to window.c.
5784 (Factive_minibuffer_window): Move to minibuf.c.
5785 (Fother_visible_frames_p): New function.
5786
5787 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5788
f230ecc9
MR
5789 * window.c (decode_window, decode_any_window): Move up in code.
5790 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5791 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5792 (Fwindow_buffer): Move up and rewrite doc-string.
5793 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5794 (Fwindow_prev): New functions.
727e958e
MR
5795 (Fwindow_frame): Move here from frame.c. Accept any window as
5796 argument.
5797 (Fframe_root_window, Fframe_first_window)
5798 (Fframe_selected_window): Move here from frame.c. Accept frame
5799 or arbitrary window as argument. Update doc-strings.
5800 (Fminibuffer_window): Move up in code.
5801 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5802 (Fset_frame_selected_window): Move here from frame.c.
5803 Marginal rewrite.
727e958e
MR
5804 (Fselected_window, select_window, Fselect_window): Move up in
5805 code. Minor doc-string fixes.
f230ecc9 5806
4d09bcf6
PE
58072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5808
5809 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5810 Do not assume that spare memory exists; that assumption is valid
5811 only if SYSTEM_MALLOC.
5812 (LARGE_REQUEST): New macro, so that the issue of large requests
5813 is separated from the issue of spare memory.
5814
810928a2
AS
58152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5816
172418ad
AS
5817 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5818 format. (Bug#8806)
5819
43f862f7
AS
5820 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5821
810928a2
AS
5822 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5823 before statements.
5824
a059fe24
JD
58252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5826
5827 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5828
5829 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5830
5831 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5832 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5833
989bf368
JB
58342011-06-05 Juanma Barranquero <lekktu@gmail.com>
5835
5836 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5837
4b80f674
CY
58382011-06-04 Chong Yidong <cyd@stupidchicken.com>
5839
5840 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5841 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5842 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5843 New error handlers.
4b80f674
CY
5844 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5845 Obey Vx_select_enable_clipboard_manager. Catch errors in
5846 x_clipboard_manager_save (Bug#8779).
5847 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5848 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5849
99a33b77 58502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5851
5852 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5853
99a33b77 58542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5855
5856 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5857 in the current matrix if keep_current_p is non-zero.
5858
8264569d
EZ
58592011-06-04 Eli Zaretskii <eliz@gnu.org>
5860
5861 * bidi.c (bidi_level_of_next_char): Fix last change.
5862
57f97249
EZ
58632011-06-03 Eli Zaretskii <eliz@gnu.org>
5864
fec2107c 5865 Support bidi reordering of text covered by display properties.
57f97249 5866
fec2107c
EZ
5867 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5868 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5869 (bidi_cache_search, bidi_cache_iterator_state)
5870 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5871 (bidi_level_of_next_char, bidi_move_to_visually_next):
5872 Support character positions inside a run of characters covered by a
fec2107c
EZ
5873 display string.
5874 (bidi_paragraph_init, bidi_resolve_explicit_1)
5875 (bidi_level_of_next_char): Call bidi_fetch_char and
5876 bidi_fetch_char_advance instead of FETCH_CHAR and
5877 FETCH_CHAR_ADVANCE.
5878 (bidi_init_it): Initialize new members.
5879 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5880 definitions.
5881 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5882 instead of using explicit *_CHAR codes.
d6d100dd
SM
5883 (bidi_resolve_explicit, bidi_resolve_weak):
5884 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5885 bidirectional text is supported only in multibyte buffers.
5886 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5887 it to initialize the frame_window_p member of struct bidi_it.
5888 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5889 (bidi_resolve_explicit, bidi_resolve_weak)
5890 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5891 bidi_it->nchars is non-positive.
5892 (bidi_level_of_next_char): Don't try to lookup the cache for the
5893 next/previous character if nothing is cached there yet, or if we
5894 were just reseat()'ed to a new position.
c40e2fb2 5895
0e14fe90
EZ
5896 * xdisp.c (set_cursor_from_row): Set start and stop points
5897 according to the row's direction when priming the loop that looks
5898 for the glyph on which to display cursor.
5899 (single_display_spec_intangible_p): Function deleted.
5900 (display_prop_intangible_p): Reimplement to call
5901 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5902 Accept 3 additional arguments needed by handle_display_spec.
5903 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5904 values: lists, `(when COND...)' forms, etc.
5905 (single_display_spec_string_p): Support property values that are
5906 lists with the argument STRING its top-level element.
5907 (display_prop_string_p): Fix the condition for processing a
5908 property that is a list to be consistent with handle_display_spec.
fec2107c 5909 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5910 last portion of handle_display_prop.
5911 (compute_display_string_pos): Accept additional argument
5912 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5913 value of a `display' property is a "replacing spec".
5914 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5915 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5916 the display property, but just return a value indicating whether
5917 the display property will replace the characters it covers.
5918 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5919 frame_window_p members of struct bidi_it.
d6d100dd
SM
5920 (compute_display_string_pos, compute_display_string_end):
5921 New functions.
fec2107c
EZ
5922 (push_it): Accept second argument POSITION, where pop_it should
5923 jump to continue iteration.
5924 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5925
fec2107c
EZ
5926 * keyboard.c (adjust_point_for_property): Adjust the call to
5927 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5928
5929 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5930 (bidi_init_it): Update prototypes.
5931 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5932 (compute_display_string_pos, compute_display_string_end):
5933 Declare prototypes.
fec2107c
EZ
5934 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5935 EMACS_INT.
fc6f18ce 5936
40087514 59372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5938
57f53182
PE
5939 Malloc failure behavior now depends on size of allocation.
5940 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5941 * lisp.h: Change signatures accordingly.
5942 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5943 All callers changed. (Bug#8762)
5944
5945 * gnutls.c: Use Emacs's memory allocators.
5946 Without this change, the gnutls library would invoke malloc etc.
5947 directly, which causes problems on non-SYNC_INPUT hosts, and which
5948 runs afoul of improving memory_full behavior. (Bug#8761)
5949 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5950 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5951 xfree instead of the default malloc, realloc, free.
5952 (Fgnutls_boot): No need to check for memory allocation failure,
5953 since xmalloc does that for us.
5954
ac32cd99 5955 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5956 * category.c (hash_get_category_set):
5957 * ccl.c (ccl_driver):
5958 * charset.c (Fdefine_charset_internal):
5959 * charset.h (struct charset.hash_index):
5960 * composite.c (get_composition_id, gstring_lookup_cache)
5961 (composition_gstring_put_cache):
5962 * composite.h (struct composition.hash_index):
5963 * dispextern.h (struct image.hash):
5964 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5965 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5966 (hashfn_equal, hashfn_user_defined, make_hash_table)
5967 (maybe_resize_hash_table, hash_lookup, hash_put)
5968 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5969 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5970 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5971 * image.c (make_image, search_image_cache, lookup_image)
5972 (xpm_put_color_table_h):
5973 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5974 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5975 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5976 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5977 * alloc.c (allocate_vectorlike):
5978 Check for overflow in vector size calculations.
5979 * ccl.c (ccl_driver):
5980 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5981 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5982 need to be updated by these changes.
40087514
PE
5983 * fns.c (make_hash_table, maybe_resize_hash_table):
5984 Check for integer overflow with large hash tables.
0de4bb68
PE
5985 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5986 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5987 (SXHASH_REDUCE): New macro.
5988 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5989 Use it instead of discarding useful hash info with large hash values.
5990 (sxhash_float): New function.
5991 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5992 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5993 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5994 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5995 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5996 Adjust signatures to match updated version of code.
5997 (consing_since_gc): Now EMACS_INT, since a single hash table can
5998 use more than INT_MAX bytes.
5999
698d32e2
DN
60002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6001
6002 Make it possible to build with GCC-4.6+ -O2 -flto.
6003
6004 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6005
fd6fa53f
SM
60062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6007
6008 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6009 Call minibuffer-inactive-mode.
6010
864db017
JB
60112011-05-31 Juanma Barranquero <lekktu@gmail.com>
6012
6013 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6014 Update dependencies.
6015
2ad0baf4
DN
60162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6017
6018 * data.c (init_data): Remove code for UTS, this system is not
6019 supported anymore.
6020
4fcc2638
DN
60212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6022
6023 Don't force ./temacs to start in terminal mode.
6024
6025 * frame.c (make_initial_frame): Initialize faces in all cases, not
6026 only when CANNOT_DUMP is defined.
6027 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6028
c56e0fd5
DN
60292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6030
6031 * dispnew.c (add_window_display_history): Use const for the string
6032 pointer. Remove declaration, not needed.
6033
333d54da 60342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6035
55d4c1b2 6036 Use 'inline', not 'INLINE'.
333d54da 6037 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6038 * alloc.c, fontset.c (INLINE): Remove.
6039 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6040 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6041 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6042 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6043 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6044
738db178
DN
60452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6046
6047 Make it possible to run ./temacs.
6048
6049 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6050 syms_of_callproc does the same thing. Remove test for
6051 "initialized", do it in the caller.
6052 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6053
620c53a6
SM
60542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6055
6056 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6057 (read_minibuf): Use get_minibuffer.
6058 (syms_of_minibuf): Use DEFSYM.
6059 (Qmetadata): New var.
6060 * data.c (Qbuffer): Don't make it static.
6061 (syms_of_data): Use DEFSYM.
6062
e003a292
PE
60632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6066 (CCL_CODE_MIN): New macro.
6067
ed008a6d
PE
60682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6069
3687c2ef
PE
6070 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6071
ed008a6d
PE
6072 * eval.c (Qdebug): Now static.
6073 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6074 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6075 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6076
d66c4c7c
CY
60772011-05-29 Chong Yidong <cyd@stupidchicken.com>
6078
6079 * image.c: Various fixes to ImageMagick code comments.
6080 (Fimagemagick_types): Doc fix.
6081
5fbc2025
PE
60822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6083
0196f88a
PE
6084 Minor fixes prompted by GCC 4.6.0 warnings.
6085
6086 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6087
5fbc2025
PE
6088 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6089 (x_clipboard_manager_save_all): Move extern decl to ...
6090 * xterm.h: ... here, so that it can be checked for consistency.
6091
1dd3c2d9
CY
60922011-05-29 Chong Yidong <cyd@stupidchicken.com>
6093
6094 * xselect.c (x_clipboard_manager_save_frame)
6095 (x_clipboard_manager_save_all): New functions.
6096 (Fx_clipboard_manager_save): Lisp function deleted.
6097
6098 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6099 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6100
6101 * xterm.h: Update prototype.
6102
5ba6571d
WX
61032011-05-28 William Xu <william.xwl@gmail.com>
6104
6105 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6106 exiting (Bug#8239).
6107
3eaff834
JM
61082011-05-28 Jim Meyering <meyering@redhat.com>
6109
e1900994 6110 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6111 * fns.c (to_uchar): Define.
6112 (crypto_hash_function): Use it to convert some newly-signed
6113 variables to unsigned, to avoid sign-extension bugs. For example,
6114 without this change, (md5 "truc") would evaluate to
6115 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6116 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6117 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6118
0f6990a7
PE
61192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6120
6121 Integer overflow fixes.
c8a9ca5a 6122
08686060
PE
6123 * dbusbind.c: Serial number integer overflow fixes.
6124 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6125 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6126 to hold a serial number that is too large for a fixnum.
6127 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6128 Check for serial numbers out of range. Decode any serial number
59568bf0 6129 that was so large that it became a float. (Bug#8722)
08686060 6130
2d1fc3c7
PE
6131 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6132 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6133 Use XFASTINT rather than XUINT when numbers are nonnegative.
6134 (xd_append_arg, Fdbus_method_return_internal):
6135 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6136 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6137 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6138 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6139 (Bug#8722)
2d1fc3c7 6140
c8a9ca5a
PE
6141 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6142
519e1d69
PE
6143 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6144
6df6ae42 6145 ccl: Add integer overflow checks.
30569699
PE
6146 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6147 (IN_INT_RANGE): New macros.
6148 (ccl_driver): Use them to check for integer overflow when
6149 decoding a CCL program. Many of the new checks are whether XINT (x)
6150 fits in int; it doesn't always, on 64-bit hosts. The new version
6151 doesn't catch all possible integer overflows, but it's an
847044ea 6152 improvement. (Bug#8719)
30569699 6153
c11285dc
PE
6154 * alloc.c (make_event_array): Use XINT, not XUINT.
6155 There's no need for unsigned here.
6156
fdccd48e
PE
6157 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6158 This follows up to the 2011-05-06 change that substituted uintptr_t
6159 for EMACS_INT. This case wasn't caught back then.
6160
37910ab2
PE
6161 Rework Fformat to avoid integer overflow issues.
6162 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6163 now (part of C89). Include <verify.h>.
6164 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6165 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6166 (Fformat): Avoid the prepass trying to compute sizes; it was only
6167 approximate and thus did not catch overflow reliably. Instead, walk
6168 through the format just once, formatting and computing sizes as we go,
6169 checking for integer overflow at every step, and allocating a larger
6170 buffer as needed. Keep track separately whether the format is
6171 multibyte. Keep only the most-recently calculated precision, rather
6172 than them all. Record whether each argument has been converted to
6173 string. Use EMACS_INT, not int, for byte and char and arg counts.
6174 Support field widths and precisions larger than INT_MAX. Avoid
6175 sprintf's undefined behavior with conversion specifications such as %#d
6176 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6177 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6178 formatting out-of-range floating point numbers with int
9173deec 6179 formats. (Bug#8668)
37910ab2 6180
2e6578fb
PE
6181 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6182
0ae6bdee
PE
6183 * data.c: Avoid integer truncation in expressions involving floats.
6184 * data.c: Include <intprops.h>.
6185 (arith_driver): When there's an integer overflow in an expression
6186 involving floating point, convert the integers to floating point
6187 so that the resulting value does not suffer from catastrophic
6188 integer truncation. For example, on a 64-bit host (* 4
6189 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6190 Do not rely on undefined behavior after integer overflow.
6191
de883a70
PE
6192 merge count_size_as_multibyte, parse_str_to_multibyte
6193 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6194 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6195 Check for integer overflow.
6196 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6197 since it's now a duplicate of the other. This is more of
6198 a character than a buffer op, so better that it's in character.c.
6199 * fns.c, print.c: Adjust to above changes.
6200
2ff916cb
PE
62012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6202
6203 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6204
f1b54466
PE
62052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6206
fb1ac845
PE
6207 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6208 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6209 (x_clipboard_manager_save): Now static.
6210 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6211
f1b54466
PE
6212 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6213 (crypto_hash_function): Now static.
6214 Fix pointer signedness problems. Avoid unnecessary initializations.
6215
a9f737ee
CY
62162011-05-27 Chong Yidong <cyd@stupidchicken.com>
6217
6218 * termhooks.h (Vselection_alist): Make it terminal-local.
6219
6220 * terminal.c (create_terminal): Initialize it.
6221
6222 * xselect.c: Support for clipboard managers.
6223 (Vselection_alist): Move to termhooks.h as terminal-local var.
6224 (LOCAL_SELECTION): New macro.
6225 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6226 (symbol_to_x_atom): Remove gratuitous arg.
6227 (x_handle_selection_request, lisp_data_to_selection_data)
6228 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6229 (x_own_selection, x_get_local_selection, x_convert_selection):
6230 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6231 (some_frame_on_display): Delete unused function.
6232 (Fx_own_selection_internal, Fx_get_selection_internal)
6233 (Fx_disown_selection_internal, Fx_selection_owner_p)
6234 (Fx_selection_exists_p): New optional frame arg.
6235 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6236 (x_handle_selection_clear): Don't treat other terminals with the
6237 same keyboard specially. Use the terminal-local Vselection_alist.
6238 (x_clear_frame_selections): Use Frun_hook_with_args.
6239
6240 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6241
6242 * xterm.h: Add support for those atoms.
6243
e067f0c1
CY
62442011-05-26 Chong Yidong <cyd@stupidchicken.com>
6245
6246 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6247 (converted_selections, conversion_fail_tag): New global variables.
6248 (x_selection_request_lisp_error): Free the above.
6249 (x_get_local_selection): Remove unnecessary code.
6250 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6251 of converted selections stored in converted_selections.
6252 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6253 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6254 (x_convert_selection): New function.
6255 (x_handle_selection_event): Simplify.
6256 (x_get_foreign_selection): Don't ignore incoming requests while
6257 waiting for an answer; this will fail when we implement
6258 SAVE_TARGETS, and seems unnecessary anyway.
6259 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6260 (Vx_sent_selection_functions): Doc fix.
6261
0f4aebc0
LL
62622011-05-26 Leo Liu <sdl.web@gmail.com>
6263
6264 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6265
e61124cd
YM
62662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6267
6268 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6269
6270 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6271 for fringe update if it has periodic bitmap.
ac389d0c 6272 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6273 and fringe_bitmap_periodic_p.
6274
6275 * fringe.c (get_fringe_bitmap_data): New function.
6276 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6277 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6278 row. Mark glyph row for fringe update if periodicity changed.
6279
6280 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6281 for fringe update unless it has periodic bitmap.
6282
f16d9837
KH
62832011-05-25 Kenichi Handa <handa@m17n.org>
6284
6285 * xdisp.c (get_next_display_element): Set correct it->face_id for
6286 a static composition.
6287
e1b90ef6
LL
62882011-05-24 Leo Liu <sdl.web@gmail.com>
6289
6290 * deps.mk (fns.o):
6291 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6292
6293 * fns.c (crypto_hash_function, Fsha1): New function.
6294 (Fmd5): Use crypto_hash_function.
6295 (syms_of_fns): Add Ssha1.
6296
7400048f
PE
62972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6298
6299 * gnutls.c: Remove unused macros.
6300 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6301 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6302 Remove macros that are defined and never used.
6303 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6304
abb71cf4
CY
63052011-05-22 Chong Yidong <cyd@stupidchicken.com>
6306
6307 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6308 (Fx_get_selection_internal): Minor cleanup.
6309 (Fx_own_selection_internal): Rename arguments for consistency with
6310 select.el.
6311
6307db39
PE
63122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6313
6314 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6315
f3d4e0a4
CY
63162011-05-22 Chong Yidong <cyd@stupidchicken.com>
6317
6318 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6319
4d8ade89
YM
63202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6321
6322 * dispnew.c (scrolling_window): Don't exclude the case that the
6323 last enabled row in the desired matrix touches the bottom boundary.
6324
32078c8d
GM
63252011-05-21 Glenn Morris <rgm@gnu.org>
6326
6327 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6328 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6329 and add some more files.
32078c8d 6330
7285dc67
EZ
63312011-05-20 Eli Zaretskii <eliz@gnu.org>
6332
6333 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6334 report_file_error introduced by the change from 2011-05-07.
6335
89d1bd22
PE
63362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6337
6338 * systime.h (Time): Define only if emacs is defined.
6339 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6340 where the include path doesn't have X11/X.h by default. See
6341 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6342
cd394be1 63432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6344
6345 * composite.c (find_automatic_composition): Fix previous change.
6346
b9704ad9
GM
63472011-05-20 Glenn Morris <rgm@gnu.org>
6348
6349 * lisp.mk: New file, split from Makefile.in.
6350 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6351 (shortlisp): Remove.
6352 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6353
4a720484
GM
63542011-05-19 Glenn Morris <rgm@gnu.org>
6355
6356 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6357 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6358 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6359 (lisp): Set the order to that of loadup.el.
6360 (shortlisp): Make it a copy of $lisp.
6361 (SOME_MACHINE_LISP): Remove.
6362 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6363 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6364
a28d4396
KH
63652011-05-18 Kenichi Handa <handa@m17n.org>
6366
6367 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6368 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6369 (find_automatic_composition): Mostly rewrite for efficiency.
6370
a2b1fa8e
JB
63712011-05-18 Juanma Barranquero <lekktu@gmail.com>
6372
6373 * makefile.w32-in: Update dependencies.
6374
8e1f5610
CS
63752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6376
6377 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6378 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6379
7025ee00 63802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6381
cdfa6eab
PE
6382 Fix some integer overflow issues, such as string length overflow.
6383
06d6db33
PE
6384 * insdel.c (count_size_as_multibyte): Check for string overflow.
6385
2b4560a8
PE
6386 * character.c (lisp_string_width): Check for string overflow.
6387 Use EMACS_INT, not int, for string indexes and lengths; in
6388 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6389 the resulting string length overflows an EMACS_INT; instead,
6390 report a string overflow if no precision given. When checking for
6391 precision exhaustion, use a check that cannot possibly have
6392 integer overflow. (Bug#8675)
6393 * character.h (lisp_string_width): Adjust to new signature.
6394
cb93f9be
PE
6395 * alloc.c (string_overflow): New function.
6396 (Fmake_string): Use it. This doesn't change behavior, but saves
6397 a few bytes and will simplify future changes.
6398 * character.c (string_escape_byte8): Likewise.
6399 * lisp.h (string_overflow): New decl.
6400
1a1f3366
PE
6401 Fixups, following up to the user-interface timestamp change.
6402 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6403 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6404 * msdos.c (mouse_get_pos): Likewise.
6405 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6406 * w32gui.h (Time): Define by including "systime.h" rather than by
6407 declaring it ourselves. (Bug#8664)
6408
d4e3e4d3
PE
6409 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6410 * image.c (clear_image_cache): Likewise.
6411
f6a24d19
PE
6412 * term.c (term_mouse_position): Don't assume time_t wraparound.
6413
08dc5ae6
PE
6414 Be more systematic about user-interface timestamps.
6415 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6416 and sometimes 'EMACS_UINT', to represent these timestamps.
6417 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6418 This makes the code easier to follow, and makes it easier to catch
6419 integer overflow bugs such as Bug#8664.
6420 * frame.c (Fmouse_position, Fmouse_pixel_position):
6421 Use Time, not unsigned long, for user-interface timestamps.
6422 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6423 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6424 * keyboard.h (last_event_timestamp): Likewise.
6425 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6426 * menu.h (xmenu_show): Likewise.
6427 * term.c (term_mouse_position): Likewise.
6428 * termhooks.h (struct input_event.timestamp): Likewise.
6429 (struct terminal.mouse_position_hook): Likewise.
6430 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6431 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6432 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6433 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6434 what it was before.
6435 * menu.h, termhooks.h: Include "systime.h", for Time.
6436
8e55734a
PE
6437 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6438 Don't assume that the difference between two unsigned long values
6439 can fit into an integer. At this point, we know button_down_time
6440 <= event->timestamp, so the difference must be nonnegative, so
6441 there's no need to cast the result if double-click-time is
6442 nonnegative, as it should be; check that it's nonnegative, just in
6443 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6444 apart (about 25 days). (Bug#8664)
8e55734a 6445
841f1b75 6446 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6447 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6448
3e26f69c
PE
6449 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6450 that always fit in int. Use a sentinel instead of a counter, to
6451 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6452 * frame.h (struct frame): Use int for menu_bar_items_used
6453 instead of EMACS_INT, since it always fits in int.
3e26f69c 6454
5cc152c0
PE
6455 * menu.c (grow_menu_items): Check for int overflow.
6456
d89eb65e
PE
6457 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6458
5235bd3e
PE
6459 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6460 Before, the code was not consistent. These values cannot exceed
6461 2**31 - 1 so there's no need to make them unsigned.
6462 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6463 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6464 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6465 as modifiers.
6466 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6467
bc827e23
PE
6468 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6469 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6470 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6471 presumably because the widths might not match.
6472
78eb494e
PE
6473 * window.c (size_window): Avoid needless test at loop start.
6474
04f2d78b
CB
64752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6476
6477 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6478
d2fc7e3d 64792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6480
6481 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6482
d2fc7e3d 64832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6484
6485 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6486 `width' to `bar_area_x' and `bar_area_width', respectively.
6487 (x_scroll_run): Take account of fringe background extension.
6488
04f2d78b
CB
6489 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6490 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6491 `bar_area_width', respectively.
6492 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6493 background extension.
6494
79b70037
GM
64952011-05-10 Jim Meyering <meyering@redhat.com>
6496
6497 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6498
2f142cc5
JB
64992011-05-10 Juanma Barranquero <lekktu@gmail.com>
6500
6501 * image.c (Finit_image_library): Return t for built-in image types,
6502 like pbm and xbm. (Bug#8640)
6503
57679c86
AS
65042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6505
6506 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6507
888c9e86
EZ
65082011-05-07 Eli Zaretskii <eliz@gnu.org>
6509
b0512a1d
EZ
6510 * w32console.c (Fset_screen_color): Doc fix.
6511 (Fget_screen_color): New function.
6512 (syms_of_ntterm): Defsubr it.
6513
7285dc67
EZ
6514 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6515 unlink the temporary file if Fcall_process didn't create it in the
6516 first place.
6517 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6518 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6519 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6520 cue to call_process_cleanup not to close that handle.
6521
4d3fcc8e
BK
65222011-05-07 Ben Key <bkey76@gmail.com>
6523
6524 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6525 one of two shell specific rules, either bootstrap-temacs-CMD or
6526 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6527 to the previous implementation of the bootstrap-temacs rule.
6528 The bootstrap-temacs-CMD rule is similar to the previous
6529 implementation of the bootstrap-temacs rule except that it
6530 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6531 variable.
6532
6533 These changes, along with some changes to nt/configure.bat,
6534 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6535 earlier fix to add support for --cflags and --ldflags options
6536 that include quotes so that it works whether make uses cmd or
6537 sh as the shell.
6538
b4289b64
MA
65392011-05-06 Michael Albinus <michael.albinus@gmx.de>
6540
6541 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6542 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6543 is a constant.
6544 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6545 a string. Handle both cases.
6546 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6547 (Fdbus_register_method): Use Qinvalid_function.
6548
af4c0e28
JB
65492011-05-06 Juanma Barranquero <lekktu@gmail.com>
6550
6551 * makefile.w32-in: Update dependencies.
6552 (LISP_H): Add inttypes.h and stdin.h.
6553 (PROCESS_H): Add unistd.h.
6554
c51453d9
EZ
65552011-05-06 Eli Zaretskii <eliz@gnu.org>
6556
6557 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6558 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6559
8ff0ac3c 65602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6561
4c4b566b
PE
6562 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6563
aab2b9b5
PE
6564 * term.c (vfatal): Remove stray call to va_end.
6565 It's not needed and the C Standard doesn't allow it here anyway.
6566
c378da0b
PE
6567 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6568 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6569
288b08c7
PE
6570 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6571 bytes.
6572
e3601888
PE
6573 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6574
db6c0e74
PE
6575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6576
dd5963ea
PE
6577 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6578
88c9450f
PE
6579 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6580
2f9442b8
PE
6581 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6582
c032b5f8
PE
6583 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6584 * charset.c (Fdefine_charset_internal): Don't initialize
6585 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6586 32-bit int (Bug#8600).
a108c10b
PE
6587
6588 * lread.c (read_integer): Be more consistent with string-to-number.
6589 Use string_to_number to do the actual conversion; this avoids
6590 rounding errors and fixes some other screwups. Without this fix,
6591 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6592 (digit_to_number): Move earlier, for benefit of read_integer.
6593 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6594 not a digit in any supported base. (Bug#8602)
a108c10b 6595
ad5f9eea
PE
6596 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6597
aec1708a
PE
6598 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6599 to match comment at start of function. This also removes a
6600 GCC warning about overflow in a 32+64-bit port.
6601
47be4ab5
PE
6602 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6603
371cac43
PE
6604 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6605 Reported by Stefan Monnier in
6606 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6607 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6608 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6609
d01a7826
PE
6610 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6611 (EMACS_UINTPTR): Likewise, with uintptr_t.
6612
7fd47d5c
PE
6613 * lisp.h: Prefer 64-bit EMACS_INT if available.
6614 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6615 on 32-bit hosts that have 64-bit int, so that they can access
6616 large files.
122b0c86
PE
6617 However, temporarily disable this change unless the temporary
6618 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6619
8727937b
PE
6620 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6621
8ac068ac
PE
6622 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6623 This removes an assumption that EMACS_INT and long are the same
6624 width as pointers. The assumption is true for Emacs porting targets
6625 now, but we want to make other targets possible.
6626 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6627 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6628 In the rest of the code, change types of integers that hold casted
6629 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6630 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6631 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6632 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6633 No need to cast type when ORing.
6634 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6635 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6636 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6637 assume EMACS_INT is the same width as char *.
6638 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6639 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6640 Remove no-longer-needed casts.
6641 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6642 (xg_tool_bar_help_callback, xg_make_tool_item):
6643 Use EMACS_INTPTR to hold an integer
6644 that will be cast to void *; this can avoid a GCC warning
6645 if EMACS_INT is not the same width as void *.
6646 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6647 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6648 (current_message_1, set_message_1):
6649 Use a local to convert to proper width without a cast.
6650 * xmenu.c (dialog_selection_callback): Likewise.
6651
ede49d71
PE
6652 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6653 Also, don't assume VALBITS / RAND_BITS is less than 5,
6654 and don't rely on undefined behavior when shifting a 1 left into
6655 the sign bit.
6656 * lisp.h (get_random): Change signature to match.
6657
2f30ecd0
PE
6658 * lread.c (hash_string): Use size_t, not int, for hash computation.
6659 Normally we prefer signed values; but hashing is special, because
6660 it's better to use unsigned division on hash table sizes so that
6661 the remainder is nonnegative. Also, size_t is the natural width
6662 for hashing into memory. The previous code used 'int', which doesn't
6663 retain enough info to hash well into very large tables.
6664 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6665
2a866e7b
PE
6666 * dbusbind.c: Don't possibly lose pointer info when converting.
6667 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6668 Use XPNTR rather than XHASH, so that the high-order bits of
6669 the pointer aren't lost when converting through void *.
6670
51639eac
PE
6671 * eval.c (Fautoload): Don't double-shift a pointer.
6672
92394119
PE
6673 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6674
dbdb9a7c
JB
66752011-05-06 Juanma Barranquero <lekktu@gmail.com>
6676
6677 * gnutls.c (DEF_GNUTLS_FN):
6678 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6679
db7a0b4f
AS
66802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6681
6682 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6683 marker. (Bug#8610)
6684
cd394be1 66852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6686
6687 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6688 New version that can reserve upto 2GB of heap space.
6689
f7ff1b0f 66902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6691
6692 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6693
639c109b
TZ
66942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6695
6696 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6697 `gnutls_certificate_set_x509_key_file'.
6698
d2127135
JB
66992011-05-05 Juanma Barranquero <lekktu@gmail.com>
6700
6701 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6702 Update dependencies.
6703
e968f4f3
JB
67042011-05-04 Juanma Barranquero <lekktu@gmail.com>
6705
6706 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6707 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6708 Remove unused parameter `fildes'.
6709 * process.c (read_process_output, send_process): Don't pass it.
6710
84d358f0
JB
67112011-05-04 Juanma Barranquero <lekktu@gmail.com>
6712
6713 Fix previous change: the library cache is defined in w32.c.
6714 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6715 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6716
0898ca10
JB
67172011-05-04 Juanma Barranquero <lekktu@gmail.com>
6718
6719 Implement dynamic loading of GnuTLS on Windows.
6720
6721 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6722 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6723 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6724 Declare.
6725
6726 * gnutls.c (Qgnutls_dll): Define.
6727 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6728 (gnutls_*): Declare function pointers.
6729 (init_gnutls_functions): New function to initialize function pointers.
6730 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6731 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6732 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6733 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6734 (emacs_gnutls_write, emacs_gnutls_read)
6735 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6736 (Fgnutls_available_p): New function.
6737 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6738 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6739 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6740
6741 * image.c: Include w32.h.
6742 (Vimage_type_cache): Delete.
6743 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6744 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6745 (w32_delayed_load): Move to w32.c.
6746
6747 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6748
6749 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6750 (w32_delayed_load): Move from image.c. When loading a library, record
6751 its filename in the :loaded-from property of the library id.
6752 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6753 Initialize and staticpro them.
6754 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6755
6756 * process.c: Include lisp.h before w32.h, not after.
6757 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6758 instead of gnutls_record_check_pending.
6759
6760 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6761
ff4de4aa
TZ
67622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6763
6764 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6765 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6766 as passed in.
6767
abe95abb
JD
67682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6769
6770 * xterm.c (x_set_frame_alpha): Do not set property on anything
6771 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6772
e16e55d4
JB
67732011-05-02 Juanma Barranquero <lekktu@gmail.com>
6774
6775 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6776
bafcf6a5
JB
67772011-05-02 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6780 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6781 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6782 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6783 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6784 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6785 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6786 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6787 (Qgnutls_bootprop_callbacks_verify): Make static.
6788
e7a6747f
AS
67892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6790
19ed11ba
AS
6791 * callproc.c: Indentation fixup.
6792
e7a6747f 6793 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6794 (wait_for_termination, interruptible_wait_for_termination):
6795 Move after wait_for_termination_1.
e7a6747f 6796
1ef14cb4
LMI
67972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6798
6799 * sysdep.c (interruptible_wait_for_termination): New function
6800 which is like wait_for_termination, but allows keyboard
6801 interruptions.
6802
6803 * callproc.c (Fcall_process): Add (:file "file") as an option for
6804 the STDOUT buffer.
6805 (Fcall_process_region): Ditto.
6806
330d880c
EZ
68072011-04-30 Eli Zaretskii <eliz@gnu.org>
6808
8db90b73
EZ
6809 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6810 rather than `XVECTOR (FOO)->size'.
6811
330d880c
EZ
6812 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6813 inttypes.h, as a gnulib replacement is used if it not available in
6814 system headers.
6815
15cbd324
EZ
68162011-04-21 Eli Zaretskii <eliz@gnu.org>
6817
6818 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6819 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6820 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6821
6822 * coding.c (coding_alloc_by_realloc): Error out if destination
6823 will grow beyond MOST_POSITIVE_FIXNUM.
6824 (decode_coding_emacs_mule): Abort if there isn't enough place in
6825 charbuf for the composition carryover bytes. Reserve an extra
6826 space for up to 2 characters produced in a loop.
6827 (decode_coding_iso_2022): Abort if there isn't enough place in
6828 charbuf for the composition carryover bytes.
6829
68302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6831
ae940cca
EZ
6832 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6833 aborting when %lld or %lll format is passed.
6834 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6835 %llo or %llx format is passed. (Bug#8545)
6836
03ab8921
EZ
6837 * window.c (window_scroll_line_based): Use a marker instead of
6838 simple variables to record original value of point. (Bug#7952)
6839
afda1437
EZ
6840 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6841 produced by %s or %c overflows available buffer space. (Bug#8545)
6842
f76dee0c
PE
68432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6844
6845 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6846 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6847
fdc5744d
JB
68482011-04-28 Juanma Barranquero <lekktu@gmail.com>
6849
6850 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6851
638f053a
JB
68522011-04-28 Juanma Barranquero <lekktu@gmail.com>
6853
6854 * keyboard.c (Qdelayed_warnings_hook): Define.
6855 (command_loop_1): Run `delayed-warnings-hook'
6856 if Vdelayed_warnings_list is non-nil.
6857 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6858 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6859
d178f871
EZ
68602011-04-28 Eli Zaretskii <eliz@gnu.org>
6861
6862 * doprnt.c (doprnt): Don't return value smaller than the buffer
6863 size if the message was truncated. (Bug#8545).
6864
b124fd93
JB
68652011-04-28 Juanma Barranquero <lekktu@gmail.com>
6866
6867 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6868 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6869
e810457d
PE
68702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6871
6872 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6873
ea51cceb
JB
68742011-04-27 Juanma Barranquero <lekktu@gmail.com>
6875
6876 * makefile.w32-in: Update dependencies.
6877
94dcfacf
EZ
68782011-04-27 Eli Zaretskii <eliz@gnu.org>
6879
6880 Improve `doprnt' and its usage. (Bug#8545)
6881 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6882 `format_end'. Remove support for %l as a conversion specifier.
6883 Don't use xrealloc. Improve diagnostics when the %l size modifier
6884 is used. Update the commentary.
6885
6886 * eval.c (verror): Simplify calculation of size_t.
6887
6888 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6889 messages.
6890
f61f41d7
PE
68912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6892
6893 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6894 change.
6895
96fb4434
PE
68962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6897
6898 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6899 This makes this file independent of the recent pseudovector change.
6900
671875da 69012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6902
69e9b5a3
PE
6903 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6904
b5f869a7 6905 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6906 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6907 Remove unused local.
c8926152 6908 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6909
841a1577 6910 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6911 GCC 4.6.0 optimizes based on type-based alias analysis.
6912 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6913 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6914 != &v->size, and therefore "v->size = 1; b->size = 2; return
6915 v->size;" must therefore return 1. This assumption is incorrect
6916 for Emacs, since it type-puns struct Lisp_Vector * with many other
6917 types. To fix this problem, this patch adds a new type struct
f904488f 6918 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6919 and pseudovectors, and helps optimizing compilers not get fooled
6920 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6921 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6922 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6923 the size member.
eab3844f
PE
6924 (XSETPVECTYPE): Rewrite in terms of new macro.
6925 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6926 This is a bit clearer, and further avoids the possibility of
6927 undesirable aliasing.
6928 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6929 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6930 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6931 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6932 (ASIZE): Now uses header.size rather than size.
6933 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6934 to avoid the hassle of writing XVECTOR (foo)->header.size.
6935 (struct vectorlike_header): New type.
eab3844f
PE
6936 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6937 object, to help avoid aliasing.
6938 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6939 (SUBRP): Likewise, since Lisp_Subr is a special case.
6940 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6941 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6942 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6943 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6944 changed to be "header.size" and "header.next".
6945 * buffer.h (struct buffer): Likewise.
6946 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6947 * frame.h (struct frame): Likewise.
6948 * process.h (struct Lisp_Process): Likewise.
6949 * termhooks.h (struct terminal): Likewise.
6950 * window.c (struct save_window_data, struct saved_window): Likewise.
6951 * window.h (struct window): Likewise.
6952 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6953 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6954 * buffer.c (init_buffer_once): Likewise.
6955 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6956 special case.
6957 * process.c (Fformat_network_address): Use local var for size,
6958 for brevity.
6959
0df1eac5
PE
6960 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6961
847ab9d1 6962 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6963 * data.c (atof): Remove decl; no longer used or needed.
6964 (digit_to_number): Move to lread.c.
6965 (Fstring_to_number): Use new string_to_number function, to be
6966 consistent with how the Lisp reader treats infinities and NaNs.
6967 Do not assume that floating-point numbers represent EMACS_INT
6968 without losing information; this is not true on most 64-bit hosts.
6969 Avoid double-rounding errors, by insisting on integers when
6970 parsing non-base-10 numbers, as the documentation specifies.
6971 * lisp.h (string_to_number): New decl, replacing ...
6972 (isfloat_string): Remove.
bc0a5c13 6973 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6974 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6975 appears to have been a coding error. Similarly, do not accept
6976 strings like +-1e0 as floating point numbers. Do not report
6977 overflow for integer overflows unless the base is not 10 which
6978 means we have no simple and reliable way to continue.
6979 Break out the floating-point parsing into a new
6980 function string_to_number, so that Fstring_to_number parses
6981 floating point numbers consistently with the Lisp reader.
04f2d78b 6982 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6983 (E_CHAR, EXP_INT): Remove, replacing with ...
6984 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6985 (string_to_number): New function, replacing isfloat_string.
6986 This function checks for valid syntax and produces the resulting
6987 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6988 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6989 so that overflow for non-base-10 numbers is reported only when
6990 there's no portable and simple way to convert to floating point.
452f4150 6991
67769ffc
PE
6992 * textprop.c (set_text_properties_1): Rewrite for clarity,
6993 and to avoid GCC warning about integer overflow.
6994
c20db43f
PE
6995 * intervals.h (struct interval): Use EMACS_INT for members
6996 where EMACS_UINT might cause problems. See
6997 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6998 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6999 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7000 All uses changed.
37aa2f85
PE
7001 (offset_intervals): Tell GCC not to worry about length overflow
7002 when negating a negative length.
c20db43f 7003
2538aa2f
PE
7004 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7005 (overrun_check_free): Likewise.
7006
f2d3008d
PE
7007 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7008 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7009 word size.
7010
ec8df744
PE
7011 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7012 (gnutls_make_error): Rename local to avoid shadowing.
7013 (gnutls_emacs_global_deinit): ifdef out; not used.
7014 (Fgnutls_boot): Use const for pointer to readonly storage.
7015 Comment out unused local. Fix pointer signedness problems.
7016
640ee02d
PE
7017 * lread.c (openp): Don't stuff size_t into an 'int'.
7018 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7019 about possible signed overflow.
7020
6048fb2a
PE
7021 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7022 (GDK_KEY_g): Don't define if already defined.
7023 (xg_prepare_tooltip): Avoid pointer signedness problem.
7024 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7025
fa3c87e1
PE
7026 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7027 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7028
2172544b
PE
7029 * xfns.c (Fx_window_property): Simplify a bit,
7030 to make a bit faster and to avoid GCC 4.6.0 warning.
7031 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7032
9b821a21
PE
7033 * fns.c (internal_equal): Don't assume size_t fits in int.
7034
3c616cfa
PE
7035 * alloc.c (compact_small_strings): Tighten assertion a little.
7036
c2982e87
PE
7037 Replace pEd with more-general pI, and fix some printf arg casts.
7038 * lisp.h (pI): New macro, generalizing old pEd macro to other
7039 conversion specifiers. For example, use "...%"pI"d..." rather
7040 than "...%"pEd"...".
7041 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7042 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7043 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7044 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7045 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7046 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7047 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7048 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7049 64-bit hosts.
7050 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7051 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7052 * print.c (safe_debug_print, print_object): Likewise.
7053 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7054 to int.
6f04d126
PE
7055 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7056 avoiding the 0 flag, which is not portable.
c2982e87
PE
7057 * process.c (Fmake_network_process): Use pI to avoid cast.
7058 * region-cache.c (pp_cache): Likewise.
7059 * xdisp.c (decode_mode_spec): Likewise.
7060 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7061 behavior on 64-bit hosts with printf arg.
6f04d126 7062 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7063 (x_stop_queuing_selection_requests): Likewise.
7064 (x_get_window_property): Don't truncate byte count to an 'int'
7065 when tracing.
0b432f21 7066
5e073ec7
PE
7067 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7068 here, since it parses constructs like leading '-' and spaces,
7069 which are not wanted; and it overflows with large numbers.
7070 Instead, simply match F[0-9]+, which is what is wanted anyway.
7071
36372bf9
PE
7072 * alloc.c: Remove unportable assumptions about struct layout.
7073 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7074 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7075 (allocate_vectorlike, make_pure_vector): Use the new macros,
7076 plus offsetof, to remove unportable assumptions about struct layout.
7077 These assumptions hold on all porting targets that I know of, but
7078 they are not guaranteed, they're easy to remove, and removing them
7079 makes further changes easier.
7080
0b432f21
PE
7081 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7082 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7083 (string_overrun_cookie): Now const. Use initializers that
7084 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7085 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7086 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7087 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7088 multiple of sizeof (EMACS_INT); it need not be, if
7089 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7090 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7091
895009e1
JB
70922011-04-26 Juanma Barranquero <lekktu@gmail.com>
7093
7094 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7095
6a7a1b0b
TZ
70962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7097
7098 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7099 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7100 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7101
841a1577 71022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7103
7104 * lisp.h (Qdebug): List symbol.
895009e1 7105 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7106 * keyboard.c (debug-on-event): New variable.
7107 (handle_user_signal): Break into debugger when debug-on-event
7108 matches the current signal symbol.
7109
f2d3ba6f
DN
71102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7111
7112 * alloc.c (check_sblock, check_string_bytes)
7113 (check_string_free_list): Convert to standard C.
7114
42ce4c63
TZ
71152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7116
7117 * w32.c (emacs_gnutls_push): Fix typo.
7118
825cd63c
EZ
71192011-04-25 Eli Zaretskii <eliz@gnu.org>
7120
fb11d64d
EZ
7121 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7122 "cast to pointer from integer of different size".
7123
825cd63c
EZ
7124 Improve doprnt and its use in verror. (Bug#8545)
7125 * doprnt.c (doprnt): Document the set of format control sequences
7126 supported by the function. Use SAFE_ALLOCA instead of always
7127 using `alloca'.
7128
7129 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7130 is one byte too soon. Don't use xrealloc; instead xfree and
7131 xmalloc anew.
7132
e061a11b
TZ
71332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7134
7135 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7136 callbacks stage.
7137
7138 * gnutls.c: Renamed global_initialized to
7139 gnutls_global_initialized. Added internals for the
7140 :verify-hostname-error, :verify-error, and :verify-flags
7141 parameters of `gnutls-boot' and documented those parameters in the
7142 docstring. Start callback support.
9173deec
JB
7143 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7144 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7145 on error. Return error code.
e061a11b
TZ
7146 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7147 (emacs_gnutls_read): Likewise.
7148 (Fgnutls_boot): Return handshake error code.
7149 (emacs_gnutls_handle_error): New function.
7150 (wsaerror_to_errno): Likewise.
7151
7152 * w32.h (emacs_gnutls_pull): Add prototype.
7153 (emacs_gnutls_push): Likewise.
7154
7155 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7156 (emacs_gnutls_push): Likewise.
7157
71582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7159
7160 * process.c (wait_reading_process_output): Check if GnuTLS
7161 buffered some data internally if no FDs are set for TLS
7162 connections.
7163
7164 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7165 (LIBS): Link to USER_LIBS.
7166 ($(BLD)/gnutls.$(0)): New target.
7167
fa6996bc
EZ
71682011-04-24 Eli Zaretskii <eliz@gnu.org>
7169
eb35682e
EZ
7170 * xdisp.c (handle_single_display_spec): Rename the
7171 display_replaced_before_p argument into display_replaced_p, to
7172 make it consistent with the commentary. Fix typos in the
7173 commentary.
7174
e2ad650c
EZ
7175 * textprop.c (syms_of_textprop): Remove dead code.
7176 (copy_text_properties): Delete obsolete commentary about an
7177 interface that was deleted long ago. Fix typos in the description
7178 of arguments.
7179
1b2de274
EZ
7180 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7181 to changes in oldXMenu/XMenu.h from 2011-04-16.
7182 <menu_help_message, prev_menu_help_message>: Constify.
7183 (IT_menu_make_room): menu->help_text is now `const char **';
7184 adjust.
7185
7186 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7187 to changes in oldXMenu/XMenu.h from 2011-04-16.
7188 (struct XMenu): Declare `help_text' `const char **'.
7189
7190 * xfaces.c <Qunspecified>: Make extern again.
7191
7192 * syntax.c: Include sys/types.h before including regex.h, as
7193 required by Posix.
7194
762b15be
EZ
7195 * doc.c (get_doc_string): Improve the format passed to `error'.
7196
7197 * doprnt.c (doprnt): Improve commentary.
7198
7199 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7200
7201 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7202 them with etags.
7203
f1052e5d
EZ
7204 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7205 changes in globals.h immediately force recompilation.
762b15be
EZ
7206 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7207 $(CURDIR)/s/ms-w32.h.
7208 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7209
fa6996bc
EZ
7210 * character.c (Fchar_direction): Function deleted.
7211 (syms_of_character): Don't defsubr it.
7212 <char-direction-table>: Deleted.
7213
e6c3da20
EZ
72142011-04-23 Eli Zaretskii <eliz@gnu.org>
7215
7216 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7217 * doprnt.c: Include limits.h.
7218 (SIZE_MAX): New macro.
04f2d78b
CB
7219 (doprnt): Return a size_t value. 2nd arg is now size_t.
7220 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7221 Improve overflow protection. Support `l' modifier for integer
7222 conversions. Support %l conversion. Don't assume an EMACS_INT
7223 argument for integer conversions and for %c.
7224
7225 * lisp.h (doprnt): Restore prototype.
7226
7227 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7228 $(SRC)/character.h.
7229
7230 * Makefile.in (base_obj): Add back doprnt.o.
7231
7232 * deps.mk (doprnt.o): Add back prerequisites.
7233 (callint.o): Depend on character.h.
7234
7235 * eval.c (internal_lisp_condition_case): Include the handler
7236 representation in the error message.
7237 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7238 when breaking from the loop.
7239
7240 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7241
7242 * callint.c (Fcall_interactively): When displaying error message
7243 about invalid control letter, pass the character's codepoint, not
7244 a pointer to its multibyte form. Improve display of the character
7245 in octal and display also its hex code.
7246
7247 * character.c (char_string): Use %x to display the (unsigned)
7248 codepoint of an invalid character, to avoid displaying a bogus
7249 negative value.
7250
7251 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7252 `error', not SYMBOL_NAME itself.
7253
7254 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7255 character arguments to `error'.
7256
7257 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7258 to `error' in error message about FINAL_CHAR argument. Make sure
7259 FINAL_CHAR is a character, and use %c when it is passed as
7260 argument to `error'.
7261
4ffd0d6b 72622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7263
7264 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7265
7266 * w32.c: Include <time.h>.
7267 (sys_localtime): New function.
7268
4ffd0d6b 72692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7270
7271 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7272
4ffd0d6b 7273 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7274
4ffd0d6b 72752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7276
4ffd0d6b
GM
7277 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7278 zombies (Bug#8467).
aac0c6e3 7279
04c56954
EZ
72802011-04-19 Eli Zaretskii <eliz@gnu.org>
7281
7282 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7283 gl_state.e_property when gl_state.object is Qt.
7284
7285 * insdel.c (make_gap_larger): Remove limitation of buffer size
7286 to <= INT_MAX.
7287
16a43933
CY
72882011-04-18 Chong Yidong <cyd@stupidchicken.com>
7289
7290 * xdisp.c (lookup_glyphless_char_display)
7291 (produce_glyphless_glyph): Handle cons cell entry in
7292 glyphless-char-display.
7293 (Vglyphless_char_display): Document it.
7294
7295 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7296 glyphless-char-display.
7297
4581706e
CY
72982011-04-17 Chong Yidong <cyd@stupidchicken.com>
7299
7300 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7301
7302 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7303
7304 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7305 definition for no-X builds.
7306
4887c6e2 73072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7308
fd35b6f9
PE
7309 Static checks with GCC 4.6.0 and non-default toolkits.
7310
5c1ccb01
PE
7311 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7312
006c5daa
PE
7313 * process.c (keyboard_bit_set): Define only if SIGIO.
7314 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7315 (send_process): Repair possible setjmp clobbering.
7316
efc736d3
PE
7317 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7318
4e2fe2e6
PE
7319 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7320
f97334a2
PE
7321 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7322
4e75f29d
PE
7323 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7324 Define only if needed.
7325
90efadd1
PE
7326 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7327 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7328 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7329
3c647824
PE
7330 * dispextern.h (struct redisplay_interface): Rename param
7331 to avoid shadowing.
e264f262 7332 * termhooks.h (struct terminal): Likewise.
761383f4 7333 * xterm.c (xembed_send_message): Likewise.
3c647824 7334
b58c5c4a
PE
7335 * insdel.c (make_gap_smaller): Define only if
7336 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7337
cad59032
PE
7338 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7339 it.
7340
c339dc2e
PE
7341 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7342 so that we aren't warned about unused symbols.
7343
91a3e27b
PE
7344 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7345
399c71d3 7346 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7347
8ffc96f5
PE
7348 * xfns.c (x_real_positions): Mark locals as initialized.
7349
eef9bc79
PE
7350 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7351
098db9dd
PE
7352 * xterm.c: Fix problems found by static analysis with other toolkits.
7353 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7354 (x_dispatch_event): Declare static if USE_GTK, and
7355 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7356 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7357 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7358 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7359 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7360
eb18f6cc
PE
7361 * xmenu.c (menu_help_callback): Pointer type fixes.
7362 Use const pointers when pointing at readonly data. Avoid pointer
7363 signedness clashes.
7364 (FALSE): Remove unused macro.
7365 (update_frame_menubar): Remove unused decl.
7366
1fe72bf8
PE
7367 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7368
60d9e1db
PE
7369 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7370 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7371 (single_menu_item): Rename local to avoid shadowing.
7372
39261c26
PE
7373 * keyboard.c (make_lispy_event): Remove unused local var.
7374
018c5e19
PE
7375 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7376 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7377
63d2b86e
PE
7378 * bitmaps: Change bitmaps from unsigned char back to the X11
7379 compatible char. Avoid the old compiler warnings about
7380 out-of-range initializers by using, for example, '\xab' rather
7381 than 0xab.
7382
aefd87e1
PE
7383 * xgselect.c (xgselect_initialize): Check vs interface
7384 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7385
bf501fb9
PE
7386 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7387
e9829fdf
PE
7388 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7389 to read-only memory.
7390
1086c095
PE
7391 * fns.c (vector): Remove; this old hack is no longer needed.
7392
2baccd04 7393 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7394 Remove unused var.
dde42981 7395 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7396
72391843 7397 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7398
436c16df 7399 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7400 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7401 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7402
92bb796d 7403 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7404 (x_term_init): Remove local to avoid shadowing.
92bb796d 7405
764430a3 7406 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7407
7408 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7409 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7410
d1dfb56c
EZ
74112011-04-16 Eli Zaretskii <eliz@gnu.org>
7412
c4354cb4
EZ
7413 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7414
d1dfb56c
EZ
7415 Fix regex.c, syntax.c and friends for buffers > 2GB.
7416 * syntax.h (struct gl_state_s): Declare character position members
7417 EMACS_INT.
7418
7419 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7420
04f2d78b
CB
7421 * textprop.c (verify_interval_modification, interval_of):
7422 Declare arguments EMACS_INT.
d1dfb56c
EZ
7423
7424 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7425 EMACS_INT.
7426
7427 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7428
7429 * indent.c (Fvertical_motion): Local variable it_start is now
7430 EMACS_INT.
7431
7432 * regex.c (re_match, re_match_2, re_match_2_internal)
7433 (bcmp_translate, regcomp, regexec, print_double_string)
7434 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7435 (re_compile_pattern, re_exec): Declare arguments and local
7436 variables `size_t' and `ssize_t' and return values `regoff_t', as
7437 appropriate.
7438 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7439 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7440 <compile_stack_type>: `size' and `avail' are now `size_t'.
7441
7442 * regex.h <regoff_t>: Use ssize_t, not int.
7443 (re_search, re_search_2, re_match, re_match_2): Arguments that
7444 specify buffer/string position and length are now ssize_t and
7445 size_t. Return type is regoff_t.
7446
613052cd
BK
74472011-04-16 Ben Key <bkey76@gmail.com>
7448
7449 * nsfont.m: Fixed bugs in ns_get_family and
7450 ns_descriptor_to_entity that were caused by using free to
7451 deallocate memory blocks that were allocated by xmalloc (via
7452 xstrdup). This caused Emacs to crash when compiled with
7453 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7454 --enable-checking=xmallocoverrun). xfree is now used to
7455 deallocate these memory blocks.
7456
4170f62f 74572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7458
71b41406
PE
7459 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7460
9587a89d
PE
7461 emacs_write: Accept and return EMACS_INT for sizes.
7462 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7463 et seq.
7464 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7465 Accept and return EMACS_INT.
7466 (emacs_gnutls_write): Return the number of bytes written on
7467 partial writes.
7468 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7469 (emacs_read, emacs_write): Remove check for negative size, as the
7470 Emacs source code has been audited now.
9587a89d
PE
7471 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7472 (emacs_read, emacs_write): Use it.
273a5f82
PE
7473 * process.c (send_process): Adjust to the new signatures of
7474 emacs_write and emacs_gnutls_write. Do not attempt to store
7475 a byte offset into an 'int'; it might overflow.
9587a89d 7476 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7477
3e047f51
PE
7478 * sound.c: Don't assume sizes fit in 'int'.
7479 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7480 Return EMACS_INT, not int.
3e047f51 7481 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7482 Accept EMACS_INT, not int.
7483 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7484 record read return values.
7485
cc39a9db
BK
74862011-04-15 Ben Key <bkey76@gmail.com>
7487
c9d0ec6d
JB
7488 * keyboard.c (Qundefined): Don't declare static since it is used
7489 in nsfns.m.
7490 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7491 static since they are used in nsfont.m.
cc39a9db 7492
6c60eb9f
SM
74932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7494
7495 * process.c (Qprocessp): Don't declare static.
7496 * lisp.h (Qprocessp): Declare again.
7497
7990b61a
JB
74982011-04-15 Juanma Barranquero <lekktu@gmail.com>
7499
7500 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7501
5d4cb038
PE
75022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7503
8bd7b830 7504 Improve C-level modularity by making more things 'static'.
cd64ea1d 7505
e3b27b31
PE
7506 Don't publish debugger-only interfaces to other modules.
7507 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7508 (verify_bytepos, count_markers): Move decls to the only modules
7509 that need them.
7510 * region-cache.h (pp_cache): Likewise.
7511 * window.h (check_all_windows): Likewise.
7512 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7513
5d4cb038
PE
7514 * sysdep.c (croak): Now static, if
7515 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7516 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7517
7518 * alloc.c (refill_memory_reserve): Now static if
7519 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7520 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7521
e87b6180
PE
7522 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7523 Define only if USE_LUCID.
7524
ac64929e
PE
7525 * xrdb.c (x_customization_string, x_rm_string): Now static.
7526
6f37259d
PE
7527 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7528 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7529
1683e3ab
PE
7530 * xdisp.c (draw_row_with_mouse_face): Now static.
7531 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7532
de9c2632
PE
7533 * window.h (check_all_windows): Mark externally visible.
7534
2b96acb7
PE
7535 * window.c (window_deletion_count): Now static.
7536
7537 * undo.c: Make symbols static if they're not exported.
7538 (last_undo_buffer, last_boundary_position, pending_boundary):
7539 Now static.
7540
50436f33
PE
7541 * textprop.c (interval_insert_behind_hooks): Now static.
7542 (interval_insert_in_front_hooks): Likewise.
7543
64520e5c
PE
7544 * term.c: Make symbols static if they're not exported.
7545 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7546 (max_frame_lines, tty_set_terminal_modes):
7547 (tty_reset_terminal_modes, tty_turn_off_highlight):
7548 (get_tty_terminal): Now static.
7549 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7550 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7551 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7552 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7553 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7554
1fa53021
PE
7555 * sysdep.c: Make symbols static if they're not exported.
7556 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7557 Now static.
7558 (sigprocmask_set, full_mask): Remove; unused.
7559 (wait_debugging): Mark as visible.
7560 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7561 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7562
d4b43b22
PE
7563 * syntax.c (syntax_temp): Define only if !__GNUC__.
7564
b7c513d0
PE
7565 * sound.c (current_sound_device, current_sound): Now static.
7566
989b29ad
PE
7567 * search.c (searchbufs, searchbuf_head): Now static.
7568
13a55a78
PE
7569 * scroll.c (scroll_cost): Remove; unused.
7570 * dispextern.h (scroll_cost): Remove decl.
7571
de68a1fc
PE
7572 * region-cache.h (pp_cache): Mark as externally visible.
7573
40ccffa6
PE
7574 * process.c: Make symbols static if they're not exported.
7575 (process_tick, update_tick, create_process, chan_process):
7576 (Vprocess_alist, proc_buffered_char, datagram_access):
7577 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7578 (deactivate_process): Mark defn as static, as well as decl.
7579 * lisp.h (create_process): Remove decl.
7580 * process.h (chan_process, Vprocess_alist): Remove decls.
7581
ad64fc97
PE
7582 * print.c: Make symbols static if they're not exported.
7583 (print_depth, new_backquote_output, being_printed, print_buffer):
7584 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7585 (print_interval, print_number_index, initial_stderr_stream):
7586 Now static.
7587 * lisp.h (Fprinc): Remove decl.
7588 (debug_output_compilation_hack): Mark as externally visible.
7589
adddb265
PE
7590 * sysdep.c (croak): Move decl from here to syssignal.h.
7591 * syssignal.h (croak): Put it here, so the API can be checked when
7592 'croak' is called from dissociate_if_controlling_tty.
7593
1717ede2
PE
7594 * minibuf.c: Make symbols static if they're not exported.
7595 (minibuf_save_list, choose_minibuf_frame): Now static.
7596 * lisp.h (choose_minibuf_frame): Remove decl.
7597
fa5fb2bc
PE
7598 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7599
1e3890d1
PE
7600 * lread.c: Make symbols static if they're not exported.
7601 (read_objects, initial_obarray, oblookup_last_bucket_number):
7602 Now static.
7603 (make_symbol): Remove; unused.
7604 * lisp.h (initial_obarray, make_symbol): Remove decls.
7605
8a1414fa
PE
7606 * keyboard.c: Make symbols static if they're not exported.
7607 (single_kboard, recent_keys_index, total_keys, recent_keys):
7608 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7609 (this_single_command_key_start, echoing, last_auto_save):
7610 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7611 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7612 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7613 (Vlispy_mouse_stem, double_click_count):
7614 Now static.
7615 (force_auto_save_soon): Define only if SIGDANGER.
7616 (ignore_mouse_drag_p): Now static if
7617 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7618 (print_help): Remove; unused.
7619 (stop_character, last_timer_event): Mark as externally visible.
7620 * keyboard.h (ignore_mouse_drag_p): Declare only if
7621 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7622 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7623 * lisp.h (echoing): Remove decl.
7624 (force_auto_save_soon): Declare only if SIGDANGER.
7625 * xdisp.c (redisplay_window): Simplify code, to make it more
7626 obvious that ignore_mouse_drag_p is not accessed if !defined
7627 USE_GTK && !defined HAVE_NS.
7628
93ea6e8f
PE
7629 * intervals.c: Make symbols static if they're not exported.
7630 (merge_properties_sticky, merge_interval_right, delete_interval):
7631 Now static.
7632 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7633
77382fcc
PE
7634 * insdel.c: Make symbols static if they're not exported.
7635 However, leave prepare_to_modify_buffer alone. It's never
7636 called from outside this function, but that appears to be a bug.
7637 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7638 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7639 (adjust_after_replace_noundo): Remove; unused.
7640 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7641 (signal_before_change): Remove decls.
77382fcc 7642
9306c32e
PE
7643 * indent.c (val_compute_motion, val_vmotion): Now static.
7644
cd44d2eb
PE
7645 * image.c: Make symbols static if they're not exported.
7646 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7647 if USE_GTK.
7648 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7649 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7650
ad9a7a06
PE
7651 * fringe.c (standard_bitmaps): Now static.
7652 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7653
81626931
PE
7654 * frame.c: Make symbols static if they're not exported.
7655 (x_report_frame_params, make_terminal_frame): Now static.
7656 (get_frame_param): Now static, unless HAVE_NS.
7657 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7658 (x_get_resource_string): Remove; not used.
7659 * frame.h (make_terminal_frame, x_report_frame_params):
7660 (x_get_resource_string); Remove decls.
7661 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7662 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7663
239f9db9
PE
7664 * font.c, fontset.c: Make symbols static if they're not exported.
7665 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7666 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7667 * font.c (font_close_object): Now static.
7668 * font.h (font_close_object): Remove.
7669 * fontset.c (FONTSET_OBJLIST): Remove.
7670 (free_realized_fontset) #if-0 the body, which does nothing.
7671 (face_suitable_for_char_p): #if-0, as it's never called.
7672 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7673 * xfaces.c (face_at_string_position):
7674 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7675 since 0 is always ASCII.
7676
dfcf3579
PE
7677 * fns.c (weak_hash_tables): Now static.
7678
5045092b
PE
7679 * fileio.c: Make symbols static if they're not exported.
7680 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7681 (Vwrite_region_annotation_buffers): Now static.
7682
57a96f5c
PE
7683 * eval.c: Make symbols static if they're not exported.
7684 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7685 * lisp.h (backtrace_list): Remove decl.
7686
35f08c38
PE
7687 * emacs.c: Make symbols static if they're not exported.
7688 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7689 (fatal_error_code, fatal_error_signal_hook, standard_args):
7690 Now static.
7691 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7692 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7693 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7694 * lisp.h (fatal_error_signal_hook): Remove decl.
7695 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7696
f44bd759
PE
7697 * editfns.c: Move a (normally-unused) function to its only use.
7698 * editfns.c, lisp.h (get_operating_system_release): Remove.
7699 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7700 worth the hassle of breaking this out.
7701
b532497d
PE
7702 * xterm.c: Make symbols static if they're not exported.
7703 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7704 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7705 (x_destroy_window, x_delete_display):
7706 Now static.
7707 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7708 (x_mouse_leave): Remove; unused.
7709 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7710 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7711 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7712 Remove decls.
7713 (x_mouse_leave): Declare only if WINDOWSNT.
7714 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7715 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7716 USE_X_TOOLKIT.
7717
1675728f
PE
7718 * ftxfont.c: Make symbols static if they're not exported.
7719 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7720 HAVE_FREETYPE.
7721 * font.h (ftxfont_driver): Likewise.
7722
e4cebfca
PE
7723 * xfns.c: Make symbols static if they're not exported.
7724 (x_last_font_name, x_display_info_for_name):
7725 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7726 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7727 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7728 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7729 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7730 (last_show_tip_args): Now static.
7731 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7732 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7733 (x_screen_planes): Remove; unused.
7734 * dispextern.h (x_screen_planes): Remove decl.
7735
5bf46f05
PE
7736 * dispnew.c: Make symbols static if they're not exported.
7737 * dispextern.h (redraw_garbaged_frames, scrolling):
7738 (increment_row_positions): Remove.
7739 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7740 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7741 Now static.
7742 (redraw_garbaged_frames): Remove; unused.
7743
435f4c28
PE
7744 * xfaces.c: Make symbols static if they're not exported.
7745 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7746 Remove decls.
7747 * xterm.h (defined_color): Remove decls.
7748 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7749 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7750 (menu_face_changed_default, defined_color, free_realized_face):
7751 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7752 (ascii_face_of_lisp_face): Remove; unused.
7753
8524aef3
PE
7754 * xdisp.c: Make symbols static if they're not exported.
7755 * dispextern.h (scratch_glyph_row, window_box_edges):
7756 (glyph_to_pixel_coords, set_cursor_from_row):
7757 (get_next_display_element, set_iterator_to_next):
7758 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7759 (show_mouse_face): Remove decls
7760 * frame.h (message_buf_print): Likewise.
7761 * lisp.h (pop_message, set_message, check_point_in_composition):
7762 Likewise.
7763 * xterm.h (set_vertical_scroll_bar): Likewise.
7764 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7765 (message_buf_print, scratch_glyph_row, displayed_buffer):
7766 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7767 (get_next_display_element, show_mouse_face, window_box_edges):
7768 (frame_to_window_pixel_xy, check_point_in_composition):
7769 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7770 (glyph_to_pixel_coords): Remove; unused.
7771
16390cd2
PE
7772 * dired.c (file_name_completion): Now static.
7773
7774 * dbusbind.c (xd_in_read_queued_messages): Now static.
7775
a25f4dfa
PE
7776 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7777 * data.c (circular_list_error): Remove.
7778
14a9c8df
PE
7779 * commands.h (last_point_position, last_point_position_buffer):
7780 (last_point_position_window): Remove decls.
7781 * keyboard.c: Make these variables static.
7782
04f2d78b
CB
7783 * coding.h (coding, code_convert_region, encode_coding_gap):
7784 Remove decls.
74ab6df5
PE
7785 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7786 (iso_code_class, detect_coding, code_convert_region): Now static.
7787 (encode_coding_gap): Remove; unused.
7788
38dfbee1
PE
7789 * chartab.c (chartab_chars, chartab_bits): Now static.
7790
a2cb4e63
PE
7791 * charset.h (charset_iso_8859_1): Remove decl.
7792 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7793 Now static.
7794
127198fd
PE
7795 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7796 * ccl.c (Vccl_program_table): Now static.
7797 (check_ccl_update): Remove; unused.
7798
d85b608f
PE
7799 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7800 * category.h: ... from here.
7801 * category.c (check_category_table, set_category_set): Now static.
7802
31cd66f3
PE
7803 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7804 * lisp.h: Remove these decls.
7805
c358e587
PE
7806 * buffer.c (buffer_count): Remove unused var.
7807
e78aecca
PE
7808 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7809 so that it's not optimized away.
7810 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7811 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7812 exported only to the debugger.
7813
e192d7d3 7814 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7815 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7816
92470028
PE
7817 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7818 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7819 was inaccessible from Lisp.
7820 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7821 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7822
244ed907
PE
7823 alloc.c: Import and export fewer symbols, and remove unused items.
7824 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7825 is defined.
7826 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7827 it's not optimized away by whole-program optimization.
7828 (message_enable_multibyte, free_misc): Remove.
7829 (catchlist, handlerlist, mark_backtrace):
7830 Declare only if BYTE_MARK_STACK.
7831 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7832 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7833 (message_enable_multibyte): Remove decl.
7834 (free_misc, interval_free_list, float_block, float_block_index):
7835 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7836 (cons_free_list, last_marked_index):
7837 Now static.
7838 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7839 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7840 (mark_backtrace): Define only if BYTE_MARK_STACK.
7841 * xdisp.c (message_enable_multibyte): Now static.
7842
61c2b50e 7843 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7844 This makes it easier for human readers (and static analyzers)
7845 to see whether these variables are used from other modules.
7846 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7847 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7848 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7849 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7850 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7851 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7852 * xmenu.c, xselect.c:
7853 Declare Q* vars static if they are not used in other modules.
7854 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7855 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7856 Remove decls of unexported vars.
7857 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7858
95c82688
PE
7859 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7860
16a97296
PE
7861 Make Emacs functions such as Fatom 'static' by default.
7862 This makes it easier for human readers (and static analyzers)
7863 to see whether these functions can be called from other modules.
7864 DEFUN now defines a static function. To make the function external
7865 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7866 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7867 (Finit_image_library):
16a97296
PE
7868 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7869 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7870 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7871 Remove decls, since these functions are now static.
7872 (Funintern, Fget_internal_run_time): New decls, since these functions
7873 were already external.
95c82688 7874
16a97296
PE
7875 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7876 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7877 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7878 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7879 * keyboard.c, keymap.c, lread.c:
7880 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7881 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7882 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7883 Mark functions with DEFUE instead of DEFUN,
7884 if they are used in other modules.
7885 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7886 decls for now-static functions.
7887 * buffer.h (Fdelete_overlay): Remove decl.
7888 * callproc.c (Fgetenv_internal): Mark as internal.
7889 * composite.c (Fremove_list_of_text_properties): Remove decl.
7890 (Fcomposition_get_gstring): New forward static decl.
7891 * composite.h (Fcomposite_get_gstring): Remove decl.
7892 * dired.c (Ffile_attributes): New forward static decl.
7893 * doc.c (Fdocumntation_property): New forward static decl.
7894 * eval.c (Ffetch_bytecode): New forward static decl.
7895 (Funintern): Remove extern decl; now in .h file where it belongs.
7896 * fileio.c (Fmake_symbolic_link): New forward static decl.
7897 * image.c (Finit_image_library): New forward static decl.
7898 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7899 * intervals.h (Fprevious_property_change):
7900 (Fremove_list_of_text_properties): Remove decls.
7901 * keyboard.c (Fthis_command_keys): Remove decl.
7902 (Fcommand_execute): New forward static decl.
7903 * keymap.c (Flookup_key): New forward static decl.
7904 (Fcopy_keymap): Now static.
7905 * keymap.h (Flookup_key): Remove decl.
7906 * process.c (Fget_process): New forward static decl.
7907 (Fprocess_datagram_address): Mark as internal.
7908 * syntax.c (Fsyntax_table_p): New forward static decl.
7909 (skip_chars): Remove duplicate decl.
7910 * textprop.c (Fprevious_property_change): New forward static decl.
7911 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7912 Now internal.
7913 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7914 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7915
785bbd42
PE
7916 * editfns.c (Fformat): Remove unreachable code.
7917
8b913b57
AS
79182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7919
7920 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7921 change. (Bug#8496)
7922
a6744a35
EZ
79232011-04-13 Eli Zaretskii <eliz@gnu.org>
7924
7925 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7926 when at ZV. (Bug#8487)
7927
e7974947
AS
79282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7929
baad03f0
AS
7930 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7931 (Bug#8437)
7932 * keyboard.c (parse_tool_bar_item): Likewise.
7933 * sound.c (sound_cleanup, alsa_close): Likewise.
7934 * termcap.c (tgetent): Likewise.
7935 * xfns.c (x_default_font_parameter): Likewise.
7936 * xsettings.c (read_and_apply_settings): Likewise.
7937
e7974947
AS
7938 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7939 (overrun_check_free): Protoize.
7940
28272684
PE
79412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7942
7943 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7944 since callers should never pass a negative size.
7945 Change the signature to match that of plain 'read' and 'write'; see
7946 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7947 * lisp.h: Update prototypes of emacs_write and emacs_read.
7948
11997c76
EZ
79492011-04-11 Eli Zaretskii <eliz@gnu.org>
7950
7951 * xdisp.c (redisplay_window): Don't try to determine the character
7952 position of the scroll margin if the window start point w->startp
e896f03c 7953 is outside the buffer's accessible region. (Bug#8468)
11997c76 7954
8a2cbd72
EZ
79552011-04-10 Eli Zaretskii <eliz@gnu.org>
7956
7957 Fix write-region and its subroutines for buffers > 2GB.
7958 * fileio.c (a_write, e_write): Modify declaration of arguments and
7959 local variables to support buffers larger than 2GB.
7960 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7961
7962 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7963 argument, local variables, and return value.
7964
7965 * lisp.h: Update prototypes of emacs_write and emacs_read.
7966
7967 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7968
4073e537 79692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7970
1ebfdcb6
PE
7971 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7972
b2ded58d
PE
7973 Fix more problems found by GCC 4.6.0's static checks.
7974
7d66342c
PE
7975 * xdisp.c (vmessage): Use a better test for character truncation.
7976
bbf47d44
PE
7977 * charset.c (load_charset_map): <, not <=, for optimization,
7978 and to avoid potential problems with integer overflow.
9248994d 7979 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7980 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7981 * editfns.c (Fformat): Likewise.
1e69125e 7982 * syntax.c (skip_chars): Likewise.
3befa583 7983
e3019616
PE
7984 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7985 This also lets GCC 4.6.0 generate slightly better loop code.
7986
becfa255
PE
7987 * callint.c (Fcall_interactively): <, not <=, for optimization.
7988 (Fcall_interactively): Count the number of arguments produced,
7989 not the number of arguments given. This is simpler and lets GCC
7990 4.6.0 generate slightly better code.
7991
dae0cd48
PE
7992 * ftfont.c: Distingish more carefully between FcChar8 and char.
7993 The previous code passed unsigned char * to a functions like
7994 strlen and xstrcasecmp that expect char *, which does not
7995 conform to the C standard.
7996 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7997 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7998 char * when the C standard requires it.
7999
76032d70
PE
8000 * keyboard.c (read_char): Remove unused var.
8001
eb3f1cc8
PE
8002 * eval.c: Port to Windows vsnprintf (Bug#8435).
8003 Include <limits.h>.
8004 (SIZE_MAX): Define if the headers do not.
8005 (verror): Do not give up if vsnprintf returns a negative count.
8006 Instead, grow the buffer. This ports to Windows vsnprintf, which
8007 does not conform to C99. Problem reported by Eli Zaretskii.
8008 Also, simplify the allocation scheme, by avoiding the need for
8009 calling realloc, and removing the ALLOCATED variable.
8010
70476b54
PE
8011 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8012
12020a9e
PE
8013 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8014 But keep the doprint source code for now, as we might revamp it
8015 and use it again (Bug#8435).
ea6c7ae6
PE
8016 * lisp.h (doprnt): Remove.
8017 * Makefile.in (base_obj): Remove doprnt.o.
8018 * deps.mk (doprnt.o): Remove.
8019
5fdb398c
PE
8020 error: Print 32- and 64-bit integers portably (Bug#8435).
8021 Without this change, on typical 64-bit hosts error ("...%d...", N)
8022 was used to print both 32- and 64-bit integers N, which relied on
8023 undefined behavior.
61bdb816 8024 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8025 * lisp.h (error, verror): Mark as printf-like functions.
8026 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8027 Report overflow in size calculations when allocating printf buffer.
8028 Do not truncate output string at its first null byte.
8029 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8030 Truncate the output at a character boundary, since vsnprintf does not
8031 do that.
8032 * charset.c (check_iso_charset_parameter): Convert internal
8033 character to string before calling 'error', since %c now has the
8034 printf meaning.
8035 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8036 overflow when computing char to be passed to 'error'. Do not
8037 pass Lisp_Object to 'error'; pass the integer instead.
8038 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8039 formatted with plain %d.
8040
b189fa66
PE
8041 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8042
bff87ef0
PE
8043 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8044
7e2cac20
PE
8045 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8046
ce4d90b5
PE
8047 * xterm.c (x_catch_errors): Remove duplicate declaration.
8048
266c9547
PE
8049 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8050
79c49ad2
PE
8051 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8052
368f4090
JM
80532011-04-10 Jim Meyering <meyering@redhat.com>
8054
8055 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8056 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8057 return ssize_t not "int", and use size_t as the buffer length.
8058 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8059 * gnutls.h: Update declarations.
8060 * process.c (read_process_output): Use ssize_t, to match.
8061 (send_process): Likewise.
8062
a32d4040
CY
80632011-04-09 Chong Yidong <cyd@stupidchicken.com>
8064
8065 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8066
8546720e 80672011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8068
04f2d78b
CB
8069 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8070 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8071
8546720e
GM
8072 * xterm.c (handle_one_xevent):
8073 * xmenu.c (create_and_show_popup_menu):
8074 * xselect.c (x_decline_selection_request)
8075 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8076
0a2f5c1a 80772011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8078
8079 Fix some uses of `int' instead of EMACS_INT.
8080 * search.c (string_match_1, fast_string_match)
8081 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8082 (scan_buffer, find_next_newline_no_quit)
8083 (find_before_next_newline, search_command, Freplace_match)
8084 (Fmatch_data): Make some `int' variables be EMACS_INT.
8085
8086 * xdisp.c (display_count_lines): 3rd argument and return value now
8087 EMACS_INT. All callers changed.
8088 (pint2hrstr): Last argument is now EMACS_INT.
8089
8090 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8091 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8092 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8093 (decode_coding_utf_16, decode_coding_emacs_mule)
8094 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8095 (decode_coding_ccl, decode_coding_charset)
8096 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8097 (decode_coding_iso_2022, decode_coding_emacs_mule)
8098 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8099 <char_offset, last_offset>: Declare EMACS_INT.
8100 (encode_coding_utf_8, encode_coding_utf_16)
8101 (encode_coding_emacs_mule, encode_invocation_designation)
8102 (encode_designation_at_bol, encode_coding_iso_2022)
8103 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8104 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8105 Declare EMACS_INT.
8106 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8107 (encode_invocation_designation): Last argument P_NCHARS is now
8108 EMACS_INT.
8109 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8110 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8111
8112 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8113 All users changed.
8114
8115 * ccl.c (Fccl_execute_on_string): Declare some variables
8116 EMACS_INT.
8117
8546720e 81182011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8119
8120 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8121
4e19a977
CS
81222011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8123
8124 * process.c (Fformat_network_address): Doc fix.
8125
87302331
R
81262011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8127
ee7683eb 8128 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8129
cbb59342
CY
81302011-04-08 Chong Yidong <cyd@stupidchicken.com>
8131
8132 * keyboard.c (read_char): Call Lisp function help-form-show,
8133 instead of using internal_with_output_to_temp_buffer.
8134 (Qhelp_form_show): New var.
e0d38eeb 8135 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8136
8137 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8138
8139 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8140
e67a13ab
CY
81412011-04-06 Chong Yidong <cyd@stupidchicken.com>
8142
04f2d78b
CB
8143 * process.c (Flist_processes): Remove to Lisp.
8144 (list_processes_1): Delete.
e67a13ab 8145
973f782d
EZ
81462011-04-06 Eli Zaretskii <eliz@gnu.org>
8147
7c106b1e
EZ
8148 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8149
973f782d
EZ
8150 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8151
41cf7d1a 81522011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8153
ca23cc88
PE
8154 Fix more problems found by GCC 4.6.0's static checks.
8155
f390e2d5
PE
8156 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8157
42eea0d0
PE
8158 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8159
b69769da 8160 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8161
f9541e84
PE
8162 * xdisp.c (vmessage): Mark as a printf-like function.
8163
13841b55
PE
8164 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8165
c136c10f
PE
8166 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8167
5e2d4a30
PE
8168 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8169 printf-like functions.
8170 (tiff_load): Add casts to remove these marks before passing them
8171 to system-supplied API.
8172
583f48b9
PE
8173 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8174
b25d760e
PE
8175 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8176 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8177 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8178 directly, rather than having caller test rule sign. This avoids
8179 some unnecessary tests.
8180 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8181 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8182 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8183
bc7b6697 8184 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8185 (xfont_open): Avoid unnecessary tests.
bc7b6697 8186
27ccc379
PE
8187 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8188
dcd5c89a
PE
8189 * composite.h, composite.c (composition_gstring_put_cache):
8190 Use EMACS_INT, not int, for length.
8191
b13a45c6
PE
8192 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8193 breaking out part of COMPOSITION_DECODE_RULE.
8194 (COMPOSITION_DECODE_RULE): Use it.
8195 * composite.c (get_composition_id): Remove unused local vars,
8196 by using the new macro.
8197
1e792e4d
PE
8198 * textprop.c (set_text_properties_1): Change while to do-while,
8199 since the condition is always true at first.
8200
dc6c6455 8201 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8202 (interval_deletion_adjustment): Return unsigned value.
8203 All uses changed.
dc6c6455 8204
aba7731a
PE
8205 * process.c (list_processes_1, create_pty, read_process_output):
8206 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8207 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8208 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8209 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8210 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8211
fdfc4bf3
PE
8212 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8213
fca8fe46 8214 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8215 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8216
06a0259a 8217 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8218 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8219 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8220
e7b9e80f
PE
8221 * print.c (print_error_message): Avoid int overflow.
8222
56201685
PE
8223 * font.c (font_list_entities): Redo for clarity,
8224 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8225
78834453 8226 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8227 (font_score): Avoid potential overflow in diff calculation.
78834453 8228
0bc0b309 8229 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8230 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8231
e610eaca
PE
8232 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8233
b895abce
PE
8234 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8235 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8236 can always succeed if overflow has undefined behavior.
8237
1f1d9321 8238 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8239 (wordify): Omit three unnecessary tests.
1f1d9321 8240
c59478bc
PE
8241 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8242 All callers changed. This avoids the need for an unused var.
8243
79b73827
PE
8244 * casefiddle.c (casify_region): Remove var that is set but not used.
8245
a4db5dfe
PE
8246 * dired.c (file_name_completion): Remove var that is set but not used.
8247
43aae36e
PE
8248 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8249
2a47c44d 8250 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8251 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8252
a37c69bf
PE
8253 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8254 Check for integer overflow on size calculations.
8255
328ab8e7
PE
8256 * buffer.c (Fprevious_overlay_change): Remove var that is set
8257 but not used.
8258
e5a2a5cb
PE
8259 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8260 Remove vars that are set but not used.
8d84a6eb 8261 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8262 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8263
a60e5f68
PE
8264 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8265
f661cb61 8266 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8267 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8268
f0397f5a
PE
8269 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8270 that are set but not used.
8271
8664db06 8272 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8273 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8274
6abdaa4a
PE
8275 * xselect.c (x_get_local_selection, x_handle_property_notify):
8276 Remove vars that are set but not used.
8277
0ce7538d 8278 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8279 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8280
9ae848fc
PE
8281 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8282 Remove var that is set but not used.
0b918413
PE
8283 (scroll_bar_windows_size): Now size_t, not int.
8284 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8285 Check for overflow.
9ae848fc 8286
a5a62657
PE
8287 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8288 (map_tty_color) [!defined MSDOS]: Likewise.
8289
5c5cdd39
PE
8290 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8291
66ebf983
PE
8292 * coding.c: Remove vars that are set but not used.
8293 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8294 All callers changed.
8295 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8296 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8297 (decode_coding_charset): Remove vars that are set but not used.
8298
1be4d761
PE
8299 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8300 that is set but not used.
8301
47553fa8
PE
8302 * print.c (print_object): Remove var that is set but not used.
8303
1f7196bf 8304 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8305 The gnulib version avoids calling malloc in the usual case,
8306 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8307 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8308 * filelock.c (current_lock_owner): Likewise.
8309 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8310 * sysdep.c: Include allocator.h, careadlinkat.h.
8311 (emacs_no_realloc_allocator): New static constant.
8312 (emacs_readlink): New function.
fdb61804
PE
8313 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8314 ../lib/careadlinkat.h.
d1fdcab7 8315
f84c17c7
SM
83162011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8317
8318 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8319 first non-nil return value).
8320
ef3862ad
JD
83212011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8322
8323 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8324 if not defined (Bug#8403).
8325
376a7006
JB
83262011-04-02 Juanma Barranquero <lekktu@gmail.com>
8327
8328 * xdisp.c (display_count_lines): Remove parameter `start',
8329 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8330 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8331 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8332 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8333 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8334 and thereabouts. All callers changed.
8335 (get_per_char_metric): Remove parameter `f', unused since
8336 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8337
6ca3801d
JM
83382011-04-02 Jim Meyering <meyering@redhat.com>
8339
8340 do not dereference NULL upon failed strdup
8341 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8342 (ns_get_family): Likewise.
8343
d8e2b5ba
JB
83442011-04-02 Juanma Barranquero <lekktu@gmail.com>
8345
8346 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8347
8c74fcbd
JD
83482011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8349
8350 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8351 later (Bug#8403).
8352
7200d79c
SM
83532011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8354
03408648 8355 Add lexical binding.
7200d79c 8356
03408648
SM
8357 * window.c (Ftemp_output_buffer_show): New fun.
8358 (Fsave_window_excursion):
8359 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8360
8361 * lread.c (lisp_file_lexically_bound_p): New function.
8362 (Fload): Bind Qlexical_binding.
8363 (readevalloop): Remove `evalfun' arg.
8364 Bind Qinternal_interpreter_environment.
8365 (Feval_buffer): Bind Qlexical_binding.
8366 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8367 Mark as dynamic.
8368 (syms_of_lread): Declare `lexical-binding'.
8369
8370 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8371
8372 * keyboard.c (eval_dyn): New fun.
8373 (menu_item_eval_property): Use it.
ca105506
SM
8374
8375 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8376
03408648
SM
8377 * fns.c (concat, mapcar1): Accept byte-code-functions.
8378
8379 * eval.c (Fsetq): Handle lexical vars.
8380 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8381 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8382 (FletX, Flet): Obey lexical binding.
8383 (Fcommandp): Handle closures.
8384 (Feval): New `lexical' arg.
8385 (eval_sub): New function extracted from Feval. Use it almost
8386 everywhere where Feval was used. Look up vars in lexical env.
8387 Handle closures.
8388 (Ffunctionp): Move from subr.el.
8389 (Ffuncall): Handle closures.
8390 (apply_lambda): Remove `eval_flags'.
8391 (funcall_lambda): Handle closures and new byte-code-functions.
8392 (Fspecial_variable_p): New function.
8393 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8394 but without exporting it to Lisp.
23aba0ea 8395
23aba0ea 8396 * doc.c (Fdocumentation, store_function_docstring):
03408648 8397 * data.c (Finteractive_form): Handle closures.
23aba0ea 8398
03408648
SM
8399 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8400 interactive spec.
ba83908c 8401
04f2d78b
CB
8402 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8403 New byte-codes.
03408648
SM
8404 (exec_byte_code): New function extracted from Fbyte_code to handle new
8405 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8406
03408648 8407 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8408
03408648 8409 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8410
e2abce01
JB
84112011-03-31 Juanma Barranquero <lekktu@gmail.com>
8412
8413 * xdisp.c (redisplay_internal): Fix prototype.
8414
63696a73 84152011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8416
63696a73 8417 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8418 (try_scrolling): Use it when setting scroll_limit.
8419 Limit scrolling to 100 screen lines.
63696a73
EZ
8420 (redisplay_window): Even when falling back on "recentering",
8421 position point in the window according to scroll-conservatively,
8422 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8423
8424 (try_scrolling): When point is above the window, allow searching
8425 as far as scroll_max, or one screenful, to compute vertical
8426 distance from PT to the scroll margin position. This prevents
8427 try_scrolling from unnecessarily failing when
8428 scroll-conservatively is set to a value slightly larger than the
8429 window height. Clean up the case of PT below the margin at bottom
8430 of window: scroll_max can no longer be INT_MAX. When aggressive
8431 scrolling is in use, don't let point enter the opposite scroll
8432 margin as result of the scroll.
8433 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8434 threshold of 100 lines for never-recentering scrolling.
8435
e4cc2dfc
JB
84362011-03-31 Juanma Barranquero <lekktu@gmail.com>
8437
8438 * dispextern.h (move_it_by_lines):
8439 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8440 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8441 (message_log_check_duplicate): Remove parameters `prev_bol' and
8442 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8443 (redisplay_internal): Remove parameter `preserve_echo_area',
8444 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8445
8446 * indent.c (Fvertical_motion):
8447 * window.c (window_scroll_pixel_based, Frecenter):
8448 Don't pass `need_y_p' to `move_it_by_lines'.
8449
1c470562
SM
84502011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8451
44f230aa
SM
8452 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8453 steal a few bits to be more compact.
8454 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8455 Remove unneeded casts.
8456
1c470562
SM
8457 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8458
888adce9
ZK
84592011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8460
8461 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8462 binding" message (bug#7967).
8463
f838ed7b
PE
84642011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8465
77861b95
PE
8466 Fix more problems found by GCC 4.6.0's static checks.
8467
de6dbc14
PE
8468 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8469 Remove unused local var.
8470
f838ed7b
PE
8471 * editfns.c (Fmessage_box): Remove unused local var.
8472
792c7b2b
PE
8473 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8474 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8475 Omit unused local vars.
c499e557 8476 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8477 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8478 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8479 Omit unused local var.
8480
ba0165e1
PE
8481 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8482 Don't assume string length fits in int.
32ad8845 8483 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8484 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8485
3c59b4c9
PE
8486 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8487 instead of alloca (Bug#8344).
8488
a3eed478 8489 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8490 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8491
eb4d412d
PE
8492 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8493
1658b401
PE
8494 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8495 concerns.
8496
8497 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8498
8499 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8500
9a2c6e05
PE
8501 * keyboard.c (syms_of_keyboard): Use the same style as later
8502 in this function when indexing through an array. This also
8503 works around GCC bug 48267.
8504
03d0a109
PE
8505 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8506
44f730c8
PE
8507 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8508
fe75f926
PE
8509 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8510 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8511
ffa8c828
PE
8512 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8513 This avoids undefined behavior on integer overflow, and is a bit
8514 more convenient anyway since it is compared to a size_t variable.
8515
c5101a77
PE
8516 Variadic C functions now count arguments with size_t, not int.
8517 This avoids an unnecessary limitation on 64-bit machines, which
8518 caused (substring ...) to crash on large vectors (Bug#8344).
8519 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8520 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8521 All variadic functions and their callers changed accordingly.
c5101a77
PE
8522 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8523 * data.c (arith_driver, float_arith_driver): Likewise.
8524 * editfns.c (general_insert_function): Likewise.
8525 * eval.c (struct backtrace.nargs, interactive_p)
8526 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8527 (funcall_lambda, mark_backtrace): Likewise.
8528 * fns.c (concat): Likewise.
8529 * frame.c (x_set_frame_parameters): Likewise.
8530 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8531 0 if not found, not -1. All callers changed.
8532
dd3f25f7
PE
8533 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8534 (stack_copy_size): Now size_t, not int.
8535 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8536
461c2ab9
JB
85372011-03-28 Juanma Barranquero <lekktu@gmail.com>
8538
8539 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8540 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8541 All callers changed.
8542
8543 * lisp.h (multibyte_char_to_unibyte):
8544 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8545 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8546 * character.h (CHAR_TO_BYTE8):
8547 * cmds.c (internal_self_insert):
8548 * editfns.c (general_insert_function):
8549 * keymap.c (push_key_description):
8550 * search.c (Freplace_match):
8551 * xdisp.c (message_dolog, set_message_1): All callers changed.
8552
f6d62986
SM
85532011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8554
8555 * keyboard.c (safe_run_hook_funcall): New function.
8556 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8557 don't set the hook to nil, but remove the offending function instead.
8558 (Qcommand_hook_internal): Remove, unused.
8559 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8560 Vcommand_hook_internal.
8561
8562 * eval.c (enum run_hooks_condition): Remove.
8563 (funcall_nil, funcall_not): New functions.
8564 (run_hook_with_args): Call each function through a `funcall' argument.
8565 Remove `cond' argument, now redundant.
8566 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8567 (Frun_hook_with_args_until_failure): Adjust accordingly.
8568 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8569
1db5b1ad
JB
85702011-03-28 Juanma Barranquero <lekktu@gmail.com>
8571
8572 * dispextern.h (string_buffer_position): Remove declaration.
8573
8574 * print.c (strout): Remove parameter `multibyte', unused since
8575 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8576
8577 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8578 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8579 All callers changed.
8580
8581 * w32.c (_wsa_errlist): Use braces for struct initializers.
8582
8583 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8584 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8585 All callers changed.
8586 (string_buffer_position): Likewise. Also, make static (it's never
8587 used outside xdisp.c).
8588 (cursor_row_p): Remove parameter `w', unused since
8589 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8590 (decode_mode_spec): Remove parameter `precision', introduced during
8591 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8592 All callers changed.
8593
5ffb62aa
JD
85942011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8595
8596 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8597
461c2ab9 85982011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8599
8600 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8601 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8602 (ns_update_auto_hide_menu_bar): New functions.
8603 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8604 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8605 ns_constrain_all_frames.
8606 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8607 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8608
5c380ffb
JD
86092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8610
8611 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8612
9af30bdf
GM
86132011-03-27 Glenn Morris <rgm@gnu.org>
8614
8615 * syssignal.h: Replace RETSIGTYPE with void.
8616 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8617 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8618 Replace SIGTYPE with void everywhere.
8619 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8620 * s/template.h (SIGTYPE): Remove commented out definition.
8621
e2abce01
JB
86222011-03-26 Eli Zaretskii <eliz@gnu.org>
8623
8624 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8625 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8626
f868cd8a
JB
86272011-03-26 Juanma Barranquero <lekktu@gmail.com>
8628
59eb0929
JB
8629 * w32.c (read_unc_volume): Use parameter `henum', instead of
8630 global variable `wget_enum_handle'.
8631
8632 * keymap.c (describe_vector): Remove parameters `indices' and
8633 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8634 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8635
f868cd8a
JB
8636 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8637
8638 * keyboard.c (timer_check): Remove parameter `do_it_now',
8639 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8640 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8641 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8642
8643 * keyboard.c (read_char):
8644 * w32menu.c (w32_menu_display_help):
8645 * xmenu.c (show_help_event, menu_help_callback):
8646 Adjust calls to `show_help_echo'.
8647
8648 * gtkutil.c (xg_maybe_add_timer):
8649 * keyboard.c (readable_events):
8650 * process.c (wait_reading_process_output):
8651 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8652
8653 * insdel.c (adjust_markers_gap_motion):
8654 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8655 (gap_left, gap_right): Don't call it.
8656
2ecf6fdb
CY
86572011-03-25 Chong Yidong <cyd@stupidchicken.com>
8658
8659 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8660 incurred during fontification.
8661
6b1f9ba4
JB
86622011-03-25 Juanma Barranquero <lekktu@gmail.com>
8663
8664 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8665 (DEFVAR_PER_BUFFER): Don't pass it.
8666
8667 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8668 (scrolling_window): Don't pass it.
8669
0f4a96b5
JB
86702011-03-25 Juanma Barranquero <lekktu@gmail.com>
8671
8672 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8673
8674 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8675 and `suffix'.
8676 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8677 of variables specific to SELinux and computation of `encoded_absname'.
8678
8679 * image.c (XPutPixel): Remove unused variable `height'.
8680
8681 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8682
8683 * unexw32.c (get_section_info): Remove unused variable `section'.
8684
8685 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8686 (system_process_attributes): Remove unused variable `sess'.
8687 (sys_read): Remove unused variable `err'.
8688
8689 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8690 (w32_wnd_proc): Remove unused variable `isdead'.
8691 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8692 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8693 (x_create_tip_frame): Remove unused variable `tem'.
8694
8695 * w32inevt.c (w32_console_read_socket):
8696 Remove unused variable `no_events'.
8697
8698 * w32term.c (x_draw_composite_glyph_string_foreground):
8699 Remove unused variable `width'.
8700
1149507c
JB
87012011-03-24 Juanma Barranquero <lekktu@gmail.com>
8702
8703 * w32term.c (x_set_glyph_string_clipping):
8704 Don't pass uninitialized region to CombineRgn.
8705
9c88f339
JB
87062011-03-23 Juanma Barranquero <lekktu@gmail.com>
8707
8708 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8709 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8710 (Fx_close_connection): Remove unused variable `i'.
8711
8712 * w32font.c (w32font_draw): Return number of glyphs.
8713 (w32font_open_internal): Remove unused variable `i'.
8714 (w32font_driver): Add missing initializer.
8715
8716 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8717 (fill_in_menu): Remove unused variable `items_added'.
8718
8719 * w32term.c (last_mouse_press_frame): Remove static global variable.
8720 (w32_clip_to_row): Remove unused variable `f'.
8721 (x_delete_terminal): Remove unused variable `i'.
8722
8723 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8724 (NOTHING): Remove unused static global variable.
8725 (uniscribe_check_otf): Remove unused variable `table'.
8726 (uniscribe_font_driver): Add missing initializers.
8727
dee091a3
JD
87282011-03-23 Julien Danjou <julien@danjou.info>
8729
8730 * term.c (Fsuspend_tty, Fresume_tty):
8731 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8732 * window.c (temp_output_buffer_show):
8733 * insdel.c (signal_before_change):
8734 * frame.c (Fhandle_switch_frame):
8735 * fileio.c (Fdo_auto_save):
8736 * emacs.c (Fkill_emacs):
8737 * editfns.c (save_excursion_restore):
8738 * cmds.c (internal_self_insert):
8739 * callint.c (Fcall_interactively):
8740 * buffer.c (Fkill_all_local_variables):
8741 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8742 Use Frun_hooks.
0f4a96b5 8743 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8744 unconditionally since it does the check itself.
dee091a3 8745
2c520ab5 87462011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8747
c9c49752
PE
8748 Fix more problems found by GCC 4.5.2's static checks.
8749
8abc3f12
PE
8750 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8751 the first time through the loop, since we know p0 < p1 then.
8752 This also avoids a gcc -Wstrict-overflow warning.
8753
a2d26660
PE
8754 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8755 leading to a memory leak, possible in functions like
8756 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8757 of objects (Bug#8318).
a2d26660 8758
916c72e9
PE
8759 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8760 that could (at least in theory) be that large.
8761
19ab8a18
PE
8762 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8763 This is less likely to overflow, and avoids undefined behavior if
8764 overflow does occur. All callers changed. Use strtoul to scan
8765 for the unsigned long integer.
b7cbbd6f
PE
8766 (pint2hrstr): Simplify and tune code slightly.
8767 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8768
f0641eff
PE
8769 * scroll.c (do_scrolling): Work around GCC bug 48228.
8770 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8771
7f650bb9
PE
8772 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8773 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8774 (validate_x_resource_name): Simplify count usage.
8775 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8776
37dd57d1
PE
8777 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8778 fail (Bug#8306).
81e56e61 8779
699979fc 8780 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8781
401bf9b4
PE
8782 * process.c (Fmake_network_process): Use socklen_t, not int,
8783 where POSIX says socklen_t is required in portable programs.
8784 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8785 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8786 (Fmake_network_process, server_accept_connection):
8787 (wait_reading_process_output, read_process_output):
8788 Likewise.
8789
b93aacde
PE
8790 * process.c: Rename or move locals to avoid shadowing.
8791 (list_processes_1, Fmake_network_process):
8792 (read_process_output_error_handler, exec_sentinel_error_handler):
8793 Rename or move locals.
4dc343ee 8794 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8795 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8796 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8797 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8798 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8799
af8a867c 8800 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8801 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8802 Include tparam.h instead, since it declares them.
af8a867c
PE
8803 * cm.h (PC): Remove extern decl; tparam.h now does this.
8804 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8805 * terminfo.c: Include tparam.h, to check interfaces.
8806 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8807 (tparam): Adjust signature to match interface in tparam.h;
8808 this removes some undefined behavior. Check that outstring and len
8809 are zero, which they always are with Emacs.
8810 * tparam.h (PC, BC, UP): New extern decls.
8811
0248044d 8812 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8813 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8814
8ff096c1 8815 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8816 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8817 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8818 (ftfont_list): Remove unused local.
49eaafba
PE
8819 (get_adstyle_property, ftfont_pattern_entity):
8820 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8821 Rename locals to avoid shadowing.
8ff096c1 8822
e2be39f6
PE
8823 * xfont.c (xfont_list_family): Mark var as initialized.
8824
c9735e30
PE
8825 * xml.c (make_dom): Now static.
8826
8f5201ae
PE
8827 * composite.c (composition_compute_stop_pos): Rename local to
8828 avoid shadowing.
b246f932
PE
8829 (composition_reseat_it): Remove unused locals.
8830 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8831 (composition_update_it): Mark var as initialized.
11b61122
PE
8832 (find_automatic_composition): Mark vars as initialized,
8833 with a FIXME (Bug#8290).
8f5201ae 8834
760fbc2c
PE
8835 character.h: Rename locals to avoid shadowing.
8836 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8837 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8838 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8839 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8840 to avoid shadowing.
8841
ff08eb85
PE
8842 * textprop.c (property_change_between_p): Remove; unused.
8843
fc7bf025
PE
8844 * intervals.c (interval_start_pos): Now static.
8845
235d7abc
PE
8846 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8847
44f230aa
SM
8848 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8849 Rename locals to avoid shadowing.
3e7d6594 8850
50060332
PE
8851 * sound.c (wav_play, au_play, Fplay_sound_internal):
8852 Fix pointer signedness.
d01f234b 8853 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8854 (wav_play): Initialize a variable to 0, to prevent undefined
8855 behavior (Bug#8278).
50060332 8856
c4fc4e30
PE
8857 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8858
918436ed
PE
8859 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8860
c939f91b
PE
8861 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8862 clobbering (Bug#8298).
b9c7f648
PE
8863 * sysdep.c (sys_subshell): Likewise.
8864 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8865
6bd8c144
PE
8866 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8867 This should get cleaned up, so that child_setup has the
8868 same signature on all platforms.
8869
7710357c 8870 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8871 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8872
c59da222
CY
88732011-03-22 Chong Yidong <cyd@stupidchicken.com>
8874
8875 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8876 not to be necessary, and produces flickering.
8877
66b87493
GM
88782011-03-20 Glenn Morris <rgm@gnu.org>
8879
8880 * config.in: Remove file.
8881
45b6f6d5
JB
88822011-03-20 Juanma Barranquero <lekktu@gmail.com>
8883
8884 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8885 are now in src/globals.h.
8886 (syms_of_minibuf): Remove spurious & from previous change.
8887
cd394be1 88882011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8889
8890 * minibuf.c (completing-read-function): New variable.
8891 (completing-read-default): Rename from completing-read.
8892 (completing-read): Call completing-read-function.
8893
b14e3e21
CY
88942011-03-19 Juanma Barranquero <lekktu@gmail.com>
8895
8896 * xfaces.c (Fx_load_color_file):
8897 Read color file from absolute filename (bug#8250).
8898
f2b726e6
JB
88992011-03-19 Juanma Barranquero <lekktu@gmail.com>
8900
8901 * makefile.w32-in: Update dependencies.
8902
09f6ff02
EZ
89032011-03-17 Eli Zaretskii <eliz@gnu.org>
8904
8905 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8906
29a6015a
PE
89072011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8908
a3a6c54e
PE
8909 Fix more problems found by GCC 4.5.2's static checks.
8910
b766f867
PE
8911 * process.c (make_serial_process_unwind, send_process_trap):
8912 (sigchld_handler): Now static.
8913
be02381c
PE
8914 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8915 That way, the code declares only the vars that it needs.
8916 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8917 * s/cygwin.h (PTY_ITERATION): Likewise.
8918 * s/darwin.h (PTY_ITERATION): Likewise.
8919 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8920
57048744
PE
8921 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8922 * process.c (allocate_pty): Don't declare stb unless it's needed.
8923
7914961c 8924 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8925 (CONSTANTLIM): Remove; unused.
8926 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8927 Define only if needed.
7914961c 8928
b3967b18
PE
8929 * unexelf.c (unexec): Name an expression,
8930 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8931 Use a different way to cause a compilation error if anyone uses
8932 n rather than nn, a way that does not involve shadowing.
73366a00 8933 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8934
29a6015a
PE
8935 * deps.mk (unexalpha.o): Remove; unused.
8936
43cfc33e 8937 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8938 * unexec.h: New file.
ce701a33
PE
8939 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8940 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8941 Depend on unexec.h.
8942 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8943 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8944 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8945 Change as necessary to match prototype in unexec.h.
ce701a33 8946
01f44d5a
PE
8947 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8948 shadowing.
4f63c6bb 8949 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8950
a6670b0b
PE
8951 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8952 Rename locals to avoid shadowing.
8953
cef2010d 8954 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8955 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8956
d4d7173a
PE
8957 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8958
f08b802a
PE
8959 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8960 warning when compiling print.c.
8961
3ddb0639
PE
8962 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8963 instead of using an uninitialized var.
5ad03b97 8964 (font_sort_entities): Mark var as initialized.
3ddb0639 8965
170a2692
PE
8966 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8967
e663c700
PE
8968 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8969 pointers to constants.
89bc529a 8970 (font_parse_fcname): Remove unused vars.
7b81e2d0 8971 (font_delete_unmatched): Now static.
ea838e10 8972 (font_get_spec): Remove; unused.
13a547c6
PE
8973 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8974 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8975 Rename or move locals to avoid shadowing.
e663c700 8976
2a80c887 8977 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8978 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8979
1384fa33 8980 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8981 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8982
8b2c52e9
PE
8983 * alloc.c (mark_backtrace): Move decl from here ...
8984 * lisp.h: ... to here, so that it can be checked.
8985
475545b5 8986 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8987 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8988 (lisp_indirect_variable): Name an expression,
8989 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8990 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8991
b1349114 8992 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8993 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8994 Use const pointer when appropriate.
b1349114 8995
a2928364
PE
8996 * lisp.h (get_system_name, get_operating_system_release):
8997 Move decls here, to check interfaces.
8998 * process.c (get_operating_system_release): Move decl to lisp.h.
8999 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9000 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9001 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9002 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9003 (Fformat_time_string, Fencode_time, Finsert_char):
9004 (Ftranslate_region_internal, Fformat):
9005 Rename or remove local vars to avoid shadowing.
9710023e 9006 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9007
a415e694
PE
9008 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9009 avoid shadowing.
9010
8ef4622d
PE
9011 * lisp.h (eassert): Check that the argument compiles, even if
9012 ENABLE_CHECKING is not defined.
9013
946f9a5b
PE
9014 * data.c (Findirect_variable): Name an expression, to avoid
9015 gcc -Wbad-function-cast warning.
112396d6 9016 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9017 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9018 (Fmake_variable_buffer_local, Fmake_local_variable):
9019 Mark variables as initialized.
52746918 9020 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9021
e5aab7e7 9022 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9023 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9024 Rename locals to avoid shadowing.
dff45157
PE
9025 (mark_stack): Move local variables into the #ifdef region where
9026 they're used.
7bc26fdb
PE
9027 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9028 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9029 needed otherwise.
9030 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9031 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9032 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9033
e5aab7e7
PE
9034 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9035 avoids undefined behavior in theory.
9036
4da60324
PE
9037 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9038
88043301
PE
9039 Use functions, not macros, for up- and down-casing (Bug#8254).
9040 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9041 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9042 to use the following functions instead of these macros.
9043 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9044 EMACS_INT, since callers assume the returned value fits in int.
9045 (upcase1): Likewise, for UPCASE_TABLE.
9046 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9047 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9048 the race-condition problem in the old DOWNCASE.
88043301 9049
19ed5445
PE
9050 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9051 Rename locals to avoid shadowing.
9052 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9053 (regex_compile, re_search_2, re_match_2_internal):
9054 Remove unused local vars.
952db0d7
PE
9055 (FREE_VAR): Rewrite so as not to use empty "else",
9056 which gcc can warn about.
da053e48 9057 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9058 (RETALLOC_IF): Define only if needed.
9059 (WORDCHAR_P): Likewise. This one is never needed, but is used
9060 only in a comment talking about a compiler bug, so put inside
9061 the #if 0 of that comment.
9062 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9063 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9064 Remove; unused.
19ed5445 9065
1f3561e4 9066 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9067 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9068 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9069
ded6f8f7
PE
9070 * search.c (simple_search): Remove unused var.
9071
dbd37a95
PE
9072 * dired.c (compile_pattern): Move decl from here ...
9073 * lisp.h: ... to here, so that it can be checked.
9074 (struct re_registers): New forward decl.
9075
7e47afad
PE
9076 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9077
85f24f61
PE
9078 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9079 All uses changed.
9080 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9081 Rename locals to avoid shadowing.
5671df8f 9082 (Fvertical_motion): Mark locals as initialized.
85f24f61 9083
181aa2be 9084 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9085 (casify_region): Mark local as initialized.
181aa2be 9086
930d429c
PE
9087 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9088
7082eac6
PE
9089 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9090 New macros, so that the caller can use some names other than
9091 gcpro1, gcpro2, etc.
9092 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9093 of the new macros.
9094 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9095 argument, for consistency with GCPRO2_VAR, etc: it is now the
9096 prefix of the variable, not the variable itself. All uses
9097 changed.
38b2c076
PE
9098 * dired.c (directory_files_internal, file_name_completion):
9099 Rename locals to avoid shadowing.
9100
15206ed9
PE
9101 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9102 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9103 dired.c's scmp function, had undefined behavior.
9104 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9105 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9106 * buffer.h: ... to here, because these macros use current_buffer,
9107 and the new implementation with inline functions needs to have
9108 current_buffer in scope now, rather than later when the macros
9109 are used.
9110 (downcase, upcase1): New static inline functions.
9111 (DOWNCASE, UPCASE1): Reimplement using these functions.
9112 This avoids undefined behavior in expressions like
9113 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9114 from race conditions in accessing the global variables
9115 case_temp1 and case_temp2.
9116 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9117 * lisp.h (case_temp1, case_temp2): Remove their decls.
9118 * character.h (ASCII_CHAR_P): Move from here ...
9119 * lisp.h: ... to here, so that the inline functions mentioned
9120 above can use them.
9121
4a6bea26
PE
9122 * dired.c (directory_files_internal_unwind): Now static.
9123
f14b7e14
PE
9124 * fileio.c (file_name_as_directory, directory_file_name):
9125 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9126 Now static.
2893f146
PE
9127 (file_name_as_directory): Use const pointers when appropriate.
9128 (Fexpand_file_name): Likewise. In particular, newdir might
9129 point at constant storage, so make it a const pointer.
fd4ead52 9130 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9131 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9132 signedness issues.
f839df0c
PE
9133 (Fset_file_times, Finsert_file_contents, auto_save_error):
9134 Rename locals to avoid shadowing.
f14b7e14 9135
5716756e 9136 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9137 (Ftry_completion, Fall_completions): Rename or remove locals
9138 to avoid shadowing.
5716756e 9139
b4c3046a
PE
9140 * marker.c (bytepos_to_charpos): Remove; unused.
9141
b45db522
PE
9142 * lisp.h (verify_bytepos, count_markers): New decls,
9143 so that gcc does not warn that these functions aren't declared.
9144
85876d07
PE
9145 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9146 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9147 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9148 (copy_text): Remove unused local var.
85876d07 9149
03d78a21 9150 * filelock.c (within_one_second): Now static.
b3dd38ab 9151 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9152
5df8f01b
PE
9153 * buffer.c (fix_overlays_before): Mark locals as initialized.
9154 (fix_start_end_in_overlays): Likewise. This function should be
9155 simplified by using pointers-to-pointers, but that's a different
9156 matter.
b1d876f1 9157 (switch_to_buffer_1): Now static.
8f54f30a
PE
9158 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9159 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9160
a70072c9 9161 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9162 Fix pointer signedness issue.
edced198
PE
9163 (sys_subshell): Mark local as volatile if checking for lint,
9164 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9165 (MAXPATHLEN): Define only if needed.
a70072c9 9166
a0977c44
PE
9167 * process.c (serial_open, serial_configure): Move decls from here ...
9168 * systty.h: ... to here, so that they can be checked.
9169
a884fdcc
PE
9170 * fns.c (get_random, seed_random): Move extern decls from here ...
9171 * lisp.h: ... to here, so that they can be checked.
9172
604efe86 9173 * sysdep.c (reset_io): Now static.
b8950c94 9174 (wait_for_termination_signal): Remove; unused.
604efe86 9175
38fc62d9
PE
9176 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9177 (copy_keymap_item, append_key, push_text_char_description):
9178 Now static.
1004a21a 9179 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9180 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9181 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9182 (describe_map_tree):
9183 Rename locals to avoid shadowing.
38fc62d9 9184
2f2650da
PE
9185 * keyboard.c: Declare functions static if they are not used elsewhere.
9186 (echo_char, echo_dash, cmd_error, top_level_2):
9187 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9188 (read_char, kbd_buffer_get_event, make_lispy_position):
9189 (make_lispy_event, make_lispy_movement, apply_modifiers):
9190 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9191 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9192 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9193 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9194 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9195
a053e86c 9196 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9197 (mark_kboards): Move decl here ...
9198 * alloc.c (mark_kboards): ... from here.
a053e86c 9199
4752793e
PE
9200 * lisp.h (force_auto_save_soon): New decl.
9201
74f10ca7 9202 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9203 (DEFINE_DUMMY_FUNCTION): New macro.
9204 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9205 Use it.
c03cd23f
PE
9206 (main): Add casts to avoid warnings
9207 if GCC considers string literals to be constants.
74f10ca7 9208
022e70d4
PE
9209 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9210
59d6fe83
PE
9211 * dbusbind.c: Pointer signedness fixes.
9212 (xd_signature, xd_append_arg, xd_initialize):
9213 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9214 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9215 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9216 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9217
78320123
PE
9218 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9219 if GCC considers string literals to be constants.
49cebcca 9220 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9221
35ac2a97
SM
92222011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9223
fb103ca9
SM
9224 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9225 (print_preprocess, print_object): New macro to fix last change.
9226
35ac2a97
SM
9227 * print.c (print_preprocess): Don't forget font objects.
9228
62973b41
JB
92292011-03-16 Juanma Barranquero <lekktu@gmail.com>
9230
9231 * emacs.c (USAGE3): Doc fixes.
9232
0e48bb22
AS
92332011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9234
9235 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9236 structure.
9237
7684e57b
JB
92382011-03-14 Juanma Barranquero <lekktu@gmail.com>
9239
9240 * lisp.h (VWindow_system, Qfile_name_history):
9241 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9242 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9243 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9244
9245 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9246 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9247
9248 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9249 * w32console.c (detect_input_pending, read_input_pending)
9250 (encode_terminal_code):
9251 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9252 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9253 (w32_system_caret_y, Qfile_name_history):
9254 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9255 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9256 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9257 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9258 * w32proc.c (Qlocal, report_file_error):
9259 * w32term.c (Vwindow_system, updating_frame):
9260 * w32uniscribe.c (initialized, uniscribe_font_driver):
9261 Remove unneeded extern declarations.
9262
2aa46d6c
CY
92632011-03-14 Chong Yidong <cyd@stupidchicken.com>
9264
c96bbc66 9265 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9266
cffc6f3b
CY
92672011-03-13 Chong Yidong <cyd@stupidchicken.com>
9268
9269 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9270 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9271 These macros can no longer be used for assignment.
9272
44f230aa
SM
9273 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9274 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9275 (record_buffer_markers, fetch_buffer_markers): New functions for
9276 recording and fetching special buffer markers.
9277 (set_buffer_internal_1, set_buffer_temp): Use them.
9278
9279 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9280
9281 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9282
9283 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9284 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9285
9286 * xdisp.c (hscroll_window_tree):
9287 (reconsider_clip_changes): Use PT instead of BUF_PT.
9288
d251f04b
EZ
92892011-03-13 Eli Zaretskii <eliz@gnu.org>
9290
9291 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9292 $(EMACS_ROOT)/lib/intprops.h.
9293
f0c77cd1
PE
92942011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9295
3eca4629
PE
9296 Fix more problems found by GCC 4.5.2's static checks.
9297
7c86ee98
PE
9298 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9299 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9300 (xg_free_frame_widgets): Make it clear that a local variable is
9301 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9302 (gdk_window_get_screen): Make it clear that this macro is needed
9303 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9304 (int_gtk_range_get_value): New function, which avoids a diagnostic
9305 from gcc -Wbad-function-cast.
9306 (xg_set_toolkit_scroll_bar_thumb): Use it.
9307 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9308 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9309 (get_utf8_string, xg_get_file_with_chooser):
9310 Rename locals to avoid shadowing.
9311 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9312
41729b81
PE
9313 * xgselect.c (xg_select): Remove unused var.
9314
f0c77cd1
PE
9315 * image.c (four_corners_best): Mark locals as initialized.
9316 (gif_load): Initialize transparent_p to zero (Bug#8238).
9317 Mark another local as initialized.
ec6cf4c6 9318 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9319
ce0ad53d 9320 * image.c (clear_image_cache): Now static.
d5d5a617 9321 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9322 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9323 (x_edge_detection): Remove unnecessary cast that
9324 gcc -Wbad-function-cast diagnoses.
2037898d 9325 (gif_load): Fix pointer signedness.
6ae141d6
PE
9326 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9327 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9328
33383987 93292011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9330
d32df629
PE
9331 Improve quality of tests for time stamp overflow.
9332 For example, without this patch (encode-time 0 0 0 1 1
9333 1152921504606846976) returns the obviously-bogus value (-948597
9334 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9335 reports time overflow. See
9336 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9337 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9338 * editfns.c: Include limits.h and intprops.h.
9339 (TIME_T_MIN, TIME_T_MAX): New macros.
9340 (time_overflow): Move earlier, to before first use.
9341 (hi_time, lo_time): New functions, for an accurate test for
9342 out-of-range times.
9343 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9344 (Fget_internal_run_time): Don't assume time_t fits in int.
9345 (make_time): Use list2 instead of Fcons twice.
9346 (Fdecode_time): More accurate test for out-of-range times.
9347 (check_tm_member): New function.
9348 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9349 (lisp_time_argument): Don't rely on undefined left-shift and
9350 right-shift behavior when checking for time stamp overflow.
8be6f318 9351
fe31d94c
PE
9352 * editfns.c (time_overflow): New function, refactoring common code.
9353 (Fformat_time_string, Fdecode_time, Fencode_time):
9354 (Fcurrent_time_string): Use it.
9355
8be6f318
PE
9356 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9357 * dired.c (make_time): Move to ...
9358 * editfns.c (make_time): ... here.
9359 * systime.h: Note the move.
9360
09d9db2c 93612011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9362
126bc0dc
YM
9363 * fringe.c (update_window_fringes): Remove unused variables.
9364
c47cbdfd
YM
9365 * unexmacosx.c (copy_data_segment): Also copy __got section.
9366 (Bug#8223)
9367
7ac80be9
EZ
93682011-03-12 Eli Zaretskii <eliz@gnu.org>
9369
c96bbc66 9370 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9371 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9372 Constify `char *' arguments and their references according to
9373 prototypes in tparam.h.
9374
ecb0f94d 9375 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9376
7ac80be9
EZ
9377 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9378 Adapt all references accordingly.
9379
9380 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9381
ef1fd07e
TT
93822011-03-11 Tom Tromey <tromey@redhat.com>
9383
9384 * buffer.c (syms_of_buffer): Remove obsolete comment.
9385
7ef4b50c
EZ
93862011-03-11 Eli Zaretskii <eliz@gnu.org>
9387
9388 * termhooks.h (encode_terminal_code): Declare prototype.
9389
9390 * msdos.c (encode_terminal_code): Don't declare prototype.
9391
9392 * term.c (encode_terminal_code): Now external again, used by
9393 w32console.c and msdos.c.
9394
44f230aa
SM
9395 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9396 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9397
4b1ec863 93982011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9399
1714f52b 9400 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9401
4b1ec863
PE
9402 * fringe.c (update_window_fringes): Mark locals as initialized
9403 (Bug#8227).
9404 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9405
524c7aa6
PE
9406 * alloc.c (mark_fringe_data): Move decl from here ...
9407 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9408 to check its interface.
9409 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9410
a5c0af81 9411 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9412 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9413 (fontset_font): Mark local as initialized.
a9a06e0b 9414 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9415
b4716021
PE
9416 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9417
811e9bac 9418 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9419 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9420 (x_own_selection, Fx_disown_selection_internal): Rename locals
9421 to avoid shadowing.
9422 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9423
7e3ab302
PE
9424 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9425 so that the caller can use some name other than gcpro1.
9426 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9427 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9428 (Fx_backspace_delete_keys_p):
9429 Use them to avoid shadowing, and rename vars to avoid shadowing.
9430 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9431 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9432 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9433 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9434 Remove unused locals.
7e3ab302
PE
9435 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9436 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9437 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9438 macros.
f78faa98 9439
e2b13473
PE
9440 * xterm.h (x_mouse_leave): New decl.
9441
77f23912
PE
9442 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9443 Remove unused functions.
cdf4ba58
PE
9444 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9445 (x_calc_absolute_position): Now static.
7411c686 9446 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9447 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9448 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9449 unless they are used.
38d0b34a
PE
9450 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9451 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9452 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9453 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9454 (x_error_catcher, x_connection_closed, x_error_handler):
9455 (x_error_quitter, xembed_send_message, x_iconify_frame):
9456 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9457 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9458 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9459
44f230aa
SM
9460 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9461 Rename or move locals to avoid shadowing.
6b463e58 9462 (tty_defined_color, merge_face_heights): Now static.
5967d051 9463 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9464 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9465 does not deduce is never used uninitialized.
73719eba
PE
9466 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9467 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9468
426994c3 9469 * terminal.c (store_terminal_param): Now static.
5489860b 9470
032f1620 9471 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9472 (set_frame_menubar): Remove unused local.
d4323972 9473 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9474 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9475 since they might point to immutable storage.
281585b0
PE
9476 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9477 since it's unused otherwise.
032f1620 9478
367c19e5 9479 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9480 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9481 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9482 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9483 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9484 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9485 does not deduce are never used uninitialized.
70739cbe 9486
07b48fa9
PE
9487 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9488
8868a238 9489 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9490 * window.c (window_loop, size_window):
9491 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9492
7e5cf297 9493 * window.c (display_buffer): Now static.
d6550a9f
PE
9494 (size_window): Mark variables that gcc -Wuninitialized
9495 does not deduce are never used uninitialized.
a586633d
PE
9496 * window.h (check_all_windows): New decl, to forestall
9497 gcc -Wmissing-prototypes diagnostic.
5b555da1 9498 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9499
f6095868
PE
9500 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9501 shadowing.
9502 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9503 Include <limits.h>.
9504 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9505 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9506 (load_charset_map): Mark variables that gcc -Wuninitialized
9507 does not deduce are never used uninitialized.
53df7c11 9508 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9509
f38b440c
PE
9510 * coding.c (coding_set_source, coding_set_destination):
9511 Use "else { /* comment */ }" rather than "else /* comment */;"
9512 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9513 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9514 a block, when the outer 'i' will do.
9515 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9516 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9517 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9518 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9519 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9520 Rename locals to avoid shadowing.
9521 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9522 * coding.c (emacs_mule_char, encode_invocation_designation):
9523 Now static, since they're not used elsewhere.
413bb2db 9524 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9525 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9526 (decode_coding_emacs_mule): Mark variables that gcc
9527 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9528 (detect_coding_iso_2022): Initialize a local variable that might
9529 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9530 this initialization is needed. (Bug#8211)
5f58e762
PE
9531 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9532 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9533 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9534 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9535 Remove unused macros.
f38b440c 9536
232b38b9 9537 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9538 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9539 * character.c (string_count_byte8): Likewise.
232b38b9 9540
fb90da1b
PE
9541 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9542 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9543
fb93dbc2
PE
9544 * chartab.c (copy_sub_char_table): Now static, since it's not used
9545 elsewhere.
5c156ace
PE
9546 (sub_char_table_ref_and_range, char_table_ref_and_range):
9547 Rename locals to avoid shadowing.
bbcd0949 9548 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9549
7d3b3862 9550 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9551 (BIDI_BOB): Remove unused macro.
7d3b3862 9552
6be7d3da
PE
9553 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9554 deduce are never used uninitialized.
c2ed9c8b 9555 * term.c (encode_terminal_code): Likewise.
6be7d3da 9556
75f8807f 9557 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9558
50938595
PE
9559 * tparam.h: New file.
9560 * term.c, tparam.h: Include it.
9561 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9562 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9563 Move these decls to tparam.h, and make them agree with what
9564 is actually in tparam.c. The previous trick of using incompatible
9565 decls in different modules does not conform to the C standard.
9566 All callers of tparam changed to use tparam's actual API.
9567 * tparam.c (tparam1, tparam, tgoto):
9568 Use const pointers where appropriate.
9569
fbceeba2
PE
9570 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9571 * cm.h (struct cm): Likewise.
9572 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9573 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9574 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9575 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9576 (turn_on_face, init_tty): Likewise.
9577 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9578
7f3f1250
PE
9579 * term.c (term_mouse_position): Rename local to avoid shadowing.
9580
e6ca6543
PE
9581 * alloc.c (mark_ttys): Move decl from here ...
9582 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9583
c40f8d15
AS
95842011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9585
9586 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9587
cfe0661d
JB
95882011-03-09 Juanma Barranquero <lekktu@gmail.com>
9589
9590 * search.c (compile_pattern_1): Remove argument regp, unused since
9591 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9592 (compile_pattern): Don't pass it.
9593
0afb4571
J
95942011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9595
9596 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9597 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9598 for ! HAVE_GTK3.
9599 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9600
9601 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9602
9603 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9604 gdk_window_get_screen, gdk_window_get_geometry,
9605 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9606 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9607 (xg_get_pixbuf_from_pixmap): New function.
9608 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9609 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9610 Call xg_get_pixbuf_from_pixmap instead of
9611 gdk_pixbuf_get_from_drawable.
9612 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9613 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9614 (xg_check_special_colors): Use GtkStyleContext and its functions
9615 for HAVE_GTK3.
9616 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9617 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9618 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9619 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9620 Call gtk_widget_get_preferred_size.
0afb4571
J
9621 (xg_frame_resized): gdk_window_get_geometry only takes 5
9622 parameters.
44f230aa
SM
9623 (xg_win_to_widget, xg_event_is_for_menubar):
9624 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9625 (xg_set_widget_bg): New function.
9626 (delete_cb): New function.
895009e1 9627 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9628 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9629 (xg_set_background_color): Call xg_set_widget_bg.
9630 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9631 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9632 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9633 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9634 if ! HAVE_GTK3.
9635 (update_frame_tool_bar): Call gtk_widget_hide.
9636 (xg_initialize): Use GDK_KEY_g.
9637
9638 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9639 if ! HAVE_GTK3
9640 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9641
9642 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9643 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9644 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9645
1c2cc4ef
JB
96462011-03-08 Juanma Barranquero <lekktu@gmail.com>
9647
9648 * w32xfns.c (select_palette): Check success of RealizePalette against
9649 GDI_ERROR, not zero.
9650
33383987 9651See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9652
9653;; Local Variables:
9654;; coding: utf-8
aac0c6e3
MR
9655;; End:
9656
acaf905b 9657 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9658
9659 This file is part of GNU Emacs.
9660
9661 GNU Emacs is free software: you can redistribute it and/or modify
9662 it under the terms of the GNU General Public License as published by
9663 the Free Software Foundation, either version 3 of the License, or
9664 (at your option) any later version.
9665
9666 GNU Emacs is distributed in the hope that it will be useful,
9667 but WITHOUT ANY WARRANTY; without even the implied warranty of
9668 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9669 GNU General Public License for more details.
9670
9671 You should have received a copy of the GNU General Public License
9672 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.