Add gnus-notifications.el
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7f8941d8
JD
12012-08-28 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
4 button_values to NULL. Call setStykeMask so dialogs get a close button.
5 (windowShouldClose:): Set window_closed.
6 (dealloc): New member, free button_values.
7 (process_dialog:): Make member function. Remove window argument,
8 replace window with self. Count buttons and allocate and store values
9 in button_values.
10 (addButton:value:row:): value is int with the name tag. Call setTag
11 with tag. Remove return self, declare return value as void.
12 (addString:row:): Remove return self, declare return value as void.
13 (addSplit): Remove return self, declare return value as void.
14 (clicked:): Remove return self, declare return value as void.
15 Set dialog_return to button_values[seltag]. Code formatting change.
16 (initFromContents:isQuestion:): Adjust call to process_dialog.
17 Code formatting change.
18 (timeout_handler:): Set timer_fired to YES.
19 (runDialogAt:): Set timer_fired to NO.
20 Handle click on close button as quit.
21
22 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
23 Add window_closed and button_values. Add void as return value for
24 add(Button|String|Split). addButton takes int instead of Lisp_Object.
25 Add process_dialog as new member.
26
eada0861 272012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 28
eada0861
GM
29 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
30 is not one of the heaps we manage. (Bug#12242)
31
322012-08-28 Glenn Morris <rgm@gnu.org>
33
34 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
35
457294dd
MR
362012-08-28 Martin Rudalics <rudalics@gmx.at>
37
38 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
39 auto-buffer-name window parameter. Install revision of reverted
40 fix.
457294dd 41
4f2daf31
DA
422012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
43
44 Do not allow to set major mode for a dead buffer.
45 * buffer.c (Fset_buffer_major_mode): Signal an error
46 if the buffer is dead.
47 (Fother_buffer, other_buffer_safely): Remove redundant
48 nested declaration.
49
66322887
DA
502012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
51
52 Always use set_buffer_if_live to restore original buffer at unwind.
53 * buffer.h (record_unwind_current_buffer): New function.
54 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
55 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
56 * undo.c, window.c: Adjust users.
57 * buffer.c (set_buffer_if_live): Fix comment.
58
a3d794a1
DA
592012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
60
61 Fix usage of set_buffer_internal.
62 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
63 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
64 * coding.c (decode_coding): Omit redundant test.
65 * fileio.c (decide_coding_unwind): Likewise.
66 * fns.c (secure_hash): Likewise.
67 * insdel.c (modify_region): Likewise.
68 * keyboard.c (command_loop_1): Likewise.
69 * print.c (PRINTFINISH): Likewise.
70 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
71
59ea14cd
PE
722012-08-27 Paul Eggert <eggert@cs.ucla.edu>
73
74 * dispnew.c: Use bool for boolean.
75 (frame_garbaged, display_completed, delayed_size_change)
76 (fonts_changed_p, add_window_display_history)
77 (add_frame_display_history, verify_row_hash)
78 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
79 (row_equal_p, realloc_glyph_pool)
80 (allocate_matrices_for_frame_redisplay)
81 (showing_window_margins_p)
82 (adjust_frame_glyphs_for_frame_redisplay)
83 (build_frame_matrix_from_leaf_window, make_current)
84 (mirrored_line_dance, mirror_line_dance, update_frame)
85 (update_window_tree, update_single_window)
86 (check_current_matrix_flags, update_window, update_text_area)
87 (update_window_line, set_window_update_flags, scrolling_window)
88 (update_frame_1, scrolling, buffer_posn_from_coords)
89 (do_pending_window_change, change_frame_size)
90 (change_frame_size_1, sit_for):
91 Use bool for boolean.
92 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
93 and remove last int (actually boolean) argument, which was always 0.
94 All callers changed.
95 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
96 * dispextern.h (struct composition_it): Use bool for boolean.
97 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
98 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
99 * dired.c (file_name_completion):
100 Use bool for boolean. (This was missed in an earlier change.)
101
95072a94
MR
1022012-08-27 Martin Rudalics <rudalics@gmx.at>
103
104 * window.c (Fset_window_configuration): Revert first part of
105 last change.
106
0f19feff
JD
1072012-08-27 Jan Djärv <jan.h.d@swipnet.se>
108
109 * nsterm.h (NSPanel): New class variable dialog_return.
110
111 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
112 dialog_return.
113 (windowShouldClose:): Use stop instead of stopModalWithCode.
114 (clicked:): Ditto, and also set dialog_return (Bug#12258).
115 (timeout_handler:): Use stop instead of abortModal. Send a dummy
116 event.
117 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
118 modal loop returns.
119
f10fe38f
PE
1202012-08-27 Paul Eggert <eggert@cs.ucla.edu>
121
de1339b0
PE
122 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
123 * composite.c (find_composition, composition_gstring_p)
124 (composition_reseat_it, find_automatic_composition):
125 * data.c (let_shadows_buffer_binding_p)
126 (let_shadows_global_binding_p, set_internal, make_blv)
127 (Fmake_variable_buffer_local, Fmake_local_variable)
128 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
129 (cons_to_signed, arith_driver):
130 * dbusbind.c (xd_in_read_queued_messages):
131 * dired.c (directory_files_internal, file_name_completion):
132 Use bool for booleans.
133 * dired.c (file_name_completion):
134 * process.h (fd_callback):
135 Omit int (actually boolean) argument. It wasn't being used.
136 All uses changed.
137 * composite.h, lisp.h: Reflect above API changes.
138
f10fe38f
PE
139 * cmds.c, coding.c: Use bool for booleans.
140 * cmds.c (move_point, Fself_insert_command):
141 * coding.h (struct composition status, struct coding_system):
142 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
143 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
144 (emacs_mule_char, decode_coding_emacs_mule)
145 (encode_coding_emacs_mule, detect_coding_iso_2022)
146 (decode_coding_iso_2022, encode_invocation_designation)
147 (encode_designation_at_bol, encode_coding_iso_2022)
148 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
149 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
150 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
151 (encode_coding_raw_text, detect_coding_charset)
152 (decode_coding_charset, encode_coding_charset, detect_eol)
153 (detect_coding, get_translation_table, produce_chars)
154 (consume_chars, reused_workbuf_in_use)
155 (make_conversion_work_buffer, code_conversion_save)
156 (decode_coding_object, encode_coding_object)
157 (detect_coding_system, char_encodable_p)
158 (Funencodable_char_position, code_convert_region)
159 (code_convert_string, code_convert_string_norecord)
160 (Fset_coding_system_priority):
161 * fileio.c (Finsert_file_contents):
162 Use bool for booleans.
163 * coding.h, lisp.h: Reflect above API changes.
164 * coding.c: Remove unnecessary static function decls.
165 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
166 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
167 not a boolean 'int', since callers never look at the return value.
168 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
169 * coding.h (decoding_buffer_size, encoding_buffer_size)
170 (emacs_mule_string_char): Remove unused extern decls.
171 (struct iso_2022_spec, struct coding_system):
172 Use 'unsigned int : 1' for boolean fields, since there's more than one.
173 (struct emacs_mule_spec): Remove unused field 'full_support'.
174 All initializations removed.
175 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
176
5474c384
DA
1772012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
178
f10fe38f 179 Fix spare memory change (Bug#12286).
5474c384
DA
180 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
181 (valid_lisp_object_p): Likewise.
182
c4b6914d
MR
1832012-08-27 Martin Rudalics <rudalics@gmx.at>
184
185 * window.c (Fset_window_configuration): Record any window's old
186 buffer if it's replaced (see Bug#8789). If the new current
187 buffer doesn't appear in the selected window, go to its old
188 point (Bug#12208).
189
35aaa1ea
DA
1902012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
191
192 Special MEM_TYPE_SPARE to denote reserved memory.
193 * alloc.c (enum mem_type): New memory type.
194 (refill_memory_reserve): Use new type for spare memory.
195 This prevents live_cons_p and live_string_p from incorrect
196 detection of uninitialized objects from spare memory as live.
197
6af64513
PE
1982012-08-26 Paul Eggert <eggert@cs.ucla.edu>
199
8b2e00a3
PE
200 Spelling fixes.
201 * Makefile.in (.PHONY): versioclean -> versionclean.
202
b52d6985
PE
203 Remove unused external symbols.
204 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
205 * window.c (Qwindow_valid_p, decode_valid_window):
206 Now static, not extern.
207 * data.c (Qinterval): Remove; unused.
208 (syms_of_data): Do not define 'interval'.
209 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
210 * window.h (decode_valid_window):
211 Remove decls.
212
d5172d4f
PE
213 * character.c, charset.c, chartab.c: Use bool for booleans.
214 * character.c (lisp_string_width, string_count_byte8)
215 (string_escape_byte8):
216 * charset.c (charset_map_loaded, load_charset_map, read_hex):
217 (load_charset_map_from_file, map_charset_chars)
218 (Fdefine_charset_internal, define_charset_internal)
219 (Fdeclare_equiv_charset, find_charsets_in_text)
220 (Ffind_charset_region, char_charset, Fiso_charset):
221 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
222 (sub_char_table_set, sub_char_table_set_range)
223 (char_table_set_range, optimize_sub_char_table)
224 (map_sub_char_table):
225 Use bool for boolean.
226 * character.c (str_to_unibyte): Omit last boolean argument; it was
227 always 0. All callers changed.
228 * character.h, charset.h: Adjust to match previous changes.
229 * character.h (char_printable_p): Remove decl of nonexistent function.
230 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
231 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
232 are all boolean, so make them single-bit bitfields.
233
6af64513
PE
234 * lisp.h (ASET): Remove attempt to detect side effects.
235 It was meant to be temporary and it often doesn't work,
236 because when IDX has side effects the behavior of IDX==IDX
237 is undefined. See Stefan Monnier in
238 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
239
e1f29348
BR
2402012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
241
242 * lisp.h (functionp): New function (extracted from Ffunctionp).
243 (FUNCTIONP): Use it.
244 * eval.c (Ffunctionp): Use it.
245
17c05d74
PE
2462012-08-25 Paul Eggert <eggert@cs.ucla.edu>
247
0f46bc75
PE
248 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
249 as that's faster and simpler than static storage. Don't bother
250 with the g_main_context_query overhead if g_main_context_pending
251 says no events are pending.
252 (gfds, gfds_size): Remove these static vars.
253 (xgselect_initialize): Remove; no longer needed.
254 All uses and decls removed.
255
ee4c0f69
PE
256 * emacs.c (fatal_error_signal_hook): Remove.
257 All uses removed. This leftover from old code was always 0.
258
17c05d74
PE
259 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
260 * casefiddle.c (casify_object, casify_region):
261 * casetab.c (set_case_table):
262 * category.c, category.h (word_boundary_p):
263 * category.h (CHAR_HAS_CATEGORY):
264 Use bool for booleans, instead of int.
265
391ceac5
EZ
2662012-08-25 Eli Zaretskii <eliz@gnu.org>
267
268 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
269
2f221583
PE
2702012-08-25 Paul Eggert <eggert@cs.ucla.edu>
271
f4a681b0
PE
272 On assertion failure, print backtrace if available.
273 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
274 (die) [ENABLE_CHECKING]: Print a backtrace if available.
275 * Makefile.in (LIB_EXECINFO): New macro.
276 (LIBES): Use it.
277
2f221583
PE
278 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
279 * bytecode.c (exec_byte_code):
280 * callint.c (check_mark, Fcall_interactively):
281 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
282 (getenv_internal, sync_process_alive, call_process_exited):
283 * lisp.h (USE_SAFE_ALLOCA):
284 Use bool for booleans, instead of int.
285 * lisp.h, process.h: Adjust prototypes to match above changes.
286 * callint.c (Fcall_interactively): Don't assume the mark's
287 offset fits in 'int'.
288
37ef52bb
PE
2892012-08-24 Paul Eggert <eggert@cs.ucla.edu>
290
291 * buffer.c, buffer.h: Use bool for boolean.
292 * buffer.c (reset_buffer_local_variables)
293 (buffer_lisp_local_variables, Fset_buffer_modified_p)
294 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
295 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
296 (overlay_touches_p, overlay_strings, Foverlay_put)
297 (report_overlay_modification, call_overlay_mod_hooks):
298 (mmap_enlarge, mmap_set_vars):
299 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
300 Use bool for booleans, instead of int.
301 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
302 since the 1-or-0 return value is always ignored anyway.
303 (mmap_initialized_p):
304 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
305 * buffer.h, lisp.h: Adjust prototypes to match above changes.
306
2cc21167
PE
3072012-08-23 Paul Eggert <eggert@cs.ucla.edu>
308
309 * bidi.c: Use bool for boolean.
310 This is a bit more readable, and makes the text segment of bidi.o
311 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
312 Presumably it's faster too.
313 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
314 Now bool.
315 (bidi_cache_find_level_change, bidi_cache_iterator_state)
316 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
317 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
318 (bidi_explicit_dir_char, bidi_level_of_next_char)
319 (bidi_find_other_level_edge, bidi_move_to_visually_next):
320 Use bool for booleans, instead of int.
321 * dispextern.h (bidi_init_it, bidi_paragraph_init)
322 (bidi_unshelve_cache): Adjust decls to match code.
323
7db4ddf4
MR
3242012-08-23 Martin Rudalics <rudalics@gmx.at>
325
326 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
327 argument.
328
b1bb8011
PE
3292012-08-23 Paul Eggert <eggert@cs.ucla.edu>
330
331 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
332 * atimer.h: Include <stdbool.h>.
333
ff687885
DN
3342012-08-22 Dan Nicolaescu <dann@gnu.org>
335
336 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
337 compile time tests instead of run time tests on systems that do
338 not use them.
339 (FRAME_MAC_P): Remove leftover from deleted code.
340 * frame.c (syms_of_frame): Remove leftover from deleted code.
341
4ce7a138
JD
3422012-08-22 Jan Djärv <jan.h.d@swipnet.se>
343
344 * nsterm.m (insertText:): Don't clear modifiers if code is space.
345
d733ec6d
PE
3462012-08-22 Paul Eggert <eggert@cs.ucla.edu>
347
348 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
349 Otherwise, the compiler complains about (A?B:C) where B is void
350 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
351 (fontset_add): Return void, for FONTSET_ADD.
352
d0d2d26f
PE
3532012-08-21 Paul Eggert <eggert@cs.ucla.edu>
354
fce31d69
PE
355 * alloc.c: Use bool for booleans.
356 (gc_in_progress, abort_on_gc)
357 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
358 (dont_register_blocks) [GC_MALLOC_CHECK]:
359 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
360 (check_string_bytes, make_specified_string, memory_full)
361 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
362 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
363 (mark_stack, valid_pointer_p, make_pure_string)
364 (Fgarbage_collect, survives_gc_p, gc_sweep):
365 Use bool for booleans, instead of int.
366 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
367 Remove unused local.
368 * alloc.c (PURE_POINTER_P):
369 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
370 * editfns.c (Fformat):
371 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
372 (Fdo_auto_save):
373 * fns.c (sweep_weak_table):
374 * lisp.h (suppress_checking, push_message, survives_gc_p)
375 (make_pure_string, gc_in_progress, abort_on_gc):
376 * lread.c (readchar, read1):
377 * print.c (Fprin1_to_string):
378 * xdisp.c (push_message):
379 Use bool for booleans affected directly or indirectly by
380 alloc.c's changes.
381
d0d2d26f
PE
382 Make recently-introduced setters macros.
383 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
384 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
385 (set_fontset_default, set_fontset_fallback): Rename from their
386 upper-case counterparts, and make them functions rather than macros.
387 This is more consistent with the other recently-introduced setters.
388 These don't need to be inline, since they're local.
389
d18e2bb6
JD
3902012-08-21 Jan Djärv <jan.h.d@swipnet.se>
391
392 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
393 the loop (Bug#12247).
394
1b9d9d16
PE
3952012-08-21 Paul Eggert <eggert@cs.ucla.edu>
396
397 * lisp.h (vcopy): Use memcpy rather than our own loop.
398 This fixes a performance regression introduced by the recent
399 addition of vcopy. This means 'vcopy' will need to be modified
400 for a copying collector, but that's OK. Also, tighten the
401 checking in the assertion.
402
b2f09701
EZ
4032012-08-21 Eli Zaretskii <eliz@gnu.org>
404
405 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
406 components for RTL text (Bug#11860). Adjust X-OFFSET of each
407 non-base glyph for the width of the base character, according to
e1f29348
BR
408 what x_draw_composite_glyph_string_foreground expects.
409 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
410 expectations, to produce correct width of the composed character.
411 Reverse the sign of the DU offset produced by ScriptPlace.
412
9b994fed
PE
4132012-08-21 Paul Eggert <eggert@cs.ucla.edu>
414
415 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
416
086ca913
DA
4172012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
418
419 Avoid direct writes to contents member of struct Lisp_Vector.
420 * lisp.h (vcopy): New function to copy data into vector.
421 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
422 * fns.c (Ffillarray): Use ASET.
423 * keyboard.c (timer_check_2): Use AREF and ASET.
424 (append_tool_bar_item, Frecent_keys): Use vcopy.
425 * lread.c (read_vector): Use ASET.
426 * msdos.c (Frecent_doskeys): Use vcopy.
427 * xface.c (Finternal_copy_lisp_face): Use vcopy.
428 (Finternal_merge_in_global_face): Use ASET and vcopy.
429 * xfont.c (xfont_list_pattern): Likewise.
430
5481664a
MR
4312012-08-21 Martin Rudalics <rudalics@gmx.at>
432
433 * window.c (Fwindow_point): For the selected window always return
434 the position of its buffer's point.
435 (Fset_window_point): For the selected window always go in its
436 buffer to the specified position.
437
6d470bdd
DA
4382012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
439
440 Setter macros for fontsets.
441 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
442 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
443 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
444 Adjust users.
445
24564fe1
GM
4462012-08-20 Glenn Morris <rgm@gnu.org>
447
448 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
449 Don't assume that `ln -f' works.
450
0a05a035
EZ
4512012-08-20 Eli Zaretskii <eliz@gnu.org>
452
453 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
454 and later about non-assignments with no effect. See discussion at
455 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
456 details.
457
e46f2325
DA
4582012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
459
460 Inline setter functions for Lisp_Objects slots of struct specbinding.
461 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
462 Adjust users.
463
734fbd86
MR
4642012-08-20 Martin Rudalics <rudalics@gmx.at>
465
466 * window.c (select_window): Always make selected window's buffer
467 current.
468
f1a95992
DA
4692012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
470
471 Use AREF and ASET for docstrings of category tables.
472 * category.h (CATEGORY_DOCSTRING): Use AREF.
473 (SET_CATEGORY_DOCSTRING): Use ASET.
474 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
475
e83064be
DA
4762012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
477
478 Inline setter functions for hash table members.
479 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
480 (set_hash_hash, set_hash_index): Rename with _slot suffix.
481 (set_hash_key_and_value, set_hash_index, set_hash_next)
482 (set_hash_hash): New functions.
483 * charset.c, fns.c: Adjust users.
484
4ce60d2e
DA
4852012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
486
487 Inline getter and setter functions for per-buffer values.
488 * buffer.h (per_buffer_default, set_per_buffer_default)
489 (per_buffer_value, set_per_buffer_value): New functions.
490 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
491 * buffer.c, data.c: Adjust users.
492
c06c9690
JB
4932012-08-20 Juanma Barranquero <lekktu@gmail.com>
494
495 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
496
32bd4250
PE
4972012-08-19 Paul Eggert <eggert@cs.ucla.edu>
498
bad03192 499 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
500 as gnulib does this if the system doesn't.
501 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
502 Remove declaration. MS-Windows declares it on stdlib.h which is
503 included by conf_post.h.
b69a6d22
PE
504 * emacs.c (environ) [DOUG_LEA_MALLOC]:
505 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
506 * vm-limit.c: Include <unistd.h>, for 'environ'.
507
22d7feb2
PE
508 * unexaix.c, unexcoff.c: Include "mem-limits.h".
509 (start_of_data): Remove decl; mem-limits.h provides it.
510
32bd4250
PE
511 * xdisp.c (handle_invisible_prop): Make it a bit faster
512 and avoid a gcc -Wmaybe-uninitialized diagnostic.
513
450809af
CY
5142012-08-19 Chong Yidong <cyd@gnu.org>
515
516 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
517 ends (Bug#3874).
518
9e677988
AS
5192012-08-19 Andreas Schwab <schwab@linux-m68k.org>
520
6b1319ce
AS
521 * .gdbinit: Use call instead of set when calling a function in the
522 inferior.
523
9e677988
AS
524 * data.c (set_internal): Don't use set_blv_found.
525 (Fkill_local_variable): Likewise.
526
d7191076
AA
5272012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
528
529 * nsfont.m (ns_ascii_average_width): Ensure the string
530 ascii_printable is initialized with a null-terminated character
531 array. Otherwise, it can contain undesired extra characters.
532
e757f1c6
PE
5332012-08-18 Paul Eggert <eggert@cs.ucla.edu>
534
535 port new setting code to Sun C 5.8 2005/10/13
536 * chartab.c, lisp.h (char_table_set, char_table_set_range):
537 Return void, not Lisp_Object. Otherwise, the compiler
538 complains about (A?B:C) where B is void and C is Lisp_Object
539 when compiling CHAR_TABLE_SET, due to the recent change to
540 the API of sub_char_table_set_contents.
541
a999ce26
CY
5422012-08-18 Chong Yidong <cyd@gnu.org>
543
544 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
545 for the string case (Bug#3874).
546
3f22b86f
PE
5472012-08-18 Paul Eggert <eggert@cs.ucla.edu>
548
39eb03f1
PE
549 * buffer.h (BSET): Remove (Bug#12215).
550 Replace all uses with calls to new setter functions.
551 (bset_bidi_paragraph_direction, bset_case_canon_table)
552 (bset_case_eqv_table, bset_directory, bset_display_count)
553 (bset_display_time, bset_downcase_table)
554 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
555 (bset_last_selected_window, bset_local_var_alist)
556 (bset_mark_active, bset_point_before_scroll, bset_read_only)
557 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
558 (bset_width_table):
559 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
560 (bset_auto_fill_function, bset_auto_save_file_format)
561 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
562 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
563 (bset_cache_long_line_scans, bset_case_fold_search)
564 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
565 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
566 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
567 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
568 (bset_header_line_format, bset_indicate_buffer_boundaries)
569 (bset_indicate_empty_lines, bset_invisibility_spec)
570 (bset_left_fringe_width, bset_major_mode, bset_mark)
571 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
572 (bset_name, bset_overwrite_mode, bset_pt_marker)
573 (bset_right_fringe_width, bset_save_length)
574 (bset_scroll_bar_width, bset_scroll_down_aggressively)
575 (bset_scroll_up_aggressively, bset_selective_display)
576 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
577 (bset_word_wrap, bset_zv_marker):
578 * category.c (bset_category_table):
579 * syntax.c (bset_syntax_table):
580 New setter functions.
581
6a09a33b
PE
582 * process.h (PSET): Remove (Bug#12215).
583 Replace all uses with calls to new setter functions.
584 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
585 (PROCESS_INLINE): New macro.
586 (pset_childp): New setter function.
587 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
588 * process.c (PROCESS_INLINE):
589 Define to EXTERN_INLINE, so that the corresponding functions
590 are compiled into code.
591 (pset_buffer, pset_command, pset_decode_coding_system)
592 (pset_decoding_buf, pset_encode_coding_system)
593 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
594 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
595 (pset_type, pset_write_queue): New setter functions.
596
e8c17b81
PE
597 * window.h (WSET): Remove (Bug#12215).
598 Replace all uses with calls to new setter functions.
599 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
600 (WINDOW_INLINE): New macro.
601 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
602 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
603 (wset_total_lines, wset_vertical_scroll_bar)
604 (wset_window_end_pos, wset_window_end_valid)
605 (wset_window_end_vpos): New setter functions.
606 * window.c (WINDOW_INLINE):
607 Define to EXTERN_INLINE, so that the corresponding functions
608 are compiled into code.
609 (wset_combination_limit, wset_dedicated, wset_display_table)
610 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
611 (wset_new_normal, wset_new_total, wset_next_buffers)
612 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
613 (wset_prev_buffers, wset_right_fringe_width)
614 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
615 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
616 (wset_window_parameters):
617 * xdisp.c (wset_base_line_number, wset_base_line_pos)
618 (wset_column_number_displayed, wset_region_showing):
619 New setter functions.
620
3f22b86f
PE
621 * termhooks.h (TSET): Remove (Bug#12215).
622 Replace all uses with calls to new setter functions.
623 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
624 (TERMHOOKS_INLINE): New macro.
625 (tset_charset_list, tset_selection_alist): New setter functions.
626 * terminal.c (TERMHOOKS_INLINE):
627 Define to EXTERN_INLINE, so that the corresponding functions
628 are compiled into code.
629 (tset_param_alist): New setter function.
630
742af32f
PE
6312012-08-17 Paul Eggert <eggert@cs.ucla.edu>
632
15dbb4d6
PE
633 * keyboard.h (KSET): Remove (Bug#12215).
634 Replace all uses with calls to new setter functions.
635 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
636 (KEYBOARD_INLINE): New macro.
637 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
638 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
639 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
640 New setter functions.
641 * keyboard.c (KEYBOARD_INLINE):
642 Define to EXTERN_INLINE, so that the corresponding functions
643 are compiled into code.
644 (kset_echo_string, kset_kbd_queue)
645 (kset_keyboard_translate_table, kset_last_prefix_arg)
646 (kset_last_repeatable_command, kset_local_function_key_map)
647 (kset_overriding_terminal_local_map, kset_real_last_command)
648 (kset_system_key_syms): New setter functions.
649
f00af5b1
PE
650 * frame.h (FSET): Remove (Bug#12215).
651 Replace all uses with calls to new setter functions.
652 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
653 (FRAME_INLINE): New macro.
654 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
655 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
656 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
657 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
658 (fset_param_alist, fset_root_window, fset_scroll_bars)
659 (fset_selected_window, fset_title, fset_tool_bar_items)
660 (fset_tool_bar_position, fset_tool_bar_window): New functions.
661 * frame.c (FRAME_INLINE):
662 Define to EXTERN_INLINE, so that the corresponding functions
663 are compiled into code.
664 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
665
0c94c8d6
PE
666 A few more naming-convention fixes for getters and setters.
667 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
668 and rename from buffer_overlays_set_before.
669 (set_buffer_overlays_after): Move here from buffer.h, and rename
670 from buffer_overlays_set_after.
671 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
672 All uses changed.
673 (set_buffer_intervals): Rename from buffer_set_intervals.
674 * intervals.c (set_interval_object): Move here from intervals.h,
675 and rename from interval_set_object.
676 (set_interval_left): Move here from intervals.h, and rename from
677 interval_set_left.
678 (set_interval_right): Move here from intervals.h, and rename from
679 interval_set_right.
680 (copy_interval_parent): Move here from intervals.h, and rename from
681 interval_copy_parent.
682 * intervals.h (set_interval_parent): Rename from interval_set_parent.
683 (set_interval_plist): Rename from interval_set_plist.
684 Return void, not Lisp_Object, since no caller uses the result.
685 * lisp.h (string_intervals): Rename from string_get_intervals.
686 (set_string_intervals): Rename from string_set_intervals.
687
34dabdb7
PE
688 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
689 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 690 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
691 All uses changed. See the end of
692 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
693
742af32f
PE
694 * lisp.h (CSET): Remove (Bug#12215).
695 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
696 (set_char_table_purpose): New functions,
697 replacing CSET. All uses changed. For example, replace
698 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 699 "set_char_table_parent (char_table, parent);".
742af32f
PE
700 The old version was confusing because it used the same name
701 'parent' for two different things.
702
a04e2c62
DA
7032012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
704
705 Functions to get and set Lisp_Object fields of buffer-local variables.
706 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
707 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
708 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
709 * data.c, eval.c, frame.c: Adjust users.
710
383dcbf9
CY
7112012-08-17 Chong Yidong <cyd@gnu.org>
712
713 * xfaces.c (merge_face_vectors): If the target font specfies a
714 font spec, make the font's attributes take precedence over
715 directly-specified attributes.
716 (merge_face_ref): Recognize :font.
717
44386687
DA
7182012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
719
720 Do not use memcpy for copying intervals.
721 * intervals.c (reproduce_interval): New function.
722 (reproduce_tree, reproduce_tree_obj): Use it.
723 (reproduce_tree_obj): Remove prototype.
724
927c7216
PE
7252012-08-17 Paul Eggert <eggert@cs.ucla.edu>
726
727 * lisp.h (duration_to_sec_usec): Remove unused decl.
728
93044f7b
AA
7292012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
730
731 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
732 to an allocated instance of NSString, not to the class itself.
733
9851e4a5
JB
7342012-08-17 Juanma Barranquero <lekktu@gmail.com>
735
736 * makefile.w32-in (C_CTYPE_H): New macro.
737 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
738 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
739 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
740
620f13b0
PE
7412012-08-16 Paul Eggert <eggert@cs.ucla.edu>
742
743 Use ASCII tests for character types.
744 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
745 * xfns.c, xterm.c:
746 Don't include <ctype.h>; was not needed.
747 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
748 * sysdep.c, xfaces.c:
749 Include <c-ctype.h> instead of <ctype.h>.
750 * nsterm.m: Include <c-ctype.h>.
751 * charset.c (read_hex):
752 * doc.c (Fsnarf_documentation):
753 * fileio.c (IS_DRIVE) [WINDOWSNT]:
754 (DRIVE_LETTER) [DOS_NT]:
755 (Ffile_name_directory, Fexpand_file_name)
756 (Fsubstitute_in_file_name):
757 * font.c (font_parse_xlfd, font_parse_fcname):
758 * frame.c (x_set_font_backend):
759 * gtkutil.c (xg_get_font):
760 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
761 * nsimage.m (hexchar):
762 * nsterm.m (ns_xlfd_to_fontname):
763 * sysdep.c (system_process_attributes):
764 * xfaces.c (hash_string_case_insensitive):
765 Use C-locale tests instead of locale-specific tests for character
766 types, since we want the ASCII interpretation here, not the
767 interpretation suitable for whatever happens to be the current locale.
768
52162052
MR
7692012-08-16 Martin Rudalics <rudalics@gmx.at>
770
771 Consistently check windows for validity/liveness
772 (Bug#11984, Bug#12025, Bug#12026).
773 * lisp.h (CHECK_VALID_WINDOW): New macro.
774 * window.c (decode_window): Rename to decode_live_window.
775 (decode_valid_window, Fwindow_valid_p): New functions.
776 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
777 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
778 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
779 (Fwindow_prev_sibling, Fwindow_combination_limit)
780 (Fset_window_combination_limit, Fwindow_use_time)
781 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
782 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
783 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
784 (Fwindow_hscroll, Fset_window_hscroll)
785 (Fwindow_redisplay_end_trigger)
786 (Fset_window_redisplay_end_trigger, Fwindow_edges)
787 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
788 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
789 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
790 (Fwindow_end, Fset_window_point, Fset_window_start)
791 (Fpos_visible_in_window_p, Fwindow_line_height)
792 (Fwindow_dedicated_p, Fset_window_dedicated_p)
793 (Fwindow_prev_buffers, Fset_window_prev_buffers)
794 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
795 (Fset_window_parameter, Fwindow_display_table)
796 (Fset_window_display_table, Fdelete_other_windows_internal)
797 (Fset_window_buffer, Fset_window_new_total)
798 (Fset_window_new_normal, Fdelete_window_internal)
799 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
800 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
801 (Fwindow_scroll_bars): Check whether argument window is a valid or
802 live window. Update doc-strings.
803 (syms_of_window): New symbol Qwindow_valid_p.
804 * keyboard.c (Fposn_at_x_y): Check whether argument
805 frame_or_window denotes a valid window.
806
2751c80f
DA
8072012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
808
809 Fix previous char table change.
810 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
811 * chartab.c (optimize_sub_char_table): Likewise.
812
032a42c8
CY
8132012-08-16 Chong Yidong <cyd@gnu.org>
814
a2d19368
CY
815 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
816
032a42c8
CY
817 * xfont.c (xfont_open):
818 * xftfont.c (xftfont_open): Set the font's max_width field.
819
820 * nsfont.m (nsfont_open): Similar to the Xft backend, set
821 min_width to space_width and average_width to the average over
822 printable ASCII characters.
823 (ns_char_width): Code cleanup.
824 (ns_ascii_average_width): New utility function.
825
826 * font.h (struct font): Update comments.
827
a098c930
DA
8282012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
829
032a42c8 830 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
831 * lisp.h (CSET): New macro.
832 (char_table_set_extras, char_table_set_contents)
833 (sub_char_table_set_contents): New function.
834 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
835 * syntax.c: Adjust users.
836
8be3a09c
SM
8372012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
838
839 * eval.c (eval_sub): Bind lexical-binding.
840 * lread.c (Qlexical_binding): Make non-static.
841
ac4845a6
JD
8422012-08-15 Jan Djärv <jan.h.d@swipnet.se>
843
ddee6515
JD
844 * nsmenu.m (popupSession): Remove.
845 (pop_down_menu): Remove endModalSession.
846 (timeout_handler:): New method.
847 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
848 Call runModalForWindow. Check timer_fired when it returns.
849 If not set, cancel timer and break out of loop.
850 Otherwise loop again, with a new timeout.
851
852 * nsterm.m: Include fcntl.h if present.
853 (fd_entry, t_readfds, inNsSelect): Remove.
854 (select_writefds, select_valid, select_timeout, selfds)
855 (select_mutex, apploopnr): Add.
856 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
857 Otherwise call kbd_buffer_store_event.
858 (ns_send_appdefined): Remove release of fd_entry.
859 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
860 Increment and decrement apploopnr.
861 (ns_select): If no file descriptors, just do a NSTimer.
862 Otherwise copy read/write masks and start select thread (fd_handler).
863 Start main loop and wait for application defined event.
864 Inform select thread to stop selecting after main loop is exited.
865 (ns_term_init): Create selfds pipe and set non-blocking.
866 Initialize select_mutex. Start the select thread (fd_handler).
867 (fd_handler:): Loop forever, wait for info from the main thread
868 to either start or stop selecting. When select returns, send
869 and appdefined event.
870 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
871 If not call kbd_buffer_store_event.
872
873 * nsterm.h (EmacsApp): fd_handler takes id argument.
874 (EmacsDialogPanel): Add timer_fired and timeout_handler.
875
ac4845a6
JD
876 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
877
eb424fe3
EZ
8782012-08-15 Eli Zaretskii <eliz@gnu.org>
879
880 * region-cache.c (move_cache_gap): Update gap_len using the actual
881 growth of the boundaries array. Do not change cache_len.
882 (Bug#12196)
883
4e6a86c6
DA
8842012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
885
886 Generalize and cleanup font subsystem checks.
887 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
888 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
889 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 890
5bf192ca
DA
8912012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
892
893 * gtkutil.c (xg_get_font): Use pango_units_to_double.
894
f2045622
CY
8952012-08-15 Chong Yidong <cyd@gnu.org>
896
8be3a09c
SM
897 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
898 When using the new font chooser, use gtk_font_chooser_get_font_desc to
899 extract the font descriptor instead of just the font name.
900 In that case, return a font spec instead of a string.
f2045622
CY
901 (x_last_font_name): Move to this file from xfns.c.
902
903 * xfns.c (Fx_select_font): The return value can also be a font
904 spec. Move x_last_font_name management to gtkutil.c.
905
906 * xfaces.c: Make font weight and style symbols non-static.
907
7f6feb56
SM
9082012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
909
910 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
911 (bug#12117).
912
fecbd8ff
SM
9132012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
914
915 * alloc.c (Fgarbage_collect): Use plural form consistently.
916
9b8d5165
EZ
9172012-08-14 Eli Zaretskii <eliz@gnu.org>
918
919 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
920 iteration through the command loop. Fixes a problem whereby mouse
921 movements are ignored until the first mouse click.
922
f5d9e83a
PE
9232012-08-14 Paul Eggert <eggert@cs.ucla.edu>
924
925 Use bool, not int, for Lisp booleans.
926 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
927 makes Emacs a bit smaller and presumably a bit faster.
928 * lisp.h: Include <stdbool.h>.
929 (struct Lisp_Boolfwd, defvar_bool):
930 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
931 * regex.c [!emacs]: Include <stdbool.h>.
932 (false, true): Remove; <stdbool.h> does this for us now.
933
55802e4a
CY
9342012-08-14 Chong Yidong <cyd@gnu.org>
935
4abcdac8
CY
936 * character.c (Fcharacterp): Doc fix (Bug#12076).
937
938 * data.c (Findirect_variable): Doc fix (Bug#11040).
939
55802e4a
CY
940 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
941
942 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 943 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 944
8e99d072
BR
9452012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
946
947 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
948 (bug#12022).
949
08908aca
MR
9502012-08-14 Martin Rudalics <rudalics@gmx.at>
951
952 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
953 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
954 * minibuf.c (choose_minibuf_frame, read_minibuf):
955 * w32fns.c (x_create_tip_frame):
956 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
957 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
958
56120d6f
PE
9592012-08-14 Paul Eggert <eggert@cs.ucla.edu>
960
961 * intervals.c (offset_intervals): Remove obsolete comment.
962
67b77c0b
AS
9632012-08-14 Andreas Schwab <schwab@linux-m68k.org>
964
965 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
966
f48b82fd
GR
9672012-08-14 Gergely Risko <gergely@risko.hu>
968
969 * coding.c (decode_coding): Record buffer modification before
970 disabling undo_list (Bug#11773).
971
fd318b54
DA
9722012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
973
974 Revert and cleanup some recent overlay changes.
975 * buffer.h (enum overlay_type): Remove.
976 (buffer_get_overlays, buffer_set_overlays): Likewise.
977 (buffer_set_overlays_before, buffer_set_overlays_after):
978 New function. Adjust users.
979 (unchain_both): Add eassert.
980
41a62dd9
DA
9812012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
982
983 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
984
5884c324
PE
9852012-08-14 Paul Eggert <eggert@cs.ucla.edu>
986
987 * gtkutil.c (xg_mark_data): Don't assume C99.
988
ca06f160
JD
9892012-08-13 Jan Djärv <jan.h.d@swipnet.se>
990
991 * gtkutil.c (xg_frame_tb_info): New struct.
992 (TB_INFO_KEY): New define.
993 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
994 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
995 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
996 if not present.
997 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
998 is up to date. Otherwise store new data.
999 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1000
7864a3f7
DA
10012012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1002
1003 Use KSET for write access to Lisp_Object members of struct kboard.
1004 * keyboard.h (KSET): New macro.
1005 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1006 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1007 * xterm.c: Adjust users.
1008
4c31be61
DA
10092012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1010
1011 Use BSET for write access to Lisp_Object members of struct buffer.
1012 * buffer.h (BSET): New macro.
1013 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1014 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1015 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1016 * window.c, xdisp.c, xfns.c: Adjust users.
1017
14ae4239
BT
10182012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1019
1020 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1021
32bcadb4
JD
10222012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1023
3d29b2ce
JD
1024 * nsterm.m (not_in_argv): New function.
1025 (application:openFile, application:openTempFile:):
1026 (application:openFileWithoutUI:, application:openFiles:): Open file
1027 if not_in_argv returns non-zero (bug#12171).
1028
32bcadb4 1029 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1030 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1031 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1032 (xg_get_font_name): Use those functions/macros here.
1033 Reported by Frans Oilinki <moilinki@gmail.com>.
1034
9ff9402d 10352012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1036
1037 * unexmacosx.c (copy_data_segment): Copy initialized data in
1038 statically linked libraries from input file rather than memory.
1039
db74a5fc
YM
1040 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1041 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1042 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1043
25e65510
GM
10442012-08-10 Glenn Morris <rgm@gnu.org>
1045
1046 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1047 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1048
7961135c
DA
10492012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1050
1051 Fix last change to allow compilation with low optimization levels.
1052 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1053 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1054
42b3a444
DA
10552012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1056
1057 Use common inline syntax in intervals.h.
1058 * intervals.h (INTERVALS_INLINE): New macro.
1059 Change all users from LISP_INLINE.
1060
9fb0c957
DA
10612012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 Define Qnone once for all platforms.
1064 * frame.c (Qnone): Define here.
1065 (syms_of_frame): DEFSYM it.
1066 * lisp.h (Qnone): New declaration.
1067 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1068 * xfns.c: Remove duplication. Adjust users.
1069
65e8ee52
DA
10702012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1071
1072 Remove unused macros from intervals.h.
1073 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1074 * intervals.c: Adjust comment.
1075
9b855fd6
EZ
10762012-08-10 Eli Zaretskii <eliz@gnu.org>
1077
1078 * w32fns.c <w32_unicode_gui>: New static variable.
1079 (globals_of_w32fns): Initialize it according to os_subtype.
1080 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1081 testing os_subtype.
1082
39cb9e56 10832012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1084 Eli Zaretskii <eliz@gnu.org>
1085
1086 Fix bug #10299 with Unicode characters sent by customized
1087 keyboards created by MSKLC.
1088 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1089 (w32_init_class): Use it to initialize the Emacs class with either
1090 ANSI or Unicode API calls.
1091 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1092 later.
1093 (w32_wnd_proc): If the character code sent by WM_CHAR or
1094 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1095 original message. Call DefWindowProcW on NT and later.
1096
9374581a
GM
10972012-08-10 Glenn Morris <rgm@gnu.org>
1098
4b94e8cf
GM
1099 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1100
9374581a
GM
1101 * lisp.h (DIRECTORY_SEP): Let configure set it.
1102
a2752828
DA
11032012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1104
1105 Use TSET for write access to Lisp_Object slots of struct terminal.
1106 * termhooks.h (TSET): New macro.
1107 * coding.c, terminal.c, xselect.c: Adjust users.
1108
cc92c454
SM
11092012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1110
1111 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1112 the failing expression, include them in the error message.
1113 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1114 * lisp.h (internal_condition_case_n): Update declaration.
1115
4cb3e6b3
DA
11162012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1117
1118 Inline functions to examine and change buffer overlays.
1119 * buffer.c (unchain_both): New function.
1120 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1121 (buffer_has_overlays): New function.
1122 (enum overlay_type): New enum.
1123 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1124 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1125
8707c1e5
DA
11262012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1127
1128 Inline functions to examine and change buffer intervals.
1129 * alloc.c (mark_interval_tree): Remove.
1130 (MARK_INTERVAL_TREE): Simplify.
1131 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1132 * intervals.c (buffer_balance_intervals): New function.
1133 (graft_intervals_into_buffer): Adjust indentation.
1134 (set_intervals_multibyte): Simplify.
1135 * buffer.h (BUF_INTERVALS): Remove.
1136 (buffer_get_intervals, buffer_set_intervals): New function.
1137 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1138 * intervals.c, textprop.c: Adjust users.
1139
ad8c997f
DA
11402012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1141
1142 Inline functions to examine and change string intervals.
1143 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1144 (string_get_intervals, string_set_intervals): New function.
1145 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1146 * lread.c, print.c, textprop.c: Adjust users.
1147
32ac3a6b
GM
11482012-08-08 Glenn Morris <rgm@gnu.org>
1149
1150 * lisp.mk (lisp): Remove language/persian.elc.
1151
77c7bcb1
DA
11522012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1153
1154 Cleanup intervals.
1155 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1156 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1157 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1158 Adjust comment. Move under #if 0.
77c7bcb1
DA
1159 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1160 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1161
9c08a8d4
DA
11622012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1163
1164 Check total length of intervals with eassert.
1165 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1166 * intervals.c: Change all users to eassert.
1167
26d16b35
EZ
11682012-08-07 Eli Zaretskii <eliz@gnu.org>
1169
14ae4239
BT
1170 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1171 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1172 INTERNAL_FIELD in Lisp_Cons.
1173
c644523b
DA
11742012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1175
1176 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1177 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1178 name since all xname users are fixed long time ago. Do not
1179 use INTERNAL_FIELD.
1180 (set_symbol_name, set_symbol_function, set_symbol_plist):
1181 (set_symbol_next, set_overlay_plist): New function.
1182 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1183 (struct Lisp_Overlay): Likewise.
1184 (CVAR, MVAR, SVAR): Remove.
1185 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1186 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1187 * xterm.c: Adjust users.
1188 * .gdbinit: Change to use name field of struct Lisp_Symbol
1189 where appropriate.
1190
6a3d20cc
DA
11912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1192
1193 Basic functions to set Lisp_Object and pointer slots of intervals.
1194 * intervals.h (interval_set_parent, interval_set_object):
1195 (interval_set_left, interval_set_right, interval_set_plist):
1196 (interval_copy_parent): New function.
1197 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1198 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1199 Adjust indentation.
6a3d20cc
DA
1200 (INTERVAL_SIZE): Remove. Adjust users.
1201 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1202
4d2b044c
DA
12032012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1204
1205 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1206 * process.h (PGET): Remove.
1207 (struct Lisp_Process): Do not use INTERNAL_FIELD.
1208 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1209
d3d50620
DA
12102012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 Drop WGET and revert read access to Lisp_Objects slots of struct window.
1213 * window.h (WGET): Remove.
1214 (struct window): Do not use INTERNAL_FIELD.
1215 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1216 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1217 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1218 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1219 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1220 Adjust users.
1221
d10a51dc
CY
12222012-08-07 Chong Yidong <cyd@gnu.org>
1223
1224 * window.c (Fwindow_edges, Fwindow_pixel_edges)
1225 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
1226 (Fdelete_window_internal): Signal an error if the window is not on
1227 a live frame (Bug#12025).
1228
e69b0960
DA
12292012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1230
1231 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
1232 * frame.h (FGET): Remove.
1233 (struct frame): Do not use INTERNAL_FIELD.
1234 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1235 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1236 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1237 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1238
25a20a3a
JB
12392012-08-06 Juanma Barranquero <lekktu@gmail.com>
1240
1241 * w32.c: Silence compiler warnings.
1242 (map_w32_filename): Remove unused variable `is_fat'.
1243 (chase_symlinks): Add parentheses around expression.
1244
1c6f11f4
GM
12452012-08-06 Glenn Morris <rgm@gnu.org>
1246
1db4583a
GM
1247 * sysdep.c: Respect BROKEN_GETWD.
1248
1c6f11f4
GM
1249 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
1250 Let configure handle it.
1251 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
1252
2b90362b
DA
12532012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1254
1255 Use GCALIGNMENT where appropriate.
1256 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
1257 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
1258 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
1259
5f50daf2
EZ
12602012-08-06 Eli Zaretskii <eliz@gnu.org>
1261
14ae4239
BT
1262 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
1263 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 1264
cbcc7007
SM
12652012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
1266
1267 * buffer.h (struct buffer): Revert `indirections' to a simple int;
1268 that should be sufficient for everyone.
1269
4d365fa4
JD
12702012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1271
1272 * keyboard.c (timer_check_2): Add break so timer_check returns next
1273 timeout.
1274
dd86bd82
DA
12752012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1276
1277 Fix Windows build errors introduced after converting to WGET and WSET.
1278 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
1279 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1280
054e1668
JD
12812012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1282
1283 * nsterm.m (ns_frame_rehighlight): Use FSET.
1284
1285 * nsmenu.m (ns_update_menubar): Use FSET.
1286
21238f11
DA
12872012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1288
1289 Separate read and write access to Lisp_Object slots of Lisp_Process.
1290 * process.h (PGET, PSET): New macros similar to AREF and ASET.
1291 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1292
077288cf
DA
12932012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1294
1295 Separate read and write access to Lisp_Object slots of struct window.
1296 * window.h (WGET, WSET): New macros similar to AREF and ASET.
1297 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1298 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1299 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1300 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1301 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1302 Adjust users.
1303
71688bd7
DA
13042012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1305
1306 Fix Windows build errors introduced after converting to FGET and FSET.
1307 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
1308 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
1309 (w32_judge_scroll_bars): Change to use FSET.
1310 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1311
f99bac93
DA
13122012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1313
1314 Fix replacement typo.
1315 * window.c (replace_window): Set root_window instead of
1316 selected_window. This fixes a total window subsystem
1317 malfunction reported by Bastien Guerry <bzg@gnu.org>.
1318
8c2a0f2d
GM
13192012-08-06 Glenn Morris <rgm@gnu.org>
1320
1321 * lisp.mk (lisp): Add language/persian.elc.
1322
edd74c35
DA
13232012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1324
1325 Separate read and write access to Lisp_Object slots of struct frame.
1326 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
1327 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1328 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1329 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1330 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1331
8671676c
AS
13322012-08-05 Andreas Schwab <schwab@linux-m68k.org>
1333
1334 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
1335
663e2b3f
DA
13362012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1337
1338 Generalize common compile-time constants.
1339 * lisp.h (header_size, bool_header_size, word_size): Now here.
1340 (struct Lisp_Vector): Add comment.
1341 (struct Lisp_Bool_Vector): Move up to define handy constants.
1342 (VECSIZE, PSEUDOVECSIZE): Simplify.
1343 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
1344 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
1345 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
1346 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
1347 * xfont.c, xmenu.c: Use word_size where appropriate.
1348
d32e47af
LM
13492012-08-05 Lawrence Mitchell <wence@gmx.li>
1350
1351 * search.c (Freplace_match): Treat \? in the replacement text
1352 literally (Bug#8161).
1353
e5d9c0d1
CY
13542012-08-05 Chong Yidong <cyd@gnu.org>
1355
1356 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
1357 * frame.c (Vdelete_frame_functions):
1358 * emacs.c (Vkill_emacs_hook): Doc fix.
1359
8da0576b
EZ
13602012-08-04 Eli Zaretskii <eliz@gnu.org>
1361
1362 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
1363 --with-x-toolkit=no builds.
1364 Reported by Carsten Mattner <carstenmattner@gmail.com>.
1365
02676e5d
CY
13662012-08-04 Chong Yidong <cyd@gnu.org>
1367
1368 * syntax.c (Fmodify_syntax_entry): Doc fix.
1369
97147da9
EZ
13702012-08-04 Eli Zaretskii <eliz@gnu.org>
1371
76151e2c
EZ
1372 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
1373 * w32.c (init_environment): Change the default values of many
1374 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
1375 them into environment when they were not already defined.
1376 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 1377 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
1378 (check_windows_init_file): Now external, not static.
1379 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
1380 called when Vload_path is already set up.
1381
1382 * w32.h (check_windows_init_file): Add prototype.
1383
1384 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
1385 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
1386 compatibility with Posix platforms.
1387 (main): Move the call to check_windows_init_file to here from
1388 w32.c.
1389 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
1390 any, in the DEFALT argument into the root of the Emacs build or
1391 installation tree, as appropriate.
1392
1393 * callproc.c (init_callproc_1): Call decode_env_path instead of
1394 doing its equivalent by hand.
1395 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
1396 the code that sets Vexec_path run on MS-Windows.
1397
1398 * lread.c (init_lread): Add comments to #ifdef's.
1399
97147da9
EZ
1400 * msdos.c (dos_set_window_size, IT_update_begin)
1401 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
1402 instead of direct references.
1403
185ee146
PE
14042012-08-04 Paul Eggert <eggert@cs.ucla.edu>
1405
1406 Export DEFAULT_REHASH_* to GDB.
1407 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
1408 Now constants, not macros.
1409
8834c57a
PE
14102012-08-03 Paul Eggert <eggert@cs.ucla.edu>
1411
98c6f1e3
PE
1412 Remove unnecessary casts involving pointers.
1413 These casts are no longer needed now that we assume C89 or later,
1414 since they involve casting to or from void *.
1415 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
1416 (make_pure_float, make_pure_vector):
1417 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
1418 * macros.c (Fstart_kbd_macro):
1419 * menu.c (find_and_return_menu_selection):
1420 * minibuf.c (read_minibuf_noninteractive):
1421 * sysdep.c (closedir):
1422 * xdisp.c (x_produce_glyphs):
1423 * xfaces.c (compare_fonts_by_sort_order):
1424 * xfns.c (x_real_positions, select_visual):
1425 * xselect.c (x_stop_queuing_selection_requests)
1426 (x_get_window_property, x_get_window_property_as_lisp_data):
1427 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
1428 Remove unnecessary pointer casts.
1429 * alloc.c (record_xmalloc): New function.
1430 * lisp.h (record_xmalloc): New decl.
1431 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
1432 more like a function. This is because the pointer cast is not
1433 needed. All uses changed.
1434 * print.c (print_string, print_error_message): Avoid length recalc.
1435
8834c57a
PE
1436 Improve fix for macroexp crash with debugging (Bug#12118).
1437 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
1438 ARRAY_MARK_FLAG when checking subscripts, because ASET is
1439 not supposed to be invoked from the garbage collector.
1440 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
1441 (gc_aset): New function, which is like ASET but can be
1442 used in the garbage collector.
1443 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1444 (set_hash_index): Use it instead of ASET.
1445
6dad7178
EZ
14462012-08-03 Eli Zaretskii <eliz@gnu.org>
1447
1448 Support symlinks on latest versions of MS-Windows.
1449 * w32.c: Include winioctl.h and aclapi.h.
1450 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
1451 (revert_to_self): Forward declarations of static functions.
1452 <static BOOL g_b_init_get_security_info>:
1453 <g_b_init_create_symbolic_link>: New static flags.
1454 (globals_of_w32): Initialize them to zero.
1455 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
1456 (map_w32_filename): Improve commentary. Simplify switch.
1457 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
1458 headers (most versions of MinGW w32api don't).
1459 (get_security_info, create_symbolic_link)
1460 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
1461 New functions.
1462 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
1463 in the argument file name.
1464 (sys_access): Call unc_volume_file_attributes only if
1465 GetFileAttributes fails with network-related error codes.
1466 (sys_rename): Diagnose renaming of a symlink when the user doesn't
1467 have the required privileges.
14ae4239 1468 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
1469 get_file_security_desc.
1470 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
1471 with addition of handling of symlinks and support for 'lstat'.
1472 If possible, get file's attributes and security information by
6dad7178
EZ
1473 handle, not by name. Produce S_IFLNK bit for symlinks, when
1474 called from 'lstat'.
1475 (stat, lstat): New functions, call 'stat_worker'.
1476 (symlink, readlink, careadlinkat): Rewritten to create and resolve
1477 symlinks when the underlying filesystem supports them.
1478
f162bcc3
PE
14792012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1480
79ea6c20
PE
1481 Fix macroexp crash on Windows with debugging (Bug#12118).
1482 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
1483 checking subscripts; problem introduced with the recent
1484 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
1485 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1486 since it's used in non-static inline functions now.
1487
c0ce93fd
PE
1488 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1489 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1490
f162bcc3
PE
1491 Use C99-style 'extern inline' if available.
1492 * buffer.h (BUFFER_INLINE):
1493 * category.h (CATEGORY_INLINE):
1494 * character.h (CHARACTER_INLINE):
1495 * charset.h (CHARSET_INLINE):
1496 * composite.h (COMPOSITE_INLINE):
1497 * dispextern.h (DISPEXTERN_INLINE):
1498 * lisp.h (LISP_INLINE):
1499 * systime.h (SYSTIME_INLINE):
1500 New macro, replacing 'static inline' in this header.
1501 * buffer.h, category.h, character.h, charset.h, composite.h:
1502 * dispextern.h, lisp.h, systime.h:
1503 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1504 * alloc.c (LISP_INLINE):
1505 * buffer.c (BUFFER_INLINE):
1506 * category.c (CATEGORY_INLINE):
1507 * character.c (CHARACTER_INLINE):
1508 * charset.c (CHARSET_INLINE):
1509 * composite.c (COMPOSITE_INLINE):
1510 * dispnew.c (DISPEXTERN_INLINE):
1511 * sysdep.c (SYSTIME_INLINE):
1512 Define to EXTERN_INLINE, so that the corresponding functions
1513 are compiled into code.
1514 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1515 (INLINE_HEADER_END): New macros.
1516 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1517 since it's used in non-static inline functions now.
a8333d03 1518 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1519
837b365b
GM
15202012-08-02 Glenn Morris <rgm@gnu.org>
1521
d66b744d
GM
1522 * s/: Remove empty directory.
1523
837b365b
GM
1524 * s/ms-w32.h: Move to ../nt/inc.
1525 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1526 Update for new ms-w32.h location.
1527
13294f95
PE
15282012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1529
1530 Port to Solaris 8.
1531 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1532
90df0db3
GM
15332012-08-02 Glenn Morris <rgm@gnu.org>
1534
1535 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1536 hard-coding the path separator.
1537
4939150c
PE
15382012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1541 This how ASET and AREF are supposed to work, and makes
1542 it easier to think about future improvements. See
1543 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1544 * charset.h (set_charset_attr): New function.
1545 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1546 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1547 (aref_addr): New function. All uses of &AREF(...) changed.
1548 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1549 (set_hash_index): New functions. All lvalue-style uses of
1550 HASH_KEY etc. changed.
1551 * keyboard.c (set_prop): New function. All lvalue-style uses
1552 of PROP changed.
1553
947b2afd
AA
15542012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1555
1556 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1557 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1558 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1559 * nsfns.m (ns_set_name_as_filename): Likewise.
1560 * nsmenu.m (ns_update_menubar): Likewise.
1561 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1562
4f5d0325
EZ
15632012-08-01 Eli Zaretskii <eliz@gnu.org>
1564
2008beae
EZ
1565 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1566 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1567 objects.
2008beae 1568
4f5d0325
EZ
1569 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1570
fe3cc771
GM
15712012-08-01 Glenn Morris <rgm@gnu.org>
1572
1573 * s/msdos.h: Remove file.
1574 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1575 * Makefile.in (S_FILE): Remove.
1576 (config_h): Remove S_FILE.
1577
c90acc54
JB
15782012-08-01 Juanma Barranquero <lekktu@gmail.com>
1579
1580 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1581 Remove; moved to nt/config.nt.
1582
d8a05828
DA
15832012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1584
1585 Use INTERNAL_FIELD for conses and overlays.
1586 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1587 Remove obsolete comment.
1588 (MVAR): New macro.
1589 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1590 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1591
8271d590
DA
15922012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1593
1594 Use INTERNAL_FIELD for symbols.
1595 * lisp.h (SVAR): New macro. Adjust users.
1596 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1597 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1598
3193acd2
DA
15992012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1600
1601 Use INTERNAL_FIELD for processes.
1602 * process.h (PVAR): New macro. Adjust style.
1603 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1604 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1605
3a45383a
DA
16062012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1607
1608 Use INTERNAL_FIELD for windows.
1609 * window.h (WVAR): New macro.
1610 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1611 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1612 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1613 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1614 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1615 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1616
c1dbc63c
PE
16172012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1620
5c0c0e8a
GM
16212012-08-01 Glenn Morris <rgm@gnu.org>
1622
1623 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1624 Move to configure.ac.
1625
552a99b4
JB
16262012-08-01 Juanma Barranquero <lekktu@gmail.com>
1627
1628 * makefile.w32-in (CONFIG_H): Update dependencies.
1629 (CONF_POST_H): New macro.
1630
1631 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1632
8d8e2dfe
GM
16332012-07-31 Glenn Morris <rgm@gnu.org>
1634
bc96620a
GM
1635 * Makefile.in (S_FILE): No longer set by configure.
1636
476b1b2d
GM
1637 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1638 is available.
1639 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1640
b2c7a106
GM
1641 * process.h (NULL_DEVICE):
1642 * emacs.c (SEPCHAR):
1643 * editfns.c (USER_FULL_NAME): Let configure set them.
1644
d53d062a
GM
1645 * s/README, s/template.h: Remove files.
1646
4515017f
GM
1647 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1648
8d8e2dfe
GM
1649 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1650 Move to configure.ac.
1651
5b20b3cc
EZ
16522012-07-31 Eli Zaretskii <eliz@gnu.org>
1653
1e0afd9a
EZ
1654 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1655 resulting renaming of 'struct frame' members.
1656
5b20b3cc
EZ
1657 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1658
1659 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1660 after introduction of FVAR.
1661
f1310128
JD
16622012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1663
79e721e0
JD
1664 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1665
1666 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1667 instead of compositeToPoint.
1668 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1669
8d7c7eed 1670 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1671
e34f7f79
DA
16722012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1673
1674 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1675 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1676 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1677 (BVAR): Change to use INTERNAL_FIELD.
1678 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1679 (KVAR): Change to use INTERNAL_FIELD.
1680 * frame.h (FVAR): New macro.
1681 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1682 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1683 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1684 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1685 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1686
c09bfb2f
DA
16872012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1688
1689 Miscellaneous fixes for non-default X toolkits.
1690 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1691 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1692 Move under #ifdef USE_LUCID.
1693 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1694 definition and usage to avoid warnings.
1695
14c114ae
JD
16962012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1697
1698 * nsterm.m (openFiles): Fix previous checkin.
1699
3bd21e82
PE
17002012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1701
1702 * indent.c (compute_motion): Remove unused local.
1703
c1529ded
GM
17042012-07-31 Glenn Morris <rgm@gnu.org>
1705
400d5621
GM
1706 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1707
268e2432
GM
1708 * conf_post.h [USG5_4]:
1709 Move remaining contents of s/usg5-4-common.h here.
1710 * s/usg5-4-common.h: Remove file.
1711
7552f3ee
GM
1712 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1713 * s/irix6-5.h: Remove file.
1714
6a381852
GM
1715 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1716 * s/darwin.h: Remove file.
1717
c1529ded
GM
1718 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1719 * s/hpux10-20.h: Remove file, which is now empty.
1720
b429a4ee
GM
17212012-07-30 Glenn Morris <rgm@gnu.org>
1722
1723 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1724 * Makefile.in (config_h): Add conf_post.h.
1725 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1726
adff3182
JD
17272012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1728
1729 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1730 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1731 (openFile, openTempFile, openFileWithoutUI, openFiles):
1732 Open files only if ns_do_open_file.
adff3182 1733
c32af1e4
PE
17342012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1735
7393bcbb
PE
1736 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1737 This no-op macro hasn't been needed for many years.
1738 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1739
c32af1e4
PE
1740 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1741 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1742 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1743 gdb_make_enums_visible.
1744 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1745 (DIRECTORY_SEP): Now a constant, not a macro.
1746
302fc036
EZ
17472012-07-30 Eli Zaretskii <eliz@gnu.org>
1748
1749 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1750 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1751
1752 * w32term.c <w32_keyboard_codepage>: Renamed from
1753 keyboard_codepage and now external. All users changed.
1754
1755 * w32term.h: Add declaration of w32_keyboard_codepage.
1756
1757 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1758 the codepage to translate keys to Unicode. If this argument is
1759 -1, use the value returned by GetConsoleCP. All callers changed.
1760
88fb40b4
PE
17612012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1762
0aee6912
PE
1763 Update .PHONY listings in makefiles.
1764 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1765 bootstrap-clean, distclean, maintainer-clean, versioclean,
1766 extraclean, frc.
1767
88fb40b4
PE
1768 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1769 This is a bit clearer. Fix some commentary typos.
1770
0a763bd1
GM
17712012-07-30 Glenn Morris <rgm@gnu.org>
1772
32bac6d6
GM
1773 * s/netbsd.h: Let configure include signal.h if needed.
1774 Remove file, which is now empty.
1775
b65e7c46
GM
1776 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1777 Let configure set them.
1778 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1779 No more need to undefine.
0a763bd1 1780
169304bd
AS
17812012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1782
1783 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1784 non-single-byte char when adding meta modifier. (Bug#12090)
1785
6cd7a139
DA
17862012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1787
1788 Convert safe_call to use variable number of arguments.
1789 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1790 (safe_call2): Fix comment.
1791 * lisp.h (safe_call): Adjust prototype.
1792 * coding.c (encode_coding_object): Change to use safe_call2.
1793 * xfaces.c (merge_face_heights): Change to use safe_call1.
1794
d34d6ffc
GM
17952012-07-30 Glenn Morris <rgm@gnu.org>
1796
7b8a48e4 1797 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1798 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1799
d34d6ffc
GM
1800 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1801 Remove empty files.
1802
03a660a6
PE
18032012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1804
1805 Export to GDB most of lisp.h's remaining object-like macros.
1806 * lisp.h (min, max): Move earlier, because they're used earlier now.
1807 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1808 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1809 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1810 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1811 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1812 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1813 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1814 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1815 Now constants, for GDB. They need not be macros.
1816 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1817 Now constants, for GDB, as well as macros, for static initializers.
1818 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1819 Move to after the definition of struct Lisp_Char_Table,
1820 since the former now needs that type defined.
1821 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1822 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1823 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1824 New enums, for gdb_make_enums_visible.
1825 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1826 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1827 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1828 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1829 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1830 enum maxargs, enum MAX_ALLOCA.
1831 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1832 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1833 no longer needed, now that they are done in lisp.h.
1834
e499d0ee
DA
18352012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1836
1837 Cleanup string bytes checking.
1838 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1839 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1840 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1841 (check_sblock, compact_small_strings): Simplify.
1842
d5040d2d
PE
18432012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1844
1845 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1846 These macros are confusing and no longer need to be defined, as
1847 the enum values now suffice. All uses replaced with definiens.
1848 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1849
7f259ae6
JB
18502012-07-29 Juanma Barranquero <lekktu@gmail.com>
1851
1852 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1853 ($(BLD)/w32console.$(O)): Update dependencies.
1854
7e63e0c3
DA
18552012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1856
1857 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1858 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1859 time. Adjust users.
1860 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1861
ffd817eb
JD
18622012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1863
1864 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1865 setting sitelisp (Bug#12010).
1866
417a7a0e
EZ
18672012-07-29 Eli Zaretskii <eliz@gnu.org>
1868
14ae4239 1869 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1870
1871 * w32heap.c (cache_system_info):
1872 * w32.c (sys_rename):
1873 * w32proc.c (find_child_console, sys_kill): All users changed.
1874
387d4d92
PE
18752012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1878
55a6cca6
EZ
18792012-07-29 Eli Zaretskii <eliz@gnu.org>
1880
1881 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1882
dbcf001c
DA
18832012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1884
1885 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1886 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1887 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1888
e2688e4a
DA
18892012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1890
1891 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1892 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1893 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1894 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1895 (replace_range, replace_range_2, del_range_2): Change to eassert.
1896 * marker.c (byte_char_debug_check): Adjust style.
1897
b46a6a83
PE
18982012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1899
1900 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1901 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1902 long-ago-commented-out code that talks about "WIN32".
1903 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1904 All uses changed.
1905
e32a5799
PE
19062012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1909 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1910 Simplify by using alignof.
1911 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1912 * lisp.h: Include <stdalign.h>.
1913 (GCALIGNMENT): New macro and constant.
1914 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1915 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1916 (stdalign): New macro, if not already defined.
1917
df81cd29
EZ
19182012-07-28 Eli Zaretskii <eliz@gnu.org>
1919
01bd1b0d
EZ
1920 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1921 * w32inevt.c: Include w32inevt.h.
1922 (w32_read_console_input): New inline function, calls either
1923 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1924 w32_console_unicode_input.
1925 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1926 (w32_kbd_patch_key, key_event): Use the codepage returned by
1927 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1928 (key_event): use uChar.UnicodeChar only if
1929 w32_console_unicode_input is non-zero.
1930
1931 * w32console.c: Include w32heap.h.
1932 <w32_console_unicode_input>: New global variable.
1933 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1934 family of Windows, zero otherwise.
1935
1936 * w32inevt.h: Declare w32_console_unicode_input.
1937
df81cd29
EZ
1938 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1939 --without-x. (Bug#11742)
1940
c20fdd9e
PE
19412012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 Adjust GDB to reflect pvec_type changes (Bug#12036).
1944 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1945 2012-07-04 changes to pseudovector representation.
1946 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1947
32770973 19482012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1949
1950 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1951 bus address.
1952 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1953
3438fe21
EZ
19542012-07-27 Eli Zaretskii <eliz@gnu.org>
1955
bcfbc9de
EZ
1956 * alloc.c (listn): Fix the order the arguments are consed onto the
1957 list.
1958
3438fe21
EZ
1959 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1960 enumeration constants, as PURE and HEAP are too general, and clash
1961 with other headers and sources, such as gmalloc.c and the
1962 MS-Windows system headers. All users changed.
1963
eeaea515
DA
19642012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1965
1966 Revert last save_excursion_save and save_excursion_restore changes.
1967 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1968 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1969
073c88c2
DA
19702012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1971
1972 Fix recently-introduced typos in Windows port.
1973 Reported by Martin Rudalics <rudalics@gmx.at>.
1974 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1975 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1976
4706125e
PE
19772012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 Improve GDB symbol export (Bug#12036).
1980 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1981 arms of an 'if', not using conditional expressions; otherwise GDB
1982 complains about the types in the unevaluated arm when the argument
1983 is an integer literal.
1984 (xgetint): Simplify expression.
1985 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1986 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1987 Zaretskii in <http://bugs.gnu.org/12036#13>.
1988 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1989 needed now that we have gdb_make_enums_visible.
1990 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1991 (enum enum_USE_LSB_TAG):
1992 New enum types, packaging up enums that need to be exported to GDB.
1993
694b6c97
DA
19942012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1995
1996 Utility function to make a list from specified amount of objects.
1997 * lisp.h (enum constype): New datatype.
1998 (listn): New prototype.
1999 * alloc.c (listn): New function.
2000 (Fmemory_use_count, syms_of_alloc): Use it.
2001 * buffer.c (syms_of_buffer): Likewise.
2002 * callint.c (syms_of_callint): Likewise.
2003 * charset.c (define_charset_internal): Likewise.
2004 * coding.c (syms_of_coding): Likewise.
2005 * keymap.c (syms_of_keymap): Likewise.
2006 * search.c (syms_of_search): Likewise.
2007 * syntax.c (syms_of_syntax): Likewise.
2008 * w32.c (init_environment): Likewise.
2009 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2010 * xdisp.c (syms_of_xdisp): Likewise.
2011 * xfns.c (syms_of_xfns): Likewise.
2012
6195f384
DA
20132012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2014
2015 Fast save_excursion_save and save_excursion_restore.
2016 * lisp.h (struct Lisp_Excursion): New data type.
2017 (PVEC_EXCURSION): New pseudovector type.
2018 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2019 to deal with it. Adjust comments.
2020 (init_marker, attach_marker): New prototype.
2021 (unchain_marker): Adjust prototype.
2022 * marker.c (attach_marker): Change to global.
2023 (init_marker): New function.
2024 * alloc.c (Fmake_marker, build_marker): Use it.
2025 (build_marker): More easserts.
2026 (mark_object): Handle struct Lisp_Excursion.
2027 * editfns.c (save_excursion_save, save_excursion_restore):
2028 Reimplement to use struct Lisp_Excursion. Add comments.
2029
5eceb8fb
PE
20302012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 Fix export of symbols to GDB (Bug#12036).
2033 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2034 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2035 emacs.c, as this is a more-suitable home. Had this been done earlier
2036 the fix for 12036 would have avoided some of the problems noted in
2037 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2038 would have been more obvious.
562157c8
PE
2039 * emacs.c: Do not include <verify.h>; no longer needed.
2040 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2041 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2042 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2043 Remove; now done in lisp.h.
2044 * lisp.h (PUBLISH_TO_GDB): New macro.
2045 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2046 (DATA_SEG_BITS): Use it.
2047 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2048 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2049 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2050 not be usable in #if. This simplifies things.
2051
d6749401
JB
20522012-07-26 Juanma Barranquero <lekktu@gmail.com>
2053
2054 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2055
1781b9e9
PE
20562012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2057
d89518db 2058 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2059 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2060 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2061 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2062 Adjust to changes in lisp.h and emacs.c, by using
2063 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2064 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2065 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2066 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2067 instead of gdb_valbits.
2068 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2069 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2070 instead of gdb_array_mark_flag.
2071 (xboolvector): Get size from $->size, not $->header.size.
2072 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2073 (xreload, hook-run, hookpost-run): Remove.
2074 * emacs.c: Include <verify.h>.
2075 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2076 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2077 Remove.
2078 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2079 (gdb_USE_LSB_TAG): New enum constants.
2080 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2081 Also define these as enum constants, so they're visible to GDB.
2082 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2083 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2084 as constants, so they're visible to GDB.
2085 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2086 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2087 Now enum constants, not macros, so they're visible to GDB.
2088 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2089 more convenient now. All uses changed.
2090 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2091 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2092
3628596a
DA
20932012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2094
2095 Explicitly free restriction data that are not needed anymore.
2096 * editfns.c (save_restriction_restore): Free restriction data.
2097
7abaf5cc
SM
20982012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2099
2100 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2101 add argument, tune behavior, and adjust all callers.
2102
71f88e00
PE
21032012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 Use typedef for EMACS_INT, EMACS_UINT.
2106 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2107 than macros. This simplifies debugging in the usual case, since
2108 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2109 and it allows expressions involving EMACS_INT casts.
2110 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2111
57ec3034
JD
21122012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2113
2114 * nsterm.m (ns_read_socket): Return early if there is a modal
2115 window (Bug#12043).
2116
8137e7b3
MR
21172012-07-25 Martin Rudalics <rudalics@gmx.at>
2118
2119 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2120 that FOCUS-FRAME can be omitted.
2121
04e9897c
DA
21222012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2123
2124 Adjust buffer text indirection counters at the end of Fkill_buffer.
2125 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2126 buffer is definitely dead. This should really fix an issue reported
2127 by Christoph Scholtes again. (Bug#12007).
2128 (init_buffer_once): Initialize indirection counters of
2129 buffer_defaults and buffer_local_symbols (for sanity and safety).
2130
8a0484e1
EZ
21312012-07-24 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2134 and continuation glyphs on tooltip frames, leave them at zero.
2135 Avoids continued lines in tooltips. (Bug#11832)
2136
fa691a83
DA
21372012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2138
2139 Simplify copy_overlay.
04e9897c 2140 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2141 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2142
436bc8e0
EZ
21432012-07-23 Eli Zaretskii <eliz@gnu.org>
2144
2145 * print.c (print_object): Don't crash when a frame's name is nil
2146 or invalid. (Bug#12025)
2147
2148 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2149 it signals an error when a tooltip frame is being created.
2150
d7a7fda3
DA
21512012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2152
2153 Cleanup miscellaneous objects allocation and initialization.
2154 * alloc.c (allocate_misc): Change to static. Add argument to
2155 specify the subtype. Adjust comment and users.
2156 (build_overlay): New function.
2157 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2158 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2159 (allocate_misc): Remove prototype.
2160 (build_overlay): Add prototype.
2161
21622012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2163
2164 Swap buffer text indirection counters in Fbuffer_swap_text.
2165 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2166 This avoids crash reported by Christoph Scholtes at
2167 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2168
9d7fa573
JD
21692012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2170
2171 * nsmenu.m (Popdown_data): New struct.
2172 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2173 free Popdown_data.
2174 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2175 (initWithContentRect): Make imgView and contentView non-static
2176 and autorelease them. Also autorelease img and matrix (Bug#12005).
2177 (dealloc): Remove (Bug#12005).
2178
0dd6d66d
DA
21792012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2180
2181 Adjust consing_since_gc when objects are explicitly freed.
2182 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2183 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2184 (free_cons, free_misc): Subtract object size from consing_since_gc.
2185
d36d71df
DA
21862012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2187
2188 Simplify and cleanup markers positioning code.
2189 * marker.c (attach_marker): More useful eassert.
2190 (live_buffer, set_marker_internal): New function.
2191 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2192 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2193
fb9ea40f
PE
21942012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2195
2196 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2197 as it's limited by the amount of memory, not by INT_MAX.
2198
2d5c5f7d
EZ
21992012-07-21 Eli Zaretskii <eliz@gnu.org>
2200
07fb592e
EZ
2201 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2202 in special-event-map. See the discussion at
2203 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2204 for the reasons.
2205
37a9eac8 2206 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
2207 info.dwItemData. Fixes crashes on 64-bit Windows.
2208 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 2209
c4328746
JD
22102012-07-21 Jan Djärv <jan.h.d@swipnet.se>
2211
2212 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 2213 (conversationIdentifier): Return value is NSInteger.
784051c4 2214 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 2215
6e5d1c12
CY
22162012-07-21 Chong Yidong <cyd@gnu.org>
2217
2218 * window.c (decode_any_window): Signal an error if the window is
2219 on a dead frame (Bug#11984).
2220
9928463d
DA
22212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2222
2223 Add indirection counting to speed up Fkill_buffer.
2224 * buffer.h (struct buffer): New member.
2225 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
2226 (Fmake_indirect_buffer): Set indirection counter to -1, increment
2227 base buffer indirection counter.
2228 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
2229 (Fkill_buffer): Adjust indirection counters as needed, don't walk
2230 through buffer list if indirection counter is 0.
2231
f8643a6b
DA
22322012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2233
2234 Extend the value returned by Fgarbage_collect with heap statistics.
2235 * alloc.c (Qheap): New symbol.
2236 (syms_of_alloc): DEFSYM it.
2237 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
2238 (Fmemory_free): Remove.
2239 (syms_of_alloc): Don't defsubr it.
2240 * buffer.c (Fcompact_buffer): Remove.
2241 (syms_of_buffer): Don't defsubr it.
2242
dac616ff
DA
22432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2244
2245 Make maybe_gc inline.
2246 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
2247 * lisp.h (consing_since_gc, gc_relative_threshold)
2248 (memory_full_cons_threshold): Revert declaration.
2249 (maybe_gc): Remove prototype, define as inline.
2250 * alloc.c: Remove old commented-out code.
2251 (consing_since_gc, gc_relative_threshold)
2252 (memory_full_cons_threshold): Revert to global.
2253 (maybe_gc): Remove.
2254
d7ea76b4
DA
22552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2256
2257 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
2258 * lisp.h (build_unibyte_string): New function.
2259 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
2260 * sysdep.c, w32fns.c, xfns.c: Use it.
2261 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
2262 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
2263 Adjust users accordingly.
2264 * font.h (font_open_by_name): Adjust prototype.
2265
765e61e3
DA
22662012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2267
2268 Cleanup calls to Fgarbage_collect.
2269 * lisp.h (maybe_gc): New prototype.
2270 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2271 Remove declarations.
2272 * alloc.c (maybe_gc): New function.
2273 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2274 Make them static.
2275 * bytecode.c (MAYBE_GC): Use maybe_gc.
2276 * eval.c (eval_sub, Ffuncall): Likewise.
2277 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
2278 to avoid dependency from auto-save feature.
2279
52b852c7
PE
22802012-07-19 Paul Eggert <eggert@cs.ucla.edu>
2281
2282 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
2283 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
2284 'for_each_per_buffer_object_at'.
2285 All uses changed. It's better to use upper-case for macros that
2286 cannot be implemented as functions, to give the reader a clue
2287 that they're special.
2288
5db81e33
SM
22892012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
2290
2291 * alloc.c (Fgarbage_collect): Tweak docstring.
2292
5b835e1d
DA
22932012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2294
2295 Tweak the value returned from Fgarbage_collect again.
2296 * alloc.c (Fgarbage_collect): New return value, as confirmed in
2297 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
2298 Adjust documentation.
2299 (total_vector_bytes): Rename to total_vector_slots, adjust
2300 accounting.
2301 (total_free_vector_bytes): Rename to total_free_vector_slots,
2302 adjust accounting.
2303 (Qstring_bytes, Qvector_slots): New symbols.
2304 (syms_of_alloc): DEFSYM them.
2305
9cd47b72
DA
23062012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2307
2308 Buffer compaction primitive which may be used from Lisp.
2309 * buffer.c (compact_buffer, Fcompact_buffer): New function.
2310 (syms_of_buffer): Register Fcompact_buffer.
2311 * alloc.c (Fgarbage_collect): Use compact_buffer.
2312 * buffer.h (compact_buffer): New prototype.
2313 (struct buffer_text): New member.
2314
d17337e5
DA
23152012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2316
2317 New macro to iterate over all buffers, miscellaneous cleanups.
2318 * lisp.h (all_buffers): Remove declaration.
2319 * buffer.h (all_buffers): Add declaration, with comment.
2320 (for_each_buffer): New macro.
2321 * alloc.c (Fgarbage_collect, mark_object): Use it.
2322 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
2323 (init_buffer): Likewise.
2324 * data.c (Fset_default): Likewise.
2325 * coding.c (code_conversion_restore): Remove redundant check
2326 for dead buffer.
2327 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
2328
60cfd278
AS
23292012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2330
2331 Fix bug that created negative-length intervals.
2332 * intervals.c (merge_interval_right, merge_interval_left):
2333 Do not zero out this interval if it is absorbed by its children,
2334 as this interval's total length doesn't change in that case. See
2335 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
2336
d06714cb
PE
23372012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2338
83713154
PE
2339 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
2340 when invoking (make-bool-vector N t) and N is a positive
2341 multiple of 8 -- the last 8 bits were mistakenly cleared.
2342
d06714cb
PE
2343 Remove some struct layout assumptions in bool vectors.
2344 * alloc.c (bool_header_size): New constant.
2345 (header_size, word_size): Move earlier, as they're now used earlier.
2346 Use 'word_size' in a few more places, where it's appropriate.
2347 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
2348 padding before the data member of a bool vector.
2349 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
2350 than doing the check by hand with an abort ().
2351
464d5a5e
SM
23522012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2353
5fbc0409
SM
2354 * eval.c (Fdefvar): Don't check constants since we only set the var if
2355 it's not yet defined anyway (bug#11904).
2356
464d5a5e
SM
2357 * lisp.h (last_undo_boundary): Declare new var.
2358 * keyboard.c (command_loop_1): Set it.
2359 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
2360 were auto-added by the command loop (bug#11774).
2361
8dc2e44a
AS
23622012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2363
2364 * w32font.c (Qsymbol): Remove local definition.
2365 (syms_of_w32font): Don't DEFSYM it.
2366
169925ec
DA
23672012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2368
2369 Fix sweep_vectors to handle large bool vectors correctly.
2370 * alloc.c (sweep_vectors): Account total_vector_bytes for
2371 bool vectors larger than VBLOCK_BYTES_MAX.
2372
5fbfb018
CY
23732012-07-18 Chong Yidong <cyd@gnu.org>
2374
2375 * frame.c (x_set_frame_parameters): Revert bogus change introduced
2376 in 2012-05-25 commit by Paul Eggert (Bug#11738).
2377
3ab6e069
DA
23782012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2379
2380 Return more descriptive data from Fgarbage_collect.
2381 Suggested by Stefan Monnier in
2382 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
2383 * alloc.c (bounded_number): New function.
2384 (total_buffers, total_vectors): New variable.
2385 (total_string_size): Rename to total_string_bytes, adjust users.
2386 (total_vector_size): Rename to total_vector_bytes, adjust users.
2387 (sweep_vectors): Account total_vectors and total_vector_bytes.
2388 (Fgarbage_collect): New return value. Adjust documentation.
2389 (gc_sweep): Account total_buffers.
2390 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
2391 (VECTOR_SIZE): Remove.
2392 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
2393 (Qinterval, Qmisc): New symbols.
2394 (syms_of_data): Initialize them.
2395 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
2396 (Qcons, Qbuffer): New declarations.
2397
6d02fe5b
PE
23982012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 * alloc.c (Fmemory_free): Account for memory-free's own storage.
2401 Round up, not down. Improve doc.
2402
b7ffe040
DA
24032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2404
2405 Restore old code in allocate_string_data to avoid Faset breakage.
2406 Reported by Julien Danjou <julien@danjou.info> in
2407 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
2408 * alloc.c (allocate_string_data): Restore old code with minor
2409 adjustments, fix comment to explain this subtle issue.
2410
4dc7c8d5
SM
24112012-07-17 Eli Zaretskii <eliz@gnu.org>
2412
2413 Remove FILE_SYSTEM_CASE.
2414 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
2415
2416 * fileio.c (FILE_SYSTEM_CASE): Don't define.
2417 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
2418 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
2419 call-process-region passes it through expand-file-name.
2420
2421 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
2422
24232012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2424
2425 Fix crash when creating indirect buffer (Bug#11917)
2426 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
2427 Don't handle unbound variables specially if non-zero.
2428 (Fbuffer_local_variables): Pass zero.
2429 (clone_per_buffer_values): Pass non-zero.
2430
24312012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2432
2433 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
2434 to make the loop interruptible.
2435
24362012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2437
2438 * gnutls.c (emacs_gnutls_handshake): Only retry if
2439 GNUTLS_E_INTERRUPTED.
2440
cce7fefc
DA
24412012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2442
2443 Cleanup and convert miscellaneous checks to eassert.
2444 * alloc.c (mark_interval): Fix comment, partially rephrase
2445 old comment from intervals.h (see below).
2446 * intervals.c (find_interval, adjust_intervals_for_insertion)
2447 (delete_interval, adjust_intervals_for_deletion)
2448 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
2449 Convert to eassert.
2450 (adjust_intervals_for_insertion, make_new_interval):
2451 Remove obsolete and unused code.
2452 * intervals.h (struct interval): Remove obsolete comment.
2453 * textprotp.c (erase_properties): Remove unused code.
2454 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
2455 (Fremove_list_of_text_properties): Convert to eassert.
2456
9ea10cc3
CY
24572012-07-17 Chong Yidong <cyd@gnu.org>
2458
2459 * editfns.c (Finsert_char): Doc fix.
2460
3900d5de
DA
24612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2462
2463 Fix previous change to make Fmemory_free always accurate.
2464 * alloc.c (make_interval): Update total_free_intervals.
2465 (make_float): Likewise for total_free_floats.
2466 (free_cons, Fcons): Likewise for total_free_conses.
2467 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
2468 Likewise for total_free_vector_bytes.
2469 (Fmake_symbol): Likewise for total_free_symbols.
2470 (bytes_free): Remove.
2471
7098646f
DA
24722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2473
2474 Simple free memory accounting feature.
2475 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
2476 (sweep_vectors): Accumulate size of free vectors.
2477 (Fgarbage_collect): Setup bytes_free.
2478 (Fmemory_free): New function.
2479 (syms_of_alloc): Register it.
2480
22657b40
DA
24812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2482
2483 Cleanup overlays checking.
2484 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
2485 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2486 eassert and OVERLAYP.
2487 (sort_overlays): Change to use OVERLAYP.
2488
ddfc8813
RK
24892012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2490
2491 * editfns.c (Finsert_char): Make it interactive, and make the
2492 second arg optional. Copy interactive spec and docstring from
2493 ucs-insert.
2494
7c26cf3c
PE
24952012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2498 Unlike the other wrapped functions, fabs has an unspecified
2499 effect on errno.
2500
5d127af9
JD
25012012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2502
2503 * nsterm.m (keyDown): Interpret flags without left/right bits
2504 as the left key (Bug#11670).
2505
6a0dd1d7
DA
25062012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2507
2508 Remove empty and useless init functions.
2509 * lisp.h (init_character_once, init_fns, init_image)
2510 (init_filelock, init_sound): Remove prototype.
2511 * character.c (init_character_once): Remove.
2512 * filelock.c (init_filelock): Likewise.
2513 * fns.c (init_fns): Likewise.
2514 * image.c (init_image): Likewise.
2515 * sound.c (init_sound): Likewise.
2516 * emacs.c (main): Adjust accordingly.
2517
7a6136fd
DA
25182012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2519
2520 * gtkutil.h: Tiny cleanups.
2521 (use_old_gtk_file_dialog): Remove useless declaration.
2522 (xg_uses_old_file_dialog): Add suggested const attribute.
2523
ce811ad9
EZ
25242012-07-15 Eli Zaretskii <eliz@gnu.org>
2525
2526 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2527 (bidi_paragraph_init): Use it to limit search forward for a strong
2528 directional character in abnormally large paragraphs full of
2529 neutral or weak characters. (Bug#11943)
2530
c9adfeaa
SF
25312012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2532
2533 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2534 the toolbar (Bug#9451).
2535 (xg_make_tool_item): Give the widget event box a transparent
2536 background.
2537
fff62aa9
DA
25382012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2539
2540 Cleanup basic allocation variables and functions.
2541 * alloc.c (ignore_warnings, init_intervals, init_float)
2542 (init_cons, init_symbol, init_marker): Remove.
2543 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2544 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2545 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2546 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2547 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2548 (staticidx, init_alloc_once, init_strings, free_ablock):
2549 Remove redundant initialization.
2550 * fns.c (init_weak_hash_tables): Remove.
2551 * lisp.h (init_weak_hash_tables): Remove prototype.
2552
9730daca
DA
25532012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2554
2555 Use zero_vector where appropriate.
2556 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2557 accordingly.
2558 * lisp.h (zero_vector): New declaration.
2559 * font.c (null_vector): Remove.
2560 (syms_of_font): Remove initialization and staticpro.
2561 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2562 * keymap.c (Faccessible_keymaps): Likewise.
2563
2e2d2a13
LL
25642012-07-15 Leo Liu <sdl.web@gmail.com>
2565
2566 * fringe.c: Fix typo in comments.
2567
cd276f6e
LL
25682012-07-14 Leo Liu <sdl.web@gmail.com>
2569
2570 * fringe.c: Add a new bitmap exclamation-mark.
2571
5a1131d9
EZ
25722012-07-14 Eli Zaretskii <eliz@gnu.org>
2573
2574 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2575
2576 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2577 (HAVE_MENUS): Don't define, defined by editing config.in with
2578 msdos/sed2v2.inp.
2579 (GMALLOC_INHIBIT_VALLOC): Don't define.
2580 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2581
22e983b7
JB
25822012-07-14 Juanma Barranquero <lekktu@gmail.com>
2583
2584 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2585
5b3f250f
GM
25862012-07-14 Glenn Morris <rgm@gnu.org>
2587
2588 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2589 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2590 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2591
33d63ff4
GM
25922012-07-13 Glenn Morris <rgm@gnu.org>
2593
5b633342
GM
2594 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2595
33d63ff4
GM
2596 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2597 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2598
b55b9f85
JD
25992012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2600
0dc8cf50
JD
2601 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2602 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2603 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2604 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2605 where appropriate.
2606 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2607 as boolean expression.
2608 (x_set_window_size): Remove unused variable toolbar.
2609 (ns_get_color_default, ns_mod_to_lisp): Remove.
2610 (ns_mouse_position): Remove unused variables xchar and ychar.
2611 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2612 (ns_set_vertical_scroll_bar): Remove unused variable count.
2613 (ns_delete_terminal): Remove unused variable i.
2614 (ns_term_init): Remove unused variables r, g and b.
2615 (mouseDown): Remove unused variable window.
2616 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2617 (initFrameFromEmacs): Remove unused variable vbextra.
2618 (mouseEntered): Remove unused variables p and dpyinfo.
2619 (mouseExited): Remove unused variables p and r.
2620 (ns_define_frame_cursor, ns_clear_frame_area)
2621 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2622 (menuDown): Assign [sender tag] to variable and cast the variable.
2623
2624 * nsterm.h (menuDown): Add id as type to argument sender.
2625 (ns_display_info_for_name): Add Lisp_Object argument.
2626 (ns_term_init): Add Lisp_Object argument.
2627 (ns_map_event_to_object): Add void argument.
2628 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2629 prototype with arguments and only declare if __OBJC__.
2630 (nxatoms_of_nsselect): Add void argument.
2631 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2632 (ns_alloc_autorelease_pool): Add void argument.
2633 (ns_release_autorelease_pool): Add void* argument.
2634 (ns_get_defaults_value): Add const char* argument.
2635
2636 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2637 (initFromContents): Use SSDATA where appropriate.
2638 (ns_update_menubar): Add braces to ambigous if-else.
2639 (initWithTitle): Put () around assignment in if statement.
2640 (ns_menu_show): Remove unused variables window and keymap.
2641 (update_frame_tool_bar): Remove unused variable selected_p.
2642 (initWithContentRect): Remove unused variable this_cmd_name.
2643
2644 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2645 appropriate.
2646 (setXBMColor): Remove unused variable len.
2647 (setPixmapData): Put () around assignment in loop statement.
2648
2649 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2650 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2651 where appropriate.
2652 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2653 around assignment in loop statement.
2654 (nsfont_open): Remove unused variable i.
2655 (nsfont_open): Remove unused variable len.
2656 (nsfont_draw): Remove unused variable cs.
2657
2658 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2659 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2660 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2661 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2662 (Fns_font_name, Fns_perform_service)
2663 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2664 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2665 (ns_set_name): Remove unused variable view.
2666 (x_set_menu_bar_lines): Remove unused variable olines.
2667 (x_set_tool_bar_lines): Remove unused variable root_window.
2668 (Fns_list_colors): Put () around assignment in while statement.
2669 (Fns_perform_service): Remove unused variable len.
2670 (Fns_display_usable_bounds): Remove unused variable top.
2671 (syms_of_nsfns): Remove unused variable i.
2672
b55b9f85
JD
2673 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2674 memcpy (Bug#11907).
2675
ed9265fc 26762012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2677
2678 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2679 and free it with DestroyExceptionInfo (Bug#11558).
2680
ef099b57
JB
26812012-07-13 Juanma Barranquero <lekktu@gmail.com>
2682
2683 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2684 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2685 Set here, not in nt/config.nt.
2686
ea814a5d
EZ
26872012-07-13 Eli Zaretskii <eliz@gnu.org>
2688
2689 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2690 cursor overflow into the last glyph on display line when the right
2691 fringe is off. (Bug#11832)
2692
1a952767
PE
26932012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2694
2695 * xdisp.c (produce_special_glyphs): Now static.
2696 * dispextern.h (produce_special_glyphs): Remove decl.
2697
983188fd
GM
26982012-07-13 Glenn Morris <rgm@gnu.org>
2699
8d7c7eed 2700 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2701 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2702
983188fd
GM
2703 * s/usg5-4-common.h (USG, USG5):
2704 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2705 * s/sol2-6.h (SOLARIS2):
2706 * s/irix6-5.h (IRIX6_5):
2707 * s/hpux10-20.h (USG, USG5, HPUX):
2708 * s/gnu-linux.h (USG, GNU_LINUX):
2709 * s/freebsd.h (BSD_SYSTEM):
2710 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2711 * s/cygwin.h (CYGWIN):
2712 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2713 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2714
d1e68667 27152012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2716
2717 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2718
6de0e799
GM
27192012-07-13 Glenn Morris <rgm@gnu.org>
2720
739ae010
GM
2721 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2722
dbee5793
GM
2723 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2724
6de0e799
GM
2725 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2726 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2727
b82da769
GM
27282012-07-12 Glenn Morris <rgm@gnu.org>
2729
4fae5a7a 2730 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2731
2732 * process.c (init_process_emacs): Rename from init_process.
2733 The old name is also the name of a Mach system call.
2734 * lisp.h, emacs.c: Update for this name change.
2735 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2736 longer needed.
2737
5a979817
EZ
27382012-07-12 Eli Zaretskii <eliz@gnu.org>
2739
2740 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2741 memmove call that removes glyphs covered by the left truncation
2742 glyph. Improve commentary.
2743 (display_line): Fix display of continuation glyphs on GUI frames
2744 when the right fringe is turned off and variable-size fonts are
2745 used in the window. Move the code that appends a stretch glyph to
2746 produce_special_glyphs, so that it could be used for truncation
2747 and continuation glyphs alike.
2748 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2749 glyph of a suitably computed width, to align the special glyphs at
2750 the window margin. Code moved from display_line. (Bug#11832)
2751
3e91a053
GM
27522012-07-12 Glenn Morris <rgm@gnu.org>
2753
ba9e4b84
GM
2754 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2755
2756 * s/gnu-linux.h, s/hpux10-20.h:
2757 Do not unconditionally define HAVE_XRMSETDATABASE.
2758
3e91a053
GM
2759 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2760
b300b1f4
PE
27612012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2762
2763 Fix typos that broke OS X build.
2764 Reported by Randal L. Schwartz in
2765 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2766 * nsterm.m (ns_timeout): Add missing local decl.
2767 (ns_get_color): snprintf -> sprintf, to fix typo.
2768
6e777848
GM
27692012-07-12 Glenn Morris <rgm@gnu.org>
2770
3f922c37
GM
2771 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2772 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2773 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2774 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2775
0ab7b23a
GM
2776 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2777 Move PTY_OPEN to configure.
2778
6e777848
GM
2779 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2780 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2781 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2782
4a7edc24
DA
27832012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2784
2785 Use empty_unibyte_string where applicable.
2786 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2787 * lread.c (read1): Likewise.
2788 * xsettings.c (syms_of_xsettings): Likewise.
2789
308aab79
GM
27902012-07-12 Glenn Morris <rgm@gnu.org>
2791
42bd1719
GM
2792 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2793 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2794 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2795 * s/hpux10-20.h (RUN_TIME_REMAP):
2796 * s/bsd-common.h (TABDLY): Move to configure.
2797
2798 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2799
2800 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2801
ea0bbd17 2802 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2803 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2804
2805 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2806
308aab79
GM
2807 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2808 * s/template.h: Move NARROWPROTO to configure.
2809
ee1cf5cf
GM
28102012-07-11 Glenn Morris <rgm@gnu.org>
2811
30fe9bf4
GM
2812 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2813 unused since 2011-01-17 change to systty.h.
2814
ee1cf5cf
GM
2815 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2816 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2817 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2818
63e47e07
PE
28192012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2820
2821 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2822
c43fb4c3
GM
28232012-07-11 Glenn Morris <rgm@gnu.org>
2824
2825 * s/darwin.h, s/gnu-linux.h, s/template.h:
2826 Move INTERRUPT_INPUT to configure.
2827
e8df9267
DA
28282012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2829
2830 Minor adjustments to interning code.
2831 * lisp.h (intern, intern_c_string): Redefine as static inline
2832 wrappers for intern_1 and intern_c_string_1, respectively.
2833 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2834 * lread.c (intern_1, intern_c_string_1, oblookup):
2835 Simplify Vobarray checking.
e8df9267
DA
2836 * font.c (font_intern_prop): Likewise. Adjust comment.
2837 * w32font.c (intern_font_name): Likewise.
2838
34348bd4
AS
28392012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2840
d96a1e0c
AS
2841 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2842
34348bd4
AS
2843 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2844 of Fcar/Fcdr if possible.
2845 * font.c (check_otf_features): Likewise.
2846 * fontset.c (Fnew_fontset): Likewise.
2847 * gnutls.c (Fgnutls_boot): Likewise.
2848 * minibuf.c (read_minibuf): Likewise.
2849 * msdos.c (IT_set_frame_parameters): Likewise.
2850 * xmenu.c (Fx_popup_dialog): Likewise.
2851 * w32menu.c (Fx_popup_dialog): Likewise.
2852
c8add24e
GM
28532012-07-11 Glenn Morris <rgm@gnu.org>
2854
4b575b3c
GM
2855 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2856 since nothing has defined it on these platforms.
2857
09f4e3b0
GM
2858 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2859 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2860
172bedef
GM
2861 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2862 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2863 Move CLASH_DETECTION to configure.
2864
249685df
GM
2865 * s/gnu.h: Remove file, which is now empty.
2866
c8add24e
GM
2867 * s/gnu.h, s/gnu-linux.h:
2868 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2869
b41253a3
JW
28702012-07-11 John Wiegley <johnw@newartisans.com>
2871
2872 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2873 function attribute, so we only use it if it exists in the
2874 compiler.
2875
d923b542
DA
28762012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2877
2878 Avoid call to strlen in fast_c_string_match_ignore_case.
2879 * search.c (fast_c_string_match_ignore_case): Change to use
2880 length argument. Adjust users accordingly.
2881 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2882
5ebbef1d
PE
28832012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2884
bb352260
PE
2885 Assume mkdir, rmdir.
2886 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2887 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2888
57054ddd
PE
2889 Assume rename.
2890 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2891
b747d3f7
PE
2892 Assume perror.
2893 * s/hpux10-20.h (HAVE_PERROR): Remove.
2894 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2895 Remove dummy definition, as this problem was obsolete long ago.
2896
5ebbef1d
PE
2897 Assume strerror.
2898 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2899
984e7f30
DA
29002012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2901
2902 Avoid calls to strlen in font processing functions.
2903 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2904 (font_open_by_name): Change to use length argument.
2905 Adjust users accordingly.
d923b542
DA
2906 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2907 Adjust prototypes.
2908 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2909 Change to return ptrdiff_t.
984e7f30
DA
2910 (xfont_list_pattern, xfont_match): Use length returned by
2911 xfont_decode_coding_xlfd.
2912 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2913
20e94fdd
GM
29142012-07-11 Glenn Morris <rgm@gnu.org>
2915
9d596af3
GM
2916 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2917 Move DONT_REOPEN_PTY to configure.
2918
20e94fdd
GM
2919 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2920 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2921
e99a530f
PE
29222012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2923
22ffb973
PE
2924 Remove "#define unix" that is no longer needed (Bug#11905).
2925 * s/aix4-2.h (unix): Remove; no longer needed.
2926
e9a9ae03
PE
2927 EMACS_TIME simplification (Bug#11875).
2928 This replaces macros (which typically do not work in GDB)
2929 with functions, typedefs and enums, making the code easier to debug.
2930 The functional style also makes code easier to read and maintain.
2931 * systime.h: Include <sys/time.h> on all hosts, not just if
2932 WINDOWSNT, since 'struct timeval' is needed in general.
2933 (EMACS_TIME): Now a typedef, not a macro.
2934 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2935 not macros.
2936 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2937 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2938 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2939 (EMACS_TIME_LE): Now functions, not macros.
2940 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2941 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2942 which are not functions. All uses rewritten to use:
2943 (make_emacs_time): New function.
2944 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2945 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2946 not functions. All uses rewritten to use the following, respectively:
2947 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2948 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2949 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2950 * fileio.c (Fcopy_file):
2951 * xterm.c (XTflash): Get the current time closer to when it's used.
2952 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2953
ffacb126
PE
2954 * bytecode.c (targets): Suppress -Woverride-init warnings.
2955
e99a530f
PE
2956 Simplify by avoiding confusing use of strncpy etc.
2957 * doc.c (Fsnarf_documentation):
2958 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2959 * frame.c (Fmake_terminal_frame):
2960 * gtkutil.c (get_utf8_string):
2961 * lread.c (openp):
2962 * nsmenu.m (ns_update_menubar):
2963 * regex.c (regerror):
2964 Prefer memcpy to strncpy and strncat when either will do.
2965 * fileio.c (Fsubstitute_in_file_name):
2966 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2967 (menu_separator_name_p):
2968 * nsmenu.m (ns_update_menubar):
2969 Prefer memcmp to strncmp when either will do.
2970 * nsterm.m: Include <ftoastr.h>.
2971 (ns_get_color):
2972 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2973 Prefer snprintf to strncpy.
2974 * nsterm.m (ns_term_init):
2975 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2976 * nsterm.m (ns_term_init):
2977 Avoid the need for strncpy, by using build_string or
2978 make_unibyte_string directly. Use dtoastr, not snprintf.
2979 * process.c (Fmake_network_process): Diagnose service names that
2980 are too long, rather than silently truncating them or creating
2981 non-null-terminated names.
2982 (Fnetwork_interface_info): Likewise, for interface names.
2983 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2984 Prefer sprintf to strncat.
2985 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2986 Prefer vsnprintf to vsprintf + strncpy.
2987
c59592b3
GM
29882012-07-10 Glenn Morris <rgm@gnu.org>
2989
2990 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2991 Clarify fallback case.
2992
7d7bbefd
DA
29932012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2994
2995 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2996 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2997 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2998 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2999 where argument type is known to be a Lisp_Cons.
3000
3a4c8000
TT
30012012-07-10 Tom Tromey <tromey@redhat.com>
3002
3003 * bytecode.c (BYTE_CODE_THREADED): New macro.
3004 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3005 (enum byte_code_op): New type.
3006 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3007 (exec_byte_code): Use them. Use token threading when applicable.
3008
2a0213a6
DA
30092012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3010
3011 Optimize pure C strings initialization.
3012 * lisp.h (make_pure_string): Fix prototype.
3013 (build_pure_c_string): New function, defined as static inline. This
3014 provides a better opportunity to optimize away calls to strlen when
3015 the function is called with compile-time constant argument.
3016 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3017 argument, adjust users accordingly. Use build_pure_c_string where
3018 appropriate.
3019 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3020 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3021 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3022
cb1caeaf
DA
30232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3024
3025 Avoid calls to strlen in miscellaneous functions.
3026 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3027 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3028 * lread.c (openp): Likewise.
3029
c293e30c
DA
30302012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3031
3032 Avoid calls to strlen in path processing functions.
3033 * fileio.c (file_name_as_directory): Add comment. Change to add
3034 srclen argument and return the length of result. Adjust users
3035 accordingly.
3036 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3037 swap 1st and 2nd arguments to obey the common convention.
3038 Adjust users accordingly.
c293e30c
DA
3039 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3040
9e059e3f
GM
30412012-07-10 Glenn Morris <rgm@gnu.org>
3042
d02eb359
GM
3043 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3044 Move PENDING_OUTPUT_COUNT definition to configure.
3045
882cf227
GM
3046 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3047 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3048 * s/gnu.h (DATA_START): Move definitions to configure.
3049
af6e839f
GM
3050 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3051 We include usg5-4-common.h, which defines them both.
3052
40289a12
GM
3053 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3054 O_RDONLY already includes it).
3055
9e059e3f
GM
3056 Stop ns builds setting the EMACSLOADPATH environment variable.
3057 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3058 Now it does not set EMACSLOADPATH, just returns the load-path string.
3059 * nsterm.h: Update accordingly.
3060 * lread.c [HAVE_NS]: Include nsterm.h.
3061 (init_lread) [HAVE_NS]: Use ns_load_path.
3062 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3063
7c4e8ec0
GM
30642012-07-09 Glenn Morris <rgm@gnu.org>
3065
d4f600ff
GM
3066 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3067 since the included bsd-common.h does so.
3068
cbb31951
GM
3069 Stop ns builds setting the EMACSPATH environment variable.
3070 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3071 (ns_init_paths): Do not set EMACSPATH.
3072 * nsterm.h (ns_exec_path): Add it.
3073 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3074 Use ns_exec_path.
3075
7c4e8ec0
GM
3076 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3077
26bccfae
PE
30782012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3079
a0bee46f
PE
3080 * process.c (wait_reading_process_output): 'waitchannels' was unset
3081 when read_kbd || !NILP (wait_for_cell); fix this.
3082
5994c183
PE
3083 Add GCC-style 'const' attribute to functions that can use it.
3084 * character.h (char_resolve_modifier_mask):
3085 * keyboard.h (make_ctrl_char):
3086 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3087 (init_character_once, next_almost_prime, init_fns, init_image)
3088 (flush_pending_output, init_sound):
3089 * mem-limits.h (start_of_data):
3090 * menu.h (finish_menu_items):
3091 Add ATTRIBUTE_CONST.
3092 * emacs.c (DEFINE_DUMMY_FUNCTION):
3093 Declare the dummy function with ATTRIBUTE_CONST.
3094 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3095 Add decls with ATTRIBUTE_CONST.
3096
26bccfae
PE
3097 Minor improvements to make_formatted_string.
3098 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3099 where int is good enough, as vsprintf returns an int.
3100 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3101
a8290ec3
DA
31022012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3103
3104 Use make_formatted_string to avoid double length calculation.
3105 * lisp.h (make_formatted_string): New prototype.
3106 * alloc.c (make_formatted_string): New function.
3107 * buffer.c (Fgenerate_new_buffer_name): Use it.
3108 * dbus.c (syms_of_dbusbind): Likewise.
3109 * editfns.c (Fcurrent_time_zone): Likewise.
3110 * filelock.c (get_boot_time): Likewise.
3111 * frame.c (make_terminal_frame, set_term_frame_name)
3112 (x_report_frame_params): Likewise.
3113 * image.c (gs_load): Likewise.
3114 * minibuf.c (get_minibuffer): Likewise.
3115 * msdos.c (dos_set_window_size): Likewise.
3116 * process.c (make_process): Likewise.
3117 * xdisp.c (ensure_echo_area_buffers): Likewise.
3118 * xsettings.c (apply_xft_settings): Likewise.
3119
d01ba2f1
GM
31202012-07-09 Glenn Morris <rgm@gnu.org>
3121
3122 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3123 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3124 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3125 * nsterm.h (ns_etc_directory): Add it.
3126 * callproc.c [HAVE_NS]: Include nsterm.h.
3127 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3128
f1f924b6
DA
31292012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3130
3131 Move marker debugging code under MARKER_DEBUG.
3132 * marker.c (MARKER_DEBUG): Move marker debugging code under
3133 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3134 for bootstrap with --enable-checking (~3x slowdown reported
3135 by Juanma Barranquero <lekktu@gmail.com>).
3136 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3137
ab531b66
PE
31382012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3141 See <http://bugs.gnu.org/11825#29>.
3142
c4b3bc8a
EZ
31432012-07-08 Eli Zaretskii <eliz@gnu.org>
3144
3145 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3146 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3147 (display_line): Add commentary about displaying truncation glyphs
3148 on GUI frames.
3149 (produce_special_glyphs): Move here from term.c.
3150
3151 * term.c (produce_special_glyphs): Move to xdisp.c.
3152
3153 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3154 section.
c4b3bc8a 3155
b676b881
AS
31562012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3157
f17c5273
AS
3158 * xdisp.c (display_line): Avoid warning about implicit declaration
3159 of FRAME_FONT.
3160
298819b9
AS
3161 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3162
b676b881
AS
3163 * lisp.h: Remove empty conditional.
3164
6045c4fd
PE
31652012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3166
b3350bf9
PE
3167 * lread.c (load_path_check): Now static.
3168
6045c4fd
PE
3169 Fix some minor --with-ns problems found by static checking.
3170 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3171 (x_set_font) [!HAVE_X_WINDOWS]:
3172 * image.c (xpm_load_image) [HAVE_NS]:
3173 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3174 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3175 Remove unused local.
3176 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3177 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3178 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3179 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3180 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3181 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3182 Fix pointer signedness problem.
3183 * xfaces.c (FRAME_X_FONT_TABLE):
3184 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3185
929e7845
GM
31862012-07-07 Glenn Morris <rgm@gnu.org>
3187
3188 * lread.c (load_path_check): New function, split from init_lread.
3189 (init_lread): Reorganize. Motivation:
3190 If EMACSLOADPATH is set, check/warn about that rather than the
3191 defaults, which we are not going to use. Hence we can remove
3192 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3193 Don't warn if site-lisp directories are missing.
3194 If not installed, start from a blank load-path, since
3195 PATH_LOADSEARCH refers to the eventual installation directories.
3196
58dd0aa4
EZ
31972012-07-07 Eli Zaretskii <eliz@gnu.org>
3198
3199 Support truncation and continuation glyphs on GUI frames, when
3200 fringes are disabled. (Bug#11832)
3201 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3202 continuation glyphs even if on GUI frames.
3203 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3204 or both, are absent.
3205 (start_display, move_it_in_display_line_to): Handle the case of a
3206 GUI frame without a fringe to display continuation or truncation
3207 glyphs.
3208 (insert_left_trunc_glyphs): Support GUI frames: make sure
3209 truncation glyphs overwrite enough glyphs from the current line to
3210 have sufficient space in pixels.
3211 (display_line): Support truncation and continuation glyphs on GUI
3212 frames. If some spare pixels are left on the line after inserting
3213 the truncation glyphs, fill that space with a stretch glyph of a
3214 suitably computed width.
3215
3216 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
3217 produce_glyphs, to support GUI sessions.
3218
31571fd7
PE
32192012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3220
5a16b9bc
PE
3221 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
3222
f3047c75
PE
3223 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
3224
31571fd7
PE
3225 Do not require float-time's arg to fit in time_t (Bug#11825).
3226 This works better on hosts where time_t is unsigned, and where
3227 float-time is applied to the (negative) difference between two times.
3228 * editfns.c (decode_time_components): Last arg is now double *,
3229 not int *, and means to store all the result as a double, without
3230 worrying about whether the seconds part fits in time_t.
3231 All callers changed.
3232 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
3233 All callers changed.
3234 (Ffloat_time): Do not fail merely because the specified time falls
3235 outside of time_t range.
3236
4516fbef
GM
32372012-07-07 Glenn Morris <rgm@gnu.org>
3238
3239 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
3240 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
3241 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
3242
07adc2c6
JB
32432012-07-07 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
3246 Update dependencies.
3247
3248 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
3249
fd573f31
PE
32502012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3251
fee5959d
PE
3252 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
3253 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
3254 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
3255 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
3256 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
3257 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
3258
fd573f31
PE
3259 * xfont.c (compare_font_names): Redo to omit the need for casts.
3260
ddadbc0e
AS
32612012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3262
fca8d6b6
AS
3263 * xfns.c (Fx_change_window_property): Doc fix.
3264 * w32fns.c (Fx_change_window_property): Doc fix.
3265
ddadbc0e
AS
3266 * w32fns.c (Fx_window_property): Accept the same arguments as the
3267 X Windows version. Doc fix.
3268 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
3269
ed9265fc 32702012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
3271 Eli Zaretskii <eliz@gnu.org>
3272
3273 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
3274 Windows-specific code from nt/config.nt moved here.
3275 Obsolete settings removed.
3276
216ee680
PE
32772012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 * process.c: Avoid unnecessary calls to gettime.
3280 (wait_reading_process_output): Don't get the time of day
3281 when gobbling data immediately and not waiting, as there's no need
3282 for it in that case. This removes a FIXME.
3283
bdd091e4
JD
32842012-07-06 Jan Djärv <jan.h.d@swipnet.se>
3285
3286 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
3287 is defined (Bug#11768).
3288
9d44f8ce
DA
32892012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3290
3291 Fix marker debugging code.
3292 * marker.c (byte_char_debug_check): Do not perform the check
3293 if buffer is not multibyte.
090bd7cb
JB
3294 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3295 Call byte_char_debug_check with correct arguments.
9d44f8ce 3296
90fc4786
DA
32972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3298
3299 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
3300 * marker.c (byte_char_debug_check, count_markers):
3301 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
3302 (byte_debug_flag): Remove.
3303 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3304 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
3305
7b7ae965
DA
33062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3307
4e57b342
DA
3308 Avoid code repetition in marker-related functions.
3309 * marker.c (attach_marker): New function.
3310 (Fset_marker, set_marker_restricted, set_marker_both)
3311 (set_marker_restricted_both): Use it.
3312 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
3313 Consistently rename charno to charpos.
3314 (marker_position): Add eassert.
3315 (marker_byte_position): Convert to eassert.
3316
33172012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3318
3319 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 3320 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 3321 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 3322
657924ff
DA
33232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3324
3325 Introduce fast path for the widely used marker operation.
3326 * alloc.c (build_marker): New function.
3327 * lisp.h (build_marker): New prototype.
3328 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
3329 * composite.c (autocmp_chars): Likewise.
3330 * editfns.c (buildmark): Remove.
3331 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
3332 (save_restriction_save): Use build_marker.
3333 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
3334 * window.c (save_window_save): Likewise.
3335
041a49a6
DA
33362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3337
3338 Do not use Fdelete_overlay in delete_all_overlays
3339 to avoid redundant calls to unchain_overlay.
3340 * buffer.c (drop_overlay): New function.
3341 (delete_all_overlays, Fdelete_overlay): Use it.
3342 * minibuf.c (get_minibuffer): Fix comment.
3343
7dca65a4
PE
33442012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3345
3346 Port to OpenBSD 5.1 amd64.
3347 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
3348 This is needed for OpenBSD, and should be harmless on all BSD systems.
3349 Also, include <sys/sysctl.h>, as it should be available on all
3350 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
3351 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
3352 use p_pid member, not kp_proc.pid.
3353
8eb876e2
GM
33542012-07-06 Glenn Morris <rgm@gnu.org>
3355
3356 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
3357
38182d90
PE
33582012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3359
3360 More xmalloc and related cleanup.
3361 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
3362 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
3363 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
3364 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
3365 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
3366 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
3367 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
3368 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
3369 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
3370 * xterm.c:
3371 Omit needless casts involving void * pointers and allocation.
3372 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
3373 as the former is more robust if P's type is changed.
3374 Prefer xzalloc to xmalloc + memset 0.
3375 Simplify malloc-or-realloc to realloc.
3376 Don't worry about xmalloc returning a null pointer.
3377 Prefer xstrdup to xmalloc + strcpy.
3378 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
3379 growing it.
3380 * keyboard.c (apply_modifiers_uncached): Prefer local array to
3381 alloca of a constant.
3382
6dd5a677
EZ
33832012-07-05 Eli Zaretskii <eliz@gnu.org>
3384
3385 * xdisp.c (display_line): Fix horizontal pixel coordinates when
3386 hscroll is larger than the line width. Fixes long and futile
3387 looping inside extend_face_to_end_of_line (on a TTY) producing
3388 glyphs that are not needed and thrown away.
3389
6b312f0f
DA
33902012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3391
3392 * marker.c (set_marker_restricted_both): Simplify by using
3393 clip_to_bounds.
3394
f520ef9b
PE
33952012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 * editfns.c (region_limit): Simplify by using clip_to_bounds.
3398
383b7c95
JD
33992012-07-05 Jan Djärv <jan.h.d@swipnet.se>
3400
3401 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
3402 not defined (Bug#11768).
3403 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
3404 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
3405 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
3406 followed by gtk_box_set_homogeneous (Bug#11768).
3407 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
3408 (update_theme_scrollbar_width, xg_create_scroll_bar):
3409 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
3410 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
3411 (is_box_type): New function (Bug#11768).
3412 (xg_tool_item_stale_p): Call is_box_type.
5293d758 3413 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
3414 with default display (Bug#11768).
3415
d6e7bf45
EZ
34162012-07-05 Eli Zaretskii <eliz@gnu.org>
3417
3418 * xdisp.c (window_hscroll_limited): New function.
3419 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
3420 coordinates when window's hscroll is set to insanely large
3421 values. (Bug#11857)
3422
431391ec
JB
34232012-07-05 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
3426 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
3427
23f86fce
DA
34282012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3429
3430 Cleanup xmalloc.
3431 * lisp.h (xzalloc): New prototype. Omit needless casts.
3432 * alloc.c (xzalloc): New function. Omit needless casts.
3433 * charset.c: Omit needless casts. Convert all calls to
3434 xmalloc with following memset to xzalloc.
3435 * dispnew.c: Likewise.
3436 * fringe.c: Likewise.
3437 * image.c: Likewise.
3438 * sound.c: Likewise.
3439 * term.c: Likewise.
3440 * w32fns.c: Likewise.
3441 * w32font.c: Likewise.
3442 * w32term.c: Likewise.
3443 * xfaces.c: Likewise.
3444 * xfns.c: Likewise.
3445 * xterm.c: Likewise.
3446 * atimer.c: Omit needless casts.
3447 * buffer.c: Likewise.
3448 * callproc.c: Likewise.
3449 * ccl.c: Likewise.
3450 * coding.c: Likewise.
3451 * composite.c: Likewise.
3452 * doc.c: Likewise.
3453 * doprnt.c: Likewise.
3454 * editfns.c: Likewise.
3455 * emacs.c: Likewise.
3456 * eval.c: Likewise.
3457 * filelock.c: Likewise.
3458 * fns.c: Likewise.
3459 * gtkutil.c: Likewise.
3460 * keyboard.c: Likewise.
3461 * lisp.h: Likewise.
3462 * lread.c: Likewise.
3463 * minibuf.c: Likewise.
3464 * msdos.c: Likewise.
3465 * print.c: Likewise.
3466 * process.c: Likewise.
3467 * region-cache.c: Likewise.
3468 * search.c: Likewise.
3469 * sysdep.c: Likewise.
3470 * termcap.c: Likewise.
3471 * terminal.c: Likewise.
3472 * tparam.c: Likewise.
3473 * w16select.c: Likewise.
3474 * w32.c: Likewise.
3475 * w32reg.c: Likewise.
3476 * w32select.c: Likewise.
3477 * w32uniscribe.c: Likewise.
3478 * widget.c: Likewise.
3479 * xdisp.c: Likewise.
3480 * xmenu.c: Likewise.
3481 * xrdb.c: Likewise.
3482 * xselect.c: Likewise.
3483
0497dc44
PE
34842012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3485
3486 * fileio.c (time_error_value): Check the right error number.
3487 Problem reported by Troels Nielsen in
3488 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3489
356e7178
PE
34902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3491
4e71fd89
PE
3492 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3493 This should be fixed in a better way; see Eli Zaretskii in
3494 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3495 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3496
f0941253
PE
3497 * fileio.c (time_error_value): Rename from special_mtime.
3498 The old name's problems were noted by Eli Zaretskii in
3499 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3500
065c9eb4
PE
3501 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3502 This variable's comment says Emacs needs at least one GDB-visible
3503 symbol of type enum pvec_type, to work around GDB problems.
3504 The symbol's value doesn't matter.
3505
356e7178
PE
3506 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3507 that causes compilation to fail on pre-C99 compilers.
3508
ed9265fc 35092012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3510
3511 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3512 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3513
3884d954
DA
35142012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3515
d209e2fb 3516 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3517 headers for buffer_defaults and buffer_local_symbols.
3518 Reported by Juanma Barranquero <lekktu@gmail.com>.
3519
ee28be33
SM
35202012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3523 * lisp.h (enum pvec_type): Use fewer bits.
3524 (PSEUDOVECTOR_SIZE_BITS): New constant.
3525 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3526 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3527 change in pvec_type.
3528 (PSEUDOVECTOR_TYPEP): New macro.
3529 (TYPED_PSEUDOVECTORP): Use it.
3530 * fns.c (internal_equal): Adapt code to extract pvectype.
3531 * emacs.c (gdb_pvec_type): Update type.
3532 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3533 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3534 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3535 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3536 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3537 abusing vector->header.next.nbytes.
3538 (live_vector_p): Use PVEC_TYPE.
3539 (mark_object): Adapt code to extract pvectype. Use switch.
3540
c7f2cd7f
PE
35412012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3544 Tighten new eassert a bit.
3545
8ce70ed2
DA
35462012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3547
3548 Fix compilation with --enable-gcc-warnings and -O1
3549 optimization level.
3550 * doprnt.c (doprnt): Change type of tem to int, initialize
3551 to avoid compiler warning. Add eassert.
3552 * search.c (simple_search): Initialize match_byte to avoid
3553 compiler warning. Add eassert.
3554
dea7f1e5
PE
35552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3556
24a212eb
PE
3557 Avoid weird behavior with large horizontal scrolls.
3558 Without this change, for example, large hscroll values would
3559 mess up Emacs's display on Fedora 15 x86, presumably due to
3560 overflows in int calculations in the display code.
3561 Also, if buffers had long lines, Emacs would freeze.
3562 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3563 (set_window_hscroll): New function, containing the old guts of
3564 Fset_window_hscroll. Return the clipped value.
3565 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3566 This avoids the need to check against PTRDIFF_MAX.
3567
dea7f1e5
PE
3568 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3569
76046526
DA
35702012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3571
3572 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3573
39adff0d
PE
35742012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3575
63807d47
PE
3576 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3577 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3578 since GCC 4.4.6 issues a bogus warning for them.
3579
39adff0d
PE
3580 Fix bugs in file timestamp newness comparisons.
3581 * fileio.c (Ffile_newer_than_file_p):
3582 * lread.c (Fload): Use full timestamp resolution of files,
3583 not just the 1-second resolution, so that files that are only
3584 slightly newer still count as newer.
3585 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3586 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3587
dbeed9a6
PE
35882012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3589
3590 * fileio.c: Improve handling of file time marker. (Bug#11852)
3591 (special_mtime): New function.
3592 (Finsert_file_contents, Fverify_visited_file_modtime):
3593 Use it to set special mtime values consistently.
3594
636334d6
AS
35952012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3596
3597 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3598 marker for non-existing file. (Bug#11852)
3599
e2017fe2
GM
36002012-07-03 Glenn Morris <rgm@gnu.org>
3601
3602 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3603 and did not make it into globals.h).
3604
404dbd37
TT
36052012-07-03 Tom Tromey <tromey@redhat.com>
3606
3607 * window.c (Fset_window_margins, Fset_window_fringes)
3608 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3609 * textprop.c (Fprevious_property_change): No longer static.
3610 * syntax.c (Fsyntax_table_p): No longer static.
3611 * process.c (Fget_process, Fprocess_datagram_address): No longer
3612 static.
3613 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3614 * keyboard.c (Fcommand_execute): No longer static.
3615 Remove EXFUN.
3616 * insdel.c (Fcombine_after_change_execute): No longer static.
3617 * image.c (Finit_image_library): No longer static.
3618 * fileio.c (Fmake_symbolic_link): No longer static.
3619 * eval.c (Ffetch_bytecode): No longer static.
3620 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3621 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3622 No longer static.
404dbd37
TT
3623 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3624 static.
3625 * dired.c (Ffile_attributes): No longer static.
3626 * composite.c (Fcomposition_get_gstring): No longer static.
3627 * callproc.c (Fgetenv_internal): No longer static.
3628
3629 * ccl.h: Remove EXFUNs.
3630 * buffer.h: Remove EXFUNs.
3631 * dispextern.h: Remove EXFUNs.
3632 * intervals.h: Remove EXFUNs.
3633 * fontset.h: Remove EXFUN.
3634 * font.h: Remove EXFUNs.
3635 * dosfns.c (system_process_attributes): Remove EXFUN.
3636 * keymap.h: Remove EXFUNs.
3637 * lisp.h: Remove EXFUNs.
3638 * w32term.h: Remove EXFUNs.
3639 * window.h: Remove EXFUNs.
3640 * xsettings.h: Remove EXFUN.
3641 * xterm.h: Remove EXFUN.
3642
8e4fd1e1
GM
36432012-07-03 Glenn Morris <rgm@gnu.org>
3644
3645 * lisp.h (Frandom): Make it visible to C.
3646 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3647 buffer for invisible buffers. (Bug#1229)
3648
ca95b3eb
DA
36492012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3650
3651 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3652 values which aren't power of 2.
14ae4239
BT
3653 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3654 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3655 accordingly.
3656
7555c33f
SM
36572012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3658
3659 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3660
3661 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3662
d12e8f5a
DA
36632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3664
3665 * alloc.c (allocate_vector_block): Remove redundant
3666 calls to mallopt if DOUG_LEA_MALLOC is defined.
3667 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3668 avoid calls to mallopt if zero_vector is returned.
3669
296094c3
DA
36702012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3671
3672 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3673 is enabled, avoid dereferencing NULL current_sblock if
3674 running undumped.
3675
36429c89
DA
36762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3677
3678 Cleanup basic buffer management.
3679 * buffer.h (struct buffer): Change layout to use generic vector
3680 marking code. Fix some comments. Change type of 'clip_changed'
3681 to bitfield. Remove unused #ifndef old.
3682 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3683 (GET_OVERLAYS_AT): Fix indentation.
3684 (for_each_per_buffer_object_at): New macro.
3685 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3686 (Fbuffer_local_variables): Use it.
3687 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3688 * alloc.c (allocate_buffer): Adjust to match new layout of
3689 struct buffer. Fix comment.
3690 (mark_overlay): New function.
3691 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3692 Lisp area of struct buffer.
3693 (mark_object): Use it. Adjust marking of misc objects
3694 and related comments.
3695
3b3e4cac
PE
36962012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3697
3698 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3699 wrapper that is not needed because the wrapped code is a no-op (zero
3700 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3701 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3702
cf5c0175
DA
37032012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3704
3705 * alloc.c (mark_buffer): Simplify. Remove prototype.
3706 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3707 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3708 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3709 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3710
ca26824c
GM
37112012-06-30 Glenn Morris <rgm@gnu.org>
3712
2e4c5312
GM
3713 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3714
ca26824c
GM
3715 * epaths.in (PATH_SITELOADSEARCH): New.
3716 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3717 This is rather than relying on --enable-locallisppath elements
3718 having "site-lisp" in their names. (Bug#10208#25, 11658)
3719
0d23c240
EZ
37202012-06-30 Eli Zaretskii <eliz@gnu.org>
3721
c9240d7a
EZ
3722 * w32proc.c (sys_select): Accept and ignore one more argument.
3723
3724 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3725
0d23c240 3726 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3727 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3728
3729 * sysdep.c: Don't include dos.h and dosfns.h.
3730
3731 * process.c (sys_select):
3732 * msdos.c (sys_select): Accept one more argument and ignore it.
3733
3734 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3735 adapt data types and code to that.
3736
3737 * dosfns.c:
3738 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3739 which clashes with the gnulib function of the same name.
3740
af5a5a98
AS
37412012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3742
c5e4379c
AS
3743 * font.c (font_style_to_value, font_style_symbolic)
3744 (font_prop_validate_style): Add type checks for values in
3745 font_style_table.
3746
af5a5a98
AS
3747 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3748 argument.
3749 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3750 uses.
3751
8d38f461
EZ
37522012-06-29 Eli Zaretskii <eliz@gnu.org>
3753
2e5a6631
EZ
3754 * xdisp.c (try_window_id): Undo last change.
3755
8d38f461
EZ
3756 * w32.c (getwd): Adjust commentary about startup_dir.
3757 (init_environment): Always call sys_access, even in non-MSVC
3758 builds. Don't chdir to the directory of the Emacs executable.
3759 This undoes code from 1997 which was justified by the need to
3760 "avoid conflicts when removing and renaming directories". But its
3761 downside was that every relative file name was being interpreted
3762 relative to the directory of the Emacs executable, which can never
3763 be TRT. In particular, it broke sys_access when called with
3764 relative file names.
3765 (sys_access): Map GetLastError to errno.
3766
2af3565e
DA
37672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3768
3769 * window.h (struct window): Change type of 'fringes_outside_margins'
3770 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3771 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3772 Adjust comment.
3773 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3774 to ptrdiff_t.
3775
c8d3a25c 37762012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3777
c8d3a25c
GM
3778 * gnutls.c (emacs_gnutls_handshake):
3779 Add QUIT to make the loop interruptible.
57570cd3 3780
c8d3a25c 37812012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3782
c8d3a25c
GM
3783 * charset.c (init_charset): Make lack of etc/charsets fatal.
3784
3e984ee8
DA
37852012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3786
3787 * editfns.c (region_limit): Fix type mismatch.
3788
ef884f23
DA
37892012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3790
3791 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3792 undefined. Convert from xassert to eassert.
3793 * nsmenu.m: Convert from xassert to eassert.
3794 * nsterm.m: Likewise.
3795
7d7e0027
SM
37962012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3797
3798 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3799
aa754e6a
PE
38002012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3801
3802 Avoid integer overflow on scroll-left and scroll-right.
3803 * window.c (HSCROLL_MAX): New macro.
3804 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3805 overflow when requested scroll falls outside ptrdiff_t range.
3806
80b00b08
DA
38072012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3808
3809 * window.h (struct window): Change type of 'hscroll',
3810 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3811 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3812 Adjust users accordingly.
3813 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3814 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3815 from EMACS_INT to ptrdiff_t.
3816 (make_window): Omit redundant initialization.
3817
62b2bcf6
JB
38182012-06-28 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3821
45942c7d
DA
38222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3823
3824 * window.h (struct window): Change type of 'use_time' and
3825 'sequence_number' from Lisp_Object to int.
3826 * frame.c (make_frame): Adjust users accordingly.
3827 * print.c (print_object): Likewise.
3828 * window.c (select_window, Fwindow_use_time, make_parent_window)
3829 (make_window): Likewise.
3830
e509cfa6
DA
38312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3832
3833 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3834 enabled with --enable-checking=[all,glyphs] configure option.
3835 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3836 adjust comments accordingly.
3837 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3838 undefined, adjust comments accordingly.
3839 * image.c: Likewise.
3840 * scroll.c: Likewise.
3841 * w32fns.c: Likewise.
3842 * w32term.c: Likewise.
3843 * xdisp.c: Likewise.
3844 * xfaces.c: Likewise.
3845 * xfns.c: Likewise.
3846 * xterm.c: Likewise.
3847
a54e2c05
DA
38482012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3849
3850 Generalize run-time debugging checks.
3851 * dispextern.h (XASSERTS): Remove.
3852 * fontset.c (xassert): Remove.
3853 Convert from xassert to eassert.
3854 * alloc.c: Convert from xassert to eassert.
3855 * bidi.c: Likewise.
3856 * dispnew.c: Likewise.
3857 * fns.c: Likewise.
3858 * fringe.c: Likewise.
3859 * ftfont.c: Likewise.
3860 * gtkutil.c: Likewise.
3861 * image.c: Likewise.
3862 * keyboard.c: Likewise.
3863 * menu.c: Likewise.
3864 * process.c: Likewise.
3865 * scroll.c: Likewise.
3866 * sound.c: Likewise.
3867 * term.c: Likewise.
3868 * w32console.c: Likewise.
3869 * w32fns.c: Likewise.
3870 * w32term.c: Likewise.
3871 * window.c: Likewise.
3872 * xdisp.c: Likewise.
3873 * xfaces.c: Likewise.
3874 * xfns.c: Likewise.
3875 * xselect.c: Likewise.
3876 * xterm.c: Likewise.
3877
1ec4b7b2
SM
38782012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3879
3880 * fns.c (maybe_resize_hash_table): Output message when growing the
3881 purify-hashtable.
3882
2014308a
DA
38832012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3884
3885 * alloc.c (allocate_string_data): Remove dead code.
3886 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3887 avoid GCC warning about unused macro.
3888
246155eb
DA
38892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3890
3891 * alloc.c (allocate_string): Omit intervals initialization.
3892 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3893 as in make_pure_string and make_pure_c_string.
3894
43184b7b
DA
38952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3896
d209e2fb 3897 * alloc.c (allocate_string): Fix last change.
43184b7b 3898
3fe6dd74
DA
38992012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3900
d209e2fb 3901 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3902 to memset, add explicit initialization where appropriate.
3903
1ba6038a
GM
39042012-06-27 Glenn Morris <rgm@gnu.org>
3905
3906 * lisp.mk (lisp): Remove paths.elc.
3907
c89926a5
CY
39082012-06-27 Chong Yidong <cyd@gnu.org>
3909
3910 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3911
ed6b3510
JW
39122012-06-26 John Wiegley <johnw@newartisans.com>
3913
1ec4b7b2 3914 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3915 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3916
ed6b3510
JW
3917 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3918 when building with Clang.
3919
8edd4a2b
SM
39202012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3921
3922 * eval.c (Fapply): Allow calling it with a single argument.
3923
f6f62d1b
EZ
39242012-06-26 Eli Zaretskii <eliz@gnu.org>
3925
3926 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3927 _stricmp and _strnicmp.
3928 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3929
62efea5e
DA
39302012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3931
3932 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3933 allocated window.
3934 (allocate_process): Likewise for new process.
8edd4a2b 3935 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3936 (allocate_frame): Likewise.
3937 * frame.c (make_frame): Omit redundant initialization.
3938 * window.c (make_parent_window): Use memset.
3939 (make_window): Omit redundant initialization.
3940 * process.c (make_process): Omit redundant initialization.
3941 * terminal.c (create_terminal): Likewise.
3942
42997f4d
DA
39432012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3944
3945 * term.c (delete_tty): Remove redundant call to memset.
3946
1130ecfc
DA
39472012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3948
3949 * alloc.c: Remove build_string.
3950 * lisp.h: Define build_string as static inline. This provides
3951 a better opportunity to optimize away calls to strlen when the
3952 function is called with compile-time constant argument.
3953 * image.c (imagemagick_error): Convert to build_string.
3954 * w32proc.c (sys_spawnve): Likewise.
3955 * xterm.c (x_term_init): Likewise.
3956
cf38a720
PE
39572012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3958
99027bdd
PE
3959 Use sprintf return value instead of invoking strlen on result.
3960 In the old days this wasn't portable, since some sprintf
3961 implementations returned char *. But they died out years ago and
3962 Emacs already assumes sprintf returns int.
3963 Similarly for float_to_string.
3964 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3965 * ccl.c (ccl_driver):
3966 * character.c (string_escape_byte8):
3967 * data.c (Fnumber_to_string):
3968 * doprnt.c (doprnt):
3969 * print.c (print_object):
3970 * xdisp.c (message_dolog):
3971 * xfns.c (syms_of_xfns):
3972 Use sprintf or float_to_string result to avoid need to call strlen.
3973 * data.c (Fnumber_to_string):
3974 Use make_unibyte_string, since the string must be ASCII.
3975 * lisp.h, print.c (float_to_string): Now returns int length.
3976 * term.c (produce_glyphless_glyph):
3977 Use sprintf result rather than recomputing it.
3978
cf38a720
PE
3979 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3980 * Makefile.in (ALL_CFLAGS):
3981 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3982 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3983
3511c784
DA
39842012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3985
0a08eb21 3986 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3987 strcasecmp if available.
3988 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3989
fb7da12e
AS
39902012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3991
3992 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3993 Avoid comma operator.
3994 * menu.c (push_submenu_start, push_submenu_end)
3995 (push_left_right_boundary, push_menu_pane): Likewise.
3996 * msdos.c (dos_rawgetc): Likewise.
3997
afa2ffd8
DA
39982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3999
4000 * xfns.c (xic_create_fontsetname): Remove redundant calls
4001 to memset.
4002
b3b4476b
PE
40032012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4004
4495ff38
PE
4005 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4006 sprintf already null-terminates its output.
4007
b3b4476b
PE
4008 * xfns.c (x_window): Remove redundant cast.
4009
b00876c9
DA
40102012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4011
4012 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4013 `const char *' to `char *' to avoid compiler warning.
4014
d188e26b
PE
40152012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4016
885d1d74
PE
4017 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4018 instead of truncating it to 63 (admittedly a generous limit).
4019
d188e26b
PE
4020 * process.c: Fix spelling and caps in comments.
4021
e2f560b1
DN
40222012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4023
e86db54b 4024 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4025 * sysdep.c (setpgrp): Remove definition, not used in this file.
4026
7583a3a1
JB
40272012-06-24 Juanma Barranquero <lekktu@gmail.com>
4028
4029 * makefile.w32-in: Update dependencies.
4030
696056c2
EZ
40312012-06-24 Eli Zaretskii <eliz@gnu.org>
4032
4033 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4034 (SYSTIME_H): Add nt/inc/sys/time.h.
4035
4036 * systime.h [WINDOWSNT]: Include sys/time.h.
4037
4038 * s/ms-w32.h (struct timespec): Definition moved from
4039 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4040
845ca893
PE
40412012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4042
4043 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4044 * buffer.h (buffer_slot_type_mismatch):
4045 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4046 * eval.c (unwind_to_catch):
4047 * image.c (my_png_error, my_error_exit):
4048 * keyboard.c (quit_throw_to_read_char, user_error)
4049 (Fexit_recursive_edit, Fabort_recursive_edit):
4050 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4051 (wrong_type_argument, buffer_overflow, __executable_start)
4052 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4053 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4054 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4055 (fatal):
4056 (child_setup) [!DOS_NT]:
4057 * lread.c (end_of_file_error, invalid_syntax):
4058 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4059 * puresize.h (pure_write_error):
4060 * search.c (matcher_overflow):
4061 * sound.c (sound_perror, alsa_sound_perror):
4062 * sysdep.c, syssignal.h (croak):
4063 * term.c (maybe_fatal, vfatal):
4064 * textprop.c (text_read_only):
4065 * undo.c (user_error):
4066 * unexmacosx.c (unexec_error):
4067 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4068 Use _Noreturn rather than NO_RETURN.
4069 No need for separate decl merely because of _Noreturn.
4070 * sound.c (sound_warning, parse_sound):
4071 Remove unnecessary forward decls.
4072
f1dd8073
PE
40732012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4074
4075 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4076 * lisp.h (WAIT_READING_MAX): New macro.
4077 * dispnew.c (Fsleep_for, sit_for):
4078 * keyboard.c (kbd_buffer_get_event):
4079 * process.c (Faccept_process_output):
4080 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4081 This improves on the previous patch, which introduced a bug
4082 when time_t is unsigned and as wide as intmax_t.
4083 See <http://bugs.gnu.org/9000#51>.
4084
b82c1755
EZ
40852012-06-23 Eli Zaretskii <eliz@gnu.org>
4086
4087 * dispnew.c (sit_for, Fsleep_for):
4088 * keyboard.c (kbd_buffer_get_event):
4089 * process.c (Faccept_process_output): Avoid compiler warnings when
4090 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4091
ca300656
JB
40922012-06-23 Juanma Barranquero <lekktu@gmail.com>
4093
049ec95b
JB
4094 * makefile.w32-in: Update dependencies.
4095
ca300656
JB
4096 * w32.c (ltime): Add return type and declare static.
4097 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4098
db7b8d06
PE
40992012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4102 Privately reported by Herbert J. Skuhra.
4103 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4104 All uses changed.
4105 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4106 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4107
0bd8297f
EZ
41082012-06-23 Eli Zaretskii <eliz@gnu.org>
4109
96512555
EZ
4110 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4111 last argument of make_unibyte_string.
4112
0bd8297f
EZ
4113 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4114 language ID in the event parameters.
4115
4116 * w32term.c (w32_read_socket): Put the new keyboard codepage into
4117 event.code, not the obscure "character set ID".
4118
63def6b6
CY
41192012-06-23 Chong Yidong <cyd@gnu.org>
4120
4121 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4122
e8a02204
EZ
41232012-06-23 Eli Zaretskii <eliz@gnu.org>
4124
388cdec0
EZ
4125 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4126 * w32.c (fdutimens): New function.
4127
4128 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4129
4130 * s/ms-w32.h (pselect): Redirect to sys_select.
4131
4132 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4133
e8a02204
EZ
4134 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4135 in the logic of incrementing and decrementing the value of
4136 use_relocatable_buffers.
4137
d054f3fb
PE
41382012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4141 Privately reported by Herbert J. Skuhra.
4142 [__FreeBSD__]: Remove "*/" typo after "#include".
4143 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4144 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4145 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4146 Don't assume EMACS_TIME and struct timeval are the same type.
4147
d35af63c
PE
41482012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 Support higher-resolution time stamps (Bug#9000).
4151 The time stamps are only nanosecond-resolution at the C level,
4152 since that's the best that any real-world system supports now.
4153 But they are picosecond-resolution at the Lisp level, as that's
4154 easy, and leaves room for future OS improvements.
4155
4156 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4157 (LIBES): Use it.
4158
4159 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4160 Don't get current time unless it's needed.
4161
4162 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4163 now provides it if it's absent.
4164 (start_atimer): Port to higher-res time stamps.
4165 Check for time stamp overflow. Don't get current time more
4166 often than is needed.
4167
4168 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4169 Include systime.h, not time.h.
4170 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4171
4172 * dired.c: Include stat-time.h.
4173 (Ffile-attributes): File times now have higher resolution.
4174
4175 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4176 (struct image): Timestamp now has higher resolution.
4177
4178 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4179 has at least microseconds now. All uses removed.
4180 (update_frame, update_single_window, update_window, update_frame_1)
4181 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4182 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4183
4184 * editfns.c (time_overflow): Now extern.
4185 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4186 (float-time, Fformat_time_string, Fcurrent_time_string)
4187 (Fcurrent_time_zone): Accept and generate higher-resolution
4188 time stamps.
4189 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4190 (decode_time_components, lisp_seconds_argument): New functions.
4191 (make_time): Now static.
4192 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4193 Report an error if the time is invalid, rather than having the caller
4194 do that.
4195
4196 * fileio.c: Include <stat-time.h>
4197 (Fcopy_file): Copy higher-resolution time stamps.
4198 Prefer to set the time stamp via a file descriptor if that works.
4199 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4200 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4201 (Fvisited_file_modtime, Fset_visited_file_modtime):
4202 Support higher-resolution time stamps.
4203
4204 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4205
4206 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
4207
4208 * image.c (prepare_image_for_display, clear_image_cache)
4209 (lookup_image): Port to higer-resolution time stamps.
4210
4211 * keyboard.c (start_polling, bind_polling_period):
4212 Check for time stamp overflow.
4213 (read_char, kbd_buffer_get_event, timer_start_idle)
4214 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
4215 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
4216 Port to higher-resolution time stamps. Do not assume time_t is signed.
4217 (decode_timer): New function. Timers are now vectors of length 9,
4218 not 8, to accommodate the picosecond component.
4219 (timer_check_2): Use it.
4220
4221 * nsterm.m (select_timeout, timeval_subtract): Remove.
4222 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
4223 as they're a bit more accurate and handle overflow better.
4224 (ns_select): Change prototype to be compatible with pselect.
4225 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
4226 * nsterm.h (ns_select): Adjust prototype.
4227
4228 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
4229 us-resolution time stamps.
4230 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
4231
4232 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
4233
4234 * lisp.h (time_overflow): New decl.
4235 (wait_reading_process_output): First arg is now intmax_t, not int,
4236 to accommodate larger waits.
4237
4238 * process.h (struct Lisp_Process.read_output_delay):
4239 Now counts nanoseconds, not microseconds.
4240 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
4241 EMACS_HAS_USECS.
4242 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
4243 (wait_reading_process_output):
4244 Port to ns-resolution time stamps.
4245 (Faccept_process_output, wait_reading_process_output):
4246 Check for time stamp overflow. Do not assume time_t is signed.
4247 (select_wrapper): Remove; we now use pselect.
4248 (Fprocess_attributes): Now generates ns-resolution time stamps.
4249
4250 * sysdep.c: Include utimens.h. Don't include utime.h
4251 or worry about struct utimbuf; gnulib does that for us now.
4252 (gettimeofday): Remove; gnulib provides a substitute.
4253 (make_timeval): New function.
4254 (set_file_times): Now sets ns-resolution time stamps.
4255 New arg FD; all uses changed.
4256 (time_from_jiffies, ltime_from_jiffies, get_up_time)
4257 (system_process_attributes):
4258 Now returns ns-resolution time stamp. All uses changed.
4259 Check for time stamp overflow.
4260
4261 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
4262 provides a substitute now.
4263
4264 * systime.h: Include timespec.h rather than sys/time.h and time.h,
4265 since it guarantees struct timespec.
4266 (EMACS_TIME): Now struct timespec, so that we can support
4267 ns-resolution time stamps.
4268 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
4269 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
4270 (EMACS_USECS): Remove.
4271 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
4272 so multiply the arg by 1000 before storing it.
4273 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
4274 New macros.
4275 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
4276 Port to ns-resolution time stamps.
4277 (EMACS_TIME_NEG_P): Remove; replaced by....
4278 (EMACS_TIME_SIGN): New macro.
4279 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
4280 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
4281 (set_file_times, make_time, lisp_time_argument): Adjust signature.
4282 (make_timeval, make_lisp_time, decode_time_components): New decls.
4283 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
4284 that it mishandled time_t overflow. You can't compare by subtracting!
4285 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
4286 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
4287
4288 * term.c: Include <sys/time.h>.
4289 (timeval_to_Time): New function, for proper overflow wraparound.
4290 (term_mouse_position, term_mouse_click): Use it.
4291
4292 * undo.c (record_first_change): Support higher-resolution time stamps
4293 in the undo buffer.
4294 (Fprimitive_undo): Use them when restoring time stamps.
4295
4296 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
4297 (w32_get_internal_run_time):
4298 Port to higher-resolution Emacs time stamps.
4299 (ltime): Now accepts single 64-bit integer, as that's more convenient
4300 for callers.
4301
4302 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
4303
4304 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
4305 for compatibility with pselect. Support ns-resolution time stamps.
4306
4307 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
4308
4309 * xselect.c (wait_for_property_change, x_get_foreign_selection):
4310 Check for time stamp overflow, and support ns-resolution time stamps.
4311
4312 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
4313 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
4314 (timeval_subtract): Remove; no longer needed.
4315 (XTflash, XTring_bell, x_wait_for_event):
4316 Port to ns-resolution time stamps. Don't assume time_t is signed.
4317
b6a92dfe
CY
43182012-06-22 Chong Yidong <cyd@gnu.org>
4319
4320 * xdisp.c (x_consider_frame_title): Revert last change.
4321
d251c37c
EZ
43222012-06-22 Eli Zaretskii <eliz@gnu.org>
4323
4324 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
4325 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
4326 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
4327 staticidx goes up to 1597 out of 1600 = 0x640.)
4328
f10deafb
PE
43292012-06-20 Paul Eggert <eggert@cs.ucla.edu>
4330
4331 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
4332 Otherwise, the umask might be mistakenly 0 while handling input signals.
4333
ec6de1e2
SM
43342012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
4335
4336 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4337
28be1ada
DA
43382012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
4339
4340 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4341 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
4342 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
4343 access to `contents' member of Lisp_Vector objects with AREF and ASET
4344 where appropriate.
4345
c6bf3022
CY
43462012-06-19 Chong Yidong <cyd@gnu.org>
4347
4348 * frame.c (delete_frame): When selecting a frame on a different
4349 text terminal, do not alter the terminal's top-frame.
4350
4351 * xdisp.c (format_mode_line_unwind_data): Record the target
4352 frame's selected window and its terminal's top-frame.
4353 (unwind_format_mode_line): Restore them.
4354 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
4355 Callers changed.
4356 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
4357 since tty frames can be explicitly named.
4358 (prepare_menu_bars): Likewise.
4359
4360 * term.c (Ftty_top_frame): New function.
4361
defd4196
PE
43622012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4363
4364 Port byte-code-meter to modern targets.
4365 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
4366 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 4367 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
4368 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
4369 (METER_1, METER_2): Simplify.
4370
1053a871
SM
43712012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
4372
4373 * data.c (Fdefalias): Return `symbol' (bug#11686).
4374
b7e8d081
MR
43752012-06-18 Martin Rudalics <rudalics@gmx.at>
4376
4377 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
4378 gets killed during executing of this function (Bug#11665).
4379 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
4380 (Vkill_buffer_query_functions): In doc-string say that functions
4381 run by this hook should not change the current buffer.
4382
7ea2b339
PE
43832012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4384
4385 Fix recently-introduced process.c problems found by static checking.
4386 * process.c (write_queue_push, write_queue_pop, send_process):
4387 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
4388 (write_queue_pop): Fix pointer signedness problem.
4389 (send_process): Remove unused local.
4390
96a313a1
CY
43912012-06-17 Chong Yidong <cyd@gnu.org>
4392
4393 * xdisp.c (redisplay_internal): No need to redisplay terminal
4394 frames that are not on top.
4395
20ca2e94
TN
43962012-06-17 Troels Nielsen <bn.troels@gmail.com>
4397
4398 * process.c (make_process): Initialize write_queue.
4399 (write_queue_push, write_queue_pop): New functions.
4400 (send_process): Use them to maintain correct ordering of process
4401 writes (Bug#10815).
4402
9a900ca9
PE
44032012-06-17 Paul Eggert <eggert@cs.ucla.edu>
4404
310fbfa8
PE
4405 * lisp.h (eassert): Assume C89 or later.
4406 This removes the need for CHECK.
4407 (CHECK): Remove. Its comments about always evaluating its
4408 argument were confusing, as 'eassert' typically does not evaluate
4409 its argument.
4410
27bb1ca4
PE
4411 * coding.c (produce_chars): Use ptrdiff_t, not int.
4412
9a900ca9
PE
4413 * xterm.c (x_draw_underwave): Check for integer overflow.
4414 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
4415
41b7f8bc 44162012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
4417
4418 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4419 referenced (Bug#11583).
4420
9b0e3eba
AA
44212012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
4422
4423 Implement wave-style variant of underlining.
4424 * dispextern.h (face_underline_type): New enum.
4425 (face): Add field for underline type.
4426 * nsterm.m (ns_draw_underwave): New function.
4427 (ns_draw_text_decoration): Use it.
4428 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
4429 New functions.
4430 (x_draw_glyph_string): Use them.
4431 * xfaces.c (Qline, Qwave): New Lisp objects.
4432 (check_lface_attrs, merge_face_ref)
1053a871
SM
4433 (Finternal_set_lisp_face_attribute, realize_x_face):
4434 Handle wave-style underline face attributes.
9b0e3eba
AA
4435 * xterm.c (x_draw_underwave): New function.
4436 (x_draw_glyph_string): Use it.
4437
0fb52f11
JB
44382012-06-16 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4441 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
4442 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
4443 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
4444 ($(BLD)/w32select.$(O)): Update dependencies.
4445
e5560ff7
AS
44462012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4447
4448 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4449 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
4450 * character.c (_fetch_multibyte_char_p): Remove.
4451 * alloc.c: Include "character.h" before "buffer.h".
4452 * bidi.c: Likewise.
4453 * buffer.c: Likewise.
4454 * bytecode.c: Likewise.
4455 * callint.c: Likewise.
4456 * callproc.c: Likewise.
4457 * casefiddle.c: Likewise.
4458 * casetab.c: Likewise.
4459 * category.c: Likewise.
4460 * cmds.c: Likewise.
4461 * coding.c: Likewise.
4462 * composite.c: Likewise.
4463 * dired.c: Likewise.
4464 * dispnew.c: Likewise.
4465 * doc.c: Likewise.
4466 * dosfns.c: Likewise.
4467 * editfns.c: Likewise.
4468 * emacs.c: Likewise.
4469 * fileio.c: Likewise.
4470 * filelock.c: Likewise.
4471 * font.c: Likewise.
4472 * fontset.c: Likewise.
4473 * fringe.c: Likewise.
4474 * indent.c: Likewise.
4475 * insdel.c: Likewise.
4476 * intervals.c: Likewise.
4477 * keyboard.c: Likewise.
4478 * keymap.c: Likewise.
4479 * lread.c: Likewise.
4480 * macros.c: Likewise.
4481 * marker.c: Likewise.
4482 * minibuf.c: Likewise.
4483 * nsfns.m: Likewise.
4484 * nsmenu.m: Likewise.
4485 * print.c: Likewise.
4486 * process.c: Likewise.
4487 * regex.c: Likewise.
4488 * region-cache.c: Likewise.
4489 * search.c: Likewise.
4490 * syntax.c: Likewise.
4491 * term.c: Likewise.
4492 * textprop.c: Likewise.
4493 * undo.c: Likewise.
4494 * unexsol.c: Likewise.
4495 * w16select.c: Likewise.
4496 * w32fns.c: Likewise.
4497 * w32menu.c: Likewise.
4498 * window.c: Likewise.
4499 * xdisp.c: Likewise.
4500 * xfns.c: Likewise.
4501 * xmenu.c: Likewise.
4502 * xml.c: Likewise.
4503 * xselect.c: Likewise.
4504
2f07e6af
EZ
45052012-06-16 Eli Zaretskii <eliz@gnu.org>
4506
1053a871
SM
4507 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4508 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4509 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4510 row.
4511 (handle_face_prop): Use chunk-relative overlay string index when
4512 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4513 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4514 the rightmost. (Bug#11720)
2f07e6af 4515
29b83cec
AS
45162012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4517
4518 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4519 (CATEGORY_MEMBER): Enforce 1/0 value.
4520 * category.c (_temp_category_set): Remove.
4521
4c5501e9
EZ
45222012-06-16 Eli Zaretskii <eliz@gnu.org>
4523
4524 * window.c (Fdelete_other_windows_internal)
4525 (Fdelete_window_internal): Don't access frame's mouse highlight
4526 info of the initial frame. (Bug#11677)
4527
2b570124
PE
45282012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4529
e93864f9
PE
4530 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4531 Assume USE_2_TAGS_FOR_INTS.
4532 (xreload): Adjust $tagmask width to match recent lisp.h change.
4533
2b570124
PE
4534 Simplify lisp.h in minor ways that should not affect code.
4535 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4536 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4537 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4538 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4539 (INTTYPEBITS): New macro, for clarity.
4540 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4541 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4542 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4543 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4544 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4545
81755f69
JB
45462012-06-13 Juanma Barranquero <lekktu@gmail.com>
4547
4548 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4549
16192a57
GM
45502012-06-13 Glenn Morris <rgm@gnu.org>
4551
4552 * s/bsd-common.h (BSD4_3):
4553 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4554
646b5f55
AS
45552012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4556
4557 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4558 instead of union.
4559 (XLI, XIL): Define.
1053a871
SM
4560 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4561 Use them.
4562 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4563 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4564 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4565 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4566 * frame.c (delete_frame): Remove outdated comment.
4567 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4568 USE_LISP_UNION_TYPE.
4569 (Fw32_unregister_hot_key): Likewise.
4570 (Fw32_toggle_lock_key): Likewise.
4571 * w32menu.c (add_menu_item): Likewise.
4572 (w32_menu_display_help): Use XIL instead of checking
4573 USE_LISP_UNION_TYPE.
4574 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4575 (init_heap): Likewise.
4576 * w32term.c (w32_read_socket): Update comment.
4577
1d3823c9
GM
45782012-06-13 Glenn Morris <rgm@gnu.org>
4579
c62ff706
GM
4580 * s/usg5-4-common.h, src/s/unixware.h:
4581 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4582
1d3823c9
GM
4583 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4584
bfe3e0a2
PE
45852012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4588 * alloc.c (make_number) [!defined make_number]:
4589 Remove, as lisp.h always defines this now.
4590 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4591 (roundup_size): Verify that it is a power of 2.
4592 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4593 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4594 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4595 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4596 USE_LSB_TAG now is always defined to be either 0 or 1.
4597 All uses changed.
4598 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4599 code works fine either way, and efficiency is not a concern here,
4600 as the union type is for debugging, not for production.
4601 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4602 Use an inline function on all platforms when using the union type,
4603 since this is simpler and 'static inline' can be used portably
4604 within Emacs now.
4605 (LISP_INITIALLY_ZERO): New macro.
4606 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4607 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4608
45fa9c0f
GM
46092012-06-12 Glenn Morris <rgm@gnu.org>
4610
b4492cba
GM
4611 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4612
4613 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4614
45fa9c0f
GM
4615 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4616 Move BROKEN_SIGIO to configure.
4617
4618 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4619 Move NO_TERMIO to configure.
4620
0e25d334
CY
46212012-06-12 Chong Yidong <cyd@gnu.org>
4622
4623 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4624 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4625 MagickExportImagePixels is undefined.
4626
43682bb6
PE
46272012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4628
4629 * image.c (imagemagick_load_image): Remove unused label.
4630
a9be7d2b
GM
46312012-06-11 Glenn Morris <rgm@gnu.org>
4632
4633 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4634 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4635 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4636 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4637
3017f87f
SM
46382012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4639
4640 * alloc.c (make_byte_code): New function.
4641 (Fmake_byte_code): Use it. Don't purify here.
4642 * lread.c (read1): Use it as well to avoid extra allocation.
4643
1b9b4cf4
CY
46442012-06-11 Chong Yidong <cyd@gnu.org>
4645
4646 * image.c (imagemagick_load_image): Implement transparency.
4647
95988fcf
AS
46482012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4649
4650 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4651 account for preceding backslashes. (Bug#11663)
4652
cd4eb164
CY
46532012-06-09 Chong Yidong <cyd@gnu.org>
4654
4655 * term.c: Support italics in capable terminals (Bug#9652).
4656 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4657 (turn_on_face): Output using TS_enter_italic_mode if available.
4658 Don't handle unused blinking and alt-charset cases.
4659 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4660 and tty_alt_charset_p cases.
4661 (tty_capable_p, init_tty): Support italics.
4662
4663 * termchar.h (struct tty_display_info): Add field for italics.
4664 Remove unused blink field.
4665
4666 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4667 Handle slant.
4668
4669 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4670 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4671 tty_alt_charset_p. Add tty_italic_p.
4672
ff88beb8
MA
46732012-06-09 Michael Albinus <michael.albinus@gmx.de>
4674
4675 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4676 dbus_type_is_basic if available.
4677 (xd_extract_signed, xd_extract_unsigned): Rename from
4678 extract_signed and extract_unsigned, respectively. Adapt callers.
4679
44286096
CY
46802012-06-09 Chong Yidong <cyd@gnu.org>
4681
1682701f
CY
4682 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4683
44286096
CY
4684 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4685 case (Bug#9752).
4686
d86feb17
PE
46872012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4688
4689 * xdisp.c (vmessage): Treat frame message as multibyte.
4690 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4691 would generate the diagnostic "Making \302\247 buffer-local while
4692 let-bound!".
4693
d5c20fe8
EZ
46942012-06-08 Eli Zaretskii <eliz@gnu.org>
4695
4696 * dispnew.c (showing_window_margins_p): Undo last change, which
4697 was done due to an inadvertent commit.
4698 (adjust_frame_glyphs_for_frame_redisplay): Do call
4699 showing_window_margins_p.
4700
513749ee
SM
47012012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4702
4703 * eval.c (Fmake_var_non_special): New primitive.
4704 (syms_of_eval): Defsubr it.
4705 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4706
d4a8f5c1
JB
47072012-06-08 Juanma Barranquero <lekktu@gmail.com>
4708
4709 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4710 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4711
8bbbc977
EZ
47122012-06-08 Eli Zaretskii <eliz@gnu.org>
4713
4714 * alloc.c (allocate_vectorlike): Fix last change.
4715
f3372c87
DA
47162012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4717
4718 Block-based vector allocation of small vectors.
4719 * lisp.h (struct vectorlike_header): New field `nbytes',
4720 adjust comment accordingly.
4721 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4722 to denote vector blocks. Adjust users (live_vector_p,
4723 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4724 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4725 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4726 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4727 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4728 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4729 (roundup_size): New constant.
4730 (struct vector_block): New data type.
4731 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4732 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4733 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4734 (sweep_vectors): New functions.
4735 (allocate_vectorlike): Return `zero_vector' as the only vector of
4736 0 items. Allocate new vector from block if vector size is less than
4737 or equal to VBLOCK_BYTES_MAX.
4738 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4739 (init_alloc_once): Add call to init_vectors.
4740
4f18a4ed
SM
47412012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4742
4743 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4744
86f158bc
PE
47452012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4746
4747 * doprnt.c (doprnt): Truncate multibyte char correctly.
4748 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4749 would mishandle a string argument "Xc" if X was a multibyte
4750 character of length 2: it would truncate after X's first byte
4751 rather than including all of X.
4752
c5cfcbe0
CY
47532012-06-06 Chong Yidong <cyd@gnu.org>
4754
4755 * buffer.c (word_wrap): Doc fix.
4756
c05cf390
PE
47572012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4758
4759 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4760
0c3461de
GM
47612012-06-03 Glenn Morris <rgm@gnu.org>
4762
4763 * xdisp.c (tool-bar-style): Doc fix.
4764
c71232db
UM
47652012-06-03 Ulrich Müller <ulm@gentoo.org>
4766
4767 * Makefile.in (PAXCTL): Define.
4768 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4769 binary via PaX flags if the paxctl utility is available.
4770 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4771 Restore PaX flags to their default. (Bug#11398)
4772
383f7350
CY
47732012-06-03 Chong Yidong <cyd@gnu.org>
4774
4775 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4776 buffer (Bug#11226).
4777
5f2c76c6
CY
47782012-06-03 Chong Yidong <cyd@gnu.org>
4779
4780 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4781 (note_mode_line_or_margin_highlight): If there is no help echo,
4782 use mode-line-default-help-echo. Handle the case where the mouse
4783 position is past the end of the mode line string.
4784
4785 * buffer.c (buffer_local_value_1): New function, split from
4786 Fbuffer_local_value; can return Qunbound.
4787 (Fbuffer_local_value): Use it.
4788 (Vmode_line_format): Docstring tweaks.
4789
773d47f6
PE
47902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4791
4792 * sysdep.c (system_process_attributes): Improve comment.
4793
f2d6a3df
SM
47942012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4795
4796 * keyboard.c: Export real-this-command to Elisp.
4797 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4798 and DEFVAR it. Update all users.
4799
63810350
PE
48002012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4801
7bd5c1f4
PE
4802 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4803
63810350
PE
4804 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4805 Convert pctcpu and pctmem to Lisp float properly.
4806 Let the compiler fold better, as 100.0/0x8000 is exact.
4807
a2821611
AS
48082012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4809
4810 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4811 cons_block.
4812
5fceba1d
PE
48132012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4814
4815 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4816
c98ff5dd
DA
48172012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4818
4819 For a 'struct window', replace some Lisp_Object fields to
4820 bitfields where appropriate, remove unused fields.
4821 * window.h (struct window): Remove unused 'last_mark_x' and
4822 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4823 change it's type from Lisp_Object to bitfield.
4824 Change type of 'force_start', 'optional_new_start',
4825 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4826 fields from Lisp_Object to bitfield. Adjust users accordingly.
4827
ca34e0be
PE
48282012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4829
4830 Pacify gcc -Wdouble-precision when using Xaw.
4831 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4832 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4833 Use 'float' consistently, rather than 'float' in most places
4834 and 'double' in a couple of places.
4835
efc00ab1 48362012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4837
4838 * xdisp.c (handle_stop): Detect whether we have overlay strings
4839 loaded by testing it->current.overlay_string_index to be
4840 non-negative, instead of checking whether n_overlay_strings is
4841 positive. (Bug#11587)
4842
efc00ab1 48432012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4844
4845 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4846
4847 * doc.c (Fsubstitute_command_keys): Doc fix.
4848
efc00ab1 48492012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4850
4851 * search.c (search_buffer): Remove calls to
4852 r_alloc_inhibit_buffer_relocation, as it is now called by
4853 maybe_unify_char, which was the cause of relocation of buffer text
4854 in bug#11519.
4855
efc00ab1 48562012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4857
4858 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4859 for the duration of call to load_charset, to avoid problems with
4860 callers of maybe_unify_char that access buffer text through C
4861 pointers.
4862
4863 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4864 decrement the inhibition flag, instead of just setting or
4865 resetting it.
4866
ba93a187
PE
48672012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4868
4869 Remove obsolete '#define static' cruft.
4870 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4871 This #undef was "temporary" in 2000; it is no longer needed
4872 now that '#define static' has gone away.
4873 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4874 (gray_bitmap_bits): Remove; no longer needed.
4875 All uses replaced with definiens.
4876 * xterm.c: Include "bitmaps/gray.xbm".
4877
9e4bf381
PE
48782012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4879
4880 Clean up __executable_start, monstartup when --enable-profiling.
4881 The following changes affect the code only when profiling.
4882 * dispnew.c (__executable_start): Rename from safe_bcopy.
4883 Define only on platforms that need it.
4884 * emacs.c: Include <sys/gmon.h> when profiling.
4885 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4886 (__executable_start): Remove decl, since lisp.h does it now.
4887 (safe_bcopy): Remove decl; no longer has that name.
4888 (main): Coalesce #if into single bit of code, for simplicity.
4889 Cast pointers to uintptr_t, since standard libraries want integers
4890 and not pointers.
4891 * lisp.h (__executable_start): New decl.
4892
32d72c2f
GM
48932012-05-31 Glenn Morris <rgm@gnu.org>
4894
4895 * image.c (Fimagemagick_types): Doc fix.
4896
baac5bc7
JM
48972012-05-30 Jim Meyering <meyering@redhat.com>
4898
4899 * callproc.c (Fcall_process_region): Include directory component
4900 in mkstemp error message (Bug#11586).
4901
72cb32cf
PE
49022012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * alloc.c, lisp.h (make_pure_vector): Now static.
4905
61b108cc
SM
49062012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4907
4908 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4909 Move to byte-run.el.
4910 (Fautoload): Do the hash-doc more carefully.
4911 * data.c (Fdefalias): Purify definition, except for keymaps.
4912 (Qdefun): Move from eval.c.
4913 * lisp.h (Qdefun): Remove.
4914 * lread.c (read1): Tiny simplification.
4915
471fe23d
TN
49162012-05-29 Troels Nielsen <bn.troels@gmail.com>
4917
934f3f58 4918 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4919 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4920 Bug#9642, but explicitly check that the buffer the overlay would
4921 be moved to is live and rearrange lines to make sure that errors
4922 will not put the overlay in an inconsistent state.
4923 (Fdelete_overlay): Cosmetics.
4924
85d0efd1
EZ
49252012-05-28 Eli Zaretskii <eliz@gnu.org>
4926
4927 * w32term.c (my_bring_window_to_top): New function.
4928 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4929 could be different from the original one.
4930 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4931 (Bug#11513)
4932
4933 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4934 by calling BringWindowToTop.
4935
4936 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4937 (WM_EMACS_END): Increase by one.
4938
da92a98c
PE
49392012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4940
4941 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4942 This avoids undefined behavior that might cause the eassert
4943 to not catch an out-of-range value.
4944
74d1f848
JB
49452012-05-28 Juanma Barranquero <lekktu@gmail.com>
4946
4947 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4948 Update dependencies.
4949
9e1a06fc
EZ
49502012-05-27 Eli Zaretskii <eliz@gnu.org>
4951
4952 * bidi.c (bidi_mirror_char): Fix last change.
4953
f3dd7312
AS
49542012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4955
4956 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4957 when referring to sectname field in printf format.
4958
81899c91
PE
49592012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4960
57b81a9f
PE
4961 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4962 Only r_alloc_inhibit_buffer_relocation needed to be added;
4963 the others were already declared.
4964
81899c91
PE
4965 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4966 before checking whether it's out of range. Put the check inside
4967 eassert. See
4968 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4969
33017faf 49702012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4971
4972 * callproc.c (Fcall_process): Restore a line that was accidentally
4973 commented out in the 2011-02-13 change (bug#11547).
4974
33017faf 49752012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4976
4977 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4978 defined on ralloc.c.
4979
4980 * buffer.c [REL_ALLOC]: Remove prototypes of
4981 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4982 they are now on lisp.h.
4983
4984 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4985
4986 * search.c (search_buffer): Use it to inhibit relocation of buffer
4987 text while re_search_2 is doing its job, because re_search_2 is
4988 passed C pointers to buffer text. (Bug#11519)
4989
23415acf
EZ
4990 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4991 Update value to 24.
4992
44e27368
EZ
4993 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4994 state after an additional call to move_it_in_display_line_to, keep
4995 the values of it->max_ascent and it->max_descent found for the
4996 entire line.
4997 (pos_visible_p): Revert the comparison against bottom_y to what it
4998 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4999 (Bug#11464)
5000
c1892f11
PE
50012012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5002
5003 Fix coding-related core dumps with gcc -ftrapv.
5004 The code was computing A - B, where A and B are pointers, and B is
5005 random garbage. This can lead to core dumps on platforms that
5006 have special pointer registers, and it also leads to core dumps on
5007 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5008 A - B only when B is initialized properly.
5009 * coding.c (coding_set_source, coding_set_destination): Return void.
5010 (coding_change_source, coding_change_destinations): New functions,
5011 with the old behaviors of coding_set_source and coding_set_destination.
5012 All callers that need an offset changed to use these new functions.
5013
eb7afdad
GM
50142012-05-26 Glenn Morris <rgm@gnu.org>
5015
5016 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5017
f12fdf02
EZ
50182012-05-26 Eli Zaretskii <eliz@gnu.org>
5019
53a63be6 5020 Extend mouse support on W32 text-mode console.
61b108cc
SM
5021 * xdisp.c (draw_row_with_mouse_face):
5022 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5023
eb3f6f01 5024 * w32console.c: Include window.h.
61b108cc
SM
5025 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5026 New functions.
eb3f6f01
EZ
5027 (initialize_w32_display): Initialize mouse-highlight data.
5028
53a63be6
EZ
5029 * w32inevt.c: Include termchar.h and window.h.
5030 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5031 moves, call note_mouse_highlight. If help_echo changed, call
5032 gen_help_event to produce help-echo message in the echo area.
5033 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5034 highlight info.
5035
4cfd81f6
PE
50362012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5037
5038 * lread.c (read1): Simplify slightly to avoid an overflow warning
5039 with GCC 4.7.0 on x86-64.
5040
4446092a
EZ
50412012-05-26 Eli Zaretskii <eliz@gnu.org>
5042
5043 * bidi.c (bidi_mirror_char): Revert last change: an int is
5044 definitely wide enough here.
5045
42b2a986 50462012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5047
42b2a986 5048 Fix integer width and related bugs (Bug#9874).
eb106a49 5049 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5050 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5051 (string_bytes, check_sblock, allocate_string_data):
5052 (compact_small_strings, Fmake_bool_vector, make_string)
5053 (make_unibyte_string, make_multibyte_string)
5054 (make_string_from_bytes, make_specified_string)
5055 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5056 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5057 (mark_vectorlike):
5058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5059 (allocate_pseudovector):
5060 Use int, not EMACS_INT, where int is wide enough.
5061 (inhibit_garbage_collection, Fgarbage_collect):
5062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5063 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5064 int might not be wide enough.
5065 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5066 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5067 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5068 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5069 (bidi_level_of_next_char, bidi_move_to_visually_next):
5070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5071 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5072 (Fkill_buffer, Fset_buffer_major_mode)
5073 (advance_to_char_boundary, Fbuffer_swap_text)
5074 (Fset_buffer_multibyte, overlays_at, overlays_in)
5075 (overlay_touches_p, struct sortvec, record_overlay_string)
5076 (overlay_strings, recenter_overlay_lists)
5077 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5078 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5079 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5080 (Foverlay_recenter, last_overlay_modification_hooks_used)
5081 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5083 (validate_region): Omit unnecessary test for b <= e,
5084 since that's guaranteed by the previous test.
d311d28c
PE
5085 (adjust_overlays_for_delete): Avoid pos + length overflow.
5086 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5087 (report_overlay_modification):
5088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5089 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5090 Omit pointer cast, which isn't needed anyway, and doesn't work
5091 after the EMACS_INT -> ptrdiff_t change.
02481186 5092 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5093 * buffer.h: Adjust decls to match defn changes elsewhere.
5094 (struct buffer_text, struct buffer):
5095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5096 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5097 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5098 not int, to avoid needless 32-bit limit on 64-bit hosts.
5099 (exec_byte_code): Use tighter memory-full test, one that checks
5100 for alloca overflow. Don't compute the address of the object just
5101 before an array, as that's not portable. Use EMACS_INT, not
5102 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5103 * callint.c (Fcall_interactively):
5104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5105 * callproc.c (call_process_kill, Fcall_process):
5106 Don't assume pid_t fits into an Emacs fixnum.
5107 (call_process_cleanup, Fcall_process, child_setup):
5108 Don't assume pid_t fits into int.
5109 (call_process_cleanup, Fcall_process, delete_temp_file)
5110 (Fcall_process_region):
5111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5112 (Fcall_process): Simplify handling of volatile integers.
5113 Use int, not EMACS_INT, where int will do.
5114 * casefiddle.c (casify_object, casify_region, operate_on_word)
5115 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
5116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5117 (casify_object): Avoid integer overflow when overallocating buffer.
5118 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5119 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5120 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5121 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5122 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5123 integers are now checked earlier. All uses replaced with XINT.
5124 (ccl_driver):
5125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5126 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5127 (ccl_driver, Fregister_code_conversion_map):
5128 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5129 (resolve_symbol_ccl_program): Check that vector header is in range.
5130 Always copy the vector, so that we can check its contents reliably
5131 now rather than having to recheck each instruction as it's being
5132 executed. Check that vector words fit in 'int'.
5133 (ccl_get_compiled_code, Fregister_ccl_program)
5134 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5135 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5136 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5137 contents are in range.
5138 (Fccl_execute_on_string): Check that status is in range.
5139 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5140 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5141 Accept and return EMACS_INT, not int, because callers can pass values
5142 out of 'int' range.
5143 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5144 (multibyte_chars_in_text, parse_str_as_multibyte)
5145 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5146 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5147 (string_escape_byte8, Fget_byte):
5148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5149 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5150 avoid mishandling large integers.
5151 * character.h: Adjust decls to match defn changes elsewhere.
5152 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5153 (Ffind_charset_region):
5154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5155 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5156 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5157 Don't assume fixnum fits in int.
d311d28c
PE
5158 (load_charset_map_from_vector, Fmap_charset_chars):
5159 Remove now-unnecessary CHECK_NATNUMs.
5160 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5161 Don't rely on undefined behavior with signed left shift overflow.
5162 Don't assume unsigned int fits into fixnum, or that fixnum fits
5163 into unsigned int. Don't require max_code to be a valid fixnum;
5164 that's not true for gb10830 4-byte on a 32-bit host. Allow
5165 invalid_code to be a cons, for the same reason. Require code_offset
5166 to be a character. Avoid int overflow if max_char is close
5167 to INT_MAX.
5168 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5169 this is intended anyway and avoids some undefined behavior.
5170 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5171 INDEX_TO_CODE_POINT, as that's what it expects.
5172 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5173 * charset.h (DECODE_CHAR): Return int, not unsigned;
5174 this is what was intended anyway, and it avoids undefined behavior.
5175 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5176 integer-overflow issues.
5177 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5178 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5179 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5180 * chartab.c (Fmake_char_table, Fset_char_table_range)
5181 (uniprop_get_decoder, uniprop_get_encoder):
5182 Don't assume fixnum fits in int.
5183 * cmds.c (move_point): New function, that does the gist of
5184 Fforward_char and Fbackward_char, but does so while checking
5185 for integer overflow more accurately.
c96e5d6a 5186 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5187 (Fforward_line, Fend_of_line, internal_self_insert)
5188 (internal_self_insert):
5189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5190 Fix a FIXME, by checking for integer overflow when calculating
5191 target_clm and actual_clm.
5192 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5193 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5194 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5195 (coding_alloc_by_making_gap, alloc_destination)
5196 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5197 (encode_coding_utf_16, detect_coding_emacs_mule)
5198 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5199 (detect_coding_iso_2022, decode_coding_iso_2022)
5200 (encode_invocation_designation, encode_designation_at_bol)
5201 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5202 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5203 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5204 (encode_coding_ccl, encode_coding_raw_text)
5205 (detect_coding_charset, decode_coding_charset)
5206 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
5207 (produce_composition, produce_charset, produce_annotation)
5208 (decode_coding, handle_composition_annotation)
5209 (handle_charset_annotation, consume_chars, decode_coding_gap)
5210 (decode_coding_object, encode_coding_object, detect_coding_system)
5211 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
5212 (code_convert_region, code_convert_string)
8f50130c
PE
5213 (Fdefine_coding_system_internal)
5214 (coding_set_source, coding_set_destination):
d311d28c
PE
5215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5216 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
5217 (Fdefine_coding_system_internal):
5218 Don't assume fixnums fit in int.
5219 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 5220 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
5221 (Funencodable_char_position, Fcheck_coding_systems_region)
5222 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 5223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 5224 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 5225 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 5226 Don't access memory outside of the args array.
d311d28c 5227 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
5228 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
5229 result of ENCODE_CHAR.
d311d28c
PE
5230 * coding.h: Adjust decls to match defn changes elsewhere.
5231 (struct coding_system):
5232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5233 * composite.c (get_composition_id, find_composition)
5234 (run_composition_function, update_compositions)
5235 (compose_text, composition_gstring_put_cache)
5236 (composition_gstring_p, composition_gstring_width)
5237 (fill_gstring_header, fill_gstring_body, autocmp_chars)
5238 (composition_compute_stop_pos, composition_reseat_it)
5239 (composition_update_it, struct position_record)
5240 (find_automatic_composition, composition_adjust_point)
5241 (Fcomposition_get_gstring, Ffind_composition_internal):
5242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5243 (update_compositions):
5244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5245 * composite.h: Adjust decls to match defn changes elsewhere.
5246 (struct composition):
5247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5248 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5249 Do not attempt to compute the address of the object just before a
5250 buffer; this is not portable.
5251 (Faref, Faset):
5252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5253 (Faset): Use int, not EMACS_INT, where int is wide enough.
5254 (Fstring_to_number): Don't assume fixnums fit in int.
5255 (Frem): Don't assume arg is nonnegative.
5256 * dbusbind.c (xd_append_arg): Check for integers out of range.
5257 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 5258 (extract_signed, extract_unsigned): New functions.
243e0530
PE
5259 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
5260 (xd_get_connection_references): Return ptrdiff_t, not int.
5261 All uses changed.
5262 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
5263 (xd_read_message_1):
5264 Use int, not unsigned, where the dbus API uses int.
5265 (Fdbus_message_internal): Don't overflow mtype.
5266 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
5267 * dired.c (directory_files_internal, file_name_completion, scmp)
5268 (file_name_completion_stat):
5269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5270 (file_name_completion): Don't overflow matchcount.
5271 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
5272 * dispextern.h: Adjust decls to match defn changes elsewhere.
5273 (struct text_pos, struct glyph, struct bidi_saved_info)
5274 (struct bidi_string_data, struct bidi_it, struct composition_it)
5275 (struct it):
5276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5277 (struct display_pos, struct composition_it, struct it):
5278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5279 * dispnew.c (increment_matrix_positions)
5280 (increment_row_positions, mode_line_string)
5281 (marginal_area_string):
5282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 5283 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
5284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5285 (duration_to_sec_usec): New function, to check for overflow better.
5286 (Fsleep_for, sit_for): Use it.
5287 * doc.c (get_doc_string, store_function_docstring):
5288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5289 (get_doc_string, Fsnarf_documentation):
5290 Use int, not EMACS_INT, where int is wide enough.
5291 (get_doc_string):
5292 Use SAFE_ALLOCA, not alloca.
5293 Check for overflow when converting EMACS_INT to off_t.
5294 * doprnt.c (doprnt):
5295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5296 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
5297 Don't assume uid_t fits into fixnum.
5298 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
5299 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
5300 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
5301 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
5302 (general_insert_function)
5303 (Finsert_char, make_buffer_string, make_buffer_string_both)
5304 (update_buffer_properties, Fbuffer_substring)
5305 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
5306 (Fsubst_char_in_region, check_translation)
5307 (Ftranslate_region_internal, save_restriction_restore, Fformat)
5308 (transpose_markers, Ftranspose_regions):
5309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5310 (clip_to_bounds): Move to lisp.h as an inline function).
5311 (Fconstrain_to_field): Don't assume integers are nonnegative.
5312 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
5313 (Fsubst_char_in_region, Fsave_restriction):
5314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5315 (Femacs_pid): Don't assume pid_t fits into fixnum.
5316 (lo_time): Use int, not EMACS_INT, when int suffices.
5317 (lisp_time_argument): Check for usec out of range.
5318 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
5319 (Fuser_login_name, Fuser_full_name): Signal an error
5320 if a uid argument is out of range, rather than relying on
5321 undefined behavior.
c8d5c857
PE
5322 (Fformat_time_string): Remove now-unnecessary check.
5323 lisp_time_argument checks for out-of-range usec now.
243e0530 5324 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
5325 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
5326 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
5327 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
5328 (init_cmdargs, Fdump_emacs):
5329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5330 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
5331 the bottom (typically) 32 bits of the fixnum.
5332 * eval.c (specpdl_size, call_debugger):
5333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5334 (when_entered_debugger, Fbacktrace_debug):
5335 Don't assume fixnum can fit in int.
5336 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
5337 the object just before a buffer; this is not portable.
5338 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
5339 (grow_specpdl, unbind_to):
5340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5341 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
5342 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 5343 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
5344 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
5345 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
5346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5347 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
5348 (a_write, e_write):
5349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5350 (Fcopy_file, non_regular_nbytes, read_non_regular)
5351 (Finsert_file_contents):
5352 Use int, not EMACS_INT, where int is wide enough.
5353 (READ_BUF_SIZE): Verify that it fits in int.
5354 (Finsert_file_contents): Check that counts are in proper range,
5355 rather than assuming fixnums fit into ptrdiff_t etc.
5356 Don't assume fixnums fit into int.
125b3835 5357 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
5358 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
5359 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
5360 (string_char_to_byte, string_byte_to_char)
5361 (string_make_multibyte, string_to_multibyte)
5362 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
5363 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
5364 (substring_both, Fdelete, internal_equal, Ffillarray)
5365 (Fclear_string, mapcar1)
5366 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
5367 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
5368 (larger_vector, make_hash_table, maybe_resize_hash_table)
5369 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
5370 (Fmaphash, secure_hash):
5371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5372 (concat): Check for string index and length overflow.
5373 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
5374 (Frequire):
5375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5376 (larger_vector): New API (vec, incr_min, size_max) replaces old
5377 one (vec, new_size, init). This catches size overflow.
5378 INIT was removed because it was always Qnil.
5379 All callers changed.
5380 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
5381 the upper bound on a hash table index size.
5382 (make_hash_table, maybe_resize_hash_table): Use it.
5383 (secure_hash): Computer start_byte and end_byte only after
5384 they're known to be in ptrdiff_t range.
5385 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
5386 (Ffont_get_glyphs, Ffont_at):
5387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5388 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
5389 (Flist_fonts, Fopen_font):
5390 Don't assume fixnum can fit in int.
5391 (check_gstring): Don't assume index can fit in int.
5392 (font_match_p): Check that fixnum is a character, not a nonnegative
5393 fixnum, since the later code needs to stuff it into an int.
5394 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
5395 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
5396 conversion overflow issues.
5397 (Fopen_font): Check for integer out of range.
5398 (Ffont_get_glyphs): Don't assume index can fit in int.
5399 * font.h: Adjust decls to match defn changes elsewhere.
5400 * fontset.c (reorder_font_vector): Redo score calculation to avoid
5401 integer overflow.
5402 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
5403 printmax_t, where ptrdiff_t is wide enough.
5404 (Finternal_char_font):
5405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5406 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
5407 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
5408 (Fset_frame_position, x_set_frame_parameters)
5409 (x_set_line_spacing, x_set_border_width)
5410 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
5411 Check that fixnums are in proper range for system types.
5412 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
5413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5414 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
5415 Use SAFE_ALLOCA_LISP, not alloca.
5416 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
5417 intptr_t is wide enough.
5418 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
5419 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
5420 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
5421 Check for fixnum out of range.
5422 * ftfont.c (ftfont_list): Don't assume index fits in int.
5423 Check that fixnums are in proper range for system types.
5424 (ftfont_shape_by_flt):
5425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
5426 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5428 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
5429 Check that fixnums are in proper range for system types.
5430 * gnutls.h: Adjust decls to match defn changes elsewhere.
5431 * gtkutil.c (xg_dialog_run):
5432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5433 (update_frame_tool_bar):
5434 Check that fixnums are in proper range for system types.
5435 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 5436 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
5437 * indent.c (last_known_column, last_known_column_point):
5438 (current_column_bol_cache):
5439 (skip_invisible, current_column, check_display_width):
5440 (check_display_width, scan_for_column, current_column_1)
5441 (Findent_to, Fcurrent_indentation, position_indentation)
5442 (indented_beyond_p, Fmove_to_column, compute_motion):
5443 (Fcompute_motion, Fvertical_motion):
5444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5445 (last_known_column_modified): Use EMACS_INT, not int.
5446 (check_display_width):
5447 (Fcompute_motion):
5448 Check that fixnums and floats are in proper range for system types.
5449 (compute_motion): Don't assume index or fixnum fits in int.
5450 (compute_motion, Fcompute_motion):
5451 Use int, not EMACS_INT, when it is wide enough.
5452 (vmotion): Omit local var start_hpos that is always 0; that way
5453 we don't need to worry about overflow in expressions involving it.
5454 * indent.h: Adjust decls to match defn changes elsewhere.
5455 (struct position):
5456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5457 Use int, not EMACS_INT, where int is wide enough.
5458 Remove unused members ovstring_chars_done and tab_offset;
5459 all uses removed.
5460 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
5461 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
5462 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
5463 (make_gap, copy_text, insert, insert_and_inherit)
5464 (insert_before_markers, insert_before_markers_and_inherit)
5465 (insert_1, count_combining_before, count_combining_after)
5466 (insert_1_both, insert_from_string)
5467 (insert_from_string_before_markers, insert_from_string_1)
5468 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
5469 (adjust_after_replace, adjust_after_insert, replace_range)
5470 (replace_range_2, del_range, del_range_1, del_range_byte)
5471 (del_range_both, del_range_2, modify_region)
5472 (prepare_to_modify_buffer, signal_before_change)
5473 (signal_after_change, Fcombine_after_change_execute):
5474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5475 * intervals.c (traverse_intervals, rotate_right, rotate_left)
5476 (balance_an_interval, split_interval_right, split_interval_left)
5477 (find_interval, next_interval, update_interval)
5478 (adjust_intervals_for_insertion, delete_node, delete_interval)
5479 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5480 (static_offset_intervals, offset_intervals)
5481 (merge_interval_right, merge_interval_left, make_new_interval)
5482 (graft_intervals_into_buffer, temp_set_point_both)
5483 (temp_set_point, set_point, adjust_for_invis_intang)
5484 (set_point_both, move_if_not_intangible, get_property_and_range)
5485 (get_local_map, copy_intervals, copy_intervals_to_string)
5486 (compare_string_intervals, set_intervals_multibyte_1):
5487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5488 * intervals.h: Adjust decls to match defn changes elsewhere.
5489 (struct interval):
5490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5491 * keyboard.c (this_command_key_count, this_single_command_key_start)
5492 (before_command_key_count, before_command_echo_length, echo_now)
5493 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5494 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5495 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5496 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5497 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5498 (last_non_minibuf_size, last_point_position, echo_truncate)
5499 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5500 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5501 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5502 (stuff_buffered_input):
5503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5504 (last_auto_save, command_loop_1, read_char):
5505 Use EMACS_INT, not int, to avoid integer overflow.
5506 (record_char): Avoid overflow in total_keys computation.
5507 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5508 * keyboard.h: Adjust decls to match defn changes elsewhere.
5509 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5510 (Fkey_description, Fdescribe_vector, Flookup_key):
5511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5512 (click_position): New function, to check that positions are in range.
5513 (Fcurrent_active_maps):
5514 (describe_command):
5515 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5516 (Faccessible_keymaps, Fkey_description):
5517 (preferred_sequence_p):
5518 Don't assume fixnum can fit into int.
5519 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5520 Check for integer overflow in size calculations.
5521 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5522 avoid mishandling large integers.
5523 * lisp.h: Adjust decls to match defn changes elsewhere.
5524 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5525 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5526 (struct Lisp_Marker):
5527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5528 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5529 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5530 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5531 All callers changed.
5532 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5533 Assume the arg has valid form, since it always does.
5534 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5535 unsigned integer system type.
5536 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5537 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5539 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5540 (duration_to_sec_usec): New decl.
5541 * lread.c (read_from_string_index, read_from_string_index_byte)
5542 (read_from_string_limit, readchar, unreadchar, openp)
5543 (read_internal_start, read1, oblookup):
5544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5545 (Fload, readevalloop, Feval_buffer, Feval_region):
5546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5547 (openp): Check for out-of-range argument to 'access'.
5548 (read1): Use int, not EMACS_INT, where int is wide enough.
5549 Don't assume fixnum fits into int.
6efdadfd 5550 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5551 (read_filtered_event): Use duration_to_sec_usec
5552 to do proper overflow checking on durations.
d311d28c
PE
5553 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5554 in size calculation.
5555 (Fexecute_kbd_macro):
5556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5557 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5558 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5559 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5560 (set_marker_both, set_marker_restricted_both, marker_position)
5561 (marker_byte_position, Fbuffer_has_markers_at):
5562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5563 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5564 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5565 It now merely ensures that the menu is large enough, without
5566 necessarily growing it, as this avoids some integer overflow issues.
5567 All callers changed.
5568 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5570 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5571 Use SAFE_ALLOCA_LISP, not alloca.
5572 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5573 to EMACS_INT. Check that fixnums are in proper range for system types.
5574 * minibuf.c (minibuf_prompt_width, string_to_object)
5575 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5576 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5578 (get_minibuffer, read_minibuf_unwind):
5579 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5580 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5581 this simplifies overflow checking. All callers changed.
5582 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5583 (Ftest_completion):
5584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5585 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5586 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5587 Check that fixnums are in proper range for system types.
5588 (Fx_create_frame, Fx_show_tip):
5589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5590 * nsfont.m (ns_findfonts, nsfont_list_family):
5591 Don't assume fixnum fits in long.
5592 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5594 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5595 wide enough.
17fdb222 5596 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5598 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5599 (PRINTDECLARE, PRINTPREPARE):
5600 (strout, print_string):
5601 (print, print_preprocess, print_check_string_charset_prop)
5602 (print_object):
5603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5604 (PRINTDECLARE):
5605 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5607 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5608 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5609 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5610 (print_error_message): Use SAFE_ALLOCA, not alloca.
5611 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5612 (print_depth, new_backquote_output, print_number_index):
5613 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5614 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5615 (Fset_process_window_size, Fformat_network_address)
5616 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5617 (sigchld_handler):
d311d28c 5618 Check that fixnums are in proper range for system types.
d44287d4 5619 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5620 Check for process-ids out of pid_t range rather than relying on
5621 undefined behavior.
e4d81efc 5622 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5623 (Fformat_network_address, read_process_output, send_process)
5624 (Fprocess_send_region, status_notify):
5625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5626 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5627 (wait_reading_process_output, read_process_output, exec_sentinel):
5628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5629 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5630 (Faccept_process_output): Use duration_to_sec_usec to do proper
5631 overflow checking on durations.
dde14581
PE
5632 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5633 Don't assume pid_t fits in int.
02481186
PE
5634 * process.h (struct Lisp_Process): Members tick and update_tick
5635 are now of type EMACS_INT, not int.
b62b53e8
PE
5636 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5637 configured --with-wide-int.
d311d28c
PE
5638 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5639 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5640 * search.c (looking_at_1, string_match_1):
5641 (fast_string_match, fast_c_string_match_ignore_case)
5642 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5643 (scan_newline, find_before_next_newline, search_command)
5644 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5645 (set_search_regs, wordify):
5646 (Freplace_match):
5647 (Fmatch_data):
5648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5649 (string_match_1, search_buffer, set_search_regs):
5650 (Fmatch_data):
5651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5652 (wordify): Check for overflow in size calculation.
5653 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5654 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5655 Check that fixnums are in proper range for system types.
5656 * sound.c (struct sound_device)
5657 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5659 (Fplay_sound_internal):
5660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5661 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5662 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5663 (Fparse_partial_sexp):
5664 Don't assume fixnums can fit in int.
5665 (struct lisp_parse_state, find_start_pos, find_start_value)
5666 (find_start_value_byte, find_start_begv)
5667 (update_syntax_table, char_quoted, dec_bytepos)
5668 (find_defun_start, prev_char_comend_first, back_comment):
5669 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5670 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5672 (Finternal_describe_syntax_value): Check that match_lisp is a
5673 character, not an integer, since the code stuffs it into int.
5674 (scan_words, scan_sexps_forward):
5675 Check that fixnums are in proper range for system types.
5676 (Fforward_word):
5677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5678 (scan_sexps_forward):
5679 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5680 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5681 * syntax.h: Adjust decls to match defn changes elsewhere.
5682 (struct gl_state_s):
5683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5684 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5685 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5686 * sysdep.c (wait_for_termination_1, wait_for_termination)
5687 (interruptible_wait_for_termination, mkdir):
5688 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5689 (emacs_read, emacs_write):
5690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5691 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5692 and double all fit in int.
d311d28c
PE
5693 * term.c (set_tty_color_mode):
5694 Check that fixnums are in proper range for system types.
5695 * termhooks.h (struct input_event):
5696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5697 * textprop.c (validate_interval_range, interval_of)
5698 (Fadd_text_properties, set_text_properties_1)
5699 (Fremove_text_properties, Fremove_list_of_text_properties)
5700 (Ftext_property_any, Ftext_property_not_all)
5701 (copy_text_properties, text_property_list, extend_property_ranges)
5702 (verify_interval_modification):
5703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5704 (Fnext_single_char_property_change)
5705 (Fprevious_single_char_property_change):
5706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5707 (copy_text_properties):
5708 Check for integer overflow in index calculation.
d311d28c
PE
5709 * undo.c (last_boundary_position, record_point, record_insert)
5710 (record_delete, record_marker_adjustment, record_change)
5711 (record_property_change):
5712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5713 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5715 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5716 (Fx_hide_tip, Fx_file_dialog):
5717 * w32menu.c (set_frame_menubar):
5718 Use ptrdiff_t, not int, for consistency with rest of code.
5719 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5720 (select_window, Fdelete_other_windows_internal)
5721 (window_scroll_pixel_based, window_scroll_line_based)
5722 (Frecenter, Fset_window_configuration):
5723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5724 (Fset_window_hscroll, run_window_configuration_change_hook)
5725 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5726 (Fscroll_other_window, Frecenter):
d311d28c
PE
5727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5728 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5729 Don't assume fixnum fits in int.
5730 (Fset_window_scroll_bars):
5731 Check that fixnums are in proper range for system types.
5732 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5733 (string_pos, c_string_pos, number_of_chars, init_iterator)
5734 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5735 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5736 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5737 (face_before_or_after_it_pos, handle_invisible_prop)
5738 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5739 (display_prop_intangible_p, string_buffer_position_lim)
5740 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5741 (get_overlay_strings_1, get_overlay_strings)
5742 (iterate_out_of_display_property, forward_to_next_line_start)
5743 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5744 (get_next_display_element, set_iterator_to_next)
5745 (get_visually_first_element, compute_stop_pos_backwards)
5746 (handle_stop_backwards, next_element_from_buffer)
5747 (move_it_in_display_line_to, move_it_in_display_line)
5748 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5749 (add_to_log, message_dolog, message_log_check_duplicate)
5750 (message2, message2_nolog, message3, message3_nolog
5751 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5752 (current_message_1, truncate_echo_area, truncate_message_1)
5753 (set_message, set_message_1, store_mode_line_noprop)
5754 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5755 (text_outside_line_unchanged_p, check_point_in_composition)
5756 (reconsider_clip_changes)
5757 (redisplay_internal, set_cursor_from_row, try_scrolling)
5758 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5759 (redisplay_window, find_last_unchanged_at_beg_row)
5760 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5761 (trailing_whitespace_p, find_row_edges, display_line)
5762 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5763 (display_mode_element, store_mode_line_string)
5764 (pint2str, pint2hrstr, decode_mode_spec)
5765 (display_count_lines, display_string, draw_glyphs)
5766 (x_produce_glyphs, x_insert_glyphs)
5767 (rows_from_pos_range, mouse_face_from_buffer_pos)
5768 (fast_find_string_pos, mouse_face_from_string_pos)
5769 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5771 (safe_call, init_from_display_pos, handle_fontified_prop)
5772 (handle_single_display_spec, load_overlay_strings)
5773 (with_echo_area_buffer, setup_echo_area_for_printing)
5774 (display_echo_area, echo_area_display)
5775 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5776 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5777 (redisplay_window, dump_glyph_row, display_mode_line)
5778 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5779 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5781 (handle_single_display_spec, build_desired_tool_bar_string)
5782 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5783 (get_specified_cursor_type):
5784 Check that fixnums are in proper range for system types.
5785 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5786 (Flookup_image_map):
5787 Don't assume fixnums fit in int.
5788 (compare_overlay_entries):
5789 Avoid mishandling comparisons due to subtraction overflow.
5790 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5791 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5792 (handle_tool_bar_click):
5793 Use int, not unsigned, since we prefer signed and the signedness
5794 doesn't matter here.
5795 (get_next_display_element, next_element_from_display_vector):
5796 Use int, not EMACS_INT, when int is wide enough.
5797 (start_hourglass): Use duration_to_sec_usec to do proper
5798 overflow checking on durations.
5799 * xfaces.c (Fbitmap_spec_p):
5800 Check that fixnums are in proper range for system types.
5801 (compare_fonts_by_sort_order):
5802 Avoid mishandling comparisons due to subtraction overflow.
5803 (Fx_family_fonts, realize_basic_faces):
5804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5805 (Fx_family_fonts):
5806 Don't assume fixnum fits in int.
5807 Use SAFE_ALLOCA_LISP, not alloca.
5808 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5809 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5810 (face_at_buffer_position, face_for_overlay_string)
5811 (face_at_string_position):
5812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5813 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5814 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5815 (Fx_show_tip):
5816 Check that fixnums are in proper range for system types.
5817 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5818 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5820 (Fx_change_window_property): Don't assume fixnums fit in int.
5821 * xfont.c (xfont_chars_supported):
5822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5823 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5824 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5826 * xml.c (parse_region):
5827 * xrdb.c (magic_file_p):
5828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5829 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5830 (x_get_local_selection, x_reply_selection_request)
5831 (x_handle_selection_request, wait_for_property_change):
5832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5833 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5834 short is wide enough.
5835 (x_send_client_event): Don't assume fixnum fits in int.
5836 * xterm.c (x_x_to_emacs_modifiers):
5837 Don't assume EMACS_INT overflows nicely into int.
5838 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5839 may come from Lisp.
5840 (handle_one_xevent): NATNUMP can eval its arg twice.
5841 (x_connection_closed):
5842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5843 * xterm.h: Adjust decls to match defn changes elsewhere.
5844 (struct scroll_bar): Use struct vectorlike_header
5845 rather than rolling our own approximation.
5846 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5847
c6574eb5
GM
58482012-05-25 Glenn Morris <rgm@gnu.org>
5849
5850 * lisp.mk (lisp): Update for more files being compiled now.
5851
e8d32c7e
SM
58522012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5853
48def666
SM
5854 * lread.c: Remove `read_pure' which makes no difference.
5855 (read_pure): Remove var.
5856 (unreadpure): Remove function.
5857 (readevalloop): Don't call read_list with -1 flag.
5858 (read1, read_vector): Don't test read_pure any more.
5859 (read_list): Simplify.
5860
e8d32c7e
SM
5861 * fileio.c, character.h: Minor style tweaks.
5862
4b2addb7
DA
58632012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5864
5865 * window.h (clip_changed): Remove useless declaration.
5866
584461b2
JB
58672012-05-22 Juanma Barranquero <lekktu@gmail.com>
5868
5869 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5870 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5871
34374650
PE
58722012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5873
5874 Remove src/m/*.
5875 This directory predates autoconf and is no longer needed nowadays.
5876 Move its few remaining bits of functionality to where they're needed.
5877 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5878 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5879 * m/template.h: Remove.
5880 * Makefile.in (M_FILE): Remove. All uses removed.
5881 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5882 * lisp.h (USE_LSB_TAG):
5883 * mem-limits.h (EXCEEDS_LISP_PTR):
5884 Use VAL_MAX, not VALBITS, in #if.
5885 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5886 (EMACS_UINT): Define unconditionally now.
5887 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5888 (BITS_PER_EMACS_INT): New constants, replacing
5889 what used to be in config.h, but not useful in #if.
5890 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5891 define them any more.
5892 (VAL_MAX): New macro.
5893 (VALMASK): Use it.
5894 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5895 BITS_PER_EMACS_INT, in #if.
5896 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5897 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5898 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5899 * s/ms-w32.h (DATA_START):
5900 Move here from removed file m/intel386.h.
5901 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5902 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5903
261cb4bb
PE
59042012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5905
5906 Assume C89 or later.
5907 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5908 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5909 (xrealloc):
5910 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5911 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5912 * textprop.c, tparam.c (NULL): Remove.
5913 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5914 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5915 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5916 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5917 * xterm.c (input_signal_count): Assume volatile works.
5918
ff23cd9f
KB
59192012-05-21 Ken Brown <kbrown@cornell.edu>
5920
5921 * xgselect.c (xg_select): Fix first argument in call to 'select'
5922 (bug#11508).
5923
1b170bc6
KB
59242012-05-20 Ken Brown <kbrown@cornell.edu>
5925
5926 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5927 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5928
b2f4d39f
KB
59292012-05-19 Ken Brown <kbrown@cornell.edu>
5930
5931 * xfns.c (x_in_use): Remove `static' qualifier.
5932 * xterm.h (x_in_use): Declare.
5933 * xgselect.c: Include xterm.h.
5934 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5935 and `display_arg' (bug#9754).
5936
003fdae2
PE
59372012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5938
9232a6d9
PE
5939 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5940
003fdae2
PE
5941 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5942 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5943
784b56e2
EZ
59442012-05-18 Eli Zaretskii <eliz@gnu.org>
5945
5946 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5947
5948 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5949 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5950
5951 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5952 reference to image_cache->refcount.
5953 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5954
a0a79cde
JL
59552012-05-17 Juri Linkov <juri@jurta.org>
5956
5957 * search.c (Fword_search_regexp, Fword_search_backward)
5958 (Fword_search_forward, Fword_search_backward_lax)
5959 (Fword_search_forward_lax): Move functions to isearch.el
5960 (bug#10145, bug#11381).
5961
b0572523
PE
59622012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5963
5964 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5965
9660f5fc
SM
59662012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5967
5968 * lread.c (init_obarray): Declare Qt and Qnil as special.
5969
4374de83
GM
59702012-05-14 Glenn Morris <rgm@gnu.org>
5971
5972 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5973 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5974
dc44c39a
PE
59752012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5976
078c97cb
PE
5977 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5978
dc44c39a
PE
5979 * unexaix.c: Port to more-recent AIX compilers.
5980 (report_error, report_error_1, make_hdr, copy_sym)
5981 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5982 Make arguments const char *, not char *, to avoid violations of C
5983 standard and to fix some AIX warnings reported by Gilles Pion.
5984
e18afed7 59852012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5986
5987 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5988 already have overlays loaded.
5989 (handle_single_display_spec): Before returning without displaying
5990 fringe bitmap, synchronize the bidi iterator with the main display
5991 iterator, by calling iterate_out_of_display_property.
5992 (iterate_out_of_display_property): Detect buffer iteration by
5993 testing that it->string is a Lisp string.
5994 (get_next_display_element): When the current object is exhausted,
5995 and there's something on it->stack, call set_iterator_to_next to
5996 proceed with what's on the stack, instead of returning zero.
5997 (set_iterator_to_next): If called at the end of a Lisp string,
5998 proceed to consider_string_end without incrementing string
5999 position. Don't increment display vector index past the end of
6000 the display vector. (Bug#11417)
c8fb9dc6
EZ
6001 (pos_visible_p): Don't report a position visible when move_it_to
6002 stopped at the last line of window, which happens to be scanned
6003 backwards by the bidi iteration. (Bug#11464)
ac268e67 6004
e18afed7 60052012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6006
6007 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6008 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6009 are on a TTY, and thus unable to display on the fringes.
6010 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6011 so we need to signal to the caller that this is a "replacing"
6012 display spec. This fixes display when the spec is invalid or we
6013 are on a TTY.
6014
e18afed7 60152012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6016
6017 * unexaix.c (make_hdr): Fix typo in prototype.
6018 This bug broke the build on AIX. Problem reported by Gilles Pion.
6019
9d0a235a
MA
60202012-05-14 Michael Albinus <michael.albinus@gmx.de>
6021
6022 * keyboard.c (kbd_buffer_get_event): Read special events also in
6023 batch mode. (Bug#11415)
6024
9e6b06ed
GM
60252012-05-12 Glenn Morris <rgm@gnu.org>
6026
6027 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6028
c1a1d7a3
EZ
60292012-05-12 Eli Zaretskii <eliz@gnu.org>
6030
6031 * lisp.mk (lisp): Add newcomment.elc.
6032
3fe7cdc8
GM
60332012-05-12 Glenn Morris <rgm@gnu.org>
6034
6035 * Makefile.in (MKDIR_P): New, set by configure.
6036 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6037
53f7d2c0
PE
60382012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6039
6040 Remove unused function hourglass_started.
6041 * dispextern.h (hourglass_started):
6042 * w32fns.c (hourglass_started):
6043 * xdisp.c (hourglass_started): Remove.
6044
75aafb17
JB
60452012-05-10 Juanma Barranquero <lekktu@gmail.com>
6046
6047 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6048 Update dependencies.
6049
12959e8e
PE
60502012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6051
97107e2e
PE
6052 * xgselect.c (xg_select): Put maxfds+1 into a var.
6053 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6054
12959e8e
PE
6055 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6056
836d29b3
DA
60572012-05-10 Dave Abrahams <dave@boostpro.com>
6058
6059 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6060 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6061
5cb67954
MA
60622012-05-09 Michael Albinus <michael.albinus@gmx.de>
6063
6064 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6065 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6066 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6067 Initialize xd_registered_buses.
6068
3478ec45
PE
60692012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6070
b263a6b0
PE
6071 Untag more efficiently if USE_LSB_TAG.
6072 This is based on a proposal by YAMAMOTO Mitsuharu in
6073 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6074 For an admittedly artificial (nth 8000 longlist) benchmark on
6075 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6076 Emacs's overall text size by 1%.
6077 * lisp.h (XUNTAG): New macro.
6078 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6079 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6080 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6081 * eval.c (Fautoload):
6082 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6083 * frame.h (XFRAME): Use XUNTAG.
6084
3478ec45
PE
6085 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6086 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6087 Remove unportable assumptions about print widths of types like
6088 dbus_uint32_t.
6089 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6090 intptr_t when converting between pointer and integer, to avoid GCC
6091 warnings about wrong width.
6092
666b903b 60932012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6094
6095 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6096 stack for each reader_thread, instead of defaulting to 8MB
6097 determined by the linker. This avoids failures in creating
6098 subprocesses on Windows 7, see the discussion in this thread:
6099 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6100
b120cc17
JC
61012012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6102
6103 Fix up display of the *Minibuf-0* buffer in the mini window.
6104 * keyboard.c (read_char): Don't clear the echo area if there's no
6105 message to clear.
6106 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6107 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6108
9a4b36f8
MA
61092012-05-07 Michael Albinus <michael.albinus@gmx.de>
6110
6111 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6112 batch mode.
6113
e5f9458f
CY
61142012-05-06 Chong Yidong <cyd@gnu.org>
6115
6116 * lisp.mk (lisp): Update.
6117
eceeb5fc 61182012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6119
6120 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6121
71873e2b
SM
61222012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6123
6124 * data.c (PUT_ERROR): New macro.
6125 (syms_of_data): Use it. Add new error type `user-error'.
6126 * undo.c (user_error): New function.
6127 (Fprimitive_undo): Use it.
6128 * print.c (print_error_message): Adjust print style for `user-error'.
6129 * keyboard.c (user_error): New function.
6130 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6131
ab0fa4e4
PE
61322012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6133
6134 Do not limit current-time-string to years 1000..9999.
6135 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6136 (Fcurrent_time_string): Support any year that is supported by the
6137 underlying localtime representation. Don't use asctime, as it
6138 has undefined behavior for years outside the range -999..9999.
6139
7ed806a7
PE
61402012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6141
6142 Fix race conditions involving setenv, gmtime, localtime, asctime.
6143 Without this fix, interrupts could mess up code that uses these
6144 nonreentrant functions, since setting TZ invalidates existing
6145 tm_zone or tzname values, and since most of these functions return
6146 pointers to static storage.
6147 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6148 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6149 Grow the critical sections to include not just invoking
6150 localtime/gmtime, but also accessing these functions' results
6151 including their tm_zone values if any, and any related TZ setting.
6152 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6153 so that the struct tm is saved in the critical section.
6154 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6155 motivated by the fact that memory allocation needs to be outside
6156 the critical section.
6157
0c16dfed
DA
61582012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6159
6160 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6161 with RESET_INTERVAL.
6162
6163 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6164 Remove duplicated buffer name initialization.
6165
3f83ace8
JM
61662012-05-02 Jim Meyering <jim@meyering.net>
6167
6168 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6169
c7b8541e
JM
6170 * xfns.c (x_window): Use xstrdup (Bug#11375).
6171
90207a15 61722012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6173
6174 * xdisp.c (pos_visible_p): If already at a newline from the
6175 display string before the 'while' loop, don't walk back the glyphs
6176 from it3.glyph_row. Solves assertion violation when the display
6177 string begins with a newline (egg.el). (Bug#11367)
6178
b593d6a9
AH
61792012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6180
6181 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6182 Move to simple.el.
6183
4737362e
GM
61842012-05-01 Glenn Morris <rgm@gnu.org>
6185
99cf43f9
GM
6186 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6187 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6188 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6189 All were removed before 23.1.
6190
9311dcff
GM
6191 * dispnew.c: Remove HAVE_LIBNCURSES test;
6192 it is always true on relevant platforms.
6193
4d5c6349
GM
6194 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6195 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6196
4737362e
GM
6197 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6198
74dd3a6b
AS
61992012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6200
6201 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6202 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6203 Remove.
6204
13c379ee
PE
62052012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6206
6207 Do not avoid creating empty evaporating overlays (Bug#9642).
6208 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
6209 That is, do not delete an evaporating overlay if it becomes
6210 empty after its bounds are adjusted to fit within its buffer.
6211 This fix caused other problems, and I'm reverting it until we get
6212 to the bottom of them.
6213
a8e7d6d7 62142012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
6215
6216 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
6217
a8e7d6d7 62182012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6219
6220 * xdisp.c (pos_visible_p): If the window start position is beyond
6221 ZV, start the display from buffer beginning. Prevents assertion
6222 violation in init_iterator when the minibuffer window is scrolled
6223 via the scroll bar.
6224
6225 * window.c (window_scroll_pixel_based): Likewise.
6226
a8e7d6d7 62272012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
6228
6229 * keymap.c (where_is_internal): Doc fix (Bug#10872).
6230
a8e7d6d7 62312012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
6232
6233 * fileio.c (Fcopy_file, Fset_file_selinux_context):
6234 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6235
a8e7d6d7 62362012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 6237
b593d6a9
AH
6238 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
6239 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 6240
1c6900d9
EZ
62412012-04-26 Eli Zaretskii <eliz@gnu.org>
6242
4c3fa1d9
EZ
6243 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
6244 display element, check also the underlying string or buffer
6245 character. (Bug#11341)
6246
1c6900d9
EZ
6247 * w32menu.c: Include w32heap.h.
6248 (add_menu_item): If the call to AppendMenuW (via
6249 unicode_append_menu) fails, disable Unicode menus only if we are
6250 running on Windows 9X/Me.
6251
42bf8205
AS
62522012-04-24 Andreas Schwab <schwab@linux-m68k.org>
6253
6254 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
6255 (xgetint): Add missing shift for LSB tags.
6256
b1bac16e
MR
62572012-04-24 Martin Rudalics <rudalics@gmx.at>
6258
6259 * keyboard.c (read_char): Don't wipe echo area for select window
6260 events: These might get delayed via `mouse-autoselect-window'
6261 (Bug#11304).
6262
d69621cc
JB
62632012-04-24 Juanma Barranquero <lekktu@gmail.com>
6264
6265 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
6266 manipulation of :loaded-from data.
6267
02fd101b
JB
62682012-04-23 Juanma Barranquero <lekktu@gmail.com>
6269
6270 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
6271 now a cons (bug#11311).
6272
888bec30
PE
62732012-04-23 Paul Eggert <eggert@cs.ucla.edu>
6274
89a438bd
PE
6275 Do not create empty overlays with the evaporate property (Bug#9642).
6276 * buffer.c (Fmove_overlay): Delete an evaporating overlay
6277 if it becomes empty after its bounds are adjusted to fit within
6278 its buffer. Without this fix, in a nonempty buffer (let ((o
6279 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
6280 yields an empty overlay that has the evaporate property, which is
6281 not supposed to happen.
6282
1068fe4d
PE
6283 Fix minor GTK3 problems found by static checking.
6284 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6285 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6286 (struct _EmacsFixedClass, emacs_fixed_get_type):
6287 Move decls here from emacsgtkfixed.h, since they needn't be public.
6288 (emacs_fixed_get_type): Now static.
6289 (emacs_fixed_class_init): Omit unused local.
6290 (emacs_fixed_child_type): Remove; unused.
6291 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6292 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6293 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
6294 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
6295 (EMACS_FIXED_GET_CLASS): Remove; unused.
6296 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
6297
888bec30
PE
6298 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
6299 Problem reported by Juanma Barranquero for Windows -Wunused-function.
6300
de85e130
PE
63012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6302
d0baac98 6303 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 6304 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
6305 (__malloc_size_t, __malloc_ptrdiff_t):
6306 Remove. All uses removed, replaced by the definiens if needed,
6307 since we can assume C89 or better now.
6308 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
6309 (protect_malloc_state, align, get_contiguous_space)
6310 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
6311 (malloc_atfork_handler_child, malloc_enable_thread)
6312 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
6313 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
6314 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
6315 (special_realloc, _realloc_internal_nolock, _realloc_internal)
6316 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
6317 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
6318 Define using prototypes, not old style.
6319 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
6320 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
6321 (align): Don't assume that signed integer overflow wraps around.
6322 Omit unused local var.
6323 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
6324 (_free_internal_nolock, memalign, mallochook, reallochook):
6325 Omit no-longer-needed casts.
6326 (valloc): Use getpagesize, not __getpagesize.
6327 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
6328 (struct hdr): The 'magic' member is now size_t, not unsigned long.
6329
de85e130
PE
6330 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
6331
dcbf5805
MA
63322012-04-22 Michael Albinus <michael.albinus@gmx.de>
6333
6334 Move functions from C to Lisp. Make non-blocking method calls
6335 the default. Implement further D-Bus standard interfaces.
6336
6337 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
6338 (QCdbus_request_name_allow_replacement)
6339 (QCdbus_request_name_replace_existing)
6340 (QCdbus_request_name_do_not_queue)
6341 (QCdbus_request_name_reply_primary_owner)
6342 (QCdbus_request_name_reply_in_queue)
6343 (QCdbus_request_name_reply_exists)
6344 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
6345 (QCdbus_registered_serial, QCdbus_registered_method)
6346 (QCdbus_registered_signal): New Lisp objects.
6347 (XD_DEBUG_MESSAGE): Use sizeof.
6348 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
6349 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
6350 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
6351 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
6352 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
6353 (xd_signature, xd_append_arg): Allow float for integer types.
6354 (xd_get_connection_references): New function.
b593d6a9
AH
6355 (xd_get_connection_address): Rename from xd_initialize.
6356 Return cached address.
dcbf5805
MA
6357 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
6358 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
6359 level.
6360 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 6361 Return number of refcounts.
dcbf5805
MA
6362 (Fdbus_get_unique_name): Make stronger parameter check.
6363 (Fdbus_message_internal): New defun.
6364 (Fdbus_call_method, Fdbus_call_method_asynchronously)
6365 (Fdbus_method_return_internal, Fdbus_method_error_internal)
6366 (Fdbus_send_signal, Fdbus_register_service)
6367 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
6368 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
6369 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
6370 (Vdbus_compiled_version, Vdbus_runtime_version)
6371 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
6372 (Vdbus_message_type_method_return, Vdbus_message_type_error)
6373 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
6374 (Vdbus_registered_buses, Vdbus_registered_objects_table):
6375 Adapt docstring.
dcbf5805 6376
52828e02
PE
63772012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6378
da05bc4c
PE
6379 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
6380 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
6381 Do not assume ptrdiff_t is the same width as 'int'.
6382
52828e02
PE
6383 * alloc.c: Handle unusual debugging option combinations.
6384 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
6385 since the two debugging options are incompatible.
6386 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
6387 is defined.
6388 (mem_init, mem_insert, mem_insert_fixup):
6389 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
6390 (NEED_MEM_INSERT): Remove; no longer needed.
6391
f01769f9
LL
63922012-04-22 Leo Liu <sdl.web@gmail.com>
6393
6394 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
6395
5790543d
PE
63962012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6397
6398 * sysdep.c [__FreeBSD__]: Minor cleanups.
6399 (list_system_processes, system_process_attributes) [__FreeBSD__]:
6400 Use Emacs indenting style more consistently. Avoid some casts.
6401 Use 'double' consistently rather than mixing 'float' and 'double'.
6402
b91b7e4d
EW
64032012-04-21 Eduard Wiebe <usenet@pusto.de>
6404
b593d6a9
AH
6405 * sysdep.c (list_system_processes, system_process_attributes):
6406 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 6407
6114eb15
AS
64082012-04-21 Andreas Schwab <schwab@linux-m68k.org>
6409
6410 * lisp.mk (lisp): Update.
6411
2f38dff7
PE
64122012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6413
6414 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
6415 It is never used otherwise.
6416
4ae29f89
SM
64172012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
6418
6419 * print.c (print_preprocess): Only check print_depth if print-circle
6420 is nil.
6421 (print_object): Check for cycles even when print-circle is nil and
6422 print-gensym is t, but only check print_depth if print-circle is nil.
6423
f30d612a
CY
64242012-04-20 Chong Yidong <cyd@gnu.org>
6425
6426 * process.c (wait_reading_process_output): If EIO occurs on a pty,
6427 set the status to "failed" and ensure that sentinel is run.
6428
c07a4c0b 64292012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
6430
6431 * process.c (Fset_process_inherit_coding_system_flag)
6432 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 6433 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 6434
c07a4c0b 64352012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
6436
6437 * xdisp.c (string_buffer_position_lim): Limit starting position to
6438 BEGV.
6439 (set_cursor_from_row): If called for a mode-line or header-line
6440 row, return zero immediately.
6441 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
6442 farther than the first row after the header line, if any.
6443 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
6444 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
6445
c07a4c0b 64462012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6447
4ae29f89
SM
6448 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
6449 (bug#11238).
ad3a2b41 6450
c07a4c0b 64512012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 64522012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
6453
6454 configure: new option --enable-gcc-warnings (Bug#11207)
6455 * Makefile.in (C_WARNINGS_SWITCH): Remove.
6456 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6457 (ALL_CFLAGS): Use new macros rather than old.
6458 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
6459 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
6460 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
6461 -Wunused-result, -Wunused-variable. This should go away once
6462 the Emacs and Gnulib regex code is merged.
6463 (xmalloc, xrealloc): Now static.
6464
aba027e8
PE
64652012-04-17 Paul Eggert <eggert@cs.ucla.edu>
6466
6467 * dired.c (Fsystem_groups): Remove unused local.
6468
e5a36063
GM
64692012-04-17 Glenn Morris <rgm@gnu.org>
6470
6471 * dired.c (Fsystem_users): Doc fix.
6472
316411f0
DA
64732012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6474
6475 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
6476 (syms_of_dired): Add them.
6477
9426aba4
PE
64782012-04-16 Paul Eggert <eggert@cs.ucla.edu>
6479
b62a57be
PE
6480 Fix minor alloc.c problems found by static checking.
6481 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
6482 New extern decls, to avoid calling undeclared functions.
6483 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
6484 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
6485 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6486 (NEED_MEM_INSERT): New macro.
6487 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6488 Remove one incorrect comment and fix another.
b62a57be 6489
3539f31f
PE
6490 Fix minor ralloc.c problems found by static checking.
6491 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6492 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6493 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6494 (r_alloc_sbrk): Now static.
6495
a041960a
PE
6496 Improve ralloc.c interface checking.
6497 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6498 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6499 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6500 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6501 [REL_ALLOC]: ... to here, to check interface.
6502 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6503 Remove decls. This fixes an "It stinks!".
6504
9426aba4
PE
6505 * alloc.c (which_symbols): Fix alignment issue / type clash.
6506
d55c12ed
AS
65072012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6508
6509 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6510 (struct Lisp_Misc_Any): Likewise.
6511 (struct Lisp_Free): Likewise.
6512 * alloc.c (union aligned_Lisp_Symbol): Define.
6513 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6514 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6515 (union aligned_Lisp_Misc): Define.
6516 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6517 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6518 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6519
b948ce8b
PE
65202012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6521
6522 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6523 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6524 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6525 * s/netbsd.h, s/sol2-6.h:
6526 Remove definition of GC_MARK_STACK, since the default now works.
6527 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6528 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6529 no longer the default.
6530 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6531
35dc09a1 65322012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6533
35dc09a1
GM
6534 * lread.c (lisp_file_lexically_bound_p):
6535 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6536
35dc09a1
GM
65372012-04-14 Eli Zaretskii <eliz@gnu.org>
6538
6539 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6540 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6541
65422012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6543
6544 * nsterm.m (constrainFrameRect): Always constrain when there is only
6545 one screen (Bug#10962).
6546
bcd86815
KB
65472012-04-13 Ken Brown <kbrown@cornell.edu>
6548
6549 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6550
c25df26e
RT
65512012-04-13 Reuben Thomas <rrt@sc3d.org>
6552
6553 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6554
0fc59f1e
DC
65552012-04-11 Daniel Colascione <dancol@dancol.org>
6556
6557 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6558 against is gone. It's better to use vfork now so that when Cygwin
6559 gains a new, working vfork, we use it automatically (bug#10398).
6560
de8c03dc
SM
65612012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6562
6563 * window.c (save_window_save): Obey window-point-insertion-type.
6564
2f097256
GM
65652012-04-11 Glenn Morris <rgm@gnu.org>
6566
6567 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6568
453b951e
SM
65692012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6570
6571 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6572
75f1671a 65732012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6574
6575 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6576 (force_quit_count): New var.
6577 (handle_interrupt): Use it.
6578
2a8ce227
JB
65792012-04-10 Juanma Barranquero <lekktu@gmail.com>
6580
6581 * w32.c (w32_delayed_load): Record the full path of the library
6582 being loaded (bug#10424).
6583
935396c0
GM
65842012-04-09 Glenn Morris <rgm@gnu.org>
6585
05920a43
GM
6586 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6587 not just in the obarray, before snarfing them. (Bug#11036)
6588
935396c0
GM
6589 * Makefile.in ($(leimdir)/leim-list.el):
6590 Pass EMACS rather than BUILT_EMACS.
6591
a18ecafa
TZ
65922012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6593
6594 * process.c (make_process):
6595 * process.h: Add integer `gnutls_handshakes_tried' member to
6596 process struct.
6597
6bbef4e5
JC
6598 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6599 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6600
6601 * gnutls.c (gnutls_log_function2i): Convenience log function.
6602 (emacs_gnutls_read): Use new log functions,
6603 `gnutls_handshakes_tried' process member, and
6604 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6605 attempts per process (connection).
6606
b4d3bc10
CY
66072012-04-09 Chong Yidong <cyd@gnu.org>
6608
6609 * eval.c (Fuser_variable_p, user_variable_p_eh)
6610 (lisp_indirect_variable): Functions deleted.
6611 (Fdefvar): Caller changed.
6612
6613 * callint.c (Finteractive, Fcall_interactively):
6614 * minibuf.c (Fread_variable): Callers changed.
6615
70f4d973
EZ
66162012-04-09 Eli Zaretskii <eliz@gnu.org>
6617
6618 * xdisp.c (set_cursor_from_row): If the display string appears in
6619 the buffer at position that is closer to point than the position
6620 after the display string, display the cursor on the first glyph of
6621 the display string. Fixes cursor display when a 'display' text
6622 property immediately follows invisible text. (Bug#11094)
6623
cb3c2e3e
PE
66242012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6625
6626 composite.c: use 'double' consistently
6627 * composite.c (get_composition_id): Use 'double' consistently
6628 instead of converting 'float' to 'double' and vice versa; this is
6629 easier to understand and avoids a GCC warning.
6630
fd06db5d
GM
66312012-04-09 Glenn Morris <rgm@gnu.org>
6632
50fe702a
GM
6633 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6634 preparation for dumping it with emacs. (Bug#4789)
6635 (leimdir): New variable.
6636 ($(leimdir)/leim-list.el): New rule.
6637 (emacs$(EXEEXT)): Depend on leim-list.el.
6638
fd06db5d
GM
6639 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6640 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6641 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6642
55c131ee
AS
66432012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6644
6645 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6646 proper alignment.
6647
9209588f
JB
66482012-04-07 Juanma Barranquero <lekktu@gmail.com>
6649
6650 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6651 Remove unused local variable.
6652
e3fb2efb
PE
66532012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6654
6655 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6656 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6657 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6658 objects, as mark_maybe_pointer will catch them otherwise.
6659 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6660 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6661
b5385551
PE
66622012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6663
6664 Fix typo that broke non-Windows builds.
6665 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6666
9078ead6
EZ
66672012-04-07 Eli Zaretskii <eliz@gnu.org>
6668
6669 Support building on MS-Windows with libxml2.
6670
6671 * makefile.w32-in (OBJ2): Add xml.$(O).
6672 (GLOBAL_SOURCES): Add xml.c.
6673 ($(BLD)/xml.$(O)): New dependency list.
6674
6675 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6676 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6677 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6678 [!WINDOWSNT]: New macros.
6679 (init_libxml2_functions, libxml2_loaded_p): New functions.
6680 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6681 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6682 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6683 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6684 linked in).
6bbef4e5
JC
6685 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6686 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6687 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6688
6689 * emacs.c: Don't include libxml/parser.h.
6690 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6691 xmlCleanupParser directly.
6692
6693 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6694
3811fdf3
EZ
66952012-04-07 Eli Zaretskii <eliz@gnu.org>
6696
6697 * indent.c (Fvertical_motion): If there is a display string at
6698 point, use it.vpos to compute how many lines to backtrack after
6699 move_it_to point. (Bug#11133)
6700
2f8e16b2
EZ
67012012-04-06 Eli Zaretskii <eliz@gnu.org>
6702
6703 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6704 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6705 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6706 macros related to unification of CJK characters. For the details,
6707 see the discussion following the message here:
6708 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6709
3d439cd1
CY
67102012-04-04 Chong Yidong <cyd@gnu.org>
6711
6712 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6713
8bc53d00
EZ
67142012-04-01 Eli Zaretskii <eliz@gnu.org>
6715
6716 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6717 instead of alloca. (Bug#11138)
6718
3b0512a3
AS
67192012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6720
6721 * w32menu.c (is_simple_dialog): Properly check lisp types.
6722 (Bug#11141)
6723
8427ddd2
EZ
67242012-03-31 Eli Zaretskii <eliz@gnu.org>
6725
979022ef
EZ
6726 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6727 position we get to after a call to move_it_to fails the
6728 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6729 only if we wind up in a string from display property. (Bug#11063)
6730
a6b1c7cc
EZ
6731 * window.c (Fdelete_other_windows_internal): Invalidate the row
6732 and column information about mouse highlight, so that redisplay
6733 restores it after reallocating the glyph matrices. (Bug#7464)
6734
8427ddd2
EZ
6735 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6736 string comes from a `display' text property, use the buffer
6737 position of that property as if we actually saw that position in
6738 the row's glyphs.
697ba24b
EZ
6739 (move_it_by_lines): Remove the assertion that
6740 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6741 violated when there's a before-string at the beginning of a line.
6742 (Bug#11063)
8427ddd2 6743
65a0a738
EZ
67442012-03-30 Eli Zaretskii <eliz@gnu.org>
6745
6746 * xdisp.c (append_space_for_newline): If the default face was
6747 remapped, use the remapped face for the appended newline.
6748 (extend_face_to_end_of_line): Use the remapped default face for
6749 extending the face to the end of the line.
6750 (display_line): Call extend_face_to_end_of_line when the default
6751 face was remapped. (Bug#11068)
6752
581355cc
EZ
67532012-03-29 Eli Zaretskii <eliz@gnu.org>
6754
6755 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6756
e8fc049f
SM
67572012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6758
6759 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6760
4fb9a543
GM
67612012-03-27 Glenn Morris <rgm@gnu.org>
6762
6763 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6764 Doc fixes.
6765
679910f1
KH
67662012-03-26 Kenichi Handa <handa@m17n.org>
6767
6768 * dispextern.h (struct glyph): Fix previous change. Change the
6769 bit length of glyphless.ch to 25 (Bug#11082).
6770
90d49b7f
CY
67712012-03-26 Chong Yidong <cyd@gnu.org>
6772
6773 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6774 (command_loop_1): Use it; inhibit selection update for
6775 handle-select-window too (Bug#8996).
6776
f514f6f0
FP
67772012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6778
e8fc049f 6779 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6780
bf43fa51
KH
67812012-03-25 Kenichi Handa <handa@m17n.org>
6782
6783 * dispextern.h (struct glyph): Change the bit length of
6784 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6785
8a0c01dd
EZ
67862012-03-24 Eli Zaretskii <eliz@gnu.org>
6787
6788 * s/ms-w32.h (tzname): Include time.h before redirecting to
6789 _tzname. Fixes the MSVC build. (Bug#9960)
6790
7d1c3a76
AS
67912012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6792
8ed79523
AS
6793 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6794 characters.
6795
7d1c3a76
AS
6796 * xterm.c (XTread_socket): Only modify handling_signal if
6797 !SYNC_INPUT. (Bug#11080)
6798
e99a9b8b
EZ
67992012-03-23 Eli Zaretskii <eliz@gnu.org>
6800
6801 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6802 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6803 when fetching a multibyte character consumes more bytes than
6804 CHAR_BYTES returns, due to unification of CJK characters in
6805 string_char. (Bug#11073)
6806
5063c0e1
TN
68072012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6808
6809 * process.c (wait_reading_process_output): Handle pty disconnect
6810 by refraining from sending oneself a SIGCHLD (bug#10933).
6811
9f851fbd
CY
68122012-03-22 Chong Yidong <cyd@gnu.org>
6813
6814 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6815
5063c0e1 6816 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6817 Mark string as coming from a prefix property.
6818 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6819 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6820
fb5b8aca
CY
68212012-03-21 Chong Yidong <cyd@gnu.org>
6822
6823 * xfaces.c (Vface_remapping_alist): Doc fix.
6824
62356a1b
EZ
68252012-03-20 Eli Zaretskii <eliz@gnu.org>
6826
6827 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6828 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6829 Doc fixes.
62356a1b 6830
025de85b
CY
68312012-03-20 Chong Yidong <cyd@gnu.org>
6832
6833 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6834 to reflect default non-nil value of redisplay-dont-pause.
6835
4827f94e
KH
68362012-03-19 Kenichi Handa <handa@m17n.org>
6837
6838 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6839 it fit in a valid range (Bug#11003).
6840
e50a24a2
EZ
68412012-03-18 Eli Zaretskii <eliz@gnu.org>
6842
6843 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6844 that is not from display property, accept the row as a "cursor
6845 row" if one of the string's character has a non-nil `cursor'
6846 property. Fixes cursor positioning when there are newlines in
6847 overlay strings, e.g. in icomplete.el. (Bug#11035)
6848
9af5ed87
PE
68492012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6850
6851 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6852
d1f55f16
CY
68532012-03-12 Chong Yidong <cyd@gnu.org>
6854
6855 * eval.c (inhibit_lisp_code): Rename from
6856 inhibit_window_configuration_change_hook; move from window.c.
6857
6858 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6859 * window.c (run_window_configuration_change_hook)
6860 (syms_of_window): Callers changed.
6861
66c5eebd
CY
68622012-03-11 Chong Yidong <cyd@gnu.org>
6863
413df973
CY
6864 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6865
66c5eebd
CY
6866 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6867
1de11f56
CY
68682012-03-10 Chong Yidong <cyd@gnu.org>
6869
6870 * frame.c (other_visible_frames): Don't assume the selected frame
6871 is visible (Bug#10955).
6872
cae07000
SM
68732012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6874
6875 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6876
89c94350
JD
68772012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6878
6879 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6880 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6881 zero (Bug#10954).
6882
999dd333
GM
68832012-03-03 Glenn Morris <rgm@gnu.org>
6884
01a6dcc8 6885 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6886
de0100f2
EZ
68872012-03-02 Eli Zaretskii <eliz@gnu.org>
6888
6889 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6890 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6891 (redisplay_window, next_element_from_string): Fix typos in
6892 comments.
3e441275
EZ
6893 (redisplay_window): Pass to move_it_vertically the margin in
6894 pixels, not in screen lines.
de0100f2 6895
96a72ee9
GM
68962012-03-02 Glenn Morris <rgm@gnu.org>
6897
6898 * buffer.c (buffer-list-update-hook): Doc fix.
6899
312508d7
EZ
69002012-02-29 Eli Zaretskii <eliz@gnu.org>
6901
6902 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6903 push_it before setting up the iterator for the first overlay
6904 string, even if we have an empty string loaded.
6905 (next_overlay_string): If there's an empty string on the iterator
6906 stack, pop the stack. (Bug#10903)
6907
27f3c637
PE
69082012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6909
6910 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6911 Suggested by Stefan Monnier in
6912 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6913 * alloc.c (widen_to_Lisp_Object): New static function.
6914 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6915 and widening them to Lisp_Objects. This would work even if
6916 USE_LSB_TAG is defined and wide integers are used, which might
6917 happen in a future version of Emacs.
6918
3c9dfce6
CY
69192012-02-25 Chong Yidong <cyd@gnu.org>
6920
fa74b241
CY
6921 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6922 Doc fix.
6923
3c9dfce6
CY
6924 * xselect.c (Fx_selection_exists_p): Doc fix.
6925 (x_clipboard_manager_save_all): Print an informative message
6926 before saving to clipboard manager.
6927
9486df08
CY
69282012-02-24 Chong Yidong <cyd@gnu.org>
6929
6930 * keyboard.c (process_special_events): Handle all X selection
6931 requests in kbd_buffer, not just the next one (Bug#8869).
6932
f01d3321
CY
69332012-02-23 Chong Yidong <cyd@gnu.org>
6934
6935 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6936 call when setting menu-bar-lines and tool-bar-lines parameters.
6937 (unwind_create_frame_1): New helper function.
6938
6939 * window.c (inhibit_window_configuration_change_hook): New var.
6940 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6941 (syms_of_window): Initialize it.
f01d3321 6942
86b847b6
CY
69432012-02-22 Chong Yidong <cyd@gnu.org>
6944
6945 * xterm.c (x_draw_image_relief): Add missing type check for
6946 Vtool_bar_button_margin (Bug#10743).
6947
a59225b1
CY
69482012-02-21 Chong Yidong <cyd@gnu.org>
6949
6950 * fileio.c (Vfile_name_handler_alist): Doc fix.
6951
6952 * buffer.c (Fget_file_buffer): Protect against invalid file
6953 handler return value.
6954
310f5bd4
PE
69552012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6956
cb3a28cc
PE
6957 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6958 when computing $valmask.
6959
310f5bd4
PE
6960 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6961 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6962 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6963 It's useless in that case, and it can cause problems on hosts
6964 that allocate halves of EMACS_INT values separately.
6965 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6966 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6967 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6968 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6969 it avoids undefined behavior on hosts where shifting right by more
6970 than the word width has undefined behavior.
6971
2375c96a
CY
69722012-02-19 Chong Yidong <cyd@gnu.org>
6973
6974 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6975 (Funhandled_file_name_directory, Ffile_name_as_directory)
6976 (Fdirectory_file_name, Fexpand_file_name)
6977 (Fsubstitute_in_file_name): Protect against invalid file handler
6978 return values (Bug#10845).
6979
3eb49e71
EZ
69802012-02-18 Eli Zaretskii <eliz@gnu.org>
6981
6982 * .gdbinit (pitx): Fix incorrect references to fields of the
6983 iterator stack.
6984
7b926f3f
CY
69852012-02-17 Chong Yidong <cyd@gnu.org>
6986
6987 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6988
11273115
PE
69892012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6990
6991 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6992 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6993
c3a70e2b
CY
69942012-02-15 Chong Yidong <cyd@gnu.org>
6995
6996 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6997 marked as special. Also, starting docstrings with * is obsolete.
6998
0ca43699
AS
69992012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7000
7001 * gnutls.c (emacs_gnutls_write): Fix last change.
7002
2e8f3c56
LI
70032012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7004
7005 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7006 send_process.
7007
af70074f
SM
70082012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7009
7010 * keymap.c (Fsingle_key_description): Handle char ranges.
7011
95986d52
CY
70122012-02-12 Chong Yidong <cyd@gnu.org>
7013
afd83bd1
CY
7014 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7015 as that creates a dangerous corner case.
7016
95986d52
CY
7017 * window.c (Fdelete_window_internal): Invalidate the mouse
7018 highlight (Bug#9904).
7019
bd7da63e
GM
70202012-02-12 Glenn Morris <rgm@gnu.org>
7021
7022 * xselect.c (Fx_own_selection_internal)
7023 (Fx_get_selection_internal, Fx_disown_selection_internal)
7024 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7025 * nsselect.m (Fx_own_selection_internal)
7026 (Fx_disown_selection_internal, Fx_selection_exists_p)
7027 (Fx_selection_owner_p, Fx_get_selection_internal):
7028 Sync docs and argument specs with the xselect.c versions.
7029
77abcbc2
LI
70302012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7031
7032 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7033
90b671e2
EZ
70342012-02-11 Eli Zaretskii <eliz@gnu.org>
7035
1c0ca0b7
EZ
7036 * w32select.c (Fx_selection_exists_p): Sync doc string and
7037 argument list with xselect.c. (Bug#10783)
7038
7039 * w16select.c (Fx_selection_exists_p): Sync doc string and
7040 argument list with xselect.c. (Bug#10783)
90b671e2 7041
49241268
GM
70422012-02-10 Glenn Morris <rgm@gnu.org>
7043
7044 * fns.c (Fsecure_hash): Doc fix.
7045
f998bbe7 70462012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7047
7048 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7049
0992bd9c
CY
70502012-02-07 Chong Yidong <cyd@gnu.org>
7051
7052 * buffer.c (Fbuffer_local_variables)
7053 (buffer_lisp_local_variables): Handle unbound vars correctly;
7054 don't let Qunbound leak into Lisp.
7055
af008560
GM
70562012-02-07 Glenn Morris <rgm@gnu.org>
7057
dd605cc4
GM
7058 * image.c (Fimagemagick_types): Doc fix.
7059
af008560
GM
7060 * image.c (imagemagick-render-type): Change it from a lisp object
7061 to an integer. Move the doc here from the lisp manual.
7062 Treat all values not equal to 0 the same.
7063
1449fa1d
CY
70642012-02-06 Chong Yidong <cyd@gnu.org>
7065
7066 * doc.c (store_function_docstring): Avoid applying docstring of
7067 alias to base function (Bug#2603).
7068
3723ec07
AS
70692012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7070
7071 * .gdbinit (pp1, pv1): Remove redundant defines.
7072 (pr): Use pp.
7073
79c1cc1e
CY
70742012-02-04 Chong Yidong <cyd@gnu.org>
7075
7076 * nsterm.m: Declare a global (Bug#10694).
7077
d7f29f8e
EZ
70782012-02-04 Eli Zaretskii <eliz@gnu.org>
7079
cae07000
SM
7080 * w32.c (get_emacs_configuration_options):
7081 Include --enable-checking, if specified, in the return value.
d7f29f8e 7082
3b95a6f9
MR
70832012-02-04 Martin Rudalics <rudalics@gmx.at>
7084
7085 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7086 after rounding frame sizes. (Bug#9723)
7087
d6fa96a6
EZ
70882012-02-04 Eli Zaretskii <eliz@gnu.org>
7089
7090 * keyboard.c (adjust_point_for_property): Don't position point
7091 before BEGV. (Bug#10696)
7092
df0b2940
PE
70932012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7094
7095 Handle overflow when computing char display width (Bug#9496).
7096 * character.c (char_width): Return EMACS_INT, not int.
7097 (char_width, c_string_width): Check for overflow when
7098 computing the width; this is possible now that individual
7099 characters can have unbounded width. Problem introduced
7100 by merge from Emacs 23 on 2012-01-19.
7101
6bee44d6
MA
71022012-02-02 Michael Albinus <michael.albinus@gmx.de>
7103
7104 * dbusbind.c (Fdbus_register_method): Mention the return value
7105 :ignore in the docstring.
7106
44f92739
GM
71072012-02-02 Glenn Morris <rgm@gnu.org>
7108
1b9f60cc
GM
7109 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7110
44f92739
GM
7111 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7112 Unconditionally set to t. (Bug#10673)
7113 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7114 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7115 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
7116
c5d3843c
KH
71172012-02-02 Kenichi Handa <handa@m17n.org>
7118
7119 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7120 0, do not call append_composite_glyph.
7121
159462d4 71222012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7123
7124 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7125 NULL (Bug#6988).
7126 (x_produce_glyphs): If the component of a composition is a null
7127 string, set it->pixel_width to 1 to avoid zero-width glyph.
7128
78cef877
EZ
71292012-02-01 Eli Zaretskii <eliz@gnu.org>
7130
7131 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7132 first 2 arguments are identical. This makes inserting large
7133 output from a subprocess an order of magnitude faster on
7134 MS-Windows, where all sbrk'ed memory is always contiguous.
7135
97897668
GM
71362012-01-31 Glenn Morris <rgm@gnu.org>
7137
7138 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7139 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7140 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7141
31fd3586
GM
71422012-01-29 Glenn Morris <rgm@gnu.org>
7143
7144 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7145
0e24a8b2
CY
71462012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7147
7148 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7149
cc0adcb0
CY
71502012-01-28 Chong Yidong <cyd@gnu.org>
7151
7152 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7153
acc28cb9
CY
71542012-01-26 Chong Yidong <cyd@gnu.org>
7155
9c69cfb7
CY
7156 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7157
acc28cb9
CY
7158 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7159 repeat counts (Bug#10507).
7160
48da7392
GM
71612012-01-26 Glenn Morris <rgm@gnu.org>
7162
7163 * lread.c (syms_of_lread): Doc fix.
7164
14af5f7f
CY
71652012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7166
7167 * coding.c (encode_designation_at_bol): Change return value to
7168 EMACS_INT.
7169
0b21c100
CY
71702012-01-25 Chong Yidong <cyd@gnu.org>
7171
7172 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7173
3c2907f7
CY
71742012-01-21 Chong Yidong <cyd@gnu.org>
7175
7176 * floatfns.c (Fcopysign): Make the second argument non-optional,
7177 since nil is not allowed anyway.
7178
959ad23f
AS
71792012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7180
7181 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7182 (send_process): Likewise.
7183
34a02f46
MR
71842012-01-19 Martin Rudalics <rudalics@gmx.at>
7185
7186 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7187 (Vwindow_persistent_parameters): Do not use Qstate.
7188 Rewrite doc-strings.
34a02f46 7189
1259009a 71902012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7191
7192 * character.c (char_width): New function.
70d4fdf6
GM
7193 (Fchar_width, c_string_width, lisp_string_width):
7194 Use char_width (Bug#9496).
25ed9e61 7195
6a6ee00d
MR
71962012-01-16 Martin Rudalics <rudalics@gmx.at>
7197
7198 * window.c (Vwindow_persistent_parameters): New variable.
7199 (Fset_window_configuration, save_window_save): Handle persistent
7200 window parameters.
7201
c85efaf7
EZ
72022012-01-14 Eli Zaretskii <eliz@gnu.org>
7203
7204 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7205 thrashing the stack of the thread. (Bug#9087)
7206
5944709e
PE
72072012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7208
7209 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
7210
e71f5d99
EZ
72112012-01-11 Eli Zaretskii <eliz@gnu.org>
7212
7213 * xdisp.c (rows_from_pos_range): Handle the case where the
7214 highlight ends on a newline. (Bug#10464)
7215 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
7216 he end column for display of highlight that ends on a newline
7217 before a R2L line.
7218
ce316182
GM
72192012-01-11 Glenn Morris <rgm@gnu.org>
7220
7221 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
7222 from load-path also when installation-directory is nil. (Bug#10208)
7223
5b43da69
GM
72242012-01-10 Glenn Morris <rgm@gnu.org>
7225
74cc8ff9
GM
7226 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
7227
7d8d6e4e
GM
7228 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
7229 Update template values to be closer to their typical values these days.
5b43da69 7230
a0db8d43
EZ
72312012-01-09 Eli Zaretskii <eliz@gnu.org>
7232
7233 * xdisp.c (rows_from_pos_range): Accept additional argument
7234 DISP_STRING, and accept any glyph in a row whose object is that
7235 string as eligible for mouse highlight. Fixes mouse highlight of
7236 display strings from overlays. (Bug#10464)
7237
9a0115ab 72382012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 7239
b9110d6a 7240 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
7241 * fileio.c (auto_saving_dir_umask): New static var.
7242 (Fmake_directory_internal): Use it.
7243 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7244 creating the directory. The old code temporarily assigns
7245 too-generous permissions to the directory.
7246 (do_auto_save_eh): Clear it.
b9110d6a 7247 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
7248 that the var is always cleared.
7249
6c1bd3f3
EZ
72502012-01-07 Eli Zaretskii <eliz@gnu.org>
7251
7252 * search.c (scan_buffer): Pass character positions to
7253 know_region_cache, not byte positions. (Bug#6540)
7254
069d2b50
L
72552012-01-07 LynX <_LynX@bk.ru> (tiny change)
7256
7257 * w32.c (sys_rename): Report EXDEV when rename of a directory
7258 fails because the target is on another logical disk. (Bug#10284)
7259
75bf0d33
DB
72602012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
7261
7262 * xterm.c (x_embed_request_focus): New function.
7263
7264 * xterm.h: Add prototype.
7265
7266 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
7267
1c6e5a32
GM
72682012-01-05 Glenn Morris <rgm@gnu.org>
7269
7270 * emacs.c (emacs_copyright): Update short copyright year to 2012.
7271
651e947e
EZ
72722012-01-01 Eli Zaretskii <eliz@gnu.org>
7273
7274 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
7275 Load gnutls_transport_set_lowat only if GnuTLS version is below
7276 2.11.1.
7277 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7278 GnuTLS versions below 2.11.1.
7279
3778cdd8
AL
72802011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
7281
7282 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
7283 to the doc string advising against its use for altering the way
7284 windows are scrolled.
7285
0e5317f7
KH
72862011-12-28 Kenichi Handa <handa@m17n.org>
7287
7288 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
7289 coding-system ASCII compatible only when it does not produce BOM
7290 on encoding (Bug#10383).
7291
93d5ca1f
JD
72922011-12-26 Jan Djärv <jan.h.d@swipnet.se>
7293
7294 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
7295 can scroll.
7296 (create_and_show_popup_menu): Always use menu_position_func for
7297 Gtk3 (Bug#10361).
7298
ca22b785
AS
72992011-12-24 Andreas Schwab <schwab@linux-m68k.org>
7300
7301 * callint.c (Fcall_interactively): Don't truncate prompt string.
7302
d048e1e6
EZ
73032011-12-23 Eli Zaretskii <eliz@gnu.org>
7304
7305 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
7306 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 7307 resumed from there (after widening). (Bug#10360)
d048e1e6 7308
5ccaba1f
JD
73092011-12-22 Jan Djärv <jan.h.d@swipnet.se>
7310
7311 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
7312
204ee57f
JD
73132011-12-21 Jan Djärv <jan.h.d@swipnet.se>
7314
b81d40f0
JB
7315 * nsterm.m (x_free_frame_resources):
7316 Release f->output_data.ns->miniimage.
204ee57f
JD
7317 (ns_index_color): Fix indentation. Do not retain
7318 color_table->colors[i].
7319
7320 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
7321 before returning.
7322
7323 * nsfns.m (x_set_background_color): Assign return value from
7324 ns_index_color to face-background instead of NSColor*.
7325 (ns_implicitly_set_icon_type): Fix indentation.
7326 Change assignment in for loop to comparison.
7327
7328 * emacs.c (ns_pool): New variable.
7329 (main): Assign ns_pool.
7330 (Fkill_emacs): Call ns_release_autorelease_pool.
7331
7332 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
7333 autorelease fdesc, release fdAttrs and tdict.
7334 (ns_get_covering_families): Release charset.
7335 (ns_findfonts): Release NSFontDescriptor created with new.
7336 (ns_uni_to_glyphs): Fix indentation.
7337 (setString): Release attrStr before assigning new value.
7338
c803b2b7
JD
73392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
7340
678f4426
JD
7341 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
7342 and NS_IMPL_COCOA.
7343 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
7344 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7345
cd394be1 73462011-12-18 David Reitter <reitter@cmu.edu>
678f4426 7347
5fecd5fc
JD
7348 * nsterm.m (ns_term_init): Subscribe for notifications
7349 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
7350 to method trackingNotification in EmacsMenu.
7351
7352 * nsmenu.m (trackingMenu): New variable.
3771cb17 7353 (trackingNotification): New method (from Aquamacs).
5fecd5fc 7354 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 7355 from Aquamacs (Bug#7030).
678f4426
JD
7356
73572011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 7358
c803b2b7
JD
7359 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
7360 (symbol_to_nsstring): Fix indentation.
7361 (ns_symbol_to_pb): New function.
cae07000
SM
7362 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
7363 (Fns_rotate_cut_buffers_internal): Remove.
7364 (Fns_store_selection_internal): Rename from
c803b2b7
JD
7365 Fns_store_cut_buffer_internal.
7366 (ns_get_foreign_selection, Fx_own_selection_internal)
7367 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
7368 (Fns_get_selection_internal, Fns_store_selection_internal):
7369 Use ns_symbol_to_pb and check if return value is nil.
7370 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
7371 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
7372 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
7373 renamed to Sns_store_selection_internal.
7374 (ns_handle_selection_request): Move code to Fx_own_selection_internal
7375 and remove this function.
7376 (ns_handle_selection_clear): Remove, never used.
7377 (Fx_own_selection_internal): Move code from ns_handle_selection_request
7378 here.
7379
e1b01a3a
KB
73802011-12-17 Ken Brown <kbrown@cornell.edu>
7381
7382 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
7383 GID is unknown (Bug#10257).
7384
2adb6e85
PE
73852011-12-17 Paul Eggert <eggert@cs.ucla.edu>
7386
7387 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
7388 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
7389 which caused a build failure on GNU/Linux IA-64. This problem was
7390 introduced by my 2011-10-07 patch.
7391
d1d7b339
JL
73922011-12-15 Juri Linkov <juri@jurta.org>
7393
7394 * image.c (imagemagick_error): New function. (Bug#10112)
7395 (imagemagick_load_image): Comment out `MagickSetResolution' call.
7396 Use `imagemagick_error' where ImageMagick functions return
7397 `MagickFalse'.
7398 (Fimagemagick_types): Add `Fnreverse' to return the list in the
7399 proper order.
7400
100d5755
KH
74012011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7402
7403 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
7404 fill background (Bug#8992).
7405
454592a6
MR
74062011-12-13 Martin Rudalics <rudalics@gmx.at>
7407
7408 * window.c (Vwindow_combination_resize)
7409 (Vwindow_combination_limit): Use t instead of non-nil in
7410 doc-strings.
61d4b438
MR
7411 (Vrecenter_redisplay): Add first sentence of doc-string on
7412 separate line.
53524d93 7413 (Frecenter): Fix doc-string typo.
454592a6 7414
3633e3aa
KH
74152011-12-11 Kenichi Handa <handa@m17n.org>
7416
7417 * coding.c (Funencodable_char_position): Pay attention to the
7418 buffer text relocation (Bug#9389).
7419
7b9d523a 74202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 7421
7b9d523a
JD
7422 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
7423 gtk_init (Bug#10100).
7424
b73189c6
EZ
74252011-12-10 Eli Zaretskii <eliz@gnu.org>
7426
7427 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
7428 IT->string is nil. (Bug#10263)
7429
f7dfe5d6
JD
74302011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7431
83faebb4
JD
7432 * nsterm.h (x_free_frame_resources): Declare.
7433
f7dfe5d6
JD
7434 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
7435 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7436
7437 * nsterm.h (ns_get_defaults_value): Declare.
7438
7439 * nsterm.m (ns_default): Call ns_get_defaults_value.
7440
7cd4e72c
EZ
74412011-12-09 Eli Zaretskii <eliz@gnu.org>
7442
7443 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
7444 (Bug#10170)
7445
b34d7317
YM
74462011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7447
7448 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
7449 that where the value of an _OBJC_* symbol points to is in the .bss
7450 section (Bug#10240).
7451
76470ad1
KH
74522011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7453
7454 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 7455 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 7456
745fff94
KH
74572011-12-08 Kenichi Handa <handa@m17n.org>
7458
7459 * ftfont.c (get_adstyle_property): Fix previous change
7460 (Bug#10233).
7461
6e44397c
JB
74622011-12-07 Juanma Barranquero <lekktu@gmail.com>
7463
7464 * w32.c (init_environment): If no_site_lisp, remove site-lisp
7465 dirs from the default value of EMACSLOADPATH (bug#10208).
7466
7efa6272
GM
74672011-12-07 Glenn Morris <rgm@gnu.org>
7468
7469 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
7470 installation and source directories as well. (Bug#10208)
7471
f6fc4d87
CY
74722011-12-06 Chong Yidong <cyd@gnu.org>
7473
7474 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
7475
2bf26180
GM
74762011-12-06 Glenn Morris <rgm@gnu.org>
7477
7478 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
7479 as an error, not just -1. (Bug#10217)
7480
3a6ad4f0
CY
74812011-12-05 Chong Yidong <cyd@gnu.org>
7482
7483 * keyboard.c (process_special_events): New function.
7484 (swallow_events, Finput_pending_p): Use it (Bug#10195).
7485
75a3b399
PE
74862011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7487
7488 * coding.c (encode_designation_at_bol): Don't use uninitialized
7489 local variable (Bug#9318).
7490
c3c9e25e
KH
74912011-12-05 Kenichi Handa <handa@m17n.org>
7492
7493 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7494 return Qnil (Bug#8046, Bug#10193).
7495
5eb05ea3
KH
74962011-12-05 Kenichi Handa <handa@m17n.org>
7497
7498 * coding.c (encode_designation_at_bol): New args charbuf_end and
7499 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7500 (coding_set_source): Return how many bytes coding->source was
7501 relocated.
7502 (coding_set_destination): Return how many bytes
7503 coding->destination was relocated.
7504 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7505 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7506
75072011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7508
7509 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7510 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7511 macro (Bug#9318).
7512
75132011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7514
7515 The following changes are to fix Bug#9318.
7516
a79703f5 7517 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7518 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7519 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7520 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7521
7dbda6df
JB
75222011-12-05 Juanma Barranquero <lekktu@gmail.com>
7523
7524 * lisp.h (process_quit_flag): Fix external declaration.
7525
6d5eb5b0
SM
75262011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7527
7528 Don't macro-inline non-performance-critical code.
7529 * eval.c (process_quit_flag): New function.
7530 * lisp.h (QUIT): Use it.
7531
a0c3fad0
JD
75322011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7533
7534 * nsfns.m (get_geometry_from_preferences): New function.
7535 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7536
6c07aac2
AS
75372011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7538
7539 * emacs.c (Qkill_emacs): Define.
7540 (syms_of_emacs): Initialize it.
7541 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7542 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7543 (quit_throw_to_read_char): Add parameter `from_signal'.
7544 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7545 * lisp.h (QUIT): Call Fkill_emacs if requested.
7546
c052ead4
JD
75472011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7548
7549 * widget.c (update_wm_hints): Return if wmshell is null.
7550 (widget_update_wm_size_hints): New function.
7551
7552 * widget.h (widget_update_wm_size_hints): Declare.
7553
7554 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7555 widget_update_wm_size_hints (Bug#10104).
7556
9e49252b
EZ
75572011-12-03 Eli Zaretskii <eliz@gnu.org>
7558
7559 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7560 before a newline, prepare the bidi iterator for consuming the
7561 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7562 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7563
02b16839
JL
75642011-12-02 Juri Linkov <juri@jurta.org>
7565
7566 * search.c (Fword_search_regexp): New Lisp function created from
7567 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7568 (Fword_search_backward, Fword_search_forward)
7569 (Fword_search_backward_lax, Fword_search_forward_lax):
7570 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7571 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7572
0068070e
SM
75732011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7574
7575 * fileio.c (Finsert_file_contents): Move after-change-function call
7576 to before the "handled:" label, since all "goto handled" appear in
7577 cases where the *-change-functions have already been properly called
7578 (bug#10117).
7579
3360a3fc
AS
75802011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7581
7582 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7583 waiting for input. (Bug#10169)
7584
73d6c093
EZ
75852011-11-30 Eli Zaretskii <eliz@gnu.org>
7586
7587 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7588 verifies glyph row's hash code--we have just reallocated the
7589 glyphs, so their contents can be complete garbage. (Bug#10164)
7590
febe6bea
JB
75912011-11-30 Juanma Barranquero <lekktu@gmail.com>
7592
7593 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7594
801a4313
EZ
75952011-11-30 Eli Zaretskii <eliz@gnu.org>
7596
7597 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7598 attributes are tested _before_ calling verify_row_hash, to protect
7599 against GCC re-ordering of the tests. (Bug#10164)
7600
2b56b87e
JD
76012011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7602
7603 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7604
7605 * xterm.c (handle_one_xevent): Only set async_visible and friends
7606 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7607 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7608 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7609
dbf31225
PE
76102011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7611
7612 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7613 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7614 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7615 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7616 All uses changed to use GCPRO1 etc.
7617 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7618 Revert to old implementation (i.e., before 2011-03-11).
7619
1305621b
YM
76202011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7621
7622 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7623 of scroll runs so as to avoid assigning disabled bogus rows and
7624 unnecessary graphics copy operations.
7625
8c9afb46
EZ
76262011-11-27 Eli Zaretskii <eliz@gnu.org>
7627
7628 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7629 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7630 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7631 (malloc, free, realloc, calloc): Redirect to e_* only when
7632 compiling Emacs.
7633
7634 * lisp.h (GCTYPEBITS): Move before first use.
7635 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7636 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7637 this macro definition.
7638
7639 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7640 _MSC_VER.
7641
54e9e3bf
JD
76422011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7643
6d5eb5b0
SM
7644 * gtkutil.c (xg_create_frame_widgets):
7645 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7646 present with Gtk+ 2.0.
7647
83aca1cb
PE
76482011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7649
7650 * fileio.c (Finsert_file_contents): Undo previous change; see
7651 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7652
5b76caa4
PE
76532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7654
7655 Rename locals to avoid shadowing.
7656 * fileio.c (Finsert_file_contents):
7657 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7658 * process.c (wait_reading_process_output):
7659 Rename inner 'proc' to 'p' to avoid shadowing.
7660 Indent for consistency with usual Emacs style.
7661
8c535114
EZ
76622011-11-25 Eli Zaretskii <eliz@gnu.org>
7663
7664 * xdisp.c (redisplay_window): If cursor row is not fully visible
7665 after recentering, and scroll-conservatively is set to a large
7666 number, scroll window by a few more lines to make the cursor fully
7667 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7668 (start_display): Don't move to the next line if the display should
7669 start at a newline that is part of a display vector or an overlay
7670 string. (Bug#10119)
8c535114 7671
fa4fdb5c
JL
76722011-11-24 Juri Linkov <juri@jurta.org>
7673
7674 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7675 after the `MagickPingImage' call. (Bug#10112)
7676
90ec88df
CY
76772011-11-23 Chong Yidong <cyd@gnu.org>
7678
7679 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7680
56e2e794
MR
76812011-11-23 Martin Rudalics <rudalics@gmx.at>
7682
7683 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7684 making another buffer current. (Bug#10114)
7685
b6e64c41
GM
76862011-11-23 Glenn Morris <rgm@gnu.org>
7687
7688 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7689
6b21de18
CY
76902011-11-23 Chong Yidong <cyd@gnu.org>
7691
7692 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7693 using it (Bug#5984).
7694
b12cd789
EZ
76952011-11-22 Eli Zaretskii <eliz@gnu.org>
7696
7697 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7698 and header-lines, as they don't have one computed for them.
7699 (Bug#10098)
7700
7701 * .gdbinit (prow): Make displayed values more self-explaining.
7702 Add row's hash code.
7703
261b6fd4
LMI
77042011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7705
7706 * process.c (wait_reading_process_output): Fix asynchrounous
7707 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7708 (wait_reading_process_output): Add comment and URL.
261b6fd4 7709
e7cfd277
JD
77102011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7711
7712 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7713
a9b9b7f5
CY
77142011-11-21 Chong Yidong <cyd@gnu.org>
7715
7716 * window.c (Fnext_window, Fprevious_window): Doc fix.
7717
b0d15b4f
SM
77182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7719
7720 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7721
fe7a3057
JB
77222011-11-20 Juanma Barranquero <lekktu@gmail.com>
7723
7724 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7725
d2999b1a
MR
77262011-11-20 Martin Rudalics <rudalics@gmx.at>
7727
7728 * window.c (Fset_window_combination_limit): Rename argument
7729 STATUS to LIMIT.
7730 (Vwindow_combination_limit): Remove "status" from doc-string.
7731
d5ff9cd0
AS
77322011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7733
7734 * m/ibms390.h: Remove.
7735 * m/ibms390x.h: Don't include "ibms390.h".
7736
a5bb9bd3
SM
77372011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7738
7739 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7740 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7741
cd1181db
JB
77422011-11-20 Juanma Barranquero <lekktu@gmail.com>
7743
7744 * casetab.c (Fset_case_table):
7745 * charset.c (Fcharset_after): Fix typos.
7746
615a3b8d 77472011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7748
17e845af
PE
7749 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7750 Otherwise, valgrind does not work on some platforms.
7751 Problem reported by Andreas Schwab in
6a0bf43d
PE
7752 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7753 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7754 is set, removing the need for VIRT_ADDRESS_VARIES.
7755 (PURE_P): Use a more-efficient implementation that needs just one
7756 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7757 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7758 to 4 (xorl, subq, cmpq, setbe).
7759 * alloc.c (pure): Always extern now, since that's the
7760 VIRT_ADDR_VARIES behavior.
7761 (PURE_POINTER_P): Use a single comparison, not two, for
7762 consistency with the new puresize.h.
7763 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7764 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7765 Remove VIRT_ADDR_VARIES no longer needed.
7766
f8fe6f96
EZ
77672011-11-19 Eli Zaretskii <eliz@gnu.org>
7768
7769 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7770 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7771 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7772 behave as if the cursor position were at the window margin.
7773
7774 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7775 and the cursor position is out of bounds, behave as if the cursor
7776 position were at the window margin. (Bug#10075)
7777
df05a53c
CY
77782011-11-18 Chong Yidong <cyd@gnu.org>
7779
7780 * window.c (Fwindow_combination_limit): Make first argument
7781 non-optional, since it is meaningless for live windows like the
7782 selected window.
61ccba97 7783
2071918e
DA
77842011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7785
7786 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7787
b50a28de
SM
77882011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7789
7790 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7791 (graft_intervals_into_buffer): Simplify.
7792
015137db
EZ
77932011-11-18 Eli Zaretskii <eliz@gnu.org>
7794
7795 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7796 hash values of the two rows.
7797 (copy_row_except_pointers): Preserve the used[] arrays and the
7798 hash values of the two rows. (Bug#10035)
68c95424 7799 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7800
7801 * xdisp.c (row_hash): New function, body extracted from
7802 compute_line_metrics.
7803 (compute_line_metrics): Call row_hash, instead of computing the
7804 hash code inline.
7805
7806 * dispnew.c (verify_row_hash): Call row_hash for computing the
7807 hash code of a row, instead of duplicating code from xdisp.c.
7808
7809 * dispextern.h (row_hash): Add prototype.
7810
a2addb04
TH
78112011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7812
7813 * frame.c (delete_frame): Don't delete the terminal when the last
7814 X frame is closed if emacs is built with GTK toolkit.
7815
df85d315
JB
78162011-11-17 Juanma Barranquero <lekktu@gmail.com>
7817
7818 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7819
a0c2d0ae
MR
78202011-11-17 Martin Rudalics <rudalics@gmx.at>
7821
7822 * window.c (Vwindow_splits): Rename to
7823 Vwindow_combination_resize. Suggested by Juri Linkov.
7824 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7825 of Vwindow_splits.
7826
58179cce
JB
78272011-11-16 Juanma Barranquero <lekktu@gmail.com>
7828
7877f373
JB
7829 * nsfns.m (Fns_font_name):
7830 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7831
b6f67890
MR
78322011-11-16 Martin Rudalics <rudalics@gmx.at>
7833
7834 * window.h (window): Rename slot "nest" to "combination_limit".
7835 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7836 (Fset_window_nest): Rename to Fset_window_combination_limit.
7837 (Vwindow_nest): Rename to Vwindow_combination_limit.
7838 (recombine_windows, make_parent_window, make_window)
7839 (Fsplit_window_internal, saved_window)
7840 (Fset_window_configuration, save_window_save): Rename all
7841 occurrences of window_nest to window_combination_limit.
7842
c7015153
JB
78432011-11-15 Juanma Barranquero <lekktu@gmail.com>
7844
7845 * image.c (imagemagick_load_image): Fix typo.
7846
322ad6ec
EZ
78472011-11-14 Eli Zaretskii <eliz@gnu.org>
7848
7849 * xdisp.c (display_line): Move the call to
7850 highlight_trailing_whitespace before the call to
7851 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7852 faces of all the glyphs to compute ROW's hash value.
7853 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7854
f067b8ec
JB
78552011-11-14 Juanma Barranquero <lekktu@gmail.com>
7856
7857 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7858 just return (bug#10044).
7859
1e5b2111
EZ
78602011-11-12 Eli Zaretskii <eliz@gnu.org>
7861
7ef3cbd5
EZ
7862 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7863 with user-defined heap size. Bump the default size of the temacs
7864 heap to 27MB, to avoid memory warning when running temacs.
7865 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7866
1e5b2111
EZ
7867 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7868 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7869 (verify_row_hash) [XASSERTS]: New function.
7870 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7871 that the hash value of glyph rows is correct.
1e5b2111 7872
89d61221
MR
78732011-11-12 Martin Rudalics <rudalics@gmx.at>
7874
7875 * window.h (window): Remove splits slot.
7876 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7877 (Fdelete_other_windows_internal, make_parent_window)
7878 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7879 (Fset_window_configuration, save_window_save): Don't deal with
7880 split status of windows.
7881 (saved_window): Remove splits slot.
7882 (Vwindow_splits): Rewrite doc-string.
7883
97f18cc8
JD
78842011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7885
7886 * xfns.c (unwind_create_frame):
7887 * nsfns.m (unwind_create_frame):
7888 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7889 Vframe_list (Bug#9999).
7890
22a648b4
DA
78912011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7892
0b381c7e 7893 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7894
659afede
KH
78952011-11-11 Kenichi Handa <handa@m17n.org>
7896
7897 * callproc.c (Fcall_process): Set the member dst_multibyte of
7898 process_coding.
7899
9ac0394b
KH
79002011-11-11 Johan Bockgård <bojohan@gnu.org>
7901
7902 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7903 avoid a crash (bug#9496).
7904
2fbdc249
CY
79052011-11-09 Chong Yidong <cyd@gnu.org>
7906
7907 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7908 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7909
ac6b1f81
PE
79102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7911
7912 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7913
09db192c
PE
79142011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7915
7916 Avoid some portability problems by eschewing 'extern inline' functions.
7917 The trivial performance wins aren't worth the portability hassles; see
7918 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7919 et seq.
7920 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7921 (window_box_width, window_box_left, window_box_left_offset)
7922 (window_box_right, window_box_right_offset): Undo previous change,
7923 by removing the "extern"s.
7924 * intervals.c (adjust_intervals_for_insertion)
7925 (adjust_intervals_for_deletion): Undo previous change,
7926 making these static again.
7927 (offset_intervals, temp_set_point_both, temp_set_point)
7928 (copy_intervals_to_string): No longer inline.
7929 * xdisp.c (window_text_bottom_y, window_box_width)
7930 (window_box_height, window_box_left_offset)
7931 (window_box_right_offset, window_box_left, window_box_right)
7932 (window_box): No longer inline.
7933
105216ed
CY
79342011-11-08 Chong Yidong <cyd@gnu.org>
7935
7936 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7937 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7938 Signal an error if not a live window.
105216ed
CY
7939 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7940 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7941
ae9e237f
JB
79422011-11-07 Juanma Barranquero <lekktu@gmail.com>
7943
7944 * lisp.h (syms_of_abbrev): Remove declaration.
7945 Reported by CHENG Gao <chenggao@royau.me>.
7946
c7aa8333
EZ
79472011-11-07 Eli Zaretskii <eliz@gnu.org>
7948
7949 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7950 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7951 of temacs in GUI mode.
7952
be7f5545
MR
79532011-11-07 Martin Rudalics <rudalics@gmx.at>
7954
7955 * window.h: Declare delete_all_child_windows instead of
7956 delete_all_subwindows.
7957 * window.c (Fwindow_nest, Fset_window_nest)
7958 (Fset_window_new_total, Fset_window_new_normal)
7959 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7960 (delete_all_subwindows): Rename to delete_all_child_windows.
7961 (Fdelete_other_windows_internal, Fset_window_configuration):
7962 Call delete_all_child_windows instead of delete_all_subwindows.
7963 * frame.c (delete_frame): Call delete_all_child_windows instead
7964 of delete_all_subwindows.
7965
ca78dc43
PE
79662011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7967
7968 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7969 This is also needed for porting to any host where GC_MARK_STACK is
7970 not GC_MAKE_GCPROS_NOOPS.
7971 (which_symbols): Use it.
7972
a0241d01
KH
79732011-11-07 Kenichi Handa <handa@m17n.org>
7974
7975 * coding.c (coding_set_destination): Check coding->src_pos only
7976 when coding->src_object is a buffer (bug#9910).
7977
7978 * process.c (send_process): Set the member src_multibyte of coding
7979 to 0 (bug#9911) when sending a unibyte text.
7980
7981 * callproc.c (Fcall_process): Set the member src_multibyte of
7982 process_coding to 0 (bug#9912).
7983
a64bfdfa 79842011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7985
7986 * xmenu.c (cleanup_widget_value_tree): New function.
7987 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7988 calling free_menubar_widget_value_tree directly (Bug#9830).
7989
cb41b32a
PE
79902011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7991
7992 Fix some portability problems with 'inline'.
7993 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7994 (window_box_width, window_box_left, window_box_left_offset)
7995 (window_box_right, window_box_right_offset): Declare extern.
7996 Otherwise, these inline functions do not conform to C99 and
7997 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7998 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7999 * intervals.c (adjust_intervals_for_insertion)
8000 (adjust_intervals_for_deletion): Now extern, because otherwise the
8001 extern inline functions 'offset_intervals' couldn't refer to it.
8002 (static_offset_intervals): Remove.
8003 (offset_intervals): Rewrite using the old contents of
8004 static_offset_intervals. The old version didn't conform to C99
8005 because an extern inline function contained a reference to an
8006 identifier with static linkage.
8007
b7041366
AS
80082011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8009
8010 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8011 GC.
8012
88a37c4d
EZ
80132011-11-06 Eli Zaretskii <eliz@gnu.org>
8014
8015 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8016 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8017 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8018 return Qleft_to_right.
8019
49745b39
CY
80202011-11-06 Chong Yidong <cyd@gnu.org>
8021
8022 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8023 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8024 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8025 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8026 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8027 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8028 (Fwindow_vscroll): Doc fix.
8029 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8030 argument, since it makes no sense to pass a live window and for
8031 consistency with window-child.
8032
1f05cd82
CS
80332011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8034
8035 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8036 support MSVC.
8037
22610910
JR
80382011-11-05 Jason Rumney <jasonr@gnu.org>
8039
8040 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8041 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8042 fonts (Bug#6029).
8043 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8044 bitwise arithmetic preventing use of unicode-sip and non-truetype
8045 opentype fonts.
8046
a06776b2
EZ
80472011-11-05 Eli Zaretskii <eliz@gnu.org>
8048
3ad924ba
EZ
8049 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8050 "emacs"-only part.
8051
a06776b2
EZ
8052 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8053 initialization code to keep similarity to xfns.c after changes
8054 from 2011-11-05.
8055
c9e7db78
JD
80562011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8057
a97f8f3f
JD
8058 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8059 (unwind_create_frame): New function (Bug#9943).
8060 (Fx_create_frame): Restructure code to be more similar to the one in
8061 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8062 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8063 Move terminal->reference_count++ just before making the frame official
8064 (Bug#9943).
8065
8066 * nsterm.m (x_free_frame_resources): New function.
8067 (x_destroy_window): Move code to x_free_frame_resources.
8068
c9e7db78 8069 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8070 (Fx_create_frame, x_create_tip_frame):
8071 Move terminal->reference_count++ just before making the frame
75f1671a 8072 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8073 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8074
a6fc3b5c
EZ
80752011-11-05 Eli Zaretskii <eliz@gnu.org>
8076
8077 Support MSVC build with newer versions of Visual Studio.
8078 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8079 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8080 nt/gmake.defs.
8081
8082 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8083 which are not supported by MSVC.
8084 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8085 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8086 bitfields.
8087 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8088 types in bitfields.
8089 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8090
8091 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8092
58179cce 80932011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8094
8095 Support MSVC build with newer versions of Visual Studio.
8096 * w32.c: Don't include w32api.h for MSVC.
8097 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8098
8099 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8100 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8101 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8102 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8103 e_* cousins.
8104 (alloca) [_MSC_VER]: Define to _alloca.
8105
8106 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8107
8108 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8109
a58c13ed
EZ
81102011-11-04 Eli Zaretskii <eliz@gnu.org>
8111
8112 * xdisp.c (note_mouse_highlight): If either of
8113 previous/next-single-property-change returns nil, treat that as
8114 the beginning or the end of the buffer. (Bug#9955)
8115
fe0b6370
JD
81162011-11-04 Jan Djärv <jan.h.d@swipnet.se>
8117
a58c13ed 8118 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8119 label is not null (Bug#9951).
8120 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8121 may be NULL.
8122
89bd5ee1
EZ
81232011-11-04 Eli Zaretskii <eliz@gnu.org>
8124
8125 * window.c (Fwindow_body_size): Mention in the doc string that the
8126 return value is in frame's canonical units. (Bug#9949)
8127
84c3edb9
EZ
81282011-11-03 Eli Zaretskii <eliz@gnu.org>
8129
4e2fb5c7
EZ
8130 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8131
84c3edb9 8132 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8133 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8134 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8135
bc17a887
EZ
81362011-11-01 Eli Zaretskii <eliz@gnu.org>
8137
8138 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8139 Don't stop backward scan on the continuation glyph, even though
8140 its CHARPOS is positive.
6d5eb5b0
SM
8141 (mouse_face_from_buffer_pos, note_mouse_highlight):
8142 Rename cover_string to disp_string.
bc17a887 8143
4ee88440
MR
81442011-11-01 Martin Rudalics <rudalics@gmx.at>
8145
8146 * window.c (temp_output_buffer_show): Don't use
8147 Vtemp_buffer_show_specifiers.
8148 (Vtemp_buffer_show_specifiers): Remove unused variable.
8149
c2ff3c02
EZ
81502011-10-30 Eli Zaretskii <eliz@gnu.org>
8151
8152 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8153 past the beginning of the current glyph matrix.
8154
58179cce 81552011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8156
8157 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8158 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8159 HAVE_GTK3 (Bug#9869).
b77a6a7f 8160
3b574623
JD
8161 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8162 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8163
b77a6a7f
JD
8164 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8165
8166 * xterm.c: Declare x_handle_net_wm_state to return int.
8167 (handle_one_xevent): Check if we are iconified but don't have
8168 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8169 (get_current_wm_state): Return non-zero if not hidden,
8170 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8171 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8172 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8173 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8174
196e41e4
PE
81752011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8176
8177 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8178 so that this new function doesn't get optimized away by a
8179 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8180
021f2e1a
AS
81812011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8182
8183 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8184
8b058d44
EZ
81852011-10-29 Eli Zaretskii <eliz@gnu.org>
8186
8187 Fix the `xbytecode' command.
8188 * .gdbinit (xprintbytestr): New command.
b50a28de 8189 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8190 (xbytecode): Print the byte-code string as well.
8191
4452fb80
EZ
81922011-10-29 Kim Storm <storm@cua.dk>
8193
8b058d44
EZ
8194 * alloc.c (which_symbols): New function.
8195
21b72067
AS
81962011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8197
8198 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8199 line. (Bug#9903)
8200
83ed7b5c
GM
82012011-10-29 Glenn Morris <rgm@gnu.org>
8202
8203 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8204 Not clear what it was for, and it causes various bugs. (Bug#9839)
8205
5a7a728b
EZ
82062011-10-28 Eli Zaretskii <eliz@gnu.org>
8207
8208 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
8209 possible random value that matches one of those tested as
8210 condition to clear the mouse face.
8211
d3d0842f
CY
82122011-10-28 Chong Yidong <cyd@gnu.org>
8213
8214 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
8215
31b39d13
DN
82162011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
8217
8218 * window.c (make_window): Initialize phys_cursor_on_p.
8219
9aba6043
SM
82202011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
8221
8222 * lisp.h (struct Lisp_Symbol): Update comments.
8223
c20992f4
JB
82242011-10-28 Juanma Barranquero <lekktu@gmail.com>
8225
8226 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
8227
db4f02f2
EZ
82282011-10-28 Eli Zaretskii <eliz@gnu.org>
8229
8230 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8231 <oslsachem@gmail.com> for helping to debug this.
8232
8233 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
8234 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
8235 (g_b_init_get_glyph_outline_w): New static variables.
8236 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
8237 (GetGlyphOutlineW_Proc): New typedefs.
8238 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
8239 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
8240 New functions.
8241 (w32font_open_internal, compute_metrics):
8242 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
8243 instead of calling the "wide" APIs directly.
8244
8245 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
8246
8247 * w32.h (syms_of_w32font): Add prototype.
8248
87e68db4
JB
82492011-10-27 Juanma Barranquero <lekktu@gmail.com>
8250
8251 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
8252 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
8253 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
8254 (Fmove_to_window_line): Doc fix.
8255
435c1d67
CY
82562011-10-27 Chong Yidong <cyd@gnu.org>
8257
8258 * process.c (make_process): Set gnutls_state to NULL.
8259
8260 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
8261 non-NULL, regardless of GNUTLS_INITSTAGE.
8262 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8263 an error. Set process slots as soon as we allocate them.
8264
8265 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
8266
9c6c6f49
CY
82672011-10-27 Chong Yidong <cyd@gnu.org>
8268
9aba6043
SM
8269 * gnutls.c (emacs_gnutls_deinit): New function.
8270 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
8271 (Fgnutls_deinit, Fgnutls_boot): Use it.
8272
8273 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8274 (deactivate_process): Call emacs_gnutls_deinit.
8275
657d08d3
JB
82762011-10-27 Juanma Barranquero <lekktu@gmail.com>
8277
8278 * image.c (x_create_x_image_and_pixmap):
8279 * w32.c (sys_rename, w32_delayed_load):
8280 * w32font.c (fill_in_logfont):
8281 * w32reg.c (x_get_string_resource): Silence compiler warnings.
8282
5430d399
JB
82832011-10-26 Juanma Barranquero <lekktu@gmail.com>
8284
8285 * w32fns.c (w32_default_color_map): New function,
8286 extracted from Fw32_default_color_map.
a7ef684b 8287 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 8288
fe0055fa
PE
82892011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8290
8291 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
8292
e6346438
SM
82932011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
8294
8295 * keyboard.c (test_undefined): New function (bug#9751).
8296 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
8297
e112cc37
ET
82982011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
8299
8300 * sysdep.c (init_sys_modes): Fix the check for the controlling
8301 terminal (Bug#6649).
8302
7b5d6677
EZ
83032011-10-20 Eli Zaretskii <eliz@gnu.org>
8304
8305 * dispextern.h (struct bidi_it): New member next_en_type.
8306
8307 * bidi.c (bidi_line_init): Initialize the next_en_type member.
8308 (bidi_resolve_explicit_1): When next_en_pos is valid for the
8309 current character, check also for next_en_type being WEAK_EN.
8310 (bidi_resolve_weak): Don't enter the expensive loop if the current
8311 position is before next_en_pos. Record the bidi type of the first
8312 non-ET, non-BN character we find, in addition to its position.
8313 (bidi_level_of_next_char): Invalidate next_en_type when
8314 next_en_pos is over-stepped.
8315
7da0b018
PE
83162011-10-20 Paul Eggert <eggert@cs.ucla.edu>
8317
8318 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
8319 * editfns.c: Rewrite current-time-zone so that it invokes
8320 the equivalent of (format-time-string "%Z") to get the time zone name.
8321 This fixes a bug when the time zone name contains characters that
8322 need converting from the system time locale to Emacs internal format.
8323 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
8324 that patch fixed format-time-string to do the conversion, but
8325 I forgot to fix current-time-zone.
8326 (format_time_string): New function, containing most of
8327 what Fformat_time_string used to contain.
8328 (Fformat_time_string): Rewrite in terms of format_time_string.
8329 This doesn't change this function's behavior.
8330 (current-time-zone): Rewrite to use format_time_string.
8331 This fixes the bug reported by Michael Schierl in
8332 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
8333 Jason Rumney's 2007-06-07 change worked around this bug, but
8334 didn't fix it.
8335 * systime.h (tzname, timezone): Remove no-longer-used declarations.
8336
8547b010
EZ
83372011-10-19 Eli Zaretskii <eliz@gnu.org>
8338
8339 * xdisp.c (start_display): If the character at POS is displayed
8340 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
8341 (try_window_reusing_current_matrix): If a line ends in a display
8342 vector or the next line starts in a display vector, continue
8343 redrawing the window even though the character position of
8344 start_row was reached.
8547b010
EZ
8345 (Bug#9771, part 2)
8346
4e948d15
CY
83472011-10-18 Chong Yidong <cyd@gnu.org>
8348
8349 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
8350 with nobreak-char-display too.
8351
4787455f
EZ
83522011-10-18 Eli Zaretskii <eliz@gnu.org>
8353
8354 Fix part 3 of bug#9771.
8355 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
8356 (bidi_resolve_neutral): Don't enter the expensive loop looking for
8357 non-neutral characters if the current character is a paragraph
8358 separator (a.k.a. Newline). This avoids running the same
8359 expensive loop twice, once when we consume the preceding newline
8360 and the other time when the line actually needs to be displayed.
8361 Avoid the loop when we see neutrals on the base embedding level
8362 following a character whose directionality is the same as the
8363 paragraph's. This avoids running the expensive loop when a line
8364 ends in a long sequence of neutrals, like control characters.
8365 Add assertion against STRONG_AL type. Slightly rearrange code
8366 that determines the type of a neutral given the first non-neutral
8367 that follows it.
8368 (bidi_level_of_next_char): Set next_en_pos to zero when
8369 invalidating its info.
8370
2c91f553
EZ
83712011-10-17 Eli Zaretskii <eliz@gnu.org>
8372
8373 * xdisp.c (push_display_prop): Determine whether to record string
8374 or buffer position by IT->string, not by IT->method. Allow
8375 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
8376 (move_it_vertically_backward): Don't look for character position
8377 immediately after the newline when in a continuation line.
8378 (Bug#9771, part 1)
2c91f553 8379
c7b08b0d
MR
83802011-10-15 Martin Rudalics <rudalics@gmx.at>
8381
8382 * window.c (coordinates_in_window): Rewrite and delabelize
8383 vertical border check. (Bug#5357) (Bug#9618)
8384
6b02f655
SM
83852011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
8386
8387 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
8388 errors in XSetWindowBorder (bug#9310).
8389
81d40c92
DA
83902011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
8391
8392 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
8393 avoid crash when xmalloc overrun checking is enabled.
8394
d4172c3b
EZ
83952011-10-13 Eli Zaretskii <eliz@gnu.org>
8396
8397 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
8398 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
8399 cursor motion with <left> and <right> arrow keys.
8400
8401 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8402 some callers set that themselves.
8403
b00eea75
EZ
84042011-10-12 Eli Zaretskii <eliz@gnu.org>
8405
8406 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
8407 display string and the previous row comes from the same string and
8408 is empty. (Bug#9739) (Bug#9738)
8409
8fe012c4
SM
84102011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8411
8412 * doc.c (get_doc_string): Encode file name (bug#9735).
8413
0074aef2
EZ
84142011-10-12 Eli Zaretskii <eliz@gnu.org>
8415
79beb178
EZ
8416 * bidi.c (bidi_level_of_next_char):
8417 * xdisp.c (get_visually_first_element): Remove old incorrect
8418 comments regarding the Unicode Line Separator character.
8419
0074aef2
EZ
8420 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
8421
6e4b3fbe
DA
84222011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
8423
8424 * alloc.c (Fgc_status): Do not access beyond zombies array
8425 boundary if nzombies > MAX_ZOMBIES.
8426 * alloc.c (dump_zombies): Add missing format specifier.
8427
0324f3af
PE
84282011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8429
b5525cac
PE
8430 * xdisp.c (set_cursor_from_row): Simplify conditionals,
8431 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
8432
0324f3af
PE
8433 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
8434 Some packages use them to denote characters with modifiers.
8435
e9b5f888
AS
84362011-10-11 Andreas Schwab <schwab@linux-m68k.org>
8437
8438 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
8439 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
8440 matching a pp-number. Rename parameter var to var1.
8441
127827c0
SM
84422011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8443
8444 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
8445
c8fd3bd0
GM
84462011-10-08 Glenn Morris <rgm@gnu.org>
8447
8448 * callint.c (Fcall_interactively): Give a more explicit error for the
8449 'c' case with a non-character input. (Bug#8479)
8450
352ec8ff
EZ
84512011-10-08 Eli Zaretskii <eliz@gnu.org>
8452
03669ccb
EZ
8453 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
8454 lines.
7061c986
EZ
8455 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
8456 lines that are hscrolled on the left.
03669ccb 8457
352ec8ff
EZ
8458 * dispnew.c (buffer_posn_from_coords): Account for a possible
8459 presence of header-line. (Bug#4426)
8460
a66cfb1c
SM
84612011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
8462
6b02f655
SM
8463 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
8464 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 8465
7c5ee88e
PE
84662011-10-07 Paul Eggert <eggert@cs.ucla.edu>
8467
8468 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
8469 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
8470 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
8471 this makes Emacs dump core during garbage collection on rare
8472 occasions. sizeof is obviously inferior to offsetof here, so
8473 stick with offsetof.
8474 (GC_POINTER_ALIGNMENT): New macro.
8475 (mark_memory): Omit 3rd (offset) arg; caller changed.
8476 Don't assume EMACS_INT alignment is the same as pointer alignment.
8477
df1bbe5b
SM
84782011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
8479
8480 * keyboard.c (read_key_sequence_remapped): New var.
8481 (read_key_sequence): Compute remapping in the right buffer.
8482 (command_loop_1): Use read_key_sequence's remapping directly.
8483
51553db6
SM
84842011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
8485
32c1fffd
SM
8486 * dired.c (file_name_completion): Don't expand file name.
8487 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8488 before checking file name handler.
8489
51553db6
SM
8490 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8491 they've been requested explicitly (bug#9591).
8492
b6bd1599 84932011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8494
8495 * keymap.c (Fsingle_key_description): Use make_specified_string
8496 instead of build_string to build string from push_key_description.
8497 (Bug#5193)
8498
f701dc2a
PE
84992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8500
4222c55d
PE
8501 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8502 This fixes a Y2038 bug on 64-bit hosts.
8503 * buffer.c (reset_buffer):
8504 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8505 (Fclear_buffer_auto_save_failure):
8506 Use 0, not -1, to represent an unset failure time, since time_t
8507 might not be signed.
8508
f701dc2a
PE
8509 Remove dependency on glibc malloc internals.
8510 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8511 Move back here from lisp.h, but with their new implementations.
8512 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8513 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8514 * charset.c (charset_table_init): New static var.
8515 (syms_of_charset): Use it instead of xmalloc. This removes a
8516 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8517 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8518 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8519 Move back to alloc.c.
8520 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8521 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8522
9ceebf39
JD
85232011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8524
8525 * nsterm.m (windowDidResize): Call x_set_window_size only when
8526 ns_in_resize is true. Otherwise set pixelwidth/height and
8527 call change_frame_size (Bug#9628).
8528
cb993c58
PE
85292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8530
3930c88b
PE
8531 Port --enable-checking=all to Fedora 14 x86-64.
8532 * charset.c (syms_of_charset): Also account for glibc malloc's
8533 internal overhead when calculating the initial malloc maximum.
8534
cb993c58
PE
8535 Port --enable-checking=all to Fedora 14 x86.
8536 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8537 Move to lisp.h.
8538 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8539 (overrun_check_realloc, overrun_check_free):
8540 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8541 That way, xmalloc returns a properly-aligned pointer even if
8542 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8543 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8544 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8545 into account when calculating the initial malloc maximum.
8546 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8547 Move here from alloc.c, so that charset.c can use it too.
8548 Properly align; the old code wasn't right for common 32-bit hosts
8549 when configured with --enable-checking=all.
8550 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8551 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8552
31bed486
EZ
85532011-09-29 Eli Zaretskii <eliz@gnu.org>
8554
04c70788 8555 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8556 use EDOM.
8557
fbcaa2f3
EZ
85582011-09-28 Eli Zaretskii <eliz@gnu.org>
8559
8560 * xdisp.c (compute_display_string_end): If there's no display
8561 string at CHARPOS, return -1.
8562
8563 * bidi.c (bidi_fetch_char): When compute_display_string_end
8564 returns a negative value, treat the character as a normal
8565 character not covered by a display string. (Bug#9624)
8566
a239d4e9
JB
85672011-09-28 Juanma Barranquero <lekktu@gmail.com>
8568
8569 * lread.c (Fread_from_string): Fix typo in docstring.
8570
88652fd5
EZ
85712011-09-27 Eli Zaretskii <eliz@gnu.org>
8572
8573 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8574 newline, reseat the iterator instead of bidi-iterating there one
8575 character at a time. (Bug#9610)
32c1fffd
SM
8576 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8577 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8578
ed497dd4
AS
85792011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8580
8581 * lread.c (readevalloop): Use correct code for NBSP.
8582 (read1): Likewise. (Bug#9608)
8583
b2bf61aa
MA
85842011-09-25 Michael Albinus <michael.albinus@gmx.de>
8585
8586 * dbusbind.c (Fdbus_register_signal): When service is not
8587 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8588
32bbb17c
GM
85892011-09-25 Glenn Morris <rgm@gnu.org>
8590
8591 * buffer.c (truncate-lines): Doc fix.
8592
94e0933e
CY
85932011-09-24 Chong Yidong <cyd@stupidchicken.com>
8594
8595 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8596 (Fset_window_next_buffers): Doc fix.
8597
cddde921
GM
85982011-09-24 Glenn Morris <rgm@gnu.org>
8599
8600 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8601
1260aef1
PE
86022011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8603
25b4bfa0
PE
8604 Fix minor problems found by static checking.
8605 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8606 * indent.c (Fvertical_motion): Fix == vs = typo.
8607
e3cbd34b
EZ
86082011-09-24 Eli Zaretskii <eliz@gnu.org>
8609
a66cfb1c
SM
8610 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8611 Default value is now t. Doc fix.
6bf7006f 8612
e3cbd34b 8613 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8614 logic when moving up, not only when moving down. Fix the
e3cbd34b 8615 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8616 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8617
8618 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8619 CHARPOS is covered by a display string which includes newlines.
8620 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8621 is covered by a display string with embedded newlines.
8622
a3de0cbd
MA
86232011-09-24 Michael Albinus <michael.albinus@gmx.de>
8624
8625 * dbusbind.c (Fdbus_register_signal): Add match rule to
8626 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8627 (Fdbus_register_method, Vdbus_registered_objects_table):
8628 Fix docstring.
a3de0cbd 8629
b260039d
JM
86302011-09-24 Jim Meyering <meyering@redhat.com>
8631
32c1fffd 8632 do not ignore write error for any output size
b260039d
JM
8633 The previous change was incomplete.
8634 While it makes emacs --batch detect the vast majority of stdout
8635 write failures, errors were still ignored whenever the output size is
8636 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8637 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8638 && echo FAIL: ignored write error
8639 FAIL: ignored write error
8640 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8641 && echo FAIL: ignored write error
8642 FAIL: ignored write error
8643 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8644
8eca8a7c
AS
86452011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8646
8647 * emacs.c (Fkill_emacs): In noninteractive mode exit
8648 non-successfully if a write error occurred on stdout. (Bug#9574)
8649
3341db62
EZ
86502011-09-21 Eli Zaretskii <eliz@gnu.org>
8651
8652 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8653 the xassert test.
8654
8655 * dispextern.h (struct it): Update the comment documenting what
8656 can it->OBJECT be.
8657
8c203dbf
EZ
86582011-09-20 Eli Zaretskii <eliz@gnu.org>
8659
8660 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8661 a display string, extend search for cursor position to end of row.
8662 (find_row_edges): If the row ends in a newline from a display
8663 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8664 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8665 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8666 non-empty line. Fixes confusing cursor motion with arrow keys at
8667 the beginning of a line that starts with whitespace.
8c203dbf 8668
a4824228
LMI
86692011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8670
8671 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8672 (bug#9493).
8673
33ed493b
CY
86742011-09-18 Chong Yidong <cyd@stupidchicken.com>
8675
8676 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8677 boolean (Bug#9154).
8678
56cd55c8
EZ
86792011-09-18 Eli Zaretskii <eliz@gnu.org>
8680
8681 * xdisp.c (display_line): Record maximum and minimum buffer
8682 positions even if no glyphs were produced (e.g., by a zero-width
8683 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8684 buffer positions that will be removed from the glyph row because
8685 they don't fit.
c02dcedf
EZ
8686 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8687 column is beyond frame width: don't subtract 1 "pixel" when
8688 computing width of the stretch.
3e62b7e0
EZ
8689 (reseat_at_next_visible_line_start): Undo the change made on
8690 2011-09-17 that saved paragraph information and restored it after
8691 the call to `reseat'. (Bug#9545)
56cd55c8 8692
5ed99d36 86932011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8694
8695 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8696 and turn window cursor on if cleared (Bug#9415).
8697
5ed99d36 86982011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8699
8700 * search.c (boyer_moore): Take unibyte characters from pattern
8701 literally. (Bug#9458)
8702
9bade7b2
EZ
87032011-09-18 Eli Zaretskii <eliz@gnu.org>
8704
8705 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8706
e5e9d610
PE
87072011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8708
87e4427a
PE
8709 Fix minor problem found by static checking.
8710 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8711 initialized, to pacify gcc -Wuninitialized.
8712
e5e9d610
PE
8713 * fileio.c: Report proper errno when syscall falls.
8714 (Finsert_file_contents): Save and restore errno,
8715 so that report_file_error outputs the correct diagnostic.
8716 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8717
a1674f0b
EZ
87182011-09-18 Eli Zaretskii <eliz@gnu.org>
8719
8720 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8721
fbfb6dd4
EZ
87222011-09-17 Eli Zaretskii <eliz@gnu.org>
8723
8724 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8725 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8726
bb187662
EZ
87272011-09-17 Eli Zaretskii <eliz@gnu.org>
8728
1137e8b8 8729 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8730 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8731
8732 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8733 (bidi_find_paragraph_start): Search back for paragraph beginning
8734 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8735 (bidi_move_to_visually_next): Only trigger paragraph-related
8736 computations when the last character is a newline or at EOB, not
8737 just any NEUTRAL_B. (Bug#9470)
8738
bb187662
EZ
8739 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8740 truncated lines if point is covered by a display string. (Bug#9524)
8741
2e621251
PE
87422011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8743
8744 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8745 (cons_to_x_long): New function.
8746 (lisp_data_to_selection_data): Use it. Correct the test for
8747 short-versus-long data; it was negated. Break out of vector
8748 loop, for efficiency, when a long datum is discovered.
8749
91a15bc6
SM
87502011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8751
8752 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8753
b41c3a35
EZ
87542011-09-16 Eli Zaretskii <eliz@gnu.org>
8755
8756 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8757 GCC PR/17406) by declaring this function with external scope.
8758
7812ba2d
PE
87592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8760
8761 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8762 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8763
cf7edc2a
AS
87642011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8765
8766 * editfns.c (Fformat): Correctly handle text properties on "%%".
8767
bd01620e
EZ
87682011-09-15 Eli Zaretskii <eliz@gnu.org>
8769
8770 * xterm.c (x_draw_composite_glyph_string_foreground):
8771 * w32term.c (x_draw_composite_glyph_string_foreground):
8772 * term.c (encode_terminal_code):
8773 * composite.c (composition_update_it, get_composition_id):
8774 * xdisp.c (get_next_display_element)
8775 (fill_composite_glyph_string): Add comments about special meaning
8776 of TAB characters in a composition.
8777
a02719a3
PE
87782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8779
8780 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8781 This occurs when processing a multibyte format.
8782 Problem reported by Wolfgang Jenker.
a02719a3 8783
72589a3c
JB
87842011-09-15 Johan Bockgård <bojohan@gnu.org>
8785
8786 * xdisp.c (try_cursor_movement): Only check for exact match if
8787 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8788
1c14176c
PE
87892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8790
8791 Remove unused external symbols.
8792 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8793 * xdisp.c (calc_pixel_width_or_height): Now static.
8794 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8795 * indent.c (check_display_width):
8796 * w32term.c: Fix comment to match code.
8797 * xterm.c, xterm.h (x_catching_errors): Remove.
8798
d2eea5b5
PE
87992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8800
8801 * xselect.c: Use signed conversions more consistently (Bug#9498).
8802 (selection_data_to_lisp_data): Assume incoming selection data are
8803 signed integers, not unsigned. This is to be consistent with
8804 outgoing selection data, which was modified to use signed integers
8805 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8806 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8807 expects long, not unsigned long.
8808
46888499
EZ
88092011-09-14 Eli Zaretskii <eliz@gnu.org>
8810
8811 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8812 computation of loop end. Reported by Johan Bockgård
8813 <bojohan@gnu.org>.
8814
ef8ef9fb
CY
88152011-09-13 Chong Yidong <cyd@stupidchicken.com>
8816
8817 * frame.c (Fother_visible_frames_p): Function deleted.
8818
fa819fed
EZ
88192011-09-12 Eli Zaretskii <eliz@gnu.org>
8820
8821 * indent.c (compute_motion): Process display vector front to back
8822 rather than the other way around. (Bug#2496)
8823
2ba8e008
SM
88242011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8825
8826 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8827
20f53c69
CY
88282011-09-11 Chong Yidong <cyd@stupidchicken.com>
8829
8830 * minibuf.c (Fread_from_minibuffer): Doc fix.
8831
d562d7a4
EZ
88322011-09-11 Eli Zaretskii <eliz@gnu.org>
8833
8834 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8835 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8836
1c4d7f3d
LMI
88372011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8838
8839 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8840 value for non-existent files.
8841
b885bf36
EZ
88422011-09-11 Eli Zaretskii <eliz@gnu.org>
8843
8844 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8845 set its "size" to -1. This will set the modtime_size field of
8846 the corresponding buffer to -1, which is what
8847 verify-visited-file-modtime expects for files that do not exist.
8848 (Bug#9139)
8849
6612f0bf
PE
88502011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8851
8852 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8853 here ...
8854 * lisp.h: ... from here. push_key_description is no longer
8855 defined in keyboard.c, so its declaration should not be in
8856 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8857 logically belongs with push_key_description.
8858
dfb3f755
PE
88592011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8860
8861 * buffer.h: Include <sys/types.h> instead of <time.h>.
8862 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8863 Problem reported by Herbert J. Skuhra.
8864
3134906c
LMI
88652011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8866
8867 * xml.c (parse_region): Make the parsing work for
8868 non-comment-starting XML files again (bug#9144).
8869
8d903f4e
AS
88702011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8871
8872 * image.c (gif_load): Fix calculation of bottom and right corner.
8873 (Bug#9468)
8874
80ad64f4
EZ
88752011-09-10 Eli Zaretskii <eliz@gnu.org>
8876
8877 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8878 redisplay in small windows.
8879
208a048d
EZ
88802011-09-09 Eli Zaretskii <eliz@gnu.org>
8881
8882 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8883
9b1c252e
MR
88842011-09-08 Martin Rudalics <rudalics@gmx.at>
8885
8886 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8887 Operate on live windows only.
8888
2949f33b
JB
88892011-09-08 Juanma Barranquero <lekktu@gmail.com>
8890
8891 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8892
e08dcafd
EZ
88932011-09-07 Eli Zaretskii <eliz@gnu.org>
8894
8895 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8896 only under bidi iteration.
8897
115b96bd
JD
88982011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8899
8900 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8901
c8199d0f
PE
89022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8903
8904 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8905 Without this fix, the command to link temacs failed due to an
8906 undefined symbol __builtin_isnan. This is because
8907 /usr/include/iso/math_c99.h #defines isnan(x) to
8908 __builtin_isnan(x), but the bundled gcc, which identifies itself
8909 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8910 a __builtin_isnan.
8911 * floatfns.c (isnan): #undef, and then #define to a clone of
8912 what's in data.c.
8913 (Fisnan): Always define, since it's always available now.
8914 (syms_of_floatfns): Always define isnan at the Lisp level.
8915
e39b275c 89162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8917
8918 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8919
b2db44d9 89202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8921
f4af5137 8922 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8923 The previous code assumed that file offsets (off_t values) fit in
8924 EMACS_INT variables, which is not true on typical 32-bit hosts.
8925 The code messed up by falsely reporting buffer overflow in cases
8926 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8927 when "big" contains more than 2**29 bytes, even though this
8928 inserts just one byte and does not overflow the buffer.
8929 (Finsert_file_contents): Store file offsets as off_t
8930 values, not as EMACS_INT values. Check for overflow when
8931 converting between EMACS_INT and off_t. When checking for
8932 buffer overflow or for overlap, take the offsets into account.
8933 Don't use EMACS_INT for small values where int suffices.
8934 When checking for overlap, fix a typo: ZV was used where
8935 ZV_BYTE was intended.
8936 (Fwrite_region): Don't assume off_t fits into 'long'.
8937 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8938
ecfc0a49
MA
89392011-09-05 Michael Albinus <michael.albinus@gmx.de>
8940
8941 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8942
6511acf2 89432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8944
0999621a 8945 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8946
8947 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8948 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8949 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8950 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8951 (modify_event_symbol): Do not assume that the length of
8952 name_alist_or_stem is safe to alloca and fits in int.
8953 (Fexecute_extended_command): Likewise for function name and binding.
8954 (Frecursion_depth): Wrap around reliably on integer overflow.
8955 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8956 since some callers pass EMACS_INT values.
8957 (Fsingle_key_description): Don't crash if symbol name contains more
8958 than MAX_ALLOCA bytes.
8959 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8960 (get_minibuffer): Arg is now EMACS_INT, not int.
8961 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8962 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8963 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8964
2be7d702
PE
8965 * dbusbind.c (signature_cat): New function.
8966 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8967 Do not overrun buffer; instead, report string overflow.
8968
9d1df220
PE
8969 * dispnew.c (add_window_display_history): Don't overrun buffer.
8970 Truncate instead; this is OK since it's just a log.
8971
33ef5c64
PE
8972 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8973 even if the time zone offset is outlandishly large.
8974 Don't mishandle offset == INT_MIN.
8975
66c6fdd5
PE
8976 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8977 when creating daemon; the previous buffer-overflow check was incorrect.
8978
d749b01b
PE
8979 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8980 which has the guts of the old verror function.
8981
b5cd1905
PE
8982 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8983 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8984
6e1a67fb
PE
8985 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8986 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8987 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8988 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8989 length of string rather than counting it via multiple sprintfs;
8990 that's simpler and more reliable.
c21721cc
PE
8991 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8992 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8993 sprintf, in case result does not fit in int.
8994
c57b67fc
PE
8995 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8996 (fontset_from_font): Print it.
8997
8a401434
PE
8998 * frame.c (tty_frame_count): Now printmax_t, not int.
8999 (make_terminal_frame, set_term_frame_name): Print it.
9000 (x_report_frame_params): In X, window IDs are unsigned long,
9001 not signed long, so print them as unsigned.
9002 (validate_x_resource_name): Check for implausibly long names,
9003 and don't assume name length fits in 'int'.
9004 (x_get_resource_string): Don't blindly alloca invocation name;
9005 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9006 not fit in int.
9007
6e1a67fb
PE
9008 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9009 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9010 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9011
0df02bf3
PE
9012 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9013 Use esprintf, not sprintf, in case result does not fit in int.
9014
48e30793
PE
9015 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9016 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9017 it as a large positive number.
9018 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9019 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9020
a66ff6d8
PE
9021 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9022 in case result does not fit in int.
9023
aca216ff
PE
9024 * print.c (float_to_string): Detect width overflow more reliably.
9025 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9026 buffer overrun. Don't assume list length fits in 'int'. Treat
9027 print length of 0 as 0, not as infinity; to be consistent with other
9028 uses of print length in this function. Don't overflow print length
9029 index. Don't assume hash table size fits in 'long', or that
9030 vectorlike size fits in 'unsigned long'.
9031
31c286f7
PE
9032 * process.c (make_process): Use printmax_t, not int, to format
9033 process-name gensyms.
9034
55e5faa1
PE
9035 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9036
80f2e268
PE
9037 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9038 to avoid potential buffer overrun.
9039
670741ab
PE
9040 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9041 if X resource line is longer than 512 bytes.
9042
b7163a50
PE
9043 * xfns.c (x_window): Make sprintf buffer a bit bigger
9044 to avoid potential buffer overrun.
9045
ae58ff1f
PE
9046 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9047
c43c8a6a
PE
9048 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9049
3f8236f4
PE
90502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9051
53e9fe90 9052 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9053 Without these, Emacs silently mishandles large integers sometimes.
9054 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9055 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9056
6511acf2
PE
9057 * xdisp.c (try_window_id): Check Emacs fixnum range before
9058 converting to 'int'.
806add1d 9059
6511acf2 9060 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9061 Check that an Emacs fixnum is in range before assigning it to 'int'.
9062 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9063 values converted from Emacs fixnums.
9064 (Frecenter): Don't wrap around a line count if it is out of 'int'
9065 range; instead, treat it as an extreme value.
9066 (Fset_window_configuration, compare_window_configurations):
9067 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9068
6511acf2
PE
9069 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9070 that can exceed INT_MAX. Check that EMACS_INT value is in range
9071 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9072 (match_limit): Don't assume that a fixnum can fit in 'int'.
9073
6511acf2 9074 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9075 exceed INT_MAX.
9076
6511acf2 9077 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9078 (Fvertical_motion): Don't wrap around LINES values that don't fit
9079 in 'int'. Instead, treat them as extreme values. This is good
9080 enough for windows, which can't have more than INT_MAX lines anyway.
9081
fcb901a7
LMI
90822011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9083
0f2f6b6d
LMI
9084 * Require libxml/parser.h to avoid compilation warning.
9085
fcb901a7
LMI
9086 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9087
9088 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9089 since this reportedly can destroy thread storage.
9090
6e20a0d4
CY
90912011-08-30 Chong Yidong <cyd@stupidchicken.com>
9092
9093 * syntax.c (find_defun_start): Update all cache variables if
9094 exiting early (Bug#9401).
9095
148ae00e
EZ
90962011-08-30 Eli Zaretskii <eliz@gnu.org>
9097
f6cfbd8f
EZ
9098 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9099
148ae00e
EZ
9100 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9101 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9102 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9103
9104 * term.c (tty_append_glyph): New function.
9105 (produce_stretch_glyph): Static function and its prototype deleted.
9106
a66cfb1c
SM
9107 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9108 Add prototypes.
148ae00e 9109
c4a07a4c
PE
91102011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9111
9112 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9113 when checking :margin (Bug#9390).
9114 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 9115 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
9116 so that the name doesn't mislead. All uses changed.
9117
6bc8cd65
JB
91182011-08-28 Johan Bockgård <bojohan@gnu.org>
9119
9120 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9121 set_tty_hooks.
9122
dca4927e
EZ
91232011-08-27 Eli Zaretskii <eliz@gnu.org>
9124
9125 * xdisp.c (move_it_to): Don't bail out early when reaching
9126 position beyond to_charpos, if we are scanning backwards.
9127 (move_it_vertically_backward): When DY == 0, make sure we get to
9128 the first character in the line after the newline.
9129
f2cad773
PE
91302011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9131
9132 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9133 (ccl_driver): Do not generate an out-of-range pointer.
9134 (Fccl_execute_on_string): Remove unnecessary check for
9135 integer overflow, noted by Stefan Monnier in
9136 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9137 Remove a FIXME that didn't need fixing.
9138 Simplify the newly-introduced buffer reallocation code.
9139
0cae2cdb
JB
91402011-08-27 Juanma Barranquero <lekktu@gmail.com>
9141
9142 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9143
5fc295a4 91442011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9145
70c60eb2 9146 Integer and memory overflow issues (Bug#9196).
726e0ab1 9147
d31850da
PE
9148 * doc.c (get_doc_string): Rework so that
9149 get_doc_string_buffer_size is the actual buffer size, rather than
9150 being 1 less than the actual buffer size; this makes xpalloc more
9151 convenient.
9152
a69fbedb
PE
9153 * image.c (x_allocate_bitmap_record, cache_image):
9154 * xselect.c (Fx_register_dnd_atom):
9155 Simplify previous changes by using xpalloc.
9156
fe5c5d37
PE
9157 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9158 since either will do and ptrdiff_t is convenient with xpalloc.
9159
0065d054
PE
9160 * charset.c (charset_table_size)
9161 (struct charset_sort_data.priority): Now ptrdiff_t.
9162 (charset_compare): Don't overflow if priorities differ greatly.
9163 (Fsort_charsets): Don't assume list length fits in int.
9164 Check for size-calculation overflow when allocating sort data.
9165 (syms_of_charset): Allocate an initial charset table that is
9166 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9167
9168 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9169
9170 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9171 The actual value is always <= INT_MAX, and leaving it unsigned made
9172 overflow checking harder.
9173
9174 * dispextern.h (struct glyph_matrix.rows_allocated)
9175 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9176 with xpalloc. The values are still always <= INT_MAX.
9177
9178 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9179
9180 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9181 (SAFE_NALLOCA): New macro.
9182
9183 * region-cache.c (struct boundary.pos, find_cache_boundary)
9184 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9185 (set_cache_region, invalidate_region_cache)
9186 (revalidate_region_cache, know_region_cache, region_cache_forward)
9187 (region_cache_backward, pp_cache):
9188 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9189 so that ptrdiff_t * can be passed to xpalloc.
9190 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9191 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9192 (pp_cache): Don't assume cache_len fits in int.
9193 * region-cache.h: Adjust extern decls to match.
9194
9195 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9196 EMACS_INT, since either will do, for xpalloc.
9197
9198 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9199 (xnmalloc, xnrealloc, xpalloc): New functions.
9200
726e0ab1
PE
9201 * bidi.c (bidi_shelve_header_size): New constant.
9202 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9203 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9204
51f30bc5 9205 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9206 * buffer.c (overlays_at, overlays_in, record_overlay_string)
9207 (overlay_strings):
9208 Don't update size of array until after memory allocation succeeds,
9209 because xmalloc/xrealloc may not return.
0065d054
PE
9210 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
9211 now that we have proper integer overflow checking.
9212 (record_overlay_string, overlay_strings): Catch overflows when
9213 calculating size of overlay_str_buf.
726e0ab1 9214
0065d054
PE
9215 * callproc.c (Fcall_process): Check for size overflow when
9216 calculating size of args2.
9217 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
9218 Normally we prefer signed values, but sticking with ptrdiff_t would
9219 require adding more-complicated checks.
726e0ab1
PE
9220
9221 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
9222 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
9223 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 9224 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
9225
9226 * character.c (Fstring): Check for size-calculation overflow.
9227
9228 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
9229 unnecessary integer overflow. Check for size overflow.
9230 (encode_coding_object): Don't update size until xmalloc succeeds.
9231
9232 * composite.c (get_composition_id): Check for overflow in glyph
9233 length calculations.
9234
9235 Integer and memory overflow fixes for display code.
9236 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
9237 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
9238 (scrolling_window): Check for overflow in size calculations.
9239 (line_draw_cost, realloc_glyph_pool, add_row_entry):
9240 Don't assume glyph table len fits in int.
9241 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
9242 (row_table_size): Now ptrdiff_t, not int.
9243 (scrolling_window): Avoid overflow in size calculations.
9244 Don't update size until allocation succeeds.
9245 * fns.c (concat): Check for overflow in size calculations.
9246 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
9247 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9248 (NEXT_ALMOST_PRIME_LIMIT): New constant.
9249
9250 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
9251 (get_doc_string): Check for size calculation overflow.
9252 Don't update size until allocation succeeds.
9253 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
9254 EMACS_INT, where ptrdiff_t will do.
9255 (Fsubstitute_command_keys): Check for string overflow.
9256
9257 * editfns.c (set_time_zone_rule): Don't assume environment length
9258 fits in int.
9259 (message_length): Now ptrdiff_t, not int.
9260 (Fmessage_box): Don't update size until allocation succeeds.
9261 Don't assume message length fits in int.
9262 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
9263
0065d054
PE
9264 * emacs.c (main): Do not reallocate argv, since there is a null at
9265 the end that can be overwritten, and this way there's no need to
9266 worry about size-calculation overflow.
9267 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
9268
9269 * eval.c (init_eval_once, grow_specpdl): Don't update size until
9270 alloc succeeds.
9271 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
9272
9273 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
9274 (x_set_scroll_bar_width, x_figure_window_size):
9275 Check for integer overflow.
9276 (x_set_alpha): Do not assume XINT fits in int.
9277
9278 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
9279 This is for the members text_lines, text_cols, total_lines, total_cols,
9280 where the system imposes an 'int' limit.
9281
9282 * fringe.c (Fdefine_fringe_bitmap):
9283 Don't update size until alloc works.
9284
9285 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
9286 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
9287
9288 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
9289 Check for size-calculation overflow.
9290 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
9291 do, as we prefer signed integers.
9292 (id_to_widget.max_size, id_to_widget.used)
9293 (xg_store_widget_in_map, xg_remove_widget_from_map)
9294 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
9295 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
9296 Use and return ptrdiff_t, not int.
9297 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
9298 * gtkutil.h: Change prototypes to match the above.
9299
9300 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
9301 are duplicate now that they've been promoted to lisp.h.
9302 (x_allocate_bitmap_record, x_alloc_image_color)
9303 (make_image_cache, cache_image, xpm_load):
9304 Don't update size until alloc is done.
9305 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
9306 (x_detect_edges):
3256efce 9307 Check for size calculation overflow.
726e0ab1
PE
9308 (ct_colors_allocated_max): New constant.
9309 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
9310 overflow.
3256efce 9311
726e0ab1
PE
9312 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
9313 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
9314 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
9315 Use ptrdiff_t, not int, to count maps.
9316 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
9317 calculations. Don't update size until allocation succeeds.
9318 Redo calculations to avoid overflow.
726e0ab1
PE
9319 * keyboard.h: Change prototypes to match the above.
9320
9321 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
9322 to count maps.
9323 (current_minor_maps): Check for size calculation overflow.
9324 * keymap.h: Change prototypes to match the above.
9325
9326 * lread.c (read1, init_obarray): Don't update size until alloc done.
9327
9328 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
9329 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9330
726e0ab1
PE
9331 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
9332 Now ptrdiff_t, not int.
9333 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9334 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
9335
9336 * process.c (Fnetwork_interface_list): Check for overflow
9337 in size calculation.
9338
9339 * region-cache.c (move_cache_gap): Check for size calculation overflow.
9340
9341 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
9342 overflow. Don't bother calling xmalloc when xrealloc will do.
9343
9344 * search.c (Freplace_match): Check for size calculation overflow.
9345 (Fset_match_data): Don't assume list lengths fit in 'int'.
9346
9347 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
9348 for command line length. Do not attempt to address one before the
9349 beginning of an array, as that's not portable.
9350
9351 * term.c (max_frame_lines): Remove; unused.
9352 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
9353 not int.
9354 (encode_terminal_code, calculate_costs): Check for size
9355 calculation overflow.
9356 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
9357 table lengths and related sizes. Don't update size until alloc
9358 done. Redo calculations to avoid overflow.
9359 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
9360
9361 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
9362 subtracting pointers.
9363 (gobble_line): Check for overflow more carefully. Don't update size
9364 until alloc done.
9365
9366 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
9367 Don't update size until alloc done.
9368 Redo size calculations to avoid overflow.
9369 Check for size calculation overflow.
0065d054 9370 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
9371
9372 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
9373 Use ptrdiff_t, not int, for sizes.
9374 (store_mode_line_noprop_char): Don't update size until alloc done.
9375
0065d054
PE
9376 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
9377 Use ptrdiff_t, not int, for sizes.
9378 (Finternal_make_lisp_face, cache_face):
9379 Check for size calculation overflow.
9380 (cache_face): Treat size calculation overflows as if they were
9381 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
9382
9383 * xfns.c (x_encode_text, x_set_name_internal)
9384 (Fx_change_window_property): Use ptrdiff_t, not int, to count
9385 sizes, since they can exceed INT_MAX in size. Check for size
9386 calculation overflow.
9387
0065d054
PE
9388 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
9389 (xg_select): Check for size calculation overflow.
726e0ab1
PE
9390 Don't update size until alloc done.
9391
0065d054 9392 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 9393 as sprintf is limited to int lengths.
1d526e2f 9394
252c5ee1
PE
9395 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
9396 (X_LONG_MIN): New macros.
864d7ce7
PE
9397 Use them to make the following changes clearer.
9398 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
9399 This change doesn't affect the value now, but it may help remind
9400 future maintainers not to raise the value too much later.
9401 (SELECTION_QUANTUM): Remove, replacing with ...
9402 (selection_quantum): ... new function, which avoids overflow.
9403 All uses changed.
9404 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
9405 assumption that selection length fits in 'int'.
9406 (x_reply_selection_request, x_handle_selection_request)
9407 (x_get_window_property, receive_incremental_selection)
9408 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
9409 (lisp_data_to_selection_data, clean_local_selection_data):
9410 Use ptrdiff_t, not int, to record length of selection.
9411 (x_reply_selection_request, x_get_window_property)
9412 (receive_incremental_selection, x_property_data_to_lisp):
9413 Redo calculations to avoid overflow.
9414 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 9415 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
9416 something.
9417 (x_get_window_property, receive_incremental_selection)
9418 (lisp_data_to_selection_data, x_property_data_to_lisp):
9419 Check for size-calculation overflow.
9420 (x_get_window_property, receive_incremental_selection)
9421 (lisp_data_to_selection_data, Fx_register_dnd_atom):
9422 Don't store size until memory allocation succeeds.
9423 (x_get_window_property): Plug memory leak on memory exhaustion.
9424 Don't double-block input; malloc is safe here. Don't assume 2**34
9425 - 4 fits in unsigned long. Add an xassert to check
9426 XGetWindowProperty overflow. Be more careful about overflow
9427 calculations, and distinguish size from memory overflow better.
9428 (receive_incremental_selection): When tracing, don't assume
9429 unsigned int is less than INT_MAX.
9430 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
9431 harmful) conversions of unsigned short to int.
9432 (lisp_data_to_selection_data): Don't assume that integers
9433 in the range -65535 through -1 fit in an X unsigned short.
9434 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
9435 result parameters unless successful. Rely on cons_to_unsigned
9436 to report problems with elements; the old code wasn't right anyway.
9437 (x_check_property_data): Check for int overflow; we cannot use
9438 a wider type due to X limits.
9439 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
9440
726e0ab1 9441 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 9442
0065d054
PE
9443 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
9444 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
9445 (x_color_cells): Don't store size until memory allocation succeeds.
9446 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 9447 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
9448 (x_term_init): Don't assume length fits in int (sprintf is limited
9449 to int size).
bc18e09d 9450
ebfa62c0
PE
9451 Use ptrdiff_t for composition IDs.
9452 * character.c (lisp_string_width):
9453 * composite.c (composition_table_size, n_compositions)
9454 (get_composition_id, composition_gstring_from_id):
9455 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
9456 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
9457 * window.c (Frecenter):
9458 Use ptrdiff_t, not int, for composition IDs.
9459 * composite.c (get_composition_id): Check for integer overflow.
9460 * composite.h: Adjust prototypes to match the above changes.
9461
d3411f89
PE
9462 Use ptrdiff_t for hash table indexes.
9463 * category.c (hash_get_category_set):
9464 * ccl.c (ccl_driver):
9465 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
9466 * coding.c (coding_system_charset_list, detect_coding_system):
9467 * coding.h (struct coding_system.id):
9468 * composite.c (get_composition_id, gstring_lookup_cache):
9469 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
9470 * image.c (xpm_get_color_table_h):
9471 * lisp.h (hash_lookup, hash_put):
9472 * minibuf.c (Ftest_completion):
9473 Use ptrdiff_t for hash table indexes, not int (which is too
9474 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
9475 32-bit --with-wide-int hosts).
9476
e097a6fa
PE
9477 * charset.c (Fdefine_charset_internal): Check for integer overflow.
9478 Add a FIXME comment about memory leaks.
9479 (syms_of_charset): Don't assume xmalloc returns.
9480
5637687f
PE
9481 Don't assume that stated character widths fit in int.
9482 * character.c (Fchar_width, c_string_width, lisp_string_width):
9483 * character.h (CHAR_WIDTH):
9484 * indent.c (MULTIBYTE_BYTES_WIDTH):
9485 Use sanitize_char_width to avoid undefined and/or bad behavior
9486 with outlandish widths.
a66cfb1c 9487 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9488 now that we have two such functions. All uses changed.
9489 (sanitize_char_width): New inline function.
9490
a2271ba2
PE
9491 Don't assume that tab-width fits in int.
9492 * character.h (sanitize_width): New inline function.
9493 (SANE_TAB_WIDTH): New macro.
9494 (ASCII_CHAR_WIDTH): Use it.
9495 * indent.c (sane_tab_width): Remove. All uses replaced by
9496 SANE_TAB_WIDTH (current_buffer).
9497 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9498
18c52557
PE
9499 * fileio.c: Integer overflow issues with file modes.
9500 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9501
caeeedc1
PE
9502 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9503 Remove unreachable code.
9504 (read_hex, load_charset_map_from_file): Check for integer overflow.
9505
6df6ae42 9506 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9507 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9508 (x_send_scroll_bar_event): Likewise. Check that the size does not
9509 exceed limits imposed by XClientMessageEvent, as well as the usual
9510 ptrdiff_t and size_t limits.
9511
b13995db
PE
9512 * keyboard.c: Overflow, signedness and related fixes.
9513 (make_lispy_movement): Use same integer type in forward decl
9514 that is used in the definition.
9515 (read_key_sequence, keyremap_step):
9516 Change bufsize argument back to int, undoing my 2011-03-30 change.
9517 We prefer signed types, and int is wide enough here.
9518 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9519 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9520 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9521 length, not size_t. Use ptrdiff_t for index, not int.
9522 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9523 possibility of integer overflow.
9524
13464394
PE
9525 Overflow, signedness and related fixes for images.
9526
9527 * dispextern.h (struct it.stack[0].u.image.image_id)
9528 (struct_it.image_id, struct image.id, struct image_cache.size)
9529 (struct image_cache.used, struct image_cache.ref_count):
9530 * gtkutil.c (update_frame_tool_bar):
9531 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9532 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9533 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9534 * nsmenu.m (update_frame_tool_bar):
9535 * xdisp.c (calc_pixel_width_or_height):
9536 * xfns.c (image_cache_refcount):
9537 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9538 on typical 64-bit hosts.
9539
9540 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9541 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9542 Omit unnecessary casts to int.
9543 (parse_image_spec): Check that integers fall into 'int' range
9544 when the callers expect that.
9545 (image_ascent): Redo ascent calculation to avoid int overflow.
9546 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9547 (lookup_image): Remove unnecessary tests.
9548 (xbm_image_p): Locals are now of int, not EMACS_INT,
9549 since parse_image_check makes sure they fit into int.
9550 (png_load, gif_load, svg_load_image):
9551 Prefer int to unsigned where either will do.
9552 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9553 old tiff_error_handler and tiff_warning_handler.
9554 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9555 stack buffer overflows. It uses only the features of vsnprintf
9556 that are common to both POSIX and native Microsoft.
9557 (tiff_error_handler, tiff_warning_handler): Use it.
9558 (tiff_load, gif_load, imagemagick_load_image):
9559 Don't assume :index value fits in 'int'.
9560 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9561 (imagemagick_load_image): Check that crop parameters fit into
9562 the integer types that MagickCropImage accepts. Don't assume
9563 Vimagemagick_render_type has a nonnegative value. Don't assume
9564 size_t fits in 'long'.
9565 (gs_load): Use printmax_t to print the widest integers possible.
9566 Check for integer overflow when computing image height and width.
9567
c11821d4
EZ
95682011-08-26 Eli Zaretskii <eliz@gnu.org>
9569
9570 * xdisp.c (redisplay_window): Don't force window start if point
9571 will be invisible in the resulting window. (Bug#9324)
9572
0c95fcf7
EZ
95732011-08-25 Eli Zaretskii <eliz@gnu.org>
9574
9575 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9576 the display spec is of the form `(space ...)'.
9577 (handle_display_spec): Return the value returned by
9578 handle_single_display_spec, not just 1 or zero.
9579 (handle_single_display_spec): If the display spec is of the form
9580 `(space ...)', and specifies display in the text area, return 2
9581 rather than 1.
fee65a97 9582 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9583 accurately, and prefer exact match for point under bidi.
9584 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9585
9586 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9587 into disp_prop; all users changed.
9588
9589 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9590 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9591 for the text covered by the display property.
9592
e4ed06f1
CY
95932011-08-25 Chong Yidong <cyd@stupidchicken.com>
9594
9595 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9596 Change return value to nil.
9597 (Frecord_buffer): Delete unused function.
9598
f67cdd7f
EZ
95992011-08-24 Eli Zaretskii <eliz@gnu.org>
9600
5980d4c6
EZ
9601 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9602 buffers, return left-to-right.
8610fe8b
EZ
9603 (set_cursor_from_row): Consider candidate row a win if its glyph
9604 represents a newline and point is on that newline. Fixes cursor
9605 positioning on the newline at EOL of R2L text within L2R
9606 paragraph, and vice versa.
9607 (try_cursor_movement): Check continued rows, in addition to
9608 continuation rows. Fixes unwarranted scroll when point enters a
9609 continued line of R2L text within an L2R paragraph, or vice versa.
9610 (cursor_row_p): Consider the case of point being equal to
9611 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9612 from the end of a short line to the beginning of a continued line
9613 of R2L text within L2R paragraph.
9614 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9615 composed characters.
5980d4c6 9616
f67cdd7f
EZ
9617 * bidi.c (bidi_check_type): Use xassert.
9618 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9619 members.
9620
bca633fb
EZ
96212011-08-23 Eli Zaretskii <eliz@gnu.org>
9622
9623 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9624 a character.
9625
4a5885a7
CY
96262011-08-23 Chong Yidong <cyd@stupidchicken.com>
9627
9628 * nsfont.m (ns_otf_to_script): Fix typo.
9629
0902a04e
KH
96302011-08-22 Kenichi Handa <handa@m17n.org>
9631
9632 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9633 extra slot even if the purpose is char-code-property-table.
9634
1a2e6670
EZ
96352011-08-23 Eli Zaretskii <eliz@gnu.org>
9636
8ddde651
EZ
9637 * xdisp.c (redisplay_window): When computing centering_position,
9638 account for the height of the header line. (Bug#8874)
9639
425cc014
EZ
9640 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9641 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9642 candidate is selected by the mouse, and that candidate has a
9643 composed character under the mouse.
9644
1a2e6670
EZ
9645 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9646 coordinates reported by pos-visible-in-window-p for a composed
9647 character in column zero.
9648
8b76d6f8
SM
96492011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9650
9651 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9652
dac347dd
EZ
96532011-08-22 Eli Zaretskii <eliz@gnu.org>
9654
9655 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9656 consider it a hit if to_charpos is anywhere in the range of the
9657 composed buffer positions.
9658
e013fb34
CY
96592011-08-22 Chong Yidong <cyd@stupidchicken.com>
9660
9661 * image.c (gif_load): Don't assume that each subimage has the same
9662 dimensions as the base image. Handle disposal method that is
9663 "undefined" by the gif spec (Bug#9335).
9664
bd1ba3e8
CY
96652011-08-20 Chong Yidong <cyd@stupidchicken.com>
9666
9667 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9668 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9669
54a1215b
EZ
96702011-08-19 Eli Zaretskii <eliz@gnu.org>
9671
823564e5
EZ
9672 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9673 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9674 from an Org mode buffer to a Speedbar frame.
9675
54a1215b
EZ
9676 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9677 a composition, take its buffer position from IT->cmp_it.charpos.
9678 Fixes cursor positioning at the beginning of a line that begins
9679 with a composed character.
9680
9778ebcc
EZ
96812011-08-18 Eli Zaretskii <eliz@gnu.org>
9682
0be6ee06
EZ
9683 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9684 character bidirectional type, use STRONG_L instead. Fixes crashes
9685 in a buffer produced by `describe-categories'.
9686
9778ebcc
EZ
9687 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9688 members before the level stack, so they would be saved and
9689 restored when copying iterator state. Fixes incorrect reordering
9690 around TABs covered by display properties.
9691
156bffbe
AS
96922011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9693
6b02f655 9694 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9695
72ad093b
CY
96962011-08-17 Chong Yidong <cyd@stupidchicken.com>
9697
9698 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9699 (internal_condition_case_2, internal_condition_case_n):
9700 Remove unnecessary aborts (Bug#9081).
72ad093b 9701
35774242
EZ
97022011-08-17 Eli Zaretskii <eliz@gnu.org>
9703
9704 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9705 has no `load' handler, try opening the file locally. (Bug#9311)
9706
db76dd85
KB
97072011-08-16 Ken Brown <kbrown@cornell.edu>
9708
9709 * gmalloc.c: Expand comment.
9710
b215eee5
EZ
97112011-08-16 Eli Zaretskii <eliz@gnu.org>
9712
9713 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9714 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9715
a4579d33
KB
97162011-08-16 Ken Brown <kbrown@cornell.edu>
9717
9718 Fix memory allocation problems in Cygwin build (Bug#9273).
9719
9720 * unexcw.c ( __malloc_initialized): Declare external variable.
9721 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9722
8b76d6f8
SM
9723 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9724 New variables.
a4579d33
KB
9725 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9726 dumped emacs.
9727 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9728 in the static heap.
9729 [CYGWIN] (special_realloc): New function.
9730 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9731 requests to realloc storage in the static heap.
9732
3ebec551
PE
97332011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9734
9735 * bidi.c (bidi_initialize): Remove unused local.
9736
9fd8be00
EZ
97372011-08-15 Eli Zaretskii <eliz@gnu.org>
9738
6b02f655
SM
9739 * bidimirror.h:
9740 * biditype.h: Remove file.
9741 * makefile.w32-in ($(BLD)/bidi.$(O)):
9742 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9743
9744 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9745
9746 * chartab.c: Improve commentary for the uniprop_table API.
9747
32413314
EZ
9748 * bidi.c (bidi_paragraph_init): Support zero value of
9749 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9750 (bidi_initialize): Use uniprop_table instead of including
9751 biditype.h and bidimirror.h.
32413314 9752
9fd8be00
EZ
9753 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9754 coordinates of the iterator when restoring from ppos_it.
9755 (Bug#9296)
9756
5cf2b69b
KH
97572011-08-14 Kenichi Handa <handa@m17n.org>
9758
9759 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9760 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9761
daf17d00
EZ
97622011-08-14 Eli Zaretskii <eliz@gnu.org>
9763
9764 * xdisp.c (move_it_in_display_line_to): Don't invoke
9765 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9766 ppos_it. Fixes vertical cursor motion when line beginning is
9767 covered by an image. (Bug#9296)
9768
08e3161a
JD
97692011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9770
9771 * nsterm.h (ns_run_ascript): Declare.
9772 (NSAPP_DATA2_RUNASSCRIPT): Define.
9773
9774 * nsfns.m (as_script, as_result, as_status): New static variables.
9775 (ns_run_ascript): New function.
5e617bc2 9776 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9777 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9778 the event loop. Get status from as_status (Bug#7276).
9779
9780 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9781 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9782 the event loop (Bug#7276).
9783
a3720aa2
AS
97842011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9785
9786 * gnutls.c (QCgnutls_bootprop_priority)
9787 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9788 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9789 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9790 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9791 (QCgnutls_bootprop_verify_hostname_error)
9792 (QCgnutls_bootprop_callbacks_verify): Rename from
9793 Qgnutls_bootprop_..., all uses changed.
9794
9795 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9796 uses changed.
9797
0a0d27fb
PE
97982011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9799
19d5c50c
PE
9800 * xfaces.c (Qframe_set_background_mode): Now static.
9801 * dispextern.h (Qframe_set_background_mode): Remove decl.
9802
0a0d27fb
PE
9803 * process.c (Fnetwork_interface_info): Declare local only if needed.
9804
377538cb
JD
98052011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9806
9807 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9808 (Fnetwork_interface_list): Allocate in increments of bytes instead
9809 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9810 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9811 sockaddr.
9812 (struct ifflag_def): notrailers is smart on OSX.
9813 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9814 Get hardware address with getifaddrs if available.
9815
08fff70c
EZ
98162011-08-12 Eli Zaretskii <eliz@gnu.org>
9817
9818 * xdisp.c (iterate_out_of_display_property): xassert that
9819 IT->position is set to within IT->object's boundaries. Break from
9820 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9821 when IT->position is set up wrongly due to some bug.
9822 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9823 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9824 entry. Force push_it to save on the stack the current
9825 buffer/string position, to be restored by pop_it. Fix flags in
9826 the iterator structure wrt the object coming from a display
9827 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9828 properties. (Bug#9284)
9829
7be1c708 98302011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9831
7be1c708
CY
9832 * fontset.c (fontset_get_font_group): Add proper type checks.
9833 (Bug#9172)
aac0c6e3 9834
7be1c708 98352011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9836
7be1c708
CY
9837 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9838 and LC_VERSION_MIN_MACOSX.
9839 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9840 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9841
97bb72a6
EZ
98422011-08-08 Eli Zaretskii <eliz@gnu.org>
9843
9844 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9845 no-display-properties-and-no-overlays under bidi display.
9846 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9847 properties and overlays.
97bb72a6 9848
d5617611
CY
98492011-08-08 Chong Yidong <cyd@stupidchicken.com>
9850
37e11a63
CY
9851 * editfns.c (Fset_time_zone_rule): Document relationship with the
9852 setenv function.
9853
d5617611
CY
9854 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9855 the font entity extracted from the cache (Bug#8109).
9856
58872834
CY
98572011-08-07 Chong Yidong <cyd@stupidchicken.com>
9858
9859 * composite.c (autocmp_chars): Don't reset point. That is done by
9860 restore_point_unwind (Bug#5984).
9861
75bfc667
JL
98622011-08-07 Juri Linkov <juri@jurta.org>
9863
9864 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9865 to show the arg `TIME' instead of `TIMEVAL'.
9866
d1410150
EZ
98672011-08-06 Eli Zaretskii <eliz@gnu.org>
9868
9869 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9870 display property strides EOL and includes a newline, as in
9871 longlines-mode. (Bug#9254)
75b771e4
EZ
9872 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9873 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9874
9875 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9876 is non-zero, even if the data buffer is NULL. Fixes a crash in
9877 vertical-motion with longlines-mode. (Bug#9254)
9878
35928349
EZ
98792011-08-05 Eli Zaretskii <eliz@gnu.org>
9880
ec7cc85b
EZ
9881 * bidi.c <bidi_cache_total_alloc>: Now static.
9882 (bidi_initialize): Initialize bidi_cache_total_alloc.
9883
8b76d6f8 9884 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9885 cache. (Bug#9221)
9886
9887 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9888 amount allocated this far in `bidi_cache_total_alloc'.
9889 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9890 non-zero, only free the data buffer without restoring the cache
9891 contents. All callers changed.
9892
9893 * dispextern.h (bidi_unshelve_cache): Update prototype.
9894
9895 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9896 (move_it_in_display_line, move_it_to)
9897 (move_it_vertically_backward, move_it_by_lines): Replace the call
9898 to xfree to an equivalent call to bidi_unshelve_cache.
9899 (move_it_in_display_line_to): Fix logic of returning
412b6358 9900 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9901
e2e2423b
EZ
99022011-08-05 Eli Zaretskii <eliz@gnu.org>
9903
9904 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9905 came from a string character with a `cursor' property. (Bug#9229)
9906
ae9e757a
JD
99072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9908
9909 * Makefile.in (LIB_PTHREAD): New variable.
9910 (LIBES): Add LIB_PTHREAD (Bug#9216).
9911
9912 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9913 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9914
213bd7f2
AS
99152011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9916
6b02f655 9917 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9918
99aaf75f
JD
99192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9920
9921 * xterm.c (x_find_topmost_parent): New function.
9922 (x_set_frame_alpha): Find topmost parent window with
9923 x_find_topmost_parent and set the property there also (bug#9181).
9924 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9925
c74e9d86
PE
99262011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9927
9928 * callproc.c (Fcall_process): Avoid vfork clobbering
9929 the local vars buffer, coding_systems, current_dir.
9930
640c8776
SM
99312011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9932
9933 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9934
f26d0e4c
PE
99352011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9936
8a10d76c
PE
9937 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9938 so that it is not optimized away.
9939
f26d0e4c
PE
9940 * xdisp.c (compute_display_string_pos): Remove unused local.
9941
55439c61
EZ
99422011-08-02 Eli Zaretskii <eliz@gnu.org>
9943
9944 Fix slow cursor motion and scrolling in large buffers with
9945 selective display, like Org Mode buffers. (Bug#9218)
9946
9947 * dispextern.h (struct bidi_it): New member disp_prop_p.
9948
9949 * xdisp.c: Remove one-slot cache of display string positions.
9950 (compute_display_string_pos): Accept an additional argument
5e617bc2 9951 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9952 for a display string or property. If found, set DISP_PROP_P
9953 non-zero.
9954
9955 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9956 DISP_PROP_P, and pass it to compute_display_string_pos.
9957 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9958 non-zero. All callers of bidi_fetch_char changed.
9959
fb33fa43
SM
99602011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9961
9962 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9963
b099e063
DM
99642010-12-03 Don March <don@ohspite.net>
9965
9966 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9967 last character M-[char] is translated to ESC [char] (bug#7541).
9968
5cc7f7af
KH
99692011-08-02 Kenichi Handa <handa@m17n.org>
9970
d0fffa3f 9971 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9972
9973 * chartab.c (uniprop_table): Make it non-static.
9974
525d5e6e
EZ
99752011-08-01 Eli Zaretskii <eliz@gnu.org>
9976
9977 * xdisp.c (forward_to_next_line_start): Accept additional argument
9978 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9979 on the newline.
9980 (reseat_at_next_visible_line_start): Use the bidi iterator state
9981 returned by forward_to_next_line_start to restore the state of
9982 it->bidi_it after backing up to previous newline. (Bug#9212)
9983
31011111
AS
99842011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9985
9986 * regex.c (re_comp): Protoize.
9987 (re_exec): Fix return type.
9988 (regexec): Fix type of `ret'. (Bug#9203)
9989
476371c4
PE
99902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9991
e5d76069
PE
9992 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9993 This is needed if max-image-size is a floating-point number.
9994
9a79b20c
AS
99952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9996
9997 * print.c (print_object): Print empty symbol as ##.
9998
9999 * lread.c (read1): Read ## as empty symbol.
10000
d8c2fa78
AA
100012011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10002
10003 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10004 setting frame foreground color (Bug#9175).
10005 (x_set_background_color): Likewise.
10006
ffe57a7a
AA
10007 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10008 contents (Bug#9176).
10009 (EmacsTooltip -init): Remove bezels and add shadows to
10010 tooltip windows.
10011
bf3492a5
AA
10012 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10013 or scroll bar (Bug#8470).
10014
d55e9c53
AA
10015 * nsfont.m (nsfont_open): Remove assignment to voffset and
10016 unnecessary vars hshink, expand, hd, full_height, min_height.
10017 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10018
10019 * nsterm.h (nsfont_info): Remove voffset field.
10020
d8c2fa78 100212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10022
10023 Implement strike-through and overline on NextStep (Bug#8863).
10024
10025 * nsfont.m (nsfont_open): Use underline position provided by font,
10026 instead of hard-coded value of 2.
10027 (nsfont_draw): Call ns_draw_text_decoration instead.
10028
10029 * nsterm.h: Add declaration for ns_draw_text_decoration.
10030
10031 * nsterm.m (ns_draw_text_decoration): New function for drawing
10032 underline, overline, and strike-through.
10033 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10034 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10035 accommodate underlining, etc.
4843aac3 10036
4cc60b9b
EZ
100372011-07-28 Eli Zaretskii <eliz@gnu.org>
10038
bc7ece87
EZ
10039 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10040 default.
4cc60b9b 10041
476371c4
PE
100422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10043
66606eea
PE
10044 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10045 Without this fix, if a signal arrives just after memory fills up,
10046 'malloc' might be invoked reentrantly.
10047
476371c4
PE
10048 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10049 In other words, assume that every image size is allowed, on non-X
10050 hosts. This assumption is probably wrong, but it lets Emacs compile.
10051
f3fcc40d
AS
100522011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10053
10054 * regex.c (re_iswctype): Convert return values to boolean.
10055
350c992f
EZ
100562011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10057
10058 * xdisp.c (compute_display_string_pos): Don't use cached display
10059 string position if the buffer had its restriction changed.
10060 (Bug#9184)
10061
5266b4bb
PE
100622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10063
10064 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10065
2573a837 100662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10067
41f55ccd 10068 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10069
39e378da
PE
10070 * bidi.c: Integer size and overflow fixes.
10071 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10072 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10073 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10074 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10075 (bidi_find_other_level_edge):
10076 Use ptrdiff_t instead of EMACS_INT where either will do.
10077 This works better on 32-bit hosts configured --with-wide-int.
10078 (bidi_cache_ensure_space): Check for size-calculation overflow.
10079 Use % rather than repeated addition, for better worst-case speed.
10080 Don't set bidi_cache_size until after xrealloc returns, because it
10081 might not return.
10082 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10083 (bidi_cache_ensure_space): Also check that the bidi cache size
10084 does not exceed that of the largest Lisp string or buffer. See Eli
10085 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10086
5e927815
PE
10087 * alloc.c (__malloc_size_t): Remove.
10088 All uses replaced by size_t. See Andreas Schwab's note
10089 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10090
ca4aa935
PE
10091 * image.c: Improve checking for integer overflow.
10092 (check_image_size): Assume that f is nonnull, since
10093 it is always nonnull in practice. This is one less thing to
10094 worry about when checking for integer overflow later.
10095 (x_check_image_size): New function, which checks for integer
10096 overflow issues inside X.
10097 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10098 This removes the need for a memory_full check.
10099 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10100 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10101 (xbm_read_bitmap_data): Change locals back to 'int', since
10102 their values must fit in 'int'.
10103 (xpm_load_image, png_load, tiff_load):
10104 Invoke x_create_x_image_and_pixmap earlier,
10105 to avoid much needless work if the image is too large.
10106 (tiff_load): Treat overly large images as if
10107 x_create_x_image_and_pixmap failed, not as malloc failures.
10108 (gs_load): Use x_check_image_size.
10109
5f8f9cc2
PE
10110 * gtkutil.c: Omit integer casts.
10111 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10112 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10113
5adf60bc
PE
10114 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
10115
c8907a93
PE
10116 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
10117 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
10118 would wrongly return t on a 64-bit host.
10119
e3c25c68
PE
10120 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10121 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10122 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10123 and therefore cause GCC to emit a bogus diagnostic in some cases.
10124
3f791afe
PE
10125 * image.c: Integer signedness and overflow and related fixes.
10126 This is not an exhaustive set of fixes, but it's time to
10127 record what I've got.
10128 (lookup_pixel_color, check_image_size): Remove redundant decls.
10129 (check_image_size): Don't assume that arbitrary EMACS_INT values
10130 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10131 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10132 (tiff_load, imagemagick_load_image):
10133 Check for overflow in size calculations.
10134 (x_create_x_image_and_pixmap): Remove unnecessary test for
10135 xmalloc returning NULL; that can't happen.
10136 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10137 (xpm_color_bucket): Use better integer hashing function.
10138 (xpm_cache_color): Don't possibly over-allocate memory.
10139 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10140 (gif_memory_source):
10141 Use ptrdiff_t, not int or size_t, to record sizes.
10142 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10143 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10144 either works, as we prefer signed integers.
10145 (tiff_read_from_memory, tiff_write_from_memory):
10146 Return tsize_t, not size_t, since that's what the TIFF API wants.
10147 (tiff_read_from_memory): Don't fail simply because the read would
10148 go past EOF; instead, return a short read.
10149 (tiff_load): Omit no-longer-needed casts.
10150 (Fimagemagick_types): Don't assume size fits into 'int'.
10151
3cc5a532
PE
10152 Improve hashing quality when configured --with-wide-int.
10153 * fns.c (hash_string): New function, taken from sxhash_string.
10154 Do not discard information about ASCII character case; this
10155 discarding is no longer needed.
10156 (sxhash-string): Use it. Change sig to match it. Caller changed.
10157 * lisp.h: Declare it.
10158 * lread.c (hash_string): Remove, since we now use fns.c's version.
10159 The fns.c version returns a wider integer if --with-wide-int is
10160 specified, so this should help the quality of the hashing a bit.
10161
b312a492
PE
10162 * emacs.c: Integer overflow minor fix.
10163 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10164 Define only if GNU_LINUX.
10165 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10166
dfd153ae
PE
10167 * dispnew.c: Integer signedness and overflow fixes.
10168 Remove unnecessary forward decls, that were a maintenance hassle.
10169 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10170 All uses changed.
10171 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10172 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10173 (prepare_desired_row, line_draw_cost):
10174 Use int, not unsigned, where either works.
10175 (save_current_matrix, restore_current_matrix):
10176 Use ptrdiff_t, not size_t, where either works.
10177 (init_display): Check for overflow more accurately, and without
10178 relying on undefined behavior.
10179
a81d11a3
PE
10180 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10181 Remove, replacing with the new symbols in lisp.h. All uses changed.
10182 * fileio.c (make_temp_name):
10183 * filelock.c (lock_file_1, lock_file):
10184 * xdisp.c (message_dolog):
10185 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10186 Use pMd etc. instead.
10187 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10188 replacing the pWIDE etc. symbols removed from editfns.c.
10189
3300e6fd
PE
10190 * keyboard.h (num_input_events): Now uintmax_t.
10191 This is (very slightly) less likely to mess up due to wraparound.
10192 All uses changed.
10193
fd05c7e9
PE
10194 * buffer.c: Integer signedness fixes.
10195 (alloc_buffer_text, enlarge_buffer_text):
10196 Use ptrdiff_t rather than size_t when either will do, as we prefer
10197 signed integers.
10198
903fe15d
PE
10199 * alloc.c: Integer signedness and overflow fixes.
10200 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10201 (__malloc_size_t): Default to size_t, not to int.
10202 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10203 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10204 Prefer ptrdiff_t to size_t when either would do, as we prefer
10205 signed integers.
10206 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
10207 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
10208 Now const. Initialize with values that are in range even if char
10209 is signed.
10210 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
10211 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
10212 These functions do the right thing with sizes > 2**32.
10213 (check_depth): Now ptrdiff_t, not int.
10214 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
10215 Adjust to new way of storing sizes. Check for size overflow bugs
10216 in rest of code.
10217 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
10218 slightly wrong anyway, as it missed one instance of
10219 XMALLOC_OVERRUN_CHECK_OVERHEAD.
10220 (refill_memory_reserve): Omit needless cast to size_t.
10221 (mark_object_loop_halt): Mark as externally visible.
10222
ac82cc6a
PE
10223 * xselect.c: Integer signedness and overflow fixes.
10224 (Fx_register_dnd_atom, x_handle_dnd_message):
10225 Use ptrdiff_t, not size_t, since we prefer signed.
10226 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
10227 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
10228 x_dnd_atoms_size and x_dnd_atoms_length.
10229
c2d1e36d
PE
10230 * doprnt.c: Prefer signed to unsigned when either works.
10231 * eval.c (verror):
10232 * doprnt.c (doprnt):
10233 * lisp.h (doprnt):
10234 * xdisp.c (vmessage):
10235 Use ptrdiff_t, not size_t, when using or implementing doprnt,
10236 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10237 prefer signed arithmetic to avoid comparison confusion.
10238 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
10239 but is a bit tricky.
10240
0e926e56
PE
10241 Assume freestanding C89 headers, string.h, stdlib.h.
10242 * data.c, doprnt.c, floatfns.c, print.c:
10243 Include float.h unconditionally.
10244 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
10245 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
10246 * regex.c: Likewise for stddef.h, string.h.
10247 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10248 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
10249 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
10250 (STDC_HEADERS): Remove obsolete defines.
10251 * sysdep.c: Include limits.h unconditionally.
10252
9cfdb3ec
PE
10253 Assume support for memcmp, memcpy, memmove, memset.
10254 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
10255 * regex.c (memcmp, memcpy):
10256 Remove; we assume C89 now.
10257
10258 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
10259 (__malloc_safe_bcopy): Remove; no longer needed.
10260
cf950e6b 10261 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
10262 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
10263 well either way, and we prefer signed to unsigned.
10264
dbf38e02
LMI
102652011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
10266
10267 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
10268 closes the connection while we're reading (bug#9182).
10269
d6f0886c 102702011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 10271
d6f0886c
JD
10272 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
10273 are specified (Bug#9168).
24e0f6b1 10274
2eb1f9e6
PE
102752011-07-25 Paul Eggert <eggert@cs.ucla.edu>
10276
10277 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
10278 Found by GCC static checking and --with-wide-int on a 32-bit host.
10279
22381272 102802011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
10281
10282 * xdisp.c (compute_display_string_pos): Fix logic of caching
10283 previous display string position. Initialize cached_prev_pos to
10284 -1. Fixes slow-down at the beginning of a buffer.
10285
f25e39b4
EZ
102862011-07-24 Eli Zaretskii <eliz@gnu.org>
10287
10288 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10289 for attrs[LFACE_FONTSET_INDEX].
10290
04c4b52e
PE
102912011-07-23 Paul Eggert <eggert@cs.ucla.edu>
10292
10293 * xml.c (parse_region): Remove unused local
10294 that was recently introduced.
10295
c1734fbd
EZ
102962011-07-23 Eli Zaretskii <eliz@gnu.org>
10297
be18c5a5
EZ
10298 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
10299 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
10300
c1734fbd
EZ
10301 * xdisp.c (move_it_in_display_line_to): Record the best matching
10302 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
10303 exit if none of the characters scanned was an exact match.
10304 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
10305 when exact match is impossible due to invisible text, and the
10306 lines are truncated.
10307
a258d627
JD
103082011-07-23 Jan Djärv <jan.h.d@swipnet.se>
10309
10310 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
10311 for OSX >= 10.7.
10312
b6d5a689
EZ
103132011-07-22 Eli Zaretskii <eliz@gnu.org>
10314
0f74f785
EZ
10315 Fix a significant slow-down of cursor motion with C-n, C-p,
10316 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10317 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 10318 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
10319 (next_element_from_buffer): Call compute_stop_pos_backwards to
10320 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
10321 base_level_stop.
10322 (reseat): Don't look for prev_stop, as that could mean a very long
10323 run.
10324 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
10325 <cached_disp_overlay_modiff>: Cache for last found display string
10326 position.
551918c1 10327 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
10328 about the same buffer in the same area of character positions, and
10329 the buffer wasn't changed since the time the display string
10330 position was cached.
551918c1 10331
b2d0c91a
EZ
103322011-07-22 Eli Zaretskii <eliz@gnu.org>
10333
10334 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
10335 is an integer, which is important for empty lines. (Bug#9149)
10336
043604ee
CY
103372011-07-22 Chong Yidong <cyd@stupidchicken.com>
10338
10339 * frame.c (Fmodify_frame_parameters): In tty case, update the
10340 default face if necessary (Bug#4238).
10341
da4adb04
CY
103422011-07-21 Chong Yidong <cyd@stupidchicken.com>
10343
10344 * editfns.c (Fstring_to_char): No need to explain what a character
10345 is in the docstring (Bug#6576).
10346
9abd0532
LMI
103472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10348
10349 * xml.c (parse_region): Make sure we always return a tree.
10350
36881d16
HK
103512011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
10352
10353 * xml.c (parse_region): If a document contains only comments,
10354 return that, too.
10355
1e98674d
LMI
103562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10357
10358 * xml.c (make_dom): Return comments, too.
10359
590bd467
PE
103602011-07-19 Paul Eggert <eggert@cs.ucla.edu>
10361
10362 Port to OpenBSD.
10363 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
10364 and the surrounding thread.
10365 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
10366 rather than fgets, and retry after EINTR. Otherwise, 'emacs
10367 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
10368 timer goes off.
10369 * s/openbsd.h (BROKEN_SIGIO): Define.
10370 * unexelf.c (unexec) [__OpenBSD__]:
10371 Don't update the .mdebug section of the Alpha COFF symbol table.
10372
f41628b2
LMI
103732011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10374
10375 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
10376 (bug#8460).
10377
b59b67c5
PE
103782011-07-18 Paul Eggert <eggert@cs.ucla.edu>
10379
15e3a074
PE
10380 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
10381 This fixes some race conditions on the permissions of any newly
10382 created file.
10383
41bed37d
PE
10384 * alloc.c (valid_pointer_p): Use pipe, not open.
10385 This fixes some permissions issues when debugging.
10386
b59b67c5
PE
10387 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
10388 If fchown fails to set both uid and gid, try to set just gid,
10389 as that is sometimes allowed. Adjust the file's mode to eliminate
10390 setuid or setgid bits that are inappropriate if fchown fails.
10391
925a6be7
SM
103922011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10393
10394 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
10395 to compare Lisp_Objects.
10396 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
10397 global_gnutls_log_level, don't mistake it for a Lisp_Object.
10398 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
10399
52968808
AS
104002011-07-17 Andreas Schwab <schwab@linux-m68k.org>
10401
0a6a104b
AS
10402 * lread.c (read_integer): Unread even EOF character.
10403 (read1): Likewise. Properly record start position of symbol.
10404
52968808
AS
10405 * lread.c (read1): Read `#:' as empty uninterned symbol if no
10406 symbol character follows.
10407
9e381cdd
PE
104082011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10409
10410 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
10411 This works around a problem with the previous change to Fcopy_file.
10412 Recent glibc declares fchown with __attribute__((warn_unused_result)),
10413 and without this change, GCC might complain about discarding
10414 fchown's return value.
10415
b5641435
JB
104162011-07-16 Juanma Barranquero <lekktu@gmail.com>
10417
10418 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
10419
a8031457
PE
104202011-07-16 Paul Eggert <eggert@cs.ucla.edu>
10421
10422 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
10423
dd889327
LMI
104242011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
10425
750c33f7
LMI
10426 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
10427 it's used from the C level.
10428
dd889327
LMI
10429 * process.c: Use the same condition for POLL_FOR_INPUT in both
10430 keyboard.c and process.c (bug#1858).
10431
87e86684
LM
104322011-07-09 Lawrence Mitchell <wence@gmx.li>
10433
10434 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
10435 (Fgnutls_boot): Use it.
10436
64348f40
AS
104372011-07-15 Andreas Schwab <schwab@linux-m68k.org>
10438
10439 * doc.c (Fsubstitute_command_keys): Revert last change.
10440
1d698799
LMI
104412011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
10442
f863868c
LMI
10443 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
10444 quotes the next character, and doesn't affect other longer
10445 sequences (bug#8935).
10446
1d698799
LMI
10447 * lread.c (syms_of_lread): Clarify that is isn't only
10448 `eval-buffer' and `eval-defun' that's affected by
10449 `lexical-binding' (bug#8460).
10450
aa4b6df6
EZ
104512011-07-15 Eli Zaretskii <eliz@gnu.org>
10452
10453 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 10454 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 10455
5d856da6
PE
104562011-07-14 Paul Eggert <eggert@cs.ucla.edu>
10457
ad6042bb
PE
10458 Fix minor problems found by static checking.
10459 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
10460 (elsz): Now a signed constant, not a size_t var. We prefer signed
10461 types to unsigned, to avoid integer comparison confusion. Without
10462 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
10463 "cannot optimize loop, the loop counter may overflow", a symptom
10464 of the confusion.
f00bbb22 10465 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
10466 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
10467
6468f31c
LMI
104682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10469
49080b10
LMI
10470 * search.c (Fre_search_backward): Mention `case-fold-search' in
10471 all the re_search_* functions (bug#8138).
10472
6468f31c
LMI
10473 * keyboard.c (Fopen_dribble_file): Document when the file is
10474 closed (bug#8056).
10475
c965adc5
EZ
104762011-07-14 Eli Zaretskii <eliz@gnu.org>
10477
df9733bf
EZ
10478 * bidi.c (bidi_dump_cached_states): Fix format of displaying
10479 bidi_cache_idx.
10480
0bb23927
EZ
10481 Support bidi reordering of display and overlay strings.
10482 * xdisp.c (compute_display_string_pos)
10483 (compute_display_string_end): Accept additional argument STRING.
10484 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
10485 (reseat_to_string): Initialize bidi_it->string.s and
10486 bidi_it->string.schars.
10487 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10488 NULL (avoids a crash in bidi_paragraph_init).
10489 Initialize itb.string.lstring.
0bb23927
EZ
10490 (init_iterator): Call bidi_init_it only of a valid
10491 buffer position was specified. Initialize paragraph_embedding to
10492 L2R.
10493 (reseat_to_string): Initialize the bidi iterator.
10494 (display_string): If we need to ignore text properties of
10495 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10496 original value of -1 will not work with bidi.)
10497 (compute_display_string_pos): First arg is now struct
10498 `text_pos *'; all callers changed. Support display properties on
10499 Lisp strings.
10500 (compute_display_string_end): Support display properties on Lisp
10501 strings.
10502 (init_iterator, reseat_1, reseat_to_string): Initialize the
10503 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10504 when iterating on a string not from display properties).
640c8776
SM
10505 (compute_display_string_pos, compute_display_string_end):
10506 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10507 arrow keys.
10508 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10509 base_level_stop; instead, set base_level_stop to BEGV.
10510 Fixes crashes in vertical-motion.
0bb23927
EZ
10511 (next_element_from_buffer): Improve commentary for when
10512 the iterator is before prev_stop.
10513 (init_iterator): Initialize bidi_p from the default value of
10514 bidi-display-reordering, not from buffer-local value. Use the
10515 buffer-local value only if initializing for buffer iteration.
10516 (handle_invisible_prop): Support invisible properties on strings
10517 that are being bidi-reordered.
10518 (set_iterator_to_next): Support bidi reordering of C strings and
10519 Lisp strings.
10520 (next_element_from_string): Support bidi reordering of Lisp
10521 strings.
10522 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10523 (display_string): Support display of R2L glyph rows.
10524 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10525 (init_iterator): Don't initialize it->bidi_p for strings
10526 here.
10527 (reseat_to_string): Initialize it->bidi_p for strings here.
10528 (next_element_from_string, next_element_from_c_string)
10529 (next_element_from_buffer): Add xassert's for correspondence
10530 between IT's object being iterated and it->bidi_it.string
10531 structure.
10532 (face_before_or_after_it_pos): Support bidi iteration.
10533 (next_element_from_c_string): Handle the case of the first string
10534 character that is not the first one in the visual order.
10535 (get_visually_first_element): New function, refactored from common
10536 parts of next_element_from_buffer, next_element_from_string, and
10537 next_element_from_c_string.
10538 (tool_bar_lines_needed, redisplay_tool_bar)
10539 (display_menu_bar): Force left-to-right direction. Add a FIXME
10540 comment for making that be controlled by a user option.
10541 (push_it, pop_it): Save and restore the state of the
10542 bidi iterator. Save and restore the bidi_p flag.
10543 (pop_it): Iterate out of display property for string iteration as
10544 well.
10545 (iterate_out_of_display_property): Support iteration over strings.
10546 (handle_single_display_spec): Set up it->bidi_it for iteration
10547 over a display string, and call bidi_init_it.
10548 (handle_single_display_spec, next_overlay_string)
10549 (get_overlay_strings_1, push_display_prop): Set up the bidi
10550 iterator for displaying display or overlay strings.
10551 (forward_to_next_line_start): Don't use the shortcut if
10552 bidi-iterating.
10553 (back_to_previous_visible_line_start): If handle_display_prop
10554 pushed the iterator stack, restore the internal state of the bidi
10555 iterator by calling bidi_pop_it same number of times.
10556 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10557 and we are bidi-iterating, don't decrement the iterator position;
10558 instead, set the first_elt flag in the bidi iterator, to produce
10559 the same effect.
10560 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10561 (push_display_prop): xassert that we are iterating a buffer.
10562 (push_it, pop_it): Save and restore paragraph_embedding member.
10563 (handle_single_display_spec, next_overlay_string)
10564 (get_overlay_strings_1, reseat_1, reseat_to_string)
10565 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10566 correctly. Don't assume unibyte strings are not bidi-reordered.
10567 (compute_display_string_pos)
10568 (compute_display_string_end): Fix handling the case of C string.
10569 (push_it, pop_it): Save and restore from_disp_prop_p.
10570 (handle_single_display_spec, push_display_prop): Set the
10571 from_disp_prop_p flag.
10572 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10573 (pop_it): Call iterate_out_of_display_property only if we are
10574 popping after iteration over a string that came from a display
10575 property. Fix a typo in popping stretch info. Add an assertion
10576 for verifying that the iterator position is in sync with the bidi
10577 iterator.
10578 (handle_single_display_spec, get_overlay_strings_1)
10579 (push_display_prop): Fix initialization of paragraph direction for
10580 string when that of the parent object is not yet determined.
10581 (reseat_1): Call bidi_init_it to resync the bidi
10582 iterator with IT's position. (Bug#7616)
10583 (find_row_edges): If ROW->start.pos gives position
10584 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10585 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10586 Reset the from_disp_prop_p flag.
10587 (SAVE_IT, RESTORE_IT): New macros.
10588 (pos_visible_p, face_before_or_after_it_pos)
10589 (back_to_previous_visible_line_start)
10590 (move_it_in_display_line_to, move_it_in_display_line)
10591 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10592 (try_scrolling, redisplay_window, display_line): Use them when
10593 saving a temporary copy of the iterator and restoring it back.
10594 (back_to_previous_visible_line_start, reseat_1)
10595 (init_iterator): Empty the bidi cache "stack".
10596 (move_it_in_display_line_to): If iterator ended up at
10597 EOL, but we never saw any buffer positions smaller than
10598 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10599 motion in bidi-reordered lines.
10600 (move_it_in_display_line_to): Record prev_method and prev_pos
10601 immediately before the call to set_iterator_to_next. Fixes cursor
10602 motion in bidi-reordered lines with stretch glyphs and strings
10603 displayed in margins. (Bug#8133) (Bug#8867)
10604 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10605 TO_CHARPOS.
640c8776
SM
10606 (pos_visible_p): Support positions in bidi-reordered lines.
10607 Save and restore bidi cache.
0bb23927
EZ
10608
10609 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10610 (bidi_paragraph_info): Delete unused struct.
10611 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10612 (bidi_cache_start): New variable.
10613 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10614 to zero.
10615 (bidi_cache_fetch_state, bidi_cache_search)
10616 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10617 (bidi_cache_find, bidi_peek_at_next_level)
10618 (bidi_level_of_next_char, bidi_find_other_level_edge)
10619 (bidi_move_to_visually_next): Compare cache index with
10620 bidi_cache_start rather than with zero.
10621 (bidi_fetch_char): Accept new argument STRING; all callers
10622 changed. Support iteration over a string. Support strings with
10623 display properties. Support unibyte strings. Fix the type of
10624 `len' according to what STRING_CHAR_AND_LENGTH expects.
10625 (bidi_paragraph_init, bidi_resolve_explicit_1)
10626 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10627 (bidi_level_of_next_char, bidi_move_to_visually_next):
10628 Support iteration over a string.
0bb23927
EZ
10629 (bidi_set_sor_type, bidi_resolve_explicit_1)
10630 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10631 can now be zero (for strings); special values 0 and -1 were
10632 changed to -1 and -2, respectively.
10633 (bidi_char_at_pos): New function.
10634 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10635 Call it instead of FETCH_MULTIBYTE_CHAR.
10636 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10637 initialized to valid values.
10638 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10639 values.
10640 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10641 the test for valid cached positions. Fix the logic for looking up
10642 the sentinel state in the cache. GCPRO the Lisp string we are
10643 iterating.
10644 (bidi_push_it, bidi_pop_it): New functions.
10645 (bidi_initialize): Initialize the bidi cache start stack pointer.
10646 (bidi_cache_ensure_space): New function, refactored from part of
10647 bidi_cache_iterator_state. Don't assume the required size is just
10648 one BIDI_CACHE_CHUNK away.
10649 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10650 (bidi_count_bytes, bidi_char_at_pos): New functions.
10651 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10652 always valid if bidi_cache_idx is valid.
10653 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10654 is valid if it's going to be used.
10655 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10656 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10657 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10658 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10659 (bidi_find_other_level_edge, bidi_cache_start_stack):
10660 All variables related to cache indices are now EMACS_INT.
c965adc5 10661
0bb23927
EZ
10662 * dispextern.h (struct bidi_string_data): New structure.
10663 (struct bidi_it): New member `string'. Make flag members be 1-bit
10664 fields, and put them last in the struct.
640c8776
SM
10665 (compute_display_string_pos, compute_display_string_end):
10666 Update prototypes.
0bb23927
EZ
10667 (bidi_push_it, bidi_pop_it): Add prototypes.
10668 (struct iterator_stack_entry): New members bidi_p,
10669 paragraph_embedding, and from_disp_prop_p.
10670 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10671 (bidi_shelve_cache, bidi_unshelve_cache):
10672 Declare prototypes.
0bb23927
EZ
10673
10674 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10675 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10676 and vector-like objects.
10677
10678 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10679 cache around display iteration.
10680
10681 * window.c (Fwindow_end, window_scroll_pixel_based)
10682 (displayed_window_lines, Frecenter): Save and restore the bidi
10683 cache around display iteration.
10684
3bbd2265
LMI
106852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10686
10687 * editfns.c (Fdelete_region): Clarify the use of the named
10688 parameters (bug#6788).
10689
adc47434
MR
106902011-07-14 Martin Rudalics <rudalics@gmx.at>
10691
10692 * indent.c (Fvertical_motion): Set and restore w->pointm when
10693 saving and restoring the window's buffer (Bug#9006).
10694
837c31f8
LMI
106952011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10696
10697 * editfns.c (Fstring_to_char): Clarify just what is returned
10698 (bug#6576). Text by Eli Zaretskii.
10699
ac389d0c
JB
107002011-07-13 Juanma Barranquero <lekktu@gmail.com>
10701
10702 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10703
0be0ce47
EZ
107042011-07-13 Eli Zaretskii <eliz@gnu.org>
10705
10706 * buffer.c (mmap_find): Fix a typo.
10707
cd18e7e3
JB
107082011-07-13 Johan Bockgård <bojohan@gnu.org>
10709
10710 Fix execution of x selection hooks.
10711 * xselect.c (Qx_lost_selection_functions)
10712 (Qx_sent_selection_functions): New vars.
10713 (syms_of_xselect): DEFSYM them.
10714 (x_handle_selection_request): Pass Qx_sent_selection_functions
10715 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10716 (x_handle_selection_clear,x_clear_frame_selections):
10717 Pass Qx_lost_selection_functions rather than
10718 Vx_lost_selection_functions to Frun_hook_with_args.
10719
47ea7f44
PE
107202011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10721
ac389d0c 10722 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10723 The old code sometimes used this field without initializing it.
10724
47ea7f44
PE
10725 * alloc.c (gc_sweep): Don't read past end of array.
10726 In theory, the old code could also have corrupted Emacs internals,
10727 though it'd be very unlikely.
10728
bc985c87
AS
107292011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10730
10731 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10732 argument. (Bug#4026)
bc985c87 10733
0cf34688
LMI
107342011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10735
b3dadd76
LMI
10736 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10737 key" (bug#4257).
10738
0cf34688
LMI
10739 * window.c (Fset_window_start): Doc fix (bug#4199).
10740 (Fset_window_hscroll): Ditto.
10741
270768cd
PE
107422011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10743
077e3dda 10744 Fix minor new problems caught by GCC 4.6.1.
270768cd 10745 * term.c (init_tty): Remove unused local.
490011a6 10746 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10747 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10748 not used otherwise.
270768cd 10749
b1f58454
CY
107502011-07-12 Chong Yidong <cyd@stupidchicken.com>
10751
10752 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10753
22b9578d
LMI
107542011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10755
6e70ab07
LMI
10756 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10757 are the mini-buffer and the echo area (bug#3320).
10758
22b9578d
LMI
10759 * term.c (init_tty): Remove support for supdup, c10 and perq
10760 terminals, which are no longer supported (bug#1482).
10761
8974cc9f
JB
107622011-07-10 Johan Bockgård <bojohan@gnu.org>
10763
10764 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10765
a560d974
JD
107662011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10767
10768 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10769 for non-popups (Bug#3642).
10770
1dae0f0a
AS
107712011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10772
268c2c36 10773 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10774 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10775 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10776 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10777 * data.c (fmod): Likewise.
10778 * dispnew.c (swap_glyphs_in_rows): Likewise.
10779 * emacs.c (memory_warning_signal): Likewise.
10780 * floatfns.c (float_error): Likewise.
10781 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10782 (otf_open, font_otf_capability, generate_otf_features)
10783 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10784 Likewise.
10785 * image.c (pbm_read_file): Likewise.
10786 * indent.c (string_display_width): Likewise.
10787 * intervals.c (check_for_interval, search_for_interval)
10788 (inc_interval_count, count_intervals, root_interval)
10789 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10790 * lread.c (defalias): Likewise.
268c2c36 10791 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10792 * regex.c (set_image_of_range_1, set_image_of_range)
10793 (regex_grow_registers): Likewise.
10794 * sysdep.c (strerror): Likewise.
10795 * termcap.c (valid_filename_p, tprint, main): Likewise.
10796 * tparam.c (main): Likewise.
10797 * unexhp9k800.c (run_time_remap, save_data_space)
10798 (update_file_ptrs, read_header, write_header, calculate_checksum)
10799 (copy_file, copy_rest, display_header): Likewise.
10800 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10801 Likewise.
10802 * xdisp.c (check_it): Likewise.
10803 * xfaces.c (register_color, unregister_color, unregister_colors):
10804 Likewise.
10805 * xfns.c (print_fontset_result): Likewise.
10806 * xrdb.c (member, fatal, main): Likewise.
10807
99033785
PE
108082011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10809
10810 Fix minor problems found by static checking (Bug#9031).
10811 * chartab.c (char_table_set_range, map_sub_char_table):
10812 Remove unused locals.
10813 (uniprop_table): Now static.
10814 * composite.c (_work_char): Remove unused static var.
10815
9cb2ac56
JB
108162011-07-09 Juanma Barranquero <lekktu@gmail.com>
10817
10818 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10819
f25661f0
JD
108202011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10821
10822 * gtkutil.c (qttip_cb): Remove code without function.
10823
8278c4fe
EZ
108242011-07-09 Eli Zaretskii <eliz@gnu.org>
10825
10826 * w32.c (pthread_sigmask): New stub.
10827
1692ae2d 108282011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10829
8a6ebd58 10830 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10831 sigprocmask is portable only for single-threaded applications, and
10832 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10833 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10834 (LIBES): Use it.
10835 * callproc.c (Fcall_process):
10836 * process.c (create_process):
10837 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10838 Use pthread_sigmask, not sigprocmask.
123403e4 10839
1b854618
JD
108402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10841
10842 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10843 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10844 wrong (Bug#8591).
10845
3fe4b549
JD
108462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10847
0ce7e563
JD
10848 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10849 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10850 (xg_hide_tooltip): Fix comment.
10851
3fe4b549
JD
10852 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10853 in registerServicesMenuSendTypes.
10854 (validRequestorForSendType): Don't check ns_return_types.
10855
10856 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10857 ns_return_type.
10858
5df75e47
JR
108592011-07-08 Jason Rumney <jasonr@gnu.org>
10860
22610910
JR
10861 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10862 SH_SHOW for hidden windows (Bug#5482).
10863
5df75e47
JR
10864 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10865 frame struct members of non-existent frames (Bug#6284).
10866
699c10bd
JD
108672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10868
4393663b
JD
10869 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10870 variable firstTime not needed on OSX >= 10.6.
10871 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10872 >= 10.5. Use setKnobProportion, setDoubleValue.
10873
10874 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10875 (MAC_OS_X_VERSION_10_5): Define if not defined.
10876 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10877 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10878 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10879
10880 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10881 cString and lossyCString on OSX >= 10.4.
4393663b 10882
58179cce 10883 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10884 sizeToFit on OSX >= 10.2.
10885
10886 * nsimage.m (allocInitFromFile): Don't use deprecated method
10887 bestRepresentationForDevice on OSX >= 10.6.
10888
10889 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10890 to avoid warning.
10891
10892 * emacs.c: Declare unexec_init_emacs_zone.
10893
a63e0781
JD
10894 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10895
699c10bd
JD
10896 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10897
10898 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10899 on svcsMenu (Bug#8842).
10900
10901 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10902 ns_return_types.
10903 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10904
10905 * nsterm.m (QUTF8_STRING): Declare.
10906 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10907 (validRequestorForSendType): Return type is (id).
10908 Change indexOfObjectIdenticalTo to indexOfObject.
10909 Check if we have local selection before returning self (Bug#8842).
10910 (writeSelectionToPasteboard): Put local selection into paste board
10911 if we have a local selection (Bug#8842).
10912 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10913
10914 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10915 (ns_get_local_selection): Declare.
10916
54e10184
LMI
109172011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10918
9888ff71
LMI
10919 * keymap.c (describe_map_tree): Don't insert a double newline at
10920 the end of the buffer (bug#1169) and return whether we inserted
10921 something.
10922
54e10184
LMI
10923 * callint.c (Fcall_interactively): Change "reading args" to
10924 "providing args" to try to clarify what it does (bug#1010).
10925
15fa4783
KH
109262011-07-07 Kenichi Handa <handa@m17n.org>
10927
10928 * composite.c (composition_compute_stop_pos): Ignore a static
10929 composition starting before CHARPOS (Bug#8915).
10930
10931 * xdisp.c (handle_composition_prop): Likewise.
10932
a8815b00
EZ
109332011-07-07 Eli Zaretskii <eliz@gnu.org>
10934
10935 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10936 (Bug#9015)
10937
ef7b981d 109382011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10939
10940 * character.h (unicode_category_t): New enum type.
10941
10942 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10943 (Qchar_code_property_table): New variable.
10944 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10945 (UNIPROP_COMPRESSED_FORM_P): New macros.
10946 (char_table_ascii): Uncompress the compressed values.
10947 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10948 Uncompress the compressed values.
ac389d0c 10949 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10950 (char_table_ref_and_range): Uncompress the compressed values.
10951 (sub_char_table_set): New arg is_uniprop. Callers changed.
10952 Uncompress the compressed values.
10953 (sub_char_table_set_range): Args changed. Callers changed.
10954 (char_table_set_range): Adjuted for the above change.
10955 (map_sub_char_table): Delete args default_val and parent. Add arg
10956 top. Give decoded values to a Lisp function.
640c8776 10957 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10958 values to a Lisp function. Gcpro more variables.
10959 (uniprop_table_uncompress)
10960 (uniprop_decode_value_run_length): New functions.
10961 (uniprop_decoder, uniprop_decoder_count): New variables.
10962 (uniprop_get_decoder, uniprop_encode_value_character)
10963 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10964 New functions.
10965 (uniprop_encoder, uniprop_encoder_count): New variables.
10966 (uniprop_get_encoder, uniprop_table)
10967 (Funicode_property_table_internal, Fget_unicode_property_internal)
10968 (Fput_unicode_property_internal): New functions.
10969 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10970 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10971 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10972 char-code-property-alist.
10973
640c8776 10974 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10975 Vunicode_category_table.
10976
640c8776 10977 * font.c (font_range): Adjust for the change of
c805dec0
KH
10978 Vunicode_category_table.
10979
76b397fb
DN
109802011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10981
10982 * m/iris4d.h: Remove file, move contents ...
10983 * s/irix6-5.h: ... here.
10984
22b4128e
PE
109852011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10986
10987 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10988 * alloc.c (mark_buffer):
10989 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10990 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10991 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10992 This isn't true in general, and it's particularly not true
10993 if Emacs is configured with --with-wide-int.
10994 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10995 New macros, used in the buffer.c change.
10996
869795d6
JD
109972011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10998
10999 * xsettings.c: Use both GConf and GSettings if both are available.
11000 (store_config_changed_event): Add comment.
11001 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11002 (store_tool_bar_style_changed): New functions.
5e617bc2 11003 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11004 (struct xsettings): Move font inside HAVE_XFT.
11005 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11006 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11007 Move inside HAVE_XFT.
640c8776 11008 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11009 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11010 also.
11011 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11012 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11013 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11014 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11015 (parse_settings): Move check for font inside HAVE_XFT.
11016 (read_settings, apply_xft_settings): Add comment.
11017 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11018 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11019 call store_font_name_changed.
11020 (xft_settings_event): Add comment.
11021 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11022 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11023 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11024 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11025 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11026 (xsettings_get_system_font, xsettings_get_system_normal_font):
11027 Add comment.
869795d6 11028
d8ed26bd
PE
110292011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11030
11031 Random fixes. E.g., (random) never returned negative values.
11032 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11033 subseconds part to the entropy, as that's a bit more random.
11034 Prefer signed to unsigned, since the signedness doesn't matter and
11035 in general we prefer signed. When given a limit, use a
11036 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11037 latter isn't right if USE_2_TAGS_FOR_INTS.
11038 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11039 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11040
cabf1cac
SM
110412011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11042
11043 * textprop.c (text_property_stickiness):
11044 Obey Vtext_property_default_nonsticky.
11045 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11046 * w32fns.c (syms_of_w32fns):
11047 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11048
6e9b2be9
PE
110492011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11050
11051 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11052 This is more efficient than Ffile_directory_p and avoids a minor race.
11053
90186c68
LMI
110542011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11055
7c301272
LMI
11056 * buffer.c (Foverlay_put): Say what the return value is
11057 (bug#7835).
11058
c4f2d8d4
LMI
11059 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11060 is a directory before asking whether to use the file name
11061 (bug#7564).
ad637907
LMI
11062 (barf_or_query_if_file_exists): Make the "File is a directory"
11063 error be more correct.
c4f2d8d4 11064
90186c68
LMI
11065 * fns.c (Frequire): Remove the mention of the .gz files, since
11066 that's installation-specific, but keep the mention of
11067 `get-load-suffixes'.
11068
da64016e
PE
110692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11070
11071 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11072 Report string overflow if the output is too long.
11073
7d47b580
JB
110742011-07-04 Juanma Barranquero <lekktu@gmail.com>
11075
a555cb87
JB
11076 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11077 (syms_of_gnutls): Remove duplicate DEFSYM for
11078 Qgnutls_bootprop_verify_hostname_error, an error for
11079 Qgnutls_bootprop_verify_error (which is no longer used).
11080
7d47b580
JB
11081 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11082 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11083 Also (re)move comments that are misplaced or no longer relevant.
11084
1e49bfab
LMI
110852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11086
11087 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11088
1485f4c0
CY
110892011-07-03 Chong Yidong <cyd@stupidchicken.com>
11090
11091 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11092 and background color parameters if they have been changed.
11093
a9ab721e
LMI
110942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11095
11096 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11097
cf7cff57
PE
110982011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11099
2e13213d
PE
11100 * xsettings.c (SYSTEM_FONT): Define only when used.
11101 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11102
cf7cff57
PE
11103 * keymap.c (access_keymap_1): Now static.
11104
7a8e04f7
CY
111052011-07-02 Chong Yidong <cyd@stupidchicken.com>
11106
11107 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11108 leave any prefix arg for the up event (Bug#1586).
11109
61352f62
LMI
111102011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11111
69bb1ef7
LMI
11112 * lread.c (syms_of_lread): Mention single symbols defined by
11113 `defvar' or `defconst' (bug#7154).
11114
61352f62 11115 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 11116 (Frequire): Mention get-load-suffixes.
61352f62 11117
28545e04
MR
111182011-07-02 Martin Rudalics <rudalics@gmx.at>
11119
11120 * window.h (window): Remove clone_number slot.
11121 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11122 Remove.
11123 (make_parent_window, make_window, saved_window)
11124 (Fset_window_configuration, save_window_save): Don't deal with
11125 clone numbers.
11126 * buffer.c (Qclone_number): Remove declaration.
11127 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11128
3349e122
SM
111292011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11130
11131 Add multiple inheritance to keymaps.
11132 * keymap.c (Fmake_composed_keymap): New function.
11133 (Fset_keymap_parent): Simplify.
11134 (fix_submap_inheritance): Remove.
11135 (access_keymap_1): New function extracted from access_keymap to handle
11136 embedded parents and handle lists of maps.
11137 (access_keymap): Use it.
11138 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11139 (Fcopy_keymap): Handle embedded parents.
11140 (Fcommand_remapping, define_as_prefix): Simplify.
11141 (Fkey_binding): Simplify.
11142 (syms_of_keymap): Move minibuffer-local-completion-map,
11143 minibuffer-local-filename-completion-map,
11144 minibuffer-local-must-match-map, and
11145 minibuffer-local-filename-must-match-map to Elisp.
11146 (syms_of_keymap): Defsubr make-composed-keymap.
11147 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11148 (parse_menu_item): Trivial simplification.
11149
3279eb87
GM
111502011-07-01 Glenn Morris <rgm@gnu.org>
11151
11152 * Makefile.in (SETTINGS_LIBS): Fix typo.
11153
39cb9e56 111542011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11155
11156 * coding.c (Fencode_coding_string): Record the last coding system
11157 used, as the function doc string says (bug#8738).
11158
0949d2b6
JD
111592011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11160
11161 * xsettings.c (store_monospaced_changed): Take new font as arg and
11162 check for change against current_mono_font.
11163 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11164 (emacs_settings_constructor, emacs_settings_get_property)
11165 (emacs_settings_set_property, emacs_settings_class_init)
11166 (emacs_settings_init, gsettings_obj): Remove.
11167 (something_changedCB): New function for HAVE_GSETTINGS.
11168 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11169 with value as argument.
11170 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11171 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11172 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11173 "changed".
11174
11175 * xgselect.c: Add defined (HAVE_GSETTINGS).
11176 (xgselect_initialize): Ditto.
11177
11178 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11179 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11180 xg_select.
11181
bbc6b304
PE
111822011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11183
11184 * eval.c (struct backtrace): Simplify and port the data structure.
11185 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11186 signed bit field, as this assumption is not portable and it makes
11187 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11188 "char debug_on_exit : 1" as this is not portable either; instead,
11189 use the portable "unsigned int debug_on_exit : 1". Remove unused
11190 member evalargs. Remove obsolete comments about cc bombing out.
11191
9851bfc5
JD
111922011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11193
51bb811f 11194 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11195 Let HAVE_GSETTINGS override HAVE_GCONF.
11196 (store_monospaced_changed): New function.
11197 (EMACS_SETTINGS): A new type derived from GObject to handle
11198 GSettings notifications.
11199 (emacs_settings_constructor, emacs_settings_get_property)
11200 (emacs_settings_set_property, emacs_settings_class_init):
11201 New functions.
11202 (gsettings_client, gsettings_obj): New variables.
11203 (GSETTINGS_SCHEMA): New define.
11204 (something_changedCB): Call store_monospaced_changed.
11205 (init_gsettings): New function.
11206 (xsettings_initialize): Call init_gsettings.
11207 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
11208 to NULL.
11209
640c8776 11210 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
11211 GCONF_CFLAGS/LIBS.
11212
5386012d
MR
112132011-06-29 Martin Rudalics <rudalics@gmx.at>
11214
11215 * window.c (resize_root_window, grow_mini_window)
11216 (shrink_mini_window): Rename Qresize_root_window to
11217 Qwindow_resize_root_window and Qresize_root_window_vertically to
11218 Qwindow_resize_root_window_vertically.
11219
f13e0b08
PE
112202011-06-28 Paul Eggert <eggert@cs.ucla.edu>
11221
11222 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11223
94515237
JB
112242011-06-27 Juanma Barranquero <lekktu@gmail.com>
11225
11226 * makefile.w32-in: Redesign dependencies so they reflect more
11227 clearly which files are directly included by each source file,
11228 and not through other includes.
11229
e43b6e43
MR
112302011-06-27 Martin Rudalics <rudalics@gmx.at>
11231
11232 * buffer.c (Qclone_number): Declare static and DEFSYM it.
11233 (sort_overlays, overlay_strings): When an overlay's clone number
11234 matches the window's clone number process the overlay even if
11235 the overlay's window property doesn't match the current window.
11236
d68443dc
MR
11237 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
11238 (Fwindow_hchild): Rename to Fwindow_left_child.
11239 (Fwindow_next): Rename to Fwindow_next_sibling.
11240 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
11241 (resize_window_check): Rename to window_resize_check.
11242 (resize_window_apply): Rename to window_resize_apply.
11243 (Fresize_window_apply): Rename to Fwindow_resize_apply.
11244 (Fdelete_other_windows_internal, resize_frame_windows)
11245 (Fsplit_window_internal, Fdelete_window_internal)
11246 (grow_mini_window, shrink_mini_window)
11247 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 11248
c7e73be5
JD
112492011-06-26 Jan Djärv <jan.h.d@swipnet.se>
11250
11251 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11252 (emacs_fixed_set_min_size): Remove.
11253 (emacs_fixed_new): Take frame as argument.
11254
11255 * emacsgtkfixed.c: State that this is only used with Gtk+3.
11256 (_EmacsFixedPrivate): Remove minwidth/height.
11257 Add struct frame *f.
11258 (emacs_fixed_init): Initialize priv->f.
11259 (get_parent_class, emacs_fixed_set_min_size): Remove.
11260 (emacs_fixed_new): Set priv->f to argument.
11261 (emacs_fixed_get_preferred_width)
11262 (emacs_fixed_get_preferred_height): Use min_width/height from
11263 frames size_hint to set minimum and natural (Bug#8919).
11264 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
11265 and use min_width/height from frames size_hint to set
11266 min_width/height (Bug#8919).
11267
11268 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
11269 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
11270 Fix indentation.
c7e73be5 11271
cf99dcf8
EZ
112722011-06-26 Eli Zaretskii <eliz@gnu.org>
11273
11274 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
11275 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
11276 called at ZV.
11277
029529ac
CY
112782011-06-26 Chong Yidong <cyd@stupidchicken.com>
11279
11280 * process.c (wait_reading_process_output): Bypass select if
11281 waiting for a cell while ignoring keyboard input, and input is
11282 pending. Suggested by Jan Djärv (Bug#8869).
11283
7a7ef429
PE
112842011-06-25 Paul Eggert <eggert@cs.ucla.edu>
11285
11286 Use gnulib's dup2 module instead of rolling our own.
11287 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11288
11fdef7d 112892011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
11290
11291 * dispnew.c (scrolling_window): Before scrolling, turn off a
11292 mouse-highlight in the window being scrolled.
11293
cd3520a4
JB
112942011-06-24 Juanma Barranquero <lekktu@gmail.com>
11295
11296 Move DEFSYM to lisp.h and use everywhere.
11297
11298 * character.h (DEFSYM): Move declaration...
11299 * lisp.h (DEFSYM): ...here.
11300
11301 * gnutls.c:
11302 * minibuf.c:
11303 * w32menu.c:
11304 * w32proc.c:
11305 * w32select.c: Don't include character.h.
11306
11307 * alloc.c (syms_of_alloc):
11308 * buffer.c (syms_of_buffer):
11309 * bytecode.c (syms_of_bytecode):
11310 * callint.c (syms_of_callint):
11311 * casefiddle.c (syms_of_casefiddle):
11312 * casetab.c (init_casetab_once):
11313 * category.c (init_category_once, syms_of_category):
11314 * ccl.c (syms_of_ccl):
11315 * cmds.c (syms_of_cmds):
11316 * composite.c (syms_of_composite):
11317 * dbusbind.c (syms_of_dbusbind):
11318 * dired.c (syms_of_dired):
11319 * dispnew.c (syms_of_display):
11320 * doc.c (syms_of_doc):
11321 * editfns.c (syms_of_editfns):
11322 * emacs.c (syms_of_emacs):
11323 * eval.c (syms_of_eval):
11324 * fileio.c (syms_of_fileio):
11325 * fns.c (syms_of_fns):
11326 * frame.c (syms_of_frame):
11327 * fringe.c (syms_of_fringe):
11328 * insdel.c (syms_of_insdel):
11329 * keymap.c (syms_of_keymap):
11330 * lread.c (init_obarray, syms_of_lread):
11331 * macros.c (syms_of_macros):
11332 * msdos.c (syms_of_msdos):
11333 * print.c (syms_of_print):
11334 * process.c (syms_of_process):
11335 * search.c (syms_of_search):
11336 * sound.c (syms_of_sound):
11337 * syntax.c (init_syntax_once, syms_of_syntax):
11338 * terminal.c (syms_of_terminal):
11339 * textprop.c (syms_of_textprop):
11340 * undo.c (syms_of_undo):
11341 * w32.c (globals_of_w32):
11342 * window.c (syms_of_window):
11343 * xdisp.c (syms_of_xdisp):
11344 * xfaces.c (syms_of_xfaces):
11345 * xfns.c (syms_of_xfns):
11346 * xmenu.c (syms_of_xmenu):
11347 * xsettings.c (syms_of_xsettings):
11348 * xterm.c (syms_of_xterm): Use DEFSYM.
11349
4228cf16
TZ
113502011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
11351
cd3520a4 11352 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 11353
7fcccf1e
PE
113542011-06-23 Paul Eggert <eggert@cs.ucla.edu>
11355
7efb4e0e
PE
11356 Integer and buffer overflow fixes (Bug#8873).
11357
ff5844ad
PE
11358 * print.c (printchar, strout): Check for string overflow.
11359 (PRINTPREPARE, printchar, strout):
11360 Don't set size unless allocation succeeds.
11361
90532f02
PE
11362 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
11363 for sizes. Check for string overflow more accurately.
11364 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
11365
6d84508d
PE
11366 * macros.c: Integer and buffer overflow fixes.
11367 * keyboard.h (struct keyboard.kbd_macro_bufsize):
11368 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
11369 Use ptrdiff_t, not int, for sizes.
11370 Don't increment bufsize until after realloc succeeds.
11371 Check for size-calculation overflow.
11372 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
11373
437b2cb4
PE
11374 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
11375
8b9ac8b4
PE
11376 * lread.c: Integer overflow fixes.
11377 (read_integer): Radix is now EMACS_INT, not int,
11378 to improve quality of diagnostics for out-of-range radices.
11379 Calculate buffer size correctly for out-of-range radices.
11380 (read1): Check for integer overflow in radices, and in
11381 read-circle numbers.
82cb60d3
PE
11382 (read_escape): Avoid int overflow.
11383 (Fload, openp, read_buffer_size, read1)
11384 (substitute_object_recurse, read_vector, read_list, map_obarray):
11385 Use ptrdiff_t, not int, for sizes.
11386 (read1): Use EMACS_INT, not int, for sizes.
20270765 11387 Check for size overflow.
8b9ac8b4 11388
7fcccf1e
PE
11389 * image.c (cache_image): Check for size arithmetic overflow.
11390
bfbbd7e7
PE
11391 * lread.c: Integer overflow issues.
11392 (saved_doc_string_size, saved_doc_string_length)
11393 (prev_saved_doc_string_size, prev_saved_doc_string_length):
11394 Now ptrdiff_t, not int.
11395 (read1): Don't assume doc string length fits in int. Check for
11396 out-of-range doc string lengths.
11397 (read_list): Don't assume file position fits in int.
39019e54 11398 (read_escape): Check for hex character overflow.
bfbbd7e7 11399
4e323265
LL
114002011-06-22 Leo Liu <sdl.web@gmail.com>
11401
11402 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
11403 Move to minibuffer.el.
11404
85fece3e
PE
114052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11406
20b84ce9 11407 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
11408 The following patches are for when GLYPH_DEBUG && !XASSERT.
11409 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11410 * dispnew.c (flush_stdout):
11411 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
11412 Mark as externally visible.
11413 * dispnew.c (check_window_matrix_pointers): Now static.
11414 * dispnew.c (window_to_frame_vpos):
11415 * xfns.c (unwind_create_frame):
11416 * xterm.c (x_check_font): Remove unused local.
11417 * scroll.c (CHECK_BOUNDS):
11418 * xfaces.c (cache_fache): Rename local to avoid shadowing.
11419 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
11420 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
11421 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
11422 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
11423 Now static.
11424 (debug_method_add): Use va_list and vsprintf rather than relying
11425 on undefined behavior with wrong number of arguments.
11426 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
11427 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
11428 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
11429 since we're not interested in debugging glyphs with old libraries.
11430 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
11431 GCC 4.6.0's static checking.
11432
0766b489
PE
114332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11434
31fd4b32
PE
11435 Integer overflow and signedness fixes (Bug#8873).
11436 A few related buffer overrun fixes, too.
11437
b79e8648
PE
11438 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
11439
0766b489
PE
11440 * dispextern.h (struct face.stipple):
11441 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
11442 (x_bitmap_mask, x_allocate_bitmap_record)
11443 (x_create_bitmap_from_data, x_create_bitmap_from_file)
11444 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
11445 (x_create_bitmap_from_xpm_data):
11446 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
11447 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
11448 (.bitmaps_last):
11449 * xfaces.c (load_pixmap):
11450 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
11451 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
11452 (.bitmaps_last, struct x_output.icon_bitmap):
11453 Use ptrdiff_t, not int, for bitmap indexes.
11454 (x_allocate_bitmap_record): Check for size overflow.
11455 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
11456
b081724f
PE
11457 Use ptrdiff_t, not int, for overlay counts.
11458 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
11459 * editfns.c (overlays_around, get_pos_property):
11460 * textprop.c (get_char_property_and_overlay):
11461 * xdisp.c (next_overlay_change, note_mouse_highlight):
11462 * xfaces.c (face_at_buffer_position):
21514da7
PE
11463 * buffer.c (OVERLAY_COUNT_MAX): New macro.
11464 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11465 (Fnext_overlay_change, Fprevious_overlay_change)
11466 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 11467 Use ptrdiff_t, not int, for sizes.
21514da7 11468 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 11469
3de73e5e
PE
11470 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
11471
2606c57b
PE
11472 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
11473 (x_session_initialize): Do not assume string length fits in int.
11474
aaafe47a
PE
11475 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
11476 This is unlikely, but can occur if DPI is outlandish.
11477
2674ddc8 11478 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
11479 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11480
28154962
PE
11481 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
11482 * xrdb.c (magic_file_p, search_magic_path):
11483 Omit last arg SUFFIX; it was always 0. All callers changed.
11484 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
11485
7de51af5
PE
11486 * xfont.c (xfont_match): Avoid need for strlen.
11487
25ed6cc3
PE
11488 * xfns.c: Don't assume strlen fits in int.
11489 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11490
4eab31dd
PE
11491 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11492 not unsigned long, as we prefer signed integers. All callers changed.
11493 Detect integer overflow in repeat count.
11494 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11495 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11496
171e2a58
PE
11497 * termcap.c: Don't assume sizes fit in int and never overflow.
11498 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11499 (gobble_line): Check for size-calculation overflow.
11500
ad39faca 11501 * minibuf.c (Fread_buffer):
6e5bb2dc 11502 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11503 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11504 Don't assume string length fits in int.
11505
52c61c22 11506 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11507 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11508
b5b8c9e5
PE
11509 * font.c: Don't assume string length fits in int.
11510 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11511 Use ptrdiff_t, not int.
ccd6111c
PE
11512 (font_intern_prop): Don't assume string length fits in int.
11513 Don't assume integer property fits in fixnum.
11514 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11515
882f0d81 11516 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11517 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11518 Reformulate so as not to need the command string.
11519 Invoke gzip -cd rather than gunzip, as it's more portable.
11520 (lock_info_type, lock_file_1, lock_file):
11521 Don't assume pid_t and time_t fit in unsigned long.
11522 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11523 (current_lock_owner): Prefer signed type for sizes.
11524 Use memcpy, not strncpy, where memcpy is what is really wanted.
11525 Don't assume (via atoi) that time_t and pid_t fit in int.
11526 Check for time_t and/or pid_t out of range, e.g., via a network share.
11527 Don't alloca where an auto var works fine.
11528
93f4cf88
PE
11529 * fileio.c: Fix some integer overflow issues.
11530 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11531 Don't assume string length fits in int.
11532 (directory_file_name): Don't assume string length fits in long.
11533 (make_temp_name): Don't assume pid fits in int, or that its print
11534 length is less than 20.
11535
f3e92b69
PE
11536 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11537
1bfdaf10
PE
11538 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11539
35016e9a
PE
11540 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11541
3d1e65a1
PE
11542 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11543 We prefer signed integers, even for size calculations.
11544
0b963a93
PE
11545 * emacs.c: Don't assume string length fits in 'int'.
11546 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11547 (main): Don't invoke strlen when not needed.
11548
573f4b54
PE
11549 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11550 (XD_DEBUG_MESSAGE): Don't waste a byte.
11551
989f33ba
PE
11552 * callproc.c (getenv_internal_1, getenv_internal)
11553 (Fgetenv_internal):
965d34eb
PE
11554 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11555
e4d29b33
PE
11556 * lread.c (invalid_syntax): Omit length argument.
11557 All uses changed. This doesn't fix a bug, but it simplifies the
11558 code away from its former Hollerith-constant appearance, and it's
11559 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11560 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11561
eb49b136
PE
11562 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11563 This didn't break anything, but it didn't help either.
11564 It's confusing to put a bogus integer in a place where the actual
11565 value does not matter.
9f62aeb1 11566 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11567 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11568
15375a22
PE
11569 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11570 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11571 implementation.
b61cc01c
PE
11572 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11573 We prefer signed types, and the value cannot exceed the EMACS_INT
11574 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11575 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11576 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11577 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11578
53b2623d
PE
11579 * indent.c (sane_tab_width): New function.
11580 (current_column, scan_for_column, Findent_to, position_indentation)
11581 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11582 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11583
51cab52b 11584 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11585
f2ed8a70
PE
11586 * lisp.h (lint_assume): New macro.
11587 * composite.c (composition_gstring_put_cache):
11588 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11589
abe80cc6
PE
11590 * editfns.c, insdel.c:
11591 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11592
b02c740e
PE
11593 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11594
ebc96716
PE
11595 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11596
b4e50fa0 11597 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11598 Use much-faster test for byte-length change.
311d5d7c 11599 Don't assume string byte-length fits in 'int'.
a4cf38e4 11600 Check that character arg fits in 'int'.
85461888 11601 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11602
c0c1ee9f
PE
11603 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11604
a498d7f4
PE
11605 * fns.c (concat): Catch string overflow earlier.
11606 Do not rely on integer wraparound.
11607
51cab52b
PE
11608 * dispextern.h (struct it.overlay_strings_charpos)
11609 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11610 * xdisp.c (forward_to_next_line_start)
11611 (back_to_previous_visible_line_start)
11612 (reseat_at_next_visible_line_start, next_element_from_buffer):
11613 Don't arbitrarily truncate the value of 'selective' to int.
11614
76031fad
PE
11615 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11616
5eb55db9
PE
11617 * composite.c: Don't truncate sizes to 'int'.
11618 (composition_gstring_p, composition_reseat_it)
11619 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11620 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11621 not EMACS_UINT, for indexes.
5eb55db9 11622
0703a717
PE
11623 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11624
d6202519
PE
11625 * buffer.c: Include <verify.h>.
11626 (struct sortvec.priority, struct sortstr.priority):
8961a454 11627 Now EMACS_INT, not int.
c20998a7 11628 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11629 (struct sortstr.size, record_overlay_string)
11630 (struct sortstrlist.size, struct sortlist.used):
11631 Don't truncate size to int.
11632 (record_overlay_string): Check for size-calculation overflow.
d6202519 11633 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11634
d5a19415
JM
116352011-06-22 Jim Meyering <meyering@redhat.com>
11636
029529ac 11637 Don't leak an XBM-image-sized buffer
d5a19415
JM
11638 * image.c (xbm_load): Free the image buffer after using it.
11639
a9041e6c
PE
116402011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11641
11642 Port to Sun C.
11643 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11644 that Sun C diagnosed.
11645 * fns.c (secure_hash): Fix pointer signedness issue.
11646 * intervals.c (static_offset_intervals): New function.
11647 (offset_intervals): Use it.
11648
7f3f739f
LL
116492011-06-21 Leo Liu <sdl.web@gmail.com>
11650
11651 * deps.mk (fns.o):
11652 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11653 sha512.h.
11654
11655 * fns.c (secure_hash): Rename from crypto_hash_function and change
11656 the first arg to accept symbols.
5b66d427 11657 (Fsecure_hash): New primitive.
7f3f739f
LL
11658 (syms_of_fns): New symbols.
11659
76147d94
DD
116602011-06-20 Deniz Dogan <deniz@dogan.se>
11661
11662 * process.c (Fset_process_buffer): Clarify return value in
11663 docstring.
11664
7d7d0045
CY
116652011-06-18 Chong Yidong <cyd@stupidchicken.com>
11666
11667 * dispnew.c (add_window_display_history): Use BVAR.
11668
11669 * xdisp.c (debug_method_add): Use BVAR.
11670 (check_window_end, dump_glyph_matrix, dump_glyph)
11671 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11672
11673 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11674 Likewise.
11675
11676 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11677 check till after the cache is created in init_frame_faces.
11678
ff2bc410
SM
116792011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11680
11681 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11682
28177add
PE
116832011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11684
dd3482fe
PE
11685 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11686 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11687 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11688
393d71f3 11689 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11690 * fileio.c (Finsert_file_contents):
11691 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11692 Remove the old (too-loose) buffer overflow checks.
11693 They weren't needed, since make_gap checks for buffer overflow.
11694 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11695 The old code merely checked for Emacs fixnum overflow, and relied
11696 on undefined (wraparound) behavior. The new code avoids undefined
11697 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11698
2e6813b0 11699 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11700 Tune. Don't use wider integers than needed. Don't use alloca.
11701 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11702
599a9e4f
PE
11703 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11704
99561444
PE
11705 * insdel.c, lisp.h (buffer_overflow): New function.
11706 (insert_from_buffer_1, replace_range, replace_range_2):
11707 * insdel.c (make_gap_larger):
11708 * editfns.c (Finsert_char):
11709 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11710
28177add
PE
11711 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11712
e69dafad
PE
117132011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11714
4baa020d 11715 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11716
b1c46f02
PE
11717 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11718 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11719
e69dafad
PE
11720 * fileio.c: Don't assume EMACS_INT fits in off_t.
11721 (emacs_lseek): New static function.
11722 (Finsert_file_contents, Fwrite_region): Use it.
11723 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11724
566684ea
PE
11725 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11726
e6966cd6
PE
11727 * fns.c: Don't overflow int when computing a list length.
11728 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11729 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11730 truncation on 64-bit hosts. Check for QUIT every
11731 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11732 faster and is responsive enough.
11733 (Flength): Report an error instead of overflowing an integer.
11734 (Fsafe_length): Return a float if the value is not representable
11735 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11736 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11737 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11738
dd0b0efb
PE
11739 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11740 (header_size, word_size): New constants.
11741 (allocate_vectorlike): Don't check size overflow here.
11742 (allocate_vector): Check it here instead, since this is the only
11743 caller of allocate_vectorlike that could cause overflow.
11744 Check that the new vector's length is representable as a fixnum.
11745
86fe5cfe
PE
11746 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11747 The previous code was bogus. For example, next_almost_prime (32)
11748 returned 39, which is undesirable as it is a multiple of 3; and
11749 next_almost_prime (24) returned 25, which is a multiple of 5 so
11750 why was the code bothering to check for multiples of 7?
11751
80e88859
PE
11752 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11753
4a2f0ad6
PE
11754 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11755
f66c7cf8
PE
11756 Variadic C functions now count arguments with ptrdiff_t.
11757 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11758 Back then I didn't know that the Emacs coding style prefers signed int.
11759 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11760 were being counted with int, which may truncate counts on 64-bit
11761 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11762 * lisp.h (struct Lisp_Subr.function.aMANY)
11763 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11764 Arg counts are now ptrdiff_t, not size_t.
11765 All variadic functions and their callers changed accordingly.
11766 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11767 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11768 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11769 * callint.c (Fcall_interactively): Check arg count for overflow,
11770 to avoid potential buffer overrun. Use signed char, not 'int',
11771 for 'varies' array, so that we needn't bother to check its size
11772 calculation for overflow.
11773 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11774 * eval.c (apply_lambda):
11775 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11776 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11777 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11778
a1759b76
PE
11779 * callint.c (Fcall_interactively): Don't use index var as event count.
11780
d96be9fc
PE
11781 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11782 * mem-limits.h (SIZE): Remove; no longer used.
11783
a690a978 11784 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11785
578c21e6
PE
11786 Remove unnecessary casts.
11787 * xterm.c (x_term_init):
11788 * xfns.c (x_set_border_pixel):
11789 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11790 These aren't needed now that we assume ANSI C.
11791
96f53c6c
PE
11792 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11793 It's more likely to cause problems (due to unsigned overflow)
11794 than to cure them.
11795
83c77d31
PE
11796 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11797
ee2079f1
PE
11798 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11799
6da65536
PE
11800 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11801
7147c4a4
PE
11802 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11803
193e32d9
PE
11804 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11805
e5533da6
PE
11806 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11807
9910e595
PE
11808 GLYPH_CODE_FACE returns EMACS_INT, not int.
11809 * dispextern.h (merge_faces):
11810 * xfaces.c (merge_faces):
01103c44
PE
11811 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11812 Don't assume EMACS_INT fits in int.
9910e595 11813
2638320e
PE
11814 * character.h (CHAR_VALID_P): Remove unused parameter.
11815 * fontset.c, lisp.h, xdisp.c: All uses changed.
11816
045eb8d9
PE
11817 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11818
c1f134b5
PE
11819 * fns.c (concat): Minor tuning based on overflow analysis.
11820 This doesn't fix any bugs. Use int to hold character, instead
11821 of constantly refetching from Emacs object. Use XFASTINT, not
11822 XINT, for value known to be a character. Don't bother comparing
11823 a single byte to 0400, as it's always less.
11824
395fcb93 11825 * floatfns.c (Fexpt):
327eeec8
PE
11826 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11827
abbd3d23
PE
11828 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11829 for characters.
11830
684a03ef
PE
11831 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11832
0fed43f3
PE
11833 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11834 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11835 incorrectly succeed when S was a string, because 4294967386 was
11836 truncated before it was used.
11837
8fd02eb7
PE
11838 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11839 Otherwise, an out-of-range integer could cause undefined behavior
11840 on a 64-bit host.
11841
f8c86b69
PE
11842 * composite.c: Use int, not EMACS_INT, for characters.
11843 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11844 EMACS_INT, for values that are known to be in character range.
11845 This doesn't fix any bugs but is the usual style inside Emacs and
11846 may generate better code on 32-bit machines.
11847
34206dd2
PE
11848 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11849 This is for reasons similar to the recent CHAR_STRING fix.
11850 * charset.c (Fencode_char): Check that character arg is actually
11851 a character. Pass an int to ENCODE_CHAR.
11852 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11853 wider than 'int', as a compile-time check to prevent future regressions
11854 in this area.
11855
c5958d4c 11856 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11857
11858 Make sure a 64-bit char is never passed to CHAR_STRING.
11859 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11860 by silently ignoring the top 32 bits, allowing some values
11861 that were far too large to be valid characters.
11862 * character.h: Include <verify.h>.
11863 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11864 arguments are no wider than unsigned, as a compile-time check
11865 to prevent future regressions in this area.
11866 * data.c (Faset):
01103c44 11867 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11868 (Fsubst_char_in_region):
11869 * fns.c (concat):
11870 * xdisp.c (decode_mode_spec_coding):
11871 Adjust to CHAR_STRING's new requirement.
11872 * editfns.c (Finsert_char, Fsubst_char_in_region):
11873 * fns.c (concat): Check that character args are actually
11874 characters. Without this test, these functions did the wrong
11875 thing with wildly out-of-range values on 64-bit hosts.
11876
d37ca623
PE
11877 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11878 These casts should not be needed on 32-bit hosts, either.
11879 * keyboard.c (read_char):
11880 * lread.c (Fload): Remove casts to unsigned.
11881
ea204efb
PE
11882 * lisp.h (UNSIGNED_CMP): New macro.
11883 This fixes comparison bugs on 64-bit hosts.
11884 (ASCII_CHAR_P): Use it.
11885 * casefiddle.c (casify_object):
01103c44 11886 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11887 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11888 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11889 * dispextern.h (FACE_FROM_ID):
11890 * keyboard.c (read_char): Use UNSIGNED_CMP.
11891
41cb286c
PE
11892 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11893 not to EMACS_INT, to avoid GCC warning.
11894
4a1b9832
PE
11895 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11896
55daad71
PE
11897 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11898 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11899 isn't needed on 32-bit machines.
8f95c75c 11900
01103c44
PE
11901 * buffer.c (Fgenerate_new_buffer_name):
11902 Use EMACS_INT for count, not int.
0ceccced 11903 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11904
11905 * data.c (Qcompiled_function): Now static.
11906
c6f072e7
PE
11907 * window.c (window_body_lines): Now static.
11908
20ce5912
PE
11909 * image.c (gif_load): Rename local to avoid shadowing.
11910
9c4c5f81
PE
11911 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11912 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11913 * alloc.c (make_save_value): Integer argument is now of type
11914 ptrdiff_t, not int.
11915 (mark_object): Use ptrdiff_t, not int.
11916 * lisp.h (pD): New macro.
11917 * print.c (print_object): Use it.
11918
c0c5c8ae
PE
11919 * alloc.c: Use EMACS_INT, not int, to count objects.
11920 (total_conses, total_markers, total_symbols, total_vector_size)
11921 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11922 (total_free_floats, total_floats, total_free_intervals)
11923 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11924 Now EMACS_INT, not int. All uses changed.
11925 (Fgarbage_collect): Compute overall total using a double, so that
11926 integer overflow is less likely to be a problem. Check for overflow
11927 when converting back to an integer.
5a25e253
PE
11928 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11929 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11930 These were 'int' variables that could overflow on 64-bit hosts;
11931 they were never used, so remove them instead of repairing them.
211a0b2a 11932 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11933 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11934 Previously, this ceilinged at INT_MAX, but that doesn't work on
11935 64-bit machines.
e46bb31a 11936 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11937
c78baabf 11938 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11939 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11940 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11941 when a (possibly-narrower) signed value would do just as well.
11942 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11943
c9d624c6
PE
11944 * alloc.c: Catch some string size overflows that we were missing.
11945 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11946 for convenience in STRING_BYTES_MAX.
11947 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11948 The definition here is exact; the one in lisp.h was approximate.
11949 (allocate_string_data): Check for string overflow. This catches
11950 some instances we weren't catching before. Also, it catches
11951 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11952 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11953 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11954
c9d624c6
PE
11955 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11956 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11957 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11958
353032ce
PE
11959 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11960
2bccce07
PE
11961 * alloc.c (Fmake_string): Check for out-of-range init.
11962
0ac30604
SM
119632011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11964
11965 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11966
c195f2de
JD
119672011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11968
11969 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11970 xg_get_default_scrollbar_width.
11971
11972 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11973 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11974 (style_changed_cb): Call update_theme_scrollbar_width and call
11975 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11976 all frames (Bug#8505).
11977 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11978 Call gtk_window_set_resizable if HAVE_GTK3.
11979 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11980 and height if HAVE_GTK3 (Bug#8505).
11981 (scroll_bar_width_for_theme): New variable.
11982 (update_theme_scrollbar_width): New function.
11983 (xg_get_default_scrollbar_width): Move code to
11984 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11985 (xg_initialize): Call update_theme_scrollbar_width.
11986
11987 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11988
11989 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11990
e10ac9f1
MR
119912011-06-12 Martin Rudalics <rudalics@gmx.at>
11992
11993 * frame.c (make_frame): Call other_buffer_safely instead of
11994 other_buffer.
11995
11996 * window.c (temp_output_buffer_show): Call display_buffer with
11997 second argument Vtemp_buffer_show_specifiers and reset latter
11998 immediately after the call.
11999 (Vtemp_buffer_show_specifiers): New variable.
12000 (auto_window_vscroll_p, next_screen_context_lines)
12001 (Vscroll_preserve_screen_position): Remove leading asterisks from
12002 doc-strings.
12003
2d3c217e 120042011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12005
7b7f97e8 12006 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12007 * buffer.c (Qclone_number): Remove for now, as it's unused.
12008 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12009 (record_buffer): Remove unused local.
12010 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12011 (set_frame_buffer_list): Remove; unused.
12012 * frame.h (other_visible_frames): Remove decl.
12013 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12014 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12015 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12016 if HAVE_GPM.
12017 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12018 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12019 Define only if HAVE_GPM.
12020 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12021 (update_hints_inhibit): Remove; never set. All uses removed.
12022 * widgetprv.h (emacsFrameClassRec): Remove decl.
12023 * window.c (delete_deletable_window): Now returns void, since it
12024 wasn't returning anything.
12025 (compare_window_configurations): Remove unused locals.
12026 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12027 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12028 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12029 the same widths as pointers. This follows up on the 2011-05-06 patch.
12030 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12031 * xterm.h: Likewise.
12032 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12033
1384b89e
JB
120342011-06-12 Juanma Barranquero <lekktu@gmail.com>
12035
12036 * makefile.w32-in: Update dependencies.
12037 (LISP_H): Add lib/intprops.h.
12038
1100a63c
CY
120392011-06-11 Chong Yidong <cyd@stupidchicken.com>
12040
12041 * image.c (gif_load): Add animation frame delay to the metadata.
12042 (syms_of_image): Use DEFSYM. New symbol `delay'.
12043
6198ccd0
MR
120442011-06-11 Martin Rudalics <rudalics@gmx.at>
12045
12046 * window.c (delete_deletable_window): Re-add.
12047 (Fset_window_configuration): Rewrite to handle dead buffers and
12048 consequently deletable windows.
12049 (window_tree, Fwindow_tree): Remove. Supply functionality in
12050 window.el.
12051 (compare_window_configurations): Simplify code.
12052
b6e3633c
AS
120532011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12054
1ab0dee5
AS
12055 * image.c (imagemagick_load_image): Fix type mismatch.
12056 (Fimagemagick_types): Likewise.
12057
b6e3633c
AS
12058 * window.h (replace_buffer_in_windows): Declare.
12059
9397e56f
MR
120602011-06-11 Martin Rudalics <rudalics@gmx.at>
12061
12062 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12063 Qclone_number. Remove external declaration of Qdelete_window.
12064 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12065 code.
640c8776
SM
12066 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12067 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12068 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12069 buffer list implementation.
12070 (other_buffer_safely): New function.
12071 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12072 calls to replace_buffer_in_windows and
12073 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12074 if allowed.
12075 (record_buffer): Inhibit quitting and rewrite using quittable
12076 functions. Run Qbuffer_list_update_hook if allowed.
12077 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12078 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12079 Move switch-to-buffer to window.el.
9397e56f
MR
12080 (bury-buffer): Move to window.el.
12081 (Vbuffer_list_update_hook): New variable.
12082
12083 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12084 section.
12085
12086 * window.h (resize_frame_windows): Move up in code.
12087 (Fwindow_frame): Remove EXFUN.
12088 (replace_buffer_in_all_windows): Remove prototype.
12089 (replace_buffer_in_windows_safely): Add prototype.
12090
12091 * window.c: Declare Qdelete_window static again. Move down
12092 declaration of select_count.
12093 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12094 (Fother_window): Move to window.el.
12095 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12096 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12097 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12098 window.el.
12099 (replace_buffer_in_windows): Implement by calling
12100 Qreplace_buffer_in_windows.
12101 (replace_buffer_in_all_windows): Remove with some functionality
12102 moved into replace_buffer_in_windows_safely.
12103 (replace_buffer_in_windows_safely): New function.
12104 (select_window_norecord, select_frame_norecord): Move in front
12105 of run_window_configuration_change_hook. Remove now obsolete
12106 declarations.
640c8776
SM
12107 (Fset_window_buffer): Rewrite doc-string.
12108 Call Qrecord_window_buffer.
9397e56f
MR
12109 (keys_of_window): Move binding for other-window to window.el.
12110
b50691aa
CY
121112011-06-11 Chong Yidong <cyd@stupidchicken.com>
12112
12113 * dispextern.h (struct image): Replace data member, whose int_val
12114 and ptr_val fields were not used by anything, with a single
12115 lisp_val object.
12116
12117 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
12118 (gif_clear_image, gif_load, imagemagick_load_image)
12119 (gs_clear_image, gs_load): Callers changed.
12120
3f754b86
PE
121212011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12122
cca69397
PE
12123 * buffer.h: Include <time.h>, for time_t.
12124 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12125
109e28d0
PE
12126 Fix minor problems found by static checking.
12127
60737f02
PE
12128 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12129
4b66faf3
PE
12130 Make identifiers static if they are not used in other modules.
12131 * data.c (Qcompiled_function, Qframe, Qvector):
12132 * image.c (QimageMagick, Qsvg):
12133 * minibuf.c (Qmetadata):
12134 * window.c (resize_window_check, resize_root_window): Now static.
12135 * window.h (resize_window_check, resize_root_window): Remove decls.
12136
109e28d0
PE
12137 * window.c (window_deletion_count, delete_deletable_window):
12138 Remove; unused.
46a4ce9e
PE
12139 (window_body_lines): Now static.
12140 (Fdelete_other_windows_internal): Mark vars as initialized.
12141 Make sure 'resize_failed' is initialized.
12142 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12143 (resize_window_apply): Remove unused local.
12144 * window.h (delete_deletable_window): Remove decl.
12145
109e28d0 12146 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12147 (imagemagick_load_image): Fix pointer signedness problem by changing
12148 last arg from unsigned char * to char *. All uses changed.
12149 Also, fix a local for similar reasons.
12150 Remove unused locals. Remove locals to avoid shadowing.
12151 (fn_rsvg_handle_free): Remove; unused.
12152 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12153 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12154
3f754b86
PE
12155 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12156
2547adb1
CY
121572011-06-10 Chong Yidong <cyd@stupidchicken.com>
12158
12159 * image.c (gif_load): Fix omitted cast error introduced by
12160 2011-06-06 change.
12161
2c8e37d4
MR
121622011-06-10 Martin Rudalics <rudalics@gmx.at>
12163
12164 * window.h (resize_proportionally, orig_total_lines)
12165 (orig_top_line): Remove from window structure.
12166 (set_window_height, set_window_width, change_window_heights)
12167 (Fdelete_window): Remove prototypes.
12168 (resize_frame_windows): Remove duplicate declaration.
12169
440a42e3
EZ
121702011-06-10 Eli Zaretskii <eliz@gnu.org>
12171
12172 * window.h (resize_frame_windows, resize_window_check)
12173 (delete_deletable_window, resize_root_window)
12174 (resize_frame_windows): Declare prototypes.
12175
12176 * window.c (resize_window_apply): Make definition be "static" to
12177 match the prototype.
12178
562dd5e9
MR
121792011-06-10 Martin Rudalics <rudalics@gmx.at>
12180
12181 * window.c: Remove declarations of Qwindow_size_fixed,
12182 window_min_size_1, window_min_size_2, window_min_size,
12183 size_window, window_fixed_size_p, enlarge_window, delete_window.
12184 Remove static from declaration of Qdelete_window, it's
12185 temporarily needed by Fbury_buffer.
12186 (replace_window): Don't assign orig_top_line and
12187 orig_total_lines.
12188 (Fdelete_window, delete_window): Remove. Window deletion is
12189 handled by window.el.
640c8776
SM
12190 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12191 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12192 (Fdelete_other_windows): Remove. Deleting other windows is
12193 handled by window.el.
12194 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12195 handled in window.el.
12196 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12197 Window minimum sizes are handled in window.el.
12198 (shrink_windows, size_window, set_window_height)
12199 (set_window_width, change_window_heights, window_height)
12200 (window_width, CURBEG, CURSIZE, enlarge_window)
12201 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12202 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12203 handled in window.el.
12204 (make_dummy_parent): Rename to make_parent_window and give it a
12205 second argument horflag.
12206 (make_window): Don't set resize_proportionally any more.
12207 (Fsplit_window): Remove. Windows are split in window.el.
12208 (save_restore_action, save_restore_orig_size)
12209 (shrink_window_lowest_first, save_restore_orig_size): Remove.
12210 Resize mini windows in window.el.
12211 (grow_mini_window, shrink_mini_window): Implement by calling
12212 Qresize_root_window_vertically, resize_window_check and
12213 resize_window_apply.
640c8776
SM
12214 (saved_window, Fset_window_configuration, save_window_save):
12215 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
12216 resize_proportionally.
12217 (window_min_height, window_min_width): Move to window.el.
12218 (keys_of_window): Move bindings for delete-other-windows,
12219 split-window, delete-window and enlarge-window to window.el.
12220
12221 * buffer.c: Temporarily extern Qdelete_window.
12222 (Fbury_buffer): Temporarily call Qdelete_window instead of
12223 Fdelete_window (Fbury_buffer will move to window.el soon).
12224
12225 * frame.c (set_menu_bar_lines_1): Remove code handling
12226 orig_top_line and orig_total_lines.
12227
12228 * dispnew.c (adjust_frame_glyphs_initially): Don't use
12229 set_window_height but set heights directly.
12230 (change_frame_size_1): Use resize_frame_windows.
12231
12232 * xdisp.c (init_xdisp): Don't use set_window_height but set
12233 heights directly.
12234
640c8776
SM
12235 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
12236 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
12237 run_window_configuration_change_hook.
12238
12239 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
12240 instead of change_window_heights and run
12241 run_window_configuration_change_hook.
12242
1a13852e
MR
122432011-06-09 Martin Rudalics <rudalics@gmx.at>
12244
12245 * window.c (replace_window): Rename second argument REPLACEMENT to
12246 NEW. New third argument SETFLAG. Rewrite.
12247 (delete_window, make_dummy_parent): Call replace_window with
12248 third argument 1.
12249 (window_list_1): Move down in code.
12250 (run_window_configuration_change_hook): Move set_buffer part
12251 before select_frame_norecord part in order to unwind correctly.
12252 Rename count1 to count.
12253 (recombine_windows, delete_deletable_window, resize_root_window)
12254 (Fdelete_other_windows_internal)
12255 (Frun_window_configuration_change_hook, make_parent_window)
12256 (resize_window_check, resize_window_apply, Fresize_window_apply)
12257 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
12258 (Fdelete_window_internal, Fresize_mini_window_internal):
12259 New functions.
1a13852e
MR
12260 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
12261
f3d1777e
MR
122622011-06-08 Martin Rudalics <rudalics@gmx.at>
12263
496e208e
MR
12264 * window.h (window): Add some new members to window structure -
12265 normal_lines, normal_cols, new_total, new_normal, clone_number,
12266 splits, nest, prev_buffers, next_buffers.
12267 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 12268 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 12269
f3d1777e
MR
12270 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
12271 Remove.
496e208e
MR
12272 (make_dummy_parent): Set new members of windows structure.
12273 (make_window): Move down in code. Handle new members of window
12274 structure.
12275 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
12276 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
12277 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
12278 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
12279 (Fset_window_next_buffers, Fset_window_clone_number):
12280 New functions.
496e208e
MR
12281 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
12282 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
12283 Doc-string fixes.
12284 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
12285 Argument WINDOW can be now internal window too.
12286 (Fwindow_use_time): Move up in code.
12287 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
12288 Rewrite doc-string.
12289 (Fset_window_configuration, saved_window)
12290 (Fcurrent_window_configuration, save_window_save): Handle new
12291 members of window structure.
b9e809c2
MR
12292 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
12293 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
12294 (syms_of_window): New Lisp objects Qrecord_window_buffer,
12295 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
12296 Qget_mru_window, Qresize_root_window,
12297 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
12298 Qauto_buffer_name; staticpro them.
f3d1777e 12299
abde8f8c
MR
123002011-06-07 Martin Rudalics <rudalics@gmx.at>
12301
12302 * window.c (Fwindow_total_size, Fwindow_left_column)
12303 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
12304 (Fwindow_list_1): New functions.
12305 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
12306 (Fwindow_width, Fscroll_left, Fscroll_right):
12307 Use window_body_cols instead of window_box_text_cols.
12308 (delete_window, Fset_window_configuration):
12309 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
12310 (delete_all_subwindows): Take a window as argument and not a
12311 structure. Rewrite.
190b47e6
MR
12312 (window_loop): Remove handling of GET_LRU_WINDOW and
12313 GET_LARGEST_WINDOW.
12314 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
12315
12316 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
12317 window_box_text_cols. delete_all_subwindows now takes a
12318 Lisp_Object as argument.
abde8f8c 12319
640c8776
SM
12320 * indent.c (compute_motion, Fcompute_motion):
12321 Use window_body_cols instead of window_box_text_cols.
abde8f8c 12322
fa8a67e6
MR
12323 * frame.c (delete_frame): Call delete_all_subwindows with root
12324 window as argument.
12325
a54e3482
DC
123262011-06-07 Daniel Colascione <dan.colascione@gmail.com>
12327
12328 * fns.c (Fputhash): Document return value.
12329
60002bf5
CY
123302011-06-06 Chong Yidong <cyd@stupidchicken.com>
12331
12332 * image.c (gif_load): Implement gif89a spec "no disposal" method.
12333
0c671da6 123342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 12335
b862a52a 12336 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 12337
be44ca6c
PE
12338 Check for overflow when converting integer to cons and back.
12339 * charset.c (Fdefine_charset_internal, Fdecode_char):
12340 Use cons_to_unsigned to catch overflow.
12341 (Fencode_char): Use INTEGER_TO_CONS.
12342 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
12343 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
12344 * data.c (long_to_cons, cons_to_long): Remove.
12345 (cons_to_unsigned, cons_to_signed): New functions.
12346 These signal an error for invalid or out-of-range values.
12347 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
12348 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
12349 * font.c (Ffont_variation_glyphs):
12350 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
12351 * lisp.h: Include <intprops.h>.
12352 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
12353 (cons_to_signed, cons_to_unsigned): New decls.
12354 (long_to_cons, cons_to_long): Remove decls.
12355 * undo.c (record_first_change): Use INTEGER_TO_CONS.
12356 (Fprimitive_undo): Use CONS_TO_INTEGER.
12357 * xfns.c (Fx_window_property): Likewise.
12358 * xselect.c: Include <limits.h>.
12359 (x_own_selection, selection_data_to_lisp_data):
12360 Use INTEGER_TO_CONS.
12361 (x_handle_selection_request, x_handle_selection_clear)
12362 (x_get_foreign_selection, Fx_disown_selection_internal)
12363 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
12364 (lisp_data_to_selection_data): Use cons_to_unsigned.
12365 (x_fill_property_data): Use cons_to_signed.
12366 Report values out of range.
12367
d1f3d2af
PE
12368 Check for buffer and string overflow more precisely.
12369 * buffer.h (BUF_BYTES_MAX): New macro.
12370 * lisp.h (STRING_BYTES_MAX): New macro.
12371 * alloc.c (Fmake_string):
12372 * character.c (string_escape_byte8):
12373 * coding.c (coding_alloc_by_realloc):
12374 * doprnt.c (doprnt):
12375 * editfns.c (Fformat):
12376 * eval.c (verror):
12377 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
12378 since they may not be the same number.
12379 * editfns.c (Finsert_char):
12380 * fileio.c (Finsert_file_contents):
12381 Likewise for BUF_BYTES_MAX.
12382
dd52fcea
PE
12383 * image.c: Use ptrdiff_t, not int, for sizes.
12384 (slurp_file): Switch from int to ptrdiff_t.
12385 All uses changed.
12386 (slurp_file): Check that file size fits in both size_t (for
12387 malloc) and ptrdiff_t (for sanity and safety).
12388
7f9bbdbb
PE
12389 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
12390 if b->modtime has its maximal value.
12391
dfe18f82
PE
12392 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
12393
84acfcf0
PE
12394 Don't assume time_t can fit into int.
12395 * buffer.h (struct buffer.modtime): Now time_t, not int.
12396 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
12397 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12398
ccd9a01a
PE
12399 Minor fixes for signed vs unsigned integers.
12400 * character.h (MAYBE_UNIFY_CHAR):
12401 * charset.c (maybe_unify_char):
12402 * keyboard.c (read_char, reorder_modifiers):
12403 XINT -> XFASTINT, since the integer must be nonnegative.
12404 * ftfont.c (ftfont_spec_pattern):
12405 * keymap.c (access_keymap, silly_event_symbol_error):
12406 XUINT -> XFASTINT, since the integer must be nonnegative.
12407 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12408 since it makes no difference and we prefer signed.
12409 * keyboard.c (record_char): Use XUINT when all the neighbors do.
12410 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
12411 nonnegative.
12412
d6d100dd
SM
124132011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
12414
12415 * window.h (Fwindow_frame): Declare.
12416
2b6148e4
PE
124172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12418
12419 * alloc.c: Simplify handling of large-request failures (Bug#8800).
12420 (SPARE_MEMORY): Always define.
12421 (LARGE_REQUEST): Remove.
12422 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
12423
f230ecc9
MR
124242011-06-06 Martin Rudalics <rudalics@gmx.at>
12425
727e958e
MR
12426 * lisp.h: Move EXFUNS for Fframe_root_window,
12427 Fframe_first_window and Fset_frame_selected_window to window.h.
12428
12429 * window.h: Move EXFUNS for Fframe_root_window,
12430 Fframe_first_window and Fset_frame_selected_window here from
12431 lisp.h.
12432
12433 * frame.c (Fwindow_frame, Fframe_first_window)
12434 (Fframe_root_window, Fframe_selected_window)
12435 (Fset_frame_selected_window): Move to window.c.
12436 (Factive_minibuffer_window): Move to minibuf.c.
12437 (Fother_visible_frames_p): New function.
12438
12439 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
12440
f230ecc9
MR
12441 * window.c (decode_window, decode_any_window): Move up in code.
12442 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
12443 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
12444 (Fwindow_buffer): Move up and rewrite doc-string.
12445 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
12446 (Fwindow_prev): New functions.
727e958e
MR
12447 (Fwindow_frame): Move here from frame.c. Accept any window as
12448 argument.
12449 (Fframe_root_window, Fframe_first_window)
12450 (Fframe_selected_window): Move here from frame.c. Accept frame
12451 or arbitrary window as argument. Update doc-strings.
12452 (Fminibuffer_window): Move up in code.
12453 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
12454 (Fset_frame_selected_window): Move here from frame.c.
12455 Marginal rewrite.
727e958e
MR
12456 (Fselected_window, select_window, Fselect_window): Move up in
12457 code. Minor doc-string fixes.
f230ecc9 12458
4d09bcf6
PE
124592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12460
12461 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
12462 Do not assume that spare memory exists; that assumption is valid
12463 only if SYSTEM_MALLOC.
12464 (LARGE_REQUEST): New macro, so that the issue of large requests
12465 is separated from the issue of spare memory.
12466
810928a2
AS
124672011-06-05 Andreas Schwab <schwab@linux-m68k.org>
12468
172418ad
AS
12469 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
12470 format. (Bug#8806)
12471
43f862f7
AS
12472 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
12473
810928a2
AS
12474 * xfns.c (x_set_scroll_bar_default_width): Move declarations
12475 before statements.
12476
a059fe24
JD
124772011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12478
12479 * gtkutil.c (xg_get_default_scrollbar_width): New function.
12480
12481 * gtkutil.h: Declare xg_get_default_scrollbar_width.
12482
12483 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
12484 min width by calling x_set_scroll_bar_default_width (Bug#8505).
12485
989bf368
JB
124862011-06-05 Juanma Barranquero <lekktu@gmail.com>
12487
12488 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12489
4b80f674
CY
124902011-06-04 Chong Yidong <cyd@stupidchicken.com>
12491
12492 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12493 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12494 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12495 New error handlers.
4b80f674
CY
12496 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12497 Obey Vx_select_enable_clipboard_manager. Catch errors in
12498 x_clipboard_manager_save (Bug#8779).
12499 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12500 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12501
99a33b77 125022011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12503
12504 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12505
99a33b77 125062011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12507
12508 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12509 in the current matrix if keep_current_p is non-zero.
12510
8264569d
EZ
125112011-06-04 Eli Zaretskii <eliz@gnu.org>
12512
12513 * bidi.c (bidi_level_of_next_char): Fix last change.
12514
57f97249
EZ
125152011-06-03 Eli Zaretskii <eliz@gnu.org>
12516
fec2107c 12517 Support bidi reordering of text covered by display properties.
57f97249 12518
fec2107c
EZ
12519 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12520 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12521 (bidi_cache_search, bidi_cache_iterator_state)
12522 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12523 (bidi_level_of_next_char, bidi_move_to_visually_next):
12524 Support character positions inside a run of characters covered by a
fec2107c
EZ
12525 display string.
12526 (bidi_paragraph_init, bidi_resolve_explicit_1)
12527 (bidi_level_of_next_char): Call bidi_fetch_char and
12528 bidi_fetch_char_advance instead of FETCH_CHAR and
12529 FETCH_CHAR_ADVANCE.
12530 (bidi_init_it): Initialize new members.
12531 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12532 definitions.
12533 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12534 instead of using explicit *_CHAR codes.
d6d100dd
SM
12535 (bidi_resolve_explicit, bidi_resolve_weak):
12536 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12537 bidirectional text is supported only in multibyte buffers.
12538 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12539 it to initialize the frame_window_p member of struct bidi_it.
12540 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12541 (bidi_resolve_explicit, bidi_resolve_weak)
12542 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12543 bidi_it->nchars is non-positive.
12544 (bidi_level_of_next_char): Don't try to lookup the cache for the
12545 next/previous character if nothing is cached there yet, or if we
12546 were just reseat()'ed to a new position.
c40e2fb2 12547
0e14fe90
EZ
12548 * xdisp.c (set_cursor_from_row): Set start and stop points
12549 according to the row's direction when priming the loop that looks
12550 for the glyph on which to display cursor.
12551 (single_display_spec_intangible_p): Function deleted.
12552 (display_prop_intangible_p): Reimplement to call
12553 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12554 Accept 3 additional arguments needed by handle_display_spec.
12555 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12556 values: lists, `(when COND...)' forms, etc.
12557 (single_display_spec_string_p): Support property values that are
12558 lists with the argument STRING its top-level element.
12559 (display_prop_string_p): Fix the condition for processing a
12560 property that is a list to be consistent with handle_display_spec.
fec2107c 12561 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12562 last portion of handle_display_prop.
12563 (compute_display_string_pos): Accept additional argument
12564 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12565 value of a `display' property is a "replacing spec".
12566 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12567 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12568 the display property, but just return a value indicating whether
12569 the display property will replace the characters it covers.
12570 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12571 frame_window_p members of struct bidi_it.
d6d100dd
SM
12572 (compute_display_string_pos, compute_display_string_end):
12573 New functions.
fec2107c
EZ
12574 (push_it): Accept second argument POSITION, where pop_it should
12575 jump to continue iteration.
12576 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12577
fec2107c
EZ
12578 * keyboard.c (adjust_point_for_property): Adjust the call to
12579 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12580
12581 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12582 (bidi_init_it): Update prototypes.
12583 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12584 (compute_display_string_pos, compute_display_string_end):
12585 Declare prototypes.
fec2107c
EZ
12586 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12587 EMACS_INT.
fc6f18ce 12588
40087514 125892011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12590
57f53182
PE
12591 Malloc failure behavior now depends on size of allocation.
12592 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12593 * lisp.h: Change signatures accordingly.
12594 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12595 All callers changed. (Bug#8762)
12596
12597 * gnutls.c: Use Emacs's memory allocators.
12598 Without this change, the gnutls library would invoke malloc etc.
12599 directly, which causes problems on non-SYNC_INPUT hosts, and which
12600 runs afoul of improving memory_full behavior. (Bug#8761)
12601 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12602 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12603 xfree instead of the default malloc, realloc, free.
12604 (Fgnutls_boot): No need to check for memory allocation failure,
12605 since xmalloc does that for us.
12606
ac32cd99 12607 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12608 * category.c (hash_get_category_set):
12609 * ccl.c (ccl_driver):
12610 * charset.c (Fdefine_charset_internal):
12611 * charset.h (struct charset.hash_index):
12612 * composite.c (get_composition_id, gstring_lookup_cache)
12613 (composition_gstring_put_cache):
12614 * composite.h (struct composition.hash_index):
12615 * dispextern.h (struct image.hash):
12616 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12617 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12618 (hashfn_equal, hashfn_user_defined, make_hash_table)
12619 (maybe_resize_hash_table, hash_lookup, hash_put)
12620 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12621 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12622 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12623 * image.c (make_image, search_image_cache, lookup_image)
12624 (xpm_put_color_table_h):
12625 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12626 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12627 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12628 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12629 * alloc.c (allocate_vectorlike):
12630 Check for overflow in vector size calculations.
12631 * ccl.c (ccl_driver):
12632 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12633 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12634 need to be updated by these changes.
40087514
PE
12635 * fns.c (make_hash_table, maybe_resize_hash_table):
12636 Check for integer overflow with large hash tables.
0de4bb68
PE
12637 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12638 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12639 (SXHASH_REDUCE): New macro.
12640 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12641 Use it instead of discarding useful hash info with large hash values.
12642 (sxhash_float): New function.
12643 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12644 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12645 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12646 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12647 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12648 Adjust signatures to match updated version of code.
12649 (consing_since_gc): Now EMACS_INT, since a single hash table can
12650 use more than INT_MAX bytes.
12651
698d32e2
DN
126522011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12653
12654 Make it possible to build with GCC-4.6+ -O2 -flto.
12655
12656 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12657
fd6fa53f
SM
126582011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12659
12660 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12661 Call minibuffer-inactive-mode.
12662
864db017
JB
126632011-05-31 Juanma Barranquero <lekktu@gmail.com>
12664
12665 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12666 Update dependencies.
12667
2ad0baf4
DN
126682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12669
12670 * data.c (init_data): Remove code for UTS, this system is not
12671 supported anymore.
12672
4fcc2638
DN
126732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12674
12675 Don't force ./temacs to start in terminal mode.
12676
12677 * frame.c (make_initial_frame): Initialize faces in all cases, not
12678 only when CANNOT_DUMP is defined.
12679 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12680
c56e0fd5
DN
126812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12682
12683 * dispnew.c (add_window_display_history): Use const for the string
12684 pointer. Remove declaration, not needed.
12685
333d54da 126862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12687
55d4c1b2 12688 Use 'inline', not 'INLINE'.
333d54da 12689 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12690 * alloc.c, fontset.c (INLINE): Remove.
12691 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12692 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12693 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12694 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12695 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12696
738db178
DN
126972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12698
12699 Make it possible to run ./temacs.
12700
12701 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12702 syms_of_callproc does the same thing. Remove test for
12703 "initialized", do it in the caller.
12704 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12705
620c53a6
SM
127062011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12707
12708 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12709 (read_minibuf): Use get_minibuffer.
12710 (syms_of_minibuf): Use DEFSYM.
12711 (Qmetadata): New var.
12712 * data.c (Qbuffer): Don't make it static.
12713 (syms_of_data): Use DEFSYM.
12714
e003a292
PE
127152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12716
12717 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12718 (CCL_CODE_MIN): New macro.
12719
ed008a6d
PE
127202011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12721
3687c2ef
PE
12722 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12723
ed008a6d
PE
12724 * eval.c (Qdebug): Now static.
12725 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12726 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12727 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12728
d66c4c7c
CY
127292011-05-29 Chong Yidong <cyd@stupidchicken.com>
12730
12731 * image.c: Various fixes to ImageMagick code comments.
12732 (Fimagemagick_types): Doc fix.
12733
5fbc2025
PE
127342011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12735
0196f88a
PE
12736 Minor fixes prompted by GCC 4.6.0 warnings.
12737
12738 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12739
5fbc2025
PE
12740 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12741 (x_clipboard_manager_save_all): Move extern decl to ...
12742 * xterm.h: ... here, so that it can be checked for consistency.
12743
1dd3c2d9
CY
127442011-05-29 Chong Yidong <cyd@stupidchicken.com>
12745
12746 * xselect.c (x_clipboard_manager_save_frame)
12747 (x_clipboard_manager_save_all): New functions.
12748 (Fx_clipboard_manager_save): Lisp function deleted.
12749
12750 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12751 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12752
12753 * xterm.h: Update prototype.
12754
5ba6571d
WX
127552011-05-28 William Xu <william.xwl@gmail.com>
12756
12757 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12758 exiting (Bug#8239).
12759
3eaff834
JM
127602011-05-28 Jim Meyering <meyering@redhat.com>
12761
e1900994 12762 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12763 * fns.c (to_uchar): Define.
12764 (crypto_hash_function): Use it to convert some newly-signed
12765 variables to unsigned, to avoid sign-extension bugs. For example,
12766 without this change, (md5 "truc") would evaluate to
12767 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12768 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12769 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12770
0f6990a7
PE
127712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12772
12773 Integer overflow fixes.
c8a9ca5a 12774
08686060
PE
12775 * dbusbind.c: Serial number integer overflow fixes.
12776 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12777 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12778 to hold a serial number that is too large for a fixnum.
12779 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12780 Check for serial numbers out of range. Decode any serial number
59568bf0 12781 that was so large that it became a float. (Bug#8722)
08686060 12782
2d1fc3c7
PE
12783 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12784 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12785 Use XFASTINT rather than XUINT when numbers are nonnegative.
12786 (xd_append_arg, Fdbus_method_return_internal):
12787 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12788 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12789 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12790 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12791 (Bug#8722)
2d1fc3c7 12792
c8a9ca5a
PE
12793 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12794
519e1d69
PE
12795 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12796
6df6ae42 12797 ccl: Add integer overflow checks.
30569699
PE
12798 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12799 (IN_INT_RANGE): New macros.
12800 (ccl_driver): Use them to check for integer overflow when
12801 decoding a CCL program. Many of the new checks are whether XINT (x)
12802 fits in int; it doesn't always, on 64-bit hosts. The new version
12803 doesn't catch all possible integer overflows, but it's an
847044ea 12804 improvement. (Bug#8719)
30569699 12805
c11285dc
PE
12806 * alloc.c (make_event_array): Use XINT, not XUINT.
12807 There's no need for unsigned here.
12808
fdccd48e
PE
12809 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12810 This follows up to the 2011-05-06 change that substituted uintptr_t
12811 for EMACS_INT. This case wasn't caught back then.
12812
37910ab2
PE
12813 Rework Fformat to avoid integer overflow issues.
12814 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12815 now (part of C89). Include <verify.h>.
12816 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12817 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12818 (Fformat): Avoid the prepass trying to compute sizes; it was only
12819 approximate and thus did not catch overflow reliably. Instead, walk
12820 through the format just once, formatting and computing sizes as we go,
12821 checking for integer overflow at every step, and allocating a larger
12822 buffer as needed. Keep track separately whether the format is
12823 multibyte. Keep only the most-recently calculated precision, rather
12824 than them all. Record whether each argument has been converted to
12825 string. Use EMACS_INT, not int, for byte and char and arg counts.
12826 Support field widths and precisions larger than INT_MAX. Avoid
12827 sprintf's undefined behavior with conversion specifications such as %#d
12828 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12829 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12830 formatting out-of-range floating point numbers with int
9173deec 12831 formats. (Bug#8668)
37910ab2 12832
2e6578fb
PE
12833 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12834
0ae6bdee
PE
12835 * data.c: Avoid integer truncation in expressions involving floats.
12836 * data.c: Include <intprops.h>.
12837 (arith_driver): When there's an integer overflow in an expression
12838 involving floating point, convert the integers to floating point
12839 so that the resulting value does not suffer from catastrophic
12840 integer truncation. For example, on a 64-bit host (* 4
12841 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12842 Do not rely on undefined behavior after integer overflow.
12843
de883a70
PE
12844 merge count_size_as_multibyte, parse_str_to_multibyte
12845 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12846 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12847 Check for integer overflow.
12848 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12849 since it's now a duplicate of the other. This is more of
12850 a character than a buffer op, so better that it's in character.c.
12851 * fns.c, print.c: Adjust to above changes.
12852
2ff916cb
PE
128532011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12854
12855 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12856
f1b54466
PE
128572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12858
fb1ac845
PE
12859 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12860 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12861 (x_clipboard_manager_save): Now static.
12862 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12863
f1b54466
PE
12864 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12865 (crypto_hash_function): Now static.
12866 Fix pointer signedness problems. Avoid unnecessary initializations.
12867
a9f737ee
CY
128682011-05-27 Chong Yidong <cyd@stupidchicken.com>
12869
12870 * termhooks.h (Vselection_alist): Make it terminal-local.
12871
12872 * terminal.c (create_terminal): Initialize it.
12873
12874 * xselect.c: Support for clipboard managers.
12875 (Vselection_alist): Move to termhooks.h as terminal-local var.
12876 (LOCAL_SELECTION): New macro.
12877 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12878 (symbol_to_x_atom): Remove gratuitous arg.
12879 (x_handle_selection_request, lisp_data_to_selection_data)
12880 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12881 (x_own_selection, x_get_local_selection, x_convert_selection):
12882 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12883 (some_frame_on_display): Delete unused function.
12884 (Fx_own_selection_internal, Fx_get_selection_internal)
12885 (Fx_disown_selection_internal, Fx_selection_owner_p)
12886 (Fx_selection_exists_p): New optional frame arg.
12887 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12888 (x_handle_selection_clear): Don't treat other terminals with the
12889 same keyboard specially. Use the terminal-local Vselection_alist.
12890 (x_clear_frame_selections): Use Frun_hook_with_args.
12891
12892 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12893
12894 * xterm.h: Add support for those atoms.
12895
e067f0c1
CY
128962011-05-26 Chong Yidong <cyd@stupidchicken.com>
12897
12898 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12899 (converted_selections, conversion_fail_tag): New global variables.
12900 (x_selection_request_lisp_error): Free the above.
12901 (x_get_local_selection): Remove unnecessary code.
12902 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12903 of converted selections stored in converted_selections.
12904 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12905 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12906 (x_convert_selection): New function.
12907 (x_handle_selection_event): Simplify.
12908 (x_get_foreign_selection): Don't ignore incoming requests while
12909 waiting for an answer; this will fail when we implement
12910 SAVE_TARGETS, and seems unnecessary anyway.
12911 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12912 (Vx_sent_selection_functions): Doc fix.
12913
0f4aebc0
LL
129142011-05-26 Leo Liu <sdl.web@gmail.com>
12915
12916 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12917
e61124cd
YM
129182011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12919
12920 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12921
12922 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12923 for fringe update if it has periodic bitmap.
ac389d0c 12924 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12925 and fringe_bitmap_periodic_p.
12926
12927 * fringe.c (get_fringe_bitmap_data): New function.
12928 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12929 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12930 row. Mark glyph row for fringe update if periodicity changed.
12931
12932 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12933 for fringe update unless it has periodic bitmap.
12934
f16d9837
KH
129352011-05-25 Kenichi Handa <handa@m17n.org>
12936
12937 * xdisp.c (get_next_display_element): Set correct it->face_id for
12938 a static composition.
12939
e1b90ef6
LL
129402011-05-24 Leo Liu <sdl.web@gmail.com>
12941
12942 * deps.mk (fns.o):
12943 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12944
12945 * fns.c (crypto_hash_function, Fsha1): New function.
12946 (Fmd5): Use crypto_hash_function.
12947 (syms_of_fns): Add Ssha1.
12948
7400048f
PE
129492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12950
12951 * gnutls.c: Remove unused macros.
12952 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12953 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12954 Remove macros that are defined and never used.
12955 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12956
abb71cf4
CY
129572011-05-22 Chong Yidong <cyd@stupidchicken.com>
12958
12959 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12960 (Fx_get_selection_internal): Minor cleanup.
12961 (Fx_own_selection_internal): Rename arguments for consistency with
12962 select.el.
12963
6307db39
PE
129642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12965
12966 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12967
f3d4e0a4
CY
129682011-05-22 Chong Yidong <cyd@stupidchicken.com>
12969
12970 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12971
4d8ade89
YM
129722011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12973
12974 * dispnew.c (scrolling_window): Don't exclude the case that the
12975 last enabled row in the desired matrix touches the bottom boundary.
12976
32078c8d
GM
129772011-05-21 Glenn Morris <rgm@gnu.org>
12978
12979 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12980 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12981 and add some more files.
32078c8d 12982
7285dc67
EZ
129832011-05-20 Eli Zaretskii <eliz@gnu.org>
12984
12985 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12986 report_file_error introduced by the change from 2011-05-07.
12987
89d1bd22
PE
129882011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12989
12990 * systime.h (Time): Define only if emacs is defined.
12991 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12992 where the include path doesn't have X11/X.h by default. See
12993 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12994
cd394be1 129952011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12996
12997 * composite.c (find_automatic_composition): Fix previous change.
12998
b9704ad9
GM
129992011-05-20 Glenn Morris <rgm@gnu.org>
13000
13001 * lisp.mk: New file, split from Makefile.in.
13002 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13003 (shortlisp): Remove.
13004 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13005
4a720484
GM
130062011-05-19 Glenn Morris <rgm@gnu.org>
13007
13008 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13009 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13010 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13011 (lisp): Set the order to that of loadup.el.
13012 (shortlisp): Make it a copy of $lisp.
13013 (SOME_MACHINE_LISP): Remove.
13014 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13015 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13016
a28d4396
KH
130172011-05-18 Kenichi Handa <handa@m17n.org>
13018
13019 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13020 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13021 (find_automatic_composition): Mostly rewrite for efficiency.
13022
a2b1fa8e
JB
130232011-05-18 Juanma Barranquero <lekktu@gmail.com>
13024
13025 * makefile.w32-in: Update dependencies.
13026
8e1f5610
CS
130272011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13028
13029 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13030 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13031
7025ee00 130322011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13033
cdfa6eab
PE
13034 Fix some integer overflow issues, such as string length overflow.
13035
06d6db33
PE
13036 * insdel.c (count_size_as_multibyte): Check for string overflow.
13037
2b4560a8
PE
13038 * character.c (lisp_string_width): Check for string overflow.
13039 Use EMACS_INT, not int, for string indexes and lengths; in
13040 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13041 the resulting string length overflows an EMACS_INT; instead,
13042 report a string overflow if no precision given. When checking for
13043 precision exhaustion, use a check that cannot possibly have
13044 integer overflow. (Bug#8675)
13045 * character.h (lisp_string_width): Adjust to new signature.
13046
cb93f9be
PE
13047 * alloc.c (string_overflow): New function.
13048 (Fmake_string): Use it. This doesn't change behavior, but saves
13049 a few bytes and will simplify future changes.
13050 * character.c (string_escape_byte8): Likewise.
13051 * lisp.h (string_overflow): New decl.
13052
1a1f3366
PE
13053 Fixups, following up to the user-interface timestamp change.
13054 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13055 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13056 * msdos.c (mouse_get_pos): Likewise.
13057 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13058 * w32gui.h (Time): Define by including "systime.h" rather than by
13059 declaring it ourselves. (Bug#8664)
13060
d4e3e4d3
PE
13061 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13062 * image.c (clear_image_cache): Likewise.
13063
f6a24d19
PE
13064 * term.c (term_mouse_position): Don't assume time_t wraparound.
13065
08dc5ae6
PE
13066 Be more systematic about user-interface timestamps.
13067 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13068 and sometimes 'EMACS_UINT', to represent these timestamps.
13069 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13070 This makes the code easier to follow, and makes it easier to catch
13071 integer overflow bugs such as Bug#8664.
13072 * frame.c (Fmouse_position, Fmouse_pixel_position):
13073 Use Time, not unsigned long, for user-interface timestamps.
13074 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13075 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13076 * keyboard.h (last_event_timestamp): Likewise.
13077 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13078 * menu.h (xmenu_show): Likewise.
13079 * term.c (term_mouse_position): Likewise.
13080 * termhooks.h (struct input_event.timestamp): Likewise.
13081 (struct terminal.mouse_position_hook): Likewise.
13082 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13083 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13084 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13085 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13086 what it was before.
13087 * menu.h, termhooks.h: Include "systime.h", for Time.
13088
8e55734a
PE
13089 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13090 Don't assume that the difference between two unsigned long values
13091 can fit into an integer. At this point, we know button_down_time
13092 <= event->timestamp, so the difference must be nonnegative, so
13093 there's no need to cast the result if double-click-time is
13094 nonnegative, as it should be; check that it's nonnegative, just in
13095 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13096 apart (about 25 days). (Bug#8664)
8e55734a 13097
841f1b75 13098 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13099 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13100
3e26f69c
PE
13101 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13102 that always fit in int. Use a sentinel instead of a counter, to
13103 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13104 * frame.h (struct frame): Use int for menu_bar_items_used
13105 instead of EMACS_INT, since it always fits in int.
3e26f69c 13106
5cc152c0
PE
13107 * menu.c (grow_menu_items): Check for int overflow.
13108
d89eb65e
PE
13109 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13110
5235bd3e
PE
13111 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13112 Before, the code was not consistent. These values cannot exceed
13113 2**31 - 1 so there's no need to make them unsigned.
13114 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
13115 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
13116 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13117 as modifiers.
13118 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13119
bc827e23
PE
13120 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13121 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13122 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13123 presumably because the widths might not match.
13124
78eb494e
PE
13125 * window.c (size_window): Avoid needless test at loop start.
13126
04f2d78b
CB
131272011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13128
13129 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13130
d2fc7e3d 131312011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13132
13133 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13134
d2fc7e3d 131352011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13136
13137 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13138 `width' to `bar_area_x' and `bar_area_width', respectively.
13139 (x_scroll_run): Take account of fringe background extension.
13140
04f2d78b
CB
13141 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13142 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13143 `bar_area_width', respectively.
13144 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13145 background extension.
13146
79b70037
GM
131472011-05-10 Jim Meyering <meyering@redhat.com>
13148
13149 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13150
2f142cc5
JB
131512011-05-10 Juanma Barranquero <lekktu@gmail.com>
13152
13153 * image.c (Finit_image_library): Return t for built-in image types,
13154 like pbm and xbm. (Bug#8640)
13155
57679c86
AS
131562011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13157
13158 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13159
888c9e86
EZ
131602011-05-07 Eli Zaretskii <eliz@gnu.org>
13161
b0512a1d
EZ
13162 * w32console.c (Fset_screen_color): Doc fix.
13163 (Fget_screen_color): New function.
13164 (syms_of_ntterm): Defsubr it.
13165
7285dc67
EZ
13166 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13167 unlink the temporary file if Fcall_process didn't create it in the
13168 first place.
13169 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13170 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13171 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13172 cue to call_process_cleanup not to close that handle.
13173
4d3fcc8e
BK
131742011-05-07 Ben Key <bkey76@gmail.com>
13175
13176 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13177 one of two shell specific rules, either bootstrap-temacs-CMD or
13178 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13179 to the previous implementation of the bootstrap-temacs rule.
13180 The bootstrap-temacs-CMD rule is similar to the previous
13181 implementation of the bootstrap-temacs rule except that it
13182 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13183 variable.
13184
13185 These changes, along with some changes to nt/configure.bat,
13186 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13187 earlier fix to add support for --cflags and --ldflags options
13188 that include quotes so that it works whether make uses cmd or
13189 sh as the shell.
13190
b4289b64
MA
131912011-05-06 Michael Albinus <michael.albinus@gmx.de>
13192
13193 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13194 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13195 is a constant.
13196 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13197 a string. Handle both cases.
13198 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13199 (Fdbus_register_method): Use Qinvalid_function.
13200
af4c0e28
JB
132012011-05-06 Juanma Barranquero <lekktu@gmail.com>
13202
13203 * makefile.w32-in: Update dependencies.
13204 (LISP_H): Add inttypes.h and stdin.h.
13205 (PROCESS_H): Add unistd.h.
13206
c51453d9
EZ
132072011-05-06 Eli Zaretskii <eliz@gnu.org>
13208
13209 * lread.c: Include limits.h (fixes the MS-Windows build broken by
13210 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
13211
8ff0ac3c 132122011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 13213
4c4b566b
PE
13214 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
13215
aab2b9b5
PE
13216 * term.c (vfatal): Remove stray call to va_end.
13217 It's not needed and the C Standard doesn't allow it here anyway.
13218
c378da0b
PE
13219 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
13220 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
13221
288b08c7
PE
13222 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
13223 bytes.
13224
e3601888
PE
13225 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13226
db6c0e74
PE
13227 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13228
dd5963ea
PE
13229 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
13230
88c9450f
PE
13231 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
13232
2f9442b8
PE
13233 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
13234
c032b5f8
PE
13235 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
13236 * charset.c (Fdefine_charset_internal): Don't initialize
13237 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 13238 32-bit int (Bug#8600).
a108c10b
PE
13239
13240 * lread.c (read_integer): Be more consistent with string-to-number.
13241 Use string_to_number to do the actual conversion; this avoids
13242 rounding errors and fixes some other screwups. Without this fix,
13243 for example, #x1fffffffffffffff was misread as -2305843009213693952.
13244 (digit_to_number): Move earlier, for benefit of read_integer.
13245 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 13246 not a digit in any supported base. (Bug#8602)
a108c10b 13247
ad5f9eea
PE
13248 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
13249
aec1708a
PE
13250 * dispnew.c (scrolling_window): Return 1 if we scrolled,
13251 to match comment at start of function. This also removes a
13252 GCC warning about overflow in a 32+64-bit port.
13253
47be4ab5
PE
13254 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
13255
371cac43
PE
13256 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
13257 Reported by Stefan Monnier in
13258 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
13259 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13260 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 13261
d01a7826
PE
13262 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
13263 (EMACS_UINTPTR): Likewise, with uintptr_t.
13264
7fd47d5c
PE
13265 * lisp.h: Prefer 64-bit EMACS_INT if available.
13266 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
13267 on 32-bit hosts that have 64-bit int, so that they can access
13268 large files.
122b0c86
PE
13269 However, temporarily disable this change unless the temporary
13270 symbol WIDE_EMACS_INT is defined.
7fd47d5c 13271
8727937b
PE
13272 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
13273
8ac068ac
PE
13274 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
13275 This removes an assumption that EMACS_INT and long are the same
13276 width as pointers. The assumption is true for Emacs porting targets
13277 now, but we want to make other targets possible.
13278 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
13279 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
13280 In the rest of the code, change types of integers that hold casted
13281 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
13282 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
13283 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13284 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
13285 No need to cast type when ORing.
13286 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
13287 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
13288 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
13289 assume EMACS_INT is the same width as char *.
13290 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
13291 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
13292 Remove no-longer-needed casts.
13293 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
13294 (xg_tool_bar_help_callback, xg_make_tool_item):
13295 Use EMACS_INTPTR to hold an integer
13296 that will be cast to void *; this can avoid a GCC warning
13297 if EMACS_INT is not the same width as void *.
13298 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
13299 * xdisp.c (display_echo_area_1, resize_mini_window_1):
13300 (current_message_1, set_message_1):
13301 Use a local to convert to proper width without a cast.
13302 * xmenu.c (dialog_selection_callback): Likewise.
13303
ede49d71
PE
13304 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
13305 Also, don't assume VALBITS / RAND_BITS is less than 5,
13306 and don't rely on undefined behavior when shifting a 1 left into
13307 the sign bit.
13308 * lisp.h (get_random): Change signature to match.
13309
2f30ecd0
PE
13310 * lread.c (hash_string): Use size_t, not int, for hash computation.
13311 Normally we prefer signed values; but hashing is special, because
13312 it's better to use unsigned division on hash table sizes so that
13313 the remainder is nonnegative. Also, size_t is the natural width
13314 for hashing into memory. The previous code used 'int', which doesn't
13315 retain enough info to hash well into very large tables.
13316 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
13317
2a866e7b
PE
13318 * dbusbind.c: Don't possibly lose pointer info when converting.
13319 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13320 Use XPNTR rather than XHASH, so that the high-order bits of
13321 the pointer aren't lost when converting through void *.
13322
51639eac
PE
13323 * eval.c (Fautoload): Don't double-shift a pointer.
13324
92394119
PE
13325 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
13326
dbdb9a7c
JB
133272011-05-06 Juanma Barranquero <lekktu@gmail.com>
13328
13329 * gnutls.c (DEF_GNUTLS_FN):
13330 * image.c (DEF_IMGLIB_FN): Make function pointers static.
13331
db7a0b4f
AS
133322011-05-05 Andreas Schwab <schwab@linux-m68k.org>
13333
13334 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
13335 marker. (Bug#8610)
13336
cd394be1 133372011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
13338
13339 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
13340 New version that can reserve upto 2GB of heap space.
13341
f7ff1b0f 133422011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
13343
13344 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
13345
639c109b
TZ
133462011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
13347
13348 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13349 `gnutls_certificate_set_x509_key_file'.
13350
d2127135
JB
133512011-05-05 Juanma Barranquero <lekktu@gmail.com>
13352
13353 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
13354 Update dependencies.
13355
e968f4f3
JB
133562011-05-04 Juanma Barranquero <lekktu@gmail.com>
13357
13358 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
13359 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
13360 Remove unused parameter `fildes'.
13361 * process.c (read_process_output, send_process): Don't pass it.
13362
84d358f0
JB
133632011-05-04 Juanma Barranquero <lekktu@gmail.com>
13364
13365 Fix previous change: the library cache is defined in w32.c.
13366 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
13367 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
13368
0898ca10
JB
133692011-05-04 Juanma Barranquero <lekktu@gmail.com>
13370
13371 Implement dynamic loading of GnuTLS on Windows.
13372
13373 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
13374 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
13375 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13376 Declare.
13377
13378 * gnutls.c (Qgnutls_dll): Define.
13379 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
13380 (gnutls_*): Declare function pointers.
13381 (init_gnutls_functions): New function to initialize function pointers.
13382 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
13383 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
13384 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13385 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
13386 (emacs_gnutls_write, emacs_gnutls_read)
13387 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
13388 (Fgnutls_available_p): New function.
13389 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
13390 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
13391 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
13392
13393 * image.c: Include w32.h.
13394 (Vimage_type_cache): Delete.
13395 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
13396 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
13397 (w32_delayed_load): Move to w32.c.
13398
13399 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
13400
13401 * w32.c (QCloaded_from, Vlibrary_cache): Define.
13402 (w32_delayed_load): Move from image.c. When loading a library, record
13403 its filename in the :loaded-from property of the library id.
13404 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
13405 Initialize and staticpro them.
13406 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
13407
13408 * process.c: Include lisp.h before w32.h, not after.
13409 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
13410 instead of gnutls_record_check_pending.
13411
13412 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
13413
ff4de4aa
TZ
134142011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
13415
13416 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
13417 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
13418 as passed in.
13419
abe95abb
JD
134202011-05-03 Jan Djärv <jan.h.d@swipnet.se>
13421
13422 * xterm.c (x_set_frame_alpha): Do not set property on anything
13423 else than FRAME_X_OUTER_WINDOW (Bug#8608).
13424
e16e55d4
JB
134252011-05-02 Juanma Barranquero <lekktu@gmail.com>
13426
13427 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
13428
bafcf6a5
JB
134292011-05-02 Juanma Barranquero <lekktu@gmail.com>
13430
13431 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
13432 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
13433 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
13434 (gnutls_global_initialized, Qgnutls_bootprop_priority)
13435 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
13436 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13437 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
13438 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
13439 (Qgnutls_bootprop_callbacks_verify): Make static.
13440
e7a6747f
AS
134412011-05-01 Andreas Schwab <schwab@linux-m68k.org>
13442
19ed11ba
AS
13443 * callproc.c: Indentation fixup.
13444
e7a6747f 13445 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
13446 (wait_for_termination, interruptible_wait_for_termination):
13447 Move after wait_for_termination_1.
e7a6747f 13448
1ef14cb4
LMI
134492011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
13450
13451 * sysdep.c (interruptible_wait_for_termination): New function
13452 which is like wait_for_termination, but allows keyboard
13453 interruptions.
13454
13455 * callproc.c (Fcall_process): Add (:file "file") as an option for
13456 the STDOUT buffer.
13457 (Fcall_process_region): Ditto.
13458
330d880c
EZ
134592011-04-30 Eli Zaretskii <eliz@gnu.org>
13460
8db90b73
EZ
13461 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
13462 rather than `XVECTOR (FOO)->size'.
13463
330d880c
EZ
13464 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
13465 inttypes.h, as a gnulib replacement is used if it not available in
13466 system headers.
13467
15cbd324
EZ
134682011-04-21 Eli Zaretskii <eliz@gnu.org>
13469
13470 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13471 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
13472 of MOST_POSITIVE_FIXNUM. (Bug#8528)
13473
13474 * coding.c (coding_alloc_by_realloc): Error out if destination
13475 will grow beyond MOST_POSITIVE_FIXNUM.
13476 (decode_coding_emacs_mule): Abort if there isn't enough place in
13477 charbuf for the composition carryover bytes. Reserve an extra
13478 space for up to 2 characters produced in a loop.
13479 (decode_coding_iso_2022): Abort if there isn't enough place in
13480 charbuf for the composition carryover bytes.
13481
134822011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 13483
ae940cca
EZ
13484 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
13485 aborting when %lld or %lll format is passed.
13486 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13487 %llo or %llx format is passed. (Bug#8545)
13488
03ab8921
EZ
13489 * window.c (window_scroll_line_based): Use a marker instead of
13490 simple variables to record original value of point. (Bug#7952)
13491
afda1437
EZ
13492 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13493 produced by %s or %c overflows available buffer space. (Bug#8545)
13494
f76dee0c
PE
134952011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13496
13497 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13498 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13499
fdc5744d
JB
135002011-04-28 Juanma Barranquero <lekktu@gmail.com>
13501
13502 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13503
638f053a
JB
135042011-04-28 Juanma Barranquero <lekktu@gmail.com>
13505
13506 * keyboard.c (Qdelayed_warnings_hook): Define.
13507 (command_loop_1): Run `delayed-warnings-hook'
13508 if Vdelayed_warnings_list is non-nil.
13509 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13510 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13511
d178f871
EZ
135122011-04-28 Eli Zaretskii <eliz@gnu.org>
13513
13514 * doprnt.c (doprnt): Don't return value smaller than the buffer
13515 size if the message was truncated. (Bug#8545).
13516
b124fd93
JB
135172011-04-28 Juanma Barranquero <lekktu@gmail.com>
13518
13519 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13520 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13521
e810457d
PE
135222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13523
13524 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13525
ea51cceb
JB
135262011-04-27 Juanma Barranquero <lekktu@gmail.com>
13527
13528 * makefile.w32-in: Update dependencies.
13529
94dcfacf
EZ
135302011-04-27 Eli Zaretskii <eliz@gnu.org>
13531
13532 Improve `doprnt' and its usage. (Bug#8545)
13533 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13534 `format_end'. Remove support for %l as a conversion specifier.
13535 Don't use xrealloc. Improve diagnostics when the %l size modifier
13536 is used. Update the commentary.
13537
13538 * eval.c (verror): Simplify calculation of size_t.
13539
13540 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13541 messages.
13542
f61f41d7
PE
135432011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13544
13545 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13546 change.
13547
96fb4434
PE
135482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13549
13550 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13551 This makes this file independent of the recent pseudovector change.
13552
671875da 135532011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13554
69e9b5a3
PE
13555 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13556
b5f869a7 13557 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13558 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13559 Remove unused local.
c8926152 13560 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13561
841a1577 13562 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13563 GCC 4.6.0 optimizes based on type-based alias analysis.
13564 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13565 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13566 != &v->size, and therefore "v->size = 1; b->size = 2; return
13567 v->size;" must therefore return 1. This assumption is incorrect
13568 for Emacs, since it type-puns struct Lisp_Vector * with many other
13569 types. To fix this problem, this patch adds a new type struct
f904488f 13570 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13571 and pseudovectors, and helps optimizing compilers not get fooled
13572 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13573 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13574 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13575 the size member.
eab3844f
PE
13576 (XSETPVECTYPE): Rewrite in terms of new macro.
13577 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13578 This is a bit clearer, and further avoids the possibility of
13579 undesirable aliasing.
13580 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13581 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13582 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13583 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13584 (ASIZE): Now uses header.size rather than size.
13585 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13586 to avoid the hassle of writing XVECTOR (foo)->header.size.
13587 (struct vectorlike_header): New type.
eab3844f
PE
13588 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13589 object, to help avoid aliasing.
13590 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13591 (SUBRP): Likewise, since Lisp_Subr is a special case.
13592 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13593 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13594 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13595 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13596 changed to be "header.size" and "header.next".
13597 * buffer.h (struct buffer): Likewise.
13598 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13599 * frame.h (struct frame): Likewise.
13600 * process.h (struct Lisp_Process): Likewise.
13601 * termhooks.h (struct terminal): Likewise.
13602 * window.c (struct save_window_data, struct saved_window): Likewise.
13603 * window.h (struct window): Likewise.
13604 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13605 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13606 * buffer.c (init_buffer_once): Likewise.
13607 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13608 special case.
13609 * process.c (Fformat_network_address): Use local var for size,
13610 for brevity.
13611
0df1eac5
PE
13612 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13613
847ab9d1 13614 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13615 * data.c (atof): Remove decl; no longer used or needed.
13616 (digit_to_number): Move to lread.c.
13617 (Fstring_to_number): Use new string_to_number function, to be
13618 consistent with how the Lisp reader treats infinities and NaNs.
13619 Do not assume that floating-point numbers represent EMACS_INT
13620 without losing information; this is not true on most 64-bit hosts.
13621 Avoid double-rounding errors, by insisting on integers when
13622 parsing non-base-10 numbers, as the documentation specifies.
13623 * lisp.h (string_to_number): New decl, replacing ...
13624 (isfloat_string): Remove.
bc0a5c13 13625 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13626 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13627 appears to have been a coding error. Similarly, do not accept
13628 strings like +-1e0 as floating point numbers. Do not report
13629 overflow for integer overflows unless the base is not 10 which
13630 means we have no simple and reliable way to continue.
13631 Break out the floating-point parsing into a new
13632 function string_to_number, so that Fstring_to_number parses
13633 floating point numbers consistently with the Lisp reader.
04f2d78b 13634 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13635 (E_CHAR, EXP_INT): Remove, replacing with ...
13636 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13637 (string_to_number): New function, replacing isfloat_string.
13638 This function checks for valid syntax and produces the resulting
13639 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13640 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13641 so that overflow for non-base-10 numbers is reported only when
13642 there's no portable and simple way to convert to floating point.
452f4150 13643
67769ffc
PE
13644 * textprop.c (set_text_properties_1): Rewrite for clarity,
13645 and to avoid GCC warning about integer overflow.
13646
c20db43f
PE
13647 * intervals.h (struct interval): Use EMACS_INT for members
13648 where EMACS_UINT might cause problems. See
13649 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13650 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13651 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13652 All uses changed.
37aa2f85
PE
13653 (offset_intervals): Tell GCC not to worry about length overflow
13654 when negating a negative length.
c20db43f 13655
2538aa2f
PE
13656 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13657 (overrun_check_free): Likewise.
13658
f2d3008d
PE
13659 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13660 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13661 word size.
13662
ec8df744
PE
13663 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13664 (gnutls_make_error): Rename local to avoid shadowing.
13665 (gnutls_emacs_global_deinit): ifdef out; not used.
13666 (Fgnutls_boot): Use const for pointer to readonly storage.
13667 Comment out unused local. Fix pointer signedness problems.
13668
640ee02d
PE
13669 * lread.c (openp): Don't stuff size_t into an 'int'.
13670 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13671 about possible signed overflow.
13672
6048fb2a
PE
13673 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13674 (GDK_KEY_g): Don't define if already defined.
13675 (xg_prepare_tooltip): Avoid pointer signedness problem.
13676 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13677
fa3c87e1
PE
13678 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13679 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13680
2172544b
PE
13681 * xfns.c (Fx_window_property): Simplify a bit,
13682 to make a bit faster and to avoid GCC 4.6.0 warning.
13683 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13684
9b821a21
PE
13685 * fns.c (internal_equal): Don't assume size_t fits in int.
13686
3c616cfa
PE
13687 * alloc.c (compact_small_strings): Tighten assertion a little.
13688
c2982e87
PE
13689 Replace pEd with more-general pI, and fix some printf arg casts.
13690 * lisp.h (pI): New macro, generalizing old pEd macro to other
13691 conversion specifiers. For example, use "...%"pI"d..." rather
13692 than "...%"pEd"...".
13693 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13694 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13695 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13696 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13697 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13698 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13699 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13700 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13701 64-bit hosts.
13702 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13703 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13704 * print.c (safe_debug_print, print_object): Likewise.
13705 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13706 to int.
6f04d126
PE
13707 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13708 avoiding the 0 flag, which is not portable.
c2982e87
PE
13709 * process.c (Fmake_network_process): Use pI to avoid cast.
13710 * region-cache.c (pp_cache): Likewise.
13711 * xdisp.c (decode_mode_spec): Likewise.
13712 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13713 behavior on 64-bit hosts with printf arg.
6f04d126 13714 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13715 (x_stop_queuing_selection_requests): Likewise.
13716 (x_get_window_property): Don't truncate byte count to an 'int'
13717 when tracing.
0b432f21 13718
5e073ec7
PE
13719 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13720 here, since it parses constructs like leading '-' and spaces,
13721 which are not wanted; and it overflows with large numbers.
13722 Instead, simply match F[0-9]+, which is what is wanted anyway.
13723
36372bf9
PE
13724 * alloc.c: Remove unportable assumptions about struct layout.
13725 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13726 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13727 (allocate_vectorlike, make_pure_vector): Use the new macros,
13728 plus offsetof, to remove unportable assumptions about struct layout.
13729 These assumptions hold on all porting targets that I know of, but
13730 they are not guaranteed, they're easy to remove, and removing them
13731 makes further changes easier.
13732
0b432f21
PE
13733 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13734 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13735 (string_overrun_cookie): Now const. Use initializers that
13736 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13737 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13738 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13739 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13740 multiple of sizeof (EMACS_INT); it need not be, if
13741 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13742 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13743
895009e1
JB
137442011-04-26 Juanma Barranquero <lekktu@gmail.com>
13745
13746 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13747
6a7a1b0b
TZ
137482011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13749
13750 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13751 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13752 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13753
841a1577 137542011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13755
13756 * lisp.h (Qdebug): List symbol.
895009e1 13757 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13758 * keyboard.c (debug-on-event): New variable.
13759 (handle_user_signal): Break into debugger when debug-on-event
13760 matches the current signal symbol.
13761
f2d3ba6f
DN
137622011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13763
13764 * alloc.c (check_sblock, check_string_bytes)
13765 (check_string_free_list): Convert to standard C.
13766
42ce4c63
TZ
137672011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13768
13769 * w32.c (emacs_gnutls_push): Fix typo.
13770
825cd63c
EZ
137712011-04-25 Eli Zaretskii <eliz@gnu.org>
13772
fb11d64d
EZ
13773 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13774 "cast to pointer from integer of different size".
13775
825cd63c
EZ
13776 Improve doprnt and its use in verror. (Bug#8545)
13777 * doprnt.c (doprnt): Document the set of format control sequences
13778 supported by the function. Use SAFE_ALLOCA instead of always
13779 using `alloca'.
13780
13781 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13782 is one byte too soon. Don't use xrealloc; instead xfree and
13783 xmalloc anew.
13784
e061a11b
TZ
137852011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13786
13787 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13788 callbacks stage.
13789
13790 * gnutls.c: Renamed global_initialized to
13791 gnutls_global_initialized. Added internals for the
13792 :verify-hostname-error, :verify-error, and :verify-flags
13793 parameters of `gnutls-boot' and documented those parameters in the
13794 docstring. Start callback support.
9173deec
JB
13795 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13796 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13797 on error. Return error code.
e061a11b
TZ
13798 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13799 (emacs_gnutls_read): Likewise.
13800 (Fgnutls_boot): Return handshake error code.
13801 (emacs_gnutls_handle_error): New function.
13802 (wsaerror_to_errno): Likewise.
13803
13804 * w32.h (emacs_gnutls_pull): Add prototype.
13805 (emacs_gnutls_push): Likewise.
13806
13807 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13808 (emacs_gnutls_push): Likewise.
13809
138102011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13811
13812 * process.c (wait_reading_process_output): Check if GnuTLS
13813 buffered some data internally if no FDs are set for TLS
13814 connections.
13815
13816 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13817 (LIBS): Link to USER_LIBS.
13818 ($(BLD)/gnutls.$(0)): New target.
13819
fa6996bc
EZ
138202011-04-24 Eli Zaretskii <eliz@gnu.org>
13821
eb35682e
EZ
13822 * xdisp.c (handle_single_display_spec): Rename the
13823 display_replaced_before_p argument into display_replaced_p, to
13824 make it consistent with the commentary. Fix typos in the
13825 commentary.
13826
e2ad650c
EZ
13827 * textprop.c (syms_of_textprop): Remove dead code.
13828 (copy_text_properties): Delete obsolete commentary about an
13829 interface that was deleted long ago. Fix typos in the description
13830 of arguments.
13831
1b2de274
EZ
13832 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13833 to changes in oldXMenu/XMenu.h from 2011-04-16.
13834 <menu_help_message, prev_menu_help_message>: Constify.
13835 (IT_menu_make_room): menu->help_text is now `const char **';
13836 adjust.
13837
13838 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13839 to changes in oldXMenu/XMenu.h from 2011-04-16.
13840 (struct XMenu): Declare `help_text' `const char **'.
13841
13842 * xfaces.c <Qunspecified>: Make extern again.
13843
13844 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13845 required by POSIX.
1b2de274 13846
762b15be
EZ
13847 * doc.c (get_doc_string): Improve the format passed to `error'.
13848
13849 * doprnt.c (doprnt): Improve commentary.
13850
13851 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13852
13853 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13854 them with etags.
13855
f1052e5d
EZ
13856 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13857 changes in globals.h immediately force recompilation.
762b15be
EZ
13858 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13859 $(CURDIR)/s/ms-w32.h.
13860 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13861
fa6996bc
EZ
13862 * character.c (Fchar_direction): Function deleted.
13863 (syms_of_character): Don't defsubr it.
13864 <char-direction-table>: Deleted.
13865
e6c3da20
EZ
138662011-04-23 Eli Zaretskii <eliz@gnu.org>
13867
13868 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13869 * doprnt.c: Include limits.h.
13870 (SIZE_MAX): New macro.
04f2d78b
CB
13871 (doprnt): Return a size_t value. 2nd arg is now size_t.
13872 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13873 Improve overflow protection. Support `l' modifier for integer
13874 conversions. Support %l conversion. Don't assume an EMACS_INT
13875 argument for integer conversions and for %c.
13876
13877 * lisp.h (doprnt): Restore prototype.
13878
13879 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13880 $(SRC)/character.h.
13881
13882 * Makefile.in (base_obj): Add back doprnt.o.
13883
13884 * deps.mk (doprnt.o): Add back prerequisites.
13885 (callint.o): Depend on character.h.
13886
13887 * eval.c (internal_lisp_condition_case): Include the handler
13888 representation in the error message.
13889 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13890 when breaking from the loop.
13891
13892 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13893
13894 * callint.c (Fcall_interactively): When displaying error message
13895 about invalid control letter, pass the character's codepoint, not
13896 a pointer to its multibyte form. Improve display of the character
13897 in octal and display also its hex code.
13898
13899 * character.c (char_string): Use %x to display the (unsigned)
13900 codepoint of an invalid character, to avoid displaying a bogus
13901 negative value.
13902
13903 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13904 `error', not SYMBOL_NAME itself.
13905
13906 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13907 character arguments to `error'.
13908
13909 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13910 to `error' in error message about FINAL_CHAR argument. Make sure
13911 FINAL_CHAR is a character, and use %c when it is passed as
13912 argument to `error'.
13913
4ffd0d6b 139142011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13915
13916 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13917
13918 * w32.c: Include <time.h>.
13919 (sys_localtime): New function.
13920
4ffd0d6b 139212011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13922
13923 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13924
4ffd0d6b 13925 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13926
4ffd0d6b 139272011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13928
4ffd0d6b
GM
13929 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13930 zombies (Bug#8467).
aac0c6e3 13931
04c56954
EZ
139322011-04-19 Eli Zaretskii <eliz@gnu.org>
13933
13934 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13935 gl_state.e_property when gl_state.object is Qt.
13936
13937 * insdel.c (make_gap_larger): Remove limitation of buffer size
13938 to <= INT_MAX.
13939
16a43933
CY
139402011-04-18 Chong Yidong <cyd@stupidchicken.com>
13941
13942 * xdisp.c (lookup_glyphless_char_display)
13943 (produce_glyphless_glyph): Handle cons cell entry in
13944 glyphless-char-display.
13945 (Vglyphless_char_display): Document it.
13946
13947 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13948 glyphless-char-display.
13949
4581706e
CY
139502011-04-17 Chong Yidong <cyd@stupidchicken.com>
13951
13952 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13953
13954 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13955
13956 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13957 definition for no-X builds.
13958
4887c6e2 139592011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13960
fd35b6f9
PE
13961 Static checks with GCC 4.6.0 and non-default toolkits.
13962
5c1ccb01
PE
13963 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13964
006c5daa
PE
13965 * process.c (keyboard_bit_set): Define only if SIGIO.
13966 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13967 (send_process): Repair possible setjmp clobbering.
13968
efc736d3
PE
13969 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13970
4e2fe2e6
PE
13971 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13972
f97334a2
PE
13973 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13974
4e75f29d
PE
13975 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13976 Define only if needed.
13977
90efadd1
PE
13978 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13979 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13980 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13981
3c647824
PE
13982 * dispextern.h (struct redisplay_interface): Rename param
13983 to avoid shadowing.
e264f262 13984 * termhooks.h (struct terminal): Likewise.
761383f4 13985 * xterm.c (xembed_send_message): Likewise.
3c647824 13986
b58c5c4a
PE
13987 * insdel.c (make_gap_smaller): Define only if
13988 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13989
cad59032
PE
13990 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13991 it.
13992
c339dc2e
PE
13993 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13994 so that we aren't warned about unused symbols.
13995
91a3e27b
PE
13996 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13997
399c71d3 13998 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13999
8ffc96f5
PE
14000 * xfns.c (x_real_positions): Mark locals as initialized.
14001
eef9bc79
PE
14002 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14003
098db9dd
PE
14004 * xterm.c: Fix problems found by static analysis with other toolkits.
14005 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14006 (x_dispatch_event): Declare static if USE_GTK, and
14007 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14008 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14009 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14010 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14011 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14012
eb18f6cc
PE
14013 * xmenu.c (menu_help_callback): Pointer type fixes.
14014 Use const pointers when pointing at readonly data. Avoid pointer
14015 signedness clashes.
14016 (FALSE): Remove unused macro.
14017 (update_frame_menubar): Remove unused decl.
14018
1fe72bf8
PE
14019 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14020
60d9e1db
PE
14021 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14022 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14023 (single_menu_item): Rename local to avoid shadowing.
14024
39261c26
PE
14025 * keyboard.c (make_lispy_event): Remove unused local var.
14026
018c5e19
PE
14027 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14028 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14029
63d2b86e
PE
14030 * bitmaps: Change bitmaps from unsigned char back to the X11
14031 compatible char. Avoid the old compiler warnings about
14032 out-of-range initializers by using, for example, '\xab' rather
14033 than 0xab.
14034
aefd87e1
PE
14035 * xgselect.c (xgselect_initialize): Check vs interface
14036 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14037
bf501fb9
PE
14038 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14039
e9829fdf
PE
14040 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14041 to read-only memory.
14042
1086c095
PE
14043 * fns.c (vector): Remove; this old hack is no longer needed.
14044
2baccd04 14045 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14046 Remove unused var.
dde42981 14047 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14048
72391843 14049 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14050
436c16df 14051 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14052 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14053 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14054
92bb796d 14055 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14056 (x_term_init): Remove local to avoid shadowing.
92bb796d 14057
764430a3 14058 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14059
14060 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14061 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14062
d1dfb56c
EZ
140632011-04-16 Eli Zaretskii <eliz@gnu.org>
14064
c4354cb4
EZ
14065 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14066
d1dfb56c
EZ
14067 Fix regex.c, syntax.c and friends for buffers > 2GB.
14068 * syntax.h (struct gl_state_s): Declare character position members
14069 EMACS_INT.
14070
14071 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14072
04f2d78b
CB
14073 * textprop.c (verify_interval_modification, interval_of):
14074 Declare arguments EMACS_INT.
d1dfb56c
EZ
14075
14076 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14077 EMACS_INT.
14078
14079 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14080
14081 * indent.c (Fvertical_motion): Local variable it_start is now
14082 EMACS_INT.
14083
14084 * regex.c (re_match, re_match_2, re_match_2_internal)
14085 (bcmp_translate, regcomp, regexec, print_double_string)
14086 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14087 (re_compile_pattern, re_exec): Declare arguments and local
14088 variables `size_t' and `ssize_t' and return values `regoff_t', as
14089 appropriate.
14090 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14091 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14092 <compile_stack_type>: `size' and `avail' are now `size_t'.
14093
14094 * regex.h <regoff_t>: Use ssize_t, not int.
14095 (re_search, re_search_2, re_match, re_match_2): Arguments that
14096 specify buffer/string position and length are now ssize_t and
14097 size_t. Return type is regoff_t.
14098
613052cd
BK
140992011-04-16 Ben Key <bkey76@gmail.com>
14100
14101 * nsfont.m: Fixed bugs in ns_get_family and
14102 ns_descriptor_to_entity that were caused by using free to
14103 deallocate memory blocks that were allocated by xmalloc (via
14104 xstrdup). This caused Emacs to crash when compiled with
14105 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14106 --enable-checking=xmallocoverrun). xfree is now used to
14107 deallocate these memory blocks.
14108
4170f62f 141092011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14110
71b41406
PE
14111 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14112
9587a89d
PE
14113 emacs_write: Accept and return EMACS_INT for sizes.
14114 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
14115 et seq.
14116 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
14117 Accept and return EMACS_INT.
14118 (emacs_gnutls_write): Return the number of bytes written on
14119 partial writes.
14120 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14121 (emacs_read, emacs_write): Remove check for negative size, as the
14122 Emacs source code has been audited now.
9587a89d
PE
14123 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14124 (emacs_read, emacs_write): Use it.
273a5f82
PE
14125 * process.c (send_process): Adjust to the new signatures of
14126 emacs_write and emacs_gnutls_write. Do not attempt to store
14127 a byte offset into an 'int'; it might overflow.
9587a89d 14128 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14129
3e047f51
PE
14130 * sound.c: Don't assume sizes fit in 'int'.
14131 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14132 Return EMACS_INT, not int.
3e047f51 14133 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14134 Accept EMACS_INT, not int.
14135 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14136 record read return values.
14137
cc39a9db
BK
141382011-04-15 Ben Key <bkey76@gmail.com>
14139
c9d0ec6d
JB
14140 * keyboard.c (Qundefined): Don't declare static since it is used
14141 in nsfns.m.
14142 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14143 static since they are used in nsfont.m.
cc39a9db 14144
6c60eb9f
SM
141452011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14146
14147 * process.c (Qprocessp): Don't declare static.
14148 * lisp.h (Qprocessp): Declare again.
14149
7990b61a
JB
141502011-04-15 Juanma Barranquero <lekktu@gmail.com>
14151
14152 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14153
5d4cb038
PE
141542011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14155
8bd7b830 14156 Improve C-level modularity by making more things 'static'.
cd64ea1d 14157
e3b27b31
PE
14158 Don't publish debugger-only interfaces to other modules.
14159 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14160 (verify_bytepos, count_markers): Move decls to the only modules
14161 that need them.
14162 * region-cache.h (pp_cache): Likewise.
14163 * window.h (check_all_windows): Likewise.
14164 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14165
5d4cb038
PE
14166 * sysdep.c (croak): Now static, if
14167 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14168 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14169
14170 * alloc.c (refill_memory_reserve): Now static if
14171 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14172 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14173
e87b6180
PE
14174 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14175 Define only if USE_LUCID.
14176
ac64929e
PE
14177 * xrdb.c (x_customization_string, x_rm_string): Now static.
14178
6f37259d
PE
14179 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14180 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14181
1683e3ab
PE
14182 * xdisp.c (draw_row_with_mouse_face): Now static.
14183 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14184
de9c2632
PE
14185 * window.h (check_all_windows): Mark externally visible.
14186
2b96acb7
PE
14187 * window.c (window_deletion_count): Now static.
14188
14189 * undo.c: Make symbols static if they're not exported.
14190 (last_undo_buffer, last_boundary_position, pending_boundary):
14191 Now static.
14192
50436f33
PE
14193 * textprop.c (interval_insert_behind_hooks): Now static.
14194 (interval_insert_in_front_hooks): Likewise.
14195
64520e5c
PE
14196 * term.c: Make symbols static if they're not exported.
14197 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14198 (max_frame_lines, tty_set_terminal_modes):
14199 (tty_reset_terminal_modes, tty_turn_off_highlight):
14200 (get_tty_terminal): Now static.
14201 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14202 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14203 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14204 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14205 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14206
1fa53021
PE
14207 * sysdep.c: Make symbols static if they're not exported.
14208 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
14209 Now static.
14210 (sigprocmask_set, full_mask): Remove; unused.
14211 (wait_debugging): Mark as visible.
14212 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
14213 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
14214
d4b43b22
PE
14215 * syntax.c (syntax_temp): Define only if !__GNUC__.
14216
b7c513d0
PE
14217 * sound.c (current_sound_device, current_sound): Now static.
14218
989b29ad
PE
14219 * search.c (searchbufs, searchbuf_head): Now static.
14220
13a55a78
PE
14221 * scroll.c (scroll_cost): Remove; unused.
14222 * dispextern.h (scroll_cost): Remove decl.
14223
de68a1fc
PE
14224 * region-cache.h (pp_cache): Mark as externally visible.
14225
40ccffa6
PE
14226 * process.c: Make symbols static if they're not exported.
14227 (process_tick, update_tick, create_process, chan_process):
14228 (Vprocess_alist, proc_buffered_char, datagram_access):
14229 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14230 (deactivate_process): Mark defn as static, as well as decl.
14231 * lisp.h (create_process): Remove decl.
14232 * process.h (chan_process, Vprocess_alist): Remove decls.
14233
ad64fc97
PE
14234 * print.c: Make symbols static if they're not exported.
14235 (print_depth, new_backquote_output, being_printed, print_buffer):
14236 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
14237 (print_interval, print_number_index, initial_stderr_stream):
14238 Now static.
14239 * lisp.h (Fprinc): Remove decl.
14240 (debug_output_compilation_hack): Mark as externally visible.
14241
adddb265
PE
14242 * sysdep.c (croak): Move decl from here to syssignal.h.
14243 * syssignal.h (croak): Put it here, so the API can be checked when
14244 'croak' is called from dissociate_if_controlling_tty.
14245
1717ede2
PE
14246 * minibuf.c: Make symbols static if they're not exported.
14247 (minibuf_save_list, choose_minibuf_frame): Now static.
14248 * lisp.h (choose_minibuf_frame): Remove decl.
14249
fa5fb2bc
PE
14250 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
14251
1e3890d1
PE
14252 * lread.c: Make symbols static if they're not exported.
14253 (read_objects, initial_obarray, oblookup_last_bucket_number):
14254 Now static.
14255 (make_symbol): Remove; unused.
14256 * lisp.h (initial_obarray, make_symbol): Remove decls.
14257
8a1414fa
PE
14258 * keyboard.c: Make symbols static if they're not exported.
14259 (single_kboard, recent_keys_index, total_keys, recent_keys):
14260 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
14261 (this_single_command_key_start, echoing, last_auto_save):
14262 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14263 (command_loop, echo_now, keyboard_init_hook, help_char_p):
14264 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
14265 (Vlispy_mouse_stem, double_click_count):
14266 Now static.
14267 (force_auto_save_soon): Define only if SIGDANGER.
14268 (ignore_mouse_drag_p): Now static if
14269 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
14270 (print_help): Remove; unused.
14271 (stop_character, last_timer_event): Mark as externally visible.
14272 * keyboard.h (ignore_mouse_drag_p): Declare only if
14273 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
14274 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
14275 * lisp.h (echoing): Remove decl.
14276 (force_auto_save_soon): Declare only if SIGDANGER.
14277 * xdisp.c (redisplay_window): Simplify code, to make it more
14278 obvious that ignore_mouse_drag_p is not accessed if !defined
14279 USE_GTK && !defined HAVE_NS.
14280
93ea6e8f
PE
14281 * intervals.c: Make symbols static if they're not exported.
14282 (merge_properties_sticky, merge_interval_right, delete_interval):
14283 Now static.
14284 * intervals.h (merge_interval_right, delete_interval): Remove decls.
14285
77382fcc
PE
14286 * insdel.c: Make symbols static if they're not exported.
14287 However, leave prepare_to_modify_buffer alone. It's never
14288 called from outside this function, but that appears to be a bug.
14289 (combine_after_change_list, combine_after_change_buffer):
4889fc82 14290 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
14291 (adjust_after_replace_noundo): Remove; unused.
14292 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 14293 (signal_before_change): Remove decls.
77382fcc 14294
9306c32e
PE
14295 * indent.c (val_compute_motion, val_vmotion): Now static.
14296
cd44d2eb
PE
14297 * image.c: Make symbols static if they're not exported.
14298 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
14299 if USE_GTK.
14300 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
14301 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
14302
ad9a7a06
PE
14303 * fringe.c (standard_bitmaps): Now static.
14304 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
14305
81626931
PE
14306 * frame.c: Make symbols static if they're not exported.
14307 (x_report_frame_params, make_terminal_frame): Now static.
14308 (get_frame_param): Now static, unless HAVE_NS.
14309 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
14310 (x_get_resource_string): Remove; not used.
14311 * frame.h (make_terminal_frame, x_report_frame_params):
14312 (x_get_resource_string); Remove decls.
14313 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14314 * lisp.h (get_frame_param): Declare only if HAVE_NS.
14315
239f9db9
PE
14316 * font.c, fontset.c: Make symbols static if they're not exported.
14317 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
14318 (FACE_SUITABLE_FOR_CHAR_P): Use it.
14319 * font.c (font_close_object): Now static.
14320 * font.h (font_close_object): Remove.
14321 * fontset.c (FONTSET_OBJLIST): Remove.
14322 (free_realized_fontset) #if-0 the body, which does nothing.
14323 (face_suitable_for_char_p): #if-0, as it's never called.
14324 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
14325 * xfaces.c (face_at_string_position):
14326 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
14327 since 0 is always ASCII.
14328
dfcf3579
PE
14329 * fns.c (weak_hash_tables): Now static.
14330
5045092b
PE
14331 * fileio.c: Make symbols static if they're not exported.
14332 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
14333 (Vwrite_region_annotation_buffers): Now static.
14334
57a96f5c
PE
14335 * eval.c: Make symbols static if they're not exported.
14336 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
14337 * lisp.h (backtrace_list): Remove decl.
14338
35f08c38
PE
14339 * emacs.c: Make symbols static if they're not exported.
14340 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
14341 (fatal_error_code, fatal_error_signal_hook, standard_args):
14342 Now static.
14343 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
14344 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
14345 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
14346 * lisp.h (fatal_error_signal_hook): Remove decl.
14347 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
14348
f44bd759
PE
14349 * editfns.c: Move a (normally-unused) function to its only use.
14350 * editfns.c, lisp.h (get_operating_system_release): Remove.
14351 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
14352 worth the hassle of breaking this out.
14353
b532497d
PE
14354 * xterm.c: Make symbols static if they're not exported.
14355 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
14356 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
14357 (x_destroy_window, x_delete_display):
14358 Now static.
14359 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14360 (x_mouse_leave): Remove; unused.
14361 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
14362 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
14363 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
14364 Remove decls.
14365 (x_mouse_leave): Declare only if WINDOWSNT.
14366 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
14367 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
14368 USE_X_TOOLKIT.
14369
1675728f
PE
14370 * ftxfont.c: Make symbols static if they're not exported.
14371 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
14372 HAVE_FREETYPE.
14373 * font.h (ftxfont_driver): Likewise.
14374
e4cebfca
PE
14375 * xfns.c: Make symbols static if they're not exported.
14376 (x_last_font_name, x_display_info_for_name):
14377 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
14378 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
14379 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
14380 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14381 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
14382 (last_show_tip_args): Now static.
14383 (xic_defaut_fontset, xic_create_fontsetname): Define only if
14384 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
14385 (x_screen_planes): Remove; unused.
14386 * dispextern.h (x_screen_planes): Remove decl.
14387
5bf46f05
PE
14388 * dispnew.c: Make symbols static if they're not exported.
14389 * dispextern.h (redraw_garbaged_frames, scrolling):
14390 (increment_row_positions): Remove.
14391 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
14392 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
14393 Now static.
14394 (redraw_garbaged_frames): Remove; unused.
14395
435f4c28
PE
14396 * xfaces.c: Make symbols static if they're not exported.
14397 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
14398 Remove decls.
14399 * xterm.h (defined_color): Remove decls.
14400 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
14401 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
14402 (menu_face_changed_default, defined_color, free_realized_face):
14403 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
14404 (ascii_face_of_lisp_face): Remove; unused.
14405
8524aef3
PE
14406 * xdisp.c: Make symbols static if they're not exported.
14407 * dispextern.h (scratch_glyph_row, window_box_edges):
14408 (glyph_to_pixel_coords, set_cursor_from_row):
14409 (get_next_display_element, set_iterator_to_next):
14410 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
14411 (show_mouse_face): Remove decls
14412 * frame.h (message_buf_print): Likewise.
14413 * lisp.h (pop_message, set_message, check_point_in_composition):
14414 Likewise.
14415 * xterm.h (set_vertical_scroll_bar): Likewise.
14416 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
14417 (message_buf_print, scratch_glyph_row, displayed_buffer):
14418 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
14419 (get_next_display_element, show_mouse_face, window_box_edges):
14420 (frame_to_window_pixel_xy, check_point_in_composition):
14421 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
14422 (glyph_to_pixel_coords): Remove; unused.
14423
16390cd2
PE
14424 * dired.c (file_name_completion): Now static.
14425
14426 * dbusbind.c (xd_in_read_queued_messages): Now static.
14427
a25f4dfa
PE
14428 * lisp.h (circular_list_error, FOREACH): Remove; unused.
14429 * data.c (circular_list_error): Remove.
14430
14a9c8df
PE
14431 * commands.h (last_point_position, last_point_position_buffer):
14432 (last_point_position_window): Remove decls.
14433 * keyboard.c: Make these variables static.
14434
04f2d78b
CB
14435 * coding.h (coding, code_convert_region, encode_coding_gap):
14436 Remove decls.
74ab6df5
PE
14437 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
14438 (iso_code_class, detect_coding, code_convert_region): Now static.
14439 (encode_coding_gap): Remove; unused.
14440
38dfbee1
PE
14441 * chartab.c (chartab_chars, chartab_bits): Now static.
14442
a2cb4e63
PE
14443 * charset.h (charset_iso_8859_1): Remove decl.
14444 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
14445 Now static.
14446
127198fd
PE
14447 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
14448 * ccl.c (Vccl_program_table): Now static.
14449 (check_ccl_update): Remove; unused.
14450
d85b608f
PE
14451 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
14452 * category.h: ... from here.
14453 * category.c (check_category_table, set_category_set): Now static.
14454
31cd66f3
PE
14455 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
14456 * lisp.h: Remove these decls.
14457
c358e587
PE
14458 * buffer.c (buffer_count): Remove unused var.
14459
e78aecca
PE
14460 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
14461 so that it's not optimized away.
14462 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
14463 * dispextern.h (bidi_dump_cached_states): Remove, since it's
14464 exported only to the debugger.
14465
e192d7d3 14466 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 14467 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 14468
92470028
PE
14469 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
14470 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
14471 was inaccessible from Lisp.
14472 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
14473 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
14474
244ed907
PE
14475 alloc.c: Import and export fewer symbols, and remove unused items.
14476 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
14477 is defined.
14478 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
14479 it's not optimized away by whole-program optimization.
14480 (message_enable_multibyte, free_misc): Remove.
14481 (catchlist, handlerlist, mark_backtrace):
14482 Declare only if BYTE_MARK_STACK.
14483 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
14484 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
14485 (message_enable_multibyte): Remove decl.
14486 (free_misc, interval_free_list, float_block, float_block_index):
14487 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14488 (cons_free_list, last_marked_index):
14489 Now static.
14490 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14491 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14492 (mark_backtrace): Define only if BYTE_MARK_STACK.
14493 * xdisp.c (message_enable_multibyte): Now static.
14494
61c2b50e 14495 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14496 This makes it easier for human readers (and static analyzers)
14497 to see whether these variables are used from other modules.
14498 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14499 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14500 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14501 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14502 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14503 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14504 * xmenu.c, xselect.c:
14505 Declare Q* vars static if they are not used in other modules.
14506 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14507 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14508 Remove decls of unexported vars.
14509 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14510
95c82688
PE
14511 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14512
16a97296
PE
14513 Make Emacs functions such as Fatom 'static' by default.
14514 This makes it easier for human readers (and static analyzers)
14515 to see whether these functions can be called from other modules.
14516 DEFUN now defines a static function. To make the function external
14517 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14518 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14519 (Finit_image_library):
16a97296
PE
14520 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14521 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14522 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14523 Remove decls, since these functions are now static.
14524 (Funintern, Fget_internal_run_time): New decls, since these functions
14525 were already external.
95c82688 14526
16a97296
PE
14527 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14528 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14529 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14530 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14531 * keyboard.c, keymap.c, lread.c:
14532 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14533 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14534 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14535 Mark functions with DEFUE instead of DEFUN,
14536 if they are used in other modules.
14537 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14538 decls for now-static functions.
14539 * buffer.h (Fdelete_overlay): Remove decl.
14540 * callproc.c (Fgetenv_internal): Mark as internal.
14541 * composite.c (Fremove_list_of_text_properties): Remove decl.
14542 (Fcomposition_get_gstring): New forward static decl.
14543 * composite.h (Fcomposite_get_gstring): Remove decl.
14544 * dired.c (Ffile_attributes): New forward static decl.
14545 * doc.c (Fdocumntation_property): New forward static decl.
14546 * eval.c (Ffetch_bytecode): New forward static decl.
14547 (Funintern): Remove extern decl; now in .h file where it belongs.
14548 * fileio.c (Fmake_symbolic_link): New forward static decl.
14549 * image.c (Finit_image_library): New forward static decl.
14550 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14551 * intervals.h (Fprevious_property_change):
14552 (Fremove_list_of_text_properties): Remove decls.
14553 * keyboard.c (Fthis_command_keys): Remove decl.
14554 (Fcommand_execute): New forward static decl.
14555 * keymap.c (Flookup_key): New forward static decl.
14556 (Fcopy_keymap): Now static.
14557 * keymap.h (Flookup_key): Remove decl.
14558 * process.c (Fget_process): New forward static decl.
14559 (Fprocess_datagram_address): Mark as internal.
14560 * syntax.c (Fsyntax_table_p): New forward static decl.
14561 (skip_chars): Remove duplicate decl.
14562 * textprop.c (Fprevious_property_change): New forward static decl.
14563 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14564 Now internal.
14565 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14566 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14567
785bbd42
PE
14568 * editfns.c (Fformat): Remove unreachable code.
14569
8b913b57
AS
145702011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14571
14572 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14573 change. (Bug#8496)
14574
a6744a35
EZ
145752011-04-13 Eli Zaretskii <eliz@gnu.org>
14576
14577 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14578 when at ZV. (Bug#8487)
14579
e7974947
AS
145802011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14581
baad03f0
AS
14582 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14583 (Bug#8437)
14584 * keyboard.c (parse_tool_bar_item): Likewise.
14585 * sound.c (sound_cleanup, alsa_close): Likewise.
14586 * termcap.c (tgetent): Likewise.
14587 * xfns.c (x_default_font_parameter): Likewise.
14588 * xsettings.c (read_and_apply_settings): Likewise.
14589
e7974947
AS
14590 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14591 (overrun_check_free): Protoize.
14592
28272684
PE
145932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14594
14595 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14596 since callers should never pass a negative size.
14597 Change the signature to match that of plain 'read' and 'write'; see
14598 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14599 * lisp.h: Update prototypes of emacs_write and emacs_read.
14600
11997c76
EZ
146012011-04-11 Eli Zaretskii <eliz@gnu.org>
14602
14603 * xdisp.c (redisplay_window): Don't try to determine the character
14604 position of the scroll margin if the window start point w->startp
e896f03c 14605 is outside the buffer's accessible region. (Bug#8468)
11997c76 14606
8a2cbd72
EZ
146072011-04-10 Eli Zaretskii <eliz@gnu.org>
14608
14609 Fix write-region and its subroutines for buffers > 2GB.
14610 * fileio.c (a_write, e_write): Modify declaration of arguments and
14611 local variables to support buffers larger than 2GB.
14612 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14613
14614 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14615 argument, local variables, and return value.
14616
14617 * lisp.h: Update prototypes of emacs_write and emacs_read.
14618
14619 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14620
4073e537 146212011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14622
1ebfdcb6
PE
14623 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14624
b2ded58d
PE
14625 Fix more problems found by GCC 4.6.0's static checks.
14626
7d66342c
PE
14627 * xdisp.c (vmessage): Use a better test for character truncation.
14628
bbf47d44
PE
14629 * charset.c (load_charset_map): <, not <=, for optimization,
14630 and to avoid potential problems with integer overflow.
9248994d 14631 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14632 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14633 * editfns.c (Fformat): Likewise.
1e69125e 14634 * syntax.c (skip_chars): Likewise.
3befa583 14635
e3019616
PE
14636 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14637 This also lets GCC 4.6.0 generate slightly better loop code.
14638
becfa255
PE
14639 * callint.c (Fcall_interactively): <, not <=, for optimization.
14640 (Fcall_interactively): Count the number of arguments produced,
14641 not the number of arguments given. This is simpler and lets GCC
14642 4.6.0 generate slightly better code.
14643
dae0cd48
PE
14644 * ftfont.c: Distingish more carefully between FcChar8 and char.
14645 The previous code passed unsigned char * to a functions like
14646 strlen and xstrcasecmp that expect char *, which does not
14647 conform to the C standard.
14648 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14649 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14650 char * when the C standard requires it.
14651
76032d70
PE
14652 * keyboard.c (read_char): Remove unused var.
14653
eb3f1cc8
PE
14654 * eval.c: Port to Windows vsnprintf (Bug#8435).
14655 Include <limits.h>.
14656 (SIZE_MAX): Define if the headers do not.
14657 (verror): Do not give up if vsnprintf returns a negative count.
14658 Instead, grow the buffer. This ports to Windows vsnprintf, which
14659 does not conform to C99. Problem reported by Eli Zaretskii.
14660 Also, simplify the allocation scheme, by avoiding the need for
14661 calling realloc, and removing the ALLOCATED variable.
14662
70476b54
PE
14663 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14664
12020a9e
PE
14665 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14666 But keep the doprint source code for now, as we might revamp it
14667 and use it again (Bug#8435).
ea6c7ae6
PE
14668 * lisp.h (doprnt): Remove.
14669 * Makefile.in (base_obj): Remove doprnt.o.
14670 * deps.mk (doprnt.o): Remove.
14671
5fdb398c
PE
14672 error: Print 32- and 64-bit integers portably (Bug#8435).
14673 Without this change, on typical 64-bit hosts error ("...%d...", N)
14674 was used to print both 32- and 64-bit integers N, which relied on
14675 undefined behavior.
61bdb816 14676 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14677 * lisp.h (error, verror): Mark as printf-like functions.
14678 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14679 Report overflow in size calculations when allocating printf buffer.
14680 Do not truncate output string at its first null byte.
14681 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14682 Truncate the output at a character boundary, since vsnprintf does not
14683 do that.
14684 * charset.c (check_iso_charset_parameter): Convert internal
14685 character to string before calling 'error', since %c now has the
14686 printf meaning.
14687 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14688 overflow when computing char to be passed to 'error'. Do not
14689 pass Lisp_Object to 'error'; pass the integer instead.
14690 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14691 formatted with plain %d.
14692
b189fa66
PE
14693 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14694
bff87ef0
PE
14695 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14696
7e2cac20
PE
14697 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14698
ce4d90b5
PE
14699 * xterm.c (x_catch_errors): Remove duplicate declaration.
14700
266c9547
PE
14701 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14702
79c49ad2
PE
14703 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14704
368f4090
JM
147052011-04-10 Jim Meyering <meyering@redhat.com>
14706
14707 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14708 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14709 return ssize_t not "int", and use size_t as the buffer length.
14710 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14711 * gnutls.h: Update declarations.
14712 * process.c (read_process_output): Use ssize_t, to match.
14713 (send_process): Likewise.
14714
a32d4040
CY
147152011-04-09 Chong Yidong <cyd@stupidchicken.com>
14716
14717 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14718
8546720e 147192011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14720
04f2d78b
CB
14721 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14722 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14723
8546720e
GM
14724 * xterm.c (handle_one_xevent):
14725 * xmenu.c (create_and_show_popup_menu):
14726 * xselect.c (x_decline_selection_request)
14727 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14728
0a2f5c1a 147292011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14730
14731 Fix some uses of `int' instead of EMACS_INT.
14732 * search.c (string_match_1, fast_string_match)
14733 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14734 (scan_buffer, find_next_newline_no_quit)
14735 (find_before_next_newline, search_command, Freplace_match)
14736 (Fmatch_data): Make some `int' variables be EMACS_INT.
14737
14738 * xdisp.c (display_count_lines): 3rd argument and return value now
14739 EMACS_INT. All callers changed.
14740 (pint2hrstr): Last argument is now EMACS_INT.
14741
14742 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14743 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14744 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14745 (decode_coding_utf_16, decode_coding_emacs_mule)
14746 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14747 (decode_coding_ccl, decode_coding_charset)
14748 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14749 (decode_coding_iso_2022, decode_coding_emacs_mule)
14750 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14751 <char_offset, last_offset>: Declare EMACS_INT.
14752 (encode_coding_utf_8, encode_coding_utf_16)
14753 (encode_coding_emacs_mule, encode_invocation_designation)
14754 (encode_designation_at_bol, encode_coding_iso_2022)
14755 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14756 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14757 Declare EMACS_INT.
14758 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14759 (encode_invocation_designation): Last argument P_NCHARS is now
14760 EMACS_INT.
14761 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14762 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14763
14764 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14765 All users changed.
14766
14767 * ccl.c (Fccl_execute_on_string): Declare some variables
14768 EMACS_INT.
14769
8546720e 147702011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14771
14772 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14773
4e19a977
CS
147742011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14775
14776 * process.c (Fformat_network_address): Doc fix.
14777
87302331
R
147782011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14779
ee7683eb 14780 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14781
cbb59342
CY
147822011-04-08 Chong Yidong <cyd@stupidchicken.com>
14783
14784 * keyboard.c (read_char): Call Lisp function help-form-show,
14785 instead of using internal_with_output_to_temp_buffer.
14786 (Qhelp_form_show): New var.
e0d38eeb 14787 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14788
14789 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14790
14791 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14792
e67a13ab
CY
147932011-04-06 Chong Yidong <cyd@stupidchicken.com>
14794
04f2d78b
CB
14795 * process.c (Flist_processes): Remove to Lisp.
14796 (list_processes_1): Delete.
e67a13ab 14797
973f782d
EZ
147982011-04-06 Eli Zaretskii <eliz@gnu.org>
14799
7c106b1e
EZ
14800 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14801
973f782d
EZ
14802 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14803
41cf7d1a 148042011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14805
ca23cc88
PE
14806 Fix more problems found by GCC 4.6.0's static checks.
14807
f390e2d5
PE
14808 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14809
42eea0d0
PE
14810 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14811
b69769da 14812 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14813
f9541e84
PE
14814 * xdisp.c (vmessage): Mark as a printf-like function.
14815
13841b55
PE
14816 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14817
c136c10f
PE
14818 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14819
5e2d4a30
PE
14820 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14821 printf-like functions.
14822 (tiff_load): Add casts to remove these marks before passing them
14823 to system-supplied API.
14824
583f48b9
PE
14825 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14826
b25d760e
PE
14827 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14828 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14829 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14830 directly, rather than having caller test rule sign. This avoids
14831 some unnecessary tests.
14832 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14833 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14834 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14835
bc7b6697 14836 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14837 (xfont_open): Avoid unnecessary tests.
bc7b6697 14838
27ccc379
PE
14839 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14840
dcd5c89a
PE
14841 * composite.h, composite.c (composition_gstring_put_cache):
14842 Use EMACS_INT, not int, for length.
14843
b13a45c6
PE
14844 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14845 breaking out part of COMPOSITION_DECODE_RULE.
14846 (COMPOSITION_DECODE_RULE): Use it.
14847 * composite.c (get_composition_id): Remove unused local vars,
14848 by using the new macro.
14849
1e792e4d
PE
14850 * textprop.c (set_text_properties_1): Change while to do-while,
14851 since the condition is always true at first.
14852
dc6c6455 14853 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14854 (interval_deletion_adjustment): Return unsigned value.
14855 All uses changed.
dc6c6455 14856
aba7731a
PE
14857 * process.c (list_processes_1, create_pty, read_process_output):
14858 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14859 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14860 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14861 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14862 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14863
fdfc4bf3
PE
14864 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14865
fca8fe46 14866 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14867 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14868
06a0259a 14869 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14870 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14871 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14872
e7b9e80f
PE
14873 * print.c (print_error_message): Avoid int overflow.
14874
56201685
PE
14875 * font.c (font_list_entities): Redo for clarity,
14876 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14877
78834453 14878 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14879 (font_score): Avoid potential overflow in diff calculation.
78834453 14880
0bc0b309 14881 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14882 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14883
e610eaca
PE
14884 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14885
b895abce
PE
14886 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14887 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14888 can always succeed if overflow has undefined behavior.
14889
1f1d9321 14890 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14891 (wordify): Omit three unnecessary tests.
1f1d9321 14892
c59478bc
PE
14893 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14894 All callers changed. This avoids the need for an unused var.
14895
79b73827
PE
14896 * casefiddle.c (casify_region): Remove var that is set but not used.
14897
a4db5dfe
PE
14898 * dired.c (file_name_completion): Remove var that is set but not used.
14899
43aae36e
PE
14900 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14901
2a47c44d 14902 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14903 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14904
a37c69bf
PE
14905 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14906 Check for integer overflow on size calculations.
14907
328ab8e7
PE
14908 * buffer.c (Fprevious_overlay_change): Remove var that is set
14909 but not used.
14910
e5a2a5cb
PE
14911 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14912 Remove vars that are set but not used.
8d84a6eb 14913 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14914 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14915
a60e5f68
PE
14916 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14917
f661cb61 14918 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14919 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14920
f0397f5a
PE
14921 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14922 that are set but not used.
14923
8664db06 14924 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14925 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14926
6abdaa4a
PE
14927 * xselect.c (x_get_local_selection, x_handle_property_notify):
14928 Remove vars that are set but not used.
14929
0ce7538d 14930 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14931 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14932
9ae848fc
PE
14933 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14934 Remove var that is set but not used.
0b918413
PE
14935 (scroll_bar_windows_size): Now size_t, not int.
14936 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14937 Check for overflow.
9ae848fc 14938
a5a62657
PE
14939 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14940 (map_tty_color) [!defined MSDOS]: Likewise.
14941
5c5cdd39
PE
14942 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14943
66ebf983
PE
14944 * coding.c: Remove vars that are set but not used.
14945 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14946 All callers changed.
14947 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14948 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14949 (decode_coding_charset): Remove vars that are set but not used.
14950
1be4d761
PE
14951 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14952 that is set but not used.
14953
47553fa8
PE
14954 * print.c (print_object): Remove var that is set but not used.
14955
1f7196bf 14956 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14957 The gnulib version avoids calling malloc in the usual case,
14958 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14959 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14960 * filelock.c (current_lock_owner): Likewise.
14961 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14962 * sysdep.c: Include allocator.h, careadlinkat.h.
14963 (emacs_no_realloc_allocator): New static constant.
14964 (emacs_readlink): New function.
fdb61804
PE
14965 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14966 ../lib/careadlinkat.h.
d1fdcab7 14967
f84c17c7
SM
149682011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14969
14970 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14971 first non-nil return value).
14972
ef3862ad
JD
149732011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14974
14975 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14976 if not defined (Bug#8403).
14977
376a7006
JB
149782011-04-02 Juanma Barranquero <lekktu@gmail.com>
14979
14980 * xdisp.c (display_count_lines): Remove parameter `start',
14981 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14982 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14983 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14984 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14985 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14986 and thereabouts. All callers changed.
14987 (get_per_char_metric): Remove parameter `f', unused since
14988 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14989
6ca3801d
JM
149902011-04-02 Jim Meyering <meyering@redhat.com>
14991
14992 do not dereference NULL upon failed strdup
14993 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14994 (ns_get_family): Likewise.
14995
d8e2b5ba
JB
149962011-04-02 Juanma Barranquero <lekktu@gmail.com>
14997
14998 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14999
8c74fcbd
JD
150002011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15001
15002 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15003 later (Bug#8403).
15004
7200d79c
SM
150052011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15006
03408648 15007 Add lexical binding.
7200d79c 15008
03408648
SM
15009 * window.c (Ftemp_output_buffer_show): New fun.
15010 (Fsave_window_excursion):
15011 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15012
15013 * lread.c (lisp_file_lexically_bound_p): New function.
15014 (Fload): Bind Qlexical_binding.
15015 (readevalloop): Remove `evalfun' arg.
15016 Bind Qinternal_interpreter_environment.
15017 (Feval_buffer): Bind Qlexical_binding.
15018 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15019 Mark as dynamic.
15020 (syms_of_lread): Declare `lexical-binding'.
15021
15022 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15023
15024 * keyboard.c (eval_dyn): New fun.
15025 (menu_item_eval_property): Use it.
ca105506
SM
15026
15027 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15028
03408648
SM
15029 * fns.c (concat, mapcar1): Accept byte-code-functions.
15030
15031 * eval.c (Fsetq): Handle lexical vars.
15032 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15033 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15034 (FletX, Flet): Obey lexical binding.
15035 (Fcommandp): Handle closures.
15036 (Feval): New `lexical' arg.
15037 (eval_sub): New function extracted from Feval. Use it almost
15038 everywhere where Feval was used. Look up vars in lexical env.
15039 Handle closures.
15040 (Ffunctionp): Move from subr.el.
15041 (Ffuncall): Handle closures.
15042 (apply_lambda): Remove `eval_flags'.
15043 (funcall_lambda): Handle closures and new byte-code-functions.
15044 (Fspecial_variable_p): New function.
15045 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15046 but without exporting it to Lisp.
23aba0ea 15047
23aba0ea 15048 * doc.c (Fdocumentation, store_function_docstring):
03408648 15049 * data.c (Finteractive_form): Handle closures.
23aba0ea 15050
03408648
SM
15051 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15052 interactive spec.
ba83908c 15053
04f2d78b
CB
15054 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15055 New byte-codes.
03408648
SM
15056 (exec_byte_code): New function extracted from Fbyte_code to handle new
15057 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15058
03408648 15059 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15060
03408648 15061 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15062
e2abce01
JB
150632011-03-31 Juanma Barranquero <lekktu@gmail.com>
15064
15065 * xdisp.c (redisplay_internal): Fix prototype.
15066
63696a73 150672011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15068
63696a73 15069 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15070 (try_scrolling): Use it when setting scroll_limit.
15071 Limit scrolling to 100 screen lines.
63696a73
EZ
15072 (redisplay_window): Even when falling back on "recentering",
15073 position point in the window according to scroll-conservatively,
15074 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15075
15076 (try_scrolling): When point is above the window, allow searching
15077 as far as scroll_max, or one screenful, to compute vertical
15078 distance from PT to the scroll margin position. This prevents
15079 try_scrolling from unnecessarily failing when
15080 scroll-conservatively is set to a value slightly larger than the
15081 window height. Clean up the case of PT below the margin at bottom
15082 of window: scroll_max can no longer be INT_MAX. When aggressive
15083 scrolling is in use, don't let point enter the opposite scroll
15084 margin as result of the scroll.
15085 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15086 threshold of 100 lines for never-recentering scrolling.
15087
e4cc2dfc
JB
150882011-03-31 Juanma Barranquero <lekktu@gmail.com>
15089
15090 * dispextern.h (move_it_by_lines):
15091 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15092 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15093 (message_log_check_duplicate): Remove parameters `prev_bol' and
15094 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15095 (redisplay_internal): Remove parameter `preserve_echo_area',
15096 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15097
15098 * indent.c (Fvertical_motion):
15099 * window.c (window_scroll_pixel_based, Frecenter):
15100 Don't pass `need_y_p' to `move_it_by_lines'.
15101
1c470562
SM
151022011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15103
44f230aa
SM
15104 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15105 steal a few bits to be more compact.
15106 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15107 Remove unneeded casts.
15108
1c470562
SM
15109 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15110
888adce9
ZK
151112011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15112
15113 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15114 binding" message (bug#7967).
15115
f838ed7b
PE
151162011-03-30 Paul Eggert <eggert@cs.ucla.edu>
15117
77861b95
PE
15118 Fix more problems found by GCC 4.6.0's static checks.
15119
de6dbc14
PE
15120 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15121 Remove unused local var.
15122
f838ed7b
PE
15123 * editfns.c (Fmessage_box): Remove unused local var.
15124
792c7b2b
PE
15125 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15126 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15127 Omit unused local vars.
c499e557 15128 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15129 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15130 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15131 Omit unused local var.
15132
ba0165e1
PE
15133 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15134 Don't assume string length fits in int.
32ad8845 15135 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15136 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15137
3c59b4c9
PE
15138 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15139 instead of alloca (Bug#8344).
15140
a3eed478 15141 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15142 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15143
eb4d412d
PE
15144 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15145
1658b401
PE
15146 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15147 concerns.
15148
15149 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15150
15151 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15152
9a2c6e05
PE
15153 * keyboard.c (syms_of_keyboard): Use the same style as later
15154 in this function when indexing through an array. This also
15155 works around GCC bug 48267.
15156
03d0a109
PE
15157 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15158
44f730c8
PE
15159 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15160
fe75f926
PE
15161 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15162 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15163
ffa8c828
PE
15164 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15165 This avoids undefined behavior on integer overflow, and is a bit
15166 more convenient anyway since it is compared to a size_t variable.
15167
c5101a77
PE
15168 Variadic C functions now count arguments with size_t, not int.
15169 This avoids an unnecessary limitation on 64-bit machines, which
15170 caused (substring ...) to crash on large vectors (Bug#8344).
15171 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15172 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15173 All variadic functions and their callers changed accordingly.
c5101a77
PE
15174 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15175 * data.c (arith_driver, float_arith_driver): Likewise.
15176 * editfns.c (general_insert_function): Likewise.
15177 * eval.c (struct backtrace.nargs, interactive_p)
15178 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15179 (funcall_lambda, mark_backtrace): Likewise.
15180 * fns.c (concat): Likewise.
15181 * frame.c (x_set_frame_parameters): Likewise.
15182 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15183 0 if not found, not -1. All callers changed.
15184
dd3f25f7
PE
15185 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15186 (stack_copy_size): Now size_t, not int.
15187 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15188
461c2ab9
JB
151892011-03-28 Juanma Barranquero <lekktu@gmail.com>
15190
15191 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15192 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15193 All callers changed.
15194
15195 * lisp.h (multibyte_char_to_unibyte):
15196 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15197 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15198 * character.h (CHAR_TO_BYTE8):
15199 * cmds.c (internal_self_insert):
15200 * editfns.c (general_insert_function):
15201 * keymap.c (push_key_description):
15202 * search.c (Freplace_match):
15203 * xdisp.c (message_dolog, set_message_1): All callers changed.
15204
f6d62986
SM
152052011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15206
15207 * keyboard.c (safe_run_hook_funcall): New function.
15208 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
15209 don't set the hook to nil, but remove the offending function instead.
15210 (Qcommand_hook_internal): Remove, unused.
15211 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
15212 Vcommand_hook_internal.
15213
15214 * eval.c (enum run_hooks_condition): Remove.
15215 (funcall_nil, funcall_not): New functions.
15216 (run_hook_with_args): Call each function through a `funcall' argument.
15217 Remove `cond' argument, now redundant.
15218 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
15219 (Frun_hook_with_args_until_failure): Adjust accordingly.
15220 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
15221
1db5b1ad
JB
152222011-03-28 Juanma Barranquero <lekktu@gmail.com>
15223
15224 * dispextern.h (string_buffer_position): Remove declaration.
15225
15226 * print.c (strout): Remove parameter `multibyte', unused since
15227 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
15228
15229 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
15230 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
15231 All callers changed.
15232
15233 * w32.c (_wsa_errlist): Use braces for struct initializers.
15234
15235 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
15236 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
15237 All callers changed.
15238 (string_buffer_position): Likewise. Also, make static (it's never
15239 used outside xdisp.c).
15240 (cursor_row_p): Remove parameter `w', unused since
15241 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
15242 (decode_mode_spec): Remove parameter `precision', introduced during
15243 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
15244 All callers changed.
15245
5ffb62aa
JD
152462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15247
15248 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
15249
461c2ab9 152502011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
15251
15252 * nsterm.m (ns_menu_bar_is_hidden): New variable.
15253 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
15254 (ns_update_auto_hide_menu_bar): New functions.
15255 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
15256 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
15257 ns_constrain_all_frames.
15258 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
15259 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
15260
5c380ffb
JD
152612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15262
15263 * nsmenu.m (runDialogAt): Remove argument to timer_check.
15264
9af30bdf
GM
152652011-03-27 Glenn Morris <rgm@gnu.org>
15266
15267 * syssignal.h: Replace RETSIGTYPE with void.
15268 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
15269 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
15270 Replace SIGTYPE with void everywhere.
15271 * s/usg5-4-common.h (SIGTYPE): Remove definition.
15272 * s/template.h (SIGTYPE): Remove commented out definition.
15273
e2abce01
JB
152742011-03-26 Eli Zaretskii <eliz@gnu.org>
15275
15276 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
15277 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
15278
f868cd8a
JB
152792011-03-26 Juanma Barranquero <lekktu@gmail.com>
15280
59eb0929
JB
15281 * w32.c (read_unc_volume): Use parameter `henum', instead of
15282 global variable `wget_enum_handle'.
15283
15284 * keymap.c (describe_vector): Remove parameters `indices' and
15285 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
15286 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
15287
f868cd8a
JB
15288 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
15289
15290 * keyboard.c (timer_check): Remove parameter `do_it_now',
15291 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
15292 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
15293 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
15294
15295 * keyboard.c (read_char):
15296 * w32menu.c (w32_menu_display_help):
15297 * xmenu.c (show_help_event, menu_help_callback):
15298 Adjust calls to `show_help_echo'.
15299
15300 * gtkutil.c (xg_maybe_add_timer):
15301 * keyboard.c (readable_events):
15302 * process.c (wait_reading_process_output):
15303 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
15304
15305 * insdel.c (adjust_markers_gap_motion):
15306 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
15307 (gap_left, gap_right): Don't call it.
15308
2ecf6fdb
CY
153092011-03-25 Chong Yidong <cyd@stupidchicken.com>
15310
15311 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
15312 incurred during fontification.
15313
6b1f9ba4
JB
153142011-03-25 Juanma Barranquero <lekktu@gmail.com>
15315
15316 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
15317 (DEFVAR_PER_BUFFER): Don't pass it.
15318
15319 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
15320 (scrolling_window): Don't pass it.
15321
0f4a96b5
JB
153222011-03-25 Juanma Barranquero <lekktu@gmail.com>
15323
15324 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
15325
15326 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
15327 and `suffix'.
15328 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
15329 of variables specific to SELinux and computation of `encoded_absname'.
15330
15331 * image.c (XPutPixel): Remove unused variable `height'.
15332
15333 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
15334
15335 * unexw32.c (get_section_info): Remove unused variable `section'.
15336
15337 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
15338 (system_process_attributes): Remove unused variable `sess'.
15339 (sys_read): Remove unused variable `err'.
15340
15341 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
15342 (w32_wnd_proc): Remove unused variable `isdead'.
15343 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
15344 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
15345 (x_create_tip_frame): Remove unused variable `tem'.
15346
15347 * w32inevt.c (w32_console_read_socket):
15348 Remove unused variable `no_events'.
15349
15350 * w32term.c (x_draw_composite_glyph_string_foreground):
15351 Remove unused variable `width'.
15352
1149507c
JB
153532011-03-24 Juanma Barranquero <lekktu@gmail.com>
15354
15355 * w32term.c (x_set_glyph_string_clipping):
15356 Don't pass uninitialized region to CombineRgn.
15357
9c88f339
JB
153582011-03-23 Juanma Barranquero <lekktu@gmail.com>
15359
15360 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
15361 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
15362 (Fx_close_connection): Remove unused variable `i'.
15363
15364 * w32font.c (w32font_draw): Return number of glyphs.
15365 (w32font_open_internal): Remove unused variable `i'.
15366 (w32font_driver): Add missing initializer.
15367
15368 * w32menu.c (utf8to16): Remove unused variable `utf16'.
15369 (fill_in_menu): Remove unused variable `items_added'.
15370
15371 * w32term.c (last_mouse_press_frame): Remove static global variable.
15372 (w32_clip_to_row): Remove unused variable `f'.
15373 (x_delete_terminal): Remove unused variable `i'.
15374
15375 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
15376 (NOTHING): Remove unused static global variable.
15377 (uniscribe_check_otf): Remove unused variable `table'.
15378 (uniscribe_font_driver): Add missing initializers.
15379
dee091a3
JD
153802011-03-23 Julien Danjou <julien@danjou.info>
15381
15382 * term.c (Fsuspend_tty, Fresume_tty):
15383 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
15384 * window.c (temp_output_buffer_show):
15385 * insdel.c (signal_before_change):
15386 * frame.c (Fhandle_switch_frame):
15387 * fileio.c (Fdo_auto_save):
15388 * emacs.c (Fkill_emacs):
15389 * editfns.c (save_excursion_restore):
15390 * cmds.c (internal_self_insert):
15391 * callint.c (Fcall_interactively):
15392 * buffer.c (Fkill_all_local_variables):
15393 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
15394 Use Frun_hooks.
0f4a96b5 15395 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 15396 unconditionally since it does the check itself.
dee091a3 15397
2c520ab5 153982011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 15399
c9c49752
PE
15400 Fix more problems found by GCC 4.5.2's static checks.
15401
8abc3f12
PE
15402 * coding.c (encode_coding_raw_text): Avoid unnecessary test
15403 the first time through the loop, since we know p0 < p1 then.
15404 This also avoids a gcc -Wstrict-overflow warning.
15405
a2d26660
PE
15406 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
15407 leading to a memory leak, possible in functions like
15408 load_charset_map_from_file that can allocate an unbounded number
b12ef411 15409 of objects (Bug#8318).
a2d26660 15410
916c72e9
PE
15411 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
15412 that could (at least in theory) be that large.
15413
19ab8a18
PE
15414 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
15415 This is less likely to overflow, and avoids undefined behavior if
15416 overflow does occur. All callers changed. Use strtoul to scan
15417 for the unsigned long integer.
b7cbbd6f
PE
15418 (pint2hrstr): Simplify and tune code slightly.
15419 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 15420
f0641eff
PE
15421 * scroll.c (do_scrolling): Work around GCC bug 48228.
15422 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
15423
7f650bb9
PE
15424 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
15425 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
15426 (validate_x_resource_name): Simplify count usage.
15427 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 15428
37dd57d1
PE
15429 * fileio.c (Fcopy_file): Report error if fchown or fchmod
15430 fail (Bug#8306).
81e56e61 15431
699979fc 15432 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 15433
401bf9b4
PE
15434 * process.c (Fmake_network_process): Use socklen_t, not int,
15435 where POSIX says socklen_t is required in portable programs.
15436 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 15437 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
15438 (Fmake_network_process, server_accept_connection):
15439 (wait_reading_process_output, read_process_output):
15440 Likewise.
15441
b93aacde
PE
15442 * process.c: Rename or move locals to avoid shadowing.
15443 (list_processes_1, Fmake_network_process):
15444 (read_process_output_error_handler, exec_sentinel_error_handler):
15445 Rename or move locals.
4dc343ee 15446 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 15447 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 15448 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 15449 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 15450 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 15451
af8a867c 15452 Make tparam.h and terminfo.c consistent.
44f230aa
SM
15453 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
15454 Include tparam.h instead, since it declares them.
af8a867c
PE
15455 * cm.h (PC): Remove extern decl; tparam.h now does this.
15456 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
15457 * terminfo.c: Include tparam.h, to check interfaces.
15458 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
15459 (tparam): Adjust signature to match interface in tparam.h;
15460 this removes some undefined behavior. Check that outstring and len
15461 are zero, which they always are with Emacs.
15462 * tparam.h (PC, BC, UP): New extern decls.
15463
0248044d 15464 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 15465 (xftfont_open): Rename locals to avoid shadowing.
0248044d 15466
8ff096c1 15467 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
15468 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
15469 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 15470 (ftfont_list): Remove unused local.
49eaafba
PE
15471 (get_adstyle_property, ftfont_pattern_entity):
15472 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
15473 Rename locals to avoid shadowing.
8ff096c1 15474
e2be39f6
PE
15475 * xfont.c (xfont_list_family): Mark var as initialized.
15476
c9735e30
PE
15477 * xml.c (make_dom): Now static.
15478
8f5201ae
PE
15479 * composite.c (composition_compute_stop_pos): Rename local to
15480 avoid shadowing.
b246f932
PE
15481 (composition_reseat_it): Remove unused locals.
15482 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 15483 (composition_update_it): Mark var as initialized.
11b61122
PE
15484 (find_automatic_composition): Mark vars as initialized,
15485 with a FIXME (Bug#8290).
8f5201ae 15486
760fbc2c
PE
15487 character.h: Rename locals to avoid shadowing.
15488 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15489 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15490 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15491 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15492 to avoid shadowing.
15493
ff08eb85
PE
15494 * textprop.c (property_change_between_p): Remove; unused.
15495
fc7bf025
PE
15496 * intervals.c (interval_start_pos): Now static.
15497
235d7abc
PE
15498 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15499
44f230aa
SM
15500 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15501 Rename locals to avoid shadowing.
3e7d6594 15502
50060332
PE
15503 * sound.c (wav_play, au_play, Fplay_sound_internal):
15504 Fix pointer signedness.
d01f234b 15505 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15506 (wav_play): Initialize a variable to 0, to prevent undefined
15507 behavior (Bug#8278).
50060332 15508
c4fc4e30
PE
15509 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15510
918436ed
PE
15511 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15512
c939f91b
PE
15513 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15514 clobbering (Bug#8298).
b9c7f648
PE
15515 * sysdep.c (sys_subshell): Likewise.
15516 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15517
6bd8c144
PE
15518 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15519 This should get cleaned up, so that child_setup has the
15520 same signature on all platforms.
15521
7710357c 15522 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15523 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15524
c59da222
CY
155252011-03-22 Chong Yidong <cyd@stupidchicken.com>
15526
15527 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15528 not to be necessary, and produces flickering.
15529
66b87493
GM
155302011-03-20 Glenn Morris <rgm@gnu.org>
15531
15532 * config.in: Remove file.
15533
45b6f6d5
JB
155342011-03-20 Juanma Barranquero <lekktu@gmail.com>
15535
15536 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15537 are now in src/globals.h.
15538 (syms_of_minibuf): Remove spurious & from previous change.
15539
cd394be1 155402011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15541
15542 * minibuf.c (completing-read-function): New variable.
15543 (completing-read-default): Rename from completing-read.
15544 (completing-read): Call completing-read-function.
15545
b14e3e21
CY
155462011-03-19 Juanma Barranquero <lekktu@gmail.com>
15547
15548 * xfaces.c (Fx_load_color_file):
15549 Read color file from absolute filename (bug#8250).
15550
f2b726e6
JB
155512011-03-19 Juanma Barranquero <lekktu@gmail.com>
15552
15553 * makefile.w32-in: Update dependencies.
15554
09f6ff02
EZ
155552011-03-17 Eli Zaretskii <eliz@gnu.org>
15556
15557 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15558
29a6015a
PE
155592011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15560
a3a6c54e
PE
15561 Fix more problems found by GCC 4.5.2's static checks.
15562
b766f867
PE
15563 * process.c (make_serial_process_unwind, send_process_trap):
15564 (sigchld_handler): Now static.
15565
be02381c
PE
15566 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15567 That way, the code declares only the vars that it needs.
15568 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15569 * s/cygwin.h (PTY_ITERATION): Likewise.
15570 * s/darwin.h (PTY_ITERATION): Likewise.
15571 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15572
57048744
PE
15573 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15574 * process.c (allocate_pty): Don't declare stb unless it's needed.
15575
7914961c 15576 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15577 (CONSTANTLIM): Remove; unused.
15578 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15579 Define only if needed.
7914961c 15580
b3967b18
PE
15581 * unexelf.c (unexec): Name an expression,
15582 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15583 Use a different way to cause a compilation error if anyone uses
15584 n rather than nn, a way that does not involve shadowing.
73366a00 15585 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15586
29a6015a
PE
15587 * deps.mk (unexalpha.o): Remove; unused.
15588
43cfc33e 15589 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15590 * unexec.h: New file.
ce701a33
PE
15591 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15592 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15593 Depend on unexec.h.
15594 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15595 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15596 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15597 Change as necessary to match prototype in unexec.h.
ce701a33 15598
01f44d5a
PE
15599 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15600 shadowing.
4f63c6bb 15601 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15602
a6670b0b
PE
15603 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15604 Rename locals to avoid shadowing.
15605
cef2010d 15606 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15607 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15608
d4d7173a
PE
15609 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15610
f08b802a
PE
15611 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15612 warning when compiling print.c.
15613
3ddb0639
PE
15614 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15615 instead of using an uninitialized var.
5ad03b97 15616 (font_sort_entities): Mark var as initialized.
3ddb0639 15617
170a2692
PE
15618 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15619
e663c700
PE
15620 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15621 pointers to constants.
89bc529a 15622 (font_parse_fcname): Remove unused vars.
7b81e2d0 15623 (font_delete_unmatched): Now static.
ea838e10 15624 (font_get_spec): Remove; unused.
13a547c6
PE
15625 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15626 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15627 Rename or move locals to avoid shadowing.
e663c700 15628
2a80c887 15629 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15630 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15631
1384fa33 15632 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15633 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15634
8b2c52e9
PE
15635 * alloc.c (mark_backtrace): Move decl from here ...
15636 * lisp.h: ... to here, so that it can be checked.
15637
475545b5 15638 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15639 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15640 (lisp_indirect_variable): Name an expression,
15641 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15642 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15643
b1349114 15644 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15645 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15646 Use const pointer when appropriate.
b1349114 15647
a2928364
PE
15648 * lisp.h (get_system_name, get_operating_system_release):
15649 Move decls here, to check interfaces.
15650 * process.c (get_operating_system_release): Move decl to lisp.h.
15651 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15652 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15653 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15654 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15655 (Fformat_time_string, Fencode_time, Finsert_char):
15656 (Ftranslate_region_internal, Fformat):
15657 Rename or remove local vars to avoid shadowing.
9710023e 15658 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15659
a415e694
PE
15660 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15661 avoid shadowing.
15662
8ef4622d
PE
15663 * lisp.h (eassert): Check that the argument compiles, even if
15664 ENABLE_CHECKING is not defined.
15665
946f9a5b
PE
15666 * data.c (Findirect_variable): Name an expression, to avoid
15667 gcc -Wbad-function-cast warning.
112396d6 15668 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15669 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15670 (Fmake_variable_buffer_local, Fmake_local_variable):
15671 Mark variables as initialized.
52746918 15672 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15673
e5aab7e7 15674 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15675 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15676 Rename locals to avoid shadowing.
dff45157
PE
15677 (mark_stack): Move local variables into the #ifdef region where
15678 they're used.
7bc26fdb
PE
15679 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15680 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15681 needed otherwise.
15682 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15683 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15684 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15685
e5aab7e7
PE
15686 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15687 avoids undefined behavior in theory.
15688
4da60324
PE
15689 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15690
88043301
PE
15691 Use functions, not macros, for up- and down-casing (Bug#8254).
15692 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15693 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15694 to use the following functions instead of these macros.
15695 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15696 EMACS_INT, since callers assume the returned value fits in int.
15697 (upcase1): Likewise, for UPCASE_TABLE.
15698 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15699 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15700 the race-condition problem in the old DOWNCASE.
88043301 15701
19ed5445
PE
15702 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15703 Rename locals to avoid shadowing.
15704 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15705 (regex_compile, re_search_2, re_match_2_internal):
15706 Remove unused local vars.
952db0d7
PE
15707 (FREE_VAR): Rewrite so as not to use empty "else",
15708 which gcc can warn about.
da053e48 15709 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15710 (RETALLOC_IF): Define only if needed.
15711 (WORDCHAR_P): Likewise. This one is never needed, but is used
15712 only in a comment talking about a compiler bug, so put inside
15713 the #if 0 of that comment.
15714 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15715 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15716 Remove; unused.
19ed5445 15717
1f3561e4 15718 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15719 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15720 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15721
ded6f8f7
PE
15722 * search.c (simple_search): Remove unused var.
15723
dbd37a95
PE
15724 * dired.c (compile_pattern): Move decl from here ...
15725 * lisp.h: ... to here, so that it can be checked.
15726 (struct re_registers): New forward decl.
15727
7e47afad
PE
15728 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15729
85f24f61
PE
15730 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15731 All uses changed.
15732 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15733 Rename locals to avoid shadowing.
5671df8f 15734 (Fvertical_motion): Mark locals as initialized.
85f24f61 15735
181aa2be 15736 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15737 (casify_region): Mark local as initialized.
181aa2be 15738
930d429c
PE
15739 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15740
7082eac6
PE
15741 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15742 New macros, so that the caller can use some names other than
15743 gcpro1, gcpro2, etc.
15744 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15745 of the new macros.
15746 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15747 argument, for consistency with GCPRO2_VAR, etc: it is now the
15748 prefix of the variable, not the variable itself. All uses
15749 changed.
38b2c076
PE
15750 * dired.c (directory_files_internal, file_name_completion):
15751 Rename locals to avoid shadowing.
15752
15206ed9
PE
15753 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15754 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15755 dired.c's scmp function, had undefined behavior.
15756 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15757 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15758 * buffer.h: ... to here, because these macros use current_buffer,
15759 and the new implementation with inline functions needs to have
15760 current_buffer in scope now, rather than later when the macros
15761 are used.
15762 (downcase, upcase1): New static inline functions.
15763 (DOWNCASE, UPCASE1): Reimplement using these functions.
15764 This avoids undefined behavior in expressions like
15765 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15766 from race conditions in accessing the global variables
15767 case_temp1 and case_temp2.
15768 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15769 * lisp.h (case_temp1, case_temp2): Remove their decls.
15770 * character.h (ASCII_CHAR_P): Move from here ...
15771 * lisp.h: ... to here, so that the inline functions mentioned
15772 above can use them.
15773
4a6bea26
PE
15774 * dired.c (directory_files_internal_unwind): Now static.
15775
f14b7e14
PE
15776 * fileio.c (file_name_as_directory, directory_file_name):
15777 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15778 Now static.
2893f146
PE
15779 (file_name_as_directory): Use const pointers when appropriate.
15780 (Fexpand_file_name): Likewise. In particular, newdir might
15781 point at constant storage, so make it a const pointer.
fd4ead52 15782 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15783 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15784 signedness issues.
f839df0c
PE
15785 (Fset_file_times, Finsert_file_contents, auto_save_error):
15786 Rename locals to avoid shadowing.
f14b7e14 15787
5716756e 15788 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15789 (Ftry_completion, Fall_completions): Rename or remove locals
15790 to avoid shadowing.
5716756e 15791
b4c3046a
PE
15792 * marker.c (bytepos_to_charpos): Remove; unused.
15793
b45db522
PE
15794 * lisp.h (verify_bytepos, count_markers): New decls,
15795 so that gcc does not warn that these functions aren't declared.
15796
85876d07
PE
15797 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15798 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15799 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15800 (copy_text): Remove unused local var.
85876d07 15801
03d78a21 15802 * filelock.c (within_one_second): Now static.
b3dd38ab 15803 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15804
5df8f01b
PE
15805 * buffer.c (fix_overlays_before): Mark locals as initialized.
15806 (fix_start_end_in_overlays): Likewise. This function should be
15807 simplified by using pointers-to-pointers, but that's a different
15808 matter.
b1d876f1 15809 (switch_to_buffer_1): Now static.
8f54f30a
PE
15810 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15811 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15812
a70072c9 15813 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15814 Fix pointer signedness issue.
edced198
PE
15815 (sys_subshell): Mark local as volatile if checking for lint,
15816 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15817 (MAXPATHLEN): Define only if needed.
a70072c9 15818
a0977c44
PE
15819 * process.c (serial_open, serial_configure): Move decls from here ...
15820 * systty.h: ... to here, so that they can be checked.
15821
a884fdcc
PE
15822 * fns.c (get_random, seed_random): Move extern decls from here ...
15823 * lisp.h: ... to here, so that they can be checked.
15824
604efe86 15825 * sysdep.c (reset_io): Now static.
b8950c94 15826 (wait_for_termination_signal): Remove; unused.
604efe86 15827
38fc62d9
PE
15828 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15829 (copy_keymap_item, append_key, push_text_char_description):
15830 Now static.
1004a21a 15831 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15832 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15833 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15834 (describe_map_tree):
15835 Rename locals to avoid shadowing.
38fc62d9 15836
2f2650da
PE
15837 * keyboard.c: Declare functions static if they are not used elsewhere.
15838 (echo_char, echo_dash, cmd_error, top_level_2):
15839 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15840 (read_char, kbd_buffer_get_event, make_lispy_position):
15841 (make_lispy_event, make_lispy_movement, apply_modifiers):
15842 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15843 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15844 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15845 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15846 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15847
a053e86c 15848 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15849 (mark_kboards): Move decl here ...
15850 * alloc.c (mark_kboards): ... from here.
a053e86c 15851
4752793e
PE
15852 * lisp.h (force_auto_save_soon): New decl.
15853
74f10ca7 15854 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15855 (DEFINE_DUMMY_FUNCTION): New macro.
15856 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15857 Use it.
c03cd23f
PE
15858 (main): Add casts to avoid warnings
15859 if GCC considers string literals to be constants.
74f10ca7 15860
022e70d4
PE
15861 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15862
59d6fe83
PE
15863 * dbusbind.c: Pointer signedness fixes.
15864 (xd_signature, xd_append_arg, xd_initialize):
15865 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15866 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15867 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15868 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15869
78320123
PE
15870 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15871 if GCC considers string literals to be constants.
49cebcca 15872 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15873
35ac2a97
SM
158742011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15875
fb103ca9
SM
15876 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15877 (print_preprocess, print_object): New macro to fix last change.
15878
35ac2a97
SM
15879 * print.c (print_preprocess): Don't forget font objects.
15880
62973b41
JB
158812011-03-16 Juanma Barranquero <lekktu@gmail.com>
15882
15883 * emacs.c (USAGE3): Doc fixes.
15884
0e48bb22
AS
158852011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15886
15887 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15888 structure.
15889
7684e57b
JB
158902011-03-14 Juanma Barranquero <lekktu@gmail.com>
15891
15892 * lisp.h (VWindow_system, Qfile_name_history):
15893 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15894 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15895 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15896
15897 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15898 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15899
15900 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15901 * w32console.c (detect_input_pending, read_input_pending)
15902 (encode_terminal_code):
15903 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15904 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15905 (w32_system_caret_y, Qfile_name_history):
15906 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15907 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15908 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15909 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15910 * w32proc.c (Qlocal, report_file_error):
15911 * w32term.c (Vwindow_system, updating_frame):
15912 * w32uniscribe.c (initialized, uniscribe_font_driver):
15913 Remove unneeded extern declarations.
15914
2aa46d6c
CY
159152011-03-14 Chong Yidong <cyd@stupidchicken.com>
15916
c96bbc66 15917 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15918
cffc6f3b
CY
159192011-03-13 Chong Yidong <cyd@stupidchicken.com>
15920
15921 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15922 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15923 These macros can no longer be used for assignment.
15924
44f230aa
SM
15925 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15926 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15927 (record_buffer_markers, fetch_buffer_markers): New functions for
15928 recording and fetching special buffer markers.
15929 (set_buffer_internal_1, set_buffer_temp): Use them.
15930
15931 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15932
15933 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15934
15935 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15936 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15937
15938 * xdisp.c (hscroll_window_tree):
15939 (reconsider_clip_changes): Use PT instead of BUF_PT.
15940
d251f04b
EZ
159412011-03-13 Eli Zaretskii <eliz@gnu.org>
15942
15943 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15944 $(EMACS_ROOT)/lib/intprops.h.
15945
f0c77cd1
PE
159462011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15947
3eca4629
PE
15948 Fix more problems found by GCC 4.5.2's static checks.
15949
7c86ee98
PE
15950 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15951 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15952 (xg_free_frame_widgets): Make it clear that a local variable is
15953 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15954 (gdk_window_get_screen): Make it clear that this macro is needed
15955 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15956 (int_gtk_range_get_value): New function, which avoids a diagnostic
15957 from gcc -Wbad-function-cast.
15958 (xg_set_toolkit_scroll_bar_thumb): Use it.
15959 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15960 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15961 (get_utf8_string, xg_get_file_with_chooser):
15962 Rename locals to avoid shadowing.
15963 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15964
41729b81
PE
15965 * xgselect.c (xg_select): Remove unused var.
15966
f0c77cd1
PE
15967 * image.c (four_corners_best): Mark locals as initialized.
15968 (gif_load): Initialize transparent_p to zero (Bug#8238).
15969 Mark another local as initialized.
ec6cf4c6 15970 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15971
ce0ad53d 15972 * image.c (clear_image_cache): Now static.
d5d5a617 15973 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15974 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15975 (x_edge_detection): Remove unnecessary cast that
15976 gcc -Wbad-function-cast diagnoses.
2037898d 15977 (gif_load): Fix pointer signedness.
6ae141d6
PE
15978 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15979 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15980
33383987 159812011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15982
d32df629
PE
15983 Improve quality of tests for time stamp overflow.
15984 For example, without this patch (encode-time 0 0 0 1 1
15985 1152921504606846976) returns the obviously-bogus value (-948597
15986 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15987 reports time overflow. See
15988 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15989 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15990 * editfns.c: Include limits.h and intprops.h.
15991 (TIME_T_MIN, TIME_T_MAX): New macros.
15992 (time_overflow): Move earlier, to before first use.
15993 (hi_time, lo_time): New functions, for an accurate test for
15994 out-of-range times.
15995 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15996 (Fget_internal_run_time): Don't assume time_t fits in int.
15997 (make_time): Use list2 instead of Fcons twice.
15998 (Fdecode_time): More accurate test for out-of-range times.
15999 (check_tm_member): New function.
16000 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16001 (lisp_time_argument): Don't rely on undefined left-shift and
16002 right-shift behavior when checking for time stamp overflow.
8be6f318 16003
fe31d94c
PE
16004 * editfns.c (time_overflow): New function, refactoring common code.
16005 (Fformat_time_string, Fdecode_time, Fencode_time):
16006 (Fcurrent_time_string): Use it.
16007
8be6f318
PE
16008 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16009 * dired.c (make_time): Move to ...
16010 * editfns.c (make_time): ... here.
16011 * systime.h: Note the move.
16012
09d9db2c 160132011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16014
126bc0dc
YM
16015 * fringe.c (update_window_fringes): Remove unused variables.
16016
c47cbdfd
YM
16017 * unexmacosx.c (copy_data_segment): Also copy __got section.
16018 (Bug#8223)
16019
7ac80be9
EZ
160202011-03-12 Eli Zaretskii <eliz@gnu.org>
16021
c96bbc66 16022 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16023 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16024 Constify `char *' arguments and their references according to
16025 prototypes in tparam.h.
16026
ecb0f94d 16027 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16028
7ac80be9
EZ
16029 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16030 Adapt all references accordingly.
16031
16032 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16033
ef1fd07e
TT
160342011-03-11 Tom Tromey <tromey@redhat.com>
16035
16036 * buffer.c (syms_of_buffer): Remove obsolete comment.
16037
7ef4b50c
EZ
160382011-03-11 Eli Zaretskii <eliz@gnu.org>
16039
16040 * termhooks.h (encode_terminal_code): Declare prototype.
16041
16042 * msdos.c (encode_terminal_code): Don't declare prototype.
16043
16044 * term.c (encode_terminal_code): Now external again, used by
16045 w32console.c and msdos.c.
16046
44f230aa
SM
16047 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16048 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16049
4b1ec863 160502011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16051
1714f52b 16052 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16053
4b1ec863
PE
16054 * fringe.c (update_window_fringes): Mark locals as initialized
16055 (Bug#8227).
16056 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16057
524c7aa6
PE
16058 * alloc.c (mark_fringe_data): Move decl from here ...
16059 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16060 to check its interface.
16061 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16062
a5c0af81 16063 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16064 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16065 (fontset_font): Mark local as initialized.
a9a06e0b 16066 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16067
b4716021
PE
16068 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16069
811e9bac 16070 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16071 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16072 (x_own_selection, Fx_disown_selection_internal): Rename locals
16073 to avoid shadowing.
16074 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16075
7e3ab302
PE
16076 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16077 so that the caller can use some name other than gcpro1.
16078 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16079 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16080 (Fx_backspace_delete_keys_p):
16081 Use them to avoid shadowing, and rename vars to avoid shadowing.
16082 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16083 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16084 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16085 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16086 Remove unused locals.
7e3ab302
PE
16087 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16088 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16089 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16090 macros.
f78faa98 16091
e2b13473
PE
16092 * xterm.h (x_mouse_leave): New decl.
16093
77f23912
PE
16094 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16095 Remove unused functions.
cdf4ba58
PE
16096 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16097 (x_calc_absolute_position): Now static.
7411c686 16098 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16099 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16100 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16101 unless they are used.
38d0b34a
PE
16102 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16103 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16104 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16105 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16106 (x_error_catcher, x_connection_closed, x_error_handler):
16107 (x_error_quitter, xembed_send_message, x_iconify_frame):
16108 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16109 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16110 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16111
44f230aa
SM
16112 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16113 Rename or move locals to avoid shadowing.
6b463e58 16114 (tty_defined_color, merge_face_heights): Now static.
5967d051 16115 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
16116 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
16117 does not deduce is never used uninitialized.
73719eba
PE
16118 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16119 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16120
426994c3 16121 * terminal.c (store_terminal_param): Now static.
5489860b 16122
032f1620 16123 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16124 (set_frame_menubar): Remove unused local.
d4323972 16125 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16126 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16127 since they might point to immutable storage.
281585b0
PE
16128 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16129 since it's unused otherwise.
032f1620 16130
367c19e5 16131 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16132 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16133 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16134 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16135 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16136 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16137 does not deduce are never used uninitialized.
70739cbe 16138
07b48fa9
PE
16139 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16140
8868a238 16141 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16142 * window.c (window_loop, size_window):
16143 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16144
7e5cf297 16145 * window.c (display_buffer): Now static.
d6550a9f
PE
16146 (size_window): Mark variables that gcc -Wuninitialized
16147 does not deduce are never used uninitialized.
a586633d
PE
16148 * window.h (check_all_windows): New decl, to forestall
16149 gcc -Wmissing-prototypes diagnostic.
5b555da1 16150 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16151
f6095868
PE
16152 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16153 shadowing.
16154 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16155 Include <limits.h>.
16156 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16157 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16158 (load_charset_map): Mark variables that gcc -Wuninitialized
16159 does not deduce are never used uninitialized.
53df7c11 16160 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16161
f38b440c
PE
16162 * coding.c (coding_set_source, coding_set_destination):
16163 Use "else { /* comment */ }" rather than "else /* comment */;"
16164 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16165 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16166 a block, when the outer 'i' will do.
16167 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16168 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16169 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16170 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16171 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16172 Rename locals to avoid shadowing.
16173 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16174 * coding.c (emacs_mule_char, encode_invocation_designation):
16175 Now static, since they're not used elsewhere.
413bb2db 16176 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16177 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16178 (decode_coding_emacs_mule): Mark variables that gcc
16179 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16180 (detect_coding_iso_2022): Initialize a local variable that might
16181 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16182 this initialization is needed. (Bug#8211)
5f58e762
PE
16183 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16184 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16185 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16186 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16187 Remove unused macros.
f38b440c 16188
232b38b9 16189 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16190 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16191 * character.c (string_count_byte8): Likewise.
232b38b9 16192
fb90da1b
PE
16193 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16194 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16195
fb93dbc2
PE
16196 * chartab.c (copy_sub_char_table): Now static, since it's not used
16197 elsewhere.
5c156ace
PE
16198 (sub_char_table_ref_and_range, char_table_ref_and_range):
16199 Rename locals to avoid shadowing.
bbcd0949 16200 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16201
7d3b3862 16202 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16203 (BIDI_BOB): Remove unused macro.
7d3b3862 16204
6be7d3da
PE
16205 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16206 deduce are never used uninitialized.
c2ed9c8b 16207 * term.c (encode_terminal_code): Likewise.
6be7d3da 16208
75f8807f 16209 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 16210
50938595
PE
16211 * tparam.h: New file.
16212 * term.c, tparam.h: Include it.
16213 * deps.mk (term.o, tparam.o): Depend on tparam.h.
16214 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
16215 Move these decls to tparam.h, and make them agree with what
16216 is actually in tparam.c. The previous trick of using incompatible
16217 decls in different modules does not conform to the C standard.
16218 All callers of tparam changed to use tparam's actual API.
16219 * tparam.c (tparam1, tparam, tgoto):
16220 Use const pointers where appropriate.
16221
fbceeba2
PE
16222 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
16223 * cm.h (struct cm): Likewise.
16224 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
16225 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
16226 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
16227 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
16228 (turn_on_face, init_tty): Likewise.
16229 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 16230
7f3f1250
PE
16231 * term.c (term_mouse_position): Rename local to avoid shadowing.
16232
e6ca6543
PE
16233 * alloc.c (mark_ttys): Move decl from here ...
16234 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
16235
c40f8d15
AS
162362011-03-11 Andreas Schwab <schwab@linux-m68k.org>
16237
16238 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
16239
cfe0661d
JB
162402011-03-09 Juanma Barranquero <lekktu@gmail.com>
16241
16242 * search.c (compile_pattern_1): Remove argument regp, unused since
16243 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
16244 (compile_pattern): Don't pass it.
16245
0afb4571
J
162462011-03-08 Jan Djärv <jan.h.d@swipnet.se>
16247
16248 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
16249 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
16250 for ! HAVE_GTK3.
16251 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
16252
16253 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
16254
16255 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
16256 gdk_window_get_screen, gdk_window_get_geometry,
16257 gdk_x11_window_lookup_for_display and GDK_KEY_g.
16258 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
16259 (xg_get_pixbuf_from_pixmap): New function.
16260 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
16261 to Pixmap, take frame as parameter, remove GdkColormap parameter.
16262 Call xg_get_pixbuf_from_pixmap instead of
16263 gdk_pixbuf_get_from_drawable.
16264 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
16265 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
16266 (xg_check_special_colors): Use GtkStyleContext and its functions
16267 for HAVE_GTK3.
16268 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
16269 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
16270 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
16271 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
16272 Call gtk_widget_get_preferred_size.
0afb4571
J
16273 (xg_frame_resized): gdk_window_get_geometry only takes 5
16274 parameters.
44f230aa
SM
16275 (xg_win_to_widget, xg_event_is_for_menubar):
16276 Call gdk_x11_window_lookup_for_display.
0afb4571
J
16277 (xg_set_widget_bg): New function.
16278 (delete_cb): New function.
895009e1 16279 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 16280 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
16281 (xg_set_background_color): Call xg_set_widget_bg.
16282 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
16283 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
16284 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
16285 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
16286 if ! HAVE_GTK3.
16287 (update_frame_tool_bar): Call gtk_widget_hide.
16288 (xg_initialize): Use GDK_KEY_g.
16289
16290 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
16291 if ! HAVE_GTK3
16292 (x_session_initialize): Call gdk_x11_set_sm_client_id.
16293
16294 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
16295 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
16296 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
16297
1c2cc4ef
JB
162982011-03-08 Juanma Barranquero <lekktu@gmail.com>
16299
16300 * w32xfns.c (select_palette): Check success of RealizePalette against
16301 GDI_ERROR, not zero.
16302
33383987 16303See ChangeLog.11 for earlier changes.
aac0c6e3
MR
16304
16305;; Local Variables:
16306;; coding: utf-8
aac0c6e3
MR
16307;; End:
16308
2f097256 16309 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
16310
16311 This file is part of GNU Emacs.
16312
16313 GNU Emacs is free software: you can redistribute it and/or modify
16314 it under the terms of the GNU General Public License as published by
16315 the Free Software Foundation, either version 3 of the License, or
16316 (at your option) any later version.
16317
16318 GNU Emacs is distributed in the hope that it will be useful,
16319 but WITHOUT ANY WARRANTY; without even the implied warranty of
16320 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16321 GNU General Public License for more details.
16322
16323 You should have received a copy of the GNU General Public License
16324 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.