Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a0c2d0ae
MR
12011-11-17 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (Vwindow_splits): Rename to
4 Vwindow_combination_resize. Suggested by Juri Linkov.
5 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6 of Vwindow_splits.
7
58179cce
JB
82011-11-16 Juanma Barranquero <lekktu@gmail.com>
9
7877f373
JB
10 * nsfns.m (Fns_font_name):
11 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 12
b6f67890
MR
132011-11-16 Martin Rudalics <rudalics@gmx.at>
14
15 * window.h (window): Rename slot "nest" to "combination_limit".
16 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
17 (Fset_window_nest): Rename to Fset_window_combination_limit.
18 (Vwindow_nest): Rename to Vwindow_combination_limit.
19 (recombine_windows, make_parent_window, make_window)
20 (Fsplit_window_internal, saved_window)
21 (Fset_window_configuration, save_window_save): Rename all
22 occurrences of window_nest to window_combination_limit.
23
c7015153
JB
242011-11-15 Juanma Barranquero <lekktu@gmail.com>
25
26 * image.c (imagemagick_load_image): Fix typo.
27
322ad6ec
EZ
282011-11-14 Eli Zaretskii <eliz@gnu.org>
29
30 * xdisp.c (display_line): Move the call to
31 highlight_trailing_whitespace before the call to
32 compute_line_metrics, since the latter needs to see the final
33 faces of all the glyphs to compute ROW's hash value. Fixes
34 assertion violations in row_equal_p. (Bug#10035)
35
f067b8ec
JB
362011-11-14 Juanma Barranquero <lekktu@gmail.com>
37
38 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
39 just return (bug#10044).
40
1e5b2111
EZ
412011-11-12 Eli Zaretskii <eliz@gnu.org>
42
7ef3cbd5
EZ
43 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
44 with user-defined heap size. Bump the default size of the temacs
45 heap to 27MB, to avoid memory warning when running temacs.
46 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
47
1e5b2111
EZ
48 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
49 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
50 (verify_row_hash) [XASSERTS]: New function.
51 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
52 that the hash value of glyph rows is correct.
1e5b2111 53
89d61221
MR
542011-11-12 Martin Rudalics <rudalics@gmx.at>
55
56 * window.h (window): Remove splits slot.
57 * window.c (Fwindow_splits, Fset_window_splits): Remove.
58 (Fdelete_other_windows_internal, make_parent_window)
59 (make_window, Fsplit_window_internal, Fdelete_window_internal)
60 (Fset_window_configuration, save_window_save): Don't deal with
61 split status of windows.
62 (saved_window): Remove splits slot.
63 (Vwindow_splits): Rewrite doc-string.
64
97f18cc8
JD
652011-11-11 Jan Djärv <jan.h.d@swipnet.se>
66
67 * xfns.c (unwind_create_frame):
68 * nsfns.m (unwind_create_frame):
69 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
70 Vframe_list (Bug#9999).
71
22a648b4
DA
722011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
73
0b381c7e 74 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 75
659afede
KH
762011-11-11 Kenichi Handa <handa@m17n.org>
77
78 * callproc.c (Fcall_process): Set the member dst_multibyte of
79 process_coding.
80
9ac0394b
KH
812011-11-11 Johan Bockgård <bojohan@gnu.org>
82
83 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
84 avoid a crash (bug#9496).
85
2fbdc249
CY
862011-11-09 Chong Yidong <cyd@gnu.org>
87
88 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
89 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
90
ac6b1f81
PE
912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
92
93 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
94
09db192c
PE
952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
96
97 Avoid some portability problems by eschewing 'extern inline' functions.
98 The trivial performance wins aren't worth the portability hassles; see
99 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
100 et seq.
101 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
102 (window_box_width, window_box_left, window_box_left_offset)
103 (window_box_right, window_box_right_offset): Undo previous change,
104 by removing the "extern"s.
105 * intervals.c (adjust_intervals_for_insertion)
106 (adjust_intervals_for_deletion): Undo previous change,
107 making these static again.
108 (offset_intervals, temp_set_point_both, temp_set_point)
109 (copy_intervals_to_string): No longer inline.
110 * xdisp.c (window_text_bottom_y, window_box_width)
111 (window_box_height, window_box_left_offset)
112 (window_box_right_offset, window_box_left, window_box_right)
113 (window_box): No longer inline.
114
105216ed
CY
1152011-11-08 Chong Yidong <cyd@gnu.org>
116
117 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
118 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
119 an error if not a live window.
120 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
121 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
122
ae9e237f
JB
1232011-11-07 Juanma Barranquero <lekktu@gmail.com>
124
125 * lisp.h (syms_of_abbrev): Remove declaration.
126 Reported by CHENG Gao <chenggao@royau.me>.
127
c7aa8333
EZ
1282011-11-07 Eli Zaretskii <eliz@gnu.org>
129
130 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
131 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
132 of temacs in GUI mode.
133
be7f5545
MR
1342011-11-07 Martin Rudalics <rudalics@gmx.at>
135
136 * window.h: Declare delete_all_child_windows instead of
137 delete_all_subwindows.
138 * window.c (Fwindow_nest, Fset_window_nest)
139 (Fset_window_new_total, Fset_window_new_normal)
140 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
141 (delete_all_subwindows): Rename to delete_all_child_windows.
142 (Fdelete_other_windows_internal, Fset_window_configuration):
143 Call delete_all_child_windows instead of delete_all_subwindows.
144 * frame.c (delete_frame): Call delete_all_child_windows instead
145 of delete_all_subwindows.
146
ca78dc43
PE
1472011-11-07 Paul Eggert <eggert@cs.ucla.edu>
148
149 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
150 This is also needed for porting to any host where GC_MARK_STACK is
151 not GC_MAKE_GCPROS_NOOPS.
152 (which_symbols): Use it.
153
a0241d01
KH
1542011-11-07 Kenichi Handa <handa@m17n.org>
155
156 * coding.c (coding_set_destination): Check coding->src_pos only
157 when coding->src_object is a buffer (bug#9910).
158
159 * process.c (send_process): Set the member src_multibyte of coding
160 to 0 (bug#9911) when sending a unibyte text.
161
162 * callproc.c (Fcall_process): Set the member src_multibyte of
163 process_coding to 0 (bug#9912).
164
a64bfdfa 1652011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
166
167 * xmenu.c (cleanup_widget_value_tree): New function.
168 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
169 calling free_menubar_widget_value_tree directly (Bug#9830).
170
cb41b32a
PE
1712011-11-06 Paul Eggert <eggert@cs.ucla.edu>
172
173 Fix some portability problems with 'inline'.
174 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
175 (window_box_width, window_box_left, window_box_left_offset)
176 (window_box_right, window_box_right_offset): Declare extern.
177 Otherwise, these inline functions do not conform to C99 and
178 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
179 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
180 * intervals.c (adjust_intervals_for_insertion)
181 (adjust_intervals_for_deletion): Now extern, because otherwise the
182 extern inline functions 'offset_intervals' couldn't refer to it.
183 (static_offset_intervals): Remove.
184 (offset_intervals): Rewrite using the old contents of
185 static_offset_intervals. The old version didn't conform to C99
186 because an extern inline function contained a reference to an
187 identifier with static linkage.
188
b7041366
AS
1892011-11-06 Andreas Schwab <schwab@linux-m68k.org>
190
191 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
192 GC.
193
88a37c4d
EZ
1942011-11-06 Eli Zaretskii <eliz@gnu.org>
195
196 * xdisp.c (init_iterator, reseat_to_string): Don't set the
197 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
198 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
199 return Qleft_to_right.
200
49745b39
CY
2012011-11-06 Chong Yidong <cyd@gnu.org>
202
203 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
204 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
205 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
206 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
207 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
208 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
209 (Fwindow_vscroll): Doc fix.
210 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
211 argument, since it makes no sense to pass a live window and for
212 consistency with window-child.
213
1f05cd82
CS
2142011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
215
216 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
217 support MSVC.
218
22610910
JR
2192011-11-05 Jason Rumney <jasonr@gnu.org>
220
221 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
222 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
223 fonts (Bug#6029).
224 (add_font_entity_to_list): Fix logic errors in mixed boolean and
225 bitwise arithmetic preventing use of unicode-sip and non-truetype
226 opentype fonts.
227
a06776b2
EZ
2282011-11-05 Eli Zaretskii <eliz@gnu.org>
229
3ad924ba
EZ
230 * s/ms-w32.h (fstat, stat, utime): Move redirections to
231 "emacs"-only part.
232
a06776b2
EZ
233 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
234 initialization code to keep similarity to xfns.c after changes
235 from 2011-11-05.
236
c9e7db78
JD
2372011-11-05 Jan Djärv <jan.h.d@swipnet.se>
238
a97f8f3f
JD
239 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
240 (unwind_create_frame): New function (Bug#9943).
241 (Fx_create_frame): Restructure code to be more similar to the one in
242 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
243 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
244 Move terminal->reference_count++ just before making the frame official
245 (Bug#9943).
246
247 * nsterm.m (x_free_frame_resources): New function.
248 (x_destroy_window): Move code to x_free_frame_resources.
249
c9e7db78
JD
250 * xfns.c (unwind_create_frame): Fix comment.
251 (Fx_create_frame, x_create_tip_frame): Move
252 terminal->reference_count++ just before making the frame
253 official. Move initialization of image_cache_refcount and
254 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
255
a6fc3b5c
EZ
2562011-11-05 Eli Zaretskii <eliz@gnu.org>
257
258 Support MSVC build with newer versions of Visual Studio.
259 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
260 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
261 nt/gmake.defs.
262
263 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
264 which are not supported by MSVC.
265 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
266 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
267 bitfields.
268 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
269 types in bitfields.
270 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
271
272 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
273
58179cce 2742011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
275
276 Support MSVC build with newer versions of Visual Studio.
277 * w32.c: Don't include w32api.h for MSVC.
278 (init_environment) [_MSC_VER]: Call sys_access, not _access.
279
280 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
281 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
282 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
283 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
284 e_* cousins.
285 (alloca) [_MSC_VER]: Define to _alloca.
286
287 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
288
289 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
290
a58c13ed
EZ
2912011-11-04 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (note_mouse_highlight): If either of
294 previous/next-single-property-change returns nil, treat that as
295 the beginning or the end of the buffer. (Bug#9955)
296
fe0b6370
JD
2972011-11-04 Jan Djärv <jan.h.d@swipnet.se>
298
a58c13ed 299 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
300 label is not null (Bug#9951).
301 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
302 may be NULL.
303
89bd5ee1
EZ
3042011-11-04 Eli Zaretskii <eliz@gnu.org>
305
306 * window.c (Fwindow_body_size): Mention in the doc string that the
307 return value is in frame's canonical units. (Bug#9949)
308
84c3edb9
EZ
3092011-11-03 Eli Zaretskii <eliz@gnu.org>
310
4e2fb5c7
EZ
311 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
312
84c3edb9 313 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 314 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 315 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 316
bc17a887
EZ
3172011-11-01 Eli Zaretskii <eliz@gnu.org>
318
319 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
320 Don't stop backward scan on the continuation glyph, even though
321 its CHARPOS is positive.
26b46e51
EZ
322 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
323 cover_string to disp_string.
bc17a887 324
4ee88440
MR
3252011-11-01 Martin Rudalics <rudalics@gmx.at>
326
327 * window.c (temp_output_buffer_show): Don't use
328 Vtemp_buffer_show_specifiers.
329 (Vtemp_buffer_show_specifiers): Remove unused variable.
330
c2ff3c02
EZ
3312011-10-30 Eli Zaretskii <eliz@gnu.org>
332
333 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
334 past the beginning of the current glyph matrix.
335
58179cce 3362011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
337
338 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
339 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
340 HAVE_GTK3 (Bug#9869).
b77a6a7f 341
3b574623
JD
342 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
343 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
344
b77a6a7f
JD
345 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
346
347 * xterm.c: Declare x_handle_net_wm_state to return int.
348 (handle_one_xevent): Check if we are iconified but don't have
349 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
350 (get_current_wm_state): Return non-zero if not hidden,
351 check for _NET_WM_STATE_HIDDEN (Bug#9893).
352 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
353 (x_handle_net_wm_state): Return what get_current_wm_state returns.
354 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
355
196e41e4
PE
3562011-10-29 Paul Eggert <eggert@cs.ucla.edu>
357
358 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
359 so that this new function doesn't get optimized away by a
360 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
361
021f2e1a
AS
3622011-10-29 Andreas Schwab <schwab@linux-m68k.org>
363
364 * frame.h (MOUSE_HL_INFO): Remove excess parens.
365
8b058d44
EZ
3662011-10-29 Eli Zaretskii <eliz@gnu.org>
367
368 Fix the `xbytecode' command.
369 * .gdbinit (xprintbytestr): New command.
370 (xwhichsymbols): Renamed from `which'; all callers changed.
371 (xbytecode): Print the byte-code string as well.
372
4452fb80
EZ
3732011-10-29 Kim Storm <storm@cua.dk>
374
8b058d44
EZ
375 * alloc.c (which_symbols): New function.
376
21b72067
AS
3772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
378
379 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
380 line. (Bug#9903)
381
83ed7b5c
GM
3822011-10-29 Glenn Morris <rgm@gnu.org>
383
384 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
385 Not clear what it was for, and it causes various bugs. (Bug#9839)
386
5a7a728b
EZ
3872011-10-28 Eli Zaretskii <eliz@gnu.org>
388
389 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
390 possible random value that matches one of those tested as
391 condition to clear the mouse face.
392
d3d0842f
CY
3932011-10-28 Chong Yidong <cyd@gnu.org>
394
395 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
396
31b39d13
DN
3972011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
398
399 * window.c (make_window): Initialize phys_cursor_on_p.
400
9aba6043
SM
4012011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
402
403 * lisp.h (struct Lisp_Symbol): Update comments.
404
c20992f4
JB
4052011-10-28 Juanma Barranquero <lekktu@gmail.com>
406
407 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
408
db4f02f2
EZ
4092011-10-28 Eli Zaretskii <eliz@gnu.org>
410
411 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
412 <oslsachem@gmail.com> for helping to debug this.
413
414 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
415 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
416 (g_b_init_get_glyph_outline_w): New static variables.
417 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
418 (GetGlyphOutlineW_Proc): New typedefs.
419 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
420 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
421 New functions.
422 (w32font_open_internal, compute_metrics):
423 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
424 instead of calling the "wide" APIs directly.
425
426 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
427
428 * w32.h (syms_of_w32font): Add prototype.
429
87e68db4
JB
4302011-10-27 Juanma Barranquero <lekktu@gmail.com>
431
432 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
433 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
434 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
435 (Fmove_to_window_line): Doc fix.
436
435c1d67
CY
4372011-10-27 Chong Yidong <cyd@gnu.org>
438
439 * process.c (make_process): Set gnutls_state to NULL.
440
441 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
442 non-NULL, regardless of GNUTLS_INITSTAGE.
443 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
444 an error. Set process slots as soon as we allocate them.
445
446 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
447
9c6c6f49
CY
4482011-10-27 Chong Yidong <cyd@gnu.org>
449
9aba6043
SM
450 * gnutls.c (emacs_gnutls_deinit): New function.
451 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
452 (Fgnutls_deinit, Fgnutls_boot): Use it.
453
454 * process.c (make_process): Initialize GnuTLS credentials to NULL.
455 (deactivate_process): Call emacs_gnutls_deinit.
456
657d08d3
JB
4572011-10-27 Juanma Barranquero <lekktu@gmail.com>
458
459 * image.c (x_create_x_image_and_pixmap):
460 * w32.c (sys_rename, w32_delayed_load):
461 * w32font.c (fill_in_logfont):
462 * w32reg.c (x_get_string_resource): Silence compiler warnings.
463
5430d399
JB
4642011-10-26 Juanma Barranquero <lekktu@gmail.com>
465
466 * w32fns.c (w32_default_color_map): New function,
467 extracted from Fw32_default_color_map.
a7ef684b 468 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 469
fe0055fa
PE
4702011-10-25 Paul Eggert <eggert@cs.ucla.edu>
471
472 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
473
e6346438
SM
4742011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
475
476 * keyboard.c (test_undefined): New function (bug#9751).
477 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
478
e112cc37
ET
4792011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
480
481 * sysdep.c (init_sys_modes): Fix the check for the controlling
482 terminal (Bug#6649).
483
7b5d6677
EZ
4842011-10-20 Eli Zaretskii <eliz@gnu.org>
485
486 * dispextern.h (struct bidi_it): New member next_en_type.
487
488 * bidi.c (bidi_line_init): Initialize the next_en_type member.
489 (bidi_resolve_explicit_1): When next_en_pos is valid for the
490 current character, check also for next_en_type being WEAK_EN.
491 (bidi_resolve_weak): Don't enter the expensive loop if the current
492 position is before next_en_pos. Record the bidi type of the first
493 non-ET, non-BN character we find, in addition to its position.
494 (bidi_level_of_next_char): Invalidate next_en_type when
495 next_en_pos is over-stepped.
496
7da0b018
PE
4972011-10-20 Paul Eggert <eggert@cs.ucla.edu>
498
499 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
500 * editfns.c: Rewrite current-time-zone so that it invokes
501 the equivalent of (format-time-string "%Z") to get the time zone name.
502 This fixes a bug when the time zone name contains characters that
503 need converting from the system time locale to Emacs internal format.
504 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
505 that patch fixed format-time-string to do the conversion, but
506 I forgot to fix current-time-zone.
507 (format_time_string): New function, containing most of
508 what Fformat_time_string used to contain.
509 (Fformat_time_string): Rewrite in terms of format_time_string.
510 This doesn't change this function's behavior.
511 (current-time-zone): Rewrite to use format_time_string.
512 This fixes the bug reported by Michael Schierl in
513 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
514 Jason Rumney's 2007-06-07 change worked around this bug, but
515 didn't fix it.
516 * systime.h (tzname, timezone): Remove no-longer-used declarations.
517
8547b010
EZ
5182011-10-19 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (start_display): If the character at POS is displayed
521 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
522 (try_window_reusing_current_matrix): If a line ends in a display
523 vector or the next line starts in a display vector, continue
524 redrawing the window even though the character position of
525 start_row was reached.
8547b010
EZ
526 (Bug#9771, part 2)
527
4e948d15
CY
5282011-10-18 Chong Yidong <cyd@gnu.org>
529
530 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
531 with nobreak-char-display too.
532
4787455f
EZ
5332011-10-18 Eli Zaretskii <eliz@gnu.org>
534
535 Fix part 3 of bug#9771.
536 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
537 (bidi_resolve_neutral): Don't enter the expensive loop looking for
538 non-neutral characters if the current character is a paragraph
539 separator (a.k.a. Newline). This avoids running the same
540 expensive loop twice, once when we consume the preceding newline
541 and the other time when the line actually needs to be displayed.
542 Avoid the loop when we see neutrals on the base embedding level
543 following a character whose directionality is the same as the
544 paragraph's. This avoids running the expensive loop when a line
545 ends in a long sequence of neutrals, like control characters.
546 Add assertion against STRONG_AL type. Slightly rearrange code
547 that determines the type of a neutral given the first non-neutral
548 that follows it.
549 (bidi_level_of_next_char): Set next_en_pos to zero when
550 invalidating its info.
551
2c91f553
EZ
5522011-10-17 Eli Zaretskii <eliz@gnu.org>
553
554 * xdisp.c (push_display_prop): Determine whether to record string
555 or buffer position by IT->string, not by IT->method. Allow
556 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
557 (move_it_vertically_backward): Don't look for character position
558 immediately after the newline when in a continuation line.
559 (Bug#9771, part 1)
2c91f553 560
c7b08b0d
MR
5612011-10-15 Martin Rudalics <rudalics@gmx.at>
562
563 * window.c (coordinates_in_window): Rewrite and delabelize
564 vertical border check. (Bug#5357) (Bug#9618)
565
6b02f655
SM
5662011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
567
568 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
569 errors in XSetWindowBorder (bug#9310).
570
81d40c92
DA
5712011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
572
573 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
574 avoid crash when xmalloc overrun checking is enabled.
575
d4172c3b
EZ
5762011-10-13 Eli Zaretskii <eliz@gnu.org>
577
578 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
579 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
580 cursor motion with <left> and <right> arrow keys.
581
582 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
583 some callers set that themselves.
584
b00eea75
EZ
5852011-10-12 Eli Zaretskii <eliz@gnu.org>
586
587 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
588 display string and the previous row comes from the same string and
589 is empty. (Bug#9739) (Bug#9738)
590
8fe012c4
SM
5912011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
592
593 * doc.c (get_doc_string): Encode file name (bug#9735).
594
0074aef2
EZ
5952011-10-12 Eli Zaretskii <eliz@gnu.org>
596
79beb178
EZ
597 * bidi.c (bidi_level_of_next_char):
598 * xdisp.c (get_visually_first_element): Remove old incorrect
599 comments regarding the Unicode Line Separator character.
600
0074aef2
EZ
601 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
602
6e4b3fbe
DA
6032011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
604
605 * alloc.c (Fgc_status): Do not access beyond zombies array
606 boundary if nzombies > MAX_ZOMBIES.
607 * alloc.c (dump_zombies): Add missing format specifier.
608
0324f3af
PE
6092011-10-12 Paul Eggert <eggert@cs.ucla.edu>
610
b5525cac
PE
611 * xdisp.c (set_cursor_from_row): Simplify conditionals,
612 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
613
0324f3af
PE
614 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
615 Some packages use them to denote characters with modifiers.
616
e9b5f888
AS
6172011-10-11 Andreas Schwab <schwab@linux-m68k.org>
618
619 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
620 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
621 matching a pp-number. Rename parameter var to var1.
622
127827c0
SM
6232011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
626
c8fd3bd0
GM
6272011-10-08 Glenn Morris <rgm@gnu.org>
628
629 * callint.c (Fcall_interactively): Give a more explicit error for the
630 'c' case with a non-character input. (Bug#8479)
631
352ec8ff
EZ
6322011-10-08 Eli Zaretskii <eliz@gnu.org>
633
03669ccb
EZ
634 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
635 lines.
7061c986
EZ
636 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
637 lines that are hscrolled on the left.
03669ccb 638
352ec8ff
EZ
639 * dispnew.c (buffer_posn_from_coords): Account for a possible
640 presence of header-line. (Bug#4426)
641
a66cfb1c
SM
6422011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
643
6b02f655
SM
644 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
645 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 646
7c5ee88e
PE
6472011-10-07 Paul Eggert <eggert@cs.ucla.edu>
648
649 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
650 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
651 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
652 this makes Emacs dump core during garbage collection on rare
653 occasions. sizeof is obviously inferior to offsetof here, so
654 stick with offsetof.
655 (GC_POINTER_ALIGNMENT): New macro.
656 (mark_memory): Omit 3rd (offset) arg; caller changed.
657 Don't assume EMACS_INT alignment is the same as pointer alignment.
658
df1bbe5b
SM
6592011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
660
661 * keyboard.c (read_key_sequence_remapped): New var.
662 (read_key_sequence): Compute remapping in the right buffer.
663 (command_loop_1): Use read_key_sequence's remapping directly.
664
51553db6
SM
6652011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
666
32c1fffd
SM
667 * dired.c (file_name_completion): Don't expand file name.
668 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
669 before checking file name handler.
670
51553db6
SM
671 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
672 they've been requested explicitly (bug#9591).
673
b6bd1599 6742011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
675
676 * keymap.c (Fsingle_key_description): Use make_specified_string
677 instead of build_string to build string from push_key_description.
678 (Bug#5193)
679
f701dc2a
PE
6802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
681
4222c55d
PE
682 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
683 This fixes a Y2038 bug on 64-bit hosts.
684 * buffer.c (reset_buffer):
685 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
686 (Fclear_buffer_auto_save_failure):
687 Use 0, not -1, to represent an unset failure time, since time_t
688 might not be signed.
689
f701dc2a
PE
690 Remove dependency on glibc malloc internals.
691 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
692 Move back here from lisp.h, but with their new implementations.
693 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
694 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
695 * charset.c (charset_table_init): New static var.
696 (syms_of_charset): Use it instead of xmalloc. This removes a
697 dependency on glibc malloc internals. See Eli Zaretskii's comment in
698 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
699 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
700 Move back to alloc.c.
701 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
702 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
703
9ceebf39
JD
7042011-09-30 Jan Djärv <jan.h.d@swipnet.se>
705
706 * nsterm.m (windowDidResize): Call x_set_window_size only when
707 ns_in_resize is true. Otherwise set pixelwidth/height and
708 call change_frame_size (Bug#9628).
709
cb993c58
PE
7102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
711
3930c88b
PE
712 Port --enable-checking=all to Fedora 14 x86-64.
713 * charset.c (syms_of_charset): Also account for glibc malloc's
714 internal overhead when calculating the initial malloc maximum.
715
cb993c58
PE
716 Port --enable-checking=all to Fedora 14 x86.
717 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
718 Move to lisp.h.
719 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
720 (overrun_check_realloc, overrun_check_free):
721 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
722 That way, xmalloc returns a properly-aligned pointer even if
723 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
724 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
725 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
726 into account when calculating the initial malloc maximum.
727 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
728 Move here from alloc.c, so that charset.c can use it too.
729 Properly align; the old code wasn't right for common 32-bit hosts
730 when configured with --enable-checking=all.
731 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
732 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
733
31bed486
EZ
7342011-09-29 Eli Zaretskii <eliz@gnu.org>
735
04c70788 736 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
737 use EDOM.
738
fbcaa2f3
EZ
7392011-09-28 Eli Zaretskii <eliz@gnu.org>
740
741 * xdisp.c (compute_display_string_end): If there's no display
742 string at CHARPOS, return -1.
743
744 * bidi.c (bidi_fetch_char): When compute_display_string_end
745 returns a negative value, treat the character as a normal
746 character not covered by a display string. (Bug#9624)
747
a239d4e9
JB
7482011-09-28 Juanma Barranquero <lekktu@gmail.com>
749
750 * lread.c (Fread_from_string): Fix typo in docstring.
751
88652fd5
EZ
7522011-09-27 Eli Zaretskii <eliz@gnu.org>
753
754 * xdisp.c (handle_invisible_prop): If invisible text ends on a
755 newline, reseat the iterator instead of bidi-iterating there one
756 character at a time. (Bug#9610)
32c1fffd
SM
757 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
758 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 759
ed497dd4
AS
7602011-09-27 Andreas Schwab <schwab@linux-m68k.org>
761
762 * lread.c (readevalloop): Use correct code for NBSP.
763 (read1): Likewise. (Bug#9608)
764
b2bf61aa
MA
7652011-09-25 Michael Albinus <michael.albinus@gmx.de>
766
767 * dbusbind.c (Fdbus_register_signal): When service is not
768 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
769
32bbb17c
GM
7702011-09-25 Glenn Morris <rgm@gnu.org>
771
772 * buffer.c (truncate-lines): Doc fix.
773
94e0933e
CY
7742011-09-24 Chong Yidong <cyd@stupidchicken.com>
775
776 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
777 (Fset_window_next_buffers): Doc fix.
778
cddde921
GM
7792011-09-24 Glenn Morris <rgm@gnu.org>
780
781 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
782
1260aef1
PE
7832011-09-24 Paul Eggert <eggert@cs.ucla.edu>
784
25b4bfa0
PE
785 Fix minor problems found by static checking.
786 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
787 * indent.c (Fvertical_motion): Fix == vs = typo.
788
e3cbd34b
EZ
7892011-09-24 Eli Zaretskii <eliz@gnu.org>
790
a66cfb1c
SM
791 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
792 Default value is now t. Doc fix.
6bf7006f 793
e3cbd34b 794 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 795 logic when moving up, not only when moving down. Fix the
e3cbd34b 796 confusing name and values of the it_overshoot_expected variable;
32c1fffd 797 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
798
799 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
800 CHARPOS is covered by a display string which includes newlines.
801 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
802 is covered by a display string with embedded newlines.
803
a3de0cbd
MA
8042011-09-24 Michael Albinus <michael.albinus@gmx.de>
805
806 * dbusbind.c (Fdbus_register_signal): Add match rule to
807 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
808 (Fdbus_register_method, Vdbus_registered_objects_table):
809 Fix docstring.
a3de0cbd 810
b260039d
JM
8112011-09-24 Jim Meyering <meyering@redhat.com>
812
32c1fffd 813 do not ignore write error for any output size
b260039d
JM
814 The previous change was incomplete.
815 While it makes emacs --batch detect the vast majority of stdout
816 write failures, errors were still ignored whenever the output size is
817 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
818 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
819 && echo FAIL: ignored write error
820 FAIL: ignored write error
821 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
822 && echo FAIL: ignored write error
823 FAIL: ignored write error
824 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
825
8eca8a7c
AS
8262011-09-23 Andreas Schwab <schwab@linux-m68k.org>
827
828 * emacs.c (Fkill_emacs): In noninteractive mode exit
829 non-successfully if a write error occurred on stdout. (Bug#9574)
830
3341db62
EZ
8312011-09-21 Eli Zaretskii <eliz@gnu.org>
832
833 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
834 the xassert test.
835
836 * dispextern.h (struct it): Update the comment documenting what
837 can it->OBJECT be.
838
8c203dbf
EZ
8392011-09-20 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
842 a display string, extend search for cursor position to end of row.
843 (find_row_edges): If the row ends in a newline from a display
844 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
845 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
846 (Fcurrent_bidi_paragraph_direction): Fix search for previous
847 non-empty line. Fixes confusing cursor motion with arrow keys at
848 the beginning of a line that starts with whitespace.
8c203dbf 849
a4824228
LMI
8502011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
851
852 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
853 (bug#9493).
854
33ed493b
CY
8552011-09-18 Chong Yidong <cyd@stupidchicken.com>
856
857 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
858 boolean (Bug#9154).
859
56cd55c8
EZ
8602011-09-18 Eli Zaretskii <eliz@gnu.org>
861
862 * xdisp.c (display_line): Record maximum and minimum buffer
863 positions even if no glyphs were produced (e.g., by a zero-width
864 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
865 buffer positions that will be removed from the glyph row because
866 they don't fit.
c02dcedf
EZ
867 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
868 column is beyond frame width: don't subtract 1 "pixel" when
869 computing width of the stretch.
3e62b7e0
EZ
870 (reseat_at_next_visible_line_start): Undo the change made on
871 2011-09-17 that saved paragraph information and restored it after
872 the call to `reseat'. (Bug#9545)
56cd55c8 873
5ed99d36 8742011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
875
876 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
877 and turn window cursor on if cleared (Bug#9415).
878
5ed99d36 8792011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
880
881 * search.c (boyer_moore): Take unibyte characters from pattern
882 literally. (Bug#9458)
883
9bade7b2
EZ
8842011-09-18 Eli Zaretskii <eliz@gnu.org>
885
886 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
887
e5e9d610
PE
8882011-09-18 Paul Eggert <eggert@cs.ucla.edu>
889
87e4427a
PE
890 Fix minor problem found by static checking.
891 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
892 initialized, to pacify gcc -Wuninitialized.
893
e5e9d610
PE
894 * fileio.c: Report proper errno when syscall falls.
895 (Finsert_file_contents): Save and restore errno,
896 so that report_file_error outputs the correct diagnostic.
897 (Fwrite_region) [CLASH_DETECTION]: Likewise.
898
a1674f0b
EZ
8992011-09-18 Eli Zaretskii <eliz@gnu.org>
900
901 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
902
fbfb6dd4
EZ
9032011-09-17 Eli Zaretskii <eliz@gnu.org>
904
905 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
906 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
907
bb187662
EZ
9082011-09-17 Eli Zaretskii <eliz@gnu.org>
909
1137e8b8 910 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 911 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
912
913 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
914 (bidi_find_paragraph_start): Search back for paragraph beginning
915 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
916 (bidi_move_to_visually_next): Only trigger paragraph-related
917 computations when the last character is a newline or at EOB, not
918 just any NEUTRAL_B. (Bug#9470)
919
bb187662
EZ
920 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
921 truncated lines if point is covered by a display string. (Bug#9524)
922
2e621251
PE
9232011-09-16 Paul Eggert <eggert@cs.ucla.edu>
924
925 * xselect.c: Relax test for outgoing X longs (Bug#9498).
926 (cons_to_x_long): New function.
927 (lisp_data_to_selection_data): Use it. Correct the test for
928 short-versus-long data; it was negated. Break out of vector
929 loop, for efficiency, when a long datum is discovered.
930
91a15bc6
SM
9312011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
932
933 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
934
b41c3a35
EZ
9352011-09-16 Eli Zaretskii <eliz@gnu.org>
936
937 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
938 GCC PR/17406) by declaring this function with external scope.
939
7812ba2d
PE
9402011-09-15 Paul Eggert <eggert@cs.ucla.edu>
941
942 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
943 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
944
cf7edc2a
AS
9452011-09-15 Andreas Schwab <schwab@linux-m68k.org>
946
947 * editfns.c (Fformat): Correctly handle text properties on "%%".
948
bd01620e
EZ
9492011-09-15 Eli Zaretskii <eliz@gnu.org>
950
951 * xterm.c (x_draw_composite_glyph_string_foreground):
952 * w32term.c (x_draw_composite_glyph_string_foreground):
953 * term.c (encode_terminal_code):
954 * composite.c (composition_update_it, get_composition_id):
955 * xdisp.c (get_next_display_element)
956 (fill_composite_glyph_string): Add comments about special meaning
957 of TAB characters in a composition.
958
a02719a3
PE
9592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
960
961 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
962 This occurs when processing a multibyte format.
963 Problem reported by Wolfgang Jenker.
a02719a3 964
72589a3c
JB
9652011-09-15 Johan Bockgård <bojohan@gnu.org>
966
967 * xdisp.c (try_cursor_movement): Only check for exact match if
968 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
969
1c14176c
PE
9702011-09-14 Paul Eggert <eggert@cs.ucla.edu>
971
972 Remove unused external symbols.
973 * dispextern.h (calc_pixel_width_or_height): Remove decl.
974 * xdisp.c (calc_pixel_width_or_height): Now static.
975 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
976 * indent.c (check_display_width):
977 * w32term.c: Fix comment to match code.
978 * xterm.c, xterm.h (x_catching_errors): Remove.
979
d2eea5b5
PE
9802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
981
982 * xselect.c: Use signed conversions more consistently (Bug#9498).
983 (selection_data_to_lisp_data): Assume incoming selection data are
984 signed integers, not unsigned. This is to be consistent with
985 outgoing selection data, which was modified to use signed integers
986 in as part of the fix to Bug#9196 in response to Jan D.'s comment
987 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
988 expects long, not unsigned long.
989
46888499
EZ
9902011-09-14 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
993 computation of loop end. Reported by Johan Bockgård
994 <bojohan@gnu.org>.
995
ef8ef9fb
CY
9962011-09-13 Chong Yidong <cyd@stupidchicken.com>
997
998 * frame.c (Fother_visible_frames_p): Function deleted.
999
fa819fed
EZ
10002011-09-12 Eli Zaretskii <eliz@gnu.org>
1001
1002 * indent.c (compute_motion): Process display vector front to back
1003 rather than the other way around. (Bug#2496)
1004
2ba8e008
SM
10052011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1006
1007 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1008
20f53c69
CY
10092011-09-11 Chong Yidong <cyd@stupidchicken.com>
1010
1011 * minibuf.c (Fread_from_minibuffer): Doc fix.
1012
d562d7a4
EZ
10132011-09-11 Eli Zaretskii <eliz@gnu.org>
1014
1015 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1016 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1017
1c4d7f3d
LMI
10182011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1019
1020 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1021 value for non-existent files.
1022
b885bf36
EZ
10232011-09-11 Eli Zaretskii <eliz@gnu.org>
1024
1025 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1026 set its "size" to -1. This will set the modtime_size field of
1027 the corresponding buffer to -1, which is what
1028 verify-visited-file-modtime expects for files that do not exist.
1029 (Bug#9139)
1030
6612f0bf
PE
10312011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1032
1033 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1034 here ...
1035 * lisp.h: ... from here. push_key_description is no longer
1036 defined in keyboard.c, so its declaration should not be in
1037 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1038 logically belongs with push_key_description.
1039
dfb3f755
PE
10402011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1041
1042 * buffer.h: Include <sys/types.h> instead of <time.h>.
1043 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1044 Problem reported by Herbert J. Skuhra.
1045
3134906c
LMI
10462011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1047
1048 * xml.c (parse_region): Make the parsing work for
1049 non-comment-starting XML files again (bug#9144).
1050
8d903f4e
AS
10512011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1052
1053 * image.c (gif_load): Fix calculation of bottom and right corner.
1054 (Bug#9468)
1055
80ad64f4
EZ
10562011-09-10 Eli Zaretskii <eliz@gnu.org>
1057
1058 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1059 redisplay in small windows.
1060
208a048d
EZ
10612011-09-09 Eli Zaretskii <eliz@gnu.org>
1062
1063 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1064
9b1c252e
MR
10652011-09-08 Martin Rudalics <rudalics@gmx.at>
1066
1067 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1068 Operate on live windows only.
1069
2949f33b
JB
10702011-09-08 Juanma Barranquero <lekktu@gmail.com>
1071
1072 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1073
e08dcafd
EZ
10742011-09-07 Eli Zaretskii <eliz@gnu.org>
1075
1076 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1077 only under bidi iteration.
1078
115b96bd
JD
10792011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1080
1081 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1082
c8199d0f
PE
10832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1086 Without this fix, the command to link temacs failed due to an
1087 undefined symbol __builtin_isnan. This is because
1088 /usr/include/iso/math_c99.h #defines isnan(x) to
1089 __builtin_isnan(x), but the bundled gcc, which identifies itself
1090 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1091 a __builtin_isnan.
1092 * floatfns.c (isnan): #undef, and then #define to a clone of
1093 what's in data.c.
1094 (Fisnan): Always define, since it's always available now.
1095 (syms_of_floatfns): Always define isnan at the Lisp level.
1096
e39b275c 10972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1098
1099 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1100
b2db44d9 11012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1102
f4af5137 1103 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1104 The previous code assumed that file offsets (off_t values) fit in
1105 EMACS_INT variables, which is not true on typical 32-bit hosts.
1106 The code messed up by falsely reporting buffer overflow in cases
1107 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1108 when "big" contains more than 2**29 bytes, even though this
1109 inserts just one byte and does not overflow the buffer.
1110 (Finsert_file_contents): Store file offsets as off_t
1111 values, not as EMACS_INT values. Check for overflow when
1112 converting between EMACS_INT and off_t. When checking for
1113 buffer overflow or for overlap, take the offsets into account.
1114 Don't use EMACS_INT for small values where int suffices.
1115 When checking for overlap, fix a typo: ZV was used where
1116 ZV_BYTE was intended.
1117 (Fwrite_region): Don't assume off_t fits into 'long'.
1118 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1119
ecfc0a49
MA
11202011-09-05 Michael Albinus <michael.albinus@gmx.de>
1121
1122 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1123
6511acf2 11242011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1125
0999621a 1126 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1127
1128 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1129 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1130 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1131 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1132 (modify_event_symbol): Do not assume that the length of
1133 name_alist_or_stem is safe to alloca and fits in int.
1134 (Fexecute_extended_command): Likewise for function name and binding.
1135 (Frecursion_depth): Wrap around reliably on integer overflow.
1136 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1137 since some callers pass EMACS_INT values.
1138 (Fsingle_key_description): Don't crash if symbol name contains more
1139 than MAX_ALLOCA bytes.
1140 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1141 (get_minibuffer): Arg is now EMACS_INT, not int.
1142 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1143 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1144 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1145
2be7d702
PE
1146 * dbusbind.c (signature_cat): New function.
1147 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1148 Do not overrun buffer; instead, report string overflow.
1149
9d1df220
PE
1150 * dispnew.c (add_window_display_history): Don't overrun buffer.
1151 Truncate instead; this is OK since it's just a log.
1152
33ef5c64
PE
1153 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1154 even if the time zone offset is outlandishly large.
1155 Don't mishandle offset == INT_MIN.
1156
66c6fdd5
PE
1157 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1158 when creating daemon; the previous buffer-overflow check was incorrect.
1159
d749b01b
PE
1160 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1161 which has the guts of the old verror function.
1162
b5cd1905
PE
1163 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1164 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1165
6e1a67fb
PE
1166 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1167 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1168 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1169 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1170 length of string rather than counting it via multiple sprintfs;
1171 that's simpler and more reliable.
c21721cc
PE
1172 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1173 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1174 sprintf, in case result does not fit in int.
1175
c57b67fc
PE
1176 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1177 (fontset_from_font): Print it.
1178
8a401434
PE
1179 * frame.c (tty_frame_count): Now printmax_t, not int.
1180 (make_terminal_frame, set_term_frame_name): Print it.
1181 (x_report_frame_params): In X, window IDs are unsigned long,
1182 not signed long, so print them as unsigned.
1183 (validate_x_resource_name): Check for implausibly long names,
1184 and don't assume name length fits in 'int'.
1185 (x_get_resource_string): Don't blindly alloca invocation name;
1186 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1187 not fit in int.
1188
6e1a67fb
PE
1189 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1190 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1191 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1192
0df02bf3
PE
1193 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1194 Use esprintf, not sprintf, in case result does not fit in int.
1195
48e30793
PE
1196 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1197 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1198 it as a large positive number.
1199 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1200 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1201
a66ff6d8
PE
1202 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1203 in case result does not fit in int.
1204
aca216ff
PE
1205 * print.c (float_to_string): Detect width overflow more reliably.
1206 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1207 buffer overrun. Don't assume list length fits in 'int'. Treat
1208 print length of 0 as 0, not as infinity; to be consistent with other
1209 uses of print length in this function. Don't overflow print length
1210 index. Don't assume hash table size fits in 'long', or that
1211 vectorlike size fits in 'unsigned long'.
1212
31c286f7
PE
1213 * process.c (make_process): Use printmax_t, not int, to format
1214 process-name gensyms.
1215
55e5faa1
PE
1216 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1217
80f2e268
PE
1218 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1219 to avoid potential buffer overrun.
1220
670741ab
PE
1221 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1222 if X resource line is longer than 512 bytes.
1223
b7163a50
PE
1224 * xfns.c (x_window): Make sprintf buffer a bit bigger
1225 to avoid potential buffer overrun.
1226
ae58ff1f
PE
1227 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1228
c43c8a6a
PE
1229 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1230
3f8236f4
PE
12312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1232
53e9fe90 1233 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1234 Without these, Emacs silently mishandles large integers sometimes.
1235 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1236 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1237
6511acf2
PE
1238 * xdisp.c (try_window_id): Check Emacs fixnum range before
1239 converting to 'int'.
806add1d 1240
6511acf2 1241 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1242 Check that an Emacs fixnum is in range before assigning it to 'int'.
1243 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1244 values converted from Emacs fixnums.
1245 (Frecenter): Don't wrap around a line count if it is out of 'int'
1246 range; instead, treat it as an extreme value.
1247 (Fset_window_configuration, compare_window_configurations):
1248 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1249
6511acf2
PE
1250 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1251 that can exceed INT_MAX. Check that EMACS_INT value is in range
1252 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1253 (match_limit): Don't assume that a fixnum can fit in 'int'.
1254
6511acf2 1255 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1256 exceed INT_MAX.
1257
6511acf2 1258 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1259 (Fvertical_motion): Don't wrap around LINES values that don't fit
1260 in 'int'. Instead, treat them as extreme values. This is good
1261 enough for windows, which can't have more than INT_MAX lines anyway.
1262
fcb901a7
LMI
12632011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1264
0f2f6b6d
LMI
1265 * Require libxml/parser.h to avoid compilation warning.
1266
fcb901a7
LMI
1267 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1268
1269 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1270 since this reportedly can destroy thread storage.
1271
6e20a0d4
CY
12722011-08-30 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * syntax.c (find_defun_start): Update all cache variables if
1275 exiting early (Bug#9401).
1276
148ae00e
EZ
12772011-08-30 Eli Zaretskii <eliz@gnu.org>
1278
f6cfbd8f
EZ
1279 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1280
148ae00e
EZ
1281 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1282 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1283 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1284
1285 * term.c (tty_append_glyph): New function.
1286 (produce_stretch_glyph): Static function and its prototype deleted.
1287
a66cfb1c
SM
1288 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1289 Add prototypes.
148ae00e 1290
c4a07a4c
PE
12912011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1294 when checking :margin (Bug#9390).
1295 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1296 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1297 so that the name doesn't mislead. All uses changed.
1298
6bc8cd65
JB
12992011-08-28 Johan Bockgård <bojohan@gnu.org>
1300
1301 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1302 set_tty_hooks.
1303
dca4927e
EZ
13042011-08-27 Eli Zaretskii <eliz@gnu.org>
1305
1306 * xdisp.c (move_it_to): Don't bail out early when reaching
1307 position beyond to_charpos, if we are scanning backwards.
1308 (move_it_vertically_backward): When DY == 0, make sure we get to
1309 the first character in the line after the newline.
1310
f2cad773
PE
13112011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1314 (ccl_driver): Do not generate an out-of-range pointer.
1315 (Fccl_execute_on_string): Remove unnecessary check for
1316 integer overflow, noted by Stefan Monnier in
1317 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1318 Remove a FIXME that didn't need fixing.
1319 Simplify the newly-introduced buffer reallocation code.
1320
0cae2cdb
JB
13212011-08-27 Juanma Barranquero <lekktu@gmail.com>
1322
1323 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1324
5fc295a4 13252011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1326
70c60eb2 1327 Integer and memory overflow issues (Bug#9196).
726e0ab1 1328
d31850da
PE
1329 * doc.c (get_doc_string): Rework so that
1330 get_doc_string_buffer_size is the actual buffer size, rather than
1331 being 1 less than the actual buffer size; this makes xpalloc more
1332 convenient.
1333
a69fbedb
PE
1334 * image.c (x_allocate_bitmap_record, cache_image):
1335 * xselect.c (Fx_register_dnd_atom):
1336 Simplify previous changes by using xpalloc.
1337
fe5c5d37
PE
1338 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1339 since either will do and ptrdiff_t is convenient with xpalloc.
1340
0065d054
PE
1341 * charset.c (charset_table_size)
1342 (struct charset_sort_data.priority): Now ptrdiff_t.
1343 (charset_compare): Don't overflow if priorities differ greatly.
1344 (Fsort_charsets): Don't assume list length fits in int.
1345 Check for size-calculation overflow when allocating sort data.
1346 (syms_of_charset): Allocate an initial charset table that is
1347 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1348
1349 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1350
1351 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1352 The actual value is always <= INT_MAX, and leaving it unsigned made
1353 overflow checking harder.
1354
1355 * dispextern.h (struct glyph_matrix.rows_allocated)
1356 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1357 with xpalloc. The values are still always <= INT_MAX.
1358
1359 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1360
1361 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1362 (SAFE_NALLOCA): New macro.
1363
1364 * region-cache.c (struct boundary.pos, find_cache_boundary)
1365 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1366 (set_cache_region, invalidate_region_cache)
1367 (revalidate_region_cache, know_region_cache, region_cache_forward)
1368 (region_cache_backward, pp_cache):
1369 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1370 so that ptrdiff_t * can be passed to xpalloc.
1371 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1372 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1373 (pp_cache): Don't assume cache_len fits in int.
1374 * region-cache.h: Adjust extern decls to match.
1375
1376 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1377 EMACS_INT, since either will do, for xpalloc.
1378
1379 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1380 (xnmalloc, xnrealloc, xpalloc): New functions.
1381
726e0ab1
PE
1382 * bidi.c (bidi_shelve_header_size): New constant.
1383 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1384 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1385
51f30bc5 1386 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1387 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1388 (overlay_strings):
1389 Don't update size of array until after memory allocation succeeds,
1390 because xmalloc/xrealloc may not return.
0065d054
PE
1391 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1392 now that we have proper integer overflow checking.
1393 (record_overlay_string, overlay_strings): Catch overflows when
1394 calculating size of overlay_str_buf.
726e0ab1 1395
0065d054
PE
1396 * callproc.c (Fcall_process): Check for size overflow when
1397 calculating size of args2.
1398 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1399 Normally we prefer signed values, but sticking with ptrdiff_t would
1400 require adding more-complicated checks.
726e0ab1
PE
1401
1402 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1403 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1404 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1405 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1406
1407 * character.c (Fstring): Check for size-calculation overflow.
1408
1409 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1410 unnecessary integer overflow. Check for size overflow.
1411 (encode_coding_object): Don't update size until xmalloc succeeds.
1412
1413 * composite.c (get_composition_id): Check for overflow in glyph
1414 length calculations.
1415
1416 Integer and memory overflow fixes for display code.
1417 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1418 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1419 (scrolling_window): Check for overflow in size calculations.
1420 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1421 Don't assume glyph table len fits in int.
1422 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1423 (row_table_size): Now ptrdiff_t, not int.
1424 (scrolling_window): Avoid overflow in size calculations.
1425 Don't update size until allocation succeeds.
1426 * fns.c (concat): Check for overflow in size calculations.
1427 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1428 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1429 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1430
1431 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1432 (get_doc_string): Check for size calculation overflow.
1433 Don't update size until allocation succeeds.
1434 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1435 EMACS_INT, where ptrdiff_t will do.
1436 (Fsubstitute_command_keys): Check for string overflow.
1437
1438 * editfns.c (set_time_zone_rule): Don't assume environment length
1439 fits in int.
1440 (message_length): Now ptrdiff_t, not int.
1441 (Fmessage_box): Don't update size until allocation succeeds.
1442 Don't assume message length fits in int.
1443 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1444
0065d054
PE
1445 * emacs.c (main): Do not reallocate argv, since there is a null at
1446 the end that can be overwritten, and this way there's no need to
1447 worry about size-calculation overflow.
1448 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1449
1450 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1451 alloc succeeds.
1452 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1453
1454 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1455 (x_set_scroll_bar_width, x_figure_window_size):
1456 Check for integer overflow.
1457 (x_set_alpha): Do not assume XINT fits in int.
1458
1459 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1460 This is for the members text_lines, text_cols, total_lines, total_cols,
1461 where the system imposes an 'int' limit.
1462
1463 * fringe.c (Fdefine_fringe_bitmap):
1464 Don't update size until alloc works.
1465
1466 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1467 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1468
1469 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1470 Check for size-calculation overflow.
1471 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1472 do, as we prefer signed integers.
1473 (id_to_widget.max_size, id_to_widget.used)
1474 (xg_store_widget_in_map, xg_remove_widget_from_map)
1475 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1476 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1477 Use and return ptrdiff_t, not int.
1478 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1479 * gtkutil.h: Change prototypes to match the above.
1480
1481 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1482 are duplicate now that they've been promoted to lisp.h.
1483 (x_allocate_bitmap_record, x_alloc_image_color)
1484 (make_image_cache, cache_image, xpm_load):
1485 Don't update size until alloc is done.
1486 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1487 (x_detect_edges):
3256efce 1488 Check for size calculation overflow.
726e0ab1
PE
1489 (ct_colors_allocated_max): New constant.
1490 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1491 overflow.
3256efce 1492
726e0ab1
PE
1493 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1494 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1495 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1496 Use ptrdiff_t, not int, to count maps.
1497 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1498 calculations. Don't update size until allocation succeeds.
1499 Redo calculations to avoid overflow.
726e0ab1
PE
1500 * keyboard.h: Change prototypes to match the above.
1501
1502 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1503 to count maps.
1504 (current_minor_maps): Check for size calculation overflow.
1505 * keymap.h: Change prototypes to match the above.
1506
1507 * lread.c (read1, init_obarray): Don't update size until alloc done.
1508
1509 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1510 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1511
726e0ab1
PE
1512 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1513 Now ptrdiff_t, not int.
1514 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1515 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1516
1517 * process.c (Fnetwork_interface_list): Check for overflow
1518 in size calculation.
1519
1520 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1521
1522 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1523 overflow. Don't bother calling xmalloc when xrealloc will do.
1524
1525 * search.c (Freplace_match): Check for size calculation overflow.
1526 (Fset_match_data): Don't assume list lengths fit in 'int'.
1527
1528 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1529 for command line length. Do not attempt to address one before the
1530 beginning of an array, as that's not portable.
1531
1532 * term.c (max_frame_lines): Remove; unused.
1533 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1534 not int.
1535 (encode_terminal_code, calculate_costs): Check for size
1536 calculation overflow.
1537 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1538 table lengths and related sizes. Don't update size until alloc
1539 done. Redo calculations to avoid overflow.
1540 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1541
1542 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1543 subtracting pointers.
1544 (gobble_line): Check for overflow more carefully. Don't update size
1545 until alloc done.
1546
1547 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1548 Don't update size until alloc done.
1549 Redo size calculations to avoid overflow.
1550 Check for size calculation overflow.
0065d054 1551 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1552
1553 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1554 Use ptrdiff_t, not int, for sizes.
1555 (store_mode_line_noprop_char): Don't update size until alloc done.
1556
0065d054
PE
1557 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1558 Use ptrdiff_t, not int, for sizes.
1559 (Finternal_make_lisp_face, cache_face):
1560 Check for size calculation overflow.
1561 (cache_face): Treat size calculation overflows as if they were
1562 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1563
1564 * xfns.c (x_encode_text, x_set_name_internal)
1565 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1566 sizes, since they can exceed INT_MAX in size. Check for size
1567 calculation overflow.
1568
0065d054
PE
1569 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1570 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1571 Don't update size until alloc done.
1572
0065d054 1573 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1574 as sprintf is limited to int lengths.
1d526e2f 1575
252c5ee1
PE
1576 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1577 (X_LONG_MIN): New macros.
864d7ce7
PE
1578 Use them to make the following changes clearer.
1579 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1580 This change doesn't affect the value now, but it may help remind
1581 future maintainers not to raise the value too much later.
1582 (SELECTION_QUANTUM): Remove, replacing with ...
1583 (selection_quantum): ... new function, which avoids overflow.
1584 All uses changed.
1585 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1586 assumption that selection length fits in 'int'.
1587 (x_reply_selection_request, x_handle_selection_request)
1588 (x_get_window_property, receive_incremental_selection)
1589 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1590 (lisp_data_to_selection_data, clean_local_selection_data):
1591 Use ptrdiff_t, not int, to record length of selection.
1592 (x_reply_selection_request, x_get_window_property)
1593 (receive_incremental_selection, x_property_data_to_lisp):
1594 Redo calculations to avoid overflow.
1595 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1596 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1597 something.
1598 (x_get_window_property, receive_incremental_selection)
1599 (lisp_data_to_selection_data, x_property_data_to_lisp):
1600 Check for size-calculation overflow.
1601 (x_get_window_property, receive_incremental_selection)
1602 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1603 Don't store size until memory allocation succeeds.
1604 (x_get_window_property): Plug memory leak on memory exhaustion.
1605 Don't double-block input; malloc is safe here. Don't assume 2**34
1606 - 4 fits in unsigned long. Add an xassert to check
1607 XGetWindowProperty overflow. Be more careful about overflow
1608 calculations, and distinguish size from memory overflow better.
1609 (receive_incremental_selection): When tracing, don't assume
1610 unsigned int is less than INT_MAX.
1611 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1612 harmful) conversions of unsigned short to int.
1613 (lisp_data_to_selection_data): Don't assume that integers
1614 in the range -65535 through -1 fit in an X unsigned short.
1615 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1616 result parameters unless successful. Rely on cons_to_unsigned
1617 to report problems with elements; the old code wasn't right anyway.
1618 (x_check_property_data): Check for int overflow; we cannot use
1619 a wider type due to X limits.
1620 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1621
726e0ab1 1622 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1623
0065d054
PE
1624 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1625 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1626 (x_color_cells): Don't store size until memory allocation succeeds.
1627 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1628 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1629 (x_term_init): Don't assume length fits in int (sprintf is limited
1630 to int size).
bc18e09d 1631
ebfa62c0
PE
1632 Use ptrdiff_t for composition IDs.
1633 * character.c (lisp_string_width):
1634 * composite.c (composition_table_size, n_compositions)
1635 (get_composition_id, composition_gstring_from_id):
1636 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1637 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1638 * window.c (Frecenter):
1639 Use ptrdiff_t, not int, for composition IDs.
1640 * composite.c (get_composition_id): Check for integer overflow.
1641 * composite.h: Adjust prototypes to match the above changes.
1642
d3411f89
PE
1643 Use ptrdiff_t for hash table indexes.
1644 * category.c (hash_get_category_set):
1645 * ccl.c (ccl_driver):
1646 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1647 * coding.c (coding_system_charset_list, detect_coding_system):
1648 * coding.h (struct coding_system.id):
1649 * composite.c (get_composition_id, gstring_lookup_cache):
1650 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1651 * image.c (xpm_get_color_table_h):
1652 * lisp.h (hash_lookup, hash_put):
1653 * minibuf.c (Ftest_completion):
1654 Use ptrdiff_t for hash table indexes, not int (which is too
1655 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1656 32-bit --with-wide-int hosts).
1657
e097a6fa
PE
1658 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1659 Add a FIXME comment about memory leaks.
1660 (syms_of_charset): Don't assume xmalloc returns.
1661
5637687f
PE
1662 Don't assume that stated character widths fit in int.
1663 * character.c (Fchar_width, c_string_width, lisp_string_width):
1664 * character.h (CHAR_WIDTH):
1665 * indent.c (MULTIBYTE_BYTES_WIDTH):
1666 Use sanitize_char_width to avoid undefined and/or bad behavior
1667 with outlandish widths.
a66cfb1c 1668 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1669 now that we have two such functions. All uses changed.
1670 (sanitize_char_width): New inline function.
1671
a2271ba2
PE
1672 Don't assume that tab-width fits in int.
1673 * character.h (sanitize_width): New inline function.
1674 (SANE_TAB_WIDTH): New macro.
1675 (ASCII_CHAR_WIDTH): Use it.
1676 * indent.c (sane_tab_width): Remove. All uses replaced by
1677 SANE_TAB_WIDTH (current_buffer).
1678 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1679
18c52557
PE
1680 * fileio.c: Integer overflow issues with file modes.
1681 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1682
caeeedc1
PE
1683 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1684 Remove unreachable code.
1685 (read_hex, load_charset_map_from_file): Check for integer overflow.
1686
50849c52
PE
1687 * xterm.c: don't go over XClientMessageEvent limit
1688 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1689 (x_send_scroll_bar_event): Likewise. Check that the size does not
1690 exceed limits imposed by XClientMessageEvent, as well as the usual
1691 ptrdiff_t and size_t limits.
1692
b13995db
PE
1693 * keyboard.c: Overflow, signedness and related fixes.
1694 (make_lispy_movement): Use same integer type in forward decl
1695 that is used in the definition.
1696 (read_key_sequence, keyremap_step):
1697 Change bufsize argument back to int, undoing my 2011-03-30 change.
1698 We prefer signed types, and int is wide enough here.
1699 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1700 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1701 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1702 length, not size_t. Use ptrdiff_t for index, not int.
1703 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1704 possibility of integer overflow.
1705
13464394
PE
1706 Overflow, signedness and related fixes for images.
1707
1708 * dispextern.h (struct it.stack[0].u.image.image_id)
1709 (struct_it.image_id, struct image.id, struct image_cache.size)
1710 (struct image_cache.used, struct image_cache.ref_count):
1711 * gtkutil.c (update_frame_tool_bar):
1712 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1713 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1714 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1715 * nsmenu.m (update_frame_tool_bar):
1716 * xdisp.c (calc_pixel_width_or_height):
1717 * xfns.c (image_cache_refcount):
1718 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1719 on typical 64-bit hosts.
1720
1721 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1722 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1723 Omit unnecessary casts to int.
1724 (parse_image_spec): Check that integers fall into 'int' range
1725 when the callers expect that.
1726 (image_ascent): Redo ascent calculation to avoid int overflow.
1727 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1728 (lookup_image): Remove unnecessary tests.
1729 (xbm_image_p): Locals are now of int, not EMACS_INT,
1730 since parse_image_check makes sure they fit into int.
1731 (png_load, gif_load, svg_load_image):
1732 Prefer int to unsigned where either will do.
1733 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1734 old tiff_error_handler and tiff_warning_handler.
1735 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1736 stack buffer overflows. It uses only the features of vsnprintf
1737 that are common to both POSIX and native Microsoft.
1738 (tiff_error_handler, tiff_warning_handler): Use it.
1739 (tiff_load, gif_load, imagemagick_load_image):
1740 Don't assume :index value fits in 'int'.
1741 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1742 (imagemagick_load_image): Check that crop parameters fit into
1743 the integer types that MagickCropImage accepts. Don't assume
1744 Vimagemagick_render_type has a nonnegative value. Don't assume
1745 size_t fits in 'long'.
1746 (gs_load): Use printmax_t to print the widest integers possible.
1747 Check for integer overflow when computing image height and width.
1748
c11821d4
EZ
17492011-08-26 Eli Zaretskii <eliz@gnu.org>
1750
1751 * xdisp.c (redisplay_window): Don't force window start if point
1752 will be invisible in the resulting window. (Bug#9324)
1753
0c95fcf7
EZ
17542011-08-25 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1757 the display spec is of the form `(space ...)'.
1758 (handle_display_spec): Return the value returned by
1759 handle_single_display_spec, not just 1 or zero.
1760 (handle_single_display_spec): If the display spec is of the form
1761 `(space ...)', and specifies display in the text area, return 2
1762 rather than 1.
fee65a97 1763 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1764 accurately, and prefer exact match for point under bidi.
1765 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1766
1767 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1768 into disp_prop; all users changed.
1769
1770 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1771 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1772 for the text covered by the display property.
1773
e4ed06f1
CY
17742011-08-25 Chong Yidong <cyd@stupidchicken.com>
1775
1776 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1777 Change return value to nil.
1778 (Frecord_buffer): Delete unused function.
1779
f67cdd7f
EZ
17802011-08-24 Eli Zaretskii <eliz@gnu.org>
1781
5980d4c6
EZ
1782 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1783 buffers, return left-to-right.
8610fe8b
EZ
1784 (set_cursor_from_row): Consider candidate row a win if its glyph
1785 represents a newline and point is on that newline. Fixes cursor
1786 positioning on the newline at EOL of R2L text within L2R
1787 paragraph, and vice versa.
1788 (try_cursor_movement): Check continued rows, in addition to
1789 continuation rows. Fixes unwarranted scroll when point enters a
1790 continued line of R2L text within an L2R paragraph, or vice versa.
1791 (cursor_row_p): Consider the case of point being equal to
1792 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1793 from the end of a short line to the beginning of a continued line
1794 of R2L text within L2R paragraph.
1795 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1796 composed characters.
5980d4c6 1797
f67cdd7f
EZ
1798 * bidi.c (bidi_check_type): Use xassert.
1799 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1800 members.
1801
bca633fb
EZ
18022011-08-23 Eli Zaretskii <eliz@gnu.org>
1803
1804 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1805 a character.
1806
4a5885a7
CY
18072011-08-23 Chong Yidong <cyd@stupidchicken.com>
1808
1809 * nsfont.m (ns_otf_to_script): Fix typo.
1810
0902a04e
KH
18112011-08-22 Kenichi Handa <handa@m17n.org>
1812
1813 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1814 extra slot even if the purpose is char-code-property-table.
1815
1a2e6670
EZ
18162011-08-23 Eli Zaretskii <eliz@gnu.org>
1817
8ddde651
EZ
1818 * xdisp.c (redisplay_window): When computing centering_position,
1819 account for the height of the header line. (Bug#8874)
1820
425cc014
EZ
1821 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1822 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1823 candidate is selected by the mouse, and that candidate has a
1824 composed character under the mouse.
1825
1a2e6670
EZ
1826 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1827 coordinates reported by pos-visible-in-window-p for a composed
1828 character in column zero.
1829
8b76d6f8
SM
18302011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1831
1832 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1833
dac347dd
EZ
18342011-08-22 Eli Zaretskii <eliz@gnu.org>
1835
1836 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1837 consider it a hit if to_charpos is anywhere in the range of the
1838 composed buffer positions.
1839
e013fb34
CY
18402011-08-22 Chong Yidong <cyd@stupidchicken.com>
1841
1842 * image.c (gif_load): Don't assume that each subimage has the same
1843 dimensions as the base image. Handle disposal method that is
1844 "undefined" by the gif spec (Bug#9335).
1845
bd1ba3e8
CY
18462011-08-20 Chong Yidong <cyd@stupidchicken.com>
1847
1848 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1849 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1850
54a1215b
EZ
18512011-08-19 Eli Zaretskii <eliz@gnu.org>
1852
823564e5
EZ
1853 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1854 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1855 from an Org mode buffer to a Speedbar frame.
1856
54a1215b
EZ
1857 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1858 a composition, take its buffer position from IT->cmp_it.charpos.
1859 Fixes cursor positioning at the beginning of a line that begins
1860 with a composed character.
1861
9778ebcc
EZ
18622011-08-18 Eli Zaretskii <eliz@gnu.org>
1863
0be6ee06
EZ
1864 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1865 character bidirectional type, use STRONG_L instead. Fixes crashes
1866 in a buffer produced by `describe-categories'.
1867
9778ebcc
EZ
1868 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1869 members before the level stack, so they would be saved and
1870 restored when copying iterator state. Fixes incorrect reordering
1871 around TABs covered by display properties.
1872
156bffbe
AS
18732011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1874
6b02f655 1875 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1876
72ad093b
CY
18772011-08-17 Chong Yidong <cyd@stupidchicken.com>
1878
1879 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1880 (internal_condition_case_2, internal_condition_case_n):
1881 Remove unnecessary aborts (Bug#9081).
72ad093b 1882
35774242
EZ
18832011-08-17 Eli Zaretskii <eliz@gnu.org>
1884
1885 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1886 has no `load' handler, try opening the file locally. (Bug#9311)
1887
db76dd85
KB
18882011-08-16 Ken Brown <kbrown@cornell.edu>
1889
1890 * gmalloc.c: Expand comment.
1891
b215eee5
EZ
18922011-08-16 Eli Zaretskii <eliz@gnu.org>
1893
1894 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1895 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1896
a4579d33
KB
18972011-08-16 Ken Brown <kbrown@cornell.edu>
1898
1899 Fix memory allocation problems in Cygwin build (Bug#9273).
1900
1901 * unexcw.c ( __malloc_initialized): Declare external variable.
1902 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1903
8b76d6f8
SM
1904 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1905 New variables.
a4579d33
KB
1906 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1907 dumped emacs.
1908 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1909 in the static heap.
1910 [CYGWIN] (special_realloc): New function.
1911 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1912 requests to realloc storage in the static heap.
1913
3ebec551
PE
19142011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1915
1916 * bidi.c (bidi_initialize): Remove unused local.
1917
9fd8be00
EZ
19182011-08-15 Eli Zaretskii <eliz@gnu.org>
1919
6b02f655
SM
1920 * bidimirror.h:
1921 * biditype.h: Remove file.
1922 * makefile.w32-in ($(BLD)/bidi.$(O)):
1923 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1924
1925 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1926
1927 * chartab.c: Improve commentary for the uniprop_table API.
1928
32413314
EZ
1929 * bidi.c (bidi_paragraph_init): Support zero value of
1930 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1931 (bidi_initialize): Use uniprop_table instead of including
1932 biditype.h and bidimirror.h.
32413314 1933
9fd8be00
EZ
1934 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1935 coordinates of the iterator when restoring from ppos_it.
1936 (Bug#9296)
1937
5cf2b69b
KH
19382011-08-14 Kenichi Handa <handa@m17n.org>
1939
1940 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1941 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1942
daf17d00
EZ
19432011-08-14 Eli Zaretskii <eliz@gnu.org>
1944
1945 * xdisp.c (move_it_in_display_line_to): Don't invoke
1946 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1947 ppos_it. Fixes vertical cursor motion when line beginning is
1948 covered by an image. (Bug#9296)
1949
08e3161a
JD
19502011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1951
1952 * nsterm.h (ns_run_ascript): Declare.
1953 (NSAPP_DATA2_RUNASSCRIPT): Define.
1954
1955 * nsfns.m (as_script, as_result, as_status): New static variables.
1956 (ns_run_ascript): New function.
5e617bc2 1957 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1958 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1959 the event loop. Get status from as_status (Bug#7276).
1960
1961 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1962 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1963 the event loop (Bug#7276).
1964
a3720aa2
AS
19652011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1966
1967 * gnutls.c (QCgnutls_bootprop_priority)
1968 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1969 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1970 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1971 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1972 (QCgnutls_bootprop_verify_hostname_error)
1973 (QCgnutls_bootprop_callbacks_verify): Rename from
1974 Qgnutls_bootprop_..., all uses changed.
1975
1976 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1977 uses changed.
1978
0a0d27fb
PE
19792011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1980
19d5c50c
PE
1981 * xfaces.c (Qframe_set_background_mode): Now static.
1982 * dispextern.h (Qframe_set_background_mode): Remove decl.
1983
0a0d27fb
PE
1984 * process.c (Fnetwork_interface_info): Declare local only if needed.
1985
377538cb
JD
19862011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1987
1988 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1989 (Fnetwork_interface_list): Allocate in increments of bytes instead
1990 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1991 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1992 sockaddr.
1993 (struct ifflag_def): notrailers is smart on OSX.
1994 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1995 Get hardware address with getifaddrs if available.
1996
08fff70c
EZ
19972011-08-12 Eli Zaretskii <eliz@gnu.org>
1998
1999 * xdisp.c (iterate_out_of_display_property): xassert that
2000 IT->position is set to within IT->object's boundaries. Break from
2001 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2002 when IT->position is set up wrongly due to some bug.
2003 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2004 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2005 entry. Force push_it to save on the stack the current
2006 buffer/string position, to be restored by pop_it. Fix flags in
2007 the iterator structure wrt the object coming from a display
2008 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2009 properties. (Bug#9284)
2010
7be1c708 20112011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2012
7be1c708
CY
2013 * fontset.c (fontset_get_font_group): Add proper type checks.
2014 (Bug#9172)
aac0c6e3 2015
7be1c708 20162011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2017
7be1c708
CY
2018 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2019 and LC_VERSION_MIN_MACOSX.
2020 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2021 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2022
97bb72a6
EZ
20232011-08-08 Eli Zaretskii <eliz@gnu.org>
2024
2025 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2026 no-display-properties-and-no-overlays under bidi display.
2027 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2028 properties and overlays.
97bb72a6 2029
d5617611
CY
20302011-08-08 Chong Yidong <cyd@stupidchicken.com>
2031
37e11a63
CY
2032 * editfns.c (Fset_time_zone_rule): Document relationship with the
2033 setenv function.
2034
d5617611
CY
2035 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2036 the font entity extracted from the cache (Bug#8109).
2037
58872834
CY
20382011-08-07 Chong Yidong <cyd@stupidchicken.com>
2039
2040 * composite.c (autocmp_chars): Don't reset point. That is done by
2041 restore_point_unwind (Bug#5984).
2042
75bfc667
JL
20432011-08-07 Juri Linkov <juri@jurta.org>
2044
2045 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2046 to show the arg `TIME' instead of `TIMEVAL'.
2047
d1410150
EZ
20482011-08-06 Eli Zaretskii <eliz@gnu.org>
2049
2050 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2051 display property strides EOL and includes a newline, as in
2052 longlines-mode. (Bug#9254)
75b771e4
EZ
2053 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2054 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2055
2056 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2057 is non-zero, even if the data buffer is NULL. Fixes a crash in
2058 vertical-motion with longlines-mode. (Bug#9254)
2059
35928349
EZ
20602011-08-05 Eli Zaretskii <eliz@gnu.org>
2061
ec7cc85b
EZ
2062 * bidi.c <bidi_cache_total_alloc>: Now static.
2063 (bidi_initialize): Initialize bidi_cache_total_alloc.
2064
8b76d6f8 2065 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2066 cache. (Bug#9221)
2067
2068 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2069 amount allocated this far in `bidi_cache_total_alloc'.
2070 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2071 non-zero, only free the data buffer without restoring the cache
2072 contents. All callers changed.
2073
2074 * dispextern.h (bidi_unshelve_cache): Update prototype.
2075
2076 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2077 (move_it_in_display_line, move_it_to)
2078 (move_it_vertically_backward, move_it_by_lines): Replace the call
2079 to xfree to an equivalent call to bidi_unshelve_cache.
2080 (move_it_in_display_line_to): Fix logic of returning
412b6358 2081 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2082
e2e2423b
EZ
20832011-08-05 Eli Zaretskii <eliz@gnu.org>
2084
2085 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2086 came from a string character with a `cursor' property. (Bug#9229)
2087
ae9e757a
JD
20882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * Makefile.in (LIB_PTHREAD): New variable.
2091 (LIBES): Add LIB_PTHREAD (Bug#9216).
2092
2093 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2094 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2095
213bd7f2
AS
20962011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2097
6b02f655 2098 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2099
99aaf75f
JD
21002011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2101
2102 * xterm.c (x_find_topmost_parent): New function.
2103 (x_set_frame_alpha): Find topmost parent window with
2104 x_find_topmost_parent and set the property there also (bug#9181).
2105 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2106
c74e9d86
PE
21072011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 * callproc.c (Fcall_process): Avoid vfork clobbering
2110 the local vars buffer, coding_systems, current_dir.
2111
640c8776
SM
21122011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2113
2114 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2115
f26d0e4c
PE
21162011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2117
8a10d76c
PE
2118 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2119 so that it is not optimized away.
2120
f26d0e4c
PE
2121 * xdisp.c (compute_display_string_pos): Remove unused local.
2122
55439c61
EZ
21232011-08-02 Eli Zaretskii <eliz@gnu.org>
2124
2125 Fix slow cursor motion and scrolling in large buffers with
2126 selective display, like Org Mode buffers. (Bug#9218)
2127
2128 * dispextern.h (struct bidi_it): New member disp_prop_p.
2129
2130 * xdisp.c: Remove one-slot cache of display string positions.
2131 (compute_display_string_pos): Accept an additional argument
5e617bc2 2132 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2133 for a display string or property. If found, set DISP_PROP_P
2134 non-zero.
2135
2136 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2137 DISP_PROP_P, and pass it to compute_display_string_pos.
2138 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2139 non-zero. All callers of bidi_fetch_char changed.
2140
fb33fa43
SM
21412011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2142
2143 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2144
b099e063
DM
21452010-12-03 Don March <don@ohspite.net>
2146
2147 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2148 last character M-[char] is translated to ESC [char] (bug#7541).
2149
5cc7f7af
KH
21502011-08-02 Kenichi Handa <handa@m17n.org>
2151
d0fffa3f 2152 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2153
2154 * chartab.c (uniprop_table): Make it non-static.
2155
525d5e6e
EZ
21562011-08-01 Eli Zaretskii <eliz@gnu.org>
2157
2158 * xdisp.c (forward_to_next_line_start): Accept additional argument
2159 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2160 on the newline.
2161 (reseat_at_next_visible_line_start): Use the bidi iterator state
2162 returned by forward_to_next_line_start to restore the state of
2163 it->bidi_it after backing up to previous newline. (Bug#9212)
2164
31011111
AS
21652011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2166
2167 * regex.c (re_comp): Protoize.
2168 (re_exec): Fix return type.
2169 (regexec): Fix type of `ret'. (Bug#9203)
2170
476371c4
PE
21712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2172
e5d76069
PE
2173 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2174 This is needed if max-image-size is a floating-point number.
2175
9a79b20c
AS
21762011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2177
2178 * print.c (print_object): Print empty symbol as ##.
2179
2180 * lread.c (read1): Read ## as empty symbol.
2181
d8c2fa78
AA
21822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2183
2184 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2185 setting frame foreground color (Bug#9175).
2186 (x_set_background_color): Likewise.
2187
ffe57a7a
AA
2188 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2189 contents (Bug#9176).
2190 (EmacsTooltip -init): Remove bezels and add shadows to
2191 tooltip windows.
2192
bf3492a5
AA
2193 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2194 or scroll bar (Bug#8470).
2195
d55e9c53
AA
2196 * nsfont.m (nsfont_open): Remove assignment to voffset and
2197 unnecessary vars hshink, expand, hd, full_height, min_height.
2198 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2199
2200 * nsterm.h (nsfont_info): Remove voffset field.
2201
d8c2fa78 22022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2203
2204 Implement strike-through and overline on NextStep (Bug#8863).
2205
2206 * nsfont.m (nsfont_open): Use underline position provided by font,
2207 instead of hard-coded value of 2.
2208 (nsfont_draw): Call ns_draw_text_decoration instead.
2209
2210 * nsterm.h: Add declaration for ns_draw_text_decoration.
2211
2212 * nsterm.m (ns_draw_text_decoration): New function for drawing
2213 underline, overline, and strike-through.
2214 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2215 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2216 accommodate underlining, etc.
4843aac3 2217
4cc60b9b
EZ
22182011-07-28 Eli Zaretskii <eliz@gnu.org>
2219
bc7ece87
EZ
2220 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2221 default.
4cc60b9b 2222
476371c4
PE
22232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2224
66606eea
PE
2225 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2226 Without this fix, if a signal arrives just after memory fills up,
2227 'malloc' might be invoked reentrantly.
2228
476371c4
PE
2229 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2230 In other words, assume that every image size is allowed, on non-X
2231 hosts. This assumption is probably wrong, but it lets Emacs compile.
2232
f3fcc40d
AS
22332011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2234
2235 * regex.c (re_iswctype): Convert return values to boolean.
2236
350c992f
EZ
22372011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2238
2239 * xdisp.c (compute_display_string_pos): Don't use cached display
2240 string position if the buffer had its restriction changed.
2241 (Bug#9184)
2242
5266b4bb
PE
22432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2244
2245 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2246
2573a837 22472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2248
41f55ccd 2249 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2250
39e378da
PE
2251 * bidi.c: Integer size and overflow fixes.
2252 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2253 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2254 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2255 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2256 (bidi_find_other_level_edge):
2257 Use ptrdiff_t instead of EMACS_INT where either will do.
2258 This works better on 32-bit hosts configured --with-wide-int.
2259 (bidi_cache_ensure_space): Check for size-calculation overflow.
2260 Use % rather than repeated addition, for better worst-case speed.
2261 Don't set bidi_cache_size until after xrealloc returns, because it
2262 might not return.
2263 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2264 (bidi_cache_ensure_space): Also check that the bidi cache size
2265 does not exceed that of the largest Lisp string or buffer. See Eli
2266 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2267
5e927815
PE
2268 * alloc.c (__malloc_size_t): Remove.
2269 All uses replaced by size_t. See Andreas Schwab's note
2270 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2271
ca4aa935
PE
2272 * image.c: Improve checking for integer overflow.
2273 (check_image_size): Assume that f is nonnull, since
2274 it is always nonnull in practice. This is one less thing to
2275 worry about when checking for integer overflow later.
2276 (x_check_image_size): New function, which checks for integer
2277 overflow issues inside X.
2278 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2279 This removes the need for a memory_full check.
2280 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2281 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2282 (xbm_read_bitmap_data): Change locals back to 'int', since
2283 their values must fit in 'int'.
2284 (xpm_load_image, png_load, tiff_load):
2285 Invoke x_create_x_image_and_pixmap earlier,
2286 to avoid much needless work if the image is too large.
2287 (tiff_load): Treat overly large images as if
2288 x_create_x_image_and_pixmap failed, not as malloc failures.
2289 (gs_load): Use x_check_image_size.
2290
5f8f9cc2
PE
2291 * gtkutil.c: Omit integer casts.
2292 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2293 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2294
5adf60bc
PE
2295 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2296
c8907a93
PE
2297 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2298 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2299 would wrongly return t on a 64-bit host.
2300
e3c25c68
PE
2301 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2302 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2303 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2304 and therefore cause GCC to emit a bogus diagnostic in some cases.
2305
3f791afe
PE
2306 * image.c: Integer signedness and overflow and related fixes.
2307 This is not an exhaustive set of fixes, but it's time to
2308 record what I've got.
2309 (lookup_pixel_color, check_image_size): Remove redundant decls.
2310 (check_image_size): Don't assume that arbitrary EMACS_INT values
2311 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2312 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2313 (tiff_load, imagemagick_load_image):
2314 Check for overflow in size calculations.
2315 (x_create_x_image_and_pixmap): Remove unnecessary test for
2316 xmalloc returning NULL; that can't happen.
2317 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2318 (xpm_color_bucket): Use better integer hashing function.
2319 (xpm_cache_color): Don't possibly over-allocate memory.
2320 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2321 (gif_memory_source):
2322 Use ptrdiff_t, not int or size_t, to record sizes.
2323 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2324 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2325 either works, as we prefer signed integers.
2326 (tiff_read_from_memory, tiff_write_from_memory):
2327 Return tsize_t, not size_t, since that's what the TIFF API wants.
2328 (tiff_read_from_memory): Don't fail simply because the read would
2329 go past EOF; instead, return a short read.
2330 (tiff_load): Omit no-longer-needed casts.
2331 (Fimagemagick_types): Don't assume size fits into 'int'.
2332
3cc5a532
PE
2333 Improve hashing quality when configured --with-wide-int.
2334 * fns.c (hash_string): New function, taken from sxhash_string.
2335 Do not discard information about ASCII character case; this
2336 discarding is no longer needed.
2337 (sxhash-string): Use it. Change sig to match it. Caller changed.
2338 * lisp.h: Declare it.
2339 * lread.c (hash_string): Remove, since we now use fns.c's version.
2340 The fns.c version returns a wider integer if --with-wide-int is
2341 specified, so this should help the quality of the hashing a bit.
2342
b312a492
PE
2343 * emacs.c: Integer overflow minor fix.
2344 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2345 Define only if GNU_LINUX.
2346 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2347
dfd153ae
PE
2348 * dispnew.c: Integer signedness and overflow fixes.
2349 Remove unnecessary forward decls, that were a maintenance hassle.
2350 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2351 All uses changed.
2352 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2353 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2354 (prepare_desired_row, line_draw_cost):
2355 Use int, not unsigned, where either works.
2356 (save_current_matrix, restore_current_matrix):
2357 Use ptrdiff_t, not size_t, where either works.
2358 (init_display): Check for overflow more accurately, and without
2359 relying on undefined behavior.
2360
a81d11a3
PE
2361 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2362 Remove, replacing with the new symbols in lisp.h. All uses changed.
2363 * fileio.c (make_temp_name):
2364 * filelock.c (lock_file_1, lock_file):
2365 * xdisp.c (message_dolog):
2366 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2367 Use pMd etc. instead.
2368 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2369 replacing the pWIDE etc. symbols removed from editfns.c.
2370
3300e6fd
PE
2371 * keyboard.h (num_input_events): Now uintmax_t.
2372 This is (very slightly) less likely to mess up due to wraparound.
2373 All uses changed.
2374
fd05c7e9
PE
2375 * buffer.c: Integer signedness fixes.
2376 (alloc_buffer_text, enlarge_buffer_text):
2377 Use ptrdiff_t rather than size_t when either will do, as we prefer
2378 signed integers.
2379
903fe15d
PE
2380 * alloc.c: Integer signedness and overflow fixes.
2381 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2382 (__malloc_size_t): Default to size_t, not to int.
2383 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2384 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2385 Prefer ptrdiff_t to size_t when either would do, as we prefer
2386 signed integers.
2387 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2388 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2389 Now const. Initialize with values that are in range even if char
2390 is signed.
2391 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2392 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2393 These functions do the right thing with sizes > 2**32.
2394 (check_depth): Now ptrdiff_t, not int.
2395 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2396 Adjust to new way of storing sizes. Check for size overflow bugs
2397 in rest of code.
2398 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2399 slightly wrong anyway, as it missed one instance of
2400 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2401 (refill_memory_reserve): Omit needless cast to size_t.
2402 (mark_object_loop_halt): Mark as externally visible.
2403
ac82cc6a
PE
2404 * xselect.c: Integer signedness and overflow fixes.
2405 (Fx_register_dnd_atom, x_handle_dnd_message):
2406 Use ptrdiff_t, not size_t, since we prefer signed.
2407 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2408 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2409 x_dnd_atoms_size and x_dnd_atoms_length.
2410
c2d1e36d
PE
2411 * doprnt.c: Prefer signed to unsigned when either works.
2412 * eval.c (verror):
2413 * doprnt.c (doprnt):
2414 * lisp.h (doprnt):
2415 * xdisp.c (vmessage):
2416 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2417 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2418 prefer signed arithmetic to avoid comparison confusion.
2419 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2420 but is a bit tricky.
2421
0e926e56
PE
2422 Assume freestanding C89 headers, string.h, stdlib.h.
2423 * data.c, doprnt.c, floatfns.c, print.c:
2424 Include float.h unconditionally.
2425 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2426 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2427 * regex.c: Likewise for stddef.h, string.h.
2428 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2429 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2430 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2431 (STDC_HEADERS): Remove obsolete defines.
2432 * sysdep.c: Include limits.h unconditionally.
2433
9cfdb3ec
PE
2434 Assume support for memcmp, memcpy, memmove, memset.
2435 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2436 * regex.c (memcmp, memcpy):
2437 Remove; we assume C89 now.
2438
2439 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2440 (__malloc_safe_bcopy): Remove; no longer needed.
2441
cf950e6b 2442 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2443 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2444 well either way, and we prefer signed to unsigned.
2445
dbf38e02
LMI
24462011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2447
2448 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2449 closes the connection while we're reading (bug#9182).
2450
d6f0886c 24512011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2452
d6f0886c
JD
2453 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2454 are specified (Bug#9168).
24e0f6b1 2455
2eb1f9e6
PE
24562011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2457
2458 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2459 Found by GCC static checking and --with-wide-int on a 32-bit host.
2460
22381272 24612011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2462
2463 * xdisp.c (compute_display_string_pos): Fix logic of caching
2464 previous display string position. Initialize cached_prev_pos to
2465 -1. Fixes slow-down at the beginning of a buffer.
2466
f25e39b4
EZ
24672011-07-24 Eli Zaretskii <eliz@gnu.org>
2468
2469 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2470 for attrs[LFACE_FONTSET_INDEX].
2471
04c4b52e
PE
24722011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 * xml.c (parse_region): Remove unused local
2475 that was recently introduced.
2476
c1734fbd
EZ
24772011-07-23 Eli Zaretskii <eliz@gnu.org>
2478
be18c5a5
EZ
2479 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2480 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2481
c1734fbd
EZ
2482 * xdisp.c (move_it_in_display_line_to): Record the best matching
2483 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2484 exit if none of the characters scanned was an exact match.
2485 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2486 when exact match is impossible due to invisible text, and the
2487 lines are truncated.
2488
a258d627
JD
24892011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2490
2491 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2492 for OSX >= 10.7.
2493
b6d5a689
EZ
24942011-07-22 Eli Zaretskii <eliz@gnu.org>
2495
0f74f785
EZ
2496 Fix a significant slow-down of cursor motion with C-n, C-p,
2497 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2498 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2499 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2500 (next_element_from_buffer): Call compute_stop_pos_backwards to
2501 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2502 base_level_stop.
2503 (reseat): Don't look for prev_stop, as that could mean a very long
2504 run.
2505 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2506 <cached_disp_overlay_modiff>: Cache for last found display string
2507 position.
551918c1 2508 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2509 about the same buffer in the same area of character positions, and
2510 the buffer wasn't changed since the time the display string
2511 position was cached.
551918c1 2512
b2d0c91a
EZ
25132011-07-22 Eli Zaretskii <eliz@gnu.org>
2514
2515 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2516 is an integer, which is important for empty lines. (Bug#9149)
2517
043604ee
CY
25182011-07-22 Chong Yidong <cyd@stupidchicken.com>
2519
2520 * frame.c (Fmodify_frame_parameters): In tty case, update the
2521 default face if necessary (Bug#4238).
2522
da4adb04
CY
25232011-07-21 Chong Yidong <cyd@stupidchicken.com>
2524
2525 * editfns.c (Fstring_to_char): No need to explain what a character
2526 is in the docstring (Bug#6576).
2527
9abd0532
LMI
25282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2529
2530 * xml.c (parse_region): Make sure we always return a tree.
2531
36881d16
HK
25322011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2533
2534 * xml.c (parse_region): If a document contains only comments,
2535 return that, too.
2536
1e98674d
LMI
25372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2538
2539 * xml.c (make_dom): Return comments, too.
2540
590bd467
PE
25412011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2542
2543 Port to OpenBSD.
2544 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2545 and the surrounding thread.
2546 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2547 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2548 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2549 timer goes off.
2550 * s/openbsd.h (BROKEN_SIGIO): Define.
2551 * unexelf.c (unexec) [__OpenBSD__]:
2552 Don't update the .mdebug section of the Alpha COFF symbol table.
2553
f41628b2
LMI
25542011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2555
2556 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2557 (bug#8460).
2558
b59b67c5
PE
25592011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2560
15e3a074
PE
2561 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2562 This fixes some race conditions on the permissions of any newly
2563 created file.
2564
41bed37d
PE
2565 * alloc.c (valid_pointer_p): Use pipe, not open.
2566 This fixes some permissions issues when debugging.
2567
b59b67c5
PE
2568 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2569 If fchown fails to set both uid and gid, try to set just gid,
2570 as that is sometimes allowed. Adjust the file's mode to eliminate
2571 setuid or setgid bits that are inappropriate if fchown fails.
2572
925a6be7
SM
25732011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2574
2575 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2576 to compare Lisp_Objects.
2577 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2578 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2579 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2580
52968808
AS
25812011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2582
0a6a104b
AS
2583 * lread.c (read_integer): Unread even EOF character.
2584 (read1): Likewise. Properly record start position of symbol.
2585
52968808
AS
2586 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2587 symbol character follows.
2588
9e381cdd
PE
25892011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2590
2591 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2592 This works around a problem with the previous change to Fcopy_file.
2593 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2594 and without this change, GCC might complain about discarding
2595 fchown's return value.
2596
b5641435
JB
25972011-07-16 Juanma Barranquero <lekktu@gmail.com>
2598
2599 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2600
a8031457
PE
26012011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2604
dd889327
LMI
26052011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2606
750c33f7
LMI
2607 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2608 it's used from the C level.
2609
dd889327
LMI
2610 * process.c: Use the same condition for POLL_FOR_INPUT in both
2611 keyboard.c and process.c (bug#1858).
2612
87e86684
LM
26132011-07-09 Lawrence Mitchell <wence@gmx.li>
2614
2615 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2616 (Fgnutls_boot): Use it.
2617
64348f40
AS
26182011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2619
2620 * doc.c (Fsubstitute_command_keys): Revert last change.
2621
1d698799
LMI
26222011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2623
f863868c
LMI
2624 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2625 quotes the next character, and doesn't affect other longer
2626 sequences (bug#8935).
2627
1d698799
LMI
2628 * lread.c (syms_of_lread): Clarify that is isn't only
2629 `eval-buffer' and `eval-defun' that's affected by
2630 `lexical-binding' (bug#8460).
2631
aa4b6df6
EZ
26322011-07-15 Eli Zaretskii <eliz@gnu.org>
2633
2634 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2635 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2636
5d856da6
PE
26372011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2638
ad6042bb
PE
2639 Fix minor problems found by static checking.
2640 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2641 (elsz): Now a signed constant, not a size_t var. We prefer signed
2642 types to unsigned, to avoid integer comparison confusion. Without
2643 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2644 "cannot optimize loop, the loop counter may overflow", a symptom
2645 of the confusion.
f00bbb22 2646 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2647 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2648
6468f31c
LMI
26492011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2650
49080b10
LMI
2651 * search.c (Fre_search_backward): Mention `case-fold-search' in
2652 all the re_search_* functions (bug#8138).
2653
6468f31c
LMI
2654 * keyboard.c (Fopen_dribble_file): Document when the file is
2655 closed (bug#8056).
2656
c965adc5
EZ
26572011-07-14 Eli Zaretskii <eliz@gnu.org>
2658
df9733bf
EZ
2659 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2660 bidi_cache_idx.
2661
0bb23927
EZ
2662 Support bidi reordering of display and overlay strings.
2663 * xdisp.c (compute_display_string_pos)
2664 (compute_display_string_end): Accept additional argument STRING.
2665 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2666 (reseat_to_string): Initialize bidi_it->string.s and
2667 bidi_it->string.schars.
2668 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2669 NULL (avoids a crash in bidi_paragraph_init).
2670 Initialize itb.string.lstring.
0bb23927
EZ
2671 (init_iterator): Call bidi_init_it only of a valid
2672 buffer position was specified. Initialize paragraph_embedding to
2673 L2R.
2674 (reseat_to_string): Initialize the bidi iterator.
2675 (display_string): If we need to ignore text properties of
2676 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2677 original value of -1 will not work with bidi.)
2678 (compute_display_string_pos): First arg is now struct
2679 `text_pos *'; all callers changed. Support display properties on
2680 Lisp strings.
2681 (compute_display_string_end): Support display properties on Lisp
2682 strings.
2683 (init_iterator, reseat_1, reseat_to_string): Initialize the
2684 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2685 when iterating on a string not from display properties).
640c8776
SM
2686 (compute_display_string_pos, compute_display_string_end):
2687 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2688 arrow keys.
2689 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2690 base_level_stop; instead, set base_level_stop to BEGV.
2691 Fixes crashes in vertical-motion.
0bb23927
EZ
2692 (next_element_from_buffer): Improve commentary for when
2693 the iterator is before prev_stop.
2694 (init_iterator): Initialize bidi_p from the default value of
2695 bidi-display-reordering, not from buffer-local value. Use the
2696 buffer-local value only if initializing for buffer iteration.
2697 (handle_invisible_prop): Support invisible properties on strings
2698 that are being bidi-reordered.
2699 (set_iterator_to_next): Support bidi reordering of C strings and
2700 Lisp strings.
2701 (next_element_from_string): Support bidi reordering of Lisp
2702 strings.
2703 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2704 (display_string): Support display of R2L glyph rows.
2705 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2706 (init_iterator): Don't initialize it->bidi_p for strings
2707 here.
2708 (reseat_to_string): Initialize it->bidi_p for strings here.
2709 (next_element_from_string, next_element_from_c_string)
2710 (next_element_from_buffer): Add xassert's for correspondence
2711 between IT's object being iterated and it->bidi_it.string
2712 structure.
2713 (face_before_or_after_it_pos): Support bidi iteration.
2714 (next_element_from_c_string): Handle the case of the first string
2715 character that is not the first one in the visual order.
2716 (get_visually_first_element): New function, refactored from common
2717 parts of next_element_from_buffer, next_element_from_string, and
2718 next_element_from_c_string.
2719 (tool_bar_lines_needed, redisplay_tool_bar)
2720 (display_menu_bar): Force left-to-right direction. Add a FIXME
2721 comment for making that be controlled by a user option.
2722 (push_it, pop_it): Save and restore the state of the
2723 bidi iterator. Save and restore the bidi_p flag.
2724 (pop_it): Iterate out of display property for string iteration as
2725 well.
2726 (iterate_out_of_display_property): Support iteration over strings.
2727 (handle_single_display_spec): Set up it->bidi_it for iteration
2728 over a display string, and call bidi_init_it.
2729 (handle_single_display_spec, next_overlay_string)
2730 (get_overlay_strings_1, push_display_prop): Set up the bidi
2731 iterator for displaying display or overlay strings.
2732 (forward_to_next_line_start): Don't use the shortcut if
2733 bidi-iterating.
2734 (back_to_previous_visible_line_start): If handle_display_prop
2735 pushed the iterator stack, restore the internal state of the bidi
2736 iterator by calling bidi_pop_it same number of times.
2737 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2738 and we are bidi-iterating, don't decrement the iterator position;
2739 instead, set the first_elt flag in the bidi iterator, to produce
2740 the same effect.
2741 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2742 (push_display_prop): xassert that we are iterating a buffer.
2743 (push_it, pop_it): Save and restore paragraph_embedding member.
2744 (handle_single_display_spec, next_overlay_string)
2745 (get_overlay_strings_1, reseat_1, reseat_to_string)
2746 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2747 correctly. Don't assume unibyte strings are not bidi-reordered.
2748 (compute_display_string_pos)
2749 (compute_display_string_end): Fix handling the case of C string.
2750 (push_it, pop_it): Save and restore from_disp_prop_p.
2751 (handle_single_display_spec, push_display_prop): Set the
2752 from_disp_prop_p flag.
2753 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2754 (pop_it): Call iterate_out_of_display_property only if we are
2755 popping after iteration over a string that came from a display
2756 property. Fix a typo in popping stretch info. Add an assertion
2757 for verifying that the iterator position is in sync with the bidi
2758 iterator.
2759 (handle_single_display_spec, get_overlay_strings_1)
2760 (push_display_prop): Fix initialization of paragraph direction for
2761 string when that of the parent object is not yet determined.
2762 (reseat_1): Call bidi_init_it to resync the bidi
2763 iterator with IT's position. (Bug#7616)
2764 (find_row_edges): If ROW->start.pos gives position
2765 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2766 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2767 Reset the from_disp_prop_p flag.
2768 (SAVE_IT, RESTORE_IT): New macros.
2769 (pos_visible_p, face_before_or_after_it_pos)
2770 (back_to_previous_visible_line_start)
2771 (move_it_in_display_line_to, move_it_in_display_line)
2772 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2773 (try_scrolling, redisplay_window, display_line): Use them when
2774 saving a temporary copy of the iterator and restoring it back.
2775 (back_to_previous_visible_line_start, reseat_1)
2776 (init_iterator): Empty the bidi cache "stack".
2777 (move_it_in_display_line_to): If iterator ended up at
2778 EOL, but we never saw any buffer positions smaller than
2779 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2780 motion in bidi-reordered lines.
2781 (move_it_in_display_line_to): Record prev_method and prev_pos
2782 immediately before the call to set_iterator_to_next. Fixes cursor
2783 motion in bidi-reordered lines with stretch glyphs and strings
2784 displayed in margins. (Bug#8133) (Bug#8867)
2785 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2786 TO_CHARPOS.
640c8776
SM
2787 (pos_visible_p): Support positions in bidi-reordered lines.
2788 Save and restore bidi cache.
0bb23927
EZ
2789
2790 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2791 (bidi_paragraph_info): Delete unused struct.
2792 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2793 (bidi_cache_start): New variable.
2794 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2795 to zero.
2796 (bidi_cache_fetch_state, bidi_cache_search)
2797 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2798 (bidi_cache_find, bidi_peek_at_next_level)
2799 (bidi_level_of_next_char, bidi_find_other_level_edge)
2800 (bidi_move_to_visually_next): Compare cache index with
2801 bidi_cache_start rather than with zero.
2802 (bidi_fetch_char): Accept new argument STRING; all callers
2803 changed. Support iteration over a string. Support strings with
2804 display properties. Support unibyte strings. Fix the type of
2805 `len' according to what STRING_CHAR_AND_LENGTH expects.
2806 (bidi_paragraph_init, bidi_resolve_explicit_1)
2807 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2808 (bidi_level_of_next_char, bidi_move_to_visually_next):
2809 Support iteration over a string.
0bb23927
EZ
2810 (bidi_set_sor_type, bidi_resolve_explicit_1)
2811 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2812 can now be zero (for strings); special values 0 and -1 were
2813 changed to -1 and -2, respectively.
2814 (bidi_char_at_pos): New function.
2815 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2816 Call it instead of FETCH_MULTIBYTE_CHAR.
2817 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2818 initialized to valid values.
2819 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2820 values.
2821 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2822 the test for valid cached positions. Fix the logic for looking up
2823 the sentinel state in the cache. GCPRO the Lisp string we are
2824 iterating.
2825 (bidi_push_it, bidi_pop_it): New functions.
2826 (bidi_initialize): Initialize the bidi cache start stack pointer.
2827 (bidi_cache_ensure_space): New function, refactored from part of
2828 bidi_cache_iterator_state. Don't assume the required size is just
2829 one BIDI_CACHE_CHUNK away.
2830 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2831 (bidi_count_bytes, bidi_char_at_pos): New functions.
2832 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2833 always valid if bidi_cache_idx is valid.
2834 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2835 is valid if it's going to be used.
2836 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2837 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2838 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2839 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2840 (bidi_find_other_level_edge, bidi_cache_start_stack):
2841 All variables related to cache indices are now EMACS_INT.
c965adc5 2842
0bb23927
EZ
2843 * dispextern.h (struct bidi_string_data): New structure.
2844 (struct bidi_it): New member `string'. Make flag members be 1-bit
2845 fields, and put them last in the struct.
640c8776
SM
2846 (compute_display_string_pos, compute_display_string_end):
2847 Update prototypes.
0bb23927
EZ
2848 (bidi_push_it, bidi_pop_it): Add prototypes.
2849 (struct iterator_stack_entry): New members bidi_p,
2850 paragraph_embedding, and from_disp_prop_p.
2851 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2852 (bidi_shelve_cache, bidi_unshelve_cache):
2853 Declare prototypes.
0bb23927
EZ
2854
2855 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2856 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2857 and vector-like objects.
2858
2859 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2860 cache around display iteration.
2861
2862 * window.c (Fwindow_end, window_scroll_pixel_based)
2863 (displayed_window_lines, Frecenter): Save and restore the bidi
2864 cache around display iteration.
2865
3bbd2265
LMI
28662011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2867
2868 * editfns.c (Fdelete_region): Clarify the use of the named
2869 parameters (bug#6788).
2870
adc47434
MR
28712011-07-14 Martin Rudalics <rudalics@gmx.at>
2872
2873 * indent.c (Fvertical_motion): Set and restore w->pointm when
2874 saving and restoring the window's buffer (Bug#9006).
2875
837c31f8
LMI
28762011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2877
2878 * editfns.c (Fstring_to_char): Clarify just what is returned
2879 (bug#6576). Text by Eli Zaretskii.
2880
ac389d0c
JB
28812011-07-13 Juanma Barranquero <lekktu@gmail.com>
2882
2883 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2884
0be0ce47
EZ
28852011-07-13 Eli Zaretskii <eliz@gnu.org>
2886
2887 * buffer.c (mmap_find): Fix a typo.
2888
cd18e7e3
JB
28892011-07-13 Johan Bockgård <bojohan@gnu.org>
2890
2891 Fix execution of x selection hooks.
2892 * xselect.c (Qx_lost_selection_functions)
2893 (Qx_sent_selection_functions): New vars.
2894 (syms_of_xselect): DEFSYM them.
2895 (x_handle_selection_request): Pass Qx_sent_selection_functions
2896 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2897 (x_handle_selection_clear,x_clear_frame_selections):
2898 Pass Qx_lost_selection_functions rather than
2899 Vx_lost_selection_functions to Frun_hook_with_args.
2900
47ea7f44
PE
29012011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2902
ac389d0c 2903 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2904 The old code sometimes used this field without initializing it.
2905
47ea7f44
PE
2906 * alloc.c (gc_sweep): Don't read past end of array.
2907 In theory, the old code could also have corrupted Emacs internals,
2908 though it'd be very unlikely.
2909
bc985c87
AS
29102011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2911
2912 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2913 argument. (Bug#4026)
bc985c87 2914
0cf34688
LMI
29152011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2916
b3dadd76
LMI
2917 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2918 key" (bug#4257).
2919
0cf34688
LMI
2920 * window.c (Fset_window_start): Doc fix (bug#4199).
2921 (Fset_window_hscroll): Ditto.
2922
270768cd
PE
29232011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2924
077e3dda 2925 Fix minor new problems caught by GCC 4.6.1.
270768cd 2926 * term.c (init_tty): Remove unused local.
490011a6 2927 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2928 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2929 not used otherwise.
270768cd 2930
b1f58454
CY
29312011-07-12 Chong Yidong <cyd@stupidchicken.com>
2932
2933 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2934
22b9578d
LMI
29352011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2936
6e70ab07
LMI
2937 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2938 are the mini-buffer and the echo area (bug#3320).
2939
22b9578d
LMI
2940 * term.c (init_tty): Remove support for supdup, c10 and perq
2941 terminals, which are no longer supported (bug#1482).
2942
8974cc9f
JB
29432011-07-10 Johan Bockgård <bojohan@gnu.org>
2944
2945 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2946
a560d974
JD
29472011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2948
2949 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2950 for non-popups (Bug#3642).
2951
1dae0f0a
AS
29522011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2953
268c2c36 2954 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2955 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2956 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2957 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2958 * data.c (fmod): Likewise.
2959 * dispnew.c (swap_glyphs_in_rows): Likewise.
2960 * emacs.c (memory_warning_signal): Likewise.
2961 * floatfns.c (float_error): Likewise.
2962 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2963 (otf_open, font_otf_capability, generate_otf_features)
2964 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2965 Likewise.
2966 * image.c (pbm_read_file): Likewise.
2967 * indent.c (string_display_width): Likewise.
2968 * intervals.c (check_for_interval, search_for_interval)
2969 (inc_interval_count, count_intervals, root_interval)
2970 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2971 * lread.c (defalias): Likewise.
268c2c36 2972 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2973 * regex.c (set_image_of_range_1, set_image_of_range)
2974 (regex_grow_registers): Likewise.
2975 * sysdep.c (strerror): Likewise.
2976 * termcap.c (valid_filename_p, tprint, main): Likewise.
2977 * tparam.c (main): Likewise.
2978 * unexhp9k800.c (run_time_remap, save_data_space)
2979 (update_file_ptrs, read_header, write_header, calculate_checksum)
2980 (copy_file, copy_rest, display_header): Likewise.
2981 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2982 Likewise.
2983 * xdisp.c (check_it): Likewise.
2984 * xfaces.c (register_color, unregister_color, unregister_colors):
2985 Likewise.
2986 * xfns.c (print_fontset_result): Likewise.
2987 * xrdb.c (member, fatal, main): Likewise.
2988
99033785
PE
29892011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 Fix minor problems found by static checking (Bug#9031).
2992 * chartab.c (char_table_set_range, map_sub_char_table):
2993 Remove unused locals.
2994 (uniprop_table): Now static.
2995 * composite.c (_work_char): Remove unused static var.
2996
9cb2ac56
JB
29972011-07-09 Juanma Barranquero <lekktu@gmail.com>
2998
2999 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3000
f25661f0
JD
30012011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3002
3003 * gtkutil.c (qttip_cb): Remove code without function.
3004
8278c4fe
EZ
30052011-07-09 Eli Zaretskii <eliz@gnu.org>
3006
3007 * w32.c (pthread_sigmask): New stub.
3008
1692ae2d 30092011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3010
8a6ebd58 3011 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3012 sigprocmask is portable only for single-threaded applications, and
3013 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3014 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3015 (LIBES): Use it.
3016 * callproc.c (Fcall_process):
3017 * process.c (create_process):
3018 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3019 Use pthread_sigmask, not sigprocmask.
123403e4 3020
1b854618
JD
30212011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3022
3023 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3024 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3025 wrong (Bug#8591).
3026
3fe4b549
JD
30272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3028
0ce7e563
JD
3029 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3030 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3031 (xg_hide_tooltip): Fix comment.
3032
3fe4b549
JD
3033 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3034 in registerServicesMenuSendTypes.
3035 (validRequestorForSendType): Don't check ns_return_types.
3036
3037 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3038 ns_return_type.
3039
5df75e47
JR
30402011-07-08 Jason Rumney <jasonr@gnu.org>
3041
22610910
JR
3042 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3043 SH_SHOW for hidden windows (Bug#5482).
3044
5df75e47
JR
3045 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3046 frame struct members of non-existent frames (Bug#6284).
3047
699c10bd
JD
30482011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3049
4393663b
JD
3050 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3051 variable firstTime not needed on OSX >= 10.6.
3052 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3053 >= 10.5. Use setKnobProportion, setDoubleValue.
3054
3055 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3056 (MAC_OS_X_VERSION_10_5): Define if not defined.
3057 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3058 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3059 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3060
3061 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3062 cString and lossyCString on OSX >= 10.4
3063
58179cce 3064 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3065 sizeToFit on OSX >= 10.2.
3066
3067 * nsimage.m (allocInitFromFile): Don't use deprecated method
3068 bestRepresentationForDevice on OSX >= 10.6.
3069
3070 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3071 to avoid warning.
3072
3073 * emacs.c: Declare unexec_init_emacs_zone.
3074
a63e0781
JD
3075 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3076
699c10bd
JD
3077 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3078
3079 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3080 on svcsMenu (Bug#8842).
3081
3082 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3083 ns_return_types.
3084 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3085
3086 * nsterm.m (QUTF8_STRING): Declare.
3087 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3088 (validRequestorForSendType): Return type is (id).
3089 Change indexOfObjectIdenticalTo to indexOfObject.
3090 Check if we have local selection before returning self (Bug#8842).
3091 (writeSelectionToPasteboard): Put local selection into paste board
3092 if we have a local selection (Bug#8842).
3093 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3094
3095 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3096 (ns_get_local_selection): Declare.
3097
54e10184
LMI
30982011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3099
9888ff71
LMI
3100 * keymap.c (describe_map_tree): Don't insert a double newline at
3101 the end of the buffer (bug#1169) and return whether we inserted
3102 something.
3103
54e10184
LMI
3104 * callint.c (Fcall_interactively): Change "reading args" to
3105 "providing args" to try to clarify what it does (bug#1010).
3106
15fa4783
KH
31072011-07-07 Kenichi Handa <handa@m17n.org>
3108
3109 * composite.c (composition_compute_stop_pos): Ignore a static
3110 composition starting before CHARPOS (Bug#8915).
3111
3112 * xdisp.c (handle_composition_prop): Likewise.
3113
a8815b00
EZ
31142011-07-07 Eli Zaretskii <eliz@gnu.org>
3115
3116 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3117 (Bug#9015)
3118
ef7b981d 31192011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3120
3121 * character.h (unicode_category_t): New enum type.
3122
3123 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3124 (Qchar_code_property_table): New variable.
3125 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3126 (UNIPROP_COMPRESSED_FORM_P): New macros.
3127 (char_table_ascii): Uncompress the compressed values.
3128 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3129 Uncompress the compressed values.
ac389d0c 3130 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3131 (char_table_ref_and_range): Uncompress the compressed values.
3132 (sub_char_table_set): New arg is_uniprop. Callers changed.
3133 Uncompress the compressed values.
3134 (sub_char_table_set_range): Args changed. Callers changed.
3135 (char_table_set_range): Adjuted for the above change.
3136 (map_sub_char_table): Delete args default_val and parent. Add arg
3137 top. Give decoded values to a Lisp function.
640c8776 3138 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3139 values to a Lisp function. Gcpro more variables.
3140 (uniprop_table_uncompress)
3141 (uniprop_decode_value_run_length): New functions.
3142 (uniprop_decoder, uniprop_decoder_count): New variables.
3143 (uniprop_get_decoder, uniprop_encode_value_character)
3144 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3145 New functions.
3146 (uniprop_encoder, uniprop_encoder_count): New variables.
3147 (uniprop_get_encoder, uniprop_table)
3148 (Funicode_property_table_internal, Fget_unicode_property_internal)
3149 (Fput_unicode_property_internal): New functions.
3150 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3151 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3152 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3153 char-code-property-alist.
3154
640c8776 3155 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3156 Vunicode_category_table.
3157
640c8776 3158 * font.c (font_range): Adjust for the change of
c805dec0
KH
3159 Vunicode_category_table.
3160
76b397fb
DN
31612011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3162
3163 * m/iris4d.h: Remove file, move contents ...
3164 * s/irix6-5.h: ... here.
3165
22b4128e
PE
31662011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3167
3168 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3169 * alloc.c (mark_buffer):
3170 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3171 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3172 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3173 This isn't true in general, and it's particularly not true
3174 if Emacs is configured with --with-wide-int.
3175 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3176 New macros, used in the buffer.c change.
3177
869795d6
JD
31782011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3179
3180 * xsettings.c: Use both GConf and GSettings if both are available.
3181 (store_config_changed_event): Add comment.
3182 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3183 (store_tool_bar_style_changed): New functions.
5e617bc2 3184 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3185 (struct xsettings): Move font inside HAVE_XFT.
3186 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3187 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3188 Move inside HAVE_XFT.
640c8776 3189 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3190 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3191 also.
3192 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3193 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3194 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3195 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3196 (parse_settings): Move check for font inside HAVE_XFT.
3197 (read_settings, apply_xft_settings): Add comment.
3198 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3199 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3200 call store_font_name_changed.
3201 (xft_settings_event): Add comment.
3202 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3203 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3204 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3205 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3206 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3207 (xsettings_get_system_font, xsettings_get_system_normal_font):
3208 Add comment.
869795d6 3209
d8ed26bd
PE
32102011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 Random fixes. E.g., (random) never returned negative values.
3213 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3214 subseconds part to the entropy, as that's a bit more random.
3215 Prefer signed to unsigned, since the signedness doesn't matter and
3216 in general we prefer signed. When given a limit, use a
3217 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3218 latter isn't right if USE_2_TAGS_FOR_INTS.
3219 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3220 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3221
cabf1cac
SM
32222011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3223
3224 * textprop.c (text_property_stickiness):
3225 Obey Vtext_property_default_nonsticky.
3226 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3227 * w32fns.c (syms_of_w32fns):
3228 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3229
6e9b2be9
PE
32302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3233 This is more efficient than Ffile_directory_p and avoids a minor race.
3234
90186c68
LMI
32352011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3236
7c301272
LMI
3237 * buffer.c (Foverlay_put): Say what the return value is
3238 (bug#7835).
3239
c4f2d8d4
LMI
3240 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3241 is a directory before asking whether to use the file name
3242 (bug#7564).
ad637907
LMI
3243 (barf_or_query_if_file_exists): Make the "File is a directory"
3244 error be more correct.
c4f2d8d4 3245
90186c68
LMI
3246 * fns.c (Frequire): Remove the mention of the .gz files, since
3247 that's installation-specific, but keep the mention of
3248 `get-load-suffixes'.
3249
da64016e
PE
32502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3251
3252 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3253 Report string overflow if the output is too long.
3254
7d47b580
JB
32552011-07-04 Juanma Barranquero <lekktu@gmail.com>
3256
a555cb87
JB
3257 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3258 (syms_of_gnutls): Remove duplicate DEFSYM for
3259 Qgnutls_bootprop_verify_hostname_error, an error for
3260 Qgnutls_bootprop_verify_error (which is no longer used).
3261
7d47b580
JB
3262 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3263 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3264 Also (re)move comments that are misplaced or no longer relevant.
3265
1e49bfab
LMI
32662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3267
3268 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3269
1485f4c0
CY
32702011-07-03 Chong Yidong <cyd@stupidchicken.com>
3271
3272 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3273 and background color parameters if they have been changed.
3274
a9ab721e
LMI
32752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3276
3277 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3278
cf7cff57
PE
32792011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3280
2e13213d
PE
3281 * xsettings.c (SYSTEM_FONT): Define only when used.
3282 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3283
cf7cff57
PE
3284 * keymap.c (access_keymap_1): Now static.
3285
7a8e04f7
CY
32862011-07-02 Chong Yidong <cyd@stupidchicken.com>
3287
3288 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3289 leave any prefix arg for the up event (Bug#1586).
3290
61352f62
LMI
32912011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3292
69bb1ef7
LMI
3293 * lread.c (syms_of_lread): Mention single symbols defined by
3294 `defvar' or `defconst' (bug#7154).
3295
61352f62 3296 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3297 (Frequire): Mention get-load-suffixes.
61352f62 3298
28545e04
MR
32992011-07-02 Martin Rudalics <rudalics@gmx.at>
3300
3301 * window.h (window): Remove clone_number slot.
3302 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3303 Remove.
3304 (make_parent_window, make_window, saved_window)
3305 (Fset_window_configuration, save_window_save): Don't deal with
3306 clone numbers.
3307 * buffer.c (Qclone_number): Remove declaration.
3308 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3309
3349e122
SM
33102011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3311
3312 Add multiple inheritance to keymaps.
3313 * keymap.c (Fmake_composed_keymap): New function.
3314 (Fset_keymap_parent): Simplify.
3315 (fix_submap_inheritance): Remove.
3316 (access_keymap_1): New function extracted from access_keymap to handle
3317 embedded parents and handle lists of maps.
3318 (access_keymap): Use it.
3319 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3320 (Fcopy_keymap): Handle embedded parents.
3321 (Fcommand_remapping, define_as_prefix): Simplify.
3322 (Fkey_binding): Simplify.
3323 (syms_of_keymap): Move minibuffer-local-completion-map,
3324 minibuffer-local-filename-completion-map,
3325 minibuffer-local-must-match-map, and
3326 minibuffer-local-filename-must-match-map to Elisp.
3327 (syms_of_keymap): Defsubr make-composed-keymap.
3328 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3329 (parse_menu_item): Trivial simplification.
3330
3279eb87
GM
33312011-07-01 Glenn Morris <rgm@gnu.org>
3332
3333 * Makefile.in (SETTINGS_LIBS): Fix typo.
3334
4550efdf
KI
33352011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3336
3337 * coding.c (Fencode_coding_string): Record the last coding system
3338 used, as the function doc string says (bug#8738).
3339
0949d2b6
JD
33402011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3341
3342 * xsettings.c (store_monospaced_changed): Take new font as arg and
3343 check for change against current_mono_font.
3344 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3345 (emacs_settings_constructor, emacs_settings_get_property)
3346 (emacs_settings_set_property, emacs_settings_class_init)
3347 (emacs_settings_init, gsettings_obj): Remove.
3348 (something_changedCB): New function for HAVE_GSETTINGS.
3349 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3350 with value as argument.
3351 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3352 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3353 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3354 "changed".
3355
3356 * xgselect.c: Add defined (HAVE_GSETTINGS).
3357 (xgselect_initialize): Ditto.
3358
3359 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3360 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3361 xg_select.
3362
bbc6b304
PE
33632011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3364
3365 * eval.c (struct backtrace): Simplify and port the data structure.
3366 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3367 signed bit field, as this assumption is not portable and it makes
3368 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3369 "char debug_on_exit : 1" as this is not portable either; instead,
3370 use the portable "unsigned int debug_on_exit : 1". Remove unused
3371 member evalargs. Remove obsolete comments about cc bombing out.
3372
9851bfc5
JD
33732011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3374
51bb811f 3375 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3376 Let HAVE_GSETTINGS override HAVE_GCONF.
3377 (store_monospaced_changed): New function.
3378 (EMACS_SETTINGS): A new type derived from GObject to handle
3379 GSettings notifications.
3380 (emacs_settings_constructor, emacs_settings_get_property)
3381 (emacs_settings_set_property, emacs_settings_class_init):
3382 New functions.
3383 (gsettings_client, gsettings_obj): New variables.
3384 (GSETTINGS_SCHEMA): New define.
3385 (something_changedCB): Call store_monospaced_changed.
3386 (init_gsettings): New function.
3387 (xsettings_initialize): Call init_gsettings.
3388 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3389 to NULL.
3390
640c8776 3391 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3392 GCONF_CFLAGS/LIBS.
3393
5386012d
MR
33942011-06-29 Martin Rudalics <rudalics@gmx.at>
3395
3396 * window.c (resize_root_window, grow_mini_window)
3397 (shrink_mini_window): Rename Qresize_root_window to
3398 Qwindow_resize_root_window and Qresize_root_window_vertically to
3399 Qwindow_resize_root_window_vertically.
3400
f13e0b08
PE
34012011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3404
94515237
JB
34052011-06-27 Juanma Barranquero <lekktu@gmail.com>
3406
3407 * makefile.w32-in: Redesign dependencies so they reflect more
3408 clearly which files are directly included by each source file,
3409 and not through other includes.
3410
e43b6e43
MR
34112011-06-27 Martin Rudalics <rudalics@gmx.at>
3412
3413 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3414 (sort_overlays, overlay_strings): When an overlay's clone number
3415 matches the window's clone number process the overlay even if
3416 the overlay's window property doesn't match the current window.
3417
d68443dc
MR
3418 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3419 (Fwindow_hchild): Rename to Fwindow_left_child.
3420 (Fwindow_next): Rename to Fwindow_next_sibling.
3421 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3422 (resize_window_check): Rename to window_resize_check.
3423 (resize_window_apply): Rename to window_resize_apply.
3424 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3425 (Fdelete_other_windows_internal, resize_frame_windows)
3426 (Fsplit_window_internal, Fdelete_window_internal)
3427 (grow_mini_window, shrink_mini_window)
3428 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3429
c7e73be5
JD
34302011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3431
3432 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3433 (emacs_fixed_set_min_size): Remove.
3434 (emacs_fixed_new): Take frame as argument.
3435
3436 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3437 (_EmacsFixedPrivate): Remove minwidth/height.
3438 Add struct frame *f.
3439 (emacs_fixed_init): Initialize priv->f.
3440 (get_parent_class, emacs_fixed_set_min_size): Remove.
3441 (emacs_fixed_new): Set priv->f to argument.
3442 (emacs_fixed_get_preferred_width)
3443 (emacs_fixed_get_preferred_height): Use min_width/height from
3444 frames size_hint to set minimum and natural (Bug#8919).
3445 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3446 and use min_width/height from frames size_hint to set
3447 min_width/height (Bug#8919).
3448
3449 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3450 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3451 Fix indentation.
c7e73be5 3452
cf99dcf8
EZ
34532011-06-26 Eli Zaretskii <eliz@gnu.org>
3454
3455 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3456 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3457 called at ZV.
3458
029529ac
CY
34592011-06-26 Chong Yidong <cyd@stupidchicken.com>
3460
3461 * process.c (wait_reading_process_output): Bypass select if
3462 waiting for a cell while ignoring keyboard input, and input is
3463 pending. Suggested by Jan Djärv (Bug#8869).
3464
7a7ef429
PE
34652011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3466
3467 Use gnulib's dup2 module instead of rolling our own.
3468 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3469
11fdef7d 34702011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3471
3472 * dispnew.c (scrolling_window): Before scrolling, turn off a
3473 mouse-highlight in the window being scrolled.
3474
cd3520a4
JB
34752011-06-24 Juanma Barranquero <lekktu@gmail.com>
3476
3477 Move DEFSYM to lisp.h and use everywhere.
3478
3479 * character.h (DEFSYM): Move declaration...
3480 * lisp.h (DEFSYM): ...here.
3481
3482 * gnutls.c:
3483 * minibuf.c:
3484 * w32menu.c:
3485 * w32proc.c:
3486 * w32select.c: Don't include character.h.
3487
3488 * alloc.c (syms_of_alloc):
3489 * buffer.c (syms_of_buffer):
3490 * bytecode.c (syms_of_bytecode):
3491 * callint.c (syms_of_callint):
3492 * casefiddle.c (syms_of_casefiddle):
3493 * casetab.c (init_casetab_once):
3494 * category.c (init_category_once, syms_of_category):
3495 * ccl.c (syms_of_ccl):
3496 * cmds.c (syms_of_cmds):
3497 * composite.c (syms_of_composite):
3498 * dbusbind.c (syms_of_dbusbind):
3499 * dired.c (syms_of_dired):
3500 * dispnew.c (syms_of_display):
3501 * doc.c (syms_of_doc):
3502 * editfns.c (syms_of_editfns):
3503 * emacs.c (syms_of_emacs):
3504 * eval.c (syms_of_eval):
3505 * fileio.c (syms_of_fileio):
3506 * fns.c (syms_of_fns):
3507 * frame.c (syms_of_frame):
3508 * fringe.c (syms_of_fringe):
3509 * insdel.c (syms_of_insdel):
3510 * keymap.c (syms_of_keymap):
3511 * lread.c (init_obarray, syms_of_lread):
3512 * macros.c (syms_of_macros):
3513 * msdos.c (syms_of_msdos):
3514 * print.c (syms_of_print):
3515 * process.c (syms_of_process):
3516 * search.c (syms_of_search):
3517 * sound.c (syms_of_sound):
3518 * syntax.c (init_syntax_once, syms_of_syntax):
3519 * terminal.c (syms_of_terminal):
3520 * textprop.c (syms_of_textprop):
3521 * undo.c (syms_of_undo):
3522 * w32.c (globals_of_w32):
3523 * window.c (syms_of_window):
3524 * xdisp.c (syms_of_xdisp):
3525 * xfaces.c (syms_of_xfaces):
3526 * xfns.c (syms_of_xfns):
3527 * xmenu.c (syms_of_xmenu):
3528 * xsettings.c (syms_of_xsettings):
3529 * xterm.c (syms_of_xterm): Use DEFSYM.
3530
4228cf16
TZ
35312011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3532
cd3520a4 3533 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3534
7fcccf1e
PE
35352011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3536
7efb4e0e
PE
3537 Integer and buffer overflow fixes (Bug#8873).
3538
ff5844ad
PE
3539 * print.c (printchar, strout): Check for string overflow.
3540 (PRINTPREPARE, printchar, strout):
3541 Don't set size unless allocation succeeds.
3542
90532f02
PE
3543 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3544 for sizes. Check for string overflow more accurately.
3545 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3546
6d84508d
PE
3547 * macros.c: Integer and buffer overflow fixes.
3548 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3549 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3550 Use ptrdiff_t, not int, for sizes.
3551 Don't increment bufsize until after realloc succeeds.
3552 Check for size-calculation overflow.
3553 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3554
437b2cb4
PE
3555 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3556
8b9ac8b4
PE
3557 * lread.c: Integer overflow fixes.
3558 (read_integer): Radix is now EMACS_INT, not int,
3559 to improve quality of diagnostics for out-of-range radices.
3560 Calculate buffer size correctly for out-of-range radices.
3561 (read1): Check for integer overflow in radices, and in
3562 read-circle numbers.
82cb60d3
PE
3563 (read_escape): Avoid int overflow.
3564 (Fload, openp, read_buffer_size, read1)
3565 (substitute_object_recurse, read_vector, read_list, map_obarray):
3566 Use ptrdiff_t, not int, for sizes.
3567 (read1): Use EMACS_INT, not int, for sizes.
20270765 3568 Check for size overflow.
8b9ac8b4 3569
7fcccf1e
PE
3570 * image.c (cache_image): Check for size arithmetic overflow.
3571
bfbbd7e7
PE
3572 * lread.c: Integer overflow issues.
3573 (saved_doc_string_size, saved_doc_string_length)
3574 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3575 Now ptrdiff_t, not int.
3576 (read1): Don't assume doc string length fits in int. Check for
3577 out-of-range doc string lengths.
3578 (read_list): Don't assume file position fits in int.
39019e54 3579 (read_escape): Check for hex character overflow.
bfbbd7e7 3580
4e323265
LL
35812011-06-22 Leo Liu <sdl.web@gmail.com>
3582
3583 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3584 Move to minibuffer.el.
3585
85fece3e
PE
35862011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3587
20b84ce9 3588 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3589 The following patches are for when GLYPH_DEBUG && !XASSERT.
3590 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3591 * dispnew.c (flush_stdout):
3592 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3593 Mark as externally visible.
3594 * dispnew.c (check_window_matrix_pointers): Now static.
3595 * dispnew.c (window_to_frame_vpos):
3596 * xfns.c (unwind_create_frame):
3597 * xterm.c (x_check_font): Remove unused local.
3598 * scroll.c (CHECK_BOUNDS):
3599 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3600 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3601 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3602 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3603 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3604 Now static.
3605 (debug_method_add): Use va_list and vsprintf rather than relying
3606 on undefined behavior with wrong number of arguments.
3607 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3608 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3609 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3610 since we're not interested in debugging glyphs with old libraries.
3611 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3612 GCC 4.6.0's static checking.
3613
0766b489
PE
36142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3615
31fd4b32
PE
3616 Integer overflow and signedness fixes (Bug#8873).
3617 A few related buffer overrun fixes, too.
3618
b79e8648
PE
3619 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3620
0766b489
PE
3621 * dispextern.h (struct face.stipple):
3622 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3623 (x_bitmap_mask, x_allocate_bitmap_record)
3624 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3625 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3626 (x_create_bitmap_from_xpm_data):
3627 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3628 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3629 (.bitmaps_last):
3630 * xfaces.c (load_pixmap):
3631 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3632 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3633 (.bitmaps_last, struct x_output.icon_bitmap):
3634 Use ptrdiff_t, not int, for bitmap indexes.
3635 (x_allocate_bitmap_record): Check for size overflow.
3636 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3637
b081724f
PE
3638 Use ptrdiff_t, not int, for overlay counts.
3639 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3640 * editfns.c (overlays_around, get_pos_property):
3641 * textprop.c (get_char_property_and_overlay):
3642 * xdisp.c (next_overlay_change, note_mouse_highlight):
3643 * xfaces.c (face_at_buffer_position):
21514da7
PE
3644 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3645 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3646 (Fnext_overlay_change, Fprevious_overlay_change)
3647 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3648 Use ptrdiff_t, not int, for sizes.
21514da7 3649 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3650
3de73e5e
PE
3651 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3652
2606c57b
PE
3653 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3654 (x_session_initialize): Do not assume string length fits in int.
3655
aaafe47a
PE
3656 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3657 This is unlikely, but can occur if DPI is outlandish.
3658
2674ddc8 3659 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3660 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3661
28154962
PE
3662 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3663 * xrdb.c (magic_file_p, search_magic_path):
3664 Omit last arg SUFFIX; it was always 0. All callers changed.
3665 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3666
7de51af5
PE
3667 * xfont.c (xfont_match): Avoid need for strlen.
3668
25ed6cc3
PE
3669 * xfns.c: Don't assume strlen fits in int.
3670 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3671
4eab31dd
PE
3672 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3673 not unsigned long, as we prefer signed integers. All callers changed.
3674 Detect integer overflow in repeat count.
3675 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3676 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3677
171e2a58
PE
3678 * termcap.c: Don't assume sizes fit in int and never overflow.
3679 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3680 (gobble_line): Check for size-calculation overflow.
3681
ad39faca 3682 * minibuf.c (Fread_buffer):
6e5bb2dc 3683 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3684 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3685 Don't assume string length fits in int.
3686
52c61c22 3687 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3688 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3689
b5b8c9e5
PE
3690 * font.c: Don't assume string length fits in int.
3691 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3692 Use ptrdiff_t, not int.
ccd6111c
PE
3693 (font_intern_prop): Don't assume string length fits in int.
3694 Don't assume integer property fits in fixnum.
3695 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3696
882f0d81 3697 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3698 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3699 Reformulate so as not to need the command string.
3700 Invoke gzip -cd rather than gunzip, as it's more portable.
3701 (lock_info_type, lock_file_1, lock_file):
3702 Don't assume pid_t and time_t fit in unsigned long.
3703 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3704 (current_lock_owner): Prefer signed type for sizes.
3705 Use memcpy, not strncpy, where memcpy is what is really wanted.
3706 Don't assume (via atoi) that time_t and pid_t fit in int.
3707 Check for time_t and/or pid_t out of range, e.g., via a network share.
3708 Don't alloca where an auto var works fine.
3709
93f4cf88
PE
3710 * fileio.c: Fix some integer overflow issues.
3711 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3712 Don't assume string length fits in int.
3713 (directory_file_name): Don't assume string length fits in long.
3714 (make_temp_name): Don't assume pid fits in int, or that its print
3715 length is less than 20.
3716
f3e92b69
PE
3717 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3718
1bfdaf10
PE
3719 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3720
35016e9a
PE
3721 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3722
3d1e65a1
PE
3723 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3724 We prefer signed integers, even for size calculations.
3725
0b963a93
PE
3726 * emacs.c: Don't assume string length fits in 'int'.
3727 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3728 (main): Don't invoke strlen when not needed.
3729
573f4b54
PE
3730 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3731 (XD_DEBUG_MESSAGE): Don't waste a byte.
3732
989f33ba
PE
3733 * callproc.c (getenv_internal_1, getenv_internal)
3734 (Fgetenv_internal):
965d34eb
PE
3735 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3736
e4d29b33
PE
3737 * lread.c (invalid_syntax): Omit length argument.
3738 All uses changed. This doesn't fix a bug, but it simplifies the
3739 code away from its former Hollerith-constant appearance, and it's
3740 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3741 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3742
eb49b136
PE
3743 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3744 This didn't break anything, but it didn't help either.
3745 It's confusing to put a bogus integer in a place where the actual
3746 value does not matter.
9f62aeb1 3747 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3748 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3749
15375a22
PE
3750 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3751 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3752 implementation.
b61cc01c
PE
3753 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3754 We prefer signed types, and the value cannot exceed the EMACS_INT
3755 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3756 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3757 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3758 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3759
53b2623d
PE
3760 * indent.c (sane_tab_width): New function.
3761 (current_column, scan_for_column, Findent_to, position_indentation)
3762 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3763 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3764
51cab52b 3765 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3766
f2ed8a70
PE
3767 * lisp.h (lint_assume): New macro.
3768 * composite.c (composition_gstring_put_cache):
3769 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3770
abe80cc6
PE
3771 * editfns.c, insdel.c:
3772 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3773
b02c740e
PE
3774 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3775
ebc96716
PE
3776 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3777
b4e50fa0 3778 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3779 Use much-faster test for byte-length change.
311d5d7c 3780 Don't assume string byte-length fits in 'int'.
a4cf38e4 3781 Check that character arg fits in 'int'.
85461888 3782 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3783
c0c1ee9f
PE
3784 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3785
a498d7f4
PE
3786 * fns.c (concat): Catch string overflow earlier.
3787 Do not rely on integer wraparound.
3788
51cab52b
PE
3789 * dispextern.h (struct it.overlay_strings_charpos)
3790 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3791 * xdisp.c (forward_to_next_line_start)
3792 (back_to_previous_visible_line_start)
3793 (reseat_at_next_visible_line_start, next_element_from_buffer):
3794 Don't arbitrarily truncate the value of 'selective' to int.
3795
76031fad
PE
3796 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3797
5eb55db9
PE
3798 * composite.c: Don't truncate sizes to 'int'.
3799 (composition_gstring_p, composition_reseat_it)
3800 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3801 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3802 not EMACS_UINT, for indexes.
5eb55db9 3803
0703a717
PE
3804 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3805
d6202519
PE
3806 * buffer.c: Include <verify.h>.
3807 (struct sortvec.priority, struct sortstr.priority):
8961a454 3808 Now EMACS_INT, not int.
c20998a7 3809 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3810 (struct sortstr.size, record_overlay_string)
3811 (struct sortstrlist.size, struct sortlist.used):
3812 Don't truncate size to int.
3813 (record_overlay_string): Check for size-calculation overflow.
d6202519 3814 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3815
d5a19415
JM
38162011-06-22 Jim Meyering <meyering@redhat.com>
3817
029529ac 3818 Don't leak an XBM-image-sized buffer
d5a19415
JM
3819 * image.c (xbm_load): Free the image buffer after using it.
3820
a9041e6c
PE
38212011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3822
3823 Port to Sun C.
3824 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3825 that Sun C diagnosed.
3826 * fns.c (secure_hash): Fix pointer signedness issue.
3827 * intervals.c (static_offset_intervals): New function.
3828 (offset_intervals): Use it.
3829
7f3f739f
LL
38302011-06-21 Leo Liu <sdl.web@gmail.com>
3831
3832 * deps.mk (fns.o):
3833 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3834 sha512.h.
3835
3836 * fns.c (secure_hash): Rename from crypto_hash_function and change
3837 the first arg to accept symbols.
5b66d427 3838 (Fsecure_hash): New primitive.
7f3f739f
LL
3839 (syms_of_fns): New symbols.
3840
76147d94
DD
38412011-06-20 Deniz Dogan <deniz@dogan.se>
3842
3843 * process.c (Fset_process_buffer): Clarify return value in
3844 docstring.
3845
7d7d0045
CY
38462011-06-18 Chong Yidong <cyd@stupidchicken.com>
3847
3848 * dispnew.c (add_window_display_history): Use BVAR.
3849
3850 * xdisp.c (debug_method_add): Use BVAR.
3851 (check_window_end, dump_glyph_matrix, dump_glyph)
3852 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3853
3854 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3855 Likewise.
3856
3857 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3858 check till after the cache is created in init_frame_faces.
3859
ff2bc410
SM
38602011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3861
3862 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3863
28177add
PE
38642011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3865
dd3482fe
PE
3866 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3867 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3868 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3869
393d71f3 3870 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3871 * fileio.c (Finsert_file_contents):
3872 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3873 Remove the old (too-loose) buffer overflow checks.
3874 They weren't needed, since make_gap checks for buffer overflow.
3875 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3876 The old code merely checked for Emacs fixnum overflow, and relied
3877 on undefined (wraparound) behavior. The new code avoids undefined
3878 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3879
2e6813b0 3880 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3881 Tune. Don't use wider integers than needed. Don't use alloca.
3882 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3883
599a9e4f
PE
3884 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3885
99561444
PE
3886 * insdel.c, lisp.h (buffer_overflow): New function.
3887 (insert_from_buffer_1, replace_range, replace_range_2):
3888 * insdel.c (make_gap_larger):
3889 * editfns.c (Finsert_char):
3890 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3891
28177add
PE
3892 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3893
e69dafad
PE
38942011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3895
a7af7fde 3896 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3897
b1c46f02
PE
3898 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3899 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3900
e69dafad
PE
3901 * fileio.c: Don't assume EMACS_INT fits in off_t.
3902 (emacs_lseek): New static function.
3903 (Finsert_file_contents, Fwrite_region): Use it.
3904 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3905
566684ea
PE
3906 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3907
e6966cd6
PE
3908 * fns.c: Don't overflow int when computing a list length.
3909 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3910 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3911 truncation on 64-bit hosts. Check for QUIT every
3912 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3913 faster and is responsive enough.
3914 (Flength): Report an error instead of overflowing an integer.
3915 (Fsafe_length): Return a float if the value is not representable
3916 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3917 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3918 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3919
dd0b0efb
PE
3920 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3921 (header_size, word_size): New constants.
3922 (allocate_vectorlike): Don't check size overflow here.
3923 (allocate_vector): Check it here instead, since this is the only
3924 caller of allocate_vectorlike that could cause overflow.
3925 Check that the new vector's length is representable as a fixnum.
3926
86fe5cfe
PE
3927 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3928 The previous code was bogus. For example, next_almost_prime (32)
3929 returned 39, which is undesirable as it is a multiple of 3; and
3930 next_almost_prime (24) returned 25, which is a multiple of 5 so
3931 why was the code bothering to check for multiples of 7?
3932
80e88859
PE
3933 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3934
4a2f0ad6
PE
3935 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3936
f66c7cf8
PE
3937 Variadic C functions now count arguments with ptrdiff_t.
3938 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3939 Back then I didn't know that the Emacs coding style prefers signed int.
3940 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3941 were being counted with int, which may truncate counts on 64-bit
3942 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3943 * lisp.h (struct Lisp_Subr.function.aMANY)
3944 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3945 Arg counts are now ptrdiff_t, not size_t.
3946 All variadic functions and their callers changed accordingly.
3947 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3948 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3949 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3950 * callint.c (Fcall_interactively): Check arg count for overflow,
3951 to avoid potential buffer overrun. Use signed char, not 'int',
3952 for 'varies' array, so that we needn't bother to check its size
3953 calculation for overflow.
3954 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3955 * eval.c (apply_lambda):
3956 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3957 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3958 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3959
a1759b76
PE
3960 * callint.c (Fcall_interactively): Don't use index var as event count.
3961
d96be9fc
PE
3962 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3963 * mem-limits.h (SIZE): Remove; no longer used.
3964
a690a978 3965 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3966
578c21e6
PE
3967 Remove unnecessary casts.
3968 * xterm.c (x_term_init):
3969 * xfns.c (x_set_border_pixel):
3970 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3971 These aren't needed now that we assume ANSI C.
3972
96f53c6c
PE
3973 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3974 It's more likely to cause problems (due to unsigned overflow)
3975 than to cure them.
3976
83c77d31
PE
3977 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3978
ee2079f1
PE
3979 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3980
6da65536
PE
3981 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3982
7147c4a4
PE
3983 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3984
193e32d9
PE
3985 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3986
e5533da6
PE
3987 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3988
9910e595
PE
3989 GLYPH_CODE_FACE returns EMACS_INT, not int.
3990 * dispextern.h (merge_faces):
3991 * xfaces.c (merge_faces):
01103c44
PE
3992 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3993 Don't assume EMACS_INT fits in int.
9910e595 3994
2638320e
PE
3995 * character.h (CHAR_VALID_P): Remove unused parameter.
3996 * fontset.c, lisp.h, xdisp.c: All uses changed.
3997
045eb8d9
PE
3998 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3999
c1f134b5
PE
4000 * fns.c (concat): Minor tuning based on overflow analysis.
4001 This doesn't fix any bugs. Use int to hold character, instead
4002 of constantly refetching from Emacs object. Use XFASTINT, not
4003 XINT, for value known to be a character. Don't bother comparing
4004 a single byte to 0400, as it's always less.
4005
395fcb93 4006 * floatfns.c (Fexpt):
327eeec8
PE
4007 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4008
abbd3d23
PE
4009 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4010 for characters.
4011
684a03ef
PE
4012 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4013
0fed43f3
PE
4014 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4015 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4016 incorrectly succeed when S was a string, because 4294967386 was
4017 truncated before it was used.
4018
8fd02eb7
PE
4019 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4020 Otherwise, an out-of-range integer could cause undefined behavior
4021 on a 64-bit host.
4022
f8c86b69
PE
4023 * composite.c: Use int, not EMACS_INT, for characters.
4024 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4025 EMACS_INT, for values that are known to be in character range.
4026 This doesn't fix any bugs but is the usual style inside Emacs and
4027 may generate better code on 32-bit machines.
4028
34206dd2
PE
4029 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4030 This is for reasons similar to the recent CHAR_STRING fix.
4031 * charset.c (Fencode_char): Check that character arg is actually
4032 a character. Pass an int to ENCODE_CHAR.
4033 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4034 wider than 'int', as a compile-time check to prevent future regressions
4035 in this area.
4036
c5958d4c 4037 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4038
4039 Make sure a 64-bit char is never passed to CHAR_STRING.
4040 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4041 by silently ignoring the top 32 bits, allowing some values
4042 that were far too large to be valid characters.
4043 * character.h: Include <verify.h>.
4044 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4045 arguments are no wider than unsigned, as a compile-time check
4046 to prevent future regressions in this area.
4047 * data.c (Faset):
01103c44 4048 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4049 (Fsubst_char_in_region):
4050 * fns.c (concat):
4051 * xdisp.c (decode_mode_spec_coding):
4052 Adjust to CHAR_STRING's new requirement.
4053 * editfns.c (Finsert_char, Fsubst_char_in_region):
4054 * fns.c (concat): Check that character args are actually
4055 characters. Without this test, these functions did the wrong
4056 thing with wildly out-of-range values on 64-bit hosts.
4057
d37ca623
PE
4058 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4059 These casts should not be needed on 32-bit hosts, either.
4060 * keyboard.c (read_char):
4061 * lread.c (Fload): Remove casts to unsigned.
4062
ea204efb
PE
4063 * lisp.h (UNSIGNED_CMP): New macro.
4064 This fixes comparison bugs on 64-bit hosts.
4065 (ASCII_CHAR_P): Use it.
4066 * casefiddle.c (casify_object):
01103c44 4067 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4068 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4069 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4070 * dispextern.h (FACE_FROM_ID):
4071 * keyboard.c (read_char): Use UNSIGNED_CMP.
4072
41cb286c
PE
4073 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4074 not to EMACS_INT, to avoid GCC warning.
4075
4a1b9832
PE
4076 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4077
55daad71
PE
4078 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4079 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4080 isn't needed on 32-bit machines.
8f95c75c 4081
01103c44
PE
4082 * buffer.c (Fgenerate_new_buffer_name):
4083 Use EMACS_INT for count, not int.
0ceccced 4084 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4085
4086 * data.c (Qcompiled_function): Now static.
4087
c6f072e7
PE
4088 * window.c (window_body_lines): Now static.
4089
20ce5912
PE
4090 * image.c (gif_load): Rename local to avoid shadowing.
4091
9c4c5f81
PE
4092 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4093 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4094 * alloc.c (make_save_value): Integer argument is now of type
4095 ptrdiff_t, not int.
4096 (mark_object): Use ptrdiff_t, not int.
4097 * lisp.h (pD): New macro.
4098 * print.c (print_object): Use it.
4099
c0c5c8ae
PE
4100 * alloc.c: Use EMACS_INT, not int, to count objects.
4101 (total_conses, total_markers, total_symbols, total_vector_size)
4102 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4103 (total_free_floats, total_floats, total_free_intervals)
4104 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4105 Now EMACS_INT, not int. All uses changed.
4106 (Fgarbage_collect): Compute overall total using a double, so that
4107 integer overflow is less likely to be a problem. Check for overflow
4108 when converting back to an integer.
5a25e253
PE
4109 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4110 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4111 These were 'int' variables that could overflow on 64-bit hosts;
4112 they were never used, so remove them instead of repairing them.
211a0b2a 4113 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4114 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4115 Previously, this ceilinged at INT_MAX, but that doesn't work on
4116 64-bit machines.
e46bb31a 4117 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4118
c78baabf 4119 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4120 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4121 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4122 when a (possibly-narrower) signed value would do just as well.
4123 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4124
c9d624c6
PE
4125 * alloc.c: Catch some string size overflows that we were missing.
4126 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4127 for convenience in STRING_BYTES_MAX.
4128 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4129 The definition here is exact; the one in lisp.h was approximate.
4130 (allocate_string_data): Check for string overflow. This catches
4131 some instances we weren't catching before. Also, it catches
4132 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4133 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4134 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4135
c9d624c6
PE
4136 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4137 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4138 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4139
353032ce
PE
4140 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4141
2bccce07
PE
4142 * alloc.c (Fmake_string): Check for out-of-range init.
4143
0ac30604
SM
41442011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4145
4146 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4147
c195f2de
JD
41482011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4149
4150 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4151 xg_get_default_scrollbar_width.
4152
4153 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4154 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4155 (style_changed_cb): Call update_theme_scrollbar_width and call
4156 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4157 all frames (Bug#8505).
4158 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4159 Call gtk_window_set_resizable if HAVE_GTK3.
4160 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4161 and height if HAVE_GTK3 (Bug#8505).
4162 (scroll_bar_width_for_theme): New variable.
4163 (update_theme_scrollbar_width): New function.
4164 (xg_get_default_scrollbar_width): Move code to
4165 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4166 (xg_initialize): Call update_theme_scrollbar_width.
4167
4168 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4169
4170 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4171
e10ac9f1
MR
41722011-06-12 Martin Rudalics <rudalics@gmx.at>
4173
4174 * frame.c (make_frame): Call other_buffer_safely instead of
4175 other_buffer.
4176
4177 * window.c (temp_output_buffer_show): Call display_buffer with
4178 second argument Vtemp_buffer_show_specifiers and reset latter
4179 immediately after the call.
4180 (Vtemp_buffer_show_specifiers): New variable.
4181 (auto_window_vscroll_p, next_screen_context_lines)
4182 (Vscroll_preserve_screen_position): Remove leading asterisks from
4183 doc-strings.
4184
2d3c217e 41852011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4186
7b7f97e8 4187 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4188 * buffer.c (Qclone_number): Remove for now, as it's unused.
4189 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4190 (record_buffer): Remove unused local.
4191 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4192 (set_frame_buffer_list): Remove; unused.
4193 * frame.h (other_visible_frames): Remove decl.
4194 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4195 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4196 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4197 if HAVE_GPM.
4198 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4199 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4200 Define only if HAVE_GPM.
4201 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4202 (update_hints_inhibit): Remove; never set. All uses removed.
4203 * widgetprv.h (emacsFrameClassRec): Remove decl.
4204 * window.c (delete_deletable_window): Now returns void, since it
4205 wasn't returning anything.
4206 (compare_window_configurations): Remove unused locals.
4207 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4208 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4209 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4210 the same widths as pointers. This follows up on the 2011-05-06 patch.
4211 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4212 * xterm.h: Likewise.
4213 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4214
1384b89e
JB
42152011-06-12 Juanma Barranquero <lekktu@gmail.com>
4216
4217 * makefile.w32-in: Update dependencies.
4218 (LISP_H): Add lib/intprops.h.
4219
1100a63c
CY
42202011-06-11 Chong Yidong <cyd@stupidchicken.com>
4221
4222 * image.c (gif_load): Add animation frame delay to the metadata.
4223 (syms_of_image): Use DEFSYM. New symbol `delay'.
4224
6198ccd0
MR
42252011-06-11 Martin Rudalics <rudalics@gmx.at>
4226
4227 * window.c (delete_deletable_window): Re-add.
4228 (Fset_window_configuration): Rewrite to handle dead buffers and
4229 consequently deletable windows.
4230 (window_tree, Fwindow_tree): Remove. Supply functionality in
4231 window.el.
4232 (compare_window_configurations): Simplify code.
4233
b6e3633c
AS
42342011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4235
1ab0dee5
AS
4236 * image.c (imagemagick_load_image): Fix type mismatch.
4237 (Fimagemagick_types): Likewise.
4238
b6e3633c
AS
4239 * window.h (replace_buffer_in_windows): Declare.
4240
9397e56f
MR
42412011-06-11 Martin Rudalics <rudalics@gmx.at>
4242
4243 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4244 Qclone_number. Remove external declaration of Qdelete_window.
4245 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4246 code.
640c8776
SM
4247 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4248 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4249 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4250 buffer list implementation.
4251 (other_buffer_safely): New function.
4252 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4253 calls to replace_buffer_in_windows and
4254 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4255 if allowed.
4256 (record_buffer): Inhibit quitting and rewrite using quittable
4257 functions. Run Qbuffer_list_update_hook if allowed.
4258 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4259 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4260 Move switch-to-buffer to window.el.
9397e56f
MR
4261 (bury-buffer): Move to window.el.
4262 (Vbuffer_list_update_hook): New variable.
4263
4264 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4265 section.
4266
4267 * window.h (resize_frame_windows): Move up in code.
4268 (Fwindow_frame): Remove EXFUN.
4269 (replace_buffer_in_all_windows): Remove prototype.
4270 (replace_buffer_in_windows_safely): Add prototype.
4271
4272 * window.c: Declare Qdelete_window static again. Move down
4273 declaration of select_count.
4274 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4275 (Fother_window): Move to window.el.
4276 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4277 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4278 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4279 window.el.
4280 (replace_buffer_in_windows): Implement by calling
4281 Qreplace_buffer_in_windows.
4282 (replace_buffer_in_all_windows): Remove with some functionality
4283 moved into replace_buffer_in_windows_safely.
4284 (replace_buffer_in_windows_safely): New function.
4285 (select_window_norecord, select_frame_norecord): Move in front
4286 of run_window_configuration_change_hook. Remove now obsolete
4287 declarations.
640c8776
SM
4288 (Fset_window_buffer): Rewrite doc-string.
4289 Call Qrecord_window_buffer.
9397e56f
MR
4290 (keys_of_window): Move binding for other-window to window.el.
4291
b50691aa
CY
42922011-06-11 Chong Yidong <cyd@stupidchicken.com>
4293
4294 * dispextern.h (struct image): Replace data member, whose int_val
4295 and ptr_val fields were not used by anything, with a single
4296 lisp_val object.
4297
4298 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4299 (gif_clear_image, gif_load, imagemagick_load_image)
4300 (gs_clear_image, gs_load): Callers changed.
4301
3f754b86
PE
43022011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4303
cca69397
PE
4304 * buffer.h: Include <time.h>, for time_t.
4305 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4306
109e28d0
PE
4307 Fix minor problems found by static checking.
4308
60737f02
PE
4309 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4310
4b66faf3
PE
4311 Make identifiers static if they are not used in other modules.
4312 * data.c (Qcompiled_function, Qframe, Qvector):
4313 * image.c (QimageMagick, Qsvg):
4314 * minibuf.c (Qmetadata):
4315 * window.c (resize_window_check, resize_root_window): Now static.
4316 * window.h (resize_window_check, resize_root_window): Remove decls.
4317
109e28d0
PE
4318 * window.c (window_deletion_count, delete_deletable_window):
4319 Remove; unused.
46a4ce9e
PE
4320 (window_body_lines): Now static.
4321 (Fdelete_other_windows_internal): Mark vars as initialized.
4322 Make sure 'resize_failed' is initialized.
4323 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4324 (resize_window_apply): Remove unused local.
4325 * window.h (delete_deletable_window): Remove decl.
4326
109e28d0 4327 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4328 (imagemagick_load_image): Fix pointer signedness problem by changing
4329 last arg from unsigned char * to char *. All uses changed.
4330 Also, fix a local for similar reasons.
4331 Remove unused locals. Remove locals to avoid shadowing.
4332 (fn_rsvg_handle_free): Remove; unused.
4333 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4334 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4335
3f754b86
PE
4336 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4337
2547adb1
CY
43382011-06-10 Chong Yidong <cyd@stupidchicken.com>
4339
4340 * image.c (gif_load): Fix omitted cast error introduced by
4341 2011-06-06 change.
4342
2c8e37d4
MR
43432011-06-10 Martin Rudalics <rudalics@gmx.at>
4344
4345 * window.h (resize_proportionally, orig_total_lines)
4346 (orig_top_line): Remove from window structure.
4347 (set_window_height, set_window_width, change_window_heights)
4348 (Fdelete_window): Remove prototypes.
4349 (resize_frame_windows): Remove duplicate declaration.
4350
440a42e3
EZ
43512011-06-10 Eli Zaretskii <eliz@gnu.org>
4352
4353 * window.h (resize_frame_windows, resize_window_check)
4354 (delete_deletable_window, resize_root_window)
4355 (resize_frame_windows): Declare prototypes.
4356
4357 * window.c (resize_window_apply): Make definition be "static" to
4358 match the prototype.
4359
562dd5e9
MR
43602011-06-10 Martin Rudalics <rudalics@gmx.at>
4361
4362 * window.c: Remove declarations of Qwindow_size_fixed,
4363 window_min_size_1, window_min_size_2, window_min_size,
4364 size_window, window_fixed_size_p, enlarge_window, delete_window.
4365 Remove static from declaration of Qdelete_window, it's
4366 temporarily needed by Fbury_buffer.
4367 (replace_window): Don't assign orig_top_line and
4368 orig_total_lines.
4369 (Fdelete_window, delete_window): Remove. Window deletion is
4370 handled by window.el.
640c8776
SM
4371 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4372 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4373 (Fdelete_other_windows): Remove. Deleting other windows is
4374 handled by window.el.
4375 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4376 handled in window.el.
4377 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4378 Window minimum sizes are handled in window.el.
4379 (shrink_windows, size_window, set_window_height)
4380 (set_window_width, change_window_heights, window_height)
4381 (window_width, CURBEG, CURSIZE, enlarge_window)
4382 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4383 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4384 handled in window.el.
4385 (make_dummy_parent): Rename to make_parent_window and give it a
4386 second argument horflag.
4387 (make_window): Don't set resize_proportionally any more.
4388 (Fsplit_window): Remove. Windows are split in window.el.
4389 (save_restore_action, save_restore_orig_size)
4390 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4391 Resize mini windows in window.el.
4392 (grow_mini_window, shrink_mini_window): Implement by calling
4393 Qresize_root_window_vertically, resize_window_check and
4394 resize_window_apply.
640c8776
SM
4395 (saved_window, Fset_window_configuration, save_window_save):
4396 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4397 resize_proportionally.
4398 (window_min_height, window_min_width): Move to window.el.
4399 (keys_of_window): Move bindings for delete-other-windows,
4400 split-window, delete-window and enlarge-window to window.el.
4401
4402 * buffer.c: Temporarily extern Qdelete_window.
4403 (Fbury_buffer): Temporarily call Qdelete_window instead of
4404 Fdelete_window (Fbury_buffer will move to window.el soon).
4405
4406 * frame.c (set_menu_bar_lines_1): Remove code handling
4407 orig_top_line and orig_total_lines.
4408
4409 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4410 set_window_height but set heights directly.
4411 (change_frame_size_1): Use resize_frame_windows.
4412
4413 * xdisp.c (init_xdisp): Don't use set_window_height but set
4414 heights directly.
4415
640c8776
SM
4416 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4417 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4418 run_window_configuration_change_hook.
4419
4420 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4421 instead of change_window_heights and run
4422 run_window_configuration_change_hook.
4423
1a13852e
MR
44242011-06-09 Martin Rudalics <rudalics@gmx.at>
4425
4426 * window.c (replace_window): Rename second argument REPLACEMENT to
4427 NEW. New third argument SETFLAG. Rewrite.
4428 (delete_window, make_dummy_parent): Call replace_window with
4429 third argument 1.
4430 (window_list_1): Move down in code.
4431 (run_window_configuration_change_hook): Move set_buffer part
4432 before select_frame_norecord part in order to unwind correctly.
4433 Rename count1 to count.
4434 (recombine_windows, delete_deletable_window, resize_root_window)
4435 (Fdelete_other_windows_internal)
4436 (Frun_window_configuration_change_hook, make_parent_window)
4437 (resize_window_check, resize_window_apply, Fresize_window_apply)
4438 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4439 (Fdelete_window_internal, Fresize_mini_window_internal):
4440 New functions.
1a13852e
MR
4441 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4442
f3d1777e
MR
44432011-06-08 Martin Rudalics <rudalics@gmx.at>
4444
496e208e
MR
4445 * window.h (window): Add some new members to window structure -
4446 normal_lines, normal_cols, new_total, new_normal, clone_number,
4447 splits, nest, prev_buffers, next_buffers.
4448 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4449 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4450
f3d1777e
MR
4451 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4452 Remove.
496e208e
MR
4453 (make_dummy_parent): Set new members of windows structure.
4454 (make_window): Move down in code. Handle new members of window
4455 structure.
4456 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4457 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4458 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4459 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4460 (Fset_window_next_buffers, Fset_window_clone_number):
4461 New functions.
496e208e
MR
4462 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4463 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4464 Doc-string fixes.
4465 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4466 Argument WINDOW can be now internal window too.
4467 (Fwindow_use_time): Move up in code.
4468 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4469 Rewrite doc-string.
4470 (Fset_window_configuration, saved_window)
4471 (Fcurrent_window_configuration, save_window_save): Handle new
4472 members of window structure.
b9e809c2
MR
4473 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4474 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4475 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4476 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4477 Qget_mru_window, Qresize_root_window,
4478 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4479 Qauto_buffer_name; staticpro them.
f3d1777e 4480
abde8f8c
MR
44812011-06-07 Martin Rudalics <rudalics@gmx.at>
4482
4483 * window.c (Fwindow_total_size, Fwindow_left_column)
4484 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4485 (Fwindow_list_1): New functions.
4486 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4487 (Fwindow_width, Fscroll_left, Fscroll_right):
4488 Use window_body_cols instead of window_box_text_cols.
4489 (delete_window, Fset_window_configuration):
4490 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4491 (delete_all_subwindows): Take a window as argument and not a
4492 structure. Rewrite.
190b47e6
MR
4493 (window_loop): Remove handling of GET_LRU_WINDOW and
4494 GET_LARGEST_WINDOW.
4495 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4496
4497 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4498 window_box_text_cols. delete_all_subwindows now takes a
4499 Lisp_Object as argument.
abde8f8c 4500
640c8776
SM
4501 * indent.c (compute_motion, Fcompute_motion):
4502 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4503
fa8a67e6
MR
4504 * frame.c (delete_frame): Call delete_all_subwindows with root
4505 window as argument.
4506
a54e3482
DC
45072011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4508
4509 * fns.c (Fputhash): Document return value.
4510
60002bf5
CY
45112011-06-06 Chong Yidong <cyd@stupidchicken.com>
4512
4513 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4514
0c671da6 45152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4516
b862a52a 4517 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4518
be44ca6c
PE
4519 Check for overflow when converting integer to cons and back.
4520 * charset.c (Fdefine_charset_internal, Fdecode_char):
4521 Use cons_to_unsigned to catch overflow.
4522 (Fencode_char): Use INTEGER_TO_CONS.
4523 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4524 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4525 * data.c (long_to_cons, cons_to_long): Remove.
4526 (cons_to_unsigned, cons_to_signed): New functions.
4527 These signal an error for invalid or out-of-range values.
4528 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4529 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4530 * font.c (Ffont_variation_glyphs):
4531 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4532 * lisp.h: Include <intprops.h>.
4533 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4534 (cons_to_signed, cons_to_unsigned): New decls.
4535 (long_to_cons, cons_to_long): Remove decls.
4536 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4537 (Fprimitive_undo): Use CONS_TO_INTEGER.
4538 * xfns.c (Fx_window_property): Likewise.
4539 * xselect.c: Include <limits.h>.
4540 (x_own_selection, selection_data_to_lisp_data):
4541 Use INTEGER_TO_CONS.
4542 (x_handle_selection_request, x_handle_selection_clear)
4543 (x_get_foreign_selection, Fx_disown_selection_internal)
4544 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4545 (lisp_data_to_selection_data): Use cons_to_unsigned.
4546 (x_fill_property_data): Use cons_to_signed.
4547 Report values out of range.
4548
d1f3d2af
PE
4549 Check for buffer and string overflow more precisely.
4550 * buffer.h (BUF_BYTES_MAX): New macro.
4551 * lisp.h (STRING_BYTES_MAX): New macro.
4552 * alloc.c (Fmake_string):
4553 * character.c (string_escape_byte8):
4554 * coding.c (coding_alloc_by_realloc):
4555 * doprnt.c (doprnt):
4556 * editfns.c (Fformat):
4557 * eval.c (verror):
4558 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4559 since they may not be the same number.
4560 * editfns.c (Finsert_char):
4561 * fileio.c (Finsert_file_contents):
4562 Likewise for BUF_BYTES_MAX.
4563
dd52fcea
PE
4564 * image.c: Use ptrdiff_t, not int, for sizes.
4565 (slurp_file): Switch from int to ptrdiff_t.
4566 All uses changed.
4567 (slurp_file): Check that file size fits in both size_t (for
4568 malloc) and ptrdiff_t (for sanity and safety).
4569
7f9bbdbb
PE
4570 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4571 if b->modtime has its maximal value.
4572
dfe18f82
PE
4573 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4574
84acfcf0
PE
4575 Don't assume time_t can fit into int.
4576 * buffer.h (struct buffer.modtime): Now time_t, not int.
4577 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4578 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4579
ccd9a01a
PE
4580 Minor fixes for signed vs unsigned integers.
4581 * character.h (MAYBE_UNIFY_CHAR):
4582 * charset.c (maybe_unify_char):
4583 * keyboard.c (read_char, reorder_modifiers):
4584 XINT -> XFASTINT, since the integer must be nonnegative.
4585 * ftfont.c (ftfont_spec_pattern):
4586 * keymap.c (access_keymap, silly_event_symbol_error):
4587 XUINT -> XFASTINT, since the integer must be nonnegative.
4588 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4589 since it makes no difference and we prefer signed.
4590 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4591 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4592 nonnegative.
4593
d6d100dd
SM
45942011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4595
4596 * window.h (Fwindow_frame): Declare.
4597
2b6148e4
PE
45982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4601 (SPARE_MEMORY): Always define.
4602 (LARGE_REQUEST): Remove.
4603 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4604
f230ecc9
MR
46052011-06-06 Martin Rudalics <rudalics@gmx.at>
4606
727e958e
MR
4607 * lisp.h: Move EXFUNS for Fframe_root_window,
4608 Fframe_first_window and Fset_frame_selected_window to window.h.
4609
4610 * window.h: Move EXFUNS for Fframe_root_window,
4611 Fframe_first_window and Fset_frame_selected_window here from
4612 lisp.h.
4613
4614 * frame.c (Fwindow_frame, Fframe_first_window)
4615 (Fframe_root_window, Fframe_selected_window)
4616 (Fset_frame_selected_window): Move to window.c.
4617 (Factive_minibuffer_window): Move to minibuf.c.
4618 (Fother_visible_frames_p): New function.
4619
4620 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4621
f230ecc9
MR
4622 * window.c (decode_window, decode_any_window): Move up in code.
4623 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4624 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4625 (Fwindow_buffer): Move up and rewrite doc-string.
4626 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4627 (Fwindow_prev): New functions.
727e958e
MR
4628 (Fwindow_frame): Move here from frame.c. Accept any window as
4629 argument.
4630 (Fframe_root_window, Fframe_first_window)
4631 (Fframe_selected_window): Move here from frame.c. Accept frame
4632 or arbitrary window as argument. Update doc-strings.
4633 (Fminibuffer_window): Move up in code.
4634 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4635 (Fset_frame_selected_window): Move here from frame.c.
4636 Marginal rewrite.
727e958e
MR
4637 (Fselected_window, select_window, Fselect_window): Move up in
4638 code. Minor doc-string fixes.
f230ecc9 4639
4d09bcf6
PE
46402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4641
4642 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4643 Do not assume that spare memory exists; that assumption is valid
4644 only if SYSTEM_MALLOC.
4645 (LARGE_REQUEST): New macro, so that the issue of large requests
4646 is separated from the issue of spare memory.
4647
810928a2
AS
46482011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4649
172418ad
AS
4650 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4651 format. (Bug#8806)
4652
43f862f7
AS
4653 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4654
810928a2
AS
4655 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4656 before statements.
4657
a059fe24
JD
46582011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4659
4660 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4661
4662 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4663
4664 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4665 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4666
989bf368
JB
46672011-06-05 Juanma Barranquero <lekktu@gmail.com>
4668
4669 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4670
4b80f674
CY
46712011-06-04 Chong Yidong <cyd@stupidchicken.com>
4672
4673 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4674 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4675 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4676 New error handlers.
4b80f674
CY
4677 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4678 Obey Vx_select_enable_clipboard_manager. Catch errors in
4679 x_clipboard_manager_save (Bug#8779).
4680 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4681 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4682
99a33b77 46832011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4684
4685 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4686
99a33b77 46872011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4688
4689 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4690 in the current matrix if keep_current_p is non-zero.
4691
8264569d
EZ
46922011-06-04 Eli Zaretskii <eliz@gnu.org>
4693
4694 * bidi.c (bidi_level_of_next_char): Fix last change.
4695
57f97249
EZ
46962011-06-03 Eli Zaretskii <eliz@gnu.org>
4697
fec2107c 4698 Support bidi reordering of text covered by display properties.
57f97249 4699
fec2107c
EZ
4700 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4701 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4702 (bidi_cache_search, bidi_cache_iterator_state)
4703 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4704 (bidi_level_of_next_char, bidi_move_to_visually_next):
4705 Support character positions inside a run of characters covered by a
fec2107c
EZ
4706 display string.
4707 (bidi_paragraph_init, bidi_resolve_explicit_1)
4708 (bidi_level_of_next_char): Call bidi_fetch_char and
4709 bidi_fetch_char_advance instead of FETCH_CHAR and
4710 FETCH_CHAR_ADVANCE.
4711 (bidi_init_it): Initialize new members.
4712 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4713 definitions.
4714 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4715 instead of using explicit *_CHAR codes.
d6d100dd
SM
4716 (bidi_resolve_explicit, bidi_resolve_weak):
4717 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4718 bidirectional text is supported only in multibyte buffers.
4719 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4720 it to initialize the frame_window_p member of struct bidi_it.
4721 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4722 (bidi_resolve_explicit, bidi_resolve_weak)
4723 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4724 bidi_it->nchars is non-positive.
4725 (bidi_level_of_next_char): Don't try to lookup the cache for the
4726 next/previous character if nothing is cached there yet, or if we
4727 were just reseat()'ed to a new position.
c40e2fb2 4728
0e14fe90
EZ
4729 * xdisp.c (set_cursor_from_row): Set start and stop points
4730 according to the row's direction when priming the loop that looks
4731 for the glyph on which to display cursor.
4732 (single_display_spec_intangible_p): Function deleted.
4733 (display_prop_intangible_p): Reimplement to call
4734 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4735 Accept 3 additional arguments needed by handle_display_spec.
4736 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4737 values: lists, `(when COND...)' forms, etc.
4738 (single_display_spec_string_p): Support property values that are
4739 lists with the argument STRING its top-level element.
4740 (display_prop_string_p): Fix the condition for processing a
4741 property that is a list to be consistent with handle_display_spec.
fec2107c 4742 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4743 last portion of handle_display_prop.
4744 (compute_display_string_pos): Accept additional argument
4745 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4746 value of a `display' property is a "replacing spec".
4747 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4748 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4749 the display property, but just return a value indicating whether
4750 the display property will replace the characters it covers.
4751 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4752 frame_window_p members of struct bidi_it.
d6d100dd
SM
4753 (compute_display_string_pos, compute_display_string_end):
4754 New functions.
fec2107c
EZ
4755 (push_it): Accept second argument POSITION, where pop_it should
4756 jump to continue iteration.
4757 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4758
fec2107c
EZ
4759 * keyboard.c (adjust_point_for_property): Adjust the call to
4760 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4761
4762 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4763 (bidi_init_it): Update prototypes.
4764 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4765 (compute_display_string_pos, compute_display_string_end):
4766 Declare prototypes.
fec2107c
EZ
4767 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4768 EMACS_INT.
fc6f18ce 4769
40087514 47702011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4771
57f53182
PE
4772 Malloc failure behavior now depends on size of allocation.
4773 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4774 * lisp.h: Change signatures accordingly.
4775 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4776 All callers changed. (Bug#8762)
4777
4778 * gnutls.c: Use Emacs's memory allocators.
4779 Without this change, the gnutls library would invoke malloc etc.
4780 directly, which causes problems on non-SYNC_INPUT hosts, and which
4781 runs afoul of improving memory_full behavior. (Bug#8761)
4782 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4783 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4784 xfree instead of the default malloc, realloc, free.
4785 (Fgnutls_boot): No need to check for memory allocation failure,
4786 since xmalloc does that for us.
4787
ac32cd99 4788 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4789 * category.c (hash_get_category_set):
4790 * ccl.c (ccl_driver):
4791 * charset.c (Fdefine_charset_internal):
4792 * charset.h (struct charset.hash_index):
4793 * composite.c (get_composition_id, gstring_lookup_cache)
4794 (composition_gstring_put_cache):
4795 * composite.h (struct composition.hash_index):
4796 * dispextern.h (struct image.hash):
4797 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4798 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4799 (hashfn_equal, hashfn_user_defined, make_hash_table)
4800 (maybe_resize_hash_table, hash_lookup, hash_put)
4801 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4802 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4803 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4804 * image.c (make_image, search_image_cache, lookup_image)
4805 (xpm_put_color_table_h):
4806 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4807 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4808 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4809 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4810 * alloc.c (allocate_vectorlike):
4811 Check for overflow in vector size calculations.
4812 * ccl.c (ccl_driver):
4813 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4814 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4815 need to be updated by these changes.
40087514
PE
4816 * fns.c (make_hash_table, maybe_resize_hash_table):
4817 Check for integer overflow with large hash tables.
0de4bb68
PE
4818 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4819 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4820 (SXHASH_REDUCE): New macro.
4821 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4822 Use it instead of discarding useful hash info with large hash values.
4823 (sxhash_float): New function.
4824 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4825 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4826 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4827 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4828 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4829 Adjust signatures to match updated version of code.
4830 (consing_since_gc): Now EMACS_INT, since a single hash table can
4831 use more than INT_MAX bytes.
4832
698d32e2
DN
48332011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4834
4835 Make it possible to build with GCC-4.6+ -O2 -flto.
4836
4837 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4838
fd6fa53f
SM
48392011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4840
4841 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4842 Call minibuffer-inactive-mode.
4843
864db017
JB
48442011-05-31 Juanma Barranquero <lekktu@gmail.com>
4845
4846 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4847 Update dependencies.
4848
2ad0baf4
DN
48492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4850
4851 * data.c (init_data): Remove code for UTS, this system is not
4852 supported anymore.
4853
4fcc2638
DN
48542011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4855
4856 Don't force ./temacs to start in terminal mode.
4857
4858 * frame.c (make_initial_frame): Initialize faces in all cases, not
4859 only when CANNOT_DUMP is defined.
4860 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4861
c56e0fd5
DN
48622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4863
4864 * dispnew.c (add_window_display_history): Use const for the string
4865 pointer. Remove declaration, not needed.
4866
333d54da 48672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4868
55d4c1b2 4869 Use 'inline', not 'INLINE'.
333d54da 4870 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4871 * alloc.c, fontset.c (INLINE): Remove.
4872 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4873 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4874 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4875 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4876 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4877
738db178
DN
48782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4879
4880 Make it possible to run ./temacs.
4881
4882 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4883 syms_of_callproc does the same thing. Remove test for
4884 "initialized", do it in the caller.
4885 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4886
620c53a6
SM
48872011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4888
4889 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4890 (read_minibuf): Use get_minibuffer.
4891 (syms_of_minibuf): Use DEFSYM.
4892 (Qmetadata): New var.
4893 * data.c (Qbuffer): Don't make it static.
4894 (syms_of_data): Use DEFSYM.
4895
e003a292
PE
48962011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4897
4898 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4899 (CCL_CODE_MIN): New macro.
4900
ed008a6d
PE
49012011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4902
3687c2ef
PE
4903 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4904
ed008a6d
PE
4905 * eval.c (Qdebug): Now static.
4906 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4907 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4908 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4909
d66c4c7c
CY
49102011-05-29 Chong Yidong <cyd@stupidchicken.com>
4911
4912 * image.c: Various fixes to ImageMagick code comments.
4913 (Fimagemagick_types): Doc fix.
4914
5fbc2025
PE
49152011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4916
0196f88a
PE
4917 Minor fixes prompted by GCC 4.6.0 warnings.
4918
4919 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4920
5fbc2025
PE
4921 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4922 (x_clipboard_manager_save_all): Move extern decl to ...
4923 * xterm.h: ... here, so that it can be checked for consistency.
4924
1dd3c2d9
CY
49252011-05-29 Chong Yidong <cyd@stupidchicken.com>
4926
4927 * xselect.c (x_clipboard_manager_save_frame)
4928 (x_clipboard_manager_save_all): New functions.
4929 (Fx_clipboard_manager_save): Lisp function deleted.
4930
4931 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4932 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4933
4934 * xterm.h: Update prototype.
4935
5ba6571d
WX
49362011-05-28 William Xu <william.xwl@gmail.com>
4937
4938 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4939 exiting (Bug#8239).
4940
3eaff834
JM
49412011-05-28 Jim Meyering <meyering@redhat.com>
4942
e1900994 4943 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4944 * fns.c (to_uchar): Define.
4945 (crypto_hash_function): Use it to convert some newly-signed
4946 variables to unsigned, to avoid sign-extension bugs. For example,
4947 without this change, (md5 "truc") would evaluate to
4948 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4949 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4950 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4951
0f6990a7
PE
49522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4953
4954 Integer overflow fixes.
c8a9ca5a 4955
08686060
PE
4956 * dbusbind.c: Serial number integer overflow fixes.
4957 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4958 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4959 to hold a serial number that is too large for a fixnum.
4960 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4961 Check for serial numbers out of range. Decode any serial number
59568bf0 4962 that was so large that it became a float. (Bug#8722)
08686060 4963
2d1fc3c7
PE
4964 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4965 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4966 Use XFASTINT rather than XUINT when numbers are nonnegative.
4967 (xd_append_arg, Fdbus_method_return_internal):
4968 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4969 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4970 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4971 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4972 (Bug#8722)
2d1fc3c7 4973
c8a9ca5a
PE
4974 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4975
519e1d69
PE
4976 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4977
30569699
PE
4978 ccl: add integer overflow checks
4979 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4980 (IN_INT_RANGE): New macros.
4981 (ccl_driver): Use them to check for integer overflow when
4982 decoding a CCL program. Many of the new checks are whether XINT (x)
4983 fits in int; it doesn't always, on 64-bit hosts. The new version
4984 doesn't catch all possible integer overflows, but it's an
847044ea 4985 improvement. (Bug#8719)
30569699 4986
c11285dc
PE
4987 * alloc.c (make_event_array): Use XINT, not XUINT.
4988 There's no need for unsigned here.
4989
fdccd48e
PE
4990 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4991 This follows up to the 2011-05-06 change that substituted uintptr_t
4992 for EMACS_INT. This case wasn't caught back then.
4993
37910ab2
PE
4994 Rework Fformat to avoid integer overflow issues.
4995 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4996 now (part of C89). Include <verify.h>.
4997 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4998 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4999 (Fformat): Avoid the prepass trying to compute sizes; it was only
5000 approximate and thus did not catch overflow reliably. Instead, walk
5001 through the format just once, formatting and computing sizes as we go,
5002 checking for integer overflow at every step, and allocating a larger
5003 buffer as needed. Keep track separately whether the format is
5004 multibyte. Keep only the most-recently calculated precision, rather
5005 than them all. Record whether each argument has been converted to
5006 string. Use EMACS_INT, not int, for byte and char and arg counts.
5007 Support field widths and precisions larger than INT_MAX. Avoid
5008 sprintf's undefined behavior with conversion specifications such as %#d
5009 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5010 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5011 formatting out-of-range floating point numbers with int
9173deec 5012 formats. (Bug#8668)
37910ab2 5013
2e6578fb
PE
5014 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5015
0ae6bdee
PE
5016 * data.c: Avoid integer truncation in expressions involving floats.
5017 * data.c: Include <intprops.h>.
5018 (arith_driver): When there's an integer overflow in an expression
5019 involving floating point, convert the integers to floating point
5020 so that the resulting value does not suffer from catastrophic
5021 integer truncation. For example, on a 64-bit host (* 4
5022 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5023 Do not rely on undefined behavior after integer overflow.
5024
de883a70
PE
5025 merge count_size_as_multibyte, parse_str_to_multibyte
5026 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5027 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5028 Check for integer overflow.
5029 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5030 since it's now a duplicate of the other. This is more of
5031 a character than a buffer op, so better that it's in character.c.
5032 * fns.c, print.c: Adjust to above changes.
5033
2ff916cb
PE
50342011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5035
5036 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5037
f1b54466
PE
50382011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5039
fb1ac845
PE
5040 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5041 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5042 (x_clipboard_manager_save): Now static.
5043 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5044
f1b54466
PE
5045 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5046 (crypto_hash_function): Now static.
5047 Fix pointer signedness problems. Avoid unnecessary initializations.
5048
a9f737ee
CY
50492011-05-27 Chong Yidong <cyd@stupidchicken.com>
5050
5051 * termhooks.h (Vselection_alist): Make it terminal-local.
5052
5053 * terminal.c (create_terminal): Initialize it.
5054
5055 * xselect.c: Support for clipboard managers.
5056 (Vselection_alist): Move to termhooks.h as terminal-local var.
5057 (LOCAL_SELECTION): New macro.
5058 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5059 (symbol_to_x_atom): Remove gratuitous arg.
5060 (x_handle_selection_request, lisp_data_to_selection_data)
5061 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5062 (x_own_selection, x_get_local_selection, x_convert_selection):
5063 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5064 (some_frame_on_display): Delete unused function.
5065 (Fx_own_selection_internal, Fx_get_selection_internal)
5066 (Fx_disown_selection_internal, Fx_selection_owner_p)
5067 (Fx_selection_exists_p): New optional frame arg.
5068 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5069 (x_handle_selection_clear): Don't treat other terminals with the
5070 same keyboard specially. Use the terminal-local Vselection_alist.
5071 (x_clear_frame_selections): Use Frun_hook_with_args.
5072
5073 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5074
5075 * xterm.h: Add support for those atoms.
5076
e067f0c1
CY
50772011-05-26 Chong Yidong <cyd@stupidchicken.com>
5078
5079 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5080 (converted_selections, conversion_fail_tag): New global variables.
5081 (x_selection_request_lisp_error): Free the above.
5082 (x_get_local_selection): Remove unnecessary code.
5083 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5084 of converted selections stored in converted_selections.
5085 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5086 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5087 (x_convert_selection): New function.
5088 (x_handle_selection_event): Simplify.
5089 (x_get_foreign_selection): Don't ignore incoming requests while
5090 waiting for an answer; this will fail when we implement
5091 SAVE_TARGETS, and seems unnecessary anyway.
5092 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5093 (Vx_sent_selection_functions): Doc fix.
5094
0f4aebc0
LL
50952011-05-26 Leo Liu <sdl.web@gmail.com>
5096
5097 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5098
e61124cd
YM
50992011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5100
5101 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5102
5103 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5104 for fringe update if it has periodic bitmap.
ac389d0c 5105 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5106 and fringe_bitmap_periodic_p.
5107
5108 * fringe.c (get_fringe_bitmap_data): New function.
5109 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5110 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5111 row. Mark glyph row for fringe update if periodicity changed.
5112
5113 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5114 for fringe update unless it has periodic bitmap.
5115
f16d9837
KH
51162011-05-25 Kenichi Handa <handa@m17n.org>
5117
5118 * xdisp.c (get_next_display_element): Set correct it->face_id for
5119 a static composition.
5120
e1b90ef6
LL
51212011-05-24 Leo Liu <sdl.web@gmail.com>
5122
5123 * deps.mk (fns.o):
5124 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5125
5126 * fns.c (crypto_hash_function, Fsha1): New function.
5127 (Fmd5): Use crypto_hash_function.
5128 (syms_of_fns): Add Ssha1.
5129
7400048f
PE
51302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5131
5132 * gnutls.c: Remove unused macros.
5133 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5134 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5135 Remove macros that are defined and never used.
5136 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5137
abb71cf4
CY
51382011-05-22 Chong Yidong <cyd@stupidchicken.com>
5139
5140 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5141 (Fx_get_selection_internal): Minor cleanup.
5142 (Fx_own_selection_internal): Rename arguments for consistency with
5143 select.el.
5144
6307db39
PE
51452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5146
5147 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5148
f3d4e0a4
CY
51492011-05-22 Chong Yidong <cyd@stupidchicken.com>
5150
5151 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5152
4d8ade89
YM
51532011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5154
5155 * dispnew.c (scrolling_window): Don't exclude the case that the
5156 last enabled row in the desired matrix touches the bottom boundary.
5157
32078c8d
GM
51582011-05-21 Glenn Morris <rgm@gnu.org>
5159
5160 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5161 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5162 and add some more files.
32078c8d 5163
7285dc67
EZ
51642011-05-20 Eli Zaretskii <eliz@gnu.org>
5165
5166 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5167 report_file_error introduced by the change from 2011-05-07.
5168
89d1bd22
PE
51692011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5170
5171 * systime.h (Time): Define only if emacs is defined.
5172 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5173 where the include path doesn't have X11/X.h by default. See
5174 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5175
e23640bb 51762011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5177
5178 * composite.c (find_automatic_composition): Fix previous change.
5179
b9704ad9
GM
51802011-05-20 Glenn Morris <rgm@gnu.org>
5181
5182 * lisp.mk: New file, split from Makefile.in.
5183 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5184 (shortlisp): Remove.
5185 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5186
4a720484
GM
51872011-05-19 Glenn Morris <rgm@gnu.org>
5188
5189 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5190 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5191 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5192 (lisp): Set the order to that of loadup.el.
5193 (shortlisp): Make it a copy of $lisp.
5194 (SOME_MACHINE_LISP): Remove.
5195 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5196 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5197
a28d4396
KH
51982011-05-18 Kenichi Handa <handa@m17n.org>
5199
5200 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5201 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5202 (find_automatic_composition): Mostly rewrite for efficiency.
5203
a2b1fa8e
JB
52042011-05-18 Juanma Barranquero <lekktu@gmail.com>
5205
5206 * makefile.w32-in: Update dependencies.
5207
8e1f5610
CS
52082011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5209
5210 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5211 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5212
7025ee00 52132011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5214
cdfa6eab
PE
5215 Fix some integer overflow issues, such as string length overflow.
5216
06d6db33
PE
5217 * insdel.c (count_size_as_multibyte): Check for string overflow.
5218
2b4560a8
PE
5219 * character.c (lisp_string_width): Check for string overflow.
5220 Use EMACS_INT, not int, for string indexes and lengths; in
5221 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5222 the resulting string length overflows an EMACS_INT; instead,
5223 report a string overflow if no precision given. When checking for
5224 precision exhaustion, use a check that cannot possibly have
5225 integer overflow. (Bug#8675)
5226 * character.h (lisp_string_width): Adjust to new signature.
5227
cb93f9be
PE
5228 * alloc.c (string_overflow): New function.
5229 (Fmake_string): Use it. This doesn't change behavior, but saves
5230 a few bytes and will simplify future changes.
5231 * character.c (string_escape_byte8): Likewise.
5232 * lisp.h (string_overflow): New decl.
5233
1a1f3366
PE
5234 Fixups, following up to the user-interface timestamp change.
5235 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5236 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5237 * msdos.c (mouse_get_pos): Likewise.
5238 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5239 * w32gui.h (Time): Define by including "systime.h" rather than by
5240 declaring it ourselves. (Bug#8664)
5241
d4e3e4d3
PE
5242 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5243 * image.c (clear_image_cache): Likewise.
5244
f6a24d19
PE
5245 * term.c (term_mouse_position): Don't assume time_t wraparound.
5246
08dc5ae6
PE
5247 Be more systematic about user-interface timestamps.
5248 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5249 and sometimes 'EMACS_UINT', to represent these timestamps.
5250 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5251 This makes the code easier to follow, and makes it easier to catch
5252 integer overflow bugs such as Bug#8664.
5253 * frame.c (Fmouse_position, Fmouse_pixel_position):
5254 Use Time, not unsigned long, for user-interface timestamps.
5255 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5256 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5257 * keyboard.h (last_event_timestamp): Likewise.
5258 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5259 * menu.h (xmenu_show): Likewise.
5260 * term.c (term_mouse_position): Likewise.
5261 * termhooks.h (struct input_event.timestamp): Likewise.
5262 (struct terminal.mouse_position_hook): Likewise.
5263 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5264 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5265 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5266 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5267 what it was before.
5268 * menu.h, termhooks.h: Include "systime.h", for Time.
5269
8e55734a
PE
5270 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5271 Don't assume that the difference between two unsigned long values
5272 can fit into an integer. At this point, we know button_down_time
5273 <= event->timestamp, so the difference must be nonnegative, so
5274 there's no need to cast the result if double-click-time is
5275 nonnegative, as it should be; check that it's nonnegative, just in
5276 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5277 apart (about 25 days). (Bug#8664)
8e55734a 5278
841f1b75 5279 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5280 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5281
3e26f69c
PE
5282 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5283 that always fit in int. Use a sentinel instead of a counter, to
5284 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5285 * frame.h (struct frame): Use int for menu_bar_items_used
5286 instead of EMACS_INT, since it always fits in int.
3e26f69c 5287
5cc152c0
PE
5288 * menu.c (grow_menu_items): Check for int overflow.
5289
d89eb65e
PE
5290 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5291
5235bd3e
PE
5292 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5293 Before, the code was not consistent. These values cannot exceed
5294 2**31 - 1 so there's no need to make them unsigned.
5295 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5296 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5297 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5298 as modifiers.
5299 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5300
bc827e23
PE
5301 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5302 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5303 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5304 presumably because the widths might not match.
5305
78eb494e
PE
5306 * window.c (size_window): Avoid needless test at loop start.
5307
04f2d78b
CB
53082011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5309
5310 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5311
d2fc7e3d 53122011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5313
5314 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5315
d2fc7e3d 53162011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5317
5318 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5319 `width' to `bar_area_x' and `bar_area_width', respectively.
5320 (x_scroll_run): Take account of fringe background extension.
5321
04f2d78b
CB
5322 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5323 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5324 `bar_area_width', respectively.
5325 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5326 background extension.
5327
79b70037
GM
53282011-05-10 Jim Meyering <meyering@redhat.com>
5329
5330 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5331
2f142cc5
JB
53322011-05-10 Juanma Barranquero <lekktu@gmail.com>
5333
5334 * image.c (Finit_image_library): Return t for built-in image types,
5335 like pbm and xbm. (Bug#8640)
5336
57679c86
AS
53372011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5338
5339 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5340
888c9e86
EZ
53412011-05-07 Eli Zaretskii <eliz@gnu.org>
5342
b0512a1d
EZ
5343 * w32console.c (Fset_screen_color): Doc fix.
5344 (Fget_screen_color): New function.
5345 (syms_of_ntterm): Defsubr it.
5346
7285dc67
EZ
5347 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5348 unlink the temporary file if Fcall_process didn't create it in the
5349 first place.
5350 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5351 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5352 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5353 cue to call_process_cleanup not to close that handle.
5354
4d3fcc8e
BK
53552011-05-07 Ben Key <bkey76@gmail.com>
5356
5357 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5358 one of two shell specific rules, either bootstrap-temacs-CMD or
5359 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5360 to the previous implementation of the bootstrap-temacs rule.
5361 The bootstrap-temacs-CMD rule is similar to the previous
5362 implementation of the bootstrap-temacs rule except that it
5363 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5364 variable.
5365
5366 These changes, along with some changes to nt/configure.bat,
5367 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5368 earlier fix to add support for --cflags and --ldflags options
5369 that include quotes so that it works whether make uses cmd or
5370 sh as the shell.
5371
b4289b64
MA
53722011-05-06 Michael Albinus <michael.albinus@gmx.de>
5373
5374 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5375 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5376 is a constant.
5377 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5378 a string. Handle both cases.
5379 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5380 (Fdbus_register_method): Use Qinvalid_function.
5381
af4c0e28
JB
53822011-05-06 Juanma Barranquero <lekktu@gmail.com>
5383
5384 * makefile.w32-in: Update dependencies.
5385 (LISP_H): Add inttypes.h and stdin.h.
5386 (PROCESS_H): Add unistd.h.
5387
c51453d9
EZ
53882011-05-06 Eli Zaretskii <eliz@gnu.org>
5389
5390 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5391 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5392
8ff0ac3c 53932011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5394
4c4b566b
PE
5395 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5396
aab2b9b5
PE
5397 * term.c (vfatal): Remove stray call to va_end.
5398 It's not needed and the C Standard doesn't allow it here anyway.
5399
c378da0b
PE
5400 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5401 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5402
288b08c7
PE
5403 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5404 bytes.
5405
e3601888
PE
5406 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5407
db6c0e74
PE
5408 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5409
dd5963ea
PE
5410 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5411
88c9450f
PE
5412 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5413
2f9442b8
PE
5414 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5415
c032b5f8
PE
5416 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5417 * charset.c (Fdefine_charset_internal): Don't initialize
5418 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5419 32-bit int (Bug#8600).
a108c10b
PE
5420
5421 * lread.c (read_integer): Be more consistent with string-to-number.
5422 Use string_to_number to do the actual conversion; this avoids
5423 rounding errors and fixes some other screwups. Without this fix,
5424 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5425 (digit_to_number): Move earlier, for benefit of read_integer.
5426 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5427 not a digit in any supported base. (Bug#8602)
a108c10b 5428
ad5f9eea
PE
5429 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5430
aec1708a
PE
5431 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5432 to match comment at start of function. This also removes a
5433 GCC warning about overflow in a 32+64-bit port.
5434
47be4ab5
PE
5435 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5436
371cac43
PE
5437 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5438 Reported by Stefan Monnier in
5439 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5440 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5441 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5442
d01a7826
PE
5443 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5444 (EMACS_UINTPTR): Likewise, with uintptr_t.
5445
7fd47d5c
PE
5446 * lisp.h: Prefer 64-bit EMACS_INT if available.
5447 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5448 on 32-bit hosts that have 64-bit int, so that they can access
5449 large files.
122b0c86
PE
5450 However, temporarily disable this change unless the temporary
5451 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5452
8727937b
PE
5453 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5454
8ac068ac
PE
5455 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5456 This removes an assumption that EMACS_INT and long are the same
5457 width as pointers. The assumption is true for Emacs porting targets
5458 now, but we want to make other targets possible.
5459 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5460 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5461 In the rest of the code, change types of integers that hold casted
5462 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5463 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5464 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5465 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5466 No need to cast type when ORing.
5467 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5468 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5469 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5470 assume EMACS_INT is the same width as char *.
5471 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5472 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5473 Remove no-longer-needed casts.
5474 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5475 (xg_tool_bar_help_callback, xg_make_tool_item):
5476 Use EMACS_INTPTR to hold an integer
5477 that will be cast to void *; this can avoid a GCC warning
5478 if EMACS_INT is not the same width as void *.
5479 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5480 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5481 (current_message_1, set_message_1):
5482 Use a local to convert to proper width without a cast.
5483 * xmenu.c (dialog_selection_callback): Likewise.
5484
ede49d71
PE
5485 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5486 Also, don't assume VALBITS / RAND_BITS is less than 5,
5487 and don't rely on undefined behavior when shifting a 1 left into
5488 the sign bit.
5489 * lisp.h (get_random): Change signature to match.
5490
2f30ecd0
PE
5491 * lread.c (hash_string): Use size_t, not int, for hash computation.
5492 Normally we prefer signed values; but hashing is special, because
5493 it's better to use unsigned division on hash table sizes so that
5494 the remainder is nonnegative. Also, size_t is the natural width
5495 for hashing into memory. The previous code used 'int', which doesn't
5496 retain enough info to hash well into very large tables.
5497 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5498
2a866e7b
PE
5499 * dbusbind.c: Don't possibly lose pointer info when converting.
5500 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5501 Use XPNTR rather than XHASH, so that the high-order bits of
5502 the pointer aren't lost when converting through void *.
5503
51639eac
PE
5504 * eval.c (Fautoload): Don't double-shift a pointer.
5505
92394119
PE
5506 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5507
dbdb9a7c
JB
55082011-05-06 Juanma Barranquero <lekktu@gmail.com>
5509
5510 * gnutls.c (DEF_GNUTLS_FN):
5511 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5512
db7a0b4f
AS
55132011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5514
5515 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5516 marker. (Bug#8610)
5517
f7ff1b0f 55182011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5519
5520 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5521 New version that can reserve upto 2GB of heap space.
5522
f7ff1b0f 55232011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5524
5525 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5526
639c109b
TZ
55272011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5528
5529 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5530 `gnutls_certificate_set_x509_key_file'.
5531
d2127135
JB
55322011-05-05 Juanma Barranquero <lekktu@gmail.com>
5533
5534 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5535 Update dependencies.
5536
e968f4f3
JB
55372011-05-04 Juanma Barranquero <lekktu@gmail.com>
5538
5539 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5540 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5541 Remove unused parameter `fildes'.
5542 * process.c (read_process_output, send_process): Don't pass it.
5543
84d358f0
JB
55442011-05-04 Juanma Barranquero <lekktu@gmail.com>
5545
5546 Fix previous change: the library cache is defined in w32.c.
5547 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5548 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5549
0898ca10
JB
55502011-05-04 Juanma Barranquero <lekktu@gmail.com>
5551
5552 Implement dynamic loading of GnuTLS on Windows.
5553
5554 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5555 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5556 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5557 Declare.
5558
5559 * gnutls.c (Qgnutls_dll): Define.
5560 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5561 (gnutls_*): Declare function pointers.
5562 (init_gnutls_functions): New function to initialize function pointers.
5563 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5564 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5565 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5566 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5567 (emacs_gnutls_write, emacs_gnutls_read)
5568 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5569 (Fgnutls_available_p): New function.
5570 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5571 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5572 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5573
5574 * image.c: Include w32.h.
5575 (Vimage_type_cache): Delete.
5576 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5577 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5578 (w32_delayed_load): Move to w32.c.
5579
5580 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5581
5582 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5583 (w32_delayed_load): Move from image.c. When loading a library, record
5584 its filename in the :loaded-from property of the library id.
5585 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5586 Initialize and staticpro them.
5587 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5588
5589 * process.c: Include lisp.h before w32.h, not after.
5590 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5591 instead of gnutls_record_check_pending.
5592
5593 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5594
ff4de4aa
TZ
55952011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5596
5597 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5598 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5599 as passed in.
5600
abe95abb
JD
56012011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5602
5603 * xterm.c (x_set_frame_alpha): Do not set property on anything
5604 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5605
e16e55d4
JB
56062011-05-02 Juanma Barranquero <lekktu@gmail.com>
5607
5608 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5609
bafcf6a5
JB
56102011-05-02 Juanma Barranquero <lekktu@gmail.com>
5611
5612 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5613 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5614 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5615 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5616 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5617 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5618 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5619 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5620 (Qgnutls_bootprop_callbacks_verify): Make static.
5621
e7a6747f
AS
56222011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5623
19ed11ba
AS
5624 * callproc.c: Indentation fixup.
5625
e7a6747f 5626 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5627 (wait_for_termination, interruptible_wait_for_termination):
5628 Move after wait_for_termination_1.
e7a6747f 5629
1ef14cb4
LMI
56302011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5631
5632 * sysdep.c (interruptible_wait_for_termination): New function
5633 which is like wait_for_termination, but allows keyboard
5634 interruptions.
5635
5636 * callproc.c (Fcall_process): Add (:file "file") as an option for
5637 the STDOUT buffer.
5638 (Fcall_process_region): Ditto.
5639
330d880c
EZ
56402011-04-30 Eli Zaretskii <eliz@gnu.org>
5641
8db90b73
EZ
5642 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5643 rather than `XVECTOR (FOO)->size'.
5644
330d880c
EZ
5645 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5646 inttypes.h, as a gnulib replacement is used if it not available in
5647 system headers.
5648
15cbd324
EZ
56492011-04-21 Eli Zaretskii <eliz@gnu.org>
5650
5651 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5652 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5653 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5654
5655 * coding.c (coding_alloc_by_realloc): Error out if destination
5656 will grow beyond MOST_POSITIVE_FIXNUM.
5657 (decode_coding_emacs_mule): Abort if there isn't enough place in
5658 charbuf for the composition carryover bytes. Reserve an extra
5659 space for up to 2 characters produced in a loop.
5660 (decode_coding_iso_2022): Abort if there isn't enough place in
5661 charbuf for the composition carryover bytes.
5662
56632011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5664
ae940cca
EZ
5665 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5666 aborting when %lld or %lll format is passed.
5667 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5668 %llo or %llx format is passed. (Bug#8545)
5669
03ab8921
EZ
5670 * window.c (window_scroll_line_based): Use a marker instead of
5671 simple variables to record original value of point. (Bug#7952)
5672
afda1437
EZ
5673 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5674 produced by %s or %c overflows available buffer space. (Bug#8545)
5675
f76dee0c
PE
56762011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5677
5678 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5679 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5680
fdc5744d
JB
56812011-04-28 Juanma Barranquero <lekktu@gmail.com>
5682
5683 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5684
638f053a
JB
56852011-04-28 Juanma Barranquero <lekktu@gmail.com>
5686
5687 * keyboard.c (Qdelayed_warnings_hook): Define.
5688 (command_loop_1): Run `delayed-warnings-hook'
5689 if Vdelayed_warnings_list is non-nil.
5690 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5691 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5692
d178f871
EZ
56932011-04-28 Eli Zaretskii <eliz@gnu.org>
5694
5695 * doprnt.c (doprnt): Don't return value smaller than the buffer
5696 size if the message was truncated. (Bug#8545).
5697
b124fd93
JB
56982011-04-28 Juanma Barranquero <lekktu@gmail.com>
5699
5700 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5701 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5702
e810457d
PE
57032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5704
5705 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5706
ea51cceb
JB
57072011-04-27 Juanma Barranquero <lekktu@gmail.com>
5708
5709 * makefile.w32-in: Update dependencies.
5710
94dcfacf
EZ
57112011-04-27 Eli Zaretskii <eliz@gnu.org>
5712
5713 Improve `doprnt' and its usage. (Bug#8545)
5714 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5715 `format_end'. Remove support for %l as a conversion specifier.
5716 Don't use xrealloc. Improve diagnostics when the %l size modifier
5717 is used. Update the commentary.
5718
5719 * eval.c (verror): Simplify calculation of size_t.
5720
5721 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5722 messages.
5723
f61f41d7
PE
57242011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5725
5726 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5727 change.
5728
96fb4434
PE
57292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5730
5731 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5732 This makes this file independent of the recent pseudovector change.
5733
671875da 57342011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5735
69e9b5a3
PE
5736 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5737
b5f869a7 5738 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5739 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5740 Remove unused local.
c8926152 5741 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5742
841a1577 5743 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5744 GCC 4.6.0 optimizes based on type-based alias analysis.
5745 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5746 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5747 != &v->size, and therefore "v->size = 1; b->size = 2; return
5748 v->size;" must therefore return 1. This assumption is incorrect
5749 for Emacs, since it type-puns struct Lisp_Vector * with many other
5750 types. To fix this problem, this patch adds a new type struct
f904488f 5751 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5752 and pseudovectors, and helps optimizing compilers not get fooled
5753 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5754 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5755 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5756 the size member.
eab3844f
PE
5757 (XSETPVECTYPE): Rewrite in terms of new macro.
5758 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5759 This is a bit clearer, and further avoids the possibility of
5760 undesirable aliasing.
5761 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5762 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5763 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5764 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5765 (ASIZE): Now uses header.size rather than size.
5766 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5767 to avoid the hassle of writing XVECTOR (foo)->header.size.
5768 (struct vectorlike_header): New type.
eab3844f
PE
5769 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5770 object, to help avoid aliasing.
5771 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5772 (SUBRP): Likewise, since Lisp_Subr is a special case.
5773 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5774 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5775 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5776 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5777 changed to be "header.size" and "header.next".
5778 * buffer.h (struct buffer): Likewise.
5779 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5780 * frame.h (struct frame): Likewise.
5781 * process.h (struct Lisp_Process): Likewise.
5782 * termhooks.h (struct terminal): Likewise.
5783 * window.c (struct save_window_data, struct saved_window): Likewise.
5784 * window.h (struct window): Likewise.
5785 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5786 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5787 * buffer.c (init_buffer_once): Likewise.
5788 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5789 special case.
5790 * process.c (Fformat_network_address): Use local var for size,
5791 for brevity.
5792
0df1eac5
PE
5793 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5794
847ab9d1 5795 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5796 * data.c (atof): Remove decl; no longer used or needed.
5797 (digit_to_number): Move to lread.c.
5798 (Fstring_to_number): Use new string_to_number function, to be
5799 consistent with how the Lisp reader treats infinities and NaNs.
5800 Do not assume that floating-point numbers represent EMACS_INT
5801 without losing information; this is not true on most 64-bit hosts.
5802 Avoid double-rounding errors, by insisting on integers when
5803 parsing non-base-10 numbers, as the documentation specifies.
5804 * lisp.h (string_to_number): New decl, replacing ...
5805 (isfloat_string): Remove.
bc0a5c13 5806 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5807 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5808 appears to have been a coding error. Similarly, do not accept
5809 strings like +-1e0 as floating point numbers. Do not report
5810 overflow for integer overflows unless the base is not 10 which
5811 means we have no simple and reliable way to continue.
5812 Break out the floating-point parsing into a new
5813 function string_to_number, so that Fstring_to_number parses
5814 floating point numbers consistently with the Lisp reader.
04f2d78b 5815 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5816 (E_CHAR, EXP_INT): Remove, replacing with ...
5817 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5818 (string_to_number): New function, replacing isfloat_string.
5819 This function checks for valid syntax and produces the resulting
5820 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5821 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5822 so that overflow for non-base-10 numbers is reported only when
5823 there's no portable and simple way to convert to floating point.
452f4150 5824
67769ffc
PE
5825 * textprop.c (set_text_properties_1): Rewrite for clarity,
5826 and to avoid GCC warning about integer overflow.
5827
c20db43f
PE
5828 * intervals.h (struct interval): Use EMACS_INT for members
5829 where EMACS_UINT might cause problems. See
5830 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5831 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5832 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5833 All uses changed.
37aa2f85
PE
5834 (offset_intervals): Tell GCC not to worry about length overflow
5835 when negating a negative length.
c20db43f 5836
2538aa2f
PE
5837 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5838 (overrun_check_free): Likewise.
5839
f2d3008d
PE
5840 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5841 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5842 word size.
5843
ec8df744
PE
5844 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5845 (gnutls_make_error): Rename local to avoid shadowing.
5846 (gnutls_emacs_global_deinit): ifdef out; not used.
5847 (Fgnutls_boot): Use const for pointer to readonly storage.
5848 Comment out unused local. Fix pointer signedness problems.
5849
640ee02d
PE
5850 * lread.c (openp): Don't stuff size_t into an 'int'.
5851 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5852 about possible signed overflow.
5853
6048fb2a
PE
5854 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5855 (GDK_KEY_g): Don't define if already defined.
5856 (xg_prepare_tooltip): Avoid pointer signedness problem.
5857 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5858
fa3c87e1
PE
5859 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5860 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5861
2172544b
PE
5862 * xfns.c (Fx_window_property): Simplify a bit,
5863 to make a bit faster and to avoid GCC 4.6.0 warning.
5864 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5865
9b821a21
PE
5866 * fns.c (internal_equal): Don't assume size_t fits in int.
5867
3c616cfa
PE
5868 * alloc.c (compact_small_strings): Tighten assertion a little.
5869
c2982e87
PE
5870 Replace pEd with more-general pI, and fix some printf arg casts.
5871 * lisp.h (pI): New macro, generalizing old pEd macro to other
5872 conversion specifiers. For example, use "...%"pI"d..." rather
5873 than "...%"pEd"...".
5874 (pEd): Remove. All uses replaced with similar uses of pI.
5875 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5876 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5877 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5878 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5879 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5880 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5881 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5882 64-bit hosts.
5883 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5884 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5885 * print.c (safe_debug_print, print_object): Likewise.
5886 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5887 to int.
6f04d126
PE
5888 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5889 avoiding the 0 flag, which is not portable.
c2982e87
PE
5890 * process.c (Fmake_network_process): Use pI to avoid cast.
5891 * region-cache.c (pp_cache): Likewise.
5892 * xdisp.c (decode_mode_spec): Likewise.
5893 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5894 behavior on 64-bit hosts with printf arg.
6f04d126 5895 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5896 (x_stop_queuing_selection_requests): Likewise.
5897 (x_get_window_property): Don't truncate byte count to an 'int'
5898 when tracing.
0b432f21 5899
5e073ec7
PE
5900 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5901 here, since it parses constructs like leading '-' and spaces,
5902 which are not wanted; and it overflows with large numbers.
5903 Instead, simply match F[0-9]+, which is what is wanted anyway.
5904
36372bf9
PE
5905 * alloc.c: Remove unportable assumptions about struct layout.
5906 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5907 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5908 (allocate_vectorlike, make_pure_vector): Use the new macros,
5909 plus offsetof, to remove unportable assumptions about struct layout.
5910 These assumptions hold on all porting targets that I know of, but
5911 they are not guaranteed, they're easy to remove, and removing them
5912 makes further changes easier.
5913
0b432f21
PE
5914 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5915 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5916 (string_overrun_cookie): Now const. Use initializers that
5917 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5918 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5919 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5920 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5921 multiple of sizeof (EMACS_INT); it need not be, if
5922 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5923 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5924
895009e1
JB
59252011-04-26 Juanma Barranquero <lekktu@gmail.com>
5926
5927 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5928
6a7a1b0b
TZ
59292011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5930
5931 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5932 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5933 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5934
841a1577 59352011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5936
5937 * lisp.h (Qdebug): List symbol.
895009e1 5938 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5939 * keyboard.c (debug-on-event): New variable.
5940 (handle_user_signal): Break into debugger when debug-on-event
5941 matches the current signal symbol.
5942
f2d3ba6f
DN
59432011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5944
5945 * alloc.c (check_sblock, check_string_bytes)
5946 (check_string_free_list): Convert to standard C.
5947
42ce4c63
TZ
59482011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5949
5950 * w32.c (emacs_gnutls_push): Fix typo.
5951
825cd63c
EZ
59522011-04-25 Eli Zaretskii <eliz@gnu.org>
5953
fb11d64d
EZ
5954 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5955 "cast to pointer from integer of different size".
5956
825cd63c
EZ
5957 Improve doprnt and its use in verror. (Bug#8545)
5958 * doprnt.c (doprnt): Document the set of format control sequences
5959 supported by the function. Use SAFE_ALLOCA instead of always
5960 using `alloca'.
5961
5962 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5963 is one byte too soon. Don't use xrealloc; instead xfree and
5964 xmalloc anew.
5965
e061a11b
TZ
59662011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5967
5968 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5969 callbacks stage.
5970
5971 * gnutls.c: Renamed global_initialized to
5972 gnutls_global_initialized. Added internals for the
5973 :verify-hostname-error, :verify-error, and :verify-flags
5974 parameters of `gnutls-boot' and documented those parameters in the
5975 docstring. Start callback support.
9173deec
JB
5976 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5977 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5978 on error. Return error code.
e061a11b
TZ
5979 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5980 (emacs_gnutls_read): Likewise.
5981 (Fgnutls_boot): Return handshake error code.
5982 (emacs_gnutls_handle_error): New function.
5983 (wsaerror_to_errno): Likewise.
5984
5985 * w32.h (emacs_gnutls_pull): Add prototype.
5986 (emacs_gnutls_push): Likewise.
5987
5988 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5989 (emacs_gnutls_push): Likewise.
5990
59912011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5992
5993 * process.c (wait_reading_process_output): Check if GnuTLS
5994 buffered some data internally if no FDs are set for TLS
5995 connections.
5996
5997 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5998 (LIBS): Link to USER_LIBS.
5999 ($(BLD)/gnutls.$(0)): New target.
6000
fa6996bc
EZ
60012011-04-24 Eli Zaretskii <eliz@gnu.org>
6002
eb35682e
EZ
6003 * xdisp.c (handle_single_display_spec): Rename the
6004 display_replaced_before_p argument into display_replaced_p, to
6005 make it consistent with the commentary. Fix typos in the
6006 commentary.
6007
e2ad650c
EZ
6008 * textprop.c (syms_of_textprop): Remove dead code.
6009 (copy_text_properties): Delete obsolete commentary about an
6010 interface that was deleted long ago. Fix typos in the description
6011 of arguments.
6012
1b2de274
EZ
6013 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6014 to changes in oldXMenu/XMenu.h from 2011-04-16.
6015 <menu_help_message, prev_menu_help_message>: Constify.
6016 (IT_menu_make_room): menu->help_text is now `const char **';
6017 adjust.
6018
6019 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6020 to changes in oldXMenu/XMenu.h from 2011-04-16.
6021 (struct XMenu): Declare `help_text' `const char **'.
6022
6023 * xfaces.c <Qunspecified>: Make extern again.
6024
6025 * syntax.c: Include sys/types.h before including regex.h, as
6026 required by Posix.
6027
762b15be
EZ
6028 * doc.c (get_doc_string): Improve the format passed to `error'.
6029
6030 * doprnt.c (doprnt): Improve commentary.
6031
6032 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6033
6034 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6035 them with etags.
6036
f1052e5d
EZ
6037 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6038 changes in globals.h immediately force recompilation.
762b15be
EZ
6039 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6040 $(CURDIR)/s/ms-w32.h.
6041 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6042
fa6996bc
EZ
6043 * character.c (Fchar_direction): Function deleted.
6044 (syms_of_character): Don't defsubr it.
6045 <char-direction-table>: Deleted.
6046
e6c3da20
EZ
60472011-04-23 Eli Zaretskii <eliz@gnu.org>
6048
6049 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6050 * doprnt.c: Include limits.h.
6051 (SIZE_MAX): New macro.
04f2d78b
CB
6052 (doprnt): Return a size_t value. 2nd arg is now size_t.
6053 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6054 Improve overflow protection. Support `l' modifier for integer
6055 conversions. Support %l conversion. Don't assume an EMACS_INT
6056 argument for integer conversions and for %c.
6057
6058 * lisp.h (doprnt): Restore prototype.
6059
6060 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6061 $(SRC)/character.h.
6062
6063 * Makefile.in (base_obj): Add back doprnt.o.
6064
6065 * deps.mk (doprnt.o): Add back prerequisites.
6066 (callint.o): Depend on character.h.
6067
6068 * eval.c (internal_lisp_condition_case): Include the handler
6069 representation in the error message.
6070 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6071 when breaking from the loop.
6072
6073 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6074
6075 * callint.c (Fcall_interactively): When displaying error message
6076 about invalid control letter, pass the character's codepoint, not
6077 a pointer to its multibyte form. Improve display of the character
6078 in octal and display also its hex code.
6079
6080 * character.c (char_string): Use %x to display the (unsigned)
6081 codepoint of an invalid character, to avoid displaying a bogus
6082 negative value.
6083
6084 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6085 `error', not SYMBOL_NAME itself.
6086
6087 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6088 character arguments to `error'.
6089
6090 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6091 to `error' in error message about FINAL_CHAR argument. Make sure
6092 FINAL_CHAR is a character, and use %c when it is passed as
6093 argument to `error'.
6094
4ffd0d6b 60952011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6096
6097 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6098
6099 * w32.c: Include <time.h>.
6100 (sys_localtime): New function.
6101
4ffd0d6b 61022011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6103
6104 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6105
4ffd0d6b 6106 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6107
4ffd0d6b 61082011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6109
4ffd0d6b
GM
6110 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6111 zombies (Bug#8467).
aac0c6e3 6112
04c56954
EZ
61132011-04-19 Eli Zaretskii <eliz@gnu.org>
6114
6115 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6116 gl_state.e_property when gl_state.object is Qt.
6117
6118 * insdel.c (make_gap_larger): Remove limitation of buffer size
6119 to <= INT_MAX.
6120
16a43933
CY
61212011-04-18 Chong Yidong <cyd@stupidchicken.com>
6122
6123 * xdisp.c (lookup_glyphless_char_display)
6124 (produce_glyphless_glyph): Handle cons cell entry in
6125 glyphless-char-display.
6126 (Vglyphless_char_display): Document it.
6127
6128 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6129 glyphless-char-display.
6130
4581706e
CY
61312011-04-17 Chong Yidong <cyd@stupidchicken.com>
6132
6133 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6134
6135 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6136
6137 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6138 definition for no-X builds.
6139
4887c6e2 61402011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6141
fd35b6f9
PE
6142 Static checks with GCC 4.6.0 and non-default toolkits.
6143
5c1ccb01
PE
6144 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6145
006c5daa
PE
6146 * process.c (keyboard_bit_set): Define only if SIGIO.
6147 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6148 (send_process): Repair possible setjmp clobbering.
6149
efc736d3
PE
6150 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6151
4e2fe2e6
PE
6152 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6153
f97334a2
PE
6154 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6155
4e75f29d
PE
6156 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6157 Define only if needed.
6158
90efadd1
PE
6159 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6160 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6161 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6162
3c647824
PE
6163 * dispextern.h (struct redisplay_interface): Rename param
6164 to avoid shadowing.
e264f262 6165 * termhooks.h (struct terminal): Likewise.
761383f4 6166 * xterm.c (xembed_send_message): Likewise.
3c647824 6167
b58c5c4a
PE
6168 * insdel.c (make_gap_smaller): Define only if
6169 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6170
cad59032
PE
6171 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6172 it.
6173
c339dc2e
PE
6174 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6175 so that we aren't warned about unused symbols.
6176
91a3e27b
PE
6177 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6178
399c71d3 6179 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6180
8ffc96f5
PE
6181 * xfns.c (x_real_positions): Mark locals as initialized.
6182
eef9bc79
PE
6183 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6184
098db9dd
PE
6185 * xterm.c: Fix problems found by static analysis with other toolkits.
6186 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6187 (x_dispatch_event): Declare static if USE_GTK, and
6188 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6189 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6190 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6191 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6192 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6193
eb18f6cc
PE
6194 * xmenu.c (menu_help_callback): Pointer type fixes.
6195 Use const pointers when pointing at readonly data. Avoid pointer
6196 signedness clashes.
6197 (FALSE): Remove unused macro.
6198 (update_frame_menubar): Remove unused decl.
6199
1fe72bf8
PE
6200 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6201
60d9e1db
PE
6202 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6203 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6204 (single_menu_item): Rename local to avoid shadowing.
6205
39261c26
PE
6206 * keyboard.c (make_lispy_event): Remove unused local var.
6207
018c5e19
PE
6208 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6209 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6210
63d2b86e
PE
6211 * bitmaps: Change bitmaps from unsigned char back to the X11
6212 compatible char. Avoid the old compiler warnings about
6213 out-of-range initializers by using, for example, '\xab' rather
6214 than 0xab.
6215
aefd87e1
PE
6216 * xgselect.c (xgselect_initialize): Check vs interface
6217 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6218
bf501fb9
PE
6219 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6220
e9829fdf
PE
6221 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6222 to read-only memory.
6223
1086c095
PE
6224 * fns.c (vector): Remove; this old hack is no longer needed.
6225
2baccd04 6226 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6227 Remove unused var.
dde42981 6228 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6229
72391843 6230 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6231
436c16df 6232 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6233 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6234 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6235
92bb796d 6236 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6237 (x_term_init): Remove local to avoid shadowing.
92bb796d 6238
764430a3 6239 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6240
6241 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6242 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6243
d1dfb56c
EZ
62442011-04-16 Eli Zaretskii <eliz@gnu.org>
6245
c4354cb4
EZ
6246 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6247
d1dfb56c
EZ
6248 Fix regex.c, syntax.c and friends for buffers > 2GB.
6249 * syntax.h (struct gl_state_s): Declare character position members
6250 EMACS_INT.
6251
6252 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6253
04f2d78b
CB
6254 * textprop.c (verify_interval_modification, interval_of):
6255 Declare arguments EMACS_INT.
d1dfb56c
EZ
6256
6257 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6258 EMACS_INT.
6259
6260 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6261
6262 * indent.c (Fvertical_motion): Local variable it_start is now
6263 EMACS_INT.
6264
6265 * regex.c (re_match, re_match_2, re_match_2_internal)
6266 (bcmp_translate, regcomp, regexec, print_double_string)
6267 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6268 (re_compile_pattern, re_exec): Declare arguments and local
6269 variables `size_t' and `ssize_t' and return values `regoff_t', as
6270 appropriate.
6271 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6272 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6273 <compile_stack_type>: `size' and `avail' are now `size_t'.
6274
6275 * regex.h <regoff_t>: Use ssize_t, not int.
6276 (re_search, re_search_2, re_match, re_match_2): Arguments that
6277 specify buffer/string position and length are now ssize_t and
6278 size_t. Return type is regoff_t.
6279
613052cd
BK
62802011-04-16 Ben Key <bkey76@gmail.com>
6281
6282 * nsfont.m: Fixed bugs in ns_get_family and
6283 ns_descriptor_to_entity that were caused by using free to
6284 deallocate memory blocks that were allocated by xmalloc (via
6285 xstrdup). This caused Emacs to crash when compiled with
6286 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6287 --enable-checking=xmallocoverrun). xfree is now used to
6288 deallocate these memory blocks.
6289
4170f62f 62902011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6291
71b41406
PE
6292 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6293
9587a89d
PE
6294 emacs_write: Accept and return EMACS_INT for sizes.
6295 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6296 et seq.
6297 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6298 Accept and return EMACS_INT.
6299 (emacs_gnutls_write): Return the number of bytes written on
6300 partial writes.
6301 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6302 (emacs_read, emacs_write): Remove check for negative size, as the
6303 Emacs source code has been audited now.
9587a89d
PE
6304 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6305 (emacs_read, emacs_write): Use it.
273a5f82
PE
6306 * process.c (send_process): Adjust to the new signatures of
6307 emacs_write and emacs_gnutls_write. Do not attempt to store
6308 a byte offset into an 'int'; it might overflow.
9587a89d 6309 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6310
3e047f51
PE
6311 * sound.c: Don't assume sizes fit in 'int'.
6312 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6313 Return EMACS_INT, not int.
3e047f51 6314 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6315 Accept EMACS_INT, not int.
6316 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6317 record read return values.
6318
cc39a9db
BK
63192011-04-15 Ben Key <bkey76@gmail.com>
6320
c9d0ec6d
JB
6321 * keyboard.c (Qundefined): Don't declare static since it is used
6322 in nsfns.m.
6323 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6324 static since they are used in nsfont.m.
cc39a9db 6325
6c60eb9f
SM
63262011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6327
6328 * process.c (Qprocessp): Don't declare static.
6329 * lisp.h (Qprocessp): Declare again.
6330
7990b61a
JB
63312011-04-15 Juanma Barranquero <lekktu@gmail.com>
6332
6333 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6334
5d4cb038
PE
63352011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6336
8bd7b830 6337 Improve C-level modularity by making more things 'static'.
cd64ea1d 6338
e3b27b31
PE
6339 Don't publish debugger-only interfaces to other modules.
6340 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6341 (verify_bytepos, count_markers): Move decls to the only modules
6342 that need them.
6343 * region-cache.h (pp_cache): Likewise.
6344 * window.h (check_all_windows): Likewise.
6345 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6346
5d4cb038
PE
6347 * sysdep.c (croak): Now static, if
6348 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6349 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6350
6351 * alloc.c (refill_memory_reserve): Now static if
6352 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6353 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6354
e87b6180
PE
6355 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6356 Define only if USE_LUCID.
6357
ac64929e
PE
6358 * xrdb.c (x_customization_string, x_rm_string): Now static.
6359
6f37259d
PE
6360 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6361 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6362
1683e3ab
PE
6363 * xdisp.c (draw_row_with_mouse_face): Now static.
6364 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6365
de9c2632
PE
6366 * window.h (check_all_windows): Mark externally visible.
6367
2b96acb7
PE
6368 * window.c (window_deletion_count): Now static.
6369
6370 * undo.c: Make symbols static if they're not exported.
6371 (last_undo_buffer, last_boundary_position, pending_boundary):
6372 Now static.
6373
50436f33
PE
6374 * textprop.c (interval_insert_behind_hooks): Now static.
6375 (interval_insert_in_front_hooks): Likewise.
6376
64520e5c
PE
6377 * term.c: Make symbols static if they're not exported.
6378 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6379 (max_frame_lines, tty_set_terminal_modes):
6380 (tty_reset_terminal_modes, tty_turn_off_highlight):
6381 (get_tty_terminal): Now static.
6382 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6383 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6384 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6385 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6386 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6387
1fa53021
PE
6388 * sysdep.c: Make symbols static if they're not exported.
6389 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6390 Now static.
6391 (sigprocmask_set, full_mask): Remove; unused.
6392 (wait_debugging): Mark as visible.
6393 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6394 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6395
d4b43b22
PE
6396 * syntax.c (syntax_temp): Define only if !__GNUC__.
6397
b7c513d0
PE
6398 * sound.c (current_sound_device, current_sound): Now static.
6399
989b29ad
PE
6400 * search.c (searchbufs, searchbuf_head): Now static.
6401
13a55a78
PE
6402 * scroll.c (scroll_cost): Remove; unused.
6403 * dispextern.h (scroll_cost): Remove decl.
6404
de68a1fc
PE
6405 * region-cache.h (pp_cache): Mark as externally visible.
6406
40ccffa6
PE
6407 * process.c: Make symbols static if they're not exported.
6408 (process_tick, update_tick, create_process, chan_process):
6409 (Vprocess_alist, proc_buffered_char, datagram_access):
6410 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6411 (deactivate_process): Mark defn as static, as well as decl.
6412 * lisp.h (create_process): Remove decl.
6413 * process.h (chan_process, Vprocess_alist): Remove decls.
6414
ad64fc97
PE
6415 * print.c: Make symbols static if they're not exported.
6416 (print_depth, new_backquote_output, being_printed, print_buffer):
6417 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6418 (print_interval, print_number_index, initial_stderr_stream):
6419 Now static.
6420 * lisp.h (Fprinc): Remove decl.
6421 (debug_output_compilation_hack): Mark as externally visible.
6422
adddb265
PE
6423 * sysdep.c (croak): Move decl from here to syssignal.h.
6424 * syssignal.h (croak): Put it here, so the API can be checked when
6425 'croak' is called from dissociate_if_controlling_tty.
6426
1717ede2
PE
6427 * minibuf.c: Make symbols static if they're not exported.
6428 (minibuf_save_list, choose_minibuf_frame): Now static.
6429 * lisp.h (choose_minibuf_frame): Remove decl.
6430
fa5fb2bc
PE
6431 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6432
1e3890d1
PE
6433 * lread.c: Make symbols static if they're not exported.
6434 (read_objects, initial_obarray, oblookup_last_bucket_number):
6435 Now static.
6436 (make_symbol): Remove; unused.
6437 * lisp.h (initial_obarray, make_symbol): Remove decls.
6438
8a1414fa
PE
6439 * keyboard.c: Make symbols static if they're not exported.
6440 (single_kboard, recent_keys_index, total_keys, recent_keys):
6441 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6442 (this_single_command_key_start, echoing, last_auto_save):
6443 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6444 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6445 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6446 (Vlispy_mouse_stem, double_click_count):
6447 Now static.
6448 (force_auto_save_soon): Define only if SIGDANGER.
6449 (ignore_mouse_drag_p): Now static if
6450 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6451 (print_help): Remove; unused.
6452 (stop_character, last_timer_event): Mark as externally visible.
6453 * keyboard.h (ignore_mouse_drag_p): Declare only if
6454 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6455 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6456 * lisp.h (echoing): Remove decl.
6457 (force_auto_save_soon): Declare only if SIGDANGER.
6458 * xdisp.c (redisplay_window): Simplify code, to make it more
6459 obvious that ignore_mouse_drag_p is not accessed if !defined
6460 USE_GTK && !defined HAVE_NS.
6461
93ea6e8f
PE
6462 * intervals.c: Make symbols static if they're not exported.
6463 (merge_properties_sticky, merge_interval_right, delete_interval):
6464 Now static.
6465 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6466
77382fcc
PE
6467 * insdel.c: Make symbols static if they're not exported.
6468 However, leave prepare_to_modify_buffer alone. It's never
6469 called from outside this function, but that appears to be a bug.
6470 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6471 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6472 (adjust_after_replace_noundo): Remove; unused.
6473 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6474 (signal_before_change): Remove decls.
77382fcc 6475
9306c32e
PE
6476 * indent.c (val_compute_motion, val_vmotion): Now static.
6477
cd44d2eb
PE
6478 * image.c: Make symbols static if they're not exported.
6479 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6480 if USE_GTK.
6481 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6482 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6483
ad9a7a06
PE
6484 * fringe.c (standard_bitmaps): Now static.
6485 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6486
81626931
PE
6487 * frame.c: Make symbols static if they're not exported.
6488 (x_report_frame_params, make_terminal_frame): Now static.
6489 (get_frame_param): Now static, unless HAVE_NS.
6490 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6491 (x_get_resource_string): Remove; not used.
6492 * frame.h (make_terminal_frame, x_report_frame_params):
6493 (x_get_resource_string); Remove decls.
6494 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6495 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6496
239f9db9
PE
6497 * font.c, fontset.c: Make symbols static if they're not exported.
6498 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6499 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6500 * font.c (font_close_object): Now static.
6501 * font.h (font_close_object): Remove.
6502 * fontset.c (FONTSET_OBJLIST): Remove.
6503 (free_realized_fontset) #if-0 the body, which does nothing.
6504 (face_suitable_for_char_p): #if-0, as it's never called.
6505 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6506 * xfaces.c (face_at_string_position):
6507 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6508 since 0 is always ASCII.
6509
dfcf3579
PE
6510 * fns.c (weak_hash_tables): Now static.
6511
5045092b
PE
6512 * fileio.c: Make symbols static if they're not exported.
6513 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6514 (Vwrite_region_annotation_buffers): Now static.
6515
57a96f5c
PE
6516 * eval.c: Make symbols static if they're not exported.
6517 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6518 * lisp.h (backtrace_list): Remove decl.
6519
35f08c38
PE
6520 * emacs.c: Make symbols static if they're not exported.
6521 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6522 (fatal_error_code, fatal_error_signal_hook, standard_args):
6523 Now static.
6524 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6525 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6526 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6527 * lisp.h (fatal_error_signal_hook): Remove decl.
6528 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6529
f44bd759
PE
6530 * editfns.c: Move a (normally-unused) function to its only use.
6531 * editfns.c, lisp.h (get_operating_system_release): Remove.
6532 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6533 worth the hassle of breaking this out.
6534
b532497d
PE
6535 * xterm.c: Make symbols static if they're not exported.
6536 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6537 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6538 (x_destroy_window, x_delete_display):
6539 Now static.
6540 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6541 (x_mouse_leave): Remove; unused.
6542 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6543 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6544 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6545 Remove decls.
6546 (x_mouse_leave): Declare only if WINDOWSNT.
6547 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6548 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6549 USE_X_TOOLKIT.
6550
1675728f
PE
6551 * ftxfont.c: Make symbols static if they're not exported.
6552 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6553 HAVE_FREETYPE.
6554 * font.h (ftxfont_driver): Likewise.
6555
e4cebfca
PE
6556 * xfns.c: Make symbols static if they're not exported.
6557 (x_last_font_name, x_display_info_for_name):
6558 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6559 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6560 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6561 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6562 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6563 (last_show_tip_args): Now static.
6564 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6565 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6566 (x_screen_planes): Remove; unused.
6567 * dispextern.h (x_screen_planes): Remove decl.
6568
5bf46f05
PE
6569 * dispnew.c: Make symbols static if they're not exported.
6570 * dispextern.h (redraw_garbaged_frames, scrolling):
6571 (increment_row_positions): Remove.
6572 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6573 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6574 Now static.
6575 (redraw_garbaged_frames): Remove; unused.
6576
435f4c28
PE
6577 * xfaces.c: Make symbols static if they're not exported.
6578 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6579 Remove decls.
6580 * xterm.h (defined_color): Remove decls.
6581 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6582 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6583 (menu_face_changed_default, defined_color, free_realized_face):
6584 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6585 (ascii_face_of_lisp_face): Remove; unused.
6586
8524aef3
PE
6587 * xdisp.c: Make symbols static if they're not exported.
6588 * dispextern.h (scratch_glyph_row, window_box_edges):
6589 (glyph_to_pixel_coords, set_cursor_from_row):
6590 (get_next_display_element, set_iterator_to_next):
6591 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6592 (show_mouse_face): Remove decls
6593 * frame.h (message_buf_print): Likewise.
6594 * lisp.h (pop_message, set_message, check_point_in_composition):
6595 Likewise.
6596 * xterm.h (set_vertical_scroll_bar): Likewise.
6597 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6598 (message_buf_print, scratch_glyph_row, displayed_buffer):
6599 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6600 (get_next_display_element, show_mouse_face, window_box_edges):
6601 (frame_to_window_pixel_xy, check_point_in_composition):
6602 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6603 (glyph_to_pixel_coords): Remove; unused.
6604
16390cd2
PE
6605 * dired.c (file_name_completion): Now static.
6606
6607 * dbusbind.c (xd_in_read_queued_messages): Now static.
6608
a25f4dfa
PE
6609 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6610 * data.c (circular_list_error): Remove.
6611
14a9c8df
PE
6612 * commands.h (last_point_position, last_point_position_buffer):
6613 (last_point_position_window): Remove decls.
6614 * keyboard.c: Make these variables static.
6615
04f2d78b
CB
6616 * coding.h (coding, code_convert_region, encode_coding_gap):
6617 Remove decls.
74ab6df5
PE
6618 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6619 (iso_code_class, detect_coding, code_convert_region): Now static.
6620 (encode_coding_gap): Remove; unused.
6621
38dfbee1
PE
6622 * chartab.c (chartab_chars, chartab_bits): Now static.
6623
a2cb4e63
PE
6624 * charset.h (charset_iso_8859_1): Remove decl.
6625 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6626 Now static.
6627
127198fd
PE
6628 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6629 * ccl.c (Vccl_program_table): Now static.
6630 (check_ccl_update): Remove; unused.
6631
d85b608f
PE
6632 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6633 * category.h: ... from here.
6634 * category.c (check_category_table, set_category_set): Now static.
6635
31cd66f3
PE
6636 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6637 * lisp.h: Remove these decls.
6638
c358e587
PE
6639 * buffer.c (buffer_count): Remove unused var.
6640
e78aecca
PE
6641 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6642 so that it's not optimized away.
6643 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6644 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6645 exported only to the debugger.
6646
e192d7d3 6647 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6648 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6649
92470028
PE
6650 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6651 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6652 was inaccessible from Lisp.
6653 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6654 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6655
244ed907
PE
6656 alloc.c: Import and export fewer symbols, and remove unused items.
6657 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6658 is defined.
6659 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6660 it's not optimized away by whole-program optimization.
6661 (message_enable_multibyte, free_misc): Remove.
6662 (catchlist, handlerlist, mark_backtrace):
6663 Declare only if BYTE_MARK_STACK.
6664 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6665 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6666 (message_enable_multibyte): Remove decl.
6667 (free_misc, interval_free_list, float_block, float_block_index):
6668 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6669 (cons_free_list, last_marked_index):
6670 Now static.
6671 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6672 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6673 (mark_backtrace): Define only if BYTE_MARK_STACK.
6674 * xdisp.c (message_enable_multibyte): Now static.
6675
61c2b50e 6676 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6677 This makes it easier for human readers (and static analyzers)
6678 to see whether these variables are used from other modules.
6679 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6680 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6681 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6682 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6683 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6684 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6685 * xmenu.c, xselect.c:
6686 Declare Q* vars static if they are not used in other modules.
6687 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6688 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6689 Remove decls of unexported vars.
6690 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6691
95c82688
PE
6692 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6693
16a97296
PE
6694 Make Emacs functions such as Fatom 'static' by default.
6695 This makes it easier for human readers (and static analyzers)
6696 to see whether these functions can be called from other modules.
6697 DEFUN now defines a static function. To make the function external
6698 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6699 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6700 (Finit_image_library):
16a97296
PE
6701 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6702 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6703 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6704 Remove decls, since these functions are now static.
6705 (Funintern, Fget_internal_run_time): New decls, since these functions
6706 were already external.
95c82688 6707
16a97296
PE
6708 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6709 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6710 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6711 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6712 * keyboard.c, keymap.c, lread.c:
6713 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6714 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6715 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6716 Mark functions with DEFUE instead of DEFUN,
6717 if they are used in other modules.
6718 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6719 decls for now-static functions.
6720 * buffer.h (Fdelete_overlay): Remove decl.
6721 * callproc.c (Fgetenv_internal): Mark as internal.
6722 * composite.c (Fremove_list_of_text_properties): Remove decl.
6723 (Fcomposition_get_gstring): New forward static decl.
6724 * composite.h (Fcomposite_get_gstring): Remove decl.
6725 * dired.c (Ffile_attributes): New forward static decl.
6726 * doc.c (Fdocumntation_property): New forward static decl.
6727 * eval.c (Ffetch_bytecode): New forward static decl.
6728 (Funintern): Remove extern decl; now in .h file where it belongs.
6729 * fileio.c (Fmake_symbolic_link): New forward static decl.
6730 * image.c (Finit_image_library): New forward static decl.
6731 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6732 * intervals.h (Fprevious_property_change):
6733 (Fremove_list_of_text_properties): Remove decls.
6734 * keyboard.c (Fthis_command_keys): Remove decl.
6735 (Fcommand_execute): New forward static decl.
6736 * keymap.c (Flookup_key): New forward static decl.
6737 (Fcopy_keymap): Now static.
6738 * keymap.h (Flookup_key): Remove decl.
6739 * process.c (Fget_process): New forward static decl.
6740 (Fprocess_datagram_address): Mark as internal.
6741 * syntax.c (Fsyntax_table_p): New forward static decl.
6742 (skip_chars): Remove duplicate decl.
6743 * textprop.c (Fprevious_property_change): New forward static decl.
6744 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6745 Now internal.
6746 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6747 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6748
785bbd42
PE
6749 * editfns.c (Fformat): Remove unreachable code.
6750
8b913b57
AS
67512011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6752
6753 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6754 change. (Bug#8496)
6755
a6744a35
EZ
67562011-04-13 Eli Zaretskii <eliz@gnu.org>
6757
6758 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6759 when at ZV. (Bug#8487)
6760
e7974947
AS
67612011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6762
baad03f0
AS
6763 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6764 (Bug#8437)
6765 * keyboard.c (parse_tool_bar_item): Likewise.
6766 * sound.c (sound_cleanup, alsa_close): Likewise.
6767 * termcap.c (tgetent): Likewise.
6768 * xfns.c (x_default_font_parameter): Likewise.
6769 * xsettings.c (read_and_apply_settings): Likewise.
6770
e7974947
AS
6771 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6772 (overrun_check_free): Protoize.
6773
28272684
PE
67742011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6775
6776 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6777 since callers should never pass a negative size.
6778 Change the signature to match that of plain 'read' and 'write'; see
6779 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6780 * lisp.h: Update prototypes of emacs_write and emacs_read.
6781
11997c76
EZ
67822011-04-11 Eli Zaretskii <eliz@gnu.org>
6783
6784 * xdisp.c (redisplay_window): Don't try to determine the character
6785 position of the scroll margin if the window start point w->startp
e896f03c 6786 is outside the buffer's accessible region. (Bug#8468)
11997c76 6787
8a2cbd72
EZ
67882011-04-10 Eli Zaretskii <eliz@gnu.org>
6789
6790 Fix write-region and its subroutines for buffers > 2GB.
6791 * fileio.c (a_write, e_write): Modify declaration of arguments and
6792 local variables to support buffers larger than 2GB.
6793 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6794
6795 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6796 argument, local variables, and return value.
6797
6798 * lisp.h: Update prototypes of emacs_write and emacs_read.
6799
6800 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6801
4073e537 68022011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6803
1ebfdcb6
PE
6804 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6805
b2ded58d
PE
6806 Fix more problems found by GCC 4.6.0's static checks.
6807
7d66342c
PE
6808 * xdisp.c (vmessage): Use a better test for character truncation.
6809
bbf47d44
PE
6810 * charset.c (load_charset_map): <, not <=, for optimization,
6811 and to avoid potential problems with integer overflow.
9248994d 6812 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6813 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6814 * editfns.c (Fformat): Likewise.
1e69125e 6815 * syntax.c (skip_chars): Likewise.
3befa583 6816
e3019616
PE
6817 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6818 This also lets GCC 4.6.0 generate slightly better loop code.
6819
becfa255
PE
6820 * callint.c (Fcall_interactively): <, not <=, for optimization.
6821 (Fcall_interactively): Count the number of arguments produced,
6822 not the number of arguments given. This is simpler and lets GCC
6823 4.6.0 generate slightly better code.
6824
dae0cd48
PE
6825 * ftfont.c: Distingish more carefully between FcChar8 and char.
6826 The previous code passed unsigned char * to a functions like
6827 strlen and xstrcasecmp that expect char *, which does not
6828 conform to the C standard.
6829 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6830 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6831 char * when the C standard requires it.
6832
76032d70
PE
6833 * keyboard.c (read_char): Remove unused var.
6834
eb3f1cc8
PE
6835 * eval.c: Port to Windows vsnprintf (Bug#8435).
6836 Include <limits.h>.
6837 (SIZE_MAX): Define if the headers do not.
6838 (verror): Do not give up if vsnprintf returns a negative count.
6839 Instead, grow the buffer. This ports to Windows vsnprintf, which
6840 does not conform to C99. Problem reported by Eli Zaretskii.
6841 Also, simplify the allocation scheme, by avoiding the need for
6842 calling realloc, and removing the ALLOCATED variable.
6843
70476b54
PE
6844 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6845
12020a9e
PE
6846 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6847 But keep the doprint source code for now, as we might revamp it
6848 and use it again (Bug#8435).
ea6c7ae6
PE
6849 * lisp.h (doprnt): Remove.
6850 * Makefile.in (base_obj): Remove doprnt.o.
6851 * deps.mk (doprnt.o): Remove.
6852
5fdb398c
PE
6853 error: Print 32- and 64-bit integers portably (Bug#8435).
6854 Without this change, on typical 64-bit hosts error ("...%d...", N)
6855 was used to print both 32- and 64-bit integers N, which relied on
6856 undefined behavior.
6857 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6858 New macro.
6859 * lisp.h (error, verror): Mark as printf-like functions.
6860 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6861 Report overflow in size calculations when allocating printf buffer.
6862 Do not truncate output string at its first null byte.
6863 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6864 Truncate the output at a character boundary, since vsnprintf does not
6865 do that.
6866 * charset.c (check_iso_charset_parameter): Convert internal
6867 character to string before calling 'error', since %c now has the
6868 printf meaning.
6869 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6870 overflow when computing char to be passed to 'error'. Do not
6871 pass Lisp_Object to 'error'; pass the integer instead.
6872 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6873 formatted with plain %d.
6874
b189fa66
PE
6875 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6876
bff87ef0
PE
6877 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6878
7e2cac20
PE
6879 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6880
ce4d90b5
PE
6881 * xterm.c (x_catch_errors): Remove duplicate declaration.
6882
266c9547
PE
6883 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6884
79c49ad2
PE
6885 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6886
368f4090
JM
68872011-04-10 Jim Meyering <meyering@redhat.com>
6888
6889 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6890 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6891 return ssize_t not "int", and use size_t as the buffer length.
6892 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6893 * gnutls.h: Update declarations.
6894 * process.c (read_process_output): Use ssize_t, to match.
6895 (send_process): Likewise.
6896
a32d4040
CY
68972011-04-09 Chong Yidong <cyd@stupidchicken.com>
6898
6899 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6900
8546720e 69012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6902
04f2d78b
CB
6903 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6904 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6905
8546720e
GM
6906 * xterm.c (handle_one_xevent):
6907 * xmenu.c (create_and_show_popup_menu):
6908 * xselect.c (x_decline_selection_request)
6909 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6910
0a2f5c1a 69112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6912
6913 Fix some uses of `int' instead of EMACS_INT.
6914 * search.c (string_match_1, fast_string_match)
6915 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6916 (scan_buffer, find_next_newline_no_quit)
6917 (find_before_next_newline, search_command, Freplace_match)
6918 (Fmatch_data): Make some `int' variables be EMACS_INT.
6919
6920 * xdisp.c (display_count_lines): 3rd argument and return value now
6921 EMACS_INT. All callers changed.
6922 (pint2hrstr): Last argument is now EMACS_INT.
6923
6924 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6925 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6926 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6927 (decode_coding_utf_16, decode_coding_emacs_mule)
6928 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6929 (decode_coding_ccl, decode_coding_charset)
6930 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6931 (decode_coding_iso_2022, decode_coding_emacs_mule)
6932 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6933 <char_offset, last_offset>: Declare EMACS_INT.
6934 (encode_coding_utf_8, encode_coding_utf_16)
6935 (encode_coding_emacs_mule, encode_invocation_designation)
6936 (encode_designation_at_bol, encode_coding_iso_2022)
6937 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6938 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6939 Declare EMACS_INT.
6940 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6941 (encode_invocation_designation): Last argument P_NCHARS is now
6942 EMACS_INT.
6943 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6944 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6945
6946 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6947 All users changed.
6948
6949 * ccl.c (Fccl_execute_on_string): Declare some variables
6950 EMACS_INT.
6951
8546720e 69522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6953
6954 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6955
4e19a977
CS
69562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6957
6958 * process.c (Fformat_network_address): Doc fix.
6959
87302331
R
69602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6961
6962 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6963
cbb59342
CY
69642011-04-08 Chong Yidong <cyd@stupidchicken.com>
6965
6966 * keyboard.c (read_char): Call Lisp function help-form-show,
6967 instead of using internal_with_output_to_temp_buffer.
6968 (Qhelp_form_show): New var.
e0d38eeb 6969 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6970
6971 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6972
6973 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6974
e67a13ab
CY
69752011-04-06 Chong Yidong <cyd@stupidchicken.com>
6976
04f2d78b
CB
6977 * process.c (Flist_processes): Remove to Lisp.
6978 (list_processes_1): Delete.
e67a13ab 6979
973f782d
EZ
69802011-04-06 Eli Zaretskii <eliz@gnu.org>
6981
7c106b1e
EZ
6982 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6983
973f782d
EZ
6984 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6985
41cf7d1a 69862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6987
ca23cc88
PE
6988 Fix more problems found by GCC 4.6.0's static checks.
6989
f390e2d5
PE
6990 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6991
42eea0d0
PE
6992 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6993
b69769da 6994 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6995
f9541e84
PE
6996 * xdisp.c (vmessage): Mark as a printf-like function.
6997
13841b55
PE
6998 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6999
c136c10f
PE
7000 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7001
5e2d4a30
PE
7002 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7003 printf-like functions.
7004 (tiff_load): Add casts to remove these marks before passing them
7005 to system-supplied API.
7006
583f48b9
PE
7007 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7008
b25d760e
PE
7009 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7010 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7011 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7012 directly, rather than having caller test rule sign. This avoids
7013 some unnecessary tests.
7014 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7015 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7016 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7017
bc7b6697 7018 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7019 (xfont_open): Avoid unnecessary tests.
bc7b6697 7020
27ccc379
PE
7021 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7022
dcd5c89a
PE
7023 * composite.h, composite.c (composition_gstring_put_cache):
7024 Use EMACS_INT, not int, for length.
7025
b13a45c6
PE
7026 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7027 breaking out part of COMPOSITION_DECODE_RULE.
7028 (COMPOSITION_DECODE_RULE): Use it.
7029 * composite.c (get_composition_id): Remove unused local vars,
7030 by using the new macro.
7031
1e792e4d
PE
7032 * textprop.c (set_text_properties_1): Change while to do-while,
7033 since the condition is always true at first.
7034
dc6c6455 7035 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7036 (interval_deletion_adjustment): Return unsigned value.
7037 All uses changed.
dc6c6455 7038
aba7731a
PE
7039 * process.c (list_processes_1, create_pty, read_process_output):
7040 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7041 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7042 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7043 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7044 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7045
fdfc4bf3
PE
7046 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7047
fca8fe46 7048 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7049 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7050
06a0259a 7051 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7052 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7053 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7054
e7b9e80f
PE
7055 * print.c (print_error_message): Avoid int overflow.
7056
56201685
PE
7057 * font.c (font_list_entities): Redo for clarity,
7058 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7059
78834453 7060 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7061 (font_score): Avoid potential overflow in diff calculation.
78834453 7062
0bc0b309 7063 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7064 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7065
e610eaca
PE
7066 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7067
b895abce
PE
7068 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7069 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7070 can always succeed if overflow has undefined behavior.
7071
1f1d9321 7072 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7073 (wordify): Omit three unnecessary tests.
1f1d9321 7074
c59478bc
PE
7075 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7076 All callers changed. This avoids the need for an unused var.
7077
79b73827
PE
7078 * casefiddle.c (casify_region): Remove var that is set but not used.
7079
a4db5dfe
PE
7080 * dired.c (file_name_completion): Remove var that is set but not used.
7081
43aae36e
PE
7082 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7083
2a47c44d 7084 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7085 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7086
a37c69bf
PE
7087 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7088 Check for integer overflow on size calculations.
7089
328ab8e7
PE
7090 * buffer.c (Fprevious_overlay_change): Remove var that is set
7091 but not used.
7092
e5a2a5cb
PE
7093 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7094 Remove vars that are set but not used.
8d84a6eb 7095 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7096 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7097
a60e5f68
PE
7098 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7099
f661cb61 7100 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7101 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7102
f0397f5a
PE
7103 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7104 that are set but not used.
7105
8664db06 7106 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7107 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7108
6abdaa4a
PE
7109 * xselect.c (x_get_local_selection, x_handle_property_notify):
7110 Remove vars that are set but not used.
7111
0ce7538d 7112 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7113 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7114
9ae848fc
PE
7115 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7116 Remove var that is set but not used.
0b918413
PE
7117 (scroll_bar_windows_size): Now size_t, not int.
7118 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7119 Check for overflow.
9ae848fc 7120
a5a62657
PE
7121 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7122 (map_tty_color) [!defined MSDOS]: Likewise.
7123
5c5cdd39
PE
7124 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7125
66ebf983
PE
7126 * coding.c: Remove vars that are set but not used.
7127 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7128 All callers changed.
7129 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7130 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7131 (decode_coding_charset): Remove vars that are set but not used.
7132
1be4d761
PE
7133 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7134 that is set but not used.
7135
47553fa8
PE
7136 * print.c (print_object): Remove var that is set but not used.
7137
1f7196bf 7138 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7139 The gnulib version avoids calling malloc in the usual case,
7140 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7141 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7142 * filelock.c (current_lock_owner): Likewise.
7143 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7144 * sysdep.c: Include allocator.h, careadlinkat.h.
7145 (emacs_no_realloc_allocator): New static constant.
7146 (emacs_readlink): New function.
fdb61804
PE
7147 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7148 ../lib/careadlinkat.h.
d1fdcab7 7149
f84c17c7
SM
71502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7151
7152 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7153 first non-nil return value).
7154
ef3862ad
JD
71552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7156
7157 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7158 if not defined (Bug#8403).
7159
376a7006
JB
71602011-04-02 Juanma Barranquero <lekktu@gmail.com>
7161
7162 * xdisp.c (display_count_lines): Remove parameter `start',
7163 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7164 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7165 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7166 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7167 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7168 and thereabouts. All callers changed.
7169 (get_per_char_metric): Remove parameter `f', unused since
7170 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7171
6ca3801d
JM
71722011-04-02 Jim Meyering <meyering@redhat.com>
7173
7174 do not dereference NULL upon failed strdup
7175 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7176 (ns_get_family): Likewise.
7177
d8e2b5ba
JB
71782011-04-02 Juanma Barranquero <lekktu@gmail.com>
7179
7180 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7181
8c74fcbd
JD
71822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7183
7184 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7185 later (Bug#8403).
7186
7200d79c
SM
71872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7188
03408648 7189 Add lexical binding.
7200d79c 7190
03408648
SM
7191 * window.c (Ftemp_output_buffer_show): New fun.
7192 (Fsave_window_excursion):
7193 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7194
7195 * lread.c (lisp_file_lexically_bound_p): New function.
7196 (Fload): Bind Qlexical_binding.
7197 (readevalloop): Remove `evalfun' arg.
7198 Bind Qinternal_interpreter_environment.
7199 (Feval_buffer): Bind Qlexical_binding.
7200 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7201 Mark as dynamic.
7202 (syms_of_lread): Declare `lexical-binding'.
7203
7204 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7205
7206 * keyboard.c (eval_dyn): New fun.
7207 (menu_item_eval_property): Use it.
ca105506
SM
7208
7209 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7210
03408648
SM
7211 * fns.c (concat, mapcar1): Accept byte-code-functions.
7212
7213 * eval.c (Fsetq): Handle lexical vars.
7214 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7215 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7216 (FletX, Flet): Obey lexical binding.
7217 (Fcommandp): Handle closures.
7218 (Feval): New `lexical' arg.
7219 (eval_sub): New function extracted from Feval. Use it almost
7220 everywhere where Feval was used. Look up vars in lexical env.
7221 Handle closures.
7222 (Ffunctionp): Move from subr.el.
7223 (Ffuncall): Handle closures.
7224 (apply_lambda): Remove `eval_flags'.
7225 (funcall_lambda): Handle closures and new byte-code-functions.
7226 (Fspecial_variable_p): New function.
7227 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7228 but without exporting it to Lisp.
23aba0ea 7229
23aba0ea 7230 * doc.c (Fdocumentation, store_function_docstring):
03408648 7231 * data.c (Finteractive_form): Handle closures.
23aba0ea 7232
03408648
SM
7233 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7234 interactive spec.
ba83908c 7235
04f2d78b
CB
7236 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7237 New byte-codes.
03408648
SM
7238 (exec_byte_code): New function extracted from Fbyte_code to handle new
7239 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7240
03408648 7241 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7242
03408648 7243 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7244
e2abce01
JB
72452011-03-31 Juanma Barranquero <lekktu@gmail.com>
7246
7247 * xdisp.c (redisplay_internal): Fix prototype.
7248
63696a73 72492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7250
63696a73 7251 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7252 (try_scrolling): Use it when setting scroll_limit.
7253 Limit scrolling to 100 screen lines.
63696a73
EZ
7254 (redisplay_window): Even when falling back on "recentering",
7255 position point in the window according to scroll-conservatively,
7256 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7257
7258 (try_scrolling): When point is above the window, allow searching
7259 as far as scroll_max, or one screenful, to compute vertical
7260 distance from PT to the scroll margin position. This prevents
7261 try_scrolling from unnecessarily failing when
7262 scroll-conservatively is set to a value slightly larger than the
7263 window height. Clean up the case of PT below the margin at bottom
7264 of window: scroll_max can no longer be INT_MAX. When aggressive
7265 scrolling is in use, don't let point enter the opposite scroll
7266 margin as result of the scroll.
7267 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7268 threshold of 100 lines for never-recentering scrolling.
7269
e4cc2dfc
JB
72702011-03-31 Juanma Barranquero <lekktu@gmail.com>
7271
7272 * dispextern.h (move_it_by_lines):
7273 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7274 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7275 (message_log_check_duplicate): Remove parameters `prev_bol' and
7276 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7277 (redisplay_internal): Remove parameter `preserve_echo_area',
7278 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7279
7280 * indent.c (Fvertical_motion):
7281 * window.c (window_scroll_pixel_based, Frecenter):
7282 Don't pass `need_y_p' to `move_it_by_lines'.
7283
1c470562
SM
72842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7285
44f230aa
SM
7286 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7287 steal a few bits to be more compact.
7288 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7289 Remove unneeded casts.
7290
1c470562
SM
7291 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7292
888adce9
ZK
72932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7294
7295 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7296 binding" message (bug#7967).
7297
f838ed7b
PE
72982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7299
77861b95
PE
7300 Fix more problems found by GCC 4.6.0's static checks.
7301
de6dbc14
PE
7302 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7303 Remove unused local var.
7304
f838ed7b
PE
7305 * editfns.c (Fmessage_box): Remove unused local var.
7306
792c7b2b
PE
7307 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7308 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7309 Omit unused local vars.
c499e557 7310 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7311 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7312 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7313 Omit unused local var.
7314
ba0165e1
PE
7315 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7316 Don't assume string length fits in int.
32ad8845 7317 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7318 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7319
3c59b4c9
PE
7320 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7321 instead of alloca (Bug#8344).
7322
a3eed478 7323 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7324 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7325
eb4d412d
PE
7326 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7327
1658b401
PE
7328 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7329 concerns.
7330
7331 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7332
7333 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7334
9a2c6e05
PE
7335 * keyboard.c (syms_of_keyboard): Use the same style as later
7336 in this function when indexing through an array. This also
7337 works around GCC bug 48267.
7338
03d0a109
PE
7339 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7340
44f730c8
PE
7341 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7342
fe75f926
PE
7343 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7344 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7345
ffa8c828
PE
7346 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7347 This avoids undefined behavior on integer overflow, and is a bit
7348 more convenient anyway since it is compared to a size_t variable.
7349
c5101a77
PE
7350 Variadic C functions now count arguments with size_t, not int.
7351 This avoids an unnecessary limitation on 64-bit machines, which
7352 caused (substring ...) to crash on large vectors (Bug#8344).
7353 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7354 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7355 All variadic functions and their callers changed accordingly.
c5101a77
PE
7356 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7357 * data.c (arith_driver, float_arith_driver): Likewise.
7358 * editfns.c (general_insert_function): Likewise.
7359 * eval.c (struct backtrace.nargs, interactive_p)
7360 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7361 (funcall_lambda, mark_backtrace): Likewise.
7362 * fns.c (concat): Likewise.
7363 * frame.c (x_set_frame_parameters): Likewise.
7364 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7365 0 if not found, not -1. All callers changed.
7366
dd3f25f7
PE
7367 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7368 (stack_copy_size): Now size_t, not int.
7369 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7370
461c2ab9
JB
73712011-03-28 Juanma Barranquero <lekktu@gmail.com>
7372
7373 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7374 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7375 All callers changed.
7376
7377 * lisp.h (multibyte_char_to_unibyte):
7378 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7379 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7380 * character.h (CHAR_TO_BYTE8):
7381 * cmds.c (internal_self_insert):
7382 * editfns.c (general_insert_function):
7383 * keymap.c (push_key_description):
7384 * search.c (Freplace_match):
7385 * xdisp.c (message_dolog, set_message_1): All callers changed.
7386
f6d62986
SM
73872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7388
7389 * keyboard.c (safe_run_hook_funcall): New function.
7390 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7391 don't set the hook to nil, but remove the offending function instead.
7392 (Qcommand_hook_internal): Remove, unused.
7393 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7394 Vcommand_hook_internal.
7395
7396 * eval.c (enum run_hooks_condition): Remove.
7397 (funcall_nil, funcall_not): New functions.
7398 (run_hook_with_args): Call each function through a `funcall' argument.
7399 Remove `cond' argument, now redundant.
7400 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7401 (Frun_hook_with_args_until_failure): Adjust accordingly.
7402 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7403
1db5b1ad
JB
74042011-03-28 Juanma Barranquero <lekktu@gmail.com>
7405
7406 * dispextern.h (string_buffer_position): Remove declaration.
7407
7408 * print.c (strout): Remove parameter `multibyte', unused since
7409 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7410
7411 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7412 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7413 All callers changed.
7414
7415 * w32.c (_wsa_errlist): Use braces for struct initializers.
7416
7417 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7418 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7419 All callers changed.
7420 (string_buffer_position): Likewise. Also, make static (it's never
7421 used outside xdisp.c).
7422 (cursor_row_p): Remove parameter `w', unused since
7423 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7424 (decode_mode_spec): Remove parameter `precision', introduced during
7425 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7426 All callers changed.
7427
5ffb62aa
JD
74282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7429
7430 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7431
461c2ab9 74322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7433
7434 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7435 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7436 (ns_update_auto_hide_menu_bar): New functions.
7437 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7438 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7439 ns_constrain_all_frames.
7440 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7441 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7442
5c380ffb
JD
74432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7444
7445 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7446
9af30bdf
GM
74472011-03-27 Glenn Morris <rgm@gnu.org>
7448
7449 * syssignal.h: Replace RETSIGTYPE with void.
7450 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7451 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7452 Replace SIGTYPE with void everywhere.
7453 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7454 * s/template.h (SIGTYPE): Remove commented out definition.
7455
e2abce01
JB
74562011-03-26 Eli Zaretskii <eliz@gnu.org>
7457
7458 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7459 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7460
f868cd8a
JB
74612011-03-26 Juanma Barranquero <lekktu@gmail.com>
7462
59eb0929
JB
7463 * w32.c (read_unc_volume): Use parameter `henum', instead of
7464 global variable `wget_enum_handle'.
7465
7466 * keymap.c (describe_vector): Remove parameters `indices' and
7467 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7468 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7469
f868cd8a
JB
7470 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7471
7472 * keyboard.c (timer_check): Remove parameter `do_it_now',
7473 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7474 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7475 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7476
7477 * keyboard.c (read_char):
7478 * w32menu.c (w32_menu_display_help):
7479 * xmenu.c (show_help_event, menu_help_callback):
7480 Adjust calls to `show_help_echo'.
7481
7482 * gtkutil.c (xg_maybe_add_timer):
7483 * keyboard.c (readable_events):
7484 * process.c (wait_reading_process_output):
7485 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7486
7487 * insdel.c (adjust_markers_gap_motion):
7488 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7489 (gap_left, gap_right): Don't call it.
7490
2ecf6fdb
CY
74912011-03-25 Chong Yidong <cyd@stupidchicken.com>
7492
7493 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7494 incurred during fontification.
7495
6b1f9ba4
JB
74962011-03-25 Juanma Barranquero <lekktu@gmail.com>
7497
7498 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7499 (DEFVAR_PER_BUFFER): Don't pass it.
7500
7501 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7502 (scrolling_window): Don't pass it.
7503
0f4a96b5
JB
75042011-03-25 Juanma Barranquero <lekktu@gmail.com>
7505
7506 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7507
7508 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7509 and `suffix'.
7510 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7511 of variables specific to SELinux and computation of `encoded_absname'.
7512
7513 * image.c (XPutPixel): Remove unused variable `height'.
7514
7515 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7516
7517 * unexw32.c (get_section_info): Remove unused variable `section'.
7518
7519 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7520 (system_process_attributes): Remove unused variable `sess'.
7521 (sys_read): Remove unused variable `err'.
7522
7523 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7524 (w32_wnd_proc): Remove unused variable `isdead'.
7525 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7526 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7527 (x_create_tip_frame): Remove unused variable `tem'.
7528
7529 * w32inevt.c (w32_console_read_socket):
7530 Remove unused variable `no_events'.
7531
7532 * w32term.c (x_draw_composite_glyph_string_foreground):
7533 Remove unused variable `width'.
7534
1149507c
JB
75352011-03-24 Juanma Barranquero <lekktu@gmail.com>
7536
7537 * w32term.c (x_set_glyph_string_clipping):
7538 Don't pass uninitialized region to CombineRgn.
7539
9c88f339
JB
75402011-03-23 Juanma Barranquero <lekktu@gmail.com>
7541
7542 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7543 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7544 (Fx_close_connection): Remove unused variable `i'.
7545
7546 * w32font.c (w32font_draw): Return number of glyphs.
7547 (w32font_open_internal): Remove unused variable `i'.
7548 (w32font_driver): Add missing initializer.
7549
7550 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7551 (fill_in_menu): Remove unused variable `items_added'.
7552
7553 * w32term.c (last_mouse_press_frame): Remove static global variable.
7554 (w32_clip_to_row): Remove unused variable `f'.
7555 (x_delete_terminal): Remove unused variable `i'.
7556
7557 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7558 (NOTHING): Remove unused static global variable.
7559 (uniscribe_check_otf): Remove unused variable `table'.
7560 (uniscribe_font_driver): Add missing initializers.
7561
dee091a3
JD
75622011-03-23 Julien Danjou <julien@danjou.info>
7563
7564 * term.c (Fsuspend_tty, Fresume_tty):
7565 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7566 * window.c (temp_output_buffer_show):
7567 * insdel.c (signal_before_change):
7568 * frame.c (Fhandle_switch_frame):
7569 * fileio.c (Fdo_auto_save):
7570 * emacs.c (Fkill_emacs):
7571 * editfns.c (save_excursion_restore):
7572 * cmds.c (internal_self_insert):
7573 * callint.c (Fcall_interactively):
7574 * buffer.c (Fkill_all_local_variables):
7575 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7576 Use Frun_hooks.
0f4a96b5 7577 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7578 unconditionnaly since it does the check itself.
7579
2c520ab5 75802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7581
c9c49752
PE
7582 Fix more problems found by GCC 4.5.2's static checks.
7583
8abc3f12
PE
7584 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7585 the first time through the loop, since we know p0 < p1 then.
7586 This also avoids a gcc -Wstrict-overflow warning.
7587
a2d26660
PE
7588 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7589 leading to a memory leak, possible in functions like
7590 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7591 of objects (Bug#8318).
a2d26660 7592
916c72e9
PE
7593 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7594 that could (at least in theory) be that large.
7595
19ab8a18
PE
7596 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7597 This is less likely to overflow, and avoids undefined behavior if
7598 overflow does occur. All callers changed. Use strtoul to scan
7599 for the unsigned long integer.
b7cbbd6f
PE
7600 (pint2hrstr): Simplify and tune code slightly.
7601 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7602
f0641eff
PE
7603 * scroll.c (do_scrolling): Work around GCC bug 48228.
7604 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7605
7f650bb9
PE
7606 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7607 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7608 (validate_x_resource_name): Simplify count usage.
7609 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7610
37dd57d1
PE
7611 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7612 fail (Bug#8306).
81e56e61 7613
699979fc 7614 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7615
401bf9b4
PE
7616 * process.c (Fmake_network_process): Use socklen_t, not int,
7617 where POSIX says socklen_t is required in portable programs.
7618 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7619 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7620 (Fmake_network_process, server_accept_connection):
7621 (wait_reading_process_output, read_process_output):
7622 Likewise.
7623
b93aacde
PE
7624 * process.c: Rename or move locals to avoid shadowing.
7625 (list_processes_1, Fmake_network_process):
7626 (read_process_output_error_handler, exec_sentinel_error_handler):
7627 Rename or move locals.
4dc343ee 7628 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7629 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7630 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7631 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7632 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7633
af8a867c 7634 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7635 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7636 Include tparam.h instead, since it declares them.
af8a867c
PE
7637 * cm.h (PC): Remove extern decl; tparam.h now does this.
7638 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7639 * terminfo.c: Include tparam.h, to check interfaces.
7640 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7641 (tparam): Adjust signature to match interface in tparam.h;
7642 this removes some undefined behavior. Check that outstring and len
7643 are zero, which they always are with Emacs.
7644 * tparam.h (PC, BC, UP): New extern decls.
7645
0248044d 7646 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7647 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7648
8ff096c1 7649 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7650 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7651 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7652 (ftfont_list): Remove unused local.
49eaafba
PE
7653 (get_adstyle_property, ftfont_pattern_entity):
7654 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7655 Rename locals to avoid shadowing.
8ff096c1 7656
e2be39f6
PE
7657 * xfont.c (xfont_list_family): Mark var as initialized.
7658
c9735e30
PE
7659 * xml.c (make_dom): Now static.
7660
8f5201ae
PE
7661 * composite.c (composition_compute_stop_pos): Rename local to
7662 avoid shadowing.
b246f932
PE
7663 (composition_reseat_it): Remove unused locals.
7664 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7665 (composition_update_it): Mark var as initialized.
11b61122
PE
7666 (find_automatic_composition): Mark vars as initialized,
7667 with a FIXME (Bug#8290).
8f5201ae 7668
760fbc2c
PE
7669 character.h: Rename locals to avoid shadowing.
7670 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7671 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7672 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7673 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7674 to avoid shadowing.
7675
ff08eb85
PE
7676 * textprop.c (property_change_between_p): Remove; unused.
7677
fc7bf025
PE
7678 * intervals.c (interval_start_pos): Now static.
7679
235d7abc
PE
7680 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7681
44f230aa
SM
7682 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7683 Rename locals to avoid shadowing.
3e7d6594 7684
50060332
PE
7685 * sound.c (wav_play, au_play, Fplay_sound_internal):
7686 Fix pointer signedness.
d01f234b 7687 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7688 (wav_play): Initialize a variable to 0, to prevent undefined
7689 behavior (Bug#8278).
50060332 7690
c4fc4e30
PE
7691 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7692
918436ed
PE
7693 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7694
c939f91b
PE
7695 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7696 clobbering (Bug#8298).
b9c7f648
PE
7697 * sysdep.c (sys_subshell): Likewise.
7698 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7699
6bd8c144
PE
7700 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7701 This should get cleaned up, so that child_setup has the
7702 same signature on all platforms.
7703
7710357c 7704 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7705 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7706
c59da222
CY
77072011-03-22 Chong Yidong <cyd@stupidchicken.com>
7708
7709 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7710 not to be necessary, and produces flickering.
7711
66b87493
GM
77122011-03-20 Glenn Morris <rgm@gnu.org>
7713
7714 * config.in: Remove file.
7715
45b6f6d5
JB
77162011-03-20 Juanma Barranquero <lekktu@gmail.com>
7717
7718 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7719 are now in src/globals.h.
7720 (syms_of_minibuf): Remove spurious & from previous change.
7721
3ec03f7e
LL
77222011-03-20 Leo <sdl.web@gmail.com>
7723
7724 * minibuf.c (completing-read-function): New variable.
7725 (completing-read-default): Rename from completing-read.
7726 (completing-read): Call completing-read-function.
7727
b14e3e21
CY
77282011-03-19 Juanma Barranquero <lekktu@gmail.com>
7729
7730 * xfaces.c (Fx_load_color_file):
7731 Read color file from absolute filename (bug#8250).
7732
f2b726e6
JB
77332011-03-19 Juanma Barranquero <lekktu@gmail.com>
7734
7735 * makefile.w32-in: Update dependencies.
7736
09f6ff02
EZ
77372011-03-17 Eli Zaretskii <eliz@gnu.org>
7738
7739 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7740
29a6015a
PE
77412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7742
a3a6c54e
PE
7743 Fix more problems found by GCC 4.5.2's static checks.
7744
b766f867
PE
7745 * process.c (make_serial_process_unwind, send_process_trap):
7746 (sigchld_handler): Now static.
7747
be02381c
PE
7748 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7749 That way, the code declares only the vars that it needs.
7750 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7751 * s/cygwin.h (PTY_ITERATION): Likewise.
7752 * s/darwin.h (PTY_ITERATION): Likewise.
7753 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7754
57048744
PE
7755 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7756 * process.c (allocate_pty): Don't declare stb unless it's needed.
7757
7914961c 7758 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7759 (CONSTANTLIM): Remove; unused.
7760 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7761 Define only if needed.
7914961c 7762
b3967b18
PE
7763 * unexelf.c (unexec): Name an expression,
7764 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7765 Use a different way to cause a compilation error if anyone uses
7766 n rather than nn, a way that does not involve shadowing.
73366a00 7767 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7768
29a6015a
PE
7769 * deps.mk (unexalpha.o): Remove; unused.
7770
43cfc33e 7771 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7772 * unexec.h: New file.
ce701a33
PE
7773 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7774 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7775 Depend on unexec.h.
7776 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7777 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7778 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7779 Change as necessary to match prototype in unexec.h.
ce701a33 7780
01f44d5a
PE
7781 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7782 shadowing.
4f63c6bb 7783 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7784
a6670b0b
PE
7785 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7786 Rename locals to avoid shadowing.
7787
cef2010d 7788 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7789 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7790
d4d7173a
PE
7791 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7792
f08b802a
PE
7793 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7794 warning when compiling print.c.
7795
3ddb0639
PE
7796 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7797 instead of using an uninitialized var.
5ad03b97 7798 (font_sort_entities): Mark var as initialized.
3ddb0639 7799
170a2692
PE
7800 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7801
e663c700
PE
7802 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7803 pointers to constants.
89bc529a 7804 (font_parse_fcname): Remove unused vars.
7b81e2d0 7805 (font_delete_unmatched): Now static.
ea838e10 7806 (font_get_spec): Remove; unused.
13a547c6
PE
7807 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7808 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7809 Rename or move locals to avoid shadowing.
e663c700 7810
2a80c887 7811 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7812 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7813
1384fa33 7814 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7815 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7816
8b2c52e9
PE
7817 * alloc.c (mark_backtrace): Move decl from here ...
7818 * lisp.h: ... to here, so that it can be checked.
7819
475545b5 7820 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7821 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7822 (lisp_indirect_variable): Name an expression,
7823 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7824 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7825
b1349114 7826 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7827 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7828 Use const pointer when appropriate.
b1349114 7829
a2928364
PE
7830 * lisp.h (get_system_name, get_operating_system_release):
7831 Move decls here, to check interfaces.
7832 * process.c (get_operating_system_release): Move decl to lisp.h.
7833 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7834 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7835 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7836 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7837 (Fformat_time_string, Fencode_time, Finsert_char):
7838 (Ftranslate_region_internal, Fformat):
7839 Rename or remove local vars to avoid shadowing.
9710023e 7840 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7841
a415e694
PE
7842 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7843 avoid shadowing.
7844
8ef4622d
PE
7845 * lisp.h (eassert): Check that the argument compiles, even if
7846 ENABLE_CHECKING is not defined.
7847
946f9a5b
PE
7848 * data.c (Findirect_variable): Name an expression, to avoid
7849 gcc -Wbad-function-cast warning.
112396d6 7850 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7851 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7852 (Fmake_variable_buffer_local, Fmake_local_variable):
7853 Mark variables as initialized.
52746918 7854 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7855
e5aab7e7 7856 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7857 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7858 Rename locals to avoid shadowing.
dff45157
PE
7859 (mark_stack): Move local variables into the #ifdef region where
7860 they're used.
7bc26fdb
PE
7861 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7862 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7863 needed otherwise.
7864 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7865 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7866 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7867
e5aab7e7
PE
7868 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7869 avoids undefined behavior in theory.
7870
4da60324
PE
7871 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7872
88043301
PE
7873 Use functions, not macros, for up- and down-casing (Bug#8254).
7874 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7875 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7876 to use the following functions instead of these macros.
7877 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7878 EMACS_INT, since callers assume the returned value fits in int.
7879 (upcase1): Likewise, for UPCASE_TABLE.
7880 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7881 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7882 the race-condition problem in the old DOWNCASE.
88043301 7883
19ed5445
PE
7884 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7885 Rename locals to avoid shadowing.
7886 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7887 (regex_compile, re_search_2, re_match_2_internal):
7888 Remove unused local vars.
952db0d7
PE
7889 (FREE_VAR): Rewrite so as not to use empty "else",
7890 which gcc can warn about.
da053e48 7891 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7892 (RETALLOC_IF): Define only if needed.
7893 (WORDCHAR_P): Likewise. This one is never needed, but is used
7894 only in a comment talking about a compiler bug, so put inside
7895 the #if 0 of that comment.
7896 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7897 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7898 Remove; unused.
19ed5445 7899
1f3561e4 7900 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7901 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7902 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7903
ded6f8f7
PE
7904 * search.c (simple_search): Remove unused var.
7905
dbd37a95
PE
7906 * dired.c (compile_pattern): Move decl from here ...
7907 * lisp.h: ... to here, so that it can be checked.
7908 (struct re_registers): New forward decl.
7909
7e47afad
PE
7910 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7911
85f24f61
PE
7912 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7913 All uses changed.
7914 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7915 Rename locals to avoid shadowing.
5671df8f 7916 (Fvertical_motion): Mark locals as initialized.
85f24f61 7917
181aa2be 7918 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7919 (casify_region): Mark local as initialized.
181aa2be 7920
930d429c
PE
7921 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7922
7082eac6
PE
7923 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7924 New macros, so that the caller can use some names other than
7925 gcpro1, gcpro2, etc.
7926 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7927 of the new macros.
7928 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7929 argument, for consistency with GCPRO2_VAR, etc: it is now the
7930 prefix of the variable, not the variable itself. All uses
7931 changed.
38b2c076
PE
7932 * dired.c (directory_files_internal, file_name_completion):
7933 Rename locals to avoid shadowing.
7934
15206ed9
PE
7935 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7936 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7937 dired.c's scmp function, had undefined behavior.
7938 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7939 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7940 * buffer.h: ... to here, because these macros use current_buffer,
7941 and the new implementation with inline functions needs to have
7942 current_buffer in scope now, rather than later when the macros
7943 are used.
7944 (downcase, upcase1): New static inline functions.
7945 (DOWNCASE, UPCASE1): Reimplement using these functions.
7946 This avoids undefined behavior in expressions like
7947 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7948 from race conditions in accessing the global variables
7949 case_temp1 and case_temp2.
7950 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7951 * lisp.h (case_temp1, case_temp2): Remove their decls.
7952 * character.h (ASCII_CHAR_P): Move from here ...
7953 * lisp.h: ... to here, so that the inline functions mentioned
7954 above can use them.
7955
4a6bea26
PE
7956 * dired.c (directory_files_internal_unwind): Now static.
7957
f14b7e14
PE
7958 * fileio.c (file_name_as_directory, directory_file_name):
7959 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7960 Now static.
2893f146
PE
7961 (file_name_as_directory): Use const pointers when appropriate.
7962 (Fexpand_file_name): Likewise. In particular, newdir might
7963 point at constant storage, so make it a const pointer.
fd4ead52 7964 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7965 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7966 signedness issues.
f839df0c
PE
7967 (Fset_file_times, Finsert_file_contents, auto_save_error):
7968 Rename locals to avoid shadowing.
f14b7e14 7969
5716756e 7970 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7971 (Ftry_completion, Fall_completions): Rename or remove locals
7972 to avoid shadowing.
5716756e 7973
b4c3046a
PE
7974 * marker.c (bytepos_to_charpos): Remove; unused.
7975
b45db522
PE
7976 * lisp.h (verify_bytepos, count_markers): New decls,
7977 so that gcc does not warn that these functions aren't declared.
7978
85876d07
PE
7979 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7980 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7981 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7982 (copy_text): Remove unused local var.
85876d07 7983
03d78a21 7984 * filelock.c (within_one_second): Now static.
b3dd38ab 7985 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7986
5df8f01b
PE
7987 * buffer.c (fix_overlays_before): Mark locals as initialized.
7988 (fix_start_end_in_overlays): Likewise. This function should be
7989 simplified by using pointers-to-pointers, but that's a different
7990 matter.
b1d876f1 7991 (switch_to_buffer_1): Now static.
8f54f30a
PE
7992 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7993 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7994
a70072c9 7995 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7996 Fix pointer signedness issue.
edced198
PE
7997 (sys_subshell): Mark local as volatile if checking for lint,
7998 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7999 (MAXPATHLEN): Define only if needed.
a70072c9 8000
a0977c44
PE
8001 * process.c (serial_open, serial_configure): Move decls from here ...
8002 * systty.h: ... to here, so that they can be checked.
8003
a884fdcc
PE
8004 * fns.c (get_random, seed_random): Move extern decls from here ...
8005 * lisp.h: ... to here, so that they can be checked.
8006
604efe86 8007 * sysdep.c (reset_io): Now static.
b8950c94 8008 (wait_for_termination_signal): Remove; unused.
604efe86 8009
38fc62d9
PE
8010 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8011 (copy_keymap_item, append_key, push_text_char_description):
8012 Now static.
1004a21a 8013 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8014 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8015 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8016 (describe_map_tree):
8017 Rename locals to avoid shadowing.
38fc62d9 8018
2f2650da
PE
8019 * keyboard.c: Declare functions static if they are not used elsewhere.
8020 (echo_char, echo_dash, cmd_error, top_level_2):
8021 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8022 (read_char, kbd_buffer_get_event, make_lispy_position):
8023 (make_lispy_event, make_lispy_movement, apply_modifiers):
8024 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8025 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8026 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8027 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8028 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8029
a053e86c 8030 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8031 (mark_kboards): Move decl here ...
8032 * alloc.c (mark_kboards): ... from here.
a053e86c 8033
4752793e
PE
8034 * lisp.h (force_auto_save_soon): New decl.
8035
74f10ca7 8036 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8037 (DEFINE_DUMMY_FUNCTION): New macro.
8038 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8039 Use it.
c03cd23f
PE
8040 (main): Add casts to avoid warnings
8041 if GCC considers string literals to be constants.
74f10ca7 8042
022e70d4
PE
8043 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8044
59d6fe83
PE
8045 * dbusbind.c: Pointer signedness fixes.
8046 (xd_signature, xd_append_arg, xd_initialize):
8047 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8048 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8049 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8050 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8051
78320123
PE
8052 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8053 if GCC considers string literals to be constants.
49cebcca 8054 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8055
35ac2a97
SM
80562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8057
fb103ca9
SM
8058 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8059 (print_preprocess, print_object): New macro to fix last change.
8060
35ac2a97
SM
8061 * print.c (print_preprocess): Don't forget font objects.
8062
62973b41
JB
80632011-03-16 Juanma Barranquero <lekktu@gmail.com>
8064
8065 * emacs.c (USAGE3): Doc fixes.
8066
0e48bb22
AS
80672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8068
8069 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8070 structure.
8071
7684e57b
JB
80722011-03-14 Juanma Barranquero <lekktu@gmail.com>
8073
8074 * lisp.h (VWindow_system, Qfile_name_history):
8075 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8076 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8077 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8078
8079 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8080 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8081
8082 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8083 * w32console.c (detect_input_pending, read_input_pending)
8084 (encode_terminal_code):
8085 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8086 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8087 (w32_system_caret_y, Qfile_name_history):
8088 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8089 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8090 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8091 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8092 * w32proc.c (Qlocal, report_file_error):
8093 * w32term.c (Vwindow_system, updating_frame):
8094 * w32uniscribe.c (initialized, uniscribe_font_driver):
8095 Remove unneeded extern declarations.
8096
2aa46d6c
CY
80972011-03-14 Chong Yidong <cyd@stupidchicken.com>
8098
c96bbc66 8099 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8100
cffc6f3b
CY
81012011-03-13 Chong Yidong <cyd@stupidchicken.com>
8102
8103 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8104 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8105 These macros can no longer be used for assignment.
8106
44f230aa
SM
8107 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8108 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8109 (record_buffer_markers, fetch_buffer_markers): New functions for
8110 recording and fetching special buffer markers.
8111 (set_buffer_internal_1, set_buffer_temp): Use them.
8112
8113 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8114
8115 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8116
8117 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8118 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8119
8120 * xdisp.c (hscroll_window_tree):
8121 (reconsider_clip_changes): Use PT instead of BUF_PT.
8122
d251f04b
EZ
81232011-03-13 Eli Zaretskii <eliz@gnu.org>
8124
8125 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8126 $(EMACS_ROOT)/lib/intprops.h.
8127
f0c77cd1
PE
81282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8129
3eca4629
PE
8130 Fix more problems found by GCC 4.5.2's static checks.
8131
7c86ee98
PE
8132 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8133 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8134 (xg_free_frame_widgets): Make it clear that a local variable is
8135 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8136 (gdk_window_get_screen): Make it clear that this macro is needed
8137 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8138 (int_gtk_range_get_value): New function, which avoids a diagnostic
8139 from gcc -Wbad-function-cast.
8140 (xg_set_toolkit_scroll_bar_thumb): Use it.
8141 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8142 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8143 (get_utf8_string, xg_get_file_with_chooser):
8144 Rename locals to avoid shadowing.
8145 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8146
41729b81
PE
8147 * xgselect.c (xg_select): Remove unused var.
8148
f0c77cd1
PE
8149 * image.c (four_corners_best): Mark locals as initialized.
8150 (gif_load): Initialize transparent_p to zero (Bug#8238).
8151 Mark another local as initialized.
ec6cf4c6 8152 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8153
ce0ad53d 8154 * image.c (clear_image_cache): Now static.
d5d5a617 8155 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8156 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8157 (x_edge_detection): Remove unnecessary cast that
8158 gcc -Wbad-function-cast diagnoses.
2037898d 8159 (gif_load): Fix pointer signedness.
6ae141d6
PE
8160 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8161 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8162
33383987 81632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8164
d32df629
PE
8165 Improve quality of tests for time stamp overflow.
8166 For example, without this patch (encode-time 0 0 0 1 1
8167 1152921504606846976) returns the obviously-bogus value (-948597
8168 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8169 reports time overflow. See
8170 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8171 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8172 * editfns.c: Include limits.h and intprops.h.
8173 (TIME_T_MIN, TIME_T_MAX): New macros.
8174 (time_overflow): Move earlier, to before first use.
8175 (hi_time, lo_time): New functions, for an accurate test for
8176 out-of-range times.
8177 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8178 (Fget_internal_run_time): Don't assume time_t fits in int.
8179 (make_time): Use list2 instead of Fcons twice.
8180 (Fdecode_time): More accurate test for out-of-range times.
8181 (check_tm_member): New function.
8182 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8183 (lisp_time_argument): Don't rely on undefined left-shift and
8184 right-shift behavior when checking for time stamp overflow.
8be6f318 8185
fe31d94c
PE
8186 * editfns.c (time_overflow): New function, refactoring common code.
8187 (Fformat_time_string, Fdecode_time, Fencode_time):
8188 (Fcurrent_time_string): Use it.
8189
8be6f318
PE
8190 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8191 * dired.c (make_time): Move to ...
8192 * editfns.c (make_time): ... here.
8193 * systime.h: Note the move.
8194
09d9db2c 81952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8196
126bc0dc
YM
8197 * fringe.c (update_window_fringes): Remove unused variables.
8198
c47cbdfd
YM
8199 * unexmacosx.c (copy_data_segment): Also copy __got section.
8200 (Bug#8223)
8201
7ac80be9
EZ
82022011-03-12 Eli Zaretskii <eliz@gnu.org>
8203
c96bbc66 8204 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8205 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8206 Constify `char *' arguments and their references according to
8207 prototypes in tparam.h.
8208
ecb0f94d 8209 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8210
7ac80be9
EZ
8211 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8212 Adapt all references accordingly.
8213
8214 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8215
ef1fd07e
TT
82162011-03-11 Tom Tromey <tromey@redhat.com>
8217
8218 * buffer.c (syms_of_buffer): Remove obsolete comment.
8219
7ef4b50c
EZ
82202011-03-11 Eli Zaretskii <eliz@gnu.org>
8221
8222 * termhooks.h (encode_terminal_code): Declare prototype.
8223
8224 * msdos.c (encode_terminal_code): Don't declare prototype.
8225
8226 * term.c (encode_terminal_code): Now external again, used by
8227 w32console.c and msdos.c.
8228
44f230aa
SM
8229 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8230 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8231
4b1ec863 82322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8233
1714f52b 8234 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8235
4b1ec863
PE
8236 * fringe.c (update_window_fringes): Mark locals as initialized
8237 (Bug#8227).
8238 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8239
524c7aa6
PE
8240 * alloc.c (mark_fringe_data): Move decl from here ...
8241 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8242 to check its interface.
8243 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8244
a5c0af81 8245 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8246 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8247 (fontset_font): Mark local as initialized.
a9a06e0b 8248 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8249
b4716021
PE
8250 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8251
811e9bac 8252 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8253 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8254 (x_own_selection, Fx_disown_selection_internal): Rename locals
8255 to avoid shadowing.
8256 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8257
7e3ab302
PE
8258 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8259 so that the caller can use some name other than gcpro1.
8260 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8261 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8262 (Fx_backspace_delete_keys_p):
8263 Use them to avoid shadowing, and rename vars to avoid shadowing.
8264 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8265 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8266 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8267 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8268 Remove unused locals.
7e3ab302
PE
8269 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8270 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8271 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8272 macros.
f78faa98 8273
e2b13473
PE
8274 * xterm.h (x_mouse_leave): New decl.
8275
77f23912
PE
8276 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8277 Remove unused functions.
cdf4ba58
PE
8278 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8279 (x_calc_absolute_position): Now static.
7411c686 8280 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8281 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8282 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8283 unless they are used.
38d0b34a
PE
8284 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8285 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8286 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8287 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8288 (x_error_catcher, x_connection_closed, x_error_handler):
8289 (x_error_quitter, xembed_send_message, x_iconify_frame):
8290 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8291 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8292 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8293
44f230aa
SM
8294 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8295 Rename or move locals to avoid shadowing.
6b463e58 8296 (tty_defined_color, merge_face_heights): Now static.
5967d051 8297 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8298 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8299 does not deduce is never used uninitialized.
73719eba
PE
8300 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8301 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8302
426994c3 8303 * terminal.c (store_terminal_param): Now static.
5489860b 8304
032f1620 8305 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8306 (set_frame_menubar): Remove unused local.
d4323972 8307 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8308 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8309 since they might point to immutable storage.
281585b0
PE
8310 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8311 since it's unused otherwise.
032f1620 8312
367c19e5 8313 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8314 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8315 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8316 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8317 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8318 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8319 does not deduce are never used uninitialized.
70739cbe 8320
07b48fa9
PE
8321 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8322
8868a238 8323 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8324 * window.c (window_loop, size_window):
8325 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8326
7e5cf297 8327 * window.c (display_buffer): Now static.
d6550a9f
PE
8328 (size_window): Mark variables that gcc -Wuninitialized
8329 does not deduce are never used uninitialized.
a586633d
PE
8330 * window.h (check_all_windows): New decl, to forestall
8331 gcc -Wmissing-prototypes diagnostic.
5b555da1 8332 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8333
f6095868
PE
8334 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8335 shadowing.
8336 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8337 Include <limits.h>.
8338 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8339 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8340 (load_charset_map): Mark variables that gcc -Wuninitialized
8341 does not deduce are never used uninitialized.
53df7c11 8342 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8343
f38b440c
PE
8344 * coding.c (coding_set_source, coding_set_destination):
8345 Use "else { /* comment */ }" rather than "else /* comment */;"
8346 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8347 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8348 a block, when the outer 'i' will do.
8349 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8350 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8351 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8352 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8353 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8354 Rename locals to avoid shadowing.
8355 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8356 * coding.c (emacs_mule_char, encode_invocation_designation):
8357 Now static, since they're not used elsewhere.
413bb2db 8358 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8359 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8360 (decode_coding_emacs_mule): Mark variables that gcc
8361 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8362 (detect_coding_iso_2022): Initialize a local variable that might
8363 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8364 this initialization is needed. (Bug#8211)
5f58e762
PE
8365 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8366 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8367 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8368 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8369 Remove unused macros.
f38b440c 8370
232b38b9 8371 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8372 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8373 * character.c (string_count_byte8): Likewise.
232b38b9 8374
fb90da1b
PE
8375 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8376 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8377
fb93dbc2
PE
8378 * chartab.c (copy_sub_char_table): Now static, since it's not used
8379 elsewhere.
5c156ace
PE
8380 (sub_char_table_ref_and_range, char_table_ref_and_range):
8381 Rename locals to avoid shadowing.
bbcd0949 8382 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8383
7d3b3862 8384 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8385 (BIDI_BOB): Remove unused macro.
7d3b3862 8386
6be7d3da
PE
8387 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8388 deduce are never used uninitialized.
c2ed9c8b 8389 * term.c (encode_terminal_code): Likewise.
6be7d3da 8390
75f8807f 8391 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8392
50938595
PE
8393 * tparam.h: New file.
8394 * term.c, tparam.h: Include it.
8395 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8396 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8397 Move these decls to tparam.h, and make them agree with what
8398 is actually in tparam.c. The previous trick of using incompatible
8399 decls in different modules does not conform to the C standard.
8400 All callers of tparam changed to use tparam's actual API.
8401 * tparam.c (tparam1, tparam, tgoto):
8402 Use const pointers where appropriate.
8403
fbceeba2
PE
8404 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8405 * cm.h (struct cm): Likewise.
8406 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8407 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8408 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8409 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8410 (turn_on_face, init_tty): Likewise.
8411 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8412
7f3f1250
PE
8413 * term.c (term_mouse_position): Rename local to avoid shadowing.
8414
e6ca6543
PE
8415 * alloc.c (mark_ttys): Move decl from here ...
8416 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8417
c40f8d15
AS
84182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8419
8420 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8421
cfe0661d
JB
84222011-03-09 Juanma Barranquero <lekktu@gmail.com>
8423
8424 * search.c (compile_pattern_1): Remove argument regp, unused since
8425 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8426 (compile_pattern): Don't pass it.
8427
0afb4571
J
84282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8429
8430 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8431 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8432 for ! HAVE_GTK3.
8433 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8434
8435 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8436
8437 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8438 gdk_window_get_screen, gdk_window_get_geometry,
8439 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8440 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8441 (xg_get_pixbuf_from_pixmap): New function.
8442 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8443 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8444 Call xg_get_pixbuf_from_pixmap instead of
8445 gdk_pixbuf_get_from_drawable.
8446 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8447 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8448 (xg_check_special_colors): Use GtkStyleContext and its functions
8449 for HAVE_GTK3.
8450 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8451 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8452 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8453 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8454 Call gtk_widget_get_preferred_size.
0afb4571
J
8455 (xg_frame_resized): gdk_window_get_geometry only takes 5
8456 parameters.
44f230aa
SM
8457 (xg_win_to_widget, xg_event_is_for_menubar):
8458 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8459 (xg_set_widget_bg): New function.
8460 (delete_cb): New function.
895009e1 8461 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8462 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8463 (xg_set_background_color): Call xg_set_widget_bg.
8464 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8465 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8466 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8467 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8468 if ! HAVE_GTK3.
8469 (update_frame_tool_bar): Call gtk_widget_hide.
8470 (xg_initialize): Use GDK_KEY_g.
8471
8472 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8473 if ! HAVE_GTK3
8474 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8475
8476 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8477 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8478 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8479
1c2cc4ef
JB
84802011-03-08 Juanma Barranquero <lekktu@gmail.com>
8481
8482 * w32xfns.c (select_palette): Check success of RealizePalette against
8483 GDI_ERROR, not zero.
8484
33383987 8485See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8486
8487;; Local Variables:
8488;; coding: utf-8
aac0c6e3
MR
8489;; End:
8490
33383987 8491 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8492
8493 This file is part of GNU Emacs.
8494
8495 GNU Emacs is free software: you can redistribute it and/or modify
8496 it under the terms of the GNU General Public License as published by
8497 the Free Software Foundation, either version 3 of the License, or
8498 (at your option) any later version.
8499
8500 GNU Emacs is distributed in the hope that it will be useful,
8501 but WITHOUT ANY WARRANTY; without even the implied warranty of
8502 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8503 GNU General Public License for more details.
8504
8505 You should have received a copy of the GNU General Public License
8506 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.