* alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c9d624c6
PE
12011-06-08 Paul Eggert <eggert@cs.ucla.edu>
2
c78baabf
PE
3 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4
c9d624c6
PE
5 * alloc.c: Catch some string size overflows that we were missing.
6 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7 for convenience in STRING_BYTES_MAX.
8 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9 The definition here is exact; the one in lisp.h was approximate.
10 (allocate_string_data): Check for string overflow. This catches
11 some instances we weren't catching before. Also, it catches
12 size_t overflow on (unusual) hosts where SIZE_MAX <= min
13 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
14 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 15
c9d624c6
PE
16 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
17 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
18 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
19
2bccce07
PE
202011-06-07 Paul Eggert <eggert@cs.ucla.edu>
21
353032ce
PE
22 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
23
2bccce07
PE
24 * alloc.c (Fmake_string): Check for out-of-range init.
25
a54e3482
DC
262011-06-07 Daniel Colascione <dan.colascione@gmail.com>
27
28 * fns.c (Fputhash): Document return value.
29
60002bf5
CY
302011-06-06 Chong Yidong <cyd@stupidchicken.com>
31
32 * image.c (gif_load): Implement gif89a spec "no disposal" method.
33
0c671da6 342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 35
b862a52a 36 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 37
be44ca6c
PE
38 Check for overflow when converting integer to cons and back.
39 * charset.c (Fdefine_charset_internal, Fdecode_char):
40 Use cons_to_unsigned to catch overflow.
41 (Fencode_char): Use INTEGER_TO_CONS.
42 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
43 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
44 * data.c (long_to_cons, cons_to_long): Remove.
45 (cons_to_unsigned, cons_to_signed): New functions.
46 These signal an error for invalid or out-of-range values.
47 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
48 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
49 * font.c (Ffont_variation_glyphs):
50 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
51 * lisp.h: Include <intprops.h>.
52 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
53 (cons_to_signed, cons_to_unsigned): New decls.
54 (long_to_cons, cons_to_long): Remove decls.
55 * undo.c (record_first_change): Use INTEGER_TO_CONS.
56 (Fprimitive_undo): Use CONS_TO_INTEGER.
57 * xfns.c (Fx_window_property): Likewise.
58 * xselect.c: Include <limits.h>.
59 (x_own_selection, selection_data_to_lisp_data):
60 Use INTEGER_TO_CONS.
61 (x_handle_selection_request, x_handle_selection_clear)
62 (x_get_foreign_selection, Fx_disown_selection_internal)
63 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
64 (lisp_data_to_selection_data): Use cons_to_unsigned.
65 (x_fill_property_data): Use cons_to_signed.
66 Report values out of range.
67
d1f3d2af
PE
68 Check for buffer and string overflow more precisely.
69 * buffer.h (BUF_BYTES_MAX): New macro.
70 * lisp.h (STRING_BYTES_MAX): New macro.
71 * alloc.c (Fmake_string):
72 * character.c (string_escape_byte8):
73 * coding.c (coding_alloc_by_realloc):
74 * doprnt.c (doprnt):
75 * editfns.c (Fformat):
76 * eval.c (verror):
77 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
78 since they may not be the same number.
79 * editfns.c (Finsert_char):
80 * fileio.c (Finsert_file_contents):
81 Likewise for BUF_BYTES_MAX.
82
dd52fcea
PE
83 * image.c: Use ptrdiff_t, not int, for sizes.
84 (slurp_file): Switch from int to ptrdiff_t.
85 All uses changed.
86 (slurp_file): Check that file size fits in both size_t (for
87 malloc) and ptrdiff_t (for sanity and safety).
88
7f9bbdbb
PE
89 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
90 if b->modtime has its maximal value.
91
dfe18f82
PE
92 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
93
84acfcf0
PE
94 Don't assume time_t can fit into int.
95 * buffer.h (struct buffer.modtime): Now time_t, not int.
96 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
97 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
98
ccd9a01a
PE
99 Minor fixes for signed vs unsigned integers.
100 * character.h (MAYBE_UNIFY_CHAR):
101 * charset.c (maybe_unify_char):
102 * keyboard.c (read_char, reorder_modifiers):
103 XINT -> XFASTINT, since the integer must be nonnegative.
104 * ftfont.c (ftfont_spec_pattern):
105 * keymap.c (access_keymap, silly_event_symbol_error):
106 XUINT -> XFASTINT, since the integer must be nonnegative.
107 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
108 since it makes no difference and we prefer signed.
109 * keyboard.c (record_char): Use XUINT when all the neighbors do.
110 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
111 nonnegative.
112
d6d100dd
SM
1132011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
114
115 * window.h (Fwindow_frame): Declare.
116
2b6148e4
PE
1172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
118
119 * alloc.c: Simplify handling of large-request failures (Bug#8800).
120 (SPARE_MEMORY): Always define.
121 (LARGE_REQUEST): Remove.
122 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
123
f230ecc9
MR
1242011-06-06 Martin Rudalics <rudalics@gmx.at>
125
727e958e
MR
126 * lisp.h: Move EXFUNS for Fframe_root_window,
127 Fframe_first_window and Fset_frame_selected_window to window.h.
128
129 * window.h: Move EXFUNS for Fframe_root_window,
130 Fframe_first_window and Fset_frame_selected_window here from
131 lisp.h.
132
133 * frame.c (Fwindow_frame, Fframe_first_window)
134 (Fframe_root_window, Fframe_selected_window)
135 (Fset_frame_selected_window): Move to window.c.
136 (Factive_minibuffer_window): Move to minibuf.c.
137 (Fother_visible_frames_p): New function.
138
139 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
140
f230ecc9
MR
141 * window.c (decode_window, decode_any_window): Move up in code.
142 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
143 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
144 (Fwindow_buffer): Move up and rewrite doc-string.
145 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
146 (Fwindow_prev): New functions.
727e958e
MR
147 (Fwindow_frame): Move here from frame.c. Accept any window as
148 argument.
149 (Fframe_root_window, Fframe_first_window)
150 (Fframe_selected_window): Move here from frame.c. Accept frame
151 or arbitrary window as argument. Update doc-strings.
152 (Fminibuffer_window): Move up in code.
153 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
154 (Fset_frame_selected_window): Move here from frame.c.
155 Marginal rewrite.
727e958e
MR
156 (Fselected_window, select_window, Fselect_window): Move up in
157 code. Minor doc-string fixes.
f230ecc9 158
4d09bcf6
PE
1592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
160
161 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
162 Do not assume that spare memory exists; that assumption is valid
163 only if SYSTEM_MALLOC.
164 (LARGE_REQUEST): New macro, so that the issue of large requests
165 is separated from the issue of spare memory.
166
810928a2
AS
1672011-06-05 Andreas Schwab <schwab@linux-m68k.org>
168
172418ad
AS
169 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
170 format. (Bug#8806)
171
43f862f7
AS
172 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
173
810928a2
AS
174 * xfns.c (x_set_scroll_bar_default_width): Move declarations
175 before statements.
176
a059fe24
JD
1772011-06-05 Jan Djärv <jan.h.d@swipnet.se>
178
179 * gtkutil.c (xg_get_default_scrollbar_width): New function.
180
181 * gtkutil.h: Declare xg_get_default_scrollbar_width.
182
183 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
184 min width by calling x_set_scroll_bar_default_width (Bug#8505).
185
989bf368
JB
1862011-06-05 Juanma Barranquero <lekktu@gmail.com>
187
188 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
189
4b80f674
CY
1902011-06-04 Chong Yidong <cyd@stupidchicken.com>
191
192 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
193 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
194 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
195 New error handlers.
4b80f674
CY
196 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
197 Obey Vx_select_enable_clipboard_manager. Catch errors in
198 x_clipboard_manager_save (Bug#8779).
199 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 200 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 201
99a33b77 2022011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
203
204 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
205
99a33b77 2062011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
207
208 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
209 in the current matrix if keep_current_p is non-zero.
210
8264569d
EZ
2112011-06-04 Eli Zaretskii <eliz@gnu.org>
212
213 * bidi.c (bidi_level_of_next_char): Fix last change.
214
57f97249
EZ
2152011-06-03 Eli Zaretskii <eliz@gnu.org>
216
fec2107c 217 Support bidi reordering of text covered by display properties.
57f97249 218
fec2107c
EZ
219 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
220 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
221 (bidi_cache_search, bidi_cache_iterator_state)
222 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
223 (bidi_level_of_next_char, bidi_move_to_visually_next):
224 Support character positions inside a run of characters covered by a
fec2107c
EZ
225 display string.
226 (bidi_paragraph_init, bidi_resolve_explicit_1)
227 (bidi_level_of_next_char): Call bidi_fetch_char and
228 bidi_fetch_char_advance instead of FETCH_CHAR and
229 FETCH_CHAR_ADVANCE.
230 (bidi_init_it): Initialize new members.
231 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
232 definitions.
233 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
234 instead of using explicit *_CHAR codes.
d6d100dd
SM
235 (bidi_resolve_explicit, bidi_resolve_weak):
236 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
237 bidirectional text is supported only in multibyte buffers.
238 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
239 it to initialize the frame_window_p member of struct bidi_it.
240 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
241 (bidi_resolve_explicit, bidi_resolve_weak)
242 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
243 bidi_it->nchars is non-positive.
244 (bidi_level_of_next_char): Don't try to lookup the cache for the
245 next/previous character if nothing is cached there yet, or if we
246 were just reseat()'ed to a new position.
c40e2fb2 247
0e14fe90
EZ
248 * xdisp.c (set_cursor_from_row): Set start and stop points
249 according to the row's direction when priming the loop that looks
250 for the glyph on which to display cursor.
251 (single_display_spec_intangible_p): Function deleted.
252 (display_prop_intangible_p): Reimplement to call
253 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
254 Accept 3 additional arguments needed by handle_display_spec.
255 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
256 values: lists, `(when COND...)' forms, etc.
257 (single_display_spec_string_p): Support property values that are
258 lists with the argument STRING its top-level element.
259 (display_prop_string_p): Fix the condition for processing a
260 property that is a list to be consistent with handle_display_spec.
fec2107c 261 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
262 last portion of handle_display_prop.
263 (compute_display_string_pos): Accept additional argument
264 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
265 value of a `display' property is a "replacing spec".
266 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
267 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
268 the display property, but just return a value indicating whether
269 the display property will replace the characters it covers.
270 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
271 frame_window_p members of struct bidi_it.
d6d100dd
SM
272 (compute_display_string_pos, compute_display_string_end):
273 New functions.
fec2107c
EZ
274 (push_it): Accept second argument POSITION, where pop_it should
275 jump to continue iteration.
276 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 277
fec2107c
EZ
278 * keyboard.c (adjust_point_for_property): Adjust the call to
279 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
280
281 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
282 (bidi_init_it): Update prototypes.
283 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
284 (compute_display_string_pos, compute_display_string_end):
285 Declare prototypes.
fec2107c
EZ
286 (struct bidi_it): New members nchars and disp_pos. ch_len is now
287 EMACS_INT.
fc6f18ce 288
40087514 2892011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 290
57f53182
PE
291 Malloc failure behavior now depends on size of allocation.
292 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
293 * lisp.h: Change signatures accordingly.
294 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
295 All callers changed. (Bug#8762)
296
297 * gnutls.c: Use Emacs's memory allocators.
298 Without this change, the gnutls library would invoke malloc etc.
299 directly, which causes problems on non-SYNC_INPUT hosts, and which
300 runs afoul of improving memory_full behavior. (Bug#8761)
301 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
302 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
303 xfree instead of the default malloc, realloc, free.
304 (Fgnutls_boot): No need to check for memory allocation failure,
305 since xmalloc does that for us.
306
ac32cd99 307 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
308 * category.c (hash_get_category_set):
309 * ccl.c (ccl_driver):
310 * charset.c (Fdefine_charset_internal):
311 * charset.h (struct charset.hash_index):
312 * composite.c (get_composition_id, gstring_lookup_cache)
313 (composition_gstring_put_cache):
314 * composite.h (struct composition.hash_index):
315 * dispextern.h (struct image.hash):
316 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
317 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
318 (hashfn_equal, hashfn_user_defined, make_hash_table)
319 (maybe_resize_hash_table, hash_lookup, hash_put)
320 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
321 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
322 (Fsxhash, Fgethash, Fputhash, Fmaphash):
323 * image.c (make_image, search_image_cache, lookup_image)
324 (xpm_put_color_table_h):
325 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 326 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
327 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
328 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
329 * alloc.c (allocate_vectorlike):
330 Check for overflow in vector size calculations.
331 * ccl.c (ccl_driver):
332 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
333 * fns.c, image.c: Remove unnecessary static decls that would otherwise
334 need to be updated by these changes.
40087514
PE
335 * fns.c (make_hash_table, maybe_resize_hash_table):
336 Check for integer overflow with large hash tables.
0de4bb68
PE
337 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
338 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
339 (SXHASH_REDUCE): New macro.
340 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
341 Use it instead of discarding useful hash info with large hash values.
342 (sxhash_float): New function.
343 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
344 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
345 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
346 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
347 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
348 Adjust signatures to match updated version of code.
349 (consing_since_gc): Now EMACS_INT, since a single hash table can
350 use more than INT_MAX bytes.
351
698d32e2
DN
3522011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
353
354 Make it possible to build with GCC-4.6+ -O2 -flto.
355
356 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
357
fd6fa53f
SM
3582011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
359
360 * minibuf.c (get_minibuffer, read_minibuf_unwind):
361 Call minibuffer-inactive-mode.
362
864db017
JB
3632011-05-31 Juanma Barranquero <lekktu@gmail.com>
364
365 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
366 Update dependencies.
367
2ad0baf4
DN
3682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
369
370 * data.c (init_data): Remove code for UTS, this system is not
371 supported anymore.
372
4fcc2638
DN
3732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
374
375 Don't force ./temacs to start in terminal mode.
376
377 * frame.c (make_initial_frame): Initialize faces in all cases, not
378 only when CANNOT_DUMP is defined.
379 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
380
c56e0fd5
DN
3812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
382
383 * dispnew.c (add_window_display_history): Use const for the string
384 pointer. Remove declaration, not needed.
385
333d54da 3862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 387
55d4c1b2 388 Use 'inline', not 'INLINE'.
333d54da 389 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
390 * alloc.c, fontset.c (INLINE): Remove.
391 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
392 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
393 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
394 * gmalloc.c (register_heapinfo): Use inline unconditionally.
395 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
396
738db178
DN
3972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
398
399 Make it possible to run ./temacs.
400
401 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
402 syms_of_callproc does the same thing. Remove test for
403 "initialized", do it in the caller.
404 * emacs.c (main): Avoid calling set_initial_environment when dumping.
405
620c53a6
SM
4062011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
407
408 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
409 (read_minibuf): Use get_minibuffer.
410 (syms_of_minibuf): Use DEFSYM.
411 (Qmetadata): New var.
412 * data.c (Qbuffer): Don't make it static.
413 (syms_of_data): Use DEFSYM.
414
e003a292
PE
4152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
416
417 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
418 (CCL_CODE_MIN): New macro.
419
ed008a6d
PE
4202011-05-30 Paul Eggert <eggert@cs.ucla.edu>
421
3687c2ef
PE
422 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
423
ed008a6d
PE
424 * eval.c (Qdebug): Now static.
425 * lisp.h (Qdebug): Remove decl. This reverts a part of the
426 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
427 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
428
d66c4c7c
CY
4292011-05-29 Chong Yidong <cyd@stupidchicken.com>
430
431 * image.c: Various fixes to ImageMagick code comments.
432 (Fimagemagick_types): Doc fix.
433
5fbc2025
PE
4342011-05-29 Paul Eggert <eggert@cs.ucla.edu>
435
0196f88a
PE
436 Minor fixes prompted by GCC 4.6.0 warnings.
437
438 * xselect.c (converted_selections, conversion_fail_tag): Now static.
439
5fbc2025
PE
440 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
441 (x_clipboard_manager_save_all): Move extern decl to ...
442 * xterm.h: ... here, so that it can be checked for consistency.
443
1dd3c2d9
CY
4442011-05-29 Chong Yidong <cyd@stupidchicken.com>
445
446 * xselect.c (x_clipboard_manager_save_frame)
447 (x_clipboard_manager_save_all): New functions.
448 (Fx_clipboard_manager_save): Lisp function deleted.
449
450 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
451 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
452
453 * xterm.h: Update prototype.
454
5ba6571d
WX
4552011-05-28 William Xu <william.xwl@gmail.com>
456
457 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
458 exiting (Bug#8239).
459
3eaff834
JM
4602011-05-28 Jim Meyering <meyering@redhat.com>
461
e1900994 462 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
463 * fns.c (to_uchar): Define.
464 (crypto_hash_function): Use it to convert some newly-signed
465 variables to unsigned, to avoid sign-extension bugs. For example,
466 without this change, (md5 "truc") would evaluate to
467 45723a2aff78ff4fff7fff1114760e62 rather than the expected
468 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 469 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 470
0f6990a7
PE
4712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
472
473 Integer overflow fixes.
c8a9ca5a 474
08686060
PE
475 * dbusbind.c: Serial number integer overflow fixes.
476 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
477 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
478 to hold a serial number that is too large for a fixnum.
479 (Fdbus_method_return_internal, Fdbus_method_error_internal):
480 Check for serial numbers out of range. Decode any serial number
59568bf0 481 that was so large that it became a float. (Bug#8722)
08686060 482
2d1fc3c7
PE
483 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
484 (Fdbus_call_method, Fdbus_call_method_asynchronously):
485 Use XFASTINT rather than XUINT when numbers are nonnegative.
486 (xd_append_arg, Fdbus_method_return_internal):
487 (Fdbus_method_error_internal): Likewise. Also, for unsigned
488 arguments, check that Lisp number is nonnegative, rather than
59568bf0 489 silently wrapping negative numbers around. (Bug#8722)
30217ff0 490 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 491 (Bug#8722)
2d1fc3c7 492
c8a9ca5a
PE
493 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
494
519e1d69
PE
495 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
496
30569699
PE
497 ccl: add integer overflow checks
498 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
499 (IN_INT_RANGE): New macros.
500 (ccl_driver): Use them to check for integer overflow when
501 decoding a CCL program. Many of the new checks are whether XINT (x)
502 fits in int; it doesn't always, on 64-bit hosts. The new version
503 doesn't catch all possible integer overflows, but it's an
847044ea 504 improvement. (Bug#8719)
30569699 505
c11285dc
PE
506 * alloc.c (make_event_array): Use XINT, not XUINT.
507 There's no need for unsigned here.
508
fdccd48e
PE
509 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
510 This follows up to the 2011-05-06 change that substituted uintptr_t
511 for EMACS_INT. This case wasn't caught back then.
512
37910ab2
PE
513 Rework Fformat to avoid integer overflow issues.
514 * editfns.c: Include <float.h> unconditionally, as it's everywhere
515 now (part of C89). Include <verify.h>.
516 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
517 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
518 (Fformat): Avoid the prepass trying to compute sizes; it was only
519 approximate and thus did not catch overflow reliably. Instead, walk
520 through the format just once, formatting and computing sizes as we go,
521 checking for integer overflow at every step, and allocating a larger
522 buffer as needed. Keep track separately whether the format is
523 multibyte. Keep only the most-recently calculated precision, rather
524 than them all. Record whether each argument has been converted to
525 string. Use EMACS_INT, not int, for byte and char and arg counts.
526 Support field widths and precisions larger than INT_MAX. Avoid
527 sprintf's undefined behavior with conversion specifications such as %#d
528 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
529 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
530 formatting out-of-range floating point numbers with int
531 formats. (Bug#8668)
532
2e6578fb
PE
533 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
534
0ae6bdee
PE
535 * data.c: Avoid integer truncation in expressions involving floats.
536 * data.c: Include <intprops.h>.
537 (arith_driver): When there's an integer overflow in an expression
538 involving floating point, convert the integers to floating point
539 so that the resulting value does not suffer from catastrophic
540 integer truncation. For example, on a 64-bit host (* 4
541 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
542 Do not rely on undefined behavior after integer overflow.
543
de883a70
PE
544 merge count_size_as_multibyte, parse_str_to_multibyte
545 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 546 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
547 Check for integer overflow.
548 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
549 since it's now a duplicate of the other. This is more of
550 a character than a buffer op, so better that it's in character.c.
551 * fns.c, print.c: Adjust to above changes.
552
2ff916cb
PE
5532011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
554
555 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
556
f1b54466
PE
5572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
558
fb1ac845
PE
559 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
560 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
561 (x_clipboard_manager_save): Now static.
562 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
563
f1b54466
PE
564 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
565 (crypto_hash_function): Now static.
566 Fix pointer signedness problems. Avoid unnecessary initializations.
567
a9f737ee
CY
5682011-05-27 Chong Yidong <cyd@stupidchicken.com>
569
570 * termhooks.h (Vselection_alist): Make it terminal-local.
571
572 * terminal.c (create_terminal): Initialize it.
573
574 * xselect.c: Support for clipboard managers.
575 (Vselection_alist): Move to termhooks.h as terminal-local var.
576 (LOCAL_SELECTION): New macro.
577 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
578 (symbol_to_x_atom): Remove gratuitous arg.
579 (x_handle_selection_request, lisp_data_to_selection_data)
580 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
581 (x_own_selection, x_get_local_selection, x_convert_selection):
582 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
583 (some_frame_on_display): Delete unused function.
584 (Fx_own_selection_internal, Fx_get_selection_internal)
585 (Fx_disown_selection_internal, Fx_selection_owner_p)
586 (Fx_selection_exists_p): New optional frame arg.
587 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
588 (x_handle_selection_clear): Don't treat other terminals with the
589 same keyboard specially. Use the terminal-local Vselection_alist.
590 (x_clear_frame_selections): Use Frun_hook_with_args.
591
592 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
593
594 * xterm.h: Add support for those atoms.
595
e067f0c1
CY
5962011-05-26 Chong Yidong <cyd@stupidchicken.com>
597
598 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
599 (converted_selections, conversion_fail_tag): New global variables.
600 (x_selection_request_lisp_error): Free the above.
601 (x_get_local_selection): Remove unnecessary code.
602 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
603 of converted selections stored in converted_selections.
604 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
605 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
606 (x_convert_selection): New function.
607 (x_handle_selection_event): Simplify.
608 (x_get_foreign_selection): Don't ignore incoming requests while
609 waiting for an answer; this will fail when we implement
610 SAVE_TARGETS, and seems unnecessary anyway.
611 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
612 (Vx_sent_selection_functions): Doc fix.
613
0f4aebc0
LL
6142011-05-26 Leo Liu <sdl.web@gmail.com>
615
616 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
617
e61124cd
YM
6182011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
619
620 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
621
622 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
623 for fringe update if it has periodic bitmap.
624 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
625 and fringe_bitmap_periodic_p.
626
627 * fringe.c (get_fringe_bitmap_data): New function.
628 (draw_fringe_bitmap_1, update_window_fringes): Use it.
629 (update_window_fringes): Record periodicity of fringe bitmap in glyph
630 row. Mark glyph row for fringe update if periodicity changed.
631
632 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
633 for fringe update unless it has periodic bitmap.
634
f16d9837
KH
6352011-05-25 Kenichi Handa <handa@m17n.org>
636
637 * xdisp.c (get_next_display_element): Set correct it->face_id for
638 a static composition.
639
e1b90ef6
LL
6402011-05-24 Leo Liu <sdl.web@gmail.com>
641
642 * deps.mk (fns.o):
643 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
644
645 * fns.c (crypto_hash_function, Fsha1): New function.
646 (Fmd5): Use crypto_hash_function.
647 (syms_of_fns): Add Ssha1.
648
7400048f
PE
6492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
650
651 * gnutls.c: Remove unused macros.
652 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
653 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
654 Remove macros that are defined and never used.
655 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
656
abb71cf4
CY
6572011-05-22 Chong Yidong <cyd@stupidchicken.com>
658
659 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
660 (Fx_get_selection_internal): Minor cleanup.
661 (Fx_own_selection_internal): Rename arguments for consistency with
662 select.el.
663
6307db39
PE
6642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
665
666 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
667
f3d4e0a4
CY
6682011-05-22 Chong Yidong <cyd@stupidchicken.com>
669
670 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
671
4d8ade89
YM
6722011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
673
674 * dispnew.c (scrolling_window): Don't exclude the case that the
675 last enabled row in the desired matrix touches the bottom boundary.
676
32078c8d
GM
6772011-05-21 Glenn Morris <rgm@gnu.org>
678
679 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
680 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
681 and add some more files.
32078c8d 682
7285dc67
EZ
6832011-05-20 Eli Zaretskii <eliz@gnu.org>
684
685 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
686 report_file_error introduced by the change from 2011-05-07.
687
89d1bd22
PE
6882011-05-20 Paul Eggert <eggert@cs.ucla.edu>
689
690 * systime.h (Time): Define only if emacs is defined.
691 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
692 where the include path doesn't have X11/X.h by default. See
693 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
694
e23640bb 6952011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
696
697 * composite.c (find_automatic_composition): Fix previous change.
698
b9704ad9
GM
6992011-05-20 Glenn Morris <rgm@gnu.org>
700
701 * lisp.mk: New file, split from Makefile.in.
702 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
703 (shortlisp): Remove.
704 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
705
4a720484
GM
7062011-05-19 Glenn Morris <rgm@gnu.org>
707
708 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
709 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
710 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
711 (lisp): Set the order to that of loadup.el.
712 (shortlisp): Make it a copy of $lisp.
713 (SOME_MACHINE_LISP): Remove.
714 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
715 Use just $shortlisp, not $SOME_MACHINE_LISP too.
716
a28d4396
KH
7172011-05-18 Kenichi Handa <handa@m17n.org>
718
719 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
720 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
721 (find_automatic_composition): Mostly rewrite for efficiency.
722
a2b1fa8e
JB
7232011-05-18 Juanma Barranquero <lekktu@gmail.com>
724
725 * makefile.w32-in: Update dependencies.
726
8e1f5610
CS
7272011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
728
729 * menu.c: Include limits.h (fixes the MS-Windows build broken by
730 revision 104625).
731
7025ee00 7322011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 733
cdfa6eab
PE
734 Fix some integer overflow issues, such as string length overflow.
735
06d6db33
PE
736 * insdel.c (count_size_as_multibyte): Check for string overflow.
737
2b4560a8
PE
738 * character.c (lisp_string_width): Check for string overflow.
739 Use EMACS_INT, not int, for string indexes and lengths; in
740 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
741 the resulting string length overflows an EMACS_INT; instead,
742 report a string overflow if no precision given. When checking for
743 precision exhaustion, use a check that cannot possibly have
744 integer overflow. (Bug#8675)
745 * character.h (lisp_string_width): Adjust to new signature.
746
cb93f9be
PE
747 * alloc.c (string_overflow): New function.
748 (Fmake_string): Use it. This doesn't change behavior, but saves
749 a few bytes and will simplify future changes.
750 * character.c (string_escape_byte8): Likewise.
751 * lisp.h (string_overflow): New decl.
752
1a1f3366
PE
753 Fixups, following up to the user-interface timestamp change.
754 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
755 for UI timestamps, instead of unsigned long.
9fbd6841
PE
756 * msdos.c (mouse_get_pos): Likewise.
757 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
758 * w32gui.h (Time): Define by including "systime.h" rather than by
759 declaring it ourselves. (Bug#8664)
760
d4e3e4d3
PE
761 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
762 * image.c (clear_image_cache): Likewise.
763
f6a24d19
PE
764 * term.c (term_mouse_position): Don't assume time_t wraparound.
765
08dc5ae6
PE
766 Be more systematic about user-interface timestamps.
767 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
768 and sometimes 'EMACS_UINT', to represent these timestamps.
769 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
770 This makes the code easier to follow, and makes it easier to catch
771 integer overflow bugs such as Bug#8664.
772 * frame.c (Fmouse_position, Fmouse_pixel_position):
773 Use Time, not unsigned long, for user-interface timestamps.
774 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
775 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
776 * keyboard.h (last_event_timestamp): Likewise.
777 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
778 * menu.h (xmenu_show): Likewise.
779 * term.c (term_mouse_position): Likewise.
780 * termhooks.h (struct input_event.timestamp): Likewise.
781 (struct terminal.mouse_position_hook): Likewise.
782 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
783 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
784 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
785 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
786 what it was before.
787 * menu.h, termhooks.h: Include "systime.h", for Time.
788
8e55734a
PE
789 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
790 Don't assume that the difference between two unsigned long values
791 can fit into an integer. At this point, we know button_down_time
792 <= event->timestamp, so the difference must be nonnegative, so
793 there's no need to cast the result if double-click-time is
794 nonnegative, as it should be; check that it's nonnegative, just in
795 case. This bug is triggered when events are more than 2**31 ms
86db42d2 796 apart (about 25 days). (Bug#8664)
8e55734a 797
841f1b75 798 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 799 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 800
3e26f69c
PE
801 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
802 that always fit in int. Use a sentinel instead of a counter, to
803 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
804 * frame.h (struct frame): Use int for menu_bar_items_used
805 instead of EMACS_INT, since it always fits in int.
3e26f69c 806
5cc152c0
PE
807 * menu.c (grow_menu_items): Check for int overflow.
808
d89eb65e
PE
809 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
810
5235bd3e
PE
811 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
812 Before, the code was not consistent. These values cannot exceed
813 2**31 - 1 so there's no need to make them unsigned.
814 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
815 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
816 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
817 as modifiers.
818 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
819
bc827e23
PE
820 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
821 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
822 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
823 presumably because the widths might not match.
824
78eb494e
PE
825 * window.c (size_window): Avoid needless test at loop start.
826
04f2d78b
CB
8272011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
828
829 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
830
d2fc7e3d 8312011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
832
833 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
834
d2fc7e3d 8352011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
836
837 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
838 `width' to `bar_area_x' and `bar_area_width', respectively.
839 (x_scroll_run): Take account of fringe background extension.
840
04f2d78b
CB
841 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
842 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
843 `bar_area_width', respectively.
844 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
845 background extension.
846
79b70037
GM
8472011-05-10 Jim Meyering <meyering@redhat.com>
848
849 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
850
2f142cc5
JB
8512011-05-10 Juanma Barranquero <lekktu@gmail.com>
852
853 * image.c (Finit_image_library): Return t for built-in image types,
854 like pbm and xbm. (Bug#8640)
855
57679c86
AS
8562011-05-09 Andreas Schwab <schwab@linux-m68k.org>
857
858 * w32menu.c (set_frame_menubar): Fix submenu allocation.
859
888c9e86
EZ
8602011-05-07 Eli Zaretskii <eliz@gnu.org>
861
b0512a1d
EZ
862 * w32console.c (Fset_screen_color): Doc fix.
863 (Fget_screen_color): New function.
864 (syms_of_ntterm): Defsubr it.
865
7285dc67
EZ
866 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
867 unlink the temporary file if Fcall_process didn't create it in the
868 first place.
869 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
870 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
871 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
872 cue to call_process_cleanup not to close that handle.
873
4d3fcc8e
BK
8742011-05-07 Ben Key <bkey76@gmail.com>
875
876 * makefile.w32-in: The bootstrap-temacs rule now makes use of
877 one of two shell specific rules, either bootstrap-temacs-CMD or
878 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
879 to the previous implementation of the bootstrap-temacs rule.
880 The bootstrap-temacs-CMD rule is similar to the previous
881 implementation of the bootstrap-temacs rule except that it
882 makes use of the ESC_CFLAGS variable instead of the CFLAGS
883 variable.
884
885 These changes, along with some changes to nt/configure.bat,
886 nt/gmake.defs, and nt/nmake.defs, are required to extend my
887 earlier fix to add support for --cflags and --ldflags options
888 that include quotes so that it works whether make uses cmd or
889 sh as the shell.
890
b4289b64
MA
8912011-05-06 Michael Albinus <michael.albinus@gmx.de>
892
893 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
894 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
895 is a constant.
896 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
897 a string. Handle both cases.
898 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
899 (Fdbus_register_method): Use Qinvalid_function.
900
af4c0e28
JB
9012011-05-06 Juanma Barranquero <lekktu@gmail.com>
902
903 * makefile.w32-in: Update dependencies.
904 (LISP_H): Add inttypes.h and stdin.h.
905 (PROCESS_H): Add unistd.h.
906
c51453d9
EZ
9072011-05-06 Eli Zaretskii <eliz@gnu.org>
908
909 * lread.c: Include limits.h (fixes the MS-Windows build broken by
910 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
911
8ff0ac3c 9122011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 913
4c4b566b
PE
914 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
915
aab2b9b5
PE
916 * term.c (vfatal): Remove stray call to va_end.
917 It's not needed and the C Standard doesn't allow it here anyway.
918
c378da0b
PE
919 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
920 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
921
288b08c7
PE
922 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
923 bytes.
924
e3601888
PE
925 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
926
db6c0e74
PE
927 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
928
dd5963ea
PE
929 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
930
88c9450f
PE
931 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
932
2f9442b8
PE
933 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
934
c032b5f8
PE
935 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
936 * charset.c (Fdefine_charset_internal): Don't initialize
937 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 938 32-bit int (Bug#8600).
a108c10b
PE
939
940 * lread.c (read_integer): Be more consistent with string-to-number.
941 Use string_to_number to do the actual conversion; this avoids
942 rounding errors and fixes some other screwups. Without this fix,
943 for example, #x1fffffffffffffff was misread as -2305843009213693952.
944 (digit_to_number): Move earlier, for benefit of read_integer.
945 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 946 not a digit in any supported base. (Bug#8602)
a108c10b 947
ad5f9eea
PE
948 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
949
aec1708a
PE
950 * dispnew.c (scrolling_window): Return 1 if we scrolled,
951 to match comment at start of function. This also removes a
952 GCC warning about overflow in a 32+64-bit port.
953
47be4ab5
PE
954 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
955
371cac43
PE
956 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
957 Reported by Stefan Monnier in
958 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
959 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
960 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 961
d01a7826
PE
962 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
963 (EMACS_UINTPTR): Likewise, with uintptr_t.
964
7fd47d5c
PE
965 * lisp.h: Prefer 64-bit EMACS_INT if available.
966 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
967 on 32-bit hosts that have 64-bit int, so that they can access
968 large files.
122b0c86
PE
969 However, temporarily disable this change unless the temporary
970 symbol WIDE_EMACS_INT is defined.
7fd47d5c 971
8727937b
PE
972 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
973
8ac068ac
PE
974 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
975 This removes an assumption that EMACS_INT and long are the same
976 width as pointers. The assumption is true for Emacs porting targets
977 now, but we want to make other targets possible.
978 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
979 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
980 In the rest of the code, change types of integers that hold casted
981 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
982 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
983 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
984 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
985 No need to cast type when ORing.
986 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
987 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
988 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
989 assume EMACS_INT is the same width as char *.
990 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
991 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
992 Remove no-longer-needed casts.
993 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
994 (xg_tool_bar_help_callback, xg_make_tool_item):
995 Use EMACS_INTPTR to hold an integer
996 that will be cast to void *; this can avoid a GCC warning
997 if EMACS_INT is not the same width as void *.
998 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
999 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1000 (current_message_1, set_message_1):
1001 Use a local to convert to proper width without a cast.
1002 * xmenu.c (dialog_selection_callback): Likewise.
1003
ede49d71
PE
1004 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1005 Also, don't assume VALBITS / RAND_BITS is less than 5,
1006 and don't rely on undefined behavior when shifting a 1 left into
1007 the sign bit.
1008 * lisp.h (get_random): Change signature to match.
1009
2f30ecd0
PE
1010 * lread.c (hash_string): Use size_t, not int, for hash computation.
1011 Normally we prefer signed values; but hashing is special, because
1012 it's better to use unsigned division on hash table sizes so that
1013 the remainder is nonnegative. Also, size_t is the natural width
1014 for hashing into memory. The previous code used 'int', which doesn't
1015 retain enough info to hash well into very large tables.
1016 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1017
2a866e7b
PE
1018 * dbusbind.c: Don't possibly lose pointer info when converting.
1019 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1020 Use XPNTR rather than XHASH, so that the high-order bits of
1021 the pointer aren't lost when converting through void *.
1022
51639eac
PE
1023 * eval.c (Fautoload): Don't double-shift a pointer.
1024
92394119
PE
1025 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1026
dbdb9a7c
JB
10272011-05-06 Juanma Barranquero <lekktu@gmail.com>
1028
1029 * gnutls.c (DEF_GNUTLS_FN):
1030 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1031
db7a0b4f
AS
10322011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1033
1034 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1035 marker. (Bug#8610)
1036
f7ff1b0f 10372011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1038
1039 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1040 New version that can reserve upto 2GB of heap space.
1041
f7ff1b0f 10422011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1043
1044 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1045
639c109b
TZ
10462011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1047
1048 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1049 `gnutls_certificate_set_x509_key_file'.
1050
d2127135
JB
10512011-05-05 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1054 Update dependencies.
1055
e968f4f3
JB
10562011-05-04 Juanma Barranquero <lekktu@gmail.com>
1057
1058 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1059 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1060 Remove unused parameter `fildes'.
1061 * process.c (read_process_output, send_process): Don't pass it.
1062
84d358f0
JB
10632011-05-04 Juanma Barranquero <lekktu@gmail.com>
1064
1065 Fix previous change: the library cache is defined in w32.c.
1066 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1067 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1068
0898ca10
JB
10692011-05-04 Juanma Barranquero <lekktu@gmail.com>
1070
1071 Implement dynamic loading of GnuTLS on Windows.
1072
1073 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1074 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1075 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1076 Declare.
1077
1078 * gnutls.c (Qgnutls_dll): Define.
1079 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1080 (gnutls_*): Declare function pointers.
1081 (init_gnutls_functions): New function to initialize function pointers.
1082 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1083 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1084 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1085 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1086 (emacs_gnutls_write, emacs_gnutls_read)
1087 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1088 (Fgnutls_available_p): New function.
1089 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1090 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1091 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1092
1093 * image.c: Include w32.h.
1094 (Vimage_type_cache): Delete.
1095 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1096 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1097 (w32_delayed_load): Move to w32.c.
1098
1099 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1100
1101 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1102 (w32_delayed_load): Move from image.c. When loading a library, record
1103 its filename in the :loaded-from property of the library id.
1104 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1105 Initialize and staticpro them.
1106 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1107
1108 * process.c: Include lisp.h before w32.h, not after.
1109 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1110 instead of gnutls_record_check_pending.
1111
1112 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1113
ff4de4aa
TZ
11142011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1115
1116 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1117 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1118 as passed in.
1119
abe95abb
JD
11202011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1121
1122 * xterm.c (x_set_frame_alpha): Do not set property on anything
1123 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1124
e16e55d4
JB
11252011-05-02 Juanma Barranquero <lekktu@gmail.com>
1126
1127 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1128
bafcf6a5
JB
11292011-05-02 Juanma Barranquero <lekktu@gmail.com>
1130
1131 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1132 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1133 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1134 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1135 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1136 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1137 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1138 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1139 (Qgnutls_bootprop_callbacks_verify): Make static.
1140
e7a6747f
AS
11412011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1142
19ed11ba
AS
1143 * callproc.c: Indentation fixup.
1144
e7a6747f 1145 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1146 (wait_for_termination, interruptible_wait_for_termination):
1147 Move after wait_for_termination_1.
e7a6747f 1148
1ef14cb4
LMI
11492011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1150
1151 * sysdep.c (interruptible_wait_for_termination): New function
1152 which is like wait_for_termination, but allows keyboard
1153 interruptions.
1154
1155 * callproc.c (Fcall_process): Add (:file "file") as an option for
1156 the STDOUT buffer.
1157 (Fcall_process_region): Ditto.
1158
330d880c
EZ
11592011-04-30 Eli Zaretskii <eliz@gnu.org>
1160
8db90b73
EZ
1161 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1162 rather than `XVECTOR (FOO)->size'.
1163
330d880c
EZ
1164 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1165 inttypes.h, as a gnulib replacement is used if it not available in
1166 system headers.
1167
15cbd324
EZ
11682011-04-21 Eli Zaretskii <eliz@gnu.org>
1169
1170 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1171 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1172 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1173
1174 * coding.c (coding_alloc_by_realloc): Error out if destination
1175 will grow beyond MOST_POSITIVE_FIXNUM.
1176 (decode_coding_emacs_mule): Abort if there isn't enough place in
1177 charbuf for the composition carryover bytes. Reserve an extra
1178 space for up to 2 characters produced in a loop.
1179 (decode_coding_iso_2022): Abort if there isn't enough place in
1180 charbuf for the composition carryover bytes.
1181
11822011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1183
ae940cca
EZ
1184 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1185 aborting when %lld or %lll format is passed.
1186 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1187 %llo or %llx format is passed. (Bug#8545)
1188
03ab8921
EZ
1189 * window.c (window_scroll_line_based): Use a marker instead of
1190 simple variables to record original value of point. (Bug#7952)
1191
afda1437
EZ
1192 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1193 produced by %s or %c overflows available buffer space. (Bug#8545)
1194
f76dee0c
PE
11952011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1196
1197 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1198 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1199
fdc5744d
JB
12002011-04-28 Juanma Barranquero <lekktu@gmail.com>
1201
1202 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1203
638f053a
JB
12042011-04-28 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * keyboard.c (Qdelayed_warnings_hook): Define.
1207 (command_loop_1): Run `delayed-warnings-hook'
1208 if Vdelayed_warnings_list is non-nil.
1209 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1210 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1211
d178f871
EZ
12122011-04-28 Eli Zaretskii <eliz@gnu.org>
1213
1214 * doprnt.c (doprnt): Don't return value smaller than the buffer
1215 size if the message was truncated. (Bug#8545).
1216
b124fd93
JB
12172011-04-28 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1220 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1221
e810457d
PE
12222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1225
ea51cceb
JB
12262011-04-27 Juanma Barranquero <lekktu@gmail.com>
1227
1228 * makefile.w32-in: Update dependencies.
1229
94dcfacf
EZ
12302011-04-27 Eli Zaretskii <eliz@gnu.org>
1231
1232 Improve `doprnt' and its usage. (Bug#8545)
1233 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1234 `format_end'. Remove support for %l as a conversion specifier.
1235 Don't use xrealloc. Improve diagnostics when the %l size modifier
1236 is used. Update the commentary.
1237
1238 * eval.c (verror): Simplify calculation of size_t.
1239
1240 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1241 messages.
1242
f61f41d7
PE
12432011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1244
1245 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1246 change.
1247
96fb4434
PE
12482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1251 This makes this file independent of the recent pseudovector change.
1252
671875da 12532011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1254
69e9b5a3
PE
1255 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1256
b5f869a7 1257 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1258 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1259 Remove unused local.
c8926152 1260 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1261
841a1577 1262 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1263 GCC 4.6.0 optimizes based on type-based alias analysis.
1264 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1265 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1266 != &v->size, and therefore "v->size = 1; b->size = 2; return
1267 v->size;" must therefore return 1. This assumption is incorrect
1268 for Emacs, since it type-puns struct Lisp_Vector * with many other
1269 types. To fix this problem, this patch adds a new type struct
f904488f 1270 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1271 and pseudovectors, and helps optimizing compilers not get fooled
1272 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1273 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1274 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1275 the size member.
eab3844f
PE
1276 (XSETPVECTYPE): Rewrite in terms of new macro.
1277 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1278 This is a bit clearer, and further avoids the possibility of
1279 undesirable aliasing.
1280 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1281 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1282 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1283 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1284 (ASIZE): Now uses header.size rather than size.
1285 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1286 to avoid the hassle of writing XVECTOR (foo)->header.size.
1287 (struct vectorlike_header): New type.
eab3844f
PE
1288 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1289 object, to help avoid aliasing.
1290 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1291 (SUBRP): Likewise, since Lisp_Subr is a special case.
1292 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1293 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1294 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1295 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1296 changed to be "header.size" and "header.next".
1297 * buffer.h (struct buffer): Likewise.
1298 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1299 * frame.h (struct frame): Likewise.
1300 * process.h (struct Lisp_Process): Likewise.
1301 * termhooks.h (struct terminal): Likewise.
1302 * window.c (struct save_window_data, struct saved_window): Likewise.
1303 * window.h (struct window): Likewise.
1304 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1305 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1306 * buffer.c (init_buffer_once): Likewise.
1307 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1308 special case.
1309 * process.c (Fformat_network_address): Use local var for size,
1310 for brevity.
1311
0df1eac5
PE
1312 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1313
847ab9d1 1314 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1315 * data.c (atof): Remove decl; no longer used or needed.
1316 (digit_to_number): Move to lread.c.
1317 (Fstring_to_number): Use new string_to_number function, to be
1318 consistent with how the Lisp reader treats infinities and NaNs.
1319 Do not assume that floating-point numbers represent EMACS_INT
1320 without losing information; this is not true on most 64-bit hosts.
1321 Avoid double-rounding errors, by insisting on integers when
1322 parsing non-base-10 numbers, as the documentation specifies.
1323 * lisp.h (string_to_number): New decl, replacing ...
1324 (isfloat_string): Remove.
bc0a5c13 1325 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1326 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1327 appears to have been a coding error. Similarly, do not accept
1328 strings like +-1e0 as floating point numbers. Do not report
1329 overflow for integer overflows unless the base is not 10 which
1330 means we have no simple and reliable way to continue.
1331 Break out the floating-point parsing into a new
1332 function string_to_number, so that Fstring_to_number parses
1333 floating point numbers consistently with the Lisp reader.
04f2d78b 1334 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1335 (E_CHAR, EXP_INT): Remove, replacing with ...
1336 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1337 (string_to_number): New function, replacing isfloat_string.
1338 This function checks for valid syntax and produces the resulting
1339 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1340 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1341 so that overflow for non-base-10 numbers is reported only when
1342 there's no portable and simple way to convert to floating point.
452f4150 1343
67769ffc
PE
1344 * textprop.c (set_text_properties_1): Rewrite for clarity,
1345 and to avoid GCC warning about integer overflow.
1346
c20db43f
PE
1347 * intervals.h (struct interval): Use EMACS_INT for members
1348 where EMACS_UINT might cause problems. See
1349 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1350 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1351 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1352 All uses changed.
37aa2f85
PE
1353 (offset_intervals): Tell GCC not to worry about length overflow
1354 when negating a negative length.
c20db43f 1355
2538aa2f
PE
1356 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1357 (overrun_check_free): Likewise.
1358
f2d3008d
PE
1359 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1360 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1361 word size.
1362
ec8df744
PE
1363 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1364 (gnutls_make_error): Rename local to avoid shadowing.
1365 (gnutls_emacs_global_deinit): ifdef out; not used.
1366 (Fgnutls_boot): Use const for pointer to readonly storage.
1367 Comment out unused local. Fix pointer signedness problems.
1368
640ee02d
PE
1369 * lread.c (openp): Don't stuff size_t into an 'int'.
1370 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1371 about possible signed overflow.
1372
6048fb2a
PE
1373 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1374 (GDK_KEY_g): Don't define if already defined.
1375 (xg_prepare_tooltip): Avoid pointer signedness problem.
1376 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1377
fa3c87e1
PE
1378 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1379 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1380
2172544b
PE
1381 * xfns.c (Fx_window_property): Simplify a bit,
1382 to make a bit faster and to avoid GCC 4.6.0 warning.
1383 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1384
9b821a21
PE
1385 * fns.c (internal_equal): Don't assume size_t fits in int.
1386
3c616cfa
PE
1387 * alloc.c (compact_small_strings): Tighten assertion a little.
1388
c2982e87
PE
1389 Replace pEd with more-general pI, and fix some printf arg casts.
1390 * lisp.h (pI): New macro, generalizing old pEd macro to other
1391 conversion specifiers. For example, use "...%"pI"d..." rather
1392 than "...%"pEd"...".
1393 (pEd): Remove. All uses replaced with similar uses of pI.
1394 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1395 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1396 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1397 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1398 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1399 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1400 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1401 64-bit hosts.
1402 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1403 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1404 * print.c (safe_debug_print, print_object): Likewise.
1405 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1406 to int.
6f04d126
PE
1407 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1408 avoiding the 0 flag, which is not portable.
c2982e87
PE
1409 * process.c (Fmake_network_process): Use pI to avoid cast.
1410 * region-cache.c (pp_cache): Likewise.
1411 * xdisp.c (decode_mode_spec): Likewise.
1412 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1413 behavior on 64-bit hosts with printf arg.
6f04d126 1414 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1415 (x_stop_queuing_selection_requests): Likewise.
1416 (x_get_window_property): Don't truncate byte count to an 'int'
1417 when tracing.
0b432f21 1418
5e073ec7
PE
1419 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1420 here, since it parses constructs like leading '-' and spaces,
1421 which are not wanted; and it overflows with large numbers.
1422 Instead, simply match F[0-9]+, which is what is wanted anyway.
1423
36372bf9
PE
1424 * alloc.c: Remove unportable assumptions about struct layout.
1425 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1426 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1427 (allocate_vectorlike, make_pure_vector): Use the new macros,
1428 plus offsetof, to remove unportable assumptions about struct layout.
1429 These assumptions hold on all porting targets that I know of, but
1430 they are not guaranteed, they're easy to remove, and removing them
1431 makes further changes easier.
1432
0b432f21
PE
1433 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1434 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1435 (string_overrun_cookie): Now const. Use initializers that
1436 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1437 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1438 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1439 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1440 multiple of sizeof (EMACS_INT); it need not be, if
1441 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1442 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1443
895009e1
JB
14442011-04-26 Juanma Barranquero <lekktu@gmail.com>
1445
1446 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1447
6a7a1b0b
TZ
14482011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1449
1450 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1451 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1452 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1453
841a1577 14542011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1455
1456 * lisp.h (Qdebug): List symbol.
895009e1 1457 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1458 * keyboard.c (debug-on-event): New variable.
1459 (handle_user_signal): Break into debugger when debug-on-event
1460 matches the current signal symbol.
1461
f2d3ba6f
DN
14622011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1463
1464 * alloc.c (check_sblock, check_string_bytes)
1465 (check_string_free_list): Convert to standard C.
1466
42ce4c63
TZ
14672011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1468
1469 * w32.c (emacs_gnutls_push): Fix typo.
1470
825cd63c
EZ
14712011-04-25 Eli Zaretskii <eliz@gnu.org>
1472
fb11d64d
EZ
1473 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1474 "cast to pointer from integer of different size".
1475
825cd63c
EZ
1476 Improve doprnt and its use in verror. (Bug#8545)
1477 * doprnt.c (doprnt): Document the set of format control sequences
1478 supported by the function. Use SAFE_ALLOCA instead of always
1479 using `alloca'.
1480
1481 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1482 is one byte too soon. Don't use xrealloc; instead xfree and
1483 xmalloc anew.
1484
e061a11b
TZ
14852011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1486
1487 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1488 callbacks stage.
1489
1490 * gnutls.c: Renamed global_initialized to
1491 gnutls_global_initialized. Added internals for the
1492 :verify-hostname-error, :verify-error, and :verify-flags
1493 parameters of `gnutls-boot' and documented those parameters in the
1494 docstring. Start callback support.
1495 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1496 unless a fatal error occured. Call gnutls_alert_send_appropriate
1497 on error. Return error code.
1498 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1499 (emacs_gnutls_read): Likewise.
1500 (Fgnutls_boot): Return handshake error code.
1501 (emacs_gnutls_handle_error): New function.
1502 (wsaerror_to_errno): Likewise.
1503
1504 * w32.h (emacs_gnutls_pull): Add prototype.
1505 (emacs_gnutls_push): Likewise.
1506
1507 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1508 (emacs_gnutls_push): Likewise.
1509
15102011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1511
1512 * process.c (wait_reading_process_output): Check if GnuTLS
1513 buffered some data internally if no FDs are set for TLS
1514 connections.
1515
1516 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1517 (LIBS): Link to USER_LIBS.
1518 ($(BLD)/gnutls.$(0)): New target.
1519
fa6996bc
EZ
15202011-04-24 Eli Zaretskii <eliz@gnu.org>
1521
eb35682e
EZ
1522 * xdisp.c (handle_single_display_spec): Rename the
1523 display_replaced_before_p argument into display_replaced_p, to
1524 make it consistent with the commentary. Fix typos in the
1525 commentary.
1526
e2ad650c
EZ
1527 * textprop.c (syms_of_textprop): Remove dead code.
1528 (copy_text_properties): Delete obsolete commentary about an
1529 interface that was deleted long ago. Fix typos in the description
1530 of arguments.
1531
1b2de274
EZ
1532 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1533 to changes in oldXMenu/XMenu.h from 2011-04-16.
1534 <menu_help_message, prev_menu_help_message>: Constify.
1535 (IT_menu_make_room): menu->help_text is now `const char **';
1536 adjust.
1537
1538 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1539 to changes in oldXMenu/XMenu.h from 2011-04-16.
1540 (struct XMenu): Declare `help_text' `const char **'.
1541
1542 * xfaces.c <Qunspecified>: Make extern again.
1543
1544 * syntax.c: Include sys/types.h before including regex.h, as
1545 required by Posix.
1546
762b15be
EZ
1547 * doc.c (get_doc_string): Improve the format passed to `error'.
1548
1549 * doprnt.c (doprnt): Improve commentary.
1550
1551 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1552
1553 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1554 them with etags.
1555
f1052e5d
EZ
1556 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1557 changes in globals.h immediately force recompilation.
762b15be
EZ
1558 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1559 $(CURDIR)/s/ms-w32.h.
1560 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1561
fa6996bc
EZ
1562 * character.c (Fchar_direction): Function deleted.
1563 (syms_of_character): Don't defsubr it.
1564 <char-direction-table>: Deleted.
1565
e6c3da20
EZ
15662011-04-23 Eli Zaretskii <eliz@gnu.org>
1567
1568 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1569 * doprnt.c: Include limits.h.
1570 (SIZE_MAX): New macro.
04f2d78b
CB
1571 (doprnt): Return a size_t value. 2nd arg is now size_t.
1572 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1573 Improve overflow protection. Support `l' modifier for integer
1574 conversions. Support %l conversion. Don't assume an EMACS_INT
1575 argument for integer conversions and for %c.
1576
1577 * lisp.h (doprnt): Restore prototype.
1578
1579 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1580 $(SRC)/character.h.
1581
1582 * Makefile.in (base_obj): Add back doprnt.o.
1583
1584 * deps.mk (doprnt.o): Add back prerequisites.
1585 (callint.o): Depend on character.h.
1586
1587 * eval.c (internal_lisp_condition_case): Include the handler
1588 representation in the error message.
1589 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1590 when breaking from the loop.
1591
1592 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1593
1594 * callint.c (Fcall_interactively): When displaying error message
1595 about invalid control letter, pass the character's codepoint, not
1596 a pointer to its multibyte form. Improve display of the character
1597 in octal and display also its hex code.
1598
1599 * character.c (char_string): Use %x to display the (unsigned)
1600 codepoint of an invalid character, to avoid displaying a bogus
1601 negative value.
1602
1603 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1604 `error', not SYMBOL_NAME itself.
1605
1606 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1607 character arguments to `error'.
1608
1609 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1610 to `error' in error message about FINAL_CHAR argument. Make sure
1611 FINAL_CHAR is a character, and use %c when it is passed as
1612 argument to `error'.
1613
4ffd0d6b 16142011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1615
1616 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1617
1618 * w32.c: Include <time.h>.
1619 (sys_localtime): New function.
1620
4ffd0d6b 16212011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1622
1623 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1624
4ffd0d6b 1625 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1626
4ffd0d6b 16272011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1628
4ffd0d6b
GM
1629 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1630 zombies (Bug#8467).
aac0c6e3 1631
04c56954
EZ
16322011-04-19 Eli Zaretskii <eliz@gnu.org>
1633
1634 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1635 gl_state.e_property when gl_state.object is Qt.
1636
1637 * insdel.c (make_gap_larger): Remove limitation of buffer size
1638 to <= INT_MAX.
1639
16a43933
CY
16402011-04-18 Chong Yidong <cyd@stupidchicken.com>
1641
1642 * xdisp.c (lookup_glyphless_char_display)
1643 (produce_glyphless_glyph): Handle cons cell entry in
1644 glyphless-char-display.
1645 (Vglyphless_char_display): Document it.
1646
1647 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1648 glyphless-char-display.
1649
4581706e
CY
16502011-04-17 Chong Yidong <cyd@stupidchicken.com>
1651
1652 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1653
1654 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1655
1656 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1657 definition for no-X builds.
1658
4887c6e2 16592011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1660
fd35b6f9
PE
1661 Static checks with GCC 4.6.0 and non-default toolkits.
1662
5c1ccb01
PE
1663 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1664
006c5daa
PE
1665 * process.c (keyboard_bit_set): Define only if SIGIO.
1666 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1667 (send_process): Repair possible setjmp clobbering.
1668
efc736d3
PE
1669 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1670
4e2fe2e6
PE
1671 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1672
f97334a2
PE
1673 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1674
4e75f29d
PE
1675 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1676 Define only if needed.
1677
90efadd1
PE
1678 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1679 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1680 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1681
3c647824
PE
1682 * dispextern.h (struct redisplay_interface): Rename param
1683 to avoid shadowing.
e264f262 1684 * termhooks.h (struct terminal): Likewise.
761383f4 1685 * xterm.c (xembed_send_message): Likewise.
3c647824 1686
b58c5c4a
PE
1687 * insdel.c (make_gap_smaller): Define only if
1688 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1689
cad59032
PE
1690 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1691 it.
1692
c339dc2e
PE
1693 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1694 so that we aren't warned about unused symbols.
1695
91a3e27b
PE
1696 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1697
399c71d3 1698 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1699
8ffc96f5
PE
1700 * xfns.c (x_real_positions): Mark locals as initialized.
1701
eef9bc79
PE
1702 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1703
098db9dd
PE
1704 * xterm.c: Fix problems found by static analysis with other toolkits.
1705 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1706 (x_dispatch_event): Declare static if USE_GTK, and
1707 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1708 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1709 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1710 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1711 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1712
eb18f6cc
PE
1713 * xmenu.c (menu_help_callback): Pointer type fixes.
1714 Use const pointers when pointing at readonly data. Avoid pointer
1715 signedness clashes.
1716 (FALSE): Remove unused macro.
1717 (update_frame_menubar): Remove unused decl.
1718
1fe72bf8
PE
1719 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1720
60d9e1db
PE
1721 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1722 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1723 (single_menu_item): Rename local to avoid shadowing.
1724
39261c26
PE
1725 * keyboard.c (make_lispy_event): Remove unused local var.
1726
018c5e19
PE
1727 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1728 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1729
63d2b86e
PE
1730 * bitmaps: Change bitmaps from unsigned char back to the X11
1731 compatible char. Avoid the old compiler warnings about
1732 out-of-range initializers by using, for example, '\xab' rather
1733 than 0xab.
1734
aefd87e1
PE
1735 * xgselect.c (xgselect_initialize): Check vs interface
1736 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1737
bf501fb9
PE
1738 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1739
e9829fdf
PE
1740 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1741 to read-only memory.
1742
1086c095
PE
1743 * fns.c (vector): Remove; this old hack is no longer needed.
1744
2baccd04 1745 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1746 Remove unused var.
dde42981 1747 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1748
72391843 1749 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1750
436c16df 1751 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1752 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1753 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1754
92bb796d 1755 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1756 (x_term_init): Remove local to avoid shadowing.
92bb796d 1757
764430a3 1758 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1759
1760 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1761 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1762
d1dfb56c
EZ
17632011-04-16 Eli Zaretskii <eliz@gnu.org>
1764
c4354cb4
EZ
1765 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1766
d1dfb56c
EZ
1767 Fix regex.c, syntax.c and friends for buffers > 2GB.
1768 * syntax.h (struct gl_state_s): Declare character position members
1769 EMACS_INT.
1770
1771 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1772
04f2d78b
CB
1773 * textprop.c (verify_interval_modification, interval_of):
1774 Declare arguments EMACS_INT.
d1dfb56c
EZ
1775
1776 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1777 EMACS_INT.
1778
1779 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1780
1781 * indent.c (Fvertical_motion): Local variable it_start is now
1782 EMACS_INT.
1783
1784 * regex.c (re_match, re_match_2, re_match_2_internal)
1785 (bcmp_translate, regcomp, regexec, print_double_string)
1786 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1787 (re_compile_pattern, re_exec): Declare arguments and local
1788 variables `size_t' and `ssize_t' and return values `regoff_t', as
1789 appropriate.
1790 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1791 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1792 <compile_stack_type>: `size' and `avail' are now `size_t'.
1793
1794 * regex.h <regoff_t>: Use ssize_t, not int.
1795 (re_search, re_search_2, re_match, re_match_2): Arguments that
1796 specify buffer/string position and length are now ssize_t and
1797 size_t. Return type is regoff_t.
1798
613052cd
BK
17992011-04-16 Ben Key <bkey76@gmail.com>
1800
1801 * nsfont.m: Fixed bugs in ns_get_family and
1802 ns_descriptor_to_entity that were caused by using free to
1803 deallocate memory blocks that were allocated by xmalloc (via
1804 xstrdup). This caused Emacs to crash when compiled with
1805 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1806 --enable-checking=xmallocoverrun). xfree is now used to
1807 deallocate these memory blocks.
1808
4170f62f 18092011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1810
71b41406
PE
1811 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1812
9587a89d
PE
1813 emacs_write: Accept and return EMACS_INT for sizes.
1814 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1815 et seq.
1816 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1817 Accept and return EMACS_INT.
1818 (emacs_gnutls_write): Return the number of bytes written on
1819 partial writes.
1820 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1821 (emacs_read, emacs_write): Remove check for negative size, as the
1822 Emacs source code has been audited now.
9587a89d
PE
1823 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1824 (emacs_read, emacs_write): Use it.
273a5f82
PE
1825 * process.c (send_process): Adjust to the new signatures of
1826 emacs_write and emacs_gnutls_write. Do not attempt to store
1827 a byte offset into an 'int'; it might overflow.
9587a89d 1828 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1829
3e047f51
PE
1830 * sound.c: Don't assume sizes fit in 'int'.
1831 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1832 Return EMACS_INT, not int.
3e047f51 1833 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1834 Accept EMACS_INT, not int.
1835 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1836 record read return values.
1837
cc39a9db
BK
18382011-04-15 Ben Key <bkey76@gmail.com>
1839
c9d0ec6d
JB
1840 * keyboard.c (Qundefined): Don't declare static since it is used
1841 in nsfns.m.
1842 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1843 static since they are used in nsfont.m.
cc39a9db 1844
6c60eb9f
SM
18452011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1846
1847 * process.c (Qprocessp): Don't declare static.
1848 * lisp.h (Qprocessp): Declare again.
1849
7990b61a
JB
18502011-04-15 Juanma Barranquero <lekktu@gmail.com>
1851
1852 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1853
5d4cb038
PE
18542011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1855
8bd7b830 1856 Improve C-level modularity by making more things 'static'.
cd64ea1d 1857
e3b27b31
PE
1858 Don't publish debugger-only interfaces to other modules.
1859 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1860 (verify_bytepos, count_markers): Move decls to the only modules
1861 that need them.
1862 * region-cache.h (pp_cache): Likewise.
1863 * window.h (check_all_windows): Likewise.
1864 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1865
5d4cb038
PE
1866 * sysdep.c (croak): Now static, if
1867 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1868 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1869
1870 * alloc.c (refill_memory_reserve): Now static if
1871 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1872 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1873
e87b6180
PE
1874 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1875 Define only if USE_LUCID.
1876
ac64929e
PE
1877 * xrdb.c (x_customization_string, x_rm_string): Now static.
1878
6f37259d
PE
1879 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1880 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1881
1683e3ab
PE
1882 * xdisp.c (draw_row_with_mouse_face): Now static.
1883 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1884
de9c2632
PE
1885 * window.h (check_all_windows): Mark externally visible.
1886
2b96acb7
PE
1887 * window.c (window_deletion_count): Now static.
1888
1889 * undo.c: Make symbols static if they're not exported.
1890 (last_undo_buffer, last_boundary_position, pending_boundary):
1891 Now static.
1892
50436f33
PE
1893 * textprop.c (interval_insert_behind_hooks): Now static.
1894 (interval_insert_in_front_hooks): Likewise.
1895
64520e5c
PE
1896 * term.c: Make symbols static if they're not exported.
1897 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1898 (max_frame_lines, tty_set_terminal_modes):
1899 (tty_reset_terminal_modes, tty_turn_off_highlight):
1900 (get_tty_terminal): Now static.
1901 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1902 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1903 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1904 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1905 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1906
1fa53021
PE
1907 * sysdep.c: Make symbols static if they're not exported.
1908 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1909 Now static.
1910 (sigprocmask_set, full_mask): Remove; unused.
1911 (wait_debugging): Mark as visible.
1912 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1913 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1914
d4b43b22
PE
1915 * syntax.c (syntax_temp): Define only if !__GNUC__.
1916
b7c513d0
PE
1917 * sound.c (current_sound_device, current_sound): Now static.
1918
989b29ad
PE
1919 * search.c (searchbufs, searchbuf_head): Now static.
1920
13a55a78
PE
1921 * scroll.c (scroll_cost): Remove; unused.
1922 * dispextern.h (scroll_cost): Remove decl.
1923
de68a1fc
PE
1924 * region-cache.h (pp_cache): Mark as externally visible.
1925
40ccffa6
PE
1926 * process.c: Make symbols static if they're not exported.
1927 (process_tick, update_tick, create_process, chan_process):
1928 (Vprocess_alist, proc_buffered_char, datagram_access):
1929 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1930 (deactivate_process): Mark defn as static, as well as decl.
1931 * lisp.h (create_process): Remove decl.
1932 * process.h (chan_process, Vprocess_alist): Remove decls.
1933
ad64fc97
PE
1934 * print.c: Make symbols static if they're not exported.
1935 (print_depth, new_backquote_output, being_printed, print_buffer):
1936 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1937 (print_interval, print_number_index, initial_stderr_stream):
1938 Now static.
1939 * lisp.h (Fprinc): Remove decl.
1940 (debug_output_compilation_hack): Mark as externally visible.
1941
adddb265
PE
1942 * sysdep.c (croak): Move decl from here to syssignal.h.
1943 * syssignal.h (croak): Put it here, so the API can be checked when
1944 'croak' is called from dissociate_if_controlling_tty.
1945
1717ede2
PE
1946 * minibuf.c: Make symbols static if they're not exported.
1947 (minibuf_save_list, choose_minibuf_frame): Now static.
1948 * lisp.h (choose_minibuf_frame): Remove decl.
1949
fa5fb2bc
PE
1950 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1951
1e3890d1
PE
1952 * lread.c: Make symbols static if they're not exported.
1953 (read_objects, initial_obarray, oblookup_last_bucket_number):
1954 Now static.
1955 (make_symbol): Remove; unused.
1956 * lisp.h (initial_obarray, make_symbol): Remove decls.
1957
8a1414fa
PE
1958 * keyboard.c: Make symbols static if they're not exported.
1959 (single_kboard, recent_keys_index, total_keys, recent_keys):
1960 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1961 (this_single_command_key_start, echoing, last_auto_save):
1962 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1963 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1964 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1965 (Vlispy_mouse_stem, double_click_count):
1966 Now static.
1967 (force_auto_save_soon): Define only if SIGDANGER.
1968 (ignore_mouse_drag_p): Now static if
1969 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1970 (print_help): Remove; unused.
1971 (stop_character, last_timer_event): Mark as externally visible.
1972 * keyboard.h (ignore_mouse_drag_p): Declare only if
1973 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1974 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1975 * lisp.h (echoing): Remove decl.
1976 (force_auto_save_soon): Declare only if SIGDANGER.
1977 * xdisp.c (redisplay_window): Simplify code, to make it more
1978 obvious that ignore_mouse_drag_p is not accessed if !defined
1979 USE_GTK && !defined HAVE_NS.
1980
93ea6e8f
PE
1981 * intervals.c: Make symbols static if they're not exported.
1982 (merge_properties_sticky, merge_interval_right, delete_interval):
1983 Now static.
1984 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1985
77382fcc
PE
1986 * insdel.c: Make symbols static if they're not exported.
1987 However, leave prepare_to_modify_buffer alone. It's never
1988 called from outside this function, but that appears to be a bug.
1989 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1990 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1991 (adjust_after_replace_noundo): Remove; unused.
1992 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1993 (signal_before_change): Remove decls.
77382fcc 1994
9306c32e
PE
1995 * indent.c (val_compute_motion, val_vmotion): Now static.
1996
cd44d2eb
PE
1997 * image.c: Make symbols static if they're not exported.
1998 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1999 if USE_GTK.
2000 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2001 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2002
ad9a7a06
PE
2003 * fringe.c (standard_bitmaps): Now static.
2004 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2005
81626931
PE
2006 * frame.c: Make symbols static if they're not exported.
2007 (x_report_frame_params, make_terminal_frame): Now static.
2008 (get_frame_param): Now static, unless HAVE_NS.
2009 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2010 (x_get_resource_string): Remove; not used.
2011 * frame.h (make_terminal_frame, x_report_frame_params):
2012 (x_get_resource_string); Remove decls.
2013 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2014 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2015
239f9db9
PE
2016 * font.c, fontset.c: Make symbols static if they're not exported.
2017 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2018 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2019 * font.c (font_close_object): Now static.
2020 * font.h (font_close_object): Remove.
2021 * fontset.c (FONTSET_OBJLIST): Remove.
2022 (free_realized_fontset) #if-0 the body, which does nothing.
2023 (face_suitable_for_char_p): #if-0, as it's never called.
2024 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2025 * xfaces.c (face_at_string_position):
2026 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2027 since 0 is always ASCII.
2028
dfcf3579
PE
2029 * fns.c (weak_hash_tables): Now static.
2030
5045092b
PE
2031 * fileio.c: Make symbols static if they're not exported.
2032 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2033 (Vwrite_region_annotation_buffers): Now static.
2034
57a96f5c
PE
2035 * eval.c: Make symbols static if they're not exported.
2036 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2037 * lisp.h (backtrace_list): Remove decl.
2038
35f08c38
PE
2039 * emacs.c: Make symbols static if they're not exported.
2040 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2041 (fatal_error_code, fatal_error_signal_hook, standard_args):
2042 Now static.
2043 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2044 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2045 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2046 * lisp.h (fatal_error_signal_hook): Remove decl.
2047 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2048
f44bd759
PE
2049 * editfns.c: Move a (normally-unused) function to its only use.
2050 * editfns.c, lisp.h (get_operating_system_release): Remove.
2051 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2052 worth the hassle of breaking this out.
2053
b532497d
PE
2054 * xterm.c: Make symbols static if they're not exported.
2055 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2056 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2057 (x_destroy_window, x_delete_display):
2058 Now static.
2059 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2060 (x_mouse_leave): Remove; unused.
2061 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2062 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2063 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2064 Remove decls.
2065 (x_mouse_leave): Declare only if WINDOWSNT.
2066 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2067 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2068 USE_X_TOOLKIT.
2069
1675728f
PE
2070 * ftxfont.c: Make symbols static if they're not exported.
2071 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2072 HAVE_FREETYPE.
2073 * font.h (ftxfont_driver): Likewise.
2074
e4cebfca
PE
2075 * xfns.c: Make symbols static if they're not exported.
2076 (x_last_font_name, x_display_info_for_name):
2077 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2078 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2079 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2080 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2081 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2082 (last_show_tip_args): Now static.
2083 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2084 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2085 (x_screen_planes): Remove; unused.
2086 * dispextern.h (x_screen_planes): Remove decl.
2087
5bf46f05
PE
2088 * dispnew.c: Make symbols static if they're not exported.
2089 * dispextern.h (redraw_garbaged_frames, scrolling):
2090 (increment_row_positions): Remove.
2091 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2092 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2093 Now static.
2094 (redraw_garbaged_frames): Remove; unused.
2095
435f4c28
PE
2096 * xfaces.c: Make symbols static if they're not exported.
2097 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2098 Remove decls.
2099 * xterm.h (defined_color): Remove decls.
2100 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2101 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2102 (menu_face_changed_default, defined_color, free_realized_face):
2103 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2104 (ascii_face_of_lisp_face): Remove; unused.
2105
8524aef3
PE
2106 * xdisp.c: Make symbols static if they're not exported.
2107 * dispextern.h (scratch_glyph_row, window_box_edges):
2108 (glyph_to_pixel_coords, set_cursor_from_row):
2109 (get_next_display_element, set_iterator_to_next):
2110 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2111 (show_mouse_face): Remove decls
2112 * frame.h (message_buf_print): Likewise.
2113 * lisp.h (pop_message, set_message, check_point_in_composition):
2114 Likewise.
2115 * xterm.h (set_vertical_scroll_bar): Likewise.
2116 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2117 (message_buf_print, scratch_glyph_row, displayed_buffer):
2118 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2119 (get_next_display_element, show_mouse_face, window_box_edges):
2120 (frame_to_window_pixel_xy, check_point_in_composition):
2121 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2122 (glyph_to_pixel_coords): Remove; unused.
2123
16390cd2
PE
2124 * dired.c (file_name_completion): Now static.
2125
2126 * dbusbind.c (xd_in_read_queued_messages): Now static.
2127
a25f4dfa
PE
2128 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2129 * data.c (circular_list_error): Remove.
2130
14a9c8df
PE
2131 * commands.h (last_point_position, last_point_position_buffer):
2132 (last_point_position_window): Remove decls.
2133 * keyboard.c: Make these variables static.
2134
04f2d78b
CB
2135 * coding.h (coding, code_convert_region, encode_coding_gap):
2136 Remove decls.
74ab6df5
PE
2137 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2138 (iso_code_class, detect_coding, code_convert_region): Now static.
2139 (encode_coding_gap): Remove; unused.
2140
38dfbee1
PE
2141 * chartab.c (chartab_chars, chartab_bits): Now static.
2142
a2cb4e63
PE
2143 * charset.h (charset_iso_8859_1): Remove decl.
2144 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2145 Now static.
2146
127198fd
PE
2147 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2148 * ccl.c (Vccl_program_table): Now static.
2149 (check_ccl_update): Remove; unused.
2150
d85b608f
PE
2151 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2152 * category.h: ... from here.
2153 * category.c (check_category_table, set_category_set): Now static.
2154
31cd66f3
PE
2155 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2156 * lisp.h: Remove these decls.
2157
c358e587
PE
2158 * buffer.c (buffer_count): Remove unused var.
2159
e78aecca
PE
2160 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2161 so that it's not optimized away.
2162 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2163 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2164 exported only to the debugger.
2165
e192d7d3 2166 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2167 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2168
92470028
PE
2169 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2170 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2171 was inaccessible from Lisp.
2172 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2173 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2174
244ed907
PE
2175 alloc.c: Import and export fewer symbols, and remove unused items.
2176 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2177 is defined.
2178 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2179 it's not optimized away by whole-program optimization.
2180 (message_enable_multibyte, free_misc): Remove.
2181 (catchlist, handlerlist, mark_backtrace):
2182 Declare only if BYTE_MARK_STACK.
2183 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2184 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2185 (message_enable_multibyte): Remove decl.
2186 (free_misc, interval_free_list, float_block, float_block_index):
2187 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2188 (cons_free_list, last_marked_index):
2189 Now static.
2190 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2191 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2192 (mark_backtrace): Define only if BYTE_MARK_STACK.
2193 * xdisp.c (message_enable_multibyte): Now static.
2194
61c2b50e 2195 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2196 This makes it easier for human readers (and static analyzers)
2197 to see whether these variables are used from other modules.
2198 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2199 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2200 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2201 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2202 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2203 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2204 * xmenu.c, xselect.c:
2205 Declare Q* vars static if they are not used in other modules.
2206 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2207 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2208 Remove decls of unexported vars.
2209 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2210
95c82688
PE
2211 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2212
16a97296
PE
2213 Make Emacs functions such as Fatom 'static' by default.
2214 This makes it easier for human readers (and static analyzers)
2215 to see whether these functions can be called from other modules.
2216 DEFUN now defines a static function. To make the function external
2217 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2218 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2219 (Finit_image_library):
16a97296
PE
2220 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2221 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2222 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2223 Remove decls, since these functions are now static.
2224 (Funintern, Fget_internal_run_time): New decls, since these functions
2225 were already external.
95c82688 2226
16a97296
PE
2227 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2228 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2229 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2230 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2231 * keyboard.c, keymap.c, lread.c:
2232 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2233 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2234 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2235 Mark functions with DEFUE instead of DEFUN,
2236 if they are used in other modules.
2237 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2238 decls for now-static functions.
2239 * buffer.h (Fdelete_overlay): Remove decl.
2240 * callproc.c (Fgetenv_internal): Mark as internal.
2241 * composite.c (Fremove_list_of_text_properties): Remove decl.
2242 (Fcomposition_get_gstring): New forward static decl.
2243 * composite.h (Fcomposite_get_gstring): Remove decl.
2244 * dired.c (Ffile_attributes): New forward static decl.
2245 * doc.c (Fdocumntation_property): New forward static decl.
2246 * eval.c (Ffetch_bytecode): New forward static decl.
2247 (Funintern): Remove extern decl; now in .h file where it belongs.
2248 * fileio.c (Fmake_symbolic_link): New forward static decl.
2249 * image.c (Finit_image_library): New forward static decl.
2250 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2251 * intervals.h (Fprevious_property_change):
2252 (Fremove_list_of_text_properties): Remove decls.
2253 * keyboard.c (Fthis_command_keys): Remove decl.
2254 (Fcommand_execute): New forward static decl.
2255 * keymap.c (Flookup_key): New forward static decl.
2256 (Fcopy_keymap): Now static.
2257 * keymap.h (Flookup_key): Remove decl.
2258 * process.c (Fget_process): New forward static decl.
2259 (Fprocess_datagram_address): Mark as internal.
2260 * syntax.c (Fsyntax_table_p): New forward static decl.
2261 (skip_chars): Remove duplicate decl.
2262 * textprop.c (Fprevious_property_change): New forward static decl.
2263 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2264 Now internal.
2265 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2266 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2267
785bbd42
PE
2268 * editfns.c (Fformat): Remove unreachable code.
2269
8b913b57
AS
22702011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2271
2272 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2273 change. (Bug#8496)
2274
a6744a35
EZ
22752011-04-13 Eli Zaretskii <eliz@gnu.org>
2276
2277 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2278 when at ZV. (Bug#8487)
2279
e7974947
AS
22802011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2281
baad03f0
AS
2282 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2283 (Bug#8437)
2284 * keyboard.c (parse_tool_bar_item): Likewise.
2285 * sound.c (sound_cleanup, alsa_close): Likewise.
2286 * termcap.c (tgetent): Likewise.
2287 * xfns.c (x_default_font_parameter): Likewise.
2288 * xsettings.c (read_and_apply_settings): Likewise.
2289
e7974947
AS
2290 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2291 (overrun_check_free): Protoize.
2292
28272684
PE
22932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2296 since callers should never pass a negative size.
2297 Change the signature to match that of plain 'read' and 'write'; see
2298 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2299 * lisp.h: Update prototypes of emacs_write and emacs_read.
2300
11997c76
EZ
23012011-04-11 Eli Zaretskii <eliz@gnu.org>
2302
2303 * xdisp.c (redisplay_window): Don't try to determine the character
2304 position of the scroll margin if the window start point w->startp
e896f03c 2305 is outside the buffer's accessible region. (Bug#8468)
11997c76 2306
8a2cbd72
EZ
23072011-04-10 Eli Zaretskii <eliz@gnu.org>
2308
2309 Fix write-region and its subroutines for buffers > 2GB.
2310 * fileio.c (a_write, e_write): Modify declaration of arguments and
2311 local variables to support buffers larger than 2GB.
2312 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2313
2314 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2315 argument, local variables, and return value.
2316
2317 * lisp.h: Update prototypes of emacs_write and emacs_read.
2318
2319 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2320
4073e537 23212011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2322
1ebfdcb6
PE
2323 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2324
b2ded58d
PE
2325 Fix more problems found by GCC 4.6.0's static checks.
2326
7d66342c
PE
2327 * xdisp.c (vmessage): Use a better test for character truncation.
2328
bbf47d44
PE
2329 * charset.c (load_charset_map): <, not <=, for optimization,
2330 and to avoid potential problems with integer overflow.
9248994d 2331 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2332 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2333 * editfns.c (Fformat): Likewise.
1e69125e 2334 * syntax.c (skip_chars): Likewise.
3befa583 2335
e3019616
PE
2336 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2337 This also lets GCC 4.6.0 generate slightly better loop code.
2338
becfa255
PE
2339 * callint.c (Fcall_interactively): <, not <=, for optimization.
2340 (Fcall_interactively): Count the number of arguments produced,
2341 not the number of arguments given. This is simpler and lets GCC
2342 4.6.0 generate slightly better code.
2343
dae0cd48
PE
2344 * ftfont.c: Distingish more carefully between FcChar8 and char.
2345 The previous code passed unsigned char * to a functions like
2346 strlen and xstrcasecmp that expect char *, which does not
2347 conform to the C standard.
2348 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2349 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2350 char * when the C standard requires it.
2351
76032d70
PE
2352 * keyboard.c (read_char): Remove unused var.
2353
eb3f1cc8
PE
2354 * eval.c: Port to Windows vsnprintf (Bug#8435).
2355 Include <limits.h>.
2356 (SIZE_MAX): Define if the headers do not.
2357 (verror): Do not give up if vsnprintf returns a negative count.
2358 Instead, grow the buffer. This ports to Windows vsnprintf, which
2359 does not conform to C99. Problem reported by Eli Zaretskii.
2360 Also, simplify the allocation scheme, by avoiding the need for
2361 calling realloc, and removing the ALLOCATED variable.
2362
70476b54
PE
2363 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2364
12020a9e
PE
2365 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2366 But keep the doprint source code for now, as we might revamp it
2367 and use it again (Bug#8435).
ea6c7ae6
PE
2368 * lisp.h (doprnt): Remove.
2369 * Makefile.in (base_obj): Remove doprnt.o.
2370 * deps.mk (doprnt.o): Remove.
2371
5fdb398c
PE
2372 error: Print 32- and 64-bit integers portably (Bug#8435).
2373 Without this change, on typical 64-bit hosts error ("...%d...", N)
2374 was used to print both 32- and 64-bit integers N, which relied on
2375 undefined behavior.
2376 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2377 New macro.
2378 * lisp.h (error, verror): Mark as printf-like functions.
2379 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2380 Report overflow in size calculations when allocating printf buffer.
2381 Do not truncate output string at its first null byte.
2382 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2383 Truncate the output at a character boundary, since vsnprintf does not
2384 do that.
2385 * charset.c (check_iso_charset_parameter): Convert internal
2386 character to string before calling 'error', since %c now has the
2387 printf meaning.
2388 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2389 overflow when computing char to be passed to 'error'. Do not
2390 pass Lisp_Object to 'error'; pass the integer instead.
2391 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2392 formatted with plain %d.
2393
b189fa66
PE
2394 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2395
bff87ef0
PE
2396 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2397
7e2cac20
PE
2398 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2399
ce4d90b5
PE
2400 * xterm.c (x_catch_errors): Remove duplicate declaration.
2401
266c9547
PE
2402 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2403
79c49ad2
PE
2404 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2405
368f4090
JM
24062011-04-10 Jim Meyering <meyering@redhat.com>
2407
2408 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2409 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2410 return ssize_t not "int", and use size_t as the buffer length.
2411 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2412 * gnutls.h: Update declarations.
2413 * process.c (read_process_output): Use ssize_t, to match.
2414 (send_process): Likewise.
2415
a32d4040
CY
24162011-04-09 Chong Yidong <cyd@stupidchicken.com>
2417
2418 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2419
8546720e 24202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2421
04f2d78b
CB
2422 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2423 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2424
8546720e
GM
2425 * xterm.c (handle_one_xevent):
2426 * xmenu.c (create_and_show_popup_menu):
2427 * xselect.c (x_decline_selection_request)
2428 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2429
0a2f5c1a 24302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2431
2432 Fix some uses of `int' instead of EMACS_INT.
2433 * search.c (string_match_1, fast_string_match)
2434 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2435 (scan_buffer, find_next_newline_no_quit)
2436 (find_before_next_newline, search_command, Freplace_match)
2437 (Fmatch_data): Make some `int' variables be EMACS_INT.
2438
2439 * xdisp.c (display_count_lines): 3rd argument and return value now
2440 EMACS_INT. All callers changed.
2441 (pint2hrstr): Last argument is now EMACS_INT.
2442
2443 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2444 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2445 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2446 (decode_coding_utf_16, decode_coding_emacs_mule)
2447 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2448 (decode_coding_ccl, decode_coding_charset)
2449 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2450 (decode_coding_iso_2022, decode_coding_emacs_mule)
2451 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2452 <char_offset, last_offset>: Declare EMACS_INT.
2453 (encode_coding_utf_8, encode_coding_utf_16)
2454 (encode_coding_emacs_mule, encode_invocation_designation)
2455 (encode_designation_at_bol, encode_coding_iso_2022)
2456 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2457 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2458 Declare EMACS_INT.
2459 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2460 (encode_invocation_designation): Last argument P_NCHARS is now
2461 EMACS_INT.
2462 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2463 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2464
2465 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2466 All users changed.
2467
2468 * ccl.c (Fccl_execute_on_string): Declare some variables
2469 EMACS_INT.
2470
8546720e 24712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2472
2473 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2474
4e19a977
CS
24752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2476
2477 * process.c (Fformat_network_address): Doc fix.
2478
87302331
R
24792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2480
2481 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2482
cbb59342
CY
24832011-04-08 Chong Yidong <cyd@stupidchicken.com>
2484
2485 * keyboard.c (read_char): Call Lisp function help-form-show,
2486 instead of using internal_with_output_to_temp_buffer.
2487 (Qhelp_form_show): New var.
e0d38eeb 2488 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2489
2490 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2491
2492 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2493
e67a13ab
CY
24942011-04-06 Chong Yidong <cyd@stupidchicken.com>
2495
04f2d78b
CB
2496 * process.c (Flist_processes): Remove to Lisp.
2497 (list_processes_1): Delete.
e67a13ab 2498
973f782d
EZ
24992011-04-06 Eli Zaretskii <eliz@gnu.org>
2500
7c106b1e
EZ
2501 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2502
973f782d
EZ
2503 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2504
41cf7d1a 25052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2506
ca23cc88
PE
2507 Fix more problems found by GCC 4.6.0's static checks.
2508
f390e2d5
PE
2509 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2510
42eea0d0
PE
2511 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2512
b69769da 2513 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2514
f9541e84
PE
2515 * xdisp.c (vmessage): Mark as a printf-like function.
2516
13841b55
PE
2517 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2518
c136c10f
PE
2519 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2520
5e2d4a30
PE
2521 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2522 printf-like functions.
2523 (tiff_load): Add casts to remove these marks before passing them
2524 to system-supplied API.
2525
583f48b9
PE
2526 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2527
b25d760e
PE
2528 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2529 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2530 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2531 directly, rather than having caller test rule sign. This avoids
2532 some unnecessary tests.
2533 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2534 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2535 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2536
bc7b6697 2537 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2538 (xfont_open): Avoid unnecessary tests.
bc7b6697 2539
27ccc379
PE
2540 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2541
dcd5c89a
PE
2542 * composite.h, composite.c (composition_gstring_put_cache):
2543 Use EMACS_INT, not int, for length.
2544
b13a45c6
PE
2545 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2546 breaking out part of COMPOSITION_DECODE_RULE.
2547 (COMPOSITION_DECODE_RULE): Use it.
2548 * composite.c (get_composition_id): Remove unused local vars,
2549 by using the new macro.
2550
1e792e4d
PE
2551 * textprop.c (set_text_properties_1): Change while to do-while,
2552 since the condition is always true at first.
2553
dc6c6455 2554 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2555 (interval_deletion_adjustment): Return unsigned value.
2556 All uses changed.
dc6c6455 2557
aba7731a
PE
2558 * process.c (list_processes_1, create_pty, read_process_output):
2559 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2560 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2561 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2562 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2563 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2564
fdfc4bf3
PE
2565 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2566
fca8fe46 2567 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2568 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2569
06a0259a 2570 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2571 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2572 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2573
e7b9e80f
PE
2574 * print.c (print_error_message): Avoid int overflow.
2575
56201685
PE
2576 * font.c (font_list_entities): Redo for clarity,
2577 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2578
78834453 2579 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2580 (font_score): Avoid potential overflow in diff calculation.
78834453 2581
0bc0b309 2582 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2583 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2584
e610eaca
PE
2585 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2586
b895abce
PE
2587 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2588 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2589 can always succeed if overflow has undefined behavior.
2590
1f1d9321 2591 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2592 (wordify): Omit three unnecessary tests.
1f1d9321 2593
c59478bc
PE
2594 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2595 All callers changed. This avoids the need for an unused var.
2596
79b73827
PE
2597 * casefiddle.c (casify_region): Remove var that is set but not used.
2598
a4db5dfe
PE
2599 * dired.c (file_name_completion): Remove var that is set but not used.
2600
43aae36e
PE
2601 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2602
2a47c44d 2603 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2604 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2605
a37c69bf
PE
2606 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2607 Check for integer overflow on size calculations.
2608
328ab8e7
PE
2609 * buffer.c (Fprevious_overlay_change): Remove var that is set
2610 but not used.
2611
e5a2a5cb
PE
2612 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2613 Remove vars that are set but not used.
8d84a6eb 2614 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2615 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2616
a60e5f68
PE
2617 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2618
f661cb61 2619 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2620 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2621
f0397f5a
PE
2622 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2623 that are set but not used.
2624
8664db06 2625 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2626 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2627
6abdaa4a
PE
2628 * xselect.c (x_get_local_selection, x_handle_property_notify):
2629 Remove vars that are set but not used.
2630
0ce7538d 2631 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2632 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2633
9ae848fc
PE
2634 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2635 Remove var that is set but not used.
0b918413
PE
2636 (scroll_bar_windows_size): Now size_t, not int.
2637 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2638 Check for overflow.
9ae848fc 2639
a5a62657
PE
2640 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2641 (map_tty_color) [!defined MSDOS]: Likewise.
2642
5c5cdd39
PE
2643 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2644
66ebf983
PE
2645 * coding.c: Remove vars that are set but not used.
2646 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2647 All callers changed.
2648 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2649 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2650 (decode_coding_charset): Remove vars that are set but not used.
2651
1be4d761
PE
2652 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2653 that is set but not used.
2654
47553fa8
PE
2655 * print.c (print_object): Remove var that is set but not used.
2656
1f7196bf 2657 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2658 The gnulib version avoids calling malloc in the usual case,
2659 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2660 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2661 * filelock.c (current_lock_owner): Likewise.
2662 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2663 * sysdep.c: Include allocator.h, careadlinkat.h.
2664 (emacs_no_realloc_allocator): New static constant.
2665 (emacs_readlink): New function.
fdb61804
PE
2666 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2667 ../lib/careadlinkat.h.
d1fdcab7 2668
f84c17c7
SM
26692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2670
2671 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2672 first non-nil return value).
2673
ef3862ad
JD
26742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2675
2676 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2677 if not defined (Bug#8403).
2678
376a7006
JB
26792011-04-02 Juanma Barranquero <lekktu@gmail.com>
2680
2681 * xdisp.c (display_count_lines): Remove parameter `start',
2682 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2683 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2684 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2685 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2686 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2687 and thereabouts. All callers changed.
2688 (get_per_char_metric): Remove parameter `f', unused since
2689 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2690
6ca3801d
JM
26912011-04-02 Jim Meyering <meyering@redhat.com>
2692
2693 do not dereference NULL upon failed strdup
2694 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2695 (ns_get_family): Likewise.
2696
d8e2b5ba
JB
26972011-04-02 Juanma Barranquero <lekktu@gmail.com>
2698
2699 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2700
8c74fcbd
JD
27012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2702
2703 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2704 later (Bug#8403).
2705
7200d79c
SM
27062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2707
03408648 2708 Add lexical binding.
7200d79c 2709
03408648
SM
2710 * window.c (Ftemp_output_buffer_show): New fun.
2711 (Fsave_window_excursion):
2712 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2713
2714 * lread.c (lisp_file_lexically_bound_p): New function.
2715 (Fload): Bind Qlexical_binding.
2716 (readevalloop): Remove `evalfun' arg.
2717 Bind Qinternal_interpreter_environment.
2718 (Feval_buffer): Bind Qlexical_binding.
2719 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2720 Mark as dynamic.
2721 (syms_of_lread): Declare `lexical-binding'.
2722
2723 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2724
2725 * keyboard.c (eval_dyn): New fun.
2726 (menu_item_eval_property): Use it.
ca105506
SM
2727
2728 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2729
03408648
SM
2730 * fns.c (concat, mapcar1): Accept byte-code-functions.
2731
2732 * eval.c (Fsetq): Handle lexical vars.
2733 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2734 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2735 (FletX, Flet): Obey lexical binding.
2736 (Fcommandp): Handle closures.
2737 (Feval): New `lexical' arg.
2738 (eval_sub): New function extracted from Feval. Use it almost
2739 everywhere where Feval was used. Look up vars in lexical env.
2740 Handle closures.
2741 (Ffunctionp): Move from subr.el.
2742 (Ffuncall): Handle closures.
2743 (apply_lambda): Remove `eval_flags'.
2744 (funcall_lambda): Handle closures and new byte-code-functions.
2745 (Fspecial_variable_p): New function.
2746 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2747 but without exporting it to Lisp.
23aba0ea 2748
23aba0ea 2749 * doc.c (Fdocumentation, store_function_docstring):
03408648 2750 * data.c (Finteractive_form): Handle closures.
23aba0ea 2751
03408648
SM
2752 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2753 interactive spec.
ba83908c 2754
04f2d78b
CB
2755 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2756 New byte-codes.
03408648
SM
2757 (exec_byte_code): New function extracted from Fbyte_code to handle new
2758 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2759
03408648 2760 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2761
03408648 2762 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2763
e2abce01
JB
27642011-03-31 Juanma Barranquero <lekktu@gmail.com>
2765
2766 * xdisp.c (redisplay_internal): Fix prototype.
2767
63696a73 27682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2769
63696a73 2770 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2771 (try_scrolling): Use it when setting scroll_limit.
2772 Limit scrolling to 100 screen lines.
63696a73
EZ
2773 (redisplay_window): Even when falling back on "recentering",
2774 position point in the window according to scroll-conservatively,
2775 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2776
2777 (try_scrolling): When point is above the window, allow searching
2778 as far as scroll_max, or one screenful, to compute vertical
2779 distance from PT to the scroll margin position. This prevents
2780 try_scrolling from unnecessarily failing when
2781 scroll-conservatively is set to a value slightly larger than the
2782 window height. Clean up the case of PT below the margin at bottom
2783 of window: scroll_max can no longer be INT_MAX. When aggressive
2784 scrolling is in use, don't let point enter the opposite scroll
2785 margin as result of the scroll.
2786 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2787 threshold of 100 lines for never-recentering scrolling.
2788
e4cc2dfc
JB
27892011-03-31 Juanma Barranquero <lekktu@gmail.com>
2790
2791 * dispextern.h (move_it_by_lines):
2792 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2793 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2794 (message_log_check_duplicate): Remove parameters `prev_bol' and
2795 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2796 (redisplay_internal): Remove parameter `preserve_echo_area',
2797 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2798
2799 * indent.c (Fvertical_motion):
2800 * window.c (window_scroll_pixel_based, Frecenter):
2801 Don't pass `need_y_p' to `move_it_by_lines'.
2802
1c470562
SM
28032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2804
44f230aa
SM
2805 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2806 steal a few bits to be more compact.
2807 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2808 Remove unneeded casts.
2809
1c470562
SM
2810 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2811
888adce9
ZK
28122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2813
2814 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2815 binding" message (bug#7967).
2816
f838ed7b
PE
28172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2818
77861b95
PE
2819 Fix more problems found by GCC 4.6.0's static checks.
2820
de6dbc14
PE
2821 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2822 Remove unused local var.
2823
f838ed7b
PE
2824 * editfns.c (Fmessage_box): Remove unused local var.
2825
792c7b2b
PE
2826 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2827 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2828 Omit unused local vars.
c499e557 2829 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2830 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2831 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2832 Omit unused local var.
2833
ba0165e1
PE
2834 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2835 Don't assume string length fits in int.
32ad8845 2836 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2837 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2838
3c59b4c9
PE
2839 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2840 instead of alloca (Bug#8344).
2841
a3eed478 2842 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2843 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2844
eb4d412d
PE
2845 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2846
1658b401
PE
2847 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2848 concerns.
2849
2850 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2851
2852 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2853
9a2c6e05
PE
2854 * keyboard.c (syms_of_keyboard): Use the same style as later
2855 in this function when indexing through an array. This also
2856 works around GCC bug 48267.
2857
03d0a109
PE
2858 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2859
44f730c8
PE
2860 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2861
fe75f926
PE
2862 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2863 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2864
ffa8c828
PE
2865 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2866 This avoids undefined behavior on integer overflow, and is a bit
2867 more convenient anyway since it is compared to a size_t variable.
2868
c5101a77
PE
2869 Variadic C functions now count arguments with size_t, not int.
2870 This avoids an unnecessary limitation on 64-bit machines, which
2871 caused (substring ...) to crash on large vectors (Bug#8344).
2872 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2873 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2874 All variadic functions and their callers changed accordingly.
c5101a77
PE
2875 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2876 * data.c (arith_driver, float_arith_driver): Likewise.
2877 * editfns.c (general_insert_function): Likewise.
2878 * eval.c (struct backtrace.nargs, interactive_p)
2879 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2880 (funcall_lambda, mark_backtrace): Likewise.
2881 * fns.c (concat): Likewise.
2882 * frame.c (x_set_frame_parameters): Likewise.
2883 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2884 0 if not found, not -1. All callers changed.
2885
dd3f25f7
PE
2886 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2887 (stack_copy_size): Now size_t, not int.
2888 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2889
461c2ab9
JB
28902011-03-28 Juanma Barranquero <lekktu@gmail.com>
2891
2892 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2893 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2894 All callers changed.
2895
2896 * lisp.h (multibyte_char_to_unibyte):
2897 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2898 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2899 * character.h (CHAR_TO_BYTE8):
2900 * cmds.c (internal_self_insert):
2901 * editfns.c (general_insert_function):
2902 * keymap.c (push_key_description):
2903 * search.c (Freplace_match):
2904 * xdisp.c (message_dolog, set_message_1): All callers changed.
2905
f6d62986
SM
29062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2907
2908 * keyboard.c (safe_run_hook_funcall): New function.
2909 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2910 don't set the hook to nil, but remove the offending function instead.
2911 (Qcommand_hook_internal): Remove, unused.
2912 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2913 Vcommand_hook_internal.
2914
2915 * eval.c (enum run_hooks_condition): Remove.
2916 (funcall_nil, funcall_not): New functions.
2917 (run_hook_with_args): Call each function through a `funcall' argument.
2918 Remove `cond' argument, now redundant.
2919 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2920 (Frun_hook_with_args_until_failure): Adjust accordingly.
2921 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2922
1db5b1ad
JB
29232011-03-28 Juanma Barranquero <lekktu@gmail.com>
2924
2925 * dispextern.h (string_buffer_position): Remove declaration.
2926
2927 * print.c (strout): Remove parameter `multibyte', unused since
2928 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2929
2930 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2931 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2932 All callers changed.
2933
2934 * w32.c (_wsa_errlist): Use braces for struct initializers.
2935
2936 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2937 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2938 All callers changed.
2939 (string_buffer_position): Likewise. Also, make static (it's never
2940 used outside xdisp.c).
2941 (cursor_row_p): Remove parameter `w', unused since
2942 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2943 (decode_mode_spec): Remove parameter `precision', introduced during
2944 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2945 All callers changed.
2946
5ffb62aa
JD
29472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2948
2949 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2950
461c2ab9 29512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2952
2953 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2954 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2955 (ns_update_auto_hide_menu_bar): New functions.
2956 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2957 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2958 ns_constrain_all_frames.
2959 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2960 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2961
5c380ffb
JD
29622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2963
2964 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2965
9af30bdf
GM
29662011-03-27 Glenn Morris <rgm@gnu.org>
2967
2968 * syssignal.h: Replace RETSIGTYPE with void.
2969 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2970 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2971 Replace SIGTYPE with void everywhere.
2972 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2973 * s/template.h (SIGTYPE): Remove commented out definition.
2974
e2abce01
JB
29752011-03-26 Eli Zaretskii <eliz@gnu.org>
2976
2977 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2978 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2979
f868cd8a
JB
29802011-03-26 Juanma Barranquero <lekktu@gmail.com>
2981
59eb0929
JB
2982 * w32.c (read_unc_volume): Use parameter `henum', instead of
2983 global variable `wget_enum_handle'.
2984
2985 * keymap.c (describe_vector): Remove parameters `indices' and
2986 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2987 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2988
f868cd8a
JB
2989 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2990
2991 * keyboard.c (timer_check): Remove parameter `do_it_now',
2992 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2993 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2994 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2995
2996 * keyboard.c (read_char):
2997 * w32menu.c (w32_menu_display_help):
2998 * xmenu.c (show_help_event, menu_help_callback):
2999 Adjust calls to `show_help_echo'.
3000
3001 * gtkutil.c (xg_maybe_add_timer):
3002 * keyboard.c (readable_events):
3003 * process.c (wait_reading_process_output):
3004 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3005
3006 * insdel.c (adjust_markers_gap_motion):
3007 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3008 (gap_left, gap_right): Don't call it.
3009
2ecf6fdb
CY
30102011-03-25 Chong Yidong <cyd@stupidchicken.com>
3011
3012 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3013 incurred during fontification.
3014
6b1f9ba4
JB
30152011-03-25 Juanma Barranquero <lekktu@gmail.com>
3016
3017 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3018 (DEFVAR_PER_BUFFER): Don't pass it.
3019
3020 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3021 (scrolling_window): Don't pass it.
3022
0f4a96b5
JB
30232011-03-25 Juanma Barranquero <lekktu@gmail.com>
3024
3025 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3026
3027 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3028 and `suffix'.
3029 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3030 of variables specific to SELinux and computation of `encoded_absname'.
3031
3032 * image.c (XPutPixel): Remove unused variable `height'.
3033
3034 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3035
3036 * unexw32.c (get_section_info): Remove unused variable `section'.
3037
3038 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3039 (system_process_attributes): Remove unused variable `sess'.
3040 (sys_read): Remove unused variable `err'.
3041
3042 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3043 (w32_wnd_proc): Remove unused variable `isdead'.
3044 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3045 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3046 (x_create_tip_frame): Remove unused variable `tem'.
3047
3048 * w32inevt.c (w32_console_read_socket):
3049 Remove unused variable `no_events'.
3050
3051 * w32term.c (x_draw_composite_glyph_string_foreground):
3052 Remove unused variable `width'.
3053
1149507c
JB
30542011-03-24 Juanma Barranquero <lekktu@gmail.com>
3055
3056 * w32term.c (x_set_glyph_string_clipping):
3057 Don't pass uninitialized region to CombineRgn.
3058
9c88f339
JB
30592011-03-23 Juanma Barranquero <lekktu@gmail.com>
3060
3061 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3062 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3063 (Fx_close_connection): Remove unused variable `i'.
3064
3065 * w32font.c (w32font_draw): Return number of glyphs.
3066 (w32font_open_internal): Remove unused variable `i'.
3067 (w32font_driver): Add missing initializer.
3068
3069 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3070 (fill_in_menu): Remove unused variable `items_added'.
3071
3072 * w32term.c (last_mouse_press_frame): Remove static global variable.
3073 (w32_clip_to_row): Remove unused variable `f'.
3074 (x_delete_terminal): Remove unused variable `i'.
3075
3076 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3077 (NOTHING): Remove unused static global variable.
3078 (uniscribe_check_otf): Remove unused variable `table'.
3079 (uniscribe_font_driver): Add missing initializers.
3080
dee091a3
JD
30812011-03-23 Julien Danjou <julien@danjou.info>
3082
3083 * term.c (Fsuspend_tty, Fresume_tty):
3084 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3085 * window.c (temp_output_buffer_show):
3086 * insdel.c (signal_before_change):
3087 * frame.c (Fhandle_switch_frame):
3088 * fileio.c (Fdo_auto_save):
3089 * emacs.c (Fkill_emacs):
3090 * editfns.c (save_excursion_restore):
3091 * cmds.c (internal_self_insert):
3092 * callint.c (Fcall_interactively):
3093 * buffer.c (Fkill_all_local_variables):
3094 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3095 Use Frun_hooks.
0f4a96b5 3096 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3097 unconditionnaly since it does the check itself.
3098
2c520ab5 30992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3100
c9c49752
PE
3101 Fix more problems found by GCC 4.5.2's static checks.
3102
8abc3f12
PE
3103 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3104 the first time through the loop, since we know p0 < p1 then.
3105 This also avoids a gcc -Wstrict-overflow warning.
3106
a2d26660
PE
3107 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3108 leading to a memory leak, possible in functions like
3109 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3110 of objects (Bug#8318).
a2d26660 3111
916c72e9
PE
3112 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3113 that could (at least in theory) be that large.
3114
19ab8a18
PE
3115 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3116 This is less likely to overflow, and avoids undefined behavior if
3117 overflow does occur. All callers changed. Use strtoul to scan
3118 for the unsigned long integer.
b7cbbd6f
PE
3119 (pint2hrstr): Simplify and tune code slightly.
3120 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3121
f0641eff
PE
3122 * scroll.c (do_scrolling): Work around GCC bug 48228.
3123 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3124
7f650bb9
PE
3125 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3126 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3127 (validate_x_resource_name): Simplify count usage.
3128 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3129
37dd57d1
PE
3130 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3131 fail (Bug#8306).
81e56e61 3132
699979fc 3133 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3134
401bf9b4
PE
3135 * process.c (Fmake_network_process): Use socklen_t, not int,
3136 where POSIX says socklen_t is required in portable programs.
3137 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3138 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3139 (Fmake_network_process, server_accept_connection):
3140 (wait_reading_process_output, read_process_output):
3141 Likewise.
3142
b93aacde
PE
3143 * process.c: Rename or move locals to avoid shadowing.
3144 (list_processes_1, Fmake_network_process):
3145 (read_process_output_error_handler, exec_sentinel_error_handler):
3146 Rename or move locals.
4dc343ee 3147 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3148 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3149 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3150 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3151 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3152
af8a867c 3153 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3154 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3155 Include tparam.h instead, since it declares them.
af8a867c
PE
3156 * cm.h (PC): Remove extern decl; tparam.h now does this.
3157 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3158 * terminfo.c: Include tparam.h, to check interfaces.
3159 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3160 (tparam): Adjust signature to match interface in tparam.h;
3161 this removes some undefined behavior. Check that outstring and len
3162 are zero, which they always are with Emacs.
3163 * tparam.h (PC, BC, UP): New extern decls.
3164
0248044d 3165 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3166 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3167
8ff096c1 3168 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3169 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3170 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3171 (ftfont_list): Remove unused local.
49eaafba
PE
3172 (get_adstyle_property, ftfont_pattern_entity):
3173 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3174 Rename locals to avoid shadowing.
8ff096c1 3175
e2be39f6
PE
3176 * xfont.c (xfont_list_family): Mark var as initialized.
3177
c9735e30
PE
3178 * xml.c (make_dom): Now static.
3179
8f5201ae
PE
3180 * composite.c (composition_compute_stop_pos): Rename local to
3181 avoid shadowing.
b246f932
PE
3182 (composition_reseat_it): Remove unused locals.
3183 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3184 (composition_update_it): Mark var as initialized.
11b61122
PE
3185 (find_automatic_composition): Mark vars as initialized,
3186 with a FIXME (Bug#8290).
8f5201ae 3187
760fbc2c
PE
3188 character.h: Rename locals to avoid shadowing.
3189 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3190 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3191 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3192 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3193 to avoid shadowing.
3194
ff08eb85
PE
3195 * textprop.c (property_change_between_p): Remove; unused.
3196
fc7bf025
PE
3197 * intervals.c (interval_start_pos): Now static.
3198
235d7abc
PE
3199 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3200
44f230aa
SM
3201 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3202 Rename locals to avoid shadowing.
3e7d6594 3203
50060332
PE
3204 * sound.c (wav_play, au_play, Fplay_sound_internal):
3205 Fix pointer signedness.
d01f234b 3206 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3207 (wav_play): Initialize a variable to 0, to prevent undefined
3208 behavior (Bug#8278).
50060332 3209
c4fc4e30
PE
3210 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3211
918436ed
PE
3212 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3213
c939f91b
PE
3214 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3215 clobbering (Bug#8298).
b9c7f648
PE
3216 * sysdep.c (sys_subshell): Likewise.
3217 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3218
6bd8c144
PE
3219 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3220 This should get cleaned up, so that child_setup has the
3221 same signature on all platforms.
3222
7710357c 3223 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3224 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3225
c59da222
CY
32262011-03-22 Chong Yidong <cyd@stupidchicken.com>
3227
3228 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3229 not to be necessary, and produces flickering.
3230
66b87493
GM
32312011-03-20 Glenn Morris <rgm@gnu.org>
3232
3233 * config.in: Remove file.
3234
45b6f6d5
JB
32352011-03-20 Juanma Barranquero <lekktu@gmail.com>
3236
3237 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3238 are now in src/globals.h.
3239 (syms_of_minibuf): Remove spurious & from previous change.
3240
3ec03f7e
LL
32412011-03-20 Leo <sdl.web@gmail.com>
3242
3243 * minibuf.c (completing-read-function): New variable.
3244 (completing-read-default): Rename from completing-read.
3245 (completing-read): Call completing-read-function.
3246
b14e3e21
CY
32472011-03-19 Juanma Barranquero <lekktu@gmail.com>
3248
3249 * xfaces.c (Fx_load_color_file):
3250 Read color file from absolute filename (bug#8250).
3251
f2b726e6
JB
32522011-03-19 Juanma Barranquero <lekktu@gmail.com>
3253
3254 * makefile.w32-in: Update dependencies.
3255
09f6ff02
EZ
32562011-03-17 Eli Zaretskii <eliz@gnu.org>
3257
3258 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3259
29a6015a
PE
32602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3261
a3a6c54e
PE
3262 Fix more problems found by GCC 4.5.2's static checks.
3263
b766f867
PE
3264 * process.c (make_serial_process_unwind, send_process_trap):
3265 (sigchld_handler): Now static.
3266
be02381c
PE
3267 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3268 That way, the code declares only the vars that it needs.
3269 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3270 * s/cygwin.h (PTY_ITERATION): Likewise.
3271 * s/darwin.h (PTY_ITERATION): Likewise.
3272 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3273
57048744
PE
3274 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3275 * process.c (allocate_pty): Don't declare stb unless it's needed.
3276
7914961c 3277 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3278 (CONSTANTLIM): Remove; unused.
3279 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3280 Define only if needed.
7914961c 3281
b3967b18
PE
3282 * unexelf.c (unexec): Name an expression,
3283 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3284 Use a different way to cause a compilation error if anyone uses
3285 n rather than nn, a way that does not involve shadowing.
73366a00 3286 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3287
29a6015a
PE
3288 * deps.mk (unexalpha.o): Remove; unused.
3289
43cfc33e 3290 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3291 * unexec.h: New file.
ce701a33
PE
3292 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3293 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3294 Depend on unexec.h.
3295 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3296 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3297 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3298 Change as necessary to match prototype in unexec.h.
ce701a33 3299
01f44d5a
PE
3300 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3301 shadowing.
4f63c6bb 3302 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3303
a6670b0b
PE
3304 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3305 Rename locals to avoid shadowing.
3306
cef2010d 3307 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3308 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3309
d4d7173a
PE
3310 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3311
f08b802a
PE
3312 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3313 warning when compiling print.c.
3314
3ddb0639
PE
3315 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3316 instead of using an uninitialized var.
5ad03b97 3317 (font_sort_entities): Mark var as initialized.
3ddb0639 3318
170a2692
PE
3319 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3320
e663c700
PE
3321 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3322 pointers to constants.
89bc529a 3323 (font_parse_fcname): Remove unused vars.
7b81e2d0 3324 (font_delete_unmatched): Now static.
ea838e10 3325 (font_get_spec): Remove; unused.
13a547c6
PE
3326 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3327 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3328 Rename or move locals to avoid shadowing.
e663c700 3329
2a80c887 3330 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3331 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3332
1384fa33 3333 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3334 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3335
8b2c52e9
PE
3336 * alloc.c (mark_backtrace): Move decl from here ...
3337 * lisp.h: ... to here, so that it can be checked.
3338
475545b5 3339 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3340 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3341 (lisp_indirect_variable): Name an expression,
3342 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3343 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3344
b1349114 3345 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3346 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3347 Use const pointer when appropriate.
b1349114 3348
a2928364
PE
3349 * lisp.h (get_system_name, get_operating_system_release):
3350 Move decls here, to check interfaces.
3351 * process.c (get_operating_system_release): Move decl to lisp.h.
3352 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3353 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3354 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3355 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3356 (Fformat_time_string, Fencode_time, Finsert_char):
3357 (Ftranslate_region_internal, Fformat):
3358 Rename or remove local vars to avoid shadowing.
9710023e 3359 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3360
a415e694
PE
3361 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3362 avoid shadowing.
3363
8ef4622d
PE
3364 * lisp.h (eassert): Check that the argument compiles, even if
3365 ENABLE_CHECKING is not defined.
3366
946f9a5b
PE
3367 * data.c (Findirect_variable): Name an expression, to avoid
3368 gcc -Wbad-function-cast warning.
112396d6 3369 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3370 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3371 (Fmake_variable_buffer_local, Fmake_local_variable):
3372 Mark variables as initialized.
52746918 3373 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3374
e5aab7e7 3375 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3376 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3377 Rename locals to avoid shadowing.
dff45157
PE
3378 (mark_stack): Move local variables into the #ifdef region where
3379 they're used.
7bc26fdb
PE
3380 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3381 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3382 needed otherwise.
3383 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3384 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3385 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3386
e5aab7e7
PE
3387 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3388 avoids undefined behavior in theory.
3389
4da60324
PE
3390 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3391
88043301
PE
3392 Use functions, not macros, for up- and down-casing (Bug#8254).
3393 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3394 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3395 to use the following functions instead of these macros.
3396 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3397 EMACS_INT, since callers assume the returned value fits in int.
3398 (upcase1): Likewise, for UPCASE_TABLE.
3399 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3400 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3401 the race-condition problem in the old DOWNCASE.
88043301 3402
19ed5445
PE
3403 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3404 Rename locals to avoid shadowing.
3405 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3406 (regex_compile, re_search_2, re_match_2_internal):
3407 Remove unused local vars.
952db0d7
PE
3408 (FREE_VAR): Rewrite so as not to use empty "else",
3409 which gcc can warn about.
da053e48 3410 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3411 (RETALLOC_IF): Define only if needed.
3412 (WORDCHAR_P): Likewise. This one is never needed, but is used
3413 only in a comment talking about a compiler bug, so put inside
3414 the #if 0 of that comment.
3415 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3416 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3417 Remove; unused.
19ed5445 3418
1f3561e4 3419 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3420 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3421 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3422
ded6f8f7
PE
3423 * search.c (simple_search): Remove unused var.
3424
dbd37a95
PE
3425 * dired.c (compile_pattern): Move decl from here ...
3426 * lisp.h: ... to here, so that it can be checked.
3427 (struct re_registers): New forward decl.
3428
7e47afad
PE
3429 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3430
85f24f61
PE
3431 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3432 All uses changed.
3433 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3434 Rename locals to avoid shadowing.
5671df8f 3435 (Fvertical_motion): Mark locals as initialized.
85f24f61 3436
181aa2be 3437 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3438 (casify_region): Mark local as initialized.
181aa2be 3439
930d429c
PE
3440 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3441
7082eac6
PE
3442 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3443 New macros, so that the caller can use some names other than
3444 gcpro1, gcpro2, etc.
3445 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3446 of the new macros.
3447 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3448 argument, for consistency with GCPRO2_VAR, etc: it is now the
3449 prefix of the variable, not the variable itself. All uses
3450 changed.
38b2c076
PE
3451 * dired.c (directory_files_internal, file_name_completion):
3452 Rename locals to avoid shadowing.
3453
15206ed9
PE
3454 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3455 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3456 dired.c's scmp function, had undefined behavior.
3457 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3458 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3459 * buffer.h: ... to here, because these macros use current_buffer,
3460 and the new implementation with inline functions needs to have
3461 current_buffer in scope now, rather than later when the macros
3462 are used.
3463 (downcase, upcase1): New static inline functions.
3464 (DOWNCASE, UPCASE1): Reimplement using these functions.
3465 This avoids undefined behavior in expressions like
3466 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3467 from race conditions in accessing the global variables
3468 case_temp1 and case_temp2.
3469 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3470 * lisp.h (case_temp1, case_temp2): Remove their decls.
3471 * character.h (ASCII_CHAR_P): Move from here ...
3472 * lisp.h: ... to here, so that the inline functions mentioned
3473 above can use them.
3474
4a6bea26
PE
3475 * dired.c (directory_files_internal_unwind): Now static.
3476
f14b7e14
PE
3477 * fileio.c (file_name_as_directory, directory_file_name):
3478 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3479 Now static.
2893f146
PE
3480 (file_name_as_directory): Use const pointers when appropriate.
3481 (Fexpand_file_name): Likewise. In particular, newdir might
3482 point at constant storage, so make it a const pointer.
fd4ead52 3483 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3484 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3485 signedness issues.
f839df0c
PE
3486 (Fset_file_times, Finsert_file_contents, auto_save_error):
3487 Rename locals to avoid shadowing.
f14b7e14 3488
5716756e 3489 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3490 (Ftry_completion, Fall_completions): Rename or remove locals
3491 to avoid shadowing.
5716756e 3492
b4c3046a
PE
3493 * marker.c (bytepos_to_charpos): Remove; unused.
3494
b45db522
PE
3495 * lisp.h (verify_bytepos, count_markers): New decls,
3496 so that gcc does not warn that these functions aren't declared.
3497
85876d07
PE
3498 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3499 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3500 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3501 (copy_text): Remove unused local var.
85876d07 3502
03d78a21 3503 * filelock.c (within_one_second): Now static.
b3dd38ab 3504 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3505
5df8f01b
PE
3506 * buffer.c (fix_overlays_before): Mark locals as initialized.
3507 (fix_start_end_in_overlays): Likewise. This function should be
3508 simplified by using pointers-to-pointers, but that's a different
3509 matter.
b1d876f1 3510 (switch_to_buffer_1): Now static.
8f54f30a
PE
3511 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3512 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3513
a70072c9 3514 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3515 Fix pointer signedness issue.
edced198
PE
3516 (sys_subshell): Mark local as volatile if checking for lint,
3517 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3518 (MAXPATHLEN): Define only if needed.
a70072c9 3519
a0977c44
PE
3520 * process.c (serial_open, serial_configure): Move decls from here ...
3521 * systty.h: ... to here, so that they can be checked.
3522
a884fdcc
PE
3523 * fns.c (get_random, seed_random): Move extern decls from here ...
3524 * lisp.h: ... to here, so that they can be checked.
3525
604efe86 3526 * sysdep.c (reset_io): Now static.
b8950c94 3527 (wait_for_termination_signal): Remove; unused.
604efe86 3528
38fc62d9
PE
3529 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3530 (copy_keymap_item, append_key, push_text_char_description):
3531 Now static.
1004a21a 3532 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3533 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3534 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3535 (describe_map_tree):
3536 Rename locals to avoid shadowing.
38fc62d9 3537
2f2650da
PE
3538 * keyboard.c: Declare functions static if they are not used elsewhere.
3539 (echo_char, echo_dash, cmd_error, top_level_2):
3540 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3541 (read_char, kbd_buffer_get_event, make_lispy_position):
3542 (make_lispy_event, make_lispy_movement, apply_modifiers):
3543 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3544 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3545 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3546 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3547 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3548
a053e86c 3549 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3550 (mark_kboards): Move decl here ...
3551 * alloc.c (mark_kboards): ... from here.
a053e86c 3552
4752793e
PE
3553 * lisp.h (force_auto_save_soon): New decl.
3554
74f10ca7 3555 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3556 (DEFINE_DUMMY_FUNCTION): New macro.
3557 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3558 Use it.
c03cd23f
PE
3559 (main): Add casts to avoid warnings
3560 if GCC considers string literals to be constants.
74f10ca7 3561
022e70d4
PE
3562 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3563
59d6fe83
PE
3564 * dbusbind.c: Pointer signedness fixes.
3565 (xd_signature, xd_append_arg, xd_initialize):
3566 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3567 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3568 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3569 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3570
78320123
PE
3571 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3572 if GCC considers string literals to be constants.
49cebcca 3573 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3574
35ac2a97
SM
35752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3576
fb103ca9
SM
3577 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3578 (print_preprocess, print_object): New macro to fix last change.
3579
35ac2a97
SM
3580 * print.c (print_preprocess): Don't forget font objects.
3581
62973b41
JB
35822011-03-16 Juanma Barranquero <lekktu@gmail.com>
3583
3584 * emacs.c (USAGE3): Doc fixes.
3585
0e48bb22
AS
35862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3587
3588 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3589 structure.
3590
7684e57b
JB
35912011-03-14 Juanma Barranquero <lekktu@gmail.com>
3592
3593 * lisp.h (VWindow_system, Qfile_name_history):
3594 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3595 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3596 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3597
3598 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3599 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3600
3601 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3602 * w32console.c (detect_input_pending, read_input_pending)
3603 (encode_terminal_code):
3604 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3605 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3606 (w32_system_caret_y, Qfile_name_history):
3607 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3608 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3609 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3610 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3611 * w32proc.c (Qlocal, report_file_error):
3612 * w32term.c (Vwindow_system, updating_frame):
3613 * w32uniscribe.c (initialized, uniscribe_font_driver):
3614 Remove unneeded extern declarations.
3615
2aa46d6c
CY
36162011-03-14 Chong Yidong <cyd@stupidchicken.com>
3617
c96bbc66 3618 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3619
cffc6f3b
CY
36202011-03-13 Chong Yidong <cyd@stupidchicken.com>
3621
3622 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3623 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3624 These macros can no longer be used for assignment.
3625
44f230aa
SM
3626 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3627 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3628 (record_buffer_markers, fetch_buffer_markers): New functions for
3629 recording and fetching special buffer markers.
3630 (set_buffer_internal_1, set_buffer_temp): Use them.
3631
3632 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3633
3634 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3635
3636 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3637 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3638
3639 * xdisp.c (hscroll_window_tree):
3640 (reconsider_clip_changes): Use PT instead of BUF_PT.
3641
d251f04b
EZ
36422011-03-13 Eli Zaretskii <eliz@gnu.org>
3643
3644 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3645 $(EMACS_ROOT)/lib/intprops.h.
3646
f0c77cd1
PE
36472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3648
3eca4629
PE
3649 Fix more problems found by GCC 4.5.2's static checks.
3650
7c86ee98
PE
3651 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3652 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3653 (xg_free_frame_widgets): Make it clear that a local variable is
3654 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3655 (gdk_window_get_screen): Make it clear that this macro is needed
3656 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3657 (int_gtk_range_get_value): New function, which avoids a diagnostic
3658 from gcc -Wbad-function-cast.
3659 (xg_set_toolkit_scroll_bar_thumb): Use it.
3660 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3661 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3662 (get_utf8_string, xg_get_file_with_chooser):
3663 Rename locals to avoid shadowing.
3664 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3665
41729b81
PE
3666 * xgselect.c (xg_select): Remove unused var.
3667
f0c77cd1
PE
3668 * image.c (four_corners_best): Mark locals as initialized.
3669 (gif_load): Initialize transparent_p to zero (Bug#8238).
3670 Mark another local as initialized.
ec6cf4c6 3671 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3672
ce0ad53d 3673 * image.c (clear_image_cache): Now static.
d5d5a617 3674 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3675 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3676 (x_edge_detection): Remove unnecessary cast that
3677 gcc -Wbad-function-cast diagnoses.
2037898d 3678 (gif_load): Fix pointer signedness.
6ae141d6
PE
3679 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3680 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3681
33383987 36822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3683
d32df629
PE
3684 Improve quality of tests for time stamp overflow.
3685 For example, without this patch (encode-time 0 0 0 1 1
3686 1152921504606846976) returns the obviously-bogus value (-948597
3687 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3688 reports time overflow. See
3689 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3690 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3691 * editfns.c: Include limits.h and intprops.h.
3692 (TIME_T_MIN, TIME_T_MAX): New macros.
3693 (time_overflow): Move earlier, to before first use.
3694 (hi_time, lo_time): New functions, for an accurate test for
3695 out-of-range times.
3696 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3697 (Fget_internal_run_time): Don't assume time_t fits in int.
3698 (make_time): Use list2 instead of Fcons twice.
3699 (Fdecode_time): More accurate test for out-of-range times.
3700 (check_tm_member): New function.
3701 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3702 (lisp_time_argument): Don't rely on undefined left-shift and
3703 right-shift behavior when checking for time stamp overflow.
8be6f318 3704
fe31d94c
PE
3705 * editfns.c (time_overflow): New function, refactoring common code.
3706 (Fformat_time_string, Fdecode_time, Fencode_time):
3707 (Fcurrent_time_string): Use it.
3708
8be6f318
PE
3709 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3710 * dired.c (make_time): Move to ...
3711 * editfns.c (make_time): ... here.
3712 * systime.h: Note the move.
3713
09d9db2c 37142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3715
126bc0dc
YM
3716 * fringe.c (update_window_fringes): Remove unused variables.
3717
c47cbdfd
YM
3718 * unexmacosx.c (copy_data_segment): Also copy __got section.
3719 (Bug#8223)
3720
7ac80be9
EZ
37212011-03-12 Eli Zaretskii <eliz@gnu.org>
3722
c96bbc66 3723 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3724 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3725 Constify `char *' arguments and their references according to
3726 prototypes in tparam.h.
3727
ecb0f94d 3728 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3729
7ac80be9
EZ
3730 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3731 Adapt all references accordingly.
3732
3733 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3734
ef1fd07e
TT
37352011-03-11 Tom Tromey <tromey@redhat.com>
3736
3737 * buffer.c (syms_of_buffer): Remove obsolete comment.
3738
7ef4b50c
EZ
37392011-03-11 Eli Zaretskii <eliz@gnu.org>
3740
3741 * termhooks.h (encode_terminal_code): Declare prototype.
3742
3743 * msdos.c (encode_terminal_code): Don't declare prototype.
3744
3745 * term.c (encode_terminal_code): Now external again, used by
3746 w32console.c and msdos.c.
3747
44f230aa
SM
3748 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3749 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3750
4b1ec863 37512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3752
1714f52b 3753 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3754
4b1ec863
PE
3755 * fringe.c (update_window_fringes): Mark locals as initialized
3756 (Bug#8227).
3757 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3758
524c7aa6
PE
3759 * alloc.c (mark_fringe_data): Move decl from here ...
3760 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3761 to check its interface.
3762 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3763
a5c0af81 3764 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3765 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3766 (fontset_font): Mark local as initialized.
a9a06e0b 3767 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3768
b4716021
PE
3769 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3770
811e9bac 3771 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3772 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3773 (x_own_selection, Fx_disown_selection_internal): Rename locals
3774 to avoid shadowing.
3775 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3776
7e3ab302
PE
3777 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3778 so that the caller can use some name other than gcpro1.
3779 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3780 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3781 (Fx_backspace_delete_keys_p):
3782 Use them to avoid shadowing, and rename vars to avoid shadowing.
3783 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3784 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3785 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3786 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3787 Remove unused locals.
7e3ab302
PE
3788 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3789 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3790 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3791 macros.
f78faa98 3792
e2b13473
PE
3793 * xterm.h (x_mouse_leave): New decl.
3794
77f23912
PE
3795 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3796 Remove unused functions.
cdf4ba58
PE
3797 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3798 (x_calc_absolute_position): Now static.
7411c686 3799 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3800 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3801 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3802 unless they are used.
38d0b34a
PE
3803 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3804 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3805 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3806 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3807 (x_error_catcher, x_connection_closed, x_error_handler):
3808 (x_error_quitter, xembed_send_message, x_iconify_frame):
3809 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3810 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3811 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3812
44f230aa
SM
3813 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3814 Rename or move locals to avoid shadowing.
6b463e58 3815 (tty_defined_color, merge_face_heights): Now static.
5967d051 3816 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3817 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3818 does not deduce is never used uninitialized.
73719eba
PE
3819 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3820 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3821
426994c3 3822 * terminal.c (store_terminal_param): Now static.
5489860b 3823
032f1620 3824 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3825 (set_frame_menubar): Remove unused local.
d4323972 3826 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3827 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3828 since they might point to immutable storage.
281585b0
PE
3829 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3830 since it's unused otherwise.
032f1620 3831
367c19e5 3832 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3833 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3834 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3835 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3836 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3837 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3838 does not deduce are never used uninitialized.
70739cbe 3839
07b48fa9
PE
3840 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3841
8868a238 3842 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3843 * window.c (window_loop, size_window):
3844 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3845
7e5cf297 3846 * window.c (display_buffer): Now static.
d6550a9f
PE
3847 (size_window): Mark variables that gcc -Wuninitialized
3848 does not deduce are never used uninitialized.
a586633d
PE
3849 * window.h (check_all_windows): New decl, to forestall
3850 gcc -Wmissing-prototypes diagnostic.
5b555da1 3851 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3852
f6095868
PE
3853 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3854 shadowing.
3855 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3856 Include <limits.h>.
3857 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3858 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3859 (load_charset_map): Mark variables that gcc -Wuninitialized
3860 does not deduce are never used uninitialized.
53df7c11 3861 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3862
f38b440c
PE
3863 * coding.c (coding_set_source, coding_set_destination):
3864 Use "else { /* comment */ }" rather than "else /* comment */;"
3865 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3866 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3867 a block, when the outer 'i' will do.
3868 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3869 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3870 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3871 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3872 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3873 Rename locals to avoid shadowing.
3874 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3875 * coding.c (emacs_mule_char, encode_invocation_designation):
3876 Now static, since they're not used elsewhere.
413bb2db 3877 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3878 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3879 (decode_coding_emacs_mule): Mark variables that gcc
3880 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3881 (detect_coding_iso_2022): Initialize a local variable that might
3882 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3883 this initialization is needed. (Bug#8211)
5f58e762
PE
3884 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3885 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3886 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3887 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3888 Remove unused macros.
f38b440c 3889
232b38b9 3890 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3891 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3892 * character.c (string_count_byte8): Likewise.
232b38b9 3893
fb90da1b
PE
3894 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3895 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3896
fb93dbc2
PE
3897 * chartab.c (copy_sub_char_table): Now static, since it's not used
3898 elsewhere.
5c156ace
PE
3899 (sub_char_table_ref_and_range, char_table_ref_and_range):
3900 Rename locals to avoid shadowing.
bbcd0949 3901 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3902
7d3b3862 3903 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3904 (BIDI_BOB): Remove unused macro.
7d3b3862 3905
6be7d3da
PE
3906 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3907 deduce are never used uninitialized.
c2ed9c8b 3908 * term.c (encode_terminal_code): Likewise.
6be7d3da 3909
75f8807f 3910 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3911
50938595
PE
3912 * tparam.h: New file.
3913 * term.c, tparam.h: Include it.
3914 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3915 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3916 Move these decls to tparam.h, and make them agree with what
3917 is actually in tparam.c. The previous trick of using incompatible
3918 decls in different modules does not conform to the C standard.
3919 All callers of tparam changed to use tparam's actual API.
3920 * tparam.c (tparam1, tparam, tgoto):
3921 Use const pointers where appropriate.
3922
fbceeba2
PE
3923 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3924 * cm.h (struct cm): Likewise.
3925 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3926 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3927 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3928 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3929 (turn_on_face, init_tty): Likewise.
3930 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3931
7f3f1250
PE
3932 * term.c (term_mouse_position): Rename local to avoid shadowing.
3933
e6ca6543
PE
3934 * alloc.c (mark_ttys): Move decl from here ...
3935 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3936
c40f8d15
AS
39372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3938
3939 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3940
cfe0661d
JB
39412011-03-09 Juanma Barranquero <lekktu@gmail.com>
3942
3943 * search.c (compile_pattern_1): Remove argument regp, unused since
3944 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3945 (compile_pattern): Don't pass it.
3946
0afb4571
J
39472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3948
3949 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3950 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3951 for ! HAVE_GTK3.
3952 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3953
3954 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3955
3956 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3957 gdk_window_get_screen, gdk_window_get_geometry,
3958 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3959 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3960 (xg_get_pixbuf_from_pixmap): New function.
3961 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3962 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3963 Call xg_get_pixbuf_from_pixmap instead of
3964 gdk_pixbuf_get_from_drawable.
3965 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3966 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3967 (xg_check_special_colors): Use GtkStyleContext and its functions
3968 for HAVE_GTK3.
3969 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3970 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3971 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3972 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3973 Call gtk_widget_get_preferred_size.
0afb4571
J
3974 (xg_frame_resized): gdk_window_get_geometry only takes 5
3975 parameters.
44f230aa
SM
3976 (xg_win_to_widget, xg_event_is_for_menubar):
3977 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3978 (xg_set_widget_bg): New function.
3979 (delete_cb): New function.
895009e1 3980 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3981 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3982 (xg_set_background_color): Call xg_set_widget_bg.
3983 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3984 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3985 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3986 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3987 if ! HAVE_GTK3.
3988 (update_frame_tool_bar): Call gtk_widget_hide.
3989 (xg_initialize): Use GDK_KEY_g.
3990
3991 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3992 if ! HAVE_GTK3
3993 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3994
3995 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3996 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3997 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3998
1c2cc4ef
JB
39992011-03-08 Juanma Barranquero <lekktu@gmail.com>
4000
4001 * w32xfns.c (select_palette): Check success of RealizePalette against
4002 GDI_ERROR, not zero.
4003
33383987 4004See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4005
4006;; Local Variables:
4007;; coding: utf-8
aac0c6e3
MR
4008;; End:
4009
33383987 4010 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4011
4012 This file is part of GNU Emacs.
4013
4014 GNU Emacs is free software: you can redistribute it and/or modify
4015 it under the terms of the GNU General Public License as published by
4016 the Free Software Foundation, either version 3 of the License, or
4017 (at your option) any later version.
4018
4019 GNU Emacs is distributed in the hope that it will be useful,
4020 but WITHOUT ANY WARRANTY; without even the implied warranty of
4021 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4022 GNU General Public License for more details.
4023
4024 You should have received a copy of the GNU General Public License
4025 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.