* sysdep.c (system_process_attributes): Improve comment.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
773d47f6
PE
12012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2
3 * sysdep.c (system_process_attributes): Improve comment.
4
f2d6a3df
SM
52012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6
7 * keyboard.c: Export real-this-command to Elisp.
8 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
9 and DEFVAR it. Update all users.
10
63810350
PE
112012-06-02 Paul Eggert <eggert@cs.ucla.edu>
12
7bd5c1f4
PE
13 * minibuf.c (Fassoc_string): Remove duplicate declaration.
14
63810350
PE
15 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
16 Convert pctcpu and pctmem to Lisp float properly.
17 Let the compiler fold better, as 100.0/0x8000 is exact.
18
a2821611
AS
192012-06-02 Andreas Schwab <schwab@linux-m68k.org>
20
21 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
22 cons_block.
23
5fceba1d
PE
242012-06-01 Paul Eggert <eggert@cs.ucla.edu>
25
26 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
27
c98ff5dd
DA
282012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
29
30 For a 'struct window', replace some Lisp_Object fields to
31 bitfields where appropriate, remove unused fields.
32 * window.h (struct window): Remove unused 'last_mark_x' and
33 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
34 change it's type from Lisp_Object to bitfield.
35 Change type of 'force_start', 'optional_new_start',
36 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
37 fields from Lisp_Object to bitfield. Adjust users accordingly.
38
ca34e0be
PE
392012-05-31 Paul Eggert <eggert@cs.ucla.edu>
40
41 Pacify gcc -Wdouble-precision when using Xaw.
42 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
43 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
44 Use 'float' consistently, rather than 'float' in most places
45 and 'double' in a couple of places.
46
efc00ab1 472012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
48
49 * xdisp.c (handle_stop): Detect whether we have overlay strings
50 loaded by testing it->current.overlay_string_index to be
51 non-negative, instead of checking whether n_overlay_strings is
52 positive. (Bug#11587)
53
efc00ab1 542012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
55
56 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
57
58 * doc.c (Fsubstitute_command_keys): Doc fix.
59
efc00ab1 602012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
61
62 * search.c (search_buffer): Remove calls to
63 r_alloc_inhibit_buffer_relocation, as it is now called by
64 maybe_unify_char, which was the cause of relocation of buffer text
65 in bug#11519.
66
efc00ab1 672012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
68
69 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
70 for the duration of call to load_charset, to avoid problems with
71 callers of maybe_unify_char that access buffer text through C
72 pointers.
73
74 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
75 decrement the inhibition flag, instead of just setting or
76 resetting it.
77
ba93a187
PE
782012-05-31 Paul Eggert <eggert@cs.ucla.edu>
79
80 Remove obsolete '#define static' cruft.
81 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
82 This #undef was "temporary" in 2000; it is no longer needed
83 now that '#define static' has gone away.
84 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
85 (gray_bitmap_bits): Remove; no longer needed.
86 All uses replaced with definiens.
87 * xterm.c: Include "bitmaps/gray.xbm".
88
9e4bf381
PE
892012-05-30 Paul Eggert <eggert@cs.ucla.edu>
90
91 Clean up __executable_start, monstartup when --enable-profiling.
92 The following changes affect the code only when profiling.
93 * dispnew.c (__executable_start): Rename from safe_bcopy.
94 Define only on platforms that need it.
95 * emacs.c: Include <sys/gmon.h> when profiling.
96 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
97 (__executable_start): Remove decl, since lisp.h does it now.
98 (safe_bcopy): Remove decl; no longer has that name.
99 (main): Coalesce #if into single bit of code, for simplicity.
100 Cast pointers to uintptr_t, since standard libraries want integers
101 and not pointers.
102 * lisp.h (__executable_start): New decl.
103
32d72c2f
GM
1042012-05-31 Glenn Morris <rgm@gnu.org>
105
106 * image.c (Fimagemagick_types): Doc fix.
107
baac5bc7
JM
1082012-05-30 Jim Meyering <meyering@redhat.com>
109
110 * callproc.c (Fcall_process_region): Include directory component
111 in mkstemp error message (Bug#11586).
112
72cb32cf
PE
1132012-05-30 Paul Eggert <eggert@cs.ucla.edu>
114
115 * alloc.c, lisp.h (make_pure_vector): Now static.
116
61b108cc
SM
1172012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
118
119 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
120 Move to byte-run.el.
121 (Fautoload): Do the hash-doc more carefully.
122 * data.c (Fdefalias): Purify definition, except for keymaps.
123 (Qdefun): Move from eval.c.
124 * lisp.h (Qdefun): Remove.
125 * lread.c (read1): Tiny simplification.
126
471fe23d
TN
1272012-05-29 Troels Nielsen <bn.troels@gmail.com>
128
934f3f58 129 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
130 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
131 Bug#9642, but explicitly check that the buffer the overlay would
132 be moved to is live and rearrange lines to make sure that errors
133 will not put the overlay in an inconsistent state.
134 (Fdelete_overlay): Cosmetics.
135
85d0efd1
EZ
1362012-05-28 Eli Zaretskii <eliz@gnu.org>
137
138 * w32term.c (my_bring_window_to_top): New function.
139 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
140 could be different from the original one.
141 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
142 (Bug#11513)
143
144 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
145 by calling BringWindowToTop.
146
147 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
148 (WM_EMACS_END): Increase by one.
149
da92a98c
PE
1502012-05-28 Paul Eggert <eggert@cs.ucla.edu>
151
152 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
153 This avoids undefined behavior that might cause the eassert
154 to not catch an out-of-range value.
155
74d1f848
JB
1562012-05-28 Juanma Barranquero <lekktu@gmail.com>
157
158 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
159 Update dependencies.
160
9e1a06fc
EZ
1612012-05-27 Eli Zaretskii <eliz@gnu.org>
162
163 * bidi.c (bidi_mirror_char): Fix last change.
164
f3dd7312
AS
1652012-05-27 Andreas Schwab <schwab@linux-m68k.org>
166
167 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
168 when referring to sectname field in printf format.
169
81899c91
PE
1702012-05-27 Paul Eggert <eggert@cs.ucla.edu>
171
57b81a9f
PE
172 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
173 Only r_alloc_inhibit_buffer_relocation needed to be added;
174 the others were already declared.
175
81899c91
PE
176 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
177 before checking whether it's out of range. Put the check inside
178 eassert. See
179 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
180
33017faf 1812012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
182
183 * callproc.c (Fcall_process): Restore a line that was accidentally
184 commented out in the 2011-02-13 change (bug#11547).
185
33017faf 1862012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
187
188 * lisp.h [REL_ALLOC]: Add prototypes for external functions
189 defined on ralloc.c.
190
191 * buffer.c [REL_ALLOC]: Remove prototypes of
192 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
193 they are now on lisp.h.
194
195 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
196
197 * search.c (search_buffer): Use it to inhibit relocation of buffer
198 text while re_search_2 is doing its job, because re_search_2 is
199 passed C pointers to buffer text. (Bug#11519)
200
23415acf
EZ
201 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
202 Update value to 24.
203
44e27368
EZ
204 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
205 state after an additional call to move_it_in_display_line_to, keep
206 the values of it->max_ascent and it->max_descent found for the
207 entire line.
208 (pos_visible_p): Revert the comparison against bottom_y to what it
209 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
210 (Bug#11464)
211
c1892f11
PE
2122012-05-26 Paul Eggert <eggert@cs.ucla.edu>
213
214 Fix coding-related core dumps with gcc -ftrapv.
215 The code was computing A - B, where A and B are pointers, and B is
216 random garbage. This can lead to core dumps on platforms that
217 have special pointer registers, and it also leads to core dumps on
218 x86-64 when compiled with gcc -ftrapv. The fix is to compute
219 A - B only when B is initialized properly.
220 * coding.c (coding_set_source, coding_set_destination): Return void.
221 (coding_change_source, coding_change_destinations): New functions,
222 with the old behaviors of coding_set_source and coding_set_destination.
223 All callers that need an offset changed to use these new functions.
224
eb7afdad
GM
2252012-05-26 Glenn Morris <rgm@gnu.org>
226
227 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
228
f12fdf02
EZ
2292012-05-26 Eli Zaretskii <eliz@gnu.org>
230
53a63be6 231 Extend mouse support on W32 text-mode console.
61b108cc
SM
232 * xdisp.c (draw_row_with_mouse_face):
233 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 234
eb3f6f01 235 * w32console.c: Include window.h.
61b108cc
SM
236 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
237 New functions.
eb3f6f01
EZ
238 (initialize_w32_display): Initialize mouse-highlight data.
239
53a63be6
EZ
240 * w32inevt.c: Include termchar.h and window.h.
241 (do_mouse_event): Support mouse-autoselect-window. When the mouse
242 moves, call note_mouse_highlight. If help_echo changed, call
243 gen_help_event to produce help-echo message in the echo area.
244 Call clear_mouse_face if mouse_face_hidden is set in the mouse
245 highlight info.
246
4cfd81f6
PE
2472012-05-26 Paul Eggert <eggert@cs.ucla.edu>
248
249 * lread.c (read1): Simplify slightly to avoid an overflow warning
250 with GCC 4.7.0 on x86-64.
251
4446092a
EZ
2522012-05-26 Eli Zaretskii <eliz@gnu.org>
253
254 * bidi.c (bidi_mirror_char): Revert last change: an int is
255 definitely wide enough here.
256
42b2a986 2572012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 258
42b2a986 259 Fix integer width and related bugs (Bug#9874).
eb106a49 260 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
261 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
262 (string_bytes, check_sblock, allocate_string_data):
263 (compact_small_strings, Fmake_bool_vector, make_string)
264 (make_unibyte_string, make_multibyte_string)
265 (make_string_from_bytes, make_specified_string)
266 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
267 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
268 (mark_vectorlike):
269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
270 (allocate_pseudovector):
271 Use int, not EMACS_INT, where int is wide enough.
272 (inhibit_garbage_collection, Fgarbage_collect):
273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
274 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
275 int might not be wide enough.
276 (bidi_cache_search, bidi_cache_find, bidi_init_it)
277 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
278 (bidi_at_paragraph_end, bidi_find_paragraph_start)
279 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
280 (bidi_level_of_next_char, bidi_move_to_visually_next):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
283 (Fkill_buffer, Fset_buffer_major_mode)
284 (advance_to_char_boundary, Fbuffer_swap_text)
285 (Fset_buffer_multibyte, overlays_at, overlays_in)
286 (overlay_touches_p, struct sortvec, record_overlay_string)
287 (overlay_strings, recenter_overlay_lists)
288 (adjust_overlays_for_insert, adjust_overlays_for_delete)
289 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
290 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
291 (Foverlay_recenter, last_overlay_modification_hooks_used)
292 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
294 (validate_region): Omit unnecessary test for b <= e,
295 since that's guaranteed by the previous test.
d311d28c
PE
296 (adjust_overlays_for_delete): Avoid pos + length overflow.
297 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
298 (report_overlay_modification):
299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
300 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
301 Omit pointer cast, which isn't needed anyway, and doesn't work
302 after the EMACS_INT -> ptrdiff_t change.
02481186 303 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
304 * buffer.h: Adjust decls to match defn changes elsewhere.
305 (struct buffer_text, struct buffer):
306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
307 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
308 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
309 not int, to avoid needless 32-bit limit on 64-bit hosts.
310 (exec_byte_code): Use tighter memory-full test, one that checks
311 for alloca overflow. Don't compute the address of the object just
312 before an array, as that's not portable. Use EMACS_INT, not
313 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
314 * callint.c (Fcall_interactively):
315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
316 * callproc.c (call_process_kill, Fcall_process):
317 Don't assume pid_t fits into an Emacs fixnum.
318 (call_process_cleanup, Fcall_process, child_setup):
319 Don't assume pid_t fits into int.
320 (call_process_cleanup, Fcall_process, delete_temp_file)
321 (Fcall_process_region):
322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
323 (Fcall_process): Simplify handling of volatile integers.
324 Use int, not EMACS_INT, where int will do.
325 * casefiddle.c (casify_object, casify_region, operate_on_word)
326 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
328 (casify_object): Avoid integer overflow when overallocating buffer.
329 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 330 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
331 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
332 * category.h (CATEGORYP): Don't assume arg is nonnegative.
333 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
334 integers are now checked earlier. All uses replaced with XINT.
335 (ccl_driver):
336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
337 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
338 (ccl_driver, Fregister_code_conversion_map):
339 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
340 (resolve_symbol_ccl_program): Check that vector header is in range.
341 Always copy the vector, so that we can check its contents reliably
342 now rather than having to recheck each instruction as it's being
343 executed. Check that vector words fit in 'int'.
344 (ccl_get_compiled_code, Fregister_ccl_program)
345 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
346 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
347 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
348 contents are in range.
349 (Fccl_execute_on_string): Check that status is in range.
350 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
351 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
352 Accept and return EMACS_INT, not int, because callers can pass values
353 out of 'int' range.
354 (c_string_width, strwidth, lisp_string_width, chars_in_text)
355 (multibyte_chars_in_text, parse_str_as_multibyte)
356 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
357 (str_as_unibyte, str_to_unibyte, string_count_byte8)
358 (string_escape_byte8, Fget_byte):
359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 360 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
361 avoid mishandling large integers.
362 * character.h: Adjust decls to match defn changes elsewhere.
363 * charset.c (load_charset_map_from_file, find_charsets_in_text)
364 (Ffind_charset_region):
365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
366 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
367 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 368 Don't assume fixnum fits in int.
d311d28c
PE
369 (load_charset_map_from_vector, Fmap_charset_chars):
370 Remove now-unnecessary CHECK_NATNUMs.
371 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
372 Don't rely on undefined behavior with signed left shift overflow.
373 Don't assume unsigned int fits into fixnum, or that fixnum fits
374 into unsigned int. Don't require max_code to be a valid fixnum;
375 that's not true for gb10830 4-byte on a 32-bit host. Allow
376 invalid_code to be a cons, for the same reason. Require code_offset
377 to be a character. Avoid int overflow if max_char is close
378 to INT_MAX.
379 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
380 this is intended anyway and avoids some undefined behavior.
381 (load_charset_map): Pass unsigned, not int, as 2nd arg of
382 INDEX_TO_CODE_POINT, as that's what it expects.
383 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
384 * charset.h (DECODE_CHAR): Return int, not unsigned;
385 this is what was intended anyway, and it avoids undefined behavior.
386 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
387 integer-overflow issues.
388 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
389 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
390 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
391 * chartab.c (Fmake_char_table, Fset_char_table_range)
392 (uniprop_get_decoder, uniprop_get_encoder):
393 Don't assume fixnum fits in int.
394 * cmds.c (move_point): New function, that does the gist of
395 Fforward_char and Fbackward_char, but does so while checking
396 for integer overflow more accurately.
c96e5d6a 397 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
398 (Fforward_line, Fend_of_line, internal_self_insert)
399 (internal_self_insert):
400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
401 Fix a FIXME, by checking for integer overflow when calculating
402 target_clm and actual_clm.
403 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 404 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
405 (ASSURE_DESTINATION, coding_alloc_by_realloc)
406 (coding_alloc_by_making_gap, alloc_destination)
407 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
408 (encode_coding_utf_16, detect_coding_emacs_mule)
409 (decode_coding_emacs_mule, encode_coding_emacs_mule)
410 (detect_coding_iso_2022, decode_coding_iso_2022)
411 (encode_invocation_designation, encode_designation_at_bol)
412 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
413 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
414 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
415 (encode_coding_ccl, encode_coding_raw_text)
416 (detect_coding_charset, decode_coding_charset)
417 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
418 (produce_composition, produce_charset, produce_annotation)
419 (decode_coding, handle_composition_annotation)
420 (handle_charset_annotation, consume_chars, decode_coding_gap)
421 (decode_coding_object, encode_coding_object, detect_coding_system)
422 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
423 (code_convert_region, code_convert_string)
8f50130c
PE
424 (Fdefine_coding_system_internal)
425 (coding_set_source, coding_set_destination):
d311d28c
PE
426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
427 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
428 (Fdefine_coding_system_internal):
429 Don't assume fixnums fit in int.
430 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 431 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
432 (Funencodable_char_position, Fcheck_coding_systems_region)
433 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 435 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 436 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 437 Don't access memory outside of the args array.
d311d28c 438 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
439 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
440 result of ENCODE_CHAR.
d311d28c
PE
441 * coding.h: Adjust decls to match defn changes elsewhere.
442 (struct coding_system):
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 * composite.c (get_composition_id, find_composition)
445 (run_composition_function, update_compositions)
446 (compose_text, composition_gstring_put_cache)
447 (composition_gstring_p, composition_gstring_width)
448 (fill_gstring_header, fill_gstring_body, autocmp_chars)
449 (composition_compute_stop_pos, composition_reseat_it)
450 (composition_update_it, struct position_record)
451 (find_automatic_composition, composition_adjust_point)
452 (Fcomposition_get_gstring, Ffind_composition_internal):
453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
454 (update_compositions):
455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
456 * composite.h: Adjust decls to match defn changes elsewhere.
457 (struct composition):
458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
459 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
460 Do not attempt to compute the address of the object just before a
461 buffer; this is not portable.
462 (Faref, Faset):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (Faset): Use int, not EMACS_INT, where int is wide enough.
465 (Fstring_to_number): Don't assume fixnums fit in int.
466 (Frem): Don't assume arg is nonnegative.
467 * dbusbind.c (xd_append_arg): Check for integers out of range.
468 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 469 (extract_signed, extract_unsigned): New functions.
243e0530
PE
470 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
471 (xd_get_connection_references): Return ptrdiff_t, not int.
472 All uses changed.
473 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
474 (xd_read_message_1):
475 Use int, not unsigned, where the dbus API uses int.
476 (Fdbus_message_internal): Don't overflow mtype.
477 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
478 * dired.c (directory_files_internal, file_name_completion, scmp)
479 (file_name_completion_stat):
480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
481 (file_name_completion): Don't overflow matchcount.
482 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
483 * dispextern.h: Adjust decls to match defn changes elsewhere.
484 (struct text_pos, struct glyph, struct bidi_saved_info)
485 (struct bidi_string_data, struct bidi_it, struct composition_it)
486 (struct it):
487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
488 (struct display_pos, struct composition_it, struct it):
489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
490 * dispnew.c (increment_matrix_positions)
491 (increment_row_positions, mode_line_string)
492 (marginal_area_string):
493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 494 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
495 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
496 (duration_to_sec_usec): New function, to check for overflow better.
497 (Fsleep_for, sit_for): Use it.
498 * doc.c (get_doc_string, store_function_docstring):
499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
500 (get_doc_string, Fsnarf_documentation):
501 Use int, not EMACS_INT, where int is wide enough.
502 (get_doc_string):
503 Use SAFE_ALLOCA, not alloca.
504 Check for overflow when converting EMACS_INT to off_t.
505 * doprnt.c (doprnt):
506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
507 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
508 Don't assume uid_t fits into fixnum.
509 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
510 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
511 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
512 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
513 (general_insert_function)
514 (Finsert_char, make_buffer_string, make_buffer_string_both)
515 (update_buffer_properties, Fbuffer_substring)
516 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
517 (Fsubst_char_in_region, check_translation)
518 (Ftranslate_region_internal, save_restriction_restore, Fformat)
519 (transpose_markers, Ftranspose_regions):
520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
521 (clip_to_bounds): Move to lisp.h as an inline function).
522 (Fconstrain_to_field): Don't assume integers are nonnegative.
523 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
524 (Fsubst_char_in_region, Fsave_restriction):
525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
526 (Femacs_pid): Don't assume pid_t fits into fixnum.
527 (lo_time): Use int, not EMACS_INT, when int suffices.
528 (lisp_time_argument): Check for usec out of range.
529 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
530 (Fuser_login_name, Fuser_full_name): Signal an error
531 if a uid argument is out of range, rather than relying on
532 undefined behavior.
c8d5c857
PE
533 (Fformat_time_string): Remove now-unnecessary check.
534 lisp_time_argument checks for out-of-range usec now.
243e0530 535 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
536 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
537 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
538 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
539 (init_cmdargs, Fdump_emacs):
540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
541 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
542 the bottom (typically) 32 bits of the fixnum.
543 * eval.c (specpdl_size, call_debugger):
544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
545 (when_entered_debugger, Fbacktrace_debug):
546 Don't assume fixnum can fit in int.
547 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
548 the object just before a buffer; this is not portable.
549 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
550 (grow_specpdl, unbind_to):
551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
552 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
553 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 554 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
555 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
556 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
558 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
559 (a_write, e_write):
560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
561 (Fcopy_file, non_regular_nbytes, read_non_regular)
562 (Finsert_file_contents):
563 Use int, not EMACS_INT, where int is wide enough.
564 (READ_BUF_SIZE): Verify that it fits in int.
565 (Finsert_file_contents): Check that counts are in proper range,
566 rather than assuming fixnums fit into ptrdiff_t etc.
567 Don't assume fixnums fit into int.
125b3835 568 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
569 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
570 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
571 (string_char_to_byte, string_byte_to_char)
572 (string_make_multibyte, string_to_multibyte)
573 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
574 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
575 (substring_both, Fdelete, internal_equal, Ffillarray)
576 (Fclear_string, mapcar1)
577 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
578 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
579 (larger_vector, make_hash_table, maybe_resize_hash_table)
580 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
581 (Fmaphash, secure_hash):
582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
583 (concat): Check for string index and length overflow.
584 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
585 (Frequire):
586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
587 (larger_vector): New API (vec, incr_min, size_max) replaces old
588 one (vec, new_size, init). This catches size overflow.
589 INIT was removed because it was always Qnil.
590 All callers changed.
591 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
592 the upper bound on a hash table index size.
593 (make_hash_table, maybe_resize_hash_table): Use it.
594 (secure_hash): Computer start_byte and end_byte only after
595 they're known to be in ptrdiff_t range.
596 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
597 (Ffont_get_glyphs, Ffont_at):
598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
599 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
600 (Flist_fonts, Fopen_font):
601 Don't assume fixnum can fit in int.
602 (check_gstring): Don't assume index can fit in int.
603 (font_match_p): Check that fixnum is a character, not a nonnegative
604 fixnum, since the later code needs to stuff it into an int.
605 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
606 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
607 conversion overflow issues.
608 (Fopen_font): Check for integer out of range.
609 (Ffont_get_glyphs): Don't assume index can fit in int.
610 * font.h: Adjust decls to match defn changes elsewhere.
611 * fontset.c (reorder_font_vector): Redo score calculation to avoid
612 integer overflow.
613 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
614 printmax_t, where ptrdiff_t is wide enough.
615 (Finternal_char_font):
616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
617 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
618 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
619 (Fset_frame_position, x_set_frame_parameters)
620 (x_set_line_spacing, x_set_border_width)
621 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
622 Check that fixnums are in proper range for system types.
623 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
625 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
626 Use SAFE_ALLOCA_LISP, not alloca.
627 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
628 intptr_t is wide enough.
629 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
630 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
631 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
632 Check for fixnum out of range.
633 * ftfont.c (ftfont_list): Don't assume index fits in int.
634 Check that fixnums are in proper range for system types.
635 (ftfont_shape_by_flt):
636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
637 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
639 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
640 Check that fixnums are in proper range for system types.
641 * gnutls.h: Adjust decls to match defn changes elsewhere.
642 * gtkutil.c (xg_dialog_run):
643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
644 (update_frame_tool_bar):
645 Check that fixnums are in proper range for system types.
646 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 647 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
648 * indent.c (last_known_column, last_known_column_point):
649 (current_column_bol_cache):
650 (skip_invisible, current_column, check_display_width):
651 (check_display_width, scan_for_column, current_column_1)
652 (Findent_to, Fcurrent_indentation, position_indentation)
653 (indented_beyond_p, Fmove_to_column, compute_motion):
654 (Fcompute_motion, Fvertical_motion):
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 (last_known_column_modified): Use EMACS_INT, not int.
657 (check_display_width):
658 (Fcompute_motion):
659 Check that fixnums and floats are in proper range for system types.
660 (compute_motion): Don't assume index or fixnum fits in int.
661 (compute_motion, Fcompute_motion):
662 Use int, not EMACS_INT, when it is wide enough.
663 (vmotion): Omit local var start_hpos that is always 0; that way
664 we don't need to worry about overflow in expressions involving it.
665 * indent.h: Adjust decls to match defn changes elsewhere.
666 (struct position):
667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
668 Use int, not EMACS_INT, where int is wide enough.
669 Remove unused members ovstring_chars_done and tab_offset;
670 all uses removed.
671 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
672 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
673 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
674 (make_gap, copy_text, insert, insert_and_inherit)
675 (insert_before_markers, insert_before_markers_and_inherit)
676 (insert_1, count_combining_before, count_combining_after)
677 (insert_1_both, insert_from_string)
678 (insert_from_string_before_markers, insert_from_string_1)
679 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
680 (adjust_after_replace, adjust_after_insert, replace_range)
681 (replace_range_2, del_range, del_range_1, del_range_byte)
682 (del_range_both, del_range_2, modify_region)
683 (prepare_to_modify_buffer, signal_before_change)
684 (signal_after_change, Fcombine_after_change_execute):
685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
686 * intervals.c (traverse_intervals, rotate_right, rotate_left)
687 (balance_an_interval, split_interval_right, split_interval_left)
688 (find_interval, next_interval, update_interval)
689 (adjust_intervals_for_insertion, delete_node, delete_interval)
690 (interval_deletion_adjustment, adjust_intervals_for_deletion)
691 (static_offset_intervals, offset_intervals)
692 (merge_interval_right, merge_interval_left, make_new_interval)
693 (graft_intervals_into_buffer, temp_set_point_both)
694 (temp_set_point, set_point, adjust_for_invis_intang)
695 (set_point_both, move_if_not_intangible, get_property_and_range)
696 (get_local_map, copy_intervals, copy_intervals_to_string)
697 (compare_string_intervals, set_intervals_multibyte_1):
698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
699 * intervals.h: Adjust decls to match defn changes elsewhere.
700 (struct interval):
701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
702 * keyboard.c (this_command_key_count, this_single_command_key_start)
703 (before_command_key_count, before_command_echo_length, echo_now)
704 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
705 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
706 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
707 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
709 (last_non_minibuf_size, last_point_position, echo_truncate)
710 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
711 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
712 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
713 (stuff_buffered_input):
714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
715 (last_auto_save, command_loop_1, read_char):
716 Use EMACS_INT, not int, to avoid integer overflow.
717 (record_char): Avoid overflow in total_keys computation.
718 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
719 * keyboard.h: Adjust decls to match defn changes elsewhere.
720 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
721 (Fkey_description, Fdescribe_vector, Flookup_key):
722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
723 (click_position): New function, to check that positions are in range.
724 (Fcurrent_active_maps):
725 (describe_command):
726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
727 (Faccessible_keymaps, Fkey_description):
728 (preferred_sequence_p):
729 Don't assume fixnum can fit into int.
730 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
731 Check for integer overflow in size calculations.
732 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
733 avoid mishandling large integers.
734 * lisp.h: Adjust decls to match defn changes elsewhere.
735 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
736 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
737 (struct Lisp_Marker):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
740 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
741 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
742 All callers changed.
743 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
744 Assume the arg has valid form, since it always does.
745 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
746 unsigned integer system type.
747 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
748 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
750 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
751 (duration_to_sec_usec): New decl.
752 * lread.c (read_from_string_index, read_from_string_index_byte)
753 (read_from_string_limit, readchar, unreadchar, openp)
754 (read_internal_start, read1, oblookup):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (Fload, readevalloop, Feval_buffer, Feval_region):
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 (openp): Check for out-of-range argument to 'access'.
759 (read1): Use int, not EMACS_INT, where int is wide enough.
760 Don't assume fixnum fits into int.
6efdadfd 761 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
762 (read_filtered_event): Use duration_to_sec_usec
763 to do proper overflow checking on durations.
d311d28c
PE
764 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
765 in size calculation.
766 (Fexecute_kbd_macro):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
769 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
770 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
771 (set_marker_both, set_marker_restricted_both, marker_position)
772 (marker_byte_position, Fbuffer_has_markers_at):
773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
774 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 775 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
776 It now merely ensures that the menu is large enough, without
777 necessarily growing it, as this avoids some integer overflow issues.
778 All callers changed.
779 (keymap_panes, parse_single_submenu, Fx_popup_menu):
780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
781 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
782 Use SAFE_ALLOCA_LISP, not alloca.
783 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
784 to EMACS_INT. Check that fixnums are in proper range for system types.
785 * minibuf.c (minibuf_prompt_width, string_to_object)
786 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
787 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
789 (get_minibuffer, read_minibuf_unwind):
790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
791 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
792 this simplifies overflow checking. All callers changed.
793 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
794 (Ftest_completion):
795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
796 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
797 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
798 Check that fixnums are in proper range for system types.
799 (Fx_create_frame, Fx_show_tip):
800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
801 * nsfont.m (ns_findfonts, nsfont_list_family):
802 Don't assume fixnum fits in long.
803 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
805 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
806 wide enough.
17fdb222 807 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
809 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
810 (PRINTDECLARE, PRINTPREPARE):
811 (strout, print_string):
812 (print, print_preprocess, print_check_string_charset_prop)
813 (print_object):
814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
815 (PRINTDECLARE):
816 (temp_output_buffer_setup, Fprin1_to_string, print_object):
817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
818 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 819 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 820 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
821 (print_error_message): Use SAFE_ALLOCA, not alloca.
822 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
823 (print_depth, new_backquote_output, print_number_index):
824 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
825 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
826 (Fset_process_window_size, Fformat_network_address)
827 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 828 (sigchld_handler):
d311d28c 829 Check that fixnums are in proper range for system types.
d44287d4 830 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
831 Check for process-ids out of pid_t range rather than relying on
832 undefined behavior.
e4d81efc 833 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
834 (Fformat_network_address, read_process_output, send_process)
835 (Fprocess_send_region, status_notify):
836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
837 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
838 (wait_reading_process_output, read_process_output, exec_sentinel):
839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
840 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
841 (Faccept_process_output): Use duration_to_sec_usec to do proper
842 overflow checking on durations.
dde14581
PE
843 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
844 Don't assume pid_t fits in int.
02481186
PE
845 * process.h (struct Lisp_Process): Members tick and update_tick
846 are now of type EMACS_INT, not int.
b62b53e8
PE
847 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
848 configured --with-wide-int.
d311d28c
PE
849 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
850 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
851 * search.c (looking_at_1, string_match_1):
852 (fast_string_match, fast_c_string_match_ignore_case)
853 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
854 (scan_newline, find_before_next_newline, search_command)
855 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
856 (set_search_regs, wordify):
857 (Freplace_match):
858 (Fmatch_data):
859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
860 (string_match_1, search_buffer, set_search_regs):
861 (Fmatch_data):
862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
863 (wordify): Check for overflow in size calculation.
864 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
865 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
866 Check that fixnums are in proper range for system types.
867 * sound.c (struct sound_device)
868 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
870 (Fplay_sound_internal):
871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 872 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
873 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
874 (Fparse_partial_sexp):
875 Don't assume fixnums can fit in int.
876 (struct lisp_parse_state, find_start_pos, find_start_value)
877 (find_start_value_byte, find_start_begv)
878 (update_syntax_table, char_quoted, dec_bytepos)
879 (find_defun_start, prev_char_comend_first, back_comment):
880 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
881 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
883 (Finternal_describe_syntax_value): Check that match_lisp is a
884 character, not an integer, since the code stuffs it into int.
885 (scan_words, scan_sexps_forward):
886 Check that fixnums are in proper range for system types.
887 (Fforward_word):
888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
889 (scan_sexps_forward):
890 Use CHARACTERP, not INTEGERP, since the value must fit into int.
891 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
892 * syntax.h: Adjust decls to match defn changes elsewhere.
893 (struct gl_state_s):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
895 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
896 MOST_POSITIVE_FIXNUM.
d311d28c
PE
897 * sysdep.c (wait_for_termination_1, wait_for_termination)
898 (interruptible_wait_for_termination, mkdir):
899 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
900 (emacs_read, emacs_write):
901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
902 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
903 and double all fit in int.
d311d28c
PE
904 * term.c (set_tty_color_mode):
905 Check that fixnums are in proper range for system types.
906 * termhooks.h (struct input_event):
907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
908 * textprop.c (validate_interval_range, interval_of)
909 (Fadd_text_properties, set_text_properties_1)
910 (Fremove_text_properties, Fremove_list_of_text_properties)
911 (Ftext_property_any, Ftext_property_not_all)
912 (copy_text_properties, text_property_list, extend_property_ranges)
913 (verify_interval_modification):
914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
915 (Fnext_single_char_property_change)
916 (Fprevious_single_char_property_change):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
918 (copy_text_properties):
919 Check for integer overflow in index calculation.
d311d28c
PE
920 * undo.c (last_boundary_position, record_point, record_insert)
921 (record_delete, record_marker_adjustment, record_change)
922 (record_property_change):
923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
924 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
926 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
927 (Fx_hide_tip, Fx_file_dialog):
928 * w32menu.c (set_frame_menubar):
929 Use ptrdiff_t, not int, for consistency with rest of code.
930 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
931 (select_window, Fdelete_other_windows_internal)
932 (window_scroll_pixel_based, window_scroll_line_based)
933 (Frecenter, Fset_window_configuration):
934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
935 (Fset_window_hscroll, run_window_configuration_change_hook)
936 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 937 (Fscroll_other_window, Frecenter):
d311d28c
PE
938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
939 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
940 Don't assume fixnum fits in int.
941 (Fset_window_scroll_bars):
942 Check that fixnums are in proper range for system types.
943 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
944 (string_pos, c_string_pos, number_of_chars, init_iterator)
945 (in_ellipses_for_invisible_text_p, init_from_display_pos)
946 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
947 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
948 (face_before_or_after_it_pos, handle_invisible_prop)
949 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
950 (display_prop_intangible_p, string_buffer_position_lim)
951 (string_buffer_position, handle_composition_prop, load_overlay_strings)
952 (get_overlay_strings_1, get_overlay_strings)
953 (iterate_out_of_display_property, forward_to_next_line_start)
954 (back_to_previous_visible_line_start, reseat, reseat_to_string)
955 (get_next_display_element, set_iterator_to_next)
956 (get_visually_first_element, compute_stop_pos_backwards)
957 (handle_stop_backwards, next_element_from_buffer)
958 (move_it_in_display_line_to, move_it_in_display_line)
959 (move_it_to, move_it_vertically_backward, move_it_by_lines)
960 (add_to_log, message_dolog, message_log_check_duplicate)
961 (message2, message2_nolog, message3, message3_nolog
962 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
963 (current_message_1, truncate_echo_area, truncate_message_1)
964 (set_message, set_message_1, store_mode_line_noprop)
965 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
966 (text_outside_line_unchanged_p, check_point_in_composition)
967 (reconsider_clip_changes)
968 (redisplay_internal, set_cursor_from_row, try_scrolling)
969 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
970 (redisplay_window, find_last_unchanged_at_beg_row)
971 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
972 (trailing_whitespace_p, find_row_edges, display_line)
973 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
974 (display_mode_element, store_mode_line_string)
975 (pint2str, pint2hrstr, decode_mode_spec)
976 (display_count_lines, display_string, draw_glyphs)
977 (x_produce_glyphs, x_insert_glyphs)
978 (rows_from_pos_range, mouse_face_from_buffer_pos)
979 (fast_find_string_pos, mouse_face_from_string_pos)
980 (note_mode_line_or_margin_highlight, note_mouse_highlight):
981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
982 (safe_call, init_from_display_pos, handle_fontified_prop)
983 (handle_single_display_spec, load_overlay_strings)
984 (with_echo_area_buffer, setup_echo_area_for_printing)
985 (display_echo_area, echo_area_display)
986 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
987 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
988 (redisplay_window, dump_glyph_row, display_mode_line)
989 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 990 (handle_display_spec, display_prop_string_p):
d311d28c
PE
991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
992 (handle_single_display_spec, build_desired_tool_bar_string)
993 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
994 (get_specified_cursor_type):
995 Check that fixnums are in proper range for system types.
996 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
997 (Flookup_image_map):
998 Don't assume fixnums fit in int.
999 (compare_overlay_entries):
1000 Avoid mishandling comparisons due to subtraction overflow.
1001 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1002 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1003 (handle_tool_bar_click):
1004 Use int, not unsigned, since we prefer signed and the signedness
1005 doesn't matter here.
1006 (get_next_display_element, next_element_from_display_vector):
1007 Use int, not EMACS_INT, when int is wide enough.
1008 (start_hourglass): Use duration_to_sec_usec to do proper
1009 overflow checking on durations.
1010 * xfaces.c (Fbitmap_spec_p):
1011 Check that fixnums are in proper range for system types.
1012 (compare_fonts_by_sort_order):
1013 Avoid mishandling comparisons due to subtraction overflow.
1014 (Fx_family_fonts, realize_basic_faces):
1015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1016 (Fx_family_fonts):
1017 Don't assume fixnum fits in int.
1018 Use SAFE_ALLOCA_LISP, not alloca.
1019 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1020 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1021 (face_at_buffer_position, face_for_overlay_string)
1022 (face_at_string_position):
1023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1024 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1025 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1026 (Fx_show_tip):
1027 Check that fixnums are in proper range for system types.
1028 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1029 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1031 (Fx_change_window_property): Don't assume fixnums fit in int.
1032 * xfont.c (xfont_chars_supported):
1033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1034 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1035 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1037 * xml.c (parse_region):
1038 * xrdb.c (magic_file_p):
1039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1040 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1041 (x_get_local_selection, x_reply_selection_request)
1042 (x_handle_selection_request, wait_for_property_change):
1043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1044 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1045 short is wide enough.
1046 (x_send_client_event): Don't assume fixnum fits in int.
1047 * xterm.c (x_x_to_emacs_modifiers):
1048 Don't assume EMACS_INT overflows nicely into int.
1049 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1050 may come from Lisp.
1051 (handle_one_xevent): NATNUMP can eval its arg twice.
1052 (x_connection_closed):
1053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1054 * xterm.h: Adjust decls to match defn changes elsewhere.
1055 (struct scroll_bar): Use struct vectorlike_header
1056 rather than rolling our own approximation.
1057 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1058
c6574eb5
GM
10592012-05-25 Glenn Morris <rgm@gnu.org>
1060
1061 * lisp.mk (lisp): Update for more files being compiled now.
1062
e8d32c7e
SM
10632012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1064
48def666
SM
1065 * lread.c: Remove `read_pure' which makes no difference.
1066 (read_pure): Remove var.
1067 (unreadpure): Remove function.
1068 (readevalloop): Don't call read_list with -1 flag.
1069 (read1, read_vector): Don't test read_pure any more.
1070 (read_list): Simplify.
1071
e8d32c7e
SM
1072 * fileio.c, character.h: Minor style tweaks.
1073
4b2addb7
DA
10742012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 * window.h (clip_changed): Remove useless declaration.
1077
584461b2
JB
10782012-05-22 Juanma Barranquero <lekktu@gmail.com>
1079
1080 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1081 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1082
34374650
PE
10832012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1084
1085 Remove src/m/*.
1086 This directory predates autoconf and is no longer needed nowadays.
1087 Move its few remaining bits of functionality to where they're needed.
1088 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1089 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1090 * m/template.h: Remove.
1091 * Makefile.in (M_FILE): Remove. All uses removed.
1092 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1093 * lisp.h (USE_LSB_TAG):
1094 * mem-limits.h (EXCEEDS_LISP_PTR):
1095 Use VAL_MAX, not VALBITS, in #if.
1096 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1097 (EMACS_UINT): Define unconditionally now.
1098 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1099 (BITS_PER_EMACS_INT): New constants, replacing
1100 what used to be in config.h, but not useful in #if.
1101 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1102 define them any more.
1103 (VAL_MAX): New macro.
1104 (VALMASK): Use it.
1105 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1106 BITS_PER_EMACS_INT, in #if.
1107 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1108 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1109 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1110 * s/ms-w32.h (DATA_START):
1111 Move here from removed file m/intel386.h.
1112 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1113 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1114
261cb4bb
PE
11152012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1116
1117 Assume C89 or later.
1118 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1119 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1120 (xrealloc):
1121 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1122 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1123 * textprop.c, tparam.c (NULL): Remove.
1124 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1125 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1126 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1127 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1128 * xterm.c (input_signal_count): Assume volatile works.
1129
ff23cd9f
KB
11302012-05-21 Ken Brown <kbrown@cornell.edu>
1131
1132 * xgselect.c (xg_select): Fix first argument in call to 'select'
1133 (bug#11508).
1134
1b170bc6
KB
11352012-05-20 Ken Brown <kbrown@cornell.edu>
1136
1137 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1138 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1139
b2f4d39f
KB
11402012-05-19 Ken Brown <kbrown@cornell.edu>
1141
1142 * xfns.c (x_in_use): Remove `static' qualifier.
1143 * xterm.h (x_in_use): Declare.
1144 * xgselect.c: Include xterm.h.
1145 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1146 and `display_arg' (bug#9754).
1147
003fdae2
PE
11482012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1149
9232a6d9
PE
1150 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1151
003fdae2
PE
1152 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1153 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1154
784b56e2
EZ
11552012-05-18 Eli Zaretskii <eliz@gnu.org>
1156
1157 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1158
1159 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1160 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1161
1162 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1163 reference to image_cache->refcount.
1164 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1165
a0a79cde
JL
11662012-05-17 Juri Linkov <juri@jurta.org>
1167
1168 * search.c (Fword_search_regexp, Fword_search_backward)
1169 (Fword_search_forward, Fword_search_backward_lax)
1170 (Fword_search_forward_lax): Move functions to isearch.el
1171 (bug#10145, bug#11381).
1172
b0572523
PE
11732012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1176
9660f5fc
SM
11772012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * lread.c (init_obarray): Declare Qt and Qnil as special.
1180
4374de83
GM
11812012-05-14 Glenn Morris <rgm@gnu.org>
1182
1183 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1184 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1185
dc44c39a
PE
11862012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1187
078c97cb
PE
1188 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1189
dc44c39a
PE
1190 * unexaix.c: Port to more-recent AIX compilers.
1191 (report_error, report_error_1, make_hdr, copy_sym)
1192 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1193 Make arguments const char *, not char *, to avoid violations of C
1194 standard and to fix some AIX warnings reported by Gilles Pion.
1195
e18afed7 11962012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1197
1198 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1199 already have overlays loaded.
1200 (handle_single_display_spec): Before returning without displaying
1201 fringe bitmap, synchronize the bidi iterator with the main display
1202 iterator, by calling iterate_out_of_display_property.
1203 (iterate_out_of_display_property): Detect buffer iteration by
1204 testing that it->string is a Lisp string.
1205 (get_next_display_element): When the current object is exhausted,
1206 and there's something on it->stack, call set_iterator_to_next to
1207 proceed with what's on the stack, instead of returning zero.
1208 (set_iterator_to_next): If called at the end of a Lisp string,
1209 proceed to consider_string_end without incrementing string
1210 position. Don't increment display vector index past the end of
1211 the display vector. (Bug#11417)
c8fb9dc6
EZ
1212 (pos_visible_p): Don't report a position visible when move_it_to
1213 stopped at the last line of window, which happens to be scanned
1214 backwards by the bidi iteration. (Bug#11464)
ac268e67 1215
e18afed7 12162012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1217
1218 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1219 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1220 are on a TTY, and thus unable to display on the fringes.
1221 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1222 so we need to signal to the caller that this is a "replacing"
1223 display spec. This fixes display when the spec is invalid or we
1224 are on a TTY.
1225
e18afed7 12262012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1227
1228 * unexaix.c (make_hdr): Fix typo in prototype.
1229 This bug broke the build on AIX. Problem reported by Gilles Pion.
1230
9d0a235a
MA
12312012-05-14 Michael Albinus <michael.albinus@gmx.de>
1232
1233 * keyboard.c (kbd_buffer_get_event): Read special events also in
1234 batch mode. (Bug#11415)
1235
9e6b06ed
GM
12362012-05-12 Glenn Morris <rgm@gnu.org>
1237
1238 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1239
c1a1d7a3
EZ
12402012-05-12 Eli Zaretskii <eliz@gnu.org>
1241
1242 * lisp.mk (lisp): Add newcomment.elc.
1243
3fe7cdc8
GM
12442012-05-12 Glenn Morris <rgm@gnu.org>
1245
1246 * Makefile.in (MKDIR_P): New, set by configure.
1247 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1248
53f7d2c0
PE
12492012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1250
1251 Remove unused function hourglass_started.
1252 * dispextern.h (hourglass_started):
1253 * w32fns.c (hourglass_started):
1254 * xdisp.c (hourglass_started): Remove.
1255
75aafb17
JB
12562012-05-10 Juanma Barranquero <lekktu@gmail.com>
1257
1258 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1259 Update dependencies.
1260
12959e8e
PE
12612012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1262
97107e2e
PE
1263 * xgselect.c (xg_select): Put maxfds+1 into a var.
1264 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1265
12959e8e
PE
1266 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1267
836d29b3
DA
12682012-05-10 Dave Abrahams <dave@boostpro.com>
1269
1270 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1271 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1272
5cb67954
MA
12732012-05-09 Michael Albinus <michael.albinus@gmx.de>
1274
1275 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1276 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1277 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1278 Initialize xd_registered_buses.
1279
3478ec45
PE
12802012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1281
b263a6b0
PE
1282 Untag more efficiently if USE_LSB_TAG.
1283 This is based on a proposal by YAMAMOTO Mitsuharu in
1284 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1285 For an admittedly artificial (nth 8000 longlist) benchmark on
1286 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1287 Emacs's overall text size by 1%.
1288 * lisp.h (XUNTAG): New macro.
1289 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1290 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1291 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1292 * eval.c (Fautoload):
1293 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1294 * frame.h (XFRAME): Use XUNTAG.
1295
3478ec45
PE
1296 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1297 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1298 Remove unportable assumptions about print widths of types like
1299 dbus_uint32_t.
1300 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1301 intptr_t when converting between pointer and integer, to avoid GCC
1302 warnings about wrong width.
1303
666b903b 13042012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1305
1306 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1307 stack for each reader_thread, instead of defaulting to 8MB
1308 determined by the linker. This avoids failures in creating
1309 subprocesses on Windows 7, see the discussion in this thread:
1310 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1311
b120cc17
JC
13122012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1313
1314 Fix up display of the *Minibuf-0* buffer in the mini window.
1315 * keyboard.c (read_char): Don't clear the echo area if there's no
1316 message to clear.
1317 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1318 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1319
9a4b36f8
MA
13202012-05-07 Michael Albinus <michael.albinus@gmx.de>
1321
1322 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1323 batch mode.
1324
e5f9458f
CY
13252012-05-06 Chong Yidong <cyd@gnu.org>
1326
1327 * lisp.mk (lisp): Update.
1328
eceeb5fc 13292012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1330
1331 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1332
71873e2b
SM
13332012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1334
1335 * data.c (PUT_ERROR): New macro.
1336 (syms_of_data): Use it. Add new error type `user-error'.
1337 * undo.c (user_error): New function.
1338 (Fprimitive_undo): Use it.
1339 * print.c (print_error_message): Adjust print style for `user-error'.
1340 * keyboard.c (user_error): New function.
1341 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1342
ab0fa4e4
PE
13432012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 Do not limit current-time-string to years 1000..9999.
1346 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1347 (Fcurrent_time_string): Support any year that is supported by the
1348 underlying localtime representation. Don't use asctime, as it
1349 has undefined behavior for years outside the range -999..9999.
1350
7ed806a7
PE
13512012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 Fix race conditions involving setenv, gmtime, localtime, asctime.
1354 Without this fix, interrupts could mess up code that uses these
1355 nonreentrant functions, since setting TZ invalidates existing
1356 tm_zone or tzname values, and since most of these functions return
1357 pointers to static storage.
1358 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1359 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1360 Grow the critical sections to include not just invoking
1361 localtime/gmtime, but also accessing these functions' results
1362 including their tm_zone values if any, and any related TZ setting.
1363 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1364 so that the struct tm is saved in the critical section.
1365 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1366 motivated by the fact that memory allocation needs to be outside
1367 the critical section.
1368
0c16dfed
DA
13692012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1370
1371 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1372 with RESET_INTERVAL.
1373
1374 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1375 Remove duplicated buffer name initialization.
1376
3f83ace8
JM
13772012-05-02 Jim Meyering <jim@meyering.net>
1378
1379 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1380
c7b8541e
JM
1381 * xfns.c (x_window): Use xstrdup (Bug#11375).
1382
90207a15 13832012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1384
1385 * xdisp.c (pos_visible_p): If already at a newline from the
1386 display string before the 'while' loop, don't walk back the glyphs
1387 from it3.glyph_row. Solves assertion violation when the display
1388 string begins with a newline (egg.el). (Bug#11367)
1389
b593d6a9
AH
13902012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1391
1392 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1393 Move to simple.el.
1394
4737362e
GM
13952012-05-01 Glenn Morris <rgm@gnu.org>
1396
99cf43f9
GM
1397 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1398 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1399 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1400 All were removed before 23.1.
1401
9311dcff
GM
1402 * dispnew.c: Remove HAVE_LIBNCURSES test;
1403 it is always true on relevant platforms.
1404
4d5c6349
GM
1405 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1406 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1407
4737362e
GM
1408 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1409
74dd3a6b
AS
14102012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1411
1412 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1413 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1414 Remove.
1415
13c379ee
PE
14162012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 Do not avoid creating empty evaporating overlays (Bug#9642).
1419 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1420 That is, do not delete an evaporating overlay if it becomes
1421 empty after its bounds are adjusted to fit within its buffer.
1422 This fix caused other problems, and I'm reverting it until we get
1423 to the bottom of them.
1424
a8e7d6d7 14252012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1426
1427 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1428
a8e7d6d7 14292012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1430
1431 * xdisp.c (pos_visible_p): If the window start position is beyond
1432 ZV, start the display from buffer beginning. Prevents assertion
1433 violation in init_iterator when the minibuffer window is scrolled
1434 via the scroll bar.
1435
1436 * window.c (window_scroll_pixel_based): Likewise.
1437
a8e7d6d7 14382012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1439
1440 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1441
a8e7d6d7 14422012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1443
1444 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1445 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1446
a8e7d6d7 14472012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1448
b593d6a9
AH
1449 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1450 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1451
1c6900d9
EZ
14522012-04-26 Eli Zaretskii <eliz@gnu.org>
1453
4c3fa1d9
EZ
1454 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1455 display element, check also the underlying string or buffer
1456 character. (Bug#11341)
1457
1c6900d9
EZ
1458 * w32menu.c: Include w32heap.h.
1459 (add_menu_item): If the call to AppendMenuW (via
1460 unicode_append_menu) fails, disable Unicode menus only if we are
1461 running on Windows 9X/Me.
1462
42bf8205
AS
14632012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1464
1465 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1466 (xgetint): Add missing shift for LSB tags.
1467
b1bac16e
MR
14682012-04-24 Martin Rudalics <rudalics@gmx.at>
1469
1470 * keyboard.c (read_char): Don't wipe echo area for select window
1471 events: These might get delayed via `mouse-autoselect-window'
1472 (Bug#11304).
1473
d69621cc
JB
14742012-04-24 Juanma Barranquero <lekktu@gmail.com>
1475
1476 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1477 manipulation of :loaded-from data.
1478
02fd101b
JB
14792012-04-23 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1482 now a cons (bug#11311).
1483
888bec30
PE
14842012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1485
89a438bd
PE
1486 Do not create empty overlays with the evaporate property (Bug#9642).
1487 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1488 if it becomes empty after its bounds are adjusted to fit within
1489 its buffer. Without this fix, in a nonempty buffer (let ((o
1490 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1491 yields an empty overlay that has the evaporate property, which is
1492 not supposed to happen.
1493
1068fe4d
PE
1494 Fix minor GTK3 problems found by static checking.
1495 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1496 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1497 (struct _EmacsFixedClass, emacs_fixed_get_type):
1498 Move decls here from emacsgtkfixed.h, since they needn't be public.
1499 (emacs_fixed_get_type): Now static.
1500 (emacs_fixed_class_init): Omit unused local.
1501 (emacs_fixed_child_type): Remove; unused.
1502 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1503 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1504 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1505 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1506 (EMACS_FIXED_GET_CLASS): Remove; unused.
1507 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1508
888bec30
PE
1509 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1510 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1511
de85e130
PE
15122012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1513
d0baac98 1514 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1515 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1516 (__malloc_size_t, __malloc_ptrdiff_t):
1517 Remove. All uses removed, replaced by the definiens if needed,
1518 since we can assume C89 or better now.
1519 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1520 (protect_malloc_state, align, get_contiguous_space)
1521 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1522 (malloc_atfork_handler_child, malloc_enable_thread)
1523 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1524 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1525 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1526 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1527 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1528 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1529 Define using prototypes, not old style.
1530 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1531 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1532 (align): Don't assume that signed integer overflow wraps around.
1533 Omit unused local var.
1534 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1535 (_free_internal_nolock, memalign, mallochook, reallochook):
1536 Omit no-longer-needed casts.
1537 (valloc): Use getpagesize, not __getpagesize.
1538 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1539 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1540
de85e130
PE
1541 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1542
dcbf5805
MA
15432012-04-22 Michael Albinus <michael.albinus@gmx.de>
1544
1545 Move functions from C to Lisp. Make non-blocking method calls
1546 the default. Implement further D-Bus standard interfaces.
1547
1548 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1549 (QCdbus_request_name_allow_replacement)
1550 (QCdbus_request_name_replace_existing)
1551 (QCdbus_request_name_do_not_queue)
1552 (QCdbus_request_name_reply_primary_owner)
1553 (QCdbus_request_name_reply_in_queue)
1554 (QCdbus_request_name_reply_exists)
1555 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1556 (QCdbus_registered_serial, QCdbus_registered_method)
1557 (QCdbus_registered_signal): New Lisp objects.
1558 (XD_DEBUG_MESSAGE): Use sizeof.
1559 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1560 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1561 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1562 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1563 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1564 (xd_signature, xd_append_arg): Allow float for integer types.
1565 (xd_get_connection_references): New function.
b593d6a9
AH
1566 (xd_get_connection_address): Rename from xd_initialize.
1567 Return cached address.
dcbf5805
MA
1568 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1569 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1570 level.
1571 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1572 Return number of refcounts.
dcbf5805
MA
1573 (Fdbus_get_unique_name): Make stronger parameter check.
1574 (Fdbus_message_internal): New defun.
1575 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1576 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1577 (Fdbus_send_signal, Fdbus_register_service)
1578 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1579 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1580 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1581 (Vdbus_compiled_version, Vdbus_runtime_version)
1582 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1583 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1584 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1585 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1586 Adapt docstring.
dcbf5805 1587
52828e02
PE
15882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1589
da05bc4c
PE
1590 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1591 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1592 Do not assume ptrdiff_t is the same width as 'int'.
1593
52828e02
PE
1594 * alloc.c: Handle unusual debugging option combinations.
1595 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1596 since the two debugging options are incompatible.
1597 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1598 is defined.
1599 (mem_init, mem_insert, mem_insert_fixup):
1600 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1601 (NEED_MEM_INSERT): Remove; no longer needed.
1602
f01769f9
LL
16032012-04-22 Leo Liu <sdl.web@gmail.com>
1604
1605 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1606
5790543d
PE
16072012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1608
1609 * sysdep.c [__FreeBSD__]: Minor cleanups.
1610 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1611 Use Emacs indenting style more consistently. Avoid some casts.
1612 Use 'double' consistently rather than mixing 'float' and 'double'.
1613
b91b7e4d
EW
16142012-04-21 Eduard Wiebe <usenet@pusto.de>
1615
b593d6a9
AH
1616 * sysdep.c (list_system_processes, system_process_attributes):
1617 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1618
6114eb15
AS
16192012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1620
1621 * lisp.mk (lisp): Update.
1622
2f38dff7
PE
16232012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1624
1625 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1626 It is never used otherwise.
1627
4ae29f89
SM
16282012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1629
1630 * print.c (print_preprocess): Only check print_depth if print-circle
1631 is nil.
1632 (print_object): Check for cycles even when print-circle is nil and
1633 print-gensym is t, but only check print_depth if print-circle is nil.
1634
f30d612a
CY
16352012-04-20 Chong Yidong <cyd@gnu.org>
1636
1637 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1638 set the status to "failed" and ensure that sentinel is run.
1639
c07a4c0b 16402012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1641
1642 * process.c (Fset_process_inherit_coding_system_flag)
1643 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1644 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1645
c07a4c0b 16462012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1647
1648 * xdisp.c (string_buffer_position_lim): Limit starting position to
1649 BEGV.
1650 (set_cursor_from_row): If called for a mode-line or header-line
1651 row, return zero immediately.
1652 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1653 farther than the first row after the header line, if any.
1654 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1655 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1656
c07a4c0b 16572012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1658
4ae29f89
SM
1659 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1660 (bug#11238).
ad3a2b41 1661
c07a4c0b 16622012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 16632012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1664
1665 configure: new option --enable-gcc-warnings (Bug#11207)
1666 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1667 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1668 (ALL_CFLAGS): Use new macros rather than old.
1669 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1670 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1671 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1672 -Wunused-result, -Wunused-variable. This should go away once
1673 the Emacs and Gnulib regex code is merged.
1674 (xmalloc, xrealloc): Now static.
1675
aba027e8
PE
16762012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * dired.c (Fsystem_groups): Remove unused local.
1679
e5a36063
GM
16802012-04-17 Glenn Morris <rgm@gnu.org>
1681
1682 * dired.c (Fsystem_users): Doc fix.
1683
316411f0
DA
16842012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1685
1686 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1687 (syms_of_dired): Add them.
1688
9426aba4
PE
16892012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1690
b62a57be
PE
1691 Fix minor alloc.c problems found by static checking.
1692 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1693 New extern decls, to avoid calling undeclared functions.
1694 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1695 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1696 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1697 (NEED_MEM_INSERT): New macro.
1698 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1699 Remove one incorrect comment and fix another.
b62a57be 1700
3539f31f
PE
1701 Fix minor ralloc.c problems found by static checking.
1702 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1703 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1704 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1705 (r_alloc_sbrk): Now static.
1706
a041960a
PE
1707 Improve ralloc.c interface checking.
1708 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1709 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1710 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1711 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1712 [REL_ALLOC]: ... to here, to check interface.
1713 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1714 Remove decls. This fixes an "It stinks!".
1715
9426aba4
PE
1716 * alloc.c (which_symbols): Fix alignment issue / type clash.
1717
d55c12ed
AS
17182012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1719
1720 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1721 (struct Lisp_Misc_Any): Likewise.
1722 (struct Lisp_Free): Likewise.
1723 * alloc.c (union aligned_Lisp_Symbol): Define.
1724 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1725 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1726 (union aligned_Lisp_Misc): Define.
1727 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1728 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1729 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1730
b948ce8b
PE
17312012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1734 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1735 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1736 * s/netbsd.h, s/sol2-6.h:
1737 Remove definition of GC_MARK_STACK, since the default now works.
1738 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1739 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1740 no longer the default.
1741 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1742
35dc09a1 17432012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1744
35dc09a1
GM
1745 * lread.c (lisp_file_lexically_bound_p):
1746 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1747
35dc09a1
GM
17482012-04-14 Eli Zaretskii <eliz@gnu.org>
1749
1750 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1751 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1752
17532012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1754
1755 * nsterm.m (constrainFrameRect): Always constrain when there is only
1756 one screen (Bug#10962).
1757
bcd86815
KB
17582012-04-13 Ken Brown <kbrown@cornell.edu>
1759
1760 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1761
c25df26e
RT
17622012-04-13 Reuben Thomas <rrt@sc3d.org>
1763
1764 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1765
0fc59f1e
DC
17662012-04-11 Daniel Colascione <dancol@dancol.org>
1767
1768 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1769 against is gone. It's better to use vfork now so that when Cygwin
1770 gains a new, working vfork, we use it automatically (bug#10398).
1771
de8c03dc
SM
17722012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1773
1774 * window.c (save_window_save): Obey window-point-insertion-type.
1775
2f097256
GM
17762012-04-11 Glenn Morris <rgm@gnu.org>
1777
1778 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1779
453b951e
SM
17802012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1781
1782 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1783
75f1671a 17842012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1785
1786 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1787 (force_quit_count): New var.
1788 (handle_interrupt): Use it.
1789
2a8ce227
JB
17902012-04-10 Juanma Barranquero <lekktu@gmail.com>
1791
1792 * w32.c (w32_delayed_load): Record the full path of the library
1793 being loaded (bug#10424).
1794
935396c0
GM
17952012-04-09 Glenn Morris <rgm@gnu.org>
1796
05920a43
GM
1797 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1798 not just in the obarray, before snarfing them. (Bug#11036)
1799
935396c0
GM
1800 * Makefile.in ($(leimdir)/leim-list.el):
1801 Pass EMACS rather than BUILT_EMACS.
1802
a18ecafa
TZ
18032012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1804
1805 * process.c (make_process):
1806 * process.h: Add integer `gnutls_handshakes_tried' member to
1807 process struct.
1808
6bbef4e5
JC
1809 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1810 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1811
1812 * gnutls.c (gnutls_log_function2i): Convenience log function.
1813 (emacs_gnutls_read): Use new log functions,
1814 `gnutls_handshakes_tried' process member, and
1815 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1816 attempts per process (connection).
1817
b4d3bc10
CY
18182012-04-09 Chong Yidong <cyd@gnu.org>
1819
1820 * eval.c (Fuser_variable_p, user_variable_p_eh)
1821 (lisp_indirect_variable): Functions deleted.
1822 (Fdefvar): Caller changed.
1823
1824 * callint.c (Finteractive, Fcall_interactively):
1825 * minibuf.c (Fread_variable): Callers changed.
1826
70f4d973
EZ
18272012-04-09 Eli Zaretskii <eliz@gnu.org>
1828
1829 * xdisp.c (set_cursor_from_row): If the display string appears in
1830 the buffer at position that is closer to point than the position
1831 after the display string, display the cursor on the first glyph of
1832 the display string. Fixes cursor display when a 'display' text
1833 property immediately follows invisible text. (Bug#11094)
1834
cb3c2e3e
PE
18352012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 composite.c: use 'double' consistently
1838 * composite.c (get_composition_id): Use 'double' consistently
1839 instead of converting 'float' to 'double' and vice versa; this is
1840 easier to understand and avoids a GCC warning.
1841
fd06db5d
GM
18422012-04-09 Glenn Morris <rgm@gnu.org>
1843
50fe702a
GM
1844 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1845 preparation for dumping it with emacs. (Bug#4789)
1846 (leimdir): New variable.
1847 ($(leimdir)/leim-list.el): New rule.
1848 (emacs$(EXEEXT)): Depend on leim-list.el.
1849
fd06db5d
GM
1850 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1851 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1852 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1853
55c131ee
AS
18542012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1855
1856 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1857 proper alignment.
1858
9209588f
JB
18592012-04-07 Juanma Barranquero <lekktu@gmail.com>
1860
1861 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1862 Remove unused local variable.
1863
e3fb2efb
PE
18642012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1867 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1868 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1869 objects, as mark_maybe_pointer will catch them otherwise.
1870 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1871 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1872
b5385551
PE
18732012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1874
1875 Fix typo that broke non-Windows builds.
1876 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1877
9078ead6
EZ
18782012-04-07 Eli Zaretskii <eliz@gnu.org>
1879
1880 Support building on MS-Windows with libxml2.
1881
1882 * makefile.w32-in (OBJ2): Add xml.$(O).
1883 (GLOBAL_SOURCES): Add xml.c.
1884 ($(BLD)/xml.$(O)): New dependency list.
1885
1886 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1887 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1888 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1889 [!WINDOWSNT]: New macros.
1890 (init_libxml2_functions, libxml2_loaded_p): New functions.
1891 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1892 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1893 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1894 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1895 linked in).
6bbef4e5
JC
1896 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1897 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1898 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1899
1900 * emacs.c: Don't include libxml/parser.h.
1901 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1902 xmlCleanupParser directly.
1903
1904 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1905
3811fdf3
EZ
19062012-04-07 Eli Zaretskii <eliz@gnu.org>
1907
1908 * indent.c (Fvertical_motion): If there is a display string at
1909 point, use it.vpos to compute how many lines to backtrack after
1910 move_it_to point. (Bug#11133)
1911
2f8e16b2
EZ
19122012-04-06 Eli Zaretskii <eliz@gnu.org>
1913
1914 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1915 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1916 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1917 macros related to unification of CJK characters. For the details,
1918 see the discussion following the message here:
1919 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1920
3d439cd1
CY
19212012-04-04 Chong Yidong <cyd@gnu.org>
1922
1923 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1924
8bc53d00
EZ
19252012-04-01 Eli Zaretskii <eliz@gnu.org>
1926
1927 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1928 instead of alloca. (Bug#11138)
1929
3b0512a3
AS
19302012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1931
1932 * w32menu.c (is_simple_dialog): Properly check lisp types.
1933 (Bug#11141)
1934
8427ddd2
EZ
19352012-03-31 Eli Zaretskii <eliz@gnu.org>
1936
979022ef
EZ
1937 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1938 position we get to after a call to move_it_to fails the
1939 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1940 only if we wind up in a string from display property. (Bug#11063)
1941
a6b1c7cc
EZ
1942 * window.c (Fdelete_other_windows_internal): Invalidate the row
1943 and column information about mouse highlight, so that redisplay
1944 restores it after reallocating the glyph matrices. (Bug#7464)
1945
8427ddd2
EZ
1946 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1947 string comes from a `display' text property, use the buffer
1948 position of that property as if we actually saw that position in
1949 the row's glyphs.
697ba24b
EZ
1950 (move_it_by_lines): Remove the assertion that
1951 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1952 violated when there's a before-string at the beginning of a line.
1953 (Bug#11063)
8427ddd2 1954
65a0a738
EZ
19552012-03-30 Eli Zaretskii <eliz@gnu.org>
1956
1957 * xdisp.c (append_space_for_newline): If the default face was
1958 remapped, use the remapped face for the appended newline.
1959 (extend_face_to_end_of_line): Use the remapped default face for
1960 extending the face to the end of the line.
1961 (display_line): Call extend_face_to_end_of_line when the default
1962 face was remapped. (Bug#11068)
1963
581355cc
EZ
19642012-03-29 Eli Zaretskii <eliz@gnu.org>
1965
1966 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1967
e8fc049f
SM
19682012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1969
1970 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1971
4fb9a543
GM
19722012-03-27 Glenn Morris <rgm@gnu.org>
1973
1974 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1975 Doc fixes.
1976
679910f1
KH
19772012-03-26 Kenichi Handa <handa@m17n.org>
1978
1979 * dispextern.h (struct glyph): Fix previous change. Change the
1980 bit length of glyphless.ch to 25 (Bug#11082).
1981
90d49b7f
CY
19822012-03-26 Chong Yidong <cyd@gnu.org>
1983
1984 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1985 (command_loop_1): Use it; inhibit selection update for
1986 handle-select-window too (Bug#8996).
1987
f514f6f0
FP
19882012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1989
e8fc049f 1990 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1991
bf43fa51
KH
19922012-03-25 Kenichi Handa <handa@m17n.org>
1993
1994 * dispextern.h (struct glyph): Change the bit length of
1995 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1996
8a0c01dd
EZ
19972012-03-24 Eli Zaretskii <eliz@gnu.org>
1998
1999 * s/ms-w32.h (tzname): Include time.h before redirecting to
2000 _tzname. Fixes the MSVC build. (Bug#9960)
2001
7d1c3a76
AS
20022012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2003
8ed79523
AS
2004 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2005 characters.
2006
7d1c3a76
AS
2007 * xterm.c (XTread_socket): Only modify handling_signal if
2008 !SYNC_INPUT. (Bug#11080)
2009
e99a9b8b
EZ
20102012-03-23 Eli Zaretskii <eliz@gnu.org>
2011
2012 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2013 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2014 when fetching a multibyte character consumes more bytes than
2015 CHAR_BYTES returns, due to unification of CJK characters in
2016 string_char. (Bug#11073)
2017
5063c0e1
TN
20182012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2019
2020 * process.c (wait_reading_process_output): Handle pty disconnect
2021 by refraining from sending oneself a SIGCHLD (bug#10933).
2022
9f851fbd
CY
20232012-03-22 Chong Yidong <cyd@gnu.org>
2024
2025 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2026
5063c0e1 2027 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2028 Mark string as coming from a prefix property.
2029 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2030 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2031
fb5b8aca
CY
20322012-03-21 Chong Yidong <cyd@gnu.org>
2033
2034 * xfaces.c (Vface_remapping_alist): Doc fix.
2035
62356a1b
EZ
20362012-03-20 Eli Zaretskii <eliz@gnu.org>
2037
2038 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2039 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2040 Doc fixes.
62356a1b 2041
025de85b
CY
20422012-03-20 Chong Yidong <cyd@gnu.org>
2043
2044 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2045 to reflect default non-nil value of redisplay-dont-pause.
2046
4827f94e
KH
20472012-03-19 Kenichi Handa <handa@m17n.org>
2048
2049 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2050 it fit in a valid range (Bug#11003).
2051
e50a24a2
EZ
20522012-03-18 Eli Zaretskii <eliz@gnu.org>
2053
2054 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2055 that is not from display property, accept the row as a "cursor
2056 row" if one of the string's character has a non-nil `cursor'
2057 property. Fixes cursor positioning when there are newlines in
2058 overlay strings, e.g. in icomplete.el. (Bug#11035)
2059
9af5ed87
PE
20602012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2061
2062 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2063
d1f55f16
CY
20642012-03-12 Chong Yidong <cyd@gnu.org>
2065
2066 * eval.c (inhibit_lisp_code): Rename from
2067 inhibit_window_configuration_change_hook; move from window.c.
2068
2069 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2070 * window.c (run_window_configuration_change_hook)
2071 (syms_of_window): Callers changed.
2072
66c5eebd
CY
20732012-03-11 Chong Yidong <cyd@gnu.org>
2074
413df973
CY
2075 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2076
66c5eebd
CY
2077 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2078
1de11f56
CY
20792012-03-10 Chong Yidong <cyd@gnu.org>
2080
2081 * frame.c (other_visible_frames): Don't assume the selected frame
2082 is visible (Bug#10955).
2083
cae07000
SM
20842012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2085
2086 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2087
89c94350
JD
20882012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2091 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2092 zero (Bug#10954).
2093
999dd333
GM
20942012-03-03 Glenn Morris <rgm@gnu.org>
2095
01a6dcc8 2096 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2097
de0100f2
EZ
20982012-03-02 Eli Zaretskii <eliz@gnu.org>
2099
2100 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2101 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2102 (redisplay_window, next_element_from_string): Fix typos in
2103 comments.
3e441275
EZ
2104 (redisplay_window): Pass to move_it_vertically the margin in
2105 pixels, not in screen lines.
de0100f2 2106
96a72ee9
GM
21072012-03-02 Glenn Morris <rgm@gnu.org>
2108
2109 * buffer.c (buffer-list-update-hook): Doc fix.
2110
312508d7
EZ
21112012-02-29 Eli Zaretskii <eliz@gnu.org>
2112
2113 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2114 push_it before setting up the iterator for the first overlay
2115 string, even if we have an empty string loaded.
2116 (next_overlay_string): If there's an empty string on the iterator
2117 stack, pop the stack. (Bug#10903)
2118
27f3c637
PE
21192012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2120
2121 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2122 Suggested by Stefan Monnier in
2123 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2124 * alloc.c (widen_to_Lisp_Object): New static function.
2125 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2126 and widening them to Lisp_Objects. This would work even if
2127 USE_LSB_TAG is defined and wide integers are used, which might
2128 happen in a future version of Emacs.
2129
3c9dfce6
CY
21302012-02-25 Chong Yidong <cyd@gnu.org>
2131
fa74b241
CY
2132 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2133 Doc fix.
2134
3c9dfce6
CY
2135 * xselect.c (Fx_selection_exists_p): Doc fix.
2136 (x_clipboard_manager_save_all): Print an informative message
2137 before saving to clipboard manager.
2138
9486df08
CY
21392012-02-24 Chong Yidong <cyd@gnu.org>
2140
2141 * keyboard.c (process_special_events): Handle all X selection
2142 requests in kbd_buffer, not just the next one (Bug#8869).
2143
f01d3321
CY
21442012-02-23 Chong Yidong <cyd@gnu.org>
2145
2146 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2147 call when setting menu-bar-lines and tool-bar-lines parameters.
2148 (unwind_create_frame_1): New helper function.
2149
2150 * window.c (inhibit_window_configuration_change_hook): New var.
2151 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2152 (syms_of_window): Initialize it.
f01d3321 2153
86b847b6
CY
21542012-02-22 Chong Yidong <cyd@gnu.org>
2155
2156 * xterm.c (x_draw_image_relief): Add missing type check for
2157 Vtool_bar_button_margin (Bug#10743).
2158
a59225b1
CY
21592012-02-21 Chong Yidong <cyd@gnu.org>
2160
2161 * fileio.c (Vfile_name_handler_alist): Doc fix.
2162
2163 * buffer.c (Fget_file_buffer): Protect against invalid file
2164 handler return value.
2165
310f5bd4
PE
21662012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2167
cb3a28cc
PE
2168 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2169 when computing $valmask.
2170
310f5bd4
PE
2171 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2172 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2173 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2174 It's useless in that case, and it can cause problems on hosts
2175 that allocate halves of EMACS_INT values separately.
2176 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2177 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2178 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2179 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2180 it avoids undefined behavior on hosts where shifting right by more
2181 than the word width has undefined behavior.
2182
2375c96a
CY
21832012-02-19 Chong Yidong <cyd@gnu.org>
2184
2185 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2186 (Funhandled_file_name_directory, Ffile_name_as_directory)
2187 (Fdirectory_file_name, Fexpand_file_name)
2188 (Fsubstitute_in_file_name): Protect against invalid file handler
2189 return values (Bug#10845).
2190
3eb49e71
EZ
21912012-02-18 Eli Zaretskii <eliz@gnu.org>
2192
2193 * .gdbinit (pitx): Fix incorrect references to fields of the
2194 iterator stack.
2195
7b926f3f
CY
21962012-02-17 Chong Yidong <cyd@gnu.org>
2197
2198 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2199
11273115
PE
22002012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2201
2202 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2203 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2204
c3a70e2b
CY
22052012-02-15 Chong Yidong <cyd@gnu.org>
2206
2207 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2208 marked as special. Also, starting docstrings with * is obsolete.
2209
0ca43699
AS
22102012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2211
2212 * gnutls.c (emacs_gnutls_write): Fix last change.
2213
2e8f3c56
LI
22142012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2215
2216 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2217 send_process.
2218
af70074f
SM
22192012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2220
2221 * keymap.c (Fsingle_key_description): Handle char ranges.
2222
95986d52
CY
22232012-02-12 Chong Yidong <cyd@gnu.org>
2224
afd83bd1
CY
2225 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2226 as that creates a dangerous corner case.
2227
95986d52
CY
2228 * window.c (Fdelete_window_internal): Invalidate the mouse
2229 highlight (Bug#9904).
2230
bd7da63e
GM
22312012-02-12 Glenn Morris <rgm@gnu.org>
2232
2233 * xselect.c (Fx_own_selection_internal)
2234 (Fx_get_selection_internal, Fx_disown_selection_internal)
2235 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2236 * nsselect.m (Fx_own_selection_internal)
2237 (Fx_disown_selection_internal, Fx_selection_exists_p)
2238 (Fx_selection_owner_p, Fx_get_selection_internal):
2239 Sync docs and argument specs with the xselect.c versions.
2240
77abcbc2
LI
22412012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2242
2243 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2244
90b671e2
EZ
22452012-02-11 Eli Zaretskii <eliz@gnu.org>
2246
1c0ca0b7
EZ
2247 * w32select.c (Fx_selection_exists_p): Sync doc string and
2248 argument list with xselect.c. (Bug#10783)
2249
2250 * w16select.c (Fx_selection_exists_p): Sync doc string and
2251 argument list with xselect.c. (Bug#10783)
90b671e2 2252
49241268
GM
22532012-02-10 Glenn Morris <rgm@gnu.org>
2254
2255 * fns.c (Fsecure_hash): Doc fix.
2256
f998bbe7 22572012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2258
2259 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2260
0992bd9c
CY
22612012-02-07 Chong Yidong <cyd@gnu.org>
2262
2263 * buffer.c (Fbuffer_local_variables)
2264 (buffer_lisp_local_variables): Handle unbound vars correctly;
2265 don't let Qunbound leak into Lisp.
2266
af008560
GM
22672012-02-07 Glenn Morris <rgm@gnu.org>
2268
dd605cc4
GM
2269 * image.c (Fimagemagick_types): Doc fix.
2270
af008560
GM
2271 * image.c (imagemagick-render-type): Change it from a lisp object
2272 to an integer. Move the doc here from the lisp manual.
2273 Treat all values not equal to 0 the same.
2274
1449fa1d
CY
22752012-02-06 Chong Yidong <cyd@gnu.org>
2276
2277 * doc.c (store_function_docstring): Avoid applying docstring of
2278 alias to base function (Bug#2603).
2279
3723ec07
AS
22802012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2281
2282 * .gdbinit (pp1, pv1): Remove redundant defines.
2283 (pr): Use pp.
2284
79c1cc1e
CY
22852012-02-04 Chong Yidong <cyd@gnu.org>
2286
2287 * nsterm.m: Declare a global (Bug#10694).
2288
d7f29f8e
EZ
22892012-02-04 Eli Zaretskii <eliz@gnu.org>
2290
cae07000
SM
2291 * w32.c (get_emacs_configuration_options):
2292 Include --enable-checking, if specified, in the return value.
d7f29f8e 2293
3b95a6f9
MR
22942012-02-04 Martin Rudalics <rudalics@gmx.at>
2295
2296 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2297 after rounding frame sizes. (Bug#9723)
2298
d6fa96a6
EZ
22992012-02-04 Eli Zaretskii <eliz@gnu.org>
2300
2301 * keyboard.c (adjust_point_for_property): Don't position point
2302 before BEGV. (Bug#10696)
2303
df0b2940
PE
23042012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 Handle overflow when computing char display width (Bug#9496).
2307 * character.c (char_width): Return EMACS_INT, not int.
2308 (char_width, c_string_width): Check for overflow when
2309 computing the width; this is possible now that individual
2310 characters can have unbounded width. Problem introduced
2311 by merge from Emacs 23 on 2012-01-19.
2312
6bee44d6
MA
23132012-02-02 Michael Albinus <michael.albinus@gmx.de>
2314
2315 * dbusbind.c (Fdbus_register_method): Mention the return value
2316 :ignore in the docstring.
2317
44f92739
GM
23182012-02-02 Glenn Morris <rgm@gnu.org>
2319
1b9f60cc
GM
2320 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2321
44f92739
GM
2322 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2323 Unconditionally set to t. (Bug#10673)
2324 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2325 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2326 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2327
c5d3843c
KH
23282012-02-02 Kenichi Handa <handa@m17n.org>
2329
2330 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2331 0, do not call append_composite_glyph.
2332
159462d4 23332012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2334
2335 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2336 NULL (Bug#6988).
2337 (x_produce_glyphs): If the component of a composition is a null
2338 string, set it->pixel_width to 1 to avoid zero-width glyph.
2339
78cef877
EZ
23402012-02-01 Eli Zaretskii <eliz@gnu.org>
2341
2342 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2343 first 2 arguments are identical. This makes inserting large
2344 output from a subprocess an order of magnitude faster on
2345 MS-Windows, where all sbrk'ed memory is always contiguous.
2346
97897668
GM
23472012-01-31 Glenn Morris <rgm@gnu.org>
2348
2349 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2350 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2351 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2352
31fd3586
GM
23532012-01-29 Glenn Morris <rgm@gnu.org>
2354
2355 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2356
0e24a8b2
CY
23572012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2358
2359 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2360
cc0adcb0
CY
23612012-01-28 Chong Yidong <cyd@gnu.org>
2362
2363 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2364
acc28cb9
CY
23652012-01-26 Chong Yidong <cyd@gnu.org>
2366
9c69cfb7
CY
2367 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2368
acc28cb9
CY
2369 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2370 repeat counts (Bug#10507).
2371
48da7392
GM
23722012-01-26 Glenn Morris <rgm@gnu.org>
2373
2374 * lread.c (syms_of_lread): Doc fix.
2375
14af5f7f
CY
23762012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2377
2378 * coding.c (encode_designation_at_bol): Change return value to
2379 EMACS_INT.
2380
0b21c100
CY
23812012-01-25 Chong Yidong <cyd@gnu.org>
2382
2383 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2384
3c2907f7
CY
23852012-01-21 Chong Yidong <cyd@gnu.org>
2386
2387 * floatfns.c (Fcopysign): Make the second argument non-optional,
2388 since nil is not allowed anyway.
2389
959ad23f
AS
23902012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2391
2392 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2393 (send_process): Likewise.
2394
34a02f46
MR
23952012-01-19 Martin Rudalics <rudalics@gmx.at>
2396
2397 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2398 (Vwindow_persistent_parameters): Do not use Qstate.
2399 Rewrite doc-strings.
34a02f46 2400
1259009a 24012012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2402
2403 * character.c (char_width): New function.
70d4fdf6
GM
2404 (Fchar_width, c_string_width, lisp_string_width):
2405 Use char_width (Bug#9496).
25ed9e61 2406
6a6ee00d
MR
24072012-01-16 Martin Rudalics <rudalics@gmx.at>
2408
2409 * window.c (Vwindow_persistent_parameters): New variable.
2410 (Fset_window_configuration, save_window_save): Handle persistent
2411 window parameters.
2412
c85efaf7
EZ
24132012-01-14 Eli Zaretskii <eliz@gnu.org>
2414
2415 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2416 thrashing the stack of the thread. (Bug#9087)
2417
5944709e
PE
24182012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2419
2420 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2421
e71f5d99
EZ
24222012-01-11 Eli Zaretskii <eliz@gnu.org>
2423
2424 * xdisp.c (rows_from_pos_range): Handle the case where the
2425 highlight ends on a newline. (Bug#10464)
2426 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2427 he end column for display of highlight that ends on a newline
2428 before a R2L line.
2429
ce316182
GM
24302012-01-11 Glenn Morris <rgm@gnu.org>
2431
2432 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2433 from load-path also when installation-directory is nil. (Bug#10208)
2434
5b43da69
GM
24352012-01-10 Glenn Morris <rgm@gnu.org>
2436
74cc8ff9
GM
2437 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2438
7d8d6e4e
GM
2439 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2440 Update template values to be closer to their typical values these days.
5b43da69 2441
a0db8d43
EZ
24422012-01-09 Eli Zaretskii <eliz@gnu.org>
2443
2444 * xdisp.c (rows_from_pos_range): Accept additional argument
2445 DISP_STRING, and accept any glyph in a row whose object is that
2446 string as eligible for mouse highlight. Fixes mouse highlight of
2447 display strings from overlays. (Bug#10464)
2448
9a0115ab 24492012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2450
b9110d6a 2451 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2452 * fileio.c (auto_saving_dir_umask): New static var.
2453 (Fmake_directory_internal): Use it.
2454 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2455 creating the directory. The old code temporarily assigns
2456 too-generous permissions to the directory.
2457 (do_auto_save_eh): Clear it.
b9110d6a 2458 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2459 that the var is always cleared.
2460
6c1bd3f3
EZ
24612012-01-07 Eli Zaretskii <eliz@gnu.org>
2462
2463 * search.c (scan_buffer): Pass character positions to
2464 know_region_cache, not byte positions. (Bug#6540)
2465
069d2b50
L
24662012-01-07 LynX <_LynX@bk.ru> (tiny change)
2467
2468 * w32.c (sys_rename): Report EXDEV when rename of a directory
2469 fails because the target is on another logical disk. (Bug#10284)
2470
75bf0d33
DB
24712012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2472
2473 * xterm.c (x_embed_request_focus): New function.
2474
2475 * xterm.h: Add prototype.
2476
2477 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2478
1c6e5a32
GM
24792012-01-05 Glenn Morris <rgm@gnu.org>
2480
2481 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2482
651e947e
EZ
24832012-01-01 Eli Zaretskii <eliz@gnu.org>
2484
2485 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2486 Load gnutls_transport_set_lowat only if GnuTLS version is below
2487 2.11.1.
2488 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2489 GnuTLS versions below 2.11.1.
2490
3778cdd8
AL
24912011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2492
2493 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2494 to the doc string advising against its use for altering the way
2495 windows are scrolled.
2496
0e5317f7
KH
24972011-12-28 Kenichi Handa <handa@m17n.org>
2498
2499 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2500 coding-system ASCII compatible only when it does not produce BOM
2501 on encoding (Bug#10383).
2502
93d5ca1f
JD
25032011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2504
2505 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2506 can scroll.
2507 (create_and_show_popup_menu): Always use menu_position_func for
2508 Gtk3 (Bug#10361).
2509
ca22b785
AS
25102011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2511
2512 * callint.c (Fcall_interactively): Don't truncate prompt string.
2513
d048e1e6
EZ
25142011-12-23 Eli Zaretskii <eliz@gnu.org>
2515
2516 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2517 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2518 resumed from there (after widening). (Bug#10360)
d048e1e6 2519
5ccaba1f
JD
25202011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2521
2522 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2523
204ee57f
JD
25242011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2525
b81d40f0
JB
2526 * nsterm.m (x_free_frame_resources):
2527 Release f->output_data.ns->miniimage.
204ee57f
JD
2528 (ns_index_color): Fix indentation. Do not retain
2529 color_table->colors[i].
2530
2531 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2532 before returning.
2533
2534 * nsfns.m (x_set_background_color): Assign return value from
2535 ns_index_color to face-background instead of NSColor*.
2536 (ns_implicitly_set_icon_type): Fix indentation.
2537 Change assignment in for loop to comparison.
2538
2539 * emacs.c (ns_pool): New variable.
2540 (main): Assign ns_pool.
2541 (Fkill_emacs): Call ns_release_autorelease_pool.
2542
2543 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2544 autorelease fdesc, release fdAttrs and tdict.
2545 (ns_get_covering_families): Release charset.
2546 (ns_findfonts): Release NSFontDescriptor created with new.
2547 (ns_uni_to_glyphs): Fix indentation.
2548 (setString): Release attrStr before assigning new value.
2549
c803b2b7
JD
25502011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2551
678f4426
JD
2552 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2553 and NS_IMPL_COCOA.
2554 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2555 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2556
cd394be1 25572011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2558
5fecd5fc
JD
2559 * nsterm.m (ns_term_init): Subscribe for notifications
2560 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2561 to method trackingNotification in EmacsMenu.
2562
2563 * nsmenu.m (trackingMenu): New variable.
3771cb17 2564 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2565 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2566 from Aquamacs (Bug#7030).
678f4426
JD
2567
25682011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2569
c803b2b7
JD
2570 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2571 (symbol_to_nsstring): Fix indentation.
2572 (ns_symbol_to_pb): New function.
cae07000
SM
2573 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2574 (Fns_rotate_cut_buffers_internal): Remove.
2575 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2576 Fns_store_cut_buffer_internal.
2577 (ns_get_foreign_selection, Fx_own_selection_internal)
2578 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2579 (Fns_get_selection_internal, Fns_store_selection_internal):
2580 Use ns_symbol_to_pb and check if return value is nil.
2581 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2582 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2583 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2584 renamed to Sns_store_selection_internal.
2585 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2586 and remove this function.
2587 (ns_handle_selection_clear): Remove, never used.
2588 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2589 here.
2590
e1b01a3a
KB
25912011-12-17 Ken Brown <kbrown@cornell.edu>
2592
2593 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2594 GID is unknown (Bug#10257).
2595
2adb6e85
PE
25962011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2597
2598 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2599 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2600 which caused a build failure on GNU/Linux IA-64. This problem was
2601 introduced by my 2011-10-07 patch.
2602
d1d7b339
JL
26032011-12-15 Juri Linkov <juri@jurta.org>
2604
2605 * image.c (imagemagick_error): New function. (Bug#10112)
2606 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2607 Use `imagemagick_error' where ImageMagick functions return
2608 `MagickFalse'.
2609 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2610 proper order.
2611
100d5755
KH
26122011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2613
2614 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2615 fill background (Bug#8992).
2616
454592a6
MR
26172011-12-13 Martin Rudalics <rudalics@gmx.at>
2618
2619 * window.c (Vwindow_combination_resize)
2620 (Vwindow_combination_limit): Use t instead of non-nil in
2621 doc-strings.
61d4b438
MR
2622 (Vrecenter_redisplay): Add first sentence of doc-string on
2623 separate line.
53524d93 2624 (Frecenter): Fix doc-string typo.
454592a6 2625
3633e3aa
KH
26262011-12-11 Kenichi Handa <handa@m17n.org>
2627
2628 * coding.c (Funencodable_char_position): Pay attention to the
2629 buffer text relocation (Bug#9389).
2630
7b9d523a 26312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2632
7b9d523a
JD
2633 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2634 gtk_init (Bug#10100).
2635
b73189c6
EZ
26362011-12-10 Eli Zaretskii <eliz@gnu.org>
2637
2638 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2639 IT->string is nil. (Bug#10263)
2640
f7dfe5d6
JD
26412011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2642
83faebb4
JD
2643 * nsterm.h (x_free_frame_resources): Declare.
2644
f7dfe5d6
JD
2645 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2646 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2647
2648 * nsterm.h (ns_get_defaults_value): Declare.
2649
2650 * nsterm.m (ns_default): Call ns_get_defaults_value.
2651
7cd4e72c
EZ
26522011-12-09 Eli Zaretskii <eliz@gnu.org>
2653
2654 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2655 (Bug#10170)
2656
b34d7317
YM
26572011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2658
2659 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2660 that where the value of an _OBJC_* symbol points to is in the .bss
2661 section (Bug#10240).
2662
76470ad1
KH
26632011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2664
2665 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2666 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2667
745fff94
KH
26682011-12-08 Kenichi Handa <handa@m17n.org>
2669
2670 * ftfont.c (get_adstyle_property): Fix previous change
2671 (Bug#10233).
2672
6e44397c
JB
26732011-12-07 Juanma Barranquero <lekktu@gmail.com>
2674
2675 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2676 dirs from the default value of EMACSLOADPATH (bug#10208).
2677
7efa6272
GM
26782011-12-07 Glenn Morris <rgm@gnu.org>
2679
2680 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2681 installation and source directories as well. (Bug#10208)
2682
f6fc4d87
CY
26832011-12-06 Chong Yidong <cyd@gnu.org>
2684
2685 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2686
2bf26180
GM
26872011-12-06 Glenn Morris <rgm@gnu.org>
2688
2689 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2690 as an error, not just -1. (Bug#10217)
2691
3a6ad4f0
CY
26922011-12-05 Chong Yidong <cyd@gnu.org>
2693
2694 * keyboard.c (process_special_events): New function.
2695 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2696
75a3b399
PE
26972011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2698
2699 * coding.c (encode_designation_at_bol): Don't use uninitialized
2700 local variable (Bug#9318).
2701
c3c9e25e
KH
27022011-12-05 Kenichi Handa <handa@m17n.org>
2703
2704 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2705 return Qnil (Bug#8046, Bug#10193).
2706
5eb05ea3
KH
27072011-12-05 Kenichi Handa <handa@m17n.org>
2708
2709 * coding.c (encode_designation_at_bol): New args charbuf_end and
2710 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2711 (coding_set_source): Return how many bytes coding->source was
2712 relocated.
2713 (coding_set_destination): Return how many bytes
2714 coding->destination was relocated.
2715 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2716 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2717
27182011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2719
2720 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2721 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2722 macro (Bug#9318).
2723
27242011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2725
2726 The following changes are to fix Bug#9318.
2727
a79703f5 2728 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2729 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2730 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2731 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2732
7dbda6df
JB
27332011-12-05 Juanma Barranquero <lekktu@gmail.com>
2734
2735 * lisp.h (process_quit_flag): Fix external declaration.
2736
6d5eb5b0
SM
27372011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2738
2739 Don't macro-inline non-performance-critical code.
2740 * eval.c (process_quit_flag): New function.
2741 * lisp.h (QUIT): Use it.
2742
a0c3fad0
JD
27432011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2744
2745 * nsfns.m (get_geometry_from_preferences): New function.
2746 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2747
6c07aac2
AS
27482011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2749
2750 * emacs.c (Qkill_emacs): Define.
2751 (syms_of_emacs): Initialize it.
2752 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2753 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2754 (quit_throw_to_read_char): Add parameter `from_signal'.
2755 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2756 * lisp.h (QUIT): Call Fkill_emacs if requested.
2757
c052ead4
JD
27582011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2759
2760 * widget.c (update_wm_hints): Return if wmshell is null.
2761 (widget_update_wm_size_hints): New function.
2762
2763 * widget.h (widget_update_wm_size_hints): Declare.
2764
2765 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2766 widget_update_wm_size_hints (Bug#10104).
2767
9e49252b
EZ
27682011-12-03 Eli Zaretskii <eliz@gnu.org>
2769
2770 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2771 before a newline, prepare the bidi iterator for consuming the
2772 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2773 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2774
02b16839
JL
27752011-12-02 Juri Linkov <juri@jurta.org>
2776
2777 * search.c (Fword_search_regexp): New Lisp function created from
2778 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2779 (Fword_search_backward, Fword_search_forward)
2780 (Fword_search_backward_lax, Fword_search_forward_lax):
2781 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2782 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2783
0068070e
SM
27842011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2785
2786 * fileio.c (Finsert_file_contents): Move after-change-function call
2787 to before the "handled:" label, since all "goto handled" appear in
2788 cases where the *-change-functions have already been properly called
2789 (bug#10117).
2790
3360a3fc
AS
27912011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2792
2793 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2794 waiting for input. (Bug#10169)
2795
73d6c093
EZ
27962011-11-30 Eli Zaretskii <eliz@gnu.org>
2797
2798 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2799 verifies glyph row's hash code--we have just reallocated the
2800 glyphs, so their contents can be complete garbage. (Bug#10164)
2801
febe6bea
JB
28022011-11-30 Juanma Barranquero <lekktu@gmail.com>
2803
2804 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2805
801a4313
EZ
28062011-11-30 Eli Zaretskii <eliz@gnu.org>
2807
2808 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2809 attributes are tested _before_ calling verify_row_hash, to protect
2810 against GCC re-ordering of the tests. (Bug#10164)
2811
2b56b87e
JD
28122011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2813
2814 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2815
2816 * xterm.c (handle_one_xevent): Only set async_visible and friends
2817 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2818 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2819 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2820
dbf31225
PE
28212011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2824 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2825 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2826 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2827 All uses changed to use GCPRO1 etc.
2828 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2829 Revert to old implementation (i.e., before 2011-03-11).
2830
1305621b
YM
28312011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2832
2833 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2834 of scroll runs so as to avoid assigning disabled bogus rows and
2835 unnecessary graphics copy operations.
2836
8c9afb46
EZ
28372011-11-27 Eli Zaretskii <eliz@gnu.org>
2838
2839 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2840 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2841 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2842 (malloc, free, realloc, calloc): Redirect to e_* only when
2843 compiling Emacs.
2844
2845 * lisp.h (GCTYPEBITS): Move before first use.
2846 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2847 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2848 this macro definition.
2849
2850 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2851 _MSC_VER.
2852
54e9e3bf
JD
28532011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2854
6d5eb5b0
SM
2855 * gtkutil.c (xg_create_frame_widgets):
2856 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2857 present with Gtk+ 2.0.
2858
83aca1cb
PE
28592011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 * fileio.c (Finsert_file_contents): Undo previous change; see
2862 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2863
5b76caa4
PE
28642011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 Rename locals to avoid shadowing.
2867 * fileio.c (Finsert_file_contents):
2868 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2869 * process.c (wait_reading_process_output):
2870 Rename inner 'proc' to 'p' to avoid shadowing.
2871 Indent for consistency with usual Emacs style.
2872
8c535114
EZ
28732011-11-25 Eli Zaretskii <eliz@gnu.org>
2874
2875 * xdisp.c (redisplay_window): If cursor row is not fully visible
2876 after recentering, and scroll-conservatively is set to a large
2877 number, scroll window by a few more lines to make the cursor fully
2878 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2879 (start_display): Don't move to the next line if the display should
2880 start at a newline that is part of a display vector or an overlay
2881 string. (Bug#10119)
8c535114 2882
fa4fdb5c
JL
28832011-11-24 Juri Linkov <juri@jurta.org>
2884
2885 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2886 after the `MagickPingImage' call. (Bug#10112)
2887
90ec88df
CY
28882011-11-23 Chong Yidong <cyd@gnu.org>
2889
2890 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2891
56e2e794
MR
28922011-11-23 Martin Rudalics <rudalics@gmx.at>
2893
2894 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2895 making another buffer current. (Bug#10114)
2896
b6e64c41
GM
28972011-11-23 Glenn Morris <rgm@gnu.org>
2898
2899 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2900
6b21de18
CY
29012011-11-23 Chong Yidong <cyd@gnu.org>
2902
2903 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2904 using it (Bug#5984).
2905
b12cd789
EZ
29062011-11-22 Eli Zaretskii <eliz@gnu.org>
2907
2908 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2909 and header-lines, as they don't have one computed for them.
2910 (Bug#10098)
2911
2912 * .gdbinit (prow): Make displayed values more self-explaining.
2913 Add row's hash code.
2914
261b6fd4
LMI
29152011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2916
2917 * process.c (wait_reading_process_output): Fix asynchrounous
2918 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2919 (wait_reading_process_output): Add comment and URL.
261b6fd4 2920
e7cfd277
JD
29212011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2922
2923 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2924
a9b9b7f5
CY
29252011-11-21 Chong Yidong <cyd@gnu.org>
2926
2927 * window.c (Fnext_window, Fprevious_window): Doc fix.
2928
b0d15b4f
SM
29292011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2930
2931 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2932
fe7a3057
JB
29332011-11-20 Juanma Barranquero <lekktu@gmail.com>
2934
2935 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2936
d2999b1a
MR
29372011-11-20 Martin Rudalics <rudalics@gmx.at>
2938
2939 * window.c (Fset_window_combination_limit): Rename argument
2940 STATUS to LIMIT.
2941 (Vwindow_combination_limit): Remove "status" from doc-string.
2942
d5ff9cd0
AS
29432011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2944
2945 * m/ibms390.h: Remove.
2946 * m/ibms390x.h: Don't include "ibms390.h".
2947
a5bb9bd3
SM
29482011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2949
2950 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2951 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2952
cd1181db
JB
29532011-11-20 Juanma Barranquero <lekktu@gmail.com>
2954
2955 * casetab.c (Fset_case_table):
2956 * charset.c (Fcharset_after): Fix typos.
2957
615a3b8d 29582011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2959
17e845af
PE
2960 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2961 Otherwise, valgrind does not work on some platforms.
2962 Problem reported by Andreas Schwab in
6a0bf43d
PE
2963 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2964 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2965 is set, removing the need for VIRT_ADDRESS_VARIES.
2966 (PURE_P): Use a more-efficient implementation that needs just one
2967 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2968 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2969 to 4 (xorl, subq, cmpq, setbe).
2970 * alloc.c (pure): Always extern now, since that's the
2971 VIRT_ADDR_VARIES behavior.
2972 (PURE_POINTER_P): Use a single comparison, not two, for
2973 consistency with the new puresize.h.
2974 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2975 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2976 Remove VIRT_ADDR_VARIES no longer needed.
2977
f8fe6f96
EZ
29782011-11-19 Eli Zaretskii <eliz@gnu.org>
2979
2980 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2981 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2982 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2983 behave as if the cursor position were at the window margin.
2984
2985 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2986 and the cursor position is out of bounds, behave as if the cursor
2987 position were at the window margin. (Bug#10075)
2988
df05a53c
CY
29892011-11-18 Chong Yidong <cyd@gnu.org>
2990
2991 * window.c (Fwindow_combination_limit): Make first argument
2992 non-optional, since it is meaningless for live windows like the
2993 selected window.
61ccba97 2994
2071918e
DA
29952011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2996
2997 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2998
b50a28de
SM
29992011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3002 (graft_intervals_into_buffer): Simplify.
3003
015137db
EZ
30042011-11-18 Eli Zaretskii <eliz@gnu.org>
3005
3006 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3007 hash values of the two rows.
3008 (copy_row_except_pointers): Preserve the used[] arrays and the
3009 hash values of the two rows. (Bug#10035)
68c95424 3010 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3011
3012 * xdisp.c (row_hash): New function, body extracted from
3013 compute_line_metrics.
3014 (compute_line_metrics): Call row_hash, instead of computing the
3015 hash code inline.
3016
3017 * dispnew.c (verify_row_hash): Call row_hash for computing the
3018 hash code of a row, instead of duplicating code from xdisp.c.
3019
3020 * dispextern.h (row_hash): Add prototype.
3021
a2addb04
TH
30222011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3023
3024 * frame.c (delete_frame): Don't delete the terminal when the last
3025 X frame is closed if emacs is built with GTK toolkit.
3026
df85d315
JB
30272011-11-17 Juanma Barranquero <lekktu@gmail.com>
3028
3029 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3030
a0c2d0ae
MR
30312011-11-17 Martin Rudalics <rudalics@gmx.at>
3032
3033 * window.c (Vwindow_splits): Rename to
3034 Vwindow_combination_resize. Suggested by Juri Linkov.
3035 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3036 of Vwindow_splits.
3037
58179cce
JB
30382011-11-16 Juanma Barranquero <lekktu@gmail.com>
3039
7877f373
JB
3040 * nsfns.m (Fns_font_name):
3041 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3042
b6f67890
MR
30432011-11-16 Martin Rudalics <rudalics@gmx.at>
3044
3045 * window.h (window): Rename slot "nest" to "combination_limit".
3046 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3047 (Fset_window_nest): Rename to Fset_window_combination_limit.
3048 (Vwindow_nest): Rename to Vwindow_combination_limit.
3049 (recombine_windows, make_parent_window, make_window)
3050 (Fsplit_window_internal, saved_window)
3051 (Fset_window_configuration, save_window_save): Rename all
3052 occurrences of window_nest to window_combination_limit.
3053
c7015153
JB
30542011-11-15 Juanma Barranquero <lekktu@gmail.com>
3055
3056 * image.c (imagemagick_load_image): Fix typo.
3057
322ad6ec
EZ
30582011-11-14 Eli Zaretskii <eliz@gnu.org>
3059
3060 * xdisp.c (display_line): Move the call to
3061 highlight_trailing_whitespace before the call to
3062 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3063 faces of all the glyphs to compute ROW's hash value.
3064 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3065
f067b8ec
JB
30662011-11-14 Juanma Barranquero <lekktu@gmail.com>
3067
3068 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3069 just return (bug#10044).
3070
1e5b2111
EZ
30712011-11-12 Eli Zaretskii <eliz@gnu.org>
3072
7ef3cbd5
EZ
3073 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3074 with user-defined heap size. Bump the default size of the temacs
3075 heap to 27MB, to avoid memory warning when running temacs.
3076 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3077
1e5b2111
EZ
3078 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3079 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3080 (verify_row_hash) [XASSERTS]: New function.
3081 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3082 that the hash value of glyph rows is correct.
1e5b2111 3083
89d61221
MR
30842011-11-12 Martin Rudalics <rudalics@gmx.at>
3085
3086 * window.h (window): Remove splits slot.
3087 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3088 (Fdelete_other_windows_internal, make_parent_window)
3089 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3090 (Fset_window_configuration, save_window_save): Don't deal with
3091 split status of windows.
3092 (saved_window): Remove splits slot.
3093 (Vwindow_splits): Rewrite doc-string.
3094
97f18cc8
JD
30952011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3096
3097 * xfns.c (unwind_create_frame):
3098 * nsfns.m (unwind_create_frame):
3099 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3100 Vframe_list (Bug#9999).
3101
22a648b4
DA
31022011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3103
0b381c7e 3104 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3105
659afede
KH
31062011-11-11 Kenichi Handa <handa@m17n.org>
3107
3108 * callproc.c (Fcall_process): Set the member dst_multibyte of
3109 process_coding.
3110
9ac0394b
KH
31112011-11-11 Johan Bockgård <bojohan@gnu.org>
3112
3113 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3114 avoid a crash (bug#9496).
3115
2fbdc249
CY
31162011-11-09 Chong Yidong <cyd@gnu.org>
3117
3118 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3119 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3120
ac6b1f81
PE
31212011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3122
3123 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3124
09db192c
PE
31252011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 Avoid some portability problems by eschewing 'extern inline' functions.
3128 The trivial performance wins aren't worth the portability hassles; see
3129 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3130 et seq.
3131 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3132 (window_box_width, window_box_left, window_box_left_offset)
3133 (window_box_right, window_box_right_offset): Undo previous change,
3134 by removing the "extern"s.
3135 * intervals.c (adjust_intervals_for_insertion)
3136 (adjust_intervals_for_deletion): Undo previous change,
3137 making these static again.
3138 (offset_intervals, temp_set_point_both, temp_set_point)
3139 (copy_intervals_to_string): No longer inline.
3140 * xdisp.c (window_text_bottom_y, window_box_width)
3141 (window_box_height, window_box_left_offset)
3142 (window_box_right_offset, window_box_left, window_box_right)
3143 (window_box): No longer inline.
3144
105216ed
CY
31452011-11-08 Chong Yidong <cyd@gnu.org>
3146
3147 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3148 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3149 Signal an error if not a live window.
105216ed
CY
3150 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3151 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3152
ae9e237f
JB
31532011-11-07 Juanma Barranquero <lekktu@gmail.com>
3154
3155 * lisp.h (syms_of_abbrev): Remove declaration.
3156 Reported by CHENG Gao <chenggao@royau.me>.
3157
c7aa8333
EZ
31582011-11-07 Eli Zaretskii <eliz@gnu.org>
3159
3160 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3161 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3162 of temacs in GUI mode.
3163
be7f5545
MR
31642011-11-07 Martin Rudalics <rudalics@gmx.at>
3165
3166 * window.h: Declare delete_all_child_windows instead of
3167 delete_all_subwindows.
3168 * window.c (Fwindow_nest, Fset_window_nest)
3169 (Fset_window_new_total, Fset_window_new_normal)
3170 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3171 (delete_all_subwindows): Rename to delete_all_child_windows.
3172 (Fdelete_other_windows_internal, Fset_window_configuration):
3173 Call delete_all_child_windows instead of delete_all_subwindows.
3174 * frame.c (delete_frame): Call delete_all_child_windows instead
3175 of delete_all_subwindows.
3176
ca78dc43
PE
31772011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3178
3179 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3180 This is also needed for porting to any host where GC_MARK_STACK is
3181 not GC_MAKE_GCPROS_NOOPS.
3182 (which_symbols): Use it.
3183
a0241d01
KH
31842011-11-07 Kenichi Handa <handa@m17n.org>
3185
3186 * coding.c (coding_set_destination): Check coding->src_pos only
3187 when coding->src_object is a buffer (bug#9910).
3188
3189 * process.c (send_process): Set the member src_multibyte of coding
3190 to 0 (bug#9911) when sending a unibyte text.
3191
3192 * callproc.c (Fcall_process): Set the member src_multibyte of
3193 process_coding to 0 (bug#9912).
3194
a64bfdfa 31952011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3196
3197 * xmenu.c (cleanup_widget_value_tree): New function.
3198 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3199 calling free_menubar_widget_value_tree directly (Bug#9830).
3200
cb41b32a
PE
32012011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3202
3203 Fix some portability problems with 'inline'.
3204 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3205 (window_box_width, window_box_left, window_box_left_offset)
3206 (window_box_right, window_box_right_offset): Declare extern.
3207 Otherwise, these inline functions do not conform to C99 and
3208 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3209 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3210 * intervals.c (adjust_intervals_for_insertion)
3211 (adjust_intervals_for_deletion): Now extern, because otherwise the
3212 extern inline functions 'offset_intervals' couldn't refer to it.
3213 (static_offset_intervals): Remove.
3214 (offset_intervals): Rewrite using the old contents of
3215 static_offset_intervals. The old version didn't conform to C99
3216 because an extern inline function contained a reference to an
3217 identifier with static linkage.
3218
b7041366
AS
32192011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3220
3221 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3222 GC.
3223
88a37c4d
EZ
32242011-11-06 Eli Zaretskii <eliz@gnu.org>
3225
3226 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3227 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3228 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3229 return Qleft_to_right.
3230
49745b39
CY
32312011-11-06 Chong Yidong <cyd@gnu.org>
3232
3233 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3234 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3235 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3236 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3237 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3238 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3239 (Fwindow_vscroll): Doc fix.
3240 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3241 argument, since it makes no sense to pass a live window and for
3242 consistency with window-child.
3243
1f05cd82
CS
32442011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3245
3246 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3247 support MSVC.
3248
22610910
JR
32492011-11-05 Jason Rumney <jasonr@gnu.org>
3250
3251 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3252 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3253 fonts (Bug#6029).
3254 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3255 bitwise arithmetic preventing use of unicode-sip and non-truetype
3256 opentype fonts.
3257
a06776b2
EZ
32582011-11-05 Eli Zaretskii <eliz@gnu.org>
3259
3ad924ba
EZ
3260 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3261 "emacs"-only part.
3262
a06776b2
EZ
3263 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3264 initialization code to keep similarity to xfns.c after changes
3265 from 2011-11-05.
3266
c9e7db78
JD
32672011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3268
a97f8f3f
JD
3269 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3270 (unwind_create_frame): New function (Bug#9943).
3271 (Fx_create_frame): Restructure code to be more similar to the one in
3272 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3273 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3274 Move terminal->reference_count++ just before making the frame official
3275 (Bug#9943).
3276
3277 * nsterm.m (x_free_frame_resources): New function.
3278 (x_destroy_window): Move code to x_free_frame_resources.
3279
c9e7db78 3280 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3281 (Fx_create_frame, x_create_tip_frame):
3282 Move terminal->reference_count++ just before making the frame
75f1671a 3283 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3284 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3285
a6fc3b5c
EZ
32862011-11-05 Eli Zaretskii <eliz@gnu.org>
3287
3288 Support MSVC build with newer versions of Visual Studio.
3289 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3290 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3291 nt/gmake.defs.
3292
3293 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3294 which are not supported by MSVC.
3295 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3296 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3297 bitfields.
3298 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3299 types in bitfields.
3300 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3301
3302 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3303
58179cce 33042011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3305
3306 Support MSVC build with newer versions of Visual Studio.
3307 * w32.c: Don't include w32api.h for MSVC.
3308 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3309
3310 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3311 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3312 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3313 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3314 e_* cousins.
3315 (alloca) [_MSC_VER]: Define to _alloca.
3316
3317 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3318
3319 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3320
a58c13ed
EZ
33212011-11-04 Eli Zaretskii <eliz@gnu.org>
3322
3323 * xdisp.c (note_mouse_highlight): If either of
3324 previous/next-single-property-change returns nil, treat that as
3325 the beginning or the end of the buffer. (Bug#9955)
3326
fe0b6370
JD
33272011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3328
a58c13ed 3329 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3330 label is not null (Bug#9951).
3331 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3332 may be NULL.
3333
89bd5ee1
EZ
33342011-11-04 Eli Zaretskii <eliz@gnu.org>
3335
3336 * window.c (Fwindow_body_size): Mention in the doc string that the
3337 return value is in frame's canonical units. (Bug#9949)
3338
84c3edb9
EZ
33392011-11-03 Eli Zaretskii <eliz@gnu.org>
3340
4e2fb5c7
EZ
3341 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3342
84c3edb9 3343 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3344 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3345 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3346
bc17a887
EZ
33472011-11-01 Eli Zaretskii <eliz@gnu.org>
3348
3349 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3350 Don't stop backward scan on the continuation glyph, even though
3351 its CHARPOS is positive.
6d5eb5b0
SM
3352 (mouse_face_from_buffer_pos, note_mouse_highlight):
3353 Rename cover_string to disp_string.
bc17a887 3354
4ee88440
MR
33552011-11-01 Martin Rudalics <rudalics@gmx.at>
3356
3357 * window.c (temp_output_buffer_show): Don't use
3358 Vtemp_buffer_show_specifiers.
3359 (Vtemp_buffer_show_specifiers): Remove unused variable.
3360
c2ff3c02
EZ
33612011-10-30 Eli Zaretskii <eliz@gnu.org>
3362
3363 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3364 past the beginning of the current glyph matrix.
3365
58179cce 33662011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3367
3368 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3369 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3370 HAVE_GTK3 (Bug#9869).
b77a6a7f 3371
3b574623
JD
3372 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3373 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3374
b77a6a7f
JD
3375 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3376
3377 * xterm.c: Declare x_handle_net_wm_state to return int.
3378 (handle_one_xevent): Check if we are iconified but don't have
3379 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3380 (get_current_wm_state): Return non-zero if not hidden,
3381 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3382 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3383 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3384 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3385
196e41e4
PE
33862011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3387
3388 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3389 so that this new function doesn't get optimized away by a
3390 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3391
021f2e1a
AS
33922011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3393
3394 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3395
8b058d44
EZ
33962011-10-29 Eli Zaretskii <eliz@gnu.org>
3397
3398 Fix the `xbytecode' command.
3399 * .gdbinit (xprintbytestr): New command.
b50a28de 3400 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3401 (xbytecode): Print the byte-code string as well.
3402
4452fb80
EZ
34032011-10-29 Kim Storm <storm@cua.dk>
3404
8b058d44
EZ
3405 * alloc.c (which_symbols): New function.
3406
21b72067
AS
34072011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3408
3409 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3410 line. (Bug#9903)
3411
83ed7b5c
GM
34122011-10-29 Glenn Morris <rgm@gnu.org>
3413
3414 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3415 Not clear what it was for, and it causes various bugs. (Bug#9839)
3416
5a7a728b
EZ
34172011-10-28 Eli Zaretskii <eliz@gnu.org>
3418
3419 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3420 possible random value that matches one of those tested as
3421 condition to clear the mouse face.
3422
d3d0842f
CY
34232011-10-28 Chong Yidong <cyd@gnu.org>
3424
3425 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3426
31b39d13
DN
34272011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3428
3429 * window.c (make_window): Initialize phys_cursor_on_p.
3430
9aba6043
SM
34312011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3432
3433 * lisp.h (struct Lisp_Symbol): Update comments.
3434
c20992f4
JB
34352011-10-28 Juanma Barranquero <lekktu@gmail.com>
3436
3437 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3438
db4f02f2
EZ
34392011-10-28 Eli Zaretskii <eliz@gnu.org>
3440
3441 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3442 <oslsachem@gmail.com> for helping to debug this.
3443
3444 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3445 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3446 (g_b_init_get_glyph_outline_w): New static variables.
3447 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3448 (GetGlyphOutlineW_Proc): New typedefs.
3449 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3450 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3451 New functions.
3452 (w32font_open_internal, compute_metrics):
3453 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3454 instead of calling the "wide" APIs directly.
3455
3456 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3457
3458 * w32.h (syms_of_w32font): Add prototype.
3459
87e68db4
JB
34602011-10-27 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3463 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3464 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3465 (Fmove_to_window_line): Doc fix.
3466
435c1d67
CY
34672011-10-27 Chong Yidong <cyd@gnu.org>
3468
3469 * process.c (make_process): Set gnutls_state to NULL.
3470
3471 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3472 non-NULL, regardless of GNUTLS_INITSTAGE.
3473 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3474 an error. Set process slots as soon as we allocate them.
3475
3476 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3477
9c6c6f49
CY
34782011-10-27 Chong Yidong <cyd@gnu.org>
3479
9aba6043
SM
3480 * gnutls.c (emacs_gnutls_deinit): New function.
3481 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3482 (Fgnutls_deinit, Fgnutls_boot): Use it.
3483
3484 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3485 (deactivate_process): Call emacs_gnutls_deinit.
3486
657d08d3
JB
34872011-10-27 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * image.c (x_create_x_image_and_pixmap):
3490 * w32.c (sys_rename, w32_delayed_load):
3491 * w32font.c (fill_in_logfont):
3492 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3493
5430d399
JB
34942011-10-26 Juanma Barranquero <lekktu@gmail.com>
3495
3496 * w32fns.c (w32_default_color_map): New function,
3497 extracted from Fw32_default_color_map.
a7ef684b 3498 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3499
fe0055fa
PE
35002011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3503
e6346438
SM
35042011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3505
3506 * keyboard.c (test_undefined): New function (bug#9751).
3507 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3508
e112cc37
ET
35092011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3510
3511 * sysdep.c (init_sys_modes): Fix the check for the controlling
3512 terminal (Bug#6649).
3513
7b5d6677
EZ
35142011-10-20 Eli Zaretskii <eliz@gnu.org>
3515
3516 * dispextern.h (struct bidi_it): New member next_en_type.
3517
3518 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3519 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3520 current character, check also for next_en_type being WEAK_EN.
3521 (bidi_resolve_weak): Don't enter the expensive loop if the current
3522 position is before next_en_pos. Record the bidi type of the first
3523 non-ET, non-BN character we find, in addition to its position.
3524 (bidi_level_of_next_char): Invalidate next_en_type when
3525 next_en_pos is over-stepped.
3526
7da0b018
PE
35272011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3528
3529 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3530 * editfns.c: Rewrite current-time-zone so that it invokes
3531 the equivalent of (format-time-string "%Z") to get the time zone name.
3532 This fixes a bug when the time zone name contains characters that
3533 need converting from the system time locale to Emacs internal format.
3534 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3535 that patch fixed format-time-string to do the conversion, but
3536 I forgot to fix current-time-zone.
3537 (format_time_string): New function, containing most of
3538 what Fformat_time_string used to contain.
3539 (Fformat_time_string): Rewrite in terms of format_time_string.
3540 This doesn't change this function's behavior.
3541 (current-time-zone): Rewrite to use format_time_string.
3542 This fixes the bug reported by Michael Schierl in
3543 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3544 Jason Rumney's 2007-06-07 change worked around this bug, but
3545 didn't fix it.
3546 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3547
8547b010
EZ
35482011-10-19 Eli Zaretskii <eliz@gnu.org>
3549
3550 * xdisp.c (start_display): If the character at POS is displayed
3551 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3552 (try_window_reusing_current_matrix): If a line ends in a display
3553 vector or the next line starts in a display vector, continue
3554 redrawing the window even though the character position of
3555 start_row was reached.
8547b010
EZ
3556 (Bug#9771, part 2)
3557
4e948d15
CY
35582011-10-18 Chong Yidong <cyd@gnu.org>
3559
3560 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3561 with nobreak-char-display too.
3562
4787455f
EZ
35632011-10-18 Eli Zaretskii <eliz@gnu.org>
3564
3565 Fix part 3 of bug#9771.
3566 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3567 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3568 non-neutral characters if the current character is a paragraph
3569 separator (a.k.a. Newline). This avoids running the same
3570 expensive loop twice, once when we consume the preceding newline
3571 and the other time when the line actually needs to be displayed.
3572 Avoid the loop when we see neutrals on the base embedding level
3573 following a character whose directionality is the same as the
3574 paragraph's. This avoids running the expensive loop when a line
3575 ends in a long sequence of neutrals, like control characters.
3576 Add assertion against STRONG_AL type. Slightly rearrange code
3577 that determines the type of a neutral given the first non-neutral
3578 that follows it.
3579 (bidi_level_of_next_char): Set next_en_pos to zero when
3580 invalidating its info.
3581
2c91f553
EZ
35822011-10-17 Eli Zaretskii <eliz@gnu.org>
3583
3584 * xdisp.c (push_display_prop): Determine whether to record string
3585 or buffer position by IT->string, not by IT->method. Allow
3586 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3587 (move_it_vertically_backward): Don't look for character position
3588 immediately after the newline when in a continuation line.
3589 (Bug#9771, part 1)
2c91f553 3590
c7b08b0d
MR
35912011-10-15 Martin Rudalics <rudalics@gmx.at>
3592
3593 * window.c (coordinates_in_window): Rewrite and delabelize
3594 vertical border check. (Bug#5357) (Bug#9618)
3595
6b02f655
SM
35962011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3597
3598 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3599 errors in XSetWindowBorder (bug#9310).
3600
81d40c92
DA
36012011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3602
3603 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3604 avoid crash when xmalloc overrun checking is enabled.
3605
d4172c3b
EZ
36062011-10-13 Eli Zaretskii <eliz@gnu.org>
3607
3608 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3609 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3610 cursor motion with <left> and <right> arrow keys.
3611
3612 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3613 some callers set that themselves.
3614
b00eea75
EZ
36152011-10-12 Eli Zaretskii <eliz@gnu.org>
3616
3617 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3618 display string and the previous row comes from the same string and
3619 is empty. (Bug#9739) (Bug#9738)
3620
8fe012c4
SM
36212011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3622
3623 * doc.c (get_doc_string): Encode file name (bug#9735).
3624
0074aef2
EZ
36252011-10-12 Eli Zaretskii <eliz@gnu.org>
3626
79beb178
EZ
3627 * bidi.c (bidi_level_of_next_char):
3628 * xdisp.c (get_visually_first_element): Remove old incorrect
3629 comments regarding the Unicode Line Separator character.
3630
0074aef2
EZ
3631 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3632
6e4b3fbe
DA
36332011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3634
3635 * alloc.c (Fgc_status): Do not access beyond zombies array
3636 boundary if nzombies > MAX_ZOMBIES.
3637 * alloc.c (dump_zombies): Add missing format specifier.
3638
0324f3af
PE
36392011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3640
b5525cac
PE
3641 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3642 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3643
0324f3af
PE
3644 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3645 Some packages use them to denote characters with modifiers.
3646
e9b5f888
AS
36472011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3648
3649 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3650 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3651 matching a pp-number. Rename parameter var to var1.
3652
127827c0
SM
36532011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3654
3655 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3656
c8fd3bd0
GM
36572011-10-08 Glenn Morris <rgm@gnu.org>
3658
3659 * callint.c (Fcall_interactively): Give a more explicit error for the
3660 'c' case with a non-character input. (Bug#8479)
3661
352ec8ff
EZ
36622011-10-08 Eli Zaretskii <eliz@gnu.org>
3663
03669ccb
EZ
3664 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3665 lines.
7061c986
EZ
3666 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3667 lines that are hscrolled on the left.
03669ccb 3668
352ec8ff
EZ
3669 * dispnew.c (buffer_posn_from_coords): Account for a possible
3670 presence of header-line. (Bug#4426)
3671
a66cfb1c
SM
36722011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3673
6b02f655
SM
3674 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3675 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3676
7c5ee88e
PE
36772011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3678
3679 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3680 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3681 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3682 this makes Emacs dump core during garbage collection on rare
3683 occasions. sizeof is obviously inferior to offsetof here, so
3684 stick with offsetof.
3685 (GC_POINTER_ALIGNMENT): New macro.
3686 (mark_memory): Omit 3rd (offset) arg; caller changed.
3687 Don't assume EMACS_INT alignment is the same as pointer alignment.
3688
df1bbe5b
SM
36892011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3690
3691 * keyboard.c (read_key_sequence_remapped): New var.
3692 (read_key_sequence): Compute remapping in the right buffer.
3693 (command_loop_1): Use read_key_sequence's remapping directly.
3694
51553db6
SM
36952011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3696
32c1fffd
SM
3697 * dired.c (file_name_completion): Don't expand file name.
3698 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3699 before checking file name handler.
3700
51553db6
SM
3701 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3702 they've been requested explicitly (bug#9591).
3703
b6bd1599 37042011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3705
3706 * keymap.c (Fsingle_key_description): Use make_specified_string
3707 instead of build_string to build string from push_key_description.
3708 (Bug#5193)
3709
f701dc2a
PE
37102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3711
4222c55d
PE
3712 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3713 This fixes a Y2038 bug on 64-bit hosts.
3714 * buffer.c (reset_buffer):
3715 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3716 (Fclear_buffer_auto_save_failure):
3717 Use 0, not -1, to represent an unset failure time, since time_t
3718 might not be signed.
3719
f701dc2a
PE
3720 Remove dependency on glibc malloc internals.
3721 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3722 Move back here from lisp.h, but with their new implementations.
3723 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3724 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3725 * charset.c (charset_table_init): New static var.
3726 (syms_of_charset): Use it instead of xmalloc. This removes a
3727 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3728 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3729 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3730 Move back to alloc.c.
3731 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3732 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3733
9ceebf39
JD
37342011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3735
3736 * nsterm.m (windowDidResize): Call x_set_window_size only when
3737 ns_in_resize is true. Otherwise set pixelwidth/height and
3738 call change_frame_size (Bug#9628).
3739
cb993c58
PE
37402011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3741
3930c88b
PE
3742 Port --enable-checking=all to Fedora 14 x86-64.
3743 * charset.c (syms_of_charset): Also account for glibc malloc's
3744 internal overhead when calculating the initial malloc maximum.
3745
cb993c58
PE
3746 Port --enable-checking=all to Fedora 14 x86.
3747 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3748 Move to lisp.h.
3749 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3750 (overrun_check_realloc, overrun_check_free):
3751 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3752 That way, xmalloc returns a properly-aligned pointer even if
3753 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3754 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3755 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3756 into account when calculating the initial malloc maximum.
3757 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3758 Move here from alloc.c, so that charset.c can use it too.
3759 Properly align; the old code wasn't right for common 32-bit hosts
3760 when configured with --enable-checking=all.
3761 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3762 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3763
31bed486
EZ
37642011-09-29 Eli Zaretskii <eliz@gnu.org>
3765
04c70788 3766 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3767 use EDOM.
3768
fbcaa2f3
EZ
37692011-09-28 Eli Zaretskii <eliz@gnu.org>
3770
3771 * xdisp.c (compute_display_string_end): If there's no display
3772 string at CHARPOS, return -1.
3773
3774 * bidi.c (bidi_fetch_char): When compute_display_string_end
3775 returns a negative value, treat the character as a normal
3776 character not covered by a display string. (Bug#9624)
3777
a239d4e9
JB
37782011-09-28 Juanma Barranquero <lekktu@gmail.com>
3779
3780 * lread.c (Fread_from_string): Fix typo in docstring.
3781
88652fd5
EZ
37822011-09-27 Eli Zaretskii <eliz@gnu.org>
3783
3784 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3785 newline, reseat the iterator instead of bidi-iterating there one
3786 character at a time. (Bug#9610)
32c1fffd
SM
3787 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3788 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3789
ed497dd4
AS
37902011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3791
3792 * lread.c (readevalloop): Use correct code for NBSP.
3793 (read1): Likewise. (Bug#9608)
3794
b2bf61aa
MA
37952011-09-25 Michael Albinus <michael.albinus@gmx.de>
3796
3797 * dbusbind.c (Fdbus_register_signal): When service is not
3798 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3799
32bbb17c
GM
38002011-09-25 Glenn Morris <rgm@gnu.org>
3801
3802 * buffer.c (truncate-lines): Doc fix.
3803
94e0933e
CY
38042011-09-24 Chong Yidong <cyd@stupidchicken.com>
3805
3806 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3807 (Fset_window_next_buffers): Doc fix.
3808
cddde921
GM
38092011-09-24 Glenn Morris <rgm@gnu.org>
3810
3811 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3812
1260aef1
PE
38132011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3814
25b4bfa0
PE
3815 Fix minor problems found by static checking.
3816 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3817 * indent.c (Fvertical_motion): Fix == vs = typo.
3818
e3cbd34b
EZ
38192011-09-24 Eli Zaretskii <eliz@gnu.org>
3820
a66cfb1c
SM
3821 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3822 Default value is now t. Doc fix.
6bf7006f 3823
e3cbd34b 3824 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3825 logic when moving up, not only when moving down. Fix the
e3cbd34b 3826 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3827 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3828
3829 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3830 CHARPOS is covered by a display string which includes newlines.
3831 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3832 is covered by a display string with embedded newlines.
3833
a3de0cbd
MA
38342011-09-24 Michael Albinus <michael.albinus@gmx.de>
3835
3836 * dbusbind.c (Fdbus_register_signal): Add match rule to
3837 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3838 (Fdbus_register_method, Vdbus_registered_objects_table):
3839 Fix docstring.
a3de0cbd 3840
b260039d
JM
38412011-09-24 Jim Meyering <meyering@redhat.com>
3842
32c1fffd 3843 do not ignore write error for any output size
b260039d
JM
3844 The previous change was incomplete.
3845 While it makes emacs --batch detect the vast majority of stdout
3846 write failures, errors were still ignored whenever the output size is
3847 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3848 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3849 && echo FAIL: ignored write error
3850 FAIL: ignored write error
3851 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3852 && echo FAIL: ignored write error
3853 FAIL: ignored write error
3854 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3855
8eca8a7c
AS
38562011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3857
3858 * emacs.c (Fkill_emacs): In noninteractive mode exit
3859 non-successfully if a write error occurred on stdout. (Bug#9574)
3860
3341db62
EZ
38612011-09-21 Eli Zaretskii <eliz@gnu.org>
3862
3863 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3864 the xassert test.
3865
3866 * dispextern.h (struct it): Update the comment documenting what
3867 can it->OBJECT be.
3868
8c203dbf
EZ
38692011-09-20 Eli Zaretskii <eliz@gnu.org>
3870
3871 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3872 a display string, extend search for cursor position to end of row.
3873 (find_row_edges): If the row ends in a newline from a display
3874 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3875 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3876 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3877 non-empty line. Fixes confusing cursor motion with arrow keys at
3878 the beginning of a line that starts with whitespace.
8c203dbf 3879
a4824228
LMI
38802011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3881
3882 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3883 (bug#9493).
3884
33ed493b
CY
38852011-09-18 Chong Yidong <cyd@stupidchicken.com>
3886
3887 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3888 boolean (Bug#9154).
3889
56cd55c8
EZ
38902011-09-18 Eli Zaretskii <eliz@gnu.org>
3891
3892 * xdisp.c (display_line): Record maximum and minimum buffer
3893 positions even if no glyphs were produced (e.g., by a zero-width
3894 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3895 buffer positions that will be removed from the glyph row because
3896 they don't fit.
c02dcedf
EZ
3897 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3898 column is beyond frame width: don't subtract 1 "pixel" when
3899 computing width of the stretch.
3e62b7e0
EZ
3900 (reseat_at_next_visible_line_start): Undo the change made on
3901 2011-09-17 that saved paragraph information and restored it after
3902 the call to `reseat'. (Bug#9545)
56cd55c8 3903
5ed99d36 39042011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3905
3906 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3907 and turn window cursor on if cleared (Bug#9415).
3908
5ed99d36 39092011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3910
3911 * search.c (boyer_moore): Take unibyte characters from pattern
3912 literally. (Bug#9458)
3913
9bade7b2
EZ
39142011-09-18 Eli Zaretskii <eliz@gnu.org>
3915
3916 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3917
e5e9d610
PE
39182011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3919
87e4427a
PE
3920 Fix minor problem found by static checking.
3921 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3922 initialized, to pacify gcc -Wuninitialized.
3923
e5e9d610
PE
3924 * fileio.c: Report proper errno when syscall falls.
3925 (Finsert_file_contents): Save and restore errno,
3926 so that report_file_error outputs the correct diagnostic.
3927 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3928
a1674f0b
EZ
39292011-09-18 Eli Zaretskii <eliz@gnu.org>
3930
3931 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3932
fbfb6dd4
EZ
39332011-09-17 Eli Zaretskii <eliz@gnu.org>
3934
3935 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3936 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3937
bb187662
EZ
39382011-09-17 Eli Zaretskii <eliz@gnu.org>
3939
1137e8b8 3940 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3941 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3942
3943 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3944 (bidi_find_paragraph_start): Search back for paragraph beginning
3945 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3946 (bidi_move_to_visually_next): Only trigger paragraph-related
3947 computations when the last character is a newline or at EOB, not
3948 just any NEUTRAL_B. (Bug#9470)
3949
bb187662
EZ
3950 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3951 truncated lines if point is covered by a display string. (Bug#9524)
3952
2e621251
PE
39532011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3956 (cons_to_x_long): New function.
3957 (lisp_data_to_selection_data): Use it. Correct the test for
3958 short-versus-long data; it was negated. Break out of vector
3959 loop, for efficiency, when a long datum is discovered.
3960
91a15bc6
SM
39612011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3962
3963 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3964
b41c3a35
EZ
39652011-09-16 Eli Zaretskii <eliz@gnu.org>
3966
3967 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3968 GCC PR/17406) by declaring this function with external scope.
3969
7812ba2d
PE
39702011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3971
3972 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3973 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3974
cf7edc2a
AS
39752011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3976
3977 * editfns.c (Fformat): Correctly handle text properties on "%%".
3978
bd01620e
EZ
39792011-09-15 Eli Zaretskii <eliz@gnu.org>
3980
3981 * xterm.c (x_draw_composite_glyph_string_foreground):
3982 * w32term.c (x_draw_composite_glyph_string_foreground):
3983 * term.c (encode_terminal_code):
3984 * composite.c (composition_update_it, get_composition_id):
3985 * xdisp.c (get_next_display_element)
3986 (fill_composite_glyph_string): Add comments about special meaning
3987 of TAB characters in a composition.
3988
a02719a3
PE
39892011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3990
3991 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3992 This occurs when processing a multibyte format.
3993 Problem reported by Wolfgang Jenker.
a02719a3 3994
72589a3c
JB
39952011-09-15 Johan Bockgård <bojohan@gnu.org>
3996
3997 * xdisp.c (try_cursor_movement): Only check for exact match if
3998 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3999
1c14176c
PE
40002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4001
4002 Remove unused external symbols.
4003 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4004 * xdisp.c (calc_pixel_width_or_height): Now static.
4005 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4006 * indent.c (check_display_width):
4007 * w32term.c: Fix comment to match code.
4008 * xterm.c, xterm.h (x_catching_errors): Remove.
4009
d2eea5b5
PE
40102011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4011
4012 * xselect.c: Use signed conversions more consistently (Bug#9498).
4013 (selection_data_to_lisp_data): Assume incoming selection data are
4014 signed integers, not unsigned. This is to be consistent with
4015 outgoing selection data, which was modified to use signed integers
4016 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4017 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4018 expects long, not unsigned long.
4019
46888499
EZ
40202011-09-14 Eli Zaretskii <eliz@gnu.org>
4021
4022 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4023 computation of loop end. Reported by Johan Bockgård
4024 <bojohan@gnu.org>.
4025
ef8ef9fb
CY
40262011-09-13 Chong Yidong <cyd@stupidchicken.com>
4027
4028 * frame.c (Fother_visible_frames_p): Function deleted.
4029
fa819fed
EZ
40302011-09-12 Eli Zaretskii <eliz@gnu.org>
4031
4032 * indent.c (compute_motion): Process display vector front to back
4033 rather than the other way around. (Bug#2496)
4034
2ba8e008
SM
40352011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4036
4037 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4038
20f53c69
CY
40392011-09-11 Chong Yidong <cyd@stupidchicken.com>
4040
4041 * minibuf.c (Fread_from_minibuffer): Doc fix.
4042
d562d7a4
EZ
40432011-09-11 Eli Zaretskii <eliz@gnu.org>
4044
4045 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4046 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4047
1c4d7f3d
LMI
40482011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4049
4050 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4051 value for non-existent files.
4052
b885bf36
EZ
40532011-09-11 Eli Zaretskii <eliz@gnu.org>
4054
4055 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4056 set its "size" to -1. This will set the modtime_size field of
4057 the corresponding buffer to -1, which is what
4058 verify-visited-file-modtime expects for files that do not exist.
4059 (Bug#9139)
4060
6612f0bf
PE
40612011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4064 here ...
4065 * lisp.h: ... from here. push_key_description is no longer
4066 defined in keyboard.c, so its declaration should not be in
4067 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4068 logically belongs with push_key_description.
4069
dfb3f755
PE
40702011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4071
4072 * buffer.h: Include <sys/types.h> instead of <time.h>.
4073 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4074 Problem reported by Herbert J. Skuhra.
4075
3134906c
LMI
40762011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4077
4078 * xml.c (parse_region): Make the parsing work for
4079 non-comment-starting XML files again (bug#9144).
4080
8d903f4e
AS
40812011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4082
4083 * image.c (gif_load): Fix calculation of bottom and right corner.
4084 (Bug#9468)
4085
80ad64f4
EZ
40862011-09-10 Eli Zaretskii <eliz@gnu.org>
4087
4088 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4089 redisplay in small windows.
4090
208a048d
EZ
40912011-09-09 Eli Zaretskii <eliz@gnu.org>
4092
4093 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4094
9b1c252e
MR
40952011-09-08 Martin Rudalics <rudalics@gmx.at>
4096
4097 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4098 Operate on live windows only.
4099
2949f33b
JB
41002011-09-08 Juanma Barranquero <lekktu@gmail.com>
4101
4102 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4103
e08dcafd
EZ
41042011-09-07 Eli Zaretskii <eliz@gnu.org>
4105
4106 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4107 only under bidi iteration.
4108
115b96bd
JD
41092011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4110
4111 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4112
c8199d0f
PE
41132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4114
4115 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4116 Without this fix, the command to link temacs failed due to an
4117 undefined symbol __builtin_isnan. This is because
4118 /usr/include/iso/math_c99.h #defines isnan(x) to
4119 __builtin_isnan(x), but the bundled gcc, which identifies itself
4120 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4121 a __builtin_isnan.
4122 * floatfns.c (isnan): #undef, and then #define to a clone of
4123 what's in data.c.
4124 (Fisnan): Always define, since it's always available now.
4125 (syms_of_floatfns): Always define isnan at the Lisp level.
4126
e39b275c 41272011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4128
4129 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4130
b2db44d9 41312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4132
f4af5137 4133 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4134 The previous code assumed that file offsets (off_t values) fit in
4135 EMACS_INT variables, which is not true on typical 32-bit hosts.
4136 The code messed up by falsely reporting buffer overflow in cases
4137 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4138 when "big" contains more than 2**29 bytes, even though this
4139 inserts just one byte and does not overflow the buffer.
4140 (Finsert_file_contents): Store file offsets as off_t
4141 values, not as EMACS_INT values. Check for overflow when
4142 converting between EMACS_INT and off_t. When checking for
4143 buffer overflow or for overlap, take the offsets into account.
4144 Don't use EMACS_INT for small values where int suffices.
4145 When checking for overlap, fix a typo: ZV was used where
4146 ZV_BYTE was intended.
4147 (Fwrite_region): Don't assume off_t fits into 'long'.
4148 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4149
ecfc0a49
MA
41502011-09-05 Michael Albinus <michael.albinus@gmx.de>
4151
4152 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4153
6511acf2 41542011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4155
0999621a 4156 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4157
4158 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4159 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4160 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4161 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4162 (modify_event_symbol): Do not assume that the length of
4163 name_alist_or_stem is safe to alloca and fits in int.
4164 (Fexecute_extended_command): Likewise for function name and binding.
4165 (Frecursion_depth): Wrap around reliably on integer overflow.
4166 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4167 since some callers pass EMACS_INT values.
4168 (Fsingle_key_description): Don't crash if symbol name contains more
4169 than MAX_ALLOCA bytes.
4170 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4171 (get_minibuffer): Arg is now EMACS_INT, not int.
4172 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4173 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4174 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4175
2be7d702
PE
4176 * dbusbind.c (signature_cat): New function.
4177 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4178 Do not overrun buffer; instead, report string overflow.
4179
9d1df220
PE
4180 * dispnew.c (add_window_display_history): Don't overrun buffer.
4181 Truncate instead; this is OK since it's just a log.
4182
33ef5c64
PE
4183 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4184 even if the time zone offset is outlandishly large.
4185 Don't mishandle offset == INT_MIN.
4186
66c6fdd5
PE
4187 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4188 when creating daemon; the previous buffer-overflow check was incorrect.
4189
d749b01b
PE
4190 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4191 which has the guts of the old verror function.
4192
b5cd1905
PE
4193 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4194 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4195
6e1a67fb
PE
4196 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4197 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4198 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4199 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4200 length of string rather than counting it via multiple sprintfs;
4201 that's simpler and more reliable.
c21721cc
PE
4202 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4203 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4204 sprintf, in case result does not fit in int.
4205
c57b67fc
PE
4206 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4207 (fontset_from_font): Print it.
4208
8a401434
PE
4209 * frame.c (tty_frame_count): Now printmax_t, not int.
4210 (make_terminal_frame, set_term_frame_name): Print it.
4211 (x_report_frame_params): In X, window IDs are unsigned long,
4212 not signed long, so print them as unsigned.
4213 (validate_x_resource_name): Check for implausibly long names,
4214 and don't assume name length fits in 'int'.
4215 (x_get_resource_string): Don't blindly alloca invocation name;
4216 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4217 not fit in int.
4218
6e1a67fb
PE
4219 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4220 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4221 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4222
0df02bf3
PE
4223 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4224 Use esprintf, not sprintf, in case result does not fit in int.
4225
48e30793
PE
4226 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4227 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4228 it as a large positive number.
4229 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4230 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4231
a66ff6d8
PE
4232 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4233 in case result does not fit in int.
4234
aca216ff
PE
4235 * print.c (float_to_string): Detect width overflow more reliably.
4236 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4237 buffer overrun. Don't assume list length fits in 'int'. Treat
4238 print length of 0 as 0, not as infinity; to be consistent with other
4239 uses of print length in this function. Don't overflow print length
4240 index. Don't assume hash table size fits in 'long', or that
4241 vectorlike size fits in 'unsigned long'.
4242
31c286f7
PE
4243 * process.c (make_process): Use printmax_t, not int, to format
4244 process-name gensyms.
4245
55e5faa1
PE
4246 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4247
80f2e268
PE
4248 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4249 to avoid potential buffer overrun.
4250
670741ab
PE
4251 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4252 if X resource line is longer than 512 bytes.
4253
b7163a50
PE
4254 * xfns.c (x_window): Make sprintf buffer a bit bigger
4255 to avoid potential buffer overrun.
4256
ae58ff1f
PE
4257 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4258
c43c8a6a
PE
4259 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4260
3f8236f4
PE
42612011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4262
53e9fe90 4263 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4264 Without these, Emacs silently mishandles large integers sometimes.
4265 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4266 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4267
6511acf2
PE
4268 * xdisp.c (try_window_id): Check Emacs fixnum range before
4269 converting to 'int'.
806add1d 4270
6511acf2 4271 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4272 Check that an Emacs fixnum is in range before assigning it to 'int'.
4273 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4274 values converted from Emacs fixnums.
4275 (Frecenter): Don't wrap around a line count if it is out of 'int'
4276 range; instead, treat it as an extreme value.
4277 (Fset_window_configuration, compare_window_configurations):
4278 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4279
6511acf2
PE
4280 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4281 that can exceed INT_MAX. Check that EMACS_INT value is in range
4282 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4283 (match_limit): Don't assume that a fixnum can fit in 'int'.
4284
6511acf2 4285 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4286 exceed INT_MAX.
4287
6511acf2 4288 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4289 (Fvertical_motion): Don't wrap around LINES values that don't fit
4290 in 'int'. Instead, treat them as extreme values. This is good
4291 enough for windows, which can't have more than INT_MAX lines anyway.
4292
fcb901a7
LMI
42932011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4294
0f2f6b6d
LMI
4295 * Require libxml/parser.h to avoid compilation warning.
4296
fcb901a7
LMI
4297 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4298
4299 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4300 since this reportedly can destroy thread storage.
4301
6e20a0d4
CY
43022011-08-30 Chong Yidong <cyd@stupidchicken.com>
4303
4304 * syntax.c (find_defun_start): Update all cache variables if
4305 exiting early (Bug#9401).
4306
148ae00e
EZ
43072011-08-30 Eli Zaretskii <eliz@gnu.org>
4308
f6cfbd8f
EZ
4309 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4310
148ae00e
EZ
4311 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4312 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4313 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4314
4315 * term.c (tty_append_glyph): New function.
4316 (produce_stretch_glyph): Static function and its prototype deleted.
4317
a66cfb1c
SM
4318 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4319 Add prototypes.
148ae00e 4320
c4a07a4c
PE
43212011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4324 when checking :margin (Bug#9390).
4325 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4326 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4327 so that the name doesn't mislead. All uses changed.
4328
6bc8cd65
JB
43292011-08-28 Johan Bockgård <bojohan@gnu.org>
4330
4331 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4332 set_tty_hooks.
4333
dca4927e
EZ
43342011-08-27 Eli Zaretskii <eliz@gnu.org>
4335
4336 * xdisp.c (move_it_to): Don't bail out early when reaching
4337 position beyond to_charpos, if we are scanning backwards.
4338 (move_it_vertically_backward): When DY == 0, make sure we get to
4339 the first character in the line after the newline.
4340
f2cad773
PE
43412011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4342
4343 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4344 (ccl_driver): Do not generate an out-of-range pointer.
4345 (Fccl_execute_on_string): Remove unnecessary check for
4346 integer overflow, noted by Stefan Monnier in
4347 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4348 Remove a FIXME that didn't need fixing.
4349 Simplify the newly-introduced buffer reallocation code.
4350
0cae2cdb
JB
43512011-08-27 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4354
5fc295a4 43552011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4356
70c60eb2 4357 Integer and memory overflow issues (Bug#9196).
726e0ab1 4358
d31850da
PE
4359 * doc.c (get_doc_string): Rework so that
4360 get_doc_string_buffer_size is the actual buffer size, rather than
4361 being 1 less than the actual buffer size; this makes xpalloc more
4362 convenient.
4363
a69fbedb
PE
4364 * image.c (x_allocate_bitmap_record, cache_image):
4365 * xselect.c (Fx_register_dnd_atom):
4366 Simplify previous changes by using xpalloc.
4367
fe5c5d37
PE
4368 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4369 since either will do and ptrdiff_t is convenient with xpalloc.
4370
0065d054
PE
4371 * charset.c (charset_table_size)
4372 (struct charset_sort_data.priority): Now ptrdiff_t.
4373 (charset_compare): Don't overflow if priorities differ greatly.
4374 (Fsort_charsets): Don't assume list length fits in int.
4375 Check for size-calculation overflow when allocating sort data.
4376 (syms_of_charset): Allocate an initial charset table that is
4377 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4378
4379 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4380
4381 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4382 The actual value is always <= INT_MAX, and leaving it unsigned made
4383 overflow checking harder.
4384
4385 * dispextern.h (struct glyph_matrix.rows_allocated)
4386 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4387 with xpalloc. The values are still always <= INT_MAX.
4388
4389 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4390
4391 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4392 (SAFE_NALLOCA): New macro.
4393
4394 * region-cache.c (struct boundary.pos, find_cache_boundary)
4395 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4396 (set_cache_region, invalidate_region_cache)
4397 (revalidate_region_cache, know_region_cache, region_cache_forward)
4398 (region_cache_backward, pp_cache):
4399 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4400 so that ptrdiff_t * can be passed to xpalloc.
4401 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4402 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4403 (pp_cache): Don't assume cache_len fits in int.
4404 * region-cache.h: Adjust extern decls to match.
4405
4406 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4407 EMACS_INT, since either will do, for xpalloc.
4408
4409 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4410 (xnmalloc, xnrealloc, xpalloc): New functions.
4411
726e0ab1
PE
4412 * bidi.c (bidi_shelve_header_size): New constant.
4413 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4414 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4415
51f30bc5 4416 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4417 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4418 (overlay_strings):
4419 Don't update size of array until after memory allocation succeeds,
4420 because xmalloc/xrealloc may not return.
0065d054
PE
4421 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4422 now that we have proper integer overflow checking.
4423 (record_overlay_string, overlay_strings): Catch overflows when
4424 calculating size of overlay_str_buf.
726e0ab1 4425
0065d054
PE
4426 * callproc.c (Fcall_process): Check for size overflow when
4427 calculating size of args2.
4428 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4429 Normally we prefer signed values, but sticking with ptrdiff_t would
4430 require adding more-complicated checks.
726e0ab1
PE
4431
4432 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4433 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4434 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4435 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4436
4437 * character.c (Fstring): Check for size-calculation overflow.
4438
4439 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4440 unnecessary integer overflow. Check for size overflow.
4441 (encode_coding_object): Don't update size until xmalloc succeeds.
4442
4443 * composite.c (get_composition_id): Check for overflow in glyph
4444 length calculations.
4445
4446 Integer and memory overflow fixes for display code.
4447 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4448 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4449 (scrolling_window): Check for overflow in size calculations.
4450 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4451 Don't assume glyph table len fits in int.
4452 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4453 (row_table_size): Now ptrdiff_t, not int.
4454 (scrolling_window): Avoid overflow in size calculations.
4455 Don't update size until allocation succeeds.
4456 * fns.c (concat): Check for overflow in size calculations.
4457 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4458 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4459 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4460
4461 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4462 (get_doc_string): Check for size calculation overflow.
4463 Don't update size until allocation succeeds.
4464 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4465 EMACS_INT, where ptrdiff_t will do.
4466 (Fsubstitute_command_keys): Check for string overflow.
4467
4468 * editfns.c (set_time_zone_rule): Don't assume environment length
4469 fits in int.
4470 (message_length): Now ptrdiff_t, not int.
4471 (Fmessage_box): Don't update size until allocation succeeds.
4472 Don't assume message length fits in int.
4473 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4474
0065d054
PE
4475 * emacs.c (main): Do not reallocate argv, since there is a null at
4476 the end that can be overwritten, and this way there's no need to
4477 worry about size-calculation overflow.
4478 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4479
4480 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4481 alloc succeeds.
4482 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4483
4484 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4485 (x_set_scroll_bar_width, x_figure_window_size):
4486 Check for integer overflow.
4487 (x_set_alpha): Do not assume XINT fits in int.
4488
4489 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4490 This is for the members text_lines, text_cols, total_lines, total_cols,
4491 where the system imposes an 'int' limit.
4492
4493 * fringe.c (Fdefine_fringe_bitmap):
4494 Don't update size until alloc works.
4495
4496 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4497 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4498
4499 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4500 Check for size-calculation overflow.
4501 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4502 do, as we prefer signed integers.
4503 (id_to_widget.max_size, id_to_widget.used)
4504 (xg_store_widget_in_map, xg_remove_widget_from_map)
4505 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4506 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4507 Use and return ptrdiff_t, not int.
4508 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4509 * gtkutil.h: Change prototypes to match the above.
4510
4511 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4512 are duplicate now that they've been promoted to lisp.h.
4513 (x_allocate_bitmap_record, x_alloc_image_color)
4514 (make_image_cache, cache_image, xpm_load):
4515 Don't update size until alloc is done.
4516 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4517 (x_detect_edges):
3256efce 4518 Check for size calculation overflow.
726e0ab1
PE
4519 (ct_colors_allocated_max): New constant.
4520 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4521 overflow.
3256efce 4522
726e0ab1
PE
4523 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4524 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4525 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4526 Use ptrdiff_t, not int, to count maps.
4527 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4528 calculations. Don't update size until allocation succeeds.
4529 Redo calculations to avoid overflow.
726e0ab1
PE
4530 * keyboard.h: Change prototypes to match the above.
4531
4532 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4533 to count maps.
4534 (current_minor_maps): Check for size calculation overflow.
4535 * keymap.h: Change prototypes to match the above.
4536
4537 * lread.c (read1, init_obarray): Don't update size until alloc done.
4538
4539 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4540 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4541
726e0ab1
PE
4542 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4543 Now ptrdiff_t, not int.
4544 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4545 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4546
4547 * process.c (Fnetwork_interface_list): Check for overflow
4548 in size calculation.
4549
4550 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4551
4552 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4553 overflow. Don't bother calling xmalloc when xrealloc will do.
4554
4555 * search.c (Freplace_match): Check for size calculation overflow.
4556 (Fset_match_data): Don't assume list lengths fit in 'int'.
4557
4558 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4559 for command line length. Do not attempt to address one before the
4560 beginning of an array, as that's not portable.
4561
4562 * term.c (max_frame_lines): Remove; unused.
4563 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4564 not int.
4565 (encode_terminal_code, calculate_costs): Check for size
4566 calculation overflow.
4567 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4568 table lengths and related sizes. Don't update size until alloc
4569 done. Redo calculations to avoid overflow.
4570 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4571
4572 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4573 subtracting pointers.
4574 (gobble_line): Check for overflow more carefully. Don't update size
4575 until alloc done.
4576
4577 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4578 Don't update size until alloc done.
4579 Redo size calculations to avoid overflow.
4580 Check for size calculation overflow.
0065d054 4581 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4582
4583 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4584 Use ptrdiff_t, not int, for sizes.
4585 (store_mode_line_noprop_char): Don't update size until alloc done.
4586
0065d054
PE
4587 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4588 Use ptrdiff_t, not int, for sizes.
4589 (Finternal_make_lisp_face, cache_face):
4590 Check for size calculation overflow.
4591 (cache_face): Treat size calculation overflows as if they were
4592 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4593
4594 * xfns.c (x_encode_text, x_set_name_internal)
4595 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4596 sizes, since they can exceed INT_MAX in size. Check for size
4597 calculation overflow.
4598
0065d054
PE
4599 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4600 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4601 Don't update size until alloc done.
4602
0065d054 4603 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4604 as sprintf is limited to int lengths.
1d526e2f 4605
252c5ee1
PE
4606 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4607 (X_LONG_MIN): New macros.
864d7ce7
PE
4608 Use them to make the following changes clearer.
4609 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4610 This change doesn't affect the value now, but it may help remind
4611 future maintainers not to raise the value too much later.
4612 (SELECTION_QUANTUM): Remove, replacing with ...
4613 (selection_quantum): ... new function, which avoids overflow.
4614 All uses changed.
4615 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4616 assumption that selection length fits in 'int'.
4617 (x_reply_selection_request, x_handle_selection_request)
4618 (x_get_window_property, receive_incremental_selection)
4619 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4620 (lisp_data_to_selection_data, clean_local_selection_data):
4621 Use ptrdiff_t, not int, to record length of selection.
4622 (x_reply_selection_request, x_get_window_property)
4623 (receive_incremental_selection, x_property_data_to_lisp):
4624 Redo calculations to avoid overflow.
4625 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4626 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4627 something.
4628 (x_get_window_property, receive_incremental_selection)
4629 (lisp_data_to_selection_data, x_property_data_to_lisp):
4630 Check for size-calculation overflow.
4631 (x_get_window_property, receive_incremental_selection)
4632 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4633 Don't store size until memory allocation succeeds.
4634 (x_get_window_property): Plug memory leak on memory exhaustion.
4635 Don't double-block input; malloc is safe here. Don't assume 2**34
4636 - 4 fits in unsigned long. Add an xassert to check
4637 XGetWindowProperty overflow. Be more careful about overflow
4638 calculations, and distinguish size from memory overflow better.
4639 (receive_incremental_selection): When tracing, don't assume
4640 unsigned int is less than INT_MAX.
4641 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4642 harmful) conversions of unsigned short to int.
4643 (lisp_data_to_selection_data): Don't assume that integers
4644 in the range -65535 through -1 fit in an X unsigned short.
4645 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4646 result parameters unless successful. Rely on cons_to_unsigned
4647 to report problems with elements; the old code wasn't right anyway.
4648 (x_check_property_data): Check for int overflow; we cannot use
4649 a wider type due to X limits.
4650 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4651
726e0ab1 4652 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4653
0065d054
PE
4654 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4655 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4656 (x_color_cells): Don't store size until memory allocation succeeds.
4657 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4658 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4659 (x_term_init): Don't assume length fits in int (sprintf is limited
4660 to int size).
bc18e09d 4661
ebfa62c0
PE
4662 Use ptrdiff_t for composition IDs.
4663 * character.c (lisp_string_width):
4664 * composite.c (composition_table_size, n_compositions)
4665 (get_composition_id, composition_gstring_from_id):
4666 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4667 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4668 * window.c (Frecenter):
4669 Use ptrdiff_t, not int, for composition IDs.
4670 * composite.c (get_composition_id): Check for integer overflow.
4671 * composite.h: Adjust prototypes to match the above changes.
4672
d3411f89
PE
4673 Use ptrdiff_t for hash table indexes.
4674 * category.c (hash_get_category_set):
4675 * ccl.c (ccl_driver):
4676 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4677 * coding.c (coding_system_charset_list, detect_coding_system):
4678 * coding.h (struct coding_system.id):
4679 * composite.c (get_composition_id, gstring_lookup_cache):
4680 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4681 * image.c (xpm_get_color_table_h):
4682 * lisp.h (hash_lookup, hash_put):
4683 * minibuf.c (Ftest_completion):
4684 Use ptrdiff_t for hash table indexes, not int (which is too
4685 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4686 32-bit --with-wide-int hosts).
4687
e097a6fa
PE
4688 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4689 Add a FIXME comment about memory leaks.
4690 (syms_of_charset): Don't assume xmalloc returns.
4691
5637687f
PE
4692 Don't assume that stated character widths fit in int.
4693 * character.c (Fchar_width, c_string_width, lisp_string_width):
4694 * character.h (CHAR_WIDTH):
4695 * indent.c (MULTIBYTE_BYTES_WIDTH):
4696 Use sanitize_char_width to avoid undefined and/or bad behavior
4697 with outlandish widths.
a66cfb1c 4698 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4699 now that we have two such functions. All uses changed.
4700 (sanitize_char_width): New inline function.
4701
a2271ba2
PE
4702 Don't assume that tab-width fits in int.
4703 * character.h (sanitize_width): New inline function.
4704 (SANE_TAB_WIDTH): New macro.
4705 (ASCII_CHAR_WIDTH): Use it.
4706 * indent.c (sane_tab_width): Remove. All uses replaced by
4707 SANE_TAB_WIDTH (current_buffer).
4708 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4709
18c52557
PE
4710 * fileio.c: Integer overflow issues with file modes.
4711 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4712
caeeedc1
PE
4713 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4714 Remove unreachable code.
4715 (read_hex, load_charset_map_from_file): Check for integer overflow.
4716
6df6ae42 4717 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4718 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4719 (x_send_scroll_bar_event): Likewise. Check that the size does not
4720 exceed limits imposed by XClientMessageEvent, as well as the usual
4721 ptrdiff_t and size_t limits.
4722
b13995db
PE
4723 * keyboard.c: Overflow, signedness and related fixes.
4724 (make_lispy_movement): Use same integer type in forward decl
4725 that is used in the definition.
4726 (read_key_sequence, keyremap_step):
4727 Change bufsize argument back to int, undoing my 2011-03-30 change.
4728 We prefer signed types, and int is wide enough here.
4729 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4730 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4731 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4732 length, not size_t. Use ptrdiff_t for index, not int.
4733 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4734 possibility of integer overflow.
4735
13464394
PE
4736 Overflow, signedness and related fixes for images.
4737
4738 * dispextern.h (struct it.stack[0].u.image.image_id)
4739 (struct_it.image_id, struct image.id, struct image_cache.size)
4740 (struct image_cache.used, struct image_cache.ref_count):
4741 * gtkutil.c (update_frame_tool_bar):
4742 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4743 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4744 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4745 * nsmenu.m (update_frame_tool_bar):
4746 * xdisp.c (calc_pixel_width_or_height):
4747 * xfns.c (image_cache_refcount):
4748 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4749 on typical 64-bit hosts.
4750
4751 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4752 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4753 Omit unnecessary casts to int.
4754 (parse_image_spec): Check that integers fall into 'int' range
4755 when the callers expect that.
4756 (image_ascent): Redo ascent calculation to avoid int overflow.
4757 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4758 (lookup_image): Remove unnecessary tests.
4759 (xbm_image_p): Locals are now of int, not EMACS_INT,
4760 since parse_image_check makes sure they fit into int.
4761 (png_load, gif_load, svg_load_image):
4762 Prefer int to unsigned where either will do.
4763 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4764 old tiff_error_handler and tiff_warning_handler.
4765 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4766 stack buffer overflows. It uses only the features of vsnprintf
4767 that are common to both POSIX and native Microsoft.
4768 (tiff_error_handler, tiff_warning_handler): Use it.
4769 (tiff_load, gif_load, imagemagick_load_image):
4770 Don't assume :index value fits in 'int'.
4771 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4772 (imagemagick_load_image): Check that crop parameters fit into
4773 the integer types that MagickCropImage accepts. Don't assume
4774 Vimagemagick_render_type has a nonnegative value. Don't assume
4775 size_t fits in 'long'.
4776 (gs_load): Use printmax_t to print the widest integers possible.
4777 Check for integer overflow when computing image height and width.
4778
c11821d4
EZ
47792011-08-26 Eli Zaretskii <eliz@gnu.org>
4780
4781 * xdisp.c (redisplay_window): Don't force window start if point
4782 will be invisible in the resulting window. (Bug#9324)
4783
0c95fcf7
EZ
47842011-08-25 Eli Zaretskii <eliz@gnu.org>
4785
4786 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4787 the display spec is of the form `(space ...)'.
4788 (handle_display_spec): Return the value returned by
4789 handle_single_display_spec, not just 1 or zero.
4790 (handle_single_display_spec): If the display spec is of the form
4791 `(space ...)', and specifies display in the text area, return 2
4792 rather than 1.
fee65a97 4793 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4794 accurately, and prefer exact match for point under bidi.
4795 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4796
4797 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4798 into disp_prop; all users changed.
4799
4800 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4801 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4802 for the text covered by the display property.
4803
e4ed06f1
CY
48042011-08-25 Chong Yidong <cyd@stupidchicken.com>
4805
4806 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4807 Change return value to nil.
4808 (Frecord_buffer): Delete unused function.
4809
f67cdd7f
EZ
48102011-08-24 Eli Zaretskii <eliz@gnu.org>
4811
5980d4c6
EZ
4812 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4813 buffers, return left-to-right.
8610fe8b
EZ
4814 (set_cursor_from_row): Consider candidate row a win if its glyph
4815 represents a newline and point is on that newline. Fixes cursor
4816 positioning on the newline at EOL of R2L text within L2R
4817 paragraph, and vice versa.
4818 (try_cursor_movement): Check continued rows, in addition to
4819 continuation rows. Fixes unwarranted scroll when point enters a
4820 continued line of R2L text within an L2R paragraph, or vice versa.
4821 (cursor_row_p): Consider the case of point being equal to
4822 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4823 from the end of a short line to the beginning of a continued line
4824 of R2L text within L2R paragraph.
4825 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4826 composed characters.
5980d4c6 4827
f67cdd7f
EZ
4828 * bidi.c (bidi_check_type): Use xassert.
4829 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4830 members.
4831
bca633fb
EZ
48322011-08-23 Eli Zaretskii <eliz@gnu.org>
4833
4834 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4835 a character.
4836
4a5885a7
CY
48372011-08-23 Chong Yidong <cyd@stupidchicken.com>
4838
4839 * nsfont.m (ns_otf_to_script): Fix typo.
4840
0902a04e
KH
48412011-08-22 Kenichi Handa <handa@m17n.org>
4842
4843 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4844 extra slot even if the purpose is char-code-property-table.
4845
1a2e6670
EZ
48462011-08-23 Eli Zaretskii <eliz@gnu.org>
4847
8ddde651
EZ
4848 * xdisp.c (redisplay_window): When computing centering_position,
4849 account for the height of the header line. (Bug#8874)
4850
425cc014
EZ
4851 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4852 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4853 candidate is selected by the mouse, and that candidate has a
4854 composed character under the mouse.
4855
1a2e6670
EZ
4856 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4857 coordinates reported by pos-visible-in-window-p for a composed
4858 character in column zero.
4859
8b76d6f8
SM
48602011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4861
4862 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4863
dac347dd
EZ
48642011-08-22 Eli Zaretskii <eliz@gnu.org>
4865
4866 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4867 consider it a hit if to_charpos is anywhere in the range of the
4868 composed buffer positions.
4869
e013fb34
CY
48702011-08-22 Chong Yidong <cyd@stupidchicken.com>
4871
4872 * image.c (gif_load): Don't assume that each subimage has the same
4873 dimensions as the base image. Handle disposal method that is
4874 "undefined" by the gif spec (Bug#9335).
4875
bd1ba3e8
CY
48762011-08-20 Chong Yidong <cyd@stupidchicken.com>
4877
4878 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4879 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4880
54a1215b
EZ
48812011-08-19 Eli Zaretskii <eliz@gnu.org>
4882
823564e5
EZ
4883 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4884 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4885 from an Org mode buffer to a Speedbar frame.
4886
54a1215b
EZ
4887 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4888 a composition, take its buffer position from IT->cmp_it.charpos.
4889 Fixes cursor positioning at the beginning of a line that begins
4890 with a composed character.
4891
9778ebcc
EZ
48922011-08-18 Eli Zaretskii <eliz@gnu.org>
4893
0be6ee06
EZ
4894 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4895 character bidirectional type, use STRONG_L instead. Fixes crashes
4896 in a buffer produced by `describe-categories'.
4897
9778ebcc
EZ
4898 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4899 members before the level stack, so they would be saved and
4900 restored when copying iterator state. Fixes incorrect reordering
4901 around TABs covered by display properties.
4902
156bffbe
AS
49032011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4904
6b02f655 4905 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4906
72ad093b
CY
49072011-08-17 Chong Yidong <cyd@stupidchicken.com>
4908
4909 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4910 (internal_condition_case_2, internal_condition_case_n):
4911 Remove unnecessary aborts (Bug#9081).
72ad093b 4912
35774242
EZ
49132011-08-17 Eli Zaretskii <eliz@gnu.org>
4914
4915 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4916 has no `load' handler, try opening the file locally. (Bug#9311)
4917
db76dd85
KB
49182011-08-16 Ken Brown <kbrown@cornell.edu>
4919
4920 * gmalloc.c: Expand comment.
4921
b215eee5
EZ
49222011-08-16 Eli Zaretskii <eliz@gnu.org>
4923
4924 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4925 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4926
a4579d33
KB
49272011-08-16 Ken Brown <kbrown@cornell.edu>
4928
4929 Fix memory allocation problems in Cygwin build (Bug#9273).
4930
4931 * unexcw.c ( __malloc_initialized): Declare external variable.
4932 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4933
8b76d6f8
SM
4934 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4935 New variables.
a4579d33
KB
4936 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4937 dumped emacs.
4938 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4939 in the static heap.
4940 [CYGWIN] (special_realloc): New function.
4941 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4942 requests to realloc storage in the static heap.
4943
3ebec551
PE
49442011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4945
4946 * bidi.c (bidi_initialize): Remove unused local.
4947
9fd8be00
EZ
49482011-08-15 Eli Zaretskii <eliz@gnu.org>
4949
6b02f655
SM
4950 * bidimirror.h:
4951 * biditype.h: Remove file.
4952 * makefile.w32-in ($(BLD)/bidi.$(O)):
4953 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4954
4955 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4956
4957 * chartab.c: Improve commentary for the uniprop_table API.
4958
32413314
EZ
4959 * bidi.c (bidi_paragraph_init): Support zero value of
4960 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4961 (bidi_initialize): Use uniprop_table instead of including
4962 biditype.h and bidimirror.h.
32413314 4963
9fd8be00
EZ
4964 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4965 coordinates of the iterator when restoring from ppos_it.
4966 (Bug#9296)
4967
5cf2b69b
KH
49682011-08-14 Kenichi Handa <handa@m17n.org>
4969
4970 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4971 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4972
daf17d00
EZ
49732011-08-14 Eli Zaretskii <eliz@gnu.org>
4974
4975 * xdisp.c (move_it_in_display_line_to): Don't invoke
4976 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4977 ppos_it. Fixes vertical cursor motion when line beginning is
4978 covered by an image. (Bug#9296)
4979
08e3161a
JD
49802011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4981
4982 * nsterm.h (ns_run_ascript): Declare.
4983 (NSAPP_DATA2_RUNASSCRIPT): Define.
4984
4985 * nsfns.m (as_script, as_result, as_status): New static variables.
4986 (ns_run_ascript): New function.
5e617bc2 4987 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4988 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4989 the event loop. Get status from as_status (Bug#7276).
4990
4991 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4992 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4993 the event loop (Bug#7276).
4994
a3720aa2
AS
49952011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4996
4997 * gnutls.c (QCgnutls_bootprop_priority)
4998 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4999 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5000 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5001 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5002 (QCgnutls_bootprop_verify_hostname_error)
5003 (QCgnutls_bootprop_callbacks_verify): Rename from
5004 Qgnutls_bootprop_..., all uses changed.
5005
5006 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5007 uses changed.
5008
0a0d27fb
PE
50092011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5010
19d5c50c
PE
5011 * xfaces.c (Qframe_set_background_mode): Now static.
5012 * dispextern.h (Qframe_set_background_mode): Remove decl.
5013
0a0d27fb
PE
5014 * process.c (Fnetwork_interface_info): Declare local only if needed.
5015
377538cb
JD
50162011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5017
5018 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5019 (Fnetwork_interface_list): Allocate in increments of bytes instead
5020 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5021 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5022 sockaddr.
5023 (struct ifflag_def): notrailers is smart on OSX.
5024 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5025 Get hardware address with getifaddrs if available.
5026
08fff70c
EZ
50272011-08-12 Eli Zaretskii <eliz@gnu.org>
5028
5029 * xdisp.c (iterate_out_of_display_property): xassert that
5030 IT->position is set to within IT->object's boundaries. Break from
5031 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5032 when IT->position is set up wrongly due to some bug.
5033 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5034 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5035 entry. Force push_it to save on the stack the current
5036 buffer/string position, to be restored by pop_it. Fix flags in
5037 the iterator structure wrt the object coming from a display
5038 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5039 properties. (Bug#9284)
5040
7be1c708 50412011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5042
7be1c708
CY
5043 * fontset.c (fontset_get_font_group): Add proper type checks.
5044 (Bug#9172)
aac0c6e3 5045
7be1c708 50462011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5047
7be1c708
CY
5048 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5049 and LC_VERSION_MIN_MACOSX.
5050 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5051 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5052
97bb72a6
EZ
50532011-08-08 Eli Zaretskii <eliz@gnu.org>
5054
5055 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5056 no-display-properties-and-no-overlays under bidi display.
5057 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5058 properties and overlays.
97bb72a6 5059
d5617611
CY
50602011-08-08 Chong Yidong <cyd@stupidchicken.com>
5061
37e11a63
CY
5062 * editfns.c (Fset_time_zone_rule): Document relationship with the
5063 setenv function.
5064
d5617611
CY
5065 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5066 the font entity extracted from the cache (Bug#8109).
5067
58872834
CY
50682011-08-07 Chong Yidong <cyd@stupidchicken.com>
5069
5070 * composite.c (autocmp_chars): Don't reset point. That is done by
5071 restore_point_unwind (Bug#5984).
5072
75bfc667
JL
50732011-08-07 Juri Linkov <juri@jurta.org>
5074
5075 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5076 to show the arg `TIME' instead of `TIMEVAL'.
5077
d1410150
EZ
50782011-08-06 Eli Zaretskii <eliz@gnu.org>
5079
5080 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5081 display property strides EOL and includes a newline, as in
5082 longlines-mode. (Bug#9254)
75b771e4
EZ
5083 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5084 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5085
5086 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5087 is non-zero, even if the data buffer is NULL. Fixes a crash in
5088 vertical-motion with longlines-mode. (Bug#9254)
5089
35928349
EZ
50902011-08-05 Eli Zaretskii <eliz@gnu.org>
5091
ec7cc85b
EZ
5092 * bidi.c <bidi_cache_total_alloc>: Now static.
5093 (bidi_initialize): Initialize bidi_cache_total_alloc.
5094
8b76d6f8 5095 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5096 cache. (Bug#9221)
5097
5098 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5099 amount allocated this far in `bidi_cache_total_alloc'.
5100 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5101 non-zero, only free the data buffer without restoring the cache
5102 contents. All callers changed.
5103
5104 * dispextern.h (bidi_unshelve_cache): Update prototype.
5105
5106 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5107 (move_it_in_display_line, move_it_to)
5108 (move_it_vertically_backward, move_it_by_lines): Replace the call
5109 to xfree to an equivalent call to bidi_unshelve_cache.
5110 (move_it_in_display_line_to): Fix logic of returning
412b6358 5111 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5112
e2e2423b
EZ
51132011-08-05 Eli Zaretskii <eliz@gnu.org>
5114
5115 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5116 came from a string character with a `cursor' property. (Bug#9229)
5117
ae9e757a
JD
51182011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5119
5120 * Makefile.in (LIB_PTHREAD): New variable.
5121 (LIBES): Add LIB_PTHREAD (Bug#9216).
5122
5123 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5124 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5125
213bd7f2
AS
51262011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5127
6b02f655 5128 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5129
99aaf75f
JD
51302011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5131
5132 * xterm.c (x_find_topmost_parent): New function.
5133 (x_set_frame_alpha): Find topmost parent window with
5134 x_find_topmost_parent and set the property there also (bug#9181).
5135 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5136
c74e9d86
PE
51372011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5138
5139 * callproc.c (Fcall_process): Avoid vfork clobbering
5140 the local vars buffer, coding_systems, current_dir.
5141
640c8776
SM
51422011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5143
5144 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5145
f26d0e4c
PE
51462011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5147
8a10d76c
PE
5148 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5149 so that it is not optimized away.
5150
f26d0e4c
PE
5151 * xdisp.c (compute_display_string_pos): Remove unused local.
5152
55439c61
EZ
51532011-08-02 Eli Zaretskii <eliz@gnu.org>
5154
5155 Fix slow cursor motion and scrolling in large buffers with
5156 selective display, like Org Mode buffers. (Bug#9218)
5157
5158 * dispextern.h (struct bidi_it): New member disp_prop_p.
5159
5160 * xdisp.c: Remove one-slot cache of display string positions.
5161 (compute_display_string_pos): Accept an additional argument
5e617bc2 5162 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5163 for a display string or property. If found, set DISP_PROP_P
5164 non-zero.
5165
5166 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5167 DISP_PROP_P, and pass it to compute_display_string_pos.
5168 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5169 non-zero. All callers of bidi_fetch_char changed.
5170
fb33fa43
SM
51712011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5172
5173 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5174
b099e063
DM
51752010-12-03 Don March <don@ohspite.net>
5176
5177 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5178 last character M-[char] is translated to ESC [char] (bug#7541).
5179
5cc7f7af
KH
51802011-08-02 Kenichi Handa <handa@m17n.org>
5181
d0fffa3f 5182 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5183
5184 * chartab.c (uniprop_table): Make it non-static.
5185
525d5e6e
EZ
51862011-08-01 Eli Zaretskii <eliz@gnu.org>
5187
5188 * xdisp.c (forward_to_next_line_start): Accept additional argument
5189 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5190 on the newline.
5191 (reseat_at_next_visible_line_start): Use the bidi iterator state
5192 returned by forward_to_next_line_start to restore the state of
5193 it->bidi_it after backing up to previous newline. (Bug#9212)
5194
31011111
AS
51952011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5196
5197 * regex.c (re_comp): Protoize.
5198 (re_exec): Fix return type.
5199 (regexec): Fix type of `ret'. (Bug#9203)
5200
476371c4
PE
52012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5202
e5d76069
PE
5203 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5204 This is needed if max-image-size is a floating-point number.
5205
9a79b20c
AS
52062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5207
5208 * print.c (print_object): Print empty symbol as ##.
5209
5210 * lread.c (read1): Read ## as empty symbol.
5211
d8c2fa78
AA
52122011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5213
5214 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5215 setting frame foreground color (Bug#9175).
5216 (x_set_background_color): Likewise.
5217
ffe57a7a
AA
5218 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5219 contents (Bug#9176).
5220 (EmacsTooltip -init): Remove bezels and add shadows to
5221 tooltip windows.
5222
bf3492a5
AA
5223 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5224 or scroll bar (Bug#8470).
5225
d55e9c53
AA
5226 * nsfont.m (nsfont_open): Remove assignment to voffset and
5227 unnecessary vars hshink, expand, hd, full_height, min_height.
5228 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5229
5230 * nsterm.h (nsfont_info): Remove voffset field.
5231
d8c2fa78 52322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5233
5234 Implement strike-through and overline on NextStep (Bug#8863).
5235
5236 * nsfont.m (nsfont_open): Use underline position provided by font,
5237 instead of hard-coded value of 2.
5238 (nsfont_draw): Call ns_draw_text_decoration instead.
5239
5240 * nsterm.h: Add declaration for ns_draw_text_decoration.
5241
5242 * nsterm.m (ns_draw_text_decoration): New function for drawing
5243 underline, overline, and strike-through.
5244 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5245 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5246 accommodate underlining, etc.
4843aac3 5247
4cc60b9b
EZ
52482011-07-28 Eli Zaretskii <eliz@gnu.org>
5249
bc7ece87
EZ
5250 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5251 default.
4cc60b9b 5252
476371c4
PE
52532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5254
66606eea
PE
5255 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5256 Without this fix, if a signal arrives just after memory fills up,
5257 'malloc' might be invoked reentrantly.
5258
476371c4
PE
5259 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5260 In other words, assume that every image size is allowed, on non-X
5261 hosts. This assumption is probably wrong, but it lets Emacs compile.
5262
f3fcc40d
AS
52632011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5264
5265 * regex.c (re_iswctype): Convert return values to boolean.
5266
350c992f
EZ
52672011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5268
5269 * xdisp.c (compute_display_string_pos): Don't use cached display
5270 string position if the buffer had its restriction changed.
5271 (Bug#9184)
5272
5266b4bb
PE
52732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5274
5275 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5276
2573a837 52772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5278
41f55ccd 5279 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5280
39e378da
PE
5281 * bidi.c: Integer size and overflow fixes.
5282 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5283 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5284 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5285 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5286 (bidi_find_other_level_edge):
5287 Use ptrdiff_t instead of EMACS_INT where either will do.
5288 This works better on 32-bit hosts configured --with-wide-int.
5289 (bidi_cache_ensure_space): Check for size-calculation overflow.
5290 Use % rather than repeated addition, for better worst-case speed.
5291 Don't set bidi_cache_size until after xrealloc returns, because it
5292 might not return.
5293 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5294 (bidi_cache_ensure_space): Also check that the bidi cache size
5295 does not exceed that of the largest Lisp string or buffer. See Eli
5296 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5297
5e927815
PE
5298 * alloc.c (__malloc_size_t): Remove.
5299 All uses replaced by size_t. See Andreas Schwab's note
5300 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5301
ca4aa935
PE
5302 * image.c: Improve checking for integer overflow.
5303 (check_image_size): Assume that f is nonnull, since
5304 it is always nonnull in practice. This is one less thing to
5305 worry about when checking for integer overflow later.
5306 (x_check_image_size): New function, which checks for integer
5307 overflow issues inside X.
5308 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5309 This removes the need for a memory_full check.
5310 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5311 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5312 (xbm_read_bitmap_data): Change locals back to 'int', since
5313 their values must fit in 'int'.
5314 (xpm_load_image, png_load, tiff_load):
5315 Invoke x_create_x_image_and_pixmap earlier,
5316 to avoid much needless work if the image is too large.
5317 (tiff_load): Treat overly large images as if
5318 x_create_x_image_and_pixmap failed, not as malloc failures.
5319 (gs_load): Use x_check_image_size.
5320
5f8f9cc2
PE
5321 * gtkutil.c: Omit integer casts.
5322 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5323 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5324
5adf60bc
PE
5325 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5326
c8907a93
PE
5327 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5328 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5329 would wrongly return t on a 64-bit host.
5330
e3c25c68
PE
5331 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5332 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5333 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5334 and therefore cause GCC to emit a bogus diagnostic in some cases.
5335
3f791afe
PE
5336 * image.c: Integer signedness and overflow and related fixes.
5337 This is not an exhaustive set of fixes, but it's time to
5338 record what I've got.
5339 (lookup_pixel_color, check_image_size): Remove redundant decls.
5340 (check_image_size): Don't assume that arbitrary EMACS_INT values
5341 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5342 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5343 (tiff_load, imagemagick_load_image):
5344 Check for overflow in size calculations.
5345 (x_create_x_image_and_pixmap): Remove unnecessary test for
5346 xmalloc returning NULL; that can't happen.
5347 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5348 (xpm_color_bucket): Use better integer hashing function.
5349 (xpm_cache_color): Don't possibly over-allocate memory.
5350 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5351 (gif_memory_source):
5352 Use ptrdiff_t, not int or size_t, to record sizes.
5353 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5354 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5355 either works, as we prefer signed integers.
5356 (tiff_read_from_memory, tiff_write_from_memory):
5357 Return tsize_t, not size_t, since that's what the TIFF API wants.
5358 (tiff_read_from_memory): Don't fail simply because the read would
5359 go past EOF; instead, return a short read.
5360 (tiff_load): Omit no-longer-needed casts.
5361 (Fimagemagick_types): Don't assume size fits into 'int'.
5362
3cc5a532
PE
5363 Improve hashing quality when configured --with-wide-int.
5364 * fns.c (hash_string): New function, taken from sxhash_string.
5365 Do not discard information about ASCII character case; this
5366 discarding is no longer needed.
5367 (sxhash-string): Use it. Change sig to match it. Caller changed.
5368 * lisp.h: Declare it.
5369 * lread.c (hash_string): Remove, since we now use fns.c's version.
5370 The fns.c version returns a wider integer if --with-wide-int is
5371 specified, so this should help the quality of the hashing a bit.
5372
b312a492
PE
5373 * emacs.c: Integer overflow minor fix.
5374 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5375 Define only if GNU_LINUX.
5376 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5377
dfd153ae
PE
5378 * dispnew.c: Integer signedness and overflow fixes.
5379 Remove unnecessary forward decls, that were a maintenance hassle.
5380 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5381 All uses changed.
5382 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5383 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5384 (prepare_desired_row, line_draw_cost):
5385 Use int, not unsigned, where either works.
5386 (save_current_matrix, restore_current_matrix):
5387 Use ptrdiff_t, not size_t, where either works.
5388 (init_display): Check for overflow more accurately, and without
5389 relying on undefined behavior.
5390
a81d11a3
PE
5391 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5392 Remove, replacing with the new symbols in lisp.h. All uses changed.
5393 * fileio.c (make_temp_name):
5394 * filelock.c (lock_file_1, lock_file):
5395 * xdisp.c (message_dolog):
5396 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5397 Use pMd etc. instead.
5398 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5399 replacing the pWIDE etc. symbols removed from editfns.c.
5400
3300e6fd
PE
5401 * keyboard.h (num_input_events): Now uintmax_t.
5402 This is (very slightly) less likely to mess up due to wraparound.
5403 All uses changed.
5404
fd05c7e9
PE
5405 * buffer.c: Integer signedness fixes.
5406 (alloc_buffer_text, enlarge_buffer_text):
5407 Use ptrdiff_t rather than size_t when either will do, as we prefer
5408 signed integers.
5409
903fe15d
PE
5410 * alloc.c: Integer signedness and overflow fixes.
5411 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5412 (__malloc_size_t): Default to size_t, not to int.
5413 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5414 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5415 Prefer ptrdiff_t to size_t when either would do, as we prefer
5416 signed integers.
5417 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5418 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5419 Now const. Initialize with values that are in range even if char
5420 is signed.
5421 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5422 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5423 These functions do the right thing with sizes > 2**32.
5424 (check_depth): Now ptrdiff_t, not int.
5425 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5426 Adjust to new way of storing sizes. Check for size overflow bugs
5427 in rest of code.
5428 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5429 slightly wrong anyway, as it missed one instance of
5430 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5431 (refill_memory_reserve): Omit needless cast to size_t.
5432 (mark_object_loop_halt): Mark as externally visible.
5433
ac82cc6a
PE
5434 * xselect.c: Integer signedness and overflow fixes.
5435 (Fx_register_dnd_atom, x_handle_dnd_message):
5436 Use ptrdiff_t, not size_t, since we prefer signed.
5437 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5438 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5439 x_dnd_atoms_size and x_dnd_atoms_length.
5440
c2d1e36d
PE
5441 * doprnt.c: Prefer signed to unsigned when either works.
5442 * eval.c (verror):
5443 * doprnt.c (doprnt):
5444 * lisp.h (doprnt):
5445 * xdisp.c (vmessage):
5446 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5447 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5448 prefer signed arithmetic to avoid comparison confusion.
5449 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5450 but is a bit tricky.
5451
0e926e56
PE
5452 Assume freestanding C89 headers, string.h, stdlib.h.
5453 * data.c, doprnt.c, floatfns.c, print.c:
5454 Include float.h unconditionally.
5455 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5456 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5457 * regex.c: Likewise for stddef.h, string.h.
5458 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5459 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5460 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5461 (STDC_HEADERS): Remove obsolete defines.
5462 * sysdep.c: Include limits.h unconditionally.
5463
9cfdb3ec
PE
5464 Assume support for memcmp, memcpy, memmove, memset.
5465 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5466 * regex.c (memcmp, memcpy):
5467 Remove; we assume C89 now.
5468
5469 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5470 (__malloc_safe_bcopy): Remove; no longer needed.
5471
cf950e6b 5472 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5473 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5474 well either way, and we prefer signed to unsigned.
5475
dbf38e02
LMI
54762011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5477
5478 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5479 closes the connection while we're reading (bug#9182).
5480
d6f0886c 54812011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5482
d6f0886c
JD
5483 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5484 are specified (Bug#9168).
24e0f6b1 5485
2eb1f9e6
PE
54862011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5487
5488 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5489 Found by GCC static checking and --with-wide-int on a 32-bit host.
5490
22381272 54912011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5492
5493 * xdisp.c (compute_display_string_pos): Fix logic of caching
5494 previous display string position. Initialize cached_prev_pos to
5495 -1. Fixes slow-down at the beginning of a buffer.
5496
f25e39b4
EZ
54972011-07-24 Eli Zaretskii <eliz@gnu.org>
5498
5499 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5500 for attrs[LFACE_FONTSET_INDEX].
5501
04c4b52e
PE
55022011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5503
5504 * xml.c (parse_region): Remove unused local
5505 that was recently introduced.
5506
c1734fbd
EZ
55072011-07-23 Eli Zaretskii <eliz@gnu.org>
5508
be18c5a5
EZ
5509 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5510 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5511
c1734fbd
EZ
5512 * xdisp.c (move_it_in_display_line_to): Record the best matching
5513 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5514 exit if none of the characters scanned was an exact match.
5515 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5516 when exact match is impossible due to invisible text, and the
5517 lines are truncated.
5518
a258d627
JD
55192011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5520
5521 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5522 for OSX >= 10.7.
5523
b6d5a689
EZ
55242011-07-22 Eli Zaretskii <eliz@gnu.org>
5525
0f74f785
EZ
5526 Fix a significant slow-down of cursor motion with C-n, C-p,
5527 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5528 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5529 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5530 (next_element_from_buffer): Call compute_stop_pos_backwards to
5531 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5532 base_level_stop.
5533 (reseat): Don't look for prev_stop, as that could mean a very long
5534 run.
5535 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5536 <cached_disp_overlay_modiff>: Cache for last found display string
5537 position.
551918c1 5538 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5539 about the same buffer in the same area of character positions, and
5540 the buffer wasn't changed since the time the display string
5541 position was cached.
551918c1 5542
b2d0c91a
EZ
55432011-07-22 Eli Zaretskii <eliz@gnu.org>
5544
5545 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5546 is an integer, which is important for empty lines. (Bug#9149)
5547
043604ee
CY
55482011-07-22 Chong Yidong <cyd@stupidchicken.com>
5549
5550 * frame.c (Fmodify_frame_parameters): In tty case, update the
5551 default face if necessary (Bug#4238).
5552
da4adb04
CY
55532011-07-21 Chong Yidong <cyd@stupidchicken.com>
5554
5555 * editfns.c (Fstring_to_char): No need to explain what a character
5556 is in the docstring (Bug#6576).
5557
9abd0532
LMI
55582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5559
5560 * xml.c (parse_region): Make sure we always return a tree.
5561
36881d16
HK
55622011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5563
5564 * xml.c (parse_region): If a document contains only comments,
5565 return that, too.
5566
1e98674d
LMI
55672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5568
5569 * xml.c (make_dom): Return comments, too.
5570
590bd467
PE
55712011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5572
5573 Port to OpenBSD.
5574 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5575 and the surrounding thread.
5576 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5577 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5578 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5579 timer goes off.
5580 * s/openbsd.h (BROKEN_SIGIO): Define.
5581 * unexelf.c (unexec) [__OpenBSD__]:
5582 Don't update the .mdebug section of the Alpha COFF symbol table.
5583
f41628b2
LMI
55842011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5585
5586 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5587 (bug#8460).
5588
b59b67c5
PE
55892011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5590
15e3a074
PE
5591 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5592 This fixes some race conditions on the permissions of any newly
5593 created file.
5594
41bed37d
PE
5595 * alloc.c (valid_pointer_p): Use pipe, not open.
5596 This fixes some permissions issues when debugging.
5597
b59b67c5
PE
5598 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5599 If fchown fails to set both uid and gid, try to set just gid,
5600 as that is sometimes allowed. Adjust the file's mode to eliminate
5601 setuid or setgid bits that are inappropriate if fchown fails.
5602
925a6be7
SM
56032011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5604
5605 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5606 to compare Lisp_Objects.
5607 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5608 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5609 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5610
52968808
AS
56112011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5612
0a6a104b
AS
5613 * lread.c (read_integer): Unread even EOF character.
5614 (read1): Likewise. Properly record start position of symbol.
5615
52968808
AS
5616 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5617 symbol character follows.
5618
9e381cdd
PE
56192011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5620
5621 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5622 This works around a problem with the previous change to Fcopy_file.
5623 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5624 and without this change, GCC might complain about discarding
5625 fchown's return value.
5626
b5641435
JB
56272011-07-16 Juanma Barranquero <lekktu@gmail.com>
5628
5629 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5630
a8031457
PE
56312011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5632
5633 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5634
dd889327
LMI
56352011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5636
750c33f7
LMI
5637 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5638 it's used from the C level.
5639
dd889327
LMI
5640 * process.c: Use the same condition for POLL_FOR_INPUT in both
5641 keyboard.c and process.c (bug#1858).
5642
87e86684
LM
56432011-07-09 Lawrence Mitchell <wence@gmx.li>
5644
5645 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5646 (Fgnutls_boot): Use it.
5647
64348f40
AS
56482011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5649
5650 * doc.c (Fsubstitute_command_keys): Revert last change.
5651
1d698799
LMI
56522011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5653
f863868c
LMI
5654 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5655 quotes the next character, and doesn't affect other longer
5656 sequences (bug#8935).
5657
1d698799
LMI
5658 * lread.c (syms_of_lread): Clarify that is isn't only
5659 `eval-buffer' and `eval-defun' that's affected by
5660 `lexical-binding' (bug#8460).
5661
aa4b6df6
EZ
56622011-07-15 Eli Zaretskii <eliz@gnu.org>
5663
5664 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5665 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5666
5d856da6
PE
56672011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5668
ad6042bb
PE
5669 Fix minor problems found by static checking.
5670 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5671 (elsz): Now a signed constant, not a size_t var. We prefer signed
5672 types to unsigned, to avoid integer comparison confusion. Without
5673 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5674 "cannot optimize loop, the loop counter may overflow", a symptom
5675 of the confusion.
f00bbb22 5676 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5677 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5678
6468f31c
LMI
56792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5680
49080b10
LMI
5681 * search.c (Fre_search_backward): Mention `case-fold-search' in
5682 all the re_search_* functions (bug#8138).
5683
6468f31c
LMI
5684 * keyboard.c (Fopen_dribble_file): Document when the file is
5685 closed (bug#8056).
5686
c965adc5
EZ
56872011-07-14 Eli Zaretskii <eliz@gnu.org>
5688
df9733bf
EZ
5689 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5690 bidi_cache_idx.
5691
0bb23927
EZ
5692 Support bidi reordering of display and overlay strings.
5693 * xdisp.c (compute_display_string_pos)
5694 (compute_display_string_end): Accept additional argument STRING.
5695 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5696 (reseat_to_string): Initialize bidi_it->string.s and
5697 bidi_it->string.schars.
5698 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5699 NULL (avoids a crash in bidi_paragraph_init).
5700 Initialize itb.string.lstring.
0bb23927
EZ
5701 (init_iterator): Call bidi_init_it only of a valid
5702 buffer position was specified. Initialize paragraph_embedding to
5703 L2R.
5704 (reseat_to_string): Initialize the bidi iterator.
5705 (display_string): If we need to ignore text properties of
5706 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5707 original value of -1 will not work with bidi.)
5708 (compute_display_string_pos): First arg is now struct
5709 `text_pos *'; all callers changed. Support display properties on
5710 Lisp strings.
5711 (compute_display_string_end): Support display properties on Lisp
5712 strings.
5713 (init_iterator, reseat_1, reseat_to_string): Initialize the
5714 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5715 when iterating on a string not from display properties).
640c8776
SM
5716 (compute_display_string_pos, compute_display_string_end):
5717 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5718 arrow keys.
5719 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5720 base_level_stop; instead, set base_level_stop to BEGV.
5721 Fixes crashes in vertical-motion.
0bb23927
EZ
5722 (next_element_from_buffer): Improve commentary for when
5723 the iterator is before prev_stop.
5724 (init_iterator): Initialize bidi_p from the default value of
5725 bidi-display-reordering, not from buffer-local value. Use the
5726 buffer-local value only if initializing for buffer iteration.
5727 (handle_invisible_prop): Support invisible properties on strings
5728 that are being bidi-reordered.
5729 (set_iterator_to_next): Support bidi reordering of C strings and
5730 Lisp strings.
5731 (next_element_from_string): Support bidi reordering of Lisp
5732 strings.
5733 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5734 (display_string): Support display of R2L glyph rows.
5735 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5736 (init_iterator): Don't initialize it->bidi_p for strings
5737 here.
5738 (reseat_to_string): Initialize it->bidi_p for strings here.
5739 (next_element_from_string, next_element_from_c_string)
5740 (next_element_from_buffer): Add xassert's for correspondence
5741 between IT's object being iterated and it->bidi_it.string
5742 structure.
5743 (face_before_or_after_it_pos): Support bidi iteration.
5744 (next_element_from_c_string): Handle the case of the first string
5745 character that is not the first one in the visual order.
5746 (get_visually_first_element): New function, refactored from common
5747 parts of next_element_from_buffer, next_element_from_string, and
5748 next_element_from_c_string.
5749 (tool_bar_lines_needed, redisplay_tool_bar)
5750 (display_menu_bar): Force left-to-right direction. Add a FIXME
5751 comment for making that be controlled by a user option.
5752 (push_it, pop_it): Save and restore the state of the
5753 bidi iterator. Save and restore the bidi_p flag.
5754 (pop_it): Iterate out of display property for string iteration as
5755 well.
5756 (iterate_out_of_display_property): Support iteration over strings.
5757 (handle_single_display_spec): Set up it->bidi_it for iteration
5758 over a display string, and call bidi_init_it.
5759 (handle_single_display_spec, next_overlay_string)
5760 (get_overlay_strings_1, push_display_prop): Set up the bidi
5761 iterator for displaying display or overlay strings.
5762 (forward_to_next_line_start): Don't use the shortcut if
5763 bidi-iterating.
5764 (back_to_previous_visible_line_start): If handle_display_prop
5765 pushed the iterator stack, restore the internal state of the bidi
5766 iterator by calling bidi_pop_it same number of times.
5767 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5768 and we are bidi-iterating, don't decrement the iterator position;
5769 instead, set the first_elt flag in the bidi iterator, to produce
5770 the same effect.
5771 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5772 (push_display_prop): xassert that we are iterating a buffer.
5773 (push_it, pop_it): Save and restore paragraph_embedding member.
5774 (handle_single_display_spec, next_overlay_string)
5775 (get_overlay_strings_1, reseat_1, reseat_to_string)
5776 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5777 correctly. Don't assume unibyte strings are not bidi-reordered.
5778 (compute_display_string_pos)
5779 (compute_display_string_end): Fix handling the case of C string.
5780 (push_it, pop_it): Save and restore from_disp_prop_p.
5781 (handle_single_display_spec, push_display_prop): Set the
5782 from_disp_prop_p flag.
5783 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5784 (pop_it): Call iterate_out_of_display_property only if we are
5785 popping after iteration over a string that came from a display
5786 property. Fix a typo in popping stretch info. Add an assertion
5787 for verifying that the iterator position is in sync with the bidi
5788 iterator.
5789 (handle_single_display_spec, get_overlay_strings_1)
5790 (push_display_prop): Fix initialization of paragraph direction for
5791 string when that of the parent object is not yet determined.
5792 (reseat_1): Call bidi_init_it to resync the bidi
5793 iterator with IT's position. (Bug#7616)
5794 (find_row_edges): If ROW->start.pos gives position
5795 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5796 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5797 Reset the from_disp_prop_p flag.
5798 (SAVE_IT, RESTORE_IT): New macros.
5799 (pos_visible_p, face_before_or_after_it_pos)
5800 (back_to_previous_visible_line_start)
5801 (move_it_in_display_line_to, move_it_in_display_line)
5802 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5803 (try_scrolling, redisplay_window, display_line): Use them when
5804 saving a temporary copy of the iterator and restoring it back.
5805 (back_to_previous_visible_line_start, reseat_1)
5806 (init_iterator): Empty the bidi cache "stack".
5807 (move_it_in_display_line_to): If iterator ended up at
5808 EOL, but we never saw any buffer positions smaller than
5809 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5810 motion in bidi-reordered lines.
5811 (move_it_in_display_line_to): Record prev_method and prev_pos
5812 immediately before the call to set_iterator_to_next. Fixes cursor
5813 motion in bidi-reordered lines with stretch glyphs and strings
5814 displayed in margins. (Bug#8133) (Bug#8867)
5815 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5816 TO_CHARPOS.
640c8776
SM
5817 (pos_visible_p): Support positions in bidi-reordered lines.
5818 Save and restore bidi cache.
0bb23927
EZ
5819
5820 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5821 (bidi_paragraph_info): Delete unused struct.
5822 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5823 (bidi_cache_start): New variable.
5824 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5825 to zero.
5826 (bidi_cache_fetch_state, bidi_cache_search)
5827 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5828 (bidi_cache_find, bidi_peek_at_next_level)
5829 (bidi_level_of_next_char, bidi_find_other_level_edge)
5830 (bidi_move_to_visually_next): Compare cache index with
5831 bidi_cache_start rather than with zero.
5832 (bidi_fetch_char): Accept new argument STRING; all callers
5833 changed. Support iteration over a string. Support strings with
5834 display properties. Support unibyte strings. Fix the type of
5835 `len' according to what STRING_CHAR_AND_LENGTH expects.
5836 (bidi_paragraph_init, bidi_resolve_explicit_1)
5837 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5838 (bidi_level_of_next_char, bidi_move_to_visually_next):
5839 Support iteration over a string.
0bb23927
EZ
5840 (bidi_set_sor_type, bidi_resolve_explicit_1)
5841 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5842 can now be zero (for strings); special values 0 and -1 were
5843 changed to -1 and -2, respectively.
5844 (bidi_char_at_pos): New function.
5845 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5846 Call it instead of FETCH_MULTIBYTE_CHAR.
5847 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5848 initialized to valid values.
5849 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5850 values.
5851 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5852 the test for valid cached positions. Fix the logic for looking up
5853 the sentinel state in the cache. GCPRO the Lisp string we are
5854 iterating.
5855 (bidi_push_it, bidi_pop_it): New functions.
5856 (bidi_initialize): Initialize the bidi cache start stack pointer.
5857 (bidi_cache_ensure_space): New function, refactored from part of
5858 bidi_cache_iterator_state. Don't assume the required size is just
5859 one BIDI_CACHE_CHUNK away.
5860 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5861 (bidi_count_bytes, bidi_char_at_pos): New functions.
5862 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5863 always valid if bidi_cache_idx is valid.
5864 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5865 is valid if it's going to be used.
5866 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5867 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5868 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5869 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5870 (bidi_find_other_level_edge, bidi_cache_start_stack):
5871 All variables related to cache indices are now EMACS_INT.
c965adc5 5872
0bb23927
EZ
5873 * dispextern.h (struct bidi_string_data): New structure.
5874 (struct bidi_it): New member `string'. Make flag members be 1-bit
5875 fields, and put them last in the struct.
640c8776
SM
5876 (compute_display_string_pos, compute_display_string_end):
5877 Update prototypes.
0bb23927
EZ
5878 (bidi_push_it, bidi_pop_it): Add prototypes.
5879 (struct iterator_stack_entry): New members bidi_p,
5880 paragraph_embedding, and from_disp_prop_p.
5881 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5882 (bidi_shelve_cache, bidi_unshelve_cache):
5883 Declare prototypes.
0bb23927
EZ
5884
5885 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5886 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5887 and vector-like objects.
5888
5889 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5890 cache around display iteration.
5891
5892 * window.c (Fwindow_end, window_scroll_pixel_based)
5893 (displayed_window_lines, Frecenter): Save and restore the bidi
5894 cache around display iteration.
5895
3bbd2265
LMI
58962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5897
5898 * editfns.c (Fdelete_region): Clarify the use of the named
5899 parameters (bug#6788).
5900
adc47434
MR
59012011-07-14 Martin Rudalics <rudalics@gmx.at>
5902
5903 * indent.c (Fvertical_motion): Set and restore w->pointm when
5904 saving and restoring the window's buffer (Bug#9006).
5905
837c31f8
LMI
59062011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5907
5908 * editfns.c (Fstring_to_char): Clarify just what is returned
5909 (bug#6576). Text by Eli Zaretskii.
5910
ac389d0c
JB
59112011-07-13 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5914
0be0ce47
EZ
59152011-07-13 Eli Zaretskii <eliz@gnu.org>
5916
5917 * buffer.c (mmap_find): Fix a typo.
5918
cd18e7e3
JB
59192011-07-13 Johan Bockgård <bojohan@gnu.org>
5920
5921 Fix execution of x selection hooks.
5922 * xselect.c (Qx_lost_selection_functions)
5923 (Qx_sent_selection_functions): New vars.
5924 (syms_of_xselect): DEFSYM them.
5925 (x_handle_selection_request): Pass Qx_sent_selection_functions
5926 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5927 (x_handle_selection_clear,x_clear_frame_selections):
5928 Pass Qx_lost_selection_functions rather than
5929 Vx_lost_selection_functions to Frun_hook_with_args.
5930
47ea7f44
PE
59312011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5932
ac389d0c 5933 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5934 The old code sometimes used this field without initializing it.
5935
47ea7f44
PE
5936 * alloc.c (gc_sweep): Don't read past end of array.
5937 In theory, the old code could also have corrupted Emacs internals,
5938 though it'd be very unlikely.
5939
bc985c87
AS
59402011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5941
5942 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5943 argument. (Bug#4026)
bc985c87 5944
0cf34688
LMI
59452011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5946
b3dadd76
LMI
5947 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5948 key" (bug#4257).
5949
0cf34688
LMI
5950 * window.c (Fset_window_start): Doc fix (bug#4199).
5951 (Fset_window_hscroll): Ditto.
5952
270768cd
PE
59532011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5954
077e3dda 5955 Fix minor new problems caught by GCC 4.6.1.
270768cd 5956 * term.c (init_tty): Remove unused local.
490011a6 5957 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5958 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5959 not used otherwise.
270768cd 5960
b1f58454
CY
59612011-07-12 Chong Yidong <cyd@stupidchicken.com>
5962
5963 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5964
22b9578d
LMI
59652011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5966
6e70ab07
LMI
5967 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5968 are the mini-buffer and the echo area (bug#3320).
5969
22b9578d
LMI
5970 * term.c (init_tty): Remove support for supdup, c10 and perq
5971 terminals, which are no longer supported (bug#1482).
5972
8974cc9f
JB
59732011-07-10 Johan Bockgård <bojohan@gnu.org>
5974
5975 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5976
a560d974
JD
59772011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5978
5979 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5980 for non-popups (Bug#3642).
5981
1dae0f0a
AS
59822011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5983
268c2c36 5984 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5985 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5986 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5987 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5988 * data.c (fmod): Likewise.
5989 * dispnew.c (swap_glyphs_in_rows): Likewise.
5990 * emacs.c (memory_warning_signal): Likewise.
5991 * floatfns.c (float_error): Likewise.
5992 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5993 (otf_open, font_otf_capability, generate_otf_features)
5994 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5995 Likewise.
5996 * image.c (pbm_read_file): Likewise.
5997 * indent.c (string_display_width): Likewise.
5998 * intervals.c (check_for_interval, search_for_interval)
5999 (inc_interval_count, count_intervals, root_interval)
6000 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6001 * lread.c (defalias): Likewise.
268c2c36 6002 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6003 * regex.c (set_image_of_range_1, set_image_of_range)
6004 (regex_grow_registers): Likewise.
6005 * sysdep.c (strerror): Likewise.
6006 * termcap.c (valid_filename_p, tprint, main): Likewise.
6007 * tparam.c (main): Likewise.
6008 * unexhp9k800.c (run_time_remap, save_data_space)
6009 (update_file_ptrs, read_header, write_header, calculate_checksum)
6010 (copy_file, copy_rest, display_header): Likewise.
6011 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6012 Likewise.
6013 * xdisp.c (check_it): Likewise.
6014 * xfaces.c (register_color, unregister_color, unregister_colors):
6015 Likewise.
6016 * xfns.c (print_fontset_result): Likewise.
6017 * xrdb.c (member, fatal, main): Likewise.
6018
99033785
PE
60192011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6020
6021 Fix minor problems found by static checking (Bug#9031).
6022 * chartab.c (char_table_set_range, map_sub_char_table):
6023 Remove unused locals.
6024 (uniprop_table): Now static.
6025 * composite.c (_work_char): Remove unused static var.
6026
9cb2ac56
JB
60272011-07-09 Juanma Barranquero <lekktu@gmail.com>
6028
6029 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6030
f25661f0
JD
60312011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6032
6033 * gtkutil.c (qttip_cb): Remove code without function.
6034
8278c4fe
EZ
60352011-07-09 Eli Zaretskii <eliz@gnu.org>
6036
6037 * w32.c (pthread_sigmask): New stub.
6038
1692ae2d 60392011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6040
8a6ebd58 6041 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6042 sigprocmask is portable only for single-threaded applications, and
6043 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6044 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6045 (LIBES): Use it.
6046 * callproc.c (Fcall_process):
6047 * process.c (create_process):
6048 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6049 Use pthread_sigmask, not sigprocmask.
123403e4 6050
1b854618
JD
60512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6052
6053 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6054 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6055 wrong (Bug#8591).
6056
3fe4b549
JD
60572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6058
0ce7e563
JD
6059 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6060 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6061 (xg_hide_tooltip): Fix comment.
6062
3fe4b549
JD
6063 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6064 in registerServicesMenuSendTypes.
6065 (validRequestorForSendType): Don't check ns_return_types.
6066
6067 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6068 ns_return_type.
6069
5df75e47
JR
60702011-07-08 Jason Rumney <jasonr@gnu.org>
6071
22610910
JR
6072 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6073 SH_SHOW for hidden windows (Bug#5482).
6074
5df75e47
JR
6075 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6076 frame struct members of non-existent frames (Bug#6284).
6077
699c10bd
JD
60782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6079
4393663b
JD
6080 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6081 variable firstTime not needed on OSX >= 10.6.
6082 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6083 >= 10.5. Use setKnobProportion, setDoubleValue.
6084
6085 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6086 (MAC_OS_X_VERSION_10_5): Define if not defined.
6087 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6088 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6089 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6090
6091 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6092 cString and lossyCString on OSX >= 10.4
6093
58179cce 6094 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6095 sizeToFit on OSX >= 10.2.
6096
6097 * nsimage.m (allocInitFromFile): Don't use deprecated method
6098 bestRepresentationForDevice on OSX >= 10.6.
6099
6100 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6101 to avoid warning.
6102
6103 * emacs.c: Declare unexec_init_emacs_zone.
6104
a63e0781
JD
6105 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6106
699c10bd
JD
6107 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6108
6109 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6110 on svcsMenu (Bug#8842).
6111
6112 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6113 ns_return_types.
6114 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6115
6116 * nsterm.m (QUTF8_STRING): Declare.
6117 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6118 (validRequestorForSendType): Return type is (id).
6119 Change indexOfObjectIdenticalTo to indexOfObject.
6120 Check if we have local selection before returning self (Bug#8842).
6121 (writeSelectionToPasteboard): Put local selection into paste board
6122 if we have a local selection (Bug#8842).
6123 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6124
6125 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6126 (ns_get_local_selection): Declare.
6127
54e10184
LMI
61282011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6129
9888ff71
LMI
6130 * keymap.c (describe_map_tree): Don't insert a double newline at
6131 the end of the buffer (bug#1169) and return whether we inserted
6132 something.
6133
54e10184
LMI
6134 * callint.c (Fcall_interactively): Change "reading args" to
6135 "providing args" to try to clarify what it does (bug#1010).
6136
15fa4783
KH
61372011-07-07 Kenichi Handa <handa@m17n.org>
6138
6139 * composite.c (composition_compute_stop_pos): Ignore a static
6140 composition starting before CHARPOS (Bug#8915).
6141
6142 * xdisp.c (handle_composition_prop): Likewise.
6143
a8815b00
EZ
61442011-07-07 Eli Zaretskii <eliz@gnu.org>
6145
6146 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6147 (Bug#9015)
6148
ef7b981d 61492011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6150
6151 * character.h (unicode_category_t): New enum type.
6152
6153 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6154 (Qchar_code_property_table): New variable.
6155 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6156 (UNIPROP_COMPRESSED_FORM_P): New macros.
6157 (char_table_ascii): Uncompress the compressed values.
6158 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6159 Uncompress the compressed values.
ac389d0c 6160 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6161 (char_table_ref_and_range): Uncompress the compressed values.
6162 (sub_char_table_set): New arg is_uniprop. Callers changed.
6163 Uncompress the compressed values.
6164 (sub_char_table_set_range): Args changed. Callers changed.
6165 (char_table_set_range): Adjuted for the above change.
6166 (map_sub_char_table): Delete args default_val and parent. Add arg
6167 top. Give decoded values to a Lisp function.
640c8776 6168 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6169 values to a Lisp function. Gcpro more variables.
6170 (uniprop_table_uncompress)
6171 (uniprop_decode_value_run_length): New functions.
6172 (uniprop_decoder, uniprop_decoder_count): New variables.
6173 (uniprop_get_decoder, uniprop_encode_value_character)
6174 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6175 New functions.
6176 (uniprop_encoder, uniprop_encoder_count): New variables.
6177 (uniprop_get_encoder, uniprop_table)
6178 (Funicode_property_table_internal, Fget_unicode_property_internal)
6179 (Fput_unicode_property_internal): New functions.
6180 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6181 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6182 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6183 char-code-property-alist.
6184
640c8776 6185 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6186 Vunicode_category_table.
6187
640c8776 6188 * font.c (font_range): Adjust for the change of
c805dec0
KH
6189 Vunicode_category_table.
6190
76b397fb
DN
61912011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6192
6193 * m/iris4d.h: Remove file, move contents ...
6194 * s/irix6-5.h: ... here.
6195
22b4128e
PE
61962011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6197
6198 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6199 * alloc.c (mark_buffer):
6200 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6201 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6202 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6203 This isn't true in general, and it's particularly not true
6204 if Emacs is configured with --with-wide-int.
6205 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6206 New macros, used in the buffer.c change.
6207
869795d6
JD
62082011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6209
6210 * xsettings.c: Use both GConf and GSettings if both are available.
6211 (store_config_changed_event): Add comment.
6212 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6213 (store_tool_bar_style_changed): New functions.
5e617bc2 6214 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6215 (struct xsettings): Move font inside HAVE_XFT.
6216 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6217 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6218 Move inside HAVE_XFT.
640c8776 6219 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6220 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6221 also.
6222 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6223 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6224 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6225 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6226 (parse_settings): Move check for font inside HAVE_XFT.
6227 (read_settings, apply_xft_settings): Add comment.
6228 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6229 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6230 call store_font_name_changed.
6231 (xft_settings_event): Add comment.
6232 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6233 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6234 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6235 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6236 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6237 (xsettings_get_system_font, xsettings_get_system_normal_font):
6238 Add comment.
869795d6 6239
d8ed26bd
PE
62402011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6241
6242 Random fixes. E.g., (random) never returned negative values.
6243 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6244 subseconds part to the entropy, as that's a bit more random.
6245 Prefer signed to unsigned, since the signedness doesn't matter and
6246 in general we prefer signed. When given a limit, use a
6247 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6248 latter isn't right if USE_2_TAGS_FOR_INTS.
6249 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6250 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6251
cabf1cac
SM
62522011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6253
6254 * textprop.c (text_property_stickiness):
6255 Obey Vtext_property_default_nonsticky.
6256 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6257 * w32fns.c (syms_of_w32fns):
6258 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6259
6e9b2be9
PE
62602011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6261
6262 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6263 This is more efficient than Ffile_directory_p and avoids a minor race.
6264
90186c68
LMI
62652011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6266
7c301272
LMI
6267 * buffer.c (Foverlay_put): Say what the return value is
6268 (bug#7835).
6269
c4f2d8d4
LMI
6270 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6271 is a directory before asking whether to use the file name
6272 (bug#7564).
ad637907
LMI
6273 (barf_or_query_if_file_exists): Make the "File is a directory"
6274 error be more correct.
c4f2d8d4 6275
90186c68
LMI
6276 * fns.c (Frequire): Remove the mention of the .gz files, since
6277 that's installation-specific, but keep the mention of
6278 `get-load-suffixes'.
6279
da64016e
PE
62802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6281
6282 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6283 Report string overflow if the output is too long.
6284
7d47b580
JB
62852011-07-04 Juanma Barranquero <lekktu@gmail.com>
6286
a555cb87
JB
6287 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6288 (syms_of_gnutls): Remove duplicate DEFSYM for
6289 Qgnutls_bootprop_verify_hostname_error, an error for
6290 Qgnutls_bootprop_verify_error (which is no longer used).
6291
7d47b580
JB
6292 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6293 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6294 Also (re)move comments that are misplaced or no longer relevant.
6295
1e49bfab
LMI
62962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6297
6298 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6299
1485f4c0
CY
63002011-07-03 Chong Yidong <cyd@stupidchicken.com>
6301
6302 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6303 and background color parameters if they have been changed.
6304
a9ab721e
LMI
63052011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6306
6307 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6308
cf7cff57
PE
63092011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6310
2e13213d
PE
6311 * xsettings.c (SYSTEM_FONT): Define only when used.
6312 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6313
cf7cff57
PE
6314 * keymap.c (access_keymap_1): Now static.
6315
7a8e04f7
CY
63162011-07-02 Chong Yidong <cyd@stupidchicken.com>
6317
6318 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6319 leave any prefix arg for the up event (Bug#1586).
6320
61352f62
LMI
63212011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6322
69bb1ef7
LMI
6323 * lread.c (syms_of_lread): Mention single symbols defined by
6324 `defvar' or `defconst' (bug#7154).
6325
61352f62 6326 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6327 (Frequire): Mention get-load-suffixes.
61352f62 6328
28545e04
MR
63292011-07-02 Martin Rudalics <rudalics@gmx.at>
6330
6331 * window.h (window): Remove clone_number slot.
6332 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6333 Remove.
6334 (make_parent_window, make_window, saved_window)
6335 (Fset_window_configuration, save_window_save): Don't deal with
6336 clone numbers.
6337 * buffer.c (Qclone_number): Remove declaration.
6338 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6339
3349e122
SM
63402011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6341
6342 Add multiple inheritance to keymaps.
6343 * keymap.c (Fmake_composed_keymap): New function.
6344 (Fset_keymap_parent): Simplify.
6345 (fix_submap_inheritance): Remove.
6346 (access_keymap_1): New function extracted from access_keymap to handle
6347 embedded parents and handle lists of maps.
6348 (access_keymap): Use it.
6349 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6350 (Fcopy_keymap): Handle embedded parents.
6351 (Fcommand_remapping, define_as_prefix): Simplify.
6352 (Fkey_binding): Simplify.
6353 (syms_of_keymap): Move minibuffer-local-completion-map,
6354 minibuffer-local-filename-completion-map,
6355 minibuffer-local-must-match-map, and
6356 minibuffer-local-filename-must-match-map to Elisp.
6357 (syms_of_keymap): Defsubr make-composed-keymap.
6358 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6359 (parse_menu_item): Trivial simplification.
6360
3279eb87
GM
63612011-07-01 Glenn Morris <rgm@gnu.org>
6362
6363 * Makefile.in (SETTINGS_LIBS): Fix typo.
6364
4550efdf
KI
63652011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6366
6367 * coding.c (Fencode_coding_string): Record the last coding system
6368 used, as the function doc string says (bug#8738).
6369
0949d2b6
JD
63702011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6371
6372 * xsettings.c (store_monospaced_changed): Take new font as arg and
6373 check for change against current_mono_font.
6374 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6375 (emacs_settings_constructor, emacs_settings_get_property)
6376 (emacs_settings_set_property, emacs_settings_class_init)
6377 (emacs_settings_init, gsettings_obj): Remove.
6378 (something_changedCB): New function for HAVE_GSETTINGS.
6379 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6380 with value as argument.
6381 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6382 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6383 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6384 "changed".
6385
6386 * xgselect.c: Add defined (HAVE_GSETTINGS).
6387 (xgselect_initialize): Ditto.
6388
6389 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6390 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6391 xg_select.
6392
bbc6b304
PE
63932011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6394
6395 * eval.c (struct backtrace): Simplify and port the data structure.
6396 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6397 signed bit field, as this assumption is not portable and it makes
6398 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6399 "char debug_on_exit : 1" as this is not portable either; instead,
6400 use the portable "unsigned int debug_on_exit : 1". Remove unused
6401 member evalargs. Remove obsolete comments about cc bombing out.
6402
9851bfc5
JD
64032011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6404
51bb811f 6405 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6406 Let HAVE_GSETTINGS override HAVE_GCONF.
6407 (store_monospaced_changed): New function.
6408 (EMACS_SETTINGS): A new type derived from GObject to handle
6409 GSettings notifications.
6410 (emacs_settings_constructor, emacs_settings_get_property)
6411 (emacs_settings_set_property, emacs_settings_class_init):
6412 New functions.
6413 (gsettings_client, gsettings_obj): New variables.
6414 (GSETTINGS_SCHEMA): New define.
6415 (something_changedCB): Call store_monospaced_changed.
6416 (init_gsettings): New function.
6417 (xsettings_initialize): Call init_gsettings.
6418 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6419 to NULL.
6420
640c8776 6421 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6422 GCONF_CFLAGS/LIBS.
6423
5386012d
MR
64242011-06-29 Martin Rudalics <rudalics@gmx.at>
6425
6426 * window.c (resize_root_window, grow_mini_window)
6427 (shrink_mini_window): Rename Qresize_root_window to
6428 Qwindow_resize_root_window and Qresize_root_window_vertically to
6429 Qwindow_resize_root_window_vertically.
6430
f13e0b08
PE
64312011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6432
6433 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6434
94515237
JB
64352011-06-27 Juanma Barranquero <lekktu@gmail.com>
6436
6437 * makefile.w32-in: Redesign dependencies so they reflect more
6438 clearly which files are directly included by each source file,
6439 and not through other includes.
6440
e43b6e43
MR
64412011-06-27 Martin Rudalics <rudalics@gmx.at>
6442
6443 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6444 (sort_overlays, overlay_strings): When an overlay's clone number
6445 matches the window's clone number process the overlay even if
6446 the overlay's window property doesn't match the current window.
6447
d68443dc
MR
6448 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6449 (Fwindow_hchild): Rename to Fwindow_left_child.
6450 (Fwindow_next): Rename to Fwindow_next_sibling.
6451 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6452 (resize_window_check): Rename to window_resize_check.
6453 (resize_window_apply): Rename to window_resize_apply.
6454 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6455 (Fdelete_other_windows_internal, resize_frame_windows)
6456 (Fsplit_window_internal, Fdelete_window_internal)
6457 (grow_mini_window, shrink_mini_window)
6458 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6459
c7e73be5
JD
64602011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6461
6462 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6463 (emacs_fixed_set_min_size): Remove.
6464 (emacs_fixed_new): Take frame as argument.
6465
6466 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6467 (_EmacsFixedPrivate): Remove minwidth/height.
6468 Add struct frame *f.
6469 (emacs_fixed_init): Initialize priv->f.
6470 (get_parent_class, emacs_fixed_set_min_size): Remove.
6471 (emacs_fixed_new): Set priv->f to argument.
6472 (emacs_fixed_get_preferred_width)
6473 (emacs_fixed_get_preferred_height): Use min_width/height from
6474 frames size_hint to set minimum and natural (Bug#8919).
6475 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6476 and use min_width/height from frames size_hint to set
6477 min_width/height (Bug#8919).
6478
6479 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6480 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6481 Fix indentation.
c7e73be5 6482
cf99dcf8
EZ
64832011-06-26 Eli Zaretskii <eliz@gnu.org>
6484
6485 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6486 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6487 called at ZV.
6488
029529ac
CY
64892011-06-26 Chong Yidong <cyd@stupidchicken.com>
6490
6491 * process.c (wait_reading_process_output): Bypass select if
6492 waiting for a cell while ignoring keyboard input, and input is
6493 pending. Suggested by Jan Djärv (Bug#8869).
6494
7a7ef429
PE
64952011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6496
6497 Use gnulib's dup2 module instead of rolling our own.
6498 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6499
11fdef7d 65002011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6501
6502 * dispnew.c (scrolling_window): Before scrolling, turn off a
6503 mouse-highlight in the window being scrolled.
6504
cd3520a4
JB
65052011-06-24 Juanma Barranquero <lekktu@gmail.com>
6506
6507 Move DEFSYM to lisp.h and use everywhere.
6508
6509 * character.h (DEFSYM): Move declaration...
6510 * lisp.h (DEFSYM): ...here.
6511
6512 * gnutls.c:
6513 * minibuf.c:
6514 * w32menu.c:
6515 * w32proc.c:
6516 * w32select.c: Don't include character.h.
6517
6518 * alloc.c (syms_of_alloc):
6519 * buffer.c (syms_of_buffer):
6520 * bytecode.c (syms_of_bytecode):
6521 * callint.c (syms_of_callint):
6522 * casefiddle.c (syms_of_casefiddle):
6523 * casetab.c (init_casetab_once):
6524 * category.c (init_category_once, syms_of_category):
6525 * ccl.c (syms_of_ccl):
6526 * cmds.c (syms_of_cmds):
6527 * composite.c (syms_of_composite):
6528 * dbusbind.c (syms_of_dbusbind):
6529 * dired.c (syms_of_dired):
6530 * dispnew.c (syms_of_display):
6531 * doc.c (syms_of_doc):
6532 * editfns.c (syms_of_editfns):
6533 * emacs.c (syms_of_emacs):
6534 * eval.c (syms_of_eval):
6535 * fileio.c (syms_of_fileio):
6536 * fns.c (syms_of_fns):
6537 * frame.c (syms_of_frame):
6538 * fringe.c (syms_of_fringe):
6539 * insdel.c (syms_of_insdel):
6540 * keymap.c (syms_of_keymap):
6541 * lread.c (init_obarray, syms_of_lread):
6542 * macros.c (syms_of_macros):
6543 * msdos.c (syms_of_msdos):
6544 * print.c (syms_of_print):
6545 * process.c (syms_of_process):
6546 * search.c (syms_of_search):
6547 * sound.c (syms_of_sound):
6548 * syntax.c (init_syntax_once, syms_of_syntax):
6549 * terminal.c (syms_of_terminal):
6550 * textprop.c (syms_of_textprop):
6551 * undo.c (syms_of_undo):
6552 * w32.c (globals_of_w32):
6553 * window.c (syms_of_window):
6554 * xdisp.c (syms_of_xdisp):
6555 * xfaces.c (syms_of_xfaces):
6556 * xfns.c (syms_of_xfns):
6557 * xmenu.c (syms_of_xmenu):
6558 * xsettings.c (syms_of_xsettings):
6559 * xterm.c (syms_of_xterm): Use DEFSYM.
6560
4228cf16
TZ
65612011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6562
cd3520a4 6563 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6564
7fcccf1e
PE
65652011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6566
7efb4e0e
PE
6567 Integer and buffer overflow fixes (Bug#8873).
6568
ff5844ad
PE
6569 * print.c (printchar, strout): Check for string overflow.
6570 (PRINTPREPARE, printchar, strout):
6571 Don't set size unless allocation succeeds.
6572
90532f02
PE
6573 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6574 for sizes. Check for string overflow more accurately.
6575 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6576
6d84508d
PE
6577 * macros.c: Integer and buffer overflow fixes.
6578 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6579 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6580 Use ptrdiff_t, not int, for sizes.
6581 Don't increment bufsize until after realloc succeeds.
6582 Check for size-calculation overflow.
6583 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6584
437b2cb4
PE
6585 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6586
8b9ac8b4
PE
6587 * lread.c: Integer overflow fixes.
6588 (read_integer): Radix is now EMACS_INT, not int,
6589 to improve quality of diagnostics for out-of-range radices.
6590 Calculate buffer size correctly for out-of-range radices.
6591 (read1): Check for integer overflow in radices, and in
6592 read-circle numbers.
82cb60d3
PE
6593 (read_escape): Avoid int overflow.
6594 (Fload, openp, read_buffer_size, read1)
6595 (substitute_object_recurse, read_vector, read_list, map_obarray):
6596 Use ptrdiff_t, not int, for sizes.
6597 (read1): Use EMACS_INT, not int, for sizes.
20270765 6598 Check for size overflow.
8b9ac8b4 6599
7fcccf1e
PE
6600 * image.c (cache_image): Check for size arithmetic overflow.
6601
bfbbd7e7
PE
6602 * lread.c: Integer overflow issues.
6603 (saved_doc_string_size, saved_doc_string_length)
6604 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6605 Now ptrdiff_t, not int.
6606 (read1): Don't assume doc string length fits in int. Check for
6607 out-of-range doc string lengths.
6608 (read_list): Don't assume file position fits in int.
39019e54 6609 (read_escape): Check for hex character overflow.
bfbbd7e7 6610
4e323265
LL
66112011-06-22 Leo Liu <sdl.web@gmail.com>
6612
6613 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6614 Move to minibuffer.el.
6615
85fece3e
PE
66162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6617
20b84ce9 6618 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6619 The following patches are for when GLYPH_DEBUG && !XASSERT.
6620 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6621 * dispnew.c (flush_stdout):
6622 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6623 Mark as externally visible.
6624 * dispnew.c (check_window_matrix_pointers): Now static.
6625 * dispnew.c (window_to_frame_vpos):
6626 * xfns.c (unwind_create_frame):
6627 * xterm.c (x_check_font): Remove unused local.
6628 * scroll.c (CHECK_BOUNDS):
6629 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6630 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6631 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6632 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6633 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6634 Now static.
6635 (debug_method_add): Use va_list and vsprintf rather than relying
6636 on undefined behavior with wrong number of arguments.
6637 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6638 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6639 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6640 since we're not interested in debugging glyphs with old libraries.
6641 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6642 GCC 4.6.0's static checking.
6643
0766b489
PE
66442011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6645
31fd4b32
PE
6646 Integer overflow and signedness fixes (Bug#8873).
6647 A few related buffer overrun fixes, too.
6648
b79e8648
PE
6649 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6650
0766b489
PE
6651 * dispextern.h (struct face.stipple):
6652 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6653 (x_bitmap_mask, x_allocate_bitmap_record)
6654 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6655 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6656 (x_create_bitmap_from_xpm_data):
6657 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6658 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6659 (.bitmaps_last):
6660 * xfaces.c (load_pixmap):
6661 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6662 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6663 (.bitmaps_last, struct x_output.icon_bitmap):
6664 Use ptrdiff_t, not int, for bitmap indexes.
6665 (x_allocate_bitmap_record): Check for size overflow.
6666 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6667
b081724f
PE
6668 Use ptrdiff_t, not int, for overlay counts.
6669 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6670 * editfns.c (overlays_around, get_pos_property):
6671 * textprop.c (get_char_property_and_overlay):
6672 * xdisp.c (next_overlay_change, note_mouse_highlight):
6673 * xfaces.c (face_at_buffer_position):
21514da7
PE
6674 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6675 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6676 (Fnext_overlay_change, Fprevious_overlay_change)
6677 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6678 Use ptrdiff_t, not int, for sizes.
21514da7 6679 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6680
3de73e5e
PE
6681 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6682
2606c57b
PE
6683 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6684 (x_session_initialize): Do not assume string length fits in int.
6685
aaafe47a
PE
6686 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6687 This is unlikely, but can occur if DPI is outlandish.
6688
2674ddc8 6689 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6690 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6691
28154962
PE
6692 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6693 * xrdb.c (magic_file_p, search_magic_path):
6694 Omit last arg SUFFIX; it was always 0. All callers changed.
6695 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6696
7de51af5
PE
6697 * xfont.c (xfont_match): Avoid need for strlen.
6698
25ed6cc3
PE
6699 * xfns.c: Don't assume strlen fits in int.
6700 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6701
4eab31dd
PE
6702 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6703 not unsigned long, as we prefer signed integers. All callers changed.
6704 Detect integer overflow in repeat count.
6705 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6706 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6707
171e2a58
PE
6708 * termcap.c: Don't assume sizes fit in int and never overflow.
6709 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6710 (gobble_line): Check for size-calculation overflow.
6711
ad39faca 6712 * minibuf.c (Fread_buffer):
6e5bb2dc 6713 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6714 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6715 Don't assume string length fits in int.
6716
52c61c22 6717 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6718 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6719
b5b8c9e5
PE
6720 * font.c: Don't assume string length fits in int.
6721 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6722 Use ptrdiff_t, not int.
ccd6111c
PE
6723 (font_intern_prop): Don't assume string length fits in int.
6724 Don't assume integer property fits in fixnum.
6725 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6726
882f0d81 6727 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6728 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6729 Reformulate so as not to need the command string.
6730 Invoke gzip -cd rather than gunzip, as it's more portable.
6731 (lock_info_type, lock_file_1, lock_file):
6732 Don't assume pid_t and time_t fit in unsigned long.
6733 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6734 (current_lock_owner): Prefer signed type for sizes.
6735 Use memcpy, not strncpy, where memcpy is what is really wanted.
6736 Don't assume (via atoi) that time_t and pid_t fit in int.
6737 Check for time_t and/or pid_t out of range, e.g., via a network share.
6738 Don't alloca where an auto var works fine.
6739
93f4cf88
PE
6740 * fileio.c: Fix some integer overflow issues.
6741 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6742 Don't assume string length fits in int.
6743 (directory_file_name): Don't assume string length fits in long.
6744 (make_temp_name): Don't assume pid fits in int, or that its print
6745 length is less than 20.
6746
f3e92b69
PE
6747 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6748
1bfdaf10
PE
6749 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6750
35016e9a
PE
6751 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6752
3d1e65a1
PE
6753 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6754 We prefer signed integers, even for size calculations.
6755
0b963a93
PE
6756 * emacs.c: Don't assume string length fits in 'int'.
6757 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6758 (main): Don't invoke strlen when not needed.
6759
573f4b54
PE
6760 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6761 (XD_DEBUG_MESSAGE): Don't waste a byte.
6762
989f33ba
PE
6763 * callproc.c (getenv_internal_1, getenv_internal)
6764 (Fgetenv_internal):
965d34eb
PE
6765 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6766
e4d29b33
PE
6767 * lread.c (invalid_syntax): Omit length argument.
6768 All uses changed. This doesn't fix a bug, but it simplifies the
6769 code away from its former Hollerith-constant appearance, and it's
6770 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6771 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6772
eb49b136
PE
6773 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6774 This didn't break anything, but it didn't help either.
6775 It's confusing to put a bogus integer in a place where the actual
6776 value does not matter.
9f62aeb1 6777 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6778 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6779
15375a22
PE
6780 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6781 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6782 implementation.
b61cc01c
PE
6783 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6784 We prefer signed types, and the value cannot exceed the EMACS_INT
6785 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6786 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6787 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6788 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6789
53b2623d
PE
6790 * indent.c (sane_tab_width): New function.
6791 (current_column, scan_for_column, Findent_to, position_indentation)
6792 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6793 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6794
51cab52b 6795 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6796
f2ed8a70
PE
6797 * lisp.h (lint_assume): New macro.
6798 * composite.c (composition_gstring_put_cache):
6799 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6800
abe80cc6
PE
6801 * editfns.c, insdel.c:
6802 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6803
b02c740e
PE
6804 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6805
ebc96716
PE
6806 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6807
b4e50fa0 6808 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6809 Use much-faster test for byte-length change.
311d5d7c 6810 Don't assume string byte-length fits in 'int'.
a4cf38e4 6811 Check that character arg fits in 'int'.
85461888 6812 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6813
c0c1ee9f
PE
6814 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6815
a498d7f4
PE
6816 * fns.c (concat): Catch string overflow earlier.
6817 Do not rely on integer wraparound.
6818
51cab52b
PE
6819 * dispextern.h (struct it.overlay_strings_charpos)
6820 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6821 * xdisp.c (forward_to_next_line_start)
6822 (back_to_previous_visible_line_start)
6823 (reseat_at_next_visible_line_start, next_element_from_buffer):
6824 Don't arbitrarily truncate the value of 'selective' to int.
6825
76031fad
PE
6826 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6827
5eb55db9
PE
6828 * composite.c: Don't truncate sizes to 'int'.
6829 (composition_gstring_p, composition_reseat_it)
6830 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6831 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6832 not EMACS_UINT, for indexes.
5eb55db9 6833
0703a717
PE
6834 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6835
d6202519
PE
6836 * buffer.c: Include <verify.h>.
6837 (struct sortvec.priority, struct sortstr.priority):
8961a454 6838 Now EMACS_INT, not int.
c20998a7 6839 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6840 (struct sortstr.size, record_overlay_string)
6841 (struct sortstrlist.size, struct sortlist.used):
6842 Don't truncate size to int.
6843 (record_overlay_string): Check for size-calculation overflow.
d6202519 6844 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6845
d5a19415
JM
68462011-06-22 Jim Meyering <meyering@redhat.com>
6847
029529ac 6848 Don't leak an XBM-image-sized buffer
d5a19415
JM
6849 * image.c (xbm_load): Free the image buffer after using it.
6850
a9041e6c
PE
68512011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6852
6853 Port to Sun C.
6854 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6855 that Sun C diagnosed.
6856 * fns.c (secure_hash): Fix pointer signedness issue.
6857 * intervals.c (static_offset_intervals): New function.
6858 (offset_intervals): Use it.
6859
7f3f739f
LL
68602011-06-21 Leo Liu <sdl.web@gmail.com>
6861
6862 * deps.mk (fns.o):
6863 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6864 sha512.h.
6865
6866 * fns.c (secure_hash): Rename from crypto_hash_function and change
6867 the first arg to accept symbols.
5b66d427 6868 (Fsecure_hash): New primitive.
7f3f739f
LL
6869 (syms_of_fns): New symbols.
6870
76147d94
DD
68712011-06-20 Deniz Dogan <deniz@dogan.se>
6872
6873 * process.c (Fset_process_buffer): Clarify return value in
6874 docstring.
6875
7d7d0045
CY
68762011-06-18 Chong Yidong <cyd@stupidchicken.com>
6877
6878 * dispnew.c (add_window_display_history): Use BVAR.
6879
6880 * xdisp.c (debug_method_add): Use BVAR.
6881 (check_window_end, dump_glyph_matrix, dump_glyph)
6882 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6883
6884 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6885 Likewise.
6886
6887 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6888 check till after the cache is created in init_frame_faces.
6889
ff2bc410
SM
68902011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6891
6892 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6893
28177add
PE
68942011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6895
dd3482fe
PE
6896 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6897 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6898 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6899
393d71f3 6900 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6901 * fileio.c (Finsert_file_contents):
6902 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6903 Remove the old (too-loose) buffer overflow checks.
6904 They weren't needed, since make_gap checks for buffer overflow.
6905 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6906 The old code merely checked for Emacs fixnum overflow, and relied
6907 on undefined (wraparound) behavior. The new code avoids undefined
6908 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6909
2e6813b0 6910 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6911 Tune. Don't use wider integers than needed. Don't use alloca.
6912 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6913
599a9e4f
PE
6914 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6915
99561444
PE
6916 * insdel.c, lisp.h (buffer_overflow): New function.
6917 (insert_from_buffer_1, replace_range, replace_range_2):
6918 * insdel.c (make_gap_larger):
6919 * editfns.c (Finsert_char):
6920 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6921
28177add
PE
6922 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6923
e69dafad
PE
69242011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6925
4baa020d 6926 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6927
b1c46f02
PE
6928 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6929 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6930
e69dafad
PE
6931 * fileio.c: Don't assume EMACS_INT fits in off_t.
6932 (emacs_lseek): New static function.
6933 (Finsert_file_contents, Fwrite_region): Use it.
6934 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6935
566684ea
PE
6936 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6937
e6966cd6
PE
6938 * fns.c: Don't overflow int when computing a list length.
6939 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6940 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6941 truncation on 64-bit hosts. Check for QUIT every
6942 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6943 faster and is responsive enough.
6944 (Flength): Report an error instead of overflowing an integer.
6945 (Fsafe_length): Return a float if the value is not representable
6946 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6947 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6948 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6949
dd0b0efb
PE
6950 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6951 (header_size, word_size): New constants.
6952 (allocate_vectorlike): Don't check size overflow here.
6953 (allocate_vector): Check it here instead, since this is the only
6954 caller of allocate_vectorlike that could cause overflow.
6955 Check that the new vector's length is representable as a fixnum.
6956
86fe5cfe
PE
6957 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6958 The previous code was bogus. For example, next_almost_prime (32)
6959 returned 39, which is undesirable as it is a multiple of 3; and
6960 next_almost_prime (24) returned 25, which is a multiple of 5 so
6961 why was the code bothering to check for multiples of 7?
6962
80e88859
PE
6963 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6964
4a2f0ad6
PE
6965 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6966
f66c7cf8
PE
6967 Variadic C functions now count arguments with ptrdiff_t.
6968 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6969 Back then I didn't know that the Emacs coding style prefers signed int.
6970 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6971 were being counted with int, which may truncate counts on 64-bit
6972 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6973 * lisp.h (struct Lisp_Subr.function.aMANY)
6974 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6975 Arg counts are now ptrdiff_t, not size_t.
6976 All variadic functions and their callers changed accordingly.
6977 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6978 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6979 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6980 * callint.c (Fcall_interactively): Check arg count for overflow,
6981 to avoid potential buffer overrun. Use signed char, not 'int',
6982 for 'varies' array, so that we needn't bother to check its size
6983 calculation for overflow.
6984 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6985 * eval.c (apply_lambda):
6986 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6987 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6988 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6989
a1759b76
PE
6990 * callint.c (Fcall_interactively): Don't use index var as event count.
6991
d96be9fc
PE
6992 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6993 * mem-limits.h (SIZE): Remove; no longer used.
6994
a690a978 6995 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6996
578c21e6
PE
6997 Remove unnecessary casts.
6998 * xterm.c (x_term_init):
6999 * xfns.c (x_set_border_pixel):
7000 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7001 These aren't needed now that we assume ANSI C.
7002
96f53c6c
PE
7003 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7004 It's more likely to cause problems (due to unsigned overflow)
7005 than to cure them.
7006
83c77d31
PE
7007 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7008
ee2079f1
PE
7009 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7010
6da65536
PE
7011 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7012
7147c4a4
PE
7013 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7014
193e32d9
PE
7015 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7016
e5533da6
PE
7017 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7018
9910e595
PE
7019 GLYPH_CODE_FACE returns EMACS_INT, not int.
7020 * dispextern.h (merge_faces):
7021 * xfaces.c (merge_faces):
01103c44
PE
7022 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7023 Don't assume EMACS_INT fits in int.
9910e595 7024
2638320e
PE
7025 * character.h (CHAR_VALID_P): Remove unused parameter.
7026 * fontset.c, lisp.h, xdisp.c: All uses changed.
7027
045eb8d9
PE
7028 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7029
c1f134b5
PE
7030 * fns.c (concat): Minor tuning based on overflow analysis.
7031 This doesn't fix any bugs. Use int to hold character, instead
7032 of constantly refetching from Emacs object. Use XFASTINT, not
7033 XINT, for value known to be a character. Don't bother comparing
7034 a single byte to 0400, as it's always less.
7035
395fcb93 7036 * floatfns.c (Fexpt):
327eeec8
PE
7037 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7038
abbd3d23
PE
7039 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7040 for characters.
7041
684a03ef
PE
7042 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7043
0fed43f3
PE
7044 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7045 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7046 incorrectly succeed when S was a string, because 4294967386 was
7047 truncated before it was used.
7048
8fd02eb7
PE
7049 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7050 Otherwise, an out-of-range integer could cause undefined behavior
7051 on a 64-bit host.
7052
f8c86b69
PE
7053 * composite.c: Use int, not EMACS_INT, for characters.
7054 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7055 EMACS_INT, for values that are known to be in character range.
7056 This doesn't fix any bugs but is the usual style inside Emacs and
7057 may generate better code on 32-bit machines.
7058
34206dd2
PE
7059 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7060 This is for reasons similar to the recent CHAR_STRING fix.
7061 * charset.c (Fencode_char): Check that character arg is actually
7062 a character. Pass an int to ENCODE_CHAR.
7063 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7064 wider than 'int', as a compile-time check to prevent future regressions
7065 in this area.
7066
c5958d4c 7067 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7068
7069 Make sure a 64-bit char is never passed to CHAR_STRING.
7070 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7071 by silently ignoring the top 32 bits, allowing some values
7072 that were far too large to be valid characters.
7073 * character.h: Include <verify.h>.
7074 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7075 arguments are no wider than unsigned, as a compile-time check
7076 to prevent future regressions in this area.
7077 * data.c (Faset):
01103c44 7078 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7079 (Fsubst_char_in_region):
7080 * fns.c (concat):
7081 * xdisp.c (decode_mode_spec_coding):
7082 Adjust to CHAR_STRING's new requirement.
7083 * editfns.c (Finsert_char, Fsubst_char_in_region):
7084 * fns.c (concat): Check that character args are actually
7085 characters. Without this test, these functions did the wrong
7086 thing with wildly out-of-range values on 64-bit hosts.
7087
d37ca623
PE
7088 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7089 These casts should not be needed on 32-bit hosts, either.
7090 * keyboard.c (read_char):
7091 * lread.c (Fload): Remove casts to unsigned.
7092
ea204efb
PE
7093 * lisp.h (UNSIGNED_CMP): New macro.
7094 This fixes comparison bugs on 64-bit hosts.
7095 (ASCII_CHAR_P): Use it.
7096 * casefiddle.c (casify_object):
01103c44 7097 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7098 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7099 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7100 * dispextern.h (FACE_FROM_ID):
7101 * keyboard.c (read_char): Use UNSIGNED_CMP.
7102
41cb286c
PE
7103 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7104 not to EMACS_INT, to avoid GCC warning.
7105
4a1b9832
PE
7106 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7107
55daad71
PE
7108 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7109 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7110 isn't needed on 32-bit machines.
8f95c75c 7111
01103c44
PE
7112 * buffer.c (Fgenerate_new_buffer_name):
7113 Use EMACS_INT for count, not int.
0ceccced 7114 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7115
7116 * data.c (Qcompiled_function): Now static.
7117
c6f072e7
PE
7118 * window.c (window_body_lines): Now static.
7119
20ce5912
PE
7120 * image.c (gif_load): Rename local to avoid shadowing.
7121
9c4c5f81
PE
7122 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7123 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7124 * alloc.c (make_save_value): Integer argument is now of type
7125 ptrdiff_t, not int.
7126 (mark_object): Use ptrdiff_t, not int.
7127 * lisp.h (pD): New macro.
7128 * print.c (print_object): Use it.
7129
c0c5c8ae
PE
7130 * alloc.c: Use EMACS_INT, not int, to count objects.
7131 (total_conses, total_markers, total_symbols, total_vector_size)
7132 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7133 (total_free_floats, total_floats, total_free_intervals)
7134 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7135 Now EMACS_INT, not int. All uses changed.
7136 (Fgarbage_collect): Compute overall total using a double, so that
7137 integer overflow is less likely to be a problem. Check for overflow
7138 when converting back to an integer.
5a25e253
PE
7139 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7140 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7141 These were 'int' variables that could overflow on 64-bit hosts;
7142 they were never used, so remove them instead of repairing them.
211a0b2a 7143 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7144 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7145 Previously, this ceilinged at INT_MAX, but that doesn't work on
7146 64-bit machines.
e46bb31a 7147 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7148
c78baabf 7149 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7150 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7151 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7152 when a (possibly-narrower) signed value would do just as well.
7153 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7154
c9d624c6
PE
7155 * alloc.c: Catch some string size overflows that we were missing.
7156 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7157 for convenience in STRING_BYTES_MAX.
7158 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7159 The definition here is exact; the one in lisp.h was approximate.
7160 (allocate_string_data): Check for string overflow. This catches
7161 some instances we weren't catching before. Also, it catches
7162 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7163 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7164 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7165
c9d624c6
PE
7166 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7167 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7168 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7169
353032ce
PE
7170 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7171
2bccce07
PE
7172 * alloc.c (Fmake_string): Check for out-of-range init.
7173
0ac30604
SM
71742011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7175
7176 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7177
c195f2de
JD
71782011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7179
7180 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7181 xg_get_default_scrollbar_width.
7182
7183 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7184 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7185 (style_changed_cb): Call update_theme_scrollbar_width and call
7186 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7187 all frames (Bug#8505).
7188 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7189 Call gtk_window_set_resizable if HAVE_GTK3.
7190 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7191 and height if HAVE_GTK3 (Bug#8505).
7192 (scroll_bar_width_for_theme): New variable.
7193 (update_theme_scrollbar_width): New function.
7194 (xg_get_default_scrollbar_width): Move code to
7195 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7196 (xg_initialize): Call update_theme_scrollbar_width.
7197
7198 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7199
7200 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7201
e10ac9f1
MR
72022011-06-12 Martin Rudalics <rudalics@gmx.at>
7203
7204 * frame.c (make_frame): Call other_buffer_safely instead of
7205 other_buffer.
7206
7207 * window.c (temp_output_buffer_show): Call display_buffer with
7208 second argument Vtemp_buffer_show_specifiers and reset latter
7209 immediately after the call.
7210 (Vtemp_buffer_show_specifiers): New variable.
7211 (auto_window_vscroll_p, next_screen_context_lines)
7212 (Vscroll_preserve_screen_position): Remove leading asterisks from
7213 doc-strings.
7214
2d3c217e 72152011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7216
7b7f97e8 7217 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7218 * buffer.c (Qclone_number): Remove for now, as it's unused.
7219 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7220 (record_buffer): Remove unused local.
7221 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7222 (set_frame_buffer_list): Remove; unused.
7223 * frame.h (other_visible_frames): Remove decl.
7224 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7225 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7226 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7227 if HAVE_GPM.
7228 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7229 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7230 Define only if HAVE_GPM.
7231 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7232 (update_hints_inhibit): Remove; never set. All uses removed.
7233 * widgetprv.h (emacsFrameClassRec): Remove decl.
7234 * window.c (delete_deletable_window): Now returns void, since it
7235 wasn't returning anything.
7236 (compare_window_configurations): Remove unused locals.
7237 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7238 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7239 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7240 the same widths as pointers. This follows up on the 2011-05-06 patch.
7241 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7242 * xterm.h: Likewise.
7243 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7244
1384b89e
JB
72452011-06-12 Juanma Barranquero <lekktu@gmail.com>
7246
7247 * makefile.w32-in: Update dependencies.
7248 (LISP_H): Add lib/intprops.h.
7249
1100a63c
CY
72502011-06-11 Chong Yidong <cyd@stupidchicken.com>
7251
7252 * image.c (gif_load): Add animation frame delay to the metadata.
7253 (syms_of_image): Use DEFSYM. New symbol `delay'.
7254
6198ccd0
MR
72552011-06-11 Martin Rudalics <rudalics@gmx.at>
7256
7257 * window.c (delete_deletable_window): Re-add.
7258 (Fset_window_configuration): Rewrite to handle dead buffers and
7259 consequently deletable windows.
7260 (window_tree, Fwindow_tree): Remove. Supply functionality in
7261 window.el.
7262 (compare_window_configurations): Simplify code.
7263
b6e3633c
AS
72642011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7265
1ab0dee5
AS
7266 * image.c (imagemagick_load_image): Fix type mismatch.
7267 (Fimagemagick_types): Likewise.
7268
b6e3633c
AS
7269 * window.h (replace_buffer_in_windows): Declare.
7270
9397e56f
MR
72712011-06-11 Martin Rudalics <rudalics@gmx.at>
7272
7273 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7274 Qclone_number. Remove external declaration of Qdelete_window.
7275 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7276 code.
640c8776
SM
7277 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7278 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7279 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7280 buffer list implementation.
7281 (other_buffer_safely): New function.
7282 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7283 calls to replace_buffer_in_windows and
7284 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7285 if allowed.
7286 (record_buffer): Inhibit quitting and rewrite using quittable
7287 functions. Run Qbuffer_list_update_hook if allowed.
7288 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7289 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7290 Move switch-to-buffer to window.el.
9397e56f
MR
7291 (bury-buffer): Move to window.el.
7292 (Vbuffer_list_update_hook): New variable.
7293
7294 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7295 section.
7296
7297 * window.h (resize_frame_windows): Move up in code.
7298 (Fwindow_frame): Remove EXFUN.
7299 (replace_buffer_in_all_windows): Remove prototype.
7300 (replace_buffer_in_windows_safely): Add prototype.
7301
7302 * window.c: Declare Qdelete_window static again. Move down
7303 declaration of select_count.
7304 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7305 (Fother_window): Move to window.el.
7306 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7307 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7308 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7309 window.el.
7310 (replace_buffer_in_windows): Implement by calling
7311 Qreplace_buffer_in_windows.
7312 (replace_buffer_in_all_windows): Remove with some functionality
7313 moved into replace_buffer_in_windows_safely.
7314 (replace_buffer_in_windows_safely): New function.
7315 (select_window_norecord, select_frame_norecord): Move in front
7316 of run_window_configuration_change_hook. Remove now obsolete
7317 declarations.
640c8776
SM
7318 (Fset_window_buffer): Rewrite doc-string.
7319 Call Qrecord_window_buffer.
9397e56f
MR
7320 (keys_of_window): Move binding for other-window to window.el.
7321
b50691aa
CY
73222011-06-11 Chong Yidong <cyd@stupidchicken.com>
7323
7324 * dispextern.h (struct image): Replace data member, whose int_val
7325 and ptr_val fields were not used by anything, with a single
7326 lisp_val object.
7327
7328 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7329 (gif_clear_image, gif_load, imagemagick_load_image)
7330 (gs_clear_image, gs_load): Callers changed.
7331
3f754b86
PE
73322011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7333
cca69397
PE
7334 * buffer.h: Include <time.h>, for time_t.
7335 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7336
109e28d0
PE
7337 Fix minor problems found by static checking.
7338
60737f02
PE
7339 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7340
4b66faf3
PE
7341 Make identifiers static if they are not used in other modules.
7342 * data.c (Qcompiled_function, Qframe, Qvector):
7343 * image.c (QimageMagick, Qsvg):
7344 * minibuf.c (Qmetadata):
7345 * window.c (resize_window_check, resize_root_window): Now static.
7346 * window.h (resize_window_check, resize_root_window): Remove decls.
7347
109e28d0
PE
7348 * window.c (window_deletion_count, delete_deletable_window):
7349 Remove; unused.
46a4ce9e
PE
7350 (window_body_lines): Now static.
7351 (Fdelete_other_windows_internal): Mark vars as initialized.
7352 Make sure 'resize_failed' is initialized.
7353 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7354 (resize_window_apply): Remove unused local.
7355 * window.h (delete_deletable_window): Remove decl.
7356
109e28d0 7357 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7358 (imagemagick_load_image): Fix pointer signedness problem by changing
7359 last arg from unsigned char * to char *. All uses changed.
7360 Also, fix a local for similar reasons.
7361 Remove unused locals. Remove locals to avoid shadowing.
7362 (fn_rsvg_handle_free): Remove; unused.
7363 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7364 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7365
3f754b86
PE
7366 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7367
2547adb1
CY
73682011-06-10 Chong Yidong <cyd@stupidchicken.com>
7369
7370 * image.c (gif_load): Fix omitted cast error introduced by
7371 2011-06-06 change.
7372
2c8e37d4
MR
73732011-06-10 Martin Rudalics <rudalics@gmx.at>
7374
7375 * window.h (resize_proportionally, orig_total_lines)
7376 (orig_top_line): Remove from window structure.
7377 (set_window_height, set_window_width, change_window_heights)
7378 (Fdelete_window): Remove prototypes.
7379 (resize_frame_windows): Remove duplicate declaration.
7380
440a42e3
EZ
73812011-06-10 Eli Zaretskii <eliz@gnu.org>
7382
7383 * window.h (resize_frame_windows, resize_window_check)
7384 (delete_deletable_window, resize_root_window)
7385 (resize_frame_windows): Declare prototypes.
7386
7387 * window.c (resize_window_apply): Make definition be "static" to
7388 match the prototype.
7389
562dd5e9
MR
73902011-06-10 Martin Rudalics <rudalics@gmx.at>
7391
7392 * window.c: Remove declarations of Qwindow_size_fixed,
7393 window_min_size_1, window_min_size_2, window_min_size,
7394 size_window, window_fixed_size_p, enlarge_window, delete_window.
7395 Remove static from declaration of Qdelete_window, it's
7396 temporarily needed by Fbury_buffer.
7397 (replace_window): Don't assign orig_top_line and
7398 orig_total_lines.
7399 (Fdelete_window, delete_window): Remove. Window deletion is
7400 handled by window.el.
640c8776
SM
7401 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7402 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7403 (Fdelete_other_windows): Remove. Deleting other windows is
7404 handled by window.el.
7405 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7406 handled in window.el.
7407 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7408 Window minimum sizes are handled in window.el.
7409 (shrink_windows, size_window, set_window_height)
7410 (set_window_width, change_window_heights, window_height)
7411 (window_width, CURBEG, CURSIZE, enlarge_window)
7412 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7413 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7414 handled in window.el.
7415 (make_dummy_parent): Rename to make_parent_window and give it a
7416 second argument horflag.
7417 (make_window): Don't set resize_proportionally any more.
7418 (Fsplit_window): Remove. Windows are split in window.el.
7419 (save_restore_action, save_restore_orig_size)
7420 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7421 Resize mini windows in window.el.
7422 (grow_mini_window, shrink_mini_window): Implement by calling
7423 Qresize_root_window_vertically, resize_window_check and
7424 resize_window_apply.
640c8776
SM
7425 (saved_window, Fset_window_configuration, save_window_save):
7426 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7427 resize_proportionally.
7428 (window_min_height, window_min_width): Move to window.el.
7429 (keys_of_window): Move bindings for delete-other-windows,
7430 split-window, delete-window and enlarge-window to window.el.
7431
7432 * buffer.c: Temporarily extern Qdelete_window.
7433 (Fbury_buffer): Temporarily call Qdelete_window instead of
7434 Fdelete_window (Fbury_buffer will move to window.el soon).
7435
7436 * frame.c (set_menu_bar_lines_1): Remove code handling
7437 orig_top_line and orig_total_lines.
7438
7439 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7440 set_window_height but set heights directly.
7441 (change_frame_size_1): Use resize_frame_windows.
7442
7443 * xdisp.c (init_xdisp): Don't use set_window_height but set
7444 heights directly.
7445
640c8776
SM
7446 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7447 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7448 run_window_configuration_change_hook.
7449
7450 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7451 instead of change_window_heights and run
7452 run_window_configuration_change_hook.
7453
1a13852e
MR
74542011-06-09 Martin Rudalics <rudalics@gmx.at>
7455
7456 * window.c (replace_window): Rename second argument REPLACEMENT to
7457 NEW. New third argument SETFLAG. Rewrite.
7458 (delete_window, make_dummy_parent): Call replace_window with
7459 third argument 1.
7460 (window_list_1): Move down in code.
7461 (run_window_configuration_change_hook): Move set_buffer part
7462 before select_frame_norecord part in order to unwind correctly.
7463 Rename count1 to count.
7464 (recombine_windows, delete_deletable_window, resize_root_window)
7465 (Fdelete_other_windows_internal)
7466 (Frun_window_configuration_change_hook, make_parent_window)
7467 (resize_window_check, resize_window_apply, Fresize_window_apply)
7468 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7469 (Fdelete_window_internal, Fresize_mini_window_internal):
7470 New functions.
1a13852e
MR
7471 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7472
f3d1777e
MR
74732011-06-08 Martin Rudalics <rudalics@gmx.at>
7474
496e208e
MR
7475 * window.h (window): Add some new members to window structure -
7476 normal_lines, normal_cols, new_total, new_normal, clone_number,
7477 splits, nest, prev_buffers, next_buffers.
7478 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7479 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7480
f3d1777e
MR
7481 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7482 Remove.
496e208e
MR
7483 (make_dummy_parent): Set new members of windows structure.
7484 (make_window): Move down in code. Handle new members of window
7485 structure.
7486 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7487 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7488 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7489 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7490 (Fset_window_next_buffers, Fset_window_clone_number):
7491 New functions.
496e208e
MR
7492 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7493 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7494 Doc-string fixes.
7495 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7496 Argument WINDOW can be now internal window too.
7497 (Fwindow_use_time): Move up in code.
7498 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7499 Rewrite doc-string.
7500 (Fset_window_configuration, saved_window)
7501 (Fcurrent_window_configuration, save_window_save): Handle new
7502 members of window structure.
b9e809c2
MR
7503 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7504 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7505 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7506 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7507 Qget_mru_window, Qresize_root_window,
7508 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7509 Qauto_buffer_name; staticpro them.
f3d1777e 7510
abde8f8c
MR
75112011-06-07 Martin Rudalics <rudalics@gmx.at>
7512
7513 * window.c (Fwindow_total_size, Fwindow_left_column)
7514 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7515 (Fwindow_list_1): New functions.
7516 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7517 (Fwindow_width, Fscroll_left, Fscroll_right):
7518 Use window_body_cols instead of window_box_text_cols.
7519 (delete_window, Fset_window_configuration):
7520 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7521 (delete_all_subwindows): Take a window as argument and not a
7522 structure. Rewrite.
190b47e6
MR
7523 (window_loop): Remove handling of GET_LRU_WINDOW and
7524 GET_LARGEST_WINDOW.
7525 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7526
7527 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7528 window_box_text_cols. delete_all_subwindows now takes a
7529 Lisp_Object as argument.
abde8f8c 7530
640c8776
SM
7531 * indent.c (compute_motion, Fcompute_motion):
7532 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7533
fa8a67e6
MR
7534 * frame.c (delete_frame): Call delete_all_subwindows with root
7535 window as argument.
7536
a54e3482
DC
75372011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7538
7539 * fns.c (Fputhash): Document return value.
7540
60002bf5
CY
75412011-06-06 Chong Yidong <cyd@stupidchicken.com>
7542
7543 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7544
0c671da6 75452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7546
b862a52a 7547 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7548
be44ca6c
PE
7549 Check for overflow when converting integer to cons and back.
7550 * charset.c (Fdefine_charset_internal, Fdecode_char):
7551 Use cons_to_unsigned to catch overflow.
7552 (Fencode_char): Use INTEGER_TO_CONS.
7553 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7554 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7555 * data.c (long_to_cons, cons_to_long): Remove.
7556 (cons_to_unsigned, cons_to_signed): New functions.
7557 These signal an error for invalid or out-of-range values.
7558 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7559 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7560 * font.c (Ffont_variation_glyphs):
7561 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7562 * lisp.h: Include <intprops.h>.
7563 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7564 (cons_to_signed, cons_to_unsigned): New decls.
7565 (long_to_cons, cons_to_long): Remove decls.
7566 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7567 (Fprimitive_undo): Use CONS_TO_INTEGER.
7568 * xfns.c (Fx_window_property): Likewise.
7569 * xselect.c: Include <limits.h>.
7570 (x_own_selection, selection_data_to_lisp_data):
7571 Use INTEGER_TO_CONS.
7572 (x_handle_selection_request, x_handle_selection_clear)
7573 (x_get_foreign_selection, Fx_disown_selection_internal)
7574 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7575 (lisp_data_to_selection_data): Use cons_to_unsigned.
7576 (x_fill_property_data): Use cons_to_signed.
7577 Report values out of range.
7578
d1f3d2af
PE
7579 Check for buffer and string overflow more precisely.
7580 * buffer.h (BUF_BYTES_MAX): New macro.
7581 * lisp.h (STRING_BYTES_MAX): New macro.
7582 * alloc.c (Fmake_string):
7583 * character.c (string_escape_byte8):
7584 * coding.c (coding_alloc_by_realloc):
7585 * doprnt.c (doprnt):
7586 * editfns.c (Fformat):
7587 * eval.c (verror):
7588 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7589 since they may not be the same number.
7590 * editfns.c (Finsert_char):
7591 * fileio.c (Finsert_file_contents):
7592 Likewise for BUF_BYTES_MAX.
7593
dd52fcea
PE
7594 * image.c: Use ptrdiff_t, not int, for sizes.
7595 (slurp_file): Switch from int to ptrdiff_t.
7596 All uses changed.
7597 (slurp_file): Check that file size fits in both size_t (for
7598 malloc) and ptrdiff_t (for sanity and safety).
7599
7f9bbdbb
PE
7600 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7601 if b->modtime has its maximal value.
7602
dfe18f82
PE
7603 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7604
84acfcf0
PE
7605 Don't assume time_t can fit into int.
7606 * buffer.h (struct buffer.modtime): Now time_t, not int.
7607 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7608 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7609
ccd9a01a
PE
7610 Minor fixes for signed vs unsigned integers.
7611 * character.h (MAYBE_UNIFY_CHAR):
7612 * charset.c (maybe_unify_char):
7613 * keyboard.c (read_char, reorder_modifiers):
7614 XINT -> XFASTINT, since the integer must be nonnegative.
7615 * ftfont.c (ftfont_spec_pattern):
7616 * keymap.c (access_keymap, silly_event_symbol_error):
7617 XUINT -> XFASTINT, since the integer must be nonnegative.
7618 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7619 since it makes no difference and we prefer signed.
7620 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7621 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7622 nonnegative.
7623
d6d100dd
SM
76242011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7625
7626 * window.h (Fwindow_frame): Declare.
7627
2b6148e4
PE
76282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7629
7630 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7631 (SPARE_MEMORY): Always define.
7632 (LARGE_REQUEST): Remove.
7633 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7634
f230ecc9
MR
76352011-06-06 Martin Rudalics <rudalics@gmx.at>
7636
727e958e
MR
7637 * lisp.h: Move EXFUNS for Fframe_root_window,
7638 Fframe_first_window and Fset_frame_selected_window to window.h.
7639
7640 * window.h: Move EXFUNS for Fframe_root_window,
7641 Fframe_first_window and Fset_frame_selected_window here from
7642 lisp.h.
7643
7644 * frame.c (Fwindow_frame, Fframe_first_window)
7645 (Fframe_root_window, Fframe_selected_window)
7646 (Fset_frame_selected_window): Move to window.c.
7647 (Factive_minibuffer_window): Move to minibuf.c.
7648 (Fother_visible_frames_p): New function.
7649
7650 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7651
f230ecc9
MR
7652 * window.c (decode_window, decode_any_window): Move up in code.
7653 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7654 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7655 (Fwindow_buffer): Move up and rewrite doc-string.
7656 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7657 (Fwindow_prev): New functions.
727e958e
MR
7658 (Fwindow_frame): Move here from frame.c. Accept any window as
7659 argument.
7660 (Fframe_root_window, Fframe_first_window)
7661 (Fframe_selected_window): Move here from frame.c. Accept frame
7662 or arbitrary window as argument. Update doc-strings.
7663 (Fminibuffer_window): Move up in code.
7664 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7665 (Fset_frame_selected_window): Move here from frame.c.
7666 Marginal rewrite.
727e958e
MR
7667 (Fselected_window, select_window, Fselect_window): Move up in
7668 code. Minor doc-string fixes.
f230ecc9 7669
4d09bcf6
PE
76702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7671
7672 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7673 Do not assume that spare memory exists; that assumption is valid
7674 only if SYSTEM_MALLOC.
7675 (LARGE_REQUEST): New macro, so that the issue of large requests
7676 is separated from the issue of spare memory.
7677
810928a2
AS
76782011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7679
172418ad
AS
7680 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7681 format. (Bug#8806)
7682
43f862f7
AS
7683 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7684
810928a2
AS
7685 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7686 before statements.
7687
a059fe24
JD
76882011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7689
7690 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7691
7692 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7693
7694 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7695 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7696
989bf368
JB
76972011-06-05 Juanma Barranquero <lekktu@gmail.com>
7698
7699 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7700
4b80f674
CY
77012011-06-04 Chong Yidong <cyd@stupidchicken.com>
7702
7703 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7704 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7705 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7706 New error handlers.
4b80f674
CY
7707 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7708 Obey Vx_select_enable_clipboard_manager. Catch errors in
7709 x_clipboard_manager_save (Bug#8779).
7710 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7711 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7712
99a33b77 77132011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7714
7715 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7716
99a33b77 77172011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7718
7719 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7720 in the current matrix if keep_current_p is non-zero.
7721
8264569d
EZ
77222011-06-04 Eli Zaretskii <eliz@gnu.org>
7723
7724 * bidi.c (bidi_level_of_next_char): Fix last change.
7725
57f97249
EZ
77262011-06-03 Eli Zaretskii <eliz@gnu.org>
7727
fec2107c 7728 Support bidi reordering of text covered by display properties.
57f97249 7729
fec2107c
EZ
7730 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7731 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7732 (bidi_cache_search, bidi_cache_iterator_state)
7733 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7734 (bidi_level_of_next_char, bidi_move_to_visually_next):
7735 Support character positions inside a run of characters covered by a
fec2107c
EZ
7736 display string.
7737 (bidi_paragraph_init, bidi_resolve_explicit_1)
7738 (bidi_level_of_next_char): Call bidi_fetch_char and
7739 bidi_fetch_char_advance instead of FETCH_CHAR and
7740 FETCH_CHAR_ADVANCE.
7741 (bidi_init_it): Initialize new members.
7742 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7743 definitions.
7744 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7745 instead of using explicit *_CHAR codes.
d6d100dd
SM
7746 (bidi_resolve_explicit, bidi_resolve_weak):
7747 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7748 bidirectional text is supported only in multibyte buffers.
7749 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7750 it to initialize the frame_window_p member of struct bidi_it.
7751 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7752 (bidi_resolve_explicit, bidi_resolve_weak)
7753 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7754 bidi_it->nchars is non-positive.
7755 (bidi_level_of_next_char): Don't try to lookup the cache for the
7756 next/previous character if nothing is cached there yet, or if we
7757 were just reseat()'ed to a new position.
c40e2fb2 7758
0e14fe90
EZ
7759 * xdisp.c (set_cursor_from_row): Set start and stop points
7760 according to the row's direction when priming the loop that looks
7761 for the glyph on which to display cursor.
7762 (single_display_spec_intangible_p): Function deleted.
7763 (display_prop_intangible_p): Reimplement to call
7764 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7765 Accept 3 additional arguments needed by handle_display_spec.
7766 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7767 values: lists, `(when COND...)' forms, etc.
7768 (single_display_spec_string_p): Support property values that are
7769 lists with the argument STRING its top-level element.
7770 (display_prop_string_p): Fix the condition for processing a
7771 property that is a list to be consistent with handle_display_spec.
fec2107c 7772 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7773 last portion of handle_display_prop.
7774 (compute_display_string_pos): Accept additional argument
7775 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7776 value of a `display' property is a "replacing spec".
7777 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7778 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7779 the display property, but just return a value indicating whether
7780 the display property will replace the characters it covers.
7781 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7782 frame_window_p members of struct bidi_it.
d6d100dd
SM
7783 (compute_display_string_pos, compute_display_string_end):
7784 New functions.
fec2107c
EZ
7785 (push_it): Accept second argument POSITION, where pop_it should
7786 jump to continue iteration.
7787 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7788
fec2107c
EZ
7789 * keyboard.c (adjust_point_for_property): Adjust the call to
7790 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7791
7792 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7793 (bidi_init_it): Update prototypes.
7794 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7795 (compute_display_string_pos, compute_display_string_end):
7796 Declare prototypes.
fec2107c
EZ
7797 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7798 EMACS_INT.
fc6f18ce 7799
40087514 78002011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7801
57f53182
PE
7802 Malloc failure behavior now depends on size of allocation.
7803 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7804 * lisp.h: Change signatures accordingly.
7805 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7806 All callers changed. (Bug#8762)
7807
7808 * gnutls.c: Use Emacs's memory allocators.
7809 Without this change, the gnutls library would invoke malloc etc.
7810 directly, which causes problems on non-SYNC_INPUT hosts, and which
7811 runs afoul of improving memory_full behavior. (Bug#8761)
7812 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7813 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7814 xfree instead of the default malloc, realloc, free.
7815 (Fgnutls_boot): No need to check for memory allocation failure,
7816 since xmalloc does that for us.
7817
ac32cd99 7818 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7819 * category.c (hash_get_category_set):
7820 * ccl.c (ccl_driver):
7821 * charset.c (Fdefine_charset_internal):
7822 * charset.h (struct charset.hash_index):
7823 * composite.c (get_composition_id, gstring_lookup_cache)
7824 (composition_gstring_put_cache):
7825 * composite.h (struct composition.hash_index):
7826 * dispextern.h (struct image.hash):
7827 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7828 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7829 (hashfn_equal, hashfn_user_defined, make_hash_table)
7830 (maybe_resize_hash_table, hash_lookup, hash_put)
7831 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7832 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7833 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7834 * image.c (make_image, search_image_cache, lookup_image)
7835 (xpm_put_color_table_h):
7836 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7837 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7838 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7839 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7840 * alloc.c (allocate_vectorlike):
7841 Check for overflow in vector size calculations.
7842 * ccl.c (ccl_driver):
7843 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7844 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7845 need to be updated by these changes.
40087514
PE
7846 * fns.c (make_hash_table, maybe_resize_hash_table):
7847 Check for integer overflow with large hash tables.
0de4bb68
PE
7848 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7849 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7850 (SXHASH_REDUCE): New macro.
7851 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7852 Use it instead of discarding useful hash info with large hash values.
7853 (sxhash_float): New function.
7854 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7855 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7856 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7857 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7858 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7859 Adjust signatures to match updated version of code.
7860 (consing_since_gc): Now EMACS_INT, since a single hash table can
7861 use more than INT_MAX bytes.
7862
698d32e2
DN
78632011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7864
7865 Make it possible to build with GCC-4.6+ -O2 -flto.
7866
7867 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7868
fd6fa53f
SM
78692011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7870
7871 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7872 Call minibuffer-inactive-mode.
7873
864db017
JB
78742011-05-31 Juanma Barranquero <lekktu@gmail.com>
7875
7876 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7877 Update dependencies.
7878
2ad0baf4
DN
78792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7880
7881 * data.c (init_data): Remove code for UTS, this system is not
7882 supported anymore.
7883
4fcc2638
DN
78842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7885
7886 Don't force ./temacs to start in terminal mode.
7887
7888 * frame.c (make_initial_frame): Initialize faces in all cases, not
7889 only when CANNOT_DUMP is defined.
7890 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7891
c56e0fd5
DN
78922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7893
7894 * dispnew.c (add_window_display_history): Use const for the string
7895 pointer. Remove declaration, not needed.
7896
333d54da 78972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7898
55d4c1b2 7899 Use 'inline', not 'INLINE'.
333d54da 7900 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7901 * alloc.c, fontset.c (INLINE): Remove.
7902 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7903 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7904 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7905 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7906 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7907
738db178
DN
79082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7909
7910 Make it possible to run ./temacs.
7911
7912 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7913 syms_of_callproc does the same thing. Remove test for
7914 "initialized", do it in the caller.
7915 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7916
620c53a6
SM
79172011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7918
7919 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7920 (read_minibuf): Use get_minibuffer.
7921 (syms_of_minibuf): Use DEFSYM.
7922 (Qmetadata): New var.
7923 * data.c (Qbuffer): Don't make it static.
7924 (syms_of_data): Use DEFSYM.
7925
e003a292
PE
79262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7927
7928 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7929 (CCL_CODE_MIN): New macro.
7930
ed008a6d
PE
79312011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7932
3687c2ef
PE
7933 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7934
ed008a6d
PE
7935 * eval.c (Qdebug): Now static.
7936 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7937 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7938 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7939
d66c4c7c
CY
79402011-05-29 Chong Yidong <cyd@stupidchicken.com>
7941
7942 * image.c: Various fixes to ImageMagick code comments.
7943 (Fimagemagick_types): Doc fix.
7944
5fbc2025
PE
79452011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7946
0196f88a
PE
7947 Minor fixes prompted by GCC 4.6.0 warnings.
7948
7949 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7950
5fbc2025
PE
7951 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7952 (x_clipboard_manager_save_all): Move extern decl to ...
7953 * xterm.h: ... here, so that it can be checked for consistency.
7954
1dd3c2d9
CY
79552011-05-29 Chong Yidong <cyd@stupidchicken.com>
7956
7957 * xselect.c (x_clipboard_manager_save_frame)
7958 (x_clipboard_manager_save_all): New functions.
7959 (Fx_clipboard_manager_save): Lisp function deleted.
7960
7961 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7962 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7963
7964 * xterm.h: Update prototype.
7965
5ba6571d
WX
79662011-05-28 William Xu <william.xwl@gmail.com>
7967
7968 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7969 exiting (Bug#8239).
7970
3eaff834
JM
79712011-05-28 Jim Meyering <meyering@redhat.com>
7972
e1900994 7973 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7974 * fns.c (to_uchar): Define.
7975 (crypto_hash_function): Use it to convert some newly-signed
7976 variables to unsigned, to avoid sign-extension bugs. For example,
7977 without this change, (md5 "truc") would evaluate to
7978 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7979 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7980 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7981
0f6990a7
PE
79822011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7983
7984 Integer overflow fixes.
c8a9ca5a 7985
08686060
PE
7986 * dbusbind.c: Serial number integer overflow fixes.
7987 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7988 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7989 to hold a serial number that is too large for a fixnum.
7990 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7991 Check for serial numbers out of range. Decode any serial number
59568bf0 7992 that was so large that it became a float. (Bug#8722)
08686060 7993
2d1fc3c7
PE
7994 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7995 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7996 Use XFASTINT rather than XUINT when numbers are nonnegative.
7997 (xd_append_arg, Fdbus_method_return_internal):
7998 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7999 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8000 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8001 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8002 (Bug#8722)
2d1fc3c7 8003
c8a9ca5a
PE
8004 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8005
519e1d69
PE
8006 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8007
6df6ae42 8008 ccl: Add integer overflow checks.
30569699
PE
8009 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8010 (IN_INT_RANGE): New macros.
8011 (ccl_driver): Use them to check for integer overflow when
8012 decoding a CCL program. Many of the new checks are whether XINT (x)
8013 fits in int; it doesn't always, on 64-bit hosts. The new version
8014 doesn't catch all possible integer overflows, but it's an
847044ea 8015 improvement. (Bug#8719)
30569699 8016
c11285dc
PE
8017 * alloc.c (make_event_array): Use XINT, not XUINT.
8018 There's no need for unsigned here.
8019
fdccd48e
PE
8020 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8021 This follows up to the 2011-05-06 change that substituted uintptr_t
8022 for EMACS_INT. This case wasn't caught back then.
8023
37910ab2
PE
8024 Rework Fformat to avoid integer overflow issues.
8025 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8026 now (part of C89). Include <verify.h>.
8027 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8028 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8029 (Fformat): Avoid the prepass trying to compute sizes; it was only
8030 approximate and thus did not catch overflow reliably. Instead, walk
8031 through the format just once, formatting and computing sizes as we go,
8032 checking for integer overflow at every step, and allocating a larger
8033 buffer as needed. Keep track separately whether the format is
8034 multibyte. Keep only the most-recently calculated precision, rather
8035 than them all. Record whether each argument has been converted to
8036 string. Use EMACS_INT, not int, for byte and char and arg counts.
8037 Support field widths and precisions larger than INT_MAX. Avoid
8038 sprintf's undefined behavior with conversion specifications such as %#d
8039 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8040 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8041 formatting out-of-range floating point numbers with int
9173deec 8042 formats. (Bug#8668)
37910ab2 8043
2e6578fb
PE
8044 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8045
0ae6bdee
PE
8046 * data.c: Avoid integer truncation in expressions involving floats.
8047 * data.c: Include <intprops.h>.
8048 (arith_driver): When there's an integer overflow in an expression
8049 involving floating point, convert the integers to floating point
8050 so that the resulting value does not suffer from catastrophic
8051 integer truncation. For example, on a 64-bit host (* 4
8052 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8053 Do not rely on undefined behavior after integer overflow.
8054
de883a70
PE
8055 merge count_size_as_multibyte, parse_str_to_multibyte
8056 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8057 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8058 Check for integer overflow.
8059 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8060 since it's now a duplicate of the other. This is more of
8061 a character than a buffer op, so better that it's in character.c.
8062 * fns.c, print.c: Adjust to above changes.
8063
2ff916cb
PE
80642011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8065
8066 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8067
f1b54466
PE
80682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8069
fb1ac845
PE
8070 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8071 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8072 (x_clipboard_manager_save): Now static.
8073 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8074
f1b54466
PE
8075 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8076 (crypto_hash_function): Now static.
8077 Fix pointer signedness problems. Avoid unnecessary initializations.
8078
a9f737ee
CY
80792011-05-27 Chong Yidong <cyd@stupidchicken.com>
8080
8081 * termhooks.h (Vselection_alist): Make it terminal-local.
8082
8083 * terminal.c (create_terminal): Initialize it.
8084
8085 * xselect.c: Support for clipboard managers.
8086 (Vselection_alist): Move to termhooks.h as terminal-local var.
8087 (LOCAL_SELECTION): New macro.
8088 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8089 (symbol_to_x_atom): Remove gratuitous arg.
8090 (x_handle_selection_request, lisp_data_to_selection_data)
8091 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8092 (x_own_selection, x_get_local_selection, x_convert_selection):
8093 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8094 (some_frame_on_display): Delete unused function.
8095 (Fx_own_selection_internal, Fx_get_selection_internal)
8096 (Fx_disown_selection_internal, Fx_selection_owner_p)
8097 (Fx_selection_exists_p): New optional frame arg.
8098 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8099 (x_handle_selection_clear): Don't treat other terminals with the
8100 same keyboard specially. Use the terminal-local Vselection_alist.
8101 (x_clear_frame_selections): Use Frun_hook_with_args.
8102
8103 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8104
8105 * xterm.h: Add support for those atoms.
8106
e067f0c1
CY
81072011-05-26 Chong Yidong <cyd@stupidchicken.com>
8108
8109 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8110 (converted_selections, conversion_fail_tag): New global variables.
8111 (x_selection_request_lisp_error): Free the above.
8112 (x_get_local_selection): Remove unnecessary code.
8113 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8114 of converted selections stored in converted_selections.
8115 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8116 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8117 (x_convert_selection): New function.
8118 (x_handle_selection_event): Simplify.
8119 (x_get_foreign_selection): Don't ignore incoming requests while
8120 waiting for an answer; this will fail when we implement
8121 SAVE_TARGETS, and seems unnecessary anyway.
8122 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8123 (Vx_sent_selection_functions): Doc fix.
8124
0f4aebc0
LL
81252011-05-26 Leo Liu <sdl.web@gmail.com>
8126
8127 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8128
e61124cd
YM
81292011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8130
8131 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8132
8133 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8134 for fringe update if it has periodic bitmap.
ac389d0c 8135 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8136 and fringe_bitmap_periodic_p.
8137
8138 * fringe.c (get_fringe_bitmap_data): New function.
8139 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8140 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8141 row. Mark glyph row for fringe update if periodicity changed.
8142
8143 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8144 for fringe update unless it has periodic bitmap.
8145
f16d9837
KH
81462011-05-25 Kenichi Handa <handa@m17n.org>
8147
8148 * xdisp.c (get_next_display_element): Set correct it->face_id for
8149 a static composition.
8150
e1b90ef6
LL
81512011-05-24 Leo Liu <sdl.web@gmail.com>
8152
8153 * deps.mk (fns.o):
8154 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8155
8156 * fns.c (crypto_hash_function, Fsha1): New function.
8157 (Fmd5): Use crypto_hash_function.
8158 (syms_of_fns): Add Ssha1.
8159
7400048f
PE
81602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8161
8162 * gnutls.c: Remove unused macros.
8163 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8164 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8165 Remove macros that are defined and never used.
8166 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8167
abb71cf4
CY
81682011-05-22 Chong Yidong <cyd@stupidchicken.com>
8169
8170 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8171 (Fx_get_selection_internal): Minor cleanup.
8172 (Fx_own_selection_internal): Rename arguments for consistency with
8173 select.el.
8174
6307db39
PE
81752011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8176
8177 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8178
f3d4e0a4
CY
81792011-05-22 Chong Yidong <cyd@stupidchicken.com>
8180
8181 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8182
4d8ade89
YM
81832011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8184
8185 * dispnew.c (scrolling_window): Don't exclude the case that the
8186 last enabled row in the desired matrix touches the bottom boundary.
8187
32078c8d
GM
81882011-05-21 Glenn Morris <rgm@gnu.org>
8189
8190 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8191 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8192 and add some more files.
32078c8d 8193
7285dc67
EZ
81942011-05-20 Eli Zaretskii <eliz@gnu.org>
8195
8196 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8197 report_file_error introduced by the change from 2011-05-07.
8198
89d1bd22
PE
81992011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8200
8201 * systime.h (Time): Define only if emacs is defined.
8202 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8203 where the include path doesn't have X11/X.h by default. See
8204 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8205
cd394be1 82062011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8207
8208 * composite.c (find_automatic_composition): Fix previous change.
8209
b9704ad9
GM
82102011-05-20 Glenn Morris <rgm@gnu.org>
8211
8212 * lisp.mk: New file, split from Makefile.in.
8213 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8214 (shortlisp): Remove.
8215 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8216
4a720484
GM
82172011-05-19 Glenn Morris <rgm@gnu.org>
8218
8219 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8220 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8221 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8222 (lisp): Set the order to that of loadup.el.
8223 (shortlisp): Make it a copy of $lisp.
8224 (SOME_MACHINE_LISP): Remove.
8225 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8226 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8227
a28d4396
KH
82282011-05-18 Kenichi Handa <handa@m17n.org>
8229
8230 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8231 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8232 (find_automatic_composition): Mostly rewrite for efficiency.
8233
a2b1fa8e
JB
82342011-05-18 Juanma Barranquero <lekktu@gmail.com>
8235
8236 * makefile.w32-in: Update dependencies.
8237
8e1f5610
CS
82382011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8239
8240 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8241 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8242
7025ee00 82432011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8244
cdfa6eab
PE
8245 Fix some integer overflow issues, such as string length overflow.
8246
06d6db33
PE
8247 * insdel.c (count_size_as_multibyte): Check for string overflow.
8248
2b4560a8
PE
8249 * character.c (lisp_string_width): Check for string overflow.
8250 Use EMACS_INT, not int, for string indexes and lengths; in
8251 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8252 the resulting string length overflows an EMACS_INT; instead,
8253 report a string overflow if no precision given. When checking for
8254 precision exhaustion, use a check that cannot possibly have
8255 integer overflow. (Bug#8675)
8256 * character.h (lisp_string_width): Adjust to new signature.
8257
cb93f9be
PE
8258 * alloc.c (string_overflow): New function.
8259 (Fmake_string): Use it. This doesn't change behavior, but saves
8260 a few bytes and will simplify future changes.
8261 * character.c (string_escape_byte8): Likewise.
8262 * lisp.h (string_overflow): New decl.
8263
1a1f3366
PE
8264 Fixups, following up to the user-interface timestamp change.
8265 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8266 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8267 * msdos.c (mouse_get_pos): Likewise.
8268 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8269 * w32gui.h (Time): Define by including "systime.h" rather than by
8270 declaring it ourselves. (Bug#8664)
8271
d4e3e4d3
PE
8272 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8273 * image.c (clear_image_cache): Likewise.
8274
f6a24d19
PE
8275 * term.c (term_mouse_position): Don't assume time_t wraparound.
8276
08dc5ae6
PE
8277 Be more systematic about user-interface timestamps.
8278 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8279 and sometimes 'EMACS_UINT', to represent these timestamps.
8280 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8281 This makes the code easier to follow, and makes it easier to catch
8282 integer overflow bugs such as Bug#8664.
8283 * frame.c (Fmouse_position, Fmouse_pixel_position):
8284 Use Time, not unsigned long, for user-interface timestamps.
8285 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8286 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8287 * keyboard.h (last_event_timestamp): Likewise.
8288 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8289 * menu.h (xmenu_show): Likewise.
8290 * term.c (term_mouse_position): Likewise.
8291 * termhooks.h (struct input_event.timestamp): Likewise.
8292 (struct terminal.mouse_position_hook): Likewise.
8293 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8294 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8295 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8296 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8297 what it was before.
8298 * menu.h, termhooks.h: Include "systime.h", for Time.
8299
8e55734a
PE
8300 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8301 Don't assume that the difference between two unsigned long values
8302 can fit into an integer. At this point, we know button_down_time
8303 <= event->timestamp, so the difference must be nonnegative, so
8304 there's no need to cast the result if double-click-time is
8305 nonnegative, as it should be; check that it's nonnegative, just in
8306 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8307 apart (about 25 days). (Bug#8664)
8e55734a 8308
841f1b75 8309 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8310 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8311
3e26f69c
PE
8312 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8313 that always fit in int. Use a sentinel instead of a counter, to
8314 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8315 * frame.h (struct frame): Use int for menu_bar_items_used
8316 instead of EMACS_INT, since it always fits in int.
3e26f69c 8317
5cc152c0
PE
8318 * menu.c (grow_menu_items): Check for int overflow.
8319
d89eb65e
PE
8320 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8321
5235bd3e
PE
8322 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8323 Before, the code was not consistent. These values cannot exceed
8324 2**31 - 1 so there's no need to make them unsigned.
8325 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8326 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8327 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8328 as modifiers.
8329 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8330
bc827e23
PE
8331 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8332 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8333 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8334 presumably because the widths might not match.
8335
78eb494e
PE
8336 * window.c (size_window): Avoid needless test at loop start.
8337
04f2d78b
CB
83382011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8339
8340 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8341
d2fc7e3d 83422011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8343
8344 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8345
d2fc7e3d 83462011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8347
8348 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8349 `width' to `bar_area_x' and `bar_area_width', respectively.
8350 (x_scroll_run): Take account of fringe background extension.
8351
04f2d78b
CB
8352 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8353 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8354 `bar_area_width', respectively.
8355 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8356 background extension.
8357
79b70037
GM
83582011-05-10 Jim Meyering <meyering@redhat.com>
8359
8360 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8361
2f142cc5
JB
83622011-05-10 Juanma Barranquero <lekktu@gmail.com>
8363
8364 * image.c (Finit_image_library): Return t for built-in image types,
8365 like pbm and xbm. (Bug#8640)
8366
57679c86
AS
83672011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8368
8369 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8370
888c9e86
EZ
83712011-05-07 Eli Zaretskii <eliz@gnu.org>
8372
b0512a1d
EZ
8373 * w32console.c (Fset_screen_color): Doc fix.
8374 (Fget_screen_color): New function.
8375 (syms_of_ntterm): Defsubr it.
8376
7285dc67
EZ
8377 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8378 unlink the temporary file if Fcall_process didn't create it in the
8379 first place.
8380 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8381 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8382 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8383 cue to call_process_cleanup not to close that handle.
8384
4d3fcc8e
BK
83852011-05-07 Ben Key <bkey76@gmail.com>
8386
8387 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8388 one of two shell specific rules, either bootstrap-temacs-CMD or
8389 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8390 to the previous implementation of the bootstrap-temacs rule.
8391 The bootstrap-temacs-CMD rule is similar to the previous
8392 implementation of the bootstrap-temacs rule except that it
8393 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8394 variable.
8395
8396 These changes, along with some changes to nt/configure.bat,
8397 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8398 earlier fix to add support for --cflags and --ldflags options
8399 that include quotes so that it works whether make uses cmd or
8400 sh as the shell.
8401
b4289b64
MA
84022011-05-06 Michael Albinus <michael.albinus@gmx.de>
8403
8404 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8405 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8406 is a constant.
8407 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8408 a string. Handle both cases.
8409 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8410 (Fdbus_register_method): Use Qinvalid_function.
8411
af4c0e28
JB
84122011-05-06 Juanma Barranquero <lekktu@gmail.com>
8413
8414 * makefile.w32-in: Update dependencies.
8415 (LISP_H): Add inttypes.h and stdin.h.
8416 (PROCESS_H): Add unistd.h.
8417
c51453d9
EZ
84182011-05-06 Eli Zaretskii <eliz@gnu.org>
8419
8420 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8421 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8422
8ff0ac3c 84232011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8424
4c4b566b
PE
8425 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8426
aab2b9b5
PE
8427 * term.c (vfatal): Remove stray call to va_end.
8428 It's not needed and the C Standard doesn't allow it here anyway.
8429
c378da0b
PE
8430 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8431 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8432
288b08c7
PE
8433 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8434 bytes.
8435
e3601888
PE
8436 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8437
db6c0e74
PE
8438 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8439
dd5963ea
PE
8440 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8441
88c9450f
PE
8442 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8443
2f9442b8
PE
8444 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8445
c032b5f8
PE
8446 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8447 * charset.c (Fdefine_charset_internal): Don't initialize
8448 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8449 32-bit int (Bug#8600).
a108c10b
PE
8450
8451 * lread.c (read_integer): Be more consistent with string-to-number.
8452 Use string_to_number to do the actual conversion; this avoids
8453 rounding errors and fixes some other screwups. Without this fix,
8454 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8455 (digit_to_number): Move earlier, for benefit of read_integer.
8456 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8457 not a digit in any supported base. (Bug#8602)
a108c10b 8458
ad5f9eea
PE
8459 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8460
aec1708a
PE
8461 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8462 to match comment at start of function. This also removes a
8463 GCC warning about overflow in a 32+64-bit port.
8464
47be4ab5
PE
8465 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8466
371cac43
PE
8467 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8468 Reported by Stefan Monnier in
8469 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8470 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8471 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8472
d01a7826
PE
8473 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8474 (EMACS_UINTPTR): Likewise, with uintptr_t.
8475
7fd47d5c
PE
8476 * lisp.h: Prefer 64-bit EMACS_INT if available.
8477 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8478 on 32-bit hosts that have 64-bit int, so that they can access
8479 large files.
122b0c86
PE
8480 However, temporarily disable this change unless the temporary
8481 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8482
8727937b
PE
8483 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8484
8ac068ac
PE
8485 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8486 This removes an assumption that EMACS_INT and long are the same
8487 width as pointers. The assumption is true for Emacs porting targets
8488 now, but we want to make other targets possible.
8489 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8490 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8491 In the rest of the code, change types of integers that hold casted
8492 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8493 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8494 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8495 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8496 No need to cast type when ORing.
8497 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8498 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8499 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8500 assume EMACS_INT is the same width as char *.
8501 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8502 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8503 Remove no-longer-needed casts.
8504 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8505 (xg_tool_bar_help_callback, xg_make_tool_item):
8506 Use EMACS_INTPTR to hold an integer
8507 that will be cast to void *; this can avoid a GCC warning
8508 if EMACS_INT is not the same width as void *.
8509 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8510 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8511 (current_message_1, set_message_1):
8512 Use a local to convert to proper width without a cast.
8513 * xmenu.c (dialog_selection_callback): Likewise.
8514
ede49d71
PE
8515 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8516 Also, don't assume VALBITS / RAND_BITS is less than 5,
8517 and don't rely on undefined behavior when shifting a 1 left into
8518 the sign bit.
8519 * lisp.h (get_random): Change signature to match.
8520
2f30ecd0
PE
8521 * lread.c (hash_string): Use size_t, not int, for hash computation.
8522 Normally we prefer signed values; but hashing is special, because
8523 it's better to use unsigned division on hash table sizes so that
8524 the remainder is nonnegative. Also, size_t is the natural width
8525 for hashing into memory. The previous code used 'int', which doesn't
8526 retain enough info to hash well into very large tables.
8527 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8528
2a866e7b
PE
8529 * dbusbind.c: Don't possibly lose pointer info when converting.
8530 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8531 Use XPNTR rather than XHASH, so that the high-order bits of
8532 the pointer aren't lost when converting through void *.
8533
51639eac
PE
8534 * eval.c (Fautoload): Don't double-shift a pointer.
8535
92394119
PE
8536 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8537
dbdb9a7c
JB
85382011-05-06 Juanma Barranquero <lekktu@gmail.com>
8539
8540 * gnutls.c (DEF_GNUTLS_FN):
8541 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8542
db7a0b4f
AS
85432011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8544
8545 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8546 marker. (Bug#8610)
8547
cd394be1 85482011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8549
8550 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8551 New version that can reserve upto 2GB of heap space.
8552
f7ff1b0f 85532011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8554
8555 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8556
639c109b
TZ
85572011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8558
8559 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8560 `gnutls_certificate_set_x509_key_file'.
8561
d2127135
JB
85622011-05-05 Juanma Barranquero <lekktu@gmail.com>
8563
8564 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8565 Update dependencies.
8566
e968f4f3
JB
85672011-05-04 Juanma Barranquero <lekktu@gmail.com>
8568
8569 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8570 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8571 Remove unused parameter `fildes'.
8572 * process.c (read_process_output, send_process): Don't pass it.
8573
84d358f0
JB
85742011-05-04 Juanma Barranquero <lekktu@gmail.com>
8575
8576 Fix previous change: the library cache is defined in w32.c.
8577 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8578 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8579
0898ca10
JB
85802011-05-04 Juanma Barranquero <lekktu@gmail.com>
8581
8582 Implement dynamic loading of GnuTLS on Windows.
8583
8584 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8585 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8586 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8587 Declare.
8588
8589 * gnutls.c (Qgnutls_dll): Define.
8590 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8591 (gnutls_*): Declare function pointers.
8592 (init_gnutls_functions): New function to initialize function pointers.
8593 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8594 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8595 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8596 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8597 (emacs_gnutls_write, emacs_gnutls_read)
8598 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8599 (Fgnutls_available_p): New function.
8600 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8601 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8602 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8603
8604 * image.c: Include w32.h.
8605 (Vimage_type_cache): Delete.
8606 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8607 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8608 (w32_delayed_load): Move to w32.c.
8609
8610 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8611
8612 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8613 (w32_delayed_load): Move from image.c. When loading a library, record
8614 its filename in the :loaded-from property of the library id.
8615 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8616 Initialize and staticpro them.
8617 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8618
8619 * process.c: Include lisp.h before w32.h, not after.
8620 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8621 instead of gnutls_record_check_pending.
8622
8623 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8624
ff4de4aa
TZ
86252011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8626
8627 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8628 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8629 as passed in.
8630
abe95abb
JD
86312011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8632
8633 * xterm.c (x_set_frame_alpha): Do not set property on anything
8634 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8635
e16e55d4
JB
86362011-05-02 Juanma Barranquero <lekktu@gmail.com>
8637
8638 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8639
bafcf6a5
JB
86402011-05-02 Juanma Barranquero <lekktu@gmail.com>
8641
8642 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8643 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8644 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8645 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8646 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8647 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8648 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8649 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8650 (Qgnutls_bootprop_callbacks_verify): Make static.
8651
e7a6747f
AS
86522011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8653
19ed11ba
AS
8654 * callproc.c: Indentation fixup.
8655
e7a6747f 8656 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8657 (wait_for_termination, interruptible_wait_for_termination):
8658 Move after wait_for_termination_1.
e7a6747f 8659
1ef14cb4
LMI
86602011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8661
8662 * sysdep.c (interruptible_wait_for_termination): New function
8663 which is like wait_for_termination, but allows keyboard
8664 interruptions.
8665
8666 * callproc.c (Fcall_process): Add (:file "file") as an option for
8667 the STDOUT buffer.
8668 (Fcall_process_region): Ditto.
8669
330d880c
EZ
86702011-04-30 Eli Zaretskii <eliz@gnu.org>
8671
8db90b73
EZ
8672 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8673 rather than `XVECTOR (FOO)->size'.
8674
330d880c
EZ
8675 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8676 inttypes.h, as a gnulib replacement is used if it not available in
8677 system headers.
8678
15cbd324
EZ
86792011-04-21 Eli Zaretskii <eliz@gnu.org>
8680
8681 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8682 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8683 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8684
8685 * coding.c (coding_alloc_by_realloc): Error out if destination
8686 will grow beyond MOST_POSITIVE_FIXNUM.
8687 (decode_coding_emacs_mule): Abort if there isn't enough place in
8688 charbuf for the composition carryover bytes. Reserve an extra
8689 space for up to 2 characters produced in a loop.
8690 (decode_coding_iso_2022): Abort if there isn't enough place in
8691 charbuf for the composition carryover bytes.
8692
86932011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8694
ae940cca
EZ
8695 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8696 aborting when %lld or %lll format is passed.
8697 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8698 %llo or %llx format is passed. (Bug#8545)
8699
03ab8921
EZ
8700 * window.c (window_scroll_line_based): Use a marker instead of
8701 simple variables to record original value of point. (Bug#7952)
8702
afda1437
EZ
8703 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8704 produced by %s or %c overflows available buffer space. (Bug#8545)
8705
f76dee0c
PE
87062011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8707
8708 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8709 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8710
fdc5744d
JB
87112011-04-28 Juanma Barranquero <lekktu@gmail.com>
8712
8713 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8714
638f053a
JB
87152011-04-28 Juanma Barranquero <lekktu@gmail.com>
8716
8717 * keyboard.c (Qdelayed_warnings_hook): Define.
8718 (command_loop_1): Run `delayed-warnings-hook'
8719 if Vdelayed_warnings_list is non-nil.
8720 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8721 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8722
d178f871
EZ
87232011-04-28 Eli Zaretskii <eliz@gnu.org>
8724
8725 * doprnt.c (doprnt): Don't return value smaller than the buffer
8726 size if the message was truncated. (Bug#8545).
8727
b124fd93
JB
87282011-04-28 Juanma Barranquero <lekktu@gmail.com>
8729
8730 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8731 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8732
e810457d
PE
87332011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8734
8735 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8736
ea51cceb
JB
87372011-04-27 Juanma Barranquero <lekktu@gmail.com>
8738
8739 * makefile.w32-in: Update dependencies.
8740
94dcfacf
EZ
87412011-04-27 Eli Zaretskii <eliz@gnu.org>
8742
8743 Improve `doprnt' and its usage. (Bug#8545)
8744 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8745 `format_end'. Remove support for %l as a conversion specifier.
8746 Don't use xrealloc. Improve diagnostics when the %l size modifier
8747 is used. Update the commentary.
8748
8749 * eval.c (verror): Simplify calculation of size_t.
8750
8751 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8752 messages.
8753
f61f41d7
PE
87542011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8755
8756 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8757 change.
8758
96fb4434
PE
87592011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8760
8761 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8762 This makes this file independent of the recent pseudovector change.
8763
671875da 87642011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8765
69e9b5a3
PE
8766 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8767
b5f869a7 8768 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8769 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8770 Remove unused local.
c8926152 8771 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8772
841a1577 8773 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8774 GCC 4.6.0 optimizes based on type-based alias analysis.
8775 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8776 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8777 != &v->size, and therefore "v->size = 1; b->size = 2; return
8778 v->size;" must therefore return 1. This assumption is incorrect
8779 for Emacs, since it type-puns struct Lisp_Vector * with many other
8780 types. To fix this problem, this patch adds a new type struct
f904488f 8781 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8782 and pseudovectors, and helps optimizing compilers not get fooled
8783 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8784 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8785 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8786 the size member.
eab3844f
PE
8787 (XSETPVECTYPE): Rewrite in terms of new macro.
8788 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8789 This is a bit clearer, and further avoids the possibility of
8790 undesirable aliasing.
8791 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8792 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8793 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8794 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8795 (ASIZE): Now uses header.size rather than size.
8796 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8797 to avoid the hassle of writing XVECTOR (foo)->header.size.
8798 (struct vectorlike_header): New type.
eab3844f
PE
8799 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8800 object, to help avoid aliasing.
8801 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8802 (SUBRP): Likewise, since Lisp_Subr is a special case.
8803 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8804 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8805 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8806 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8807 changed to be "header.size" and "header.next".
8808 * buffer.h (struct buffer): Likewise.
8809 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8810 * frame.h (struct frame): Likewise.
8811 * process.h (struct Lisp_Process): Likewise.
8812 * termhooks.h (struct terminal): Likewise.
8813 * window.c (struct save_window_data, struct saved_window): Likewise.
8814 * window.h (struct window): Likewise.
8815 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8816 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8817 * buffer.c (init_buffer_once): Likewise.
8818 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8819 special case.
8820 * process.c (Fformat_network_address): Use local var for size,
8821 for brevity.
8822
0df1eac5
PE
8823 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8824
847ab9d1 8825 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8826 * data.c (atof): Remove decl; no longer used or needed.
8827 (digit_to_number): Move to lread.c.
8828 (Fstring_to_number): Use new string_to_number function, to be
8829 consistent with how the Lisp reader treats infinities and NaNs.
8830 Do not assume that floating-point numbers represent EMACS_INT
8831 without losing information; this is not true on most 64-bit hosts.
8832 Avoid double-rounding errors, by insisting on integers when
8833 parsing non-base-10 numbers, as the documentation specifies.
8834 * lisp.h (string_to_number): New decl, replacing ...
8835 (isfloat_string): Remove.
bc0a5c13 8836 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8837 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8838 appears to have been a coding error. Similarly, do not accept
8839 strings like +-1e0 as floating point numbers. Do not report
8840 overflow for integer overflows unless the base is not 10 which
8841 means we have no simple and reliable way to continue.
8842 Break out the floating-point parsing into a new
8843 function string_to_number, so that Fstring_to_number parses
8844 floating point numbers consistently with the Lisp reader.
04f2d78b 8845 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8846 (E_CHAR, EXP_INT): Remove, replacing with ...
8847 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8848 (string_to_number): New function, replacing isfloat_string.
8849 This function checks for valid syntax and produces the resulting
8850 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8851 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8852 so that overflow for non-base-10 numbers is reported only when
8853 there's no portable and simple way to convert to floating point.
452f4150 8854
67769ffc
PE
8855 * textprop.c (set_text_properties_1): Rewrite for clarity,
8856 and to avoid GCC warning about integer overflow.
8857
c20db43f
PE
8858 * intervals.h (struct interval): Use EMACS_INT for members
8859 where EMACS_UINT might cause problems. See
8860 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8861 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8862 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8863 All uses changed.
37aa2f85
PE
8864 (offset_intervals): Tell GCC not to worry about length overflow
8865 when negating a negative length.
c20db43f 8866
2538aa2f
PE
8867 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8868 (overrun_check_free): Likewise.
8869
f2d3008d
PE
8870 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8871 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8872 word size.
8873
ec8df744
PE
8874 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8875 (gnutls_make_error): Rename local to avoid shadowing.
8876 (gnutls_emacs_global_deinit): ifdef out; not used.
8877 (Fgnutls_boot): Use const for pointer to readonly storage.
8878 Comment out unused local. Fix pointer signedness problems.
8879
640ee02d
PE
8880 * lread.c (openp): Don't stuff size_t into an 'int'.
8881 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8882 about possible signed overflow.
8883
6048fb2a
PE
8884 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8885 (GDK_KEY_g): Don't define if already defined.
8886 (xg_prepare_tooltip): Avoid pointer signedness problem.
8887 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8888
fa3c87e1
PE
8889 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8890 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8891
2172544b
PE
8892 * xfns.c (Fx_window_property): Simplify a bit,
8893 to make a bit faster and to avoid GCC 4.6.0 warning.
8894 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8895
9b821a21
PE
8896 * fns.c (internal_equal): Don't assume size_t fits in int.
8897
3c616cfa
PE
8898 * alloc.c (compact_small_strings): Tighten assertion a little.
8899
c2982e87
PE
8900 Replace pEd with more-general pI, and fix some printf arg casts.
8901 * lisp.h (pI): New macro, generalizing old pEd macro to other
8902 conversion specifiers. For example, use "...%"pI"d..." rather
8903 than "...%"pEd"...".
8904 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8905 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8906 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8907 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8908 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8909 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8910 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8911 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8912 64-bit hosts.
8913 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8914 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8915 * print.c (safe_debug_print, print_object): Likewise.
8916 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8917 to int.
6f04d126
PE
8918 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8919 avoiding the 0 flag, which is not portable.
c2982e87
PE
8920 * process.c (Fmake_network_process): Use pI to avoid cast.
8921 * region-cache.c (pp_cache): Likewise.
8922 * xdisp.c (decode_mode_spec): Likewise.
8923 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8924 behavior on 64-bit hosts with printf arg.
6f04d126 8925 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8926 (x_stop_queuing_selection_requests): Likewise.
8927 (x_get_window_property): Don't truncate byte count to an 'int'
8928 when tracing.
0b432f21 8929
5e073ec7
PE
8930 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8931 here, since it parses constructs like leading '-' and spaces,
8932 which are not wanted; and it overflows with large numbers.
8933 Instead, simply match F[0-9]+, which is what is wanted anyway.
8934
36372bf9
PE
8935 * alloc.c: Remove unportable assumptions about struct layout.
8936 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8937 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8938 (allocate_vectorlike, make_pure_vector): Use the new macros,
8939 plus offsetof, to remove unportable assumptions about struct layout.
8940 These assumptions hold on all porting targets that I know of, but
8941 they are not guaranteed, they're easy to remove, and removing them
8942 makes further changes easier.
8943
0b432f21
PE
8944 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8945 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8946 (string_overrun_cookie): Now const. Use initializers that
8947 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8948 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8949 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8950 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8951 multiple of sizeof (EMACS_INT); it need not be, if
8952 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8953 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8954
895009e1
JB
89552011-04-26 Juanma Barranquero <lekktu@gmail.com>
8956
8957 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8958
6a7a1b0b
TZ
89592011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8960
8961 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8962 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8963 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8964
841a1577 89652011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8966
8967 * lisp.h (Qdebug): List symbol.
895009e1 8968 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8969 * keyboard.c (debug-on-event): New variable.
8970 (handle_user_signal): Break into debugger when debug-on-event
8971 matches the current signal symbol.
8972
f2d3ba6f
DN
89732011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8974
8975 * alloc.c (check_sblock, check_string_bytes)
8976 (check_string_free_list): Convert to standard C.
8977
42ce4c63
TZ
89782011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8979
8980 * w32.c (emacs_gnutls_push): Fix typo.
8981
825cd63c
EZ
89822011-04-25 Eli Zaretskii <eliz@gnu.org>
8983
fb11d64d
EZ
8984 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8985 "cast to pointer from integer of different size".
8986
825cd63c
EZ
8987 Improve doprnt and its use in verror. (Bug#8545)
8988 * doprnt.c (doprnt): Document the set of format control sequences
8989 supported by the function. Use SAFE_ALLOCA instead of always
8990 using `alloca'.
8991
8992 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8993 is one byte too soon. Don't use xrealloc; instead xfree and
8994 xmalloc anew.
8995
e061a11b
TZ
89962011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8997
8998 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8999 callbacks stage.
9000
9001 * gnutls.c: Renamed global_initialized to
9002 gnutls_global_initialized. Added internals for the
9003 :verify-hostname-error, :verify-error, and :verify-flags
9004 parameters of `gnutls-boot' and documented those parameters in the
9005 docstring. Start callback support.
9173deec
JB
9006 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9007 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9008 on error. Return error code.
e061a11b
TZ
9009 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9010 (emacs_gnutls_read): Likewise.
9011 (Fgnutls_boot): Return handshake error code.
9012 (emacs_gnutls_handle_error): New function.
9013 (wsaerror_to_errno): Likewise.
9014
9015 * w32.h (emacs_gnutls_pull): Add prototype.
9016 (emacs_gnutls_push): Likewise.
9017
9018 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9019 (emacs_gnutls_push): Likewise.
9020
90212011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9022
9023 * process.c (wait_reading_process_output): Check if GnuTLS
9024 buffered some data internally if no FDs are set for TLS
9025 connections.
9026
9027 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9028 (LIBS): Link to USER_LIBS.
9029 ($(BLD)/gnutls.$(0)): New target.
9030
fa6996bc
EZ
90312011-04-24 Eli Zaretskii <eliz@gnu.org>
9032
eb35682e
EZ
9033 * xdisp.c (handle_single_display_spec): Rename the
9034 display_replaced_before_p argument into display_replaced_p, to
9035 make it consistent with the commentary. Fix typos in the
9036 commentary.
9037
e2ad650c
EZ
9038 * textprop.c (syms_of_textprop): Remove dead code.
9039 (copy_text_properties): Delete obsolete commentary about an
9040 interface that was deleted long ago. Fix typos in the description
9041 of arguments.
9042
1b2de274
EZ
9043 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9044 to changes in oldXMenu/XMenu.h from 2011-04-16.
9045 <menu_help_message, prev_menu_help_message>: Constify.
9046 (IT_menu_make_room): menu->help_text is now `const char **';
9047 adjust.
9048
9049 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9050 to changes in oldXMenu/XMenu.h from 2011-04-16.
9051 (struct XMenu): Declare `help_text' `const char **'.
9052
9053 * xfaces.c <Qunspecified>: Make extern again.
9054
9055 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9056 required by POSIX.
1b2de274 9057
762b15be
EZ
9058 * doc.c (get_doc_string): Improve the format passed to `error'.
9059
9060 * doprnt.c (doprnt): Improve commentary.
9061
9062 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9063
9064 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9065 them with etags.
9066
f1052e5d
EZ
9067 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9068 changes in globals.h immediately force recompilation.
762b15be
EZ
9069 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9070 $(CURDIR)/s/ms-w32.h.
9071 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9072
fa6996bc
EZ
9073 * character.c (Fchar_direction): Function deleted.
9074 (syms_of_character): Don't defsubr it.
9075 <char-direction-table>: Deleted.
9076
e6c3da20
EZ
90772011-04-23 Eli Zaretskii <eliz@gnu.org>
9078
9079 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9080 * doprnt.c: Include limits.h.
9081 (SIZE_MAX): New macro.
04f2d78b
CB
9082 (doprnt): Return a size_t value. 2nd arg is now size_t.
9083 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9084 Improve overflow protection. Support `l' modifier for integer
9085 conversions. Support %l conversion. Don't assume an EMACS_INT
9086 argument for integer conversions and for %c.
9087
9088 * lisp.h (doprnt): Restore prototype.
9089
9090 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9091 $(SRC)/character.h.
9092
9093 * Makefile.in (base_obj): Add back doprnt.o.
9094
9095 * deps.mk (doprnt.o): Add back prerequisites.
9096 (callint.o): Depend on character.h.
9097
9098 * eval.c (internal_lisp_condition_case): Include the handler
9099 representation in the error message.
9100 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9101 when breaking from the loop.
9102
9103 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9104
9105 * callint.c (Fcall_interactively): When displaying error message
9106 about invalid control letter, pass the character's codepoint, not
9107 a pointer to its multibyte form. Improve display of the character
9108 in octal and display also its hex code.
9109
9110 * character.c (char_string): Use %x to display the (unsigned)
9111 codepoint of an invalid character, to avoid displaying a bogus
9112 negative value.
9113
9114 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9115 `error', not SYMBOL_NAME itself.
9116
9117 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9118 character arguments to `error'.
9119
9120 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9121 to `error' in error message about FINAL_CHAR argument. Make sure
9122 FINAL_CHAR is a character, and use %c when it is passed as
9123 argument to `error'.
9124
4ffd0d6b 91252011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9126
9127 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9128
9129 * w32.c: Include <time.h>.
9130 (sys_localtime): New function.
9131
4ffd0d6b 91322011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9133
9134 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9135
4ffd0d6b 9136 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9137
4ffd0d6b 91382011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9139
4ffd0d6b
GM
9140 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9141 zombies (Bug#8467).
aac0c6e3 9142
04c56954
EZ
91432011-04-19 Eli Zaretskii <eliz@gnu.org>
9144
9145 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9146 gl_state.e_property when gl_state.object is Qt.
9147
9148 * insdel.c (make_gap_larger): Remove limitation of buffer size
9149 to <= INT_MAX.
9150
16a43933
CY
91512011-04-18 Chong Yidong <cyd@stupidchicken.com>
9152
9153 * xdisp.c (lookup_glyphless_char_display)
9154 (produce_glyphless_glyph): Handle cons cell entry in
9155 glyphless-char-display.
9156 (Vglyphless_char_display): Document it.
9157
9158 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9159 glyphless-char-display.
9160
4581706e
CY
91612011-04-17 Chong Yidong <cyd@stupidchicken.com>
9162
9163 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9164
9165 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9166
9167 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9168 definition for no-X builds.
9169
4887c6e2 91702011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9171
fd35b6f9
PE
9172 Static checks with GCC 4.6.0 and non-default toolkits.
9173
5c1ccb01
PE
9174 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9175
006c5daa
PE
9176 * process.c (keyboard_bit_set): Define only if SIGIO.
9177 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9178 (send_process): Repair possible setjmp clobbering.
9179
efc736d3
PE
9180 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9181
4e2fe2e6
PE
9182 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9183
f97334a2
PE
9184 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9185
4e75f29d
PE
9186 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9187 Define only if needed.
9188
90efadd1
PE
9189 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9190 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9191 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9192
3c647824
PE
9193 * dispextern.h (struct redisplay_interface): Rename param
9194 to avoid shadowing.
e264f262 9195 * termhooks.h (struct terminal): Likewise.
761383f4 9196 * xterm.c (xembed_send_message): Likewise.
3c647824 9197
b58c5c4a
PE
9198 * insdel.c (make_gap_smaller): Define only if
9199 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9200
cad59032
PE
9201 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9202 it.
9203
c339dc2e
PE
9204 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9205 so that we aren't warned about unused symbols.
9206
91a3e27b
PE
9207 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9208
399c71d3 9209 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9210
8ffc96f5
PE
9211 * xfns.c (x_real_positions): Mark locals as initialized.
9212
eef9bc79
PE
9213 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9214
098db9dd
PE
9215 * xterm.c: Fix problems found by static analysis with other toolkits.
9216 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9217 (x_dispatch_event): Declare static if USE_GTK, and
9218 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9219 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9220 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9221 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9222 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9223
eb18f6cc
PE
9224 * xmenu.c (menu_help_callback): Pointer type fixes.
9225 Use const pointers when pointing at readonly data. Avoid pointer
9226 signedness clashes.
9227 (FALSE): Remove unused macro.
9228 (update_frame_menubar): Remove unused decl.
9229
1fe72bf8
PE
9230 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9231
60d9e1db
PE
9232 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9233 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9234 (single_menu_item): Rename local to avoid shadowing.
9235
39261c26
PE
9236 * keyboard.c (make_lispy_event): Remove unused local var.
9237
018c5e19
PE
9238 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9239 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9240
63d2b86e
PE
9241 * bitmaps: Change bitmaps from unsigned char back to the X11
9242 compatible char. Avoid the old compiler warnings about
9243 out-of-range initializers by using, for example, '\xab' rather
9244 than 0xab.
9245
aefd87e1
PE
9246 * xgselect.c (xgselect_initialize): Check vs interface
9247 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9248
bf501fb9
PE
9249 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9250
e9829fdf
PE
9251 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9252 to read-only memory.
9253
1086c095
PE
9254 * fns.c (vector): Remove; this old hack is no longer needed.
9255
2baccd04 9256 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9257 Remove unused var.
dde42981 9258 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9259
72391843 9260 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9261
436c16df 9262 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9263 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9264 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9265
92bb796d 9266 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9267 (x_term_init): Remove local to avoid shadowing.
92bb796d 9268
764430a3 9269 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9270
9271 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9272 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9273
d1dfb56c
EZ
92742011-04-16 Eli Zaretskii <eliz@gnu.org>
9275
c4354cb4
EZ
9276 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9277
d1dfb56c
EZ
9278 Fix regex.c, syntax.c and friends for buffers > 2GB.
9279 * syntax.h (struct gl_state_s): Declare character position members
9280 EMACS_INT.
9281
9282 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9283
04f2d78b
CB
9284 * textprop.c (verify_interval_modification, interval_of):
9285 Declare arguments EMACS_INT.
d1dfb56c
EZ
9286
9287 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9288 EMACS_INT.
9289
9290 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9291
9292 * indent.c (Fvertical_motion): Local variable it_start is now
9293 EMACS_INT.
9294
9295 * regex.c (re_match, re_match_2, re_match_2_internal)
9296 (bcmp_translate, regcomp, regexec, print_double_string)
9297 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9298 (re_compile_pattern, re_exec): Declare arguments and local
9299 variables `size_t' and `ssize_t' and return values `regoff_t', as
9300 appropriate.
9301 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9302 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9303 <compile_stack_type>: `size' and `avail' are now `size_t'.
9304
9305 * regex.h <regoff_t>: Use ssize_t, not int.
9306 (re_search, re_search_2, re_match, re_match_2): Arguments that
9307 specify buffer/string position and length are now ssize_t and
9308 size_t. Return type is regoff_t.
9309
613052cd
BK
93102011-04-16 Ben Key <bkey76@gmail.com>
9311
9312 * nsfont.m: Fixed bugs in ns_get_family and
9313 ns_descriptor_to_entity that were caused by using free to
9314 deallocate memory blocks that were allocated by xmalloc (via
9315 xstrdup). This caused Emacs to crash when compiled with
9316 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9317 --enable-checking=xmallocoverrun). xfree is now used to
9318 deallocate these memory blocks.
9319
4170f62f 93202011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9321
71b41406
PE
9322 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9323
9587a89d
PE
9324 emacs_write: Accept and return EMACS_INT for sizes.
9325 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9326 et seq.
9327 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9328 Accept and return EMACS_INT.
9329 (emacs_gnutls_write): Return the number of bytes written on
9330 partial writes.
9331 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9332 (emacs_read, emacs_write): Remove check for negative size, as the
9333 Emacs source code has been audited now.
9587a89d
PE
9334 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9335 (emacs_read, emacs_write): Use it.
273a5f82
PE
9336 * process.c (send_process): Adjust to the new signatures of
9337 emacs_write and emacs_gnutls_write. Do not attempt to store
9338 a byte offset into an 'int'; it might overflow.
9587a89d 9339 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9340
3e047f51
PE
9341 * sound.c: Don't assume sizes fit in 'int'.
9342 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9343 Return EMACS_INT, not int.
3e047f51 9344 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9345 Accept EMACS_INT, not int.
9346 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9347 record read return values.
9348
cc39a9db
BK
93492011-04-15 Ben Key <bkey76@gmail.com>
9350
c9d0ec6d
JB
9351 * keyboard.c (Qundefined): Don't declare static since it is used
9352 in nsfns.m.
9353 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9354 static since they are used in nsfont.m.
cc39a9db 9355
6c60eb9f
SM
93562011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9357
9358 * process.c (Qprocessp): Don't declare static.
9359 * lisp.h (Qprocessp): Declare again.
9360
7990b61a
JB
93612011-04-15 Juanma Barranquero <lekktu@gmail.com>
9362
9363 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9364
5d4cb038
PE
93652011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9366
8bd7b830 9367 Improve C-level modularity by making more things 'static'.
cd64ea1d 9368
e3b27b31
PE
9369 Don't publish debugger-only interfaces to other modules.
9370 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9371 (verify_bytepos, count_markers): Move decls to the only modules
9372 that need them.
9373 * region-cache.h (pp_cache): Likewise.
9374 * window.h (check_all_windows): Likewise.
9375 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9376
5d4cb038
PE
9377 * sysdep.c (croak): Now static, if
9378 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9379 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9380
9381 * alloc.c (refill_memory_reserve): Now static if
9382 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9383 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9384
e87b6180
PE
9385 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9386 Define only if USE_LUCID.
9387
ac64929e
PE
9388 * xrdb.c (x_customization_string, x_rm_string): Now static.
9389
6f37259d
PE
9390 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9391 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9392
1683e3ab
PE
9393 * xdisp.c (draw_row_with_mouse_face): Now static.
9394 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9395
de9c2632
PE
9396 * window.h (check_all_windows): Mark externally visible.
9397
2b96acb7
PE
9398 * window.c (window_deletion_count): Now static.
9399
9400 * undo.c: Make symbols static if they're not exported.
9401 (last_undo_buffer, last_boundary_position, pending_boundary):
9402 Now static.
9403
50436f33
PE
9404 * textprop.c (interval_insert_behind_hooks): Now static.
9405 (interval_insert_in_front_hooks): Likewise.
9406
64520e5c
PE
9407 * term.c: Make symbols static if they're not exported.
9408 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9409 (max_frame_lines, tty_set_terminal_modes):
9410 (tty_reset_terminal_modes, tty_turn_off_highlight):
9411 (get_tty_terminal): Now static.
9412 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9413 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9414 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9415 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9416 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9417
1fa53021
PE
9418 * sysdep.c: Make symbols static if they're not exported.
9419 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9420 Now static.
9421 (sigprocmask_set, full_mask): Remove; unused.
9422 (wait_debugging): Mark as visible.
9423 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9424 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9425
d4b43b22
PE
9426 * syntax.c (syntax_temp): Define only if !__GNUC__.
9427
b7c513d0
PE
9428 * sound.c (current_sound_device, current_sound): Now static.
9429
989b29ad
PE
9430 * search.c (searchbufs, searchbuf_head): Now static.
9431
13a55a78
PE
9432 * scroll.c (scroll_cost): Remove; unused.
9433 * dispextern.h (scroll_cost): Remove decl.
9434
de68a1fc
PE
9435 * region-cache.h (pp_cache): Mark as externally visible.
9436
40ccffa6
PE
9437 * process.c: Make symbols static if they're not exported.
9438 (process_tick, update_tick, create_process, chan_process):
9439 (Vprocess_alist, proc_buffered_char, datagram_access):
9440 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9441 (deactivate_process): Mark defn as static, as well as decl.
9442 * lisp.h (create_process): Remove decl.
9443 * process.h (chan_process, Vprocess_alist): Remove decls.
9444
ad64fc97
PE
9445 * print.c: Make symbols static if they're not exported.
9446 (print_depth, new_backquote_output, being_printed, print_buffer):
9447 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9448 (print_interval, print_number_index, initial_stderr_stream):
9449 Now static.
9450 * lisp.h (Fprinc): Remove decl.
9451 (debug_output_compilation_hack): Mark as externally visible.
9452
adddb265
PE
9453 * sysdep.c (croak): Move decl from here to syssignal.h.
9454 * syssignal.h (croak): Put it here, so the API can be checked when
9455 'croak' is called from dissociate_if_controlling_tty.
9456
1717ede2
PE
9457 * minibuf.c: Make symbols static if they're not exported.
9458 (minibuf_save_list, choose_minibuf_frame): Now static.
9459 * lisp.h (choose_minibuf_frame): Remove decl.
9460
fa5fb2bc
PE
9461 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9462
1e3890d1
PE
9463 * lread.c: Make symbols static if they're not exported.
9464 (read_objects, initial_obarray, oblookup_last_bucket_number):
9465 Now static.
9466 (make_symbol): Remove; unused.
9467 * lisp.h (initial_obarray, make_symbol): Remove decls.
9468
8a1414fa
PE
9469 * keyboard.c: Make symbols static if they're not exported.
9470 (single_kboard, recent_keys_index, total_keys, recent_keys):
9471 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9472 (this_single_command_key_start, echoing, last_auto_save):
9473 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9474 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9475 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9476 (Vlispy_mouse_stem, double_click_count):
9477 Now static.
9478 (force_auto_save_soon): Define only if SIGDANGER.
9479 (ignore_mouse_drag_p): Now static if
9480 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9481 (print_help): Remove; unused.
9482 (stop_character, last_timer_event): Mark as externally visible.
9483 * keyboard.h (ignore_mouse_drag_p): Declare only if
9484 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9485 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9486 * lisp.h (echoing): Remove decl.
9487 (force_auto_save_soon): Declare only if SIGDANGER.
9488 * xdisp.c (redisplay_window): Simplify code, to make it more
9489 obvious that ignore_mouse_drag_p is not accessed if !defined
9490 USE_GTK && !defined HAVE_NS.
9491
93ea6e8f
PE
9492 * intervals.c: Make symbols static if they're not exported.
9493 (merge_properties_sticky, merge_interval_right, delete_interval):
9494 Now static.
9495 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9496
77382fcc
PE
9497 * insdel.c: Make symbols static if they're not exported.
9498 However, leave prepare_to_modify_buffer alone. It's never
9499 called from outside this function, but that appears to be a bug.
9500 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9501 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9502 (adjust_after_replace_noundo): Remove; unused.
9503 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9504 (signal_before_change): Remove decls.
77382fcc 9505
9306c32e
PE
9506 * indent.c (val_compute_motion, val_vmotion): Now static.
9507
cd44d2eb
PE
9508 * image.c: Make symbols static if they're not exported.
9509 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9510 if USE_GTK.
9511 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9512 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9513
ad9a7a06
PE
9514 * fringe.c (standard_bitmaps): Now static.
9515 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9516
81626931
PE
9517 * frame.c: Make symbols static if they're not exported.
9518 (x_report_frame_params, make_terminal_frame): Now static.
9519 (get_frame_param): Now static, unless HAVE_NS.
9520 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9521 (x_get_resource_string): Remove; not used.
9522 * frame.h (make_terminal_frame, x_report_frame_params):
9523 (x_get_resource_string); Remove decls.
9524 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9525 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9526
239f9db9
PE
9527 * font.c, fontset.c: Make symbols static if they're not exported.
9528 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9529 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9530 * font.c (font_close_object): Now static.
9531 * font.h (font_close_object): Remove.
9532 * fontset.c (FONTSET_OBJLIST): Remove.
9533 (free_realized_fontset) #if-0 the body, which does nothing.
9534 (face_suitable_for_char_p): #if-0, as it's never called.
9535 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9536 * xfaces.c (face_at_string_position):
9537 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9538 since 0 is always ASCII.
9539
dfcf3579
PE
9540 * fns.c (weak_hash_tables): Now static.
9541
5045092b
PE
9542 * fileio.c: Make symbols static if they're not exported.
9543 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9544 (Vwrite_region_annotation_buffers): Now static.
9545
57a96f5c
PE
9546 * eval.c: Make symbols static if they're not exported.
9547 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9548 * lisp.h (backtrace_list): Remove decl.
9549
35f08c38
PE
9550 * emacs.c: Make symbols static if they're not exported.
9551 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9552 (fatal_error_code, fatal_error_signal_hook, standard_args):
9553 Now static.
9554 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9555 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9556 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9557 * lisp.h (fatal_error_signal_hook): Remove decl.
9558 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9559
f44bd759
PE
9560 * editfns.c: Move a (normally-unused) function to its only use.
9561 * editfns.c, lisp.h (get_operating_system_release): Remove.
9562 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9563 worth the hassle of breaking this out.
9564
b532497d
PE
9565 * xterm.c: Make symbols static if they're not exported.
9566 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9567 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9568 (x_destroy_window, x_delete_display):
9569 Now static.
9570 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9571 (x_mouse_leave): Remove; unused.
9572 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9573 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9574 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9575 Remove decls.
9576 (x_mouse_leave): Declare only if WINDOWSNT.
9577 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9578 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9579 USE_X_TOOLKIT.
9580
1675728f
PE
9581 * ftxfont.c: Make symbols static if they're not exported.
9582 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9583 HAVE_FREETYPE.
9584 * font.h (ftxfont_driver): Likewise.
9585
e4cebfca
PE
9586 * xfns.c: Make symbols static if they're not exported.
9587 (x_last_font_name, x_display_info_for_name):
9588 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9589 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9590 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9591 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9592 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9593 (last_show_tip_args): Now static.
9594 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9595 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9596 (x_screen_planes): Remove; unused.
9597 * dispextern.h (x_screen_planes): Remove decl.
9598
5bf46f05
PE
9599 * dispnew.c: Make symbols static if they're not exported.
9600 * dispextern.h (redraw_garbaged_frames, scrolling):
9601 (increment_row_positions): Remove.
9602 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9603 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9604 Now static.
9605 (redraw_garbaged_frames): Remove; unused.
9606
435f4c28
PE
9607 * xfaces.c: Make symbols static if they're not exported.
9608 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9609 Remove decls.
9610 * xterm.h (defined_color): Remove decls.
9611 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9612 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9613 (menu_face_changed_default, defined_color, free_realized_face):
9614 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9615 (ascii_face_of_lisp_face): Remove; unused.
9616
8524aef3
PE
9617 * xdisp.c: Make symbols static if they're not exported.
9618 * dispextern.h (scratch_glyph_row, window_box_edges):
9619 (glyph_to_pixel_coords, set_cursor_from_row):
9620 (get_next_display_element, set_iterator_to_next):
9621 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9622 (show_mouse_face): Remove decls
9623 * frame.h (message_buf_print): Likewise.
9624 * lisp.h (pop_message, set_message, check_point_in_composition):
9625 Likewise.
9626 * xterm.h (set_vertical_scroll_bar): Likewise.
9627 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9628 (message_buf_print, scratch_glyph_row, displayed_buffer):
9629 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9630 (get_next_display_element, show_mouse_face, window_box_edges):
9631 (frame_to_window_pixel_xy, check_point_in_composition):
9632 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9633 (glyph_to_pixel_coords): Remove; unused.
9634
16390cd2
PE
9635 * dired.c (file_name_completion): Now static.
9636
9637 * dbusbind.c (xd_in_read_queued_messages): Now static.
9638
a25f4dfa
PE
9639 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9640 * data.c (circular_list_error): Remove.
9641
14a9c8df
PE
9642 * commands.h (last_point_position, last_point_position_buffer):
9643 (last_point_position_window): Remove decls.
9644 * keyboard.c: Make these variables static.
9645
04f2d78b
CB
9646 * coding.h (coding, code_convert_region, encode_coding_gap):
9647 Remove decls.
74ab6df5
PE
9648 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9649 (iso_code_class, detect_coding, code_convert_region): Now static.
9650 (encode_coding_gap): Remove; unused.
9651
38dfbee1
PE
9652 * chartab.c (chartab_chars, chartab_bits): Now static.
9653
a2cb4e63
PE
9654 * charset.h (charset_iso_8859_1): Remove decl.
9655 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9656 Now static.
9657
127198fd
PE
9658 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9659 * ccl.c (Vccl_program_table): Now static.
9660 (check_ccl_update): Remove; unused.
9661
d85b608f
PE
9662 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9663 * category.h: ... from here.
9664 * category.c (check_category_table, set_category_set): Now static.
9665
31cd66f3
PE
9666 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9667 * lisp.h: Remove these decls.
9668
c358e587
PE
9669 * buffer.c (buffer_count): Remove unused var.
9670
e78aecca
PE
9671 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9672 so that it's not optimized away.
9673 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9674 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9675 exported only to the debugger.
9676
e192d7d3 9677 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9678 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9679
92470028
PE
9680 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9681 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9682 was inaccessible from Lisp.
9683 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9684 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9685
244ed907
PE
9686 alloc.c: Import and export fewer symbols, and remove unused items.
9687 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9688 is defined.
9689 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9690 it's not optimized away by whole-program optimization.
9691 (message_enable_multibyte, free_misc): Remove.
9692 (catchlist, handlerlist, mark_backtrace):
9693 Declare only if BYTE_MARK_STACK.
9694 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9695 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9696 (message_enable_multibyte): Remove decl.
9697 (free_misc, interval_free_list, float_block, float_block_index):
9698 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9699 (cons_free_list, last_marked_index):
9700 Now static.
9701 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9702 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9703 (mark_backtrace): Define only if BYTE_MARK_STACK.
9704 * xdisp.c (message_enable_multibyte): Now static.
9705
61c2b50e 9706 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9707 This makes it easier for human readers (and static analyzers)
9708 to see whether these variables are used from other modules.
9709 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9710 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9711 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9712 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9713 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9714 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9715 * xmenu.c, xselect.c:
9716 Declare Q* vars static if they are not used in other modules.
9717 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9718 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9719 Remove decls of unexported vars.
9720 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9721
95c82688
PE
9722 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9723
16a97296
PE
9724 Make Emacs functions such as Fatom 'static' by default.
9725 This makes it easier for human readers (and static analyzers)
9726 to see whether these functions can be called from other modules.
9727 DEFUN now defines a static function. To make the function external
9728 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9729 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9730 (Finit_image_library):
16a97296
PE
9731 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9732 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9733 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9734 Remove decls, since these functions are now static.
9735 (Funintern, Fget_internal_run_time): New decls, since these functions
9736 were already external.
95c82688 9737
16a97296
PE
9738 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9739 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9740 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9741 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9742 * keyboard.c, keymap.c, lread.c:
9743 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9744 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9745 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9746 Mark functions with DEFUE instead of DEFUN,
9747 if they are used in other modules.
9748 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9749 decls for now-static functions.
9750 * buffer.h (Fdelete_overlay): Remove decl.
9751 * callproc.c (Fgetenv_internal): Mark as internal.
9752 * composite.c (Fremove_list_of_text_properties): Remove decl.
9753 (Fcomposition_get_gstring): New forward static decl.
9754 * composite.h (Fcomposite_get_gstring): Remove decl.
9755 * dired.c (Ffile_attributes): New forward static decl.
9756 * doc.c (Fdocumntation_property): New forward static decl.
9757 * eval.c (Ffetch_bytecode): New forward static decl.
9758 (Funintern): Remove extern decl; now in .h file where it belongs.
9759 * fileio.c (Fmake_symbolic_link): New forward static decl.
9760 * image.c (Finit_image_library): New forward static decl.
9761 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9762 * intervals.h (Fprevious_property_change):
9763 (Fremove_list_of_text_properties): Remove decls.
9764 * keyboard.c (Fthis_command_keys): Remove decl.
9765 (Fcommand_execute): New forward static decl.
9766 * keymap.c (Flookup_key): New forward static decl.
9767 (Fcopy_keymap): Now static.
9768 * keymap.h (Flookup_key): Remove decl.
9769 * process.c (Fget_process): New forward static decl.
9770 (Fprocess_datagram_address): Mark as internal.
9771 * syntax.c (Fsyntax_table_p): New forward static decl.
9772 (skip_chars): Remove duplicate decl.
9773 * textprop.c (Fprevious_property_change): New forward static decl.
9774 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9775 Now internal.
9776 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9777 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9778
785bbd42
PE
9779 * editfns.c (Fformat): Remove unreachable code.
9780
8b913b57
AS
97812011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9782
9783 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9784 change. (Bug#8496)
9785
a6744a35
EZ
97862011-04-13 Eli Zaretskii <eliz@gnu.org>
9787
9788 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9789 when at ZV. (Bug#8487)
9790
e7974947
AS
97912011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9792
baad03f0
AS
9793 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9794 (Bug#8437)
9795 * keyboard.c (parse_tool_bar_item): Likewise.
9796 * sound.c (sound_cleanup, alsa_close): Likewise.
9797 * termcap.c (tgetent): Likewise.
9798 * xfns.c (x_default_font_parameter): Likewise.
9799 * xsettings.c (read_and_apply_settings): Likewise.
9800
e7974947
AS
9801 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9802 (overrun_check_free): Protoize.
9803
28272684
PE
98042011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9805
9806 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9807 since callers should never pass a negative size.
9808 Change the signature to match that of plain 'read' and 'write'; see
9809 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9810 * lisp.h: Update prototypes of emacs_write and emacs_read.
9811
11997c76
EZ
98122011-04-11 Eli Zaretskii <eliz@gnu.org>
9813
9814 * xdisp.c (redisplay_window): Don't try to determine the character
9815 position of the scroll margin if the window start point w->startp
e896f03c 9816 is outside the buffer's accessible region. (Bug#8468)
11997c76 9817
8a2cbd72
EZ
98182011-04-10 Eli Zaretskii <eliz@gnu.org>
9819
9820 Fix write-region and its subroutines for buffers > 2GB.
9821 * fileio.c (a_write, e_write): Modify declaration of arguments and
9822 local variables to support buffers larger than 2GB.
9823 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9824
9825 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9826 argument, local variables, and return value.
9827
9828 * lisp.h: Update prototypes of emacs_write and emacs_read.
9829
9830 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9831
4073e537 98322011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9833
1ebfdcb6
PE
9834 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9835
b2ded58d
PE
9836 Fix more problems found by GCC 4.6.0's static checks.
9837
7d66342c
PE
9838 * xdisp.c (vmessage): Use a better test for character truncation.
9839
bbf47d44
PE
9840 * charset.c (load_charset_map): <, not <=, for optimization,
9841 and to avoid potential problems with integer overflow.
9248994d 9842 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9843 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9844 * editfns.c (Fformat): Likewise.
1e69125e 9845 * syntax.c (skip_chars): Likewise.
3befa583 9846
e3019616
PE
9847 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9848 This also lets GCC 4.6.0 generate slightly better loop code.
9849
becfa255
PE
9850 * callint.c (Fcall_interactively): <, not <=, for optimization.
9851 (Fcall_interactively): Count the number of arguments produced,
9852 not the number of arguments given. This is simpler and lets GCC
9853 4.6.0 generate slightly better code.
9854
dae0cd48
PE
9855 * ftfont.c: Distingish more carefully between FcChar8 and char.
9856 The previous code passed unsigned char * to a functions like
9857 strlen and xstrcasecmp that expect char *, which does not
9858 conform to the C standard.
9859 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9860 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9861 char * when the C standard requires it.
9862
76032d70
PE
9863 * keyboard.c (read_char): Remove unused var.
9864
eb3f1cc8
PE
9865 * eval.c: Port to Windows vsnprintf (Bug#8435).
9866 Include <limits.h>.
9867 (SIZE_MAX): Define if the headers do not.
9868 (verror): Do not give up if vsnprintf returns a negative count.
9869 Instead, grow the buffer. This ports to Windows vsnprintf, which
9870 does not conform to C99. Problem reported by Eli Zaretskii.
9871 Also, simplify the allocation scheme, by avoiding the need for
9872 calling realloc, and removing the ALLOCATED variable.
9873
70476b54
PE
9874 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9875
12020a9e
PE
9876 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9877 But keep the doprint source code for now, as we might revamp it
9878 and use it again (Bug#8435).
ea6c7ae6
PE
9879 * lisp.h (doprnt): Remove.
9880 * Makefile.in (base_obj): Remove doprnt.o.
9881 * deps.mk (doprnt.o): Remove.
9882
5fdb398c
PE
9883 error: Print 32- and 64-bit integers portably (Bug#8435).
9884 Without this change, on typical 64-bit hosts error ("...%d...", N)
9885 was used to print both 32- and 64-bit integers N, which relied on
9886 undefined behavior.
61bdb816 9887 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9888 * lisp.h (error, verror): Mark as printf-like functions.
9889 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9890 Report overflow in size calculations when allocating printf buffer.
9891 Do not truncate output string at its first null byte.
9892 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9893 Truncate the output at a character boundary, since vsnprintf does not
9894 do that.
9895 * charset.c (check_iso_charset_parameter): Convert internal
9896 character to string before calling 'error', since %c now has the
9897 printf meaning.
9898 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9899 overflow when computing char to be passed to 'error'. Do not
9900 pass Lisp_Object to 'error'; pass the integer instead.
9901 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9902 formatted with plain %d.
9903
b189fa66
PE
9904 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9905
bff87ef0
PE
9906 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9907
7e2cac20
PE
9908 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9909
ce4d90b5
PE
9910 * xterm.c (x_catch_errors): Remove duplicate declaration.
9911
266c9547
PE
9912 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9913
79c49ad2
PE
9914 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9915
368f4090
JM
99162011-04-10 Jim Meyering <meyering@redhat.com>
9917
9918 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9919 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9920 return ssize_t not "int", and use size_t as the buffer length.
9921 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9922 * gnutls.h: Update declarations.
9923 * process.c (read_process_output): Use ssize_t, to match.
9924 (send_process): Likewise.
9925
a32d4040
CY
99262011-04-09 Chong Yidong <cyd@stupidchicken.com>
9927
9928 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9929
8546720e 99302011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9931
04f2d78b
CB
9932 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9933 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9934
8546720e
GM
9935 * xterm.c (handle_one_xevent):
9936 * xmenu.c (create_and_show_popup_menu):
9937 * xselect.c (x_decline_selection_request)
9938 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9939
0a2f5c1a 99402011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9941
9942 Fix some uses of `int' instead of EMACS_INT.
9943 * search.c (string_match_1, fast_string_match)
9944 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9945 (scan_buffer, find_next_newline_no_quit)
9946 (find_before_next_newline, search_command, Freplace_match)
9947 (Fmatch_data): Make some `int' variables be EMACS_INT.
9948
9949 * xdisp.c (display_count_lines): 3rd argument and return value now
9950 EMACS_INT. All callers changed.
9951 (pint2hrstr): Last argument is now EMACS_INT.
9952
9953 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9954 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9955 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9956 (decode_coding_utf_16, decode_coding_emacs_mule)
9957 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9958 (decode_coding_ccl, decode_coding_charset)
9959 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9960 (decode_coding_iso_2022, decode_coding_emacs_mule)
9961 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9962 <char_offset, last_offset>: Declare EMACS_INT.
9963 (encode_coding_utf_8, encode_coding_utf_16)
9964 (encode_coding_emacs_mule, encode_invocation_designation)
9965 (encode_designation_at_bol, encode_coding_iso_2022)
9966 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9967 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9968 Declare EMACS_INT.
9969 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9970 (encode_invocation_designation): Last argument P_NCHARS is now
9971 EMACS_INT.
9972 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9973 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9974
9975 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9976 All users changed.
9977
9978 * ccl.c (Fccl_execute_on_string): Declare some variables
9979 EMACS_INT.
9980
8546720e 99812011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9982
9983 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9984
4e19a977
CS
99852011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9986
9987 * process.c (Fformat_network_address): Doc fix.
9988
87302331
R
99892011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9990
ee7683eb 9991 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9992
cbb59342
CY
99932011-04-08 Chong Yidong <cyd@stupidchicken.com>
9994
9995 * keyboard.c (read_char): Call Lisp function help-form-show,
9996 instead of using internal_with_output_to_temp_buffer.
9997 (Qhelp_form_show): New var.
e0d38eeb 9998 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9999
10000 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10001
10002 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10003
e67a13ab
CY
100042011-04-06 Chong Yidong <cyd@stupidchicken.com>
10005
04f2d78b
CB
10006 * process.c (Flist_processes): Remove to Lisp.
10007 (list_processes_1): Delete.
e67a13ab 10008
973f782d
EZ
100092011-04-06 Eli Zaretskii <eliz@gnu.org>
10010
7c106b1e
EZ
10011 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10012
973f782d
EZ
10013 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10014
41cf7d1a 100152011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10016
ca23cc88
PE
10017 Fix more problems found by GCC 4.6.0's static checks.
10018
f390e2d5
PE
10019 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10020
42eea0d0
PE
10021 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10022
b69769da 10023 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10024
f9541e84
PE
10025 * xdisp.c (vmessage): Mark as a printf-like function.
10026
13841b55
PE
10027 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10028
c136c10f
PE
10029 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10030
5e2d4a30
PE
10031 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10032 printf-like functions.
10033 (tiff_load): Add casts to remove these marks before passing them
10034 to system-supplied API.
10035
583f48b9
PE
10036 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10037
b25d760e
PE
10038 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10039 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10040 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10041 directly, rather than having caller test rule sign. This avoids
10042 some unnecessary tests.
10043 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10044 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10045 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10046
bc7b6697 10047 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10048 (xfont_open): Avoid unnecessary tests.
bc7b6697 10049
27ccc379
PE
10050 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10051
dcd5c89a
PE
10052 * composite.h, composite.c (composition_gstring_put_cache):
10053 Use EMACS_INT, not int, for length.
10054
b13a45c6
PE
10055 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10056 breaking out part of COMPOSITION_DECODE_RULE.
10057 (COMPOSITION_DECODE_RULE): Use it.
10058 * composite.c (get_composition_id): Remove unused local vars,
10059 by using the new macro.
10060
1e792e4d
PE
10061 * textprop.c (set_text_properties_1): Change while to do-while,
10062 since the condition is always true at first.
10063
dc6c6455 10064 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10065 (interval_deletion_adjustment): Return unsigned value.
10066 All uses changed.
dc6c6455 10067
aba7731a
PE
10068 * process.c (list_processes_1, create_pty, read_process_output):
10069 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10070 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10071 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10072 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10073 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10074
fdfc4bf3
PE
10075 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10076
fca8fe46 10077 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10078 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10079
06a0259a 10080 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10081 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10082 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10083
e7b9e80f
PE
10084 * print.c (print_error_message): Avoid int overflow.
10085
56201685
PE
10086 * font.c (font_list_entities): Redo for clarity,
10087 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10088
78834453 10089 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10090 (font_score): Avoid potential overflow in diff calculation.
78834453 10091
0bc0b309 10092 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10093 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10094
e610eaca
PE
10095 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10096
b895abce
PE
10097 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10098 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10099 can always succeed if overflow has undefined behavior.
10100
1f1d9321 10101 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10102 (wordify): Omit three unnecessary tests.
1f1d9321 10103
c59478bc
PE
10104 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10105 All callers changed. This avoids the need for an unused var.
10106
79b73827
PE
10107 * casefiddle.c (casify_region): Remove var that is set but not used.
10108
a4db5dfe
PE
10109 * dired.c (file_name_completion): Remove var that is set but not used.
10110
43aae36e
PE
10111 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10112
2a47c44d 10113 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10114 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10115
a37c69bf
PE
10116 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10117 Check for integer overflow on size calculations.
10118
328ab8e7
PE
10119 * buffer.c (Fprevious_overlay_change): Remove var that is set
10120 but not used.
10121
e5a2a5cb
PE
10122 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10123 Remove vars that are set but not used.
8d84a6eb 10124 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10125 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10126
a60e5f68
PE
10127 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10128
f661cb61 10129 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10130 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10131
f0397f5a
PE
10132 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10133 that are set but not used.
10134
8664db06 10135 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10136 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10137
6abdaa4a
PE
10138 * xselect.c (x_get_local_selection, x_handle_property_notify):
10139 Remove vars that are set but not used.
10140
0ce7538d 10141 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10142 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10143
9ae848fc
PE
10144 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10145 Remove var that is set but not used.
0b918413
PE
10146 (scroll_bar_windows_size): Now size_t, not int.
10147 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10148 Check for overflow.
9ae848fc 10149
a5a62657
PE
10150 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10151 (map_tty_color) [!defined MSDOS]: Likewise.
10152
5c5cdd39
PE
10153 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10154
66ebf983
PE
10155 * coding.c: Remove vars that are set but not used.
10156 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10157 All callers changed.
10158 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10159 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10160 (decode_coding_charset): Remove vars that are set but not used.
10161
1be4d761
PE
10162 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10163 that is set but not used.
10164
47553fa8
PE
10165 * print.c (print_object): Remove var that is set but not used.
10166
1f7196bf 10167 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10168 The gnulib version avoids calling malloc in the usual case,
10169 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10170 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10171 * filelock.c (current_lock_owner): Likewise.
10172 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10173 * sysdep.c: Include allocator.h, careadlinkat.h.
10174 (emacs_no_realloc_allocator): New static constant.
10175 (emacs_readlink): New function.
fdb61804
PE
10176 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10177 ../lib/careadlinkat.h.
d1fdcab7 10178
f84c17c7
SM
101792011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10180
10181 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10182 first non-nil return value).
10183
ef3862ad
JD
101842011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10185
10186 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10187 if not defined (Bug#8403).
10188
376a7006
JB
101892011-04-02 Juanma Barranquero <lekktu@gmail.com>
10190
10191 * xdisp.c (display_count_lines): Remove parameter `start',
10192 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10193 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10194 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10195 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10196 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10197 and thereabouts. All callers changed.
10198 (get_per_char_metric): Remove parameter `f', unused since
10199 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10200
6ca3801d
JM
102012011-04-02 Jim Meyering <meyering@redhat.com>
10202
10203 do not dereference NULL upon failed strdup
10204 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10205 (ns_get_family): Likewise.
10206
d8e2b5ba
JB
102072011-04-02 Juanma Barranquero <lekktu@gmail.com>
10208
10209 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10210
8c74fcbd
JD
102112011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10212
10213 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10214 later (Bug#8403).
10215
7200d79c
SM
102162011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10217
03408648 10218 Add lexical binding.
7200d79c 10219
03408648
SM
10220 * window.c (Ftemp_output_buffer_show): New fun.
10221 (Fsave_window_excursion):
10222 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10223
10224 * lread.c (lisp_file_lexically_bound_p): New function.
10225 (Fload): Bind Qlexical_binding.
10226 (readevalloop): Remove `evalfun' arg.
10227 Bind Qinternal_interpreter_environment.
10228 (Feval_buffer): Bind Qlexical_binding.
10229 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10230 Mark as dynamic.
10231 (syms_of_lread): Declare `lexical-binding'.
10232
10233 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10234
10235 * keyboard.c (eval_dyn): New fun.
10236 (menu_item_eval_property): Use it.
ca105506
SM
10237
10238 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10239
03408648
SM
10240 * fns.c (concat, mapcar1): Accept byte-code-functions.
10241
10242 * eval.c (Fsetq): Handle lexical vars.
10243 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10244 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10245 (FletX, Flet): Obey lexical binding.
10246 (Fcommandp): Handle closures.
10247 (Feval): New `lexical' arg.
10248 (eval_sub): New function extracted from Feval. Use it almost
10249 everywhere where Feval was used. Look up vars in lexical env.
10250 Handle closures.
10251 (Ffunctionp): Move from subr.el.
10252 (Ffuncall): Handle closures.
10253 (apply_lambda): Remove `eval_flags'.
10254 (funcall_lambda): Handle closures and new byte-code-functions.
10255 (Fspecial_variable_p): New function.
10256 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10257 but without exporting it to Lisp.
23aba0ea 10258
23aba0ea 10259 * doc.c (Fdocumentation, store_function_docstring):
03408648 10260 * data.c (Finteractive_form): Handle closures.
23aba0ea 10261
03408648
SM
10262 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10263 interactive spec.
ba83908c 10264
04f2d78b
CB
10265 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10266 New byte-codes.
03408648
SM
10267 (exec_byte_code): New function extracted from Fbyte_code to handle new
10268 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10269
03408648 10270 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10271
03408648 10272 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10273
e2abce01
JB
102742011-03-31 Juanma Barranquero <lekktu@gmail.com>
10275
10276 * xdisp.c (redisplay_internal): Fix prototype.
10277
63696a73 102782011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10279
63696a73 10280 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10281 (try_scrolling): Use it when setting scroll_limit.
10282 Limit scrolling to 100 screen lines.
63696a73
EZ
10283 (redisplay_window): Even when falling back on "recentering",
10284 position point in the window according to scroll-conservatively,
10285 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10286
10287 (try_scrolling): When point is above the window, allow searching
10288 as far as scroll_max, or one screenful, to compute vertical
10289 distance from PT to the scroll margin position. This prevents
10290 try_scrolling from unnecessarily failing when
10291 scroll-conservatively is set to a value slightly larger than the
10292 window height. Clean up the case of PT below the margin at bottom
10293 of window: scroll_max can no longer be INT_MAX. When aggressive
10294 scrolling is in use, don't let point enter the opposite scroll
10295 margin as result of the scroll.
10296 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10297 threshold of 100 lines for never-recentering scrolling.
10298
e4cc2dfc
JB
102992011-03-31 Juanma Barranquero <lekktu@gmail.com>
10300
10301 * dispextern.h (move_it_by_lines):
10302 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10303 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10304 (message_log_check_duplicate): Remove parameters `prev_bol' and
10305 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10306 (redisplay_internal): Remove parameter `preserve_echo_area',
10307 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10308
10309 * indent.c (Fvertical_motion):
10310 * window.c (window_scroll_pixel_based, Frecenter):
10311 Don't pass `need_y_p' to `move_it_by_lines'.
10312
1c470562
SM
103132011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10314
44f230aa
SM
10315 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10316 steal a few bits to be more compact.
10317 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10318 Remove unneeded casts.
10319
1c470562
SM
10320 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10321
888adce9
ZK
103222011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10323
10324 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10325 binding" message (bug#7967).
10326
f838ed7b
PE
103272011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10328
77861b95
PE
10329 Fix more problems found by GCC 4.6.0's static checks.
10330
de6dbc14
PE
10331 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10332 Remove unused local var.
10333
f838ed7b
PE
10334 * editfns.c (Fmessage_box): Remove unused local var.
10335
792c7b2b
PE
10336 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10337 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10338 Omit unused local vars.
c499e557 10339 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10340 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10341 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10342 Omit unused local var.
10343
ba0165e1
PE
10344 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10345 Don't assume string length fits in int.
32ad8845 10346 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10347 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10348
3c59b4c9
PE
10349 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10350 instead of alloca (Bug#8344).
10351
a3eed478 10352 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10353 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10354
eb4d412d
PE
10355 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10356
1658b401
PE
10357 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10358 concerns.
10359
10360 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10361
10362 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10363
9a2c6e05
PE
10364 * keyboard.c (syms_of_keyboard): Use the same style as later
10365 in this function when indexing through an array. This also
10366 works around GCC bug 48267.
10367
03d0a109
PE
10368 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10369
44f730c8
PE
10370 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10371
fe75f926
PE
10372 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10373 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10374
ffa8c828
PE
10375 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10376 This avoids undefined behavior on integer overflow, and is a bit
10377 more convenient anyway since it is compared to a size_t variable.
10378
c5101a77
PE
10379 Variadic C functions now count arguments with size_t, not int.
10380 This avoids an unnecessary limitation on 64-bit machines, which
10381 caused (substring ...) to crash on large vectors (Bug#8344).
10382 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10383 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10384 All variadic functions and their callers changed accordingly.
c5101a77
PE
10385 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10386 * data.c (arith_driver, float_arith_driver): Likewise.
10387 * editfns.c (general_insert_function): Likewise.
10388 * eval.c (struct backtrace.nargs, interactive_p)
10389 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10390 (funcall_lambda, mark_backtrace): Likewise.
10391 * fns.c (concat): Likewise.
10392 * frame.c (x_set_frame_parameters): Likewise.
10393 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10394 0 if not found, not -1. All callers changed.
10395
dd3f25f7
PE
10396 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10397 (stack_copy_size): Now size_t, not int.
10398 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10399
461c2ab9
JB
104002011-03-28 Juanma Barranquero <lekktu@gmail.com>
10401
10402 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10403 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10404 All callers changed.
10405
10406 * lisp.h (multibyte_char_to_unibyte):
10407 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10408 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10409 * character.h (CHAR_TO_BYTE8):
10410 * cmds.c (internal_self_insert):
10411 * editfns.c (general_insert_function):
10412 * keymap.c (push_key_description):
10413 * search.c (Freplace_match):
10414 * xdisp.c (message_dolog, set_message_1): All callers changed.
10415
f6d62986
SM
104162011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10417
10418 * keyboard.c (safe_run_hook_funcall): New function.
10419 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10420 don't set the hook to nil, but remove the offending function instead.
10421 (Qcommand_hook_internal): Remove, unused.
10422 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10423 Vcommand_hook_internal.
10424
10425 * eval.c (enum run_hooks_condition): Remove.
10426 (funcall_nil, funcall_not): New functions.
10427 (run_hook_with_args): Call each function through a `funcall' argument.
10428 Remove `cond' argument, now redundant.
10429 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10430 (Frun_hook_with_args_until_failure): Adjust accordingly.
10431 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10432
1db5b1ad
JB
104332011-03-28 Juanma Barranquero <lekktu@gmail.com>
10434
10435 * dispextern.h (string_buffer_position): Remove declaration.
10436
10437 * print.c (strout): Remove parameter `multibyte', unused since
10438 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10439
10440 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10441 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10442 All callers changed.
10443
10444 * w32.c (_wsa_errlist): Use braces for struct initializers.
10445
10446 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10447 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10448 All callers changed.
10449 (string_buffer_position): Likewise. Also, make static (it's never
10450 used outside xdisp.c).
10451 (cursor_row_p): Remove parameter `w', unused since
10452 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10453 (decode_mode_spec): Remove parameter `precision', introduced during
10454 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10455 All callers changed.
10456
5ffb62aa
JD
104572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10458
10459 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10460
461c2ab9 104612011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10462
10463 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10464 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10465 (ns_update_auto_hide_menu_bar): New functions.
10466 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10467 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10468 ns_constrain_all_frames.
10469 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10470 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10471
5c380ffb
JD
104722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10473
10474 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10475
9af30bdf
GM
104762011-03-27 Glenn Morris <rgm@gnu.org>
10477
10478 * syssignal.h: Replace RETSIGTYPE with void.
10479 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10480 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10481 Replace SIGTYPE with void everywhere.
10482 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10483 * s/template.h (SIGTYPE): Remove commented out definition.
10484
e2abce01
JB
104852011-03-26 Eli Zaretskii <eliz@gnu.org>
10486
10487 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10488 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10489
f868cd8a
JB
104902011-03-26 Juanma Barranquero <lekktu@gmail.com>
10491
59eb0929
JB
10492 * w32.c (read_unc_volume): Use parameter `henum', instead of
10493 global variable `wget_enum_handle'.
10494
10495 * keymap.c (describe_vector): Remove parameters `indices' and
10496 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10497 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10498
f868cd8a
JB
10499 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10500
10501 * keyboard.c (timer_check): Remove parameter `do_it_now',
10502 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10503 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10504 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10505
10506 * keyboard.c (read_char):
10507 * w32menu.c (w32_menu_display_help):
10508 * xmenu.c (show_help_event, menu_help_callback):
10509 Adjust calls to `show_help_echo'.
10510
10511 * gtkutil.c (xg_maybe_add_timer):
10512 * keyboard.c (readable_events):
10513 * process.c (wait_reading_process_output):
10514 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10515
10516 * insdel.c (adjust_markers_gap_motion):
10517 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10518 (gap_left, gap_right): Don't call it.
10519
2ecf6fdb
CY
105202011-03-25 Chong Yidong <cyd@stupidchicken.com>
10521
10522 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10523 incurred during fontification.
10524
6b1f9ba4
JB
105252011-03-25 Juanma Barranquero <lekktu@gmail.com>
10526
10527 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10528 (DEFVAR_PER_BUFFER): Don't pass it.
10529
10530 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10531 (scrolling_window): Don't pass it.
10532
0f4a96b5
JB
105332011-03-25 Juanma Barranquero <lekktu@gmail.com>
10534
10535 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10536
10537 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10538 and `suffix'.
10539 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10540 of variables specific to SELinux and computation of `encoded_absname'.
10541
10542 * image.c (XPutPixel): Remove unused variable `height'.
10543
10544 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10545
10546 * unexw32.c (get_section_info): Remove unused variable `section'.
10547
10548 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10549 (system_process_attributes): Remove unused variable `sess'.
10550 (sys_read): Remove unused variable `err'.
10551
10552 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10553 (w32_wnd_proc): Remove unused variable `isdead'.
10554 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10555 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10556 (x_create_tip_frame): Remove unused variable `tem'.
10557
10558 * w32inevt.c (w32_console_read_socket):
10559 Remove unused variable `no_events'.
10560
10561 * w32term.c (x_draw_composite_glyph_string_foreground):
10562 Remove unused variable `width'.
10563
1149507c
JB
105642011-03-24 Juanma Barranquero <lekktu@gmail.com>
10565
10566 * w32term.c (x_set_glyph_string_clipping):
10567 Don't pass uninitialized region to CombineRgn.
10568
9c88f339
JB
105692011-03-23 Juanma Barranquero <lekktu@gmail.com>
10570
10571 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10572 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10573 (Fx_close_connection): Remove unused variable `i'.
10574
10575 * w32font.c (w32font_draw): Return number of glyphs.
10576 (w32font_open_internal): Remove unused variable `i'.
10577 (w32font_driver): Add missing initializer.
10578
10579 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10580 (fill_in_menu): Remove unused variable `items_added'.
10581
10582 * w32term.c (last_mouse_press_frame): Remove static global variable.
10583 (w32_clip_to_row): Remove unused variable `f'.
10584 (x_delete_terminal): Remove unused variable `i'.
10585
10586 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10587 (NOTHING): Remove unused static global variable.
10588 (uniscribe_check_otf): Remove unused variable `table'.
10589 (uniscribe_font_driver): Add missing initializers.
10590
dee091a3
JD
105912011-03-23 Julien Danjou <julien@danjou.info>
10592
10593 * term.c (Fsuspend_tty, Fresume_tty):
10594 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10595 * window.c (temp_output_buffer_show):
10596 * insdel.c (signal_before_change):
10597 * frame.c (Fhandle_switch_frame):
10598 * fileio.c (Fdo_auto_save):
10599 * emacs.c (Fkill_emacs):
10600 * editfns.c (save_excursion_restore):
10601 * cmds.c (internal_self_insert):
10602 * callint.c (Fcall_interactively):
10603 * buffer.c (Fkill_all_local_variables):
10604 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10605 Use Frun_hooks.
0f4a96b5 10606 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10607 unconditionally since it does the check itself.
dee091a3 10608
2c520ab5 106092011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10610
c9c49752
PE
10611 Fix more problems found by GCC 4.5.2's static checks.
10612
8abc3f12
PE
10613 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10614 the first time through the loop, since we know p0 < p1 then.
10615 This also avoids a gcc -Wstrict-overflow warning.
10616
a2d26660
PE
10617 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10618 leading to a memory leak, possible in functions like
10619 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10620 of objects (Bug#8318).
a2d26660 10621
916c72e9
PE
10622 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10623 that could (at least in theory) be that large.
10624
19ab8a18
PE
10625 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10626 This is less likely to overflow, and avoids undefined behavior if
10627 overflow does occur. All callers changed. Use strtoul to scan
10628 for the unsigned long integer.
b7cbbd6f
PE
10629 (pint2hrstr): Simplify and tune code slightly.
10630 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10631
f0641eff
PE
10632 * scroll.c (do_scrolling): Work around GCC bug 48228.
10633 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10634
7f650bb9
PE
10635 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10636 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10637 (validate_x_resource_name): Simplify count usage.
10638 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10639
37dd57d1
PE
10640 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10641 fail (Bug#8306).
81e56e61 10642
699979fc 10643 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10644
401bf9b4
PE
10645 * process.c (Fmake_network_process): Use socklen_t, not int,
10646 where POSIX says socklen_t is required in portable programs.
10647 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10648 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10649 (Fmake_network_process, server_accept_connection):
10650 (wait_reading_process_output, read_process_output):
10651 Likewise.
10652
b93aacde
PE
10653 * process.c: Rename or move locals to avoid shadowing.
10654 (list_processes_1, Fmake_network_process):
10655 (read_process_output_error_handler, exec_sentinel_error_handler):
10656 Rename or move locals.
4dc343ee 10657 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10658 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10659 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10660 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10661 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10662
af8a867c 10663 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10664 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10665 Include tparam.h instead, since it declares them.
af8a867c
PE
10666 * cm.h (PC): Remove extern decl; tparam.h now does this.
10667 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10668 * terminfo.c: Include tparam.h, to check interfaces.
10669 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10670 (tparam): Adjust signature to match interface in tparam.h;
10671 this removes some undefined behavior. Check that outstring and len
10672 are zero, which they always are with Emacs.
10673 * tparam.h (PC, BC, UP): New extern decls.
10674
0248044d 10675 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10676 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10677
8ff096c1 10678 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10679 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10680 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10681 (ftfont_list): Remove unused local.
49eaafba
PE
10682 (get_adstyle_property, ftfont_pattern_entity):
10683 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10684 Rename locals to avoid shadowing.
8ff096c1 10685
e2be39f6
PE
10686 * xfont.c (xfont_list_family): Mark var as initialized.
10687
c9735e30
PE
10688 * xml.c (make_dom): Now static.
10689
8f5201ae
PE
10690 * composite.c (composition_compute_stop_pos): Rename local to
10691 avoid shadowing.
b246f932
PE
10692 (composition_reseat_it): Remove unused locals.
10693 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10694 (composition_update_it): Mark var as initialized.
11b61122
PE
10695 (find_automatic_composition): Mark vars as initialized,
10696 with a FIXME (Bug#8290).
8f5201ae 10697
760fbc2c
PE
10698 character.h: Rename locals to avoid shadowing.
10699 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10700 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10701 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10702 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10703 to avoid shadowing.
10704
ff08eb85
PE
10705 * textprop.c (property_change_between_p): Remove; unused.
10706
fc7bf025
PE
10707 * intervals.c (interval_start_pos): Now static.
10708
235d7abc
PE
10709 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10710
44f230aa
SM
10711 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10712 Rename locals to avoid shadowing.
3e7d6594 10713
50060332
PE
10714 * sound.c (wav_play, au_play, Fplay_sound_internal):
10715 Fix pointer signedness.
d01f234b 10716 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10717 (wav_play): Initialize a variable to 0, to prevent undefined
10718 behavior (Bug#8278).
50060332 10719
c4fc4e30
PE
10720 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10721
918436ed
PE
10722 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10723
c939f91b
PE
10724 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10725 clobbering (Bug#8298).
b9c7f648
PE
10726 * sysdep.c (sys_subshell): Likewise.
10727 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10728
6bd8c144
PE
10729 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10730 This should get cleaned up, so that child_setup has the
10731 same signature on all platforms.
10732
7710357c 10733 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10734 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10735
c59da222
CY
107362011-03-22 Chong Yidong <cyd@stupidchicken.com>
10737
10738 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10739 not to be necessary, and produces flickering.
10740
66b87493
GM
107412011-03-20 Glenn Morris <rgm@gnu.org>
10742
10743 * config.in: Remove file.
10744
45b6f6d5
JB
107452011-03-20 Juanma Barranquero <lekktu@gmail.com>
10746
10747 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10748 are now in src/globals.h.
10749 (syms_of_minibuf): Remove spurious & from previous change.
10750
cd394be1 107512011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10752
10753 * minibuf.c (completing-read-function): New variable.
10754 (completing-read-default): Rename from completing-read.
10755 (completing-read): Call completing-read-function.
10756
b14e3e21
CY
107572011-03-19 Juanma Barranquero <lekktu@gmail.com>
10758
10759 * xfaces.c (Fx_load_color_file):
10760 Read color file from absolute filename (bug#8250).
10761
f2b726e6
JB
107622011-03-19 Juanma Barranquero <lekktu@gmail.com>
10763
10764 * makefile.w32-in: Update dependencies.
10765
09f6ff02
EZ
107662011-03-17 Eli Zaretskii <eliz@gnu.org>
10767
10768 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10769
29a6015a
PE
107702011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10771
a3a6c54e
PE
10772 Fix more problems found by GCC 4.5.2's static checks.
10773
b766f867
PE
10774 * process.c (make_serial_process_unwind, send_process_trap):
10775 (sigchld_handler): Now static.
10776
be02381c
PE
10777 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10778 That way, the code declares only the vars that it needs.
10779 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10780 * s/cygwin.h (PTY_ITERATION): Likewise.
10781 * s/darwin.h (PTY_ITERATION): Likewise.
10782 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10783
57048744
PE
10784 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10785 * process.c (allocate_pty): Don't declare stb unless it's needed.
10786
7914961c 10787 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10788 (CONSTANTLIM): Remove; unused.
10789 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10790 Define only if needed.
7914961c 10791
b3967b18
PE
10792 * unexelf.c (unexec): Name an expression,
10793 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10794 Use a different way to cause a compilation error if anyone uses
10795 n rather than nn, a way that does not involve shadowing.
73366a00 10796 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10797
29a6015a
PE
10798 * deps.mk (unexalpha.o): Remove; unused.
10799
43cfc33e 10800 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10801 * unexec.h: New file.
ce701a33
PE
10802 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10803 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10804 Depend on unexec.h.
10805 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10806 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10807 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10808 Change as necessary to match prototype in unexec.h.
ce701a33 10809
01f44d5a
PE
10810 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10811 shadowing.
4f63c6bb 10812 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10813
a6670b0b
PE
10814 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10815 Rename locals to avoid shadowing.
10816
cef2010d 10817 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10818 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10819
d4d7173a
PE
10820 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10821
f08b802a
PE
10822 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10823 warning when compiling print.c.
10824
3ddb0639
PE
10825 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10826 instead of using an uninitialized var.
5ad03b97 10827 (font_sort_entities): Mark var as initialized.
3ddb0639 10828
170a2692
PE
10829 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10830
e663c700
PE
10831 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10832 pointers to constants.
89bc529a 10833 (font_parse_fcname): Remove unused vars.
7b81e2d0 10834 (font_delete_unmatched): Now static.
ea838e10 10835 (font_get_spec): Remove; unused.
13a547c6
PE
10836 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10837 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10838 Rename or move locals to avoid shadowing.
e663c700 10839
2a80c887 10840 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10841 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10842
1384fa33 10843 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10844 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10845
8b2c52e9
PE
10846 * alloc.c (mark_backtrace): Move decl from here ...
10847 * lisp.h: ... to here, so that it can be checked.
10848
475545b5 10849 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10850 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10851 (lisp_indirect_variable): Name an expression,
10852 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10853 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10854
b1349114 10855 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10856 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10857 Use const pointer when appropriate.
b1349114 10858
a2928364
PE
10859 * lisp.h (get_system_name, get_operating_system_release):
10860 Move decls here, to check interfaces.
10861 * process.c (get_operating_system_release): Move decl to lisp.h.
10862 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10863 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10864 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10865 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10866 (Fformat_time_string, Fencode_time, Finsert_char):
10867 (Ftranslate_region_internal, Fformat):
10868 Rename or remove local vars to avoid shadowing.
9710023e 10869 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10870
a415e694
PE
10871 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10872 avoid shadowing.
10873
8ef4622d
PE
10874 * lisp.h (eassert): Check that the argument compiles, even if
10875 ENABLE_CHECKING is not defined.
10876
946f9a5b
PE
10877 * data.c (Findirect_variable): Name an expression, to avoid
10878 gcc -Wbad-function-cast warning.
112396d6 10879 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10880 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10881 (Fmake_variable_buffer_local, Fmake_local_variable):
10882 Mark variables as initialized.
52746918 10883 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10884
e5aab7e7 10885 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10886 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10887 Rename locals to avoid shadowing.
dff45157
PE
10888 (mark_stack): Move local variables into the #ifdef region where
10889 they're used.
7bc26fdb
PE
10890 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10891 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10892 needed otherwise.
10893 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10894 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10895 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10896
e5aab7e7
PE
10897 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10898 avoids undefined behavior in theory.
10899
4da60324
PE
10900 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10901
88043301
PE
10902 Use functions, not macros, for up- and down-casing (Bug#8254).
10903 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10904 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10905 to use the following functions instead of these macros.
10906 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10907 EMACS_INT, since callers assume the returned value fits in int.
10908 (upcase1): Likewise, for UPCASE_TABLE.
10909 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10910 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10911 the race-condition problem in the old DOWNCASE.
88043301 10912
19ed5445
PE
10913 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10914 Rename locals to avoid shadowing.
10915 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10916 (regex_compile, re_search_2, re_match_2_internal):
10917 Remove unused local vars.
952db0d7
PE
10918 (FREE_VAR): Rewrite so as not to use empty "else",
10919 which gcc can warn about.
da053e48 10920 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10921 (RETALLOC_IF): Define only if needed.
10922 (WORDCHAR_P): Likewise. This one is never needed, but is used
10923 only in a comment talking about a compiler bug, so put inside
10924 the #if 0 of that comment.
10925 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10926 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10927 Remove; unused.
19ed5445 10928
1f3561e4 10929 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10930 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10931 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10932
ded6f8f7
PE
10933 * search.c (simple_search): Remove unused var.
10934
dbd37a95
PE
10935 * dired.c (compile_pattern): Move decl from here ...
10936 * lisp.h: ... to here, so that it can be checked.
10937 (struct re_registers): New forward decl.
10938
7e47afad
PE
10939 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10940
85f24f61
PE
10941 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10942 All uses changed.
10943 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10944 Rename locals to avoid shadowing.
5671df8f 10945 (Fvertical_motion): Mark locals as initialized.
85f24f61 10946
181aa2be 10947 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10948 (casify_region): Mark local as initialized.
181aa2be 10949
930d429c
PE
10950 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10951
7082eac6
PE
10952 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10953 New macros, so that the caller can use some names other than
10954 gcpro1, gcpro2, etc.
10955 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10956 of the new macros.
10957 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10958 argument, for consistency with GCPRO2_VAR, etc: it is now the
10959 prefix of the variable, not the variable itself. All uses
10960 changed.
38b2c076
PE
10961 * dired.c (directory_files_internal, file_name_completion):
10962 Rename locals to avoid shadowing.
10963
15206ed9
PE
10964 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10965 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10966 dired.c's scmp function, had undefined behavior.
10967 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10968 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10969 * buffer.h: ... to here, because these macros use current_buffer,
10970 and the new implementation with inline functions needs to have
10971 current_buffer in scope now, rather than later when the macros
10972 are used.
10973 (downcase, upcase1): New static inline functions.
10974 (DOWNCASE, UPCASE1): Reimplement using these functions.
10975 This avoids undefined behavior in expressions like
10976 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10977 from race conditions in accessing the global variables
10978 case_temp1 and case_temp2.
10979 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10980 * lisp.h (case_temp1, case_temp2): Remove their decls.
10981 * character.h (ASCII_CHAR_P): Move from here ...
10982 * lisp.h: ... to here, so that the inline functions mentioned
10983 above can use them.
10984
4a6bea26
PE
10985 * dired.c (directory_files_internal_unwind): Now static.
10986
f14b7e14
PE
10987 * fileio.c (file_name_as_directory, directory_file_name):
10988 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10989 Now static.
2893f146
PE
10990 (file_name_as_directory): Use const pointers when appropriate.
10991 (Fexpand_file_name): Likewise. In particular, newdir might
10992 point at constant storage, so make it a const pointer.
fd4ead52 10993 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10994 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10995 signedness issues.
f839df0c
PE
10996 (Fset_file_times, Finsert_file_contents, auto_save_error):
10997 Rename locals to avoid shadowing.
f14b7e14 10998
5716756e 10999 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11000 (Ftry_completion, Fall_completions): Rename or remove locals
11001 to avoid shadowing.
5716756e 11002
b4c3046a
PE
11003 * marker.c (bytepos_to_charpos): Remove; unused.
11004
b45db522
PE
11005 * lisp.h (verify_bytepos, count_markers): New decls,
11006 so that gcc does not warn that these functions aren't declared.
11007
85876d07
PE
11008 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11009 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11010 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11011 (copy_text): Remove unused local var.
85876d07 11012
03d78a21 11013 * filelock.c (within_one_second): Now static.
b3dd38ab 11014 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11015
5df8f01b
PE
11016 * buffer.c (fix_overlays_before): Mark locals as initialized.
11017 (fix_start_end_in_overlays): Likewise. This function should be
11018 simplified by using pointers-to-pointers, but that's a different
11019 matter.
b1d876f1 11020 (switch_to_buffer_1): Now static.
8f54f30a
PE
11021 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11022 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11023
a70072c9 11024 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11025 Fix pointer signedness issue.
edced198
PE
11026 (sys_subshell): Mark local as volatile if checking for lint,
11027 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11028 (MAXPATHLEN): Define only if needed.
a70072c9 11029
a0977c44
PE
11030 * process.c (serial_open, serial_configure): Move decls from here ...
11031 * systty.h: ... to here, so that they can be checked.
11032
a884fdcc
PE
11033 * fns.c (get_random, seed_random): Move extern decls from here ...
11034 * lisp.h: ... to here, so that they can be checked.
11035
604efe86 11036 * sysdep.c (reset_io): Now static.
b8950c94 11037 (wait_for_termination_signal): Remove; unused.
604efe86 11038
38fc62d9
PE
11039 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11040 (copy_keymap_item, append_key, push_text_char_description):
11041 Now static.
1004a21a 11042 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11043 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11044 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11045 (describe_map_tree):
11046 Rename locals to avoid shadowing.
38fc62d9 11047
2f2650da
PE
11048 * keyboard.c: Declare functions static if they are not used elsewhere.
11049 (echo_char, echo_dash, cmd_error, top_level_2):
11050 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11051 (read_char, kbd_buffer_get_event, make_lispy_position):
11052 (make_lispy_event, make_lispy_movement, apply_modifiers):
11053 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11054 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11055 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11056 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11057 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11058
a053e86c 11059 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11060 (mark_kboards): Move decl here ...
11061 * alloc.c (mark_kboards): ... from here.
a053e86c 11062
4752793e
PE
11063 * lisp.h (force_auto_save_soon): New decl.
11064
74f10ca7 11065 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11066 (DEFINE_DUMMY_FUNCTION): New macro.
11067 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11068 Use it.
c03cd23f
PE
11069 (main): Add casts to avoid warnings
11070 if GCC considers string literals to be constants.
74f10ca7 11071
022e70d4
PE
11072 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11073
59d6fe83
PE
11074 * dbusbind.c: Pointer signedness fixes.
11075 (xd_signature, xd_append_arg, xd_initialize):
11076 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11077 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11078 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11079 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11080
78320123
PE
11081 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11082 if GCC considers string literals to be constants.
49cebcca 11083 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11084
35ac2a97
SM
110852011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11086
fb103ca9
SM
11087 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11088 (print_preprocess, print_object): New macro to fix last change.
11089
35ac2a97
SM
11090 * print.c (print_preprocess): Don't forget font objects.
11091
62973b41
JB
110922011-03-16 Juanma Barranquero <lekktu@gmail.com>
11093
11094 * emacs.c (USAGE3): Doc fixes.
11095
0e48bb22
AS
110962011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11097
11098 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11099 structure.
11100
7684e57b
JB
111012011-03-14 Juanma Barranquero <lekktu@gmail.com>
11102
11103 * lisp.h (VWindow_system, Qfile_name_history):
11104 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11105 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11106 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11107
11108 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11109 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11110
11111 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11112 * w32console.c (detect_input_pending, read_input_pending)
11113 (encode_terminal_code):
11114 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11115 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11116 (w32_system_caret_y, Qfile_name_history):
11117 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11118 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11119 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11120 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11121 * w32proc.c (Qlocal, report_file_error):
11122 * w32term.c (Vwindow_system, updating_frame):
11123 * w32uniscribe.c (initialized, uniscribe_font_driver):
11124 Remove unneeded extern declarations.
11125
2aa46d6c
CY
111262011-03-14 Chong Yidong <cyd@stupidchicken.com>
11127
c96bbc66 11128 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11129
cffc6f3b
CY
111302011-03-13 Chong Yidong <cyd@stupidchicken.com>
11131
11132 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11133 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11134 These macros can no longer be used for assignment.
11135
44f230aa
SM
11136 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11137 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11138 (record_buffer_markers, fetch_buffer_markers): New functions for
11139 recording and fetching special buffer markers.
11140 (set_buffer_internal_1, set_buffer_temp): Use them.
11141
11142 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11143
11144 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11145
11146 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11147 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11148
11149 * xdisp.c (hscroll_window_tree):
11150 (reconsider_clip_changes): Use PT instead of BUF_PT.
11151
d251f04b
EZ
111522011-03-13 Eli Zaretskii <eliz@gnu.org>
11153
11154 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11155 $(EMACS_ROOT)/lib/intprops.h.
11156
f0c77cd1
PE
111572011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11158
3eca4629
PE
11159 Fix more problems found by GCC 4.5.2's static checks.
11160
7c86ee98
PE
11161 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11162 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11163 (xg_free_frame_widgets): Make it clear that a local variable is
11164 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11165 (gdk_window_get_screen): Make it clear that this macro is needed
11166 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11167 (int_gtk_range_get_value): New function, which avoids a diagnostic
11168 from gcc -Wbad-function-cast.
11169 (xg_set_toolkit_scroll_bar_thumb): Use it.
11170 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11171 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11172 (get_utf8_string, xg_get_file_with_chooser):
11173 Rename locals to avoid shadowing.
11174 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11175
41729b81
PE
11176 * xgselect.c (xg_select): Remove unused var.
11177
f0c77cd1
PE
11178 * image.c (four_corners_best): Mark locals as initialized.
11179 (gif_load): Initialize transparent_p to zero (Bug#8238).
11180 Mark another local as initialized.
ec6cf4c6 11181 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11182
ce0ad53d 11183 * image.c (clear_image_cache): Now static.
d5d5a617 11184 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11185 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11186 (x_edge_detection): Remove unnecessary cast that
11187 gcc -Wbad-function-cast diagnoses.
2037898d 11188 (gif_load): Fix pointer signedness.
6ae141d6
PE
11189 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11190 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11191
33383987 111922011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11193
d32df629
PE
11194 Improve quality of tests for time stamp overflow.
11195 For example, without this patch (encode-time 0 0 0 1 1
11196 1152921504606846976) returns the obviously-bogus value (-948597
11197 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11198 reports time overflow. See
11199 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11200 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11201 * editfns.c: Include limits.h and intprops.h.
11202 (TIME_T_MIN, TIME_T_MAX): New macros.
11203 (time_overflow): Move earlier, to before first use.
11204 (hi_time, lo_time): New functions, for an accurate test for
11205 out-of-range times.
11206 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11207 (Fget_internal_run_time): Don't assume time_t fits in int.
11208 (make_time): Use list2 instead of Fcons twice.
11209 (Fdecode_time): More accurate test for out-of-range times.
11210 (check_tm_member): New function.
11211 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11212 (lisp_time_argument): Don't rely on undefined left-shift and
11213 right-shift behavior when checking for time stamp overflow.
8be6f318 11214
fe31d94c
PE
11215 * editfns.c (time_overflow): New function, refactoring common code.
11216 (Fformat_time_string, Fdecode_time, Fencode_time):
11217 (Fcurrent_time_string): Use it.
11218
8be6f318
PE
11219 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11220 * dired.c (make_time): Move to ...
11221 * editfns.c (make_time): ... here.
11222 * systime.h: Note the move.
11223
09d9db2c 112242011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11225
126bc0dc
YM
11226 * fringe.c (update_window_fringes): Remove unused variables.
11227
c47cbdfd
YM
11228 * unexmacosx.c (copy_data_segment): Also copy __got section.
11229 (Bug#8223)
11230
7ac80be9
EZ
112312011-03-12 Eli Zaretskii <eliz@gnu.org>
11232
c96bbc66 11233 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11234 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11235 Constify `char *' arguments and their references according to
11236 prototypes in tparam.h.
11237
ecb0f94d 11238 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11239
7ac80be9
EZ
11240 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11241 Adapt all references accordingly.
11242
11243 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11244
ef1fd07e
TT
112452011-03-11 Tom Tromey <tromey@redhat.com>
11246
11247 * buffer.c (syms_of_buffer): Remove obsolete comment.
11248
7ef4b50c
EZ
112492011-03-11 Eli Zaretskii <eliz@gnu.org>
11250
11251 * termhooks.h (encode_terminal_code): Declare prototype.
11252
11253 * msdos.c (encode_terminal_code): Don't declare prototype.
11254
11255 * term.c (encode_terminal_code): Now external again, used by
11256 w32console.c and msdos.c.
11257
44f230aa
SM
11258 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11259 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11260
4b1ec863 112612011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11262
1714f52b 11263 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11264
4b1ec863
PE
11265 * fringe.c (update_window_fringes): Mark locals as initialized
11266 (Bug#8227).
11267 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11268
524c7aa6
PE
11269 * alloc.c (mark_fringe_data): Move decl from here ...
11270 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11271 to check its interface.
11272 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11273
a5c0af81 11274 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11275 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11276 (fontset_font): Mark local as initialized.
a9a06e0b 11277 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11278
b4716021
PE
11279 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11280
811e9bac 11281 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11282 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11283 (x_own_selection, Fx_disown_selection_internal): Rename locals
11284 to avoid shadowing.
11285 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11286
7e3ab302
PE
11287 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11288 so that the caller can use some name other than gcpro1.
11289 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11290 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11291 (Fx_backspace_delete_keys_p):
11292 Use them to avoid shadowing, and rename vars to avoid shadowing.
11293 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11294 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11295 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11296 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11297 Remove unused locals.
7e3ab302
PE
11298 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11299 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11300 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11301 macros.
f78faa98 11302
e2b13473
PE
11303 * xterm.h (x_mouse_leave): New decl.
11304
77f23912
PE
11305 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11306 Remove unused functions.
cdf4ba58
PE
11307 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11308 (x_calc_absolute_position): Now static.
7411c686 11309 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11310 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11311 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11312 unless they are used.
38d0b34a
PE
11313 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11314 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11315 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11316 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11317 (x_error_catcher, x_connection_closed, x_error_handler):
11318 (x_error_quitter, xembed_send_message, x_iconify_frame):
11319 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11320 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11321 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11322
44f230aa
SM
11323 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11324 Rename or move locals to avoid shadowing.
6b463e58 11325 (tty_defined_color, merge_face_heights): Now static.
5967d051 11326 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11327 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11328 does not deduce is never used uninitialized.
73719eba
PE
11329 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11330 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11331
426994c3 11332 * terminal.c (store_terminal_param): Now static.
5489860b 11333
032f1620 11334 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11335 (set_frame_menubar): Remove unused local.
d4323972 11336 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11337 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11338 since they might point to immutable storage.
281585b0
PE
11339 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11340 since it's unused otherwise.
032f1620 11341
367c19e5 11342 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11343 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11344 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11345 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11346 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11347 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11348 does not deduce are never used uninitialized.
70739cbe 11349
07b48fa9
PE
11350 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11351
8868a238 11352 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11353 * window.c (window_loop, size_window):
11354 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11355
7e5cf297 11356 * window.c (display_buffer): Now static.
d6550a9f
PE
11357 (size_window): Mark variables that gcc -Wuninitialized
11358 does not deduce are never used uninitialized.
a586633d
PE
11359 * window.h (check_all_windows): New decl, to forestall
11360 gcc -Wmissing-prototypes diagnostic.
5b555da1 11361 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11362
f6095868
PE
11363 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11364 shadowing.
11365 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11366 Include <limits.h>.
11367 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11368 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11369 (load_charset_map): Mark variables that gcc -Wuninitialized
11370 does not deduce are never used uninitialized.
53df7c11 11371 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11372
f38b440c
PE
11373 * coding.c (coding_set_source, coding_set_destination):
11374 Use "else { /* comment */ }" rather than "else /* comment */;"
11375 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11376 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11377 a block, when the outer 'i' will do.
11378 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11379 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11380 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11381 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11382 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11383 Rename locals to avoid shadowing.
11384 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11385 * coding.c (emacs_mule_char, encode_invocation_designation):
11386 Now static, since they're not used elsewhere.
413bb2db 11387 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11388 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11389 (decode_coding_emacs_mule): Mark variables that gcc
11390 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11391 (detect_coding_iso_2022): Initialize a local variable that might
11392 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11393 this initialization is needed. (Bug#8211)
5f58e762
PE
11394 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11395 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11396 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11397 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11398 Remove unused macros.
f38b440c 11399
232b38b9 11400 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11401 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11402 * character.c (string_count_byte8): Likewise.
232b38b9 11403
fb90da1b
PE
11404 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11405 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11406
fb93dbc2
PE
11407 * chartab.c (copy_sub_char_table): Now static, since it's not used
11408 elsewhere.
5c156ace
PE
11409 (sub_char_table_ref_and_range, char_table_ref_and_range):
11410 Rename locals to avoid shadowing.
bbcd0949 11411 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11412
7d3b3862 11413 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11414 (BIDI_BOB): Remove unused macro.
7d3b3862 11415
6be7d3da
PE
11416 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11417 deduce are never used uninitialized.
c2ed9c8b 11418 * term.c (encode_terminal_code): Likewise.
6be7d3da 11419
75f8807f 11420 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11421
50938595
PE
11422 * tparam.h: New file.
11423 * term.c, tparam.h: Include it.
11424 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11425 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11426 Move these decls to tparam.h, and make them agree with what
11427 is actually in tparam.c. The previous trick of using incompatible
11428 decls in different modules does not conform to the C standard.
11429 All callers of tparam changed to use tparam's actual API.
11430 * tparam.c (tparam1, tparam, tgoto):
11431 Use const pointers where appropriate.
11432
fbceeba2
PE
11433 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11434 * cm.h (struct cm): Likewise.
11435 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11436 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11437 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11438 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11439 (turn_on_face, init_tty): Likewise.
11440 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11441
7f3f1250
PE
11442 * term.c (term_mouse_position): Rename local to avoid shadowing.
11443
e6ca6543
PE
11444 * alloc.c (mark_ttys): Move decl from here ...
11445 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11446
c40f8d15
AS
114472011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11448
11449 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11450
cfe0661d
JB
114512011-03-09 Juanma Barranquero <lekktu@gmail.com>
11452
11453 * search.c (compile_pattern_1): Remove argument regp, unused since
11454 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11455 (compile_pattern): Don't pass it.
11456
0afb4571
J
114572011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11458
11459 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11460 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11461 for ! HAVE_GTK3.
11462 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11463
11464 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11465
11466 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11467 gdk_window_get_screen, gdk_window_get_geometry,
11468 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11469 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11470 (xg_get_pixbuf_from_pixmap): New function.
11471 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11472 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11473 Call xg_get_pixbuf_from_pixmap instead of
11474 gdk_pixbuf_get_from_drawable.
11475 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11476 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11477 (xg_check_special_colors): Use GtkStyleContext and its functions
11478 for HAVE_GTK3.
11479 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11480 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11481 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11482 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11483 Call gtk_widget_get_preferred_size.
0afb4571
J
11484 (xg_frame_resized): gdk_window_get_geometry only takes 5
11485 parameters.
44f230aa
SM
11486 (xg_win_to_widget, xg_event_is_for_menubar):
11487 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11488 (xg_set_widget_bg): New function.
11489 (delete_cb): New function.
895009e1 11490 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11491 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11492 (xg_set_background_color): Call xg_set_widget_bg.
11493 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11494 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11495 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11496 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11497 if ! HAVE_GTK3.
11498 (update_frame_tool_bar): Call gtk_widget_hide.
11499 (xg_initialize): Use GDK_KEY_g.
11500
11501 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11502 if ! HAVE_GTK3
11503 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11504
11505 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11506 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11507 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11508
1c2cc4ef
JB
115092011-03-08 Juanma Barranquero <lekktu@gmail.com>
11510
11511 * w32xfns.c (select_palette): Check success of RealizePalette against
11512 GDI_ERROR, not zero.
11513
33383987 11514See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11515
11516;; Local Variables:
11517;; coding: utf-8
aac0c6e3
MR
11518;; End:
11519
2f097256 11520 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11521
11522 This file is part of GNU Emacs.
11523
11524 GNU Emacs is free software: you can redistribute it and/or modify
11525 it under the terms of the GNU General Public License as published by
11526 the Free Software Foundation, either version 3 of the License, or
11527 (at your option) any later version.
11528
11529 GNU Emacs is distributed in the hope that it will be useful,
11530 but WITHOUT ANY WARRANTY; without even the implied warranty of
11531 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11532 GNU General Public License for more details.
11533
11534 You should have received a copy of the GNU General Public License
11535 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.