* fileio.c: Improve handling of file time marker. (Bug#11852)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dbeed9a6
PE
12012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 * fileio.c: Improve handling of file time marker. (Bug#11852)
4 (special_mtime): New function.
5 (Finsert_file_contents, Fverify_visited_file_modtime):
6 Use it to set special mtime values consistently.
7
636334d6
AS
82012-07-03 Andreas Schwab <schwab@linux-m68k.org>
9
10 * fileio.c (Finsert_file_contents): Properly handle st_mtime
11 marker for non-existing file. (Bug#11852)
12
e2017fe2
GM
132012-07-03 Glenn Morris <rgm@gnu.org>
14
15 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
16 and did not make it into globals.h).
17
404dbd37
TT
182012-07-03 Tom Tromey <tromey@redhat.com>
19
20 * window.c (Fset_window_margins, Fset_window_fringes)
21 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
22 * textprop.c (Fprevious_property_change): No longer static.
23 * syntax.c (Fsyntax_table_p): No longer static.
24 * process.c (Fget_process, Fprocess_datagram_address): No longer
25 static.
26 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
27 * keyboard.c (Fcommand_execute): No longer static.
28 Remove EXFUN.
29 * insdel.c (Fcombine_after_change_execute): No longer static.
30 * image.c (Finit_image_library): No longer static.
31 * fileio.c (Fmake_symbolic_link): No longer static.
32 * eval.c (Ffetch_bytecode): No longer static.
33 * editfns.c (Fuser_full_name): No longer static.
34 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
35 longer static.
36 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
37 static.
38 * dired.c (Ffile_attributes): No longer static.
39 * composite.c (Fcomposition_get_gstring): No longer static.
40 * callproc.c (Fgetenv_internal): No longer static.
41
42 * ccl.h: Remove EXFUNs.
43 * buffer.h: Remove EXFUNs.
44 * dispextern.h: Remove EXFUNs.
45 * intervals.h: Remove EXFUNs.
46 * fontset.h: Remove EXFUN.
47 * font.h: Remove EXFUNs.
48 * dosfns.c (system_process_attributes): Remove EXFUN.
49 * keymap.h: Remove EXFUNs.
50 * lisp.h: Remove EXFUNs.
51 * w32term.h: Remove EXFUNs.
52 * window.h: Remove EXFUNs.
53 * xsettings.h: Remove EXFUN.
54 * xterm.h: Remove EXFUN.
55
8e4fd1e1
GM
562012-07-03 Glenn Morris <rgm@gnu.org>
57
58 * lisp.h (Frandom): Make it visible to C.
59 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
60 buffer for invisible buffers. (Bug#1229)
61
ca95b3eb
DA
622012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
63
64 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
65 values which aren't power of 2.
66 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
67 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
68 accordingly.
69
7555c33f
SM
702012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
71
72 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
73
74 * alloc.c (mark_object): Revert part of last patch to use `switch'.
75
d12e8f5a
DA
762012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
77
78 * alloc.c (allocate_vector_block): Remove redundant
79 calls to mallopt if DOUG_LEA_MALLOC is defined.
80 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
81 avoid calls to mallopt if zero_vector is returned.
82
296094c3
DA
832012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
84
85 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
86 is enabled, avoid dereferencing NULL current_sblock if
87 running undumped.
88
36429c89
DA
892012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
90
91 Cleanup basic buffer management.
92 * buffer.h (struct buffer): Change layout to use generic vector
93 marking code. Fix some comments. Change type of 'clip_changed'
94 to bitfield. Remove unused #ifndef old.
95 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
96 (GET_OVERLAYS_AT): Fix indentation.
97 (for_each_per_buffer_object_at): New macro.
98 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
99 (Fbuffer_local_variables): Use it.
100 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
101 * alloc.c (allocate_buffer): Adjust to match new layout of
102 struct buffer. Fix comment.
103 (mark_overlay): New function.
104 (mark_buffer): Use it. Use mark_vectorlike to mark normal
105 Lisp area of struct buffer.
106 (mark_object): Use it. Adjust marking of misc objects
107 and related comments.
108
3b3e4cac
PE
1092012-07-02 Paul Eggert <eggert@cs.ucla.edu>
110
111 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
112 wrapper that is not needed because the wrapped code is a no-op (zero
113 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
114 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
115
cf5c0175
DA
1162012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
117
118 * alloc.c (mark_buffer): Simplify. Remove prototype.
119 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 120 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
121 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
122 redundant calls to mark_vectorlike for bool vectors.
123
ca26824c
GM
1242012-06-30 Glenn Morris <rgm@gnu.org>
125
2e4c5312
GM
126 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
127
ca26824c
GM
128 * epaths.in (PATH_SITELOADSEARCH): New.
129 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
130 This is rather than relying on --enable-locallisppath elements
131 having "site-lisp" in their names. (Bug#10208#25, 11658)
132
0d23c240
EZ
1332012-06-30 Eli Zaretskii <eliz@gnu.org>
134
c9240d7a
EZ
135 * w32proc.c (sys_select): Accept and ignore one more argument.
136
137 * w32.c (emacs_gnutls_pull): Call select with one more argument.
138
0d23c240 139 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 140 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
141
142 * sysdep.c: Don't include dos.h and dosfns.h.
143
144 * process.c (sys_select):
145 * msdos.c (sys_select): Accept one more argument and ignore it.
146
147 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
148 adapt data types and code to that.
149
150 * dosfns.c:
151 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
152 which clashes with the gnulib function of the same name.
153
af5a5a98
AS
1542012-06-30 Andreas Schwab <schwab@linux-m68k.org>
155
c5e4379c
AS
156 * font.c (font_style_to_value, font_style_symbolic)
157 (font_prop_validate_style): Add type checks for values in
158 font_style_table.
159
af5a5a98
AS
160 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
161 argument.
162 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
163 uses.
164
8d38f461
EZ
1652012-06-29 Eli Zaretskii <eliz@gnu.org>
166
2e5a6631
EZ
167 * xdisp.c (try_window_id): Undo last change.
168
8d38f461
EZ
169 * w32.c (getwd): Adjust commentary about startup_dir.
170 (init_environment): Always call sys_access, even in non-MSVC
171 builds. Don't chdir to the directory of the Emacs executable.
172 This undoes code from 1997 which was justified by the need to
173 "avoid conflicts when removing and renaming directories". But its
174 downside was that every relative file name was being interpreted
175 relative to the directory of the Emacs executable, which can never
176 be TRT. In particular, it broke sys_access when called with
177 relative file names.
178 (sys_access): Map GetLastError to errno.
179
2af3565e
DA
1802012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
181
182 * window.h (struct window): Change type of 'fringes_outside_margins'
183 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 184 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
185 Adjust comment.
186 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
187 to ptrdiff_t.
188
c8d3a25c 1892012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 190
c8d3a25c
GM
191 * gnutls.c (emacs_gnutls_handshake):
192 Add QUIT to make the loop interruptible.
57570cd3 193
c8d3a25c 1942012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 195
c8d3a25c
GM
196 * charset.c (init_charset): Make lack of etc/charsets fatal.
197
3e984ee8
DA
1982012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
199
200 * editfns.c (region_limit): Fix type mismatch.
201
ef884f23
DA
2022012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
203
204 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
205 undefined. Convert from xassert to eassert.
206 * nsmenu.m: Convert from xassert to eassert.
207 * nsterm.m: Likewise.
208
7d7e0027
SM
2092012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
210
211 * editfns.c (region_limit): Clip to narrowing (bug#11770).
212
aa754e6a
PE
2132012-06-28 Paul Eggert <eggert@cs.ucla.edu>
214
215 Avoid integer overflow on scroll-left and scroll-right.
216 * window.c (HSCROLL_MAX): New macro.
217 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
218 overflow when requested scroll falls outside ptrdiff_t range.
219
80b00b08
DA
2202012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * window.h (struct window): Change type of 'hscroll',
223 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
224 'last_modified' and 'last_overlay_modified' to EMACS_INT.
225 Adjust users accordingly.
226 * xdisp.c (try_cursor_movement): Replace type check with eassert.
227 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
228 from EMACS_INT to ptrdiff_t.
229 (make_window): Omit redundant initialization.
230
62b2bcf6
JB
2312012-06-28 Juanma Barranquero <lekktu@gmail.com>
232
233 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
234
45942c7d
DA
2352012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
236
237 * window.h (struct window): Change type of 'use_time' and
238 'sequence_number' from Lisp_Object to int.
239 * frame.c (make_frame): Adjust users accordingly.
240 * print.c (print_object): Likewise.
241 * window.c (select_window, Fwindow_use_time, make_parent_window)
242 (make_window): Likewise.
243
e509cfa6
DA
2442012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
245
246 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
247 enabled with --enable-checking=[all,glyphs] configure option.
248 Fix GLYPH_DEBUG usage assuming that it may be undefined,
249 adjust comments accordingly.
250 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
251 undefined, adjust comments accordingly.
252 * image.c: Likewise.
253 * scroll.c: Likewise.
254 * w32fns.c: Likewise.
255 * w32term.c: Likewise.
256 * xdisp.c: Likewise.
257 * xfaces.c: Likewise.
258 * xfns.c: Likewise.
259 * xterm.c: Likewise.
260
a54e2c05
DA
2612012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Generalize run-time debugging checks.
264 * dispextern.h (XASSERTS): Remove.
265 * fontset.c (xassert): Remove.
266 Convert from xassert to eassert.
267 * alloc.c: Convert from xassert to eassert.
268 * bidi.c: Likewise.
269 * dispnew.c: Likewise.
270 * fns.c: Likewise.
271 * fringe.c: Likewise.
272 * ftfont.c: Likewise.
273 * gtkutil.c: Likewise.
274 * image.c: Likewise.
275 * keyboard.c: Likewise.
276 * menu.c: Likewise.
277 * process.c: Likewise.
278 * scroll.c: Likewise.
279 * sound.c: Likewise.
280 * term.c: Likewise.
281 * w32console.c: Likewise.
282 * w32fns.c: Likewise.
283 * w32term.c: Likewise.
284 * window.c: Likewise.
285 * xdisp.c: Likewise.
286 * xfaces.c: Likewise.
287 * xfns.c: Likewise.
288 * xselect.c: Likewise.
289 * xterm.c: Likewise.
290
1ec4b7b2
SM
2912012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
292
293 * fns.c (maybe_resize_hash_table): Output message when growing the
294 purify-hashtable.
295
2014308a
DA
2962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
297
298 * alloc.c (allocate_string_data): Remove dead code.
299 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
300 avoid GCC warning about unused macro.
301
246155eb
DA
3022012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
303
304 * alloc.c (allocate_string): Omit intervals initialization.
305 * alloc.c (make_uninit_multibyte_string): Initialize intervals
306 as in make_pure_string and make_pure_c_string.
307
43184b7b
DA
3082012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
309
310 * alloc.c (allocate_string): Fix last change.
311
3fe6dd74
DA
3122012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
313
314 * alloc.c (allocate_string): Remove two redundant calls
315 to memset, add explicit initialization where appropriate.
316
1ba6038a
GM
3172012-06-27 Glenn Morris <rgm@gnu.org>
318
319 * lisp.mk (lisp): Remove paths.elc.
320
c89926a5
CY
3212012-06-27 Chong Yidong <cyd@gnu.org>
322
323 * doc.c (Fsubstitute_command_keys): Fix punctuation.
324
ed6b3510
JW
3252012-06-26 John Wiegley <johnw@newartisans.com>
326
1ec4b7b2 327 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
328 on Mac OS X Lion: __mod_init_func and __mod_term_func.
329
ed6b3510
JW
330 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
331 when building with Clang.
332
8edd4a2b
SM
3332012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
334
335 * eval.c (Fapply): Allow calling it with a single argument.
336
f6f62d1b
EZ
3372012-06-26 Eli Zaretskii <eliz@gnu.org>
338
339 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
340 _stricmp and _strnicmp.
341 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
342
62efea5e
DA
3432012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
344
345 * alloc.c (allocate_window): Zero out non-Lisp part of newly
346 allocated window.
347 (allocate_process): Likewise for new process.
8edd4a2b 348 (allocate_terminal): Change to use offsetof.
62efea5e
DA
349 (allocate_frame): Likewise.
350 * frame.c (make_frame): Omit redundant initialization.
351 * window.c (make_parent_window): Use memset.
352 (make_window): Omit redundant initialization.
353 * process.c (make_process): Omit redundant initialization.
354 * terminal.c (create_terminal): Likewise.
355
42997f4d
DA
3562012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
357
358 * term.c (delete_tty): Remove redundant call to memset.
359
1130ecfc
DA
3602012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
361
362 * alloc.c: Remove build_string.
363 * lisp.h: Define build_string as static inline. This provides
364 a better opportunity to optimize away calls to strlen when the
365 function is called with compile-time constant argument.
366 * image.c (imagemagick_error): Convert to build_string.
367 * w32proc.c (sys_spawnve): Likewise.
368 * xterm.c (x_term_init): Likewise.
369
cf38a720
PE
3702012-06-26 Paul Eggert <eggert@cs.ucla.edu>
371
99027bdd
PE
372 Use sprintf return value instead of invoking strlen on result.
373 In the old days this wasn't portable, since some sprintf
374 implementations returned char *. But they died out years ago and
375 Emacs already assumes sprintf returns int.
376 Similarly for float_to_string.
377 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
378 * ccl.c (ccl_driver):
379 * character.c (string_escape_byte8):
380 * data.c (Fnumber_to_string):
381 * doprnt.c (doprnt):
382 * print.c (print_object):
383 * xdisp.c (message_dolog):
384 * xfns.c (syms_of_xfns):
385 Use sprintf or float_to_string result to avoid need to call strlen.
386 * data.c (Fnumber_to_string):
387 Use make_unibyte_string, since the string must be ASCII.
388 * lisp.h, print.c (float_to_string): Now returns int length.
389 * term.c (produce_glyphless_glyph):
390 Use sprintf result rather than recomputing it.
391
cf38a720
PE
392 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
393 * Makefile.in (ALL_CFLAGS):
394 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
395 * gmalloc.c, regex.c: Include <config.h> unconditionally.
396
3511c784
DA
3972012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
398
0a08eb21 399 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
400 strcasecmp if available.
401 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
402
fb7da12e
AS
4032012-06-25 Andreas Schwab <schwab@linux-m68k.org>
404
405 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
406 Avoid comma operator.
407 * menu.c (push_submenu_start, push_submenu_end)
408 (push_left_right_boundary, push_menu_pane): Likewise.
409 * msdos.c (dos_rawgetc): Likewise.
410
afa2ffd8
DA
4112012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
412
413 * xfns.c (xic_create_fontsetname): Remove redundant calls
414 to memset.
415
b3b4476b
PE
4162012-06-25 Paul Eggert <eggert@cs.ucla.edu>
417
4495ff38
PE
418 * gtkutil.c (get_utf8_string): Remove redundant assignment.
419 sprintf already null-terminates its output.
420
b3b4476b
PE
421 * xfns.c (x_window): Remove redundant cast.
422
b00876c9
DA
4232012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
424
425 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
426 `const char *' to `char *' to avoid compiler warning.
427
d188e26b
PE
4282012-06-24 Paul Eggert <eggert@cs.ucla.edu>
429
885d1d74
PE
430 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
431 instead of truncating it to 63 (admittedly a generous limit).
432
d188e26b
PE
433 * process.c: Fix spelling and caps in comments.
434
e2f560b1
DN
4352012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
436
e86db54b 437 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
438 * sysdep.c (setpgrp): Remove definition, not used in this file.
439
7583a3a1
JB
4402012-06-24 Juanma Barranquero <lekktu@gmail.com>
441
442 * makefile.w32-in: Update dependencies.
443
696056c2
EZ
4442012-06-24 Eli Zaretskii <eliz@gnu.org>
445
446 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
447 (SYSTIME_H): Add nt/inc/sys/time.h.
448
449 * systime.h [WINDOWSNT]: Include sys/time.h.
450
451 * s/ms-w32.h (struct timespec): Definition moved from
452 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
453
845ca893
PE
4542012-06-24 Paul Eggert <eggert@cs.ucla.edu>
455
456 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
457 * buffer.h (buffer_slot_type_mismatch):
458 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
459 * eval.c (unwind_to_catch):
460 * image.c (my_png_error, my_error_exit):
461 * keyboard.c (quit_throw_to_read_char, user_error)
462 (Fexit_recursive_edit, Fabort_recursive_edit):
463 * lisp.h (die, args_out_of_range, args_out_of_range_3)
464 (wrong_type_argument, buffer_overflow, __executable_start)
465 (memory_full, buffer_memory_full, string_overflow, Fthrow)
466 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
467 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
468 (fatal):
469 (child_setup) [!DOS_NT]:
470 * lread.c (end_of_file_error, invalid_syntax):
471 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
472 * puresize.h (pure_write_error):
473 * search.c (matcher_overflow):
474 * sound.c (sound_perror, alsa_sound_perror):
475 * sysdep.c, syssignal.h (croak):
476 * term.c (maybe_fatal, vfatal):
477 * textprop.c (text_read_only):
478 * undo.c (user_error):
479 * unexmacosx.c (unexec_error):
480 * xterm.c (x_ins_del_lines, x_delete_glyphs):
481 Use _Noreturn rather than NO_RETURN.
482 No need for separate decl merely because of _Noreturn.
483 * sound.c (sound_warning, parse_sound):
484 Remove unnecessary forward decls.
485
f1dd8073
PE
4862012-06-24 Paul Eggert <eggert@cs.ucla.edu>
487
488 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
489 * lisp.h (WAIT_READING_MAX): New macro.
490 * dispnew.c (Fsleep_for, sit_for):
491 * keyboard.c (kbd_buffer_get_event):
492 * process.c (Faccept_process_output):
493 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
494 This improves on the previous patch, which introduced a bug
495 when time_t is unsigned and as wide as intmax_t.
496 See <http://bugs.gnu.org/9000#51>.
497
b82c1755
EZ
4982012-06-23 Eli Zaretskii <eliz@gnu.org>
499
500 * dispnew.c (sit_for, Fsleep_for):
501 * keyboard.c (kbd_buffer_get_event):
502 * process.c (Faccept_process_output): Avoid compiler warnings when
503 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
504
ca300656
JB
5052012-06-23 Juanma Barranquero <lekktu@gmail.com>
506
049ec95b
JB
507 * makefile.w32-in: Update dependencies.
508
ca300656
JB
509 * w32.c (ltime): Add return type and declare static.
510 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
511
db7b8d06
PE
5122012-06-23 Paul Eggert <eggert@cs.ucla.edu>
513
514 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
515 Privately reported by Herbert J. Skuhra.
516 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
517 All uses changed.
518 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
519 not make_lisp_timeval, when the argument is of type EMACS_TIME.
520
0bd8297f
EZ
5212012-06-23 Eli Zaretskii <eliz@gnu.org>
522
96512555
EZ
523 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
524 last argument of make_unibyte_string.
525
0bd8297f
EZ
526 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
527 language ID in the event parameters.
528
529 * w32term.c (w32_read_socket): Put the new keyboard codepage into
530 event.code, not the obscure "character set ID".
531
63def6b6
CY
5322012-06-23 Chong Yidong <cyd@gnu.org>
533
534 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
535
e8a02204
EZ
5362012-06-23 Eli Zaretskii <eliz@gnu.org>
537
388cdec0
EZ
538 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
539 * w32.c (fdutimens): New function.
540
541 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
542
543 * s/ms-w32.h (pselect): Redirect to sys_select.
544
545 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
546
e8a02204
EZ
547 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
548 in the logic of incrementing and decrementing the value of
549 use_relocatable_buffers.
550
d054f3fb
PE
5512012-06-23 Paul Eggert <eggert@cs.ucla.edu>
552
553 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
554 Privately reported by Herbert J. Skuhra.
555 [__FreeBSD__]: Remove "*/" typo after "#include".
556 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
557 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
558 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
559 Don't assume EMACS_TIME and struct timeval are the same type.
560
d35af63c
PE
5612012-06-22 Paul Eggert <eggert@cs.ucla.edu>
562
563 Support higher-resolution time stamps (Bug#9000).
564 The time stamps are only nanosecond-resolution at the C level,
565 since that's the best that any real-world system supports now.
566 But they are picosecond-resolution at the Lisp level, as that's
567 easy, and leaves room for future OS improvements.
568
569 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
570 (LIBES): Use it.
571
572 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
573 Don't get current time unless it's needed.
574
575 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
576 now provides it if it's absent.
577 (start_atimer): Port to higher-res time stamps.
578 Check for time stamp overflow. Don't get current time more
579 often than is needed.
580
581 * buffer.h (struct buffer): Buffer modtime now has high resolution.
582 Include systime.h, not time.h.
583 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
584
585 * dired.c: Include stat-time.h.
586 (Ffile-attributes): File times now have higher resolution.
587
588 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
589 (struct image): Timestamp now has higher resolution.
590
591 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
592 has at least microseconds now. All uses removed.
593 (update_frame, update_single_window, update_window, update_frame_1)
594 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
595
596 * editfns.c (time_overflow): Now extern.
597 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
598 (float-time, Fformat_time_string, Fcurrent_time_string)
599 (Fcurrent_time_zone): Accept and generate higher-resolution
600 time stamps.
601 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
602 (decode_time_components, lisp_seconds_argument): New functions.
603 (make_time): Now static.
604 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
605 Report an error if the time is invalid, rather than having the caller
606 do that.
607
608 * fileio.c: Include <stat-time.h>
609 (Fcopy_file): Copy higher-resolution time stamps.
610 Prefer to set the time stamp via a file descriptor if that works.
611 (Fset_file_times, Finsert_file_contents, Fwrite_region)
612 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
613 (Fvisited_file_modtime, Fset_visited_file_modtime):
614 Support higher-resolution time stamps.
615
616 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
617
618 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
619
620 * image.c (prepare_image_for_display, clear_image_cache)
621 (lookup_image): Port to higer-resolution time stamps.
622
623 * keyboard.c (start_polling, bind_polling_period):
624 Check for time stamp overflow.
625 (read_char, kbd_buffer_get_event, timer_start_idle)
626 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
627 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
628 Port to higher-resolution time stamps. Do not assume time_t is signed.
629 (decode_timer): New function. Timers are now vectors of length 9,
630 not 8, to accommodate the picosecond component.
631 (timer_check_2): Use it.
632
633 * nsterm.m (select_timeout, timeval_subtract): Remove.
634 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
635 as they're a bit more accurate and handle overflow better.
636 (ns_select): Change prototype to be compatible with pselect.
637 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
638 * nsterm.h (ns_select): Adjust prototype.
639
640 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
641 us-resolution time stamps.
642 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
643
644 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
645
646 * lisp.h (time_overflow): New decl.
647 (wait_reading_process_output): First arg is now intmax_t, not int,
648 to accommodate larger waits.
649
650 * process.h (struct Lisp_Process.read_output_delay):
651 Now counts nanoseconds, not microseconds.
652 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
653 EMACS_HAS_USECS.
654 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
655 (wait_reading_process_output):
656 Port to ns-resolution time stamps.
657 (Faccept_process_output, wait_reading_process_output):
658 Check for time stamp overflow. Do not assume time_t is signed.
659 (select_wrapper): Remove; we now use pselect.
660 (Fprocess_attributes): Now generates ns-resolution time stamps.
661
662 * sysdep.c: Include utimens.h. Don't include utime.h
663 or worry about struct utimbuf; gnulib does that for us now.
664 (gettimeofday): Remove; gnulib provides a substitute.
665 (make_timeval): New function.
666 (set_file_times): Now sets ns-resolution time stamps.
667 New arg FD; all uses changed.
668 (time_from_jiffies, ltime_from_jiffies, get_up_time)
669 (system_process_attributes):
670 Now returns ns-resolution time stamp. All uses changed.
671 Check for time stamp overflow.
672
673 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
674 provides a substitute now.
675
676 * systime.h: Include timespec.h rather than sys/time.h and time.h,
677 since it guarantees struct timespec.
678 (EMACS_TIME): Now struct timespec, so that we can support
679 ns-resolution time stamps.
680 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
681 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
682 (EMACS_USECS): Remove.
683 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
684 so multiply the arg by 1000 before storing it.
685 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
686 New macros.
687 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
688 Port to ns-resolution time stamps.
689 (EMACS_TIME_NEG_P): Remove; replaced by....
690 (EMACS_TIME_SIGN): New macro.
691 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
692 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
693 (set_file_times, make_time, lisp_time_argument): Adjust signature.
694 (make_timeval, make_lisp_time, decode_time_components): New decls.
695 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
696 that it mishandled time_t overflow. You can't compare by subtracting!
697 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
698 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
699
700 * term.c: Include <sys/time.h>.
701 (timeval_to_Time): New function, for proper overflow wraparound.
702 (term_mouse_position, term_mouse_click): Use it.
703
704 * undo.c (record_first_change): Support higher-resolution time stamps
705 in the undo buffer.
706 (Fprimitive_undo): Use them when restoring time stamps.
707
708 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
709 (w32_get_internal_run_time):
710 Port to higher-resolution Emacs time stamps.
711 (ltime): Now accepts single 64-bit integer, as that's more convenient
712 for callers.
713
714 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
715
716 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
717 for compatibility with pselect. Support ns-resolution time stamps.
718
719 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
720
721 * xselect.c (wait_for_property_change, x_get_foreign_selection):
722 Check for time stamp overflow, and support ns-resolution time stamps.
723
724 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
725 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
726 (timeval_subtract): Remove; no longer needed.
727 (XTflash, XTring_bell, x_wait_for_event):
728 Port to ns-resolution time stamps. Don't assume time_t is signed.
729
b6a92dfe
CY
7302012-06-22 Chong Yidong <cyd@gnu.org>
731
732 * xdisp.c (x_consider_frame_title): Revert last change.
733
d251c37c
EZ
7342012-06-22 Eli Zaretskii <eliz@gnu.org>
735
736 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
737 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
738 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
739 staticidx goes up to 1597 out of 1600 = 0x640.)
740
f10deafb
PE
7412012-06-20 Paul Eggert <eggert@cs.ucla.edu>
742
743 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
744 Otherwise, the umask might be mistakenly 0 while handling input signals.
745
ec6de1e2
SM
7462012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
747
748 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
749
28be1ada
DA
7502012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
751
752 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
753 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
754 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
755 access to `contents' member of Lisp_Vector objects with AREF and ASET
756 where appropriate.
757
c6bf3022
CY
7582012-06-19 Chong Yidong <cyd@gnu.org>
759
760 * frame.c (delete_frame): When selecting a frame on a different
761 text terminal, do not alter the terminal's top-frame.
762
763 * xdisp.c (format_mode_line_unwind_data): Record the target
764 frame's selected window and its terminal's top-frame.
765 (unwind_format_mode_line): Restore them.
766 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
767 Callers changed.
768 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
769 since tty frames can be explicitly named.
770 (prepare_menu_bars): Likewise.
771
772 * term.c (Ftty_top_frame): New function.
773
defd4196
PE
7742012-06-18 Paul Eggert <eggert@cs.ucla.edu>
775
776 Port byte-code-meter to modern targets.
777 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
778 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 779 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
780 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
781 (METER_1, METER_2): Simplify.
782
1053a871
SM
7832012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
784
785 * data.c (Fdefalias): Return `symbol' (bug#11686).
786
b7e8d081
MR
7872012-06-18 Martin Rudalics <rudalics@gmx.at>
788
789 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
790 gets killed during executing of this function (Bug#11665).
791 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
792 (Vkill_buffer_query_functions): In doc-string say that functions
793 run by this hook should not change the current buffer.
794
7ea2b339
PE
7952012-06-18 Paul Eggert <eggert@cs.ucla.edu>
796
797 Fix recently-introduced process.c problems found by static checking.
798 * process.c (write_queue_push, write_queue_pop, send_process):
799 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
800 (write_queue_pop): Fix pointer signedness problem.
801 (send_process): Remove unused local.
802
96a313a1
CY
8032012-06-17 Chong Yidong <cyd@gnu.org>
804
805 * xdisp.c (redisplay_internal): No need to redisplay terminal
806 frames that are not on top.
807
20ca2e94
TN
8082012-06-17 Troels Nielsen <bn.troels@gmail.com>
809
810 * process.c (make_process): Initialize write_queue.
811 (write_queue_push, write_queue_pop): New functions.
812 (send_process): Use them to maintain correct ordering of process
813 writes (Bug#10815).
814
9a900ca9
PE
8152012-06-17 Paul Eggert <eggert@cs.ucla.edu>
816
310fbfa8
PE
817 * lisp.h (eassert): Assume C89 or later.
818 This removes the need for CHECK.
819 (CHECK): Remove. Its comments about always evaluating its
820 argument were confusing, as 'eassert' typically does not evaluate
821 its argument.
822
27bb1ca4
PE
823 * coding.c (produce_chars): Use ptrdiff_t, not int.
824
9a900ca9
PE
825 * xterm.c (x_draw_underwave): Check for integer overflow.
826 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
827
41b7f8bc 8282012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
829
830 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
831 referenced (Bug#11583).
832
9b0e3eba
AA
8332012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
834
835 Implement wave-style variant of underlining.
836 * dispextern.h (face_underline_type): New enum.
837 (face): Add field for underline type.
838 * nsterm.m (ns_draw_underwave): New function.
839 (ns_draw_text_decoration): Use it.
840 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
841 New functions.
842 (x_draw_glyph_string): Use them.
843 * xfaces.c (Qline, Qwave): New Lisp objects.
844 (check_lface_attrs, merge_face_ref)
1053a871
SM
845 (Finternal_set_lisp_face_attribute, realize_x_face):
846 Handle wave-style underline face attributes.
9b0e3eba
AA
847 * xterm.c (x_draw_underwave): New function.
848 (x_draw_glyph_string): Use it.
849
0fb52f11
JB
8502012-06-16 Juanma Barranquero <lekktu@gmail.com>
851
852 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
853 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
854 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
855 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
856 ($(BLD)/w32select.$(O)): Update dependencies.
857
e5560ff7
AS
8582012-06-16 Andreas Schwab <schwab@linux-m68k.org>
859
860 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
861 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
862 * character.c (_fetch_multibyte_char_p): Remove.
863 * alloc.c: Include "character.h" before "buffer.h".
864 * bidi.c: Likewise.
865 * buffer.c: Likewise.
866 * bytecode.c: Likewise.
867 * callint.c: Likewise.
868 * callproc.c: Likewise.
869 * casefiddle.c: Likewise.
870 * casetab.c: Likewise.
871 * category.c: Likewise.
872 * cmds.c: Likewise.
873 * coding.c: Likewise.
874 * composite.c: Likewise.
875 * dired.c: Likewise.
876 * dispnew.c: Likewise.
877 * doc.c: Likewise.
878 * dosfns.c: Likewise.
879 * editfns.c: Likewise.
880 * emacs.c: Likewise.
881 * fileio.c: Likewise.
882 * filelock.c: Likewise.
883 * font.c: Likewise.
884 * fontset.c: Likewise.
885 * fringe.c: Likewise.
886 * indent.c: Likewise.
887 * insdel.c: Likewise.
888 * intervals.c: Likewise.
889 * keyboard.c: Likewise.
890 * keymap.c: Likewise.
891 * lread.c: Likewise.
892 * macros.c: Likewise.
893 * marker.c: Likewise.
894 * minibuf.c: Likewise.
895 * nsfns.m: Likewise.
896 * nsmenu.m: Likewise.
897 * print.c: Likewise.
898 * process.c: Likewise.
899 * regex.c: Likewise.
900 * region-cache.c: Likewise.
901 * search.c: Likewise.
902 * syntax.c: Likewise.
903 * term.c: Likewise.
904 * textprop.c: Likewise.
905 * undo.c: Likewise.
906 * unexsol.c: Likewise.
907 * w16select.c: Likewise.
908 * w32fns.c: Likewise.
909 * w32menu.c: Likewise.
910 * window.c: Likewise.
911 * xdisp.c: Likewise.
912 * xfns.c: Likewise.
913 * xmenu.c: Likewise.
914 * xml.c: Likewise.
915 * xselect.c: Likewise.
916
2f07e6af
EZ
9172012-06-16 Eli Zaretskii <eliz@gnu.org>
918
1053a871
SM
919 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
920 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 921 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
922 row.
923 (handle_face_prop): Use chunk-relative overlay string index when
924 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
925 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
926 the rightmost. (Bug#11720)
2f07e6af 927
29b83cec
AS
9282012-06-16 Andreas Schwab <schwab@linux-m68k.org>
929
930 * category.h (CHAR_HAS_CATEGORY): Define as inline.
931 (CATEGORY_MEMBER): Enforce 1/0 value.
932 * category.c (_temp_category_set): Remove.
933
4c5501e9
EZ
9342012-06-16 Eli Zaretskii <eliz@gnu.org>
935
936 * window.c (Fdelete_other_windows_internal)
937 (Fdelete_window_internal): Don't access frame's mouse highlight
938 info of the initial frame. (Bug#11677)
939
2b570124
PE
9402012-06-14 Paul Eggert <eggert@cs.ucla.edu>
941
e93864f9
PE
942 * .gdbinit (xgetint): Fix recently-introduced paren typo.
943 Assume USE_2_TAGS_FOR_INTS.
944 (xreload): Adjust $tagmask width to match recent lisp.h change.
945
2b570124
PE
946 Simplify lisp.h in minor ways that should not affect code.
947 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
948 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
949 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
950 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
951 (INTTYPEBITS): New macro, for clarity.
952 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
953 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
954 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
955 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
956 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
957
81755f69
JB
9582012-06-13 Juanma Barranquero <lekktu@gmail.com>
959
960 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
961
16192a57
GM
9622012-06-13 Glenn Morris <rgm@gnu.org>
963
964 * s/bsd-common.h (BSD4_3):
965 * s/usg5-4-common.h (USG5_4): No longer define; unused.
966
646b5f55
AS
9672012-06-13 Andreas Schwab <schwab@linux-m68k.org>
968
969 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
970 instead of union.
971 (XLI, XIL): Define.
1053a871
SM
972 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
973 Use them.
974 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 975 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 976 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
977 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
978 * frame.c (delete_frame): Remove outdated comment.
979 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
980 USE_LISP_UNION_TYPE.
981 (Fw32_unregister_hot_key): Likewise.
982 (Fw32_toggle_lock_key): Likewise.
983 * w32menu.c (add_menu_item): Likewise.
984 (w32_menu_display_help): Use XIL instead of checking
985 USE_LISP_UNION_TYPE.
986 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
987 (init_heap): Likewise.
988 * w32term.c (w32_read_socket): Update comment.
989
1d3823c9
GM
9902012-06-13 Glenn Morris <rgm@gnu.org>
991
c62ff706
GM
992 * s/usg5-4-common.h, src/s/unixware.h:
993 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
994
1d3823c9
GM
995 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
996
bfe3e0a2
PE
9972012-06-13 Paul Eggert <eggert@cs.ucla.edu>
998
999 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1000 * alloc.c (make_number) [!defined make_number]:
1001 Remove, as lisp.h always defines this now.
1002 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1003 (roundup_size): Verify that it is a power of 2.
1004 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1005 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1006 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1007 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1008 USE_LSB_TAG now is always defined to be either 0 or 1.
1009 All uses changed.
1010 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1011 code works fine either way, and efficiency is not a concern here,
1012 as the union type is for debugging, not for production.
1013 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1014 Use an inline function on all platforms when using the union type,
1015 since this is simpler and 'static inline' can be used portably
1016 within Emacs now.
1017 (LISP_INITIALLY_ZERO): New macro.
1018 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1019 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1020
45fa9c0f
GM
10212012-06-12 Glenn Morris <rgm@gnu.org>
1022
b4492cba
GM
1023 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1024
1025 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1026
45fa9c0f
GM
1027 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1028 Move BROKEN_SIGIO to configure.
1029
1030 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1031 Move NO_TERMIO to configure.
1032
0e25d334
CY
10332012-06-12 Chong Yidong <cyd@gnu.org>
1034
1035 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1036 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1037 MagickExportImagePixels is undefined.
1038
43682bb6
PE
10392012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 * image.c (imagemagick_load_image): Remove unused label.
1042
a9be7d2b
GM
10432012-06-11 Glenn Morris <rgm@gnu.org>
1044
1045 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1046 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1047 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1048 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1049
3017f87f
SM
10502012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1051
1052 * alloc.c (make_byte_code): New function.
1053 (Fmake_byte_code): Use it. Don't purify here.
1054 * lread.c (read1): Use it as well to avoid extra allocation.
1055
1b9b4cf4
CY
10562012-06-11 Chong Yidong <cyd@gnu.org>
1057
1058 * image.c (imagemagick_load_image): Implement transparency.
1059
95988fcf
AS
10602012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1061
1062 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1063 account for preceding backslashes. (Bug#11663)
1064
cd4eb164
CY
10652012-06-09 Chong Yidong <cyd@gnu.org>
1066
1067 * term.c: Support italics in capable terminals (Bug#9652).
1068 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1069 (turn_on_face): Output using TS_enter_italic_mode if available.
1070 Don't handle unused blinking and alt-charset cases.
1071 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1072 and tty_alt_charset_p cases.
1073 (tty_capable_p, init_tty): Support italics.
1074
1075 * termchar.h (struct tty_display_info): Add field for italics.
1076 Remove unused blink field.
1077
1078 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1079 Handle slant.
1080
1081 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1082 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1083 tty_alt_charset_p. Add tty_italic_p.
1084
ff88beb8
MA
10852012-06-09 Michael Albinus <michael.albinus@gmx.de>
1086
1087 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1088 dbus_type_is_basic if available.
1089 (xd_extract_signed, xd_extract_unsigned): Rename from
1090 extract_signed and extract_unsigned, respectively. Adapt callers.
1091
44286096
CY
10922012-06-09 Chong Yidong <cyd@gnu.org>
1093
1682701f
CY
1094 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1095
44286096
CY
1096 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1097 case (Bug#9752).
1098
d86feb17
PE
10992012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * xdisp.c (vmessage): Treat frame message as multibyte.
1102 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1103 would generate the diagnostic "Making \302\247 buffer-local while
1104 let-bound!".
1105
d5c20fe8
EZ
11062012-06-08 Eli Zaretskii <eliz@gnu.org>
1107
1108 * dispnew.c (showing_window_margins_p): Undo last change, which
1109 was done due to an inadvertent commit.
1110 (adjust_frame_glyphs_for_frame_redisplay): Do call
1111 showing_window_margins_p.
1112
513749ee
SM
11132012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1114
1115 * eval.c (Fmake_var_non_special): New primitive.
1116 (syms_of_eval): Defsubr it.
1117 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1118
d4a8f5c1
JB
11192012-06-08 Juanma Barranquero <lekktu@gmail.com>
1120
1121 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1122 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1123
8bbbc977
EZ
11242012-06-08 Eli Zaretskii <eliz@gnu.org>
1125
1126 * alloc.c (allocate_vectorlike): Fix last change.
1127
f3372c87
DA
11282012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1129
1130 Block-based vector allocation of small vectors.
1131 * lisp.h (struct vectorlike_header): New field `nbytes',
1132 adjust comment accordingly.
1133 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1134 to denote vector blocks. Adjust users (live_vector_p,
1135 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1136 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1137 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1138 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1139 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1140 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1141 (roundup_size): New constant.
1142 (struct vector_block): New data type.
1143 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1144 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1145 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1146 (sweep_vectors): New functions.
1147 (allocate_vectorlike): Return `zero_vector' as the only vector of
1148 0 items. Allocate new vector from block if vector size is less than
1149 or equal to VBLOCK_BYTES_MAX.
1150 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1151 (init_alloc_once): Add call to init_vectors.
1152
4f18a4ed
SM
11532012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1154
1155 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1156
86f158bc
PE
11572012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 * doprnt.c (doprnt): Truncate multibyte char correctly.
1160 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1161 would mishandle a string argument "Xc" if X was a multibyte
1162 character of length 2: it would truncate after X's first byte
1163 rather than including all of X.
1164
c5cfcbe0
CY
11652012-06-06 Chong Yidong <cyd@gnu.org>
1166
1167 * buffer.c (word_wrap): Doc fix.
1168
c05cf390
PE
11692012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1172
0c3461de
GM
11732012-06-03 Glenn Morris <rgm@gnu.org>
1174
1175 * xdisp.c (tool-bar-style): Doc fix.
1176
c71232db
UM
11772012-06-03 Ulrich Müller <ulm@gentoo.org>
1178
1179 * Makefile.in (PAXCTL): Define.
1180 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1181 binary via PaX flags if the paxctl utility is available.
1182 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1183 Restore PaX flags to their default. (Bug#11398)
1184
383f7350
CY
11852012-06-03 Chong Yidong <cyd@gnu.org>
1186
1187 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1188 buffer (Bug#11226).
1189
5f2c76c6
CY
11902012-06-03 Chong Yidong <cyd@gnu.org>
1191
1192 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1193 (note_mode_line_or_margin_highlight): If there is no help echo,
1194 use mode-line-default-help-echo. Handle the case where the mouse
1195 position is past the end of the mode line string.
1196
1197 * buffer.c (buffer_local_value_1): New function, split from
1198 Fbuffer_local_value; can return Qunbound.
1199 (Fbuffer_local_value): Use it.
1200 (Vmode_line_format): Docstring tweaks.
1201
773d47f6
PE
12022012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * sysdep.c (system_process_attributes): Improve comment.
1205
f2d6a3df
SM
12062012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1207
1208 * keyboard.c: Export real-this-command to Elisp.
1209 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1210 and DEFVAR it. Update all users.
1211
63810350
PE
12122012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1213
7bd5c1f4
PE
1214 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1215
63810350
PE
1216 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1217 Convert pctcpu and pctmem to Lisp float properly.
1218 Let the compiler fold better, as 100.0/0x8000 is exact.
1219
a2821611
AS
12202012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1221
1222 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1223 cons_block.
1224
5fceba1d
PE
12252012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1228
c98ff5dd
DA
12292012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1230
1231 For a 'struct window', replace some Lisp_Object fields to
1232 bitfields where appropriate, remove unused fields.
1233 * window.h (struct window): Remove unused 'last_mark_x' and
1234 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1235 change it's type from Lisp_Object to bitfield.
1236 Change type of 'force_start', 'optional_new_start',
1237 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1238 fields from Lisp_Object to bitfield. Adjust users accordingly.
1239
ca34e0be
PE
12402012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1241
1242 Pacify gcc -Wdouble-precision when using Xaw.
1243 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1244 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1245 Use 'float' consistently, rather than 'float' in most places
1246 and 'double' in a couple of places.
1247
efc00ab1 12482012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1249
1250 * xdisp.c (handle_stop): Detect whether we have overlay strings
1251 loaded by testing it->current.overlay_string_index to be
1252 non-negative, instead of checking whether n_overlay_strings is
1253 positive. (Bug#11587)
1254
efc00ab1 12552012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1256
1257 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1258
1259 * doc.c (Fsubstitute_command_keys): Doc fix.
1260
efc00ab1 12612012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1262
1263 * search.c (search_buffer): Remove calls to
1264 r_alloc_inhibit_buffer_relocation, as it is now called by
1265 maybe_unify_char, which was the cause of relocation of buffer text
1266 in bug#11519.
1267
efc00ab1 12682012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1269
1270 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1271 for the duration of call to load_charset, to avoid problems with
1272 callers of maybe_unify_char that access buffer text through C
1273 pointers.
1274
1275 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1276 decrement the inhibition flag, instead of just setting or
1277 resetting it.
1278
ba93a187
PE
12792012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 Remove obsolete '#define static' cruft.
1282 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1283 This #undef was "temporary" in 2000; it is no longer needed
1284 now that '#define static' has gone away.
1285 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1286 (gray_bitmap_bits): Remove; no longer needed.
1287 All uses replaced with definiens.
1288 * xterm.c: Include "bitmaps/gray.xbm".
1289
9e4bf381
PE
12902012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 Clean up __executable_start, monstartup when --enable-profiling.
1293 The following changes affect the code only when profiling.
1294 * dispnew.c (__executable_start): Rename from safe_bcopy.
1295 Define only on platforms that need it.
1296 * emacs.c: Include <sys/gmon.h> when profiling.
1297 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1298 (__executable_start): Remove decl, since lisp.h does it now.
1299 (safe_bcopy): Remove decl; no longer has that name.
1300 (main): Coalesce #if into single bit of code, for simplicity.
1301 Cast pointers to uintptr_t, since standard libraries want integers
1302 and not pointers.
1303 * lisp.h (__executable_start): New decl.
1304
32d72c2f
GM
13052012-05-31 Glenn Morris <rgm@gnu.org>
1306
1307 * image.c (Fimagemagick_types): Doc fix.
1308
baac5bc7
JM
13092012-05-30 Jim Meyering <meyering@redhat.com>
1310
1311 * callproc.c (Fcall_process_region): Include directory component
1312 in mkstemp error message (Bug#11586).
1313
72cb32cf
PE
13142012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * alloc.c, lisp.h (make_pure_vector): Now static.
1317
61b108cc
SM
13182012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1319
1320 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1321 Move to byte-run.el.
1322 (Fautoload): Do the hash-doc more carefully.
1323 * data.c (Fdefalias): Purify definition, except for keymaps.
1324 (Qdefun): Move from eval.c.
1325 * lisp.h (Qdefun): Remove.
1326 * lread.c (read1): Tiny simplification.
1327
471fe23d
TN
13282012-05-29 Troels Nielsen <bn.troels@gmail.com>
1329
934f3f58 1330 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1331 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1332 Bug#9642, but explicitly check that the buffer the overlay would
1333 be moved to is live and rearrange lines to make sure that errors
1334 will not put the overlay in an inconsistent state.
1335 (Fdelete_overlay): Cosmetics.
1336
85d0efd1
EZ
13372012-05-28 Eli Zaretskii <eliz@gnu.org>
1338
1339 * w32term.c (my_bring_window_to_top): New function.
1340 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1341 could be different from the original one.
1342 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1343 (Bug#11513)
1344
1345 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1346 by calling BringWindowToTop.
1347
1348 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1349 (WM_EMACS_END): Increase by one.
1350
da92a98c
PE
13512012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1354 This avoids undefined behavior that might cause the eassert
1355 to not catch an out-of-range value.
1356
74d1f848
JB
13572012-05-28 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1360 Update dependencies.
1361
9e1a06fc
EZ
13622012-05-27 Eli Zaretskii <eliz@gnu.org>
1363
1364 * bidi.c (bidi_mirror_char): Fix last change.
1365
f3dd7312
AS
13662012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1367
1368 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1369 when referring to sectname field in printf format.
1370
81899c91
PE
13712012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1372
57b81a9f
PE
1373 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1374 Only r_alloc_inhibit_buffer_relocation needed to be added;
1375 the others were already declared.
1376
81899c91
PE
1377 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1378 before checking whether it's out of range. Put the check inside
1379 eassert. See
1380 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1381
33017faf 13822012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1383
1384 * callproc.c (Fcall_process): Restore a line that was accidentally
1385 commented out in the 2011-02-13 change (bug#11547).
1386
33017faf 13872012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1388
1389 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1390 defined on ralloc.c.
1391
1392 * buffer.c [REL_ALLOC]: Remove prototypes of
1393 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1394 they are now on lisp.h.
1395
1396 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1397
1398 * search.c (search_buffer): Use it to inhibit relocation of buffer
1399 text while re_search_2 is doing its job, because re_search_2 is
1400 passed C pointers to buffer text. (Bug#11519)
1401
23415acf
EZ
1402 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1403 Update value to 24.
1404
44e27368
EZ
1405 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1406 state after an additional call to move_it_in_display_line_to, keep
1407 the values of it->max_ascent and it->max_descent found for the
1408 entire line.
1409 (pos_visible_p): Revert the comparison against bottom_y to what it
1410 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1411 (Bug#11464)
1412
c1892f11
PE
14132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 Fix coding-related core dumps with gcc -ftrapv.
1416 The code was computing A - B, where A and B are pointers, and B is
1417 random garbage. This can lead to core dumps on platforms that
1418 have special pointer registers, and it also leads to core dumps on
1419 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1420 A - B only when B is initialized properly.
1421 * coding.c (coding_set_source, coding_set_destination): Return void.
1422 (coding_change_source, coding_change_destinations): New functions,
1423 with the old behaviors of coding_set_source and coding_set_destination.
1424 All callers that need an offset changed to use these new functions.
1425
eb7afdad
GM
14262012-05-26 Glenn Morris <rgm@gnu.org>
1427
1428 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1429
f12fdf02
EZ
14302012-05-26 Eli Zaretskii <eliz@gnu.org>
1431
53a63be6 1432 Extend mouse support on W32 text-mode console.
61b108cc
SM
1433 * xdisp.c (draw_row_with_mouse_face):
1434 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1435
eb3f6f01 1436 * w32console.c: Include window.h.
61b108cc
SM
1437 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1438 New functions.
eb3f6f01
EZ
1439 (initialize_w32_display): Initialize mouse-highlight data.
1440
53a63be6
EZ
1441 * w32inevt.c: Include termchar.h and window.h.
1442 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1443 moves, call note_mouse_highlight. If help_echo changed, call
1444 gen_help_event to produce help-echo message in the echo area.
1445 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1446 highlight info.
1447
4cfd81f6
PE
14482012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 * lread.c (read1): Simplify slightly to avoid an overflow warning
1451 with GCC 4.7.0 on x86-64.
1452
4446092a
EZ
14532012-05-26 Eli Zaretskii <eliz@gnu.org>
1454
1455 * bidi.c (bidi_mirror_char): Revert last change: an int is
1456 definitely wide enough here.
1457
42b2a986 14582012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1459
42b2a986 1460 Fix integer width and related bugs (Bug#9874).
eb106a49 1461 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1462 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1463 (string_bytes, check_sblock, allocate_string_data):
1464 (compact_small_strings, Fmake_bool_vector, make_string)
1465 (make_unibyte_string, make_multibyte_string)
1466 (make_string_from_bytes, make_specified_string)
1467 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1468 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1469 (mark_vectorlike):
1470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1471 (allocate_pseudovector):
1472 Use int, not EMACS_INT, where int is wide enough.
1473 (inhibit_garbage_collection, Fgarbage_collect):
1474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1475 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1476 int might not be wide enough.
1477 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1478 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1479 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1480 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1481 (bidi_level_of_next_char, bidi_move_to_visually_next):
1482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1483 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1484 (Fkill_buffer, Fset_buffer_major_mode)
1485 (advance_to_char_boundary, Fbuffer_swap_text)
1486 (Fset_buffer_multibyte, overlays_at, overlays_in)
1487 (overlay_touches_p, struct sortvec, record_overlay_string)
1488 (overlay_strings, recenter_overlay_lists)
1489 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1490 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1491 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1492 (Foverlay_recenter, last_overlay_modification_hooks_used)
1493 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1495 (validate_region): Omit unnecessary test for b <= e,
1496 since that's guaranteed by the previous test.
d311d28c
PE
1497 (adjust_overlays_for_delete): Avoid pos + length overflow.
1498 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1499 (report_overlay_modification):
1500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1501 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1502 Omit pointer cast, which isn't needed anyway, and doesn't work
1503 after the EMACS_INT -> ptrdiff_t change.
02481186 1504 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1505 * buffer.h: Adjust decls to match defn changes elsewhere.
1506 (struct buffer_text, struct buffer):
1507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1508 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1509 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1510 not int, to avoid needless 32-bit limit on 64-bit hosts.
1511 (exec_byte_code): Use tighter memory-full test, one that checks
1512 for alloca overflow. Don't compute the address of the object just
1513 before an array, as that's not portable. Use EMACS_INT, not
1514 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1515 * callint.c (Fcall_interactively):
1516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1517 * callproc.c (call_process_kill, Fcall_process):
1518 Don't assume pid_t fits into an Emacs fixnum.
1519 (call_process_cleanup, Fcall_process, child_setup):
1520 Don't assume pid_t fits into int.
1521 (call_process_cleanup, Fcall_process, delete_temp_file)
1522 (Fcall_process_region):
1523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1524 (Fcall_process): Simplify handling of volatile integers.
1525 Use int, not EMACS_INT, where int will do.
1526 * casefiddle.c (casify_object, casify_region, operate_on_word)
1527 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1529 (casify_object): Avoid integer overflow when overallocating buffer.
1530 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1531 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1532 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1533 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1534 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1535 integers are now checked earlier. All uses replaced with XINT.
1536 (ccl_driver):
1537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1538 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1539 (ccl_driver, Fregister_code_conversion_map):
1540 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1541 (resolve_symbol_ccl_program): Check that vector header is in range.
1542 Always copy the vector, so that we can check its contents reliably
1543 now rather than having to recheck each instruction as it's being
1544 executed. Check that vector words fit in 'int'.
1545 (ccl_get_compiled_code, Fregister_ccl_program)
1546 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1547 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1548 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1549 contents are in range.
1550 (Fccl_execute_on_string): Check that status is in range.
1551 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1552 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1553 Accept and return EMACS_INT, not int, because callers can pass values
1554 out of 'int' range.
1555 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1556 (multibyte_chars_in_text, parse_str_as_multibyte)
1557 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1558 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1559 (string_escape_byte8, Fget_byte):
1560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1561 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1562 avoid mishandling large integers.
1563 * character.h: Adjust decls to match defn changes elsewhere.
1564 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1565 (Ffind_charset_region):
1566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1567 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1568 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1569 Don't assume fixnum fits in int.
d311d28c
PE
1570 (load_charset_map_from_vector, Fmap_charset_chars):
1571 Remove now-unnecessary CHECK_NATNUMs.
1572 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1573 Don't rely on undefined behavior with signed left shift overflow.
1574 Don't assume unsigned int fits into fixnum, or that fixnum fits
1575 into unsigned int. Don't require max_code to be a valid fixnum;
1576 that's not true for gb10830 4-byte on a 32-bit host. Allow
1577 invalid_code to be a cons, for the same reason. Require code_offset
1578 to be a character. Avoid int overflow if max_char is close
1579 to INT_MAX.
1580 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1581 this is intended anyway and avoids some undefined behavior.
1582 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1583 INDEX_TO_CODE_POINT, as that's what it expects.
1584 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1585 * charset.h (DECODE_CHAR): Return int, not unsigned;
1586 this is what was intended anyway, and it avoids undefined behavior.
1587 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1588 integer-overflow issues.
1589 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1590 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1591 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1592 * chartab.c (Fmake_char_table, Fset_char_table_range)
1593 (uniprop_get_decoder, uniprop_get_encoder):
1594 Don't assume fixnum fits in int.
1595 * cmds.c (move_point): New function, that does the gist of
1596 Fforward_char and Fbackward_char, but does so while checking
1597 for integer overflow more accurately.
c96e5d6a 1598 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1599 (Fforward_line, Fend_of_line, internal_self_insert)
1600 (internal_self_insert):
1601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1602 Fix a FIXME, by checking for integer overflow when calculating
1603 target_clm and actual_clm.
1604 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1605 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1606 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1607 (coding_alloc_by_making_gap, alloc_destination)
1608 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1609 (encode_coding_utf_16, detect_coding_emacs_mule)
1610 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1611 (detect_coding_iso_2022, decode_coding_iso_2022)
1612 (encode_invocation_designation, encode_designation_at_bol)
1613 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1614 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1615 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1616 (encode_coding_ccl, encode_coding_raw_text)
1617 (detect_coding_charset, decode_coding_charset)
1618 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1619 (produce_composition, produce_charset, produce_annotation)
1620 (decode_coding, handle_composition_annotation)
1621 (handle_charset_annotation, consume_chars, decode_coding_gap)
1622 (decode_coding_object, encode_coding_object, detect_coding_system)
1623 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1624 (code_convert_region, code_convert_string)
8f50130c
PE
1625 (Fdefine_coding_system_internal)
1626 (coding_set_source, coding_set_destination):
d311d28c
PE
1627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1628 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1629 (Fdefine_coding_system_internal):
1630 Don't assume fixnums fit in int.
1631 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1632 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1633 (Funencodable_char_position, Fcheck_coding_systems_region)
1634 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1636 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1637 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1638 Don't access memory outside of the args array.
d311d28c 1639 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1640 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1641 result of ENCODE_CHAR.
d311d28c
PE
1642 * coding.h: Adjust decls to match defn changes elsewhere.
1643 (struct coding_system):
1644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1645 * composite.c (get_composition_id, find_composition)
1646 (run_composition_function, update_compositions)
1647 (compose_text, composition_gstring_put_cache)
1648 (composition_gstring_p, composition_gstring_width)
1649 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1650 (composition_compute_stop_pos, composition_reseat_it)
1651 (composition_update_it, struct position_record)
1652 (find_automatic_composition, composition_adjust_point)
1653 (Fcomposition_get_gstring, Ffind_composition_internal):
1654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1655 (update_compositions):
1656 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1657 * composite.h: Adjust decls to match defn changes elsewhere.
1658 (struct composition):
1659 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1660 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1661 Do not attempt to compute the address of the object just before a
1662 buffer; this is not portable.
1663 (Faref, Faset):
1664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1665 (Faset): Use int, not EMACS_INT, where int is wide enough.
1666 (Fstring_to_number): Don't assume fixnums fit in int.
1667 (Frem): Don't assume arg is nonnegative.
1668 * dbusbind.c (xd_append_arg): Check for integers out of range.
1669 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1670 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1671 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1672 (xd_get_connection_references): Return ptrdiff_t, not int.
1673 All uses changed.
1674 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1675 (xd_read_message_1):
1676 Use int, not unsigned, where the dbus API uses int.
1677 (Fdbus_message_internal): Don't overflow mtype.
1678 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1679 * dired.c (directory_files_internal, file_name_completion, scmp)
1680 (file_name_completion_stat):
1681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1682 (file_name_completion): Don't overflow matchcount.
1683 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1684 * dispextern.h: Adjust decls to match defn changes elsewhere.
1685 (struct text_pos, struct glyph, struct bidi_saved_info)
1686 (struct bidi_string_data, struct bidi_it, struct composition_it)
1687 (struct it):
1688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1689 (struct display_pos, struct composition_it, struct it):
1690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1691 * dispnew.c (increment_matrix_positions)
1692 (increment_row_positions, mode_line_string)
1693 (marginal_area_string):
1694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1695 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1697 (duration_to_sec_usec): New function, to check for overflow better.
1698 (Fsleep_for, sit_for): Use it.
1699 * doc.c (get_doc_string, store_function_docstring):
1700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1701 (get_doc_string, Fsnarf_documentation):
1702 Use int, not EMACS_INT, where int is wide enough.
1703 (get_doc_string):
1704 Use SAFE_ALLOCA, not alloca.
1705 Check for overflow when converting EMACS_INT to off_t.
1706 * doprnt.c (doprnt):
1707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1708 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1709 Don't assume uid_t fits into fixnum.
1710 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1711 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1712 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1713 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1714 (general_insert_function)
1715 (Finsert_char, make_buffer_string, make_buffer_string_both)
1716 (update_buffer_properties, Fbuffer_substring)
1717 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1718 (Fsubst_char_in_region, check_translation)
1719 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1720 (transpose_markers, Ftranspose_regions):
1721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1722 (clip_to_bounds): Move to lisp.h as an inline function).
1723 (Fconstrain_to_field): Don't assume integers are nonnegative.
1724 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1725 (Fsubst_char_in_region, Fsave_restriction):
1726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1727 (Femacs_pid): Don't assume pid_t fits into fixnum.
1728 (lo_time): Use int, not EMACS_INT, when int suffices.
1729 (lisp_time_argument): Check for usec out of range.
1730 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1731 (Fuser_login_name, Fuser_full_name): Signal an error
1732 if a uid argument is out of range, rather than relying on
1733 undefined behavior.
c8d5c857
PE
1734 (Fformat_time_string): Remove now-unnecessary check.
1735 lisp_time_argument checks for out-of-range usec now.
243e0530 1736 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1737 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1738 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1739 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1740 (init_cmdargs, Fdump_emacs):
1741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1742 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1743 the bottom (typically) 32 bits of the fixnum.
1744 * eval.c (specpdl_size, call_debugger):
1745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1746 (when_entered_debugger, Fbacktrace_debug):
1747 Don't assume fixnum can fit in int.
1748 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1749 the object just before a buffer; this is not portable.
1750 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1751 (grow_specpdl, unbind_to):
1752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1753 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1754 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1755 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1756 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1757 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1759 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1760 (a_write, e_write):
1761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1762 (Fcopy_file, non_regular_nbytes, read_non_regular)
1763 (Finsert_file_contents):
1764 Use int, not EMACS_INT, where int is wide enough.
1765 (READ_BUF_SIZE): Verify that it fits in int.
1766 (Finsert_file_contents): Check that counts are in proper range,
1767 rather than assuming fixnums fit into ptrdiff_t etc.
1768 Don't assume fixnums fit into int.
125b3835 1769 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1770 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1771 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1772 (string_char_to_byte, string_byte_to_char)
1773 (string_make_multibyte, string_to_multibyte)
1774 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1775 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1776 (substring_both, Fdelete, internal_equal, Ffillarray)
1777 (Fclear_string, mapcar1)
1778 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1779 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1780 (larger_vector, make_hash_table, maybe_resize_hash_table)
1781 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1782 (Fmaphash, secure_hash):
1783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1784 (concat): Check for string index and length overflow.
1785 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1786 (Frequire):
1787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1788 (larger_vector): New API (vec, incr_min, size_max) replaces old
1789 one (vec, new_size, init). This catches size overflow.
1790 INIT was removed because it was always Qnil.
1791 All callers changed.
1792 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1793 the upper bound on a hash table index size.
1794 (make_hash_table, maybe_resize_hash_table): Use it.
1795 (secure_hash): Computer start_byte and end_byte only after
1796 they're known to be in ptrdiff_t range.
1797 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1798 (Ffont_get_glyphs, Ffont_at):
1799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1800 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1801 (Flist_fonts, Fopen_font):
1802 Don't assume fixnum can fit in int.
1803 (check_gstring): Don't assume index can fit in int.
1804 (font_match_p): Check that fixnum is a character, not a nonnegative
1805 fixnum, since the later code needs to stuff it into an int.
1806 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1807 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1808 conversion overflow issues.
1809 (Fopen_font): Check for integer out of range.
1810 (Ffont_get_glyphs): Don't assume index can fit in int.
1811 * font.h: Adjust decls to match defn changes elsewhere.
1812 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1813 integer overflow.
1814 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1815 printmax_t, where ptrdiff_t is wide enough.
1816 (Finternal_char_font):
1817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1818 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1819 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1820 (Fset_frame_position, x_set_frame_parameters)
1821 (x_set_line_spacing, x_set_border_width)
1822 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1823 Check that fixnums are in proper range for system types.
1824 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1826 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1827 Use SAFE_ALLOCA_LISP, not alloca.
1828 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1829 intptr_t is wide enough.
1830 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1831 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1832 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1833 Check for fixnum out of range.
1834 * ftfont.c (ftfont_list): Don't assume index fits in int.
1835 Check that fixnums are in proper range for system types.
1836 (ftfont_shape_by_flt):
1837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1838 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1840 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1841 Check that fixnums are in proper range for system types.
1842 * gnutls.h: Adjust decls to match defn changes elsewhere.
1843 * gtkutil.c (xg_dialog_run):
1844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1845 (update_frame_tool_bar):
1846 Check that fixnums are in proper range for system types.
1847 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1848 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1849 * indent.c (last_known_column, last_known_column_point):
1850 (current_column_bol_cache):
1851 (skip_invisible, current_column, check_display_width):
1852 (check_display_width, scan_for_column, current_column_1)
1853 (Findent_to, Fcurrent_indentation, position_indentation)
1854 (indented_beyond_p, Fmove_to_column, compute_motion):
1855 (Fcompute_motion, Fvertical_motion):
1856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1857 (last_known_column_modified): Use EMACS_INT, not int.
1858 (check_display_width):
1859 (Fcompute_motion):
1860 Check that fixnums and floats are in proper range for system types.
1861 (compute_motion): Don't assume index or fixnum fits in int.
1862 (compute_motion, Fcompute_motion):
1863 Use int, not EMACS_INT, when it is wide enough.
1864 (vmotion): Omit local var start_hpos that is always 0; that way
1865 we don't need to worry about overflow in expressions involving it.
1866 * indent.h: Adjust decls to match defn changes elsewhere.
1867 (struct position):
1868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1869 Use int, not EMACS_INT, where int is wide enough.
1870 Remove unused members ovstring_chars_done and tab_offset;
1871 all uses removed.
1872 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1873 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1874 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1875 (make_gap, copy_text, insert, insert_and_inherit)
1876 (insert_before_markers, insert_before_markers_and_inherit)
1877 (insert_1, count_combining_before, count_combining_after)
1878 (insert_1_both, insert_from_string)
1879 (insert_from_string_before_markers, insert_from_string_1)
1880 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1881 (adjust_after_replace, adjust_after_insert, replace_range)
1882 (replace_range_2, del_range, del_range_1, del_range_byte)
1883 (del_range_both, del_range_2, modify_region)
1884 (prepare_to_modify_buffer, signal_before_change)
1885 (signal_after_change, Fcombine_after_change_execute):
1886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1887 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1888 (balance_an_interval, split_interval_right, split_interval_left)
1889 (find_interval, next_interval, update_interval)
1890 (adjust_intervals_for_insertion, delete_node, delete_interval)
1891 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1892 (static_offset_intervals, offset_intervals)
1893 (merge_interval_right, merge_interval_left, make_new_interval)
1894 (graft_intervals_into_buffer, temp_set_point_both)
1895 (temp_set_point, set_point, adjust_for_invis_intang)
1896 (set_point_both, move_if_not_intangible, get_property_and_range)
1897 (get_local_map, copy_intervals, copy_intervals_to_string)
1898 (compare_string_intervals, set_intervals_multibyte_1):
1899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1900 * intervals.h: Adjust decls to match defn changes elsewhere.
1901 (struct interval):
1902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1903 * keyboard.c (this_command_key_count, this_single_command_key_start)
1904 (before_command_key_count, before_command_echo_length, echo_now)
1905 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1906 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1907 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1908 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1910 (last_non_minibuf_size, last_point_position, echo_truncate)
1911 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1912 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1913 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1914 (stuff_buffered_input):
1915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1916 (last_auto_save, command_loop_1, read_char):
1917 Use EMACS_INT, not int, to avoid integer overflow.
1918 (record_char): Avoid overflow in total_keys computation.
1919 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1920 * keyboard.h: Adjust decls to match defn changes elsewhere.
1921 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1922 (Fkey_description, Fdescribe_vector, Flookup_key):
1923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1924 (click_position): New function, to check that positions are in range.
1925 (Fcurrent_active_maps):
1926 (describe_command):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1928 (Faccessible_keymaps, Fkey_description):
1929 (preferred_sequence_p):
1930 Don't assume fixnum can fit into int.
1931 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1932 Check for integer overflow in size calculations.
1933 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1934 avoid mishandling large integers.
1935 * lisp.h: Adjust decls to match defn changes elsewhere.
1936 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1937 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1938 (struct Lisp_Marker):
1939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1940 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1941 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1942 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1943 All callers changed.
1944 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1945 Assume the arg has valid form, since it always does.
1946 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1947 unsigned integer system type.
1948 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1949 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1951 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1952 (duration_to_sec_usec): New decl.
1953 * lread.c (read_from_string_index, read_from_string_index_byte)
1954 (read_from_string_limit, readchar, unreadchar, openp)
1955 (read_internal_start, read1, oblookup):
1956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1957 (Fload, readevalloop, Feval_buffer, Feval_region):
1958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1959 (openp): Check for out-of-range argument to 'access'.
1960 (read1): Use int, not EMACS_INT, where int is wide enough.
1961 Don't assume fixnum fits into int.
6efdadfd 1962 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1963 (read_filtered_event): Use duration_to_sec_usec
1964 to do proper overflow checking on durations.
d311d28c
PE
1965 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1966 in size calculation.
1967 (Fexecute_kbd_macro):
1968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1969 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1970 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1971 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1972 (set_marker_both, set_marker_restricted_both, marker_position)
1973 (marker_byte_position, Fbuffer_has_markers_at):
1974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1975 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1976 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1977 It now merely ensures that the menu is large enough, without
1978 necessarily growing it, as this avoids some integer overflow issues.
1979 All callers changed.
1980 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1982 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1983 Use SAFE_ALLOCA_LISP, not alloca.
1984 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1985 to EMACS_INT. Check that fixnums are in proper range for system types.
1986 * minibuf.c (minibuf_prompt_width, string_to_object)
1987 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1988 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1990 (get_minibuffer, read_minibuf_unwind):
1991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1992 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1993 this simplifies overflow checking. All callers changed.
1994 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1995 (Ftest_completion):
1996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1997 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1998 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1999 Check that fixnums are in proper range for system types.
2000 (Fx_create_frame, Fx_show_tip):
2001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2002 * nsfont.m (ns_findfonts, nsfont_list_family):
2003 Don't assume fixnum fits in long.
2004 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2006 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2007 wide enough.
17fdb222 2008 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2010 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2011 (PRINTDECLARE, PRINTPREPARE):
2012 (strout, print_string):
2013 (print, print_preprocess, print_check_string_charset_prop)
2014 (print_object):
2015 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2016 (PRINTDECLARE):
2017 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2019 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2020 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2021 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2022 (print_error_message): Use SAFE_ALLOCA, not alloca.
2023 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2024 (print_depth, new_backquote_output, print_number_index):
2025 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2026 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2027 (Fset_process_window_size, Fformat_network_address)
2028 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2029 (sigchld_handler):
d311d28c 2030 Check that fixnums are in proper range for system types.
d44287d4 2031 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2032 Check for process-ids out of pid_t range rather than relying on
2033 undefined behavior.
e4d81efc 2034 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2035 (Fformat_network_address, read_process_output, send_process)
2036 (Fprocess_send_region, status_notify):
2037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2038 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2039 (wait_reading_process_output, read_process_output, exec_sentinel):
2040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2041 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2042 (Faccept_process_output): Use duration_to_sec_usec to do proper
2043 overflow checking on durations.
dde14581
PE
2044 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2045 Don't assume pid_t fits in int.
02481186
PE
2046 * process.h (struct Lisp_Process): Members tick and update_tick
2047 are now of type EMACS_INT, not int.
b62b53e8
PE
2048 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2049 configured --with-wide-int.
d311d28c
PE
2050 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2051 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2052 * search.c (looking_at_1, string_match_1):
2053 (fast_string_match, fast_c_string_match_ignore_case)
2054 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2055 (scan_newline, find_before_next_newline, search_command)
2056 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2057 (set_search_regs, wordify):
2058 (Freplace_match):
2059 (Fmatch_data):
2060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2061 (string_match_1, search_buffer, set_search_regs):
2062 (Fmatch_data):
2063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2064 (wordify): Check for overflow in size calculation.
2065 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2066 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2067 Check that fixnums are in proper range for system types.
2068 * sound.c (struct sound_device)
2069 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2071 (Fplay_sound_internal):
2072 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2073 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2074 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2075 (Fparse_partial_sexp):
2076 Don't assume fixnums can fit in int.
2077 (struct lisp_parse_state, find_start_pos, find_start_value)
2078 (find_start_value_byte, find_start_begv)
2079 (update_syntax_table, char_quoted, dec_bytepos)
2080 (find_defun_start, prev_char_comend_first, back_comment):
2081 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2082 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2084 (Finternal_describe_syntax_value): Check that match_lisp is a
2085 character, not an integer, since the code stuffs it into int.
2086 (scan_words, scan_sexps_forward):
2087 Check that fixnums are in proper range for system types.
2088 (Fforward_word):
2089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2090 (scan_sexps_forward):
2091 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2092 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2093 * syntax.h: Adjust decls to match defn changes elsewhere.
2094 (struct gl_state_s):
2095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2096 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2097 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2098 * sysdep.c (wait_for_termination_1, wait_for_termination)
2099 (interruptible_wait_for_termination, mkdir):
2100 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2101 (emacs_read, emacs_write):
2102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2103 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2104 and double all fit in int.
d311d28c
PE
2105 * term.c (set_tty_color_mode):
2106 Check that fixnums are in proper range for system types.
2107 * termhooks.h (struct input_event):
2108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2109 * textprop.c (validate_interval_range, interval_of)
2110 (Fadd_text_properties, set_text_properties_1)
2111 (Fremove_text_properties, Fremove_list_of_text_properties)
2112 (Ftext_property_any, Ftext_property_not_all)
2113 (copy_text_properties, text_property_list, extend_property_ranges)
2114 (verify_interval_modification):
2115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2116 (Fnext_single_char_property_change)
2117 (Fprevious_single_char_property_change):
2118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2119 (copy_text_properties):
2120 Check for integer overflow in index calculation.
d311d28c
PE
2121 * undo.c (last_boundary_position, record_point, record_insert)
2122 (record_delete, record_marker_adjustment, record_change)
2123 (record_property_change):
2124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2125 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2127 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2128 (Fx_hide_tip, Fx_file_dialog):
2129 * w32menu.c (set_frame_menubar):
2130 Use ptrdiff_t, not int, for consistency with rest of code.
2131 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2132 (select_window, Fdelete_other_windows_internal)
2133 (window_scroll_pixel_based, window_scroll_line_based)
2134 (Frecenter, Fset_window_configuration):
2135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2136 (Fset_window_hscroll, run_window_configuration_change_hook)
2137 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2138 (Fscroll_other_window, Frecenter):
d311d28c
PE
2139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2140 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2141 Don't assume fixnum fits in int.
2142 (Fset_window_scroll_bars):
2143 Check that fixnums are in proper range for system types.
2144 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2145 (string_pos, c_string_pos, number_of_chars, init_iterator)
2146 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2147 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2148 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2149 (face_before_or_after_it_pos, handle_invisible_prop)
2150 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2151 (display_prop_intangible_p, string_buffer_position_lim)
2152 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2153 (get_overlay_strings_1, get_overlay_strings)
2154 (iterate_out_of_display_property, forward_to_next_line_start)
2155 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2156 (get_next_display_element, set_iterator_to_next)
2157 (get_visually_first_element, compute_stop_pos_backwards)
2158 (handle_stop_backwards, next_element_from_buffer)
2159 (move_it_in_display_line_to, move_it_in_display_line)
2160 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2161 (add_to_log, message_dolog, message_log_check_duplicate)
2162 (message2, message2_nolog, message3, message3_nolog
2163 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2164 (current_message_1, truncate_echo_area, truncate_message_1)
2165 (set_message, set_message_1, store_mode_line_noprop)
2166 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2167 (text_outside_line_unchanged_p, check_point_in_composition)
2168 (reconsider_clip_changes)
2169 (redisplay_internal, set_cursor_from_row, try_scrolling)
2170 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2171 (redisplay_window, find_last_unchanged_at_beg_row)
2172 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2173 (trailing_whitespace_p, find_row_edges, display_line)
2174 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2175 (display_mode_element, store_mode_line_string)
2176 (pint2str, pint2hrstr, decode_mode_spec)
2177 (display_count_lines, display_string, draw_glyphs)
2178 (x_produce_glyphs, x_insert_glyphs)
2179 (rows_from_pos_range, mouse_face_from_buffer_pos)
2180 (fast_find_string_pos, mouse_face_from_string_pos)
2181 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2183 (safe_call, init_from_display_pos, handle_fontified_prop)
2184 (handle_single_display_spec, load_overlay_strings)
2185 (with_echo_area_buffer, setup_echo_area_for_printing)
2186 (display_echo_area, echo_area_display)
2187 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2188 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2189 (redisplay_window, dump_glyph_row, display_mode_line)
2190 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2191 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2193 (handle_single_display_spec, build_desired_tool_bar_string)
2194 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2195 (get_specified_cursor_type):
2196 Check that fixnums are in proper range for system types.
2197 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2198 (Flookup_image_map):
2199 Don't assume fixnums fit in int.
2200 (compare_overlay_entries):
2201 Avoid mishandling comparisons due to subtraction overflow.
2202 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2203 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2204 (handle_tool_bar_click):
2205 Use int, not unsigned, since we prefer signed and the signedness
2206 doesn't matter here.
2207 (get_next_display_element, next_element_from_display_vector):
2208 Use int, not EMACS_INT, when int is wide enough.
2209 (start_hourglass): Use duration_to_sec_usec to do proper
2210 overflow checking on durations.
2211 * xfaces.c (Fbitmap_spec_p):
2212 Check that fixnums are in proper range for system types.
2213 (compare_fonts_by_sort_order):
2214 Avoid mishandling comparisons due to subtraction overflow.
2215 (Fx_family_fonts, realize_basic_faces):
2216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2217 (Fx_family_fonts):
2218 Don't assume fixnum fits in int.
2219 Use SAFE_ALLOCA_LISP, not alloca.
2220 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2221 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2222 (face_at_buffer_position, face_for_overlay_string)
2223 (face_at_string_position):
2224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2225 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2226 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2227 (Fx_show_tip):
2228 Check that fixnums are in proper range for system types.
2229 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2230 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2232 (Fx_change_window_property): Don't assume fixnums fit in int.
2233 * xfont.c (xfont_chars_supported):
2234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2235 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2236 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2238 * xml.c (parse_region):
2239 * xrdb.c (magic_file_p):
2240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2241 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2242 (x_get_local_selection, x_reply_selection_request)
2243 (x_handle_selection_request, wait_for_property_change):
2244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2245 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2246 short is wide enough.
2247 (x_send_client_event): Don't assume fixnum fits in int.
2248 * xterm.c (x_x_to_emacs_modifiers):
2249 Don't assume EMACS_INT overflows nicely into int.
2250 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2251 may come from Lisp.
2252 (handle_one_xevent): NATNUMP can eval its arg twice.
2253 (x_connection_closed):
2254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2255 * xterm.h: Adjust decls to match defn changes elsewhere.
2256 (struct scroll_bar): Use struct vectorlike_header
2257 rather than rolling our own approximation.
2258 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2259
c6574eb5
GM
22602012-05-25 Glenn Morris <rgm@gnu.org>
2261
2262 * lisp.mk (lisp): Update for more files being compiled now.
2263
e8d32c7e
SM
22642012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2265
48def666
SM
2266 * lread.c: Remove `read_pure' which makes no difference.
2267 (read_pure): Remove var.
2268 (unreadpure): Remove function.
2269 (readevalloop): Don't call read_list with -1 flag.
2270 (read1, read_vector): Don't test read_pure any more.
2271 (read_list): Simplify.
2272
e8d32c7e
SM
2273 * fileio.c, character.h: Minor style tweaks.
2274
4b2addb7
DA
22752012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2276
2277 * window.h (clip_changed): Remove useless declaration.
2278
584461b2
JB
22792012-05-22 Juanma Barranquero <lekktu@gmail.com>
2280
2281 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2282 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2283
34374650
PE
22842012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2285
2286 Remove src/m/*.
2287 This directory predates autoconf and is no longer needed nowadays.
2288 Move its few remaining bits of functionality to where they're needed.
2289 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2290 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2291 * m/template.h: Remove.
2292 * Makefile.in (M_FILE): Remove. All uses removed.
2293 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2294 * lisp.h (USE_LSB_TAG):
2295 * mem-limits.h (EXCEEDS_LISP_PTR):
2296 Use VAL_MAX, not VALBITS, in #if.
2297 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2298 (EMACS_UINT): Define unconditionally now.
2299 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2300 (BITS_PER_EMACS_INT): New constants, replacing
2301 what used to be in config.h, but not useful in #if.
2302 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2303 define them any more.
2304 (VAL_MAX): New macro.
2305 (VALMASK): Use it.
2306 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2307 BITS_PER_EMACS_INT, in #if.
2308 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2309 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2310 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2311 * s/ms-w32.h (DATA_START):
2312 Move here from removed file m/intel386.h.
2313 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2314 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2315
261cb4bb
PE
23162012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2317
2318 Assume C89 or later.
2319 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2320 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2321 (xrealloc):
2322 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2323 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2324 * textprop.c, tparam.c (NULL): Remove.
2325 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2326 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2327 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2328 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2329 * xterm.c (input_signal_count): Assume volatile works.
2330
ff23cd9f
KB
23312012-05-21 Ken Brown <kbrown@cornell.edu>
2332
2333 * xgselect.c (xg_select): Fix first argument in call to 'select'
2334 (bug#11508).
2335
1b170bc6
KB
23362012-05-20 Ken Brown <kbrown@cornell.edu>
2337
2338 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2339 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2340
b2f4d39f
KB
23412012-05-19 Ken Brown <kbrown@cornell.edu>
2342
2343 * xfns.c (x_in_use): Remove `static' qualifier.
2344 * xterm.h (x_in_use): Declare.
2345 * xgselect.c: Include xterm.h.
2346 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2347 and `display_arg' (bug#9754).
2348
003fdae2
PE
23492012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2350
9232a6d9
PE
2351 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2352
003fdae2
PE
2353 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2354 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2355
784b56e2
EZ
23562012-05-18 Eli Zaretskii <eliz@gnu.org>
2357
2358 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2359
2360 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2361 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2362
2363 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2364 reference to image_cache->refcount.
2365 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2366
a0a79cde
JL
23672012-05-17 Juri Linkov <juri@jurta.org>
2368
2369 * search.c (Fword_search_regexp, Fword_search_backward)
2370 (Fword_search_forward, Fword_search_backward_lax)
2371 (Fword_search_forward_lax): Move functions to isearch.el
2372 (bug#10145, bug#11381).
2373
b0572523
PE
23742012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2377
9660f5fc
SM
23782012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2379
2380 * lread.c (init_obarray): Declare Qt and Qnil as special.
2381
4374de83
GM
23822012-05-14 Glenn Morris <rgm@gnu.org>
2383
2384 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2385 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2386
dc44c39a
PE
23872012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2388
078c97cb
PE
2389 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2390
dc44c39a
PE
2391 * unexaix.c: Port to more-recent AIX compilers.
2392 (report_error, report_error_1, make_hdr, copy_sym)
2393 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2394 Make arguments const char *, not char *, to avoid violations of C
2395 standard and to fix some AIX warnings reported by Gilles Pion.
2396
e18afed7 23972012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2398
2399 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2400 already have overlays loaded.
2401 (handle_single_display_spec): Before returning without displaying
2402 fringe bitmap, synchronize the bidi iterator with the main display
2403 iterator, by calling iterate_out_of_display_property.
2404 (iterate_out_of_display_property): Detect buffer iteration by
2405 testing that it->string is a Lisp string.
2406 (get_next_display_element): When the current object is exhausted,
2407 and there's something on it->stack, call set_iterator_to_next to
2408 proceed with what's on the stack, instead of returning zero.
2409 (set_iterator_to_next): If called at the end of a Lisp string,
2410 proceed to consider_string_end without incrementing string
2411 position. Don't increment display vector index past the end of
2412 the display vector. (Bug#11417)
c8fb9dc6
EZ
2413 (pos_visible_p): Don't report a position visible when move_it_to
2414 stopped at the last line of window, which happens to be scanned
2415 backwards by the bidi iteration. (Bug#11464)
ac268e67 2416
e18afed7 24172012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2418
2419 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2420 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2421 are on a TTY, and thus unable to display on the fringes.
2422 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2423 so we need to signal to the caller that this is a "replacing"
2424 display spec. This fixes display when the spec is invalid or we
2425 are on a TTY.
2426
e18afed7 24272012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2428
2429 * unexaix.c (make_hdr): Fix typo in prototype.
2430 This bug broke the build on AIX. Problem reported by Gilles Pion.
2431
9d0a235a
MA
24322012-05-14 Michael Albinus <michael.albinus@gmx.de>
2433
2434 * keyboard.c (kbd_buffer_get_event): Read special events also in
2435 batch mode. (Bug#11415)
2436
9e6b06ed
GM
24372012-05-12 Glenn Morris <rgm@gnu.org>
2438
2439 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2440
c1a1d7a3
EZ
24412012-05-12 Eli Zaretskii <eliz@gnu.org>
2442
2443 * lisp.mk (lisp): Add newcomment.elc.
2444
3fe7cdc8
GM
24452012-05-12 Glenn Morris <rgm@gnu.org>
2446
2447 * Makefile.in (MKDIR_P): New, set by configure.
2448 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2449
53f7d2c0
PE
24502012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 Remove unused function hourglass_started.
2453 * dispextern.h (hourglass_started):
2454 * w32fns.c (hourglass_started):
2455 * xdisp.c (hourglass_started): Remove.
2456
75aafb17
JB
24572012-05-10 Juanma Barranquero <lekktu@gmail.com>
2458
2459 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2460 Update dependencies.
2461
12959e8e
PE
24622012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2463
97107e2e
PE
2464 * xgselect.c (xg_select): Put maxfds+1 into a var.
2465 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2466
12959e8e
PE
2467 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2468
836d29b3
DA
24692012-05-10 Dave Abrahams <dave@boostpro.com>
2470
2471 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2472 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2473
5cb67954
MA
24742012-05-09 Michael Albinus <michael.albinus@gmx.de>
2475
2476 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2477 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2478 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2479 Initialize xd_registered_buses.
2480
3478ec45
PE
24812012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2482
b263a6b0
PE
2483 Untag more efficiently if USE_LSB_TAG.
2484 This is based on a proposal by YAMAMOTO Mitsuharu in
2485 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2486 For an admittedly artificial (nth 8000 longlist) benchmark on
2487 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2488 Emacs's overall text size by 1%.
2489 * lisp.h (XUNTAG): New macro.
2490 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2491 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2492 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2493 * eval.c (Fautoload):
2494 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2495 * frame.h (XFRAME): Use XUNTAG.
2496
3478ec45
PE
2497 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2498 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2499 Remove unportable assumptions about print widths of types like
2500 dbus_uint32_t.
2501 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2502 intptr_t when converting between pointer and integer, to avoid GCC
2503 warnings about wrong width.
2504
666b903b 25052012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2506
2507 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2508 stack for each reader_thread, instead of defaulting to 8MB
2509 determined by the linker. This avoids failures in creating
2510 subprocesses on Windows 7, see the discussion in this thread:
2511 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2512
b120cc17
JC
25132012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2514
2515 Fix up display of the *Minibuf-0* buffer in the mini window.
2516 * keyboard.c (read_char): Don't clear the echo area if there's no
2517 message to clear.
2518 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2519 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2520
9a4b36f8
MA
25212012-05-07 Michael Albinus <michael.albinus@gmx.de>
2522
2523 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2524 batch mode.
2525
e5f9458f
CY
25262012-05-06 Chong Yidong <cyd@gnu.org>
2527
2528 * lisp.mk (lisp): Update.
2529
eceeb5fc 25302012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2531
2532 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2533
71873e2b
SM
25342012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2535
2536 * data.c (PUT_ERROR): New macro.
2537 (syms_of_data): Use it. Add new error type `user-error'.
2538 * undo.c (user_error): New function.
2539 (Fprimitive_undo): Use it.
2540 * print.c (print_error_message): Adjust print style for `user-error'.
2541 * keyboard.c (user_error): New function.
2542 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2543
ab0fa4e4
PE
25442012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2545
2546 Do not limit current-time-string to years 1000..9999.
2547 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2548 (Fcurrent_time_string): Support any year that is supported by the
2549 underlying localtime representation. Don't use asctime, as it
2550 has undefined behavior for years outside the range -999..9999.
2551
7ed806a7
PE
25522012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 Fix race conditions involving setenv, gmtime, localtime, asctime.
2555 Without this fix, interrupts could mess up code that uses these
2556 nonreentrant functions, since setting TZ invalidates existing
2557 tm_zone or tzname values, and since most of these functions return
2558 pointers to static storage.
2559 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2560 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2561 Grow the critical sections to include not just invoking
2562 localtime/gmtime, but also accessing these functions' results
2563 including their tm_zone values if any, and any related TZ setting.
2564 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2565 so that the struct tm is saved in the critical section.
2566 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2567 motivated by the fact that memory allocation needs to be outside
2568 the critical section.
2569
0c16dfed
DA
25702012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2571
2572 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2573 with RESET_INTERVAL.
2574
2575 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2576 Remove duplicated buffer name initialization.
2577
3f83ace8
JM
25782012-05-02 Jim Meyering <jim@meyering.net>
2579
2580 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2581
c7b8541e
JM
2582 * xfns.c (x_window): Use xstrdup (Bug#11375).
2583
90207a15 25842012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2585
2586 * xdisp.c (pos_visible_p): If already at a newline from the
2587 display string before the 'while' loop, don't walk back the glyphs
2588 from it3.glyph_row. Solves assertion violation when the display
2589 string begins with a newline (egg.el). (Bug#11367)
2590
b593d6a9
AH
25912012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2592
2593 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2594 Move to simple.el.
2595
4737362e
GM
25962012-05-01 Glenn Morris <rgm@gnu.org>
2597
99cf43f9
GM
2598 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2599 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2600 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2601 All were removed before 23.1.
2602
9311dcff
GM
2603 * dispnew.c: Remove HAVE_LIBNCURSES test;
2604 it is always true on relevant platforms.
2605
4d5c6349
GM
2606 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2607 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2608
4737362e
GM
2609 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2610
74dd3a6b
AS
26112012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2612
2613 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2614 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2615 Remove.
2616
13c379ee
PE
26172012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2618
2619 Do not avoid creating empty evaporating overlays (Bug#9642).
2620 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2621 That is, do not delete an evaporating overlay if it becomes
2622 empty after its bounds are adjusted to fit within its buffer.
2623 This fix caused other problems, and I'm reverting it until we get
2624 to the bottom of them.
2625
a8e7d6d7 26262012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2627
2628 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2629
a8e7d6d7 26302012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2631
2632 * xdisp.c (pos_visible_p): If the window start position is beyond
2633 ZV, start the display from buffer beginning. Prevents assertion
2634 violation in init_iterator when the minibuffer window is scrolled
2635 via the scroll bar.
2636
2637 * window.c (window_scroll_pixel_based): Likewise.
2638
a8e7d6d7 26392012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2640
2641 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2642
a8e7d6d7 26432012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2644
2645 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2646 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2647
a8e7d6d7 26482012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2649
b593d6a9
AH
2650 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2651 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2652
1c6900d9
EZ
26532012-04-26 Eli Zaretskii <eliz@gnu.org>
2654
4c3fa1d9
EZ
2655 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2656 display element, check also the underlying string or buffer
2657 character. (Bug#11341)
2658
1c6900d9
EZ
2659 * w32menu.c: Include w32heap.h.
2660 (add_menu_item): If the call to AppendMenuW (via
2661 unicode_append_menu) fails, disable Unicode menus only if we are
2662 running on Windows 9X/Me.
2663
42bf8205
AS
26642012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2665
2666 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2667 (xgetint): Add missing shift for LSB tags.
2668
b1bac16e
MR
26692012-04-24 Martin Rudalics <rudalics@gmx.at>
2670
2671 * keyboard.c (read_char): Don't wipe echo area for select window
2672 events: These might get delayed via `mouse-autoselect-window'
2673 (Bug#11304).
2674
d69621cc
JB
26752012-04-24 Juanma Barranquero <lekktu@gmail.com>
2676
2677 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2678 manipulation of :loaded-from data.
2679
02fd101b
JB
26802012-04-23 Juanma Barranquero <lekktu@gmail.com>
2681
2682 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2683 now a cons (bug#11311).
2684
888bec30
PE
26852012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2686
89a438bd
PE
2687 Do not create empty overlays with the evaporate property (Bug#9642).
2688 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2689 if it becomes empty after its bounds are adjusted to fit within
2690 its buffer. Without this fix, in a nonempty buffer (let ((o
2691 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2692 yields an empty overlay that has the evaporate property, which is
2693 not supposed to happen.
2694
1068fe4d
PE
2695 Fix minor GTK3 problems found by static checking.
2696 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2697 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2698 (struct _EmacsFixedClass, emacs_fixed_get_type):
2699 Move decls here from emacsgtkfixed.h, since they needn't be public.
2700 (emacs_fixed_get_type): Now static.
2701 (emacs_fixed_class_init): Omit unused local.
2702 (emacs_fixed_child_type): Remove; unused.
2703 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2704 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2705 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2706 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2707 (EMACS_FIXED_GET_CLASS): Remove; unused.
2708 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2709
888bec30
PE
2710 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2711 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2712
de85e130
PE
27132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2714
d0baac98 2715 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2716 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2717 (__malloc_size_t, __malloc_ptrdiff_t):
2718 Remove. All uses removed, replaced by the definiens if needed,
2719 since we can assume C89 or better now.
2720 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2721 (protect_malloc_state, align, get_contiguous_space)
2722 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2723 (malloc_atfork_handler_child, malloc_enable_thread)
2724 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2725 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2726 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2727 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2728 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2729 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2730 Define using prototypes, not old style.
2731 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2732 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2733 (align): Don't assume that signed integer overflow wraps around.
2734 Omit unused local var.
2735 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2736 (_free_internal_nolock, memalign, mallochook, reallochook):
2737 Omit no-longer-needed casts.
2738 (valloc): Use getpagesize, not __getpagesize.
2739 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2740 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2741
de85e130
PE
2742 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2743
dcbf5805
MA
27442012-04-22 Michael Albinus <michael.albinus@gmx.de>
2745
2746 Move functions from C to Lisp. Make non-blocking method calls
2747 the default. Implement further D-Bus standard interfaces.
2748
2749 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2750 (QCdbus_request_name_allow_replacement)
2751 (QCdbus_request_name_replace_existing)
2752 (QCdbus_request_name_do_not_queue)
2753 (QCdbus_request_name_reply_primary_owner)
2754 (QCdbus_request_name_reply_in_queue)
2755 (QCdbus_request_name_reply_exists)
2756 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2757 (QCdbus_registered_serial, QCdbus_registered_method)
2758 (QCdbus_registered_signal): New Lisp objects.
2759 (XD_DEBUG_MESSAGE): Use sizeof.
2760 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2761 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2762 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2763 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2764 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2765 (xd_signature, xd_append_arg): Allow float for integer types.
2766 (xd_get_connection_references): New function.
b593d6a9
AH
2767 (xd_get_connection_address): Rename from xd_initialize.
2768 Return cached address.
dcbf5805
MA
2769 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2770 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2771 level.
2772 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2773 Return number of refcounts.
dcbf5805
MA
2774 (Fdbus_get_unique_name): Make stronger parameter check.
2775 (Fdbus_message_internal): New defun.
2776 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2777 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2778 (Fdbus_send_signal, Fdbus_register_service)
2779 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2780 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2781 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2782 (Vdbus_compiled_version, Vdbus_runtime_version)
2783 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2784 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2785 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2786 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2787 Adapt docstring.
dcbf5805 2788
52828e02
PE
27892012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2790
da05bc4c
PE
2791 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2792 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2793 Do not assume ptrdiff_t is the same width as 'int'.
2794
52828e02
PE
2795 * alloc.c: Handle unusual debugging option combinations.
2796 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2797 since the two debugging options are incompatible.
2798 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2799 is defined.
2800 (mem_init, mem_insert, mem_insert_fixup):
2801 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2802 (NEED_MEM_INSERT): Remove; no longer needed.
2803
f01769f9
LL
28042012-04-22 Leo Liu <sdl.web@gmail.com>
2805
2806 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2807
5790543d
PE
28082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 * sysdep.c [__FreeBSD__]: Minor cleanups.
2811 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2812 Use Emacs indenting style more consistently. Avoid some casts.
2813 Use 'double' consistently rather than mixing 'float' and 'double'.
2814
b91b7e4d
EW
28152012-04-21 Eduard Wiebe <usenet@pusto.de>
2816
b593d6a9
AH
2817 * sysdep.c (list_system_processes, system_process_attributes):
2818 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2819
6114eb15
AS
28202012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2821
2822 * lisp.mk (lisp): Update.
2823
2f38dff7
PE
28242012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2827 It is never used otherwise.
2828
4ae29f89
SM
28292012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2830
2831 * print.c (print_preprocess): Only check print_depth if print-circle
2832 is nil.
2833 (print_object): Check for cycles even when print-circle is nil and
2834 print-gensym is t, but only check print_depth if print-circle is nil.
2835
f30d612a
CY
28362012-04-20 Chong Yidong <cyd@gnu.org>
2837
2838 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2839 set the status to "failed" and ensure that sentinel is run.
2840
c07a4c0b 28412012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2842
2843 * process.c (Fset_process_inherit_coding_system_flag)
2844 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2845 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2846
c07a4c0b 28472012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2848
2849 * xdisp.c (string_buffer_position_lim): Limit starting position to
2850 BEGV.
2851 (set_cursor_from_row): If called for a mode-line or header-line
2852 row, return zero immediately.
2853 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2854 farther than the first row after the header line, if any.
2855 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2856 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2857
c07a4c0b 28582012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2859
4ae29f89
SM
2860 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2861 (bug#11238).
ad3a2b41 2862
c07a4c0b 28632012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 28642012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2865
2866 configure: new option --enable-gcc-warnings (Bug#11207)
2867 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2868 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2869 (ALL_CFLAGS): Use new macros rather than old.
2870 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2871 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2872 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2873 -Wunused-result, -Wunused-variable. This should go away once
2874 the Emacs and Gnulib regex code is merged.
2875 (xmalloc, xrealloc): Now static.
2876
aba027e8
PE
28772012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2878
2879 * dired.c (Fsystem_groups): Remove unused local.
2880
e5a36063
GM
28812012-04-17 Glenn Morris <rgm@gnu.org>
2882
2883 * dired.c (Fsystem_users): Doc fix.
2884
316411f0
DA
28852012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2886
2887 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2888 (syms_of_dired): Add them.
2889
9426aba4
PE
28902012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2891
b62a57be
PE
2892 Fix minor alloc.c problems found by static checking.
2893 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2894 New extern decls, to avoid calling undeclared functions.
2895 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2896 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2897 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2898 (NEED_MEM_INSERT): New macro.
2899 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2900 Remove one incorrect comment and fix another.
b62a57be 2901
3539f31f
PE
2902 Fix minor ralloc.c problems found by static checking.
2903 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2904 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2905 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2906 (r_alloc_sbrk): Now static.
2907
a041960a
PE
2908 Improve ralloc.c interface checking.
2909 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2910 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2911 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2912 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2913 [REL_ALLOC]: ... to here, to check interface.
2914 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2915 Remove decls. This fixes an "It stinks!".
2916
9426aba4
PE
2917 * alloc.c (which_symbols): Fix alignment issue / type clash.
2918
d55c12ed
AS
29192012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2920
2921 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2922 (struct Lisp_Misc_Any): Likewise.
2923 (struct Lisp_Free): Likewise.
2924 * alloc.c (union aligned_Lisp_Symbol): Define.
2925 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2926 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2927 (union aligned_Lisp_Misc): Define.
2928 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2929 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2930 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2931
b948ce8b
PE
29322012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2933
2934 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2935 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2936 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2937 * s/netbsd.h, s/sol2-6.h:
2938 Remove definition of GC_MARK_STACK, since the default now works.
2939 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2940 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2941 no longer the default.
2942 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2943
35dc09a1 29442012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2945
35dc09a1
GM
2946 * lread.c (lisp_file_lexically_bound_p):
2947 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2948
35dc09a1
GM
29492012-04-14 Eli Zaretskii <eliz@gnu.org>
2950
2951 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2952 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2953
29542012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2955
2956 * nsterm.m (constrainFrameRect): Always constrain when there is only
2957 one screen (Bug#10962).
2958
bcd86815
KB
29592012-04-13 Ken Brown <kbrown@cornell.edu>
2960
2961 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2962
c25df26e
RT
29632012-04-13 Reuben Thomas <rrt@sc3d.org>
2964
2965 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2966
0fc59f1e
DC
29672012-04-11 Daniel Colascione <dancol@dancol.org>
2968
2969 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2970 against is gone. It's better to use vfork now so that when Cygwin
2971 gains a new, working vfork, we use it automatically (bug#10398).
2972
de8c03dc
SM
29732012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2974
2975 * window.c (save_window_save): Obey window-point-insertion-type.
2976
2f097256
GM
29772012-04-11 Glenn Morris <rgm@gnu.org>
2978
2979 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2980
453b951e
SM
29812012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2982
2983 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2984
75f1671a 29852012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2986
2987 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2988 (force_quit_count): New var.
2989 (handle_interrupt): Use it.
2990
2a8ce227
JB
29912012-04-10 Juanma Barranquero <lekktu@gmail.com>
2992
2993 * w32.c (w32_delayed_load): Record the full path of the library
2994 being loaded (bug#10424).
2995
935396c0
GM
29962012-04-09 Glenn Morris <rgm@gnu.org>
2997
05920a43
GM
2998 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2999 not just in the obarray, before snarfing them. (Bug#11036)
3000
935396c0
GM
3001 * Makefile.in ($(leimdir)/leim-list.el):
3002 Pass EMACS rather than BUILT_EMACS.
3003
a18ecafa
TZ
30042012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3005
3006 * process.c (make_process):
3007 * process.h: Add integer `gnutls_handshakes_tried' member to
3008 process struct.
3009
6bbef4e5
JC
3010 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3011 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3012
3013 * gnutls.c (gnutls_log_function2i): Convenience log function.
3014 (emacs_gnutls_read): Use new log functions,
3015 `gnutls_handshakes_tried' process member, and
3016 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3017 attempts per process (connection).
3018
b4d3bc10
CY
30192012-04-09 Chong Yidong <cyd@gnu.org>
3020
3021 * eval.c (Fuser_variable_p, user_variable_p_eh)
3022 (lisp_indirect_variable): Functions deleted.
3023 (Fdefvar): Caller changed.
3024
3025 * callint.c (Finteractive, Fcall_interactively):
3026 * minibuf.c (Fread_variable): Callers changed.
3027
70f4d973
EZ
30282012-04-09 Eli Zaretskii <eliz@gnu.org>
3029
3030 * xdisp.c (set_cursor_from_row): If the display string appears in
3031 the buffer at position that is closer to point than the position
3032 after the display string, display the cursor on the first glyph of
3033 the display string. Fixes cursor display when a 'display' text
3034 property immediately follows invisible text. (Bug#11094)
3035
cb3c2e3e
PE
30362012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 composite.c: use 'double' consistently
3039 * composite.c (get_composition_id): Use 'double' consistently
3040 instead of converting 'float' to 'double' and vice versa; this is
3041 easier to understand and avoids a GCC warning.
3042
fd06db5d
GM
30432012-04-09 Glenn Morris <rgm@gnu.org>
3044
50fe702a
GM
3045 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3046 preparation for dumping it with emacs. (Bug#4789)
3047 (leimdir): New variable.
3048 ($(leimdir)/leim-list.el): New rule.
3049 (emacs$(EXEEXT)): Depend on leim-list.el.
3050
fd06db5d
GM
3051 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3052 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3053 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3054
55c131ee
AS
30552012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3056
3057 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3058 proper alignment.
3059
9209588f
JB
30602012-04-07 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3063 Remove unused local variable.
3064
e3fb2efb
PE
30652012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3066
3067 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3068 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3069 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3070 objects, as mark_maybe_pointer will catch them otherwise.
3071 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3072 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3073
b5385551
PE
30742012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3075
3076 Fix typo that broke non-Windows builds.
3077 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3078
9078ead6
EZ
30792012-04-07 Eli Zaretskii <eliz@gnu.org>
3080
3081 Support building on MS-Windows with libxml2.
3082
3083 * makefile.w32-in (OBJ2): Add xml.$(O).
3084 (GLOBAL_SOURCES): Add xml.c.
3085 ($(BLD)/xml.$(O)): New dependency list.
3086
3087 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3088 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3089 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3090 [!WINDOWSNT]: New macros.
3091 (init_libxml2_functions, libxml2_loaded_p): New functions.
3092 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3093 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3094 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3095 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3096 linked in).
6bbef4e5
JC
3097 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3098 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3099 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3100
3101 * emacs.c: Don't include libxml/parser.h.
3102 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3103 xmlCleanupParser directly.
3104
3105 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3106
3811fdf3
EZ
31072012-04-07 Eli Zaretskii <eliz@gnu.org>
3108
3109 * indent.c (Fvertical_motion): If there is a display string at
3110 point, use it.vpos to compute how many lines to backtrack after
3111 move_it_to point. (Bug#11133)
3112
2f8e16b2
EZ
31132012-04-06 Eli Zaretskii <eliz@gnu.org>
3114
3115 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3116 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3117 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3118 macros related to unification of CJK characters. For the details,
3119 see the discussion following the message here:
3120 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3121
3d439cd1
CY
31222012-04-04 Chong Yidong <cyd@gnu.org>
3123
3124 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3125
8bc53d00
EZ
31262012-04-01 Eli Zaretskii <eliz@gnu.org>
3127
3128 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3129 instead of alloca. (Bug#11138)
3130
3b0512a3
AS
31312012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3132
3133 * w32menu.c (is_simple_dialog): Properly check lisp types.
3134 (Bug#11141)
3135
8427ddd2
EZ
31362012-03-31 Eli Zaretskii <eliz@gnu.org>
3137
979022ef
EZ
3138 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3139 position we get to after a call to move_it_to fails the
3140 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3141 only if we wind up in a string from display property. (Bug#11063)
3142
a6b1c7cc
EZ
3143 * window.c (Fdelete_other_windows_internal): Invalidate the row
3144 and column information about mouse highlight, so that redisplay
3145 restores it after reallocating the glyph matrices. (Bug#7464)
3146
8427ddd2
EZ
3147 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3148 string comes from a `display' text property, use the buffer
3149 position of that property as if we actually saw that position in
3150 the row's glyphs.
697ba24b
EZ
3151 (move_it_by_lines): Remove the assertion that
3152 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3153 violated when there's a before-string at the beginning of a line.
3154 (Bug#11063)
8427ddd2 3155
65a0a738
EZ
31562012-03-30 Eli Zaretskii <eliz@gnu.org>
3157
3158 * xdisp.c (append_space_for_newline): If the default face was
3159 remapped, use the remapped face for the appended newline.
3160 (extend_face_to_end_of_line): Use the remapped default face for
3161 extending the face to the end of the line.
3162 (display_line): Call extend_face_to_end_of_line when the default
3163 face was remapped. (Bug#11068)
3164
581355cc
EZ
31652012-03-29 Eli Zaretskii <eliz@gnu.org>
3166
3167 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3168
e8fc049f
SM
31692012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3170
3171 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3172
4fb9a543
GM
31732012-03-27 Glenn Morris <rgm@gnu.org>
3174
3175 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3176 Doc fixes.
3177
679910f1
KH
31782012-03-26 Kenichi Handa <handa@m17n.org>
3179
3180 * dispextern.h (struct glyph): Fix previous change. Change the
3181 bit length of glyphless.ch to 25 (Bug#11082).
3182
90d49b7f
CY
31832012-03-26 Chong Yidong <cyd@gnu.org>
3184
3185 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3186 (command_loop_1): Use it; inhibit selection update for
3187 handle-select-window too (Bug#8996).
3188
f514f6f0
FP
31892012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3190
e8fc049f 3191 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3192
bf43fa51
KH
31932012-03-25 Kenichi Handa <handa@m17n.org>
3194
3195 * dispextern.h (struct glyph): Change the bit length of
3196 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3197
8a0c01dd
EZ
31982012-03-24 Eli Zaretskii <eliz@gnu.org>
3199
3200 * s/ms-w32.h (tzname): Include time.h before redirecting to
3201 _tzname. Fixes the MSVC build. (Bug#9960)
3202
7d1c3a76
AS
32032012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3204
8ed79523
AS
3205 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3206 characters.
3207
7d1c3a76
AS
3208 * xterm.c (XTread_socket): Only modify handling_signal if
3209 !SYNC_INPUT. (Bug#11080)
3210
e99a9b8b
EZ
32112012-03-23 Eli Zaretskii <eliz@gnu.org>
3212
3213 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3214 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3215 when fetching a multibyte character consumes more bytes than
3216 CHAR_BYTES returns, due to unification of CJK characters in
3217 string_char. (Bug#11073)
3218
5063c0e1
TN
32192012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3220
3221 * process.c (wait_reading_process_output): Handle pty disconnect
3222 by refraining from sending oneself a SIGCHLD (bug#10933).
3223
9f851fbd
CY
32242012-03-22 Chong Yidong <cyd@gnu.org>
3225
3226 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3227
5063c0e1 3228 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3229 Mark string as coming from a prefix property.
3230 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3231 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3232
fb5b8aca
CY
32332012-03-21 Chong Yidong <cyd@gnu.org>
3234
3235 * xfaces.c (Vface_remapping_alist): Doc fix.
3236
62356a1b
EZ
32372012-03-20 Eli Zaretskii <eliz@gnu.org>
3238
3239 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3240 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3241 Doc fixes.
62356a1b 3242
025de85b
CY
32432012-03-20 Chong Yidong <cyd@gnu.org>
3244
3245 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3246 to reflect default non-nil value of redisplay-dont-pause.
3247
4827f94e
KH
32482012-03-19 Kenichi Handa <handa@m17n.org>
3249
3250 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3251 it fit in a valid range (Bug#11003).
3252
e50a24a2
EZ
32532012-03-18 Eli Zaretskii <eliz@gnu.org>
3254
3255 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3256 that is not from display property, accept the row as a "cursor
3257 row" if one of the string's character has a non-nil `cursor'
3258 property. Fixes cursor positioning when there are newlines in
3259 overlay strings, e.g. in icomplete.el. (Bug#11035)
3260
9af5ed87
PE
32612012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3262
3263 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3264
d1f55f16
CY
32652012-03-12 Chong Yidong <cyd@gnu.org>
3266
3267 * eval.c (inhibit_lisp_code): Rename from
3268 inhibit_window_configuration_change_hook; move from window.c.
3269
3270 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3271 * window.c (run_window_configuration_change_hook)
3272 (syms_of_window): Callers changed.
3273
66c5eebd
CY
32742012-03-11 Chong Yidong <cyd@gnu.org>
3275
413df973
CY
3276 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3277
66c5eebd
CY
3278 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3279
1de11f56
CY
32802012-03-10 Chong Yidong <cyd@gnu.org>
3281
3282 * frame.c (other_visible_frames): Don't assume the selected frame
3283 is visible (Bug#10955).
3284
cae07000
SM
32852012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3286
3287 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3288
89c94350
JD
32892012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3292 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3293 zero (Bug#10954).
3294
999dd333
GM
32952012-03-03 Glenn Morris <rgm@gnu.org>
3296
01a6dcc8 3297 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3298
de0100f2
EZ
32992012-03-02 Eli Zaretskii <eliz@gnu.org>
3300
3301 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3302 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3303 (redisplay_window, next_element_from_string): Fix typos in
3304 comments.
3e441275
EZ
3305 (redisplay_window): Pass to move_it_vertically the margin in
3306 pixels, not in screen lines.
de0100f2 3307
96a72ee9
GM
33082012-03-02 Glenn Morris <rgm@gnu.org>
3309
3310 * buffer.c (buffer-list-update-hook): Doc fix.
3311
312508d7
EZ
33122012-02-29 Eli Zaretskii <eliz@gnu.org>
3313
3314 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3315 push_it before setting up the iterator for the first overlay
3316 string, even if we have an empty string loaded.
3317 (next_overlay_string): If there's an empty string on the iterator
3318 stack, pop the stack. (Bug#10903)
3319
27f3c637
PE
33202012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3321
3322 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3323 Suggested by Stefan Monnier in
3324 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3325 * alloc.c (widen_to_Lisp_Object): New static function.
3326 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3327 and widening them to Lisp_Objects. This would work even if
3328 USE_LSB_TAG is defined and wide integers are used, which might
3329 happen in a future version of Emacs.
3330
3c9dfce6
CY
33312012-02-25 Chong Yidong <cyd@gnu.org>
3332
fa74b241
CY
3333 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3334 Doc fix.
3335
3c9dfce6
CY
3336 * xselect.c (Fx_selection_exists_p): Doc fix.
3337 (x_clipboard_manager_save_all): Print an informative message
3338 before saving to clipboard manager.
3339
9486df08
CY
33402012-02-24 Chong Yidong <cyd@gnu.org>
3341
3342 * keyboard.c (process_special_events): Handle all X selection
3343 requests in kbd_buffer, not just the next one (Bug#8869).
3344
f01d3321
CY
33452012-02-23 Chong Yidong <cyd@gnu.org>
3346
3347 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3348 call when setting menu-bar-lines and tool-bar-lines parameters.
3349 (unwind_create_frame_1): New helper function.
3350
3351 * window.c (inhibit_window_configuration_change_hook): New var.
3352 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3353 (syms_of_window): Initialize it.
f01d3321 3354
86b847b6
CY
33552012-02-22 Chong Yidong <cyd@gnu.org>
3356
3357 * xterm.c (x_draw_image_relief): Add missing type check for
3358 Vtool_bar_button_margin (Bug#10743).
3359
a59225b1
CY
33602012-02-21 Chong Yidong <cyd@gnu.org>
3361
3362 * fileio.c (Vfile_name_handler_alist): Doc fix.
3363
3364 * buffer.c (Fget_file_buffer): Protect against invalid file
3365 handler return value.
3366
310f5bd4
PE
33672012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3368
cb3a28cc
PE
3369 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3370 when computing $valmask.
3371
310f5bd4
PE
3372 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3373 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3374 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3375 It's useless in that case, and it can cause problems on hosts
3376 that allocate halves of EMACS_INT values separately.
3377 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3378 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3379 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3380 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3381 it avoids undefined behavior on hosts where shifting right by more
3382 than the word width has undefined behavior.
3383
2375c96a
CY
33842012-02-19 Chong Yidong <cyd@gnu.org>
3385
3386 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3387 (Funhandled_file_name_directory, Ffile_name_as_directory)
3388 (Fdirectory_file_name, Fexpand_file_name)
3389 (Fsubstitute_in_file_name): Protect against invalid file handler
3390 return values (Bug#10845).
3391
3eb49e71
EZ
33922012-02-18 Eli Zaretskii <eliz@gnu.org>
3393
3394 * .gdbinit (pitx): Fix incorrect references to fields of the
3395 iterator stack.
3396
7b926f3f
CY
33972012-02-17 Chong Yidong <cyd@gnu.org>
3398
3399 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3400
11273115
PE
34012012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3402
3403 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3404 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3405
c3a70e2b
CY
34062012-02-15 Chong Yidong <cyd@gnu.org>
3407
3408 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3409 marked as special. Also, starting docstrings with * is obsolete.
3410
0ca43699
AS
34112012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3412
3413 * gnutls.c (emacs_gnutls_write): Fix last change.
3414
2e8f3c56
LI
34152012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3416
3417 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3418 send_process.
3419
af70074f
SM
34202012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3421
3422 * keymap.c (Fsingle_key_description): Handle char ranges.
3423
95986d52
CY
34242012-02-12 Chong Yidong <cyd@gnu.org>
3425
afd83bd1
CY
3426 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3427 as that creates a dangerous corner case.
3428
95986d52
CY
3429 * window.c (Fdelete_window_internal): Invalidate the mouse
3430 highlight (Bug#9904).
3431
bd7da63e
GM
34322012-02-12 Glenn Morris <rgm@gnu.org>
3433
3434 * xselect.c (Fx_own_selection_internal)
3435 (Fx_get_selection_internal, Fx_disown_selection_internal)
3436 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3437 * nsselect.m (Fx_own_selection_internal)
3438 (Fx_disown_selection_internal, Fx_selection_exists_p)
3439 (Fx_selection_owner_p, Fx_get_selection_internal):
3440 Sync docs and argument specs with the xselect.c versions.
3441
77abcbc2
LI
34422012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3443
3444 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3445
90b671e2
EZ
34462012-02-11 Eli Zaretskii <eliz@gnu.org>
3447
1c0ca0b7
EZ
3448 * w32select.c (Fx_selection_exists_p): Sync doc string and
3449 argument list with xselect.c. (Bug#10783)
3450
3451 * w16select.c (Fx_selection_exists_p): Sync doc string and
3452 argument list with xselect.c. (Bug#10783)
90b671e2 3453
49241268
GM
34542012-02-10 Glenn Morris <rgm@gnu.org>
3455
3456 * fns.c (Fsecure_hash): Doc fix.
3457
f998bbe7 34582012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3459
3460 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3461
0992bd9c
CY
34622012-02-07 Chong Yidong <cyd@gnu.org>
3463
3464 * buffer.c (Fbuffer_local_variables)
3465 (buffer_lisp_local_variables): Handle unbound vars correctly;
3466 don't let Qunbound leak into Lisp.
3467
af008560
GM
34682012-02-07 Glenn Morris <rgm@gnu.org>
3469
dd605cc4
GM
3470 * image.c (Fimagemagick_types): Doc fix.
3471
af008560
GM
3472 * image.c (imagemagick-render-type): Change it from a lisp object
3473 to an integer. Move the doc here from the lisp manual.
3474 Treat all values not equal to 0 the same.
3475
1449fa1d
CY
34762012-02-06 Chong Yidong <cyd@gnu.org>
3477
3478 * doc.c (store_function_docstring): Avoid applying docstring of
3479 alias to base function (Bug#2603).
3480
3723ec07
AS
34812012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3482
3483 * .gdbinit (pp1, pv1): Remove redundant defines.
3484 (pr): Use pp.
3485
79c1cc1e
CY
34862012-02-04 Chong Yidong <cyd@gnu.org>
3487
3488 * nsterm.m: Declare a global (Bug#10694).
3489
d7f29f8e
EZ
34902012-02-04 Eli Zaretskii <eliz@gnu.org>
3491
cae07000
SM
3492 * w32.c (get_emacs_configuration_options):
3493 Include --enable-checking, if specified, in the return value.
d7f29f8e 3494
3b95a6f9
MR
34952012-02-04 Martin Rudalics <rudalics@gmx.at>
3496
3497 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3498 after rounding frame sizes. (Bug#9723)
3499
d6fa96a6
EZ
35002012-02-04 Eli Zaretskii <eliz@gnu.org>
3501
3502 * keyboard.c (adjust_point_for_property): Don't position point
3503 before BEGV. (Bug#10696)
3504
df0b2940
PE
35052012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 Handle overflow when computing char display width (Bug#9496).
3508 * character.c (char_width): Return EMACS_INT, not int.
3509 (char_width, c_string_width): Check for overflow when
3510 computing the width; this is possible now that individual
3511 characters can have unbounded width. Problem introduced
3512 by merge from Emacs 23 on 2012-01-19.
3513
6bee44d6
MA
35142012-02-02 Michael Albinus <michael.albinus@gmx.de>
3515
3516 * dbusbind.c (Fdbus_register_method): Mention the return value
3517 :ignore in the docstring.
3518
44f92739
GM
35192012-02-02 Glenn Morris <rgm@gnu.org>
3520
1b9f60cc
GM
3521 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3522
44f92739
GM
3523 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3524 Unconditionally set to t. (Bug#10673)
3525 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3526 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3527 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3528
c5d3843c
KH
35292012-02-02 Kenichi Handa <handa@m17n.org>
3530
3531 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3532 0, do not call append_composite_glyph.
3533
159462d4 35342012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3535
3536 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3537 NULL (Bug#6988).
3538 (x_produce_glyphs): If the component of a composition is a null
3539 string, set it->pixel_width to 1 to avoid zero-width glyph.
3540
78cef877
EZ
35412012-02-01 Eli Zaretskii <eliz@gnu.org>
3542
3543 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3544 first 2 arguments are identical. This makes inserting large
3545 output from a subprocess an order of magnitude faster on
3546 MS-Windows, where all sbrk'ed memory is always contiguous.
3547
97897668
GM
35482012-01-31 Glenn Morris <rgm@gnu.org>
3549
3550 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3551 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3552 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3553
31fd3586
GM
35542012-01-29 Glenn Morris <rgm@gnu.org>
3555
3556 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3557
0e24a8b2
CY
35582012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3559
3560 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3561
cc0adcb0
CY
35622012-01-28 Chong Yidong <cyd@gnu.org>
3563
3564 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3565
acc28cb9
CY
35662012-01-26 Chong Yidong <cyd@gnu.org>
3567
9c69cfb7
CY
3568 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3569
acc28cb9
CY
3570 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3571 repeat counts (Bug#10507).
3572
48da7392
GM
35732012-01-26 Glenn Morris <rgm@gnu.org>
3574
3575 * lread.c (syms_of_lread): Doc fix.
3576
14af5f7f
CY
35772012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3578
3579 * coding.c (encode_designation_at_bol): Change return value to
3580 EMACS_INT.
3581
0b21c100
CY
35822012-01-25 Chong Yidong <cyd@gnu.org>
3583
3584 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3585
3c2907f7
CY
35862012-01-21 Chong Yidong <cyd@gnu.org>
3587
3588 * floatfns.c (Fcopysign): Make the second argument non-optional,
3589 since nil is not allowed anyway.
3590
959ad23f
AS
35912012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3592
3593 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3594 (send_process): Likewise.
3595
34a02f46
MR
35962012-01-19 Martin Rudalics <rudalics@gmx.at>
3597
3598 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3599 (Vwindow_persistent_parameters): Do not use Qstate.
3600 Rewrite doc-strings.
34a02f46 3601
1259009a 36022012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3603
3604 * character.c (char_width): New function.
70d4fdf6
GM
3605 (Fchar_width, c_string_width, lisp_string_width):
3606 Use char_width (Bug#9496).
25ed9e61 3607
6a6ee00d
MR
36082012-01-16 Martin Rudalics <rudalics@gmx.at>
3609
3610 * window.c (Vwindow_persistent_parameters): New variable.
3611 (Fset_window_configuration, save_window_save): Handle persistent
3612 window parameters.
3613
c85efaf7
EZ
36142012-01-14 Eli Zaretskii <eliz@gnu.org>
3615
3616 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3617 thrashing the stack of the thread. (Bug#9087)
3618
5944709e
PE
36192012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3620
3621 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3622
e71f5d99
EZ
36232012-01-11 Eli Zaretskii <eliz@gnu.org>
3624
3625 * xdisp.c (rows_from_pos_range): Handle the case where the
3626 highlight ends on a newline. (Bug#10464)
3627 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3628 he end column for display of highlight that ends on a newline
3629 before a R2L line.
3630
ce316182
GM
36312012-01-11 Glenn Morris <rgm@gnu.org>
3632
3633 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3634 from load-path also when installation-directory is nil. (Bug#10208)
3635
5b43da69
GM
36362012-01-10 Glenn Morris <rgm@gnu.org>
3637
74cc8ff9
GM
3638 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3639
7d8d6e4e
GM
3640 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3641 Update template values to be closer to their typical values these days.
5b43da69 3642
a0db8d43
EZ
36432012-01-09 Eli Zaretskii <eliz@gnu.org>
3644
3645 * xdisp.c (rows_from_pos_range): Accept additional argument
3646 DISP_STRING, and accept any glyph in a row whose object is that
3647 string as eligible for mouse highlight. Fixes mouse highlight of
3648 display strings from overlays. (Bug#10464)
3649
9a0115ab 36502012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3651
b9110d6a 3652 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3653 * fileio.c (auto_saving_dir_umask): New static var.
3654 (Fmake_directory_internal): Use it.
3655 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3656 creating the directory. The old code temporarily assigns
3657 too-generous permissions to the directory.
3658 (do_auto_save_eh): Clear it.
b9110d6a 3659 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3660 that the var is always cleared.
3661
6c1bd3f3
EZ
36622012-01-07 Eli Zaretskii <eliz@gnu.org>
3663
3664 * search.c (scan_buffer): Pass character positions to
3665 know_region_cache, not byte positions. (Bug#6540)
3666
069d2b50
L
36672012-01-07 LynX <_LynX@bk.ru> (tiny change)
3668
3669 * w32.c (sys_rename): Report EXDEV when rename of a directory
3670 fails because the target is on another logical disk. (Bug#10284)
3671
75bf0d33
DB
36722012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3673
3674 * xterm.c (x_embed_request_focus): New function.
3675
3676 * xterm.h: Add prototype.
3677
3678 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3679
1c6e5a32
GM
36802012-01-05 Glenn Morris <rgm@gnu.org>
3681
3682 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3683
651e947e
EZ
36842012-01-01 Eli Zaretskii <eliz@gnu.org>
3685
3686 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3687 Load gnutls_transport_set_lowat only if GnuTLS version is below
3688 2.11.1.
3689 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3690 GnuTLS versions below 2.11.1.
3691
3778cdd8
AL
36922011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3693
3694 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3695 to the doc string advising against its use for altering the way
3696 windows are scrolled.
3697
0e5317f7
KH
36982011-12-28 Kenichi Handa <handa@m17n.org>
3699
3700 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3701 coding-system ASCII compatible only when it does not produce BOM
3702 on encoding (Bug#10383).
3703
93d5ca1f
JD
37042011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3705
3706 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3707 can scroll.
3708 (create_and_show_popup_menu): Always use menu_position_func for
3709 Gtk3 (Bug#10361).
3710
ca22b785
AS
37112011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3712
3713 * callint.c (Fcall_interactively): Don't truncate prompt string.
3714
d048e1e6
EZ
37152011-12-23 Eli Zaretskii <eliz@gnu.org>
3716
3717 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3718 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3719 resumed from there (after widening). (Bug#10360)
d048e1e6 3720
5ccaba1f
JD
37212011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3722
3723 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3724
204ee57f
JD
37252011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3726
b81d40f0
JB
3727 * nsterm.m (x_free_frame_resources):
3728 Release f->output_data.ns->miniimage.
204ee57f
JD
3729 (ns_index_color): Fix indentation. Do not retain
3730 color_table->colors[i].
3731
3732 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3733 before returning.
3734
3735 * nsfns.m (x_set_background_color): Assign return value from
3736 ns_index_color to face-background instead of NSColor*.
3737 (ns_implicitly_set_icon_type): Fix indentation.
3738 Change assignment in for loop to comparison.
3739
3740 * emacs.c (ns_pool): New variable.
3741 (main): Assign ns_pool.
3742 (Fkill_emacs): Call ns_release_autorelease_pool.
3743
3744 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3745 autorelease fdesc, release fdAttrs and tdict.
3746 (ns_get_covering_families): Release charset.
3747 (ns_findfonts): Release NSFontDescriptor created with new.
3748 (ns_uni_to_glyphs): Fix indentation.
3749 (setString): Release attrStr before assigning new value.
3750
c803b2b7
JD
37512011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3752
678f4426
JD
3753 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3754 and NS_IMPL_COCOA.
3755 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3756 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3757
cd394be1 37582011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3759
5fecd5fc
JD
3760 * nsterm.m (ns_term_init): Subscribe for notifications
3761 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3762 to method trackingNotification in EmacsMenu.
3763
3764 * nsmenu.m (trackingMenu): New variable.
3771cb17 3765 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3766 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3767 from Aquamacs (Bug#7030).
678f4426
JD
3768
37692011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3770
c803b2b7
JD
3771 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3772 (symbol_to_nsstring): Fix indentation.
3773 (ns_symbol_to_pb): New function.
cae07000
SM
3774 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3775 (Fns_rotate_cut_buffers_internal): Remove.
3776 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3777 Fns_store_cut_buffer_internal.
3778 (ns_get_foreign_selection, Fx_own_selection_internal)
3779 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3780 (Fns_get_selection_internal, Fns_store_selection_internal):
3781 Use ns_symbol_to_pb and check if return value is nil.
3782 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3783 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3784 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3785 renamed to Sns_store_selection_internal.
3786 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3787 and remove this function.
3788 (ns_handle_selection_clear): Remove, never used.
3789 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3790 here.
3791
e1b01a3a
KB
37922011-12-17 Ken Brown <kbrown@cornell.edu>
3793
3794 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3795 GID is unknown (Bug#10257).
3796
2adb6e85
PE
37972011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3800 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3801 which caused a build failure on GNU/Linux IA-64. This problem was
3802 introduced by my 2011-10-07 patch.
3803
d1d7b339
JL
38042011-12-15 Juri Linkov <juri@jurta.org>
3805
3806 * image.c (imagemagick_error): New function. (Bug#10112)
3807 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3808 Use `imagemagick_error' where ImageMagick functions return
3809 `MagickFalse'.
3810 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3811 proper order.
3812
100d5755
KH
38132011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3814
3815 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3816 fill background (Bug#8992).
3817
454592a6
MR
38182011-12-13 Martin Rudalics <rudalics@gmx.at>
3819
3820 * window.c (Vwindow_combination_resize)
3821 (Vwindow_combination_limit): Use t instead of non-nil in
3822 doc-strings.
61d4b438
MR
3823 (Vrecenter_redisplay): Add first sentence of doc-string on
3824 separate line.
53524d93 3825 (Frecenter): Fix doc-string typo.
454592a6 3826
3633e3aa
KH
38272011-12-11 Kenichi Handa <handa@m17n.org>
3828
3829 * coding.c (Funencodable_char_position): Pay attention to the
3830 buffer text relocation (Bug#9389).
3831
7b9d523a 38322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3833
7b9d523a
JD
3834 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3835 gtk_init (Bug#10100).
3836
b73189c6
EZ
38372011-12-10 Eli Zaretskii <eliz@gnu.org>
3838
3839 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3840 IT->string is nil. (Bug#10263)
3841
f7dfe5d6
JD
38422011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3843
83faebb4
JD
3844 * nsterm.h (x_free_frame_resources): Declare.
3845
f7dfe5d6
JD
3846 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3847 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3848
3849 * nsterm.h (ns_get_defaults_value): Declare.
3850
3851 * nsterm.m (ns_default): Call ns_get_defaults_value.
3852
7cd4e72c
EZ
38532011-12-09 Eli Zaretskii <eliz@gnu.org>
3854
3855 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3856 (Bug#10170)
3857
b34d7317
YM
38582011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3859
3860 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3861 that where the value of an _OBJC_* symbol points to is in the .bss
3862 section (Bug#10240).
3863
76470ad1
KH
38642011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3865
3866 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3867 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3868
745fff94
KH
38692011-12-08 Kenichi Handa <handa@m17n.org>
3870
3871 * ftfont.c (get_adstyle_property): Fix previous change
3872 (Bug#10233).
3873
6e44397c
JB
38742011-12-07 Juanma Barranquero <lekktu@gmail.com>
3875
3876 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3877 dirs from the default value of EMACSLOADPATH (bug#10208).
3878
7efa6272
GM
38792011-12-07 Glenn Morris <rgm@gnu.org>
3880
3881 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3882 installation and source directories as well. (Bug#10208)
3883
f6fc4d87
CY
38842011-12-06 Chong Yidong <cyd@gnu.org>
3885
3886 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3887
2bf26180
GM
38882011-12-06 Glenn Morris <rgm@gnu.org>
3889
3890 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3891 as an error, not just -1. (Bug#10217)
3892
3a6ad4f0
CY
38932011-12-05 Chong Yidong <cyd@gnu.org>
3894
3895 * keyboard.c (process_special_events): New function.
3896 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3897
75a3b399
PE
38982011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 * coding.c (encode_designation_at_bol): Don't use uninitialized
3901 local variable (Bug#9318).
3902
c3c9e25e
KH
39032011-12-05 Kenichi Handa <handa@m17n.org>
3904
3905 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3906 return Qnil (Bug#8046, Bug#10193).
3907
5eb05ea3
KH
39082011-12-05 Kenichi Handa <handa@m17n.org>
3909
3910 * coding.c (encode_designation_at_bol): New args charbuf_end and
3911 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3912 (coding_set_source): Return how many bytes coding->source was
3913 relocated.
3914 (coding_set_destination): Return how many bytes
3915 coding->destination was relocated.
3916 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3917 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3918
39192011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3920
3921 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3922 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3923 macro (Bug#9318).
3924
39252011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3926
3927 The following changes are to fix Bug#9318.
3928
a79703f5 3929 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3930 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3931 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3932 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3933
7dbda6df
JB
39342011-12-05 Juanma Barranquero <lekktu@gmail.com>
3935
3936 * lisp.h (process_quit_flag): Fix external declaration.
3937
6d5eb5b0
SM
39382011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3939
3940 Don't macro-inline non-performance-critical code.
3941 * eval.c (process_quit_flag): New function.
3942 * lisp.h (QUIT): Use it.
3943
a0c3fad0
JD
39442011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3945
3946 * nsfns.m (get_geometry_from_preferences): New function.
3947 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3948
6c07aac2
AS
39492011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3950
3951 * emacs.c (Qkill_emacs): Define.
3952 (syms_of_emacs): Initialize it.
3953 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3954 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3955 (quit_throw_to_read_char): Add parameter `from_signal'.
3956 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3957 * lisp.h (QUIT): Call Fkill_emacs if requested.
3958
c052ead4
JD
39592011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3960
3961 * widget.c (update_wm_hints): Return if wmshell is null.
3962 (widget_update_wm_size_hints): New function.
3963
3964 * widget.h (widget_update_wm_size_hints): Declare.
3965
3966 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3967 widget_update_wm_size_hints (Bug#10104).
3968
9e49252b
EZ
39692011-12-03 Eli Zaretskii <eliz@gnu.org>
3970
3971 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3972 before a newline, prepare the bidi iterator for consuming the
3973 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3974 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3975
02b16839
JL
39762011-12-02 Juri Linkov <juri@jurta.org>
3977
3978 * search.c (Fword_search_regexp): New Lisp function created from
3979 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3980 (Fword_search_backward, Fword_search_forward)
3981 (Fword_search_backward_lax, Fword_search_forward_lax):
3982 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3983 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3984
0068070e
SM
39852011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3986
3987 * fileio.c (Finsert_file_contents): Move after-change-function call
3988 to before the "handled:" label, since all "goto handled" appear in
3989 cases where the *-change-functions have already been properly called
3990 (bug#10117).
3991
3360a3fc
AS
39922011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3993
3994 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3995 waiting for input. (Bug#10169)
3996
73d6c093
EZ
39972011-11-30 Eli Zaretskii <eliz@gnu.org>
3998
3999 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4000 verifies glyph row's hash code--we have just reallocated the
4001 glyphs, so their contents can be complete garbage. (Bug#10164)
4002
febe6bea
JB
40032011-11-30 Juanma Barranquero <lekktu@gmail.com>
4004
4005 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4006
801a4313
EZ
40072011-11-30 Eli Zaretskii <eliz@gnu.org>
4008
4009 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4010 attributes are tested _before_ calling verify_row_hash, to protect
4011 against GCC re-ordering of the tests. (Bug#10164)
4012
2b56b87e
JD
40132011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4014
4015 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4016
4017 * xterm.c (handle_one_xevent): Only set async_visible and friends
4018 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4019 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4020 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4021
dbf31225
PE
40222011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4023
4024 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4025 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4026 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4027 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4028 All uses changed to use GCPRO1 etc.
4029 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4030 Revert to old implementation (i.e., before 2011-03-11).
4031
1305621b
YM
40322011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4033
4034 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4035 of scroll runs so as to avoid assigning disabled bogus rows and
4036 unnecessary graphics copy operations.
4037
8c9afb46
EZ
40382011-11-27 Eli Zaretskii <eliz@gnu.org>
4039
4040 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4041 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4042 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4043 (malloc, free, realloc, calloc): Redirect to e_* only when
4044 compiling Emacs.
4045
4046 * lisp.h (GCTYPEBITS): Move before first use.
4047 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4048 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4049 this macro definition.
4050
4051 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4052 _MSC_VER.
4053
54e9e3bf
JD
40542011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4055
6d5eb5b0
SM
4056 * gtkutil.c (xg_create_frame_widgets):
4057 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4058 present with Gtk+ 2.0.
4059
83aca1cb
PE
40602011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4061
4062 * fileio.c (Finsert_file_contents): Undo previous change; see
4063 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4064
5b76caa4
PE
40652011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4066
4067 Rename locals to avoid shadowing.
4068 * fileio.c (Finsert_file_contents):
4069 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4070 * process.c (wait_reading_process_output):
4071 Rename inner 'proc' to 'p' to avoid shadowing.
4072 Indent for consistency with usual Emacs style.
4073
8c535114
EZ
40742011-11-25 Eli Zaretskii <eliz@gnu.org>
4075
4076 * xdisp.c (redisplay_window): If cursor row is not fully visible
4077 after recentering, and scroll-conservatively is set to a large
4078 number, scroll window by a few more lines to make the cursor fully
4079 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4080 (start_display): Don't move to the next line if the display should
4081 start at a newline that is part of a display vector or an overlay
4082 string. (Bug#10119)
8c535114 4083
fa4fdb5c
JL
40842011-11-24 Juri Linkov <juri@jurta.org>
4085
4086 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4087 after the `MagickPingImage' call. (Bug#10112)
4088
90ec88df
CY
40892011-11-23 Chong Yidong <cyd@gnu.org>
4090
4091 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4092
56e2e794
MR
40932011-11-23 Martin Rudalics <rudalics@gmx.at>
4094
4095 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4096 making another buffer current. (Bug#10114)
4097
b6e64c41
GM
40982011-11-23 Glenn Morris <rgm@gnu.org>
4099
4100 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4101
6b21de18
CY
41022011-11-23 Chong Yidong <cyd@gnu.org>
4103
4104 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4105 using it (Bug#5984).
4106
b12cd789
EZ
41072011-11-22 Eli Zaretskii <eliz@gnu.org>
4108
4109 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4110 and header-lines, as they don't have one computed for them.
4111 (Bug#10098)
4112
4113 * .gdbinit (prow): Make displayed values more self-explaining.
4114 Add row's hash code.
4115
261b6fd4
LMI
41162011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4117
4118 * process.c (wait_reading_process_output): Fix asynchrounous
4119 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4120 (wait_reading_process_output): Add comment and URL.
261b6fd4 4121
e7cfd277
JD
41222011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4123
4124 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4125
a9b9b7f5
CY
41262011-11-21 Chong Yidong <cyd@gnu.org>
4127
4128 * window.c (Fnext_window, Fprevious_window): Doc fix.
4129
b0d15b4f
SM
41302011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4131
4132 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4133
fe7a3057
JB
41342011-11-20 Juanma Barranquero <lekktu@gmail.com>
4135
4136 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4137
d2999b1a
MR
41382011-11-20 Martin Rudalics <rudalics@gmx.at>
4139
4140 * window.c (Fset_window_combination_limit): Rename argument
4141 STATUS to LIMIT.
4142 (Vwindow_combination_limit): Remove "status" from doc-string.
4143
d5ff9cd0
AS
41442011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4145
4146 * m/ibms390.h: Remove.
4147 * m/ibms390x.h: Don't include "ibms390.h".
4148
a5bb9bd3
SM
41492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4150
4151 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4152 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4153
cd1181db
JB
41542011-11-20 Juanma Barranquero <lekktu@gmail.com>
4155
4156 * casetab.c (Fset_case_table):
4157 * charset.c (Fcharset_after): Fix typos.
4158
615a3b8d 41592011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4160
17e845af
PE
4161 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4162 Otherwise, valgrind does not work on some platforms.
4163 Problem reported by Andreas Schwab in
6a0bf43d
PE
4164 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4165 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4166 is set, removing the need for VIRT_ADDRESS_VARIES.
4167 (PURE_P): Use a more-efficient implementation that needs just one
4168 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4169 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4170 to 4 (xorl, subq, cmpq, setbe).
4171 * alloc.c (pure): Always extern now, since that's the
4172 VIRT_ADDR_VARIES behavior.
4173 (PURE_POINTER_P): Use a single comparison, not two, for
4174 consistency with the new puresize.h.
4175 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4176 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4177 Remove VIRT_ADDR_VARIES no longer needed.
4178
f8fe6f96
EZ
41792011-11-19 Eli Zaretskii <eliz@gnu.org>
4180
4181 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4182 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4183 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4184 behave as if the cursor position were at the window margin.
4185
4186 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4187 and the cursor position is out of bounds, behave as if the cursor
4188 position were at the window margin. (Bug#10075)
4189
df05a53c
CY
41902011-11-18 Chong Yidong <cyd@gnu.org>
4191
4192 * window.c (Fwindow_combination_limit): Make first argument
4193 non-optional, since it is meaningless for live windows like the
4194 selected window.
61ccba97 4195
2071918e
DA
41962011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4197
4198 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4199
b50a28de
SM
42002011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4201
4202 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4203 (graft_intervals_into_buffer): Simplify.
4204
015137db
EZ
42052011-11-18 Eli Zaretskii <eliz@gnu.org>
4206
4207 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4208 hash values of the two rows.
4209 (copy_row_except_pointers): Preserve the used[] arrays and the
4210 hash values of the two rows. (Bug#10035)
68c95424 4211 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4212
4213 * xdisp.c (row_hash): New function, body extracted from
4214 compute_line_metrics.
4215 (compute_line_metrics): Call row_hash, instead of computing the
4216 hash code inline.
4217
4218 * dispnew.c (verify_row_hash): Call row_hash for computing the
4219 hash code of a row, instead of duplicating code from xdisp.c.
4220
4221 * dispextern.h (row_hash): Add prototype.
4222
a2addb04
TH
42232011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4224
4225 * frame.c (delete_frame): Don't delete the terminal when the last
4226 X frame is closed if emacs is built with GTK toolkit.
4227
df85d315
JB
42282011-11-17 Juanma Barranquero <lekktu@gmail.com>
4229
4230 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4231
a0c2d0ae
MR
42322011-11-17 Martin Rudalics <rudalics@gmx.at>
4233
4234 * window.c (Vwindow_splits): Rename to
4235 Vwindow_combination_resize. Suggested by Juri Linkov.
4236 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4237 of Vwindow_splits.
4238
58179cce
JB
42392011-11-16 Juanma Barranquero <lekktu@gmail.com>
4240
7877f373
JB
4241 * nsfns.m (Fns_font_name):
4242 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4243
b6f67890
MR
42442011-11-16 Martin Rudalics <rudalics@gmx.at>
4245
4246 * window.h (window): Rename slot "nest" to "combination_limit".
4247 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4248 (Fset_window_nest): Rename to Fset_window_combination_limit.
4249 (Vwindow_nest): Rename to Vwindow_combination_limit.
4250 (recombine_windows, make_parent_window, make_window)
4251 (Fsplit_window_internal, saved_window)
4252 (Fset_window_configuration, save_window_save): Rename all
4253 occurrences of window_nest to window_combination_limit.
4254
c7015153
JB
42552011-11-15 Juanma Barranquero <lekktu@gmail.com>
4256
4257 * image.c (imagemagick_load_image): Fix typo.
4258
322ad6ec
EZ
42592011-11-14 Eli Zaretskii <eliz@gnu.org>
4260
4261 * xdisp.c (display_line): Move the call to
4262 highlight_trailing_whitespace before the call to
4263 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4264 faces of all the glyphs to compute ROW's hash value.
4265 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4266
f067b8ec
JB
42672011-11-14 Juanma Barranquero <lekktu@gmail.com>
4268
4269 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4270 just return (bug#10044).
4271
1e5b2111
EZ
42722011-11-12 Eli Zaretskii <eliz@gnu.org>
4273
7ef3cbd5
EZ
4274 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4275 with user-defined heap size. Bump the default size of the temacs
4276 heap to 27MB, to avoid memory warning when running temacs.
4277 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4278
1e5b2111
EZ
4279 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4280 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4281 (verify_row_hash) [XASSERTS]: New function.
4282 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4283 that the hash value of glyph rows is correct.
1e5b2111 4284
89d61221
MR
42852011-11-12 Martin Rudalics <rudalics@gmx.at>
4286
4287 * window.h (window): Remove splits slot.
4288 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4289 (Fdelete_other_windows_internal, make_parent_window)
4290 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4291 (Fset_window_configuration, save_window_save): Don't deal with
4292 split status of windows.
4293 (saved_window): Remove splits slot.
4294 (Vwindow_splits): Rewrite doc-string.
4295
97f18cc8
JD
42962011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4297
4298 * xfns.c (unwind_create_frame):
4299 * nsfns.m (unwind_create_frame):
4300 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4301 Vframe_list (Bug#9999).
4302
22a648b4
DA
43032011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4304
0b381c7e 4305 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4306
659afede
KH
43072011-11-11 Kenichi Handa <handa@m17n.org>
4308
4309 * callproc.c (Fcall_process): Set the member dst_multibyte of
4310 process_coding.
4311
9ac0394b
KH
43122011-11-11 Johan Bockgård <bojohan@gnu.org>
4313
4314 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4315 avoid a crash (bug#9496).
4316
2fbdc249
CY
43172011-11-09 Chong Yidong <cyd@gnu.org>
4318
4319 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4320 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4321
ac6b1f81
PE
43222011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4325
09db192c
PE
43262011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Avoid some portability problems by eschewing 'extern inline' functions.
4329 The trivial performance wins aren't worth the portability hassles; see
4330 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4331 et seq.
4332 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4333 (window_box_width, window_box_left, window_box_left_offset)
4334 (window_box_right, window_box_right_offset): Undo previous change,
4335 by removing the "extern"s.
4336 * intervals.c (adjust_intervals_for_insertion)
4337 (adjust_intervals_for_deletion): Undo previous change,
4338 making these static again.
4339 (offset_intervals, temp_set_point_both, temp_set_point)
4340 (copy_intervals_to_string): No longer inline.
4341 * xdisp.c (window_text_bottom_y, window_box_width)
4342 (window_box_height, window_box_left_offset)
4343 (window_box_right_offset, window_box_left, window_box_right)
4344 (window_box): No longer inline.
4345
105216ed
CY
43462011-11-08 Chong Yidong <cyd@gnu.org>
4347
4348 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4349 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4350 Signal an error if not a live window.
105216ed
CY
4351 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4352 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4353
ae9e237f
JB
43542011-11-07 Juanma Barranquero <lekktu@gmail.com>
4355
4356 * lisp.h (syms_of_abbrev): Remove declaration.
4357 Reported by CHENG Gao <chenggao@royau.me>.
4358
c7aa8333
EZ
43592011-11-07 Eli Zaretskii <eliz@gnu.org>
4360
4361 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4362 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4363 of temacs in GUI mode.
4364
be7f5545
MR
43652011-11-07 Martin Rudalics <rudalics@gmx.at>
4366
4367 * window.h: Declare delete_all_child_windows instead of
4368 delete_all_subwindows.
4369 * window.c (Fwindow_nest, Fset_window_nest)
4370 (Fset_window_new_total, Fset_window_new_normal)
4371 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4372 (delete_all_subwindows): Rename to delete_all_child_windows.
4373 (Fdelete_other_windows_internal, Fset_window_configuration):
4374 Call delete_all_child_windows instead of delete_all_subwindows.
4375 * frame.c (delete_frame): Call delete_all_child_windows instead
4376 of delete_all_subwindows.
4377
ca78dc43
PE
43782011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4381 This is also needed for porting to any host where GC_MARK_STACK is
4382 not GC_MAKE_GCPROS_NOOPS.
4383 (which_symbols): Use it.
4384
a0241d01
KH
43852011-11-07 Kenichi Handa <handa@m17n.org>
4386
4387 * coding.c (coding_set_destination): Check coding->src_pos only
4388 when coding->src_object is a buffer (bug#9910).
4389
4390 * process.c (send_process): Set the member src_multibyte of coding
4391 to 0 (bug#9911) when sending a unibyte text.
4392
4393 * callproc.c (Fcall_process): Set the member src_multibyte of
4394 process_coding to 0 (bug#9912).
4395
a64bfdfa 43962011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4397
4398 * xmenu.c (cleanup_widget_value_tree): New function.
4399 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4400 calling free_menubar_widget_value_tree directly (Bug#9830).
4401
cb41b32a
PE
44022011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4403
4404 Fix some portability problems with 'inline'.
4405 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4406 (window_box_width, window_box_left, window_box_left_offset)
4407 (window_box_right, window_box_right_offset): Declare extern.
4408 Otherwise, these inline functions do not conform to C99 and
4409 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4410 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4411 * intervals.c (adjust_intervals_for_insertion)
4412 (adjust_intervals_for_deletion): Now extern, because otherwise the
4413 extern inline functions 'offset_intervals' couldn't refer to it.
4414 (static_offset_intervals): Remove.
4415 (offset_intervals): Rewrite using the old contents of
4416 static_offset_intervals. The old version didn't conform to C99
4417 because an extern inline function contained a reference to an
4418 identifier with static linkage.
4419
b7041366
AS
44202011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4421
4422 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4423 GC.
4424
88a37c4d
EZ
44252011-11-06 Eli Zaretskii <eliz@gnu.org>
4426
4427 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4428 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4429 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4430 return Qleft_to_right.
4431
49745b39
CY
44322011-11-06 Chong Yidong <cyd@gnu.org>
4433
4434 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4435 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4436 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4437 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4438 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4439 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4440 (Fwindow_vscroll): Doc fix.
4441 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4442 argument, since it makes no sense to pass a live window and for
4443 consistency with window-child.
4444
1f05cd82
CS
44452011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4446
4447 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4448 support MSVC.
4449
22610910
JR
44502011-11-05 Jason Rumney <jasonr@gnu.org>
4451
4452 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4453 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4454 fonts (Bug#6029).
4455 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4456 bitwise arithmetic preventing use of unicode-sip and non-truetype
4457 opentype fonts.
4458
a06776b2
EZ
44592011-11-05 Eli Zaretskii <eliz@gnu.org>
4460
3ad924ba
EZ
4461 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4462 "emacs"-only part.
4463
a06776b2
EZ
4464 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4465 initialization code to keep similarity to xfns.c after changes
4466 from 2011-11-05.
4467
c9e7db78
JD
44682011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4469
a97f8f3f
JD
4470 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4471 (unwind_create_frame): New function (Bug#9943).
4472 (Fx_create_frame): Restructure code to be more similar to the one in
4473 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4474 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4475 Move terminal->reference_count++ just before making the frame official
4476 (Bug#9943).
4477
4478 * nsterm.m (x_free_frame_resources): New function.
4479 (x_destroy_window): Move code to x_free_frame_resources.
4480
c9e7db78 4481 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4482 (Fx_create_frame, x_create_tip_frame):
4483 Move terminal->reference_count++ just before making the frame
75f1671a 4484 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4485 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4486
a6fc3b5c
EZ
44872011-11-05 Eli Zaretskii <eliz@gnu.org>
4488
4489 Support MSVC build with newer versions of Visual Studio.
4490 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4491 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4492 nt/gmake.defs.
4493
4494 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4495 which are not supported by MSVC.
4496 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4497 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4498 bitfields.
4499 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4500 types in bitfields.
4501 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4502
4503 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4504
58179cce 45052011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4506
4507 Support MSVC build with newer versions of Visual Studio.
4508 * w32.c: Don't include w32api.h for MSVC.
4509 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4510
4511 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4512 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4513 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4514 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4515 e_* cousins.
4516 (alloca) [_MSC_VER]: Define to _alloca.
4517
4518 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4519
4520 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4521
a58c13ed
EZ
45222011-11-04 Eli Zaretskii <eliz@gnu.org>
4523
4524 * xdisp.c (note_mouse_highlight): If either of
4525 previous/next-single-property-change returns nil, treat that as
4526 the beginning or the end of the buffer. (Bug#9955)
4527
fe0b6370
JD
45282011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4529
a58c13ed 4530 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4531 label is not null (Bug#9951).
4532 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4533 may be NULL.
4534
89bd5ee1
EZ
45352011-11-04 Eli Zaretskii <eliz@gnu.org>
4536
4537 * window.c (Fwindow_body_size): Mention in the doc string that the
4538 return value is in frame's canonical units. (Bug#9949)
4539
84c3edb9
EZ
45402011-11-03 Eli Zaretskii <eliz@gnu.org>
4541
4e2fb5c7
EZ
4542 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4543
84c3edb9 4544 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4545 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4546 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4547
bc17a887
EZ
45482011-11-01 Eli Zaretskii <eliz@gnu.org>
4549
4550 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4551 Don't stop backward scan on the continuation glyph, even though
4552 its CHARPOS is positive.
6d5eb5b0
SM
4553 (mouse_face_from_buffer_pos, note_mouse_highlight):
4554 Rename cover_string to disp_string.
bc17a887 4555
4ee88440
MR
45562011-11-01 Martin Rudalics <rudalics@gmx.at>
4557
4558 * window.c (temp_output_buffer_show): Don't use
4559 Vtemp_buffer_show_specifiers.
4560 (Vtemp_buffer_show_specifiers): Remove unused variable.
4561
c2ff3c02
EZ
45622011-10-30 Eli Zaretskii <eliz@gnu.org>
4563
4564 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4565 past the beginning of the current glyph matrix.
4566
58179cce 45672011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4568
4569 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4570 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4571 HAVE_GTK3 (Bug#9869).
b77a6a7f 4572
3b574623
JD
4573 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4574 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4575
b77a6a7f
JD
4576 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4577
4578 * xterm.c: Declare x_handle_net_wm_state to return int.
4579 (handle_one_xevent): Check if we are iconified but don't have
4580 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4581 (get_current_wm_state): Return non-zero if not hidden,
4582 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4583 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4584 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4585 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4586
196e41e4
PE
45872011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4588
4589 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4590 so that this new function doesn't get optimized away by a
4591 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4592
021f2e1a
AS
45932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4594
4595 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4596
8b058d44
EZ
45972011-10-29 Eli Zaretskii <eliz@gnu.org>
4598
4599 Fix the `xbytecode' command.
4600 * .gdbinit (xprintbytestr): New command.
b50a28de 4601 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4602 (xbytecode): Print the byte-code string as well.
4603
4452fb80
EZ
46042011-10-29 Kim Storm <storm@cua.dk>
4605
8b058d44
EZ
4606 * alloc.c (which_symbols): New function.
4607
21b72067
AS
46082011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4609
4610 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4611 line. (Bug#9903)
4612
83ed7b5c
GM
46132011-10-29 Glenn Morris <rgm@gnu.org>
4614
4615 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4616 Not clear what it was for, and it causes various bugs. (Bug#9839)
4617
5a7a728b
EZ
46182011-10-28 Eli Zaretskii <eliz@gnu.org>
4619
4620 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4621 possible random value that matches one of those tested as
4622 condition to clear the mouse face.
4623
d3d0842f
CY
46242011-10-28 Chong Yidong <cyd@gnu.org>
4625
4626 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4627
31b39d13
DN
46282011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4629
4630 * window.c (make_window): Initialize phys_cursor_on_p.
4631
9aba6043
SM
46322011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4633
4634 * lisp.h (struct Lisp_Symbol): Update comments.
4635
c20992f4
JB
46362011-10-28 Juanma Barranquero <lekktu@gmail.com>
4637
4638 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4639
db4f02f2
EZ
46402011-10-28 Eli Zaretskii <eliz@gnu.org>
4641
4642 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4643 <oslsachem@gmail.com> for helping to debug this.
4644
4645 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4646 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4647 (g_b_init_get_glyph_outline_w): New static variables.
4648 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4649 (GetGlyphOutlineW_Proc): New typedefs.
4650 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4651 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4652 New functions.
4653 (w32font_open_internal, compute_metrics):
4654 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4655 instead of calling the "wide" APIs directly.
4656
4657 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4658
4659 * w32.h (syms_of_w32font): Add prototype.
4660
87e68db4
JB
46612011-10-27 Juanma Barranquero <lekktu@gmail.com>
4662
4663 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4664 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4665 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4666 (Fmove_to_window_line): Doc fix.
4667
435c1d67
CY
46682011-10-27 Chong Yidong <cyd@gnu.org>
4669
4670 * process.c (make_process): Set gnutls_state to NULL.
4671
4672 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4673 non-NULL, regardless of GNUTLS_INITSTAGE.
4674 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4675 an error. Set process slots as soon as we allocate them.
4676
4677 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4678
9c6c6f49
CY
46792011-10-27 Chong Yidong <cyd@gnu.org>
4680
9aba6043
SM
4681 * gnutls.c (emacs_gnutls_deinit): New function.
4682 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4683 (Fgnutls_deinit, Fgnutls_boot): Use it.
4684
4685 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4686 (deactivate_process): Call emacs_gnutls_deinit.
4687
657d08d3
JB
46882011-10-27 Juanma Barranquero <lekktu@gmail.com>
4689
4690 * image.c (x_create_x_image_and_pixmap):
4691 * w32.c (sys_rename, w32_delayed_load):
4692 * w32font.c (fill_in_logfont):
4693 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4694
5430d399
JB
46952011-10-26 Juanma Barranquero <lekktu@gmail.com>
4696
4697 * w32fns.c (w32_default_color_map): New function,
4698 extracted from Fw32_default_color_map.
a7ef684b 4699 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4700
fe0055fa
PE
47012011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4702
4703 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4704
e6346438
SM
47052011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4706
4707 * keyboard.c (test_undefined): New function (bug#9751).
4708 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4709
e112cc37
ET
47102011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4711
4712 * sysdep.c (init_sys_modes): Fix the check for the controlling
4713 terminal (Bug#6649).
4714
7b5d6677
EZ
47152011-10-20 Eli Zaretskii <eliz@gnu.org>
4716
4717 * dispextern.h (struct bidi_it): New member next_en_type.
4718
4719 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4720 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4721 current character, check also for next_en_type being WEAK_EN.
4722 (bidi_resolve_weak): Don't enter the expensive loop if the current
4723 position is before next_en_pos. Record the bidi type of the first
4724 non-ET, non-BN character we find, in addition to its position.
4725 (bidi_level_of_next_char): Invalidate next_en_type when
4726 next_en_pos is over-stepped.
4727
7da0b018
PE
47282011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4729
4730 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4731 * editfns.c: Rewrite current-time-zone so that it invokes
4732 the equivalent of (format-time-string "%Z") to get the time zone name.
4733 This fixes a bug when the time zone name contains characters that
4734 need converting from the system time locale to Emacs internal format.
4735 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4736 that patch fixed format-time-string to do the conversion, but
4737 I forgot to fix current-time-zone.
4738 (format_time_string): New function, containing most of
4739 what Fformat_time_string used to contain.
4740 (Fformat_time_string): Rewrite in terms of format_time_string.
4741 This doesn't change this function's behavior.
4742 (current-time-zone): Rewrite to use format_time_string.
4743 This fixes the bug reported by Michael Schierl in
4744 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4745 Jason Rumney's 2007-06-07 change worked around this bug, but
4746 didn't fix it.
4747 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4748
8547b010
EZ
47492011-10-19 Eli Zaretskii <eliz@gnu.org>
4750
4751 * xdisp.c (start_display): If the character at POS is displayed
4752 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4753 (try_window_reusing_current_matrix): If a line ends in a display
4754 vector or the next line starts in a display vector, continue
4755 redrawing the window even though the character position of
4756 start_row was reached.
8547b010
EZ
4757 (Bug#9771, part 2)
4758
4e948d15
CY
47592011-10-18 Chong Yidong <cyd@gnu.org>
4760
4761 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4762 with nobreak-char-display too.
4763
4787455f
EZ
47642011-10-18 Eli Zaretskii <eliz@gnu.org>
4765
4766 Fix part 3 of bug#9771.
4767 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4768 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4769 non-neutral characters if the current character is a paragraph
4770 separator (a.k.a. Newline). This avoids running the same
4771 expensive loop twice, once when we consume the preceding newline
4772 and the other time when the line actually needs to be displayed.
4773 Avoid the loop when we see neutrals on the base embedding level
4774 following a character whose directionality is the same as the
4775 paragraph's. This avoids running the expensive loop when a line
4776 ends in a long sequence of neutrals, like control characters.
4777 Add assertion against STRONG_AL type. Slightly rearrange code
4778 that determines the type of a neutral given the first non-neutral
4779 that follows it.
4780 (bidi_level_of_next_char): Set next_en_pos to zero when
4781 invalidating its info.
4782
2c91f553
EZ
47832011-10-17 Eli Zaretskii <eliz@gnu.org>
4784
4785 * xdisp.c (push_display_prop): Determine whether to record string
4786 or buffer position by IT->string, not by IT->method. Allow
4787 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4788 (move_it_vertically_backward): Don't look for character position
4789 immediately after the newline when in a continuation line.
4790 (Bug#9771, part 1)
2c91f553 4791
c7b08b0d
MR
47922011-10-15 Martin Rudalics <rudalics@gmx.at>
4793
4794 * window.c (coordinates_in_window): Rewrite and delabelize
4795 vertical border check. (Bug#5357) (Bug#9618)
4796
6b02f655
SM
47972011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4798
4799 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4800 errors in XSetWindowBorder (bug#9310).
4801
81d40c92
DA
48022011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4803
4804 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4805 avoid crash when xmalloc overrun checking is enabled.
4806
d4172c3b
EZ
48072011-10-13 Eli Zaretskii <eliz@gnu.org>
4808
4809 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4810 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4811 cursor motion with <left> and <right> arrow keys.
4812
4813 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4814 some callers set that themselves.
4815
b00eea75
EZ
48162011-10-12 Eli Zaretskii <eliz@gnu.org>
4817
4818 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4819 display string and the previous row comes from the same string and
4820 is empty. (Bug#9739) (Bug#9738)
4821
8fe012c4
SM
48222011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4823
4824 * doc.c (get_doc_string): Encode file name (bug#9735).
4825
0074aef2
EZ
48262011-10-12 Eli Zaretskii <eliz@gnu.org>
4827
79beb178
EZ
4828 * bidi.c (bidi_level_of_next_char):
4829 * xdisp.c (get_visually_first_element): Remove old incorrect
4830 comments regarding the Unicode Line Separator character.
4831
0074aef2
EZ
4832 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4833
6e4b3fbe
DA
48342011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4835
4836 * alloc.c (Fgc_status): Do not access beyond zombies array
4837 boundary if nzombies > MAX_ZOMBIES.
4838 * alloc.c (dump_zombies): Add missing format specifier.
4839
0324f3af
PE
48402011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4841
b5525cac
PE
4842 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4843 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4844
0324f3af
PE
4845 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4846 Some packages use them to denote characters with modifiers.
4847
e9b5f888
AS
48482011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4849
4850 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4851 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4852 matching a pp-number. Rename parameter var to var1.
4853
127827c0
SM
48542011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4855
4856 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4857
c8fd3bd0
GM
48582011-10-08 Glenn Morris <rgm@gnu.org>
4859
4860 * callint.c (Fcall_interactively): Give a more explicit error for the
4861 'c' case with a non-character input. (Bug#8479)
4862
352ec8ff
EZ
48632011-10-08 Eli Zaretskii <eliz@gnu.org>
4864
03669ccb
EZ
4865 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4866 lines.
7061c986
EZ
4867 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4868 lines that are hscrolled on the left.
03669ccb 4869
352ec8ff
EZ
4870 * dispnew.c (buffer_posn_from_coords): Account for a possible
4871 presence of header-line. (Bug#4426)
4872
a66cfb1c
SM
48732011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4874
6b02f655
SM
4875 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4876 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4877
7c5ee88e
PE
48782011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4879
4880 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4881 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4882 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4883 this makes Emacs dump core during garbage collection on rare
4884 occasions. sizeof is obviously inferior to offsetof here, so
4885 stick with offsetof.
4886 (GC_POINTER_ALIGNMENT): New macro.
4887 (mark_memory): Omit 3rd (offset) arg; caller changed.
4888 Don't assume EMACS_INT alignment is the same as pointer alignment.
4889
df1bbe5b
SM
48902011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4891
4892 * keyboard.c (read_key_sequence_remapped): New var.
4893 (read_key_sequence): Compute remapping in the right buffer.
4894 (command_loop_1): Use read_key_sequence's remapping directly.
4895
51553db6
SM
48962011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4897
32c1fffd
SM
4898 * dired.c (file_name_completion): Don't expand file name.
4899 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4900 before checking file name handler.
4901
51553db6
SM
4902 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4903 they've been requested explicitly (bug#9591).
4904
b6bd1599 49052011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4906
4907 * keymap.c (Fsingle_key_description): Use make_specified_string
4908 instead of build_string to build string from push_key_description.
4909 (Bug#5193)
4910
f701dc2a
PE
49112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4912
4222c55d
PE
4913 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4914 This fixes a Y2038 bug on 64-bit hosts.
4915 * buffer.c (reset_buffer):
4916 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4917 (Fclear_buffer_auto_save_failure):
4918 Use 0, not -1, to represent an unset failure time, since time_t
4919 might not be signed.
4920
f701dc2a
PE
4921 Remove dependency on glibc malloc internals.
4922 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4923 Move back here from lisp.h, but with their new implementations.
4924 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4925 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4926 * charset.c (charset_table_init): New static var.
4927 (syms_of_charset): Use it instead of xmalloc. This removes a
4928 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4929 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4930 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4931 Move back to alloc.c.
4932 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4933 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4934
9ceebf39
JD
49352011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4936
4937 * nsterm.m (windowDidResize): Call x_set_window_size only when
4938 ns_in_resize is true. Otherwise set pixelwidth/height and
4939 call change_frame_size (Bug#9628).
4940
cb993c58
PE
49412011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4942
3930c88b
PE
4943 Port --enable-checking=all to Fedora 14 x86-64.
4944 * charset.c (syms_of_charset): Also account for glibc malloc's
4945 internal overhead when calculating the initial malloc maximum.
4946
cb993c58
PE
4947 Port --enable-checking=all to Fedora 14 x86.
4948 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4949 Move to lisp.h.
4950 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4951 (overrun_check_realloc, overrun_check_free):
4952 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4953 That way, xmalloc returns a properly-aligned pointer even if
4954 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4955 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4956 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4957 into account when calculating the initial malloc maximum.
4958 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4959 Move here from alloc.c, so that charset.c can use it too.
4960 Properly align; the old code wasn't right for common 32-bit hosts
4961 when configured with --enable-checking=all.
4962 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4963 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4964
31bed486
EZ
49652011-09-29 Eli Zaretskii <eliz@gnu.org>
4966
04c70788 4967 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4968 use EDOM.
4969
fbcaa2f3
EZ
49702011-09-28 Eli Zaretskii <eliz@gnu.org>
4971
4972 * xdisp.c (compute_display_string_end): If there's no display
4973 string at CHARPOS, return -1.
4974
4975 * bidi.c (bidi_fetch_char): When compute_display_string_end
4976 returns a negative value, treat the character as a normal
4977 character not covered by a display string. (Bug#9624)
4978
a239d4e9
JB
49792011-09-28 Juanma Barranquero <lekktu@gmail.com>
4980
4981 * lread.c (Fread_from_string): Fix typo in docstring.
4982
88652fd5
EZ
49832011-09-27 Eli Zaretskii <eliz@gnu.org>
4984
4985 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4986 newline, reseat the iterator instead of bidi-iterating there one
4987 character at a time. (Bug#9610)
32c1fffd
SM
4988 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4989 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4990
ed497dd4
AS
49912011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4992
4993 * lread.c (readevalloop): Use correct code for NBSP.
4994 (read1): Likewise. (Bug#9608)
4995
b2bf61aa
MA
49962011-09-25 Michael Albinus <michael.albinus@gmx.de>
4997
4998 * dbusbind.c (Fdbus_register_signal): When service is not
4999 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5000
32bbb17c
GM
50012011-09-25 Glenn Morris <rgm@gnu.org>
5002
5003 * buffer.c (truncate-lines): Doc fix.
5004
94e0933e
CY
50052011-09-24 Chong Yidong <cyd@stupidchicken.com>
5006
5007 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5008 (Fset_window_next_buffers): Doc fix.
5009
cddde921
GM
50102011-09-24 Glenn Morris <rgm@gnu.org>
5011
5012 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5013
1260aef1
PE
50142011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5015
25b4bfa0
PE
5016 Fix minor problems found by static checking.
5017 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5018 * indent.c (Fvertical_motion): Fix == vs = typo.
5019
e3cbd34b
EZ
50202011-09-24 Eli Zaretskii <eliz@gnu.org>
5021
a66cfb1c
SM
5022 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5023 Default value is now t. Doc fix.
6bf7006f 5024
e3cbd34b 5025 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5026 logic when moving up, not only when moving down. Fix the
e3cbd34b 5027 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5028 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5029
5030 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5031 CHARPOS is covered by a display string which includes newlines.
5032 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5033 is covered by a display string with embedded newlines.
5034
a3de0cbd
MA
50352011-09-24 Michael Albinus <michael.albinus@gmx.de>
5036
5037 * dbusbind.c (Fdbus_register_signal): Add match rule to
5038 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5039 (Fdbus_register_method, Vdbus_registered_objects_table):
5040 Fix docstring.
a3de0cbd 5041
b260039d
JM
50422011-09-24 Jim Meyering <meyering@redhat.com>
5043
32c1fffd 5044 do not ignore write error for any output size
b260039d
JM
5045 The previous change was incomplete.
5046 While it makes emacs --batch detect the vast majority of stdout
5047 write failures, errors were still ignored whenever the output size is
5048 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5049 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5050 && echo FAIL: ignored write error
5051 FAIL: ignored write error
5052 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5053 && echo FAIL: ignored write error
5054 FAIL: ignored write error
5055 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5056
8eca8a7c
AS
50572011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5058
5059 * emacs.c (Fkill_emacs): In noninteractive mode exit
5060 non-successfully if a write error occurred on stdout. (Bug#9574)
5061
3341db62
EZ
50622011-09-21 Eli Zaretskii <eliz@gnu.org>
5063
5064 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5065 the xassert test.
5066
5067 * dispextern.h (struct it): Update the comment documenting what
5068 can it->OBJECT be.
5069
8c203dbf
EZ
50702011-09-20 Eli Zaretskii <eliz@gnu.org>
5071
5072 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5073 a display string, extend search for cursor position to end of row.
5074 (find_row_edges): If the row ends in a newline from a display
5075 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5076 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5077 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5078 non-empty line. Fixes confusing cursor motion with arrow keys at
5079 the beginning of a line that starts with whitespace.
8c203dbf 5080
a4824228
LMI
50812011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5082
5083 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5084 (bug#9493).
5085
33ed493b
CY
50862011-09-18 Chong Yidong <cyd@stupidchicken.com>
5087
5088 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5089 boolean (Bug#9154).
5090
56cd55c8
EZ
50912011-09-18 Eli Zaretskii <eliz@gnu.org>
5092
5093 * xdisp.c (display_line): Record maximum and minimum buffer
5094 positions even if no glyphs were produced (e.g., by a zero-width
5095 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5096 buffer positions that will be removed from the glyph row because
5097 they don't fit.
c02dcedf
EZ
5098 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5099 column is beyond frame width: don't subtract 1 "pixel" when
5100 computing width of the stretch.
3e62b7e0
EZ
5101 (reseat_at_next_visible_line_start): Undo the change made on
5102 2011-09-17 that saved paragraph information and restored it after
5103 the call to `reseat'. (Bug#9545)
56cd55c8 5104
5ed99d36 51052011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5106
5107 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5108 and turn window cursor on if cleared (Bug#9415).
5109
5ed99d36 51102011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5111
5112 * search.c (boyer_moore): Take unibyte characters from pattern
5113 literally. (Bug#9458)
5114
9bade7b2
EZ
51152011-09-18 Eli Zaretskii <eliz@gnu.org>
5116
5117 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5118
e5e9d610
PE
51192011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5120
87e4427a
PE
5121 Fix minor problem found by static checking.
5122 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5123 initialized, to pacify gcc -Wuninitialized.
5124
e5e9d610
PE
5125 * fileio.c: Report proper errno when syscall falls.
5126 (Finsert_file_contents): Save and restore errno,
5127 so that report_file_error outputs the correct diagnostic.
5128 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5129
a1674f0b
EZ
51302011-09-18 Eli Zaretskii <eliz@gnu.org>
5131
5132 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5133
fbfb6dd4
EZ
51342011-09-17 Eli Zaretskii <eliz@gnu.org>
5135
5136 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5137 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5138
bb187662
EZ
51392011-09-17 Eli Zaretskii <eliz@gnu.org>
5140
1137e8b8 5141 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5142 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5143
5144 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5145 (bidi_find_paragraph_start): Search back for paragraph beginning
5146 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5147 (bidi_move_to_visually_next): Only trigger paragraph-related
5148 computations when the last character is a newline or at EOB, not
5149 just any NEUTRAL_B. (Bug#9470)
5150
bb187662
EZ
5151 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5152 truncated lines if point is covered by a display string. (Bug#9524)
5153
2e621251
PE
51542011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5157 (cons_to_x_long): New function.
5158 (lisp_data_to_selection_data): Use it. Correct the test for
5159 short-versus-long data; it was negated. Break out of vector
5160 loop, for efficiency, when a long datum is discovered.
5161
91a15bc6
SM
51622011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5163
5164 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5165
b41c3a35
EZ
51662011-09-16 Eli Zaretskii <eliz@gnu.org>
5167
5168 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5169 GCC PR/17406) by declaring this function with external scope.
5170
7812ba2d
PE
51712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5172
5173 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5174 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5175
cf7edc2a
AS
51762011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5177
5178 * editfns.c (Fformat): Correctly handle text properties on "%%".
5179
bd01620e
EZ
51802011-09-15 Eli Zaretskii <eliz@gnu.org>
5181
5182 * xterm.c (x_draw_composite_glyph_string_foreground):
5183 * w32term.c (x_draw_composite_glyph_string_foreground):
5184 * term.c (encode_terminal_code):
5185 * composite.c (composition_update_it, get_composition_id):
5186 * xdisp.c (get_next_display_element)
5187 (fill_composite_glyph_string): Add comments about special meaning
5188 of TAB characters in a composition.
5189
a02719a3
PE
51902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5191
5192 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5193 This occurs when processing a multibyte format.
5194 Problem reported by Wolfgang Jenker.
a02719a3 5195
72589a3c
JB
51962011-09-15 Johan Bockgård <bojohan@gnu.org>
5197
5198 * xdisp.c (try_cursor_movement): Only check for exact match if
5199 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5200
1c14176c
PE
52012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5202
5203 Remove unused external symbols.
5204 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5205 * xdisp.c (calc_pixel_width_or_height): Now static.
5206 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5207 * indent.c (check_display_width):
5208 * w32term.c: Fix comment to match code.
5209 * xterm.c, xterm.h (x_catching_errors): Remove.
5210
d2eea5b5
PE
52112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5212
5213 * xselect.c: Use signed conversions more consistently (Bug#9498).
5214 (selection_data_to_lisp_data): Assume incoming selection data are
5215 signed integers, not unsigned. This is to be consistent with
5216 outgoing selection data, which was modified to use signed integers
5217 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5218 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5219 expects long, not unsigned long.
5220
46888499
EZ
52212011-09-14 Eli Zaretskii <eliz@gnu.org>
5222
5223 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5224 computation of loop end. Reported by Johan Bockgård
5225 <bojohan@gnu.org>.
5226
ef8ef9fb
CY
52272011-09-13 Chong Yidong <cyd@stupidchicken.com>
5228
5229 * frame.c (Fother_visible_frames_p): Function deleted.
5230
fa819fed
EZ
52312011-09-12 Eli Zaretskii <eliz@gnu.org>
5232
5233 * indent.c (compute_motion): Process display vector front to back
5234 rather than the other way around. (Bug#2496)
5235
2ba8e008
SM
52362011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5237
5238 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5239
20f53c69
CY
52402011-09-11 Chong Yidong <cyd@stupidchicken.com>
5241
5242 * minibuf.c (Fread_from_minibuffer): Doc fix.
5243
d562d7a4
EZ
52442011-09-11 Eli Zaretskii <eliz@gnu.org>
5245
5246 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5247 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5248
1c4d7f3d
LMI
52492011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5250
5251 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5252 value for non-existent files.
5253
b885bf36
EZ
52542011-09-11 Eli Zaretskii <eliz@gnu.org>
5255
5256 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5257 set its "size" to -1. This will set the modtime_size field of
5258 the corresponding buffer to -1, which is what
5259 verify-visited-file-modtime expects for files that do not exist.
5260 (Bug#9139)
5261
6612f0bf
PE
52622011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5263
5264 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5265 here ...
5266 * lisp.h: ... from here. push_key_description is no longer
5267 defined in keyboard.c, so its declaration should not be in
5268 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5269 logically belongs with push_key_description.
5270
dfb3f755
PE
52712011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5272
5273 * buffer.h: Include <sys/types.h> instead of <time.h>.
5274 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5275 Problem reported by Herbert J. Skuhra.
5276
3134906c
LMI
52772011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5278
5279 * xml.c (parse_region): Make the parsing work for
5280 non-comment-starting XML files again (bug#9144).
5281
8d903f4e
AS
52822011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5283
5284 * image.c (gif_load): Fix calculation of bottom and right corner.
5285 (Bug#9468)
5286
80ad64f4
EZ
52872011-09-10 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5290 redisplay in small windows.
5291
208a048d
EZ
52922011-09-09 Eli Zaretskii <eliz@gnu.org>
5293
5294 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5295
9b1c252e
MR
52962011-09-08 Martin Rudalics <rudalics@gmx.at>
5297
5298 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5299 Operate on live windows only.
5300
2949f33b
JB
53012011-09-08 Juanma Barranquero <lekktu@gmail.com>
5302
5303 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5304
e08dcafd
EZ
53052011-09-07 Eli Zaretskii <eliz@gnu.org>
5306
5307 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5308 only under bidi iteration.
5309
115b96bd
JD
53102011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5311
5312 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5313
c8199d0f
PE
53142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5315
5316 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5317 Without this fix, the command to link temacs failed due to an
5318 undefined symbol __builtin_isnan. This is because
5319 /usr/include/iso/math_c99.h #defines isnan(x) to
5320 __builtin_isnan(x), but the bundled gcc, which identifies itself
5321 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5322 a __builtin_isnan.
5323 * floatfns.c (isnan): #undef, and then #define to a clone of
5324 what's in data.c.
5325 (Fisnan): Always define, since it's always available now.
5326 (syms_of_floatfns): Always define isnan at the Lisp level.
5327
e39b275c 53282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5329
5330 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5331
b2db44d9 53322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5333
f4af5137 5334 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5335 The previous code assumed that file offsets (off_t values) fit in
5336 EMACS_INT variables, which is not true on typical 32-bit hosts.
5337 The code messed up by falsely reporting buffer overflow in cases
5338 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5339 when "big" contains more than 2**29 bytes, even though this
5340 inserts just one byte and does not overflow the buffer.
5341 (Finsert_file_contents): Store file offsets as off_t
5342 values, not as EMACS_INT values. Check for overflow when
5343 converting between EMACS_INT and off_t. When checking for
5344 buffer overflow or for overlap, take the offsets into account.
5345 Don't use EMACS_INT for small values where int suffices.
5346 When checking for overlap, fix a typo: ZV was used where
5347 ZV_BYTE was intended.
5348 (Fwrite_region): Don't assume off_t fits into 'long'.
5349 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5350
ecfc0a49
MA
53512011-09-05 Michael Albinus <michael.albinus@gmx.de>
5352
5353 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5354
6511acf2 53552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5356
0999621a 5357 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5358
5359 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5360 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5361 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5362 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5363 (modify_event_symbol): Do not assume that the length of
5364 name_alist_or_stem is safe to alloca and fits in int.
5365 (Fexecute_extended_command): Likewise for function name and binding.
5366 (Frecursion_depth): Wrap around reliably on integer overflow.
5367 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5368 since some callers pass EMACS_INT values.
5369 (Fsingle_key_description): Don't crash if symbol name contains more
5370 than MAX_ALLOCA bytes.
5371 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5372 (get_minibuffer): Arg is now EMACS_INT, not int.
5373 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5374 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5375 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5376
2be7d702
PE
5377 * dbusbind.c (signature_cat): New function.
5378 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5379 Do not overrun buffer; instead, report string overflow.
5380
9d1df220
PE
5381 * dispnew.c (add_window_display_history): Don't overrun buffer.
5382 Truncate instead; this is OK since it's just a log.
5383
33ef5c64
PE
5384 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5385 even if the time zone offset is outlandishly large.
5386 Don't mishandle offset == INT_MIN.
5387
66c6fdd5
PE
5388 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5389 when creating daemon; the previous buffer-overflow check was incorrect.
5390
d749b01b
PE
5391 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5392 which has the guts of the old verror function.
5393
b5cd1905
PE
5394 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5395 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5396
6e1a67fb
PE
5397 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5398 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5399 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5400 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5401 length of string rather than counting it via multiple sprintfs;
5402 that's simpler and more reliable.
c21721cc
PE
5403 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5404 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5405 sprintf, in case result does not fit in int.
5406
c57b67fc
PE
5407 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5408 (fontset_from_font): Print it.
5409
8a401434
PE
5410 * frame.c (tty_frame_count): Now printmax_t, not int.
5411 (make_terminal_frame, set_term_frame_name): Print it.
5412 (x_report_frame_params): In X, window IDs are unsigned long,
5413 not signed long, so print them as unsigned.
5414 (validate_x_resource_name): Check for implausibly long names,
5415 and don't assume name length fits in 'int'.
5416 (x_get_resource_string): Don't blindly alloca invocation name;
5417 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5418 not fit in int.
5419
6e1a67fb
PE
5420 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5421 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5422 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5423
0df02bf3
PE
5424 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5425 Use esprintf, not sprintf, in case result does not fit in int.
5426
48e30793
PE
5427 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5428 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5429 it as a large positive number.
5430 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5431 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5432
a66ff6d8
PE
5433 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5434 in case result does not fit in int.
5435
aca216ff
PE
5436 * print.c (float_to_string): Detect width overflow more reliably.
5437 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5438 buffer overrun. Don't assume list length fits in 'int'. Treat
5439 print length of 0 as 0, not as infinity; to be consistent with other
5440 uses of print length in this function. Don't overflow print length
5441 index. Don't assume hash table size fits in 'long', or that
5442 vectorlike size fits in 'unsigned long'.
5443
31c286f7
PE
5444 * process.c (make_process): Use printmax_t, not int, to format
5445 process-name gensyms.
5446
55e5faa1
PE
5447 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5448
80f2e268
PE
5449 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5450 to avoid potential buffer overrun.
5451
670741ab
PE
5452 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5453 if X resource line is longer than 512 bytes.
5454
b7163a50
PE
5455 * xfns.c (x_window): Make sprintf buffer a bit bigger
5456 to avoid potential buffer overrun.
5457
ae58ff1f
PE
5458 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5459
c43c8a6a
PE
5460 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5461
3f8236f4
PE
54622011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5463
53e9fe90 5464 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5465 Without these, Emacs silently mishandles large integers sometimes.
5466 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5467 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5468
6511acf2
PE
5469 * xdisp.c (try_window_id): Check Emacs fixnum range before
5470 converting to 'int'.
806add1d 5471
6511acf2 5472 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5473 Check that an Emacs fixnum is in range before assigning it to 'int'.
5474 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5475 values converted from Emacs fixnums.
5476 (Frecenter): Don't wrap around a line count if it is out of 'int'
5477 range; instead, treat it as an extreme value.
5478 (Fset_window_configuration, compare_window_configurations):
5479 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5480
6511acf2
PE
5481 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5482 that can exceed INT_MAX. Check that EMACS_INT value is in range
5483 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5484 (match_limit): Don't assume that a fixnum can fit in 'int'.
5485
6511acf2 5486 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5487 exceed INT_MAX.
5488
6511acf2 5489 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5490 (Fvertical_motion): Don't wrap around LINES values that don't fit
5491 in 'int'. Instead, treat them as extreme values. This is good
5492 enough for windows, which can't have more than INT_MAX lines anyway.
5493
fcb901a7
LMI
54942011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5495
0f2f6b6d
LMI
5496 * Require libxml/parser.h to avoid compilation warning.
5497
fcb901a7
LMI
5498 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5499
5500 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5501 since this reportedly can destroy thread storage.
5502
6e20a0d4
CY
55032011-08-30 Chong Yidong <cyd@stupidchicken.com>
5504
5505 * syntax.c (find_defun_start): Update all cache variables if
5506 exiting early (Bug#9401).
5507
148ae00e
EZ
55082011-08-30 Eli Zaretskii <eliz@gnu.org>
5509
f6cfbd8f
EZ
5510 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5511
148ae00e
EZ
5512 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5513 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5514 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5515
5516 * term.c (tty_append_glyph): New function.
5517 (produce_stretch_glyph): Static function and its prototype deleted.
5518
a66cfb1c
SM
5519 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5520 Add prototypes.
148ae00e 5521
c4a07a4c
PE
55222011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5523
5524 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5525 when checking :margin (Bug#9390).
5526 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5527 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5528 so that the name doesn't mislead. All uses changed.
5529
6bc8cd65
JB
55302011-08-28 Johan Bockgård <bojohan@gnu.org>
5531
5532 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5533 set_tty_hooks.
5534
dca4927e
EZ
55352011-08-27 Eli Zaretskii <eliz@gnu.org>
5536
5537 * xdisp.c (move_it_to): Don't bail out early when reaching
5538 position beyond to_charpos, if we are scanning backwards.
5539 (move_it_vertically_backward): When DY == 0, make sure we get to
5540 the first character in the line after the newline.
5541
f2cad773
PE
55422011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5543
5544 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5545 (ccl_driver): Do not generate an out-of-range pointer.
5546 (Fccl_execute_on_string): Remove unnecessary check for
5547 integer overflow, noted by Stefan Monnier in
5548 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5549 Remove a FIXME that didn't need fixing.
5550 Simplify the newly-introduced buffer reallocation code.
5551
0cae2cdb
JB
55522011-08-27 Juanma Barranquero <lekktu@gmail.com>
5553
5554 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5555
5fc295a4 55562011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5557
70c60eb2 5558 Integer and memory overflow issues (Bug#9196).
726e0ab1 5559
d31850da
PE
5560 * doc.c (get_doc_string): Rework so that
5561 get_doc_string_buffer_size is the actual buffer size, rather than
5562 being 1 less than the actual buffer size; this makes xpalloc more
5563 convenient.
5564
a69fbedb
PE
5565 * image.c (x_allocate_bitmap_record, cache_image):
5566 * xselect.c (Fx_register_dnd_atom):
5567 Simplify previous changes by using xpalloc.
5568
fe5c5d37
PE
5569 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5570 since either will do and ptrdiff_t is convenient with xpalloc.
5571
0065d054
PE
5572 * charset.c (charset_table_size)
5573 (struct charset_sort_data.priority): Now ptrdiff_t.
5574 (charset_compare): Don't overflow if priorities differ greatly.
5575 (Fsort_charsets): Don't assume list length fits in int.
5576 Check for size-calculation overflow when allocating sort data.
5577 (syms_of_charset): Allocate an initial charset table that is
5578 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5579
5580 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5581
5582 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5583 The actual value is always <= INT_MAX, and leaving it unsigned made
5584 overflow checking harder.
5585
5586 * dispextern.h (struct glyph_matrix.rows_allocated)
5587 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5588 with xpalloc. The values are still always <= INT_MAX.
5589
5590 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5591
5592 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5593 (SAFE_NALLOCA): New macro.
5594
5595 * region-cache.c (struct boundary.pos, find_cache_boundary)
5596 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5597 (set_cache_region, invalidate_region_cache)
5598 (revalidate_region_cache, know_region_cache, region_cache_forward)
5599 (region_cache_backward, pp_cache):
5600 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5601 so that ptrdiff_t * can be passed to xpalloc.
5602 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5603 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5604 (pp_cache): Don't assume cache_len fits in int.
5605 * region-cache.h: Adjust extern decls to match.
5606
5607 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5608 EMACS_INT, since either will do, for xpalloc.
5609
5610 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5611 (xnmalloc, xnrealloc, xpalloc): New functions.
5612
726e0ab1
PE
5613 * bidi.c (bidi_shelve_header_size): New constant.
5614 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5615 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5616
51f30bc5 5617 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5618 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5619 (overlay_strings):
5620 Don't update size of array until after memory allocation succeeds,
5621 because xmalloc/xrealloc may not return.
0065d054
PE
5622 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5623 now that we have proper integer overflow checking.
5624 (record_overlay_string, overlay_strings): Catch overflows when
5625 calculating size of overlay_str_buf.
726e0ab1 5626
0065d054
PE
5627 * callproc.c (Fcall_process): Check for size overflow when
5628 calculating size of args2.
5629 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5630 Normally we prefer signed values, but sticking with ptrdiff_t would
5631 require adding more-complicated checks.
726e0ab1
PE
5632
5633 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5634 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5635 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5636 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5637
5638 * character.c (Fstring): Check for size-calculation overflow.
5639
5640 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5641 unnecessary integer overflow. Check for size overflow.
5642 (encode_coding_object): Don't update size until xmalloc succeeds.
5643
5644 * composite.c (get_composition_id): Check for overflow in glyph
5645 length calculations.
5646
5647 Integer and memory overflow fixes for display code.
5648 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5649 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5650 (scrolling_window): Check for overflow in size calculations.
5651 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5652 Don't assume glyph table len fits in int.
5653 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5654 (row_table_size): Now ptrdiff_t, not int.
5655 (scrolling_window): Avoid overflow in size calculations.
5656 Don't update size until allocation succeeds.
5657 * fns.c (concat): Check for overflow in size calculations.
5658 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5659 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5660 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5661
5662 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5663 (get_doc_string): Check for size calculation overflow.
5664 Don't update size until allocation succeeds.
5665 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5666 EMACS_INT, where ptrdiff_t will do.
5667 (Fsubstitute_command_keys): Check for string overflow.
5668
5669 * editfns.c (set_time_zone_rule): Don't assume environment length
5670 fits in int.
5671 (message_length): Now ptrdiff_t, not int.
5672 (Fmessage_box): Don't update size until allocation succeeds.
5673 Don't assume message length fits in int.
5674 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5675
0065d054
PE
5676 * emacs.c (main): Do not reallocate argv, since there is a null at
5677 the end that can be overwritten, and this way there's no need to
5678 worry about size-calculation overflow.
5679 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5680
5681 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5682 alloc succeeds.
5683 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5684
5685 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5686 (x_set_scroll_bar_width, x_figure_window_size):
5687 Check for integer overflow.
5688 (x_set_alpha): Do not assume XINT fits in int.
5689
5690 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5691 This is for the members text_lines, text_cols, total_lines, total_cols,
5692 where the system imposes an 'int' limit.
5693
5694 * fringe.c (Fdefine_fringe_bitmap):
5695 Don't update size until alloc works.
5696
5697 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5698 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5699
5700 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5701 Check for size-calculation overflow.
5702 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5703 do, as we prefer signed integers.
5704 (id_to_widget.max_size, id_to_widget.used)
5705 (xg_store_widget_in_map, xg_remove_widget_from_map)
5706 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5707 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5708 Use and return ptrdiff_t, not int.
5709 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5710 * gtkutil.h: Change prototypes to match the above.
5711
5712 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5713 are duplicate now that they've been promoted to lisp.h.
5714 (x_allocate_bitmap_record, x_alloc_image_color)
5715 (make_image_cache, cache_image, xpm_load):
5716 Don't update size until alloc is done.
5717 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5718 (x_detect_edges):
3256efce 5719 Check for size calculation overflow.
726e0ab1
PE
5720 (ct_colors_allocated_max): New constant.
5721 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5722 overflow.
3256efce 5723
726e0ab1
PE
5724 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5725 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5726 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5727 Use ptrdiff_t, not int, to count maps.
5728 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5729 calculations. Don't update size until allocation succeeds.
5730 Redo calculations to avoid overflow.
726e0ab1
PE
5731 * keyboard.h: Change prototypes to match the above.
5732
5733 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5734 to count maps.
5735 (current_minor_maps): Check for size calculation overflow.
5736 * keymap.h: Change prototypes to match the above.
5737
5738 * lread.c (read1, init_obarray): Don't update size until alloc done.
5739
5740 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5741 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5742
726e0ab1
PE
5743 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5744 Now ptrdiff_t, not int.
5745 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5746 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5747
5748 * process.c (Fnetwork_interface_list): Check for overflow
5749 in size calculation.
5750
5751 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5752
5753 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5754 overflow. Don't bother calling xmalloc when xrealloc will do.
5755
5756 * search.c (Freplace_match): Check for size calculation overflow.
5757 (Fset_match_data): Don't assume list lengths fit in 'int'.
5758
5759 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5760 for command line length. Do not attempt to address one before the
5761 beginning of an array, as that's not portable.
5762
5763 * term.c (max_frame_lines): Remove; unused.
5764 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5765 not int.
5766 (encode_terminal_code, calculate_costs): Check for size
5767 calculation overflow.
5768 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5769 table lengths and related sizes. Don't update size until alloc
5770 done. Redo calculations to avoid overflow.
5771 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5772
5773 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5774 subtracting pointers.
5775 (gobble_line): Check for overflow more carefully. Don't update size
5776 until alloc done.
5777
5778 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5779 Don't update size until alloc done.
5780 Redo size calculations to avoid overflow.
5781 Check for size calculation overflow.
0065d054 5782 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5783
5784 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5785 Use ptrdiff_t, not int, for sizes.
5786 (store_mode_line_noprop_char): Don't update size until alloc done.
5787
0065d054
PE
5788 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5789 Use ptrdiff_t, not int, for sizes.
5790 (Finternal_make_lisp_face, cache_face):
5791 Check for size calculation overflow.
5792 (cache_face): Treat size calculation overflows as if they were
5793 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5794
5795 * xfns.c (x_encode_text, x_set_name_internal)
5796 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5797 sizes, since they can exceed INT_MAX in size. Check for size
5798 calculation overflow.
5799
0065d054
PE
5800 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5801 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5802 Don't update size until alloc done.
5803
0065d054 5804 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5805 as sprintf is limited to int lengths.
1d526e2f 5806
252c5ee1
PE
5807 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5808 (X_LONG_MIN): New macros.
864d7ce7
PE
5809 Use them to make the following changes clearer.
5810 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5811 This change doesn't affect the value now, but it may help remind
5812 future maintainers not to raise the value too much later.
5813 (SELECTION_QUANTUM): Remove, replacing with ...
5814 (selection_quantum): ... new function, which avoids overflow.
5815 All uses changed.
5816 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5817 assumption that selection length fits in 'int'.
5818 (x_reply_selection_request, x_handle_selection_request)
5819 (x_get_window_property, receive_incremental_selection)
5820 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5821 (lisp_data_to_selection_data, clean_local_selection_data):
5822 Use ptrdiff_t, not int, to record length of selection.
5823 (x_reply_selection_request, x_get_window_property)
5824 (receive_incremental_selection, x_property_data_to_lisp):
5825 Redo calculations to avoid overflow.
5826 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5827 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5828 something.
5829 (x_get_window_property, receive_incremental_selection)
5830 (lisp_data_to_selection_data, x_property_data_to_lisp):
5831 Check for size-calculation overflow.
5832 (x_get_window_property, receive_incremental_selection)
5833 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5834 Don't store size until memory allocation succeeds.
5835 (x_get_window_property): Plug memory leak on memory exhaustion.
5836 Don't double-block input; malloc is safe here. Don't assume 2**34
5837 - 4 fits in unsigned long. Add an xassert to check
5838 XGetWindowProperty overflow. Be more careful about overflow
5839 calculations, and distinguish size from memory overflow better.
5840 (receive_incremental_selection): When tracing, don't assume
5841 unsigned int is less than INT_MAX.
5842 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5843 harmful) conversions of unsigned short to int.
5844 (lisp_data_to_selection_data): Don't assume that integers
5845 in the range -65535 through -1 fit in an X unsigned short.
5846 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5847 result parameters unless successful. Rely on cons_to_unsigned
5848 to report problems with elements; the old code wasn't right anyway.
5849 (x_check_property_data): Check for int overflow; we cannot use
5850 a wider type due to X limits.
5851 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5852
726e0ab1 5853 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5854
0065d054
PE
5855 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5856 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5857 (x_color_cells): Don't store size until memory allocation succeeds.
5858 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5859 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5860 (x_term_init): Don't assume length fits in int (sprintf is limited
5861 to int size).
bc18e09d 5862
ebfa62c0
PE
5863 Use ptrdiff_t for composition IDs.
5864 * character.c (lisp_string_width):
5865 * composite.c (composition_table_size, n_compositions)
5866 (get_composition_id, composition_gstring_from_id):
5867 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5868 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5869 * window.c (Frecenter):
5870 Use ptrdiff_t, not int, for composition IDs.
5871 * composite.c (get_composition_id): Check for integer overflow.
5872 * composite.h: Adjust prototypes to match the above changes.
5873
d3411f89
PE
5874 Use ptrdiff_t for hash table indexes.
5875 * category.c (hash_get_category_set):
5876 * ccl.c (ccl_driver):
5877 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5878 * coding.c (coding_system_charset_list, detect_coding_system):
5879 * coding.h (struct coding_system.id):
5880 * composite.c (get_composition_id, gstring_lookup_cache):
5881 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5882 * image.c (xpm_get_color_table_h):
5883 * lisp.h (hash_lookup, hash_put):
5884 * minibuf.c (Ftest_completion):
5885 Use ptrdiff_t for hash table indexes, not int (which is too
5886 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5887 32-bit --with-wide-int hosts).
5888
e097a6fa
PE
5889 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5890 Add a FIXME comment about memory leaks.
5891 (syms_of_charset): Don't assume xmalloc returns.
5892
5637687f
PE
5893 Don't assume that stated character widths fit in int.
5894 * character.c (Fchar_width, c_string_width, lisp_string_width):
5895 * character.h (CHAR_WIDTH):
5896 * indent.c (MULTIBYTE_BYTES_WIDTH):
5897 Use sanitize_char_width to avoid undefined and/or bad behavior
5898 with outlandish widths.
a66cfb1c 5899 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5900 now that we have two such functions. All uses changed.
5901 (sanitize_char_width): New inline function.
5902
a2271ba2
PE
5903 Don't assume that tab-width fits in int.
5904 * character.h (sanitize_width): New inline function.
5905 (SANE_TAB_WIDTH): New macro.
5906 (ASCII_CHAR_WIDTH): Use it.
5907 * indent.c (sane_tab_width): Remove. All uses replaced by
5908 SANE_TAB_WIDTH (current_buffer).
5909 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5910
18c52557
PE
5911 * fileio.c: Integer overflow issues with file modes.
5912 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5913
caeeedc1
PE
5914 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5915 Remove unreachable code.
5916 (read_hex, load_charset_map_from_file): Check for integer overflow.
5917
6df6ae42 5918 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5919 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5920 (x_send_scroll_bar_event): Likewise. Check that the size does not
5921 exceed limits imposed by XClientMessageEvent, as well as the usual
5922 ptrdiff_t and size_t limits.
5923
b13995db
PE
5924 * keyboard.c: Overflow, signedness and related fixes.
5925 (make_lispy_movement): Use same integer type in forward decl
5926 that is used in the definition.
5927 (read_key_sequence, keyremap_step):
5928 Change bufsize argument back to int, undoing my 2011-03-30 change.
5929 We prefer signed types, and int is wide enough here.
5930 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5931 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5932 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5933 length, not size_t. Use ptrdiff_t for index, not int.
5934 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5935 possibility of integer overflow.
5936
13464394
PE
5937 Overflow, signedness and related fixes for images.
5938
5939 * dispextern.h (struct it.stack[0].u.image.image_id)
5940 (struct_it.image_id, struct image.id, struct image_cache.size)
5941 (struct image_cache.used, struct image_cache.ref_count):
5942 * gtkutil.c (update_frame_tool_bar):
5943 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5944 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5945 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5946 * nsmenu.m (update_frame_tool_bar):
5947 * xdisp.c (calc_pixel_width_or_height):
5948 * xfns.c (image_cache_refcount):
5949 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5950 on typical 64-bit hosts.
5951
5952 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5953 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5954 Omit unnecessary casts to int.
5955 (parse_image_spec): Check that integers fall into 'int' range
5956 when the callers expect that.
5957 (image_ascent): Redo ascent calculation to avoid int overflow.
5958 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5959 (lookup_image): Remove unnecessary tests.
5960 (xbm_image_p): Locals are now of int, not EMACS_INT,
5961 since parse_image_check makes sure they fit into int.
5962 (png_load, gif_load, svg_load_image):
5963 Prefer int to unsigned where either will do.
5964 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5965 old tiff_error_handler and tiff_warning_handler.
5966 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5967 stack buffer overflows. It uses only the features of vsnprintf
5968 that are common to both POSIX and native Microsoft.
5969 (tiff_error_handler, tiff_warning_handler): Use it.
5970 (tiff_load, gif_load, imagemagick_load_image):
5971 Don't assume :index value fits in 'int'.
5972 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5973 (imagemagick_load_image): Check that crop parameters fit into
5974 the integer types that MagickCropImage accepts. Don't assume
5975 Vimagemagick_render_type has a nonnegative value. Don't assume
5976 size_t fits in 'long'.
5977 (gs_load): Use printmax_t to print the widest integers possible.
5978 Check for integer overflow when computing image height and width.
5979
c11821d4
EZ
59802011-08-26 Eli Zaretskii <eliz@gnu.org>
5981
5982 * xdisp.c (redisplay_window): Don't force window start if point
5983 will be invisible in the resulting window. (Bug#9324)
5984
0c95fcf7
EZ
59852011-08-25 Eli Zaretskii <eliz@gnu.org>
5986
5987 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5988 the display spec is of the form `(space ...)'.
5989 (handle_display_spec): Return the value returned by
5990 handle_single_display_spec, not just 1 or zero.
5991 (handle_single_display_spec): If the display spec is of the form
5992 `(space ...)', and specifies display in the text area, return 2
5993 rather than 1.
fee65a97 5994 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5995 accurately, and prefer exact match for point under bidi.
5996 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5997
5998 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5999 into disp_prop; all users changed.
6000
6001 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6002 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6003 for the text covered by the display property.
6004
e4ed06f1
CY
60052011-08-25 Chong Yidong <cyd@stupidchicken.com>
6006
6007 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6008 Change return value to nil.
6009 (Frecord_buffer): Delete unused function.
6010
f67cdd7f
EZ
60112011-08-24 Eli Zaretskii <eliz@gnu.org>
6012
5980d4c6
EZ
6013 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6014 buffers, return left-to-right.
8610fe8b
EZ
6015 (set_cursor_from_row): Consider candidate row a win if its glyph
6016 represents a newline and point is on that newline. Fixes cursor
6017 positioning on the newline at EOL of R2L text within L2R
6018 paragraph, and vice versa.
6019 (try_cursor_movement): Check continued rows, in addition to
6020 continuation rows. Fixes unwarranted scroll when point enters a
6021 continued line of R2L text within an L2R paragraph, or vice versa.
6022 (cursor_row_p): Consider the case of point being equal to
6023 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6024 from the end of a short line to the beginning of a continued line
6025 of R2L text within L2R paragraph.
6026 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6027 composed characters.
5980d4c6 6028
f67cdd7f
EZ
6029 * bidi.c (bidi_check_type): Use xassert.
6030 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6031 members.
6032
bca633fb
EZ
60332011-08-23 Eli Zaretskii <eliz@gnu.org>
6034
6035 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6036 a character.
6037
4a5885a7
CY
60382011-08-23 Chong Yidong <cyd@stupidchicken.com>
6039
6040 * nsfont.m (ns_otf_to_script): Fix typo.
6041
0902a04e
KH
60422011-08-22 Kenichi Handa <handa@m17n.org>
6043
6044 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6045 extra slot even if the purpose is char-code-property-table.
6046
1a2e6670
EZ
60472011-08-23 Eli Zaretskii <eliz@gnu.org>
6048
8ddde651
EZ
6049 * xdisp.c (redisplay_window): When computing centering_position,
6050 account for the height of the header line. (Bug#8874)
6051
425cc014
EZ
6052 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6053 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6054 candidate is selected by the mouse, and that candidate has a
6055 composed character under the mouse.
6056
1a2e6670
EZ
6057 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6058 coordinates reported by pos-visible-in-window-p for a composed
6059 character in column zero.
6060
8b76d6f8
SM
60612011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6062
6063 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6064
dac347dd
EZ
60652011-08-22 Eli Zaretskii <eliz@gnu.org>
6066
6067 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6068 consider it a hit if to_charpos is anywhere in the range of the
6069 composed buffer positions.
6070
e013fb34
CY
60712011-08-22 Chong Yidong <cyd@stupidchicken.com>
6072
6073 * image.c (gif_load): Don't assume that each subimage has the same
6074 dimensions as the base image. Handle disposal method that is
6075 "undefined" by the gif spec (Bug#9335).
6076
bd1ba3e8
CY
60772011-08-20 Chong Yidong <cyd@stupidchicken.com>
6078
6079 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6080 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6081
54a1215b
EZ
60822011-08-19 Eli Zaretskii <eliz@gnu.org>
6083
823564e5
EZ
6084 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6085 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6086 from an Org mode buffer to a Speedbar frame.
6087
54a1215b
EZ
6088 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6089 a composition, take its buffer position from IT->cmp_it.charpos.
6090 Fixes cursor positioning at the beginning of a line that begins
6091 with a composed character.
6092
9778ebcc
EZ
60932011-08-18 Eli Zaretskii <eliz@gnu.org>
6094
0be6ee06
EZ
6095 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6096 character bidirectional type, use STRONG_L instead. Fixes crashes
6097 in a buffer produced by `describe-categories'.
6098
9778ebcc
EZ
6099 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6100 members before the level stack, so they would be saved and
6101 restored when copying iterator state. Fixes incorrect reordering
6102 around TABs covered by display properties.
6103
156bffbe
AS
61042011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6105
6b02f655 6106 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6107
72ad093b
CY
61082011-08-17 Chong Yidong <cyd@stupidchicken.com>
6109
6110 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6111 (internal_condition_case_2, internal_condition_case_n):
6112 Remove unnecessary aborts (Bug#9081).
72ad093b 6113
35774242
EZ
61142011-08-17 Eli Zaretskii <eliz@gnu.org>
6115
6116 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6117 has no `load' handler, try opening the file locally. (Bug#9311)
6118
db76dd85
KB
61192011-08-16 Ken Brown <kbrown@cornell.edu>
6120
6121 * gmalloc.c: Expand comment.
6122
b215eee5
EZ
61232011-08-16 Eli Zaretskii <eliz@gnu.org>
6124
6125 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6126 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6127
a4579d33
KB
61282011-08-16 Ken Brown <kbrown@cornell.edu>
6129
6130 Fix memory allocation problems in Cygwin build (Bug#9273).
6131
6132 * unexcw.c ( __malloc_initialized): Declare external variable.
6133 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6134
8b76d6f8
SM
6135 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6136 New variables.
a4579d33
KB
6137 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6138 dumped emacs.
6139 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6140 in the static heap.
6141 [CYGWIN] (special_realloc): New function.
6142 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6143 requests to realloc storage in the static heap.
6144
3ebec551
PE
61452011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6146
6147 * bidi.c (bidi_initialize): Remove unused local.
6148
9fd8be00
EZ
61492011-08-15 Eli Zaretskii <eliz@gnu.org>
6150
6b02f655
SM
6151 * bidimirror.h:
6152 * biditype.h: Remove file.
6153 * makefile.w32-in ($(BLD)/bidi.$(O)):
6154 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6155
6156 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6157
6158 * chartab.c: Improve commentary for the uniprop_table API.
6159
32413314
EZ
6160 * bidi.c (bidi_paragraph_init): Support zero value of
6161 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6162 (bidi_initialize): Use uniprop_table instead of including
6163 biditype.h and bidimirror.h.
32413314 6164
9fd8be00
EZ
6165 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6166 coordinates of the iterator when restoring from ppos_it.
6167 (Bug#9296)
6168
5cf2b69b
KH
61692011-08-14 Kenichi Handa <handa@m17n.org>
6170
6171 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6172 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6173
daf17d00
EZ
61742011-08-14 Eli Zaretskii <eliz@gnu.org>
6175
6176 * xdisp.c (move_it_in_display_line_to): Don't invoke
6177 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6178 ppos_it. Fixes vertical cursor motion when line beginning is
6179 covered by an image. (Bug#9296)
6180
08e3161a
JD
61812011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6182
6183 * nsterm.h (ns_run_ascript): Declare.
6184 (NSAPP_DATA2_RUNASSCRIPT): Define.
6185
6186 * nsfns.m (as_script, as_result, as_status): New static variables.
6187 (ns_run_ascript): New function.
5e617bc2 6188 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6189 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6190 the event loop. Get status from as_status (Bug#7276).
6191
6192 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6193 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6194 the event loop (Bug#7276).
6195
a3720aa2
AS
61962011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6197
6198 * gnutls.c (QCgnutls_bootprop_priority)
6199 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6200 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6201 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6202 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6203 (QCgnutls_bootprop_verify_hostname_error)
6204 (QCgnutls_bootprop_callbacks_verify): Rename from
6205 Qgnutls_bootprop_..., all uses changed.
6206
6207 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6208 uses changed.
6209
0a0d27fb
PE
62102011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6211
19d5c50c
PE
6212 * xfaces.c (Qframe_set_background_mode): Now static.
6213 * dispextern.h (Qframe_set_background_mode): Remove decl.
6214
0a0d27fb
PE
6215 * process.c (Fnetwork_interface_info): Declare local only if needed.
6216
377538cb
JD
62172011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6218
6219 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6220 (Fnetwork_interface_list): Allocate in increments of bytes instead
6221 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6222 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6223 sockaddr.
6224 (struct ifflag_def): notrailers is smart on OSX.
6225 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6226 Get hardware address with getifaddrs if available.
6227
08fff70c
EZ
62282011-08-12 Eli Zaretskii <eliz@gnu.org>
6229
6230 * xdisp.c (iterate_out_of_display_property): xassert that
6231 IT->position is set to within IT->object's boundaries. Break from
6232 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6233 when IT->position is set up wrongly due to some bug.
6234 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6235 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6236 entry. Force push_it to save on the stack the current
6237 buffer/string position, to be restored by pop_it. Fix flags in
6238 the iterator structure wrt the object coming from a display
6239 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6240 properties. (Bug#9284)
6241
7be1c708 62422011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6243
7be1c708
CY
6244 * fontset.c (fontset_get_font_group): Add proper type checks.
6245 (Bug#9172)
aac0c6e3 6246
7be1c708 62472011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6248
7be1c708
CY
6249 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6250 and LC_VERSION_MIN_MACOSX.
6251 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6252 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6253
97bb72a6
EZ
62542011-08-08 Eli Zaretskii <eliz@gnu.org>
6255
6256 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6257 no-display-properties-and-no-overlays under bidi display.
6258 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6259 properties and overlays.
97bb72a6 6260
d5617611
CY
62612011-08-08 Chong Yidong <cyd@stupidchicken.com>
6262
37e11a63
CY
6263 * editfns.c (Fset_time_zone_rule): Document relationship with the
6264 setenv function.
6265
d5617611
CY
6266 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6267 the font entity extracted from the cache (Bug#8109).
6268
58872834
CY
62692011-08-07 Chong Yidong <cyd@stupidchicken.com>
6270
6271 * composite.c (autocmp_chars): Don't reset point. That is done by
6272 restore_point_unwind (Bug#5984).
6273
75bfc667
JL
62742011-08-07 Juri Linkov <juri@jurta.org>
6275
6276 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6277 to show the arg `TIME' instead of `TIMEVAL'.
6278
d1410150
EZ
62792011-08-06 Eli Zaretskii <eliz@gnu.org>
6280
6281 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6282 display property strides EOL and includes a newline, as in
6283 longlines-mode. (Bug#9254)
75b771e4
EZ
6284 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6285 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6286
6287 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6288 is non-zero, even if the data buffer is NULL. Fixes a crash in
6289 vertical-motion with longlines-mode. (Bug#9254)
6290
35928349
EZ
62912011-08-05 Eli Zaretskii <eliz@gnu.org>
6292
ec7cc85b
EZ
6293 * bidi.c <bidi_cache_total_alloc>: Now static.
6294 (bidi_initialize): Initialize bidi_cache_total_alloc.
6295
8b76d6f8 6296 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6297 cache. (Bug#9221)
6298
6299 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6300 amount allocated this far in `bidi_cache_total_alloc'.
6301 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6302 non-zero, only free the data buffer without restoring the cache
6303 contents. All callers changed.
6304
6305 * dispextern.h (bidi_unshelve_cache): Update prototype.
6306
6307 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6308 (move_it_in_display_line, move_it_to)
6309 (move_it_vertically_backward, move_it_by_lines): Replace the call
6310 to xfree to an equivalent call to bidi_unshelve_cache.
6311 (move_it_in_display_line_to): Fix logic of returning
412b6358 6312 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6313
e2e2423b
EZ
63142011-08-05 Eli Zaretskii <eliz@gnu.org>
6315
6316 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6317 came from a string character with a `cursor' property. (Bug#9229)
6318
ae9e757a
JD
63192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6320
6321 * Makefile.in (LIB_PTHREAD): New variable.
6322 (LIBES): Add LIB_PTHREAD (Bug#9216).
6323
6324 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6325 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6326
213bd7f2
AS
63272011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6328
6b02f655 6329 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6330
99aaf75f
JD
63312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6332
6333 * xterm.c (x_find_topmost_parent): New function.
6334 (x_set_frame_alpha): Find topmost parent window with
6335 x_find_topmost_parent and set the property there also (bug#9181).
6336 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6337
c74e9d86
PE
63382011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 * callproc.c (Fcall_process): Avoid vfork clobbering
6341 the local vars buffer, coding_systems, current_dir.
6342
640c8776
SM
63432011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6344
6345 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6346
f26d0e4c
PE
63472011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6348
8a10d76c
PE
6349 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6350 so that it is not optimized away.
6351
f26d0e4c
PE
6352 * xdisp.c (compute_display_string_pos): Remove unused local.
6353
55439c61
EZ
63542011-08-02 Eli Zaretskii <eliz@gnu.org>
6355
6356 Fix slow cursor motion and scrolling in large buffers with
6357 selective display, like Org Mode buffers. (Bug#9218)
6358
6359 * dispextern.h (struct bidi_it): New member disp_prop_p.
6360
6361 * xdisp.c: Remove one-slot cache of display string positions.
6362 (compute_display_string_pos): Accept an additional argument
5e617bc2 6363 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6364 for a display string or property. If found, set DISP_PROP_P
6365 non-zero.
6366
6367 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6368 DISP_PROP_P, and pass it to compute_display_string_pos.
6369 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6370 non-zero. All callers of bidi_fetch_char changed.
6371
fb33fa43
SM
63722011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6373
6374 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6375
b099e063
DM
63762010-12-03 Don March <don@ohspite.net>
6377
6378 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6379 last character M-[char] is translated to ESC [char] (bug#7541).
6380
5cc7f7af
KH
63812011-08-02 Kenichi Handa <handa@m17n.org>
6382
d0fffa3f 6383 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6384
6385 * chartab.c (uniprop_table): Make it non-static.
6386
525d5e6e
EZ
63872011-08-01 Eli Zaretskii <eliz@gnu.org>
6388
6389 * xdisp.c (forward_to_next_line_start): Accept additional argument
6390 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6391 on the newline.
6392 (reseat_at_next_visible_line_start): Use the bidi iterator state
6393 returned by forward_to_next_line_start to restore the state of
6394 it->bidi_it after backing up to previous newline. (Bug#9212)
6395
31011111
AS
63962011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6397
6398 * regex.c (re_comp): Protoize.
6399 (re_exec): Fix return type.
6400 (regexec): Fix type of `ret'. (Bug#9203)
6401
476371c4
PE
64022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6403
e5d76069
PE
6404 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6405 This is needed if max-image-size is a floating-point number.
6406
9a79b20c
AS
64072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6408
6409 * print.c (print_object): Print empty symbol as ##.
6410
6411 * lread.c (read1): Read ## as empty symbol.
6412
d8c2fa78
AA
64132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6414
6415 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6416 setting frame foreground color (Bug#9175).
6417 (x_set_background_color): Likewise.
6418
ffe57a7a
AA
6419 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6420 contents (Bug#9176).
6421 (EmacsTooltip -init): Remove bezels and add shadows to
6422 tooltip windows.
6423
bf3492a5
AA
6424 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6425 or scroll bar (Bug#8470).
6426
d55e9c53
AA
6427 * nsfont.m (nsfont_open): Remove assignment to voffset and
6428 unnecessary vars hshink, expand, hd, full_height, min_height.
6429 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6430
6431 * nsterm.h (nsfont_info): Remove voffset field.
6432
d8c2fa78 64332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6434
6435 Implement strike-through and overline on NextStep (Bug#8863).
6436
6437 * nsfont.m (nsfont_open): Use underline position provided by font,
6438 instead of hard-coded value of 2.
6439 (nsfont_draw): Call ns_draw_text_decoration instead.
6440
6441 * nsterm.h: Add declaration for ns_draw_text_decoration.
6442
6443 * nsterm.m (ns_draw_text_decoration): New function for drawing
6444 underline, overline, and strike-through.
6445 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6446 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6447 accommodate underlining, etc.
4843aac3 6448
4cc60b9b
EZ
64492011-07-28 Eli Zaretskii <eliz@gnu.org>
6450
bc7ece87
EZ
6451 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6452 default.
4cc60b9b 6453
476371c4
PE
64542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6455
66606eea
PE
6456 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6457 Without this fix, if a signal arrives just after memory fills up,
6458 'malloc' might be invoked reentrantly.
6459
476371c4
PE
6460 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6461 In other words, assume that every image size is allowed, on non-X
6462 hosts. This assumption is probably wrong, but it lets Emacs compile.
6463
f3fcc40d
AS
64642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6465
6466 * regex.c (re_iswctype): Convert return values to boolean.
6467
350c992f
EZ
64682011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6469
6470 * xdisp.c (compute_display_string_pos): Don't use cached display
6471 string position if the buffer had its restriction changed.
6472 (Bug#9184)
6473
5266b4bb
PE
64742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6475
6476 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6477
2573a837 64782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6479
41f55ccd 6480 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6481
39e378da
PE
6482 * bidi.c: Integer size and overflow fixes.
6483 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6484 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6485 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6486 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6487 (bidi_find_other_level_edge):
6488 Use ptrdiff_t instead of EMACS_INT where either will do.
6489 This works better on 32-bit hosts configured --with-wide-int.
6490 (bidi_cache_ensure_space): Check for size-calculation overflow.
6491 Use % rather than repeated addition, for better worst-case speed.
6492 Don't set bidi_cache_size until after xrealloc returns, because it
6493 might not return.
6494 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6495 (bidi_cache_ensure_space): Also check that the bidi cache size
6496 does not exceed that of the largest Lisp string or buffer. See Eli
6497 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6498
5e927815
PE
6499 * alloc.c (__malloc_size_t): Remove.
6500 All uses replaced by size_t. See Andreas Schwab's note
6501 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6502
ca4aa935
PE
6503 * image.c: Improve checking for integer overflow.
6504 (check_image_size): Assume that f is nonnull, since
6505 it is always nonnull in practice. This is one less thing to
6506 worry about when checking for integer overflow later.
6507 (x_check_image_size): New function, which checks for integer
6508 overflow issues inside X.
6509 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6510 This removes the need for a memory_full check.
6511 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6512 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6513 (xbm_read_bitmap_data): Change locals back to 'int', since
6514 their values must fit in 'int'.
6515 (xpm_load_image, png_load, tiff_load):
6516 Invoke x_create_x_image_and_pixmap earlier,
6517 to avoid much needless work if the image is too large.
6518 (tiff_load): Treat overly large images as if
6519 x_create_x_image_and_pixmap failed, not as malloc failures.
6520 (gs_load): Use x_check_image_size.
6521
5f8f9cc2
PE
6522 * gtkutil.c: Omit integer casts.
6523 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6524 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6525
5adf60bc
PE
6526 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6527
c8907a93
PE
6528 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6529 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6530 would wrongly return t on a 64-bit host.
6531
e3c25c68
PE
6532 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6533 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6534 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6535 and therefore cause GCC to emit a bogus diagnostic in some cases.
6536
3f791afe
PE
6537 * image.c: Integer signedness and overflow and related fixes.
6538 This is not an exhaustive set of fixes, but it's time to
6539 record what I've got.
6540 (lookup_pixel_color, check_image_size): Remove redundant decls.
6541 (check_image_size): Don't assume that arbitrary EMACS_INT values
6542 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6543 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6544 (tiff_load, imagemagick_load_image):
6545 Check for overflow in size calculations.
6546 (x_create_x_image_and_pixmap): Remove unnecessary test for
6547 xmalloc returning NULL; that can't happen.
6548 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6549 (xpm_color_bucket): Use better integer hashing function.
6550 (xpm_cache_color): Don't possibly over-allocate memory.
6551 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6552 (gif_memory_source):
6553 Use ptrdiff_t, not int or size_t, to record sizes.
6554 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6555 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6556 either works, as we prefer signed integers.
6557 (tiff_read_from_memory, tiff_write_from_memory):
6558 Return tsize_t, not size_t, since that's what the TIFF API wants.
6559 (tiff_read_from_memory): Don't fail simply because the read would
6560 go past EOF; instead, return a short read.
6561 (tiff_load): Omit no-longer-needed casts.
6562 (Fimagemagick_types): Don't assume size fits into 'int'.
6563
3cc5a532
PE
6564 Improve hashing quality when configured --with-wide-int.
6565 * fns.c (hash_string): New function, taken from sxhash_string.
6566 Do not discard information about ASCII character case; this
6567 discarding is no longer needed.
6568 (sxhash-string): Use it. Change sig to match it. Caller changed.
6569 * lisp.h: Declare it.
6570 * lread.c (hash_string): Remove, since we now use fns.c's version.
6571 The fns.c version returns a wider integer if --with-wide-int is
6572 specified, so this should help the quality of the hashing a bit.
6573
b312a492
PE
6574 * emacs.c: Integer overflow minor fix.
6575 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6576 Define only if GNU_LINUX.
6577 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6578
dfd153ae
PE
6579 * dispnew.c: Integer signedness and overflow fixes.
6580 Remove unnecessary forward decls, that were a maintenance hassle.
6581 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6582 All uses changed.
6583 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6584 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6585 (prepare_desired_row, line_draw_cost):
6586 Use int, not unsigned, where either works.
6587 (save_current_matrix, restore_current_matrix):
6588 Use ptrdiff_t, not size_t, where either works.
6589 (init_display): Check for overflow more accurately, and without
6590 relying on undefined behavior.
6591
a81d11a3
PE
6592 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6593 Remove, replacing with the new symbols in lisp.h. All uses changed.
6594 * fileio.c (make_temp_name):
6595 * filelock.c (lock_file_1, lock_file):
6596 * xdisp.c (message_dolog):
6597 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6598 Use pMd etc. instead.
6599 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6600 replacing the pWIDE etc. symbols removed from editfns.c.
6601
3300e6fd
PE
6602 * keyboard.h (num_input_events): Now uintmax_t.
6603 This is (very slightly) less likely to mess up due to wraparound.
6604 All uses changed.
6605
fd05c7e9
PE
6606 * buffer.c: Integer signedness fixes.
6607 (alloc_buffer_text, enlarge_buffer_text):
6608 Use ptrdiff_t rather than size_t when either will do, as we prefer
6609 signed integers.
6610
903fe15d
PE
6611 * alloc.c: Integer signedness and overflow fixes.
6612 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6613 (__malloc_size_t): Default to size_t, not to int.
6614 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6615 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6616 Prefer ptrdiff_t to size_t when either would do, as we prefer
6617 signed integers.
6618 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6619 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6620 Now const. Initialize with values that are in range even if char
6621 is signed.
6622 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6623 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6624 These functions do the right thing with sizes > 2**32.
6625 (check_depth): Now ptrdiff_t, not int.
6626 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6627 Adjust to new way of storing sizes. Check for size overflow bugs
6628 in rest of code.
6629 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6630 slightly wrong anyway, as it missed one instance of
6631 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6632 (refill_memory_reserve): Omit needless cast to size_t.
6633 (mark_object_loop_halt): Mark as externally visible.
6634
ac82cc6a
PE
6635 * xselect.c: Integer signedness and overflow fixes.
6636 (Fx_register_dnd_atom, x_handle_dnd_message):
6637 Use ptrdiff_t, not size_t, since we prefer signed.
6638 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6639 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6640 x_dnd_atoms_size and x_dnd_atoms_length.
6641
c2d1e36d
PE
6642 * doprnt.c: Prefer signed to unsigned when either works.
6643 * eval.c (verror):
6644 * doprnt.c (doprnt):
6645 * lisp.h (doprnt):
6646 * xdisp.c (vmessage):
6647 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6648 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6649 prefer signed arithmetic to avoid comparison confusion.
6650 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6651 but is a bit tricky.
6652
0e926e56
PE
6653 Assume freestanding C89 headers, string.h, stdlib.h.
6654 * data.c, doprnt.c, floatfns.c, print.c:
6655 Include float.h unconditionally.
6656 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6657 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6658 * regex.c: Likewise for stddef.h, string.h.
6659 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6660 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6661 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6662 (STDC_HEADERS): Remove obsolete defines.
6663 * sysdep.c: Include limits.h unconditionally.
6664
9cfdb3ec
PE
6665 Assume support for memcmp, memcpy, memmove, memset.
6666 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6667 * regex.c (memcmp, memcpy):
6668 Remove; we assume C89 now.
6669
6670 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6671 (__malloc_safe_bcopy): Remove; no longer needed.
6672
cf950e6b 6673 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6674 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6675 well either way, and we prefer signed to unsigned.
6676
dbf38e02
LMI
66772011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6678
6679 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6680 closes the connection while we're reading (bug#9182).
6681
d6f0886c 66822011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6683
d6f0886c
JD
6684 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6685 are specified (Bug#9168).
24e0f6b1 6686
2eb1f9e6
PE
66872011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6688
6689 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6690 Found by GCC static checking and --with-wide-int on a 32-bit host.
6691
22381272 66922011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6693
6694 * xdisp.c (compute_display_string_pos): Fix logic of caching
6695 previous display string position. Initialize cached_prev_pos to
6696 -1. Fixes slow-down at the beginning of a buffer.
6697
f25e39b4
EZ
66982011-07-24 Eli Zaretskii <eliz@gnu.org>
6699
6700 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6701 for attrs[LFACE_FONTSET_INDEX].
6702
04c4b52e
PE
67032011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6704
6705 * xml.c (parse_region): Remove unused local
6706 that was recently introduced.
6707
c1734fbd
EZ
67082011-07-23 Eli Zaretskii <eliz@gnu.org>
6709
be18c5a5
EZ
6710 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6711 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6712
c1734fbd
EZ
6713 * xdisp.c (move_it_in_display_line_to): Record the best matching
6714 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6715 exit if none of the characters scanned was an exact match.
6716 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6717 when exact match is impossible due to invisible text, and the
6718 lines are truncated.
6719
a258d627
JD
67202011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6721
6722 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6723 for OSX >= 10.7.
6724
b6d5a689
EZ
67252011-07-22 Eli Zaretskii <eliz@gnu.org>
6726
0f74f785
EZ
6727 Fix a significant slow-down of cursor motion with C-n, C-p,
6728 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6729 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6730 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6731 (next_element_from_buffer): Call compute_stop_pos_backwards to
6732 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6733 base_level_stop.
6734 (reseat): Don't look for prev_stop, as that could mean a very long
6735 run.
6736 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6737 <cached_disp_overlay_modiff>: Cache for last found display string
6738 position.
551918c1 6739 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6740 about the same buffer in the same area of character positions, and
6741 the buffer wasn't changed since the time the display string
6742 position was cached.
551918c1 6743
b2d0c91a
EZ
67442011-07-22 Eli Zaretskii <eliz@gnu.org>
6745
6746 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6747 is an integer, which is important for empty lines. (Bug#9149)
6748
043604ee
CY
67492011-07-22 Chong Yidong <cyd@stupidchicken.com>
6750
6751 * frame.c (Fmodify_frame_parameters): In tty case, update the
6752 default face if necessary (Bug#4238).
6753
da4adb04
CY
67542011-07-21 Chong Yidong <cyd@stupidchicken.com>
6755
6756 * editfns.c (Fstring_to_char): No need to explain what a character
6757 is in the docstring (Bug#6576).
6758
9abd0532
LMI
67592011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6760
6761 * xml.c (parse_region): Make sure we always return a tree.
6762
36881d16
HK
67632011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6764
6765 * xml.c (parse_region): If a document contains only comments,
6766 return that, too.
6767
1e98674d
LMI
67682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6769
6770 * xml.c (make_dom): Return comments, too.
6771
590bd467
PE
67722011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6773
6774 Port to OpenBSD.
6775 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6776 and the surrounding thread.
6777 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6778 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6779 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6780 timer goes off.
6781 * s/openbsd.h (BROKEN_SIGIO): Define.
6782 * unexelf.c (unexec) [__OpenBSD__]:
6783 Don't update the .mdebug section of the Alpha COFF symbol table.
6784
f41628b2
LMI
67852011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6786
6787 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6788 (bug#8460).
6789
b59b67c5
PE
67902011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6791
15e3a074
PE
6792 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6793 This fixes some race conditions on the permissions of any newly
6794 created file.
6795
41bed37d
PE
6796 * alloc.c (valid_pointer_p): Use pipe, not open.
6797 This fixes some permissions issues when debugging.
6798
b59b67c5
PE
6799 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6800 If fchown fails to set both uid and gid, try to set just gid,
6801 as that is sometimes allowed. Adjust the file's mode to eliminate
6802 setuid or setgid bits that are inappropriate if fchown fails.
6803
925a6be7
SM
68042011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6805
6806 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6807 to compare Lisp_Objects.
6808 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6809 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6810 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6811
52968808
AS
68122011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6813
0a6a104b
AS
6814 * lread.c (read_integer): Unread even EOF character.
6815 (read1): Likewise. Properly record start position of symbol.
6816
52968808
AS
6817 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6818 symbol character follows.
6819
9e381cdd
PE
68202011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6821
6822 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6823 This works around a problem with the previous change to Fcopy_file.
6824 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6825 and without this change, GCC might complain about discarding
6826 fchown's return value.
6827
b5641435
JB
68282011-07-16 Juanma Barranquero <lekktu@gmail.com>
6829
6830 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6831
a8031457
PE
68322011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6833
6834 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6835
dd889327
LMI
68362011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6837
750c33f7
LMI
6838 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6839 it's used from the C level.
6840
dd889327
LMI
6841 * process.c: Use the same condition for POLL_FOR_INPUT in both
6842 keyboard.c and process.c (bug#1858).
6843
87e86684
LM
68442011-07-09 Lawrence Mitchell <wence@gmx.li>
6845
6846 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6847 (Fgnutls_boot): Use it.
6848
64348f40
AS
68492011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6850
6851 * doc.c (Fsubstitute_command_keys): Revert last change.
6852
1d698799
LMI
68532011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6854
f863868c
LMI
6855 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6856 quotes the next character, and doesn't affect other longer
6857 sequences (bug#8935).
6858
1d698799
LMI
6859 * lread.c (syms_of_lread): Clarify that is isn't only
6860 `eval-buffer' and `eval-defun' that's affected by
6861 `lexical-binding' (bug#8460).
6862
aa4b6df6
EZ
68632011-07-15 Eli Zaretskii <eliz@gnu.org>
6864
6865 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6866 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6867
5d856da6
PE
68682011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6869
ad6042bb
PE
6870 Fix minor problems found by static checking.
6871 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6872 (elsz): Now a signed constant, not a size_t var. We prefer signed
6873 types to unsigned, to avoid integer comparison confusion. Without
6874 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6875 "cannot optimize loop, the loop counter may overflow", a symptom
6876 of the confusion.
f00bbb22 6877 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6878 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6879
6468f31c
LMI
68802011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6881
49080b10
LMI
6882 * search.c (Fre_search_backward): Mention `case-fold-search' in
6883 all the re_search_* functions (bug#8138).
6884
6468f31c
LMI
6885 * keyboard.c (Fopen_dribble_file): Document when the file is
6886 closed (bug#8056).
6887
c965adc5
EZ
68882011-07-14 Eli Zaretskii <eliz@gnu.org>
6889
df9733bf
EZ
6890 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6891 bidi_cache_idx.
6892
0bb23927
EZ
6893 Support bidi reordering of display and overlay strings.
6894 * xdisp.c (compute_display_string_pos)
6895 (compute_display_string_end): Accept additional argument STRING.
6896 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6897 (reseat_to_string): Initialize bidi_it->string.s and
6898 bidi_it->string.schars.
6899 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6900 NULL (avoids a crash in bidi_paragraph_init).
6901 Initialize itb.string.lstring.
0bb23927
EZ
6902 (init_iterator): Call bidi_init_it only of a valid
6903 buffer position was specified. Initialize paragraph_embedding to
6904 L2R.
6905 (reseat_to_string): Initialize the bidi iterator.
6906 (display_string): If we need to ignore text properties of
6907 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6908 original value of -1 will not work with bidi.)
6909 (compute_display_string_pos): First arg is now struct
6910 `text_pos *'; all callers changed. Support display properties on
6911 Lisp strings.
6912 (compute_display_string_end): Support display properties on Lisp
6913 strings.
6914 (init_iterator, reseat_1, reseat_to_string): Initialize the
6915 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6916 when iterating on a string not from display properties).
640c8776
SM
6917 (compute_display_string_pos, compute_display_string_end):
6918 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6919 arrow keys.
6920 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6921 base_level_stop; instead, set base_level_stop to BEGV.
6922 Fixes crashes in vertical-motion.
0bb23927
EZ
6923 (next_element_from_buffer): Improve commentary for when
6924 the iterator is before prev_stop.
6925 (init_iterator): Initialize bidi_p from the default value of
6926 bidi-display-reordering, not from buffer-local value. Use the
6927 buffer-local value only if initializing for buffer iteration.
6928 (handle_invisible_prop): Support invisible properties on strings
6929 that are being bidi-reordered.
6930 (set_iterator_to_next): Support bidi reordering of C strings and
6931 Lisp strings.
6932 (next_element_from_string): Support bidi reordering of Lisp
6933 strings.
6934 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6935 (display_string): Support display of R2L glyph rows.
6936 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6937 (init_iterator): Don't initialize it->bidi_p for strings
6938 here.
6939 (reseat_to_string): Initialize it->bidi_p for strings here.
6940 (next_element_from_string, next_element_from_c_string)
6941 (next_element_from_buffer): Add xassert's for correspondence
6942 between IT's object being iterated and it->bidi_it.string
6943 structure.
6944 (face_before_or_after_it_pos): Support bidi iteration.
6945 (next_element_from_c_string): Handle the case of the first string
6946 character that is not the first one in the visual order.
6947 (get_visually_first_element): New function, refactored from common
6948 parts of next_element_from_buffer, next_element_from_string, and
6949 next_element_from_c_string.
6950 (tool_bar_lines_needed, redisplay_tool_bar)
6951 (display_menu_bar): Force left-to-right direction. Add a FIXME
6952 comment for making that be controlled by a user option.
6953 (push_it, pop_it): Save and restore the state of the
6954 bidi iterator. Save and restore the bidi_p flag.
6955 (pop_it): Iterate out of display property for string iteration as
6956 well.
6957 (iterate_out_of_display_property): Support iteration over strings.
6958 (handle_single_display_spec): Set up it->bidi_it for iteration
6959 over a display string, and call bidi_init_it.
6960 (handle_single_display_spec, next_overlay_string)
6961 (get_overlay_strings_1, push_display_prop): Set up the bidi
6962 iterator for displaying display or overlay strings.
6963 (forward_to_next_line_start): Don't use the shortcut if
6964 bidi-iterating.
6965 (back_to_previous_visible_line_start): If handle_display_prop
6966 pushed the iterator stack, restore the internal state of the bidi
6967 iterator by calling bidi_pop_it same number of times.
6968 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6969 and we are bidi-iterating, don't decrement the iterator position;
6970 instead, set the first_elt flag in the bidi iterator, to produce
6971 the same effect.
6972 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6973 (push_display_prop): xassert that we are iterating a buffer.
6974 (push_it, pop_it): Save and restore paragraph_embedding member.
6975 (handle_single_display_spec, next_overlay_string)
6976 (get_overlay_strings_1, reseat_1, reseat_to_string)
6977 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6978 correctly. Don't assume unibyte strings are not bidi-reordered.
6979 (compute_display_string_pos)
6980 (compute_display_string_end): Fix handling the case of C string.
6981 (push_it, pop_it): Save and restore from_disp_prop_p.
6982 (handle_single_display_spec, push_display_prop): Set the
6983 from_disp_prop_p flag.
6984 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6985 (pop_it): Call iterate_out_of_display_property only if we are
6986 popping after iteration over a string that came from a display
6987 property. Fix a typo in popping stretch info. Add an assertion
6988 for verifying that the iterator position is in sync with the bidi
6989 iterator.
6990 (handle_single_display_spec, get_overlay_strings_1)
6991 (push_display_prop): Fix initialization of paragraph direction for
6992 string when that of the parent object is not yet determined.
6993 (reseat_1): Call bidi_init_it to resync the bidi
6994 iterator with IT's position. (Bug#7616)
6995 (find_row_edges): If ROW->start.pos gives position
6996 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6997 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6998 Reset the from_disp_prop_p flag.
6999 (SAVE_IT, RESTORE_IT): New macros.
7000 (pos_visible_p, face_before_or_after_it_pos)
7001 (back_to_previous_visible_line_start)
7002 (move_it_in_display_line_to, move_it_in_display_line)
7003 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7004 (try_scrolling, redisplay_window, display_line): Use them when
7005 saving a temporary copy of the iterator and restoring it back.
7006 (back_to_previous_visible_line_start, reseat_1)
7007 (init_iterator): Empty the bidi cache "stack".
7008 (move_it_in_display_line_to): If iterator ended up at
7009 EOL, but we never saw any buffer positions smaller than
7010 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7011 motion in bidi-reordered lines.
7012 (move_it_in_display_line_to): Record prev_method and prev_pos
7013 immediately before the call to set_iterator_to_next. Fixes cursor
7014 motion in bidi-reordered lines with stretch glyphs and strings
7015 displayed in margins. (Bug#8133) (Bug#8867)
7016 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7017 TO_CHARPOS.
640c8776
SM
7018 (pos_visible_p): Support positions in bidi-reordered lines.
7019 Save and restore bidi cache.
0bb23927
EZ
7020
7021 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7022 (bidi_paragraph_info): Delete unused struct.
7023 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7024 (bidi_cache_start): New variable.
7025 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7026 to zero.
7027 (bidi_cache_fetch_state, bidi_cache_search)
7028 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7029 (bidi_cache_find, bidi_peek_at_next_level)
7030 (bidi_level_of_next_char, bidi_find_other_level_edge)
7031 (bidi_move_to_visually_next): Compare cache index with
7032 bidi_cache_start rather than with zero.
7033 (bidi_fetch_char): Accept new argument STRING; all callers
7034 changed. Support iteration over a string. Support strings with
7035 display properties. Support unibyte strings. Fix the type of
7036 `len' according to what STRING_CHAR_AND_LENGTH expects.
7037 (bidi_paragraph_init, bidi_resolve_explicit_1)
7038 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7039 (bidi_level_of_next_char, bidi_move_to_visually_next):
7040 Support iteration over a string.
0bb23927
EZ
7041 (bidi_set_sor_type, bidi_resolve_explicit_1)
7042 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7043 can now be zero (for strings); special values 0 and -1 were
7044 changed to -1 and -2, respectively.
7045 (bidi_char_at_pos): New function.
7046 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7047 Call it instead of FETCH_MULTIBYTE_CHAR.
7048 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7049 initialized to valid values.
7050 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7051 values.
7052 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7053 the test for valid cached positions. Fix the logic for looking up
7054 the sentinel state in the cache. GCPRO the Lisp string we are
7055 iterating.
7056 (bidi_push_it, bidi_pop_it): New functions.
7057 (bidi_initialize): Initialize the bidi cache start stack pointer.
7058 (bidi_cache_ensure_space): New function, refactored from part of
7059 bidi_cache_iterator_state. Don't assume the required size is just
7060 one BIDI_CACHE_CHUNK away.
7061 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7062 (bidi_count_bytes, bidi_char_at_pos): New functions.
7063 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7064 always valid if bidi_cache_idx is valid.
7065 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7066 is valid if it's going to be used.
7067 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7068 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7069 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7070 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7071 (bidi_find_other_level_edge, bidi_cache_start_stack):
7072 All variables related to cache indices are now EMACS_INT.
c965adc5 7073
0bb23927
EZ
7074 * dispextern.h (struct bidi_string_data): New structure.
7075 (struct bidi_it): New member `string'. Make flag members be 1-bit
7076 fields, and put them last in the struct.
640c8776
SM
7077 (compute_display_string_pos, compute_display_string_end):
7078 Update prototypes.
0bb23927
EZ
7079 (bidi_push_it, bidi_pop_it): Add prototypes.
7080 (struct iterator_stack_entry): New members bidi_p,
7081 paragraph_embedding, and from_disp_prop_p.
7082 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7083 (bidi_shelve_cache, bidi_unshelve_cache):
7084 Declare prototypes.
0bb23927
EZ
7085
7086 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7087 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7088 and vector-like objects.
7089
7090 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7091 cache around display iteration.
7092
7093 * window.c (Fwindow_end, window_scroll_pixel_based)
7094 (displayed_window_lines, Frecenter): Save and restore the bidi
7095 cache around display iteration.
7096
3bbd2265
LMI
70972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7098
7099 * editfns.c (Fdelete_region): Clarify the use of the named
7100 parameters (bug#6788).
7101
adc47434
MR
71022011-07-14 Martin Rudalics <rudalics@gmx.at>
7103
7104 * indent.c (Fvertical_motion): Set and restore w->pointm when
7105 saving and restoring the window's buffer (Bug#9006).
7106
837c31f8
LMI
71072011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7108
7109 * editfns.c (Fstring_to_char): Clarify just what is returned
7110 (bug#6576). Text by Eli Zaretskii.
7111
ac389d0c
JB
71122011-07-13 Juanma Barranquero <lekktu@gmail.com>
7113
7114 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7115
0be0ce47
EZ
71162011-07-13 Eli Zaretskii <eliz@gnu.org>
7117
7118 * buffer.c (mmap_find): Fix a typo.
7119
cd18e7e3
JB
71202011-07-13 Johan Bockgård <bojohan@gnu.org>
7121
7122 Fix execution of x selection hooks.
7123 * xselect.c (Qx_lost_selection_functions)
7124 (Qx_sent_selection_functions): New vars.
7125 (syms_of_xselect): DEFSYM them.
7126 (x_handle_selection_request): Pass Qx_sent_selection_functions
7127 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7128 (x_handle_selection_clear,x_clear_frame_selections):
7129 Pass Qx_lost_selection_functions rather than
7130 Vx_lost_selection_functions to Frun_hook_with_args.
7131
47ea7f44
PE
71322011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7133
ac389d0c 7134 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7135 The old code sometimes used this field without initializing it.
7136
47ea7f44
PE
7137 * alloc.c (gc_sweep): Don't read past end of array.
7138 In theory, the old code could also have corrupted Emacs internals,
7139 though it'd be very unlikely.
7140
bc985c87
AS
71412011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7142
7143 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7144 argument. (Bug#4026)
bc985c87 7145
0cf34688
LMI
71462011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7147
b3dadd76
LMI
7148 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7149 key" (bug#4257).
7150
0cf34688
LMI
7151 * window.c (Fset_window_start): Doc fix (bug#4199).
7152 (Fset_window_hscroll): Ditto.
7153
270768cd
PE
71542011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7155
077e3dda 7156 Fix minor new problems caught by GCC 4.6.1.
270768cd 7157 * term.c (init_tty): Remove unused local.
490011a6 7158 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7159 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7160 not used otherwise.
270768cd 7161
b1f58454
CY
71622011-07-12 Chong Yidong <cyd@stupidchicken.com>
7163
7164 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7165
22b9578d
LMI
71662011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7167
6e70ab07
LMI
7168 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7169 are the mini-buffer and the echo area (bug#3320).
7170
22b9578d
LMI
7171 * term.c (init_tty): Remove support for supdup, c10 and perq
7172 terminals, which are no longer supported (bug#1482).
7173
8974cc9f
JB
71742011-07-10 Johan Bockgård <bojohan@gnu.org>
7175
7176 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7177
a560d974
JD
71782011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7179
7180 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7181 for non-popups (Bug#3642).
7182
1dae0f0a
AS
71832011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7184
268c2c36 7185 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7186 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7187 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7188 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7189 * data.c (fmod): Likewise.
7190 * dispnew.c (swap_glyphs_in_rows): Likewise.
7191 * emacs.c (memory_warning_signal): Likewise.
7192 * floatfns.c (float_error): Likewise.
7193 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7194 (otf_open, font_otf_capability, generate_otf_features)
7195 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7196 Likewise.
7197 * image.c (pbm_read_file): Likewise.
7198 * indent.c (string_display_width): Likewise.
7199 * intervals.c (check_for_interval, search_for_interval)
7200 (inc_interval_count, count_intervals, root_interval)
7201 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7202 * lread.c (defalias): Likewise.
268c2c36 7203 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7204 * regex.c (set_image_of_range_1, set_image_of_range)
7205 (regex_grow_registers): Likewise.
7206 * sysdep.c (strerror): Likewise.
7207 * termcap.c (valid_filename_p, tprint, main): Likewise.
7208 * tparam.c (main): Likewise.
7209 * unexhp9k800.c (run_time_remap, save_data_space)
7210 (update_file_ptrs, read_header, write_header, calculate_checksum)
7211 (copy_file, copy_rest, display_header): Likewise.
7212 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7213 Likewise.
7214 * xdisp.c (check_it): Likewise.
7215 * xfaces.c (register_color, unregister_color, unregister_colors):
7216 Likewise.
7217 * xfns.c (print_fontset_result): Likewise.
7218 * xrdb.c (member, fatal, main): Likewise.
7219
99033785
PE
72202011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7221
7222 Fix minor problems found by static checking (Bug#9031).
7223 * chartab.c (char_table_set_range, map_sub_char_table):
7224 Remove unused locals.
7225 (uniprop_table): Now static.
7226 * composite.c (_work_char): Remove unused static var.
7227
9cb2ac56
JB
72282011-07-09 Juanma Barranquero <lekktu@gmail.com>
7229
7230 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7231
f25661f0
JD
72322011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7233
7234 * gtkutil.c (qttip_cb): Remove code without function.
7235
8278c4fe
EZ
72362011-07-09 Eli Zaretskii <eliz@gnu.org>
7237
7238 * w32.c (pthread_sigmask): New stub.
7239
1692ae2d 72402011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7241
8a6ebd58 7242 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7243 sigprocmask is portable only for single-threaded applications, and
7244 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7245 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7246 (LIBES): Use it.
7247 * callproc.c (Fcall_process):
7248 * process.c (create_process):
7249 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7250 Use pthread_sigmask, not sigprocmask.
123403e4 7251
1b854618
JD
72522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7253
7254 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7255 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7256 wrong (Bug#8591).
7257
3fe4b549
JD
72582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7259
0ce7e563
JD
7260 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7261 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7262 (xg_hide_tooltip): Fix comment.
7263
3fe4b549
JD
7264 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7265 in registerServicesMenuSendTypes.
7266 (validRequestorForSendType): Don't check ns_return_types.
7267
7268 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7269 ns_return_type.
7270
5df75e47
JR
72712011-07-08 Jason Rumney <jasonr@gnu.org>
7272
22610910
JR
7273 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7274 SH_SHOW for hidden windows (Bug#5482).
7275
5df75e47
JR
7276 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7277 frame struct members of non-existent frames (Bug#6284).
7278
699c10bd
JD
72792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7280
4393663b
JD
7281 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7282 variable firstTime not needed on OSX >= 10.6.
7283 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7284 >= 10.5. Use setKnobProportion, setDoubleValue.
7285
7286 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7287 (MAC_OS_X_VERSION_10_5): Define if not defined.
7288 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7289 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7290 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7291
7292 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7293 cString and lossyCString on OSX >= 10.4
7294
58179cce 7295 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7296 sizeToFit on OSX >= 10.2.
7297
7298 * nsimage.m (allocInitFromFile): Don't use deprecated method
7299 bestRepresentationForDevice on OSX >= 10.6.
7300
7301 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7302 to avoid warning.
7303
7304 * emacs.c: Declare unexec_init_emacs_zone.
7305
a63e0781
JD
7306 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7307
699c10bd
JD
7308 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7309
7310 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7311 on svcsMenu (Bug#8842).
7312
7313 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7314 ns_return_types.
7315 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7316
7317 * nsterm.m (QUTF8_STRING): Declare.
7318 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7319 (validRequestorForSendType): Return type is (id).
7320 Change indexOfObjectIdenticalTo to indexOfObject.
7321 Check if we have local selection before returning self (Bug#8842).
7322 (writeSelectionToPasteboard): Put local selection into paste board
7323 if we have a local selection (Bug#8842).
7324 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7325
7326 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7327 (ns_get_local_selection): Declare.
7328
54e10184
LMI
73292011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7330
9888ff71
LMI
7331 * keymap.c (describe_map_tree): Don't insert a double newline at
7332 the end of the buffer (bug#1169) and return whether we inserted
7333 something.
7334
54e10184
LMI
7335 * callint.c (Fcall_interactively): Change "reading args" to
7336 "providing args" to try to clarify what it does (bug#1010).
7337
15fa4783
KH
73382011-07-07 Kenichi Handa <handa@m17n.org>
7339
7340 * composite.c (composition_compute_stop_pos): Ignore a static
7341 composition starting before CHARPOS (Bug#8915).
7342
7343 * xdisp.c (handle_composition_prop): Likewise.
7344
a8815b00
EZ
73452011-07-07 Eli Zaretskii <eliz@gnu.org>
7346
7347 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7348 (Bug#9015)
7349
ef7b981d 73502011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7351
7352 * character.h (unicode_category_t): New enum type.
7353
7354 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7355 (Qchar_code_property_table): New variable.
7356 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7357 (UNIPROP_COMPRESSED_FORM_P): New macros.
7358 (char_table_ascii): Uncompress the compressed values.
7359 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7360 Uncompress the compressed values.
ac389d0c 7361 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7362 (char_table_ref_and_range): Uncompress the compressed values.
7363 (sub_char_table_set): New arg is_uniprop. Callers changed.
7364 Uncompress the compressed values.
7365 (sub_char_table_set_range): Args changed. Callers changed.
7366 (char_table_set_range): Adjuted for the above change.
7367 (map_sub_char_table): Delete args default_val and parent. Add arg
7368 top. Give decoded values to a Lisp function.
640c8776 7369 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7370 values to a Lisp function. Gcpro more variables.
7371 (uniprop_table_uncompress)
7372 (uniprop_decode_value_run_length): New functions.
7373 (uniprop_decoder, uniprop_decoder_count): New variables.
7374 (uniprop_get_decoder, uniprop_encode_value_character)
7375 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7376 New functions.
7377 (uniprop_encoder, uniprop_encoder_count): New variables.
7378 (uniprop_get_encoder, uniprop_table)
7379 (Funicode_property_table_internal, Fget_unicode_property_internal)
7380 (Fput_unicode_property_internal): New functions.
7381 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7382 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7383 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7384 char-code-property-alist.
7385
640c8776 7386 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7387 Vunicode_category_table.
7388
640c8776 7389 * font.c (font_range): Adjust for the change of
c805dec0
KH
7390 Vunicode_category_table.
7391
76b397fb
DN
73922011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7393
7394 * m/iris4d.h: Remove file, move contents ...
7395 * s/irix6-5.h: ... here.
7396
22b4128e
PE
73972011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7398
7399 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7400 * alloc.c (mark_buffer):
7401 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7402 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7403 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7404 This isn't true in general, and it's particularly not true
7405 if Emacs is configured with --with-wide-int.
7406 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7407 New macros, used in the buffer.c change.
7408
869795d6
JD
74092011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7410
7411 * xsettings.c: Use both GConf and GSettings if both are available.
7412 (store_config_changed_event): Add comment.
7413 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7414 (store_tool_bar_style_changed): New functions.
5e617bc2 7415 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7416 (struct xsettings): Move font inside HAVE_XFT.
7417 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7418 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7419 Move inside HAVE_XFT.
640c8776 7420 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7421 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7422 also.
7423 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7424 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7425 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7426 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7427 (parse_settings): Move check for font inside HAVE_XFT.
7428 (read_settings, apply_xft_settings): Add comment.
7429 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7430 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7431 call store_font_name_changed.
7432 (xft_settings_event): Add comment.
7433 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7434 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7435 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7436 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7437 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7438 (xsettings_get_system_font, xsettings_get_system_normal_font):
7439 Add comment.
869795d6 7440
d8ed26bd
PE
74412011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7442
7443 Random fixes. E.g., (random) never returned negative values.
7444 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7445 subseconds part to the entropy, as that's a bit more random.
7446 Prefer signed to unsigned, since the signedness doesn't matter and
7447 in general we prefer signed. When given a limit, use a
7448 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7449 latter isn't right if USE_2_TAGS_FOR_INTS.
7450 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7451 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7452
cabf1cac
SM
74532011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7454
7455 * textprop.c (text_property_stickiness):
7456 Obey Vtext_property_default_nonsticky.
7457 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7458 * w32fns.c (syms_of_w32fns):
7459 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7460
6e9b2be9
PE
74612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7462
7463 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7464 This is more efficient than Ffile_directory_p and avoids a minor race.
7465
90186c68
LMI
74662011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7467
7c301272
LMI
7468 * buffer.c (Foverlay_put): Say what the return value is
7469 (bug#7835).
7470
c4f2d8d4
LMI
7471 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7472 is a directory before asking whether to use the file name
7473 (bug#7564).
ad637907
LMI
7474 (barf_or_query_if_file_exists): Make the "File is a directory"
7475 error be more correct.
c4f2d8d4 7476
90186c68
LMI
7477 * fns.c (Frequire): Remove the mention of the .gz files, since
7478 that's installation-specific, but keep the mention of
7479 `get-load-suffixes'.
7480
da64016e
PE
74812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7482
7483 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7484 Report string overflow if the output is too long.
7485
7d47b580
JB
74862011-07-04 Juanma Barranquero <lekktu@gmail.com>
7487
a555cb87
JB
7488 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7489 (syms_of_gnutls): Remove duplicate DEFSYM for
7490 Qgnutls_bootprop_verify_hostname_error, an error for
7491 Qgnutls_bootprop_verify_error (which is no longer used).
7492
7d47b580
JB
7493 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7494 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7495 Also (re)move comments that are misplaced or no longer relevant.
7496
1e49bfab
LMI
74972011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7498
7499 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7500
1485f4c0
CY
75012011-07-03 Chong Yidong <cyd@stupidchicken.com>
7502
7503 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7504 and background color parameters if they have been changed.
7505
a9ab721e
LMI
75062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7507
7508 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7509
cf7cff57
PE
75102011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7511
2e13213d
PE
7512 * xsettings.c (SYSTEM_FONT): Define only when used.
7513 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7514
cf7cff57
PE
7515 * keymap.c (access_keymap_1): Now static.
7516
7a8e04f7
CY
75172011-07-02 Chong Yidong <cyd@stupidchicken.com>
7518
7519 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7520 leave any prefix arg for the up event (Bug#1586).
7521
61352f62
LMI
75222011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7523
69bb1ef7
LMI
7524 * lread.c (syms_of_lread): Mention single symbols defined by
7525 `defvar' or `defconst' (bug#7154).
7526
61352f62 7527 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7528 (Frequire): Mention get-load-suffixes.
61352f62 7529
28545e04
MR
75302011-07-02 Martin Rudalics <rudalics@gmx.at>
7531
7532 * window.h (window): Remove clone_number slot.
7533 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7534 Remove.
7535 (make_parent_window, make_window, saved_window)
7536 (Fset_window_configuration, save_window_save): Don't deal with
7537 clone numbers.
7538 * buffer.c (Qclone_number): Remove declaration.
7539 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7540
3349e122
SM
75412011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7542
7543 Add multiple inheritance to keymaps.
7544 * keymap.c (Fmake_composed_keymap): New function.
7545 (Fset_keymap_parent): Simplify.
7546 (fix_submap_inheritance): Remove.
7547 (access_keymap_1): New function extracted from access_keymap to handle
7548 embedded parents and handle lists of maps.
7549 (access_keymap): Use it.
7550 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7551 (Fcopy_keymap): Handle embedded parents.
7552 (Fcommand_remapping, define_as_prefix): Simplify.
7553 (Fkey_binding): Simplify.
7554 (syms_of_keymap): Move minibuffer-local-completion-map,
7555 minibuffer-local-filename-completion-map,
7556 minibuffer-local-must-match-map, and
7557 minibuffer-local-filename-must-match-map to Elisp.
7558 (syms_of_keymap): Defsubr make-composed-keymap.
7559 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7560 (parse_menu_item): Trivial simplification.
7561
3279eb87
GM
75622011-07-01 Glenn Morris <rgm@gnu.org>
7563
7564 * Makefile.in (SETTINGS_LIBS): Fix typo.
7565
4550efdf
KI
75662011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7567
7568 * coding.c (Fencode_coding_string): Record the last coding system
7569 used, as the function doc string says (bug#8738).
7570
0949d2b6
JD
75712011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7572
7573 * xsettings.c (store_monospaced_changed): Take new font as arg and
7574 check for change against current_mono_font.
7575 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7576 (emacs_settings_constructor, emacs_settings_get_property)
7577 (emacs_settings_set_property, emacs_settings_class_init)
7578 (emacs_settings_init, gsettings_obj): Remove.
7579 (something_changedCB): New function for HAVE_GSETTINGS.
7580 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7581 with value as argument.
7582 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7583 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7584 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7585 "changed".
7586
7587 * xgselect.c: Add defined (HAVE_GSETTINGS).
7588 (xgselect_initialize): Ditto.
7589
7590 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7591 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7592 xg_select.
7593
bbc6b304
PE
75942011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7595
7596 * eval.c (struct backtrace): Simplify and port the data structure.
7597 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7598 signed bit field, as this assumption is not portable and it makes
7599 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7600 "char debug_on_exit : 1" as this is not portable either; instead,
7601 use the portable "unsigned int debug_on_exit : 1". Remove unused
7602 member evalargs. Remove obsolete comments about cc bombing out.
7603
9851bfc5
JD
76042011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7605
51bb811f 7606 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7607 Let HAVE_GSETTINGS override HAVE_GCONF.
7608 (store_monospaced_changed): New function.
7609 (EMACS_SETTINGS): A new type derived from GObject to handle
7610 GSettings notifications.
7611 (emacs_settings_constructor, emacs_settings_get_property)
7612 (emacs_settings_set_property, emacs_settings_class_init):
7613 New functions.
7614 (gsettings_client, gsettings_obj): New variables.
7615 (GSETTINGS_SCHEMA): New define.
7616 (something_changedCB): Call store_monospaced_changed.
7617 (init_gsettings): New function.
7618 (xsettings_initialize): Call init_gsettings.
7619 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7620 to NULL.
7621
640c8776 7622 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7623 GCONF_CFLAGS/LIBS.
7624
5386012d
MR
76252011-06-29 Martin Rudalics <rudalics@gmx.at>
7626
7627 * window.c (resize_root_window, grow_mini_window)
7628 (shrink_mini_window): Rename Qresize_root_window to
7629 Qwindow_resize_root_window and Qresize_root_window_vertically to
7630 Qwindow_resize_root_window_vertically.
7631
f13e0b08
PE
76322011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7633
7634 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7635
94515237
JB
76362011-06-27 Juanma Barranquero <lekktu@gmail.com>
7637
7638 * makefile.w32-in: Redesign dependencies so they reflect more
7639 clearly which files are directly included by each source file,
7640 and not through other includes.
7641
e43b6e43
MR
76422011-06-27 Martin Rudalics <rudalics@gmx.at>
7643
7644 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7645 (sort_overlays, overlay_strings): When an overlay's clone number
7646 matches the window's clone number process the overlay even if
7647 the overlay's window property doesn't match the current window.
7648
d68443dc
MR
7649 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7650 (Fwindow_hchild): Rename to Fwindow_left_child.
7651 (Fwindow_next): Rename to Fwindow_next_sibling.
7652 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7653 (resize_window_check): Rename to window_resize_check.
7654 (resize_window_apply): Rename to window_resize_apply.
7655 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7656 (Fdelete_other_windows_internal, resize_frame_windows)
7657 (Fsplit_window_internal, Fdelete_window_internal)
7658 (grow_mini_window, shrink_mini_window)
7659 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7660
c7e73be5
JD
76612011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7662
7663 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7664 (emacs_fixed_set_min_size): Remove.
7665 (emacs_fixed_new): Take frame as argument.
7666
7667 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7668 (_EmacsFixedPrivate): Remove minwidth/height.
7669 Add struct frame *f.
7670 (emacs_fixed_init): Initialize priv->f.
7671 (get_parent_class, emacs_fixed_set_min_size): Remove.
7672 (emacs_fixed_new): Set priv->f to argument.
7673 (emacs_fixed_get_preferred_width)
7674 (emacs_fixed_get_preferred_height): Use min_width/height from
7675 frames size_hint to set minimum and natural (Bug#8919).
7676 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7677 and use min_width/height from frames size_hint to set
7678 min_width/height (Bug#8919).
7679
7680 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7681 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7682 Fix indentation.
c7e73be5 7683
cf99dcf8
EZ
76842011-06-26 Eli Zaretskii <eliz@gnu.org>
7685
7686 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7687 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7688 called at ZV.
7689
029529ac
CY
76902011-06-26 Chong Yidong <cyd@stupidchicken.com>
7691
7692 * process.c (wait_reading_process_output): Bypass select if
7693 waiting for a cell while ignoring keyboard input, and input is
7694 pending. Suggested by Jan Djärv (Bug#8869).
7695
7a7ef429
PE
76962011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7697
7698 Use gnulib's dup2 module instead of rolling our own.
7699 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7700
11fdef7d 77012011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7702
7703 * dispnew.c (scrolling_window): Before scrolling, turn off a
7704 mouse-highlight in the window being scrolled.
7705
cd3520a4
JB
77062011-06-24 Juanma Barranquero <lekktu@gmail.com>
7707
7708 Move DEFSYM to lisp.h and use everywhere.
7709
7710 * character.h (DEFSYM): Move declaration...
7711 * lisp.h (DEFSYM): ...here.
7712
7713 * gnutls.c:
7714 * minibuf.c:
7715 * w32menu.c:
7716 * w32proc.c:
7717 * w32select.c: Don't include character.h.
7718
7719 * alloc.c (syms_of_alloc):
7720 * buffer.c (syms_of_buffer):
7721 * bytecode.c (syms_of_bytecode):
7722 * callint.c (syms_of_callint):
7723 * casefiddle.c (syms_of_casefiddle):
7724 * casetab.c (init_casetab_once):
7725 * category.c (init_category_once, syms_of_category):
7726 * ccl.c (syms_of_ccl):
7727 * cmds.c (syms_of_cmds):
7728 * composite.c (syms_of_composite):
7729 * dbusbind.c (syms_of_dbusbind):
7730 * dired.c (syms_of_dired):
7731 * dispnew.c (syms_of_display):
7732 * doc.c (syms_of_doc):
7733 * editfns.c (syms_of_editfns):
7734 * emacs.c (syms_of_emacs):
7735 * eval.c (syms_of_eval):
7736 * fileio.c (syms_of_fileio):
7737 * fns.c (syms_of_fns):
7738 * frame.c (syms_of_frame):
7739 * fringe.c (syms_of_fringe):
7740 * insdel.c (syms_of_insdel):
7741 * keymap.c (syms_of_keymap):
7742 * lread.c (init_obarray, syms_of_lread):
7743 * macros.c (syms_of_macros):
7744 * msdos.c (syms_of_msdos):
7745 * print.c (syms_of_print):
7746 * process.c (syms_of_process):
7747 * search.c (syms_of_search):
7748 * sound.c (syms_of_sound):
7749 * syntax.c (init_syntax_once, syms_of_syntax):
7750 * terminal.c (syms_of_terminal):
7751 * textprop.c (syms_of_textprop):
7752 * undo.c (syms_of_undo):
7753 * w32.c (globals_of_w32):
7754 * window.c (syms_of_window):
7755 * xdisp.c (syms_of_xdisp):
7756 * xfaces.c (syms_of_xfaces):
7757 * xfns.c (syms_of_xfns):
7758 * xmenu.c (syms_of_xmenu):
7759 * xsettings.c (syms_of_xsettings):
7760 * xterm.c (syms_of_xterm): Use DEFSYM.
7761
4228cf16
TZ
77622011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7763
cd3520a4 7764 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7765
7fcccf1e
PE
77662011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7767
7efb4e0e
PE
7768 Integer and buffer overflow fixes (Bug#8873).
7769
ff5844ad
PE
7770 * print.c (printchar, strout): Check for string overflow.
7771 (PRINTPREPARE, printchar, strout):
7772 Don't set size unless allocation succeeds.
7773
90532f02
PE
7774 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7775 for sizes. Check for string overflow more accurately.
7776 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7777
6d84508d
PE
7778 * macros.c: Integer and buffer overflow fixes.
7779 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7780 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7781 Use ptrdiff_t, not int, for sizes.
7782 Don't increment bufsize until after realloc succeeds.
7783 Check for size-calculation overflow.
7784 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7785
437b2cb4
PE
7786 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7787
8b9ac8b4
PE
7788 * lread.c: Integer overflow fixes.
7789 (read_integer): Radix is now EMACS_INT, not int,
7790 to improve quality of diagnostics for out-of-range radices.
7791 Calculate buffer size correctly for out-of-range radices.
7792 (read1): Check for integer overflow in radices, and in
7793 read-circle numbers.
82cb60d3
PE
7794 (read_escape): Avoid int overflow.
7795 (Fload, openp, read_buffer_size, read1)
7796 (substitute_object_recurse, read_vector, read_list, map_obarray):
7797 Use ptrdiff_t, not int, for sizes.
7798 (read1): Use EMACS_INT, not int, for sizes.
20270765 7799 Check for size overflow.
8b9ac8b4 7800
7fcccf1e
PE
7801 * image.c (cache_image): Check for size arithmetic overflow.
7802
bfbbd7e7
PE
7803 * lread.c: Integer overflow issues.
7804 (saved_doc_string_size, saved_doc_string_length)
7805 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7806 Now ptrdiff_t, not int.
7807 (read1): Don't assume doc string length fits in int. Check for
7808 out-of-range doc string lengths.
7809 (read_list): Don't assume file position fits in int.
39019e54 7810 (read_escape): Check for hex character overflow.
bfbbd7e7 7811
4e323265
LL
78122011-06-22 Leo Liu <sdl.web@gmail.com>
7813
7814 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7815 Move to minibuffer.el.
7816
85fece3e
PE
78172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7818
20b84ce9 7819 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7820 The following patches are for when GLYPH_DEBUG && !XASSERT.
7821 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7822 * dispnew.c (flush_stdout):
7823 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7824 Mark as externally visible.
7825 * dispnew.c (check_window_matrix_pointers): Now static.
7826 * dispnew.c (window_to_frame_vpos):
7827 * xfns.c (unwind_create_frame):
7828 * xterm.c (x_check_font): Remove unused local.
7829 * scroll.c (CHECK_BOUNDS):
7830 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7831 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7832 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7833 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7834 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7835 Now static.
7836 (debug_method_add): Use va_list and vsprintf rather than relying
7837 on undefined behavior with wrong number of arguments.
7838 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7839 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7840 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7841 since we're not interested in debugging glyphs with old libraries.
7842 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7843 GCC 4.6.0's static checking.
7844
0766b489
PE
78452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7846
31fd4b32
PE
7847 Integer overflow and signedness fixes (Bug#8873).
7848 A few related buffer overrun fixes, too.
7849
b79e8648
PE
7850 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7851
0766b489
PE
7852 * dispextern.h (struct face.stipple):
7853 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7854 (x_bitmap_mask, x_allocate_bitmap_record)
7855 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7856 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7857 (x_create_bitmap_from_xpm_data):
7858 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7859 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7860 (.bitmaps_last):
7861 * xfaces.c (load_pixmap):
7862 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7863 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7864 (.bitmaps_last, struct x_output.icon_bitmap):
7865 Use ptrdiff_t, not int, for bitmap indexes.
7866 (x_allocate_bitmap_record): Check for size overflow.
7867 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7868
b081724f
PE
7869 Use ptrdiff_t, not int, for overlay counts.
7870 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7871 * editfns.c (overlays_around, get_pos_property):
7872 * textprop.c (get_char_property_and_overlay):
7873 * xdisp.c (next_overlay_change, note_mouse_highlight):
7874 * xfaces.c (face_at_buffer_position):
21514da7
PE
7875 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7876 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7877 (Fnext_overlay_change, Fprevious_overlay_change)
7878 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7879 Use ptrdiff_t, not int, for sizes.
21514da7 7880 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7881
3de73e5e
PE
7882 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7883
2606c57b
PE
7884 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7885 (x_session_initialize): Do not assume string length fits in int.
7886
aaafe47a
PE
7887 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7888 This is unlikely, but can occur if DPI is outlandish.
7889
2674ddc8 7890 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7891 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7892
28154962
PE
7893 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7894 * xrdb.c (magic_file_p, search_magic_path):
7895 Omit last arg SUFFIX; it was always 0. All callers changed.
7896 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7897
7de51af5
PE
7898 * xfont.c (xfont_match): Avoid need for strlen.
7899
25ed6cc3
PE
7900 * xfns.c: Don't assume strlen fits in int.
7901 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7902
4eab31dd
PE
7903 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7904 not unsigned long, as we prefer signed integers. All callers changed.
7905 Detect integer overflow in repeat count.
7906 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7907 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7908
171e2a58
PE
7909 * termcap.c: Don't assume sizes fit in int and never overflow.
7910 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7911 (gobble_line): Check for size-calculation overflow.
7912
ad39faca 7913 * minibuf.c (Fread_buffer):
6e5bb2dc 7914 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7915 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7916 Don't assume string length fits in int.
7917
52c61c22 7918 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7919 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7920
b5b8c9e5
PE
7921 * font.c: Don't assume string length fits in int.
7922 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7923 Use ptrdiff_t, not int.
ccd6111c
PE
7924 (font_intern_prop): Don't assume string length fits in int.
7925 Don't assume integer property fits in fixnum.
7926 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7927
882f0d81 7928 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7929 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7930 Reformulate so as not to need the command string.
7931 Invoke gzip -cd rather than gunzip, as it's more portable.
7932 (lock_info_type, lock_file_1, lock_file):
7933 Don't assume pid_t and time_t fit in unsigned long.
7934 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7935 (current_lock_owner): Prefer signed type for sizes.
7936 Use memcpy, not strncpy, where memcpy is what is really wanted.
7937 Don't assume (via atoi) that time_t and pid_t fit in int.
7938 Check for time_t and/or pid_t out of range, e.g., via a network share.
7939 Don't alloca where an auto var works fine.
7940
93f4cf88
PE
7941 * fileio.c: Fix some integer overflow issues.
7942 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7943 Don't assume string length fits in int.
7944 (directory_file_name): Don't assume string length fits in long.
7945 (make_temp_name): Don't assume pid fits in int, or that its print
7946 length is less than 20.
7947
f3e92b69
PE
7948 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7949
1bfdaf10
PE
7950 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7951
35016e9a
PE
7952 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7953
3d1e65a1
PE
7954 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7955 We prefer signed integers, even for size calculations.
7956
0b963a93
PE
7957 * emacs.c: Don't assume string length fits in 'int'.
7958 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7959 (main): Don't invoke strlen when not needed.
7960
573f4b54
PE
7961 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7962 (XD_DEBUG_MESSAGE): Don't waste a byte.
7963
989f33ba
PE
7964 * callproc.c (getenv_internal_1, getenv_internal)
7965 (Fgetenv_internal):
965d34eb
PE
7966 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7967
e4d29b33
PE
7968 * lread.c (invalid_syntax): Omit length argument.
7969 All uses changed. This doesn't fix a bug, but it simplifies the
7970 code away from its former Hollerith-constant appearance, and it's
7971 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7972 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7973
eb49b136
PE
7974 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7975 This didn't break anything, but it didn't help either.
7976 It's confusing to put a bogus integer in a place where the actual
7977 value does not matter.
9f62aeb1 7978 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7979 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7980
15375a22
PE
7981 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7982 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7983 implementation.
b61cc01c
PE
7984 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7985 We prefer signed types, and the value cannot exceed the EMACS_INT
7986 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7987 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7988 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7989 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7990
53b2623d
PE
7991 * indent.c (sane_tab_width): New function.
7992 (current_column, scan_for_column, Findent_to, position_indentation)
7993 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7994 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7995
51cab52b 7996 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7997
f2ed8a70
PE
7998 * lisp.h (lint_assume): New macro.
7999 * composite.c (composition_gstring_put_cache):
8000 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8001
abe80cc6
PE
8002 * editfns.c, insdel.c:
8003 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8004
b02c740e
PE
8005 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8006
ebc96716
PE
8007 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8008
b4e50fa0 8009 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8010 Use much-faster test for byte-length change.
311d5d7c 8011 Don't assume string byte-length fits in 'int'.
a4cf38e4 8012 Check that character arg fits in 'int'.
85461888 8013 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8014
c0c1ee9f
PE
8015 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8016
a498d7f4
PE
8017 * fns.c (concat): Catch string overflow earlier.
8018 Do not rely on integer wraparound.
8019
51cab52b
PE
8020 * dispextern.h (struct it.overlay_strings_charpos)
8021 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8022 * xdisp.c (forward_to_next_line_start)
8023 (back_to_previous_visible_line_start)
8024 (reseat_at_next_visible_line_start, next_element_from_buffer):
8025 Don't arbitrarily truncate the value of 'selective' to int.
8026
76031fad
PE
8027 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8028
5eb55db9
PE
8029 * composite.c: Don't truncate sizes to 'int'.
8030 (composition_gstring_p, composition_reseat_it)
8031 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8032 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8033 not EMACS_UINT, for indexes.
5eb55db9 8034
0703a717
PE
8035 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8036
d6202519
PE
8037 * buffer.c: Include <verify.h>.
8038 (struct sortvec.priority, struct sortstr.priority):
8961a454 8039 Now EMACS_INT, not int.
c20998a7 8040 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8041 (struct sortstr.size, record_overlay_string)
8042 (struct sortstrlist.size, struct sortlist.used):
8043 Don't truncate size to int.
8044 (record_overlay_string): Check for size-calculation overflow.
d6202519 8045 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8046
d5a19415
JM
80472011-06-22 Jim Meyering <meyering@redhat.com>
8048
029529ac 8049 Don't leak an XBM-image-sized buffer
d5a19415
JM
8050 * image.c (xbm_load): Free the image buffer after using it.
8051
a9041e6c
PE
80522011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8053
8054 Port to Sun C.
8055 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8056 that Sun C diagnosed.
8057 * fns.c (secure_hash): Fix pointer signedness issue.
8058 * intervals.c (static_offset_intervals): New function.
8059 (offset_intervals): Use it.
8060
7f3f739f
LL
80612011-06-21 Leo Liu <sdl.web@gmail.com>
8062
8063 * deps.mk (fns.o):
8064 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8065 sha512.h.
8066
8067 * fns.c (secure_hash): Rename from crypto_hash_function and change
8068 the first arg to accept symbols.
5b66d427 8069 (Fsecure_hash): New primitive.
7f3f739f
LL
8070 (syms_of_fns): New symbols.
8071
76147d94
DD
80722011-06-20 Deniz Dogan <deniz@dogan.se>
8073
8074 * process.c (Fset_process_buffer): Clarify return value in
8075 docstring.
8076
7d7d0045
CY
80772011-06-18 Chong Yidong <cyd@stupidchicken.com>
8078
8079 * dispnew.c (add_window_display_history): Use BVAR.
8080
8081 * xdisp.c (debug_method_add): Use BVAR.
8082 (check_window_end, dump_glyph_matrix, dump_glyph)
8083 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8084
8085 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8086 Likewise.
8087
8088 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8089 check till after the cache is created in init_frame_faces.
8090
ff2bc410
SM
80912011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8092
8093 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8094
28177add
PE
80952011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8096
dd3482fe
PE
8097 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8098 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8099 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8100
393d71f3 8101 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8102 * fileio.c (Finsert_file_contents):
8103 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8104 Remove the old (too-loose) buffer overflow checks.
8105 They weren't needed, since make_gap checks for buffer overflow.
8106 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8107 The old code merely checked for Emacs fixnum overflow, and relied
8108 on undefined (wraparound) behavior. The new code avoids undefined
8109 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8110
2e6813b0 8111 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8112 Tune. Don't use wider integers than needed. Don't use alloca.
8113 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8114
599a9e4f
PE
8115 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8116
99561444
PE
8117 * insdel.c, lisp.h (buffer_overflow): New function.
8118 (insert_from_buffer_1, replace_range, replace_range_2):
8119 * insdel.c (make_gap_larger):
8120 * editfns.c (Finsert_char):
8121 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8122
28177add
PE
8123 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8124
e69dafad
PE
81252011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8126
4baa020d 8127 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8128
b1c46f02
PE
8129 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8130 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8131
e69dafad
PE
8132 * fileio.c: Don't assume EMACS_INT fits in off_t.
8133 (emacs_lseek): New static function.
8134 (Finsert_file_contents, Fwrite_region): Use it.
8135 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8136
566684ea
PE
8137 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8138
e6966cd6
PE
8139 * fns.c: Don't overflow int when computing a list length.
8140 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8141 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8142 truncation on 64-bit hosts. Check for QUIT every
8143 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8144 faster and is responsive enough.
8145 (Flength): Report an error instead of overflowing an integer.
8146 (Fsafe_length): Return a float if the value is not representable
8147 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8148 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8149 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8150
dd0b0efb
PE
8151 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8152 (header_size, word_size): New constants.
8153 (allocate_vectorlike): Don't check size overflow here.
8154 (allocate_vector): Check it here instead, since this is the only
8155 caller of allocate_vectorlike that could cause overflow.
8156 Check that the new vector's length is representable as a fixnum.
8157
86fe5cfe
PE
8158 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8159 The previous code was bogus. For example, next_almost_prime (32)
8160 returned 39, which is undesirable as it is a multiple of 3; and
8161 next_almost_prime (24) returned 25, which is a multiple of 5 so
8162 why was the code bothering to check for multiples of 7?
8163
80e88859
PE
8164 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8165
4a2f0ad6
PE
8166 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8167
f66c7cf8
PE
8168 Variadic C functions now count arguments with ptrdiff_t.
8169 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8170 Back then I didn't know that the Emacs coding style prefers signed int.
8171 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8172 were being counted with int, which may truncate counts on 64-bit
8173 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8174 * lisp.h (struct Lisp_Subr.function.aMANY)
8175 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8176 Arg counts are now ptrdiff_t, not size_t.
8177 All variadic functions and their callers changed accordingly.
8178 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8179 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8180 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8181 * callint.c (Fcall_interactively): Check arg count for overflow,
8182 to avoid potential buffer overrun. Use signed char, not 'int',
8183 for 'varies' array, so that we needn't bother to check its size
8184 calculation for overflow.
8185 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8186 * eval.c (apply_lambda):
8187 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8188 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8189 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8190
a1759b76
PE
8191 * callint.c (Fcall_interactively): Don't use index var as event count.
8192
d96be9fc
PE
8193 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8194 * mem-limits.h (SIZE): Remove; no longer used.
8195
a690a978 8196 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8197
578c21e6
PE
8198 Remove unnecessary casts.
8199 * xterm.c (x_term_init):
8200 * xfns.c (x_set_border_pixel):
8201 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8202 These aren't needed now that we assume ANSI C.
8203
96f53c6c
PE
8204 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8205 It's more likely to cause problems (due to unsigned overflow)
8206 than to cure them.
8207
83c77d31
PE
8208 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8209
ee2079f1
PE
8210 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8211
6da65536
PE
8212 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8213
7147c4a4
PE
8214 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8215
193e32d9
PE
8216 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8217
e5533da6
PE
8218 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8219
9910e595
PE
8220 GLYPH_CODE_FACE returns EMACS_INT, not int.
8221 * dispextern.h (merge_faces):
8222 * xfaces.c (merge_faces):
01103c44
PE
8223 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8224 Don't assume EMACS_INT fits in int.
9910e595 8225
2638320e
PE
8226 * character.h (CHAR_VALID_P): Remove unused parameter.
8227 * fontset.c, lisp.h, xdisp.c: All uses changed.
8228
045eb8d9
PE
8229 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8230
c1f134b5
PE
8231 * fns.c (concat): Minor tuning based on overflow analysis.
8232 This doesn't fix any bugs. Use int to hold character, instead
8233 of constantly refetching from Emacs object. Use XFASTINT, not
8234 XINT, for value known to be a character. Don't bother comparing
8235 a single byte to 0400, as it's always less.
8236
395fcb93 8237 * floatfns.c (Fexpt):
327eeec8
PE
8238 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8239
abbd3d23
PE
8240 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8241 for characters.
8242
684a03ef
PE
8243 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8244
0fed43f3
PE
8245 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8246 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8247 incorrectly succeed when S was a string, because 4294967386 was
8248 truncated before it was used.
8249
8fd02eb7
PE
8250 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8251 Otherwise, an out-of-range integer could cause undefined behavior
8252 on a 64-bit host.
8253
f8c86b69
PE
8254 * composite.c: Use int, not EMACS_INT, for characters.
8255 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8256 EMACS_INT, for values that are known to be in character range.
8257 This doesn't fix any bugs but is the usual style inside Emacs and
8258 may generate better code on 32-bit machines.
8259
34206dd2
PE
8260 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8261 This is for reasons similar to the recent CHAR_STRING fix.
8262 * charset.c (Fencode_char): Check that character arg is actually
8263 a character. Pass an int to ENCODE_CHAR.
8264 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8265 wider than 'int', as a compile-time check to prevent future regressions
8266 in this area.
8267
c5958d4c 8268 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8269
8270 Make sure a 64-bit char is never passed to CHAR_STRING.
8271 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8272 by silently ignoring the top 32 bits, allowing some values
8273 that were far too large to be valid characters.
8274 * character.h: Include <verify.h>.
8275 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8276 arguments are no wider than unsigned, as a compile-time check
8277 to prevent future regressions in this area.
8278 * data.c (Faset):
01103c44 8279 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8280 (Fsubst_char_in_region):
8281 * fns.c (concat):
8282 * xdisp.c (decode_mode_spec_coding):
8283 Adjust to CHAR_STRING's new requirement.
8284 * editfns.c (Finsert_char, Fsubst_char_in_region):
8285 * fns.c (concat): Check that character args are actually
8286 characters. Without this test, these functions did the wrong
8287 thing with wildly out-of-range values on 64-bit hosts.
8288
d37ca623
PE
8289 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8290 These casts should not be needed on 32-bit hosts, either.
8291 * keyboard.c (read_char):
8292 * lread.c (Fload): Remove casts to unsigned.
8293
ea204efb
PE
8294 * lisp.h (UNSIGNED_CMP): New macro.
8295 This fixes comparison bugs on 64-bit hosts.
8296 (ASCII_CHAR_P): Use it.
8297 * casefiddle.c (casify_object):
01103c44 8298 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8299 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8300 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8301 * dispextern.h (FACE_FROM_ID):
8302 * keyboard.c (read_char): Use UNSIGNED_CMP.
8303
41cb286c
PE
8304 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8305 not to EMACS_INT, to avoid GCC warning.
8306
4a1b9832
PE
8307 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8308
55daad71
PE
8309 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8310 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8311 isn't needed on 32-bit machines.
8f95c75c 8312
01103c44
PE
8313 * buffer.c (Fgenerate_new_buffer_name):
8314 Use EMACS_INT for count, not int.
0ceccced 8315 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8316
8317 * data.c (Qcompiled_function): Now static.
8318
c6f072e7
PE
8319 * window.c (window_body_lines): Now static.
8320
20ce5912
PE
8321 * image.c (gif_load): Rename local to avoid shadowing.
8322
9c4c5f81
PE
8323 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8324 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8325 * alloc.c (make_save_value): Integer argument is now of type
8326 ptrdiff_t, not int.
8327 (mark_object): Use ptrdiff_t, not int.
8328 * lisp.h (pD): New macro.
8329 * print.c (print_object): Use it.
8330
c0c5c8ae
PE
8331 * alloc.c: Use EMACS_INT, not int, to count objects.
8332 (total_conses, total_markers, total_symbols, total_vector_size)
8333 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8334 (total_free_floats, total_floats, total_free_intervals)
8335 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8336 Now EMACS_INT, not int. All uses changed.
8337 (Fgarbage_collect): Compute overall total using a double, so that
8338 integer overflow is less likely to be a problem. Check for overflow
8339 when converting back to an integer.
5a25e253
PE
8340 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8341 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8342 These were 'int' variables that could overflow on 64-bit hosts;
8343 they were never used, so remove them instead of repairing them.
211a0b2a 8344 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8345 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8346 Previously, this ceilinged at INT_MAX, but that doesn't work on
8347 64-bit machines.
e46bb31a 8348 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8349
c78baabf 8350 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8351 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8352 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8353 when a (possibly-narrower) signed value would do just as well.
8354 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8355
c9d624c6
PE
8356 * alloc.c: Catch some string size overflows that we were missing.
8357 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8358 for convenience in STRING_BYTES_MAX.
8359 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8360 The definition here is exact; the one in lisp.h was approximate.
8361 (allocate_string_data): Check for string overflow. This catches
8362 some instances we weren't catching before. Also, it catches
8363 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8364 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8365 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8366
c9d624c6
PE
8367 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8368 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8369 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8370
353032ce
PE
8371 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8372
2bccce07
PE
8373 * alloc.c (Fmake_string): Check for out-of-range init.
8374
0ac30604
SM
83752011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8376
8377 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8378
c195f2de
JD
83792011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8380
8381 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8382 xg_get_default_scrollbar_width.
8383
8384 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8385 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8386 (style_changed_cb): Call update_theme_scrollbar_width and call
8387 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8388 all frames (Bug#8505).
8389 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8390 Call gtk_window_set_resizable if HAVE_GTK3.
8391 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8392 and height if HAVE_GTK3 (Bug#8505).
8393 (scroll_bar_width_for_theme): New variable.
8394 (update_theme_scrollbar_width): New function.
8395 (xg_get_default_scrollbar_width): Move code to
8396 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8397 (xg_initialize): Call update_theme_scrollbar_width.
8398
8399 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8400
8401 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8402
e10ac9f1
MR
84032011-06-12 Martin Rudalics <rudalics@gmx.at>
8404
8405 * frame.c (make_frame): Call other_buffer_safely instead of
8406 other_buffer.
8407
8408 * window.c (temp_output_buffer_show): Call display_buffer with
8409 second argument Vtemp_buffer_show_specifiers and reset latter
8410 immediately after the call.
8411 (Vtemp_buffer_show_specifiers): New variable.
8412 (auto_window_vscroll_p, next_screen_context_lines)
8413 (Vscroll_preserve_screen_position): Remove leading asterisks from
8414 doc-strings.
8415
2d3c217e 84162011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8417
7b7f97e8 8418 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8419 * buffer.c (Qclone_number): Remove for now, as it's unused.
8420 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8421 (record_buffer): Remove unused local.
8422 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8423 (set_frame_buffer_list): Remove; unused.
8424 * frame.h (other_visible_frames): Remove decl.
8425 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8426 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8427 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8428 if HAVE_GPM.
8429 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8430 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8431 Define only if HAVE_GPM.
8432 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8433 (update_hints_inhibit): Remove; never set. All uses removed.
8434 * widgetprv.h (emacsFrameClassRec): Remove decl.
8435 * window.c (delete_deletable_window): Now returns void, since it
8436 wasn't returning anything.
8437 (compare_window_configurations): Remove unused locals.
8438 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8439 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8440 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8441 the same widths as pointers. This follows up on the 2011-05-06 patch.
8442 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8443 * xterm.h: Likewise.
8444 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8445
1384b89e
JB
84462011-06-12 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * makefile.w32-in: Update dependencies.
8449 (LISP_H): Add lib/intprops.h.
8450
1100a63c
CY
84512011-06-11 Chong Yidong <cyd@stupidchicken.com>
8452
8453 * image.c (gif_load): Add animation frame delay to the metadata.
8454 (syms_of_image): Use DEFSYM. New symbol `delay'.
8455
6198ccd0
MR
84562011-06-11 Martin Rudalics <rudalics@gmx.at>
8457
8458 * window.c (delete_deletable_window): Re-add.
8459 (Fset_window_configuration): Rewrite to handle dead buffers and
8460 consequently deletable windows.
8461 (window_tree, Fwindow_tree): Remove. Supply functionality in
8462 window.el.
8463 (compare_window_configurations): Simplify code.
8464
b6e3633c
AS
84652011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8466
1ab0dee5
AS
8467 * image.c (imagemagick_load_image): Fix type mismatch.
8468 (Fimagemagick_types): Likewise.
8469
b6e3633c
AS
8470 * window.h (replace_buffer_in_windows): Declare.
8471
9397e56f
MR
84722011-06-11 Martin Rudalics <rudalics@gmx.at>
8473
8474 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8475 Qclone_number. Remove external declaration of Qdelete_window.
8476 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8477 code.
640c8776
SM
8478 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8479 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8480 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8481 buffer list implementation.
8482 (other_buffer_safely): New function.
8483 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8484 calls to replace_buffer_in_windows and
8485 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8486 if allowed.
8487 (record_buffer): Inhibit quitting and rewrite using quittable
8488 functions. Run Qbuffer_list_update_hook if allowed.
8489 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8490 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8491 Move switch-to-buffer to window.el.
9397e56f
MR
8492 (bury-buffer): Move to window.el.
8493 (Vbuffer_list_update_hook): New variable.
8494
8495 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8496 section.
8497
8498 * window.h (resize_frame_windows): Move up in code.
8499 (Fwindow_frame): Remove EXFUN.
8500 (replace_buffer_in_all_windows): Remove prototype.
8501 (replace_buffer_in_windows_safely): Add prototype.
8502
8503 * window.c: Declare Qdelete_window static again. Move down
8504 declaration of select_count.
8505 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8506 (Fother_window): Move to window.el.
8507 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8508 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8509 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8510 window.el.
8511 (replace_buffer_in_windows): Implement by calling
8512 Qreplace_buffer_in_windows.
8513 (replace_buffer_in_all_windows): Remove with some functionality
8514 moved into replace_buffer_in_windows_safely.
8515 (replace_buffer_in_windows_safely): New function.
8516 (select_window_norecord, select_frame_norecord): Move in front
8517 of run_window_configuration_change_hook. Remove now obsolete
8518 declarations.
640c8776
SM
8519 (Fset_window_buffer): Rewrite doc-string.
8520 Call Qrecord_window_buffer.
9397e56f
MR
8521 (keys_of_window): Move binding for other-window to window.el.
8522
b50691aa
CY
85232011-06-11 Chong Yidong <cyd@stupidchicken.com>
8524
8525 * dispextern.h (struct image): Replace data member, whose int_val
8526 and ptr_val fields were not used by anything, with a single
8527 lisp_val object.
8528
8529 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8530 (gif_clear_image, gif_load, imagemagick_load_image)
8531 (gs_clear_image, gs_load): Callers changed.
8532
3f754b86
PE
85332011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8534
cca69397
PE
8535 * buffer.h: Include <time.h>, for time_t.
8536 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8537
109e28d0
PE
8538 Fix minor problems found by static checking.
8539
60737f02
PE
8540 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8541
4b66faf3
PE
8542 Make identifiers static if they are not used in other modules.
8543 * data.c (Qcompiled_function, Qframe, Qvector):
8544 * image.c (QimageMagick, Qsvg):
8545 * minibuf.c (Qmetadata):
8546 * window.c (resize_window_check, resize_root_window): Now static.
8547 * window.h (resize_window_check, resize_root_window): Remove decls.
8548
109e28d0
PE
8549 * window.c (window_deletion_count, delete_deletable_window):
8550 Remove; unused.
46a4ce9e
PE
8551 (window_body_lines): Now static.
8552 (Fdelete_other_windows_internal): Mark vars as initialized.
8553 Make sure 'resize_failed' is initialized.
8554 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8555 (resize_window_apply): Remove unused local.
8556 * window.h (delete_deletable_window): Remove decl.
8557
109e28d0 8558 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8559 (imagemagick_load_image): Fix pointer signedness problem by changing
8560 last arg from unsigned char * to char *. All uses changed.
8561 Also, fix a local for similar reasons.
8562 Remove unused locals. Remove locals to avoid shadowing.
8563 (fn_rsvg_handle_free): Remove; unused.
8564 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8565 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8566
3f754b86
PE
8567 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8568
2547adb1
CY
85692011-06-10 Chong Yidong <cyd@stupidchicken.com>
8570
8571 * image.c (gif_load): Fix omitted cast error introduced by
8572 2011-06-06 change.
8573
2c8e37d4
MR
85742011-06-10 Martin Rudalics <rudalics@gmx.at>
8575
8576 * window.h (resize_proportionally, orig_total_lines)
8577 (orig_top_line): Remove from window structure.
8578 (set_window_height, set_window_width, change_window_heights)
8579 (Fdelete_window): Remove prototypes.
8580 (resize_frame_windows): Remove duplicate declaration.
8581
440a42e3
EZ
85822011-06-10 Eli Zaretskii <eliz@gnu.org>
8583
8584 * window.h (resize_frame_windows, resize_window_check)
8585 (delete_deletable_window, resize_root_window)
8586 (resize_frame_windows): Declare prototypes.
8587
8588 * window.c (resize_window_apply): Make definition be "static" to
8589 match the prototype.
8590
562dd5e9
MR
85912011-06-10 Martin Rudalics <rudalics@gmx.at>
8592
8593 * window.c: Remove declarations of Qwindow_size_fixed,
8594 window_min_size_1, window_min_size_2, window_min_size,
8595 size_window, window_fixed_size_p, enlarge_window, delete_window.
8596 Remove static from declaration of Qdelete_window, it's
8597 temporarily needed by Fbury_buffer.
8598 (replace_window): Don't assign orig_top_line and
8599 orig_total_lines.
8600 (Fdelete_window, delete_window): Remove. Window deletion is
8601 handled by window.el.
640c8776
SM
8602 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8603 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8604 (Fdelete_other_windows): Remove. Deleting other windows is
8605 handled by window.el.
8606 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8607 handled in window.el.
8608 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8609 Window minimum sizes are handled in window.el.
8610 (shrink_windows, size_window, set_window_height)
8611 (set_window_width, change_window_heights, window_height)
8612 (window_width, CURBEG, CURSIZE, enlarge_window)
8613 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8614 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8615 handled in window.el.
8616 (make_dummy_parent): Rename to make_parent_window and give it a
8617 second argument horflag.
8618 (make_window): Don't set resize_proportionally any more.
8619 (Fsplit_window): Remove. Windows are split in window.el.
8620 (save_restore_action, save_restore_orig_size)
8621 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8622 Resize mini windows in window.el.
8623 (grow_mini_window, shrink_mini_window): Implement by calling
8624 Qresize_root_window_vertically, resize_window_check and
8625 resize_window_apply.
640c8776
SM
8626 (saved_window, Fset_window_configuration, save_window_save):
8627 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8628 resize_proportionally.
8629 (window_min_height, window_min_width): Move to window.el.
8630 (keys_of_window): Move bindings for delete-other-windows,
8631 split-window, delete-window and enlarge-window to window.el.
8632
8633 * buffer.c: Temporarily extern Qdelete_window.
8634 (Fbury_buffer): Temporarily call Qdelete_window instead of
8635 Fdelete_window (Fbury_buffer will move to window.el soon).
8636
8637 * frame.c (set_menu_bar_lines_1): Remove code handling
8638 orig_top_line and orig_total_lines.
8639
8640 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8641 set_window_height but set heights directly.
8642 (change_frame_size_1): Use resize_frame_windows.
8643
8644 * xdisp.c (init_xdisp): Don't use set_window_height but set
8645 heights directly.
8646
640c8776
SM
8647 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8648 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8649 run_window_configuration_change_hook.
8650
8651 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8652 instead of change_window_heights and run
8653 run_window_configuration_change_hook.
8654
1a13852e
MR
86552011-06-09 Martin Rudalics <rudalics@gmx.at>
8656
8657 * window.c (replace_window): Rename second argument REPLACEMENT to
8658 NEW. New third argument SETFLAG. Rewrite.
8659 (delete_window, make_dummy_parent): Call replace_window with
8660 third argument 1.
8661 (window_list_1): Move down in code.
8662 (run_window_configuration_change_hook): Move set_buffer part
8663 before select_frame_norecord part in order to unwind correctly.
8664 Rename count1 to count.
8665 (recombine_windows, delete_deletable_window, resize_root_window)
8666 (Fdelete_other_windows_internal)
8667 (Frun_window_configuration_change_hook, make_parent_window)
8668 (resize_window_check, resize_window_apply, Fresize_window_apply)
8669 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8670 (Fdelete_window_internal, Fresize_mini_window_internal):
8671 New functions.
1a13852e
MR
8672 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8673
f3d1777e
MR
86742011-06-08 Martin Rudalics <rudalics@gmx.at>
8675
496e208e
MR
8676 * window.h (window): Add some new members to window structure -
8677 normal_lines, normal_cols, new_total, new_normal, clone_number,
8678 splits, nest, prev_buffers, next_buffers.
8679 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8680 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8681
f3d1777e
MR
8682 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8683 Remove.
496e208e
MR
8684 (make_dummy_parent): Set new members of windows structure.
8685 (make_window): Move down in code. Handle new members of window
8686 structure.
8687 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8688 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8689 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8690 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8691 (Fset_window_next_buffers, Fset_window_clone_number):
8692 New functions.
496e208e
MR
8693 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8694 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8695 Doc-string fixes.
8696 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8697 Argument WINDOW can be now internal window too.
8698 (Fwindow_use_time): Move up in code.
8699 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8700 Rewrite doc-string.
8701 (Fset_window_configuration, saved_window)
8702 (Fcurrent_window_configuration, save_window_save): Handle new
8703 members of window structure.
b9e809c2
MR
8704 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8705 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8706 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8707 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8708 Qget_mru_window, Qresize_root_window,
8709 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8710 Qauto_buffer_name; staticpro them.
f3d1777e 8711
abde8f8c
MR
87122011-06-07 Martin Rudalics <rudalics@gmx.at>
8713
8714 * window.c (Fwindow_total_size, Fwindow_left_column)
8715 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8716 (Fwindow_list_1): New functions.
8717 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8718 (Fwindow_width, Fscroll_left, Fscroll_right):
8719 Use window_body_cols instead of window_box_text_cols.
8720 (delete_window, Fset_window_configuration):
8721 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8722 (delete_all_subwindows): Take a window as argument and not a
8723 structure. Rewrite.
190b47e6
MR
8724 (window_loop): Remove handling of GET_LRU_WINDOW and
8725 GET_LARGEST_WINDOW.
8726 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8727
8728 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8729 window_box_text_cols. delete_all_subwindows now takes a
8730 Lisp_Object as argument.
abde8f8c 8731
640c8776
SM
8732 * indent.c (compute_motion, Fcompute_motion):
8733 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8734
fa8a67e6
MR
8735 * frame.c (delete_frame): Call delete_all_subwindows with root
8736 window as argument.
8737
a54e3482
DC
87382011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8739
8740 * fns.c (Fputhash): Document return value.
8741
60002bf5
CY
87422011-06-06 Chong Yidong <cyd@stupidchicken.com>
8743
8744 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8745
0c671da6 87462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8747
b862a52a 8748 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8749
be44ca6c
PE
8750 Check for overflow when converting integer to cons and back.
8751 * charset.c (Fdefine_charset_internal, Fdecode_char):
8752 Use cons_to_unsigned to catch overflow.
8753 (Fencode_char): Use INTEGER_TO_CONS.
8754 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8755 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8756 * data.c (long_to_cons, cons_to_long): Remove.
8757 (cons_to_unsigned, cons_to_signed): New functions.
8758 These signal an error for invalid or out-of-range values.
8759 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8760 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8761 * font.c (Ffont_variation_glyphs):
8762 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8763 * lisp.h: Include <intprops.h>.
8764 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8765 (cons_to_signed, cons_to_unsigned): New decls.
8766 (long_to_cons, cons_to_long): Remove decls.
8767 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8768 (Fprimitive_undo): Use CONS_TO_INTEGER.
8769 * xfns.c (Fx_window_property): Likewise.
8770 * xselect.c: Include <limits.h>.
8771 (x_own_selection, selection_data_to_lisp_data):
8772 Use INTEGER_TO_CONS.
8773 (x_handle_selection_request, x_handle_selection_clear)
8774 (x_get_foreign_selection, Fx_disown_selection_internal)
8775 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8776 (lisp_data_to_selection_data): Use cons_to_unsigned.
8777 (x_fill_property_data): Use cons_to_signed.
8778 Report values out of range.
8779
d1f3d2af
PE
8780 Check for buffer and string overflow more precisely.
8781 * buffer.h (BUF_BYTES_MAX): New macro.
8782 * lisp.h (STRING_BYTES_MAX): New macro.
8783 * alloc.c (Fmake_string):
8784 * character.c (string_escape_byte8):
8785 * coding.c (coding_alloc_by_realloc):
8786 * doprnt.c (doprnt):
8787 * editfns.c (Fformat):
8788 * eval.c (verror):
8789 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8790 since they may not be the same number.
8791 * editfns.c (Finsert_char):
8792 * fileio.c (Finsert_file_contents):
8793 Likewise for BUF_BYTES_MAX.
8794
dd52fcea
PE
8795 * image.c: Use ptrdiff_t, not int, for sizes.
8796 (slurp_file): Switch from int to ptrdiff_t.
8797 All uses changed.
8798 (slurp_file): Check that file size fits in both size_t (for
8799 malloc) and ptrdiff_t (for sanity and safety).
8800
7f9bbdbb
PE
8801 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8802 if b->modtime has its maximal value.
8803
dfe18f82
PE
8804 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8805
84acfcf0
PE
8806 Don't assume time_t can fit into int.
8807 * buffer.h (struct buffer.modtime): Now time_t, not int.
8808 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8809 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8810
ccd9a01a
PE
8811 Minor fixes for signed vs unsigned integers.
8812 * character.h (MAYBE_UNIFY_CHAR):
8813 * charset.c (maybe_unify_char):
8814 * keyboard.c (read_char, reorder_modifiers):
8815 XINT -> XFASTINT, since the integer must be nonnegative.
8816 * ftfont.c (ftfont_spec_pattern):
8817 * keymap.c (access_keymap, silly_event_symbol_error):
8818 XUINT -> XFASTINT, since the integer must be nonnegative.
8819 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8820 since it makes no difference and we prefer signed.
8821 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8822 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8823 nonnegative.
8824
d6d100dd
SM
88252011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8826
8827 * window.h (Fwindow_frame): Declare.
8828
2b6148e4
PE
88292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8830
8831 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8832 (SPARE_MEMORY): Always define.
8833 (LARGE_REQUEST): Remove.
8834 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8835
f230ecc9
MR
88362011-06-06 Martin Rudalics <rudalics@gmx.at>
8837
727e958e
MR
8838 * lisp.h: Move EXFUNS for Fframe_root_window,
8839 Fframe_first_window and Fset_frame_selected_window to window.h.
8840
8841 * window.h: Move EXFUNS for Fframe_root_window,
8842 Fframe_first_window and Fset_frame_selected_window here from
8843 lisp.h.
8844
8845 * frame.c (Fwindow_frame, Fframe_first_window)
8846 (Fframe_root_window, Fframe_selected_window)
8847 (Fset_frame_selected_window): Move to window.c.
8848 (Factive_minibuffer_window): Move to minibuf.c.
8849 (Fother_visible_frames_p): New function.
8850
8851 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8852
f230ecc9
MR
8853 * window.c (decode_window, decode_any_window): Move up in code.
8854 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8855 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8856 (Fwindow_buffer): Move up and rewrite doc-string.
8857 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8858 (Fwindow_prev): New functions.
727e958e
MR
8859 (Fwindow_frame): Move here from frame.c. Accept any window as
8860 argument.
8861 (Fframe_root_window, Fframe_first_window)
8862 (Fframe_selected_window): Move here from frame.c. Accept frame
8863 or arbitrary window as argument. Update doc-strings.
8864 (Fminibuffer_window): Move up in code.
8865 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8866 (Fset_frame_selected_window): Move here from frame.c.
8867 Marginal rewrite.
727e958e
MR
8868 (Fselected_window, select_window, Fselect_window): Move up in
8869 code. Minor doc-string fixes.
f230ecc9 8870
4d09bcf6
PE
88712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8872
8873 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8874 Do not assume that spare memory exists; that assumption is valid
8875 only if SYSTEM_MALLOC.
8876 (LARGE_REQUEST): New macro, so that the issue of large requests
8877 is separated from the issue of spare memory.
8878
810928a2
AS
88792011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8880
172418ad
AS
8881 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8882 format. (Bug#8806)
8883
43f862f7
AS
8884 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8885
810928a2
AS
8886 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8887 before statements.
8888
a059fe24
JD
88892011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8890
8891 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8892
8893 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8894
8895 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8896 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8897
989bf368
JB
88982011-06-05 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8901
4b80f674
CY
89022011-06-04 Chong Yidong <cyd@stupidchicken.com>
8903
8904 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8905 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8906 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8907 New error handlers.
4b80f674
CY
8908 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8909 Obey Vx_select_enable_clipboard_manager. Catch errors in
8910 x_clipboard_manager_save (Bug#8779).
8911 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8912 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8913
99a33b77 89142011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8915
8916 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8917
99a33b77 89182011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8919
8920 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8921 in the current matrix if keep_current_p is non-zero.
8922
8264569d
EZ
89232011-06-04 Eli Zaretskii <eliz@gnu.org>
8924
8925 * bidi.c (bidi_level_of_next_char): Fix last change.
8926
57f97249
EZ
89272011-06-03 Eli Zaretskii <eliz@gnu.org>
8928
fec2107c 8929 Support bidi reordering of text covered by display properties.
57f97249 8930
fec2107c
EZ
8931 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8932 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8933 (bidi_cache_search, bidi_cache_iterator_state)
8934 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8935 (bidi_level_of_next_char, bidi_move_to_visually_next):
8936 Support character positions inside a run of characters covered by a
fec2107c
EZ
8937 display string.
8938 (bidi_paragraph_init, bidi_resolve_explicit_1)
8939 (bidi_level_of_next_char): Call bidi_fetch_char and
8940 bidi_fetch_char_advance instead of FETCH_CHAR and
8941 FETCH_CHAR_ADVANCE.
8942 (bidi_init_it): Initialize new members.
8943 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8944 definitions.
8945 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8946 instead of using explicit *_CHAR codes.
d6d100dd
SM
8947 (bidi_resolve_explicit, bidi_resolve_weak):
8948 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8949 bidirectional text is supported only in multibyte buffers.
8950 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8951 it to initialize the frame_window_p member of struct bidi_it.
8952 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8953 (bidi_resolve_explicit, bidi_resolve_weak)
8954 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8955 bidi_it->nchars is non-positive.
8956 (bidi_level_of_next_char): Don't try to lookup the cache for the
8957 next/previous character if nothing is cached there yet, or if we
8958 were just reseat()'ed to a new position.
c40e2fb2 8959
0e14fe90
EZ
8960 * xdisp.c (set_cursor_from_row): Set start and stop points
8961 according to the row's direction when priming the loop that looks
8962 for the glyph on which to display cursor.
8963 (single_display_spec_intangible_p): Function deleted.
8964 (display_prop_intangible_p): Reimplement to call
8965 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8966 Accept 3 additional arguments needed by handle_display_spec.
8967 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8968 values: lists, `(when COND...)' forms, etc.
8969 (single_display_spec_string_p): Support property values that are
8970 lists with the argument STRING its top-level element.
8971 (display_prop_string_p): Fix the condition for processing a
8972 property that is a list to be consistent with handle_display_spec.
fec2107c 8973 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8974 last portion of handle_display_prop.
8975 (compute_display_string_pos): Accept additional argument
8976 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8977 value of a `display' property is a "replacing spec".
8978 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8979 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8980 the display property, but just return a value indicating whether
8981 the display property will replace the characters it covers.
8982 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8983 frame_window_p members of struct bidi_it.
d6d100dd
SM
8984 (compute_display_string_pos, compute_display_string_end):
8985 New functions.
fec2107c
EZ
8986 (push_it): Accept second argument POSITION, where pop_it should
8987 jump to continue iteration.
8988 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8989
fec2107c
EZ
8990 * keyboard.c (adjust_point_for_property): Adjust the call to
8991 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8992
8993 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8994 (bidi_init_it): Update prototypes.
8995 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8996 (compute_display_string_pos, compute_display_string_end):
8997 Declare prototypes.
fec2107c
EZ
8998 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8999 EMACS_INT.
fc6f18ce 9000
40087514 90012011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9002
57f53182
PE
9003 Malloc failure behavior now depends on size of allocation.
9004 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9005 * lisp.h: Change signatures accordingly.
9006 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9007 All callers changed. (Bug#8762)
9008
9009 * gnutls.c: Use Emacs's memory allocators.
9010 Without this change, the gnutls library would invoke malloc etc.
9011 directly, which causes problems on non-SYNC_INPUT hosts, and which
9012 runs afoul of improving memory_full behavior. (Bug#8761)
9013 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9014 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9015 xfree instead of the default malloc, realloc, free.
9016 (Fgnutls_boot): No need to check for memory allocation failure,
9017 since xmalloc does that for us.
9018
ac32cd99 9019 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9020 * category.c (hash_get_category_set):
9021 * ccl.c (ccl_driver):
9022 * charset.c (Fdefine_charset_internal):
9023 * charset.h (struct charset.hash_index):
9024 * composite.c (get_composition_id, gstring_lookup_cache)
9025 (composition_gstring_put_cache):
9026 * composite.h (struct composition.hash_index):
9027 * dispextern.h (struct image.hash):
9028 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9029 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9030 (hashfn_equal, hashfn_user_defined, make_hash_table)
9031 (maybe_resize_hash_table, hash_lookup, hash_put)
9032 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9033 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9034 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9035 * image.c (make_image, search_image_cache, lookup_image)
9036 (xpm_put_color_table_h):
9037 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9038 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9039 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9040 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9041 * alloc.c (allocate_vectorlike):
9042 Check for overflow in vector size calculations.
9043 * ccl.c (ccl_driver):
9044 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9045 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9046 need to be updated by these changes.
40087514
PE
9047 * fns.c (make_hash_table, maybe_resize_hash_table):
9048 Check for integer overflow with large hash tables.
0de4bb68
PE
9049 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9050 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9051 (SXHASH_REDUCE): New macro.
9052 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9053 Use it instead of discarding useful hash info with large hash values.
9054 (sxhash_float): New function.
9055 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9056 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9057 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9058 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9059 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9060 Adjust signatures to match updated version of code.
9061 (consing_since_gc): Now EMACS_INT, since a single hash table can
9062 use more than INT_MAX bytes.
9063
698d32e2
DN
90642011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9065
9066 Make it possible to build with GCC-4.6+ -O2 -flto.
9067
9068 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9069
fd6fa53f
SM
90702011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9071
9072 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9073 Call minibuffer-inactive-mode.
9074
864db017
JB
90752011-05-31 Juanma Barranquero <lekktu@gmail.com>
9076
9077 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9078 Update dependencies.
9079
2ad0baf4
DN
90802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9081
9082 * data.c (init_data): Remove code for UTS, this system is not
9083 supported anymore.
9084
4fcc2638
DN
90852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9086
9087 Don't force ./temacs to start in terminal mode.
9088
9089 * frame.c (make_initial_frame): Initialize faces in all cases, not
9090 only when CANNOT_DUMP is defined.
9091 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9092
c56e0fd5
DN
90932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9094
9095 * dispnew.c (add_window_display_history): Use const for the string
9096 pointer. Remove declaration, not needed.
9097
333d54da 90982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9099
55d4c1b2 9100 Use 'inline', not 'INLINE'.
333d54da 9101 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9102 * alloc.c, fontset.c (INLINE): Remove.
9103 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9104 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9105 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9106 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9107 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9108
738db178
DN
91092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9110
9111 Make it possible to run ./temacs.
9112
9113 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9114 syms_of_callproc does the same thing. Remove test for
9115 "initialized", do it in the caller.
9116 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9117
620c53a6
SM
91182011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9119
9120 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9121 (read_minibuf): Use get_minibuffer.
9122 (syms_of_minibuf): Use DEFSYM.
9123 (Qmetadata): New var.
9124 * data.c (Qbuffer): Don't make it static.
9125 (syms_of_data): Use DEFSYM.
9126
e003a292
PE
91272011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9128
9129 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9130 (CCL_CODE_MIN): New macro.
9131
ed008a6d
PE
91322011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9133
3687c2ef
PE
9134 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9135
ed008a6d
PE
9136 * eval.c (Qdebug): Now static.
9137 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9138 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9139 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9140
d66c4c7c
CY
91412011-05-29 Chong Yidong <cyd@stupidchicken.com>
9142
9143 * image.c: Various fixes to ImageMagick code comments.
9144 (Fimagemagick_types): Doc fix.
9145
5fbc2025
PE
91462011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9147
0196f88a
PE
9148 Minor fixes prompted by GCC 4.6.0 warnings.
9149
9150 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9151
5fbc2025
PE
9152 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9153 (x_clipboard_manager_save_all): Move extern decl to ...
9154 * xterm.h: ... here, so that it can be checked for consistency.
9155
1dd3c2d9
CY
91562011-05-29 Chong Yidong <cyd@stupidchicken.com>
9157
9158 * xselect.c (x_clipboard_manager_save_frame)
9159 (x_clipboard_manager_save_all): New functions.
9160 (Fx_clipboard_manager_save): Lisp function deleted.
9161
9162 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9163 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9164
9165 * xterm.h: Update prototype.
9166
5ba6571d
WX
91672011-05-28 William Xu <william.xwl@gmail.com>
9168
9169 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9170 exiting (Bug#8239).
9171
3eaff834
JM
91722011-05-28 Jim Meyering <meyering@redhat.com>
9173
e1900994 9174 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9175 * fns.c (to_uchar): Define.
9176 (crypto_hash_function): Use it to convert some newly-signed
9177 variables to unsigned, to avoid sign-extension bugs. For example,
9178 without this change, (md5 "truc") would evaluate to
9179 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9180 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9181 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9182
0f6990a7
PE
91832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9184
9185 Integer overflow fixes.
c8a9ca5a 9186
08686060
PE
9187 * dbusbind.c: Serial number integer overflow fixes.
9188 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9189 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9190 to hold a serial number that is too large for a fixnum.
9191 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9192 Check for serial numbers out of range. Decode any serial number
59568bf0 9193 that was so large that it became a float. (Bug#8722)
08686060 9194
2d1fc3c7
PE
9195 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9196 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9197 Use XFASTINT rather than XUINT when numbers are nonnegative.
9198 (xd_append_arg, Fdbus_method_return_internal):
9199 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9200 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9201 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9202 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9203 (Bug#8722)
2d1fc3c7 9204
c8a9ca5a
PE
9205 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9206
519e1d69
PE
9207 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9208
6df6ae42 9209 ccl: Add integer overflow checks.
30569699
PE
9210 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9211 (IN_INT_RANGE): New macros.
9212 (ccl_driver): Use them to check for integer overflow when
9213 decoding a CCL program. Many of the new checks are whether XINT (x)
9214 fits in int; it doesn't always, on 64-bit hosts. The new version
9215 doesn't catch all possible integer overflows, but it's an
847044ea 9216 improvement. (Bug#8719)
30569699 9217
c11285dc
PE
9218 * alloc.c (make_event_array): Use XINT, not XUINT.
9219 There's no need for unsigned here.
9220
fdccd48e
PE
9221 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9222 This follows up to the 2011-05-06 change that substituted uintptr_t
9223 for EMACS_INT. This case wasn't caught back then.
9224
37910ab2
PE
9225 Rework Fformat to avoid integer overflow issues.
9226 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9227 now (part of C89). Include <verify.h>.
9228 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9229 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9230 (Fformat): Avoid the prepass trying to compute sizes; it was only
9231 approximate and thus did not catch overflow reliably. Instead, walk
9232 through the format just once, formatting and computing sizes as we go,
9233 checking for integer overflow at every step, and allocating a larger
9234 buffer as needed. Keep track separately whether the format is
9235 multibyte. Keep only the most-recently calculated precision, rather
9236 than them all. Record whether each argument has been converted to
9237 string. Use EMACS_INT, not int, for byte and char and arg counts.
9238 Support field widths and precisions larger than INT_MAX. Avoid
9239 sprintf's undefined behavior with conversion specifications such as %#d
9240 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9241 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9242 formatting out-of-range floating point numbers with int
9173deec 9243 formats. (Bug#8668)
37910ab2 9244
2e6578fb
PE
9245 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9246
0ae6bdee
PE
9247 * data.c: Avoid integer truncation in expressions involving floats.
9248 * data.c: Include <intprops.h>.
9249 (arith_driver): When there's an integer overflow in an expression
9250 involving floating point, convert the integers to floating point
9251 so that the resulting value does not suffer from catastrophic
9252 integer truncation. For example, on a 64-bit host (* 4
9253 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9254 Do not rely on undefined behavior after integer overflow.
9255
de883a70
PE
9256 merge count_size_as_multibyte, parse_str_to_multibyte
9257 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9258 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9259 Check for integer overflow.
9260 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9261 since it's now a duplicate of the other. This is more of
9262 a character than a buffer op, so better that it's in character.c.
9263 * fns.c, print.c: Adjust to above changes.
9264
2ff916cb
PE
92652011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9266
9267 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9268
f1b54466
PE
92692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9270
fb1ac845
PE
9271 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9272 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9273 (x_clipboard_manager_save): Now static.
9274 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9275
f1b54466
PE
9276 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9277 (crypto_hash_function): Now static.
9278 Fix pointer signedness problems. Avoid unnecessary initializations.
9279
a9f737ee
CY
92802011-05-27 Chong Yidong <cyd@stupidchicken.com>
9281
9282 * termhooks.h (Vselection_alist): Make it terminal-local.
9283
9284 * terminal.c (create_terminal): Initialize it.
9285
9286 * xselect.c: Support for clipboard managers.
9287 (Vselection_alist): Move to termhooks.h as terminal-local var.
9288 (LOCAL_SELECTION): New macro.
9289 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9290 (symbol_to_x_atom): Remove gratuitous arg.
9291 (x_handle_selection_request, lisp_data_to_selection_data)
9292 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9293 (x_own_selection, x_get_local_selection, x_convert_selection):
9294 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9295 (some_frame_on_display): Delete unused function.
9296 (Fx_own_selection_internal, Fx_get_selection_internal)
9297 (Fx_disown_selection_internal, Fx_selection_owner_p)
9298 (Fx_selection_exists_p): New optional frame arg.
9299 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9300 (x_handle_selection_clear): Don't treat other terminals with the
9301 same keyboard specially. Use the terminal-local Vselection_alist.
9302 (x_clear_frame_selections): Use Frun_hook_with_args.
9303
9304 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9305
9306 * xterm.h: Add support for those atoms.
9307
e067f0c1
CY
93082011-05-26 Chong Yidong <cyd@stupidchicken.com>
9309
9310 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9311 (converted_selections, conversion_fail_tag): New global variables.
9312 (x_selection_request_lisp_error): Free the above.
9313 (x_get_local_selection): Remove unnecessary code.
9314 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9315 of converted selections stored in converted_selections.
9316 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9317 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9318 (x_convert_selection): New function.
9319 (x_handle_selection_event): Simplify.
9320 (x_get_foreign_selection): Don't ignore incoming requests while
9321 waiting for an answer; this will fail when we implement
9322 SAVE_TARGETS, and seems unnecessary anyway.
9323 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9324 (Vx_sent_selection_functions): Doc fix.
9325
0f4aebc0
LL
93262011-05-26 Leo Liu <sdl.web@gmail.com>
9327
9328 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9329
e61124cd
YM
93302011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9331
9332 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9333
9334 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9335 for fringe update if it has periodic bitmap.
ac389d0c 9336 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9337 and fringe_bitmap_periodic_p.
9338
9339 * fringe.c (get_fringe_bitmap_data): New function.
9340 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9341 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9342 row. Mark glyph row for fringe update if periodicity changed.
9343
9344 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9345 for fringe update unless it has periodic bitmap.
9346
f16d9837
KH
93472011-05-25 Kenichi Handa <handa@m17n.org>
9348
9349 * xdisp.c (get_next_display_element): Set correct it->face_id for
9350 a static composition.
9351
e1b90ef6
LL
93522011-05-24 Leo Liu <sdl.web@gmail.com>
9353
9354 * deps.mk (fns.o):
9355 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9356
9357 * fns.c (crypto_hash_function, Fsha1): New function.
9358 (Fmd5): Use crypto_hash_function.
9359 (syms_of_fns): Add Ssha1.
9360
7400048f
PE
93612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9362
9363 * gnutls.c: Remove unused macros.
9364 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9365 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9366 Remove macros that are defined and never used.
9367 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9368
abb71cf4
CY
93692011-05-22 Chong Yidong <cyd@stupidchicken.com>
9370
9371 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9372 (Fx_get_selection_internal): Minor cleanup.
9373 (Fx_own_selection_internal): Rename arguments for consistency with
9374 select.el.
9375
6307db39
PE
93762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9377
9378 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9379
f3d4e0a4
CY
93802011-05-22 Chong Yidong <cyd@stupidchicken.com>
9381
9382 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9383
4d8ade89
YM
93842011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9385
9386 * dispnew.c (scrolling_window): Don't exclude the case that the
9387 last enabled row in the desired matrix touches the bottom boundary.
9388
32078c8d
GM
93892011-05-21 Glenn Morris <rgm@gnu.org>
9390
9391 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9392 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9393 and add some more files.
32078c8d 9394
7285dc67
EZ
93952011-05-20 Eli Zaretskii <eliz@gnu.org>
9396
9397 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9398 report_file_error introduced by the change from 2011-05-07.
9399
89d1bd22
PE
94002011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9401
9402 * systime.h (Time): Define only if emacs is defined.
9403 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9404 where the include path doesn't have X11/X.h by default. See
9405 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9406
cd394be1 94072011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9408
9409 * composite.c (find_automatic_composition): Fix previous change.
9410
b9704ad9
GM
94112011-05-20 Glenn Morris <rgm@gnu.org>
9412
9413 * lisp.mk: New file, split from Makefile.in.
9414 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9415 (shortlisp): Remove.
9416 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9417
4a720484
GM
94182011-05-19 Glenn Morris <rgm@gnu.org>
9419
9420 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9421 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9422 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9423 (lisp): Set the order to that of loadup.el.
9424 (shortlisp): Make it a copy of $lisp.
9425 (SOME_MACHINE_LISP): Remove.
9426 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9427 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9428
a28d4396
KH
94292011-05-18 Kenichi Handa <handa@m17n.org>
9430
9431 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9432 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9433 (find_automatic_composition): Mostly rewrite for efficiency.
9434
a2b1fa8e
JB
94352011-05-18 Juanma Barranquero <lekktu@gmail.com>
9436
9437 * makefile.w32-in: Update dependencies.
9438
8e1f5610
CS
94392011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9440
9441 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9442 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9443
7025ee00 94442011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9445
cdfa6eab
PE
9446 Fix some integer overflow issues, such as string length overflow.
9447
06d6db33
PE
9448 * insdel.c (count_size_as_multibyte): Check for string overflow.
9449
2b4560a8
PE
9450 * character.c (lisp_string_width): Check for string overflow.
9451 Use EMACS_INT, not int, for string indexes and lengths; in
9452 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9453 the resulting string length overflows an EMACS_INT; instead,
9454 report a string overflow if no precision given. When checking for
9455 precision exhaustion, use a check that cannot possibly have
9456 integer overflow. (Bug#8675)
9457 * character.h (lisp_string_width): Adjust to new signature.
9458
cb93f9be
PE
9459 * alloc.c (string_overflow): New function.
9460 (Fmake_string): Use it. This doesn't change behavior, but saves
9461 a few bytes and will simplify future changes.
9462 * character.c (string_escape_byte8): Likewise.
9463 * lisp.h (string_overflow): New decl.
9464
1a1f3366
PE
9465 Fixups, following up to the user-interface timestamp change.
9466 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9467 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9468 * msdos.c (mouse_get_pos): Likewise.
9469 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9470 * w32gui.h (Time): Define by including "systime.h" rather than by
9471 declaring it ourselves. (Bug#8664)
9472
d4e3e4d3
PE
9473 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9474 * image.c (clear_image_cache): Likewise.
9475
f6a24d19
PE
9476 * term.c (term_mouse_position): Don't assume time_t wraparound.
9477
08dc5ae6
PE
9478 Be more systematic about user-interface timestamps.
9479 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9480 and sometimes 'EMACS_UINT', to represent these timestamps.
9481 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9482 This makes the code easier to follow, and makes it easier to catch
9483 integer overflow bugs such as Bug#8664.
9484 * frame.c (Fmouse_position, Fmouse_pixel_position):
9485 Use Time, not unsigned long, for user-interface timestamps.
9486 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9487 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9488 * keyboard.h (last_event_timestamp): Likewise.
9489 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9490 * menu.h (xmenu_show): Likewise.
9491 * term.c (term_mouse_position): Likewise.
9492 * termhooks.h (struct input_event.timestamp): Likewise.
9493 (struct terminal.mouse_position_hook): Likewise.
9494 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9495 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9496 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9497 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9498 what it was before.
9499 * menu.h, termhooks.h: Include "systime.h", for Time.
9500
8e55734a
PE
9501 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9502 Don't assume that the difference between two unsigned long values
9503 can fit into an integer. At this point, we know button_down_time
9504 <= event->timestamp, so the difference must be nonnegative, so
9505 there's no need to cast the result if double-click-time is
9506 nonnegative, as it should be; check that it's nonnegative, just in
9507 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9508 apart (about 25 days). (Bug#8664)
8e55734a 9509
841f1b75 9510 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9511 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9512
3e26f69c
PE
9513 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9514 that always fit in int. Use a sentinel instead of a counter, to
9515 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9516 * frame.h (struct frame): Use int for menu_bar_items_used
9517 instead of EMACS_INT, since it always fits in int.
3e26f69c 9518
5cc152c0
PE
9519 * menu.c (grow_menu_items): Check for int overflow.
9520
d89eb65e
PE
9521 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9522
5235bd3e
PE
9523 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9524 Before, the code was not consistent. These values cannot exceed
9525 2**31 - 1 so there's no need to make them unsigned.
9526 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9527 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9528 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9529 as modifiers.
9530 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9531
bc827e23
PE
9532 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9533 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9534 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9535 presumably because the widths might not match.
9536
78eb494e
PE
9537 * window.c (size_window): Avoid needless test at loop start.
9538
04f2d78b
CB
95392011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9540
9541 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9542
d2fc7e3d 95432011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9544
9545 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9546
d2fc7e3d 95472011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9548
9549 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9550 `width' to `bar_area_x' and `bar_area_width', respectively.
9551 (x_scroll_run): Take account of fringe background extension.
9552
04f2d78b
CB
9553 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9554 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9555 `bar_area_width', respectively.
9556 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9557 background extension.
9558
79b70037
GM
95592011-05-10 Jim Meyering <meyering@redhat.com>
9560
9561 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9562
2f142cc5
JB
95632011-05-10 Juanma Barranquero <lekktu@gmail.com>
9564
9565 * image.c (Finit_image_library): Return t for built-in image types,
9566 like pbm and xbm. (Bug#8640)
9567
57679c86
AS
95682011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9569
9570 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9571
888c9e86
EZ
95722011-05-07 Eli Zaretskii <eliz@gnu.org>
9573
b0512a1d
EZ
9574 * w32console.c (Fset_screen_color): Doc fix.
9575 (Fget_screen_color): New function.
9576 (syms_of_ntterm): Defsubr it.
9577
7285dc67
EZ
9578 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9579 unlink the temporary file if Fcall_process didn't create it in the
9580 first place.
9581 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9582 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9583 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9584 cue to call_process_cleanup not to close that handle.
9585
4d3fcc8e
BK
95862011-05-07 Ben Key <bkey76@gmail.com>
9587
9588 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9589 one of two shell specific rules, either bootstrap-temacs-CMD or
9590 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9591 to the previous implementation of the bootstrap-temacs rule.
9592 The bootstrap-temacs-CMD rule is similar to the previous
9593 implementation of the bootstrap-temacs rule except that it
9594 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9595 variable.
9596
9597 These changes, along with some changes to nt/configure.bat,
9598 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9599 earlier fix to add support for --cflags and --ldflags options
9600 that include quotes so that it works whether make uses cmd or
9601 sh as the shell.
9602
b4289b64
MA
96032011-05-06 Michael Albinus <michael.albinus@gmx.de>
9604
9605 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9606 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9607 is a constant.
9608 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9609 a string. Handle both cases.
9610 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9611 (Fdbus_register_method): Use Qinvalid_function.
9612
af4c0e28
JB
96132011-05-06 Juanma Barranquero <lekktu@gmail.com>
9614
9615 * makefile.w32-in: Update dependencies.
9616 (LISP_H): Add inttypes.h and stdin.h.
9617 (PROCESS_H): Add unistd.h.
9618
c51453d9
EZ
96192011-05-06 Eli Zaretskii <eliz@gnu.org>
9620
9621 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9622 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9623
8ff0ac3c 96242011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9625
4c4b566b
PE
9626 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9627
aab2b9b5
PE
9628 * term.c (vfatal): Remove stray call to va_end.
9629 It's not needed and the C Standard doesn't allow it here anyway.
9630
c378da0b
PE
9631 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9632 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9633
288b08c7
PE
9634 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9635 bytes.
9636
e3601888
PE
9637 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9638
db6c0e74
PE
9639 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9640
dd5963ea
PE
9641 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9642
88c9450f
PE
9643 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9644
2f9442b8
PE
9645 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9646
c032b5f8
PE
9647 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9648 * charset.c (Fdefine_charset_internal): Don't initialize
9649 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9650 32-bit int (Bug#8600).
a108c10b
PE
9651
9652 * lread.c (read_integer): Be more consistent with string-to-number.
9653 Use string_to_number to do the actual conversion; this avoids
9654 rounding errors and fixes some other screwups. Without this fix,
9655 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9656 (digit_to_number): Move earlier, for benefit of read_integer.
9657 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9658 not a digit in any supported base. (Bug#8602)
a108c10b 9659
ad5f9eea
PE
9660 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9661
aec1708a
PE
9662 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9663 to match comment at start of function. This also removes a
9664 GCC warning about overflow in a 32+64-bit port.
9665
47be4ab5
PE
9666 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9667
371cac43
PE
9668 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9669 Reported by Stefan Monnier in
9670 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9671 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9672 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9673
d01a7826
PE
9674 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9675 (EMACS_UINTPTR): Likewise, with uintptr_t.
9676
7fd47d5c
PE
9677 * lisp.h: Prefer 64-bit EMACS_INT if available.
9678 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9679 on 32-bit hosts that have 64-bit int, so that they can access
9680 large files.
122b0c86
PE
9681 However, temporarily disable this change unless the temporary
9682 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9683
8727937b
PE
9684 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9685
8ac068ac
PE
9686 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9687 This removes an assumption that EMACS_INT and long are the same
9688 width as pointers. The assumption is true for Emacs porting targets
9689 now, but we want to make other targets possible.
9690 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9691 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9692 In the rest of the code, change types of integers that hold casted
9693 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9694 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9695 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9696 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9697 No need to cast type when ORing.
9698 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9699 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9700 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9701 assume EMACS_INT is the same width as char *.
9702 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9703 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9704 Remove no-longer-needed casts.
9705 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9706 (xg_tool_bar_help_callback, xg_make_tool_item):
9707 Use EMACS_INTPTR to hold an integer
9708 that will be cast to void *; this can avoid a GCC warning
9709 if EMACS_INT is not the same width as void *.
9710 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9711 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9712 (current_message_1, set_message_1):
9713 Use a local to convert to proper width without a cast.
9714 * xmenu.c (dialog_selection_callback): Likewise.
9715
ede49d71
PE
9716 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9717 Also, don't assume VALBITS / RAND_BITS is less than 5,
9718 and don't rely on undefined behavior when shifting a 1 left into
9719 the sign bit.
9720 * lisp.h (get_random): Change signature to match.
9721
2f30ecd0
PE
9722 * lread.c (hash_string): Use size_t, not int, for hash computation.
9723 Normally we prefer signed values; but hashing is special, because
9724 it's better to use unsigned division on hash table sizes so that
9725 the remainder is nonnegative. Also, size_t is the natural width
9726 for hashing into memory. The previous code used 'int', which doesn't
9727 retain enough info to hash well into very large tables.
9728 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9729
2a866e7b
PE
9730 * dbusbind.c: Don't possibly lose pointer info when converting.
9731 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9732 Use XPNTR rather than XHASH, so that the high-order bits of
9733 the pointer aren't lost when converting through void *.
9734
51639eac
PE
9735 * eval.c (Fautoload): Don't double-shift a pointer.
9736
92394119
PE
9737 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9738
dbdb9a7c
JB
97392011-05-06 Juanma Barranquero <lekktu@gmail.com>
9740
9741 * gnutls.c (DEF_GNUTLS_FN):
9742 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9743
db7a0b4f
AS
97442011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9745
9746 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9747 marker. (Bug#8610)
9748
cd394be1 97492011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9750
9751 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9752 New version that can reserve upto 2GB of heap space.
9753
f7ff1b0f 97542011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9755
9756 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9757
639c109b
TZ
97582011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9759
9760 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9761 `gnutls_certificate_set_x509_key_file'.
9762
d2127135
JB
97632011-05-05 Juanma Barranquero <lekktu@gmail.com>
9764
9765 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9766 Update dependencies.
9767
e968f4f3
JB
97682011-05-04 Juanma Barranquero <lekktu@gmail.com>
9769
9770 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9771 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9772 Remove unused parameter `fildes'.
9773 * process.c (read_process_output, send_process): Don't pass it.
9774
84d358f0
JB
97752011-05-04 Juanma Barranquero <lekktu@gmail.com>
9776
9777 Fix previous change: the library cache is defined in w32.c.
9778 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9779 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9780
0898ca10
JB
97812011-05-04 Juanma Barranquero <lekktu@gmail.com>
9782
9783 Implement dynamic loading of GnuTLS on Windows.
9784
9785 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9786 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9787 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9788 Declare.
9789
9790 * gnutls.c (Qgnutls_dll): Define.
9791 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9792 (gnutls_*): Declare function pointers.
9793 (init_gnutls_functions): New function to initialize function pointers.
9794 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9795 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9796 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9797 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9798 (emacs_gnutls_write, emacs_gnutls_read)
9799 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9800 (Fgnutls_available_p): New function.
9801 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9802 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9803 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9804
9805 * image.c: Include w32.h.
9806 (Vimage_type_cache): Delete.
9807 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9808 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9809 (w32_delayed_load): Move to w32.c.
9810
9811 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9812
9813 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9814 (w32_delayed_load): Move from image.c. When loading a library, record
9815 its filename in the :loaded-from property of the library id.
9816 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9817 Initialize and staticpro them.
9818 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9819
9820 * process.c: Include lisp.h before w32.h, not after.
9821 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9822 instead of gnutls_record_check_pending.
9823
9824 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9825
ff4de4aa
TZ
98262011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9827
9828 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9829 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9830 as passed in.
9831
abe95abb
JD
98322011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9833
9834 * xterm.c (x_set_frame_alpha): Do not set property on anything
9835 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9836
e16e55d4
JB
98372011-05-02 Juanma Barranquero <lekktu@gmail.com>
9838
9839 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9840
bafcf6a5
JB
98412011-05-02 Juanma Barranquero <lekktu@gmail.com>
9842
9843 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9844 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9845 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9846 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9847 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9848 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9849 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9850 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9851 (Qgnutls_bootprop_callbacks_verify): Make static.
9852
e7a6747f
AS
98532011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9854
19ed11ba
AS
9855 * callproc.c: Indentation fixup.
9856
e7a6747f 9857 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9858 (wait_for_termination, interruptible_wait_for_termination):
9859 Move after wait_for_termination_1.
e7a6747f 9860
1ef14cb4
LMI
98612011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9862
9863 * sysdep.c (interruptible_wait_for_termination): New function
9864 which is like wait_for_termination, but allows keyboard
9865 interruptions.
9866
9867 * callproc.c (Fcall_process): Add (:file "file") as an option for
9868 the STDOUT buffer.
9869 (Fcall_process_region): Ditto.
9870
330d880c
EZ
98712011-04-30 Eli Zaretskii <eliz@gnu.org>
9872
8db90b73
EZ
9873 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9874 rather than `XVECTOR (FOO)->size'.
9875
330d880c
EZ
9876 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9877 inttypes.h, as a gnulib replacement is used if it not available in
9878 system headers.
9879
15cbd324
EZ
98802011-04-21 Eli Zaretskii <eliz@gnu.org>
9881
9882 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9883 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9884 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9885
9886 * coding.c (coding_alloc_by_realloc): Error out if destination
9887 will grow beyond MOST_POSITIVE_FIXNUM.
9888 (decode_coding_emacs_mule): Abort if there isn't enough place in
9889 charbuf for the composition carryover bytes. Reserve an extra
9890 space for up to 2 characters produced in a loop.
9891 (decode_coding_iso_2022): Abort if there isn't enough place in
9892 charbuf for the composition carryover bytes.
9893
98942011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9895
ae940cca
EZ
9896 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9897 aborting when %lld or %lll format is passed.
9898 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9899 %llo or %llx format is passed. (Bug#8545)
9900
03ab8921
EZ
9901 * window.c (window_scroll_line_based): Use a marker instead of
9902 simple variables to record original value of point. (Bug#7952)
9903
afda1437
EZ
9904 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9905 produced by %s or %c overflows available buffer space. (Bug#8545)
9906
f76dee0c
PE
99072011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9908
9909 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9910 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9911
fdc5744d
JB
99122011-04-28 Juanma Barranquero <lekktu@gmail.com>
9913
9914 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9915
638f053a
JB
99162011-04-28 Juanma Barranquero <lekktu@gmail.com>
9917
9918 * keyboard.c (Qdelayed_warnings_hook): Define.
9919 (command_loop_1): Run `delayed-warnings-hook'
9920 if Vdelayed_warnings_list is non-nil.
9921 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9922 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9923
d178f871
EZ
99242011-04-28 Eli Zaretskii <eliz@gnu.org>
9925
9926 * doprnt.c (doprnt): Don't return value smaller than the buffer
9927 size if the message was truncated. (Bug#8545).
9928
b124fd93
JB
99292011-04-28 Juanma Barranquero <lekktu@gmail.com>
9930
9931 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9932 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9933
e810457d
PE
99342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9935
9936 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9937
ea51cceb
JB
99382011-04-27 Juanma Barranquero <lekktu@gmail.com>
9939
9940 * makefile.w32-in: Update dependencies.
9941
94dcfacf
EZ
99422011-04-27 Eli Zaretskii <eliz@gnu.org>
9943
9944 Improve `doprnt' and its usage. (Bug#8545)
9945 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9946 `format_end'. Remove support for %l as a conversion specifier.
9947 Don't use xrealloc. Improve diagnostics when the %l size modifier
9948 is used. Update the commentary.
9949
9950 * eval.c (verror): Simplify calculation of size_t.
9951
9952 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9953 messages.
9954
f61f41d7
PE
99552011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9956
9957 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9958 change.
9959
96fb4434
PE
99602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9961
9962 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9963 This makes this file independent of the recent pseudovector change.
9964
671875da 99652011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9966
69e9b5a3
PE
9967 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9968
b5f869a7 9969 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9970 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9971 Remove unused local.
c8926152 9972 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9973
841a1577 9974 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9975 GCC 4.6.0 optimizes based on type-based alias analysis.
9976 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9977 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9978 != &v->size, and therefore "v->size = 1; b->size = 2; return
9979 v->size;" must therefore return 1. This assumption is incorrect
9980 for Emacs, since it type-puns struct Lisp_Vector * with many other
9981 types. To fix this problem, this patch adds a new type struct
f904488f 9982 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9983 and pseudovectors, and helps optimizing compilers not get fooled
9984 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9985 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9986 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9987 the size member.
eab3844f
PE
9988 (XSETPVECTYPE): Rewrite in terms of new macro.
9989 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9990 This is a bit clearer, and further avoids the possibility of
9991 undesirable aliasing.
9992 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9993 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9994 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9995 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9996 (ASIZE): Now uses header.size rather than size.
9997 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9998 to avoid the hassle of writing XVECTOR (foo)->header.size.
9999 (struct vectorlike_header): New type.
eab3844f
PE
10000 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10001 object, to help avoid aliasing.
10002 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10003 (SUBRP): Likewise, since Lisp_Subr is a special case.
10004 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10005 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10006 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10007 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10008 changed to be "header.size" and "header.next".
10009 * buffer.h (struct buffer): Likewise.
10010 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10011 * frame.h (struct frame): Likewise.
10012 * process.h (struct Lisp_Process): Likewise.
10013 * termhooks.h (struct terminal): Likewise.
10014 * window.c (struct save_window_data, struct saved_window): Likewise.
10015 * window.h (struct window): Likewise.
10016 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10017 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10018 * buffer.c (init_buffer_once): Likewise.
10019 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10020 special case.
10021 * process.c (Fformat_network_address): Use local var for size,
10022 for brevity.
10023
0df1eac5
PE
10024 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10025
847ab9d1 10026 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10027 * data.c (atof): Remove decl; no longer used or needed.
10028 (digit_to_number): Move to lread.c.
10029 (Fstring_to_number): Use new string_to_number function, to be
10030 consistent with how the Lisp reader treats infinities and NaNs.
10031 Do not assume that floating-point numbers represent EMACS_INT
10032 without losing information; this is not true on most 64-bit hosts.
10033 Avoid double-rounding errors, by insisting on integers when
10034 parsing non-base-10 numbers, as the documentation specifies.
10035 * lisp.h (string_to_number): New decl, replacing ...
10036 (isfloat_string): Remove.
bc0a5c13 10037 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10038 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10039 appears to have been a coding error. Similarly, do not accept
10040 strings like +-1e0 as floating point numbers. Do not report
10041 overflow for integer overflows unless the base is not 10 which
10042 means we have no simple and reliable way to continue.
10043 Break out the floating-point parsing into a new
10044 function string_to_number, so that Fstring_to_number parses
10045 floating point numbers consistently with the Lisp reader.
04f2d78b 10046 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10047 (E_CHAR, EXP_INT): Remove, replacing with ...
10048 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10049 (string_to_number): New function, replacing isfloat_string.
10050 This function checks for valid syntax and produces the resulting
10051 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10052 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10053 so that overflow for non-base-10 numbers is reported only when
10054 there's no portable and simple way to convert to floating point.
452f4150 10055
67769ffc
PE
10056 * textprop.c (set_text_properties_1): Rewrite for clarity,
10057 and to avoid GCC warning about integer overflow.
10058
c20db43f
PE
10059 * intervals.h (struct interval): Use EMACS_INT for members
10060 where EMACS_UINT might cause problems. See
10061 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10062 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10063 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10064 All uses changed.
37aa2f85
PE
10065 (offset_intervals): Tell GCC not to worry about length overflow
10066 when negating a negative length.
c20db43f 10067
2538aa2f
PE
10068 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10069 (overrun_check_free): Likewise.
10070
f2d3008d
PE
10071 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10072 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10073 word size.
10074
ec8df744
PE
10075 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10076 (gnutls_make_error): Rename local to avoid shadowing.
10077 (gnutls_emacs_global_deinit): ifdef out; not used.
10078 (Fgnutls_boot): Use const for pointer to readonly storage.
10079 Comment out unused local. Fix pointer signedness problems.
10080
640ee02d
PE
10081 * lread.c (openp): Don't stuff size_t into an 'int'.
10082 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10083 about possible signed overflow.
10084
6048fb2a
PE
10085 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10086 (GDK_KEY_g): Don't define if already defined.
10087 (xg_prepare_tooltip): Avoid pointer signedness problem.
10088 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10089
fa3c87e1
PE
10090 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10091 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10092
2172544b
PE
10093 * xfns.c (Fx_window_property): Simplify a bit,
10094 to make a bit faster and to avoid GCC 4.6.0 warning.
10095 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10096
9b821a21
PE
10097 * fns.c (internal_equal): Don't assume size_t fits in int.
10098
3c616cfa
PE
10099 * alloc.c (compact_small_strings): Tighten assertion a little.
10100
c2982e87
PE
10101 Replace pEd with more-general pI, and fix some printf arg casts.
10102 * lisp.h (pI): New macro, generalizing old pEd macro to other
10103 conversion specifiers. For example, use "...%"pI"d..." rather
10104 than "...%"pEd"...".
10105 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10106 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10107 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10108 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10109 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10110 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10111 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10112 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10113 64-bit hosts.
10114 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10115 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10116 * print.c (safe_debug_print, print_object): Likewise.
10117 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10118 to int.
6f04d126
PE
10119 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10120 avoiding the 0 flag, which is not portable.
c2982e87
PE
10121 * process.c (Fmake_network_process): Use pI to avoid cast.
10122 * region-cache.c (pp_cache): Likewise.
10123 * xdisp.c (decode_mode_spec): Likewise.
10124 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10125 behavior on 64-bit hosts with printf arg.
6f04d126 10126 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10127 (x_stop_queuing_selection_requests): Likewise.
10128 (x_get_window_property): Don't truncate byte count to an 'int'
10129 when tracing.
0b432f21 10130
5e073ec7
PE
10131 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10132 here, since it parses constructs like leading '-' and spaces,
10133 which are not wanted; and it overflows with large numbers.
10134 Instead, simply match F[0-9]+, which is what is wanted anyway.
10135
36372bf9
PE
10136 * alloc.c: Remove unportable assumptions about struct layout.
10137 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10138 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10139 (allocate_vectorlike, make_pure_vector): Use the new macros,
10140 plus offsetof, to remove unportable assumptions about struct layout.
10141 These assumptions hold on all porting targets that I know of, but
10142 they are not guaranteed, they're easy to remove, and removing them
10143 makes further changes easier.
10144
0b432f21
PE
10145 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10146 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10147 (string_overrun_cookie): Now const. Use initializers that
10148 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10149 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10150 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10151 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10152 multiple of sizeof (EMACS_INT); it need not be, if
10153 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10154 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10155
895009e1
JB
101562011-04-26 Juanma Barranquero <lekktu@gmail.com>
10157
10158 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10159
6a7a1b0b
TZ
101602011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10161
10162 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10163 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10164 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10165
841a1577 101662011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10167
10168 * lisp.h (Qdebug): List symbol.
895009e1 10169 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10170 * keyboard.c (debug-on-event): New variable.
10171 (handle_user_signal): Break into debugger when debug-on-event
10172 matches the current signal symbol.
10173
f2d3ba6f
DN
101742011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10175
10176 * alloc.c (check_sblock, check_string_bytes)
10177 (check_string_free_list): Convert to standard C.
10178
42ce4c63
TZ
101792011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10180
10181 * w32.c (emacs_gnutls_push): Fix typo.
10182
825cd63c
EZ
101832011-04-25 Eli Zaretskii <eliz@gnu.org>
10184
fb11d64d
EZ
10185 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10186 "cast to pointer from integer of different size".
10187
825cd63c
EZ
10188 Improve doprnt and its use in verror. (Bug#8545)
10189 * doprnt.c (doprnt): Document the set of format control sequences
10190 supported by the function. Use SAFE_ALLOCA instead of always
10191 using `alloca'.
10192
10193 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10194 is one byte too soon. Don't use xrealloc; instead xfree and
10195 xmalloc anew.
10196
e061a11b
TZ
101972011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10198
10199 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10200 callbacks stage.
10201
10202 * gnutls.c: Renamed global_initialized to
10203 gnutls_global_initialized. Added internals for the
10204 :verify-hostname-error, :verify-error, and :verify-flags
10205 parameters of `gnutls-boot' and documented those parameters in the
10206 docstring. Start callback support.
9173deec
JB
10207 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10208 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10209 on error. Return error code.
e061a11b
TZ
10210 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10211 (emacs_gnutls_read): Likewise.
10212 (Fgnutls_boot): Return handshake error code.
10213 (emacs_gnutls_handle_error): New function.
10214 (wsaerror_to_errno): Likewise.
10215
10216 * w32.h (emacs_gnutls_pull): Add prototype.
10217 (emacs_gnutls_push): Likewise.
10218
10219 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10220 (emacs_gnutls_push): Likewise.
10221
102222011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10223
10224 * process.c (wait_reading_process_output): Check if GnuTLS
10225 buffered some data internally if no FDs are set for TLS
10226 connections.
10227
10228 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10229 (LIBS): Link to USER_LIBS.
10230 ($(BLD)/gnutls.$(0)): New target.
10231
fa6996bc
EZ
102322011-04-24 Eli Zaretskii <eliz@gnu.org>
10233
eb35682e
EZ
10234 * xdisp.c (handle_single_display_spec): Rename the
10235 display_replaced_before_p argument into display_replaced_p, to
10236 make it consistent with the commentary. Fix typos in the
10237 commentary.
10238
e2ad650c
EZ
10239 * textprop.c (syms_of_textprop): Remove dead code.
10240 (copy_text_properties): Delete obsolete commentary about an
10241 interface that was deleted long ago. Fix typos in the description
10242 of arguments.
10243
1b2de274
EZ
10244 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10245 to changes in oldXMenu/XMenu.h from 2011-04-16.
10246 <menu_help_message, prev_menu_help_message>: Constify.
10247 (IT_menu_make_room): menu->help_text is now `const char **';
10248 adjust.
10249
10250 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10251 to changes in oldXMenu/XMenu.h from 2011-04-16.
10252 (struct XMenu): Declare `help_text' `const char **'.
10253
10254 * xfaces.c <Qunspecified>: Make extern again.
10255
10256 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10257 required by POSIX.
1b2de274 10258
762b15be
EZ
10259 * doc.c (get_doc_string): Improve the format passed to `error'.
10260
10261 * doprnt.c (doprnt): Improve commentary.
10262
10263 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10264
10265 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10266 them with etags.
10267
f1052e5d
EZ
10268 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10269 changes in globals.h immediately force recompilation.
762b15be
EZ
10270 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10271 $(CURDIR)/s/ms-w32.h.
10272 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10273
fa6996bc
EZ
10274 * character.c (Fchar_direction): Function deleted.
10275 (syms_of_character): Don't defsubr it.
10276 <char-direction-table>: Deleted.
10277
e6c3da20
EZ
102782011-04-23 Eli Zaretskii <eliz@gnu.org>
10279
10280 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10281 * doprnt.c: Include limits.h.
10282 (SIZE_MAX): New macro.
04f2d78b
CB
10283 (doprnt): Return a size_t value. 2nd arg is now size_t.
10284 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10285 Improve overflow protection. Support `l' modifier for integer
10286 conversions. Support %l conversion. Don't assume an EMACS_INT
10287 argument for integer conversions and for %c.
10288
10289 * lisp.h (doprnt): Restore prototype.
10290
10291 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10292 $(SRC)/character.h.
10293
10294 * Makefile.in (base_obj): Add back doprnt.o.
10295
10296 * deps.mk (doprnt.o): Add back prerequisites.
10297 (callint.o): Depend on character.h.
10298
10299 * eval.c (internal_lisp_condition_case): Include the handler
10300 representation in the error message.
10301 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10302 when breaking from the loop.
10303
10304 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10305
10306 * callint.c (Fcall_interactively): When displaying error message
10307 about invalid control letter, pass the character's codepoint, not
10308 a pointer to its multibyte form. Improve display of the character
10309 in octal and display also its hex code.
10310
10311 * character.c (char_string): Use %x to display the (unsigned)
10312 codepoint of an invalid character, to avoid displaying a bogus
10313 negative value.
10314
10315 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10316 `error', not SYMBOL_NAME itself.
10317
10318 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10319 character arguments to `error'.
10320
10321 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10322 to `error' in error message about FINAL_CHAR argument. Make sure
10323 FINAL_CHAR is a character, and use %c when it is passed as
10324 argument to `error'.
10325
4ffd0d6b 103262011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10327
10328 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10329
10330 * w32.c: Include <time.h>.
10331 (sys_localtime): New function.
10332
4ffd0d6b 103332011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10334
10335 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10336
4ffd0d6b 10337 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10338
4ffd0d6b 103392011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10340
4ffd0d6b
GM
10341 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10342 zombies (Bug#8467).
aac0c6e3 10343
04c56954
EZ
103442011-04-19 Eli Zaretskii <eliz@gnu.org>
10345
10346 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10347 gl_state.e_property when gl_state.object is Qt.
10348
10349 * insdel.c (make_gap_larger): Remove limitation of buffer size
10350 to <= INT_MAX.
10351
16a43933
CY
103522011-04-18 Chong Yidong <cyd@stupidchicken.com>
10353
10354 * xdisp.c (lookup_glyphless_char_display)
10355 (produce_glyphless_glyph): Handle cons cell entry in
10356 glyphless-char-display.
10357 (Vglyphless_char_display): Document it.
10358
10359 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10360 glyphless-char-display.
10361
4581706e
CY
103622011-04-17 Chong Yidong <cyd@stupidchicken.com>
10363
10364 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10365
10366 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10367
10368 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10369 definition for no-X builds.
10370
4887c6e2 103712011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10372
fd35b6f9
PE
10373 Static checks with GCC 4.6.0 and non-default toolkits.
10374
5c1ccb01
PE
10375 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10376
006c5daa
PE
10377 * process.c (keyboard_bit_set): Define only if SIGIO.
10378 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10379 (send_process): Repair possible setjmp clobbering.
10380
efc736d3
PE
10381 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10382
4e2fe2e6
PE
10383 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10384
f97334a2
PE
10385 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10386
4e75f29d
PE
10387 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10388 Define only if needed.
10389
90efadd1
PE
10390 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10391 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10392 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10393
3c647824
PE
10394 * dispextern.h (struct redisplay_interface): Rename param
10395 to avoid shadowing.
e264f262 10396 * termhooks.h (struct terminal): Likewise.
761383f4 10397 * xterm.c (xembed_send_message): Likewise.
3c647824 10398
b58c5c4a
PE
10399 * insdel.c (make_gap_smaller): Define only if
10400 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10401
cad59032
PE
10402 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10403 it.
10404
c339dc2e
PE
10405 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10406 so that we aren't warned about unused symbols.
10407
91a3e27b
PE
10408 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10409
399c71d3 10410 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10411
8ffc96f5
PE
10412 * xfns.c (x_real_positions): Mark locals as initialized.
10413
eef9bc79
PE
10414 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10415
098db9dd
PE
10416 * xterm.c: Fix problems found by static analysis with other toolkits.
10417 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10418 (x_dispatch_event): Declare static if USE_GTK, and
10419 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10420 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10421 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10422 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10423 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10424
eb18f6cc
PE
10425 * xmenu.c (menu_help_callback): Pointer type fixes.
10426 Use const pointers when pointing at readonly data. Avoid pointer
10427 signedness clashes.
10428 (FALSE): Remove unused macro.
10429 (update_frame_menubar): Remove unused decl.
10430
1fe72bf8
PE
10431 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10432
60d9e1db
PE
10433 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10434 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10435 (single_menu_item): Rename local to avoid shadowing.
10436
39261c26
PE
10437 * keyboard.c (make_lispy_event): Remove unused local var.
10438
018c5e19
PE
10439 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10440 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10441
63d2b86e
PE
10442 * bitmaps: Change bitmaps from unsigned char back to the X11
10443 compatible char. Avoid the old compiler warnings about
10444 out-of-range initializers by using, for example, '\xab' rather
10445 than 0xab.
10446
aefd87e1
PE
10447 * xgselect.c (xgselect_initialize): Check vs interface
10448 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10449
bf501fb9
PE
10450 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10451
e9829fdf
PE
10452 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10453 to read-only memory.
10454
1086c095
PE
10455 * fns.c (vector): Remove; this old hack is no longer needed.
10456
2baccd04 10457 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10458 Remove unused var.
dde42981 10459 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10460
72391843 10461 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10462
436c16df 10463 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10464 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10465 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10466
92bb796d 10467 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10468 (x_term_init): Remove local to avoid shadowing.
92bb796d 10469
764430a3 10470 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10471
10472 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10473 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10474
d1dfb56c
EZ
104752011-04-16 Eli Zaretskii <eliz@gnu.org>
10476
c4354cb4
EZ
10477 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10478
d1dfb56c
EZ
10479 Fix regex.c, syntax.c and friends for buffers > 2GB.
10480 * syntax.h (struct gl_state_s): Declare character position members
10481 EMACS_INT.
10482
10483 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10484
04f2d78b
CB
10485 * textprop.c (verify_interval_modification, interval_of):
10486 Declare arguments EMACS_INT.
d1dfb56c
EZ
10487
10488 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10489 EMACS_INT.
10490
10491 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10492
10493 * indent.c (Fvertical_motion): Local variable it_start is now
10494 EMACS_INT.
10495
10496 * regex.c (re_match, re_match_2, re_match_2_internal)
10497 (bcmp_translate, regcomp, regexec, print_double_string)
10498 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10499 (re_compile_pattern, re_exec): Declare arguments and local
10500 variables `size_t' and `ssize_t' and return values `regoff_t', as
10501 appropriate.
10502 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10503 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10504 <compile_stack_type>: `size' and `avail' are now `size_t'.
10505
10506 * regex.h <regoff_t>: Use ssize_t, not int.
10507 (re_search, re_search_2, re_match, re_match_2): Arguments that
10508 specify buffer/string position and length are now ssize_t and
10509 size_t. Return type is regoff_t.
10510
613052cd
BK
105112011-04-16 Ben Key <bkey76@gmail.com>
10512
10513 * nsfont.m: Fixed bugs in ns_get_family and
10514 ns_descriptor_to_entity that were caused by using free to
10515 deallocate memory blocks that were allocated by xmalloc (via
10516 xstrdup). This caused Emacs to crash when compiled with
10517 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10518 --enable-checking=xmallocoverrun). xfree is now used to
10519 deallocate these memory blocks.
10520
4170f62f 105212011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10522
71b41406
PE
10523 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10524
9587a89d
PE
10525 emacs_write: Accept and return EMACS_INT for sizes.
10526 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10527 et seq.
10528 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10529 Accept and return EMACS_INT.
10530 (emacs_gnutls_write): Return the number of bytes written on
10531 partial writes.
10532 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10533 (emacs_read, emacs_write): Remove check for negative size, as the
10534 Emacs source code has been audited now.
9587a89d
PE
10535 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10536 (emacs_read, emacs_write): Use it.
273a5f82
PE
10537 * process.c (send_process): Adjust to the new signatures of
10538 emacs_write and emacs_gnutls_write. Do not attempt to store
10539 a byte offset into an 'int'; it might overflow.
9587a89d 10540 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10541
3e047f51
PE
10542 * sound.c: Don't assume sizes fit in 'int'.
10543 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10544 Return EMACS_INT, not int.
3e047f51 10545 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10546 Accept EMACS_INT, not int.
10547 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10548 record read return values.
10549
cc39a9db
BK
105502011-04-15 Ben Key <bkey76@gmail.com>
10551
c9d0ec6d
JB
10552 * keyboard.c (Qundefined): Don't declare static since it is used
10553 in nsfns.m.
10554 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10555 static since they are used in nsfont.m.
cc39a9db 10556
6c60eb9f
SM
105572011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10558
10559 * process.c (Qprocessp): Don't declare static.
10560 * lisp.h (Qprocessp): Declare again.
10561
7990b61a
JB
105622011-04-15 Juanma Barranquero <lekktu@gmail.com>
10563
10564 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10565
5d4cb038
PE
105662011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10567
8bd7b830 10568 Improve C-level modularity by making more things 'static'.
cd64ea1d 10569
e3b27b31
PE
10570 Don't publish debugger-only interfaces to other modules.
10571 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10572 (verify_bytepos, count_markers): Move decls to the only modules
10573 that need them.
10574 * region-cache.h (pp_cache): Likewise.
10575 * window.h (check_all_windows): Likewise.
10576 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10577
5d4cb038
PE
10578 * sysdep.c (croak): Now static, if
10579 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10580 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10581
10582 * alloc.c (refill_memory_reserve): Now static if
10583 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10584 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10585
e87b6180
PE
10586 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10587 Define only if USE_LUCID.
10588
ac64929e
PE
10589 * xrdb.c (x_customization_string, x_rm_string): Now static.
10590
6f37259d
PE
10591 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10592 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10593
1683e3ab
PE
10594 * xdisp.c (draw_row_with_mouse_face): Now static.
10595 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10596
de9c2632
PE
10597 * window.h (check_all_windows): Mark externally visible.
10598
2b96acb7
PE
10599 * window.c (window_deletion_count): Now static.
10600
10601 * undo.c: Make symbols static if they're not exported.
10602 (last_undo_buffer, last_boundary_position, pending_boundary):
10603 Now static.
10604
50436f33
PE
10605 * textprop.c (interval_insert_behind_hooks): Now static.
10606 (interval_insert_in_front_hooks): Likewise.
10607
64520e5c
PE
10608 * term.c: Make symbols static if they're not exported.
10609 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10610 (max_frame_lines, tty_set_terminal_modes):
10611 (tty_reset_terminal_modes, tty_turn_off_highlight):
10612 (get_tty_terminal): Now static.
10613 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10614 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10615 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10616 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10617 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10618
1fa53021
PE
10619 * sysdep.c: Make symbols static if they're not exported.
10620 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10621 Now static.
10622 (sigprocmask_set, full_mask): Remove; unused.
10623 (wait_debugging): Mark as visible.
10624 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10625 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10626
d4b43b22
PE
10627 * syntax.c (syntax_temp): Define only if !__GNUC__.
10628
b7c513d0
PE
10629 * sound.c (current_sound_device, current_sound): Now static.
10630
989b29ad
PE
10631 * search.c (searchbufs, searchbuf_head): Now static.
10632
13a55a78
PE
10633 * scroll.c (scroll_cost): Remove; unused.
10634 * dispextern.h (scroll_cost): Remove decl.
10635
de68a1fc
PE
10636 * region-cache.h (pp_cache): Mark as externally visible.
10637
40ccffa6
PE
10638 * process.c: Make symbols static if they're not exported.
10639 (process_tick, update_tick, create_process, chan_process):
10640 (Vprocess_alist, proc_buffered_char, datagram_access):
10641 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10642 (deactivate_process): Mark defn as static, as well as decl.
10643 * lisp.h (create_process): Remove decl.
10644 * process.h (chan_process, Vprocess_alist): Remove decls.
10645
ad64fc97
PE
10646 * print.c: Make symbols static if they're not exported.
10647 (print_depth, new_backquote_output, being_printed, print_buffer):
10648 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10649 (print_interval, print_number_index, initial_stderr_stream):
10650 Now static.
10651 * lisp.h (Fprinc): Remove decl.
10652 (debug_output_compilation_hack): Mark as externally visible.
10653
adddb265
PE
10654 * sysdep.c (croak): Move decl from here to syssignal.h.
10655 * syssignal.h (croak): Put it here, so the API can be checked when
10656 'croak' is called from dissociate_if_controlling_tty.
10657
1717ede2
PE
10658 * minibuf.c: Make symbols static if they're not exported.
10659 (minibuf_save_list, choose_minibuf_frame): Now static.
10660 * lisp.h (choose_minibuf_frame): Remove decl.
10661
fa5fb2bc
PE
10662 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10663
1e3890d1
PE
10664 * lread.c: Make symbols static if they're not exported.
10665 (read_objects, initial_obarray, oblookup_last_bucket_number):
10666 Now static.
10667 (make_symbol): Remove; unused.
10668 * lisp.h (initial_obarray, make_symbol): Remove decls.
10669
8a1414fa
PE
10670 * keyboard.c: Make symbols static if they're not exported.
10671 (single_kboard, recent_keys_index, total_keys, recent_keys):
10672 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10673 (this_single_command_key_start, echoing, last_auto_save):
10674 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10675 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10676 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10677 (Vlispy_mouse_stem, double_click_count):
10678 Now static.
10679 (force_auto_save_soon): Define only if SIGDANGER.
10680 (ignore_mouse_drag_p): Now static if
10681 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10682 (print_help): Remove; unused.
10683 (stop_character, last_timer_event): Mark as externally visible.
10684 * keyboard.h (ignore_mouse_drag_p): Declare only if
10685 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10686 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10687 * lisp.h (echoing): Remove decl.
10688 (force_auto_save_soon): Declare only if SIGDANGER.
10689 * xdisp.c (redisplay_window): Simplify code, to make it more
10690 obvious that ignore_mouse_drag_p is not accessed if !defined
10691 USE_GTK && !defined HAVE_NS.
10692
93ea6e8f
PE
10693 * intervals.c: Make symbols static if they're not exported.
10694 (merge_properties_sticky, merge_interval_right, delete_interval):
10695 Now static.
10696 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10697
77382fcc
PE
10698 * insdel.c: Make symbols static if they're not exported.
10699 However, leave prepare_to_modify_buffer alone. It's never
10700 called from outside this function, but that appears to be a bug.
10701 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10702 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10703 (adjust_after_replace_noundo): Remove; unused.
10704 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10705 (signal_before_change): Remove decls.
77382fcc 10706
9306c32e
PE
10707 * indent.c (val_compute_motion, val_vmotion): Now static.
10708
cd44d2eb
PE
10709 * image.c: Make symbols static if they're not exported.
10710 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10711 if USE_GTK.
10712 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10713 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10714
ad9a7a06
PE
10715 * fringe.c (standard_bitmaps): Now static.
10716 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10717
81626931
PE
10718 * frame.c: Make symbols static if they're not exported.
10719 (x_report_frame_params, make_terminal_frame): Now static.
10720 (get_frame_param): Now static, unless HAVE_NS.
10721 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10722 (x_get_resource_string): Remove; not used.
10723 * frame.h (make_terminal_frame, x_report_frame_params):
10724 (x_get_resource_string); Remove decls.
10725 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10726 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10727
239f9db9
PE
10728 * font.c, fontset.c: Make symbols static if they're not exported.
10729 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10730 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10731 * font.c (font_close_object): Now static.
10732 * font.h (font_close_object): Remove.
10733 * fontset.c (FONTSET_OBJLIST): Remove.
10734 (free_realized_fontset) #if-0 the body, which does nothing.
10735 (face_suitable_for_char_p): #if-0, as it's never called.
10736 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10737 * xfaces.c (face_at_string_position):
10738 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10739 since 0 is always ASCII.
10740
dfcf3579
PE
10741 * fns.c (weak_hash_tables): Now static.
10742
5045092b
PE
10743 * fileio.c: Make symbols static if they're not exported.
10744 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10745 (Vwrite_region_annotation_buffers): Now static.
10746
57a96f5c
PE
10747 * eval.c: Make symbols static if they're not exported.
10748 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10749 * lisp.h (backtrace_list): Remove decl.
10750
35f08c38
PE
10751 * emacs.c: Make symbols static if they're not exported.
10752 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10753 (fatal_error_code, fatal_error_signal_hook, standard_args):
10754 Now static.
10755 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10756 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10757 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10758 * lisp.h (fatal_error_signal_hook): Remove decl.
10759 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10760
f44bd759
PE
10761 * editfns.c: Move a (normally-unused) function to its only use.
10762 * editfns.c, lisp.h (get_operating_system_release): Remove.
10763 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10764 worth the hassle of breaking this out.
10765
b532497d
PE
10766 * xterm.c: Make symbols static if they're not exported.
10767 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10768 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10769 (x_destroy_window, x_delete_display):
10770 Now static.
10771 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10772 (x_mouse_leave): Remove; unused.
10773 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10774 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10775 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10776 Remove decls.
10777 (x_mouse_leave): Declare only if WINDOWSNT.
10778 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10779 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10780 USE_X_TOOLKIT.
10781
1675728f
PE
10782 * ftxfont.c: Make symbols static if they're not exported.
10783 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10784 HAVE_FREETYPE.
10785 * font.h (ftxfont_driver): Likewise.
10786
e4cebfca
PE
10787 * xfns.c: Make symbols static if they're not exported.
10788 (x_last_font_name, x_display_info_for_name):
10789 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10790 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10791 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10792 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10793 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10794 (last_show_tip_args): Now static.
10795 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10796 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10797 (x_screen_planes): Remove; unused.
10798 * dispextern.h (x_screen_planes): Remove decl.
10799
5bf46f05
PE
10800 * dispnew.c: Make symbols static if they're not exported.
10801 * dispextern.h (redraw_garbaged_frames, scrolling):
10802 (increment_row_positions): Remove.
10803 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10804 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10805 Now static.
10806 (redraw_garbaged_frames): Remove; unused.
10807
435f4c28
PE
10808 * xfaces.c: Make symbols static if they're not exported.
10809 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10810 Remove decls.
10811 * xterm.h (defined_color): Remove decls.
10812 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10813 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10814 (menu_face_changed_default, defined_color, free_realized_face):
10815 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10816 (ascii_face_of_lisp_face): Remove; unused.
10817
8524aef3
PE
10818 * xdisp.c: Make symbols static if they're not exported.
10819 * dispextern.h (scratch_glyph_row, window_box_edges):
10820 (glyph_to_pixel_coords, set_cursor_from_row):
10821 (get_next_display_element, set_iterator_to_next):
10822 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10823 (show_mouse_face): Remove decls
10824 * frame.h (message_buf_print): Likewise.
10825 * lisp.h (pop_message, set_message, check_point_in_composition):
10826 Likewise.
10827 * xterm.h (set_vertical_scroll_bar): Likewise.
10828 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10829 (message_buf_print, scratch_glyph_row, displayed_buffer):
10830 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10831 (get_next_display_element, show_mouse_face, window_box_edges):
10832 (frame_to_window_pixel_xy, check_point_in_composition):
10833 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10834 (glyph_to_pixel_coords): Remove; unused.
10835
16390cd2
PE
10836 * dired.c (file_name_completion): Now static.
10837
10838 * dbusbind.c (xd_in_read_queued_messages): Now static.
10839
a25f4dfa
PE
10840 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10841 * data.c (circular_list_error): Remove.
10842
14a9c8df
PE
10843 * commands.h (last_point_position, last_point_position_buffer):
10844 (last_point_position_window): Remove decls.
10845 * keyboard.c: Make these variables static.
10846
04f2d78b
CB
10847 * coding.h (coding, code_convert_region, encode_coding_gap):
10848 Remove decls.
74ab6df5
PE
10849 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10850 (iso_code_class, detect_coding, code_convert_region): Now static.
10851 (encode_coding_gap): Remove; unused.
10852
38dfbee1
PE
10853 * chartab.c (chartab_chars, chartab_bits): Now static.
10854
a2cb4e63
PE
10855 * charset.h (charset_iso_8859_1): Remove decl.
10856 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10857 Now static.
10858
127198fd
PE
10859 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10860 * ccl.c (Vccl_program_table): Now static.
10861 (check_ccl_update): Remove; unused.
10862
d85b608f
PE
10863 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10864 * category.h: ... from here.
10865 * category.c (check_category_table, set_category_set): Now static.
10866
31cd66f3
PE
10867 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10868 * lisp.h: Remove these decls.
10869
c358e587
PE
10870 * buffer.c (buffer_count): Remove unused var.
10871
e78aecca
PE
10872 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10873 so that it's not optimized away.
10874 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10875 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10876 exported only to the debugger.
10877
e192d7d3 10878 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10879 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10880
92470028
PE
10881 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10882 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10883 was inaccessible from Lisp.
10884 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10885 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10886
244ed907
PE
10887 alloc.c: Import and export fewer symbols, and remove unused items.
10888 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10889 is defined.
10890 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10891 it's not optimized away by whole-program optimization.
10892 (message_enable_multibyte, free_misc): Remove.
10893 (catchlist, handlerlist, mark_backtrace):
10894 Declare only if BYTE_MARK_STACK.
10895 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10896 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10897 (message_enable_multibyte): Remove decl.
10898 (free_misc, interval_free_list, float_block, float_block_index):
10899 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10900 (cons_free_list, last_marked_index):
10901 Now static.
10902 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10903 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10904 (mark_backtrace): Define only if BYTE_MARK_STACK.
10905 * xdisp.c (message_enable_multibyte): Now static.
10906
61c2b50e 10907 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10908 This makes it easier for human readers (and static analyzers)
10909 to see whether these variables are used from other modules.
10910 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10911 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10912 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10913 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10914 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10915 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10916 * xmenu.c, xselect.c:
10917 Declare Q* vars static if they are not used in other modules.
10918 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10919 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10920 Remove decls of unexported vars.
10921 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10922
95c82688
PE
10923 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10924
16a97296
PE
10925 Make Emacs functions such as Fatom 'static' by default.
10926 This makes it easier for human readers (and static analyzers)
10927 to see whether these functions can be called from other modules.
10928 DEFUN now defines a static function. To make the function external
10929 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10930 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10931 (Finit_image_library):
16a97296
PE
10932 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10933 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10934 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10935 Remove decls, since these functions are now static.
10936 (Funintern, Fget_internal_run_time): New decls, since these functions
10937 were already external.
95c82688 10938
16a97296
PE
10939 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10940 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10941 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10942 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10943 * keyboard.c, keymap.c, lread.c:
10944 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10945 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10946 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10947 Mark functions with DEFUE instead of DEFUN,
10948 if they are used in other modules.
10949 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10950 decls for now-static functions.
10951 * buffer.h (Fdelete_overlay): Remove decl.
10952 * callproc.c (Fgetenv_internal): Mark as internal.
10953 * composite.c (Fremove_list_of_text_properties): Remove decl.
10954 (Fcomposition_get_gstring): New forward static decl.
10955 * composite.h (Fcomposite_get_gstring): Remove decl.
10956 * dired.c (Ffile_attributes): New forward static decl.
10957 * doc.c (Fdocumntation_property): New forward static decl.
10958 * eval.c (Ffetch_bytecode): New forward static decl.
10959 (Funintern): Remove extern decl; now in .h file where it belongs.
10960 * fileio.c (Fmake_symbolic_link): New forward static decl.
10961 * image.c (Finit_image_library): New forward static decl.
10962 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10963 * intervals.h (Fprevious_property_change):
10964 (Fremove_list_of_text_properties): Remove decls.
10965 * keyboard.c (Fthis_command_keys): Remove decl.
10966 (Fcommand_execute): New forward static decl.
10967 * keymap.c (Flookup_key): New forward static decl.
10968 (Fcopy_keymap): Now static.
10969 * keymap.h (Flookup_key): Remove decl.
10970 * process.c (Fget_process): New forward static decl.
10971 (Fprocess_datagram_address): Mark as internal.
10972 * syntax.c (Fsyntax_table_p): New forward static decl.
10973 (skip_chars): Remove duplicate decl.
10974 * textprop.c (Fprevious_property_change): New forward static decl.
10975 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10976 Now internal.
10977 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10978 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10979
785bbd42
PE
10980 * editfns.c (Fformat): Remove unreachable code.
10981
8b913b57
AS
109822011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10983
10984 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10985 change. (Bug#8496)
10986
a6744a35
EZ
109872011-04-13 Eli Zaretskii <eliz@gnu.org>
10988
10989 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10990 when at ZV. (Bug#8487)
10991
e7974947
AS
109922011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10993
baad03f0
AS
10994 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10995 (Bug#8437)
10996 * keyboard.c (parse_tool_bar_item): Likewise.
10997 * sound.c (sound_cleanup, alsa_close): Likewise.
10998 * termcap.c (tgetent): Likewise.
10999 * xfns.c (x_default_font_parameter): Likewise.
11000 * xsettings.c (read_and_apply_settings): Likewise.
11001
e7974947
AS
11002 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11003 (overrun_check_free): Protoize.
11004
28272684
PE
110052011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11006
11007 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11008 since callers should never pass a negative size.
11009 Change the signature to match that of plain 'read' and 'write'; see
11010 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11011 * lisp.h: Update prototypes of emacs_write and emacs_read.
11012
11997c76
EZ
110132011-04-11 Eli Zaretskii <eliz@gnu.org>
11014
11015 * xdisp.c (redisplay_window): Don't try to determine the character
11016 position of the scroll margin if the window start point w->startp
e896f03c 11017 is outside the buffer's accessible region. (Bug#8468)
11997c76 11018
8a2cbd72
EZ
110192011-04-10 Eli Zaretskii <eliz@gnu.org>
11020
11021 Fix write-region and its subroutines for buffers > 2GB.
11022 * fileio.c (a_write, e_write): Modify declaration of arguments and
11023 local variables to support buffers larger than 2GB.
11024 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11025
11026 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11027 argument, local variables, and return value.
11028
11029 * lisp.h: Update prototypes of emacs_write and emacs_read.
11030
11031 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11032
4073e537 110332011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11034
1ebfdcb6
PE
11035 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11036
b2ded58d
PE
11037 Fix more problems found by GCC 4.6.0's static checks.
11038
7d66342c
PE
11039 * xdisp.c (vmessage): Use a better test for character truncation.
11040
bbf47d44
PE
11041 * charset.c (load_charset_map): <, not <=, for optimization,
11042 and to avoid potential problems with integer overflow.
9248994d 11043 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11044 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11045 * editfns.c (Fformat): Likewise.
1e69125e 11046 * syntax.c (skip_chars): Likewise.
3befa583 11047
e3019616
PE
11048 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11049 This also lets GCC 4.6.0 generate slightly better loop code.
11050
becfa255
PE
11051 * callint.c (Fcall_interactively): <, not <=, for optimization.
11052 (Fcall_interactively): Count the number of arguments produced,
11053 not the number of arguments given. This is simpler and lets GCC
11054 4.6.0 generate slightly better code.
11055
dae0cd48
PE
11056 * ftfont.c: Distingish more carefully between FcChar8 and char.
11057 The previous code passed unsigned char * to a functions like
11058 strlen and xstrcasecmp that expect char *, which does not
11059 conform to the C standard.
11060 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11061 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11062 char * when the C standard requires it.
11063
76032d70
PE
11064 * keyboard.c (read_char): Remove unused var.
11065
eb3f1cc8
PE
11066 * eval.c: Port to Windows vsnprintf (Bug#8435).
11067 Include <limits.h>.
11068 (SIZE_MAX): Define if the headers do not.
11069 (verror): Do not give up if vsnprintf returns a negative count.
11070 Instead, grow the buffer. This ports to Windows vsnprintf, which
11071 does not conform to C99. Problem reported by Eli Zaretskii.
11072 Also, simplify the allocation scheme, by avoiding the need for
11073 calling realloc, and removing the ALLOCATED variable.
11074
70476b54
PE
11075 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11076
12020a9e
PE
11077 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11078 But keep the doprint source code for now, as we might revamp it
11079 and use it again (Bug#8435).
ea6c7ae6
PE
11080 * lisp.h (doprnt): Remove.
11081 * Makefile.in (base_obj): Remove doprnt.o.
11082 * deps.mk (doprnt.o): Remove.
11083
5fdb398c
PE
11084 error: Print 32- and 64-bit integers portably (Bug#8435).
11085 Without this change, on typical 64-bit hosts error ("...%d...", N)
11086 was used to print both 32- and 64-bit integers N, which relied on
11087 undefined behavior.
61bdb816 11088 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11089 * lisp.h (error, verror): Mark as printf-like functions.
11090 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11091 Report overflow in size calculations when allocating printf buffer.
11092 Do not truncate output string at its first null byte.
11093 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11094 Truncate the output at a character boundary, since vsnprintf does not
11095 do that.
11096 * charset.c (check_iso_charset_parameter): Convert internal
11097 character to string before calling 'error', since %c now has the
11098 printf meaning.
11099 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11100 overflow when computing char to be passed to 'error'. Do not
11101 pass Lisp_Object to 'error'; pass the integer instead.
11102 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11103 formatted with plain %d.
11104
b189fa66
PE
11105 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11106
bff87ef0
PE
11107 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11108
7e2cac20
PE
11109 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11110
ce4d90b5
PE
11111 * xterm.c (x_catch_errors): Remove duplicate declaration.
11112
266c9547
PE
11113 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11114
79c49ad2
PE
11115 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11116
368f4090
JM
111172011-04-10 Jim Meyering <meyering@redhat.com>
11118
11119 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11120 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11121 return ssize_t not "int", and use size_t as the buffer length.
11122 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11123 * gnutls.h: Update declarations.
11124 * process.c (read_process_output): Use ssize_t, to match.
11125 (send_process): Likewise.
11126
a32d4040
CY
111272011-04-09 Chong Yidong <cyd@stupidchicken.com>
11128
11129 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11130
8546720e 111312011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11132
04f2d78b
CB
11133 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11134 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11135
8546720e
GM
11136 * xterm.c (handle_one_xevent):
11137 * xmenu.c (create_and_show_popup_menu):
11138 * xselect.c (x_decline_selection_request)
11139 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11140
0a2f5c1a 111412011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11142
11143 Fix some uses of `int' instead of EMACS_INT.
11144 * search.c (string_match_1, fast_string_match)
11145 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11146 (scan_buffer, find_next_newline_no_quit)
11147 (find_before_next_newline, search_command, Freplace_match)
11148 (Fmatch_data): Make some `int' variables be EMACS_INT.
11149
11150 * xdisp.c (display_count_lines): 3rd argument and return value now
11151 EMACS_INT. All callers changed.
11152 (pint2hrstr): Last argument is now EMACS_INT.
11153
11154 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11155 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11156 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11157 (decode_coding_utf_16, decode_coding_emacs_mule)
11158 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11159 (decode_coding_ccl, decode_coding_charset)
11160 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11161 (decode_coding_iso_2022, decode_coding_emacs_mule)
11162 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11163 <char_offset, last_offset>: Declare EMACS_INT.
11164 (encode_coding_utf_8, encode_coding_utf_16)
11165 (encode_coding_emacs_mule, encode_invocation_designation)
11166 (encode_designation_at_bol, encode_coding_iso_2022)
11167 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11168 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11169 Declare EMACS_INT.
11170 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11171 (encode_invocation_designation): Last argument P_NCHARS is now
11172 EMACS_INT.
11173 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11174 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11175
11176 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11177 All users changed.
11178
11179 * ccl.c (Fccl_execute_on_string): Declare some variables
11180 EMACS_INT.
11181
8546720e 111822011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11183
11184 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11185
4e19a977
CS
111862011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11187
11188 * process.c (Fformat_network_address): Doc fix.
11189
87302331
R
111902011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11191
ee7683eb 11192 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11193
cbb59342
CY
111942011-04-08 Chong Yidong <cyd@stupidchicken.com>
11195
11196 * keyboard.c (read_char): Call Lisp function help-form-show,
11197 instead of using internal_with_output_to_temp_buffer.
11198 (Qhelp_form_show): New var.
e0d38eeb 11199 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11200
11201 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11202
11203 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11204
e67a13ab
CY
112052011-04-06 Chong Yidong <cyd@stupidchicken.com>
11206
04f2d78b
CB
11207 * process.c (Flist_processes): Remove to Lisp.
11208 (list_processes_1): Delete.
e67a13ab 11209
973f782d
EZ
112102011-04-06 Eli Zaretskii <eliz@gnu.org>
11211
7c106b1e
EZ
11212 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11213
973f782d
EZ
11214 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11215
41cf7d1a 112162011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11217
ca23cc88
PE
11218 Fix more problems found by GCC 4.6.0's static checks.
11219
f390e2d5
PE
11220 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11221
42eea0d0
PE
11222 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11223
b69769da 11224 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11225
f9541e84
PE
11226 * xdisp.c (vmessage): Mark as a printf-like function.
11227
13841b55
PE
11228 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11229
c136c10f
PE
11230 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11231
5e2d4a30
PE
11232 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11233 printf-like functions.
11234 (tiff_load): Add casts to remove these marks before passing them
11235 to system-supplied API.
11236
583f48b9
PE
11237 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11238
b25d760e
PE
11239 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11240 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11241 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11242 directly, rather than having caller test rule sign. This avoids
11243 some unnecessary tests.
11244 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11245 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11246 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11247
bc7b6697 11248 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11249 (xfont_open): Avoid unnecessary tests.
bc7b6697 11250
27ccc379
PE
11251 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11252
dcd5c89a
PE
11253 * composite.h, composite.c (composition_gstring_put_cache):
11254 Use EMACS_INT, not int, for length.
11255
b13a45c6
PE
11256 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11257 breaking out part of COMPOSITION_DECODE_RULE.
11258 (COMPOSITION_DECODE_RULE): Use it.
11259 * composite.c (get_composition_id): Remove unused local vars,
11260 by using the new macro.
11261
1e792e4d
PE
11262 * textprop.c (set_text_properties_1): Change while to do-while,
11263 since the condition is always true at first.
11264
dc6c6455 11265 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11266 (interval_deletion_adjustment): Return unsigned value.
11267 All uses changed.
dc6c6455 11268
aba7731a
PE
11269 * process.c (list_processes_1, create_pty, read_process_output):
11270 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11271 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11272 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11273 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11274 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11275
fdfc4bf3
PE
11276 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11277
fca8fe46 11278 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11279 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11280
06a0259a 11281 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11282 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11283 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11284
e7b9e80f
PE
11285 * print.c (print_error_message): Avoid int overflow.
11286
56201685
PE
11287 * font.c (font_list_entities): Redo for clarity,
11288 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11289
78834453 11290 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11291 (font_score): Avoid potential overflow in diff calculation.
78834453 11292
0bc0b309 11293 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11294 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11295
e610eaca
PE
11296 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11297
b895abce
PE
11298 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11299 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11300 can always succeed if overflow has undefined behavior.
11301
1f1d9321 11302 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11303 (wordify): Omit three unnecessary tests.
1f1d9321 11304
c59478bc
PE
11305 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11306 All callers changed. This avoids the need for an unused var.
11307
79b73827
PE
11308 * casefiddle.c (casify_region): Remove var that is set but not used.
11309
a4db5dfe
PE
11310 * dired.c (file_name_completion): Remove var that is set but not used.
11311
43aae36e
PE
11312 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11313
2a47c44d 11314 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11315 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11316
a37c69bf
PE
11317 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11318 Check for integer overflow on size calculations.
11319
328ab8e7
PE
11320 * buffer.c (Fprevious_overlay_change): Remove var that is set
11321 but not used.
11322
e5a2a5cb
PE
11323 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11324 Remove vars that are set but not used.
8d84a6eb 11325 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11326 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11327
a60e5f68
PE
11328 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11329
f661cb61 11330 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11331 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11332
f0397f5a
PE
11333 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11334 that are set but not used.
11335
8664db06 11336 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11337 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11338
6abdaa4a
PE
11339 * xselect.c (x_get_local_selection, x_handle_property_notify):
11340 Remove vars that are set but not used.
11341
0ce7538d 11342 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11343 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11344
9ae848fc
PE
11345 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11346 Remove var that is set but not used.
0b918413
PE
11347 (scroll_bar_windows_size): Now size_t, not int.
11348 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11349 Check for overflow.
9ae848fc 11350
a5a62657
PE
11351 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11352 (map_tty_color) [!defined MSDOS]: Likewise.
11353
5c5cdd39
PE
11354 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11355
66ebf983
PE
11356 * coding.c: Remove vars that are set but not used.
11357 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11358 All callers changed.
11359 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11360 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11361 (decode_coding_charset): Remove vars that are set but not used.
11362
1be4d761
PE
11363 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11364 that is set but not used.
11365
47553fa8
PE
11366 * print.c (print_object): Remove var that is set but not used.
11367
1f7196bf 11368 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11369 The gnulib version avoids calling malloc in the usual case,
11370 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11371 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11372 * filelock.c (current_lock_owner): Likewise.
11373 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11374 * sysdep.c: Include allocator.h, careadlinkat.h.
11375 (emacs_no_realloc_allocator): New static constant.
11376 (emacs_readlink): New function.
fdb61804
PE
11377 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11378 ../lib/careadlinkat.h.
d1fdcab7 11379
f84c17c7
SM
113802011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11381
11382 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11383 first non-nil return value).
11384
ef3862ad
JD
113852011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11386
11387 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11388 if not defined (Bug#8403).
11389
376a7006
JB
113902011-04-02 Juanma Barranquero <lekktu@gmail.com>
11391
11392 * xdisp.c (display_count_lines): Remove parameter `start',
11393 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11394 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11395 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11396 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11397 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11398 and thereabouts. All callers changed.
11399 (get_per_char_metric): Remove parameter `f', unused since
11400 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11401
6ca3801d
JM
114022011-04-02 Jim Meyering <meyering@redhat.com>
11403
11404 do not dereference NULL upon failed strdup
11405 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11406 (ns_get_family): Likewise.
11407
d8e2b5ba
JB
114082011-04-02 Juanma Barranquero <lekktu@gmail.com>
11409
11410 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11411
8c74fcbd
JD
114122011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11413
11414 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11415 later (Bug#8403).
11416
7200d79c
SM
114172011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11418
03408648 11419 Add lexical binding.
7200d79c 11420
03408648
SM
11421 * window.c (Ftemp_output_buffer_show): New fun.
11422 (Fsave_window_excursion):
11423 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11424
11425 * lread.c (lisp_file_lexically_bound_p): New function.
11426 (Fload): Bind Qlexical_binding.
11427 (readevalloop): Remove `evalfun' arg.
11428 Bind Qinternal_interpreter_environment.
11429 (Feval_buffer): Bind Qlexical_binding.
11430 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11431 Mark as dynamic.
11432 (syms_of_lread): Declare `lexical-binding'.
11433
11434 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11435
11436 * keyboard.c (eval_dyn): New fun.
11437 (menu_item_eval_property): Use it.
ca105506
SM
11438
11439 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11440
03408648
SM
11441 * fns.c (concat, mapcar1): Accept byte-code-functions.
11442
11443 * eval.c (Fsetq): Handle lexical vars.
11444 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11445 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11446 (FletX, Flet): Obey lexical binding.
11447 (Fcommandp): Handle closures.
11448 (Feval): New `lexical' arg.
11449 (eval_sub): New function extracted from Feval. Use it almost
11450 everywhere where Feval was used. Look up vars in lexical env.
11451 Handle closures.
11452 (Ffunctionp): Move from subr.el.
11453 (Ffuncall): Handle closures.
11454 (apply_lambda): Remove `eval_flags'.
11455 (funcall_lambda): Handle closures and new byte-code-functions.
11456 (Fspecial_variable_p): New function.
11457 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11458 but without exporting it to Lisp.
23aba0ea 11459
23aba0ea 11460 * doc.c (Fdocumentation, store_function_docstring):
03408648 11461 * data.c (Finteractive_form): Handle closures.
23aba0ea 11462
03408648
SM
11463 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11464 interactive spec.
ba83908c 11465
04f2d78b
CB
11466 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11467 New byte-codes.
03408648
SM
11468 (exec_byte_code): New function extracted from Fbyte_code to handle new
11469 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11470
03408648 11471 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11472
03408648 11473 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11474
e2abce01
JB
114752011-03-31 Juanma Barranquero <lekktu@gmail.com>
11476
11477 * xdisp.c (redisplay_internal): Fix prototype.
11478
63696a73 114792011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11480
63696a73 11481 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11482 (try_scrolling): Use it when setting scroll_limit.
11483 Limit scrolling to 100 screen lines.
63696a73
EZ
11484 (redisplay_window): Even when falling back on "recentering",
11485 position point in the window according to scroll-conservatively,
11486 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11487
11488 (try_scrolling): When point is above the window, allow searching
11489 as far as scroll_max, or one screenful, to compute vertical
11490 distance from PT to the scroll margin position. This prevents
11491 try_scrolling from unnecessarily failing when
11492 scroll-conservatively is set to a value slightly larger than the
11493 window height. Clean up the case of PT below the margin at bottom
11494 of window: scroll_max can no longer be INT_MAX. When aggressive
11495 scrolling is in use, don't let point enter the opposite scroll
11496 margin as result of the scroll.
11497 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11498 threshold of 100 lines for never-recentering scrolling.
11499
e4cc2dfc
JB
115002011-03-31 Juanma Barranquero <lekktu@gmail.com>
11501
11502 * dispextern.h (move_it_by_lines):
11503 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11504 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11505 (message_log_check_duplicate): Remove parameters `prev_bol' and
11506 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11507 (redisplay_internal): Remove parameter `preserve_echo_area',
11508 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11509
11510 * indent.c (Fvertical_motion):
11511 * window.c (window_scroll_pixel_based, Frecenter):
11512 Don't pass `need_y_p' to `move_it_by_lines'.
11513
1c470562
SM
115142011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11515
44f230aa
SM
11516 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11517 steal a few bits to be more compact.
11518 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11519 Remove unneeded casts.
11520
1c470562
SM
11521 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11522
888adce9
ZK
115232011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11524
11525 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11526 binding" message (bug#7967).
11527
f838ed7b
PE
115282011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11529
77861b95
PE
11530 Fix more problems found by GCC 4.6.0's static checks.
11531
de6dbc14
PE
11532 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11533 Remove unused local var.
11534
f838ed7b
PE
11535 * editfns.c (Fmessage_box): Remove unused local var.
11536
792c7b2b
PE
11537 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11538 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11539 Omit unused local vars.
c499e557 11540 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11541 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11542 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11543 Omit unused local var.
11544
ba0165e1
PE
11545 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11546 Don't assume string length fits in int.
32ad8845 11547 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11548 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11549
3c59b4c9
PE
11550 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11551 instead of alloca (Bug#8344).
11552
a3eed478 11553 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11554 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11555
eb4d412d
PE
11556 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11557
1658b401
PE
11558 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11559 concerns.
11560
11561 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11562
11563 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11564
9a2c6e05
PE
11565 * keyboard.c (syms_of_keyboard): Use the same style as later
11566 in this function when indexing through an array. This also
11567 works around GCC bug 48267.
11568
03d0a109
PE
11569 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11570
44f730c8
PE
11571 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11572
fe75f926
PE
11573 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11574 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11575
ffa8c828
PE
11576 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11577 This avoids undefined behavior on integer overflow, and is a bit
11578 more convenient anyway since it is compared to a size_t variable.
11579
c5101a77
PE
11580 Variadic C functions now count arguments with size_t, not int.
11581 This avoids an unnecessary limitation on 64-bit machines, which
11582 caused (substring ...) to crash on large vectors (Bug#8344).
11583 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11584 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11585 All variadic functions and their callers changed accordingly.
c5101a77
PE
11586 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11587 * data.c (arith_driver, float_arith_driver): Likewise.
11588 * editfns.c (general_insert_function): Likewise.
11589 * eval.c (struct backtrace.nargs, interactive_p)
11590 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11591 (funcall_lambda, mark_backtrace): Likewise.
11592 * fns.c (concat): Likewise.
11593 * frame.c (x_set_frame_parameters): Likewise.
11594 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11595 0 if not found, not -1. All callers changed.
11596
dd3f25f7
PE
11597 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11598 (stack_copy_size): Now size_t, not int.
11599 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11600
461c2ab9
JB
116012011-03-28 Juanma Barranquero <lekktu@gmail.com>
11602
11603 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11604 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11605 All callers changed.
11606
11607 * lisp.h (multibyte_char_to_unibyte):
11608 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11609 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11610 * character.h (CHAR_TO_BYTE8):
11611 * cmds.c (internal_self_insert):
11612 * editfns.c (general_insert_function):
11613 * keymap.c (push_key_description):
11614 * search.c (Freplace_match):
11615 * xdisp.c (message_dolog, set_message_1): All callers changed.
11616
f6d62986
SM
116172011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11618
11619 * keyboard.c (safe_run_hook_funcall): New function.
11620 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11621 don't set the hook to nil, but remove the offending function instead.
11622 (Qcommand_hook_internal): Remove, unused.
11623 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11624 Vcommand_hook_internal.
11625
11626 * eval.c (enum run_hooks_condition): Remove.
11627 (funcall_nil, funcall_not): New functions.
11628 (run_hook_with_args): Call each function through a `funcall' argument.
11629 Remove `cond' argument, now redundant.
11630 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11631 (Frun_hook_with_args_until_failure): Adjust accordingly.
11632 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11633
1db5b1ad
JB
116342011-03-28 Juanma Barranquero <lekktu@gmail.com>
11635
11636 * dispextern.h (string_buffer_position): Remove declaration.
11637
11638 * print.c (strout): Remove parameter `multibyte', unused since
11639 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11640
11641 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11642 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11643 All callers changed.
11644
11645 * w32.c (_wsa_errlist): Use braces for struct initializers.
11646
11647 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11648 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11649 All callers changed.
11650 (string_buffer_position): Likewise. Also, make static (it's never
11651 used outside xdisp.c).
11652 (cursor_row_p): Remove parameter `w', unused since
11653 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11654 (decode_mode_spec): Remove parameter `precision', introduced during
11655 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11656 All callers changed.
11657
5ffb62aa
JD
116582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11659
11660 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11661
461c2ab9 116622011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11663
11664 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11665 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11666 (ns_update_auto_hide_menu_bar): New functions.
11667 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11668 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11669 ns_constrain_all_frames.
11670 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11671 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11672
5c380ffb
JD
116732011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11674
11675 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11676
9af30bdf
GM
116772011-03-27 Glenn Morris <rgm@gnu.org>
11678
11679 * syssignal.h: Replace RETSIGTYPE with void.
11680 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11681 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11682 Replace SIGTYPE with void everywhere.
11683 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11684 * s/template.h (SIGTYPE): Remove commented out definition.
11685
e2abce01
JB
116862011-03-26 Eli Zaretskii <eliz@gnu.org>
11687
11688 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11689 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11690
f868cd8a
JB
116912011-03-26 Juanma Barranquero <lekktu@gmail.com>
11692
59eb0929
JB
11693 * w32.c (read_unc_volume): Use parameter `henum', instead of
11694 global variable `wget_enum_handle'.
11695
11696 * keymap.c (describe_vector): Remove parameters `indices' and
11697 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11698 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11699
f868cd8a
JB
11700 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11701
11702 * keyboard.c (timer_check): Remove parameter `do_it_now',
11703 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11704 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11705 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11706
11707 * keyboard.c (read_char):
11708 * w32menu.c (w32_menu_display_help):
11709 * xmenu.c (show_help_event, menu_help_callback):
11710 Adjust calls to `show_help_echo'.
11711
11712 * gtkutil.c (xg_maybe_add_timer):
11713 * keyboard.c (readable_events):
11714 * process.c (wait_reading_process_output):
11715 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11716
11717 * insdel.c (adjust_markers_gap_motion):
11718 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11719 (gap_left, gap_right): Don't call it.
11720
2ecf6fdb
CY
117212011-03-25 Chong Yidong <cyd@stupidchicken.com>
11722
11723 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11724 incurred during fontification.
11725
6b1f9ba4
JB
117262011-03-25 Juanma Barranquero <lekktu@gmail.com>
11727
11728 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11729 (DEFVAR_PER_BUFFER): Don't pass it.
11730
11731 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11732 (scrolling_window): Don't pass it.
11733
0f4a96b5
JB
117342011-03-25 Juanma Barranquero <lekktu@gmail.com>
11735
11736 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11737
11738 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11739 and `suffix'.
11740 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11741 of variables specific to SELinux and computation of `encoded_absname'.
11742
11743 * image.c (XPutPixel): Remove unused variable `height'.
11744
11745 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11746
11747 * unexw32.c (get_section_info): Remove unused variable `section'.
11748
11749 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11750 (system_process_attributes): Remove unused variable `sess'.
11751 (sys_read): Remove unused variable `err'.
11752
11753 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11754 (w32_wnd_proc): Remove unused variable `isdead'.
11755 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11756 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11757 (x_create_tip_frame): Remove unused variable `tem'.
11758
11759 * w32inevt.c (w32_console_read_socket):
11760 Remove unused variable `no_events'.
11761
11762 * w32term.c (x_draw_composite_glyph_string_foreground):
11763 Remove unused variable `width'.
11764
1149507c
JB
117652011-03-24 Juanma Barranquero <lekktu@gmail.com>
11766
11767 * w32term.c (x_set_glyph_string_clipping):
11768 Don't pass uninitialized region to CombineRgn.
11769
9c88f339
JB
117702011-03-23 Juanma Barranquero <lekktu@gmail.com>
11771
11772 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11773 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11774 (Fx_close_connection): Remove unused variable `i'.
11775
11776 * w32font.c (w32font_draw): Return number of glyphs.
11777 (w32font_open_internal): Remove unused variable `i'.
11778 (w32font_driver): Add missing initializer.
11779
11780 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11781 (fill_in_menu): Remove unused variable `items_added'.
11782
11783 * w32term.c (last_mouse_press_frame): Remove static global variable.
11784 (w32_clip_to_row): Remove unused variable `f'.
11785 (x_delete_terminal): Remove unused variable `i'.
11786
11787 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11788 (NOTHING): Remove unused static global variable.
11789 (uniscribe_check_otf): Remove unused variable `table'.
11790 (uniscribe_font_driver): Add missing initializers.
11791
dee091a3
JD
117922011-03-23 Julien Danjou <julien@danjou.info>
11793
11794 * term.c (Fsuspend_tty, Fresume_tty):
11795 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11796 * window.c (temp_output_buffer_show):
11797 * insdel.c (signal_before_change):
11798 * frame.c (Fhandle_switch_frame):
11799 * fileio.c (Fdo_auto_save):
11800 * emacs.c (Fkill_emacs):
11801 * editfns.c (save_excursion_restore):
11802 * cmds.c (internal_self_insert):
11803 * callint.c (Fcall_interactively):
11804 * buffer.c (Fkill_all_local_variables):
11805 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11806 Use Frun_hooks.
0f4a96b5 11807 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11808 unconditionally since it does the check itself.
dee091a3 11809
2c520ab5 118102011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11811
c9c49752
PE
11812 Fix more problems found by GCC 4.5.2's static checks.
11813
8abc3f12
PE
11814 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11815 the first time through the loop, since we know p0 < p1 then.
11816 This also avoids a gcc -Wstrict-overflow warning.
11817
a2d26660
PE
11818 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11819 leading to a memory leak, possible in functions like
11820 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11821 of objects (Bug#8318).
a2d26660 11822
916c72e9
PE
11823 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11824 that could (at least in theory) be that large.
11825
19ab8a18
PE
11826 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11827 This is less likely to overflow, and avoids undefined behavior if
11828 overflow does occur. All callers changed. Use strtoul to scan
11829 for the unsigned long integer.
b7cbbd6f
PE
11830 (pint2hrstr): Simplify and tune code slightly.
11831 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11832
f0641eff
PE
11833 * scroll.c (do_scrolling): Work around GCC bug 48228.
11834 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11835
7f650bb9
PE
11836 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11837 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11838 (validate_x_resource_name): Simplify count usage.
11839 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11840
37dd57d1
PE
11841 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11842 fail (Bug#8306).
81e56e61 11843
699979fc 11844 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11845
401bf9b4
PE
11846 * process.c (Fmake_network_process): Use socklen_t, not int,
11847 where POSIX says socklen_t is required in portable programs.
11848 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11849 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11850 (Fmake_network_process, server_accept_connection):
11851 (wait_reading_process_output, read_process_output):
11852 Likewise.
11853
b93aacde
PE
11854 * process.c: Rename or move locals to avoid shadowing.
11855 (list_processes_1, Fmake_network_process):
11856 (read_process_output_error_handler, exec_sentinel_error_handler):
11857 Rename or move locals.
4dc343ee 11858 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11859 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11860 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11861 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11862 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11863
af8a867c 11864 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11865 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11866 Include tparam.h instead, since it declares them.
af8a867c
PE
11867 * cm.h (PC): Remove extern decl; tparam.h now does this.
11868 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11869 * terminfo.c: Include tparam.h, to check interfaces.
11870 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11871 (tparam): Adjust signature to match interface in tparam.h;
11872 this removes some undefined behavior. Check that outstring and len
11873 are zero, which they always are with Emacs.
11874 * tparam.h (PC, BC, UP): New extern decls.
11875
0248044d 11876 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11877 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11878
8ff096c1 11879 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11880 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11881 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11882 (ftfont_list): Remove unused local.
49eaafba
PE
11883 (get_adstyle_property, ftfont_pattern_entity):
11884 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11885 Rename locals to avoid shadowing.
8ff096c1 11886
e2be39f6
PE
11887 * xfont.c (xfont_list_family): Mark var as initialized.
11888
c9735e30
PE
11889 * xml.c (make_dom): Now static.
11890
8f5201ae
PE
11891 * composite.c (composition_compute_stop_pos): Rename local to
11892 avoid shadowing.
b246f932
PE
11893 (composition_reseat_it): Remove unused locals.
11894 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11895 (composition_update_it): Mark var as initialized.
11b61122
PE
11896 (find_automatic_composition): Mark vars as initialized,
11897 with a FIXME (Bug#8290).
8f5201ae 11898
760fbc2c
PE
11899 character.h: Rename locals to avoid shadowing.
11900 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11901 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11902 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11903 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11904 to avoid shadowing.
11905
ff08eb85
PE
11906 * textprop.c (property_change_between_p): Remove; unused.
11907
fc7bf025
PE
11908 * intervals.c (interval_start_pos): Now static.
11909
235d7abc
PE
11910 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11911
44f230aa
SM
11912 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11913 Rename locals to avoid shadowing.
3e7d6594 11914
50060332
PE
11915 * sound.c (wav_play, au_play, Fplay_sound_internal):
11916 Fix pointer signedness.
d01f234b 11917 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11918 (wav_play): Initialize a variable to 0, to prevent undefined
11919 behavior (Bug#8278).
50060332 11920
c4fc4e30
PE
11921 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11922
918436ed
PE
11923 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11924
c939f91b
PE
11925 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11926 clobbering (Bug#8298).
b9c7f648
PE
11927 * sysdep.c (sys_subshell): Likewise.
11928 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11929
6bd8c144
PE
11930 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11931 This should get cleaned up, so that child_setup has the
11932 same signature on all platforms.
11933
7710357c 11934 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11935 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11936
c59da222
CY
119372011-03-22 Chong Yidong <cyd@stupidchicken.com>
11938
11939 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11940 not to be necessary, and produces flickering.
11941
66b87493
GM
119422011-03-20 Glenn Morris <rgm@gnu.org>
11943
11944 * config.in: Remove file.
11945
45b6f6d5
JB
119462011-03-20 Juanma Barranquero <lekktu@gmail.com>
11947
11948 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11949 are now in src/globals.h.
11950 (syms_of_minibuf): Remove spurious & from previous change.
11951
cd394be1 119522011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11953
11954 * minibuf.c (completing-read-function): New variable.
11955 (completing-read-default): Rename from completing-read.
11956 (completing-read): Call completing-read-function.
11957
b14e3e21
CY
119582011-03-19 Juanma Barranquero <lekktu@gmail.com>
11959
11960 * xfaces.c (Fx_load_color_file):
11961 Read color file from absolute filename (bug#8250).
11962
f2b726e6
JB
119632011-03-19 Juanma Barranquero <lekktu@gmail.com>
11964
11965 * makefile.w32-in: Update dependencies.
11966
09f6ff02
EZ
119672011-03-17 Eli Zaretskii <eliz@gnu.org>
11968
11969 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11970
29a6015a
PE
119712011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11972
a3a6c54e
PE
11973 Fix more problems found by GCC 4.5.2's static checks.
11974
b766f867
PE
11975 * process.c (make_serial_process_unwind, send_process_trap):
11976 (sigchld_handler): Now static.
11977
be02381c
PE
11978 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11979 That way, the code declares only the vars that it needs.
11980 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11981 * s/cygwin.h (PTY_ITERATION): Likewise.
11982 * s/darwin.h (PTY_ITERATION): Likewise.
11983 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11984
57048744
PE
11985 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11986 * process.c (allocate_pty): Don't declare stb unless it's needed.
11987
7914961c 11988 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11989 (CONSTANTLIM): Remove; unused.
11990 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11991 Define only if needed.
7914961c 11992
b3967b18
PE
11993 * unexelf.c (unexec): Name an expression,
11994 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11995 Use a different way to cause a compilation error if anyone uses
11996 n rather than nn, a way that does not involve shadowing.
73366a00 11997 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11998
29a6015a
PE
11999 * deps.mk (unexalpha.o): Remove; unused.
12000
43cfc33e 12001 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12002 * unexec.h: New file.
ce701a33
PE
12003 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12004 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12005 Depend on unexec.h.
12006 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12007 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12008 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12009 Change as necessary to match prototype in unexec.h.
ce701a33 12010
01f44d5a
PE
12011 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12012 shadowing.
4f63c6bb 12013 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12014
a6670b0b
PE
12015 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12016 Rename locals to avoid shadowing.
12017
cef2010d 12018 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12019 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12020
d4d7173a
PE
12021 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12022
f08b802a
PE
12023 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12024 warning when compiling print.c.
12025
3ddb0639
PE
12026 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12027 instead of using an uninitialized var.
5ad03b97 12028 (font_sort_entities): Mark var as initialized.
3ddb0639 12029
170a2692
PE
12030 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12031
e663c700
PE
12032 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12033 pointers to constants.
89bc529a 12034 (font_parse_fcname): Remove unused vars.
7b81e2d0 12035 (font_delete_unmatched): Now static.
ea838e10 12036 (font_get_spec): Remove; unused.
13a547c6
PE
12037 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12038 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12039 Rename or move locals to avoid shadowing.
e663c700 12040
2a80c887 12041 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12042 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12043
1384fa33 12044 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12045 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12046
8b2c52e9
PE
12047 * alloc.c (mark_backtrace): Move decl from here ...
12048 * lisp.h: ... to here, so that it can be checked.
12049
475545b5 12050 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12051 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12052 (lisp_indirect_variable): Name an expression,
12053 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12054 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12055
b1349114 12056 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12057 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12058 Use const pointer when appropriate.
b1349114 12059
a2928364
PE
12060 * lisp.h (get_system_name, get_operating_system_release):
12061 Move decls here, to check interfaces.
12062 * process.c (get_operating_system_release): Move decl to lisp.h.
12063 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12064 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12065 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12066 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12067 (Fformat_time_string, Fencode_time, Finsert_char):
12068 (Ftranslate_region_internal, Fformat):
12069 Rename or remove local vars to avoid shadowing.
9710023e 12070 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12071
a415e694
PE
12072 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12073 avoid shadowing.
12074
8ef4622d
PE
12075 * lisp.h (eassert): Check that the argument compiles, even if
12076 ENABLE_CHECKING is not defined.
12077
946f9a5b
PE
12078 * data.c (Findirect_variable): Name an expression, to avoid
12079 gcc -Wbad-function-cast warning.
112396d6 12080 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12081 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12082 (Fmake_variable_buffer_local, Fmake_local_variable):
12083 Mark variables as initialized.
52746918 12084 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12085
e5aab7e7 12086 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12087 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12088 Rename locals to avoid shadowing.
dff45157
PE
12089 (mark_stack): Move local variables into the #ifdef region where
12090 they're used.
7bc26fdb
PE
12091 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12092 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12093 needed otherwise.
12094 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12095 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12096 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12097
e5aab7e7
PE
12098 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12099 avoids undefined behavior in theory.
12100
4da60324
PE
12101 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12102
88043301
PE
12103 Use functions, not macros, for up- and down-casing (Bug#8254).
12104 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12105 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12106 to use the following functions instead of these macros.
12107 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12108 EMACS_INT, since callers assume the returned value fits in int.
12109 (upcase1): Likewise, for UPCASE_TABLE.
12110 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12111 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12112 the race-condition problem in the old DOWNCASE.
88043301 12113
19ed5445
PE
12114 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12115 Rename locals to avoid shadowing.
12116 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12117 (regex_compile, re_search_2, re_match_2_internal):
12118 Remove unused local vars.
952db0d7
PE
12119 (FREE_VAR): Rewrite so as not to use empty "else",
12120 which gcc can warn about.
da053e48 12121 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12122 (RETALLOC_IF): Define only if needed.
12123 (WORDCHAR_P): Likewise. This one is never needed, but is used
12124 only in a comment talking about a compiler bug, so put inside
12125 the #if 0 of that comment.
12126 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12127 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12128 Remove; unused.
19ed5445 12129
1f3561e4 12130 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12131 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12132 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12133
ded6f8f7
PE
12134 * search.c (simple_search): Remove unused var.
12135
dbd37a95
PE
12136 * dired.c (compile_pattern): Move decl from here ...
12137 * lisp.h: ... to here, so that it can be checked.
12138 (struct re_registers): New forward decl.
12139
7e47afad
PE
12140 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12141
85f24f61
PE
12142 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12143 All uses changed.
12144 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12145 Rename locals to avoid shadowing.
5671df8f 12146 (Fvertical_motion): Mark locals as initialized.
85f24f61 12147
181aa2be 12148 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12149 (casify_region): Mark local as initialized.
181aa2be 12150
930d429c
PE
12151 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12152
7082eac6
PE
12153 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12154 New macros, so that the caller can use some names other than
12155 gcpro1, gcpro2, etc.
12156 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12157 of the new macros.
12158 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12159 argument, for consistency with GCPRO2_VAR, etc: it is now the
12160 prefix of the variable, not the variable itself. All uses
12161 changed.
38b2c076
PE
12162 * dired.c (directory_files_internal, file_name_completion):
12163 Rename locals to avoid shadowing.
12164
15206ed9
PE
12165 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12166 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12167 dired.c's scmp function, had undefined behavior.
12168 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12169 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12170 * buffer.h: ... to here, because these macros use current_buffer,
12171 and the new implementation with inline functions needs to have
12172 current_buffer in scope now, rather than later when the macros
12173 are used.
12174 (downcase, upcase1): New static inline functions.
12175 (DOWNCASE, UPCASE1): Reimplement using these functions.
12176 This avoids undefined behavior in expressions like
12177 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12178 from race conditions in accessing the global variables
12179 case_temp1 and case_temp2.
12180 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12181 * lisp.h (case_temp1, case_temp2): Remove their decls.
12182 * character.h (ASCII_CHAR_P): Move from here ...
12183 * lisp.h: ... to here, so that the inline functions mentioned
12184 above can use them.
12185
4a6bea26
PE
12186 * dired.c (directory_files_internal_unwind): Now static.
12187
f14b7e14
PE
12188 * fileio.c (file_name_as_directory, directory_file_name):
12189 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12190 Now static.
2893f146
PE
12191 (file_name_as_directory): Use const pointers when appropriate.
12192 (Fexpand_file_name): Likewise. In particular, newdir might
12193 point at constant storage, so make it a const pointer.
fd4ead52 12194 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12195 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12196 signedness issues.
f839df0c
PE
12197 (Fset_file_times, Finsert_file_contents, auto_save_error):
12198 Rename locals to avoid shadowing.
f14b7e14 12199
5716756e 12200 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12201 (Ftry_completion, Fall_completions): Rename or remove locals
12202 to avoid shadowing.
5716756e 12203
b4c3046a
PE
12204 * marker.c (bytepos_to_charpos): Remove; unused.
12205
b45db522
PE
12206 * lisp.h (verify_bytepos, count_markers): New decls,
12207 so that gcc does not warn that these functions aren't declared.
12208
85876d07
PE
12209 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12210 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12211 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12212 (copy_text): Remove unused local var.
85876d07 12213
03d78a21 12214 * filelock.c (within_one_second): Now static.
b3dd38ab 12215 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12216
5df8f01b
PE
12217 * buffer.c (fix_overlays_before): Mark locals as initialized.
12218 (fix_start_end_in_overlays): Likewise. This function should be
12219 simplified by using pointers-to-pointers, but that's a different
12220 matter.
b1d876f1 12221 (switch_to_buffer_1): Now static.
8f54f30a
PE
12222 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12223 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12224
a70072c9 12225 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12226 Fix pointer signedness issue.
edced198
PE
12227 (sys_subshell): Mark local as volatile if checking for lint,
12228 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12229 (MAXPATHLEN): Define only if needed.
a70072c9 12230
a0977c44
PE
12231 * process.c (serial_open, serial_configure): Move decls from here ...
12232 * systty.h: ... to here, so that they can be checked.
12233
a884fdcc
PE
12234 * fns.c (get_random, seed_random): Move extern decls from here ...
12235 * lisp.h: ... to here, so that they can be checked.
12236
604efe86 12237 * sysdep.c (reset_io): Now static.
b8950c94 12238 (wait_for_termination_signal): Remove; unused.
604efe86 12239
38fc62d9
PE
12240 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12241 (copy_keymap_item, append_key, push_text_char_description):
12242 Now static.
1004a21a 12243 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12244 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12245 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12246 (describe_map_tree):
12247 Rename locals to avoid shadowing.
38fc62d9 12248
2f2650da
PE
12249 * keyboard.c: Declare functions static if they are not used elsewhere.
12250 (echo_char, echo_dash, cmd_error, top_level_2):
12251 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12252 (read_char, kbd_buffer_get_event, make_lispy_position):
12253 (make_lispy_event, make_lispy_movement, apply_modifiers):
12254 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12255 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12256 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12257 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12258 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12259
a053e86c 12260 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12261 (mark_kboards): Move decl here ...
12262 * alloc.c (mark_kboards): ... from here.
a053e86c 12263
4752793e
PE
12264 * lisp.h (force_auto_save_soon): New decl.
12265
74f10ca7 12266 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12267 (DEFINE_DUMMY_FUNCTION): New macro.
12268 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12269 Use it.
c03cd23f
PE
12270 (main): Add casts to avoid warnings
12271 if GCC considers string literals to be constants.
74f10ca7 12272
022e70d4
PE
12273 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12274
59d6fe83
PE
12275 * dbusbind.c: Pointer signedness fixes.
12276 (xd_signature, xd_append_arg, xd_initialize):
12277 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12278 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12279 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12280 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12281
78320123
PE
12282 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12283 if GCC considers string literals to be constants.
49cebcca 12284 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12285
35ac2a97
SM
122862011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12287
fb103ca9
SM
12288 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12289 (print_preprocess, print_object): New macro to fix last change.
12290
35ac2a97
SM
12291 * print.c (print_preprocess): Don't forget font objects.
12292
62973b41
JB
122932011-03-16 Juanma Barranquero <lekktu@gmail.com>
12294
12295 * emacs.c (USAGE3): Doc fixes.
12296
0e48bb22
AS
122972011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12298
12299 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12300 structure.
12301
7684e57b
JB
123022011-03-14 Juanma Barranquero <lekktu@gmail.com>
12303
12304 * lisp.h (VWindow_system, Qfile_name_history):
12305 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12306 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12307 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12308
12309 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12310 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12311
12312 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12313 * w32console.c (detect_input_pending, read_input_pending)
12314 (encode_terminal_code):
12315 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12316 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12317 (w32_system_caret_y, Qfile_name_history):
12318 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12319 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12320 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12321 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12322 * w32proc.c (Qlocal, report_file_error):
12323 * w32term.c (Vwindow_system, updating_frame):
12324 * w32uniscribe.c (initialized, uniscribe_font_driver):
12325 Remove unneeded extern declarations.
12326
2aa46d6c
CY
123272011-03-14 Chong Yidong <cyd@stupidchicken.com>
12328
c96bbc66 12329 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12330
cffc6f3b
CY
123312011-03-13 Chong Yidong <cyd@stupidchicken.com>
12332
12333 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12334 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12335 These macros can no longer be used for assignment.
12336
44f230aa
SM
12337 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12338 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12339 (record_buffer_markers, fetch_buffer_markers): New functions for
12340 recording and fetching special buffer markers.
12341 (set_buffer_internal_1, set_buffer_temp): Use them.
12342
12343 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12344
12345 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12346
12347 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12348 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12349
12350 * xdisp.c (hscroll_window_tree):
12351 (reconsider_clip_changes): Use PT instead of BUF_PT.
12352
d251f04b
EZ
123532011-03-13 Eli Zaretskii <eliz@gnu.org>
12354
12355 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12356 $(EMACS_ROOT)/lib/intprops.h.
12357
f0c77cd1
PE
123582011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12359
3eca4629
PE
12360 Fix more problems found by GCC 4.5.2's static checks.
12361
7c86ee98
PE
12362 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12363 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12364 (xg_free_frame_widgets): Make it clear that a local variable is
12365 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12366 (gdk_window_get_screen): Make it clear that this macro is needed
12367 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12368 (int_gtk_range_get_value): New function, which avoids a diagnostic
12369 from gcc -Wbad-function-cast.
12370 (xg_set_toolkit_scroll_bar_thumb): Use it.
12371 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12372 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12373 (get_utf8_string, xg_get_file_with_chooser):
12374 Rename locals to avoid shadowing.
12375 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12376
41729b81
PE
12377 * xgselect.c (xg_select): Remove unused var.
12378
f0c77cd1
PE
12379 * image.c (four_corners_best): Mark locals as initialized.
12380 (gif_load): Initialize transparent_p to zero (Bug#8238).
12381 Mark another local as initialized.
ec6cf4c6 12382 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12383
ce0ad53d 12384 * image.c (clear_image_cache): Now static.
d5d5a617 12385 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12386 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12387 (x_edge_detection): Remove unnecessary cast that
12388 gcc -Wbad-function-cast diagnoses.
2037898d 12389 (gif_load): Fix pointer signedness.
6ae141d6
PE
12390 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12391 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12392
33383987 123932011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12394
d32df629
PE
12395 Improve quality of tests for time stamp overflow.
12396 For example, without this patch (encode-time 0 0 0 1 1
12397 1152921504606846976) returns the obviously-bogus value (-948597
12398 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12399 reports time overflow. See
12400 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12401 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12402 * editfns.c: Include limits.h and intprops.h.
12403 (TIME_T_MIN, TIME_T_MAX): New macros.
12404 (time_overflow): Move earlier, to before first use.
12405 (hi_time, lo_time): New functions, for an accurate test for
12406 out-of-range times.
12407 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12408 (Fget_internal_run_time): Don't assume time_t fits in int.
12409 (make_time): Use list2 instead of Fcons twice.
12410 (Fdecode_time): More accurate test for out-of-range times.
12411 (check_tm_member): New function.
12412 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12413 (lisp_time_argument): Don't rely on undefined left-shift and
12414 right-shift behavior when checking for time stamp overflow.
8be6f318 12415
fe31d94c
PE
12416 * editfns.c (time_overflow): New function, refactoring common code.
12417 (Fformat_time_string, Fdecode_time, Fencode_time):
12418 (Fcurrent_time_string): Use it.
12419
8be6f318
PE
12420 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12421 * dired.c (make_time): Move to ...
12422 * editfns.c (make_time): ... here.
12423 * systime.h: Note the move.
12424
09d9db2c 124252011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12426
126bc0dc
YM
12427 * fringe.c (update_window_fringes): Remove unused variables.
12428
c47cbdfd
YM
12429 * unexmacosx.c (copy_data_segment): Also copy __got section.
12430 (Bug#8223)
12431
7ac80be9
EZ
124322011-03-12 Eli Zaretskii <eliz@gnu.org>
12433
c96bbc66 12434 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12435 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12436 Constify `char *' arguments and their references according to
12437 prototypes in tparam.h.
12438
ecb0f94d 12439 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12440
7ac80be9
EZ
12441 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12442 Adapt all references accordingly.
12443
12444 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12445
ef1fd07e
TT
124462011-03-11 Tom Tromey <tromey@redhat.com>
12447
12448 * buffer.c (syms_of_buffer): Remove obsolete comment.
12449
7ef4b50c
EZ
124502011-03-11 Eli Zaretskii <eliz@gnu.org>
12451
12452 * termhooks.h (encode_terminal_code): Declare prototype.
12453
12454 * msdos.c (encode_terminal_code): Don't declare prototype.
12455
12456 * term.c (encode_terminal_code): Now external again, used by
12457 w32console.c and msdos.c.
12458
44f230aa
SM
12459 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12460 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12461
4b1ec863 124622011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12463
1714f52b 12464 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12465
4b1ec863
PE
12466 * fringe.c (update_window_fringes): Mark locals as initialized
12467 (Bug#8227).
12468 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12469
524c7aa6
PE
12470 * alloc.c (mark_fringe_data): Move decl from here ...
12471 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12472 to check its interface.
12473 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12474
a5c0af81 12475 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12476 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12477 (fontset_font): Mark local as initialized.
a9a06e0b 12478 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12479
b4716021
PE
12480 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12481
811e9bac 12482 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12483 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12484 (x_own_selection, Fx_disown_selection_internal): Rename locals
12485 to avoid shadowing.
12486 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12487
7e3ab302
PE
12488 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12489 so that the caller can use some name other than gcpro1.
12490 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12491 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12492 (Fx_backspace_delete_keys_p):
12493 Use them to avoid shadowing, and rename vars to avoid shadowing.
12494 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12495 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12496 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12497 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12498 Remove unused locals.
7e3ab302
PE
12499 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12500 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12501 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12502 macros.
f78faa98 12503
e2b13473
PE
12504 * xterm.h (x_mouse_leave): New decl.
12505
77f23912
PE
12506 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12507 Remove unused functions.
cdf4ba58
PE
12508 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12509 (x_calc_absolute_position): Now static.
7411c686 12510 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12511 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12512 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12513 unless they are used.
38d0b34a
PE
12514 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12515 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12516 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12517 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12518 (x_error_catcher, x_connection_closed, x_error_handler):
12519 (x_error_quitter, xembed_send_message, x_iconify_frame):
12520 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12521 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12522 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12523
44f230aa
SM
12524 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12525 Rename or move locals to avoid shadowing.
6b463e58 12526 (tty_defined_color, merge_face_heights): Now static.
5967d051 12527 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12528 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12529 does not deduce is never used uninitialized.
73719eba
PE
12530 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12531 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12532
426994c3 12533 * terminal.c (store_terminal_param): Now static.
5489860b 12534
032f1620 12535 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12536 (set_frame_menubar): Remove unused local.
d4323972 12537 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12538 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12539 since they might point to immutable storage.
281585b0
PE
12540 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12541 since it's unused otherwise.
032f1620 12542
367c19e5 12543 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12544 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12545 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12546 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12547 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12548 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12549 does not deduce are never used uninitialized.
70739cbe 12550
07b48fa9
PE
12551 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12552
8868a238 12553 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12554 * window.c (window_loop, size_window):
12555 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12556
7e5cf297 12557 * window.c (display_buffer): Now static.
d6550a9f
PE
12558 (size_window): Mark variables that gcc -Wuninitialized
12559 does not deduce are never used uninitialized.
a586633d
PE
12560 * window.h (check_all_windows): New decl, to forestall
12561 gcc -Wmissing-prototypes diagnostic.
5b555da1 12562 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12563
f6095868
PE
12564 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12565 shadowing.
12566 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12567 Include <limits.h>.
12568 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12569 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12570 (load_charset_map): Mark variables that gcc -Wuninitialized
12571 does not deduce are never used uninitialized.
53df7c11 12572 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12573
f38b440c
PE
12574 * coding.c (coding_set_source, coding_set_destination):
12575 Use "else { /* comment */ }" rather than "else /* comment */;"
12576 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12577 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12578 a block, when the outer 'i' will do.
12579 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12580 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12581 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12582 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12583 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12584 Rename locals to avoid shadowing.
12585 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12586 * coding.c (emacs_mule_char, encode_invocation_designation):
12587 Now static, since they're not used elsewhere.
413bb2db 12588 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12589 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12590 (decode_coding_emacs_mule): Mark variables that gcc
12591 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12592 (detect_coding_iso_2022): Initialize a local variable that might
12593 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12594 this initialization is needed. (Bug#8211)
5f58e762
PE
12595 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12596 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12597 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12598 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12599 Remove unused macros.
f38b440c 12600
232b38b9 12601 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12602 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12603 * character.c (string_count_byte8): Likewise.
232b38b9 12604
fb90da1b
PE
12605 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12606 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12607
fb93dbc2
PE
12608 * chartab.c (copy_sub_char_table): Now static, since it's not used
12609 elsewhere.
5c156ace
PE
12610 (sub_char_table_ref_and_range, char_table_ref_and_range):
12611 Rename locals to avoid shadowing.
bbcd0949 12612 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12613
7d3b3862 12614 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12615 (BIDI_BOB): Remove unused macro.
7d3b3862 12616
6be7d3da
PE
12617 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12618 deduce are never used uninitialized.
c2ed9c8b 12619 * term.c (encode_terminal_code): Likewise.
6be7d3da 12620
75f8807f 12621 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12622
50938595
PE
12623 * tparam.h: New file.
12624 * term.c, tparam.h: Include it.
12625 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12626 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12627 Move these decls to tparam.h, and make them agree with what
12628 is actually in tparam.c. The previous trick of using incompatible
12629 decls in different modules does not conform to the C standard.
12630 All callers of tparam changed to use tparam's actual API.
12631 * tparam.c (tparam1, tparam, tgoto):
12632 Use const pointers where appropriate.
12633
fbceeba2
PE
12634 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12635 * cm.h (struct cm): Likewise.
12636 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12637 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12638 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12639 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12640 (turn_on_face, init_tty): Likewise.
12641 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12642
7f3f1250
PE
12643 * term.c (term_mouse_position): Rename local to avoid shadowing.
12644
e6ca6543
PE
12645 * alloc.c (mark_ttys): Move decl from here ...
12646 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12647
c40f8d15
AS
126482011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12649
12650 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12651
cfe0661d
JB
126522011-03-09 Juanma Barranquero <lekktu@gmail.com>
12653
12654 * search.c (compile_pattern_1): Remove argument regp, unused since
12655 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12656 (compile_pattern): Don't pass it.
12657
0afb4571
J
126582011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12659
12660 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12661 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12662 for ! HAVE_GTK3.
12663 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12664
12665 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12666
12667 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12668 gdk_window_get_screen, gdk_window_get_geometry,
12669 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12670 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12671 (xg_get_pixbuf_from_pixmap): New function.
12672 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12673 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12674 Call xg_get_pixbuf_from_pixmap instead of
12675 gdk_pixbuf_get_from_drawable.
12676 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12677 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12678 (xg_check_special_colors): Use GtkStyleContext and its functions
12679 for HAVE_GTK3.
12680 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12681 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12682 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12683 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12684 Call gtk_widget_get_preferred_size.
0afb4571
J
12685 (xg_frame_resized): gdk_window_get_geometry only takes 5
12686 parameters.
44f230aa
SM
12687 (xg_win_to_widget, xg_event_is_for_menubar):
12688 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12689 (xg_set_widget_bg): New function.
12690 (delete_cb): New function.
895009e1 12691 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12692 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12693 (xg_set_background_color): Call xg_set_widget_bg.
12694 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12695 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12696 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12697 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12698 if ! HAVE_GTK3.
12699 (update_frame_tool_bar): Call gtk_widget_hide.
12700 (xg_initialize): Use GDK_KEY_g.
12701
12702 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12703 if ! HAVE_GTK3
12704 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12705
12706 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12707 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12708 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12709
1c2cc4ef
JB
127102011-03-08 Juanma Barranquero <lekktu@gmail.com>
12711
12712 * w32xfns.c (select_palette): Check success of RealizePalette against
12713 GDI_ERROR, not zero.
12714
33383987 12715See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12716
12717;; Local Variables:
12718;; coding: utf-8
aac0c6e3
MR
12719;; End:
12720
2f097256 12721 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12722
12723 This file is part of GNU Emacs.
12724
12725 GNU Emacs is free software: you can redistribute it and/or modify
12726 it under the terms of the GNU General Public License as published by
12727 the Free Software Foundation, either version 3 of the License, or
12728 (at your option) any later version.
12729
12730 GNU Emacs is distributed in the hope that it will be useful,
12731 but WITHOUT ANY WARRANTY; without even the implied warranty of
12732 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12733 GNU General Public License for more details.
12734
12735 You should have received a copy of the GNU General Public License
12736 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.