* fns.c: Don't overflow int when computing a list length.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d96be9fc
PE
12011-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
e6966cd6
PE
3 * fns.c: Don't overflow int when computing a list length.
4 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6 truncation on 64-bit hosts. Check for QUIT every
7 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8 faster and is responsive enough.
9 (Flength): Report an error instead of overflowing an integer.
10 (Fsafe_length): Return a float if the value is not representable
11 as a fixnum. This shouldn't happen except in contrived situations.
00c604f2 12
dd0b0efb
PE
13 * alloc.c: Check that resized vectors' lengths fit in fixnums.
14 (header_size, word_size): New constants.
15 (allocate_vectorlike): Don't check size overflow here.
16 (allocate_vector): Check it here instead, since this is the only
17 caller of allocate_vectorlike that could cause overflow.
18 Check that the new vector's length is representable as a fixnum.
19
86fe5cfe
PE
20 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
21 The previous code was bogus. For example, next_almost_prime (32)
22 returned 39, which is undesirable as it is a multiple of 3; and
23 next_almost_prime (24) returned 25, which is a multiple of 5 so
24 why was the code bothering to check for multiples of 7?
25
80e88859
PE
26 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
27
4a2f0ad6
PE
28 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
29
f66c7cf8
PE
30 Variadic C functions now count arguments with ptrdiff_t.
31 This partly undoes my 2011-03-30 change, which replaced int with size_t.
32 Back then I didn't know that the Emacs coding style prefers signed int.
33 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
34 were being counted with int, which may truncate counts on 64-bit
35 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
36 * lisp.h (struct Lisp_Subr.function.aMANY)
37 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
38 Arg counts are now ptrdiff_t, not size_t.
39 All variadic functions and their callers changed accordingly.
40 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
41 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
42 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
43 * callint.c (Fcall_interactively): Check arg count for overflow,
44 to avoid potential buffer overrun. Use signed char, not 'int',
45 for 'varies' array, so that we needn't bother to check its size
46 calculation for overflow.
47 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
48 * eval.c (apply_lambda):
49 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
50 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
51 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
52
a1759b76
PE
53 * callint.c (Fcall_interactively): Don't use index var as event count.
54
d96be9fc
PE
55 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
56 * mem-limits.h (SIZE): Remove; no longer used.
57
13bdea59
PE
582011-06-13 Paul Eggert <eggert@cs.ucla.edu>
59
a690a978 60 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 61
578c21e6
PE
62 Remove unnecessary casts.
63 * xterm.c (x_term_init):
64 * xfns.c (x_set_border_pixel):
65 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
66 These aren't needed now that we assume ANSI C.
67
96f53c6c
PE
68 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
69 It's more likely to cause problems (due to unsigned overflow)
70 than to cure them.
71
83c77d31
PE
72 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
73
ee2079f1
PE
74 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
75
6da65536
PE
76 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
77
7147c4a4
PE
78 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
79
193e32d9
PE
80 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
81
e5533da6
PE
82 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
83
9910e595
PE
84 GLYPH_CODE_FACE returns EMACS_INT, not int.
85 * dispextern.h (merge_faces):
86 * xfaces.c (merge_faces):
01103c44
PE
87 * xdisp.c (get_next_display_element, next_element_from_display_vector):
88 Don't assume EMACS_INT fits in int.
9910e595 89
2638320e
PE
90 * character.h (CHAR_VALID_P): Remove unused parameter.
91 * fontset.c, lisp.h, xdisp.c: All uses changed.
92
045eb8d9
PE
93 * editfns.c (Ftranslate_region_internal): Omit redundant test.
94
c1f134b5
PE
95 * fns.c (concat): Minor tuning based on overflow analysis.
96 This doesn't fix any bugs. Use int to hold character, instead
97 of constantly refetching from Emacs object. Use XFASTINT, not
98 XINT, for value known to be a character. Don't bother comparing
99 a single byte to 0400, as it's always less.
100
395fcb93 101 * floatfns.c (Fexpt):
327eeec8
PE
102 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
103
abbd3d23
PE
104 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
105 for characters.
106
684a03ef
PE
107 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
108
0fed43f3
PE
109 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
110 Without this fix, on a 64-bit host (aset S 0 4294967386) would
111 incorrectly succeed when S was a string, because 4294967386 was
112 truncated before it was used.
113
8fd02eb7
PE
114 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
115 Otherwise, an out-of-range integer could cause undefined behavior
116 on a 64-bit host.
117
f8c86b69
PE
118 * composite.c: Use int, not EMACS_INT, for characters.
119 (fill_gstring_body, composition_compute_stop_pos): Use int, not
120 EMACS_INT, for values that are known to be in character range.
121 This doesn't fix any bugs but is the usual style inside Emacs and
122 may generate better code on 32-bit machines.
123
34206dd2
PE
124 Make sure a 64-bit char is never passed to ENCODE_CHAR.
125 This is for reasons similar to the recent CHAR_STRING fix.
126 * charset.c (Fencode_char): Check that character arg is actually
127 a character. Pass an int to ENCODE_CHAR.
128 * charset.h (ENCODE_CHAR): Verify that the character argument is no
129 wider than 'int', as a compile-time check to prevent future regressions
130 in this area.
131
c5958d4c 132 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
133
134 Make sure a 64-bit char is never passed to CHAR_STRING.
135 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
136 by silently ignoring the top 32 bits, allowing some values
137 that were far too large to be valid characters.
138 * character.h: Include <verify.h>.
139 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
140 arguments are no wider than unsigned, as a compile-time check
141 to prevent future regressions in this area.
142 * data.c (Faset):
01103c44 143 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
144 (Fsubst_char_in_region):
145 * fns.c (concat):
146 * xdisp.c (decode_mode_spec_coding):
147 Adjust to CHAR_STRING's new requirement.
148 * editfns.c (Finsert_char, Fsubst_char_in_region):
149 * fns.c (concat): Check that character args are actually
150 characters. Without this test, these functions did the wrong
151 thing with wildly out-of-range values on 64-bit hosts.
152
d37ca623
PE
153 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
154 These casts should not be needed on 32-bit hosts, either.
155 * keyboard.c (read_char):
156 * lread.c (Fload): Remove casts to unsigned.
157
ea204efb
PE
158 * lisp.h (UNSIGNED_CMP): New macro.
159 This fixes comparison bugs on 64-bit hosts.
160 (ASCII_CHAR_P): Use it.
161 * casefiddle.c (casify_object):
01103c44 162 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
163 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
164 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
165 * dispextern.h (FACE_FROM_ID):
166 * keyboard.c (read_char): Use UNSIGNED_CMP.
167
41cb286c
PE
168 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
169 not to EMACS_INT, to avoid GCC warning.
170
4a1b9832
PE
171 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
172
55daad71
PE
173 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
174 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
175 isn't needed on 32-bit machines.
8f95c75c 176
01103c44
PE
177 * buffer.c (Fgenerate_new_buffer_name):
178 Use EMACS_INT for count, not int.
0ceccced 179 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
180
181 * data.c (Qcompiled_function): Now static.
182
c6f072e7
PE
183 * window.c (window_body_lines): Now static.
184
20ce5912
PE
185 * image.c (gif_load): Rename local to avoid shadowing.
186
9c4c5f81
PE
187 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
188 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
189 * alloc.c (make_save_value): Integer argument is now of type
190 ptrdiff_t, not int.
191 (mark_object): Use ptrdiff_t, not int.
192 * lisp.h (pD): New macro.
193 * print.c (print_object): Use it.
194
c0c5c8ae
PE
195 * alloc.c: Use EMACS_INT, not int, to count objects.
196 (total_conses, total_markers, total_symbols, total_vector_size)
197 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
198 (total_free_floats, total_floats, total_free_intervals)
199 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
200 Now EMACS_INT, not int. All uses changed.
201 (Fgarbage_collect): Compute overall total using a double, so that
202 integer overflow is less likely to be a problem. Check for overflow
203 when converting back to an integer.
5a25e253
PE
204 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
205 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
206 These were 'int' variables that could overflow on 64-bit hosts;
207 they were never used, so remove them instead of repairing them.
211a0b2a 208 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
209 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
210 Previously, this ceilinged at INT_MAX, but that doesn't work on
211 64-bit machines.
e46bb31a 212 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 213
c78baabf 214 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 215 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
216 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
217 when a (possibly-narrower) signed value would do just as well.
218 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 219
c9d624c6
PE
220 * alloc.c: Catch some string size overflows that we were missing.
221 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
222 for convenience in STRING_BYTES_MAX.
223 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
224 The definition here is exact; the one in lisp.h was approximate.
225 (allocate_string_data): Check for string overflow. This catches
226 some instances we weren't catching before. Also, it catches
227 size_t overflow on (unusual) hosts where SIZE_MAX <= min
228 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
229 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 230
c9d624c6
PE
231 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
232 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
233 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
234
353032ce
PE
235 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
236
2bccce07
PE
237 * alloc.c (Fmake_string): Check for out-of-range init.
238
e10ac9f1
MR
2392011-06-12 Martin Rudalics <rudalics@gmx.at>
240
241 * frame.c (make_frame): Call other_buffer_safely instead of
242 other_buffer.
243
244 * window.c (temp_output_buffer_show): Call display_buffer with
245 second argument Vtemp_buffer_show_specifiers and reset latter
246 immediately after the call.
247 (Vtemp_buffer_show_specifiers): New variable.
248 (auto_window_vscroll_p, next_screen_context_lines)
249 (Vscroll_preserve_screen_position): Remove leading asterisks from
250 doc-strings.
251
2d3c217e 2522011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 253
7b7f97e8 254 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
255 * buffer.c (Qclone_number): Remove for now, as it's unused.
256 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
257 (record_buffer): Remove unused local.
258 * frame.c (other_visible_frames, frame_buffer_list): Now static.
259 (set_frame_buffer_list): Remove; unused.
260 * frame.h (other_visible_frames): Remove decl.
261 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
262 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
263 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
264 if HAVE_GPM.
265 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
266 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
267 Define only if HAVE_GPM.
268 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
269 (update_hints_inhibit): Remove; never set. All uses removed.
270 * widgetprv.h (emacsFrameClassRec): Remove decl.
271 * window.c (delete_deletable_window): Now returns void, since it
272 wasn't returning anything.
273 (compare_window_configurations): Remove unused locals.
274 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
275 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
276 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
277 the same widths as pointers. This follows up on the 2011-05-06 patch.
278 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
279 * xterm.h: Likewise.
280 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
281
1384b89e
JB
2822011-06-12 Juanma Barranquero <lekktu@gmail.com>
283
284 * makefile.w32-in: Update dependencies.
285 (LISP_H): Add lib/intprops.h.
286
1100a63c
CY
2872011-06-11 Chong Yidong <cyd@stupidchicken.com>
288
289 * image.c (gif_load): Add animation frame delay to the metadata.
290 (syms_of_image): Use DEFSYM. New symbol `delay'.
291
6198ccd0
MR
2922011-06-11 Martin Rudalics <rudalics@gmx.at>
293
294 * window.c (delete_deletable_window): Re-add.
295 (Fset_window_configuration): Rewrite to handle dead buffers and
296 consequently deletable windows.
297 (window_tree, Fwindow_tree): Remove. Supply functionality in
298 window.el.
299 (compare_window_configurations): Simplify code.
300
b6e3633c
AS
3012011-06-11 Andreas Schwab <schwab@linux-m68k.org>
302
1ab0dee5
AS
303 * image.c (imagemagick_load_image): Fix type mismatch.
304 (Fimagemagick_types): Likewise.
305
b6e3633c
AS
306 * window.h (replace_buffer_in_windows): Declare.
307
9397e56f
MR
3082011-06-11 Martin Rudalics <rudalics@gmx.at>
309
310 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
311 Qclone_number. Remove external declaration of Qdelete_window.
312 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
313 code.
314 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
315 Qbuffer_list_update_hook if allowed.
316 (Fother_buffer): Rewrite doc-string. Major rewrite for new
317 buffer list implementation.
318 (other_buffer_safely): New function.
319 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
320 calls to replace_buffer_in_windows and
321 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
322 if allowed.
323 (record_buffer): Inhibit quitting and rewrite using quittable
324 functions. Run Qbuffer_list_update_hook if allowed.
325 (Frecord_buffer, Funrecord_buffer): New functions.
326 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
327 switch-to-buffer to window.el.
328 (bury-buffer): Move to window.el.
329 (Vbuffer_list_update_hook): New variable.
330
331 * lisp.h (other_buffer_safely): Add prototype in buffer.c
332 section.
333
334 * window.h (resize_frame_windows): Move up in code.
335 (Fwindow_frame): Remove EXFUN.
336 (replace_buffer_in_all_windows): Remove prototype.
337 (replace_buffer_in_windows_safely): Add prototype.
338
339 * window.c: Declare Qdelete_window static again. Move down
340 declaration of select_count.
341 (Fnext_window, Fprevious_window): Rewrite doc-strings.
342 (Fother_window): Move to window.el.
343 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
344 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
345 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
346 window.el.
347 (replace_buffer_in_windows): Implement by calling
348 Qreplace_buffer_in_windows.
349 (replace_buffer_in_all_windows): Remove with some functionality
350 moved into replace_buffer_in_windows_safely.
351 (replace_buffer_in_windows_safely): New function.
352 (select_window_norecord, select_frame_norecord): Move in front
353 of run_window_configuration_change_hook. Remove now obsolete
354 declarations.
355 (Fset_window_buffer): Rewrite doc-string. Call
356 Qrecord_window_buffer.
357 (keys_of_window): Move binding for other-window to window.el.
358
b50691aa
CY
3592011-06-11 Chong Yidong <cyd@stupidchicken.com>
360
361 * dispextern.h (struct image): Replace data member, whose int_val
362 and ptr_val fields were not used by anything, with a single
363 lisp_val object.
364
365 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
366 (gif_clear_image, gif_load, imagemagick_load_image)
367 (gs_clear_image, gs_load): Callers changed.
368
3f754b86
PE
3692011-06-10 Paul Eggert <eggert@cs.ucla.edu>
370
cca69397
PE
371 * buffer.h: Include <time.h>, for time_t.
372 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
373
109e28d0
PE
374 Fix minor problems found by static checking.
375
60737f02
PE
376 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
377
4b66faf3
PE
378 Make identifiers static if they are not used in other modules.
379 * data.c (Qcompiled_function, Qframe, Qvector):
380 * image.c (QimageMagick, Qsvg):
381 * minibuf.c (Qmetadata):
382 * window.c (resize_window_check, resize_root_window): Now static.
383 * window.h (resize_window_check, resize_root_window): Remove decls.
384
109e28d0
PE
385 * window.c (window_deletion_count, delete_deletable_window):
386 Remove; unused.
46a4ce9e
PE
387 (window_body_lines): Now static.
388 (Fdelete_other_windows_internal): Mark vars as initialized.
389 Make sure 'resize_failed' is initialized.
390 (run_window_configuration_change_hook): Rename local to avoid shadowing.
391 (resize_window_apply): Remove unused local.
392 * window.h (delete_deletable_window): Remove decl.
393
109e28d0 394 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
395 (imagemagick_load_image): Fix pointer signedness problem by changing
396 last arg from unsigned char * to char *. All uses changed.
397 Also, fix a local for similar reasons.
398 Remove unused locals. Remove locals to avoid shadowing.
399 (fn_rsvg_handle_free): Remove; unused.
400 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 401 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 402
3f754b86
PE
403 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
404
2547adb1
CY
4052011-06-10 Chong Yidong <cyd@stupidchicken.com>
406
407 * image.c (gif_load): Fix omitted cast error introduced by
408 2011-06-06 change.
409
2c8e37d4
MR
4102011-06-10 Martin Rudalics <rudalics@gmx.at>
411
412 * window.h (resize_proportionally, orig_total_lines)
413 (orig_top_line): Remove from window structure.
414 (set_window_height, set_window_width, change_window_heights)
415 (Fdelete_window): Remove prototypes.
416 (resize_frame_windows): Remove duplicate declaration.
417
440a42e3
EZ
4182011-06-10 Eli Zaretskii <eliz@gnu.org>
419
420 * window.h (resize_frame_windows, resize_window_check)
421 (delete_deletable_window, resize_root_window)
422 (resize_frame_windows): Declare prototypes.
423
424 * window.c (resize_window_apply): Make definition be "static" to
425 match the prototype.
426
562dd5e9
MR
4272011-06-10 Martin Rudalics <rudalics@gmx.at>
428
429 * window.c: Remove declarations of Qwindow_size_fixed,
430 window_min_size_1, window_min_size_2, window_min_size,
431 size_window, window_fixed_size_p, enlarge_window, delete_window.
432 Remove static from declaration of Qdelete_window, it's
433 temporarily needed by Fbury_buffer.
434 (replace_window): Don't assign orig_top_line and
435 orig_total_lines.
436 (Fdelete_window, delete_window): Remove. Window deletion is
437 handled by window.el.
438 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
439 Fdelete_window calls with calls to Qdelete_window.
440 (Fdelete_other_windows): Remove. Deleting other windows is
441 handled by window.el.
442 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
443 handled in window.el.
444 (window_min_size_2, window_min_size_1, window_min_size): Remove.
445 Window minimum sizes are handled in window.el.
446 (shrink_windows, size_window, set_window_height)
447 (set_window_width, change_window_heights, window_height)
448 (window_width, CURBEG, CURSIZE, enlarge_window)
449 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
450 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
451 handled in window.el.
452 (make_dummy_parent): Rename to make_parent_window and give it a
453 second argument horflag.
454 (make_window): Don't set resize_proportionally any more.
455 (Fsplit_window): Remove. Windows are split in window.el.
456 (save_restore_action, save_restore_orig_size)
457 (shrink_window_lowest_first, save_restore_orig_size): Remove.
458 Resize mini windows in window.el.
459 (grow_mini_window, shrink_mini_window): Implement by calling
460 Qresize_root_window_vertically, resize_window_check and
461 resize_window_apply.
462 (saved_window, Fset_window_configuration, save_window_save): Do
463 not handle orig_top_line, orig_total_lines, and
464 resize_proportionally.
465 (window_min_height, window_min_width): Move to window.el.
466 (keys_of_window): Move bindings for delete-other-windows,
467 split-window, delete-window and enlarge-window to window.el.
468
469 * buffer.c: Temporarily extern Qdelete_window.
470 (Fbury_buffer): Temporarily call Qdelete_window instead of
471 Fdelete_window (Fbury_buffer will move to window.el soon).
472
473 * frame.c (set_menu_bar_lines_1): Remove code handling
474 orig_top_line and orig_total_lines.
475
476 * dispnew.c (adjust_frame_glyphs_initially): Don't use
477 set_window_height but set heights directly.
478 (change_frame_size_1): Use resize_frame_windows.
479
480 * xdisp.c (init_xdisp): Don't use set_window_height but set
481 heights directly.
482
483 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
484 resize_frame_windows instead of change_window_heights and run
485 run_window_configuration_change_hook.
486
487 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
488 instead of change_window_heights and run
489 run_window_configuration_change_hook.
490
1a13852e
MR
4912011-06-09 Martin Rudalics <rudalics@gmx.at>
492
493 * window.c (replace_window): Rename second argument REPLACEMENT to
494 NEW. New third argument SETFLAG. Rewrite.
495 (delete_window, make_dummy_parent): Call replace_window with
496 third argument 1.
497 (window_list_1): Move down in code.
498 (run_window_configuration_change_hook): Move set_buffer part
499 before select_frame_norecord part in order to unwind correctly.
500 Rename count1 to count.
501 (recombine_windows, delete_deletable_window, resize_root_window)
502 (Fdelete_other_windows_internal)
503 (Frun_window_configuration_change_hook, make_parent_window)
504 (resize_window_check, resize_window_apply, Fresize_window_apply)
505 (resize_frame_windows, Fsplit_window_internal)
506 (Fdelete_window_internal, Fresize_mini_window_internal): New
507 functions.
508 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
509
f3d1777e
MR
5102011-06-08 Martin Rudalics <rudalics@gmx.at>
511
496e208e
MR
512 * window.h (window): Add some new members to window structure -
513 normal_lines, normal_cols, new_total, new_normal, clone_number,
514 splits, nest, prev_buffers, next_buffers.
515 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 516 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 517
f3d1777e
MR
518 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
519 Remove.
496e208e
MR
520 (make_dummy_parent): Set new members of windows structure.
521 (make_window): Move down in code. Handle new members of window
522 structure.
523 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
524 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
525 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
526 (Fset_window_prev_buffers, Fwindow_next_buffers)
527 (Fset_window_next_buffers, Fset_window_clone_number): New
528 functions.
529 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
530 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
531 Doc-string fixes.
532 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
533 Argument WINDOW can be now internal window too.
534 (Fwindow_use_time): Move up in code.
535 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
536 Rewrite doc-string.
537 (Fset_window_configuration, saved_window)
538 (Fcurrent_window_configuration, save_window_save): Handle new
539 members of window structure.
b9e809c2
MR
540 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
541 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
542 (syms_of_window): New Lisp objects Qrecord_window_buffer,
543 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
544 Qget_mru_window, Qresize_root_window,
545 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
546 Qauto_buffer_name; staticpro them.
f3d1777e 547
abde8f8c
MR
5482011-06-07 Martin Rudalics <rudalics@gmx.at>
549
550 * window.c (Fwindow_total_size, Fwindow_left_column)
551 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
552 (Fwindow_list_1): New functions.
553 (window_box_text_cols): Replace with window_body_cols.
554 (Fwindow_width, Fscroll_left, Fscroll_right): Use
555 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
556 (delete_window, Fset_window_configuration): Call
557 delete_all_subwindows with window as argument.
558 (delete_all_subwindows): Take a window as argument and not a
559 structure. Rewrite.
190b47e6
MR
560 (window_loop): Remove handling of GET_LRU_WINDOW and
561 GET_LARGEST_WINDOW.
562 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
563
564 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
565 window_box_text_cols. delete_all_subwindows now takes a
566 Lisp_Object as argument.
abde8f8c
MR
567
568 * indent.c (compute_motion, Fcompute_motion): Use
569 window_body_cols instead of window_box_text_cols.
570
fa8a67e6
MR
571 * frame.c (delete_frame): Call delete_all_subwindows with root
572 window as argument.
573
a54e3482
DC
5742011-06-07 Daniel Colascione <dan.colascione@gmail.com>
575
576 * fns.c (Fputhash): Document return value.
577
60002bf5
CY
5782011-06-06 Chong Yidong <cyd@stupidchicken.com>
579
580 * image.c (gif_load): Implement gif89a spec "no disposal" method.
581
0c671da6 5822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 583
b862a52a 584 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 585
be44ca6c
PE
586 Check for overflow when converting integer to cons and back.
587 * charset.c (Fdefine_charset_internal, Fdecode_char):
588 Use cons_to_unsigned to catch overflow.
589 (Fencode_char): Use INTEGER_TO_CONS.
590 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
591 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
592 * data.c (long_to_cons, cons_to_long): Remove.
593 (cons_to_unsigned, cons_to_signed): New functions.
594 These signal an error for invalid or out-of-range values.
595 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
596 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
597 * font.c (Ffont_variation_glyphs):
598 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
599 * lisp.h: Include <intprops.h>.
600 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
601 (cons_to_signed, cons_to_unsigned): New decls.
602 (long_to_cons, cons_to_long): Remove decls.
603 * undo.c (record_first_change): Use INTEGER_TO_CONS.
604 (Fprimitive_undo): Use CONS_TO_INTEGER.
605 * xfns.c (Fx_window_property): Likewise.
606 * xselect.c: Include <limits.h>.
607 (x_own_selection, selection_data_to_lisp_data):
608 Use INTEGER_TO_CONS.
609 (x_handle_selection_request, x_handle_selection_clear)
610 (x_get_foreign_selection, Fx_disown_selection_internal)
611 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
612 (lisp_data_to_selection_data): Use cons_to_unsigned.
613 (x_fill_property_data): Use cons_to_signed.
614 Report values out of range.
615
d1f3d2af
PE
616 Check for buffer and string overflow more precisely.
617 * buffer.h (BUF_BYTES_MAX): New macro.
618 * lisp.h (STRING_BYTES_MAX): New macro.
619 * alloc.c (Fmake_string):
620 * character.c (string_escape_byte8):
621 * coding.c (coding_alloc_by_realloc):
622 * doprnt.c (doprnt):
623 * editfns.c (Fformat):
624 * eval.c (verror):
625 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
626 since they may not be the same number.
627 * editfns.c (Finsert_char):
628 * fileio.c (Finsert_file_contents):
629 Likewise for BUF_BYTES_MAX.
630
dd52fcea
PE
631 * image.c: Use ptrdiff_t, not int, for sizes.
632 (slurp_file): Switch from int to ptrdiff_t.
633 All uses changed.
634 (slurp_file): Check that file size fits in both size_t (for
635 malloc) and ptrdiff_t (for sanity and safety).
636
7f9bbdbb
PE
637 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
638 if b->modtime has its maximal value.
639
dfe18f82
PE
640 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
641
84acfcf0
PE
642 Don't assume time_t can fit into int.
643 * buffer.h (struct buffer.modtime): Now time_t, not int.
644 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
645 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
646
ccd9a01a
PE
647 Minor fixes for signed vs unsigned integers.
648 * character.h (MAYBE_UNIFY_CHAR):
649 * charset.c (maybe_unify_char):
650 * keyboard.c (read_char, reorder_modifiers):
651 XINT -> XFASTINT, since the integer must be nonnegative.
652 * ftfont.c (ftfont_spec_pattern):
653 * keymap.c (access_keymap, silly_event_symbol_error):
654 XUINT -> XFASTINT, since the integer must be nonnegative.
655 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
656 since it makes no difference and we prefer signed.
657 * keyboard.c (record_char): Use XUINT when all the neighbors do.
658 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
659 nonnegative.
660
d6d100dd
SM
6612011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
662
663 * window.h (Fwindow_frame): Declare.
664
2b6148e4
PE
6652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
666
667 * alloc.c: Simplify handling of large-request failures (Bug#8800).
668 (SPARE_MEMORY): Always define.
669 (LARGE_REQUEST): Remove.
670 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
671
f230ecc9
MR
6722011-06-06 Martin Rudalics <rudalics@gmx.at>
673
727e958e
MR
674 * lisp.h: Move EXFUNS for Fframe_root_window,
675 Fframe_first_window and Fset_frame_selected_window to window.h.
676
677 * window.h: Move EXFUNS for Fframe_root_window,
678 Fframe_first_window and Fset_frame_selected_window here from
679 lisp.h.
680
681 * frame.c (Fwindow_frame, Fframe_first_window)
682 (Fframe_root_window, Fframe_selected_window)
683 (Fset_frame_selected_window): Move to window.c.
684 (Factive_minibuffer_window): Move to minibuf.c.
685 (Fother_visible_frames_p): New function.
686
687 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
688
f230ecc9
MR
689 * window.c (decode_window, decode_any_window): Move up in code.
690 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
691 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
692 (Fwindow_buffer): Move up and rewrite doc-string.
693 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
694 (Fwindow_prev): New functions.
727e958e
MR
695 (Fwindow_frame): Move here from frame.c. Accept any window as
696 argument.
697 (Fframe_root_window, Fframe_first_window)
698 (Fframe_selected_window): Move here from frame.c. Accept frame
699 or arbitrary window as argument. Update doc-strings.
700 (Fminibuffer_window): Move up in code.
701 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
702 (Fset_frame_selected_window): Move here from frame.c.
703 Marginal rewrite.
727e958e
MR
704 (Fselected_window, select_window, Fselect_window): Move up in
705 code. Minor doc-string fixes.
f230ecc9 706
4d09bcf6
PE
7072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
708
709 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
710 Do not assume that spare memory exists; that assumption is valid
711 only if SYSTEM_MALLOC.
712 (LARGE_REQUEST): New macro, so that the issue of large requests
713 is separated from the issue of spare memory.
714
810928a2
AS
7152011-06-05 Andreas Schwab <schwab@linux-m68k.org>
716
172418ad
AS
717 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
718 format. (Bug#8806)
719
43f862f7
AS
720 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
721
810928a2
AS
722 * xfns.c (x_set_scroll_bar_default_width): Move declarations
723 before statements.
724
a059fe24
JD
7252011-06-05 Jan Djärv <jan.h.d@swipnet.se>
726
727 * gtkutil.c (xg_get_default_scrollbar_width): New function.
728
729 * gtkutil.h: Declare xg_get_default_scrollbar_width.
730
731 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
732 min width by calling x_set_scroll_bar_default_width (Bug#8505).
733
989bf368
JB
7342011-06-05 Juanma Barranquero <lekktu@gmail.com>
735
736 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
737
4b80f674
CY
7382011-06-04 Chong Yidong <cyd@stupidchicken.com>
739
740 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
741 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
742 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
743 New error handlers.
4b80f674
CY
744 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
745 Obey Vx_select_enable_clipboard_manager. Catch errors in
746 x_clipboard_manager_save (Bug#8779).
747 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 748 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 749
99a33b77 7502011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
751
752 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
753
99a33b77 7542011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
755
756 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
757 in the current matrix if keep_current_p is non-zero.
758
8264569d
EZ
7592011-06-04 Eli Zaretskii <eliz@gnu.org>
760
761 * bidi.c (bidi_level_of_next_char): Fix last change.
762
57f97249
EZ
7632011-06-03 Eli Zaretskii <eliz@gnu.org>
764
fec2107c 765 Support bidi reordering of text covered by display properties.
57f97249 766
fec2107c
EZ
767 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
768 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
769 (bidi_cache_search, bidi_cache_iterator_state)
770 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
771 (bidi_level_of_next_char, bidi_move_to_visually_next):
772 Support character positions inside a run of characters covered by a
fec2107c
EZ
773 display string.
774 (bidi_paragraph_init, bidi_resolve_explicit_1)
775 (bidi_level_of_next_char): Call bidi_fetch_char and
776 bidi_fetch_char_advance instead of FETCH_CHAR and
777 FETCH_CHAR_ADVANCE.
778 (bidi_init_it): Initialize new members.
779 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
780 definitions.
781 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
782 instead of using explicit *_CHAR codes.
d6d100dd
SM
783 (bidi_resolve_explicit, bidi_resolve_weak):
784 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
785 bidirectional text is supported only in multibyte buffers.
786 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
787 it to initialize the frame_window_p member of struct bidi_it.
788 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
789 (bidi_resolve_explicit, bidi_resolve_weak)
790 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
791 bidi_it->nchars is non-positive.
792 (bidi_level_of_next_char): Don't try to lookup the cache for the
793 next/previous character if nothing is cached there yet, or if we
794 were just reseat()'ed to a new position.
c40e2fb2 795
0e14fe90
EZ
796 * xdisp.c (set_cursor_from_row): Set start and stop points
797 according to the row's direction when priming the loop that looks
798 for the glyph on which to display cursor.
799 (single_display_spec_intangible_p): Function deleted.
800 (display_prop_intangible_p): Reimplement to call
801 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
802 Accept 3 additional arguments needed by handle_display_spec.
803 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
804 values: lists, `(when COND...)' forms, etc.
805 (single_display_spec_string_p): Support property values that are
806 lists with the argument STRING its top-level element.
807 (display_prop_string_p): Fix the condition for processing a
808 property that is a list to be consistent with handle_display_spec.
fec2107c 809 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
810 last portion of handle_display_prop.
811 (compute_display_string_pos): Accept additional argument
812 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
813 value of a `display' property is a "replacing spec".
814 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
815 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
816 the display property, but just return a value indicating whether
817 the display property will replace the characters it covers.
818 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
819 frame_window_p members of struct bidi_it.
d6d100dd
SM
820 (compute_display_string_pos, compute_display_string_end):
821 New functions.
fec2107c
EZ
822 (push_it): Accept second argument POSITION, where pop_it should
823 jump to continue iteration.
824 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 825
fec2107c
EZ
826 * keyboard.c (adjust_point_for_property): Adjust the call to
827 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
828
829 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
830 (bidi_init_it): Update prototypes.
831 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
832 (compute_display_string_pos, compute_display_string_end):
833 Declare prototypes.
fec2107c
EZ
834 (struct bidi_it): New members nchars and disp_pos. ch_len is now
835 EMACS_INT.
fc6f18ce 836
40087514 8372011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 838
57f53182
PE
839 Malloc failure behavior now depends on size of allocation.
840 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
841 * lisp.h: Change signatures accordingly.
842 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
843 All callers changed. (Bug#8762)
844
845 * gnutls.c: Use Emacs's memory allocators.
846 Without this change, the gnutls library would invoke malloc etc.
847 directly, which causes problems on non-SYNC_INPUT hosts, and which
848 runs afoul of improving memory_full behavior. (Bug#8761)
849 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
850 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
851 xfree instead of the default malloc, realloc, free.
852 (Fgnutls_boot): No need to check for memory allocation failure,
853 since xmalloc does that for us.
854
ac32cd99 855 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
856 * category.c (hash_get_category_set):
857 * ccl.c (ccl_driver):
858 * charset.c (Fdefine_charset_internal):
859 * charset.h (struct charset.hash_index):
860 * composite.c (get_composition_id, gstring_lookup_cache)
861 (composition_gstring_put_cache):
862 * composite.h (struct composition.hash_index):
863 * dispextern.h (struct image.hash):
864 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
865 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
866 (hashfn_equal, hashfn_user_defined, make_hash_table)
867 (maybe_resize_hash_table, hash_lookup, hash_put)
868 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
869 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
870 (Fsxhash, Fgethash, Fputhash, Fmaphash):
871 * image.c (make_image, search_image_cache, lookup_image)
872 (xpm_put_color_table_h):
873 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 874 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
875 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
876 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
877 * alloc.c (allocate_vectorlike):
878 Check for overflow in vector size calculations.
879 * ccl.c (ccl_driver):
880 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
881 * fns.c, image.c: Remove unnecessary static decls that would otherwise
882 need to be updated by these changes.
40087514
PE
883 * fns.c (make_hash_table, maybe_resize_hash_table):
884 Check for integer overflow with large hash tables.
0de4bb68
PE
885 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
886 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
887 (SXHASH_REDUCE): New macro.
888 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
889 Use it instead of discarding useful hash info with large hash values.
890 (sxhash_float): New function.
891 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
892 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
893 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
894 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
895 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
896 Adjust signatures to match updated version of code.
897 (consing_since_gc): Now EMACS_INT, since a single hash table can
898 use more than INT_MAX bytes.
899
698d32e2
DN
9002011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
901
902 Make it possible to build with GCC-4.6+ -O2 -flto.
903
904 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
905
fd6fa53f
SM
9062011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
907
908 * minibuf.c (get_minibuffer, read_minibuf_unwind):
909 Call minibuffer-inactive-mode.
910
864db017
JB
9112011-05-31 Juanma Barranquero <lekktu@gmail.com>
912
913 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
914 Update dependencies.
915
2ad0baf4
DN
9162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
917
918 * data.c (init_data): Remove code for UTS, this system is not
919 supported anymore.
920
4fcc2638
DN
9212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
922
923 Don't force ./temacs to start in terminal mode.
924
925 * frame.c (make_initial_frame): Initialize faces in all cases, not
926 only when CANNOT_DUMP is defined.
927 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
928
c56e0fd5
DN
9292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
930
931 * dispnew.c (add_window_display_history): Use const for the string
932 pointer. Remove declaration, not needed.
933
333d54da 9342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 935
55d4c1b2 936 Use 'inline', not 'INLINE'.
333d54da 937 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
938 * alloc.c, fontset.c (INLINE): Remove.
939 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
940 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
941 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
942 * gmalloc.c (register_heapinfo): Use inline unconditionally.
943 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
944
738db178
DN
9452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
946
947 Make it possible to run ./temacs.
948
949 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
950 syms_of_callproc does the same thing. Remove test for
951 "initialized", do it in the caller.
952 * emacs.c (main): Avoid calling set_initial_environment when dumping.
953
620c53a6
SM
9542011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
955
956 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
957 (read_minibuf): Use get_minibuffer.
958 (syms_of_minibuf): Use DEFSYM.
959 (Qmetadata): New var.
960 * data.c (Qbuffer): Don't make it static.
961 (syms_of_data): Use DEFSYM.
962
e003a292
PE
9632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
964
965 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
966 (CCL_CODE_MIN): New macro.
967
ed008a6d
PE
9682011-05-30 Paul Eggert <eggert@cs.ucla.edu>
969
3687c2ef
PE
970 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
971
ed008a6d
PE
972 * eval.c (Qdebug): Now static.
973 * lisp.h (Qdebug): Remove decl. This reverts a part of the
974 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
975 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
976
d66c4c7c
CY
9772011-05-29 Chong Yidong <cyd@stupidchicken.com>
978
979 * image.c: Various fixes to ImageMagick code comments.
980 (Fimagemagick_types): Doc fix.
981
5fbc2025
PE
9822011-05-29 Paul Eggert <eggert@cs.ucla.edu>
983
0196f88a
PE
984 Minor fixes prompted by GCC 4.6.0 warnings.
985
986 * xselect.c (converted_selections, conversion_fail_tag): Now static.
987
5fbc2025
PE
988 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
989 (x_clipboard_manager_save_all): Move extern decl to ...
990 * xterm.h: ... here, so that it can be checked for consistency.
991
1dd3c2d9
CY
9922011-05-29 Chong Yidong <cyd@stupidchicken.com>
993
994 * xselect.c (x_clipboard_manager_save_frame)
995 (x_clipboard_manager_save_all): New functions.
996 (Fx_clipboard_manager_save): Lisp function deleted.
997
998 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
999 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1000
1001 * xterm.h: Update prototype.
1002
5ba6571d
WX
10032011-05-28 William Xu <william.xwl@gmail.com>
1004
1005 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1006 exiting (Bug#8239).
1007
3eaff834
JM
10082011-05-28 Jim Meyering <meyering@redhat.com>
1009
e1900994 1010 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1011 * fns.c (to_uchar): Define.
1012 (crypto_hash_function): Use it to convert some newly-signed
1013 variables to unsigned, to avoid sign-extension bugs. For example,
1014 without this change, (md5 "truc") would evaluate to
1015 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1016 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1017 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1018
0f6990a7
PE
10192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 Integer overflow fixes.
c8a9ca5a 1022
08686060
PE
1023 * dbusbind.c: Serial number integer overflow fixes.
1024 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1025 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1026 to hold a serial number that is too large for a fixnum.
1027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1028 Check for serial numbers out of range. Decode any serial number
59568bf0 1029 that was so large that it became a float. (Bug#8722)
08686060 1030
2d1fc3c7
PE
1031 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1032 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1033 Use XFASTINT rather than XUINT when numbers are nonnegative.
1034 (xd_append_arg, Fdbus_method_return_internal):
1035 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1036 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1037 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1038 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1039 (Bug#8722)
2d1fc3c7 1040
c8a9ca5a
PE
1041 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1042
519e1d69
PE
1043 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1044
30569699
PE
1045 ccl: add integer overflow checks
1046 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1047 (IN_INT_RANGE): New macros.
1048 (ccl_driver): Use them to check for integer overflow when
1049 decoding a CCL program. Many of the new checks are whether XINT (x)
1050 fits in int; it doesn't always, on 64-bit hosts. The new version
1051 doesn't catch all possible integer overflows, but it's an
847044ea 1052 improvement. (Bug#8719)
30569699 1053
c11285dc
PE
1054 * alloc.c (make_event_array): Use XINT, not XUINT.
1055 There's no need for unsigned here.
1056
fdccd48e
PE
1057 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1058 This follows up to the 2011-05-06 change that substituted uintptr_t
1059 for EMACS_INT. This case wasn't caught back then.
1060
37910ab2
PE
1061 Rework Fformat to avoid integer overflow issues.
1062 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1063 now (part of C89). Include <verify.h>.
1064 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1065 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1066 (Fformat): Avoid the prepass trying to compute sizes; it was only
1067 approximate and thus did not catch overflow reliably. Instead, walk
1068 through the format just once, formatting and computing sizes as we go,
1069 checking for integer overflow at every step, and allocating a larger
1070 buffer as needed. Keep track separately whether the format is
1071 multibyte. Keep only the most-recently calculated precision, rather
1072 than them all. Record whether each argument has been converted to
1073 string. Use EMACS_INT, not int, for byte and char and arg counts.
1074 Support field widths and precisions larger than INT_MAX. Avoid
1075 sprintf's undefined behavior with conversion specifications such as %#d
1076 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1077 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1078 formatting out-of-range floating point numbers with int
1079 formats. (Bug#8668)
1080
2e6578fb
PE
1081 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1082
0ae6bdee
PE
1083 * data.c: Avoid integer truncation in expressions involving floats.
1084 * data.c: Include <intprops.h>.
1085 (arith_driver): When there's an integer overflow in an expression
1086 involving floating point, convert the integers to floating point
1087 so that the resulting value does not suffer from catastrophic
1088 integer truncation. For example, on a 64-bit host (* 4
1089 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1090 Do not rely on undefined behavior after integer overflow.
1091
de883a70
PE
1092 merge count_size_as_multibyte, parse_str_to_multibyte
1093 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1094 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1095 Check for integer overflow.
1096 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1097 since it's now a duplicate of the other. This is more of
1098 a character than a buffer op, so better that it's in character.c.
1099 * fns.c, print.c: Adjust to above changes.
1100
2ff916cb
PE
11012011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1102
1103 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1104
f1b54466
PE
11052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1106
fb1ac845
PE
1107 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1108 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1109 (x_clipboard_manager_save): Now static.
1110 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1111
f1b54466
PE
1112 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1113 (crypto_hash_function): Now static.
1114 Fix pointer signedness problems. Avoid unnecessary initializations.
1115
a9f737ee
CY
11162011-05-27 Chong Yidong <cyd@stupidchicken.com>
1117
1118 * termhooks.h (Vselection_alist): Make it terminal-local.
1119
1120 * terminal.c (create_terminal): Initialize it.
1121
1122 * xselect.c: Support for clipboard managers.
1123 (Vselection_alist): Move to termhooks.h as terminal-local var.
1124 (LOCAL_SELECTION): New macro.
1125 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1126 (symbol_to_x_atom): Remove gratuitous arg.
1127 (x_handle_selection_request, lisp_data_to_selection_data)
1128 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1129 (x_own_selection, x_get_local_selection, x_convert_selection):
1130 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1131 (some_frame_on_display): Delete unused function.
1132 (Fx_own_selection_internal, Fx_get_selection_internal)
1133 (Fx_disown_selection_internal, Fx_selection_owner_p)
1134 (Fx_selection_exists_p): New optional frame arg.
1135 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1136 (x_handle_selection_clear): Don't treat other terminals with the
1137 same keyboard specially. Use the terminal-local Vselection_alist.
1138 (x_clear_frame_selections): Use Frun_hook_with_args.
1139
1140 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1141
1142 * xterm.h: Add support for those atoms.
1143
e067f0c1
CY
11442011-05-26 Chong Yidong <cyd@stupidchicken.com>
1145
1146 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1147 (converted_selections, conversion_fail_tag): New global variables.
1148 (x_selection_request_lisp_error): Free the above.
1149 (x_get_local_selection): Remove unnecessary code.
1150 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1151 of converted selections stored in converted_selections.
1152 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1153 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1154 (x_convert_selection): New function.
1155 (x_handle_selection_event): Simplify.
1156 (x_get_foreign_selection): Don't ignore incoming requests while
1157 waiting for an answer; this will fail when we implement
1158 SAVE_TARGETS, and seems unnecessary anyway.
1159 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1160 (Vx_sent_selection_functions): Doc fix.
1161
0f4aebc0
LL
11622011-05-26 Leo Liu <sdl.web@gmail.com>
1163
1164 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1165
e61124cd
YM
11662011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1167
1168 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1169
1170 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1171 for fringe update if it has periodic bitmap.
1172 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1173 and fringe_bitmap_periodic_p.
1174
1175 * fringe.c (get_fringe_bitmap_data): New function.
1176 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1177 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1178 row. Mark glyph row for fringe update if periodicity changed.
1179
1180 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1181 for fringe update unless it has periodic bitmap.
1182
f16d9837
KH
11832011-05-25 Kenichi Handa <handa@m17n.org>
1184
1185 * xdisp.c (get_next_display_element): Set correct it->face_id for
1186 a static composition.
1187
e1b90ef6
LL
11882011-05-24 Leo Liu <sdl.web@gmail.com>
1189
1190 * deps.mk (fns.o):
1191 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1192
1193 * fns.c (crypto_hash_function, Fsha1): New function.
1194 (Fmd5): Use crypto_hash_function.
1195 (syms_of_fns): Add Ssha1.
1196
7400048f
PE
11972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * gnutls.c: Remove unused macros.
1200 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1201 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1202 Remove macros that are defined and never used.
1203 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1204
abb71cf4
CY
12052011-05-22 Chong Yidong <cyd@stupidchicken.com>
1206
1207 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1208 (Fx_get_selection_internal): Minor cleanup.
1209 (Fx_own_selection_internal): Rename arguments for consistency with
1210 select.el.
1211
6307db39
PE
12122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1213
1214 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1215
f3d4e0a4
CY
12162011-05-22 Chong Yidong <cyd@stupidchicken.com>
1217
1218 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1219
4d8ade89
YM
12202011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1221
1222 * dispnew.c (scrolling_window): Don't exclude the case that the
1223 last enabled row in the desired matrix touches the bottom boundary.
1224
32078c8d
GM
12252011-05-21 Glenn Morris <rgm@gnu.org>
1226
1227 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1228 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1229 and add some more files.
32078c8d 1230
7285dc67
EZ
12312011-05-20 Eli Zaretskii <eliz@gnu.org>
1232
1233 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1234 report_file_error introduced by the change from 2011-05-07.
1235
89d1bd22
PE
12362011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * systime.h (Time): Define only if emacs is defined.
1239 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1240 where the include path doesn't have X11/X.h by default. See
1241 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1242
e23640bb 12432011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1244
1245 * composite.c (find_automatic_composition): Fix previous change.
1246
b9704ad9
GM
12472011-05-20 Glenn Morris <rgm@gnu.org>
1248
1249 * lisp.mk: New file, split from Makefile.in.
1250 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1251 (shortlisp): Remove.
1252 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1253
4a720484
GM
12542011-05-19 Glenn Morris <rgm@gnu.org>
1255
1256 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1257 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1258 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1259 (lisp): Set the order to that of loadup.el.
1260 (shortlisp): Make it a copy of $lisp.
1261 (SOME_MACHINE_LISP): Remove.
1262 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1263 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1264
a28d4396
KH
12652011-05-18 Kenichi Handa <handa@m17n.org>
1266
1267 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1268 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1269 (find_automatic_composition): Mostly rewrite for efficiency.
1270
a2b1fa8e
JB
12712011-05-18 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * makefile.w32-in: Update dependencies.
1274
8e1f5610
CS
12752011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1276
1277 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1278 revision 104625).
1279
7025ee00 12802011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1281
cdfa6eab
PE
1282 Fix some integer overflow issues, such as string length overflow.
1283
06d6db33
PE
1284 * insdel.c (count_size_as_multibyte): Check for string overflow.
1285
2b4560a8
PE
1286 * character.c (lisp_string_width): Check for string overflow.
1287 Use EMACS_INT, not int, for string indexes and lengths; in
1288 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1289 the resulting string length overflows an EMACS_INT; instead,
1290 report a string overflow if no precision given. When checking for
1291 precision exhaustion, use a check that cannot possibly have
1292 integer overflow. (Bug#8675)
1293 * character.h (lisp_string_width): Adjust to new signature.
1294
cb93f9be
PE
1295 * alloc.c (string_overflow): New function.
1296 (Fmake_string): Use it. This doesn't change behavior, but saves
1297 a few bytes and will simplify future changes.
1298 * character.c (string_escape_byte8): Likewise.
1299 * lisp.h (string_overflow): New decl.
1300
1a1f3366
PE
1301 Fixups, following up to the user-interface timestamp change.
1302 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1303 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1304 * msdos.c (mouse_get_pos): Likewise.
1305 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1306 * w32gui.h (Time): Define by including "systime.h" rather than by
1307 declaring it ourselves. (Bug#8664)
1308
d4e3e4d3
PE
1309 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1310 * image.c (clear_image_cache): Likewise.
1311
f6a24d19
PE
1312 * term.c (term_mouse_position): Don't assume time_t wraparound.
1313
08dc5ae6
PE
1314 Be more systematic about user-interface timestamps.
1315 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1316 and sometimes 'EMACS_UINT', to represent these timestamps.
1317 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1318 This makes the code easier to follow, and makes it easier to catch
1319 integer overflow bugs such as Bug#8664.
1320 * frame.c (Fmouse_position, Fmouse_pixel_position):
1321 Use Time, not unsigned long, for user-interface timestamps.
1322 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1323 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1324 * keyboard.h (last_event_timestamp): Likewise.
1325 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1326 * menu.h (xmenu_show): Likewise.
1327 * term.c (term_mouse_position): Likewise.
1328 * termhooks.h (struct input_event.timestamp): Likewise.
1329 (struct terminal.mouse_position_hook): Likewise.
1330 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1331 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1332 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1333 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1334 what it was before.
1335 * menu.h, termhooks.h: Include "systime.h", for Time.
1336
8e55734a
PE
1337 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1338 Don't assume that the difference between two unsigned long values
1339 can fit into an integer. At this point, we know button_down_time
1340 <= event->timestamp, so the difference must be nonnegative, so
1341 there's no need to cast the result if double-click-time is
1342 nonnegative, as it should be; check that it's nonnegative, just in
1343 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1344 apart (about 25 days). (Bug#8664)
8e55734a 1345
841f1b75 1346 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1347 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1348
3e26f69c
PE
1349 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1350 that always fit in int. Use a sentinel instead of a counter, to
1351 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1352 * frame.h (struct frame): Use int for menu_bar_items_used
1353 instead of EMACS_INT, since it always fits in int.
3e26f69c 1354
5cc152c0
PE
1355 * menu.c (grow_menu_items): Check for int overflow.
1356
d89eb65e
PE
1357 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1358
5235bd3e
PE
1359 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1360 Before, the code was not consistent. These values cannot exceed
1361 2**31 - 1 so there's no need to make them unsigned.
1362 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1363 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1364 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1365 as modifiers.
1366 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1367
bc827e23
PE
1368 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1369 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1370 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1371 presumably because the widths might not match.
1372
78eb494e
PE
1373 * window.c (size_window): Avoid needless test at loop start.
1374
04f2d78b
CB
13752011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1376
1377 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1378
d2fc7e3d 13792011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1380
1381 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1382
d2fc7e3d 13832011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1384
1385 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1386 `width' to `bar_area_x' and `bar_area_width', respectively.
1387 (x_scroll_run): Take account of fringe background extension.
1388
04f2d78b
CB
1389 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1390 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1391 `bar_area_width', respectively.
1392 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1393 background extension.
1394
79b70037
GM
13952011-05-10 Jim Meyering <meyering@redhat.com>
1396
1397 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1398
2f142cc5
JB
13992011-05-10 Juanma Barranquero <lekktu@gmail.com>
1400
1401 * image.c (Finit_image_library): Return t for built-in image types,
1402 like pbm and xbm. (Bug#8640)
1403
57679c86
AS
14042011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1405
1406 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1407
888c9e86
EZ
14082011-05-07 Eli Zaretskii <eliz@gnu.org>
1409
b0512a1d
EZ
1410 * w32console.c (Fset_screen_color): Doc fix.
1411 (Fget_screen_color): New function.
1412 (syms_of_ntterm): Defsubr it.
1413
7285dc67
EZ
1414 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1415 unlink the temporary file if Fcall_process didn't create it in the
1416 first place.
1417 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1418 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1419 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1420 cue to call_process_cleanup not to close that handle.
1421
4d3fcc8e
BK
14222011-05-07 Ben Key <bkey76@gmail.com>
1423
1424 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1425 one of two shell specific rules, either bootstrap-temacs-CMD or
1426 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1427 to the previous implementation of the bootstrap-temacs rule.
1428 The bootstrap-temacs-CMD rule is similar to the previous
1429 implementation of the bootstrap-temacs rule except that it
1430 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1431 variable.
1432
1433 These changes, along with some changes to nt/configure.bat,
1434 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1435 earlier fix to add support for --cflags and --ldflags options
1436 that include quotes so that it works whether make uses cmd or
1437 sh as the shell.
1438
b4289b64
MA
14392011-05-06 Michael Albinus <michael.albinus@gmx.de>
1440
1441 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1442 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1443 is a constant.
1444 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1445 a string. Handle both cases.
1446 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1447 (Fdbus_register_method): Use Qinvalid_function.
1448
af4c0e28
JB
14492011-05-06 Juanma Barranquero <lekktu@gmail.com>
1450
1451 * makefile.w32-in: Update dependencies.
1452 (LISP_H): Add inttypes.h and stdin.h.
1453 (PROCESS_H): Add unistd.h.
1454
c51453d9
EZ
14552011-05-06 Eli Zaretskii <eliz@gnu.org>
1456
1457 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1458 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1459
8ff0ac3c 14602011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1461
4c4b566b
PE
1462 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1463
aab2b9b5
PE
1464 * term.c (vfatal): Remove stray call to va_end.
1465 It's not needed and the C Standard doesn't allow it here anyway.
1466
c378da0b
PE
1467 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1468 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1469
288b08c7
PE
1470 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1471 bytes.
1472
e3601888
PE
1473 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1474
db6c0e74
PE
1475 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1476
dd5963ea
PE
1477 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1478
88c9450f
PE
1479 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1480
2f9442b8
PE
1481 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1482
c032b5f8
PE
1483 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1484 * charset.c (Fdefine_charset_internal): Don't initialize
1485 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1486 32-bit int (Bug#8600).
a108c10b
PE
1487
1488 * lread.c (read_integer): Be more consistent with string-to-number.
1489 Use string_to_number to do the actual conversion; this avoids
1490 rounding errors and fixes some other screwups. Without this fix,
1491 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1492 (digit_to_number): Move earlier, for benefit of read_integer.
1493 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1494 not a digit in any supported base. (Bug#8602)
a108c10b 1495
ad5f9eea
PE
1496 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1497
aec1708a
PE
1498 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1499 to match comment at start of function. This also removes a
1500 GCC warning about overflow in a 32+64-bit port.
1501
47be4ab5
PE
1502 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1503
371cac43
PE
1504 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1505 Reported by Stefan Monnier in
1506 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1507 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1508 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1509
d01a7826
PE
1510 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1511 (EMACS_UINTPTR): Likewise, with uintptr_t.
1512
7fd47d5c
PE
1513 * lisp.h: Prefer 64-bit EMACS_INT if available.
1514 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1515 on 32-bit hosts that have 64-bit int, so that they can access
1516 large files.
122b0c86
PE
1517 However, temporarily disable this change unless the temporary
1518 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1519
8727937b
PE
1520 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1521
8ac068ac
PE
1522 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1523 This removes an assumption that EMACS_INT and long are the same
1524 width as pointers. The assumption is true for Emacs porting targets
1525 now, but we want to make other targets possible.
1526 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1527 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1528 In the rest of the code, change types of integers that hold casted
1529 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1530 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1531 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1532 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1533 No need to cast type when ORing.
1534 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1535 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1536 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1537 assume EMACS_INT is the same width as char *.
1538 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1539 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1540 Remove no-longer-needed casts.
1541 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1542 (xg_tool_bar_help_callback, xg_make_tool_item):
1543 Use EMACS_INTPTR to hold an integer
1544 that will be cast to void *; this can avoid a GCC warning
1545 if EMACS_INT is not the same width as void *.
1546 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1547 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1548 (current_message_1, set_message_1):
1549 Use a local to convert to proper width without a cast.
1550 * xmenu.c (dialog_selection_callback): Likewise.
1551
ede49d71
PE
1552 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1553 Also, don't assume VALBITS / RAND_BITS is less than 5,
1554 and don't rely on undefined behavior when shifting a 1 left into
1555 the sign bit.
1556 * lisp.h (get_random): Change signature to match.
1557
2f30ecd0
PE
1558 * lread.c (hash_string): Use size_t, not int, for hash computation.
1559 Normally we prefer signed values; but hashing is special, because
1560 it's better to use unsigned division on hash table sizes so that
1561 the remainder is nonnegative. Also, size_t is the natural width
1562 for hashing into memory. The previous code used 'int', which doesn't
1563 retain enough info to hash well into very large tables.
1564 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1565
2a866e7b
PE
1566 * dbusbind.c: Don't possibly lose pointer info when converting.
1567 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1568 Use XPNTR rather than XHASH, so that the high-order bits of
1569 the pointer aren't lost when converting through void *.
1570
51639eac
PE
1571 * eval.c (Fautoload): Don't double-shift a pointer.
1572
92394119
PE
1573 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1574
dbdb9a7c
JB
15752011-05-06 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * gnutls.c (DEF_GNUTLS_FN):
1578 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1579
db7a0b4f
AS
15802011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1581
1582 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1583 marker. (Bug#8610)
1584
f7ff1b0f 15852011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1586
1587 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1588 New version that can reserve upto 2GB of heap space.
1589
f7ff1b0f 15902011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1591
1592 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1593
639c109b
TZ
15942011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1595
1596 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1597 `gnutls_certificate_set_x509_key_file'.
1598
d2127135
JB
15992011-05-05 Juanma Barranquero <lekktu@gmail.com>
1600
1601 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1602 Update dependencies.
1603
e968f4f3
JB
16042011-05-04 Juanma Barranquero <lekktu@gmail.com>
1605
1606 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1607 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1608 Remove unused parameter `fildes'.
1609 * process.c (read_process_output, send_process): Don't pass it.
1610
84d358f0
JB
16112011-05-04 Juanma Barranquero <lekktu@gmail.com>
1612
1613 Fix previous change: the library cache is defined in w32.c.
1614 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1615 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1616
0898ca10
JB
16172011-05-04 Juanma Barranquero <lekktu@gmail.com>
1618
1619 Implement dynamic loading of GnuTLS on Windows.
1620
1621 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1622 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1623 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1624 Declare.
1625
1626 * gnutls.c (Qgnutls_dll): Define.
1627 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1628 (gnutls_*): Declare function pointers.
1629 (init_gnutls_functions): New function to initialize function pointers.
1630 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1631 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1632 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1633 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1634 (emacs_gnutls_write, emacs_gnutls_read)
1635 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1636 (Fgnutls_available_p): New function.
1637 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1638 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1639 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1640
1641 * image.c: Include w32.h.
1642 (Vimage_type_cache): Delete.
1643 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1644 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1645 (w32_delayed_load): Move to w32.c.
1646
1647 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1648
1649 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1650 (w32_delayed_load): Move from image.c. When loading a library, record
1651 its filename in the :loaded-from property of the library id.
1652 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1653 Initialize and staticpro them.
1654 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1655
1656 * process.c: Include lisp.h before w32.h, not after.
1657 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1658 instead of gnutls_record_check_pending.
1659
1660 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1661
ff4de4aa
TZ
16622011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1663
1664 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1665 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1666 as passed in.
1667
abe95abb
JD
16682011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1669
1670 * xterm.c (x_set_frame_alpha): Do not set property on anything
1671 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1672
e16e55d4
JB
16732011-05-02 Juanma Barranquero <lekktu@gmail.com>
1674
1675 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1676
bafcf6a5
JB
16772011-05-02 Juanma Barranquero <lekktu@gmail.com>
1678
1679 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1680 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1681 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1682 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1683 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1684 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1685 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1686 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1687 (Qgnutls_bootprop_callbacks_verify): Make static.
1688
e7a6747f
AS
16892011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1690
19ed11ba
AS
1691 * callproc.c: Indentation fixup.
1692
e7a6747f 1693 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1694 (wait_for_termination, interruptible_wait_for_termination):
1695 Move after wait_for_termination_1.
e7a6747f 1696
1ef14cb4
LMI
16972011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1698
1699 * sysdep.c (interruptible_wait_for_termination): New function
1700 which is like wait_for_termination, but allows keyboard
1701 interruptions.
1702
1703 * callproc.c (Fcall_process): Add (:file "file") as an option for
1704 the STDOUT buffer.
1705 (Fcall_process_region): Ditto.
1706
330d880c
EZ
17072011-04-30 Eli Zaretskii <eliz@gnu.org>
1708
8db90b73
EZ
1709 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1710 rather than `XVECTOR (FOO)->size'.
1711
330d880c
EZ
1712 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1713 inttypes.h, as a gnulib replacement is used if it not available in
1714 system headers.
1715
15cbd324
EZ
17162011-04-21 Eli Zaretskii <eliz@gnu.org>
1717
1718 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1719 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1720 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1721
1722 * coding.c (coding_alloc_by_realloc): Error out if destination
1723 will grow beyond MOST_POSITIVE_FIXNUM.
1724 (decode_coding_emacs_mule): Abort if there isn't enough place in
1725 charbuf for the composition carryover bytes. Reserve an extra
1726 space for up to 2 characters produced in a loop.
1727 (decode_coding_iso_2022): Abort if there isn't enough place in
1728 charbuf for the composition carryover bytes.
1729
17302011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1731
ae940cca
EZ
1732 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1733 aborting when %lld or %lll format is passed.
1734 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1735 %llo or %llx format is passed. (Bug#8545)
1736
03ab8921
EZ
1737 * window.c (window_scroll_line_based): Use a marker instead of
1738 simple variables to record original value of point. (Bug#7952)
1739
afda1437
EZ
1740 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1741 produced by %s or %c overflows available buffer space. (Bug#8545)
1742
f76dee0c
PE
17432011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1746 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1747
fdc5744d
JB
17482011-04-28 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1751
638f053a
JB
17522011-04-28 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * keyboard.c (Qdelayed_warnings_hook): Define.
1755 (command_loop_1): Run `delayed-warnings-hook'
1756 if Vdelayed_warnings_list is non-nil.
1757 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1758 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1759
d178f871
EZ
17602011-04-28 Eli Zaretskii <eliz@gnu.org>
1761
1762 * doprnt.c (doprnt): Don't return value smaller than the buffer
1763 size if the message was truncated. (Bug#8545).
1764
b124fd93
JB
17652011-04-28 Juanma Barranquero <lekktu@gmail.com>
1766
1767 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1768 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1769
e810457d
PE
17702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1773
ea51cceb
JB
17742011-04-27 Juanma Barranquero <lekktu@gmail.com>
1775
1776 * makefile.w32-in: Update dependencies.
1777
94dcfacf
EZ
17782011-04-27 Eli Zaretskii <eliz@gnu.org>
1779
1780 Improve `doprnt' and its usage. (Bug#8545)
1781 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1782 `format_end'. Remove support for %l as a conversion specifier.
1783 Don't use xrealloc. Improve diagnostics when the %l size modifier
1784 is used. Update the commentary.
1785
1786 * eval.c (verror): Simplify calculation of size_t.
1787
1788 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1789 messages.
1790
f61f41d7
PE
17912011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1792
1793 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1794 change.
1795
96fb4434
PE
17962011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1799 This makes this file independent of the recent pseudovector change.
1800
671875da 18012011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1802
69e9b5a3
PE
1803 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1804
b5f869a7 1805 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1806 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1807 Remove unused local.
c8926152 1808 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1809
841a1577 1810 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1811 GCC 4.6.0 optimizes based on type-based alias analysis.
1812 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1813 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1814 != &v->size, and therefore "v->size = 1; b->size = 2; return
1815 v->size;" must therefore return 1. This assumption is incorrect
1816 for Emacs, since it type-puns struct Lisp_Vector * with many other
1817 types. To fix this problem, this patch adds a new type struct
f904488f 1818 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1819 and pseudovectors, and helps optimizing compilers not get fooled
1820 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1821 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1822 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1823 the size member.
eab3844f
PE
1824 (XSETPVECTYPE): Rewrite in terms of new macro.
1825 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1826 This is a bit clearer, and further avoids the possibility of
1827 undesirable aliasing.
1828 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1829 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1830 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1831 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1832 (ASIZE): Now uses header.size rather than size.
1833 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1834 to avoid the hassle of writing XVECTOR (foo)->header.size.
1835 (struct vectorlike_header): New type.
eab3844f
PE
1836 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1837 object, to help avoid aliasing.
1838 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1839 (SUBRP): Likewise, since Lisp_Subr is a special case.
1840 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1841 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1842 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1843 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1844 changed to be "header.size" and "header.next".
1845 * buffer.h (struct buffer): Likewise.
1846 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1847 * frame.h (struct frame): Likewise.
1848 * process.h (struct Lisp_Process): Likewise.
1849 * termhooks.h (struct terminal): Likewise.
1850 * window.c (struct save_window_data, struct saved_window): Likewise.
1851 * window.h (struct window): Likewise.
1852 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1853 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1854 * buffer.c (init_buffer_once): Likewise.
1855 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1856 special case.
1857 * process.c (Fformat_network_address): Use local var for size,
1858 for brevity.
1859
0df1eac5
PE
1860 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1861
847ab9d1 1862 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1863 * data.c (atof): Remove decl; no longer used or needed.
1864 (digit_to_number): Move to lread.c.
1865 (Fstring_to_number): Use new string_to_number function, to be
1866 consistent with how the Lisp reader treats infinities and NaNs.
1867 Do not assume that floating-point numbers represent EMACS_INT
1868 without losing information; this is not true on most 64-bit hosts.
1869 Avoid double-rounding errors, by insisting on integers when
1870 parsing non-base-10 numbers, as the documentation specifies.
1871 * lisp.h (string_to_number): New decl, replacing ...
1872 (isfloat_string): Remove.
bc0a5c13 1873 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1874 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1875 appears to have been a coding error. Similarly, do not accept
1876 strings like +-1e0 as floating point numbers. Do not report
1877 overflow for integer overflows unless the base is not 10 which
1878 means we have no simple and reliable way to continue.
1879 Break out the floating-point parsing into a new
1880 function string_to_number, so that Fstring_to_number parses
1881 floating point numbers consistently with the Lisp reader.
04f2d78b 1882 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1883 (E_CHAR, EXP_INT): Remove, replacing with ...
1884 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1885 (string_to_number): New function, replacing isfloat_string.
1886 This function checks for valid syntax and produces the resulting
1887 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1888 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1889 so that overflow for non-base-10 numbers is reported only when
1890 there's no portable and simple way to convert to floating point.
452f4150 1891
67769ffc
PE
1892 * textprop.c (set_text_properties_1): Rewrite for clarity,
1893 and to avoid GCC warning about integer overflow.
1894
c20db43f
PE
1895 * intervals.h (struct interval): Use EMACS_INT for members
1896 where EMACS_UINT might cause problems. See
1897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1898 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1899 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1900 All uses changed.
37aa2f85
PE
1901 (offset_intervals): Tell GCC not to worry about length overflow
1902 when negating a negative length.
c20db43f 1903
2538aa2f
PE
1904 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1905 (overrun_check_free): Likewise.
1906
f2d3008d
PE
1907 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1908 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1909 word size.
1910
ec8df744
PE
1911 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1912 (gnutls_make_error): Rename local to avoid shadowing.
1913 (gnutls_emacs_global_deinit): ifdef out; not used.
1914 (Fgnutls_boot): Use const for pointer to readonly storage.
1915 Comment out unused local. Fix pointer signedness problems.
1916
640ee02d
PE
1917 * lread.c (openp): Don't stuff size_t into an 'int'.
1918 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1919 about possible signed overflow.
1920
6048fb2a
PE
1921 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1922 (GDK_KEY_g): Don't define if already defined.
1923 (xg_prepare_tooltip): Avoid pointer signedness problem.
1924 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1925
fa3c87e1
PE
1926 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1927 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1928
2172544b
PE
1929 * xfns.c (Fx_window_property): Simplify a bit,
1930 to make a bit faster and to avoid GCC 4.6.0 warning.
1931 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1932
9b821a21
PE
1933 * fns.c (internal_equal): Don't assume size_t fits in int.
1934
3c616cfa
PE
1935 * alloc.c (compact_small_strings): Tighten assertion a little.
1936
c2982e87
PE
1937 Replace pEd with more-general pI, and fix some printf arg casts.
1938 * lisp.h (pI): New macro, generalizing old pEd macro to other
1939 conversion specifiers. For example, use "...%"pI"d..." rather
1940 than "...%"pEd"...".
1941 (pEd): Remove. All uses replaced with similar uses of pI.
1942 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1943 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1944 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1945 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1946 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1947 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1948 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1949 64-bit hosts.
1950 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1951 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1952 * print.c (safe_debug_print, print_object): Likewise.
1953 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1954 to int.
6f04d126
PE
1955 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1956 avoiding the 0 flag, which is not portable.
c2982e87
PE
1957 * process.c (Fmake_network_process): Use pI to avoid cast.
1958 * region-cache.c (pp_cache): Likewise.
1959 * xdisp.c (decode_mode_spec): Likewise.
1960 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1961 behavior on 64-bit hosts with printf arg.
6f04d126 1962 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1963 (x_stop_queuing_selection_requests): Likewise.
1964 (x_get_window_property): Don't truncate byte count to an 'int'
1965 when tracing.
0b432f21 1966
5e073ec7
PE
1967 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1968 here, since it parses constructs like leading '-' and spaces,
1969 which are not wanted; and it overflows with large numbers.
1970 Instead, simply match F[0-9]+, which is what is wanted anyway.
1971
36372bf9
PE
1972 * alloc.c: Remove unportable assumptions about struct layout.
1973 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1974 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1975 (allocate_vectorlike, make_pure_vector): Use the new macros,
1976 plus offsetof, to remove unportable assumptions about struct layout.
1977 These assumptions hold on all porting targets that I know of, but
1978 they are not guaranteed, they're easy to remove, and removing them
1979 makes further changes easier.
1980
0b432f21
PE
1981 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1982 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1983 (string_overrun_cookie): Now const. Use initializers that
1984 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1985 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1986 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1987 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1988 multiple of sizeof (EMACS_INT); it need not be, if
1989 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1990 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1991
895009e1
JB
19922011-04-26 Juanma Barranquero <lekktu@gmail.com>
1993
1994 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1995
6a7a1b0b
TZ
19962011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1997
1998 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1999 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2000 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2001
841a1577 20022011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2003
2004 * lisp.h (Qdebug): List symbol.
895009e1 2005 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2006 * keyboard.c (debug-on-event): New variable.
2007 (handle_user_signal): Break into debugger when debug-on-event
2008 matches the current signal symbol.
2009
f2d3ba6f
DN
20102011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2011
2012 * alloc.c (check_sblock, check_string_bytes)
2013 (check_string_free_list): Convert to standard C.
2014
42ce4c63
TZ
20152011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2016
2017 * w32.c (emacs_gnutls_push): Fix typo.
2018
825cd63c
EZ
20192011-04-25 Eli Zaretskii <eliz@gnu.org>
2020
fb11d64d
EZ
2021 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2022 "cast to pointer from integer of different size".
2023
825cd63c
EZ
2024 Improve doprnt and its use in verror. (Bug#8545)
2025 * doprnt.c (doprnt): Document the set of format control sequences
2026 supported by the function. Use SAFE_ALLOCA instead of always
2027 using `alloca'.
2028
2029 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2030 is one byte too soon. Don't use xrealloc; instead xfree and
2031 xmalloc anew.
2032
e061a11b
TZ
20332011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2034
2035 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2036 callbacks stage.
2037
2038 * gnutls.c: Renamed global_initialized to
2039 gnutls_global_initialized. Added internals for the
2040 :verify-hostname-error, :verify-error, and :verify-flags
2041 parameters of `gnutls-boot' and documented those parameters in the
2042 docstring. Start callback support.
2043 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2044 unless a fatal error occured. Call gnutls_alert_send_appropriate
2045 on error. Return error code.
2046 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2047 (emacs_gnutls_read): Likewise.
2048 (Fgnutls_boot): Return handshake error code.
2049 (emacs_gnutls_handle_error): New function.
2050 (wsaerror_to_errno): Likewise.
2051
2052 * w32.h (emacs_gnutls_pull): Add prototype.
2053 (emacs_gnutls_push): Likewise.
2054
2055 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2056 (emacs_gnutls_push): Likewise.
2057
20582011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2059
2060 * process.c (wait_reading_process_output): Check if GnuTLS
2061 buffered some data internally if no FDs are set for TLS
2062 connections.
2063
2064 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2065 (LIBS): Link to USER_LIBS.
2066 ($(BLD)/gnutls.$(0)): New target.
2067
fa6996bc
EZ
20682011-04-24 Eli Zaretskii <eliz@gnu.org>
2069
eb35682e
EZ
2070 * xdisp.c (handle_single_display_spec): Rename the
2071 display_replaced_before_p argument into display_replaced_p, to
2072 make it consistent with the commentary. Fix typos in the
2073 commentary.
2074
e2ad650c
EZ
2075 * textprop.c (syms_of_textprop): Remove dead code.
2076 (copy_text_properties): Delete obsolete commentary about an
2077 interface that was deleted long ago. Fix typos in the description
2078 of arguments.
2079
1b2de274
EZ
2080 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2081 to changes in oldXMenu/XMenu.h from 2011-04-16.
2082 <menu_help_message, prev_menu_help_message>: Constify.
2083 (IT_menu_make_room): menu->help_text is now `const char **';
2084 adjust.
2085
2086 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2087 to changes in oldXMenu/XMenu.h from 2011-04-16.
2088 (struct XMenu): Declare `help_text' `const char **'.
2089
2090 * xfaces.c <Qunspecified>: Make extern again.
2091
2092 * syntax.c: Include sys/types.h before including regex.h, as
2093 required by Posix.
2094
762b15be
EZ
2095 * doc.c (get_doc_string): Improve the format passed to `error'.
2096
2097 * doprnt.c (doprnt): Improve commentary.
2098
2099 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2100
2101 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2102 them with etags.
2103
f1052e5d
EZ
2104 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2105 changes in globals.h immediately force recompilation.
762b15be
EZ
2106 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2107 $(CURDIR)/s/ms-w32.h.
2108 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2109
fa6996bc
EZ
2110 * character.c (Fchar_direction): Function deleted.
2111 (syms_of_character): Don't defsubr it.
2112 <char-direction-table>: Deleted.
2113
e6c3da20
EZ
21142011-04-23 Eli Zaretskii <eliz@gnu.org>
2115
2116 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2117 * doprnt.c: Include limits.h.
2118 (SIZE_MAX): New macro.
04f2d78b
CB
2119 (doprnt): Return a size_t value. 2nd arg is now size_t.
2120 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2121 Improve overflow protection. Support `l' modifier for integer
2122 conversions. Support %l conversion. Don't assume an EMACS_INT
2123 argument for integer conversions and for %c.
2124
2125 * lisp.h (doprnt): Restore prototype.
2126
2127 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2128 $(SRC)/character.h.
2129
2130 * Makefile.in (base_obj): Add back doprnt.o.
2131
2132 * deps.mk (doprnt.o): Add back prerequisites.
2133 (callint.o): Depend on character.h.
2134
2135 * eval.c (internal_lisp_condition_case): Include the handler
2136 representation in the error message.
2137 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2138 when breaking from the loop.
2139
2140 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2141
2142 * callint.c (Fcall_interactively): When displaying error message
2143 about invalid control letter, pass the character's codepoint, not
2144 a pointer to its multibyte form. Improve display of the character
2145 in octal and display also its hex code.
2146
2147 * character.c (char_string): Use %x to display the (unsigned)
2148 codepoint of an invalid character, to avoid displaying a bogus
2149 negative value.
2150
2151 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2152 `error', not SYMBOL_NAME itself.
2153
2154 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2155 character arguments to `error'.
2156
2157 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2158 to `error' in error message about FINAL_CHAR argument. Make sure
2159 FINAL_CHAR is a character, and use %c when it is passed as
2160 argument to `error'.
2161
4ffd0d6b 21622011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2163
2164 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2165
2166 * w32.c: Include <time.h>.
2167 (sys_localtime): New function.
2168
4ffd0d6b 21692011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2170
2171 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2172
4ffd0d6b 2173 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2174
4ffd0d6b 21752011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2176
4ffd0d6b
GM
2177 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2178 zombies (Bug#8467).
aac0c6e3 2179
04c56954
EZ
21802011-04-19 Eli Zaretskii <eliz@gnu.org>
2181
2182 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2183 gl_state.e_property when gl_state.object is Qt.
2184
2185 * insdel.c (make_gap_larger): Remove limitation of buffer size
2186 to <= INT_MAX.
2187
16a43933
CY
21882011-04-18 Chong Yidong <cyd@stupidchicken.com>
2189
2190 * xdisp.c (lookup_glyphless_char_display)
2191 (produce_glyphless_glyph): Handle cons cell entry in
2192 glyphless-char-display.
2193 (Vglyphless_char_display): Document it.
2194
2195 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2196 glyphless-char-display.
2197
4581706e
CY
21982011-04-17 Chong Yidong <cyd@stupidchicken.com>
2199
2200 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2201
2202 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2203
2204 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2205 definition for no-X builds.
2206
4887c6e2 22072011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2208
fd35b6f9
PE
2209 Static checks with GCC 4.6.0 and non-default toolkits.
2210
5c1ccb01
PE
2211 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2212
006c5daa
PE
2213 * process.c (keyboard_bit_set): Define only if SIGIO.
2214 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2215 (send_process): Repair possible setjmp clobbering.
2216
efc736d3
PE
2217 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2218
4e2fe2e6
PE
2219 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2220
f97334a2
PE
2221 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2222
4e75f29d
PE
2223 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2224 Define only if needed.
2225
90efadd1
PE
2226 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2227 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2228 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2229
3c647824
PE
2230 * dispextern.h (struct redisplay_interface): Rename param
2231 to avoid shadowing.
e264f262 2232 * termhooks.h (struct terminal): Likewise.
761383f4 2233 * xterm.c (xembed_send_message): Likewise.
3c647824 2234
b58c5c4a
PE
2235 * insdel.c (make_gap_smaller): Define only if
2236 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2237
cad59032
PE
2238 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2239 it.
2240
c339dc2e
PE
2241 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2242 so that we aren't warned about unused symbols.
2243
91a3e27b
PE
2244 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2245
399c71d3 2246 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2247
8ffc96f5
PE
2248 * xfns.c (x_real_positions): Mark locals as initialized.
2249
eef9bc79
PE
2250 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2251
098db9dd
PE
2252 * xterm.c: Fix problems found by static analysis with other toolkits.
2253 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2254 (x_dispatch_event): Declare static if USE_GTK, and
2255 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2256 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2257 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2258 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2259 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2260
eb18f6cc
PE
2261 * xmenu.c (menu_help_callback): Pointer type fixes.
2262 Use const pointers when pointing at readonly data. Avoid pointer
2263 signedness clashes.
2264 (FALSE): Remove unused macro.
2265 (update_frame_menubar): Remove unused decl.
2266
1fe72bf8
PE
2267 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2268
60d9e1db
PE
2269 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2270 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2271 (single_menu_item): Rename local to avoid shadowing.
2272
39261c26
PE
2273 * keyboard.c (make_lispy_event): Remove unused local var.
2274
018c5e19
PE
2275 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2276 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2277
63d2b86e
PE
2278 * bitmaps: Change bitmaps from unsigned char back to the X11
2279 compatible char. Avoid the old compiler warnings about
2280 out-of-range initializers by using, for example, '\xab' rather
2281 than 0xab.
2282
aefd87e1
PE
2283 * xgselect.c (xgselect_initialize): Check vs interface
2284 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2285
bf501fb9
PE
2286 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2287
e9829fdf
PE
2288 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2289 to read-only memory.
2290
1086c095
PE
2291 * fns.c (vector): Remove; this old hack is no longer needed.
2292
2baccd04 2293 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2294 Remove unused var.
dde42981 2295 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2296
72391843 2297 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2298
436c16df 2299 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2300 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2301 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2302
92bb796d 2303 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2304 (x_term_init): Remove local to avoid shadowing.
92bb796d 2305
764430a3 2306 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2307
2308 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2309 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2310
d1dfb56c
EZ
23112011-04-16 Eli Zaretskii <eliz@gnu.org>
2312
c4354cb4
EZ
2313 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2314
d1dfb56c
EZ
2315 Fix regex.c, syntax.c and friends for buffers > 2GB.
2316 * syntax.h (struct gl_state_s): Declare character position members
2317 EMACS_INT.
2318
2319 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2320
04f2d78b
CB
2321 * textprop.c (verify_interval_modification, interval_of):
2322 Declare arguments EMACS_INT.
d1dfb56c
EZ
2323
2324 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2325 EMACS_INT.
2326
2327 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2328
2329 * indent.c (Fvertical_motion): Local variable it_start is now
2330 EMACS_INT.
2331
2332 * regex.c (re_match, re_match_2, re_match_2_internal)
2333 (bcmp_translate, regcomp, regexec, print_double_string)
2334 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2335 (re_compile_pattern, re_exec): Declare arguments and local
2336 variables `size_t' and `ssize_t' and return values `regoff_t', as
2337 appropriate.
2338 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2339 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2340 <compile_stack_type>: `size' and `avail' are now `size_t'.
2341
2342 * regex.h <regoff_t>: Use ssize_t, not int.
2343 (re_search, re_search_2, re_match, re_match_2): Arguments that
2344 specify buffer/string position and length are now ssize_t and
2345 size_t. Return type is regoff_t.
2346
613052cd
BK
23472011-04-16 Ben Key <bkey76@gmail.com>
2348
2349 * nsfont.m: Fixed bugs in ns_get_family and
2350 ns_descriptor_to_entity that were caused by using free to
2351 deallocate memory blocks that were allocated by xmalloc (via
2352 xstrdup). This caused Emacs to crash when compiled with
2353 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2354 --enable-checking=xmallocoverrun). xfree is now used to
2355 deallocate these memory blocks.
2356
4170f62f 23572011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2358
71b41406
PE
2359 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2360
9587a89d
PE
2361 emacs_write: Accept and return EMACS_INT for sizes.
2362 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2363 et seq.
2364 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2365 Accept and return EMACS_INT.
2366 (emacs_gnutls_write): Return the number of bytes written on
2367 partial writes.
2368 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2369 (emacs_read, emacs_write): Remove check for negative size, as the
2370 Emacs source code has been audited now.
9587a89d
PE
2371 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2372 (emacs_read, emacs_write): Use it.
273a5f82
PE
2373 * process.c (send_process): Adjust to the new signatures of
2374 emacs_write and emacs_gnutls_write. Do not attempt to store
2375 a byte offset into an 'int'; it might overflow.
9587a89d 2376 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2377
3e047f51
PE
2378 * sound.c: Don't assume sizes fit in 'int'.
2379 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2380 Return EMACS_INT, not int.
3e047f51 2381 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2382 Accept EMACS_INT, not int.
2383 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2384 record read return values.
2385
cc39a9db
BK
23862011-04-15 Ben Key <bkey76@gmail.com>
2387
c9d0ec6d
JB
2388 * keyboard.c (Qundefined): Don't declare static since it is used
2389 in nsfns.m.
2390 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2391 static since they are used in nsfont.m.
cc39a9db 2392
6c60eb9f
SM
23932011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2394
2395 * process.c (Qprocessp): Don't declare static.
2396 * lisp.h (Qprocessp): Declare again.
2397
7990b61a
JB
23982011-04-15 Juanma Barranquero <lekktu@gmail.com>
2399
2400 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2401
5d4cb038
PE
24022011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2403
8bd7b830 2404 Improve C-level modularity by making more things 'static'.
cd64ea1d 2405
e3b27b31
PE
2406 Don't publish debugger-only interfaces to other modules.
2407 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2408 (verify_bytepos, count_markers): Move decls to the only modules
2409 that need them.
2410 * region-cache.h (pp_cache): Likewise.
2411 * window.h (check_all_windows): Likewise.
2412 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2413
5d4cb038
PE
2414 * sysdep.c (croak): Now static, if
2415 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2416 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2417
2418 * alloc.c (refill_memory_reserve): Now static if
2419 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2420 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2421
e87b6180
PE
2422 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2423 Define only if USE_LUCID.
2424
ac64929e
PE
2425 * xrdb.c (x_customization_string, x_rm_string): Now static.
2426
6f37259d
PE
2427 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2428 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2429
1683e3ab
PE
2430 * xdisp.c (draw_row_with_mouse_face): Now static.
2431 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2432
de9c2632
PE
2433 * window.h (check_all_windows): Mark externally visible.
2434
2b96acb7
PE
2435 * window.c (window_deletion_count): Now static.
2436
2437 * undo.c: Make symbols static if they're not exported.
2438 (last_undo_buffer, last_boundary_position, pending_boundary):
2439 Now static.
2440
50436f33
PE
2441 * textprop.c (interval_insert_behind_hooks): Now static.
2442 (interval_insert_in_front_hooks): Likewise.
2443
64520e5c
PE
2444 * term.c: Make symbols static if they're not exported.
2445 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2446 (max_frame_lines, tty_set_terminal_modes):
2447 (tty_reset_terminal_modes, tty_turn_off_highlight):
2448 (get_tty_terminal): Now static.
2449 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2450 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2451 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2452 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2453 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2454
1fa53021
PE
2455 * sysdep.c: Make symbols static if they're not exported.
2456 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2457 Now static.
2458 (sigprocmask_set, full_mask): Remove; unused.
2459 (wait_debugging): Mark as visible.
2460 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2461 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2462
d4b43b22
PE
2463 * syntax.c (syntax_temp): Define only if !__GNUC__.
2464
b7c513d0
PE
2465 * sound.c (current_sound_device, current_sound): Now static.
2466
989b29ad
PE
2467 * search.c (searchbufs, searchbuf_head): Now static.
2468
13a55a78
PE
2469 * scroll.c (scroll_cost): Remove; unused.
2470 * dispextern.h (scroll_cost): Remove decl.
2471
de68a1fc
PE
2472 * region-cache.h (pp_cache): Mark as externally visible.
2473
40ccffa6
PE
2474 * process.c: Make symbols static if they're not exported.
2475 (process_tick, update_tick, create_process, chan_process):
2476 (Vprocess_alist, proc_buffered_char, datagram_access):
2477 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2478 (deactivate_process): Mark defn as static, as well as decl.
2479 * lisp.h (create_process): Remove decl.
2480 * process.h (chan_process, Vprocess_alist): Remove decls.
2481
ad64fc97
PE
2482 * print.c: Make symbols static if they're not exported.
2483 (print_depth, new_backquote_output, being_printed, print_buffer):
2484 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2485 (print_interval, print_number_index, initial_stderr_stream):
2486 Now static.
2487 * lisp.h (Fprinc): Remove decl.
2488 (debug_output_compilation_hack): Mark as externally visible.
2489
adddb265
PE
2490 * sysdep.c (croak): Move decl from here to syssignal.h.
2491 * syssignal.h (croak): Put it here, so the API can be checked when
2492 'croak' is called from dissociate_if_controlling_tty.
2493
1717ede2
PE
2494 * minibuf.c: Make symbols static if they're not exported.
2495 (minibuf_save_list, choose_minibuf_frame): Now static.
2496 * lisp.h (choose_minibuf_frame): Remove decl.
2497
fa5fb2bc
PE
2498 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2499
1e3890d1
PE
2500 * lread.c: Make symbols static if they're not exported.
2501 (read_objects, initial_obarray, oblookup_last_bucket_number):
2502 Now static.
2503 (make_symbol): Remove; unused.
2504 * lisp.h (initial_obarray, make_symbol): Remove decls.
2505
8a1414fa
PE
2506 * keyboard.c: Make symbols static if they're not exported.
2507 (single_kboard, recent_keys_index, total_keys, recent_keys):
2508 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2509 (this_single_command_key_start, echoing, last_auto_save):
2510 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2511 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2512 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2513 (Vlispy_mouse_stem, double_click_count):
2514 Now static.
2515 (force_auto_save_soon): Define only if SIGDANGER.
2516 (ignore_mouse_drag_p): Now static if
2517 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2518 (print_help): Remove; unused.
2519 (stop_character, last_timer_event): Mark as externally visible.
2520 * keyboard.h (ignore_mouse_drag_p): Declare only if
2521 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2522 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2523 * lisp.h (echoing): Remove decl.
2524 (force_auto_save_soon): Declare only if SIGDANGER.
2525 * xdisp.c (redisplay_window): Simplify code, to make it more
2526 obvious that ignore_mouse_drag_p is not accessed if !defined
2527 USE_GTK && !defined HAVE_NS.
2528
93ea6e8f
PE
2529 * intervals.c: Make symbols static if they're not exported.
2530 (merge_properties_sticky, merge_interval_right, delete_interval):
2531 Now static.
2532 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2533
77382fcc
PE
2534 * insdel.c: Make symbols static if they're not exported.
2535 However, leave prepare_to_modify_buffer alone. It's never
2536 called from outside this function, but that appears to be a bug.
2537 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2538 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2539 (adjust_after_replace_noundo): Remove; unused.
2540 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2541 (signal_before_change): Remove decls.
77382fcc 2542
9306c32e
PE
2543 * indent.c (val_compute_motion, val_vmotion): Now static.
2544
cd44d2eb
PE
2545 * image.c: Make symbols static if they're not exported.
2546 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2547 if USE_GTK.
2548 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2549 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2550
ad9a7a06
PE
2551 * fringe.c (standard_bitmaps): Now static.
2552 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2553
81626931
PE
2554 * frame.c: Make symbols static if they're not exported.
2555 (x_report_frame_params, make_terminal_frame): Now static.
2556 (get_frame_param): Now static, unless HAVE_NS.
2557 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2558 (x_get_resource_string): Remove; not used.
2559 * frame.h (make_terminal_frame, x_report_frame_params):
2560 (x_get_resource_string); Remove decls.
2561 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2562 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2563
239f9db9
PE
2564 * font.c, fontset.c: Make symbols static if they're not exported.
2565 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2566 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2567 * font.c (font_close_object): Now static.
2568 * font.h (font_close_object): Remove.
2569 * fontset.c (FONTSET_OBJLIST): Remove.
2570 (free_realized_fontset) #if-0 the body, which does nothing.
2571 (face_suitable_for_char_p): #if-0, as it's never called.
2572 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2573 * xfaces.c (face_at_string_position):
2574 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2575 since 0 is always ASCII.
2576
dfcf3579
PE
2577 * fns.c (weak_hash_tables): Now static.
2578
5045092b
PE
2579 * fileio.c: Make symbols static if they're not exported.
2580 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2581 (Vwrite_region_annotation_buffers): Now static.
2582
57a96f5c
PE
2583 * eval.c: Make symbols static if they're not exported.
2584 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2585 * lisp.h (backtrace_list): Remove decl.
2586
35f08c38
PE
2587 * emacs.c: Make symbols static if they're not exported.
2588 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2589 (fatal_error_code, fatal_error_signal_hook, standard_args):
2590 Now static.
2591 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2592 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2593 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2594 * lisp.h (fatal_error_signal_hook): Remove decl.
2595 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2596
f44bd759
PE
2597 * editfns.c: Move a (normally-unused) function to its only use.
2598 * editfns.c, lisp.h (get_operating_system_release): Remove.
2599 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2600 worth the hassle of breaking this out.
2601
b532497d
PE
2602 * xterm.c: Make symbols static if they're not exported.
2603 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2604 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2605 (x_destroy_window, x_delete_display):
2606 Now static.
2607 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2608 (x_mouse_leave): Remove; unused.
2609 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2610 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2611 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2612 Remove decls.
2613 (x_mouse_leave): Declare only if WINDOWSNT.
2614 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2615 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2616 USE_X_TOOLKIT.
2617
1675728f
PE
2618 * ftxfont.c: Make symbols static if they're not exported.
2619 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2620 HAVE_FREETYPE.
2621 * font.h (ftxfont_driver): Likewise.
2622
e4cebfca
PE
2623 * xfns.c: Make symbols static if they're not exported.
2624 (x_last_font_name, x_display_info_for_name):
2625 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2626 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2627 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2628 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2629 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2630 (last_show_tip_args): Now static.
2631 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2632 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2633 (x_screen_planes): Remove; unused.
2634 * dispextern.h (x_screen_planes): Remove decl.
2635
5bf46f05
PE
2636 * dispnew.c: Make symbols static if they're not exported.
2637 * dispextern.h (redraw_garbaged_frames, scrolling):
2638 (increment_row_positions): Remove.
2639 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2640 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2641 Now static.
2642 (redraw_garbaged_frames): Remove; unused.
2643
435f4c28
PE
2644 * xfaces.c: Make symbols static if they're not exported.
2645 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2646 Remove decls.
2647 * xterm.h (defined_color): Remove decls.
2648 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2649 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2650 (menu_face_changed_default, defined_color, free_realized_face):
2651 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2652 (ascii_face_of_lisp_face): Remove; unused.
2653
8524aef3
PE
2654 * xdisp.c: Make symbols static if they're not exported.
2655 * dispextern.h (scratch_glyph_row, window_box_edges):
2656 (glyph_to_pixel_coords, set_cursor_from_row):
2657 (get_next_display_element, set_iterator_to_next):
2658 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2659 (show_mouse_face): Remove decls
2660 * frame.h (message_buf_print): Likewise.
2661 * lisp.h (pop_message, set_message, check_point_in_composition):
2662 Likewise.
2663 * xterm.h (set_vertical_scroll_bar): Likewise.
2664 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2665 (message_buf_print, scratch_glyph_row, displayed_buffer):
2666 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2667 (get_next_display_element, show_mouse_face, window_box_edges):
2668 (frame_to_window_pixel_xy, check_point_in_composition):
2669 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2670 (glyph_to_pixel_coords): Remove; unused.
2671
16390cd2
PE
2672 * dired.c (file_name_completion): Now static.
2673
2674 * dbusbind.c (xd_in_read_queued_messages): Now static.
2675
a25f4dfa
PE
2676 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2677 * data.c (circular_list_error): Remove.
2678
14a9c8df
PE
2679 * commands.h (last_point_position, last_point_position_buffer):
2680 (last_point_position_window): Remove decls.
2681 * keyboard.c: Make these variables static.
2682
04f2d78b
CB
2683 * coding.h (coding, code_convert_region, encode_coding_gap):
2684 Remove decls.
74ab6df5
PE
2685 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2686 (iso_code_class, detect_coding, code_convert_region): Now static.
2687 (encode_coding_gap): Remove; unused.
2688
38dfbee1
PE
2689 * chartab.c (chartab_chars, chartab_bits): Now static.
2690
a2cb4e63
PE
2691 * charset.h (charset_iso_8859_1): Remove decl.
2692 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2693 Now static.
2694
127198fd
PE
2695 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2696 * ccl.c (Vccl_program_table): Now static.
2697 (check_ccl_update): Remove; unused.
2698
d85b608f
PE
2699 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2700 * category.h: ... from here.
2701 * category.c (check_category_table, set_category_set): Now static.
2702
31cd66f3
PE
2703 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2704 * lisp.h: Remove these decls.
2705
c358e587
PE
2706 * buffer.c (buffer_count): Remove unused var.
2707
e78aecca
PE
2708 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2709 so that it's not optimized away.
2710 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2711 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2712 exported only to the debugger.
2713
e192d7d3 2714 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2715 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2716
92470028
PE
2717 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2718 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2719 was inaccessible from Lisp.
2720 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2721 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2722
244ed907
PE
2723 alloc.c: Import and export fewer symbols, and remove unused items.
2724 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2725 is defined.
2726 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2727 it's not optimized away by whole-program optimization.
2728 (message_enable_multibyte, free_misc): Remove.
2729 (catchlist, handlerlist, mark_backtrace):
2730 Declare only if BYTE_MARK_STACK.
2731 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2732 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2733 (message_enable_multibyte): Remove decl.
2734 (free_misc, interval_free_list, float_block, float_block_index):
2735 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2736 (cons_free_list, last_marked_index):
2737 Now static.
2738 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2739 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2740 (mark_backtrace): Define only if BYTE_MARK_STACK.
2741 * xdisp.c (message_enable_multibyte): Now static.
2742
61c2b50e 2743 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2744 This makes it easier for human readers (and static analyzers)
2745 to see whether these variables are used from other modules.
2746 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2747 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2748 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2749 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2750 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2751 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2752 * xmenu.c, xselect.c:
2753 Declare Q* vars static if they are not used in other modules.
2754 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2755 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2756 Remove decls of unexported vars.
2757 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2758
95c82688
PE
2759 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2760
16a97296
PE
2761 Make Emacs functions such as Fatom 'static' by default.
2762 This makes it easier for human readers (and static analyzers)
2763 to see whether these functions can be called from other modules.
2764 DEFUN now defines a static function. To make the function external
2765 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2766 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2767 (Finit_image_library):
16a97296
PE
2768 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2769 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2770 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2771 Remove decls, since these functions are now static.
2772 (Funintern, Fget_internal_run_time): New decls, since these functions
2773 were already external.
95c82688 2774
16a97296
PE
2775 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2776 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2777 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2778 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2779 * keyboard.c, keymap.c, lread.c:
2780 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2781 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2782 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2783 Mark functions with DEFUE instead of DEFUN,
2784 if they are used in other modules.
2785 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2786 decls for now-static functions.
2787 * buffer.h (Fdelete_overlay): Remove decl.
2788 * callproc.c (Fgetenv_internal): Mark as internal.
2789 * composite.c (Fremove_list_of_text_properties): Remove decl.
2790 (Fcomposition_get_gstring): New forward static decl.
2791 * composite.h (Fcomposite_get_gstring): Remove decl.
2792 * dired.c (Ffile_attributes): New forward static decl.
2793 * doc.c (Fdocumntation_property): New forward static decl.
2794 * eval.c (Ffetch_bytecode): New forward static decl.
2795 (Funintern): Remove extern decl; now in .h file where it belongs.
2796 * fileio.c (Fmake_symbolic_link): New forward static decl.
2797 * image.c (Finit_image_library): New forward static decl.
2798 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2799 * intervals.h (Fprevious_property_change):
2800 (Fremove_list_of_text_properties): Remove decls.
2801 * keyboard.c (Fthis_command_keys): Remove decl.
2802 (Fcommand_execute): New forward static decl.
2803 * keymap.c (Flookup_key): New forward static decl.
2804 (Fcopy_keymap): Now static.
2805 * keymap.h (Flookup_key): Remove decl.
2806 * process.c (Fget_process): New forward static decl.
2807 (Fprocess_datagram_address): Mark as internal.
2808 * syntax.c (Fsyntax_table_p): New forward static decl.
2809 (skip_chars): Remove duplicate decl.
2810 * textprop.c (Fprevious_property_change): New forward static decl.
2811 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2812 Now internal.
2813 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2814 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2815
785bbd42
PE
2816 * editfns.c (Fformat): Remove unreachable code.
2817
8b913b57
AS
28182011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2819
2820 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2821 change. (Bug#8496)
2822
a6744a35
EZ
28232011-04-13 Eli Zaretskii <eliz@gnu.org>
2824
2825 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2826 when at ZV. (Bug#8487)
2827
e7974947
AS
28282011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2829
baad03f0
AS
2830 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2831 (Bug#8437)
2832 * keyboard.c (parse_tool_bar_item): Likewise.
2833 * sound.c (sound_cleanup, alsa_close): Likewise.
2834 * termcap.c (tgetent): Likewise.
2835 * xfns.c (x_default_font_parameter): Likewise.
2836 * xsettings.c (read_and_apply_settings): Likewise.
2837
e7974947
AS
2838 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2839 (overrun_check_free): Protoize.
2840
28272684
PE
28412011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2844 since callers should never pass a negative size.
2845 Change the signature to match that of plain 'read' and 'write'; see
2846 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2847 * lisp.h: Update prototypes of emacs_write and emacs_read.
2848
11997c76
EZ
28492011-04-11 Eli Zaretskii <eliz@gnu.org>
2850
2851 * xdisp.c (redisplay_window): Don't try to determine the character
2852 position of the scroll margin if the window start point w->startp
e896f03c 2853 is outside the buffer's accessible region. (Bug#8468)
11997c76 2854
8a2cbd72
EZ
28552011-04-10 Eli Zaretskii <eliz@gnu.org>
2856
2857 Fix write-region and its subroutines for buffers > 2GB.
2858 * fileio.c (a_write, e_write): Modify declaration of arguments and
2859 local variables to support buffers larger than 2GB.
2860 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2861
2862 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2863 argument, local variables, and return value.
2864
2865 * lisp.h: Update prototypes of emacs_write and emacs_read.
2866
2867 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2868
4073e537 28692011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2870
1ebfdcb6
PE
2871 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2872
b2ded58d
PE
2873 Fix more problems found by GCC 4.6.0's static checks.
2874
7d66342c
PE
2875 * xdisp.c (vmessage): Use a better test for character truncation.
2876
bbf47d44
PE
2877 * charset.c (load_charset_map): <, not <=, for optimization,
2878 and to avoid potential problems with integer overflow.
9248994d 2879 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2880 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2881 * editfns.c (Fformat): Likewise.
1e69125e 2882 * syntax.c (skip_chars): Likewise.
3befa583 2883
e3019616
PE
2884 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2885 This also lets GCC 4.6.0 generate slightly better loop code.
2886
becfa255
PE
2887 * callint.c (Fcall_interactively): <, not <=, for optimization.
2888 (Fcall_interactively): Count the number of arguments produced,
2889 not the number of arguments given. This is simpler and lets GCC
2890 4.6.0 generate slightly better code.
2891
dae0cd48
PE
2892 * ftfont.c: Distingish more carefully between FcChar8 and char.
2893 The previous code passed unsigned char * to a functions like
2894 strlen and xstrcasecmp that expect char *, which does not
2895 conform to the C standard.
2896 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2897 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2898 char * when the C standard requires it.
2899
76032d70
PE
2900 * keyboard.c (read_char): Remove unused var.
2901
eb3f1cc8
PE
2902 * eval.c: Port to Windows vsnprintf (Bug#8435).
2903 Include <limits.h>.
2904 (SIZE_MAX): Define if the headers do not.
2905 (verror): Do not give up if vsnprintf returns a negative count.
2906 Instead, grow the buffer. This ports to Windows vsnprintf, which
2907 does not conform to C99. Problem reported by Eli Zaretskii.
2908 Also, simplify the allocation scheme, by avoiding the need for
2909 calling realloc, and removing the ALLOCATED variable.
2910
70476b54
PE
2911 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2912
12020a9e
PE
2913 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2914 But keep the doprint source code for now, as we might revamp it
2915 and use it again (Bug#8435).
ea6c7ae6
PE
2916 * lisp.h (doprnt): Remove.
2917 * Makefile.in (base_obj): Remove doprnt.o.
2918 * deps.mk (doprnt.o): Remove.
2919
5fdb398c
PE
2920 error: Print 32- and 64-bit integers portably (Bug#8435).
2921 Without this change, on typical 64-bit hosts error ("...%d...", N)
2922 was used to print both 32- and 64-bit integers N, which relied on
2923 undefined behavior.
2924 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2925 New macro.
2926 * lisp.h (error, verror): Mark as printf-like functions.
2927 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2928 Report overflow in size calculations when allocating printf buffer.
2929 Do not truncate output string at its first null byte.
2930 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2931 Truncate the output at a character boundary, since vsnprintf does not
2932 do that.
2933 * charset.c (check_iso_charset_parameter): Convert internal
2934 character to string before calling 'error', since %c now has the
2935 printf meaning.
2936 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2937 overflow when computing char to be passed to 'error'. Do not
2938 pass Lisp_Object to 'error'; pass the integer instead.
2939 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2940 formatted with plain %d.
2941
b189fa66
PE
2942 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2943
bff87ef0
PE
2944 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2945
7e2cac20
PE
2946 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2947
ce4d90b5
PE
2948 * xterm.c (x_catch_errors): Remove duplicate declaration.
2949
266c9547
PE
2950 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2951
79c49ad2
PE
2952 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2953
368f4090
JM
29542011-04-10 Jim Meyering <meyering@redhat.com>
2955
2956 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2957 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2958 return ssize_t not "int", and use size_t as the buffer length.
2959 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2960 * gnutls.h: Update declarations.
2961 * process.c (read_process_output): Use ssize_t, to match.
2962 (send_process): Likewise.
2963
a32d4040
CY
29642011-04-09 Chong Yidong <cyd@stupidchicken.com>
2965
2966 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2967
8546720e 29682011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2969
04f2d78b
CB
2970 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2971 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2972
8546720e
GM
2973 * xterm.c (handle_one_xevent):
2974 * xmenu.c (create_and_show_popup_menu):
2975 * xselect.c (x_decline_selection_request)
2976 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2977
0a2f5c1a 29782011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2979
2980 Fix some uses of `int' instead of EMACS_INT.
2981 * search.c (string_match_1, fast_string_match)
2982 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2983 (scan_buffer, find_next_newline_no_quit)
2984 (find_before_next_newline, search_command, Freplace_match)
2985 (Fmatch_data): Make some `int' variables be EMACS_INT.
2986
2987 * xdisp.c (display_count_lines): 3rd argument and return value now
2988 EMACS_INT. All callers changed.
2989 (pint2hrstr): Last argument is now EMACS_INT.
2990
2991 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2992 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2993 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2994 (decode_coding_utf_16, decode_coding_emacs_mule)
2995 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2996 (decode_coding_ccl, decode_coding_charset)
2997 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2998 (decode_coding_iso_2022, decode_coding_emacs_mule)
2999 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3000 <char_offset, last_offset>: Declare EMACS_INT.
3001 (encode_coding_utf_8, encode_coding_utf_16)
3002 (encode_coding_emacs_mule, encode_invocation_designation)
3003 (encode_designation_at_bol, encode_coding_iso_2022)
3004 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3005 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3006 Declare EMACS_INT.
3007 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3008 (encode_invocation_designation): Last argument P_NCHARS is now
3009 EMACS_INT.
3010 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3011 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3012
3013 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3014 All users changed.
3015
3016 * ccl.c (Fccl_execute_on_string): Declare some variables
3017 EMACS_INT.
3018
8546720e 30192011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3020
3021 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3022
4e19a977
CS
30232011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3024
3025 * process.c (Fformat_network_address): Doc fix.
3026
87302331
R
30272011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3028
3029 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3030
cbb59342
CY
30312011-04-08 Chong Yidong <cyd@stupidchicken.com>
3032
3033 * keyboard.c (read_char): Call Lisp function help-form-show,
3034 instead of using internal_with_output_to_temp_buffer.
3035 (Qhelp_form_show): New var.
e0d38eeb 3036 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3037
3038 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3039
3040 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3041
e67a13ab
CY
30422011-04-06 Chong Yidong <cyd@stupidchicken.com>
3043
04f2d78b
CB
3044 * process.c (Flist_processes): Remove to Lisp.
3045 (list_processes_1): Delete.
e67a13ab 3046
973f782d
EZ
30472011-04-06 Eli Zaretskii <eliz@gnu.org>
3048
7c106b1e
EZ
3049 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3050
973f782d
EZ
3051 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3052
41cf7d1a 30532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3054
ca23cc88
PE
3055 Fix more problems found by GCC 4.6.0's static checks.
3056
f390e2d5
PE
3057 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3058
42eea0d0
PE
3059 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3060
b69769da 3061 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3062
f9541e84
PE
3063 * xdisp.c (vmessage): Mark as a printf-like function.
3064
13841b55
PE
3065 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3066
c136c10f
PE
3067 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3068
5e2d4a30
PE
3069 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3070 printf-like functions.
3071 (tiff_load): Add casts to remove these marks before passing them
3072 to system-supplied API.
3073
583f48b9
PE
3074 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3075
b25d760e
PE
3076 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3077 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3078 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3079 directly, rather than having caller test rule sign. This avoids
3080 some unnecessary tests.
3081 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3082 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3083 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3084
bc7b6697 3085 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3086 (xfont_open): Avoid unnecessary tests.
bc7b6697 3087
27ccc379
PE
3088 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3089
dcd5c89a
PE
3090 * composite.h, composite.c (composition_gstring_put_cache):
3091 Use EMACS_INT, not int, for length.
3092
b13a45c6
PE
3093 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3094 breaking out part of COMPOSITION_DECODE_RULE.
3095 (COMPOSITION_DECODE_RULE): Use it.
3096 * composite.c (get_composition_id): Remove unused local vars,
3097 by using the new macro.
3098
1e792e4d
PE
3099 * textprop.c (set_text_properties_1): Change while to do-while,
3100 since the condition is always true at first.
3101
dc6c6455 3102 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3103 (interval_deletion_adjustment): Return unsigned value.
3104 All uses changed.
dc6c6455 3105
aba7731a
PE
3106 * process.c (list_processes_1, create_pty, read_process_output):
3107 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3108 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3109 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3110 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3111 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3112
fdfc4bf3
PE
3113 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3114
fca8fe46 3115 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3116 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3117
06a0259a 3118 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3119 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3120 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3121
e7b9e80f
PE
3122 * print.c (print_error_message): Avoid int overflow.
3123
56201685
PE
3124 * font.c (font_list_entities): Redo for clarity,
3125 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3126
78834453 3127 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3128 (font_score): Avoid potential overflow in diff calculation.
78834453 3129
0bc0b309 3130 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3131 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3132
e610eaca
PE
3133 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3134
b895abce
PE
3135 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3136 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3137 can always succeed if overflow has undefined behavior.
3138
1f1d9321 3139 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3140 (wordify): Omit three unnecessary tests.
1f1d9321 3141
c59478bc
PE
3142 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3143 All callers changed. This avoids the need for an unused var.
3144
79b73827
PE
3145 * casefiddle.c (casify_region): Remove var that is set but not used.
3146
a4db5dfe
PE
3147 * dired.c (file_name_completion): Remove var that is set but not used.
3148
43aae36e
PE
3149 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3150
2a47c44d 3151 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3152 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3153
a37c69bf
PE
3154 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3155 Check for integer overflow on size calculations.
3156
328ab8e7
PE
3157 * buffer.c (Fprevious_overlay_change): Remove var that is set
3158 but not used.
3159
e5a2a5cb
PE
3160 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3161 Remove vars that are set but not used.
8d84a6eb 3162 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3163 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3164
a60e5f68
PE
3165 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3166
f661cb61 3167 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3168 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3169
f0397f5a
PE
3170 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3171 that are set but not used.
3172
8664db06 3173 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3174 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3175
6abdaa4a
PE
3176 * xselect.c (x_get_local_selection, x_handle_property_notify):
3177 Remove vars that are set but not used.
3178
0ce7538d 3179 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3180 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3181
9ae848fc
PE
3182 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3183 Remove var that is set but not used.
0b918413
PE
3184 (scroll_bar_windows_size): Now size_t, not int.
3185 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3186 Check for overflow.
9ae848fc 3187
a5a62657
PE
3188 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3189 (map_tty_color) [!defined MSDOS]: Likewise.
3190
5c5cdd39
PE
3191 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3192
66ebf983
PE
3193 * coding.c: Remove vars that are set but not used.
3194 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3195 All callers changed.
3196 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3197 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3198 (decode_coding_charset): Remove vars that are set but not used.
3199
1be4d761
PE
3200 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3201 that is set but not used.
3202
47553fa8
PE
3203 * print.c (print_object): Remove var that is set but not used.
3204
1f7196bf 3205 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3206 The gnulib version avoids calling malloc in the usual case,
3207 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3208 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3209 * filelock.c (current_lock_owner): Likewise.
3210 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3211 * sysdep.c: Include allocator.h, careadlinkat.h.
3212 (emacs_no_realloc_allocator): New static constant.
3213 (emacs_readlink): New function.
fdb61804
PE
3214 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3215 ../lib/careadlinkat.h.
d1fdcab7 3216
f84c17c7
SM
32172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3218
3219 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3220 first non-nil return value).
3221
ef3862ad
JD
32222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3223
3224 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3225 if not defined (Bug#8403).
3226
376a7006
JB
32272011-04-02 Juanma Barranquero <lekktu@gmail.com>
3228
3229 * xdisp.c (display_count_lines): Remove parameter `start',
3230 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3231 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3232 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3233 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3234 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3235 and thereabouts. All callers changed.
3236 (get_per_char_metric): Remove parameter `f', unused since
3237 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3238
6ca3801d
JM
32392011-04-02 Jim Meyering <meyering@redhat.com>
3240
3241 do not dereference NULL upon failed strdup
3242 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3243 (ns_get_family): Likewise.
3244
d8e2b5ba
JB
32452011-04-02 Juanma Barranquero <lekktu@gmail.com>
3246
3247 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3248
8c74fcbd
JD
32492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3250
3251 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3252 later (Bug#8403).
3253
7200d79c
SM
32542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3255
03408648 3256 Add lexical binding.
7200d79c 3257
03408648
SM
3258 * window.c (Ftemp_output_buffer_show): New fun.
3259 (Fsave_window_excursion):
3260 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3261
3262 * lread.c (lisp_file_lexically_bound_p): New function.
3263 (Fload): Bind Qlexical_binding.
3264 (readevalloop): Remove `evalfun' arg.
3265 Bind Qinternal_interpreter_environment.
3266 (Feval_buffer): Bind Qlexical_binding.
3267 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3268 Mark as dynamic.
3269 (syms_of_lread): Declare `lexical-binding'.
3270
3271 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3272
3273 * keyboard.c (eval_dyn): New fun.
3274 (menu_item_eval_property): Use it.
ca105506
SM
3275
3276 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3277
03408648
SM
3278 * fns.c (concat, mapcar1): Accept byte-code-functions.
3279
3280 * eval.c (Fsetq): Handle lexical vars.
3281 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3282 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3283 (FletX, Flet): Obey lexical binding.
3284 (Fcommandp): Handle closures.
3285 (Feval): New `lexical' arg.
3286 (eval_sub): New function extracted from Feval. Use it almost
3287 everywhere where Feval was used. Look up vars in lexical env.
3288 Handle closures.
3289 (Ffunctionp): Move from subr.el.
3290 (Ffuncall): Handle closures.
3291 (apply_lambda): Remove `eval_flags'.
3292 (funcall_lambda): Handle closures and new byte-code-functions.
3293 (Fspecial_variable_p): New function.
3294 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3295 but without exporting it to Lisp.
23aba0ea 3296
23aba0ea 3297 * doc.c (Fdocumentation, store_function_docstring):
03408648 3298 * data.c (Finteractive_form): Handle closures.
23aba0ea 3299
03408648
SM
3300 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3301 interactive spec.
ba83908c 3302
04f2d78b
CB
3303 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3304 New byte-codes.
03408648
SM
3305 (exec_byte_code): New function extracted from Fbyte_code to handle new
3306 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3307
03408648 3308 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3309
03408648 3310 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3311
e2abce01
JB
33122011-03-31 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * xdisp.c (redisplay_internal): Fix prototype.
3315
63696a73 33162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3317
63696a73 3318 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3319 (try_scrolling): Use it when setting scroll_limit.
3320 Limit scrolling to 100 screen lines.
63696a73
EZ
3321 (redisplay_window): Even when falling back on "recentering",
3322 position point in the window according to scroll-conservatively,
3323 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3324
3325 (try_scrolling): When point is above the window, allow searching
3326 as far as scroll_max, or one screenful, to compute vertical
3327 distance from PT to the scroll margin position. This prevents
3328 try_scrolling from unnecessarily failing when
3329 scroll-conservatively is set to a value slightly larger than the
3330 window height. Clean up the case of PT below the margin at bottom
3331 of window: scroll_max can no longer be INT_MAX. When aggressive
3332 scrolling is in use, don't let point enter the opposite scroll
3333 margin as result of the scroll.
3334 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3335 threshold of 100 lines for never-recentering scrolling.
3336
e4cc2dfc
JB
33372011-03-31 Juanma Barranquero <lekktu@gmail.com>
3338
3339 * dispextern.h (move_it_by_lines):
3340 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3341 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3342 (message_log_check_duplicate): Remove parameters `prev_bol' and
3343 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3344 (redisplay_internal): Remove parameter `preserve_echo_area',
3345 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3346
3347 * indent.c (Fvertical_motion):
3348 * window.c (window_scroll_pixel_based, Frecenter):
3349 Don't pass `need_y_p' to `move_it_by_lines'.
3350
1c470562
SM
33512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3352
44f230aa
SM
3353 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3354 steal a few bits to be more compact.
3355 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3356 Remove unneeded casts.
3357
1c470562
SM
3358 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3359
888adce9
ZK
33602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3361
3362 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3363 binding" message (bug#7967).
3364
f838ed7b
PE
33652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3366
77861b95
PE
3367 Fix more problems found by GCC 4.6.0's static checks.
3368
de6dbc14
PE
3369 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3370 Remove unused local var.
3371
f838ed7b
PE
3372 * editfns.c (Fmessage_box): Remove unused local var.
3373
792c7b2b
PE
3374 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3375 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3376 Omit unused local vars.
c499e557 3377 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3378 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3379 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3380 Omit unused local var.
3381
ba0165e1
PE
3382 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3383 Don't assume string length fits in int.
32ad8845 3384 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3385 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3386
3c59b4c9
PE
3387 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3388 instead of alloca (Bug#8344).
3389
a3eed478 3390 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3391 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3392
eb4d412d
PE
3393 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3394
1658b401
PE
3395 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3396 concerns.
3397
3398 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3399
3400 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3401
9a2c6e05
PE
3402 * keyboard.c (syms_of_keyboard): Use the same style as later
3403 in this function when indexing through an array. This also
3404 works around GCC bug 48267.
3405
03d0a109
PE
3406 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3407
44f730c8
PE
3408 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3409
fe75f926
PE
3410 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3411 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3412
ffa8c828
PE
3413 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3414 This avoids undefined behavior on integer overflow, and is a bit
3415 more convenient anyway since it is compared to a size_t variable.
3416
c5101a77
PE
3417 Variadic C functions now count arguments with size_t, not int.
3418 This avoids an unnecessary limitation on 64-bit machines, which
3419 caused (substring ...) to crash on large vectors (Bug#8344).
3420 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3421 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3422 All variadic functions and their callers changed accordingly.
c5101a77
PE
3423 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3424 * data.c (arith_driver, float_arith_driver): Likewise.
3425 * editfns.c (general_insert_function): Likewise.
3426 * eval.c (struct backtrace.nargs, interactive_p)
3427 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3428 (funcall_lambda, mark_backtrace): Likewise.
3429 * fns.c (concat): Likewise.
3430 * frame.c (x_set_frame_parameters): Likewise.
3431 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3432 0 if not found, not -1. All callers changed.
3433
dd3f25f7
PE
3434 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3435 (stack_copy_size): Now size_t, not int.
3436 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3437
461c2ab9
JB
34382011-03-28 Juanma Barranquero <lekktu@gmail.com>
3439
3440 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3441 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3442 All callers changed.
3443
3444 * lisp.h (multibyte_char_to_unibyte):
3445 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3446 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3447 * character.h (CHAR_TO_BYTE8):
3448 * cmds.c (internal_self_insert):
3449 * editfns.c (general_insert_function):
3450 * keymap.c (push_key_description):
3451 * search.c (Freplace_match):
3452 * xdisp.c (message_dolog, set_message_1): All callers changed.
3453
f6d62986
SM
34542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3455
3456 * keyboard.c (safe_run_hook_funcall): New function.
3457 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3458 don't set the hook to nil, but remove the offending function instead.
3459 (Qcommand_hook_internal): Remove, unused.
3460 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3461 Vcommand_hook_internal.
3462
3463 * eval.c (enum run_hooks_condition): Remove.
3464 (funcall_nil, funcall_not): New functions.
3465 (run_hook_with_args): Call each function through a `funcall' argument.
3466 Remove `cond' argument, now redundant.
3467 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3468 (Frun_hook_with_args_until_failure): Adjust accordingly.
3469 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3470
1db5b1ad
JB
34712011-03-28 Juanma Barranquero <lekktu@gmail.com>
3472
3473 * dispextern.h (string_buffer_position): Remove declaration.
3474
3475 * print.c (strout): Remove parameter `multibyte', unused since
3476 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3477
3478 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3479 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3480 All callers changed.
3481
3482 * w32.c (_wsa_errlist): Use braces for struct initializers.
3483
3484 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3485 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3486 All callers changed.
3487 (string_buffer_position): Likewise. Also, make static (it's never
3488 used outside xdisp.c).
3489 (cursor_row_p): Remove parameter `w', unused since
3490 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3491 (decode_mode_spec): Remove parameter `precision', introduced during
3492 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3493 All callers changed.
3494
5ffb62aa
JD
34952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3496
3497 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3498
461c2ab9 34992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3500
3501 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3502 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3503 (ns_update_auto_hide_menu_bar): New functions.
3504 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3505 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3506 ns_constrain_all_frames.
3507 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3508 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3509
5c380ffb
JD
35102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3511
3512 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3513
9af30bdf
GM
35142011-03-27 Glenn Morris <rgm@gnu.org>
3515
3516 * syssignal.h: Replace RETSIGTYPE with void.
3517 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3518 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3519 Replace SIGTYPE with void everywhere.
3520 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3521 * s/template.h (SIGTYPE): Remove commented out definition.
3522
e2abce01
JB
35232011-03-26 Eli Zaretskii <eliz@gnu.org>
3524
3525 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3526 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3527
f868cd8a
JB
35282011-03-26 Juanma Barranquero <lekktu@gmail.com>
3529
59eb0929
JB
3530 * w32.c (read_unc_volume): Use parameter `henum', instead of
3531 global variable `wget_enum_handle'.
3532
3533 * keymap.c (describe_vector): Remove parameters `indices' and
3534 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3535 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3536
f868cd8a
JB
3537 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3538
3539 * keyboard.c (timer_check): Remove parameter `do_it_now',
3540 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3541 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3542 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3543
3544 * keyboard.c (read_char):
3545 * w32menu.c (w32_menu_display_help):
3546 * xmenu.c (show_help_event, menu_help_callback):
3547 Adjust calls to `show_help_echo'.
3548
3549 * gtkutil.c (xg_maybe_add_timer):
3550 * keyboard.c (readable_events):
3551 * process.c (wait_reading_process_output):
3552 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3553
3554 * insdel.c (adjust_markers_gap_motion):
3555 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3556 (gap_left, gap_right): Don't call it.
3557
2ecf6fdb
CY
35582011-03-25 Chong Yidong <cyd@stupidchicken.com>
3559
3560 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3561 incurred during fontification.
3562
6b1f9ba4
JB
35632011-03-25 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3566 (DEFVAR_PER_BUFFER): Don't pass it.
3567
3568 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3569 (scrolling_window): Don't pass it.
3570
0f4a96b5
JB
35712011-03-25 Juanma Barranquero <lekktu@gmail.com>
3572
3573 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3574
3575 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3576 and `suffix'.
3577 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3578 of variables specific to SELinux and computation of `encoded_absname'.
3579
3580 * image.c (XPutPixel): Remove unused variable `height'.
3581
3582 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3583
3584 * unexw32.c (get_section_info): Remove unused variable `section'.
3585
3586 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3587 (system_process_attributes): Remove unused variable `sess'.
3588 (sys_read): Remove unused variable `err'.
3589
3590 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3591 (w32_wnd_proc): Remove unused variable `isdead'.
3592 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3593 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3594 (x_create_tip_frame): Remove unused variable `tem'.
3595
3596 * w32inevt.c (w32_console_read_socket):
3597 Remove unused variable `no_events'.
3598
3599 * w32term.c (x_draw_composite_glyph_string_foreground):
3600 Remove unused variable `width'.
3601
1149507c
JB
36022011-03-24 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * w32term.c (x_set_glyph_string_clipping):
3605 Don't pass uninitialized region to CombineRgn.
3606
9c88f339
JB
36072011-03-23 Juanma Barranquero <lekktu@gmail.com>
3608
3609 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3610 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3611 (Fx_close_connection): Remove unused variable `i'.
3612
3613 * w32font.c (w32font_draw): Return number of glyphs.
3614 (w32font_open_internal): Remove unused variable `i'.
3615 (w32font_driver): Add missing initializer.
3616
3617 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3618 (fill_in_menu): Remove unused variable `items_added'.
3619
3620 * w32term.c (last_mouse_press_frame): Remove static global variable.
3621 (w32_clip_to_row): Remove unused variable `f'.
3622 (x_delete_terminal): Remove unused variable `i'.
3623
3624 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3625 (NOTHING): Remove unused static global variable.
3626 (uniscribe_check_otf): Remove unused variable `table'.
3627 (uniscribe_font_driver): Add missing initializers.
3628
dee091a3
JD
36292011-03-23 Julien Danjou <julien@danjou.info>
3630
3631 * term.c (Fsuspend_tty, Fresume_tty):
3632 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3633 * window.c (temp_output_buffer_show):
3634 * insdel.c (signal_before_change):
3635 * frame.c (Fhandle_switch_frame):
3636 * fileio.c (Fdo_auto_save):
3637 * emacs.c (Fkill_emacs):
3638 * editfns.c (save_excursion_restore):
3639 * cmds.c (internal_self_insert):
3640 * callint.c (Fcall_interactively):
3641 * buffer.c (Fkill_all_local_variables):
3642 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3643 Use Frun_hooks.
0f4a96b5 3644 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3645 unconditionnaly since it does the check itself.
3646
2c520ab5 36472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3648
c9c49752
PE
3649 Fix more problems found by GCC 4.5.2's static checks.
3650
8abc3f12
PE
3651 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3652 the first time through the loop, since we know p0 < p1 then.
3653 This also avoids a gcc -Wstrict-overflow warning.
3654
a2d26660
PE
3655 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3656 leading to a memory leak, possible in functions like
3657 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3658 of objects (Bug#8318).
a2d26660 3659
916c72e9
PE
3660 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3661 that could (at least in theory) be that large.
3662
19ab8a18
PE
3663 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3664 This is less likely to overflow, and avoids undefined behavior if
3665 overflow does occur. All callers changed. Use strtoul to scan
3666 for the unsigned long integer.
b7cbbd6f
PE
3667 (pint2hrstr): Simplify and tune code slightly.
3668 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3669
f0641eff
PE
3670 * scroll.c (do_scrolling): Work around GCC bug 48228.
3671 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3672
7f650bb9
PE
3673 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3674 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3675 (validate_x_resource_name): Simplify count usage.
3676 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3677
37dd57d1
PE
3678 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3679 fail (Bug#8306).
81e56e61 3680
699979fc 3681 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3682
401bf9b4
PE
3683 * process.c (Fmake_network_process): Use socklen_t, not int,
3684 where POSIX says socklen_t is required in portable programs.
3685 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3686 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3687 (Fmake_network_process, server_accept_connection):
3688 (wait_reading_process_output, read_process_output):
3689 Likewise.
3690
b93aacde
PE
3691 * process.c: Rename or move locals to avoid shadowing.
3692 (list_processes_1, Fmake_network_process):
3693 (read_process_output_error_handler, exec_sentinel_error_handler):
3694 Rename or move locals.
4dc343ee 3695 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3696 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3697 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3698 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3699 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3700
af8a867c 3701 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3702 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3703 Include tparam.h instead, since it declares them.
af8a867c
PE
3704 * cm.h (PC): Remove extern decl; tparam.h now does this.
3705 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3706 * terminfo.c: Include tparam.h, to check interfaces.
3707 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3708 (tparam): Adjust signature to match interface in tparam.h;
3709 this removes some undefined behavior. Check that outstring and len
3710 are zero, which they always are with Emacs.
3711 * tparam.h (PC, BC, UP): New extern decls.
3712
0248044d 3713 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3714 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3715
8ff096c1 3716 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3717 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3718 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3719 (ftfont_list): Remove unused local.
49eaafba
PE
3720 (get_adstyle_property, ftfont_pattern_entity):
3721 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3722 Rename locals to avoid shadowing.
8ff096c1 3723
e2be39f6
PE
3724 * xfont.c (xfont_list_family): Mark var as initialized.
3725
c9735e30
PE
3726 * xml.c (make_dom): Now static.
3727
8f5201ae
PE
3728 * composite.c (composition_compute_stop_pos): Rename local to
3729 avoid shadowing.
b246f932
PE
3730 (composition_reseat_it): Remove unused locals.
3731 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3732 (composition_update_it): Mark var as initialized.
11b61122
PE
3733 (find_automatic_composition): Mark vars as initialized,
3734 with a FIXME (Bug#8290).
8f5201ae 3735
760fbc2c
PE
3736 character.h: Rename locals to avoid shadowing.
3737 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3738 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3739 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3740 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3741 to avoid shadowing.
3742
ff08eb85
PE
3743 * textprop.c (property_change_between_p): Remove; unused.
3744
fc7bf025
PE
3745 * intervals.c (interval_start_pos): Now static.
3746
235d7abc
PE
3747 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3748
44f230aa
SM
3749 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3750 Rename locals to avoid shadowing.
3e7d6594 3751
50060332
PE
3752 * sound.c (wav_play, au_play, Fplay_sound_internal):
3753 Fix pointer signedness.
d01f234b 3754 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3755 (wav_play): Initialize a variable to 0, to prevent undefined
3756 behavior (Bug#8278).
50060332 3757
c4fc4e30
PE
3758 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3759
918436ed
PE
3760 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3761
c939f91b
PE
3762 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3763 clobbering (Bug#8298).
b9c7f648
PE
3764 * sysdep.c (sys_subshell): Likewise.
3765 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3766
6bd8c144
PE
3767 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3768 This should get cleaned up, so that child_setup has the
3769 same signature on all platforms.
3770
7710357c 3771 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3772 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3773
c59da222
CY
37742011-03-22 Chong Yidong <cyd@stupidchicken.com>
3775
3776 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3777 not to be necessary, and produces flickering.
3778
66b87493
GM
37792011-03-20 Glenn Morris <rgm@gnu.org>
3780
3781 * config.in: Remove file.
3782
45b6f6d5
JB
37832011-03-20 Juanma Barranquero <lekktu@gmail.com>
3784
3785 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3786 are now in src/globals.h.
3787 (syms_of_minibuf): Remove spurious & from previous change.
3788
3ec03f7e
LL
37892011-03-20 Leo <sdl.web@gmail.com>
3790
3791 * minibuf.c (completing-read-function): New variable.
3792 (completing-read-default): Rename from completing-read.
3793 (completing-read): Call completing-read-function.
3794
b14e3e21
CY
37952011-03-19 Juanma Barranquero <lekktu@gmail.com>
3796
3797 * xfaces.c (Fx_load_color_file):
3798 Read color file from absolute filename (bug#8250).
3799
f2b726e6
JB
38002011-03-19 Juanma Barranquero <lekktu@gmail.com>
3801
3802 * makefile.w32-in: Update dependencies.
3803
09f6ff02
EZ
38042011-03-17 Eli Zaretskii <eliz@gnu.org>
3805
3806 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3807
29a6015a
PE
38082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3809
a3a6c54e
PE
3810 Fix more problems found by GCC 4.5.2's static checks.
3811
b766f867
PE
3812 * process.c (make_serial_process_unwind, send_process_trap):
3813 (sigchld_handler): Now static.
3814
be02381c
PE
3815 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3816 That way, the code declares only the vars that it needs.
3817 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3818 * s/cygwin.h (PTY_ITERATION): Likewise.
3819 * s/darwin.h (PTY_ITERATION): Likewise.
3820 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3821
57048744
PE
3822 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3823 * process.c (allocate_pty): Don't declare stb unless it's needed.
3824
7914961c 3825 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3826 (CONSTANTLIM): Remove; unused.
3827 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3828 Define only if needed.
7914961c 3829
b3967b18
PE
3830 * unexelf.c (unexec): Name an expression,
3831 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3832 Use a different way to cause a compilation error if anyone uses
3833 n rather than nn, a way that does not involve shadowing.
73366a00 3834 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3835
29a6015a
PE
3836 * deps.mk (unexalpha.o): Remove; unused.
3837
43cfc33e 3838 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3839 * unexec.h: New file.
ce701a33
PE
3840 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3841 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3842 Depend on unexec.h.
3843 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3844 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3845 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3846 Change as necessary to match prototype in unexec.h.
ce701a33 3847
01f44d5a
PE
3848 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3849 shadowing.
4f63c6bb 3850 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3851
a6670b0b
PE
3852 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3853 Rename locals to avoid shadowing.
3854
cef2010d 3855 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3856 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3857
d4d7173a
PE
3858 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3859
f08b802a
PE
3860 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3861 warning when compiling print.c.
3862
3ddb0639
PE
3863 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3864 instead of using an uninitialized var.
5ad03b97 3865 (font_sort_entities): Mark var as initialized.
3ddb0639 3866
170a2692
PE
3867 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3868
e663c700
PE
3869 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3870 pointers to constants.
89bc529a 3871 (font_parse_fcname): Remove unused vars.
7b81e2d0 3872 (font_delete_unmatched): Now static.
ea838e10 3873 (font_get_spec): Remove; unused.
13a547c6
PE
3874 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3875 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3876 Rename or move locals to avoid shadowing.
e663c700 3877
2a80c887 3878 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3879 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3880
1384fa33 3881 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3882 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3883
8b2c52e9
PE
3884 * alloc.c (mark_backtrace): Move decl from here ...
3885 * lisp.h: ... to here, so that it can be checked.
3886
475545b5 3887 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3888 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3889 (lisp_indirect_variable): Name an expression,
3890 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3891 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3892
b1349114 3893 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3894 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3895 Use const pointer when appropriate.
b1349114 3896
a2928364
PE
3897 * lisp.h (get_system_name, get_operating_system_release):
3898 Move decls here, to check interfaces.
3899 * process.c (get_operating_system_release): Move decl to lisp.h.
3900 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3901 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3902 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3903 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3904 (Fformat_time_string, Fencode_time, Finsert_char):
3905 (Ftranslate_region_internal, Fformat):
3906 Rename or remove local vars to avoid shadowing.
9710023e 3907 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3908
a415e694
PE
3909 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3910 avoid shadowing.
3911
8ef4622d
PE
3912 * lisp.h (eassert): Check that the argument compiles, even if
3913 ENABLE_CHECKING is not defined.
3914
946f9a5b
PE
3915 * data.c (Findirect_variable): Name an expression, to avoid
3916 gcc -Wbad-function-cast warning.
112396d6 3917 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3918 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3919 (Fmake_variable_buffer_local, Fmake_local_variable):
3920 Mark variables as initialized.
52746918 3921 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3922
e5aab7e7 3923 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3924 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3925 Rename locals to avoid shadowing.
dff45157
PE
3926 (mark_stack): Move local variables into the #ifdef region where
3927 they're used.
7bc26fdb
PE
3928 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3929 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3930 needed otherwise.
3931 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3932 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3933 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3934
e5aab7e7
PE
3935 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3936 avoids undefined behavior in theory.
3937
4da60324
PE
3938 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3939
88043301
PE
3940 Use functions, not macros, for up- and down-casing (Bug#8254).
3941 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3942 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3943 to use the following functions instead of these macros.
3944 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3945 EMACS_INT, since callers assume the returned value fits in int.
3946 (upcase1): Likewise, for UPCASE_TABLE.
3947 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3948 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3949 the race-condition problem in the old DOWNCASE.
88043301 3950
19ed5445
PE
3951 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3952 Rename locals to avoid shadowing.
3953 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3954 (regex_compile, re_search_2, re_match_2_internal):
3955 Remove unused local vars.
952db0d7
PE
3956 (FREE_VAR): Rewrite so as not to use empty "else",
3957 which gcc can warn about.
da053e48 3958 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3959 (RETALLOC_IF): Define only if needed.
3960 (WORDCHAR_P): Likewise. This one is never needed, but is used
3961 only in a comment talking about a compiler bug, so put inside
3962 the #if 0 of that comment.
3963 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3964 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3965 Remove; unused.
19ed5445 3966
1f3561e4 3967 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3968 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3969 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3970
ded6f8f7
PE
3971 * search.c (simple_search): Remove unused var.
3972
dbd37a95
PE
3973 * dired.c (compile_pattern): Move decl from here ...
3974 * lisp.h: ... to here, so that it can be checked.
3975 (struct re_registers): New forward decl.
3976
7e47afad
PE
3977 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3978
85f24f61
PE
3979 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3980 All uses changed.
3981 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3982 Rename locals to avoid shadowing.
5671df8f 3983 (Fvertical_motion): Mark locals as initialized.
85f24f61 3984
181aa2be 3985 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3986 (casify_region): Mark local as initialized.
181aa2be 3987
930d429c
PE
3988 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3989
7082eac6
PE
3990 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3991 New macros, so that the caller can use some names other than
3992 gcpro1, gcpro2, etc.
3993 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3994 of the new macros.
3995 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3996 argument, for consistency with GCPRO2_VAR, etc: it is now the
3997 prefix of the variable, not the variable itself. All uses
3998 changed.
38b2c076
PE
3999 * dired.c (directory_files_internal, file_name_completion):
4000 Rename locals to avoid shadowing.
4001
15206ed9
PE
4002 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4003 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4004 dired.c's scmp function, had undefined behavior.
4005 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4006 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4007 * buffer.h: ... to here, because these macros use current_buffer,
4008 and the new implementation with inline functions needs to have
4009 current_buffer in scope now, rather than later when the macros
4010 are used.
4011 (downcase, upcase1): New static inline functions.
4012 (DOWNCASE, UPCASE1): Reimplement using these functions.
4013 This avoids undefined behavior in expressions like
4014 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4015 from race conditions in accessing the global variables
4016 case_temp1 and case_temp2.
4017 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4018 * lisp.h (case_temp1, case_temp2): Remove their decls.
4019 * character.h (ASCII_CHAR_P): Move from here ...
4020 * lisp.h: ... to here, so that the inline functions mentioned
4021 above can use them.
4022
4a6bea26
PE
4023 * dired.c (directory_files_internal_unwind): Now static.
4024
f14b7e14
PE
4025 * fileio.c (file_name_as_directory, directory_file_name):
4026 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4027 Now static.
2893f146
PE
4028 (file_name_as_directory): Use const pointers when appropriate.
4029 (Fexpand_file_name): Likewise. In particular, newdir might
4030 point at constant storage, so make it a const pointer.
fd4ead52 4031 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4032 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4033 signedness issues.
f839df0c
PE
4034 (Fset_file_times, Finsert_file_contents, auto_save_error):
4035 Rename locals to avoid shadowing.
f14b7e14 4036
5716756e 4037 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4038 (Ftry_completion, Fall_completions): Rename or remove locals
4039 to avoid shadowing.
5716756e 4040
b4c3046a
PE
4041 * marker.c (bytepos_to_charpos): Remove; unused.
4042
b45db522
PE
4043 * lisp.h (verify_bytepos, count_markers): New decls,
4044 so that gcc does not warn that these functions aren't declared.
4045
85876d07
PE
4046 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4047 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4048 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4049 (copy_text): Remove unused local var.
85876d07 4050
03d78a21 4051 * filelock.c (within_one_second): Now static.
b3dd38ab 4052 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4053
5df8f01b
PE
4054 * buffer.c (fix_overlays_before): Mark locals as initialized.
4055 (fix_start_end_in_overlays): Likewise. This function should be
4056 simplified by using pointers-to-pointers, but that's a different
4057 matter.
b1d876f1 4058 (switch_to_buffer_1): Now static.
8f54f30a
PE
4059 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4060 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4061
a70072c9 4062 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4063 Fix pointer signedness issue.
edced198
PE
4064 (sys_subshell): Mark local as volatile if checking for lint,
4065 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4066 (MAXPATHLEN): Define only if needed.
a70072c9 4067
a0977c44
PE
4068 * process.c (serial_open, serial_configure): Move decls from here ...
4069 * systty.h: ... to here, so that they can be checked.
4070
a884fdcc
PE
4071 * fns.c (get_random, seed_random): Move extern decls from here ...
4072 * lisp.h: ... to here, so that they can be checked.
4073
604efe86 4074 * sysdep.c (reset_io): Now static.
b8950c94 4075 (wait_for_termination_signal): Remove; unused.
604efe86 4076
38fc62d9
PE
4077 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4078 (copy_keymap_item, append_key, push_text_char_description):
4079 Now static.
1004a21a 4080 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4081 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4082 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4083 (describe_map_tree):
4084 Rename locals to avoid shadowing.
38fc62d9 4085
2f2650da
PE
4086 * keyboard.c: Declare functions static if they are not used elsewhere.
4087 (echo_char, echo_dash, cmd_error, top_level_2):
4088 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4089 (read_char, kbd_buffer_get_event, make_lispy_position):
4090 (make_lispy_event, make_lispy_movement, apply_modifiers):
4091 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4092 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4093 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4094 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4095 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4096
a053e86c 4097 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4098 (mark_kboards): Move decl here ...
4099 * alloc.c (mark_kboards): ... from here.
a053e86c 4100
4752793e
PE
4101 * lisp.h (force_auto_save_soon): New decl.
4102
74f10ca7 4103 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4104 (DEFINE_DUMMY_FUNCTION): New macro.
4105 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4106 Use it.
c03cd23f
PE
4107 (main): Add casts to avoid warnings
4108 if GCC considers string literals to be constants.
74f10ca7 4109
022e70d4
PE
4110 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4111
59d6fe83
PE
4112 * dbusbind.c: Pointer signedness fixes.
4113 (xd_signature, xd_append_arg, xd_initialize):
4114 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4115 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4116 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4117 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4118
78320123
PE
4119 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4120 if GCC considers string literals to be constants.
49cebcca 4121 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4122
35ac2a97
SM
41232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4124
fb103ca9
SM
4125 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4126 (print_preprocess, print_object): New macro to fix last change.
4127
35ac2a97
SM
4128 * print.c (print_preprocess): Don't forget font objects.
4129
62973b41
JB
41302011-03-16 Juanma Barranquero <lekktu@gmail.com>
4131
4132 * emacs.c (USAGE3): Doc fixes.
4133
0e48bb22
AS
41342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4135
4136 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4137 structure.
4138
7684e57b
JB
41392011-03-14 Juanma Barranquero <lekktu@gmail.com>
4140
4141 * lisp.h (VWindow_system, Qfile_name_history):
4142 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4143 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4144 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4145
4146 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4147 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4148
4149 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4150 * w32console.c (detect_input_pending, read_input_pending)
4151 (encode_terminal_code):
4152 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4153 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4154 (w32_system_caret_y, Qfile_name_history):
4155 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4156 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4157 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4158 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4159 * w32proc.c (Qlocal, report_file_error):
4160 * w32term.c (Vwindow_system, updating_frame):
4161 * w32uniscribe.c (initialized, uniscribe_font_driver):
4162 Remove unneeded extern declarations.
4163
2aa46d6c
CY
41642011-03-14 Chong Yidong <cyd@stupidchicken.com>
4165
c96bbc66 4166 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4167
cffc6f3b
CY
41682011-03-13 Chong Yidong <cyd@stupidchicken.com>
4169
4170 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4171 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4172 These macros can no longer be used for assignment.
4173
44f230aa
SM
4174 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4175 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4176 (record_buffer_markers, fetch_buffer_markers): New functions for
4177 recording and fetching special buffer markers.
4178 (set_buffer_internal_1, set_buffer_temp): Use them.
4179
4180 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4181
4182 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4183
4184 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4185 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4186
4187 * xdisp.c (hscroll_window_tree):
4188 (reconsider_clip_changes): Use PT instead of BUF_PT.
4189
d251f04b
EZ
41902011-03-13 Eli Zaretskii <eliz@gnu.org>
4191
4192 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4193 $(EMACS_ROOT)/lib/intprops.h.
4194
f0c77cd1
PE
41952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4196
3eca4629
PE
4197 Fix more problems found by GCC 4.5.2's static checks.
4198
7c86ee98
PE
4199 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4200 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4201 (xg_free_frame_widgets): Make it clear that a local variable is
4202 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4203 (gdk_window_get_screen): Make it clear that this macro is needed
4204 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4205 (int_gtk_range_get_value): New function, which avoids a diagnostic
4206 from gcc -Wbad-function-cast.
4207 (xg_set_toolkit_scroll_bar_thumb): Use it.
4208 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4209 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4210 (get_utf8_string, xg_get_file_with_chooser):
4211 Rename locals to avoid shadowing.
4212 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4213
41729b81
PE
4214 * xgselect.c (xg_select): Remove unused var.
4215
f0c77cd1
PE
4216 * image.c (four_corners_best): Mark locals as initialized.
4217 (gif_load): Initialize transparent_p to zero (Bug#8238).
4218 Mark another local as initialized.
ec6cf4c6 4219 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4220
ce0ad53d 4221 * image.c (clear_image_cache): Now static.
d5d5a617 4222 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4223 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4224 (x_edge_detection): Remove unnecessary cast that
4225 gcc -Wbad-function-cast diagnoses.
2037898d 4226 (gif_load): Fix pointer signedness.
6ae141d6
PE
4227 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4228 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4229
33383987 42302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4231
d32df629
PE
4232 Improve quality of tests for time stamp overflow.
4233 For example, without this patch (encode-time 0 0 0 1 1
4234 1152921504606846976) returns the obviously-bogus value (-948597
4235 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4236 reports time overflow. See
4237 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4238 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4239 * editfns.c: Include limits.h and intprops.h.
4240 (TIME_T_MIN, TIME_T_MAX): New macros.
4241 (time_overflow): Move earlier, to before first use.
4242 (hi_time, lo_time): New functions, for an accurate test for
4243 out-of-range times.
4244 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4245 (Fget_internal_run_time): Don't assume time_t fits in int.
4246 (make_time): Use list2 instead of Fcons twice.
4247 (Fdecode_time): More accurate test for out-of-range times.
4248 (check_tm_member): New function.
4249 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4250 (lisp_time_argument): Don't rely on undefined left-shift and
4251 right-shift behavior when checking for time stamp overflow.
8be6f318 4252
fe31d94c
PE
4253 * editfns.c (time_overflow): New function, refactoring common code.
4254 (Fformat_time_string, Fdecode_time, Fencode_time):
4255 (Fcurrent_time_string): Use it.
4256
8be6f318
PE
4257 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4258 * dired.c (make_time): Move to ...
4259 * editfns.c (make_time): ... here.
4260 * systime.h: Note the move.
4261
09d9db2c 42622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4263
126bc0dc
YM
4264 * fringe.c (update_window_fringes): Remove unused variables.
4265
c47cbdfd
YM
4266 * unexmacosx.c (copy_data_segment): Also copy __got section.
4267 (Bug#8223)
4268
7ac80be9
EZ
42692011-03-12 Eli Zaretskii <eliz@gnu.org>
4270
c96bbc66 4271 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4272 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4273 Constify `char *' arguments and their references according to
4274 prototypes in tparam.h.
4275
ecb0f94d 4276 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4277
7ac80be9
EZ
4278 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4279 Adapt all references accordingly.
4280
4281 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4282
ef1fd07e
TT
42832011-03-11 Tom Tromey <tromey@redhat.com>
4284
4285 * buffer.c (syms_of_buffer): Remove obsolete comment.
4286
7ef4b50c
EZ
42872011-03-11 Eli Zaretskii <eliz@gnu.org>
4288
4289 * termhooks.h (encode_terminal_code): Declare prototype.
4290
4291 * msdos.c (encode_terminal_code): Don't declare prototype.
4292
4293 * term.c (encode_terminal_code): Now external again, used by
4294 w32console.c and msdos.c.
4295
44f230aa
SM
4296 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4297 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4298
4b1ec863 42992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4300
1714f52b 4301 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4302
4b1ec863
PE
4303 * fringe.c (update_window_fringes): Mark locals as initialized
4304 (Bug#8227).
4305 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4306
524c7aa6
PE
4307 * alloc.c (mark_fringe_data): Move decl from here ...
4308 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4309 to check its interface.
4310 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4311
a5c0af81 4312 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4313 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4314 (fontset_font): Mark local as initialized.
a9a06e0b 4315 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4316
b4716021
PE
4317 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4318
811e9bac 4319 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4320 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4321 (x_own_selection, Fx_disown_selection_internal): Rename locals
4322 to avoid shadowing.
4323 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4324
7e3ab302
PE
4325 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4326 so that the caller can use some name other than gcpro1.
4327 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4328 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4329 (Fx_backspace_delete_keys_p):
4330 Use them to avoid shadowing, and rename vars to avoid shadowing.
4331 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4332 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4333 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4334 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4335 Remove unused locals.
7e3ab302
PE
4336 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4337 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4338 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4339 macros.
f78faa98 4340
e2b13473
PE
4341 * xterm.h (x_mouse_leave): New decl.
4342
77f23912
PE
4343 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4344 Remove unused functions.
cdf4ba58
PE
4345 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4346 (x_calc_absolute_position): Now static.
7411c686 4347 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4348 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4349 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4350 unless they are used.
38d0b34a
PE
4351 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4352 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4353 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4354 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4355 (x_error_catcher, x_connection_closed, x_error_handler):
4356 (x_error_quitter, xembed_send_message, x_iconify_frame):
4357 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4358 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4359 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4360
44f230aa
SM
4361 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4362 Rename or move locals to avoid shadowing.
6b463e58 4363 (tty_defined_color, merge_face_heights): Now static.
5967d051 4364 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4365 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4366 does not deduce is never used uninitialized.
73719eba
PE
4367 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4368 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4369
426994c3 4370 * terminal.c (store_terminal_param): Now static.
5489860b 4371
032f1620 4372 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4373 (set_frame_menubar): Remove unused local.
d4323972 4374 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4375 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4376 since they might point to immutable storage.
281585b0
PE
4377 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4378 since it's unused otherwise.
032f1620 4379
367c19e5 4380 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4381 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4382 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4383 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4384 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4385 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4386 does not deduce are never used uninitialized.
70739cbe 4387
07b48fa9
PE
4388 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4389
8868a238 4390 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4391 * window.c (window_loop, size_window):
4392 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4393
7e5cf297 4394 * window.c (display_buffer): Now static.
d6550a9f
PE
4395 (size_window): Mark variables that gcc -Wuninitialized
4396 does not deduce are never used uninitialized.
a586633d
PE
4397 * window.h (check_all_windows): New decl, to forestall
4398 gcc -Wmissing-prototypes diagnostic.
5b555da1 4399 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4400
f6095868
PE
4401 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4402 shadowing.
4403 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4404 Include <limits.h>.
4405 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4406 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4407 (load_charset_map): Mark variables that gcc -Wuninitialized
4408 does not deduce are never used uninitialized.
53df7c11 4409 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4410
f38b440c
PE
4411 * coding.c (coding_set_source, coding_set_destination):
4412 Use "else { /* comment */ }" rather than "else /* comment */;"
4413 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4414 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4415 a block, when the outer 'i' will do.
4416 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4417 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4418 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4419 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4420 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4421 Rename locals to avoid shadowing.
4422 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4423 * coding.c (emacs_mule_char, encode_invocation_designation):
4424 Now static, since they're not used elsewhere.
413bb2db 4425 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4426 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4427 (decode_coding_emacs_mule): Mark variables that gcc
4428 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4429 (detect_coding_iso_2022): Initialize a local variable that might
4430 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4431 this initialization is needed. (Bug#8211)
5f58e762
PE
4432 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4433 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4434 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4435 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4436 Remove unused macros.
f38b440c 4437
232b38b9 4438 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4439 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4440 * character.c (string_count_byte8): Likewise.
232b38b9 4441
fb90da1b
PE
4442 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4443 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4444
fb93dbc2
PE
4445 * chartab.c (copy_sub_char_table): Now static, since it's not used
4446 elsewhere.
5c156ace
PE
4447 (sub_char_table_ref_and_range, char_table_ref_and_range):
4448 Rename locals to avoid shadowing.
bbcd0949 4449 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4450
7d3b3862 4451 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4452 (BIDI_BOB): Remove unused macro.
7d3b3862 4453
6be7d3da
PE
4454 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4455 deduce are never used uninitialized.
c2ed9c8b 4456 * term.c (encode_terminal_code): Likewise.
6be7d3da 4457
75f8807f 4458 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4459
50938595
PE
4460 * tparam.h: New file.
4461 * term.c, tparam.h: Include it.
4462 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4463 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4464 Move these decls to tparam.h, and make them agree with what
4465 is actually in tparam.c. The previous trick of using incompatible
4466 decls in different modules does not conform to the C standard.
4467 All callers of tparam changed to use tparam's actual API.
4468 * tparam.c (tparam1, tparam, tgoto):
4469 Use const pointers where appropriate.
4470
fbceeba2
PE
4471 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4472 * cm.h (struct cm): Likewise.
4473 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4474 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4475 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4476 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4477 (turn_on_face, init_tty): Likewise.
4478 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4479
7f3f1250
PE
4480 * term.c (term_mouse_position): Rename local to avoid shadowing.
4481
e6ca6543
PE
4482 * alloc.c (mark_ttys): Move decl from here ...
4483 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4484
c40f8d15
AS
44852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4486
4487 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4488
cfe0661d
JB
44892011-03-09 Juanma Barranquero <lekktu@gmail.com>
4490
4491 * search.c (compile_pattern_1): Remove argument regp, unused since
4492 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4493 (compile_pattern): Don't pass it.
4494
0afb4571
J
44952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4496
4497 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4498 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4499 for ! HAVE_GTK3.
4500 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4501
4502 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4503
4504 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4505 gdk_window_get_screen, gdk_window_get_geometry,
4506 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4507 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4508 (xg_get_pixbuf_from_pixmap): New function.
4509 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4510 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4511 Call xg_get_pixbuf_from_pixmap instead of
4512 gdk_pixbuf_get_from_drawable.
4513 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4514 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4515 (xg_check_special_colors): Use GtkStyleContext and its functions
4516 for HAVE_GTK3.
4517 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4518 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4519 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4520 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4521 Call gtk_widget_get_preferred_size.
0afb4571
J
4522 (xg_frame_resized): gdk_window_get_geometry only takes 5
4523 parameters.
44f230aa
SM
4524 (xg_win_to_widget, xg_event_is_for_menubar):
4525 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4526 (xg_set_widget_bg): New function.
4527 (delete_cb): New function.
895009e1 4528 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4529 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4530 (xg_set_background_color): Call xg_set_widget_bg.
4531 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4532 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4533 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4534 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4535 if ! HAVE_GTK3.
4536 (update_frame_tool_bar): Call gtk_widget_hide.
4537 (xg_initialize): Use GDK_KEY_g.
4538
4539 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4540 if ! HAVE_GTK3
4541 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4542
4543 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4544 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4545 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4546
1c2cc4ef
JB
45472011-03-08 Juanma Barranquero <lekktu@gmail.com>
4548
4549 * w32xfns.c (select_palette): Check success of RealizePalette against
4550 GDI_ERROR, not zero.
4551
33383987 4552See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4553
4554;; Local Variables:
4555;; coding: utf-8
aac0c6e3
MR
4556;; End:
4557
33383987 4558 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4559
4560 This file is part of GNU Emacs.
4561
4562 GNU Emacs is free software: you can redistribute it and/or modify
4563 it under the terms of the GNU General Public License as published by
4564 the Free Software Foundation, either version 3 of the License, or
4565 (at your option) any later version.
4566
4567 GNU Emacs is distributed in the hope that it will be useful,
4568 but WITHOUT ANY WARRANTY; without even the implied warranty of
4569 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4570 GNU General Public License for more details.
4571
4572 You should have received a copy of the GNU General Public License
4573 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.