Use an include file in configure.ac's AH_BOTTOM
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b429a4ee
GM
12012-07-30 Glenn Morris <rgm@gnu.org>
2
3 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
4 * Makefile.in (config_h): Add conf_post.h.
5 * makefile.w32-in (CONFIG_H): Add conf_post.h.
6
adff3182
JD
72012-07-30 Jan Djärv <jan.h.d@swipnet.se>
8
9 * nsterm.m (ns_do_open_file): New variable.
10 (ns_term_init): Set ns_do_open_file to NO after run returns.
11 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
12 files only if ns_do_open_file.
13
c32af1e4
PE
142012-07-30 Paul Eggert <eggert@cs.ucla.edu>
15
7393bcbb
PE
16 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
17 This no-op macro hasn't been needed for many years.
18 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
19
c32af1e4
PE
20 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
21 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
22 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
23 gdb_make_enums_visible.
24 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
25 (DIRECTORY_SEP): Now a constant, not a macro.
26
302fc036
EZ
272012-07-30 Eli Zaretskii <eliz@gnu.org>
28
29 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
30 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
31
32 * w32term.c <w32_keyboard_codepage>: Renamed from
33 keyboard_codepage and now external. All users changed.
34
35 * w32term.h: Add declaration of w32_keyboard_codepage.
36
37 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
38 the codepage to translate keys to Unicode. If this argument is
39 -1, use the value returned by GetConsoleCP. All callers changed.
40
88fb40b4
PE
412012-07-30 Paul Eggert <eggert@cs.ucla.edu>
42
0aee6912
PE
43 Update .PHONY listings in makefiles.
44 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
45 bootstrap-clean, distclean, maintainer-clean, versioclean,
46 extraclean, frc.
47
88fb40b4
PE
48 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
49 This is a bit clearer. Fix some commentary typos.
50
0a763bd1
GM
512012-07-30 Glenn Morris <rgm@gnu.org>
52
32bac6d6
GM
53 * s/netbsd.h: Let configure include signal.h if needed.
54 Remove file, which is now empty.
55
b65e7c46
GM
56 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
57 Let configure set them.
58 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
59 No more need to undefine.
0a763bd1 60
169304bd
AS
612012-07-30 Andreas Schwab <schwab@linux-m68k.org>
62
63 * keymap.c (Fkey_description): Don't remove 0x80 bit from
64 non-single-byte char when adding meta modifier. (Bug#12090)
65
6cd7a139
DA
662012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
67
68 Convert safe_call to use variable number of arguments.
69 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
70 (safe_call2): Fix comment.
71 * lisp.h (safe_call): Adjust prototype.
72 * coding.c (encode_coding_object): Change to use safe_call2.
73 * xfaces.c (merge_face_heights): Change to use safe_call1.
74
d34d6ffc
GM
752012-07-30 Glenn Morris <rgm@gnu.org>
76
7b8a48e4 77 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 78 does that unconditionally. Remove file, which is now empty.
7b8a48e4 79
d34d6ffc
GM
80 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
81 Remove empty files.
82
03a660a6
PE
832012-07-30 Paul Eggert <eggert@cs.ucla.edu>
84
85 Export to GDB most of lisp.h's remaining object-like macros.
86 * lisp.h (min, max): Move earlier, because they're used earlier now.
87 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
88 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
89 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
90 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
91 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
92 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
93 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
94 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
95 Now constants, for GDB. They need not be macros.
96 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
97 Now constants, for GDB, as well as macros, for static initializers.
98 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
99 Move to after the definition of struct Lisp_Char_Table,
100 since the former now needs that type defined.
101 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
102 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
103 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
104 New enums, for gdb_make_enums_visible.
105 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 106 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
107 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
108 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
109 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
110 enum maxargs, enum MAX_ALLOCA.
111 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
112 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
113 no longer needed, now that they are done in lisp.h.
114
e499d0ee
DA
1152012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
116
117 Cleanup string bytes checking.
118 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
119 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
120 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
121 (check_sblock, compact_small_strings): Simplify.
122
d5040d2d
PE
1232012-07-29 Paul Eggert <eggert@cs.ucla.edu>
124
125 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
126 These macros are confusing and no longer need to be defined, as
127 the enum values now suffice. All uses replaced with definiens.
128 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
129
7f259ae6
JB
1302012-07-29 Juanma Barranquero <lekktu@gmail.com>
131
132 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
133 ($(BLD)/w32console.$(O)): Update dependencies.
134
7e63e0c3
DA
1352012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
136
137 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
138 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
139 time. Adjust users.
140 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
141
ffd817eb
JD
1422012-07-29 Jan Djärv <jan.h.d@swipnet.se>
143
144 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
145 setting sitelisp (Bug#12010).
146
417a7a0e
EZ
1472012-07-29 Eli Zaretskii <eliz@gnu.org>
148
149 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
150
151 * w32heap.c (cache_system_info):
152 * w32.c (sys_rename):
153 * w32proc.c (find_child_console, sys_kill): All users changed.
154
387d4d92
PE
1552012-07-29 Paul Eggert <eggert@cs.ucla.edu>
156
157 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
158
55a6cca6
EZ
1592012-07-29 Eli Zaretskii <eliz@gnu.org>
160
161 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
162
dbcf001c
DA
1632012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
164
165 Cleanup statistics calculation in Fgarbage_collect.
166 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
167 zombies percentage calculation. Simplify elapsed time calculation.
168
e2688e4a
DA
1692012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
170
171 Generalize marker debugging code under MARKER_DEBUG and use eassert.
172 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
173 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
174 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
175 (replace_range, replace_range_2, del_range_2): Change to eassert.
176 * marker.c (byte_char_debug_check): Adjust style.
177
b46a6a83
PE
1782012-07-29 Paul Eggert <eggert@cs.ucla.edu>
179
180 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
181 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
182 long-ago-commented-out code that talks about "WIN32".
183 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
184 All uses changed.
185
e32a5799
PE
1862012-07-28 Paul Eggert <eggert@cs.ucla.edu>
187
188 Use Gnulib stdalign module (Bug#9772, Bug#9960).
189 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
190 Simplify by using alignof.
191 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
192 * lisp.h: Include <stdalign.h>.
193 (GCALIGNMENT): New macro and constant.
194 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
195 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
196 (stdalign): New macro, if not already defined.
197
df81cd29
EZ
1982012-07-28 Eli Zaretskii <eliz@gnu.org>
199
01bd1b0d
EZ
200 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
201 * w32inevt.c: Include w32inevt.h.
202 (w32_read_console_input): New inline function, calls either
203 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
204 w32_console_unicode_input.
205 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
206 (w32_kbd_patch_key, key_event): Use the codepage returned by
207 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
208 (key_event): use uChar.UnicodeChar only if
209 w32_console_unicode_input is non-zero.
210
211 * w32console.c: Include w32heap.h.
212 <w32_console_unicode_input>: New global variable.
213 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
214 family of Windows, zero otherwise.
215
216 * w32inevt.h: Declare w32_console_unicode_input.
217
df81cd29
EZ
218 * xdisp.c (init_iterator): Don't reference tip_frame in a build
219 --without-x. (Bug#11742)
220
c20fdd9e
PE
2212012-07-27 Paul Eggert <eggert@cs.ucla.edu>
222
223 Adjust GDB to reflect pvec_type changes (Bug#12036).
224 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
225 2012-07-04 changes to pseudovector representation. Problem
226 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
227
32770973 2282012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
229
230 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
231 bus address.
232 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
233
3438fe21
EZ
2342012-07-27 Eli Zaretskii <eliz@gnu.org>
235
bcfbc9de
EZ
236 * alloc.c (listn): Fix the order the arguments are consed onto the
237 list.
238
3438fe21
EZ
239 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
240 enumeration constants, as PURE and HEAP are too general, and clash
241 with other headers and sources, such as gmalloc.c and the
242 MS-Windows system headers. All users changed.
243
eeaea515
DA
2442012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Revert last save_excursion_save and save_excursion_restore changes.
247 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
248 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
249
073c88c2
DA
2502012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
251
252 Fix recently-introduced typos in Windows port.
253 Reported by Martin Rudalics <rudalics@gmx.at>.
254 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 255 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 256
4706125e
PE
2572012-07-27 Paul Eggert <eggert@cs.ucla.edu>
258
259 Improve GDB symbol export (Bug#12036).
260 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
261 arms of an 'if', not using conditional expressions; otherwise GDB
262 complains about the types in the unevaluated arm when the argument
263 is an integer literal.
264 (xgetint): Simplify expression.
265 * alloc.c (gdb_make_enums_visible): New constant. This ports to
266 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
267 Zaretskii in <http://bugs.gnu.org/12036#13>.
268 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
269 needed now that we have gdb_make_enums_visible.
270 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
271 (enum enum_USE_LSB_TAG):
272 New enum types, packaging up enums that need to be exported to GDB.
273
694b6c97
DA
2742012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
275
276 Utility function to make a list from specified amount of objects.
277 * lisp.h (enum constype): New datatype.
278 (listn): New prototype.
279 * alloc.c (listn): New function.
280 (Fmemory_use_count, syms_of_alloc): Use it.
281 * buffer.c (syms_of_buffer): Likewise.
282 * callint.c (syms_of_callint): Likewise.
283 * charset.c (define_charset_internal): Likewise.
284 * coding.c (syms_of_coding): Likewise.
285 * keymap.c (syms_of_keymap): Likewise.
286 * search.c (syms_of_search): Likewise.
287 * syntax.c (syms_of_syntax): Likewise.
288 * w32.c (init_environment): Likewise.
289 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
290 * xdisp.c (syms_of_xdisp): Likewise.
291 * xfns.c (syms_of_xfns): Likewise.
292
6195f384
DA
2932012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
294
295 Fast save_excursion_save and save_excursion_restore.
296 * lisp.h (struct Lisp_Excursion): New data type.
297 (PVEC_EXCURSION): New pseudovector type.
298 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
299 to deal with it. Adjust comments.
300 (init_marker, attach_marker): New prototype.
301 (unchain_marker): Adjust prototype.
302 * marker.c (attach_marker): Change to global.
303 (init_marker): New function.
304 * alloc.c (Fmake_marker, build_marker): Use it.
305 (build_marker): More easserts.
306 (mark_object): Handle struct Lisp_Excursion.
307 * editfns.c (save_excursion_save, save_excursion_restore):
308 Reimplement to use struct Lisp_Excursion. Add comments.
309
5eceb8fb
PE
3102012-07-26 Paul Eggert <eggert@cs.ucla.edu>
311
312 Fix export of symbols to GDB (Bug#12036).
313 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
314 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
315 emacs.c, as this is a more-suitable home. Had this been done earlier
316 the fix for 12036 would have avoided some of the problems noted in
317 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
318 would have been more obvious.
562157c8
PE
319 * emacs.c: Do not include <verify.h>; no longer needed.
320 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
321 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
322 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
323 Remove; now done in lisp.h.
324 * lisp.h (PUBLISH_TO_GDB): New macro.
325 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
326 (DATA_SEG_BITS): Use it.
327 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
328 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
329 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
330 not be usable in #if. This simplifies things.
331
d6749401
JB
3322012-07-26 Juanma Barranquero <lekktu@gmail.com>
333
334 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
335
1781b9e9
PE
3362012-07-26 Paul Eggert <eggert@cs.ucla.edu>
337
d89518db 338 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
339 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
340 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
341 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
342 Adjust to changes in lisp.h and emacs.c, by using
343 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
344 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
345 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
346 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
347 instead of gdb_valbits.
348 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
349 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
350 instead of gdb_array_mark_flag.
351 (xboolvector): Get size from $->size, not $->header.size.
352 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
353 (xreload, hook-run, hookpost-run): Remove.
354 * emacs.c: Include <verify.h>.
355 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
356 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
357 Remove.
358 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
359 (gdb_USE_LSB_TAG): New enum constants.
360 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
361 Also define these as enum constants, so they're visible to GDB.
362 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
363 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
364 as constants, so they're visible to GDB.
365 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
366 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
367 Now enum constants, not macros, so they're visible to GDB.
368 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
369 more convenient now. All uses changed.
370 (VALMASK) [USE_LSB_TAG]: Also define in this case.
371 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
372
3628596a
DA
3732012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
374
375 Explicitly free restriction data that are not needed anymore.
376 * editfns.c (save_restriction_restore): Free restriction data.
377
7abaf5cc
SM
3782012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
379
380 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
381 add argument, tune behavior, and adjust all callers.
382
71f88e00
PE
3832012-07-25 Paul Eggert <eggert@cs.ucla.edu>
384
385 Use typedef for EMACS_INT, EMACS_UINT.
386 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
387 than macros. This simplifies debugging in the usual case, since
388 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
389 and it allows expressions involving EMACS_INT casts.
390 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
391
57ec3034
JD
3922012-07-25 Jan Djärv <jan.h.d@swipnet.se>
393
394 * nsterm.m (ns_read_socket): Return early if there is a modal
395 window (Bug#12043).
396
8137e7b3
MR
3972012-07-25 Martin Rudalics <rudalics@gmx.at>
398
399 * frame.c (Fredirect_frame_focus): In doc-string don't mention
400 that FOCUS-FRAME can be omitted.
401
04e9897c
DA
4022012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
403
404 Adjust buffer text indirection counters at the end of Fkill_buffer.
405 * buffer.c (Fkill_buffer): Adjust indirection counters when the
406 buffer is definitely dead. This should really fix an issue reported
407 by Christoph Scholtes again. (Bug#12007).
408 (init_buffer_once): Initialize indirection counters of
409 buffer_defaults and buffer_local_symbols (for sanity and safety).
410
8a0484e1
EZ
4112012-07-24 Eli Zaretskii <eliz@gnu.org>
412
413 * xdisp.c (init_iterator): Don't compute dimensions of truncation
414 and continuation glyphs on tooltip frames, leave them at zero.
415 Avoids continued lines in tooltips. (Bug#11832)
416
fa691a83
DA
4172012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
418
419 Simplify copy_overlay.
04e9897c 420 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
421 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
422
436bc8e0
EZ
4232012-07-23 Eli Zaretskii <eliz@gnu.org>
424
425 * print.c (print_object): Don't crash when a frame's name is nil
426 or invalid. (Bug#12025)
427
428 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
429 it signals an error when a tooltip frame is being created.
430
d7a7fda3
DA
4312012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
432
433 Cleanup miscellaneous objects allocation and initialization.
434 * alloc.c (allocate_misc): Change to static. Add argument to
435 specify the subtype. Adjust comment and users.
436 (build_overlay): New function.
437 * buffer.c (copy_overlays, Fmake_overlay): Use it.
438 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
439 (allocate_misc): Remove prototype.
440 (build_overlay): Add prototype.
441
4422012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
443
444 Swap buffer text indirection counters in Fbuffer_swap_text.
445 * buffer.c (Fbuffer_swap_text): Swap indirections too.
446 This avoids crash reported by Christoph Scholtes at
447 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
448
9d7fa573
JD
4492012-07-22 Jan Djärv <jan.h.d@swipnet.se>
450
451 * nsmenu.m (Popdown_data): New struct.
452 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
453 free Popdown_data.
454 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
455 (initWithContentRect): Make imgView and contentView non-static
456 and autorelease them. Also autorelease img and matrix (Bug#12005).
457 (dealloc): Remove (Bug#12005).
458
0dd6d66d
DA
4592012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
460
461 Adjust consing_since_gc when objects are explicitly freed.
462 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
463 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
464 (free_cons, free_misc): Subtract object size from consing_since_gc.
465
d36d71df
DA
4662012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
467
468 Simplify and cleanup markers positioning code.
469 * marker.c (attach_marker): More useful eassert.
470 (live_buffer, set_marker_internal): New function.
471 (Fset_marker, set_marker_restricted): Use set_marker_internal.
472 (set_marker_both, set_marker_restricted_both): Use live_buffer.
473
fb9ea40f
PE
4742012-07-22 Paul Eggert <eggert@cs.ucla.edu>
475
476 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
477 as it's limited by the amount of memory, not by INT_MAX.
478
2d5c5f7d
EZ
4792012-07-21 Eli Zaretskii <eliz@gnu.org>
480
07fb592e
EZ
481 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
482 in special-event-map. See the discussion at
483 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
484 for the reasons.
485
37a9eac8 486 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
487 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
488 Fabrice Popineau <fabrice.popineau@supelec.fr>.
489
c4328746
JD
4902012-07-21 Jan Djärv <jan.h.d@swipnet.se>
491
492 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 493 (conversationIdentifier): Return value is NSInteger.
784051c4 494 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 495
6e5d1c12
CY
4962012-07-21 Chong Yidong <cyd@gnu.org>
497
498 * window.c (decode_any_window): Signal an error if the window is
499 on a dead frame (Bug#11984).
500
9928463d
DA
5012012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
502
503 Add indirection counting to speed up Fkill_buffer.
504 * buffer.h (struct buffer): New member.
505 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
506 (Fmake_indirect_buffer): Set indirection counter to -1, increment
507 base buffer indirection counter.
508 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
509 (Fkill_buffer): Adjust indirection counters as needed, don't walk
510 through buffer list if indirection counter is 0.
511
f8643a6b
DA
5122012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
513
514 Extend the value returned by Fgarbage_collect with heap statistics.
515 * alloc.c (Qheap): New symbol.
516 (syms_of_alloc): DEFSYM it.
517 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
518 (Fmemory_free): Remove.
519 (syms_of_alloc): Don't defsubr it.
520 * buffer.c (Fcompact_buffer): Remove.
521 (syms_of_buffer): Don't defsubr it.
522
dac616ff
DA
5232012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
524
525 Make maybe_gc inline.
526 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
527 * lisp.h (consing_since_gc, gc_relative_threshold)
528 (memory_full_cons_threshold): Revert declaration.
529 (maybe_gc): Remove prototype, define as inline.
530 * alloc.c: Remove old commented-out code.
531 (consing_since_gc, gc_relative_threshold)
532 (memory_full_cons_threshold): Revert to global.
533 (maybe_gc): Remove.
534
d7ea76b4
DA
5352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
538 * lisp.h (build_unibyte_string): New function.
539 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
540 * sysdep.c, w32fns.c, xfns.c: Use it.
541 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
542 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
543 Adjust users accordingly.
544 * font.h (font_open_by_name): Adjust prototype.
545
765e61e3
DA
5462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
547
548 Cleanup calls to Fgarbage_collect.
549 * lisp.h (maybe_gc): New prototype.
550 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
551 Remove declarations.
552 * alloc.c (maybe_gc): New function.
553 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
554 Make them static.
555 * bytecode.c (MAYBE_GC): Use maybe_gc.
556 * eval.c (eval_sub, Ffuncall): Likewise.
557 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
558 to avoid dependency from auto-save feature.
559
52b852c7
PE
5602012-07-19 Paul Eggert <eggert@cs.ucla.edu>
561
562 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
563 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
564 'for_each_per_buffer_object_at'.
565 All uses changed. It's better to use upper-case for macros that
566 cannot be implemented as functions, to give the reader a clue
567 that they're special.
568
5db81e33
SM
5692012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
570
571 * alloc.c (Fgarbage_collect): Tweak docstring.
572
5b835e1d
DA
5732012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
574
575 Tweak the value returned from Fgarbage_collect again.
576 * alloc.c (Fgarbage_collect): New return value, as confirmed in
577 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
578 Adjust documentation.
579 (total_vector_bytes): Rename to total_vector_slots, adjust
580 accounting.
581 (total_free_vector_bytes): Rename to total_free_vector_slots,
582 adjust accounting.
583 (Qstring_bytes, Qvector_slots): New symbols.
584 (syms_of_alloc): DEFSYM them.
585
9cd47b72
DA
5862012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
587
588 Buffer compaction primitive which may be used from Lisp.
589 * buffer.c (compact_buffer, Fcompact_buffer): New function.
590 (syms_of_buffer): Register Fcompact_buffer.
591 * alloc.c (Fgarbage_collect): Use compact_buffer.
592 * buffer.h (compact_buffer): New prototype.
593 (struct buffer_text): New member.
594
d17337e5
DA
5952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
596
597 New macro to iterate over all buffers, miscellaneous cleanups.
598 * lisp.h (all_buffers): Remove declaration.
599 * buffer.h (all_buffers): Add declaration, with comment.
600 (for_each_buffer): New macro.
601 * alloc.c (Fgarbage_collect, mark_object): Use it.
602 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
603 (init_buffer): Likewise.
604 * data.c (Fset_default): Likewise.
605 * coding.c (code_conversion_restore): Remove redundant check
606 for dead buffer.
607 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
608
60cfd278
AS
6092012-07-18 Andreas Schwab <schwab@linux-m68k.org>
610
611 Fix bug that created negative-length intervals.
612 * intervals.c (merge_interval_right, merge_interval_left):
613 Do not zero out this interval if it is absorbed by its children,
614 as this interval's total length doesn't change in that case. See
615 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
616
d06714cb
PE
6172012-07-18 Paul Eggert <eggert@cs.ucla.edu>
618
83713154
PE
619 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
620 when invoking (make-bool-vector N t) and N is a positive
621 multiple of 8 -- the last 8 bits were mistakenly cleared.
622
d06714cb
PE
623 Remove some struct layout assumptions in bool vectors.
624 * alloc.c (bool_header_size): New constant.
625 (header_size, word_size): Move earlier, as they're now used earlier.
626 Use 'word_size' in a few more places, where it's appropriate.
627 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
628 padding before the data member of a bool vector.
629 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
630 than doing the check by hand with an abort ().
631
464d5a5e
SM
6322012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
633
5fbc0409
SM
634 * eval.c (Fdefvar): Don't check constants since we only set the var if
635 it's not yet defined anyway (bug#11904).
636
464d5a5e
SM
637 * lisp.h (last_undo_boundary): Declare new var.
638 * keyboard.c (command_loop_1): Set it.
639 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
640 were auto-added by the command loop (bug#11774).
641
8dc2e44a
AS
6422012-07-18 Andreas Schwab <schwab@linux-m68k.org>
643
644 * w32font.c (Qsymbol): Remove local definition.
645 (syms_of_w32font): Don't DEFSYM it.
646
169925ec
DA
6472012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
648
649 Fix sweep_vectors to handle large bool vectors correctly.
650 * alloc.c (sweep_vectors): Account total_vector_bytes for
651 bool vectors larger than VBLOCK_BYTES_MAX.
652
5fbfb018
CY
6532012-07-18 Chong Yidong <cyd@gnu.org>
654
655 * frame.c (x_set_frame_parameters): Revert bogus change introduced
656 in 2012-05-25 commit by Paul Eggert (Bug#11738).
657
3ab6e069
DA
6582012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
659
660 Return more descriptive data from Fgarbage_collect.
661 Suggested by Stefan Monnier in
662 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
663 * alloc.c (bounded_number): New function.
664 (total_buffers, total_vectors): New variable.
665 (total_string_size): Rename to total_string_bytes, adjust users.
666 (total_vector_size): Rename to total_vector_bytes, adjust users.
667 (sweep_vectors): Account total_vectors and total_vector_bytes.
668 (Fgarbage_collect): New return value. Adjust documentation.
669 (gc_sweep): Account total_buffers.
670 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
671 (VECTOR_SIZE): Remove.
672 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
673 (Qinterval, Qmisc): New symbols.
674 (syms_of_data): Initialize them.
675 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
676 (Qcons, Qbuffer): New declarations.
677
6d02fe5b
PE
6782012-07-17 Paul Eggert <eggert@cs.ucla.edu>
679
680 * alloc.c (Fmemory_free): Account for memory-free's own storage.
681 Round up, not down. Improve doc.
682
b7ffe040
DA
6832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
684
685 Restore old code in allocate_string_data to avoid Faset breakage.
686 Reported by Julien Danjou <julien@danjou.info> in
687 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
688 * alloc.c (allocate_string_data): Restore old code with minor
689 adjustments, fix comment to explain this subtle issue.
690
4dc7c8d5
SM
6912012-07-17 Eli Zaretskii <eliz@gnu.org>
692
693 Remove FILE_SYSTEM_CASE.
694 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
695
696 * fileio.c (FILE_SYSTEM_CASE): Don't define.
697 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
698 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
699 call-process-region passes it through expand-file-name.
700
701 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
702
7032012-07-17 Andreas Schwab <schwab@linux-m68k.org>
704
705 Fix crash when creating indirect buffer (Bug#11917)
706 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
707 Don't handle unbound variables specially if non-zero.
708 (Fbuffer_local_variables): Pass zero.
709 (clone_per_buffer_values): Pass non-zero.
710
7112012-07-17 Andreas Schwab <schwab@linux-m68k.org>
712
713 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
714 to make the loop interruptible.
715
7162012-07-17 Andreas Schwab <schwab@linux-m68k.org>
717
718 * gnutls.c (emacs_gnutls_handshake): Only retry if
719 GNUTLS_E_INTERRUPTED.
720
cce7fefc
DA
7212012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
722
723 Cleanup and convert miscellaneous checks to eassert.
724 * alloc.c (mark_interval): Fix comment, partially rephrase
725 old comment from intervals.h (see below).
726 * intervals.c (find_interval, adjust_intervals_for_insertion)
727 (delete_interval, adjust_intervals_for_deletion)
728 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
729 Convert to eassert.
730 (adjust_intervals_for_insertion, make_new_interval):
731 Remove obsolete and unused code.
732 * intervals.h (struct interval): Remove obsolete comment.
733 * textprotp.c (erase_properties): Remove unused code.
734 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
735 (Fremove_list_of_text_properties): Convert to eassert.
736
9ea10cc3
CY
7372012-07-17 Chong Yidong <cyd@gnu.org>
738
739 * editfns.c (Finsert_char): Doc fix.
740
3900d5de
DA
7412012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
742
743 Fix previous change to make Fmemory_free always accurate.
744 * alloc.c (make_interval): Update total_free_intervals.
745 (make_float): Likewise for total_free_floats.
746 (free_cons, Fcons): Likewise for total_free_conses.
747 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
748 Likewise for total_free_vector_bytes.
749 (Fmake_symbol): Likewise for total_free_symbols.
750 (bytes_free): Remove.
751
7098646f
DA
7522012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
753
754 Simple free memory accounting feature.
755 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
756 (sweep_vectors): Accumulate size of free vectors.
757 (Fgarbage_collect): Setup bytes_free.
758 (Fmemory_free): New function.
759 (syms_of_alloc): Register it.
760
22657b40
DA
7612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
762
763 Cleanup overlays checking.
764 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
765 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
766 eassert and OVERLAYP.
767 (sort_overlays): Change to use OVERLAYP.
768
ddfc8813
RK
7692012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
770
771 * editfns.c (Finsert_char): Make it interactive, and make the
772 second arg optional. Copy interactive spec and docstring from
773 ucs-insert.
774
7c26cf3c
PE
7752012-07-17 Paul Eggert <eggert@cs.ucla.edu>
776
777 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
778 Unlike the other wrapped functions, fabs has an unspecified
779 effect on errno.
780
5d127af9
JD
7812012-07-16 Jan Djärv <jan.h.d@swipnet.se>
782
783 * nsterm.m (keyDown): Interpret flags without left/right bits
784 as the left key (Bug#11670).
785
6a0dd1d7
DA
7862012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Remove empty and useless init functions.
789 * lisp.h (init_character_once, init_fns, init_image)
790 (init_filelock, init_sound): Remove prototype.
791 * character.c (init_character_once): Remove.
792 * filelock.c (init_filelock): Likewise.
793 * fns.c (init_fns): Likewise.
794 * image.c (init_image): Likewise.
795 * sound.c (init_sound): Likewise.
796 * emacs.c (main): Adjust accordingly.
797
7a6136fd
DA
7982012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
799
800 * gtkutil.h: Tiny cleanups.
801 (use_old_gtk_file_dialog): Remove useless declaration.
802 (xg_uses_old_file_dialog): Add suggested const attribute.
803
ce811ad9
EZ
8042012-07-15 Eli Zaretskii <eliz@gnu.org>
805
806 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
807 (bidi_paragraph_init): Use it to limit search forward for a strong
808 directional character in abnormally large paragraphs full of
809 neutral or weak characters. (Bug#11943)
810
c9adfeaa
SF
8112012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
812
813 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
814 the toolbar (Bug#9451).
815 (xg_make_tool_item): Give the widget event box a transparent
816 background.
817
fff62aa9
DA
8182012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
819
820 Cleanup basic allocation variables and functions.
821 * alloc.c (ignore_warnings, init_intervals, init_float)
822 (init_cons, init_symbol, init_marker): Remove.
823 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
824 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
825 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
826 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
827 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
828 (staticidx, init_alloc_once, init_strings, free_ablock):
829 Remove redundant initialization.
830 * fns.c (init_weak_hash_tables): Remove.
831 * lisp.h (init_weak_hash_tables): Remove prototype.
832
9730daca
DA
8332012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
834
835 Use zero_vector where appropriate.
836 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
837 accordingly.
838 * lisp.h (zero_vector): New declaration.
839 * font.c (null_vector): Remove.
840 (syms_of_font): Remove initialization and staticpro.
841 (font_list_entities, font_find_for_lface): Change to use zero_vector.
842 * keymap.c (Faccessible_keymaps): Likewise.
843
2e2d2a13
LL
8442012-07-15 Leo Liu <sdl.web@gmail.com>
845
846 * fringe.c: Fix typo in comments.
847
cd276f6e
LL
8482012-07-14 Leo Liu <sdl.web@gmail.com>
849
850 * fringe.c: Add a new bitmap exclamation-mark.
851
5a1131d9
EZ
8522012-07-14 Eli Zaretskii <eliz@gnu.org>
853
854 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
855
856 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
857 (HAVE_MENUS): Don't define, defined by editing config.in with
858 msdos/sed2v2.inp.
859 (GMALLOC_INHIBIT_VALLOC): Don't define.
860 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
861
22e983b7
JB
8622012-07-14 Juanma Barranquero <lekktu@gmail.com>
863
864 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
865
5b3f250f
GM
8662012-07-14 Glenn Morris <rgm@gnu.org>
867
868 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
869 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
870 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
871
33d63ff4
GM
8722012-07-13 Glenn Morris <rgm@gnu.org>
873
5b633342
GM
874 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
875
33d63ff4
GM
876 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
877 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
878
b55b9f85
JD
8792012-07-13 Jan Djärv <jan.h.d@swipnet.se>
880
0dc8cf50
JD
881 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
882 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
883 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
884 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
885 where appropriate.
886 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
887 as boolean expression.
888 (x_set_window_size): Remove unused variable toolbar.
889 (ns_get_color_default, ns_mod_to_lisp): Remove.
890 (ns_mouse_position): Remove unused variables xchar and ychar.
891 (ns_compute_glyph_string_overhangs): Remove unused variable face.
892 (ns_set_vertical_scroll_bar): Remove unused variable count.
893 (ns_delete_terminal): Remove unused variable i.
894 (ns_term_init): Remove unused variables r, g and b.
895 (mouseDown): Remove unused variable window.
896 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
897 (initFrameFromEmacs): Remove unused variable vbextra.
898 (mouseEntered): Remove unused variables p and dpyinfo.
899 (mouseExited): Remove unused variables p and r.
900 (ns_define_frame_cursor, ns_clear_frame_area)
901 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
902 (menuDown): Assign [sender tag] to variable and cast the variable.
903
904 * nsterm.h (menuDown): Add id as type to argument sender.
905 (ns_display_info_for_name): Add Lisp_Object argument.
906 (ns_term_init): Add Lisp_Object argument.
907 (ns_map_event_to_object): Add void argument.
908 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
909 prototype with arguments and only declare if __OBJC__.
910 (nxatoms_of_nsselect): Add void argument.
911 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
912 (ns_alloc_autorelease_pool): Add void argument.
913 (ns_release_autorelease_pool): Add void* argument.
914 (ns_get_defaults_value): Add const char* argument.
915
916 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
917 (initFromContents): Use SSDATA where appropriate.
918 (ns_update_menubar): Add braces to ambigous if-else.
919 (initWithTitle): Put () around assignment in if statement.
920 (ns_menu_show): Remove unused variables window and keymap.
921 (update_frame_tool_bar): Remove unused variable selected_p.
922 (initWithContentRect): Remove unused variable this_cmd_name.
923
924 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
925 appropriate.
926 (setXBMColor): Remove unused variable len.
927 (setPixmapData): Put () around assignment in loop statement.
928
929 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
930 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
931 where appropriate.
932 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
933 around assignment in loop statement.
934 (nsfont_open): Remove unused variable i.
935 (nsfont_open): Remove unused variable len.
936 (nsfont_draw): Remove unused variable cs.
937
938 * nsfns.m (x_set_icon_name, ns_set_name_internal)
939 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
940 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
941 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
942 (Fns_font_name, Fns_perform_service)
943 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
944 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
945 (ns_set_name): Remove unused variable view.
946 (x_set_menu_bar_lines): Remove unused variable olines.
947 (x_set_tool_bar_lines): Remove unused variable root_window.
948 (Fns_list_colors): Put () around assignment in while statement.
949 (Fns_perform_service): Remove unused variable len.
950 (Fns_display_usable_bounds): Remove unused variable top.
951 (syms_of_nsfns): Remove unused variable i.
952
b55b9f85
JD
953 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
954 memcpy (Bug#11907).
955
ed9265fc 9562012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
957
958 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
959 and free it with DestroyExceptionInfo (Bug#11558).
960
ef099b57
JB
9612012-07-13 Juanma Barranquero <lekktu@gmail.com>
962
963 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
964 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
965 Set here, not in nt/config.nt.
966
ea814a5d
EZ
9672012-07-13 Eli Zaretskii <eliz@gnu.org>
968
969 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
970 cursor overflow into the last glyph on display line when the right
971 fringe is off. (Bug#11832)
972
1a952767
PE
9732012-07-13 Paul Eggert <eggert@cs.ucla.edu>
974
975 * xdisp.c (produce_special_glyphs): Now static.
976 * dispextern.h (produce_special_glyphs): Remove decl.
977
983188fd
GM
9782012-07-13 Glenn Morris <rgm@gnu.org>
979
32fb4bb6
GM
980 * s/bsd-common, s/cygwin.h: Remove empty files.
981 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
982
983188fd
GM
983 * s/usg5-4-common.h (USG, USG5):
984 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
985 * s/sol2-6.h (SOLARIS2):
986 * s/irix6-5.h (IRIX6_5):
987 * s/hpux10-20.h (USG, USG5, HPUX):
988 * s/gnu-linux.h (USG, GNU_LINUX):
989 * s/freebsd.h (BSD_SYSTEM):
990 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
991 * s/cygwin.h (CYGWIN):
992 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
993 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
994
d1e68667 9952012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
996
997 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 998
6de0e799
GM
9992012-07-13 Glenn Morris <rgm@gnu.org>
1000
739ae010
GM
1001 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1002
dbee5793
GM
1003 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1004
6de0e799
GM
1005 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1006 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1007
b82da769
GM
10082012-07-12 Glenn Morris <rgm@gnu.org>
1009
4fae5a7a 1010 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1011
1012 * process.c (init_process_emacs): Rename from init_process.
1013 The old name is also the name of a Mach system call.
1014 * lisp.h, emacs.c: Update for this name change.
1015 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1016 longer needed.
1017
5a979817
EZ
10182012-07-12 Eli Zaretskii <eliz@gnu.org>
1019
1020 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1021 memmove call that removes glyphs covered by the left truncation
1022 glyph. Improve commentary.
1023 (display_line): Fix display of continuation glyphs on GUI frames
1024 when the right fringe is turned off and variable-size fonts are
1025 used in the window. Move the code that appends a stretch glyph to
1026 produce_special_glyphs, so that it could be used for truncation
1027 and continuation glyphs alike.
1028 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1029 glyph of a suitably computed width, to align the special glyphs at
1030 the window margin. Code moved from display_line. (Bug#11832)
1031
3e91a053
GM
10322012-07-12 Glenn Morris <rgm@gnu.org>
1033
ba9e4b84
GM
1034 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1035
1036 * s/gnu-linux.h, s/hpux10-20.h:
1037 Do not unconditionally define HAVE_XRMSETDATABASE.
1038
3e91a053
GM
1039 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1040
b300b1f4
PE
10412012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1042
1043 Fix typos that broke OS X build.
1044 Reported by Randal L. Schwartz in
1045 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1046 * nsterm.m (ns_timeout): Add missing local decl.
1047 (ns_get_color): snprintf -> sprintf, to fix typo.
1048
6e777848
GM
10492012-07-12 Glenn Morris <rgm@gnu.org>
1050
3f922c37
GM
1051 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1052 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1053 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1054 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1055
0ab7b23a
GM
1056 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1057 Move PTY_OPEN to configure.
1058
6e777848
GM
1059 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1060 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1061 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1062
4a7edc24
DA
10632012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1064
1065 Use empty_unibyte_string where applicable.
1066 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1067 * lread.c (read1): Likewise.
1068 * xsettings.c (syms_of_xsettings): Likewise.
1069
308aab79
GM
10702012-07-12 Glenn Morris <rgm@gnu.org>
1071
42bd1719
GM
1072 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1073 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1074 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1075 * s/hpux10-20.h (RUN_TIME_REMAP):
1076 * s/bsd-common.h (TABDLY): Move to configure.
1077
1078 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1079
1080 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1081
ea0bbd17 1082 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1083 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1084
1085 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1086
308aab79
GM
1087 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1088 * s/template.h: Move NARROWPROTO to configure.
1089
ee1cf5cf
GM
10902012-07-11 Glenn Morris <rgm@gnu.org>
1091
30fe9bf4
GM
1092 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1093 unused since 2011-01-17 change to systty.h.
1094
ee1cf5cf
GM
1095 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1096 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1097 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1098
63e47e07
PE
10992012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1102
c43fb4c3
GM
11032012-07-11 Glenn Morris <rgm@gnu.org>
1104
1105 * s/darwin.h, s/gnu-linux.h, s/template.h:
1106 Move INTERRUPT_INPUT to configure.
1107
e8df9267
DA
11082012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1109
1110 Minor adjustments to interning code.
1111 * lisp.h (intern, intern_c_string): Redefine as static inline
1112 wrappers for intern_1 and intern_c_string_1, respectively.
1113 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1114 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1115 Vobarray checking.
e8df9267
DA
1116 * font.c (font_intern_prop): Likewise. Adjust comment.
1117 * w32font.c (intern_font_name): Likewise.
1118
34348bd4
AS
11192012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1120
d96a1e0c
AS
1121 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1122
34348bd4
AS
1123 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1124 of Fcar/Fcdr if possible.
1125 * font.c (check_otf_features): Likewise.
1126 * fontset.c (Fnew_fontset): Likewise.
1127 * gnutls.c (Fgnutls_boot): Likewise.
1128 * minibuf.c (read_minibuf): Likewise.
1129 * msdos.c (IT_set_frame_parameters): Likewise.
1130 * xmenu.c (Fx_popup_dialog): Likewise.
1131 * w32menu.c (Fx_popup_dialog): Likewise.
1132
c8add24e
GM
11332012-07-11 Glenn Morris <rgm@gnu.org>
1134
4b575b3c
GM
1135 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1136 since nothing has defined it on these platforms.
1137
09f4e3b0
GM
1138 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1139 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1140
172bedef
GM
1141 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1142 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1143 Move CLASH_DETECTION to configure.
1144
249685df
GM
1145 * s/gnu.h: Remove file, which is now empty.
1146
c8add24e
GM
1147 * s/gnu.h, s/gnu-linux.h:
1148 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1149
b41253a3
JW
11502012-07-11 John Wiegley <johnw@newartisans.com>
1151
1152 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1153 function attribute, so we only use it if it exists in the
1154 compiler.
1155
d923b542
DA
11562012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1157
1158 Avoid call to strlen in fast_c_string_match_ignore_case.
1159 * search.c (fast_c_string_match_ignore_case): Change to use
1160 length argument. Adjust users accordingly.
1161 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1162
5ebbef1d
PE
11632012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1164
bb352260
PE
1165 Assume mkdir, rmdir.
1166 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1167 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1168
57054ddd
PE
1169 Assume rename.
1170 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1171
b747d3f7
PE
1172 Assume perror.
1173 * s/hpux10-20.h (HAVE_PERROR): Remove.
1174 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1175 Remove dummy definition, as this problem was obsolete long ago.
1176
5ebbef1d
PE
1177 Assume strerror.
1178 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1179
984e7f30
DA
11802012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1181
1182 Avoid calls to strlen in font processing functions.
1183 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1184 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1185 users accordingly.
d923b542
DA
1186 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1187 Adjust prototypes.
1188 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1189 Change to return ptrdiff_t.
984e7f30
DA
1190 (xfont_list_pattern, xfont_match): Use length returned by
1191 xfont_decode_coding_xlfd.
1192 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1193
20e94fdd
GM
11942012-07-11 Glenn Morris <rgm@gnu.org>
1195
9d596af3
GM
1196 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1197 Move DONT_REOPEN_PTY to configure.
1198
20e94fdd
GM
1199 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1200 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1201
e99a530f
PE
12022012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1203
22ffb973
PE
1204 Remove "#define unix" that is no longer needed (Bug#11905).
1205 * s/aix4-2.h (unix): Remove; no longer needed.
1206
e9a9ae03
PE
1207 EMACS_TIME simplification (Bug#11875).
1208 This replaces macros (which typically do not work in GDB)
1209 with functions, typedefs and enums, making the code easier to debug.
1210 The functional style also makes code easier to read and maintain.
1211 * systime.h: Include <sys/time.h> on all hosts, not just if
1212 WINDOWSNT, since 'struct timeval' is needed in general.
1213 (EMACS_TIME): Now a typedef, not a macro.
1214 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1215 not macros.
1216 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1217 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1218 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1219 (EMACS_TIME_LE): Now functions, not macros.
1220 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1221 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1222 which are not functions. All uses rewritten to use:
1223 (make_emacs_time): New function.
1224 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1225 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1226 not functions. All uses rewritten to use the following, respectively:
1227 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1228 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1229 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1230 * fileio.c (Fcopy_file):
1231 * xterm.c (XTflash): Get the current time closer to when it's used.
1232 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1233
ffacb126
PE
1234 * bytecode.c (targets): Suppress -Woverride-init warnings.
1235
e99a530f
PE
1236 Simplify by avoiding confusing use of strncpy etc.
1237 * doc.c (Fsnarf_documentation):
1238 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1239 * frame.c (Fmake_terminal_frame):
1240 * gtkutil.c (get_utf8_string):
1241 * lread.c (openp):
1242 * nsmenu.m (ns_update_menubar):
1243 * regex.c (regerror):
1244 Prefer memcpy to strncpy and strncat when either will do.
1245 * fileio.c (Fsubstitute_in_file_name):
1246 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1247 (menu_separator_name_p):
1248 * nsmenu.m (ns_update_menubar):
1249 Prefer memcmp to strncmp when either will do.
1250 * nsterm.m: Include <ftoastr.h>.
1251 (ns_get_color):
1252 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1253 Prefer snprintf to strncpy.
1254 * nsterm.m (ns_term_init):
1255 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1256 * nsterm.m (ns_term_init):
1257 Avoid the need for strncpy, by using build_string or
1258 make_unibyte_string directly. Use dtoastr, not snprintf.
1259 * process.c (Fmake_network_process): Diagnose service names that
1260 are too long, rather than silently truncating them or creating
1261 non-null-terminated names.
1262 (Fnetwork_interface_info): Likewise, for interface names.
1263 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1264 Prefer sprintf to strncat.
1265 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1266 Prefer vsnprintf to vsprintf + strncpy.
1267
c59592b3
GM
12682012-07-10 Glenn Morris <rgm@gnu.org>
1269
1270 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1271 Clarify fallback case.
1272
7d7bbefd
DA
12732012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1274
1275 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1276 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1277 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1278 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1279 where argument type is known to be a Lisp_Cons.
1280
3a4c8000
TT
12812012-07-10 Tom Tromey <tromey@redhat.com>
1282
1283 * bytecode.c (BYTE_CODE_THREADED): New macro.
1284 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1285 (enum byte_code_op): New type.
1286 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1287 (exec_byte_code): Use them. Use token threading when applicable.
1288
2a0213a6
DA
12892012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1290
1291 Optimize pure C strings initialization.
1292 * lisp.h (make_pure_string): Fix prototype.
1293 (build_pure_c_string): New function, defined as static inline. This
1294 provides a better opportunity to optimize away calls to strlen when
1295 the function is called with compile-time constant argument.
1296 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1297 argument, adjust users accordingly. Use build_pure_c_string where
1298 appropriate.
1299 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1300 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1301 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1302
cb1caeaf
DA
13032012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1304
1305 Avoid calls to strlen in miscellaneous functions.
1306 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1307 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1308 * lread.c (openp): Likewise.
1309
c293e30c
DA
13102012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Avoid calls to strlen in path processing functions.
1313 * fileio.c (file_name_as_directory): Add comment. Change to add
1314 srclen argument and return the length of result. Adjust users
1315 accordingly.
1316 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1317 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1318 users accordingly.
1319 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1320
9e059e3f
GM
13212012-07-10 Glenn Morris <rgm@gnu.org>
1322
d02eb359
GM
1323 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1324 Move PENDING_OUTPUT_COUNT definition to configure.
1325
882cf227
GM
1326 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1327 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1328 * s/gnu.h (DATA_START): Move definitions to configure.
1329
af6e839f
GM
1330 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1331 We include usg5-4-common.h, which defines them both.
1332
40289a12
GM
1333 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1334 O_RDONLY already includes it).
1335
9e059e3f
GM
1336 Stop ns builds setting the EMACSLOADPATH environment variable.
1337 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1338 Now it does not set EMACSLOADPATH, just returns the load-path string.
1339 * nsterm.h: Update accordingly.
1340 * lread.c [HAVE_NS]: Include nsterm.h.
1341 (init_lread) [HAVE_NS]: Use ns_load_path.
1342 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1343
7c4e8ec0
GM
13442012-07-09 Glenn Morris <rgm@gnu.org>
1345
d4f600ff
GM
1346 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1347 since the included bsd-common.h does so.
1348
cbb31951
GM
1349 Stop ns builds setting the EMACSPATH environment variable.
1350 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1351 (ns_init_paths): Do not set EMACSPATH.
1352 * nsterm.h (ns_exec_path): Add it.
1353 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1354 Use ns_exec_path.
1355
7c4e8ec0
GM
1356 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1357
26bccfae
PE
13582012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1359
a0bee46f
PE
1360 * process.c (wait_reading_process_output): 'waitchannels' was unset
1361 when read_kbd || !NILP (wait_for_cell); fix this.
1362
5994c183
PE
1363 Add GCC-style 'const' attribute to functions that can use it.
1364 * character.h (char_resolve_modifier_mask):
1365 * keyboard.h (make_ctrl_char):
1366 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1367 (init_character_once, next_almost_prime, init_fns, init_image)
1368 (flush_pending_output, init_sound):
1369 * mem-limits.h (start_of_data):
1370 * menu.h (finish_menu_items):
1371 Add ATTRIBUTE_CONST.
1372 * emacs.c (DEFINE_DUMMY_FUNCTION):
1373 Declare the dummy function with ATTRIBUTE_CONST.
1374 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1375 Add decls with ATTRIBUTE_CONST.
1376
26bccfae
PE
1377 Minor improvements to make_formatted_string.
1378 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1379 where int is good enough, as vsprintf returns an int.
1380 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1381
a8290ec3
DA
13822012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1383
1384 Use make_formatted_string to avoid double length calculation.
1385 * lisp.h (make_formatted_string): New prototype.
1386 * alloc.c (make_formatted_string): New function.
1387 * buffer.c (Fgenerate_new_buffer_name): Use it.
1388 * dbus.c (syms_of_dbusbind): Likewise.
1389 * editfns.c (Fcurrent_time_zone): Likewise.
1390 * filelock.c (get_boot_time): Likewise.
1391 * frame.c (make_terminal_frame, set_term_frame_name)
1392 (x_report_frame_params): Likewise.
1393 * image.c (gs_load): Likewise.
1394 * minibuf.c (get_minibuffer): Likewise.
1395 * msdos.c (dos_set_window_size): Likewise.
1396 * process.c (make_process): Likewise.
1397 * xdisp.c (ensure_echo_area_buffers): Likewise.
1398 * xsettings.c (apply_xft_settings): Likewise.
1399
d01ba2f1
GM
14002012-07-09 Glenn Morris <rgm@gnu.org>
1401
1402 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1403 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1404 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1405 * nsterm.h (ns_etc_directory): Add it.
1406 * callproc.c [HAVE_NS]: Include nsterm.h.
1407 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1408
f1f924b6
DA
14092012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1410
1411 Move marker debugging code under MARKER_DEBUG.
1412 * marker.c (MARKER_DEBUG): Move marker debugging code under
1413 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1414 for bootstrap with --enable-checking (~3x slowdown reported
1415 by Juanma Barranquero <lekktu@gmail.com>).
1416 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1417
ab531b66
PE
14182012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1421 See <http://bugs.gnu.org/11825#29>.
1422
c4b3bc8a
EZ
14232012-07-08 Eli Zaretskii <eliz@gnu.org>
1424
1425 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1426 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1427 (display_line): Add commentary about displaying truncation glyphs
1428 on GUI frames.
1429 (produce_special_glyphs): Move here from term.c.
1430
1431 * term.c (produce_special_glyphs): Move to xdisp.c.
1432
1433 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1434 section.
c4b3bc8a 1435
b676b881
AS
14362012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1437
f17c5273
AS
1438 * xdisp.c (display_line): Avoid warning about implicit declaration
1439 of FRAME_FONT.
1440
298819b9
AS
1441 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1442
b676b881
AS
1443 * lisp.h: Remove empty conditional.
1444
6045c4fd
PE
14452012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1446
b3350bf9
PE
1447 * lread.c (load_path_check): Now static.
1448
6045c4fd
PE
1449 Fix some minor --with-ns problems found by static checking.
1450 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1451 (x_set_font) [!HAVE_X_WINDOWS]:
1452 * image.c (xpm_load_image) [HAVE_NS]:
1453 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1454 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1455 Remove unused local.
1456 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1457 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1458 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1459 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1460 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1461 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1462 Fix pointer signedness problem.
1463 * xfaces.c (FRAME_X_FONT_TABLE):
1464 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1465
929e7845
GM
14662012-07-07 Glenn Morris <rgm@gnu.org>
1467
1468 * lread.c (load_path_check): New function, split from init_lread.
1469 (init_lread): Reorganize. Motivation:
1470 If EMACSLOADPATH is set, check/warn about that rather than the
1471 defaults, which we are not going to use. Hence we can remove
1472 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1473 Don't warn if site-lisp directories are missing.
1474 If not installed, start from a blank load-path, since
1475 PATH_LOADSEARCH refers to the eventual installation directories.
1476
58dd0aa4
EZ
14772012-07-07 Eli Zaretskii <eliz@gnu.org>
1478
1479 Support truncation and continuation glyphs on GUI frames, when
1480 fringes are disabled. (Bug#11832)
1481 * xdisp.c (init_iterator): Get dimensions of truncation and
1482 continuation glyphs even if on GUI frames. Adjust
1483 it->last_visible_x on GUI frames when the left or right fringes,
1484 or both, are absent.
1485 (start_display, move_it_in_display_line_to): Handle the case of a
1486 GUI frame without a fringe to display continuation or truncation
1487 glyphs.
1488 (insert_left_trunc_glyphs): Support GUI frames: make sure
1489 truncation glyphs overwrite enough glyphs from the current line to
1490 have sufficient space in pixels.
1491 (display_line): Support truncation and continuation glyphs on GUI
1492 frames. If some spare pixels are left on the line after inserting
1493 the truncation glyphs, fill that space with a stretch glyph of a
1494 suitably computed width.
1495
1496 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1497 produce_glyphs, to support GUI sessions.
1498
31571fd7
PE
14992012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1500
5a16b9bc
PE
1501 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1502
f3047c75
PE
1503 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1504
31571fd7
PE
1505 Do not require float-time's arg to fit in time_t (Bug#11825).
1506 This works better on hosts where time_t is unsigned, and where
1507 float-time is applied to the (negative) difference between two times.
1508 * editfns.c (decode_time_components): Last arg is now double *,
1509 not int *, and means to store all the result as a double, without
1510 worrying about whether the seconds part fits in time_t.
1511 All callers changed.
1512 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1513 All callers changed.
1514 (Ffloat_time): Do not fail merely because the specified time falls
1515 outside of time_t range.
1516
4516fbef
GM
15172012-07-07 Glenn Morris <rgm@gnu.org>
1518
1519 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1520 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1521 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1522
07adc2c6
JB
15232012-07-07 Juanma Barranquero <lekktu@gmail.com>
1524
1525 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1526 Update dependencies.
1527
1528 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1529
fd573f31
PE
15302012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1531
fee5959d
PE
1532 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1533 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1534 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1535 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1536 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1537 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1538
fd573f31
PE
1539 * xfont.c (compare_font_names): Redo to omit the need for casts.
1540
ddadbc0e
AS
15412012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1542
fca8d6b6
AS
1543 * xfns.c (Fx_change_window_property): Doc fix.
1544 * w32fns.c (Fx_change_window_property): Doc fix.
1545
ddadbc0e
AS
1546 * w32fns.c (Fx_window_property): Accept the same arguments as the
1547 X Windows version. Doc fix.
1548 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1549
ed9265fc 15502012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1551 Eli Zaretskii <eliz@gnu.org>
1552
1553 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1554 Windows-specific code from nt/config.nt moved here.
1555 Obsolete settings removed.
1556
216ee680
PE
15572012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * process.c: Avoid unnecessary calls to gettime.
1560 (wait_reading_process_output): Don't get the time of day
1561 when gobbling data immediately and not waiting, as there's no need
1562 for it in that case. This removes a FIXME.
1563
bdd091e4
JD
15642012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1565
1566 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1567 is defined (Bug#11768).
1568
9d44f8ce
DA
15692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1570
1571 Fix marker debugging code.
1572 * marker.c (byte_char_debug_check): Do not perform the check
1573 if buffer is not multibyte.
090bd7cb
JB
1574 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1575 Call byte_char_debug_check with correct arguments.
9d44f8ce 1576
90fc4786
DA
15772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1578
1579 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1580 * marker.c (byte_char_debug_check, count_markers):
1581 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1582 (byte_debug_flag): Remove.
1583 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1584 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1585
7b7ae965
DA
15862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1587
4e57b342
DA
1588 Avoid code repetition in marker-related functions.
1589 * marker.c (attach_marker): New function.
1590 (Fset_marker, set_marker_restricted, set_marker_both)
1591 (set_marker_restricted_both): Use it.
1592 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1593 Consistently rename charno to charpos.
1594 (marker_position): Add eassert.
1595 (marker_byte_position): Convert to eassert.
1596
15972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1598
1599 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1600 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1601 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1602
657924ff
DA
16032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1604
1605 Introduce fast path for the widely used marker operation.
1606 * alloc.c (build_marker): New function.
1607 * lisp.h (build_marker): New prototype.
1608 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1609 * composite.c (autocmp_chars): Likewise.
1610 * editfns.c (buildmark): Remove.
1611 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1612 (save_restriction_save): Use build_marker.
1613 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1614 * window.c (save_window_save): Likewise.
1615
041a49a6
DA
16162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1617
1618 Do not use Fdelete_overlay in delete_all_overlays
1619 to avoid redundant calls to unchain_overlay.
1620 * buffer.c (drop_overlay): New function.
1621 (delete_all_overlays, Fdelete_overlay): Use it.
1622 * minibuf.c (get_minibuffer): Fix comment.
1623
7dca65a4
PE
16242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1625
1626 Port to OpenBSD 5.1 amd64.
1627 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1628 This is needed for OpenBSD, and should be harmless on all BSD systems.
1629 Also, include <sys/sysctl.h>, as it should be available on all
1630 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1631 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1632 use p_pid member, not kp_proc.pid.
1633
8eb876e2
GM
16342012-07-06 Glenn Morris <rgm@gnu.org>
1635
1636 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1637
38182d90
PE
16382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 More xmalloc and related cleanup.
1641 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1642 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1643 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1644 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1645 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1646 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1647 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1648 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1649 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1650 * xterm.c:
1651 Omit needless casts involving void * pointers and allocation.
1652 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1653 as the former is more robust if P's type is changed.
1654 Prefer xzalloc to xmalloc + memset 0.
1655 Simplify malloc-or-realloc to realloc.
1656 Don't worry about xmalloc returning a null pointer.
1657 Prefer xstrdup to xmalloc + strcpy.
1658 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1659 growing it.
1660 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1661 alloca of a constant.
1662
6dd5a677
EZ
16632012-07-05 Eli Zaretskii <eliz@gnu.org>
1664
1665 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1666 hscroll is larger than the line width. Fixes long and futile
1667 looping inside extend_face_to_end_of_line (on a TTY) producing
1668 glyphs that are not needed and thrown away.
1669
6b312f0f
DA
16702012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1671
1672 * marker.c (set_marker_restricted_both): Simplify by using
1673 clip_to_bounds.
1674
f520ef9b
PE
16752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1678
383b7c95
JD
16792012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1680
1681 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1682 not defined (Bug#11768).
1683 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1684 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1685 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1686 followed by gtk_box_set_homogeneous (Bug#11768).
1687 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1688 (update_theme_scrollbar_width, xg_create_scroll_bar):
1689 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1690 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1691 (is_box_type): New function (Bug#11768).
1692 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1693 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1694 with default display (Bug#11768).
1695
d6e7bf45
EZ
16962012-07-05 Eli Zaretskii <eliz@gnu.org>
1697
1698 * xdisp.c (window_hscroll_limited): New function.
1699 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1700 coordinates when window's hscroll is set to insanely large
1701 values. (Bug#11857)
1702
431391ec
JB
17032012-07-05 Juanma Barranquero <lekktu@gmail.com>
1704
1705 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1706 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1707
23f86fce
DA
17082012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1709
1710 Cleanup xmalloc.
1711 * lisp.h (xzalloc): New prototype. Omit needless casts.
1712 * alloc.c (xzalloc): New function. Omit needless casts.
1713 * charset.c: Omit needless casts. Convert all calls to
1714 xmalloc with following memset to xzalloc.
1715 * dispnew.c: Likewise.
1716 * fringe.c: Likewise.
1717 * image.c: Likewise.
1718 * sound.c: Likewise.
1719 * term.c: Likewise.
1720 * w32fns.c: Likewise.
1721 * w32font.c: Likewise.
1722 * w32term.c: Likewise.
1723 * xfaces.c: Likewise.
1724 * xfns.c: Likewise.
1725 * xterm.c: Likewise.
1726 * atimer.c: Omit needless casts.
1727 * buffer.c: Likewise.
1728 * callproc.c: Likewise.
1729 * ccl.c: Likewise.
1730 * coding.c: Likewise.
1731 * composite.c: Likewise.
1732 * doc.c: Likewise.
1733 * doprnt.c: Likewise.
1734 * editfns.c: Likewise.
1735 * emacs.c: Likewise.
1736 * eval.c: Likewise.
1737 * filelock.c: Likewise.
1738 * fns.c: Likewise.
1739 * gtkutil.c: Likewise.
1740 * keyboard.c: Likewise.
1741 * lisp.h: Likewise.
1742 * lread.c: Likewise.
1743 * minibuf.c: Likewise.
1744 * msdos.c: Likewise.
1745 * print.c: Likewise.
1746 * process.c: Likewise.
1747 * region-cache.c: Likewise.
1748 * search.c: Likewise.
1749 * sysdep.c: Likewise.
1750 * termcap.c: Likewise.
1751 * terminal.c: Likewise.
1752 * tparam.c: Likewise.
1753 * w16select.c: Likewise.
1754 * w32.c: Likewise.
1755 * w32reg.c: Likewise.
1756 * w32select.c: Likewise.
1757 * w32uniscribe.c: Likewise.
1758 * widget.c: Likewise.
1759 * xdisp.c: Likewise.
1760 * xmenu.c: Likewise.
1761 * xrdb.c: Likewise.
1762 * xselect.c: Likewise.
1763
0497dc44
PE
17642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 * fileio.c (time_error_value): Check the right error number.
1767 Problem reported by Troels Nielsen in
1768 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1769
356e7178
PE
17702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1771
4e71fd89
PE
1772 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1773 This should be fixed in a better way; see Eli Zaretskii in
1774 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1775 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1776
f0941253
PE
1777 * fileio.c (time_error_value): Rename from special_mtime.
1778 The old name's problems were noted by Eli Zaretskii in
1779 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1780
065c9eb4
PE
1781 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1782 This variable's comment says Emacs needs at least one GDB-visible
1783 symbol of type enum pvec_type, to work around GDB problems.
1784 The symbol's value doesn't matter.
1785
356e7178
PE
1786 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1787 that causes compilation to fail on pre-C99 compilers.
1788
ed9265fc 17892012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1790
1791 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1792 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1793
3884d954
DA
17942012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1795
d209e2fb 1796 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1797 headers for buffer_defaults and buffer_local_symbols.
1798 Reported by Juanma Barranquero <lekktu@gmail.com>.
1799
ee28be33
SM
18002012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1801
1802 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1803 * lisp.h (enum pvec_type): Use fewer bits.
1804 (PSEUDOVECTOR_SIZE_BITS): New constant.
1805 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1806 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1807 change in pvec_type.
1808 (PSEUDOVECTOR_TYPEP): New macro.
1809 (TYPED_PSEUDOVECTORP): Use it.
1810 * fns.c (internal_equal): Adapt code to extract pvectype.
1811 * emacs.c (gdb_pvec_type): Update type.
1812 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1813 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1814 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1815 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1816 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1817 abusing vector->header.next.nbytes.
1818 (live_vector_p): Use PVEC_TYPE.
1819 (mark_object): Adapt code to extract pvectype. Use switch.
1820
c7f2cd7f
PE
18212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1822
1823 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1824 Tighten new eassert a bit.
1825
8ce70ed2
DA
18262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1827
1828 Fix compilation with --enable-gcc-warnings and -O1
1829 optimization level.
1830 * doprnt.c (doprnt): Change type of tem to int, initialize
1831 to avoid compiler warning. Add eassert.
1832 * search.c (simple_search): Initialize match_byte to avoid
1833 compiler warning. Add eassert.
1834
dea7f1e5
PE
18352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1836
24a212eb
PE
1837 Avoid weird behavior with large horizontal scrolls.
1838 Without this change, for example, large hscroll values would
1839 mess up Emacs's display on Fedora 15 x86, presumably due to
1840 overflows in int calculations in the display code.
1841 Also, if buffers had long lines, Emacs would freeze.
1842 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1843 (set_window_hscroll): New function, containing the old guts of
1844 Fset_window_hscroll. Return the clipped value.
1845 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1846 This avoids the need to check against PTRDIFF_MAX.
1847
dea7f1e5
PE
1848 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1849
76046526
DA
18502012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1851
1852 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1853
39adff0d
PE
18542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1855
63807d47
PE
1856 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1857 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1858 since GCC 4.4.6 issues a bogus warning for them.
1859
39adff0d
PE
1860 Fix bugs in file timestamp newness comparisons.
1861 * fileio.c (Ffile_newer_than_file_p):
1862 * lread.c (Fload): Use full timestamp resolution of files,
1863 not just the 1-second resolution, so that files that are only
1864 slightly newer still count as newer.
1865 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1866 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1867
dbeed9a6
PE
18682012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1869
1870 * fileio.c: Improve handling of file time marker. (Bug#11852)
1871 (special_mtime): New function.
1872 (Finsert_file_contents, Fverify_visited_file_modtime):
1873 Use it to set special mtime values consistently.
1874
636334d6
AS
18752012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1876
1877 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1878 marker for non-existing file. (Bug#11852)
1879
e2017fe2
GM
18802012-07-03 Glenn Morris <rgm@gnu.org>
1881
1882 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1883 and did not make it into globals.h).
1884
404dbd37
TT
18852012-07-03 Tom Tromey <tromey@redhat.com>
1886
1887 * window.c (Fset_window_margins, Fset_window_fringes)
1888 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1889 * textprop.c (Fprevious_property_change): No longer static.
1890 * syntax.c (Fsyntax_table_p): No longer static.
1891 * process.c (Fget_process, Fprocess_datagram_address): No longer
1892 static.
1893 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1894 * keyboard.c (Fcommand_execute): No longer static.
1895 Remove EXFUN.
1896 * insdel.c (Fcombine_after_change_execute): No longer static.
1897 * image.c (Finit_image_library): No longer static.
1898 * fileio.c (Fmake_symbolic_link): No longer static.
1899 * eval.c (Ffetch_bytecode): No longer static.
1900 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1901 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1902 No longer static.
404dbd37
TT
1903 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1904 static.
1905 * dired.c (Ffile_attributes): No longer static.
1906 * composite.c (Fcomposition_get_gstring): No longer static.
1907 * callproc.c (Fgetenv_internal): No longer static.
1908
1909 * ccl.h: Remove EXFUNs.
1910 * buffer.h: Remove EXFUNs.
1911 * dispextern.h: Remove EXFUNs.
1912 * intervals.h: Remove EXFUNs.
1913 * fontset.h: Remove EXFUN.
1914 * font.h: Remove EXFUNs.
1915 * dosfns.c (system_process_attributes): Remove EXFUN.
1916 * keymap.h: Remove EXFUNs.
1917 * lisp.h: Remove EXFUNs.
1918 * w32term.h: Remove EXFUNs.
1919 * window.h: Remove EXFUNs.
1920 * xsettings.h: Remove EXFUN.
1921 * xterm.h: Remove EXFUN.
1922
8e4fd1e1
GM
19232012-07-03 Glenn Morris <rgm@gnu.org>
1924
1925 * lisp.h (Frandom): Make it visible to C.
1926 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1927 buffer for invisible buffers. (Bug#1229)
1928
ca95b3eb
DA
19292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1930
1931 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1932 values which aren't power of 2.
1933 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1934 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1935 accordingly.
1936
7555c33f
SM
19372012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1938
1939 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1940
1941 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1942
d12e8f5a
DA
19432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 * alloc.c (allocate_vector_block): Remove redundant
1946 calls to mallopt if DOUG_LEA_MALLOC is defined.
1947 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1948 avoid calls to mallopt if zero_vector is returned.
1949
296094c3
DA
19502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1951
1952 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1953 is enabled, avoid dereferencing NULL current_sblock if
1954 running undumped.
1955
36429c89
DA
19562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1957
1958 Cleanup basic buffer management.
1959 * buffer.h (struct buffer): Change layout to use generic vector
1960 marking code. Fix some comments. Change type of 'clip_changed'
1961 to bitfield. Remove unused #ifndef old.
1962 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1963 (GET_OVERLAYS_AT): Fix indentation.
1964 (for_each_per_buffer_object_at): New macro.
1965 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1966 (Fbuffer_local_variables): Use it.
1967 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1968 * alloc.c (allocate_buffer): Adjust to match new layout of
1969 struct buffer. Fix comment.
1970 (mark_overlay): New function.
1971 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1972 Lisp area of struct buffer.
1973 (mark_object): Use it. Adjust marking of misc objects
1974 and related comments.
1975
3b3e4cac
PE
19762012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1977
1978 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1979 wrapper that is not needed because the wrapped code is a no-op (zero
1980 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1981 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1982
cf5c0175
DA
19832012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1984
1985 * alloc.c (mark_buffer): Simplify. Remove prototype.
1986 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1987 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1988 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1989 redundant calls to mark_vectorlike for bool vectors.
1990
ca26824c
GM
19912012-06-30 Glenn Morris <rgm@gnu.org>
1992
2e4c5312
GM
1993 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1994
ca26824c
GM
1995 * epaths.in (PATH_SITELOADSEARCH): New.
1996 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1997 This is rather than relying on --enable-locallisppath elements
1998 having "site-lisp" in their names. (Bug#10208#25, 11658)
1999
0d23c240
EZ
20002012-06-30 Eli Zaretskii <eliz@gnu.org>
2001
c9240d7a
EZ
2002 * w32proc.c (sys_select): Accept and ignore one more argument.
2003
2004 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2005
0d23c240 2006 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2007 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2008
2009 * sysdep.c: Don't include dos.h and dosfns.h.
2010
2011 * process.c (sys_select):
2012 * msdos.c (sys_select): Accept one more argument and ignore it.
2013
2014 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2015 adapt data types and code to that.
2016
2017 * dosfns.c:
2018 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2019 which clashes with the gnulib function of the same name.
2020
af5a5a98
AS
20212012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2022
c5e4379c
AS
2023 * font.c (font_style_to_value, font_style_symbolic)
2024 (font_prop_validate_style): Add type checks for values in
2025 font_style_table.
2026
af5a5a98
AS
2027 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2028 argument.
2029 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2030 uses.
2031
8d38f461
EZ
20322012-06-29 Eli Zaretskii <eliz@gnu.org>
2033
2e5a6631
EZ
2034 * xdisp.c (try_window_id): Undo last change.
2035
8d38f461
EZ
2036 * w32.c (getwd): Adjust commentary about startup_dir.
2037 (init_environment): Always call sys_access, even in non-MSVC
2038 builds. Don't chdir to the directory of the Emacs executable.
2039 This undoes code from 1997 which was justified by the need to
2040 "avoid conflicts when removing and renaming directories". But its
2041 downside was that every relative file name was being interpreted
2042 relative to the directory of the Emacs executable, which can never
2043 be TRT. In particular, it broke sys_access when called with
2044 relative file names.
2045 (sys_access): Map GetLastError to errno.
2046
2af3565e
DA
20472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 * window.h (struct window): Change type of 'fringes_outside_margins'
2050 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2051 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2052 Adjust comment.
2053 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2054 to ptrdiff_t.
2055
c8d3a25c 20562012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2057
c8d3a25c
GM
2058 * gnutls.c (emacs_gnutls_handshake):
2059 Add QUIT to make the loop interruptible.
57570cd3 2060
c8d3a25c 20612012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2062
c8d3a25c
GM
2063 * charset.c (init_charset): Make lack of etc/charsets fatal.
2064
3e984ee8
DA
20652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2066
2067 * editfns.c (region_limit): Fix type mismatch.
2068
ef884f23
DA
20692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2070
2071 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2072 undefined. Convert from xassert to eassert.
2073 * nsmenu.m: Convert from xassert to eassert.
2074 * nsterm.m: Likewise.
2075
7d7e0027
SM
20762012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2077
2078 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2079
aa754e6a
PE
20802012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 Avoid integer overflow on scroll-left and scroll-right.
2083 * window.c (HSCROLL_MAX): New macro.
2084 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2085 overflow when requested scroll falls outside ptrdiff_t range.
2086
80b00b08
DA
20872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2088
2089 * window.h (struct window): Change type of 'hscroll',
2090 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2091 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2092 Adjust users accordingly.
2093 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2094 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2095 from EMACS_INT to ptrdiff_t.
2096 (make_window): Omit redundant initialization.
2097
62b2bcf6
JB
20982012-06-28 Juanma Barranquero <lekktu@gmail.com>
2099
2100 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2101
45942c7d
DA
21022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2103
2104 * window.h (struct window): Change type of 'use_time' and
2105 'sequence_number' from Lisp_Object to int.
2106 * frame.c (make_frame): Adjust users accordingly.
2107 * print.c (print_object): Likewise.
2108 * window.c (select_window, Fwindow_use_time, make_parent_window)
2109 (make_window): Likewise.
2110
e509cfa6
DA
21112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2112
2113 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2114 enabled with --enable-checking=[all,glyphs] configure option.
2115 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2116 adjust comments accordingly.
2117 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2118 undefined, adjust comments accordingly.
2119 * image.c: Likewise.
2120 * scroll.c: Likewise.
2121 * w32fns.c: Likewise.
2122 * w32term.c: Likewise.
2123 * xdisp.c: Likewise.
2124 * xfaces.c: Likewise.
2125 * xfns.c: Likewise.
2126 * xterm.c: Likewise.
2127
a54e2c05
DA
21282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2129
2130 Generalize run-time debugging checks.
2131 * dispextern.h (XASSERTS): Remove.
2132 * fontset.c (xassert): Remove.
2133 Convert from xassert to eassert.
2134 * alloc.c: Convert from xassert to eassert.
2135 * bidi.c: Likewise.
2136 * dispnew.c: Likewise.
2137 * fns.c: Likewise.
2138 * fringe.c: Likewise.
2139 * ftfont.c: Likewise.
2140 * gtkutil.c: Likewise.
2141 * image.c: Likewise.
2142 * keyboard.c: Likewise.
2143 * menu.c: Likewise.
2144 * process.c: Likewise.
2145 * scroll.c: Likewise.
2146 * sound.c: Likewise.
2147 * term.c: Likewise.
2148 * w32console.c: Likewise.
2149 * w32fns.c: Likewise.
2150 * w32term.c: Likewise.
2151 * window.c: Likewise.
2152 * xdisp.c: Likewise.
2153 * xfaces.c: Likewise.
2154 * xfns.c: Likewise.
2155 * xselect.c: Likewise.
2156 * xterm.c: Likewise.
2157
1ec4b7b2
SM
21582012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2159
2160 * fns.c (maybe_resize_hash_table): Output message when growing the
2161 purify-hashtable.
2162
2014308a
DA
21632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2164
2165 * alloc.c (allocate_string_data): Remove dead code.
2166 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2167 avoid GCC warning about unused macro.
2168
246155eb
DA
21692012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 * alloc.c (allocate_string): Omit intervals initialization.
2172 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2173 as in make_pure_string and make_pure_c_string.
2174
43184b7b
DA
21752012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2176
d209e2fb 2177 * alloc.c (allocate_string): Fix last change.
43184b7b 2178
3fe6dd74
DA
21792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2180
d209e2fb 2181 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2182 to memset, add explicit initialization where appropriate.
2183
1ba6038a
GM
21842012-06-27 Glenn Morris <rgm@gnu.org>
2185
2186 * lisp.mk (lisp): Remove paths.elc.
2187
c89926a5
CY
21882012-06-27 Chong Yidong <cyd@gnu.org>
2189
2190 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2191
ed6b3510
JW
21922012-06-26 John Wiegley <johnw@newartisans.com>
2193
1ec4b7b2 2194 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2195 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2196
ed6b3510
JW
2197 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2198 when building with Clang.
2199
8edd4a2b
SM
22002012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2201
2202 * eval.c (Fapply): Allow calling it with a single argument.
2203
f6f62d1b
EZ
22042012-06-26 Eli Zaretskii <eliz@gnu.org>
2205
2206 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2207 _stricmp and _strnicmp.
2208 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2209
62efea5e
DA
22102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2211
2212 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2213 allocated window.
2214 (allocate_process): Likewise for new process.
8edd4a2b 2215 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2216 (allocate_frame): Likewise.
2217 * frame.c (make_frame): Omit redundant initialization.
2218 * window.c (make_parent_window): Use memset.
2219 (make_window): Omit redundant initialization.
2220 * process.c (make_process): Omit redundant initialization.
2221 * terminal.c (create_terminal): Likewise.
2222
42997f4d
DA
22232012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2224
2225 * term.c (delete_tty): Remove redundant call to memset.
2226
1130ecfc
DA
22272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2228
2229 * alloc.c: Remove build_string.
2230 * lisp.h: Define build_string as static inline. This provides
2231 a better opportunity to optimize away calls to strlen when the
2232 function is called with compile-time constant argument.
2233 * image.c (imagemagick_error): Convert to build_string.
2234 * w32proc.c (sys_spawnve): Likewise.
2235 * xterm.c (x_term_init): Likewise.
2236
cf38a720
PE
22372012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2238
99027bdd
PE
2239 Use sprintf return value instead of invoking strlen on result.
2240 In the old days this wasn't portable, since some sprintf
2241 implementations returned char *. But they died out years ago and
2242 Emacs already assumes sprintf returns int.
2243 Similarly for float_to_string.
2244 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2245 * ccl.c (ccl_driver):
2246 * character.c (string_escape_byte8):
2247 * data.c (Fnumber_to_string):
2248 * doprnt.c (doprnt):
2249 * print.c (print_object):
2250 * xdisp.c (message_dolog):
2251 * xfns.c (syms_of_xfns):
2252 Use sprintf or float_to_string result to avoid need to call strlen.
2253 * data.c (Fnumber_to_string):
2254 Use make_unibyte_string, since the string must be ASCII.
2255 * lisp.h, print.c (float_to_string): Now returns int length.
2256 * term.c (produce_glyphless_glyph):
2257 Use sprintf result rather than recomputing it.
2258
cf38a720
PE
2259 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2260 * Makefile.in (ALL_CFLAGS):
2261 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2262 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2263
3511c784
DA
22642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2265
0a08eb21 2266 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2267 strcasecmp if available.
2268 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2269
fb7da12e
AS
22702012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2271
2272 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2273 Avoid comma operator.
2274 * menu.c (push_submenu_start, push_submenu_end)
2275 (push_left_right_boundary, push_menu_pane): Likewise.
2276 * msdos.c (dos_rawgetc): Likewise.
2277
afa2ffd8
DA
22782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2279
2280 * xfns.c (xic_create_fontsetname): Remove redundant calls
2281 to memset.
2282
b3b4476b
PE
22832012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2284
4495ff38
PE
2285 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2286 sprintf already null-terminates its output.
2287
b3b4476b
PE
2288 * xfns.c (x_window): Remove redundant cast.
2289
b00876c9
DA
22902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2291
2292 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2293 `const char *' to `char *' to avoid compiler warning.
2294
d188e26b
PE
22952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2296
885d1d74
PE
2297 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2298 instead of truncating it to 63 (admittedly a generous limit).
2299
d188e26b
PE
2300 * process.c: Fix spelling and caps in comments.
2301
e2f560b1
DN
23022012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2303
e86db54b 2304 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2305 * sysdep.c (setpgrp): Remove definition, not used in this file.
2306
7583a3a1
JB
23072012-06-24 Juanma Barranquero <lekktu@gmail.com>
2308
2309 * makefile.w32-in: Update dependencies.
2310
696056c2
EZ
23112012-06-24 Eli Zaretskii <eliz@gnu.org>
2312
2313 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2314 (SYSTIME_H): Add nt/inc/sys/time.h.
2315
2316 * systime.h [WINDOWSNT]: Include sys/time.h.
2317
2318 * s/ms-w32.h (struct timespec): Definition moved from
2319 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2320
845ca893
PE
23212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2324 * buffer.h (buffer_slot_type_mismatch):
2325 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2326 * eval.c (unwind_to_catch):
2327 * image.c (my_png_error, my_error_exit):
2328 * keyboard.c (quit_throw_to_read_char, user_error)
2329 (Fexit_recursive_edit, Fabort_recursive_edit):
2330 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2331 (wrong_type_argument, buffer_overflow, __executable_start)
2332 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2333 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2334 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2335 (fatal):
2336 (child_setup) [!DOS_NT]:
2337 * lread.c (end_of_file_error, invalid_syntax):
2338 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2339 * puresize.h (pure_write_error):
2340 * search.c (matcher_overflow):
2341 * sound.c (sound_perror, alsa_sound_perror):
2342 * sysdep.c, syssignal.h (croak):
2343 * term.c (maybe_fatal, vfatal):
2344 * textprop.c (text_read_only):
2345 * undo.c (user_error):
2346 * unexmacosx.c (unexec_error):
2347 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2348 Use _Noreturn rather than NO_RETURN.
2349 No need for separate decl merely because of _Noreturn.
2350 * sound.c (sound_warning, parse_sound):
2351 Remove unnecessary forward decls.
2352
f1dd8073
PE
23532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2356 * lisp.h (WAIT_READING_MAX): New macro.
2357 * dispnew.c (Fsleep_for, sit_for):
2358 * keyboard.c (kbd_buffer_get_event):
2359 * process.c (Faccept_process_output):
2360 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2361 This improves on the previous patch, which introduced a bug
2362 when time_t is unsigned and as wide as intmax_t.
2363 See <http://bugs.gnu.org/9000#51>.
2364
b82c1755
EZ
23652012-06-23 Eli Zaretskii <eliz@gnu.org>
2366
2367 * dispnew.c (sit_for, Fsleep_for):
2368 * keyboard.c (kbd_buffer_get_event):
2369 * process.c (Faccept_process_output): Avoid compiler warnings when
2370 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2371
ca300656
JB
23722012-06-23 Juanma Barranquero <lekktu@gmail.com>
2373
049ec95b
JB
2374 * makefile.w32-in: Update dependencies.
2375
ca300656
JB
2376 * w32.c (ltime): Add return type and declare static.
2377 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2378
db7b8d06
PE
23792012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2382 Privately reported by Herbert J. Skuhra.
2383 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2384 All uses changed.
2385 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2386 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2387
0bd8297f
EZ
23882012-06-23 Eli Zaretskii <eliz@gnu.org>
2389
96512555
EZ
2390 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2391 last argument of make_unibyte_string.
2392
0bd8297f
EZ
2393 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2394 language ID in the event parameters.
2395
2396 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2397 event.code, not the obscure "character set ID".
2398
63def6b6
CY
23992012-06-23 Chong Yidong <cyd@gnu.org>
2400
2401 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2402
e8a02204
EZ
24032012-06-23 Eli Zaretskii <eliz@gnu.org>
2404
388cdec0
EZ
2405 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2406 * w32.c (fdutimens): New function.
2407
2408 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2409
2410 * s/ms-w32.h (pselect): Redirect to sys_select.
2411
2412 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2413
e8a02204
EZ
2414 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2415 in the logic of incrementing and decrementing the value of
2416 use_relocatable_buffers.
2417
d054f3fb
PE
24182012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2419
2420 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2421 Privately reported by Herbert J. Skuhra.
2422 [__FreeBSD__]: Remove "*/" typo after "#include".
2423 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2424 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2425 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2426 Don't assume EMACS_TIME and struct timeval are the same type.
2427
d35af63c
PE
24282012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2429
2430 Support higher-resolution time stamps (Bug#9000).
2431 The time stamps are only nanosecond-resolution at the C level,
2432 since that's the best that any real-world system supports now.
2433 But they are picosecond-resolution at the Lisp level, as that's
2434 easy, and leaves room for future OS improvements.
2435
2436 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2437 (LIBES): Use it.
2438
2439 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2440 Don't get current time unless it's needed.
2441
2442 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2443 now provides it if it's absent.
2444 (start_atimer): Port to higher-res time stamps.
2445 Check for time stamp overflow. Don't get current time more
2446 often than is needed.
2447
2448 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2449 Include systime.h, not time.h.
2450 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2451
2452 * dired.c: Include stat-time.h.
2453 (Ffile-attributes): File times now have higher resolution.
2454
2455 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2456 (struct image): Timestamp now has higher resolution.
2457
2458 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2459 has at least microseconds now. All uses removed.
2460 (update_frame, update_single_window, update_window, update_frame_1)
2461 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2462
2463 * editfns.c (time_overflow): Now extern.
2464 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2465 (float-time, Fformat_time_string, Fcurrent_time_string)
2466 (Fcurrent_time_zone): Accept and generate higher-resolution
2467 time stamps.
2468 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2469 (decode_time_components, lisp_seconds_argument): New functions.
2470 (make_time): Now static.
2471 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2472 Report an error if the time is invalid, rather than having the caller
2473 do that.
2474
2475 * fileio.c: Include <stat-time.h>
2476 (Fcopy_file): Copy higher-resolution time stamps.
2477 Prefer to set the time stamp via a file descriptor if that works.
2478 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2479 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2480 (Fvisited_file_modtime, Fset_visited_file_modtime):
2481 Support higher-resolution time stamps.
2482
2483 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2484
2485 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2486
2487 * image.c (prepare_image_for_display, clear_image_cache)
2488 (lookup_image): Port to higer-resolution time stamps.
2489
2490 * keyboard.c (start_polling, bind_polling_period):
2491 Check for time stamp overflow.
2492 (read_char, kbd_buffer_get_event, timer_start_idle)
2493 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2494 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2495 Port to higher-resolution time stamps. Do not assume time_t is signed.
2496 (decode_timer): New function. Timers are now vectors of length 9,
2497 not 8, to accommodate the picosecond component.
2498 (timer_check_2): Use it.
2499
2500 * nsterm.m (select_timeout, timeval_subtract): Remove.
2501 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2502 as they're a bit more accurate and handle overflow better.
2503 (ns_select): Change prototype to be compatible with pselect.
2504 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2505 * nsterm.h (ns_select): Adjust prototype.
2506
2507 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2508 us-resolution time stamps.
2509 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2510
2511 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2512
2513 * lisp.h (time_overflow): New decl.
2514 (wait_reading_process_output): First arg is now intmax_t, not int,
2515 to accommodate larger waits.
2516
2517 * process.h (struct Lisp_Process.read_output_delay):
2518 Now counts nanoseconds, not microseconds.
2519 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2520 EMACS_HAS_USECS.
2521 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2522 (wait_reading_process_output):
2523 Port to ns-resolution time stamps.
2524 (Faccept_process_output, wait_reading_process_output):
2525 Check for time stamp overflow. Do not assume time_t is signed.
2526 (select_wrapper): Remove; we now use pselect.
2527 (Fprocess_attributes): Now generates ns-resolution time stamps.
2528
2529 * sysdep.c: Include utimens.h. Don't include utime.h
2530 or worry about struct utimbuf; gnulib does that for us now.
2531 (gettimeofday): Remove; gnulib provides a substitute.
2532 (make_timeval): New function.
2533 (set_file_times): Now sets ns-resolution time stamps.
2534 New arg FD; all uses changed.
2535 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2536 (system_process_attributes):
2537 Now returns ns-resolution time stamp. All uses changed.
2538 Check for time stamp overflow.
2539
2540 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2541 provides a substitute now.
2542
2543 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2544 since it guarantees struct timespec.
2545 (EMACS_TIME): Now struct timespec, so that we can support
2546 ns-resolution time stamps.
2547 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2548 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2549 (EMACS_USECS): Remove.
2550 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2551 so multiply the arg by 1000 before storing it.
2552 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2553 New macros.
2554 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2555 Port to ns-resolution time stamps.
2556 (EMACS_TIME_NEG_P): Remove; replaced by....
2557 (EMACS_TIME_SIGN): New macro.
2558 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2559 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2560 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2561 (make_timeval, make_lisp_time, decode_time_components): New decls.
2562 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2563 that it mishandled time_t overflow. You can't compare by subtracting!
2564 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2565 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2566
2567 * term.c: Include <sys/time.h>.
2568 (timeval_to_Time): New function, for proper overflow wraparound.
2569 (term_mouse_position, term_mouse_click): Use it.
2570
2571 * undo.c (record_first_change): Support higher-resolution time stamps
2572 in the undo buffer.
2573 (Fprimitive_undo): Use them when restoring time stamps.
2574
2575 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2576 (w32_get_internal_run_time):
2577 Port to higher-resolution Emacs time stamps.
2578 (ltime): Now accepts single 64-bit integer, as that's more convenient
2579 for callers.
2580
2581 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2582
2583 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2584 for compatibility with pselect. Support ns-resolution time stamps.
2585
2586 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2587
2588 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2589 Check for time stamp overflow, and support ns-resolution time stamps.
2590
2591 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2592 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2593 (timeval_subtract): Remove; no longer needed.
2594 (XTflash, XTring_bell, x_wait_for_event):
2595 Port to ns-resolution time stamps. Don't assume time_t is signed.
2596
b6a92dfe
CY
25972012-06-22 Chong Yidong <cyd@gnu.org>
2598
2599 * xdisp.c (x_consider_frame_title): Revert last change.
2600
d251c37c
EZ
26012012-06-22 Eli Zaretskii <eliz@gnu.org>
2602
2603 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2604 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2605 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2606 staticidx goes up to 1597 out of 1600 = 0x640.)
2607
f10deafb
PE
26082012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2609
2610 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2611 Otherwise, the umask might be mistakenly 0 while handling input signals.
2612
ec6de1e2
SM
26132012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2614
2615 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2616
28be1ada
DA
26172012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2618
2619 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2620 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2621 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2622 access to `contents' member of Lisp_Vector objects with AREF and ASET
2623 where appropriate.
2624
c6bf3022
CY
26252012-06-19 Chong Yidong <cyd@gnu.org>
2626
2627 * frame.c (delete_frame): When selecting a frame on a different
2628 text terminal, do not alter the terminal's top-frame.
2629
2630 * xdisp.c (format_mode_line_unwind_data): Record the target
2631 frame's selected window and its terminal's top-frame.
2632 (unwind_format_mode_line): Restore them.
2633 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2634 Callers changed.
2635 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2636 since tty frames can be explicitly named.
2637 (prepare_menu_bars): Likewise.
2638
2639 * term.c (Ftty_top_frame): New function.
2640
defd4196
PE
26412012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Port byte-code-meter to modern targets.
2644 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2645 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2646 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2647 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2648 (METER_1, METER_2): Simplify.
2649
1053a871
SM
26502012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2651
2652 * data.c (Fdefalias): Return `symbol' (bug#11686).
2653
b7e8d081
MR
26542012-06-18 Martin Rudalics <rudalics@gmx.at>
2655
2656 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2657 gets killed during executing of this function (Bug#11665).
2658 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2659 (Vkill_buffer_query_functions): In doc-string say that functions
2660 run by this hook should not change the current buffer.
2661
7ea2b339
PE
26622012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2663
2664 Fix recently-introduced process.c problems found by static checking.
2665 * process.c (write_queue_push, write_queue_pop, send_process):
2666 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2667 (write_queue_pop): Fix pointer signedness problem.
2668 (send_process): Remove unused local.
2669
96a313a1
CY
26702012-06-17 Chong Yidong <cyd@gnu.org>
2671
2672 * xdisp.c (redisplay_internal): No need to redisplay terminal
2673 frames that are not on top.
2674
20ca2e94
TN
26752012-06-17 Troels Nielsen <bn.troels@gmail.com>
2676
2677 * process.c (make_process): Initialize write_queue.
2678 (write_queue_push, write_queue_pop): New functions.
2679 (send_process): Use them to maintain correct ordering of process
2680 writes (Bug#10815).
2681
9a900ca9
PE
26822012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2683
310fbfa8
PE
2684 * lisp.h (eassert): Assume C89 or later.
2685 This removes the need for CHECK.
2686 (CHECK): Remove. Its comments about always evaluating its
2687 argument were confusing, as 'eassert' typically does not evaluate
2688 its argument.
2689
27bb1ca4
PE
2690 * coding.c (produce_chars): Use ptrdiff_t, not int.
2691
9a900ca9
PE
2692 * xterm.c (x_draw_underwave): Check for integer overflow.
2693 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2694
41b7f8bc 26952012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2696
2697 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2698 referenced (Bug#11583).
2699
9b0e3eba
AA
27002012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2701
2702 Implement wave-style variant of underlining.
2703 * dispextern.h (face_underline_type): New enum.
2704 (face): Add field for underline type.
2705 * nsterm.m (ns_draw_underwave): New function.
2706 (ns_draw_text_decoration): Use it.
2707 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2708 New functions.
2709 (x_draw_glyph_string): Use them.
2710 * xfaces.c (Qline, Qwave): New Lisp objects.
2711 (check_lface_attrs, merge_face_ref)
1053a871
SM
2712 (Finternal_set_lisp_face_attribute, realize_x_face):
2713 Handle wave-style underline face attributes.
9b0e3eba
AA
2714 * xterm.c (x_draw_underwave): New function.
2715 (x_draw_glyph_string): Use it.
2716
0fb52f11
JB
27172012-06-16 Juanma Barranquero <lekktu@gmail.com>
2718
2719 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2720 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2721 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2722 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2723 ($(BLD)/w32select.$(O)): Update dependencies.
2724
e5560ff7
AS
27252012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2726
2727 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2728 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2729 * character.c (_fetch_multibyte_char_p): Remove.
2730 * alloc.c: Include "character.h" before "buffer.h".
2731 * bidi.c: Likewise.
2732 * buffer.c: Likewise.
2733 * bytecode.c: Likewise.
2734 * callint.c: Likewise.
2735 * callproc.c: Likewise.
2736 * casefiddle.c: Likewise.
2737 * casetab.c: Likewise.
2738 * category.c: Likewise.
2739 * cmds.c: Likewise.
2740 * coding.c: Likewise.
2741 * composite.c: Likewise.
2742 * dired.c: Likewise.
2743 * dispnew.c: Likewise.
2744 * doc.c: Likewise.
2745 * dosfns.c: Likewise.
2746 * editfns.c: Likewise.
2747 * emacs.c: Likewise.
2748 * fileio.c: Likewise.
2749 * filelock.c: Likewise.
2750 * font.c: Likewise.
2751 * fontset.c: Likewise.
2752 * fringe.c: Likewise.
2753 * indent.c: Likewise.
2754 * insdel.c: Likewise.
2755 * intervals.c: Likewise.
2756 * keyboard.c: Likewise.
2757 * keymap.c: Likewise.
2758 * lread.c: Likewise.
2759 * macros.c: Likewise.
2760 * marker.c: Likewise.
2761 * minibuf.c: Likewise.
2762 * nsfns.m: Likewise.
2763 * nsmenu.m: Likewise.
2764 * print.c: Likewise.
2765 * process.c: Likewise.
2766 * regex.c: Likewise.
2767 * region-cache.c: Likewise.
2768 * search.c: Likewise.
2769 * syntax.c: Likewise.
2770 * term.c: Likewise.
2771 * textprop.c: Likewise.
2772 * undo.c: Likewise.
2773 * unexsol.c: Likewise.
2774 * w16select.c: Likewise.
2775 * w32fns.c: Likewise.
2776 * w32menu.c: Likewise.
2777 * window.c: Likewise.
2778 * xdisp.c: Likewise.
2779 * xfns.c: Likewise.
2780 * xmenu.c: Likewise.
2781 * xml.c: Likewise.
2782 * xselect.c: Likewise.
2783
2f07e6af
EZ
27842012-06-16 Eli Zaretskii <eliz@gnu.org>
2785
1053a871
SM
2786 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2787 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2788 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2789 row.
2790 (handle_face_prop): Use chunk-relative overlay string index when
2791 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2792 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2793 the rightmost. (Bug#11720)
2f07e6af 2794
29b83cec
AS
27952012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2796
2797 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2798 (CATEGORY_MEMBER): Enforce 1/0 value.
2799 * category.c (_temp_category_set): Remove.
2800
4c5501e9
EZ
28012012-06-16 Eli Zaretskii <eliz@gnu.org>
2802
2803 * window.c (Fdelete_other_windows_internal)
2804 (Fdelete_window_internal): Don't access frame's mouse highlight
2805 info of the initial frame. (Bug#11677)
2806
2b570124
PE
28072012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2808
e93864f9
PE
2809 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2810 Assume USE_2_TAGS_FOR_INTS.
2811 (xreload): Adjust $tagmask width to match recent lisp.h change.
2812
2b570124
PE
2813 Simplify lisp.h in minor ways that should not affect code.
2814 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2815 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2816 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2817 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2818 (INTTYPEBITS): New macro, for clarity.
2819 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2820 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2821 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2822 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2823 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2824
81755f69
JB
28252012-06-13 Juanma Barranquero <lekktu@gmail.com>
2826
2827 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2828
16192a57
GM
28292012-06-13 Glenn Morris <rgm@gnu.org>
2830
2831 * s/bsd-common.h (BSD4_3):
2832 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2833
646b5f55
AS
28342012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2835
2836 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2837 instead of union.
2838 (XLI, XIL): Define.
1053a871
SM
2839 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2840 Use them.
2841 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2842 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2843 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2844 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2845 * frame.c (delete_frame): Remove outdated comment.
2846 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2847 USE_LISP_UNION_TYPE.
2848 (Fw32_unregister_hot_key): Likewise.
2849 (Fw32_toggle_lock_key): Likewise.
2850 * w32menu.c (add_menu_item): Likewise.
2851 (w32_menu_display_help): Use XIL instead of checking
2852 USE_LISP_UNION_TYPE.
2853 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2854 (init_heap): Likewise.
2855 * w32term.c (w32_read_socket): Update comment.
2856
1d3823c9
GM
28572012-06-13 Glenn Morris <rgm@gnu.org>
2858
c62ff706
GM
2859 * s/usg5-4-common.h, src/s/unixware.h:
2860 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2861
1d3823c9
GM
2862 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2863
bfe3e0a2
PE
28642012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2867 * alloc.c (make_number) [!defined make_number]:
2868 Remove, as lisp.h always defines this now.
2869 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2870 (roundup_size): Verify that it is a power of 2.
2871 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2872 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2873 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2874 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2875 USE_LSB_TAG now is always defined to be either 0 or 1.
2876 All uses changed.
2877 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2878 code works fine either way, and efficiency is not a concern here,
2879 as the union type is for debugging, not for production.
2880 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2881 Use an inline function on all platforms when using the union type,
2882 since this is simpler and 'static inline' can be used portably
2883 within Emacs now.
2884 (LISP_INITIALLY_ZERO): New macro.
2885 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2886 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2887
45fa9c0f
GM
28882012-06-12 Glenn Morris <rgm@gnu.org>
2889
b4492cba
GM
2890 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2891
2892 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2893
45fa9c0f
GM
2894 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2895 Move BROKEN_SIGIO to configure.
2896
2897 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2898 Move NO_TERMIO to configure.
2899
0e25d334
CY
29002012-06-12 Chong Yidong <cyd@gnu.org>
2901
2902 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2903 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2904 MagickExportImagePixels is undefined.
2905
43682bb6
PE
29062012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2907
2908 * image.c (imagemagick_load_image): Remove unused label.
2909
a9be7d2b
GM
29102012-06-11 Glenn Morris <rgm@gnu.org>
2911
2912 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2913 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2914 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2915 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2916
3017f87f
SM
29172012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2918
2919 * alloc.c (make_byte_code): New function.
2920 (Fmake_byte_code): Use it. Don't purify here.
2921 * lread.c (read1): Use it as well to avoid extra allocation.
2922
1b9b4cf4
CY
29232012-06-11 Chong Yidong <cyd@gnu.org>
2924
2925 * image.c (imagemagick_load_image): Implement transparency.
2926
95988fcf
AS
29272012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2928
2929 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2930 account for preceding backslashes. (Bug#11663)
2931
cd4eb164
CY
29322012-06-09 Chong Yidong <cyd@gnu.org>
2933
2934 * term.c: Support italics in capable terminals (Bug#9652).
2935 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2936 (turn_on_face): Output using TS_enter_italic_mode if available.
2937 Don't handle unused blinking and alt-charset cases.
2938 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2939 and tty_alt_charset_p cases.
2940 (tty_capable_p, init_tty): Support italics.
2941
2942 * termchar.h (struct tty_display_info): Add field for italics.
2943 Remove unused blink field.
2944
2945 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2946 Handle slant.
2947
2948 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2949 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2950 tty_alt_charset_p. Add tty_italic_p.
2951
ff88beb8
MA
29522012-06-09 Michael Albinus <michael.albinus@gmx.de>
2953
2954 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2955 dbus_type_is_basic if available.
2956 (xd_extract_signed, xd_extract_unsigned): Rename from
2957 extract_signed and extract_unsigned, respectively. Adapt callers.
2958
44286096
CY
29592012-06-09 Chong Yidong <cyd@gnu.org>
2960
1682701f
CY
2961 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2962
44286096
CY
2963 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2964 case (Bug#9752).
2965
d86feb17
PE
29662012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 * xdisp.c (vmessage): Treat frame message as multibyte.
2969 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2970 would generate the diagnostic "Making \302\247 buffer-local while
2971 let-bound!".
2972
d5c20fe8
EZ
29732012-06-08 Eli Zaretskii <eliz@gnu.org>
2974
2975 * dispnew.c (showing_window_margins_p): Undo last change, which
2976 was done due to an inadvertent commit.
2977 (adjust_frame_glyphs_for_frame_redisplay): Do call
2978 showing_window_margins_p.
2979
513749ee
SM
29802012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2981
2982 * eval.c (Fmake_var_non_special): New primitive.
2983 (syms_of_eval): Defsubr it.
2984 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2985
d4a8f5c1
JB
29862012-06-08 Juanma Barranquero <lekktu@gmail.com>
2987
2988 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2989 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2990
8bbbc977
EZ
29912012-06-08 Eli Zaretskii <eliz@gnu.org>
2992
2993 * alloc.c (allocate_vectorlike): Fix last change.
2994
f3372c87
DA
29952012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2996
2997 Block-based vector allocation of small vectors.
2998 * lisp.h (struct vectorlike_header): New field `nbytes',
2999 adjust comment accordingly.
3000 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3001 to denote vector blocks. Adjust users (live_vector_p,
3002 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3003 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3004 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3005 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3006 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3007 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3008 (roundup_size): New constant.
3009 (struct vector_block): New data type.
3010 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3011 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3012 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3013 (sweep_vectors): New functions.
3014 (allocate_vectorlike): Return `zero_vector' as the only vector of
3015 0 items. Allocate new vector from block if vector size is less than
3016 or equal to VBLOCK_BYTES_MAX.
3017 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3018 (init_alloc_once): Add call to init_vectors.
3019
4f18a4ed
SM
30202012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3021
3022 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3023
86f158bc
PE
30242012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 * doprnt.c (doprnt): Truncate multibyte char correctly.
3027 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3028 would mishandle a string argument "Xc" if X was a multibyte
3029 character of length 2: it would truncate after X's first byte
3030 rather than including all of X.
3031
c5cfcbe0
CY
30322012-06-06 Chong Yidong <cyd@gnu.org>
3033
3034 * buffer.c (word_wrap): Doc fix.
3035
c05cf390
PE
30362012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3037
3038 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3039
0c3461de
GM
30402012-06-03 Glenn Morris <rgm@gnu.org>
3041
3042 * xdisp.c (tool-bar-style): Doc fix.
3043
c71232db
UM
30442012-06-03 Ulrich Müller <ulm@gentoo.org>
3045
3046 * Makefile.in (PAXCTL): Define.
3047 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3048 binary via PaX flags if the paxctl utility is available.
3049 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3050 Restore PaX flags to their default. (Bug#11398)
3051
383f7350
CY
30522012-06-03 Chong Yidong <cyd@gnu.org>
3053
3054 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3055 buffer (Bug#11226).
3056
5f2c76c6
CY
30572012-06-03 Chong Yidong <cyd@gnu.org>
3058
3059 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3060 (note_mode_line_or_margin_highlight): If there is no help echo,
3061 use mode-line-default-help-echo. Handle the case where the mouse
3062 position is past the end of the mode line string.
3063
3064 * buffer.c (buffer_local_value_1): New function, split from
3065 Fbuffer_local_value; can return Qunbound.
3066 (Fbuffer_local_value): Use it.
3067 (Vmode_line_format): Docstring tweaks.
3068
773d47f6
PE
30692012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 * sysdep.c (system_process_attributes): Improve comment.
3072
f2d6a3df
SM
30732012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3074
3075 * keyboard.c: Export real-this-command to Elisp.
3076 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3077 and DEFVAR it. Update all users.
3078
63810350
PE
30792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3080
7bd5c1f4
PE
3081 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3082
63810350
PE
3083 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3084 Convert pctcpu and pctmem to Lisp float properly.
3085 Let the compiler fold better, as 100.0/0x8000 is exact.
3086
a2821611
AS
30872012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3088
3089 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3090 cons_block.
3091
5fceba1d
PE
30922012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3095
c98ff5dd
DA
30962012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3097
3098 For a 'struct window', replace some Lisp_Object fields to
3099 bitfields where appropriate, remove unused fields.
3100 * window.h (struct window): Remove unused 'last_mark_x' and
3101 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3102 change it's type from Lisp_Object to bitfield.
3103 Change type of 'force_start', 'optional_new_start',
3104 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3105 fields from Lisp_Object to bitfield. Adjust users accordingly.
3106
ca34e0be
PE
31072012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Pacify gcc -Wdouble-precision when using Xaw.
3110 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3111 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3112 Use 'float' consistently, rather than 'float' in most places
3113 and 'double' in a couple of places.
3114
efc00ab1 31152012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3116
3117 * xdisp.c (handle_stop): Detect whether we have overlay strings
3118 loaded by testing it->current.overlay_string_index to be
3119 non-negative, instead of checking whether n_overlay_strings is
3120 positive. (Bug#11587)
3121
efc00ab1 31222012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3123
3124 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3125
3126 * doc.c (Fsubstitute_command_keys): Doc fix.
3127
efc00ab1 31282012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3129
3130 * search.c (search_buffer): Remove calls to
3131 r_alloc_inhibit_buffer_relocation, as it is now called by
3132 maybe_unify_char, which was the cause of relocation of buffer text
3133 in bug#11519.
3134
efc00ab1 31352012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3136
3137 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3138 for the duration of call to load_charset, to avoid problems with
3139 callers of maybe_unify_char that access buffer text through C
3140 pointers.
3141
3142 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3143 decrement the inhibition flag, instead of just setting or
3144 resetting it.
3145
ba93a187
PE
31462012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 Remove obsolete '#define static' cruft.
3149 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3150 This #undef was "temporary" in 2000; it is no longer needed
3151 now that '#define static' has gone away.
3152 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3153 (gray_bitmap_bits): Remove; no longer needed.
3154 All uses replaced with definiens.
3155 * xterm.c: Include "bitmaps/gray.xbm".
3156
9e4bf381
PE
31572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 Clean up __executable_start, monstartup when --enable-profiling.
3160 The following changes affect the code only when profiling.
3161 * dispnew.c (__executable_start): Rename from safe_bcopy.
3162 Define only on platforms that need it.
3163 * emacs.c: Include <sys/gmon.h> when profiling.
3164 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3165 (__executable_start): Remove decl, since lisp.h does it now.
3166 (safe_bcopy): Remove decl; no longer has that name.
3167 (main): Coalesce #if into single bit of code, for simplicity.
3168 Cast pointers to uintptr_t, since standard libraries want integers
3169 and not pointers.
3170 * lisp.h (__executable_start): New decl.
3171
32d72c2f
GM
31722012-05-31 Glenn Morris <rgm@gnu.org>
3173
3174 * image.c (Fimagemagick_types): Doc fix.
3175
baac5bc7
JM
31762012-05-30 Jim Meyering <meyering@redhat.com>
3177
3178 * callproc.c (Fcall_process_region): Include directory component
3179 in mkstemp error message (Bug#11586).
3180
72cb32cf
PE
31812012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3182
3183 * alloc.c, lisp.h (make_pure_vector): Now static.
3184
61b108cc
SM
31852012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3186
3187 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3188 Move to byte-run.el.
3189 (Fautoload): Do the hash-doc more carefully.
3190 * data.c (Fdefalias): Purify definition, except for keymaps.
3191 (Qdefun): Move from eval.c.
3192 * lisp.h (Qdefun): Remove.
3193 * lread.c (read1): Tiny simplification.
3194
471fe23d
TN
31952012-05-29 Troels Nielsen <bn.troels@gmail.com>
3196
934f3f58 3197 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3198 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3199 Bug#9642, but explicitly check that the buffer the overlay would
3200 be moved to is live and rearrange lines to make sure that errors
3201 will not put the overlay in an inconsistent state.
3202 (Fdelete_overlay): Cosmetics.
3203
85d0efd1
EZ
32042012-05-28 Eli Zaretskii <eliz@gnu.org>
3205
3206 * w32term.c (my_bring_window_to_top): New function.
3207 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3208 could be different from the original one.
3209 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3210 (Bug#11513)
3211
3212 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3213 by calling BringWindowToTop.
3214
3215 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3216 (WM_EMACS_END): Increase by one.
3217
da92a98c
PE
32182012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3219
3220 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3221 This avoids undefined behavior that might cause the eassert
3222 to not catch an out-of-range value.
3223
74d1f848
JB
32242012-05-28 Juanma Barranquero <lekktu@gmail.com>
3225
3226 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3227 Update dependencies.
3228
9e1a06fc
EZ
32292012-05-27 Eli Zaretskii <eliz@gnu.org>
3230
3231 * bidi.c (bidi_mirror_char): Fix last change.
3232
f3dd7312
AS
32332012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3234
3235 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3236 when referring to sectname field in printf format.
3237
81899c91
PE
32382012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3239
57b81a9f
PE
3240 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3241 Only r_alloc_inhibit_buffer_relocation needed to be added;
3242 the others were already declared.
3243
81899c91
PE
3244 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3245 before checking whether it's out of range. Put the check inside
3246 eassert. See
3247 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3248
33017faf 32492012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3250
3251 * callproc.c (Fcall_process): Restore a line that was accidentally
3252 commented out in the 2011-02-13 change (bug#11547).
3253
33017faf 32542012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3255
3256 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3257 defined on ralloc.c.
3258
3259 * buffer.c [REL_ALLOC]: Remove prototypes of
3260 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3261 they are now on lisp.h.
3262
3263 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3264
3265 * search.c (search_buffer): Use it to inhibit relocation of buffer
3266 text while re_search_2 is doing its job, because re_search_2 is
3267 passed C pointers to buffer text. (Bug#11519)
3268
23415acf
EZ
3269 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3270 Update value to 24.
3271
44e27368
EZ
3272 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3273 state after an additional call to move_it_in_display_line_to, keep
3274 the values of it->max_ascent and it->max_descent found for the
3275 entire line.
3276 (pos_visible_p): Revert the comparison against bottom_y to what it
3277 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3278 (Bug#11464)
3279
c1892f11
PE
32802012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3281
3282 Fix coding-related core dumps with gcc -ftrapv.
3283 The code was computing A - B, where A and B are pointers, and B is
3284 random garbage. This can lead to core dumps on platforms that
3285 have special pointer registers, and it also leads to core dumps on
3286 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3287 A - B only when B is initialized properly.
3288 * coding.c (coding_set_source, coding_set_destination): Return void.
3289 (coding_change_source, coding_change_destinations): New functions,
3290 with the old behaviors of coding_set_source and coding_set_destination.
3291 All callers that need an offset changed to use these new functions.
3292
eb7afdad
GM
32932012-05-26 Glenn Morris <rgm@gnu.org>
3294
3295 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3296
f12fdf02
EZ
32972012-05-26 Eli Zaretskii <eliz@gnu.org>
3298
53a63be6 3299 Extend mouse support on W32 text-mode console.
61b108cc
SM
3300 * xdisp.c (draw_row_with_mouse_face):
3301 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3302
eb3f6f01 3303 * w32console.c: Include window.h.
61b108cc
SM
3304 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3305 New functions.
eb3f6f01
EZ
3306 (initialize_w32_display): Initialize mouse-highlight data.
3307
53a63be6
EZ
3308 * w32inevt.c: Include termchar.h and window.h.
3309 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3310 moves, call note_mouse_highlight. If help_echo changed, call
3311 gen_help_event to produce help-echo message in the echo area.
3312 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3313 highlight info.
3314
4cfd81f6
PE
33152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 * lread.c (read1): Simplify slightly to avoid an overflow warning
3318 with GCC 4.7.0 on x86-64.
3319
4446092a
EZ
33202012-05-26 Eli Zaretskii <eliz@gnu.org>
3321
3322 * bidi.c (bidi_mirror_char): Revert last change: an int is
3323 definitely wide enough here.
3324
42b2a986 33252012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3326
42b2a986 3327 Fix integer width and related bugs (Bug#9874).
eb106a49 3328 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3329 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3330 (string_bytes, check_sblock, allocate_string_data):
3331 (compact_small_strings, Fmake_bool_vector, make_string)
3332 (make_unibyte_string, make_multibyte_string)
3333 (make_string_from_bytes, make_specified_string)
3334 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3335 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3336 (mark_vectorlike):
3337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3338 (allocate_pseudovector):
3339 Use int, not EMACS_INT, where int is wide enough.
3340 (inhibit_garbage_collection, Fgarbage_collect):
3341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3342 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3343 int might not be wide enough.
3344 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3345 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3346 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3347 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3348 (bidi_level_of_next_char, bidi_move_to_visually_next):
3349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3350 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3351 (Fkill_buffer, Fset_buffer_major_mode)
3352 (advance_to_char_boundary, Fbuffer_swap_text)
3353 (Fset_buffer_multibyte, overlays_at, overlays_in)
3354 (overlay_touches_p, struct sortvec, record_overlay_string)
3355 (overlay_strings, recenter_overlay_lists)
3356 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3357 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3358 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3359 (Foverlay_recenter, last_overlay_modification_hooks_used)
3360 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3362 (validate_region): Omit unnecessary test for b <= e,
3363 since that's guaranteed by the previous test.
d311d28c
PE
3364 (adjust_overlays_for_delete): Avoid pos + length overflow.
3365 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3366 (report_overlay_modification):
3367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3368 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3369 Omit pointer cast, which isn't needed anyway, and doesn't work
3370 after the EMACS_INT -> ptrdiff_t change.
02481186 3371 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3372 * buffer.h: Adjust decls to match defn changes elsewhere.
3373 (struct buffer_text, struct buffer):
3374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3375 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3376 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3377 not int, to avoid needless 32-bit limit on 64-bit hosts.
3378 (exec_byte_code): Use tighter memory-full test, one that checks
3379 for alloca overflow. Don't compute the address of the object just
3380 before an array, as that's not portable. Use EMACS_INT, not
3381 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3382 * callint.c (Fcall_interactively):
3383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3384 * callproc.c (call_process_kill, Fcall_process):
3385 Don't assume pid_t fits into an Emacs fixnum.
3386 (call_process_cleanup, Fcall_process, child_setup):
3387 Don't assume pid_t fits into int.
3388 (call_process_cleanup, Fcall_process, delete_temp_file)
3389 (Fcall_process_region):
3390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3391 (Fcall_process): Simplify handling of volatile integers.
3392 Use int, not EMACS_INT, where int will do.
3393 * casefiddle.c (casify_object, casify_region, operate_on_word)
3394 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3396 (casify_object): Avoid integer overflow when overallocating buffer.
3397 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3398 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3399 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3400 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3401 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3402 integers are now checked earlier. All uses replaced with XINT.
3403 (ccl_driver):
3404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3405 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3406 (ccl_driver, Fregister_code_conversion_map):
3407 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3408 (resolve_symbol_ccl_program): Check that vector header is in range.
3409 Always copy the vector, so that we can check its contents reliably
3410 now rather than having to recheck each instruction as it's being
3411 executed. Check that vector words fit in 'int'.
3412 (ccl_get_compiled_code, Fregister_ccl_program)
3413 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3414 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3415 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3416 contents are in range.
3417 (Fccl_execute_on_string): Check that status is in range.
3418 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3419 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3420 Accept and return EMACS_INT, not int, because callers can pass values
3421 out of 'int' range.
3422 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3423 (multibyte_chars_in_text, parse_str_as_multibyte)
3424 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3425 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3426 (string_escape_byte8, Fget_byte):
3427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3428 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3429 avoid mishandling large integers.
3430 * character.h: Adjust decls to match defn changes elsewhere.
3431 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3432 (Ffind_charset_region):
3433 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3434 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3435 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3436 Don't assume fixnum fits in int.
d311d28c
PE
3437 (load_charset_map_from_vector, Fmap_charset_chars):
3438 Remove now-unnecessary CHECK_NATNUMs.
3439 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3440 Don't rely on undefined behavior with signed left shift overflow.
3441 Don't assume unsigned int fits into fixnum, or that fixnum fits
3442 into unsigned int. Don't require max_code to be a valid fixnum;
3443 that's not true for gb10830 4-byte on a 32-bit host. Allow
3444 invalid_code to be a cons, for the same reason. Require code_offset
3445 to be a character. Avoid int overflow if max_char is close
3446 to INT_MAX.
3447 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3448 this is intended anyway and avoids some undefined behavior.
3449 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3450 INDEX_TO_CODE_POINT, as that's what it expects.
3451 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3452 * charset.h (DECODE_CHAR): Return int, not unsigned;
3453 this is what was intended anyway, and it avoids undefined behavior.
3454 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3455 integer-overflow issues.
3456 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3457 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3458 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3459 * chartab.c (Fmake_char_table, Fset_char_table_range)
3460 (uniprop_get_decoder, uniprop_get_encoder):
3461 Don't assume fixnum fits in int.
3462 * cmds.c (move_point): New function, that does the gist of
3463 Fforward_char and Fbackward_char, but does so while checking
3464 for integer overflow more accurately.
c96e5d6a 3465 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3466 (Fforward_line, Fend_of_line, internal_self_insert)
3467 (internal_self_insert):
3468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3469 Fix a FIXME, by checking for integer overflow when calculating
3470 target_clm and actual_clm.
3471 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3472 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3473 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3474 (coding_alloc_by_making_gap, alloc_destination)
3475 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3476 (encode_coding_utf_16, detect_coding_emacs_mule)
3477 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3478 (detect_coding_iso_2022, decode_coding_iso_2022)
3479 (encode_invocation_designation, encode_designation_at_bol)
3480 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3481 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3482 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3483 (encode_coding_ccl, encode_coding_raw_text)
3484 (detect_coding_charset, decode_coding_charset)
3485 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3486 (produce_composition, produce_charset, produce_annotation)
3487 (decode_coding, handle_composition_annotation)
3488 (handle_charset_annotation, consume_chars, decode_coding_gap)
3489 (decode_coding_object, encode_coding_object, detect_coding_system)
3490 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3491 (code_convert_region, code_convert_string)
8f50130c
PE
3492 (Fdefine_coding_system_internal)
3493 (coding_set_source, coding_set_destination):
d311d28c
PE
3494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3495 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3496 (Fdefine_coding_system_internal):
3497 Don't assume fixnums fit in int.
3498 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3499 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3500 (Funencodable_char_position, Fcheck_coding_systems_region)
3501 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3503 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3504 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3505 Don't access memory outside of the args array.
d311d28c 3506 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3507 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3508 result of ENCODE_CHAR.
d311d28c
PE
3509 * coding.h: Adjust decls to match defn changes elsewhere.
3510 (struct coding_system):
3511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3512 * composite.c (get_composition_id, find_composition)
3513 (run_composition_function, update_compositions)
3514 (compose_text, composition_gstring_put_cache)
3515 (composition_gstring_p, composition_gstring_width)
3516 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3517 (composition_compute_stop_pos, composition_reseat_it)
3518 (composition_update_it, struct position_record)
3519 (find_automatic_composition, composition_adjust_point)
3520 (Fcomposition_get_gstring, Ffind_composition_internal):
3521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3522 (update_compositions):
3523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3524 * composite.h: Adjust decls to match defn changes elsewhere.
3525 (struct composition):
3526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3527 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3528 Do not attempt to compute the address of the object just before a
3529 buffer; this is not portable.
3530 (Faref, Faset):
3531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3532 (Faset): Use int, not EMACS_INT, where int is wide enough.
3533 (Fstring_to_number): Don't assume fixnums fit in int.
3534 (Frem): Don't assume arg is nonnegative.
3535 * dbusbind.c (xd_append_arg): Check for integers out of range.
3536 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3537 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3538 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3539 (xd_get_connection_references): Return ptrdiff_t, not int.
3540 All uses changed.
3541 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3542 (xd_read_message_1):
3543 Use int, not unsigned, where the dbus API uses int.
3544 (Fdbus_message_internal): Don't overflow mtype.
3545 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3546 * dired.c (directory_files_internal, file_name_completion, scmp)
3547 (file_name_completion_stat):
3548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3549 (file_name_completion): Don't overflow matchcount.
3550 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3551 * dispextern.h: Adjust decls to match defn changes elsewhere.
3552 (struct text_pos, struct glyph, struct bidi_saved_info)
3553 (struct bidi_string_data, struct bidi_it, struct composition_it)
3554 (struct it):
3555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3556 (struct display_pos, struct composition_it, struct it):
3557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3558 * dispnew.c (increment_matrix_positions)
3559 (increment_row_positions, mode_line_string)
3560 (marginal_area_string):
3561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3562 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3564 (duration_to_sec_usec): New function, to check for overflow better.
3565 (Fsleep_for, sit_for): Use it.
3566 * doc.c (get_doc_string, store_function_docstring):
3567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3568 (get_doc_string, Fsnarf_documentation):
3569 Use int, not EMACS_INT, where int is wide enough.
3570 (get_doc_string):
3571 Use SAFE_ALLOCA, not alloca.
3572 Check for overflow when converting EMACS_INT to off_t.
3573 * doprnt.c (doprnt):
3574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3575 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3576 Don't assume uid_t fits into fixnum.
3577 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3578 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3579 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3580 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3581 (general_insert_function)
3582 (Finsert_char, make_buffer_string, make_buffer_string_both)
3583 (update_buffer_properties, Fbuffer_substring)
3584 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3585 (Fsubst_char_in_region, check_translation)
3586 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3587 (transpose_markers, Ftranspose_regions):
3588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3589 (clip_to_bounds): Move to lisp.h as an inline function).
3590 (Fconstrain_to_field): Don't assume integers are nonnegative.
3591 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3592 (Fsubst_char_in_region, Fsave_restriction):
3593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3594 (Femacs_pid): Don't assume pid_t fits into fixnum.
3595 (lo_time): Use int, not EMACS_INT, when int suffices.
3596 (lisp_time_argument): Check for usec out of range.
3597 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3598 (Fuser_login_name, Fuser_full_name): Signal an error
3599 if a uid argument is out of range, rather than relying on
3600 undefined behavior.
c8d5c857
PE
3601 (Fformat_time_string): Remove now-unnecessary check.
3602 lisp_time_argument checks for out-of-range usec now.
243e0530 3603 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3604 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3605 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3606 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3607 (init_cmdargs, Fdump_emacs):
3608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3609 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3610 the bottom (typically) 32 bits of the fixnum.
3611 * eval.c (specpdl_size, call_debugger):
3612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3613 (when_entered_debugger, Fbacktrace_debug):
3614 Don't assume fixnum can fit in int.
3615 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3616 the object just before a buffer; this is not portable.
3617 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3618 (grow_specpdl, unbind_to):
3619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3620 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3621 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3622 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3623 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3624 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3626 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3627 (a_write, e_write):
3628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3629 (Fcopy_file, non_regular_nbytes, read_non_regular)
3630 (Finsert_file_contents):
3631 Use int, not EMACS_INT, where int is wide enough.
3632 (READ_BUF_SIZE): Verify that it fits in int.
3633 (Finsert_file_contents): Check that counts are in proper range,
3634 rather than assuming fixnums fit into ptrdiff_t etc.
3635 Don't assume fixnums fit into int.
125b3835 3636 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3637 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3638 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3639 (string_char_to_byte, string_byte_to_char)
3640 (string_make_multibyte, string_to_multibyte)
3641 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3642 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3643 (substring_both, Fdelete, internal_equal, Ffillarray)
3644 (Fclear_string, mapcar1)
3645 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3646 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3647 (larger_vector, make_hash_table, maybe_resize_hash_table)
3648 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3649 (Fmaphash, secure_hash):
3650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3651 (concat): Check for string index and length overflow.
3652 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3653 (Frequire):
3654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3655 (larger_vector): New API (vec, incr_min, size_max) replaces old
3656 one (vec, new_size, init). This catches size overflow.
3657 INIT was removed because it was always Qnil.
3658 All callers changed.
3659 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3660 the upper bound on a hash table index size.
3661 (make_hash_table, maybe_resize_hash_table): Use it.
3662 (secure_hash): Computer start_byte and end_byte only after
3663 they're known to be in ptrdiff_t range.
3664 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3665 (Ffont_get_glyphs, Ffont_at):
3666 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3667 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3668 (Flist_fonts, Fopen_font):
3669 Don't assume fixnum can fit in int.
3670 (check_gstring): Don't assume index can fit in int.
3671 (font_match_p): Check that fixnum is a character, not a nonnegative
3672 fixnum, since the later code needs to stuff it into an int.
3673 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3674 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3675 conversion overflow issues.
3676 (Fopen_font): Check for integer out of range.
3677 (Ffont_get_glyphs): Don't assume index can fit in int.
3678 * font.h: Adjust decls to match defn changes elsewhere.
3679 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3680 integer overflow.
3681 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3682 printmax_t, where ptrdiff_t is wide enough.
3683 (Finternal_char_font):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3686 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3687 (Fset_frame_position, x_set_frame_parameters)
3688 (x_set_line_spacing, x_set_border_width)
3689 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3690 Check that fixnums are in proper range for system types.
3691 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3693 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3694 Use SAFE_ALLOCA_LISP, not alloca.
3695 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3696 intptr_t is wide enough.
3697 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3698 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3699 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3700 Check for fixnum out of range.
3701 * ftfont.c (ftfont_list): Don't assume index fits in int.
3702 Check that fixnums are in proper range for system types.
3703 (ftfont_shape_by_flt):
3704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3705 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3707 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3708 Check that fixnums are in proper range for system types.
3709 * gnutls.h: Adjust decls to match defn changes elsewhere.
3710 * gtkutil.c (xg_dialog_run):
3711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3712 (update_frame_tool_bar):
3713 Check that fixnums are in proper range for system types.
3714 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3715 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3716 * indent.c (last_known_column, last_known_column_point):
3717 (current_column_bol_cache):
3718 (skip_invisible, current_column, check_display_width):
3719 (check_display_width, scan_for_column, current_column_1)
3720 (Findent_to, Fcurrent_indentation, position_indentation)
3721 (indented_beyond_p, Fmove_to_column, compute_motion):
3722 (Fcompute_motion, Fvertical_motion):
3723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3724 (last_known_column_modified): Use EMACS_INT, not int.
3725 (check_display_width):
3726 (Fcompute_motion):
3727 Check that fixnums and floats are in proper range for system types.
3728 (compute_motion): Don't assume index or fixnum fits in int.
3729 (compute_motion, Fcompute_motion):
3730 Use int, not EMACS_INT, when it is wide enough.
3731 (vmotion): Omit local var start_hpos that is always 0; that way
3732 we don't need to worry about overflow in expressions involving it.
3733 * indent.h: Adjust decls to match defn changes elsewhere.
3734 (struct position):
3735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3736 Use int, not EMACS_INT, where int is wide enough.
3737 Remove unused members ovstring_chars_done and tab_offset;
3738 all uses removed.
3739 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3740 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3741 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3742 (make_gap, copy_text, insert, insert_and_inherit)
3743 (insert_before_markers, insert_before_markers_and_inherit)
3744 (insert_1, count_combining_before, count_combining_after)
3745 (insert_1_both, insert_from_string)
3746 (insert_from_string_before_markers, insert_from_string_1)
3747 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3748 (adjust_after_replace, adjust_after_insert, replace_range)
3749 (replace_range_2, del_range, del_range_1, del_range_byte)
3750 (del_range_both, del_range_2, modify_region)
3751 (prepare_to_modify_buffer, signal_before_change)
3752 (signal_after_change, Fcombine_after_change_execute):
3753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3754 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3755 (balance_an_interval, split_interval_right, split_interval_left)
3756 (find_interval, next_interval, update_interval)
3757 (adjust_intervals_for_insertion, delete_node, delete_interval)
3758 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3759 (static_offset_intervals, offset_intervals)
3760 (merge_interval_right, merge_interval_left, make_new_interval)
3761 (graft_intervals_into_buffer, temp_set_point_both)
3762 (temp_set_point, set_point, adjust_for_invis_intang)
3763 (set_point_both, move_if_not_intangible, get_property_and_range)
3764 (get_local_map, copy_intervals, copy_intervals_to_string)
3765 (compare_string_intervals, set_intervals_multibyte_1):
3766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3767 * intervals.h: Adjust decls to match defn changes elsewhere.
3768 (struct interval):
3769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3770 * keyboard.c (this_command_key_count, this_single_command_key_start)
3771 (before_command_key_count, before_command_echo_length, echo_now)
3772 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3773 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3774 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3775 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3777 (last_non_minibuf_size, last_point_position, echo_truncate)
3778 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3779 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3780 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3781 (stuff_buffered_input):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (last_auto_save, command_loop_1, read_char):
3784 Use EMACS_INT, not int, to avoid integer overflow.
3785 (record_char): Avoid overflow in total_keys computation.
3786 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3787 * keyboard.h: Adjust decls to match defn changes elsewhere.
3788 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3789 (Fkey_description, Fdescribe_vector, Flookup_key):
3790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3791 (click_position): New function, to check that positions are in range.
3792 (Fcurrent_active_maps):
3793 (describe_command):
3794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3795 (Faccessible_keymaps, Fkey_description):
3796 (preferred_sequence_p):
3797 Don't assume fixnum can fit into int.
3798 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3799 Check for integer overflow in size calculations.
3800 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3801 avoid mishandling large integers.
3802 * lisp.h: Adjust decls to match defn changes elsewhere.
3803 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3804 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3805 (struct Lisp_Marker):
3806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3807 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3808 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3809 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3810 All callers changed.
3811 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3812 Assume the arg has valid form, since it always does.
3813 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3814 unsigned integer system type.
3815 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3816 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3818 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3819 (duration_to_sec_usec): New decl.
3820 * lread.c (read_from_string_index, read_from_string_index_byte)
3821 (read_from_string_limit, readchar, unreadchar, openp)
3822 (read_internal_start, read1, oblookup):
3823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3824 (Fload, readevalloop, Feval_buffer, Feval_region):
3825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3826 (openp): Check for out-of-range argument to 'access'.
3827 (read1): Use int, not EMACS_INT, where int is wide enough.
3828 Don't assume fixnum fits into int.
6efdadfd 3829 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3830 (read_filtered_event): Use duration_to_sec_usec
3831 to do proper overflow checking on durations.
d311d28c
PE
3832 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3833 in size calculation.
3834 (Fexecute_kbd_macro):
3835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3836 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3837 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3838 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3839 (set_marker_both, set_marker_restricted_both, marker_position)
3840 (marker_byte_position, Fbuffer_has_markers_at):
3841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3842 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3843 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3844 It now merely ensures that the menu is large enough, without
3845 necessarily growing it, as this avoids some integer overflow issues.
3846 All callers changed.
3847 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3849 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3850 Use SAFE_ALLOCA_LISP, not alloca.
3851 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3852 to EMACS_INT. Check that fixnums are in proper range for system types.
3853 * minibuf.c (minibuf_prompt_width, string_to_object)
3854 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3855 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3857 (get_minibuffer, read_minibuf_unwind):
3858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3859 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3860 this simplifies overflow checking. All callers changed.
3861 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3862 (Ftest_completion):
3863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3864 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3865 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3866 Check that fixnums are in proper range for system types.
3867 (Fx_create_frame, Fx_show_tip):
3868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3869 * nsfont.m (ns_findfonts, nsfont_list_family):
3870 Don't assume fixnum fits in long.
3871 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3873 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3874 wide enough.
17fdb222 3875 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3877 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3878 (PRINTDECLARE, PRINTPREPARE):
3879 (strout, print_string):
3880 (print, print_preprocess, print_check_string_charset_prop)
3881 (print_object):
3882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3883 (PRINTDECLARE):
3884 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3885 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3886 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3887 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3888 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3889 (print_error_message): Use SAFE_ALLOCA, not alloca.
3890 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3891 (print_depth, new_backquote_output, print_number_index):
3892 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3893 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3894 (Fset_process_window_size, Fformat_network_address)
3895 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3896 (sigchld_handler):
d311d28c 3897 Check that fixnums are in proper range for system types.
d44287d4 3898 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3899 Check for process-ids out of pid_t range rather than relying on
3900 undefined behavior.
e4d81efc 3901 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3902 (Fformat_network_address, read_process_output, send_process)
3903 (Fprocess_send_region, status_notify):
3904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3905 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3906 (wait_reading_process_output, read_process_output, exec_sentinel):
3907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3908 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3909 (Faccept_process_output): Use duration_to_sec_usec to do proper
3910 overflow checking on durations.
dde14581
PE
3911 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3912 Don't assume pid_t fits in int.
02481186
PE
3913 * process.h (struct Lisp_Process): Members tick and update_tick
3914 are now of type EMACS_INT, not int.
b62b53e8
PE
3915 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3916 configured --with-wide-int.
d311d28c
PE
3917 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3918 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3919 * search.c (looking_at_1, string_match_1):
3920 (fast_string_match, fast_c_string_match_ignore_case)
3921 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3922 (scan_newline, find_before_next_newline, search_command)
3923 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3924 (set_search_regs, wordify):
3925 (Freplace_match):
3926 (Fmatch_data):
3927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3928 (string_match_1, search_buffer, set_search_regs):
3929 (Fmatch_data):
3930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 (wordify): Check for overflow in size calculation.
3932 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3933 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3934 Check that fixnums are in proper range for system types.
3935 * sound.c (struct sound_device)
3936 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3938 (Fplay_sound_internal):
3939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3940 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3941 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3942 (Fparse_partial_sexp):
3943 Don't assume fixnums can fit in int.
3944 (struct lisp_parse_state, find_start_pos, find_start_value)
3945 (find_start_value_byte, find_start_begv)
3946 (update_syntax_table, char_quoted, dec_bytepos)
3947 (find_defun_start, prev_char_comend_first, back_comment):
3948 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3949 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3951 (Finternal_describe_syntax_value): Check that match_lisp is a
3952 character, not an integer, since the code stuffs it into int.
3953 (scan_words, scan_sexps_forward):
3954 Check that fixnums are in proper range for system types.
3955 (Fforward_word):
3956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3957 (scan_sexps_forward):
3958 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3959 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3960 * syntax.h: Adjust decls to match defn changes elsewhere.
3961 (struct gl_state_s):
3962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3963 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3964 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3965 * sysdep.c (wait_for_termination_1, wait_for_termination)
3966 (interruptible_wait_for_termination, mkdir):
3967 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3968 (emacs_read, emacs_write):
3969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3970 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3971 and double all fit in int.
d311d28c
PE
3972 * term.c (set_tty_color_mode):
3973 Check that fixnums are in proper range for system types.
3974 * termhooks.h (struct input_event):
3975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3976 * textprop.c (validate_interval_range, interval_of)
3977 (Fadd_text_properties, set_text_properties_1)
3978 (Fremove_text_properties, Fremove_list_of_text_properties)
3979 (Ftext_property_any, Ftext_property_not_all)
3980 (copy_text_properties, text_property_list, extend_property_ranges)
3981 (verify_interval_modification):
3982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3983 (Fnext_single_char_property_change)
3984 (Fprevious_single_char_property_change):
3985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3986 (copy_text_properties):
3987 Check for integer overflow in index calculation.
d311d28c
PE
3988 * undo.c (last_boundary_position, record_point, record_insert)
3989 (record_delete, record_marker_adjustment, record_change)
3990 (record_property_change):
3991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3992 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3994 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3995 (Fx_hide_tip, Fx_file_dialog):
3996 * w32menu.c (set_frame_menubar):
3997 Use ptrdiff_t, not int, for consistency with rest of code.
3998 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3999 (select_window, Fdelete_other_windows_internal)
4000 (window_scroll_pixel_based, window_scroll_line_based)
4001 (Frecenter, Fset_window_configuration):
4002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4003 (Fset_window_hscroll, run_window_configuration_change_hook)
4004 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4005 (Fscroll_other_window, Frecenter):
d311d28c
PE
4006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4007 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4008 Don't assume fixnum fits in int.
4009 (Fset_window_scroll_bars):
4010 Check that fixnums are in proper range for system types.
4011 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4012 (string_pos, c_string_pos, number_of_chars, init_iterator)
4013 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4014 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4015 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4016 (face_before_or_after_it_pos, handle_invisible_prop)
4017 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4018 (display_prop_intangible_p, string_buffer_position_lim)
4019 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4020 (get_overlay_strings_1, get_overlay_strings)
4021 (iterate_out_of_display_property, forward_to_next_line_start)
4022 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4023 (get_next_display_element, set_iterator_to_next)
4024 (get_visually_first_element, compute_stop_pos_backwards)
4025 (handle_stop_backwards, next_element_from_buffer)
4026 (move_it_in_display_line_to, move_it_in_display_line)
4027 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4028 (add_to_log, message_dolog, message_log_check_duplicate)
4029 (message2, message2_nolog, message3, message3_nolog
4030 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4031 (current_message_1, truncate_echo_area, truncate_message_1)
4032 (set_message, set_message_1, store_mode_line_noprop)
4033 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4034 (text_outside_line_unchanged_p, check_point_in_composition)
4035 (reconsider_clip_changes)
4036 (redisplay_internal, set_cursor_from_row, try_scrolling)
4037 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4038 (redisplay_window, find_last_unchanged_at_beg_row)
4039 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4040 (trailing_whitespace_p, find_row_edges, display_line)
4041 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4042 (display_mode_element, store_mode_line_string)
4043 (pint2str, pint2hrstr, decode_mode_spec)
4044 (display_count_lines, display_string, draw_glyphs)
4045 (x_produce_glyphs, x_insert_glyphs)
4046 (rows_from_pos_range, mouse_face_from_buffer_pos)
4047 (fast_find_string_pos, mouse_face_from_string_pos)
4048 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4050 (safe_call, init_from_display_pos, handle_fontified_prop)
4051 (handle_single_display_spec, load_overlay_strings)
4052 (with_echo_area_buffer, setup_echo_area_for_printing)
4053 (display_echo_area, echo_area_display)
4054 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4055 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4056 (redisplay_window, dump_glyph_row, display_mode_line)
4057 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4058 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4060 (handle_single_display_spec, build_desired_tool_bar_string)
4061 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4062 (get_specified_cursor_type):
4063 Check that fixnums are in proper range for system types.
4064 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4065 (Flookup_image_map):
4066 Don't assume fixnums fit in int.
4067 (compare_overlay_entries):
4068 Avoid mishandling comparisons due to subtraction overflow.
4069 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4070 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4071 (handle_tool_bar_click):
4072 Use int, not unsigned, since we prefer signed and the signedness
4073 doesn't matter here.
4074 (get_next_display_element, next_element_from_display_vector):
4075 Use int, not EMACS_INT, when int is wide enough.
4076 (start_hourglass): Use duration_to_sec_usec to do proper
4077 overflow checking on durations.
4078 * xfaces.c (Fbitmap_spec_p):
4079 Check that fixnums are in proper range for system types.
4080 (compare_fonts_by_sort_order):
4081 Avoid mishandling comparisons due to subtraction overflow.
4082 (Fx_family_fonts, realize_basic_faces):
4083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4084 (Fx_family_fonts):
4085 Don't assume fixnum fits in int.
4086 Use SAFE_ALLOCA_LISP, not alloca.
4087 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4088 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4089 (face_at_buffer_position, face_for_overlay_string)
4090 (face_at_string_position):
4091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4092 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4093 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4094 (Fx_show_tip):
4095 Check that fixnums are in proper range for system types.
4096 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4097 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4099 (Fx_change_window_property): Don't assume fixnums fit in int.
4100 * xfont.c (xfont_chars_supported):
4101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4102 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4103 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4105 * xml.c (parse_region):
4106 * xrdb.c (magic_file_p):
4107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4108 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4109 (x_get_local_selection, x_reply_selection_request)
4110 (x_handle_selection_request, wait_for_property_change):
4111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4112 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4113 short is wide enough.
4114 (x_send_client_event): Don't assume fixnum fits in int.
4115 * xterm.c (x_x_to_emacs_modifiers):
4116 Don't assume EMACS_INT overflows nicely into int.
4117 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4118 may come from Lisp.
4119 (handle_one_xevent): NATNUMP can eval its arg twice.
4120 (x_connection_closed):
4121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4122 * xterm.h: Adjust decls to match defn changes elsewhere.
4123 (struct scroll_bar): Use struct vectorlike_header
4124 rather than rolling our own approximation.
4125 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4126
c6574eb5
GM
41272012-05-25 Glenn Morris <rgm@gnu.org>
4128
4129 * lisp.mk (lisp): Update for more files being compiled now.
4130
e8d32c7e
SM
41312012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4132
48def666
SM
4133 * lread.c: Remove `read_pure' which makes no difference.
4134 (read_pure): Remove var.
4135 (unreadpure): Remove function.
4136 (readevalloop): Don't call read_list with -1 flag.
4137 (read1, read_vector): Don't test read_pure any more.
4138 (read_list): Simplify.
4139
e8d32c7e
SM
4140 * fileio.c, character.h: Minor style tweaks.
4141
4b2addb7
DA
41422012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4143
4144 * window.h (clip_changed): Remove useless declaration.
4145
584461b2
JB
41462012-05-22 Juanma Barranquero <lekktu@gmail.com>
4147
4148 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4149 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4150
34374650
PE
41512012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4152
4153 Remove src/m/*.
4154 This directory predates autoconf and is no longer needed nowadays.
4155 Move its few remaining bits of functionality to where they're needed.
4156 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4157 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4158 * m/template.h: Remove.
4159 * Makefile.in (M_FILE): Remove. All uses removed.
4160 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4161 * lisp.h (USE_LSB_TAG):
4162 * mem-limits.h (EXCEEDS_LISP_PTR):
4163 Use VAL_MAX, not VALBITS, in #if.
4164 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4165 (EMACS_UINT): Define unconditionally now.
4166 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4167 (BITS_PER_EMACS_INT): New constants, replacing
4168 what used to be in config.h, but not useful in #if.
4169 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4170 define them any more.
4171 (VAL_MAX): New macro.
4172 (VALMASK): Use it.
4173 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4174 BITS_PER_EMACS_INT, in #if.
4175 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4176 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4177 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4178 * s/ms-w32.h (DATA_START):
4179 Move here from removed file m/intel386.h.
4180 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4181 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4182
261cb4bb
PE
41832012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4184
4185 Assume C89 or later.
4186 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4187 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4188 (xrealloc):
4189 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4190 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4191 * textprop.c, tparam.c (NULL): Remove.
4192 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4193 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4194 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4195 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4196 * xterm.c (input_signal_count): Assume volatile works.
4197
ff23cd9f
KB
41982012-05-21 Ken Brown <kbrown@cornell.edu>
4199
4200 * xgselect.c (xg_select): Fix first argument in call to 'select'
4201 (bug#11508).
4202
1b170bc6
KB
42032012-05-20 Ken Brown <kbrown@cornell.edu>
4204
4205 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4206 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4207
b2f4d39f
KB
42082012-05-19 Ken Brown <kbrown@cornell.edu>
4209
4210 * xfns.c (x_in_use): Remove `static' qualifier.
4211 * xterm.h (x_in_use): Declare.
4212 * xgselect.c: Include xterm.h.
4213 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4214 and `display_arg' (bug#9754).
4215
003fdae2
PE
42162012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4217
9232a6d9
PE
4218 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4219
003fdae2
PE
4220 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4221 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4222
784b56e2
EZ
42232012-05-18 Eli Zaretskii <eliz@gnu.org>
4224
4225 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4226
4227 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4228 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4229
4230 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4231 reference to image_cache->refcount.
4232 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4233
a0a79cde
JL
42342012-05-17 Juri Linkov <juri@jurta.org>
4235
4236 * search.c (Fword_search_regexp, Fword_search_backward)
4237 (Fword_search_forward, Fword_search_backward_lax)
4238 (Fword_search_forward_lax): Move functions to isearch.el
4239 (bug#10145, bug#11381).
4240
b0572523
PE
42412012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4242
4243 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4244
9660f5fc
SM
42452012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4246
4247 * lread.c (init_obarray): Declare Qt and Qnil as special.
4248
4374de83
GM
42492012-05-14 Glenn Morris <rgm@gnu.org>
4250
4251 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4252 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4253
dc44c39a
PE
42542012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4255
078c97cb
PE
4256 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4257
dc44c39a
PE
4258 * unexaix.c: Port to more-recent AIX compilers.
4259 (report_error, report_error_1, make_hdr, copy_sym)
4260 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4261 Make arguments const char *, not char *, to avoid violations of C
4262 standard and to fix some AIX warnings reported by Gilles Pion.
4263
e18afed7 42642012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4265
4266 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4267 already have overlays loaded.
4268 (handle_single_display_spec): Before returning without displaying
4269 fringe bitmap, synchronize the bidi iterator with the main display
4270 iterator, by calling iterate_out_of_display_property.
4271 (iterate_out_of_display_property): Detect buffer iteration by
4272 testing that it->string is a Lisp string.
4273 (get_next_display_element): When the current object is exhausted,
4274 and there's something on it->stack, call set_iterator_to_next to
4275 proceed with what's on the stack, instead of returning zero.
4276 (set_iterator_to_next): If called at the end of a Lisp string,
4277 proceed to consider_string_end without incrementing string
4278 position. Don't increment display vector index past the end of
4279 the display vector. (Bug#11417)
c8fb9dc6
EZ
4280 (pos_visible_p): Don't report a position visible when move_it_to
4281 stopped at the last line of window, which happens to be scanned
4282 backwards by the bidi iteration. (Bug#11464)
ac268e67 4283
e18afed7 42842012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4285
4286 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4287 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4288 are on a TTY, and thus unable to display on the fringes.
4289 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4290 so we need to signal to the caller that this is a "replacing"
4291 display spec. This fixes display when the spec is invalid or we
4292 are on a TTY.
4293
e18afed7 42942012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4295
4296 * unexaix.c (make_hdr): Fix typo in prototype.
4297 This bug broke the build on AIX. Problem reported by Gilles Pion.
4298
9d0a235a
MA
42992012-05-14 Michael Albinus <michael.albinus@gmx.de>
4300
4301 * keyboard.c (kbd_buffer_get_event): Read special events also in
4302 batch mode. (Bug#11415)
4303
9e6b06ed
GM
43042012-05-12 Glenn Morris <rgm@gnu.org>
4305
4306 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4307
c1a1d7a3
EZ
43082012-05-12 Eli Zaretskii <eliz@gnu.org>
4309
4310 * lisp.mk (lisp): Add newcomment.elc.
4311
3fe7cdc8
GM
43122012-05-12 Glenn Morris <rgm@gnu.org>
4313
4314 * Makefile.in (MKDIR_P): New, set by configure.
4315 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4316
53f7d2c0
PE
43172012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4318
4319 Remove unused function hourglass_started.
4320 * dispextern.h (hourglass_started):
4321 * w32fns.c (hourglass_started):
4322 * xdisp.c (hourglass_started): Remove.
4323
75aafb17
JB
43242012-05-10 Juanma Barranquero <lekktu@gmail.com>
4325
4326 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4327 Update dependencies.
4328
12959e8e
PE
43292012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4330
97107e2e
PE
4331 * xgselect.c (xg_select): Put maxfds+1 into a var.
4332 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4333
12959e8e
PE
4334 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4335
836d29b3
DA
43362012-05-10 Dave Abrahams <dave@boostpro.com>
4337
4338 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4339 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4340
5cb67954
MA
43412012-05-09 Michael Albinus <michael.albinus@gmx.de>
4342
4343 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4344 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4345 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4346 Initialize xd_registered_buses.
4347
3478ec45
PE
43482012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4349
b263a6b0
PE
4350 Untag more efficiently if USE_LSB_TAG.
4351 This is based on a proposal by YAMAMOTO Mitsuharu in
4352 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4353 For an admittedly artificial (nth 8000 longlist) benchmark on
4354 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4355 Emacs's overall text size by 1%.
4356 * lisp.h (XUNTAG): New macro.
4357 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4358 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4359 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4360 * eval.c (Fautoload):
4361 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4362 * frame.h (XFRAME): Use XUNTAG.
4363
3478ec45
PE
4364 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4365 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4366 Remove unportable assumptions about print widths of types like
4367 dbus_uint32_t.
4368 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4369 intptr_t when converting between pointer and integer, to avoid GCC
4370 warnings about wrong width.
4371
666b903b 43722012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4373
4374 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4375 stack for each reader_thread, instead of defaulting to 8MB
4376 determined by the linker. This avoids failures in creating
4377 subprocesses on Windows 7, see the discussion in this thread:
4378 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4379
b120cc17
JC
43802012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4381
4382 Fix up display of the *Minibuf-0* buffer in the mini window.
4383 * keyboard.c (read_char): Don't clear the echo area if there's no
4384 message to clear.
4385 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4386 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4387
9a4b36f8
MA
43882012-05-07 Michael Albinus <michael.albinus@gmx.de>
4389
4390 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4391 batch mode.
4392
e5f9458f
CY
43932012-05-06 Chong Yidong <cyd@gnu.org>
4394
4395 * lisp.mk (lisp): Update.
4396
eceeb5fc 43972012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4398
4399 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4400
71873e2b
SM
44012012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4402
4403 * data.c (PUT_ERROR): New macro.
4404 (syms_of_data): Use it. Add new error type `user-error'.
4405 * undo.c (user_error): New function.
4406 (Fprimitive_undo): Use it.
4407 * print.c (print_error_message): Adjust print style for `user-error'.
4408 * keyboard.c (user_error): New function.
4409 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4410
ab0fa4e4
PE
44112012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 Do not limit current-time-string to years 1000..9999.
4414 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4415 (Fcurrent_time_string): Support any year that is supported by the
4416 underlying localtime representation. Don't use asctime, as it
4417 has undefined behavior for years outside the range -999..9999.
4418
7ed806a7
PE
44192012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4420
4421 Fix race conditions involving setenv, gmtime, localtime, asctime.
4422 Without this fix, interrupts could mess up code that uses these
4423 nonreentrant functions, since setting TZ invalidates existing
4424 tm_zone or tzname values, and since most of these functions return
4425 pointers to static storage.
4426 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4427 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4428 Grow the critical sections to include not just invoking
4429 localtime/gmtime, but also accessing these functions' results
4430 including their tm_zone values if any, and any related TZ setting.
4431 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4432 so that the struct tm is saved in the critical section.
4433 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4434 motivated by the fact that memory allocation needs to be outside
4435 the critical section.
4436
0c16dfed
DA
44372012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4438
4439 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4440 with RESET_INTERVAL.
4441
4442 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4443 Remove duplicated buffer name initialization.
4444
3f83ace8
JM
44452012-05-02 Jim Meyering <jim@meyering.net>
4446
4447 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4448
c7b8541e
JM
4449 * xfns.c (x_window): Use xstrdup (Bug#11375).
4450
90207a15 44512012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4452
4453 * xdisp.c (pos_visible_p): If already at a newline from the
4454 display string before the 'while' loop, don't walk back the glyphs
4455 from it3.glyph_row. Solves assertion violation when the display
4456 string begins with a newline (egg.el). (Bug#11367)
4457
b593d6a9
AH
44582012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4459
4460 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4461 Move to simple.el.
4462
4737362e
GM
44632012-05-01 Glenn Morris <rgm@gnu.org>
4464
99cf43f9
GM
4465 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4466 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4467 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4468 All were removed before 23.1.
4469
9311dcff
GM
4470 * dispnew.c: Remove HAVE_LIBNCURSES test;
4471 it is always true on relevant platforms.
4472
4d5c6349
GM
4473 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4474 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4475
4737362e
GM
4476 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4477
74dd3a6b
AS
44782012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4479
4480 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4481 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4482 Remove.
4483
13c379ee
PE
44842012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4485
4486 Do not avoid creating empty evaporating overlays (Bug#9642).
4487 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4488 That is, do not delete an evaporating overlay if it becomes
4489 empty after its bounds are adjusted to fit within its buffer.
4490 This fix caused other problems, and I'm reverting it until we get
4491 to the bottom of them.
4492
a8e7d6d7 44932012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4494
4495 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4496
a8e7d6d7 44972012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4498
4499 * xdisp.c (pos_visible_p): If the window start position is beyond
4500 ZV, start the display from buffer beginning. Prevents assertion
4501 violation in init_iterator when the minibuffer window is scrolled
4502 via the scroll bar.
4503
4504 * window.c (window_scroll_pixel_based): Likewise.
4505
a8e7d6d7 45062012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4507
4508 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4509
a8e7d6d7 45102012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4511
4512 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4513 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4514
a8e7d6d7 45152012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4516
b593d6a9
AH
4517 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4518 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4519
1c6900d9
EZ
45202012-04-26 Eli Zaretskii <eliz@gnu.org>
4521
4c3fa1d9
EZ
4522 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4523 display element, check also the underlying string or buffer
4524 character. (Bug#11341)
4525
1c6900d9
EZ
4526 * w32menu.c: Include w32heap.h.
4527 (add_menu_item): If the call to AppendMenuW (via
4528 unicode_append_menu) fails, disable Unicode menus only if we are
4529 running on Windows 9X/Me.
4530
42bf8205
AS
45312012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4532
4533 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4534 (xgetint): Add missing shift for LSB tags.
4535
b1bac16e
MR
45362012-04-24 Martin Rudalics <rudalics@gmx.at>
4537
4538 * keyboard.c (read_char): Don't wipe echo area for select window
4539 events: These might get delayed via `mouse-autoselect-window'
4540 (Bug#11304).
4541
d69621cc
JB
45422012-04-24 Juanma Barranquero <lekktu@gmail.com>
4543
4544 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4545 manipulation of :loaded-from data.
4546
02fd101b
JB
45472012-04-23 Juanma Barranquero <lekktu@gmail.com>
4548
4549 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4550 now a cons (bug#11311).
4551
888bec30
PE
45522012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4553
89a438bd
PE
4554 Do not create empty overlays with the evaporate property (Bug#9642).
4555 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4556 if it becomes empty after its bounds are adjusted to fit within
4557 its buffer. Without this fix, in a nonempty buffer (let ((o
4558 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4559 yields an empty overlay that has the evaporate property, which is
4560 not supposed to happen.
4561
1068fe4d
PE
4562 Fix minor GTK3 problems found by static checking.
4563 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4564 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4565 (struct _EmacsFixedClass, emacs_fixed_get_type):
4566 Move decls here from emacsgtkfixed.h, since they needn't be public.
4567 (emacs_fixed_get_type): Now static.
4568 (emacs_fixed_class_init): Omit unused local.
4569 (emacs_fixed_child_type): Remove; unused.
4570 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4571 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4572 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4573 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4574 (EMACS_FIXED_GET_CLASS): Remove; unused.
4575 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4576
888bec30
PE
4577 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4578 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4579
de85e130
PE
45802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4581
d0baac98 4582 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4583 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4584 (__malloc_size_t, __malloc_ptrdiff_t):
4585 Remove. All uses removed, replaced by the definiens if needed,
4586 since we can assume C89 or better now.
4587 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4588 (protect_malloc_state, align, get_contiguous_space)
4589 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4590 (malloc_atfork_handler_child, malloc_enable_thread)
4591 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4592 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4593 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4594 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4595 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4596 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4597 Define using prototypes, not old style.
4598 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4599 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4600 (align): Don't assume that signed integer overflow wraps around.
4601 Omit unused local var.
4602 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4603 (_free_internal_nolock, memalign, mallochook, reallochook):
4604 Omit no-longer-needed casts.
4605 (valloc): Use getpagesize, not __getpagesize.
4606 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4607 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4608
de85e130
PE
4609 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4610
dcbf5805
MA
46112012-04-22 Michael Albinus <michael.albinus@gmx.de>
4612
4613 Move functions from C to Lisp. Make non-blocking method calls
4614 the default. Implement further D-Bus standard interfaces.
4615
4616 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4617 (QCdbus_request_name_allow_replacement)
4618 (QCdbus_request_name_replace_existing)
4619 (QCdbus_request_name_do_not_queue)
4620 (QCdbus_request_name_reply_primary_owner)
4621 (QCdbus_request_name_reply_in_queue)
4622 (QCdbus_request_name_reply_exists)
4623 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4624 (QCdbus_registered_serial, QCdbus_registered_method)
4625 (QCdbus_registered_signal): New Lisp objects.
4626 (XD_DEBUG_MESSAGE): Use sizeof.
4627 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4628 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4629 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4630 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4631 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4632 (xd_signature, xd_append_arg): Allow float for integer types.
4633 (xd_get_connection_references): New function.
b593d6a9
AH
4634 (xd_get_connection_address): Rename from xd_initialize.
4635 Return cached address.
dcbf5805
MA
4636 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4637 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4638 level.
4639 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4640 Return number of refcounts.
dcbf5805
MA
4641 (Fdbus_get_unique_name): Make stronger parameter check.
4642 (Fdbus_message_internal): New defun.
4643 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4644 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4645 (Fdbus_send_signal, Fdbus_register_service)
4646 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4647 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4648 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4649 (Vdbus_compiled_version, Vdbus_runtime_version)
4650 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4651 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4652 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4653 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4654 Adapt docstring.
dcbf5805 4655
52828e02
PE
46562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4657
da05bc4c
PE
4658 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4659 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4660 Do not assume ptrdiff_t is the same width as 'int'.
4661
52828e02
PE
4662 * alloc.c: Handle unusual debugging option combinations.
4663 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4664 since the two debugging options are incompatible.
4665 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4666 is defined.
4667 (mem_init, mem_insert, mem_insert_fixup):
4668 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4669 (NEED_MEM_INSERT): Remove; no longer needed.
4670
f01769f9
LL
46712012-04-22 Leo Liu <sdl.web@gmail.com>
4672
4673 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4674
5790543d
PE
46752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4676
4677 * sysdep.c [__FreeBSD__]: Minor cleanups.
4678 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4679 Use Emacs indenting style more consistently. Avoid some casts.
4680 Use 'double' consistently rather than mixing 'float' and 'double'.
4681
b91b7e4d
EW
46822012-04-21 Eduard Wiebe <usenet@pusto.de>
4683
b593d6a9
AH
4684 * sysdep.c (list_system_processes, system_process_attributes):
4685 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4686
6114eb15
AS
46872012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4688
4689 * lisp.mk (lisp): Update.
4690
2f38dff7
PE
46912012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4692
4693 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4694 It is never used otherwise.
4695
4ae29f89
SM
46962012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4697
4698 * print.c (print_preprocess): Only check print_depth if print-circle
4699 is nil.
4700 (print_object): Check for cycles even when print-circle is nil and
4701 print-gensym is t, but only check print_depth if print-circle is nil.
4702
f30d612a
CY
47032012-04-20 Chong Yidong <cyd@gnu.org>
4704
4705 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4706 set the status to "failed" and ensure that sentinel is run.
4707
c07a4c0b 47082012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4709
4710 * process.c (Fset_process_inherit_coding_system_flag)
4711 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4712 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4713
c07a4c0b 47142012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4715
4716 * xdisp.c (string_buffer_position_lim): Limit starting position to
4717 BEGV.
4718 (set_cursor_from_row): If called for a mode-line or header-line
4719 row, return zero immediately.
4720 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4721 farther than the first row after the header line, if any.
4722 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4723 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4724
c07a4c0b 47252012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4726
4ae29f89
SM
4727 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4728 (bug#11238).
ad3a2b41 4729
c07a4c0b 47302012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47312012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4732
4733 configure: new option --enable-gcc-warnings (Bug#11207)
4734 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4735 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4736 (ALL_CFLAGS): Use new macros rather than old.
4737 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4738 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4739 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4740 -Wunused-result, -Wunused-variable. This should go away once
4741 the Emacs and Gnulib regex code is merged.
4742 (xmalloc, xrealloc): Now static.
4743
aba027e8
PE
47442012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4745
4746 * dired.c (Fsystem_groups): Remove unused local.
4747
e5a36063
GM
47482012-04-17 Glenn Morris <rgm@gnu.org>
4749
4750 * dired.c (Fsystem_users): Doc fix.
4751
316411f0
DA
47522012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4753
4754 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4755 (syms_of_dired): Add them.
4756
9426aba4
PE
47572012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4758
b62a57be
PE
4759 Fix minor alloc.c problems found by static checking.
4760 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4761 New extern decls, to avoid calling undeclared functions.
4762 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4763 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4764 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4765 (NEED_MEM_INSERT): New macro.
4766 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4767 Remove one incorrect comment and fix another.
b62a57be 4768
3539f31f
PE
4769 Fix minor ralloc.c problems found by static checking.
4770 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4771 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4772 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4773 (r_alloc_sbrk): Now static.
4774
a041960a
PE
4775 Improve ralloc.c interface checking.
4776 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4777 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4778 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4779 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4780 [REL_ALLOC]: ... to here, to check interface.
4781 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4782 Remove decls. This fixes an "It stinks!".
4783
9426aba4
PE
4784 * alloc.c (which_symbols): Fix alignment issue / type clash.
4785
d55c12ed
AS
47862012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4787
4788 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4789 (struct Lisp_Misc_Any): Likewise.
4790 (struct Lisp_Free): Likewise.
4791 * alloc.c (union aligned_Lisp_Symbol): Define.
4792 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4793 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4794 (union aligned_Lisp_Misc): Define.
4795 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4796 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4797 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4798
b948ce8b
PE
47992012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4800
4801 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4802 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4803 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4804 * s/netbsd.h, s/sol2-6.h:
4805 Remove definition of GC_MARK_STACK, since the default now works.
4806 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4807 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4808 no longer the default.
4809 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4810
35dc09a1 48112012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4812
35dc09a1
GM
4813 * lread.c (lisp_file_lexically_bound_p):
4814 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4815
35dc09a1
GM
48162012-04-14 Eli Zaretskii <eliz@gnu.org>
4817
4818 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4819 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4820
48212012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4822
4823 * nsterm.m (constrainFrameRect): Always constrain when there is only
4824 one screen (Bug#10962).
4825
bcd86815
KB
48262012-04-13 Ken Brown <kbrown@cornell.edu>
4827
4828 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4829
c25df26e
RT
48302012-04-13 Reuben Thomas <rrt@sc3d.org>
4831
4832 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4833
0fc59f1e
DC
48342012-04-11 Daniel Colascione <dancol@dancol.org>
4835
4836 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4837 against is gone. It's better to use vfork now so that when Cygwin
4838 gains a new, working vfork, we use it automatically (bug#10398).
4839
de8c03dc
SM
48402012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4841
4842 * window.c (save_window_save): Obey window-point-insertion-type.
4843
2f097256
GM
48442012-04-11 Glenn Morris <rgm@gnu.org>
4845
4846 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4847
453b951e
SM
48482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4849
4850 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4851
75f1671a 48522012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4853
4854 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4855 (force_quit_count): New var.
4856 (handle_interrupt): Use it.
4857
2a8ce227
JB
48582012-04-10 Juanma Barranquero <lekktu@gmail.com>
4859
4860 * w32.c (w32_delayed_load): Record the full path of the library
4861 being loaded (bug#10424).
4862
935396c0
GM
48632012-04-09 Glenn Morris <rgm@gnu.org>
4864
05920a43
GM
4865 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4866 not just in the obarray, before snarfing them. (Bug#11036)
4867
935396c0
GM
4868 * Makefile.in ($(leimdir)/leim-list.el):
4869 Pass EMACS rather than BUILT_EMACS.
4870
a18ecafa
TZ
48712012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4872
4873 * process.c (make_process):
4874 * process.h: Add integer `gnutls_handshakes_tried' member to
4875 process struct.
4876
6bbef4e5
JC
4877 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4878 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4879
4880 * gnutls.c (gnutls_log_function2i): Convenience log function.
4881 (emacs_gnutls_read): Use new log functions,
4882 `gnutls_handshakes_tried' process member, and
4883 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4884 attempts per process (connection).
4885
b4d3bc10
CY
48862012-04-09 Chong Yidong <cyd@gnu.org>
4887
4888 * eval.c (Fuser_variable_p, user_variable_p_eh)
4889 (lisp_indirect_variable): Functions deleted.
4890 (Fdefvar): Caller changed.
4891
4892 * callint.c (Finteractive, Fcall_interactively):
4893 * minibuf.c (Fread_variable): Callers changed.
4894
70f4d973
EZ
48952012-04-09 Eli Zaretskii <eliz@gnu.org>
4896
4897 * xdisp.c (set_cursor_from_row): If the display string appears in
4898 the buffer at position that is closer to point than the position
4899 after the display string, display the cursor on the first glyph of
4900 the display string. Fixes cursor display when a 'display' text
4901 property immediately follows invisible text. (Bug#11094)
4902
cb3c2e3e
PE
49032012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 composite.c: use 'double' consistently
4906 * composite.c (get_composition_id): Use 'double' consistently
4907 instead of converting 'float' to 'double' and vice versa; this is
4908 easier to understand and avoids a GCC warning.
4909
fd06db5d
GM
49102012-04-09 Glenn Morris <rgm@gnu.org>
4911
50fe702a
GM
4912 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4913 preparation for dumping it with emacs. (Bug#4789)
4914 (leimdir): New variable.
4915 ($(leimdir)/leim-list.el): New rule.
4916 (emacs$(EXEEXT)): Depend on leim-list.el.
4917
fd06db5d
GM
4918 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4919 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4920 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4921
55c131ee
AS
49222012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4923
4924 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4925 proper alignment.
4926
9209588f
JB
49272012-04-07 Juanma Barranquero <lekktu@gmail.com>
4928
4929 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4930 Remove unused local variable.
4931
e3fb2efb
PE
49322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4933
4934 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4935 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4936 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4937 objects, as mark_maybe_pointer will catch them otherwise.
4938 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4939 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4940
b5385551
PE
49412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4942
4943 Fix typo that broke non-Windows builds.
4944 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4945
9078ead6
EZ
49462012-04-07 Eli Zaretskii <eliz@gnu.org>
4947
4948 Support building on MS-Windows with libxml2.
4949
4950 * makefile.w32-in (OBJ2): Add xml.$(O).
4951 (GLOBAL_SOURCES): Add xml.c.
4952 ($(BLD)/xml.$(O)): New dependency list.
4953
4954 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4955 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4956 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4957 [!WINDOWSNT]: New macros.
4958 (init_libxml2_functions, libxml2_loaded_p): New functions.
4959 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4960 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4961 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4962 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4963 linked in).
6bbef4e5
JC
4964 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4965 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4966 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4967
4968 * emacs.c: Don't include libxml/parser.h.
4969 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4970 xmlCleanupParser directly.
4971
4972 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4973
3811fdf3
EZ
49742012-04-07 Eli Zaretskii <eliz@gnu.org>
4975
4976 * indent.c (Fvertical_motion): If there is a display string at
4977 point, use it.vpos to compute how many lines to backtrack after
4978 move_it_to point. (Bug#11133)
4979
2f8e16b2
EZ
49802012-04-06 Eli Zaretskii <eliz@gnu.org>
4981
4982 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4983 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4984 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4985 macros related to unification of CJK characters. For the details,
4986 see the discussion following the message here:
4987 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4988
3d439cd1
CY
49892012-04-04 Chong Yidong <cyd@gnu.org>
4990
4991 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4992
8bc53d00
EZ
49932012-04-01 Eli Zaretskii <eliz@gnu.org>
4994
4995 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4996 instead of alloca. (Bug#11138)
4997
3b0512a3
AS
49982012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4999
5000 * w32menu.c (is_simple_dialog): Properly check lisp types.
5001 (Bug#11141)
5002
8427ddd2
EZ
50032012-03-31 Eli Zaretskii <eliz@gnu.org>
5004
979022ef
EZ
5005 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5006 position we get to after a call to move_it_to fails the
5007 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5008 only if we wind up in a string from display property. (Bug#11063)
5009
a6b1c7cc
EZ
5010 * window.c (Fdelete_other_windows_internal): Invalidate the row
5011 and column information about mouse highlight, so that redisplay
5012 restores it after reallocating the glyph matrices. (Bug#7464)
5013
8427ddd2
EZ
5014 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5015 string comes from a `display' text property, use the buffer
5016 position of that property as if we actually saw that position in
5017 the row's glyphs.
697ba24b
EZ
5018 (move_it_by_lines): Remove the assertion that
5019 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5020 violated when there's a before-string at the beginning of a line.
5021 (Bug#11063)
8427ddd2 5022
65a0a738
EZ
50232012-03-30 Eli Zaretskii <eliz@gnu.org>
5024
5025 * xdisp.c (append_space_for_newline): If the default face was
5026 remapped, use the remapped face for the appended newline.
5027 (extend_face_to_end_of_line): Use the remapped default face for
5028 extending the face to the end of the line.
5029 (display_line): Call extend_face_to_end_of_line when the default
5030 face was remapped. (Bug#11068)
5031
581355cc
EZ
50322012-03-29 Eli Zaretskii <eliz@gnu.org>
5033
5034 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5035
e8fc049f
SM
50362012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5037
5038 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5039
4fb9a543
GM
50402012-03-27 Glenn Morris <rgm@gnu.org>
5041
5042 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5043 Doc fixes.
5044
679910f1
KH
50452012-03-26 Kenichi Handa <handa@m17n.org>
5046
5047 * dispextern.h (struct glyph): Fix previous change. Change the
5048 bit length of glyphless.ch to 25 (Bug#11082).
5049
90d49b7f
CY
50502012-03-26 Chong Yidong <cyd@gnu.org>
5051
5052 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5053 (command_loop_1): Use it; inhibit selection update for
5054 handle-select-window too (Bug#8996).
5055
f514f6f0
FP
50562012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5057
e8fc049f 5058 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5059
bf43fa51
KH
50602012-03-25 Kenichi Handa <handa@m17n.org>
5061
5062 * dispextern.h (struct glyph): Change the bit length of
5063 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5064
8a0c01dd
EZ
50652012-03-24 Eli Zaretskii <eliz@gnu.org>
5066
5067 * s/ms-w32.h (tzname): Include time.h before redirecting to
5068 _tzname. Fixes the MSVC build. (Bug#9960)
5069
7d1c3a76
AS
50702012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5071
8ed79523
AS
5072 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5073 characters.
5074
7d1c3a76
AS
5075 * xterm.c (XTread_socket): Only modify handling_signal if
5076 !SYNC_INPUT. (Bug#11080)
5077
e99a9b8b
EZ
50782012-03-23 Eli Zaretskii <eliz@gnu.org>
5079
5080 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5081 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5082 when fetching a multibyte character consumes more bytes than
5083 CHAR_BYTES returns, due to unification of CJK characters in
5084 string_char. (Bug#11073)
5085
5063c0e1
TN
50862012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5087
5088 * process.c (wait_reading_process_output): Handle pty disconnect
5089 by refraining from sending oneself a SIGCHLD (bug#10933).
5090
9f851fbd
CY
50912012-03-22 Chong Yidong <cyd@gnu.org>
5092
5093 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5094
5063c0e1 5095 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5096 Mark string as coming from a prefix property.
5097 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5098 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5099
fb5b8aca
CY
51002012-03-21 Chong Yidong <cyd@gnu.org>
5101
5102 * xfaces.c (Vface_remapping_alist): Doc fix.
5103
62356a1b
EZ
51042012-03-20 Eli Zaretskii <eliz@gnu.org>
5105
5106 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5107 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5108 Doc fixes.
62356a1b 5109
025de85b
CY
51102012-03-20 Chong Yidong <cyd@gnu.org>
5111
5112 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5113 to reflect default non-nil value of redisplay-dont-pause.
5114
4827f94e
KH
51152012-03-19 Kenichi Handa <handa@m17n.org>
5116
5117 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5118 it fit in a valid range (Bug#11003).
5119
e50a24a2
EZ
51202012-03-18 Eli Zaretskii <eliz@gnu.org>
5121
5122 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5123 that is not from display property, accept the row as a "cursor
5124 row" if one of the string's character has a non-nil `cursor'
5125 property. Fixes cursor positioning when there are newlines in
5126 overlay strings, e.g. in icomplete.el. (Bug#11035)
5127
9af5ed87
PE
51282012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5129
5130 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5131
d1f55f16
CY
51322012-03-12 Chong Yidong <cyd@gnu.org>
5133
5134 * eval.c (inhibit_lisp_code): Rename from
5135 inhibit_window_configuration_change_hook; move from window.c.
5136
5137 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5138 * window.c (run_window_configuration_change_hook)
5139 (syms_of_window): Callers changed.
5140
66c5eebd
CY
51412012-03-11 Chong Yidong <cyd@gnu.org>
5142
413df973
CY
5143 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5144
66c5eebd
CY
5145 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5146
1de11f56
CY
51472012-03-10 Chong Yidong <cyd@gnu.org>
5148
5149 * frame.c (other_visible_frames): Don't assume the selected frame
5150 is visible (Bug#10955).
5151
cae07000
SM
51522012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5153
5154 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5155
89c94350
JD
51562012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5157
5158 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5159 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5160 zero (Bug#10954).
5161
999dd333
GM
51622012-03-03 Glenn Morris <rgm@gnu.org>
5163
01a6dcc8 5164 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5165
de0100f2
EZ
51662012-03-02 Eli Zaretskii <eliz@gnu.org>
5167
5168 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5169 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5170 (redisplay_window, next_element_from_string): Fix typos in
5171 comments.
3e441275
EZ
5172 (redisplay_window): Pass to move_it_vertically the margin in
5173 pixels, not in screen lines.
de0100f2 5174
96a72ee9
GM
51752012-03-02 Glenn Morris <rgm@gnu.org>
5176
5177 * buffer.c (buffer-list-update-hook): Doc fix.
5178
312508d7
EZ
51792012-02-29 Eli Zaretskii <eliz@gnu.org>
5180
5181 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5182 push_it before setting up the iterator for the first overlay
5183 string, even if we have an empty string loaded.
5184 (next_overlay_string): If there's an empty string on the iterator
5185 stack, pop the stack. (Bug#10903)
5186
27f3c637
PE
51872012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5188
5189 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5190 Suggested by Stefan Monnier in
5191 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5192 * alloc.c (widen_to_Lisp_Object): New static function.
5193 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5194 and widening them to Lisp_Objects. This would work even if
5195 USE_LSB_TAG is defined and wide integers are used, which might
5196 happen in a future version of Emacs.
5197
3c9dfce6
CY
51982012-02-25 Chong Yidong <cyd@gnu.org>
5199
fa74b241
CY
5200 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5201 Doc fix.
5202
3c9dfce6
CY
5203 * xselect.c (Fx_selection_exists_p): Doc fix.
5204 (x_clipboard_manager_save_all): Print an informative message
5205 before saving to clipboard manager.
5206
9486df08
CY
52072012-02-24 Chong Yidong <cyd@gnu.org>
5208
5209 * keyboard.c (process_special_events): Handle all X selection
5210 requests in kbd_buffer, not just the next one (Bug#8869).
5211
f01d3321
CY
52122012-02-23 Chong Yidong <cyd@gnu.org>
5213
5214 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5215 call when setting menu-bar-lines and tool-bar-lines parameters.
5216 (unwind_create_frame_1): New helper function.
5217
5218 * window.c (inhibit_window_configuration_change_hook): New var.
5219 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5220 (syms_of_window): Initialize it.
f01d3321 5221
86b847b6
CY
52222012-02-22 Chong Yidong <cyd@gnu.org>
5223
5224 * xterm.c (x_draw_image_relief): Add missing type check for
5225 Vtool_bar_button_margin (Bug#10743).
5226
a59225b1
CY
52272012-02-21 Chong Yidong <cyd@gnu.org>
5228
5229 * fileio.c (Vfile_name_handler_alist): Doc fix.
5230
5231 * buffer.c (Fget_file_buffer): Protect against invalid file
5232 handler return value.
5233
310f5bd4
PE
52342012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5235
cb3a28cc
PE
5236 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5237 when computing $valmask.
5238
310f5bd4
PE
5239 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5240 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5241 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5242 It's useless in that case, and it can cause problems on hosts
5243 that allocate halves of EMACS_INT values separately.
5244 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5245 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5246 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5247 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5248 it avoids undefined behavior on hosts where shifting right by more
5249 than the word width has undefined behavior.
5250
2375c96a
CY
52512012-02-19 Chong Yidong <cyd@gnu.org>
5252
5253 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5254 (Funhandled_file_name_directory, Ffile_name_as_directory)
5255 (Fdirectory_file_name, Fexpand_file_name)
5256 (Fsubstitute_in_file_name): Protect against invalid file handler
5257 return values (Bug#10845).
5258
3eb49e71
EZ
52592012-02-18 Eli Zaretskii <eliz@gnu.org>
5260
5261 * .gdbinit (pitx): Fix incorrect references to fields of the
5262 iterator stack.
5263
7b926f3f
CY
52642012-02-17 Chong Yidong <cyd@gnu.org>
5265
5266 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5267
11273115
PE
52682012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5269
5270 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5271 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5272
c3a70e2b
CY
52732012-02-15 Chong Yidong <cyd@gnu.org>
5274
5275 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5276 marked as special. Also, starting docstrings with * is obsolete.
5277
0ca43699
AS
52782012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5279
5280 * gnutls.c (emacs_gnutls_write): Fix last change.
5281
2e8f3c56
LI
52822012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5283
5284 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5285 send_process.
5286
af70074f
SM
52872012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5288
5289 * keymap.c (Fsingle_key_description): Handle char ranges.
5290
95986d52
CY
52912012-02-12 Chong Yidong <cyd@gnu.org>
5292
afd83bd1
CY
5293 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5294 as that creates a dangerous corner case.
5295
95986d52
CY
5296 * window.c (Fdelete_window_internal): Invalidate the mouse
5297 highlight (Bug#9904).
5298
bd7da63e
GM
52992012-02-12 Glenn Morris <rgm@gnu.org>
5300
5301 * xselect.c (Fx_own_selection_internal)
5302 (Fx_get_selection_internal, Fx_disown_selection_internal)
5303 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5304 * nsselect.m (Fx_own_selection_internal)
5305 (Fx_disown_selection_internal, Fx_selection_exists_p)
5306 (Fx_selection_owner_p, Fx_get_selection_internal):
5307 Sync docs and argument specs with the xselect.c versions.
5308
77abcbc2
LI
53092012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5310
5311 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5312
90b671e2
EZ
53132012-02-11 Eli Zaretskii <eliz@gnu.org>
5314
1c0ca0b7
EZ
5315 * w32select.c (Fx_selection_exists_p): Sync doc string and
5316 argument list with xselect.c. (Bug#10783)
5317
5318 * w16select.c (Fx_selection_exists_p): Sync doc string and
5319 argument list with xselect.c. (Bug#10783)
90b671e2 5320
49241268
GM
53212012-02-10 Glenn Morris <rgm@gnu.org>
5322
5323 * fns.c (Fsecure_hash): Doc fix.
5324
f998bbe7 53252012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5326
5327 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5328
0992bd9c
CY
53292012-02-07 Chong Yidong <cyd@gnu.org>
5330
5331 * buffer.c (Fbuffer_local_variables)
5332 (buffer_lisp_local_variables): Handle unbound vars correctly;
5333 don't let Qunbound leak into Lisp.
5334
af008560
GM
53352012-02-07 Glenn Morris <rgm@gnu.org>
5336
dd605cc4
GM
5337 * image.c (Fimagemagick_types): Doc fix.
5338
af008560
GM
5339 * image.c (imagemagick-render-type): Change it from a lisp object
5340 to an integer. Move the doc here from the lisp manual.
5341 Treat all values not equal to 0 the same.
5342
1449fa1d
CY
53432012-02-06 Chong Yidong <cyd@gnu.org>
5344
5345 * doc.c (store_function_docstring): Avoid applying docstring of
5346 alias to base function (Bug#2603).
5347
3723ec07
AS
53482012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5349
5350 * .gdbinit (pp1, pv1): Remove redundant defines.
5351 (pr): Use pp.
5352
79c1cc1e
CY
53532012-02-04 Chong Yidong <cyd@gnu.org>
5354
5355 * nsterm.m: Declare a global (Bug#10694).
5356
d7f29f8e
EZ
53572012-02-04 Eli Zaretskii <eliz@gnu.org>
5358
cae07000
SM
5359 * w32.c (get_emacs_configuration_options):
5360 Include --enable-checking, if specified, in the return value.
d7f29f8e 5361
3b95a6f9
MR
53622012-02-04 Martin Rudalics <rudalics@gmx.at>
5363
5364 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5365 after rounding frame sizes. (Bug#9723)
5366
d6fa96a6
EZ
53672012-02-04 Eli Zaretskii <eliz@gnu.org>
5368
5369 * keyboard.c (adjust_point_for_property): Don't position point
5370 before BEGV. (Bug#10696)
5371
df0b2940
PE
53722012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 Handle overflow when computing char display width (Bug#9496).
5375 * character.c (char_width): Return EMACS_INT, not int.
5376 (char_width, c_string_width): Check for overflow when
5377 computing the width; this is possible now that individual
5378 characters can have unbounded width. Problem introduced
5379 by merge from Emacs 23 on 2012-01-19.
5380
6bee44d6
MA
53812012-02-02 Michael Albinus <michael.albinus@gmx.de>
5382
5383 * dbusbind.c (Fdbus_register_method): Mention the return value
5384 :ignore in the docstring.
5385
44f92739
GM
53862012-02-02 Glenn Morris <rgm@gnu.org>
5387
1b9f60cc
GM
5388 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5389
44f92739
GM
5390 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5391 Unconditionally set to t. (Bug#10673)
5392 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5393 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5394 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5395
c5d3843c
KH
53962012-02-02 Kenichi Handa <handa@m17n.org>
5397
5398 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5399 0, do not call append_composite_glyph.
5400
159462d4 54012012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5402
5403 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5404 NULL (Bug#6988).
5405 (x_produce_glyphs): If the component of a composition is a null
5406 string, set it->pixel_width to 1 to avoid zero-width glyph.
5407
78cef877
EZ
54082012-02-01 Eli Zaretskii <eliz@gnu.org>
5409
5410 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5411 first 2 arguments are identical. This makes inserting large
5412 output from a subprocess an order of magnitude faster on
5413 MS-Windows, where all sbrk'ed memory is always contiguous.
5414
97897668
GM
54152012-01-31 Glenn Morris <rgm@gnu.org>
5416
5417 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5418 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5419 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5420
31fd3586
GM
54212012-01-29 Glenn Morris <rgm@gnu.org>
5422
5423 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5424
0e24a8b2
CY
54252012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5426
5427 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5428
cc0adcb0
CY
54292012-01-28 Chong Yidong <cyd@gnu.org>
5430
5431 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5432
acc28cb9
CY
54332012-01-26 Chong Yidong <cyd@gnu.org>
5434
9c69cfb7
CY
5435 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5436
acc28cb9
CY
5437 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5438 repeat counts (Bug#10507).
5439
48da7392
GM
54402012-01-26 Glenn Morris <rgm@gnu.org>
5441
5442 * lread.c (syms_of_lread): Doc fix.
5443
14af5f7f
CY
54442012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5445
5446 * coding.c (encode_designation_at_bol): Change return value to
5447 EMACS_INT.
5448
0b21c100
CY
54492012-01-25 Chong Yidong <cyd@gnu.org>
5450
5451 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5452
3c2907f7
CY
54532012-01-21 Chong Yidong <cyd@gnu.org>
5454
5455 * floatfns.c (Fcopysign): Make the second argument non-optional,
5456 since nil is not allowed anyway.
5457
959ad23f
AS
54582012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5459
5460 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5461 (send_process): Likewise.
5462
34a02f46
MR
54632012-01-19 Martin Rudalics <rudalics@gmx.at>
5464
5465 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5466 (Vwindow_persistent_parameters): Do not use Qstate.
5467 Rewrite doc-strings.
34a02f46 5468
1259009a 54692012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5470
5471 * character.c (char_width): New function.
70d4fdf6
GM
5472 (Fchar_width, c_string_width, lisp_string_width):
5473 Use char_width (Bug#9496).
25ed9e61 5474
6a6ee00d
MR
54752012-01-16 Martin Rudalics <rudalics@gmx.at>
5476
5477 * window.c (Vwindow_persistent_parameters): New variable.
5478 (Fset_window_configuration, save_window_save): Handle persistent
5479 window parameters.
5480
c85efaf7
EZ
54812012-01-14 Eli Zaretskii <eliz@gnu.org>
5482
5483 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5484 thrashing the stack of the thread. (Bug#9087)
5485
5944709e
PE
54862012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5487
5488 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5489
e71f5d99
EZ
54902012-01-11 Eli Zaretskii <eliz@gnu.org>
5491
5492 * xdisp.c (rows_from_pos_range): Handle the case where the
5493 highlight ends on a newline. (Bug#10464)
5494 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5495 he end column for display of highlight that ends on a newline
5496 before a R2L line.
5497
ce316182
GM
54982012-01-11 Glenn Morris <rgm@gnu.org>
5499
5500 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5501 from load-path also when installation-directory is nil. (Bug#10208)
5502
5b43da69
GM
55032012-01-10 Glenn Morris <rgm@gnu.org>
5504
74cc8ff9
GM
5505 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5506
7d8d6e4e
GM
5507 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5508 Update template values to be closer to their typical values these days.
5b43da69 5509
a0db8d43
EZ
55102012-01-09 Eli Zaretskii <eliz@gnu.org>
5511
5512 * xdisp.c (rows_from_pos_range): Accept additional argument
5513 DISP_STRING, and accept any glyph in a row whose object is that
5514 string as eligible for mouse highlight. Fixes mouse highlight of
5515 display strings from overlays. (Bug#10464)
5516
9a0115ab 55172012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5518
b9110d6a 5519 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5520 * fileio.c (auto_saving_dir_umask): New static var.
5521 (Fmake_directory_internal): Use it.
5522 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5523 creating the directory. The old code temporarily assigns
5524 too-generous permissions to the directory.
5525 (do_auto_save_eh): Clear it.
b9110d6a 5526 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5527 that the var is always cleared.
5528
6c1bd3f3
EZ
55292012-01-07 Eli Zaretskii <eliz@gnu.org>
5530
5531 * search.c (scan_buffer): Pass character positions to
5532 know_region_cache, not byte positions. (Bug#6540)
5533
069d2b50
L
55342012-01-07 LynX <_LynX@bk.ru> (tiny change)
5535
5536 * w32.c (sys_rename): Report EXDEV when rename of a directory
5537 fails because the target is on another logical disk. (Bug#10284)
5538
75bf0d33
DB
55392012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5540
5541 * xterm.c (x_embed_request_focus): New function.
5542
5543 * xterm.h: Add prototype.
5544
5545 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5546
1c6e5a32
GM
55472012-01-05 Glenn Morris <rgm@gnu.org>
5548
5549 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5550
651e947e
EZ
55512012-01-01 Eli Zaretskii <eliz@gnu.org>
5552
5553 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5554 Load gnutls_transport_set_lowat only if GnuTLS version is below
5555 2.11.1.
5556 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5557 GnuTLS versions below 2.11.1.
5558
3778cdd8
AL
55592011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5560
5561 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5562 to the doc string advising against its use for altering the way
5563 windows are scrolled.
5564
0e5317f7
KH
55652011-12-28 Kenichi Handa <handa@m17n.org>
5566
5567 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5568 coding-system ASCII compatible only when it does not produce BOM
5569 on encoding (Bug#10383).
5570
93d5ca1f
JD
55712011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5572
5573 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5574 can scroll.
5575 (create_and_show_popup_menu): Always use menu_position_func for
5576 Gtk3 (Bug#10361).
5577
ca22b785
AS
55782011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5579
5580 * callint.c (Fcall_interactively): Don't truncate prompt string.
5581
d048e1e6
EZ
55822011-12-23 Eli Zaretskii <eliz@gnu.org>
5583
5584 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5585 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5586 resumed from there (after widening). (Bug#10360)
d048e1e6 5587
5ccaba1f
JD
55882011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5589
5590 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5591
204ee57f
JD
55922011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5593
b81d40f0
JB
5594 * nsterm.m (x_free_frame_resources):
5595 Release f->output_data.ns->miniimage.
204ee57f
JD
5596 (ns_index_color): Fix indentation. Do not retain
5597 color_table->colors[i].
5598
5599 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5600 before returning.
5601
5602 * nsfns.m (x_set_background_color): Assign return value from
5603 ns_index_color to face-background instead of NSColor*.
5604 (ns_implicitly_set_icon_type): Fix indentation.
5605 Change assignment in for loop to comparison.
5606
5607 * emacs.c (ns_pool): New variable.
5608 (main): Assign ns_pool.
5609 (Fkill_emacs): Call ns_release_autorelease_pool.
5610
5611 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5612 autorelease fdesc, release fdAttrs and tdict.
5613 (ns_get_covering_families): Release charset.
5614 (ns_findfonts): Release NSFontDescriptor created with new.
5615 (ns_uni_to_glyphs): Fix indentation.
5616 (setString): Release attrStr before assigning new value.
5617
c803b2b7
JD
56182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5619
678f4426
JD
5620 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5621 and NS_IMPL_COCOA.
5622 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5623 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5624
cd394be1 56252011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5626
5fecd5fc
JD
5627 * nsterm.m (ns_term_init): Subscribe for notifications
5628 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5629 to method trackingNotification in EmacsMenu.
5630
5631 * nsmenu.m (trackingMenu): New variable.
3771cb17 5632 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5633 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5634 from Aquamacs (Bug#7030).
678f4426
JD
5635
56362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5637
c803b2b7
JD
5638 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5639 (symbol_to_nsstring): Fix indentation.
5640 (ns_symbol_to_pb): New function.
cae07000
SM
5641 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5642 (Fns_rotate_cut_buffers_internal): Remove.
5643 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5644 Fns_store_cut_buffer_internal.
5645 (ns_get_foreign_selection, Fx_own_selection_internal)
5646 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5647 (Fns_get_selection_internal, Fns_store_selection_internal):
5648 Use ns_symbol_to_pb and check if return value is nil.
5649 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5650 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5651 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5652 renamed to Sns_store_selection_internal.
5653 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5654 and remove this function.
5655 (ns_handle_selection_clear): Remove, never used.
5656 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5657 here.
5658
e1b01a3a
KB
56592011-12-17 Ken Brown <kbrown@cornell.edu>
5660
5661 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5662 GID is unknown (Bug#10257).
5663
2adb6e85
PE
56642011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5665
5666 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5667 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5668 which caused a build failure on GNU/Linux IA-64. This problem was
5669 introduced by my 2011-10-07 patch.
5670
d1d7b339
JL
56712011-12-15 Juri Linkov <juri@jurta.org>
5672
5673 * image.c (imagemagick_error): New function. (Bug#10112)
5674 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5675 Use `imagemagick_error' where ImageMagick functions return
5676 `MagickFalse'.
5677 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5678 proper order.
5679
100d5755
KH
56802011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5681
5682 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5683 fill background (Bug#8992).
5684
454592a6
MR
56852011-12-13 Martin Rudalics <rudalics@gmx.at>
5686
5687 * window.c (Vwindow_combination_resize)
5688 (Vwindow_combination_limit): Use t instead of non-nil in
5689 doc-strings.
61d4b438
MR
5690 (Vrecenter_redisplay): Add first sentence of doc-string on
5691 separate line.
53524d93 5692 (Frecenter): Fix doc-string typo.
454592a6 5693
3633e3aa
KH
56942011-12-11 Kenichi Handa <handa@m17n.org>
5695
5696 * coding.c (Funencodable_char_position): Pay attention to the
5697 buffer text relocation (Bug#9389).
5698
7b9d523a 56992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5700
7b9d523a
JD
5701 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5702 gtk_init (Bug#10100).
5703
b73189c6
EZ
57042011-12-10 Eli Zaretskii <eliz@gnu.org>
5705
5706 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5707 IT->string is nil. (Bug#10263)
5708
f7dfe5d6
JD
57092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5710
83faebb4
JD
5711 * nsterm.h (x_free_frame_resources): Declare.
5712
f7dfe5d6
JD
5713 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5714 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5715
5716 * nsterm.h (ns_get_defaults_value): Declare.
5717
5718 * nsterm.m (ns_default): Call ns_get_defaults_value.
5719
7cd4e72c
EZ
57202011-12-09 Eli Zaretskii <eliz@gnu.org>
5721
5722 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5723 (Bug#10170)
5724
b34d7317
YM
57252011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5726
5727 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5728 that where the value of an _OBJC_* symbol points to is in the .bss
5729 section (Bug#10240).
5730
76470ad1
KH
57312011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5732
5733 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5734 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5735
745fff94
KH
57362011-12-08 Kenichi Handa <handa@m17n.org>
5737
5738 * ftfont.c (get_adstyle_property): Fix previous change
5739 (Bug#10233).
5740
6e44397c
JB
57412011-12-07 Juanma Barranquero <lekktu@gmail.com>
5742
5743 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5744 dirs from the default value of EMACSLOADPATH (bug#10208).
5745
7efa6272
GM
57462011-12-07 Glenn Morris <rgm@gnu.org>
5747
5748 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5749 installation and source directories as well. (Bug#10208)
5750
f6fc4d87
CY
57512011-12-06 Chong Yidong <cyd@gnu.org>
5752
5753 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5754
2bf26180
GM
57552011-12-06 Glenn Morris <rgm@gnu.org>
5756
5757 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5758 as an error, not just -1. (Bug#10217)
5759
3a6ad4f0
CY
57602011-12-05 Chong Yidong <cyd@gnu.org>
5761
5762 * keyboard.c (process_special_events): New function.
5763 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5764
75a3b399
PE
57652011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5766
5767 * coding.c (encode_designation_at_bol): Don't use uninitialized
5768 local variable (Bug#9318).
5769
c3c9e25e
KH
57702011-12-05 Kenichi Handa <handa@m17n.org>
5771
5772 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5773 return Qnil (Bug#8046, Bug#10193).
5774
5eb05ea3
KH
57752011-12-05 Kenichi Handa <handa@m17n.org>
5776
5777 * coding.c (encode_designation_at_bol): New args charbuf_end and
5778 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5779 (coding_set_source): Return how many bytes coding->source was
5780 relocated.
5781 (coding_set_destination): Return how many bytes
5782 coding->destination was relocated.
5783 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5784 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5785
57862011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5787
5788 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5789 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5790 macro (Bug#9318).
5791
57922011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5793
5794 The following changes are to fix Bug#9318.
5795
a79703f5 5796 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5797 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5798 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5799 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5800
7dbda6df
JB
58012011-12-05 Juanma Barranquero <lekktu@gmail.com>
5802
5803 * lisp.h (process_quit_flag): Fix external declaration.
5804
6d5eb5b0
SM
58052011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5806
5807 Don't macro-inline non-performance-critical code.
5808 * eval.c (process_quit_flag): New function.
5809 * lisp.h (QUIT): Use it.
5810
a0c3fad0
JD
58112011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5812
5813 * nsfns.m (get_geometry_from_preferences): New function.
5814 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5815
6c07aac2
AS
58162011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5817
5818 * emacs.c (Qkill_emacs): Define.
5819 (syms_of_emacs): Initialize it.
5820 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5821 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5822 (quit_throw_to_read_char): Add parameter `from_signal'.
5823 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5824 * lisp.h (QUIT): Call Fkill_emacs if requested.
5825
c052ead4
JD
58262011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5827
5828 * widget.c (update_wm_hints): Return if wmshell is null.
5829 (widget_update_wm_size_hints): New function.
5830
5831 * widget.h (widget_update_wm_size_hints): Declare.
5832
5833 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5834 widget_update_wm_size_hints (Bug#10104).
5835
9e49252b
EZ
58362011-12-03 Eli Zaretskii <eliz@gnu.org>
5837
5838 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5839 before a newline, prepare the bidi iterator for consuming the
5840 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5841 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5842
02b16839
JL
58432011-12-02 Juri Linkov <juri@jurta.org>
5844
5845 * search.c (Fword_search_regexp): New Lisp function created from
5846 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5847 (Fword_search_backward, Fword_search_forward)
5848 (Fword_search_backward_lax, Fword_search_forward_lax):
5849 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5850 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5851
0068070e
SM
58522011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5853
5854 * fileio.c (Finsert_file_contents): Move after-change-function call
5855 to before the "handled:" label, since all "goto handled" appear in
5856 cases where the *-change-functions have already been properly called
5857 (bug#10117).
5858
3360a3fc
AS
58592011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5860
5861 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5862 waiting for input. (Bug#10169)
5863
73d6c093
EZ
58642011-11-30 Eli Zaretskii <eliz@gnu.org>
5865
5866 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5867 verifies glyph row's hash code--we have just reallocated the
5868 glyphs, so their contents can be complete garbage. (Bug#10164)
5869
febe6bea
JB
58702011-11-30 Juanma Barranquero <lekktu@gmail.com>
5871
5872 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5873
801a4313
EZ
58742011-11-30 Eli Zaretskii <eliz@gnu.org>
5875
5876 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5877 attributes are tested _before_ calling verify_row_hash, to protect
5878 against GCC re-ordering of the tests. (Bug#10164)
5879
2b56b87e
JD
58802011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5881
5882 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5883
5884 * xterm.c (handle_one_xevent): Only set async_visible and friends
5885 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5886 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5887 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5888
dbf31225
PE
58892011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5890
5891 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5892 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5893 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5894 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5895 All uses changed to use GCPRO1 etc.
5896 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5897 Revert to old implementation (i.e., before 2011-03-11).
5898
1305621b
YM
58992011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5900
5901 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5902 of scroll runs so as to avoid assigning disabled bogus rows and
5903 unnecessary graphics copy operations.
5904
8c9afb46
EZ
59052011-11-27 Eli Zaretskii <eliz@gnu.org>
5906
5907 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5908 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5909 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5910 (malloc, free, realloc, calloc): Redirect to e_* only when
5911 compiling Emacs.
5912
5913 * lisp.h (GCTYPEBITS): Move before first use.
5914 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5915 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5916 this macro definition.
5917
5918 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5919 _MSC_VER.
5920
54e9e3bf
JD
59212011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5922
6d5eb5b0
SM
5923 * gtkutil.c (xg_create_frame_widgets):
5924 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5925 present with Gtk+ 2.0.
5926
83aca1cb
PE
59272011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5928
5929 * fileio.c (Finsert_file_contents): Undo previous change; see
5930 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5931
5b76caa4
PE
59322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5933
5934 Rename locals to avoid shadowing.
5935 * fileio.c (Finsert_file_contents):
5936 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5937 * process.c (wait_reading_process_output):
5938 Rename inner 'proc' to 'p' to avoid shadowing.
5939 Indent for consistency with usual Emacs style.
5940
8c535114
EZ
59412011-11-25 Eli Zaretskii <eliz@gnu.org>
5942
5943 * xdisp.c (redisplay_window): If cursor row is not fully visible
5944 after recentering, and scroll-conservatively is set to a large
5945 number, scroll window by a few more lines to make the cursor fully
5946 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5947 (start_display): Don't move to the next line if the display should
5948 start at a newline that is part of a display vector or an overlay
5949 string. (Bug#10119)
8c535114 5950
fa4fdb5c
JL
59512011-11-24 Juri Linkov <juri@jurta.org>
5952
5953 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5954 after the `MagickPingImage' call. (Bug#10112)
5955
90ec88df
CY
59562011-11-23 Chong Yidong <cyd@gnu.org>
5957
5958 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5959
56e2e794
MR
59602011-11-23 Martin Rudalics <rudalics@gmx.at>
5961
5962 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5963 making another buffer current. (Bug#10114)
5964
b6e64c41
GM
59652011-11-23 Glenn Morris <rgm@gnu.org>
5966
5967 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5968
6b21de18
CY
59692011-11-23 Chong Yidong <cyd@gnu.org>
5970
5971 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5972 using it (Bug#5984).
5973
b12cd789
EZ
59742011-11-22 Eli Zaretskii <eliz@gnu.org>
5975
5976 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5977 and header-lines, as they don't have one computed for them.
5978 (Bug#10098)
5979
5980 * .gdbinit (prow): Make displayed values more self-explaining.
5981 Add row's hash code.
5982
261b6fd4
LMI
59832011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5984
5985 * process.c (wait_reading_process_output): Fix asynchrounous
5986 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5987 (wait_reading_process_output): Add comment and URL.
261b6fd4 5988
e7cfd277
JD
59892011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5990
5991 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5992
a9b9b7f5
CY
59932011-11-21 Chong Yidong <cyd@gnu.org>
5994
5995 * window.c (Fnext_window, Fprevious_window): Doc fix.
5996
b0d15b4f
SM
59972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5998
5999 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6000
fe7a3057
JB
60012011-11-20 Juanma Barranquero <lekktu@gmail.com>
6002
6003 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6004
d2999b1a
MR
60052011-11-20 Martin Rudalics <rudalics@gmx.at>
6006
6007 * window.c (Fset_window_combination_limit): Rename argument
6008 STATUS to LIMIT.
6009 (Vwindow_combination_limit): Remove "status" from doc-string.
6010
d5ff9cd0
AS
60112011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6012
6013 * m/ibms390.h: Remove.
6014 * m/ibms390x.h: Don't include "ibms390.h".
6015
a5bb9bd3
SM
60162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6017
6018 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6019 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6020
cd1181db
JB
60212011-11-20 Juanma Barranquero <lekktu@gmail.com>
6022
6023 * casetab.c (Fset_case_table):
6024 * charset.c (Fcharset_after): Fix typos.
6025
615a3b8d 60262011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6027
17e845af
PE
6028 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6029 Otherwise, valgrind does not work on some platforms.
6030 Problem reported by Andreas Schwab in
6a0bf43d
PE
6031 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6032 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6033 is set, removing the need for VIRT_ADDRESS_VARIES.
6034 (PURE_P): Use a more-efficient implementation that needs just one
6035 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6036 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6037 to 4 (xorl, subq, cmpq, setbe).
6038 * alloc.c (pure): Always extern now, since that's the
6039 VIRT_ADDR_VARIES behavior.
6040 (PURE_POINTER_P): Use a single comparison, not two, for
6041 consistency with the new puresize.h.
6042 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6043 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6044 Remove VIRT_ADDR_VARIES no longer needed.
6045
f8fe6f96
EZ
60462011-11-19 Eli Zaretskii <eliz@gnu.org>
6047
6048 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6049 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6050 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6051 behave as if the cursor position were at the window margin.
6052
6053 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6054 and the cursor position is out of bounds, behave as if the cursor
6055 position were at the window margin. (Bug#10075)
6056
df05a53c
CY
60572011-11-18 Chong Yidong <cyd@gnu.org>
6058
6059 * window.c (Fwindow_combination_limit): Make first argument
6060 non-optional, since it is meaningless for live windows like the
6061 selected window.
61ccba97 6062
2071918e
DA
60632011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6064
6065 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6066
b50a28de
SM
60672011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6068
6069 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6070 (graft_intervals_into_buffer): Simplify.
6071
015137db
EZ
60722011-11-18 Eli Zaretskii <eliz@gnu.org>
6073
6074 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6075 hash values of the two rows.
6076 (copy_row_except_pointers): Preserve the used[] arrays and the
6077 hash values of the two rows. (Bug#10035)
68c95424 6078 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6079
6080 * xdisp.c (row_hash): New function, body extracted from
6081 compute_line_metrics.
6082 (compute_line_metrics): Call row_hash, instead of computing the
6083 hash code inline.
6084
6085 * dispnew.c (verify_row_hash): Call row_hash for computing the
6086 hash code of a row, instead of duplicating code from xdisp.c.
6087
6088 * dispextern.h (row_hash): Add prototype.
6089
a2addb04
TH
60902011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6091
6092 * frame.c (delete_frame): Don't delete the terminal when the last
6093 X frame is closed if emacs is built with GTK toolkit.
6094
df85d315
JB
60952011-11-17 Juanma Barranquero <lekktu@gmail.com>
6096
6097 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6098
a0c2d0ae
MR
60992011-11-17 Martin Rudalics <rudalics@gmx.at>
6100
6101 * window.c (Vwindow_splits): Rename to
6102 Vwindow_combination_resize. Suggested by Juri Linkov.
6103 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6104 of Vwindow_splits.
6105
58179cce
JB
61062011-11-16 Juanma Barranquero <lekktu@gmail.com>
6107
7877f373
JB
6108 * nsfns.m (Fns_font_name):
6109 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6110
b6f67890
MR
61112011-11-16 Martin Rudalics <rudalics@gmx.at>
6112
6113 * window.h (window): Rename slot "nest" to "combination_limit".
6114 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6115 (Fset_window_nest): Rename to Fset_window_combination_limit.
6116 (Vwindow_nest): Rename to Vwindow_combination_limit.
6117 (recombine_windows, make_parent_window, make_window)
6118 (Fsplit_window_internal, saved_window)
6119 (Fset_window_configuration, save_window_save): Rename all
6120 occurrences of window_nest to window_combination_limit.
6121
c7015153
JB
61222011-11-15 Juanma Barranquero <lekktu@gmail.com>
6123
6124 * image.c (imagemagick_load_image): Fix typo.
6125
322ad6ec
EZ
61262011-11-14 Eli Zaretskii <eliz@gnu.org>
6127
6128 * xdisp.c (display_line): Move the call to
6129 highlight_trailing_whitespace before the call to
6130 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6131 faces of all the glyphs to compute ROW's hash value.
6132 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6133
f067b8ec
JB
61342011-11-14 Juanma Barranquero <lekktu@gmail.com>
6135
6136 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6137 just return (bug#10044).
6138
1e5b2111
EZ
61392011-11-12 Eli Zaretskii <eliz@gnu.org>
6140
7ef3cbd5
EZ
6141 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6142 with user-defined heap size. Bump the default size of the temacs
6143 heap to 27MB, to avoid memory warning when running temacs.
6144 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6145
1e5b2111
EZ
6146 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6147 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6148 (verify_row_hash) [XASSERTS]: New function.
6149 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6150 that the hash value of glyph rows is correct.
1e5b2111 6151
89d61221
MR
61522011-11-12 Martin Rudalics <rudalics@gmx.at>
6153
6154 * window.h (window): Remove splits slot.
6155 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6156 (Fdelete_other_windows_internal, make_parent_window)
6157 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6158 (Fset_window_configuration, save_window_save): Don't deal with
6159 split status of windows.
6160 (saved_window): Remove splits slot.
6161 (Vwindow_splits): Rewrite doc-string.
6162
97f18cc8
JD
61632011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6164
6165 * xfns.c (unwind_create_frame):
6166 * nsfns.m (unwind_create_frame):
6167 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6168 Vframe_list (Bug#9999).
6169
22a648b4
DA
61702011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6171
0b381c7e 6172 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6173
659afede
KH
61742011-11-11 Kenichi Handa <handa@m17n.org>
6175
6176 * callproc.c (Fcall_process): Set the member dst_multibyte of
6177 process_coding.
6178
9ac0394b
KH
61792011-11-11 Johan Bockgård <bojohan@gnu.org>
6180
6181 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6182 avoid a crash (bug#9496).
6183
2fbdc249
CY
61842011-11-09 Chong Yidong <cyd@gnu.org>
6185
6186 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6187 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6188
ac6b1f81
PE
61892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6190
6191 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6192
09db192c
PE
61932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6194
6195 Avoid some portability problems by eschewing 'extern inline' functions.
6196 The trivial performance wins aren't worth the portability hassles; see
6197 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6198 et seq.
6199 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6200 (window_box_width, window_box_left, window_box_left_offset)
6201 (window_box_right, window_box_right_offset): Undo previous change,
6202 by removing the "extern"s.
6203 * intervals.c (adjust_intervals_for_insertion)
6204 (adjust_intervals_for_deletion): Undo previous change,
6205 making these static again.
6206 (offset_intervals, temp_set_point_both, temp_set_point)
6207 (copy_intervals_to_string): No longer inline.
6208 * xdisp.c (window_text_bottom_y, window_box_width)
6209 (window_box_height, window_box_left_offset)
6210 (window_box_right_offset, window_box_left, window_box_right)
6211 (window_box): No longer inline.
6212
105216ed
CY
62132011-11-08 Chong Yidong <cyd@gnu.org>
6214
6215 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6216 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6217 Signal an error if not a live window.
105216ed
CY
6218 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6219 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6220
ae9e237f
JB
62212011-11-07 Juanma Barranquero <lekktu@gmail.com>
6222
6223 * lisp.h (syms_of_abbrev): Remove declaration.
6224 Reported by CHENG Gao <chenggao@royau.me>.
6225
c7aa8333
EZ
62262011-11-07 Eli Zaretskii <eliz@gnu.org>
6227
6228 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6229 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6230 of temacs in GUI mode.
6231
be7f5545
MR
62322011-11-07 Martin Rudalics <rudalics@gmx.at>
6233
6234 * window.h: Declare delete_all_child_windows instead of
6235 delete_all_subwindows.
6236 * window.c (Fwindow_nest, Fset_window_nest)
6237 (Fset_window_new_total, Fset_window_new_normal)
6238 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6239 (delete_all_subwindows): Rename to delete_all_child_windows.
6240 (Fdelete_other_windows_internal, Fset_window_configuration):
6241 Call delete_all_child_windows instead of delete_all_subwindows.
6242 * frame.c (delete_frame): Call delete_all_child_windows instead
6243 of delete_all_subwindows.
6244
ca78dc43
PE
62452011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6246
6247 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6248 This is also needed for porting to any host where GC_MARK_STACK is
6249 not GC_MAKE_GCPROS_NOOPS.
6250 (which_symbols): Use it.
6251
a0241d01
KH
62522011-11-07 Kenichi Handa <handa@m17n.org>
6253
6254 * coding.c (coding_set_destination): Check coding->src_pos only
6255 when coding->src_object is a buffer (bug#9910).
6256
6257 * process.c (send_process): Set the member src_multibyte of coding
6258 to 0 (bug#9911) when sending a unibyte text.
6259
6260 * callproc.c (Fcall_process): Set the member src_multibyte of
6261 process_coding to 0 (bug#9912).
6262
a64bfdfa 62632011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6264
6265 * xmenu.c (cleanup_widget_value_tree): New function.
6266 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6267 calling free_menubar_widget_value_tree directly (Bug#9830).
6268
cb41b32a
PE
62692011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6270
6271 Fix some portability problems with 'inline'.
6272 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6273 (window_box_width, window_box_left, window_box_left_offset)
6274 (window_box_right, window_box_right_offset): Declare extern.
6275 Otherwise, these inline functions do not conform to C99 and
6276 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6277 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6278 * intervals.c (adjust_intervals_for_insertion)
6279 (adjust_intervals_for_deletion): Now extern, because otherwise the
6280 extern inline functions 'offset_intervals' couldn't refer to it.
6281 (static_offset_intervals): Remove.
6282 (offset_intervals): Rewrite using the old contents of
6283 static_offset_intervals. The old version didn't conform to C99
6284 because an extern inline function contained a reference to an
6285 identifier with static linkage.
6286
b7041366
AS
62872011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6288
6289 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6290 GC.
6291
88a37c4d
EZ
62922011-11-06 Eli Zaretskii <eliz@gnu.org>
6293
6294 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6295 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6296 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6297 return Qleft_to_right.
6298
49745b39
CY
62992011-11-06 Chong Yidong <cyd@gnu.org>
6300
6301 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6302 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6303 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6304 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6305 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6306 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6307 (Fwindow_vscroll): Doc fix.
6308 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6309 argument, since it makes no sense to pass a live window and for
6310 consistency with window-child.
6311
1f05cd82
CS
63122011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6313
6314 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6315 support MSVC.
6316
22610910
JR
63172011-11-05 Jason Rumney <jasonr@gnu.org>
6318
6319 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6320 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6321 fonts (Bug#6029).
6322 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6323 bitwise arithmetic preventing use of unicode-sip and non-truetype
6324 opentype fonts.
6325
a06776b2
EZ
63262011-11-05 Eli Zaretskii <eliz@gnu.org>
6327
3ad924ba
EZ
6328 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6329 "emacs"-only part.
6330
a06776b2
EZ
6331 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6332 initialization code to keep similarity to xfns.c after changes
6333 from 2011-11-05.
6334
c9e7db78
JD
63352011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6336
a97f8f3f
JD
6337 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6338 (unwind_create_frame): New function (Bug#9943).
6339 (Fx_create_frame): Restructure code to be more similar to the one in
6340 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6341 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6342 Move terminal->reference_count++ just before making the frame official
6343 (Bug#9943).
6344
6345 * nsterm.m (x_free_frame_resources): New function.
6346 (x_destroy_window): Move code to x_free_frame_resources.
6347
c9e7db78 6348 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6349 (Fx_create_frame, x_create_tip_frame):
6350 Move terminal->reference_count++ just before making the frame
75f1671a 6351 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6352 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6353
a6fc3b5c
EZ
63542011-11-05 Eli Zaretskii <eliz@gnu.org>
6355
6356 Support MSVC build with newer versions of Visual Studio.
6357 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6358 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6359 nt/gmake.defs.
6360
6361 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6362 which are not supported by MSVC.
6363 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6364 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6365 bitfields.
6366 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6367 types in bitfields.
6368 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6369
6370 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6371
58179cce 63722011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6373
6374 Support MSVC build with newer versions of Visual Studio.
6375 * w32.c: Don't include w32api.h for MSVC.
6376 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6377
6378 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6379 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6380 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6381 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6382 e_* cousins.
6383 (alloca) [_MSC_VER]: Define to _alloca.
6384
6385 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6386
6387 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6388
a58c13ed
EZ
63892011-11-04 Eli Zaretskii <eliz@gnu.org>
6390
6391 * xdisp.c (note_mouse_highlight): If either of
6392 previous/next-single-property-change returns nil, treat that as
6393 the beginning or the end of the buffer. (Bug#9955)
6394
fe0b6370
JD
63952011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6396
a58c13ed 6397 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6398 label is not null (Bug#9951).
6399 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6400 may be NULL.
6401
89bd5ee1
EZ
64022011-11-04 Eli Zaretskii <eliz@gnu.org>
6403
6404 * window.c (Fwindow_body_size): Mention in the doc string that the
6405 return value is in frame's canonical units. (Bug#9949)
6406
84c3edb9
EZ
64072011-11-03 Eli Zaretskii <eliz@gnu.org>
6408
4e2fb5c7
EZ
6409 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6410
84c3edb9 6411 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6412 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6413 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6414
bc17a887
EZ
64152011-11-01 Eli Zaretskii <eliz@gnu.org>
6416
6417 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6418 Don't stop backward scan on the continuation glyph, even though
6419 its CHARPOS is positive.
6d5eb5b0
SM
6420 (mouse_face_from_buffer_pos, note_mouse_highlight):
6421 Rename cover_string to disp_string.
bc17a887 6422
4ee88440
MR
64232011-11-01 Martin Rudalics <rudalics@gmx.at>
6424
6425 * window.c (temp_output_buffer_show): Don't use
6426 Vtemp_buffer_show_specifiers.
6427 (Vtemp_buffer_show_specifiers): Remove unused variable.
6428
c2ff3c02
EZ
64292011-10-30 Eli Zaretskii <eliz@gnu.org>
6430
6431 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6432 past the beginning of the current glyph matrix.
6433
58179cce 64342011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6435
6436 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6437 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6438 HAVE_GTK3 (Bug#9869).
b77a6a7f 6439
3b574623
JD
6440 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6441 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6442
b77a6a7f
JD
6443 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6444
6445 * xterm.c: Declare x_handle_net_wm_state to return int.
6446 (handle_one_xevent): Check if we are iconified but don't have
6447 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6448 (get_current_wm_state): Return non-zero if not hidden,
6449 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6450 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6451 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6452 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6453
196e41e4
PE
64542011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6455
6456 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6457 so that this new function doesn't get optimized away by a
6458 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6459
021f2e1a
AS
64602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6461
6462 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6463
8b058d44
EZ
64642011-10-29 Eli Zaretskii <eliz@gnu.org>
6465
6466 Fix the `xbytecode' command.
6467 * .gdbinit (xprintbytestr): New command.
b50a28de 6468 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6469 (xbytecode): Print the byte-code string as well.
6470
4452fb80
EZ
64712011-10-29 Kim Storm <storm@cua.dk>
6472
8b058d44
EZ
6473 * alloc.c (which_symbols): New function.
6474
21b72067
AS
64752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6476
6477 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6478 line. (Bug#9903)
6479
83ed7b5c
GM
64802011-10-29 Glenn Morris <rgm@gnu.org>
6481
6482 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6483 Not clear what it was for, and it causes various bugs. (Bug#9839)
6484
5a7a728b
EZ
64852011-10-28 Eli Zaretskii <eliz@gnu.org>
6486
6487 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6488 possible random value that matches one of those tested as
6489 condition to clear the mouse face.
6490
d3d0842f
CY
64912011-10-28 Chong Yidong <cyd@gnu.org>
6492
6493 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6494
31b39d13
DN
64952011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6496
6497 * window.c (make_window): Initialize phys_cursor_on_p.
6498
9aba6043
SM
64992011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6500
6501 * lisp.h (struct Lisp_Symbol): Update comments.
6502
c20992f4
JB
65032011-10-28 Juanma Barranquero <lekktu@gmail.com>
6504
6505 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6506
db4f02f2
EZ
65072011-10-28 Eli Zaretskii <eliz@gnu.org>
6508
6509 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6510 <oslsachem@gmail.com> for helping to debug this.
6511
6512 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6513 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6514 (g_b_init_get_glyph_outline_w): New static variables.
6515 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6516 (GetGlyphOutlineW_Proc): New typedefs.
6517 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6518 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6519 New functions.
6520 (w32font_open_internal, compute_metrics):
6521 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6522 instead of calling the "wide" APIs directly.
6523
6524 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6525
6526 * w32.h (syms_of_w32font): Add prototype.
6527
87e68db4
JB
65282011-10-27 Juanma Barranquero <lekktu@gmail.com>
6529
6530 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6531 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6532 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6533 (Fmove_to_window_line): Doc fix.
6534
435c1d67
CY
65352011-10-27 Chong Yidong <cyd@gnu.org>
6536
6537 * process.c (make_process): Set gnutls_state to NULL.
6538
6539 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6540 non-NULL, regardless of GNUTLS_INITSTAGE.
6541 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6542 an error. Set process slots as soon as we allocate them.
6543
6544 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6545
9c6c6f49
CY
65462011-10-27 Chong Yidong <cyd@gnu.org>
6547
9aba6043
SM
6548 * gnutls.c (emacs_gnutls_deinit): New function.
6549 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6550 (Fgnutls_deinit, Fgnutls_boot): Use it.
6551
6552 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6553 (deactivate_process): Call emacs_gnutls_deinit.
6554
657d08d3
JB
65552011-10-27 Juanma Barranquero <lekktu@gmail.com>
6556
6557 * image.c (x_create_x_image_and_pixmap):
6558 * w32.c (sys_rename, w32_delayed_load):
6559 * w32font.c (fill_in_logfont):
6560 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6561
5430d399
JB
65622011-10-26 Juanma Barranquero <lekktu@gmail.com>
6563
6564 * w32fns.c (w32_default_color_map): New function,
6565 extracted from Fw32_default_color_map.
a7ef684b 6566 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6567
fe0055fa
PE
65682011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6569
6570 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6571
e6346438
SM
65722011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6573
6574 * keyboard.c (test_undefined): New function (bug#9751).
6575 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6576
e112cc37
ET
65772011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6578
6579 * sysdep.c (init_sys_modes): Fix the check for the controlling
6580 terminal (Bug#6649).
6581
7b5d6677
EZ
65822011-10-20 Eli Zaretskii <eliz@gnu.org>
6583
6584 * dispextern.h (struct bidi_it): New member next_en_type.
6585
6586 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6587 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6588 current character, check also for next_en_type being WEAK_EN.
6589 (bidi_resolve_weak): Don't enter the expensive loop if the current
6590 position is before next_en_pos. Record the bidi type of the first
6591 non-ET, non-BN character we find, in addition to its position.
6592 (bidi_level_of_next_char): Invalidate next_en_type when
6593 next_en_pos is over-stepped.
6594
7da0b018
PE
65952011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6596
6597 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6598 * editfns.c: Rewrite current-time-zone so that it invokes
6599 the equivalent of (format-time-string "%Z") to get the time zone name.
6600 This fixes a bug when the time zone name contains characters that
6601 need converting from the system time locale to Emacs internal format.
6602 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6603 that patch fixed format-time-string to do the conversion, but
6604 I forgot to fix current-time-zone.
6605 (format_time_string): New function, containing most of
6606 what Fformat_time_string used to contain.
6607 (Fformat_time_string): Rewrite in terms of format_time_string.
6608 This doesn't change this function's behavior.
6609 (current-time-zone): Rewrite to use format_time_string.
6610 This fixes the bug reported by Michael Schierl in
6611 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6612 Jason Rumney's 2007-06-07 change worked around this bug, but
6613 didn't fix it.
6614 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6615
8547b010
EZ
66162011-10-19 Eli Zaretskii <eliz@gnu.org>
6617
6618 * xdisp.c (start_display): If the character at POS is displayed
6619 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6620 (try_window_reusing_current_matrix): If a line ends in a display
6621 vector or the next line starts in a display vector, continue
6622 redrawing the window even though the character position of
6623 start_row was reached.
8547b010
EZ
6624 (Bug#9771, part 2)
6625
4e948d15
CY
66262011-10-18 Chong Yidong <cyd@gnu.org>
6627
6628 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6629 with nobreak-char-display too.
6630
4787455f
EZ
66312011-10-18 Eli Zaretskii <eliz@gnu.org>
6632
6633 Fix part 3 of bug#9771.
6634 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6635 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6636 non-neutral characters if the current character is a paragraph
6637 separator (a.k.a. Newline). This avoids running the same
6638 expensive loop twice, once when we consume the preceding newline
6639 and the other time when the line actually needs to be displayed.
6640 Avoid the loop when we see neutrals on the base embedding level
6641 following a character whose directionality is the same as the
6642 paragraph's. This avoids running the expensive loop when a line
6643 ends in a long sequence of neutrals, like control characters.
6644 Add assertion against STRONG_AL type. Slightly rearrange code
6645 that determines the type of a neutral given the first non-neutral
6646 that follows it.
6647 (bidi_level_of_next_char): Set next_en_pos to zero when
6648 invalidating its info.
6649
2c91f553
EZ
66502011-10-17 Eli Zaretskii <eliz@gnu.org>
6651
6652 * xdisp.c (push_display_prop): Determine whether to record string
6653 or buffer position by IT->string, not by IT->method. Allow
6654 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6655 (move_it_vertically_backward): Don't look for character position
6656 immediately after the newline when in a continuation line.
6657 (Bug#9771, part 1)
2c91f553 6658
c7b08b0d
MR
66592011-10-15 Martin Rudalics <rudalics@gmx.at>
6660
6661 * window.c (coordinates_in_window): Rewrite and delabelize
6662 vertical border check. (Bug#5357) (Bug#9618)
6663
6b02f655
SM
66642011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6665
6666 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6667 errors in XSetWindowBorder (bug#9310).
6668
81d40c92
DA
66692011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6670
6671 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6672 avoid crash when xmalloc overrun checking is enabled.
6673
d4172c3b
EZ
66742011-10-13 Eli Zaretskii <eliz@gnu.org>
6675
6676 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6677 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6678 cursor motion with <left> and <right> arrow keys.
6679
6680 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6681 some callers set that themselves.
6682
b00eea75
EZ
66832011-10-12 Eli Zaretskii <eliz@gnu.org>
6684
6685 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6686 display string and the previous row comes from the same string and
6687 is empty. (Bug#9739) (Bug#9738)
6688
8fe012c4
SM
66892011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6690
6691 * doc.c (get_doc_string): Encode file name (bug#9735).
6692
0074aef2
EZ
66932011-10-12 Eli Zaretskii <eliz@gnu.org>
6694
79beb178
EZ
6695 * bidi.c (bidi_level_of_next_char):
6696 * xdisp.c (get_visually_first_element): Remove old incorrect
6697 comments regarding the Unicode Line Separator character.
6698
0074aef2
EZ
6699 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6700
6e4b3fbe
DA
67012011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6702
6703 * alloc.c (Fgc_status): Do not access beyond zombies array
6704 boundary if nzombies > MAX_ZOMBIES.
6705 * alloc.c (dump_zombies): Add missing format specifier.
6706
0324f3af
PE
67072011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6708
b5525cac
PE
6709 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6710 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6711
0324f3af
PE
6712 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6713 Some packages use them to denote characters with modifiers.
6714
e9b5f888
AS
67152011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6716
6717 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6718 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6719 matching a pp-number. Rename parameter var to var1.
6720
127827c0
SM
67212011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6722
6723 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6724
c8fd3bd0
GM
67252011-10-08 Glenn Morris <rgm@gnu.org>
6726
6727 * callint.c (Fcall_interactively): Give a more explicit error for the
6728 'c' case with a non-character input. (Bug#8479)
6729
352ec8ff
EZ
67302011-10-08 Eli Zaretskii <eliz@gnu.org>
6731
03669ccb
EZ
6732 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6733 lines.
7061c986
EZ
6734 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6735 lines that are hscrolled on the left.
03669ccb 6736
352ec8ff
EZ
6737 * dispnew.c (buffer_posn_from_coords): Account for a possible
6738 presence of header-line. (Bug#4426)
6739
a66cfb1c
SM
67402011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6741
6b02f655
SM
6742 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6743 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6744
7c5ee88e
PE
67452011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6746
6747 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6748 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6749 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6750 this makes Emacs dump core during garbage collection on rare
6751 occasions. sizeof is obviously inferior to offsetof here, so
6752 stick with offsetof.
6753 (GC_POINTER_ALIGNMENT): New macro.
6754 (mark_memory): Omit 3rd (offset) arg; caller changed.
6755 Don't assume EMACS_INT alignment is the same as pointer alignment.
6756
df1bbe5b
SM
67572011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6758
6759 * keyboard.c (read_key_sequence_remapped): New var.
6760 (read_key_sequence): Compute remapping in the right buffer.
6761 (command_loop_1): Use read_key_sequence's remapping directly.
6762
51553db6
SM
67632011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6764
32c1fffd
SM
6765 * dired.c (file_name_completion): Don't expand file name.
6766 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6767 before checking file name handler.
6768
51553db6
SM
6769 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6770 they've been requested explicitly (bug#9591).
6771
b6bd1599 67722011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6773
6774 * keymap.c (Fsingle_key_description): Use make_specified_string
6775 instead of build_string to build string from push_key_description.
6776 (Bug#5193)
6777
f701dc2a
PE
67782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6779
4222c55d
PE
6780 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6781 This fixes a Y2038 bug on 64-bit hosts.
6782 * buffer.c (reset_buffer):
6783 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6784 (Fclear_buffer_auto_save_failure):
6785 Use 0, not -1, to represent an unset failure time, since time_t
6786 might not be signed.
6787
f701dc2a
PE
6788 Remove dependency on glibc malloc internals.
6789 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6790 Move back here from lisp.h, but with their new implementations.
6791 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6792 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6793 * charset.c (charset_table_init): New static var.
6794 (syms_of_charset): Use it instead of xmalloc. This removes a
6795 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6796 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6797 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6798 Move back to alloc.c.
6799 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6800 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6801
9ceebf39
JD
68022011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6803
6804 * nsterm.m (windowDidResize): Call x_set_window_size only when
6805 ns_in_resize is true. Otherwise set pixelwidth/height and
6806 call change_frame_size (Bug#9628).
6807
cb993c58
PE
68082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6809
3930c88b
PE
6810 Port --enable-checking=all to Fedora 14 x86-64.
6811 * charset.c (syms_of_charset): Also account for glibc malloc's
6812 internal overhead when calculating the initial malloc maximum.
6813
cb993c58
PE
6814 Port --enable-checking=all to Fedora 14 x86.
6815 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6816 Move to lisp.h.
6817 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6818 (overrun_check_realloc, overrun_check_free):
6819 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6820 That way, xmalloc returns a properly-aligned pointer even if
6821 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6822 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6823 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6824 into account when calculating the initial malloc maximum.
6825 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6826 Move here from alloc.c, so that charset.c can use it too.
6827 Properly align; the old code wasn't right for common 32-bit hosts
6828 when configured with --enable-checking=all.
6829 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6830 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6831
31bed486
EZ
68322011-09-29 Eli Zaretskii <eliz@gnu.org>
6833
04c70788 6834 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6835 use EDOM.
6836
fbcaa2f3
EZ
68372011-09-28 Eli Zaretskii <eliz@gnu.org>
6838
6839 * xdisp.c (compute_display_string_end): If there's no display
6840 string at CHARPOS, return -1.
6841
6842 * bidi.c (bidi_fetch_char): When compute_display_string_end
6843 returns a negative value, treat the character as a normal
6844 character not covered by a display string. (Bug#9624)
6845
a239d4e9
JB
68462011-09-28 Juanma Barranquero <lekktu@gmail.com>
6847
6848 * lread.c (Fread_from_string): Fix typo in docstring.
6849
88652fd5
EZ
68502011-09-27 Eli Zaretskii <eliz@gnu.org>
6851
6852 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6853 newline, reseat the iterator instead of bidi-iterating there one
6854 character at a time. (Bug#9610)
32c1fffd
SM
6855 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6856 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6857
ed497dd4
AS
68582011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6859
6860 * lread.c (readevalloop): Use correct code for NBSP.
6861 (read1): Likewise. (Bug#9608)
6862
b2bf61aa
MA
68632011-09-25 Michael Albinus <michael.albinus@gmx.de>
6864
6865 * dbusbind.c (Fdbus_register_signal): When service is not
6866 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6867
32bbb17c
GM
68682011-09-25 Glenn Morris <rgm@gnu.org>
6869
6870 * buffer.c (truncate-lines): Doc fix.
6871
94e0933e
CY
68722011-09-24 Chong Yidong <cyd@stupidchicken.com>
6873
6874 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6875 (Fset_window_next_buffers): Doc fix.
6876
cddde921
GM
68772011-09-24 Glenn Morris <rgm@gnu.org>
6878
6879 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6880
1260aef1
PE
68812011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6882
25b4bfa0
PE
6883 Fix minor problems found by static checking.
6884 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6885 * indent.c (Fvertical_motion): Fix == vs = typo.
6886
e3cbd34b
EZ
68872011-09-24 Eli Zaretskii <eliz@gnu.org>
6888
a66cfb1c
SM
6889 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6890 Default value is now t. Doc fix.
6bf7006f 6891
e3cbd34b 6892 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6893 logic when moving up, not only when moving down. Fix the
e3cbd34b 6894 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6895 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6896
6897 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6898 CHARPOS is covered by a display string which includes newlines.
6899 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6900 is covered by a display string with embedded newlines.
6901
a3de0cbd
MA
69022011-09-24 Michael Albinus <michael.albinus@gmx.de>
6903
6904 * dbusbind.c (Fdbus_register_signal): Add match rule to
6905 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6906 (Fdbus_register_method, Vdbus_registered_objects_table):
6907 Fix docstring.
a3de0cbd 6908
b260039d
JM
69092011-09-24 Jim Meyering <meyering@redhat.com>
6910
32c1fffd 6911 do not ignore write error for any output size
b260039d
JM
6912 The previous change was incomplete.
6913 While it makes emacs --batch detect the vast majority of stdout
6914 write failures, errors were still ignored whenever the output size is
6915 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6916 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6917 && echo FAIL: ignored write error
6918 FAIL: ignored write error
6919 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6920 && echo FAIL: ignored write error
6921 FAIL: ignored write error
6922 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6923
8eca8a7c
AS
69242011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6925
6926 * emacs.c (Fkill_emacs): In noninteractive mode exit
6927 non-successfully if a write error occurred on stdout. (Bug#9574)
6928
3341db62
EZ
69292011-09-21 Eli Zaretskii <eliz@gnu.org>
6930
6931 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6932 the xassert test.
6933
6934 * dispextern.h (struct it): Update the comment documenting what
6935 can it->OBJECT be.
6936
8c203dbf
EZ
69372011-09-20 Eli Zaretskii <eliz@gnu.org>
6938
6939 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6940 a display string, extend search for cursor position to end of row.
6941 (find_row_edges): If the row ends in a newline from a display
6942 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6943 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6944 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6945 non-empty line. Fixes confusing cursor motion with arrow keys at
6946 the beginning of a line that starts with whitespace.
8c203dbf 6947
a4824228
LMI
69482011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6949
6950 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6951 (bug#9493).
6952
33ed493b
CY
69532011-09-18 Chong Yidong <cyd@stupidchicken.com>
6954
6955 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6956 boolean (Bug#9154).
6957
56cd55c8
EZ
69582011-09-18 Eli Zaretskii <eliz@gnu.org>
6959
6960 * xdisp.c (display_line): Record maximum and minimum buffer
6961 positions even if no glyphs were produced (e.g., by a zero-width
6962 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6963 buffer positions that will be removed from the glyph row because
6964 they don't fit.
c02dcedf
EZ
6965 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6966 column is beyond frame width: don't subtract 1 "pixel" when
6967 computing width of the stretch.
3e62b7e0
EZ
6968 (reseat_at_next_visible_line_start): Undo the change made on
6969 2011-09-17 that saved paragraph information and restored it after
6970 the call to `reseat'. (Bug#9545)
56cd55c8 6971
5ed99d36 69722011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6973
6974 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6975 and turn window cursor on if cleared (Bug#9415).
6976
5ed99d36 69772011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6978
6979 * search.c (boyer_moore): Take unibyte characters from pattern
6980 literally. (Bug#9458)
6981
9bade7b2
EZ
69822011-09-18 Eli Zaretskii <eliz@gnu.org>
6983
6984 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6985
e5e9d610
PE
69862011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6987
87e4427a
PE
6988 Fix minor problem found by static checking.
6989 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6990 initialized, to pacify gcc -Wuninitialized.
6991
e5e9d610
PE
6992 * fileio.c: Report proper errno when syscall falls.
6993 (Finsert_file_contents): Save and restore errno,
6994 so that report_file_error outputs the correct diagnostic.
6995 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6996
a1674f0b
EZ
69972011-09-18 Eli Zaretskii <eliz@gnu.org>
6998
6999 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7000
fbfb6dd4
EZ
70012011-09-17 Eli Zaretskii <eliz@gnu.org>
7002
7003 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7004 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7005
bb187662
EZ
70062011-09-17 Eli Zaretskii <eliz@gnu.org>
7007
1137e8b8 7008 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7009 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7010
7011 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7012 (bidi_find_paragraph_start): Search back for paragraph beginning
7013 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7014 (bidi_move_to_visually_next): Only trigger paragraph-related
7015 computations when the last character is a newline or at EOB, not
7016 just any NEUTRAL_B. (Bug#9470)
7017
bb187662
EZ
7018 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7019 truncated lines if point is covered by a display string. (Bug#9524)
7020
2e621251
PE
70212011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7022
7023 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7024 (cons_to_x_long): New function.
7025 (lisp_data_to_selection_data): Use it. Correct the test for
7026 short-versus-long data; it was negated. Break out of vector
7027 loop, for efficiency, when a long datum is discovered.
7028
91a15bc6
SM
70292011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7030
7031 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7032
b41c3a35
EZ
70332011-09-16 Eli Zaretskii <eliz@gnu.org>
7034
7035 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7036 GCC PR/17406) by declaring this function with external scope.
7037
7812ba2d
PE
70382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7039
7040 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7041 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7042
cf7edc2a
AS
70432011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7044
7045 * editfns.c (Fformat): Correctly handle text properties on "%%".
7046
bd01620e
EZ
70472011-09-15 Eli Zaretskii <eliz@gnu.org>
7048
7049 * xterm.c (x_draw_composite_glyph_string_foreground):
7050 * w32term.c (x_draw_composite_glyph_string_foreground):
7051 * term.c (encode_terminal_code):
7052 * composite.c (composition_update_it, get_composition_id):
7053 * xdisp.c (get_next_display_element)
7054 (fill_composite_glyph_string): Add comments about special meaning
7055 of TAB characters in a composition.
7056
a02719a3
PE
70572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7058
7059 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7060 This occurs when processing a multibyte format.
7061 Problem reported by Wolfgang Jenker.
a02719a3 7062
72589a3c
JB
70632011-09-15 Johan Bockgård <bojohan@gnu.org>
7064
7065 * xdisp.c (try_cursor_movement): Only check for exact match if
7066 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7067
1c14176c
PE
70682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7069
7070 Remove unused external symbols.
7071 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7072 * xdisp.c (calc_pixel_width_or_height): Now static.
7073 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7074 * indent.c (check_display_width):
7075 * w32term.c: Fix comment to match code.
7076 * xterm.c, xterm.h (x_catching_errors): Remove.
7077
d2eea5b5
PE
70782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7079
7080 * xselect.c: Use signed conversions more consistently (Bug#9498).
7081 (selection_data_to_lisp_data): Assume incoming selection data are
7082 signed integers, not unsigned. This is to be consistent with
7083 outgoing selection data, which was modified to use signed integers
7084 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7085 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7086 expects long, not unsigned long.
7087
46888499
EZ
70882011-09-14 Eli Zaretskii <eliz@gnu.org>
7089
7090 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7091 computation of loop end. Reported by Johan Bockgård
7092 <bojohan@gnu.org>.
7093
ef8ef9fb
CY
70942011-09-13 Chong Yidong <cyd@stupidchicken.com>
7095
7096 * frame.c (Fother_visible_frames_p): Function deleted.
7097
fa819fed
EZ
70982011-09-12 Eli Zaretskii <eliz@gnu.org>
7099
7100 * indent.c (compute_motion): Process display vector front to back
7101 rather than the other way around. (Bug#2496)
7102
2ba8e008
SM
71032011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7104
7105 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7106
20f53c69
CY
71072011-09-11 Chong Yidong <cyd@stupidchicken.com>
7108
7109 * minibuf.c (Fread_from_minibuffer): Doc fix.
7110
d562d7a4
EZ
71112011-09-11 Eli Zaretskii <eliz@gnu.org>
7112
7113 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7114 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7115
1c4d7f3d
LMI
71162011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7117
7118 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7119 value for non-existent files.
7120
b885bf36
EZ
71212011-09-11 Eli Zaretskii <eliz@gnu.org>
7122
7123 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7124 set its "size" to -1. This will set the modtime_size field of
7125 the corresponding buffer to -1, which is what
7126 verify-visited-file-modtime expects for files that do not exist.
7127 (Bug#9139)
7128
6612f0bf
PE
71292011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7130
7131 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7132 here ...
7133 * lisp.h: ... from here. push_key_description is no longer
7134 defined in keyboard.c, so its declaration should not be in
7135 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7136 logically belongs with push_key_description.
7137
dfb3f755
PE
71382011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7139
7140 * buffer.h: Include <sys/types.h> instead of <time.h>.
7141 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7142 Problem reported by Herbert J. Skuhra.
7143
3134906c
LMI
71442011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7145
7146 * xml.c (parse_region): Make the parsing work for
7147 non-comment-starting XML files again (bug#9144).
7148
8d903f4e
AS
71492011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7150
7151 * image.c (gif_load): Fix calculation of bottom and right corner.
7152 (Bug#9468)
7153
80ad64f4
EZ
71542011-09-10 Eli Zaretskii <eliz@gnu.org>
7155
7156 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7157 redisplay in small windows.
7158
208a048d
EZ
71592011-09-09 Eli Zaretskii <eliz@gnu.org>
7160
7161 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7162
9b1c252e
MR
71632011-09-08 Martin Rudalics <rudalics@gmx.at>
7164
7165 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7166 Operate on live windows only.
7167
2949f33b
JB
71682011-09-08 Juanma Barranquero <lekktu@gmail.com>
7169
7170 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7171
e08dcafd
EZ
71722011-09-07 Eli Zaretskii <eliz@gnu.org>
7173
7174 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7175 only under bidi iteration.
7176
115b96bd
JD
71772011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7178
7179 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7180
c8199d0f
PE
71812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7182
7183 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7184 Without this fix, the command to link temacs failed due to an
7185 undefined symbol __builtin_isnan. This is because
7186 /usr/include/iso/math_c99.h #defines isnan(x) to
7187 __builtin_isnan(x), but the bundled gcc, which identifies itself
7188 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7189 a __builtin_isnan.
7190 * floatfns.c (isnan): #undef, and then #define to a clone of
7191 what's in data.c.
7192 (Fisnan): Always define, since it's always available now.
7193 (syms_of_floatfns): Always define isnan at the Lisp level.
7194
e39b275c 71952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7196
7197 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7198
b2db44d9 71992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7200
f4af5137 7201 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7202 The previous code assumed that file offsets (off_t values) fit in
7203 EMACS_INT variables, which is not true on typical 32-bit hosts.
7204 The code messed up by falsely reporting buffer overflow in cases
7205 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7206 when "big" contains more than 2**29 bytes, even though this
7207 inserts just one byte and does not overflow the buffer.
7208 (Finsert_file_contents): Store file offsets as off_t
7209 values, not as EMACS_INT values. Check for overflow when
7210 converting between EMACS_INT and off_t. When checking for
7211 buffer overflow or for overlap, take the offsets into account.
7212 Don't use EMACS_INT for small values where int suffices.
7213 When checking for overlap, fix a typo: ZV was used where
7214 ZV_BYTE was intended.
7215 (Fwrite_region): Don't assume off_t fits into 'long'.
7216 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7217
ecfc0a49
MA
72182011-09-05 Michael Albinus <michael.albinus@gmx.de>
7219
7220 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7221
6511acf2 72222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7223
0999621a 7224 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7225
7226 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7227 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7228 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7229 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7230 (modify_event_symbol): Do not assume that the length of
7231 name_alist_or_stem is safe to alloca and fits in int.
7232 (Fexecute_extended_command): Likewise for function name and binding.
7233 (Frecursion_depth): Wrap around reliably on integer overflow.
7234 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7235 since some callers pass EMACS_INT values.
7236 (Fsingle_key_description): Don't crash if symbol name contains more
7237 than MAX_ALLOCA bytes.
7238 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7239 (get_minibuffer): Arg is now EMACS_INT, not int.
7240 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7241 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7242 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7243
2be7d702
PE
7244 * dbusbind.c (signature_cat): New function.
7245 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7246 Do not overrun buffer; instead, report string overflow.
7247
9d1df220
PE
7248 * dispnew.c (add_window_display_history): Don't overrun buffer.
7249 Truncate instead; this is OK since it's just a log.
7250
33ef5c64
PE
7251 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7252 even if the time zone offset is outlandishly large.
7253 Don't mishandle offset == INT_MIN.
7254
66c6fdd5
PE
7255 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7256 when creating daemon; the previous buffer-overflow check was incorrect.
7257
d749b01b
PE
7258 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7259 which has the guts of the old verror function.
7260
b5cd1905
PE
7261 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7262 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7263
6e1a67fb
PE
7264 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7265 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7266 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7267 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7268 length of string rather than counting it via multiple sprintfs;
7269 that's simpler and more reliable.
c21721cc
PE
7270 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7271 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7272 sprintf, in case result does not fit in int.
7273
c57b67fc
PE
7274 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7275 (fontset_from_font): Print it.
7276
8a401434
PE
7277 * frame.c (tty_frame_count): Now printmax_t, not int.
7278 (make_terminal_frame, set_term_frame_name): Print it.
7279 (x_report_frame_params): In X, window IDs are unsigned long,
7280 not signed long, so print them as unsigned.
7281 (validate_x_resource_name): Check for implausibly long names,
7282 and don't assume name length fits in 'int'.
7283 (x_get_resource_string): Don't blindly alloca invocation name;
7284 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7285 not fit in int.
7286
6e1a67fb
PE
7287 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7288 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7289 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7290
0df02bf3
PE
7291 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7292 Use esprintf, not sprintf, in case result does not fit in int.
7293
48e30793
PE
7294 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7295 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7296 it as a large positive number.
7297 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7298 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7299
a66ff6d8
PE
7300 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7301 in case result does not fit in int.
7302
aca216ff
PE
7303 * print.c (float_to_string): Detect width overflow more reliably.
7304 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7305 buffer overrun. Don't assume list length fits in 'int'. Treat
7306 print length of 0 as 0, not as infinity; to be consistent with other
7307 uses of print length in this function. Don't overflow print length
7308 index. Don't assume hash table size fits in 'long', or that
7309 vectorlike size fits in 'unsigned long'.
7310
31c286f7
PE
7311 * process.c (make_process): Use printmax_t, not int, to format
7312 process-name gensyms.
7313
55e5faa1
PE
7314 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7315
80f2e268
PE
7316 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7317 to avoid potential buffer overrun.
7318
670741ab
PE
7319 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7320 if X resource line is longer than 512 bytes.
7321
b7163a50
PE
7322 * xfns.c (x_window): Make sprintf buffer a bit bigger
7323 to avoid potential buffer overrun.
7324
ae58ff1f
PE
7325 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7326
c43c8a6a
PE
7327 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7328
3f8236f4
PE
73292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7330
53e9fe90 7331 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7332 Without these, Emacs silently mishandles large integers sometimes.
7333 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7334 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7335
6511acf2
PE
7336 * xdisp.c (try_window_id): Check Emacs fixnum range before
7337 converting to 'int'.
806add1d 7338
6511acf2 7339 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7340 Check that an Emacs fixnum is in range before assigning it to 'int'.
7341 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7342 values converted from Emacs fixnums.
7343 (Frecenter): Don't wrap around a line count if it is out of 'int'
7344 range; instead, treat it as an extreme value.
7345 (Fset_window_configuration, compare_window_configurations):
7346 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7347
6511acf2
PE
7348 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7349 that can exceed INT_MAX. Check that EMACS_INT value is in range
7350 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7351 (match_limit): Don't assume that a fixnum can fit in 'int'.
7352
6511acf2 7353 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7354 exceed INT_MAX.
7355
6511acf2 7356 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7357 (Fvertical_motion): Don't wrap around LINES values that don't fit
7358 in 'int'. Instead, treat them as extreme values. This is good
7359 enough for windows, which can't have more than INT_MAX lines anyway.
7360
fcb901a7
LMI
73612011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7362
0f2f6b6d
LMI
7363 * Require libxml/parser.h to avoid compilation warning.
7364
fcb901a7
LMI
7365 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7366
7367 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7368 since this reportedly can destroy thread storage.
7369
6e20a0d4
CY
73702011-08-30 Chong Yidong <cyd@stupidchicken.com>
7371
7372 * syntax.c (find_defun_start): Update all cache variables if
7373 exiting early (Bug#9401).
7374
148ae00e
EZ
73752011-08-30 Eli Zaretskii <eliz@gnu.org>
7376
f6cfbd8f
EZ
7377 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7378
148ae00e
EZ
7379 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7380 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7381 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7382
7383 * term.c (tty_append_glyph): New function.
7384 (produce_stretch_glyph): Static function and its prototype deleted.
7385
a66cfb1c
SM
7386 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7387 Add prototypes.
148ae00e 7388
c4a07a4c
PE
73892011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7390
7391 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7392 when checking :margin (Bug#9390).
7393 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7394 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7395 so that the name doesn't mislead. All uses changed.
7396
6bc8cd65
JB
73972011-08-28 Johan Bockgård <bojohan@gnu.org>
7398
7399 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7400 set_tty_hooks.
7401
dca4927e
EZ
74022011-08-27 Eli Zaretskii <eliz@gnu.org>
7403
7404 * xdisp.c (move_it_to): Don't bail out early when reaching
7405 position beyond to_charpos, if we are scanning backwards.
7406 (move_it_vertically_backward): When DY == 0, make sure we get to
7407 the first character in the line after the newline.
7408
f2cad773
PE
74092011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7410
7411 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7412 (ccl_driver): Do not generate an out-of-range pointer.
7413 (Fccl_execute_on_string): Remove unnecessary check for
7414 integer overflow, noted by Stefan Monnier in
7415 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7416 Remove a FIXME that didn't need fixing.
7417 Simplify the newly-introduced buffer reallocation code.
7418
0cae2cdb
JB
74192011-08-27 Juanma Barranquero <lekktu@gmail.com>
7420
7421 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7422
5fc295a4 74232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7424
70c60eb2 7425 Integer and memory overflow issues (Bug#9196).
726e0ab1 7426
d31850da
PE
7427 * doc.c (get_doc_string): Rework so that
7428 get_doc_string_buffer_size is the actual buffer size, rather than
7429 being 1 less than the actual buffer size; this makes xpalloc more
7430 convenient.
7431
a69fbedb
PE
7432 * image.c (x_allocate_bitmap_record, cache_image):
7433 * xselect.c (Fx_register_dnd_atom):
7434 Simplify previous changes by using xpalloc.
7435
fe5c5d37
PE
7436 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7437 since either will do and ptrdiff_t is convenient with xpalloc.
7438
0065d054
PE
7439 * charset.c (charset_table_size)
7440 (struct charset_sort_data.priority): Now ptrdiff_t.
7441 (charset_compare): Don't overflow if priorities differ greatly.
7442 (Fsort_charsets): Don't assume list length fits in int.
7443 Check for size-calculation overflow when allocating sort data.
7444 (syms_of_charset): Allocate an initial charset table that is
7445 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7446
7447 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7448
7449 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7450 The actual value is always <= INT_MAX, and leaving it unsigned made
7451 overflow checking harder.
7452
7453 * dispextern.h (struct glyph_matrix.rows_allocated)
7454 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7455 with xpalloc. The values are still always <= INT_MAX.
7456
7457 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7458
7459 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7460 (SAFE_NALLOCA): New macro.
7461
7462 * region-cache.c (struct boundary.pos, find_cache_boundary)
7463 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7464 (set_cache_region, invalidate_region_cache)
7465 (revalidate_region_cache, know_region_cache, region_cache_forward)
7466 (region_cache_backward, pp_cache):
7467 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7468 so that ptrdiff_t * can be passed to xpalloc.
7469 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7470 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7471 (pp_cache): Don't assume cache_len fits in int.
7472 * region-cache.h: Adjust extern decls to match.
7473
7474 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7475 EMACS_INT, since either will do, for xpalloc.
7476
7477 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7478 (xnmalloc, xnrealloc, xpalloc): New functions.
7479
726e0ab1
PE
7480 * bidi.c (bidi_shelve_header_size): New constant.
7481 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7482 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7483
51f30bc5 7484 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7485 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7486 (overlay_strings):
7487 Don't update size of array until after memory allocation succeeds,
7488 because xmalloc/xrealloc may not return.
0065d054
PE
7489 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7490 now that we have proper integer overflow checking.
7491 (record_overlay_string, overlay_strings): Catch overflows when
7492 calculating size of overlay_str_buf.
726e0ab1 7493
0065d054
PE
7494 * callproc.c (Fcall_process): Check for size overflow when
7495 calculating size of args2.
7496 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7497 Normally we prefer signed values, but sticking with ptrdiff_t would
7498 require adding more-complicated checks.
726e0ab1
PE
7499
7500 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7501 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7502 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7503 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7504
7505 * character.c (Fstring): Check for size-calculation overflow.
7506
7507 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7508 unnecessary integer overflow. Check for size overflow.
7509 (encode_coding_object): Don't update size until xmalloc succeeds.
7510
7511 * composite.c (get_composition_id): Check for overflow in glyph
7512 length calculations.
7513
7514 Integer and memory overflow fixes for display code.
7515 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7516 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7517 (scrolling_window): Check for overflow in size calculations.
7518 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7519 Don't assume glyph table len fits in int.
7520 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7521 (row_table_size): Now ptrdiff_t, not int.
7522 (scrolling_window): Avoid overflow in size calculations.
7523 Don't update size until allocation succeeds.
7524 * fns.c (concat): Check for overflow in size calculations.
7525 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7526 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7527 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7528
7529 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7530 (get_doc_string): Check for size calculation overflow.
7531 Don't update size until allocation succeeds.
7532 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7533 EMACS_INT, where ptrdiff_t will do.
7534 (Fsubstitute_command_keys): Check for string overflow.
7535
7536 * editfns.c (set_time_zone_rule): Don't assume environment length
7537 fits in int.
7538 (message_length): Now ptrdiff_t, not int.
7539 (Fmessage_box): Don't update size until allocation succeeds.
7540 Don't assume message length fits in int.
7541 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7542
0065d054
PE
7543 * emacs.c (main): Do not reallocate argv, since there is a null at
7544 the end that can be overwritten, and this way there's no need to
7545 worry about size-calculation overflow.
7546 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7547
7548 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7549 alloc succeeds.
7550 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7551
7552 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7553 (x_set_scroll_bar_width, x_figure_window_size):
7554 Check for integer overflow.
7555 (x_set_alpha): Do not assume XINT fits in int.
7556
7557 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7558 This is for the members text_lines, text_cols, total_lines, total_cols,
7559 where the system imposes an 'int' limit.
7560
7561 * fringe.c (Fdefine_fringe_bitmap):
7562 Don't update size until alloc works.
7563
7564 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7565 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7566
7567 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7568 Check for size-calculation overflow.
7569 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7570 do, as we prefer signed integers.
7571 (id_to_widget.max_size, id_to_widget.used)
7572 (xg_store_widget_in_map, xg_remove_widget_from_map)
7573 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7574 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7575 Use and return ptrdiff_t, not int.
7576 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7577 * gtkutil.h: Change prototypes to match the above.
7578
7579 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7580 are duplicate now that they've been promoted to lisp.h.
7581 (x_allocate_bitmap_record, x_alloc_image_color)
7582 (make_image_cache, cache_image, xpm_load):
7583 Don't update size until alloc is done.
7584 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7585 (x_detect_edges):
3256efce 7586 Check for size calculation overflow.
726e0ab1
PE
7587 (ct_colors_allocated_max): New constant.
7588 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7589 overflow.
3256efce 7590
726e0ab1
PE
7591 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7592 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7593 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7594 Use ptrdiff_t, not int, to count maps.
7595 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7596 calculations. Don't update size until allocation succeeds.
7597 Redo calculations to avoid overflow.
726e0ab1
PE
7598 * keyboard.h: Change prototypes to match the above.
7599
7600 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7601 to count maps.
7602 (current_minor_maps): Check for size calculation overflow.
7603 * keymap.h: Change prototypes to match the above.
7604
7605 * lread.c (read1, init_obarray): Don't update size until alloc done.
7606
7607 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7608 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7609
726e0ab1
PE
7610 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7611 Now ptrdiff_t, not int.
7612 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7613 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7614
7615 * process.c (Fnetwork_interface_list): Check for overflow
7616 in size calculation.
7617
7618 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7619
7620 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7621 overflow. Don't bother calling xmalloc when xrealloc will do.
7622
7623 * search.c (Freplace_match): Check for size calculation overflow.
7624 (Fset_match_data): Don't assume list lengths fit in 'int'.
7625
7626 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7627 for command line length. Do not attempt to address one before the
7628 beginning of an array, as that's not portable.
7629
7630 * term.c (max_frame_lines): Remove; unused.
7631 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7632 not int.
7633 (encode_terminal_code, calculate_costs): Check for size
7634 calculation overflow.
7635 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7636 table lengths and related sizes. Don't update size until alloc
7637 done. Redo calculations to avoid overflow.
7638 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7639
7640 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7641 subtracting pointers.
7642 (gobble_line): Check for overflow more carefully. Don't update size
7643 until alloc done.
7644
7645 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7646 Don't update size until alloc done.
7647 Redo size calculations to avoid overflow.
7648 Check for size calculation overflow.
0065d054 7649 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7650
7651 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7652 Use ptrdiff_t, not int, for sizes.
7653 (store_mode_line_noprop_char): Don't update size until alloc done.
7654
0065d054
PE
7655 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7656 Use ptrdiff_t, not int, for sizes.
7657 (Finternal_make_lisp_face, cache_face):
7658 Check for size calculation overflow.
7659 (cache_face): Treat size calculation overflows as if they were
7660 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7661
7662 * xfns.c (x_encode_text, x_set_name_internal)
7663 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7664 sizes, since they can exceed INT_MAX in size. Check for size
7665 calculation overflow.
7666
0065d054
PE
7667 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7668 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7669 Don't update size until alloc done.
7670
0065d054 7671 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7672 as sprintf is limited to int lengths.
1d526e2f 7673
252c5ee1
PE
7674 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7675 (X_LONG_MIN): New macros.
864d7ce7
PE
7676 Use them to make the following changes clearer.
7677 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7678 This change doesn't affect the value now, but it may help remind
7679 future maintainers not to raise the value too much later.
7680 (SELECTION_QUANTUM): Remove, replacing with ...
7681 (selection_quantum): ... new function, which avoids overflow.
7682 All uses changed.
7683 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7684 assumption that selection length fits in 'int'.
7685 (x_reply_selection_request, x_handle_selection_request)
7686 (x_get_window_property, receive_incremental_selection)
7687 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7688 (lisp_data_to_selection_data, clean_local_selection_data):
7689 Use ptrdiff_t, not int, to record length of selection.
7690 (x_reply_selection_request, x_get_window_property)
7691 (receive_incremental_selection, x_property_data_to_lisp):
7692 Redo calculations to avoid overflow.
7693 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7694 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7695 something.
7696 (x_get_window_property, receive_incremental_selection)
7697 (lisp_data_to_selection_data, x_property_data_to_lisp):
7698 Check for size-calculation overflow.
7699 (x_get_window_property, receive_incremental_selection)
7700 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7701 Don't store size until memory allocation succeeds.
7702 (x_get_window_property): Plug memory leak on memory exhaustion.
7703 Don't double-block input; malloc is safe here. Don't assume 2**34
7704 - 4 fits in unsigned long. Add an xassert to check
7705 XGetWindowProperty overflow. Be more careful about overflow
7706 calculations, and distinguish size from memory overflow better.
7707 (receive_incremental_selection): When tracing, don't assume
7708 unsigned int is less than INT_MAX.
7709 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7710 harmful) conversions of unsigned short to int.
7711 (lisp_data_to_selection_data): Don't assume that integers
7712 in the range -65535 through -1 fit in an X unsigned short.
7713 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7714 result parameters unless successful. Rely on cons_to_unsigned
7715 to report problems with elements; the old code wasn't right anyway.
7716 (x_check_property_data): Check for int overflow; we cannot use
7717 a wider type due to X limits.
7718 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7719
726e0ab1 7720 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7721
0065d054
PE
7722 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7723 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7724 (x_color_cells): Don't store size until memory allocation succeeds.
7725 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7726 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7727 (x_term_init): Don't assume length fits in int (sprintf is limited
7728 to int size).
bc18e09d 7729
ebfa62c0
PE
7730 Use ptrdiff_t for composition IDs.
7731 * character.c (lisp_string_width):
7732 * composite.c (composition_table_size, n_compositions)
7733 (get_composition_id, composition_gstring_from_id):
7734 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7735 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7736 * window.c (Frecenter):
7737 Use ptrdiff_t, not int, for composition IDs.
7738 * composite.c (get_composition_id): Check for integer overflow.
7739 * composite.h: Adjust prototypes to match the above changes.
7740
d3411f89
PE
7741 Use ptrdiff_t for hash table indexes.
7742 * category.c (hash_get_category_set):
7743 * ccl.c (ccl_driver):
7744 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7745 * coding.c (coding_system_charset_list, detect_coding_system):
7746 * coding.h (struct coding_system.id):
7747 * composite.c (get_composition_id, gstring_lookup_cache):
7748 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7749 * image.c (xpm_get_color_table_h):
7750 * lisp.h (hash_lookup, hash_put):
7751 * minibuf.c (Ftest_completion):
7752 Use ptrdiff_t for hash table indexes, not int (which is too
7753 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7754 32-bit --with-wide-int hosts).
7755
e097a6fa
PE
7756 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7757 Add a FIXME comment about memory leaks.
7758 (syms_of_charset): Don't assume xmalloc returns.
7759
5637687f
PE
7760 Don't assume that stated character widths fit in int.
7761 * character.c (Fchar_width, c_string_width, lisp_string_width):
7762 * character.h (CHAR_WIDTH):
7763 * indent.c (MULTIBYTE_BYTES_WIDTH):
7764 Use sanitize_char_width to avoid undefined and/or bad behavior
7765 with outlandish widths.
a66cfb1c 7766 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7767 now that we have two such functions. All uses changed.
7768 (sanitize_char_width): New inline function.
7769
a2271ba2
PE
7770 Don't assume that tab-width fits in int.
7771 * character.h (sanitize_width): New inline function.
7772 (SANE_TAB_WIDTH): New macro.
7773 (ASCII_CHAR_WIDTH): Use it.
7774 * indent.c (sane_tab_width): Remove. All uses replaced by
7775 SANE_TAB_WIDTH (current_buffer).
7776 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7777
18c52557
PE
7778 * fileio.c: Integer overflow issues with file modes.
7779 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7780
caeeedc1
PE
7781 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7782 Remove unreachable code.
7783 (read_hex, load_charset_map_from_file): Check for integer overflow.
7784
6df6ae42 7785 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7786 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7787 (x_send_scroll_bar_event): Likewise. Check that the size does not
7788 exceed limits imposed by XClientMessageEvent, as well as the usual
7789 ptrdiff_t and size_t limits.
7790
b13995db
PE
7791 * keyboard.c: Overflow, signedness and related fixes.
7792 (make_lispy_movement): Use same integer type in forward decl
7793 that is used in the definition.
7794 (read_key_sequence, keyremap_step):
7795 Change bufsize argument back to int, undoing my 2011-03-30 change.
7796 We prefer signed types, and int is wide enough here.
7797 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7798 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7799 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7800 length, not size_t. Use ptrdiff_t for index, not int.
7801 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7802 possibility of integer overflow.
7803
13464394
PE
7804 Overflow, signedness and related fixes for images.
7805
7806 * dispextern.h (struct it.stack[0].u.image.image_id)
7807 (struct_it.image_id, struct image.id, struct image_cache.size)
7808 (struct image_cache.used, struct image_cache.ref_count):
7809 * gtkutil.c (update_frame_tool_bar):
7810 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7811 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7812 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7813 * nsmenu.m (update_frame_tool_bar):
7814 * xdisp.c (calc_pixel_width_or_height):
7815 * xfns.c (image_cache_refcount):
7816 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7817 on typical 64-bit hosts.
7818
7819 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7820 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7821 Omit unnecessary casts to int.
7822 (parse_image_spec): Check that integers fall into 'int' range
7823 when the callers expect that.
7824 (image_ascent): Redo ascent calculation to avoid int overflow.
7825 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7826 (lookup_image): Remove unnecessary tests.
7827 (xbm_image_p): Locals are now of int, not EMACS_INT,
7828 since parse_image_check makes sure they fit into int.
7829 (png_load, gif_load, svg_load_image):
7830 Prefer int to unsigned where either will do.
7831 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7832 old tiff_error_handler and tiff_warning_handler.
7833 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7834 stack buffer overflows. It uses only the features of vsnprintf
7835 that are common to both POSIX and native Microsoft.
7836 (tiff_error_handler, tiff_warning_handler): Use it.
7837 (tiff_load, gif_load, imagemagick_load_image):
7838 Don't assume :index value fits in 'int'.
7839 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7840 (imagemagick_load_image): Check that crop parameters fit into
7841 the integer types that MagickCropImage accepts. Don't assume
7842 Vimagemagick_render_type has a nonnegative value. Don't assume
7843 size_t fits in 'long'.
7844 (gs_load): Use printmax_t to print the widest integers possible.
7845 Check for integer overflow when computing image height and width.
7846
c11821d4
EZ
78472011-08-26 Eli Zaretskii <eliz@gnu.org>
7848
7849 * xdisp.c (redisplay_window): Don't force window start if point
7850 will be invisible in the resulting window. (Bug#9324)
7851
0c95fcf7
EZ
78522011-08-25 Eli Zaretskii <eliz@gnu.org>
7853
7854 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7855 the display spec is of the form `(space ...)'.
7856 (handle_display_spec): Return the value returned by
7857 handle_single_display_spec, not just 1 or zero.
7858 (handle_single_display_spec): If the display spec is of the form
7859 `(space ...)', and specifies display in the text area, return 2
7860 rather than 1.
fee65a97 7861 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7862 accurately, and prefer exact match for point under bidi.
7863 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7864
7865 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7866 into disp_prop; all users changed.
7867
7868 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7869 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7870 for the text covered by the display property.
7871
e4ed06f1
CY
78722011-08-25 Chong Yidong <cyd@stupidchicken.com>
7873
7874 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7875 Change return value to nil.
7876 (Frecord_buffer): Delete unused function.
7877
f67cdd7f
EZ
78782011-08-24 Eli Zaretskii <eliz@gnu.org>
7879
5980d4c6
EZ
7880 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7881 buffers, return left-to-right.
8610fe8b
EZ
7882 (set_cursor_from_row): Consider candidate row a win if its glyph
7883 represents a newline and point is on that newline. Fixes cursor
7884 positioning on the newline at EOL of R2L text within L2R
7885 paragraph, and vice versa.
7886 (try_cursor_movement): Check continued rows, in addition to
7887 continuation rows. Fixes unwarranted scroll when point enters a
7888 continued line of R2L text within an L2R paragraph, or vice versa.
7889 (cursor_row_p): Consider the case of point being equal to
7890 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7891 from the end of a short line to the beginning of a continued line
7892 of R2L text within L2R paragraph.
7893 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7894 composed characters.
5980d4c6 7895
f67cdd7f
EZ
7896 * bidi.c (bidi_check_type): Use xassert.
7897 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7898 members.
7899
bca633fb
EZ
79002011-08-23 Eli Zaretskii <eliz@gnu.org>
7901
7902 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7903 a character.
7904
4a5885a7
CY
79052011-08-23 Chong Yidong <cyd@stupidchicken.com>
7906
7907 * nsfont.m (ns_otf_to_script): Fix typo.
7908
0902a04e
KH
79092011-08-22 Kenichi Handa <handa@m17n.org>
7910
7911 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7912 extra slot even if the purpose is char-code-property-table.
7913
1a2e6670
EZ
79142011-08-23 Eli Zaretskii <eliz@gnu.org>
7915
8ddde651
EZ
7916 * xdisp.c (redisplay_window): When computing centering_position,
7917 account for the height of the header line. (Bug#8874)
7918
425cc014
EZ
7919 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7920 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7921 candidate is selected by the mouse, and that candidate has a
7922 composed character under the mouse.
7923
1a2e6670
EZ
7924 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7925 coordinates reported by pos-visible-in-window-p for a composed
7926 character in column zero.
7927
8b76d6f8
SM
79282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7929
7930 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7931
dac347dd
EZ
79322011-08-22 Eli Zaretskii <eliz@gnu.org>
7933
7934 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7935 consider it a hit if to_charpos is anywhere in the range of the
7936 composed buffer positions.
7937
e013fb34
CY
79382011-08-22 Chong Yidong <cyd@stupidchicken.com>
7939
7940 * image.c (gif_load): Don't assume that each subimage has the same
7941 dimensions as the base image. Handle disposal method that is
7942 "undefined" by the gif spec (Bug#9335).
7943
bd1ba3e8
CY
79442011-08-20 Chong Yidong <cyd@stupidchicken.com>
7945
7946 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7947 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7948
54a1215b
EZ
79492011-08-19 Eli Zaretskii <eliz@gnu.org>
7950
823564e5
EZ
7951 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7952 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7953 from an Org mode buffer to a Speedbar frame.
7954
54a1215b
EZ
7955 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7956 a composition, take its buffer position from IT->cmp_it.charpos.
7957 Fixes cursor positioning at the beginning of a line that begins
7958 with a composed character.
7959
9778ebcc
EZ
79602011-08-18 Eli Zaretskii <eliz@gnu.org>
7961
0be6ee06
EZ
7962 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7963 character bidirectional type, use STRONG_L instead. Fixes crashes
7964 in a buffer produced by `describe-categories'.
7965
9778ebcc
EZ
7966 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7967 members before the level stack, so they would be saved and
7968 restored when copying iterator state. Fixes incorrect reordering
7969 around TABs covered by display properties.
7970
156bffbe
AS
79712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7972
6b02f655 7973 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7974
72ad093b
CY
79752011-08-17 Chong Yidong <cyd@stupidchicken.com>
7976
7977 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7978 (internal_condition_case_2, internal_condition_case_n):
7979 Remove unnecessary aborts (Bug#9081).
72ad093b 7980
35774242
EZ
79812011-08-17 Eli Zaretskii <eliz@gnu.org>
7982
7983 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7984 has no `load' handler, try opening the file locally. (Bug#9311)
7985
db76dd85
KB
79862011-08-16 Ken Brown <kbrown@cornell.edu>
7987
7988 * gmalloc.c: Expand comment.
7989
b215eee5
EZ
79902011-08-16 Eli Zaretskii <eliz@gnu.org>
7991
7992 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7993 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7994
a4579d33
KB
79952011-08-16 Ken Brown <kbrown@cornell.edu>
7996
7997 Fix memory allocation problems in Cygwin build (Bug#9273).
7998
7999 * unexcw.c ( __malloc_initialized): Declare external variable.
8000 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8001
8b76d6f8
SM
8002 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8003 New variables.
a4579d33
KB
8004 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8005 dumped emacs.
8006 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8007 in the static heap.
8008 [CYGWIN] (special_realloc): New function.
8009 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8010 requests to realloc storage in the static heap.
8011
3ebec551
PE
80122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8013
8014 * bidi.c (bidi_initialize): Remove unused local.
8015
9fd8be00
EZ
80162011-08-15 Eli Zaretskii <eliz@gnu.org>
8017
6b02f655
SM
8018 * bidimirror.h:
8019 * biditype.h: Remove file.
8020 * makefile.w32-in ($(BLD)/bidi.$(O)):
8021 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8022
8023 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8024
8025 * chartab.c: Improve commentary for the uniprop_table API.
8026
32413314
EZ
8027 * bidi.c (bidi_paragraph_init): Support zero value of
8028 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8029 (bidi_initialize): Use uniprop_table instead of including
8030 biditype.h and bidimirror.h.
32413314 8031
9fd8be00
EZ
8032 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8033 coordinates of the iterator when restoring from ppos_it.
8034 (Bug#9296)
8035
5cf2b69b
KH
80362011-08-14 Kenichi Handa <handa@m17n.org>
8037
8038 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8039 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8040
daf17d00
EZ
80412011-08-14 Eli Zaretskii <eliz@gnu.org>
8042
8043 * xdisp.c (move_it_in_display_line_to): Don't invoke
8044 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8045 ppos_it. Fixes vertical cursor motion when line beginning is
8046 covered by an image. (Bug#9296)
8047
08e3161a
JD
80482011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8049
8050 * nsterm.h (ns_run_ascript): Declare.
8051 (NSAPP_DATA2_RUNASSCRIPT): Define.
8052
8053 * nsfns.m (as_script, as_result, as_status): New static variables.
8054 (ns_run_ascript): New function.
5e617bc2 8055 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8056 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8057 the event loop. Get status from as_status (Bug#7276).
8058
8059 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8060 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8061 the event loop (Bug#7276).
8062
a3720aa2
AS
80632011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8064
8065 * gnutls.c (QCgnutls_bootprop_priority)
8066 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8067 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8068 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8069 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8070 (QCgnutls_bootprop_verify_hostname_error)
8071 (QCgnutls_bootprop_callbacks_verify): Rename from
8072 Qgnutls_bootprop_..., all uses changed.
8073
8074 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8075 uses changed.
8076
0a0d27fb
PE
80772011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8078
19d5c50c
PE
8079 * xfaces.c (Qframe_set_background_mode): Now static.
8080 * dispextern.h (Qframe_set_background_mode): Remove decl.
8081
0a0d27fb
PE
8082 * process.c (Fnetwork_interface_info): Declare local only if needed.
8083
377538cb
JD
80842011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8085
8086 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8087 (Fnetwork_interface_list): Allocate in increments of bytes instead
8088 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8089 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8090 sockaddr.
8091 (struct ifflag_def): notrailers is smart on OSX.
8092 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8093 Get hardware address with getifaddrs if available.
8094
08fff70c
EZ
80952011-08-12 Eli Zaretskii <eliz@gnu.org>
8096
8097 * xdisp.c (iterate_out_of_display_property): xassert that
8098 IT->position is set to within IT->object's boundaries. Break from
8099 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8100 when IT->position is set up wrongly due to some bug.
8101 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8102 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8103 entry. Force push_it to save on the stack the current
8104 buffer/string position, to be restored by pop_it. Fix flags in
8105 the iterator structure wrt the object coming from a display
8106 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8107 properties. (Bug#9284)
8108
7be1c708 81092011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8110
7be1c708
CY
8111 * fontset.c (fontset_get_font_group): Add proper type checks.
8112 (Bug#9172)
aac0c6e3 8113
7be1c708 81142011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8115
7be1c708
CY
8116 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8117 and LC_VERSION_MIN_MACOSX.
8118 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8119 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8120
97bb72a6
EZ
81212011-08-08 Eli Zaretskii <eliz@gnu.org>
8122
8123 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8124 no-display-properties-and-no-overlays under bidi display.
8125 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8126 properties and overlays.
97bb72a6 8127
d5617611
CY
81282011-08-08 Chong Yidong <cyd@stupidchicken.com>
8129
37e11a63
CY
8130 * editfns.c (Fset_time_zone_rule): Document relationship with the
8131 setenv function.
8132
d5617611
CY
8133 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8134 the font entity extracted from the cache (Bug#8109).
8135
58872834
CY
81362011-08-07 Chong Yidong <cyd@stupidchicken.com>
8137
8138 * composite.c (autocmp_chars): Don't reset point. That is done by
8139 restore_point_unwind (Bug#5984).
8140
75bfc667
JL
81412011-08-07 Juri Linkov <juri@jurta.org>
8142
8143 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8144 to show the arg `TIME' instead of `TIMEVAL'.
8145
d1410150
EZ
81462011-08-06 Eli Zaretskii <eliz@gnu.org>
8147
8148 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8149 display property strides EOL and includes a newline, as in
8150 longlines-mode. (Bug#9254)
75b771e4
EZ
8151 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8152 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8153
8154 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8155 is non-zero, even if the data buffer is NULL. Fixes a crash in
8156 vertical-motion with longlines-mode. (Bug#9254)
8157
35928349
EZ
81582011-08-05 Eli Zaretskii <eliz@gnu.org>
8159
ec7cc85b
EZ
8160 * bidi.c <bidi_cache_total_alloc>: Now static.
8161 (bidi_initialize): Initialize bidi_cache_total_alloc.
8162
8b76d6f8 8163 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8164 cache. (Bug#9221)
8165
8166 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8167 amount allocated this far in `bidi_cache_total_alloc'.
8168 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8169 non-zero, only free the data buffer without restoring the cache
8170 contents. All callers changed.
8171
8172 * dispextern.h (bidi_unshelve_cache): Update prototype.
8173
8174 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8175 (move_it_in_display_line, move_it_to)
8176 (move_it_vertically_backward, move_it_by_lines): Replace the call
8177 to xfree to an equivalent call to bidi_unshelve_cache.
8178 (move_it_in_display_line_to): Fix logic of returning
412b6358 8179 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8180
e2e2423b
EZ
81812011-08-05 Eli Zaretskii <eliz@gnu.org>
8182
8183 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8184 came from a string character with a `cursor' property. (Bug#9229)
8185
ae9e757a
JD
81862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8187
8188 * Makefile.in (LIB_PTHREAD): New variable.
8189 (LIBES): Add LIB_PTHREAD (Bug#9216).
8190
8191 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8192 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8193
213bd7f2
AS
81942011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8195
6b02f655 8196 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8197
99aaf75f
JD
81982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8199
8200 * xterm.c (x_find_topmost_parent): New function.
8201 (x_set_frame_alpha): Find topmost parent window with
8202 x_find_topmost_parent and set the property there also (bug#9181).
8203 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8204
c74e9d86
PE
82052011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8206
8207 * callproc.c (Fcall_process): Avoid vfork clobbering
8208 the local vars buffer, coding_systems, current_dir.
8209
640c8776
SM
82102011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8211
8212 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8213
f26d0e4c
PE
82142011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8215
8a10d76c
PE
8216 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8217 so that it is not optimized away.
8218
f26d0e4c
PE
8219 * xdisp.c (compute_display_string_pos): Remove unused local.
8220
55439c61
EZ
82212011-08-02 Eli Zaretskii <eliz@gnu.org>
8222
8223 Fix slow cursor motion and scrolling in large buffers with
8224 selective display, like Org Mode buffers. (Bug#9218)
8225
8226 * dispextern.h (struct bidi_it): New member disp_prop_p.
8227
8228 * xdisp.c: Remove one-slot cache of display string positions.
8229 (compute_display_string_pos): Accept an additional argument
5e617bc2 8230 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8231 for a display string or property. If found, set DISP_PROP_P
8232 non-zero.
8233
8234 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8235 DISP_PROP_P, and pass it to compute_display_string_pos.
8236 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8237 non-zero. All callers of bidi_fetch_char changed.
8238
fb33fa43
SM
82392011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8240
8241 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8242
b099e063
DM
82432010-12-03 Don March <don@ohspite.net>
8244
8245 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8246 last character M-[char] is translated to ESC [char] (bug#7541).
8247
5cc7f7af
KH
82482011-08-02 Kenichi Handa <handa@m17n.org>
8249
d0fffa3f 8250 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8251
8252 * chartab.c (uniprop_table): Make it non-static.
8253
525d5e6e
EZ
82542011-08-01 Eli Zaretskii <eliz@gnu.org>
8255
8256 * xdisp.c (forward_to_next_line_start): Accept additional argument
8257 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8258 on the newline.
8259 (reseat_at_next_visible_line_start): Use the bidi iterator state
8260 returned by forward_to_next_line_start to restore the state of
8261 it->bidi_it after backing up to previous newline. (Bug#9212)
8262
31011111
AS
82632011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8264
8265 * regex.c (re_comp): Protoize.
8266 (re_exec): Fix return type.
8267 (regexec): Fix type of `ret'. (Bug#9203)
8268
476371c4
PE
82692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8270
e5d76069
PE
8271 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8272 This is needed if max-image-size is a floating-point number.
8273
9a79b20c
AS
82742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8275
8276 * print.c (print_object): Print empty symbol as ##.
8277
8278 * lread.c (read1): Read ## as empty symbol.
8279
d8c2fa78
AA
82802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8281
8282 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8283 setting frame foreground color (Bug#9175).
8284 (x_set_background_color): Likewise.
8285
ffe57a7a
AA
8286 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8287 contents (Bug#9176).
8288 (EmacsTooltip -init): Remove bezels and add shadows to
8289 tooltip windows.
8290
bf3492a5
AA
8291 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8292 or scroll bar (Bug#8470).
8293
d55e9c53
AA
8294 * nsfont.m (nsfont_open): Remove assignment to voffset and
8295 unnecessary vars hshink, expand, hd, full_height, min_height.
8296 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8297
8298 * nsterm.h (nsfont_info): Remove voffset field.
8299
d8c2fa78 83002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8301
8302 Implement strike-through and overline on NextStep (Bug#8863).
8303
8304 * nsfont.m (nsfont_open): Use underline position provided by font,
8305 instead of hard-coded value of 2.
8306 (nsfont_draw): Call ns_draw_text_decoration instead.
8307
8308 * nsterm.h: Add declaration for ns_draw_text_decoration.
8309
8310 * nsterm.m (ns_draw_text_decoration): New function for drawing
8311 underline, overline, and strike-through.
8312 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8313 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8314 accommodate underlining, etc.
4843aac3 8315
4cc60b9b
EZ
83162011-07-28 Eli Zaretskii <eliz@gnu.org>
8317
bc7ece87
EZ
8318 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8319 default.
4cc60b9b 8320
476371c4
PE
83212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8322
66606eea
PE
8323 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8324 Without this fix, if a signal arrives just after memory fills up,
8325 'malloc' might be invoked reentrantly.
8326
476371c4
PE
8327 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8328 In other words, assume that every image size is allowed, on non-X
8329 hosts. This assumption is probably wrong, but it lets Emacs compile.
8330
f3fcc40d
AS
83312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8332
8333 * regex.c (re_iswctype): Convert return values to boolean.
8334
350c992f
EZ
83352011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8336
8337 * xdisp.c (compute_display_string_pos): Don't use cached display
8338 string position if the buffer had its restriction changed.
8339 (Bug#9184)
8340
5266b4bb
PE
83412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8342
8343 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8344
2573a837 83452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8346
41f55ccd 8347 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8348
39e378da
PE
8349 * bidi.c: Integer size and overflow fixes.
8350 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8351 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8352 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8353 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8354 (bidi_find_other_level_edge):
8355 Use ptrdiff_t instead of EMACS_INT where either will do.
8356 This works better on 32-bit hosts configured --with-wide-int.
8357 (bidi_cache_ensure_space): Check for size-calculation overflow.
8358 Use % rather than repeated addition, for better worst-case speed.
8359 Don't set bidi_cache_size until after xrealloc returns, because it
8360 might not return.
8361 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8362 (bidi_cache_ensure_space): Also check that the bidi cache size
8363 does not exceed that of the largest Lisp string or buffer. See Eli
8364 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8365
5e927815
PE
8366 * alloc.c (__malloc_size_t): Remove.
8367 All uses replaced by size_t. See Andreas Schwab's note
8368 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8369
ca4aa935
PE
8370 * image.c: Improve checking for integer overflow.
8371 (check_image_size): Assume that f is nonnull, since
8372 it is always nonnull in practice. This is one less thing to
8373 worry about when checking for integer overflow later.
8374 (x_check_image_size): New function, which checks for integer
8375 overflow issues inside X.
8376 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8377 This removes the need for a memory_full check.
8378 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8379 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8380 (xbm_read_bitmap_data): Change locals back to 'int', since
8381 their values must fit in 'int'.
8382 (xpm_load_image, png_load, tiff_load):
8383 Invoke x_create_x_image_and_pixmap earlier,
8384 to avoid much needless work if the image is too large.
8385 (tiff_load): Treat overly large images as if
8386 x_create_x_image_and_pixmap failed, not as malloc failures.
8387 (gs_load): Use x_check_image_size.
8388
5f8f9cc2
PE
8389 * gtkutil.c: Omit integer casts.
8390 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8391 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8392
5adf60bc
PE
8393 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8394
c8907a93
PE
8395 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8396 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8397 would wrongly return t on a 64-bit host.
8398
e3c25c68
PE
8399 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8400 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8401 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8402 and therefore cause GCC to emit a bogus diagnostic in some cases.
8403
3f791afe
PE
8404 * image.c: Integer signedness and overflow and related fixes.
8405 This is not an exhaustive set of fixes, but it's time to
8406 record what I've got.
8407 (lookup_pixel_color, check_image_size): Remove redundant decls.
8408 (check_image_size): Don't assume that arbitrary EMACS_INT values
8409 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8410 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8411 (tiff_load, imagemagick_load_image):
8412 Check for overflow in size calculations.
8413 (x_create_x_image_and_pixmap): Remove unnecessary test for
8414 xmalloc returning NULL; that can't happen.
8415 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8416 (xpm_color_bucket): Use better integer hashing function.
8417 (xpm_cache_color): Don't possibly over-allocate memory.
8418 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8419 (gif_memory_source):
8420 Use ptrdiff_t, not int or size_t, to record sizes.
8421 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8422 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8423 either works, as we prefer signed integers.
8424 (tiff_read_from_memory, tiff_write_from_memory):
8425 Return tsize_t, not size_t, since that's what the TIFF API wants.
8426 (tiff_read_from_memory): Don't fail simply because the read would
8427 go past EOF; instead, return a short read.
8428 (tiff_load): Omit no-longer-needed casts.
8429 (Fimagemagick_types): Don't assume size fits into 'int'.
8430
3cc5a532
PE
8431 Improve hashing quality when configured --with-wide-int.
8432 * fns.c (hash_string): New function, taken from sxhash_string.
8433 Do not discard information about ASCII character case; this
8434 discarding is no longer needed.
8435 (sxhash-string): Use it. Change sig to match it. Caller changed.
8436 * lisp.h: Declare it.
8437 * lread.c (hash_string): Remove, since we now use fns.c's version.
8438 The fns.c version returns a wider integer if --with-wide-int is
8439 specified, so this should help the quality of the hashing a bit.
8440
b312a492
PE
8441 * emacs.c: Integer overflow minor fix.
8442 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8443 Define only if GNU_LINUX.
8444 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8445
dfd153ae
PE
8446 * dispnew.c: Integer signedness and overflow fixes.
8447 Remove unnecessary forward decls, that were a maintenance hassle.
8448 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8449 All uses changed.
8450 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8451 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8452 (prepare_desired_row, line_draw_cost):
8453 Use int, not unsigned, where either works.
8454 (save_current_matrix, restore_current_matrix):
8455 Use ptrdiff_t, not size_t, where either works.
8456 (init_display): Check for overflow more accurately, and without
8457 relying on undefined behavior.
8458
a81d11a3
PE
8459 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8460 Remove, replacing with the new symbols in lisp.h. All uses changed.
8461 * fileio.c (make_temp_name):
8462 * filelock.c (lock_file_1, lock_file):
8463 * xdisp.c (message_dolog):
8464 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8465 Use pMd etc. instead.
8466 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8467 replacing the pWIDE etc. symbols removed from editfns.c.
8468
3300e6fd
PE
8469 * keyboard.h (num_input_events): Now uintmax_t.
8470 This is (very slightly) less likely to mess up due to wraparound.
8471 All uses changed.
8472
fd05c7e9
PE
8473 * buffer.c: Integer signedness fixes.
8474 (alloc_buffer_text, enlarge_buffer_text):
8475 Use ptrdiff_t rather than size_t when either will do, as we prefer
8476 signed integers.
8477
903fe15d
PE
8478 * alloc.c: Integer signedness and overflow fixes.
8479 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8480 (__malloc_size_t): Default to size_t, not to int.
8481 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8482 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8483 Prefer ptrdiff_t to size_t when either would do, as we prefer
8484 signed integers.
8485 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8486 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8487 Now const. Initialize with values that are in range even if char
8488 is signed.
8489 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8490 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8491 These functions do the right thing with sizes > 2**32.
8492 (check_depth): Now ptrdiff_t, not int.
8493 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8494 Adjust to new way of storing sizes. Check for size overflow bugs
8495 in rest of code.
8496 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8497 slightly wrong anyway, as it missed one instance of
8498 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8499 (refill_memory_reserve): Omit needless cast to size_t.
8500 (mark_object_loop_halt): Mark as externally visible.
8501
ac82cc6a
PE
8502 * xselect.c: Integer signedness and overflow fixes.
8503 (Fx_register_dnd_atom, x_handle_dnd_message):
8504 Use ptrdiff_t, not size_t, since we prefer signed.
8505 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8506 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8507 x_dnd_atoms_size and x_dnd_atoms_length.
8508
c2d1e36d
PE
8509 * doprnt.c: Prefer signed to unsigned when either works.
8510 * eval.c (verror):
8511 * doprnt.c (doprnt):
8512 * lisp.h (doprnt):
8513 * xdisp.c (vmessage):
8514 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8515 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8516 prefer signed arithmetic to avoid comparison confusion.
8517 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8518 but is a bit tricky.
8519
0e926e56
PE
8520 Assume freestanding C89 headers, string.h, stdlib.h.
8521 * data.c, doprnt.c, floatfns.c, print.c:
8522 Include float.h unconditionally.
8523 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8524 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8525 * regex.c: Likewise for stddef.h, string.h.
8526 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8527 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8528 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8529 (STDC_HEADERS): Remove obsolete defines.
8530 * sysdep.c: Include limits.h unconditionally.
8531
9cfdb3ec
PE
8532 Assume support for memcmp, memcpy, memmove, memset.
8533 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8534 * regex.c (memcmp, memcpy):
8535 Remove; we assume C89 now.
8536
8537 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8538 (__malloc_safe_bcopy): Remove; no longer needed.
8539
cf950e6b 8540 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8541 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8542 well either way, and we prefer signed to unsigned.
8543
dbf38e02
LMI
85442011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8545
8546 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8547 closes the connection while we're reading (bug#9182).
8548
d6f0886c 85492011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8550
d6f0886c
JD
8551 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8552 are specified (Bug#9168).
24e0f6b1 8553
2eb1f9e6
PE
85542011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8555
8556 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8557 Found by GCC static checking and --with-wide-int on a 32-bit host.
8558
22381272 85592011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8560
8561 * xdisp.c (compute_display_string_pos): Fix logic of caching
8562 previous display string position. Initialize cached_prev_pos to
8563 -1. Fixes slow-down at the beginning of a buffer.
8564
f25e39b4
EZ
85652011-07-24 Eli Zaretskii <eliz@gnu.org>
8566
8567 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8568 for attrs[LFACE_FONTSET_INDEX].
8569
04c4b52e
PE
85702011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8571
8572 * xml.c (parse_region): Remove unused local
8573 that was recently introduced.
8574
c1734fbd
EZ
85752011-07-23 Eli Zaretskii <eliz@gnu.org>
8576
be18c5a5
EZ
8577 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8578 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8579
c1734fbd
EZ
8580 * xdisp.c (move_it_in_display_line_to): Record the best matching
8581 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8582 exit if none of the characters scanned was an exact match.
8583 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8584 when exact match is impossible due to invisible text, and the
8585 lines are truncated.
8586
a258d627
JD
85872011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8588
8589 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8590 for OSX >= 10.7.
8591
b6d5a689
EZ
85922011-07-22 Eli Zaretskii <eliz@gnu.org>
8593
0f74f785
EZ
8594 Fix a significant slow-down of cursor motion with C-n, C-p,
8595 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8596 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8597 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8598 (next_element_from_buffer): Call compute_stop_pos_backwards to
8599 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8600 base_level_stop.
8601 (reseat): Don't look for prev_stop, as that could mean a very long
8602 run.
8603 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8604 <cached_disp_overlay_modiff>: Cache for last found display string
8605 position.
551918c1 8606 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8607 about the same buffer in the same area of character positions, and
8608 the buffer wasn't changed since the time the display string
8609 position was cached.
551918c1 8610
b2d0c91a
EZ
86112011-07-22 Eli Zaretskii <eliz@gnu.org>
8612
8613 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8614 is an integer, which is important for empty lines. (Bug#9149)
8615
043604ee
CY
86162011-07-22 Chong Yidong <cyd@stupidchicken.com>
8617
8618 * frame.c (Fmodify_frame_parameters): In tty case, update the
8619 default face if necessary (Bug#4238).
8620
da4adb04
CY
86212011-07-21 Chong Yidong <cyd@stupidchicken.com>
8622
8623 * editfns.c (Fstring_to_char): No need to explain what a character
8624 is in the docstring (Bug#6576).
8625
9abd0532
LMI
86262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8627
8628 * xml.c (parse_region): Make sure we always return a tree.
8629
36881d16
HK
86302011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8631
8632 * xml.c (parse_region): If a document contains only comments,
8633 return that, too.
8634
1e98674d
LMI
86352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8636
8637 * xml.c (make_dom): Return comments, too.
8638
590bd467
PE
86392011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8640
8641 Port to OpenBSD.
8642 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8643 and the surrounding thread.
8644 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8645 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8646 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8647 timer goes off.
8648 * s/openbsd.h (BROKEN_SIGIO): Define.
8649 * unexelf.c (unexec) [__OpenBSD__]:
8650 Don't update the .mdebug section of the Alpha COFF symbol table.
8651
f41628b2
LMI
86522011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8653
8654 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8655 (bug#8460).
8656
b59b67c5
PE
86572011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8658
15e3a074
PE
8659 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8660 This fixes some race conditions on the permissions of any newly
8661 created file.
8662
41bed37d
PE
8663 * alloc.c (valid_pointer_p): Use pipe, not open.
8664 This fixes some permissions issues when debugging.
8665
b59b67c5
PE
8666 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8667 If fchown fails to set both uid and gid, try to set just gid,
8668 as that is sometimes allowed. Adjust the file's mode to eliminate
8669 setuid or setgid bits that are inappropriate if fchown fails.
8670
925a6be7
SM
86712011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8672
8673 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8674 to compare Lisp_Objects.
8675 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8676 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8677 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8678
52968808
AS
86792011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8680
0a6a104b
AS
8681 * lread.c (read_integer): Unread even EOF character.
8682 (read1): Likewise. Properly record start position of symbol.
8683
52968808
AS
8684 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8685 symbol character follows.
8686
9e381cdd
PE
86872011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8688
8689 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8690 This works around a problem with the previous change to Fcopy_file.
8691 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8692 and without this change, GCC might complain about discarding
8693 fchown's return value.
8694
b5641435
JB
86952011-07-16 Juanma Barranquero <lekktu@gmail.com>
8696
8697 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8698
a8031457
PE
86992011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8700
8701 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8702
dd889327
LMI
87032011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8704
750c33f7
LMI
8705 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8706 it's used from the C level.
8707
dd889327
LMI
8708 * process.c: Use the same condition for POLL_FOR_INPUT in both
8709 keyboard.c and process.c (bug#1858).
8710
87e86684
LM
87112011-07-09 Lawrence Mitchell <wence@gmx.li>
8712
8713 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8714 (Fgnutls_boot): Use it.
8715
64348f40
AS
87162011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8717
8718 * doc.c (Fsubstitute_command_keys): Revert last change.
8719
1d698799
LMI
87202011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8721
f863868c
LMI
8722 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8723 quotes the next character, and doesn't affect other longer
8724 sequences (bug#8935).
8725
1d698799
LMI
8726 * lread.c (syms_of_lread): Clarify that is isn't only
8727 `eval-buffer' and `eval-defun' that's affected by
8728 `lexical-binding' (bug#8460).
8729
aa4b6df6
EZ
87302011-07-15 Eli Zaretskii <eliz@gnu.org>
8731
8732 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8733 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8734
5d856da6
PE
87352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8736
ad6042bb
PE
8737 Fix minor problems found by static checking.
8738 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8739 (elsz): Now a signed constant, not a size_t var. We prefer signed
8740 types to unsigned, to avoid integer comparison confusion. Without
8741 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8742 "cannot optimize loop, the loop counter may overflow", a symptom
8743 of the confusion.
f00bbb22 8744 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8745 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8746
6468f31c
LMI
87472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8748
49080b10
LMI
8749 * search.c (Fre_search_backward): Mention `case-fold-search' in
8750 all the re_search_* functions (bug#8138).
8751
6468f31c
LMI
8752 * keyboard.c (Fopen_dribble_file): Document when the file is
8753 closed (bug#8056).
8754
c965adc5
EZ
87552011-07-14 Eli Zaretskii <eliz@gnu.org>
8756
df9733bf
EZ
8757 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8758 bidi_cache_idx.
8759
0bb23927
EZ
8760 Support bidi reordering of display and overlay strings.
8761 * xdisp.c (compute_display_string_pos)
8762 (compute_display_string_end): Accept additional argument STRING.
8763 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8764 (reseat_to_string): Initialize bidi_it->string.s and
8765 bidi_it->string.schars.
8766 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8767 NULL (avoids a crash in bidi_paragraph_init).
8768 Initialize itb.string.lstring.
0bb23927
EZ
8769 (init_iterator): Call bidi_init_it only of a valid
8770 buffer position was specified. Initialize paragraph_embedding to
8771 L2R.
8772 (reseat_to_string): Initialize the bidi iterator.
8773 (display_string): If we need to ignore text properties of
8774 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8775 original value of -1 will not work with bidi.)
8776 (compute_display_string_pos): First arg is now struct
8777 `text_pos *'; all callers changed. Support display properties on
8778 Lisp strings.
8779 (compute_display_string_end): Support display properties on Lisp
8780 strings.
8781 (init_iterator, reseat_1, reseat_to_string): Initialize the
8782 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8783 when iterating on a string not from display properties).
640c8776
SM
8784 (compute_display_string_pos, compute_display_string_end):
8785 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8786 arrow keys.
8787 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8788 base_level_stop; instead, set base_level_stop to BEGV.
8789 Fixes crashes in vertical-motion.
0bb23927
EZ
8790 (next_element_from_buffer): Improve commentary for when
8791 the iterator is before prev_stop.
8792 (init_iterator): Initialize bidi_p from the default value of
8793 bidi-display-reordering, not from buffer-local value. Use the
8794 buffer-local value only if initializing for buffer iteration.
8795 (handle_invisible_prop): Support invisible properties on strings
8796 that are being bidi-reordered.
8797 (set_iterator_to_next): Support bidi reordering of C strings and
8798 Lisp strings.
8799 (next_element_from_string): Support bidi reordering of Lisp
8800 strings.
8801 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8802 (display_string): Support display of R2L glyph rows.
8803 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8804 (init_iterator): Don't initialize it->bidi_p for strings
8805 here.
8806 (reseat_to_string): Initialize it->bidi_p for strings here.
8807 (next_element_from_string, next_element_from_c_string)
8808 (next_element_from_buffer): Add xassert's for correspondence
8809 between IT's object being iterated and it->bidi_it.string
8810 structure.
8811 (face_before_or_after_it_pos): Support bidi iteration.
8812 (next_element_from_c_string): Handle the case of the first string
8813 character that is not the first one in the visual order.
8814 (get_visually_first_element): New function, refactored from common
8815 parts of next_element_from_buffer, next_element_from_string, and
8816 next_element_from_c_string.
8817 (tool_bar_lines_needed, redisplay_tool_bar)
8818 (display_menu_bar): Force left-to-right direction. Add a FIXME
8819 comment for making that be controlled by a user option.
8820 (push_it, pop_it): Save and restore the state of the
8821 bidi iterator. Save and restore the bidi_p flag.
8822 (pop_it): Iterate out of display property for string iteration as
8823 well.
8824 (iterate_out_of_display_property): Support iteration over strings.
8825 (handle_single_display_spec): Set up it->bidi_it for iteration
8826 over a display string, and call bidi_init_it.
8827 (handle_single_display_spec, next_overlay_string)
8828 (get_overlay_strings_1, push_display_prop): Set up the bidi
8829 iterator for displaying display or overlay strings.
8830 (forward_to_next_line_start): Don't use the shortcut if
8831 bidi-iterating.
8832 (back_to_previous_visible_line_start): If handle_display_prop
8833 pushed the iterator stack, restore the internal state of the bidi
8834 iterator by calling bidi_pop_it same number of times.
8835 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8836 and we are bidi-iterating, don't decrement the iterator position;
8837 instead, set the first_elt flag in the bidi iterator, to produce
8838 the same effect.
8839 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8840 (push_display_prop): xassert that we are iterating a buffer.
8841 (push_it, pop_it): Save and restore paragraph_embedding member.
8842 (handle_single_display_spec, next_overlay_string)
8843 (get_overlay_strings_1, reseat_1, reseat_to_string)
8844 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8845 correctly. Don't assume unibyte strings are not bidi-reordered.
8846 (compute_display_string_pos)
8847 (compute_display_string_end): Fix handling the case of C string.
8848 (push_it, pop_it): Save and restore from_disp_prop_p.
8849 (handle_single_display_spec, push_display_prop): Set the
8850 from_disp_prop_p flag.
8851 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8852 (pop_it): Call iterate_out_of_display_property only if we are
8853 popping after iteration over a string that came from a display
8854 property. Fix a typo in popping stretch info. Add an assertion
8855 for verifying that the iterator position is in sync with the bidi
8856 iterator.
8857 (handle_single_display_spec, get_overlay_strings_1)
8858 (push_display_prop): Fix initialization of paragraph direction for
8859 string when that of the parent object is not yet determined.
8860 (reseat_1): Call bidi_init_it to resync the bidi
8861 iterator with IT's position. (Bug#7616)
8862 (find_row_edges): If ROW->start.pos gives position
8863 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8864 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8865 Reset the from_disp_prop_p flag.
8866 (SAVE_IT, RESTORE_IT): New macros.
8867 (pos_visible_p, face_before_or_after_it_pos)
8868 (back_to_previous_visible_line_start)
8869 (move_it_in_display_line_to, move_it_in_display_line)
8870 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8871 (try_scrolling, redisplay_window, display_line): Use them when
8872 saving a temporary copy of the iterator and restoring it back.
8873 (back_to_previous_visible_line_start, reseat_1)
8874 (init_iterator): Empty the bidi cache "stack".
8875 (move_it_in_display_line_to): If iterator ended up at
8876 EOL, but we never saw any buffer positions smaller than
8877 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8878 motion in bidi-reordered lines.
8879 (move_it_in_display_line_to): Record prev_method and prev_pos
8880 immediately before the call to set_iterator_to_next. Fixes cursor
8881 motion in bidi-reordered lines with stretch glyphs and strings
8882 displayed in margins. (Bug#8133) (Bug#8867)
8883 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8884 TO_CHARPOS.
640c8776
SM
8885 (pos_visible_p): Support positions in bidi-reordered lines.
8886 Save and restore bidi cache.
0bb23927
EZ
8887
8888 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8889 (bidi_paragraph_info): Delete unused struct.
8890 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8891 (bidi_cache_start): New variable.
8892 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8893 to zero.
8894 (bidi_cache_fetch_state, bidi_cache_search)
8895 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8896 (bidi_cache_find, bidi_peek_at_next_level)
8897 (bidi_level_of_next_char, bidi_find_other_level_edge)
8898 (bidi_move_to_visually_next): Compare cache index with
8899 bidi_cache_start rather than with zero.
8900 (bidi_fetch_char): Accept new argument STRING; all callers
8901 changed. Support iteration over a string. Support strings with
8902 display properties. Support unibyte strings. Fix the type of
8903 `len' according to what STRING_CHAR_AND_LENGTH expects.
8904 (bidi_paragraph_init, bidi_resolve_explicit_1)
8905 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8906 (bidi_level_of_next_char, bidi_move_to_visually_next):
8907 Support iteration over a string.
0bb23927
EZ
8908 (bidi_set_sor_type, bidi_resolve_explicit_1)
8909 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8910 can now be zero (for strings); special values 0 and -1 were
8911 changed to -1 and -2, respectively.
8912 (bidi_char_at_pos): New function.
8913 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8914 Call it instead of FETCH_MULTIBYTE_CHAR.
8915 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8916 initialized to valid values.
8917 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8918 values.
8919 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8920 the test for valid cached positions. Fix the logic for looking up
8921 the sentinel state in the cache. GCPRO the Lisp string we are
8922 iterating.
8923 (bidi_push_it, bidi_pop_it): New functions.
8924 (bidi_initialize): Initialize the bidi cache start stack pointer.
8925 (bidi_cache_ensure_space): New function, refactored from part of
8926 bidi_cache_iterator_state. Don't assume the required size is just
8927 one BIDI_CACHE_CHUNK away.
8928 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8929 (bidi_count_bytes, bidi_char_at_pos): New functions.
8930 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8931 always valid if bidi_cache_idx is valid.
8932 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8933 is valid if it's going to be used.
8934 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8935 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8936 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8937 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8938 (bidi_find_other_level_edge, bidi_cache_start_stack):
8939 All variables related to cache indices are now EMACS_INT.
c965adc5 8940
0bb23927
EZ
8941 * dispextern.h (struct bidi_string_data): New structure.
8942 (struct bidi_it): New member `string'. Make flag members be 1-bit
8943 fields, and put them last in the struct.
640c8776
SM
8944 (compute_display_string_pos, compute_display_string_end):
8945 Update prototypes.
0bb23927
EZ
8946 (bidi_push_it, bidi_pop_it): Add prototypes.
8947 (struct iterator_stack_entry): New members bidi_p,
8948 paragraph_embedding, and from_disp_prop_p.
8949 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8950 (bidi_shelve_cache, bidi_unshelve_cache):
8951 Declare prototypes.
0bb23927
EZ
8952
8953 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8954 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8955 and vector-like objects.
8956
8957 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8958 cache around display iteration.
8959
8960 * window.c (Fwindow_end, window_scroll_pixel_based)
8961 (displayed_window_lines, Frecenter): Save and restore the bidi
8962 cache around display iteration.
8963
3bbd2265
LMI
89642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8965
8966 * editfns.c (Fdelete_region): Clarify the use of the named
8967 parameters (bug#6788).
8968
adc47434
MR
89692011-07-14 Martin Rudalics <rudalics@gmx.at>
8970
8971 * indent.c (Fvertical_motion): Set and restore w->pointm when
8972 saving and restoring the window's buffer (Bug#9006).
8973
837c31f8
LMI
89742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8975
8976 * editfns.c (Fstring_to_char): Clarify just what is returned
8977 (bug#6576). Text by Eli Zaretskii.
8978
ac389d0c
JB
89792011-07-13 Juanma Barranquero <lekktu@gmail.com>
8980
8981 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8982
0be0ce47
EZ
89832011-07-13 Eli Zaretskii <eliz@gnu.org>
8984
8985 * buffer.c (mmap_find): Fix a typo.
8986
cd18e7e3
JB
89872011-07-13 Johan Bockgård <bojohan@gnu.org>
8988
8989 Fix execution of x selection hooks.
8990 * xselect.c (Qx_lost_selection_functions)
8991 (Qx_sent_selection_functions): New vars.
8992 (syms_of_xselect): DEFSYM them.
8993 (x_handle_selection_request): Pass Qx_sent_selection_functions
8994 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8995 (x_handle_selection_clear,x_clear_frame_selections):
8996 Pass Qx_lost_selection_functions rather than
8997 Vx_lost_selection_functions to Frun_hook_with_args.
8998
47ea7f44
PE
89992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9000
ac389d0c 9001 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9002 The old code sometimes used this field without initializing it.
9003
47ea7f44
PE
9004 * alloc.c (gc_sweep): Don't read past end of array.
9005 In theory, the old code could also have corrupted Emacs internals,
9006 though it'd be very unlikely.
9007
bc985c87
AS
90082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9009
9010 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9011 argument. (Bug#4026)
bc985c87 9012
0cf34688
LMI
90132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9014
b3dadd76
LMI
9015 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9016 key" (bug#4257).
9017
0cf34688
LMI
9018 * window.c (Fset_window_start): Doc fix (bug#4199).
9019 (Fset_window_hscroll): Ditto.
9020
270768cd
PE
90212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9022
077e3dda 9023 Fix minor new problems caught by GCC 4.6.1.
270768cd 9024 * term.c (init_tty): Remove unused local.
490011a6 9025 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9026 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9027 not used otherwise.
270768cd 9028
b1f58454
CY
90292011-07-12 Chong Yidong <cyd@stupidchicken.com>
9030
9031 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9032
22b9578d
LMI
90332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9034
6e70ab07
LMI
9035 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9036 are the mini-buffer and the echo area (bug#3320).
9037
22b9578d
LMI
9038 * term.c (init_tty): Remove support for supdup, c10 and perq
9039 terminals, which are no longer supported (bug#1482).
9040
8974cc9f
JB
90412011-07-10 Johan Bockgård <bojohan@gnu.org>
9042
9043 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9044
a560d974
JD
90452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9046
9047 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9048 for non-popups (Bug#3642).
9049
1dae0f0a
AS
90502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9051
268c2c36 9052 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9053 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9054 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9055 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9056 * data.c (fmod): Likewise.
9057 * dispnew.c (swap_glyphs_in_rows): Likewise.
9058 * emacs.c (memory_warning_signal): Likewise.
9059 * floatfns.c (float_error): Likewise.
9060 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9061 (otf_open, font_otf_capability, generate_otf_features)
9062 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9063 Likewise.
9064 * image.c (pbm_read_file): Likewise.
9065 * indent.c (string_display_width): Likewise.
9066 * intervals.c (check_for_interval, search_for_interval)
9067 (inc_interval_count, count_intervals, root_interval)
9068 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9069 * lread.c (defalias): Likewise.
268c2c36 9070 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9071 * regex.c (set_image_of_range_1, set_image_of_range)
9072 (regex_grow_registers): Likewise.
9073 * sysdep.c (strerror): Likewise.
9074 * termcap.c (valid_filename_p, tprint, main): Likewise.
9075 * tparam.c (main): Likewise.
9076 * unexhp9k800.c (run_time_remap, save_data_space)
9077 (update_file_ptrs, read_header, write_header, calculate_checksum)
9078 (copy_file, copy_rest, display_header): Likewise.
9079 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9080 Likewise.
9081 * xdisp.c (check_it): Likewise.
9082 * xfaces.c (register_color, unregister_color, unregister_colors):
9083 Likewise.
9084 * xfns.c (print_fontset_result): Likewise.
9085 * xrdb.c (member, fatal, main): Likewise.
9086
99033785
PE
90872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9088
9089 Fix minor problems found by static checking (Bug#9031).
9090 * chartab.c (char_table_set_range, map_sub_char_table):
9091 Remove unused locals.
9092 (uniprop_table): Now static.
9093 * composite.c (_work_char): Remove unused static var.
9094
9cb2ac56
JB
90952011-07-09 Juanma Barranquero <lekktu@gmail.com>
9096
9097 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9098
f25661f0
JD
90992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9100
9101 * gtkutil.c (qttip_cb): Remove code without function.
9102
8278c4fe
EZ
91032011-07-09 Eli Zaretskii <eliz@gnu.org>
9104
9105 * w32.c (pthread_sigmask): New stub.
9106
1692ae2d 91072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9108
8a6ebd58 9109 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9110 sigprocmask is portable only for single-threaded applications, and
9111 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9112 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9113 (LIBES): Use it.
9114 * callproc.c (Fcall_process):
9115 * process.c (create_process):
9116 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9117 Use pthread_sigmask, not sigprocmask.
123403e4 9118
1b854618
JD
91192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9120
9121 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9122 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9123 wrong (Bug#8591).
9124
3fe4b549
JD
91252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9126
0ce7e563
JD
9127 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9128 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9129 (xg_hide_tooltip): Fix comment.
9130
3fe4b549
JD
9131 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9132 in registerServicesMenuSendTypes.
9133 (validRequestorForSendType): Don't check ns_return_types.
9134
9135 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9136 ns_return_type.
9137
5df75e47
JR
91382011-07-08 Jason Rumney <jasonr@gnu.org>
9139
22610910
JR
9140 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9141 SH_SHOW for hidden windows (Bug#5482).
9142
5df75e47
JR
9143 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9144 frame struct members of non-existent frames (Bug#6284).
9145
699c10bd
JD
91462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9147
4393663b
JD
9148 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9149 variable firstTime not needed on OSX >= 10.6.
9150 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9151 >= 10.5. Use setKnobProportion, setDoubleValue.
9152
9153 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9154 (MAC_OS_X_VERSION_10_5): Define if not defined.
9155 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9156 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9157 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9158
9159 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9160 cString and lossyCString on OSX >= 10.4.
4393663b 9161
58179cce 9162 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9163 sizeToFit on OSX >= 10.2.
9164
9165 * nsimage.m (allocInitFromFile): Don't use deprecated method
9166 bestRepresentationForDevice on OSX >= 10.6.
9167
9168 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9169 to avoid warning.
9170
9171 * emacs.c: Declare unexec_init_emacs_zone.
9172
a63e0781
JD
9173 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9174
699c10bd
JD
9175 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9176
9177 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9178 on svcsMenu (Bug#8842).
9179
9180 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9181 ns_return_types.
9182 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9183
9184 * nsterm.m (QUTF8_STRING): Declare.
9185 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9186 (validRequestorForSendType): Return type is (id).
9187 Change indexOfObjectIdenticalTo to indexOfObject.
9188 Check if we have local selection before returning self (Bug#8842).
9189 (writeSelectionToPasteboard): Put local selection into paste board
9190 if we have a local selection (Bug#8842).
9191 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9192
9193 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9194 (ns_get_local_selection): Declare.
9195
54e10184
LMI
91962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9197
9888ff71
LMI
9198 * keymap.c (describe_map_tree): Don't insert a double newline at
9199 the end of the buffer (bug#1169) and return whether we inserted
9200 something.
9201
54e10184
LMI
9202 * callint.c (Fcall_interactively): Change "reading args" to
9203 "providing args" to try to clarify what it does (bug#1010).
9204
15fa4783
KH
92052011-07-07 Kenichi Handa <handa@m17n.org>
9206
9207 * composite.c (composition_compute_stop_pos): Ignore a static
9208 composition starting before CHARPOS (Bug#8915).
9209
9210 * xdisp.c (handle_composition_prop): Likewise.
9211
a8815b00
EZ
92122011-07-07 Eli Zaretskii <eliz@gnu.org>
9213
9214 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9215 (Bug#9015)
9216
ef7b981d 92172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9218
9219 * character.h (unicode_category_t): New enum type.
9220
9221 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9222 (Qchar_code_property_table): New variable.
9223 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9224 (UNIPROP_COMPRESSED_FORM_P): New macros.
9225 (char_table_ascii): Uncompress the compressed values.
9226 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9227 Uncompress the compressed values.
ac389d0c 9228 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9229 (char_table_ref_and_range): Uncompress the compressed values.
9230 (sub_char_table_set): New arg is_uniprop. Callers changed.
9231 Uncompress the compressed values.
9232 (sub_char_table_set_range): Args changed. Callers changed.
9233 (char_table_set_range): Adjuted for the above change.
9234 (map_sub_char_table): Delete args default_val and parent. Add arg
9235 top. Give decoded values to a Lisp function.
640c8776 9236 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9237 values to a Lisp function. Gcpro more variables.
9238 (uniprop_table_uncompress)
9239 (uniprop_decode_value_run_length): New functions.
9240 (uniprop_decoder, uniprop_decoder_count): New variables.
9241 (uniprop_get_decoder, uniprop_encode_value_character)
9242 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9243 New functions.
9244 (uniprop_encoder, uniprop_encoder_count): New variables.
9245 (uniprop_get_encoder, uniprop_table)
9246 (Funicode_property_table_internal, Fget_unicode_property_internal)
9247 (Fput_unicode_property_internal): New functions.
9248 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9249 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9250 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9251 char-code-property-alist.
9252
640c8776 9253 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9254 Vunicode_category_table.
9255
640c8776 9256 * font.c (font_range): Adjust for the change of
c805dec0
KH
9257 Vunicode_category_table.
9258
76b397fb
DN
92592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9260
9261 * m/iris4d.h: Remove file, move contents ...
9262 * s/irix6-5.h: ... here.
9263
22b4128e
PE
92642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9265
9266 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9267 * alloc.c (mark_buffer):
9268 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9269 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9270 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9271 This isn't true in general, and it's particularly not true
9272 if Emacs is configured with --with-wide-int.
9273 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9274 New macros, used in the buffer.c change.
9275
869795d6
JD
92762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9277
9278 * xsettings.c: Use both GConf and GSettings if both are available.
9279 (store_config_changed_event): Add comment.
9280 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9281 (store_tool_bar_style_changed): New functions.
5e617bc2 9282 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9283 (struct xsettings): Move font inside HAVE_XFT.
9284 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9285 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9286 Move inside HAVE_XFT.
640c8776 9287 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9288 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9289 also.
9290 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9291 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9292 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9293 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9294 (parse_settings): Move check for font inside HAVE_XFT.
9295 (read_settings, apply_xft_settings): Add comment.
9296 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9297 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9298 call store_font_name_changed.
9299 (xft_settings_event): Add comment.
9300 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9301 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9302 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9303 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9304 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9305 (xsettings_get_system_font, xsettings_get_system_normal_font):
9306 Add comment.
869795d6 9307
d8ed26bd
PE
93082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9309
9310 Random fixes. E.g., (random) never returned negative values.
9311 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9312 subseconds part to the entropy, as that's a bit more random.
9313 Prefer signed to unsigned, since the signedness doesn't matter and
9314 in general we prefer signed. When given a limit, use a
9315 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9316 latter isn't right if USE_2_TAGS_FOR_INTS.
9317 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9318 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9319
cabf1cac
SM
93202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9321
9322 * textprop.c (text_property_stickiness):
9323 Obey Vtext_property_default_nonsticky.
9324 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9325 * w32fns.c (syms_of_w32fns):
9326 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9327
6e9b2be9
PE
93282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9329
9330 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9331 This is more efficient than Ffile_directory_p and avoids a minor race.
9332
90186c68
LMI
93332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9334
7c301272
LMI
9335 * buffer.c (Foverlay_put): Say what the return value is
9336 (bug#7835).
9337
c4f2d8d4
LMI
9338 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9339 is a directory before asking whether to use the file name
9340 (bug#7564).
ad637907
LMI
9341 (barf_or_query_if_file_exists): Make the "File is a directory"
9342 error be more correct.
c4f2d8d4 9343
90186c68
LMI
9344 * fns.c (Frequire): Remove the mention of the .gz files, since
9345 that's installation-specific, but keep the mention of
9346 `get-load-suffixes'.
9347
da64016e
PE
93482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9349
9350 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9351 Report string overflow if the output is too long.
9352
7d47b580
JB
93532011-07-04 Juanma Barranquero <lekktu@gmail.com>
9354
a555cb87
JB
9355 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9356 (syms_of_gnutls): Remove duplicate DEFSYM for
9357 Qgnutls_bootprop_verify_hostname_error, an error for
9358 Qgnutls_bootprop_verify_error (which is no longer used).
9359
7d47b580
JB
9360 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9361 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9362 Also (re)move comments that are misplaced or no longer relevant.
9363
1e49bfab
LMI
93642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9365
9366 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9367
1485f4c0
CY
93682011-07-03 Chong Yidong <cyd@stupidchicken.com>
9369
9370 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9371 and background color parameters if they have been changed.
9372
a9ab721e
LMI
93732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9374
9375 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9376
cf7cff57
PE
93772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9378
2e13213d
PE
9379 * xsettings.c (SYSTEM_FONT): Define only when used.
9380 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9381
cf7cff57
PE
9382 * keymap.c (access_keymap_1): Now static.
9383
7a8e04f7
CY
93842011-07-02 Chong Yidong <cyd@stupidchicken.com>
9385
9386 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9387 leave any prefix arg for the up event (Bug#1586).
9388
61352f62
LMI
93892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9390
69bb1ef7
LMI
9391 * lread.c (syms_of_lread): Mention single symbols defined by
9392 `defvar' or `defconst' (bug#7154).
9393
61352f62 9394 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9395 (Frequire): Mention get-load-suffixes.
61352f62 9396
28545e04
MR
93972011-07-02 Martin Rudalics <rudalics@gmx.at>
9398
9399 * window.h (window): Remove clone_number slot.
9400 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9401 Remove.
9402 (make_parent_window, make_window, saved_window)
9403 (Fset_window_configuration, save_window_save): Don't deal with
9404 clone numbers.
9405 * buffer.c (Qclone_number): Remove declaration.
9406 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9407
3349e122
SM
94082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9409
9410 Add multiple inheritance to keymaps.
9411 * keymap.c (Fmake_composed_keymap): New function.
9412 (Fset_keymap_parent): Simplify.
9413 (fix_submap_inheritance): Remove.
9414 (access_keymap_1): New function extracted from access_keymap to handle
9415 embedded parents and handle lists of maps.
9416 (access_keymap): Use it.
9417 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9418 (Fcopy_keymap): Handle embedded parents.
9419 (Fcommand_remapping, define_as_prefix): Simplify.
9420 (Fkey_binding): Simplify.
9421 (syms_of_keymap): Move minibuffer-local-completion-map,
9422 minibuffer-local-filename-completion-map,
9423 minibuffer-local-must-match-map, and
9424 minibuffer-local-filename-must-match-map to Elisp.
9425 (syms_of_keymap): Defsubr make-composed-keymap.
9426 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9427 (parse_menu_item): Trivial simplification.
9428
3279eb87
GM
94292011-07-01 Glenn Morris <rgm@gnu.org>
9430
9431 * Makefile.in (SETTINGS_LIBS): Fix typo.
9432
4550efdf
KI
94332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9434
9435 * coding.c (Fencode_coding_string): Record the last coding system
9436 used, as the function doc string says (bug#8738).
9437
0949d2b6
JD
94382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9439
9440 * xsettings.c (store_monospaced_changed): Take new font as arg and
9441 check for change against current_mono_font.
9442 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9443 (emacs_settings_constructor, emacs_settings_get_property)
9444 (emacs_settings_set_property, emacs_settings_class_init)
9445 (emacs_settings_init, gsettings_obj): Remove.
9446 (something_changedCB): New function for HAVE_GSETTINGS.
9447 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9448 with value as argument.
9449 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9450 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9451 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9452 "changed".
9453
9454 * xgselect.c: Add defined (HAVE_GSETTINGS).
9455 (xgselect_initialize): Ditto.
9456
9457 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9458 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9459 xg_select.
9460
bbc6b304
PE
94612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9462
9463 * eval.c (struct backtrace): Simplify and port the data structure.
9464 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9465 signed bit field, as this assumption is not portable and it makes
9466 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9467 "char debug_on_exit : 1" as this is not portable either; instead,
9468 use the portable "unsigned int debug_on_exit : 1". Remove unused
9469 member evalargs. Remove obsolete comments about cc bombing out.
9470
9851bfc5
JD
94712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9472
51bb811f 9473 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9474 Let HAVE_GSETTINGS override HAVE_GCONF.
9475 (store_monospaced_changed): New function.
9476 (EMACS_SETTINGS): A new type derived from GObject to handle
9477 GSettings notifications.
9478 (emacs_settings_constructor, emacs_settings_get_property)
9479 (emacs_settings_set_property, emacs_settings_class_init):
9480 New functions.
9481 (gsettings_client, gsettings_obj): New variables.
9482 (GSETTINGS_SCHEMA): New define.
9483 (something_changedCB): Call store_monospaced_changed.
9484 (init_gsettings): New function.
9485 (xsettings_initialize): Call init_gsettings.
9486 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9487 to NULL.
9488
640c8776 9489 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9490 GCONF_CFLAGS/LIBS.
9491
5386012d
MR
94922011-06-29 Martin Rudalics <rudalics@gmx.at>
9493
9494 * window.c (resize_root_window, grow_mini_window)
9495 (shrink_mini_window): Rename Qresize_root_window to
9496 Qwindow_resize_root_window and Qresize_root_window_vertically to
9497 Qwindow_resize_root_window_vertically.
9498
f13e0b08
PE
94992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9500
9501 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9502
94515237
JB
95032011-06-27 Juanma Barranquero <lekktu@gmail.com>
9504
9505 * makefile.w32-in: Redesign dependencies so they reflect more
9506 clearly which files are directly included by each source file,
9507 and not through other includes.
9508
e43b6e43
MR
95092011-06-27 Martin Rudalics <rudalics@gmx.at>
9510
9511 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9512 (sort_overlays, overlay_strings): When an overlay's clone number
9513 matches the window's clone number process the overlay even if
9514 the overlay's window property doesn't match the current window.
9515
d68443dc
MR
9516 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9517 (Fwindow_hchild): Rename to Fwindow_left_child.
9518 (Fwindow_next): Rename to Fwindow_next_sibling.
9519 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9520 (resize_window_check): Rename to window_resize_check.
9521 (resize_window_apply): Rename to window_resize_apply.
9522 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9523 (Fdelete_other_windows_internal, resize_frame_windows)
9524 (Fsplit_window_internal, Fdelete_window_internal)
9525 (grow_mini_window, shrink_mini_window)
9526 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9527
c7e73be5
JD
95282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9529
9530 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9531 (emacs_fixed_set_min_size): Remove.
9532 (emacs_fixed_new): Take frame as argument.
9533
9534 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9535 (_EmacsFixedPrivate): Remove minwidth/height.
9536 Add struct frame *f.
9537 (emacs_fixed_init): Initialize priv->f.
9538 (get_parent_class, emacs_fixed_set_min_size): Remove.
9539 (emacs_fixed_new): Set priv->f to argument.
9540 (emacs_fixed_get_preferred_width)
9541 (emacs_fixed_get_preferred_height): Use min_width/height from
9542 frames size_hint to set minimum and natural (Bug#8919).
9543 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9544 and use min_width/height from frames size_hint to set
9545 min_width/height (Bug#8919).
9546
9547 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9548 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9549 Fix indentation.
c7e73be5 9550
cf99dcf8
EZ
95512011-06-26 Eli Zaretskii <eliz@gnu.org>
9552
9553 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9554 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9555 called at ZV.
9556
029529ac
CY
95572011-06-26 Chong Yidong <cyd@stupidchicken.com>
9558
9559 * process.c (wait_reading_process_output): Bypass select if
9560 waiting for a cell while ignoring keyboard input, and input is
9561 pending. Suggested by Jan Djärv (Bug#8869).
9562
7a7ef429
PE
95632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9564
9565 Use gnulib's dup2 module instead of rolling our own.
9566 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9567
11fdef7d 95682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9569
9570 * dispnew.c (scrolling_window): Before scrolling, turn off a
9571 mouse-highlight in the window being scrolled.
9572
cd3520a4
JB
95732011-06-24 Juanma Barranquero <lekktu@gmail.com>
9574
9575 Move DEFSYM to lisp.h and use everywhere.
9576
9577 * character.h (DEFSYM): Move declaration...
9578 * lisp.h (DEFSYM): ...here.
9579
9580 * gnutls.c:
9581 * minibuf.c:
9582 * w32menu.c:
9583 * w32proc.c:
9584 * w32select.c: Don't include character.h.
9585
9586 * alloc.c (syms_of_alloc):
9587 * buffer.c (syms_of_buffer):
9588 * bytecode.c (syms_of_bytecode):
9589 * callint.c (syms_of_callint):
9590 * casefiddle.c (syms_of_casefiddle):
9591 * casetab.c (init_casetab_once):
9592 * category.c (init_category_once, syms_of_category):
9593 * ccl.c (syms_of_ccl):
9594 * cmds.c (syms_of_cmds):
9595 * composite.c (syms_of_composite):
9596 * dbusbind.c (syms_of_dbusbind):
9597 * dired.c (syms_of_dired):
9598 * dispnew.c (syms_of_display):
9599 * doc.c (syms_of_doc):
9600 * editfns.c (syms_of_editfns):
9601 * emacs.c (syms_of_emacs):
9602 * eval.c (syms_of_eval):
9603 * fileio.c (syms_of_fileio):
9604 * fns.c (syms_of_fns):
9605 * frame.c (syms_of_frame):
9606 * fringe.c (syms_of_fringe):
9607 * insdel.c (syms_of_insdel):
9608 * keymap.c (syms_of_keymap):
9609 * lread.c (init_obarray, syms_of_lread):
9610 * macros.c (syms_of_macros):
9611 * msdos.c (syms_of_msdos):
9612 * print.c (syms_of_print):
9613 * process.c (syms_of_process):
9614 * search.c (syms_of_search):
9615 * sound.c (syms_of_sound):
9616 * syntax.c (init_syntax_once, syms_of_syntax):
9617 * terminal.c (syms_of_terminal):
9618 * textprop.c (syms_of_textprop):
9619 * undo.c (syms_of_undo):
9620 * w32.c (globals_of_w32):
9621 * window.c (syms_of_window):
9622 * xdisp.c (syms_of_xdisp):
9623 * xfaces.c (syms_of_xfaces):
9624 * xfns.c (syms_of_xfns):
9625 * xmenu.c (syms_of_xmenu):
9626 * xsettings.c (syms_of_xsettings):
9627 * xterm.c (syms_of_xterm): Use DEFSYM.
9628
4228cf16
TZ
96292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9630
cd3520a4 9631 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9632
7fcccf1e
PE
96332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9634
7efb4e0e
PE
9635 Integer and buffer overflow fixes (Bug#8873).
9636
ff5844ad
PE
9637 * print.c (printchar, strout): Check for string overflow.
9638 (PRINTPREPARE, printchar, strout):
9639 Don't set size unless allocation succeeds.
9640
90532f02
PE
9641 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9642 for sizes. Check for string overflow more accurately.
9643 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9644
6d84508d
PE
9645 * macros.c: Integer and buffer overflow fixes.
9646 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9647 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9648 Use ptrdiff_t, not int, for sizes.
9649 Don't increment bufsize until after realloc succeeds.
9650 Check for size-calculation overflow.
9651 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9652
437b2cb4
PE
9653 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9654
8b9ac8b4
PE
9655 * lread.c: Integer overflow fixes.
9656 (read_integer): Radix is now EMACS_INT, not int,
9657 to improve quality of diagnostics for out-of-range radices.
9658 Calculate buffer size correctly for out-of-range radices.
9659 (read1): Check for integer overflow in radices, and in
9660 read-circle numbers.
82cb60d3
PE
9661 (read_escape): Avoid int overflow.
9662 (Fload, openp, read_buffer_size, read1)
9663 (substitute_object_recurse, read_vector, read_list, map_obarray):
9664 Use ptrdiff_t, not int, for sizes.
9665 (read1): Use EMACS_INT, not int, for sizes.
20270765 9666 Check for size overflow.
8b9ac8b4 9667
7fcccf1e
PE
9668 * image.c (cache_image): Check for size arithmetic overflow.
9669
bfbbd7e7
PE
9670 * lread.c: Integer overflow issues.
9671 (saved_doc_string_size, saved_doc_string_length)
9672 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9673 Now ptrdiff_t, not int.
9674 (read1): Don't assume doc string length fits in int. Check for
9675 out-of-range doc string lengths.
9676 (read_list): Don't assume file position fits in int.
39019e54 9677 (read_escape): Check for hex character overflow.
bfbbd7e7 9678
4e323265
LL
96792011-06-22 Leo Liu <sdl.web@gmail.com>
9680
9681 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9682 Move to minibuffer.el.
9683
85fece3e
PE
96842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9685
20b84ce9 9686 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9687 The following patches are for when GLYPH_DEBUG && !XASSERT.
9688 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9689 * dispnew.c (flush_stdout):
9690 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9691 Mark as externally visible.
9692 * dispnew.c (check_window_matrix_pointers): Now static.
9693 * dispnew.c (window_to_frame_vpos):
9694 * xfns.c (unwind_create_frame):
9695 * xterm.c (x_check_font): Remove unused local.
9696 * scroll.c (CHECK_BOUNDS):
9697 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9698 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9699 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9700 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9701 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9702 Now static.
9703 (debug_method_add): Use va_list and vsprintf rather than relying
9704 on undefined behavior with wrong number of arguments.
9705 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9706 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9707 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9708 since we're not interested in debugging glyphs with old libraries.
9709 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9710 GCC 4.6.0's static checking.
9711
0766b489
PE
97122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9713
31fd4b32
PE
9714 Integer overflow and signedness fixes (Bug#8873).
9715 A few related buffer overrun fixes, too.
9716
b79e8648
PE
9717 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9718
0766b489
PE
9719 * dispextern.h (struct face.stipple):
9720 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9721 (x_bitmap_mask, x_allocate_bitmap_record)
9722 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9723 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9724 (x_create_bitmap_from_xpm_data):
9725 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9726 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9727 (.bitmaps_last):
9728 * xfaces.c (load_pixmap):
9729 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9730 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9731 (.bitmaps_last, struct x_output.icon_bitmap):
9732 Use ptrdiff_t, not int, for bitmap indexes.
9733 (x_allocate_bitmap_record): Check for size overflow.
9734 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9735
b081724f
PE
9736 Use ptrdiff_t, not int, for overlay counts.
9737 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9738 * editfns.c (overlays_around, get_pos_property):
9739 * textprop.c (get_char_property_and_overlay):
9740 * xdisp.c (next_overlay_change, note_mouse_highlight):
9741 * xfaces.c (face_at_buffer_position):
21514da7
PE
9742 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9743 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9744 (Fnext_overlay_change, Fprevious_overlay_change)
9745 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9746 Use ptrdiff_t, not int, for sizes.
21514da7 9747 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9748
3de73e5e
PE
9749 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9750
2606c57b
PE
9751 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9752 (x_session_initialize): Do not assume string length fits in int.
9753
aaafe47a
PE
9754 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9755 This is unlikely, but can occur if DPI is outlandish.
9756
2674ddc8 9757 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9758 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9759
28154962
PE
9760 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9761 * xrdb.c (magic_file_p, search_magic_path):
9762 Omit last arg SUFFIX; it was always 0. All callers changed.
9763 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9764
7de51af5
PE
9765 * xfont.c (xfont_match): Avoid need for strlen.
9766
25ed6cc3
PE
9767 * xfns.c: Don't assume strlen fits in int.
9768 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9769
4eab31dd
PE
9770 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9771 not unsigned long, as we prefer signed integers. All callers changed.
9772 Detect integer overflow in repeat count.
9773 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9774 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9775
171e2a58
PE
9776 * termcap.c: Don't assume sizes fit in int and never overflow.
9777 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9778 (gobble_line): Check for size-calculation overflow.
9779
ad39faca 9780 * minibuf.c (Fread_buffer):
6e5bb2dc 9781 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9782 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9783 Don't assume string length fits in int.
9784
52c61c22 9785 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9786 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9787
b5b8c9e5
PE
9788 * font.c: Don't assume string length fits in int.
9789 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9790 Use ptrdiff_t, not int.
ccd6111c
PE
9791 (font_intern_prop): Don't assume string length fits in int.
9792 Don't assume integer property fits in fixnum.
9793 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9794
882f0d81 9795 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9796 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9797 Reformulate so as not to need the command string.
9798 Invoke gzip -cd rather than gunzip, as it's more portable.
9799 (lock_info_type, lock_file_1, lock_file):
9800 Don't assume pid_t and time_t fit in unsigned long.
9801 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9802 (current_lock_owner): Prefer signed type for sizes.
9803 Use memcpy, not strncpy, where memcpy is what is really wanted.
9804 Don't assume (via atoi) that time_t and pid_t fit in int.
9805 Check for time_t and/or pid_t out of range, e.g., via a network share.
9806 Don't alloca where an auto var works fine.
9807
93f4cf88
PE
9808 * fileio.c: Fix some integer overflow issues.
9809 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9810 Don't assume string length fits in int.
9811 (directory_file_name): Don't assume string length fits in long.
9812 (make_temp_name): Don't assume pid fits in int, or that its print
9813 length is less than 20.
9814
f3e92b69
PE
9815 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9816
1bfdaf10
PE
9817 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9818
35016e9a
PE
9819 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9820
3d1e65a1
PE
9821 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9822 We prefer signed integers, even for size calculations.
9823
0b963a93
PE
9824 * emacs.c: Don't assume string length fits in 'int'.
9825 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9826 (main): Don't invoke strlen when not needed.
9827
573f4b54
PE
9828 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9829 (XD_DEBUG_MESSAGE): Don't waste a byte.
9830
989f33ba
PE
9831 * callproc.c (getenv_internal_1, getenv_internal)
9832 (Fgetenv_internal):
965d34eb
PE
9833 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9834
e4d29b33
PE
9835 * lread.c (invalid_syntax): Omit length argument.
9836 All uses changed. This doesn't fix a bug, but it simplifies the
9837 code away from its former Hollerith-constant appearance, and it's
9838 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9839 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9840
eb49b136
PE
9841 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9842 This didn't break anything, but it didn't help either.
9843 It's confusing to put a bogus integer in a place where the actual
9844 value does not matter.
9f62aeb1 9845 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9846 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9847
15375a22
PE
9848 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9849 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9850 implementation.
b61cc01c
PE
9851 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9852 We prefer signed types, and the value cannot exceed the EMACS_INT
9853 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9854 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9855 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9856 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9857
53b2623d
PE
9858 * indent.c (sane_tab_width): New function.
9859 (current_column, scan_for_column, Findent_to, position_indentation)
9860 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9861 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9862
51cab52b 9863 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9864
f2ed8a70
PE
9865 * lisp.h (lint_assume): New macro.
9866 * composite.c (composition_gstring_put_cache):
9867 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9868
abe80cc6
PE
9869 * editfns.c, insdel.c:
9870 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9871
b02c740e
PE
9872 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9873
ebc96716
PE
9874 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9875
b4e50fa0 9876 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9877 Use much-faster test for byte-length change.
311d5d7c 9878 Don't assume string byte-length fits in 'int'.
a4cf38e4 9879 Check that character arg fits in 'int'.
85461888 9880 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9881
c0c1ee9f
PE
9882 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9883
a498d7f4
PE
9884 * fns.c (concat): Catch string overflow earlier.
9885 Do not rely on integer wraparound.
9886
51cab52b
PE
9887 * dispextern.h (struct it.overlay_strings_charpos)
9888 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9889 * xdisp.c (forward_to_next_line_start)
9890 (back_to_previous_visible_line_start)
9891 (reseat_at_next_visible_line_start, next_element_from_buffer):
9892 Don't arbitrarily truncate the value of 'selective' to int.
9893
76031fad
PE
9894 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9895
5eb55db9
PE
9896 * composite.c: Don't truncate sizes to 'int'.
9897 (composition_gstring_p, composition_reseat_it)
9898 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9899 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9900 not EMACS_UINT, for indexes.
5eb55db9 9901
0703a717
PE
9902 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9903
d6202519
PE
9904 * buffer.c: Include <verify.h>.
9905 (struct sortvec.priority, struct sortstr.priority):
8961a454 9906 Now EMACS_INT, not int.
c20998a7 9907 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9908 (struct sortstr.size, record_overlay_string)
9909 (struct sortstrlist.size, struct sortlist.used):
9910 Don't truncate size to int.
9911 (record_overlay_string): Check for size-calculation overflow.
d6202519 9912 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9913
d5a19415
JM
99142011-06-22 Jim Meyering <meyering@redhat.com>
9915
029529ac 9916 Don't leak an XBM-image-sized buffer
d5a19415
JM
9917 * image.c (xbm_load): Free the image buffer after using it.
9918
a9041e6c
PE
99192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9920
9921 Port to Sun C.
9922 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9923 that Sun C diagnosed.
9924 * fns.c (secure_hash): Fix pointer signedness issue.
9925 * intervals.c (static_offset_intervals): New function.
9926 (offset_intervals): Use it.
9927
7f3f739f
LL
99282011-06-21 Leo Liu <sdl.web@gmail.com>
9929
9930 * deps.mk (fns.o):
9931 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9932 sha512.h.
9933
9934 * fns.c (secure_hash): Rename from crypto_hash_function and change
9935 the first arg to accept symbols.
5b66d427 9936 (Fsecure_hash): New primitive.
7f3f739f
LL
9937 (syms_of_fns): New symbols.
9938
76147d94
DD
99392011-06-20 Deniz Dogan <deniz@dogan.se>
9940
9941 * process.c (Fset_process_buffer): Clarify return value in
9942 docstring.
9943
7d7d0045
CY
99442011-06-18 Chong Yidong <cyd@stupidchicken.com>
9945
9946 * dispnew.c (add_window_display_history): Use BVAR.
9947
9948 * xdisp.c (debug_method_add): Use BVAR.
9949 (check_window_end, dump_glyph_matrix, dump_glyph)
9950 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9951
9952 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9953 Likewise.
9954
9955 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9956 check till after the cache is created in init_frame_faces.
9957
ff2bc410
SM
99582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9959
9960 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9961
28177add
PE
99622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9963
dd3482fe
PE
9964 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9965 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9966 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9967
393d71f3 9968 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9969 * fileio.c (Finsert_file_contents):
9970 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9971 Remove the old (too-loose) buffer overflow checks.
9972 They weren't needed, since make_gap checks for buffer overflow.
9973 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9974 The old code merely checked for Emacs fixnum overflow, and relied
9975 on undefined (wraparound) behavior. The new code avoids undefined
9976 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9977
2e6813b0 9978 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9979 Tune. Don't use wider integers than needed. Don't use alloca.
9980 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9981
599a9e4f
PE
9982 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9983
99561444
PE
9984 * insdel.c, lisp.h (buffer_overflow): New function.
9985 (insert_from_buffer_1, replace_range, replace_range_2):
9986 * insdel.c (make_gap_larger):
9987 * editfns.c (Finsert_char):
9988 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9989
28177add
PE
9990 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9991
e69dafad
PE
99922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9993
4baa020d 9994 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9995
b1c46f02
PE
9996 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9997 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9998
e69dafad
PE
9999 * fileio.c: Don't assume EMACS_INT fits in off_t.
10000 (emacs_lseek): New static function.
10001 (Finsert_file_contents, Fwrite_region): Use it.
10002 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10003
566684ea
PE
10004 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10005
e6966cd6
PE
10006 * fns.c: Don't overflow int when computing a list length.
10007 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10008 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10009 truncation on 64-bit hosts. Check for QUIT every
10010 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10011 faster and is responsive enough.
10012 (Flength): Report an error instead of overflowing an integer.
10013 (Fsafe_length): Return a float if the value is not representable
10014 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10015 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10016 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10017
dd0b0efb
PE
10018 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10019 (header_size, word_size): New constants.
10020 (allocate_vectorlike): Don't check size overflow here.
10021 (allocate_vector): Check it here instead, since this is the only
10022 caller of allocate_vectorlike that could cause overflow.
10023 Check that the new vector's length is representable as a fixnum.
10024
86fe5cfe
PE
10025 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10026 The previous code was bogus. For example, next_almost_prime (32)
10027 returned 39, which is undesirable as it is a multiple of 3; and
10028 next_almost_prime (24) returned 25, which is a multiple of 5 so
10029 why was the code bothering to check for multiples of 7?
10030
80e88859
PE
10031 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10032
4a2f0ad6
PE
10033 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10034
f66c7cf8
PE
10035 Variadic C functions now count arguments with ptrdiff_t.
10036 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10037 Back then I didn't know that the Emacs coding style prefers signed int.
10038 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10039 were being counted with int, which may truncate counts on 64-bit
10040 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10041 * lisp.h (struct Lisp_Subr.function.aMANY)
10042 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10043 Arg counts are now ptrdiff_t, not size_t.
10044 All variadic functions and their callers changed accordingly.
10045 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10046 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10047 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10048 * callint.c (Fcall_interactively): Check arg count for overflow,
10049 to avoid potential buffer overrun. Use signed char, not 'int',
10050 for 'varies' array, so that we needn't bother to check its size
10051 calculation for overflow.
10052 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10053 * eval.c (apply_lambda):
10054 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10055 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10056 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10057
a1759b76
PE
10058 * callint.c (Fcall_interactively): Don't use index var as event count.
10059
d96be9fc
PE
10060 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10061 * mem-limits.h (SIZE): Remove; no longer used.
10062
a690a978 10063 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10064
578c21e6
PE
10065 Remove unnecessary casts.
10066 * xterm.c (x_term_init):
10067 * xfns.c (x_set_border_pixel):
10068 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10069 These aren't needed now that we assume ANSI C.
10070
96f53c6c
PE
10071 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10072 It's more likely to cause problems (due to unsigned overflow)
10073 than to cure them.
10074
83c77d31
PE
10075 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10076
ee2079f1
PE
10077 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10078
6da65536
PE
10079 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10080
7147c4a4
PE
10081 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10082
193e32d9
PE
10083 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10084
e5533da6
PE
10085 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10086
9910e595
PE
10087 GLYPH_CODE_FACE returns EMACS_INT, not int.
10088 * dispextern.h (merge_faces):
10089 * xfaces.c (merge_faces):
01103c44
PE
10090 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10091 Don't assume EMACS_INT fits in int.
9910e595 10092
2638320e
PE
10093 * character.h (CHAR_VALID_P): Remove unused parameter.
10094 * fontset.c, lisp.h, xdisp.c: All uses changed.
10095
045eb8d9
PE
10096 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10097
c1f134b5
PE
10098 * fns.c (concat): Minor tuning based on overflow analysis.
10099 This doesn't fix any bugs. Use int to hold character, instead
10100 of constantly refetching from Emacs object. Use XFASTINT, not
10101 XINT, for value known to be a character. Don't bother comparing
10102 a single byte to 0400, as it's always less.
10103
395fcb93 10104 * floatfns.c (Fexpt):
327eeec8
PE
10105 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10106
abbd3d23
PE
10107 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10108 for characters.
10109
684a03ef
PE
10110 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10111
0fed43f3
PE
10112 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10113 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10114 incorrectly succeed when S was a string, because 4294967386 was
10115 truncated before it was used.
10116
8fd02eb7
PE
10117 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10118 Otherwise, an out-of-range integer could cause undefined behavior
10119 on a 64-bit host.
10120
f8c86b69
PE
10121 * composite.c: Use int, not EMACS_INT, for characters.
10122 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10123 EMACS_INT, for values that are known to be in character range.
10124 This doesn't fix any bugs but is the usual style inside Emacs and
10125 may generate better code on 32-bit machines.
10126
34206dd2
PE
10127 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10128 This is for reasons similar to the recent CHAR_STRING fix.
10129 * charset.c (Fencode_char): Check that character arg is actually
10130 a character. Pass an int to ENCODE_CHAR.
10131 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10132 wider than 'int', as a compile-time check to prevent future regressions
10133 in this area.
10134
c5958d4c 10135 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10136
10137 Make sure a 64-bit char is never passed to CHAR_STRING.
10138 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10139 by silently ignoring the top 32 bits, allowing some values
10140 that were far too large to be valid characters.
10141 * character.h: Include <verify.h>.
10142 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10143 arguments are no wider than unsigned, as a compile-time check
10144 to prevent future regressions in this area.
10145 * data.c (Faset):
01103c44 10146 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10147 (Fsubst_char_in_region):
10148 * fns.c (concat):
10149 * xdisp.c (decode_mode_spec_coding):
10150 Adjust to CHAR_STRING's new requirement.
10151 * editfns.c (Finsert_char, Fsubst_char_in_region):
10152 * fns.c (concat): Check that character args are actually
10153 characters. Without this test, these functions did the wrong
10154 thing with wildly out-of-range values on 64-bit hosts.
10155
d37ca623
PE
10156 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10157 These casts should not be needed on 32-bit hosts, either.
10158 * keyboard.c (read_char):
10159 * lread.c (Fload): Remove casts to unsigned.
10160
ea204efb
PE
10161 * lisp.h (UNSIGNED_CMP): New macro.
10162 This fixes comparison bugs on 64-bit hosts.
10163 (ASCII_CHAR_P): Use it.
10164 * casefiddle.c (casify_object):
01103c44 10165 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10166 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10167 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10168 * dispextern.h (FACE_FROM_ID):
10169 * keyboard.c (read_char): Use UNSIGNED_CMP.
10170
41cb286c
PE
10171 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10172 not to EMACS_INT, to avoid GCC warning.
10173
4a1b9832
PE
10174 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10175
55daad71
PE
10176 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10177 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10178 isn't needed on 32-bit machines.
8f95c75c 10179
01103c44
PE
10180 * buffer.c (Fgenerate_new_buffer_name):
10181 Use EMACS_INT for count, not int.
0ceccced 10182 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10183
10184 * data.c (Qcompiled_function): Now static.
10185
c6f072e7
PE
10186 * window.c (window_body_lines): Now static.
10187
20ce5912
PE
10188 * image.c (gif_load): Rename local to avoid shadowing.
10189
9c4c5f81
PE
10190 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10191 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10192 * alloc.c (make_save_value): Integer argument is now of type
10193 ptrdiff_t, not int.
10194 (mark_object): Use ptrdiff_t, not int.
10195 * lisp.h (pD): New macro.
10196 * print.c (print_object): Use it.
10197
c0c5c8ae
PE
10198 * alloc.c: Use EMACS_INT, not int, to count objects.
10199 (total_conses, total_markers, total_symbols, total_vector_size)
10200 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10201 (total_free_floats, total_floats, total_free_intervals)
10202 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10203 Now EMACS_INT, not int. All uses changed.
10204 (Fgarbage_collect): Compute overall total using a double, so that
10205 integer overflow is less likely to be a problem. Check for overflow
10206 when converting back to an integer.
5a25e253
PE
10207 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10208 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10209 These were 'int' variables that could overflow on 64-bit hosts;
10210 they were never used, so remove them instead of repairing them.
211a0b2a 10211 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10212 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10213 Previously, this ceilinged at INT_MAX, but that doesn't work on
10214 64-bit machines.
e46bb31a 10215 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10216
c78baabf 10217 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10218 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10219 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10220 when a (possibly-narrower) signed value would do just as well.
10221 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10222
c9d624c6
PE
10223 * alloc.c: Catch some string size overflows that we were missing.
10224 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10225 for convenience in STRING_BYTES_MAX.
10226 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10227 The definition here is exact; the one in lisp.h was approximate.
10228 (allocate_string_data): Check for string overflow. This catches
10229 some instances we weren't catching before. Also, it catches
10230 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10231 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10232 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10233
c9d624c6
PE
10234 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10235 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10236 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10237
353032ce
PE
10238 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10239
2bccce07
PE
10240 * alloc.c (Fmake_string): Check for out-of-range init.
10241
0ac30604
SM
102422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10243
10244 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10245
c195f2de
JD
102462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10247
10248 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10249 xg_get_default_scrollbar_width.
10250
10251 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10252 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10253 (style_changed_cb): Call update_theme_scrollbar_width and call
10254 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10255 all frames (Bug#8505).
10256 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10257 Call gtk_window_set_resizable if HAVE_GTK3.
10258 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10259 and height if HAVE_GTK3 (Bug#8505).
10260 (scroll_bar_width_for_theme): New variable.
10261 (update_theme_scrollbar_width): New function.
10262 (xg_get_default_scrollbar_width): Move code to
10263 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10264 (xg_initialize): Call update_theme_scrollbar_width.
10265
10266 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10267
10268 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10269
e10ac9f1
MR
102702011-06-12 Martin Rudalics <rudalics@gmx.at>
10271
10272 * frame.c (make_frame): Call other_buffer_safely instead of
10273 other_buffer.
10274
10275 * window.c (temp_output_buffer_show): Call display_buffer with
10276 second argument Vtemp_buffer_show_specifiers and reset latter
10277 immediately after the call.
10278 (Vtemp_buffer_show_specifiers): New variable.
10279 (auto_window_vscroll_p, next_screen_context_lines)
10280 (Vscroll_preserve_screen_position): Remove leading asterisks from
10281 doc-strings.
10282
2d3c217e 102832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10284
7b7f97e8 10285 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10286 * buffer.c (Qclone_number): Remove for now, as it's unused.
10287 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10288 (record_buffer): Remove unused local.
10289 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10290 (set_frame_buffer_list): Remove; unused.
10291 * frame.h (other_visible_frames): Remove decl.
10292 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10293 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10294 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10295 if HAVE_GPM.
10296 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10297 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10298 Define only if HAVE_GPM.
10299 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10300 (update_hints_inhibit): Remove; never set. All uses removed.
10301 * widgetprv.h (emacsFrameClassRec): Remove decl.
10302 * window.c (delete_deletable_window): Now returns void, since it
10303 wasn't returning anything.
10304 (compare_window_configurations): Remove unused locals.
10305 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10306 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10307 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10308 the same widths as pointers. This follows up on the 2011-05-06 patch.
10309 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10310 * xterm.h: Likewise.
10311 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10312
1384b89e
JB
103132011-06-12 Juanma Barranquero <lekktu@gmail.com>
10314
10315 * makefile.w32-in: Update dependencies.
10316 (LISP_H): Add lib/intprops.h.
10317
1100a63c
CY
103182011-06-11 Chong Yidong <cyd@stupidchicken.com>
10319
10320 * image.c (gif_load): Add animation frame delay to the metadata.
10321 (syms_of_image): Use DEFSYM. New symbol `delay'.
10322
6198ccd0
MR
103232011-06-11 Martin Rudalics <rudalics@gmx.at>
10324
10325 * window.c (delete_deletable_window): Re-add.
10326 (Fset_window_configuration): Rewrite to handle dead buffers and
10327 consequently deletable windows.
10328 (window_tree, Fwindow_tree): Remove. Supply functionality in
10329 window.el.
10330 (compare_window_configurations): Simplify code.
10331
b6e3633c
AS
103322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10333
1ab0dee5
AS
10334 * image.c (imagemagick_load_image): Fix type mismatch.
10335 (Fimagemagick_types): Likewise.
10336
b6e3633c
AS
10337 * window.h (replace_buffer_in_windows): Declare.
10338
9397e56f
MR
103392011-06-11 Martin Rudalics <rudalics@gmx.at>
10340
10341 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10342 Qclone_number. Remove external declaration of Qdelete_window.
10343 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10344 code.
640c8776
SM
10345 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10346 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10347 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10348 buffer list implementation.
10349 (other_buffer_safely): New function.
10350 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10351 calls to replace_buffer_in_windows and
10352 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10353 if allowed.
10354 (record_buffer): Inhibit quitting and rewrite using quittable
10355 functions. Run Qbuffer_list_update_hook if allowed.
10356 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10357 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10358 Move switch-to-buffer to window.el.
9397e56f
MR
10359 (bury-buffer): Move to window.el.
10360 (Vbuffer_list_update_hook): New variable.
10361
10362 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10363 section.
10364
10365 * window.h (resize_frame_windows): Move up in code.
10366 (Fwindow_frame): Remove EXFUN.
10367 (replace_buffer_in_all_windows): Remove prototype.
10368 (replace_buffer_in_windows_safely): Add prototype.
10369
10370 * window.c: Declare Qdelete_window static again. Move down
10371 declaration of select_count.
10372 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10373 (Fother_window): Move to window.el.
10374 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10375 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10376 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10377 window.el.
10378 (replace_buffer_in_windows): Implement by calling
10379 Qreplace_buffer_in_windows.
10380 (replace_buffer_in_all_windows): Remove with some functionality
10381 moved into replace_buffer_in_windows_safely.
10382 (replace_buffer_in_windows_safely): New function.
10383 (select_window_norecord, select_frame_norecord): Move in front
10384 of run_window_configuration_change_hook. Remove now obsolete
10385 declarations.
640c8776
SM
10386 (Fset_window_buffer): Rewrite doc-string.
10387 Call Qrecord_window_buffer.
9397e56f
MR
10388 (keys_of_window): Move binding for other-window to window.el.
10389
b50691aa
CY
103902011-06-11 Chong Yidong <cyd@stupidchicken.com>
10391
10392 * dispextern.h (struct image): Replace data member, whose int_val
10393 and ptr_val fields were not used by anything, with a single
10394 lisp_val object.
10395
10396 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10397 (gif_clear_image, gif_load, imagemagick_load_image)
10398 (gs_clear_image, gs_load): Callers changed.
10399
3f754b86
PE
104002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10401
cca69397
PE
10402 * buffer.h: Include <time.h>, for time_t.
10403 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10404
109e28d0
PE
10405 Fix minor problems found by static checking.
10406
60737f02
PE
10407 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10408
4b66faf3
PE
10409 Make identifiers static if they are not used in other modules.
10410 * data.c (Qcompiled_function, Qframe, Qvector):
10411 * image.c (QimageMagick, Qsvg):
10412 * minibuf.c (Qmetadata):
10413 * window.c (resize_window_check, resize_root_window): Now static.
10414 * window.h (resize_window_check, resize_root_window): Remove decls.
10415
109e28d0
PE
10416 * window.c (window_deletion_count, delete_deletable_window):
10417 Remove; unused.
46a4ce9e
PE
10418 (window_body_lines): Now static.
10419 (Fdelete_other_windows_internal): Mark vars as initialized.
10420 Make sure 'resize_failed' is initialized.
10421 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10422 (resize_window_apply): Remove unused local.
10423 * window.h (delete_deletable_window): Remove decl.
10424
109e28d0 10425 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10426 (imagemagick_load_image): Fix pointer signedness problem by changing
10427 last arg from unsigned char * to char *. All uses changed.
10428 Also, fix a local for similar reasons.
10429 Remove unused locals. Remove locals to avoid shadowing.
10430 (fn_rsvg_handle_free): Remove; unused.
10431 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10432 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10433
3f754b86
PE
10434 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10435
2547adb1
CY
104362011-06-10 Chong Yidong <cyd@stupidchicken.com>
10437
10438 * image.c (gif_load): Fix omitted cast error introduced by
10439 2011-06-06 change.
10440
2c8e37d4
MR
104412011-06-10 Martin Rudalics <rudalics@gmx.at>
10442
10443 * window.h (resize_proportionally, orig_total_lines)
10444 (orig_top_line): Remove from window structure.
10445 (set_window_height, set_window_width, change_window_heights)
10446 (Fdelete_window): Remove prototypes.
10447 (resize_frame_windows): Remove duplicate declaration.
10448
440a42e3
EZ
104492011-06-10 Eli Zaretskii <eliz@gnu.org>
10450
10451 * window.h (resize_frame_windows, resize_window_check)
10452 (delete_deletable_window, resize_root_window)
10453 (resize_frame_windows): Declare prototypes.
10454
10455 * window.c (resize_window_apply): Make definition be "static" to
10456 match the prototype.
10457
562dd5e9
MR
104582011-06-10 Martin Rudalics <rudalics@gmx.at>
10459
10460 * window.c: Remove declarations of Qwindow_size_fixed,
10461 window_min_size_1, window_min_size_2, window_min_size,
10462 size_window, window_fixed_size_p, enlarge_window, delete_window.
10463 Remove static from declaration of Qdelete_window, it's
10464 temporarily needed by Fbury_buffer.
10465 (replace_window): Don't assign orig_top_line and
10466 orig_total_lines.
10467 (Fdelete_window, delete_window): Remove. Window deletion is
10468 handled by window.el.
640c8776
SM
10469 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10470 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10471 (Fdelete_other_windows): Remove. Deleting other windows is
10472 handled by window.el.
10473 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10474 handled in window.el.
10475 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10476 Window minimum sizes are handled in window.el.
10477 (shrink_windows, size_window, set_window_height)
10478 (set_window_width, change_window_heights, window_height)
10479 (window_width, CURBEG, CURSIZE, enlarge_window)
10480 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10481 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10482 handled in window.el.
10483 (make_dummy_parent): Rename to make_parent_window and give it a
10484 second argument horflag.
10485 (make_window): Don't set resize_proportionally any more.
10486 (Fsplit_window): Remove. Windows are split in window.el.
10487 (save_restore_action, save_restore_orig_size)
10488 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10489 Resize mini windows in window.el.
10490 (grow_mini_window, shrink_mini_window): Implement by calling
10491 Qresize_root_window_vertically, resize_window_check and
10492 resize_window_apply.
640c8776
SM
10493 (saved_window, Fset_window_configuration, save_window_save):
10494 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10495 resize_proportionally.
10496 (window_min_height, window_min_width): Move to window.el.
10497 (keys_of_window): Move bindings for delete-other-windows,
10498 split-window, delete-window and enlarge-window to window.el.
10499
10500 * buffer.c: Temporarily extern Qdelete_window.
10501 (Fbury_buffer): Temporarily call Qdelete_window instead of
10502 Fdelete_window (Fbury_buffer will move to window.el soon).
10503
10504 * frame.c (set_menu_bar_lines_1): Remove code handling
10505 orig_top_line and orig_total_lines.
10506
10507 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10508 set_window_height but set heights directly.
10509 (change_frame_size_1): Use resize_frame_windows.
10510
10511 * xdisp.c (init_xdisp): Don't use set_window_height but set
10512 heights directly.
10513
640c8776
SM
10514 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10515 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10516 run_window_configuration_change_hook.
10517
10518 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10519 instead of change_window_heights and run
10520 run_window_configuration_change_hook.
10521
1a13852e
MR
105222011-06-09 Martin Rudalics <rudalics@gmx.at>
10523
10524 * window.c (replace_window): Rename second argument REPLACEMENT to
10525 NEW. New third argument SETFLAG. Rewrite.
10526 (delete_window, make_dummy_parent): Call replace_window with
10527 third argument 1.
10528 (window_list_1): Move down in code.
10529 (run_window_configuration_change_hook): Move set_buffer part
10530 before select_frame_norecord part in order to unwind correctly.
10531 Rename count1 to count.
10532 (recombine_windows, delete_deletable_window, resize_root_window)
10533 (Fdelete_other_windows_internal)
10534 (Frun_window_configuration_change_hook, make_parent_window)
10535 (resize_window_check, resize_window_apply, Fresize_window_apply)
10536 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10537 (Fdelete_window_internal, Fresize_mini_window_internal):
10538 New functions.
1a13852e
MR
10539 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10540
f3d1777e
MR
105412011-06-08 Martin Rudalics <rudalics@gmx.at>
10542
496e208e
MR
10543 * window.h (window): Add some new members to window structure -
10544 normal_lines, normal_cols, new_total, new_normal, clone_number,
10545 splits, nest, prev_buffers, next_buffers.
10546 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10547 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10548
f3d1777e
MR
10549 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10550 Remove.
496e208e
MR
10551 (make_dummy_parent): Set new members of windows structure.
10552 (make_window): Move down in code. Handle new members of window
10553 structure.
10554 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10555 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10556 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10557 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10558 (Fset_window_next_buffers, Fset_window_clone_number):
10559 New functions.
496e208e
MR
10560 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10561 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10562 Doc-string fixes.
10563 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10564 Argument WINDOW can be now internal window too.
10565 (Fwindow_use_time): Move up in code.
10566 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10567 Rewrite doc-string.
10568 (Fset_window_configuration, saved_window)
10569 (Fcurrent_window_configuration, save_window_save): Handle new
10570 members of window structure.
b9e809c2
MR
10571 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10572 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10573 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10574 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10575 Qget_mru_window, Qresize_root_window,
10576 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10577 Qauto_buffer_name; staticpro them.
f3d1777e 10578
abde8f8c
MR
105792011-06-07 Martin Rudalics <rudalics@gmx.at>
10580
10581 * window.c (Fwindow_total_size, Fwindow_left_column)
10582 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10583 (Fwindow_list_1): New functions.
10584 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10585 (Fwindow_width, Fscroll_left, Fscroll_right):
10586 Use window_body_cols instead of window_box_text_cols.
10587 (delete_window, Fset_window_configuration):
10588 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10589 (delete_all_subwindows): Take a window as argument and not a
10590 structure. Rewrite.
190b47e6
MR
10591 (window_loop): Remove handling of GET_LRU_WINDOW and
10592 GET_LARGEST_WINDOW.
10593 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10594
10595 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10596 window_box_text_cols. delete_all_subwindows now takes a
10597 Lisp_Object as argument.
abde8f8c 10598
640c8776
SM
10599 * indent.c (compute_motion, Fcompute_motion):
10600 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10601
fa8a67e6
MR
10602 * frame.c (delete_frame): Call delete_all_subwindows with root
10603 window as argument.
10604
a54e3482
DC
106052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10606
10607 * fns.c (Fputhash): Document return value.
10608
60002bf5
CY
106092011-06-06 Chong Yidong <cyd@stupidchicken.com>
10610
10611 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10612
0c671da6 106132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10614
b862a52a 10615 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10616
be44ca6c
PE
10617 Check for overflow when converting integer to cons and back.
10618 * charset.c (Fdefine_charset_internal, Fdecode_char):
10619 Use cons_to_unsigned to catch overflow.
10620 (Fencode_char): Use INTEGER_TO_CONS.
10621 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10622 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10623 * data.c (long_to_cons, cons_to_long): Remove.
10624 (cons_to_unsigned, cons_to_signed): New functions.
10625 These signal an error for invalid or out-of-range values.
10626 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10627 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10628 * font.c (Ffont_variation_glyphs):
10629 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10630 * lisp.h: Include <intprops.h>.
10631 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10632 (cons_to_signed, cons_to_unsigned): New decls.
10633 (long_to_cons, cons_to_long): Remove decls.
10634 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10635 (Fprimitive_undo): Use CONS_TO_INTEGER.
10636 * xfns.c (Fx_window_property): Likewise.
10637 * xselect.c: Include <limits.h>.
10638 (x_own_selection, selection_data_to_lisp_data):
10639 Use INTEGER_TO_CONS.
10640 (x_handle_selection_request, x_handle_selection_clear)
10641 (x_get_foreign_selection, Fx_disown_selection_internal)
10642 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10643 (lisp_data_to_selection_data): Use cons_to_unsigned.
10644 (x_fill_property_data): Use cons_to_signed.
10645 Report values out of range.
10646
d1f3d2af
PE
10647 Check for buffer and string overflow more precisely.
10648 * buffer.h (BUF_BYTES_MAX): New macro.
10649 * lisp.h (STRING_BYTES_MAX): New macro.
10650 * alloc.c (Fmake_string):
10651 * character.c (string_escape_byte8):
10652 * coding.c (coding_alloc_by_realloc):
10653 * doprnt.c (doprnt):
10654 * editfns.c (Fformat):
10655 * eval.c (verror):
10656 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10657 since they may not be the same number.
10658 * editfns.c (Finsert_char):
10659 * fileio.c (Finsert_file_contents):
10660 Likewise for BUF_BYTES_MAX.
10661
dd52fcea
PE
10662 * image.c: Use ptrdiff_t, not int, for sizes.
10663 (slurp_file): Switch from int to ptrdiff_t.
10664 All uses changed.
10665 (slurp_file): Check that file size fits in both size_t (for
10666 malloc) and ptrdiff_t (for sanity and safety).
10667
7f9bbdbb
PE
10668 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10669 if b->modtime has its maximal value.
10670
dfe18f82
PE
10671 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10672
84acfcf0
PE
10673 Don't assume time_t can fit into int.
10674 * buffer.h (struct buffer.modtime): Now time_t, not int.
10675 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10676 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10677
ccd9a01a
PE
10678 Minor fixes for signed vs unsigned integers.
10679 * character.h (MAYBE_UNIFY_CHAR):
10680 * charset.c (maybe_unify_char):
10681 * keyboard.c (read_char, reorder_modifiers):
10682 XINT -> XFASTINT, since the integer must be nonnegative.
10683 * ftfont.c (ftfont_spec_pattern):
10684 * keymap.c (access_keymap, silly_event_symbol_error):
10685 XUINT -> XFASTINT, since the integer must be nonnegative.
10686 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10687 since it makes no difference and we prefer signed.
10688 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10689 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10690 nonnegative.
10691
d6d100dd
SM
106922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10693
10694 * window.h (Fwindow_frame): Declare.
10695
2b6148e4
PE
106962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10697
10698 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10699 (SPARE_MEMORY): Always define.
10700 (LARGE_REQUEST): Remove.
10701 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10702
f230ecc9
MR
107032011-06-06 Martin Rudalics <rudalics@gmx.at>
10704
727e958e
MR
10705 * lisp.h: Move EXFUNS for Fframe_root_window,
10706 Fframe_first_window and Fset_frame_selected_window to window.h.
10707
10708 * window.h: Move EXFUNS for Fframe_root_window,
10709 Fframe_first_window and Fset_frame_selected_window here from
10710 lisp.h.
10711
10712 * frame.c (Fwindow_frame, Fframe_first_window)
10713 (Fframe_root_window, Fframe_selected_window)
10714 (Fset_frame_selected_window): Move to window.c.
10715 (Factive_minibuffer_window): Move to minibuf.c.
10716 (Fother_visible_frames_p): New function.
10717
10718 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10719
f230ecc9
MR
10720 * window.c (decode_window, decode_any_window): Move up in code.
10721 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10722 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10723 (Fwindow_buffer): Move up and rewrite doc-string.
10724 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10725 (Fwindow_prev): New functions.
727e958e
MR
10726 (Fwindow_frame): Move here from frame.c. Accept any window as
10727 argument.
10728 (Fframe_root_window, Fframe_first_window)
10729 (Fframe_selected_window): Move here from frame.c. Accept frame
10730 or arbitrary window as argument. Update doc-strings.
10731 (Fminibuffer_window): Move up in code.
10732 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10733 (Fset_frame_selected_window): Move here from frame.c.
10734 Marginal rewrite.
727e958e
MR
10735 (Fselected_window, select_window, Fselect_window): Move up in
10736 code. Minor doc-string fixes.
f230ecc9 10737
4d09bcf6
PE
107382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10739
10740 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10741 Do not assume that spare memory exists; that assumption is valid
10742 only if SYSTEM_MALLOC.
10743 (LARGE_REQUEST): New macro, so that the issue of large requests
10744 is separated from the issue of spare memory.
10745
810928a2
AS
107462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10747
172418ad
AS
10748 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10749 format. (Bug#8806)
10750
43f862f7
AS
10751 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10752
810928a2
AS
10753 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10754 before statements.
10755
a059fe24
JD
107562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10757
10758 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10759
10760 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10761
10762 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10763 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10764
989bf368
JB
107652011-06-05 Juanma Barranquero <lekktu@gmail.com>
10766
10767 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10768
4b80f674
CY
107692011-06-04 Chong Yidong <cyd@stupidchicken.com>
10770
10771 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10772 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10773 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10774 New error handlers.
4b80f674
CY
10775 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10776 Obey Vx_select_enable_clipboard_manager. Catch errors in
10777 x_clipboard_manager_save (Bug#8779).
10778 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10779 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10780
99a33b77 107812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10782
10783 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10784
99a33b77 107852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10786
10787 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10788 in the current matrix if keep_current_p is non-zero.
10789
8264569d
EZ
107902011-06-04 Eli Zaretskii <eliz@gnu.org>
10791
10792 * bidi.c (bidi_level_of_next_char): Fix last change.
10793
57f97249
EZ
107942011-06-03 Eli Zaretskii <eliz@gnu.org>
10795
fec2107c 10796 Support bidi reordering of text covered by display properties.
57f97249 10797
fec2107c
EZ
10798 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10799 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10800 (bidi_cache_search, bidi_cache_iterator_state)
10801 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10802 (bidi_level_of_next_char, bidi_move_to_visually_next):
10803 Support character positions inside a run of characters covered by a
fec2107c
EZ
10804 display string.
10805 (bidi_paragraph_init, bidi_resolve_explicit_1)
10806 (bidi_level_of_next_char): Call bidi_fetch_char and
10807 bidi_fetch_char_advance instead of FETCH_CHAR and
10808 FETCH_CHAR_ADVANCE.
10809 (bidi_init_it): Initialize new members.
10810 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10811 definitions.
10812 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10813 instead of using explicit *_CHAR codes.
d6d100dd
SM
10814 (bidi_resolve_explicit, bidi_resolve_weak):
10815 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10816 bidirectional text is supported only in multibyte buffers.
10817 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10818 it to initialize the frame_window_p member of struct bidi_it.
10819 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10820 (bidi_resolve_explicit, bidi_resolve_weak)
10821 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10822 bidi_it->nchars is non-positive.
10823 (bidi_level_of_next_char): Don't try to lookup the cache for the
10824 next/previous character if nothing is cached there yet, or if we
10825 were just reseat()'ed to a new position.
c40e2fb2 10826
0e14fe90
EZ
10827 * xdisp.c (set_cursor_from_row): Set start and stop points
10828 according to the row's direction when priming the loop that looks
10829 for the glyph on which to display cursor.
10830 (single_display_spec_intangible_p): Function deleted.
10831 (display_prop_intangible_p): Reimplement to call
10832 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10833 Accept 3 additional arguments needed by handle_display_spec.
10834 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10835 values: lists, `(when COND...)' forms, etc.
10836 (single_display_spec_string_p): Support property values that are
10837 lists with the argument STRING its top-level element.
10838 (display_prop_string_p): Fix the condition for processing a
10839 property that is a list to be consistent with handle_display_spec.
fec2107c 10840 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10841 last portion of handle_display_prop.
10842 (compute_display_string_pos): Accept additional argument
10843 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10844 value of a `display' property is a "replacing spec".
10845 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10846 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10847 the display property, but just return a value indicating whether
10848 the display property will replace the characters it covers.
10849 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10850 frame_window_p members of struct bidi_it.
d6d100dd
SM
10851 (compute_display_string_pos, compute_display_string_end):
10852 New functions.
fec2107c
EZ
10853 (push_it): Accept second argument POSITION, where pop_it should
10854 jump to continue iteration.
10855 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10856
fec2107c
EZ
10857 * keyboard.c (adjust_point_for_property): Adjust the call to
10858 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10859
10860 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10861 (bidi_init_it): Update prototypes.
10862 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10863 (compute_display_string_pos, compute_display_string_end):
10864 Declare prototypes.
fec2107c
EZ
10865 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10866 EMACS_INT.
fc6f18ce 10867
40087514 108682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10869
57f53182
PE
10870 Malloc failure behavior now depends on size of allocation.
10871 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10872 * lisp.h: Change signatures accordingly.
10873 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10874 All callers changed. (Bug#8762)
10875
10876 * gnutls.c: Use Emacs's memory allocators.
10877 Without this change, the gnutls library would invoke malloc etc.
10878 directly, which causes problems on non-SYNC_INPUT hosts, and which
10879 runs afoul of improving memory_full behavior. (Bug#8761)
10880 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10881 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10882 xfree instead of the default malloc, realloc, free.
10883 (Fgnutls_boot): No need to check for memory allocation failure,
10884 since xmalloc does that for us.
10885
ac32cd99 10886 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10887 * category.c (hash_get_category_set):
10888 * ccl.c (ccl_driver):
10889 * charset.c (Fdefine_charset_internal):
10890 * charset.h (struct charset.hash_index):
10891 * composite.c (get_composition_id, gstring_lookup_cache)
10892 (composition_gstring_put_cache):
10893 * composite.h (struct composition.hash_index):
10894 * dispextern.h (struct image.hash):
10895 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10896 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10897 (hashfn_equal, hashfn_user_defined, make_hash_table)
10898 (maybe_resize_hash_table, hash_lookup, hash_put)
10899 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10900 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10901 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10902 * image.c (make_image, search_image_cache, lookup_image)
10903 (xpm_put_color_table_h):
10904 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10905 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10906 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10907 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10908 * alloc.c (allocate_vectorlike):
10909 Check for overflow in vector size calculations.
10910 * ccl.c (ccl_driver):
10911 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10912 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10913 need to be updated by these changes.
40087514
PE
10914 * fns.c (make_hash_table, maybe_resize_hash_table):
10915 Check for integer overflow with large hash tables.
0de4bb68
PE
10916 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10917 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10918 (SXHASH_REDUCE): New macro.
10919 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10920 Use it instead of discarding useful hash info with large hash values.
10921 (sxhash_float): New function.
10922 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10923 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10924 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10925 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10926 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10927 Adjust signatures to match updated version of code.
10928 (consing_since_gc): Now EMACS_INT, since a single hash table can
10929 use more than INT_MAX bytes.
10930
698d32e2
DN
109312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10932
10933 Make it possible to build with GCC-4.6+ -O2 -flto.
10934
10935 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10936
fd6fa53f
SM
109372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10938
10939 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10940 Call minibuffer-inactive-mode.
10941
864db017
JB
109422011-05-31 Juanma Barranquero <lekktu@gmail.com>
10943
10944 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10945 Update dependencies.
10946
2ad0baf4
DN
109472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10948
10949 * data.c (init_data): Remove code for UTS, this system is not
10950 supported anymore.
10951
4fcc2638
DN
109522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10953
10954 Don't force ./temacs to start in terminal mode.
10955
10956 * frame.c (make_initial_frame): Initialize faces in all cases, not
10957 only when CANNOT_DUMP is defined.
10958 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10959
c56e0fd5
DN
109602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10961
10962 * dispnew.c (add_window_display_history): Use const for the string
10963 pointer. Remove declaration, not needed.
10964
333d54da 109652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10966
55d4c1b2 10967 Use 'inline', not 'INLINE'.
333d54da 10968 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10969 * alloc.c, fontset.c (INLINE): Remove.
10970 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10971 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10972 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10973 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10974 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10975
738db178
DN
109762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10977
10978 Make it possible to run ./temacs.
10979
10980 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10981 syms_of_callproc does the same thing. Remove test for
10982 "initialized", do it in the caller.
10983 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10984
620c53a6
SM
109852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10986
10987 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10988 (read_minibuf): Use get_minibuffer.
10989 (syms_of_minibuf): Use DEFSYM.
10990 (Qmetadata): New var.
10991 * data.c (Qbuffer): Don't make it static.
10992 (syms_of_data): Use DEFSYM.
10993
e003a292
PE
109942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10995
10996 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10997 (CCL_CODE_MIN): New macro.
10998
ed008a6d
PE
109992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11000
3687c2ef
PE
11001 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11002
ed008a6d
PE
11003 * eval.c (Qdebug): Now static.
11004 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11005 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11006 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11007
d66c4c7c
CY
110082011-05-29 Chong Yidong <cyd@stupidchicken.com>
11009
11010 * image.c: Various fixes to ImageMagick code comments.
11011 (Fimagemagick_types): Doc fix.
11012
5fbc2025
PE
110132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11014
0196f88a
PE
11015 Minor fixes prompted by GCC 4.6.0 warnings.
11016
11017 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11018
5fbc2025
PE
11019 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11020 (x_clipboard_manager_save_all): Move extern decl to ...
11021 * xterm.h: ... here, so that it can be checked for consistency.
11022
1dd3c2d9
CY
110232011-05-29 Chong Yidong <cyd@stupidchicken.com>
11024
11025 * xselect.c (x_clipboard_manager_save_frame)
11026 (x_clipboard_manager_save_all): New functions.
11027 (Fx_clipboard_manager_save): Lisp function deleted.
11028
11029 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11030 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11031
11032 * xterm.h: Update prototype.
11033
5ba6571d
WX
110342011-05-28 William Xu <william.xwl@gmail.com>
11035
11036 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11037 exiting (Bug#8239).
11038
3eaff834
JM
110392011-05-28 Jim Meyering <meyering@redhat.com>
11040
e1900994 11041 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11042 * fns.c (to_uchar): Define.
11043 (crypto_hash_function): Use it to convert some newly-signed
11044 variables to unsigned, to avoid sign-extension bugs. For example,
11045 without this change, (md5 "truc") would evaluate to
11046 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11047 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11048 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11049
0f6990a7
PE
110502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11051
11052 Integer overflow fixes.
c8a9ca5a 11053
08686060
PE
11054 * dbusbind.c: Serial number integer overflow fixes.
11055 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11056 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11057 to hold a serial number that is too large for a fixnum.
11058 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11059 Check for serial numbers out of range. Decode any serial number
59568bf0 11060 that was so large that it became a float. (Bug#8722)
08686060 11061
2d1fc3c7
PE
11062 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11063 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11064 Use XFASTINT rather than XUINT when numbers are nonnegative.
11065 (xd_append_arg, Fdbus_method_return_internal):
11066 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11067 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11068 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11069 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11070 (Bug#8722)
2d1fc3c7 11071
c8a9ca5a
PE
11072 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11073
519e1d69
PE
11074 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11075
6df6ae42 11076 ccl: Add integer overflow checks.
30569699
PE
11077 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11078 (IN_INT_RANGE): New macros.
11079 (ccl_driver): Use them to check for integer overflow when
11080 decoding a CCL program. Many of the new checks are whether XINT (x)
11081 fits in int; it doesn't always, on 64-bit hosts. The new version
11082 doesn't catch all possible integer overflows, but it's an
847044ea 11083 improvement. (Bug#8719)
30569699 11084
c11285dc
PE
11085 * alloc.c (make_event_array): Use XINT, not XUINT.
11086 There's no need for unsigned here.
11087
fdccd48e
PE
11088 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11089 This follows up to the 2011-05-06 change that substituted uintptr_t
11090 for EMACS_INT. This case wasn't caught back then.
11091
37910ab2
PE
11092 Rework Fformat to avoid integer overflow issues.
11093 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11094 now (part of C89). Include <verify.h>.
11095 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11096 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11097 (Fformat): Avoid the prepass trying to compute sizes; it was only
11098 approximate and thus did not catch overflow reliably. Instead, walk
11099 through the format just once, formatting and computing sizes as we go,
11100 checking for integer overflow at every step, and allocating a larger
11101 buffer as needed. Keep track separately whether the format is
11102 multibyte. Keep only the most-recently calculated precision, rather
11103 than them all. Record whether each argument has been converted to
11104 string. Use EMACS_INT, not int, for byte and char and arg counts.
11105 Support field widths and precisions larger than INT_MAX. Avoid
11106 sprintf's undefined behavior with conversion specifications such as %#d
11107 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11108 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11109 formatting out-of-range floating point numbers with int
9173deec 11110 formats. (Bug#8668)
37910ab2 11111
2e6578fb
PE
11112 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11113
0ae6bdee
PE
11114 * data.c: Avoid integer truncation in expressions involving floats.
11115 * data.c: Include <intprops.h>.
11116 (arith_driver): When there's an integer overflow in an expression
11117 involving floating point, convert the integers to floating point
11118 so that the resulting value does not suffer from catastrophic
11119 integer truncation. For example, on a 64-bit host (* 4
11120 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11121 Do not rely on undefined behavior after integer overflow.
11122
de883a70
PE
11123 merge count_size_as_multibyte, parse_str_to_multibyte
11124 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11125 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11126 Check for integer overflow.
11127 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11128 since it's now a duplicate of the other. This is more of
11129 a character than a buffer op, so better that it's in character.c.
11130 * fns.c, print.c: Adjust to above changes.
11131
2ff916cb
PE
111322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11133
11134 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11135
f1b54466
PE
111362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11137
fb1ac845
PE
11138 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11139 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11140 (x_clipboard_manager_save): Now static.
11141 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11142
f1b54466
PE
11143 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11144 (crypto_hash_function): Now static.
11145 Fix pointer signedness problems. Avoid unnecessary initializations.
11146
a9f737ee
CY
111472011-05-27 Chong Yidong <cyd@stupidchicken.com>
11148
11149 * termhooks.h (Vselection_alist): Make it terminal-local.
11150
11151 * terminal.c (create_terminal): Initialize it.
11152
11153 * xselect.c: Support for clipboard managers.
11154 (Vselection_alist): Move to termhooks.h as terminal-local var.
11155 (LOCAL_SELECTION): New macro.
11156 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11157 (symbol_to_x_atom): Remove gratuitous arg.
11158 (x_handle_selection_request, lisp_data_to_selection_data)
11159 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11160 (x_own_selection, x_get_local_selection, x_convert_selection):
11161 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11162 (some_frame_on_display): Delete unused function.
11163 (Fx_own_selection_internal, Fx_get_selection_internal)
11164 (Fx_disown_selection_internal, Fx_selection_owner_p)
11165 (Fx_selection_exists_p): New optional frame arg.
11166 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11167 (x_handle_selection_clear): Don't treat other terminals with the
11168 same keyboard specially. Use the terminal-local Vselection_alist.
11169 (x_clear_frame_selections): Use Frun_hook_with_args.
11170
11171 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11172
11173 * xterm.h: Add support for those atoms.
11174
e067f0c1
CY
111752011-05-26 Chong Yidong <cyd@stupidchicken.com>
11176
11177 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11178 (converted_selections, conversion_fail_tag): New global variables.
11179 (x_selection_request_lisp_error): Free the above.
11180 (x_get_local_selection): Remove unnecessary code.
11181 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11182 of converted selections stored in converted_selections.
11183 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11184 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11185 (x_convert_selection): New function.
11186 (x_handle_selection_event): Simplify.
11187 (x_get_foreign_selection): Don't ignore incoming requests while
11188 waiting for an answer; this will fail when we implement
11189 SAVE_TARGETS, and seems unnecessary anyway.
11190 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11191 (Vx_sent_selection_functions): Doc fix.
11192
0f4aebc0
LL
111932011-05-26 Leo Liu <sdl.web@gmail.com>
11194
11195 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11196
e61124cd
YM
111972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11198
11199 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11200
11201 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11202 for fringe update if it has periodic bitmap.
ac389d0c 11203 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11204 and fringe_bitmap_periodic_p.
11205
11206 * fringe.c (get_fringe_bitmap_data): New function.
11207 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11208 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11209 row. Mark glyph row for fringe update if periodicity changed.
11210
11211 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11212 for fringe update unless it has periodic bitmap.
11213
f16d9837
KH
112142011-05-25 Kenichi Handa <handa@m17n.org>
11215
11216 * xdisp.c (get_next_display_element): Set correct it->face_id for
11217 a static composition.
11218
e1b90ef6
LL
112192011-05-24 Leo Liu <sdl.web@gmail.com>
11220
11221 * deps.mk (fns.o):
11222 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11223
11224 * fns.c (crypto_hash_function, Fsha1): New function.
11225 (Fmd5): Use crypto_hash_function.
11226 (syms_of_fns): Add Ssha1.
11227
7400048f
PE
112282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11229
11230 * gnutls.c: Remove unused macros.
11231 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11232 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11233 Remove macros that are defined and never used.
11234 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11235
abb71cf4
CY
112362011-05-22 Chong Yidong <cyd@stupidchicken.com>
11237
11238 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11239 (Fx_get_selection_internal): Minor cleanup.
11240 (Fx_own_selection_internal): Rename arguments for consistency with
11241 select.el.
11242
6307db39
PE
112432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11244
11245 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11246
f3d4e0a4
CY
112472011-05-22 Chong Yidong <cyd@stupidchicken.com>
11248
11249 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11250
4d8ade89
YM
112512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11252
11253 * dispnew.c (scrolling_window): Don't exclude the case that the
11254 last enabled row in the desired matrix touches the bottom boundary.
11255
32078c8d
GM
112562011-05-21 Glenn Morris <rgm@gnu.org>
11257
11258 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11259 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11260 and add some more files.
32078c8d 11261
7285dc67
EZ
112622011-05-20 Eli Zaretskii <eliz@gnu.org>
11263
11264 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11265 report_file_error introduced by the change from 2011-05-07.
11266
89d1bd22
PE
112672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11268
11269 * systime.h (Time): Define only if emacs is defined.
11270 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11271 where the include path doesn't have X11/X.h by default. See
11272 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11273
cd394be1 112742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11275
11276 * composite.c (find_automatic_composition): Fix previous change.
11277
b9704ad9
GM
112782011-05-20 Glenn Morris <rgm@gnu.org>
11279
11280 * lisp.mk: New file, split from Makefile.in.
11281 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11282 (shortlisp): Remove.
11283 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11284
4a720484
GM
112852011-05-19 Glenn Morris <rgm@gnu.org>
11286
11287 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11288 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11289 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11290 (lisp): Set the order to that of loadup.el.
11291 (shortlisp): Make it a copy of $lisp.
11292 (SOME_MACHINE_LISP): Remove.
11293 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11294 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11295
a28d4396
KH
112962011-05-18 Kenichi Handa <handa@m17n.org>
11297
11298 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11299 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11300 (find_automatic_composition): Mostly rewrite for efficiency.
11301
a2b1fa8e
JB
113022011-05-18 Juanma Barranquero <lekktu@gmail.com>
11303
11304 * makefile.w32-in: Update dependencies.
11305
8e1f5610
CS
113062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11307
11308 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11309 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11310
7025ee00 113112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11312
cdfa6eab
PE
11313 Fix some integer overflow issues, such as string length overflow.
11314
06d6db33
PE
11315 * insdel.c (count_size_as_multibyte): Check for string overflow.
11316
2b4560a8
PE
11317 * character.c (lisp_string_width): Check for string overflow.
11318 Use EMACS_INT, not int, for string indexes and lengths; in
11319 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11320 the resulting string length overflows an EMACS_INT; instead,
11321 report a string overflow if no precision given. When checking for
11322 precision exhaustion, use a check that cannot possibly have
11323 integer overflow. (Bug#8675)
11324 * character.h (lisp_string_width): Adjust to new signature.
11325
cb93f9be
PE
11326 * alloc.c (string_overflow): New function.
11327 (Fmake_string): Use it. This doesn't change behavior, but saves
11328 a few bytes and will simplify future changes.
11329 * character.c (string_escape_byte8): Likewise.
11330 * lisp.h (string_overflow): New decl.
11331
1a1f3366
PE
11332 Fixups, following up to the user-interface timestamp change.
11333 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11334 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11335 * msdos.c (mouse_get_pos): Likewise.
11336 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11337 * w32gui.h (Time): Define by including "systime.h" rather than by
11338 declaring it ourselves. (Bug#8664)
11339
d4e3e4d3
PE
11340 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11341 * image.c (clear_image_cache): Likewise.
11342
f6a24d19
PE
11343 * term.c (term_mouse_position): Don't assume time_t wraparound.
11344
08dc5ae6
PE
11345 Be more systematic about user-interface timestamps.
11346 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11347 and sometimes 'EMACS_UINT', to represent these timestamps.
11348 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11349 This makes the code easier to follow, and makes it easier to catch
11350 integer overflow bugs such as Bug#8664.
11351 * frame.c (Fmouse_position, Fmouse_pixel_position):
11352 Use Time, not unsigned long, for user-interface timestamps.
11353 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11354 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11355 * keyboard.h (last_event_timestamp): Likewise.
11356 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11357 * menu.h (xmenu_show): Likewise.
11358 * term.c (term_mouse_position): Likewise.
11359 * termhooks.h (struct input_event.timestamp): Likewise.
11360 (struct terminal.mouse_position_hook): Likewise.
11361 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11362 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11363 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11364 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11365 what it was before.
11366 * menu.h, termhooks.h: Include "systime.h", for Time.
11367
8e55734a
PE
11368 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11369 Don't assume that the difference between two unsigned long values
11370 can fit into an integer. At this point, we know button_down_time
11371 <= event->timestamp, so the difference must be nonnegative, so
11372 there's no need to cast the result if double-click-time is
11373 nonnegative, as it should be; check that it's nonnegative, just in
11374 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11375 apart (about 25 days). (Bug#8664)
8e55734a 11376
841f1b75 11377 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11378 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11379
3e26f69c
PE
11380 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11381 that always fit in int. Use a sentinel instead of a counter, to
11382 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11383 * frame.h (struct frame): Use int for menu_bar_items_used
11384 instead of EMACS_INT, since it always fits in int.
3e26f69c 11385
5cc152c0
PE
11386 * menu.c (grow_menu_items): Check for int overflow.
11387
d89eb65e
PE
11388 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11389
5235bd3e
PE
11390 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11391 Before, the code was not consistent. These values cannot exceed
11392 2**31 - 1 so there's no need to make them unsigned.
11393 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11394 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11395 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11396 as modifiers.
11397 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11398
bc827e23
PE
11399 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11400 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11401 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11402 presumably because the widths might not match.
11403
78eb494e
PE
11404 * window.c (size_window): Avoid needless test at loop start.
11405
04f2d78b
CB
114062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11407
11408 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11409
d2fc7e3d 114102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11411
11412 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11413
d2fc7e3d 114142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11415
11416 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11417 `width' to `bar_area_x' and `bar_area_width', respectively.
11418 (x_scroll_run): Take account of fringe background extension.
11419
04f2d78b
CB
11420 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11421 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11422 `bar_area_width', respectively.
11423 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11424 background extension.
11425
79b70037
GM
114262011-05-10 Jim Meyering <meyering@redhat.com>
11427
11428 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11429
2f142cc5
JB
114302011-05-10 Juanma Barranquero <lekktu@gmail.com>
11431
11432 * image.c (Finit_image_library): Return t for built-in image types,
11433 like pbm and xbm. (Bug#8640)
11434
57679c86
AS
114352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11436
11437 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11438
888c9e86
EZ
114392011-05-07 Eli Zaretskii <eliz@gnu.org>
11440
b0512a1d
EZ
11441 * w32console.c (Fset_screen_color): Doc fix.
11442 (Fget_screen_color): New function.
11443 (syms_of_ntterm): Defsubr it.
11444
7285dc67
EZ
11445 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11446 unlink the temporary file if Fcall_process didn't create it in the
11447 first place.
11448 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11449 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11450 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11451 cue to call_process_cleanup not to close that handle.
11452
4d3fcc8e
BK
114532011-05-07 Ben Key <bkey76@gmail.com>
11454
11455 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11456 one of two shell specific rules, either bootstrap-temacs-CMD or
11457 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11458 to the previous implementation of the bootstrap-temacs rule.
11459 The bootstrap-temacs-CMD rule is similar to the previous
11460 implementation of the bootstrap-temacs rule except that it
11461 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11462 variable.
11463
11464 These changes, along with some changes to nt/configure.bat,
11465 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11466 earlier fix to add support for --cflags and --ldflags options
11467 that include quotes so that it works whether make uses cmd or
11468 sh as the shell.
11469
b4289b64
MA
114702011-05-06 Michael Albinus <michael.albinus@gmx.de>
11471
11472 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11473 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11474 is a constant.
11475 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11476 a string. Handle both cases.
11477 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11478 (Fdbus_register_method): Use Qinvalid_function.
11479
af4c0e28
JB
114802011-05-06 Juanma Barranquero <lekktu@gmail.com>
11481
11482 * makefile.w32-in: Update dependencies.
11483 (LISP_H): Add inttypes.h and stdin.h.
11484 (PROCESS_H): Add unistd.h.
11485
c51453d9
EZ
114862011-05-06 Eli Zaretskii <eliz@gnu.org>
11487
11488 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11489 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11490
8ff0ac3c 114912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11492
4c4b566b
PE
11493 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11494
aab2b9b5
PE
11495 * term.c (vfatal): Remove stray call to va_end.
11496 It's not needed and the C Standard doesn't allow it here anyway.
11497
c378da0b
PE
11498 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11499 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11500
288b08c7
PE
11501 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11502 bytes.
11503
e3601888
PE
11504 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11505
db6c0e74
PE
11506 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11507
dd5963ea
PE
11508 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11509
88c9450f
PE
11510 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11511
2f9442b8
PE
11512 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11513
c032b5f8
PE
11514 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11515 * charset.c (Fdefine_charset_internal): Don't initialize
11516 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11517 32-bit int (Bug#8600).
a108c10b
PE
11518
11519 * lread.c (read_integer): Be more consistent with string-to-number.
11520 Use string_to_number to do the actual conversion; this avoids
11521 rounding errors and fixes some other screwups. Without this fix,
11522 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11523 (digit_to_number): Move earlier, for benefit of read_integer.
11524 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11525 not a digit in any supported base. (Bug#8602)
a108c10b 11526
ad5f9eea
PE
11527 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11528
aec1708a
PE
11529 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11530 to match comment at start of function. This also removes a
11531 GCC warning about overflow in a 32+64-bit port.
11532
47be4ab5
PE
11533 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11534
371cac43
PE
11535 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11536 Reported by Stefan Monnier in
11537 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11538 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11539 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11540
d01a7826
PE
11541 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11542 (EMACS_UINTPTR): Likewise, with uintptr_t.
11543
7fd47d5c
PE
11544 * lisp.h: Prefer 64-bit EMACS_INT if available.
11545 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11546 on 32-bit hosts that have 64-bit int, so that they can access
11547 large files.
122b0c86
PE
11548 However, temporarily disable this change unless the temporary
11549 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11550
8727937b
PE
11551 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11552
8ac068ac
PE
11553 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11554 This removes an assumption that EMACS_INT and long are the same
11555 width as pointers. The assumption is true for Emacs porting targets
11556 now, but we want to make other targets possible.
11557 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11558 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11559 In the rest of the code, change types of integers that hold casted
11560 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11561 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11562 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11563 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11564 No need to cast type when ORing.
11565 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11566 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11567 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11568 assume EMACS_INT is the same width as char *.
11569 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11570 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11571 Remove no-longer-needed casts.
11572 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11573 (xg_tool_bar_help_callback, xg_make_tool_item):
11574 Use EMACS_INTPTR to hold an integer
11575 that will be cast to void *; this can avoid a GCC warning
11576 if EMACS_INT is not the same width as void *.
11577 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11578 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11579 (current_message_1, set_message_1):
11580 Use a local to convert to proper width without a cast.
11581 * xmenu.c (dialog_selection_callback): Likewise.
11582
ede49d71
PE
11583 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11584 Also, don't assume VALBITS / RAND_BITS is less than 5,
11585 and don't rely on undefined behavior when shifting a 1 left into
11586 the sign bit.
11587 * lisp.h (get_random): Change signature to match.
11588
2f30ecd0
PE
11589 * lread.c (hash_string): Use size_t, not int, for hash computation.
11590 Normally we prefer signed values; but hashing is special, because
11591 it's better to use unsigned division on hash table sizes so that
11592 the remainder is nonnegative. Also, size_t is the natural width
11593 for hashing into memory. The previous code used 'int', which doesn't
11594 retain enough info to hash well into very large tables.
11595 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11596
2a866e7b
PE
11597 * dbusbind.c: Don't possibly lose pointer info when converting.
11598 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11599 Use XPNTR rather than XHASH, so that the high-order bits of
11600 the pointer aren't lost when converting through void *.
11601
51639eac
PE
11602 * eval.c (Fautoload): Don't double-shift a pointer.
11603
92394119
PE
11604 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11605
dbdb9a7c
JB
116062011-05-06 Juanma Barranquero <lekktu@gmail.com>
11607
11608 * gnutls.c (DEF_GNUTLS_FN):
11609 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11610
db7a0b4f
AS
116112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11612
11613 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11614 marker. (Bug#8610)
11615
cd394be1 116162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11617
11618 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11619 New version that can reserve upto 2GB of heap space.
11620
f7ff1b0f 116212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11622
11623 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11624
639c109b
TZ
116252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11626
11627 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11628 `gnutls_certificate_set_x509_key_file'.
11629
d2127135
JB
116302011-05-05 Juanma Barranquero <lekktu@gmail.com>
11631
11632 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11633 Update dependencies.
11634
e968f4f3
JB
116352011-05-04 Juanma Barranquero <lekktu@gmail.com>
11636
11637 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11638 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11639 Remove unused parameter `fildes'.
11640 * process.c (read_process_output, send_process): Don't pass it.
11641
84d358f0
JB
116422011-05-04 Juanma Barranquero <lekktu@gmail.com>
11643
11644 Fix previous change: the library cache is defined in w32.c.
11645 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11646 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11647
0898ca10
JB
116482011-05-04 Juanma Barranquero <lekktu@gmail.com>
11649
11650 Implement dynamic loading of GnuTLS on Windows.
11651
11652 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11653 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11654 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11655 Declare.
11656
11657 * gnutls.c (Qgnutls_dll): Define.
11658 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11659 (gnutls_*): Declare function pointers.
11660 (init_gnutls_functions): New function to initialize function pointers.
11661 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11662 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11663 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11664 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11665 (emacs_gnutls_write, emacs_gnutls_read)
11666 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11667 (Fgnutls_available_p): New function.
11668 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11669 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11670 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11671
11672 * image.c: Include w32.h.
11673 (Vimage_type_cache): Delete.
11674 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11675 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11676 (w32_delayed_load): Move to w32.c.
11677
11678 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11679
11680 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11681 (w32_delayed_load): Move from image.c. When loading a library, record
11682 its filename in the :loaded-from property of the library id.
11683 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11684 Initialize and staticpro them.
11685 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11686
11687 * process.c: Include lisp.h before w32.h, not after.
11688 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11689 instead of gnutls_record_check_pending.
11690
11691 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11692
ff4de4aa
TZ
116932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11694
11695 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11696 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11697 as passed in.
11698
abe95abb
JD
116992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11700
11701 * xterm.c (x_set_frame_alpha): Do not set property on anything
11702 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11703
e16e55d4
JB
117042011-05-02 Juanma Barranquero <lekktu@gmail.com>
11705
11706 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11707
bafcf6a5
JB
117082011-05-02 Juanma Barranquero <lekktu@gmail.com>
11709
11710 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11711 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11712 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11713 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11714 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11715 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11716 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11717 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11718 (Qgnutls_bootprop_callbacks_verify): Make static.
11719
e7a6747f
AS
117202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11721
19ed11ba
AS
11722 * callproc.c: Indentation fixup.
11723
e7a6747f 11724 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11725 (wait_for_termination, interruptible_wait_for_termination):
11726 Move after wait_for_termination_1.
e7a6747f 11727
1ef14cb4
LMI
117282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11729
11730 * sysdep.c (interruptible_wait_for_termination): New function
11731 which is like wait_for_termination, but allows keyboard
11732 interruptions.
11733
11734 * callproc.c (Fcall_process): Add (:file "file") as an option for
11735 the STDOUT buffer.
11736 (Fcall_process_region): Ditto.
11737
330d880c
EZ
117382011-04-30 Eli Zaretskii <eliz@gnu.org>
11739
8db90b73
EZ
11740 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11741 rather than `XVECTOR (FOO)->size'.
11742
330d880c
EZ
11743 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11744 inttypes.h, as a gnulib replacement is used if it not available in
11745 system headers.
11746
15cbd324
EZ
117472011-04-21 Eli Zaretskii <eliz@gnu.org>
11748
11749 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11750 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11751 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11752
11753 * coding.c (coding_alloc_by_realloc): Error out if destination
11754 will grow beyond MOST_POSITIVE_FIXNUM.
11755 (decode_coding_emacs_mule): Abort if there isn't enough place in
11756 charbuf for the composition carryover bytes. Reserve an extra
11757 space for up to 2 characters produced in a loop.
11758 (decode_coding_iso_2022): Abort if there isn't enough place in
11759 charbuf for the composition carryover bytes.
11760
117612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11762
ae940cca
EZ
11763 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11764 aborting when %lld or %lll format is passed.
11765 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11766 %llo or %llx format is passed. (Bug#8545)
11767
03ab8921
EZ
11768 * window.c (window_scroll_line_based): Use a marker instead of
11769 simple variables to record original value of point. (Bug#7952)
11770
afda1437
EZ
11771 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11772 produced by %s or %c overflows available buffer space. (Bug#8545)
11773
f76dee0c
PE
117742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11775
11776 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11777 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11778
fdc5744d
JB
117792011-04-28 Juanma Barranquero <lekktu@gmail.com>
11780
11781 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11782
638f053a
JB
117832011-04-28 Juanma Barranquero <lekktu@gmail.com>
11784
11785 * keyboard.c (Qdelayed_warnings_hook): Define.
11786 (command_loop_1): Run `delayed-warnings-hook'
11787 if Vdelayed_warnings_list is non-nil.
11788 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11789 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11790
d178f871
EZ
117912011-04-28 Eli Zaretskii <eliz@gnu.org>
11792
11793 * doprnt.c (doprnt): Don't return value smaller than the buffer
11794 size if the message was truncated. (Bug#8545).
11795
b124fd93
JB
117962011-04-28 Juanma Barranquero <lekktu@gmail.com>
11797
11798 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11799 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11800
e810457d
PE
118012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11802
11803 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11804
ea51cceb
JB
118052011-04-27 Juanma Barranquero <lekktu@gmail.com>
11806
11807 * makefile.w32-in: Update dependencies.
11808
94dcfacf
EZ
118092011-04-27 Eli Zaretskii <eliz@gnu.org>
11810
11811 Improve `doprnt' and its usage. (Bug#8545)
11812 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11813 `format_end'. Remove support for %l as a conversion specifier.
11814 Don't use xrealloc. Improve diagnostics when the %l size modifier
11815 is used. Update the commentary.
11816
11817 * eval.c (verror): Simplify calculation of size_t.
11818
11819 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11820 messages.
11821
f61f41d7
PE
118222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11823
11824 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11825 change.
11826
96fb4434
PE
118272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11828
11829 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11830 This makes this file independent of the recent pseudovector change.
11831
671875da 118322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11833
69e9b5a3
PE
11834 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11835
b5f869a7 11836 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11837 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11838 Remove unused local.
c8926152 11839 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11840
841a1577 11841 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11842 GCC 4.6.0 optimizes based on type-based alias analysis.
11843 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11844 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11845 != &v->size, and therefore "v->size = 1; b->size = 2; return
11846 v->size;" must therefore return 1. This assumption is incorrect
11847 for Emacs, since it type-puns struct Lisp_Vector * with many other
11848 types. To fix this problem, this patch adds a new type struct
f904488f 11849 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11850 and pseudovectors, and helps optimizing compilers not get fooled
11851 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11852 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11853 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11854 the size member.
eab3844f
PE
11855 (XSETPVECTYPE): Rewrite in terms of new macro.
11856 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11857 This is a bit clearer, and further avoids the possibility of
11858 undesirable aliasing.
11859 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11860 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11861 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11862 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11863 (ASIZE): Now uses header.size rather than size.
11864 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11865 to avoid the hassle of writing XVECTOR (foo)->header.size.
11866 (struct vectorlike_header): New type.
eab3844f
PE
11867 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11868 object, to help avoid aliasing.
11869 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11870 (SUBRP): Likewise, since Lisp_Subr is a special case.
11871 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11872 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11873 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11874 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11875 changed to be "header.size" and "header.next".
11876 * buffer.h (struct buffer): Likewise.
11877 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11878 * frame.h (struct frame): Likewise.
11879 * process.h (struct Lisp_Process): Likewise.
11880 * termhooks.h (struct terminal): Likewise.
11881 * window.c (struct save_window_data, struct saved_window): Likewise.
11882 * window.h (struct window): Likewise.
11883 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11884 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11885 * buffer.c (init_buffer_once): Likewise.
11886 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11887 special case.
11888 * process.c (Fformat_network_address): Use local var for size,
11889 for brevity.
11890
0df1eac5
PE
11891 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11892
847ab9d1 11893 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11894 * data.c (atof): Remove decl; no longer used or needed.
11895 (digit_to_number): Move to lread.c.
11896 (Fstring_to_number): Use new string_to_number function, to be
11897 consistent with how the Lisp reader treats infinities and NaNs.
11898 Do not assume that floating-point numbers represent EMACS_INT
11899 without losing information; this is not true on most 64-bit hosts.
11900 Avoid double-rounding errors, by insisting on integers when
11901 parsing non-base-10 numbers, as the documentation specifies.
11902 * lisp.h (string_to_number): New decl, replacing ...
11903 (isfloat_string): Remove.
bc0a5c13 11904 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11905 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11906 appears to have been a coding error. Similarly, do not accept
11907 strings like +-1e0 as floating point numbers. Do not report
11908 overflow for integer overflows unless the base is not 10 which
11909 means we have no simple and reliable way to continue.
11910 Break out the floating-point parsing into a new
11911 function string_to_number, so that Fstring_to_number parses
11912 floating point numbers consistently with the Lisp reader.
04f2d78b 11913 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11914 (E_CHAR, EXP_INT): Remove, replacing with ...
11915 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11916 (string_to_number): New function, replacing isfloat_string.
11917 This function checks for valid syntax and produces the resulting
11918 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11919 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11920 so that overflow for non-base-10 numbers is reported only when
11921 there's no portable and simple way to convert to floating point.
452f4150 11922
67769ffc
PE
11923 * textprop.c (set_text_properties_1): Rewrite for clarity,
11924 and to avoid GCC warning about integer overflow.
11925
c20db43f
PE
11926 * intervals.h (struct interval): Use EMACS_INT for members
11927 where EMACS_UINT might cause problems. See
11928 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11929 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11930 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11931 All uses changed.
37aa2f85
PE
11932 (offset_intervals): Tell GCC not to worry about length overflow
11933 when negating a negative length.
c20db43f 11934
2538aa2f
PE
11935 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11936 (overrun_check_free): Likewise.
11937
f2d3008d
PE
11938 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11939 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11940 word size.
11941
ec8df744
PE
11942 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11943 (gnutls_make_error): Rename local to avoid shadowing.
11944 (gnutls_emacs_global_deinit): ifdef out; not used.
11945 (Fgnutls_boot): Use const for pointer to readonly storage.
11946 Comment out unused local. Fix pointer signedness problems.
11947
640ee02d
PE
11948 * lread.c (openp): Don't stuff size_t into an 'int'.
11949 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11950 about possible signed overflow.
11951
6048fb2a
PE
11952 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11953 (GDK_KEY_g): Don't define if already defined.
11954 (xg_prepare_tooltip): Avoid pointer signedness problem.
11955 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11956
fa3c87e1
PE
11957 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11958 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11959
2172544b
PE
11960 * xfns.c (Fx_window_property): Simplify a bit,
11961 to make a bit faster and to avoid GCC 4.6.0 warning.
11962 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11963
9b821a21
PE
11964 * fns.c (internal_equal): Don't assume size_t fits in int.
11965
3c616cfa
PE
11966 * alloc.c (compact_small_strings): Tighten assertion a little.
11967
c2982e87
PE
11968 Replace pEd with more-general pI, and fix some printf arg casts.
11969 * lisp.h (pI): New macro, generalizing old pEd macro to other
11970 conversion specifiers. For example, use "...%"pI"d..." rather
11971 than "...%"pEd"...".
11972 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11973 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11974 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11975 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11976 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11977 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11978 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11979 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11980 64-bit hosts.
11981 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11982 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11983 * print.c (safe_debug_print, print_object): Likewise.
11984 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11985 to int.
6f04d126
PE
11986 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11987 avoiding the 0 flag, which is not portable.
c2982e87
PE
11988 * process.c (Fmake_network_process): Use pI to avoid cast.
11989 * region-cache.c (pp_cache): Likewise.
11990 * xdisp.c (decode_mode_spec): Likewise.
11991 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11992 behavior on 64-bit hosts with printf arg.
6f04d126 11993 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11994 (x_stop_queuing_selection_requests): Likewise.
11995 (x_get_window_property): Don't truncate byte count to an 'int'
11996 when tracing.
0b432f21 11997
5e073ec7
PE
11998 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11999 here, since it parses constructs like leading '-' and spaces,
12000 which are not wanted; and it overflows with large numbers.
12001 Instead, simply match F[0-9]+, which is what is wanted anyway.
12002
36372bf9
PE
12003 * alloc.c: Remove unportable assumptions about struct layout.
12004 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12005 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12006 (allocate_vectorlike, make_pure_vector): Use the new macros,
12007 plus offsetof, to remove unportable assumptions about struct layout.
12008 These assumptions hold on all porting targets that I know of, but
12009 they are not guaranteed, they're easy to remove, and removing them
12010 makes further changes easier.
12011
0b432f21
PE
12012 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12013 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12014 (string_overrun_cookie): Now const. Use initializers that
12015 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12016 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12017 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12018 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12019 multiple of sizeof (EMACS_INT); it need not be, if
12020 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12021 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12022
895009e1
JB
120232011-04-26 Juanma Barranquero <lekktu@gmail.com>
12024
12025 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12026
6a7a1b0b
TZ
120272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12028
12029 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12030 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12031 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12032
841a1577 120332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12034
12035 * lisp.h (Qdebug): List symbol.
895009e1 12036 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12037 * keyboard.c (debug-on-event): New variable.
12038 (handle_user_signal): Break into debugger when debug-on-event
12039 matches the current signal symbol.
12040
f2d3ba6f
DN
120412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12042
12043 * alloc.c (check_sblock, check_string_bytes)
12044 (check_string_free_list): Convert to standard C.
12045
42ce4c63
TZ
120462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12047
12048 * w32.c (emacs_gnutls_push): Fix typo.
12049
825cd63c
EZ
120502011-04-25 Eli Zaretskii <eliz@gnu.org>
12051
fb11d64d
EZ
12052 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12053 "cast to pointer from integer of different size".
12054
825cd63c
EZ
12055 Improve doprnt and its use in verror. (Bug#8545)
12056 * doprnt.c (doprnt): Document the set of format control sequences
12057 supported by the function. Use SAFE_ALLOCA instead of always
12058 using `alloca'.
12059
12060 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12061 is one byte too soon. Don't use xrealloc; instead xfree and
12062 xmalloc anew.
12063
e061a11b
TZ
120642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12065
12066 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12067 callbacks stage.
12068
12069 * gnutls.c: Renamed global_initialized to
12070 gnutls_global_initialized. Added internals for the
12071 :verify-hostname-error, :verify-error, and :verify-flags
12072 parameters of `gnutls-boot' and documented those parameters in the
12073 docstring. Start callback support.
9173deec
JB
12074 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12075 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12076 on error. Return error code.
e061a11b
TZ
12077 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12078 (emacs_gnutls_read): Likewise.
12079 (Fgnutls_boot): Return handshake error code.
12080 (emacs_gnutls_handle_error): New function.
12081 (wsaerror_to_errno): Likewise.
12082
12083 * w32.h (emacs_gnutls_pull): Add prototype.
12084 (emacs_gnutls_push): Likewise.
12085
12086 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12087 (emacs_gnutls_push): Likewise.
12088
120892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12090
12091 * process.c (wait_reading_process_output): Check if GnuTLS
12092 buffered some data internally if no FDs are set for TLS
12093 connections.
12094
12095 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12096 (LIBS): Link to USER_LIBS.
12097 ($(BLD)/gnutls.$(0)): New target.
12098
fa6996bc
EZ
120992011-04-24 Eli Zaretskii <eliz@gnu.org>
12100
eb35682e
EZ
12101 * xdisp.c (handle_single_display_spec): Rename the
12102 display_replaced_before_p argument into display_replaced_p, to
12103 make it consistent with the commentary. Fix typos in the
12104 commentary.
12105
e2ad650c
EZ
12106 * textprop.c (syms_of_textprop): Remove dead code.
12107 (copy_text_properties): Delete obsolete commentary about an
12108 interface that was deleted long ago. Fix typos in the description
12109 of arguments.
12110
1b2de274
EZ
12111 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12112 to changes in oldXMenu/XMenu.h from 2011-04-16.
12113 <menu_help_message, prev_menu_help_message>: Constify.
12114 (IT_menu_make_room): menu->help_text is now `const char **';
12115 adjust.
12116
12117 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12118 to changes in oldXMenu/XMenu.h from 2011-04-16.
12119 (struct XMenu): Declare `help_text' `const char **'.
12120
12121 * xfaces.c <Qunspecified>: Make extern again.
12122
12123 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12124 required by POSIX.
1b2de274 12125
762b15be
EZ
12126 * doc.c (get_doc_string): Improve the format passed to `error'.
12127
12128 * doprnt.c (doprnt): Improve commentary.
12129
12130 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12131
12132 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12133 them with etags.
12134
f1052e5d
EZ
12135 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12136 changes in globals.h immediately force recompilation.
762b15be
EZ
12137 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12138 $(CURDIR)/s/ms-w32.h.
12139 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12140
fa6996bc
EZ
12141 * character.c (Fchar_direction): Function deleted.
12142 (syms_of_character): Don't defsubr it.
12143 <char-direction-table>: Deleted.
12144
e6c3da20
EZ
121452011-04-23 Eli Zaretskii <eliz@gnu.org>
12146
12147 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12148 * doprnt.c: Include limits.h.
12149 (SIZE_MAX): New macro.
04f2d78b
CB
12150 (doprnt): Return a size_t value. 2nd arg is now size_t.
12151 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12152 Improve overflow protection. Support `l' modifier for integer
12153 conversions. Support %l conversion. Don't assume an EMACS_INT
12154 argument for integer conversions and for %c.
12155
12156 * lisp.h (doprnt): Restore prototype.
12157
12158 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12159 $(SRC)/character.h.
12160
12161 * Makefile.in (base_obj): Add back doprnt.o.
12162
12163 * deps.mk (doprnt.o): Add back prerequisites.
12164 (callint.o): Depend on character.h.
12165
12166 * eval.c (internal_lisp_condition_case): Include the handler
12167 representation in the error message.
12168 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12169 when breaking from the loop.
12170
12171 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12172
12173 * callint.c (Fcall_interactively): When displaying error message
12174 about invalid control letter, pass the character's codepoint, not
12175 a pointer to its multibyte form. Improve display of the character
12176 in octal and display also its hex code.
12177
12178 * character.c (char_string): Use %x to display the (unsigned)
12179 codepoint of an invalid character, to avoid displaying a bogus
12180 negative value.
12181
12182 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12183 `error', not SYMBOL_NAME itself.
12184
12185 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12186 character arguments to `error'.
12187
12188 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12189 to `error' in error message about FINAL_CHAR argument. Make sure
12190 FINAL_CHAR is a character, and use %c when it is passed as
12191 argument to `error'.
12192
4ffd0d6b 121932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12194
12195 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12196
12197 * w32.c: Include <time.h>.
12198 (sys_localtime): New function.
12199
4ffd0d6b 122002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12201
12202 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12203
4ffd0d6b 12204 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12205
4ffd0d6b 122062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12207
4ffd0d6b
GM
12208 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12209 zombies (Bug#8467).
aac0c6e3 12210
04c56954
EZ
122112011-04-19 Eli Zaretskii <eliz@gnu.org>
12212
12213 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12214 gl_state.e_property when gl_state.object is Qt.
12215
12216 * insdel.c (make_gap_larger): Remove limitation of buffer size
12217 to <= INT_MAX.
12218
16a43933
CY
122192011-04-18 Chong Yidong <cyd@stupidchicken.com>
12220
12221 * xdisp.c (lookup_glyphless_char_display)
12222 (produce_glyphless_glyph): Handle cons cell entry in
12223 glyphless-char-display.
12224 (Vglyphless_char_display): Document it.
12225
12226 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12227 glyphless-char-display.
12228
4581706e
CY
122292011-04-17 Chong Yidong <cyd@stupidchicken.com>
12230
12231 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12232
12233 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12234
12235 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12236 definition for no-X builds.
12237
4887c6e2 122382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12239
fd35b6f9
PE
12240 Static checks with GCC 4.6.0 and non-default toolkits.
12241
5c1ccb01
PE
12242 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12243
006c5daa
PE
12244 * process.c (keyboard_bit_set): Define only if SIGIO.
12245 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12246 (send_process): Repair possible setjmp clobbering.
12247
efc736d3
PE
12248 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12249
4e2fe2e6
PE
12250 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12251
f97334a2
PE
12252 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12253
4e75f29d
PE
12254 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12255 Define only if needed.
12256
90efadd1
PE
12257 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12258 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12259 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12260
3c647824
PE
12261 * dispextern.h (struct redisplay_interface): Rename param
12262 to avoid shadowing.
e264f262 12263 * termhooks.h (struct terminal): Likewise.
761383f4 12264 * xterm.c (xembed_send_message): Likewise.
3c647824 12265
b58c5c4a
PE
12266 * insdel.c (make_gap_smaller): Define only if
12267 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12268
cad59032
PE
12269 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12270 it.
12271
c339dc2e
PE
12272 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12273 so that we aren't warned about unused symbols.
12274
91a3e27b
PE
12275 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12276
399c71d3 12277 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12278
8ffc96f5
PE
12279 * xfns.c (x_real_positions): Mark locals as initialized.
12280
eef9bc79
PE
12281 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12282
098db9dd
PE
12283 * xterm.c: Fix problems found by static analysis with other toolkits.
12284 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12285 (x_dispatch_event): Declare static if USE_GTK, and
12286 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12287 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12288 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12289 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12290 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12291
eb18f6cc
PE
12292 * xmenu.c (menu_help_callback): Pointer type fixes.
12293 Use const pointers when pointing at readonly data. Avoid pointer
12294 signedness clashes.
12295 (FALSE): Remove unused macro.
12296 (update_frame_menubar): Remove unused decl.
12297
1fe72bf8
PE
12298 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12299
60d9e1db
PE
12300 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12301 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12302 (single_menu_item): Rename local to avoid shadowing.
12303
39261c26
PE
12304 * keyboard.c (make_lispy_event): Remove unused local var.
12305
018c5e19
PE
12306 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12307 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12308
63d2b86e
PE
12309 * bitmaps: Change bitmaps from unsigned char back to the X11
12310 compatible char. Avoid the old compiler warnings about
12311 out-of-range initializers by using, for example, '\xab' rather
12312 than 0xab.
12313
aefd87e1
PE
12314 * xgselect.c (xgselect_initialize): Check vs interface
12315 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12316
bf501fb9
PE
12317 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12318
e9829fdf
PE
12319 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12320 to read-only memory.
12321
1086c095
PE
12322 * fns.c (vector): Remove; this old hack is no longer needed.
12323
2baccd04 12324 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12325 Remove unused var.
dde42981 12326 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12327
72391843 12328 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12329
436c16df 12330 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12331 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12332 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12333
92bb796d 12334 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12335 (x_term_init): Remove local to avoid shadowing.
92bb796d 12336
764430a3 12337 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12338
12339 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12340 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12341
d1dfb56c
EZ
123422011-04-16 Eli Zaretskii <eliz@gnu.org>
12343
c4354cb4
EZ
12344 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12345
d1dfb56c
EZ
12346 Fix regex.c, syntax.c and friends for buffers > 2GB.
12347 * syntax.h (struct gl_state_s): Declare character position members
12348 EMACS_INT.
12349
12350 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12351
04f2d78b
CB
12352 * textprop.c (verify_interval_modification, interval_of):
12353 Declare arguments EMACS_INT.
d1dfb56c
EZ
12354
12355 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12356 EMACS_INT.
12357
12358 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12359
12360 * indent.c (Fvertical_motion): Local variable it_start is now
12361 EMACS_INT.
12362
12363 * regex.c (re_match, re_match_2, re_match_2_internal)
12364 (bcmp_translate, regcomp, regexec, print_double_string)
12365 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12366 (re_compile_pattern, re_exec): Declare arguments and local
12367 variables `size_t' and `ssize_t' and return values `regoff_t', as
12368 appropriate.
12369 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12370 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12371 <compile_stack_type>: `size' and `avail' are now `size_t'.
12372
12373 * regex.h <regoff_t>: Use ssize_t, not int.
12374 (re_search, re_search_2, re_match, re_match_2): Arguments that
12375 specify buffer/string position and length are now ssize_t and
12376 size_t. Return type is regoff_t.
12377
613052cd
BK
123782011-04-16 Ben Key <bkey76@gmail.com>
12379
12380 * nsfont.m: Fixed bugs in ns_get_family and
12381 ns_descriptor_to_entity that were caused by using free to
12382 deallocate memory blocks that were allocated by xmalloc (via
12383 xstrdup). This caused Emacs to crash when compiled with
12384 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12385 --enable-checking=xmallocoverrun). xfree is now used to
12386 deallocate these memory blocks.
12387
4170f62f 123882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12389
71b41406
PE
12390 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12391
9587a89d
PE
12392 emacs_write: Accept and return EMACS_INT for sizes.
12393 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12394 et seq.
12395 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12396 Accept and return EMACS_INT.
12397 (emacs_gnutls_write): Return the number of bytes written on
12398 partial writes.
12399 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12400 (emacs_read, emacs_write): Remove check for negative size, as the
12401 Emacs source code has been audited now.
9587a89d
PE
12402 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12403 (emacs_read, emacs_write): Use it.
273a5f82
PE
12404 * process.c (send_process): Adjust to the new signatures of
12405 emacs_write and emacs_gnutls_write. Do not attempt to store
12406 a byte offset into an 'int'; it might overflow.
9587a89d 12407 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12408
3e047f51
PE
12409 * sound.c: Don't assume sizes fit in 'int'.
12410 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12411 Return EMACS_INT, not int.
3e047f51 12412 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12413 Accept EMACS_INT, not int.
12414 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12415 record read return values.
12416
cc39a9db
BK
124172011-04-15 Ben Key <bkey76@gmail.com>
12418
c9d0ec6d
JB
12419 * keyboard.c (Qundefined): Don't declare static since it is used
12420 in nsfns.m.
12421 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12422 static since they are used in nsfont.m.
cc39a9db 12423
6c60eb9f
SM
124242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12425
12426 * process.c (Qprocessp): Don't declare static.
12427 * lisp.h (Qprocessp): Declare again.
12428
7990b61a
JB
124292011-04-15 Juanma Barranquero <lekktu@gmail.com>
12430
12431 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12432
5d4cb038
PE
124332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12434
8bd7b830 12435 Improve C-level modularity by making more things 'static'.
cd64ea1d 12436
e3b27b31
PE
12437 Don't publish debugger-only interfaces to other modules.
12438 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12439 (verify_bytepos, count_markers): Move decls to the only modules
12440 that need them.
12441 * region-cache.h (pp_cache): Likewise.
12442 * window.h (check_all_windows): Likewise.
12443 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12444
5d4cb038
PE
12445 * sysdep.c (croak): Now static, if
12446 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12447 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12448
12449 * alloc.c (refill_memory_reserve): Now static if
12450 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12451 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12452
e87b6180
PE
12453 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12454 Define only if USE_LUCID.
12455
ac64929e
PE
12456 * xrdb.c (x_customization_string, x_rm_string): Now static.
12457
6f37259d
PE
12458 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12459 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12460
1683e3ab
PE
12461 * xdisp.c (draw_row_with_mouse_face): Now static.
12462 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12463
de9c2632
PE
12464 * window.h (check_all_windows): Mark externally visible.
12465
2b96acb7
PE
12466 * window.c (window_deletion_count): Now static.
12467
12468 * undo.c: Make symbols static if they're not exported.
12469 (last_undo_buffer, last_boundary_position, pending_boundary):
12470 Now static.
12471
50436f33
PE
12472 * textprop.c (interval_insert_behind_hooks): Now static.
12473 (interval_insert_in_front_hooks): Likewise.
12474
64520e5c
PE
12475 * term.c: Make symbols static if they're not exported.
12476 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12477 (max_frame_lines, tty_set_terminal_modes):
12478 (tty_reset_terminal_modes, tty_turn_off_highlight):
12479 (get_tty_terminal): Now static.
12480 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12481 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12482 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12483 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12484 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12485
1fa53021
PE
12486 * sysdep.c: Make symbols static if they're not exported.
12487 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12488 Now static.
12489 (sigprocmask_set, full_mask): Remove; unused.
12490 (wait_debugging): Mark as visible.
12491 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12492 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12493
d4b43b22
PE
12494 * syntax.c (syntax_temp): Define only if !__GNUC__.
12495
b7c513d0
PE
12496 * sound.c (current_sound_device, current_sound): Now static.
12497
989b29ad
PE
12498 * search.c (searchbufs, searchbuf_head): Now static.
12499
13a55a78
PE
12500 * scroll.c (scroll_cost): Remove; unused.
12501 * dispextern.h (scroll_cost): Remove decl.
12502
de68a1fc
PE
12503 * region-cache.h (pp_cache): Mark as externally visible.
12504
40ccffa6
PE
12505 * process.c: Make symbols static if they're not exported.
12506 (process_tick, update_tick, create_process, chan_process):
12507 (Vprocess_alist, proc_buffered_char, datagram_access):
12508 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12509 (deactivate_process): Mark defn as static, as well as decl.
12510 * lisp.h (create_process): Remove decl.
12511 * process.h (chan_process, Vprocess_alist): Remove decls.
12512
ad64fc97
PE
12513 * print.c: Make symbols static if they're not exported.
12514 (print_depth, new_backquote_output, being_printed, print_buffer):
12515 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12516 (print_interval, print_number_index, initial_stderr_stream):
12517 Now static.
12518 * lisp.h (Fprinc): Remove decl.
12519 (debug_output_compilation_hack): Mark as externally visible.
12520
adddb265
PE
12521 * sysdep.c (croak): Move decl from here to syssignal.h.
12522 * syssignal.h (croak): Put it here, so the API can be checked when
12523 'croak' is called from dissociate_if_controlling_tty.
12524
1717ede2
PE
12525 * minibuf.c: Make symbols static if they're not exported.
12526 (minibuf_save_list, choose_minibuf_frame): Now static.
12527 * lisp.h (choose_minibuf_frame): Remove decl.
12528
fa5fb2bc
PE
12529 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12530
1e3890d1
PE
12531 * lread.c: Make symbols static if they're not exported.
12532 (read_objects, initial_obarray, oblookup_last_bucket_number):
12533 Now static.
12534 (make_symbol): Remove; unused.
12535 * lisp.h (initial_obarray, make_symbol): Remove decls.
12536
8a1414fa
PE
12537 * keyboard.c: Make symbols static if they're not exported.
12538 (single_kboard, recent_keys_index, total_keys, recent_keys):
12539 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12540 (this_single_command_key_start, echoing, last_auto_save):
12541 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12542 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12543 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12544 (Vlispy_mouse_stem, double_click_count):
12545 Now static.
12546 (force_auto_save_soon): Define only if SIGDANGER.
12547 (ignore_mouse_drag_p): Now static if
12548 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12549 (print_help): Remove; unused.
12550 (stop_character, last_timer_event): Mark as externally visible.
12551 * keyboard.h (ignore_mouse_drag_p): Declare only if
12552 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12553 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12554 * lisp.h (echoing): Remove decl.
12555 (force_auto_save_soon): Declare only if SIGDANGER.
12556 * xdisp.c (redisplay_window): Simplify code, to make it more
12557 obvious that ignore_mouse_drag_p is not accessed if !defined
12558 USE_GTK && !defined HAVE_NS.
12559
93ea6e8f
PE
12560 * intervals.c: Make symbols static if they're not exported.
12561 (merge_properties_sticky, merge_interval_right, delete_interval):
12562 Now static.
12563 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12564
77382fcc
PE
12565 * insdel.c: Make symbols static if they're not exported.
12566 However, leave prepare_to_modify_buffer alone. It's never
12567 called from outside this function, but that appears to be a bug.
12568 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12569 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12570 (adjust_after_replace_noundo): Remove; unused.
12571 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12572 (signal_before_change): Remove decls.
77382fcc 12573
9306c32e
PE
12574 * indent.c (val_compute_motion, val_vmotion): Now static.
12575
cd44d2eb
PE
12576 * image.c: Make symbols static if they're not exported.
12577 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12578 if USE_GTK.
12579 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12580 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12581
ad9a7a06
PE
12582 * fringe.c (standard_bitmaps): Now static.
12583 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12584
81626931
PE
12585 * frame.c: Make symbols static if they're not exported.
12586 (x_report_frame_params, make_terminal_frame): Now static.
12587 (get_frame_param): Now static, unless HAVE_NS.
12588 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12589 (x_get_resource_string): Remove; not used.
12590 * frame.h (make_terminal_frame, x_report_frame_params):
12591 (x_get_resource_string); Remove decls.
12592 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12593 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12594
239f9db9
PE
12595 * font.c, fontset.c: Make symbols static if they're not exported.
12596 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12597 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12598 * font.c (font_close_object): Now static.
12599 * font.h (font_close_object): Remove.
12600 * fontset.c (FONTSET_OBJLIST): Remove.
12601 (free_realized_fontset) #if-0 the body, which does nothing.
12602 (face_suitable_for_char_p): #if-0, as it's never called.
12603 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12604 * xfaces.c (face_at_string_position):
12605 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12606 since 0 is always ASCII.
12607
dfcf3579
PE
12608 * fns.c (weak_hash_tables): Now static.
12609
5045092b
PE
12610 * fileio.c: Make symbols static if they're not exported.
12611 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12612 (Vwrite_region_annotation_buffers): Now static.
12613
57a96f5c
PE
12614 * eval.c: Make symbols static if they're not exported.
12615 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12616 * lisp.h (backtrace_list): Remove decl.
12617
35f08c38
PE
12618 * emacs.c: Make symbols static if they're not exported.
12619 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12620 (fatal_error_code, fatal_error_signal_hook, standard_args):
12621 Now static.
12622 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12623 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12624 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12625 * lisp.h (fatal_error_signal_hook): Remove decl.
12626 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12627
f44bd759
PE
12628 * editfns.c: Move a (normally-unused) function to its only use.
12629 * editfns.c, lisp.h (get_operating_system_release): Remove.
12630 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12631 worth the hassle of breaking this out.
12632
b532497d
PE
12633 * xterm.c: Make symbols static if they're not exported.
12634 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12635 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12636 (x_destroy_window, x_delete_display):
12637 Now static.
12638 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12639 (x_mouse_leave): Remove; unused.
12640 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12641 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12642 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12643 Remove decls.
12644 (x_mouse_leave): Declare only if WINDOWSNT.
12645 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12646 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12647 USE_X_TOOLKIT.
12648
1675728f
PE
12649 * ftxfont.c: Make symbols static if they're not exported.
12650 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12651 HAVE_FREETYPE.
12652 * font.h (ftxfont_driver): Likewise.
12653
e4cebfca
PE
12654 * xfns.c: Make symbols static if they're not exported.
12655 (x_last_font_name, x_display_info_for_name):
12656 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12657 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12658 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12659 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12660 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12661 (last_show_tip_args): Now static.
12662 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12663 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12664 (x_screen_planes): Remove; unused.
12665 * dispextern.h (x_screen_planes): Remove decl.
12666
5bf46f05
PE
12667 * dispnew.c: Make symbols static if they're not exported.
12668 * dispextern.h (redraw_garbaged_frames, scrolling):
12669 (increment_row_positions): Remove.
12670 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12671 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12672 Now static.
12673 (redraw_garbaged_frames): Remove; unused.
12674
435f4c28
PE
12675 * xfaces.c: Make symbols static if they're not exported.
12676 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12677 Remove decls.
12678 * xterm.h (defined_color): Remove decls.
12679 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12680 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12681 (menu_face_changed_default, defined_color, free_realized_face):
12682 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12683 (ascii_face_of_lisp_face): Remove; unused.
12684
8524aef3
PE
12685 * xdisp.c: Make symbols static if they're not exported.
12686 * dispextern.h (scratch_glyph_row, window_box_edges):
12687 (glyph_to_pixel_coords, set_cursor_from_row):
12688 (get_next_display_element, set_iterator_to_next):
12689 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12690 (show_mouse_face): Remove decls
12691 * frame.h (message_buf_print): Likewise.
12692 * lisp.h (pop_message, set_message, check_point_in_composition):
12693 Likewise.
12694 * xterm.h (set_vertical_scroll_bar): Likewise.
12695 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12696 (message_buf_print, scratch_glyph_row, displayed_buffer):
12697 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12698 (get_next_display_element, show_mouse_face, window_box_edges):
12699 (frame_to_window_pixel_xy, check_point_in_composition):
12700 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12701 (glyph_to_pixel_coords): Remove; unused.
12702
16390cd2
PE
12703 * dired.c (file_name_completion): Now static.
12704
12705 * dbusbind.c (xd_in_read_queued_messages): Now static.
12706
a25f4dfa
PE
12707 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12708 * data.c (circular_list_error): Remove.
12709
14a9c8df
PE
12710 * commands.h (last_point_position, last_point_position_buffer):
12711 (last_point_position_window): Remove decls.
12712 * keyboard.c: Make these variables static.
12713
04f2d78b
CB
12714 * coding.h (coding, code_convert_region, encode_coding_gap):
12715 Remove decls.
74ab6df5
PE
12716 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12717 (iso_code_class, detect_coding, code_convert_region): Now static.
12718 (encode_coding_gap): Remove; unused.
12719
38dfbee1
PE
12720 * chartab.c (chartab_chars, chartab_bits): Now static.
12721
a2cb4e63
PE
12722 * charset.h (charset_iso_8859_1): Remove decl.
12723 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12724 Now static.
12725
127198fd
PE
12726 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12727 * ccl.c (Vccl_program_table): Now static.
12728 (check_ccl_update): Remove; unused.
12729
d85b608f
PE
12730 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12731 * category.h: ... from here.
12732 * category.c (check_category_table, set_category_set): Now static.
12733
31cd66f3
PE
12734 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12735 * lisp.h: Remove these decls.
12736
c358e587
PE
12737 * buffer.c (buffer_count): Remove unused var.
12738
e78aecca
PE
12739 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12740 so that it's not optimized away.
12741 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12742 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12743 exported only to the debugger.
12744
e192d7d3 12745 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12746 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12747
92470028
PE
12748 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12749 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12750 was inaccessible from Lisp.
12751 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12752 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12753
244ed907
PE
12754 alloc.c: Import and export fewer symbols, and remove unused items.
12755 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12756 is defined.
12757 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12758 it's not optimized away by whole-program optimization.
12759 (message_enable_multibyte, free_misc): Remove.
12760 (catchlist, handlerlist, mark_backtrace):
12761 Declare only if BYTE_MARK_STACK.
12762 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12763 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12764 (message_enable_multibyte): Remove decl.
12765 (free_misc, interval_free_list, float_block, float_block_index):
12766 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12767 (cons_free_list, last_marked_index):
12768 Now static.
12769 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12770 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12771 (mark_backtrace): Define only if BYTE_MARK_STACK.
12772 * xdisp.c (message_enable_multibyte): Now static.
12773
61c2b50e 12774 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12775 This makes it easier for human readers (and static analyzers)
12776 to see whether these variables are used from other modules.
12777 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12778 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12779 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12780 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12781 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12782 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12783 * xmenu.c, xselect.c:
12784 Declare Q* vars static if they are not used in other modules.
12785 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12786 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12787 Remove decls of unexported vars.
12788 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12789
95c82688
PE
12790 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12791
16a97296
PE
12792 Make Emacs functions such as Fatom 'static' by default.
12793 This makes it easier for human readers (and static analyzers)
12794 to see whether these functions can be called from other modules.
12795 DEFUN now defines a static function. To make the function external
12796 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12797 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12798 (Finit_image_library):
16a97296
PE
12799 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12800 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12801 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12802 Remove decls, since these functions are now static.
12803 (Funintern, Fget_internal_run_time): New decls, since these functions
12804 were already external.
95c82688 12805
16a97296
PE
12806 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12807 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12808 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12809 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12810 * keyboard.c, keymap.c, lread.c:
12811 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12812 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12813 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12814 Mark functions with DEFUE instead of DEFUN,
12815 if they are used in other modules.
12816 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12817 decls for now-static functions.
12818 * buffer.h (Fdelete_overlay): Remove decl.
12819 * callproc.c (Fgetenv_internal): Mark as internal.
12820 * composite.c (Fremove_list_of_text_properties): Remove decl.
12821 (Fcomposition_get_gstring): New forward static decl.
12822 * composite.h (Fcomposite_get_gstring): Remove decl.
12823 * dired.c (Ffile_attributes): New forward static decl.
12824 * doc.c (Fdocumntation_property): New forward static decl.
12825 * eval.c (Ffetch_bytecode): New forward static decl.
12826 (Funintern): Remove extern decl; now in .h file where it belongs.
12827 * fileio.c (Fmake_symbolic_link): New forward static decl.
12828 * image.c (Finit_image_library): New forward static decl.
12829 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12830 * intervals.h (Fprevious_property_change):
12831 (Fremove_list_of_text_properties): Remove decls.
12832 * keyboard.c (Fthis_command_keys): Remove decl.
12833 (Fcommand_execute): New forward static decl.
12834 * keymap.c (Flookup_key): New forward static decl.
12835 (Fcopy_keymap): Now static.
12836 * keymap.h (Flookup_key): Remove decl.
12837 * process.c (Fget_process): New forward static decl.
12838 (Fprocess_datagram_address): Mark as internal.
12839 * syntax.c (Fsyntax_table_p): New forward static decl.
12840 (skip_chars): Remove duplicate decl.
12841 * textprop.c (Fprevious_property_change): New forward static decl.
12842 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12843 Now internal.
12844 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12845 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12846
785bbd42
PE
12847 * editfns.c (Fformat): Remove unreachable code.
12848
8b913b57
AS
128492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12850
12851 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12852 change. (Bug#8496)
12853
a6744a35
EZ
128542011-04-13 Eli Zaretskii <eliz@gnu.org>
12855
12856 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12857 when at ZV. (Bug#8487)
12858
e7974947
AS
128592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12860
baad03f0
AS
12861 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12862 (Bug#8437)
12863 * keyboard.c (parse_tool_bar_item): Likewise.
12864 * sound.c (sound_cleanup, alsa_close): Likewise.
12865 * termcap.c (tgetent): Likewise.
12866 * xfns.c (x_default_font_parameter): Likewise.
12867 * xsettings.c (read_and_apply_settings): Likewise.
12868
e7974947
AS
12869 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12870 (overrun_check_free): Protoize.
12871
28272684
PE
128722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12873
12874 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12875 since callers should never pass a negative size.
12876 Change the signature to match that of plain 'read' and 'write'; see
12877 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12878 * lisp.h: Update prototypes of emacs_write and emacs_read.
12879
11997c76
EZ
128802011-04-11 Eli Zaretskii <eliz@gnu.org>
12881
12882 * xdisp.c (redisplay_window): Don't try to determine the character
12883 position of the scroll margin if the window start point w->startp
e896f03c 12884 is outside the buffer's accessible region. (Bug#8468)
11997c76 12885
8a2cbd72
EZ
128862011-04-10 Eli Zaretskii <eliz@gnu.org>
12887
12888 Fix write-region and its subroutines for buffers > 2GB.
12889 * fileio.c (a_write, e_write): Modify declaration of arguments and
12890 local variables to support buffers larger than 2GB.
12891 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12892
12893 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12894 argument, local variables, and return value.
12895
12896 * lisp.h: Update prototypes of emacs_write and emacs_read.
12897
12898 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12899
4073e537 129002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12901
1ebfdcb6
PE
12902 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12903
b2ded58d
PE
12904 Fix more problems found by GCC 4.6.0's static checks.
12905
7d66342c
PE
12906 * xdisp.c (vmessage): Use a better test for character truncation.
12907
bbf47d44
PE
12908 * charset.c (load_charset_map): <, not <=, for optimization,
12909 and to avoid potential problems with integer overflow.
9248994d 12910 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12911 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12912 * editfns.c (Fformat): Likewise.
1e69125e 12913 * syntax.c (skip_chars): Likewise.
3befa583 12914
e3019616
PE
12915 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12916 This also lets GCC 4.6.0 generate slightly better loop code.
12917
becfa255
PE
12918 * callint.c (Fcall_interactively): <, not <=, for optimization.
12919 (Fcall_interactively): Count the number of arguments produced,
12920 not the number of arguments given. This is simpler and lets GCC
12921 4.6.0 generate slightly better code.
12922
dae0cd48
PE
12923 * ftfont.c: Distingish more carefully between FcChar8 and char.
12924 The previous code passed unsigned char * to a functions like
12925 strlen and xstrcasecmp that expect char *, which does not
12926 conform to the C standard.
12927 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12928 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12929 char * when the C standard requires it.
12930
76032d70
PE
12931 * keyboard.c (read_char): Remove unused var.
12932
eb3f1cc8
PE
12933 * eval.c: Port to Windows vsnprintf (Bug#8435).
12934 Include <limits.h>.
12935 (SIZE_MAX): Define if the headers do not.
12936 (verror): Do not give up if vsnprintf returns a negative count.
12937 Instead, grow the buffer. This ports to Windows vsnprintf, which
12938 does not conform to C99. Problem reported by Eli Zaretskii.
12939 Also, simplify the allocation scheme, by avoiding the need for
12940 calling realloc, and removing the ALLOCATED variable.
12941
70476b54
PE
12942 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12943
12020a9e
PE
12944 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12945 But keep the doprint source code for now, as we might revamp it
12946 and use it again (Bug#8435).
ea6c7ae6
PE
12947 * lisp.h (doprnt): Remove.
12948 * Makefile.in (base_obj): Remove doprnt.o.
12949 * deps.mk (doprnt.o): Remove.
12950
5fdb398c
PE
12951 error: Print 32- and 64-bit integers portably (Bug#8435).
12952 Without this change, on typical 64-bit hosts error ("...%d...", N)
12953 was used to print both 32- and 64-bit integers N, which relied on
12954 undefined behavior.
61bdb816 12955 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12956 * lisp.h (error, verror): Mark as printf-like functions.
12957 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12958 Report overflow in size calculations when allocating printf buffer.
12959 Do not truncate output string at its first null byte.
12960 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12961 Truncate the output at a character boundary, since vsnprintf does not
12962 do that.
12963 * charset.c (check_iso_charset_parameter): Convert internal
12964 character to string before calling 'error', since %c now has the
12965 printf meaning.
12966 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12967 overflow when computing char to be passed to 'error'. Do not
12968 pass Lisp_Object to 'error'; pass the integer instead.
12969 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12970 formatted with plain %d.
12971
b189fa66
PE
12972 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12973
bff87ef0
PE
12974 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12975
7e2cac20
PE
12976 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12977
ce4d90b5
PE
12978 * xterm.c (x_catch_errors): Remove duplicate declaration.
12979
266c9547
PE
12980 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12981
79c49ad2
PE
12982 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12983
368f4090
JM
129842011-04-10 Jim Meyering <meyering@redhat.com>
12985
12986 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12987 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12988 return ssize_t not "int", and use size_t as the buffer length.
12989 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12990 * gnutls.h: Update declarations.
12991 * process.c (read_process_output): Use ssize_t, to match.
12992 (send_process): Likewise.
12993
a32d4040
CY
129942011-04-09 Chong Yidong <cyd@stupidchicken.com>
12995
12996 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12997
8546720e 129982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12999
04f2d78b
CB
13000 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13001 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13002
8546720e
GM
13003 * xterm.c (handle_one_xevent):
13004 * xmenu.c (create_and_show_popup_menu):
13005 * xselect.c (x_decline_selection_request)
13006 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13007
0a2f5c1a 130082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13009
13010 Fix some uses of `int' instead of EMACS_INT.
13011 * search.c (string_match_1, fast_string_match)
13012 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13013 (scan_buffer, find_next_newline_no_quit)
13014 (find_before_next_newline, search_command, Freplace_match)
13015 (Fmatch_data): Make some `int' variables be EMACS_INT.
13016
13017 * xdisp.c (display_count_lines): 3rd argument and return value now
13018 EMACS_INT. All callers changed.
13019 (pint2hrstr): Last argument is now EMACS_INT.
13020
13021 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13022 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13023 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13024 (decode_coding_utf_16, decode_coding_emacs_mule)
13025 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13026 (decode_coding_ccl, decode_coding_charset)
13027 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13028 (decode_coding_iso_2022, decode_coding_emacs_mule)
13029 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13030 <char_offset, last_offset>: Declare EMACS_INT.
13031 (encode_coding_utf_8, encode_coding_utf_16)
13032 (encode_coding_emacs_mule, encode_invocation_designation)
13033 (encode_designation_at_bol, encode_coding_iso_2022)
13034 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13035 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13036 Declare EMACS_INT.
13037 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13038 (encode_invocation_designation): Last argument P_NCHARS is now
13039 EMACS_INT.
13040 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13041 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13042
13043 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13044 All users changed.
13045
13046 * ccl.c (Fccl_execute_on_string): Declare some variables
13047 EMACS_INT.
13048
8546720e 130492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13050
13051 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13052
4e19a977
CS
130532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13054
13055 * process.c (Fformat_network_address): Doc fix.
13056
87302331
R
130572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13058
ee7683eb 13059 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13060
cbb59342
CY
130612011-04-08 Chong Yidong <cyd@stupidchicken.com>
13062
13063 * keyboard.c (read_char): Call Lisp function help-form-show,
13064 instead of using internal_with_output_to_temp_buffer.
13065 (Qhelp_form_show): New var.
e0d38eeb 13066 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13067
13068 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13069
13070 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13071
e67a13ab
CY
130722011-04-06 Chong Yidong <cyd@stupidchicken.com>
13073
04f2d78b
CB
13074 * process.c (Flist_processes): Remove to Lisp.
13075 (list_processes_1): Delete.
e67a13ab 13076
973f782d
EZ
130772011-04-06 Eli Zaretskii <eliz@gnu.org>
13078
7c106b1e
EZ
13079 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13080
973f782d
EZ
13081 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13082
41cf7d1a 130832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13084
ca23cc88
PE
13085 Fix more problems found by GCC 4.6.0's static checks.
13086
f390e2d5
PE
13087 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13088
42eea0d0
PE
13089 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13090
b69769da 13091 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13092
f9541e84
PE
13093 * xdisp.c (vmessage): Mark as a printf-like function.
13094
13841b55
PE
13095 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13096
c136c10f
PE
13097 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13098
5e2d4a30
PE
13099 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13100 printf-like functions.
13101 (tiff_load): Add casts to remove these marks before passing them
13102 to system-supplied API.
13103
583f48b9
PE
13104 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13105
b25d760e
PE
13106 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13107 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13108 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13109 directly, rather than having caller test rule sign. This avoids
13110 some unnecessary tests.
13111 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13112 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13113 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13114
bc7b6697 13115 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13116 (xfont_open): Avoid unnecessary tests.
bc7b6697 13117
27ccc379
PE
13118 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13119
dcd5c89a
PE
13120 * composite.h, composite.c (composition_gstring_put_cache):
13121 Use EMACS_INT, not int, for length.
13122
b13a45c6
PE
13123 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13124 breaking out part of COMPOSITION_DECODE_RULE.
13125 (COMPOSITION_DECODE_RULE): Use it.
13126 * composite.c (get_composition_id): Remove unused local vars,
13127 by using the new macro.
13128
1e792e4d
PE
13129 * textprop.c (set_text_properties_1): Change while to do-while,
13130 since the condition is always true at first.
13131
dc6c6455 13132 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13133 (interval_deletion_adjustment): Return unsigned value.
13134 All uses changed.
dc6c6455 13135
aba7731a
PE
13136 * process.c (list_processes_1, create_pty, read_process_output):
13137 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13138 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13139 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13140 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13141 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13142
fdfc4bf3
PE
13143 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13144
fca8fe46 13145 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13146 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13147
06a0259a 13148 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13149 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13150 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13151
e7b9e80f
PE
13152 * print.c (print_error_message): Avoid int overflow.
13153
56201685
PE
13154 * font.c (font_list_entities): Redo for clarity,
13155 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13156
78834453 13157 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13158 (font_score): Avoid potential overflow in diff calculation.
78834453 13159
0bc0b309 13160 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13161 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13162
e610eaca
PE
13163 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13164
b895abce
PE
13165 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13166 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13167 can always succeed if overflow has undefined behavior.
13168
1f1d9321 13169 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13170 (wordify): Omit three unnecessary tests.
1f1d9321 13171
c59478bc
PE
13172 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13173 All callers changed. This avoids the need for an unused var.
13174
79b73827
PE
13175 * casefiddle.c (casify_region): Remove var that is set but not used.
13176
a4db5dfe
PE
13177 * dired.c (file_name_completion): Remove var that is set but not used.
13178
43aae36e
PE
13179 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13180
2a47c44d 13181 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13182 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13183
a37c69bf
PE
13184 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13185 Check for integer overflow on size calculations.
13186
328ab8e7
PE
13187 * buffer.c (Fprevious_overlay_change): Remove var that is set
13188 but not used.
13189
e5a2a5cb
PE
13190 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13191 Remove vars that are set but not used.
8d84a6eb 13192 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13193 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13194
a60e5f68
PE
13195 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13196
f661cb61 13197 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13198 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13199
f0397f5a
PE
13200 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13201 that are set but not used.
13202
8664db06 13203 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13204 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13205
6abdaa4a
PE
13206 * xselect.c (x_get_local_selection, x_handle_property_notify):
13207 Remove vars that are set but not used.
13208
0ce7538d 13209 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13210 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13211
9ae848fc
PE
13212 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13213 Remove var that is set but not used.
0b918413
PE
13214 (scroll_bar_windows_size): Now size_t, not int.
13215 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13216 Check for overflow.
9ae848fc 13217
a5a62657
PE
13218 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13219 (map_tty_color) [!defined MSDOS]: Likewise.
13220
5c5cdd39
PE
13221 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13222
66ebf983
PE
13223 * coding.c: Remove vars that are set but not used.
13224 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13225 All callers changed.
13226 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13227 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13228 (decode_coding_charset): Remove vars that are set but not used.
13229
1be4d761
PE
13230 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13231 that is set but not used.
13232
47553fa8
PE
13233 * print.c (print_object): Remove var that is set but not used.
13234
1f7196bf 13235 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13236 The gnulib version avoids calling malloc in the usual case,
13237 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13238 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13239 * filelock.c (current_lock_owner): Likewise.
13240 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13241 * sysdep.c: Include allocator.h, careadlinkat.h.
13242 (emacs_no_realloc_allocator): New static constant.
13243 (emacs_readlink): New function.
fdb61804
PE
13244 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13245 ../lib/careadlinkat.h.
d1fdcab7 13246
f84c17c7
SM
132472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13248
13249 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13250 first non-nil return value).
13251
ef3862ad
JD
132522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13253
13254 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13255 if not defined (Bug#8403).
13256
376a7006
JB
132572011-04-02 Juanma Barranquero <lekktu@gmail.com>
13258
13259 * xdisp.c (display_count_lines): Remove parameter `start',
13260 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13261 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13262 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13263 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13264 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13265 and thereabouts. All callers changed.
13266 (get_per_char_metric): Remove parameter `f', unused since
13267 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13268
6ca3801d
JM
132692011-04-02 Jim Meyering <meyering@redhat.com>
13270
13271 do not dereference NULL upon failed strdup
13272 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13273 (ns_get_family): Likewise.
13274
d8e2b5ba
JB
132752011-04-02 Juanma Barranquero <lekktu@gmail.com>
13276
13277 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13278
8c74fcbd
JD
132792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13280
13281 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13282 later (Bug#8403).
13283
7200d79c
SM
132842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13285
03408648 13286 Add lexical binding.
7200d79c 13287
03408648
SM
13288 * window.c (Ftemp_output_buffer_show): New fun.
13289 (Fsave_window_excursion):
13290 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13291
13292 * lread.c (lisp_file_lexically_bound_p): New function.
13293 (Fload): Bind Qlexical_binding.
13294 (readevalloop): Remove `evalfun' arg.
13295 Bind Qinternal_interpreter_environment.
13296 (Feval_buffer): Bind Qlexical_binding.
13297 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13298 Mark as dynamic.
13299 (syms_of_lread): Declare `lexical-binding'.
13300
13301 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13302
13303 * keyboard.c (eval_dyn): New fun.
13304 (menu_item_eval_property): Use it.
ca105506
SM
13305
13306 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13307
03408648
SM
13308 * fns.c (concat, mapcar1): Accept byte-code-functions.
13309
13310 * eval.c (Fsetq): Handle lexical vars.
13311 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13312 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13313 (FletX, Flet): Obey lexical binding.
13314 (Fcommandp): Handle closures.
13315 (Feval): New `lexical' arg.
13316 (eval_sub): New function extracted from Feval. Use it almost
13317 everywhere where Feval was used. Look up vars in lexical env.
13318 Handle closures.
13319 (Ffunctionp): Move from subr.el.
13320 (Ffuncall): Handle closures.
13321 (apply_lambda): Remove `eval_flags'.
13322 (funcall_lambda): Handle closures and new byte-code-functions.
13323 (Fspecial_variable_p): New function.
13324 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13325 but without exporting it to Lisp.
23aba0ea 13326
23aba0ea 13327 * doc.c (Fdocumentation, store_function_docstring):
03408648 13328 * data.c (Finteractive_form): Handle closures.
23aba0ea 13329
03408648
SM
13330 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13331 interactive spec.
ba83908c 13332
04f2d78b
CB
13333 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13334 New byte-codes.
03408648
SM
13335 (exec_byte_code): New function extracted from Fbyte_code to handle new
13336 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13337
03408648 13338 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13339
03408648 13340 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13341
e2abce01
JB
133422011-03-31 Juanma Barranquero <lekktu@gmail.com>
13343
13344 * xdisp.c (redisplay_internal): Fix prototype.
13345
63696a73 133462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13347
63696a73 13348 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13349 (try_scrolling): Use it when setting scroll_limit.
13350 Limit scrolling to 100 screen lines.
63696a73
EZ
13351 (redisplay_window): Even when falling back on "recentering",
13352 position point in the window according to scroll-conservatively,
13353 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13354
13355 (try_scrolling): When point is above the window, allow searching
13356 as far as scroll_max, or one screenful, to compute vertical
13357 distance from PT to the scroll margin position. This prevents
13358 try_scrolling from unnecessarily failing when
13359 scroll-conservatively is set to a value slightly larger than the
13360 window height. Clean up the case of PT below the margin at bottom
13361 of window: scroll_max can no longer be INT_MAX. When aggressive
13362 scrolling is in use, don't let point enter the opposite scroll
13363 margin as result of the scroll.
13364 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13365 threshold of 100 lines for never-recentering scrolling.
13366
e4cc2dfc
JB
133672011-03-31 Juanma Barranquero <lekktu@gmail.com>
13368
13369 * dispextern.h (move_it_by_lines):
13370 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13371 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13372 (message_log_check_duplicate): Remove parameters `prev_bol' and
13373 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13374 (redisplay_internal): Remove parameter `preserve_echo_area',
13375 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13376
13377 * indent.c (Fvertical_motion):
13378 * window.c (window_scroll_pixel_based, Frecenter):
13379 Don't pass `need_y_p' to `move_it_by_lines'.
13380
1c470562
SM
133812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13382
44f230aa
SM
13383 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13384 steal a few bits to be more compact.
13385 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13386 Remove unneeded casts.
13387
1c470562
SM
13388 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13389
888adce9
ZK
133902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13391
13392 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13393 binding" message (bug#7967).
13394
f838ed7b
PE
133952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13396
77861b95
PE
13397 Fix more problems found by GCC 4.6.0's static checks.
13398
de6dbc14
PE
13399 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13400 Remove unused local var.
13401
f838ed7b
PE
13402 * editfns.c (Fmessage_box): Remove unused local var.
13403
792c7b2b
PE
13404 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13405 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13406 Omit unused local vars.
c499e557 13407 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13408 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13409 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13410 Omit unused local var.
13411
ba0165e1
PE
13412 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13413 Don't assume string length fits in int.
32ad8845 13414 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13415 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13416
3c59b4c9
PE
13417 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13418 instead of alloca (Bug#8344).
13419
a3eed478 13420 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13421 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13422
eb4d412d
PE
13423 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13424
1658b401
PE
13425 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13426 concerns.
13427
13428 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13429
13430 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13431
9a2c6e05
PE
13432 * keyboard.c (syms_of_keyboard): Use the same style as later
13433 in this function when indexing through an array. This also
13434 works around GCC bug 48267.
13435
03d0a109
PE
13436 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13437
44f730c8
PE
13438 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13439
fe75f926
PE
13440 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13441 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13442
ffa8c828
PE
13443 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13444 This avoids undefined behavior on integer overflow, and is a bit
13445 more convenient anyway since it is compared to a size_t variable.
13446
c5101a77
PE
13447 Variadic C functions now count arguments with size_t, not int.
13448 This avoids an unnecessary limitation on 64-bit machines, which
13449 caused (substring ...) to crash on large vectors (Bug#8344).
13450 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13451 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13452 All variadic functions and their callers changed accordingly.
c5101a77
PE
13453 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13454 * data.c (arith_driver, float_arith_driver): Likewise.
13455 * editfns.c (general_insert_function): Likewise.
13456 * eval.c (struct backtrace.nargs, interactive_p)
13457 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13458 (funcall_lambda, mark_backtrace): Likewise.
13459 * fns.c (concat): Likewise.
13460 * frame.c (x_set_frame_parameters): Likewise.
13461 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13462 0 if not found, not -1. All callers changed.
13463
dd3f25f7
PE
13464 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13465 (stack_copy_size): Now size_t, not int.
13466 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13467
461c2ab9
JB
134682011-03-28 Juanma Barranquero <lekktu@gmail.com>
13469
13470 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13471 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13472 All callers changed.
13473
13474 * lisp.h (multibyte_char_to_unibyte):
13475 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13476 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13477 * character.h (CHAR_TO_BYTE8):
13478 * cmds.c (internal_self_insert):
13479 * editfns.c (general_insert_function):
13480 * keymap.c (push_key_description):
13481 * search.c (Freplace_match):
13482 * xdisp.c (message_dolog, set_message_1): All callers changed.
13483
f6d62986
SM
134842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13485
13486 * keyboard.c (safe_run_hook_funcall): New function.
13487 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13488 don't set the hook to nil, but remove the offending function instead.
13489 (Qcommand_hook_internal): Remove, unused.
13490 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13491 Vcommand_hook_internal.
13492
13493 * eval.c (enum run_hooks_condition): Remove.
13494 (funcall_nil, funcall_not): New functions.
13495 (run_hook_with_args): Call each function through a `funcall' argument.
13496 Remove `cond' argument, now redundant.
13497 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13498 (Frun_hook_with_args_until_failure): Adjust accordingly.
13499 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13500
1db5b1ad
JB
135012011-03-28 Juanma Barranquero <lekktu@gmail.com>
13502
13503 * dispextern.h (string_buffer_position): Remove declaration.
13504
13505 * print.c (strout): Remove parameter `multibyte', unused since
13506 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13507
13508 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13509 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13510 All callers changed.
13511
13512 * w32.c (_wsa_errlist): Use braces for struct initializers.
13513
13514 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13515 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13516 All callers changed.
13517 (string_buffer_position): Likewise. Also, make static (it's never
13518 used outside xdisp.c).
13519 (cursor_row_p): Remove parameter `w', unused since
13520 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13521 (decode_mode_spec): Remove parameter `precision', introduced during
13522 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13523 All callers changed.
13524
5ffb62aa
JD
135252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13526
13527 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13528
461c2ab9 135292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13530
13531 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13532 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13533 (ns_update_auto_hide_menu_bar): New functions.
13534 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13535 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13536 ns_constrain_all_frames.
13537 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13538 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13539
5c380ffb
JD
135402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13541
13542 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13543
9af30bdf
GM
135442011-03-27 Glenn Morris <rgm@gnu.org>
13545
13546 * syssignal.h: Replace RETSIGTYPE with void.
13547 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13548 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13549 Replace SIGTYPE with void everywhere.
13550 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13551 * s/template.h (SIGTYPE): Remove commented out definition.
13552
e2abce01
JB
135532011-03-26 Eli Zaretskii <eliz@gnu.org>
13554
13555 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13556 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13557
f868cd8a
JB
135582011-03-26 Juanma Barranquero <lekktu@gmail.com>
13559
59eb0929
JB
13560 * w32.c (read_unc_volume): Use parameter `henum', instead of
13561 global variable `wget_enum_handle'.
13562
13563 * keymap.c (describe_vector): Remove parameters `indices' and
13564 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13565 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13566
f868cd8a
JB
13567 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13568
13569 * keyboard.c (timer_check): Remove parameter `do_it_now',
13570 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13571 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13572 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13573
13574 * keyboard.c (read_char):
13575 * w32menu.c (w32_menu_display_help):
13576 * xmenu.c (show_help_event, menu_help_callback):
13577 Adjust calls to `show_help_echo'.
13578
13579 * gtkutil.c (xg_maybe_add_timer):
13580 * keyboard.c (readable_events):
13581 * process.c (wait_reading_process_output):
13582 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13583
13584 * insdel.c (adjust_markers_gap_motion):
13585 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13586 (gap_left, gap_right): Don't call it.
13587
2ecf6fdb
CY
135882011-03-25 Chong Yidong <cyd@stupidchicken.com>
13589
13590 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13591 incurred during fontification.
13592
6b1f9ba4
JB
135932011-03-25 Juanma Barranquero <lekktu@gmail.com>
13594
13595 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13596 (DEFVAR_PER_BUFFER): Don't pass it.
13597
13598 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13599 (scrolling_window): Don't pass it.
13600
0f4a96b5
JB
136012011-03-25 Juanma Barranquero <lekktu@gmail.com>
13602
13603 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13604
13605 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13606 and `suffix'.
13607 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13608 of variables specific to SELinux and computation of `encoded_absname'.
13609
13610 * image.c (XPutPixel): Remove unused variable `height'.
13611
13612 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13613
13614 * unexw32.c (get_section_info): Remove unused variable `section'.
13615
13616 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13617 (system_process_attributes): Remove unused variable `sess'.
13618 (sys_read): Remove unused variable `err'.
13619
13620 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13621 (w32_wnd_proc): Remove unused variable `isdead'.
13622 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13623 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13624 (x_create_tip_frame): Remove unused variable `tem'.
13625
13626 * w32inevt.c (w32_console_read_socket):
13627 Remove unused variable `no_events'.
13628
13629 * w32term.c (x_draw_composite_glyph_string_foreground):
13630 Remove unused variable `width'.
13631
1149507c
JB
136322011-03-24 Juanma Barranquero <lekktu@gmail.com>
13633
13634 * w32term.c (x_set_glyph_string_clipping):
13635 Don't pass uninitialized region to CombineRgn.
13636
9c88f339
JB
136372011-03-23 Juanma Barranquero <lekktu@gmail.com>
13638
13639 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13640 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13641 (Fx_close_connection): Remove unused variable `i'.
13642
13643 * w32font.c (w32font_draw): Return number of glyphs.
13644 (w32font_open_internal): Remove unused variable `i'.
13645 (w32font_driver): Add missing initializer.
13646
13647 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13648 (fill_in_menu): Remove unused variable `items_added'.
13649
13650 * w32term.c (last_mouse_press_frame): Remove static global variable.
13651 (w32_clip_to_row): Remove unused variable `f'.
13652 (x_delete_terminal): Remove unused variable `i'.
13653
13654 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13655 (NOTHING): Remove unused static global variable.
13656 (uniscribe_check_otf): Remove unused variable `table'.
13657 (uniscribe_font_driver): Add missing initializers.
13658
dee091a3
JD
136592011-03-23 Julien Danjou <julien@danjou.info>
13660
13661 * term.c (Fsuspend_tty, Fresume_tty):
13662 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13663 * window.c (temp_output_buffer_show):
13664 * insdel.c (signal_before_change):
13665 * frame.c (Fhandle_switch_frame):
13666 * fileio.c (Fdo_auto_save):
13667 * emacs.c (Fkill_emacs):
13668 * editfns.c (save_excursion_restore):
13669 * cmds.c (internal_self_insert):
13670 * callint.c (Fcall_interactively):
13671 * buffer.c (Fkill_all_local_variables):
13672 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13673 Use Frun_hooks.
0f4a96b5 13674 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13675 unconditionally since it does the check itself.
dee091a3 13676
2c520ab5 136772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13678
c9c49752
PE
13679 Fix more problems found by GCC 4.5.2's static checks.
13680
8abc3f12
PE
13681 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13682 the first time through the loop, since we know p0 < p1 then.
13683 This also avoids a gcc -Wstrict-overflow warning.
13684
a2d26660
PE
13685 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13686 leading to a memory leak, possible in functions like
13687 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13688 of objects (Bug#8318).
a2d26660 13689
916c72e9
PE
13690 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13691 that could (at least in theory) be that large.
13692
19ab8a18
PE
13693 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13694 This is less likely to overflow, and avoids undefined behavior if
13695 overflow does occur. All callers changed. Use strtoul to scan
13696 for the unsigned long integer.
b7cbbd6f
PE
13697 (pint2hrstr): Simplify and tune code slightly.
13698 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13699
f0641eff
PE
13700 * scroll.c (do_scrolling): Work around GCC bug 48228.
13701 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13702
7f650bb9
PE
13703 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13704 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13705 (validate_x_resource_name): Simplify count usage.
13706 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13707
37dd57d1
PE
13708 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13709 fail (Bug#8306).
81e56e61 13710
699979fc 13711 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13712
401bf9b4
PE
13713 * process.c (Fmake_network_process): Use socklen_t, not int,
13714 where POSIX says socklen_t is required in portable programs.
13715 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13716 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13717 (Fmake_network_process, server_accept_connection):
13718 (wait_reading_process_output, read_process_output):
13719 Likewise.
13720
b93aacde
PE
13721 * process.c: Rename or move locals to avoid shadowing.
13722 (list_processes_1, Fmake_network_process):
13723 (read_process_output_error_handler, exec_sentinel_error_handler):
13724 Rename or move locals.
4dc343ee 13725 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13726 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13727 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13728 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13729 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13730
af8a867c 13731 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13732 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13733 Include tparam.h instead, since it declares them.
af8a867c
PE
13734 * cm.h (PC): Remove extern decl; tparam.h now does this.
13735 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13736 * terminfo.c: Include tparam.h, to check interfaces.
13737 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13738 (tparam): Adjust signature to match interface in tparam.h;
13739 this removes some undefined behavior. Check that outstring and len
13740 are zero, which they always are with Emacs.
13741 * tparam.h (PC, BC, UP): New extern decls.
13742
0248044d 13743 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13744 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13745
8ff096c1 13746 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13747 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13748 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13749 (ftfont_list): Remove unused local.
49eaafba
PE
13750 (get_adstyle_property, ftfont_pattern_entity):
13751 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13752 Rename locals to avoid shadowing.
8ff096c1 13753
e2be39f6
PE
13754 * xfont.c (xfont_list_family): Mark var as initialized.
13755
c9735e30
PE
13756 * xml.c (make_dom): Now static.
13757
8f5201ae
PE
13758 * composite.c (composition_compute_stop_pos): Rename local to
13759 avoid shadowing.
b246f932
PE
13760 (composition_reseat_it): Remove unused locals.
13761 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13762 (composition_update_it): Mark var as initialized.
11b61122
PE
13763 (find_automatic_composition): Mark vars as initialized,
13764 with a FIXME (Bug#8290).
8f5201ae 13765
760fbc2c
PE
13766 character.h: Rename locals to avoid shadowing.
13767 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13768 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13769 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13770 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13771 to avoid shadowing.
13772
ff08eb85
PE
13773 * textprop.c (property_change_between_p): Remove; unused.
13774
fc7bf025
PE
13775 * intervals.c (interval_start_pos): Now static.
13776
235d7abc
PE
13777 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13778
44f230aa
SM
13779 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13780 Rename locals to avoid shadowing.
3e7d6594 13781
50060332
PE
13782 * sound.c (wav_play, au_play, Fplay_sound_internal):
13783 Fix pointer signedness.
d01f234b 13784 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13785 (wav_play): Initialize a variable to 0, to prevent undefined
13786 behavior (Bug#8278).
50060332 13787
c4fc4e30
PE
13788 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13789
918436ed
PE
13790 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13791
c939f91b
PE
13792 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13793 clobbering (Bug#8298).
b9c7f648
PE
13794 * sysdep.c (sys_subshell): Likewise.
13795 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13796
6bd8c144
PE
13797 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13798 This should get cleaned up, so that child_setup has the
13799 same signature on all platforms.
13800
7710357c 13801 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13802 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13803
c59da222
CY
138042011-03-22 Chong Yidong <cyd@stupidchicken.com>
13805
13806 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13807 not to be necessary, and produces flickering.
13808
66b87493
GM
138092011-03-20 Glenn Morris <rgm@gnu.org>
13810
13811 * config.in: Remove file.
13812
45b6f6d5
JB
138132011-03-20 Juanma Barranquero <lekktu@gmail.com>
13814
13815 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13816 are now in src/globals.h.
13817 (syms_of_minibuf): Remove spurious & from previous change.
13818
cd394be1 138192011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13820
13821 * minibuf.c (completing-read-function): New variable.
13822 (completing-read-default): Rename from completing-read.
13823 (completing-read): Call completing-read-function.
13824
b14e3e21
CY
138252011-03-19 Juanma Barranquero <lekktu@gmail.com>
13826
13827 * xfaces.c (Fx_load_color_file):
13828 Read color file from absolute filename (bug#8250).
13829
f2b726e6
JB
138302011-03-19 Juanma Barranquero <lekktu@gmail.com>
13831
13832 * makefile.w32-in: Update dependencies.
13833
09f6ff02
EZ
138342011-03-17 Eli Zaretskii <eliz@gnu.org>
13835
13836 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13837
29a6015a
PE
138382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13839
a3a6c54e
PE
13840 Fix more problems found by GCC 4.5.2's static checks.
13841
b766f867
PE
13842 * process.c (make_serial_process_unwind, send_process_trap):
13843 (sigchld_handler): Now static.
13844
be02381c
PE
13845 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13846 That way, the code declares only the vars that it needs.
13847 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13848 * s/cygwin.h (PTY_ITERATION): Likewise.
13849 * s/darwin.h (PTY_ITERATION): Likewise.
13850 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13851
57048744
PE
13852 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13853 * process.c (allocate_pty): Don't declare stb unless it's needed.
13854
7914961c 13855 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13856 (CONSTANTLIM): Remove; unused.
13857 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13858 Define only if needed.
7914961c 13859
b3967b18
PE
13860 * unexelf.c (unexec): Name an expression,
13861 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13862 Use a different way to cause a compilation error if anyone uses
13863 n rather than nn, a way that does not involve shadowing.
73366a00 13864 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13865
29a6015a
PE
13866 * deps.mk (unexalpha.o): Remove; unused.
13867
43cfc33e 13868 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13869 * unexec.h: New file.
ce701a33
PE
13870 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13871 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13872 Depend on unexec.h.
13873 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13874 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13875 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13876 Change as necessary to match prototype in unexec.h.
ce701a33 13877
01f44d5a
PE
13878 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13879 shadowing.
4f63c6bb 13880 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13881
a6670b0b
PE
13882 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13883 Rename locals to avoid shadowing.
13884
cef2010d 13885 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13886 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13887
d4d7173a
PE
13888 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13889
f08b802a
PE
13890 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13891 warning when compiling print.c.
13892
3ddb0639
PE
13893 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13894 instead of using an uninitialized var.
5ad03b97 13895 (font_sort_entities): Mark var as initialized.
3ddb0639 13896
170a2692
PE
13897 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13898
e663c700
PE
13899 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13900 pointers to constants.
89bc529a 13901 (font_parse_fcname): Remove unused vars.
7b81e2d0 13902 (font_delete_unmatched): Now static.
ea838e10 13903 (font_get_spec): Remove; unused.
13a547c6
PE
13904 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13905 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13906 Rename or move locals to avoid shadowing.
e663c700 13907
2a80c887 13908 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13909 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13910
1384fa33 13911 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13912 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13913
8b2c52e9
PE
13914 * alloc.c (mark_backtrace): Move decl from here ...
13915 * lisp.h: ... to here, so that it can be checked.
13916
475545b5 13917 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13918 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13919 (lisp_indirect_variable): Name an expression,
13920 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13921 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13922
b1349114 13923 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13924 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13925 Use const pointer when appropriate.
b1349114 13926
a2928364
PE
13927 * lisp.h (get_system_name, get_operating_system_release):
13928 Move decls here, to check interfaces.
13929 * process.c (get_operating_system_release): Move decl to lisp.h.
13930 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13931 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13932 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13933 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13934 (Fformat_time_string, Fencode_time, Finsert_char):
13935 (Ftranslate_region_internal, Fformat):
13936 Rename or remove local vars to avoid shadowing.
9710023e 13937 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13938
a415e694
PE
13939 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13940 avoid shadowing.
13941
8ef4622d
PE
13942 * lisp.h (eassert): Check that the argument compiles, even if
13943 ENABLE_CHECKING is not defined.
13944
946f9a5b
PE
13945 * data.c (Findirect_variable): Name an expression, to avoid
13946 gcc -Wbad-function-cast warning.
112396d6 13947 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13948 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13949 (Fmake_variable_buffer_local, Fmake_local_variable):
13950 Mark variables as initialized.
52746918 13951 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13952
e5aab7e7 13953 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13954 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13955 Rename locals to avoid shadowing.
dff45157
PE
13956 (mark_stack): Move local variables into the #ifdef region where
13957 they're used.
7bc26fdb
PE
13958 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13959 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13960 needed otherwise.
13961 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13962 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13963 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13964
e5aab7e7
PE
13965 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13966 avoids undefined behavior in theory.
13967
4da60324
PE
13968 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13969
88043301
PE
13970 Use functions, not macros, for up- and down-casing (Bug#8254).
13971 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13972 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13973 to use the following functions instead of these macros.
13974 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13975 EMACS_INT, since callers assume the returned value fits in int.
13976 (upcase1): Likewise, for UPCASE_TABLE.
13977 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13978 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13979 the race-condition problem in the old DOWNCASE.
88043301 13980
19ed5445
PE
13981 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13982 Rename locals to avoid shadowing.
13983 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13984 (regex_compile, re_search_2, re_match_2_internal):
13985 Remove unused local vars.
952db0d7
PE
13986 (FREE_VAR): Rewrite so as not to use empty "else",
13987 which gcc can warn about.
da053e48 13988 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13989 (RETALLOC_IF): Define only if needed.
13990 (WORDCHAR_P): Likewise. This one is never needed, but is used
13991 only in a comment talking about a compiler bug, so put inside
13992 the #if 0 of that comment.
13993 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13994 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13995 Remove; unused.
19ed5445 13996
1f3561e4 13997 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13998 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13999 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14000
ded6f8f7
PE
14001 * search.c (simple_search): Remove unused var.
14002
dbd37a95
PE
14003 * dired.c (compile_pattern): Move decl from here ...
14004 * lisp.h: ... to here, so that it can be checked.
14005 (struct re_registers): New forward decl.
14006
7e47afad
PE
14007 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14008
85f24f61
PE
14009 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14010 All uses changed.
14011 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14012 Rename locals to avoid shadowing.
5671df8f 14013 (Fvertical_motion): Mark locals as initialized.
85f24f61 14014
181aa2be 14015 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14016 (casify_region): Mark local as initialized.
181aa2be 14017
930d429c
PE
14018 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14019
7082eac6
PE
14020 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14021 New macros, so that the caller can use some names other than
14022 gcpro1, gcpro2, etc.
14023 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14024 of the new macros.
14025 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14026 argument, for consistency with GCPRO2_VAR, etc: it is now the
14027 prefix of the variable, not the variable itself. All uses
14028 changed.
38b2c076
PE
14029 * dired.c (directory_files_internal, file_name_completion):
14030 Rename locals to avoid shadowing.
14031
15206ed9
PE
14032 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14033 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14034 dired.c's scmp function, had undefined behavior.
14035 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14036 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14037 * buffer.h: ... to here, because these macros use current_buffer,
14038 and the new implementation with inline functions needs to have
14039 current_buffer in scope now, rather than later when the macros
14040 are used.
14041 (downcase, upcase1): New static inline functions.
14042 (DOWNCASE, UPCASE1): Reimplement using these functions.
14043 This avoids undefined behavior in expressions like
14044 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14045 from race conditions in accessing the global variables
14046 case_temp1 and case_temp2.
14047 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14048 * lisp.h (case_temp1, case_temp2): Remove their decls.
14049 * character.h (ASCII_CHAR_P): Move from here ...
14050 * lisp.h: ... to here, so that the inline functions mentioned
14051 above can use them.
14052
4a6bea26
PE
14053 * dired.c (directory_files_internal_unwind): Now static.
14054
f14b7e14
PE
14055 * fileio.c (file_name_as_directory, directory_file_name):
14056 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14057 Now static.
2893f146
PE
14058 (file_name_as_directory): Use const pointers when appropriate.
14059 (Fexpand_file_name): Likewise. In particular, newdir might
14060 point at constant storage, so make it a const pointer.
fd4ead52 14061 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14062 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14063 signedness issues.
f839df0c
PE
14064 (Fset_file_times, Finsert_file_contents, auto_save_error):
14065 Rename locals to avoid shadowing.
f14b7e14 14066
5716756e 14067 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14068 (Ftry_completion, Fall_completions): Rename or remove locals
14069 to avoid shadowing.
5716756e 14070
b4c3046a
PE
14071 * marker.c (bytepos_to_charpos): Remove; unused.
14072
b45db522
PE
14073 * lisp.h (verify_bytepos, count_markers): New decls,
14074 so that gcc does not warn that these functions aren't declared.
14075
85876d07
PE
14076 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14077 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14078 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14079 (copy_text): Remove unused local var.
85876d07 14080
03d78a21 14081 * filelock.c (within_one_second): Now static.
b3dd38ab 14082 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14083
5df8f01b
PE
14084 * buffer.c (fix_overlays_before): Mark locals as initialized.
14085 (fix_start_end_in_overlays): Likewise. This function should be
14086 simplified by using pointers-to-pointers, but that's a different
14087 matter.
b1d876f1 14088 (switch_to_buffer_1): Now static.
8f54f30a
PE
14089 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14090 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14091
a70072c9 14092 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14093 Fix pointer signedness issue.
edced198
PE
14094 (sys_subshell): Mark local as volatile if checking for lint,
14095 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14096 (MAXPATHLEN): Define only if needed.
a70072c9 14097
a0977c44
PE
14098 * process.c (serial_open, serial_configure): Move decls from here ...
14099 * systty.h: ... to here, so that they can be checked.
14100
a884fdcc
PE
14101 * fns.c (get_random, seed_random): Move extern decls from here ...
14102 * lisp.h: ... to here, so that they can be checked.
14103
604efe86 14104 * sysdep.c (reset_io): Now static.
b8950c94 14105 (wait_for_termination_signal): Remove; unused.
604efe86 14106
38fc62d9
PE
14107 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14108 (copy_keymap_item, append_key, push_text_char_description):
14109 Now static.
1004a21a 14110 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14111 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14112 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14113 (describe_map_tree):
14114 Rename locals to avoid shadowing.
38fc62d9 14115
2f2650da
PE
14116 * keyboard.c: Declare functions static if they are not used elsewhere.
14117 (echo_char, echo_dash, cmd_error, top_level_2):
14118 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14119 (read_char, kbd_buffer_get_event, make_lispy_position):
14120 (make_lispy_event, make_lispy_movement, apply_modifiers):
14121 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14122 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14123 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14124 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14125 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14126
a053e86c 14127 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14128 (mark_kboards): Move decl here ...
14129 * alloc.c (mark_kboards): ... from here.
a053e86c 14130
4752793e
PE
14131 * lisp.h (force_auto_save_soon): New decl.
14132
74f10ca7 14133 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14134 (DEFINE_DUMMY_FUNCTION): New macro.
14135 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14136 Use it.
c03cd23f
PE
14137 (main): Add casts to avoid warnings
14138 if GCC considers string literals to be constants.
74f10ca7 14139
022e70d4
PE
14140 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14141
59d6fe83
PE
14142 * dbusbind.c: Pointer signedness fixes.
14143 (xd_signature, xd_append_arg, xd_initialize):
14144 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14145 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14146 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14147 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14148
78320123
PE
14149 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14150 if GCC considers string literals to be constants.
49cebcca 14151 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14152
35ac2a97
SM
141532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14154
fb103ca9
SM
14155 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14156 (print_preprocess, print_object): New macro to fix last change.
14157
35ac2a97
SM
14158 * print.c (print_preprocess): Don't forget font objects.
14159
62973b41
JB
141602011-03-16 Juanma Barranquero <lekktu@gmail.com>
14161
14162 * emacs.c (USAGE3): Doc fixes.
14163
0e48bb22
AS
141642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14165
14166 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14167 structure.
14168
7684e57b
JB
141692011-03-14 Juanma Barranquero <lekktu@gmail.com>
14170
14171 * lisp.h (VWindow_system, Qfile_name_history):
14172 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14173 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14174 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14175
14176 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14177 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14178
14179 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14180 * w32console.c (detect_input_pending, read_input_pending)
14181 (encode_terminal_code):
14182 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14183 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14184 (w32_system_caret_y, Qfile_name_history):
14185 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14186 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14187 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14188 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14189 * w32proc.c (Qlocal, report_file_error):
14190 * w32term.c (Vwindow_system, updating_frame):
14191 * w32uniscribe.c (initialized, uniscribe_font_driver):
14192 Remove unneeded extern declarations.
14193
2aa46d6c
CY
141942011-03-14 Chong Yidong <cyd@stupidchicken.com>
14195
c96bbc66 14196 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14197
cffc6f3b
CY
141982011-03-13 Chong Yidong <cyd@stupidchicken.com>
14199
14200 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14201 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14202 These macros can no longer be used for assignment.
14203
44f230aa
SM
14204 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14205 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14206 (record_buffer_markers, fetch_buffer_markers): New functions for
14207 recording and fetching special buffer markers.
14208 (set_buffer_internal_1, set_buffer_temp): Use them.
14209
14210 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14211
14212 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14213
14214 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14215 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14216
14217 * xdisp.c (hscroll_window_tree):
14218 (reconsider_clip_changes): Use PT instead of BUF_PT.
14219
d251f04b
EZ
142202011-03-13 Eli Zaretskii <eliz@gnu.org>
14221
14222 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14223 $(EMACS_ROOT)/lib/intprops.h.
14224
f0c77cd1
PE
142252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14226
3eca4629
PE
14227 Fix more problems found by GCC 4.5.2's static checks.
14228
7c86ee98
PE
14229 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14230 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14231 (xg_free_frame_widgets): Make it clear that a local variable is
14232 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14233 (gdk_window_get_screen): Make it clear that this macro is needed
14234 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14235 (int_gtk_range_get_value): New function, which avoids a diagnostic
14236 from gcc -Wbad-function-cast.
14237 (xg_set_toolkit_scroll_bar_thumb): Use it.
14238 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14239 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14240 (get_utf8_string, xg_get_file_with_chooser):
14241 Rename locals to avoid shadowing.
14242 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14243
41729b81
PE
14244 * xgselect.c (xg_select): Remove unused var.
14245
f0c77cd1
PE
14246 * image.c (four_corners_best): Mark locals as initialized.
14247 (gif_load): Initialize transparent_p to zero (Bug#8238).
14248 Mark another local as initialized.
ec6cf4c6 14249 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14250
ce0ad53d 14251 * image.c (clear_image_cache): Now static.
d5d5a617 14252 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14253 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14254 (x_edge_detection): Remove unnecessary cast that
14255 gcc -Wbad-function-cast diagnoses.
2037898d 14256 (gif_load): Fix pointer signedness.
6ae141d6
PE
14257 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14258 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14259
33383987 142602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14261
d32df629
PE
14262 Improve quality of tests for time stamp overflow.
14263 For example, without this patch (encode-time 0 0 0 1 1
14264 1152921504606846976) returns the obviously-bogus value (-948597
14265 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14266 reports time overflow. See
14267 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14268 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14269 * editfns.c: Include limits.h and intprops.h.
14270 (TIME_T_MIN, TIME_T_MAX): New macros.
14271 (time_overflow): Move earlier, to before first use.
14272 (hi_time, lo_time): New functions, for an accurate test for
14273 out-of-range times.
14274 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14275 (Fget_internal_run_time): Don't assume time_t fits in int.
14276 (make_time): Use list2 instead of Fcons twice.
14277 (Fdecode_time): More accurate test for out-of-range times.
14278 (check_tm_member): New function.
14279 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14280 (lisp_time_argument): Don't rely on undefined left-shift and
14281 right-shift behavior when checking for time stamp overflow.
8be6f318 14282
fe31d94c
PE
14283 * editfns.c (time_overflow): New function, refactoring common code.
14284 (Fformat_time_string, Fdecode_time, Fencode_time):
14285 (Fcurrent_time_string): Use it.
14286
8be6f318
PE
14287 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14288 * dired.c (make_time): Move to ...
14289 * editfns.c (make_time): ... here.
14290 * systime.h: Note the move.
14291
09d9db2c 142922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14293
126bc0dc
YM
14294 * fringe.c (update_window_fringes): Remove unused variables.
14295
c47cbdfd
YM
14296 * unexmacosx.c (copy_data_segment): Also copy __got section.
14297 (Bug#8223)
14298
7ac80be9
EZ
142992011-03-12 Eli Zaretskii <eliz@gnu.org>
14300
c96bbc66 14301 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14302 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14303 Constify `char *' arguments and their references according to
14304 prototypes in tparam.h.
14305
ecb0f94d 14306 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14307
7ac80be9
EZ
14308 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14309 Adapt all references accordingly.
14310
14311 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14312
ef1fd07e
TT
143132011-03-11 Tom Tromey <tromey@redhat.com>
14314
14315 * buffer.c (syms_of_buffer): Remove obsolete comment.
14316
7ef4b50c
EZ
143172011-03-11 Eli Zaretskii <eliz@gnu.org>
14318
14319 * termhooks.h (encode_terminal_code): Declare prototype.
14320
14321 * msdos.c (encode_terminal_code): Don't declare prototype.
14322
14323 * term.c (encode_terminal_code): Now external again, used by
14324 w32console.c and msdos.c.
14325
44f230aa
SM
14326 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14327 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14328
4b1ec863 143292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14330
1714f52b 14331 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14332
4b1ec863
PE
14333 * fringe.c (update_window_fringes): Mark locals as initialized
14334 (Bug#8227).
14335 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14336
524c7aa6
PE
14337 * alloc.c (mark_fringe_data): Move decl from here ...
14338 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14339 to check its interface.
14340 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14341
a5c0af81 14342 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14343 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14344 (fontset_font): Mark local as initialized.
a9a06e0b 14345 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14346
b4716021
PE
14347 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14348
811e9bac 14349 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14350 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14351 (x_own_selection, Fx_disown_selection_internal): Rename locals
14352 to avoid shadowing.
14353 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14354
7e3ab302
PE
14355 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14356 so that the caller can use some name other than gcpro1.
14357 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14358 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14359 (Fx_backspace_delete_keys_p):
14360 Use them to avoid shadowing, and rename vars to avoid shadowing.
14361 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14362 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14363 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14364 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14365 Remove unused locals.
7e3ab302
PE
14366 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14367 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14368 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14369 macros.
f78faa98 14370
e2b13473
PE
14371 * xterm.h (x_mouse_leave): New decl.
14372
77f23912
PE
14373 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14374 Remove unused functions.
cdf4ba58
PE
14375 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14376 (x_calc_absolute_position): Now static.
7411c686 14377 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14378 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14379 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14380 unless they are used.
38d0b34a
PE
14381 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14382 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14383 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14384 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14385 (x_error_catcher, x_connection_closed, x_error_handler):
14386 (x_error_quitter, xembed_send_message, x_iconify_frame):
14387 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14388 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14389 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14390
44f230aa
SM
14391 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14392 Rename or move locals to avoid shadowing.
6b463e58 14393 (tty_defined_color, merge_face_heights): Now static.
5967d051 14394 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14395 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14396 does not deduce is never used uninitialized.
73719eba
PE
14397 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14398 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14399
426994c3 14400 * terminal.c (store_terminal_param): Now static.
5489860b 14401
032f1620 14402 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14403 (set_frame_menubar): Remove unused local.
d4323972 14404 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14405 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14406 since they might point to immutable storage.
281585b0
PE
14407 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14408 since it's unused otherwise.
032f1620 14409
367c19e5 14410 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14411 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14412 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14413 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14414 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14415 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14416 does not deduce are never used uninitialized.
70739cbe 14417
07b48fa9
PE
14418 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14419
8868a238 14420 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14421 * window.c (window_loop, size_window):
14422 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14423
7e5cf297 14424 * window.c (display_buffer): Now static.
d6550a9f
PE
14425 (size_window): Mark variables that gcc -Wuninitialized
14426 does not deduce are never used uninitialized.
a586633d
PE
14427 * window.h (check_all_windows): New decl, to forestall
14428 gcc -Wmissing-prototypes diagnostic.
5b555da1 14429 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14430
f6095868
PE
14431 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14432 shadowing.
14433 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14434 Include <limits.h>.
14435 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14436 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14437 (load_charset_map): Mark variables that gcc -Wuninitialized
14438 does not deduce are never used uninitialized.
53df7c11 14439 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14440
f38b440c
PE
14441 * coding.c (coding_set_source, coding_set_destination):
14442 Use "else { /* comment */ }" rather than "else /* comment */;"
14443 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14444 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14445 a block, when the outer 'i' will do.
14446 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14447 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14448 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14449 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14450 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14451 Rename locals to avoid shadowing.
14452 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14453 * coding.c (emacs_mule_char, encode_invocation_designation):
14454 Now static, since they're not used elsewhere.
413bb2db 14455 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14456 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14457 (decode_coding_emacs_mule): Mark variables that gcc
14458 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14459 (detect_coding_iso_2022): Initialize a local variable that might
14460 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14461 this initialization is needed. (Bug#8211)
5f58e762
PE
14462 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14463 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14464 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14465 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14466 Remove unused macros.
f38b440c 14467
232b38b9 14468 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14469 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14470 * character.c (string_count_byte8): Likewise.
232b38b9 14471
fb90da1b
PE
14472 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14473 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14474
fb93dbc2
PE
14475 * chartab.c (copy_sub_char_table): Now static, since it's not used
14476 elsewhere.
5c156ace
PE
14477 (sub_char_table_ref_and_range, char_table_ref_and_range):
14478 Rename locals to avoid shadowing.
bbcd0949 14479 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14480
7d3b3862 14481 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14482 (BIDI_BOB): Remove unused macro.
7d3b3862 14483
6be7d3da
PE
14484 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14485 deduce are never used uninitialized.
c2ed9c8b 14486 * term.c (encode_terminal_code): Likewise.
6be7d3da 14487
75f8807f 14488 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14489
50938595
PE
14490 * tparam.h: New file.
14491 * term.c, tparam.h: Include it.
14492 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14493 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14494 Move these decls to tparam.h, and make them agree with what
14495 is actually in tparam.c. The previous trick of using incompatible
14496 decls in different modules does not conform to the C standard.
14497 All callers of tparam changed to use tparam's actual API.
14498 * tparam.c (tparam1, tparam, tgoto):
14499 Use const pointers where appropriate.
14500
fbceeba2
PE
14501 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14502 * cm.h (struct cm): Likewise.
14503 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14504 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14505 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14506 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14507 (turn_on_face, init_tty): Likewise.
14508 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14509
7f3f1250
PE
14510 * term.c (term_mouse_position): Rename local to avoid shadowing.
14511
e6ca6543
PE
14512 * alloc.c (mark_ttys): Move decl from here ...
14513 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14514
c40f8d15
AS
145152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14516
14517 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14518
cfe0661d
JB
145192011-03-09 Juanma Barranquero <lekktu@gmail.com>
14520
14521 * search.c (compile_pattern_1): Remove argument regp, unused since
14522 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14523 (compile_pattern): Don't pass it.
14524
0afb4571
J
145252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14526
14527 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14528 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14529 for ! HAVE_GTK3.
14530 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14531
14532 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14533
14534 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14535 gdk_window_get_screen, gdk_window_get_geometry,
14536 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14537 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14538 (xg_get_pixbuf_from_pixmap): New function.
14539 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14540 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14541 Call xg_get_pixbuf_from_pixmap instead of
14542 gdk_pixbuf_get_from_drawable.
14543 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14544 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14545 (xg_check_special_colors): Use GtkStyleContext and its functions
14546 for HAVE_GTK3.
14547 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14548 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14549 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14550 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14551 Call gtk_widget_get_preferred_size.
0afb4571
J
14552 (xg_frame_resized): gdk_window_get_geometry only takes 5
14553 parameters.
44f230aa
SM
14554 (xg_win_to_widget, xg_event_is_for_menubar):
14555 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14556 (xg_set_widget_bg): New function.
14557 (delete_cb): New function.
895009e1 14558 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14559 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14560 (xg_set_background_color): Call xg_set_widget_bg.
14561 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14562 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14563 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14564 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14565 if ! HAVE_GTK3.
14566 (update_frame_tool_bar): Call gtk_widget_hide.
14567 (xg_initialize): Use GDK_KEY_g.
14568
14569 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14570 if ! HAVE_GTK3
14571 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14572
14573 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14574 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14575 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14576
1c2cc4ef
JB
145772011-03-08 Juanma Barranquero <lekktu@gmail.com>
14578
14579 * w32xfns.c (select_palette): Check success of RealizePalette against
14580 GDI_ERROR, not zero.
14581
33383987 14582See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14583
14584;; Local Variables:
14585;; coding: utf-8
aac0c6e3
MR
14586;; End:
14587
2f097256 14588 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14589
14590 This file is part of GNU Emacs.
14591
14592 GNU Emacs is free software: you can redistribute it and/or modify
14593 it under the terms of the GNU General Public License as published by
14594 the Free Software Foundation, either version 3 of the License, or
14595 (at your option) any later version.
14596
14597 GNU Emacs is distributed in the hope that it will be useful,
14598 but WITHOUT ANY WARRANTY; without even the implied warranty of
14599 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14600 GNU General Public License for more details.
14601
14602 You should have received a copy of the GNU General Public License
14603 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.