Fixed bugs in ns_get_family and ns_descriptor_to_entity that were caused by using...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
613052cd
BK
12011-04-16 Ben Key <bkey76@gmail.com>
2
3 * nsfont.m: Fixed bugs in ns_get_family and
4 ns_descriptor_to_entity that were caused by using free to
5 deallocate memory blocks that were allocated by xmalloc (via
6 xstrdup). This caused Emacs to crash when compiled with
7 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8 --enable-checking=xmallocoverrun). xfree is now used to
9 deallocate these memory blocks.
10
4170f62f 112011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12
71b41406
PE
13 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14
9587a89d
PE
15 emacs_write: Accept and return EMACS_INT for sizes.
16 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
17 et seq.
18 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
19 Accept and return EMACS_INT.
20 (emacs_gnutls_write): Return the number of bytes written on
21 partial writes.
22 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
23 (emacs_read, emacs_write): Remove check for negative size, as the
24 Emacs source code has been audited now.
9587a89d
PE
25 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
26 (emacs_read, emacs_write): Use it.
273a5f82
PE
27 * process.c (send_process): Adjust to the new signatures of
28 emacs_write and emacs_gnutls_write. Do not attempt to store
29 a byte offset into an 'int'; it might overflow.
9587a89d 30 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 31
3e047f51
PE
32 * sound.c: Don't assume sizes fit in 'int'.
33 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 34 Return EMACS_INT, not int.
3e047f51 35 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
36 Accept EMACS_INT, not int.
37 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
38 record read return values.
39
cc39a9db
BK
402011-04-15 Ben Key <bkey76@gmail.com>
41
42 * keyboard.c (Qundefined): Don't declare static since it is
43 used in nsfns.m.
44 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
45 declare static since they are used in nsfont.m.
46
6c60eb9f
SM
472011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
48
49 * process.c (Qprocessp): Don't declare static.
50 * lisp.h (Qprocessp): Declare again.
51
7990b61a
JB
522011-04-15 Juanma Barranquero <lekktu@gmail.com>
53
54 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
55
5d4cb038
PE
562011-04-14 Paul Eggert <eggert@cs.ucla.edu>
57
8bd7b830 58 Improve C-level modularity by making more things 'static'.
cd64ea1d 59
e3b27b31
PE
60 Don't publish debugger-only interfaces to other modules.
61 * lisp.h (safe_debug_print, debug_output_compilation_hack):
62 (verify_bytepos, count_markers): Move decls to the only modules
63 that need them.
64 * region-cache.h (pp_cache): Likewise.
65 * window.h (check_all_windows): Likewise.
66 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
67
5d4cb038
PE
68 * sysdep.c (croak): Now static, if
69 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
70 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
71
72 * alloc.c (refill_memory_reserve): Now static if
73 !defined REL_ALLOC || defined SYSTEM_MALLOC.
74 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 75
e87b6180
PE
76 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
77 Define only if USE_LUCID.
78
ac64929e
PE
79 * xrdb.c (x_customization_string, x_rm_string): Now static.
80
6f37259d
PE
81 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
82 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
83
1683e3ab
PE
84 * xdisp.c (draw_row_with_mouse_face): Now static.
85 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
86
de9c2632
PE
87 * window.h (check_all_windows): Mark externally visible.
88
2b96acb7
PE
89 * window.c (window_deletion_count): Now static.
90
91 * undo.c: Make symbols static if they're not exported.
92 (last_undo_buffer, last_boundary_position, pending_boundary):
93 Now static.
94
50436f33
PE
95 * textprop.c (interval_insert_behind_hooks): Now static.
96 (interval_insert_in_front_hooks): Likewise.
97
64520e5c
PE
98 * term.c: Make symbols static if they're not exported.
99 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
100 (max_frame_lines, tty_set_terminal_modes):
101 (tty_reset_terminal_modes, tty_turn_off_highlight):
102 (get_tty_terminal): Now static.
103 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
104 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 105 HAVE_WINDOW_SYSTEM.
64520e5c
PE
106 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
107 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
108
1fa53021
PE
109 * sysdep.c: Make symbols static if they're not exported.
110 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
111 Now static.
112 (sigprocmask_set, full_mask): Remove; unused.
113 (wait_debugging): Mark as visible.
114 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
115 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
116
d4b43b22
PE
117 * syntax.c (syntax_temp): Define only if !__GNUC__.
118
b7c513d0
PE
119 * sound.c (current_sound_device, current_sound): Now static.
120
989b29ad
PE
121 * search.c (searchbufs, searchbuf_head): Now static.
122
13a55a78
PE
123 * scroll.c (scroll_cost): Remove; unused.
124 * dispextern.h (scroll_cost): Remove decl.
125
de68a1fc
PE
126 * region-cache.h (pp_cache): Mark as externally visible.
127
40ccffa6
PE
128 * process.c: Make symbols static if they're not exported.
129 (process_tick, update_tick, create_process, chan_process):
130 (Vprocess_alist, proc_buffered_char, datagram_access):
131 (fd_callback_data, send_process_frame, process_sent_to): Now static.
132 (deactivate_process): Mark defn as static, as well as decl.
133 * lisp.h (create_process): Remove decl.
134 * process.h (chan_process, Vprocess_alist): Remove decls.
135
ad64fc97
PE
136 * print.c: Make symbols static if they're not exported.
137 (print_depth, new_backquote_output, being_printed, print_buffer):
138 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
139 (print_interval, print_number_index, initial_stderr_stream):
140 Now static.
141 * lisp.h (Fprinc): Remove decl.
142 (debug_output_compilation_hack): Mark as externally visible.
143
adddb265
PE
144 * sysdep.c (croak): Move decl from here to syssignal.h.
145 * syssignal.h (croak): Put it here, so the API can be checked when
146 'croak' is called from dissociate_if_controlling_tty.
147
1717ede2
PE
148 * minibuf.c: Make symbols static if they're not exported.
149 (minibuf_save_list, choose_minibuf_frame): Now static.
150 * lisp.h (choose_minibuf_frame): Remove decl.
151
fa5fb2bc
PE
152 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
153
1e3890d1
PE
154 * lread.c: Make symbols static if they're not exported.
155 (read_objects, initial_obarray, oblookup_last_bucket_number):
156 Now static.
157 (make_symbol): Remove; unused.
158 * lisp.h (initial_obarray, make_symbol): Remove decls.
159
8a1414fa
PE
160 * keyboard.c: Make symbols static if they're not exported.
161 (single_kboard, recent_keys_index, total_keys, recent_keys):
162 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
163 (this_single_command_key_start, echoing, last_auto_save):
164 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
165 (command_loop, echo_now, keyboard_init_hook, help_char_p):
166 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
167 (Vlispy_mouse_stem, double_click_count):
168 Now static.
169 (force_auto_save_soon): Define only if SIGDANGER.
170 (ignore_mouse_drag_p): Now static if
171 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
172 (print_help): Remove; unused.
173 (stop_character, last_timer_event): Mark as externally visible.
174 * keyboard.h (ignore_mouse_drag_p): Declare only if
175 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
176 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
177 * lisp.h (echoing): Remove decl.
178 (force_auto_save_soon): Declare only if SIGDANGER.
179 * xdisp.c (redisplay_window): Simplify code, to make it more
180 obvious that ignore_mouse_drag_p is not accessed if !defined
181 USE_GTK && !defined HAVE_NS.
182
93ea6e8f
PE
183 * intervals.c: Make symbols static if they're not exported.
184 (merge_properties_sticky, merge_interval_right, delete_interval):
185 Now static.
186 * intervals.h (merge_interval_right, delete_interval): Remove decls.
187
77382fcc
PE
188 * insdel.c: Make symbols static if they're not exported.
189 However, leave prepare_to_modify_buffer alone. It's never
190 called from outside this function, but that appears to be a bug.
191 (combine_after_change_list, combine_after_change_buffer):
4889fc82 192 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
193 (adjust_after_replace_noundo): Remove; unused.
194 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 195 (signal_before_change): Remove decls.
77382fcc 196
9306c32e
PE
197 * indent.c (val_compute_motion, val_vmotion): Now static.
198
cd44d2eb
PE
199 * image.c: Make symbols static if they're not exported.
200 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
201 if USE_GTK.
202 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
203 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
204
ad9a7a06
PE
205 * fringe.c (standard_bitmaps): Now static.
206 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
207
81626931
PE
208 * frame.c: Make symbols static if they're not exported.
209 (x_report_frame_params, make_terminal_frame): Now static.
210 (get_frame_param): Now static, unless HAVE_NS.
211 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
212 (x_get_resource_string): Remove; not used.
213 * frame.h (make_terminal_frame, x_report_frame_params):
214 (x_get_resource_string); Remove decls.
215 (x_fullscreen_adjust): Declare only if WINDOWSNT.
216 * lisp.h (get_frame_param): Declare only if HAVE_NS.
217
239f9db9
PE
218 * font.c, fontset.c: Make symbols static if they're not exported.
219 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
220 (FACE_SUITABLE_FOR_CHAR_P): Use it.
221 * font.c (font_close_object): Now static.
222 * font.h (font_close_object): Remove.
223 * fontset.c (FONTSET_OBJLIST): Remove.
224 (free_realized_fontset) #if-0 the body, which does nothing.
225 (face_suitable_for_char_p): #if-0, as it's never called.
226 * fontset.h (face_suitable_for_char_p): Remove decl.
227 * xfaces.c (face_at_string_position): Use
228 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
229 since 0 is always ASCII.
230
dfcf3579
PE
231 * fns.c (weak_hash_tables): Now static.
232
5045092b
PE
233 * fileio.c: Make symbols static if they're not exported.
234 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
235 (Vwrite_region_annotation_buffers): Now static.
236
57a96f5c
PE
237 * eval.c: Make symbols static if they're not exported.
238 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
239 * lisp.h (backtrace_list): Remove decl.
240
35f08c38
PE
241 * emacs.c: Make symbols static if they're not exported.
242 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
243 (fatal_error_code, fatal_error_signal_hook, standard_args):
244 Now static.
245 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
246 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
247 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
248 * lisp.h (fatal_error_signal_hook): Remove decl.
249 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
250
f44bd759
PE
251 * editfns.c: Move a (normally-unused) function to its only use.
252 * editfns.c, lisp.h (get_operating_system_release): Remove.
253 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
254 worth the hassle of breaking this out.
255
b532497d
PE
256 * xterm.c: Make symbols static if they're not exported.
257 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
258 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
259 (x_destroy_window, x_delete_display):
260 Now static.
261 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
262 (x_mouse_leave): Remove; unused.
263 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
264 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
265 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
266 Remove decls.
267 (x_mouse_leave): Declare only if WINDOWSNT.
268 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
269 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
270 USE_X_TOOLKIT.
271
1675728f
PE
272 * ftxfont.c: Make symbols static if they're not exported.
273 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
274 HAVE_FREETYPE.
275 * font.h (ftxfont_driver): Likewise.
276
e4cebfca
PE
277 * xfns.c: Make symbols static if they're not exported.
278 (x_last_font_name, x_display_info_for_name):
279 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
280 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
281 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
282 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
283 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
284 (last_show_tip_args): Now static.
285 (xic_defaut_fontset, xic_create_fontsetname): Define only if
286 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
287 (x_screen_planes): Remove; unused.
288 * dispextern.h (x_screen_planes): Remove decl.
289
5bf46f05
PE
290 * dispnew.c: Make symbols static if they're not exported.
291 * dispextern.h (redraw_garbaged_frames, scrolling):
292 (increment_row_positions): Remove.
293 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
294 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
295 Now static.
296 (redraw_garbaged_frames): Remove; unused.
297
435f4c28
PE
298 * xfaces.c: Make symbols static if they're not exported.
299 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
300 Remove decls.
301 * xterm.h (defined_color): Remove decls.
302 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
303 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
304 (menu_face_changed_default, defined_color, free_realized_face):
305 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
306 (ascii_face_of_lisp_face): Remove; unused.
307
8524aef3
PE
308 * xdisp.c: Make symbols static if they're not exported.
309 * dispextern.h (scratch_glyph_row, window_box_edges):
310 (glyph_to_pixel_coords, set_cursor_from_row):
311 (get_next_display_element, set_iterator_to_next):
312 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
313 (show_mouse_face): Remove decls
314 * frame.h (message_buf_print): Likewise.
315 * lisp.h (pop_message, set_message, check_point_in_composition):
316 Likewise.
317 * xterm.h (set_vertical_scroll_bar): Likewise.
318 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
319 (message_buf_print, scratch_glyph_row, displayed_buffer):
320 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
321 (get_next_display_element, show_mouse_face, window_box_edges):
322 (frame_to_window_pixel_xy, check_point_in_composition):
323 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
324 (glyph_to_pixel_coords): Remove; unused.
325
16390cd2
PE
326 * dired.c (file_name_completion): Now static.
327
328 * dbusbind.c (xd_in_read_queued_messages): Now static.
329
a25f4dfa
PE
330 * lisp.h (circular_list_error, FOREACH): Remove; unused.
331 * data.c (circular_list_error): Remove.
332
14a9c8df
PE
333 * commands.h (last_point_position, last_point_position_buffer):
334 (last_point_position_window): Remove decls.
335 * keyboard.c: Make these variables static.
336
74ab6df5
PE
337 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
338 decls.
339 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
340 (iso_code_class, detect_coding, code_convert_region): Now static.
341 (encode_coding_gap): Remove; unused.
342
38dfbee1
PE
343 * chartab.c (chartab_chars, chartab_bits): Now static.
344
a2cb4e63
PE
345 * charset.h (charset_iso_8859_1): Remove decl.
346 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
347 Now static.
348
127198fd
PE
349 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
350 * ccl.c (Vccl_program_table): Now static.
351 (check_ccl_update): Remove; unused.
352
d85b608f
PE
353 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
354 * category.h: ... from here.
355 * category.c (check_category_table, set_category_set): Now static.
356
31cd66f3
PE
357 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
358 * lisp.h: Remove these decls.
359
c358e587
PE
360 * buffer.c (buffer_count): Remove unused var.
361
e78aecca
PE
362 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
363 so that it's not optimized away.
364 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
365 * dispextern.h (bidi_dump_cached_states): Remove, since it's
366 exported only to the debugger.
367
e192d7d3
PE
368 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
369 * atimer.h (run_all_atimers): Removed; not exported.
370
92470028
PE
371 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
372 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
373 was inaccessible from Lisp.
374 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
375 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
376
244ed907
PE
377 alloc.c: Import and export fewer symbols, and remove unused items.
378 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
379 is defined.
380 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
381 it's not optimized away by whole-program optimization.
382 (message_enable_multibyte, free_misc): Remove.
383 (catchlist, handlerlist, mark_backtrace):
384 Declare only if BYTE_MARK_STACK.
385 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
386 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
387 (message_enable_multibyte): Remove decl.
388 (free_misc, interval_free_list, float_block, float_block_index):
389 (n_float_blocks, float_free_list, cons_block, cons_block_index):
390 (cons_free_list, last_marked_index):
391 Now static.
392 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
393 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
394 (mark_backtrace): Define only if BYTE_MARK_STACK.
395 * xdisp.c (message_enable_multibyte): Now static.
396
955cbe7b
PE
397 Declare Lisp_Object Q* variables to be 'static' if not exproted.
398 This makes it easier for human readers (and static analyzers)
399 to see whether these variables are used from other modules.
400 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
401 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
402 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
403 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
404 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
405 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
406 * xmenu.c, xselect.c:
407 Declare Q* vars static if they are not used in other modules.
408 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
409 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
410 Remove decls of unexported vars.
411 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
412
95c82688
PE
413 * lisp.h (DEFINE_FUNC): Make sname 'static'.
414
16a97296
PE
415 Make Emacs functions such as Fatom 'static' by default.
416 This makes it easier for human readers (and static analyzers)
417 to see whether these functions can be called from other modules.
418 DEFUN now defines a static function. To make the function external
419 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
420 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
421 (Finit_image_library):
16a97296
PE
422 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
423 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
424 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
425 Remove decls, since these functions are now static.
426 (Funintern, Fget_internal_run_time): New decls, since these functions
427 were already external.
95c82688 428
16a97296
PE
429 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
430 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
431 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
432 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
433 * keyboard.c, keymap.c, lread.c:
434 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
435 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
436 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
437 Mark functions with DEFUE instead of DEFUN,
438 if they are used in other modules.
439 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
440 decls for now-static functions.
441 * buffer.h (Fdelete_overlay): Remove decl.
442 * callproc.c (Fgetenv_internal): Mark as internal.
443 * composite.c (Fremove_list_of_text_properties): Remove decl.
444 (Fcomposition_get_gstring): New forward static decl.
445 * composite.h (Fcomposite_get_gstring): Remove decl.
446 * dired.c (Ffile_attributes): New forward static decl.
447 * doc.c (Fdocumntation_property): New forward static decl.
448 * eval.c (Ffetch_bytecode): New forward static decl.
449 (Funintern): Remove extern decl; now in .h file where it belongs.
450 * fileio.c (Fmake_symbolic_link): New forward static decl.
451 * image.c (Finit_image_library): New forward static decl.
452 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
453 * intervals.h (Fprevious_property_change):
454 (Fremove_list_of_text_properties): Remove decls.
455 * keyboard.c (Fthis_command_keys): Remove decl.
456 (Fcommand_execute): New forward static decl.
457 * keymap.c (Flookup_key): New forward static decl.
458 (Fcopy_keymap): Now static.
459 * keymap.h (Flookup_key): Remove decl.
460 * process.c (Fget_process): New forward static decl.
461 (Fprocess_datagram_address): Mark as internal.
462 * syntax.c (Fsyntax_table_p): New forward static decl.
463 (skip_chars): Remove duplicate decl.
464 * textprop.c (Fprevious_property_change): New forward static decl.
465 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
466 Now internal.
467 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
468 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
469
785bbd42
PE
470 * editfns.c (Fformat): Remove unreachable code.
471
8b913b57
AS
4722011-04-14 Andreas Schwab <schwab@linux-m68k.org>
473
474 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
475 change. (Bug#8496)
476
a6744a35
EZ
4772011-04-13 Eli Zaretskii <eliz@gnu.org>
478
479 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
480 when at ZV. (Bug#8487)
481
e7974947
AS
4822011-04-12 Andreas Schwab <schwab@linux-m68k.org>
483
baad03f0
AS
484 * charset.c (Fclear_charset_maps): Use xfree instead of free.
485 (Bug#8437)
486 * keyboard.c (parse_tool_bar_item): Likewise.
487 * sound.c (sound_cleanup, alsa_close): Likewise.
488 * termcap.c (tgetent): Likewise.
489 * xfns.c (x_default_font_parameter): Likewise.
490 * xsettings.c (read_and_apply_settings): Likewise.
491
e7974947
AS
492 * alloc.c (overrun_check_malloc, overrun_check_realloc)
493 (overrun_check_free): Protoize.
494
28272684
PE
4952011-04-12 Paul Eggert <eggert@cs.ucla.edu>
496
497 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
498 since callers should never pass a negative size.
499 Change the signature to match that of plain 'read' and 'write'; see
500 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
501 * lisp.h: Update prototypes of emacs_write and emacs_read.
502
11997c76
EZ
5032011-04-11 Eli Zaretskii <eliz@gnu.org>
504
505 * xdisp.c (redisplay_window): Don't try to determine the character
506 position of the scroll margin if the window start point w->startp
e896f03c 507 is outside the buffer's accessible region. (Bug#8468)
11997c76 508
8a2cbd72
EZ
5092011-04-10 Eli Zaretskii <eliz@gnu.org>
510
511 Fix write-region and its subroutines for buffers > 2GB.
512 * fileio.c (a_write, e_write): Modify declaration of arguments and
513 local variables to support buffers larger than 2GB.
514 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
515
516 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
517 argument, local variables, and return value.
518
519 * lisp.h: Update prototypes of emacs_write and emacs_read.
520
521 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
522
4073e537 5232011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 524
1ebfdcb6
PE
525 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
526
b2ded58d
PE
527 Fix more problems found by GCC 4.6.0's static checks.
528
7d66342c
PE
529 * xdisp.c (vmessage): Use a better test for character truncation.
530
bbf47d44
PE
531 * charset.c (load_charset_map): <, not <=, for optimization,
532 and to avoid potential problems with integer overflow.
9248994d 533 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 534 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 535 * editfns.c (Fformat): Likewise.
1e69125e 536 * syntax.c (skip_chars): Likewise.
3befa583 537
e3019616
PE
538 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
539 This also lets GCC 4.6.0 generate slightly better loop code.
540
becfa255
PE
541 * callint.c (Fcall_interactively): <, not <=, for optimization.
542 (Fcall_interactively): Count the number of arguments produced,
543 not the number of arguments given. This is simpler and lets GCC
544 4.6.0 generate slightly better code.
545
dae0cd48
PE
546 * ftfont.c: Distingish more carefully between FcChar8 and char.
547 The previous code passed unsigned char * to a functions like
548 strlen and xstrcasecmp that expect char *, which does not
549 conform to the C standard.
550 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
551 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
552 char * when the C standard requires it.
553
76032d70
PE
554 * keyboard.c (read_char): Remove unused var.
555
eb3f1cc8
PE
556 * eval.c: Port to Windows vsnprintf (Bug#8435).
557 Include <limits.h>.
558 (SIZE_MAX): Define if the headers do not.
559 (verror): Do not give up if vsnprintf returns a negative count.
560 Instead, grow the buffer. This ports to Windows vsnprintf, which
561 does not conform to C99. Problem reported by Eli Zaretskii.
562 Also, simplify the allocation scheme, by avoiding the need for
563 calling realloc, and removing the ALLOCATED variable.
564
70476b54
PE
565 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
566
12020a9e
PE
567 Remove invocations of doprnt, as Emacs now uses vsnprintf.
568 But keep the doprint source code for now, as we might revamp it
569 and use it again (Bug#8435).
ea6c7ae6
PE
570 * lisp.h (doprnt): Remove.
571 * Makefile.in (base_obj): Remove doprnt.o.
572 * deps.mk (doprnt.o): Remove.
573
5fdb398c
PE
574 error: Print 32- and 64-bit integers portably (Bug#8435).
575 Without this change, on typical 64-bit hosts error ("...%d...", N)
576 was used to print both 32- and 64-bit integers N, which relied on
577 undefined behavior.
578 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
579 New macro.
580 * lisp.h (error, verror): Mark as printf-like functions.
581 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
582 Report overflow in size calculations when allocating printf buffer.
583 Do not truncate output string at its first null byte.
584 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
585 Truncate the output at a character boundary, since vsnprintf does not
586 do that.
587 * charset.c (check_iso_charset_parameter): Convert internal
588 character to string before calling 'error', since %c now has the
589 printf meaning.
590 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
591 overflow when computing char to be passed to 'error'. Do not
592 pass Lisp_Object to 'error'; pass the integer instead.
593 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
594 formatted with plain %d.
595
b189fa66
PE
596 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
597
bff87ef0
PE
598 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
599
7e2cac20
PE
600 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
601
ce4d90b5
PE
602 * xterm.c (x_catch_errors): Remove duplicate declaration.
603
266c9547
PE
604 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
605
79c49ad2
PE
606 * xdisp.c, lisp.h (message_nolog): Remove; unused.
607
368f4090
JM
6082011-04-10 Jim Meyering <meyering@redhat.com>
609
610 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
611 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
612 return ssize_t not "int", and use size_t as the buffer length.
613 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
614 * gnutls.h: Update declarations.
615 * process.c (read_process_output): Use ssize_t, to match.
616 (send_process): Likewise.
617
a32d4040
CY
6182011-04-09 Chong Yidong <cyd@stupidchicken.com>
619
620 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
621
8546720e 6222011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 623
8546720e
GM
624 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
625 unsigned char, to match FcChar8 type definition.
aac0c6e3 626
8546720e
GM
627 * xterm.c (handle_one_xevent):
628 * xmenu.c (create_and_show_popup_menu):
629 * xselect.c (x_decline_selection_request)
630 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 631
0a2f5c1a 6322011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
633
634 Fix some uses of `int' instead of EMACS_INT.
635 * search.c (string_match_1, fast_string_match)
636 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
637 (scan_buffer, find_next_newline_no_quit)
638 (find_before_next_newline, search_command, Freplace_match)
639 (Fmatch_data): Make some `int' variables be EMACS_INT.
640
641 * xdisp.c (display_count_lines): 3rd argument and return value now
642 EMACS_INT. All callers changed.
643 (pint2hrstr): Last argument is now EMACS_INT.
644
645 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
646 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
647 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
648 (decode_coding_utf_16, decode_coding_emacs_mule)
649 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
650 (decode_coding_ccl, decode_coding_charset)
651 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
652 (decode_coding_iso_2022, decode_coding_emacs_mule)
653 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
654 <char_offset, last_offset>: Declare EMACS_INT.
655 (encode_coding_utf_8, encode_coding_utf_16)
656 (encode_coding_emacs_mule, encode_invocation_designation)
657 (encode_designation_at_bol, encode_coding_iso_2022)
658 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
659 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
660 Declare EMACS_INT.
661 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
662 (encode_invocation_designation): Last argument P_NCHARS is now
663 EMACS_INT.
664 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
665 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
666
667 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
668 All users changed.
669
670 * ccl.c (Fccl_execute_on_string): Declare some variables
671 EMACS_INT.
672
8546720e 6732011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
674
675 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
676
4e19a977
CS
6772011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
678
679 * process.c (Fformat_network_address): Doc fix.
680
87302331
R
6812011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
682
683 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
684
cbb59342
CY
6852011-04-08 Chong Yidong <cyd@stupidchicken.com>
686
687 * keyboard.c (read_char): Call Lisp function help-form-show,
688 instead of using internal_with_output_to_temp_buffer.
689 (Qhelp_form_show): New var.
e0d38eeb 690 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
691
692 * print.c (internal_with_output_to_temp_buffer): Function deleted.
693
694 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
695
e67a13ab
CY
6962011-04-06 Chong Yidong <cyd@stupidchicken.com>
697
698 * process.c (Flist_processes): Removed to Lisp.
699 (list_processes_1): Deleted.
700
973f782d
EZ
7012011-04-06 Eli Zaretskii <eliz@gnu.org>
702
7c106b1e
EZ
703 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
704
973f782d
EZ
705 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
706
41cf7d1a 7072011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 708
ca23cc88
PE
709 Fix more problems found by GCC 4.6.0's static checks.
710
f390e2d5
PE
711 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
712
42eea0d0
PE
713 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
714
b69769da 715 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 716
f9541e84
PE
717 * xdisp.c (vmessage): Mark as a printf-like function.
718
13841b55
PE
719 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
720
c136c10f
PE
721 * sound.c (sound_warning): Don't crash if arg contains a printf format.
722
5e2d4a30
PE
723 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
724 printf-like functions.
725 (tiff_load): Add casts to remove these marks before passing them
726 to system-supplied API.
727
583f48b9
PE
728 * eval.c (Fsignal): Remove excess argument to 'fatal'.
729
b25d760e
PE
730 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
731 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
732 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
733 directly, rather than having caller test rule sign. This avoids
734 some unnecessary tests.
735 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
736 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
737 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 738
bc7b6697 739 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 740 (xfont_open): Avoid unnecessary tests.
bc7b6697 741
27ccc379
PE
742 * composite.c (composition_gstring_put_cache): Use unsigned integer.
743
dcd5c89a
PE
744 * composite.h, composite.c (composition_gstring_put_cache):
745 Use EMACS_INT, not int, for length.
746
b13a45c6
PE
747 * composite.h (COMPOSITION_DECODE_REFS): New macro,
748 breaking out part of COMPOSITION_DECODE_RULE.
749 (COMPOSITION_DECODE_RULE): Use it.
750 * composite.c (get_composition_id): Remove unused local vars,
751 by using the new macro.
752
1e792e4d
PE
753 * textprop.c (set_text_properties_1): Change while to do-while,
754 since the condition is always true at first.
755
dc6c6455 756 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
757 (interval_deletion_adjustment): Return unsigned value.
758 All uses changed.
dc6c6455 759
aba7731a
PE
760 * process.c (list_processes_1, create_pty, read_process_output):
761 (exec_sentinel): Remove vars that were set but not used.
afd4052b 762 (create_pty): Remove unnecessary "volatile"s.
bc57d757 763 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 764 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 765 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 766
fdfc4bf3
PE
767 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
768
fca8fe46 769 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 770 (update_syntax_table): Use unsigned instead of int.
fca8fe46 771
06a0259a 772 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 773 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 774 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 775
e7b9e80f
PE
776 * print.c (print_error_message): Avoid int overflow.
777
56201685
PE
778 * font.c (font_list_entities): Redo for clarity,
779 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
780
78834453 781 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 782 (font_score): Avoid potential overflow in diff calculation.
78834453 783
0bc0b309 784 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 785 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 786
e610eaca
PE
787 * eval.c (funcall_lambda): Rename local to avoid shadowing.
788
b895abce
PE
789 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
790 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
791 can always succeed if overflow has undefined behavior.
792
1f1d9321 793 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 794 (wordify): Omit three unnecessary tests.
1f1d9321 795
c59478bc
PE
796 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
797 All callers changed. This avoids the need for an unused var.
798
79b73827
PE
799 * casefiddle.c (casify_region): Remove var that is set but not used.
800
a4db5dfe
PE
801 * dired.c (file_name_completion): Remove var that is set but not used.
802
43aae36e
PE
803 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
804
2a47c44d 805 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 806 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 807
a37c69bf
PE
808 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
809 Check for integer overflow on size calculations.
810
328ab8e7
PE
811 * buffer.c (Fprevious_overlay_change): Remove var that is set
812 but not used.
813
e5a2a5cb
PE
814 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
815 Remove vars that are set but not used.
8d84a6eb 816 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 817 (timer_check_2): Mark vars as initialized.
e5a2a5cb 818
a60e5f68
PE
819 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
820
f661cb61 821 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 822 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 823
f0397f5a
PE
824 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
825 that are set but not used.
826
8664db06 827 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 828 if XCreateBitmapFromData fails (Bug#8410).
8664db06 829
6abdaa4a
PE
830 * xselect.c (x_get_local_selection, x_handle_property_notify):
831 Remove vars that are set but not used.
832
0ce7538d 833 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 834 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 835
9ae848fc
PE
836 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
837 Remove var that is set but not used.
0b918413
PE
838 (scroll_bar_windows_size): Now size_t, not int.
839 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
840 Check for overflow.
9ae848fc 841
a5a62657
PE
842 * xfaces.c (realize_named_face): Remove vars that are set but not used.
843 (map_tty_color) [!defined MSDOS]: Likewise.
844
5c5cdd39
PE
845 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
846
66ebf983
PE
847 * coding.c: Remove vars that are set but not used.
848 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
849 All callers changed.
850 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
851 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
852 (decode_coding_charset): Remove vars that are set but not used.
853
1be4d761
PE
854 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
855 that is set but not used.
856
47553fa8
PE
857 * print.c (print_object): Remove var that is set but not used.
858
1f7196bf 859 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
860 The gnulib version avoids calling malloc in the usual case,
861 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
862 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
863 * filelock.c (current_lock_owner): Likewise.
864 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
865 * sysdep.c: Include allocator.h, careadlinkat.h.
866 (emacs_no_realloc_allocator): New static constant.
867 (emacs_readlink): New function.
fdb61804
PE
868 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
869 ../lib/careadlinkat.h.
d1fdcab7 870
f84c17c7
SM
8712011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
872
873 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
874 first non-nil return value).
875
ef3862ad
JD
8762011-04-03 Jan Djärv <jan.h.d@swipnet.se>
877
878 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
879 if not defined (Bug#8403).
880
376a7006
JB
8812011-04-02 Juanma Barranquero <lekktu@gmail.com>
882
883 * xdisp.c (display_count_lines): Remove parameter `start',
884 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
885 (get_char_face_and_encoding): Remove parameter `multibyte_p',
886 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
887 (fill_stretch_glyph_string): Remove parameters `row' and `area',
888 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
889 and thereabouts. All callers changed.
890 (get_per_char_metric): Remove parameter `f', unused since
891 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
892
6ca3801d
JM
8932011-04-02 Jim Meyering <meyering@redhat.com>
894
895 do not dereference NULL upon failed strdup
896 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
897 (ns_get_family): Likewise.
898
d8e2b5ba
JB
8992011-04-02 Juanma Barranquero <lekktu@gmail.com>
900
901 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
902
8c74fcbd
JD
9032011-04-02 Jan Djärv <jan.h.d@swipnet.se>
904
905 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
906 later (Bug#8403).
907
7200d79c
SM
9082011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
909
03408648 910 Add lexical binding.
7200d79c 911
03408648
SM
912 * window.c (Ftemp_output_buffer_show): New fun.
913 (Fsave_window_excursion):
914 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
915
916 * lread.c (lisp_file_lexically_bound_p): New function.
917 (Fload): Bind Qlexical_binding.
918 (readevalloop): Remove `evalfun' arg.
919 Bind Qinternal_interpreter_environment.
920 (Feval_buffer): Bind Qlexical_binding.
921 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
922 Mark as dynamic.
923 (syms_of_lread): Declare `lexical-binding'.
924
925 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
926
927 * keyboard.c (eval_dyn): New fun.
928 (menu_item_eval_property): Use it.
ca105506
SM
929
930 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 931
03408648
SM
932 * fns.c (concat, mapcar1): Accept byte-code-functions.
933
934 * eval.c (Fsetq): Handle lexical vars.
935 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
936 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
937 (FletX, Flet): Obey lexical binding.
938 (Fcommandp): Handle closures.
939 (Feval): New `lexical' arg.
940 (eval_sub): New function extracted from Feval. Use it almost
941 everywhere where Feval was used. Look up vars in lexical env.
942 Handle closures.
943 (Ffunctionp): Move from subr.el.
944 (Ffuncall): Handle closures.
945 (apply_lambda): Remove `eval_flags'.
946 (funcall_lambda): Handle closures and new byte-code-functions.
947 (Fspecial_variable_p): New function.
948 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
949 but without exporting it to Lisp.
23aba0ea 950
23aba0ea 951 * doc.c (Fdocumentation, store_function_docstring):
03408648 952 * data.c (Finteractive_form): Handle closures.
23aba0ea 953
03408648
SM
954 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
955 interactive spec.
ba83908c 956
03408648
SM
957 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
958 byte-codes.
959 (exec_byte_code): New function extracted from Fbyte_code to handle new
960 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 961
03408648 962 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 963
03408648 964 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 965
e2abce01
JB
9662011-03-31 Juanma Barranquero <lekktu@gmail.com>
967
968 * xdisp.c (redisplay_internal): Fix prototype.
969
63696a73 9702011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 971
63696a73
EZ
972 * xdisp.c (SCROLL_LIMIT): New macro.
973 (try_scrolling): Use it when setting scroll_limit. Limit
974 scrolling to 100 screen lines.
975 (redisplay_window): Even when falling back on "recentering",
976 position point in the window according to scroll-conservatively,
977 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
978
979 (try_scrolling): When point is above the window, allow searching
980 as far as scroll_max, or one screenful, to compute vertical
981 distance from PT to the scroll margin position. This prevents
982 try_scrolling from unnecessarily failing when
983 scroll-conservatively is set to a value slightly larger than the
984 window height. Clean up the case of PT below the margin at bottom
985 of window: scroll_max can no longer be INT_MAX. When aggressive
986 scrolling is in use, don't let point enter the opposite scroll
987 margin as result of the scroll.
988 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
989 threshold of 100 lines for never-recentering scrolling.
990
e4cc2dfc
JB
9912011-03-31 Juanma Barranquero <lekktu@gmail.com>
992
993 * dispextern.h (move_it_by_lines):
994 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
995 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
996 (message_log_check_duplicate): Remove parameters `prev_bol' and
997 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
998 (redisplay_internal): Remove parameter `preserve_echo_area',
999 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1000
1001 * indent.c (Fvertical_motion):
1002 * window.c (window_scroll_pixel_based, Frecenter):
1003 Don't pass `need_y_p' to `move_it_by_lines'.
1004
1c470562
SM
10052011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1006
44f230aa
SM
1007 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1008 steal a few bits to be more compact.
1009 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1010 Remove unneeded casts.
1011
1c470562
SM
1012 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1013
888adce9
ZK
10142011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1015
1016 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1017 binding" message (bug#7967).
1018
f838ed7b
PE
10192011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1020
77861b95
PE
1021 Fix more problems found by GCC 4.6.0's static checks.
1022
de6dbc14
PE
1023 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1024 Remove unused local var.
1025
f838ed7b
PE
1026 * editfns.c (Fmessage_box): Remove unused local var.
1027
792c7b2b
PE
1028 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1029 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1030 Omit unused local vars.
c499e557 1031 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1032 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1033 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1034 Omit unused local var.
1035
ba0165e1
PE
1036 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1037 Don't assume string length fits in int.
32ad8845 1038 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1039 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1040
3c59b4c9
PE
1041 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1042 instead of alloca (Bug#8344).
1043
a3eed478 1044 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1045 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1046
eb4d412d
PE
1047 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1048
1658b401
PE
1049 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1050 concerns.
1051
1052 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1053
1054 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1055
9a2c6e05
PE
1056 * keyboard.c (syms_of_keyboard): Use the same style as later
1057 in this function when indexing through an array. This also
1058 works around GCC bug 48267.
1059
03d0a109
PE
1060 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1061
44f730c8
PE
1062 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1063
fe75f926
PE
1064 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1065 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1066
ffa8c828
PE
1067 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1068 This avoids undefined behavior on integer overflow, and is a bit
1069 more convenient anyway since it is compared to a size_t variable.
1070
c5101a77
PE
1071 Variadic C functions now count arguments with size_t, not int.
1072 This avoids an unnecessary limitation on 64-bit machines, which
1073 caused (substring ...) to crash on large vectors (Bug#8344).
1074 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1075 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1076 All variadic functions and their callers changed accordingly.
c5101a77
PE
1077 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1078 * data.c (arith_driver, float_arith_driver): Likewise.
1079 * editfns.c (general_insert_function): Likewise.
1080 * eval.c (struct backtrace.nargs, interactive_p)
1081 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1082 (funcall_lambda, mark_backtrace): Likewise.
1083 * fns.c (concat): Likewise.
1084 * frame.c (x_set_frame_parameters): Likewise.
1085 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1086 0 if not found, not -1. All callers changed.
1087
dd3f25f7
PE
1088 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1089 (stack_copy_size): Now size_t, not int.
1090 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1091
461c2ab9
JB
10922011-03-28 Juanma Barranquero <lekktu@gmail.com>
1093
1094 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1095 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1096 All callers changed.
1097
1098 * lisp.h (multibyte_char_to_unibyte):
1099 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1100 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1101 * character.h (CHAR_TO_BYTE8):
1102 * cmds.c (internal_self_insert):
1103 * editfns.c (general_insert_function):
1104 * keymap.c (push_key_description):
1105 * search.c (Freplace_match):
1106 * xdisp.c (message_dolog, set_message_1): All callers changed.
1107
f6d62986
SM
11082011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1109
1110 * keyboard.c (safe_run_hook_funcall): New function.
1111 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1112 don't set the hook to nil, but remove the offending function instead.
1113 (Qcommand_hook_internal): Remove, unused.
1114 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1115 Vcommand_hook_internal.
1116
1117 * eval.c (enum run_hooks_condition): Remove.
1118 (funcall_nil, funcall_not): New functions.
1119 (run_hook_with_args): Call each function through a `funcall' argument.
1120 Remove `cond' argument, now redundant.
1121 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1122 (Frun_hook_with_args_until_failure): Adjust accordingly.
1123 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1124
1db5b1ad
JB
11252011-03-28 Juanma Barranquero <lekktu@gmail.com>
1126
1127 * dispextern.h (string_buffer_position): Remove declaration.
1128
1129 * print.c (strout): Remove parameter `multibyte', unused since
1130 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1131
1132 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1133 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1134 All callers changed.
1135
1136 * w32.c (_wsa_errlist): Use braces for struct initializers.
1137
1138 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1139 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1140 All callers changed.
1141 (string_buffer_position): Likewise. Also, make static (it's never
1142 used outside xdisp.c).
1143 (cursor_row_p): Remove parameter `w', unused since
1144 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1145 (decode_mode_spec): Remove parameter `precision', introduced during
1146 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1147 All callers changed.
1148
5ffb62aa
JD
11492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1150
1151 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1152
461c2ab9 11532011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1154
1155 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1156 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1157 (ns_update_auto_hide_menu_bar): New functions.
1158 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1159 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1160 ns_constrain_all_frames.
1161 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1162 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1163
5c380ffb
JD
11642011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1165
1166 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1167
9af30bdf
GM
11682011-03-27 Glenn Morris <rgm@gnu.org>
1169
1170 * syssignal.h: Replace RETSIGTYPE with void.
1171 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1172 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1173 Replace SIGTYPE with void everywhere.
1174 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1175 * s/template.h (SIGTYPE): Remove commented out definition.
1176
e2abce01
JB
11772011-03-26 Eli Zaretskii <eliz@gnu.org>
1178
1179 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1180 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1181
f868cd8a
JB
11822011-03-26 Juanma Barranquero <lekktu@gmail.com>
1183
59eb0929
JB
1184 * w32.c (read_unc_volume): Use parameter `henum', instead of
1185 global variable `wget_enum_handle'.
1186
1187 * keymap.c (describe_vector): Remove parameters `indices' and
1188 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1189 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1190
f868cd8a
JB
1191 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1192
1193 * keyboard.c (timer_check): Remove parameter `do_it_now',
1194 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1195 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1196 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1197
1198 * keyboard.c (read_char):
1199 * w32menu.c (w32_menu_display_help):
1200 * xmenu.c (show_help_event, menu_help_callback):
1201 Adjust calls to `show_help_echo'.
1202
1203 * gtkutil.c (xg_maybe_add_timer):
1204 * keyboard.c (readable_events):
1205 * process.c (wait_reading_process_output):
1206 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1207
1208 * insdel.c (adjust_markers_gap_motion):
1209 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1210 (gap_left, gap_right): Don't call it.
1211
2ecf6fdb
CY
12122011-03-25 Chong Yidong <cyd@stupidchicken.com>
1213
1214 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1215 incurred during fontification.
1216
6b1f9ba4
JB
12172011-03-25 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1220 (DEFVAR_PER_BUFFER): Don't pass it.
1221
1222 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1223 (scrolling_window): Don't pass it.
1224
0f4a96b5
JB
12252011-03-25 Juanma Barranquero <lekktu@gmail.com>
1226
1227 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1228
1229 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1230 and `suffix'.
1231 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1232 of variables specific to SELinux and computation of `encoded_absname'.
1233
1234 * image.c (XPutPixel): Remove unused variable `height'.
1235
1236 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1237
1238 * unexw32.c (get_section_info): Remove unused variable `section'.
1239
1240 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1241 (system_process_attributes): Remove unused variable `sess'.
1242 (sys_read): Remove unused variable `err'.
1243
1244 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1245 (w32_wnd_proc): Remove unused variable `isdead'.
1246 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1247 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1248 (x_create_tip_frame): Remove unused variable `tem'.
1249
1250 * w32inevt.c (w32_console_read_socket):
1251 Remove unused variable `no_events'.
1252
1253 * w32term.c (x_draw_composite_glyph_string_foreground):
1254 Remove unused variable `width'.
1255
1149507c
JB
12562011-03-24 Juanma Barranquero <lekktu@gmail.com>
1257
1258 * w32term.c (x_set_glyph_string_clipping):
1259 Don't pass uninitialized region to CombineRgn.
1260
9c88f339
JB
12612011-03-23 Juanma Barranquero <lekktu@gmail.com>
1262
1263 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1264 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1265 (Fx_close_connection): Remove unused variable `i'.
1266
1267 * w32font.c (w32font_draw): Return number of glyphs.
1268 (w32font_open_internal): Remove unused variable `i'.
1269 (w32font_driver): Add missing initializer.
1270
1271 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1272 (fill_in_menu): Remove unused variable `items_added'.
1273
1274 * w32term.c (last_mouse_press_frame): Remove static global variable.
1275 (w32_clip_to_row): Remove unused variable `f'.
1276 (x_delete_terminal): Remove unused variable `i'.
1277
1278 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1279 (NOTHING): Remove unused static global variable.
1280 (uniscribe_check_otf): Remove unused variable `table'.
1281 (uniscribe_font_driver): Add missing initializers.
1282
dee091a3
JD
12832011-03-23 Julien Danjou <julien@danjou.info>
1284
1285 * term.c (Fsuspend_tty, Fresume_tty):
1286 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1287 * window.c (temp_output_buffer_show):
1288 * insdel.c (signal_before_change):
1289 * frame.c (Fhandle_switch_frame):
1290 * fileio.c (Fdo_auto_save):
1291 * emacs.c (Fkill_emacs):
1292 * editfns.c (save_excursion_restore):
1293 * cmds.c (internal_self_insert):
1294 * callint.c (Fcall_interactively):
1295 * buffer.c (Fkill_all_local_variables):
1296 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1297 Use Frun_hooks.
0f4a96b5 1298 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1299 unconditionnaly since it does the check itself.
1300
2c520ab5 13012011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1302
c9c49752
PE
1303 Fix more problems found by GCC 4.5.2's static checks.
1304
8abc3f12
PE
1305 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1306 the first time through the loop, since we know p0 < p1 then.
1307 This also avoids a gcc -Wstrict-overflow warning.
1308
a2d26660
PE
1309 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1310 leading to a memory leak, possible in functions like
1311 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1312 of objects (Bug#8318).
a2d26660 1313
916c72e9
PE
1314 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1315 that could (at least in theory) be that large.
1316
19ab8a18
PE
1317 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1318 This is less likely to overflow, and avoids undefined behavior if
1319 overflow does occur. All callers changed. Use strtoul to scan
1320 for the unsigned long integer.
b7cbbd6f
PE
1321 (pint2hrstr): Simplify and tune code slightly.
1322 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1323
f0641eff
PE
1324 * scroll.c (do_scrolling): Work around GCC bug 48228.
1325 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1326
7f650bb9
PE
1327 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1328 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1329 (validate_x_resource_name): Simplify count usage.
1330 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1331
37dd57d1
PE
1332 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1333 fail (Bug#8306).
81e56e61 1334
699979fc 1335 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1336
401bf9b4
PE
1337 * process.c (Fmake_network_process): Use socklen_t, not int,
1338 where POSIX says socklen_t is required in portable programs.
1339 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1340 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1341 (Fmake_network_process, server_accept_connection):
1342 (wait_reading_process_output, read_process_output):
1343 Likewise.
1344
b93aacde
PE
1345 * process.c: Rename or move locals to avoid shadowing.
1346 (list_processes_1, Fmake_network_process):
1347 (read_process_output_error_handler, exec_sentinel_error_handler):
1348 Rename or move locals.
4dc343ee 1349 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1350 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1351 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1352 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1353 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1354
af8a867c 1355 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1356 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1357 Include tparam.h instead, since it declares them.
af8a867c
PE
1358 * cm.h (PC): Remove extern decl; tparam.h now does this.
1359 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1360 * terminfo.c: Include tparam.h, to check interfaces.
1361 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1362 (tparam): Adjust signature to match interface in tparam.h;
1363 this removes some undefined behavior. Check that outstring and len
1364 are zero, which they always are with Emacs.
1365 * tparam.h (PC, BC, UP): New extern decls.
1366
0248044d 1367 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1368 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1369
8ff096c1 1370 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1371 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1372 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1373 (ftfont_list): Remove unused local.
49eaafba
PE
1374 (get_adstyle_property, ftfont_pattern_entity):
1375 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1376 Rename locals to avoid shadowing.
8ff096c1 1377
e2be39f6
PE
1378 * xfont.c (xfont_list_family): Mark var as initialized.
1379
c9735e30
PE
1380 * xml.c (make_dom): Now static.
1381
8f5201ae
PE
1382 * composite.c (composition_compute_stop_pos): Rename local to
1383 avoid shadowing.
b246f932
PE
1384 (composition_reseat_it): Remove unused locals.
1385 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1386 (composition_update_it): Mark var as initialized.
11b61122
PE
1387 (find_automatic_composition): Mark vars as initialized,
1388 with a FIXME (Bug#8290).
8f5201ae 1389
760fbc2c
PE
1390 character.h: Rename locals to avoid shadowing.
1391 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1392 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1393 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1394 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1395 to avoid shadowing.
1396
ff08eb85
PE
1397 * textprop.c (property_change_between_p): Remove; unused.
1398
fc7bf025
PE
1399 * intervals.c (interval_start_pos): Now static.
1400
235d7abc
PE
1401 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1402
44f230aa
SM
1403 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1404 Rename locals to avoid shadowing.
3e7d6594 1405
50060332
PE
1406 * sound.c (wav_play, au_play, Fplay_sound_internal):
1407 Fix pointer signedness.
d01f234b 1408 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1409 (wav_play): Initialize a variable to 0, to prevent undefined
1410 behavior (Bug#8278).
50060332 1411
c4fc4e30
PE
1412 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1413
918436ed
PE
1414 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1415
c939f91b
PE
1416 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1417 clobbering (Bug#8298).
b9c7f648
PE
1418 * sysdep.c (sys_subshell): Likewise.
1419 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1420
6bd8c144
PE
1421 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1422 This should get cleaned up, so that child_setup has the
1423 same signature on all platforms.
1424
7710357c 1425 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1426 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1427
c59da222
CY
14282011-03-22 Chong Yidong <cyd@stupidchicken.com>
1429
1430 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1431 not to be necessary, and produces flickering.
1432
66b87493
GM
14332011-03-20 Glenn Morris <rgm@gnu.org>
1434
1435 * config.in: Remove file.
1436
45b6f6d5
JB
14372011-03-20 Juanma Barranquero <lekktu@gmail.com>
1438
1439 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1440 are now in src/globals.h.
1441 (syms_of_minibuf): Remove spurious & from previous change.
1442
3ec03f7e
LL
14432011-03-20 Leo <sdl.web@gmail.com>
1444
1445 * minibuf.c (completing-read-function): New variable.
1446 (completing-read-default): Rename from completing-read.
1447 (completing-read): Call completing-read-function.
1448
b14e3e21
CY
14492011-03-19 Juanma Barranquero <lekktu@gmail.com>
1450
1451 * xfaces.c (Fx_load_color_file):
1452 Read color file from absolute filename (bug#8250).
1453
f2b726e6
JB
14542011-03-19 Juanma Barranquero <lekktu@gmail.com>
1455
1456 * makefile.w32-in: Update dependencies.
1457
09f6ff02
EZ
14582011-03-17 Eli Zaretskii <eliz@gnu.org>
1459
1460 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1461
29a6015a
PE
14622011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1463
a3a6c54e
PE
1464 Fix more problems found by GCC 4.5.2's static checks.
1465
b766f867
PE
1466 * process.c (make_serial_process_unwind, send_process_trap):
1467 (sigchld_handler): Now static.
1468
be02381c
PE
1469 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1470 That way, the code declares only the vars that it needs.
1471 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1472 * s/cygwin.h (PTY_ITERATION): Likewise.
1473 * s/darwin.h (PTY_ITERATION): Likewise.
1474 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1475
57048744
PE
1476 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1477 * process.c (allocate_pty): Don't declare stb unless it's needed.
1478
7914961c 1479 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1480 (CONSTANTLIM): Remove; unused.
1481 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1482 Define only if needed.
7914961c 1483
b3967b18
PE
1484 * unexelf.c (unexec): Name an expression,
1485 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1486 Use a different way to cause a compilation error if anyone uses
1487 n rather than nn, a way that does not involve shadowing.
73366a00 1488 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1489
29a6015a
PE
1490 * deps.mk (unexalpha.o): Remove; unused.
1491
43cfc33e 1492 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1493 * unexec.h: New file.
ce701a33
PE
1494 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1495 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1496 Depend on unexec.h.
1497 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1498 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1499 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1500 Change as necessary to match prototype in unexec.h.
ce701a33 1501
01f44d5a
PE
1502 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1503 shadowing.
4f63c6bb 1504 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1505
a6670b0b
PE
1506 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1507 Rename locals to avoid shadowing.
1508
cef2010d 1509 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1510 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1511
d4d7173a
PE
1512 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1513
f08b802a
PE
1514 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1515 warning when compiling print.c.
1516
3ddb0639
PE
1517 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1518 instead of using an uninitialized var.
5ad03b97 1519 (font_sort_entities): Mark var as initialized.
3ddb0639 1520
170a2692
PE
1521 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1522
e663c700
PE
1523 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1524 pointers to constants.
89bc529a 1525 (font_parse_fcname): Remove unused vars.
7b81e2d0 1526 (font_delete_unmatched): Now static.
ea838e10 1527 (font_get_spec): Remove; unused.
13a547c6
PE
1528 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1529 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1530 Rename or move locals to avoid shadowing.
e663c700 1531
2a80c887 1532 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1533 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1534
1384fa33 1535 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1536 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1537
8b2c52e9
PE
1538 * alloc.c (mark_backtrace): Move decl from here ...
1539 * lisp.h: ... to here, so that it can be checked.
1540
475545b5 1541 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1542 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1543 (lisp_indirect_variable): Name an expression,
1544 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1545 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1546
b1349114 1547 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1548 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1549 Use const pointer when appropriate.
b1349114 1550
a2928364
PE
1551 * lisp.h (get_system_name, get_operating_system_release):
1552 Move decls here, to check interfaces.
1553 * process.c (get_operating_system_release): Move decl to lisp.h.
1554 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1555 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1556 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1557 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1558 (Fformat_time_string, Fencode_time, Finsert_char):
1559 (Ftranslate_region_internal, Fformat):
1560 Rename or remove local vars to avoid shadowing.
9710023e 1561 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1562
a415e694
PE
1563 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1564 avoid shadowing.
1565
8ef4622d
PE
1566 * lisp.h (eassert): Check that the argument compiles, even if
1567 ENABLE_CHECKING is not defined.
1568
946f9a5b
PE
1569 * data.c (Findirect_variable): Name an expression, to avoid
1570 gcc -Wbad-function-cast warning.
112396d6 1571 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1572 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1573 (Fmake_variable_buffer_local, Fmake_local_variable):
1574 Mark variables as initialized.
52746918 1575 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1576
e5aab7e7 1577 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1578 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1579 Rename locals to avoid shadowing.
dff45157
PE
1580 (mark_stack): Move local variables into the #ifdef region where
1581 they're used.
7bc26fdb
PE
1582 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1583 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1584 needed otherwise.
1585 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1586 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1587 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1588
e5aab7e7
PE
1589 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1590 avoids undefined behavior in theory.
1591
4da60324
PE
1592 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1593
88043301
PE
1594 Use functions, not macros, for up- and down-casing (Bug#8254).
1595 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1596 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1597 to use the following functions instead of these macros.
1598 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1599 EMACS_INT, since callers assume the returned value fits in int.
1600 (upcase1): Likewise, for UPCASE_TABLE.
1601 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1602 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1603 the race-condition problem in the old DOWNCASE.
88043301 1604
19ed5445
PE
1605 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1606 Rename locals to avoid shadowing.
1607 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1608 (regex_compile, re_search_2, re_match_2_internal):
1609 Remove unused local vars.
952db0d7
PE
1610 (FREE_VAR): Rewrite so as not to use empty "else",
1611 which gcc can warn about.
da053e48 1612 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1613 (RETALLOC_IF): Define only if needed.
1614 (WORDCHAR_P): Likewise. This one is never needed, but is used
1615 only in a comment talking about a compiler bug, so put inside
1616 the #if 0 of that comment.
1617 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1618 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1619 Remove; unused.
19ed5445 1620
1f3561e4 1621 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1622 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1623 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1624
ded6f8f7
PE
1625 * search.c (simple_search): Remove unused var.
1626
dbd37a95
PE
1627 * dired.c (compile_pattern): Move decl from here ...
1628 * lisp.h: ... to here, so that it can be checked.
1629 (struct re_registers): New forward decl.
1630
7e47afad
PE
1631 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1632
85f24f61
PE
1633 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1634 All uses changed.
1635 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1636 Rename locals to avoid shadowing.
5671df8f 1637 (Fvertical_motion): Mark locals as initialized.
85f24f61 1638
181aa2be 1639 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1640 (casify_region): Mark local as initialized.
181aa2be 1641
930d429c
PE
1642 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1643
7082eac6
PE
1644 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1645 New macros, so that the caller can use some names other than
1646 gcpro1, gcpro2, etc.
1647 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1648 of the new macros.
1649 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1650 argument, for consistency with GCPRO2_VAR, etc: it is now the
1651 prefix of the variable, not the variable itself. All uses
1652 changed.
38b2c076
PE
1653 * dired.c (directory_files_internal, file_name_completion):
1654 Rename locals to avoid shadowing.
1655
15206ed9
PE
1656 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1657 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1658 dired.c's scmp function, had undefined behavior.
1659 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1660 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1661 * buffer.h: ... to here, because these macros use current_buffer,
1662 and the new implementation with inline functions needs to have
1663 current_buffer in scope now, rather than later when the macros
1664 are used.
1665 (downcase, upcase1): New static inline functions.
1666 (DOWNCASE, UPCASE1): Reimplement using these functions.
1667 This avoids undefined behavior in expressions like
1668 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1669 from race conditions in accessing the global variables
1670 case_temp1 and case_temp2.
1671 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1672 * lisp.h (case_temp1, case_temp2): Remove their decls.
1673 * character.h (ASCII_CHAR_P): Move from here ...
1674 * lisp.h: ... to here, so that the inline functions mentioned
1675 above can use them.
1676
4a6bea26
PE
1677 * dired.c (directory_files_internal_unwind): Now static.
1678
f14b7e14
PE
1679 * fileio.c (file_name_as_directory, directory_file_name):
1680 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1681 Now static.
2893f146
PE
1682 (file_name_as_directory): Use const pointers when appropriate.
1683 (Fexpand_file_name): Likewise. In particular, newdir might
1684 point at constant storage, so make it a const pointer.
fd4ead52 1685 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1686 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1687 signedness issues.
f839df0c
PE
1688 (Fset_file_times, Finsert_file_contents, auto_save_error):
1689 Rename locals to avoid shadowing.
f14b7e14 1690
5716756e 1691 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1692 (Ftry_completion, Fall_completions): Rename or remove locals
1693 to avoid shadowing.
5716756e 1694
b4c3046a
PE
1695 * marker.c (bytepos_to_charpos): Remove; unused.
1696
b45db522
PE
1697 * lisp.h (verify_bytepos, count_markers): New decls,
1698 so that gcc does not warn that these functions aren't declared.
1699
85876d07
PE
1700 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1701 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1702 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1703 (copy_text): Remove unused local var.
85876d07 1704
03d78a21 1705 * filelock.c (within_one_second): Now static.
b3dd38ab 1706 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1707
5df8f01b
PE
1708 * buffer.c (fix_overlays_before): Mark locals as initialized.
1709 (fix_start_end_in_overlays): Likewise. This function should be
1710 simplified by using pointers-to-pointers, but that's a different
1711 matter.
b1d876f1 1712 (switch_to_buffer_1): Now static.
8f54f30a
PE
1713 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1714 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1715
a70072c9 1716 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1717 Fix pointer signedness issue.
edced198
PE
1718 (sys_subshell): Mark local as volatile if checking for lint,
1719 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1720 (MAXPATHLEN): Define only if needed.
a70072c9 1721
a0977c44
PE
1722 * process.c (serial_open, serial_configure): Move decls from here ...
1723 * systty.h: ... to here, so that they can be checked.
1724
a884fdcc
PE
1725 * fns.c (get_random, seed_random): Move extern decls from here ...
1726 * lisp.h: ... to here, so that they can be checked.
1727
604efe86 1728 * sysdep.c (reset_io): Now static.
b8950c94 1729 (wait_for_termination_signal): Remove; unused.
604efe86 1730
38fc62d9
PE
1731 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1732 (copy_keymap_item, append_key, push_text_char_description):
1733 Now static.
1004a21a 1734 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1735 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1736 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1737 (describe_map_tree):
1738 Rename locals to avoid shadowing.
38fc62d9 1739
2f2650da
PE
1740 * keyboard.c: Declare functions static if they are not used elsewhere.
1741 (echo_char, echo_dash, cmd_error, top_level_2):
1742 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1743 (read_char, kbd_buffer_get_event, make_lispy_position):
1744 (make_lispy_event, make_lispy_movement, apply_modifiers):
1745 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1746 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1747 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1748 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1749 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1750
a053e86c 1751 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1752 (mark_kboards): Move decl here ...
1753 * alloc.c (mark_kboards): ... from here.
a053e86c 1754
4752793e
PE
1755 * lisp.h (force_auto_save_soon): New decl.
1756
74f10ca7 1757 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1758 (DEFINE_DUMMY_FUNCTION): New macro.
1759 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1760 Use it.
c03cd23f
PE
1761 (main): Add casts to avoid warnings
1762 if GCC considers string literals to be constants.
74f10ca7 1763
022e70d4
PE
1764 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1765
59d6fe83
PE
1766 * dbusbind.c: Pointer signedness fixes.
1767 (xd_signature, xd_append_arg, xd_initialize):
1768 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1769 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1770 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1771 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1772
78320123
PE
1773 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1774 if GCC considers string literals to be constants.
49cebcca 1775 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1776
35ac2a97
SM
17772011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1778
fb103ca9
SM
1779 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1780 (print_preprocess, print_object): New macro to fix last change.
1781
35ac2a97
SM
1782 * print.c (print_preprocess): Don't forget font objects.
1783
62973b41
JB
17842011-03-16 Juanma Barranquero <lekktu@gmail.com>
1785
1786 * emacs.c (USAGE3): Doc fixes.
1787
0e48bb22
AS
17882011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1789
1790 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1791 structure.
1792
7684e57b
JB
17932011-03-14 Juanma Barranquero <lekktu@gmail.com>
1794
1795 * lisp.h (VWindow_system, Qfile_name_history):
1796 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1797 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1798 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1799
1800 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1801 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1802
1803 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1804 * w32console.c (detect_input_pending, read_input_pending)
1805 (encode_terminal_code):
1806 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1807 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1808 (w32_system_caret_y, Qfile_name_history):
1809 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1810 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1811 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1812 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1813 * w32proc.c (Qlocal, report_file_error):
1814 * w32term.c (Vwindow_system, updating_frame):
1815 * w32uniscribe.c (initialized, uniscribe_font_driver):
1816 Remove unneeded extern declarations.
1817
2aa46d6c
CY
18182011-03-14 Chong Yidong <cyd@stupidchicken.com>
1819
c96bbc66 1820 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1821
cffc6f3b
CY
18222011-03-13 Chong Yidong <cyd@stupidchicken.com>
1823
1824 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1825 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1826 These macros can no longer be used for assignment.
1827
44f230aa
SM
1828 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1829 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1830 (record_buffer_markers, fetch_buffer_markers): New functions for
1831 recording and fetching special buffer markers.
1832 (set_buffer_internal_1, set_buffer_temp): Use them.
1833
1834 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1835
1836 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1837
1838 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1839 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1840
1841 * xdisp.c (hscroll_window_tree):
1842 (reconsider_clip_changes): Use PT instead of BUF_PT.
1843
d251f04b
EZ
18442011-03-13 Eli Zaretskii <eliz@gnu.org>
1845
1846 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1847 $(EMACS_ROOT)/lib/intprops.h.
1848
f0c77cd1
PE
18492011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1850
3eca4629
PE
1851 Fix more problems found by GCC 4.5.2's static checks.
1852
7c86ee98
PE
1853 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1854 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1855 (xg_free_frame_widgets): Make it clear that a local variable is
1856 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1857 (gdk_window_get_screen): Make it clear that this macro is needed
1858 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1859 (int_gtk_range_get_value): New function, which avoids a diagnostic
1860 from gcc -Wbad-function-cast.
1861 (xg_set_toolkit_scroll_bar_thumb): Use it.
1862 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1863 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1864 (get_utf8_string, xg_get_file_with_chooser):
1865 Rename locals to avoid shadowing.
1866 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1867
41729b81
PE
1868 * xgselect.c (xg_select): Remove unused var.
1869
f0c77cd1
PE
1870 * image.c (four_corners_best): Mark locals as initialized.
1871 (gif_load): Initialize transparent_p to zero (Bug#8238).
1872 Mark another local as initialized.
ec6cf4c6 1873 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1874
ce0ad53d 1875 * image.c (clear_image_cache): Now static.
d5d5a617 1876 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1877 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1878 (x_edge_detection): Remove unnecessary cast that
1879 gcc -Wbad-function-cast diagnoses.
2037898d 1880 (gif_load): Fix pointer signedness.
6ae141d6
PE
1881 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1882 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1883
33383987 18842011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1885
d32df629
PE
1886 Improve quality of tests for time stamp overflow.
1887 For example, without this patch (encode-time 0 0 0 1 1
1888 1152921504606846976) returns the obviously-bogus value (-948597
1889 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1890 reports time overflow. See
1891 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1892 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1893 * editfns.c: Include limits.h and intprops.h.
1894 (TIME_T_MIN, TIME_T_MAX): New macros.
1895 (time_overflow): Move earlier, to before first use.
1896 (hi_time, lo_time): New functions, for an accurate test for
1897 out-of-range times.
1898 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1899 (Fget_internal_run_time): Don't assume time_t fits in int.
1900 (make_time): Use list2 instead of Fcons twice.
1901 (Fdecode_time): More accurate test for out-of-range times.
1902 (check_tm_member): New function.
1903 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1904 (lisp_time_argument): Don't rely on undefined left-shift and
1905 right-shift behavior when checking for time stamp overflow.
8be6f318 1906
fe31d94c
PE
1907 * editfns.c (time_overflow): New function, refactoring common code.
1908 (Fformat_time_string, Fdecode_time, Fencode_time):
1909 (Fcurrent_time_string): Use it.
1910
8be6f318
PE
1911 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1912 * dired.c (make_time): Move to ...
1913 * editfns.c (make_time): ... here.
1914 * systime.h: Note the move.
1915
09d9db2c 19162011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1917
126bc0dc
YM
1918 * fringe.c (update_window_fringes): Remove unused variables.
1919
c47cbdfd
YM
1920 * unexmacosx.c (copy_data_segment): Also copy __got section.
1921 (Bug#8223)
1922
7ac80be9
EZ
19232011-03-12 Eli Zaretskii <eliz@gnu.org>
1924
c96bbc66 1925 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1926 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1927 Constify `char *' arguments and their references according to
1928 prototypes in tparam.h.
1929
ecb0f94d 1930 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1931
7ac80be9
EZ
1932 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1933 Adapt all references accordingly.
1934
1935 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1936
ef1fd07e
TT
19372011-03-11 Tom Tromey <tromey@redhat.com>
1938
1939 * buffer.c (syms_of_buffer): Remove obsolete comment.
1940
7ef4b50c
EZ
19412011-03-11 Eli Zaretskii <eliz@gnu.org>
1942
1943 * termhooks.h (encode_terminal_code): Declare prototype.
1944
1945 * msdos.c (encode_terminal_code): Don't declare prototype.
1946
1947 * term.c (encode_terminal_code): Now external again, used by
1948 w32console.c and msdos.c.
1949
44f230aa
SM
1950 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1951 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1952
4b1ec863 19532011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1954
1714f52b 1955 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1956
4b1ec863
PE
1957 * fringe.c (update_window_fringes): Mark locals as initialized
1958 (Bug#8227).
1959 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1960
524c7aa6
PE
1961 * alloc.c (mark_fringe_data): Move decl from here ...
1962 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1963 to check its interface.
1964 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1965
a5c0af81 1966 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1967 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1968 (fontset_font): Mark local as initialized.
a9a06e0b 1969 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1970
b4716021
PE
1971 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1972
811e9bac 1973 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1974 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1975 (x_own_selection, Fx_disown_selection_internal): Rename locals
1976 to avoid shadowing.
1977 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1978
7e3ab302
PE
1979 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1980 so that the caller can use some name other than gcpro1.
1981 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1982 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1983 (Fx_backspace_delete_keys_p):
1984 Use them to avoid shadowing, and rename vars to avoid shadowing.
1985 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1986 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1987 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1988 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1989 Remove unused locals.
7e3ab302
PE
1990 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1991 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1992 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1993 macros.
f78faa98 1994
e2b13473
PE
1995 * xterm.h (x_mouse_leave): New decl.
1996
77f23912
PE
1997 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1998 Remove unused functions.
cdf4ba58
PE
1999 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2000 (x_calc_absolute_position): Now static.
7411c686 2001 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2002 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2003 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2004 unless they are used.
38d0b34a
PE
2005 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2006 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2007 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2008 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2009 (x_error_catcher, x_connection_closed, x_error_handler):
2010 (x_error_quitter, xembed_send_message, x_iconify_frame):
2011 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2012 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2013 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2014
44f230aa
SM
2015 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2016 Rename or move locals to avoid shadowing.
6b463e58 2017 (tty_defined_color, merge_face_heights): Now static.
5967d051 2018 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2019 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2020 does not deduce is never used uninitialized.
73719eba
PE
2021 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2022 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2023
426994c3 2024 * terminal.c (store_terminal_param): Now static.
5489860b 2025
032f1620 2026 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2027 (set_frame_menubar): Remove unused local.
d4323972 2028 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2029 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2030 since they might point to immutable storage.
281585b0
PE
2031 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2032 since it's unused otherwise.
032f1620 2033
367c19e5 2034 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2035 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2036 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2037 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2038 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2039 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2040 does not deduce are never used uninitialized.
70739cbe 2041
07b48fa9
PE
2042 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2043
8868a238 2044 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2045 * window.c (window_loop, size_window):
2046 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2047
7e5cf297 2048 * window.c (display_buffer): Now static.
d6550a9f
PE
2049 (size_window): Mark variables that gcc -Wuninitialized
2050 does not deduce are never used uninitialized.
a586633d
PE
2051 * window.h (check_all_windows): New decl, to forestall
2052 gcc -Wmissing-prototypes diagnostic.
5b555da1 2053 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2054
f6095868
PE
2055 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2056 shadowing.
2057 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2058 Include <limits.h>.
2059 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2060 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2061 (load_charset_map): Mark variables that gcc -Wuninitialized
2062 does not deduce are never used uninitialized.
53df7c11 2063 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2064
f38b440c
PE
2065 * coding.c (coding_set_source, coding_set_destination):
2066 Use "else { /* comment */ }" rather than "else /* comment */;"
2067 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2068 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2069 a block, when the outer 'i' will do.
2070 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2071 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2072 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2073 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2074 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2075 Rename locals to avoid shadowing.
2076 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2077 * coding.c (emacs_mule_char, encode_invocation_designation):
2078 Now static, since they're not used elsewhere.
413bb2db 2079 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2080 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2081 (decode_coding_emacs_mule): Mark variables that gcc
2082 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2083 (detect_coding_iso_2022): Initialize a local variable that might
2084 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2085 this initialization is needed. (Bug#8211)
5f58e762
PE
2086 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2087 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2088 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2089 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2090 Remove unused macros.
f38b440c 2091
232b38b9 2092 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2093 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2094 * character.c (string_count_byte8): Likewise.
232b38b9 2095
fb90da1b
PE
2096 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2097 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2098
fb93dbc2
PE
2099 * chartab.c (copy_sub_char_table): Now static, since it's not used
2100 elsewhere.
5c156ace
PE
2101 (sub_char_table_ref_and_range, char_table_ref_and_range):
2102 Rename locals to avoid shadowing.
bbcd0949 2103 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2104
7d3b3862 2105 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2106 (BIDI_BOB): Remove unused macro.
7d3b3862 2107
6be7d3da
PE
2108 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2109 deduce are never used uninitialized.
c2ed9c8b 2110 * term.c (encode_terminal_code): Likewise.
6be7d3da 2111
75f8807f 2112 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2113
50938595
PE
2114 * tparam.h: New file.
2115 * term.c, tparam.h: Include it.
2116 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2117 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2118 Move these decls to tparam.h, and make them agree with what
2119 is actually in tparam.c. The previous trick of using incompatible
2120 decls in different modules does not conform to the C standard.
2121 All callers of tparam changed to use tparam's actual API.
2122 * tparam.c (tparam1, tparam, tgoto):
2123 Use const pointers where appropriate.
2124
fbceeba2
PE
2125 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2126 * cm.h (struct cm): Likewise.
2127 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2128 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2129 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2130 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2131 (turn_on_face, init_tty): Likewise.
2132 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2133
7f3f1250
PE
2134 * term.c (term_mouse_position): Rename local to avoid shadowing.
2135
e6ca6543
PE
2136 * alloc.c (mark_ttys): Move decl from here ...
2137 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2138
c40f8d15
AS
21392011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2140
2141 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2142
cfe0661d
JB
21432011-03-09 Juanma Barranquero <lekktu@gmail.com>
2144
2145 * search.c (compile_pattern_1): Remove argument regp, unused since
2146 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2147 (compile_pattern): Don't pass it.
2148
0afb4571
J
21492011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2150
2151 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2152 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2153 for ! HAVE_GTK3.
2154 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2155
2156 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2157
2158 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2159 gdk_window_get_screen, gdk_window_get_geometry,
2160 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2161 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2162 (xg_get_pixbuf_from_pixmap): New function.
2163 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2164 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2165 Call xg_get_pixbuf_from_pixmap instead of
2166 gdk_pixbuf_get_from_drawable.
2167 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2168 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2169 (xg_check_special_colors): Use GtkStyleContext and its functions
2170 for HAVE_GTK3.
2171 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2172 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2173 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2174 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2175 Call gtk_widget_get_preferred_size.
0afb4571
J
2176 (xg_frame_resized): gdk_window_get_geometry only takes 5
2177 parameters.
44f230aa
SM
2178 (xg_win_to_widget, xg_event_is_for_menubar):
2179 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2180 (xg_set_widget_bg): New function.
2181 (delete_cb): New function.
2182 (xg_create_frame_widgets): connect delete-event to delete_cb.
2183 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2184 (xg_set_background_color): Call xg_set_widget_bg.
2185 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2186 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2187 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2188 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2189 if ! HAVE_GTK3.
2190 (update_frame_tool_bar): Call gtk_widget_hide.
2191 (xg_initialize): Use GDK_KEY_g.
2192
2193 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2194 if ! HAVE_GTK3
2195 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2196
2197 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2198 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2199 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2200
1c2cc4ef
JB
22012011-03-08 Juanma Barranquero <lekktu@gmail.com>
2202
2203 * w32xfns.c (select_palette): Check success of RealizePalette against
2204 GDI_ERROR, not zero.
2205
33383987 2206See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2207
2208;; Local Variables:
2209;; coding: utf-8
aac0c6e3
MR
2210;; End:
2211
33383987 2212 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2213
2214 This file is part of GNU Emacs.
2215
2216 GNU Emacs is free software: you can redistribute it and/or modify
2217 it under the terms of the GNU General Public License as published by
2218 the Free Software Foundation, either version 3 of the License, or
2219 (at your option) any later version.
2220
2221 GNU Emacs is distributed in the hope that it will be useful,
2222 but WITHOUT ANY WARRANTY; without even the implied warranty of
2223 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2224 GNU General Public License for more details.
2225
2226 You should have received a copy of the GNU General Public License
2227 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.