Merge from emacs-24; up to 2012-04-24T21:47:24Z!michael.albinus@gmx.de
[bpt/emacs.git] / src / ChangeLog
CommitLineData
efc00ab1 12012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2
3 * xdisp.c (handle_stop): Detect whether we have overlay strings
4 loaded by testing it->current.overlay_string_index to be
5 non-negative, instead of checking whether n_overlay_strings is
6 positive. (Bug#11587)
7
efc00ab1 82012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
9
10 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
11
12 * doc.c (Fsubstitute_command_keys): Doc fix.
13
efc00ab1 142012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
15
16 * search.c (search_buffer): Remove calls to
17 r_alloc_inhibit_buffer_relocation, as it is now called by
18 maybe_unify_char, which was the cause of relocation of buffer text
19 in bug#11519.
20
efc00ab1 212012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
22
23 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
24 for the duration of call to load_charset, to avoid problems with
25 callers of maybe_unify_char that access buffer text through C
26 pointers.
27
28 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
29 decrement the inhibition flag, instead of just setting or
30 resetting it.
31
ba93a187
PE
322012-05-31 Paul Eggert <eggert@cs.ucla.edu>
33
34 Remove obsolete '#define static' cruft.
35 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
36 This #undef was "temporary" in 2000; it is no longer needed
37 now that '#define static' has gone away.
38 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
39 (gray_bitmap_bits): Remove; no longer needed.
40 All uses replaced with definiens.
41 * xterm.c: Include "bitmaps/gray.xbm".
42
9e4bf381
PE
432012-05-30 Paul Eggert <eggert@cs.ucla.edu>
44
45 Clean up __executable_start, monstartup when --enable-profiling.
46 The following changes affect the code only when profiling.
47 * dispnew.c (__executable_start): Rename from safe_bcopy.
48 Define only on platforms that need it.
49 * emacs.c: Include <sys/gmon.h> when profiling.
50 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
51 (__executable_start): Remove decl, since lisp.h does it now.
52 (safe_bcopy): Remove decl; no longer has that name.
53 (main): Coalesce #if into single bit of code, for simplicity.
54 Cast pointers to uintptr_t, since standard libraries want integers
55 and not pointers.
56 * lisp.h (__executable_start): New decl.
57
baac5bc7
JM
582012-05-30 Jim Meyering <meyering@redhat.com>
59
60 * callproc.c (Fcall_process_region): Include directory component
61 in mkstemp error message (Bug#11586).
62
72cb32cf
PE
632012-05-30 Paul Eggert <eggert@cs.ucla.edu>
64
65 * alloc.c, lisp.h (make_pure_vector): Now static.
66
61b108cc
SM
672012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
70 Move to byte-run.el.
71 (Fautoload): Do the hash-doc more carefully.
72 * data.c (Fdefalias): Purify definition, except for keymaps.
73 (Qdefun): Move from eval.c.
74 * lisp.h (Qdefun): Remove.
75 * lread.c (read1): Tiny simplification.
76
471fe23d
TN
772012-05-29 Troels Nielsen <bn.troels@gmail.com>
78
934f3f58 79 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
80 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
81 Bug#9642, but explicitly check that the buffer the overlay would
82 be moved to is live and rearrange lines to make sure that errors
83 will not put the overlay in an inconsistent state.
84 (Fdelete_overlay): Cosmetics.
85
85d0efd1
EZ
862012-05-28 Eli Zaretskii <eliz@gnu.org>
87
88 * w32term.c (my_bring_window_to_top): New function.
89 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
90 could be different from the original one.
91 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
92 (Bug#11513)
93
94 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
95 by calling BringWindowToTop.
96
97 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
98 (WM_EMACS_END): Increase by one.
99
da92a98c
PE
1002012-05-28 Paul Eggert <eggert@cs.ucla.edu>
101
102 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
103 This avoids undefined behavior that might cause the eassert
104 to not catch an out-of-range value.
105
74d1f848
JB
1062012-05-28 Juanma Barranquero <lekktu@gmail.com>
107
108 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
109 Update dependencies.
110
9e1a06fc
EZ
1112012-05-27 Eli Zaretskii <eliz@gnu.org>
112
113 * bidi.c (bidi_mirror_char): Fix last change.
114
f3dd7312
AS
1152012-05-27 Andreas Schwab <schwab@linux-m68k.org>
116
117 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
118 when referring to sectname field in printf format.
119
81899c91
PE
1202012-05-27 Paul Eggert <eggert@cs.ucla.edu>
121
57b81a9f
PE
122 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
123 Only r_alloc_inhibit_buffer_relocation needed to be added;
124 the others were already declared.
125
81899c91
PE
126 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
127 before checking whether it's out of range. Put the check inside
128 eassert. See
129 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
130
33017faf 1312012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
132
133 * callproc.c (Fcall_process): Restore a line that was accidentally
134 commented out in the 2011-02-13 change (bug#11547).
135
33017faf 1362012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
137
138 * lisp.h [REL_ALLOC]: Add prototypes for external functions
139 defined on ralloc.c.
140
141 * buffer.c [REL_ALLOC]: Remove prototypes of
142 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
143 they are now on lisp.h.
144
145 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
146
147 * search.c (search_buffer): Use it to inhibit relocation of buffer
148 text while re_search_2 is doing its job, because re_search_2 is
149 passed C pointers to buffer text. (Bug#11519)
150
23415acf
EZ
151 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
152 Update value to 24.
153
44e27368
EZ
154 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
155 state after an additional call to move_it_in_display_line_to, keep
156 the values of it->max_ascent and it->max_descent found for the
157 entire line.
158 (pos_visible_p): Revert the comparison against bottom_y to what it
159 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
160 (Bug#11464)
161
c1892f11
PE
1622012-05-26 Paul Eggert <eggert@cs.ucla.edu>
163
164 Fix coding-related core dumps with gcc -ftrapv.
165 The code was computing A - B, where A and B are pointers, and B is
166 random garbage. This can lead to core dumps on platforms that
167 have special pointer registers, and it also leads to core dumps on
168 x86-64 when compiled with gcc -ftrapv. The fix is to compute
169 A - B only when B is initialized properly.
170 * coding.c (coding_set_source, coding_set_destination): Return void.
171 (coding_change_source, coding_change_destinations): New functions,
172 with the old behaviors of coding_set_source and coding_set_destination.
173 All callers that need an offset changed to use these new functions.
174
eb7afdad
GM
1752012-05-26 Glenn Morris <rgm@gnu.org>
176
177 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
178
f12fdf02
EZ
1792012-05-26 Eli Zaretskii <eliz@gnu.org>
180
53a63be6 181 Extend mouse support on W32 text-mode console.
61b108cc
SM
182 * xdisp.c (draw_row_with_mouse_face):
183 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 184
eb3f6f01 185 * w32console.c: Include window.h.
61b108cc
SM
186 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
187 New functions.
eb3f6f01
EZ
188 (initialize_w32_display): Initialize mouse-highlight data.
189
53a63be6
EZ
190 * w32inevt.c: Include termchar.h and window.h.
191 (do_mouse_event): Support mouse-autoselect-window. When the mouse
192 moves, call note_mouse_highlight. If help_echo changed, call
193 gen_help_event to produce help-echo message in the echo area.
194 Call clear_mouse_face if mouse_face_hidden is set in the mouse
195 highlight info.
196
4cfd81f6
PE
1972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
198
199 * lread.c (read1): Simplify slightly to avoid an overflow warning
200 with GCC 4.7.0 on x86-64.
201
4446092a
EZ
2022012-05-26 Eli Zaretskii <eliz@gnu.org>
203
204 * bidi.c (bidi_mirror_char): Revert last change: an int is
205 definitely wide enough here.
206
42b2a986 2072012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 208
42b2a986 209 Fix integer width and related bugs (Bug#9874).
eb106a49 210 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
211 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
212 (string_bytes, check_sblock, allocate_string_data):
213 (compact_small_strings, Fmake_bool_vector, make_string)
214 (make_unibyte_string, make_multibyte_string)
215 (make_string_from_bytes, make_specified_string)
216 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
217 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
218 (mark_vectorlike):
219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
220 (allocate_pseudovector):
221 Use int, not EMACS_INT, where int is wide enough.
222 (inhibit_garbage_collection, Fgarbage_collect):
223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
224 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
225 int might not be wide enough.
226 (bidi_cache_search, bidi_cache_find, bidi_init_it)
227 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
228 (bidi_at_paragraph_end, bidi_find_paragraph_start)
229 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
230 (bidi_level_of_next_char, bidi_move_to_visually_next):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
233 (Fkill_buffer, Fset_buffer_major_mode)
234 (advance_to_char_boundary, Fbuffer_swap_text)
235 (Fset_buffer_multibyte, overlays_at, overlays_in)
236 (overlay_touches_p, struct sortvec, record_overlay_string)
237 (overlay_strings, recenter_overlay_lists)
238 (adjust_overlays_for_insert, adjust_overlays_for_delete)
239 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
240 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
241 (Foverlay_recenter, last_overlay_modification_hooks_used)
242 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
244 (validate_region): Omit unnecessary test for b <= e,
245 since that's guaranteed by the previous test.
d311d28c
PE
246 (adjust_overlays_for_delete): Avoid pos + length overflow.
247 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
248 (report_overlay_modification):
249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
250 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
251 Omit pointer cast, which isn't needed anyway, and doesn't work
252 after the EMACS_INT -> ptrdiff_t change.
02481186 253 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
254 * buffer.h: Adjust decls to match defn changes elsewhere.
255 (struct buffer_text, struct buffer):
256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
257 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
258 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
259 not int, to avoid needless 32-bit limit on 64-bit hosts.
260 (exec_byte_code): Use tighter memory-full test, one that checks
261 for alloca overflow. Don't compute the address of the object just
262 before an array, as that's not portable. Use EMACS_INT, not
263 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
264 * callint.c (Fcall_interactively):
265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
266 * callproc.c (call_process_kill, Fcall_process):
267 Don't assume pid_t fits into an Emacs fixnum.
268 (call_process_cleanup, Fcall_process, child_setup):
269 Don't assume pid_t fits into int.
270 (call_process_cleanup, Fcall_process, delete_temp_file)
271 (Fcall_process_region):
272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
273 (Fcall_process): Simplify handling of volatile integers.
274 Use int, not EMACS_INT, where int will do.
275 * casefiddle.c (casify_object, casify_region, operate_on_word)
276 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
278 (casify_object): Avoid integer overflow when overallocating buffer.
279 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 280 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
281 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
282 * category.h (CATEGORYP): Don't assume arg is nonnegative.
283 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
284 integers are now checked earlier. All uses replaced with XINT.
285 (ccl_driver):
286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
287 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
288 (ccl_driver, Fregister_code_conversion_map):
289 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
290 (resolve_symbol_ccl_program): Check that vector header is in range.
291 Always copy the vector, so that we can check its contents reliably
292 now rather than having to recheck each instruction as it's being
293 executed. Check that vector words fit in 'int'.
294 (ccl_get_compiled_code, Fregister_ccl_program)
295 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
296 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
297 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
298 contents are in range.
299 (Fccl_execute_on_string): Check that status is in range.
300 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
301 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
302 Accept and return EMACS_INT, not int, because callers can pass values
303 out of 'int' range.
304 (c_string_width, strwidth, lisp_string_width, chars_in_text)
305 (multibyte_chars_in_text, parse_str_as_multibyte)
306 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
307 (str_as_unibyte, str_to_unibyte, string_count_byte8)
308 (string_escape_byte8, Fget_byte):
309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 310 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
311 avoid mishandling large integers.
312 * character.h: Adjust decls to match defn changes elsewhere.
313 * charset.c (load_charset_map_from_file, find_charsets_in_text)
314 (Ffind_charset_region):
315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
316 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
317 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 318 Don't assume fixnum fits in int.
d311d28c
PE
319 (load_charset_map_from_vector, Fmap_charset_chars):
320 Remove now-unnecessary CHECK_NATNUMs.
321 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
322 Don't rely on undefined behavior with signed left shift overflow.
323 Don't assume unsigned int fits into fixnum, or that fixnum fits
324 into unsigned int. Don't require max_code to be a valid fixnum;
325 that's not true for gb10830 4-byte on a 32-bit host. Allow
326 invalid_code to be a cons, for the same reason. Require code_offset
327 to be a character. Avoid int overflow if max_char is close
328 to INT_MAX.
329 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
330 this is intended anyway and avoids some undefined behavior.
331 (load_charset_map): Pass unsigned, not int, as 2nd arg of
332 INDEX_TO_CODE_POINT, as that's what it expects.
333 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
334 * charset.h (DECODE_CHAR): Return int, not unsigned;
335 this is what was intended anyway, and it avoids undefined behavior.
336 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
337 integer-overflow issues.
338 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
339 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
340 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
341 * chartab.c (Fmake_char_table, Fset_char_table_range)
342 (uniprop_get_decoder, uniprop_get_encoder):
343 Don't assume fixnum fits in int.
344 * cmds.c (move_point): New function, that does the gist of
345 Fforward_char and Fbackward_char, but does so while checking
346 for integer overflow more accurately.
c96e5d6a 347 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
348 (Fforward_line, Fend_of_line, internal_self_insert)
349 (internal_self_insert):
350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
351 Fix a FIXME, by checking for integer overflow when calculating
352 target_clm and actual_clm.
353 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 354 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
355 (ASSURE_DESTINATION, coding_alloc_by_realloc)
356 (coding_alloc_by_making_gap, alloc_destination)
357 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
358 (encode_coding_utf_16, detect_coding_emacs_mule)
359 (decode_coding_emacs_mule, encode_coding_emacs_mule)
360 (detect_coding_iso_2022, decode_coding_iso_2022)
361 (encode_invocation_designation, encode_designation_at_bol)
362 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
363 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
364 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
365 (encode_coding_ccl, encode_coding_raw_text)
366 (detect_coding_charset, decode_coding_charset)
367 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
368 (produce_composition, produce_charset, produce_annotation)
369 (decode_coding, handle_composition_annotation)
370 (handle_charset_annotation, consume_chars, decode_coding_gap)
371 (decode_coding_object, encode_coding_object, detect_coding_system)
372 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
373 (code_convert_region, code_convert_string)
8f50130c
PE
374 (Fdefine_coding_system_internal)
375 (coding_set_source, coding_set_destination):
d311d28c
PE
376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
377 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
378 (Fdefine_coding_system_internal):
379 Don't assume fixnums fit in int.
380 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 381 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
382 (Funencodable_char_position, Fcheck_coding_systems_region)
383 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 385 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 386 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 387 Don't access memory outside of the args array.
d311d28c 388 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
389 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
390 result of ENCODE_CHAR.
d311d28c
PE
391 * coding.h: Adjust decls to match defn changes elsewhere.
392 (struct coding_system):
393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
394 * composite.c (get_composition_id, find_composition)
395 (run_composition_function, update_compositions)
396 (compose_text, composition_gstring_put_cache)
397 (composition_gstring_p, composition_gstring_width)
398 (fill_gstring_header, fill_gstring_body, autocmp_chars)
399 (composition_compute_stop_pos, composition_reseat_it)
400 (composition_update_it, struct position_record)
401 (find_automatic_composition, composition_adjust_point)
402 (Fcomposition_get_gstring, Ffind_composition_internal):
403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
404 (update_compositions):
405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
406 * composite.h: Adjust decls to match defn changes elsewhere.
407 (struct composition):
408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
409 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
410 Do not attempt to compute the address of the object just before a
411 buffer; this is not portable.
412 (Faref, Faset):
413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
414 (Faset): Use int, not EMACS_INT, where int is wide enough.
415 (Fstring_to_number): Don't assume fixnums fit in int.
416 (Frem): Don't assume arg is nonnegative.
417 * dbusbind.c (xd_append_arg): Check for integers out of range.
418 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 419 (extract_signed, extract_unsigned): New functions.
243e0530
PE
420 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
421 (xd_get_connection_references): Return ptrdiff_t, not int.
422 All uses changed.
423 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
424 (xd_read_message_1):
425 Use int, not unsigned, where the dbus API uses int.
426 (Fdbus_message_internal): Don't overflow mtype.
427 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
428 * dired.c (directory_files_internal, file_name_completion, scmp)
429 (file_name_completion_stat):
430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
431 (file_name_completion): Don't overflow matchcount.
432 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
433 * dispextern.h: Adjust decls to match defn changes elsewhere.
434 (struct text_pos, struct glyph, struct bidi_saved_info)
435 (struct bidi_string_data, struct bidi_it, struct composition_it)
436 (struct it):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 (struct display_pos, struct composition_it, struct it):
439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
440 * dispnew.c (increment_matrix_positions)
441 (increment_row_positions, mode_line_string)
442 (marginal_area_string):
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 444 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (duration_to_sec_usec): New function, to check for overflow better.
447 (Fsleep_for, sit_for): Use it.
448 * doc.c (get_doc_string, store_function_docstring):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 (get_doc_string, Fsnarf_documentation):
451 Use int, not EMACS_INT, where int is wide enough.
452 (get_doc_string):
453 Use SAFE_ALLOCA, not alloca.
454 Check for overflow when converting EMACS_INT to off_t.
455 * doprnt.c (doprnt):
456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
457 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
458 Don't assume uid_t fits into fixnum.
459 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
460 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
461 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
462 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
463 (general_insert_function)
464 (Finsert_char, make_buffer_string, make_buffer_string_both)
465 (update_buffer_properties, Fbuffer_substring)
466 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
467 (Fsubst_char_in_region, check_translation)
468 (Ftranslate_region_internal, save_restriction_restore, Fformat)
469 (transpose_markers, Ftranspose_regions):
470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
471 (clip_to_bounds): Move to lisp.h as an inline function).
472 (Fconstrain_to_field): Don't assume integers are nonnegative.
473 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
474 (Fsubst_char_in_region, Fsave_restriction):
475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
476 (Femacs_pid): Don't assume pid_t fits into fixnum.
477 (lo_time): Use int, not EMACS_INT, when int suffices.
478 (lisp_time_argument): Check for usec out of range.
479 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
480 (Fuser_login_name, Fuser_full_name): Signal an error
481 if a uid argument is out of range, rather than relying on
482 undefined behavior.
c8d5c857
PE
483 (Fformat_time_string): Remove now-unnecessary check.
484 lisp_time_argument checks for out-of-range usec now.
243e0530 485 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
486 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
487 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
488 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
489 (init_cmdargs, Fdump_emacs):
490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
491 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
492 the bottom (typically) 32 bits of the fixnum.
493 * eval.c (specpdl_size, call_debugger):
494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
495 (when_entered_debugger, Fbacktrace_debug):
496 Don't assume fixnum can fit in int.
497 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
498 the object just before a buffer; this is not portable.
499 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
500 (grow_specpdl, unbind_to):
501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
502 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
503 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 504 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
505 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
506 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
508 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
509 (a_write, e_write):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (Fcopy_file, non_regular_nbytes, read_non_regular)
512 (Finsert_file_contents):
513 Use int, not EMACS_INT, where int is wide enough.
514 (READ_BUF_SIZE): Verify that it fits in int.
515 (Finsert_file_contents): Check that counts are in proper range,
516 rather than assuming fixnums fit into ptrdiff_t etc.
517 Don't assume fixnums fit into int.
125b3835 518 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
519 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
520 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
521 (string_char_to_byte, string_byte_to_char)
522 (string_make_multibyte, string_to_multibyte)
523 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
524 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
525 (substring_both, Fdelete, internal_equal, Ffillarray)
526 (Fclear_string, mapcar1)
527 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
528 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
529 (larger_vector, make_hash_table, maybe_resize_hash_table)
530 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
531 (Fmaphash, secure_hash):
532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
533 (concat): Check for string index and length overflow.
534 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
535 (Frequire):
536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
537 (larger_vector): New API (vec, incr_min, size_max) replaces old
538 one (vec, new_size, init). This catches size overflow.
539 INIT was removed because it was always Qnil.
540 All callers changed.
541 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
542 the upper bound on a hash table index size.
543 (make_hash_table, maybe_resize_hash_table): Use it.
544 (secure_hash): Computer start_byte and end_byte only after
545 they're known to be in ptrdiff_t range.
546 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
547 (Ffont_get_glyphs, Ffont_at):
548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
549 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
550 (Flist_fonts, Fopen_font):
551 Don't assume fixnum can fit in int.
552 (check_gstring): Don't assume index can fit in int.
553 (font_match_p): Check that fixnum is a character, not a nonnegative
554 fixnum, since the later code needs to stuff it into an int.
555 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
556 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
557 conversion overflow issues.
558 (Fopen_font): Check for integer out of range.
559 (Ffont_get_glyphs): Don't assume index can fit in int.
560 * font.h: Adjust decls to match defn changes elsewhere.
561 * fontset.c (reorder_font_vector): Redo score calculation to avoid
562 integer overflow.
563 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
564 printmax_t, where ptrdiff_t is wide enough.
565 (Finternal_char_font):
566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
567 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
568 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
569 (Fset_frame_position, x_set_frame_parameters)
570 (x_set_line_spacing, x_set_border_width)
571 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
572 Check that fixnums are in proper range for system types.
573 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
575 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
576 Use SAFE_ALLOCA_LISP, not alloca.
577 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
578 intptr_t is wide enough.
579 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
580 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
581 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
582 Check for fixnum out of range.
583 * ftfont.c (ftfont_list): Don't assume index fits in int.
584 Check that fixnums are in proper range for system types.
585 (ftfont_shape_by_flt):
586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
587 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
589 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
590 Check that fixnums are in proper range for system types.
591 * gnutls.h: Adjust decls to match defn changes elsewhere.
592 * gtkutil.c (xg_dialog_run):
593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
594 (update_frame_tool_bar):
595 Check that fixnums are in proper range for system types.
596 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 597 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
598 * indent.c (last_known_column, last_known_column_point):
599 (current_column_bol_cache):
600 (skip_invisible, current_column, check_display_width):
601 (check_display_width, scan_for_column, current_column_1)
602 (Findent_to, Fcurrent_indentation, position_indentation)
603 (indented_beyond_p, Fmove_to_column, compute_motion):
604 (Fcompute_motion, Fvertical_motion):
605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
606 (last_known_column_modified): Use EMACS_INT, not int.
607 (check_display_width):
608 (Fcompute_motion):
609 Check that fixnums and floats are in proper range for system types.
610 (compute_motion): Don't assume index or fixnum fits in int.
611 (compute_motion, Fcompute_motion):
612 Use int, not EMACS_INT, when it is wide enough.
613 (vmotion): Omit local var start_hpos that is always 0; that way
614 we don't need to worry about overflow in expressions involving it.
615 * indent.h: Adjust decls to match defn changes elsewhere.
616 (struct position):
617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
618 Use int, not EMACS_INT, where int is wide enough.
619 Remove unused members ovstring_chars_done and tab_offset;
620 all uses removed.
621 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
622 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
623 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
624 (make_gap, copy_text, insert, insert_and_inherit)
625 (insert_before_markers, insert_before_markers_and_inherit)
626 (insert_1, count_combining_before, count_combining_after)
627 (insert_1_both, insert_from_string)
628 (insert_from_string_before_markers, insert_from_string_1)
629 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
630 (adjust_after_replace, adjust_after_insert, replace_range)
631 (replace_range_2, del_range, del_range_1, del_range_byte)
632 (del_range_both, del_range_2, modify_region)
633 (prepare_to_modify_buffer, signal_before_change)
634 (signal_after_change, Fcombine_after_change_execute):
635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
636 * intervals.c (traverse_intervals, rotate_right, rotate_left)
637 (balance_an_interval, split_interval_right, split_interval_left)
638 (find_interval, next_interval, update_interval)
639 (adjust_intervals_for_insertion, delete_node, delete_interval)
640 (interval_deletion_adjustment, adjust_intervals_for_deletion)
641 (static_offset_intervals, offset_intervals)
642 (merge_interval_right, merge_interval_left, make_new_interval)
643 (graft_intervals_into_buffer, temp_set_point_both)
644 (temp_set_point, set_point, adjust_for_invis_intang)
645 (set_point_both, move_if_not_intangible, get_property_and_range)
646 (get_local_map, copy_intervals, copy_intervals_to_string)
647 (compare_string_intervals, set_intervals_multibyte_1):
648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
649 * intervals.h: Adjust decls to match defn changes elsewhere.
650 (struct interval):
651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
652 * keyboard.c (this_command_key_count, this_single_command_key_start)
653 (before_command_key_count, before_command_echo_length, echo_now)
654 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
655 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
656 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
657 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
659 (last_non_minibuf_size, last_point_position, echo_truncate)
660 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
661 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
662 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
663 (stuff_buffered_input):
664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
665 (last_auto_save, command_loop_1, read_char):
666 Use EMACS_INT, not int, to avoid integer overflow.
667 (record_char): Avoid overflow in total_keys computation.
668 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
669 * keyboard.h: Adjust decls to match defn changes elsewhere.
670 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
671 (Fkey_description, Fdescribe_vector, Flookup_key):
672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
673 (click_position): New function, to check that positions are in range.
674 (Fcurrent_active_maps):
675 (describe_command):
676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
677 (Faccessible_keymaps, Fkey_description):
678 (preferred_sequence_p):
679 Don't assume fixnum can fit into int.
680 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
681 Check for integer overflow in size calculations.
682 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
683 avoid mishandling large integers.
684 * lisp.h: Adjust decls to match defn changes elsewhere.
685 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
686 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
687 (struct Lisp_Marker):
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
690 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
691 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
692 All callers changed.
693 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
694 Assume the arg has valid form, since it always does.
695 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
696 unsigned integer system type.
697 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
698 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
700 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
701 (duration_to_sec_usec): New decl.
702 * lread.c (read_from_string_index, read_from_string_index_byte)
703 (read_from_string_limit, readchar, unreadchar, openp)
704 (read_internal_start, read1, oblookup):
705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
706 (Fload, readevalloop, Feval_buffer, Feval_region):
707 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
708 (openp): Check for out-of-range argument to 'access'.
709 (read1): Use int, not EMACS_INT, where int is wide enough.
710 Don't assume fixnum fits into int.
6efdadfd 711 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
712 (read_filtered_event): Use duration_to_sec_usec
713 to do proper overflow checking on durations.
d311d28c
PE
714 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
715 in size calculation.
716 (Fexecute_kbd_macro):
717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
718 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
719 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
720 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
721 (set_marker_both, set_marker_restricted_both, marker_position)
722 (marker_byte_position, Fbuffer_has_markers_at):
723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
724 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 725 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
726 It now merely ensures that the menu is large enough, without
727 necessarily growing it, as this avoids some integer overflow issues.
728 All callers changed.
729 (keymap_panes, parse_single_submenu, Fx_popup_menu):
730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
731 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
732 Use SAFE_ALLOCA_LISP, not alloca.
733 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
734 to EMACS_INT. Check that fixnums are in proper range for system types.
735 * minibuf.c (minibuf_prompt_width, string_to_object)
736 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
737 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 (get_minibuffer, read_minibuf_unwind):
740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
741 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
742 this simplifies overflow checking. All callers changed.
743 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
744 (Ftest_completion):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
747 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
748 Check that fixnums are in proper range for system types.
749 (Fx_create_frame, Fx_show_tip):
750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
751 * nsfont.m (ns_findfonts, nsfont_list_family):
752 Don't assume fixnum fits in long.
753 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
755 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
756 wide enough.
17fdb222 757 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
759 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
760 (PRINTDECLARE, PRINTPREPARE):
761 (strout, print_string):
762 (print, print_preprocess, print_check_string_charset_prop)
763 (print_object):
764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
765 (PRINTDECLARE):
766 (temp_output_buffer_setup, Fprin1_to_string, print_object):
767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
768 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 769 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 770 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
771 (print_error_message): Use SAFE_ALLOCA, not alloca.
772 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
773 (print_depth, new_backquote_output, print_number_index):
774 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
775 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
776 (Fset_process_window_size, Fformat_network_address)
777 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 778 (sigchld_handler):
d311d28c 779 Check that fixnums are in proper range for system types.
d44287d4 780 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
781 Check for process-ids out of pid_t range rather than relying on
782 undefined behavior.
e4d81efc 783 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
784 (Fformat_network_address, read_process_output, send_process)
785 (Fprocess_send_region, status_notify):
786 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
787 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
788 (wait_reading_process_output, read_process_output, exec_sentinel):
789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
790 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
791 (Faccept_process_output): Use duration_to_sec_usec to do proper
792 overflow checking on durations.
dde14581
PE
793 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
794 Don't assume pid_t fits in int.
02481186
PE
795 * process.h (struct Lisp_Process): Members tick and update_tick
796 are now of type EMACS_INT, not int.
b62b53e8
PE
797 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
798 configured --with-wide-int.
d311d28c
PE
799 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
800 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
801 * search.c (looking_at_1, string_match_1):
802 (fast_string_match, fast_c_string_match_ignore_case)
803 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
804 (scan_newline, find_before_next_newline, search_command)
805 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
806 (set_search_regs, wordify):
807 (Freplace_match):
808 (Fmatch_data):
809 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
810 (string_match_1, search_buffer, set_search_regs):
811 (Fmatch_data):
812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
813 (wordify): Check for overflow in size calculation.
814 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
815 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
816 Check that fixnums are in proper range for system types.
817 * sound.c (struct sound_device)
818 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
820 (Fplay_sound_internal):
821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 822 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
823 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
824 (Fparse_partial_sexp):
825 Don't assume fixnums can fit in int.
826 (struct lisp_parse_state, find_start_pos, find_start_value)
827 (find_start_value_byte, find_start_begv)
828 (update_syntax_table, char_quoted, dec_bytepos)
829 (find_defun_start, prev_char_comend_first, back_comment):
830 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
831 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
833 (Finternal_describe_syntax_value): Check that match_lisp is a
834 character, not an integer, since the code stuffs it into int.
835 (scan_words, scan_sexps_forward):
836 Check that fixnums are in proper range for system types.
837 (Fforward_word):
838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
839 (scan_sexps_forward):
840 Use CHARACTERP, not INTEGERP, since the value must fit into int.
841 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
842 * syntax.h: Adjust decls to match defn changes elsewhere.
843 (struct gl_state_s):
844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
845 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
846 MOST_POSITIVE_FIXNUM.
d311d28c
PE
847 * sysdep.c (wait_for_termination_1, wait_for_termination)
848 (interruptible_wait_for_termination, mkdir):
849 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
850 (emacs_read, emacs_write):
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
852 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
853 and double all fit in int.
d311d28c
PE
854 * term.c (set_tty_color_mode):
855 Check that fixnums are in proper range for system types.
856 * termhooks.h (struct input_event):
857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
858 * textprop.c (validate_interval_range, interval_of)
859 (Fadd_text_properties, set_text_properties_1)
860 (Fremove_text_properties, Fremove_list_of_text_properties)
861 (Ftext_property_any, Ftext_property_not_all)
862 (copy_text_properties, text_property_list, extend_property_ranges)
863 (verify_interval_modification):
864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
865 (Fnext_single_char_property_change)
866 (Fprevious_single_char_property_change):
867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
868 (copy_text_properties):
869 Check for integer overflow in index calculation.
d311d28c
PE
870 * undo.c (last_boundary_position, record_point, record_insert)
871 (record_delete, record_marker_adjustment, record_change)
872 (record_property_change):
873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
874 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
875 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
876 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
877 (Fx_hide_tip, Fx_file_dialog):
878 * w32menu.c (set_frame_menubar):
879 Use ptrdiff_t, not int, for consistency with rest of code.
880 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
881 (select_window, Fdelete_other_windows_internal)
882 (window_scroll_pixel_based, window_scroll_line_based)
883 (Frecenter, Fset_window_configuration):
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 (Fset_window_hscroll, run_window_configuration_change_hook)
886 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 887 (Fscroll_other_window, Frecenter):
d311d28c
PE
888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
889 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
890 Don't assume fixnum fits in int.
891 (Fset_window_scroll_bars):
892 Check that fixnums are in proper range for system types.
893 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
894 (string_pos, c_string_pos, number_of_chars, init_iterator)
895 (in_ellipses_for_invisible_text_p, init_from_display_pos)
896 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
897 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
898 (face_before_or_after_it_pos, handle_invisible_prop)
899 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
900 (display_prop_intangible_p, string_buffer_position_lim)
901 (string_buffer_position, handle_composition_prop, load_overlay_strings)
902 (get_overlay_strings_1, get_overlay_strings)
903 (iterate_out_of_display_property, forward_to_next_line_start)
904 (back_to_previous_visible_line_start, reseat, reseat_to_string)
905 (get_next_display_element, set_iterator_to_next)
906 (get_visually_first_element, compute_stop_pos_backwards)
907 (handle_stop_backwards, next_element_from_buffer)
908 (move_it_in_display_line_to, move_it_in_display_line)
909 (move_it_to, move_it_vertically_backward, move_it_by_lines)
910 (add_to_log, message_dolog, message_log_check_duplicate)
911 (message2, message2_nolog, message3, message3_nolog
912 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
913 (current_message_1, truncate_echo_area, truncate_message_1)
914 (set_message, set_message_1, store_mode_line_noprop)
915 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
916 (text_outside_line_unchanged_p, check_point_in_composition)
917 (reconsider_clip_changes)
918 (redisplay_internal, set_cursor_from_row, try_scrolling)
919 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
920 (redisplay_window, find_last_unchanged_at_beg_row)
921 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
922 (trailing_whitespace_p, find_row_edges, display_line)
923 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
924 (display_mode_element, store_mode_line_string)
925 (pint2str, pint2hrstr, decode_mode_spec)
926 (display_count_lines, display_string, draw_glyphs)
927 (x_produce_glyphs, x_insert_glyphs)
928 (rows_from_pos_range, mouse_face_from_buffer_pos)
929 (fast_find_string_pos, mouse_face_from_string_pos)
930 (note_mode_line_or_margin_highlight, note_mouse_highlight):
931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
932 (safe_call, init_from_display_pos, handle_fontified_prop)
933 (handle_single_display_spec, load_overlay_strings)
934 (with_echo_area_buffer, setup_echo_area_for_printing)
935 (display_echo_area, echo_area_display)
936 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
937 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
938 (redisplay_window, dump_glyph_row, display_mode_line)
939 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 940 (handle_display_spec, display_prop_string_p):
d311d28c
PE
941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
942 (handle_single_display_spec, build_desired_tool_bar_string)
943 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
944 (get_specified_cursor_type):
945 Check that fixnums are in proper range for system types.
946 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
947 (Flookup_image_map):
948 Don't assume fixnums fit in int.
949 (compare_overlay_entries):
950 Avoid mishandling comparisons due to subtraction overflow.
951 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
952 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
953 (handle_tool_bar_click):
954 Use int, not unsigned, since we prefer signed and the signedness
955 doesn't matter here.
956 (get_next_display_element, next_element_from_display_vector):
957 Use int, not EMACS_INT, when int is wide enough.
958 (start_hourglass): Use duration_to_sec_usec to do proper
959 overflow checking on durations.
960 * xfaces.c (Fbitmap_spec_p):
961 Check that fixnums are in proper range for system types.
962 (compare_fonts_by_sort_order):
963 Avoid mishandling comparisons due to subtraction overflow.
964 (Fx_family_fonts, realize_basic_faces):
965 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
966 (Fx_family_fonts):
967 Don't assume fixnum fits in int.
968 Use SAFE_ALLOCA_LISP, not alloca.
969 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
970 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
971 (face_at_buffer_position, face_for_overlay_string)
972 (face_at_string_position):
973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
974 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
975 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
976 (Fx_show_tip):
977 Check that fixnums are in proper range for system types.
978 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
979 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
981 (Fx_change_window_property): Don't assume fixnums fit in int.
982 * xfont.c (xfont_chars_supported):
983 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
984 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
985 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
987 * xml.c (parse_region):
988 * xrdb.c (magic_file_p):
989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
990 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
991 (x_get_local_selection, x_reply_selection_request)
992 (x_handle_selection_request, wait_for_property_change):
993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
994 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
995 short is wide enough.
996 (x_send_client_event): Don't assume fixnum fits in int.
997 * xterm.c (x_x_to_emacs_modifiers):
998 Don't assume EMACS_INT overflows nicely into int.
999 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1000 may come from Lisp.
1001 (handle_one_xevent): NATNUMP can eval its arg twice.
1002 (x_connection_closed):
1003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1004 * xterm.h: Adjust decls to match defn changes elsewhere.
1005 (struct scroll_bar): Use struct vectorlike_header
1006 rather than rolling our own approximation.
1007 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1008
c6574eb5
GM
10092012-05-25 Glenn Morris <rgm@gnu.org>
1010
1011 * lisp.mk (lisp): Update for more files being compiled now.
1012
e8d32c7e
SM
10132012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1014
48def666
SM
1015 * lread.c: Remove `read_pure' which makes no difference.
1016 (read_pure): Remove var.
1017 (unreadpure): Remove function.
1018 (readevalloop): Don't call read_list with -1 flag.
1019 (read1, read_vector): Don't test read_pure any more.
1020 (read_list): Simplify.
1021
e8d32c7e
SM
1022 * fileio.c, character.h: Minor style tweaks.
1023
4b2addb7
DA
10242012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1025
1026 * window.h (clip_changed): Remove useless declaration.
1027
584461b2
JB
10282012-05-22 Juanma Barranquero <lekktu@gmail.com>
1029
1030 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1031 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1032
34374650
PE
10332012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1034
1035 Remove src/m/*.
1036 This directory predates autoconf and is no longer needed nowadays.
1037 Move its few remaining bits of functionality to where they're needed.
1038 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1039 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1040 * m/template.h: Remove.
1041 * Makefile.in (M_FILE): Remove. All uses removed.
1042 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1043 * lisp.h (USE_LSB_TAG):
1044 * mem-limits.h (EXCEEDS_LISP_PTR):
1045 Use VAL_MAX, not VALBITS, in #if.
1046 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1047 (EMACS_UINT): Define unconditionally now.
1048 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1049 (BITS_PER_EMACS_INT): New constants, replacing
1050 what used to be in config.h, but not useful in #if.
1051 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1052 define them any more.
1053 (VAL_MAX): New macro.
1054 (VALMASK): Use it.
1055 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1056 BITS_PER_EMACS_INT, in #if.
1057 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1058 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1059 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1060 * s/ms-w32.h (DATA_START):
1061 Move here from removed file m/intel386.h.
1062 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1063 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1064
261cb4bb
PE
10652012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1066
1067 Assume C89 or later.
1068 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1069 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1070 (xrealloc):
1071 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1072 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1073 * textprop.c, tparam.c (NULL): Remove.
1074 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1075 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1076 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1077 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1078 * xterm.c (input_signal_count): Assume volatile works.
1079
ff23cd9f
KB
10802012-05-21 Ken Brown <kbrown@cornell.edu>
1081
1082 * xgselect.c (xg_select): Fix first argument in call to 'select'
1083 (bug#11508).
1084
1b170bc6
KB
10852012-05-20 Ken Brown <kbrown@cornell.edu>
1086
1087 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1088 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1089
b2f4d39f
KB
10902012-05-19 Ken Brown <kbrown@cornell.edu>
1091
1092 * xfns.c (x_in_use): Remove `static' qualifier.
1093 * xterm.h (x_in_use): Declare.
1094 * xgselect.c: Include xterm.h.
1095 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1096 and `display_arg' (bug#9754).
1097
003fdae2
PE
10982012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1099
9232a6d9
PE
1100 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1101
003fdae2
PE
1102 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1103 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1104
784b56e2
EZ
11052012-05-18 Eli Zaretskii <eliz@gnu.org>
1106
1107 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1108
1109 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1110 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1111
1112 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1113 reference to image_cache->refcount.
1114 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1115
a0a79cde
JL
11162012-05-17 Juri Linkov <juri@jurta.org>
1117
1118 * search.c (Fword_search_regexp, Fword_search_backward)
1119 (Fword_search_forward, Fword_search_backward_lax)
1120 (Fword_search_forward_lax): Move functions to isearch.el
1121 (bug#10145, bug#11381).
1122
b0572523
PE
11232012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1126
9660f5fc
SM
11272012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1128
1129 * lread.c (init_obarray): Declare Qt and Qnil as special.
1130
4374de83
GM
11312012-05-14 Glenn Morris <rgm@gnu.org>
1132
1133 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1134 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1135
dc44c39a
PE
11362012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1137
078c97cb
PE
1138 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1139
dc44c39a
PE
1140 * unexaix.c: Port to more-recent AIX compilers.
1141 (report_error, report_error_1, make_hdr, copy_sym)
1142 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1143 Make arguments const char *, not char *, to avoid violations of C
1144 standard and to fix some AIX warnings reported by Gilles Pion.
1145
e18afed7 11462012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1147
1148 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1149 already have overlays loaded.
1150 (handle_single_display_spec): Before returning without displaying
1151 fringe bitmap, synchronize the bidi iterator with the main display
1152 iterator, by calling iterate_out_of_display_property.
1153 (iterate_out_of_display_property): Detect buffer iteration by
1154 testing that it->string is a Lisp string.
1155 (get_next_display_element): When the current object is exhausted,
1156 and there's something on it->stack, call set_iterator_to_next to
1157 proceed with what's on the stack, instead of returning zero.
1158 (set_iterator_to_next): If called at the end of a Lisp string,
1159 proceed to consider_string_end without incrementing string
1160 position. Don't increment display vector index past the end of
1161 the display vector. (Bug#11417)
c8fb9dc6
EZ
1162 (pos_visible_p): Don't report a position visible when move_it_to
1163 stopped at the last line of window, which happens to be scanned
1164 backwards by the bidi iteration. (Bug#11464)
ac268e67 1165
e18afed7 11662012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1167
1168 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1169 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1170 are on a TTY, and thus unable to display on the fringes.
1171 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1172 so we need to signal to the caller that this is a "replacing"
1173 display spec. This fixes display when the spec is invalid or we
1174 are on a TTY.
1175
e18afed7 11762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1177
1178 * unexaix.c (make_hdr): Fix typo in prototype.
1179 This bug broke the build on AIX. Problem reported by Gilles Pion.
1180
9d0a235a
MA
11812012-05-14 Michael Albinus <michael.albinus@gmx.de>
1182
1183 * keyboard.c (kbd_buffer_get_event): Read special events also in
1184 batch mode. (Bug#11415)
1185
9e6b06ed
GM
11862012-05-12 Glenn Morris <rgm@gnu.org>
1187
1188 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1189
c1a1d7a3
EZ
11902012-05-12 Eli Zaretskii <eliz@gnu.org>
1191
1192 * lisp.mk (lisp): Add newcomment.elc.
1193
3fe7cdc8
GM
11942012-05-12 Glenn Morris <rgm@gnu.org>
1195
1196 * Makefile.in (MKDIR_P): New, set by configure.
1197 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1198
53f7d2c0
PE
11992012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 Remove unused function hourglass_started.
1202 * dispextern.h (hourglass_started):
1203 * w32fns.c (hourglass_started):
1204 * xdisp.c (hourglass_started): Remove.
1205
75aafb17
JB
12062012-05-10 Juanma Barranquero <lekktu@gmail.com>
1207
1208 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1209 Update dependencies.
1210
12959e8e
PE
12112012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1212
97107e2e
PE
1213 * xgselect.c (xg_select): Put maxfds+1 into a var.
1214 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1215
12959e8e
PE
1216 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1217
836d29b3
DA
12182012-05-10 Dave Abrahams <dave@boostpro.com>
1219
1220 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1221 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1222
5cb67954
MA
12232012-05-09 Michael Albinus <michael.albinus@gmx.de>
1224
1225 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1226 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1227 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1228 Initialize xd_registered_buses.
1229
3478ec45
PE
12302012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1231
b263a6b0
PE
1232 Untag more efficiently if USE_LSB_TAG.
1233 This is based on a proposal by YAMAMOTO Mitsuharu in
1234 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1235 For an admittedly artificial (nth 8000 longlist) benchmark on
1236 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1237 Emacs's overall text size by 1%.
1238 * lisp.h (XUNTAG): New macro.
1239 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1240 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1241 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1242 * eval.c (Fautoload):
1243 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1244 * frame.h (XFRAME): Use XUNTAG.
1245
3478ec45
PE
1246 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1247 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1248 Remove unportable assumptions about print widths of types like
1249 dbus_uint32_t.
1250 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1251 intptr_t when converting between pointer and integer, to avoid GCC
1252 warnings about wrong width.
1253
666b903b 12542012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1255
1256 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1257 stack for each reader_thread, instead of defaulting to 8MB
1258 determined by the linker. This avoids failures in creating
1259 subprocesses on Windows 7, see the discussion in this thread:
1260 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1261
b120cc17
JC
12622012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1263
1264 Fix up display of the *Minibuf-0* buffer in the mini window.
1265 * keyboard.c (read_char): Don't clear the echo area if there's no
1266 message to clear.
1267 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1268 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1269
9a4b36f8
MA
12702012-05-07 Michael Albinus <michael.albinus@gmx.de>
1271
1272 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1273 batch mode.
1274
e5f9458f
CY
12752012-05-06 Chong Yidong <cyd@gnu.org>
1276
1277 * lisp.mk (lisp): Update.
1278
eceeb5fc 12792012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1280
1281 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1282
71873e2b
SM
12832012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1284
1285 * data.c (PUT_ERROR): New macro.
1286 (syms_of_data): Use it. Add new error type `user-error'.
1287 * undo.c (user_error): New function.
1288 (Fprimitive_undo): Use it.
1289 * print.c (print_error_message): Adjust print style for `user-error'.
1290 * keyboard.c (user_error): New function.
1291 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1292
ab0fa4e4
PE
12932012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 Do not limit current-time-string to years 1000..9999.
1296 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1297 (Fcurrent_time_string): Support any year that is supported by the
1298 underlying localtime representation. Don't use asctime, as it
1299 has undefined behavior for years outside the range -999..9999.
1300
7ed806a7
PE
13012012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 Fix race conditions involving setenv, gmtime, localtime, asctime.
1304 Without this fix, interrupts could mess up code that uses these
1305 nonreentrant functions, since setting TZ invalidates existing
1306 tm_zone or tzname values, and since most of these functions return
1307 pointers to static storage.
1308 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1309 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1310 Grow the critical sections to include not just invoking
1311 localtime/gmtime, but also accessing these functions' results
1312 including their tm_zone values if any, and any related TZ setting.
1313 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1314 so that the struct tm is saved in the critical section.
1315 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1316 motivated by the fact that memory allocation needs to be outside
1317 the critical section.
1318
0c16dfed
DA
13192012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1320
1321 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1322 with RESET_INTERVAL.
1323
1324 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1325 Remove duplicated buffer name initialization.
1326
3f83ace8
JM
13272012-05-02 Jim Meyering <jim@meyering.net>
1328
1329 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1330
c7b8541e
JM
1331 * xfns.c (x_window): Use xstrdup (Bug#11375).
1332
90207a15 13332012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1334
1335 * xdisp.c (pos_visible_p): If already at a newline from the
1336 display string before the 'while' loop, don't walk back the glyphs
1337 from it3.glyph_row. Solves assertion violation when the display
1338 string begins with a newline (egg.el). (Bug#11367)
1339
b593d6a9
AH
13402012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1341
1342 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1343 Move to simple.el.
1344
4737362e
GM
13452012-05-01 Glenn Morris <rgm@gnu.org>
1346
99cf43f9
GM
1347 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1348 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1349 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1350 All were removed before 23.1.
1351
9311dcff
GM
1352 * dispnew.c: Remove HAVE_LIBNCURSES test;
1353 it is always true on relevant platforms.
1354
4d5c6349
GM
1355 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1356 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1357
4737362e
GM
1358 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1359
74dd3a6b
AS
13602012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1361
1362 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1363 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1364 Remove.
1365
13c379ee
PE
13662012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1367
1368 Do not avoid creating empty evaporating overlays (Bug#9642).
1369 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1370 That is, do not delete an evaporating overlay if it becomes
1371 empty after its bounds are adjusted to fit within its buffer.
1372 This fix caused other problems, and I'm reverting it until we get
1373 to the bottom of them.
1374
a8e7d6d7 13752012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1376
1377 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1378
a8e7d6d7 13792012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1380
1381 * xdisp.c (pos_visible_p): If the window start position is beyond
1382 ZV, start the display from buffer beginning. Prevents assertion
1383 violation in init_iterator when the minibuffer window is scrolled
1384 via the scroll bar.
1385
1386 * window.c (window_scroll_pixel_based): Likewise.
1387
a8e7d6d7 13882012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1389
1390 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1391
a8e7d6d7 13922012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1393
1394 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1395 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1396
a8e7d6d7 13972012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1398
b593d6a9
AH
1399 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1400 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1401
1c6900d9
EZ
14022012-04-26 Eli Zaretskii <eliz@gnu.org>
1403
4c3fa1d9
EZ
1404 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1405 display element, check also the underlying string or buffer
1406 character. (Bug#11341)
1407
1c6900d9
EZ
1408 * w32menu.c: Include w32heap.h.
1409 (add_menu_item): If the call to AppendMenuW (via
1410 unicode_append_menu) fails, disable Unicode menus only if we are
1411 running on Windows 9X/Me.
1412
42bf8205
AS
14132012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1414
1415 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1416 (xgetint): Add missing shift for LSB tags.
1417
b1bac16e
MR
14182012-04-24 Martin Rudalics <rudalics@gmx.at>
1419
1420 * keyboard.c (read_char): Don't wipe echo area for select window
1421 events: These might get delayed via `mouse-autoselect-window'
1422 (Bug#11304).
1423
d69621cc
JB
14242012-04-24 Juanma Barranquero <lekktu@gmail.com>
1425
1426 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1427 manipulation of :loaded-from data.
1428
02fd101b
JB
14292012-04-23 Juanma Barranquero <lekktu@gmail.com>
1430
1431 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1432 now a cons (bug#11311).
1433
888bec30
PE
14342012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1435
89a438bd
PE
1436 Do not create empty overlays with the evaporate property (Bug#9642).
1437 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1438 if it becomes empty after its bounds are adjusted to fit within
1439 its buffer. Without this fix, in a nonempty buffer (let ((o
1440 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1441 yields an empty overlay that has the evaporate property, which is
1442 not supposed to happen.
1443
1068fe4d
PE
1444 Fix minor GTK3 problems found by static checking.
1445 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1446 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1447 (struct _EmacsFixedClass, emacs_fixed_get_type):
1448 Move decls here from emacsgtkfixed.h, since they needn't be public.
1449 (emacs_fixed_get_type): Now static.
1450 (emacs_fixed_class_init): Omit unused local.
1451 (emacs_fixed_child_type): Remove; unused.
1452 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1453 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1454 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1455 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1456 (EMACS_FIXED_GET_CLASS): Remove; unused.
1457 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1458
888bec30
PE
1459 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1460 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1461
de85e130
PE
14622012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1463
d0baac98 1464 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1465 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1466 (__malloc_size_t, __malloc_ptrdiff_t):
1467 Remove. All uses removed, replaced by the definiens if needed,
1468 since we can assume C89 or better now.
1469 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1470 (protect_malloc_state, align, get_contiguous_space)
1471 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1472 (malloc_atfork_handler_child, malloc_enable_thread)
1473 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1474 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1475 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1476 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1477 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1478 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1479 Define using prototypes, not old style.
1480 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1481 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1482 (align): Don't assume that signed integer overflow wraps around.
1483 Omit unused local var.
1484 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1485 (_free_internal_nolock, memalign, mallochook, reallochook):
1486 Omit no-longer-needed casts.
1487 (valloc): Use getpagesize, not __getpagesize.
1488 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1489 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1490
de85e130
PE
1491 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1492
dcbf5805
MA
14932012-04-22 Michael Albinus <michael.albinus@gmx.de>
1494
1495 Move functions from C to Lisp. Make non-blocking method calls
1496 the default. Implement further D-Bus standard interfaces.
1497
1498 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1499 (QCdbus_request_name_allow_replacement)
1500 (QCdbus_request_name_replace_existing)
1501 (QCdbus_request_name_do_not_queue)
1502 (QCdbus_request_name_reply_primary_owner)
1503 (QCdbus_request_name_reply_in_queue)
1504 (QCdbus_request_name_reply_exists)
1505 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1506 (QCdbus_registered_serial, QCdbus_registered_method)
1507 (QCdbus_registered_signal): New Lisp objects.
1508 (XD_DEBUG_MESSAGE): Use sizeof.
1509 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1510 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1511 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1512 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1513 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1514 (xd_signature, xd_append_arg): Allow float for integer types.
1515 (xd_get_connection_references): New function.
b593d6a9
AH
1516 (xd_get_connection_address): Rename from xd_initialize.
1517 Return cached address.
dcbf5805
MA
1518 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1519 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1520 level.
1521 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1522 Return number of refcounts.
dcbf5805
MA
1523 (Fdbus_get_unique_name): Make stronger parameter check.
1524 (Fdbus_message_internal): New defun.
1525 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1526 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1527 (Fdbus_send_signal, Fdbus_register_service)
1528 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1529 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1530 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1531 (Vdbus_compiled_version, Vdbus_runtime_version)
1532 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1533 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1534 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1535 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1536 Adapt docstring.
dcbf5805 1537
52828e02
PE
15382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1539
da05bc4c
PE
1540 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1541 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1542 Do not assume ptrdiff_t is the same width as 'int'.
1543
52828e02
PE
1544 * alloc.c: Handle unusual debugging option combinations.
1545 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1546 since the two debugging options are incompatible.
1547 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1548 is defined.
1549 (mem_init, mem_insert, mem_insert_fixup):
1550 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1551 (NEED_MEM_INSERT): Remove; no longer needed.
1552
f01769f9
LL
15532012-04-22 Leo Liu <sdl.web@gmail.com>
1554
1555 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1556
5790543d
PE
15572012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * sysdep.c [__FreeBSD__]: Minor cleanups.
1560 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1561 Use Emacs indenting style more consistently. Avoid some casts.
1562 Use 'double' consistently rather than mixing 'float' and 'double'.
1563
b91b7e4d
EW
15642012-04-21 Eduard Wiebe <usenet@pusto.de>
1565
b593d6a9
AH
1566 * sysdep.c (list_system_processes, system_process_attributes):
1567 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1568
6114eb15
AS
15692012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1570
1571 * lisp.mk (lisp): Update.
1572
2f38dff7
PE
15732012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1576 It is never used otherwise.
1577
4ae29f89
SM
15782012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1579
1580 * print.c (print_preprocess): Only check print_depth if print-circle
1581 is nil.
1582 (print_object): Check for cycles even when print-circle is nil and
1583 print-gensym is t, but only check print_depth if print-circle is nil.
1584
f30d612a
CY
15852012-04-20 Chong Yidong <cyd@gnu.org>
1586
1587 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1588 set the status to "failed" and ensure that sentinel is run.
1589
c07a4c0b 15902012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1591
1592 * process.c (Fset_process_inherit_coding_system_flag)
1593 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1594 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1595
c07a4c0b 15962012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1597
1598 * xdisp.c (string_buffer_position_lim): Limit starting position to
1599 BEGV.
1600 (set_cursor_from_row): If called for a mode-line or header-line
1601 row, return zero immediately.
1602 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1603 farther than the first row after the header line, if any.
1604 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1605 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1606
c07a4c0b 16072012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1608
4ae29f89
SM
1609 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1610 (bug#11238).
ad3a2b41 1611
c07a4c0b 16122012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 16132012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1614
1615 configure: new option --enable-gcc-warnings (Bug#11207)
1616 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1617 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1618 (ALL_CFLAGS): Use new macros rather than old.
1619 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1620 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1621 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1622 -Wunused-result, -Wunused-variable. This should go away once
1623 the Emacs and Gnulib regex code is merged.
1624 (xmalloc, xrealloc): Now static.
1625
aba027e8
PE
16262012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * dired.c (Fsystem_groups): Remove unused local.
1629
e5a36063
GM
16302012-04-17 Glenn Morris <rgm@gnu.org>
1631
1632 * dired.c (Fsystem_users): Doc fix.
1633
316411f0
DA
16342012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1635
1636 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1637 (syms_of_dired): Add them.
1638
9426aba4
PE
16392012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1640
b62a57be
PE
1641 Fix minor alloc.c problems found by static checking.
1642 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1643 New extern decls, to avoid calling undeclared functions.
1644 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1645 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1646 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1647 (NEED_MEM_INSERT): New macro.
1648 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1649 Remove one incorrect comment and fix another.
b62a57be 1650
3539f31f
PE
1651 Fix minor ralloc.c problems found by static checking.
1652 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1653 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1654 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1655 (r_alloc_sbrk): Now static.
1656
a041960a
PE
1657 Improve ralloc.c interface checking.
1658 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1659 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1660 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1661 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1662 [REL_ALLOC]: ... to here, to check interface.
1663 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1664 Remove decls. This fixes an "It stinks!".
1665
9426aba4
PE
1666 * alloc.c (which_symbols): Fix alignment issue / type clash.
1667
d55c12ed
AS
16682012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1669
1670 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1671 (struct Lisp_Misc_Any): Likewise.
1672 (struct Lisp_Free): Likewise.
1673 * alloc.c (union aligned_Lisp_Symbol): Define.
1674 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1675 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1676 (union aligned_Lisp_Misc): Define.
1677 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1678 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1679 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1680
b948ce8b
PE
16812012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1684 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1685 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1686 * s/netbsd.h, s/sol2-6.h:
1687 Remove definition of GC_MARK_STACK, since the default now works.
1688 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1689 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1690 no longer the default.
1691 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1692
35dc09a1 16932012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1694
35dc09a1
GM
1695 * lread.c (lisp_file_lexically_bound_p):
1696 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 1697
35dc09a1
GM
16982012-04-14 Eli Zaretskii <eliz@gnu.org>
1699
1700 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1701 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1702
17032012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1704
1705 * nsterm.m (constrainFrameRect): Always constrain when there is only
1706 one screen (Bug#10962).
1707
bcd86815
KB
17082012-04-13 Ken Brown <kbrown@cornell.edu>
1709
1710 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1711
c25df26e
RT
17122012-04-13 Reuben Thomas <rrt@sc3d.org>
1713
1714 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1715
0fc59f1e
DC
17162012-04-11 Daniel Colascione <dancol@dancol.org>
1717
1718 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1719 against is gone. It's better to use vfork now so that when Cygwin
1720 gains a new, working vfork, we use it automatically (bug#10398).
1721
de8c03dc
SM
17222012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * window.c (save_window_save): Obey window-point-insertion-type.
1725
2f097256
GM
17262012-04-11 Glenn Morris <rgm@gnu.org>
1727
1728 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1729
453b951e
SM
17302012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1731
1732 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1733
75f1671a 17342012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
1735
1736 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1737 (force_quit_count): New var.
1738 (handle_interrupt): Use it.
1739
2a8ce227
JB
17402012-04-10 Juanma Barranquero <lekktu@gmail.com>
1741
1742 * w32.c (w32_delayed_load): Record the full path of the library
1743 being loaded (bug#10424).
1744
935396c0
GM
17452012-04-09 Glenn Morris <rgm@gnu.org>
1746
05920a43
GM
1747 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1748 not just in the obarray, before snarfing them. (Bug#11036)
1749
935396c0
GM
1750 * Makefile.in ($(leimdir)/leim-list.el):
1751 Pass EMACS rather than BUILT_EMACS.
1752
a18ecafa
TZ
17532012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1754
1755 * process.c (make_process):
1756 * process.h: Add integer `gnutls_handshakes_tried' member to
1757 process struct.
1758
6bbef4e5
JC
1759 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1760 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
1761
1762 * gnutls.c (gnutls_log_function2i): Convenience log function.
1763 (emacs_gnutls_read): Use new log functions,
1764 `gnutls_handshakes_tried' process member, and
1765 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1766 attempts per process (connection).
1767
b4d3bc10
CY
17682012-04-09 Chong Yidong <cyd@gnu.org>
1769
1770 * eval.c (Fuser_variable_p, user_variable_p_eh)
1771 (lisp_indirect_variable): Functions deleted.
1772 (Fdefvar): Caller changed.
1773
1774 * callint.c (Finteractive, Fcall_interactively):
1775 * minibuf.c (Fread_variable): Callers changed.
1776
70f4d973
EZ
17772012-04-09 Eli Zaretskii <eliz@gnu.org>
1778
1779 * xdisp.c (set_cursor_from_row): If the display string appears in
1780 the buffer at position that is closer to point than the position
1781 after the display string, display the cursor on the first glyph of
1782 the display string. Fixes cursor display when a 'display' text
1783 property immediately follows invisible text. (Bug#11094)
1784
cb3c2e3e
PE
17852012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 composite.c: use 'double' consistently
1788 * composite.c (get_composition_id): Use 'double' consistently
1789 instead of converting 'float' to 'double' and vice versa; this is
1790 easier to understand and avoids a GCC warning.
1791
fd06db5d
GM
17922012-04-09 Glenn Morris <rgm@gnu.org>
1793
50fe702a
GM
1794 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1795 preparation for dumping it with emacs. (Bug#4789)
1796 (leimdir): New variable.
1797 ($(leimdir)/leim-list.el): New rule.
1798 (emacs$(EXEEXT)): Depend on leim-list.el.
1799
fd06db5d
GM
1800 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1801 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1802 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1803
55c131ee
AS
18042012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1805
1806 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1807 proper alignment.
1808
9209588f
JB
18092012-04-07 Juanma Barranquero <lekktu@gmail.com>
1810
1811 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1812 Remove unused local variable.
1813
e3fb2efb
PE
18142012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1815
1816 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1817 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1818 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1819 objects, as mark_maybe_pointer will catch them otherwise.
1820 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1821 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1822
b5385551
PE
18232012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1824
1825 Fix typo that broke non-Windows builds.
1826 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1827
9078ead6
EZ
18282012-04-07 Eli Zaretskii <eliz@gnu.org>
1829
1830 Support building on MS-Windows with libxml2.
1831
1832 * makefile.w32-in (OBJ2): Add xml.$(O).
1833 (GLOBAL_SOURCES): Add xml.c.
1834 ($(BLD)/xml.$(O)): New dependency list.
1835
1836 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1837 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1838 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1839 [!WINDOWSNT]: New macros.
1840 (init_libxml2_functions, libxml2_loaded_p): New functions.
1841 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1842 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1843 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1844 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1845 linked in).
6bbef4e5
JC
1846 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1847 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
1848 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1849
1850 * emacs.c: Don't include libxml/parser.h.
1851 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1852 xmlCleanupParser directly.
1853
1854 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1855
3811fdf3
EZ
18562012-04-07 Eli Zaretskii <eliz@gnu.org>
1857
1858 * indent.c (Fvertical_motion): If there is a display string at
1859 point, use it.vpos to compute how many lines to backtrack after
1860 move_it_to point. (Bug#11133)
1861
2f8e16b2
EZ
18622012-04-06 Eli Zaretskii <eliz@gnu.org>
1863
1864 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1865 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1866 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1867 macros related to unification of CJK characters. For the details,
1868 see the discussion following the message here:
1869 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1870
3d439cd1
CY
18712012-04-04 Chong Yidong <cyd@gnu.org>
1872
1873 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1874
8bc53d00
EZ
18752012-04-01 Eli Zaretskii <eliz@gnu.org>
1876
1877 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1878 instead of alloca. (Bug#11138)
1879
3b0512a3
AS
18802012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1881
1882 * w32menu.c (is_simple_dialog): Properly check lisp types.
1883 (Bug#11141)
1884
8427ddd2
EZ
18852012-03-31 Eli Zaretskii <eliz@gnu.org>
1886
979022ef
EZ
1887 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1888 position we get to after a call to move_it_to fails the
1889 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1890 only if we wind up in a string from display property. (Bug#11063)
1891
a6b1c7cc
EZ
1892 * window.c (Fdelete_other_windows_internal): Invalidate the row
1893 and column information about mouse highlight, so that redisplay
1894 restores it after reallocating the glyph matrices. (Bug#7464)
1895
8427ddd2
EZ
1896 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1897 string comes from a `display' text property, use the buffer
1898 position of that property as if we actually saw that position in
1899 the row's glyphs.
697ba24b
EZ
1900 (move_it_by_lines): Remove the assertion that
1901 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1902 violated when there's a before-string at the beginning of a line.
1903 (Bug#11063)
8427ddd2 1904
65a0a738
EZ
19052012-03-30 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (append_space_for_newline): If the default face was
1908 remapped, use the remapped face for the appended newline.
1909 (extend_face_to_end_of_line): Use the remapped default face for
1910 extending the face to the end of the line.
1911 (display_line): Call extend_face_to_end_of_line when the default
1912 face was remapped. (Bug#11068)
1913
581355cc
EZ
19142012-03-29 Eli Zaretskii <eliz@gnu.org>
1915
1916 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1917
e8fc049f
SM
19182012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1919
1920 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1921
4fb9a543
GM
19222012-03-27 Glenn Morris <rgm@gnu.org>
1923
1924 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1925 Doc fixes.
1926
679910f1
KH
19272012-03-26 Kenichi Handa <handa@m17n.org>
1928
1929 * dispextern.h (struct glyph): Fix previous change. Change the
1930 bit length of glyphless.ch to 25 (Bug#11082).
1931
90d49b7f
CY
19322012-03-26 Chong Yidong <cyd@gnu.org>
1933
1934 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1935 (command_loop_1): Use it; inhibit selection update for
1936 handle-select-window too (Bug#8996).
1937
f514f6f0
FP
19382012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1939
e8fc049f 1940 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 1941
bf43fa51
KH
19422012-03-25 Kenichi Handa <handa@m17n.org>
1943
1944 * dispextern.h (struct glyph): Change the bit length of
1945 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1946
8a0c01dd
EZ
19472012-03-24 Eli Zaretskii <eliz@gnu.org>
1948
1949 * s/ms-w32.h (tzname): Include time.h before redirecting to
1950 _tzname. Fixes the MSVC build. (Bug#9960)
1951
7d1c3a76
AS
19522012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1953
8ed79523
AS
1954 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1955 characters.
1956
7d1c3a76
AS
1957 * xterm.c (XTread_socket): Only modify handling_signal if
1958 !SYNC_INPUT. (Bug#11080)
1959
e99a9b8b
EZ
19602012-03-23 Eli Zaretskii <eliz@gnu.org>
1961
1962 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1963 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1964 when fetching a multibyte character consumes more bytes than
1965 CHAR_BYTES returns, due to unification of CJK characters in
1966 string_char. (Bug#11073)
1967
5063c0e1
TN
19682012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1969
1970 * process.c (wait_reading_process_output): Handle pty disconnect
1971 by refraining from sending oneself a SIGCHLD (bug#10933).
1972
9f851fbd
CY
19732012-03-22 Chong Yidong <cyd@gnu.org>
1974
1975 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1976
5063c0e1 1977 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
1978 Mark string as coming from a prefix property.
1979 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1980 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1981
fb5b8aca
CY
19822012-03-21 Chong Yidong <cyd@gnu.org>
1983
1984 * xfaces.c (Vface_remapping_alist): Doc fix.
1985
62356a1b
EZ
19862012-03-20 Eli Zaretskii <eliz@gnu.org>
1987
1988 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
1989 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1990 Doc fixes.
62356a1b 1991
025de85b
CY
19922012-03-20 Chong Yidong <cyd@gnu.org>
1993
1994 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1995 to reflect default non-nil value of redisplay-dont-pause.
1996
4827f94e
KH
19972012-03-19 Kenichi Handa <handa@m17n.org>
1998
1999 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2000 it fit in a valid range (Bug#11003).
2001
e50a24a2
EZ
20022012-03-18 Eli Zaretskii <eliz@gnu.org>
2003
2004 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2005 that is not from display property, accept the row as a "cursor
2006 row" if one of the string's character has a non-nil `cursor'
2007 property. Fixes cursor positioning when there are newlines in
2008 overlay strings, e.g. in icomplete.el. (Bug#11035)
2009
9af5ed87
PE
20102012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2013
d1f55f16
CY
20142012-03-12 Chong Yidong <cyd@gnu.org>
2015
2016 * eval.c (inhibit_lisp_code): Rename from
2017 inhibit_window_configuration_change_hook; move from window.c.
2018
2019 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2020 * window.c (run_window_configuration_change_hook)
2021 (syms_of_window): Callers changed.
2022
66c5eebd
CY
20232012-03-11 Chong Yidong <cyd@gnu.org>
2024
413df973
CY
2025 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2026
66c5eebd
CY
2027 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2028
1de11f56
CY
20292012-03-10 Chong Yidong <cyd@gnu.org>
2030
2031 * frame.c (other_visible_frames): Don't assume the selected frame
2032 is visible (Bug#10955).
2033
cae07000
SM
20342012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2035
2036 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2037
89c94350
JD
20382012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2039
2040 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2041 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2042 zero (Bug#10954).
2043
999dd333
GM
20442012-03-03 Glenn Morris <rgm@gnu.org>
2045
01a6dcc8 2046 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2047
de0100f2
EZ
20482012-03-02 Eli Zaretskii <eliz@gnu.org>
2049
2050 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2051 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2052 (redisplay_window, next_element_from_string): Fix typos in
2053 comments.
3e441275
EZ
2054 (redisplay_window): Pass to move_it_vertically the margin in
2055 pixels, not in screen lines.
de0100f2 2056
96a72ee9
GM
20572012-03-02 Glenn Morris <rgm@gnu.org>
2058
2059 * buffer.c (buffer-list-update-hook): Doc fix.
2060
312508d7
EZ
20612012-02-29 Eli Zaretskii <eliz@gnu.org>
2062
2063 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2064 push_it before setting up the iterator for the first overlay
2065 string, even if we have an empty string loaded.
2066 (next_overlay_string): If there's an empty string on the iterator
2067 stack, pop the stack. (Bug#10903)
2068
27f3c637
PE
20692012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2072 Suggested by Stefan Monnier in
2073 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2074 * alloc.c (widen_to_Lisp_Object): New static function.
2075 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2076 and widening them to Lisp_Objects. This would work even if
2077 USE_LSB_TAG is defined and wide integers are used, which might
2078 happen in a future version of Emacs.
2079
3c9dfce6
CY
20802012-02-25 Chong Yidong <cyd@gnu.org>
2081
fa74b241
CY
2082 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2083 Doc fix.
2084
3c9dfce6
CY
2085 * xselect.c (Fx_selection_exists_p): Doc fix.
2086 (x_clipboard_manager_save_all): Print an informative message
2087 before saving to clipboard manager.
2088
9486df08
CY
20892012-02-24 Chong Yidong <cyd@gnu.org>
2090
2091 * keyboard.c (process_special_events): Handle all X selection
2092 requests in kbd_buffer, not just the next one (Bug#8869).
2093
f01d3321
CY
20942012-02-23 Chong Yidong <cyd@gnu.org>
2095
2096 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2097 call when setting menu-bar-lines and tool-bar-lines parameters.
2098 (unwind_create_frame_1): New helper function.
2099
2100 * window.c (inhibit_window_configuration_change_hook): New var.
2101 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2102 (syms_of_window): Initialize it.
f01d3321 2103
86b847b6
CY
21042012-02-22 Chong Yidong <cyd@gnu.org>
2105
2106 * xterm.c (x_draw_image_relief): Add missing type check for
2107 Vtool_bar_button_margin (Bug#10743).
2108
a59225b1
CY
21092012-02-21 Chong Yidong <cyd@gnu.org>
2110
2111 * fileio.c (Vfile_name_handler_alist): Doc fix.
2112
2113 * buffer.c (Fget_file_buffer): Protect against invalid file
2114 handler return value.
2115
310f5bd4
PE
21162012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2117
cb3a28cc
PE
2118 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2119 when computing $valmask.
2120
310f5bd4
PE
2121 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2122 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2123 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2124 It's useless in that case, and it can cause problems on hosts
2125 that allocate halves of EMACS_INT values separately.
2126 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2127 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2128 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2129 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2130 it avoids undefined behavior on hosts where shifting right by more
2131 than the word width has undefined behavior.
2132
2375c96a
CY
21332012-02-19 Chong Yidong <cyd@gnu.org>
2134
2135 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2136 (Funhandled_file_name_directory, Ffile_name_as_directory)
2137 (Fdirectory_file_name, Fexpand_file_name)
2138 (Fsubstitute_in_file_name): Protect against invalid file handler
2139 return values (Bug#10845).
2140
3eb49e71
EZ
21412012-02-18 Eli Zaretskii <eliz@gnu.org>
2142
2143 * .gdbinit (pitx): Fix incorrect references to fields of the
2144 iterator stack.
2145
7b926f3f
CY
21462012-02-17 Chong Yidong <cyd@gnu.org>
2147
2148 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2149
11273115
PE
21502012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2153 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2154
c3a70e2b
CY
21552012-02-15 Chong Yidong <cyd@gnu.org>
2156
2157 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2158 marked as special. Also, starting docstrings with * is obsolete.
2159
0ca43699
AS
21602012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2161
2162 * gnutls.c (emacs_gnutls_write): Fix last change.
2163
2e8f3c56
LI
21642012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2165
2166 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2167 send_process.
2168
af70074f
SM
21692012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2170
2171 * keymap.c (Fsingle_key_description): Handle char ranges.
2172
95986d52
CY
21732012-02-12 Chong Yidong <cyd@gnu.org>
2174
afd83bd1
CY
2175 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2176 as that creates a dangerous corner case.
2177
95986d52
CY
2178 * window.c (Fdelete_window_internal): Invalidate the mouse
2179 highlight (Bug#9904).
2180
bd7da63e
GM
21812012-02-12 Glenn Morris <rgm@gnu.org>
2182
2183 * xselect.c (Fx_own_selection_internal)
2184 (Fx_get_selection_internal, Fx_disown_selection_internal)
2185 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2186 * nsselect.m (Fx_own_selection_internal)
2187 (Fx_disown_selection_internal, Fx_selection_exists_p)
2188 (Fx_selection_owner_p, Fx_get_selection_internal):
2189 Sync docs and argument specs with the xselect.c versions.
2190
77abcbc2
LI
21912012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2192
2193 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2194
90b671e2
EZ
21952012-02-11 Eli Zaretskii <eliz@gnu.org>
2196
1c0ca0b7
EZ
2197 * w32select.c (Fx_selection_exists_p): Sync doc string and
2198 argument list with xselect.c. (Bug#10783)
2199
2200 * w16select.c (Fx_selection_exists_p): Sync doc string and
2201 argument list with xselect.c. (Bug#10783)
90b671e2 2202
49241268
GM
22032012-02-10 Glenn Morris <rgm@gnu.org>
2204
2205 * fns.c (Fsecure_hash): Doc fix.
2206
f998bbe7 22072012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2208
2209 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2210
0992bd9c
CY
22112012-02-07 Chong Yidong <cyd@gnu.org>
2212
2213 * buffer.c (Fbuffer_local_variables)
2214 (buffer_lisp_local_variables): Handle unbound vars correctly;
2215 don't let Qunbound leak into Lisp.
2216
af008560
GM
22172012-02-07 Glenn Morris <rgm@gnu.org>
2218
dd605cc4
GM
2219 * image.c (Fimagemagick_types): Doc fix.
2220
af008560
GM
2221 * image.c (imagemagick-render-type): Change it from a lisp object
2222 to an integer. Move the doc here from the lisp manual.
2223 Treat all values not equal to 0 the same.
2224
1449fa1d
CY
22252012-02-06 Chong Yidong <cyd@gnu.org>
2226
2227 * doc.c (store_function_docstring): Avoid applying docstring of
2228 alias to base function (Bug#2603).
2229
3723ec07
AS
22302012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2231
2232 * .gdbinit (pp1, pv1): Remove redundant defines.
2233 (pr): Use pp.
2234
79c1cc1e
CY
22352012-02-04 Chong Yidong <cyd@gnu.org>
2236
2237 * nsterm.m: Declare a global (Bug#10694).
2238
d7f29f8e
EZ
22392012-02-04 Eli Zaretskii <eliz@gnu.org>
2240
cae07000
SM
2241 * w32.c (get_emacs_configuration_options):
2242 Include --enable-checking, if specified, in the return value.
d7f29f8e 2243
3b95a6f9
MR
22442012-02-04 Martin Rudalics <rudalics@gmx.at>
2245
2246 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2247 after rounding frame sizes. (Bug#9723)
2248
d6fa96a6
EZ
22492012-02-04 Eli Zaretskii <eliz@gnu.org>
2250
2251 * keyboard.c (adjust_point_for_property): Don't position point
2252 before BEGV. (Bug#10696)
2253
df0b2940
PE
22542012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 Handle overflow when computing char display width (Bug#9496).
2257 * character.c (char_width): Return EMACS_INT, not int.
2258 (char_width, c_string_width): Check for overflow when
2259 computing the width; this is possible now that individual
2260 characters can have unbounded width. Problem introduced
2261 by merge from Emacs 23 on 2012-01-19.
2262
6bee44d6
MA
22632012-02-02 Michael Albinus <michael.albinus@gmx.de>
2264
2265 * dbusbind.c (Fdbus_register_method): Mention the return value
2266 :ignore in the docstring.
2267
44f92739
GM
22682012-02-02 Glenn Morris <rgm@gnu.org>
2269
1b9f60cc
GM
2270 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2271
44f92739
GM
2272 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2273 Unconditionally set to t. (Bug#10673)
2274 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2275 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2276 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2277
c5d3843c
KH
22782012-02-02 Kenichi Handa <handa@m17n.org>
2279
2280 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2281 0, do not call append_composite_glyph.
2282
159462d4 22832012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2284
2285 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2286 NULL (Bug#6988).
2287 (x_produce_glyphs): If the component of a composition is a null
2288 string, set it->pixel_width to 1 to avoid zero-width glyph.
2289
78cef877
EZ
22902012-02-01 Eli Zaretskii <eliz@gnu.org>
2291
2292 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2293 first 2 arguments are identical. This makes inserting large
2294 output from a subprocess an order of magnitude faster on
2295 MS-Windows, where all sbrk'ed memory is always contiguous.
2296
97897668
GM
22972012-01-31 Glenn Morris <rgm@gnu.org>
2298
2299 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2300 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2301 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2302
31fd3586
GM
23032012-01-29 Glenn Morris <rgm@gnu.org>
2304
2305 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2306
0e24a8b2
CY
23072012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2308
2309 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2310
cc0adcb0
CY
23112012-01-28 Chong Yidong <cyd@gnu.org>
2312
2313 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2314
acc28cb9
CY
23152012-01-26 Chong Yidong <cyd@gnu.org>
2316
9c69cfb7
CY
2317 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2318
acc28cb9
CY
2319 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2320 repeat counts (Bug#10507).
2321
48da7392
GM
23222012-01-26 Glenn Morris <rgm@gnu.org>
2323
2324 * lread.c (syms_of_lread): Doc fix.
2325
14af5f7f
CY
23262012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2327
2328 * coding.c (encode_designation_at_bol): Change return value to
2329 EMACS_INT.
2330
0b21c100
CY
23312012-01-25 Chong Yidong <cyd@gnu.org>
2332
2333 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2334
3c2907f7
CY
23352012-01-21 Chong Yidong <cyd@gnu.org>
2336
2337 * floatfns.c (Fcopysign): Make the second argument non-optional,
2338 since nil is not allowed anyway.
2339
959ad23f
AS
23402012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2341
2342 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2343 (send_process): Likewise.
2344
34a02f46
MR
23452012-01-19 Martin Rudalics <rudalics@gmx.at>
2346
2347 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2348 (Vwindow_persistent_parameters): Do not use Qstate.
2349 Rewrite doc-strings.
34a02f46 2350
1259009a 23512012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2352
2353 * character.c (char_width): New function.
70d4fdf6
GM
2354 (Fchar_width, c_string_width, lisp_string_width):
2355 Use char_width (Bug#9496).
25ed9e61 2356
6a6ee00d
MR
23572012-01-16 Martin Rudalics <rudalics@gmx.at>
2358
2359 * window.c (Vwindow_persistent_parameters): New variable.
2360 (Fset_window_configuration, save_window_save): Handle persistent
2361 window parameters.
2362
c85efaf7
EZ
23632012-01-14 Eli Zaretskii <eliz@gnu.org>
2364
2365 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2366 thrashing the stack of the thread. (Bug#9087)
2367
5944709e
PE
23682012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2371
e71f5d99
EZ
23722012-01-11 Eli Zaretskii <eliz@gnu.org>
2373
2374 * xdisp.c (rows_from_pos_range): Handle the case where the
2375 highlight ends on a newline. (Bug#10464)
2376 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2377 he end column for display of highlight that ends on a newline
2378 before a R2L line.
2379
ce316182
GM
23802012-01-11 Glenn Morris <rgm@gnu.org>
2381
2382 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2383 from load-path also when installation-directory is nil. (Bug#10208)
2384
5b43da69
GM
23852012-01-10 Glenn Morris <rgm@gnu.org>
2386
74cc8ff9
GM
2387 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2388
7d8d6e4e
GM
2389 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2390 Update template values to be closer to their typical values these days.
5b43da69 2391
a0db8d43
EZ
23922012-01-09 Eli Zaretskii <eliz@gnu.org>
2393
2394 * xdisp.c (rows_from_pos_range): Accept additional argument
2395 DISP_STRING, and accept any glyph in a row whose object is that
2396 string as eligible for mouse highlight. Fixes mouse highlight of
2397 display strings from overlays. (Bug#10464)
2398
9a0115ab 23992012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2400
b9110d6a 2401 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2402 * fileio.c (auto_saving_dir_umask): New static var.
2403 (Fmake_directory_internal): Use it.
2404 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2405 creating the directory. The old code temporarily assigns
2406 too-generous permissions to the directory.
2407 (do_auto_save_eh): Clear it.
b9110d6a 2408 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2409 that the var is always cleared.
2410
6c1bd3f3
EZ
24112012-01-07 Eli Zaretskii <eliz@gnu.org>
2412
2413 * search.c (scan_buffer): Pass character positions to
2414 know_region_cache, not byte positions. (Bug#6540)
2415
069d2b50
L
24162012-01-07 LynX <_LynX@bk.ru> (tiny change)
2417
2418 * w32.c (sys_rename): Report EXDEV when rename of a directory
2419 fails because the target is on another logical disk. (Bug#10284)
2420
75bf0d33
DB
24212012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2422
2423 * xterm.c (x_embed_request_focus): New function.
2424
2425 * xterm.h: Add prototype.
2426
2427 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2428
1c6e5a32
GM
24292012-01-05 Glenn Morris <rgm@gnu.org>
2430
2431 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2432
651e947e
EZ
24332012-01-01 Eli Zaretskii <eliz@gnu.org>
2434
2435 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2436 Load gnutls_transport_set_lowat only if GnuTLS version is below
2437 2.11.1.
2438 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2439 GnuTLS versions below 2.11.1.
2440
3778cdd8
AL
24412011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2442
2443 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2444 to the doc string advising against its use for altering the way
2445 windows are scrolled.
2446
0e5317f7
KH
24472011-12-28 Kenichi Handa <handa@m17n.org>
2448
2449 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2450 coding-system ASCII compatible only when it does not produce BOM
2451 on encoding (Bug#10383).
2452
93d5ca1f
JD
24532011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2454
2455 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2456 can scroll.
2457 (create_and_show_popup_menu): Always use menu_position_func for
2458 Gtk3 (Bug#10361).
2459
ca22b785
AS
24602011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2461
2462 * callint.c (Fcall_interactively): Don't truncate prompt string.
2463
d048e1e6
EZ
24642011-12-23 Eli Zaretskii <eliz@gnu.org>
2465
2466 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2467 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2468 resumed from there (after widening). (Bug#10360)
d048e1e6 2469
5ccaba1f
JD
24702011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2471
2472 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2473
204ee57f
JD
24742011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2475
b81d40f0
JB
2476 * nsterm.m (x_free_frame_resources):
2477 Release f->output_data.ns->miniimage.
204ee57f
JD
2478 (ns_index_color): Fix indentation. Do not retain
2479 color_table->colors[i].
2480
2481 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2482 before returning.
2483
2484 * nsfns.m (x_set_background_color): Assign return value from
2485 ns_index_color to face-background instead of NSColor*.
2486 (ns_implicitly_set_icon_type): Fix indentation.
2487 Change assignment in for loop to comparison.
2488
2489 * emacs.c (ns_pool): New variable.
2490 (main): Assign ns_pool.
2491 (Fkill_emacs): Call ns_release_autorelease_pool.
2492
2493 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2494 autorelease fdesc, release fdAttrs and tdict.
2495 (ns_get_covering_families): Release charset.
2496 (ns_findfonts): Release NSFontDescriptor created with new.
2497 (ns_uni_to_glyphs): Fix indentation.
2498 (setString): Release attrStr before assigning new value.
2499
c803b2b7
JD
25002011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2501
678f4426
JD
2502 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2503 and NS_IMPL_COCOA.
2504 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2505 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2506
cd394be1 25072011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2508
5fecd5fc
JD
2509 * nsterm.m (ns_term_init): Subscribe for notifications
2510 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2511 to method trackingNotification in EmacsMenu.
2512
2513 * nsmenu.m (trackingMenu): New variable.
3771cb17 2514 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2515 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2516 from Aquamacs (Bug#7030).
678f4426
JD
2517
25182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2519
c803b2b7
JD
2520 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2521 (symbol_to_nsstring): Fix indentation.
2522 (ns_symbol_to_pb): New function.
cae07000
SM
2523 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2524 (Fns_rotate_cut_buffers_internal): Remove.
2525 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2526 Fns_store_cut_buffer_internal.
2527 (ns_get_foreign_selection, Fx_own_selection_internal)
2528 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2529 (Fns_get_selection_internal, Fns_store_selection_internal):
2530 Use ns_symbol_to_pb and check if return value is nil.
2531 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2532 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2533 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2534 renamed to Sns_store_selection_internal.
2535 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2536 and remove this function.
2537 (ns_handle_selection_clear): Remove, never used.
2538 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2539 here.
2540
e1b01a3a
KB
25412011-12-17 Ken Brown <kbrown@cornell.edu>
2542
2543 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2544 GID is unknown (Bug#10257).
2545
2adb6e85
PE
25462011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2549 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2550 which caused a build failure on GNU/Linux IA-64. This problem was
2551 introduced by my 2011-10-07 patch.
2552
d1d7b339
JL
25532011-12-15 Juri Linkov <juri@jurta.org>
2554
2555 * image.c (imagemagick_error): New function. (Bug#10112)
2556 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2557 Use `imagemagick_error' where ImageMagick functions return
2558 `MagickFalse'.
2559 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2560 proper order.
2561
100d5755
KH
25622011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2563
2564 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2565 fill background (Bug#8992).
2566
454592a6
MR
25672011-12-13 Martin Rudalics <rudalics@gmx.at>
2568
2569 * window.c (Vwindow_combination_resize)
2570 (Vwindow_combination_limit): Use t instead of non-nil in
2571 doc-strings.
61d4b438
MR
2572 (Vrecenter_redisplay): Add first sentence of doc-string on
2573 separate line.
53524d93 2574 (Frecenter): Fix doc-string typo.
454592a6 2575
3633e3aa
KH
25762011-12-11 Kenichi Handa <handa@m17n.org>
2577
2578 * coding.c (Funencodable_char_position): Pay attention to the
2579 buffer text relocation (Bug#9389).
2580
7b9d523a 25812011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2582
7b9d523a
JD
2583 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2584 gtk_init (Bug#10100).
2585
b73189c6
EZ
25862011-12-10 Eli Zaretskii <eliz@gnu.org>
2587
2588 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2589 IT->string is nil. (Bug#10263)
2590
f7dfe5d6
JD
25912011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2592
83faebb4
JD
2593 * nsterm.h (x_free_frame_resources): Declare.
2594
f7dfe5d6
JD
2595 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2596 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2597
2598 * nsterm.h (ns_get_defaults_value): Declare.
2599
2600 * nsterm.m (ns_default): Call ns_get_defaults_value.
2601
7cd4e72c
EZ
26022011-12-09 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2605 (Bug#10170)
2606
b34d7317
YM
26072011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2608
2609 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2610 that where the value of an _OBJC_* symbol points to is in the .bss
2611 section (Bug#10240).
2612
76470ad1
KH
26132011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2614
2615 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2616 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2617
745fff94
KH
26182011-12-08 Kenichi Handa <handa@m17n.org>
2619
2620 * ftfont.c (get_adstyle_property): Fix previous change
2621 (Bug#10233).
2622
6e44397c
JB
26232011-12-07 Juanma Barranquero <lekktu@gmail.com>
2624
2625 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2626 dirs from the default value of EMACSLOADPATH (bug#10208).
2627
7efa6272
GM
26282011-12-07 Glenn Morris <rgm@gnu.org>
2629
2630 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2631 installation and source directories as well. (Bug#10208)
2632
f6fc4d87
CY
26332011-12-06 Chong Yidong <cyd@gnu.org>
2634
2635 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2636
2bf26180
GM
26372011-12-06 Glenn Morris <rgm@gnu.org>
2638
2639 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2640 as an error, not just -1. (Bug#10217)
2641
3a6ad4f0
CY
26422011-12-05 Chong Yidong <cyd@gnu.org>
2643
2644 * keyboard.c (process_special_events): New function.
2645 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2646
75a3b399
PE
26472011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 * coding.c (encode_designation_at_bol): Don't use uninitialized
2650 local variable (Bug#9318).
2651
c3c9e25e
KH
26522011-12-05 Kenichi Handa <handa@m17n.org>
2653
2654 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2655 return Qnil (Bug#8046, Bug#10193).
2656
5eb05ea3
KH
26572011-12-05 Kenichi Handa <handa@m17n.org>
2658
2659 * coding.c (encode_designation_at_bol): New args charbuf_end and
2660 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2661 (coding_set_source): Return how many bytes coding->source was
2662 relocated.
2663 (coding_set_destination): Return how many bytes
2664 coding->destination was relocated.
2665 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2666 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2667
26682011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2669
2670 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2671 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2672 macro (Bug#9318).
2673
26742011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2675
2676 The following changes are to fix Bug#9318.
2677
a79703f5 2678 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2679 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2680 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2681 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2682
7dbda6df
JB
26832011-12-05 Juanma Barranquero <lekktu@gmail.com>
2684
2685 * lisp.h (process_quit_flag): Fix external declaration.
2686
6d5eb5b0
SM
26872011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2688
2689 Don't macro-inline non-performance-critical code.
2690 * eval.c (process_quit_flag): New function.
2691 * lisp.h (QUIT): Use it.
2692
a0c3fad0
JD
26932011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2694
2695 * nsfns.m (get_geometry_from_preferences): New function.
2696 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2697
6c07aac2
AS
26982011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2699
2700 * emacs.c (Qkill_emacs): Define.
2701 (syms_of_emacs): Initialize it.
2702 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2703 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
2704 (quit_throw_to_read_char): Add parameter `from_signal'.
2705 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
2706 * lisp.h (QUIT): Call Fkill_emacs if requested.
2707
c052ead4
JD
27082011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2709
2710 * widget.c (update_wm_hints): Return if wmshell is null.
2711 (widget_update_wm_size_hints): New function.
2712
2713 * widget.h (widget_update_wm_size_hints): Declare.
2714
2715 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2716 widget_update_wm_size_hints (Bug#10104).
2717
9e49252b
EZ
27182011-12-03 Eli Zaretskii <eliz@gnu.org>
2719
2720 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2721 before a newline, prepare the bidi iterator for consuming the
2722 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 2723 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 2724
02b16839
JL
27252011-12-02 Juri Linkov <juri@jurta.org>
2726
2727 * search.c (Fword_search_regexp): New Lisp function created from
2728 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2729 (Fword_search_backward, Fword_search_forward)
2730 (Fword_search_backward_lax, Fword_search_forward_lax):
2731 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2732 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2733
0068070e
SM
27342011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2735
2736 * fileio.c (Finsert_file_contents): Move after-change-function call
2737 to before the "handled:" label, since all "goto handled" appear in
2738 cases where the *-change-functions have already been properly called
2739 (bug#10117).
2740
3360a3fc
AS
27412011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2742
2743 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2744 waiting for input. (Bug#10169)
2745
73d6c093
EZ
27462011-11-30 Eli Zaretskii <eliz@gnu.org>
2747
2748 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2749 verifies glyph row's hash code--we have just reallocated the
2750 glyphs, so their contents can be complete garbage. (Bug#10164)
2751
febe6bea
JB
27522011-11-30 Juanma Barranquero <lekktu@gmail.com>
2753
2754 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2755
801a4313
EZ
27562011-11-30 Eli Zaretskii <eliz@gnu.org>
2757
2758 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2759 attributes are tested _before_ calling verify_row_hash, to protect
2760 against GCC re-ordering of the tests. (Bug#10164)
2761
2b56b87e
JD
27622011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2763
2764 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2765
2766 * xterm.c (handle_one_xevent): Only set async_visible and friends
2767 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 2768 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
2769 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2770
dbf31225
PE
27712011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2772
2773 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2774 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2775 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2776 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2777 All uses changed to use GCPRO1 etc.
2778 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2779 Revert to old implementation (i.e., before 2011-03-11).
2780
1305621b
YM
27812011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2782
2783 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2784 of scroll runs so as to avoid assigning disabled bogus rows and
2785 unnecessary graphics copy operations.
2786
8c9afb46
EZ
27872011-11-27 Eli Zaretskii <eliz@gnu.org>
2788
2789 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2790 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2791 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2792 (malloc, free, realloc, calloc): Redirect to e_* only when
2793 compiling Emacs.
2794
2795 * lisp.h (GCTYPEBITS): Move before first use.
2796 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2797 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2798 this macro definition.
2799
2800 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2801 _MSC_VER.
2802
54e9e3bf
JD
28032011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2804
6d5eb5b0
SM
2805 * gtkutil.c (xg_create_frame_widgets):
2806 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
2807 present with Gtk+ 2.0.
2808
83aca1cb
PE
28092011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 * fileio.c (Finsert_file_contents): Undo previous change; see
2812 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2813
5b76caa4
PE
28142011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2815
2816 Rename locals to avoid shadowing.
2817 * fileio.c (Finsert_file_contents):
2818 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2819 * process.c (wait_reading_process_output):
2820 Rename inner 'proc' to 'p' to avoid shadowing.
2821 Indent for consistency with usual Emacs style.
2822
8c535114
EZ
28232011-11-25 Eli Zaretskii <eliz@gnu.org>
2824
2825 * xdisp.c (redisplay_window): If cursor row is not fully visible
2826 after recentering, and scroll-conservatively is set to a large
2827 number, scroll window by a few more lines to make the cursor fully
2828 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
2829 (start_display): Don't move to the next line if the display should
2830 start at a newline that is part of a display vector or an overlay
2831 string. (Bug#10119)
8c535114 2832
fa4fdb5c
JL
28332011-11-24 Juri Linkov <juri@jurta.org>
2834
2835 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2836 after the `MagickPingImage' call. (Bug#10112)
2837
90ec88df
CY
28382011-11-23 Chong Yidong <cyd@gnu.org>
2839
2840 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2841
56e2e794
MR
28422011-11-23 Martin Rudalics <rudalics@gmx.at>
2843
2844 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2845 making another buffer current. (Bug#10114)
2846
b6e64c41
GM
28472011-11-23 Glenn Morris <rgm@gnu.org>
2848
2849 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2850
6b21de18
CY
28512011-11-23 Chong Yidong <cyd@gnu.org>
2852
2853 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2854 using it (Bug#5984).
2855
b12cd789
EZ
28562011-11-22 Eli Zaretskii <eliz@gnu.org>
2857
2858 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2859 and header-lines, as they don't have one computed for them.
2860 (Bug#10098)
2861
2862 * .gdbinit (prow): Make displayed values more self-explaining.
2863 Add row's hash code.
2864
261b6fd4
LMI
28652011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2866
2867 * process.c (wait_reading_process_output): Fix asynchrounous
2868 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 2869 (wait_reading_process_output): Add comment and URL.
261b6fd4 2870
e7cfd277
JD
28712011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2872
2873 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2874
a9b9b7f5
CY
28752011-11-21 Chong Yidong <cyd@gnu.org>
2876
2877 * window.c (Fnext_window, Fprevious_window): Doc fix.
2878
b0d15b4f
SM
28792011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2880
2881 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2882
fe7a3057
JB
28832011-11-20 Juanma Barranquero <lekktu@gmail.com>
2884
2885 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2886
d2999b1a
MR
28872011-11-20 Martin Rudalics <rudalics@gmx.at>
2888
2889 * window.c (Fset_window_combination_limit): Rename argument
2890 STATUS to LIMIT.
2891 (Vwindow_combination_limit): Remove "status" from doc-string.
2892
d5ff9cd0
AS
28932011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2894
2895 * m/ibms390.h: Remove.
2896 * m/ibms390x.h: Don't include "ibms390.h".
2897
a5bb9bd3
SM
28982011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2899
2900 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2901 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2902
cd1181db
JB
29032011-11-20 Juanma Barranquero <lekktu@gmail.com>
2904
2905 * casetab.c (Fset_case_table):
2906 * charset.c (Fcharset_after): Fix typos.
2907
615a3b8d 29082011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 2909
17e845af
PE
2910 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2911 Otherwise, valgrind does not work on some platforms.
2912 Problem reported by Andreas Schwab in
6a0bf43d
PE
2913 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2914 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2915 is set, removing the need for VIRT_ADDRESS_VARIES.
2916 (PURE_P): Use a more-efficient implementation that needs just one
2917 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2918 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2919 to 4 (xorl, subq, cmpq, setbe).
2920 * alloc.c (pure): Always extern now, since that's the
2921 VIRT_ADDR_VARIES behavior.
2922 (PURE_POINTER_P): Use a single comparison, not two, for
2923 consistency with the new puresize.h.
2924 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2925 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2926 Remove VIRT_ADDR_VARIES no longer needed.
2927
f8fe6f96
EZ
29282011-11-19 Eli Zaretskii <eliz@gnu.org>
2929
2930 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2931 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2932 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2933 behave as if the cursor position were at the window margin.
2934
2935 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2936 and the cursor position is out of bounds, behave as if the cursor
2937 position were at the window margin. (Bug#10075)
2938
df05a53c
CY
29392011-11-18 Chong Yidong <cyd@gnu.org>
2940
2941 * window.c (Fwindow_combination_limit): Make first argument
2942 non-optional, since it is meaningless for live windows like the
2943 selected window.
61ccba97 2944
2071918e
DA
29452011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2946
2947 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2948
b50a28de
SM
29492011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2950
2951 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2952 (graft_intervals_into_buffer): Simplify.
2953
015137db
EZ
29542011-11-18 Eli Zaretskii <eliz@gnu.org>
2955
2956 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2957 hash values of the two rows.
2958 (copy_row_except_pointers): Preserve the used[] arrays and the
2959 hash values of the two rows. (Bug#10035)
68c95424 2960 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
2961
2962 * xdisp.c (row_hash): New function, body extracted from
2963 compute_line_metrics.
2964 (compute_line_metrics): Call row_hash, instead of computing the
2965 hash code inline.
2966
2967 * dispnew.c (verify_row_hash): Call row_hash for computing the
2968 hash code of a row, instead of duplicating code from xdisp.c.
2969
2970 * dispextern.h (row_hash): Add prototype.
2971
a2addb04
TH
29722011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2973
2974 * frame.c (delete_frame): Don't delete the terminal when the last
2975 X frame is closed if emacs is built with GTK toolkit.
2976
df85d315
JB
29772011-11-17 Juanma Barranquero <lekktu@gmail.com>
2978
2979 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2980
a0c2d0ae
MR
29812011-11-17 Martin Rudalics <rudalics@gmx.at>
2982
2983 * window.c (Vwindow_splits): Rename to
2984 Vwindow_combination_resize. Suggested by Juri Linkov.
2985 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2986 of Vwindow_splits.
2987
58179cce
JB
29882011-11-16 Juanma Barranquero <lekktu@gmail.com>
2989
7877f373
JB
2990 * nsfns.m (Fns_font_name):
2991 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 2992
b6f67890
MR
29932011-11-16 Martin Rudalics <rudalics@gmx.at>
2994
2995 * window.h (window): Rename slot "nest" to "combination_limit".
2996 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2997 (Fset_window_nest): Rename to Fset_window_combination_limit.
2998 (Vwindow_nest): Rename to Vwindow_combination_limit.
2999 (recombine_windows, make_parent_window, make_window)
3000 (Fsplit_window_internal, saved_window)
3001 (Fset_window_configuration, save_window_save): Rename all
3002 occurrences of window_nest to window_combination_limit.
3003
c7015153
JB
30042011-11-15 Juanma Barranquero <lekktu@gmail.com>
3005
3006 * image.c (imagemagick_load_image): Fix typo.
3007
322ad6ec
EZ
30082011-11-14 Eli Zaretskii <eliz@gnu.org>
3009
3010 * xdisp.c (display_line): Move the call to
3011 highlight_trailing_whitespace before the call to
3012 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3013 faces of all the glyphs to compute ROW's hash value.
3014 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3015
f067b8ec
JB
30162011-11-14 Juanma Barranquero <lekktu@gmail.com>
3017
3018 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3019 just return (bug#10044).
3020
1e5b2111
EZ
30212011-11-12 Eli Zaretskii <eliz@gnu.org>
3022
7ef3cbd5
EZ
3023 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3024 with user-defined heap size. Bump the default size of the temacs
3025 heap to 27MB, to avoid memory warning when running temacs.
3026 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3027
1e5b2111
EZ
3028 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3029 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3030 (verify_row_hash) [XASSERTS]: New function.
3031 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3032 that the hash value of glyph rows is correct.
1e5b2111 3033
89d61221
MR
30342011-11-12 Martin Rudalics <rudalics@gmx.at>
3035
3036 * window.h (window): Remove splits slot.
3037 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3038 (Fdelete_other_windows_internal, make_parent_window)
3039 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3040 (Fset_window_configuration, save_window_save): Don't deal with
3041 split status of windows.
3042 (saved_window): Remove splits slot.
3043 (Vwindow_splits): Rewrite doc-string.
3044
97f18cc8
JD
30452011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3046
3047 * xfns.c (unwind_create_frame):
3048 * nsfns.m (unwind_create_frame):
3049 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3050 Vframe_list (Bug#9999).
3051
22a648b4
DA
30522011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3053
0b381c7e 3054 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3055
659afede
KH
30562011-11-11 Kenichi Handa <handa@m17n.org>
3057
3058 * callproc.c (Fcall_process): Set the member dst_multibyte of
3059 process_coding.
3060
9ac0394b
KH
30612011-11-11 Johan Bockgård <bojohan@gnu.org>
3062
3063 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3064 avoid a crash (bug#9496).
3065
2fbdc249
CY
30662011-11-09 Chong Yidong <cyd@gnu.org>
3067
3068 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3069 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3070
ac6b1f81
PE
30712011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3072
3073 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3074
09db192c
PE
30752011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3076
3077 Avoid some portability problems by eschewing 'extern inline' functions.
3078 The trivial performance wins aren't worth the portability hassles; see
3079 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3080 et seq.
3081 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3082 (window_box_width, window_box_left, window_box_left_offset)
3083 (window_box_right, window_box_right_offset): Undo previous change,
3084 by removing the "extern"s.
3085 * intervals.c (adjust_intervals_for_insertion)
3086 (adjust_intervals_for_deletion): Undo previous change,
3087 making these static again.
3088 (offset_intervals, temp_set_point_both, temp_set_point)
3089 (copy_intervals_to_string): No longer inline.
3090 * xdisp.c (window_text_bottom_y, window_box_width)
3091 (window_box_height, window_box_left_offset)
3092 (window_box_right_offset, window_box_left, window_box_right)
3093 (window_box): No longer inline.
3094
105216ed
CY
30952011-11-08 Chong Yidong <cyd@gnu.org>
3096
3097 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3098 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3099 Signal an error if not a live window.
105216ed
CY
3100 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3101 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3102
ae9e237f
JB
31032011-11-07 Juanma Barranquero <lekktu@gmail.com>
3104
3105 * lisp.h (syms_of_abbrev): Remove declaration.
3106 Reported by CHENG Gao <chenggao@royau.me>.
3107
c7aa8333
EZ
31082011-11-07 Eli Zaretskii <eliz@gnu.org>
3109
3110 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3111 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3112 of temacs in GUI mode.
3113
be7f5545
MR
31142011-11-07 Martin Rudalics <rudalics@gmx.at>
3115
3116 * window.h: Declare delete_all_child_windows instead of
3117 delete_all_subwindows.
3118 * window.c (Fwindow_nest, Fset_window_nest)
3119 (Fset_window_new_total, Fset_window_new_normal)
3120 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3121 (delete_all_subwindows): Rename to delete_all_child_windows.
3122 (Fdelete_other_windows_internal, Fset_window_configuration):
3123 Call delete_all_child_windows instead of delete_all_subwindows.
3124 * frame.c (delete_frame): Call delete_all_child_windows instead
3125 of delete_all_subwindows.
3126
ca78dc43
PE
31272011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3130 This is also needed for porting to any host where GC_MARK_STACK is
3131 not GC_MAKE_GCPROS_NOOPS.
3132 (which_symbols): Use it.
3133
a0241d01
KH
31342011-11-07 Kenichi Handa <handa@m17n.org>
3135
3136 * coding.c (coding_set_destination): Check coding->src_pos only
3137 when coding->src_object is a buffer (bug#9910).
3138
3139 * process.c (send_process): Set the member src_multibyte of coding
3140 to 0 (bug#9911) when sending a unibyte text.
3141
3142 * callproc.c (Fcall_process): Set the member src_multibyte of
3143 process_coding to 0 (bug#9912).
3144
a64bfdfa 31452011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3146
3147 * xmenu.c (cleanup_widget_value_tree): New function.
3148 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3149 calling free_menubar_widget_value_tree directly (Bug#9830).
3150
cb41b32a
PE
31512011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3152
3153 Fix some portability problems with 'inline'.
3154 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3155 (window_box_width, window_box_left, window_box_left_offset)
3156 (window_box_right, window_box_right_offset): Declare extern.
3157 Otherwise, these inline functions do not conform to C99 and
3158 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3159 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3160 * intervals.c (adjust_intervals_for_insertion)
3161 (adjust_intervals_for_deletion): Now extern, because otherwise the
3162 extern inline functions 'offset_intervals' couldn't refer to it.
3163 (static_offset_intervals): Remove.
3164 (offset_intervals): Rewrite using the old contents of
3165 static_offset_intervals. The old version didn't conform to C99
3166 because an extern inline function contained a reference to an
3167 identifier with static linkage.
3168
b7041366
AS
31692011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3170
3171 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3172 GC.
3173
88a37c4d
EZ
31742011-11-06 Eli Zaretskii <eliz@gnu.org>
3175
3176 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3177 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3178 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3179 return Qleft_to_right.
3180
49745b39
CY
31812011-11-06 Chong Yidong <cyd@gnu.org>
3182
3183 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3184 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3185 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3186 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3187 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3188 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3189 (Fwindow_vscroll): Doc fix.
3190 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3191 argument, since it makes no sense to pass a live window and for
3192 consistency with window-child.
3193
1f05cd82
CS
31942011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3195
3196 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3197 support MSVC.
3198
22610910
JR
31992011-11-05 Jason Rumney <jasonr@gnu.org>
3200
3201 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3202 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3203 fonts (Bug#6029).
3204 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3205 bitwise arithmetic preventing use of unicode-sip and non-truetype
3206 opentype fonts.
3207
a06776b2
EZ
32082011-11-05 Eli Zaretskii <eliz@gnu.org>
3209
3ad924ba
EZ
3210 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3211 "emacs"-only part.
3212
a06776b2
EZ
3213 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3214 initialization code to keep similarity to xfns.c after changes
3215 from 2011-11-05.
3216
c9e7db78
JD
32172011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3218
a97f8f3f
JD
3219 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3220 (unwind_create_frame): New function (Bug#9943).
3221 (Fx_create_frame): Restructure code to be more similar to the one in
3222 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3223 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3224 Move terminal->reference_count++ just before making the frame official
3225 (Bug#9943).
3226
3227 * nsterm.m (x_free_frame_resources): New function.
3228 (x_destroy_window): Move code to x_free_frame_resources.
3229
c9e7db78 3230 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3231 (Fx_create_frame, x_create_tip_frame):
3232 Move terminal->reference_count++ just before making the frame
75f1671a 3233 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3234 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3235
a6fc3b5c
EZ
32362011-11-05 Eli Zaretskii <eliz@gnu.org>
3237
3238 Support MSVC build with newer versions of Visual Studio.
3239 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3240 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3241 nt/gmake.defs.
3242
3243 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3244 which are not supported by MSVC.
3245 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3246 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3247 bitfields.
3248 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3249 types in bitfields.
3250 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3251
3252 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3253
58179cce 32542011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3255
3256 Support MSVC build with newer versions of Visual Studio.
3257 * w32.c: Don't include w32api.h for MSVC.
3258 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3259
3260 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3261 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3262 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3263 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3264 e_* cousins.
3265 (alloca) [_MSC_VER]: Define to _alloca.
3266
3267 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3268
3269 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3270
a58c13ed
EZ
32712011-11-04 Eli Zaretskii <eliz@gnu.org>
3272
3273 * xdisp.c (note_mouse_highlight): If either of
3274 previous/next-single-property-change returns nil, treat that as
3275 the beginning or the end of the buffer. (Bug#9955)
3276
fe0b6370
JD
32772011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3278
a58c13ed 3279 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3280 label is not null (Bug#9951).
3281 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3282 may be NULL.
3283
89bd5ee1
EZ
32842011-11-04 Eli Zaretskii <eliz@gnu.org>
3285
3286 * window.c (Fwindow_body_size): Mention in the doc string that the
3287 return value is in frame's canonical units. (Bug#9949)
3288
84c3edb9
EZ
32892011-11-03 Eli Zaretskii <eliz@gnu.org>
3290
4e2fb5c7
EZ
3291 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3292
84c3edb9 3293 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3294 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3295 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3296
bc17a887
EZ
32972011-11-01 Eli Zaretskii <eliz@gnu.org>
3298
3299 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3300 Don't stop backward scan on the continuation glyph, even though
3301 its CHARPOS is positive.
6d5eb5b0
SM
3302 (mouse_face_from_buffer_pos, note_mouse_highlight):
3303 Rename cover_string to disp_string.
bc17a887 3304
4ee88440
MR
33052011-11-01 Martin Rudalics <rudalics@gmx.at>
3306
3307 * window.c (temp_output_buffer_show): Don't use
3308 Vtemp_buffer_show_specifiers.
3309 (Vtemp_buffer_show_specifiers): Remove unused variable.
3310
c2ff3c02
EZ
33112011-10-30 Eli Zaretskii <eliz@gnu.org>
3312
3313 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3314 past the beginning of the current glyph matrix.
3315
58179cce 33162011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3317
3318 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3319 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3320 HAVE_GTK3 (Bug#9869).
b77a6a7f 3321
3b574623
JD
3322 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3323 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3324
b77a6a7f
JD
3325 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3326
3327 * xterm.c: Declare x_handle_net_wm_state to return int.
3328 (handle_one_xevent): Check if we are iconified but don't have
3329 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3330 (get_current_wm_state): Return non-zero if not hidden,
3331 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3332 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3333 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3334 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3335
196e41e4
PE
33362011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3337
3338 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3339 so that this new function doesn't get optimized away by a
3340 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3341
021f2e1a
AS
33422011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3343
3344 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3345
8b058d44
EZ
33462011-10-29 Eli Zaretskii <eliz@gnu.org>
3347
3348 Fix the `xbytecode' command.
3349 * .gdbinit (xprintbytestr): New command.
b50a28de 3350 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3351 (xbytecode): Print the byte-code string as well.
3352
4452fb80
EZ
33532011-10-29 Kim Storm <storm@cua.dk>
3354
8b058d44
EZ
3355 * alloc.c (which_symbols): New function.
3356
21b72067
AS
33572011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3358
3359 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3360 line. (Bug#9903)
3361
83ed7b5c
GM
33622011-10-29 Glenn Morris <rgm@gnu.org>
3363
3364 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3365 Not clear what it was for, and it causes various bugs. (Bug#9839)
3366
5a7a728b
EZ
33672011-10-28 Eli Zaretskii <eliz@gnu.org>
3368
3369 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3370 possible random value that matches one of those tested as
3371 condition to clear the mouse face.
3372
d3d0842f
CY
33732011-10-28 Chong Yidong <cyd@gnu.org>
3374
3375 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3376
31b39d13
DN
33772011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3378
3379 * window.c (make_window): Initialize phys_cursor_on_p.
3380
9aba6043
SM
33812011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3382
3383 * lisp.h (struct Lisp_Symbol): Update comments.
3384
c20992f4
JB
33852011-10-28 Juanma Barranquero <lekktu@gmail.com>
3386
3387 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3388
db4f02f2
EZ
33892011-10-28 Eli Zaretskii <eliz@gnu.org>
3390
3391 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3392 <oslsachem@gmail.com> for helping to debug this.
3393
3394 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3395 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3396 (g_b_init_get_glyph_outline_w): New static variables.
3397 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3398 (GetGlyphOutlineW_Proc): New typedefs.
3399 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3400 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3401 New functions.
3402 (w32font_open_internal, compute_metrics):
3403 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3404 instead of calling the "wide" APIs directly.
3405
3406 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3407
3408 * w32.h (syms_of_w32font): Add prototype.
3409
87e68db4
JB
34102011-10-27 Juanma Barranquero <lekktu@gmail.com>
3411
3412 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3413 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3414 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3415 (Fmove_to_window_line): Doc fix.
3416
435c1d67
CY
34172011-10-27 Chong Yidong <cyd@gnu.org>
3418
3419 * process.c (make_process): Set gnutls_state to NULL.
3420
3421 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3422 non-NULL, regardless of GNUTLS_INITSTAGE.
3423 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3424 an error. Set process slots as soon as we allocate them.
3425
3426 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3427
9c6c6f49
CY
34282011-10-27 Chong Yidong <cyd@gnu.org>
3429
9aba6043
SM
3430 * gnutls.c (emacs_gnutls_deinit): New function.
3431 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3432 (Fgnutls_deinit, Fgnutls_boot): Use it.
3433
3434 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3435 (deactivate_process): Call emacs_gnutls_deinit.
3436
657d08d3
JB
34372011-10-27 Juanma Barranquero <lekktu@gmail.com>
3438
3439 * image.c (x_create_x_image_and_pixmap):
3440 * w32.c (sys_rename, w32_delayed_load):
3441 * w32font.c (fill_in_logfont):
3442 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3443
5430d399
JB
34442011-10-26 Juanma Barranquero <lekktu@gmail.com>
3445
3446 * w32fns.c (w32_default_color_map): New function,
3447 extracted from Fw32_default_color_map.
a7ef684b 3448 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3449
fe0055fa
PE
34502011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3453
e6346438
SM
34542011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3455
3456 * keyboard.c (test_undefined): New function (bug#9751).
3457 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3458
e112cc37
ET
34592011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3460
3461 * sysdep.c (init_sys_modes): Fix the check for the controlling
3462 terminal (Bug#6649).
3463
7b5d6677
EZ
34642011-10-20 Eli Zaretskii <eliz@gnu.org>
3465
3466 * dispextern.h (struct bidi_it): New member next_en_type.
3467
3468 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3469 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3470 current character, check also for next_en_type being WEAK_EN.
3471 (bidi_resolve_weak): Don't enter the expensive loop if the current
3472 position is before next_en_pos. Record the bidi type of the first
3473 non-ET, non-BN character we find, in addition to its position.
3474 (bidi_level_of_next_char): Invalidate next_en_type when
3475 next_en_pos is over-stepped.
3476
7da0b018
PE
34772011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3480 * editfns.c: Rewrite current-time-zone so that it invokes
3481 the equivalent of (format-time-string "%Z") to get the time zone name.
3482 This fixes a bug when the time zone name contains characters that
3483 need converting from the system time locale to Emacs internal format.
3484 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3485 that patch fixed format-time-string to do the conversion, but
3486 I forgot to fix current-time-zone.
3487 (format_time_string): New function, containing most of
3488 what Fformat_time_string used to contain.
3489 (Fformat_time_string): Rewrite in terms of format_time_string.
3490 This doesn't change this function's behavior.
3491 (current-time-zone): Rewrite to use format_time_string.
3492 This fixes the bug reported by Michael Schierl in
3493 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3494 Jason Rumney's 2007-06-07 change worked around this bug, but
3495 didn't fix it.
3496 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3497
8547b010
EZ
34982011-10-19 Eli Zaretskii <eliz@gnu.org>
3499
3500 * xdisp.c (start_display): If the character at POS is displayed
3501 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3502 (try_window_reusing_current_matrix): If a line ends in a display
3503 vector or the next line starts in a display vector, continue
3504 redrawing the window even though the character position of
3505 start_row was reached.
8547b010
EZ
3506 (Bug#9771, part 2)
3507
4e948d15
CY
35082011-10-18 Chong Yidong <cyd@gnu.org>
3509
3510 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3511 with nobreak-char-display too.
3512
4787455f
EZ
35132011-10-18 Eli Zaretskii <eliz@gnu.org>
3514
3515 Fix part 3 of bug#9771.
3516 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3517 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3518 non-neutral characters if the current character is a paragraph
3519 separator (a.k.a. Newline). This avoids running the same
3520 expensive loop twice, once when we consume the preceding newline
3521 and the other time when the line actually needs to be displayed.
3522 Avoid the loop when we see neutrals on the base embedding level
3523 following a character whose directionality is the same as the
3524 paragraph's. This avoids running the expensive loop when a line
3525 ends in a long sequence of neutrals, like control characters.
3526 Add assertion against STRONG_AL type. Slightly rearrange code
3527 that determines the type of a neutral given the first non-neutral
3528 that follows it.
3529 (bidi_level_of_next_char): Set next_en_pos to zero when
3530 invalidating its info.
3531
2c91f553
EZ
35322011-10-17 Eli Zaretskii <eliz@gnu.org>
3533
3534 * xdisp.c (push_display_prop): Determine whether to record string
3535 or buffer position by IT->string, not by IT->method. Allow
3536 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3537 (move_it_vertically_backward): Don't look for character position
3538 immediately after the newline when in a continuation line.
3539 (Bug#9771, part 1)
2c91f553 3540
c7b08b0d
MR
35412011-10-15 Martin Rudalics <rudalics@gmx.at>
3542
3543 * window.c (coordinates_in_window): Rewrite and delabelize
3544 vertical border check. (Bug#5357) (Bug#9618)
3545
6b02f655
SM
35462011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3547
3548 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3549 errors in XSetWindowBorder (bug#9310).
3550
81d40c92
DA
35512011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3552
3553 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3554 avoid crash when xmalloc overrun checking is enabled.
3555
d4172c3b
EZ
35562011-10-13 Eli Zaretskii <eliz@gnu.org>
3557
3558 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3559 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3560 cursor motion with <left> and <right> arrow keys.
3561
3562 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3563 some callers set that themselves.
3564
b00eea75
EZ
35652011-10-12 Eli Zaretskii <eliz@gnu.org>
3566
3567 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3568 display string and the previous row comes from the same string and
3569 is empty. (Bug#9739) (Bug#9738)
3570
8fe012c4
SM
35712011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3572
3573 * doc.c (get_doc_string): Encode file name (bug#9735).
3574
0074aef2
EZ
35752011-10-12 Eli Zaretskii <eliz@gnu.org>
3576
79beb178
EZ
3577 * bidi.c (bidi_level_of_next_char):
3578 * xdisp.c (get_visually_first_element): Remove old incorrect
3579 comments regarding the Unicode Line Separator character.
3580
0074aef2
EZ
3581 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3582
6e4b3fbe
DA
35832011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3584
3585 * alloc.c (Fgc_status): Do not access beyond zombies array
3586 boundary if nzombies > MAX_ZOMBIES.
3587 * alloc.c (dump_zombies): Add missing format specifier.
3588
0324f3af
PE
35892011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3590
b5525cac
PE
3591 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3592 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3593
0324f3af
PE
3594 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3595 Some packages use them to denote characters with modifiers.
3596
e9b5f888
AS
35972011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3598
3599 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3600 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3601 matching a pp-number. Rename parameter var to var1.
3602
127827c0
SM
36032011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3604
3605 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3606
c8fd3bd0
GM
36072011-10-08 Glenn Morris <rgm@gnu.org>
3608
3609 * callint.c (Fcall_interactively): Give a more explicit error for the
3610 'c' case with a non-character input. (Bug#8479)
3611
352ec8ff
EZ
36122011-10-08 Eli Zaretskii <eliz@gnu.org>
3613
03669ccb
EZ
3614 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3615 lines.
7061c986
EZ
3616 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3617 lines that are hscrolled on the left.
03669ccb 3618
352ec8ff
EZ
3619 * dispnew.c (buffer_posn_from_coords): Account for a possible
3620 presence of header-line. (Bug#4426)
3621
a66cfb1c
SM
36222011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3623
6b02f655
SM
3624 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3625 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3626
7c5ee88e
PE
36272011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3628
3629 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3630 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3631 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3632 this makes Emacs dump core during garbage collection on rare
3633 occasions. sizeof is obviously inferior to offsetof here, so
3634 stick with offsetof.
3635 (GC_POINTER_ALIGNMENT): New macro.
3636 (mark_memory): Omit 3rd (offset) arg; caller changed.
3637 Don't assume EMACS_INT alignment is the same as pointer alignment.
3638
df1bbe5b
SM
36392011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3640
3641 * keyboard.c (read_key_sequence_remapped): New var.
3642 (read_key_sequence): Compute remapping in the right buffer.
3643 (command_loop_1): Use read_key_sequence's remapping directly.
3644
51553db6
SM
36452011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3646
32c1fffd
SM
3647 * dired.c (file_name_completion): Don't expand file name.
3648 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3649 before checking file name handler.
3650
51553db6
SM
3651 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3652 they've been requested explicitly (bug#9591).
3653
b6bd1599 36542011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3655
3656 * keymap.c (Fsingle_key_description): Use make_specified_string
3657 instead of build_string to build string from push_key_description.
3658 (Bug#5193)
3659
f701dc2a
PE
36602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3661
4222c55d
PE
3662 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3663 This fixes a Y2038 bug on 64-bit hosts.
3664 * buffer.c (reset_buffer):
3665 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3666 (Fclear_buffer_auto_save_failure):
3667 Use 0, not -1, to represent an unset failure time, since time_t
3668 might not be signed.
3669
f701dc2a
PE
3670 Remove dependency on glibc malloc internals.
3671 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3672 Move back here from lisp.h, but with their new implementations.
3673 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3674 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3675 * charset.c (charset_table_init): New static var.
3676 (syms_of_charset): Use it instead of xmalloc. This removes a
3677 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3678 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3679 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3680 Move back to alloc.c.
3681 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3682 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3683
9ceebf39
JD
36842011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3685
3686 * nsterm.m (windowDidResize): Call x_set_window_size only when
3687 ns_in_resize is true. Otherwise set pixelwidth/height and
3688 call change_frame_size (Bug#9628).
3689
cb993c58
PE
36902011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3691
3930c88b
PE
3692 Port --enable-checking=all to Fedora 14 x86-64.
3693 * charset.c (syms_of_charset): Also account for glibc malloc's
3694 internal overhead when calculating the initial malloc maximum.
3695
cb993c58
PE
3696 Port --enable-checking=all to Fedora 14 x86.
3697 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3698 Move to lisp.h.
3699 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3700 (overrun_check_realloc, overrun_check_free):
3701 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3702 That way, xmalloc returns a properly-aligned pointer even if
3703 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3704 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3705 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3706 into account when calculating the initial malloc maximum.
3707 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3708 Move here from alloc.c, so that charset.c can use it too.
3709 Properly align; the old code wasn't right for common 32-bit hosts
3710 when configured with --enable-checking=all.
3711 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3712 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3713
31bed486
EZ
37142011-09-29 Eli Zaretskii <eliz@gnu.org>
3715
04c70788 3716 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
3717 use EDOM.
3718
fbcaa2f3
EZ
37192011-09-28 Eli Zaretskii <eliz@gnu.org>
3720
3721 * xdisp.c (compute_display_string_end): If there's no display
3722 string at CHARPOS, return -1.
3723
3724 * bidi.c (bidi_fetch_char): When compute_display_string_end
3725 returns a negative value, treat the character as a normal
3726 character not covered by a display string. (Bug#9624)
3727
a239d4e9
JB
37282011-09-28 Juanma Barranquero <lekktu@gmail.com>
3729
3730 * lread.c (Fread_from_string): Fix typo in docstring.
3731
88652fd5
EZ
37322011-09-27 Eli Zaretskii <eliz@gnu.org>
3733
3734 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3735 newline, reseat the iterator instead of bidi-iterating there one
3736 character at a time. (Bug#9610)
32c1fffd
SM
3737 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3738 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 3739
ed497dd4
AS
37402011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3741
3742 * lread.c (readevalloop): Use correct code for NBSP.
3743 (read1): Likewise. (Bug#9608)
3744
b2bf61aa
MA
37452011-09-25 Michael Albinus <michael.albinus@gmx.de>
3746
3747 * dbusbind.c (Fdbus_register_signal): When service is not
3748 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3749
32bbb17c
GM
37502011-09-25 Glenn Morris <rgm@gnu.org>
3751
3752 * buffer.c (truncate-lines): Doc fix.
3753
94e0933e
CY
37542011-09-24 Chong Yidong <cyd@stupidchicken.com>
3755
3756 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3757 (Fset_window_next_buffers): Doc fix.
3758
cddde921
GM
37592011-09-24 Glenn Morris <rgm@gnu.org>
3760
3761 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3762
1260aef1
PE
37632011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3764
25b4bfa0
PE
3765 Fix minor problems found by static checking.
3766 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
3767 * indent.c (Fvertical_motion): Fix == vs = typo.
3768
e3cbd34b
EZ
37692011-09-24 Eli Zaretskii <eliz@gnu.org>
3770
a66cfb1c
SM
3771 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3772 Default value is now t. Doc fix.
6bf7006f 3773
e3cbd34b 3774 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 3775 logic when moving up, not only when moving down. Fix the
e3cbd34b 3776 confusing name and values of the it_overshoot_expected variable;
32c1fffd 3777 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
3778
3779 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3780 CHARPOS is covered by a display string which includes newlines.
3781 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3782 is covered by a display string with embedded newlines.
3783
a3de0cbd
MA
37842011-09-24 Michael Albinus <michael.albinus@gmx.de>
3785
3786 * dbusbind.c (Fdbus_register_signal): Add match rule to
3787 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
3788 (Fdbus_register_method, Vdbus_registered_objects_table):
3789 Fix docstring.
a3de0cbd 3790
b260039d
JM
37912011-09-24 Jim Meyering <meyering@redhat.com>
3792
32c1fffd 3793 do not ignore write error for any output size
b260039d
JM
3794 The previous change was incomplete.
3795 While it makes emacs --batch detect the vast majority of stdout
3796 write failures, errors were still ignored whenever the output size is
3797 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3798 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3799 && echo FAIL: ignored write error
3800 FAIL: ignored write error
3801 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3802 && echo FAIL: ignored write error
3803 FAIL: ignored write error
3804 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3805
8eca8a7c
AS
38062011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3807
3808 * emacs.c (Fkill_emacs): In noninteractive mode exit
3809 non-successfully if a write error occurred on stdout. (Bug#9574)
3810
3341db62
EZ
38112011-09-21 Eli Zaretskii <eliz@gnu.org>
3812
3813 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3814 the xassert test.
3815
3816 * dispextern.h (struct it): Update the comment documenting what
3817 can it->OBJECT be.
3818
8c203dbf
EZ
38192011-09-20 Eli Zaretskii <eliz@gnu.org>
3820
3821 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3822 a display string, extend search for cursor position to end of row.
3823 (find_row_edges): If the row ends in a newline from a display
3824 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3825 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
3826 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3827 non-empty line. Fixes confusing cursor motion with arrow keys at
3828 the beginning of a line that starts with whitespace.
8c203dbf 3829
a4824228
LMI
38302011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3831
3832 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3833 (bug#9493).
3834
33ed493b
CY
38352011-09-18 Chong Yidong <cyd@stupidchicken.com>
3836
3837 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3838 boolean (Bug#9154).
3839
56cd55c8
EZ
38402011-09-18 Eli Zaretskii <eliz@gnu.org>
3841
3842 * xdisp.c (display_line): Record maximum and minimum buffer
3843 positions even if no glyphs were produced (e.g., by a zero-width
3844 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3845 buffer positions that will be removed from the glyph row because
3846 they don't fit.
c02dcedf
EZ
3847 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3848 column is beyond frame width: don't subtract 1 "pixel" when
3849 computing width of the stretch.
3e62b7e0
EZ
3850 (reseat_at_next_visible_line_start): Undo the change made on
3851 2011-09-17 that saved paragraph information and restored it after
3852 the call to `reseat'. (Bug#9545)
56cd55c8 3853
5ed99d36 38542011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
3855
3856 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3857 and turn window cursor on if cleared (Bug#9415).
3858
5ed99d36 38592011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
3860
3861 * search.c (boyer_moore): Take unibyte characters from pattern
3862 literally. (Bug#9458)
3863
9bade7b2
EZ
38642011-09-18 Eli Zaretskii <eliz@gnu.org>
3865
3866 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3867
e5e9d610
PE
38682011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3869
87e4427a
PE
3870 Fix minor problem found by static checking.
3871 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3872 initialized, to pacify gcc -Wuninitialized.
3873
e5e9d610
PE
3874 * fileio.c: Report proper errno when syscall falls.
3875 (Finsert_file_contents): Save and restore errno,
3876 so that report_file_error outputs the correct diagnostic.
3877 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3878
a1674f0b
EZ
38792011-09-18 Eli Zaretskii <eliz@gnu.org>
3880
3881 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3882
fbfb6dd4
EZ
38832011-09-17 Eli Zaretskii <eliz@gnu.org>
3884
3885 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3886 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3887
bb187662
EZ
38882011-09-17 Eli Zaretskii <eliz@gnu.org>
3889
1137e8b8 3890 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 3891 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
3892
3893 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3894 (bidi_find_paragraph_start): Search back for paragraph beginning
3895 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3896 (bidi_move_to_visually_next): Only trigger paragraph-related
3897 computations when the last character is a newline or at EOB, not
3898 just any NEUTRAL_B. (Bug#9470)
3899
bb187662
EZ
3900 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3901 truncated lines if point is covered by a display string. (Bug#9524)
3902
2e621251
PE
39032011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3904
3905 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3906 (cons_to_x_long): New function.
3907 (lisp_data_to_selection_data): Use it. Correct the test for
3908 short-versus-long data; it was negated. Break out of vector
3909 loop, for efficiency, when a long datum is discovered.
3910
91a15bc6
SM
39112011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3912
3913 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3914
b41c3a35
EZ
39152011-09-16 Eli Zaretskii <eliz@gnu.org>
3916
3917 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3918 GCC PR/17406) by declaring this function with external scope.
3919
7812ba2d
PE
39202011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3921
3922 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3923 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3924
cf7edc2a
AS
39252011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3926
3927 * editfns.c (Fformat): Correctly handle text properties on "%%".
3928
bd01620e
EZ
39292011-09-15 Eli Zaretskii <eliz@gnu.org>
3930
3931 * xterm.c (x_draw_composite_glyph_string_foreground):
3932 * w32term.c (x_draw_composite_glyph_string_foreground):
3933 * term.c (encode_terminal_code):
3934 * composite.c (composition_update_it, get_composition_id):
3935 * xdisp.c (get_next_display_element)
3936 (fill_composite_glyph_string): Add comments about special meaning
3937 of TAB characters in a composition.
3938
a02719a3
PE
39392011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3940
3941 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
3942 This occurs when processing a multibyte format.
3943 Problem reported by Wolfgang Jenker.
a02719a3 3944
72589a3c
JB
39452011-09-15 Johan Bockgård <bojohan@gnu.org>
3946
3947 * xdisp.c (try_cursor_movement): Only check for exact match if
3948 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3949
1c14176c
PE
39502011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3951
3952 Remove unused external symbols.
3953 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3954 * xdisp.c (calc_pixel_width_or_height): Now static.
3955 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3956 * indent.c (check_display_width):
3957 * w32term.c: Fix comment to match code.
3958 * xterm.c, xterm.h (x_catching_errors): Remove.
3959
d2eea5b5
PE
39602011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 * xselect.c: Use signed conversions more consistently (Bug#9498).
3963 (selection_data_to_lisp_data): Assume incoming selection data are
3964 signed integers, not unsigned. This is to be consistent with
3965 outgoing selection data, which was modified to use signed integers
3966 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3967 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3968 expects long, not unsigned long.
3969
46888499
EZ
39702011-09-14 Eli Zaretskii <eliz@gnu.org>
3971
3972 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3973 computation of loop end. Reported by Johan Bockgård
3974 <bojohan@gnu.org>.
3975
ef8ef9fb
CY
39762011-09-13 Chong Yidong <cyd@stupidchicken.com>
3977
3978 * frame.c (Fother_visible_frames_p): Function deleted.
3979
fa819fed
EZ
39802011-09-12 Eli Zaretskii <eliz@gnu.org>
3981
3982 * indent.c (compute_motion): Process display vector front to back
3983 rather than the other way around. (Bug#2496)
3984
2ba8e008
SM
39852011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3986
3987 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3988
20f53c69
CY
39892011-09-11 Chong Yidong <cyd@stupidchicken.com>
3990
3991 * minibuf.c (Fread_from_minibuffer): Doc fix.
3992
d562d7a4
EZ
39932011-09-11 Eli Zaretskii <eliz@gnu.org>
3994
3995 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3996 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3997
1c4d7f3d
LMI
39982011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3999
4000 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4001 value for non-existent files.
4002
b885bf36
EZ
40032011-09-11 Eli Zaretskii <eliz@gnu.org>
4004
4005 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4006 set its "size" to -1. This will set the modtime_size field of
4007 the corresponding buffer to -1, which is what
4008 verify-visited-file-modtime expects for files that do not exist.
4009 (Bug#9139)
4010
6612f0bf
PE
40112011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4014 here ...
4015 * lisp.h: ... from here. push_key_description is no longer
4016 defined in keyboard.c, so its declaration should not be in
4017 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4018 logically belongs with push_key_description.
4019
dfb3f755
PE
40202011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * buffer.h: Include <sys/types.h> instead of <time.h>.
4023 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4024 Problem reported by Herbert J. Skuhra.
4025
3134906c
LMI
40262011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4027
4028 * xml.c (parse_region): Make the parsing work for
4029 non-comment-starting XML files again (bug#9144).
4030
8d903f4e
AS
40312011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4032
4033 * image.c (gif_load): Fix calculation of bottom and right corner.
4034 (Bug#9468)
4035
80ad64f4
EZ
40362011-09-10 Eli Zaretskii <eliz@gnu.org>
4037
4038 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4039 redisplay in small windows.
4040
208a048d
EZ
40412011-09-09 Eli Zaretskii <eliz@gnu.org>
4042
4043 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4044
9b1c252e
MR
40452011-09-08 Martin Rudalics <rudalics@gmx.at>
4046
4047 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4048 Operate on live windows only.
4049
2949f33b
JB
40502011-09-08 Juanma Barranquero <lekktu@gmail.com>
4051
4052 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4053
e08dcafd
EZ
40542011-09-07 Eli Zaretskii <eliz@gnu.org>
4055
4056 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4057 only under bidi iteration.
4058
115b96bd
JD
40592011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4060
4061 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4062
c8199d0f
PE
40632011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4064
4065 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4066 Without this fix, the command to link temacs failed due to an
4067 undefined symbol __builtin_isnan. This is because
4068 /usr/include/iso/math_c99.h #defines isnan(x) to
4069 __builtin_isnan(x), but the bundled gcc, which identifies itself
4070 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4071 a __builtin_isnan.
4072 * floatfns.c (isnan): #undef, and then #define to a clone of
4073 what's in data.c.
4074 (Fisnan): Always define, since it's always available now.
4075 (syms_of_floatfns): Always define isnan at the Lisp level.
4076
e39b275c 40772011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4078
4079 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4080
b2db44d9 40812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4082
f4af5137 4083 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4084 The previous code assumed that file offsets (off_t values) fit in
4085 EMACS_INT variables, which is not true on typical 32-bit hosts.
4086 The code messed up by falsely reporting buffer overflow in cases
4087 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4088 when "big" contains more than 2**29 bytes, even though this
4089 inserts just one byte and does not overflow the buffer.
4090 (Finsert_file_contents): Store file offsets as off_t
4091 values, not as EMACS_INT values. Check for overflow when
4092 converting between EMACS_INT and off_t. When checking for
4093 buffer overflow or for overlap, take the offsets into account.
4094 Don't use EMACS_INT for small values where int suffices.
4095 When checking for overlap, fix a typo: ZV was used where
4096 ZV_BYTE was intended.
4097 (Fwrite_region): Don't assume off_t fits into 'long'.
4098 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4099
ecfc0a49
MA
41002011-09-05 Michael Albinus <michael.albinus@gmx.de>
4101
4102 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4103
6511acf2 41042011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4105
0999621a 4106 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4107
4108 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4109 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4110 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4111 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4112 (modify_event_symbol): Do not assume that the length of
4113 name_alist_or_stem is safe to alloca and fits in int.
4114 (Fexecute_extended_command): Likewise for function name and binding.
4115 (Frecursion_depth): Wrap around reliably on integer overflow.
4116 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4117 since some callers pass EMACS_INT values.
4118 (Fsingle_key_description): Don't crash if symbol name contains more
4119 than MAX_ALLOCA bytes.
4120 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4121 (get_minibuffer): Arg is now EMACS_INT, not int.
4122 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4123 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4124 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4125
2be7d702
PE
4126 * dbusbind.c (signature_cat): New function.
4127 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4128 Do not overrun buffer; instead, report string overflow.
4129
9d1df220
PE
4130 * dispnew.c (add_window_display_history): Don't overrun buffer.
4131 Truncate instead; this is OK since it's just a log.
4132
33ef5c64
PE
4133 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4134 even if the time zone offset is outlandishly large.
4135 Don't mishandle offset == INT_MIN.
4136
66c6fdd5
PE
4137 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4138 when creating daemon; the previous buffer-overflow check was incorrect.
4139
d749b01b
PE
4140 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4141 which has the guts of the old verror function.
4142
b5cd1905
PE
4143 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4144 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4145
6e1a67fb
PE
4146 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4147 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4148 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4149 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4150 length of string rather than counting it via multiple sprintfs;
4151 that's simpler and more reliable.
c21721cc
PE
4152 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4153 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4154 sprintf, in case result does not fit in int.
4155
c57b67fc
PE
4156 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4157 (fontset_from_font): Print it.
4158
8a401434
PE
4159 * frame.c (tty_frame_count): Now printmax_t, not int.
4160 (make_terminal_frame, set_term_frame_name): Print it.
4161 (x_report_frame_params): In X, window IDs are unsigned long,
4162 not signed long, so print them as unsigned.
4163 (validate_x_resource_name): Check for implausibly long names,
4164 and don't assume name length fits in 'int'.
4165 (x_get_resource_string): Don't blindly alloca invocation name;
4166 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4167 not fit in int.
4168
6e1a67fb
PE
4169 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4170 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4171 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4172
0df02bf3
PE
4173 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4174 Use esprintf, not sprintf, in case result does not fit in int.
4175
48e30793
PE
4176 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4177 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4178 it as a large positive number.
4179 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4180 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4181
a66ff6d8
PE
4182 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4183 in case result does not fit in int.
4184
aca216ff
PE
4185 * print.c (float_to_string): Detect width overflow more reliably.
4186 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4187 buffer overrun. Don't assume list length fits in 'int'. Treat
4188 print length of 0 as 0, not as infinity; to be consistent with other
4189 uses of print length in this function. Don't overflow print length
4190 index. Don't assume hash table size fits in 'long', or that
4191 vectorlike size fits in 'unsigned long'.
4192
31c286f7
PE
4193 * process.c (make_process): Use printmax_t, not int, to format
4194 process-name gensyms.
4195
55e5faa1
PE
4196 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4197
80f2e268
PE
4198 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4199 to avoid potential buffer overrun.
4200
670741ab
PE
4201 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4202 if X resource line is longer than 512 bytes.
4203
b7163a50
PE
4204 * xfns.c (x_window): Make sprintf buffer a bit bigger
4205 to avoid potential buffer overrun.
4206
ae58ff1f
PE
4207 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4208
c43c8a6a
PE
4209 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4210
3f8236f4
PE
42112011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4212
53e9fe90 4213 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4214 Without these, Emacs silently mishandles large integers sometimes.
4215 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4216 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4217
6511acf2
PE
4218 * xdisp.c (try_window_id): Check Emacs fixnum range before
4219 converting to 'int'.
806add1d 4220
6511acf2 4221 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4222 Check that an Emacs fixnum is in range before assigning it to 'int'.
4223 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4224 values converted from Emacs fixnums.
4225 (Frecenter): Don't wrap around a line count if it is out of 'int'
4226 range; instead, treat it as an extreme value.
4227 (Fset_window_configuration, compare_window_configurations):
4228 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4229
6511acf2
PE
4230 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4231 that can exceed INT_MAX. Check that EMACS_INT value is in range
4232 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4233 (match_limit): Don't assume that a fixnum can fit in 'int'.
4234
6511acf2 4235 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4236 exceed INT_MAX.
4237
6511acf2 4238 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4239 (Fvertical_motion): Don't wrap around LINES values that don't fit
4240 in 'int'. Instead, treat them as extreme values. This is good
4241 enough for windows, which can't have more than INT_MAX lines anyway.
4242
fcb901a7
LMI
42432011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4244
0f2f6b6d
LMI
4245 * Require libxml/parser.h to avoid compilation warning.
4246
fcb901a7
LMI
4247 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4248
4249 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4250 since this reportedly can destroy thread storage.
4251
6e20a0d4
CY
42522011-08-30 Chong Yidong <cyd@stupidchicken.com>
4253
4254 * syntax.c (find_defun_start): Update all cache variables if
4255 exiting early (Bug#9401).
4256
148ae00e
EZ
42572011-08-30 Eli Zaretskii <eliz@gnu.org>
4258
f6cfbd8f
EZ
4259 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4260
148ae00e
EZ
4261 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4262 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4263 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4264
4265 * term.c (tty_append_glyph): New function.
4266 (produce_stretch_glyph): Static function and its prototype deleted.
4267
a66cfb1c
SM
4268 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4269 Add prototypes.
148ae00e 4270
c4a07a4c
PE
42712011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4272
4273 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4274 when checking :margin (Bug#9390).
4275 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4276 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4277 so that the name doesn't mislead. All uses changed.
4278
6bc8cd65
JB
42792011-08-28 Johan Bockgård <bojohan@gnu.org>
4280
4281 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4282 set_tty_hooks.
4283
dca4927e
EZ
42842011-08-27 Eli Zaretskii <eliz@gnu.org>
4285
4286 * xdisp.c (move_it_to): Don't bail out early when reaching
4287 position beyond to_charpos, if we are scanning backwards.
4288 (move_it_vertically_backward): When DY == 0, make sure we get to
4289 the first character in the line after the newline.
4290
f2cad773
PE
42912011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4292
4293 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4294 (ccl_driver): Do not generate an out-of-range pointer.
4295 (Fccl_execute_on_string): Remove unnecessary check for
4296 integer overflow, noted by Stefan Monnier in
4297 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4298 Remove a FIXME that didn't need fixing.
4299 Simplify the newly-introduced buffer reallocation code.
4300
0cae2cdb
JB
43012011-08-27 Juanma Barranquero <lekktu@gmail.com>
4302
4303 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4304
5fc295a4 43052011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4306
70c60eb2 4307 Integer and memory overflow issues (Bug#9196).
726e0ab1 4308
d31850da
PE
4309 * doc.c (get_doc_string): Rework so that
4310 get_doc_string_buffer_size is the actual buffer size, rather than
4311 being 1 less than the actual buffer size; this makes xpalloc more
4312 convenient.
4313
a69fbedb
PE
4314 * image.c (x_allocate_bitmap_record, cache_image):
4315 * xselect.c (Fx_register_dnd_atom):
4316 Simplify previous changes by using xpalloc.
4317
fe5c5d37
PE
4318 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4319 since either will do and ptrdiff_t is convenient with xpalloc.
4320
0065d054
PE
4321 * charset.c (charset_table_size)
4322 (struct charset_sort_data.priority): Now ptrdiff_t.
4323 (charset_compare): Don't overflow if priorities differ greatly.
4324 (Fsort_charsets): Don't assume list length fits in int.
4325 Check for size-calculation overflow when allocating sort data.
4326 (syms_of_charset): Allocate an initial charset table that is
4327 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4328
4329 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4330
4331 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4332 The actual value is always <= INT_MAX, and leaving it unsigned made
4333 overflow checking harder.
4334
4335 * dispextern.h (struct glyph_matrix.rows_allocated)
4336 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4337 with xpalloc. The values are still always <= INT_MAX.
4338
4339 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4340
4341 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4342 (SAFE_NALLOCA): New macro.
4343
4344 * region-cache.c (struct boundary.pos, find_cache_boundary)
4345 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4346 (set_cache_region, invalidate_region_cache)
4347 (revalidate_region_cache, know_region_cache, region_cache_forward)
4348 (region_cache_backward, pp_cache):
4349 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4350 so that ptrdiff_t * can be passed to xpalloc.
4351 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4352 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4353 (pp_cache): Don't assume cache_len fits in int.
4354 * region-cache.h: Adjust extern decls to match.
4355
4356 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4357 EMACS_INT, since either will do, for xpalloc.
4358
4359 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4360 (xnmalloc, xnrealloc, xpalloc): New functions.
4361
726e0ab1
PE
4362 * bidi.c (bidi_shelve_header_size): New constant.
4363 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4364 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4365
51f30bc5 4366 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4367 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4368 (overlay_strings):
4369 Don't update size of array until after memory allocation succeeds,
4370 because xmalloc/xrealloc may not return.
0065d054
PE
4371 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4372 now that we have proper integer overflow checking.
4373 (record_overlay_string, overlay_strings): Catch overflows when
4374 calculating size of overlay_str_buf.
726e0ab1 4375
0065d054
PE
4376 * callproc.c (Fcall_process): Check for size overflow when
4377 calculating size of args2.
4378 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4379 Normally we prefer signed values, but sticking with ptrdiff_t would
4380 require adding more-complicated checks.
726e0ab1
PE
4381
4382 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4383 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4384 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4385 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4386
4387 * character.c (Fstring): Check for size-calculation overflow.
4388
4389 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4390 unnecessary integer overflow. Check for size overflow.
4391 (encode_coding_object): Don't update size until xmalloc succeeds.
4392
4393 * composite.c (get_composition_id): Check for overflow in glyph
4394 length calculations.
4395
4396 Integer and memory overflow fixes for display code.
4397 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4398 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4399 (scrolling_window): Check for overflow in size calculations.
4400 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4401 Don't assume glyph table len fits in int.
4402 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4403 (row_table_size): Now ptrdiff_t, not int.
4404 (scrolling_window): Avoid overflow in size calculations.
4405 Don't update size until allocation succeeds.
4406 * fns.c (concat): Check for overflow in size calculations.
4407 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4408 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4409 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4410
4411 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4412 (get_doc_string): Check for size calculation overflow.
4413 Don't update size until allocation succeeds.
4414 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4415 EMACS_INT, where ptrdiff_t will do.
4416 (Fsubstitute_command_keys): Check for string overflow.
4417
4418 * editfns.c (set_time_zone_rule): Don't assume environment length
4419 fits in int.
4420 (message_length): Now ptrdiff_t, not int.
4421 (Fmessage_box): Don't update size until allocation succeeds.
4422 Don't assume message length fits in int.
4423 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4424
0065d054
PE
4425 * emacs.c (main): Do not reallocate argv, since there is a null at
4426 the end that can be overwritten, and this way there's no need to
4427 worry about size-calculation overflow.
4428 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4429
4430 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4431 alloc succeeds.
4432 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4433
4434 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4435 (x_set_scroll_bar_width, x_figure_window_size):
4436 Check for integer overflow.
4437 (x_set_alpha): Do not assume XINT fits in int.
4438
4439 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4440 This is for the members text_lines, text_cols, total_lines, total_cols,
4441 where the system imposes an 'int' limit.
4442
4443 * fringe.c (Fdefine_fringe_bitmap):
4444 Don't update size until alloc works.
4445
4446 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4447 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4448
4449 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4450 Check for size-calculation overflow.
4451 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4452 do, as we prefer signed integers.
4453 (id_to_widget.max_size, id_to_widget.used)
4454 (xg_store_widget_in_map, xg_remove_widget_from_map)
4455 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4456 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4457 Use and return ptrdiff_t, not int.
4458 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4459 * gtkutil.h: Change prototypes to match the above.
4460
4461 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4462 are duplicate now that they've been promoted to lisp.h.
4463 (x_allocate_bitmap_record, x_alloc_image_color)
4464 (make_image_cache, cache_image, xpm_load):
4465 Don't update size until alloc is done.
4466 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4467 (x_detect_edges):
3256efce 4468 Check for size calculation overflow.
726e0ab1
PE
4469 (ct_colors_allocated_max): New constant.
4470 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4471 overflow.
3256efce 4472
726e0ab1
PE
4473 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4474 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4475 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4476 Use ptrdiff_t, not int, to count maps.
4477 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4478 calculations. Don't update size until allocation succeeds.
4479 Redo calculations to avoid overflow.
726e0ab1
PE
4480 * keyboard.h: Change prototypes to match the above.
4481
4482 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4483 to count maps.
4484 (current_minor_maps): Check for size calculation overflow.
4485 * keymap.h: Change prototypes to match the above.
4486
4487 * lread.c (read1, init_obarray): Don't update size until alloc done.
4488
4489 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4490 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4491
726e0ab1
PE
4492 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4493 Now ptrdiff_t, not int.
4494 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4495 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4496
4497 * process.c (Fnetwork_interface_list): Check for overflow
4498 in size calculation.
4499
4500 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4501
4502 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4503 overflow. Don't bother calling xmalloc when xrealloc will do.
4504
4505 * search.c (Freplace_match): Check for size calculation overflow.
4506 (Fset_match_data): Don't assume list lengths fit in 'int'.
4507
4508 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4509 for command line length. Do not attempt to address one before the
4510 beginning of an array, as that's not portable.
4511
4512 * term.c (max_frame_lines): Remove; unused.
4513 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4514 not int.
4515 (encode_terminal_code, calculate_costs): Check for size
4516 calculation overflow.
4517 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4518 table lengths and related sizes. Don't update size until alloc
4519 done. Redo calculations to avoid overflow.
4520 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4521
4522 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4523 subtracting pointers.
4524 (gobble_line): Check for overflow more carefully. Don't update size
4525 until alloc done.
4526
4527 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4528 Don't update size until alloc done.
4529 Redo size calculations to avoid overflow.
4530 Check for size calculation overflow.
0065d054 4531 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4532
4533 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4534 Use ptrdiff_t, not int, for sizes.
4535 (store_mode_line_noprop_char): Don't update size until alloc done.
4536
0065d054
PE
4537 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4538 Use ptrdiff_t, not int, for sizes.
4539 (Finternal_make_lisp_face, cache_face):
4540 Check for size calculation overflow.
4541 (cache_face): Treat size calculation overflows as if they were
4542 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4543
4544 * xfns.c (x_encode_text, x_set_name_internal)
4545 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4546 sizes, since they can exceed INT_MAX in size. Check for size
4547 calculation overflow.
4548
0065d054
PE
4549 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4550 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4551 Don't update size until alloc done.
4552
0065d054 4553 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4554 as sprintf is limited to int lengths.
1d526e2f 4555
252c5ee1
PE
4556 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4557 (X_LONG_MIN): New macros.
864d7ce7
PE
4558 Use them to make the following changes clearer.
4559 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4560 This change doesn't affect the value now, but it may help remind
4561 future maintainers not to raise the value too much later.
4562 (SELECTION_QUANTUM): Remove, replacing with ...
4563 (selection_quantum): ... new function, which avoids overflow.
4564 All uses changed.
4565 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4566 assumption that selection length fits in 'int'.
4567 (x_reply_selection_request, x_handle_selection_request)
4568 (x_get_window_property, receive_incremental_selection)
4569 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4570 (lisp_data_to_selection_data, clean_local_selection_data):
4571 Use ptrdiff_t, not int, to record length of selection.
4572 (x_reply_selection_request, x_get_window_property)
4573 (receive_incremental_selection, x_property_data_to_lisp):
4574 Redo calculations to avoid overflow.
4575 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4576 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4577 something.
4578 (x_get_window_property, receive_incremental_selection)
4579 (lisp_data_to_selection_data, x_property_data_to_lisp):
4580 Check for size-calculation overflow.
4581 (x_get_window_property, receive_incremental_selection)
4582 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4583 Don't store size until memory allocation succeeds.
4584 (x_get_window_property): Plug memory leak on memory exhaustion.
4585 Don't double-block input; malloc is safe here. Don't assume 2**34
4586 - 4 fits in unsigned long. Add an xassert to check
4587 XGetWindowProperty overflow. Be more careful about overflow
4588 calculations, and distinguish size from memory overflow better.
4589 (receive_incremental_selection): When tracing, don't assume
4590 unsigned int is less than INT_MAX.
4591 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4592 harmful) conversions of unsigned short to int.
4593 (lisp_data_to_selection_data): Don't assume that integers
4594 in the range -65535 through -1 fit in an X unsigned short.
4595 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4596 result parameters unless successful. Rely on cons_to_unsigned
4597 to report problems with elements; the old code wasn't right anyway.
4598 (x_check_property_data): Check for int overflow; we cannot use
4599 a wider type due to X limits.
4600 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4601
726e0ab1 4602 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4603
0065d054
PE
4604 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4605 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4606 (x_color_cells): Don't store size until memory allocation succeeds.
4607 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4608 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4609 (x_term_init): Don't assume length fits in int (sprintf is limited
4610 to int size).
bc18e09d 4611
ebfa62c0
PE
4612 Use ptrdiff_t for composition IDs.
4613 * character.c (lisp_string_width):
4614 * composite.c (composition_table_size, n_compositions)
4615 (get_composition_id, composition_gstring_from_id):
4616 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4617 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4618 * window.c (Frecenter):
4619 Use ptrdiff_t, not int, for composition IDs.
4620 * composite.c (get_composition_id): Check for integer overflow.
4621 * composite.h: Adjust prototypes to match the above changes.
4622
d3411f89
PE
4623 Use ptrdiff_t for hash table indexes.
4624 * category.c (hash_get_category_set):
4625 * ccl.c (ccl_driver):
4626 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4627 * coding.c (coding_system_charset_list, detect_coding_system):
4628 * coding.h (struct coding_system.id):
4629 * composite.c (get_composition_id, gstring_lookup_cache):
4630 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4631 * image.c (xpm_get_color_table_h):
4632 * lisp.h (hash_lookup, hash_put):
4633 * minibuf.c (Ftest_completion):
4634 Use ptrdiff_t for hash table indexes, not int (which is too
4635 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4636 32-bit --with-wide-int hosts).
4637
e097a6fa
PE
4638 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4639 Add a FIXME comment about memory leaks.
4640 (syms_of_charset): Don't assume xmalloc returns.
4641
5637687f
PE
4642 Don't assume that stated character widths fit in int.
4643 * character.c (Fchar_width, c_string_width, lisp_string_width):
4644 * character.h (CHAR_WIDTH):
4645 * indent.c (MULTIBYTE_BYTES_WIDTH):
4646 Use sanitize_char_width to avoid undefined and/or bad behavior
4647 with outlandish widths.
a66cfb1c 4648 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4649 now that we have two such functions. All uses changed.
4650 (sanitize_char_width): New inline function.
4651
a2271ba2
PE
4652 Don't assume that tab-width fits in int.
4653 * character.h (sanitize_width): New inline function.
4654 (SANE_TAB_WIDTH): New macro.
4655 (ASCII_CHAR_WIDTH): Use it.
4656 * indent.c (sane_tab_width): Remove. All uses replaced by
4657 SANE_TAB_WIDTH (current_buffer).
4658 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4659
18c52557
PE
4660 * fileio.c: Integer overflow issues with file modes.
4661 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4662
caeeedc1
PE
4663 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4664 Remove unreachable code.
4665 (read_hex, load_charset_map_from_file): Check for integer overflow.
4666
6df6ae42 4667 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4668 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4669 (x_send_scroll_bar_event): Likewise. Check that the size does not
4670 exceed limits imposed by XClientMessageEvent, as well as the usual
4671 ptrdiff_t and size_t limits.
4672
b13995db
PE
4673 * keyboard.c: Overflow, signedness and related fixes.
4674 (make_lispy_movement): Use same integer type in forward decl
4675 that is used in the definition.
4676 (read_key_sequence, keyremap_step):
4677 Change bufsize argument back to int, undoing my 2011-03-30 change.
4678 We prefer signed types, and int is wide enough here.
4679 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4680 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4681 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4682 length, not size_t. Use ptrdiff_t for index, not int.
4683 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4684 possibility of integer overflow.
4685
13464394
PE
4686 Overflow, signedness and related fixes for images.
4687
4688 * dispextern.h (struct it.stack[0].u.image.image_id)
4689 (struct_it.image_id, struct image.id, struct image_cache.size)
4690 (struct image_cache.used, struct image_cache.ref_count):
4691 * gtkutil.c (update_frame_tool_bar):
4692 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4693 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4694 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4695 * nsmenu.m (update_frame_tool_bar):
4696 * xdisp.c (calc_pixel_width_or_height):
4697 * xfns.c (image_cache_refcount):
4698 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4699 on typical 64-bit hosts.
4700
4701 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4702 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4703 Omit unnecessary casts to int.
4704 (parse_image_spec): Check that integers fall into 'int' range
4705 when the callers expect that.
4706 (image_ascent): Redo ascent calculation to avoid int overflow.
4707 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4708 (lookup_image): Remove unnecessary tests.
4709 (xbm_image_p): Locals are now of int, not EMACS_INT,
4710 since parse_image_check makes sure they fit into int.
4711 (png_load, gif_load, svg_load_image):
4712 Prefer int to unsigned where either will do.
4713 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
4714 old tiff_error_handler and tiff_warning_handler.
4715 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
4716 stack buffer overflows. It uses only the features of vsnprintf
4717 that are common to both POSIX and native Microsoft.
4718 (tiff_error_handler, tiff_warning_handler): Use it.
4719 (tiff_load, gif_load, imagemagick_load_image):
4720 Don't assume :index value fits in 'int'.
4721 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4722 (imagemagick_load_image): Check that crop parameters fit into
4723 the integer types that MagickCropImage accepts. Don't assume
4724 Vimagemagick_render_type has a nonnegative value. Don't assume
4725 size_t fits in 'long'.
4726 (gs_load): Use printmax_t to print the widest integers possible.
4727 Check for integer overflow when computing image height and width.
4728
c11821d4
EZ
47292011-08-26 Eli Zaretskii <eliz@gnu.org>
4730
4731 * xdisp.c (redisplay_window): Don't force window start if point
4732 will be invisible in the resulting window. (Bug#9324)
4733
0c95fcf7
EZ
47342011-08-25 Eli Zaretskii <eliz@gnu.org>
4735
4736 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4737 the display spec is of the form `(space ...)'.
4738 (handle_display_spec): Return the value returned by
4739 handle_single_display_spec, not just 1 or zero.
4740 (handle_single_display_spec): If the display spec is of the form
4741 `(space ...)', and specifies display in the text area, return 2
4742 rather than 1.
fee65a97 4743 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
4744 accurately, and prefer exact match for point under bidi.
4745 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
4746
4747 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4748 into disp_prop; all users changed.
4749
4750 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4751 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4752 for the text covered by the display property.
4753
e4ed06f1
CY
47542011-08-25 Chong Yidong <cyd@stupidchicken.com>
4755
4756 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4757 Change return value to nil.
4758 (Frecord_buffer): Delete unused function.
4759
f67cdd7f
EZ
47602011-08-24 Eli Zaretskii <eliz@gnu.org>
4761
5980d4c6
EZ
4762 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4763 buffers, return left-to-right.
8610fe8b
EZ
4764 (set_cursor_from_row): Consider candidate row a win if its glyph
4765 represents a newline and point is on that newline. Fixes cursor
4766 positioning on the newline at EOL of R2L text within L2R
4767 paragraph, and vice versa.
4768 (try_cursor_movement): Check continued rows, in addition to
4769 continuation rows. Fixes unwarranted scroll when point enters a
4770 continued line of R2L text within an L2R paragraph, or vice versa.
4771 (cursor_row_p): Consider the case of point being equal to
4772 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4773 from the end of a short line to the beginning of a continued line
4774 of R2L text within L2R paragraph.
4775 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4776 composed characters.
5980d4c6 4777
f67cdd7f
EZ
4778 * bidi.c (bidi_check_type): Use xassert.
4779 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4780 members.
4781
bca633fb
EZ
47822011-08-23 Eli Zaretskii <eliz@gnu.org>
4783
4784 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4785 a character.
4786
4a5885a7
CY
47872011-08-23 Chong Yidong <cyd@stupidchicken.com>
4788
4789 * nsfont.m (ns_otf_to_script): Fix typo.
4790
0902a04e
KH
47912011-08-22 Kenichi Handa <handa@m17n.org>
4792
4793 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4794 extra slot even if the purpose is char-code-property-table.
4795
1a2e6670
EZ
47962011-08-23 Eli Zaretskii <eliz@gnu.org>
4797
8ddde651
EZ
4798 * xdisp.c (redisplay_window): When computing centering_position,
4799 account for the height of the header line. (Bug#8874)
4800
425cc014
EZ
4801 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4802 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4803 candidate is selected by the mouse, and that candidate has a
4804 composed character under the mouse.
4805
1a2e6670
EZ
4806 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4807 coordinates reported by pos-visible-in-window-p for a composed
4808 character in column zero.
4809
8b76d6f8
SM
48102011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4811
4812 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4813
dac347dd
EZ
48142011-08-22 Eli Zaretskii <eliz@gnu.org>
4815
4816 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4817 consider it a hit if to_charpos is anywhere in the range of the
4818 composed buffer positions.
4819
e013fb34
CY
48202011-08-22 Chong Yidong <cyd@stupidchicken.com>
4821
4822 * image.c (gif_load): Don't assume that each subimage has the same
4823 dimensions as the base image. Handle disposal method that is
4824 "undefined" by the gif spec (Bug#9335).
4825
bd1ba3e8
CY
48262011-08-20 Chong Yidong <cyd@stupidchicken.com>
4827
4828 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 4829 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 4830
54a1215b
EZ
48312011-08-19 Eli Zaretskii <eliz@gnu.org>
4832
823564e5
EZ
4833 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4834 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4835 from an Org mode buffer to a Speedbar frame.
4836
54a1215b
EZ
4837 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4838 a composition, take its buffer position from IT->cmp_it.charpos.
4839 Fixes cursor positioning at the beginning of a line that begins
4840 with a composed character.
4841
9778ebcc
EZ
48422011-08-18 Eli Zaretskii <eliz@gnu.org>
4843
0be6ee06
EZ
4844 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4845 character bidirectional type, use STRONG_L instead. Fixes crashes
4846 in a buffer produced by `describe-categories'.
4847
9778ebcc
EZ
4848 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4849 members before the level stack, so they would be saved and
4850 restored when copying iterator state. Fixes incorrect reordering
4851 around TABs covered by display properties.
4852
156bffbe
AS
48532011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4854
6b02f655 4855 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 4856
72ad093b
CY
48572011-08-17 Chong Yidong <cyd@stupidchicken.com>
4858
4859 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
4860 (internal_condition_case_2, internal_condition_case_n):
4861 Remove unnecessary aborts (Bug#9081).
72ad093b 4862
35774242
EZ
48632011-08-17 Eli Zaretskii <eliz@gnu.org>
4864
4865 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4866 has no `load' handler, try opening the file locally. (Bug#9311)
4867
db76dd85
KB
48682011-08-16 Ken Brown <kbrown@cornell.edu>
4869
4870 * gmalloc.c: Expand comment.
4871
b215eee5
EZ
48722011-08-16 Eli Zaretskii <eliz@gnu.org>
4873
4874 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4875 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4876
a4579d33
KB
48772011-08-16 Ken Brown <kbrown@cornell.edu>
4878
4879 Fix memory allocation problems in Cygwin build (Bug#9273).
4880
4881 * unexcw.c ( __malloc_initialized): Declare external variable.
4882 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4883
8b76d6f8
SM
4884 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4885 New variables.
a4579d33
KB
4886 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4887 dumped emacs.
4888 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4889 in the static heap.
4890 [CYGWIN] (special_realloc): New function.
4891 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4892 requests to realloc storage in the static heap.
4893
3ebec551
PE
48942011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4895
4896 * bidi.c (bidi_initialize): Remove unused local.
4897
9fd8be00
EZ
48982011-08-15 Eli Zaretskii <eliz@gnu.org>
4899
6b02f655
SM
4900 * bidimirror.h:
4901 * biditype.h: Remove file.
4902 * makefile.w32-in ($(BLD)/bidi.$(O)):
4903 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
4904
4905 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4906
4907 * chartab.c: Improve commentary for the uniprop_table API.
4908
32413314
EZ
4909 * bidi.c (bidi_paragraph_init): Support zero value of
4910 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
4911 (bidi_initialize): Use uniprop_table instead of including
4912 biditype.h and bidimirror.h.
32413314 4913
9fd8be00
EZ
4914 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4915 coordinates of the iterator when restoring from ppos_it.
4916 (Bug#9296)
4917
5cf2b69b
KH
49182011-08-14 Kenichi Handa <handa@m17n.org>
4919
4920 * process.c (create_process): Call setup_process_coding_systems
72ad093b 4921 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 4922
daf17d00
EZ
49232011-08-14 Eli Zaretskii <eliz@gnu.org>
4924
4925 * xdisp.c (move_it_in_display_line_to): Don't invoke
4926 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4927 ppos_it. Fixes vertical cursor motion when line beginning is
4928 covered by an image. (Bug#9296)
4929
08e3161a
JD
49302011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4931
4932 * nsterm.h (ns_run_ascript): Declare.
4933 (NSAPP_DATA2_RUNASSCRIPT): Define.
4934
4935 * nsfns.m (as_script, as_result, as_status): New static variables.
4936 (ns_run_ascript): New function.
5e617bc2 4937 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
4938 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4939 the event loop. Get status from as_status (Bug#7276).
4940
4941 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4942 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4943 the event loop (Bug#7276).
4944
a3720aa2
AS
49452011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4946
4947 * gnutls.c (QCgnutls_bootprop_priority)
4948 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4949 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4950 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4951 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4952 (QCgnutls_bootprop_verify_hostname_error)
4953 (QCgnutls_bootprop_callbacks_verify): Rename from
4954 Qgnutls_bootprop_..., all uses changed.
4955
4956 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4957 uses changed.
4958
0a0d27fb
PE
49592011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4960
19d5c50c
PE
4961 * xfaces.c (Qframe_set_background_mode): Now static.
4962 * dispextern.h (Qframe_set_background_mode): Remove decl.
4963
0a0d27fb
PE
4964 * process.c (Fnetwork_interface_info): Declare local only if needed.
4965
377538cb
JD
49662011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4967
4968 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4969 (Fnetwork_interface_list): Allocate in increments of bytes instead
4970 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4971 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4972 sockaddr.
4973 (struct ifflag_def): notrailers is smart on OSX.
4974 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4975 Get hardware address with getifaddrs if available.
4976
08fff70c
EZ
49772011-08-12 Eli Zaretskii <eliz@gnu.org>
4978
4979 * xdisp.c (iterate_out_of_display_property): xassert that
4980 IT->position is set to within IT->object's boundaries. Break from
4981 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
4982 when IT->position is set up wrongly due to some bug.
4983 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
4984 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4985 entry. Force push_it to save on the stack the current
4986 buffer/string position, to be restored by pop_it. Fix flags in
4987 the iterator structure wrt the object coming from a display
4988 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4989 properties. (Bug#9284)
4990
7be1c708 49912011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 4992
7be1c708
CY
4993 * fontset.c (fontset_get_font_group): Add proper type checks.
4994 (Bug#9172)
aac0c6e3 4995
7be1c708 49962011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 4997
7be1c708
CY
4998 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4999 and LC_VERSION_MIN_MACOSX.
5000 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5001 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5002
97bb72a6
EZ
50032011-08-08 Eli Zaretskii <eliz@gnu.org>
5004
5005 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5006 no-display-properties-and-no-overlays under bidi display.
5007 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5008 properties and overlays.
97bb72a6 5009
d5617611
CY
50102011-08-08 Chong Yidong <cyd@stupidchicken.com>
5011
37e11a63
CY
5012 * editfns.c (Fset_time_zone_rule): Document relationship with the
5013 setenv function.
5014
d5617611
CY
5015 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5016 the font entity extracted from the cache (Bug#8109).
5017
58872834
CY
50182011-08-07 Chong Yidong <cyd@stupidchicken.com>
5019
5020 * composite.c (autocmp_chars): Don't reset point. That is done by
5021 restore_point_unwind (Bug#5984).
5022
75bfc667
JL
50232011-08-07 Juri Linkov <juri@jurta.org>
5024
5025 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5026 to show the arg `TIME' instead of `TIMEVAL'.
5027
d1410150
EZ
50282011-08-06 Eli Zaretskii <eliz@gnu.org>
5029
5030 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5031 display property strides EOL and includes a newline, as in
5032 longlines-mode. (Bug#9254)
75b771e4
EZ
5033 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5034 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5035
5036 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5037 is non-zero, even if the data buffer is NULL. Fixes a crash in
5038 vertical-motion with longlines-mode. (Bug#9254)
5039
35928349
EZ
50402011-08-05 Eli Zaretskii <eliz@gnu.org>
5041
ec7cc85b
EZ
5042 * bidi.c <bidi_cache_total_alloc>: Now static.
5043 (bidi_initialize): Initialize bidi_cache_total_alloc.
5044
8b76d6f8 5045 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5046 cache. (Bug#9221)
5047
5048 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5049 amount allocated this far in `bidi_cache_total_alloc'.
5050 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5051 non-zero, only free the data buffer without restoring the cache
5052 contents. All callers changed.
5053
5054 * dispextern.h (bidi_unshelve_cache): Update prototype.
5055
5056 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5057 (move_it_in_display_line, move_it_to)
5058 (move_it_vertically_backward, move_it_by_lines): Replace the call
5059 to xfree to an equivalent call to bidi_unshelve_cache.
5060 (move_it_in_display_line_to): Fix logic of returning
412b6358 5061 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5062
e2e2423b
EZ
50632011-08-05 Eli Zaretskii <eliz@gnu.org>
5064
5065 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5066 came from a string character with a `cursor' property. (Bug#9229)
5067
ae9e757a
JD
50682011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5069
5070 * Makefile.in (LIB_PTHREAD): New variable.
5071 (LIBES): Add LIB_PTHREAD (Bug#9216).
5072
5073 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5074 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5075
213bd7f2
AS
50762011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5077
6b02f655 5078 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5079
99aaf75f
JD
50802011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5081
5082 * xterm.c (x_find_topmost_parent): New function.
5083 (x_set_frame_alpha): Find topmost parent window with
5084 x_find_topmost_parent and set the property there also (bug#9181).
5085 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5086
c74e9d86
PE
50872011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5088
5089 * callproc.c (Fcall_process): Avoid vfork clobbering
5090 the local vars buffer, coding_systems, current_dir.
5091
640c8776
SM
50922011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5093
5094 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5095
f26d0e4c
PE
50962011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5097
8a10d76c
PE
5098 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5099 so that it is not optimized away.
5100
f26d0e4c
PE
5101 * xdisp.c (compute_display_string_pos): Remove unused local.
5102
55439c61
EZ
51032011-08-02 Eli Zaretskii <eliz@gnu.org>
5104
5105 Fix slow cursor motion and scrolling in large buffers with
5106 selective display, like Org Mode buffers. (Bug#9218)
5107
5108 * dispextern.h (struct bidi_it): New member disp_prop_p.
5109
5110 * xdisp.c: Remove one-slot cache of display string positions.
5111 (compute_display_string_pos): Accept an additional argument
5e617bc2 5112 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5113 for a display string or property. If found, set DISP_PROP_P
5114 non-zero.
5115
5116 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5117 DISP_PROP_P, and pass it to compute_display_string_pos.
5118 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5119 non-zero. All callers of bidi_fetch_char changed.
5120
fb33fa43
SM
51212011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5122
5123 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5124
b099e063
DM
51252010-12-03 Don March <don@ohspite.net>
5126
5127 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5128 last character M-[char] is translated to ESC [char] (bug#7541).
5129
5cc7f7af
KH
51302011-08-02 Kenichi Handa <handa@m17n.org>
5131
d0fffa3f 5132 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5133
5134 * chartab.c (uniprop_table): Make it non-static.
5135
525d5e6e
EZ
51362011-08-01 Eli Zaretskii <eliz@gnu.org>
5137
5138 * xdisp.c (forward_to_next_line_start): Accept additional argument
5139 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5140 on the newline.
5141 (reseat_at_next_visible_line_start): Use the bidi iterator state
5142 returned by forward_to_next_line_start to restore the state of
5143 it->bidi_it after backing up to previous newline. (Bug#9212)
5144
31011111
AS
51452011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5146
5147 * regex.c (re_comp): Protoize.
5148 (re_exec): Fix return type.
5149 (regexec): Fix type of `ret'. (Bug#9203)
5150
476371c4
PE
51512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5152
e5d76069
PE
5153 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5154 This is needed if max-image-size is a floating-point number.
5155
9a79b20c
AS
51562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5157
5158 * print.c (print_object): Print empty symbol as ##.
5159
5160 * lread.c (read1): Read ## as empty symbol.
5161
d8c2fa78
AA
51622011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5163
5164 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5165 setting frame foreground color (Bug#9175).
5166 (x_set_background_color): Likewise.
5167
ffe57a7a
AA
5168 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5169 contents (Bug#9176).
5170 (EmacsTooltip -init): Remove bezels and add shadows to
5171 tooltip windows.
5172
bf3492a5
AA
5173 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5174 or scroll bar (Bug#8470).
5175
d55e9c53
AA
5176 * nsfont.m (nsfont_open): Remove assignment to voffset and
5177 unnecessary vars hshink, expand, hd, full_height, min_height.
5178 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5179
5180 * nsterm.h (nsfont_info): Remove voffset field.
5181
d8c2fa78 51822011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5183
5184 Implement strike-through and overline on NextStep (Bug#8863).
5185
5186 * nsfont.m (nsfont_open): Use underline position provided by font,
5187 instead of hard-coded value of 2.
5188 (nsfont_draw): Call ns_draw_text_decoration instead.
5189
5190 * nsterm.h: Add declaration for ns_draw_text_decoration.
5191
5192 * nsterm.m (ns_draw_text_decoration): New function for drawing
5193 underline, overline, and strike-through.
5194 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5195 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5196 accommodate underlining, etc.
4843aac3 5197
4cc60b9b
EZ
51982011-07-28 Eli Zaretskii <eliz@gnu.org>
5199
bc7ece87
EZ
5200 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5201 default.
4cc60b9b 5202
476371c4
PE
52032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5204
66606eea
PE
5205 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5206 Without this fix, if a signal arrives just after memory fills up,
5207 'malloc' might be invoked reentrantly.
5208
476371c4
PE
5209 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5210 In other words, assume that every image size is allowed, on non-X
5211 hosts. This assumption is probably wrong, but it lets Emacs compile.
5212
f3fcc40d
AS
52132011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5214
5215 * regex.c (re_iswctype): Convert return values to boolean.
5216
350c992f
EZ
52172011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5218
5219 * xdisp.c (compute_display_string_pos): Don't use cached display
5220 string position if the buffer had its restriction changed.
5221 (Bug#9184)
5222
5266b4bb
PE
52232011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5224
5225 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5226
2573a837 52272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5228
41f55ccd 5229 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5230
39e378da
PE
5231 * bidi.c: Integer size and overflow fixes.
5232 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5233 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5234 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5235 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5236 (bidi_find_other_level_edge):
5237 Use ptrdiff_t instead of EMACS_INT where either will do.
5238 This works better on 32-bit hosts configured --with-wide-int.
5239 (bidi_cache_ensure_space): Check for size-calculation overflow.
5240 Use % rather than repeated addition, for better worst-case speed.
5241 Don't set bidi_cache_size until after xrealloc returns, because it
5242 might not return.
5243 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5244 (bidi_cache_ensure_space): Also check that the bidi cache size
5245 does not exceed that of the largest Lisp string or buffer. See Eli
5246 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5247
5e927815
PE
5248 * alloc.c (__malloc_size_t): Remove.
5249 All uses replaced by size_t. See Andreas Schwab's note
5250 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5251
ca4aa935
PE
5252 * image.c: Improve checking for integer overflow.
5253 (check_image_size): Assume that f is nonnull, since
5254 it is always nonnull in practice. This is one less thing to
5255 worry about when checking for integer overflow later.
5256 (x_check_image_size): New function, which checks for integer
5257 overflow issues inside X.
5258 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5259 This removes the need for a memory_full check.
5260 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5261 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5262 (xbm_read_bitmap_data): Change locals back to 'int', since
5263 their values must fit in 'int'.
5264 (xpm_load_image, png_load, tiff_load):
5265 Invoke x_create_x_image_and_pixmap earlier,
5266 to avoid much needless work if the image is too large.
5267 (tiff_load): Treat overly large images as if
5268 x_create_x_image_and_pixmap failed, not as malloc failures.
5269 (gs_load): Use x_check_image_size.
5270
5f8f9cc2
PE
5271 * gtkutil.c: Omit integer casts.
5272 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5273 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5274
5adf60bc
PE
5275 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5276
c8907a93
PE
5277 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5278 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5279 would wrongly return t on a 64-bit host.
5280
e3c25c68
PE
5281 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5282 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5283 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5284 and therefore cause GCC to emit a bogus diagnostic in some cases.
5285
3f791afe
PE
5286 * image.c: Integer signedness and overflow and related fixes.
5287 This is not an exhaustive set of fixes, but it's time to
5288 record what I've got.
5289 (lookup_pixel_color, check_image_size): Remove redundant decls.
5290 (check_image_size): Don't assume that arbitrary EMACS_INT values
5291 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5292 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5293 (tiff_load, imagemagick_load_image):
5294 Check for overflow in size calculations.
5295 (x_create_x_image_and_pixmap): Remove unnecessary test for
5296 xmalloc returning NULL; that can't happen.
5297 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5298 (xpm_color_bucket): Use better integer hashing function.
5299 (xpm_cache_color): Don't possibly over-allocate memory.
5300 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5301 (gif_memory_source):
5302 Use ptrdiff_t, not int or size_t, to record sizes.
5303 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5304 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5305 either works, as we prefer signed integers.
5306 (tiff_read_from_memory, tiff_write_from_memory):
5307 Return tsize_t, not size_t, since that's what the TIFF API wants.
5308 (tiff_read_from_memory): Don't fail simply because the read would
5309 go past EOF; instead, return a short read.
5310 (tiff_load): Omit no-longer-needed casts.
5311 (Fimagemagick_types): Don't assume size fits into 'int'.
5312
3cc5a532
PE
5313 Improve hashing quality when configured --with-wide-int.
5314 * fns.c (hash_string): New function, taken from sxhash_string.
5315 Do not discard information about ASCII character case; this
5316 discarding is no longer needed.
5317 (sxhash-string): Use it. Change sig to match it. Caller changed.
5318 * lisp.h: Declare it.
5319 * lread.c (hash_string): Remove, since we now use fns.c's version.
5320 The fns.c version returns a wider integer if --with-wide-int is
5321 specified, so this should help the quality of the hashing a bit.
5322
b312a492
PE
5323 * emacs.c: Integer overflow minor fix.
5324 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5325 Define only if GNU_LINUX.
5326 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5327
dfd153ae
PE
5328 * dispnew.c: Integer signedness and overflow fixes.
5329 Remove unnecessary forward decls, that were a maintenance hassle.
5330 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5331 All uses changed.
5332 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5333 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5334 (prepare_desired_row, line_draw_cost):
5335 Use int, not unsigned, where either works.
5336 (save_current_matrix, restore_current_matrix):
5337 Use ptrdiff_t, not size_t, where either works.
5338 (init_display): Check for overflow more accurately, and without
5339 relying on undefined behavior.
5340
a81d11a3
PE
5341 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5342 Remove, replacing with the new symbols in lisp.h. All uses changed.
5343 * fileio.c (make_temp_name):
5344 * filelock.c (lock_file_1, lock_file):
5345 * xdisp.c (message_dolog):
5346 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5347 Use pMd etc. instead.
5348 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5349 replacing the pWIDE etc. symbols removed from editfns.c.
5350
3300e6fd
PE
5351 * keyboard.h (num_input_events): Now uintmax_t.
5352 This is (very slightly) less likely to mess up due to wraparound.
5353 All uses changed.
5354
fd05c7e9
PE
5355 * buffer.c: Integer signedness fixes.
5356 (alloc_buffer_text, enlarge_buffer_text):
5357 Use ptrdiff_t rather than size_t when either will do, as we prefer
5358 signed integers.
5359
903fe15d
PE
5360 * alloc.c: Integer signedness and overflow fixes.
5361 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5362 (__malloc_size_t): Default to size_t, not to int.
5363 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5364 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5365 Prefer ptrdiff_t to size_t when either would do, as we prefer
5366 signed integers.
5367 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5368 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5369 Now const. Initialize with values that are in range even if char
5370 is signed.
5371 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5372 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5373 These functions do the right thing with sizes > 2**32.
5374 (check_depth): Now ptrdiff_t, not int.
5375 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5376 Adjust to new way of storing sizes. Check for size overflow bugs
5377 in rest of code.
5378 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5379 slightly wrong anyway, as it missed one instance of
5380 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5381 (refill_memory_reserve): Omit needless cast to size_t.
5382 (mark_object_loop_halt): Mark as externally visible.
5383
ac82cc6a
PE
5384 * xselect.c: Integer signedness and overflow fixes.
5385 (Fx_register_dnd_atom, x_handle_dnd_message):
5386 Use ptrdiff_t, not size_t, since we prefer signed.
5387 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5388 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5389 x_dnd_atoms_size and x_dnd_atoms_length.
5390
c2d1e36d
PE
5391 * doprnt.c: Prefer signed to unsigned when either works.
5392 * eval.c (verror):
5393 * doprnt.c (doprnt):
5394 * lisp.h (doprnt):
5395 * xdisp.c (vmessage):
5396 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5397 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5398 prefer signed arithmetic to avoid comparison confusion.
5399 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5400 but is a bit tricky.
5401
0e926e56
PE
5402 Assume freestanding C89 headers, string.h, stdlib.h.
5403 * data.c, doprnt.c, floatfns.c, print.c:
5404 Include float.h unconditionally.
5405 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5406 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5407 * regex.c: Likewise for stddef.h, string.h.
5408 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5409 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5410 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5411 (STDC_HEADERS): Remove obsolete defines.
5412 * sysdep.c: Include limits.h unconditionally.
5413
9cfdb3ec
PE
5414 Assume support for memcmp, memcpy, memmove, memset.
5415 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5416 * regex.c (memcmp, memcpy):
5417 Remove; we assume C89 now.
5418
5419 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5420 (__malloc_safe_bcopy): Remove; no longer needed.
5421
cf950e6b 5422 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5423 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5424 well either way, and we prefer signed to unsigned.
5425
dbf38e02
LMI
54262011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5427
5428 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5429 closes the connection while we're reading (bug#9182).
5430
d6f0886c 54312011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5432
d6f0886c
JD
5433 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5434 are specified (Bug#9168).
24e0f6b1 5435
2eb1f9e6
PE
54362011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5437
5438 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5439 Found by GCC static checking and --with-wide-int on a 32-bit host.
5440
22381272 54412011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5442
5443 * xdisp.c (compute_display_string_pos): Fix logic of caching
5444 previous display string position. Initialize cached_prev_pos to
5445 -1. Fixes slow-down at the beginning of a buffer.
5446
f25e39b4
EZ
54472011-07-24 Eli Zaretskii <eliz@gnu.org>
5448
5449 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5450 for attrs[LFACE_FONTSET_INDEX].
5451
04c4b52e
PE
54522011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5453
5454 * xml.c (parse_region): Remove unused local
5455 that was recently introduced.
5456
c1734fbd
EZ
54572011-07-23 Eli Zaretskii <eliz@gnu.org>
5458
be18c5a5
EZ
5459 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5460 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5461
c1734fbd
EZ
5462 * xdisp.c (move_it_in_display_line_to): Record the best matching
5463 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5464 exit if none of the characters scanned was an exact match.
5465 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5466 when exact match is impossible due to invisible text, and the
5467 lines are truncated.
5468
a258d627
JD
54692011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5470
5471 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5472 for OSX >= 10.7.
5473
b6d5a689
EZ
54742011-07-22 Eli Zaretskii <eliz@gnu.org>
5475
0f74f785
EZ
5476 Fix a significant slow-down of cursor motion with C-n, C-p,
5477 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5478 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5479 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5480 (next_element_from_buffer): Call compute_stop_pos_backwards to
5481 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5482 base_level_stop.
5483 (reseat): Don't look for prev_stop, as that could mean a very long
5484 run.
5485 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5486 <cached_disp_overlay_modiff>: Cache for last found display string
5487 position.
551918c1 5488 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5489 about the same buffer in the same area of character positions, and
5490 the buffer wasn't changed since the time the display string
5491 position was cached.
551918c1 5492
b2d0c91a
EZ
54932011-07-22 Eli Zaretskii <eliz@gnu.org>
5494
5495 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5496 is an integer, which is important for empty lines. (Bug#9149)
5497
043604ee
CY
54982011-07-22 Chong Yidong <cyd@stupidchicken.com>
5499
5500 * frame.c (Fmodify_frame_parameters): In tty case, update the
5501 default face if necessary (Bug#4238).
5502
da4adb04
CY
55032011-07-21 Chong Yidong <cyd@stupidchicken.com>
5504
5505 * editfns.c (Fstring_to_char): No need to explain what a character
5506 is in the docstring (Bug#6576).
5507
9abd0532
LMI
55082011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5509
5510 * xml.c (parse_region): Make sure we always return a tree.
5511
36881d16
HK
55122011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5513
5514 * xml.c (parse_region): If a document contains only comments,
5515 return that, too.
5516
1e98674d
LMI
55172011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5518
5519 * xml.c (make_dom): Return comments, too.
5520
590bd467
PE
55212011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5522
5523 Port to OpenBSD.
5524 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5525 and the surrounding thread.
5526 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5527 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5528 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5529 timer goes off.
5530 * s/openbsd.h (BROKEN_SIGIO): Define.
5531 * unexelf.c (unexec) [__OpenBSD__]:
5532 Don't update the .mdebug section of the Alpha COFF symbol table.
5533
f41628b2
LMI
55342011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5535
5536 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5537 (bug#8460).
5538
b59b67c5
PE
55392011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5540
15e3a074
PE
5541 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5542 This fixes some race conditions on the permissions of any newly
5543 created file.
5544
41bed37d
PE
5545 * alloc.c (valid_pointer_p): Use pipe, not open.
5546 This fixes some permissions issues when debugging.
5547
b59b67c5
PE
5548 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5549 If fchown fails to set both uid and gid, try to set just gid,
5550 as that is sometimes allowed. Adjust the file's mode to eliminate
5551 setuid or setgid bits that are inappropriate if fchown fails.
5552
925a6be7
SM
55532011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5554
5555 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5556 to compare Lisp_Objects.
5557 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5558 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5559 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5560
52968808
AS
55612011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5562
0a6a104b
AS
5563 * lread.c (read_integer): Unread even EOF character.
5564 (read1): Likewise. Properly record start position of symbol.
5565
52968808
AS
5566 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5567 symbol character follows.
5568
9e381cdd
PE
55692011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5570
5571 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5572 This works around a problem with the previous change to Fcopy_file.
5573 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5574 and without this change, GCC might complain about discarding
5575 fchown's return value.
5576
b5641435
JB
55772011-07-16 Juanma Barranquero <lekktu@gmail.com>
5578
5579 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5580
a8031457
PE
55812011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5584
dd889327
LMI
55852011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5586
750c33f7
LMI
5587 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5588 it's used from the C level.
5589
dd889327
LMI
5590 * process.c: Use the same condition for POLL_FOR_INPUT in both
5591 keyboard.c and process.c (bug#1858).
5592
87e86684
LM
55932011-07-09 Lawrence Mitchell <wence@gmx.li>
5594
5595 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5596 (Fgnutls_boot): Use it.
5597
64348f40
AS
55982011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5599
5600 * doc.c (Fsubstitute_command_keys): Revert last change.
5601
1d698799
LMI
56022011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5603
f863868c
LMI
5604 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5605 quotes the next character, and doesn't affect other longer
5606 sequences (bug#8935).
5607
1d698799
LMI
5608 * lread.c (syms_of_lread): Clarify that is isn't only
5609 `eval-buffer' and `eval-defun' that's affected by
5610 `lexical-binding' (bug#8460).
5611
aa4b6df6
EZ
56122011-07-15 Eli Zaretskii <eliz@gnu.org>
5613
5614 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5615 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5616
5d856da6
PE
56172011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5618
ad6042bb
PE
5619 Fix minor problems found by static checking.
5620 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5621 (elsz): Now a signed constant, not a size_t var. We prefer signed
5622 types to unsigned, to avoid integer comparison confusion. Without
5623 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5624 "cannot optimize loop, the loop counter may overflow", a symptom
5625 of the confusion.
f00bbb22 5626 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5627 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5628
6468f31c
LMI
56292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5630
49080b10
LMI
5631 * search.c (Fre_search_backward): Mention `case-fold-search' in
5632 all the re_search_* functions (bug#8138).
5633
6468f31c
LMI
5634 * keyboard.c (Fopen_dribble_file): Document when the file is
5635 closed (bug#8056).
5636
c965adc5
EZ
56372011-07-14 Eli Zaretskii <eliz@gnu.org>
5638
df9733bf
EZ
5639 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5640 bidi_cache_idx.
5641
0bb23927
EZ
5642 Support bidi reordering of display and overlay strings.
5643 * xdisp.c (compute_display_string_pos)
5644 (compute_display_string_end): Accept additional argument STRING.
5645 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5646 (reseat_to_string): Initialize bidi_it->string.s and
5647 bidi_it->string.schars.
5648 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5649 NULL (avoids a crash in bidi_paragraph_init).
5650 Initialize itb.string.lstring.
0bb23927
EZ
5651 (init_iterator): Call bidi_init_it only of a valid
5652 buffer position was specified. Initialize paragraph_embedding to
5653 L2R.
5654 (reseat_to_string): Initialize the bidi iterator.
5655 (display_string): If we need to ignore text properties of
5656 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5657 original value of -1 will not work with bidi.)
5658 (compute_display_string_pos): First arg is now struct
5659 `text_pos *'; all callers changed. Support display properties on
5660 Lisp strings.
5661 (compute_display_string_end): Support display properties on Lisp
5662 strings.
5663 (init_iterator, reseat_1, reseat_to_string): Initialize the
5664 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5665 when iterating on a string not from display properties).
640c8776
SM
5666 (compute_display_string_pos, compute_display_string_end):
5667 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5668 arrow keys.
5669 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5670 base_level_stop; instead, set base_level_stop to BEGV.
5671 Fixes crashes in vertical-motion.
0bb23927
EZ
5672 (next_element_from_buffer): Improve commentary for when
5673 the iterator is before prev_stop.
5674 (init_iterator): Initialize bidi_p from the default value of
5675 bidi-display-reordering, not from buffer-local value. Use the
5676 buffer-local value only if initializing for buffer iteration.
5677 (handle_invisible_prop): Support invisible properties on strings
5678 that are being bidi-reordered.
5679 (set_iterator_to_next): Support bidi reordering of C strings and
5680 Lisp strings.
5681 (next_element_from_string): Support bidi reordering of Lisp
5682 strings.
5683 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5684 (display_string): Support display of R2L glyph rows.
5685 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5686 (init_iterator): Don't initialize it->bidi_p for strings
5687 here.
5688 (reseat_to_string): Initialize it->bidi_p for strings here.
5689 (next_element_from_string, next_element_from_c_string)
5690 (next_element_from_buffer): Add xassert's for correspondence
5691 between IT's object being iterated and it->bidi_it.string
5692 structure.
5693 (face_before_or_after_it_pos): Support bidi iteration.
5694 (next_element_from_c_string): Handle the case of the first string
5695 character that is not the first one in the visual order.
5696 (get_visually_first_element): New function, refactored from common
5697 parts of next_element_from_buffer, next_element_from_string, and
5698 next_element_from_c_string.
5699 (tool_bar_lines_needed, redisplay_tool_bar)
5700 (display_menu_bar): Force left-to-right direction. Add a FIXME
5701 comment for making that be controlled by a user option.
5702 (push_it, pop_it): Save and restore the state of the
5703 bidi iterator. Save and restore the bidi_p flag.
5704 (pop_it): Iterate out of display property for string iteration as
5705 well.
5706 (iterate_out_of_display_property): Support iteration over strings.
5707 (handle_single_display_spec): Set up it->bidi_it for iteration
5708 over a display string, and call bidi_init_it.
5709 (handle_single_display_spec, next_overlay_string)
5710 (get_overlay_strings_1, push_display_prop): Set up the bidi
5711 iterator for displaying display or overlay strings.
5712 (forward_to_next_line_start): Don't use the shortcut if
5713 bidi-iterating.
5714 (back_to_previous_visible_line_start): If handle_display_prop
5715 pushed the iterator stack, restore the internal state of the bidi
5716 iterator by calling bidi_pop_it same number of times.
5717 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5718 and we are bidi-iterating, don't decrement the iterator position;
5719 instead, set the first_elt flag in the bidi iterator, to produce
5720 the same effect.
5721 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5722 (push_display_prop): xassert that we are iterating a buffer.
5723 (push_it, pop_it): Save and restore paragraph_embedding member.
5724 (handle_single_display_spec, next_overlay_string)
5725 (get_overlay_strings_1, reseat_1, reseat_to_string)
5726 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5727 correctly. Don't assume unibyte strings are not bidi-reordered.
5728 (compute_display_string_pos)
5729 (compute_display_string_end): Fix handling the case of C string.
5730 (push_it, pop_it): Save and restore from_disp_prop_p.
5731 (handle_single_display_spec, push_display_prop): Set the
5732 from_disp_prop_p flag.
5733 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5734 (pop_it): Call iterate_out_of_display_property only if we are
5735 popping after iteration over a string that came from a display
5736 property. Fix a typo in popping stretch info. Add an assertion
5737 for verifying that the iterator position is in sync with the bidi
5738 iterator.
5739 (handle_single_display_spec, get_overlay_strings_1)
5740 (push_display_prop): Fix initialization of paragraph direction for
5741 string when that of the parent object is not yet determined.
5742 (reseat_1): Call bidi_init_it to resync the bidi
5743 iterator with IT's position. (Bug#7616)
5744 (find_row_edges): If ROW->start.pos gives position
5745 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5746 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5747 Reset the from_disp_prop_p flag.
5748 (SAVE_IT, RESTORE_IT): New macros.
5749 (pos_visible_p, face_before_or_after_it_pos)
5750 (back_to_previous_visible_line_start)
5751 (move_it_in_display_line_to, move_it_in_display_line)
5752 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5753 (try_scrolling, redisplay_window, display_line): Use them when
5754 saving a temporary copy of the iterator and restoring it back.
5755 (back_to_previous_visible_line_start, reseat_1)
5756 (init_iterator): Empty the bidi cache "stack".
5757 (move_it_in_display_line_to): If iterator ended up at
5758 EOL, but we never saw any buffer positions smaller than
5759 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5760 motion in bidi-reordered lines.
5761 (move_it_in_display_line_to): Record prev_method and prev_pos
5762 immediately before the call to set_iterator_to_next. Fixes cursor
5763 motion in bidi-reordered lines with stretch glyphs and strings
5764 displayed in margins. (Bug#8133) (Bug#8867)
5765 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5766 TO_CHARPOS.
640c8776
SM
5767 (pos_visible_p): Support positions in bidi-reordered lines.
5768 Save and restore bidi cache.
0bb23927
EZ
5769
5770 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5771 (bidi_paragraph_info): Delete unused struct.
5772 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5773 (bidi_cache_start): New variable.
5774 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5775 to zero.
5776 (bidi_cache_fetch_state, bidi_cache_search)
5777 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5778 (bidi_cache_find, bidi_peek_at_next_level)
5779 (bidi_level_of_next_char, bidi_find_other_level_edge)
5780 (bidi_move_to_visually_next): Compare cache index with
5781 bidi_cache_start rather than with zero.
5782 (bidi_fetch_char): Accept new argument STRING; all callers
5783 changed. Support iteration over a string. Support strings with
5784 display properties. Support unibyte strings. Fix the type of
5785 `len' according to what STRING_CHAR_AND_LENGTH expects.
5786 (bidi_paragraph_init, bidi_resolve_explicit_1)
5787 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
5788 (bidi_level_of_next_char, bidi_move_to_visually_next):
5789 Support iteration over a string.
0bb23927
EZ
5790 (bidi_set_sor_type, bidi_resolve_explicit_1)
5791 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5792 can now be zero (for strings); special values 0 and -1 were
5793 changed to -1 and -2, respectively.
5794 (bidi_char_at_pos): New function.
5795 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5796 Call it instead of FETCH_MULTIBYTE_CHAR.
5797 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5798 initialized to valid values.
5799 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5800 values.
5801 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5802 the test for valid cached positions. Fix the logic for looking up
5803 the sentinel state in the cache. GCPRO the Lisp string we are
5804 iterating.
5805 (bidi_push_it, bidi_pop_it): New functions.
5806 (bidi_initialize): Initialize the bidi cache start stack pointer.
5807 (bidi_cache_ensure_space): New function, refactored from part of
5808 bidi_cache_iterator_state. Don't assume the required size is just
5809 one BIDI_CACHE_CHUNK away.
5810 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5811 (bidi_count_bytes, bidi_char_at_pos): New functions.
5812 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5813 always valid if bidi_cache_idx is valid.
5814 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5815 is valid if it's going to be used.
5816 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5817 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
5818 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5819 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
5820 (bidi_find_other_level_edge, bidi_cache_start_stack):
5821 All variables related to cache indices are now EMACS_INT.
c965adc5 5822
0bb23927
EZ
5823 * dispextern.h (struct bidi_string_data): New structure.
5824 (struct bidi_it): New member `string'. Make flag members be 1-bit
5825 fields, and put them last in the struct.
640c8776
SM
5826 (compute_display_string_pos, compute_display_string_end):
5827 Update prototypes.
0bb23927
EZ
5828 (bidi_push_it, bidi_pop_it): Add prototypes.
5829 (struct iterator_stack_entry): New members bidi_p,
5830 paragraph_embedding, and from_disp_prop_p.
5831 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
5832 (bidi_shelve_cache, bidi_unshelve_cache):
5833 Declare prototypes.
0bb23927
EZ
5834
5835 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5836 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5837 and vector-like objects.
5838
5839 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5840 cache around display iteration.
5841
5842 * window.c (Fwindow_end, window_scroll_pixel_based)
5843 (displayed_window_lines, Frecenter): Save and restore the bidi
5844 cache around display iteration.
5845
3bbd2265
LMI
58462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5847
5848 * editfns.c (Fdelete_region): Clarify the use of the named
5849 parameters (bug#6788).
5850
adc47434
MR
58512011-07-14 Martin Rudalics <rudalics@gmx.at>
5852
5853 * indent.c (Fvertical_motion): Set and restore w->pointm when
5854 saving and restoring the window's buffer (Bug#9006).
5855
837c31f8
LMI
58562011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5857
5858 * editfns.c (Fstring_to_char): Clarify just what is returned
5859 (bug#6576). Text by Eli Zaretskii.
5860
ac389d0c
JB
58612011-07-13 Juanma Barranquero <lekktu@gmail.com>
5862
5863 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5864
0be0ce47
EZ
58652011-07-13 Eli Zaretskii <eliz@gnu.org>
5866
5867 * buffer.c (mmap_find): Fix a typo.
5868
cd18e7e3
JB
58692011-07-13 Johan Bockgård <bojohan@gnu.org>
5870
5871 Fix execution of x selection hooks.
5872 * xselect.c (Qx_lost_selection_functions)
5873 (Qx_sent_selection_functions): New vars.
5874 (syms_of_xselect): DEFSYM them.
5875 (x_handle_selection_request): Pass Qx_sent_selection_functions
5876 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5877 (x_handle_selection_clear,x_clear_frame_selections):
5878 Pass Qx_lost_selection_functions rather than
5879 Vx_lost_selection_functions to Frun_hook_with_args.
5880
47ea7f44
PE
58812011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5882
ac389d0c 5883 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
5884 The old code sometimes used this field without initializing it.
5885
47ea7f44
PE
5886 * alloc.c (gc_sweep): Don't read past end of array.
5887 In theory, the old code could also have corrupted Emacs internals,
5888 though it'd be very unlikely.
5889
bc985c87
AS
58902011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5891
5892 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 5893 argument. (Bug#4026)
bc985c87 5894
0cf34688
LMI
58952011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5896
b3dadd76
LMI
5897 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5898 key" (bug#4257).
5899
0cf34688
LMI
5900 * window.c (Fset_window_start): Doc fix (bug#4199).
5901 (Fset_window_hscroll): Ditto.
5902
270768cd
PE
59032011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5904
077e3dda 5905 Fix minor new problems caught by GCC 4.6.1.
270768cd 5906 * term.c (init_tty): Remove unused local.
490011a6 5907 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 5908 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 5909 not used otherwise.
270768cd 5910
b1f58454
CY
59112011-07-12 Chong Yidong <cyd@stupidchicken.com>
5912
5913 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5914
22b9578d
LMI
59152011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5916
6e70ab07
LMI
5917 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5918 are the mini-buffer and the echo area (bug#3320).
5919
22b9578d
LMI
5920 * term.c (init_tty): Remove support for supdup, c10 and perq
5921 terminals, which are no longer supported (bug#1482).
5922
8974cc9f
JB
59232011-07-10 Johan Bockgård <bojohan@gnu.org>
5924
5925 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5926
a560d974
JD
59272011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5928
5929 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5930 for non-popups (Bug#3642).
5931
1dae0f0a
AS
59322011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5933
268c2c36 5934 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 5935 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
5936 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5937 * cm.c (losecursor): Likewise.
1dae0f0a
AS
5938 * data.c (fmod): Likewise.
5939 * dispnew.c (swap_glyphs_in_rows): Likewise.
5940 * emacs.c (memory_warning_signal): Likewise.
5941 * floatfns.c (float_error): Likewise.
5942 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5943 (otf_open, font_otf_capability, generate_otf_features)
5944 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5945 Likewise.
5946 * image.c (pbm_read_file): Likewise.
5947 * indent.c (string_display_width): Likewise.
5948 * intervals.c (check_for_interval, search_for_interval)
5949 (inc_interval_count, count_intervals, root_interval)
5950 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5951 * lread.c (defalias): Likewise.
268c2c36 5952 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
5953 * regex.c (set_image_of_range_1, set_image_of_range)
5954 (regex_grow_registers): Likewise.
5955 * sysdep.c (strerror): Likewise.
5956 * termcap.c (valid_filename_p, tprint, main): Likewise.
5957 * tparam.c (main): Likewise.
5958 * unexhp9k800.c (run_time_remap, save_data_space)
5959 (update_file_ptrs, read_header, write_header, calculate_checksum)
5960 (copy_file, copy_rest, display_header): Likewise.
5961 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5962 Likewise.
5963 * xdisp.c (check_it): Likewise.
5964 * xfaces.c (register_color, unregister_color, unregister_colors):
5965 Likewise.
5966 * xfns.c (print_fontset_result): Likewise.
5967 * xrdb.c (member, fatal, main): Likewise.
5968
99033785
PE
59692011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5970
5971 Fix minor problems found by static checking (Bug#9031).
5972 * chartab.c (char_table_set_range, map_sub_char_table):
5973 Remove unused locals.
5974 (uniprop_table): Now static.
5975 * composite.c (_work_char): Remove unused static var.
5976
9cb2ac56
JB
59772011-07-09 Juanma Barranquero <lekktu@gmail.com>
5978
5979 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5980
f25661f0
JD
59812011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5982
5983 * gtkutil.c (qttip_cb): Remove code without function.
5984
8278c4fe
EZ
59852011-07-09 Eli Zaretskii <eliz@gnu.org>
5986
5987 * w32.c (pthread_sigmask): New stub.
5988
1692ae2d 59892011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 5990
8a6ebd58 5991 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
5992 sigprocmask is portable only for single-threaded applications, and
5993 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
5994 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5995 (LIBES): Use it.
5996 * callproc.c (Fcall_process):
5997 * process.c (create_process):
5998 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5999 Use pthread_sigmask, not sigprocmask.
123403e4 6000
1b854618
JD
60012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6002
6003 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6004 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6005 wrong (Bug#8591).
6006
3fe4b549
JD
60072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6008
0ce7e563
JD
6009 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6010 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6011 (xg_hide_tooltip): Fix comment.
6012
3fe4b549
JD
6013 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6014 in registerServicesMenuSendTypes.
6015 (validRequestorForSendType): Don't check ns_return_types.
6016
6017 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6018 ns_return_type.
6019
5df75e47
JR
60202011-07-08 Jason Rumney <jasonr@gnu.org>
6021
22610910
JR
6022 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6023 SH_SHOW for hidden windows (Bug#5482).
6024
5df75e47
JR
6025 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6026 frame struct members of non-existent frames (Bug#6284).
6027
699c10bd
JD
60282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6029
4393663b
JD
6030 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6031 variable firstTime not needed on OSX >= 10.6.
6032 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6033 >= 10.5. Use setKnobProportion, setDoubleValue.
6034
6035 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6036 (MAC_OS_X_VERSION_10_5): Define if not defined.
6037 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6038 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6039 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6040
6041 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6042 cString and lossyCString on OSX >= 10.4
6043
58179cce 6044 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6045 sizeToFit on OSX >= 10.2.
6046
6047 * nsimage.m (allocInitFromFile): Don't use deprecated method
6048 bestRepresentationForDevice on OSX >= 10.6.
6049
6050 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6051 to avoid warning.
6052
6053 * emacs.c: Declare unexec_init_emacs_zone.
6054
a63e0781
JD
6055 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6056
699c10bd
JD
6057 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6058
6059 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6060 on svcsMenu (Bug#8842).
6061
6062 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6063 ns_return_types.
6064 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6065
6066 * nsterm.m (QUTF8_STRING): Declare.
6067 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6068 (validRequestorForSendType): Return type is (id).
6069 Change indexOfObjectIdenticalTo to indexOfObject.
6070 Check if we have local selection before returning self (Bug#8842).
6071 (writeSelectionToPasteboard): Put local selection into paste board
6072 if we have a local selection (Bug#8842).
6073 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6074
6075 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6076 (ns_get_local_selection): Declare.
6077
54e10184
LMI
60782011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6079
9888ff71
LMI
6080 * keymap.c (describe_map_tree): Don't insert a double newline at
6081 the end of the buffer (bug#1169) and return whether we inserted
6082 something.
6083
54e10184
LMI
6084 * callint.c (Fcall_interactively): Change "reading args" to
6085 "providing args" to try to clarify what it does (bug#1010).
6086
15fa4783
KH
60872011-07-07 Kenichi Handa <handa@m17n.org>
6088
6089 * composite.c (composition_compute_stop_pos): Ignore a static
6090 composition starting before CHARPOS (Bug#8915).
6091
6092 * xdisp.c (handle_composition_prop): Likewise.
6093
a8815b00
EZ
60942011-07-07 Eli Zaretskii <eliz@gnu.org>
6095
6096 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6097 (Bug#9015)
6098
ef7b981d 60992011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6100
6101 * character.h (unicode_category_t): New enum type.
6102
6103 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6104 (Qchar_code_property_table): New variable.
6105 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6106 (UNIPROP_COMPRESSED_FORM_P): New macros.
6107 (char_table_ascii): Uncompress the compressed values.
6108 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6109 Uncompress the compressed values.
ac389d0c 6110 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6111 (char_table_ref_and_range): Uncompress the compressed values.
6112 (sub_char_table_set): New arg is_uniprop. Callers changed.
6113 Uncompress the compressed values.
6114 (sub_char_table_set_range): Args changed. Callers changed.
6115 (char_table_set_range): Adjuted for the above change.
6116 (map_sub_char_table): Delete args default_val and parent. Add arg
6117 top. Give decoded values to a Lisp function.
640c8776 6118 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6119 values to a Lisp function. Gcpro more variables.
6120 (uniprop_table_uncompress)
6121 (uniprop_decode_value_run_length): New functions.
6122 (uniprop_decoder, uniprop_decoder_count): New variables.
6123 (uniprop_get_decoder, uniprop_encode_value_character)
6124 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6125 New functions.
6126 (uniprop_encoder, uniprop_encoder_count): New variables.
6127 (uniprop_get_encoder, uniprop_table)
6128 (Funicode_property_table_internal, Fget_unicode_property_internal)
6129 (Fput_unicode_property_internal): New functions.
6130 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6131 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6132 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6133 char-code-property-alist.
6134
640c8776 6135 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6136 Vunicode_category_table.
6137
640c8776 6138 * font.c (font_range): Adjust for the change of
c805dec0
KH
6139 Vunicode_category_table.
6140
76b397fb
DN
61412011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6142
6143 * m/iris4d.h: Remove file, move contents ...
6144 * s/irix6-5.h: ... here.
6145
22b4128e
PE
61462011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6147
6148 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6149 * alloc.c (mark_buffer):
6150 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6151 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6152 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6153 This isn't true in general, and it's particularly not true
6154 if Emacs is configured with --with-wide-int.
6155 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6156 New macros, used in the buffer.c change.
6157
869795d6
JD
61582011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6159
6160 * xsettings.c: Use both GConf and GSettings if both are available.
6161 (store_config_changed_event): Add comment.
6162 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6163 (store_tool_bar_style_changed): New functions.
5e617bc2 6164 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6165 (struct xsettings): Move font inside HAVE_XFT.
6166 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6167 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6168 Move inside HAVE_XFT.
640c8776 6169 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6170 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6171 also.
6172 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6173 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6174 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6175 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6176 (parse_settings): Move check for font inside HAVE_XFT.
6177 (read_settings, apply_xft_settings): Add comment.
6178 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6179 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6180 call store_font_name_changed.
6181 (xft_settings_event): Add comment.
6182 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6183 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6184 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6185 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6186 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6187 (xsettings_get_system_font, xsettings_get_system_normal_font):
6188 Add comment.
869795d6 6189
d8ed26bd
PE
61902011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6191
6192 Random fixes. E.g., (random) never returned negative values.
6193 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6194 subseconds part to the entropy, as that's a bit more random.
6195 Prefer signed to unsigned, since the signedness doesn't matter and
6196 in general we prefer signed. When given a limit, use a
6197 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6198 latter isn't right if USE_2_TAGS_FOR_INTS.
6199 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6200 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6201
cabf1cac
SM
62022011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6203
6204 * textprop.c (text_property_stickiness):
6205 Obey Vtext_property_default_nonsticky.
6206 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6207 * w32fns.c (syms_of_w32fns):
6208 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6209
6e9b2be9
PE
62102011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6211
6212 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6213 This is more efficient than Ffile_directory_p and avoids a minor race.
6214
90186c68
LMI
62152011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6216
7c301272
LMI
6217 * buffer.c (Foverlay_put): Say what the return value is
6218 (bug#7835).
6219
c4f2d8d4
LMI
6220 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6221 is a directory before asking whether to use the file name
6222 (bug#7564).
ad637907
LMI
6223 (barf_or_query_if_file_exists): Make the "File is a directory"
6224 error be more correct.
c4f2d8d4 6225
90186c68
LMI
6226 * fns.c (Frequire): Remove the mention of the .gz files, since
6227 that's installation-specific, but keep the mention of
6228 `get-load-suffixes'.
6229
da64016e
PE
62302011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6231
6232 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6233 Report string overflow if the output is too long.
6234
7d47b580
JB
62352011-07-04 Juanma Barranquero <lekktu@gmail.com>
6236
a555cb87
JB
6237 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6238 (syms_of_gnutls): Remove duplicate DEFSYM for
6239 Qgnutls_bootprop_verify_hostname_error, an error for
6240 Qgnutls_bootprop_verify_error (which is no longer used).
6241
7d47b580
JB
6242 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6243 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6244 Also (re)move comments that are misplaced or no longer relevant.
6245
1e49bfab
LMI
62462011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6247
6248 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6249
1485f4c0
CY
62502011-07-03 Chong Yidong <cyd@stupidchicken.com>
6251
6252 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6253 and background color parameters if they have been changed.
6254
a9ab721e
LMI
62552011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6256
6257 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6258
cf7cff57
PE
62592011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6260
2e13213d
PE
6261 * xsettings.c (SYSTEM_FONT): Define only when used.
6262 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6263
cf7cff57
PE
6264 * keymap.c (access_keymap_1): Now static.
6265
7a8e04f7
CY
62662011-07-02 Chong Yidong <cyd@stupidchicken.com>
6267
6268 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6269 leave any prefix arg for the up event (Bug#1586).
6270
61352f62
LMI
62712011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6272
69bb1ef7
LMI
6273 * lread.c (syms_of_lread): Mention single symbols defined by
6274 `defvar' or `defconst' (bug#7154).
6275
61352f62 6276 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6277 (Frequire): Mention get-load-suffixes.
61352f62 6278
28545e04
MR
62792011-07-02 Martin Rudalics <rudalics@gmx.at>
6280
6281 * window.h (window): Remove clone_number slot.
6282 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6283 Remove.
6284 (make_parent_window, make_window, saved_window)
6285 (Fset_window_configuration, save_window_save): Don't deal with
6286 clone numbers.
6287 * buffer.c (Qclone_number): Remove declaration.
6288 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6289
3349e122
SM
62902011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6291
6292 Add multiple inheritance to keymaps.
6293 * keymap.c (Fmake_composed_keymap): New function.
6294 (Fset_keymap_parent): Simplify.
6295 (fix_submap_inheritance): Remove.
6296 (access_keymap_1): New function extracted from access_keymap to handle
6297 embedded parents and handle lists of maps.
6298 (access_keymap): Use it.
6299 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6300 (Fcopy_keymap): Handle embedded parents.
6301 (Fcommand_remapping, define_as_prefix): Simplify.
6302 (Fkey_binding): Simplify.
6303 (syms_of_keymap): Move minibuffer-local-completion-map,
6304 minibuffer-local-filename-completion-map,
6305 minibuffer-local-must-match-map, and
6306 minibuffer-local-filename-must-match-map to Elisp.
6307 (syms_of_keymap): Defsubr make-composed-keymap.
6308 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6309 (parse_menu_item): Trivial simplification.
6310
3279eb87
GM
63112011-07-01 Glenn Morris <rgm@gnu.org>
6312
6313 * Makefile.in (SETTINGS_LIBS): Fix typo.
6314
4550efdf
KI
63152011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6316
6317 * coding.c (Fencode_coding_string): Record the last coding system
6318 used, as the function doc string says (bug#8738).
6319
0949d2b6
JD
63202011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6321
6322 * xsettings.c (store_monospaced_changed): Take new font as arg and
6323 check for change against current_mono_font.
6324 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6325 (emacs_settings_constructor, emacs_settings_get_property)
6326 (emacs_settings_set_property, emacs_settings_class_init)
6327 (emacs_settings_init, gsettings_obj): Remove.
6328 (something_changedCB): New function for HAVE_GSETTINGS.
6329 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6330 with value as argument.
6331 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6332 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6333 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6334 "changed".
6335
6336 * xgselect.c: Add defined (HAVE_GSETTINGS).
6337 (xgselect_initialize): Ditto.
6338
6339 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6340 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6341 xg_select.
6342
bbc6b304
PE
63432011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6344
6345 * eval.c (struct backtrace): Simplify and port the data structure.
6346 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6347 signed bit field, as this assumption is not portable and it makes
6348 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6349 "char debug_on_exit : 1" as this is not portable either; instead,
6350 use the portable "unsigned int debug_on_exit : 1". Remove unused
6351 member evalargs. Remove obsolete comments about cc bombing out.
6352
9851bfc5
JD
63532011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6354
51bb811f 6355 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6356 Let HAVE_GSETTINGS override HAVE_GCONF.
6357 (store_monospaced_changed): New function.
6358 (EMACS_SETTINGS): A new type derived from GObject to handle
6359 GSettings notifications.
6360 (emacs_settings_constructor, emacs_settings_get_property)
6361 (emacs_settings_set_property, emacs_settings_class_init):
6362 New functions.
6363 (gsettings_client, gsettings_obj): New variables.
6364 (GSETTINGS_SCHEMA): New define.
6365 (something_changedCB): Call store_monospaced_changed.
6366 (init_gsettings): New function.
6367 (xsettings_initialize): Call init_gsettings.
6368 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6369 to NULL.
6370
640c8776 6371 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6372 GCONF_CFLAGS/LIBS.
6373
5386012d
MR
63742011-06-29 Martin Rudalics <rudalics@gmx.at>
6375
6376 * window.c (resize_root_window, grow_mini_window)
6377 (shrink_mini_window): Rename Qresize_root_window to
6378 Qwindow_resize_root_window and Qresize_root_window_vertically to
6379 Qwindow_resize_root_window_vertically.
6380
f13e0b08
PE
63812011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6382
6383 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6384
94515237
JB
63852011-06-27 Juanma Barranquero <lekktu@gmail.com>
6386
6387 * makefile.w32-in: Redesign dependencies so they reflect more
6388 clearly which files are directly included by each source file,
6389 and not through other includes.
6390
e43b6e43
MR
63912011-06-27 Martin Rudalics <rudalics@gmx.at>
6392
6393 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6394 (sort_overlays, overlay_strings): When an overlay's clone number
6395 matches the window's clone number process the overlay even if
6396 the overlay's window property doesn't match the current window.
6397
d68443dc
MR
6398 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6399 (Fwindow_hchild): Rename to Fwindow_left_child.
6400 (Fwindow_next): Rename to Fwindow_next_sibling.
6401 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6402 (resize_window_check): Rename to window_resize_check.
6403 (resize_window_apply): Rename to window_resize_apply.
6404 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6405 (Fdelete_other_windows_internal, resize_frame_windows)
6406 (Fsplit_window_internal, Fdelete_window_internal)
6407 (grow_mini_window, shrink_mini_window)
6408 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6409
c7e73be5
JD
64102011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6411
6412 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6413 (emacs_fixed_set_min_size): Remove.
6414 (emacs_fixed_new): Take frame as argument.
6415
6416 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6417 (_EmacsFixedPrivate): Remove minwidth/height.
6418 Add struct frame *f.
6419 (emacs_fixed_init): Initialize priv->f.
6420 (get_parent_class, emacs_fixed_set_min_size): Remove.
6421 (emacs_fixed_new): Set priv->f to argument.
6422 (emacs_fixed_get_preferred_width)
6423 (emacs_fixed_get_preferred_height): Use min_width/height from
6424 frames size_hint to set minimum and natural (Bug#8919).
6425 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6426 and use min_width/height from frames size_hint to set
6427 min_width/height (Bug#8919).
6428
6429 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6430 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6431 Fix indentation.
c7e73be5 6432
cf99dcf8
EZ
64332011-06-26 Eli Zaretskii <eliz@gnu.org>
6434
6435 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6436 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6437 called at ZV.
6438
029529ac
CY
64392011-06-26 Chong Yidong <cyd@stupidchicken.com>
6440
6441 * process.c (wait_reading_process_output): Bypass select if
6442 waiting for a cell while ignoring keyboard input, and input is
6443 pending. Suggested by Jan Djärv (Bug#8869).
6444
7a7ef429
PE
64452011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6446
6447 Use gnulib's dup2 module instead of rolling our own.
6448 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6449
11fdef7d 64502011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6451
6452 * dispnew.c (scrolling_window): Before scrolling, turn off a
6453 mouse-highlight in the window being scrolled.
6454
cd3520a4
JB
64552011-06-24 Juanma Barranquero <lekktu@gmail.com>
6456
6457 Move DEFSYM to lisp.h and use everywhere.
6458
6459 * character.h (DEFSYM): Move declaration...
6460 * lisp.h (DEFSYM): ...here.
6461
6462 * gnutls.c:
6463 * minibuf.c:
6464 * w32menu.c:
6465 * w32proc.c:
6466 * w32select.c: Don't include character.h.
6467
6468 * alloc.c (syms_of_alloc):
6469 * buffer.c (syms_of_buffer):
6470 * bytecode.c (syms_of_bytecode):
6471 * callint.c (syms_of_callint):
6472 * casefiddle.c (syms_of_casefiddle):
6473 * casetab.c (init_casetab_once):
6474 * category.c (init_category_once, syms_of_category):
6475 * ccl.c (syms_of_ccl):
6476 * cmds.c (syms_of_cmds):
6477 * composite.c (syms_of_composite):
6478 * dbusbind.c (syms_of_dbusbind):
6479 * dired.c (syms_of_dired):
6480 * dispnew.c (syms_of_display):
6481 * doc.c (syms_of_doc):
6482 * editfns.c (syms_of_editfns):
6483 * emacs.c (syms_of_emacs):
6484 * eval.c (syms_of_eval):
6485 * fileio.c (syms_of_fileio):
6486 * fns.c (syms_of_fns):
6487 * frame.c (syms_of_frame):
6488 * fringe.c (syms_of_fringe):
6489 * insdel.c (syms_of_insdel):
6490 * keymap.c (syms_of_keymap):
6491 * lread.c (init_obarray, syms_of_lread):
6492 * macros.c (syms_of_macros):
6493 * msdos.c (syms_of_msdos):
6494 * print.c (syms_of_print):
6495 * process.c (syms_of_process):
6496 * search.c (syms_of_search):
6497 * sound.c (syms_of_sound):
6498 * syntax.c (init_syntax_once, syms_of_syntax):
6499 * terminal.c (syms_of_terminal):
6500 * textprop.c (syms_of_textprop):
6501 * undo.c (syms_of_undo):
6502 * w32.c (globals_of_w32):
6503 * window.c (syms_of_window):
6504 * xdisp.c (syms_of_xdisp):
6505 * xfaces.c (syms_of_xfaces):
6506 * xfns.c (syms_of_xfns):
6507 * xmenu.c (syms_of_xmenu):
6508 * xsettings.c (syms_of_xsettings):
6509 * xterm.c (syms_of_xterm): Use DEFSYM.
6510
4228cf16
TZ
65112011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6512
cd3520a4 6513 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6514
7fcccf1e
PE
65152011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6516
7efb4e0e
PE
6517 Integer and buffer overflow fixes (Bug#8873).
6518
ff5844ad
PE
6519 * print.c (printchar, strout): Check for string overflow.
6520 (PRINTPREPARE, printchar, strout):
6521 Don't set size unless allocation succeeds.
6522
90532f02
PE
6523 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6524 for sizes. Check for string overflow more accurately.
6525 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6526
6d84508d
PE
6527 * macros.c: Integer and buffer overflow fixes.
6528 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6529 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6530 Use ptrdiff_t, not int, for sizes.
6531 Don't increment bufsize until after realloc succeeds.
6532 Check for size-calculation overflow.
6533 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6534
437b2cb4
PE
6535 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6536
8b9ac8b4
PE
6537 * lread.c: Integer overflow fixes.
6538 (read_integer): Radix is now EMACS_INT, not int,
6539 to improve quality of diagnostics for out-of-range radices.
6540 Calculate buffer size correctly for out-of-range radices.
6541 (read1): Check for integer overflow in radices, and in
6542 read-circle numbers.
82cb60d3
PE
6543 (read_escape): Avoid int overflow.
6544 (Fload, openp, read_buffer_size, read1)
6545 (substitute_object_recurse, read_vector, read_list, map_obarray):
6546 Use ptrdiff_t, not int, for sizes.
6547 (read1): Use EMACS_INT, not int, for sizes.
20270765 6548 Check for size overflow.
8b9ac8b4 6549
7fcccf1e
PE
6550 * image.c (cache_image): Check for size arithmetic overflow.
6551
bfbbd7e7
PE
6552 * lread.c: Integer overflow issues.
6553 (saved_doc_string_size, saved_doc_string_length)
6554 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6555 Now ptrdiff_t, not int.
6556 (read1): Don't assume doc string length fits in int. Check for
6557 out-of-range doc string lengths.
6558 (read_list): Don't assume file position fits in int.
39019e54 6559 (read_escape): Check for hex character overflow.
bfbbd7e7 6560
4e323265
LL
65612011-06-22 Leo Liu <sdl.web@gmail.com>
6562
6563 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6564 Move to minibuffer.el.
6565
85fece3e
PE
65662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6567
20b84ce9 6568 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6569 The following patches are for when GLYPH_DEBUG && !XASSERT.
6570 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6571 * dispnew.c (flush_stdout):
6572 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6573 Mark as externally visible.
6574 * dispnew.c (check_window_matrix_pointers): Now static.
6575 * dispnew.c (window_to_frame_vpos):
6576 * xfns.c (unwind_create_frame):
6577 * xterm.c (x_check_font): Remove unused local.
6578 * scroll.c (CHECK_BOUNDS):
6579 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6580 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6581 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6582 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6583 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6584 Now static.
6585 (debug_method_add): Use va_list and vsprintf rather than relying
6586 on undefined behavior with wrong number of arguments.
6587 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6588 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6589 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6590 since we're not interested in debugging glyphs with old libraries.
6591 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6592 GCC 4.6.0's static checking.
6593
0766b489
PE
65942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6595
31fd4b32
PE
6596 Integer overflow and signedness fixes (Bug#8873).
6597 A few related buffer overrun fixes, too.
6598
b79e8648
PE
6599 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6600
0766b489
PE
6601 * dispextern.h (struct face.stipple):
6602 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6603 (x_bitmap_mask, x_allocate_bitmap_record)
6604 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6605 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6606 (x_create_bitmap_from_xpm_data):
6607 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6608 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6609 (.bitmaps_last):
6610 * xfaces.c (load_pixmap):
6611 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6612 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6613 (.bitmaps_last, struct x_output.icon_bitmap):
6614 Use ptrdiff_t, not int, for bitmap indexes.
6615 (x_allocate_bitmap_record): Check for size overflow.
6616 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6617
b081724f
PE
6618 Use ptrdiff_t, not int, for overlay counts.
6619 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6620 * editfns.c (overlays_around, get_pos_property):
6621 * textprop.c (get_char_property_and_overlay):
6622 * xdisp.c (next_overlay_change, note_mouse_highlight):
6623 * xfaces.c (face_at_buffer_position):
21514da7
PE
6624 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6625 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6626 (Fnext_overlay_change, Fprevious_overlay_change)
6627 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6628 Use ptrdiff_t, not int, for sizes.
21514da7 6629 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6630
3de73e5e
PE
6631 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6632
2606c57b
PE
6633 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6634 (x_session_initialize): Do not assume string length fits in int.
6635
aaafe47a
PE
6636 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6637 This is unlikely, but can occur if DPI is outlandish.
6638
2674ddc8 6639 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6640 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6641
28154962
PE
6642 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6643 * xrdb.c (magic_file_p, search_magic_path):
6644 Omit last arg SUFFIX; it was always 0. All callers changed.
6645 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6646
7de51af5
PE
6647 * xfont.c (xfont_match): Avoid need for strlen.
6648
25ed6cc3
PE
6649 * xfns.c: Don't assume strlen fits in int.
6650 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6651
4eab31dd
PE
6652 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6653 not unsigned long, as we prefer signed integers. All callers changed.
6654 Detect integer overflow in repeat count.
6655 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6656 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6657
171e2a58
PE
6658 * termcap.c: Don't assume sizes fit in int and never overflow.
6659 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6660 (gobble_line): Check for size-calculation overflow.
6661
ad39faca 6662 * minibuf.c (Fread_buffer):
6e5bb2dc 6663 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6664 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6665 Don't assume string length fits in int.
6666
52c61c22 6667 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6668 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6669
b5b8c9e5
PE
6670 * font.c: Don't assume string length fits in int.
6671 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6672 Use ptrdiff_t, not int.
ccd6111c
PE
6673 (font_intern_prop): Don't assume string length fits in int.
6674 Don't assume integer property fits in fixnum.
6675 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6676
882f0d81 6677 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6678 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6679 Reformulate so as not to need the command string.
6680 Invoke gzip -cd rather than gunzip, as it's more portable.
6681 (lock_info_type, lock_file_1, lock_file):
6682 Don't assume pid_t and time_t fit in unsigned long.
6683 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6684 (current_lock_owner): Prefer signed type for sizes.
6685 Use memcpy, not strncpy, where memcpy is what is really wanted.
6686 Don't assume (via atoi) that time_t and pid_t fit in int.
6687 Check for time_t and/or pid_t out of range, e.g., via a network share.
6688 Don't alloca where an auto var works fine.
6689
93f4cf88
PE
6690 * fileio.c: Fix some integer overflow issues.
6691 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6692 Don't assume string length fits in int.
6693 (directory_file_name): Don't assume string length fits in long.
6694 (make_temp_name): Don't assume pid fits in int, or that its print
6695 length is less than 20.
6696
f3e92b69
PE
6697 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6698
1bfdaf10
PE
6699 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6700
35016e9a
PE
6701 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6702
3d1e65a1
PE
6703 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6704 We prefer signed integers, even for size calculations.
6705
0b963a93
PE
6706 * emacs.c: Don't assume string length fits in 'int'.
6707 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6708 (main): Don't invoke strlen when not needed.
6709
573f4b54
PE
6710 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6711 (XD_DEBUG_MESSAGE): Don't waste a byte.
6712
989f33ba
PE
6713 * callproc.c (getenv_internal_1, getenv_internal)
6714 (Fgetenv_internal):
965d34eb
PE
6715 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6716
e4d29b33
PE
6717 * lread.c (invalid_syntax): Omit length argument.
6718 All uses changed. This doesn't fix a bug, but it simplifies the
6719 code away from its former Hollerith-constant appearance, and it's
6720 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 6721 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 6722
eb49b136
PE
6723 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6724 This didn't break anything, but it didn't help either.
6725 It's confusing to put a bogus integer in a place where the actual
6726 value does not matter.
9f62aeb1 6727 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 6728 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 6729
15375a22
PE
6730 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6731 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6732 implementation.
b61cc01c
PE
6733 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6734 We prefer signed types, and the value cannot exceed the EMACS_INT
6735 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
6736 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6737 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6738 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 6739
53b2623d
PE
6740 * indent.c (sane_tab_width): New function.
6741 (current_column, scan_for_column, Findent_to, position_indentation)
6742 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 6743 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 6744
51cab52b 6745 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 6746
f2ed8a70
PE
6747 * lisp.h (lint_assume): New macro.
6748 * composite.c (composition_gstring_put_cache):
6749 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6750
abe80cc6
PE
6751 * editfns.c, insdel.c:
6752 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 6753
b02c740e
PE
6754 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6755
ebc96716
PE
6756 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6757
b4e50fa0 6758 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 6759 Use much-faster test for byte-length change.
311d5d7c 6760 Don't assume string byte-length fits in 'int'.
a4cf38e4 6761 Check that character arg fits in 'int'.
85461888 6762 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 6763
c0c1ee9f
PE
6764 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6765
a498d7f4
PE
6766 * fns.c (concat): Catch string overflow earlier.
6767 Do not rely on integer wraparound.
6768
51cab52b
PE
6769 * dispextern.h (struct it.overlay_strings_charpos)
6770 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
6771 * xdisp.c (forward_to_next_line_start)
6772 (back_to_previous_visible_line_start)
6773 (reseat_at_next_visible_line_start, next_element_from_buffer):
6774 Don't arbitrarily truncate the value of 'selective' to int.
6775
76031fad
PE
6776 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6777
5eb55db9
PE
6778 * composite.c: Don't truncate sizes to 'int'.
6779 (composition_gstring_p, composition_reseat_it)
6780 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
6781 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6782 not EMACS_UINT, for indexes.
5eb55db9 6783
0703a717
PE
6784 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6785
d6202519
PE
6786 * buffer.c: Include <verify.h>.
6787 (struct sortvec.priority, struct sortstr.priority):
8961a454 6788 Now EMACS_INT, not int.
c20998a7 6789 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
6790 (struct sortstr.size, record_overlay_string)
6791 (struct sortstrlist.size, struct sortlist.used):
6792 Don't truncate size to int.
6793 (record_overlay_string): Check for size-calculation overflow.
d6202519 6794 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 6795
d5a19415
JM
67962011-06-22 Jim Meyering <meyering@redhat.com>
6797
029529ac 6798 Don't leak an XBM-image-sized buffer
d5a19415
JM
6799 * image.c (xbm_load): Free the image buffer after using it.
6800
a9041e6c
PE
68012011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6802
6803 Port to Sun C.
6804 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6805 that Sun C diagnosed.
6806 * fns.c (secure_hash): Fix pointer signedness issue.
6807 * intervals.c (static_offset_intervals): New function.
6808 (offset_intervals): Use it.
6809
7f3f739f
LL
68102011-06-21 Leo Liu <sdl.web@gmail.com>
6811
6812 * deps.mk (fns.o):
6813 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6814 sha512.h.
6815
6816 * fns.c (secure_hash): Rename from crypto_hash_function and change
6817 the first arg to accept symbols.
5b66d427 6818 (Fsecure_hash): New primitive.
7f3f739f
LL
6819 (syms_of_fns): New symbols.
6820
76147d94
DD
68212011-06-20 Deniz Dogan <deniz@dogan.se>
6822
6823 * process.c (Fset_process_buffer): Clarify return value in
6824 docstring.
6825
7d7d0045
CY
68262011-06-18 Chong Yidong <cyd@stupidchicken.com>
6827
6828 * dispnew.c (add_window_display_history): Use BVAR.
6829
6830 * xdisp.c (debug_method_add): Use BVAR.
6831 (check_window_end, dump_glyph_matrix, dump_glyph)
6832 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6833
6834 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6835 Likewise.
6836
6837 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6838 check till after the cache is created in init_frame_faces.
6839
ff2bc410
SM
68402011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6841
6842 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6843
28177add
PE
68442011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6845
dd3482fe
PE
6846 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6847 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6848 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6849
393d71f3 6850 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
6851 * fileio.c (Finsert_file_contents):
6852 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6853 Remove the old (too-loose) buffer overflow checks.
6854 They weren't needed, since make_gap checks for buffer overflow.
6855 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6856 The old code merely checked for Emacs fixnum overflow, and relied
6857 on undefined (wraparound) behavior. The new code avoids undefined
6858 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6859
2e6813b0 6860 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
6861 Tune. Don't use wider integers than needed. Don't use alloca.
6862 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 6863
599a9e4f
PE
6864 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6865
99561444
PE
6866 * insdel.c, lisp.h (buffer_overflow): New function.
6867 (insert_from_buffer_1, replace_range, replace_range_2):
6868 * insdel.c (make_gap_larger):
6869 * editfns.c (Finsert_char):
6870 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6871
28177add
PE
6872 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6873
e69dafad
PE
68742011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6875
4baa020d 6876 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 6877
b1c46f02
PE
6878 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6879 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6880
e69dafad
PE
6881 * fileio.c: Don't assume EMACS_INT fits in off_t.
6882 (emacs_lseek): New static function.
6883 (Finsert_file_contents, Fwrite_region): Use it.
6884 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6885
566684ea
PE
6886 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6887
e6966cd6
PE
6888 * fns.c: Don't overflow int when computing a list length.
6889 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6890 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6891 truncation on 64-bit hosts. Check for QUIT every
6892 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6893 faster and is responsive enough.
6894 (Flength): Report an error instead of overflowing an integer.
6895 (Fsafe_length): Return a float if the value is not representable
6896 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 6897 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 6898 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 6899
dd0b0efb
PE
6900 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6901 (header_size, word_size): New constants.
6902 (allocate_vectorlike): Don't check size overflow here.
6903 (allocate_vector): Check it here instead, since this is the only
6904 caller of allocate_vectorlike that could cause overflow.
6905 Check that the new vector's length is representable as a fixnum.
6906
86fe5cfe
PE
6907 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6908 The previous code was bogus. For example, next_almost_prime (32)
6909 returned 39, which is undesirable as it is a multiple of 3; and
6910 next_almost_prime (24) returned 25, which is a multiple of 5 so
6911 why was the code bothering to check for multiples of 7?
6912
80e88859
PE
6913 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6914
4a2f0ad6
PE
6915 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6916
f66c7cf8
PE
6917 Variadic C functions now count arguments with ptrdiff_t.
6918 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6919 Back then I didn't know that the Emacs coding style prefers signed int.
6920 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
6921 were being counted with int, which may truncate counts on 64-bit
6922 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
6923 * lisp.h (struct Lisp_Subr.function.aMANY)
6924 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6925 Arg counts are now ptrdiff_t, not size_t.
6926 All variadic functions and their callers changed accordingly.
6927 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6928 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6929 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6930 * callint.c (Fcall_interactively): Check arg count for overflow,
6931 to avoid potential buffer overrun. Use signed char, not 'int',
6932 for 'varies' array, so that we needn't bother to check its size
6933 calculation for overflow.
6934 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6935 * eval.c (apply_lambda):
6936 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6937 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6938 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6939
a1759b76
PE
6940 * callint.c (Fcall_interactively): Don't use index var as event count.
6941
d96be9fc
PE
6942 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6943 * mem-limits.h (SIZE): Remove; no longer used.
6944
a690a978 6945 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 6946
578c21e6
PE
6947 Remove unnecessary casts.
6948 * xterm.c (x_term_init):
6949 * xfns.c (x_set_border_pixel):
6950 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6951 These aren't needed now that we assume ANSI C.
6952
96f53c6c
PE
6953 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6954 It's more likely to cause problems (due to unsigned overflow)
6955 than to cure them.
6956
83c77d31
PE
6957 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6958
ee2079f1
PE
6959 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6960
6da65536
PE
6961 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6962
7147c4a4
PE
6963 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6964
193e32d9
PE
6965 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6966
e5533da6
PE
6967 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6968
9910e595
PE
6969 GLYPH_CODE_FACE returns EMACS_INT, not int.
6970 * dispextern.h (merge_faces):
6971 * xfaces.c (merge_faces):
01103c44
PE
6972 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6973 Don't assume EMACS_INT fits in int.
9910e595 6974
2638320e
PE
6975 * character.h (CHAR_VALID_P): Remove unused parameter.
6976 * fontset.c, lisp.h, xdisp.c: All uses changed.
6977
045eb8d9
PE
6978 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6979
c1f134b5
PE
6980 * fns.c (concat): Minor tuning based on overflow analysis.
6981 This doesn't fix any bugs. Use int to hold character, instead
6982 of constantly refetching from Emacs object. Use XFASTINT, not
6983 XINT, for value known to be a character. Don't bother comparing
6984 a single byte to 0400, as it's always less.
6985
395fcb93 6986 * floatfns.c (Fexpt):
327eeec8
PE
6987 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6988
abbd3d23
PE
6989 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6990 for characters.
6991
684a03ef
PE
6992 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6993
0fed43f3
PE
6994 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6995 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6996 incorrectly succeed when S was a string, because 4294967386 was
6997 truncated before it was used.
6998
8fd02eb7
PE
6999 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7000 Otherwise, an out-of-range integer could cause undefined behavior
7001 on a 64-bit host.
7002
f8c86b69
PE
7003 * composite.c: Use int, not EMACS_INT, for characters.
7004 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7005 EMACS_INT, for values that are known to be in character range.
7006 This doesn't fix any bugs but is the usual style inside Emacs and
7007 may generate better code on 32-bit machines.
7008
34206dd2
PE
7009 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7010 This is for reasons similar to the recent CHAR_STRING fix.
7011 * charset.c (Fencode_char): Check that character arg is actually
7012 a character. Pass an int to ENCODE_CHAR.
7013 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7014 wider than 'int', as a compile-time check to prevent future regressions
7015 in this area.
7016
c5958d4c 7017 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7018
7019 Make sure a 64-bit char is never passed to CHAR_STRING.
7020 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7021 by silently ignoring the top 32 bits, allowing some values
7022 that were far too large to be valid characters.
7023 * character.h: Include <verify.h>.
7024 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7025 arguments are no wider than unsigned, as a compile-time check
7026 to prevent future regressions in this area.
7027 * data.c (Faset):
01103c44 7028 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7029 (Fsubst_char_in_region):
7030 * fns.c (concat):
7031 * xdisp.c (decode_mode_spec_coding):
7032 Adjust to CHAR_STRING's new requirement.
7033 * editfns.c (Finsert_char, Fsubst_char_in_region):
7034 * fns.c (concat): Check that character args are actually
7035 characters. Without this test, these functions did the wrong
7036 thing with wildly out-of-range values on 64-bit hosts.
7037
d37ca623
PE
7038 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7039 These casts should not be needed on 32-bit hosts, either.
7040 * keyboard.c (read_char):
7041 * lread.c (Fload): Remove casts to unsigned.
7042
ea204efb
PE
7043 * lisp.h (UNSIGNED_CMP): New macro.
7044 This fixes comparison bugs on 64-bit hosts.
7045 (ASCII_CHAR_P): Use it.
7046 * casefiddle.c (casify_object):
01103c44 7047 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7048 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7049 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7050 * dispextern.h (FACE_FROM_ID):
7051 * keyboard.c (read_char): Use UNSIGNED_CMP.
7052
41cb286c
PE
7053 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7054 not to EMACS_INT, to avoid GCC warning.
7055
4a1b9832
PE
7056 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7057
55daad71
PE
7058 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7059 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7060 isn't needed on 32-bit machines.
8f95c75c 7061
01103c44
PE
7062 * buffer.c (Fgenerate_new_buffer_name):
7063 Use EMACS_INT for count, not int.
0ceccced 7064 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7065
7066 * data.c (Qcompiled_function): Now static.
7067
c6f072e7
PE
7068 * window.c (window_body_lines): Now static.
7069
20ce5912
PE
7070 * image.c (gif_load): Rename local to avoid shadowing.
7071
9c4c5f81
PE
7072 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7073 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7074 * alloc.c (make_save_value): Integer argument is now of type
7075 ptrdiff_t, not int.
7076 (mark_object): Use ptrdiff_t, not int.
7077 * lisp.h (pD): New macro.
7078 * print.c (print_object): Use it.
7079
c0c5c8ae
PE
7080 * alloc.c: Use EMACS_INT, not int, to count objects.
7081 (total_conses, total_markers, total_symbols, total_vector_size)
7082 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7083 (total_free_floats, total_floats, total_free_intervals)
7084 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7085 Now EMACS_INT, not int. All uses changed.
7086 (Fgarbage_collect): Compute overall total using a double, so that
7087 integer overflow is less likely to be a problem. Check for overflow
7088 when converting back to an integer.
5a25e253
PE
7089 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7090 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7091 These were 'int' variables that could overflow on 64-bit hosts;
7092 they were never used, so remove them instead of repairing them.
211a0b2a 7093 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7094 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7095 Previously, this ceilinged at INT_MAX, but that doesn't work on
7096 64-bit machines.
e46bb31a 7097 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7098
c78baabf 7099 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7100 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7101 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7102 when a (possibly-narrower) signed value would do just as well.
7103 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7104
c9d624c6
PE
7105 * alloc.c: Catch some string size overflows that we were missing.
7106 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7107 for convenience in STRING_BYTES_MAX.
7108 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7109 The definition here is exact; the one in lisp.h was approximate.
7110 (allocate_string_data): Check for string overflow. This catches
7111 some instances we weren't catching before. Also, it catches
7112 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7113 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7114 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7115
c9d624c6
PE
7116 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7117 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7118 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7119
353032ce
PE
7120 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7121
2bccce07
PE
7122 * alloc.c (Fmake_string): Check for out-of-range init.
7123
0ac30604
SM
71242011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7125
7126 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7127
c195f2de
JD
71282011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7129
7130 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7131 xg_get_default_scrollbar_width.
7132
7133 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7134 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7135 (style_changed_cb): Call update_theme_scrollbar_width and call
7136 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7137 all frames (Bug#8505).
7138 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7139 Call gtk_window_set_resizable if HAVE_GTK3.
7140 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7141 and height if HAVE_GTK3 (Bug#8505).
7142 (scroll_bar_width_for_theme): New variable.
7143 (update_theme_scrollbar_width): New function.
7144 (xg_get_default_scrollbar_width): Move code to
7145 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7146 (xg_initialize): Call update_theme_scrollbar_width.
7147
7148 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7149
7150 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7151
e10ac9f1
MR
71522011-06-12 Martin Rudalics <rudalics@gmx.at>
7153
7154 * frame.c (make_frame): Call other_buffer_safely instead of
7155 other_buffer.
7156
7157 * window.c (temp_output_buffer_show): Call display_buffer with
7158 second argument Vtemp_buffer_show_specifiers and reset latter
7159 immediately after the call.
7160 (Vtemp_buffer_show_specifiers): New variable.
7161 (auto_window_vscroll_p, next_screen_context_lines)
7162 (Vscroll_preserve_screen_position): Remove leading asterisks from
7163 doc-strings.
7164
2d3c217e 71652011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7166
7b7f97e8 7167 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7168 * buffer.c (Qclone_number): Remove for now, as it's unused.
7169 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7170 (record_buffer): Remove unused local.
7171 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7172 (set_frame_buffer_list): Remove; unused.
7173 * frame.h (other_visible_frames): Remove decl.
7174 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7175 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7176 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7177 if HAVE_GPM.
7178 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7179 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7180 Define only if HAVE_GPM.
7181 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7182 (update_hints_inhibit): Remove; never set. All uses removed.
7183 * widgetprv.h (emacsFrameClassRec): Remove decl.
7184 * window.c (delete_deletable_window): Now returns void, since it
7185 wasn't returning anything.
7186 (compare_window_configurations): Remove unused locals.
7187 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7188 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7189 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7190 the same widths as pointers. This follows up on the 2011-05-06 patch.
7191 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7192 * xterm.h: Likewise.
7193 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7194
1384b89e
JB
71952011-06-12 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * makefile.w32-in: Update dependencies.
7198 (LISP_H): Add lib/intprops.h.
7199
1100a63c
CY
72002011-06-11 Chong Yidong <cyd@stupidchicken.com>
7201
7202 * image.c (gif_load): Add animation frame delay to the metadata.
7203 (syms_of_image): Use DEFSYM. New symbol `delay'.
7204
6198ccd0
MR
72052011-06-11 Martin Rudalics <rudalics@gmx.at>
7206
7207 * window.c (delete_deletable_window): Re-add.
7208 (Fset_window_configuration): Rewrite to handle dead buffers and
7209 consequently deletable windows.
7210 (window_tree, Fwindow_tree): Remove. Supply functionality in
7211 window.el.
7212 (compare_window_configurations): Simplify code.
7213
b6e3633c
AS
72142011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7215
1ab0dee5
AS
7216 * image.c (imagemagick_load_image): Fix type mismatch.
7217 (Fimagemagick_types): Likewise.
7218
b6e3633c
AS
7219 * window.h (replace_buffer_in_windows): Declare.
7220
9397e56f
MR
72212011-06-11 Martin Rudalics <rudalics@gmx.at>
7222
7223 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7224 Qclone_number. Remove external declaration of Qdelete_window.
7225 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7226 code.
640c8776
SM
7227 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7228 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7229 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7230 buffer list implementation.
7231 (other_buffer_safely): New function.
7232 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7233 calls to replace_buffer_in_windows and
7234 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7235 if allowed.
7236 (record_buffer): Inhibit quitting and rewrite using quittable
7237 functions. Run Qbuffer_list_update_hook if allowed.
7238 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7239 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7240 Move switch-to-buffer to window.el.
9397e56f
MR
7241 (bury-buffer): Move to window.el.
7242 (Vbuffer_list_update_hook): New variable.
7243
7244 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7245 section.
7246
7247 * window.h (resize_frame_windows): Move up in code.
7248 (Fwindow_frame): Remove EXFUN.
7249 (replace_buffer_in_all_windows): Remove prototype.
7250 (replace_buffer_in_windows_safely): Add prototype.
7251
7252 * window.c: Declare Qdelete_window static again. Move down
7253 declaration of select_count.
7254 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7255 (Fother_window): Move to window.el.
7256 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7257 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7258 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7259 window.el.
7260 (replace_buffer_in_windows): Implement by calling
7261 Qreplace_buffer_in_windows.
7262 (replace_buffer_in_all_windows): Remove with some functionality
7263 moved into replace_buffer_in_windows_safely.
7264 (replace_buffer_in_windows_safely): New function.
7265 (select_window_norecord, select_frame_norecord): Move in front
7266 of run_window_configuration_change_hook. Remove now obsolete
7267 declarations.
640c8776
SM
7268 (Fset_window_buffer): Rewrite doc-string.
7269 Call Qrecord_window_buffer.
9397e56f
MR
7270 (keys_of_window): Move binding for other-window to window.el.
7271
b50691aa
CY
72722011-06-11 Chong Yidong <cyd@stupidchicken.com>
7273
7274 * dispextern.h (struct image): Replace data member, whose int_val
7275 and ptr_val fields were not used by anything, with a single
7276 lisp_val object.
7277
7278 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7279 (gif_clear_image, gif_load, imagemagick_load_image)
7280 (gs_clear_image, gs_load): Callers changed.
7281
3f754b86
PE
72822011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7283
cca69397
PE
7284 * buffer.h: Include <time.h>, for time_t.
7285 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7286
109e28d0
PE
7287 Fix minor problems found by static checking.
7288
60737f02
PE
7289 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7290
4b66faf3
PE
7291 Make identifiers static if they are not used in other modules.
7292 * data.c (Qcompiled_function, Qframe, Qvector):
7293 * image.c (QimageMagick, Qsvg):
7294 * minibuf.c (Qmetadata):
7295 * window.c (resize_window_check, resize_root_window): Now static.
7296 * window.h (resize_window_check, resize_root_window): Remove decls.
7297
109e28d0
PE
7298 * window.c (window_deletion_count, delete_deletable_window):
7299 Remove; unused.
46a4ce9e
PE
7300 (window_body_lines): Now static.
7301 (Fdelete_other_windows_internal): Mark vars as initialized.
7302 Make sure 'resize_failed' is initialized.
7303 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7304 (resize_window_apply): Remove unused local.
7305 * window.h (delete_deletable_window): Remove decl.
7306
109e28d0 7307 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7308 (imagemagick_load_image): Fix pointer signedness problem by changing
7309 last arg from unsigned char * to char *. All uses changed.
7310 Also, fix a local for similar reasons.
7311 Remove unused locals. Remove locals to avoid shadowing.
7312 (fn_rsvg_handle_free): Remove; unused.
7313 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7314 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7315
3f754b86
PE
7316 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7317
2547adb1
CY
73182011-06-10 Chong Yidong <cyd@stupidchicken.com>
7319
7320 * image.c (gif_load): Fix omitted cast error introduced by
7321 2011-06-06 change.
7322
2c8e37d4
MR
73232011-06-10 Martin Rudalics <rudalics@gmx.at>
7324
7325 * window.h (resize_proportionally, orig_total_lines)
7326 (orig_top_line): Remove from window structure.
7327 (set_window_height, set_window_width, change_window_heights)
7328 (Fdelete_window): Remove prototypes.
7329 (resize_frame_windows): Remove duplicate declaration.
7330
440a42e3
EZ
73312011-06-10 Eli Zaretskii <eliz@gnu.org>
7332
7333 * window.h (resize_frame_windows, resize_window_check)
7334 (delete_deletable_window, resize_root_window)
7335 (resize_frame_windows): Declare prototypes.
7336
7337 * window.c (resize_window_apply): Make definition be "static" to
7338 match the prototype.
7339
562dd5e9
MR
73402011-06-10 Martin Rudalics <rudalics@gmx.at>
7341
7342 * window.c: Remove declarations of Qwindow_size_fixed,
7343 window_min_size_1, window_min_size_2, window_min_size,
7344 size_window, window_fixed_size_p, enlarge_window, delete_window.
7345 Remove static from declaration of Qdelete_window, it's
7346 temporarily needed by Fbury_buffer.
7347 (replace_window): Don't assign orig_top_line and
7348 orig_total_lines.
7349 (Fdelete_window, delete_window): Remove. Window deletion is
7350 handled by window.el.
640c8776
SM
7351 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7352 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7353 (Fdelete_other_windows): Remove. Deleting other windows is
7354 handled by window.el.
7355 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7356 handled in window.el.
7357 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7358 Window minimum sizes are handled in window.el.
7359 (shrink_windows, size_window, set_window_height)
7360 (set_window_width, change_window_heights, window_height)
7361 (window_width, CURBEG, CURSIZE, enlarge_window)
7362 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7363 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7364 handled in window.el.
7365 (make_dummy_parent): Rename to make_parent_window and give it a
7366 second argument horflag.
7367 (make_window): Don't set resize_proportionally any more.
7368 (Fsplit_window): Remove. Windows are split in window.el.
7369 (save_restore_action, save_restore_orig_size)
7370 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7371 Resize mini windows in window.el.
7372 (grow_mini_window, shrink_mini_window): Implement by calling
7373 Qresize_root_window_vertically, resize_window_check and
7374 resize_window_apply.
640c8776
SM
7375 (saved_window, Fset_window_configuration, save_window_save):
7376 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7377 resize_proportionally.
7378 (window_min_height, window_min_width): Move to window.el.
7379 (keys_of_window): Move bindings for delete-other-windows,
7380 split-window, delete-window and enlarge-window to window.el.
7381
7382 * buffer.c: Temporarily extern Qdelete_window.
7383 (Fbury_buffer): Temporarily call Qdelete_window instead of
7384 Fdelete_window (Fbury_buffer will move to window.el soon).
7385
7386 * frame.c (set_menu_bar_lines_1): Remove code handling
7387 orig_top_line and orig_total_lines.
7388
7389 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7390 set_window_height but set heights directly.
7391 (change_frame_size_1): Use resize_frame_windows.
7392
7393 * xdisp.c (init_xdisp): Don't use set_window_height but set
7394 heights directly.
7395
640c8776
SM
7396 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7397 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7398 run_window_configuration_change_hook.
7399
7400 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7401 instead of change_window_heights and run
7402 run_window_configuration_change_hook.
7403
1a13852e
MR
74042011-06-09 Martin Rudalics <rudalics@gmx.at>
7405
7406 * window.c (replace_window): Rename second argument REPLACEMENT to
7407 NEW. New third argument SETFLAG. Rewrite.
7408 (delete_window, make_dummy_parent): Call replace_window with
7409 third argument 1.
7410 (window_list_1): Move down in code.
7411 (run_window_configuration_change_hook): Move set_buffer part
7412 before select_frame_norecord part in order to unwind correctly.
7413 Rename count1 to count.
7414 (recombine_windows, delete_deletable_window, resize_root_window)
7415 (Fdelete_other_windows_internal)
7416 (Frun_window_configuration_change_hook, make_parent_window)
7417 (resize_window_check, resize_window_apply, Fresize_window_apply)
7418 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7419 (Fdelete_window_internal, Fresize_mini_window_internal):
7420 New functions.
1a13852e
MR
7421 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7422
f3d1777e
MR
74232011-06-08 Martin Rudalics <rudalics@gmx.at>
7424
496e208e
MR
7425 * window.h (window): Add some new members to window structure -
7426 normal_lines, normal_cols, new_total, new_normal, clone_number,
7427 splits, nest, prev_buffers, next_buffers.
7428 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7429 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7430
f3d1777e
MR
7431 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7432 Remove.
496e208e
MR
7433 (make_dummy_parent): Set new members of windows structure.
7434 (make_window): Move down in code. Handle new members of window
7435 structure.
7436 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7437 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7438 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7439 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7440 (Fset_window_next_buffers, Fset_window_clone_number):
7441 New functions.
496e208e
MR
7442 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7443 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7444 Doc-string fixes.
7445 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7446 Argument WINDOW can be now internal window too.
7447 (Fwindow_use_time): Move up in code.
7448 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7449 Rewrite doc-string.
7450 (Fset_window_configuration, saved_window)
7451 (Fcurrent_window_configuration, save_window_save): Handle new
7452 members of window structure.
b9e809c2
MR
7453 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7454 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7455 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7456 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7457 Qget_mru_window, Qresize_root_window,
7458 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7459 Qauto_buffer_name; staticpro them.
f3d1777e 7460
abde8f8c
MR
74612011-06-07 Martin Rudalics <rudalics@gmx.at>
7462
7463 * window.c (Fwindow_total_size, Fwindow_left_column)
7464 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7465 (Fwindow_list_1): New functions.
7466 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7467 (Fwindow_width, Fscroll_left, Fscroll_right):
7468 Use window_body_cols instead of window_box_text_cols.
7469 (delete_window, Fset_window_configuration):
7470 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7471 (delete_all_subwindows): Take a window as argument and not a
7472 structure. Rewrite.
190b47e6
MR
7473 (window_loop): Remove handling of GET_LRU_WINDOW and
7474 GET_LARGEST_WINDOW.
7475 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7476
7477 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7478 window_box_text_cols. delete_all_subwindows now takes a
7479 Lisp_Object as argument.
abde8f8c 7480
640c8776
SM
7481 * indent.c (compute_motion, Fcompute_motion):
7482 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7483
fa8a67e6
MR
7484 * frame.c (delete_frame): Call delete_all_subwindows with root
7485 window as argument.
7486
a54e3482
DC
74872011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7488
7489 * fns.c (Fputhash): Document return value.
7490
60002bf5
CY
74912011-06-06 Chong Yidong <cyd@stupidchicken.com>
7492
7493 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7494
0c671da6 74952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7496
b862a52a 7497 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7498
be44ca6c
PE
7499 Check for overflow when converting integer to cons and back.
7500 * charset.c (Fdefine_charset_internal, Fdecode_char):
7501 Use cons_to_unsigned to catch overflow.
7502 (Fencode_char): Use INTEGER_TO_CONS.
7503 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7504 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7505 * data.c (long_to_cons, cons_to_long): Remove.
7506 (cons_to_unsigned, cons_to_signed): New functions.
7507 These signal an error for invalid or out-of-range values.
7508 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7509 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7510 * font.c (Ffont_variation_glyphs):
7511 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7512 * lisp.h: Include <intprops.h>.
7513 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7514 (cons_to_signed, cons_to_unsigned): New decls.
7515 (long_to_cons, cons_to_long): Remove decls.
7516 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7517 (Fprimitive_undo): Use CONS_TO_INTEGER.
7518 * xfns.c (Fx_window_property): Likewise.
7519 * xselect.c: Include <limits.h>.
7520 (x_own_selection, selection_data_to_lisp_data):
7521 Use INTEGER_TO_CONS.
7522 (x_handle_selection_request, x_handle_selection_clear)
7523 (x_get_foreign_selection, Fx_disown_selection_internal)
7524 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7525 (lisp_data_to_selection_data): Use cons_to_unsigned.
7526 (x_fill_property_data): Use cons_to_signed.
7527 Report values out of range.
7528
d1f3d2af
PE
7529 Check for buffer and string overflow more precisely.
7530 * buffer.h (BUF_BYTES_MAX): New macro.
7531 * lisp.h (STRING_BYTES_MAX): New macro.
7532 * alloc.c (Fmake_string):
7533 * character.c (string_escape_byte8):
7534 * coding.c (coding_alloc_by_realloc):
7535 * doprnt.c (doprnt):
7536 * editfns.c (Fformat):
7537 * eval.c (verror):
7538 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7539 since they may not be the same number.
7540 * editfns.c (Finsert_char):
7541 * fileio.c (Finsert_file_contents):
7542 Likewise for BUF_BYTES_MAX.
7543
dd52fcea
PE
7544 * image.c: Use ptrdiff_t, not int, for sizes.
7545 (slurp_file): Switch from int to ptrdiff_t.
7546 All uses changed.
7547 (slurp_file): Check that file size fits in both size_t (for
7548 malloc) and ptrdiff_t (for sanity and safety).
7549
7f9bbdbb
PE
7550 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7551 if b->modtime has its maximal value.
7552
dfe18f82
PE
7553 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7554
84acfcf0
PE
7555 Don't assume time_t can fit into int.
7556 * buffer.h (struct buffer.modtime): Now time_t, not int.
7557 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7558 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7559
ccd9a01a
PE
7560 Minor fixes for signed vs unsigned integers.
7561 * character.h (MAYBE_UNIFY_CHAR):
7562 * charset.c (maybe_unify_char):
7563 * keyboard.c (read_char, reorder_modifiers):
7564 XINT -> XFASTINT, since the integer must be nonnegative.
7565 * ftfont.c (ftfont_spec_pattern):
7566 * keymap.c (access_keymap, silly_event_symbol_error):
7567 XUINT -> XFASTINT, since the integer must be nonnegative.
7568 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7569 since it makes no difference and we prefer signed.
7570 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7571 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7572 nonnegative.
7573
d6d100dd
SM
75742011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7575
7576 * window.h (Fwindow_frame): Declare.
7577
2b6148e4
PE
75782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7579
7580 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7581 (SPARE_MEMORY): Always define.
7582 (LARGE_REQUEST): Remove.
7583 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7584
f230ecc9
MR
75852011-06-06 Martin Rudalics <rudalics@gmx.at>
7586
727e958e
MR
7587 * lisp.h: Move EXFUNS for Fframe_root_window,
7588 Fframe_first_window and Fset_frame_selected_window to window.h.
7589
7590 * window.h: Move EXFUNS for Fframe_root_window,
7591 Fframe_first_window and Fset_frame_selected_window here from
7592 lisp.h.
7593
7594 * frame.c (Fwindow_frame, Fframe_first_window)
7595 (Fframe_root_window, Fframe_selected_window)
7596 (Fset_frame_selected_window): Move to window.c.
7597 (Factive_minibuffer_window): Move to minibuf.c.
7598 (Fother_visible_frames_p): New function.
7599
7600 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7601
f230ecc9
MR
7602 * window.c (decode_window, decode_any_window): Move up in code.
7603 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7604 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7605 (Fwindow_buffer): Move up and rewrite doc-string.
7606 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7607 (Fwindow_prev): New functions.
727e958e
MR
7608 (Fwindow_frame): Move here from frame.c. Accept any window as
7609 argument.
7610 (Fframe_root_window, Fframe_first_window)
7611 (Fframe_selected_window): Move here from frame.c. Accept frame
7612 or arbitrary window as argument. Update doc-strings.
7613 (Fminibuffer_window): Move up in code.
7614 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7615 (Fset_frame_selected_window): Move here from frame.c.
7616 Marginal rewrite.
727e958e
MR
7617 (Fselected_window, select_window, Fselect_window): Move up in
7618 code. Minor doc-string fixes.
f230ecc9 7619
4d09bcf6
PE
76202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7621
7622 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7623 Do not assume that spare memory exists; that assumption is valid
7624 only if SYSTEM_MALLOC.
7625 (LARGE_REQUEST): New macro, so that the issue of large requests
7626 is separated from the issue of spare memory.
7627
810928a2
AS
76282011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7629
172418ad
AS
7630 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7631 format. (Bug#8806)
7632
43f862f7
AS
7633 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7634
810928a2
AS
7635 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7636 before statements.
7637
a059fe24
JD
76382011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7639
7640 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7641
7642 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7643
7644 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7645 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7646
989bf368
JB
76472011-06-05 Juanma Barranquero <lekktu@gmail.com>
7648
7649 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7650
4b80f674
CY
76512011-06-04 Chong Yidong <cyd@stupidchicken.com>
7652
7653 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7654 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7655 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7656 New error handlers.
4b80f674
CY
7657 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7658 Obey Vx_select_enable_clipboard_manager. Catch errors in
7659 x_clipboard_manager_save (Bug#8779).
7660 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7661 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7662
99a33b77 76632011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7664
7665 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7666
99a33b77 76672011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7668
7669 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7670 in the current matrix if keep_current_p is non-zero.
7671
8264569d
EZ
76722011-06-04 Eli Zaretskii <eliz@gnu.org>
7673
7674 * bidi.c (bidi_level_of_next_char): Fix last change.
7675
57f97249
EZ
76762011-06-03 Eli Zaretskii <eliz@gnu.org>
7677
fec2107c 7678 Support bidi reordering of text covered by display properties.
57f97249 7679
fec2107c
EZ
7680 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7681 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7682 (bidi_cache_search, bidi_cache_iterator_state)
7683 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7684 (bidi_level_of_next_char, bidi_move_to_visually_next):
7685 Support character positions inside a run of characters covered by a
fec2107c
EZ
7686 display string.
7687 (bidi_paragraph_init, bidi_resolve_explicit_1)
7688 (bidi_level_of_next_char): Call bidi_fetch_char and
7689 bidi_fetch_char_advance instead of FETCH_CHAR and
7690 FETCH_CHAR_ADVANCE.
7691 (bidi_init_it): Initialize new members.
7692 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7693 definitions.
7694 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7695 instead of using explicit *_CHAR codes.
d6d100dd
SM
7696 (bidi_resolve_explicit, bidi_resolve_weak):
7697 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
7698 bidirectional text is supported only in multibyte buffers.
7699 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7700 it to initialize the frame_window_p member of struct bidi_it.
7701 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7702 (bidi_resolve_explicit, bidi_resolve_weak)
7703 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7704 bidi_it->nchars is non-positive.
7705 (bidi_level_of_next_char): Don't try to lookup the cache for the
7706 next/previous character if nothing is cached there yet, or if we
7707 were just reseat()'ed to a new position.
c40e2fb2 7708
0e14fe90
EZ
7709 * xdisp.c (set_cursor_from_row): Set start and stop points
7710 according to the row's direction when priming the loop that looks
7711 for the glyph on which to display cursor.
7712 (single_display_spec_intangible_p): Function deleted.
7713 (display_prop_intangible_p): Reimplement to call
7714 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
7715 Accept 3 additional arguments needed by handle_display_spec.
7716 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
7717 values: lists, `(when COND...)' forms, etc.
7718 (single_display_spec_string_p): Support property values that are
7719 lists with the argument STRING its top-level element.
7720 (display_prop_string_p): Fix the condition for processing a
7721 property that is a list to be consistent with handle_display_spec.
fec2107c 7722 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
7723 last portion of handle_display_prop.
7724 (compute_display_string_pos): Accept additional argument
7725 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7726 value of a `display' property is a "replacing spec".
7727 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7728 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7729 the display property, but just return a value indicating whether
7730 the display property will replace the characters it covers.
7731 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7732 frame_window_p members of struct bidi_it.
d6d100dd
SM
7733 (compute_display_string_pos, compute_display_string_end):
7734 New functions.
fec2107c
EZ
7735 (push_it): Accept second argument POSITION, where pop_it should
7736 jump to continue iteration.
7737 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 7738
fec2107c
EZ
7739 * keyboard.c (adjust_point_for_property): Adjust the call to
7740 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
7741
7742 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
7743 (bidi_init_it): Update prototypes.
7744 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
7745 (compute_display_string_pos, compute_display_string_end):
7746 Declare prototypes.
fec2107c
EZ
7747 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7748 EMACS_INT.
fc6f18ce 7749
40087514 77502011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 7751
57f53182
PE
7752 Malloc failure behavior now depends on size of allocation.
7753 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7754 * lisp.h: Change signatures accordingly.
7755 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7756 All callers changed. (Bug#8762)
7757
7758 * gnutls.c: Use Emacs's memory allocators.
7759 Without this change, the gnutls library would invoke malloc etc.
7760 directly, which causes problems on non-SYNC_INPUT hosts, and which
7761 runs afoul of improving memory_full behavior. (Bug#8761)
7762 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7763 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7764 xfree instead of the default malloc, realloc, free.
7765 (Fgnutls_boot): No need to check for memory allocation failure,
7766 since xmalloc does that for us.
7767
ac32cd99 7768 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
7769 * category.c (hash_get_category_set):
7770 * ccl.c (ccl_driver):
7771 * charset.c (Fdefine_charset_internal):
7772 * charset.h (struct charset.hash_index):
7773 * composite.c (get_composition_id, gstring_lookup_cache)
7774 (composition_gstring_put_cache):
7775 * composite.h (struct composition.hash_index):
7776 * dispextern.h (struct image.hash):
7777 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7778 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7779 (hashfn_equal, hashfn_user_defined, make_hash_table)
7780 (maybe_resize_hash_table, hash_lookup, hash_put)
7781 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7782 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7783 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7784 * image.c (make_image, search_image_cache, lookup_image)
7785 (xpm_put_color_table_h):
7786 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 7787 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 7788 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 7789 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
7790 * alloc.c (allocate_vectorlike):
7791 Check for overflow in vector size calculations.
7792 * ccl.c (ccl_driver):
7793 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
7794 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7795 need to be updated by these changes.
40087514
PE
7796 * fns.c (make_hash_table, maybe_resize_hash_table):
7797 Check for integer overflow with large hash tables.
0de4bb68
PE
7798 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7799 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7800 (SXHASH_REDUCE): New macro.
7801 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7802 Use it instead of discarding useful hash info with large hash values.
7803 (sxhash_float): New function.
7804 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7805 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
7806 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7807 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
7808 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7809 Adjust signatures to match updated version of code.
7810 (consing_since_gc): Now EMACS_INT, since a single hash table can
7811 use more than INT_MAX bytes.
7812
698d32e2
DN
78132011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7814
7815 Make it possible to build with GCC-4.6+ -O2 -flto.
7816
7817 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7818
fd6fa53f
SM
78192011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7820
7821 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7822 Call minibuffer-inactive-mode.
7823
864db017
JB
78242011-05-31 Juanma Barranquero <lekktu@gmail.com>
7825
7826 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7827 Update dependencies.
7828
2ad0baf4
DN
78292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7830
7831 * data.c (init_data): Remove code for UTS, this system is not
7832 supported anymore.
7833
4fcc2638
DN
78342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7835
7836 Don't force ./temacs to start in terminal mode.
7837
7838 * frame.c (make_initial_frame): Initialize faces in all cases, not
7839 only when CANNOT_DUMP is defined.
7840 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7841
c56e0fd5
DN
78422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7843
7844 * dispnew.c (add_window_display_history): Use const for the string
7845 pointer. Remove declaration, not needed.
7846
333d54da 78472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 7848
55d4c1b2 7849 Use 'inline', not 'INLINE'.
333d54da 7850 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
7851 * alloc.c, fontset.c (INLINE): Remove.
7852 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7853 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7854 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7855 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7856 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7857
738db178
DN
78582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7859
7860 Make it possible to run ./temacs.
7861
7862 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7863 syms_of_callproc does the same thing. Remove test for
7864 "initialized", do it in the caller.
7865 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7866
620c53a6
SM
78672011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7868
7869 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7870 (read_minibuf): Use get_minibuffer.
7871 (syms_of_minibuf): Use DEFSYM.
7872 (Qmetadata): New var.
7873 * data.c (Qbuffer): Don't make it static.
7874 (syms_of_data): Use DEFSYM.
7875
e003a292
PE
78762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7877
7878 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7879 (CCL_CODE_MIN): New macro.
7880
ed008a6d
PE
78812011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7882
3687c2ef
PE
7883 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7884
ed008a6d
PE
7885 * eval.c (Qdebug): Now static.
7886 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7887 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7888 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7889
d66c4c7c
CY
78902011-05-29 Chong Yidong <cyd@stupidchicken.com>
7891
7892 * image.c: Various fixes to ImageMagick code comments.
7893 (Fimagemagick_types): Doc fix.
7894
5fbc2025
PE
78952011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7896
0196f88a
PE
7897 Minor fixes prompted by GCC 4.6.0 warnings.
7898
7899 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7900
5fbc2025
PE
7901 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7902 (x_clipboard_manager_save_all): Move extern decl to ...
7903 * xterm.h: ... here, so that it can be checked for consistency.
7904
1dd3c2d9
CY
79052011-05-29 Chong Yidong <cyd@stupidchicken.com>
7906
7907 * xselect.c (x_clipboard_manager_save_frame)
7908 (x_clipboard_manager_save_all): New functions.
7909 (Fx_clipboard_manager_save): Lisp function deleted.
7910
7911 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7912 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7913
7914 * xterm.h: Update prototype.
7915
5ba6571d
WX
79162011-05-28 William Xu <william.xwl@gmail.com>
7917
7918 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7919 exiting (Bug#8239).
7920
3eaff834
JM
79212011-05-28 Jim Meyering <meyering@redhat.com>
7922
e1900994 7923 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
7924 * fns.c (to_uchar): Define.
7925 (crypto_hash_function): Use it to convert some newly-signed
7926 variables to unsigned, to avoid sign-extension bugs. For example,
7927 without this change, (md5 "truc") would evaluate to
7928 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7929 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 7930 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 7931
0f6990a7
PE
79322011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7933
7934 Integer overflow fixes.
c8a9ca5a 7935
08686060
PE
7936 * dbusbind.c: Serial number integer overflow fixes.
7937 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
7938 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7939 to hold a serial number that is too large for a fixnum.
7940 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7941 Check for serial numbers out of range. Decode any serial number
59568bf0 7942 that was so large that it became a float. (Bug#8722)
08686060 7943
2d1fc3c7
PE
7944 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7945 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7946 Use XFASTINT rather than XUINT when numbers are nonnegative.
7947 (xd_append_arg, Fdbus_method_return_internal):
7948 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7949 arguments, check that Lisp number is nonnegative, rather than
59568bf0 7950 silently wrapping negative numbers around. (Bug#8722)
30217ff0 7951 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 7952 (Bug#8722)
2d1fc3c7 7953
c8a9ca5a
PE
7954 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7955
519e1d69
PE
7956 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7957
6df6ae42 7958 ccl: Add integer overflow checks.
30569699
PE
7959 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7960 (IN_INT_RANGE): New macros.
7961 (ccl_driver): Use them to check for integer overflow when
7962 decoding a CCL program. Many of the new checks are whether XINT (x)
7963 fits in int; it doesn't always, on 64-bit hosts. The new version
7964 doesn't catch all possible integer overflows, but it's an
847044ea 7965 improvement. (Bug#8719)
30569699 7966
c11285dc
PE
7967 * alloc.c (make_event_array): Use XINT, not XUINT.
7968 There's no need for unsigned here.
7969
fdccd48e
PE
7970 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7971 This follows up to the 2011-05-06 change that substituted uintptr_t
7972 for EMACS_INT. This case wasn't caught back then.
7973
37910ab2
PE
7974 Rework Fformat to avoid integer overflow issues.
7975 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7976 now (part of C89). Include <verify.h>.
7977 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7978 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7979 (Fformat): Avoid the prepass trying to compute sizes; it was only
7980 approximate and thus did not catch overflow reliably. Instead, walk
7981 through the format just once, formatting and computing sizes as we go,
7982 checking for integer overflow at every step, and allocating a larger
7983 buffer as needed. Keep track separately whether the format is
7984 multibyte. Keep only the most-recently calculated precision, rather
7985 than them all. Record whether each argument has been converted to
7986 string. Use EMACS_INT, not int, for byte and char and arg counts.
7987 Support field widths and precisions larger than INT_MAX. Avoid
7988 sprintf's undefined behavior with conversion specifications such as %#d
7989 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7990 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7991 formatting out-of-range floating point numbers with int
9173deec 7992 formats. (Bug#8668)
37910ab2 7993
2e6578fb
PE
7994 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7995
0ae6bdee
PE
7996 * data.c: Avoid integer truncation in expressions involving floats.
7997 * data.c: Include <intprops.h>.
7998 (arith_driver): When there's an integer overflow in an expression
7999 involving floating point, convert the integers to floating point
8000 so that the resulting value does not suffer from catastrophic
8001 integer truncation. For example, on a 64-bit host (* 4
8002 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8003 Do not rely on undefined behavior after integer overflow.
8004
de883a70
PE
8005 merge count_size_as_multibyte, parse_str_to_multibyte
8006 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8007 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8008 Check for integer overflow.
8009 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8010 since it's now a duplicate of the other. This is more of
8011 a character than a buffer op, so better that it's in character.c.
8012 * fns.c, print.c: Adjust to above changes.
8013
2ff916cb
PE
80142011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8015
8016 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8017
f1b54466
PE
80182011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8019
fb1ac845
PE
8020 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8021 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8022 (x_clipboard_manager_save): Now static.
8023 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8024
f1b54466
PE
8025 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8026 (crypto_hash_function): Now static.
8027 Fix pointer signedness problems. Avoid unnecessary initializations.
8028
a9f737ee
CY
80292011-05-27 Chong Yidong <cyd@stupidchicken.com>
8030
8031 * termhooks.h (Vselection_alist): Make it terminal-local.
8032
8033 * terminal.c (create_terminal): Initialize it.
8034
8035 * xselect.c: Support for clipboard managers.
8036 (Vselection_alist): Move to termhooks.h as terminal-local var.
8037 (LOCAL_SELECTION): New macro.
8038 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8039 (symbol_to_x_atom): Remove gratuitous arg.
8040 (x_handle_selection_request, lisp_data_to_selection_data)
8041 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8042 (x_own_selection, x_get_local_selection, x_convert_selection):
8043 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8044 (some_frame_on_display): Delete unused function.
8045 (Fx_own_selection_internal, Fx_get_selection_internal)
8046 (Fx_disown_selection_internal, Fx_selection_owner_p)
8047 (Fx_selection_exists_p): New optional frame arg.
8048 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8049 (x_handle_selection_clear): Don't treat other terminals with the
8050 same keyboard specially. Use the terminal-local Vselection_alist.
8051 (x_clear_frame_selections): Use Frun_hook_with_args.
8052
8053 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8054
8055 * xterm.h: Add support for those atoms.
8056
e067f0c1
CY
80572011-05-26 Chong Yidong <cyd@stupidchicken.com>
8058
8059 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8060 (converted_selections, conversion_fail_tag): New global variables.
8061 (x_selection_request_lisp_error): Free the above.
8062 (x_get_local_selection): Remove unnecessary code.
8063 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8064 of converted selections stored in converted_selections.
8065 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8066 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8067 (x_convert_selection): New function.
8068 (x_handle_selection_event): Simplify.
8069 (x_get_foreign_selection): Don't ignore incoming requests while
8070 waiting for an answer; this will fail when we implement
8071 SAVE_TARGETS, and seems unnecessary anyway.
8072 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8073 (Vx_sent_selection_functions): Doc fix.
8074
0f4aebc0
LL
80752011-05-26 Leo Liu <sdl.web@gmail.com>
8076
8077 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8078
e61124cd
YM
80792011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8080
8081 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8082
8083 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8084 for fringe update if it has periodic bitmap.
ac389d0c 8085 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8086 and fringe_bitmap_periodic_p.
8087
8088 * fringe.c (get_fringe_bitmap_data): New function.
8089 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8090 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8091 row. Mark glyph row for fringe update if periodicity changed.
8092
8093 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8094 for fringe update unless it has periodic bitmap.
8095
f16d9837
KH
80962011-05-25 Kenichi Handa <handa@m17n.org>
8097
8098 * xdisp.c (get_next_display_element): Set correct it->face_id for
8099 a static composition.
8100
e1b90ef6
LL
81012011-05-24 Leo Liu <sdl.web@gmail.com>
8102
8103 * deps.mk (fns.o):
8104 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8105
8106 * fns.c (crypto_hash_function, Fsha1): New function.
8107 (Fmd5): Use crypto_hash_function.
8108 (syms_of_fns): Add Ssha1.
8109
7400048f
PE
81102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8111
8112 * gnutls.c: Remove unused macros.
8113 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8114 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8115 Remove macros that are defined and never used.
8116 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8117
abb71cf4
CY
81182011-05-22 Chong Yidong <cyd@stupidchicken.com>
8119
8120 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8121 (Fx_get_selection_internal): Minor cleanup.
8122 (Fx_own_selection_internal): Rename arguments for consistency with
8123 select.el.
8124
6307db39
PE
81252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8126
8127 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8128
f3d4e0a4
CY
81292011-05-22 Chong Yidong <cyd@stupidchicken.com>
8130
8131 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8132
4d8ade89
YM
81332011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8134
8135 * dispnew.c (scrolling_window): Don't exclude the case that the
8136 last enabled row in the desired matrix touches the bottom boundary.
8137
32078c8d
GM
81382011-05-21 Glenn Morris <rgm@gnu.org>
8139
8140 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8141 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8142 and add some more files.
32078c8d 8143
7285dc67
EZ
81442011-05-20 Eli Zaretskii <eliz@gnu.org>
8145
8146 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8147 report_file_error introduced by the change from 2011-05-07.
8148
89d1bd22
PE
81492011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8150
8151 * systime.h (Time): Define only if emacs is defined.
8152 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8153 where the include path doesn't have X11/X.h by default. See
8154 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8155
cd394be1 81562011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8157
8158 * composite.c (find_automatic_composition): Fix previous change.
8159
b9704ad9
GM
81602011-05-20 Glenn Morris <rgm@gnu.org>
8161
8162 * lisp.mk: New file, split from Makefile.in.
8163 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8164 (shortlisp): Remove.
8165 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8166
4a720484
GM
81672011-05-19 Glenn Morris <rgm@gnu.org>
8168
8169 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8170 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8171 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8172 (lisp): Set the order to that of loadup.el.
8173 (shortlisp): Make it a copy of $lisp.
8174 (SOME_MACHINE_LISP): Remove.
8175 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8176 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8177
a28d4396
KH
81782011-05-18 Kenichi Handa <handa@m17n.org>
8179
8180 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8181 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8182 (find_automatic_composition): Mostly rewrite for efficiency.
8183
a2b1fa8e
JB
81842011-05-18 Juanma Barranquero <lekktu@gmail.com>
8185
8186 * makefile.w32-in: Update dependencies.
8187
8e1f5610
CS
81882011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8189
8190 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8191 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8192
7025ee00 81932011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8194
cdfa6eab
PE
8195 Fix some integer overflow issues, such as string length overflow.
8196
06d6db33
PE
8197 * insdel.c (count_size_as_multibyte): Check for string overflow.
8198
2b4560a8
PE
8199 * character.c (lisp_string_width): Check for string overflow.
8200 Use EMACS_INT, not int, for string indexes and lengths; in
8201 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8202 the resulting string length overflows an EMACS_INT; instead,
8203 report a string overflow if no precision given. When checking for
8204 precision exhaustion, use a check that cannot possibly have
8205 integer overflow. (Bug#8675)
8206 * character.h (lisp_string_width): Adjust to new signature.
8207
cb93f9be
PE
8208 * alloc.c (string_overflow): New function.
8209 (Fmake_string): Use it. This doesn't change behavior, but saves
8210 a few bytes and will simplify future changes.
8211 * character.c (string_escape_byte8): Likewise.
8212 * lisp.h (string_overflow): New decl.
8213
1a1f3366
PE
8214 Fixups, following up to the user-interface timestamp change.
8215 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8216 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8217 * msdos.c (mouse_get_pos): Likewise.
8218 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8219 * w32gui.h (Time): Define by including "systime.h" rather than by
8220 declaring it ourselves. (Bug#8664)
8221
d4e3e4d3
PE
8222 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8223 * image.c (clear_image_cache): Likewise.
8224
f6a24d19
PE
8225 * term.c (term_mouse_position): Don't assume time_t wraparound.
8226
08dc5ae6
PE
8227 Be more systematic about user-interface timestamps.
8228 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8229 and sometimes 'EMACS_UINT', to represent these timestamps.
8230 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8231 This makes the code easier to follow, and makes it easier to catch
8232 integer overflow bugs such as Bug#8664.
8233 * frame.c (Fmouse_position, Fmouse_pixel_position):
8234 Use Time, not unsigned long, for user-interface timestamps.
8235 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8236 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8237 * keyboard.h (last_event_timestamp): Likewise.
8238 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8239 * menu.h (xmenu_show): Likewise.
8240 * term.c (term_mouse_position): Likewise.
8241 * termhooks.h (struct input_event.timestamp): Likewise.
8242 (struct terminal.mouse_position_hook): Likewise.
8243 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8244 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8245 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8246 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8247 what it was before.
8248 * menu.h, termhooks.h: Include "systime.h", for Time.
8249
8e55734a
PE
8250 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8251 Don't assume that the difference between two unsigned long values
8252 can fit into an integer. At this point, we know button_down_time
8253 <= event->timestamp, so the difference must be nonnegative, so
8254 there's no need to cast the result if double-click-time is
8255 nonnegative, as it should be; check that it's nonnegative, just in
8256 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8257 apart (about 25 days). (Bug#8664)
8e55734a 8258
841f1b75 8259 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8260 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8261
3e26f69c
PE
8262 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8263 that always fit in int. Use a sentinel instead of a counter, to
8264 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8265 * frame.h (struct frame): Use int for menu_bar_items_used
8266 instead of EMACS_INT, since it always fits in int.
3e26f69c 8267
5cc152c0
PE
8268 * menu.c (grow_menu_items): Check for int overflow.
8269
d89eb65e
PE
8270 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8271
5235bd3e
PE
8272 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8273 Before, the code was not consistent. These values cannot exceed
8274 2**31 - 1 so there's no need to make them unsigned.
8275 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8276 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8277 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8278 as modifiers.
8279 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8280
bc827e23
PE
8281 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8282 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8283 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8284 presumably because the widths might not match.
8285
78eb494e
PE
8286 * window.c (size_window): Avoid needless test at loop start.
8287
04f2d78b
CB
82882011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8289
8290 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8291
d2fc7e3d 82922011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8293
8294 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8295
d2fc7e3d 82962011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8297
8298 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8299 `width' to `bar_area_x' and `bar_area_width', respectively.
8300 (x_scroll_run): Take account of fringe background extension.
8301
04f2d78b
CB
8302 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8303 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8304 `bar_area_width', respectively.
8305 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8306 background extension.
8307
79b70037
GM
83082011-05-10 Jim Meyering <meyering@redhat.com>
8309
8310 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8311
2f142cc5
JB
83122011-05-10 Juanma Barranquero <lekktu@gmail.com>
8313
8314 * image.c (Finit_image_library): Return t for built-in image types,
8315 like pbm and xbm. (Bug#8640)
8316
57679c86
AS
83172011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8318
8319 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8320
888c9e86
EZ
83212011-05-07 Eli Zaretskii <eliz@gnu.org>
8322
b0512a1d
EZ
8323 * w32console.c (Fset_screen_color): Doc fix.
8324 (Fget_screen_color): New function.
8325 (syms_of_ntterm): Defsubr it.
8326
7285dc67
EZ
8327 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8328 unlink the temporary file if Fcall_process didn't create it in the
8329 first place.
8330 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8331 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8332 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8333 cue to call_process_cleanup not to close that handle.
8334
4d3fcc8e
BK
83352011-05-07 Ben Key <bkey76@gmail.com>
8336
8337 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8338 one of two shell specific rules, either bootstrap-temacs-CMD or
8339 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8340 to the previous implementation of the bootstrap-temacs rule.
8341 The bootstrap-temacs-CMD rule is similar to the previous
8342 implementation of the bootstrap-temacs rule except that it
8343 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8344 variable.
8345
8346 These changes, along with some changes to nt/configure.bat,
8347 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8348 earlier fix to add support for --cflags and --ldflags options
8349 that include quotes so that it works whether make uses cmd or
8350 sh as the shell.
8351
b4289b64
MA
83522011-05-06 Michael Albinus <michael.albinus@gmx.de>
8353
8354 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8355 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8356 is a constant.
8357 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8358 a string. Handle both cases.
8359 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8360 (Fdbus_register_method): Use Qinvalid_function.
8361
af4c0e28
JB
83622011-05-06 Juanma Barranquero <lekktu@gmail.com>
8363
8364 * makefile.w32-in: Update dependencies.
8365 (LISP_H): Add inttypes.h and stdin.h.
8366 (PROCESS_H): Add unistd.h.
8367
c51453d9
EZ
83682011-05-06 Eli Zaretskii <eliz@gnu.org>
8369
8370 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8371 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8372
8ff0ac3c 83732011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8374
4c4b566b
PE
8375 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8376
aab2b9b5
PE
8377 * term.c (vfatal): Remove stray call to va_end.
8378 It's not needed and the C Standard doesn't allow it here anyway.
8379
c378da0b
PE
8380 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8381 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8382
288b08c7
PE
8383 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8384 bytes.
8385
e3601888
PE
8386 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8387
db6c0e74
PE
8388 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8389
dd5963ea
PE
8390 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8391
88c9450f
PE
8392 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8393
2f9442b8
PE
8394 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8395
c032b5f8
PE
8396 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8397 * charset.c (Fdefine_charset_internal): Don't initialize
8398 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8399 32-bit int (Bug#8600).
a108c10b
PE
8400
8401 * lread.c (read_integer): Be more consistent with string-to-number.
8402 Use string_to_number to do the actual conversion; this avoids
8403 rounding errors and fixes some other screwups. Without this fix,
8404 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8405 (digit_to_number): Move earlier, for benefit of read_integer.
8406 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8407 not a digit in any supported base. (Bug#8602)
a108c10b 8408
ad5f9eea
PE
8409 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8410
aec1708a
PE
8411 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8412 to match comment at start of function. This also removes a
8413 GCC warning about overflow in a 32+64-bit port.
8414
47be4ab5
PE
8415 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8416
371cac43
PE
8417 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8418 Reported by Stefan Monnier in
8419 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8420 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8421 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8422
d01a7826
PE
8423 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8424 (EMACS_UINTPTR): Likewise, with uintptr_t.
8425
7fd47d5c
PE
8426 * lisp.h: Prefer 64-bit EMACS_INT if available.
8427 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8428 on 32-bit hosts that have 64-bit int, so that they can access
8429 large files.
122b0c86
PE
8430 However, temporarily disable this change unless the temporary
8431 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8432
8727937b
PE
8433 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8434
8ac068ac
PE
8435 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8436 This removes an assumption that EMACS_INT and long are the same
8437 width as pointers. The assumption is true for Emacs porting targets
8438 now, but we want to make other targets possible.
8439 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8440 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8441 In the rest of the code, change types of integers that hold casted
8442 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8443 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8444 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8445 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8446 No need to cast type when ORing.
8447 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8448 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8449 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8450 assume EMACS_INT is the same width as char *.
8451 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8452 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8453 Remove no-longer-needed casts.
8454 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8455 (xg_tool_bar_help_callback, xg_make_tool_item):
8456 Use EMACS_INTPTR to hold an integer
8457 that will be cast to void *; this can avoid a GCC warning
8458 if EMACS_INT is not the same width as void *.
8459 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8460 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8461 (current_message_1, set_message_1):
8462 Use a local to convert to proper width without a cast.
8463 * xmenu.c (dialog_selection_callback): Likewise.
8464
ede49d71
PE
8465 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8466 Also, don't assume VALBITS / RAND_BITS is less than 5,
8467 and don't rely on undefined behavior when shifting a 1 left into
8468 the sign bit.
8469 * lisp.h (get_random): Change signature to match.
8470
2f30ecd0
PE
8471 * lread.c (hash_string): Use size_t, not int, for hash computation.
8472 Normally we prefer signed values; but hashing is special, because
8473 it's better to use unsigned division on hash table sizes so that
8474 the remainder is nonnegative. Also, size_t is the natural width
8475 for hashing into memory. The previous code used 'int', which doesn't
8476 retain enough info to hash well into very large tables.
8477 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8478
2a866e7b
PE
8479 * dbusbind.c: Don't possibly lose pointer info when converting.
8480 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8481 Use XPNTR rather than XHASH, so that the high-order bits of
8482 the pointer aren't lost when converting through void *.
8483
51639eac
PE
8484 * eval.c (Fautoload): Don't double-shift a pointer.
8485
92394119
PE
8486 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8487
dbdb9a7c
JB
84882011-05-06 Juanma Barranquero <lekktu@gmail.com>
8489
8490 * gnutls.c (DEF_GNUTLS_FN):
8491 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8492
db7a0b4f
AS
84932011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8494
8495 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8496 marker. (Bug#8610)
8497
cd394be1 84982011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8499
8500 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8501 New version that can reserve upto 2GB of heap space.
8502
f7ff1b0f 85032011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8504
8505 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8506
639c109b
TZ
85072011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8508
8509 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8510 `gnutls_certificate_set_x509_key_file'.
8511
d2127135
JB
85122011-05-05 Juanma Barranquero <lekktu@gmail.com>
8513
8514 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8515 Update dependencies.
8516
e968f4f3
JB
85172011-05-04 Juanma Barranquero <lekktu@gmail.com>
8518
8519 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8520 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8521 Remove unused parameter `fildes'.
8522 * process.c (read_process_output, send_process): Don't pass it.
8523
84d358f0
JB
85242011-05-04 Juanma Barranquero <lekktu@gmail.com>
8525
8526 Fix previous change: the library cache is defined in w32.c.
8527 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8528 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8529
0898ca10
JB
85302011-05-04 Juanma Barranquero <lekktu@gmail.com>
8531
8532 Implement dynamic loading of GnuTLS on Windows.
8533
8534 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8535 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8536 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8537 Declare.
8538
8539 * gnutls.c (Qgnutls_dll): Define.
8540 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8541 (gnutls_*): Declare function pointers.
8542 (init_gnutls_functions): New function to initialize function pointers.
8543 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8544 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8545 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8546 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8547 (emacs_gnutls_write, emacs_gnutls_read)
8548 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8549 (Fgnutls_available_p): New function.
8550 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8551 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8552 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8553
8554 * image.c: Include w32.h.
8555 (Vimage_type_cache): Delete.
8556 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8557 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8558 (w32_delayed_load): Move to w32.c.
8559
8560 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8561
8562 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8563 (w32_delayed_load): Move from image.c. When loading a library, record
8564 its filename in the :loaded-from property of the library id.
8565 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8566 Initialize and staticpro them.
8567 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8568
8569 * process.c: Include lisp.h before w32.h, not after.
8570 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8571 instead of gnutls_record_check_pending.
8572
8573 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8574
ff4de4aa
TZ
85752011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8576
8577 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8578 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8579 as passed in.
8580
abe95abb
JD
85812011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8582
8583 * xterm.c (x_set_frame_alpha): Do not set property on anything
8584 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8585
e16e55d4
JB
85862011-05-02 Juanma Barranquero <lekktu@gmail.com>
8587
8588 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8589
bafcf6a5
JB
85902011-05-02 Juanma Barranquero <lekktu@gmail.com>
8591
8592 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8593 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8594 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8595 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8596 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8597 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8598 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8599 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8600 (Qgnutls_bootprop_callbacks_verify): Make static.
8601
e7a6747f
AS
86022011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8603
19ed11ba
AS
8604 * callproc.c: Indentation fixup.
8605
e7a6747f 8606 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8607 (wait_for_termination, interruptible_wait_for_termination):
8608 Move after wait_for_termination_1.
e7a6747f 8609
1ef14cb4
LMI
86102011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8611
8612 * sysdep.c (interruptible_wait_for_termination): New function
8613 which is like wait_for_termination, but allows keyboard
8614 interruptions.
8615
8616 * callproc.c (Fcall_process): Add (:file "file") as an option for
8617 the STDOUT buffer.
8618 (Fcall_process_region): Ditto.
8619
330d880c
EZ
86202011-04-30 Eli Zaretskii <eliz@gnu.org>
8621
8db90b73
EZ
8622 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8623 rather than `XVECTOR (FOO)->size'.
8624
330d880c
EZ
8625 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8626 inttypes.h, as a gnulib replacement is used if it not available in
8627 system headers.
8628
15cbd324
EZ
86292011-04-21 Eli Zaretskii <eliz@gnu.org>
8630
8631 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8632 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8633 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8634
8635 * coding.c (coding_alloc_by_realloc): Error out if destination
8636 will grow beyond MOST_POSITIVE_FIXNUM.
8637 (decode_coding_emacs_mule): Abort if there isn't enough place in
8638 charbuf for the composition carryover bytes. Reserve an extra
8639 space for up to 2 characters produced in a loop.
8640 (decode_coding_iso_2022): Abort if there isn't enough place in
8641 charbuf for the composition carryover bytes.
8642
86432011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8644
ae940cca
EZ
8645 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8646 aborting when %lld or %lll format is passed.
8647 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8648 %llo or %llx format is passed. (Bug#8545)
8649
03ab8921
EZ
8650 * window.c (window_scroll_line_based): Use a marker instead of
8651 simple variables to record original value of point. (Bug#7952)
8652
afda1437
EZ
8653 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8654 produced by %s or %c overflows available buffer space. (Bug#8545)
8655
f76dee0c
PE
86562011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8657
8658 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8659 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8660
fdc5744d
JB
86612011-04-28 Juanma Barranquero <lekktu@gmail.com>
8662
8663 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8664
638f053a
JB
86652011-04-28 Juanma Barranquero <lekktu@gmail.com>
8666
8667 * keyboard.c (Qdelayed_warnings_hook): Define.
8668 (command_loop_1): Run `delayed-warnings-hook'
8669 if Vdelayed_warnings_list is non-nil.
8670 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8671 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8672
d178f871
EZ
86732011-04-28 Eli Zaretskii <eliz@gnu.org>
8674
8675 * doprnt.c (doprnt): Don't return value smaller than the buffer
8676 size if the message was truncated. (Bug#8545).
8677
b124fd93
JB
86782011-04-28 Juanma Barranquero <lekktu@gmail.com>
8679
8680 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8681 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8682
e810457d
PE
86832011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8684
8685 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8686
ea51cceb
JB
86872011-04-27 Juanma Barranquero <lekktu@gmail.com>
8688
8689 * makefile.w32-in: Update dependencies.
8690
94dcfacf
EZ
86912011-04-27 Eli Zaretskii <eliz@gnu.org>
8692
8693 Improve `doprnt' and its usage. (Bug#8545)
8694 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8695 `format_end'. Remove support for %l as a conversion specifier.
8696 Don't use xrealloc. Improve diagnostics when the %l size modifier
8697 is used. Update the commentary.
8698
8699 * eval.c (verror): Simplify calculation of size_t.
8700
8701 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8702 messages.
8703
f61f41d7
PE
87042011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8705
8706 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8707 change.
8708
96fb4434
PE
87092011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8710
8711 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8712 This makes this file independent of the recent pseudovector change.
8713
671875da 87142011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 8715
69e9b5a3
PE
8716 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8717
b5f869a7 8718 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 8719 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 8720 Remove unused local.
c8926152 8721 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 8722
841a1577 8723 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
8724 GCC 4.6.0 optimizes based on type-based alias analysis.
8725 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
8726 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8727 != &v->size, and therefore "v->size = 1; b->size = 2; return
8728 v->size;" must therefore return 1. This assumption is incorrect
8729 for Emacs, since it type-puns struct Lisp_Vector * with many other
8730 types. To fix this problem, this patch adds a new type struct
f904488f 8731 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
8732 and pseudovectors, and helps optimizing compilers not get fooled
8733 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8734 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
8735 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8736 the size member.
eab3844f
PE
8737 (XSETPVECTYPE): Rewrite in terms of new macro.
8738 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8739 This is a bit clearer, and further avoids the possibility of
8740 undesirable aliasing.
8741 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 8742 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
8743 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8744 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
8745 (ASIZE): Now uses header.size rather than size.
8746 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
8747 to avoid the hassle of writing XVECTOR (foo)->header.size.
8748 (struct vectorlike_header): New type.
eab3844f
PE
8749 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8750 object, to help avoid aliasing.
8751 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8752 (SUBRP): Likewise, since Lisp_Subr is a special case.
8753 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8754 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8755 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 8756 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
8757 changed to be "header.size" and "header.next".
8758 * buffer.h (struct buffer): Likewise.
8759 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8760 * frame.h (struct frame): Likewise.
8761 * process.h (struct Lisp_Process): Likewise.
8762 * termhooks.h (struct terminal): Likewise.
8763 * window.c (struct save_window_data, struct saved_window): Likewise.
8764 * window.h (struct window): Likewise.
8765 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8766 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8767 * buffer.c (init_buffer_once): Likewise.
8768 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8769 special case.
8770 * process.c (Fformat_network_address): Use local var for size,
8771 for brevity.
8772
0df1eac5
PE
8773 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8774
847ab9d1 8775 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
8776 * data.c (atof): Remove decl; no longer used or needed.
8777 (digit_to_number): Move to lread.c.
8778 (Fstring_to_number): Use new string_to_number function, to be
8779 consistent with how the Lisp reader treats infinities and NaNs.
8780 Do not assume that floating-point numbers represent EMACS_INT
8781 without losing information; this is not true on most 64-bit hosts.
8782 Avoid double-rounding errors, by insisting on integers when
8783 parsing non-base-10 numbers, as the documentation specifies.
8784 * lisp.h (string_to_number): New decl, replacing ...
8785 (isfloat_string): Remove.
bc0a5c13 8786 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 8787 (read1): Do not accept +. and -. as integers; this
452f4150
PE
8788 appears to have been a coding error. Similarly, do not accept
8789 strings like +-1e0 as floating point numbers. Do not report
8790 overflow for integer overflows unless the base is not 10 which
8791 means we have no simple and reliable way to continue.
8792 Break out the floating-point parsing into a new
8793 function string_to_number, so that Fstring_to_number parses
8794 floating point numbers consistently with the Lisp reader.
04f2d78b 8795 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
8796 (E_CHAR, EXP_INT): Remove, replacing with ...
8797 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8798 (string_to_number): New function, replacing isfloat_string.
8799 This function checks for valid syntax and produces the resulting
8800 Lisp float number too. Rework it so that string-to-number
bc0a5c13 8801 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
8802 so that overflow for non-base-10 numbers is reported only when
8803 there's no portable and simple way to convert to floating point.
452f4150 8804
67769ffc
PE
8805 * textprop.c (set_text_properties_1): Rewrite for clarity,
8806 and to avoid GCC warning about integer overflow.
8807
c20db43f
PE
8808 * intervals.h (struct interval): Use EMACS_INT for members
8809 where EMACS_UINT might cause problems. See
8810 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8811 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8812 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8813 All uses changed.
37aa2f85
PE
8814 (offset_intervals): Tell GCC not to worry about length overflow
8815 when negating a negative length.
c20db43f 8816
2538aa2f
PE
8817 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8818 (overrun_check_free): Likewise.
8819
f2d3008d
PE
8820 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8821 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8822 word size.
8823
ec8df744
PE
8824 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8825 (gnutls_make_error): Rename local to avoid shadowing.
8826 (gnutls_emacs_global_deinit): ifdef out; not used.
8827 (Fgnutls_boot): Use const for pointer to readonly storage.
8828 Comment out unused local. Fix pointer signedness problems.
8829
640ee02d
PE
8830 * lread.c (openp): Don't stuff size_t into an 'int'.
8831 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8832 about possible signed overflow.
8833
6048fb2a
PE
8834 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8835 (GDK_KEY_g): Don't define if already defined.
8836 (xg_prepare_tooltip): Avoid pointer signedness problem.
8837 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8838
fa3c87e1
PE
8839 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8840 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8841
2172544b
PE
8842 * xfns.c (Fx_window_property): Simplify a bit,
8843 to make a bit faster and to avoid GCC 4.6.0 warning.
8844 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8845
9b821a21
PE
8846 * fns.c (internal_equal): Don't assume size_t fits in int.
8847
3c616cfa
PE
8848 * alloc.c (compact_small_strings): Tighten assertion a little.
8849
c2982e87
PE
8850 Replace pEd with more-general pI, and fix some printf arg casts.
8851 * lisp.h (pI): New macro, generalizing old pEd macro to other
8852 conversion specifiers. For example, use "...%"pI"d..." rather
8853 than "...%"pEd"...".
8854 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 8855 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
8856 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8857 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8858 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8859 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8860 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8861 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8862 64-bit hosts.
8863 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8864 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8865 * print.c (safe_debug_print, print_object): Likewise.
8866 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8867 to int.
6f04d126
PE
8868 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8869 avoiding the 0 flag, which is not portable.
c2982e87
PE
8870 * process.c (Fmake_network_process): Use pI to avoid cast.
8871 * region-cache.c (pp_cache): Likewise.
8872 * xdisp.c (decode_mode_spec): Likewise.
8873 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8874 behavior on 64-bit hosts with printf arg.
6f04d126 8875 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
8876 (x_stop_queuing_selection_requests): Likewise.
8877 (x_get_window_property): Don't truncate byte count to an 'int'
8878 when tracing.
0b432f21 8879
5e073ec7
PE
8880 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8881 here, since it parses constructs like leading '-' and spaces,
8882 which are not wanted; and it overflows with large numbers.
8883 Instead, simply match F[0-9]+, which is what is wanted anyway.
8884
36372bf9
PE
8885 * alloc.c: Remove unportable assumptions about struct layout.
8886 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8887 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8888 (allocate_vectorlike, make_pure_vector): Use the new macros,
8889 plus offsetof, to remove unportable assumptions about struct layout.
8890 These assumptions hold on all porting targets that I know of, but
8891 they are not guaranteed, they're easy to remove, and removing them
8892 makes further changes easier.
8893
0b432f21
PE
8894 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8895 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
8896 (string_overrun_cookie): Now const. Use initializers that
8897 don't formally overflow signed char, to avoid warnings.
000098c1
PE
8898 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8899 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
8900 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8901 multiple of sizeof (EMACS_INT); it need not be, if
8902 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 8903 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 8904
895009e1
JB
89052011-04-26 Juanma Barranquero <lekktu@gmail.com>
8906
8907 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8908
6a7a1b0b
TZ
89092011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8910
8911 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 8912 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
8913 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8914
841a1577 89152011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
8916
8917 * lisp.h (Qdebug): List symbol.
895009e1 8918 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
8919 * keyboard.c (debug-on-event): New variable.
8920 (handle_user_signal): Break into debugger when debug-on-event
8921 matches the current signal symbol.
8922
f2d3ba6f
DN
89232011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8924
8925 * alloc.c (check_sblock, check_string_bytes)
8926 (check_string_free_list): Convert to standard C.
8927
42ce4c63
TZ
89282011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8929
8930 * w32.c (emacs_gnutls_push): Fix typo.
8931
825cd63c
EZ
89322011-04-25 Eli Zaretskii <eliz@gnu.org>
8933
fb11d64d
EZ
8934 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8935 "cast to pointer from integer of different size".
8936
825cd63c
EZ
8937 Improve doprnt and its use in verror. (Bug#8545)
8938 * doprnt.c (doprnt): Document the set of format control sequences
8939 supported by the function. Use SAFE_ALLOCA instead of always
8940 using `alloca'.
8941
8942 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8943 is one byte too soon. Don't use xrealloc; instead xfree and
8944 xmalloc anew.
8945
e061a11b
TZ
89462011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8947
8948 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8949 callbacks stage.
8950
8951 * gnutls.c: Renamed global_initialized to
8952 gnutls_global_initialized. Added internals for the
8953 :verify-hostname-error, :verify-error, and :verify-flags
8954 parameters of `gnutls-boot' and documented those parameters in the
8955 docstring. Start callback support.
9173deec
JB
8956 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8957 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8958 on error. Return error code.
e061a11b
TZ
8959 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8960 (emacs_gnutls_read): Likewise.
8961 (Fgnutls_boot): Return handshake error code.
8962 (emacs_gnutls_handle_error): New function.
8963 (wsaerror_to_errno): Likewise.
8964
8965 * w32.h (emacs_gnutls_pull): Add prototype.
8966 (emacs_gnutls_push): Likewise.
8967
8968 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8969 (emacs_gnutls_push): Likewise.
8970
89712011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8972
8973 * process.c (wait_reading_process_output): Check if GnuTLS
8974 buffered some data internally if no FDs are set for TLS
8975 connections.
8976
8977 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8978 (LIBS): Link to USER_LIBS.
8979 ($(BLD)/gnutls.$(0)): New target.
8980
fa6996bc
EZ
89812011-04-24 Eli Zaretskii <eliz@gnu.org>
8982
eb35682e
EZ
8983 * xdisp.c (handle_single_display_spec): Rename the
8984 display_replaced_before_p argument into display_replaced_p, to
8985 make it consistent with the commentary. Fix typos in the
8986 commentary.
8987
e2ad650c
EZ
8988 * textprop.c (syms_of_textprop): Remove dead code.
8989 (copy_text_properties): Delete obsolete commentary about an
8990 interface that was deleted long ago. Fix typos in the description
8991 of arguments.
8992
1b2de274
EZ
8993 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8994 to changes in oldXMenu/XMenu.h from 2011-04-16.
8995 <menu_help_message, prev_menu_help_message>: Constify.
8996 (IT_menu_make_room): menu->help_text is now `const char **';
8997 adjust.
8998
8999 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9000 to changes in oldXMenu/XMenu.h from 2011-04-16.
9001 (struct XMenu): Declare `help_text' `const char **'.
9002
9003 * xfaces.c <Qunspecified>: Make extern again.
9004
9005 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9006 required by POSIX.
1b2de274 9007
762b15be
EZ
9008 * doc.c (get_doc_string): Improve the format passed to `error'.
9009
9010 * doprnt.c (doprnt): Improve commentary.
9011
9012 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9013
9014 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9015 them with etags.
9016
f1052e5d
EZ
9017 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9018 changes in globals.h immediately force recompilation.
762b15be
EZ
9019 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9020 $(CURDIR)/s/ms-w32.h.
9021 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9022
fa6996bc
EZ
9023 * character.c (Fchar_direction): Function deleted.
9024 (syms_of_character): Don't defsubr it.
9025 <char-direction-table>: Deleted.
9026
e6c3da20
EZ
90272011-04-23 Eli Zaretskii <eliz@gnu.org>
9028
9029 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9030 * doprnt.c: Include limits.h.
9031 (SIZE_MAX): New macro.
04f2d78b
CB
9032 (doprnt): Return a size_t value. 2nd arg is now size_t.
9033 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9034 Improve overflow protection. Support `l' modifier for integer
9035 conversions. Support %l conversion. Don't assume an EMACS_INT
9036 argument for integer conversions and for %c.
9037
9038 * lisp.h (doprnt): Restore prototype.
9039
9040 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9041 $(SRC)/character.h.
9042
9043 * Makefile.in (base_obj): Add back doprnt.o.
9044
9045 * deps.mk (doprnt.o): Add back prerequisites.
9046 (callint.o): Depend on character.h.
9047
9048 * eval.c (internal_lisp_condition_case): Include the handler
9049 representation in the error message.
9050 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9051 when breaking from the loop.
9052
9053 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9054
9055 * callint.c (Fcall_interactively): When displaying error message
9056 about invalid control letter, pass the character's codepoint, not
9057 a pointer to its multibyte form. Improve display of the character
9058 in octal and display also its hex code.
9059
9060 * character.c (char_string): Use %x to display the (unsigned)
9061 codepoint of an invalid character, to avoid displaying a bogus
9062 negative value.
9063
9064 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9065 `error', not SYMBOL_NAME itself.
9066
9067 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9068 character arguments to `error'.
9069
9070 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9071 to `error' in error message about FINAL_CHAR argument. Make sure
9072 FINAL_CHAR is a character, and use %c when it is passed as
9073 argument to `error'.
9074
4ffd0d6b 90752011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9076
9077 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9078
9079 * w32.c: Include <time.h>.
9080 (sys_localtime): New function.
9081
4ffd0d6b 90822011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9083
9084 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9085
4ffd0d6b 9086 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9087
4ffd0d6b 90882011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9089
4ffd0d6b
GM
9090 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9091 zombies (Bug#8467).
aac0c6e3 9092
04c56954
EZ
90932011-04-19 Eli Zaretskii <eliz@gnu.org>
9094
9095 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9096 gl_state.e_property when gl_state.object is Qt.
9097
9098 * insdel.c (make_gap_larger): Remove limitation of buffer size
9099 to <= INT_MAX.
9100
16a43933
CY
91012011-04-18 Chong Yidong <cyd@stupidchicken.com>
9102
9103 * xdisp.c (lookup_glyphless_char_display)
9104 (produce_glyphless_glyph): Handle cons cell entry in
9105 glyphless-char-display.
9106 (Vglyphless_char_display): Document it.
9107
9108 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9109 glyphless-char-display.
9110
4581706e
CY
91112011-04-17 Chong Yidong <cyd@stupidchicken.com>
9112
9113 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9114
9115 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9116
9117 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9118 definition for no-X builds.
9119
4887c6e2 91202011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9121
fd35b6f9
PE
9122 Static checks with GCC 4.6.0 and non-default toolkits.
9123
5c1ccb01
PE
9124 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9125
006c5daa
PE
9126 * process.c (keyboard_bit_set): Define only if SIGIO.
9127 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9128 (send_process): Repair possible setjmp clobbering.
9129
efc736d3
PE
9130 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9131
4e2fe2e6
PE
9132 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9133
f97334a2
PE
9134 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9135
4e75f29d
PE
9136 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9137 Define only if needed.
9138
90efadd1
PE
9139 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9140 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9141 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9142
3c647824
PE
9143 * dispextern.h (struct redisplay_interface): Rename param
9144 to avoid shadowing.
e264f262 9145 * termhooks.h (struct terminal): Likewise.
761383f4 9146 * xterm.c (xembed_send_message): Likewise.
3c647824 9147
b58c5c4a
PE
9148 * insdel.c (make_gap_smaller): Define only if
9149 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9150
cad59032
PE
9151 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9152 it.
9153
c339dc2e
PE
9154 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9155 so that we aren't warned about unused symbols.
9156
91a3e27b
PE
9157 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9158
399c71d3 9159 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9160
8ffc96f5
PE
9161 * xfns.c (x_real_positions): Mark locals as initialized.
9162
eef9bc79
PE
9163 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9164
098db9dd
PE
9165 * xterm.c: Fix problems found by static analysis with other toolkits.
9166 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9167 (x_dispatch_event): Declare static if USE_GTK, and
9168 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9169 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9170 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9171 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9172 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9173
eb18f6cc
PE
9174 * xmenu.c (menu_help_callback): Pointer type fixes.
9175 Use const pointers when pointing at readonly data. Avoid pointer
9176 signedness clashes.
9177 (FALSE): Remove unused macro.
9178 (update_frame_menubar): Remove unused decl.
9179
1fe72bf8
PE
9180 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9181
60d9e1db
PE
9182 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9183 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9184 (single_menu_item): Rename local to avoid shadowing.
9185
39261c26
PE
9186 * keyboard.c (make_lispy_event): Remove unused local var.
9187
018c5e19
PE
9188 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9189 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9190
63d2b86e
PE
9191 * bitmaps: Change bitmaps from unsigned char back to the X11
9192 compatible char. Avoid the old compiler warnings about
9193 out-of-range initializers by using, for example, '\xab' rather
9194 than 0xab.
9195
aefd87e1
PE
9196 * xgselect.c (xgselect_initialize): Check vs interface
9197 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9198
bf501fb9
PE
9199 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9200
e9829fdf
PE
9201 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9202 to read-only memory.
9203
1086c095
PE
9204 * fns.c (vector): Remove; this old hack is no longer needed.
9205
2baccd04 9206 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9207 Remove unused var.
dde42981 9208 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9209
72391843 9210 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9211
436c16df 9212 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9213 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9214 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9215
92bb796d 9216 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9217 (x_term_init): Remove local to avoid shadowing.
92bb796d 9218
764430a3 9219 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9220
9221 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9222 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9223
d1dfb56c
EZ
92242011-04-16 Eli Zaretskii <eliz@gnu.org>
9225
c4354cb4
EZ
9226 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9227
d1dfb56c
EZ
9228 Fix regex.c, syntax.c and friends for buffers > 2GB.
9229 * syntax.h (struct gl_state_s): Declare character position members
9230 EMACS_INT.
9231
9232 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9233
04f2d78b
CB
9234 * textprop.c (verify_interval_modification, interval_of):
9235 Declare arguments EMACS_INT.
d1dfb56c
EZ
9236
9237 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9238 EMACS_INT.
9239
9240 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9241
9242 * indent.c (Fvertical_motion): Local variable it_start is now
9243 EMACS_INT.
9244
9245 * regex.c (re_match, re_match_2, re_match_2_internal)
9246 (bcmp_translate, regcomp, regexec, print_double_string)
9247 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9248 (re_compile_pattern, re_exec): Declare arguments and local
9249 variables `size_t' and `ssize_t' and return values `regoff_t', as
9250 appropriate.
9251 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9252 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9253 <compile_stack_type>: `size' and `avail' are now `size_t'.
9254
9255 * regex.h <regoff_t>: Use ssize_t, not int.
9256 (re_search, re_search_2, re_match, re_match_2): Arguments that
9257 specify buffer/string position and length are now ssize_t and
9258 size_t. Return type is regoff_t.
9259
613052cd
BK
92602011-04-16 Ben Key <bkey76@gmail.com>
9261
9262 * nsfont.m: Fixed bugs in ns_get_family and
9263 ns_descriptor_to_entity that were caused by using free to
9264 deallocate memory blocks that were allocated by xmalloc (via
9265 xstrdup). This caused Emacs to crash when compiled with
9266 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9267 --enable-checking=xmallocoverrun). xfree is now used to
9268 deallocate these memory blocks.
9269
4170f62f 92702011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9271
71b41406
PE
9272 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9273
9587a89d
PE
9274 emacs_write: Accept and return EMACS_INT for sizes.
9275 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9276 et seq.
9277 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9278 Accept and return EMACS_INT.
9279 (emacs_gnutls_write): Return the number of bytes written on
9280 partial writes.
9281 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9282 (emacs_read, emacs_write): Remove check for negative size, as the
9283 Emacs source code has been audited now.
9587a89d
PE
9284 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9285 (emacs_read, emacs_write): Use it.
273a5f82
PE
9286 * process.c (send_process): Adjust to the new signatures of
9287 emacs_write and emacs_gnutls_write. Do not attempt to store
9288 a byte offset into an 'int'; it might overflow.
9587a89d 9289 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9290
3e047f51
PE
9291 * sound.c: Don't assume sizes fit in 'int'.
9292 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9293 Return EMACS_INT, not int.
3e047f51 9294 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9295 Accept EMACS_INT, not int.
9296 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9297 record read return values.
9298
cc39a9db
BK
92992011-04-15 Ben Key <bkey76@gmail.com>
9300
c9d0ec6d
JB
9301 * keyboard.c (Qundefined): Don't declare static since it is used
9302 in nsfns.m.
9303 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9304 static since they are used in nsfont.m.
cc39a9db 9305
6c60eb9f
SM
93062011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9307
9308 * process.c (Qprocessp): Don't declare static.
9309 * lisp.h (Qprocessp): Declare again.
9310
7990b61a
JB
93112011-04-15 Juanma Barranquero <lekktu@gmail.com>
9312
9313 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9314
5d4cb038
PE
93152011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9316
8bd7b830 9317 Improve C-level modularity by making more things 'static'.
cd64ea1d 9318
e3b27b31
PE
9319 Don't publish debugger-only interfaces to other modules.
9320 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9321 (verify_bytepos, count_markers): Move decls to the only modules
9322 that need them.
9323 * region-cache.h (pp_cache): Likewise.
9324 * window.h (check_all_windows): Likewise.
9325 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9326
5d4cb038
PE
9327 * sysdep.c (croak): Now static, if
9328 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9329 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9330
9331 * alloc.c (refill_memory_reserve): Now static if
9332 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9333 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9334
e87b6180
PE
9335 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9336 Define only if USE_LUCID.
9337
ac64929e
PE
9338 * xrdb.c (x_customization_string, x_rm_string): Now static.
9339
6f37259d
PE
9340 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9341 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9342
1683e3ab
PE
9343 * xdisp.c (draw_row_with_mouse_face): Now static.
9344 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9345
de9c2632
PE
9346 * window.h (check_all_windows): Mark externally visible.
9347
2b96acb7
PE
9348 * window.c (window_deletion_count): Now static.
9349
9350 * undo.c: Make symbols static if they're not exported.
9351 (last_undo_buffer, last_boundary_position, pending_boundary):
9352 Now static.
9353
50436f33
PE
9354 * textprop.c (interval_insert_behind_hooks): Now static.
9355 (interval_insert_in_front_hooks): Likewise.
9356
64520e5c
PE
9357 * term.c: Make symbols static if they're not exported.
9358 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9359 (max_frame_lines, tty_set_terminal_modes):
9360 (tty_reset_terminal_modes, tty_turn_off_highlight):
9361 (get_tty_terminal): Now static.
9362 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9363 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9364 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9365 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9366 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9367
1fa53021
PE
9368 * sysdep.c: Make symbols static if they're not exported.
9369 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9370 Now static.
9371 (sigprocmask_set, full_mask): Remove; unused.
9372 (wait_debugging): Mark as visible.
9373 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9374 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9375
d4b43b22
PE
9376 * syntax.c (syntax_temp): Define only if !__GNUC__.
9377
b7c513d0
PE
9378 * sound.c (current_sound_device, current_sound): Now static.
9379
989b29ad
PE
9380 * search.c (searchbufs, searchbuf_head): Now static.
9381
13a55a78
PE
9382 * scroll.c (scroll_cost): Remove; unused.
9383 * dispextern.h (scroll_cost): Remove decl.
9384
de68a1fc
PE
9385 * region-cache.h (pp_cache): Mark as externally visible.
9386
40ccffa6
PE
9387 * process.c: Make symbols static if they're not exported.
9388 (process_tick, update_tick, create_process, chan_process):
9389 (Vprocess_alist, proc_buffered_char, datagram_access):
9390 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9391 (deactivate_process): Mark defn as static, as well as decl.
9392 * lisp.h (create_process): Remove decl.
9393 * process.h (chan_process, Vprocess_alist): Remove decls.
9394
ad64fc97
PE
9395 * print.c: Make symbols static if they're not exported.
9396 (print_depth, new_backquote_output, being_printed, print_buffer):
9397 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9398 (print_interval, print_number_index, initial_stderr_stream):
9399 Now static.
9400 * lisp.h (Fprinc): Remove decl.
9401 (debug_output_compilation_hack): Mark as externally visible.
9402
adddb265
PE
9403 * sysdep.c (croak): Move decl from here to syssignal.h.
9404 * syssignal.h (croak): Put it here, so the API can be checked when
9405 'croak' is called from dissociate_if_controlling_tty.
9406
1717ede2
PE
9407 * minibuf.c: Make symbols static if they're not exported.
9408 (minibuf_save_list, choose_minibuf_frame): Now static.
9409 * lisp.h (choose_minibuf_frame): Remove decl.
9410
fa5fb2bc
PE
9411 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9412
1e3890d1
PE
9413 * lread.c: Make symbols static if they're not exported.
9414 (read_objects, initial_obarray, oblookup_last_bucket_number):
9415 Now static.
9416 (make_symbol): Remove; unused.
9417 * lisp.h (initial_obarray, make_symbol): Remove decls.
9418
8a1414fa
PE
9419 * keyboard.c: Make symbols static if they're not exported.
9420 (single_kboard, recent_keys_index, total_keys, recent_keys):
9421 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9422 (this_single_command_key_start, echoing, last_auto_save):
9423 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9424 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9425 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9426 (Vlispy_mouse_stem, double_click_count):
9427 Now static.
9428 (force_auto_save_soon): Define only if SIGDANGER.
9429 (ignore_mouse_drag_p): Now static if
9430 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9431 (print_help): Remove; unused.
9432 (stop_character, last_timer_event): Mark as externally visible.
9433 * keyboard.h (ignore_mouse_drag_p): Declare only if
9434 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9435 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9436 * lisp.h (echoing): Remove decl.
9437 (force_auto_save_soon): Declare only if SIGDANGER.
9438 * xdisp.c (redisplay_window): Simplify code, to make it more
9439 obvious that ignore_mouse_drag_p is not accessed if !defined
9440 USE_GTK && !defined HAVE_NS.
9441
93ea6e8f
PE
9442 * intervals.c: Make symbols static if they're not exported.
9443 (merge_properties_sticky, merge_interval_right, delete_interval):
9444 Now static.
9445 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9446
77382fcc
PE
9447 * insdel.c: Make symbols static if they're not exported.
9448 However, leave prepare_to_modify_buffer alone. It's never
9449 called from outside this function, but that appears to be a bug.
9450 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9451 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9452 (adjust_after_replace_noundo): Remove; unused.
9453 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9454 (signal_before_change): Remove decls.
77382fcc 9455
9306c32e
PE
9456 * indent.c (val_compute_motion, val_vmotion): Now static.
9457
cd44d2eb
PE
9458 * image.c: Make symbols static if they're not exported.
9459 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9460 if USE_GTK.
9461 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9462 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9463
ad9a7a06
PE
9464 * fringe.c (standard_bitmaps): Now static.
9465 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9466
81626931
PE
9467 * frame.c: Make symbols static if they're not exported.
9468 (x_report_frame_params, make_terminal_frame): Now static.
9469 (get_frame_param): Now static, unless HAVE_NS.
9470 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9471 (x_get_resource_string): Remove; not used.
9472 * frame.h (make_terminal_frame, x_report_frame_params):
9473 (x_get_resource_string); Remove decls.
9474 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9475 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9476
239f9db9
PE
9477 * font.c, fontset.c: Make symbols static if they're not exported.
9478 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9479 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9480 * font.c (font_close_object): Now static.
9481 * font.h (font_close_object): Remove.
9482 * fontset.c (FONTSET_OBJLIST): Remove.
9483 (free_realized_fontset) #if-0 the body, which does nothing.
9484 (face_suitable_for_char_p): #if-0, as it's never called.
9485 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9486 * xfaces.c (face_at_string_position):
9487 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9488 since 0 is always ASCII.
9489
dfcf3579
PE
9490 * fns.c (weak_hash_tables): Now static.
9491
5045092b
PE
9492 * fileio.c: Make symbols static if they're not exported.
9493 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9494 (Vwrite_region_annotation_buffers): Now static.
9495
57a96f5c
PE
9496 * eval.c: Make symbols static if they're not exported.
9497 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9498 * lisp.h (backtrace_list): Remove decl.
9499
35f08c38
PE
9500 * emacs.c: Make symbols static if they're not exported.
9501 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9502 (fatal_error_code, fatal_error_signal_hook, standard_args):
9503 Now static.
9504 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9505 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9506 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9507 * lisp.h (fatal_error_signal_hook): Remove decl.
9508 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9509
f44bd759
PE
9510 * editfns.c: Move a (normally-unused) function to its only use.
9511 * editfns.c, lisp.h (get_operating_system_release): Remove.
9512 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9513 worth the hassle of breaking this out.
9514
b532497d
PE
9515 * xterm.c: Make symbols static if they're not exported.
9516 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9517 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9518 (x_destroy_window, x_delete_display):
9519 Now static.
9520 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9521 (x_mouse_leave): Remove; unused.
9522 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9523 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9524 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9525 Remove decls.
9526 (x_mouse_leave): Declare only if WINDOWSNT.
9527 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9528 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9529 USE_X_TOOLKIT.
9530
1675728f
PE
9531 * ftxfont.c: Make symbols static if they're not exported.
9532 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9533 HAVE_FREETYPE.
9534 * font.h (ftxfont_driver): Likewise.
9535
e4cebfca
PE
9536 * xfns.c: Make symbols static if they're not exported.
9537 (x_last_font_name, x_display_info_for_name):
9538 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9539 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9540 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9541 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9542 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9543 (last_show_tip_args): Now static.
9544 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9545 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9546 (x_screen_planes): Remove; unused.
9547 * dispextern.h (x_screen_planes): Remove decl.
9548
5bf46f05
PE
9549 * dispnew.c: Make symbols static if they're not exported.
9550 * dispextern.h (redraw_garbaged_frames, scrolling):
9551 (increment_row_positions): Remove.
9552 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9553 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9554 Now static.
9555 (redraw_garbaged_frames): Remove; unused.
9556
435f4c28
PE
9557 * xfaces.c: Make symbols static if they're not exported.
9558 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9559 Remove decls.
9560 * xterm.h (defined_color): Remove decls.
9561 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9562 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9563 (menu_face_changed_default, defined_color, free_realized_face):
9564 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9565 (ascii_face_of_lisp_face): Remove; unused.
9566
8524aef3
PE
9567 * xdisp.c: Make symbols static if they're not exported.
9568 * dispextern.h (scratch_glyph_row, window_box_edges):
9569 (glyph_to_pixel_coords, set_cursor_from_row):
9570 (get_next_display_element, set_iterator_to_next):
9571 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9572 (show_mouse_face): Remove decls
9573 * frame.h (message_buf_print): Likewise.
9574 * lisp.h (pop_message, set_message, check_point_in_composition):
9575 Likewise.
9576 * xterm.h (set_vertical_scroll_bar): Likewise.
9577 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9578 (message_buf_print, scratch_glyph_row, displayed_buffer):
9579 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9580 (get_next_display_element, show_mouse_face, window_box_edges):
9581 (frame_to_window_pixel_xy, check_point_in_composition):
9582 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9583 (glyph_to_pixel_coords): Remove; unused.
9584
16390cd2
PE
9585 * dired.c (file_name_completion): Now static.
9586
9587 * dbusbind.c (xd_in_read_queued_messages): Now static.
9588
a25f4dfa
PE
9589 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9590 * data.c (circular_list_error): Remove.
9591
14a9c8df
PE
9592 * commands.h (last_point_position, last_point_position_buffer):
9593 (last_point_position_window): Remove decls.
9594 * keyboard.c: Make these variables static.
9595
04f2d78b
CB
9596 * coding.h (coding, code_convert_region, encode_coding_gap):
9597 Remove decls.
74ab6df5
PE
9598 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9599 (iso_code_class, detect_coding, code_convert_region): Now static.
9600 (encode_coding_gap): Remove; unused.
9601
38dfbee1
PE
9602 * chartab.c (chartab_chars, chartab_bits): Now static.
9603
a2cb4e63
PE
9604 * charset.h (charset_iso_8859_1): Remove decl.
9605 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9606 Now static.
9607
127198fd
PE
9608 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9609 * ccl.c (Vccl_program_table): Now static.
9610 (check_ccl_update): Remove; unused.
9611
d85b608f
PE
9612 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9613 * category.h: ... from here.
9614 * category.c (check_category_table, set_category_set): Now static.
9615
31cd66f3
PE
9616 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9617 * lisp.h: Remove these decls.
9618
c358e587
PE
9619 * buffer.c (buffer_count): Remove unused var.
9620
e78aecca
PE
9621 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9622 so that it's not optimized away.
9623 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9624 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9625 exported only to the debugger.
9626
e192d7d3 9627 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9628 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9629
92470028
PE
9630 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9631 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9632 was inaccessible from Lisp.
9633 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9634 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9635
244ed907
PE
9636 alloc.c: Import and export fewer symbols, and remove unused items.
9637 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9638 is defined.
9639 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9640 it's not optimized away by whole-program optimization.
9641 (message_enable_multibyte, free_misc): Remove.
9642 (catchlist, handlerlist, mark_backtrace):
9643 Declare only if BYTE_MARK_STACK.
9644 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9645 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9646 (message_enable_multibyte): Remove decl.
9647 (free_misc, interval_free_list, float_block, float_block_index):
9648 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9649 (cons_free_list, last_marked_index):
9650 Now static.
9651 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9652 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9653 (mark_backtrace): Define only if BYTE_MARK_STACK.
9654 * xdisp.c (message_enable_multibyte): Now static.
9655
61c2b50e 9656 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9657 This makes it easier for human readers (and static analyzers)
9658 to see whether these variables are used from other modules.
9659 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9660 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9661 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9662 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9663 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9664 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9665 * xmenu.c, xselect.c:
9666 Declare Q* vars static if they are not used in other modules.
9667 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9668 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9669 Remove decls of unexported vars.
9670 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9671
95c82688
PE
9672 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9673
16a97296
PE
9674 Make Emacs functions such as Fatom 'static' by default.
9675 This makes it easier for human readers (and static analyzers)
9676 to see whether these functions can be called from other modules.
9677 DEFUN now defines a static function. To make the function external
9678 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9679 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9680 (Finit_image_library):
16a97296
PE
9681 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9682 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9683 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9684 Remove decls, since these functions are now static.
9685 (Funintern, Fget_internal_run_time): New decls, since these functions
9686 were already external.
95c82688 9687
16a97296
PE
9688 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9689 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9690 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9691 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9692 * keyboard.c, keymap.c, lread.c:
9693 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9694 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9695 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9696 Mark functions with DEFUE instead of DEFUN,
9697 if they are used in other modules.
9698 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9699 decls for now-static functions.
9700 * buffer.h (Fdelete_overlay): Remove decl.
9701 * callproc.c (Fgetenv_internal): Mark as internal.
9702 * composite.c (Fremove_list_of_text_properties): Remove decl.
9703 (Fcomposition_get_gstring): New forward static decl.
9704 * composite.h (Fcomposite_get_gstring): Remove decl.
9705 * dired.c (Ffile_attributes): New forward static decl.
9706 * doc.c (Fdocumntation_property): New forward static decl.
9707 * eval.c (Ffetch_bytecode): New forward static decl.
9708 (Funintern): Remove extern decl; now in .h file where it belongs.
9709 * fileio.c (Fmake_symbolic_link): New forward static decl.
9710 * image.c (Finit_image_library): New forward static decl.
9711 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9712 * intervals.h (Fprevious_property_change):
9713 (Fremove_list_of_text_properties): Remove decls.
9714 * keyboard.c (Fthis_command_keys): Remove decl.
9715 (Fcommand_execute): New forward static decl.
9716 * keymap.c (Flookup_key): New forward static decl.
9717 (Fcopy_keymap): Now static.
9718 * keymap.h (Flookup_key): Remove decl.
9719 * process.c (Fget_process): New forward static decl.
9720 (Fprocess_datagram_address): Mark as internal.
9721 * syntax.c (Fsyntax_table_p): New forward static decl.
9722 (skip_chars): Remove duplicate decl.
9723 * textprop.c (Fprevious_property_change): New forward static decl.
9724 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9725 Now internal.
9726 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9727 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9728
785bbd42
PE
9729 * editfns.c (Fformat): Remove unreachable code.
9730
8b913b57
AS
97312011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9732
9733 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9734 change. (Bug#8496)
9735
a6744a35
EZ
97362011-04-13 Eli Zaretskii <eliz@gnu.org>
9737
9738 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9739 when at ZV. (Bug#8487)
9740
e7974947
AS
97412011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9742
baad03f0
AS
9743 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9744 (Bug#8437)
9745 * keyboard.c (parse_tool_bar_item): Likewise.
9746 * sound.c (sound_cleanup, alsa_close): Likewise.
9747 * termcap.c (tgetent): Likewise.
9748 * xfns.c (x_default_font_parameter): Likewise.
9749 * xsettings.c (read_and_apply_settings): Likewise.
9750
e7974947
AS
9751 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9752 (overrun_check_free): Protoize.
9753
28272684
PE
97542011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9755
9756 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9757 since callers should never pass a negative size.
9758 Change the signature to match that of plain 'read' and 'write'; see
9759 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9760 * lisp.h: Update prototypes of emacs_write and emacs_read.
9761
11997c76
EZ
97622011-04-11 Eli Zaretskii <eliz@gnu.org>
9763
9764 * xdisp.c (redisplay_window): Don't try to determine the character
9765 position of the scroll margin if the window start point w->startp
e896f03c 9766 is outside the buffer's accessible region. (Bug#8468)
11997c76 9767
8a2cbd72
EZ
97682011-04-10 Eli Zaretskii <eliz@gnu.org>
9769
9770 Fix write-region and its subroutines for buffers > 2GB.
9771 * fileio.c (a_write, e_write): Modify declaration of arguments and
9772 local variables to support buffers larger than 2GB.
9773 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9774
9775 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9776 argument, local variables, and return value.
9777
9778 * lisp.h: Update prototypes of emacs_write and emacs_read.
9779
9780 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9781
4073e537 97822011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 9783
1ebfdcb6
PE
9784 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9785
b2ded58d
PE
9786 Fix more problems found by GCC 4.6.0's static checks.
9787
7d66342c
PE
9788 * xdisp.c (vmessage): Use a better test for character truncation.
9789
bbf47d44
PE
9790 * charset.c (load_charset_map): <, not <=, for optimization,
9791 and to avoid potential problems with integer overflow.
9248994d 9792 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 9793 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 9794 * editfns.c (Fformat): Likewise.
1e69125e 9795 * syntax.c (skip_chars): Likewise.
3befa583 9796
e3019616
PE
9797 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9798 This also lets GCC 4.6.0 generate slightly better loop code.
9799
becfa255
PE
9800 * callint.c (Fcall_interactively): <, not <=, for optimization.
9801 (Fcall_interactively): Count the number of arguments produced,
9802 not the number of arguments given. This is simpler and lets GCC
9803 4.6.0 generate slightly better code.
9804
dae0cd48
PE
9805 * ftfont.c: Distingish more carefully between FcChar8 and char.
9806 The previous code passed unsigned char * to a functions like
9807 strlen and xstrcasecmp that expect char *, which does not
9808 conform to the C standard.
9809 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9810 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9811 char * when the C standard requires it.
9812
76032d70
PE
9813 * keyboard.c (read_char): Remove unused var.
9814
eb3f1cc8
PE
9815 * eval.c: Port to Windows vsnprintf (Bug#8435).
9816 Include <limits.h>.
9817 (SIZE_MAX): Define if the headers do not.
9818 (verror): Do not give up if vsnprintf returns a negative count.
9819 Instead, grow the buffer. This ports to Windows vsnprintf, which
9820 does not conform to C99. Problem reported by Eli Zaretskii.
9821 Also, simplify the allocation scheme, by avoiding the need for
9822 calling realloc, and removing the ALLOCATED variable.
9823
70476b54
PE
9824 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9825
12020a9e
PE
9826 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9827 But keep the doprint source code for now, as we might revamp it
9828 and use it again (Bug#8435).
ea6c7ae6
PE
9829 * lisp.h (doprnt): Remove.
9830 * Makefile.in (base_obj): Remove doprnt.o.
9831 * deps.mk (doprnt.o): Remove.
9832
5fdb398c
PE
9833 error: Print 32- and 64-bit integers portably (Bug#8435).
9834 Without this change, on typical 64-bit hosts error ("...%d...", N)
9835 was used to print both 32- and 64-bit integers N, which relied on
9836 undefined behavior.
61bdb816 9837 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
9838 * lisp.h (error, verror): Mark as printf-like functions.
9839 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9840 Report overflow in size calculations when allocating printf buffer.
9841 Do not truncate output string at its first null byte.
9842 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9843 Truncate the output at a character boundary, since vsnprintf does not
9844 do that.
9845 * charset.c (check_iso_charset_parameter): Convert internal
9846 character to string before calling 'error', since %c now has the
9847 printf meaning.
9848 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9849 overflow when computing char to be passed to 'error'. Do not
9850 pass Lisp_Object to 'error'; pass the integer instead.
9851 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9852 formatted with plain %d.
9853
b189fa66
PE
9854 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9855
bff87ef0
PE
9856 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9857
7e2cac20
PE
9858 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9859
ce4d90b5
PE
9860 * xterm.c (x_catch_errors): Remove duplicate declaration.
9861
266c9547
PE
9862 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9863
79c49ad2
PE
9864 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9865
368f4090
JM
98662011-04-10 Jim Meyering <meyering@redhat.com>
9867
9868 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9869 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9870 return ssize_t not "int", and use size_t as the buffer length.
9871 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9872 * gnutls.h: Update declarations.
9873 * process.c (read_process_output): Use ssize_t, to match.
9874 (send_process): Likewise.
9875
a32d4040
CY
98762011-04-09 Chong Yidong <cyd@stupidchicken.com>
9877
9878 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9879
8546720e 98802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 9881
04f2d78b
CB
9882 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9883 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 9884
8546720e
GM
9885 * xterm.c (handle_one_xevent):
9886 * xmenu.c (create_and_show_popup_menu):
9887 * xselect.c (x_decline_selection_request)
9888 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 9889
0a2f5c1a 98902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
9891
9892 Fix some uses of `int' instead of EMACS_INT.
9893 * search.c (string_match_1, fast_string_match)
9894 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9895 (scan_buffer, find_next_newline_no_quit)
9896 (find_before_next_newline, search_command, Freplace_match)
9897 (Fmatch_data): Make some `int' variables be EMACS_INT.
9898
9899 * xdisp.c (display_count_lines): 3rd argument and return value now
9900 EMACS_INT. All callers changed.
9901 (pint2hrstr): Last argument is now EMACS_INT.
9902
9903 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9904 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9905 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9906 (decode_coding_utf_16, decode_coding_emacs_mule)
9907 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9908 (decode_coding_ccl, decode_coding_charset)
9909 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9910 (decode_coding_iso_2022, decode_coding_emacs_mule)
9911 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9912 <char_offset, last_offset>: Declare EMACS_INT.
9913 (encode_coding_utf_8, encode_coding_utf_16)
9914 (encode_coding_emacs_mule, encode_invocation_designation)
9915 (encode_designation_at_bol, encode_coding_iso_2022)
9916 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9917 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9918 Declare EMACS_INT.
9919 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9920 (encode_invocation_designation): Last argument P_NCHARS is now
9921 EMACS_INT.
9922 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9923 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9924
9925 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9926 All users changed.
9927
9928 * ccl.c (Fccl_execute_on_string): Declare some variables
9929 EMACS_INT.
9930
8546720e 99312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
9932
9933 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9934
4e19a977
CS
99352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9936
9937 * process.c (Fformat_network_address): Doc fix.
9938
87302331
R
99392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9940
ee7683eb 9941 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 9942
cbb59342
CY
99432011-04-08 Chong Yidong <cyd@stupidchicken.com>
9944
9945 * keyboard.c (read_char): Call Lisp function help-form-show,
9946 instead of using internal_with_output_to_temp_buffer.
9947 (Qhelp_form_show): New var.
e0d38eeb 9948 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
9949
9950 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9951
9952 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9953
e67a13ab
CY
99542011-04-06 Chong Yidong <cyd@stupidchicken.com>
9955
04f2d78b
CB
9956 * process.c (Flist_processes): Remove to Lisp.
9957 (list_processes_1): Delete.
e67a13ab 9958
973f782d
EZ
99592011-04-06 Eli Zaretskii <eliz@gnu.org>
9960
7c106b1e
EZ
9961 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9962
973f782d
EZ
9963 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9964
41cf7d1a 99652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 9966
ca23cc88
PE
9967 Fix more problems found by GCC 4.6.0's static checks.
9968
f390e2d5
PE
9969 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9970
42eea0d0
PE
9971 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9972
b69769da 9973 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 9974
f9541e84
PE
9975 * xdisp.c (vmessage): Mark as a printf-like function.
9976
13841b55
PE
9977 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9978
c136c10f
PE
9979 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9980
5e2d4a30
PE
9981 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9982 printf-like functions.
9983 (tiff_load): Add casts to remove these marks before passing them
9984 to system-supplied API.
9985
583f48b9
PE
9986 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9987
b25d760e
PE
9988 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9989 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
9990 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9991 directly, rather than having caller test rule sign. This avoids
9992 some unnecessary tests.
9993 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9994 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9995 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 9996
bc7b6697 9997 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 9998 (xfont_open): Avoid unnecessary tests.
bc7b6697 9999
27ccc379
PE
10000 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10001
dcd5c89a
PE
10002 * composite.h, composite.c (composition_gstring_put_cache):
10003 Use EMACS_INT, not int, for length.
10004
b13a45c6
PE
10005 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10006 breaking out part of COMPOSITION_DECODE_RULE.
10007 (COMPOSITION_DECODE_RULE): Use it.
10008 * composite.c (get_composition_id): Remove unused local vars,
10009 by using the new macro.
10010
1e792e4d
PE
10011 * textprop.c (set_text_properties_1): Change while to do-while,
10012 since the condition is always true at first.
10013
dc6c6455 10014 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10015 (interval_deletion_adjustment): Return unsigned value.
10016 All uses changed.
dc6c6455 10017
aba7731a
PE
10018 * process.c (list_processes_1, create_pty, read_process_output):
10019 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10020 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10021 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10022 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10023 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10024
fdfc4bf3
PE
10025 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10026
fca8fe46 10027 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10028 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10029
06a0259a 10030 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10031 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10032 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10033
e7b9e80f
PE
10034 * print.c (print_error_message): Avoid int overflow.
10035
56201685
PE
10036 * font.c (font_list_entities): Redo for clarity,
10037 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10038
78834453 10039 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10040 (font_score): Avoid potential overflow in diff calculation.
78834453 10041
0bc0b309 10042 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10043 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10044
e610eaca
PE
10045 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10046
b895abce
PE
10047 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10048 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10049 can always succeed if overflow has undefined behavior.
10050
1f1d9321 10051 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10052 (wordify): Omit three unnecessary tests.
1f1d9321 10053
c59478bc
PE
10054 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10055 All callers changed. This avoids the need for an unused var.
10056
79b73827
PE
10057 * casefiddle.c (casify_region): Remove var that is set but not used.
10058
a4db5dfe
PE
10059 * dired.c (file_name_completion): Remove var that is set but not used.
10060
43aae36e
PE
10061 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10062
2a47c44d 10063 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10064 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10065
a37c69bf
PE
10066 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10067 Check for integer overflow on size calculations.
10068
328ab8e7
PE
10069 * buffer.c (Fprevious_overlay_change): Remove var that is set
10070 but not used.
10071
e5a2a5cb
PE
10072 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10073 Remove vars that are set but not used.
8d84a6eb 10074 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10075 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10076
a60e5f68
PE
10077 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10078
f661cb61 10079 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10080 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10081
f0397f5a
PE
10082 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10083 that are set but not used.
10084
8664db06 10085 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10086 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10087
6abdaa4a
PE
10088 * xselect.c (x_get_local_selection, x_handle_property_notify):
10089 Remove vars that are set but not used.
10090
0ce7538d 10091 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10092 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10093
9ae848fc
PE
10094 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10095 Remove var that is set but not used.
0b918413
PE
10096 (scroll_bar_windows_size): Now size_t, not int.
10097 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10098 Check for overflow.
9ae848fc 10099
a5a62657
PE
10100 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10101 (map_tty_color) [!defined MSDOS]: Likewise.
10102
5c5cdd39
PE
10103 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10104
66ebf983
PE
10105 * coding.c: Remove vars that are set but not used.
10106 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10107 All callers changed.
10108 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10109 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10110 (decode_coding_charset): Remove vars that are set but not used.
10111
1be4d761
PE
10112 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10113 that is set but not used.
10114
47553fa8
PE
10115 * print.c (print_object): Remove var that is set but not used.
10116
1f7196bf 10117 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10118 The gnulib version avoids calling malloc in the usual case,
10119 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10120 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10121 * filelock.c (current_lock_owner): Likewise.
10122 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10123 * sysdep.c: Include allocator.h, careadlinkat.h.
10124 (emacs_no_realloc_allocator): New static constant.
10125 (emacs_readlink): New function.
fdb61804
PE
10126 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10127 ../lib/careadlinkat.h.
d1fdcab7 10128
f84c17c7
SM
101292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10130
10131 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10132 first non-nil return value).
10133
ef3862ad
JD
101342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10135
10136 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10137 if not defined (Bug#8403).
10138
376a7006
JB
101392011-04-02 Juanma Barranquero <lekktu@gmail.com>
10140
10141 * xdisp.c (display_count_lines): Remove parameter `start',
10142 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10143 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10144 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10145 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10146 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10147 and thereabouts. All callers changed.
10148 (get_per_char_metric): Remove parameter `f', unused since
10149 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10150
6ca3801d
JM
101512011-04-02 Jim Meyering <meyering@redhat.com>
10152
10153 do not dereference NULL upon failed strdup
10154 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10155 (ns_get_family): Likewise.
10156
d8e2b5ba
JB
101572011-04-02 Juanma Barranquero <lekktu@gmail.com>
10158
10159 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10160
8c74fcbd
JD
101612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10162
10163 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10164 later (Bug#8403).
10165
7200d79c
SM
101662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10167
03408648 10168 Add lexical binding.
7200d79c 10169
03408648
SM
10170 * window.c (Ftemp_output_buffer_show): New fun.
10171 (Fsave_window_excursion):
10172 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10173
10174 * lread.c (lisp_file_lexically_bound_p): New function.
10175 (Fload): Bind Qlexical_binding.
10176 (readevalloop): Remove `evalfun' arg.
10177 Bind Qinternal_interpreter_environment.
10178 (Feval_buffer): Bind Qlexical_binding.
10179 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10180 Mark as dynamic.
10181 (syms_of_lread): Declare `lexical-binding'.
10182
10183 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10184
10185 * keyboard.c (eval_dyn): New fun.
10186 (menu_item_eval_property): Use it.
ca105506
SM
10187
10188 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10189
03408648
SM
10190 * fns.c (concat, mapcar1): Accept byte-code-functions.
10191
10192 * eval.c (Fsetq): Handle lexical vars.
10193 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10194 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10195 (FletX, Flet): Obey lexical binding.
10196 (Fcommandp): Handle closures.
10197 (Feval): New `lexical' arg.
10198 (eval_sub): New function extracted from Feval. Use it almost
10199 everywhere where Feval was used. Look up vars in lexical env.
10200 Handle closures.
10201 (Ffunctionp): Move from subr.el.
10202 (Ffuncall): Handle closures.
10203 (apply_lambda): Remove `eval_flags'.
10204 (funcall_lambda): Handle closures and new byte-code-functions.
10205 (Fspecial_variable_p): New function.
10206 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10207 but without exporting it to Lisp.
23aba0ea 10208
23aba0ea 10209 * doc.c (Fdocumentation, store_function_docstring):
03408648 10210 * data.c (Finteractive_form): Handle closures.
23aba0ea 10211
03408648
SM
10212 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10213 interactive spec.
ba83908c 10214
04f2d78b
CB
10215 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10216 New byte-codes.
03408648
SM
10217 (exec_byte_code): New function extracted from Fbyte_code to handle new
10218 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10219
03408648 10220 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10221
03408648 10222 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10223
e2abce01
JB
102242011-03-31 Juanma Barranquero <lekktu@gmail.com>
10225
10226 * xdisp.c (redisplay_internal): Fix prototype.
10227
63696a73 102282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10229
63696a73 10230 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10231 (try_scrolling): Use it when setting scroll_limit.
10232 Limit scrolling to 100 screen lines.
63696a73
EZ
10233 (redisplay_window): Even when falling back on "recentering",
10234 position point in the window according to scroll-conservatively,
10235 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10236
10237 (try_scrolling): When point is above the window, allow searching
10238 as far as scroll_max, or one screenful, to compute vertical
10239 distance from PT to the scroll margin position. This prevents
10240 try_scrolling from unnecessarily failing when
10241 scroll-conservatively is set to a value slightly larger than the
10242 window height. Clean up the case of PT below the margin at bottom
10243 of window: scroll_max can no longer be INT_MAX. When aggressive
10244 scrolling is in use, don't let point enter the opposite scroll
10245 margin as result of the scroll.
10246 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10247 threshold of 100 lines for never-recentering scrolling.
10248
e4cc2dfc
JB
102492011-03-31 Juanma Barranquero <lekktu@gmail.com>
10250
10251 * dispextern.h (move_it_by_lines):
10252 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10253 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10254 (message_log_check_duplicate): Remove parameters `prev_bol' and
10255 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10256 (redisplay_internal): Remove parameter `preserve_echo_area',
10257 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10258
10259 * indent.c (Fvertical_motion):
10260 * window.c (window_scroll_pixel_based, Frecenter):
10261 Don't pass `need_y_p' to `move_it_by_lines'.
10262
1c470562
SM
102632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10264
44f230aa
SM
10265 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10266 steal a few bits to be more compact.
10267 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10268 Remove unneeded casts.
10269
1c470562
SM
10270 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10271
888adce9
ZK
102722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10273
10274 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10275 binding" message (bug#7967).
10276
f838ed7b
PE
102772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10278
77861b95
PE
10279 Fix more problems found by GCC 4.6.0's static checks.
10280
de6dbc14
PE
10281 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10282 Remove unused local var.
10283
f838ed7b
PE
10284 * editfns.c (Fmessage_box): Remove unused local var.
10285
792c7b2b
PE
10286 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10287 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10288 Omit unused local vars.
c499e557 10289 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10290 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10291 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10292 Omit unused local var.
10293
ba0165e1
PE
10294 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10295 Don't assume string length fits in int.
32ad8845 10296 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10297 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10298
3c59b4c9
PE
10299 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10300 instead of alloca (Bug#8344).
10301
a3eed478 10302 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10303 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10304
eb4d412d
PE
10305 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10306
1658b401
PE
10307 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10308 concerns.
10309
10310 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10311
10312 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10313
9a2c6e05
PE
10314 * keyboard.c (syms_of_keyboard): Use the same style as later
10315 in this function when indexing through an array. This also
10316 works around GCC bug 48267.
10317
03d0a109
PE
10318 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10319
44f730c8
PE
10320 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10321
fe75f926
PE
10322 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10323 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10324
ffa8c828
PE
10325 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10326 This avoids undefined behavior on integer overflow, and is a bit
10327 more convenient anyway since it is compared to a size_t variable.
10328
c5101a77
PE
10329 Variadic C functions now count arguments with size_t, not int.
10330 This avoids an unnecessary limitation on 64-bit machines, which
10331 caused (substring ...) to crash on large vectors (Bug#8344).
10332 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10333 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10334 All variadic functions and their callers changed accordingly.
c5101a77
PE
10335 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10336 * data.c (arith_driver, float_arith_driver): Likewise.
10337 * editfns.c (general_insert_function): Likewise.
10338 * eval.c (struct backtrace.nargs, interactive_p)
10339 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10340 (funcall_lambda, mark_backtrace): Likewise.
10341 * fns.c (concat): Likewise.
10342 * frame.c (x_set_frame_parameters): Likewise.
10343 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10344 0 if not found, not -1. All callers changed.
10345
dd3f25f7
PE
10346 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10347 (stack_copy_size): Now size_t, not int.
10348 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10349
461c2ab9
JB
103502011-03-28 Juanma Barranquero <lekktu@gmail.com>
10351
10352 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10353 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10354 All callers changed.
10355
10356 * lisp.h (multibyte_char_to_unibyte):
10357 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10358 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10359 * character.h (CHAR_TO_BYTE8):
10360 * cmds.c (internal_self_insert):
10361 * editfns.c (general_insert_function):
10362 * keymap.c (push_key_description):
10363 * search.c (Freplace_match):
10364 * xdisp.c (message_dolog, set_message_1): All callers changed.
10365
f6d62986
SM
103662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10367
10368 * keyboard.c (safe_run_hook_funcall): New function.
10369 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10370 don't set the hook to nil, but remove the offending function instead.
10371 (Qcommand_hook_internal): Remove, unused.
10372 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10373 Vcommand_hook_internal.
10374
10375 * eval.c (enum run_hooks_condition): Remove.
10376 (funcall_nil, funcall_not): New functions.
10377 (run_hook_with_args): Call each function through a `funcall' argument.
10378 Remove `cond' argument, now redundant.
10379 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10380 (Frun_hook_with_args_until_failure): Adjust accordingly.
10381 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10382
1db5b1ad
JB
103832011-03-28 Juanma Barranquero <lekktu@gmail.com>
10384
10385 * dispextern.h (string_buffer_position): Remove declaration.
10386
10387 * print.c (strout): Remove parameter `multibyte', unused since
10388 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10389
10390 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10391 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10392 All callers changed.
10393
10394 * w32.c (_wsa_errlist): Use braces for struct initializers.
10395
10396 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10397 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10398 All callers changed.
10399 (string_buffer_position): Likewise. Also, make static (it's never
10400 used outside xdisp.c).
10401 (cursor_row_p): Remove parameter `w', unused since
10402 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10403 (decode_mode_spec): Remove parameter `precision', introduced during
10404 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10405 All callers changed.
10406
5ffb62aa
JD
104072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10408
10409 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10410
461c2ab9 104112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10412
10413 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10414 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10415 (ns_update_auto_hide_menu_bar): New functions.
10416 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10417 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10418 ns_constrain_all_frames.
10419 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10420 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10421
5c380ffb
JD
104222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10423
10424 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10425
9af30bdf
GM
104262011-03-27 Glenn Morris <rgm@gnu.org>
10427
10428 * syssignal.h: Replace RETSIGTYPE with void.
10429 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10430 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10431 Replace SIGTYPE with void everywhere.
10432 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10433 * s/template.h (SIGTYPE): Remove commented out definition.
10434
e2abce01
JB
104352011-03-26 Eli Zaretskii <eliz@gnu.org>
10436
10437 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10438 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10439
f868cd8a
JB
104402011-03-26 Juanma Barranquero <lekktu@gmail.com>
10441
59eb0929
JB
10442 * w32.c (read_unc_volume): Use parameter `henum', instead of
10443 global variable `wget_enum_handle'.
10444
10445 * keymap.c (describe_vector): Remove parameters `indices' and
10446 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10447 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10448
f868cd8a
JB
10449 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10450
10451 * keyboard.c (timer_check): Remove parameter `do_it_now',
10452 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10453 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10454 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10455
10456 * keyboard.c (read_char):
10457 * w32menu.c (w32_menu_display_help):
10458 * xmenu.c (show_help_event, menu_help_callback):
10459 Adjust calls to `show_help_echo'.
10460
10461 * gtkutil.c (xg_maybe_add_timer):
10462 * keyboard.c (readable_events):
10463 * process.c (wait_reading_process_output):
10464 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10465
10466 * insdel.c (adjust_markers_gap_motion):
10467 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10468 (gap_left, gap_right): Don't call it.
10469
2ecf6fdb
CY
104702011-03-25 Chong Yidong <cyd@stupidchicken.com>
10471
10472 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10473 incurred during fontification.
10474
6b1f9ba4
JB
104752011-03-25 Juanma Barranquero <lekktu@gmail.com>
10476
10477 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10478 (DEFVAR_PER_BUFFER): Don't pass it.
10479
10480 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10481 (scrolling_window): Don't pass it.
10482
0f4a96b5
JB
104832011-03-25 Juanma Barranquero <lekktu@gmail.com>
10484
10485 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10486
10487 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10488 and `suffix'.
10489 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10490 of variables specific to SELinux and computation of `encoded_absname'.
10491
10492 * image.c (XPutPixel): Remove unused variable `height'.
10493
10494 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10495
10496 * unexw32.c (get_section_info): Remove unused variable `section'.
10497
10498 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10499 (system_process_attributes): Remove unused variable `sess'.
10500 (sys_read): Remove unused variable `err'.
10501
10502 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10503 (w32_wnd_proc): Remove unused variable `isdead'.
10504 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10505 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10506 (x_create_tip_frame): Remove unused variable `tem'.
10507
10508 * w32inevt.c (w32_console_read_socket):
10509 Remove unused variable `no_events'.
10510
10511 * w32term.c (x_draw_composite_glyph_string_foreground):
10512 Remove unused variable `width'.
10513
1149507c
JB
105142011-03-24 Juanma Barranquero <lekktu@gmail.com>
10515
10516 * w32term.c (x_set_glyph_string_clipping):
10517 Don't pass uninitialized region to CombineRgn.
10518
9c88f339
JB
105192011-03-23 Juanma Barranquero <lekktu@gmail.com>
10520
10521 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10522 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10523 (Fx_close_connection): Remove unused variable `i'.
10524
10525 * w32font.c (w32font_draw): Return number of glyphs.
10526 (w32font_open_internal): Remove unused variable `i'.
10527 (w32font_driver): Add missing initializer.
10528
10529 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10530 (fill_in_menu): Remove unused variable `items_added'.
10531
10532 * w32term.c (last_mouse_press_frame): Remove static global variable.
10533 (w32_clip_to_row): Remove unused variable `f'.
10534 (x_delete_terminal): Remove unused variable `i'.
10535
10536 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10537 (NOTHING): Remove unused static global variable.
10538 (uniscribe_check_otf): Remove unused variable `table'.
10539 (uniscribe_font_driver): Add missing initializers.
10540
dee091a3
JD
105412011-03-23 Julien Danjou <julien@danjou.info>
10542
10543 * term.c (Fsuspend_tty, Fresume_tty):
10544 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10545 * window.c (temp_output_buffer_show):
10546 * insdel.c (signal_before_change):
10547 * frame.c (Fhandle_switch_frame):
10548 * fileio.c (Fdo_auto_save):
10549 * emacs.c (Fkill_emacs):
10550 * editfns.c (save_excursion_restore):
10551 * cmds.c (internal_self_insert):
10552 * callint.c (Fcall_interactively):
10553 * buffer.c (Fkill_all_local_variables):
10554 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10555 Use Frun_hooks.
0f4a96b5 10556 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10557 unconditionally since it does the check itself.
dee091a3 10558
2c520ab5 105592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10560
c9c49752
PE
10561 Fix more problems found by GCC 4.5.2's static checks.
10562
8abc3f12
PE
10563 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10564 the first time through the loop, since we know p0 < p1 then.
10565 This also avoids a gcc -Wstrict-overflow warning.
10566
a2d26660
PE
10567 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10568 leading to a memory leak, possible in functions like
10569 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10570 of objects (Bug#8318).
a2d26660 10571
916c72e9
PE
10572 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10573 that could (at least in theory) be that large.
10574
19ab8a18
PE
10575 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10576 This is less likely to overflow, and avoids undefined behavior if
10577 overflow does occur. All callers changed. Use strtoul to scan
10578 for the unsigned long integer.
b7cbbd6f
PE
10579 (pint2hrstr): Simplify and tune code slightly.
10580 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10581
f0641eff
PE
10582 * scroll.c (do_scrolling): Work around GCC bug 48228.
10583 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10584
7f650bb9
PE
10585 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10586 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10587 (validate_x_resource_name): Simplify count usage.
10588 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10589
37dd57d1
PE
10590 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10591 fail (Bug#8306).
81e56e61 10592
699979fc 10593 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10594
401bf9b4
PE
10595 * process.c (Fmake_network_process): Use socklen_t, not int,
10596 where POSIX says socklen_t is required in portable programs.
10597 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10598 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10599 (Fmake_network_process, server_accept_connection):
10600 (wait_reading_process_output, read_process_output):
10601 Likewise.
10602
b93aacde
PE
10603 * process.c: Rename or move locals to avoid shadowing.
10604 (list_processes_1, Fmake_network_process):
10605 (read_process_output_error_handler, exec_sentinel_error_handler):
10606 Rename or move locals.
4dc343ee 10607 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10608 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10609 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10610 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10611 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10612
af8a867c 10613 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10614 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10615 Include tparam.h instead, since it declares them.
af8a867c
PE
10616 * cm.h (PC): Remove extern decl; tparam.h now does this.
10617 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10618 * terminfo.c: Include tparam.h, to check interfaces.
10619 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10620 (tparam): Adjust signature to match interface in tparam.h;
10621 this removes some undefined behavior. Check that outstring and len
10622 are zero, which they always are with Emacs.
10623 * tparam.h (PC, BC, UP): New extern decls.
10624
0248044d 10625 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10626 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10627
8ff096c1 10628 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10629 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10630 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10631 (ftfont_list): Remove unused local.
49eaafba
PE
10632 (get_adstyle_property, ftfont_pattern_entity):
10633 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10634 Rename locals to avoid shadowing.
8ff096c1 10635
e2be39f6
PE
10636 * xfont.c (xfont_list_family): Mark var as initialized.
10637
c9735e30
PE
10638 * xml.c (make_dom): Now static.
10639
8f5201ae
PE
10640 * composite.c (composition_compute_stop_pos): Rename local to
10641 avoid shadowing.
b246f932
PE
10642 (composition_reseat_it): Remove unused locals.
10643 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10644 (composition_update_it): Mark var as initialized.
11b61122
PE
10645 (find_automatic_composition): Mark vars as initialized,
10646 with a FIXME (Bug#8290).
8f5201ae 10647
760fbc2c
PE
10648 character.h: Rename locals to avoid shadowing.
10649 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10650 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10651 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10652 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10653 to avoid shadowing.
10654
ff08eb85
PE
10655 * textprop.c (property_change_between_p): Remove; unused.
10656
fc7bf025
PE
10657 * intervals.c (interval_start_pos): Now static.
10658
235d7abc
PE
10659 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10660
44f230aa
SM
10661 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10662 Rename locals to avoid shadowing.
3e7d6594 10663
50060332
PE
10664 * sound.c (wav_play, au_play, Fplay_sound_internal):
10665 Fix pointer signedness.
d01f234b 10666 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10667 (wav_play): Initialize a variable to 0, to prevent undefined
10668 behavior (Bug#8278).
50060332 10669
c4fc4e30
PE
10670 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10671
918436ed
PE
10672 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10673
c939f91b
PE
10674 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10675 clobbering (Bug#8298).
b9c7f648
PE
10676 * sysdep.c (sys_subshell): Likewise.
10677 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10678
6bd8c144
PE
10679 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10680 This should get cleaned up, so that child_setup has the
10681 same signature on all platforms.
10682
7710357c 10683 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10684 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10685
c59da222
CY
106862011-03-22 Chong Yidong <cyd@stupidchicken.com>
10687
10688 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10689 not to be necessary, and produces flickering.
10690
66b87493
GM
106912011-03-20 Glenn Morris <rgm@gnu.org>
10692
10693 * config.in: Remove file.
10694
45b6f6d5
JB
106952011-03-20 Juanma Barranquero <lekktu@gmail.com>
10696
10697 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10698 are now in src/globals.h.
10699 (syms_of_minibuf): Remove spurious & from previous change.
10700
cd394be1 107012011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
10702
10703 * minibuf.c (completing-read-function): New variable.
10704 (completing-read-default): Rename from completing-read.
10705 (completing-read): Call completing-read-function.
10706
b14e3e21
CY
107072011-03-19 Juanma Barranquero <lekktu@gmail.com>
10708
10709 * xfaces.c (Fx_load_color_file):
10710 Read color file from absolute filename (bug#8250).
10711
f2b726e6
JB
107122011-03-19 Juanma Barranquero <lekktu@gmail.com>
10713
10714 * makefile.w32-in: Update dependencies.
10715
09f6ff02
EZ
107162011-03-17 Eli Zaretskii <eliz@gnu.org>
10717
10718 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10719
29a6015a
PE
107202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10721
a3a6c54e
PE
10722 Fix more problems found by GCC 4.5.2's static checks.
10723
b766f867
PE
10724 * process.c (make_serial_process_unwind, send_process_trap):
10725 (sigchld_handler): Now static.
10726
be02381c
PE
10727 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10728 That way, the code declares only the vars that it needs.
10729 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10730 * s/cygwin.h (PTY_ITERATION): Likewise.
10731 * s/darwin.h (PTY_ITERATION): Likewise.
10732 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10733
57048744
PE
10734 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10735 * process.c (allocate_pty): Don't declare stb unless it's needed.
10736
7914961c 10737 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
10738 (CONSTANTLIM): Remove; unused.
10739 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10740 Define only if needed.
7914961c 10741
b3967b18
PE
10742 * unexelf.c (unexec): Name an expression,
10743 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
10744 Use a different way to cause a compilation error if anyone uses
10745 n rather than nn, a way that does not involve shadowing.
73366a00 10746 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 10747
29a6015a
PE
10748 * deps.mk (unexalpha.o): Remove; unused.
10749
43cfc33e 10750 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 10751 * unexec.h: New file.
ce701a33
PE
10752 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10753 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10754 Depend on unexec.h.
10755 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10756 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10757 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 10758 Change as necessary to match prototype in unexec.h.
ce701a33 10759
01f44d5a
PE
10760 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10761 shadowing.
4f63c6bb 10762 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 10763
a6670b0b
PE
10764 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10765 Rename locals to avoid shadowing.
10766
cef2010d 10767 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 10768 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 10769
d4d7173a
PE
10770 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10771
f08b802a
PE
10772 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10773 warning when compiling print.c.
10774
3ddb0639
PE
10775 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10776 instead of using an uninitialized var.
5ad03b97 10777 (font_sort_entities): Mark var as initialized.
3ddb0639 10778
170a2692
PE
10779 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10780
e663c700
PE
10781 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10782 pointers to constants.
89bc529a 10783 (font_parse_fcname): Remove unused vars.
7b81e2d0 10784 (font_delete_unmatched): Now static.
ea838e10 10785 (font_get_spec): Remove; unused.
13a547c6
PE
10786 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10787 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10788 Rename or move locals to avoid shadowing.
e663c700 10789
2a80c887 10790 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 10791 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 10792
1384fa33 10793 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 10794 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 10795
8b2c52e9
PE
10796 * alloc.c (mark_backtrace): Move decl from here ...
10797 * lisp.h: ... to here, so that it can be checked.
10798
475545b5 10799 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 10800 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
10801 (lisp_indirect_variable): Name an expression,
10802 to avoid gcc -Wbad-function-cast warning.
1faed8ae 10803 (Fdefvar): Rename locals to avoid shadowing.
475545b5 10804
b1349114 10805 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 10806 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 10807 Use const pointer when appropriate.
b1349114 10808
a2928364
PE
10809 * lisp.h (get_system_name, get_operating_system_release):
10810 Move decls here, to check interfaces.
10811 * process.c (get_operating_system_release): Move decl to lisp.h.
10812 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
10813 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10814 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10815 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
10816 (Fformat_time_string, Fencode_time, Finsert_char):
10817 (Ftranslate_region_internal, Fformat):
10818 Rename or remove local vars to avoid shadowing.
9710023e 10819 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 10820
a415e694
PE
10821 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10822 avoid shadowing.
10823
8ef4622d
PE
10824 * lisp.h (eassert): Check that the argument compiles, even if
10825 ENABLE_CHECKING is not defined.
10826
946f9a5b
PE
10827 * data.c (Findirect_variable): Name an expression, to avoid
10828 gcc -Wbad-function-cast warning.
112396d6 10829 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 10830 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
10831 (Fmake_variable_buffer_local, Fmake_local_variable):
10832 Mark variables as initialized.
52746918 10833 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 10834
e5aab7e7 10835 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
10836 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10837 Rename locals to avoid shadowing.
dff45157
PE
10838 (mark_stack): Move local variables into the #ifdef region where
10839 they're used.
7bc26fdb
PE
10840 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10841 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10842 needed otherwise.
10843 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10844 (GC_STRING_CHARS): Remove; not used.
d40d4be1 10845 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 10846
e5aab7e7
PE
10847 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10848 avoids undefined behavior in theory.
10849
4da60324
PE
10850 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10851
88043301
PE
10852 Use functions, not macros, for up- and down-casing (Bug#8254).
10853 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10854 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10855 to use the following functions instead of these macros.
10856 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10857 EMACS_INT, since callers assume the returned value fits in int.
10858 (upcase1): Likewise, for UPCASE_TABLE.
10859 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 10860 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 10861 the race-condition problem in the old DOWNCASE.
88043301 10862
19ed5445
PE
10863 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10864 Rename locals to avoid shadowing.
10865 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
10866 (regex_compile, re_search_2, re_match_2_internal):
10867 Remove unused local vars.
952db0d7
PE
10868 (FREE_VAR): Rewrite so as not to use empty "else",
10869 which gcc can warn about.
da053e48 10870 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
10871 (RETALLOC_IF): Define only if needed.
10872 (WORDCHAR_P): Likewise. This one is never needed, but is used
10873 only in a comment talking about a compiler bug, so put inside
10874 the #if 0 of that comment.
10875 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10876 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10877 Remove; unused.
19ed5445 10878
1f3561e4 10879 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
10880 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10881 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 10882
ded6f8f7
PE
10883 * search.c (simple_search): Remove unused var.
10884
dbd37a95
PE
10885 * dired.c (compile_pattern): Move decl from here ...
10886 * lisp.h: ... to here, so that it can be checked.
10887 (struct re_registers): New forward decl.
10888
7e47afad
PE
10889 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10890
85f24f61
PE
10891 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10892 All uses changed.
10893 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10894 Rename locals to avoid shadowing.
5671df8f 10895 (Fvertical_motion): Mark locals as initialized.
85f24f61 10896
181aa2be 10897 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 10898 (casify_region): Mark local as initialized.
181aa2be 10899
930d429c
PE
10900 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10901
7082eac6
PE
10902 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10903 New macros, so that the caller can use some names other than
10904 gcpro1, gcpro2, etc.
10905 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10906 of the new macros.
10907 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10908 argument, for consistency with GCPRO2_VAR, etc: it is now the
10909 prefix of the variable, not the variable itself. All uses
10910 changed.
38b2c076
PE
10911 * dired.c (directory_files_internal, file_name_completion):
10912 Rename locals to avoid shadowing.
10913
15206ed9
PE
10914 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10915 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10916 dired.c's scmp function, had undefined behavior.
10917 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10918 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10919 * buffer.h: ... to here, because these macros use current_buffer,
10920 and the new implementation with inline functions needs to have
10921 current_buffer in scope now, rather than later when the macros
10922 are used.
10923 (downcase, upcase1): New static inline functions.
10924 (DOWNCASE, UPCASE1): Reimplement using these functions.
10925 This avoids undefined behavior in expressions like
10926 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10927 from race conditions in accessing the global variables
10928 case_temp1 and case_temp2.
10929 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10930 * lisp.h (case_temp1, case_temp2): Remove their decls.
10931 * character.h (ASCII_CHAR_P): Move from here ...
10932 * lisp.h: ... to here, so that the inline functions mentioned
10933 above can use them.
10934
4a6bea26
PE
10935 * dired.c (directory_files_internal_unwind): Now static.
10936
f14b7e14
PE
10937 * fileio.c (file_name_as_directory, directory_file_name):
10938 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10939 Now static.
2893f146
PE
10940 (file_name_as_directory): Use const pointers when appropriate.
10941 (Fexpand_file_name): Likewise. In particular, newdir might
10942 point at constant storage, so make it a const pointer.
fd4ead52 10943 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
10944 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10945 signedness issues.
f839df0c
PE
10946 (Fset_file_times, Finsert_file_contents, auto_save_error):
10947 Rename locals to avoid shadowing.
f14b7e14 10948
5716756e 10949 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
10950 (Ftry_completion, Fall_completions): Rename or remove locals
10951 to avoid shadowing.
5716756e 10952
b4c3046a
PE
10953 * marker.c (bytepos_to_charpos): Remove; unused.
10954
b45db522
PE
10955 * lisp.h (verify_bytepos, count_markers): New decls,
10956 so that gcc does not warn that these functions aren't declared.
10957
85876d07
PE
10958 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10959 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 10960 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 10961 (copy_text): Remove unused local var.
85876d07 10962
03d78a21 10963 * filelock.c (within_one_second): Now static.
b3dd38ab 10964 (lock_file_1): Rename local to avoid shadowing.
03d78a21 10965
5df8f01b
PE
10966 * buffer.c (fix_overlays_before): Mark locals as initialized.
10967 (fix_start_end_in_overlays): Likewise. This function should be
10968 simplified by using pointers-to-pointers, but that's a different
10969 matter.
b1d876f1 10970 (switch_to_buffer_1): Now static.
8f54f30a
PE
10971 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10972 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 10973
a70072c9 10974 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 10975 Fix pointer signedness issue.
edced198
PE
10976 (sys_subshell): Mark local as volatile if checking for lint,
10977 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 10978 (MAXPATHLEN): Define only if needed.
a70072c9 10979
a0977c44
PE
10980 * process.c (serial_open, serial_configure): Move decls from here ...
10981 * systty.h: ... to here, so that they can be checked.
10982
a884fdcc
PE
10983 * fns.c (get_random, seed_random): Move extern decls from here ...
10984 * lisp.h: ... to here, so that they can be checked.
10985
604efe86 10986 * sysdep.c (reset_io): Now static.
b8950c94 10987 (wait_for_termination_signal): Remove; unused.
604efe86 10988
38fc62d9
PE
10989 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10990 (copy_keymap_item, append_key, push_text_char_description):
10991 Now static.
1004a21a 10992 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 10993 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
10994 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10995 (describe_map_tree):
10996 Rename locals to avoid shadowing.
38fc62d9 10997
2f2650da
PE
10998 * keyboard.c: Declare functions static if they are not used elsewhere.
10999 (echo_char, echo_dash, cmd_error, top_level_2):
11000 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11001 (read_char, kbd_buffer_get_event, make_lispy_position):
11002 (make_lispy_event, make_lispy_movement, apply_modifiers):
11003 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11004 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11005 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11006 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11007 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11008
a053e86c 11009 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11010 (mark_kboards): Move decl here ...
11011 * alloc.c (mark_kboards): ... from here.
a053e86c 11012
4752793e
PE
11013 * lisp.h (force_auto_save_soon): New decl.
11014
74f10ca7 11015 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11016 (DEFINE_DUMMY_FUNCTION): New macro.
11017 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11018 Use it.
c03cd23f
PE
11019 (main): Add casts to avoid warnings
11020 if GCC considers string literals to be constants.
74f10ca7 11021
022e70d4
PE
11022 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11023
59d6fe83
PE
11024 * dbusbind.c: Pointer signedness fixes.
11025 (xd_signature, xd_append_arg, xd_initialize):
11026 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11027 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11028 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11029 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11030
78320123
PE
11031 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11032 if GCC considers string literals to be constants.
49cebcca 11033 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11034
35ac2a97
SM
110352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11036
fb103ca9
SM
11037 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11038 (print_preprocess, print_object): New macro to fix last change.
11039
35ac2a97
SM
11040 * print.c (print_preprocess): Don't forget font objects.
11041
62973b41
JB
110422011-03-16 Juanma Barranquero <lekktu@gmail.com>
11043
11044 * emacs.c (USAGE3): Doc fixes.
11045
0e48bb22
AS
110462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11047
11048 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11049 structure.
11050
7684e57b
JB
110512011-03-14 Juanma Barranquero <lekktu@gmail.com>
11052
11053 * lisp.h (VWindow_system, Qfile_name_history):
11054 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11055 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11056 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11057
11058 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11059 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11060
11061 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11062 * w32console.c (detect_input_pending, read_input_pending)
11063 (encode_terminal_code):
11064 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11065 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11066 (w32_system_caret_y, Qfile_name_history):
11067 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11068 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11069 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11070 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11071 * w32proc.c (Qlocal, report_file_error):
11072 * w32term.c (Vwindow_system, updating_frame):
11073 * w32uniscribe.c (initialized, uniscribe_font_driver):
11074 Remove unneeded extern declarations.
11075
2aa46d6c
CY
110762011-03-14 Chong Yidong <cyd@stupidchicken.com>
11077
c96bbc66 11078 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11079
cffc6f3b
CY
110802011-03-13 Chong Yidong <cyd@stupidchicken.com>
11081
11082 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11083 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11084 These macros can no longer be used for assignment.
11085
44f230aa
SM
11086 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11087 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11088 (record_buffer_markers, fetch_buffer_markers): New functions for
11089 recording and fetching special buffer markers.
11090 (set_buffer_internal_1, set_buffer_temp): Use them.
11091
11092 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11093
11094 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11095
11096 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11097 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11098
11099 * xdisp.c (hscroll_window_tree):
11100 (reconsider_clip_changes): Use PT instead of BUF_PT.
11101
d251f04b
EZ
111022011-03-13 Eli Zaretskii <eliz@gnu.org>
11103
11104 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11105 $(EMACS_ROOT)/lib/intprops.h.
11106
f0c77cd1
PE
111072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11108
3eca4629
PE
11109 Fix more problems found by GCC 4.5.2's static checks.
11110
7c86ee98
PE
11111 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11112 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11113 (xg_free_frame_widgets): Make it clear that a local variable is
11114 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11115 (gdk_window_get_screen): Make it clear that this macro is needed
11116 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11117 (int_gtk_range_get_value): New function, which avoids a diagnostic
11118 from gcc -Wbad-function-cast.
11119 (xg_set_toolkit_scroll_bar_thumb): Use it.
11120 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11121 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11122 (get_utf8_string, xg_get_file_with_chooser):
11123 Rename locals to avoid shadowing.
11124 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11125
41729b81
PE
11126 * xgselect.c (xg_select): Remove unused var.
11127
f0c77cd1
PE
11128 * image.c (four_corners_best): Mark locals as initialized.
11129 (gif_load): Initialize transparent_p to zero (Bug#8238).
11130 Mark another local as initialized.
ec6cf4c6 11131 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11132
ce0ad53d 11133 * image.c (clear_image_cache): Now static.
d5d5a617 11134 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11135 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11136 (x_edge_detection): Remove unnecessary cast that
11137 gcc -Wbad-function-cast diagnoses.
2037898d 11138 (gif_load): Fix pointer signedness.
6ae141d6
PE
11139 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11140 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11141
33383987 111422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11143
d32df629
PE
11144 Improve quality of tests for time stamp overflow.
11145 For example, without this patch (encode-time 0 0 0 1 1
11146 1152921504606846976) returns the obviously-bogus value (-948597
11147 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11148 reports time overflow. See
11149 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11150 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11151 * editfns.c: Include limits.h and intprops.h.
11152 (TIME_T_MIN, TIME_T_MAX): New macros.
11153 (time_overflow): Move earlier, to before first use.
11154 (hi_time, lo_time): New functions, for an accurate test for
11155 out-of-range times.
11156 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11157 (Fget_internal_run_time): Don't assume time_t fits in int.
11158 (make_time): Use list2 instead of Fcons twice.
11159 (Fdecode_time): More accurate test for out-of-range times.
11160 (check_tm_member): New function.
11161 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11162 (lisp_time_argument): Don't rely on undefined left-shift and
11163 right-shift behavior when checking for time stamp overflow.
8be6f318 11164
fe31d94c
PE
11165 * editfns.c (time_overflow): New function, refactoring common code.
11166 (Fformat_time_string, Fdecode_time, Fencode_time):
11167 (Fcurrent_time_string): Use it.
11168
8be6f318
PE
11169 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11170 * dired.c (make_time): Move to ...
11171 * editfns.c (make_time): ... here.
11172 * systime.h: Note the move.
11173
09d9db2c 111742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11175
126bc0dc
YM
11176 * fringe.c (update_window_fringes): Remove unused variables.
11177
c47cbdfd
YM
11178 * unexmacosx.c (copy_data_segment): Also copy __got section.
11179 (Bug#8223)
11180
7ac80be9
EZ
111812011-03-12 Eli Zaretskii <eliz@gnu.org>
11182
c96bbc66 11183 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11184 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11185 Constify `char *' arguments and their references according to
11186 prototypes in tparam.h.
11187
ecb0f94d 11188 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11189
7ac80be9
EZ
11190 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11191 Adapt all references accordingly.
11192
11193 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11194
ef1fd07e
TT
111952011-03-11 Tom Tromey <tromey@redhat.com>
11196
11197 * buffer.c (syms_of_buffer): Remove obsolete comment.
11198
7ef4b50c
EZ
111992011-03-11 Eli Zaretskii <eliz@gnu.org>
11200
11201 * termhooks.h (encode_terminal_code): Declare prototype.
11202
11203 * msdos.c (encode_terminal_code): Don't declare prototype.
11204
11205 * term.c (encode_terminal_code): Now external again, used by
11206 w32console.c and msdos.c.
11207
44f230aa
SM
11208 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11209 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11210
4b1ec863 112112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11212
1714f52b 11213 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11214
4b1ec863
PE
11215 * fringe.c (update_window_fringes): Mark locals as initialized
11216 (Bug#8227).
11217 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11218
524c7aa6
PE
11219 * alloc.c (mark_fringe_data): Move decl from here ...
11220 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11221 to check its interface.
11222 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11223
a5c0af81 11224 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11225 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11226 (fontset_font): Mark local as initialized.
a9a06e0b 11227 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11228
b4716021
PE
11229 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11230
811e9bac 11231 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11232 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11233 (x_own_selection, Fx_disown_selection_internal): Rename locals
11234 to avoid shadowing.
11235 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11236
7e3ab302
PE
11237 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11238 so that the caller can use some name other than gcpro1.
11239 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11240 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11241 (Fx_backspace_delete_keys_p):
11242 Use them to avoid shadowing, and rename vars to avoid shadowing.
11243 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11244 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11245 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11246 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11247 Remove unused locals.
7e3ab302
PE
11248 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11249 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11250 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11251 macros.
f78faa98 11252
e2b13473
PE
11253 * xterm.h (x_mouse_leave): New decl.
11254
77f23912
PE
11255 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11256 Remove unused functions.
cdf4ba58
PE
11257 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11258 (x_calc_absolute_position): Now static.
7411c686 11259 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11260 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11261 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11262 unless they are used.
38d0b34a
PE
11263 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11264 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11265 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11266 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11267 (x_error_catcher, x_connection_closed, x_error_handler):
11268 (x_error_quitter, xembed_send_message, x_iconify_frame):
11269 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11270 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11271 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11272
44f230aa
SM
11273 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11274 Rename or move locals to avoid shadowing.
6b463e58 11275 (tty_defined_color, merge_face_heights): Now static.
5967d051 11276 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11277 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11278 does not deduce is never used uninitialized.
73719eba
PE
11279 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11280 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11281
426994c3 11282 * terminal.c (store_terminal_param): Now static.
5489860b 11283
032f1620 11284 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11285 (set_frame_menubar): Remove unused local.
d4323972 11286 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11287 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11288 since they might point to immutable storage.
281585b0
PE
11289 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11290 since it's unused otherwise.
032f1620 11291
367c19e5 11292 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11293 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11294 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11295 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11296 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11297 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11298 does not deduce are never used uninitialized.
70739cbe 11299
07b48fa9
PE
11300 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11301
8868a238 11302 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11303 * window.c (window_loop, size_window):
11304 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11305
7e5cf297 11306 * window.c (display_buffer): Now static.
d6550a9f
PE
11307 (size_window): Mark variables that gcc -Wuninitialized
11308 does not deduce are never used uninitialized.
a586633d
PE
11309 * window.h (check_all_windows): New decl, to forestall
11310 gcc -Wmissing-prototypes diagnostic.
5b555da1 11311 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11312
f6095868
PE
11313 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11314 shadowing.
11315 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11316 Include <limits.h>.
11317 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11318 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11319 (load_charset_map): Mark variables that gcc -Wuninitialized
11320 does not deduce are never used uninitialized.
53df7c11 11321 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11322
f38b440c
PE
11323 * coding.c (coding_set_source, coding_set_destination):
11324 Use "else { /* comment */ }" rather than "else /* comment */;"
11325 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11326 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11327 a block, when the outer 'i' will do.
11328 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11329 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11330 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11331 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11332 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11333 Rename locals to avoid shadowing.
11334 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11335 * coding.c (emacs_mule_char, encode_invocation_designation):
11336 Now static, since they're not used elsewhere.
413bb2db 11337 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11338 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11339 (decode_coding_emacs_mule): Mark variables that gcc
11340 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11341 (detect_coding_iso_2022): Initialize a local variable that might
11342 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11343 this initialization is needed. (Bug#8211)
5f58e762
PE
11344 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11345 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11346 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11347 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11348 Remove unused macros.
f38b440c 11349
232b38b9 11350 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11351 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11352 * character.c (string_count_byte8): Likewise.
232b38b9 11353
fb90da1b
PE
11354 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11355 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11356
fb93dbc2
PE
11357 * chartab.c (copy_sub_char_table): Now static, since it's not used
11358 elsewhere.
5c156ace
PE
11359 (sub_char_table_ref_and_range, char_table_ref_and_range):
11360 Rename locals to avoid shadowing.
bbcd0949 11361 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11362
7d3b3862 11363 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11364 (BIDI_BOB): Remove unused macro.
7d3b3862 11365
6be7d3da
PE
11366 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11367 deduce are never used uninitialized.
c2ed9c8b 11368 * term.c (encode_terminal_code): Likewise.
6be7d3da 11369
75f8807f 11370 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11371
50938595
PE
11372 * tparam.h: New file.
11373 * term.c, tparam.h: Include it.
11374 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11375 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11376 Move these decls to tparam.h, and make them agree with what
11377 is actually in tparam.c. The previous trick of using incompatible
11378 decls in different modules does not conform to the C standard.
11379 All callers of tparam changed to use tparam's actual API.
11380 * tparam.c (tparam1, tparam, tgoto):
11381 Use const pointers where appropriate.
11382
fbceeba2
PE
11383 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11384 * cm.h (struct cm): Likewise.
11385 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11386 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11387 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11388 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11389 (turn_on_face, init_tty): Likewise.
11390 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11391
7f3f1250
PE
11392 * term.c (term_mouse_position): Rename local to avoid shadowing.
11393
e6ca6543
PE
11394 * alloc.c (mark_ttys): Move decl from here ...
11395 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11396
c40f8d15
AS
113972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11398
11399 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11400
cfe0661d
JB
114012011-03-09 Juanma Barranquero <lekktu@gmail.com>
11402
11403 * search.c (compile_pattern_1): Remove argument regp, unused since
11404 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11405 (compile_pattern): Don't pass it.
11406
0afb4571
J
114072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11408
11409 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11410 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11411 for ! HAVE_GTK3.
11412 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11413
11414 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11415
11416 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11417 gdk_window_get_screen, gdk_window_get_geometry,
11418 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11419 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11420 (xg_get_pixbuf_from_pixmap): New function.
11421 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11422 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11423 Call xg_get_pixbuf_from_pixmap instead of
11424 gdk_pixbuf_get_from_drawable.
11425 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11426 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11427 (xg_check_special_colors): Use GtkStyleContext and its functions
11428 for HAVE_GTK3.
11429 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11430 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11431 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11432 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11433 Call gtk_widget_get_preferred_size.
0afb4571
J
11434 (xg_frame_resized): gdk_window_get_geometry only takes 5
11435 parameters.
44f230aa
SM
11436 (xg_win_to_widget, xg_event_is_for_menubar):
11437 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11438 (xg_set_widget_bg): New function.
11439 (delete_cb): New function.
895009e1 11440 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11441 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11442 (xg_set_background_color): Call xg_set_widget_bg.
11443 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11444 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11445 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11446 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11447 if ! HAVE_GTK3.
11448 (update_frame_tool_bar): Call gtk_widget_hide.
11449 (xg_initialize): Use GDK_KEY_g.
11450
11451 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11452 if ! HAVE_GTK3
11453 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11454
11455 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11456 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11457 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11458
1c2cc4ef
JB
114592011-03-08 Juanma Barranquero <lekktu@gmail.com>
11460
11461 * w32xfns.c (select_palette): Check success of RealizePalette against
11462 GDI_ERROR, not zero.
11463
33383987 11464See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11465
11466;; Local Variables:
11467;; coding: utf-8
aac0c6e3
MR
11468;; End:
11469
2f097256 11470 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11471
11472 This file is part of GNU Emacs.
11473
11474 GNU Emacs is free software: you can redistribute it and/or modify
11475 it under the terms of the GNU General Public License as published by
11476 the Free Software Foundation, either version 3 of the License, or
11477 (at your option) any later version.
11478
11479 GNU Emacs is distributed in the hope that it will be useful,
11480 but WITHOUT ANY WARRANTY; without even the implied warranty of
11481 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11482 GNU General Public License for more details.
11483
11484 You should have received a copy of the GNU General Public License
11485 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.