Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
825cd63c
EZ
12011-04-25 Eli Zaretskii <eliz@gnu.org>
2
3 Improve doprnt and its use in verror. (Bug#8545)
4 * doprnt.c (doprnt): Document the set of format control sequences
5 supported by the function. Use SAFE_ALLOCA instead of always
6 using `alloca'.
7
8 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9 is one byte too soon. Don't use xrealloc; instead xfree and
10 xmalloc anew.
11
e061a11b
TZ
122011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13
14 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15 callbacks stage.
16
17 * gnutls.c: Renamed global_initialized to
18 gnutls_global_initialized. Added internals for the
19 :verify-hostname-error, :verify-error, and :verify-flags
20 parameters of `gnutls-boot' and documented those parameters in the
21 docstring. Start callback support.
22 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
23 unless a fatal error occured. Call gnutls_alert_send_appropriate
24 on error. Return error code.
25 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
26 (emacs_gnutls_read): Likewise.
27 (Fgnutls_boot): Return handshake error code.
28 (emacs_gnutls_handle_error): New function.
29 (wsaerror_to_errno): Likewise.
30
31 * w32.h (emacs_gnutls_pull): Add prototype.
32 (emacs_gnutls_push): Likewise.
33
34 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
35 (emacs_gnutls_push): Likewise.
36
372011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
38
39 * process.c (wait_reading_process_output): Check if GnuTLS
40 buffered some data internally if no FDs are set for TLS
41 connections.
42
43 * makefile.w32-in (OBJ2): Add gnutls.$(O).
44 (LIBS): Link to USER_LIBS.
45 ($(BLD)/gnutls.$(0)): New target.
46
fa6996bc
EZ
472011-04-24 Eli Zaretskii <eliz@gnu.org>
48
eb35682e
EZ
49 * xdisp.c (handle_single_display_spec): Rename the
50 display_replaced_before_p argument into display_replaced_p, to
51 make it consistent with the commentary. Fix typos in the
52 commentary.
53
e2ad650c
EZ
54 * textprop.c (syms_of_textprop): Remove dead code.
55 (copy_text_properties): Delete obsolete commentary about an
56 interface that was deleted long ago. Fix typos in the description
57 of arguments.
58
1b2de274
EZ
59 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
60 to changes in oldXMenu/XMenu.h from 2011-04-16.
61 <menu_help_message, prev_menu_help_message>: Constify.
62 (IT_menu_make_room): menu->help_text is now `const char **';
63 adjust.
64
65 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
66 to changes in oldXMenu/XMenu.h from 2011-04-16.
67 (struct XMenu): Declare `help_text' `const char **'.
68
69 * xfaces.c <Qunspecified>: Make extern again.
70
71 * syntax.c: Include sys/types.h before including regex.h, as
72 required by Posix.
73
762b15be
EZ
74 * doc.c (get_doc_string): Improve the format passed to `error'.
75
76 * doprnt.c (doprnt): Improve commentary.
77
78 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
79
80 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
81 them with etags.
82
f1052e5d
EZ
83 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
84 changes in globals.h immediately force recompilation.
762b15be
EZ
85 (TAGS): Depend on $(CURDIR)/m/intel386.h and
86 $(CURDIR)/s/ms-w32.h.
87 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 88
fa6996bc
EZ
89 * character.c (Fchar_direction): Function deleted.
90 (syms_of_character): Don't defsubr it.
91 <char-direction-table>: Deleted.
92
e6c3da20
EZ
932011-04-23 Eli Zaretskii <eliz@gnu.org>
94
95 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
96 * doprnt.c: Include limits.h.
97 (SIZE_MAX): New macro.
98 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
99 local variables are now size_t instead of int or unsigned.
100 Improve overflow protection. Support `l' modifier for integer
101 conversions. Support %l conversion. Don't assume an EMACS_INT
102 argument for integer conversions and for %c.
103
104 * lisp.h (doprnt): Restore prototype.
105
106 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
107 $(SRC)/character.h.
108
109 * Makefile.in (base_obj): Add back doprnt.o.
110
111 * deps.mk (doprnt.o): Add back prerequisites.
112 (callint.o): Depend on character.h.
113
114 * eval.c (internal_lisp_condition_case): Include the handler
115 representation in the error message.
116 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
117 when breaking from the loop.
118
119 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
120
121 * callint.c (Fcall_interactively): When displaying error message
122 about invalid control letter, pass the character's codepoint, not
123 a pointer to its multibyte form. Improve display of the character
124 in octal and display also its hex code.
125
126 * character.c (char_string): Use %x to display the (unsigned)
127 codepoint of an invalid character, to avoid displaying a bogus
128 negative value.
129
130 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
131 `error', not SYMBOL_NAME itself.
132
133 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
134 character arguments to `error'.
135
136 * charset.c (check_iso_charset_parameter): Fix incorrect argument
137 to `error' in error message about FINAL_CHAR argument. Make sure
138 FINAL_CHAR is a character, and use %c when it is passed as
139 argument to `error'.
140
4ffd0d6b 1412011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
142
143 * s/ms-w32.h (localtime): Redirect to sys_localtime.
144
145 * w32.c: Include <time.h>.
146 (sys_localtime): New function.
147
4ffd0d6b 1482011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
149
150 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
151
4ffd0d6b 152 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 153
4ffd0d6b 1542011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 155
4ffd0d6b
GM
156 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
157 zombies (Bug#8467).
aac0c6e3 158
04c56954
EZ
1592011-04-19 Eli Zaretskii <eliz@gnu.org>
160
161 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
162 gl_state.e_property when gl_state.object is Qt.
163
164 * insdel.c (make_gap_larger): Remove limitation of buffer size
165 to <= INT_MAX.
166
16a43933
CY
1672011-04-18 Chong Yidong <cyd@stupidchicken.com>
168
169 * xdisp.c (lookup_glyphless_char_display)
170 (produce_glyphless_glyph): Handle cons cell entry in
171 glyphless-char-display.
172 (Vglyphless_char_display): Document it.
173
174 * term.c (produce_glyphless_glyph): Handle cons cell entry in
175 glyphless-char-display.
176
4581706e
CY
1772011-04-17 Chong Yidong <cyd@stupidchicken.com>
178
179 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
180
181 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
182
183 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
184 definition for no-X builds.
185
4887c6e2 1862011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 187
fd35b6f9
PE
188 Static checks with GCC 4.6.0 and non-default toolkits.
189
5c1ccb01
PE
190 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
191
006c5daa
PE
192 * process.c (keyboard_bit_set): Define only if SIGIO.
193 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
194 (send_process): Repair possible setjmp clobbering.
195
efc736d3
PE
196 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
197
4e2fe2e6
PE
198 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
199
f97334a2
PE
200 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
201
4e75f29d
PE
202 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
203 Define only if needed.
204
90efadd1
PE
205 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
206 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 207 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 208
3c647824
PE
209 * dispextern.h (struct redisplay_interface): Rename param
210 to avoid shadowing.
e264f262 211 * termhooks.h (struct terminal): Likewise.
761383f4 212 * xterm.c (xembed_send_message): Likewise.
3c647824 213
b58c5c4a
PE
214 * insdel.c (make_gap_smaller): Define only if
215 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
216
cad59032
PE
217 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
218 it.
219
c339dc2e
PE
220 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
221 so that we aren't warned about unused symbols.
222
91a3e27b
PE
223 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
224
399c71d3 225 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 226
8ffc96f5
PE
227 * xfns.c (x_real_positions): Mark locals as initialized.
228
eef9bc79
PE
229 * xmenu.c (xmenu_show): Don't use uninitialized vars.
230
098db9dd
PE
231 * xterm.c: Fix problems found by static analysis with other toolkits.
232 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
233 (x_dispatch_event): Declare static if USE_GTK, and
234 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 235 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 236 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
237 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
238 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
239
eb18f6cc
PE
240 * xmenu.c (menu_help_callback): Pointer type fixes.
241 Use const pointers when pointing at readonly data. Avoid pointer
242 signedness clashes.
243 (FALSE): Remove unused macro.
244 (update_frame_menubar): Remove unused decl.
245
1fe72bf8
PE
246 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
247
60d9e1db
PE
248 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
249 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
250 (single_menu_item): Rename local to avoid shadowing.
251
39261c26
PE
252 * keyboard.c (make_lispy_event): Remove unused local var.
253
018c5e19
PE
254 * frame.c, frame.h (x_get_resource_string): Bring this back, but
255 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
256
63d2b86e
PE
257 * bitmaps: Change bitmaps from unsigned char back to the X11
258 compatible char. Avoid the old compiler warnings about
259 out-of-range initializers by using, for example, '\xab' rather
260 than 0xab.
261
aefd87e1
PE
262 * xgselect.c (xgselect_initialize): Check vs interface
263 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
264
bf501fb9
PE
265 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
266
e9829fdf
PE
267 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
268 to read-only memory.
269
1086c095
PE
270 * fns.c (vector): Remove; this old hack is no longer needed.
271
2baccd04 272 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 273 Remove unused var.
dde42981 274 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 275
72391843 276 * xrdb.c (x_load_resources): Omit unused local.
3565b346 277
436c16df 278 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 279 (x_window): Rename locals to avoid shadowing.
dc5ddd85 280 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 281
92bb796d 282 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 283 (x_term_init): Remove local to avoid shadowing.
92bb796d 284
764430a3 285 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
286
287 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
288 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
289
d1dfb56c
EZ
2902011-04-16 Eli Zaretskii <eliz@gnu.org>
291
c4354cb4
EZ
292 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
293
d1dfb56c
EZ
294 Fix regex.c, syntax.c and friends for buffers > 2GB.
295 * syntax.h (struct gl_state_s): Declare character position members
296 EMACS_INT.
297
298 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
299
300 * textprop.c (verify_interval_modification, interval_of): Declare
301 arguments EMACS_INT.
302
303 * intervals.c (adjust_intervals_for_insertion): Declare arguments
304 EMACS_INT.
305
306 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
307
308 * indent.c (Fvertical_motion): Local variable it_start is now
309 EMACS_INT.
310
311 * regex.c (re_match, re_match_2, re_match_2_internal)
312 (bcmp_translate, regcomp, regexec, print_double_string)
313 (group_in_compile_stack, re_search, re_search_2, regex_compile)
314 (re_compile_pattern, re_exec): Declare arguments and local
315 variables `size_t' and `ssize_t' and return values `regoff_t', as
316 appropriate.
317 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
318 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
319 <compile_stack_type>: `size' and `avail' are now `size_t'.
320
321 * regex.h <regoff_t>: Use ssize_t, not int.
322 (re_search, re_search_2, re_match, re_match_2): Arguments that
323 specify buffer/string position and length are now ssize_t and
324 size_t. Return type is regoff_t.
325
613052cd
BK
3262011-04-16 Ben Key <bkey76@gmail.com>
327
328 * nsfont.m: Fixed bugs in ns_get_family and
329 ns_descriptor_to_entity that were caused by using free to
330 deallocate memory blocks that were allocated by xmalloc (via
331 xstrdup). This caused Emacs to crash when compiled with
332 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
333 --enable-checking=xmallocoverrun). xfree is now used to
334 deallocate these memory blocks.
335
4170f62f 3362011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 337
71b41406
PE
338 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
339
9587a89d
PE
340 emacs_write: Accept and return EMACS_INT for sizes.
341 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
342 et seq.
343 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
344 Accept and return EMACS_INT.
345 (emacs_gnutls_write): Return the number of bytes written on
346 partial writes.
347 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
348 (emacs_read, emacs_write): Remove check for negative size, as the
349 Emacs source code has been audited now.
9587a89d
PE
350 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
351 (emacs_read, emacs_write): Use it.
273a5f82
PE
352 * process.c (send_process): Adjust to the new signatures of
353 emacs_write and emacs_gnutls_write. Do not attempt to store
354 a byte offset into an 'int'; it might overflow.
9587a89d 355 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 356
3e047f51
PE
357 * sound.c: Don't assume sizes fit in 'int'.
358 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 359 Return EMACS_INT, not int.
3e047f51 360 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
361 Accept EMACS_INT, not int.
362 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
363 record read return values.
364
cc39a9db
BK
3652011-04-15 Ben Key <bkey76@gmail.com>
366
c9d0ec6d
JB
367 * keyboard.c (Qundefined): Don't declare static since it is used
368 in nsfns.m.
369 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
370 static since they are used in nsfont.m.
cc39a9db 371
6c60eb9f
SM
3722011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
373
374 * process.c (Qprocessp): Don't declare static.
375 * lisp.h (Qprocessp): Declare again.
376
7990b61a
JB
3772011-04-15 Juanma Barranquero <lekktu@gmail.com>
378
379 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
380
5d4cb038
PE
3812011-04-14 Paul Eggert <eggert@cs.ucla.edu>
382
8bd7b830 383 Improve C-level modularity by making more things 'static'.
cd64ea1d 384
e3b27b31
PE
385 Don't publish debugger-only interfaces to other modules.
386 * lisp.h (safe_debug_print, debug_output_compilation_hack):
387 (verify_bytepos, count_markers): Move decls to the only modules
388 that need them.
389 * region-cache.h (pp_cache): Likewise.
390 * window.h (check_all_windows): Likewise.
391 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
392
5d4cb038
PE
393 * sysdep.c (croak): Now static, if
394 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
395 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
396
397 * alloc.c (refill_memory_reserve): Now static if
398 !defined REL_ALLOC || defined SYSTEM_MALLOC.
399 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 400
e87b6180
PE
401 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
402 Define only if USE_LUCID.
403
ac64929e
PE
404 * xrdb.c (x_customization_string, x_rm_string): Now static.
405
6f37259d
PE
406 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
407 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
408
1683e3ab
PE
409 * xdisp.c (draw_row_with_mouse_face): Now static.
410 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
411
de9c2632
PE
412 * window.h (check_all_windows): Mark externally visible.
413
2b96acb7
PE
414 * window.c (window_deletion_count): Now static.
415
416 * undo.c: Make symbols static if they're not exported.
417 (last_undo_buffer, last_boundary_position, pending_boundary):
418 Now static.
419
50436f33
PE
420 * textprop.c (interval_insert_behind_hooks): Now static.
421 (interval_insert_in_front_hooks): Likewise.
422
64520e5c
PE
423 * term.c: Make symbols static if they're not exported.
424 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
425 (max_frame_lines, tty_set_terminal_modes):
426 (tty_reset_terminal_modes, tty_turn_off_highlight):
427 (get_tty_terminal): Now static.
428 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
429 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 430 HAVE_WINDOW_SYSTEM.
64520e5c
PE
431 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
432 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
433
1fa53021
PE
434 * sysdep.c: Make symbols static if they're not exported.
435 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
436 Now static.
437 (sigprocmask_set, full_mask): Remove; unused.
438 (wait_debugging): Mark as visible.
439 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
440 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
441
d4b43b22
PE
442 * syntax.c (syntax_temp): Define only if !__GNUC__.
443
b7c513d0
PE
444 * sound.c (current_sound_device, current_sound): Now static.
445
989b29ad
PE
446 * search.c (searchbufs, searchbuf_head): Now static.
447
13a55a78
PE
448 * scroll.c (scroll_cost): Remove; unused.
449 * dispextern.h (scroll_cost): Remove decl.
450
de68a1fc
PE
451 * region-cache.h (pp_cache): Mark as externally visible.
452
40ccffa6
PE
453 * process.c: Make symbols static if they're not exported.
454 (process_tick, update_tick, create_process, chan_process):
455 (Vprocess_alist, proc_buffered_char, datagram_access):
456 (fd_callback_data, send_process_frame, process_sent_to): Now static.
457 (deactivate_process): Mark defn as static, as well as decl.
458 * lisp.h (create_process): Remove decl.
459 * process.h (chan_process, Vprocess_alist): Remove decls.
460
ad64fc97
PE
461 * print.c: Make symbols static if they're not exported.
462 (print_depth, new_backquote_output, being_printed, print_buffer):
463 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
464 (print_interval, print_number_index, initial_stderr_stream):
465 Now static.
466 * lisp.h (Fprinc): Remove decl.
467 (debug_output_compilation_hack): Mark as externally visible.
468
adddb265
PE
469 * sysdep.c (croak): Move decl from here to syssignal.h.
470 * syssignal.h (croak): Put it here, so the API can be checked when
471 'croak' is called from dissociate_if_controlling_tty.
472
1717ede2
PE
473 * minibuf.c: Make symbols static if they're not exported.
474 (minibuf_save_list, choose_minibuf_frame): Now static.
475 * lisp.h (choose_minibuf_frame): Remove decl.
476
fa5fb2bc
PE
477 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
478
1e3890d1
PE
479 * lread.c: Make symbols static if they're not exported.
480 (read_objects, initial_obarray, oblookup_last_bucket_number):
481 Now static.
482 (make_symbol): Remove; unused.
483 * lisp.h (initial_obarray, make_symbol): Remove decls.
484
8a1414fa
PE
485 * keyboard.c: Make symbols static if they're not exported.
486 (single_kboard, recent_keys_index, total_keys, recent_keys):
487 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
488 (this_single_command_key_start, echoing, last_auto_save):
489 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
490 (command_loop, echo_now, keyboard_init_hook, help_char_p):
491 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
492 (Vlispy_mouse_stem, double_click_count):
493 Now static.
494 (force_auto_save_soon): Define only if SIGDANGER.
495 (ignore_mouse_drag_p): Now static if
496 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
497 (print_help): Remove; unused.
498 (stop_character, last_timer_event): Mark as externally visible.
499 * keyboard.h (ignore_mouse_drag_p): Declare only if
500 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
501 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
502 * lisp.h (echoing): Remove decl.
503 (force_auto_save_soon): Declare only if SIGDANGER.
504 * xdisp.c (redisplay_window): Simplify code, to make it more
505 obvious that ignore_mouse_drag_p is not accessed if !defined
506 USE_GTK && !defined HAVE_NS.
507
93ea6e8f
PE
508 * intervals.c: Make symbols static if they're not exported.
509 (merge_properties_sticky, merge_interval_right, delete_interval):
510 Now static.
511 * intervals.h (merge_interval_right, delete_interval): Remove decls.
512
77382fcc
PE
513 * insdel.c: Make symbols static if they're not exported.
514 However, leave prepare_to_modify_buffer alone. It's never
515 called from outside this function, but that appears to be a bug.
516 (combine_after_change_list, combine_after_change_buffer):
4889fc82 517 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
518 (adjust_after_replace_noundo): Remove; unused.
519 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 520 (signal_before_change): Remove decls.
77382fcc 521
9306c32e
PE
522 * indent.c (val_compute_motion, val_vmotion): Now static.
523
cd44d2eb
PE
524 * image.c: Make symbols static if they're not exported.
525 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
526 if USE_GTK.
527 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
528 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
529
ad9a7a06
PE
530 * fringe.c (standard_bitmaps): Now static.
531 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
532
81626931
PE
533 * frame.c: Make symbols static if they're not exported.
534 (x_report_frame_params, make_terminal_frame): Now static.
535 (get_frame_param): Now static, unless HAVE_NS.
536 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
537 (x_get_resource_string): Remove; not used.
538 * frame.h (make_terminal_frame, x_report_frame_params):
539 (x_get_resource_string); Remove decls.
540 (x_fullscreen_adjust): Declare only if WINDOWSNT.
541 * lisp.h (get_frame_param): Declare only if HAVE_NS.
542
239f9db9
PE
543 * font.c, fontset.c: Make symbols static if they're not exported.
544 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
545 (FACE_SUITABLE_FOR_CHAR_P): Use it.
546 * font.c (font_close_object): Now static.
547 * font.h (font_close_object): Remove.
548 * fontset.c (FONTSET_OBJLIST): Remove.
549 (free_realized_fontset) #if-0 the body, which does nothing.
550 (face_suitable_for_char_p): #if-0, as it's never called.
551 * fontset.h (face_suitable_for_char_p): Remove decl.
552 * xfaces.c (face_at_string_position): Use
553 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
554 since 0 is always ASCII.
555
dfcf3579
PE
556 * fns.c (weak_hash_tables): Now static.
557
5045092b
PE
558 * fileio.c: Make symbols static if they're not exported.
559 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
560 (Vwrite_region_annotation_buffers): Now static.
561
57a96f5c
PE
562 * eval.c: Make symbols static if they're not exported.
563 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
564 * lisp.h (backtrace_list): Remove decl.
565
35f08c38
PE
566 * emacs.c: Make symbols static if they're not exported.
567 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
568 (fatal_error_code, fatal_error_signal_hook, standard_args):
569 Now static.
570 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
571 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
572 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
573 * lisp.h (fatal_error_signal_hook): Remove decl.
574 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
575
f44bd759
PE
576 * editfns.c: Move a (normally-unused) function to its only use.
577 * editfns.c, lisp.h (get_operating_system_release): Remove.
578 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
579 worth the hassle of breaking this out.
580
b532497d
PE
581 * xterm.c: Make symbols static if they're not exported.
582 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
583 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
584 (x_destroy_window, x_delete_display):
585 Now static.
586 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
587 (x_mouse_leave): Remove; unused.
588 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
589 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
590 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
591 Remove decls.
592 (x_mouse_leave): Declare only if WINDOWSNT.
593 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
594 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
595 USE_X_TOOLKIT.
596
1675728f
PE
597 * ftxfont.c: Make symbols static if they're not exported.
598 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
599 HAVE_FREETYPE.
600 * font.h (ftxfont_driver): Likewise.
601
e4cebfca
PE
602 * xfns.c: Make symbols static if they're not exported.
603 (x_last_font_name, x_display_info_for_name):
604 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
605 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
606 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
607 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
608 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
609 (last_show_tip_args): Now static.
610 (xic_defaut_fontset, xic_create_fontsetname): Define only if
611 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
612 (x_screen_planes): Remove; unused.
613 * dispextern.h (x_screen_planes): Remove decl.
614
5bf46f05
PE
615 * dispnew.c: Make symbols static if they're not exported.
616 * dispextern.h (redraw_garbaged_frames, scrolling):
617 (increment_row_positions): Remove.
618 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
619 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
620 Now static.
621 (redraw_garbaged_frames): Remove; unused.
622
435f4c28
PE
623 * xfaces.c: Make symbols static if they're not exported.
624 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
625 Remove decls.
626 * xterm.h (defined_color): Remove decls.
627 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
628 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
629 (menu_face_changed_default, defined_color, free_realized_face):
630 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
631 (ascii_face_of_lisp_face): Remove; unused.
632
8524aef3
PE
633 * xdisp.c: Make symbols static if they're not exported.
634 * dispextern.h (scratch_glyph_row, window_box_edges):
635 (glyph_to_pixel_coords, set_cursor_from_row):
636 (get_next_display_element, set_iterator_to_next):
637 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
638 (show_mouse_face): Remove decls
639 * frame.h (message_buf_print): Likewise.
640 * lisp.h (pop_message, set_message, check_point_in_composition):
641 Likewise.
642 * xterm.h (set_vertical_scroll_bar): Likewise.
643 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
644 (message_buf_print, scratch_glyph_row, displayed_buffer):
645 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
646 (get_next_display_element, show_mouse_face, window_box_edges):
647 (frame_to_window_pixel_xy, check_point_in_composition):
648 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
649 (glyph_to_pixel_coords): Remove; unused.
650
16390cd2
PE
651 * dired.c (file_name_completion): Now static.
652
653 * dbusbind.c (xd_in_read_queued_messages): Now static.
654
a25f4dfa
PE
655 * lisp.h (circular_list_error, FOREACH): Remove; unused.
656 * data.c (circular_list_error): Remove.
657
14a9c8df
PE
658 * commands.h (last_point_position, last_point_position_buffer):
659 (last_point_position_window): Remove decls.
660 * keyboard.c: Make these variables static.
661
74ab6df5
PE
662 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
663 decls.
664 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
665 (iso_code_class, detect_coding, code_convert_region): Now static.
666 (encode_coding_gap): Remove; unused.
667
38dfbee1
PE
668 * chartab.c (chartab_chars, chartab_bits): Now static.
669
a2cb4e63
PE
670 * charset.h (charset_iso_8859_1): Remove decl.
671 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
672 Now static.
673
127198fd
PE
674 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
675 * ccl.c (Vccl_program_table): Now static.
676 (check_ccl_update): Remove; unused.
677
d85b608f
PE
678 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
679 * category.h: ... from here.
680 * category.c (check_category_table, set_category_set): Now static.
681
31cd66f3
PE
682 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
683 * lisp.h: Remove these decls.
684
c358e587
PE
685 * buffer.c (buffer_count): Remove unused var.
686
e78aecca
PE
687 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
688 so that it's not optimized away.
689 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
690 * dispextern.h (bidi_dump_cached_states): Remove, since it's
691 exported only to the debugger.
692
e192d7d3
PE
693 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
694 * atimer.h (run_all_atimers): Removed; not exported.
695
92470028
PE
696 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
697 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
698 was inaccessible from Lisp.
699 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
700 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
701
244ed907
PE
702 alloc.c: Import and export fewer symbols, and remove unused items.
703 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
704 is defined.
705 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
706 it's not optimized away by whole-program optimization.
707 (message_enable_multibyte, free_misc): Remove.
708 (catchlist, handlerlist, mark_backtrace):
709 Declare only if BYTE_MARK_STACK.
710 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
711 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
712 (message_enable_multibyte): Remove decl.
713 (free_misc, interval_free_list, float_block, float_block_index):
714 (n_float_blocks, float_free_list, cons_block, cons_block_index):
715 (cons_free_list, last_marked_index):
716 Now static.
717 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
718 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
719 (mark_backtrace): Define only if BYTE_MARK_STACK.
720 * xdisp.c (message_enable_multibyte): Now static.
721
61c2b50e 722 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
723 This makes it easier for human readers (and static analyzers)
724 to see whether these variables are used from other modules.
725 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
726 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
727 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
728 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
729 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
730 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
731 * xmenu.c, xselect.c:
732 Declare Q* vars static if they are not used in other modules.
733 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
734 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
735 Remove decls of unexported vars.
736 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
737
95c82688
PE
738 * lisp.h (DEFINE_FUNC): Make sname 'static'.
739
16a97296
PE
740 Make Emacs functions such as Fatom 'static' by default.
741 This makes it easier for human readers (and static analyzers)
742 to see whether these functions can be called from other modules.
743 DEFUN now defines a static function. To make the function external
744 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
745 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
746 (Finit_image_library):
16a97296
PE
747 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
748 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
749 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
750 Remove decls, since these functions are now static.
751 (Funintern, Fget_internal_run_time): New decls, since these functions
752 were already external.
95c82688 753
16a97296
PE
754 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
755 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
756 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
757 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
758 * keyboard.c, keymap.c, lread.c:
759 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
760 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
761 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
762 Mark functions with DEFUE instead of DEFUN,
763 if they are used in other modules.
764 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
765 decls for now-static functions.
766 * buffer.h (Fdelete_overlay): Remove decl.
767 * callproc.c (Fgetenv_internal): Mark as internal.
768 * composite.c (Fremove_list_of_text_properties): Remove decl.
769 (Fcomposition_get_gstring): New forward static decl.
770 * composite.h (Fcomposite_get_gstring): Remove decl.
771 * dired.c (Ffile_attributes): New forward static decl.
772 * doc.c (Fdocumntation_property): New forward static decl.
773 * eval.c (Ffetch_bytecode): New forward static decl.
774 (Funintern): Remove extern decl; now in .h file where it belongs.
775 * fileio.c (Fmake_symbolic_link): New forward static decl.
776 * image.c (Finit_image_library): New forward static decl.
777 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
778 * intervals.h (Fprevious_property_change):
779 (Fremove_list_of_text_properties): Remove decls.
780 * keyboard.c (Fthis_command_keys): Remove decl.
781 (Fcommand_execute): New forward static decl.
782 * keymap.c (Flookup_key): New forward static decl.
783 (Fcopy_keymap): Now static.
784 * keymap.h (Flookup_key): Remove decl.
785 * process.c (Fget_process): New forward static decl.
786 (Fprocess_datagram_address): Mark as internal.
787 * syntax.c (Fsyntax_table_p): New forward static decl.
788 (skip_chars): Remove duplicate decl.
789 * textprop.c (Fprevious_property_change): New forward static decl.
790 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
791 Now internal.
792 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
793 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
794
785bbd42
PE
795 * editfns.c (Fformat): Remove unreachable code.
796
8b913b57
AS
7972011-04-14 Andreas Schwab <schwab@linux-m68k.org>
798
799 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
800 change. (Bug#8496)
801
a6744a35
EZ
8022011-04-13 Eli Zaretskii <eliz@gnu.org>
803
804 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
805 when at ZV. (Bug#8487)
806
e7974947
AS
8072011-04-12 Andreas Schwab <schwab@linux-m68k.org>
808
baad03f0
AS
809 * charset.c (Fclear_charset_maps): Use xfree instead of free.
810 (Bug#8437)
811 * keyboard.c (parse_tool_bar_item): Likewise.
812 * sound.c (sound_cleanup, alsa_close): Likewise.
813 * termcap.c (tgetent): Likewise.
814 * xfns.c (x_default_font_parameter): Likewise.
815 * xsettings.c (read_and_apply_settings): Likewise.
816
e7974947
AS
817 * alloc.c (overrun_check_malloc, overrun_check_realloc)
818 (overrun_check_free): Protoize.
819
28272684
PE
8202011-04-12 Paul Eggert <eggert@cs.ucla.edu>
821
822 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
823 since callers should never pass a negative size.
824 Change the signature to match that of plain 'read' and 'write'; see
825 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
826 * lisp.h: Update prototypes of emacs_write and emacs_read.
827
11997c76
EZ
8282011-04-11 Eli Zaretskii <eliz@gnu.org>
829
830 * xdisp.c (redisplay_window): Don't try to determine the character
831 position of the scroll margin if the window start point w->startp
e896f03c 832 is outside the buffer's accessible region. (Bug#8468)
11997c76 833
8a2cbd72
EZ
8342011-04-10 Eli Zaretskii <eliz@gnu.org>
835
836 Fix write-region and its subroutines for buffers > 2GB.
837 * fileio.c (a_write, e_write): Modify declaration of arguments and
838 local variables to support buffers larger than 2GB.
839 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
840
841 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
842 argument, local variables, and return value.
843
844 * lisp.h: Update prototypes of emacs_write and emacs_read.
845
846 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
847
4073e537 8482011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 849
1ebfdcb6
PE
850 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
851
b2ded58d
PE
852 Fix more problems found by GCC 4.6.0's static checks.
853
7d66342c
PE
854 * xdisp.c (vmessage): Use a better test for character truncation.
855
bbf47d44
PE
856 * charset.c (load_charset_map): <, not <=, for optimization,
857 and to avoid potential problems with integer overflow.
9248994d 858 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 859 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 860 * editfns.c (Fformat): Likewise.
1e69125e 861 * syntax.c (skip_chars): Likewise.
3befa583 862
e3019616
PE
863 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
864 This also lets GCC 4.6.0 generate slightly better loop code.
865
becfa255
PE
866 * callint.c (Fcall_interactively): <, not <=, for optimization.
867 (Fcall_interactively): Count the number of arguments produced,
868 not the number of arguments given. This is simpler and lets GCC
869 4.6.0 generate slightly better code.
870
dae0cd48
PE
871 * ftfont.c: Distingish more carefully between FcChar8 and char.
872 The previous code passed unsigned char * to a functions like
873 strlen and xstrcasecmp that expect char *, which does not
874 conform to the C standard.
875 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
876 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
877 char * when the C standard requires it.
878
76032d70
PE
879 * keyboard.c (read_char): Remove unused var.
880
eb3f1cc8
PE
881 * eval.c: Port to Windows vsnprintf (Bug#8435).
882 Include <limits.h>.
883 (SIZE_MAX): Define if the headers do not.
884 (verror): Do not give up if vsnprintf returns a negative count.
885 Instead, grow the buffer. This ports to Windows vsnprintf, which
886 does not conform to C99. Problem reported by Eli Zaretskii.
887 Also, simplify the allocation scheme, by avoiding the need for
888 calling realloc, and removing the ALLOCATED variable.
889
70476b54
PE
890 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
891
12020a9e
PE
892 Remove invocations of doprnt, as Emacs now uses vsnprintf.
893 But keep the doprint source code for now, as we might revamp it
894 and use it again (Bug#8435).
ea6c7ae6
PE
895 * lisp.h (doprnt): Remove.
896 * Makefile.in (base_obj): Remove doprnt.o.
897 * deps.mk (doprnt.o): Remove.
898
5fdb398c
PE
899 error: Print 32- and 64-bit integers portably (Bug#8435).
900 Without this change, on typical 64-bit hosts error ("...%d...", N)
901 was used to print both 32- and 64-bit integers N, which relied on
902 undefined behavior.
903 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
904 New macro.
905 * lisp.h (error, verror): Mark as printf-like functions.
906 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
907 Report overflow in size calculations when allocating printf buffer.
908 Do not truncate output string at its first null byte.
909 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
910 Truncate the output at a character boundary, since vsnprintf does not
911 do that.
912 * charset.c (check_iso_charset_parameter): Convert internal
913 character to string before calling 'error', since %c now has the
914 printf meaning.
915 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
916 overflow when computing char to be passed to 'error'. Do not
917 pass Lisp_Object to 'error'; pass the integer instead.
918 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
919 formatted with plain %d.
920
b189fa66
PE
921 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
922
bff87ef0
PE
923 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
924
7e2cac20
PE
925 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
926
ce4d90b5
PE
927 * xterm.c (x_catch_errors): Remove duplicate declaration.
928
266c9547
PE
929 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
930
79c49ad2
PE
931 * xdisp.c, lisp.h (message_nolog): Remove; unused.
932
368f4090
JM
9332011-04-10 Jim Meyering <meyering@redhat.com>
934
935 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
936 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
937 return ssize_t not "int", and use size_t as the buffer length.
938 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
939 * gnutls.h: Update declarations.
940 * process.c (read_process_output): Use ssize_t, to match.
941 (send_process): Likewise.
942
a32d4040
CY
9432011-04-09 Chong Yidong <cyd@stupidchicken.com>
944
945 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
946
8546720e 9472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 948
8546720e
GM
949 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
950 unsigned char, to match FcChar8 type definition.
aac0c6e3 951
8546720e
GM
952 * xterm.c (handle_one_xevent):
953 * xmenu.c (create_and_show_popup_menu):
954 * xselect.c (x_decline_selection_request)
955 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 956
0a2f5c1a 9572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
958
959 Fix some uses of `int' instead of EMACS_INT.
960 * search.c (string_match_1, fast_string_match)
961 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
962 (scan_buffer, find_next_newline_no_quit)
963 (find_before_next_newline, search_command, Freplace_match)
964 (Fmatch_data): Make some `int' variables be EMACS_INT.
965
966 * xdisp.c (display_count_lines): 3rd argument and return value now
967 EMACS_INT. All callers changed.
968 (pint2hrstr): Last argument is now EMACS_INT.
969
970 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
971 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
972 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
973 (decode_coding_utf_16, decode_coding_emacs_mule)
974 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
975 (decode_coding_ccl, decode_coding_charset)
976 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
977 (decode_coding_iso_2022, decode_coding_emacs_mule)
978 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
979 <char_offset, last_offset>: Declare EMACS_INT.
980 (encode_coding_utf_8, encode_coding_utf_16)
981 (encode_coding_emacs_mule, encode_invocation_designation)
982 (encode_designation_at_bol, encode_coding_iso_2022)
983 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
984 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
985 Declare EMACS_INT.
986 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
987 (encode_invocation_designation): Last argument P_NCHARS is now
988 EMACS_INT.
989 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
990 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
991
992 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
993 All users changed.
994
995 * ccl.c (Fccl_execute_on_string): Declare some variables
996 EMACS_INT.
997
8546720e 9982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
999
1000 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1001
4e19a977
CS
10022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1003
1004 * process.c (Fformat_network_address): Doc fix.
1005
87302331
R
10062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1007
1008 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1009
cbb59342
CY
10102011-04-08 Chong Yidong <cyd@stupidchicken.com>
1011
1012 * keyboard.c (read_char): Call Lisp function help-form-show,
1013 instead of using internal_with_output_to_temp_buffer.
1014 (Qhelp_form_show): New var.
e0d38eeb 1015 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1016
1017 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1018
1019 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1020
e67a13ab
CY
10212011-04-06 Chong Yidong <cyd@stupidchicken.com>
1022
1023 * process.c (Flist_processes): Removed to Lisp.
1024 (list_processes_1): Deleted.
1025
973f782d
EZ
10262011-04-06 Eli Zaretskii <eliz@gnu.org>
1027
7c106b1e
EZ
1028 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1029
973f782d
EZ
1030 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1031
41cf7d1a 10322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1033
ca23cc88
PE
1034 Fix more problems found by GCC 4.6.0's static checks.
1035
f390e2d5
PE
1036 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1037
42eea0d0
PE
1038 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1039
b69769da 1040 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1041
f9541e84
PE
1042 * xdisp.c (vmessage): Mark as a printf-like function.
1043
13841b55
PE
1044 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1045
c136c10f
PE
1046 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1047
5e2d4a30
PE
1048 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1049 printf-like functions.
1050 (tiff_load): Add casts to remove these marks before passing them
1051 to system-supplied API.
1052
583f48b9
PE
1053 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1054
b25d760e
PE
1055 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1056 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1057 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1058 directly, rather than having caller test rule sign. This avoids
1059 some unnecessary tests.
1060 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1061 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1062 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1063
bc7b6697 1064 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1065 (xfont_open): Avoid unnecessary tests.
bc7b6697 1066
27ccc379
PE
1067 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1068
dcd5c89a
PE
1069 * composite.h, composite.c (composition_gstring_put_cache):
1070 Use EMACS_INT, not int, for length.
1071
b13a45c6
PE
1072 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1073 breaking out part of COMPOSITION_DECODE_RULE.
1074 (COMPOSITION_DECODE_RULE): Use it.
1075 * composite.c (get_composition_id): Remove unused local vars,
1076 by using the new macro.
1077
1e792e4d
PE
1078 * textprop.c (set_text_properties_1): Change while to do-while,
1079 since the condition is always true at first.
1080
dc6c6455 1081 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1082 (interval_deletion_adjustment): Return unsigned value.
1083 All uses changed.
dc6c6455 1084
aba7731a
PE
1085 * process.c (list_processes_1, create_pty, read_process_output):
1086 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1087 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1088 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1089 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1090 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1091
fdfc4bf3
PE
1092 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1093
fca8fe46 1094 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1095 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1096
06a0259a 1097 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1098 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1099 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1100
e7b9e80f
PE
1101 * print.c (print_error_message): Avoid int overflow.
1102
56201685
PE
1103 * font.c (font_list_entities): Redo for clarity,
1104 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1105
78834453 1106 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1107 (font_score): Avoid potential overflow in diff calculation.
78834453 1108
0bc0b309 1109 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1110 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1111
e610eaca
PE
1112 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1113
b895abce
PE
1114 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1115 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1116 can always succeed if overflow has undefined behavior.
1117
1f1d9321 1118 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1119 (wordify): Omit three unnecessary tests.
1f1d9321 1120
c59478bc
PE
1121 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1122 All callers changed. This avoids the need for an unused var.
1123
79b73827
PE
1124 * casefiddle.c (casify_region): Remove var that is set but not used.
1125
a4db5dfe
PE
1126 * dired.c (file_name_completion): Remove var that is set but not used.
1127
43aae36e
PE
1128 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1129
2a47c44d 1130 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1131 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1132
a37c69bf
PE
1133 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1134 Check for integer overflow on size calculations.
1135
328ab8e7
PE
1136 * buffer.c (Fprevious_overlay_change): Remove var that is set
1137 but not used.
1138
e5a2a5cb
PE
1139 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1140 Remove vars that are set but not used.
8d84a6eb 1141 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1142 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1143
a60e5f68
PE
1144 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1145
f661cb61 1146 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1147 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1148
f0397f5a
PE
1149 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1150 that are set but not used.
1151
8664db06 1152 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1153 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1154
6abdaa4a
PE
1155 * xselect.c (x_get_local_selection, x_handle_property_notify):
1156 Remove vars that are set but not used.
1157
0ce7538d 1158 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1159 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1160
9ae848fc
PE
1161 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1162 Remove var that is set but not used.
0b918413
PE
1163 (scroll_bar_windows_size): Now size_t, not int.
1164 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1165 Check for overflow.
9ae848fc 1166
a5a62657
PE
1167 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1168 (map_tty_color) [!defined MSDOS]: Likewise.
1169
5c5cdd39
PE
1170 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1171
66ebf983
PE
1172 * coding.c: Remove vars that are set but not used.
1173 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1174 All callers changed.
1175 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1176 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1177 (decode_coding_charset): Remove vars that are set but not used.
1178
1be4d761
PE
1179 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1180 that is set but not used.
1181
47553fa8
PE
1182 * print.c (print_object): Remove var that is set but not used.
1183
1f7196bf 1184 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1185 The gnulib version avoids calling malloc in the usual case,
1186 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1187 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1188 * filelock.c (current_lock_owner): Likewise.
1189 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1190 * sysdep.c: Include allocator.h, careadlinkat.h.
1191 (emacs_no_realloc_allocator): New static constant.
1192 (emacs_readlink): New function.
fdb61804
PE
1193 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1194 ../lib/careadlinkat.h.
d1fdcab7 1195
f84c17c7
SM
11962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1197
1198 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1199 first non-nil return value).
1200
ef3862ad
JD
12012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1202
1203 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1204 if not defined (Bug#8403).
1205
376a7006
JB
12062011-04-02 Juanma Barranquero <lekktu@gmail.com>
1207
1208 * xdisp.c (display_count_lines): Remove parameter `start',
1209 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1210 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1211 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1212 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1213 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1214 and thereabouts. All callers changed.
1215 (get_per_char_metric): Remove parameter `f', unused since
1216 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1217
6ca3801d
JM
12182011-04-02 Jim Meyering <meyering@redhat.com>
1219
1220 do not dereference NULL upon failed strdup
1221 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1222 (ns_get_family): Likewise.
1223
d8e2b5ba
JB
12242011-04-02 Juanma Barranquero <lekktu@gmail.com>
1225
1226 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1227
8c74fcbd
JD
12282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1229
1230 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1231 later (Bug#8403).
1232
7200d79c
SM
12332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1234
03408648 1235 Add lexical binding.
7200d79c 1236
03408648
SM
1237 * window.c (Ftemp_output_buffer_show): New fun.
1238 (Fsave_window_excursion):
1239 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1240
1241 * lread.c (lisp_file_lexically_bound_p): New function.
1242 (Fload): Bind Qlexical_binding.
1243 (readevalloop): Remove `evalfun' arg.
1244 Bind Qinternal_interpreter_environment.
1245 (Feval_buffer): Bind Qlexical_binding.
1246 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1247 Mark as dynamic.
1248 (syms_of_lread): Declare `lexical-binding'.
1249
1250 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1251
1252 * keyboard.c (eval_dyn): New fun.
1253 (menu_item_eval_property): Use it.
ca105506
SM
1254
1255 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1256
03408648
SM
1257 * fns.c (concat, mapcar1): Accept byte-code-functions.
1258
1259 * eval.c (Fsetq): Handle lexical vars.
1260 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1261 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1262 (FletX, Flet): Obey lexical binding.
1263 (Fcommandp): Handle closures.
1264 (Feval): New `lexical' arg.
1265 (eval_sub): New function extracted from Feval. Use it almost
1266 everywhere where Feval was used. Look up vars in lexical env.
1267 Handle closures.
1268 (Ffunctionp): Move from subr.el.
1269 (Ffuncall): Handle closures.
1270 (apply_lambda): Remove `eval_flags'.
1271 (funcall_lambda): Handle closures and new byte-code-functions.
1272 (Fspecial_variable_p): New function.
1273 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1274 but without exporting it to Lisp.
23aba0ea 1275
23aba0ea 1276 * doc.c (Fdocumentation, store_function_docstring):
03408648 1277 * data.c (Finteractive_form): Handle closures.
23aba0ea 1278
03408648
SM
1279 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1280 interactive spec.
ba83908c 1281
03408648
SM
1282 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1283 byte-codes.
1284 (exec_byte_code): New function extracted from Fbyte_code to handle new
1285 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1286
03408648 1287 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1288
03408648 1289 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1290
e2abce01
JB
12912011-03-31 Juanma Barranquero <lekktu@gmail.com>
1292
1293 * xdisp.c (redisplay_internal): Fix prototype.
1294
63696a73 12952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1296
63696a73
EZ
1297 * xdisp.c (SCROLL_LIMIT): New macro.
1298 (try_scrolling): Use it when setting scroll_limit. Limit
1299 scrolling to 100 screen lines.
1300 (redisplay_window): Even when falling back on "recentering",
1301 position point in the window according to scroll-conservatively,
1302 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1303
1304 (try_scrolling): When point is above the window, allow searching
1305 as far as scroll_max, or one screenful, to compute vertical
1306 distance from PT to the scroll margin position. This prevents
1307 try_scrolling from unnecessarily failing when
1308 scroll-conservatively is set to a value slightly larger than the
1309 window height. Clean up the case of PT below the margin at bottom
1310 of window: scroll_max can no longer be INT_MAX. When aggressive
1311 scrolling is in use, don't let point enter the opposite scroll
1312 margin as result of the scroll.
1313 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1314 threshold of 100 lines for never-recentering scrolling.
1315
e4cc2dfc
JB
13162011-03-31 Juanma Barranquero <lekktu@gmail.com>
1317
1318 * dispextern.h (move_it_by_lines):
1319 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1320 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1321 (message_log_check_duplicate): Remove parameters `prev_bol' and
1322 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1323 (redisplay_internal): Remove parameter `preserve_echo_area',
1324 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1325
1326 * indent.c (Fvertical_motion):
1327 * window.c (window_scroll_pixel_based, Frecenter):
1328 Don't pass `need_y_p' to `move_it_by_lines'.
1329
1c470562
SM
13302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1331
44f230aa
SM
1332 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1333 steal a few bits to be more compact.
1334 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1335 Remove unneeded casts.
1336
1c470562
SM
1337 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1338
888adce9
ZK
13392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1340
1341 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1342 binding" message (bug#7967).
1343
f838ed7b
PE
13442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1345
77861b95
PE
1346 Fix more problems found by GCC 4.6.0's static checks.
1347
de6dbc14
PE
1348 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1349 Remove unused local var.
1350
f838ed7b
PE
1351 * editfns.c (Fmessage_box): Remove unused local var.
1352
792c7b2b
PE
1353 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1354 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1355 Omit unused local vars.
c499e557 1356 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1357 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1358 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1359 Omit unused local var.
1360
ba0165e1
PE
1361 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1362 Don't assume string length fits in int.
32ad8845 1363 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1364 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1365
3c59b4c9
PE
1366 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1367 instead of alloca (Bug#8344).
1368
a3eed478 1369 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1370 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1371
eb4d412d
PE
1372 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1373
1658b401
PE
1374 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1375 concerns.
1376
1377 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1378
1379 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1380
9a2c6e05
PE
1381 * keyboard.c (syms_of_keyboard): Use the same style as later
1382 in this function when indexing through an array. This also
1383 works around GCC bug 48267.
1384
03d0a109
PE
1385 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1386
44f730c8
PE
1387 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1388
fe75f926
PE
1389 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1390 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1391
ffa8c828
PE
1392 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1393 This avoids undefined behavior on integer overflow, and is a bit
1394 more convenient anyway since it is compared to a size_t variable.
1395
c5101a77
PE
1396 Variadic C functions now count arguments with size_t, not int.
1397 This avoids an unnecessary limitation on 64-bit machines, which
1398 caused (substring ...) to crash on large vectors (Bug#8344).
1399 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1400 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1401 All variadic functions and their callers changed accordingly.
c5101a77
PE
1402 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1403 * data.c (arith_driver, float_arith_driver): Likewise.
1404 * editfns.c (general_insert_function): Likewise.
1405 * eval.c (struct backtrace.nargs, interactive_p)
1406 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1407 (funcall_lambda, mark_backtrace): Likewise.
1408 * fns.c (concat): Likewise.
1409 * frame.c (x_set_frame_parameters): Likewise.
1410 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1411 0 if not found, not -1. All callers changed.
1412
dd3f25f7
PE
1413 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1414 (stack_copy_size): Now size_t, not int.
1415 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1416
461c2ab9
JB
14172011-03-28 Juanma Barranquero <lekktu@gmail.com>
1418
1419 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1420 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1421 All callers changed.
1422
1423 * lisp.h (multibyte_char_to_unibyte):
1424 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1425 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1426 * character.h (CHAR_TO_BYTE8):
1427 * cmds.c (internal_self_insert):
1428 * editfns.c (general_insert_function):
1429 * keymap.c (push_key_description):
1430 * search.c (Freplace_match):
1431 * xdisp.c (message_dolog, set_message_1): All callers changed.
1432
f6d62986
SM
14332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1434
1435 * keyboard.c (safe_run_hook_funcall): New function.
1436 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1437 don't set the hook to nil, but remove the offending function instead.
1438 (Qcommand_hook_internal): Remove, unused.
1439 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1440 Vcommand_hook_internal.
1441
1442 * eval.c (enum run_hooks_condition): Remove.
1443 (funcall_nil, funcall_not): New functions.
1444 (run_hook_with_args): Call each function through a `funcall' argument.
1445 Remove `cond' argument, now redundant.
1446 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1447 (Frun_hook_with_args_until_failure): Adjust accordingly.
1448 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1449
1db5b1ad
JB
14502011-03-28 Juanma Barranquero <lekktu@gmail.com>
1451
1452 * dispextern.h (string_buffer_position): Remove declaration.
1453
1454 * print.c (strout): Remove parameter `multibyte', unused since
1455 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1456
1457 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1458 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1459 All callers changed.
1460
1461 * w32.c (_wsa_errlist): Use braces for struct initializers.
1462
1463 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1464 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1465 All callers changed.
1466 (string_buffer_position): Likewise. Also, make static (it's never
1467 used outside xdisp.c).
1468 (cursor_row_p): Remove parameter `w', unused since
1469 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1470 (decode_mode_spec): Remove parameter `precision', introduced during
1471 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1472 All callers changed.
1473
5ffb62aa
JD
14742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1475
1476 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1477
461c2ab9 14782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1479
1480 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1481 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1482 (ns_update_auto_hide_menu_bar): New functions.
1483 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1484 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1485 ns_constrain_all_frames.
1486 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1487 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1488
5c380ffb
JD
14892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1490
1491 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1492
9af30bdf
GM
14932011-03-27 Glenn Morris <rgm@gnu.org>
1494
1495 * syssignal.h: Replace RETSIGTYPE with void.
1496 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1497 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1498 Replace SIGTYPE with void everywhere.
1499 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1500 * s/template.h (SIGTYPE): Remove commented out definition.
1501
e2abce01
JB
15022011-03-26 Eli Zaretskii <eliz@gnu.org>
1503
1504 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1505 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1506
f868cd8a
JB
15072011-03-26 Juanma Barranquero <lekktu@gmail.com>
1508
59eb0929
JB
1509 * w32.c (read_unc_volume): Use parameter `henum', instead of
1510 global variable `wget_enum_handle'.
1511
1512 * keymap.c (describe_vector): Remove parameters `indices' and
1513 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1514 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1515
f868cd8a
JB
1516 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1517
1518 * keyboard.c (timer_check): Remove parameter `do_it_now',
1519 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1520 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1521 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1522
1523 * keyboard.c (read_char):
1524 * w32menu.c (w32_menu_display_help):
1525 * xmenu.c (show_help_event, menu_help_callback):
1526 Adjust calls to `show_help_echo'.
1527
1528 * gtkutil.c (xg_maybe_add_timer):
1529 * keyboard.c (readable_events):
1530 * process.c (wait_reading_process_output):
1531 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1532
1533 * insdel.c (adjust_markers_gap_motion):
1534 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1535 (gap_left, gap_right): Don't call it.
1536
2ecf6fdb
CY
15372011-03-25 Chong Yidong <cyd@stupidchicken.com>
1538
1539 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1540 incurred during fontification.
1541
6b1f9ba4
JB
15422011-03-25 Juanma Barranquero <lekktu@gmail.com>
1543
1544 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1545 (DEFVAR_PER_BUFFER): Don't pass it.
1546
1547 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1548 (scrolling_window): Don't pass it.
1549
0f4a96b5
JB
15502011-03-25 Juanma Barranquero <lekktu@gmail.com>
1551
1552 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1553
1554 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1555 and `suffix'.
1556 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1557 of variables specific to SELinux and computation of `encoded_absname'.
1558
1559 * image.c (XPutPixel): Remove unused variable `height'.
1560
1561 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1562
1563 * unexw32.c (get_section_info): Remove unused variable `section'.
1564
1565 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1566 (system_process_attributes): Remove unused variable `sess'.
1567 (sys_read): Remove unused variable `err'.
1568
1569 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1570 (w32_wnd_proc): Remove unused variable `isdead'.
1571 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1572 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1573 (x_create_tip_frame): Remove unused variable `tem'.
1574
1575 * w32inevt.c (w32_console_read_socket):
1576 Remove unused variable `no_events'.
1577
1578 * w32term.c (x_draw_composite_glyph_string_foreground):
1579 Remove unused variable `width'.
1580
1149507c
JB
15812011-03-24 Juanma Barranquero <lekktu@gmail.com>
1582
1583 * w32term.c (x_set_glyph_string_clipping):
1584 Don't pass uninitialized region to CombineRgn.
1585
9c88f339
JB
15862011-03-23 Juanma Barranquero <lekktu@gmail.com>
1587
1588 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1589 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1590 (Fx_close_connection): Remove unused variable `i'.
1591
1592 * w32font.c (w32font_draw): Return number of glyphs.
1593 (w32font_open_internal): Remove unused variable `i'.
1594 (w32font_driver): Add missing initializer.
1595
1596 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1597 (fill_in_menu): Remove unused variable `items_added'.
1598
1599 * w32term.c (last_mouse_press_frame): Remove static global variable.
1600 (w32_clip_to_row): Remove unused variable `f'.
1601 (x_delete_terminal): Remove unused variable `i'.
1602
1603 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1604 (NOTHING): Remove unused static global variable.
1605 (uniscribe_check_otf): Remove unused variable `table'.
1606 (uniscribe_font_driver): Add missing initializers.
1607
dee091a3
JD
16082011-03-23 Julien Danjou <julien@danjou.info>
1609
1610 * term.c (Fsuspend_tty, Fresume_tty):
1611 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1612 * window.c (temp_output_buffer_show):
1613 * insdel.c (signal_before_change):
1614 * frame.c (Fhandle_switch_frame):
1615 * fileio.c (Fdo_auto_save):
1616 * emacs.c (Fkill_emacs):
1617 * editfns.c (save_excursion_restore):
1618 * cmds.c (internal_self_insert):
1619 * callint.c (Fcall_interactively):
1620 * buffer.c (Fkill_all_local_variables):
1621 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1622 Use Frun_hooks.
0f4a96b5 1623 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1624 unconditionnaly since it does the check itself.
1625
2c520ab5 16262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1627
c9c49752
PE
1628 Fix more problems found by GCC 4.5.2's static checks.
1629
8abc3f12
PE
1630 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1631 the first time through the loop, since we know p0 < p1 then.
1632 This also avoids a gcc -Wstrict-overflow warning.
1633
a2d26660
PE
1634 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1635 leading to a memory leak, possible in functions like
1636 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1637 of objects (Bug#8318).
a2d26660 1638
916c72e9
PE
1639 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1640 that could (at least in theory) be that large.
1641
19ab8a18
PE
1642 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1643 This is less likely to overflow, and avoids undefined behavior if
1644 overflow does occur. All callers changed. Use strtoul to scan
1645 for the unsigned long integer.
b7cbbd6f
PE
1646 (pint2hrstr): Simplify and tune code slightly.
1647 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1648
f0641eff
PE
1649 * scroll.c (do_scrolling): Work around GCC bug 48228.
1650 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1651
7f650bb9
PE
1652 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1653 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1654 (validate_x_resource_name): Simplify count usage.
1655 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1656
37dd57d1
PE
1657 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1658 fail (Bug#8306).
81e56e61 1659
699979fc 1660 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1661
401bf9b4
PE
1662 * process.c (Fmake_network_process): Use socklen_t, not int,
1663 where POSIX says socklen_t is required in portable programs.
1664 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1665 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1666 (Fmake_network_process, server_accept_connection):
1667 (wait_reading_process_output, read_process_output):
1668 Likewise.
1669
b93aacde
PE
1670 * process.c: Rename or move locals to avoid shadowing.
1671 (list_processes_1, Fmake_network_process):
1672 (read_process_output_error_handler, exec_sentinel_error_handler):
1673 Rename or move locals.
4dc343ee 1674 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1675 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1676 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1677 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1678 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1679
af8a867c 1680 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1681 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1682 Include tparam.h instead, since it declares them.
af8a867c
PE
1683 * cm.h (PC): Remove extern decl; tparam.h now does this.
1684 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1685 * terminfo.c: Include tparam.h, to check interfaces.
1686 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1687 (tparam): Adjust signature to match interface in tparam.h;
1688 this removes some undefined behavior. Check that outstring and len
1689 are zero, which they always are with Emacs.
1690 * tparam.h (PC, BC, UP): New extern decls.
1691
0248044d 1692 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1693 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1694
8ff096c1 1695 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1696 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1697 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1698 (ftfont_list): Remove unused local.
49eaafba
PE
1699 (get_adstyle_property, ftfont_pattern_entity):
1700 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1701 Rename locals to avoid shadowing.
8ff096c1 1702
e2be39f6
PE
1703 * xfont.c (xfont_list_family): Mark var as initialized.
1704
c9735e30
PE
1705 * xml.c (make_dom): Now static.
1706
8f5201ae
PE
1707 * composite.c (composition_compute_stop_pos): Rename local to
1708 avoid shadowing.
b246f932
PE
1709 (composition_reseat_it): Remove unused locals.
1710 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1711 (composition_update_it): Mark var as initialized.
11b61122
PE
1712 (find_automatic_composition): Mark vars as initialized,
1713 with a FIXME (Bug#8290).
8f5201ae 1714
760fbc2c
PE
1715 character.h: Rename locals to avoid shadowing.
1716 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1717 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1718 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1719 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1720 to avoid shadowing.
1721
ff08eb85
PE
1722 * textprop.c (property_change_between_p): Remove; unused.
1723
fc7bf025
PE
1724 * intervals.c (interval_start_pos): Now static.
1725
235d7abc
PE
1726 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1727
44f230aa
SM
1728 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1729 Rename locals to avoid shadowing.
3e7d6594 1730
50060332
PE
1731 * sound.c (wav_play, au_play, Fplay_sound_internal):
1732 Fix pointer signedness.
d01f234b 1733 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1734 (wav_play): Initialize a variable to 0, to prevent undefined
1735 behavior (Bug#8278).
50060332 1736
c4fc4e30
PE
1737 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1738
918436ed
PE
1739 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1740
c939f91b
PE
1741 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1742 clobbering (Bug#8298).
b9c7f648
PE
1743 * sysdep.c (sys_subshell): Likewise.
1744 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1745
6bd8c144
PE
1746 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1747 This should get cleaned up, so that child_setup has the
1748 same signature on all platforms.
1749
7710357c 1750 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1751 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1752
c59da222
CY
17532011-03-22 Chong Yidong <cyd@stupidchicken.com>
1754
1755 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1756 not to be necessary, and produces flickering.
1757
66b87493
GM
17582011-03-20 Glenn Morris <rgm@gnu.org>
1759
1760 * config.in: Remove file.
1761
45b6f6d5
JB
17622011-03-20 Juanma Barranquero <lekktu@gmail.com>
1763
1764 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1765 are now in src/globals.h.
1766 (syms_of_minibuf): Remove spurious & from previous change.
1767
3ec03f7e
LL
17682011-03-20 Leo <sdl.web@gmail.com>
1769
1770 * minibuf.c (completing-read-function): New variable.
1771 (completing-read-default): Rename from completing-read.
1772 (completing-read): Call completing-read-function.
1773
b14e3e21
CY
17742011-03-19 Juanma Barranquero <lekktu@gmail.com>
1775
1776 * xfaces.c (Fx_load_color_file):
1777 Read color file from absolute filename (bug#8250).
1778
f2b726e6
JB
17792011-03-19 Juanma Barranquero <lekktu@gmail.com>
1780
1781 * makefile.w32-in: Update dependencies.
1782
09f6ff02
EZ
17832011-03-17 Eli Zaretskii <eliz@gnu.org>
1784
1785 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1786
29a6015a
PE
17872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1788
a3a6c54e
PE
1789 Fix more problems found by GCC 4.5.2's static checks.
1790
b766f867
PE
1791 * process.c (make_serial_process_unwind, send_process_trap):
1792 (sigchld_handler): Now static.
1793
be02381c
PE
1794 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1795 That way, the code declares only the vars that it needs.
1796 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1797 * s/cygwin.h (PTY_ITERATION): Likewise.
1798 * s/darwin.h (PTY_ITERATION): Likewise.
1799 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1800
57048744
PE
1801 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1802 * process.c (allocate_pty): Don't declare stb unless it's needed.
1803
7914961c 1804 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1805 (CONSTANTLIM): Remove; unused.
1806 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1807 Define only if needed.
7914961c 1808
b3967b18
PE
1809 * unexelf.c (unexec): Name an expression,
1810 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1811 Use a different way to cause a compilation error if anyone uses
1812 n rather than nn, a way that does not involve shadowing.
73366a00 1813 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1814
29a6015a
PE
1815 * deps.mk (unexalpha.o): Remove; unused.
1816
43cfc33e 1817 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1818 * unexec.h: New file.
ce701a33
PE
1819 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1820 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1821 Depend on unexec.h.
1822 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1823 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1824 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1825 Change as necessary to match prototype in unexec.h.
ce701a33 1826
01f44d5a
PE
1827 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1828 shadowing.
4f63c6bb 1829 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1830
a6670b0b
PE
1831 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1832 Rename locals to avoid shadowing.
1833
cef2010d 1834 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1835 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1836
d4d7173a
PE
1837 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1838
f08b802a
PE
1839 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1840 warning when compiling print.c.
1841
3ddb0639
PE
1842 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1843 instead of using an uninitialized var.
5ad03b97 1844 (font_sort_entities): Mark var as initialized.
3ddb0639 1845
170a2692
PE
1846 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1847
e663c700
PE
1848 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1849 pointers to constants.
89bc529a 1850 (font_parse_fcname): Remove unused vars.
7b81e2d0 1851 (font_delete_unmatched): Now static.
ea838e10 1852 (font_get_spec): Remove; unused.
13a547c6
PE
1853 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1854 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1855 Rename or move locals to avoid shadowing.
e663c700 1856
2a80c887 1857 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1858 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1859
1384fa33 1860 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1861 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1862
8b2c52e9
PE
1863 * alloc.c (mark_backtrace): Move decl from here ...
1864 * lisp.h: ... to here, so that it can be checked.
1865
475545b5 1866 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1867 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1868 (lisp_indirect_variable): Name an expression,
1869 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1870 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1871
b1349114 1872 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1873 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1874 Use const pointer when appropriate.
b1349114 1875
a2928364
PE
1876 * lisp.h (get_system_name, get_operating_system_release):
1877 Move decls here, to check interfaces.
1878 * process.c (get_operating_system_release): Move decl to lisp.h.
1879 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1880 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1881 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1882 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1883 (Fformat_time_string, Fencode_time, Finsert_char):
1884 (Ftranslate_region_internal, Fformat):
1885 Rename or remove local vars to avoid shadowing.
9710023e 1886 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1887
a415e694
PE
1888 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1889 avoid shadowing.
1890
8ef4622d
PE
1891 * lisp.h (eassert): Check that the argument compiles, even if
1892 ENABLE_CHECKING is not defined.
1893
946f9a5b
PE
1894 * data.c (Findirect_variable): Name an expression, to avoid
1895 gcc -Wbad-function-cast warning.
112396d6 1896 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1897 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1898 (Fmake_variable_buffer_local, Fmake_local_variable):
1899 Mark variables as initialized.
52746918 1900 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1901
e5aab7e7 1902 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1903 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1904 Rename locals to avoid shadowing.
dff45157
PE
1905 (mark_stack): Move local variables into the #ifdef region where
1906 they're used.
7bc26fdb
PE
1907 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1908 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1909 needed otherwise.
1910 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1911 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1912 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1913
e5aab7e7
PE
1914 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1915 avoids undefined behavior in theory.
1916
4da60324
PE
1917 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1918
88043301
PE
1919 Use functions, not macros, for up- and down-casing (Bug#8254).
1920 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1921 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1922 to use the following functions instead of these macros.
1923 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1924 EMACS_INT, since callers assume the returned value fits in int.
1925 (upcase1): Likewise, for UPCASE_TABLE.
1926 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1927 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1928 the race-condition problem in the old DOWNCASE.
88043301 1929
19ed5445
PE
1930 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1931 Rename locals to avoid shadowing.
1932 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1933 (regex_compile, re_search_2, re_match_2_internal):
1934 Remove unused local vars.
952db0d7
PE
1935 (FREE_VAR): Rewrite so as not to use empty "else",
1936 which gcc can warn about.
da053e48 1937 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1938 (RETALLOC_IF): Define only if needed.
1939 (WORDCHAR_P): Likewise. This one is never needed, but is used
1940 only in a comment talking about a compiler bug, so put inside
1941 the #if 0 of that comment.
1942 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1943 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1944 Remove; unused.
19ed5445 1945
1f3561e4 1946 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1947 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1948 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1949
ded6f8f7
PE
1950 * search.c (simple_search): Remove unused var.
1951
dbd37a95
PE
1952 * dired.c (compile_pattern): Move decl from here ...
1953 * lisp.h: ... to here, so that it can be checked.
1954 (struct re_registers): New forward decl.
1955
7e47afad
PE
1956 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1957
85f24f61
PE
1958 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1959 All uses changed.
1960 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1961 Rename locals to avoid shadowing.
5671df8f 1962 (Fvertical_motion): Mark locals as initialized.
85f24f61 1963
181aa2be 1964 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1965 (casify_region): Mark local as initialized.
181aa2be 1966
930d429c
PE
1967 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1968
7082eac6
PE
1969 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1970 New macros, so that the caller can use some names other than
1971 gcpro1, gcpro2, etc.
1972 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1973 of the new macros.
1974 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1975 argument, for consistency with GCPRO2_VAR, etc: it is now the
1976 prefix of the variable, not the variable itself. All uses
1977 changed.
38b2c076
PE
1978 * dired.c (directory_files_internal, file_name_completion):
1979 Rename locals to avoid shadowing.
1980
15206ed9
PE
1981 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1982 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1983 dired.c's scmp function, had undefined behavior.
1984 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1985 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1986 * buffer.h: ... to here, because these macros use current_buffer,
1987 and the new implementation with inline functions needs to have
1988 current_buffer in scope now, rather than later when the macros
1989 are used.
1990 (downcase, upcase1): New static inline functions.
1991 (DOWNCASE, UPCASE1): Reimplement using these functions.
1992 This avoids undefined behavior in expressions like
1993 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1994 from race conditions in accessing the global variables
1995 case_temp1 and case_temp2.
1996 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1997 * lisp.h (case_temp1, case_temp2): Remove their decls.
1998 * character.h (ASCII_CHAR_P): Move from here ...
1999 * lisp.h: ... to here, so that the inline functions mentioned
2000 above can use them.
2001
4a6bea26
PE
2002 * dired.c (directory_files_internal_unwind): Now static.
2003
f14b7e14
PE
2004 * fileio.c (file_name_as_directory, directory_file_name):
2005 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2006 Now static.
2893f146
PE
2007 (file_name_as_directory): Use const pointers when appropriate.
2008 (Fexpand_file_name): Likewise. In particular, newdir might
2009 point at constant storage, so make it a const pointer.
fd4ead52 2010 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2011 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2012 signedness issues.
f839df0c
PE
2013 (Fset_file_times, Finsert_file_contents, auto_save_error):
2014 Rename locals to avoid shadowing.
f14b7e14 2015
5716756e 2016 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2017 (Ftry_completion, Fall_completions): Rename or remove locals
2018 to avoid shadowing.
5716756e 2019
b4c3046a
PE
2020 * marker.c (bytepos_to_charpos): Remove; unused.
2021
b45db522
PE
2022 * lisp.h (verify_bytepos, count_markers): New decls,
2023 so that gcc does not warn that these functions aren't declared.
2024
85876d07
PE
2025 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2026 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2027 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2028 (copy_text): Remove unused local var.
85876d07 2029
03d78a21 2030 * filelock.c (within_one_second): Now static.
b3dd38ab 2031 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2032
5df8f01b
PE
2033 * buffer.c (fix_overlays_before): Mark locals as initialized.
2034 (fix_start_end_in_overlays): Likewise. This function should be
2035 simplified by using pointers-to-pointers, but that's a different
2036 matter.
b1d876f1 2037 (switch_to_buffer_1): Now static.
8f54f30a
PE
2038 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2039 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2040
a70072c9 2041 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2042 Fix pointer signedness issue.
edced198
PE
2043 (sys_subshell): Mark local as volatile if checking for lint,
2044 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2045 (MAXPATHLEN): Define only if needed.
a70072c9 2046
a0977c44
PE
2047 * process.c (serial_open, serial_configure): Move decls from here ...
2048 * systty.h: ... to here, so that they can be checked.
2049
a884fdcc
PE
2050 * fns.c (get_random, seed_random): Move extern decls from here ...
2051 * lisp.h: ... to here, so that they can be checked.
2052
604efe86 2053 * sysdep.c (reset_io): Now static.
b8950c94 2054 (wait_for_termination_signal): Remove; unused.
604efe86 2055
38fc62d9
PE
2056 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2057 (copy_keymap_item, append_key, push_text_char_description):
2058 Now static.
1004a21a 2059 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2060 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2061 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2062 (describe_map_tree):
2063 Rename locals to avoid shadowing.
38fc62d9 2064
2f2650da
PE
2065 * keyboard.c: Declare functions static if they are not used elsewhere.
2066 (echo_char, echo_dash, cmd_error, top_level_2):
2067 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2068 (read_char, kbd_buffer_get_event, make_lispy_position):
2069 (make_lispy_event, make_lispy_movement, apply_modifiers):
2070 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2071 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2072 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2073 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2074 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2075
a053e86c 2076 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2077 (mark_kboards): Move decl here ...
2078 * alloc.c (mark_kboards): ... from here.
a053e86c 2079
4752793e
PE
2080 * lisp.h (force_auto_save_soon): New decl.
2081
74f10ca7 2082 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2083 (DEFINE_DUMMY_FUNCTION): New macro.
2084 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2085 Use it.
c03cd23f
PE
2086 (main): Add casts to avoid warnings
2087 if GCC considers string literals to be constants.
74f10ca7 2088
022e70d4
PE
2089 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2090
59d6fe83
PE
2091 * dbusbind.c: Pointer signedness fixes.
2092 (xd_signature, xd_append_arg, xd_initialize):
2093 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2094 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2095 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2096 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2097
78320123
PE
2098 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2099 if GCC considers string literals to be constants.
49cebcca 2100 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2101
35ac2a97
SM
21022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2103
fb103ca9
SM
2104 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2105 (print_preprocess, print_object): New macro to fix last change.
2106
35ac2a97
SM
2107 * print.c (print_preprocess): Don't forget font objects.
2108
62973b41
JB
21092011-03-16 Juanma Barranquero <lekktu@gmail.com>
2110
2111 * emacs.c (USAGE3): Doc fixes.
2112
0e48bb22
AS
21132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2114
2115 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2116 structure.
2117
7684e57b
JB
21182011-03-14 Juanma Barranquero <lekktu@gmail.com>
2119
2120 * lisp.h (VWindow_system, Qfile_name_history):
2121 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2122 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2123 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2124
2125 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2126 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2127
2128 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2129 * w32console.c (detect_input_pending, read_input_pending)
2130 (encode_terminal_code):
2131 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2132 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2133 (w32_system_caret_y, Qfile_name_history):
2134 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2135 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2136 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2137 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2138 * w32proc.c (Qlocal, report_file_error):
2139 * w32term.c (Vwindow_system, updating_frame):
2140 * w32uniscribe.c (initialized, uniscribe_font_driver):
2141 Remove unneeded extern declarations.
2142
2aa46d6c
CY
21432011-03-14 Chong Yidong <cyd@stupidchicken.com>
2144
c96bbc66 2145 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2146
cffc6f3b
CY
21472011-03-13 Chong Yidong <cyd@stupidchicken.com>
2148
2149 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2150 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2151 These macros can no longer be used for assignment.
2152
44f230aa
SM
2153 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2154 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2155 (record_buffer_markers, fetch_buffer_markers): New functions for
2156 recording and fetching special buffer markers.
2157 (set_buffer_internal_1, set_buffer_temp): Use them.
2158
2159 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2160
2161 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2162
2163 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2164 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2165
2166 * xdisp.c (hscroll_window_tree):
2167 (reconsider_clip_changes): Use PT instead of BUF_PT.
2168
d251f04b
EZ
21692011-03-13 Eli Zaretskii <eliz@gnu.org>
2170
2171 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2172 $(EMACS_ROOT)/lib/intprops.h.
2173
f0c77cd1
PE
21742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2175
3eca4629
PE
2176 Fix more problems found by GCC 4.5.2's static checks.
2177
7c86ee98
PE
2178 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2179 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2180 (xg_free_frame_widgets): Make it clear that a local variable is
2181 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2182 (gdk_window_get_screen): Make it clear that this macro is needed
2183 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2184 (int_gtk_range_get_value): New function, which avoids a diagnostic
2185 from gcc -Wbad-function-cast.
2186 (xg_set_toolkit_scroll_bar_thumb): Use it.
2187 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2188 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2189 (get_utf8_string, xg_get_file_with_chooser):
2190 Rename locals to avoid shadowing.
2191 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2192
41729b81
PE
2193 * xgselect.c (xg_select): Remove unused var.
2194
f0c77cd1
PE
2195 * image.c (four_corners_best): Mark locals as initialized.
2196 (gif_load): Initialize transparent_p to zero (Bug#8238).
2197 Mark another local as initialized.
ec6cf4c6 2198 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2199
ce0ad53d 2200 * image.c (clear_image_cache): Now static.
d5d5a617 2201 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2202 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2203 (x_edge_detection): Remove unnecessary cast that
2204 gcc -Wbad-function-cast diagnoses.
2037898d 2205 (gif_load): Fix pointer signedness.
6ae141d6
PE
2206 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2207 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2208
33383987 22092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2210
d32df629
PE
2211 Improve quality of tests for time stamp overflow.
2212 For example, without this patch (encode-time 0 0 0 1 1
2213 1152921504606846976) returns the obviously-bogus value (-948597
2214 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2215 reports time overflow. See
2216 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2217 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2218 * editfns.c: Include limits.h and intprops.h.
2219 (TIME_T_MIN, TIME_T_MAX): New macros.
2220 (time_overflow): Move earlier, to before first use.
2221 (hi_time, lo_time): New functions, for an accurate test for
2222 out-of-range times.
2223 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2224 (Fget_internal_run_time): Don't assume time_t fits in int.
2225 (make_time): Use list2 instead of Fcons twice.
2226 (Fdecode_time): More accurate test for out-of-range times.
2227 (check_tm_member): New function.
2228 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2229 (lisp_time_argument): Don't rely on undefined left-shift and
2230 right-shift behavior when checking for time stamp overflow.
8be6f318 2231
fe31d94c
PE
2232 * editfns.c (time_overflow): New function, refactoring common code.
2233 (Fformat_time_string, Fdecode_time, Fencode_time):
2234 (Fcurrent_time_string): Use it.
2235
8be6f318
PE
2236 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2237 * dired.c (make_time): Move to ...
2238 * editfns.c (make_time): ... here.
2239 * systime.h: Note the move.
2240
09d9db2c 22412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2242
126bc0dc
YM
2243 * fringe.c (update_window_fringes): Remove unused variables.
2244
c47cbdfd
YM
2245 * unexmacosx.c (copy_data_segment): Also copy __got section.
2246 (Bug#8223)
2247
7ac80be9
EZ
22482011-03-12 Eli Zaretskii <eliz@gnu.org>
2249
c96bbc66 2250 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2251 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2252 Constify `char *' arguments and their references according to
2253 prototypes in tparam.h.
2254
ecb0f94d 2255 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2256
7ac80be9
EZ
2257 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2258 Adapt all references accordingly.
2259
2260 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2261
ef1fd07e
TT
22622011-03-11 Tom Tromey <tromey@redhat.com>
2263
2264 * buffer.c (syms_of_buffer): Remove obsolete comment.
2265
7ef4b50c
EZ
22662011-03-11 Eli Zaretskii <eliz@gnu.org>
2267
2268 * termhooks.h (encode_terminal_code): Declare prototype.
2269
2270 * msdos.c (encode_terminal_code): Don't declare prototype.
2271
2272 * term.c (encode_terminal_code): Now external again, used by
2273 w32console.c and msdos.c.
2274
44f230aa
SM
2275 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2276 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2277
4b1ec863 22782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2279
1714f52b 2280 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2281
4b1ec863
PE
2282 * fringe.c (update_window_fringes): Mark locals as initialized
2283 (Bug#8227).
2284 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2285
524c7aa6
PE
2286 * alloc.c (mark_fringe_data): Move decl from here ...
2287 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2288 to check its interface.
2289 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2290
a5c0af81 2291 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2292 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2293 (fontset_font): Mark local as initialized.
a9a06e0b 2294 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2295
b4716021
PE
2296 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2297
811e9bac 2298 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2299 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2300 (x_own_selection, Fx_disown_selection_internal): Rename locals
2301 to avoid shadowing.
2302 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2303
7e3ab302
PE
2304 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2305 so that the caller can use some name other than gcpro1.
2306 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2307 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2308 (Fx_backspace_delete_keys_p):
2309 Use them to avoid shadowing, and rename vars to avoid shadowing.
2310 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2311 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2312 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2313 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2314 Remove unused locals.
7e3ab302
PE
2315 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2316 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2317 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2318 macros.
f78faa98 2319
e2b13473
PE
2320 * xterm.h (x_mouse_leave): New decl.
2321
77f23912
PE
2322 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2323 Remove unused functions.
cdf4ba58
PE
2324 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2325 (x_calc_absolute_position): Now static.
7411c686 2326 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2327 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2328 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2329 unless they are used.
38d0b34a
PE
2330 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2331 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2332 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2333 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2334 (x_error_catcher, x_connection_closed, x_error_handler):
2335 (x_error_quitter, xembed_send_message, x_iconify_frame):
2336 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2337 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2338 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2339
44f230aa
SM
2340 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2341 Rename or move locals to avoid shadowing.
6b463e58 2342 (tty_defined_color, merge_face_heights): Now static.
5967d051 2343 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2344 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2345 does not deduce is never used uninitialized.
73719eba
PE
2346 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2347 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2348
426994c3 2349 * terminal.c (store_terminal_param): Now static.
5489860b 2350
032f1620 2351 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2352 (set_frame_menubar): Remove unused local.
d4323972 2353 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2354 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2355 since they might point to immutable storage.
281585b0
PE
2356 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2357 since it's unused otherwise.
032f1620 2358
367c19e5 2359 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2360 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2361 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2362 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2363 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2364 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2365 does not deduce are never used uninitialized.
70739cbe 2366
07b48fa9
PE
2367 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2368
8868a238 2369 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2370 * window.c (window_loop, size_window):
2371 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2372
7e5cf297 2373 * window.c (display_buffer): Now static.
d6550a9f
PE
2374 (size_window): Mark variables that gcc -Wuninitialized
2375 does not deduce are never used uninitialized.
a586633d
PE
2376 * window.h (check_all_windows): New decl, to forestall
2377 gcc -Wmissing-prototypes diagnostic.
5b555da1 2378 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2379
f6095868
PE
2380 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2381 shadowing.
2382 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2383 Include <limits.h>.
2384 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2385 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2386 (load_charset_map): Mark variables that gcc -Wuninitialized
2387 does not deduce are never used uninitialized.
53df7c11 2388 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2389
f38b440c
PE
2390 * coding.c (coding_set_source, coding_set_destination):
2391 Use "else { /* comment */ }" rather than "else /* comment */;"
2392 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2393 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2394 a block, when the outer 'i' will do.
2395 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2396 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2397 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2398 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2399 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2400 Rename locals to avoid shadowing.
2401 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2402 * coding.c (emacs_mule_char, encode_invocation_designation):
2403 Now static, since they're not used elsewhere.
413bb2db 2404 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2405 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2406 (decode_coding_emacs_mule): Mark variables that gcc
2407 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2408 (detect_coding_iso_2022): Initialize a local variable that might
2409 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2410 this initialization is needed. (Bug#8211)
5f58e762
PE
2411 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2412 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2413 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2414 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2415 Remove unused macros.
f38b440c 2416
232b38b9 2417 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2418 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2419 * character.c (string_count_byte8): Likewise.
232b38b9 2420
fb90da1b
PE
2421 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2422 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2423
fb93dbc2
PE
2424 * chartab.c (copy_sub_char_table): Now static, since it's not used
2425 elsewhere.
5c156ace
PE
2426 (sub_char_table_ref_and_range, char_table_ref_and_range):
2427 Rename locals to avoid shadowing.
bbcd0949 2428 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2429
7d3b3862 2430 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2431 (BIDI_BOB): Remove unused macro.
7d3b3862 2432
6be7d3da
PE
2433 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2434 deduce are never used uninitialized.
c2ed9c8b 2435 * term.c (encode_terminal_code): Likewise.
6be7d3da 2436
75f8807f 2437 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2438
50938595
PE
2439 * tparam.h: New file.
2440 * term.c, tparam.h: Include it.
2441 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2442 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2443 Move these decls to tparam.h, and make them agree with what
2444 is actually in tparam.c. The previous trick of using incompatible
2445 decls in different modules does not conform to the C standard.
2446 All callers of tparam changed to use tparam's actual API.
2447 * tparam.c (tparam1, tparam, tgoto):
2448 Use const pointers where appropriate.
2449
fbceeba2
PE
2450 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2451 * cm.h (struct cm): Likewise.
2452 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2453 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2454 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2455 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2456 (turn_on_face, init_tty): Likewise.
2457 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2458
7f3f1250
PE
2459 * term.c (term_mouse_position): Rename local to avoid shadowing.
2460
e6ca6543
PE
2461 * alloc.c (mark_ttys): Move decl from here ...
2462 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2463
c40f8d15
AS
24642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2465
2466 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2467
cfe0661d
JB
24682011-03-09 Juanma Barranquero <lekktu@gmail.com>
2469
2470 * search.c (compile_pattern_1): Remove argument regp, unused since
2471 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2472 (compile_pattern): Don't pass it.
2473
0afb4571
J
24742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2475
2476 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2477 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2478 for ! HAVE_GTK3.
2479 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2480
2481 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2482
2483 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2484 gdk_window_get_screen, gdk_window_get_geometry,
2485 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2486 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2487 (xg_get_pixbuf_from_pixmap): New function.
2488 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2489 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2490 Call xg_get_pixbuf_from_pixmap instead of
2491 gdk_pixbuf_get_from_drawable.
2492 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2493 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2494 (xg_check_special_colors): Use GtkStyleContext and its functions
2495 for HAVE_GTK3.
2496 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2497 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2498 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2499 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2500 Call gtk_widget_get_preferred_size.
0afb4571
J
2501 (xg_frame_resized): gdk_window_get_geometry only takes 5
2502 parameters.
44f230aa
SM
2503 (xg_win_to_widget, xg_event_is_for_menubar):
2504 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2505 (xg_set_widget_bg): New function.
2506 (delete_cb): New function.
2507 (xg_create_frame_widgets): connect delete-event to delete_cb.
2508 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2509 (xg_set_background_color): Call xg_set_widget_bg.
2510 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2511 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2512 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2513 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2514 if ! HAVE_GTK3.
2515 (update_frame_tool_bar): Call gtk_widget_hide.
2516 (xg_initialize): Use GDK_KEY_g.
2517
2518 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2519 if ! HAVE_GTK3
2520 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2521
2522 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2523 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2524 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2525
1c2cc4ef
JB
25262011-03-08 Juanma Barranquero <lekktu@gmail.com>
2527
2528 * w32xfns.c (select_palette): Check success of RealizePalette against
2529 GDI_ERROR, not zero.
2530
33383987 2531See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2532
2533;; Local Variables:
2534;; coding: utf-8
aac0c6e3
MR
2535;; End:
2536
33383987 2537 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2538
2539 This file is part of GNU Emacs.
2540
2541 GNU Emacs is free software: you can redistribute it and/or modify
2542 it under the terms of the GNU General Public License as published by
2543 the Free Software Foundation, either version 3 of the License, or
2544 (at your option) any later version.
2545
2546 GNU Emacs is distributed in the hope that it will be useful,
2547 but WITHOUT ANY WARRANTY; without even the implied warranty of
2548 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2549 GNU General Public License for more details.
2550
2551 You should have received a copy of the GNU General Public License
2552 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.