Use const for a string pointer.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c56e0fd5
DN
12011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2
3 * dispnew.c (add_window_display_history): Use const for the string
4 pointer. Remove declaration, not needed.
5
333d54da 62011-05-31 Paul Eggert <eggert@cs.ucla.edu>
55d4c1b2
PE
7
8 Use 'inline', not 'INLINE'.
333d54da 9 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10 * alloc.c, fontset.c (INLINE): Remove.
11 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
13 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14 * gmalloc.c (register_heapinfo): Use inline unconditionally.
15 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
16
738db178
DN
172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
18
19 Make it possible to run ./temacs.
20
21 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
22 syms_of_callproc does the same thing. Remove test for
23 "initialized", do it in the caller.
24 * emacs.c (main): Avoid calling set_initial_environment when dumping.
25
620c53a6
SM
262011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
27
28 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
29 (read_minibuf): Use get_minibuffer.
30 (syms_of_minibuf): Use DEFSYM.
31 (Qmetadata): New var.
32 * data.c (Qbuffer): Don't make it static.
33 (syms_of_data): Use DEFSYM.
34
e003a292
PE
352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
36
37 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
38 (CCL_CODE_MIN): New macro.
39
ed008a6d
PE
402011-05-30 Paul Eggert <eggert@cs.ucla.edu>
41
3687c2ef
PE
42 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
43
ed008a6d
PE
44 * eval.c (Qdebug): Now static.
45 * lisp.h (Qdebug): Remove decl. This reverts a part of the
46 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
47 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
48
d66c4c7c
CY
492011-05-29 Chong Yidong <cyd@stupidchicken.com>
50
51 * image.c: Various fixes to ImageMagick code comments.
52 (Fimagemagick_types): Doc fix.
53
5fbc2025
PE
542011-05-29 Paul Eggert <eggert@cs.ucla.edu>
55
0196f88a
PE
56 Minor fixes prompted by GCC 4.6.0 warnings.
57
58 * xselect.c (converted_selections, conversion_fail_tag): Now static.
59
5fbc2025
PE
60 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
61 (x_clipboard_manager_save_all): Move extern decl to ...
62 * xterm.h: ... here, so that it can be checked for consistency.
63
1dd3c2d9
CY
642011-05-29 Chong Yidong <cyd@stupidchicken.com>
65
66 * xselect.c (x_clipboard_manager_save_frame)
67 (x_clipboard_manager_save_all): New functions.
68 (Fx_clipboard_manager_save): Lisp function deleted.
69
70 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
71 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
72
73 * xterm.h: Update prototype.
74
5ba6571d
WX
752011-05-28 William Xu <william.xwl@gmail.com>
76
77 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
78 exiting (Bug#8239).
79
3eaff834
JM
802011-05-28 Jim Meyering <meyering@redhat.com>
81
e1900994 82 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
83 * fns.c (to_uchar): Define.
84 (crypto_hash_function): Use it to convert some newly-signed
85 variables to unsigned, to avoid sign-extension bugs. For example,
86 without this change, (md5 "truc") would evaluate to
87 45723a2aff78ff4fff7fff1114760e62 rather than the expected
88 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 89 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 90
0f6990a7
PE
912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
92
93 Integer overflow fixes.
c8a9ca5a 94
08686060
PE
95 * dbusbind.c: Serial number integer overflow fixes.
96 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
97 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
98 to hold a serial number that is too large for a fixnum.
99 (Fdbus_method_return_internal, Fdbus_method_error_internal):
100 Check for serial numbers out of range. Decode any serial number
59568bf0 101 that was so large that it became a float. (Bug#8722)
08686060 102
2d1fc3c7
PE
103 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
104 (Fdbus_call_method, Fdbus_call_method_asynchronously):
105 Use XFASTINT rather than XUINT when numbers are nonnegative.
106 (xd_append_arg, Fdbus_method_return_internal):
107 (Fdbus_method_error_internal): Likewise. Also, for unsigned
108 arguments, check that Lisp number is nonnegative, rather than
59568bf0 109 silently wrapping negative numbers around. (Bug#8722)
30217ff0 110 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 111 (Bug#8722)
2d1fc3c7 112
c8a9ca5a
PE
113 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
114
519e1d69
PE
115 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
116
30569699
PE
117 ccl: add integer overflow checks
118 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
119 (IN_INT_RANGE): New macros.
120 (ccl_driver): Use them to check for integer overflow when
121 decoding a CCL program. Many of the new checks are whether XINT (x)
122 fits in int; it doesn't always, on 64-bit hosts. The new version
123 doesn't catch all possible integer overflows, but it's an
847044ea 124 improvement. (Bug#8719)
30569699 125
c11285dc
PE
126 * alloc.c (make_event_array): Use XINT, not XUINT.
127 There's no need for unsigned here.
128
fdccd48e
PE
129 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
130 This follows up to the 2011-05-06 change that substituted uintptr_t
131 for EMACS_INT. This case wasn't caught back then.
132
37910ab2
PE
133 Rework Fformat to avoid integer overflow issues.
134 * editfns.c: Include <float.h> unconditionally, as it's everywhere
135 now (part of C89). Include <verify.h>.
136 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
137 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
138 (Fformat): Avoid the prepass trying to compute sizes; it was only
139 approximate and thus did not catch overflow reliably. Instead, walk
140 through the format just once, formatting and computing sizes as we go,
141 checking for integer overflow at every step, and allocating a larger
142 buffer as needed. Keep track separately whether the format is
143 multibyte. Keep only the most-recently calculated precision, rather
144 than them all. Record whether each argument has been converted to
145 string. Use EMACS_INT, not int, for byte and char and arg counts.
146 Support field widths and precisions larger than INT_MAX. Avoid
147 sprintf's undefined behavior with conversion specifications such as %#d
148 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
149 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
150 formatting out-of-range floating point numbers with int
151 formats. (Bug#8668)
152
2e6578fb
PE
153 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
154
0ae6bdee
PE
155 * data.c: Avoid integer truncation in expressions involving floats.
156 * data.c: Include <intprops.h>.
157 (arith_driver): When there's an integer overflow in an expression
158 involving floating point, convert the integers to floating point
159 so that the resulting value does not suffer from catastrophic
160 integer truncation. For example, on a 64-bit host (* 4
161 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
162 Do not rely on undefined behavior after integer overflow.
163
de883a70
PE
164 merge count_size_as_multibyte, parse_str_to_multibyte
165 * character.c, character.h (count_size_as_multibyte):
166 Renamed from parse_str_to_multibyte; all uses changed.
167 Check for integer overflow.
168 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
169 since it's now a duplicate of the other. This is more of
170 a character than a buffer op, so better that it's in character.c.
171 * fns.c, print.c: Adjust to above changes.
172
2ff916cb
PE
1732011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
174
175 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
176
f1b54466
PE
1772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
178
fb1ac845
PE
179 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
180 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
181 (x_clipboard_manager_save): Now static.
182 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
183
f1b54466
PE
184 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
185 (crypto_hash_function): Now static.
186 Fix pointer signedness problems. Avoid unnecessary initializations.
187
a9f737ee
CY
1882011-05-27 Chong Yidong <cyd@stupidchicken.com>
189
190 * termhooks.h (Vselection_alist): Make it terminal-local.
191
192 * terminal.c (create_terminal): Initialize it.
193
194 * xselect.c: Support for clipboard managers.
195 (Vselection_alist): Move to termhooks.h as terminal-local var.
196 (LOCAL_SELECTION): New macro.
197 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
198 (symbol_to_x_atom): Remove gratuitous arg.
199 (x_handle_selection_request, lisp_data_to_selection_data)
200 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
201 (x_own_selection, x_get_local_selection, x_convert_selection):
202 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
203 (some_frame_on_display): Delete unused function.
204 (Fx_own_selection_internal, Fx_get_selection_internal)
205 (Fx_disown_selection_internal, Fx_selection_owner_p)
206 (Fx_selection_exists_p): New optional frame arg.
207 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
208 (x_handle_selection_clear): Don't treat other terminals with the
209 same keyboard specially. Use the terminal-local Vselection_alist.
210 (x_clear_frame_selections): Use Frun_hook_with_args.
211
212 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
213
214 * xterm.h: Add support for those atoms.
215
e067f0c1
CY
2162011-05-26 Chong Yidong <cyd@stupidchicken.com>
217
218 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
219 (converted_selections, conversion_fail_tag): New global variables.
220 (x_selection_request_lisp_error): Free the above.
221 (x_get_local_selection): Remove unnecessary code.
222 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
223 of converted selections stored in converted_selections.
224 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
225 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
226 (x_convert_selection): New function.
227 (x_handle_selection_event): Simplify.
228 (x_get_foreign_selection): Don't ignore incoming requests while
229 waiting for an answer; this will fail when we implement
230 SAVE_TARGETS, and seems unnecessary anyway.
231 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
232 (Vx_sent_selection_functions): Doc fix.
233
0f4aebc0
LL
2342011-05-26 Leo Liu <sdl.web@gmail.com>
235
236 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
237
e61124cd
YM
2382011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
239
240 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
241
242 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
243 for fringe update if it has periodic bitmap.
244 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
245 and fringe_bitmap_periodic_p.
246
247 * fringe.c (get_fringe_bitmap_data): New function.
248 (draw_fringe_bitmap_1, update_window_fringes): Use it.
249 (update_window_fringes): Record periodicity of fringe bitmap in glyph
250 row. Mark glyph row for fringe update if periodicity changed.
251
252 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
253 for fringe update unless it has periodic bitmap.
254
f16d9837
KH
2552011-05-25 Kenichi Handa <handa@m17n.org>
256
257 * xdisp.c (get_next_display_element): Set correct it->face_id for
258 a static composition.
259
e1b90ef6
LL
2602011-05-24 Leo Liu <sdl.web@gmail.com>
261
262 * deps.mk (fns.o):
263 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
264
265 * fns.c (crypto_hash_function, Fsha1): New function.
266 (Fmd5): Use crypto_hash_function.
267 (syms_of_fns): Add Ssha1.
268
7400048f
PE
2692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
270
271 * gnutls.c: Remove unused macros.
272 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
273 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
274 Remove macros that are defined and never used.
275 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
276
abb71cf4
CY
2772011-05-22 Chong Yidong <cyd@stupidchicken.com>
278
279 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
280 (Fx_get_selection_internal): Minor cleanup.
281 (Fx_own_selection_internal): Rename arguments for consistency with
282 select.el.
283
6307db39
PE
2842011-05-22 Paul Eggert <eggert@cs.ucla.edu>
285
286 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
287
f3d4e0a4
CY
2882011-05-22 Chong Yidong <cyd@stupidchicken.com>
289
290 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
291
4d8ade89
YM
2922011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
293
294 * dispnew.c (scrolling_window): Don't exclude the case that the
295 last enabled row in the desired matrix touches the bottom boundary.
296
32078c8d
GM
2972011-05-21 Glenn Morris <rgm@gnu.org>
298
299 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
300 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
301 and add some more files.
32078c8d 302
7285dc67
EZ
3032011-05-20 Eli Zaretskii <eliz@gnu.org>
304
305 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
306 report_file_error introduced by the change from 2011-05-07.
307
89d1bd22
PE
3082011-05-20 Paul Eggert <eggert@cs.ucla.edu>
309
310 * systime.h (Time): Define only if emacs is defined.
311 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
312 where the include path doesn't have X11/X.h by default. See
313 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
314
e23640bb 3152011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
316
317 * composite.c (find_automatic_composition): Fix previous change.
318
b9704ad9
GM
3192011-05-20 Glenn Morris <rgm@gnu.org>
320
321 * lisp.mk: New file, split from Makefile.in.
322 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
323 (shortlisp): Remove.
324 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
325
4a720484
GM
3262011-05-19 Glenn Morris <rgm@gnu.org>
327
328 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
329 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
330 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
331 (lisp): Set the order to that of loadup.el.
332 (shortlisp): Make it a copy of $lisp.
333 (SOME_MACHINE_LISP): Remove.
334 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
335 Use just $shortlisp, not $SOME_MACHINE_LISP too.
336
a28d4396
KH
3372011-05-18 Kenichi Handa <handa@m17n.org>
338
339 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
340 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
341 (find_automatic_composition): Mostly rewrite for efficiency.
342
a2b1fa8e
JB
3432011-05-18 Juanma Barranquero <lekktu@gmail.com>
344
345 * makefile.w32-in: Update dependencies.
346
8e1f5610
CS
3472011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
348
349 * menu.c: Include limits.h (fixes the MS-Windows build broken by
350 revision 104625).
351
7025ee00 3522011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 353
cdfa6eab
PE
354 Fix some integer overflow issues, such as string length overflow.
355
06d6db33
PE
356 * insdel.c (count_size_as_multibyte): Check for string overflow.
357
2b4560a8
PE
358 * character.c (lisp_string_width): Check for string overflow.
359 Use EMACS_INT, not int, for string indexes and lengths; in
360 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
361 the resulting string length overflows an EMACS_INT; instead,
362 report a string overflow if no precision given. When checking for
363 precision exhaustion, use a check that cannot possibly have
364 integer overflow. (Bug#8675)
365 * character.h (lisp_string_width): Adjust to new signature.
366
cb93f9be
PE
367 * alloc.c (string_overflow): New function.
368 (Fmake_string): Use it. This doesn't change behavior, but saves
369 a few bytes and will simplify future changes.
370 * character.c (string_escape_byte8): Likewise.
371 * lisp.h (string_overflow): New decl.
372
1a1f3366
PE
373 Fixups, following up to the user-interface timestamp change.
374 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
375 for UI timestamps, instead of unsigned long.
9fbd6841
PE
376 * msdos.c (mouse_get_pos): Likewise.
377 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
378 * w32gui.h (Time): Define by including "systime.h" rather than by
379 declaring it ourselves. (Bug#8664)
380
d4e3e4d3
PE
381 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
382 * image.c (clear_image_cache): Likewise.
383
f6a24d19
PE
384 * term.c (term_mouse_position): Don't assume time_t wraparound.
385
08dc5ae6
PE
386 Be more systematic about user-interface timestamps.
387 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
388 and sometimes 'EMACS_UINT', to represent these timestamps.
389 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
390 This makes the code easier to follow, and makes it easier to catch
391 integer overflow bugs such as Bug#8664.
392 * frame.c (Fmouse_position, Fmouse_pixel_position):
393 Use Time, not unsigned long, for user-interface timestamps.
394 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
395 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
396 * keyboard.h (last_event_timestamp): Likewise.
397 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
398 * menu.h (xmenu_show): Likewise.
399 * term.c (term_mouse_position): Likewise.
400 * termhooks.h (struct input_event.timestamp): Likewise.
401 (struct terminal.mouse_position_hook): Likewise.
402 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
403 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
404 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
405 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
406 what it was before.
407 * menu.h, termhooks.h: Include "systime.h", for Time.
408
8e55734a
PE
409 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
410 Don't assume that the difference between two unsigned long values
411 can fit into an integer. At this point, we know button_down_time
412 <= event->timestamp, so the difference must be nonnegative, so
413 there's no need to cast the result if double-click-time is
414 nonnegative, as it should be; check that it's nonnegative, just in
415 case. This bug is triggered when events are more than 2**31 ms
86db42d2 416 apart (about 25 days). (Bug#8664)
8e55734a 417
841f1b75 418 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 419 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 420
3e26f69c
PE
421 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
422 that always fit in int. Use a sentinel instead of a counter, to
423 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
424 * frame.h (struct frame): Use int for menu_bar_items_used
425 instead of EMACS_INT, since it always fits in int.
3e26f69c 426
5cc152c0
PE
427 * menu.c (grow_menu_items): Check for int overflow.
428
d89eb65e
PE
429 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
430
5235bd3e
PE
431 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
432 Before, the code was not consistent. These values cannot exceed
433 2**31 - 1 so there's no need to make them unsigned.
434 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
435 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
436 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
437 as modifiers.
438 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
439
bc827e23
PE
440 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
441 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
442 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
443 presumably because the widths might not match.
444
78eb494e
PE
445 * window.c (size_window): Avoid needless test at loop start.
446
04f2d78b
CB
4472011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
448
449 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
450
d2fc7e3d 4512011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
452
453 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
454
d2fc7e3d 4552011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
456
457 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
458 `width' to `bar_area_x' and `bar_area_width', respectively.
459 (x_scroll_run): Take account of fringe background extension.
460
04f2d78b
CB
461 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
462 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
463 `bar_area_width', respectively.
464 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
465 background extension.
466
79b70037
GM
4672011-05-10 Jim Meyering <meyering@redhat.com>
468
469 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
470
2f142cc5
JB
4712011-05-10 Juanma Barranquero <lekktu@gmail.com>
472
473 * image.c (Finit_image_library): Return t for built-in image types,
474 like pbm and xbm. (Bug#8640)
475
57679c86
AS
4762011-05-09 Andreas Schwab <schwab@linux-m68k.org>
477
478 * w32menu.c (set_frame_menubar): Fix submenu allocation.
479
888c9e86
EZ
4802011-05-07 Eli Zaretskii <eliz@gnu.org>
481
b0512a1d
EZ
482 * w32console.c (Fset_screen_color): Doc fix.
483 (Fget_screen_color): New function.
484 (syms_of_ntterm): Defsubr it.
485
7285dc67
EZ
486 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
487 unlink the temporary file if Fcall_process didn't create it in the
488 first place.
489 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
490 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
491 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
492 cue to call_process_cleanup not to close that handle.
493
4d3fcc8e
BK
4942011-05-07 Ben Key <bkey76@gmail.com>
495
496 * makefile.w32-in: The bootstrap-temacs rule now makes use of
497 one of two shell specific rules, either bootstrap-temacs-CMD or
498 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
499 to the previous implementation of the bootstrap-temacs rule.
500 The bootstrap-temacs-CMD rule is similar to the previous
501 implementation of the bootstrap-temacs rule except that it
502 makes use of the ESC_CFLAGS variable instead of the CFLAGS
503 variable.
504
505 These changes, along with some changes to nt/configure.bat,
506 nt/gmake.defs, and nt/nmake.defs, are required to extend my
507 earlier fix to add support for --cflags and --ldflags options
508 that include quotes so that it works whether make uses cmd or
509 sh as the shell.
510
b4289b64
MA
5112011-05-06 Michael Albinus <michael.albinus@gmx.de>
512
513 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
514 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
515 is a constant.
516 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
517 a string. Handle both cases.
518 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
519 (Fdbus_register_method): Use Qinvalid_function.
520
af4c0e28
JB
5212011-05-06 Juanma Barranquero <lekktu@gmail.com>
522
523 * makefile.w32-in: Update dependencies.
524 (LISP_H): Add inttypes.h and stdin.h.
525 (PROCESS_H): Add unistd.h.
526
c51453d9
EZ
5272011-05-06 Eli Zaretskii <eliz@gnu.org>
528
529 * lread.c: Include limits.h (fixes the MS-Windows build broken by
530 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
531
8ff0ac3c 5322011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 533
4c4b566b
PE
534 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
535
aab2b9b5
PE
536 * term.c (vfatal): Remove stray call to va_end.
537 It's not needed and the C Standard doesn't allow it here anyway.
538
c378da0b
PE
539 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
540 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
541
288b08c7
PE
542 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
543 bytes.
544
e3601888
PE
545 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
546
db6c0e74
PE
547 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
548
dd5963ea
PE
549 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
550
88c9450f
PE
551 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
552
2f9442b8
PE
553 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
554
c032b5f8
PE
555 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
556 * charset.c (Fdefine_charset_internal): Don't initialize
557 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 558 32-bit int (Bug#8600).
a108c10b
PE
559
560 * lread.c (read_integer): Be more consistent with string-to-number.
561 Use string_to_number to do the actual conversion; this avoids
562 rounding errors and fixes some other screwups. Without this fix,
563 for example, #x1fffffffffffffff was misread as -2305843009213693952.
564 (digit_to_number): Move earlier, for benefit of read_integer.
565 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 566 not a digit in any supported base. (Bug#8602)
a108c10b 567
ad5f9eea
PE
568 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
569
aec1708a
PE
570 * dispnew.c (scrolling_window): Return 1 if we scrolled,
571 to match comment at start of function. This also removes a
572 GCC warning about overflow in a 32+64-bit port.
573
47be4ab5
PE
574 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
575
371cac43
PE
576 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
577 Reported by Stefan Monnier in
578 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
579 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
580 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 581
d01a7826
PE
582 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
583 (EMACS_UINTPTR): Likewise, with uintptr_t.
584
7fd47d5c
PE
585 * lisp.h: Prefer 64-bit EMACS_INT if available.
586 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
587 on 32-bit hosts that have 64-bit int, so that they can access
588 large files.
122b0c86
PE
589 However, temporarily disable this change unless the temporary
590 symbol WIDE_EMACS_INT is defined.
7fd47d5c 591
8727937b
PE
592 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
593
8ac068ac
PE
594 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
595 This removes an assumption that EMACS_INT and long are the same
596 width as pointers. The assumption is true for Emacs porting targets
597 now, but we want to make other targets possible.
598 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
599 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
600 In the rest of the code, change types of integers that hold casted
601 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
602 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
603 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
604 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
605 No need to cast type when ORing.
606 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
607 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
608 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
609 assume EMACS_INT is the same width as char *.
610 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
611 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
612 Remove no-longer-needed casts.
613 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
614 (xg_tool_bar_help_callback, xg_make_tool_item):
615 Use EMACS_INTPTR to hold an integer
616 that will be cast to void *; this can avoid a GCC warning
617 if EMACS_INT is not the same width as void *.
618 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
619 * xdisp.c (display_echo_area_1, resize_mini_window_1):
620 (current_message_1, set_message_1):
621 Use a local to convert to proper width without a cast.
622 * xmenu.c (dialog_selection_callback): Likewise.
623
ede49d71
PE
624 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
625 Also, don't assume VALBITS / RAND_BITS is less than 5,
626 and don't rely on undefined behavior when shifting a 1 left into
627 the sign bit.
628 * lisp.h (get_random): Change signature to match.
629
2f30ecd0
PE
630 * lread.c (hash_string): Use size_t, not int, for hash computation.
631 Normally we prefer signed values; but hashing is special, because
632 it's better to use unsigned division on hash table sizes so that
633 the remainder is nonnegative. Also, size_t is the natural width
634 for hashing into memory. The previous code used 'int', which doesn't
635 retain enough info to hash well into very large tables.
636 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
637
2a866e7b
PE
638 * dbusbind.c: Don't possibly lose pointer info when converting.
639 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
640 Use XPNTR rather than XHASH, so that the high-order bits of
641 the pointer aren't lost when converting through void *.
642
51639eac
PE
643 * eval.c (Fautoload): Don't double-shift a pointer.
644
92394119
PE
645 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
646
dbdb9a7c
JB
6472011-05-06 Juanma Barranquero <lekktu@gmail.com>
648
649 * gnutls.c (DEF_GNUTLS_FN):
650 * image.c (DEF_IMGLIB_FN): Make function pointers static.
651
db7a0b4f
AS
6522011-05-05 Andreas Schwab <schwab@linux-m68k.org>
653
654 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
655 marker. (Bug#8610)
656
f7ff1b0f 6572011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
658
659 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
660 New version that can reserve upto 2GB of heap space.
661
f7ff1b0f 6622011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
663
664 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
665
639c109b
TZ
6662011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
667
668 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
669 `gnutls_certificate_set_x509_key_file'.
670
d2127135
JB
6712011-05-05 Juanma Barranquero <lekktu@gmail.com>
672
673 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
674 Update dependencies.
675
e968f4f3
JB
6762011-05-04 Juanma Barranquero <lekktu@gmail.com>
677
678 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
679 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
680 Remove unused parameter `fildes'.
681 * process.c (read_process_output, send_process): Don't pass it.
682
84d358f0
JB
6832011-05-04 Juanma Barranquero <lekktu@gmail.com>
684
685 Fix previous change: the library cache is defined in w32.c.
686 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
687 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
688
0898ca10
JB
6892011-05-04 Juanma Barranquero <lekktu@gmail.com>
690
691 Implement dynamic loading of GnuTLS on Windows.
692
693 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
694 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
695 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
696 Declare.
697
698 * gnutls.c (Qgnutls_dll): Define.
699 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
700 (gnutls_*): Declare function pointers.
701 (init_gnutls_functions): New function to initialize function pointers.
702 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
703 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
704 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
705 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
706 (emacs_gnutls_write, emacs_gnutls_read)
707 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
708 (Fgnutls_available_p): New function.
709 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
710 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
711 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
712
713 * image.c: Include w32.h.
714 (Vimage_type_cache): Delete.
715 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
716 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
717 (w32_delayed_load): Move to w32.c.
718
719 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
720
721 * w32.c (QCloaded_from, Vlibrary_cache): Define.
722 (w32_delayed_load): Move from image.c. When loading a library, record
723 its filename in the :loaded-from property of the library id.
724 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
725 Initialize and staticpro them.
726 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
727
728 * process.c: Include lisp.h before w32.h, not after.
729 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
730 instead of gnutls_record_check_pending.
731
732 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
733
ff4de4aa
TZ
7342011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
735
736 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
737 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
738 as passed in.
739
abe95abb
JD
7402011-05-03 Jan Djärv <jan.h.d@swipnet.se>
741
742 * xterm.c (x_set_frame_alpha): Do not set property on anything
743 else than FRAME_X_OUTER_WINDOW (Bug#8608).
744
e16e55d4
JB
7452011-05-02 Juanma Barranquero <lekktu@gmail.com>
746
747 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
748
bafcf6a5
JB
7492011-05-02 Juanma Barranquero <lekktu@gmail.com>
750
751 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
752 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
753 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
754 (gnutls_global_initialized, Qgnutls_bootprop_priority)
755 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
756 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
757 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
758 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
759 (Qgnutls_bootprop_callbacks_verify): Make static.
760
e7a6747f
AS
7612011-05-01 Andreas Schwab <schwab@linux-m68k.org>
762
19ed11ba
AS
763 * callproc.c: Indentation fixup.
764
e7a6747f 765 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
766 (wait_for_termination, interruptible_wait_for_termination):
767 Move after wait_for_termination_1.
e7a6747f 768
1ef14cb4
LMI
7692011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
770
771 * sysdep.c (interruptible_wait_for_termination): New function
772 which is like wait_for_termination, but allows keyboard
773 interruptions.
774
775 * callproc.c (Fcall_process): Add (:file "file") as an option for
776 the STDOUT buffer.
777 (Fcall_process_region): Ditto.
778
330d880c
EZ
7792011-04-30 Eli Zaretskii <eliz@gnu.org>
780
8db90b73
EZ
781 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
782 rather than `XVECTOR (FOO)->size'.
783
330d880c
EZ
784 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
785 inttypes.h, as a gnulib replacement is used if it not available in
786 system headers.
787
15cbd324
EZ
7882011-04-21 Eli Zaretskii <eliz@gnu.org>
789
790 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
791 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
792 of MOST_POSITIVE_FIXNUM. (Bug#8528)
793
794 * coding.c (coding_alloc_by_realloc): Error out if destination
795 will grow beyond MOST_POSITIVE_FIXNUM.
796 (decode_coding_emacs_mule): Abort if there isn't enough place in
797 charbuf for the composition carryover bytes. Reserve an extra
798 space for up to 2 characters produced in a loop.
799 (decode_coding_iso_2022): Abort if there isn't enough place in
800 charbuf for the composition carryover bytes.
801
8022011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 803
ae940cca
EZ
804 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
805 aborting when %lld or %lll format is passed.
806 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
807 %llo or %llx format is passed. (Bug#8545)
808
03ab8921
EZ
809 * window.c (window_scroll_line_based): Use a marker instead of
810 simple variables to record original value of point. (Bug#7952)
811
afda1437
EZ
812 * doprnt.c (doprnt): Fix the case where a multibyte sequence
813 produced by %s or %c overflows available buffer space. (Bug#8545)
814
f76dee0c
PE
8152011-04-28 Paul Eggert <eggert@cs.ucla.edu>
816
817 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 818 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 819
fdc5744d
JB
8202011-04-28 Juanma Barranquero <lekktu@gmail.com>
821
822 * w32.c (init_environment): Warn about defaulting HOME to C:\.
823
638f053a
JB
8242011-04-28 Juanma Barranquero <lekktu@gmail.com>
825
826 * keyboard.c (Qdelayed_warnings_hook): Define.
827 (command_loop_1): Run `delayed-warnings-hook'
828 if Vdelayed_warnings_list is non-nil.
829 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
830 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
831
d178f871
EZ
8322011-04-28 Eli Zaretskii <eliz@gnu.org>
833
834 * doprnt.c (doprnt): Don't return value smaller than the buffer
835 size if the message was truncated. (Bug#8545).
836
b124fd93
JB
8372011-04-28 Juanma Barranquero <lekktu@gmail.com>
838
839 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
840 (Fx_window_property): #if-0 the whole functions, not just the bodies.
841
e810457d
PE
8422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
843
844 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
845
ea51cceb
JB
8462011-04-27 Juanma Barranquero <lekktu@gmail.com>
847
848 * makefile.w32-in: Update dependencies.
849
94dcfacf
EZ
8502011-04-27 Eli Zaretskii <eliz@gnu.org>
851
852 Improve `doprnt' and its usage. (Bug#8545)
853 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
854 `format_end'. Remove support for %l as a conversion specifier.
855 Don't use xrealloc. Improve diagnostics when the %l size modifier
856 is used. Update the commentary.
857
858 * eval.c (verror): Simplify calculation of size_t.
859
860 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
861 messages.
862
f61f41d7
PE
8632011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
864
865 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
866 change.
867
96fb4434
PE
8682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
869
870 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
871 This makes this file independent of the recent pseudovector change.
872
671875da 8732011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 874
69e9b5a3
PE
875 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
876
b5f869a7 877 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 878 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 879 Remove unused local.
c8926152 880 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 881
841a1577 882 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
883 GCC 4.6.0 optimizes based on type-based alias analysis.
884 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
885 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
886 != &v->size, and therefore "v->size = 1; b->size = 2; return
887 v->size;" must therefore return 1. This assumption is incorrect
888 for Emacs, since it type-puns struct Lisp_Vector * with many other
889 types. To fix this problem, this patch adds a new type struct
f904488f 890 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
891 and pseudovectors, and helps optimizing compilers not get fooled
892 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
893 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
894 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
895 the size member.
eab3844f
PE
896 (XSETPVECTYPE): Rewrite in terms of new macro.
897 (XSETPVECTYPESIZE): New macro, specifying both type and size.
898 This is a bit clearer, and further avoids the possibility of
899 undesirable aliasing.
900 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 901 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
902 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
903 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
904 (ASIZE): Now uses header.size rather than size.
905 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
906 to avoid the hassle of writing XVECTOR (foo)->header.size.
907 (struct vectorlike_header): New type.
eab3844f
PE
908 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
909 object, to help avoid aliasing.
910 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
911 (SUBRP): Likewise, since Lisp_Subr is a special case.
912 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
913 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
914 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 915 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
916 changed to be "header.size" and "header.next".
917 * buffer.h (struct buffer): Likewise.
918 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
919 * frame.h (struct frame): Likewise.
920 * process.h (struct Lisp_Process): Likewise.
921 * termhooks.h (struct terminal): Likewise.
922 * window.c (struct save_window_data, struct saved_window): Likewise.
923 * window.h (struct window): Likewise.
924 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
925 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
926 * buffer.c (init_buffer_once): Likewise.
927 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
928 special case.
929 * process.c (Fformat_network_address): Use local var for size,
930 for brevity.
931
0df1eac5
PE
932 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
933
847ab9d1 934 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
935 * data.c (atof): Remove decl; no longer used or needed.
936 (digit_to_number): Move to lread.c.
937 (Fstring_to_number): Use new string_to_number function, to be
938 consistent with how the Lisp reader treats infinities and NaNs.
939 Do not assume that floating-point numbers represent EMACS_INT
940 without losing information; this is not true on most 64-bit hosts.
941 Avoid double-rounding errors, by insisting on integers when
942 parsing non-base-10 numbers, as the documentation specifies.
943 * lisp.h (string_to_number): New decl, replacing ...
944 (isfloat_string): Remove.
bc0a5c13 945 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 946 (read1): Do not accept +. and -. as integers; this
452f4150
PE
947 appears to have been a coding error. Similarly, do not accept
948 strings like +-1e0 as floating point numbers. Do not report
949 overflow for integer overflows unless the base is not 10 which
950 means we have no simple and reliable way to continue.
951 Break out the floating-point parsing into a new
952 function string_to_number, so that Fstring_to_number parses
953 floating point numbers consistently with the Lisp reader.
04f2d78b 954 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
955 (E_CHAR, EXP_INT): Remove, replacing with ...
956 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
957 (string_to_number): New function, replacing isfloat_string.
958 This function checks for valid syntax and produces the resulting
959 Lisp float number too. Rework it so that string-to-number
bc0a5c13 960 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
961 so that overflow for non-base-10 numbers is reported only when
962 there's no portable and simple way to convert to floating point.
452f4150 963
67769ffc
PE
964 * textprop.c (set_text_properties_1): Rewrite for clarity,
965 and to avoid GCC warning about integer overflow.
966
c20db43f
PE
967 * intervals.h (struct interval): Use EMACS_INT for members
968 where EMACS_UINT might cause problems. See
969 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
970 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
971 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
972 All uses changed.
37aa2f85
PE
973 (offset_intervals): Tell GCC not to worry about length overflow
974 when negating a negative length.
c20db43f 975
2538aa2f
PE
976 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
977 (overrun_check_free): Likewise.
978
f2d3008d
PE
979 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
980 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
981 word size.
982
ec8df744
PE
983 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
984 (gnutls_make_error): Rename local to avoid shadowing.
985 (gnutls_emacs_global_deinit): ifdef out; not used.
986 (Fgnutls_boot): Use const for pointer to readonly storage.
987 Comment out unused local. Fix pointer signedness problems.
988
640ee02d
PE
989 * lread.c (openp): Don't stuff size_t into an 'int'.
990 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
991 about possible signed overflow.
992
6048fb2a
PE
993 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
994 (GDK_KEY_g): Don't define if already defined.
995 (xg_prepare_tooltip): Avoid pointer signedness problem.
996 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
997
fa3c87e1
PE
998 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
999 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1000
2172544b
PE
1001 * xfns.c (Fx_window_property): Simplify a bit,
1002 to make a bit faster and to avoid GCC 4.6.0 warning.
1003 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1004
9b821a21
PE
1005 * fns.c (internal_equal): Don't assume size_t fits in int.
1006
3c616cfa
PE
1007 * alloc.c (compact_small_strings): Tighten assertion a little.
1008
c2982e87
PE
1009 Replace pEd with more-general pI, and fix some printf arg casts.
1010 * lisp.h (pI): New macro, generalizing old pEd macro to other
1011 conversion specifiers. For example, use "...%"pI"d..." rather
1012 than "...%"pEd"...".
1013 (pEd): Remove. All uses replaced with similar uses of pI.
1014 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1015 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1016 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1017 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1018 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1019 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1020 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1021 64-bit hosts.
1022 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1023 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1024 * print.c (safe_debug_print, print_object): Likewise.
1025 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1026 to int.
6f04d126
PE
1027 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1028 avoiding the 0 flag, which is not portable.
c2982e87
PE
1029 * process.c (Fmake_network_process): Use pI to avoid cast.
1030 * region-cache.c (pp_cache): Likewise.
1031 * xdisp.c (decode_mode_spec): Likewise.
1032 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1033 behavior on 64-bit hosts with printf arg.
6f04d126 1034 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1035 (x_stop_queuing_selection_requests): Likewise.
1036 (x_get_window_property): Don't truncate byte count to an 'int'
1037 when tracing.
0b432f21 1038
5e073ec7
PE
1039 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1040 here, since it parses constructs like leading '-' and spaces,
1041 which are not wanted; and it overflows with large numbers.
1042 Instead, simply match F[0-9]+, which is what is wanted anyway.
1043
36372bf9
PE
1044 * alloc.c: Remove unportable assumptions about struct layout.
1045 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1046 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1047 (allocate_vectorlike, make_pure_vector): Use the new macros,
1048 plus offsetof, to remove unportable assumptions about struct layout.
1049 These assumptions hold on all porting targets that I know of, but
1050 they are not guaranteed, they're easy to remove, and removing them
1051 makes further changes easier.
1052
0b432f21
PE
1053 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1054 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1055 (string_overrun_cookie): Now const. Use initializers that
1056 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1057 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1058 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1059 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1060 multiple of sizeof (EMACS_INT); it need not be, if
1061 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1062 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1063
895009e1
JB
10642011-04-26 Juanma Barranquero <lekktu@gmail.com>
1065
1066 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1067
6a7a1b0b
TZ
10682011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1069
1070 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1071 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1072 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1073
841a1577 10742011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1075
1076 * lisp.h (Qdebug): List symbol.
895009e1 1077 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1078 * keyboard.c (debug-on-event): New variable.
1079 (handle_user_signal): Break into debugger when debug-on-event
1080 matches the current signal symbol.
1081
f2d3ba6f
DN
10822011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1083
1084 * alloc.c (check_sblock, check_string_bytes)
1085 (check_string_free_list): Convert to standard C.
1086
42ce4c63
TZ
10872011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1088
1089 * w32.c (emacs_gnutls_push): Fix typo.
1090
825cd63c
EZ
10912011-04-25 Eli Zaretskii <eliz@gnu.org>
1092
fb11d64d
EZ
1093 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1094 "cast to pointer from integer of different size".
1095
825cd63c
EZ
1096 Improve doprnt and its use in verror. (Bug#8545)
1097 * doprnt.c (doprnt): Document the set of format control sequences
1098 supported by the function. Use SAFE_ALLOCA instead of always
1099 using `alloca'.
1100
1101 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1102 is one byte too soon. Don't use xrealloc; instead xfree and
1103 xmalloc anew.
1104
e061a11b
TZ
11052011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1106
1107 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1108 callbacks stage.
1109
1110 * gnutls.c: Renamed global_initialized to
1111 gnutls_global_initialized. Added internals for the
1112 :verify-hostname-error, :verify-error, and :verify-flags
1113 parameters of `gnutls-boot' and documented those parameters in the
1114 docstring. Start callback support.
1115 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1116 unless a fatal error occured. Call gnutls_alert_send_appropriate
1117 on error. Return error code.
1118 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1119 (emacs_gnutls_read): Likewise.
1120 (Fgnutls_boot): Return handshake error code.
1121 (emacs_gnutls_handle_error): New function.
1122 (wsaerror_to_errno): Likewise.
1123
1124 * w32.h (emacs_gnutls_pull): Add prototype.
1125 (emacs_gnutls_push): Likewise.
1126
1127 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1128 (emacs_gnutls_push): Likewise.
1129
11302011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1131
1132 * process.c (wait_reading_process_output): Check if GnuTLS
1133 buffered some data internally if no FDs are set for TLS
1134 connections.
1135
1136 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1137 (LIBS): Link to USER_LIBS.
1138 ($(BLD)/gnutls.$(0)): New target.
1139
fa6996bc
EZ
11402011-04-24 Eli Zaretskii <eliz@gnu.org>
1141
eb35682e
EZ
1142 * xdisp.c (handle_single_display_spec): Rename the
1143 display_replaced_before_p argument into display_replaced_p, to
1144 make it consistent with the commentary. Fix typos in the
1145 commentary.
1146
e2ad650c
EZ
1147 * textprop.c (syms_of_textprop): Remove dead code.
1148 (copy_text_properties): Delete obsolete commentary about an
1149 interface that was deleted long ago. Fix typos in the description
1150 of arguments.
1151
1b2de274
EZ
1152 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1153 to changes in oldXMenu/XMenu.h from 2011-04-16.
1154 <menu_help_message, prev_menu_help_message>: Constify.
1155 (IT_menu_make_room): menu->help_text is now `const char **';
1156 adjust.
1157
1158 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1159 to changes in oldXMenu/XMenu.h from 2011-04-16.
1160 (struct XMenu): Declare `help_text' `const char **'.
1161
1162 * xfaces.c <Qunspecified>: Make extern again.
1163
1164 * syntax.c: Include sys/types.h before including regex.h, as
1165 required by Posix.
1166
762b15be
EZ
1167 * doc.c (get_doc_string): Improve the format passed to `error'.
1168
1169 * doprnt.c (doprnt): Improve commentary.
1170
1171 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1172
1173 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1174 them with etags.
1175
f1052e5d
EZ
1176 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1177 changes in globals.h immediately force recompilation.
762b15be
EZ
1178 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1179 $(CURDIR)/s/ms-w32.h.
1180 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1181
fa6996bc
EZ
1182 * character.c (Fchar_direction): Function deleted.
1183 (syms_of_character): Don't defsubr it.
1184 <char-direction-table>: Deleted.
1185
e6c3da20
EZ
11862011-04-23 Eli Zaretskii <eliz@gnu.org>
1187
1188 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1189 * doprnt.c: Include limits.h.
1190 (SIZE_MAX): New macro.
04f2d78b
CB
1191 (doprnt): Return a size_t value. 2nd arg is now size_t.
1192 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1193 Improve overflow protection. Support `l' modifier for integer
1194 conversions. Support %l conversion. Don't assume an EMACS_INT
1195 argument for integer conversions and for %c.
1196
1197 * lisp.h (doprnt): Restore prototype.
1198
1199 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1200 $(SRC)/character.h.
1201
1202 * Makefile.in (base_obj): Add back doprnt.o.
1203
1204 * deps.mk (doprnt.o): Add back prerequisites.
1205 (callint.o): Depend on character.h.
1206
1207 * eval.c (internal_lisp_condition_case): Include the handler
1208 representation in the error message.
1209 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1210 when breaking from the loop.
1211
1212 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1213
1214 * callint.c (Fcall_interactively): When displaying error message
1215 about invalid control letter, pass the character's codepoint, not
1216 a pointer to its multibyte form. Improve display of the character
1217 in octal and display also its hex code.
1218
1219 * character.c (char_string): Use %x to display the (unsigned)
1220 codepoint of an invalid character, to avoid displaying a bogus
1221 negative value.
1222
1223 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1224 `error', not SYMBOL_NAME itself.
1225
1226 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1227 character arguments to `error'.
1228
1229 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1230 to `error' in error message about FINAL_CHAR argument. Make sure
1231 FINAL_CHAR is a character, and use %c when it is passed as
1232 argument to `error'.
1233
4ffd0d6b 12342011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1235
1236 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1237
1238 * w32.c: Include <time.h>.
1239 (sys_localtime): New function.
1240
4ffd0d6b 12412011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1242
1243 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1244
4ffd0d6b 1245 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1246
4ffd0d6b 12472011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1248
4ffd0d6b
GM
1249 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1250 zombies (Bug#8467).
aac0c6e3 1251
04c56954
EZ
12522011-04-19 Eli Zaretskii <eliz@gnu.org>
1253
1254 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1255 gl_state.e_property when gl_state.object is Qt.
1256
1257 * insdel.c (make_gap_larger): Remove limitation of buffer size
1258 to <= INT_MAX.
1259
16a43933
CY
12602011-04-18 Chong Yidong <cyd@stupidchicken.com>
1261
1262 * xdisp.c (lookup_glyphless_char_display)
1263 (produce_glyphless_glyph): Handle cons cell entry in
1264 glyphless-char-display.
1265 (Vglyphless_char_display): Document it.
1266
1267 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1268 glyphless-char-display.
1269
4581706e
CY
12702011-04-17 Chong Yidong <cyd@stupidchicken.com>
1271
1272 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1273
1274 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1275
1276 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1277 definition for no-X builds.
1278
4887c6e2 12792011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1280
fd35b6f9
PE
1281 Static checks with GCC 4.6.0 and non-default toolkits.
1282
5c1ccb01
PE
1283 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1284
006c5daa
PE
1285 * process.c (keyboard_bit_set): Define only if SIGIO.
1286 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1287 (send_process): Repair possible setjmp clobbering.
1288
efc736d3
PE
1289 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1290
4e2fe2e6
PE
1291 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1292
f97334a2
PE
1293 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1294
4e75f29d
PE
1295 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1296 Define only if needed.
1297
90efadd1
PE
1298 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1299 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1300 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1301
3c647824
PE
1302 * dispextern.h (struct redisplay_interface): Rename param
1303 to avoid shadowing.
e264f262 1304 * termhooks.h (struct terminal): Likewise.
761383f4 1305 * xterm.c (xembed_send_message): Likewise.
3c647824 1306
b58c5c4a
PE
1307 * insdel.c (make_gap_smaller): Define only if
1308 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1309
cad59032
PE
1310 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1311 it.
1312
c339dc2e
PE
1313 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1314 so that we aren't warned about unused symbols.
1315
91a3e27b
PE
1316 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1317
399c71d3 1318 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1319
8ffc96f5
PE
1320 * xfns.c (x_real_positions): Mark locals as initialized.
1321
eef9bc79
PE
1322 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1323
098db9dd
PE
1324 * xterm.c: Fix problems found by static analysis with other toolkits.
1325 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1326 (x_dispatch_event): Declare static if USE_GTK, and
1327 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1328 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1329 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1330 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1331 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1332
eb18f6cc
PE
1333 * xmenu.c (menu_help_callback): Pointer type fixes.
1334 Use const pointers when pointing at readonly data. Avoid pointer
1335 signedness clashes.
1336 (FALSE): Remove unused macro.
1337 (update_frame_menubar): Remove unused decl.
1338
1fe72bf8
PE
1339 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1340
60d9e1db
PE
1341 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1342 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1343 (single_menu_item): Rename local to avoid shadowing.
1344
39261c26
PE
1345 * keyboard.c (make_lispy_event): Remove unused local var.
1346
018c5e19
PE
1347 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1348 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1349
63d2b86e
PE
1350 * bitmaps: Change bitmaps from unsigned char back to the X11
1351 compatible char. Avoid the old compiler warnings about
1352 out-of-range initializers by using, for example, '\xab' rather
1353 than 0xab.
1354
aefd87e1
PE
1355 * xgselect.c (xgselect_initialize): Check vs interface
1356 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1357
bf501fb9
PE
1358 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1359
e9829fdf
PE
1360 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1361 to read-only memory.
1362
1086c095
PE
1363 * fns.c (vector): Remove; this old hack is no longer needed.
1364
2baccd04 1365 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1366 Remove unused var.
dde42981 1367 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1368
72391843 1369 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1370
436c16df 1371 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1372 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1373 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1374
92bb796d 1375 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1376 (x_term_init): Remove local to avoid shadowing.
92bb796d 1377
764430a3 1378 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1379
1380 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1381 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1382
d1dfb56c
EZ
13832011-04-16 Eli Zaretskii <eliz@gnu.org>
1384
c4354cb4
EZ
1385 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1386
d1dfb56c
EZ
1387 Fix regex.c, syntax.c and friends for buffers > 2GB.
1388 * syntax.h (struct gl_state_s): Declare character position members
1389 EMACS_INT.
1390
1391 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1392
04f2d78b
CB
1393 * textprop.c (verify_interval_modification, interval_of):
1394 Declare arguments EMACS_INT.
d1dfb56c
EZ
1395
1396 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1397 EMACS_INT.
1398
1399 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1400
1401 * indent.c (Fvertical_motion): Local variable it_start is now
1402 EMACS_INT.
1403
1404 * regex.c (re_match, re_match_2, re_match_2_internal)
1405 (bcmp_translate, regcomp, regexec, print_double_string)
1406 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1407 (re_compile_pattern, re_exec): Declare arguments and local
1408 variables `size_t' and `ssize_t' and return values `regoff_t', as
1409 appropriate.
1410 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1411 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1412 <compile_stack_type>: `size' and `avail' are now `size_t'.
1413
1414 * regex.h <regoff_t>: Use ssize_t, not int.
1415 (re_search, re_search_2, re_match, re_match_2): Arguments that
1416 specify buffer/string position and length are now ssize_t and
1417 size_t. Return type is regoff_t.
1418
613052cd
BK
14192011-04-16 Ben Key <bkey76@gmail.com>
1420
1421 * nsfont.m: Fixed bugs in ns_get_family and
1422 ns_descriptor_to_entity that were caused by using free to
1423 deallocate memory blocks that were allocated by xmalloc (via
1424 xstrdup). This caused Emacs to crash when compiled with
1425 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1426 --enable-checking=xmallocoverrun). xfree is now used to
1427 deallocate these memory blocks.
1428
4170f62f 14292011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1430
71b41406
PE
1431 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1432
9587a89d
PE
1433 emacs_write: Accept and return EMACS_INT for sizes.
1434 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1435 et seq.
1436 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1437 Accept and return EMACS_INT.
1438 (emacs_gnutls_write): Return the number of bytes written on
1439 partial writes.
1440 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1441 (emacs_read, emacs_write): Remove check for negative size, as the
1442 Emacs source code has been audited now.
9587a89d
PE
1443 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1444 (emacs_read, emacs_write): Use it.
273a5f82
PE
1445 * process.c (send_process): Adjust to the new signatures of
1446 emacs_write and emacs_gnutls_write. Do not attempt to store
1447 a byte offset into an 'int'; it might overflow.
9587a89d 1448 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1449
3e047f51
PE
1450 * sound.c: Don't assume sizes fit in 'int'.
1451 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1452 Return EMACS_INT, not int.
3e047f51 1453 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1454 Accept EMACS_INT, not int.
1455 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1456 record read return values.
1457
cc39a9db
BK
14582011-04-15 Ben Key <bkey76@gmail.com>
1459
c9d0ec6d
JB
1460 * keyboard.c (Qundefined): Don't declare static since it is used
1461 in nsfns.m.
1462 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1463 static since they are used in nsfont.m.
cc39a9db 1464
6c60eb9f
SM
14652011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1466
1467 * process.c (Qprocessp): Don't declare static.
1468 * lisp.h (Qprocessp): Declare again.
1469
7990b61a
JB
14702011-04-15 Juanma Barranquero <lekktu@gmail.com>
1471
1472 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1473
5d4cb038
PE
14742011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1475
8bd7b830 1476 Improve C-level modularity by making more things 'static'.
cd64ea1d 1477
e3b27b31
PE
1478 Don't publish debugger-only interfaces to other modules.
1479 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1480 (verify_bytepos, count_markers): Move decls to the only modules
1481 that need them.
1482 * region-cache.h (pp_cache): Likewise.
1483 * window.h (check_all_windows): Likewise.
1484 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1485
5d4cb038
PE
1486 * sysdep.c (croak): Now static, if
1487 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1488 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1489
1490 * alloc.c (refill_memory_reserve): Now static if
1491 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1492 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1493
e87b6180
PE
1494 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1495 Define only if USE_LUCID.
1496
ac64929e
PE
1497 * xrdb.c (x_customization_string, x_rm_string): Now static.
1498
6f37259d
PE
1499 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1500 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1501
1683e3ab
PE
1502 * xdisp.c (draw_row_with_mouse_face): Now static.
1503 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1504
de9c2632
PE
1505 * window.h (check_all_windows): Mark externally visible.
1506
2b96acb7
PE
1507 * window.c (window_deletion_count): Now static.
1508
1509 * undo.c: Make symbols static if they're not exported.
1510 (last_undo_buffer, last_boundary_position, pending_boundary):
1511 Now static.
1512
50436f33
PE
1513 * textprop.c (interval_insert_behind_hooks): Now static.
1514 (interval_insert_in_front_hooks): Likewise.
1515
64520e5c
PE
1516 * term.c: Make symbols static if they're not exported.
1517 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1518 (max_frame_lines, tty_set_terminal_modes):
1519 (tty_reset_terminal_modes, tty_turn_off_highlight):
1520 (get_tty_terminal): Now static.
1521 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1522 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1523 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1524 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1525 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1526
1fa53021
PE
1527 * sysdep.c: Make symbols static if they're not exported.
1528 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1529 Now static.
1530 (sigprocmask_set, full_mask): Remove; unused.
1531 (wait_debugging): Mark as visible.
1532 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1533 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1534
d4b43b22
PE
1535 * syntax.c (syntax_temp): Define only if !__GNUC__.
1536
b7c513d0
PE
1537 * sound.c (current_sound_device, current_sound): Now static.
1538
989b29ad
PE
1539 * search.c (searchbufs, searchbuf_head): Now static.
1540
13a55a78
PE
1541 * scroll.c (scroll_cost): Remove; unused.
1542 * dispextern.h (scroll_cost): Remove decl.
1543
de68a1fc
PE
1544 * region-cache.h (pp_cache): Mark as externally visible.
1545
40ccffa6
PE
1546 * process.c: Make symbols static if they're not exported.
1547 (process_tick, update_tick, create_process, chan_process):
1548 (Vprocess_alist, proc_buffered_char, datagram_access):
1549 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1550 (deactivate_process): Mark defn as static, as well as decl.
1551 * lisp.h (create_process): Remove decl.
1552 * process.h (chan_process, Vprocess_alist): Remove decls.
1553
ad64fc97
PE
1554 * print.c: Make symbols static if they're not exported.
1555 (print_depth, new_backquote_output, being_printed, print_buffer):
1556 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1557 (print_interval, print_number_index, initial_stderr_stream):
1558 Now static.
1559 * lisp.h (Fprinc): Remove decl.
1560 (debug_output_compilation_hack): Mark as externally visible.
1561
adddb265
PE
1562 * sysdep.c (croak): Move decl from here to syssignal.h.
1563 * syssignal.h (croak): Put it here, so the API can be checked when
1564 'croak' is called from dissociate_if_controlling_tty.
1565
1717ede2
PE
1566 * minibuf.c: Make symbols static if they're not exported.
1567 (minibuf_save_list, choose_minibuf_frame): Now static.
1568 * lisp.h (choose_minibuf_frame): Remove decl.
1569
fa5fb2bc
PE
1570 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1571
1e3890d1
PE
1572 * lread.c: Make symbols static if they're not exported.
1573 (read_objects, initial_obarray, oblookup_last_bucket_number):
1574 Now static.
1575 (make_symbol): Remove; unused.
1576 * lisp.h (initial_obarray, make_symbol): Remove decls.
1577
8a1414fa
PE
1578 * keyboard.c: Make symbols static if they're not exported.
1579 (single_kboard, recent_keys_index, total_keys, recent_keys):
1580 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1581 (this_single_command_key_start, echoing, last_auto_save):
1582 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1583 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1584 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1585 (Vlispy_mouse_stem, double_click_count):
1586 Now static.
1587 (force_auto_save_soon): Define only if SIGDANGER.
1588 (ignore_mouse_drag_p): Now static if
1589 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1590 (print_help): Remove; unused.
1591 (stop_character, last_timer_event): Mark as externally visible.
1592 * keyboard.h (ignore_mouse_drag_p): Declare only if
1593 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1594 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1595 * lisp.h (echoing): Remove decl.
1596 (force_auto_save_soon): Declare only if SIGDANGER.
1597 * xdisp.c (redisplay_window): Simplify code, to make it more
1598 obvious that ignore_mouse_drag_p is not accessed if !defined
1599 USE_GTK && !defined HAVE_NS.
1600
93ea6e8f
PE
1601 * intervals.c: Make symbols static if they're not exported.
1602 (merge_properties_sticky, merge_interval_right, delete_interval):
1603 Now static.
1604 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1605
77382fcc
PE
1606 * insdel.c: Make symbols static if they're not exported.
1607 However, leave prepare_to_modify_buffer alone. It's never
1608 called from outside this function, but that appears to be a bug.
1609 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1610 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1611 (adjust_after_replace_noundo): Remove; unused.
1612 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1613 (signal_before_change): Remove decls.
77382fcc 1614
9306c32e
PE
1615 * indent.c (val_compute_motion, val_vmotion): Now static.
1616
cd44d2eb
PE
1617 * image.c: Make symbols static if they're not exported.
1618 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1619 if USE_GTK.
1620 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1621 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1622
ad9a7a06
PE
1623 * fringe.c (standard_bitmaps): Now static.
1624 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1625
81626931
PE
1626 * frame.c: Make symbols static if they're not exported.
1627 (x_report_frame_params, make_terminal_frame): Now static.
1628 (get_frame_param): Now static, unless HAVE_NS.
1629 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1630 (x_get_resource_string): Remove; not used.
1631 * frame.h (make_terminal_frame, x_report_frame_params):
1632 (x_get_resource_string); Remove decls.
1633 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1634 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1635
239f9db9
PE
1636 * font.c, fontset.c: Make symbols static if they're not exported.
1637 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1638 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1639 * font.c (font_close_object): Now static.
1640 * font.h (font_close_object): Remove.
1641 * fontset.c (FONTSET_OBJLIST): Remove.
1642 (free_realized_fontset) #if-0 the body, which does nothing.
1643 (face_suitable_for_char_p): #if-0, as it's never called.
1644 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1645 * xfaces.c (face_at_string_position):
1646 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1647 since 0 is always ASCII.
1648
dfcf3579
PE
1649 * fns.c (weak_hash_tables): Now static.
1650
5045092b
PE
1651 * fileio.c: Make symbols static if they're not exported.
1652 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1653 (Vwrite_region_annotation_buffers): Now static.
1654
57a96f5c
PE
1655 * eval.c: Make symbols static if they're not exported.
1656 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1657 * lisp.h (backtrace_list): Remove decl.
1658
35f08c38
PE
1659 * emacs.c: Make symbols static if they're not exported.
1660 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1661 (fatal_error_code, fatal_error_signal_hook, standard_args):
1662 Now static.
1663 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1664 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1665 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1666 * lisp.h (fatal_error_signal_hook): Remove decl.
1667 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1668
f44bd759
PE
1669 * editfns.c: Move a (normally-unused) function to its only use.
1670 * editfns.c, lisp.h (get_operating_system_release): Remove.
1671 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1672 worth the hassle of breaking this out.
1673
b532497d
PE
1674 * xterm.c: Make symbols static if they're not exported.
1675 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1676 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1677 (x_destroy_window, x_delete_display):
1678 Now static.
1679 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1680 (x_mouse_leave): Remove; unused.
1681 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1682 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1683 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1684 Remove decls.
1685 (x_mouse_leave): Declare only if WINDOWSNT.
1686 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1687 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1688 USE_X_TOOLKIT.
1689
1675728f
PE
1690 * ftxfont.c: Make symbols static if they're not exported.
1691 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1692 HAVE_FREETYPE.
1693 * font.h (ftxfont_driver): Likewise.
1694
e4cebfca
PE
1695 * xfns.c: Make symbols static if they're not exported.
1696 (x_last_font_name, x_display_info_for_name):
1697 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1698 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1699 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1700 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1701 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1702 (last_show_tip_args): Now static.
1703 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1704 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1705 (x_screen_planes): Remove; unused.
1706 * dispextern.h (x_screen_planes): Remove decl.
1707
5bf46f05
PE
1708 * dispnew.c: Make symbols static if they're not exported.
1709 * dispextern.h (redraw_garbaged_frames, scrolling):
1710 (increment_row_positions): Remove.
1711 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1712 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1713 Now static.
1714 (redraw_garbaged_frames): Remove; unused.
1715
435f4c28
PE
1716 * xfaces.c: Make symbols static if they're not exported.
1717 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1718 Remove decls.
1719 * xterm.h (defined_color): Remove decls.
1720 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1721 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1722 (menu_face_changed_default, defined_color, free_realized_face):
1723 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1724 (ascii_face_of_lisp_face): Remove; unused.
1725
8524aef3
PE
1726 * xdisp.c: Make symbols static if they're not exported.
1727 * dispextern.h (scratch_glyph_row, window_box_edges):
1728 (glyph_to_pixel_coords, set_cursor_from_row):
1729 (get_next_display_element, set_iterator_to_next):
1730 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1731 (show_mouse_face): Remove decls
1732 * frame.h (message_buf_print): Likewise.
1733 * lisp.h (pop_message, set_message, check_point_in_composition):
1734 Likewise.
1735 * xterm.h (set_vertical_scroll_bar): Likewise.
1736 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1737 (message_buf_print, scratch_glyph_row, displayed_buffer):
1738 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1739 (get_next_display_element, show_mouse_face, window_box_edges):
1740 (frame_to_window_pixel_xy, check_point_in_composition):
1741 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1742 (glyph_to_pixel_coords): Remove; unused.
1743
16390cd2
PE
1744 * dired.c (file_name_completion): Now static.
1745
1746 * dbusbind.c (xd_in_read_queued_messages): Now static.
1747
a25f4dfa
PE
1748 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1749 * data.c (circular_list_error): Remove.
1750
14a9c8df
PE
1751 * commands.h (last_point_position, last_point_position_buffer):
1752 (last_point_position_window): Remove decls.
1753 * keyboard.c: Make these variables static.
1754
04f2d78b
CB
1755 * coding.h (coding, code_convert_region, encode_coding_gap):
1756 Remove decls.
74ab6df5
PE
1757 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1758 (iso_code_class, detect_coding, code_convert_region): Now static.
1759 (encode_coding_gap): Remove; unused.
1760
38dfbee1
PE
1761 * chartab.c (chartab_chars, chartab_bits): Now static.
1762
a2cb4e63
PE
1763 * charset.h (charset_iso_8859_1): Remove decl.
1764 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1765 Now static.
1766
127198fd
PE
1767 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1768 * ccl.c (Vccl_program_table): Now static.
1769 (check_ccl_update): Remove; unused.
1770
d85b608f
PE
1771 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1772 * category.h: ... from here.
1773 * category.c (check_category_table, set_category_set): Now static.
1774
31cd66f3
PE
1775 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1776 * lisp.h: Remove these decls.
1777
c358e587
PE
1778 * buffer.c (buffer_count): Remove unused var.
1779
e78aecca
PE
1780 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1781 so that it's not optimized away.
1782 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1783 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1784 exported only to the debugger.
1785
e192d7d3 1786 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1787 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1788
92470028
PE
1789 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1790 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1791 was inaccessible from Lisp.
1792 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1793 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1794
244ed907
PE
1795 alloc.c: Import and export fewer symbols, and remove unused items.
1796 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1797 is defined.
1798 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1799 it's not optimized away by whole-program optimization.
1800 (message_enable_multibyte, free_misc): Remove.
1801 (catchlist, handlerlist, mark_backtrace):
1802 Declare only if BYTE_MARK_STACK.
1803 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1804 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1805 (message_enable_multibyte): Remove decl.
1806 (free_misc, interval_free_list, float_block, float_block_index):
1807 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1808 (cons_free_list, last_marked_index):
1809 Now static.
1810 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1811 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1812 (mark_backtrace): Define only if BYTE_MARK_STACK.
1813 * xdisp.c (message_enable_multibyte): Now static.
1814
61c2b50e 1815 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1816 This makes it easier for human readers (and static analyzers)
1817 to see whether these variables are used from other modules.
1818 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1819 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1820 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1821 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1822 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1823 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1824 * xmenu.c, xselect.c:
1825 Declare Q* vars static if they are not used in other modules.
1826 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1827 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1828 Remove decls of unexported vars.
1829 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1830
95c82688
PE
1831 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1832
16a97296
PE
1833 Make Emacs functions such as Fatom 'static' by default.
1834 This makes it easier for human readers (and static analyzers)
1835 to see whether these functions can be called from other modules.
1836 DEFUN now defines a static function. To make the function external
1837 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1838 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1839 (Finit_image_library):
16a97296
PE
1840 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1841 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1842 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1843 Remove decls, since these functions are now static.
1844 (Funintern, Fget_internal_run_time): New decls, since these functions
1845 were already external.
95c82688 1846
16a97296
PE
1847 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1848 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1849 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1850 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1851 * keyboard.c, keymap.c, lread.c:
1852 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1853 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1854 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1855 Mark functions with DEFUE instead of DEFUN,
1856 if they are used in other modules.
1857 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1858 decls for now-static functions.
1859 * buffer.h (Fdelete_overlay): Remove decl.
1860 * callproc.c (Fgetenv_internal): Mark as internal.
1861 * composite.c (Fremove_list_of_text_properties): Remove decl.
1862 (Fcomposition_get_gstring): New forward static decl.
1863 * composite.h (Fcomposite_get_gstring): Remove decl.
1864 * dired.c (Ffile_attributes): New forward static decl.
1865 * doc.c (Fdocumntation_property): New forward static decl.
1866 * eval.c (Ffetch_bytecode): New forward static decl.
1867 (Funintern): Remove extern decl; now in .h file where it belongs.
1868 * fileio.c (Fmake_symbolic_link): New forward static decl.
1869 * image.c (Finit_image_library): New forward static decl.
1870 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1871 * intervals.h (Fprevious_property_change):
1872 (Fremove_list_of_text_properties): Remove decls.
1873 * keyboard.c (Fthis_command_keys): Remove decl.
1874 (Fcommand_execute): New forward static decl.
1875 * keymap.c (Flookup_key): New forward static decl.
1876 (Fcopy_keymap): Now static.
1877 * keymap.h (Flookup_key): Remove decl.
1878 * process.c (Fget_process): New forward static decl.
1879 (Fprocess_datagram_address): Mark as internal.
1880 * syntax.c (Fsyntax_table_p): New forward static decl.
1881 (skip_chars): Remove duplicate decl.
1882 * textprop.c (Fprevious_property_change): New forward static decl.
1883 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1884 Now internal.
1885 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1886 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1887
785bbd42
PE
1888 * editfns.c (Fformat): Remove unreachable code.
1889
8b913b57
AS
18902011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1891
1892 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1893 change. (Bug#8496)
1894
a6744a35
EZ
18952011-04-13 Eli Zaretskii <eliz@gnu.org>
1896
1897 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1898 when at ZV. (Bug#8487)
1899
e7974947
AS
19002011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1901
baad03f0
AS
1902 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1903 (Bug#8437)
1904 * keyboard.c (parse_tool_bar_item): Likewise.
1905 * sound.c (sound_cleanup, alsa_close): Likewise.
1906 * termcap.c (tgetent): Likewise.
1907 * xfns.c (x_default_font_parameter): Likewise.
1908 * xsettings.c (read_and_apply_settings): Likewise.
1909
e7974947
AS
1910 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1911 (overrun_check_free): Protoize.
1912
28272684
PE
19132011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1916 since callers should never pass a negative size.
1917 Change the signature to match that of plain 'read' and 'write'; see
1918 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1919 * lisp.h: Update prototypes of emacs_write and emacs_read.
1920
11997c76
EZ
19212011-04-11 Eli Zaretskii <eliz@gnu.org>
1922
1923 * xdisp.c (redisplay_window): Don't try to determine the character
1924 position of the scroll margin if the window start point w->startp
e896f03c 1925 is outside the buffer's accessible region. (Bug#8468)
11997c76 1926
8a2cbd72
EZ
19272011-04-10 Eli Zaretskii <eliz@gnu.org>
1928
1929 Fix write-region and its subroutines for buffers > 2GB.
1930 * fileio.c (a_write, e_write): Modify declaration of arguments and
1931 local variables to support buffers larger than 2GB.
1932 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1933
1934 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1935 argument, local variables, and return value.
1936
1937 * lisp.h: Update prototypes of emacs_write and emacs_read.
1938
1939 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1940
4073e537 19412011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1942
1ebfdcb6
PE
1943 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1944
b2ded58d
PE
1945 Fix more problems found by GCC 4.6.0's static checks.
1946
7d66342c
PE
1947 * xdisp.c (vmessage): Use a better test for character truncation.
1948
bbf47d44
PE
1949 * charset.c (load_charset_map): <, not <=, for optimization,
1950 and to avoid potential problems with integer overflow.
9248994d 1951 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1952 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1953 * editfns.c (Fformat): Likewise.
1e69125e 1954 * syntax.c (skip_chars): Likewise.
3befa583 1955
e3019616
PE
1956 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1957 This also lets GCC 4.6.0 generate slightly better loop code.
1958
becfa255
PE
1959 * callint.c (Fcall_interactively): <, not <=, for optimization.
1960 (Fcall_interactively): Count the number of arguments produced,
1961 not the number of arguments given. This is simpler and lets GCC
1962 4.6.0 generate slightly better code.
1963
dae0cd48
PE
1964 * ftfont.c: Distingish more carefully between FcChar8 and char.
1965 The previous code passed unsigned char * to a functions like
1966 strlen and xstrcasecmp that expect char *, which does not
1967 conform to the C standard.
1968 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1969 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1970 char * when the C standard requires it.
1971
76032d70
PE
1972 * keyboard.c (read_char): Remove unused var.
1973
eb3f1cc8
PE
1974 * eval.c: Port to Windows vsnprintf (Bug#8435).
1975 Include <limits.h>.
1976 (SIZE_MAX): Define if the headers do not.
1977 (verror): Do not give up if vsnprintf returns a negative count.
1978 Instead, grow the buffer. This ports to Windows vsnprintf, which
1979 does not conform to C99. Problem reported by Eli Zaretskii.
1980 Also, simplify the allocation scheme, by avoiding the need for
1981 calling realloc, and removing the ALLOCATED variable.
1982
70476b54
PE
1983 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1984
12020a9e
PE
1985 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1986 But keep the doprint source code for now, as we might revamp it
1987 and use it again (Bug#8435).
ea6c7ae6
PE
1988 * lisp.h (doprnt): Remove.
1989 * Makefile.in (base_obj): Remove doprnt.o.
1990 * deps.mk (doprnt.o): Remove.
1991
5fdb398c
PE
1992 error: Print 32- and 64-bit integers portably (Bug#8435).
1993 Without this change, on typical 64-bit hosts error ("...%d...", N)
1994 was used to print both 32- and 64-bit integers N, which relied on
1995 undefined behavior.
1996 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1997 New macro.
1998 * lisp.h (error, verror): Mark as printf-like functions.
1999 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2000 Report overflow in size calculations when allocating printf buffer.
2001 Do not truncate output string at its first null byte.
2002 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2003 Truncate the output at a character boundary, since vsnprintf does not
2004 do that.
2005 * charset.c (check_iso_charset_parameter): Convert internal
2006 character to string before calling 'error', since %c now has the
2007 printf meaning.
2008 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2009 overflow when computing char to be passed to 'error'. Do not
2010 pass Lisp_Object to 'error'; pass the integer instead.
2011 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2012 formatted with plain %d.
2013
b189fa66
PE
2014 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2015
bff87ef0
PE
2016 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2017
7e2cac20
PE
2018 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2019
ce4d90b5
PE
2020 * xterm.c (x_catch_errors): Remove duplicate declaration.
2021
266c9547
PE
2022 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2023
79c49ad2
PE
2024 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2025
368f4090
JM
20262011-04-10 Jim Meyering <meyering@redhat.com>
2027
2028 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2029 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2030 return ssize_t not "int", and use size_t as the buffer length.
2031 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2032 * gnutls.h: Update declarations.
2033 * process.c (read_process_output): Use ssize_t, to match.
2034 (send_process): Likewise.
2035
a32d4040
CY
20362011-04-09 Chong Yidong <cyd@stupidchicken.com>
2037
2038 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2039
8546720e 20402011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2041
04f2d78b
CB
2042 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2043 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2044
8546720e
GM
2045 * xterm.c (handle_one_xevent):
2046 * xmenu.c (create_and_show_popup_menu):
2047 * xselect.c (x_decline_selection_request)
2048 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2049
0a2f5c1a 20502011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2051
2052 Fix some uses of `int' instead of EMACS_INT.
2053 * search.c (string_match_1, fast_string_match)
2054 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2055 (scan_buffer, find_next_newline_no_quit)
2056 (find_before_next_newline, search_command, Freplace_match)
2057 (Fmatch_data): Make some `int' variables be EMACS_INT.
2058
2059 * xdisp.c (display_count_lines): 3rd argument and return value now
2060 EMACS_INT. All callers changed.
2061 (pint2hrstr): Last argument is now EMACS_INT.
2062
2063 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2064 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2065 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2066 (decode_coding_utf_16, decode_coding_emacs_mule)
2067 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2068 (decode_coding_ccl, decode_coding_charset)
2069 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2070 (decode_coding_iso_2022, decode_coding_emacs_mule)
2071 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2072 <char_offset, last_offset>: Declare EMACS_INT.
2073 (encode_coding_utf_8, encode_coding_utf_16)
2074 (encode_coding_emacs_mule, encode_invocation_designation)
2075 (encode_designation_at_bol, encode_coding_iso_2022)
2076 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2077 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2078 Declare EMACS_INT.
2079 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2080 (encode_invocation_designation): Last argument P_NCHARS is now
2081 EMACS_INT.
2082 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2083 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2084
2085 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2086 All users changed.
2087
2088 * ccl.c (Fccl_execute_on_string): Declare some variables
2089 EMACS_INT.
2090
8546720e 20912011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2092
2093 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2094
4e19a977
CS
20952011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2096
2097 * process.c (Fformat_network_address): Doc fix.
2098
87302331
R
20992011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2100
2101 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2102
cbb59342
CY
21032011-04-08 Chong Yidong <cyd@stupidchicken.com>
2104
2105 * keyboard.c (read_char): Call Lisp function help-form-show,
2106 instead of using internal_with_output_to_temp_buffer.
2107 (Qhelp_form_show): New var.
e0d38eeb 2108 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2109
2110 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2111
2112 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2113
e67a13ab
CY
21142011-04-06 Chong Yidong <cyd@stupidchicken.com>
2115
04f2d78b
CB
2116 * process.c (Flist_processes): Remove to Lisp.
2117 (list_processes_1): Delete.
e67a13ab 2118
973f782d
EZ
21192011-04-06 Eli Zaretskii <eliz@gnu.org>
2120
7c106b1e
EZ
2121 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2122
973f782d
EZ
2123 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2124
41cf7d1a 21252011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2126
ca23cc88
PE
2127 Fix more problems found by GCC 4.6.0's static checks.
2128
f390e2d5
PE
2129 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2130
42eea0d0
PE
2131 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2132
b69769da 2133 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2134
f9541e84
PE
2135 * xdisp.c (vmessage): Mark as a printf-like function.
2136
13841b55
PE
2137 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2138
c136c10f
PE
2139 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2140
5e2d4a30
PE
2141 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2142 printf-like functions.
2143 (tiff_load): Add casts to remove these marks before passing them
2144 to system-supplied API.
2145
583f48b9
PE
2146 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2147
b25d760e
PE
2148 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2149 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2150 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2151 directly, rather than having caller test rule sign. This avoids
2152 some unnecessary tests.
2153 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2154 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2155 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2156
bc7b6697 2157 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2158 (xfont_open): Avoid unnecessary tests.
bc7b6697 2159
27ccc379
PE
2160 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2161
dcd5c89a
PE
2162 * composite.h, composite.c (composition_gstring_put_cache):
2163 Use EMACS_INT, not int, for length.
2164
b13a45c6
PE
2165 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2166 breaking out part of COMPOSITION_DECODE_RULE.
2167 (COMPOSITION_DECODE_RULE): Use it.
2168 * composite.c (get_composition_id): Remove unused local vars,
2169 by using the new macro.
2170
1e792e4d
PE
2171 * textprop.c (set_text_properties_1): Change while to do-while,
2172 since the condition is always true at first.
2173
dc6c6455 2174 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2175 (interval_deletion_adjustment): Return unsigned value.
2176 All uses changed.
dc6c6455 2177
aba7731a
PE
2178 * process.c (list_processes_1, create_pty, read_process_output):
2179 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2180 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2181 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2182 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2183 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2184
fdfc4bf3
PE
2185 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2186
fca8fe46 2187 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2188 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2189
06a0259a 2190 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2191 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2192 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2193
e7b9e80f
PE
2194 * print.c (print_error_message): Avoid int overflow.
2195
56201685
PE
2196 * font.c (font_list_entities): Redo for clarity,
2197 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2198
78834453 2199 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2200 (font_score): Avoid potential overflow in diff calculation.
78834453 2201
0bc0b309 2202 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2203 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2204
e610eaca
PE
2205 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2206
b895abce
PE
2207 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2208 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2209 can always succeed if overflow has undefined behavior.
2210
1f1d9321 2211 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2212 (wordify): Omit three unnecessary tests.
1f1d9321 2213
c59478bc
PE
2214 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2215 All callers changed. This avoids the need for an unused var.
2216
79b73827
PE
2217 * casefiddle.c (casify_region): Remove var that is set but not used.
2218
a4db5dfe
PE
2219 * dired.c (file_name_completion): Remove var that is set but not used.
2220
43aae36e
PE
2221 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2222
2a47c44d 2223 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2224 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2225
a37c69bf
PE
2226 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2227 Check for integer overflow on size calculations.
2228
328ab8e7
PE
2229 * buffer.c (Fprevious_overlay_change): Remove var that is set
2230 but not used.
2231
e5a2a5cb
PE
2232 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2233 Remove vars that are set but not used.
8d84a6eb 2234 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2235 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2236
a60e5f68
PE
2237 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2238
f661cb61 2239 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2240 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2241
f0397f5a
PE
2242 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2243 that are set but not used.
2244
8664db06 2245 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2246 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2247
6abdaa4a
PE
2248 * xselect.c (x_get_local_selection, x_handle_property_notify):
2249 Remove vars that are set but not used.
2250
0ce7538d 2251 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2252 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2253
9ae848fc
PE
2254 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2255 Remove var that is set but not used.
0b918413
PE
2256 (scroll_bar_windows_size): Now size_t, not int.
2257 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2258 Check for overflow.
9ae848fc 2259
a5a62657
PE
2260 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2261 (map_tty_color) [!defined MSDOS]: Likewise.
2262
5c5cdd39
PE
2263 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2264
66ebf983
PE
2265 * coding.c: Remove vars that are set but not used.
2266 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2267 All callers changed.
2268 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2269 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2270 (decode_coding_charset): Remove vars that are set but not used.
2271
1be4d761
PE
2272 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2273 that is set but not used.
2274
47553fa8
PE
2275 * print.c (print_object): Remove var that is set but not used.
2276
1f7196bf 2277 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2278 The gnulib version avoids calling malloc in the usual case,
2279 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2280 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2281 * filelock.c (current_lock_owner): Likewise.
2282 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2283 * sysdep.c: Include allocator.h, careadlinkat.h.
2284 (emacs_no_realloc_allocator): New static constant.
2285 (emacs_readlink): New function.
fdb61804
PE
2286 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2287 ../lib/careadlinkat.h.
d1fdcab7 2288
f84c17c7
SM
22892011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2290
2291 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2292 first non-nil return value).
2293
ef3862ad
JD
22942011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2295
2296 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2297 if not defined (Bug#8403).
2298
376a7006
JB
22992011-04-02 Juanma Barranquero <lekktu@gmail.com>
2300
2301 * xdisp.c (display_count_lines): Remove parameter `start',
2302 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2303 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2304 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2305 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2306 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2307 and thereabouts. All callers changed.
2308 (get_per_char_metric): Remove parameter `f', unused since
2309 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2310
6ca3801d
JM
23112011-04-02 Jim Meyering <meyering@redhat.com>
2312
2313 do not dereference NULL upon failed strdup
2314 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2315 (ns_get_family): Likewise.
2316
d8e2b5ba
JB
23172011-04-02 Juanma Barranquero <lekktu@gmail.com>
2318
2319 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2320
8c74fcbd
JD
23212011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2322
2323 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2324 later (Bug#8403).
2325
7200d79c
SM
23262011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2327
03408648 2328 Add lexical binding.
7200d79c 2329
03408648
SM
2330 * window.c (Ftemp_output_buffer_show): New fun.
2331 (Fsave_window_excursion):
2332 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2333
2334 * lread.c (lisp_file_lexically_bound_p): New function.
2335 (Fload): Bind Qlexical_binding.
2336 (readevalloop): Remove `evalfun' arg.
2337 Bind Qinternal_interpreter_environment.
2338 (Feval_buffer): Bind Qlexical_binding.
2339 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2340 Mark as dynamic.
2341 (syms_of_lread): Declare `lexical-binding'.
2342
2343 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2344
2345 * keyboard.c (eval_dyn): New fun.
2346 (menu_item_eval_property): Use it.
ca105506
SM
2347
2348 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2349
03408648
SM
2350 * fns.c (concat, mapcar1): Accept byte-code-functions.
2351
2352 * eval.c (Fsetq): Handle lexical vars.
2353 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2354 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2355 (FletX, Flet): Obey lexical binding.
2356 (Fcommandp): Handle closures.
2357 (Feval): New `lexical' arg.
2358 (eval_sub): New function extracted from Feval. Use it almost
2359 everywhere where Feval was used. Look up vars in lexical env.
2360 Handle closures.
2361 (Ffunctionp): Move from subr.el.
2362 (Ffuncall): Handle closures.
2363 (apply_lambda): Remove `eval_flags'.
2364 (funcall_lambda): Handle closures and new byte-code-functions.
2365 (Fspecial_variable_p): New function.
2366 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2367 but without exporting it to Lisp.
23aba0ea 2368
23aba0ea 2369 * doc.c (Fdocumentation, store_function_docstring):
03408648 2370 * data.c (Finteractive_form): Handle closures.
23aba0ea 2371
03408648
SM
2372 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2373 interactive spec.
ba83908c 2374
04f2d78b
CB
2375 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2376 New byte-codes.
03408648
SM
2377 (exec_byte_code): New function extracted from Fbyte_code to handle new
2378 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2379
03408648 2380 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2381
03408648 2382 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2383
e2abce01
JB
23842011-03-31 Juanma Barranquero <lekktu@gmail.com>
2385
2386 * xdisp.c (redisplay_internal): Fix prototype.
2387
63696a73 23882011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2389
63696a73 2390 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2391 (try_scrolling): Use it when setting scroll_limit.
2392 Limit scrolling to 100 screen lines.
63696a73
EZ
2393 (redisplay_window): Even when falling back on "recentering",
2394 position point in the window according to scroll-conservatively,
2395 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2396
2397 (try_scrolling): When point is above the window, allow searching
2398 as far as scroll_max, or one screenful, to compute vertical
2399 distance from PT to the scroll margin position. This prevents
2400 try_scrolling from unnecessarily failing when
2401 scroll-conservatively is set to a value slightly larger than the
2402 window height. Clean up the case of PT below the margin at bottom
2403 of window: scroll_max can no longer be INT_MAX. When aggressive
2404 scrolling is in use, don't let point enter the opposite scroll
2405 margin as result of the scroll.
2406 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2407 threshold of 100 lines for never-recentering scrolling.
2408
e4cc2dfc
JB
24092011-03-31 Juanma Barranquero <lekktu@gmail.com>
2410
2411 * dispextern.h (move_it_by_lines):
2412 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2413 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2414 (message_log_check_duplicate): Remove parameters `prev_bol' and
2415 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2416 (redisplay_internal): Remove parameter `preserve_echo_area',
2417 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2418
2419 * indent.c (Fvertical_motion):
2420 * window.c (window_scroll_pixel_based, Frecenter):
2421 Don't pass `need_y_p' to `move_it_by_lines'.
2422
1c470562
SM
24232011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2424
44f230aa
SM
2425 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2426 steal a few bits to be more compact.
2427 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2428 Remove unneeded casts.
2429
1c470562
SM
2430 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2431
888adce9
ZK
24322011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2433
2434 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2435 binding" message (bug#7967).
2436
f838ed7b
PE
24372011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2438
77861b95
PE
2439 Fix more problems found by GCC 4.6.0's static checks.
2440
de6dbc14
PE
2441 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2442 Remove unused local var.
2443
f838ed7b
PE
2444 * editfns.c (Fmessage_box): Remove unused local var.
2445
792c7b2b
PE
2446 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2447 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2448 Omit unused local vars.
c499e557 2449 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2450 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2451 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2452 Omit unused local var.
2453
ba0165e1
PE
2454 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2455 Don't assume string length fits in int.
32ad8845 2456 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2457 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2458
3c59b4c9
PE
2459 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2460 instead of alloca (Bug#8344).
2461
a3eed478 2462 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2463 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2464
eb4d412d
PE
2465 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2466
1658b401
PE
2467 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2468 concerns.
2469
2470 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2471
2472 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2473
9a2c6e05
PE
2474 * keyboard.c (syms_of_keyboard): Use the same style as later
2475 in this function when indexing through an array. This also
2476 works around GCC bug 48267.
2477
03d0a109
PE
2478 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2479
44f730c8
PE
2480 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2481
fe75f926
PE
2482 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2483 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2484
ffa8c828
PE
2485 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2486 This avoids undefined behavior on integer overflow, and is a bit
2487 more convenient anyway since it is compared to a size_t variable.
2488
c5101a77
PE
2489 Variadic C functions now count arguments with size_t, not int.
2490 This avoids an unnecessary limitation on 64-bit machines, which
2491 caused (substring ...) to crash on large vectors (Bug#8344).
2492 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2493 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2494 All variadic functions and their callers changed accordingly.
c5101a77
PE
2495 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2496 * data.c (arith_driver, float_arith_driver): Likewise.
2497 * editfns.c (general_insert_function): Likewise.
2498 * eval.c (struct backtrace.nargs, interactive_p)
2499 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2500 (funcall_lambda, mark_backtrace): Likewise.
2501 * fns.c (concat): Likewise.
2502 * frame.c (x_set_frame_parameters): Likewise.
2503 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2504 0 if not found, not -1. All callers changed.
2505
dd3f25f7
PE
2506 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2507 (stack_copy_size): Now size_t, not int.
2508 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2509
461c2ab9
JB
25102011-03-28 Juanma Barranquero <lekktu@gmail.com>
2511
2512 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2513 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2514 All callers changed.
2515
2516 * lisp.h (multibyte_char_to_unibyte):
2517 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2518 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2519 * character.h (CHAR_TO_BYTE8):
2520 * cmds.c (internal_self_insert):
2521 * editfns.c (general_insert_function):
2522 * keymap.c (push_key_description):
2523 * search.c (Freplace_match):
2524 * xdisp.c (message_dolog, set_message_1): All callers changed.
2525
f6d62986
SM
25262011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2527
2528 * keyboard.c (safe_run_hook_funcall): New function.
2529 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2530 don't set the hook to nil, but remove the offending function instead.
2531 (Qcommand_hook_internal): Remove, unused.
2532 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2533 Vcommand_hook_internal.
2534
2535 * eval.c (enum run_hooks_condition): Remove.
2536 (funcall_nil, funcall_not): New functions.
2537 (run_hook_with_args): Call each function through a `funcall' argument.
2538 Remove `cond' argument, now redundant.
2539 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2540 (Frun_hook_with_args_until_failure): Adjust accordingly.
2541 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2542
1db5b1ad
JB
25432011-03-28 Juanma Barranquero <lekktu@gmail.com>
2544
2545 * dispextern.h (string_buffer_position): Remove declaration.
2546
2547 * print.c (strout): Remove parameter `multibyte', unused since
2548 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2549
2550 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2551 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2552 All callers changed.
2553
2554 * w32.c (_wsa_errlist): Use braces for struct initializers.
2555
2556 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2557 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2558 All callers changed.
2559 (string_buffer_position): Likewise. Also, make static (it's never
2560 used outside xdisp.c).
2561 (cursor_row_p): Remove parameter `w', unused since
2562 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2563 (decode_mode_spec): Remove parameter `precision', introduced during
2564 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2565 All callers changed.
2566
5ffb62aa
JD
25672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2568
2569 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2570
461c2ab9 25712011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2572
2573 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2574 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2575 (ns_update_auto_hide_menu_bar): New functions.
2576 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2577 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2578 ns_constrain_all_frames.
2579 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2580 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2581
5c380ffb
JD
25822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2583
2584 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2585
9af30bdf
GM
25862011-03-27 Glenn Morris <rgm@gnu.org>
2587
2588 * syssignal.h: Replace RETSIGTYPE with void.
2589 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2590 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2591 Replace SIGTYPE with void everywhere.
2592 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2593 * s/template.h (SIGTYPE): Remove commented out definition.
2594
e2abce01
JB
25952011-03-26 Eli Zaretskii <eliz@gnu.org>
2596
2597 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2598 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2599
f868cd8a
JB
26002011-03-26 Juanma Barranquero <lekktu@gmail.com>
2601
59eb0929
JB
2602 * w32.c (read_unc_volume): Use parameter `henum', instead of
2603 global variable `wget_enum_handle'.
2604
2605 * keymap.c (describe_vector): Remove parameters `indices' and
2606 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2607 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2608
f868cd8a
JB
2609 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2610
2611 * keyboard.c (timer_check): Remove parameter `do_it_now',
2612 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2613 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2614 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2615
2616 * keyboard.c (read_char):
2617 * w32menu.c (w32_menu_display_help):
2618 * xmenu.c (show_help_event, menu_help_callback):
2619 Adjust calls to `show_help_echo'.
2620
2621 * gtkutil.c (xg_maybe_add_timer):
2622 * keyboard.c (readable_events):
2623 * process.c (wait_reading_process_output):
2624 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2625
2626 * insdel.c (adjust_markers_gap_motion):
2627 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2628 (gap_left, gap_right): Don't call it.
2629
2ecf6fdb
CY
26302011-03-25 Chong Yidong <cyd@stupidchicken.com>
2631
2632 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2633 incurred during fontification.
2634
6b1f9ba4
JB
26352011-03-25 Juanma Barranquero <lekktu@gmail.com>
2636
2637 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2638 (DEFVAR_PER_BUFFER): Don't pass it.
2639
2640 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2641 (scrolling_window): Don't pass it.
2642
0f4a96b5
JB
26432011-03-25 Juanma Barranquero <lekktu@gmail.com>
2644
2645 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2646
2647 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2648 and `suffix'.
2649 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2650 of variables specific to SELinux and computation of `encoded_absname'.
2651
2652 * image.c (XPutPixel): Remove unused variable `height'.
2653
2654 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2655
2656 * unexw32.c (get_section_info): Remove unused variable `section'.
2657
2658 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2659 (system_process_attributes): Remove unused variable `sess'.
2660 (sys_read): Remove unused variable `err'.
2661
2662 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2663 (w32_wnd_proc): Remove unused variable `isdead'.
2664 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2665 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2666 (x_create_tip_frame): Remove unused variable `tem'.
2667
2668 * w32inevt.c (w32_console_read_socket):
2669 Remove unused variable `no_events'.
2670
2671 * w32term.c (x_draw_composite_glyph_string_foreground):
2672 Remove unused variable `width'.
2673
1149507c
JB
26742011-03-24 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * w32term.c (x_set_glyph_string_clipping):
2677 Don't pass uninitialized region to CombineRgn.
2678
9c88f339
JB
26792011-03-23 Juanma Barranquero <lekktu@gmail.com>
2680
2681 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2682 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2683 (Fx_close_connection): Remove unused variable `i'.
2684
2685 * w32font.c (w32font_draw): Return number of glyphs.
2686 (w32font_open_internal): Remove unused variable `i'.
2687 (w32font_driver): Add missing initializer.
2688
2689 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2690 (fill_in_menu): Remove unused variable `items_added'.
2691
2692 * w32term.c (last_mouse_press_frame): Remove static global variable.
2693 (w32_clip_to_row): Remove unused variable `f'.
2694 (x_delete_terminal): Remove unused variable `i'.
2695
2696 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2697 (NOTHING): Remove unused static global variable.
2698 (uniscribe_check_otf): Remove unused variable `table'.
2699 (uniscribe_font_driver): Add missing initializers.
2700
dee091a3
JD
27012011-03-23 Julien Danjou <julien@danjou.info>
2702
2703 * term.c (Fsuspend_tty, Fresume_tty):
2704 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2705 * window.c (temp_output_buffer_show):
2706 * insdel.c (signal_before_change):
2707 * frame.c (Fhandle_switch_frame):
2708 * fileio.c (Fdo_auto_save):
2709 * emacs.c (Fkill_emacs):
2710 * editfns.c (save_excursion_restore):
2711 * cmds.c (internal_self_insert):
2712 * callint.c (Fcall_interactively):
2713 * buffer.c (Fkill_all_local_variables):
2714 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2715 Use Frun_hooks.
0f4a96b5 2716 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2717 unconditionnaly since it does the check itself.
2718
2c520ab5 27192011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2720
c9c49752
PE
2721 Fix more problems found by GCC 4.5.2's static checks.
2722
8abc3f12
PE
2723 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2724 the first time through the loop, since we know p0 < p1 then.
2725 This also avoids a gcc -Wstrict-overflow warning.
2726
a2d26660
PE
2727 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2728 leading to a memory leak, possible in functions like
2729 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2730 of objects (Bug#8318).
a2d26660 2731
916c72e9
PE
2732 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2733 that could (at least in theory) be that large.
2734
19ab8a18
PE
2735 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2736 This is less likely to overflow, and avoids undefined behavior if
2737 overflow does occur. All callers changed. Use strtoul to scan
2738 for the unsigned long integer.
b7cbbd6f
PE
2739 (pint2hrstr): Simplify and tune code slightly.
2740 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2741
f0641eff
PE
2742 * scroll.c (do_scrolling): Work around GCC bug 48228.
2743 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2744
7f650bb9
PE
2745 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2746 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2747 (validate_x_resource_name): Simplify count usage.
2748 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2749
37dd57d1
PE
2750 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2751 fail (Bug#8306).
81e56e61 2752
699979fc 2753 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2754
401bf9b4
PE
2755 * process.c (Fmake_network_process): Use socklen_t, not int,
2756 where POSIX says socklen_t is required in portable programs.
2757 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2758 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2759 (Fmake_network_process, server_accept_connection):
2760 (wait_reading_process_output, read_process_output):
2761 Likewise.
2762
b93aacde
PE
2763 * process.c: Rename or move locals to avoid shadowing.
2764 (list_processes_1, Fmake_network_process):
2765 (read_process_output_error_handler, exec_sentinel_error_handler):
2766 Rename or move locals.
4dc343ee 2767 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2768 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2769 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2770 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2771 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2772
af8a867c 2773 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2774 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2775 Include tparam.h instead, since it declares them.
af8a867c
PE
2776 * cm.h (PC): Remove extern decl; tparam.h now does this.
2777 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2778 * terminfo.c: Include tparam.h, to check interfaces.
2779 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2780 (tparam): Adjust signature to match interface in tparam.h;
2781 this removes some undefined behavior. Check that outstring and len
2782 are zero, which they always are with Emacs.
2783 * tparam.h (PC, BC, UP): New extern decls.
2784
0248044d 2785 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2786 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2787
8ff096c1 2788 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2789 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2790 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2791 (ftfont_list): Remove unused local.
49eaafba
PE
2792 (get_adstyle_property, ftfont_pattern_entity):
2793 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2794 Rename locals to avoid shadowing.
8ff096c1 2795
e2be39f6
PE
2796 * xfont.c (xfont_list_family): Mark var as initialized.
2797
c9735e30
PE
2798 * xml.c (make_dom): Now static.
2799
8f5201ae
PE
2800 * composite.c (composition_compute_stop_pos): Rename local to
2801 avoid shadowing.
b246f932
PE
2802 (composition_reseat_it): Remove unused locals.
2803 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2804 (composition_update_it): Mark var as initialized.
11b61122
PE
2805 (find_automatic_composition): Mark vars as initialized,
2806 with a FIXME (Bug#8290).
8f5201ae 2807
760fbc2c
PE
2808 character.h: Rename locals to avoid shadowing.
2809 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2810 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2811 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2812 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2813 to avoid shadowing.
2814
ff08eb85
PE
2815 * textprop.c (property_change_between_p): Remove; unused.
2816
fc7bf025
PE
2817 * intervals.c (interval_start_pos): Now static.
2818
235d7abc
PE
2819 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2820
44f230aa
SM
2821 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2822 Rename locals to avoid shadowing.
3e7d6594 2823
50060332
PE
2824 * sound.c (wav_play, au_play, Fplay_sound_internal):
2825 Fix pointer signedness.
d01f234b 2826 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2827 (wav_play): Initialize a variable to 0, to prevent undefined
2828 behavior (Bug#8278).
50060332 2829
c4fc4e30
PE
2830 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2831
918436ed
PE
2832 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2833
c939f91b
PE
2834 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2835 clobbering (Bug#8298).
b9c7f648
PE
2836 * sysdep.c (sys_subshell): Likewise.
2837 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2838
6bd8c144
PE
2839 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2840 This should get cleaned up, so that child_setup has the
2841 same signature on all platforms.
2842
7710357c 2843 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2844 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2845
c59da222
CY
28462011-03-22 Chong Yidong <cyd@stupidchicken.com>
2847
2848 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2849 not to be necessary, and produces flickering.
2850
66b87493
GM
28512011-03-20 Glenn Morris <rgm@gnu.org>
2852
2853 * config.in: Remove file.
2854
45b6f6d5
JB
28552011-03-20 Juanma Barranquero <lekktu@gmail.com>
2856
2857 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2858 are now in src/globals.h.
2859 (syms_of_minibuf): Remove spurious & from previous change.
2860
3ec03f7e
LL
28612011-03-20 Leo <sdl.web@gmail.com>
2862
2863 * minibuf.c (completing-read-function): New variable.
2864 (completing-read-default): Rename from completing-read.
2865 (completing-read): Call completing-read-function.
2866
b14e3e21
CY
28672011-03-19 Juanma Barranquero <lekktu@gmail.com>
2868
2869 * xfaces.c (Fx_load_color_file):
2870 Read color file from absolute filename (bug#8250).
2871
f2b726e6
JB
28722011-03-19 Juanma Barranquero <lekktu@gmail.com>
2873
2874 * makefile.w32-in: Update dependencies.
2875
09f6ff02
EZ
28762011-03-17 Eli Zaretskii <eliz@gnu.org>
2877
2878 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2879
29a6015a
PE
28802011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2881
a3a6c54e
PE
2882 Fix more problems found by GCC 4.5.2's static checks.
2883
b766f867
PE
2884 * process.c (make_serial_process_unwind, send_process_trap):
2885 (sigchld_handler): Now static.
2886
be02381c
PE
2887 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2888 That way, the code declares only the vars that it needs.
2889 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2890 * s/cygwin.h (PTY_ITERATION): Likewise.
2891 * s/darwin.h (PTY_ITERATION): Likewise.
2892 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2893
57048744
PE
2894 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2895 * process.c (allocate_pty): Don't declare stb unless it's needed.
2896
7914961c 2897 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2898 (CONSTANTLIM): Remove; unused.
2899 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2900 Define only if needed.
7914961c 2901
b3967b18
PE
2902 * unexelf.c (unexec): Name an expression,
2903 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2904 Use a different way to cause a compilation error if anyone uses
2905 n rather than nn, a way that does not involve shadowing.
73366a00 2906 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2907
29a6015a
PE
2908 * deps.mk (unexalpha.o): Remove; unused.
2909
43cfc33e 2910 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2911 * unexec.h: New file.
ce701a33
PE
2912 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2913 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2914 Depend on unexec.h.
2915 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2916 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2917 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2918 Change as necessary to match prototype in unexec.h.
ce701a33 2919
01f44d5a
PE
2920 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2921 shadowing.
4f63c6bb 2922 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2923
a6670b0b
PE
2924 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2925 Rename locals to avoid shadowing.
2926
cef2010d 2927 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2928 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2929
d4d7173a
PE
2930 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2931
f08b802a
PE
2932 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2933 warning when compiling print.c.
2934
3ddb0639
PE
2935 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2936 instead of using an uninitialized var.
5ad03b97 2937 (font_sort_entities): Mark var as initialized.
3ddb0639 2938
170a2692
PE
2939 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2940
e663c700
PE
2941 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2942 pointers to constants.
89bc529a 2943 (font_parse_fcname): Remove unused vars.
7b81e2d0 2944 (font_delete_unmatched): Now static.
ea838e10 2945 (font_get_spec): Remove; unused.
13a547c6
PE
2946 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2947 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2948 Rename or move locals to avoid shadowing.
e663c700 2949
2a80c887 2950 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2951 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2952
1384fa33 2953 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2954 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2955
8b2c52e9
PE
2956 * alloc.c (mark_backtrace): Move decl from here ...
2957 * lisp.h: ... to here, so that it can be checked.
2958
475545b5 2959 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2960 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2961 (lisp_indirect_variable): Name an expression,
2962 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2963 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2964
b1349114 2965 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2966 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2967 Use const pointer when appropriate.
b1349114 2968
a2928364
PE
2969 * lisp.h (get_system_name, get_operating_system_release):
2970 Move decls here, to check interfaces.
2971 * process.c (get_operating_system_release): Move decl to lisp.h.
2972 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2973 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2974 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2975 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2976 (Fformat_time_string, Fencode_time, Finsert_char):
2977 (Ftranslate_region_internal, Fformat):
2978 Rename or remove local vars to avoid shadowing.
9710023e 2979 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2980
a415e694
PE
2981 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2982 avoid shadowing.
2983
8ef4622d
PE
2984 * lisp.h (eassert): Check that the argument compiles, even if
2985 ENABLE_CHECKING is not defined.
2986
946f9a5b
PE
2987 * data.c (Findirect_variable): Name an expression, to avoid
2988 gcc -Wbad-function-cast warning.
112396d6 2989 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2990 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2991 (Fmake_variable_buffer_local, Fmake_local_variable):
2992 Mark variables as initialized.
52746918 2993 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2994
e5aab7e7 2995 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2996 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2997 Rename locals to avoid shadowing.
dff45157
PE
2998 (mark_stack): Move local variables into the #ifdef region where
2999 they're used.
7bc26fdb
PE
3000 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3001 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3002 needed otherwise.
3003 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3004 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3005 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3006
e5aab7e7
PE
3007 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3008 avoids undefined behavior in theory.
3009
4da60324
PE
3010 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3011
88043301
PE
3012 Use functions, not macros, for up- and down-casing (Bug#8254).
3013 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3014 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3015 to use the following functions instead of these macros.
3016 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3017 EMACS_INT, since callers assume the returned value fits in int.
3018 (upcase1): Likewise, for UPCASE_TABLE.
3019 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3020 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3021 the race-condition problem in the old DOWNCASE.
88043301 3022
19ed5445
PE
3023 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3024 Rename locals to avoid shadowing.
3025 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3026 (regex_compile, re_search_2, re_match_2_internal):
3027 Remove unused local vars.
952db0d7
PE
3028 (FREE_VAR): Rewrite so as not to use empty "else",
3029 which gcc can warn about.
da053e48 3030 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3031 (RETALLOC_IF): Define only if needed.
3032 (WORDCHAR_P): Likewise. This one is never needed, but is used
3033 only in a comment talking about a compiler bug, so put inside
3034 the #if 0 of that comment.
3035 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3036 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3037 Remove; unused.
19ed5445 3038
1f3561e4 3039 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3040 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3041 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3042
ded6f8f7
PE
3043 * search.c (simple_search): Remove unused var.
3044
dbd37a95
PE
3045 * dired.c (compile_pattern): Move decl from here ...
3046 * lisp.h: ... to here, so that it can be checked.
3047 (struct re_registers): New forward decl.
3048
7e47afad
PE
3049 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3050
85f24f61
PE
3051 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3052 All uses changed.
3053 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3054 Rename locals to avoid shadowing.
5671df8f 3055 (Fvertical_motion): Mark locals as initialized.
85f24f61 3056
181aa2be 3057 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3058 (casify_region): Mark local as initialized.
181aa2be 3059
930d429c
PE
3060 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3061
7082eac6
PE
3062 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3063 New macros, so that the caller can use some names other than
3064 gcpro1, gcpro2, etc.
3065 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3066 of the new macros.
3067 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3068 argument, for consistency with GCPRO2_VAR, etc: it is now the
3069 prefix of the variable, not the variable itself. All uses
3070 changed.
38b2c076
PE
3071 * dired.c (directory_files_internal, file_name_completion):
3072 Rename locals to avoid shadowing.
3073
15206ed9
PE
3074 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3075 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3076 dired.c's scmp function, had undefined behavior.
3077 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3078 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3079 * buffer.h: ... to here, because these macros use current_buffer,
3080 and the new implementation with inline functions needs to have
3081 current_buffer in scope now, rather than later when the macros
3082 are used.
3083 (downcase, upcase1): New static inline functions.
3084 (DOWNCASE, UPCASE1): Reimplement using these functions.
3085 This avoids undefined behavior in expressions like
3086 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3087 from race conditions in accessing the global variables
3088 case_temp1 and case_temp2.
3089 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3090 * lisp.h (case_temp1, case_temp2): Remove their decls.
3091 * character.h (ASCII_CHAR_P): Move from here ...
3092 * lisp.h: ... to here, so that the inline functions mentioned
3093 above can use them.
3094
4a6bea26
PE
3095 * dired.c (directory_files_internal_unwind): Now static.
3096
f14b7e14
PE
3097 * fileio.c (file_name_as_directory, directory_file_name):
3098 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3099 Now static.
2893f146
PE
3100 (file_name_as_directory): Use const pointers when appropriate.
3101 (Fexpand_file_name): Likewise. In particular, newdir might
3102 point at constant storage, so make it a const pointer.
fd4ead52 3103 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3104 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3105 signedness issues.
f839df0c
PE
3106 (Fset_file_times, Finsert_file_contents, auto_save_error):
3107 Rename locals to avoid shadowing.
f14b7e14 3108
5716756e 3109 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3110 (Ftry_completion, Fall_completions): Rename or remove locals
3111 to avoid shadowing.
5716756e 3112
b4c3046a
PE
3113 * marker.c (bytepos_to_charpos): Remove; unused.
3114
b45db522
PE
3115 * lisp.h (verify_bytepos, count_markers): New decls,
3116 so that gcc does not warn that these functions aren't declared.
3117
85876d07
PE
3118 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3119 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3120 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3121 (copy_text): Remove unused local var.
85876d07 3122
03d78a21 3123 * filelock.c (within_one_second): Now static.
b3dd38ab 3124 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3125
5df8f01b
PE
3126 * buffer.c (fix_overlays_before): Mark locals as initialized.
3127 (fix_start_end_in_overlays): Likewise. This function should be
3128 simplified by using pointers-to-pointers, but that's a different
3129 matter.
b1d876f1 3130 (switch_to_buffer_1): Now static.
8f54f30a
PE
3131 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3132 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3133
a70072c9 3134 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3135 Fix pointer signedness issue.
edced198
PE
3136 (sys_subshell): Mark local as volatile if checking for lint,
3137 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3138 (MAXPATHLEN): Define only if needed.
a70072c9 3139
a0977c44
PE
3140 * process.c (serial_open, serial_configure): Move decls from here ...
3141 * systty.h: ... to here, so that they can be checked.
3142
a884fdcc
PE
3143 * fns.c (get_random, seed_random): Move extern decls from here ...
3144 * lisp.h: ... to here, so that they can be checked.
3145
604efe86 3146 * sysdep.c (reset_io): Now static.
b8950c94 3147 (wait_for_termination_signal): Remove; unused.
604efe86 3148
38fc62d9
PE
3149 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3150 (copy_keymap_item, append_key, push_text_char_description):
3151 Now static.
1004a21a 3152 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3153 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3154 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3155 (describe_map_tree):
3156 Rename locals to avoid shadowing.
38fc62d9 3157
2f2650da
PE
3158 * keyboard.c: Declare functions static if they are not used elsewhere.
3159 (echo_char, echo_dash, cmd_error, top_level_2):
3160 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3161 (read_char, kbd_buffer_get_event, make_lispy_position):
3162 (make_lispy_event, make_lispy_movement, apply_modifiers):
3163 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3164 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3165 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3166 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3167 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3168
a053e86c 3169 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3170 (mark_kboards): Move decl here ...
3171 * alloc.c (mark_kboards): ... from here.
a053e86c 3172
4752793e
PE
3173 * lisp.h (force_auto_save_soon): New decl.
3174
74f10ca7 3175 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3176 (DEFINE_DUMMY_FUNCTION): New macro.
3177 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3178 Use it.
c03cd23f
PE
3179 (main): Add casts to avoid warnings
3180 if GCC considers string literals to be constants.
74f10ca7 3181
022e70d4
PE
3182 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3183
59d6fe83
PE
3184 * dbusbind.c: Pointer signedness fixes.
3185 (xd_signature, xd_append_arg, xd_initialize):
3186 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3187 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3188 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3189 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3190
78320123
PE
3191 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3192 if GCC considers string literals to be constants.
49cebcca 3193 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3194
35ac2a97
SM
31952011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3196
fb103ca9
SM
3197 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3198 (print_preprocess, print_object): New macro to fix last change.
3199
35ac2a97
SM
3200 * print.c (print_preprocess): Don't forget font objects.
3201
62973b41
JB
32022011-03-16 Juanma Barranquero <lekktu@gmail.com>
3203
3204 * emacs.c (USAGE3): Doc fixes.
3205
0e48bb22
AS
32062011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3207
3208 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3209 structure.
3210
7684e57b
JB
32112011-03-14 Juanma Barranquero <lekktu@gmail.com>
3212
3213 * lisp.h (VWindow_system, Qfile_name_history):
3214 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3215 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3216 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3217
3218 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3219 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3220
3221 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3222 * w32console.c (detect_input_pending, read_input_pending)
3223 (encode_terminal_code):
3224 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3225 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3226 (w32_system_caret_y, Qfile_name_history):
3227 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3228 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3229 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3230 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3231 * w32proc.c (Qlocal, report_file_error):
3232 * w32term.c (Vwindow_system, updating_frame):
3233 * w32uniscribe.c (initialized, uniscribe_font_driver):
3234 Remove unneeded extern declarations.
3235
2aa46d6c
CY
32362011-03-14 Chong Yidong <cyd@stupidchicken.com>
3237
c96bbc66 3238 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3239
cffc6f3b
CY
32402011-03-13 Chong Yidong <cyd@stupidchicken.com>
3241
3242 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3243 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3244 These macros can no longer be used for assignment.
3245
44f230aa
SM
3246 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3247 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3248 (record_buffer_markers, fetch_buffer_markers): New functions for
3249 recording and fetching special buffer markers.
3250 (set_buffer_internal_1, set_buffer_temp): Use them.
3251
3252 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3253
3254 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3255
3256 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3257 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3258
3259 * xdisp.c (hscroll_window_tree):
3260 (reconsider_clip_changes): Use PT instead of BUF_PT.
3261
d251f04b
EZ
32622011-03-13 Eli Zaretskii <eliz@gnu.org>
3263
3264 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3265 $(EMACS_ROOT)/lib/intprops.h.
3266
f0c77cd1
PE
32672011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3268
3eca4629
PE
3269 Fix more problems found by GCC 4.5.2's static checks.
3270
7c86ee98
PE
3271 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3272 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3273 (xg_free_frame_widgets): Make it clear that a local variable is
3274 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3275 (gdk_window_get_screen): Make it clear that this macro is needed
3276 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3277 (int_gtk_range_get_value): New function, which avoids a diagnostic
3278 from gcc -Wbad-function-cast.
3279 (xg_set_toolkit_scroll_bar_thumb): Use it.
3280 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3281 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3282 (get_utf8_string, xg_get_file_with_chooser):
3283 Rename locals to avoid shadowing.
3284 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3285
41729b81
PE
3286 * xgselect.c (xg_select): Remove unused var.
3287
f0c77cd1
PE
3288 * image.c (four_corners_best): Mark locals as initialized.
3289 (gif_load): Initialize transparent_p to zero (Bug#8238).
3290 Mark another local as initialized.
ec6cf4c6 3291 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3292
ce0ad53d 3293 * image.c (clear_image_cache): Now static.
d5d5a617 3294 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3295 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3296 (x_edge_detection): Remove unnecessary cast that
3297 gcc -Wbad-function-cast diagnoses.
2037898d 3298 (gif_load): Fix pointer signedness.
6ae141d6
PE
3299 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3300 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3301
33383987 33022011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3303
d32df629
PE
3304 Improve quality of tests for time stamp overflow.
3305 For example, without this patch (encode-time 0 0 0 1 1
3306 1152921504606846976) returns the obviously-bogus value (-948597
3307 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3308 reports time overflow. See
3309 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3310 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3311 * editfns.c: Include limits.h and intprops.h.
3312 (TIME_T_MIN, TIME_T_MAX): New macros.
3313 (time_overflow): Move earlier, to before first use.
3314 (hi_time, lo_time): New functions, for an accurate test for
3315 out-of-range times.
3316 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3317 (Fget_internal_run_time): Don't assume time_t fits in int.
3318 (make_time): Use list2 instead of Fcons twice.
3319 (Fdecode_time): More accurate test for out-of-range times.
3320 (check_tm_member): New function.
3321 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3322 (lisp_time_argument): Don't rely on undefined left-shift and
3323 right-shift behavior when checking for time stamp overflow.
8be6f318 3324
fe31d94c
PE
3325 * editfns.c (time_overflow): New function, refactoring common code.
3326 (Fformat_time_string, Fdecode_time, Fencode_time):
3327 (Fcurrent_time_string): Use it.
3328
8be6f318
PE
3329 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3330 * dired.c (make_time): Move to ...
3331 * editfns.c (make_time): ... here.
3332 * systime.h: Note the move.
3333
09d9db2c 33342011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3335
126bc0dc
YM
3336 * fringe.c (update_window_fringes): Remove unused variables.
3337
c47cbdfd
YM
3338 * unexmacosx.c (copy_data_segment): Also copy __got section.
3339 (Bug#8223)
3340
7ac80be9
EZ
33412011-03-12 Eli Zaretskii <eliz@gnu.org>
3342
c96bbc66 3343 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3344 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3345 Constify `char *' arguments and their references according to
3346 prototypes in tparam.h.
3347
ecb0f94d 3348 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3349
7ac80be9
EZ
3350 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3351 Adapt all references accordingly.
3352
3353 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3354
ef1fd07e
TT
33552011-03-11 Tom Tromey <tromey@redhat.com>
3356
3357 * buffer.c (syms_of_buffer): Remove obsolete comment.
3358
7ef4b50c
EZ
33592011-03-11 Eli Zaretskii <eliz@gnu.org>
3360
3361 * termhooks.h (encode_terminal_code): Declare prototype.
3362
3363 * msdos.c (encode_terminal_code): Don't declare prototype.
3364
3365 * term.c (encode_terminal_code): Now external again, used by
3366 w32console.c and msdos.c.
3367
44f230aa
SM
3368 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3369 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3370
4b1ec863 33712011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3372
1714f52b 3373 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3374
4b1ec863
PE
3375 * fringe.c (update_window_fringes): Mark locals as initialized
3376 (Bug#8227).
3377 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3378
524c7aa6
PE
3379 * alloc.c (mark_fringe_data): Move decl from here ...
3380 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3381 to check its interface.
3382 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3383
a5c0af81 3384 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3385 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3386 (fontset_font): Mark local as initialized.
a9a06e0b 3387 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3388
b4716021
PE
3389 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3390
811e9bac 3391 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3392 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3393 (x_own_selection, Fx_disown_selection_internal): Rename locals
3394 to avoid shadowing.
3395 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3396
7e3ab302
PE
3397 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3398 so that the caller can use some name other than gcpro1.
3399 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3400 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3401 (Fx_backspace_delete_keys_p):
3402 Use them to avoid shadowing, and rename vars to avoid shadowing.
3403 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3404 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3405 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3406 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3407 Remove unused locals.
7e3ab302
PE
3408 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3409 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3410 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3411 macros.
f78faa98 3412
e2b13473
PE
3413 * xterm.h (x_mouse_leave): New decl.
3414
77f23912
PE
3415 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3416 Remove unused functions.
cdf4ba58
PE
3417 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3418 (x_calc_absolute_position): Now static.
7411c686 3419 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3420 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3421 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3422 unless they are used.
38d0b34a
PE
3423 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3424 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3425 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3426 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3427 (x_error_catcher, x_connection_closed, x_error_handler):
3428 (x_error_quitter, xembed_send_message, x_iconify_frame):
3429 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3430 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3431 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3432
44f230aa
SM
3433 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3434 Rename or move locals to avoid shadowing.
6b463e58 3435 (tty_defined_color, merge_face_heights): Now static.
5967d051 3436 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3437 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3438 does not deduce is never used uninitialized.
73719eba
PE
3439 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3440 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3441
426994c3 3442 * terminal.c (store_terminal_param): Now static.
5489860b 3443
032f1620 3444 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3445 (set_frame_menubar): Remove unused local.
d4323972 3446 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3447 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3448 since they might point to immutable storage.
281585b0
PE
3449 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3450 since it's unused otherwise.
032f1620 3451
367c19e5 3452 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3453 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3454 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3455 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3456 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3457 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3458 does not deduce are never used uninitialized.
70739cbe 3459
07b48fa9
PE
3460 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3461
8868a238 3462 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3463 * window.c (window_loop, size_window):
3464 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3465
7e5cf297 3466 * window.c (display_buffer): Now static.
d6550a9f
PE
3467 (size_window): Mark variables that gcc -Wuninitialized
3468 does not deduce are never used uninitialized.
a586633d
PE
3469 * window.h (check_all_windows): New decl, to forestall
3470 gcc -Wmissing-prototypes diagnostic.
5b555da1 3471 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3472
f6095868
PE
3473 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3474 shadowing.
3475 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3476 Include <limits.h>.
3477 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3478 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3479 (load_charset_map): Mark variables that gcc -Wuninitialized
3480 does not deduce are never used uninitialized.
53df7c11 3481 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3482
f38b440c
PE
3483 * coding.c (coding_set_source, coding_set_destination):
3484 Use "else { /* comment */ }" rather than "else /* comment */;"
3485 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3486 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3487 a block, when the outer 'i' will do.
3488 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3489 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3490 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3491 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3492 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3493 Rename locals to avoid shadowing.
3494 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3495 * coding.c (emacs_mule_char, encode_invocation_designation):
3496 Now static, since they're not used elsewhere.
413bb2db 3497 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3498 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3499 (decode_coding_emacs_mule): Mark variables that gcc
3500 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3501 (detect_coding_iso_2022): Initialize a local variable that might
3502 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3503 this initialization is needed. (Bug#8211)
5f58e762
PE
3504 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3505 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3506 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3507 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3508 Remove unused macros.
f38b440c 3509
232b38b9 3510 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3511 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3512 * character.c (string_count_byte8): Likewise.
232b38b9 3513
fb90da1b
PE
3514 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3515 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3516
fb93dbc2
PE
3517 * chartab.c (copy_sub_char_table): Now static, since it's not used
3518 elsewhere.
5c156ace
PE
3519 (sub_char_table_ref_and_range, char_table_ref_and_range):
3520 Rename locals to avoid shadowing.
bbcd0949 3521 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3522
7d3b3862 3523 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3524 (BIDI_BOB): Remove unused macro.
7d3b3862 3525
6be7d3da
PE
3526 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3527 deduce are never used uninitialized.
c2ed9c8b 3528 * term.c (encode_terminal_code): Likewise.
6be7d3da 3529
75f8807f 3530 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3531
50938595
PE
3532 * tparam.h: New file.
3533 * term.c, tparam.h: Include it.
3534 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3535 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3536 Move these decls to tparam.h, and make them agree with what
3537 is actually in tparam.c. The previous trick of using incompatible
3538 decls in different modules does not conform to the C standard.
3539 All callers of tparam changed to use tparam's actual API.
3540 * tparam.c (tparam1, tparam, tgoto):
3541 Use const pointers where appropriate.
3542
fbceeba2
PE
3543 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3544 * cm.h (struct cm): Likewise.
3545 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3546 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3547 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3548 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3549 (turn_on_face, init_tty): Likewise.
3550 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3551
7f3f1250
PE
3552 * term.c (term_mouse_position): Rename local to avoid shadowing.
3553
e6ca6543
PE
3554 * alloc.c (mark_ttys): Move decl from here ...
3555 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3556
c40f8d15
AS
35572011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3558
3559 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3560
cfe0661d
JB
35612011-03-09 Juanma Barranquero <lekktu@gmail.com>
3562
3563 * search.c (compile_pattern_1): Remove argument regp, unused since
3564 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3565 (compile_pattern): Don't pass it.
3566
0afb4571
J
35672011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3568
3569 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3570 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3571 for ! HAVE_GTK3.
3572 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3573
3574 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3575
3576 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3577 gdk_window_get_screen, gdk_window_get_geometry,
3578 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3579 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3580 (xg_get_pixbuf_from_pixmap): New function.
3581 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3582 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3583 Call xg_get_pixbuf_from_pixmap instead of
3584 gdk_pixbuf_get_from_drawable.
3585 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3586 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3587 (xg_check_special_colors): Use GtkStyleContext and its functions
3588 for HAVE_GTK3.
3589 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3590 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3591 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3592 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3593 Call gtk_widget_get_preferred_size.
0afb4571
J
3594 (xg_frame_resized): gdk_window_get_geometry only takes 5
3595 parameters.
44f230aa
SM
3596 (xg_win_to_widget, xg_event_is_for_menubar):
3597 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3598 (xg_set_widget_bg): New function.
3599 (delete_cb): New function.
895009e1 3600 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3601 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3602 (xg_set_background_color): Call xg_set_widget_bg.
3603 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3604 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3605 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3606 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3607 if ! HAVE_GTK3.
3608 (update_frame_tool_bar): Call gtk_widget_hide.
3609 (xg_initialize): Use GDK_KEY_g.
3610
3611 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3612 if ! HAVE_GTK3
3613 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3614
3615 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3616 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3617 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3618
1c2cc4ef
JB
36192011-03-08 Juanma Barranquero <lekktu@gmail.com>
3620
3621 * w32xfns.c (select_palette): Check success of RealizePalette against
3622 GDI_ERROR, not zero.
3623
33383987 3624See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3625
3626;; Local Variables:
3627;; coding: utf-8
aac0c6e3
MR
3628;; End:
3629
33383987 3630 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3631
3632 This file is part of GNU Emacs.
3633
3634 GNU Emacs is free software: you can redistribute it and/or modify
3635 it under the terms of the GNU General Public License as published by
3636 the Free Software Foundation, either version 3 of the License, or
3637 (at your option) any later version.
3638
3639 GNU Emacs is distributed in the hope that it will be useful,
3640 but WITHOUT ANY WARRANTY; without even the implied warranty of
3641 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3642 GNU General Public License for more details.
3643
3644 You should have received a copy of the GNU General Public License
3645 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.