Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
61bfeeb7
PE
12011-08-31 Paul Eggert <eggert@cs.ucla.edu>
2
0999621a 3 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2be7d702
PE
23 * dbusbind.c (signature_cat): New function.
24 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
25 Do not overrun buffer; instead, report string overflow.
26
9d1df220
PE
27 * dispnew.c (add_window_display_history): Don't overrun buffer.
28 Truncate instead; this is OK since it's just a log.
29
33ef5c64
PE
30 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
31 even if the time zone offset is outlandishly large.
32 Don't mishandle offset == INT_MIN.
33
66c6fdd5
PE
34 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
35 when creating daemon; the previous buffer-overflow check was incorrect.
36
d749b01b
PE
37 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
38 which has the guts of the old verror function.
39
b5cd1905
PE
40 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
41 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
42
6e1a67fb
PE
43 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
44 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 45 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
e91caa60 46 fits in int, when using sprintf. Use single esnprintf to count
c21721cc
PE
47 length of string rather than counting it via multiple sprintfs;
48 that's simpler and more reliable.
c21721cc
PE
49 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
50 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
51 sprintf, in case result does not fit in int.
52
c57b67fc
PE
53 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
54 (fontset_from_font): Print it.
55
8a401434
PE
56 * frame.c (tty_frame_count): Now printmax_t, not int.
57 (make_terminal_frame, set_term_frame_name): Print it.
58 (x_report_frame_params): In X, window IDs are unsigned long,
59 not signed long, so print them as unsigned.
60 (validate_x_resource_name): Check for implausibly long names,
61 and don't assume name length fits in 'int'.
62 (x_get_resource_string): Don't blindly alloca invocation name;
63 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
64 not fit in int.
65
6e1a67fb
PE
66 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
67 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
68 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
69
0df02bf3
PE
70 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
71 Use esprintf, not sprintf, in case result does not fit in int.
72
48e30793
PE
73 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
74 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
75 it as a large positive number.
76 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
77 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
78
a66ff6d8
PE
79 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
80 in case result does not fit in int.
81
aca216ff
PE
82 * print.c (float_to_string): Detect width overflow more reliably.
83 (print_object): Make sprintf buffer a bit bigger, to avoid potential
84 buffer overrun. Don't assume list length fits in 'int'. Treat
85 print length of 0 as 0, not as infinity; to be consistent with other
86 uses of print length in this function. Don't overflow print length
87 index. Don't assume hash table size fits in 'long', or that
88 vectorlike size fits in 'unsigned long'.
89
31c286f7
PE
90 * process.c (make_process): Use printmax_t, not int, to format
91 process-name gensyms.
92
80f2e268
PE
93 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
94 to avoid potential buffer overrun.
95
670741ab
PE
96 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
97 if X resource line is longer than 512 bytes.
98
b7163a50
PE
99 * xfns.c (x_window): Make sprintf buffer a bit bigger
100 to avoid potential buffer overrun.
101
ae58ff1f 102 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
e91caa60
PE
103 (x_term_init): Use sprintf, not snprintf, so that we need not
104 worry about ancient hosts that lack snprintf. The buffer cannot
105 possibly be overrun, so this is safe.
ae58ff1f 106
c43c8a6a
PE
107 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
108
6e20a0d4
CY
1092011-08-30 Chong Yidong <cyd@stupidchicken.com>
110
111 * syntax.c (find_defun_start): Update all cache variables if
112 exiting early (Bug#9401).
113
148ae00e
EZ
1142011-08-30 Eli Zaretskii <eliz@gnu.org>
115
f6cfbd8f
EZ
116 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
117
148ae00e
EZ
118 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
119 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
120 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
121
122 * term.c (tty_append_glyph): New function.
123 (produce_stretch_glyph): Static function and its prototype deleted.
124
125 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
126 prototypes.
127
c4a07a4c
PE
1282011-08-29 Paul Eggert <eggert@cs.ucla.edu>
129
130 * image.c (parse_image_spec): Check for nonnegative, not for positive,
131 when checking :margin (Bug#9390).
132 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
133 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
134 so that the name doesn't mislead. All uses changed.
135
6bc8cd65
JB
1362011-08-28 Johan Bockgård <bojohan@gnu.org>
137
138 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
139 set_tty_hooks.
140
dca4927e
EZ
1412011-08-27 Eli Zaretskii <eliz@gnu.org>
142
143 * xdisp.c (move_it_to): Don't bail out early when reaching
144 position beyond to_charpos, if we are scanning backwards.
145 (move_it_vertically_backward): When DY == 0, make sure we get to
146 the first character in the line after the newline.
147
f2cad773
PE
1482011-08-27 Paul Eggert <eggert@cs.ucla.edu>
149
150 * ccl.c: Improve and simplify overflow checking (Bug#9196).
151 (ccl_driver): Do not generate an out-of-range pointer.
152 (Fccl_execute_on_string): Remove unnecessary check for
153 integer overflow, noted by Stefan Monnier in
154 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
155 Remove a FIXME that didn't need fixing.
156 Simplify the newly-introduced buffer reallocation code.
157
0cae2cdb
JB
1582011-08-27 Juanma Barranquero <lekktu@gmail.com>
159
160 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
161
5fc295a4 1622011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 163
70c60eb2 164 Integer and memory overflow issues (Bug#9196).
726e0ab1 165
d31850da
PE
166 * doc.c (get_doc_string): Rework so that
167 get_doc_string_buffer_size is the actual buffer size, rather than
168 being 1 less than the actual buffer size; this makes xpalloc more
169 convenient.
170
a69fbedb
PE
171 * image.c (x_allocate_bitmap_record, cache_image):
172 * xselect.c (Fx_register_dnd_atom):
173 Simplify previous changes by using xpalloc.
174
fe5c5d37
PE
175 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
176 since either will do and ptrdiff_t is convenient with xpalloc.
177
0065d054
PE
178 * charset.c (charset_table_size)
179 (struct charset_sort_data.priority): Now ptrdiff_t.
180 (charset_compare): Don't overflow if priorities differ greatly.
181 (Fsort_charsets): Don't assume list length fits in int.
182 Check for size-calculation overflow when allocating sort data.
183 (syms_of_charset): Allocate an initial charset table that is
184 just under 64 KiB, to avoid problems with glibc malloc and mmap.
185
186 * cmds.c (internal_self_insert): Check for size-calculation overflow.
187
188 * composite.h (struct composition.glyph_len): Now int, not unsigned.
189 The actual value is always <= INT_MAX, and leaving it unsigned made
190 overflow checking harder.
191
192 * dispextern.h (struct glyph_matrix.rows_allocated)
193 (struct face_cache.size): Now ptrdiff_t, for convenience in use
194 with xpalloc. The values are still always <= INT_MAX.
195
196 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
197
198 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
199 (SAFE_NALLOCA): New macro.
200
201 * region-cache.c (struct boundary.pos, find_cache_boundary)
202 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
203 (set_cache_region, invalidate_region_cache)
204 (revalidate_region_cache, know_region_cache, region_cache_forward)
205 (region_cache_backward, pp_cache):
206 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
207 so that ptrdiff_t * can be passed to xpalloc.
208 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
209 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
210 (pp_cache): Don't assume cache_len fits in int.
211 * region-cache.h: Adjust extern decls to match.
212
213 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
214 EMACS_INT, since either will do, for xpalloc.
215
216 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
217 (xnmalloc, xnrealloc, xpalloc): New functions.
218
726e0ab1
PE
219 * bidi.c (bidi_shelve_header_size): New constant.
220 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
221 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
222
51f30bc5 223 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
224 * buffer.c (overlays_at, overlays_in, record_overlay_string)
225 (overlay_strings):
226 Don't update size of array until after memory allocation succeeds,
227 because xmalloc/xrealloc may not return.
0065d054
PE
228 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
229 now that we have proper integer overflow checking.
230 (record_overlay_string, overlay_strings): Catch overflows when
231 calculating size of overlay_str_buf.
726e0ab1 232
0065d054
PE
233 * callproc.c (Fcall_process): Check for size overflow when
234 calculating size of args2.
235 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
236 Normally we prefer signed values, but sticking with ptrdiff_t would
237 require adding more-complicated checks.
726e0ab1
PE
238
239 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
240 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
241 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 242 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
243
244 * character.c (Fstring): Check for size-calculation overflow.
245
246 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
247 unnecessary integer overflow. Check for size overflow.
248 (encode_coding_object): Don't update size until xmalloc succeeds.
249
250 * composite.c (get_composition_id): Check for overflow in glyph
251 length calculations.
252
253 Integer and memory overflow fixes for display code.
254 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
255 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
256 (scrolling_window): Check for overflow in size calculations.
257 (line_draw_cost, realloc_glyph_pool, add_row_entry):
258 Don't assume glyph table len fits in int.
259 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
260 (row_table_size): Now ptrdiff_t, not int.
261 (scrolling_window): Avoid overflow in size calculations.
262 Don't update size until allocation succeeds.
263 * fns.c (concat): Check for overflow in size calculations.
264 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
265 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
266 (NEXT_ALMOST_PRIME_LIMIT): New constant.
267
268 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
269 (get_doc_string): Check for size calculation overflow.
270 Don't update size until allocation succeeds.
271 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
272 EMACS_INT, where ptrdiff_t will do.
273 (Fsubstitute_command_keys): Check for string overflow.
274
275 * editfns.c (set_time_zone_rule): Don't assume environment length
276 fits in int.
277 (message_length): Now ptrdiff_t, not int.
278 (Fmessage_box): Don't update size until allocation succeeds.
279 Don't assume message length fits in int.
280 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
281
0065d054
PE
282 * emacs.c (main): Do not reallocate argv, since there is a null at
283 the end that can be overwritten, and this way there's no need to
284 worry about size-calculation overflow.
285 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
286
287 * eval.c (init_eval_once, grow_specpdl): Don't update size until
288 alloc succeeds.
289 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
290
291 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
292 (x_set_scroll_bar_width, x_figure_window_size):
293 Check for integer overflow.
294 (x_set_alpha): Do not assume XINT fits in int.
295
296 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
297 This is for the members text_lines, text_cols, total_lines, total_cols,
298 where the system imposes an 'int' limit.
299
300 * fringe.c (Fdefine_fringe_bitmap):
301 Don't update size until alloc works.
302
303 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
304 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
305
306 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
307 Check for size-calculation overflow.
308 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
309 do, as we prefer signed integers.
310 (id_to_widget.max_size, id_to_widget.used)
311 (xg_store_widget_in_map, xg_remove_widget_from_map)
312 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
313 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
314 Use and return ptrdiff_t, not int.
315 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
316 * gtkutil.h: Change prototypes to match the above.
317
318 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
319 are duplicate now that they've been promoted to lisp.h.
320 (x_allocate_bitmap_record, x_alloc_image_color)
321 (make_image_cache, cache_image, xpm_load):
322 Don't update size until alloc is done.
323 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
324 (x_detect_edges):
3256efce 325 Check for size calculation overflow.
726e0ab1
PE
326 (ct_colors_allocated_max): New constant.
327 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
328 overflow.
3256efce 329
726e0ab1
PE
330 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
331 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
332 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
333 Use ptrdiff_t, not int, to count maps.
334 (read_char_minibuf_menu_prompt): Check for overflow in size
335 calculations. Don't update size until allocation succeeds. Redo
336 calculations to avoid overflow.
337 * keyboard.h: Change prototypes to match the above.
338
339 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
340 to count maps.
341 (current_minor_maps): Check for size calculation overflow.
342 * keymap.h: Change prototypes to match the above.
343
344 * lread.c (read1, init_obarray): Don't update size until alloc done.
345
346 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
347 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
348
726e0ab1
PE
349 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
350 Now ptrdiff_t, not int.
351 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
352 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
353
354 * process.c (Fnetwork_interface_list): Check for overflow
355 in size calculation.
356
357 * region-cache.c (move_cache_gap): Check for size calculation overflow.
358
359 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
360 overflow. Don't bother calling xmalloc when xrealloc will do.
361
362 * search.c (Freplace_match): Check for size calculation overflow.
363 (Fset_match_data): Don't assume list lengths fit in 'int'.
364
365 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
366 for command line length. Do not attempt to address one before the
367 beginning of an array, as that's not portable.
368
369 * term.c (max_frame_lines): Remove; unused.
370 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
371 not int.
372 (encode_terminal_code, calculate_costs): Check for size
373 calculation overflow.
374 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
375 table lengths and related sizes. Don't update size until alloc
376 done. Redo calculations to avoid overflow.
377 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
378
379 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
380 subtracting pointers.
381 (gobble_line): Check for overflow more carefully. Don't update size
382 until alloc done.
383
384 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
385 Don't update size until alloc done.
386 Redo size calculations to avoid overflow.
387 Check for size calculation overflow.
0065d054 388 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
389
390 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
391 Use ptrdiff_t, not int, for sizes.
392 (store_mode_line_noprop_char): Don't update size until alloc done.
393
0065d054
PE
394 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
395 Use ptrdiff_t, not int, for sizes.
396 (Finternal_make_lisp_face, cache_face):
397 Check for size calculation overflow.
398 (cache_face): Treat size calculation overflows as if they were
399 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
400
401 * xfns.c (x_encode_text, x_set_name_internal)
402 (Fx_change_window_property): Use ptrdiff_t, not int, to count
403 sizes, since they can exceed INT_MAX in size. Check for size
404 calculation overflow.
405
0065d054
PE
406 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
407 (xg_select): Check for size calculation overflow.
726e0ab1
PE
408 Don't update size until alloc done.
409
0065d054 410 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 411 as sprintf is limited to int lengths.
1d526e2f 412
252c5ee1
PE
413 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
414 (X_LONG_MIN): New macros.
864d7ce7
PE
415 Use them to make the following changes clearer.
416 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
417 This change doesn't affect the value now, but it may help remind
418 future maintainers not to raise the value too much later.
419 (SELECTION_QUANTUM): Remove, replacing with ...
420 (selection_quantum): ... new function, which avoids overflow.
421 All uses changed.
422 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
423 assumption that selection length fits in 'int'.
424 (x_reply_selection_request, x_handle_selection_request)
425 (x_get_window_property, receive_incremental_selection)
426 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
427 (lisp_data_to_selection_data, clean_local_selection_data):
428 Use ptrdiff_t, not int, to record length of selection.
429 (x_reply_selection_request, x_get_window_property)
430 (receive_incremental_selection, x_property_data_to_lisp):
431 Redo calculations to avoid overflow.
432 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 433 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
434 something.
435 (x_get_window_property, receive_incremental_selection)
436 (lisp_data_to_selection_data, x_property_data_to_lisp):
437 Check for size-calculation overflow.
438 (x_get_window_property, receive_incremental_selection)
439 (lisp_data_to_selection_data, Fx_register_dnd_atom):
440 Don't store size until memory allocation succeeds.
441 (x_get_window_property): Plug memory leak on memory exhaustion.
442 Don't double-block input; malloc is safe here. Don't assume 2**34
443 - 4 fits in unsigned long. Add an xassert to check
444 XGetWindowProperty overflow. Be more careful about overflow
445 calculations, and distinguish size from memory overflow better.
446 (receive_incremental_selection): When tracing, don't assume
447 unsigned int is less than INT_MAX.
448 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
449 harmful) conversions of unsigned short to int.
450 (lisp_data_to_selection_data): Don't assume that integers
451 in the range -65535 through -1 fit in an X unsigned short.
452 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
453 result parameters unless successful. Rely on cons_to_unsigned
454 to report problems with elements; the old code wasn't right anyway.
455 (x_check_property_data): Check for int overflow; we cannot use
456 a wider type due to X limits.
457 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
458
726e0ab1 459 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 460
0065d054
PE
461 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
462 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
463 (x_color_cells): Don't store size until memory allocation succeeds.
464 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 465 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
466 (x_term_init): Don't assume length fits in int (sprintf is limited
467 to int size).
bc18e09d 468
ebfa62c0
PE
469 Use ptrdiff_t for composition IDs.
470 * character.c (lisp_string_width):
471 * composite.c (composition_table_size, n_compositions)
472 (get_composition_id, composition_gstring_from_id):
473 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
474 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
475 * window.c (Frecenter):
476 Use ptrdiff_t, not int, for composition IDs.
477 * composite.c (get_composition_id): Check for integer overflow.
478 * composite.h: Adjust prototypes to match the above changes.
479
d3411f89
PE
480 Use ptrdiff_t for hash table indexes.
481 * category.c (hash_get_category_set):
482 * ccl.c (ccl_driver):
483 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
484 * coding.c (coding_system_charset_list, detect_coding_system):
485 * coding.h (struct coding_system.id):
486 * composite.c (get_composition_id, gstring_lookup_cache):
487 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
488 * image.c (xpm_get_color_table_h):
489 * lisp.h (hash_lookup, hash_put):
490 * minibuf.c (Ftest_completion):
491 Use ptrdiff_t for hash table indexes, not int (which is too
492 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
493 32-bit --with-wide-int hosts).
494
e097a6fa
PE
495 * charset.c (Fdefine_charset_internal): Check for integer overflow.
496 Add a FIXME comment about memory leaks.
497 (syms_of_charset): Don't assume xmalloc returns.
498
5637687f
PE
499 Don't assume that stated character widths fit in int.
500 * character.c (Fchar_width, c_string_width, lisp_string_width):
501 * character.h (CHAR_WIDTH):
502 * indent.c (MULTIBYTE_BYTES_WIDTH):
503 Use sanitize_char_width to avoid undefined and/or bad behavior
504 with outlandish widths.
505 * character.h (sanitize_tab_width): Renamed from sanitize_width,
506 now that we have two such functions. All uses changed.
507 (sanitize_char_width): New inline function.
508
a2271ba2
PE
509 Don't assume that tab-width fits in int.
510 * character.h (sanitize_width): New inline function.
511 (SANE_TAB_WIDTH): New macro.
512 (ASCII_CHAR_WIDTH): Use it.
513 * indent.c (sane_tab_width): Remove. All uses replaced by
514 SANE_TAB_WIDTH (current_buffer).
515 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
516
18c52557
PE
517 * fileio.c: Integer overflow issues with file modes.
518 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
519
caeeedc1
PE
520 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
521 Remove unreachable code.
522 (read_hex, load_charset_map_from_file): Check for integer overflow.
523
50849c52
PE
524 * xterm.c: don't go over XClientMessageEvent limit
525 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
526 (x_send_scroll_bar_event): Likewise. Check that the size does not
527 exceed limits imposed by XClientMessageEvent, as well as the usual
528 ptrdiff_t and size_t limits.
529
b13995db
PE
530 * keyboard.c: Overflow, signedness and related fixes.
531 (make_lispy_movement): Use same integer type in forward decl
532 that is used in the definition.
533 (read_key_sequence, keyremap_step):
534 Change bufsize argument back to int, undoing my 2011-03-30 change.
535 We prefer signed types, and int is wide enough here.
536 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
537 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
538 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
539 length, not size_t. Use ptrdiff_t for index, not int.
540 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
541 possibility of integer overflow.
542
13464394
PE
543 Overflow, signedness and related fixes for images.
544
545 * dispextern.h (struct it.stack[0].u.image.image_id)
546 (struct_it.image_id, struct image.id, struct image_cache.size)
547 (struct image_cache.used, struct image_cache.ref_count):
548 * gtkutil.c (update_frame_tool_bar):
549 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
550 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
551 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
552 * nsmenu.m (update_frame_tool_bar):
553 * xdisp.c (calc_pixel_width_or_height):
554 * xfns.c (image_cache_refcount):
555 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
556 on typical 64-bit hosts.
557
558 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
559 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
560 Omit unnecessary casts to int.
561 (parse_image_spec): Check that integers fall into 'int' range
562 when the callers expect that.
563 (image_ascent): Redo ascent calculation to avoid int overflow.
564 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
565 (lookup_image): Remove unnecessary tests.
566 (xbm_image_p): Locals are now of int, not EMACS_INT,
567 since parse_image_check makes sure they fit into int.
568 (png_load, gif_load, svg_load_image):
569 Prefer int to unsigned where either will do.
570 (tiff_handler): New function, combining the cores of the
571 old tiff_error_handler and tiff_warning_handler. This
572 function is rewritten to use vsnprintf and thereby avoid
573 stack buffer overflows. It uses only the features of vsnprintf
574 that are common to both POSIX and native Microsoft.
575 (tiff_error_handler, tiff_warning_handler): Use it.
576 (tiff_load, gif_load, imagemagick_load_image):
577 Don't assume :index value fits in 'int'.
578 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
579 (imagemagick_load_image): Check that crop parameters fit into
580 the integer types that MagickCropImage accepts. Don't assume
581 Vimagemagick_render_type has a nonnegative value. Don't assume
582 size_t fits in 'long'.
583 (gs_load): Use printmax_t to print the widest integers possible.
584 Check for integer overflow when computing image height and width.
585
c11821d4
EZ
5862011-08-26 Eli Zaretskii <eliz@gnu.org>
587
588 * xdisp.c (redisplay_window): Don't force window start if point
589 will be invisible in the resulting window. (Bug#9324)
590
0c95fcf7
EZ
5912011-08-25 Eli Zaretskii <eliz@gnu.org>
592
593 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
594 the display spec is of the form `(space ...)'.
595 (handle_display_spec): Return the value returned by
596 handle_single_display_spec, not just 1 or zero.
597 (handle_single_display_spec): If the display spec is of the form
598 `(space ...)', and specifies display in the text area, return 2
599 rather than 1.
fee65a97 600 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
601 accurately, and prefer exact match for point under bidi. Don't
602 advance `row' beyond the last row of the window.
0c95fcf7
EZ
603
604 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
605 into disp_prop; all users changed.
606
607 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
608 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
609 for the text covered by the display property.
610
e4ed06f1
CY
6112011-08-25 Chong Yidong <cyd@stupidchicken.com>
612
613 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
614 Change return value to nil.
615 (Frecord_buffer): Delete unused function.
616
f67cdd7f
EZ
6172011-08-24 Eli Zaretskii <eliz@gnu.org>
618
5980d4c6
EZ
619 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
620 buffers, return left-to-right.
8610fe8b
EZ
621 (set_cursor_from_row): Consider candidate row a win if its glyph
622 represents a newline and point is on that newline. Fixes cursor
623 positioning on the newline at EOL of R2L text within L2R
624 paragraph, and vice versa.
625 (try_cursor_movement): Check continued rows, in addition to
626 continuation rows. Fixes unwarranted scroll when point enters a
627 continued line of R2L text within an L2R paragraph, or vice versa.
628 (cursor_row_p): Consider the case of point being equal to
629 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
630 from the end of a short line to the beginning of a continued line
631 of R2L text within L2R paragraph.
632 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
633 composed characters.
5980d4c6 634
f67cdd7f
EZ
635 * bidi.c (bidi_check_type): Use xassert.
636 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
637 members.
638
bca633fb
EZ
6392011-08-23 Eli Zaretskii <eliz@gnu.org>
640
641 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
642 a character.
643
4a5885a7
CY
6442011-08-23 Chong Yidong <cyd@stupidchicken.com>
645
646 * nsfont.m (ns_otf_to_script): Fix typo.
647
0902a04e
KH
6482011-08-22 Kenichi Handa <handa@m17n.org>
649
650 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
651 extra slot even if the purpose is char-code-property-table.
652
1a2e6670
EZ
6532011-08-23 Eli Zaretskii <eliz@gnu.org>
654
8ddde651
EZ
655 * xdisp.c (redisplay_window): When computing centering_position,
656 account for the height of the header line. (Bug#8874)
657
425cc014
EZ
658 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
659 instead of CHAR_TO_BYTE. Fixes a crash when a completion
660 candidate is selected by the mouse, and that candidate has a
661 composed character under the mouse.
662
1a2e6670
EZ
663 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
664 coordinates reported by pos-visible-in-window-p for a composed
665 character in column zero.
666
8b76d6f8
SM
6672011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
668
669 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
670
dac347dd
EZ
6712011-08-22 Eli Zaretskii <eliz@gnu.org>
672
673 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
674 consider it a hit if to_charpos is anywhere in the range of the
675 composed buffer positions.
676
e013fb34
CY
6772011-08-22 Chong Yidong <cyd@stupidchicken.com>
678
679 * image.c (gif_load): Don't assume that each subimage has the same
680 dimensions as the base image. Handle disposal method that is
681 "undefined" by the gif spec (Bug#9335).
682
bd1ba3e8
CY
6832011-08-20 Chong Yidong <cyd@stupidchicken.com>
684
685 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 686 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 687
54a1215b
EZ
6882011-08-19 Eli Zaretskii <eliz@gnu.org>
689
823564e5
EZ
690 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
691 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
692 from an Org mode buffer to a Speedbar frame.
693
54a1215b
EZ
694 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
695 a composition, take its buffer position from IT->cmp_it.charpos.
696 Fixes cursor positioning at the beginning of a line that begins
697 with a composed character.
698
9778ebcc
EZ
6992011-08-18 Eli Zaretskii <eliz@gnu.org>
700
0be6ee06
EZ
701 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
702 character bidirectional type, use STRONG_L instead. Fixes crashes
703 in a buffer produced by `describe-categories'.
704
9778ebcc
EZ
705 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
706 members before the level stack, so they would be saved and
707 restored when copying iterator state. Fixes incorrect reordering
708 around TABs covered by display properties.
709
156bffbe
AS
7102011-08-18 Andreas Schwab <schwab@linux-m68k.org>
711
712 * process.c (Fnetwork_interface_list): Correctly determine buffer
713 size.
714
72ad093b
CY
7152011-08-17 Chong Yidong <cyd@stupidchicken.com>
716
717 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
718 (internal_condition_case_2, internal_condition_case_n):
719 Remove unnecessary aborts (Bug#9081).
72ad093b 720
35774242
EZ
7212011-08-17 Eli Zaretskii <eliz@gnu.org>
722
723 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
724 has no `load' handler, try opening the file locally. (Bug#9311)
725
db76dd85
KB
7262011-08-16 Ken Brown <kbrown@cornell.edu>
727
728 * gmalloc.c: Expand comment.
729
b215eee5
EZ
7302011-08-16 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
733 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
734
a4579d33
KB
7352011-08-16 Ken Brown <kbrown@cornell.edu>
736
737 Fix memory allocation problems in Cygwin build (Bug#9273).
738
739 * unexcw.c ( __malloc_initialized): Declare external variable.
740 (fixup_executable): Force the dumped emacs to reinitialize malloc.
741
8b76d6f8
SM
742 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
743 New variables.
a4579d33
KB
744 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
745 dumped emacs.
746 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
747 in the static heap.
748 [CYGWIN] (special_realloc): New function.
749 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
750 requests to realloc storage in the static heap.
751
3ebec551
PE
7522011-08-15 Paul Eggert <eggert@cs.ucla.edu>
753
754 * bidi.c (bidi_initialize): Remove unused local.
755
9fd8be00
EZ
7562011-08-15 Eli Zaretskii <eliz@gnu.org>
757
474a8465
EZ
758 * biditype.h: File removed.
759
760 * bidimirror.h: File removed.
761
762 * deps.mk (bidi.o): Remove biditype.h and
763 bidimirror.h.
764
765 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
766 bidimirror.h.
767
768 * dispextern.h: Fix a typo in the comment to bidi_type_t.
769
770 * chartab.c: Improve commentary for the uniprop_table API.
771
32413314
EZ
772 * bidi.c (bidi_paragraph_init): Support zero value of
773 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
774 (bidi_initialize): Use uniprop_table instead of including
775 biditype.h and bidimirror.h.
32413314 776
9fd8be00
EZ
777 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
778 coordinates of the iterator when restoring from ppos_it.
779 (Bug#9296)
780
5cf2b69b
KH
7812011-08-14 Kenichi Handa <handa@m17n.org>
782
783 * process.c (create_process): Call setup_process_coding_systems
72ad093b 784 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 785
daf17d00
EZ
7862011-08-14 Eli Zaretskii <eliz@gnu.org>
787
788 * xdisp.c (move_it_in_display_line_to): Don't invoke
789 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
790 ppos_it. Fixes vertical cursor motion when line beginning is
791 covered by an image. (Bug#9296)
792
08e3161a
JD
7932011-08-14 Jan Djärv <jan.h.d@swipnet.se>
794
795 * nsterm.h (ns_run_ascript): Declare.
796 (NSAPP_DATA2_RUNASSCRIPT): Define.
797
798 * nsfns.m (as_script, as_result, as_status): New static variables.
799 (ns_run_ascript): New function.
800 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
801 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
802 the event loop. Get status from as_status (Bug#7276).
803
804 * nsterm.m (sendEvent): If event is NSApplicationDefined and
805 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
806 the event loop (Bug#7276).
807
a3720aa2
AS
8082011-08-14 Andreas Schwab <schwab@linux-m68k.org>
809
810 * gnutls.c (QCgnutls_bootprop_priority)
811 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
812 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
813 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
814 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
815 (QCgnutls_bootprop_verify_hostname_error)
816 (QCgnutls_bootprop_callbacks_verify): Rename from
817 Qgnutls_bootprop_..., all uses changed.
818
819 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
820 uses changed.
821
0a0d27fb
PE
8222011-08-14 Paul Eggert <eggert@cs.ucla.edu>
823
19d5c50c
PE
824 * xfaces.c (Qframe_set_background_mode): Now static.
825 * dispextern.h (Qframe_set_background_mode): Remove decl.
826
0a0d27fb
PE
827 * process.c (Fnetwork_interface_info): Declare local only if needed.
828
377538cb
JD
8292011-08-13 Jan Djärv <jan.h.d@swipnet.se>
830
831 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
832 (Fnetwork_interface_list): Allocate in increments of bytes instead
833 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
834 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
835 sockaddr.
836 (struct ifflag_def): notrailers is smart on OSX.
837 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
838 Get hardware address with getifaddrs if available.
839
08fff70c
EZ
8402011-08-12 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (iterate_out_of_display_property): xassert that
843 IT->position is set to within IT->object's boundaries. Break from
844 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
845 when IT->position is set up wrongly due to some bug.
846 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
847 (push_display_prop): Allow GET_FROM_STRING as IT->method on
848 entry. Force push_it to save on the stack the current
849 buffer/string position, to be restored by pop_it. Fix flags in
850 the iterator structure wrt the object coming from a display
851 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
852 properties. (Bug#9284)
853
7be1c708 8542011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 855
7be1c708
CY
856 * fontset.c (fontset_get_font_group): Add proper type checks.
857 (Bug#9172)
aac0c6e3 858
7be1c708 8592011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 860
7be1c708
CY
861 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
862 and LC_VERSION_MIN_MACOSX.
863 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
864 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 865
97bb72a6
EZ
8662011-08-08 Eli Zaretskii <eliz@gnu.org>
867
868 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
869 no-display-properties-and-no-overlays under bidi display.
870 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 871 properties and overlays.
97bb72a6 872
d5617611
CY
8732011-08-08 Chong Yidong <cyd@stupidchicken.com>
874
37e11a63
CY
875 * editfns.c (Fset_time_zone_rule): Document relationship with the
876 setenv function.
877
d5617611
CY
878 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
879 the font entity extracted from the cache (Bug#8109).
880
58872834
CY
8812011-08-07 Chong Yidong <cyd@stupidchicken.com>
882
883 * composite.c (autocmp_chars): Don't reset point. That is done by
884 restore_point_unwind (Bug#5984).
885
75bfc667
JL
8862011-08-07 Juri Linkov <juri@jurta.org>
887
888 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
889 to show the arg `TIME' instead of `TIMEVAL'.
890
d1410150
EZ
8912011-08-06 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
894 display property strides EOL and includes a newline, as in
895 longlines-mode. (Bug#9254)
75b771e4
EZ
896 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
897 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
898
899 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
900 is non-zero, even if the data buffer is NULL. Fixes a crash in
901 vertical-motion with longlines-mode. (Bug#9254)
902
35928349
EZ
9032011-08-05 Eli Zaretskii <eliz@gnu.org>
904
ec7cc85b
EZ
905 * bidi.c <bidi_cache_total_alloc>: Now static.
906 (bidi_initialize): Initialize bidi_cache_total_alloc.
907
8b76d6f8 908 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
909 cache. (Bug#9221)
910
911 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
912 amount allocated this far in `bidi_cache_total_alloc'.
913 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
914 non-zero, only free the data buffer without restoring the cache
915 contents. All callers changed.
916
917 * dispextern.h (bidi_unshelve_cache): Update prototype.
918
919 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
920 (move_it_in_display_line, move_it_to)
921 (move_it_vertically_backward, move_it_by_lines): Replace the call
922 to xfree to an equivalent call to bidi_unshelve_cache.
923 (move_it_in_display_line_to): Fix logic of returning
412b6358 924 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 925
e2e2423b
EZ
9262011-08-05 Eli Zaretskii <eliz@gnu.org>
927
928 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
929 came from a string character with a `cursor' property. (Bug#9229)
930
ae9e757a
JD
9312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
932
933 * Makefile.in (LIB_PTHREAD): New variable.
934 (LIBES): Add LIB_PTHREAD (Bug#9216).
935
936 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
937 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
938
213bd7f2
AS
9392011-08-04 Andreas Schwab <schwab@linux-m68k.org>
940
941 * regex.c (re_iswctype): Remove some redundant boolean
942 conversions.
943
99aaf75f
JD
9442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
945
946 * xterm.c (x_find_topmost_parent): New function.
947 (x_set_frame_alpha): Find topmost parent window with
948 x_find_topmost_parent and set the property there also (bug#9181).
949 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
950
c74e9d86
PE
9512011-08-04 Paul Eggert <eggert@cs.ucla.edu>
952
953 * callproc.c (Fcall_process): Avoid vfork clobbering
954 the local vars buffer, coding_systems, current_dir.
955
640c8776
SM
9562011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
957
958 * keymap.c (Fmake_composed_keymap): Move to subr.el.
959
f26d0e4c
PE
9602011-08-03 Paul Eggert <eggert@cs.ucla.edu>
961
8a10d76c
PE
962 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
963 so that it is not optimized away.
964
f26d0e4c
PE
965 * xdisp.c (compute_display_string_pos): Remove unused local.
966
55439c61
EZ
9672011-08-02 Eli Zaretskii <eliz@gnu.org>
968
969 Fix slow cursor motion and scrolling in large buffers with
970 selective display, like Org Mode buffers. (Bug#9218)
971
972 * dispextern.h (struct bidi_it): New member disp_prop_p.
973
974 * xdisp.c: Remove one-slot cache of display string positions.
975 (compute_display_string_pos): Accept an additional argument
976 DISP_PROP_P; callers changed. Scan at most 5K characters forward
977 for a display string or property. If found, set DISP_PROP_P
978 non-zero.
979
980 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
981 DISP_PROP_P, and pass it to compute_display_string_pos.
982 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
983 non-zero. All callers of bidi_fetch_char changed.
984
fb33fa43
SM
9852011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
986
987 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
988
b099e063
DM
9892010-12-03 Don March <don@ohspite.net>
990
991 * keymap.c (Fdefine_key): Fix non-prefix key error message when
992 last character M-[char] is translated to ESC [char] (bug#7541).
993
5cc7f7af
KH
9942011-08-02 Kenichi Handa <handa@m17n.org>
995
d0fffa3f 996 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
997
998 * chartab.c (uniprop_table): Make it non-static.
999
525d5e6e
EZ
10002011-08-01 Eli Zaretskii <eliz@gnu.org>
1001
1002 * xdisp.c (forward_to_next_line_start): Accept additional argument
1003 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1004 on the newline.
1005 (reseat_at_next_visible_line_start): Use the bidi iterator state
1006 returned by forward_to_next_line_start to restore the state of
1007 it->bidi_it after backing up to previous newline. (Bug#9212)
1008
31011111
AS
10092011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1010
1011 * regex.c (re_comp): Protoize.
1012 (re_exec): Fix return type.
1013 (regexec): Fix type of `ret'. (Bug#9203)
1014
e5d76069
PE
10152011-07-29 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1018 This is needed if max-image-size is a floating-point number.
1019
9a79b20c
AS
10202011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1021
1022 * print.c (print_object): Print empty symbol as ##.
1023
1024 * lread.c (read1): Read ## as empty symbol.
1025
d8c2fa78
AA
10262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1027
1028 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1029 setting frame foreground color (Bug#9175).
1030 (x_set_background_color): Likewise.
1031
ffe57a7a
AA
1032 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1033 contents (Bug#9176).
1034 (EmacsTooltip -init): Remove bezels and add shadows to
1035 tooltip windows.
1036
bf3492a5
AA
1037 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1038 or scroll bar (Bug#8470).
1039
d55e9c53
AA
1040 * nsfont.m (nsfont_open): Remove assignment to voffset and
1041 unnecessary vars hshink, expand, hd, full_height, min_height.
1042 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1043
1044 * nsterm.h (nsfont_info): Remove voffset field.
1045
d8c2fa78 10462011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1047
1048 Implement strike-through and overline on NextStep (Bug#8863).
1049
1050 * nsfont.m (nsfont_open): Use underline position provided by font,
1051 instead of hard-coded value of 2.
1052 (nsfont_draw): Call ns_draw_text_decoration instead.
1053
1054 * nsterm.h: Add declaration for ns_draw_text_decoration.
1055
1056 * nsterm.m (ns_draw_text_decoration): New function for drawing
1057 underline, overline, and strike-through.
1058 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1059 ns_draw_text_decoration. Change treatment of cursor drawing to
1060 accomodate underlining, etc.
1061
4cc60b9b
EZ
10622011-07-28 Eli Zaretskii <eliz@gnu.org>
1063
bc7ece87
EZ
1064 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1065 default.
4cc60b9b 1066
476371c4
PE
10672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1068
66606eea
PE
1069 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1070 Without this fix, if a signal arrives just after memory fills up,
1071 'malloc' might be invoked reentrantly.
1072
476371c4
PE
1073 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1074 In other words, assume that every image size is allowed, on non-X
1075 hosts. This assumption is probably wrong, but it lets Emacs compile.
1076
f3fcc40d
AS
10772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1078
1079 * regex.c (re_iswctype): Convert return values to boolean.
1080
350c992f
EZ
10812011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1082
1083 * xdisp.c (compute_display_string_pos): Don't use cached display
1084 string position if the buffer had its restriction changed.
1085 (Bug#9184)
1086
5266b4bb
PE
10872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1090
2573a837 10912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1092
41f55ccd 1093 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1094
39e378da
PE
1095 * bidi.c: Integer size and overflow fixes.
1096 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1097 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1098 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1099 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1100 (bidi_find_other_level_edge):
1101 Use ptrdiff_t instead of EMACS_INT where either will do.
1102 This works better on 32-bit hosts configured --with-wide-int.
1103 (bidi_cache_ensure_space): Check for size-calculation overflow.
1104 Use % rather than repeated addition, for better worst-case speed.
1105 Don't set bidi_cache_size until after xrealloc returns, because it
1106 might not return.
1107 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1108 (bidi_cache_ensure_space): Also check that the bidi cache size
1109 does not exceed that of the largest Lisp string or buffer. See Eli
1110 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1111
5e927815
PE
1112 * alloc.c (__malloc_size_t): Remove.
1113 All uses replaced by size_t. See Andreas Schwab's note
1114 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1115
ca4aa935
PE
1116 * image.c: Improve checking for integer overflow.
1117 (check_image_size): Assume that f is nonnull, since
1118 it is always nonnull in practice. This is one less thing to
1119 worry about when checking for integer overflow later.
1120 (x_check_image_size): New function, which checks for integer
1121 overflow issues inside X.
1122 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1123 This removes the need for a memory_full check.
1124 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1125 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1126 (xbm_read_bitmap_data): Change locals back to 'int', since
1127 their values must fit in 'int'.
1128 (xpm_load_image, png_load, tiff_load):
1129 Invoke x_create_x_image_and_pixmap earlier,
1130 to avoid much needless work if the image is too large.
1131 (tiff_load): Treat overly large images as if
1132 x_create_x_image_and_pixmap failed, not as malloc failures.
1133 (gs_load): Use x_check_image_size.
1134
5f8f9cc2
PE
1135 * gtkutil.c: Omit integer casts.
1136 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1137 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1138
5adf60bc
PE
1139 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1140
c8907a93
PE
1141 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1142 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1143 would wrongly return t on a 64-bit host.
1144
e3c25c68
PE
1145 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1146 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1147 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1148 and therefore cause GCC to emit a bogus diagnostic in some cases.
1149
3f791afe
PE
1150 * image.c: Integer signedness and overflow and related fixes.
1151 This is not an exhaustive set of fixes, but it's time to
1152 record what I've got.
1153 (lookup_pixel_color, check_image_size): Remove redundant decls.
1154 (check_image_size): Don't assume that arbitrary EMACS_INT values
1155 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1156 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1157 (tiff_load, imagemagick_load_image):
1158 Check for overflow in size calculations.
1159 (x_create_x_image_and_pixmap): Remove unnecessary test for
1160 xmalloc returning NULL; that can't happen.
1161 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1162 (xpm_color_bucket): Use better integer hashing function.
1163 (xpm_cache_color): Don't possibly over-allocate memory.
1164 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1165 (gif_memory_source):
1166 Use ptrdiff_t, not int or size_t, to record sizes.
1167 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1168 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1169 either works, as we prefer signed integers.
1170 (tiff_read_from_memory, tiff_write_from_memory):
1171 Return tsize_t, not size_t, since that's what the TIFF API wants.
1172 (tiff_read_from_memory): Don't fail simply because the read would
1173 go past EOF; instead, return a short read.
1174 (tiff_load): Omit no-longer-needed casts.
1175 (Fimagemagick_types): Don't assume size fits into 'int'.
1176
3cc5a532
PE
1177 Improve hashing quality when configured --with-wide-int.
1178 * fns.c (hash_string): New function, taken from sxhash_string.
1179 Do not discard information about ASCII character case; this
1180 discarding is no longer needed.
1181 (sxhash-string): Use it. Change sig to match it. Caller changed.
1182 * lisp.h: Declare it.
1183 * lread.c (hash_string): Remove, since we now use fns.c's version.
1184 The fns.c version returns a wider integer if --with-wide-int is
1185 specified, so this should help the quality of the hashing a bit.
1186
b312a492
PE
1187 * emacs.c: Integer overflow minor fix.
1188 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1189 Define only if GNU_LINUX.
1190 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1191
dfd153ae
PE
1192 * dispnew.c: Integer signedness and overflow fixes.
1193 Remove unnecessary forward decls, that were a maintenance hassle.
1194 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1195 All uses changed.
1196 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1197 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1198 (prepare_desired_row, line_draw_cost):
1199 Use int, not unsigned, where either works.
1200 (save_current_matrix, restore_current_matrix):
1201 Use ptrdiff_t, not size_t, where either works.
1202 (init_display): Check for overflow more accurately, and without
1203 relying on undefined behavior.
1204
a81d11a3
PE
1205 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1206 Remove, replacing with the new symbols in lisp.h. All uses changed.
1207 * fileio.c (make_temp_name):
1208 * filelock.c (lock_file_1, lock_file):
1209 * xdisp.c (message_dolog):
1210 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1211 Use pMd etc. instead.
1212 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1213 replacing the pWIDE etc. symbols removed from editfns.c.
1214
3300e6fd
PE
1215 * keyboard.h (num_input_events): Now uintmax_t.
1216 This is (very slightly) less likely to mess up due to wraparound.
1217 All uses changed.
1218
fd05c7e9
PE
1219 * buffer.c: Integer signedness fixes.
1220 (alloc_buffer_text, enlarge_buffer_text):
1221 Use ptrdiff_t rather than size_t when either will do, as we prefer
1222 signed integers.
1223
903fe15d
PE
1224 * alloc.c: Integer signedness and overflow fixes.
1225 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1226 (__malloc_size_t): Default to size_t, not to int.
1227 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1228 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1229 Prefer ptrdiff_t to size_t when either would do, as we prefer
1230 signed integers.
1231 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1232 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1233 Now const. Initialize with values that are in range even if char
1234 is signed.
1235 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1236 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1237 These functions do the right thing with sizes > 2**32.
1238 (check_depth): Now ptrdiff_t, not int.
1239 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1240 Adjust to new way of storing sizes. Check for size overflow bugs
1241 in rest of code.
1242 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1243 slightly wrong anyway, as it missed one instance of
1244 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1245 (refill_memory_reserve): Omit needless cast to size_t.
1246 (mark_object_loop_halt): Mark as externally visible.
1247
ac82cc6a
PE
1248 * xselect.c: Integer signedness and overflow fixes.
1249 (Fx_register_dnd_atom, x_handle_dnd_message):
1250 Use ptrdiff_t, not size_t, since we prefer signed.
1251 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1252 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1253 x_dnd_atoms_size and x_dnd_atoms_length.
1254
c2d1e36d
PE
1255 * doprnt.c: Prefer signed to unsigned when either works.
1256 * eval.c (verror):
1257 * doprnt.c (doprnt):
1258 * lisp.h (doprnt):
1259 * xdisp.c (vmessage):
1260 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1261 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1262 prefer signed arithmetic to avoid comparison confusion.
1263 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1264 but is a bit tricky.
1265
0e926e56
PE
1266 Assume freestanding C89 headers, string.h, stdlib.h.
1267 * data.c, doprnt.c, floatfns.c, print.c:
1268 Include float.h unconditionally.
1269 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1270 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1271 * regex.c: Likewise for stddef.h, string.h.
1272 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1273 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1274 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1275 (STDC_HEADERS): Remove obsolete defines.
1276 * sysdep.c: Include limits.h unconditionally.
1277
9cfdb3ec
PE
1278 Assume support for memcmp, memcpy, memmove, memset.
1279 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1280 * regex.c (memcmp, memcpy):
1281 Remove; we assume C89 now.
1282
1283 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1284 (__malloc_safe_bcopy): Remove; no longer needed.
1285
cf950e6b 1286 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1287 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1288 well either way, and we prefer signed to unsigned.
1289
dbf38e02
LMI
12902011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1291
1292 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1293 closes the connection while we're reading (bug#9182).
1294
d6f0886c
JD
12952011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1296
1297 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1298 are specified (Bug#9168).
1299
2eb1f9e6
PE
13002011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1303 Found by GCC static checking and --with-wide-int on a 32-bit host.
1304
22381272 13052011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1306
1307 * xdisp.c (compute_display_string_pos): Fix logic of caching
1308 previous display string position. Initialize cached_prev_pos to
1309 -1. Fixes slow-down at the beginning of a buffer.
1310
f25e39b4
EZ
13112011-07-24 Eli Zaretskii <eliz@gnu.org>
1312
1313 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1314 for attrs[LFACE_FONTSET_INDEX].
1315
04c4b52e
PE
13162011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * xml.c (parse_region): Remove unused local
1319 that was recently introduced.
1320
c1734fbd
EZ
13212011-07-23 Eli Zaretskii <eliz@gnu.org>
1322
be18c5a5
EZ
1323 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1324 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1325
c1734fbd
EZ
1326 * xdisp.c (move_it_in_display_line_to): Record the best matching
1327 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1328 exit if none of the characters scanned was an exact match.
1329 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1330 when exact match is impossible due to invisible text, and the
1331 lines are truncated.
1332
a258d627
JD
13332011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1334
1335 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1336 for OSX >= 10.7.
1337
b6d5a689
EZ
13382011-07-22 Eli Zaretskii <eliz@gnu.org>
1339
0f74f785
EZ
1340 Fix a significant slow-down of cursor motion with C-n, C-p,
1341 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1342 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1343 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1344 (next_element_from_buffer): Call compute_stop_pos_backwards to
1345 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1346 base_level_stop.
1347 (reseat): Don't look for prev_stop, as that could mean a very long
1348 run.
1349 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1350 <cached_disp_overlay_modiff>: Cache for last found display string
1351 position.
551918c1 1352 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1353 about the same buffer in the same area of character positions, and
1354 the buffer wasn't changed since the time the display string
1355 position was cached.
551918c1 1356
b2d0c91a
EZ
13572011-07-22 Eli Zaretskii <eliz@gnu.org>
1358
1359 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1360 is an integer, which is important for empty lines. (Bug#9149)
1361
043604ee
CY
13622011-07-22 Chong Yidong <cyd@stupidchicken.com>
1363
1364 * frame.c (Fmodify_frame_parameters): In tty case, update the
1365 default face if necessary (Bug#4238).
1366
da4adb04
CY
13672011-07-21 Chong Yidong <cyd@stupidchicken.com>
1368
1369 * editfns.c (Fstring_to_char): No need to explain what a character
1370 is in the docstring (Bug#6576).
1371
9abd0532
LMI
13722011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1373
1374 * xml.c (parse_region): Make sure we always return a tree.
1375
36881d16
HK
13762011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1377
1378 * xml.c (parse_region): If a document contains only comments,
1379 return that, too.
1380
1e98674d
LMI
13812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1382
1383 * xml.c (make_dom): Return comments, too.
1384
590bd467
PE
13852011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 Port to OpenBSD.
1388 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1389 and the surrounding thread.
1390 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1391 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1392 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1393 timer goes off.
1394 * s/openbsd.h (BROKEN_SIGIO): Define.
1395 * unexelf.c (unexec) [__OpenBSD__]:
1396 Don't update the .mdebug section of the Alpha COFF symbol table.
1397
f41628b2
LMI
13982011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1399
1400 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1401 (bug#8460).
1402
b59b67c5
PE
14032011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1404
15e3a074
PE
1405 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1406 This fixes some race conditions on the permissions of any newly
1407 created file.
1408
41bed37d
PE
1409 * alloc.c (valid_pointer_p): Use pipe, not open.
1410 This fixes some permissions issues when debugging.
1411
b59b67c5
PE
1412 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1413 If fchown fails to set both uid and gid, try to set just gid,
1414 as that is sometimes allowed. Adjust the file's mode to eliminate
1415 setuid or setgid bits that are inappropriate if fchown fails.
1416
925a6be7
SM
14172011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1420 to compare Lisp_Objects.
1421 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1422 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1423 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1424
52968808
AS
14252011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1426
0a6a104b
AS
1427 * lread.c (read_integer): Unread even EOF character.
1428 (read1): Likewise. Properly record start position of symbol.
1429
52968808
AS
1430 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1431 symbol character follows.
1432
9e381cdd
PE
14332011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1436 This works around a problem with the previous change to Fcopy_file.
1437 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1438 and without this change, GCC might complain about discarding
1439 fchown's return value.
1440
b5641435
JB
14412011-07-16 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1444
a8031457
PE
14452011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1448
dd889327
LMI
14492011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1450
750c33f7
LMI
1451 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1452 it's used from the C level.
1453
dd889327
LMI
1454 * process.c: Use the same condition for POLL_FOR_INPUT in both
1455 keyboard.c and process.c (bug#1858).
1456
87e86684
LM
14572011-07-09 Lawrence Mitchell <wence@gmx.li>
1458
1459 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1460 (Fgnutls_boot): Use it.
1461
64348f40
AS
14622011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1463
1464 * doc.c (Fsubstitute_command_keys): Revert last change.
1465
1d698799
LMI
14662011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1467
f863868c
LMI
1468 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1469 quotes the next character, and doesn't affect other longer
1470 sequences (bug#8935).
1471
1d698799
LMI
1472 * lread.c (syms_of_lread): Clarify that is isn't only
1473 `eval-buffer' and `eval-defun' that's affected by
1474 `lexical-binding' (bug#8460).
1475
aa4b6df6
EZ
14762011-07-15 Eli Zaretskii <eliz@gnu.org>
1477
1478 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1479 bidi redisplay when a line includes both an image and is
1480 truncated.
1481
5d856da6
PE
14822011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1483
ad6042bb
PE
1484 Fix minor problems found by static checking.
1485 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1486 (elsz): Now a signed constant, not a size_t var. We prefer signed
1487 types to unsigned, to avoid integer comparison confusion. Without
1488 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1489 "cannot optimize loop, the loop counter may overflow", a symptom
1490 of the confusion.
f00bbb22 1491 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1492 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1493
6468f31c
LMI
14942011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1495
49080b10
LMI
1496 * search.c (Fre_search_backward): Mention `case-fold-search' in
1497 all the re_search_* functions (bug#8138).
1498
6468f31c
LMI
1499 * keyboard.c (Fopen_dribble_file): Document when the file is
1500 closed (bug#8056).
1501
c965adc5
EZ
15022011-07-14 Eli Zaretskii <eliz@gnu.org>
1503
df9733bf
EZ
1504 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1505 bidi_cache_idx.
1506
0bb23927
EZ
1507 Support bidi reordering of display and overlay strings.
1508 * xdisp.c (compute_display_string_pos)
1509 (compute_display_string_end): Accept additional argument STRING.
1510 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1511 (reseat_to_string): Initialize bidi_it->string.s and
1512 bidi_it->string.schars.
1513 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1514 NULL (avoids a crash in bidi_paragraph_init).
1515 Initialize itb.string.lstring.
0bb23927
EZ
1516 (init_iterator): Call bidi_init_it only of a valid
1517 buffer position was specified. Initialize paragraph_embedding to
1518 L2R.
1519 (reseat_to_string): Initialize the bidi iterator.
1520 (display_string): If we need to ignore text properties of
1521 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1522 original value of -1 will not work with bidi.)
1523 (compute_display_string_pos): First arg is now struct
1524 `text_pos *'; all callers changed. Support display properties on
1525 Lisp strings.
1526 (compute_display_string_end): Support display properties on Lisp
1527 strings.
1528 (init_iterator, reseat_1, reseat_to_string): Initialize the
1529 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1530 when iterating on a string not from display properties).
640c8776
SM
1531 (compute_display_string_pos, compute_display_string_end):
1532 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1533 arrow keys.
1534 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1535 base_level_stop; instead, set base_level_stop to BEGV.
1536 Fixes crashes in vertical-motion.
0bb23927
EZ
1537 (next_element_from_buffer): Improve commentary for when
1538 the iterator is before prev_stop.
1539 (init_iterator): Initialize bidi_p from the default value of
1540 bidi-display-reordering, not from buffer-local value. Use the
1541 buffer-local value only if initializing for buffer iteration.
1542 (handle_invisible_prop): Support invisible properties on strings
1543 that are being bidi-reordered.
1544 (set_iterator_to_next): Support bidi reordering of C strings and
1545 Lisp strings.
1546 (next_element_from_string): Support bidi reordering of Lisp
1547 strings.
1548 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1549 (display_string): Support display of R2L glyph rows.
1550 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1551 (init_iterator): Don't initialize it->bidi_p for strings
1552 here.
1553 (reseat_to_string): Initialize it->bidi_p for strings here.
1554 (next_element_from_string, next_element_from_c_string)
1555 (next_element_from_buffer): Add xassert's for correspondence
1556 between IT's object being iterated and it->bidi_it.string
1557 structure.
1558 (face_before_or_after_it_pos): Support bidi iteration.
1559 (next_element_from_c_string): Handle the case of the first string
1560 character that is not the first one in the visual order.
1561 (get_visually_first_element): New function, refactored from common
1562 parts of next_element_from_buffer, next_element_from_string, and
1563 next_element_from_c_string.
1564 (tool_bar_lines_needed, redisplay_tool_bar)
1565 (display_menu_bar): Force left-to-right direction. Add a FIXME
1566 comment for making that be controlled by a user option.
1567 (push_it, pop_it): Save and restore the state of the
1568 bidi iterator. Save and restore the bidi_p flag.
1569 (pop_it): Iterate out of display property for string iteration as
1570 well.
1571 (iterate_out_of_display_property): Support iteration over strings.
1572 (handle_single_display_spec): Set up it->bidi_it for iteration
1573 over a display string, and call bidi_init_it.
1574 (handle_single_display_spec, next_overlay_string)
1575 (get_overlay_strings_1, push_display_prop): Set up the bidi
1576 iterator for displaying display or overlay strings.
1577 (forward_to_next_line_start): Don't use the shortcut if
1578 bidi-iterating.
1579 (back_to_previous_visible_line_start): If handle_display_prop
1580 pushed the iterator stack, restore the internal state of the bidi
1581 iterator by calling bidi_pop_it same number of times.
1582 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1583 and we are bidi-iterating, don't decrement the iterator position;
1584 instead, set the first_elt flag in the bidi iterator, to produce
1585 the same effect.
1586 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1587 (push_display_prop): xassert that we are iterating a buffer.
1588 (push_it, pop_it): Save and restore paragraph_embedding member.
1589 (handle_single_display_spec, next_overlay_string)
1590 (get_overlay_strings_1, reseat_1, reseat_to_string)
1591 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1592 correctly. Don't assume unibyte strings are not bidi-reordered.
1593 (compute_display_string_pos)
1594 (compute_display_string_end): Fix handling the case of C string.
1595 (push_it, pop_it): Save and restore from_disp_prop_p.
1596 (handle_single_display_spec, push_display_prop): Set the
1597 from_disp_prop_p flag.
1598 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1599 (pop_it): Call iterate_out_of_display_property only if we are
1600 popping after iteration over a string that came from a display
1601 property. Fix a typo in popping stretch info. Add an assertion
1602 for verifying that the iterator position is in sync with the bidi
1603 iterator.
1604 (handle_single_display_spec, get_overlay_strings_1)
1605 (push_display_prop): Fix initialization of paragraph direction for
1606 string when that of the parent object is not yet determined.
1607 (reseat_1): Call bidi_init_it to resync the bidi
1608 iterator with IT's position. (Bug#7616)
1609 (find_row_edges): If ROW->start.pos gives position
1610 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1611 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1612 Reset the from_disp_prop_p flag.
1613 (SAVE_IT, RESTORE_IT): New macros.
1614 (pos_visible_p, face_before_or_after_it_pos)
1615 (back_to_previous_visible_line_start)
1616 (move_it_in_display_line_to, move_it_in_display_line)
1617 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1618 (try_scrolling, redisplay_window, display_line): Use them when
1619 saving a temporary copy of the iterator and restoring it back.
1620 (back_to_previous_visible_line_start, reseat_1)
1621 (init_iterator): Empty the bidi cache "stack".
1622 (move_it_in_display_line_to): If iterator ended up at
1623 EOL, but we never saw any buffer positions smaller than
1624 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1625 motion in bidi-reordered lines.
1626 (move_it_in_display_line_to): Record prev_method and prev_pos
1627 immediately before the call to set_iterator_to_next. Fixes cursor
1628 motion in bidi-reordered lines with stretch glyphs and strings
1629 displayed in margins. (Bug#8133) (Bug#8867)
1630 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1631 TO_CHARPOS.
640c8776
SM
1632 (pos_visible_p): Support positions in bidi-reordered lines.
1633 Save and restore bidi cache.
0bb23927
EZ
1634
1635 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1636 (bidi_paragraph_info): Delete unused struct.
1637 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1638 (bidi_cache_start): New variable.
1639 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1640 to zero.
1641 (bidi_cache_fetch_state, bidi_cache_search)
1642 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1643 (bidi_cache_find, bidi_peek_at_next_level)
1644 (bidi_level_of_next_char, bidi_find_other_level_edge)
1645 (bidi_move_to_visually_next): Compare cache index with
1646 bidi_cache_start rather than with zero.
1647 (bidi_fetch_char): Accept new argument STRING; all callers
1648 changed. Support iteration over a string. Support strings with
1649 display properties. Support unibyte strings. Fix the type of
1650 `len' according to what STRING_CHAR_AND_LENGTH expects.
1651 (bidi_paragraph_init, bidi_resolve_explicit_1)
1652 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1653 (bidi_level_of_next_char, bidi_move_to_visually_next):
1654 Support iteration over a string.
0bb23927
EZ
1655 (bidi_set_sor_type, bidi_resolve_explicit_1)
1656 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1657 can now be zero (for strings); special values 0 and -1 were
1658 changed to -1 and -2, respectively.
1659 (bidi_char_at_pos): New function.
1660 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1661 Call it instead of FETCH_MULTIBYTE_CHAR.
1662 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1663 initialized to valid values.
1664 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1665 values.
1666 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1667 the test for valid cached positions. Fix the logic for looking up
1668 the sentinel state in the cache. GCPRO the Lisp string we are
1669 iterating.
1670 (bidi_push_it, bidi_pop_it): New functions.
1671 (bidi_initialize): Initialize the bidi cache start stack pointer.
1672 (bidi_cache_ensure_space): New function, refactored from part of
1673 bidi_cache_iterator_state. Don't assume the required size is just
1674 one BIDI_CACHE_CHUNK away.
1675 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1676 (bidi_count_bytes, bidi_char_at_pos): New functions.
1677 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1678 always valid if bidi_cache_idx is valid.
1679 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1680 is valid if it's going to be used.
1681 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1682 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1683 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1684 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1685 (bidi_find_other_level_edge, bidi_cache_start_stack):
1686 All variables related to cache indices are now EMACS_INT.
c965adc5 1687
0bb23927
EZ
1688 * dispextern.h (struct bidi_string_data): New structure.
1689 (struct bidi_it): New member `string'. Make flag members be 1-bit
1690 fields, and put them last in the struct.
640c8776
SM
1691 (compute_display_string_pos, compute_display_string_end):
1692 Update prototypes.
0bb23927
EZ
1693 (bidi_push_it, bidi_pop_it): Add prototypes.
1694 (struct iterator_stack_entry): New members bidi_p,
1695 paragraph_embedding, and from_disp_prop_p.
1696 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1697 (bidi_shelve_cache, bidi_unshelve_cache):
1698 Declare prototypes.
0bb23927
EZ
1699
1700 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1701 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1702 and vector-like objects.
1703
1704 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1705 cache around display iteration.
1706
1707 * window.c (Fwindow_end, window_scroll_pixel_based)
1708 (displayed_window_lines, Frecenter): Save and restore the bidi
1709 cache around display iteration.
1710
3bbd2265
LMI
17112011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1712
1713 * editfns.c (Fdelete_region): Clarify the use of the named
1714 parameters (bug#6788).
1715
adc47434
MR
17162011-07-14 Martin Rudalics <rudalics@gmx.at>
1717
1718 * indent.c (Fvertical_motion): Set and restore w->pointm when
1719 saving and restoring the window's buffer (Bug#9006).
1720
837c31f8
LMI
17212011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1722
1723 * editfns.c (Fstring_to_char): Clarify just what is returned
1724 (bug#6576). Text by Eli Zaretskii.
1725
ac389d0c
JB
17262011-07-13 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1729
0be0ce47
EZ
17302011-07-13 Eli Zaretskii <eliz@gnu.org>
1731
1732 * buffer.c (mmap_find): Fix a typo.
1733
cd18e7e3
JB
17342011-07-13 Johan Bockgård <bojohan@gnu.org>
1735
1736 Fix execution of x selection hooks.
1737 * xselect.c (Qx_lost_selection_functions)
1738 (Qx_sent_selection_functions): New vars.
1739 (syms_of_xselect): DEFSYM them.
1740 (x_handle_selection_request): Pass Qx_sent_selection_functions
1741 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1742 (x_handle_selection_clear,x_clear_frame_selections):
1743 Pass Qx_lost_selection_functions rather than
1744 Vx_lost_selection_functions to Frun_hook_with_args.
1745
47ea7f44
PE
17462011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1747
ac389d0c 1748 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1749 The old code sometimes used this field without initializing it.
1750
47ea7f44
PE
1751 * alloc.c (gc_sweep): Don't read past end of array.
1752 In theory, the old code could also have corrupted Emacs internals,
1753 though it'd be very unlikely.
1754
bc985c87
AS
17552011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1756
1757 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1758 argument. (Bug#4026)
bc985c87 1759
0cf34688
LMI
17602011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1761
b3dadd76
LMI
1762 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1763 key" (bug#4257).
1764
0cf34688
LMI
1765 * window.c (Fset_window_start): Doc fix (bug#4199).
1766 (Fset_window_hscroll): Ditto.
1767
270768cd
PE
17682011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1769
077e3dda 1770 Fix minor new problems caught by GCC 4.6.1.
270768cd 1771 * term.c (init_tty): Remove unused local.
490011a6 1772 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1773 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1774 not used otherwise.
270768cd 1775
b1f58454
CY
17762011-07-12 Chong Yidong <cyd@stupidchicken.com>
1777
1778 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1779
22b9578d
LMI
17802011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1781
6e70ab07
LMI
1782 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1783 are the mini-buffer and the echo area (bug#3320).
1784
22b9578d
LMI
1785 * term.c (init_tty): Remove support for supdup, c10 and perq
1786 terminals, which are no longer supported (bug#1482).
1787
8974cc9f
JB
17882011-07-10 Johan Bockgård <bojohan@gnu.org>
1789
1790 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1791
a560d974
JD
17922011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1793
1794 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1795 for non-popups (Bug#3642).
1796
1dae0f0a
AS
17972011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1798
268c2c36 1799 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1800 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1801 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1802 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1803 * data.c (fmod): Likewise.
1804 * dispnew.c (swap_glyphs_in_rows): Likewise.
1805 * emacs.c (memory_warning_signal): Likewise.
1806 * floatfns.c (float_error): Likewise.
1807 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1808 (otf_open, font_otf_capability, generate_otf_features)
1809 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1810 Likewise.
1811 * image.c (pbm_read_file): Likewise.
1812 * indent.c (string_display_width): Likewise.
1813 * intervals.c (check_for_interval, search_for_interval)
1814 (inc_interval_count, count_intervals, root_interval)
1815 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1816 * lread.c (defalias): Likewise.
268c2c36 1817 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1818 * regex.c (set_image_of_range_1, set_image_of_range)
1819 (regex_grow_registers): Likewise.
1820 * sysdep.c (strerror): Likewise.
1821 * termcap.c (valid_filename_p, tprint, main): Likewise.
1822 * tparam.c (main): Likewise.
1823 * unexhp9k800.c (run_time_remap, save_data_space)
1824 (update_file_ptrs, read_header, write_header, calculate_checksum)
1825 (copy_file, copy_rest, display_header): Likewise.
1826 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1827 Likewise.
1828 * xdisp.c (check_it): Likewise.
1829 * xfaces.c (register_color, unregister_color, unregister_colors):
1830 Likewise.
1831 * xfns.c (print_fontset_result): Likewise.
1832 * xrdb.c (member, fatal, main): Likewise.
1833
99033785
PE
18342011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1835
1836 Fix minor problems found by static checking (Bug#9031).
1837 * chartab.c (char_table_set_range, map_sub_char_table):
1838 Remove unused locals.
1839 (uniprop_table): Now static.
1840 * composite.c (_work_char): Remove unused static var.
1841
9cb2ac56
JB
18422011-07-09 Juanma Barranquero <lekktu@gmail.com>
1843
1844 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1845
f25661f0
JD
18462011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1847
1848 * gtkutil.c (qttip_cb): Remove code without function.
1849
8278c4fe
EZ
18502011-07-09 Eli Zaretskii <eliz@gnu.org>
1851
1852 * w32.c (pthread_sigmask): New stub.
1853
1692ae2d 18542011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1855
8a6ebd58 1856 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1857 sigprocmask is portable only for single-threaded applications, and
1858 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1859 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1860 (LIBES): Use it.
1861 * callproc.c (Fcall_process):
1862 * process.c (create_process):
1863 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1864 Use pthread_sigmask, not sigprocmask.
123403e4 1865
1b854618
JD
18662011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1867
1868 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1869 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1870 wrong (Bug#8591).
1871
3fe4b549
JD
18722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1873
0ce7e563
JD
1874 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1875 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1876 (xg_hide_tooltip): Fix comment.
1877
3fe4b549
JD
1878 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1879 in registerServicesMenuSendTypes.
1880 (validRequestorForSendType): Don't check ns_return_types.
1881
1882 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1883 ns_return_type.
1884
5df75e47
JR
18852011-07-08 Jason Rumney <jasonr@gnu.org>
1886
1887 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1888 frame struct members of non-existent frames (Bug#6284).
1889
699c10bd
JD
18902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1891
4393663b
JD
1892 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1893 variable firstTime not needed on OSX >= 10.6.
1894 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1895 >= 10.5. Use setKnobProportion, setDoubleValue.
1896
1897 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1898 (MAC_OS_X_VERSION_10_5): Define if not defined.
1899 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1900 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1901 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1902
1903 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1904 cString and lossyCString on OSX >= 10.4
1905
1906 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1907 sizeToFit on OSX >= 10.2.
1908
1909 * nsimage.m (allocInitFromFile): Don't use deprecated method
1910 bestRepresentationForDevice on OSX >= 10.6.
1911
1912 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1913 to avoid warning.
1914
1915 * emacs.c: Declare unexec_init_emacs_zone.
1916
a63e0781
JD
1917 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1918
699c10bd
JD
1919 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1920
1921 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1922 on svcsMenu (Bug#8842).
1923
1924 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1925 ns_return_types.
1926 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1927
1928 * nsterm.m (QUTF8_STRING): Declare.
1929 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1930 (validRequestorForSendType): Return type is (id).
1931 Change indexOfObjectIdenticalTo to indexOfObject.
1932 Check if we have local selection before returning self (Bug#8842).
1933 (writeSelectionToPasteboard): Put local selection into paste board
1934 if we have a local selection (Bug#8842).
1935 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1936
1937 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1938 (ns_get_local_selection): Declare.
1939
54e10184
LMI
19402011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1941
9888ff71
LMI
1942 * keymap.c (describe_map_tree): Don't insert a double newline at
1943 the end of the buffer (bug#1169) and return whether we inserted
1944 something.
1945
54e10184
LMI
1946 * callint.c (Fcall_interactively): Change "reading args" to
1947 "providing args" to try to clarify what it does (bug#1010).
1948
15fa4783
KH
19492011-07-07 Kenichi Handa <handa@m17n.org>
1950
1951 * composite.c (composition_compute_stop_pos): Ignore a static
1952 composition starting before CHARPOS (Bug#8915).
1953
1954 * xdisp.c (handle_composition_prop): Likewise.
1955
a8815b00
EZ
19562011-07-07 Eli Zaretskii <eliz@gnu.org>
1957
1958 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1959 (Bug#9015)
1960
ef7b981d 19612011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1962
1963 * character.h (unicode_category_t): New enum type.
1964
1965 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1966 (Qchar_code_property_table): New variable.
1967 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1968 (UNIPROP_COMPRESSED_FORM_P): New macros.
1969 (char_table_ascii): Uncompress the compressed values.
1970 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1971 Uncompress the compressed values.
ac389d0c 1972 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1973 (char_table_ref_and_range): Uncompress the compressed values.
1974 (sub_char_table_set): New arg is_uniprop. Callers changed.
1975 Uncompress the compressed values.
1976 (sub_char_table_set_range): Args changed. Callers changed.
1977 (char_table_set_range): Adjuted for the above change.
1978 (map_sub_char_table): Delete args default_val and parent. Add arg
1979 top. Give decoded values to a Lisp function.
640c8776 1980 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1981 values to a Lisp function. Gcpro more variables.
1982 (uniprop_table_uncompress)
1983 (uniprop_decode_value_run_length): New functions.
1984 (uniprop_decoder, uniprop_decoder_count): New variables.
1985 (uniprop_get_decoder, uniprop_encode_value_character)
1986 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1987 New functions.
1988 (uniprop_encoder, uniprop_encoder_count): New variables.
1989 (uniprop_get_encoder, uniprop_table)
1990 (Funicode_property_table_internal, Fget_unicode_property_internal)
1991 (Fput_unicode_property_internal): New functions.
1992 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1993 Sunicode_property_table_internal, Sget_unicode_property_internal,
1994 and Sput_unicode_property_internal. Defvar_lisp
1995 char-code-property-alist.
1996
640c8776 1997 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1998 Vunicode_category_table.
1999
640c8776 2000 * font.c (font_range): Adjust for the change of
c805dec0
KH
2001 Vunicode_category_table.
2002
76b397fb
DN
20032011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2004
2005 * m/iris4d.h: Remove file, move contents ...
2006 * s/irix6-5.h: ... here.
2007
22b4128e
PE
20082011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2011 * alloc.c (mark_buffer):
2012 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2013 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2014 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2015 This isn't true in general, and it's particularly not true
2016 if Emacs is configured with --with-wide-int.
2017 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2018 New macros, used in the buffer.c change.
2019
869795d6
JD
20202011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2021
2022 * xsettings.c: Use both GConf and GSettings if both are available.
2023 (store_config_changed_event): Add comment.
2024 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2025 (store_tool_bar_style_changed): New functions.
2026 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2027 (struct xsettings): Move font inside HAVE_XFT.
2028 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2029 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2030 Move inside HAVE_XFT.
640c8776 2031 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2032 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2033 also.
2034 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
2035 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2036 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2037 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2038 (parse_settings): Move check for font inside HAVE_XFT.
2039 (read_settings, apply_xft_settings): Add comment.
2040 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2041 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2042 call store_font_name_changed.
2043 (xft_settings_event): Add comment.
2044 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2045 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2046 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2047 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2048 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2049 (xsettings_get_system_font, xsettings_get_system_normal_font):
2050 Add comment.
869795d6 2051
d8ed26bd
PE
20522011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2053
2054 Random fixes. E.g., (random) never returned negative values.
2055 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2056 subseconds part to the entropy, as that's a bit more random.
2057 Prefer signed to unsigned, since the signedness doesn't matter and
2058 in general we prefer signed. When given a limit, use a
2059 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2060 latter isn't right if USE_2_TAGS_FOR_INTS.
2061 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2062 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2063
cabf1cac
SM
20642011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2065
2066 * textprop.c (text_property_stickiness):
2067 Obey Vtext_property_default_nonsticky.
2068 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2069 * w32fns.c (syms_of_w32fns):
2070 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2071
6e9b2be9
PE
20722011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2075 This is more efficient than Ffile_directory_p and avoids a minor race.
2076
90186c68
LMI
20772011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2078
7c301272
LMI
2079 * buffer.c (Foverlay_put): Say what the return value is
2080 (bug#7835).
2081
c4f2d8d4
LMI
2082 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2083 is a directory before asking whether to use the file name
2084 (bug#7564).
ad637907
LMI
2085 (barf_or_query_if_file_exists): Make the "File is a directory"
2086 error be more correct.
c4f2d8d4 2087
90186c68
LMI
2088 * fns.c (Frequire): Remove the mention of the .gz files, since
2089 that's installation-specific, but keep the mention of
2090 `get-load-suffixes'.
2091
da64016e
PE
20922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2095 Report string overflow if the output is too long.
2096
7d47b580
JB
20972011-07-04 Juanma Barranquero <lekktu@gmail.com>
2098
a555cb87
JB
2099 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2100 (syms_of_gnutls): Remove duplicate DEFSYM for
2101 Qgnutls_bootprop_verify_hostname_error, an error for
2102 Qgnutls_bootprop_verify_error (which is no longer used).
2103
7d47b580
JB
2104 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2105 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2106 Also (re)move comments that are misplaced or no longer relevant.
2107
1e49bfab
LMI
21082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2109
2110 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2111
1485f4c0
CY
21122011-07-03 Chong Yidong <cyd@stupidchicken.com>
2113
2114 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2115 and background color parameters if they have been changed.
2116
a9ab721e
LMI
21172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2118
2119 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2120
cf7cff57
PE
21212011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2122
2e13213d
PE
2123 * xsettings.c (SYSTEM_FONT): Define only when used.
2124 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2125
cf7cff57
PE
2126 * keymap.c (access_keymap_1): Now static.
2127
7a8e04f7
CY
21282011-07-02 Chong Yidong <cyd@stupidchicken.com>
2129
2130 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2131 leave any prefix arg for the up event (Bug#1586).
2132
61352f62
LMI
21332011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2134
69bb1ef7
LMI
2135 * lread.c (syms_of_lread): Mention single symbols defined by
2136 `defvar' or `defconst' (bug#7154).
2137
61352f62 2138 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2139 (Frequire): Mention get-load-suffixes.
61352f62 2140
28545e04
MR
21412011-07-02 Martin Rudalics <rudalics@gmx.at>
2142
2143 * window.h (window): Remove clone_number slot.
2144 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2145 Remove.
2146 (make_parent_window, make_window, saved_window)
2147 (Fset_window_configuration, save_window_save): Don't deal with
2148 clone numbers.
2149 * buffer.c (Qclone_number): Remove declaration.
2150 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2151
3349e122
SM
21522011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2153
2154 Add multiple inheritance to keymaps.
2155 * keymap.c (Fmake_composed_keymap): New function.
2156 (Fset_keymap_parent): Simplify.
2157 (fix_submap_inheritance): Remove.
2158 (access_keymap_1): New function extracted from access_keymap to handle
2159 embedded parents and handle lists of maps.
2160 (access_keymap): Use it.
2161 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2162 (Fcopy_keymap): Handle embedded parents.
2163 (Fcommand_remapping, define_as_prefix): Simplify.
2164 (Fkey_binding): Simplify.
2165 (syms_of_keymap): Move minibuffer-local-completion-map,
2166 minibuffer-local-filename-completion-map,
2167 minibuffer-local-must-match-map, and
2168 minibuffer-local-filename-must-match-map to Elisp.
2169 (syms_of_keymap): Defsubr make-composed-keymap.
2170 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2171 (parse_menu_item): Trivial simplification.
2172
3279eb87
GM
21732011-07-01 Glenn Morris <rgm@gnu.org>
2174
2175 * Makefile.in (SETTINGS_LIBS): Fix typo.
2176
4550efdf
KI
21772011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2178
2179 * coding.c (Fencode_coding_string): Record the last coding system
2180 used, as the function doc string says (bug#8738).
2181
0949d2b6
JD
21822011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2183
2184 * xsettings.c (store_monospaced_changed): Take new font as arg and
2185 check for change against current_mono_font.
2186 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2187 (emacs_settings_constructor, emacs_settings_get_property)
2188 (emacs_settings_set_property, emacs_settings_class_init)
2189 (emacs_settings_init, gsettings_obj): Remove.
2190 (something_changedCB): New function for HAVE_GSETTINGS.
2191 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2192 with value as argument.
2193 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2194 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2195 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2196 "changed".
2197
2198 * xgselect.c: Add defined (HAVE_GSETTINGS).
2199 (xgselect_initialize): Ditto.
2200
2201 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2202 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2203 xg_select.
2204
bbc6b304
PE
22052011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2206
2207 * eval.c (struct backtrace): Simplify and port the data structure.
2208 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2209 signed bit field, as this assumption is not portable and it makes
2210 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2211 "char debug_on_exit : 1" as this is not portable either; instead,
2212 use the portable "unsigned int debug_on_exit : 1". Remove unused
2213 member evalargs. Remove obsolete comments about cc bombing out.
2214
9851bfc5
JD
22152011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2216
51bb811f 2217 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2218 Let HAVE_GSETTINGS override HAVE_GCONF.
2219 (store_monospaced_changed): New function.
2220 (EMACS_SETTINGS): A new type derived from GObject to handle
2221 GSettings notifications.
2222 (emacs_settings_constructor, emacs_settings_get_property)
2223 (emacs_settings_set_property, emacs_settings_class_init):
2224 New functions.
2225 (gsettings_client, gsettings_obj): New variables.
2226 (GSETTINGS_SCHEMA): New define.
2227 (something_changedCB): Call store_monospaced_changed.
2228 (init_gsettings): New function.
2229 (xsettings_initialize): Call init_gsettings.
2230 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2231 to NULL.
2232
640c8776 2233 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2234 GCONF_CFLAGS/LIBS.
2235
5386012d
MR
22362011-06-29 Martin Rudalics <rudalics@gmx.at>
2237
2238 * window.c (resize_root_window, grow_mini_window)
2239 (shrink_mini_window): Rename Qresize_root_window to
2240 Qwindow_resize_root_window and Qresize_root_window_vertically to
2241 Qwindow_resize_root_window_vertically.
2242
f13e0b08
PE
22432011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2244
2245 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2246
94515237
JB
22472011-06-27 Juanma Barranquero <lekktu@gmail.com>
2248
2249 * makefile.w32-in: Redesign dependencies so they reflect more
2250 clearly which files are directly included by each source file,
2251 and not through other includes.
2252
e43b6e43
MR
22532011-06-27 Martin Rudalics <rudalics@gmx.at>
2254
2255 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2256 (sort_overlays, overlay_strings): When an overlay's clone number
2257 matches the window's clone number process the overlay even if
2258 the overlay's window property doesn't match the current window.
2259
d68443dc
MR
2260 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2261 (Fwindow_hchild): Rename to Fwindow_left_child.
2262 (Fwindow_next): Rename to Fwindow_next_sibling.
2263 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2264 (resize_window_check): Rename to window_resize_check.
2265 (resize_window_apply): Rename to window_resize_apply.
2266 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2267 (Fdelete_other_windows_internal, resize_frame_windows)
2268 (Fsplit_window_internal, Fdelete_window_internal)
2269 (grow_mini_window, shrink_mini_window)
2270 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2271
c7e73be5
JD
22722011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2273
2274 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2275 (emacs_fixed_set_min_size): Remove.
2276 (emacs_fixed_new): Take frame as argument.
2277
2278 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2279 (_EmacsFixedPrivate): Remove minwidth/height.
2280 Add struct frame *f.
2281 (emacs_fixed_init): Initialize priv->f.
2282 (get_parent_class, emacs_fixed_set_min_size): Remove.
2283 (emacs_fixed_new): Set priv->f to argument.
2284 (emacs_fixed_get_preferred_width)
2285 (emacs_fixed_get_preferred_height): Use min_width/height from
2286 frames size_hint to set minimum and natural (Bug#8919).
2287 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2288 and use min_width/height from frames size_hint to set
2289 min_width/height (Bug#8919).
2290
2291 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2292 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2293 Fix indentation.
c7e73be5 2294
cf99dcf8
EZ
22952011-06-26 Eli Zaretskii <eliz@gnu.org>
2296
2297 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2298 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2299 called at ZV.
2300
029529ac
CY
23012011-06-26 Chong Yidong <cyd@stupidchicken.com>
2302
2303 * process.c (wait_reading_process_output): Bypass select if
2304 waiting for a cell while ignoring keyboard input, and input is
2305 pending. Suggested by Jan Djärv (Bug#8869).
2306
7a7ef429
PE
23072011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 Use gnulib's dup2 module instead of rolling our own.
2310 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2311
11fdef7d 23122011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2313
2314 * dispnew.c (scrolling_window): Before scrolling, turn off a
2315 mouse-highlight in the window being scrolled.
2316
cd3520a4
JB
23172011-06-24 Juanma Barranquero <lekktu@gmail.com>
2318
2319 Move DEFSYM to lisp.h and use everywhere.
2320
2321 * character.h (DEFSYM): Move declaration...
2322 * lisp.h (DEFSYM): ...here.
2323
2324 * gnutls.c:
2325 * minibuf.c:
2326 * w32menu.c:
2327 * w32proc.c:
2328 * w32select.c: Don't include character.h.
2329
2330 * alloc.c (syms_of_alloc):
2331 * buffer.c (syms_of_buffer):
2332 * bytecode.c (syms_of_bytecode):
2333 * callint.c (syms_of_callint):
2334 * casefiddle.c (syms_of_casefiddle):
2335 * casetab.c (init_casetab_once):
2336 * category.c (init_category_once, syms_of_category):
2337 * ccl.c (syms_of_ccl):
2338 * cmds.c (syms_of_cmds):
2339 * composite.c (syms_of_composite):
2340 * dbusbind.c (syms_of_dbusbind):
2341 * dired.c (syms_of_dired):
2342 * dispnew.c (syms_of_display):
2343 * doc.c (syms_of_doc):
2344 * editfns.c (syms_of_editfns):
2345 * emacs.c (syms_of_emacs):
2346 * eval.c (syms_of_eval):
2347 * fileio.c (syms_of_fileio):
2348 * fns.c (syms_of_fns):
2349 * frame.c (syms_of_frame):
2350 * fringe.c (syms_of_fringe):
2351 * insdel.c (syms_of_insdel):
2352 * keymap.c (syms_of_keymap):
2353 * lread.c (init_obarray, syms_of_lread):
2354 * macros.c (syms_of_macros):
2355 * msdos.c (syms_of_msdos):
2356 * print.c (syms_of_print):
2357 * process.c (syms_of_process):
2358 * search.c (syms_of_search):
2359 * sound.c (syms_of_sound):
2360 * syntax.c (init_syntax_once, syms_of_syntax):
2361 * terminal.c (syms_of_terminal):
2362 * textprop.c (syms_of_textprop):
2363 * undo.c (syms_of_undo):
2364 * w32.c (globals_of_w32):
2365 * window.c (syms_of_window):
2366 * xdisp.c (syms_of_xdisp):
2367 * xfaces.c (syms_of_xfaces):
2368 * xfns.c (syms_of_xfns):
2369 * xmenu.c (syms_of_xmenu):
2370 * xsettings.c (syms_of_xsettings):
2371 * xterm.c (syms_of_xterm): Use DEFSYM.
2372
4228cf16
TZ
23732011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2374
cd3520a4 2375 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2376
7fcccf1e
PE
23772011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2378
7efb4e0e
PE
2379 Integer and buffer overflow fixes (Bug#8873).
2380
ff5844ad
PE
2381 * print.c (printchar, strout): Check for string overflow.
2382 (PRINTPREPARE, printchar, strout):
2383 Don't set size unless allocation succeeds.
2384
90532f02
PE
2385 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2386 for sizes. Check for string overflow more accurately.
2387 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2388
6d84508d
PE
2389 * macros.c: Integer and buffer overflow fixes.
2390 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2391 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2392 Use ptrdiff_t, not int, for sizes.
2393 Don't increment bufsize until after realloc succeeds.
2394 Check for size-calculation overflow.
2395 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2396
437b2cb4
PE
2397 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2398
8b9ac8b4
PE
2399 * lread.c: Integer overflow fixes.
2400 (read_integer): Radix is now EMACS_INT, not int,
2401 to improve quality of diagnostics for out-of-range radices.
2402 Calculate buffer size correctly for out-of-range radices.
2403 (read1): Check for integer overflow in radices, and in
2404 read-circle numbers.
82cb60d3
PE
2405 (read_escape): Avoid int overflow.
2406 (Fload, openp, read_buffer_size, read1)
2407 (substitute_object_recurse, read_vector, read_list, map_obarray):
2408 Use ptrdiff_t, not int, for sizes.
2409 (read1): Use EMACS_INT, not int, for sizes.
20270765 2410 Check for size overflow.
8b9ac8b4 2411
7fcccf1e
PE
2412 * image.c (cache_image): Check for size arithmetic overflow.
2413
bfbbd7e7
PE
2414 * lread.c: Integer overflow issues.
2415 (saved_doc_string_size, saved_doc_string_length)
2416 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2417 Now ptrdiff_t, not int.
2418 (read1): Don't assume doc string length fits in int. Check for
2419 out-of-range doc string lengths.
2420 (read_list): Don't assume file position fits in int.
39019e54 2421 (read_escape): Check for hex character overflow.
bfbbd7e7 2422
4e323265
LL
24232011-06-22 Leo Liu <sdl.web@gmail.com>
2424
2425 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2426 Move to minibuffer.el.
2427
85fece3e
PE
24282011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2429
20b84ce9 2430 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2431 The following patches are for when GLYPH_DEBUG && !XASSERT.
2432 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2433 * dispnew.c (flush_stdout):
2434 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2435 Mark as externally visible.
2436 * dispnew.c (check_window_matrix_pointers): Now static.
2437 * dispnew.c (window_to_frame_vpos):
2438 * xfns.c (unwind_create_frame):
2439 * xterm.c (x_check_font): Remove unused local.
2440 * scroll.c (CHECK_BOUNDS):
2441 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2442 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2443 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2444 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2445 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2446 Now static.
2447 (debug_method_add): Use va_list and vsprintf rather than relying
2448 on undefined behavior with wrong number of arguments.
2449 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2450 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2451 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2452 since we're not interested in debugging glyphs with old libraries.
2453 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2454 GCC 4.6.0's static checking.
2455
0766b489
PE
24562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2457
31fd4b32
PE
2458 Integer overflow and signedness fixes (Bug#8873).
2459 A few related buffer overrun fixes, too.
2460
b79e8648
PE
2461 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2462
0766b489
PE
2463 * dispextern.h (struct face.stipple):
2464 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2465 (x_bitmap_mask, x_allocate_bitmap_record)
2466 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2467 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2468 (x_create_bitmap_from_xpm_data):
2469 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2470 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2471 (.bitmaps_last):
2472 * xfaces.c (load_pixmap):
2473 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2474 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2475 (.bitmaps_last, struct x_output.icon_bitmap):
2476 Use ptrdiff_t, not int, for bitmap indexes.
2477 (x_allocate_bitmap_record): Check for size overflow.
2478 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2479
b081724f
PE
2480 Use ptrdiff_t, not int, for overlay counts.
2481 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2482 * editfns.c (overlays_around, get_pos_property):
2483 * textprop.c (get_char_property_and_overlay):
2484 * xdisp.c (next_overlay_change, note_mouse_highlight):
2485 * xfaces.c (face_at_buffer_position):
21514da7
PE
2486 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2487 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2488 (Fnext_overlay_change, Fprevious_overlay_change)
2489 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2490 Use ptrdiff_t, not int, for sizes.
21514da7 2491 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2492
3de73e5e
PE
2493 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2494
2606c57b
PE
2495 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2496 (x_session_initialize): Do not assume string length fits in int.
2497
aaafe47a
PE
2498 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2499 This is unlikely, but can occur if DPI is outlandish.
2500
2674ddc8 2501 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2502 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2503
28154962
PE
2504 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2505 * xrdb.c (magic_file_p, search_magic_path):
2506 Omit last arg SUFFIX; it was always 0. All callers changed.
2507 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2508
7de51af5
PE
2509 * xfont.c (xfont_match): Avoid need for strlen.
2510
25ed6cc3
PE
2511 * xfns.c: Don't assume strlen fits in int.
2512 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2513
4eab31dd
PE
2514 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2515 not unsigned long, as we prefer signed integers. All callers changed.
2516 Detect integer overflow in repeat count.
2517 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2518 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2519
171e2a58
PE
2520 * termcap.c: Don't assume sizes fit in int and never overflow.
2521 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2522 (gobble_line): Check for size-calculation overflow.
2523
ad39faca 2524 * minibuf.c (Fread_buffer):
6e5bb2dc 2525 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2526 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2527 Don't assume string length fits in int.
2528
52c61c22 2529 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2530 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2531
b5b8c9e5
PE
2532 * font.c: Don't assume string length fits in int.
2533 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2534 Use ptrdiff_t, not int.
ccd6111c
PE
2535 (font_intern_prop): Don't assume string length fits in int.
2536 Don't assume integer property fits in fixnum.
2537 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2538
882f0d81 2539 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2540 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2541 Reformulate so as not to need the command string.
2542 Invoke gzip -cd rather than gunzip, as it's more portable.
2543 (lock_info_type, lock_file_1, lock_file):
2544 Don't assume pid_t and time_t fit in unsigned long.
2545 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2546 (current_lock_owner): Prefer signed type for sizes.
2547 Use memcpy, not strncpy, where memcpy is what is really wanted.
2548 Don't assume (via atoi) that time_t and pid_t fit in int.
2549 Check for time_t and/or pid_t out of range, e.g., via a network share.
2550 Don't alloca where an auto var works fine.
2551
93f4cf88
PE
2552 * fileio.c: Fix some integer overflow issues.
2553 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2554 Don't assume string length fits in int.
2555 (directory_file_name): Don't assume string length fits in long.
2556 (make_temp_name): Don't assume pid fits in int, or that its print
2557 length is less than 20.
2558
f3e92b69
PE
2559 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2560
1bfdaf10
PE
2561 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2562
35016e9a
PE
2563 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2564
3d1e65a1
PE
2565 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2566 We prefer signed integers, even for size calculations.
2567
0b963a93
PE
2568 * emacs.c: Don't assume string length fits in 'int'.
2569 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2570 (main): Don't invoke strlen when not needed.
2571
573f4b54
PE
2572 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2573 (XD_DEBUG_MESSAGE): Don't waste a byte.
2574
989f33ba
PE
2575 * callproc.c (getenv_internal_1, getenv_internal)
2576 (Fgetenv_internal):
965d34eb
PE
2577 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2578
e4d29b33
PE
2579 * lread.c (invalid_syntax): Omit length argument.
2580 All uses changed. This doesn't fix a bug, but it simplifies the
2581 code away from its former Hollerith-constant appearance, and it's
2582 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2583 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2584
eb49b136
PE
2585 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2586 This didn't break anything, but it didn't help either.
2587 It's confusing to put a bogus integer in a place where the actual
2588 value does not matter.
9f62aeb1 2589 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2590 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2591
15375a22
PE
2592 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2593 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2594 implementation.
b61cc01c
PE
2595 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2596 We prefer signed types, and the value cannot exceed the EMACS_INT
2597 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2598 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2599 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2600 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2601
53b2623d
PE
2602 * indent.c (sane_tab_width): New function.
2603 (current_column, scan_for_column, Findent_to, position_indentation)
2604 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2605 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2606
51cab52b 2607 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2608
f2ed8a70
PE
2609 * lisp.h (lint_assume): New macro.
2610 * composite.c (composition_gstring_put_cache):
2611 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2612
abe80cc6
PE
2613 * editfns.c, insdel.c:
2614 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2615
b02c740e
PE
2616 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2617
ebc96716
PE
2618 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2619
b4e50fa0 2620 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2621 Use much-faster test for byte-length change.
311d5d7c 2622 Don't assume string byte-length fits in 'int'.
a4cf38e4 2623 Check that character arg fits in 'int'.
85461888 2624 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2625
c0c1ee9f
PE
2626 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2627
a498d7f4
PE
2628 * fns.c (concat): Catch string overflow earlier.
2629 Do not rely on integer wraparound.
2630
51cab52b
PE
2631 * dispextern.h (struct it.overlay_strings_charpos)
2632 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2633 * xdisp.c (forward_to_next_line_start)
2634 (back_to_previous_visible_line_start)
2635 (reseat_at_next_visible_line_start, next_element_from_buffer):
2636 Don't arbitrarily truncate the value of 'selective' to int.
2637
76031fad
PE
2638 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2639
5eb55db9
PE
2640 * composite.c: Don't truncate sizes to 'int'.
2641 (composition_gstring_p, composition_reseat_it)
2642 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2643 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2644 not EMACS_UINT, for indexes.
5eb55db9 2645
0703a717
PE
2646 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2647
d6202519
PE
2648 * buffer.c: Include <verify.h>.
2649 (struct sortvec.priority, struct sortstr.priority):
8961a454 2650 Now EMACS_INT, not int.
c20998a7 2651 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2652 (struct sortstr.size, record_overlay_string)
2653 (struct sortstrlist.size, struct sortlist.used):
2654 Don't truncate size to int.
2655 (record_overlay_string): Check for size-calculation overflow.
d6202519 2656 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2657
d5a19415
JM
26582011-06-22 Jim Meyering <meyering@redhat.com>
2659
029529ac 2660 Don't leak an XBM-image-sized buffer
d5a19415
JM
2661 * image.c (xbm_load): Free the image buffer after using it.
2662
a9041e6c
PE
26632011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 Port to Sun C.
2666 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2667 that Sun C diagnosed.
2668 * fns.c (secure_hash): Fix pointer signedness issue.
2669 * intervals.c (static_offset_intervals): New function.
2670 (offset_intervals): Use it.
2671
7f3f739f
LL
26722011-06-21 Leo Liu <sdl.web@gmail.com>
2673
2674 * deps.mk (fns.o):
2675 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2676 sha512.h.
2677
2678 * fns.c (secure_hash): Rename from crypto_hash_function and change
2679 the first arg to accept symbols.
5b66d427 2680 (Fsecure_hash): New primitive.
7f3f739f
LL
2681 (syms_of_fns): New symbols.
2682
76147d94
DD
26832011-06-20 Deniz Dogan <deniz@dogan.se>
2684
2685 * process.c (Fset_process_buffer): Clarify return value in
2686 docstring.
2687
7d7d0045
CY
26882011-06-18 Chong Yidong <cyd@stupidchicken.com>
2689
2690 * dispnew.c (add_window_display_history): Use BVAR.
2691
2692 * xdisp.c (debug_method_add): Use BVAR.
2693 (check_window_end, dump_glyph_matrix, dump_glyph)
2694 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2695
2696 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2697 Likewise.
2698
2699 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2700 check till after the cache is created in init_frame_faces.
2701
ff2bc410
SM
27022011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2703
2704 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2705
28177add
PE
27062011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2707
dd3482fe
PE
2708 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2709 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2710 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2711
393d71f3 2712 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2713 * fileio.c (Finsert_file_contents):
2714 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2715 Remove the old (too-loose) buffer overflow checks.
2716 They weren't needed, since make_gap checks for buffer overflow.
2717 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2718 The old code merely checked for Emacs fixnum overflow, and relied
2719 on undefined (wraparound) behavior. The new code avoids undefined
2720 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2721
2e6813b0 2722 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2723 Tune. Don't use wider integers than needed. Don't use alloca.
2724 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2725
599a9e4f
PE
2726 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2727
99561444
PE
2728 * insdel.c, lisp.h (buffer_overflow): New function.
2729 (insert_from_buffer_1, replace_range, replace_range_2):
2730 * insdel.c (make_gap_larger):
2731 * editfns.c (Finsert_char):
2732 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2733
28177add
PE
2734 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2735
e69dafad
PE
27362011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2737
a7af7fde 2738 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2739
b1c46f02
PE
2740 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2741 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2742
e69dafad
PE
2743 * fileio.c: Don't assume EMACS_INT fits in off_t.
2744 (emacs_lseek): New static function.
2745 (Finsert_file_contents, Fwrite_region): Use it.
2746 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2747
566684ea
PE
2748 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2749
e6966cd6
PE
2750 * fns.c: Don't overflow int when computing a list length.
2751 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2752 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2753 truncation on 64-bit hosts. Check for QUIT every
2754 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2755 faster and is responsive enough.
2756 (Flength): Report an error instead of overflowing an integer.
2757 (Fsafe_length): Return a float if the value is not representable
2758 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2759 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2760 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2761
dd0b0efb
PE
2762 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2763 (header_size, word_size): New constants.
2764 (allocate_vectorlike): Don't check size overflow here.
2765 (allocate_vector): Check it here instead, since this is the only
2766 caller of allocate_vectorlike that could cause overflow.
2767 Check that the new vector's length is representable as a fixnum.
2768
86fe5cfe
PE
2769 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2770 The previous code was bogus. For example, next_almost_prime (32)
2771 returned 39, which is undesirable as it is a multiple of 3; and
2772 next_almost_prime (24) returned 25, which is a multiple of 5 so
2773 why was the code bothering to check for multiples of 7?
2774
80e88859
PE
2775 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2776
4a2f0ad6
PE
2777 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2778
f66c7cf8
PE
2779 Variadic C functions now count arguments with ptrdiff_t.
2780 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2781 Back then I didn't know that the Emacs coding style prefers signed int.
2782 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2783 were being counted with int, which may truncate counts on 64-bit
2784 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2785 * lisp.h (struct Lisp_Subr.function.aMANY)
2786 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2787 Arg counts are now ptrdiff_t, not size_t.
2788 All variadic functions and their callers changed accordingly.
2789 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2790 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2791 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2792 * callint.c (Fcall_interactively): Check arg count for overflow,
2793 to avoid potential buffer overrun. Use signed char, not 'int',
2794 for 'varies' array, so that we needn't bother to check its size
2795 calculation for overflow.
2796 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2797 * eval.c (apply_lambda):
2798 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2799 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2800 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2801
a1759b76
PE
2802 * callint.c (Fcall_interactively): Don't use index var as event count.
2803
d96be9fc
PE
2804 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2805 * mem-limits.h (SIZE): Remove; no longer used.
2806
a690a978 2807 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2808
578c21e6
PE
2809 Remove unnecessary casts.
2810 * xterm.c (x_term_init):
2811 * xfns.c (x_set_border_pixel):
2812 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2813 These aren't needed now that we assume ANSI C.
2814
96f53c6c
PE
2815 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2816 It's more likely to cause problems (due to unsigned overflow)
2817 than to cure them.
2818
83c77d31
PE
2819 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2820
ee2079f1
PE
2821 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2822
6da65536
PE
2823 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2824
7147c4a4
PE
2825 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2826
193e32d9
PE
2827 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2828
e5533da6
PE
2829 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2830
9910e595
PE
2831 GLYPH_CODE_FACE returns EMACS_INT, not int.
2832 * dispextern.h (merge_faces):
2833 * xfaces.c (merge_faces):
01103c44
PE
2834 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2835 Don't assume EMACS_INT fits in int.
9910e595 2836
2638320e
PE
2837 * character.h (CHAR_VALID_P): Remove unused parameter.
2838 * fontset.c, lisp.h, xdisp.c: All uses changed.
2839
045eb8d9
PE
2840 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2841
c1f134b5
PE
2842 * fns.c (concat): Minor tuning based on overflow analysis.
2843 This doesn't fix any bugs. Use int to hold character, instead
2844 of constantly refetching from Emacs object. Use XFASTINT, not
2845 XINT, for value known to be a character. Don't bother comparing
2846 a single byte to 0400, as it's always less.
2847
395fcb93 2848 * floatfns.c (Fexpt):
327eeec8
PE
2849 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2850
abbd3d23
PE
2851 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2852 for characters.
2853
684a03ef
PE
2854 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2855
0fed43f3
PE
2856 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2857 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2858 incorrectly succeed when S was a string, because 4294967386 was
2859 truncated before it was used.
2860
8fd02eb7
PE
2861 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2862 Otherwise, an out-of-range integer could cause undefined behavior
2863 on a 64-bit host.
2864
f8c86b69
PE
2865 * composite.c: Use int, not EMACS_INT, for characters.
2866 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2867 EMACS_INT, for values that are known to be in character range.
2868 This doesn't fix any bugs but is the usual style inside Emacs and
2869 may generate better code on 32-bit machines.
2870
34206dd2
PE
2871 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2872 This is for reasons similar to the recent CHAR_STRING fix.
2873 * charset.c (Fencode_char): Check that character arg is actually
2874 a character. Pass an int to ENCODE_CHAR.
2875 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2876 wider than 'int', as a compile-time check to prevent future regressions
2877 in this area.
2878
c5958d4c 2879 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2880
2881 Make sure a 64-bit char is never passed to CHAR_STRING.
2882 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2883 by silently ignoring the top 32 bits, allowing some values
2884 that were far too large to be valid characters.
2885 * character.h: Include <verify.h>.
2886 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2887 arguments are no wider than unsigned, as a compile-time check
2888 to prevent future regressions in this area.
2889 * data.c (Faset):
01103c44 2890 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2891 (Fsubst_char_in_region):
2892 * fns.c (concat):
2893 * xdisp.c (decode_mode_spec_coding):
2894 Adjust to CHAR_STRING's new requirement.
2895 * editfns.c (Finsert_char, Fsubst_char_in_region):
2896 * fns.c (concat): Check that character args are actually
2897 characters. Without this test, these functions did the wrong
2898 thing with wildly out-of-range values on 64-bit hosts.
2899
d37ca623
PE
2900 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2901 These casts should not be needed on 32-bit hosts, either.
2902 * keyboard.c (read_char):
2903 * lread.c (Fload): Remove casts to unsigned.
2904
ea204efb
PE
2905 * lisp.h (UNSIGNED_CMP): New macro.
2906 This fixes comparison bugs on 64-bit hosts.
2907 (ASCII_CHAR_P): Use it.
2908 * casefiddle.c (casify_object):
01103c44 2909 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2910 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2911 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2912 * dispextern.h (FACE_FROM_ID):
2913 * keyboard.c (read_char): Use UNSIGNED_CMP.
2914
41cb286c
PE
2915 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2916 not to EMACS_INT, to avoid GCC warning.
2917
4a1b9832
PE
2918 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2919
55daad71
PE
2920 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2921 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2922 isn't needed on 32-bit machines.
8f95c75c 2923
01103c44
PE
2924 * buffer.c (Fgenerate_new_buffer_name):
2925 Use EMACS_INT for count, not int.
0ceccced 2926 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2927
2928 * data.c (Qcompiled_function): Now static.
2929
c6f072e7
PE
2930 * window.c (window_body_lines): Now static.
2931
20ce5912
PE
2932 * image.c (gif_load): Rename local to avoid shadowing.
2933
9c4c5f81
PE
2934 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2935 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2936 * alloc.c (make_save_value): Integer argument is now of type
2937 ptrdiff_t, not int.
2938 (mark_object): Use ptrdiff_t, not int.
2939 * lisp.h (pD): New macro.
2940 * print.c (print_object): Use it.
2941
c0c5c8ae
PE
2942 * alloc.c: Use EMACS_INT, not int, to count objects.
2943 (total_conses, total_markers, total_symbols, total_vector_size)
2944 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2945 (total_free_floats, total_floats, total_free_intervals)
2946 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2947 Now EMACS_INT, not int. All uses changed.
2948 (Fgarbage_collect): Compute overall total using a double, so that
2949 integer overflow is less likely to be a problem. Check for overflow
2950 when converting back to an integer.
5a25e253
PE
2951 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2952 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2953 These were 'int' variables that could overflow on 64-bit hosts;
2954 they were never used, so remove them instead of repairing them.
211a0b2a 2955 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2956 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2957 Previously, this ceilinged at INT_MAX, but that doesn't work on
2958 64-bit machines.
e46bb31a 2959 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2960
c78baabf 2961 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2962 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2963 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2964 when a (possibly-narrower) signed value would do just as well.
2965 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2966
c9d624c6
PE
2967 * alloc.c: Catch some string size overflows that we were missing.
2968 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2969 for convenience in STRING_BYTES_MAX.
2970 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2971 The definition here is exact; the one in lisp.h was approximate.
2972 (allocate_string_data): Check for string overflow. This catches
2973 some instances we weren't catching before. Also, it catches
2974 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2975 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2976 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2977
c9d624c6
PE
2978 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2979 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2980 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2981
353032ce
PE
2982 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2983
2bccce07
PE
2984 * alloc.c (Fmake_string): Check for out-of-range init.
2985
0ac30604
SM
29862011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2987
2988 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2989
c195f2de
JD
29902011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2991
2992 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2993 xg_get_default_scrollbar_width.
2994
2995 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2996 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2997 (style_changed_cb): Call update_theme_scrollbar_width and call
2998 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2999 all frames (Bug#8505).
3000 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3001 Call gtk_window_set_resizable if HAVE_GTK3.
3002 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3003 and height if HAVE_GTK3 (Bug#8505).
3004 (scroll_bar_width_for_theme): New variable.
3005 (update_theme_scrollbar_width): New function.
3006 (xg_get_default_scrollbar_width): Move code to
3007 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3008 (xg_initialize): Call update_theme_scrollbar_width.
3009
3010 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3011
3012 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3013
e10ac9f1
MR
30142011-06-12 Martin Rudalics <rudalics@gmx.at>
3015
3016 * frame.c (make_frame): Call other_buffer_safely instead of
3017 other_buffer.
3018
3019 * window.c (temp_output_buffer_show): Call display_buffer with
3020 second argument Vtemp_buffer_show_specifiers and reset latter
3021 immediately after the call.
3022 (Vtemp_buffer_show_specifiers): New variable.
3023 (auto_window_vscroll_p, next_screen_context_lines)
3024 (Vscroll_preserve_screen_position): Remove leading asterisks from
3025 doc-strings.
3026
2d3c217e 30272011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3028
7b7f97e8 3029 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3030 * buffer.c (Qclone_number): Remove for now, as it's unused.
3031 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3032 (record_buffer): Remove unused local.
3033 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3034 (set_frame_buffer_list): Remove; unused.
3035 * frame.h (other_visible_frames): Remove decl.
3036 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3037 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3038 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3039 if HAVE_GPM.
3040 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3041 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3042 Define only if HAVE_GPM.
3043 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3044 (update_hints_inhibit): Remove; never set. All uses removed.
3045 * widgetprv.h (emacsFrameClassRec): Remove decl.
3046 * window.c (delete_deletable_window): Now returns void, since it
3047 wasn't returning anything.
3048 (compare_window_configurations): Remove unused locals.
3049 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3050 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3051 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3052 the same widths as pointers. This follows up on the 2011-05-06 patch.
3053 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3054 * xterm.h: Likewise.
3055 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3056
1384b89e
JB
30572011-06-12 Juanma Barranquero <lekktu@gmail.com>
3058
3059 * makefile.w32-in: Update dependencies.
3060 (LISP_H): Add lib/intprops.h.
3061
1100a63c
CY
30622011-06-11 Chong Yidong <cyd@stupidchicken.com>
3063
3064 * image.c (gif_load): Add animation frame delay to the metadata.
3065 (syms_of_image): Use DEFSYM. New symbol `delay'.
3066
6198ccd0
MR
30672011-06-11 Martin Rudalics <rudalics@gmx.at>
3068
3069 * window.c (delete_deletable_window): Re-add.
3070 (Fset_window_configuration): Rewrite to handle dead buffers and
3071 consequently deletable windows.
3072 (window_tree, Fwindow_tree): Remove. Supply functionality in
3073 window.el.
3074 (compare_window_configurations): Simplify code.
3075
b6e3633c
AS
30762011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3077
1ab0dee5
AS
3078 * image.c (imagemagick_load_image): Fix type mismatch.
3079 (Fimagemagick_types): Likewise.
3080
b6e3633c
AS
3081 * window.h (replace_buffer_in_windows): Declare.
3082
9397e56f
MR
30832011-06-11 Martin Rudalics <rudalics@gmx.at>
3084
3085 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3086 Qclone_number. Remove external declaration of Qdelete_window.
3087 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3088 code.
640c8776
SM
3089 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3090 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3091 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3092 buffer list implementation.
3093 (other_buffer_safely): New function.
3094 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3095 calls to replace_buffer_in_windows and
3096 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3097 if allowed.
3098 (record_buffer): Inhibit quitting and rewrite using quittable
3099 functions. Run Qbuffer_list_update_hook if allowed.
3100 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3101 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3102 Move switch-to-buffer to window.el.
9397e56f
MR
3103 (bury-buffer): Move to window.el.
3104 (Vbuffer_list_update_hook): New variable.
3105
3106 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3107 section.
3108
3109 * window.h (resize_frame_windows): Move up in code.
3110 (Fwindow_frame): Remove EXFUN.
3111 (replace_buffer_in_all_windows): Remove prototype.
3112 (replace_buffer_in_windows_safely): Add prototype.
3113
3114 * window.c: Declare Qdelete_window static again. Move down
3115 declaration of select_count.
3116 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3117 (Fother_window): Move to window.el.
3118 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3119 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3120 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3121 window.el.
3122 (replace_buffer_in_windows): Implement by calling
3123 Qreplace_buffer_in_windows.
3124 (replace_buffer_in_all_windows): Remove with some functionality
3125 moved into replace_buffer_in_windows_safely.
3126 (replace_buffer_in_windows_safely): New function.
3127 (select_window_norecord, select_frame_norecord): Move in front
3128 of run_window_configuration_change_hook. Remove now obsolete
3129 declarations.
640c8776
SM
3130 (Fset_window_buffer): Rewrite doc-string.
3131 Call Qrecord_window_buffer.
9397e56f
MR
3132 (keys_of_window): Move binding for other-window to window.el.
3133
b50691aa
CY
31342011-06-11 Chong Yidong <cyd@stupidchicken.com>
3135
3136 * dispextern.h (struct image): Replace data member, whose int_val
3137 and ptr_val fields were not used by anything, with a single
3138 lisp_val object.
3139
3140 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3141 (gif_clear_image, gif_load, imagemagick_load_image)
3142 (gs_clear_image, gs_load): Callers changed.
3143
3f754b86
PE
31442011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3145
cca69397
PE
3146 * buffer.h: Include <time.h>, for time_t.
3147 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3148
109e28d0
PE
3149 Fix minor problems found by static checking.
3150
60737f02
PE
3151 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3152
4b66faf3
PE
3153 Make identifiers static if they are not used in other modules.
3154 * data.c (Qcompiled_function, Qframe, Qvector):
3155 * image.c (QimageMagick, Qsvg):
3156 * minibuf.c (Qmetadata):
3157 * window.c (resize_window_check, resize_root_window): Now static.
3158 * window.h (resize_window_check, resize_root_window): Remove decls.
3159
109e28d0
PE
3160 * window.c (window_deletion_count, delete_deletable_window):
3161 Remove; unused.
46a4ce9e
PE
3162 (window_body_lines): Now static.
3163 (Fdelete_other_windows_internal): Mark vars as initialized.
3164 Make sure 'resize_failed' is initialized.
3165 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3166 (resize_window_apply): Remove unused local.
3167 * window.h (delete_deletable_window): Remove decl.
3168
109e28d0 3169 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3170 (imagemagick_load_image): Fix pointer signedness problem by changing
3171 last arg from unsigned char * to char *. All uses changed.
3172 Also, fix a local for similar reasons.
3173 Remove unused locals. Remove locals to avoid shadowing.
3174 (fn_rsvg_handle_free): Remove; unused.
3175 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3176 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3177
3f754b86
PE
3178 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3179
2547adb1
CY
31802011-06-10 Chong Yidong <cyd@stupidchicken.com>
3181
3182 * image.c (gif_load): Fix omitted cast error introduced by
3183 2011-06-06 change.
3184
2c8e37d4
MR
31852011-06-10 Martin Rudalics <rudalics@gmx.at>
3186
3187 * window.h (resize_proportionally, orig_total_lines)
3188 (orig_top_line): Remove from window structure.
3189 (set_window_height, set_window_width, change_window_heights)
3190 (Fdelete_window): Remove prototypes.
3191 (resize_frame_windows): Remove duplicate declaration.
3192
440a42e3
EZ
31932011-06-10 Eli Zaretskii <eliz@gnu.org>
3194
3195 * window.h (resize_frame_windows, resize_window_check)
3196 (delete_deletable_window, resize_root_window)
3197 (resize_frame_windows): Declare prototypes.
3198
3199 * window.c (resize_window_apply): Make definition be "static" to
3200 match the prototype.
3201
562dd5e9
MR
32022011-06-10 Martin Rudalics <rudalics@gmx.at>
3203
3204 * window.c: Remove declarations of Qwindow_size_fixed,
3205 window_min_size_1, window_min_size_2, window_min_size,
3206 size_window, window_fixed_size_p, enlarge_window, delete_window.
3207 Remove static from declaration of Qdelete_window, it's
3208 temporarily needed by Fbury_buffer.
3209 (replace_window): Don't assign orig_top_line and
3210 orig_total_lines.
3211 (Fdelete_window, delete_window): Remove. Window deletion is
3212 handled by window.el.
640c8776
SM
3213 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3214 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3215 (Fdelete_other_windows): Remove. Deleting other windows is
3216 handled by window.el.
3217 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3218 handled in window.el.
3219 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3220 Window minimum sizes are handled in window.el.
3221 (shrink_windows, size_window, set_window_height)
3222 (set_window_width, change_window_heights, window_height)
3223 (window_width, CURBEG, CURSIZE, enlarge_window)
3224 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3225 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3226 handled in window.el.
3227 (make_dummy_parent): Rename to make_parent_window and give it a
3228 second argument horflag.
3229 (make_window): Don't set resize_proportionally any more.
3230 (Fsplit_window): Remove. Windows are split in window.el.
3231 (save_restore_action, save_restore_orig_size)
3232 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3233 Resize mini windows in window.el.
3234 (grow_mini_window, shrink_mini_window): Implement by calling
3235 Qresize_root_window_vertically, resize_window_check and
3236 resize_window_apply.
640c8776
SM
3237 (saved_window, Fset_window_configuration, save_window_save):
3238 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3239 resize_proportionally.
3240 (window_min_height, window_min_width): Move to window.el.
3241 (keys_of_window): Move bindings for delete-other-windows,
3242 split-window, delete-window and enlarge-window to window.el.
3243
3244 * buffer.c: Temporarily extern Qdelete_window.
3245 (Fbury_buffer): Temporarily call Qdelete_window instead of
3246 Fdelete_window (Fbury_buffer will move to window.el soon).
3247
3248 * frame.c (set_menu_bar_lines_1): Remove code handling
3249 orig_top_line and orig_total_lines.
3250
3251 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3252 set_window_height but set heights directly.
3253 (change_frame_size_1): Use resize_frame_windows.
3254
3255 * xdisp.c (init_xdisp): Don't use set_window_height but set
3256 heights directly.
3257
640c8776
SM
3258 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3259 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3260 run_window_configuration_change_hook.
3261
3262 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3263 instead of change_window_heights and run
3264 run_window_configuration_change_hook.
3265
1a13852e
MR
32662011-06-09 Martin Rudalics <rudalics@gmx.at>
3267
3268 * window.c (replace_window): Rename second argument REPLACEMENT to
3269 NEW. New third argument SETFLAG. Rewrite.
3270 (delete_window, make_dummy_parent): Call replace_window with
3271 third argument 1.
3272 (window_list_1): Move down in code.
3273 (run_window_configuration_change_hook): Move set_buffer part
3274 before select_frame_norecord part in order to unwind correctly.
3275 Rename count1 to count.
3276 (recombine_windows, delete_deletable_window, resize_root_window)
3277 (Fdelete_other_windows_internal)
3278 (Frun_window_configuration_change_hook, make_parent_window)
3279 (resize_window_check, resize_window_apply, Fresize_window_apply)
3280 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3281 (Fdelete_window_internal, Fresize_mini_window_internal):
3282 New functions.
1a13852e
MR
3283 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3284
f3d1777e
MR
32852011-06-08 Martin Rudalics <rudalics@gmx.at>
3286
496e208e
MR
3287 * window.h (window): Add some new members to window structure -
3288 normal_lines, normal_cols, new_total, new_normal, clone_number,
3289 splits, nest, prev_buffers, next_buffers.
3290 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3291 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3292
f3d1777e
MR
3293 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3294 Remove.
496e208e
MR
3295 (make_dummy_parent): Set new members of windows structure.
3296 (make_window): Move down in code. Handle new members of window
3297 structure.
3298 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3299 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3300 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3301 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3302 (Fset_window_next_buffers, Fset_window_clone_number):
3303 New functions.
496e208e
MR
3304 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3305 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3306 Doc-string fixes.
3307 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3308 Argument WINDOW can be now internal window too.
3309 (Fwindow_use_time): Move up in code.
3310 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3311 Rewrite doc-string.
3312 (Fset_window_configuration, saved_window)
3313 (Fcurrent_window_configuration, save_window_save): Handle new
3314 members of window structure.
b9e809c2
MR
3315 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3316 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3317 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3318 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3319 Qget_mru_window, Qresize_root_window,
3320 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3321 Qauto_buffer_name; staticpro them.
f3d1777e 3322
abde8f8c
MR
33232011-06-07 Martin Rudalics <rudalics@gmx.at>
3324
3325 * window.c (Fwindow_total_size, Fwindow_left_column)
3326 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3327 (Fwindow_list_1): New functions.
3328 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3329 (Fwindow_width, Fscroll_left, Fscroll_right):
3330 Use window_body_cols instead of window_box_text_cols.
3331 (delete_window, Fset_window_configuration):
3332 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3333 (delete_all_subwindows): Take a window as argument and not a
3334 structure. Rewrite.
190b47e6
MR
3335 (window_loop): Remove handling of GET_LRU_WINDOW and
3336 GET_LARGEST_WINDOW.
3337 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3338
3339 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3340 window_box_text_cols. delete_all_subwindows now takes a
3341 Lisp_Object as argument.
abde8f8c 3342
640c8776
SM
3343 * indent.c (compute_motion, Fcompute_motion):
3344 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3345
fa8a67e6
MR
3346 * frame.c (delete_frame): Call delete_all_subwindows with root
3347 window as argument.
3348
a54e3482
DC
33492011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3350
3351 * fns.c (Fputhash): Document return value.
3352
60002bf5
CY
33532011-06-06 Chong Yidong <cyd@stupidchicken.com>
3354
3355 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3356
0c671da6 33572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3358
b862a52a 3359 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3360
be44ca6c
PE
3361 Check for overflow when converting integer to cons and back.
3362 * charset.c (Fdefine_charset_internal, Fdecode_char):
3363 Use cons_to_unsigned to catch overflow.
3364 (Fencode_char): Use INTEGER_TO_CONS.
3365 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3366 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3367 * data.c (long_to_cons, cons_to_long): Remove.
3368 (cons_to_unsigned, cons_to_signed): New functions.
3369 These signal an error for invalid or out-of-range values.
3370 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3371 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3372 * font.c (Ffont_variation_glyphs):
3373 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3374 * lisp.h: Include <intprops.h>.
3375 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3376 (cons_to_signed, cons_to_unsigned): New decls.
3377 (long_to_cons, cons_to_long): Remove decls.
3378 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3379 (Fprimitive_undo): Use CONS_TO_INTEGER.
3380 * xfns.c (Fx_window_property): Likewise.
3381 * xselect.c: Include <limits.h>.
3382 (x_own_selection, selection_data_to_lisp_data):
3383 Use INTEGER_TO_CONS.
3384 (x_handle_selection_request, x_handle_selection_clear)
3385 (x_get_foreign_selection, Fx_disown_selection_internal)
3386 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3387 (lisp_data_to_selection_data): Use cons_to_unsigned.
3388 (x_fill_property_data): Use cons_to_signed.
3389 Report values out of range.
3390
d1f3d2af
PE
3391 Check for buffer and string overflow more precisely.
3392 * buffer.h (BUF_BYTES_MAX): New macro.
3393 * lisp.h (STRING_BYTES_MAX): New macro.
3394 * alloc.c (Fmake_string):
3395 * character.c (string_escape_byte8):
3396 * coding.c (coding_alloc_by_realloc):
3397 * doprnt.c (doprnt):
3398 * editfns.c (Fformat):
3399 * eval.c (verror):
3400 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3401 since they may not be the same number.
3402 * editfns.c (Finsert_char):
3403 * fileio.c (Finsert_file_contents):
3404 Likewise for BUF_BYTES_MAX.
3405
dd52fcea
PE
3406 * image.c: Use ptrdiff_t, not int, for sizes.
3407 (slurp_file): Switch from int to ptrdiff_t.
3408 All uses changed.
3409 (slurp_file): Check that file size fits in both size_t (for
3410 malloc) and ptrdiff_t (for sanity and safety).
3411
7f9bbdbb
PE
3412 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3413 if b->modtime has its maximal value.
3414
dfe18f82
PE
3415 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3416
84acfcf0
PE
3417 Don't assume time_t can fit into int.
3418 * buffer.h (struct buffer.modtime): Now time_t, not int.
3419 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3420 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3421
ccd9a01a
PE
3422 Minor fixes for signed vs unsigned integers.
3423 * character.h (MAYBE_UNIFY_CHAR):
3424 * charset.c (maybe_unify_char):
3425 * keyboard.c (read_char, reorder_modifiers):
3426 XINT -> XFASTINT, since the integer must be nonnegative.
3427 * ftfont.c (ftfont_spec_pattern):
3428 * keymap.c (access_keymap, silly_event_symbol_error):
3429 XUINT -> XFASTINT, since the integer must be nonnegative.
3430 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3431 since it makes no difference and we prefer signed.
3432 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3433 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3434 nonnegative.
3435
d6d100dd
SM
34362011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3437
3438 * window.h (Fwindow_frame): Declare.
3439
2b6148e4
PE
34402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3443 (SPARE_MEMORY): Always define.
3444 (LARGE_REQUEST): Remove.
3445 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3446
f230ecc9
MR
34472011-06-06 Martin Rudalics <rudalics@gmx.at>
3448
727e958e
MR
3449 * lisp.h: Move EXFUNS for Fframe_root_window,
3450 Fframe_first_window and Fset_frame_selected_window to window.h.
3451
3452 * window.h: Move EXFUNS for Fframe_root_window,
3453 Fframe_first_window and Fset_frame_selected_window here from
3454 lisp.h.
3455
3456 * frame.c (Fwindow_frame, Fframe_first_window)
3457 (Fframe_root_window, Fframe_selected_window)
3458 (Fset_frame_selected_window): Move to window.c.
3459 (Factive_minibuffer_window): Move to minibuf.c.
3460 (Fother_visible_frames_p): New function.
3461
3462 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3463
f230ecc9
MR
3464 * window.c (decode_window, decode_any_window): Move up in code.
3465 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3466 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3467 (Fwindow_buffer): Move up and rewrite doc-string.
3468 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3469 (Fwindow_prev): New functions.
727e958e
MR
3470 (Fwindow_frame): Move here from frame.c. Accept any window as
3471 argument.
3472 (Fframe_root_window, Fframe_first_window)
3473 (Fframe_selected_window): Move here from frame.c. Accept frame
3474 or arbitrary window as argument. Update doc-strings.
3475 (Fminibuffer_window): Move up in code.
3476 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3477 (Fset_frame_selected_window): Move here from frame.c.
3478 Marginal rewrite.
727e958e
MR
3479 (Fselected_window, select_window, Fselect_window): Move up in
3480 code. Minor doc-string fixes.
f230ecc9 3481
4d09bcf6
PE
34822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3483
3484 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3485 Do not assume that spare memory exists; that assumption is valid
3486 only if SYSTEM_MALLOC.
3487 (LARGE_REQUEST): New macro, so that the issue of large requests
3488 is separated from the issue of spare memory.
3489
810928a2
AS
34902011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3491
172418ad
AS
3492 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3493 format. (Bug#8806)
3494
43f862f7
AS
3495 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3496
810928a2
AS
3497 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3498 before statements.
3499
a059fe24
JD
35002011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3501
3502 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3503
3504 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3505
3506 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3507 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3508
989bf368
JB
35092011-06-05 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3512
4b80f674
CY
35132011-06-04 Chong Yidong <cyd@stupidchicken.com>
3514
3515 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3516 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3517 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3518 New error handlers.
4b80f674
CY
3519 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3520 Obey Vx_select_enable_clipboard_manager. Catch errors in
3521 x_clipboard_manager_save (Bug#8779).
3522 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3523 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3524
99a33b77 35252011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3526
3527 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3528
99a33b77 35292011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3530
3531 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3532 in the current matrix if keep_current_p is non-zero.
3533
8264569d
EZ
35342011-06-04 Eli Zaretskii <eliz@gnu.org>
3535
3536 * bidi.c (bidi_level_of_next_char): Fix last change.
3537
57f97249
EZ
35382011-06-03 Eli Zaretskii <eliz@gnu.org>
3539
fec2107c 3540 Support bidi reordering of text covered by display properties.
57f97249 3541
fec2107c
EZ
3542 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3543 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3544 (bidi_cache_search, bidi_cache_iterator_state)
3545 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3546 (bidi_level_of_next_char, bidi_move_to_visually_next):
3547 Support character positions inside a run of characters covered by a
fec2107c
EZ
3548 display string.
3549 (bidi_paragraph_init, bidi_resolve_explicit_1)
3550 (bidi_level_of_next_char): Call bidi_fetch_char and
3551 bidi_fetch_char_advance instead of FETCH_CHAR and
3552 FETCH_CHAR_ADVANCE.
3553 (bidi_init_it): Initialize new members.
3554 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3555 definitions.
3556 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3557 instead of using explicit *_CHAR codes.
d6d100dd
SM
3558 (bidi_resolve_explicit, bidi_resolve_weak):
3559 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3560 bidirectional text is supported only in multibyte buffers.
3561 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3562 it to initialize the frame_window_p member of struct bidi_it.
3563 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3564 (bidi_resolve_explicit, bidi_resolve_weak)
3565 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3566 bidi_it->nchars is non-positive.
3567 (bidi_level_of_next_char): Don't try to lookup the cache for the
3568 next/previous character if nothing is cached there yet, or if we
3569 were just reseat()'ed to a new position.
c40e2fb2 3570
0e14fe90
EZ
3571 * xdisp.c (set_cursor_from_row): Set start and stop points
3572 according to the row's direction when priming the loop that looks
3573 for the glyph on which to display cursor.
3574 (single_display_spec_intangible_p): Function deleted.
3575 (display_prop_intangible_p): Reimplement to call
3576 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3577 Accept 3 additional arguments needed by handle_display_spec.
3578 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3579 values: lists, `(when COND...)' forms, etc.
3580 (single_display_spec_string_p): Support property values that are
3581 lists with the argument STRING its top-level element.
3582 (display_prop_string_p): Fix the condition for processing a
3583 property that is a list to be consistent with handle_display_spec.
fec2107c 3584 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3585 last portion of handle_display_prop.
3586 (compute_display_string_pos): Accept additional argument
3587 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3588 value of a `display' property is a "replacing spec".
3589 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3590 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3591 the display property, but just return a value indicating whether
3592 the display property will replace the characters it covers.
3593 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3594 frame_window_p members of struct bidi_it.
d6d100dd
SM
3595 (compute_display_string_pos, compute_display_string_end):
3596 New functions.
fec2107c
EZ
3597 (push_it): Accept second argument POSITION, where pop_it should
3598 jump to continue iteration.
3599 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3600
fec2107c
EZ
3601 * keyboard.c (adjust_point_for_property): Adjust the call to
3602 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3603
3604 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3605 (bidi_init_it): Update prototypes.
3606 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3607 (compute_display_string_pos, compute_display_string_end):
3608 Declare prototypes.
fec2107c
EZ
3609 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3610 EMACS_INT.
fc6f18ce 3611
40087514 36122011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3613
57f53182
PE
3614 Malloc failure behavior now depends on size of allocation.
3615 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3616 * lisp.h: Change signatures accordingly.
3617 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3618 All callers changed. (Bug#8762)
3619
3620 * gnutls.c: Use Emacs's memory allocators.
3621 Without this change, the gnutls library would invoke malloc etc.
3622 directly, which causes problems on non-SYNC_INPUT hosts, and which
3623 runs afoul of improving memory_full behavior. (Bug#8761)
3624 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3625 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3626 xfree instead of the default malloc, realloc, free.
3627 (Fgnutls_boot): No need to check for memory allocation failure,
3628 since xmalloc does that for us.
3629
ac32cd99 3630 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3631 * category.c (hash_get_category_set):
3632 * ccl.c (ccl_driver):
3633 * charset.c (Fdefine_charset_internal):
3634 * charset.h (struct charset.hash_index):
3635 * composite.c (get_composition_id, gstring_lookup_cache)
3636 (composition_gstring_put_cache):
3637 * composite.h (struct composition.hash_index):
3638 * dispextern.h (struct image.hash):
3639 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3640 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3641 (hashfn_equal, hashfn_user_defined, make_hash_table)
3642 (maybe_resize_hash_table, hash_lookup, hash_put)
3643 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3644 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3645 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3646 * image.c (make_image, search_image_cache, lookup_image)
3647 (xpm_put_color_table_h):
3648 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3649 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3650 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3651 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3652 * alloc.c (allocate_vectorlike):
3653 Check for overflow in vector size calculations.
3654 * ccl.c (ccl_driver):
3655 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3656 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3657 need to be updated by these changes.
40087514
PE
3658 * fns.c (make_hash_table, maybe_resize_hash_table):
3659 Check for integer overflow with large hash tables.
0de4bb68
PE
3660 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3661 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3662 (SXHASH_REDUCE): New macro.
3663 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3664 Use it instead of discarding useful hash info with large hash values.
3665 (sxhash_float): New function.
3666 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3667 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3668 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3669 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3670 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3671 Adjust signatures to match updated version of code.
3672 (consing_since_gc): Now EMACS_INT, since a single hash table can
3673 use more than INT_MAX bytes.
3674
698d32e2
DN
36752011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3676
3677 Make it possible to build with GCC-4.6+ -O2 -flto.
3678
3679 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3680
fd6fa53f
SM
36812011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3682
3683 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3684 Call minibuffer-inactive-mode.
3685
864db017
JB
36862011-05-31 Juanma Barranquero <lekktu@gmail.com>
3687
3688 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3689 Update dependencies.
3690
2ad0baf4
DN
36912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3692
3693 * data.c (init_data): Remove code for UTS, this system is not
3694 supported anymore.
3695
4fcc2638
DN
36962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3697
3698 Don't force ./temacs to start in terminal mode.
3699
3700 * frame.c (make_initial_frame): Initialize faces in all cases, not
3701 only when CANNOT_DUMP is defined.
3702 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3703
c56e0fd5
DN
37042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3705
3706 * dispnew.c (add_window_display_history): Use const for the string
3707 pointer. Remove declaration, not needed.
3708
333d54da 37092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3710
55d4c1b2 3711 Use 'inline', not 'INLINE'.
333d54da 3712 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3713 * alloc.c, fontset.c (INLINE): Remove.
3714 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3715 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3716 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3717 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3718 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3719
738db178
DN
37202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3721
3722 Make it possible to run ./temacs.
3723
3724 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3725 syms_of_callproc does the same thing. Remove test for
3726 "initialized", do it in the caller.
3727 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3728
620c53a6
SM
37292011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3730
3731 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3732 (read_minibuf): Use get_minibuffer.
3733 (syms_of_minibuf): Use DEFSYM.
3734 (Qmetadata): New var.
3735 * data.c (Qbuffer): Don't make it static.
3736 (syms_of_data): Use DEFSYM.
3737
e003a292
PE
37382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3741 (CCL_CODE_MIN): New macro.
3742
ed008a6d
PE
37432011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3744
3687c2ef
PE
3745 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3746
ed008a6d
PE
3747 * eval.c (Qdebug): Now static.
3748 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3749 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3750 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3751
d66c4c7c
CY
37522011-05-29 Chong Yidong <cyd@stupidchicken.com>
3753
3754 * image.c: Various fixes to ImageMagick code comments.
3755 (Fimagemagick_types): Doc fix.
3756
5fbc2025
PE
37572011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3758
0196f88a
PE
3759 Minor fixes prompted by GCC 4.6.0 warnings.
3760
3761 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3762
5fbc2025
PE
3763 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3764 (x_clipboard_manager_save_all): Move extern decl to ...
3765 * xterm.h: ... here, so that it can be checked for consistency.
3766
1dd3c2d9
CY
37672011-05-29 Chong Yidong <cyd@stupidchicken.com>
3768
3769 * xselect.c (x_clipboard_manager_save_frame)
3770 (x_clipboard_manager_save_all): New functions.
3771 (Fx_clipboard_manager_save): Lisp function deleted.
3772
3773 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3774 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3775
3776 * xterm.h: Update prototype.
3777
5ba6571d
WX
37782011-05-28 William Xu <william.xwl@gmail.com>
3779
3780 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3781 exiting (Bug#8239).
3782
3eaff834
JM
37832011-05-28 Jim Meyering <meyering@redhat.com>
3784
e1900994 3785 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3786 * fns.c (to_uchar): Define.
3787 (crypto_hash_function): Use it to convert some newly-signed
3788 variables to unsigned, to avoid sign-extension bugs. For example,
3789 without this change, (md5 "truc") would evaluate to
3790 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3791 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3792 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3793
0f6990a7
PE
37942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3795
3796 Integer overflow fixes.
c8a9ca5a 3797
08686060
PE
3798 * dbusbind.c: Serial number integer overflow fixes.
3799 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3800 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3801 to hold a serial number that is too large for a fixnum.
3802 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3803 Check for serial numbers out of range. Decode any serial number
59568bf0 3804 that was so large that it became a float. (Bug#8722)
08686060 3805
2d1fc3c7
PE
3806 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3807 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3808 Use XFASTINT rather than XUINT when numbers are nonnegative.
3809 (xd_append_arg, Fdbus_method_return_internal):
3810 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3811 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3812 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3813 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3814 (Bug#8722)
2d1fc3c7 3815
c8a9ca5a
PE
3816 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3817
519e1d69
PE
3818 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3819
30569699
PE
3820 ccl: add integer overflow checks
3821 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3822 (IN_INT_RANGE): New macros.
3823 (ccl_driver): Use them to check for integer overflow when
3824 decoding a CCL program. Many of the new checks are whether XINT (x)
3825 fits in int; it doesn't always, on 64-bit hosts. The new version
3826 doesn't catch all possible integer overflows, but it's an
847044ea 3827 improvement. (Bug#8719)
30569699 3828
c11285dc
PE
3829 * alloc.c (make_event_array): Use XINT, not XUINT.
3830 There's no need for unsigned here.
3831
fdccd48e
PE
3832 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3833 This follows up to the 2011-05-06 change that substituted uintptr_t
3834 for EMACS_INT. This case wasn't caught back then.
3835
37910ab2
PE
3836 Rework Fformat to avoid integer overflow issues.
3837 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3838 now (part of C89). Include <verify.h>.
3839 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3840 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3841 (Fformat): Avoid the prepass trying to compute sizes; it was only
3842 approximate and thus did not catch overflow reliably. Instead, walk
3843 through the format just once, formatting and computing sizes as we go,
3844 checking for integer overflow at every step, and allocating a larger
3845 buffer as needed. Keep track separately whether the format is
3846 multibyte. Keep only the most-recently calculated precision, rather
3847 than them all. Record whether each argument has been converted to
3848 string. Use EMACS_INT, not int, for byte and char and arg counts.
3849 Support field widths and precisions larger than INT_MAX. Avoid
3850 sprintf's undefined behavior with conversion specifications such as %#d
3851 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3852 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3853 formatting out-of-range floating point numbers with int
9173deec 3854 formats. (Bug#8668)
37910ab2 3855
2e6578fb
PE
3856 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3857
0ae6bdee
PE
3858 * data.c: Avoid integer truncation in expressions involving floats.
3859 * data.c: Include <intprops.h>.
3860 (arith_driver): When there's an integer overflow in an expression
3861 involving floating point, convert the integers to floating point
3862 so that the resulting value does not suffer from catastrophic
3863 integer truncation. For example, on a 64-bit host (* 4
3864 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3865 Do not rely on undefined behavior after integer overflow.
3866
de883a70
PE
3867 merge count_size_as_multibyte, parse_str_to_multibyte
3868 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3869 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3870 Check for integer overflow.
3871 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3872 since it's now a duplicate of the other. This is more of
3873 a character than a buffer op, so better that it's in character.c.
3874 * fns.c, print.c: Adjust to above changes.
3875
2ff916cb
PE
38762011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3877
3878 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3879
f1b54466
PE
38802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3881
fb1ac845
PE
3882 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3883 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3884 (x_clipboard_manager_save): Now static.
3885 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3886
f1b54466
PE
3887 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3888 (crypto_hash_function): Now static.
3889 Fix pointer signedness problems. Avoid unnecessary initializations.
3890
a9f737ee
CY
38912011-05-27 Chong Yidong <cyd@stupidchicken.com>
3892
3893 * termhooks.h (Vselection_alist): Make it terminal-local.
3894
3895 * terminal.c (create_terminal): Initialize it.
3896
3897 * xselect.c: Support for clipboard managers.
3898 (Vselection_alist): Move to termhooks.h as terminal-local var.
3899 (LOCAL_SELECTION): New macro.
3900 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3901 (symbol_to_x_atom): Remove gratuitous arg.
3902 (x_handle_selection_request, lisp_data_to_selection_data)
3903 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3904 (x_own_selection, x_get_local_selection, x_convert_selection):
3905 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3906 (some_frame_on_display): Delete unused function.
3907 (Fx_own_selection_internal, Fx_get_selection_internal)
3908 (Fx_disown_selection_internal, Fx_selection_owner_p)
3909 (Fx_selection_exists_p): New optional frame arg.
3910 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3911 (x_handle_selection_clear): Don't treat other terminals with the
3912 same keyboard specially. Use the terminal-local Vselection_alist.
3913 (x_clear_frame_selections): Use Frun_hook_with_args.
3914
3915 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3916
3917 * xterm.h: Add support for those atoms.
3918
e067f0c1
CY
39192011-05-26 Chong Yidong <cyd@stupidchicken.com>
3920
3921 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3922 (converted_selections, conversion_fail_tag): New global variables.
3923 (x_selection_request_lisp_error): Free the above.
3924 (x_get_local_selection): Remove unnecessary code.
3925 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3926 of converted selections stored in converted_selections.
3927 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3928 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3929 (x_convert_selection): New function.
3930 (x_handle_selection_event): Simplify.
3931 (x_get_foreign_selection): Don't ignore incoming requests while
3932 waiting for an answer; this will fail when we implement
3933 SAVE_TARGETS, and seems unnecessary anyway.
3934 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3935 (Vx_sent_selection_functions): Doc fix.
3936
0f4aebc0
LL
39372011-05-26 Leo Liu <sdl.web@gmail.com>
3938
3939 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3940
e61124cd
YM
39412011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3942
3943 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3944
3945 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3946 for fringe update if it has periodic bitmap.
ac389d0c 3947 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3948 and fringe_bitmap_periodic_p.
3949
3950 * fringe.c (get_fringe_bitmap_data): New function.
3951 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3952 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3953 row. Mark glyph row for fringe update if periodicity changed.
3954
3955 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3956 for fringe update unless it has periodic bitmap.
3957
f16d9837
KH
39582011-05-25 Kenichi Handa <handa@m17n.org>
3959
3960 * xdisp.c (get_next_display_element): Set correct it->face_id for
3961 a static composition.
3962
e1b90ef6
LL
39632011-05-24 Leo Liu <sdl.web@gmail.com>
3964
3965 * deps.mk (fns.o):
3966 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3967
3968 * fns.c (crypto_hash_function, Fsha1): New function.
3969 (Fmd5): Use crypto_hash_function.
3970 (syms_of_fns): Add Ssha1.
3971
7400048f
PE
39722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 * gnutls.c: Remove unused macros.
3975 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3976 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3977 Remove macros that are defined and never used.
3978 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3979
abb71cf4
CY
39802011-05-22 Chong Yidong <cyd@stupidchicken.com>
3981
3982 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3983 (Fx_get_selection_internal): Minor cleanup.
3984 (Fx_own_selection_internal): Rename arguments for consistency with
3985 select.el.
3986
6307db39
PE
39872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3990
f3d4e0a4
CY
39912011-05-22 Chong Yidong <cyd@stupidchicken.com>
3992
3993 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3994
4d8ade89
YM
39952011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3996
3997 * dispnew.c (scrolling_window): Don't exclude the case that the
3998 last enabled row in the desired matrix touches the bottom boundary.
3999
32078c8d
GM
40002011-05-21 Glenn Morris <rgm@gnu.org>
4001
4002 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4003 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4004 and add some more files.
32078c8d 4005
7285dc67
EZ
40062011-05-20 Eli Zaretskii <eliz@gnu.org>
4007
4008 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4009 report_file_error introduced by the change from 2011-05-07.
4010
89d1bd22
PE
40112011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4012
4013 * systime.h (Time): Define only if emacs is defined.
4014 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4015 where the include path doesn't have X11/X.h by default. See
4016 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4017
e23640bb 40182011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4019
4020 * composite.c (find_automatic_composition): Fix previous change.
4021
b9704ad9
GM
40222011-05-20 Glenn Morris <rgm@gnu.org>
4023
4024 * lisp.mk: New file, split from Makefile.in.
4025 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4026 (shortlisp): Remove.
4027 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4028
4a720484
GM
40292011-05-19 Glenn Morris <rgm@gnu.org>
4030
4031 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4032 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4033 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4034 (lisp): Set the order to that of loadup.el.
4035 (shortlisp): Make it a copy of $lisp.
4036 (SOME_MACHINE_LISP): Remove.
4037 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4038 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4039
a28d4396
KH
40402011-05-18 Kenichi Handa <handa@m17n.org>
4041
4042 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4043 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4044 (find_automatic_composition): Mostly rewrite for efficiency.
4045
a2b1fa8e
JB
40462011-05-18 Juanma Barranquero <lekktu@gmail.com>
4047
4048 * makefile.w32-in: Update dependencies.
4049
8e1f5610
CS
40502011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4051
4052 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4053 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4054
7025ee00 40552011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4056
cdfa6eab
PE
4057 Fix some integer overflow issues, such as string length overflow.
4058
06d6db33
PE
4059 * insdel.c (count_size_as_multibyte): Check for string overflow.
4060
2b4560a8
PE
4061 * character.c (lisp_string_width): Check for string overflow.
4062 Use EMACS_INT, not int, for string indexes and lengths; in
4063 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4064 the resulting string length overflows an EMACS_INT; instead,
4065 report a string overflow if no precision given. When checking for
4066 precision exhaustion, use a check that cannot possibly have
4067 integer overflow. (Bug#8675)
4068 * character.h (lisp_string_width): Adjust to new signature.
4069
cb93f9be
PE
4070 * alloc.c (string_overflow): New function.
4071 (Fmake_string): Use it. This doesn't change behavior, but saves
4072 a few bytes and will simplify future changes.
4073 * character.c (string_escape_byte8): Likewise.
4074 * lisp.h (string_overflow): New decl.
4075
1a1f3366
PE
4076 Fixups, following up to the user-interface timestamp change.
4077 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4078 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4079 * msdos.c (mouse_get_pos): Likewise.
4080 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4081 * w32gui.h (Time): Define by including "systime.h" rather than by
4082 declaring it ourselves. (Bug#8664)
4083
d4e3e4d3
PE
4084 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4085 * image.c (clear_image_cache): Likewise.
4086
f6a24d19
PE
4087 * term.c (term_mouse_position): Don't assume time_t wraparound.
4088
08dc5ae6
PE
4089 Be more systematic about user-interface timestamps.
4090 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4091 and sometimes 'EMACS_UINT', to represent these timestamps.
4092 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4093 This makes the code easier to follow, and makes it easier to catch
4094 integer overflow bugs such as Bug#8664.
4095 * frame.c (Fmouse_position, Fmouse_pixel_position):
4096 Use Time, not unsigned long, for user-interface timestamps.
4097 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4098 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4099 * keyboard.h (last_event_timestamp): Likewise.
4100 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4101 * menu.h (xmenu_show): Likewise.
4102 * term.c (term_mouse_position): Likewise.
4103 * termhooks.h (struct input_event.timestamp): Likewise.
4104 (struct terminal.mouse_position_hook): Likewise.
4105 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4106 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4107 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4108 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4109 what it was before.
4110 * menu.h, termhooks.h: Include "systime.h", for Time.
4111
8e55734a
PE
4112 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4113 Don't assume that the difference between two unsigned long values
4114 can fit into an integer. At this point, we know button_down_time
4115 <= event->timestamp, so the difference must be nonnegative, so
4116 there's no need to cast the result if double-click-time is
4117 nonnegative, as it should be; check that it's nonnegative, just in
4118 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4119 apart (about 25 days). (Bug#8664)
8e55734a 4120
841f1b75 4121 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4122 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4123
3e26f69c
PE
4124 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4125 that always fit in int. Use a sentinel instead of a counter, to
4126 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4127 * frame.h (struct frame): Use int for menu_bar_items_used
4128 instead of EMACS_INT, since it always fits in int.
3e26f69c 4129
5cc152c0
PE
4130 * menu.c (grow_menu_items): Check for int overflow.
4131
d89eb65e
PE
4132 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4133
5235bd3e
PE
4134 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4135 Before, the code was not consistent. These values cannot exceed
4136 2**31 - 1 so there's no need to make them unsigned.
4137 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4138 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4139 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4140 as modifiers.
4141 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4142
bc827e23
PE
4143 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4144 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4145 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4146 presumably because the widths might not match.
4147
78eb494e
PE
4148 * window.c (size_window): Avoid needless test at loop start.
4149
04f2d78b
CB
41502011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4151
4152 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4153
d2fc7e3d 41542011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4155
4156 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4157
d2fc7e3d 41582011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4159
4160 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4161 `width' to `bar_area_x' and `bar_area_width', respectively.
4162 (x_scroll_run): Take account of fringe background extension.
4163
04f2d78b
CB
4164 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4165 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4166 `bar_area_width', respectively.
4167 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4168 background extension.
4169
79b70037
GM
41702011-05-10 Jim Meyering <meyering@redhat.com>
4171
4172 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4173
2f142cc5
JB
41742011-05-10 Juanma Barranquero <lekktu@gmail.com>
4175
4176 * image.c (Finit_image_library): Return t for built-in image types,
4177 like pbm and xbm. (Bug#8640)
4178
57679c86
AS
41792011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4180
4181 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4182
888c9e86
EZ
41832011-05-07 Eli Zaretskii <eliz@gnu.org>
4184
b0512a1d
EZ
4185 * w32console.c (Fset_screen_color): Doc fix.
4186 (Fget_screen_color): New function.
4187 (syms_of_ntterm): Defsubr it.
4188
7285dc67
EZ
4189 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4190 unlink the temporary file if Fcall_process didn't create it in the
4191 first place.
4192 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4193 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4194 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4195 cue to call_process_cleanup not to close that handle.
4196
4d3fcc8e
BK
41972011-05-07 Ben Key <bkey76@gmail.com>
4198
4199 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4200 one of two shell specific rules, either bootstrap-temacs-CMD or
4201 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4202 to the previous implementation of the bootstrap-temacs rule.
4203 The bootstrap-temacs-CMD rule is similar to the previous
4204 implementation of the bootstrap-temacs rule except that it
4205 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4206 variable.
4207
4208 These changes, along with some changes to nt/configure.bat,
4209 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4210 earlier fix to add support for --cflags and --ldflags options
4211 that include quotes so that it works whether make uses cmd or
4212 sh as the shell.
4213
b4289b64
MA
42142011-05-06 Michael Albinus <michael.albinus@gmx.de>
4215
4216 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4217 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4218 is a constant.
4219 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4220 a string. Handle both cases.
4221 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4222 (Fdbus_register_method): Use Qinvalid_function.
4223
af4c0e28
JB
42242011-05-06 Juanma Barranquero <lekktu@gmail.com>
4225
4226 * makefile.w32-in: Update dependencies.
4227 (LISP_H): Add inttypes.h and stdin.h.
4228 (PROCESS_H): Add unistd.h.
4229
c51453d9
EZ
42302011-05-06 Eli Zaretskii <eliz@gnu.org>
4231
4232 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4233 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4234
8ff0ac3c 42352011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4236
4c4b566b
PE
4237 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4238
aab2b9b5
PE
4239 * term.c (vfatal): Remove stray call to va_end.
4240 It's not needed and the C Standard doesn't allow it here anyway.
4241
c378da0b
PE
4242 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4243 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4244
288b08c7
PE
4245 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4246 bytes.
4247
e3601888
PE
4248 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4249
db6c0e74
PE
4250 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4251
dd5963ea
PE
4252 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4253
88c9450f
PE
4254 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4255
2f9442b8
PE
4256 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4257
c032b5f8
PE
4258 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4259 * charset.c (Fdefine_charset_internal): Don't initialize
4260 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4261 32-bit int (Bug#8600).
a108c10b
PE
4262
4263 * lread.c (read_integer): Be more consistent with string-to-number.
4264 Use string_to_number to do the actual conversion; this avoids
4265 rounding errors and fixes some other screwups. Without this fix,
4266 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4267 (digit_to_number): Move earlier, for benefit of read_integer.
4268 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4269 not a digit in any supported base. (Bug#8602)
a108c10b 4270
ad5f9eea
PE
4271 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4272
aec1708a
PE
4273 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4274 to match comment at start of function. This also removes a
4275 GCC warning about overflow in a 32+64-bit port.
4276
47be4ab5
PE
4277 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4278
371cac43
PE
4279 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4280 Reported by Stefan Monnier in
4281 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4282 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4283 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4284
d01a7826
PE
4285 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4286 (EMACS_UINTPTR): Likewise, with uintptr_t.
4287
7fd47d5c
PE
4288 * lisp.h: Prefer 64-bit EMACS_INT if available.
4289 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4290 on 32-bit hosts that have 64-bit int, so that they can access
4291 large files.
122b0c86
PE
4292 However, temporarily disable this change unless the temporary
4293 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4294
8727937b
PE
4295 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4296
8ac068ac
PE
4297 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4298 This removes an assumption that EMACS_INT and long are the same
4299 width as pointers. The assumption is true for Emacs porting targets
4300 now, but we want to make other targets possible.
4301 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4302 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4303 In the rest of the code, change types of integers that hold casted
4304 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4305 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4306 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4307 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4308 No need to cast type when ORing.
4309 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4310 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4311 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4312 assume EMACS_INT is the same width as char *.
4313 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4314 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4315 Remove no-longer-needed casts.
4316 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4317 (xg_tool_bar_help_callback, xg_make_tool_item):
4318 Use EMACS_INTPTR to hold an integer
4319 that will be cast to void *; this can avoid a GCC warning
4320 if EMACS_INT is not the same width as void *.
4321 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4322 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4323 (current_message_1, set_message_1):
4324 Use a local to convert to proper width without a cast.
4325 * xmenu.c (dialog_selection_callback): Likewise.
4326
ede49d71
PE
4327 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4328 Also, don't assume VALBITS / RAND_BITS is less than 5,
4329 and don't rely on undefined behavior when shifting a 1 left into
4330 the sign bit.
4331 * lisp.h (get_random): Change signature to match.
4332
2f30ecd0
PE
4333 * lread.c (hash_string): Use size_t, not int, for hash computation.
4334 Normally we prefer signed values; but hashing is special, because
4335 it's better to use unsigned division on hash table sizes so that
4336 the remainder is nonnegative. Also, size_t is the natural width
4337 for hashing into memory. The previous code used 'int', which doesn't
4338 retain enough info to hash well into very large tables.
4339 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4340
2a866e7b
PE
4341 * dbusbind.c: Don't possibly lose pointer info when converting.
4342 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4343 Use XPNTR rather than XHASH, so that the high-order bits of
4344 the pointer aren't lost when converting through void *.
4345
51639eac
PE
4346 * eval.c (Fautoload): Don't double-shift a pointer.
4347
92394119
PE
4348 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4349
dbdb9a7c
JB
43502011-05-06 Juanma Barranquero <lekktu@gmail.com>
4351
4352 * gnutls.c (DEF_GNUTLS_FN):
4353 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4354
db7a0b4f
AS
43552011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4356
4357 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4358 marker. (Bug#8610)
4359
f7ff1b0f 43602011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4361
4362 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4363 New version that can reserve upto 2GB of heap space.
4364
f7ff1b0f 43652011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4366
4367 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4368
639c109b
TZ
43692011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4370
4371 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4372 `gnutls_certificate_set_x509_key_file'.
4373
d2127135
JB
43742011-05-05 Juanma Barranquero <lekktu@gmail.com>
4375
4376 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4377 Update dependencies.
4378
e968f4f3
JB
43792011-05-04 Juanma Barranquero <lekktu@gmail.com>
4380
4381 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4382 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4383 Remove unused parameter `fildes'.
4384 * process.c (read_process_output, send_process): Don't pass it.
4385
84d358f0
JB
43862011-05-04 Juanma Barranquero <lekktu@gmail.com>
4387
4388 Fix previous change: the library cache is defined in w32.c.
4389 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4390 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4391
0898ca10
JB
43922011-05-04 Juanma Barranquero <lekktu@gmail.com>
4393
4394 Implement dynamic loading of GnuTLS on Windows.
4395
4396 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4397 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4398 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4399 Declare.
4400
4401 * gnutls.c (Qgnutls_dll): Define.
4402 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4403 (gnutls_*): Declare function pointers.
4404 (init_gnutls_functions): New function to initialize function pointers.
4405 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4406 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4407 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4408 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4409 (emacs_gnutls_write, emacs_gnutls_read)
4410 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4411 (Fgnutls_available_p): New function.
4412 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4413 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4414 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4415
4416 * image.c: Include w32.h.
4417 (Vimage_type_cache): Delete.
4418 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4419 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4420 (w32_delayed_load): Move to w32.c.
4421
4422 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4423
4424 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4425 (w32_delayed_load): Move from image.c. When loading a library, record
4426 its filename in the :loaded-from property of the library id.
4427 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4428 Initialize and staticpro them.
4429 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4430
4431 * process.c: Include lisp.h before w32.h, not after.
4432 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4433 instead of gnutls_record_check_pending.
4434
4435 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4436
ff4de4aa
TZ
44372011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4438
4439 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4440 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4441 as passed in.
4442
abe95abb
JD
44432011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4444
4445 * xterm.c (x_set_frame_alpha): Do not set property on anything
4446 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4447
e16e55d4
JB
44482011-05-02 Juanma Barranquero <lekktu@gmail.com>
4449
4450 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4451
bafcf6a5
JB
44522011-05-02 Juanma Barranquero <lekktu@gmail.com>
4453
4454 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4455 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4456 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4457 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4458 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4459 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4460 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4461 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4462 (Qgnutls_bootprop_callbacks_verify): Make static.
4463
e7a6747f
AS
44642011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4465
19ed11ba
AS
4466 * callproc.c: Indentation fixup.
4467
e7a6747f 4468 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4469 (wait_for_termination, interruptible_wait_for_termination):
4470 Move after wait_for_termination_1.
e7a6747f 4471
1ef14cb4
LMI
44722011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4473
4474 * sysdep.c (interruptible_wait_for_termination): New function
4475 which is like wait_for_termination, but allows keyboard
4476 interruptions.
4477
4478 * callproc.c (Fcall_process): Add (:file "file") as an option for
4479 the STDOUT buffer.
4480 (Fcall_process_region): Ditto.
4481
330d880c
EZ
44822011-04-30 Eli Zaretskii <eliz@gnu.org>
4483
8db90b73
EZ
4484 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4485 rather than `XVECTOR (FOO)->size'.
4486
330d880c
EZ
4487 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4488 inttypes.h, as a gnulib replacement is used if it not available in
4489 system headers.
4490
15cbd324
EZ
44912011-04-21 Eli Zaretskii <eliz@gnu.org>
4492
4493 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4494 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4495 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4496
4497 * coding.c (coding_alloc_by_realloc): Error out if destination
4498 will grow beyond MOST_POSITIVE_FIXNUM.
4499 (decode_coding_emacs_mule): Abort if there isn't enough place in
4500 charbuf for the composition carryover bytes. Reserve an extra
4501 space for up to 2 characters produced in a loop.
4502 (decode_coding_iso_2022): Abort if there isn't enough place in
4503 charbuf for the composition carryover bytes.
4504
45052011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4506
ae940cca
EZ
4507 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4508 aborting when %lld or %lll format is passed.
4509 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4510 %llo or %llx format is passed. (Bug#8545)
4511
03ab8921
EZ
4512 * window.c (window_scroll_line_based): Use a marker instead of
4513 simple variables to record original value of point. (Bug#7952)
4514
afda1437
EZ
4515 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4516 produced by %s or %c overflows available buffer space. (Bug#8545)
4517
f76dee0c
PE
45182011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4521 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4522
fdc5744d
JB
45232011-04-28 Juanma Barranquero <lekktu@gmail.com>
4524
4525 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4526
638f053a
JB
45272011-04-28 Juanma Barranquero <lekktu@gmail.com>
4528
4529 * keyboard.c (Qdelayed_warnings_hook): Define.
4530 (command_loop_1): Run `delayed-warnings-hook'
4531 if Vdelayed_warnings_list is non-nil.
4532 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4533 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4534
d178f871
EZ
45352011-04-28 Eli Zaretskii <eliz@gnu.org>
4536
4537 * doprnt.c (doprnt): Don't return value smaller than the buffer
4538 size if the message was truncated. (Bug#8545).
4539
b124fd93
JB
45402011-04-28 Juanma Barranquero <lekktu@gmail.com>
4541
4542 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4543 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4544
e810457d
PE
45452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4546
4547 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4548
ea51cceb
JB
45492011-04-27 Juanma Barranquero <lekktu@gmail.com>
4550
4551 * makefile.w32-in: Update dependencies.
4552
94dcfacf
EZ
45532011-04-27 Eli Zaretskii <eliz@gnu.org>
4554
4555 Improve `doprnt' and its usage. (Bug#8545)
4556 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4557 `format_end'. Remove support for %l as a conversion specifier.
4558 Don't use xrealloc. Improve diagnostics when the %l size modifier
4559 is used. Update the commentary.
4560
4561 * eval.c (verror): Simplify calculation of size_t.
4562
4563 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4564 messages.
4565
f61f41d7
PE
45662011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4567
4568 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4569 change.
4570
96fb4434
PE
45712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4574 This makes this file independent of the recent pseudovector change.
4575
671875da 45762011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4577
69e9b5a3
PE
4578 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4579
b5f869a7 4580 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4581 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4582 Remove unused local.
c8926152 4583 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4584
841a1577 4585 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4586 GCC 4.6.0 optimizes based on type-based alias analysis.
4587 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4588 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4589 != &v->size, and therefore "v->size = 1; b->size = 2; return
4590 v->size;" must therefore return 1. This assumption is incorrect
4591 for Emacs, since it type-puns struct Lisp_Vector * with many other
4592 types. To fix this problem, this patch adds a new type struct
f904488f 4593 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4594 and pseudovectors, and helps optimizing compilers not get fooled
4595 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4596 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4597 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4598 the size member.
eab3844f
PE
4599 (XSETPVECTYPE): Rewrite in terms of new macro.
4600 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4601 This is a bit clearer, and further avoids the possibility of
4602 undesirable aliasing.
4603 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4604 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4605 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4606 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4607 (ASIZE): Now uses header.size rather than size.
4608 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4609 to avoid the hassle of writing XVECTOR (foo)->header.size.
4610 (struct vectorlike_header): New type.
eab3844f
PE
4611 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4612 object, to help avoid aliasing.
4613 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4614 (SUBRP): Likewise, since Lisp_Subr is a special case.
4615 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4616 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4617 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4618 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4619 changed to be "header.size" and "header.next".
4620 * buffer.h (struct buffer): Likewise.
4621 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4622 * frame.h (struct frame): Likewise.
4623 * process.h (struct Lisp_Process): Likewise.
4624 * termhooks.h (struct terminal): Likewise.
4625 * window.c (struct save_window_data, struct saved_window): Likewise.
4626 * window.h (struct window): Likewise.
4627 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4628 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4629 * buffer.c (init_buffer_once): Likewise.
4630 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4631 special case.
4632 * process.c (Fformat_network_address): Use local var for size,
4633 for brevity.
4634
0df1eac5
PE
4635 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4636
847ab9d1 4637 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4638 * data.c (atof): Remove decl; no longer used or needed.
4639 (digit_to_number): Move to lread.c.
4640 (Fstring_to_number): Use new string_to_number function, to be
4641 consistent with how the Lisp reader treats infinities and NaNs.
4642 Do not assume that floating-point numbers represent EMACS_INT
4643 without losing information; this is not true on most 64-bit hosts.
4644 Avoid double-rounding errors, by insisting on integers when
4645 parsing non-base-10 numbers, as the documentation specifies.
4646 * lisp.h (string_to_number): New decl, replacing ...
4647 (isfloat_string): Remove.
bc0a5c13 4648 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4649 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4650 appears to have been a coding error. Similarly, do not accept
4651 strings like +-1e0 as floating point numbers. Do not report
4652 overflow for integer overflows unless the base is not 10 which
4653 means we have no simple and reliable way to continue.
4654 Break out the floating-point parsing into a new
4655 function string_to_number, so that Fstring_to_number parses
4656 floating point numbers consistently with the Lisp reader.
04f2d78b 4657 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4658 (E_CHAR, EXP_INT): Remove, replacing with ...
4659 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4660 (string_to_number): New function, replacing isfloat_string.
4661 This function checks for valid syntax and produces the resulting
4662 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4663 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4664 so that overflow for non-base-10 numbers is reported only when
4665 there's no portable and simple way to convert to floating point.
452f4150 4666
67769ffc
PE
4667 * textprop.c (set_text_properties_1): Rewrite for clarity,
4668 and to avoid GCC warning about integer overflow.
4669
c20db43f
PE
4670 * intervals.h (struct interval): Use EMACS_INT for members
4671 where EMACS_UINT might cause problems. See
4672 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4673 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4674 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4675 All uses changed.
37aa2f85
PE
4676 (offset_intervals): Tell GCC not to worry about length overflow
4677 when negating a negative length.
c20db43f 4678
2538aa2f
PE
4679 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4680 (overrun_check_free): Likewise.
4681
f2d3008d
PE
4682 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4683 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4684 word size.
4685
ec8df744
PE
4686 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4687 (gnutls_make_error): Rename local to avoid shadowing.
4688 (gnutls_emacs_global_deinit): ifdef out; not used.
4689 (Fgnutls_boot): Use const for pointer to readonly storage.
4690 Comment out unused local. Fix pointer signedness problems.
4691
640ee02d
PE
4692 * lread.c (openp): Don't stuff size_t into an 'int'.
4693 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4694 about possible signed overflow.
4695
6048fb2a
PE
4696 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4697 (GDK_KEY_g): Don't define if already defined.
4698 (xg_prepare_tooltip): Avoid pointer signedness problem.
4699 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4700
fa3c87e1
PE
4701 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4702 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4703
2172544b
PE
4704 * xfns.c (Fx_window_property): Simplify a bit,
4705 to make a bit faster and to avoid GCC 4.6.0 warning.
4706 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4707
9b821a21
PE
4708 * fns.c (internal_equal): Don't assume size_t fits in int.
4709
3c616cfa
PE
4710 * alloc.c (compact_small_strings): Tighten assertion a little.
4711
c2982e87
PE
4712 Replace pEd with more-general pI, and fix some printf arg casts.
4713 * lisp.h (pI): New macro, generalizing old pEd macro to other
4714 conversion specifiers. For example, use "...%"pI"d..." rather
4715 than "...%"pEd"...".
4716 (pEd): Remove. All uses replaced with similar uses of pI.
4717 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4718 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4719 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4720 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4721 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4722 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4723 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4724 64-bit hosts.
4725 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4726 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4727 * print.c (safe_debug_print, print_object): Likewise.
4728 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4729 to int.
6f04d126
PE
4730 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4731 avoiding the 0 flag, which is not portable.
c2982e87
PE
4732 * process.c (Fmake_network_process): Use pI to avoid cast.
4733 * region-cache.c (pp_cache): Likewise.
4734 * xdisp.c (decode_mode_spec): Likewise.
4735 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4736 behavior on 64-bit hosts with printf arg.
6f04d126 4737 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4738 (x_stop_queuing_selection_requests): Likewise.
4739 (x_get_window_property): Don't truncate byte count to an 'int'
4740 when tracing.
0b432f21 4741
5e073ec7
PE
4742 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4743 here, since it parses constructs like leading '-' and spaces,
4744 which are not wanted; and it overflows with large numbers.
4745 Instead, simply match F[0-9]+, which is what is wanted anyway.
4746
36372bf9
PE
4747 * alloc.c: Remove unportable assumptions about struct layout.
4748 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4749 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4750 (allocate_vectorlike, make_pure_vector): Use the new macros,
4751 plus offsetof, to remove unportable assumptions about struct layout.
4752 These assumptions hold on all porting targets that I know of, but
4753 they are not guaranteed, they're easy to remove, and removing them
4754 makes further changes easier.
4755
0b432f21
PE
4756 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4757 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4758 (string_overrun_cookie): Now const. Use initializers that
4759 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4760 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4761 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4762 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4763 multiple of sizeof (EMACS_INT); it need not be, if
4764 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4765 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4766
895009e1
JB
47672011-04-26 Juanma Barranquero <lekktu@gmail.com>
4768
4769 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4770
6a7a1b0b
TZ
47712011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4772
4773 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4774 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4775 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4776
841a1577 47772011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4778
4779 * lisp.h (Qdebug): List symbol.
895009e1 4780 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4781 * keyboard.c (debug-on-event): New variable.
4782 (handle_user_signal): Break into debugger when debug-on-event
4783 matches the current signal symbol.
4784
f2d3ba6f
DN
47852011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4786
4787 * alloc.c (check_sblock, check_string_bytes)
4788 (check_string_free_list): Convert to standard C.
4789
42ce4c63
TZ
47902011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4791
4792 * w32.c (emacs_gnutls_push): Fix typo.
4793
825cd63c
EZ
47942011-04-25 Eli Zaretskii <eliz@gnu.org>
4795
fb11d64d
EZ
4796 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4797 "cast to pointer from integer of different size".
4798
825cd63c
EZ
4799 Improve doprnt and its use in verror. (Bug#8545)
4800 * doprnt.c (doprnt): Document the set of format control sequences
4801 supported by the function. Use SAFE_ALLOCA instead of always
4802 using `alloca'.
4803
4804 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4805 is one byte too soon. Don't use xrealloc; instead xfree and
4806 xmalloc anew.
4807
e061a11b
TZ
48082011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4809
4810 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4811 callbacks stage.
4812
4813 * gnutls.c: Renamed global_initialized to
4814 gnutls_global_initialized. Added internals for the
4815 :verify-hostname-error, :verify-error, and :verify-flags
4816 parameters of `gnutls-boot' and documented those parameters in the
4817 docstring. Start callback support.
9173deec
JB
4818 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4819 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4820 on error. Return error code.
e061a11b
TZ
4821 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4822 (emacs_gnutls_read): Likewise.
4823 (Fgnutls_boot): Return handshake error code.
4824 (emacs_gnutls_handle_error): New function.
4825 (wsaerror_to_errno): Likewise.
4826
4827 * w32.h (emacs_gnutls_pull): Add prototype.
4828 (emacs_gnutls_push): Likewise.
4829
4830 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4831 (emacs_gnutls_push): Likewise.
4832
48332011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4834
4835 * process.c (wait_reading_process_output): Check if GnuTLS
4836 buffered some data internally if no FDs are set for TLS
4837 connections.
4838
4839 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4840 (LIBS): Link to USER_LIBS.
4841 ($(BLD)/gnutls.$(0)): New target.
4842
fa6996bc
EZ
48432011-04-24 Eli Zaretskii <eliz@gnu.org>
4844
eb35682e
EZ
4845 * xdisp.c (handle_single_display_spec): Rename the
4846 display_replaced_before_p argument into display_replaced_p, to
4847 make it consistent with the commentary. Fix typos in the
4848 commentary.
4849
e2ad650c
EZ
4850 * textprop.c (syms_of_textprop): Remove dead code.
4851 (copy_text_properties): Delete obsolete commentary about an
4852 interface that was deleted long ago. Fix typos in the description
4853 of arguments.
4854
1b2de274
EZ
4855 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4856 to changes in oldXMenu/XMenu.h from 2011-04-16.
4857 <menu_help_message, prev_menu_help_message>: Constify.
4858 (IT_menu_make_room): menu->help_text is now `const char **';
4859 adjust.
4860
4861 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4862 to changes in oldXMenu/XMenu.h from 2011-04-16.
4863 (struct XMenu): Declare `help_text' `const char **'.
4864
4865 * xfaces.c <Qunspecified>: Make extern again.
4866
4867 * syntax.c: Include sys/types.h before including regex.h, as
4868 required by Posix.
4869
762b15be
EZ
4870 * doc.c (get_doc_string): Improve the format passed to `error'.
4871
4872 * doprnt.c (doprnt): Improve commentary.
4873
4874 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4875
4876 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4877 them with etags.
4878
f1052e5d
EZ
4879 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4880 changes in globals.h immediately force recompilation.
762b15be
EZ
4881 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4882 $(CURDIR)/s/ms-w32.h.
4883 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4884
fa6996bc
EZ
4885 * character.c (Fchar_direction): Function deleted.
4886 (syms_of_character): Don't defsubr it.
4887 <char-direction-table>: Deleted.
4888
e6c3da20
EZ
48892011-04-23 Eli Zaretskii <eliz@gnu.org>
4890
4891 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4892 * doprnt.c: Include limits.h.
4893 (SIZE_MAX): New macro.
04f2d78b
CB
4894 (doprnt): Return a size_t value. 2nd arg is now size_t.
4895 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4896 Improve overflow protection. Support `l' modifier for integer
4897 conversions. Support %l conversion. Don't assume an EMACS_INT
4898 argument for integer conversions and for %c.
4899
4900 * lisp.h (doprnt): Restore prototype.
4901
4902 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4903 $(SRC)/character.h.
4904
4905 * Makefile.in (base_obj): Add back doprnt.o.
4906
4907 * deps.mk (doprnt.o): Add back prerequisites.
4908 (callint.o): Depend on character.h.
4909
4910 * eval.c (internal_lisp_condition_case): Include the handler
4911 representation in the error message.
4912 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4913 when breaking from the loop.
4914
4915 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4916
4917 * callint.c (Fcall_interactively): When displaying error message
4918 about invalid control letter, pass the character's codepoint, not
4919 a pointer to its multibyte form. Improve display of the character
4920 in octal and display also its hex code.
4921
4922 * character.c (char_string): Use %x to display the (unsigned)
4923 codepoint of an invalid character, to avoid displaying a bogus
4924 negative value.
4925
4926 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4927 `error', not SYMBOL_NAME itself.
4928
4929 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4930 character arguments to `error'.
4931
4932 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4933 to `error' in error message about FINAL_CHAR argument. Make sure
4934 FINAL_CHAR is a character, and use %c when it is passed as
4935 argument to `error'.
4936
4ffd0d6b 49372011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4938
4939 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4940
4941 * w32.c: Include <time.h>.
4942 (sys_localtime): New function.
4943
4ffd0d6b 49442011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4945
4946 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4947
4ffd0d6b 4948 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4949
4ffd0d6b 49502011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4951
4ffd0d6b
GM
4952 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4953 zombies (Bug#8467).
aac0c6e3 4954
04c56954
EZ
49552011-04-19 Eli Zaretskii <eliz@gnu.org>
4956
4957 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4958 gl_state.e_property when gl_state.object is Qt.
4959
4960 * insdel.c (make_gap_larger): Remove limitation of buffer size
4961 to <= INT_MAX.
4962
16a43933
CY
49632011-04-18 Chong Yidong <cyd@stupidchicken.com>
4964
4965 * xdisp.c (lookup_glyphless_char_display)
4966 (produce_glyphless_glyph): Handle cons cell entry in
4967 glyphless-char-display.
4968 (Vglyphless_char_display): Document it.
4969
4970 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4971 glyphless-char-display.
4972
4581706e
CY
49732011-04-17 Chong Yidong <cyd@stupidchicken.com>
4974
4975 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4976
4977 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4978
4979 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4980 definition for no-X builds.
4981
4887c6e2 49822011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4983
fd35b6f9
PE
4984 Static checks with GCC 4.6.0 and non-default toolkits.
4985
5c1ccb01
PE
4986 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4987
006c5daa
PE
4988 * process.c (keyboard_bit_set): Define only if SIGIO.
4989 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4990 (send_process): Repair possible setjmp clobbering.
4991
efc736d3
PE
4992 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4993
4e2fe2e6
PE
4994 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4995
f97334a2
PE
4996 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4997
4e75f29d
PE
4998 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4999 Define only if needed.
5000
90efadd1
PE
5001 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5002 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5003 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5004
3c647824
PE
5005 * dispextern.h (struct redisplay_interface): Rename param
5006 to avoid shadowing.
e264f262 5007 * termhooks.h (struct terminal): Likewise.
761383f4 5008 * xterm.c (xembed_send_message): Likewise.
3c647824 5009
b58c5c4a
PE
5010 * insdel.c (make_gap_smaller): Define only if
5011 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5012
cad59032
PE
5013 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5014 it.
5015
c339dc2e
PE
5016 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5017 so that we aren't warned about unused symbols.
5018
91a3e27b
PE
5019 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5020
399c71d3 5021 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5022
8ffc96f5
PE
5023 * xfns.c (x_real_positions): Mark locals as initialized.
5024
eef9bc79
PE
5025 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5026
098db9dd
PE
5027 * xterm.c: Fix problems found by static analysis with other toolkits.
5028 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5029 (x_dispatch_event): Declare static if USE_GTK, and
5030 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5031 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5032 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5033 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5034 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5035
eb18f6cc
PE
5036 * xmenu.c (menu_help_callback): Pointer type fixes.
5037 Use const pointers when pointing at readonly data. Avoid pointer
5038 signedness clashes.
5039 (FALSE): Remove unused macro.
5040 (update_frame_menubar): Remove unused decl.
5041
1fe72bf8
PE
5042 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5043
60d9e1db
PE
5044 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5045 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5046 (single_menu_item): Rename local to avoid shadowing.
5047
39261c26
PE
5048 * keyboard.c (make_lispy_event): Remove unused local var.
5049
018c5e19
PE
5050 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5051 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5052
63d2b86e
PE
5053 * bitmaps: Change bitmaps from unsigned char back to the X11
5054 compatible char. Avoid the old compiler warnings about
5055 out-of-range initializers by using, for example, '\xab' rather
5056 than 0xab.
5057
aefd87e1
PE
5058 * xgselect.c (xgselect_initialize): Check vs interface
5059 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5060
bf501fb9
PE
5061 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5062
e9829fdf
PE
5063 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5064 to read-only memory.
5065
1086c095
PE
5066 * fns.c (vector): Remove; this old hack is no longer needed.
5067
2baccd04 5068 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5069 Remove unused var.
dde42981 5070 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5071
72391843 5072 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5073
436c16df 5074 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5075 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5076 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5077
92bb796d 5078 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5079 (x_term_init): Remove local to avoid shadowing.
92bb796d 5080
764430a3 5081 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5082
5083 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5084 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5085
d1dfb56c
EZ
50862011-04-16 Eli Zaretskii <eliz@gnu.org>
5087
c4354cb4
EZ
5088 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5089
d1dfb56c
EZ
5090 Fix regex.c, syntax.c and friends for buffers > 2GB.
5091 * syntax.h (struct gl_state_s): Declare character position members
5092 EMACS_INT.
5093
5094 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5095
04f2d78b
CB
5096 * textprop.c (verify_interval_modification, interval_of):
5097 Declare arguments EMACS_INT.
d1dfb56c
EZ
5098
5099 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5100 EMACS_INT.
5101
5102 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5103
5104 * indent.c (Fvertical_motion): Local variable it_start is now
5105 EMACS_INT.
5106
5107 * regex.c (re_match, re_match_2, re_match_2_internal)
5108 (bcmp_translate, regcomp, regexec, print_double_string)
5109 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5110 (re_compile_pattern, re_exec): Declare arguments and local
5111 variables `size_t' and `ssize_t' and return values `regoff_t', as
5112 appropriate.
5113 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5114 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5115 <compile_stack_type>: `size' and `avail' are now `size_t'.
5116
5117 * regex.h <regoff_t>: Use ssize_t, not int.
5118 (re_search, re_search_2, re_match, re_match_2): Arguments that
5119 specify buffer/string position and length are now ssize_t and
5120 size_t. Return type is regoff_t.
5121
613052cd
BK
51222011-04-16 Ben Key <bkey76@gmail.com>
5123
5124 * nsfont.m: Fixed bugs in ns_get_family and
5125 ns_descriptor_to_entity that were caused by using free to
5126 deallocate memory blocks that were allocated by xmalloc (via
5127 xstrdup). This caused Emacs to crash when compiled with
5128 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5129 --enable-checking=xmallocoverrun). xfree is now used to
5130 deallocate these memory blocks.
5131
4170f62f 51322011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5133
71b41406
PE
5134 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5135
9587a89d
PE
5136 emacs_write: Accept and return EMACS_INT for sizes.
5137 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5138 et seq.
5139 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5140 Accept and return EMACS_INT.
5141 (emacs_gnutls_write): Return the number of bytes written on
5142 partial writes.
5143 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5144 (emacs_read, emacs_write): Remove check for negative size, as the
5145 Emacs source code has been audited now.
9587a89d
PE
5146 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5147 (emacs_read, emacs_write): Use it.
273a5f82
PE
5148 * process.c (send_process): Adjust to the new signatures of
5149 emacs_write and emacs_gnutls_write. Do not attempt to store
5150 a byte offset into an 'int'; it might overflow.
9587a89d 5151 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5152
3e047f51
PE
5153 * sound.c: Don't assume sizes fit in 'int'.
5154 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5155 Return EMACS_INT, not int.
3e047f51 5156 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5157 Accept EMACS_INT, not int.
5158 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5159 record read return values.
5160
cc39a9db
BK
51612011-04-15 Ben Key <bkey76@gmail.com>
5162
c9d0ec6d
JB
5163 * keyboard.c (Qundefined): Don't declare static since it is used
5164 in nsfns.m.
5165 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5166 static since they are used in nsfont.m.
cc39a9db 5167
6c60eb9f
SM
51682011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5169
5170 * process.c (Qprocessp): Don't declare static.
5171 * lisp.h (Qprocessp): Declare again.
5172
7990b61a
JB
51732011-04-15 Juanma Barranquero <lekktu@gmail.com>
5174
5175 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5176
5d4cb038
PE
51772011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5178
8bd7b830 5179 Improve C-level modularity by making more things 'static'.
cd64ea1d 5180
e3b27b31
PE
5181 Don't publish debugger-only interfaces to other modules.
5182 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5183 (verify_bytepos, count_markers): Move decls to the only modules
5184 that need them.
5185 * region-cache.h (pp_cache): Likewise.
5186 * window.h (check_all_windows): Likewise.
5187 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5188
5d4cb038
PE
5189 * sysdep.c (croak): Now static, if
5190 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5191 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5192
5193 * alloc.c (refill_memory_reserve): Now static if
5194 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5195 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5196
e87b6180
PE
5197 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5198 Define only if USE_LUCID.
5199
ac64929e
PE
5200 * xrdb.c (x_customization_string, x_rm_string): Now static.
5201
6f37259d
PE
5202 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5203 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5204
1683e3ab
PE
5205 * xdisp.c (draw_row_with_mouse_face): Now static.
5206 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5207
de9c2632
PE
5208 * window.h (check_all_windows): Mark externally visible.
5209
2b96acb7
PE
5210 * window.c (window_deletion_count): Now static.
5211
5212 * undo.c: Make symbols static if they're not exported.
5213 (last_undo_buffer, last_boundary_position, pending_boundary):
5214 Now static.
5215
50436f33
PE
5216 * textprop.c (interval_insert_behind_hooks): Now static.
5217 (interval_insert_in_front_hooks): Likewise.
5218
64520e5c
PE
5219 * term.c: Make symbols static if they're not exported.
5220 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5221 (max_frame_lines, tty_set_terminal_modes):
5222 (tty_reset_terminal_modes, tty_turn_off_highlight):
5223 (get_tty_terminal): Now static.
5224 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5225 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5226 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5227 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5228 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5229
1fa53021
PE
5230 * sysdep.c: Make symbols static if they're not exported.
5231 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5232 Now static.
5233 (sigprocmask_set, full_mask): Remove; unused.
5234 (wait_debugging): Mark as visible.
5235 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5236 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5237
d4b43b22
PE
5238 * syntax.c (syntax_temp): Define only if !__GNUC__.
5239
b7c513d0
PE
5240 * sound.c (current_sound_device, current_sound): Now static.
5241
989b29ad
PE
5242 * search.c (searchbufs, searchbuf_head): Now static.
5243
13a55a78
PE
5244 * scroll.c (scroll_cost): Remove; unused.
5245 * dispextern.h (scroll_cost): Remove decl.
5246
de68a1fc
PE
5247 * region-cache.h (pp_cache): Mark as externally visible.
5248
40ccffa6
PE
5249 * process.c: Make symbols static if they're not exported.
5250 (process_tick, update_tick, create_process, chan_process):
5251 (Vprocess_alist, proc_buffered_char, datagram_access):
5252 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5253 (deactivate_process): Mark defn as static, as well as decl.
5254 * lisp.h (create_process): Remove decl.
5255 * process.h (chan_process, Vprocess_alist): Remove decls.
5256
ad64fc97
PE
5257 * print.c: Make symbols static if they're not exported.
5258 (print_depth, new_backquote_output, being_printed, print_buffer):
5259 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5260 (print_interval, print_number_index, initial_stderr_stream):
5261 Now static.
5262 * lisp.h (Fprinc): Remove decl.
5263 (debug_output_compilation_hack): Mark as externally visible.
5264
adddb265
PE
5265 * sysdep.c (croak): Move decl from here to syssignal.h.
5266 * syssignal.h (croak): Put it here, so the API can be checked when
5267 'croak' is called from dissociate_if_controlling_tty.
5268
1717ede2
PE
5269 * minibuf.c: Make symbols static if they're not exported.
5270 (minibuf_save_list, choose_minibuf_frame): Now static.
5271 * lisp.h (choose_minibuf_frame): Remove decl.
5272
fa5fb2bc
PE
5273 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5274
1e3890d1
PE
5275 * lread.c: Make symbols static if they're not exported.
5276 (read_objects, initial_obarray, oblookup_last_bucket_number):
5277 Now static.
5278 (make_symbol): Remove; unused.
5279 * lisp.h (initial_obarray, make_symbol): Remove decls.
5280
8a1414fa
PE
5281 * keyboard.c: Make symbols static if they're not exported.
5282 (single_kboard, recent_keys_index, total_keys, recent_keys):
5283 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5284 (this_single_command_key_start, echoing, last_auto_save):
5285 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5286 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5287 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5288 (Vlispy_mouse_stem, double_click_count):
5289 Now static.
5290 (force_auto_save_soon): Define only if SIGDANGER.
5291 (ignore_mouse_drag_p): Now static if
5292 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5293 (print_help): Remove; unused.
5294 (stop_character, last_timer_event): Mark as externally visible.
5295 * keyboard.h (ignore_mouse_drag_p): Declare only if
5296 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5297 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5298 * lisp.h (echoing): Remove decl.
5299 (force_auto_save_soon): Declare only if SIGDANGER.
5300 * xdisp.c (redisplay_window): Simplify code, to make it more
5301 obvious that ignore_mouse_drag_p is not accessed if !defined
5302 USE_GTK && !defined HAVE_NS.
5303
93ea6e8f
PE
5304 * intervals.c: Make symbols static if they're not exported.
5305 (merge_properties_sticky, merge_interval_right, delete_interval):
5306 Now static.
5307 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5308
77382fcc
PE
5309 * insdel.c: Make symbols static if they're not exported.
5310 However, leave prepare_to_modify_buffer alone. It's never
5311 called from outside this function, but that appears to be a bug.
5312 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5313 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5314 (adjust_after_replace_noundo): Remove; unused.
5315 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5316 (signal_before_change): Remove decls.
77382fcc 5317
9306c32e
PE
5318 * indent.c (val_compute_motion, val_vmotion): Now static.
5319
cd44d2eb
PE
5320 * image.c: Make symbols static if they're not exported.
5321 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5322 if USE_GTK.
5323 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5324 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5325
ad9a7a06
PE
5326 * fringe.c (standard_bitmaps): Now static.
5327 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5328
81626931
PE
5329 * frame.c: Make symbols static if they're not exported.
5330 (x_report_frame_params, make_terminal_frame): Now static.
5331 (get_frame_param): Now static, unless HAVE_NS.
5332 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5333 (x_get_resource_string): Remove; not used.
5334 * frame.h (make_terminal_frame, x_report_frame_params):
5335 (x_get_resource_string); Remove decls.
5336 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5337 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5338
239f9db9
PE
5339 * font.c, fontset.c: Make symbols static if they're not exported.
5340 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5341 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5342 * font.c (font_close_object): Now static.
5343 * font.h (font_close_object): Remove.
5344 * fontset.c (FONTSET_OBJLIST): Remove.
5345 (free_realized_fontset) #if-0 the body, which does nothing.
5346 (face_suitable_for_char_p): #if-0, as it's never called.
5347 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5348 * xfaces.c (face_at_string_position):
5349 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5350 since 0 is always ASCII.
5351
dfcf3579
PE
5352 * fns.c (weak_hash_tables): Now static.
5353
5045092b
PE
5354 * fileio.c: Make symbols static if they're not exported.
5355 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5356 (Vwrite_region_annotation_buffers): Now static.
5357
57a96f5c
PE
5358 * eval.c: Make symbols static if they're not exported.
5359 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5360 * lisp.h (backtrace_list): Remove decl.
5361
35f08c38
PE
5362 * emacs.c: Make symbols static if they're not exported.
5363 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5364 (fatal_error_code, fatal_error_signal_hook, standard_args):
5365 Now static.
5366 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5367 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5368 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5369 * lisp.h (fatal_error_signal_hook): Remove decl.
5370 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5371
f44bd759
PE
5372 * editfns.c: Move a (normally-unused) function to its only use.
5373 * editfns.c, lisp.h (get_operating_system_release): Remove.
5374 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5375 worth the hassle of breaking this out.
5376
b532497d
PE
5377 * xterm.c: Make symbols static if they're not exported.
5378 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5379 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5380 (x_destroy_window, x_delete_display):
5381 Now static.
5382 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5383 (x_mouse_leave): Remove; unused.
5384 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5385 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5386 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5387 Remove decls.
5388 (x_mouse_leave): Declare only if WINDOWSNT.
5389 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5390 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5391 USE_X_TOOLKIT.
5392
1675728f
PE
5393 * ftxfont.c: Make symbols static if they're not exported.
5394 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5395 HAVE_FREETYPE.
5396 * font.h (ftxfont_driver): Likewise.
5397
e4cebfca
PE
5398 * xfns.c: Make symbols static if they're not exported.
5399 (x_last_font_name, x_display_info_for_name):
5400 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5401 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5402 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5403 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5404 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5405 (last_show_tip_args): Now static.
5406 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5407 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5408 (x_screen_planes): Remove; unused.
5409 * dispextern.h (x_screen_planes): Remove decl.
5410
5bf46f05
PE
5411 * dispnew.c: Make symbols static if they're not exported.
5412 * dispextern.h (redraw_garbaged_frames, scrolling):
5413 (increment_row_positions): Remove.
5414 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5415 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5416 Now static.
5417 (redraw_garbaged_frames): Remove; unused.
5418
435f4c28
PE
5419 * xfaces.c: Make symbols static if they're not exported.
5420 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5421 Remove decls.
5422 * xterm.h (defined_color): Remove decls.
5423 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5424 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5425 (menu_face_changed_default, defined_color, free_realized_face):
5426 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5427 (ascii_face_of_lisp_face): Remove; unused.
5428
8524aef3
PE
5429 * xdisp.c: Make symbols static if they're not exported.
5430 * dispextern.h (scratch_glyph_row, window_box_edges):
5431 (glyph_to_pixel_coords, set_cursor_from_row):
5432 (get_next_display_element, set_iterator_to_next):
5433 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5434 (show_mouse_face): Remove decls
5435 * frame.h (message_buf_print): Likewise.
5436 * lisp.h (pop_message, set_message, check_point_in_composition):
5437 Likewise.
5438 * xterm.h (set_vertical_scroll_bar): Likewise.
5439 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5440 (message_buf_print, scratch_glyph_row, displayed_buffer):
5441 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5442 (get_next_display_element, show_mouse_face, window_box_edges):
5443 (frame_to_window_pixel_xy, check_point_in_composition):
5444 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5445 (glyph_to_pixel_coords): Remove; unused.
5446
16390cd2
PE
5447 * dired.c (file_name_completion): Now static.
5448
5449 * dbusbind.c (xd_in_read_queued_messages): Now static.
5450
a25f4dfa
PE
5451 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5452 * data.c (circular_list_error): Remove.
5453
14a9c8df
PE
5454 * commands.h (last_point_position, last_point_position_buffer):
5455 (last_point_position_window): Remove decls.
5456 * keyboard.c: Make these variables static.
5457
04f2d78b
CB
5458 * coding.h (coding, code_convert_region, encode_coding_gap):
5459 Remove decls.
74ab6df5
PE
5460 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5461 (iso_code_class, detect_coding, code_convert_region): Now static.
5462 (encode_coding_gap): Remove; unused.
5463
38dfbee1
PE
5464 * chartab.c (chartab_chars, chartab_bits): Now static.
5465
a2cb4e63
PE
5466 * charset.h (charset_iso_8859_1): Remove decl.
5467 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5468 Now static.
5469
127198fd
PE
5470 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5471 * ccl.c (Vccl_program_table): Now static.
5472 (check_ccl_update): Remove; unused.
5473
d85b608f
PE
5474 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5475 * category.h: ... from here.
5476 * category.c (check_category_table, set_category_set): Now static.
5477
31cd66f3
PE
5478 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5479 * lisp.h: Remove these decls.
5480
c358e587
PE
5481 * buffer.c (buffer_count): Remove unused var.
5482
e78aecca
PE
5483 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5484 so that it's not optimized away.
5485 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5486 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5487 exported only to the debugger.
5488
e192d7d3 5489 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5490 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5491
92470028
PE
5492 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5493 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5494 was inaccessible from Lisp.
5495 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5496 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5497
244ed907
PE
5498 alloc.c: Import and export fewer symbols, and remove unused items.
5499 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5500 is defined.
5501 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5502 it's not optimized away by whole-program optimization.
5503 (message_enable_multibyte, free_misc): Remove.
5504 (catchlist, handlerlist, mark_backtrace):
5505 Declare only if BYTE_MARK_STACK.
5506 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5507 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5508 (message_enable_multibyte): Remove decl.
5509 (free_misc, interval_free_list, float_block, float_block_index):
5510 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5511 (cons_free_list, last_marked_index):
5512 Now static.
5513 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5514 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5515 (mark_backtrace): Define only if BYTE_MARK_STACK.
5516 * xdisp.c (message_enable_multibyte): Now static.
5517
61c2b50e 5518 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5519 This makes it easier for human readers (and static analyzers)
5520 to see whether these variables are used from other modules.
5521 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5522 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5523 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5524 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5525 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5526 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5527 * xmenu.c, xselect.c:
5528 Declare Q* vars static if they are not used in other modules.
5529 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5530 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5531 Remove decls of unexported vars.
5532 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5533
95c82688
PE
5534 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5535
16a97296
PE
5536 Make Emacs functions such as Fatom 'static' by default.
5537 This makes it easier for human readers (and static analyzers)
5538 to see whether these functions can be called from other modules.
5539 DEFUN now defines a static function. To make the function external
5540 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5541 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5542 (Finit_image_library):
16a97296
PE
5543 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5544 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5545 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5546 Remove decls, since these functions are now static.
5547 (Funintern, Fget_internal_run_time): New decls, since these functions
5548 were already external.
95c82688 5549
16a97296
PE
5550 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5551 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5552 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5553 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5554 * keyboard.c, keymap.c, lread.c:
5555 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5556 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5557 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5558 Mark functions with DEFUE instead of DEFUN,
5559 if they are used in other modules.
5560 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5561 decls for now-static functions.
5562 * buffer.h (Fdelete_overlay): Remove decl.
5563 * callproc.c (Fgetenv_internal): Mark as internal.
5564 * composite.c (Fremove_list_of_text_properties): Remove decl.
5565 (Fcomposition_get_gstring): New forward static decl.
5566 * composite.h (Fcomposite_get_gstring): Remove decl.
5567 * dired.c (Ffile_attributes): New forward static decl.
5568 * doc.c (Fdocumntation_property): New forward static decl.
5569 * eval.c (Ffetch_bytecode): New forward static decl.
5570 (Funintern): Remove extern decl; now in .h file where it belongs.
5571 * fileio.c (Fmake_symbolic_link): New forward static decl.
5572 * image.c (Finit_image_library): New forward static decl.
5573 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5574 * intervals.h (Fprevious_property_change):
5575 (Fremove_list_of_text_properties): Remove decls.
5576 * keyboard.c (Fthis_command_keys): Remove decl.
5577 (Fcommand_execute): New forward static decl.
5578 * keymap.c (Flookup_key): New forward static decl.
5579 (Fcopy_keymap): Now static.
5580 * keymap.h (Flookup_key): Remove decl.
5581 * process.c (Fget_process): New forward static decl.
5582 (Fprocess_datagram_address): Mark as internal.
5583 * syntax.c (Fsyntax_table_p): New forward static decl.
5584 (skip_chars): Remove duplicate decl.
5585 * textprop.c (Fprevious_property_change): New forward static decl.
5586 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5587 Now internal.
5588 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5589 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5590
785bbd42
PE
5591 * editfns.c (Fformat): Remove unreachable code.
5592
8b913b57
AS
55932011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5594
5595 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5596 change. (Bug#8496)
5597
a6744a35
EZ
55982011-04-13 Eli Zaretskii <eliz@gnu.org>
5599
5600 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5601 when at ZV. (Bug#8487)
5602
e7974947
AS
56032011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5604
baad03f0
AS
5605 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5606 (Bug#8437)
5607 * keyboard.c (parse_tool_bar_item): Likewise.
5608 * sound.c (sound_cleanup, alsa_close): Likewise.
5609 * termcap.c (tgetent): Likewise.
5610 * xfns.c (x_default_font_parameter): Likewise.
5611 * xsettings.c (read_and_apply_settings): Likewise.
5612
e7974947
AS
5613 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5614 (overrun_check_free): Protoize.
5615
28272684
PE
56162011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5617
5618 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5619 since callers should never pass a negative size.
5620 Change the signature to match that of plain 'read' and 'write'; see
5621 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5622 * lisp.h: Update prototypes of emacs_write and emacs_read.
5623
11997c76
EZ
56242011-04-11 Eli Zaretskii <eliz@gnu.org>
5625
5626 * xdisp.c (redisplay_window): Don't try to determine the character
5627 position of the scroll margin if the window start point w->startp
e896f03c 5628 is outside the buffer's accessible region. (Bug#8468)
11997c76 5629
8a2cbd72
EZ
56302011-04-10 Eli Zaretskii <eliz@gnu.org>
5631
5632 Fix write-region and its subroutines for buffers > 2GB.
5633 * fileio.c (a_write, e_write): Modify declaration of arguments and
5634 local variables to support buffers larger than 2GB.
5635 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5636
5637 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5638 argument, local variables, and return value.
5639
5640 * lisp.h: Update prototypes of emacs_write and emacs_read.
5641
5642 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5643
4073e537 56442011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5645
1ebfdcb6
PE
5646 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5647
b2ded58d
PE
5648 Fix more problems found by GCC 4.6.0's static checks.
5649
7d66342c
PE
5650 * xdisp.c (vmessage): Use a better test for character truncation.
5651
bbf47d44
PE
5652 * charset.c (load_charset_map): <, not <=, for optimization,
5653 and to avoid potential problems with integer overflow.
9248994d 5654 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5655 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5656 * editfns.c (Fformat): Likewise.
1e69125e 5657 * syntax.c (skip_chars): Likewise.
3befa583 5658
e3019616
PE
5659 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5660 This also lets GCC 4.6.0 generate slightly better loop code.
5661
becfa255
PE
5662 * callint.c (Fcall_interactively): <, not <=, for optimization.
5663 (Fcall_interactively): Count the number of arguments produced,
5664 not the number of arguments given. This is simpler and lets GCC
5665 4.6.0 generate slightly better code.
5666
dae0cd48
PE
5667 * ftfont.c: Distingish more carefully between FcChar8 and char.
5668 The previous code passed unsigned char * to a functions like
5669 strlen and xstrcasecmp that expect char *, which does not
5670 conform to the C standard.
5671 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5672 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5673 char * when the C standard requires it.
5674
76032d70
PE
5675 * keyboard.c (read_char): Remove unused var.
5676
eb3f1cc8
PE
5677 * eval.c: Port to Windows vsnprintf (Bug#8435).
5678 Include <limits.h>.
5679 (SIZE_MAX): Define if the headers do not.
5680 (verror): Do not give up if vsnprintf returns a negative count.
5681 Instead, grow the buffer. This ports to Windows vsnprintf, which
5682 does not conform to C99. Problem reported by Eli Zaretskii.
5683 Also, simplify the allocation scheme, by avoiding the need for
5684 calling realloc, and removing the ALLOCATED variable.
5685
70476b54
PE
5686 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5687
12020a9e
PE
5688 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5689 But keep the doprint source code for now, as we might revamp it
5690 and use it again (Bug#8435).
ea6c7ae6
PE
5691 * lisp.h (doprnt): Remove.
5692 * Makefile.in (base_obj): Remove doprnt.o.
5693 * deps.mk (doprnt.o): Remove.
5694
5fdb398c
PE
5695 error: Print 32- and 64-bit integers portably (Bug#8435).
5696 Without this change, on typical 64-bit hosts error ("...%d...", N)
5697 was used to print both 32- and 64-bit integers N, which relied on
5698 undefined behavior.
5699 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5700 New macro.
5701 * lisp.h (error, verror): Mark as printf-like functions.
5702 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5703 Report overflow in size calculations when allocating printf buffer.
5704 Do not truncate output string at its first null byte.
5705 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5706 Truncate the output at a character boundary, since vsnprintf does not
5707 do that.
5708 * charset.c (check_iso_charset_parameter): Convert internal
5709 character to string before calling 'error', since %c now has the
5710 printf meaning.
5711 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5712 overflow when computing char to be passed to 'error'. Do not
5713 pass Lisp_Object to 'error'; pass the integer instead.
5714 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5715 formatted with plain %d.
5716
b189fa66
PE
5717 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5718
bff87ef0
PE
5719 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5720
7e2cac20
PE
5721 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5722
ce4d90b5
PE
5723 * xterm.c (x_catch_errors): Remove duplicate declaration.
5724
266c9547
PE
5725 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5726
79c49ad2
PE
5727 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5728
368f4090
JM
57292011-04-10 Jim Meyering <meyering@redhat.com>
5730
5731 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5732 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5733 return ssize_t not "int", and use size_t as the buffer length.
5734 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5735 * gnutls.h: Update declarations.
5736 * process.c (read_process_output): Use ssize_t, to match.
5737 (send_process): Likewise.
5738
a32d4040
CY
57392011-04-09 Chong Yidong <cyd@stupidchicken.com>
5740
5741 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5742
8546720e 57432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5744
04f2d78b
CB
5745 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5746 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5747
8546720e
GM
5748 * xterm.c (handle_one_xevent):
5749 * xmenu.c (create_and_show_popup_menu):
5750 * xselect.c (x_decline_selection_request)
5751 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5752
0a2f5c1a 57532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5754
5755 Fix some uses of `int' instead of EMACS_INT.
5756 * search.c (string_match_1, fast_string_match)
5757 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5758 (scan_buffer, find_next_newline_no_quit)
5759 (find_before_next_newline, search_command, Freplace_match)
5760 (Fmatch_data): Make some `int' variables be EMACS_INT.
5761
5762 * xdisp.c (display_count_lines): 3rd argument and return value now
5763 EMACS_INT. All callers changed.
5764 (pint2hrstr): Last argument is now EMACS_INT.
5765
5766 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5767 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5768 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5769 (decode_coding_utf_16, decode_coding_emacs_mule)
5770 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5771 (decode_coding_ccl, decode_coding_charset)
5772 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5773 (decode_coding_iso_2022, decode_coding_emacs_mule)
5774 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5775 <char_offset, last_offset>: Declare EMACS_INT.
5776 (encode_coding_utf_8, encode_coding_utf_16)
5777 (encode_coding_emacs_mule, encode_invocation_designation)
5778 (encode_designation_at_bol, encode_coding_iso_2022)
5779 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5780 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5781 Declare EMACS_INT.
5782 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5783 (encode_invocation_designation): Last argument P_NCHARS is now
5784 EMACS_INT.
5785 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5786 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5787
5788 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5789 All users changed.
5790
5791 * ccl.c (Fccl_execute_on_string): Declare some variables
5792 EMACS_INT.
5793
8546720e 57942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5795
5796 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5797
4e19a977
CS
57982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5799
5800 * process.c (Fformat_network_address): Doc fix.
5801
87302331
R
58022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5803
5804 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5805
cbb59342
CY
58062011-04-08 Chong Yidong <cyd@stupidchicken.com>
5807
5808 * keyboard.c (read_char): Call Lisp function help-form-show,
5809 instead of using internal_with_output_to_temp_buffer.
5810 (Qhelp_form_show): New var.
e0d38eeb 5811 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5812
5813 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5814
5815 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5816
e67a13ab
CY
58172011-04-06 Chong Yidong <cyd@stupidchicken.com>
5818
04f2d78b
CB
5819 * process.c (Flist_processes): Remove to Lisp.
5820 (list_processes_1): Delete.
e67a13ab 5821
973f782d
EZ
58222011-04-06 Eli Zaretskii <eliz@gnu.org>
5823
7c106b1e
EZ
5824 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5825
973f782d
EZ
5826 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5827
41cf7d1a 58282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5829
ca23cc88
PE
5830 Fix more problems found by GCC 4.6.0's static checks.
5831
f390e2d5
PE
5832 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5833
42eea0d0
PE
5834 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5835
b69769da 5836 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5837
f9541e84
PE
5838 * xdisp.c (vmessage): Mark as a printf-like function.
5839
13841b55
PE
5840 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5841
c136c10f
PE
5842 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5843
5e2d4a30
PE
5844 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5845 printf-like functions.
5846 (tiff_load): Add casts to remove these marks before passing them
5847 to system-supplied API.
5848
583f48b9
PE
5849 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5850
b25d760e
PE
5851 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5852 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5853 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5854 directly, rather than having caller test rule sign. This avoids
5855 some unnecessary tests.
5856 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5857 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5858 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5859
bc7b6697 5860 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5861 (xfont_open): Avoid unnecessary tests.
bc7b6697 5862
27ccc379
PE
5863 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5864
dcd5c89a
PE
5865 * composite.h, composite.c (composition_gstring_put_cache):
5866 Use EMACS_INT, not int, for length.
5867
b13a45c6
PE
5868 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5869 breaking out part of COMPOSITION_DECODE_RULE.
5870 (COMPOSITION_DECODE_RULE): Use it.
5871 * composite.c (get_composition_id): Remove unused local vars,
5872 by using the new macro.
5873
1e792e4d
PE
5874 * textprop.c (set_text_properties_1): Change while to do-while,
5875 since the condition is always true at first.
5876
dc6c6455 5877 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5878 (interval_deletion_adjustment): Return unsigned value.
5879 All uses changed.
dc6c6455 5880
aba7731a
PE
5881 * process.c (list_processes_1, create_pty, read_process_output):
5882 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5883 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5884 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5885 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5886 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5887
fdfc4bf3
PE
5888 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5889
fca8fe46 5890 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5891 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5892
06a0259a 5893 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5894 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5895 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5896
e7b9e80f
PE
5897 * print.c (print_error_message): Avoid int overflow.
5898
56201685
PE
5899 * font.c (font_list_entities): Redo for clarity,
5900 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5901
78834453 5902 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5903 (font_score): Avoid potential overflow in diff calculation.
78834453 5904
0bc0b309 5905 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5906 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5907
e610eaca
PE
5908 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5909
b895abce
PE
5910 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5911 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5912 can always succeed if overflow has undefined behavior.
5913
1f1d9321 5914 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5915 (wordify): Omit three unnecessary tests.
1f1d9321 5916
c59478bc
PE
5917 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5918 All callers changed. This avoids the need for an unused var.
5919
79b73827
PE
5920 * casefiddle.c (casify_region): Remove var that is set but not used.
5921
a4db5dfe
PE
5922 * dired.c (file_name_completion): Remove var that is set but not used.
5923
43aae36e
PE
5924 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5925
2a47c44d 5926 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5927 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5928
a37c69bf
PE
5929 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5930 Check for integer overflow on size calculations.
5931
328ab8e7
PE
5932 * buffer.c (Fprevious_overlay_change): Remove var that is set
5933 but not used.
5934
e5a2a5cb
PE
5935 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5936 Remove vars that are set but not used.
8d84a6eb 5937 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5938 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5939
a60e5f68
PE
5940 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5941
f661cb61 5942 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5943 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5944
f0397f5a
PE
5945 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5946 that are set but not used.
5947
8664db06 5948 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5949 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5950
6abdaa4a
PE
5951 * xselect.c (x_get_local_selection, x_handle_property_notify):
5952 Remove vars that are set but not used.
5953
0ce7538d 5954 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5955 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5956
9ae848fc
PE
5957 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5958 Remove var that is set but not used.
0b918413
PE
5959 (scroll_bar_windows_size): Now size_t, not int.
5960 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5961 Check for overflow.
9ae848fc 5962
a5a62657
PE
5963 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5964 (map_tty_color) [!defined MSDOS]: Likewise.
5965
5c5cdd39
PE
5966 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5967
66ebf983
PE
5968 * coding.c: Remove vars that are set but not used.
5969 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5970 All callers changed.
5971 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5972 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5973 (decode_coding_charset): Remove vars that are set but not used.
5974
1be4d761
PE
5975 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5976 that is set but not used.
5977
47553fa8
PE
5978 * print.c (print_object): Remove var that is set but not used.
5979
1f7196bf 5980 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5981 The gnulib version avoids calling malloc in the usual case,
5982 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5983 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5984 * filelock.c (current_lock_owner): Likewise.
5985 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5986 * sysdep.c: Include allocator.h, careadlinkat.h.
5987 (emacs_no_realloc_allocator): New static constant.
5988 (emacs_readlink): New function.
fdb61804
PE
5989 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5990 ../lib/careadlinkat.h.
d1fdcab7 5991
f84c17c7
SM
59922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5993
5994 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5995 first non-nil return value).
5996
ef3862ad
JD
59972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5998
5999 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6000 if not defined (Bug#8403).
6001
376a7006
JB
60022011-04-02 Juanma Barranquero <lekktu@gmail.com>
6003
6004 * xdisp.c (display_count_lines): Remove parameter `start',
6005 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6006 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6007 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6008 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6009 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6010 and thereabouts. All callers changed.
6011 (get_per_char_metric): Remove parameter `f', unused since
6012 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6013
6ca3801d
JM
60142011-04-02 Jim Meyering <meyering@redhat.com>
6015
6016 do not dereference NULL upon failed strdup
6017 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6018 (ns_get_family): Likewise.
6019
d8e2b5ba
JB
60202011-04-02 Juanma Barranquero <lekktu@gmail.com>
6021
6022 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6023
8c74fcbd
JD
60242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6025
6026 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6027 later (Bug#8403).
6028
7200d79c
SM
60292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6030
03408648 6031 Add lexical binding.
7200d79c 6032
03408648
SM
6033 * window.c (Ftemp_output_buffer_show): New fun.
6034 (Fsave_window_excursion):
6035 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6036
6037 * lread.c (lisp_file_lexically_bound_p): New function.
6038 (Fload): Bind Qlexical_binding.
6039 (readevalloop): Remove `evalfun' arg.
6040 Bind Qinternal_interpreter_environment.
6041 (Feval_buffer): Bind Qlexical_binding.
6042 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6043 Mark as dynamic.
6044 (syms_of_lread): Declare `lexical-binding'.
6045
6046 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6047
6048 * keyboard.c (eval_dyn): New fun.
6049 (menu_item_eval_property): Use it.
ca105506
SM
6050
6051 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6052
03408648
SM
6053 * fns.c (concat, mapcar1): Accept byte-code-functions.
6054
6055 * eval.c (Fsetq): Handle lexical vars.
6056 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6057 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6058 (FletX, Flet): Obey lexical binding.
6059 (Fcommandp): Handle closures.
6060 (Feval): New `lexical' arg.
6061 (eval_sub): New function extracted from Feval. Use it almost
6062 everywhere where Feval was used. Look up vars in lexical env.
6063 Handle closures.
6064 (Ffunctionp): Move from subr.el.
6065 (Ffuncall): Handle closures.
6066 (apply_lambda): Remove `eval_flags'.
6067 (funcall_lambda): Handle closures and new byte-code-functions.
6068 (Fspecial_variable_p): New function.
6069 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6070 but without exporting it to Lisp.
23aba0ea 6071
23aba0ea 6072 * doc.c (Fdocumentation, store_function_docstring):
03408648 6073 * data.c (Finteractive_form): Handle closures.
23aba0ea 6074
03408648
SM
6075 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6076 interactive spec.
ba83908c 6077
04f2d78b
CB
6078 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6079 New byte-codes.
03408648
SM
6080 (exec_byte_code): New function extracted from Fbyte_code to handle new
6081 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6082
03408648 6083 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6084
03408648 6085 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6086
e2abce01
JB
60872011-03-31 Juanma Barranquero <lekktu@gmail.com>
6088
6089 * xdisp.c (redisplay_internal): Fix prototype.
6090
63696a73 60912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6092
63696a73 6093 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6094 (try_scrolling): Use it when setting scroll_limit.
6095 Limit scrolling to 100 screen lines.
63696a73
EZ
6096 (redisplay_window): Even when falling back on "recentering",
6097 position point in the window according to scroll-conservatively,
6098 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6099
6100 (try_scrolling): When point is above the window, allow searching
6101 as far as scroll_max, or one screenful, to compute vertical
6102 distance from PT to the scroll margin position. This prevents
6103 try_scrolling from unnecessarily failing when
6104 scroll-conservatively is set to a value slightly larger than the
6105 window height. Clean up the case of PT below the margin at bottom
6106 of window: scroll_max can no longer be INT_MAX. When aggressive
6107 scrolling is in use, don't let point enter the opposite scroll
6108 margin as result of the scroll.
6109 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6110 threshold of 100 lines for never-recentering scrolling.
6111
e4cc2dfc
JB
61122011-03-31 Juanma Barranquero <lekktu@gmail.com>
6113
6114 * dispextern.h (move_it_by_lines):
6115 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6116 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6117 (message_log_check_duplicate): Remove parameters `prev_bol' and
6118 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6119 (redisplay_internal): Remove parameter `preserve_echo_area',
6120 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6121
6122 * indent.c (Fvertical_motion):
6123 * window.c (window_scroll_pixel_based, Frecenter):
6124 Don't pass `need_y_p' to `move_it_by_lines'.
6125
1c470562
SM
61262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6127
44f230aa
SM
6128 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6129 steal a few bits to be more compact.
6130 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6131 Remove unneeded casts.
6132
1c470562
SM
6133 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6134
888adce9
ZK
61352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6136
6137 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6138 binding" message (bug#7967).
6139
f838ed7b
PE
61402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6141
77861b95
PE
6142 Fix more problems found by GCC 4.6.0's static checks.
6143
de6dbc14
PE
6144 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6145 Remove unused local var.
6146
f838ed7b
PE
6147 * editfns.c (Fmessage_box): Remove unused local var.
6148
792c7b2b
PE
6149 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6150 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6151 Omit unused local vars.
c499e557 6152 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6153 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6154 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6155 Omit unused local var.
6156
ba0165e1
PE
6157 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6158 Don't assume string length fits in int.
32ad8845 6159 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6160 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6161
3c59b4c9
PE
6162 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6163 instead of alloca (Bug#8344).
6164
a3eed478 6165 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6166 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6167
eb4d412d
PE
6168 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6169
1658b401
PE
6170 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6171 concerns.
6172
6173 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6174
6175 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6176
9a2c6e05
PE
6177 * keyboard.c (syms_of_keyboard): Use the same style as later
6178 in this function when indexing through an array. This also
6179 works around GCC bug 48267.
6180
03d0a109
PE
6181 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6182
44f730c8
PE
6183 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6184
fe75f926
PE
6185 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6186 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6187
ffa8c828
PE
6188 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6189 This avoids undefined behavior on integer overflow, and is a bit
6190 more convenient anyway since it is compared to a size_t variable.
6191
c5101a77
PE
6192 Variadic C functions now count arguments with size_t, not int.
6193 This avoids an unnecessary limitation on 64-bit machines, which
6194 caused (substring ...) to crash on large vectors (Bug#8344).
6195 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6196 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6197 All variadic functions and their callers changed accordingly.
c5101a77
PE
6198 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6199 * data.c (arith_driver, float_arith_driver): Likewise.
6200 * editfns.c (general_insert_function): Likewise.
6201 * eval.c (struct backtrace.nargs, interactive_p)
6202 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6203 (funcall_lambda, mark_backtrace): Likewise.
6204 * fns.c (concat): Likewise.
6205 * frame.c (x_set_frame_parameters): Likewise.
6206 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6207 0 if not found, not -1. All callers changed.
6208
dd3f25f7
PE
6209 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6210 (stack_copy_size): Now size_t, not int.
6211 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6212
461c2ab9
JB
62132011-03-28 Juanma Barranquero <lekktu@gmail.com>
6214
6215 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6216 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6217 All callers changed.
6218
6219 * lisp.h (multibyte_char_to_unibyte):
6220 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6221 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6222 * character.h (CHAR_TO_BYTE8):
6223 * cmds.c (internal_self_insert):
6224 * editfns.c (general_insert_function):
6225 * keymap.c (push_key_description):
6226 * search.c (Freplace_match):
6227 * xdisp.c (message_dolog, set_message_1): All callers changed.
6228
f6d62986
SM
62292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6230
6231 * keyboard.c (safe_run_hook_funcall): New function.
6232 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6233 don't set the hook to nil, but remove the offending function instead.
6234 (Qcommand_hook_internal): Remove, unused.
6235 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6236 Vcommand_hook_internal.
6237
6238 * eval.c (enum run_hooks_condition): Remove.
6239 (funcall_nil, funcall_not): New functions.
6240 (run_hook_with_args): Call each function through a `funcall' argument.
6241 Remove `cond' argument, now redundant.
6242 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6243 (Frun_hook_with_args_until_failure): Adjust accordingly.
6244 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6245
1db5b1ad
JB
62462011-03-28 Juanma Barranquero <lekktu@gmail.com>
6247
6248 * dispextern.h (string_buffer_position): Remove declaration.
6249
6250 * print.c (strout): Remove parameter `multibyte', unused since
6251 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6252
6253 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6254 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6255 All callers changed.
6256
6257 * w32.c (_wsa_errlist): Use braces for struct initializers.
6258
6259 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6260 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6261 All callers changed.
6262 (string_buffer_position): Likewise. Also, make static (it's never
6263 used outside xdisp.c).
6264 (cursor_row_p): Remove parameter `w', unused since
6265 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6266 (decode_mode_spec): Remove parameter `precision', introduced during
6267 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6268 All callers changed.
6269
5ffb62aa
JD
62702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6271
6272 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6273
461c2ab9 62742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6275
6276 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6277 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6278 (ns_update_auto_hide_menu_bar): New functions.
6279 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6280 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6281 ns_constrain_all_frames.
6282 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6283 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6284
5c380ffb
JD
62852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6286
6287 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6288
9af30bdf
GM
62892011-03-27 Glenn Morris <rgm@gnu.org>
6290
6291 * syssignal.h: Replace RETSIGTYPE with void.
6292 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6293 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6294 Replace SIGTYPE with void everywhere.
6295 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6296 * s/template.h (SIGTYPE): Remove commented out definition.
6297
e2abce01
JB
62982011-03-26 Eli Zaretskii <eliz@gnu.org>
6299
6300 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6301 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6302
f868cd8a
JB
63032011-03-26 Juanma Barranquero <lekktu@gmail.com>
6304
59eb0929
JB
6305 * w32.c (read_unc_volume): Use parameter `henum', instead of
6306 global variable `wget_enum_handle'.
6307
6308 * keymap.c (describe_vector): Remove parameters `indices' and
6309 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6310 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6311
f868cd8a
JB
6312 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6313
6314 * keyboard.c (timer_check): Remove parameter `do_it_now',
6315 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6316 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6317 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6318
6319 * keyboard.c (read_char):
6320 * w32menu.c (w32_menu_display_help):
6321 * xmenu.c (show_help_event, menu_help_callback):
6322 Adjust calls to `show_help_echo'.
6323
6324 * gtkutil.c (xg_maybe_add_timer):
6325 * keyboard.c (readable_events):
6326 * process.c (wait_reading_process_output):
6327 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6328
6329 * insdel.c (adjust_markers_gap_motion):
6330 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6331 (gap_left, gap_right): Don't call it.
6332
2ecf6fdb
CY
63332011-03-25 Chong Yidong <cyd@stupidchicken.com>
6334
6335 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6336 incurred during fontification.
6337
6b1f9ba4
JB
63382011-03-25 Juanma Barranquero <lekktu@gmail.com>
6339
6340 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6341 (DEFVAR_PER_BUFFER): Don't pass it.
6342
6343 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6344 (scrolling_window): Don't pass it.
6345
0f4a96b5
JB
63462011-03-25 Juanma Barranquero <lekktu@gmail.com>
6347
6348 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6349
6350 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6351 and `suffix'.
6352 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6353 of variables specific to SELinux and computation of `encoded_absname'.
6354
6355 * image.c (XPutPixel): Remove unused variable `height'.
6356
6357 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6358
6359 * unexw32.c (get_section_info): Remove unused variable `section'.
6360
6361 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6362 (system_process_attributes): Remove unused variable `sess'.
6363 (sys_read): Remove unused variable `err'.
6364
6365 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6366 (w32_wnd_proc): Remove unused variable `isdead'.
6367 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6368 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6369 (x_create_tip_frame): Remove unused variable `tem'.
6370
6371 * w32inevt.c (w32_console_read_socket):
6372 Remove unused variable `no_events'.
6373
6374 * w32term.c (x_draw_composite_glyph_string_foreground):
6375 Remove unused variable `width'.
6376
1149507c
JB
63772011-03-24 Juanma Barranquero <lekktu@gmail.com>
6378
6379 * w32term.c (x_set_glyph_string_clipping):
6380 Don't pass uninitialized region to CombineRgn.
6381
9c88f339
JB
63822011-03-23 Juanma Barranquero <lekktu@gmail.com>
6383
6384 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6385 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6386 (Fx_close_connection): Remove unused variable `i'.
6387
6388 * w32font.c (w32font_draw): Return number of glyphs.
6389 (w32font_open_internal): Remove unused variable `i'.
6390 (w32font_driver): Add missing initializer.
6391
6392 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6393 (fill_in_menu): Remove unused variable `items_added'.
6394
6395 * w32term.c (last_mouse_press_frame): Remove static global variable.
6396 (w32_clip_to_row): Remove unused variable `f'.
6397 (x_delete_terminal): Remove unused variable `i'.
6398
6399 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6400 (NOTHING): Remove unused static global variable.
6401 (uniscribe_check_otf): Remove unused variable `table'.
6402 (uniscribe_font_driver): Add missing initializers.
6403
dee091a3
JD
64042011-03-23 Julien Danjou <julien@danjou.info>
6405
6406 * term.c (Fsuspend_tty, Fresume_tty):
6407 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6408 * window.c (temp_output_buffer_show):
6409 * insdel.c (signal_before_change):
6410 * frame.c (Fhandle_switch_frame):
6411 * fileio.c (Fdo_auto_save):
6412 * emacs.c (Fkill_emacs):
6413 * editfns.c (save_excursion_restore):
6414 * cmds.c (internal_self_insert):
6415 * callint.c (Fcall_interactively):
6416 * buffer.c (Fkill_all_local_variables):
6417 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6418 Use Frun_hooks.
0f4a96b5 6419 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6420 unconditionnaly since it does the check itself.
6421
2c520ab5 64222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6423
c9c49752
PE
6424 Fix more problems found by GCC 4.5.2's static checks.
6425
8abc3f12
PE
6426 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6427 the first time through the loop, since we know p0 < p1 then.
6428 This also avoids a gcc -Wstrict-overflow warning.
6429
a2d26660
PE
6430 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6431 leading to a memory leak, possible in functions like
6432 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6433 of objects (Bug#8318).
a2d26660 6434
916c72e9
PE
6435 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6436 that could (at least in theory) be that large.
6437
19ab8a18
PE
6438 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6439 This is less likely to overflow, and avoids undefined behavior if
6440 overflow does occur. All callers changed. Use strtoul to scan
6441 for the unsigned long integer.
b7cbbd6f
PE
6442 (pint2hrstr): Simplify and tune code slightly.
6443 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6444
f0641eff
PE
6445 * scroll.c (do_scrolling): Work around GCC bug 48228.
6446 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6447
7f650bb9
PE
6448 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6449 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6450 (validate_x_resource_name): Simplify count usage.
6451 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6452
37dd57d1
PE
6453 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6454 fail (Bug#8306).
81e56e61 6455
699979fc 6456 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6457
401bf9b4
PE
6458 * process.c (Fmake_network_process): Use socklen_t, not int,
6459 where POSIX says socklen_t is required in portable programs.
6460 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6461 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6462 (Fmake_network_process, server_accept_connection):
6463 (wait_reading_process_output, read_process_output):
6464 Likewise.
6465
b93aacde
PE
6466 * process.c: Rename or move locals to avoid shadowing.
6467 (list_processes_1, Fmake_network_process):
6468 (read_process_output_error_handler, exec_sentinel_error_handler):
6469 Rename or move locals.
4dc343ee 6470 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6471 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6472 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6473 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6474 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6475
af8a867c 6476 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6477 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6478 Include tparam.h instead, since it declares them.
af8a867c
PE
6479 * cm.h (PC): Remove extern decl; tparam.h now does this.
6480 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6481 * terminfo.c: Include tparam.h, to check interfaces.
6482 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6483 (tparam): Adjust signature to match interface in tparam.h;
6484 this removes some undefined behavior. Check that outstring and len
6485 are zero, which they always are with Emacs.
6486 * tparam.h (PC, BC, UP): New extern decls.
6487
0248044d 6488 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6489 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6490
8ff096c1 6491 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6492 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6493 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6494 (ftfont_list): Remove unused local.
49eaafba
PE
6495 (get_adstyle_property, ftfont_pattern_entity):
6496 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6497 Rename locals to avoid shadowing.
8ff096c1 6498
e2be39f6
PE
6499 * xfont.c (xfont_list_family): Mark var as initialized.
6500
c9735e30
PE
6501 * xml.c (make_dom): Now static.
6502
8f5201ae
PE
6503 * composite.c (composition_compute_stop_pos): Rename local to
6504 avoid shadowing.
b246f932
PE
6505 (composition_reseat_it): Remove unused locals.
6506 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6507 (composition_update_it): Mark var as initialized.
11b61122
PE
6508 (find_automatic_composition): Mark vars as initialized,
6509 with a FIXME (Bug#8290).
8f5201ae 6510
760fbc2c
PE
6511 character.h: Rename locals to avoid shadowing.
6512 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6513 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6514 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6515 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6516 to avoid shadowing.
6517
ff08eb85
PE
6518 * textprop.c (property_change_between_p): Remove; unused.
6519
fc7bf025
PE
6520 * intervals.c (interval_start_pos): Now static.
6521
235d7abc
PE
6522 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6523
44f230aa
SM
6524 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6525 Rename locals to avoid shadowing.
3e7d6594 6526
50060332
PE
6527 * sound.c (wav_play, au_play, Fplay_sound_internal):
6528 Fix pointer signedness.
d01f234b 6529 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6530 (wav_play): Initialize a variable to 0, to prevent undefined
6531 behavior (Bug#8278).
50060332 6532
c4fc4e30
PE
6533 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6534
918436ed
PE
6535 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6536
c939f91b
PE
6537 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6538 clobbering (Bug#8298).
b9c7f648
PE
6539 * sysdep.c (sys_subshell): Likewise.
6540 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6541
6bd8c144
PE
6542 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6543 This should get cleaned up, so that child_setup has the
6544 same signature on all platforms.
6545
7710357c 6546 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6547 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6548
c59da222
CY
65492011-03-22 Chong Yidong <cyd@stupidchicken.com>
6550
6551 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6552 not to be necessary, and produces flickering.
6553
66b87493
GM
65542011-03-20 Glenn Morris <rgm@gnu.org>
6555
6556 * config.in: Remove file.
6557
45b6f6d5
JB
65582011-03-20 Juanma Barranquero <lekktu@gmail.com>
6559
6560 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6561 are now in src/globals.h.
6562 (syms_of_minibuf): Remove spurious & from previous change.
6563
3ec03f7e
LL
65642011-03-20 Leo <sdl.web@gmail.com>
6565
6566 * minibuf.c (completing-read-function): New variable.
6567 (completing-read-default): Rename from completing-read.
6568 (completing-read): Call completing-read-function.
6569
b14e3e21
CY
65702011-03-19 Juanma Barranquero <lekktu@gmail.com>
6571
6572 * xfaces.c (Fx_load_color_file):
6573 Read color file from absolute filename (bug#8250).
6574
f2b726e6
JB
65752011-03-19 Juanma Barranquero <lekktu@gmail.com>
6576
6577 * makefile.w32-in: Update dependencies.
6578
09f6ff02
EZ
65792011-03-17 Eli Zaretskii <eliz@gnu.org>
6580
6581 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6582
29a6015a
PE
65832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6584
a3a6c54e
PE
6585 Fix more problems found by GCC 4.5.2's static checks.
6586
b766f867
PE
6587 * process.c (make_serial_process_unwind, send_process_trap):
6588 (sigchld_handler): Now static.
6589
be02381c
PE
6590 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6591 That way, the code declares only the vars that it needs.
6592 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6593 * s/cygwin.h (PTY_ITERATION): Likewise.
6594 * s/darwin.h (PTY_ITERATION): Likewise.
6595 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6596
57048744
PE
6597 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6598 * process.c (allocate_pty): Don't declare stb unless it's needed.
6599
7914961c 6600 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6601 (CONSTANTLIM): Remove; unused.
6602 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6603 Define only if needed.
7914961c 6604
b3967b18
PE
6605 * unexelf.c (unexec): Name an expression,
6606 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6607 Use a different way to cause a compilation error if anyone uses
6608 n rather than nn, a way that does not involve shadowing.
73366a00 6609 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6610
29a6015a
PE
6611 * deps.mk (unexalpha.o): Remove; unused.
6612
43cfc33e 6613 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6614 * unexec.h: New file.
ce701a33
PE
6615 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6616 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6617 Depend on unexec.h.
6618 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6619 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6620 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6621 Change as necessary to match prototype in unexec.h.
ce701a33 6622
01f44d5a
PE
6623 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6624 shadowing.
4f63c6bb 6625 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6626
a6670b0b
PE
6627 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6628 Rename locals to avoid shadowing.
6629
cef2010d 6630 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6631 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6632
d4d7173a
PE
6633 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6634
f08b802a
PE
6635 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6636 warning when compiling print.c.
6637
3ddb0639
PE
6638 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6639 instead of using an uninitialized var.
5ad03b97 6640 (font_sort_entities): Mark var as initialized.
3ddb0639 6641
170a2692
PE
6642 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6643
e663c700
PE
6644 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6645 pointers to constants.
89bc529a 6646 (font_parse_fcname): Remove unused vars.
7b81e2d0 6647 (font_delete_unmatched): Now static.
ea838e10 6648 (font_get_spec): Remove; unused.
13a547c6
PE
6649 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6650 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6651 Rename or move locals to avoid shadowing.
e663c700 6652
2a80c887 6653 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6654 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6655
1384fa33 6656 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6657 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6658
8b2c52e9
PE
6659 * alloc.c (mark_backtrace): Move decl from here ...
6660 * lisp.h: ... to here, so that it can be checked.
6661
475545b5 6662 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6663 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6664 (lisp_indirect_variable): Name an expression,
6665 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6666 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6667
b1349114 6668 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6669 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6670 Use const pointer when appropriate.
b1349114 6671
a2928364
PE
6672 * lisp.h (get_system_name, get_operating_system_release):
6673 Move decls here, to check interfaces.
6674 * process.c (get_operating_system_release): Move decl to lisp.h.
6675 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6676 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6677 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6678 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6679 (Fformat_time_string, Fencode_time, Finsert_char):
6680 (Ftranslate_region_internal, Fformat):
6681 Rename or remove local vars to avoid shadowing.
9710023e 6682 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6683
a415e694
PE
6684 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6685 avoid shadowing.
6686
8ef4622d
PE
6687 * lisp.h (eassert): Check that the argument compiles, even if
6688 ENABLE_CHECKING is not defined.
6689
946f9a5b
PE
6690 * data.c (Findirect_variable): Name an expression, to avoid
6691 gcc -Wbad-function-cast warning.
112396d6 6692 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6693 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6694 (Fmake_variable_buffer_local, Fmake_local_variable):
6695 Mark variables as initialized.
52746918 6696 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6697
e5aab7e7 6698 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6699 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6700 Rename locals to avoid shadowing.
dff45157
PE
6701 (mark_stack): Move local variables into the #ifdef region where
6702 they're used.
7bc26fdb
PE
6703 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6704 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6705 needed otherwise.
6706 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6707 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6708 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6709
e5aab7e7
PE
6710 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6711 avoids undefined behavior in theory.
6712
4da60324
PE
6713 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6714
88043301
PE
6715 Use functions, not macros, for up- and down-casing (Bug#8254).
6716 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6717 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6718 to use the following functions instead of these macros.
6719 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6720 EMACS_INT, since callers assume the returned value fits in int.
6721 (upcase1): Likewise, for UPCASE_TABLE.
6722 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6723 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6724 the race-condition problem in the old DOWNCASE.
88043301 6725
19ed5445
PE
6726 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6727 Rename locals to avoid shadowing.
6728 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6729 (regex_compile, re_search_2, re_match_2_internal):
6730 Remove unused local vars.
952db0d7
PE
6731 (FREE_VAR): Rewrite so as not to use empty "else",
6732 which gcc can warn about.
da053e48 6733 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6734 (RETALLOC_IF): Define only if needed.
6735 (WORDCHAR_P): Likewise. This one is never needed, but is used
6736 only in a comment talking about a compiler bug, so put inside
6737 the #if 0 of that comment.
6738 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6739 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6740 Remove; unused.
19ed5445 6741
1f3561e4 6742 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6743 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6744 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6745
ded6f8f7
PE
6746 * search.c (simple_search): Remove unused var.
6747
dbd37a95
PE
6748 * dired.c (compile_pattern): Move decl from here ...
6749 * lisp.h: ... to here, so that it can be checked.
6750 (struct re_registers): New forward decl.
6751
7e47afad
PE
6752 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6753
85f24f61
PE
6754 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6755 All uses changed.
6756 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6757 Rename locals to avoid shadowing.
5671df8f 6758 (Fvertical_motion): Mark locals as initialized.
85f24f61 6759
181aa2be 6760 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6761 (casify_region): Mark local as initialized.
181aa2be 6762
930d429c
PE
6763 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6764
7082eac6
PE
6765 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6766 New macros, so that the caller can use some names other than
6767 gcpro1, gcpro2, etc.
6768 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6769 of the new macros.
6770 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6771 argument, for consistency with GCPRO2_VAR, etc: it is now the
6772 prefix of the variable, not the variable itself. All uses
6773 changed.
38b2c076
PE
6774 * dired.c (directory_files_internal, file_name_completion):
6775 Rename locals to avoid shadowing.
6776
15206ed9
PE
6777 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6778 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6779 dired.c's scmp function, had undefined behavior.
6780 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6781 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6782 * buffer.h: ... to here, because these macros use current_buffer,
6783 and the new implementation with inline functions needs to have
6784 current_buffer in scope now, rather than later when the macros
6785 are used.
6786 (downcase, upcase1): New static inline functions.
6787 (DOWNCASE, UPCASE1): Reimplement using these functions.
6788 This avoids undefined behavior in expressions like
6789 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6790 from race conditions in accessing the global variables
6791 case_temp1 and case_temp2.
6792 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6793 * lisp.h (case_temp1, case_temp2): Remove their decls.
6794 * character.h (ASCII_CHAR_P): Move from here ...
6795 * lisp.h: ... to here, so that the inline functions mentioned
6796 above can use them.
6797
4a6bea26
PE
6798 * dired.c (directory_files_internal_unwind): Now static.
6799
f14b7e14
PE
6800 * fileio.c (file_name_as_directory, directory_file_name):
6801 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6802 Now static.
2893f146
PE
6803 (file_name_as_directory): Use const pointers when appropriate.
6804 (Fexpand_file_name): Likewise. In particular, newdir might
6805 point at constant storage, so make it a const pointer.
fd4ead52 6806 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6807 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6808 signedness issues.
f839df0c
PE
6809 (Fset_file_times, Finsert_file_contents, auto_save_error):
6810 Rename locals to avoid shadowing.
f14b7e14 6811
5716756e 6812 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6813 (Ftry_completion, Fall_completions): Rename or remove locals
6814 to avoid shadowing.
5716756e 6815
b4c3046a
PE
6816 * marker.c (bytepos_to_charpos): Remove; unused.
6817
b45db522
PE
6818 * lisp.h (verify_bytepos, count_markers): New decls,
6819 so that gcc does not warn that these functions aren't declared.
6820
85876d07
PE
6821 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6822 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6823 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6824 (copy_text): Remove unused local var.
85876d07 6825
03d78a21 6826 * filelock.c (within_one_second): Now static.
b3dd38ab 6827 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6828
5df8f01b
PE
6829 * buffer.c (fix_overlays_before): Mark locals as initialized.
6830 (fix_start_end_in_overlays): Likewise. This function should be
6831 simplified by using pointers-to-pointers, but that's a different
6832 matter.
b1d876f1 6833 (switch_to_buffer_1): Now static.
8f54f30a
PE
6834 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6835 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6836
a70072c9 6837 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6838 Fix pointer signedness issue.
edced198
PE
6839 (sys_subshell): Mark local as volatile if checking for lint,
6840 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6841 (MAXPATHLEN): Define only if needed.
a70072c9 6842
a0977c44
PE
6843 * process.c (serial_open, serial_configure): Move decls from here ...
6844 * systty.h: ... to here, so that they can be checked.
6845
a884fdcc
PE
6846 * fns.c (get_random, seed_random): Move extern decls from here ...
6847 * lisp.h: ... to here, so that they can be checked.
6848
604efe86 6849 * sysdep.c (reset_io): Now static.
b8950c94 6850 (wait_for_termination_signal): Remove; unused.
604efe86 6851
38fc62d9
PE
6852 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6853 (copy_keymap_item, append_key, push_text_char_description):
6854 Now static.
1004a21a 6855 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6856 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6857 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6858 (describe_map_tree):
6859 Rename locals to avoid shadowing.
38fc62d9 6860
2f2650da
PE
6861 * keyboard.c: Declare functions static if they are not used elsewhere.
6862 (echo_char, echo_dash, cmd_error, top_level_2):
6863 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6864 (read_char, kbd_buffer_get_event, make_lispy_position):
6865 (make_lispy_event, make_lispy_movement, apply_modifiers):
6866 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6867 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6868 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6869 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6870 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6871
a053e86c 6872 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6873 (mark_kboards): Move decl here ...
6874 * alloc.c (mark_kboards): ... from here.
a053e86c 6875
4752793e
PE
6876 * lisp.h (force_auto_save_soon): New decl.
6877
74f10ca7 6878 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6879 (DEFINE_DUMMY_FUNCTION): New macro.
6880 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6881 Use it.
c03cd23f
PE
6882 (main): Add casts to avoid warnings
6883 if GCC considers string literals to be constants.
74f10ca7 6884
022e70d4
PE
6885 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6886
59d6fe83
PE
6887 * dbusbind.c: Pointer signedness fixes.
6888 (xd_signature, xd_append_arg, xd_initialize):
6889 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6890 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6891 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6892 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6893
78320123
PE
6894 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6895 if GCC considers string literals to be constants.
49cebcca 6896 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6897
35ac2a97
SM
68982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6899
fb103ca9
SM
6900 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6901 (print_preprocess, print_object): New macro to fix last change.
6902
35ac2a97
SM
6903 * print.c (print_preprocess): Don't forget font objects.
6904
62973b41
JB
69052011-03-16 Juanma Barranquero <lekktu@gmail.com>
6906
6907 * emacs.c (USAGE3): Doc fixes.
6908
0e48bb22
AS
69092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6910
6911 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6912 structure.
6913
7684e57b
JB
69142011-03-14 Juanma Barranquero <lekktu@gmail.com>
6915
6916 * lisp.h (VWindow_system, Qfile_name_history):
6917 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6918 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6919 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6920
6921 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6922 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6923
6924 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6925 * w32console.c (detect_input_pending, read_input_pending)
6926 (encode_terminal_code):
6927 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6928 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6929 (w32_system_caret_y, Qfile_name_history):
6930 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6931 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6932 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6933 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6934 * w32proc.c (Qlocal, report_file_error):
6935 * w32term.c (Vwindow_system, updating_frame):
6936 * w32uniscribe.c (initialized, uniscribe_font_driver):
6937 Remove unneeded extern declarations.
6938
2aa46d6c
CY
69392011-03-14 Chong Yidong <cyd@stupidchicken.com>
6940
c96bbc66 6941 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6942
cffc6f3b
CY
69432011-03-13 Chong Yidong <cyd@stupidchicken.com>
6944
6945 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6946 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6947 These macros can no longer be used for assignment.
6948
44f230aa
SM
6949 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6950 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6951 (record_buffer_markers, fetch_buffer_markers): New functions for
6952 recording and fetching special buffer markers.
6953 (set_buffer_internal_1, set_buffer_temp): Use them.
6954
6955 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6956
6957 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6958
6959 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6960 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6961
6962 * xdisp.c (hscroll_window_tree):
6963 (reconsider_clip_changes): Use PT instead of BUF_PT.
6964
d251f04b
EZ
69652011-03-13 Eli Zaretskii <eliz@gnu.org>
6966
6967 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6968 $(EMACS_ROOT)/lib/intprops.h.
6969
f0c77cd1
PE
69702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6971
3eca4629
PE
6972 Fix more problems found by GCC 4.5.2's static checks.
6973
7c86ee98
PE
6974 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6975 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6976 (xg_free_frame_widgets): Make it clear that a local variable is
6977 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6978 (gdk_window_get_screen): Make it clear that this macro is needed
6979 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6980 (int_gtk_range_get_value): New function, which avoids a diagnostic
6981 from gcc -Wbad-function-cast.
6982 (xg_set_toolkit_scroll_bar_thumb): Use it.
6983 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6984 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6985 (get_utf8_string, xg_get_file_with_chooser):
6986 Rename locals to avoid shadowing.
6987 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6988
41729b81
PE
6989 * xgselect.c (xg_select): Remove unused var.
6990
f0c77cd1
PE
6991 * image.c (four_corners_best): Mark locals as initialized.
6992 (gif_load): Initialize transparent_p to zero (Bug#8238).
6993 Mark another local as initialized.
ec6cf4c6 6994 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6995
ce0ad53d 6996 * image.c (clear_image_cache): Now static.
d5d5a617 6997 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6998 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6999 (x_edge_detection): Remove unnecessary cast that
7000 gcc -Wbad-function-cast diagnoses.
2037898d 7001 (gif_load): Fix pointer signedness.
6ae141d6
PE
7002 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7003 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7004
33383987 70052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7006
d32df629
PE
7007 Improve quality of tests for time stamp overflow.
7008 For example, without this patch (encode-time 0 0 0 1 1
7009 1152921504606846976) returns the obviously-bogus value (-948597
7010 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7011 reports time overflow. See
7012 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7013 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7014 * editfns.c: Include limits.h and intprops.h.
7015 (TIME_T_MIN, TIME_T_MAX): New macros.
7016 (time_overflow): Move earlier, to before first use.
7017 (hi_time, lo_time): New functions, for an accurate test for
7018 out-of-range times.
7019 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7020 (Fget_internal_run_time): Don't assume time_t fits in int.
7021 (make_time): Use list2 instead of Fcons twice.
7022 (Fdecode_time): More accurate test for out-of-range times.
7023 (check_tm_member): New function.
7024 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7025 (lisp_time_argument): Don't rely on undefined left-shift and
7026 right-shift behavior when checking for time stamp overflow.
8be6f318 7027
fe31d94c
PE
7028 * editfns.c (time_overflow): New function, refactoring common code.
7029 (Fformat_time_string, Fdecode_time, Fencode_time):
7030 (Fcurrent_time_string): Use it.
7031
8be6f318
PE
7032 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7033 * dired.c (make_time): Move to ...
7034 * editfns.c (make_time): ... here.
7035 * systime.h: Note the move.
7036
09d9db2c 70372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7038
126bc0dc
YM
7039 * fringe.c (update_window_fringes): Remove unused variables.
7040
c47cbdfd
YM
7041 * unexmacosx.c (copy_data_segment): Also copy __got section.
7042 (Bug#8223)
7043
7ac80be9
EZ
70442011-03-12 Eli Zaretskii <eliz@gnu.org>
7045
c96bbc66 7046 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7047 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7048 Constify `char *' arguments and their references according to
7049 prototypes in tparam.h.
7050
ecb0f94d 7051 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7052
7ac80be9
EZ
7053 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7054 Adapt all references accordingly.
7055
7056 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7057
ef1fd07e
TT
70582011-03-11 Tom Tromey <tromey@redhat.com>
7059
7060 * buffer.c (syms_of_buffer): Remove obsolete comment.
7061
7ef4b50c
EZ
70622011-03-11 Eli Zaretskii <eliz@gnu.org>
7063
7064 * termhooks.h (encode_terminal_code): Declare prototype.
7065
7066 * msdos.c (encode_terminal_code): Don't declare prototype.
7067
7068 * term.c (encode_terminal_code): Now external again, used by
7069 w32console.c and msdos.c.
7070
44f230aa
SM
7071 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7072 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7073
4b1ec863 70742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7075
1714f52b 7076 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7077
4b1ec863
PE
7078 * fringe.c (update_window_fringes): Mark locals as initialized
7079 (Bug#8227).
7080 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7081
524c7aa6
PE
7082 * alloc.c (mark_fringe_data): Move decl from here ...
7083 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7084 to check its interface.
7085 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7086
a5c0af81 7087 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7088 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7089 (fontset_font): Mark local as initialized.
a9a06e0b 7090 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7091
b4716021
PE
7092 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7093
811e9bac 7094 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7095 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7096 (x_own_selection, Fx_disown_selection_internal): Rename locals
7097 to avoid shadowing.
7098 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7099
7e3ab302
PE
7100 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7101 so that the caller can use some name other than gcpro1.
7102 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7103 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7104 (Fx_backspace_delete_keys_p):
7105 Use them to avoid shadowing, and rename vars to avoid shadowing.
7106 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7107 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7108 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7109 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7110 Remove unused locals.
7e3ab302
PE
7111 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7112 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7113 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7114 macros.
f78faa98 7115
e2b13473
PE
7116 * xterm.h (x_mouse_leave): New decl.
7117
77f23912
PE
7118 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7119 Remove unused functions.
cdf4ba58
PE
7120 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7121 (x_calc_absolute_position): Now static.
7411c686 7122 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7123 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7124 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7125 unless they are used.
38d0b34a
PE
7126 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7127 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7128 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7129 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7130 (x_error_catcher, x_connection_closed, x_error_handler):
7131 (x_error_quitter, xembed_send_message, x_iconify_frame):
7132 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7133 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7134 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7135
44f230aa
SM
7136 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7137 Rename or move locals to avoid shadowing.
6b463e58 7138 (tty_defined_color, merge_face_heights): Now static.
5967d051 7139 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7140 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7141 does not deduce is never used uninitialized.
73719eba
PE
7142 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7143 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7144
426994c3 7145 * terminal.c (store_terminal_param): Now static.
5489860b 7146
032f1620 7147 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7148 (set_frame_menubar): Remove unused local.
d4323972 7149 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7150 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7151 since they might point to immutable storage.
281585b0
PE
7152 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7153 since it's unused otherwise.
032f1620 7154
367c19e5 7155 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7156 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7157 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7158 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7159 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7160 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7161 does not deduce are never used uninitialized.
70739cbe 7162
07b48fa9
PE
7163 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7164
8868a238 7165 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7166 * window.c (window_loop, size_window):
7167 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7168
7e5cf297 7169 * window.c (display_buffer): Now static.
d6550a9f
PE
7170 (size_window): Mark variables that gcc -Wuninitialized
7171 does not deduce are never used uninitialized.
a586633d
PE
7172 * window.h (check_all_windows): New decl, to forestall
7173 gcc -Wmissing-prototypes diagnostic.
5b555da1 7174 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7175
f6095868
PE
7176 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7177 shadowing.
7178 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7179 Include <limits.h>.
7180 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7181 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7182 (load_charset_map): Mark variables that gcc -Wuninitialized
7183 does not deduce are never used uninitialized.
53df7c11 7184 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7185
f38b440c
PE
7186 * coding.c (coding_set_source, coding_set_destination):
7187 Use "else { /* comment */ }" rather than "else /* comment */;"
7188 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7189 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7190 a block, when the outer 'i' will do.
7191 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7192 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7193 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7194 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7195 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7196 Rename locals to avoid shadowing.
7197 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7198 * coding.c (emacs_mule_char, encode_invocation_designation):
7199 Now static, since they're not used elsewhere.
413bb2db 7200 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7201 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7202 (decode_coding_emacs_mule): Mark variables that gcc
7203 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7204 (detect_coding_iso_2022): Initialize a local variable that might
7205 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7206 this initialization is needed. (Bug#8211)
5f58e762
PE
7207 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7208 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7209 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7210 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7211 Remove unused macros.
f38b440c 7212
232b38b9 7213 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7214 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7215 * character.c (string_count_byte8): Likewise.
232b38b9 7216
fb90da1b
PE
7217 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7218 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7219
fb93dbc2
PE
7220 * chartab.c (copy_sub_char_table): Now static, since it's not used
7221 elsewhere.
5c156ace
PE
7222 (sub_char_table_ref_and_range, char_table_ref_and_range):
7223 Rename locals to avoid shadowing.
bbcd0949 7224 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7225
7d3b3862 7226 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7227 (BIDI_BOB): Remove unused macro.
7d3b3862 7228
6be7d3da
PE
7229 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7230 deduce are never used uninitialized.
c2ed9c8b 7231 * term.c (encode_terminal_code): Likewise.
6be7d3da 7232
75f8807f 7233 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7234
50938595
PE
7235 * tparam.h: New file.
7236 * term.c, tparam.h: Include it.
7237 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7238 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7239 Move these decls to tparam.h, and make them agree with what
7240 is actually in tparam.c. The previous trick of using incompatible
7241 decls in different modules does not conform to the C standard.
7242 All callers of tparam changed to use tparam's actual API.
7243 * tparam.c (tparam1, tparam, tgoto):
7244 Use const pointers where appropriate.
7245
fbceeba2
PE
7246 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7247 * cm.h (struct cm): Likewise.
7248 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7249 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7250 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7251 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7252 (turn_on_face, init_tty): Likewise.
7253 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7254
7f3f1250
PE
7255 * term.c (term_mouse_position): Rename local to avoid shadowing.
7256
e6ca6543
PE
7257 * alloc.c (mark_ttys): Move decl from here ...
7258 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7259
c40f8d15
AS
72602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7261
7262 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7263
cfe0661d
JB
72642011-03-09 Juanma Barranquero <lekktu@gmail.com>
7265
7266 * search.c (compile_pattern_1): Remove argument regp, unused since
7267 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7268 (compile_pattern): Don't pass it.
7269
0afb4571
J
72702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7271
7272 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7273 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7274 for ! HAVE_GTK3.
7275 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7276
7277 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7278
7279 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7280 gdk_window_get_screen, gdk_window_get_geometry,
7281 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7282 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7283 (xg_get_pixbuf_from_pixmap): New function.
7284 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7285 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7286 Call xg_get_pixbuf_from_pixmap instead of
7287 gdk_pixbuf_get_from_drawable.
7288 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7289 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7290 (xg_check_special_colors): Use GtkStyleContext and its functions
7291 for HAVE_GTK3.
7292 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7293 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7294 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7295 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7296 Call gtk_widget_get_preferred_size.
0afb4571
J
7297 (xg_frame_resized): gdk_window_get_geometry only takes 5
7298 parameters.
44f230aa
SM
7299 (xg_win_to_widget, xg_event_is_for_menubar):
7300 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7301 (xg_set_widget_bg): New function.
7302 (delete_cb): New function.
895009e1 7303 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7304 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7305 (xg_set_background_color): Call xg_set_widget_bg.
7306 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7307 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7308 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7309 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7310 if ! HAVE_GTK3.
7311 (update_frame_tool_bar): Call gtk_widget_hide.
7312 (xg_initialize): Use GDK_KEY_g.
7313
7314 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7315 if ! HAVE_GTK3
7316 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7317
7318 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7319 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7320 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7321
1c2cc4ef
JB
73222011-03-08 Juanma Barranquero <lekktu@gmail.com>
7323
7324 * w32xfns.c (select_palette): Check success of RealizePalette against
7325 GDI_ERROR, not zero.
7326
33383987 7327See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7328
7329;; Local Variables:
7330;; coding: utf-8
aac0c6e3
MR
7331;; End:
7332
33383987 7333 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7334
7335 This file is part of GNU Emacs.
7336
7337 GNU Emacs is free software: you can redistribute it and/or modify
7338 it under the terms of the GNU General Public License as published by
7339 the Free Software Foundation, either version 3 of the License, or
7340 (at your option) any later version.
7341
7342 GNU Emacs is distributed in the hope that it will be useful,
7343 but WITHOUT ANY WARRANTY; without even the implied warranty of
7344 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7345 GNU General Public License for more details.
7346
7347 You should have received a copy of the GNU General Public License
7348 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.