* lisp/custom.el (custom-initialize-delay): Doc fix.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c89926a5
CY
12012-06-27 Chong Yidong <cyd@gnu.org>
2
3 * doc.c (Fsubstitute_command_keys): Fix punctuation.
4
ed6b3510
JW
52012-06-26 John Wiegley <johnw@newartisans.com>
6
157e99e4
JW
7 * unexmacosx.c (copy_data_segment): Added two section names used
8 on Mac OS X Lion: __mod_init_func and __mod_term_func.
9
ed6b3510
JW
10 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
11 when building with Clang.
12
8edd4a2b
SM
132012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
14
15 * eval.c (Fapply): Allow calling it with a single argument.
16
f6f62d1b
EZ
172012-06-26 Eli Zaretskii <eliz@gnu.org>
18
19 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
20 _stricmp and _strnicmp.
21 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
22
62efea5e
DA
232012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
24
25 * alloc.c (allocate_window): Zero out non-Lisp part of newly
26 allocated window.
27 (allocate_process): Likewise for new process.
8edd4a2b 28 (allocate_terminal): Change to use offsetof.
62efea5e
DA
29 (allocate_frame): Likewise.
30 * frame.c (make_frame): Omit redundant initialization.
31 * window.c (make_parent_window): Use memset.
32 (make_window): Omit redundant initialization.
33 * process.c (make_process): Omit redundant initialization.
34 * terminal.c (create_terminal): Likewise.
35
42997f4d
DA
362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
37
38 * term.c (delete_tty): Remove redundant call to memset.
39
1130ecfc
DA
402012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
41
42 * alloc.c: Remove build_string.
43 * lisp.h: Define build_string as static inline. This provides
44 a better opportunity to optimize away calls to strlen when the
45 function is called with compile-time constant argument.
46 * image.c (imagemagick_error): Convert to build_string.
47 * w32proc.c (sys_spawnve): Likewise.
48 * xterm.c (x_term_init): Likewise.
49
cf38a720
PE
502012-06-26 Paul Eggert <eggert@cs.ucla.edu>
51
99027bdd
PE
52 Use sprintf return value instead of invoking strlen on result.
53 In the old days this wasn't portable, since some sprintf
54 implementations returned char *. But they died out years ago and
55 Emacs already assumes sprintf returns int.
56 Similarly for float_to_string.
57 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
58 * ccl.c (ccl_driver):
59 * character.c (string_escape_byte8):
60 * data.c (Fnumber_to_string):
61 * doprnt.c (doprnt):
62 * print.c (print_object):
63 * xdisp.c (message_dolog):
64 * xfns.c (syms_of_xfns):
65 Use sprintf or float_to_string result to avoid need to call strlen.
66 * data.c (Fnumber_to_string):
67 Use make_unibyte_string, since the string must be ASCII.
68 * lisp.h, print.c (float_to_string): Now returns int length.
69 * term.c (produce_glyphless_glyph):
70 Use sprintf result rather than recomputing it.
71
cf38a720
PE
72 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
73 * Makefile.in (ALL_CFLAGS):
74 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
75 * gmalloc.c, regex.c: Include <config.h> unconditionally.
76
3511c784
DA
772012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
78
0a08eb21 79 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
80 strcasecmp if available.
81 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
82
fb7da12e
AS
832012-06-25 Andreas Schwab <schwab@linux-m68k.org>
84
85 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
86 Avoid comma operator.
87 * menu.c (push_submenu_start, push_submenu_end)
88 (push_left_right_boundary, push_menu_pane): Likewise.
89 * msdos.c (dos_rawgetc): Likewise.
90
afa2ffd8
DA
912012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
92
93 * xfns.c (xic_create_fontsetname): Remove redundant calls
94 to memset.
95
b3b4476b
PE
962012-06-25 Paul Eggert <eggert@cs.ucla.edu>
97
4495ff38
PE
98 * gtkutil.c (get_utf8_string): Remove redundant assignment.
99 sprintf already null-terminates its output.
100
b3b4476b
PE
101 * xfns.c (x_window): Remove redundant cast.
102
b00876c9
DA
1032012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
104
105 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
106 `const char *' to `char *' to avoid compiler warning.
107
d188e26b
PE
1082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
109
885d1d74
PE
110 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
111 instead of truncating it to 63 (admittedly a generous limit).
112
d188e26b
PE
113 * process.c: Fix spelling and caps in comments.
114
e2f560b1
DN
1152012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
116
e86db54b 117 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
118 * sysdep.c (setpgrp): Remove definition, not used in this file.
119
7583a3a1
JB
1202012-06-24 Juanma Barranquero <lekktu@gmail.com>
121
122 * makefile.w32-in: Update dependencies.
123
696056c2
EZ
1242012-06-24 Eli Zaretskii <eliz@gnu.org>
125
126 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
127 (SYSTIME_H): Add nt/inc/sys/time.h.
128
129 * systime.h [WINDOWSNT]: Include sys/time.h.
130
131 * s/ms-w32.h (struct timespec): Definition moved from
132 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
133
845ca893
PE
1342012-06-24 Paul Eggert <eggert@cs.ucla.edu>
135
136 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
137 * buffer.h (buffer_slot_type_mismatch):
138 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
139 * eval.c (unwind_to_catch):
140 * image.c (my_png_error, my_error_exit):
141 * keyboard.c (quit_throw_to_read_char, user_error)
142 (Fexit_recursive_edit, Fabort_recursive_edit):
143 * lisp.h (die, args_out_of_range, args_out_of_range_3)
144 (wrong_type_argument, buffer_overflow, __executable_start)
145 (memory_full, buffer_memory_full, string_overflow, Fthrow)
146 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
147 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
148 (fatal):
149 (child_setup) [!DOS_NT]:
150 * lread.c (end_of_file_error, invalid_syntax):
151 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
152 * puresize.h (pure_write_error):
153 * search.c (matcher_overflow):
154 * sound.c (sound_perror, alsa_sound_perror):
155 * sysdep.c, syssignal.h (croak):
156 * term.c (maybe_fatal, vfatal):
157 * textprop.c (text_read_only):
158 * undo.c (user_error):
159 * unexmacosx.c (unexec_error):
160 * xterm.c (x_ins_del_lines, x_delete_glyphs):
161 Use _Noreturn rather than NO_RETURN.
162 No need for separate decl merely because of _Noreturn.
163 * sound.c (sound_warning, parse_sound):
164 Remove unnecessary forward decls.
165
f1dd8073
PE
1662012-06-24 Paul Eggert <eggert@cs.ucla.edu>
167
168 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
169 * lisp.h (WAIT_READING_MAX): New macro.
170 * dispnew.c (Fsleep_for, sit_for):
171 * keyboard.c (kbd_buffer_get_event):
172 * process.c (Faccept_process_output):
173 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
174 This improves on the previous patch, which introduced a bug
175 when time_t is unsigned and as wide as intmax_t.
176 See <http://bugs.gnu.org/9000#51>.
177
b82c1755
EZ
1782012-06-23 Eli Zaretskii <eliz@gnu.org>
179
180 * dispnew.c (sit_for, Fsleep_for):
181 * keyboard.c (kbd_buffer_get_event):
182 * process.c (Faccept_process_output): Avoid compiler warnings when
183 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
184
ca300656
JB
1852012-06-23 Juanma Barranquero <lekktu@gmail.com>
186
049ec95b
JB
187 * makefile.w32-in: Update dependencies.
188
ca300656
JB
189 * w32.c (ltime): Add return type and declare static.
190 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
191
db7b8d06
PE
1922012-06-23 Paul Eggert <eggert@cs.ucla.edu>
193
194 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
195 Privately reported by Herbert J. Skuhra.
196 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
197 All uses changed.
198 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
199 not make_lisp_timeval, when the argument is of type EMACS_TIME.
200
0bd8297f
EZ
2012012-06-23 Eli Zaretskii <eliz@gnu.org>
202
96512555
EZ
203 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
204 last argument of make_unibyte_string.
205
0bd8297f
EZ
206 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
207 language ID in the event parameters.
208
209 * w32term.c (w32_read_socket): Put the new keyboard codepage into
210 event.code, not the obscure "character set ID".
211
63def6b6
CY
2122012-06-23 Chong Yidong <cyd@gnu.org>
213
214 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
215
e8a02204
EZ
2162012-06-23 Eli Zaretskii <eliz@gnu.org>
217
388cdec0
EZ
218 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
219 * w32.c (fdutimens): New function.
220
221 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
222
223 * s/ms-w32.h (pselect): Redirect to sys_select.
224
225 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
226
e8a02204
EZ
227 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
228 in the logic of incrementing and decrementing the value of
229 use_relocatable_buffers.
230
d054f3fb
PE
2312012-06-23 Paul Eggert <eggert@cs.ucla.edu>
232
233 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
234 Privately reported by Herbert J. Skuhra.
235 [__FreeBSD__]: Remove "*/" typo after "#include".
236 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
237 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
238 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
239 Don't assume EMACS_TIME and struct timeval are the same type.
240
d35af63c
PE
2412012-06-22 Paul Eggert <eggert@cs.ucla.edu>
242
243 Support higher-resolution time stamps (Bug#9000).
244 The time stamps are only nanosecond-resolution at the C level,
245 since that's the best that any real-world system supports now.
246 But they are picosecond-resolution at the Lisp level, as that's
247 easy, and leaves room for future OS improvements.
248
249 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
250 (LIBES): Use it.
251
252 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
253 Don't get current time unless it's needed.
254
255 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
256 now provides it if it's absent.
257 (start_atimer): Port to higher-res time stamps.
258 Check for time stamp overflow. Don't get current time more
259 often than is needed.
260
261 * buffer.h (struct buffer): Buffer modtime now has high resolution.
262 Include systime.h, not time.h.
263 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
264
265 * dired.c: Include stat-time.h.
266 (Ffile-attributes): File times now have higher resolution.
267
268 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
269 (struct image): Timestamp now has higher resolution.
270
271 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
272 has at least microseconds now. All uses removed.
273 (update_frame, update_single_window, update_window, update_frame_1)
274 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
275
276 * editfns.c (time_overflow): Now extern.
277 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
278 (float-time, Fformat_time_string, Fcurrent_time_string)
279 (Fcurrent_time_zone): Accept and generate higher-resolution
280 time stamps.
281 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
282 (decode_time_components, lisp_seconds_argument): New functions.
283 (make_time): Now static.
284 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
285 Report an error if the time is invalid, rather than having the caller
286 do that.
287
288 * fileio.c: Include <stat-time.h>
289 (Fcopy_file): Copy higher-resolution time stamps.
290 Prefer to set the time stamp via a file descriptor if that works.
291 (Fset_file_times, Finsert_file_contents, Fwrite_region)
292 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
293 (Fvisited_file_modtime, Fset_visited_file_modtime):
294 Support higher-resolution time stamps.
295
296 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
297
298 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
299
300 * image.c (prepare_image_for_display, clear_image_cache)
301 (lookup_image): Port to higer-resolution time stamps.
302
303 * keyboard.c (start_polling, bind_polling_period):
304 Check for time stamp overflow.
305 (read_char, kbd_buffer_get_event, timer_start_idle)
306 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
307 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
308 Port to higher-resolution time stamps. Do not assume time_t is signed.
309 (decode_timer): New function. Timers are now vectors of length 9,
310 not 8, to accommodate the picosecond component.
311 (timer_check_2): Use it.
312
313 * nsterm.m (select_timeout, timeval_subtract): Remove.
314 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
315 as they're a bit more accurate and handle overflow better.
316 (ns_select): Change prototype to be compatible with pselect.
317 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
318 * nsterm.h (ns_select): Adjust prototype.
319
320 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
321 us-resolution time stamps.
322 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
323
324 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
325
326 * lisp.h (time_overflow): New decl.
327 (wait_reading_process_output): First arg is now intmax_t, not int,
328 to accommodate larger waits.
329
330 * process.h (struct Lisp_Process.read_output_delay):
331 Now counts nanoseconds, not microseconds.
332 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
333 EMACS_HAS_USECS.
334 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
335 (wait_reading_process_output):
336 Port to ns-resolution time stamps.
337 (Faccept_process_output, wait_reading_process_output):
338 Check for time stamp overflow. Do not assume time_t is signed.
339 (select_wrapper): Remove; we now use pselect.
340 (Fprocess_attributes): Now generates ns-resolution time stamps.
341
342 * sysdep.c: Include utimens.h. Don't include utime.h
343 or worry about struct utimbuf; gnulib does that for us now.
344 (gettimeofday): Remove; gnulib provides a substitute.
345 (make_timeval): New function.
346 (set_file_times): Now sets ns-resolution time stamps.
347 New arg FD; all uses changed.
348 (time_from_jiffies, ltime_from_jiffies, get_up_time)
349 (system_process_attributes):
350 Now returns ns-resolution time stamp. All uses changed.
351 Check for time stamp overflow.
352
353 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
354 provides a substitute now.
355
356 * systime.h: Include timespec.h rather than sys/time.h and time.h,
357 since it guarantees struct timespec.
358 (EMACS_TIME): Now struct timespec, so that we can support
359 ns-resolution time stamps.
360 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
361 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
362 (EMACS_USECS): Remove.
363 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
364 so multiply the arg by 1000 before storing it.
365 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
366 New macros.
367 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
368 Port to ns-resolution time stamps.
369 (EMACS_TIME_NEG_P): Remove; replaced by....
370 (EMACS_TIME_SIGN): New macro.
371 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
372 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
373 (set_file_times, make_time, lisp_time_argument): Adjust signature.
374 (make_timeval, make_lisp_time, decode_time_components): New decls.
375 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
376 that it mishandled time_t overflow. You can't compare by subtracting!
377 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
378 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
379
380 * term.c: Include <sys/time.h>.
381 (timeval_to_Time): New function, for proper overflow wraparound.
382 (term_mouse_position, term_mouse_click): Use it.
383
384 * undo.c (record_first_change): Support higher-resolution time stamps
385 in the undo buffer.
386 (Fprimitive_undo): Use them when restoring time stamps.
387
388 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
389 (w32_get_internal_run_time):
390 Port to higher-resolution Emacs time stamps.
391 (ltime): Now accepts single 64-bit integer, as that's more convenient
392 for callers.
393
394 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
395
396 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
397 for compatibility with pselect. Support ns-resolution time stamps.
398
399 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
400
401 * xselect.c (wait_for_property_change, x_get_foreign_selection):
402 Check for time stamp overflow, and support ns-resolution time stamps.
403
404 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
405 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
406 (timeval_subtract): Remove; no longer needed.
407 (XTflash, XTring_bell, x_wait_for_event):
408 Port to ns-resolution time stamps. Don't assume time_t is signed.
409
b6a92dfe
CY
4102012-06-22 Chong Yidong <cyd@gnu.org>
411
412 * xdisp.c (x_consider_frame_title): Revert last change.
413
d251c37c
EZ
4142012-06-22 Eli Zaretskii <eliz@gnu.org>
415
416 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
417 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
418 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
419 staticidx goes up to 1597 out of 1600 = 0x640.)
420
f10deafb
PE
4212012-06-20 Paul Eggert <eggert@cs.ucla.edu>
422
423 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
424 Otherwise, the umask might be mistakenly 0 while handling input signals.
425
ec6de1e2
SM
4262012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
427
428 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
429
28be1ada
DA
4302012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
431
432 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
433 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
434 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
435 access to `contents' member of Lisp_Vector objects with AREF and ASET
436 where appropriate.
437
c6bf3022
CY
4382012-06-19 Chong Yidong <cyd@gnu.org>
439
440 * frame.c (delete_frame): When selecting a frame on a different
441 text terminal, do not alter the terminal's top-frame.
442
443 * xdisp.c (format_mode_line_unwind_data): Record the target
444 frame's selected window and its terminal's top-frame.
445 (unwind_format_mode_line): Restore them.
446 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
447 Callers changed.
448 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
449 since tty frames can be explicitly named.
450 (prepare_menu_bars): Likewise.
451
452 * term.c (Ftty_top_frame): New function.
453
defd4196
PE
4542012-06-18 Paul Eggert <eggert@cs.ucla.edu>
455
456 Port byte-code-meter to modern targets.
457 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
458 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 459 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
460 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
461 (METER_1, METER_2): Simplify.
462
1053a871
SM
4632012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
464
465 * data.c (Fdefalias): Return `symbol' (bug#11686).
466
b7e8d081
MR
4672012-06-18 Martin Rudalics <rudalics@gmx.at>
468
469 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
470 gets killed during executing of this function (Bug#11665).
471 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
472 (Vkill_buffer_query_functions): In doc-string say that functions
473 run by this hook should not change the current buffer.
474
7ea2b339
PE
4752012-06-18 Paul Eggert <eggert@cs.ucla.edu>
476
477 Fix recently-introduced process.c problems found by static checking.
478 * process.c (write_queue_push, write_queue_pop, send_process):
479 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
480 (write_queue_pop): Fix pointer signedness problem.
481 (send_process): Remove unused local.
482
96a313a1
CY
4832012-06-17 Chong Yidong <cyd@gnu.org>
484
485 * xdisp.c (redisplay_internal): No need to redisplay terminal
486 frames that are not on top.
487
20ca2e94
TN
4882012-06-17 Troels Nielsen <bn.troels@gmail.com>
489
490 * process.c (make_process): Initialize write_queue.
491 (write_queue_push, write_queue_pop): New functions.
492 (send_process): Use them to maintain correct ordering of process
493 writes (Bug#10815).
494
9a900ca9
PE
4952012-06-17 Paul Eggert <eggert@cs.ucla.edu>
496
310fbfa8
PE
497 * lisp.h (eassert): Assume C89 or later.
498 This removes the need for CHECK.
499 (CHECK): Remove. Its comments about always evaluating its
500 argument were confusing, as 'eassert' typically does not evaluate
501 its argument.
502
27bb1ca4
PE
503 * coding.c (produce_chars): Use ptrdiff_t, not int.
504
9a900ca9
PE
505 * xterm.c (x_draw_underwave): Check for integer overflow.
506 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
507
41b7f8bc 5082012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
509
510 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
511 referenced (Bug#11583).
512
9b0e3eba
AA
5132012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
514
515 Implement wave-style variant of underlining.
516 * dispextern.h (face_underline_type): New enum.
517 (face): Add field for underline type.
518 * nsterm.m (ns_draw_underwave): New function.
519 (ns_draw_text_decoration): Use it.
520 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
521 New functions.
522 (x_draw_glyph_string): Use them.
523 * xfaces.c (Qline, Qwave): New Lisp objects.
524 (check_lface_attrs, merge_face_ref)
1053a871
SM
525 (Finternal_set_lisp_face_attribute, realize_x_face):
526 Handle wave-style underline face attributes.
9b0e3eba
AA
527 * xterm.c (x_draw_underwave): New function.
528 (x_draw_glyph_string): Use it.
529
0fb52f11
JB
5302012-06-16 Juanma Barranquero <lekktu@gmail.com>
531
532 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
533 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
534 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
535 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
536 ($(BLD)/w32select.$(O)): Update dependencies.
537
e5560ff7
AS
5382012-06-16 Andreas Schwab <schwab@linux-m68k.org>
539
540 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
541 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
542 * character.c (_fetch_multibyte_char_p): Remove.
543 * alloc.c: Include "character.h" before "buffer.h".
544 * bidi.c: Likewise.
545 * buffer.c: Likewise.
546 * bytecode.c: Likewise.
547 * callint.c: Likewise.
548 * callproc.c: Likewise.
549 * casefiddle.c: Likewise.
550 * casetab.c: Likewise.
551 * category.c: Likewise.
552 * cmds.c: Likewise.
553 * coding.c: Likewise.
554 * composite.c: Likewise.
555 * dired.c: Likewise.
556 * dispnew.c: Likewise.
557 * doc.c: Likewise.
558 * dosfns.c: Likewise.
559 * editfns.c: Likewise.
560 * emacs.c: Likewise.
561 * fileio.c: Likewise.
562 * filelock.c: Likewise.
563 * font.c: Likewise.
564 * fontset.c: Likewise.
565 * fringe.c: Likewise.
566 * indent.c: Likewise.
567 * insdel.c: Likewise.
568 * intervals.c: Likewise.
569 * keyboard.c: Likewise.
570 * keymap.c: Likewise.
571 * lread.c: Likewise.
572 * macros.c: Likewise.
573 * marker.c: Likewise.
574 * minibuf.c: Likewise.
575 * nsfns.m: Likewise.
576 * nsmenu.m: Likewise.
577 * print.c: Likewise.
578 * process.c: Likewise.
579 * regex.c: Likewise.
580 * region-cache.c: Likewise.
581 * search.c: Likewise.
582 * syntax.c: Likewise.
583 * term.c: Likewise.
584 * textprop.c: Likewise.
585 * undo.c: Likewise.
586 * unexsol.c: Likewise.
587 * w16select.c: Likewise.
588 * w32fns.c: Likewise.
589 * w32menu.c: Likewise.
590 * window.c: Likewise.
591 * xdisp.c: Likewise.
592 * xfns.c: Likewise.
593 * xmenu.c: Likewise.
594 * xml.c: Likewise.
595 * xselect.c: Likewise.
596
2f07e6af
EZ
5972012-06-16 Eli Zaretskii <eliz@gnu.org>
598
1053a871
SM
599 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
600 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 601 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
602 row.
603 (handle_face_prop): Use chunk-relative overlay string index when
604 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
605 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
606 the rightmost. (Bug#11720)
2f07e6af 607
29b83cec
AS
6082012-06-16 Andreas Schwab <schwab@linux-m68k.org>
609
610 * category.h (CHAR_HAS_CATEGORY): Define as inline.
611 (CATEGORY_MEMBER): Enforce 1/0 value.
612 * category.c (_temp_category_set): Remove.
613
4c5501e9
EZ
6142012-06-16 Eli Zaretskii <eliz@gnu.org>
615
616 * window.c (Fdelete_other_windows_internal)
617 (Fdelete_window_internal): Don't access frame's mouse highlight
618 info of the initial frame. (Bug#11677)
619
2b570124
PE
6202012-06-14 Paul Eggert <eggert@cs.ucla.edu>
621
e93864f9
PE
622 * .gdbinit (xgetint): Fix recently-introduced paren typo.
623 Assume USE_2_TAGS_FOR_INTS.
624 (xreload): Adjust $tagmask width to match recent lisp.h change.
625
2b570124
PE
626 Simplify lisp.h in minor ways that should not affect code.
627 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
628 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
629 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
630 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
631 (INTTYPEBITS): New macro, for clarity.
632 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
633 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
634 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
635 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
636 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
637
81755f69
JB
6382012-06-13 Juanma Barranquero <lekktu@gmail.com>
639
640 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
641
16192a57
GM
6422012-06-13 Glenn Morris <rgm@gnu.org>
643
644 * s/bsd-common.h (BSD4_3):
645 * s/usg5-4-common.h (USG5_4): No longer define; unused.
646
646b5f55
AS
6472012-06-13 Andreas Schwab <schwab@linux-m68k.org>
648
649 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
650 instead of union.
651 (XLI, XIL): Define.
1053a871
SM
652 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
653 Use them.
654 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 655 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 656 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
657 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
658 * frame.c (delete_frame): Remove outdated comment.
659 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
660 USE_LISP_UNION_TYPE.
661 (Fw32_unregister_hot_key): Likewise.
662 (Fw32_toggle_lock_key): Likewise.
663 * w32menu.c (add_menu_item): Likewise.
664 (w32_menu_display_help): Use XIL instead of checking
665 USE_LISP_UNION_TYPE.
666 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
667 (init_heap): Likewise.
668 * w32term.c (w32_read_socket): Update comment.
669
1d3823c9
GM
6702012-06-13 Glenn Morris <rgm@gnu.org>
671
c62ff706
GM
672 * s/usg5-4-common.h, src/s/unixware.h:
673 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
674
1d3823c9
GM
675 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
676
bfe3e0a2
PE
6772012-06-13 Paul Eggert <eggert@cs.ucla.edu>
678
679 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
680 * alloc.c (make_number) [!defined make_number]:
681 Remove, as lisp.h always defines this now.
682 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
683 (roundup_size): Verify that it is a power of 2.
684 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
685 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
686 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
687 -DUSE_LSB_TAG=0, to override the automatically-selected default.
688 USE_LSB_TAG now is always defined to be either 0 or 1.
689 All uses changed.
690 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
691 code works fine either way, and efficiency is not a concern here,
692 as the union type is for debugging, not for production.
693 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
694 Use an inline function on all platforms when using the union type,
695 since this is simpler and 'static inline' can be used portably
696 within Emacs now.
697 (LISP_INITIALLY_ZERO): New macro.
698 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
699 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
700
45fa9c0f
GM
7012012-06-12 Glenn Morris <rgm@gnu.org>
702
b4492cba
GM
703 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
704
705 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 706
45fa9c0f
GM
707 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
708 Move BROKEN_SIGIO to configure.
709
710 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
711 Move NO_TERMIO to configure.
712
0e25d334
CY
7132012-06-12 Chong Yidong <cyd@gnu.org>
714
715 * image.c (imagemagick_load_image): Use MagickFlattenImage if
716 MagickMergeImageLayers is undefined. Use pixel pusher loop if
717 MagickExportImagePixels is undefined.
718
43682bb6
PE
7192012-06-12 Paul Eggert <eggert@cs.ucla.edu>
720
721 * image.c (imagemagick_load_image): Remove unused label.
722
a9be7d2b
GM
7232012-06-11 Glenn Morris <rgm@gnu.org>
724
725 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
726 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
727 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
728 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
729
3017f87f
SM
7302012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
731
732 * alloc.c (make_byte_code): New function.
733 (Fmake_byte_code): Use it. Don't purify here.
734 * lread.c (read1): Use it as well to avoid extra allocation.
735
1b9b4cf4
CY
7362012-06-11 Chong Yidong <cyd@gnu.org>
737
738 * image.c (imagemagick_load_image): Implement transparency.
739
95988fcf
AS
7402012-06-10 Andreas Schwab <schwab@linux-m68k.org>
741
742 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
743 account for preceding backslashes. (Bug#11663)
744
cd4eb164
CY
7452012-06-09 Chong Yidong <cyd@gnu.org>
746
747 * term.c: Support italics in capable terminals (Bug#9652).
748 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
749 (turn_on_face): Output using TS_enter_italic_mode if available.
750 Don't handle unused blinking and alt-charset cases.
751 (turn_off_face): Handle italic case; discard unused tty_blinking_p
752 and tty_alt_charset_p cases.
753 (tty_capable_p, init_tty): Support italics.
754
755 * termchar.h (struct tty_display_info): Add field for italics.
756 Remove unused blink field.
757
758 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
759 Handle slant.
760
761 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
762 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
763 tty_alt_charset_p. Add tty_italic_p.
764
ff88beb8
MA
7652012-06-09 Michael Albinus <michael.albinus@gmx.de>
766
767 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
768 dbus_type_is_basic if available.
769 (xd_extract_signed, xd_extract_unsigned): Rename from
770 extract_signed and extract_unsigned, respectively. Adapt callers.
771
44286096
CY
7722012-06-09 Chong Yidong <cyd@gnu.org>
773
1682701f
CY
774 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
775
44286096
CY
776 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
777 case (Bug#9752).
778
d86feb17
PE
7792012-06-08 Paul Eggert <eggert@cs.ucla.edu>
780
781 * xdisp.c (vmessage): Treat frame message as multibyte.
782 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
783 would generate the diagnostic "Making \302\247 buffer-local while
784 let-bound!".
785
d5c20fe8
EZ
7862012-06-08 Eli Zaretskii <eliz@gnu.org>
787
788 * dispnew.c (showing_window_margins_p): Undo last change, which
789 was done due to an inadvertent commit.
790 (adjust_frame_glyphs_for_frame_redisplay): Do call
791 showing_window_margins_p.
792
513749ee
SM
7932012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
794
795 * eval.c (Fmake_var_non_special): New primitive.
796 (syms_of_eval): Defsubr it.
797 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
798
d4a8f5c1
JB
7992012-06-08 Juanma Barranquero <lekktu@gmail.com>
800
801 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
802 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
803
8bbbc977
EZ
8042012-06-08 Eli Zaretskii <eliz@gnu.org>
805
806 * alloc.c (allocate_vectorlike): Fix last change.
807
f3372c87
DA
8082012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
809
810 Block-based vector allocation of small vectors.
811 * lisp.h (struct vectorlike_header): New field `nbytes',
812 adjust comment accordingly.
813 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
814 to denote vector blocks. Adjust users (live_vector_p,
815 mark_maybe_pointer, valid_lisp_object_p) accordingly.
816 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
817 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
818 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
819 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
820 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
821 (roundup_size): New constant.
822 (struct vector_block): New data type.
823 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 824 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
825 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
826 (sweep_vectors): New functions.
827 (allocate_vectorlike): Return `zero_vector' as the only vector of
828 0 items. Allocate new vector from block if vector size is less than
829 or equal to VBLOCK_BYTES_MAX.
830 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
831 (init_alloc_once): Add call to init_vectors.
832
4f18a4ed
SM
8332012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
834
835 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
836
86f158bc
PE
8372012-06-07 Paul Eggert <eggert@cs.ucla.edu>
838
839 * doprnt.c (doprnt): Truncate multibyte char correctly.
840 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
841 would mishandle a string argument "Xc" if X was a multibyte
842 character of length 2: it would truncate after X's first byte
843 rather than including all of X.
844
c5cfcbe0
CY
8452012-06-06 Chong Yidong <cyd@gnu.org>
846
847 * buffer.c (word_wrap): Doc fix.
848
c05cf390
PE
8492012-06-04 Paul Eggert <eggert@cs.ucla.edu>
850
851 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
852
0c3461de
GM
8532012-06-03 Glenn Morris <rgm@gnu.org>
854
855 * xdisp.c (tool-bar-style): Doc fix.
856
c71232db
UM
8572012-06-03 Ulrich Müller <ulm@gentoo.org>
858
859 * Makefile.in (PAXCTL): Define.
860 (temacs$(EXEEXT)): Disable memory randomization for the temacs
861 binary via PaX flags if the paxctl utility is available.
862 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
863 Restore PaX flags to their default. (Bug#11398)
864
383f7350
CY
8652012-06-03 Chong Yidong <cyd@gnu.org>
866
867 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
868 buffer (Bug#11226).
869
5f2c76c6
CY
8702012-06-03 Chong Yidong <cyd@gnu.org>
871
872 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
873 (note_mode_line_or_margin_highlight): If there is no help echo,
874 use mode-line-default-help-echo. Handle the case where the mouse
875 position is past the end of the mode line string.
876
877 * buffer.c (buffer_local_value_1): New function, split from
878 Fbuffer_local_value; can return Qunbound.
879 (Fbuffer_local_value): Use it.
880 (Vmode_line_format): Docstring tweaks.
881
773d47f6
PE
8822012-06-02 Paul Eggert <eggert@cs.ucla.edu>
883
884 * sysdep.c (system_process_attributes): Improve comment.
885
f2d6a3df
SM
8862012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
887
888 * keyboard.c: Export real-this-command to Elisp.
889 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
890 and DEFVAR it. Update all users.
891
63810350
PE
8922012-06-02 Paul Eggert <eggert@cs.ucla.edu>
893
7bd5c1f4
PE
894 * minibuf.c (Fassoc_string): Remove duplicate declaration.
895
63810350
PE
896 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
897 Convert pctcpu and pctmem to Lisp float properly.
898 Let the compiler fold better, as 100.0/0x8000 is exact.
899
a2821611
AS
9002012-06-02 Andreas Schwab <schwab@linux-m68k.org>
901
902 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
903 cons_block.
904
5fceba1d
PE
9052012-06-01 Paul Eggert <eggert@cs.ucla.edu>
906
907 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
908
c98ff5dd
DA
9092012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
910
911 For a 'struct window', replace some Lisp_Object fields to
912 bitfields where appropriate, remove unused fields.
913 * window.h (struct window): Remove unused 'last_mark_x' and
914 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
915 change it's type from Lisp_Object to bitfield.
916 Change type of 'force_start', 'optional_new_start',
917 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
918 fields from Lisp_Object to bitfield. Adjust users accordingly.
919
ca34e0be
PE
9202012-05-31 Paul Eggert <eggert@cs.ucla.edu>
921
922 Pacify gcc -Wdouble-precision when using Xaw.
923 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
924 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
925 Use 'float' consistently, rather than 'float' in most places
926 and 'double' in a couple of places.
927
efc00ab1 9282012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
929
930 * xdisp.c (handle_stop): Detect whether we have overlay strings
931 loaded by testing it->current.overlay_string_index to be
932 non-negative, instead of checking whether n_overlay_strings is
933 positive. (Bug#11587)
934
efc00ab1 9352012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
936
937 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
938
939 * doc.c (Fsubstitute_command_keys): Doc fix.
940
efc00ab1 9412012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
942
943 * search.c (search_buffer): Remove calls to
944 r_alloc_inhibit_buffer_relocation, as it is now called by
945 maybe_unify_char, which was the cause of relocation of buffer text
946 in bug#11519.
947
efc00ab1 9482012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
949
950 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
951 for the duration of call to load_charset, to avoid problems with
952 callers of maybe_unify_char that access buffer text through C
953 pointers.
954
955 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
956 decrement the inhibition flag, instead of just setting or
957 resetting it.
958
ba93a187
PE
9592012-05-31 Paul Eggert <eggert@cs.ucla.edu>
960
961 Remove obsolete '#define static' cruft.
962 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
963 This #undef was "temporary" in 2000; it is no longer needed
964 now that '#define static' has gone away.
965 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
966 (gray_bitmap_bits): Remove; no longer needed.
967 All uses replaced with definiens.
968 * xterm.c: Include "bitmaps/gray.xbm".
969
9e4bf381
PE
9702012-05-30 Paul Eggert <eggert@cs.ucla.edu>
971
972 Clean up __executable_start, monstartup when --enable-profiling.
973 The following changes affect the code only when profiling.
974 * dispnew.c (__executable_start): Rename from safe_bcopy.
975 Define only on platforms that need it.
976 * emacs.c: Include <sys/gmon.h> when profiling.
977 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
978 (__executable_start): Remove decl, since lisp.h does it now.
979 (safe_bcopy): Remove decl; no longer has that name.
980 (main): Coalesce #if into single bit of code, for simplicity.
981 Cast pointers to uintptr_t, since standard libraries want integers
982 and not pointers.
983 * lisp.h (__executable_start): New decl.
984
32d72c2f
GM
9852012-05-31 Glenn Morris <rgm@gnu.org>
986
987 * image.c (Fimagemagick_types): Doc fix.
988
baac5bc7
JM
9892012-05-30 Jim Meyering <meyering@redhat.com>
990
991 * callproc.c (Fcall_process_region): Include directory component
992 in mkstemp error message (Bug#11586).
993
72cb32cf
PE
9942012-05-30 Paul Eggert <eggert@cs.ucla.edu>
995
996 * alloc.c, lisp.h (make_pure_vector): Now static.
997
61b108cc
SM
9982012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
999
1000 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1001 Move to byte-run.el.
1002 (Fautoload): Do the hash-doc more carefully.
1003 * data.c (Fdefalias): Purify definition, except for keymaps.
1004 (Qdefun): Move from eval.c.
1005 * lisp.h (Qdefun): Remove.
1006 * lread.c (read1): Tiny simplification.
1007
471fe23d
TN
10082012-05-29 Troels Nielsen <bn.troels@gmail.com>
1009
934f3f58 1010 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1011 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1012 Bug#9642, but explicitly check that the buffer the overlay would
1013 be moved to is live and rearrange lines to make sure that errors
1014 will not put the overlay in an inconsistent state.
1015 (Fdelete_overlay): Cosmetics.
1016
85d0efd1
EZ
10172012-05-28 Eli Zaretskii <eliz@gnu.org>
1018
1019 * w32term.c (my_bring_window_to_top): New function.
1020 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1021 could be different from the original one.
1022 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1023 (Bug#11513)
1024
1025 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1026 by calling BringWindowToTop.
1027
1028 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1029 (WM_EMACS_END): Increase by one.
1030
da92a98c
PE
10312012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1032
1033 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1034 This avoids undefined behavior that might cause the eassert
1035 to not catch an out-of-range value.
1036
74d1f848
JB
10372012-05-28 Juanma Barranquero <lekktu@gmail.com>
1038
1039 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1040 Update dependencies.
1041
9e1a06fc
EZ
10422012-05-27 Eli Zaretskii <eliz@gnu.org>
1043
1044 * bidi.c (bidi_mirror_char): Fix last change.
1045
f3dd7312
AS
10462012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1047
1048 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1049 when referring to sectname field in printf format.
1050
81899c91
PE
10512012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1052
57b81a9f
PE
1053 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1054 Only r_alloc_inhibit_buffer_relocation needed to be added;
1055 the others were already declared.
1056
81899c91
PE
1057 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1058 before checking whether it's out of range. Put the check inside
1059 eassert. See
1060 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1061
33017faf 10622012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1063
1064 * callproc.c (Fcall_process): Restore a line that was accidentally
1065 commented out in the 2011-02-13 change (bug#11547).
1066
33017faf 10672012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1068
1069 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1070 defined on ralloc.c.
1071
1072 * buffer.c [REL_ALLOC]: Remove prototypes of
1073 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1074 they are now on lisp.h.
1075
1076 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1077
1078 * search.c (search_buffer): Use it to inhibit relocation of buffer
1079 text while re_search_2 is doing its job, because re_search_2 is
1080 passed C pointers to buffer text. (Bug#11519)
1081
23415acf
EZ
1082 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1083 Update value to 24.
1084
44e27368
EZ
1085 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1086 state after an additional call to move_it_in_display_line_to, keep
1087 the values of it->max_ascent and it->max_descent found for the
1088 entire line.
1089 (pos_visible_p): Revert the comparison against bottom_y to what it
1090 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1091 (Bug#11464)
1092
c1892f11
PE
10932012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 Fix coding-related core dumps with gcc -ftrapv.
1096 The code was computing A - B, where A and B are pointers, and B is
1097 random garbage. This can lead to core dumps on platforms that
1098 have special pointer registers, and it also leads to core dumps on
1099 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1100 A - B only when B is initialized properly.
1101 * coding.c (coding_set_source, coding_set_destination): Return void.
1102 (coding_change_source, coding_change_destinations): New functions,
1103 with the old behaviors of coding_set_source and coding_set_destination.
1104 All callers that need an offset changed to use these new functions.
1105
eb7afdad
GM
11062012-05-26 Glenn Morris <rgm@gnu.org>
1107
1108 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1109
f12fdf02
EZ
11102012-05-26 Eli Zaretskii <eliz@gnu.org>
1111
53a63be6 1112 Extend mouse support on W32 text-mode console.
61b108cc
SM
1113 * xdisp.c (draw_row_with_mouse_face):
1114 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1115
eb3f6f01 1116 * w32console.c: Include window.h.
61b108cc
SM
1117 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1118 New functions.
eb3f6f01
EZ
1119 (initialize_w32_display): Initialize mouse-highlight data.
1120
53a63be6
EZ
1121 * w32inevt.c: Include termchar.h and window.h.
1122 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1123 moves, call note_mouse_highlight. If help_echo changed, call
1124 gen_help_event to produce help-echo message in the echo area.
1125 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1126 highlight info.
1127
4cfd81f6
PE
11282012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * lread.c (read1): Simplify slightly to avoid an overflow warning
1131 with GCC 4.7.0 on x86-64.
1132
4446092a
EZ
11332012-05-26 Eli Zaretskii <eliz@gnu.org>
1134
1135 * bidi.c (bidi_mirror_char): Revert last change: an int is
1136 definitely wide enough here.
1137
42b2a986 11382012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1139
42b2a986 1140 Fix integer width and related bugs (Bug#9874).
eb106a49 1141 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1142 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1143 (string_bytes, check_sblock, allocate_string_data):
1144 (compact_small_strings, Fmake_bool_vector, make_string)
1145 (make_unibyte_string, make_multibyte_string)
1146 (make_string_from_bytes, make_specified_string)
1147 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1148 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1149 (mark_vectorlike):
1150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1151 (allocate_pseudovector):
1152 Use int, not EMACS_INT, where int is wide enough.
1153 (inhibit_garbage_collection, Fgarbage_collect):
1154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1155 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1156 int might not be wide enough.
1157 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1158 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1159 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1160 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1161 (bidi_level_of_next_char, bidi_move_to_visually_next):
1162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1163 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1164 (Fkill_buffer, Fset_buffer_major_mode)
1165 (advance_to_char_boundary, Fbuffer_swap_text)
1166 (Fset_buffer_multibyte, overlays_at, overlays_in)
1167 (overlay_touches_p, struct sortvec, record_overlay_string)
1168 (overlay_strings, recenter_overlay_lists)
1169 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1170 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1171 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1172 (Foverlay_recenter, last_overlay_modification_hooks_used)
1173 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1175 (validate_region): Omit unnecessary test for b <= e,
1176 since that's guaranteed by the previous test.
d311d28c
PE
1177 (adjust_overlays_for_delete): Avoid pos + length overflow.
1178 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1179 (report_overlay_modification):
1180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1181 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1182 Omit pointer cast, which isn't needed anyway, and doesn't work
1183 after the EMACS_INT -> ptrdiff_t change.
02481186 1184 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1185 * buffer.h: Adjust decls to match defn changes elsewhere.
1186 (struct buffer_text, struct buffer):
1187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1188 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1189 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1190 not int, to avoid needless 32-bit limit on 64-bit hosts.
1191 (exec_byte_code): Use tighter memory-full test, one that checks
1192 for alloca overflow. Don't compute the address of the object just
1193 before an array, as that's not portable. Use EMACS_INT, not
1194 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1195 * callint.c (Fcall_interactively):
1196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1197 * callproc.c (call_process_kill, Fcall_process):
1198 Don't assume pid_t fits into an Emacs fixnum.
1199 (call_process_cleanup, Fcall_process, child_setup):
1200 Don't assume pid_t fits into int.
1201 (call_process_cleanup, Fcall_process, delete_temp_file)
1202 (Fcall_process_region):
1203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1204 (Fcall_process): Simplify handling of volatile integers.
1205 Use int, not EMACS_INT, where int will do.
1206 * casefiddle.c (casify_object, casify_region, operate_on_word)
1207 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1209 (casify_object): Avoid integer overflow when overallocating buffer.
1210 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1211 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1212 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1213 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1214 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1215 integers are now checked earlier. All uses replaced with XINT.
1216 (ccl_driver):
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1219 (ccl_driver, Fregister_code_conversion_map):
1220 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1221 (resolve_symbol_ccl_program): Check that vector header is in range.
1222 Always copy the vector, so that we can check its contents reliably
1223 now rather than having to recheck each instruction as it's being
1224 executed. Check that vector words fit in 'int'.
1225 (ccl_get_compiled_code, Fregister_ccl_program)
1226 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1227 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1228 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1229 contents are in range.
1230 (Fccl_execute_on_string): Check that status is in range.
1231 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1232 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1233 Accept and return EMACS_INT, not int, because callers can pass values
1234 out of 'int' range.
1235 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1236 (multibyte_chars_in_text, parse_str_as_multibyte)
1237 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1238 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1239 (string_escape_byte8, Fget_byte):
1240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1241 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1242 avoid mishandling large integers.
1243 * character.h: Adjust decls to match defn changes elsewhere.
1244 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1245 (Ffind_charset_region):
1246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1247 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1248 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1249 Don't assume fixnum fits in int.
d311d28c
PE
1250 (load_charset_map_from_vector, Fmap_charset_chars):
1251 Remove now-unnecessary CHECK_NATNUMs.
1252 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1253 Don't rely on undefined behavior with signed left shift overflow.
1254 Don't assume unsigned int fits into fixnum, or that fixnum fits
1255 into unsigned int. Don't require max_code to be a valid fixnum;
1256 that's not true for gb10830 4-byte on a 32-bit host. Allow
1257 invalid_code to be a cons, for the same reason. Require code_offset
1258 to be a character. Avoid int overflow if max_char is close
1259 to INT_MAX.
1260 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1261 this is intended anyway and avoids some undefined behavior.
1262 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1263 INDEX_TO_CODE_POINT, as that's what it expects.
1264 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1265 * charset.h (DECODE_CHAR): Return int, not unsigned;
1266 this is what was intended anyway, and it avoids undefined behavior.
1267 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1268 integer-overflow issues.
1269 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1270 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1271 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1272 * chartab.c (Fmake_char_table, Fset_char_table_range)
1273 (uniprop_get_decoder, uniprop_get_encoder):
1274 Don't assume fixnum fits in int.
1275 * cmds.c (move_point): New function, that does the gist of
1276 Fforward_char and Fbackward_char, but does so while checking
1277 for integer overflow more accurately.
c96e5d6a 1278 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1279 (Fforward_line, Fend_of_line, internal_self_insert)
1280 (internal_self_insert):
1281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1282 Fix a FIXME, by checking for integer overflow when calculating
1283 target_clm and actual_clm.
1284 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1285 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1286 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1287 (coding_alloc_by_making_gap, alloc_destination)
1288 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1289 (encode_coding_utf_16, detect_coding_emacs_mule)
1290 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1291 (detect_coding_iso_2022, decode_coding_iso_2022)
1292 (encode_invocation_designation, encode_designation_at_bol)
1293 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1294 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1295 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1296 (encode_coding_ccl, encode_coding_raw_text)
1297 (detect_coding_charset, decode_coding_charset)
1298 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1299 (produce_composition, produce_charset, produce_annotation)
1300 (decode_coding, handle_composition_annotation)
1301 (handle_charset_annotation, consume_chars, decode_coding_gap)
1302 (decode_coding_object, encode_coding_object, detect_coding_system)
1303 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1304 (code_convert_region, code_convert_string)
8f50130c
PE
1305 (Fdefine_coding_system_internal)
1306 (coding_set_source, coding_set_destination):
d311d28c
PE
1307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1308 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1309 (Fdefine_coding_system_internal):
1310 Don't assume fixnums fit in int.
1311 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1312 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1313 (Funencodable_char_position, Fcheck_coding_systems_region)
1314 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1316 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1317 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1318 Don't access memory outside of the args array.
d311d28c 1319 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1320 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1321 result of ENCODE_CHAR.
d311d28c
PE
1322 * coding.h: Adjust decls to match defn changes elsewhere.
1323 (struct coding_system):
1324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1325 * composite.c (get_composition_id, find_composition)
1326 (run_composition_function, update_compositions)
1327 (compose_text, composition_gstring_put_cache)
1328 (composition_gstring_p, composition_gstring_width)
1329 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1330 (composition_compute_stop_pos, composition_reseat_it)
1331 (composition_update_it, struct position_record)
1332 (find_automatic_composition, composition_adjust_point)
1333 (Fcomposition_get_gstring, Ffind_composition_internal):
1334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1335 (update_compositions):
1336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1337 * composite.h: Adjust decls to match defn changes elsewhere.
1338 (struct composition):
1339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1340 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1341 Do not attempt to compute the address of the object just before a
1342 buffer; this is not portable.
1343 (Faref, Faset):
1344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1345 (Faset): Use int, not EMACS_INT, where int is wide enough.
1346 (Fstring_to_number): Don't assume fixnums fit in int.
1347 (Frem): Don't assume arg is nonnegative.
1348 * dbusbind.c (xd_append_arg): Check for integers out of range.
1349 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1350 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1351 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1352 (xd_get_connection_references): Return ptrdiff_t, not int.
1353 All uses changed.
1354 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1355 (xd_read_message_1):
1356 Use int, not unsigned, where the dbus API uses int.
1357 (Fdbus_message_internal): Don't overflow mtype.
1358 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1359 * dired.c (directory_files_internal, file_name_completion, scmp)
1360 (file_name_completion_stat):
1361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1362 (file_name_completion): Don't overflow matchcount.
1363 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1364 * dispextern.h: Adjust decls to match defn changes elsewhere.
1365 (struct text_pos, struct glyph, struct bidi_saved_info)
1366 (struct bidi_string_data, struct bidi_it, struct composition_it)
1367 (struct it):
1368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1369 (struct display_pos, struct composition_it, struct it):
1370 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1371 * dispnew.c (increment_matrix_positions)
1372 (increment_row_positions, mode_line_string)
1373 (marginal_area_string):
1374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1375 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1377 (duration_to_sec_usec): New function, to check for overflow better.
1378 (Fsleep_for, sit_for): Use it.
1379 * doc.c (get_doc_string, store_function_docstring):
1380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1381 (get_doc_string, Fsnarf_documentation):
1382 Use int, not EMACS_INT, where int is wide enough.
1383 (get_doc_string):
1384 Use SAFE_ALLOCA, not alloca.
1385 Check for overflow when converting EMACS_INT to off_t.
1386 * doprnt.c (doprnt):
1387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1388 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1389 Don't assume uid_t fits into fixnum.
1390 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1391 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1392 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1393 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1394 (general_insert_function)
1395 (Finsert_char, make_buffer_string, make_buffer_string_both)
1396 (update_buffer_properties, Fbuffer_substring)
1397 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1398 (Fsubst_char_in_region, check_translation)
1399 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1400 (transpose_markers, Ftranspose_regions):
1401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1402 (clip_to_bounds): Move to lisp.h as an inline function).
1403 (Fconstrain_to_field): Don't assume integers are nonnegative.
1404 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1405 (Fsubst_char_in_region, Fsave_restriction):
1406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1407 (Femacs_pid): Don't assume pid_t fits into fixnum.
1408 (lo_time): Use int, not EMACS_INT, when int suffices.
1409 (lisp_time_argument): Check for usec out of range.
1410 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1411 (Fuser_login_name, Fuser_full_name): Signal an error
1412 if a uid argument is out of range, rather than relying on
1413 undefined behavior.
c8d5c857
PE
1414 (Fformat_time_string): Remove now-unnecessary check.
1415 lisp_time_argument checks for out-of-range usec now.
243e0530 1416 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1417 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1418 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1419 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1420 (init_cmdargs, Fdump_emacs):
1421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1422 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1423 the bottom (typically) 32 bits of the fixnum.
1424 * eval.c (specpdl_size, call_debugger):
1425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1426 (when_entered_debugger, Fbacktrace_debug):
1427 Don't assume fixnum can fit in int.
1428 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1429 the object just before a buffer; this is not portable.
1430 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1431 (grow_specpdl, unbind_to):
1432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1433 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1434 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1435 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1436 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1437 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1439 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1440 (a_write, e_write):
1441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1442 (Fcopy_file, non_regular_nbytes, read_non_regular)
1443 (Finsert_file_contents):
1444 Use int, not EMACS_INT, where int is wide enough.
1445 (READ_BUF_SIZE): Verify that it fits in int.
1446 (Finsert_file_contents): Check that counts are in proper range,
1447 rather than assuming fixnums fit into ptrdiff_t etc.
1448 Don't assume fixnums fit into int.
125b3835 1449 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1450 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1451 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1452 (string_char_to_byte, string_byte_to_char)
1453 (string_make_multibyte, string_to_multibyte)
1454 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1455 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1456 (substring_both, Fdelete, internal_equal, Ffillarray)
1457 (Fclear_string, mapcar1)
1458 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1459 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1460 (larger_vector, make_hash_table, maybe_resize_hash_table)
1461 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1462 (Fmaphash, secure_hash):
1463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1464 (concat): Check for string index and length overflow.
1465 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1466 (Frequire):
1467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1468 (larger_vector): New API (vec, incr_min, size_max) replaces old
1469 one (vec, new_size, init). This catches size overflow.
1470 INIT was removed because it was always Qnil.
1471 All callers changed.
1472 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1473 the upper bound on a hash table index size.
1474 (make_hash_table, maybe_resize_hash_table): Use it.
1475 (secure_hash): Computer start_byte and end_byte only after
1476 they're known to be in ptrdiff_t range.
1477 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1478 (Ffont_get_glyphs, Ffont_at):
1479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1480 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1481 (Flist_fonts, Fopen_font):
1482 Don't assume fixnum can fit in int.
1483 (check_gstring): Don't assume index can fit in int.
1484 (font_match_p): Check that fixnum is a character, not a nonnegative
1485 fixnum, since the later code needs to stuff it into an int.
1486 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1487 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1488 conversion overflow issues.
1489 (Fopen_font): Check for integer out of range.
1490 (Ffont_get_glyphs): Don't assume index can fit in int.
1491 * font.h: Adjust decls to match defn changes elsewhere.
1492 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1493 integer overflow.
1494 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1495 printmax_t, where ptrdiff_t is wide enough.
1496 (Finternal_char_font):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1499 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1500 (Fset_frame_position, x_set_frame_parameters)
1501 (x_set_line_spacing, x_set_border_width)
1502 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1503 Check that fixnums are in proper range for system types.
1504 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1506 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1507 Use SAFE_ALLOCA_LISP, not alloca.
1508 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1509 intptr_t is wide enough.
1510 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1511 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1512 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1513 Check for fixnum out of range.
1514 * ftfont.c (ftfont_list): Don't assume index fits in int.
1515 Check that fixnums are in proper range for system types.
1516 (ftfont_shape_by_flt):
1517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1518 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1520 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1521 Check that fixnums are in proper range for system types.
1522 * gnutls.h: Adjust decls to match defn changes elsewhere.
1523 * gtkutil.c (xg_dialog_run):
1524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1525 (update_frame_tool_bar):
1526 Check that fixnums are in proper range for system types.
1527 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1528 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1529 * indent.c (last_known_column, last_known_column_point):
1530 (current_column_bol_cache):
1531 (skip_invisible, current_column, check_display_width):
1532 (check_display_width, scan_for_column, current_column_1)
1533 (Findent_to, Fcurrent_indentation, position_indentation)
1534 (indented_beyond_p, Fmove_to_column, compute_motion):
1535 (Fcompute_motion, Fvertical_motion):
1536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1537 (last_known_column_modified): Use EMACS_INT, not int.
1538 (check_display_width):
1539 (Fcompute_motion):
1540 Check that fixnums and floats are in proper range for system types.
1541 (compute_motion): Don't assume index or fixnum fits in int.
1542 (compute_motion, Fcompute_motion):
1543 Use int, not EMACS_INT, when it is wide enough.
1544 (vmotion): Omit local var start_hpos that is always 0; that way
1545 we don't need to worry about overflow in expressions involving it.
1546 * indent.h: Adjust decls to match defn changes elsewhere.
1547 (struct position):
1548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1549 Use int, not EMACS_INT, where int is wide enough.
1550 Remove unused members ovstring_chars_done and tab_offset;
1551 all uses removed.
1552 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1553 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1554 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1555 (make_gap, copy_text, insert, insert_and_inherit)
1556 (insert_before_markers, insert_before_markers_and_inherit)
1557 (insert_1, count_combining_before, count_combining_after)
1558 (insert_1_both, insert_from_string)
1559 (insert_from_string_before_markers, insert_from_string_1)
1560 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1561 (adjust_after_replace, adjust_after_insert, replace_range)
1562 (replace_range_2, del_range, del_range_1, del_range_byte)
1563 (del_range_both, del_range_2, modify_region)
1564 (prepare_to_modify_buffer, signal_before_change)
1565 (signal_after_change, Fcombine_after_change_execute):
1566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1567 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1568 (balance_an_interval, split_interval_right, split_interval_left)
1569 (find_interval, next_interval, update_interval)
1570 (adjust_intervals_for_insertion, delete_node, delete_interval)
1571 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1572 (static_offset_intervals, offset_intervals)
1573 (merge_interval_right, merge_interval_left, make_new_interval)
1574 (graft_intervals_into_buffer, temp_set_point_both)
1575 (temp_set_point, set_point, adjust_for_invis_intang)
1576 (set_point_both, move_if_not_intangible, get_property_and_range)
1577 (get_local_map, copy_intervals, copy_intervals_to_string)
1578 (compare_string_intervals, set_intervals_multibyte_1):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1580 * intervals.h: Adjust decls to match defn changes elsewhere.
1581 (struct interval):
1582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1583 * keyboard.c (this_command_key_count, this_single_command_key_start)
1584 (before_command_key_count, before_command_echo_length, echo_now)
1585 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1586 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1587 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1588 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1590 (last_non_minibuf_size, last_point_position, echo_truncate)
1591 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1592 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1593 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1594 (stuff_buffered_input):
1595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1596 (last_auto_save, command_loop_1, read_char):
1597 Use EMACS_INT, not int, to avoid integer overflow.
1598 (record_char): Avoid overflow in total_keys computation.
1599 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1600 * keyboard.h: Adjust decls to match defn changes elsewhere.
1601 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1602 (Fkey_description, Fdescribe_vector, Flookup_key):
1603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1604 (click_position): New function, to check that positions are in range.
1605 (Fcurrent_active_maps):
1606 (describe_command):
1607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1608 (Faccessible_keymaps, Fkey_description):
1609 (preferred_sequence_p):
1610 Don't assume fixnum can fit into int.
1611 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1612 Check for integer overflow in size calculations.
1613 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1614 avoid mishandling large integers.
1615 * lisp.h: Adjust decls to match defn changes elsewhere.
1616 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1617 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1618 (struct Lisp_Marker):
1619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1620 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1621 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1622 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1623 All callers changed.
1624 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1625 Assume the arg has valid form, since it always does.
1626 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1627 unsigned integer system type.
1628 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1629 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1631 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1632 (duration_to_sec_usec): New decl.
1633 * lread.c (read_from_string_index, read_from_string_index_byte)
1634 (read_from_string_limit, readchar, unreadchar, openp)
1635 (read_internal_start, read1, oblookup):
1636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1637 (Fload, readevalloop, Feval_buffer, Feval_region):
1638 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1639 (openp): Check for out-of-range argument to 'access'.
1640 (read1): Use int, not EMACS_INT, where int is wide enough.
1641 Don't assume fixnum fits into int.
6efdadfd 1642 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1643 (read_filtered_event): Use duration_to_sec_usec
1644 to do proper overflow checking on durations.
d311d28c
PE
1645 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1646 in size calculation.
1647 (Fexecute_kbd_macro):
1648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1649 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1650 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1651 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1652 (set_marker_both, set_marker_restricted_both, marker_position)
1653 (marker_byte_position, Fbuffer_has_markers_at):
1654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1655 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1656 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1657 It now merely ensures that the menu is large enough, without
1658 necessarily growing it, as this avoids some integer overflow issues.
1659 All callers changed.
1660 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1662 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1663 Use SAFE_ALLOCA_LISP, not alloca.
1664 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1665 to EMACS_INT. Check that fixnums are in proper range for system types.
1666 * minibuf.c (minibuf_prompt_width, string_to_object)
1667 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1668 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1670 (get_minibuffer, read_minibuf_unwind):
1671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1672 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1673 this simplifies overflow checking. All callers changed.
1674 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1675 (Ftest_completion):
1676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1677 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1678 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1679 Check that fixnums are in proper range for system types.
1680 (Fx_create_frame, Fx_show_tip):
1681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1682 * nsfont.m (ns_findfonts, nsfont_list_family):
1683 Don't assume fixnum fits in long.
1684 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1686 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1687 wide enough.
17fdb222 1688 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1690 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1691 (PRINTDECLARE, PRINTPREPARE):
1692 (strout, print_string):
1693 (print, print_preprocess, print_check_string_charset_prop)
1694 (print_object):
1695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1696 (PRINTDECLARE):
1697 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1699 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1700 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1701 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1702 (print_error_message): Use SAFE_ALLOCA, not alloca.
1703 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1704 (print_depth, new_backquote_output, print_number_index):
1705 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1706 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1707 (Fset_process_window_size, Fformat_network_address)
1708 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1709 (sigchld_handler):
d311d28c 1710 Check that fixnums are in proper range for system types.
d44287d4 1711 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1712 Check for process-ids out of pid_t range rather than relying on
1713 undefined behavior.
e4d81efc 1714 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1715 (Fformat_network_address, read_process_output, send_process)
1716 (Fprocess_send_region, status_notify):
1717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1718 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1719 (wait_reading_process_output, read_process_output, exec_sentinel):
1720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1721 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1722 (Faccept_process_output): Use duration_to_sec_usec to do proper
1723 overflow checking on durations.
dde14581
PE
1724 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1725 Don't assume pid_t fits in int.
02481186
PE
1726 * process.h (struct Lisp_Process): Members tick and update_tick
1727 are now of type EMACS_INT, not int.
b62b53e8
PE
1728 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1729 configured --with-wide-int.
d311d28c
PE
1730 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1731 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1732 * search.c (looking_at_1, string_match_1):
1733 (fast_string_match, fast_c_string_match_ignore_case)
1734 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1735 (scan_newline, find_before_next_newline, search_command)
1736 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1737 (set_search_regs, wordify):
1738 (Freplace_match):
1739 (Fmatch_data):
1740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1741 (string_match_1, search_buffer, set_search_regs):
1742 (Fmatch_data):
1743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1744 (wordify): Check for overflow in size calculation.
1745 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1746 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1747 Check that fixnums are in proper range for system types.
1748 * sound.c (struct sound_device)
1749 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1751 (Fplay_sound_internal):
1752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1753 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1754 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1755 (Fparse_partial_sexp):
1756 Don't assume fixnums can fit in int.
1757 (struct lisp_parse_state, find_start_pos, find_start_value)
1758 (find_start_value_byte, find_start_begv)
1759 (update_syntax_table, char_quoted, dec_bytepos)
1760 (find_defun_start, prev_char_comend_first, back_comment):
1761 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1762 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1764 (Finternal_describe_syntax_value): Check that match_lisp is a
1765 character, not an integer, since the code stuffs it into int.
1766 (scan_words, scan_sexps_forward):
1767 Check that fixnums are in proper range for system types.
1768 (Fforward_word):
1769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1770 (scan_sexps_forward):
1771 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1772 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1773 * syntax.h: Adjust decls to match defn changes elsewhere.
1774 (struct gl_state_s):
1775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1776 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1777 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1778 * sysdep.c (wait_for_termination_1, wait_for_termination)
1779 (interruptible_wait_for_termination, mkdir):
1780 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1781 (emacs_read, emacs_write):
1782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1783 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1784 and double all fit in int.
d311d28c
PE
1785 * term.c (set_tty_color_mode):
1786 Check that fixnums are in proper range for system types.
1787 * termhooks.h (struct input_event):
1788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1789 * textprop.c (validate_interval_range, interval_of)
1790 (Fadd_text_properties, set_text_properties_1)
1791 (Fremove_text_properties, Fremove_list_of_text_properties)
1792 (Ftext_property_any, Ftext_property_not_all)
1793 (copy_text_properties, text_property_list, extend_property_ranges)
1794 (verify_interval_modification):
1795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1796 (Fnext_single_char_property_change)
1797 (Fprevious_single_char_property_change):
1798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1799 (copy_text_properties):
1800 Check for integer overflow in index calculation.
d311d28c
PE
1801 * undo.c (last_boundary_position, record_point, record_insert)
1802 (record_delete, record_marker_adjustment, record_change)
1803 (record_property_change):
1804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1805 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1807 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1808 (Fx_hide_tip, Fx_file_dialog):
1809 * w32menu.c (set_frame_menubar):
1810 Use ptrdiff_t, not int, for consistency with rest of code.
1811 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1812 (select_window, Fdelete_other_windows_internal)
1813 (window_scroll_pixel_based, window_scroll_line_based)
1814 (Frecenter, Fset_window_configuration):
1815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1816 (Fset_window_hscroll, run_window_configuration_change_hook)
1817 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1818 (Fscroll_other_window, Frecenter):
d311d28c
PE
1819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1820 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1821 Don't assume fixnum fits in int.
1822 (Fset_window_scroll_bars):
1823 Check that fixnums are in proper range for system types.
1824 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1825 (string_pos, c_string_pos, number_of_chars, init_iterator)
1826 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1827 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1828 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1829 (face_before_or_after_it_pos, handle_invisible_prop)
1830 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1831 (display_prop_intangible_p, string_buffer_position_lim)
1832 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1833 (get_overlay_strings_1, get_overlay_strings)
1834 (iterate_out_of_display_property, forward_to_next_line_start)
1835 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1836 (get_next_display_element, set_iterator_to_next)
1837 (get_visually_first_element, compute_stop_pos_backwards)
1838 (handle_stop_backwards, next_element_from_buffer)
1839 (move_it_in_display_line_to, move_it_in_display_line)
1840 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1841 (add_to_log, message_dolog, message_log_check_duplicate)
1842 (message2, message2_nolog, message3, message3_nolog
1843 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1844 (current_message_1, truncate_echo_area, truncate_message_1)
1845 (set_message, set_message_1, store_mode_line_noprop)
1846 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1847 (text_outside_line_unchanged_p, check_point_in_composition)
1848 (reconsider_clip_changes)
1849 (redisplay_internal, set_cursor_from_row, try_scrolling)
1850 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1851 (redisplay_window, find_last_unchanged_at_beg_row)
1852 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1853 (trailing_whitespace_p, find_row_edges, display_line)
1854 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1855 (display_mode_element, store_mode_line_string)
1856 (pint2str, pint2hrstr, decode_mode_spec)
1857 (display_count_lines, display_string, draw_glyphs)
1858 (x_produce_glyphs, x_insert_glyphs)
1859 (rows_from_pos_range, mouse_face_from_buffer_pos)
1860 (fast_find_string_pos, mouse_face_from_string_pos)
1861 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1863 (safe_call, init_from_display_pos, handle_fontified_prop)
1864 (handle_single_display_spec, load_overlay_strings)
1865 (with_echo_area_buffer, setup_echo_area_for_printing)
1866 (display_echo_area, echo_area_display)
1867 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1868 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1869 (redisplay_window, dump_glyph_row, display_mode_line)
1870 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1871 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1872 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1873 (handle_single_display_spec, build_desired_tool_bar_string)
1874 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1875 (get_specified_cursor_type):
1876 Check that fixnums are in proper range for system types.
1877 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1878 (Flookup_image_map):
1879 Don't assume fixnums fit in int.
1880 (compare_overlay_entries):
1881 Avoid mishandling comparisons due to subtraction overflow.
1882 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1883 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1884 (handle_tool_bar_click):
1885 Use int, not unsigned, since we prefer signed and the signedness
1886 doesn't matter here.
1887 (get_next_display_element, next_element_from_display_vector):
1888 Use int, not EMACS_INT, when int is wide enough.
1889 (start_hourglass): Use duration_to_sec_usec to do proper
1890 overflow checking on durations.
1891 * xfaces.c (Fbitmap_spec_p):
1892 Check that fixnums are in proper range for system types.
1893 (compare_fonts_by_sort_order):
1894 Avoid mishandling comparisons due to subtraction overflow.
1895 (Fx_family_fonts, realize_basic_faces):
1896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1897 (Fx_family_fonts):
1898 Don't assume fixnum fits in int.
1899 Use SAFE_ALLOCA_LISP, not alloca.
1900 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1901 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1902 (face_at_buffer_position, face_for_overlay_string)
1903 (face_at_string_position):
1904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1905 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1906 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1907 (Fx_show_tip):
1908 Check that fixnums are in proper range for system types.
1909 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1910 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1912 (Fx_change_window_property): Don't assume fixnums fit in int.
1913 * xfont.c (xfont_chars_supported):
1914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1915 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1916 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1918 * xml.c (parse_region):
1919 * xrdb.c (magic_file_p):
1920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1921 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1922 (x_get_local_selection, x_reply_selection_request)
1923 (x_handle_selection_request, wait_for_property_change):
1924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1925 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1926 short is wide enough.
1927 (x_send_client_event): Don't assume fixnum fits in int.
1928 * xterm.c (x_x_to_emacs_modifiers):
1929 Don't assume EMACS_INT overflows nicely into int.
1930 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1931 may come from Lisp.
1932 (handle_one_xevent): NATNUMP can eval its arg twice.
1933 (x_connection_closed):
1934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1935 * xterm.h: Adjust decls to match defn changes elsewhere.
1936 (struct scroll_bar): Use struct vectorlike_header
1937 rather than rolling our own approximation.
1938 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1939
c6574eb5
GM
19402012-05-25 Glenn Morris <rgm@gnu.org>
1941
1942 * lisp.mk (lisp): Update for more files being compiled now.
1943
e8d32c7e
SM
19442012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1945
48def666
SM
1946 * lread.c: Remove `read_pure' which makes no difference.
1947 (read_pure): Remove var.
1948 (unreadpure): Remove function.
1949 (readevalloop): Don't call read_list with -1 flag.
1950 (read1, read_vector): Don't test read_pure any more.
1951 (read_list): Simplify.
1952
e8d32c7e
SM
1953 * fileio.c, character.h: Minor style tweaks.
1954
4b2addb7
DA
19552012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1956
1957 * window.h (clip_changed): Remove useless declaration.
1958
584461b2
JB
19592012-05-22 Juanma Barranquero <lekktu@gmail.com>
1960
1961 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1962 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1963
34374650
PE
19642012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1965
1966 Remove src/m/*.
1967 This directory predates autoconf and is no longer needed nowadays.
1968 Move its few remaining bits of functionality to where they're needed.
1969 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1970 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1971 * m/template.h: Remove.
1972 * Makefile.in (M_FILE): Remove. All uses removed.
1973 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1974 * lisp.h (USE_LSB_TAG):
1975 * mem-limits.h (EXCEEDS_LISP_PTR):
1976 Use VAL_MAX, not VALBITS, in #if.
1977 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1978 (EMACS_UINT): Define unconditionally now.
1979 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1980 (BITS_PER_EMACS_INT): New constants, replacing
1981 what used to be in config.h, but not useful in #if.
1982 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1983 define them any more.
1984 (VAL_MAX): New macro.
1985 (VALMASK): Use it.
1986 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1987 BITS_PER_EMACS_INT, in #if.
1988 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1989 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1990 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1991 * s/ms-w32.h (DATA_START):
1992 Move here from removed file m/intel386.h.
1993 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1994 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1995
261cb4bb
PE
19962012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 Assume C89 or later.
1999 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2000 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2001 (xrealloc):
2002 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2003 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2004 * textprop.c, tparam.c (NULL): Remove.
2005 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2006 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2007 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2008 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2009 * xterm.c (input_signal_count): Assume volatile works.
2010
ff23cd9f
KB
20112012-05-21 Ken Brown <kbrown@cornell.edu>
2012
2013 * xgselect.c (xg_select): Fix first argument in call to 'select'
2014 (bug#11508).
2015
1b170bc6
KB
20162012-05-20 Ken Brown <kbrown@cornell.edu>
2017
2018 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2019 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2020
b2f4d39f
KB
20212012-05-19 Ken Brown <kbrown@cornell.edu>
2022
2023 * xfns.c (x_in_use): Remove `static' qualifier.
2024 * xterm.h (x_in_use): Declare.
2025 * xgselect.c: Include xterm.h.
2026 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2027 and `display_arg' (bug#9754).
2028
003fdae2
PE
20292012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2030
9232a6d9
PE
2031 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2032
003fdae2
PE
2033 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2034 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2035
784b56e2
EZ
20362012-05-18 Eli Zaretskii <eliz@gnu.org>
2037
2038 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2039
2040 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2041 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2042
2043 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2044 reference to image_cache->refcount.
2045 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2046
a0a79cde
JL
20472012-05-17 Juri Linkov <juri@jurta.org>
2048
2049 * search.c (Fword_search_regexp, Fword_search_backward)
2050 (Fword_search_forward, Fword_search_backward_lax)
2051 (Fword_search_forward_lax): Move functions to isearch.el
2052 (bug#10145, bug#11381).
2053
b0572523
PE
20542012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2057
9660f5fc
SM
20582012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2059
2060 * lread.c (init_obarray): Declare Qt and Qnil as special.
2061
4374de83
GM
20622012-05-14 Glenn Morris <rgm@gnu.org>
2063
2064 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2065 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2066
dc44c39a
PE
20672012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2068
078c97cb
PE
2069 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2070
dc44c39a
PE
2071 * unexaix.c: Port to more-recent AIX compilers.
2072 (report_error, report_error_1, make_hdr, copy_sym)
2073 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2074 Make arguments const char *, not char *, to avoid violations of C
2075 standard and to fix some AIX warnings reported by Gilles Pion.
2076
e18afed7 20772012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2078
2079 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2080 already have overlays loaded.
2081 (handle_single_display_spec): Before returning without displaying
2082 fringe bitmap, synchronize the bidi iterator with the main display
2083 iterator, by calling iterate_out_of_display_property.
2084 (iterate_out_of_display_property): Detect buffer iteration by
2085 testing that it->string is a Lisp string.
2086 (get_next_display_element): When the current object is exhausted,
2087 and there's something on it->stack, call set_iterator_to_next to
2088 proceed with what's on the stack, instead of returning zero.
2089 (set_iterator_to_next): If called at the end of a Lisp string,
2090 proceed to consider_string_end without incrementing string
2091 position. Don't increment display vector index past the end of
2092 the display vector. (Bug#11417)
c8fb9dc6
EZ
2093 (pos_visible_p): Don't report a position visible when move_it_to
2094 stopped at the last line of window, which happens to be scanned
2095 backwards by the bidi iteration. (Bug#11464)
ac268e67 2096
e18afed7 20972012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2098
2099 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2100 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2101 are on a TTY, and thus unable to display on the fringes.
2102 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2103 so we need to signal to the caller that this is a "replacing"
2104 display spec. This fixes display when the spec is invalid or we
2105 are on a TTY.
2106
e18afed7 21072012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2108
2109 * unexaix.c (make_hdr): Fix typo in prototype.
2110 This bug broke the build on AIX. Problem reported by Gilles Pion.
2111
9d0a235a
MA
21122012-05-14 Michael Albinus <michael.albinus@gmx.de>
2113
2114 * keyboard.c (kbd_buffer_get_event): Read special events also in
2115 batch mode. (Bug#11415)
2116
9e6b06ed
GM
21172012-05-12 Glenn Morris <rgm@gnu.org>
2118
2119 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2120
c1a1d7a3
EZ
21212012-05-12 Eli Zaretskii <eliz@gnu.org>
2122
2123 * lisp.mk (lisp): Add newcomment.elc.
2124
3fe7cdc8
GM
21252012-05-12 Glenn Morris <rgm@gnu.org>
2126
2127 * Makefile.in (MKDIR_P): New, set by configure.
2128 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2129
53f7d2c0
PE
21302012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2131
2132 Remove unused function hourglass_started.
2133 * dispextern.h (hourglass_started):
2134 * w32fns.c (hourglass_started):
2135 * xdisp.c (hourglass_started): Remove.
2136
75aafb17
JB
21372012-05-10 Juanma Barranquero <lekktu@gmail.com>
2138
2139 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2140 Update dependencies.
2141
12959e8e
PE
21422012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2143
97107e2e
PE
2144 * xgselect.c (xg_select): Put maxfds+1 into a var.
2145 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2146
12959e8e
PE
2147 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2148
836d29b3
DA
21492012-05-10 Dave Abrahams <dave@boostpro.com>
2150
2151 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2152 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2153
5cb67954
MA
21542012-05-09 Michael Albinus <michael.albinus@gmx.de>
2155
2156 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2157 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2158 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2159 Initialize xd_registered_buses.
2160
3478ec45
PE
21612012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2162
b263a6b0
PE
2163 Untag more efficiently if USE_LSB_TAG.
2164 This is based on a proposal by YAMAMOTO Mitsuharu in
2165 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2166 For an admittedly artificial (nth 8000 longlist) benchmark on
2167 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2168 Emacs's overall text size by 1%.
2169 * lisp.h (XUNTAG): New macro.
2170 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2171 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2172 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2173 * eval.c (Fautoload):
2174 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2175 * frame.h (XFRAME): Use XUNTAG.
2176
3478ec45
PE
2177 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2178 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2179 Remove unportable assumptions about print widths of types like
2180 dbus_uint32_t.
2181 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2182 intptr_t when converting between pointer and integer, to avoid GCC
2183 warnings about wrong width.
2184
666b903b 21852012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2186
2187 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2188 stack for each reader_thread, instead of defaulting to 8MB
2189 determined by the linker. This avoids failures in creating
2190 subprocesses on Windows 7, see the discussion in this thread:
2191 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2192
b120cc17
JC
21932012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2194
2195 Fix up display of the *Minibuf-0* buffer in the mini window.
2196 * keyboard.c (read_char): Don't clear the echo area if there's no
2197 message to clear.
2198 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2199 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2200
9a4b36f8
MA
22012012-05-07 Michael Albinus <michael.albinus@gmx.de>
2202
2203 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2204 batch mode.
2205
e5f9458f
CY
22062012-05-06 Chong Yidong <cyd@gnu.org>
2207
2208 * lisp.mk (lisp): Update.
2209
eceeb5fc 22102012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2211
2212 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2213
71873e2b
SM
22142012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2215
2216 * data.c (PUT_ERROR): New macro.
2217 (syms_of_data): Use it. Add new error type `user-error'.
2218 * undo.c (user_error): New function.
2219 (Fprimitive_undo): Use it.
2220 * print.c (print_error_message): Adjust print style for `user-error'.
2221 * keyboard.c (user_error): New function.
2222 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2223
ab0fa4e4
PE
22242012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 Do not limit current-time-string to years 1000..9999.
2227 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2228 (Fcurrent_time_string): Support any year that is supported by the
2229 underlying localtime representation. Don't use asctime, as it
2230 has undefined behavior for years outside the range -999..9999.
2231
7ed806a7
PE
22322012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2233
2234 Fix race conditions involving setenv, gmtime, localtime, asctime.
2235 Without this fix, interrupts could mess up code that uses these
2236 nonreentrant functions, since setting TZ invalidates existing
2237 tm_zone or tzname values, and since most of these functions return
2238 pointers to static storage.
2239 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2240 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2241 Grow the critical sections to include not just invoking
2242 localtime/gmtime, but also accessing these functions' results
2243 including their tm_zone values if any, and any related TZ setting.
2244 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2245 so that the struct tm is saved in the critical section.
2246 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2247 motivated by the fact that memory allocation needs to be outside
2248 the critical section.
2249
0c16dfed
DA
22502012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2251
2252 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2253 with RESET_INTERVAL.
2254
2255 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2256 Remove duplicated buffer name initialization.
2257
3f83ace8
JM
22582012-05-02 Jim Meyering <jim@meyering.net>
2259
2260 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2261
c7b8541e
JM
2262 * xfns.c (x_window): Use xstrdup (Bug#11375).
2263
90207a15 22642012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2265
2266 * xdisp.c (pos_visible_p): If already at a newline from the
2267 display string before the 'while' loop, don't walk back the glyphs
2268 from it3.glyph_row. Solves assertion violation when the display
2269 string begins with a newline (egg.el). (Bug#11367)
2270
b593d6a9
AH
22712012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2272
2273 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2274 Move to simple.el.
2275
4737362e
GM
22762012-05-01 Glenn Morris <rgm@gnu.org>
2277
99cf43f9
GM
2278 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2279 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2280 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2281 All were removed before 23.1.
2282
9311dcff
GM
2283 * dispnew.c: Remove HAVE_LIBNCURSES test;
2284 it is always true on relevant platforms.
2285
4d5c6349
GM
2286 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2287 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2288
4737362e
GM
2289 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2290
74dd3a6b
AS
22912012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2292
2293 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2294 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2295 Remove.
2296
13c379ee
PE
22972012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 Do not avoid creating empty evaporating overlays (Bug#9642).
2300 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2301 That is, do not delete an evaporating overlay if it becomes
2302 empty after its bounds are adjusted to fit within its buffer.
2303 This fix caused other problems, and I'm reverting it until we get
2304 to the bottom of them.
2305
a8e7d6d7 23062012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2307
2308 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2309
a8e7d6d7 23102012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2311
2312 * xdisp.c (pos_visible_p): If the window start position is beyond
2313 ZV, start the display from buffer beginning. Prevents assertion
2314 violation in init_iterator when the minibuffer window is scrolled
2315 via the scroll bar.
2316
2317 * window.c (window_scroll_pixel_based): Likewise.
2318
a8e7d6d7 23192012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2320
2321 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2322
a8e7d6d7 23232012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2324
2325 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2326 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2327
a8e7d6d7 23282012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2329
b593d6a9
AH
2330 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2331 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2332
1c6900d9
EZ
23332012-04-26 Eli Zaretskii <eliz@gnu.org>
2334
4c3fa1d9
EZ
2335 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2336 display element, check also the underlying string or buffer
2337 character. (Bug#11341)
2338
1c6900d9
EZ
2339 * w32menu.c: Include w32heap.h.
2340 (add_menu_item): If the call to AppendMenuW (via
2341 unicode_append_menu) fails, disable Unicode menus only if we are
2342 running on Windows 9X/Me.
2343
42bf8205
AS
23442012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2345
2346 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2347 (xgetint): Add missing shift for LSB tags.
2348
b1bac16e
MR
23492012-04-24 Martin Rudalics <rudalics@gmx.at>
2350
2351 * keyboard.c (read_char): Don't wipe echo area for select window
2352 events: These might get delayed via `mouse-autoselect-window'
2353 (Bug#11304).
2354
d69621cc
JB
23552012-04-24 Juanma Barranquero <lekktu@gmail.com>
2356
2357 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2358 manipulation of :loaded-from data.
2359
02fd101b
JB
23602012-04-23 Juanma Barranquero <lekktu@gmail.com>
2361
2362 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2363 now a cons (bug#11311).
2364
888bec30
PE
23652012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2366
89a438bd
PE
2367 Do not create empty overlays with the evaporate property (Bug#9642).
2368 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2369 if it becomes empty after its bounds are adjusted to fit within
2370 its buffer. Without this fix, in a nonempty buffer (let ((o
2371 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2372 yields an empty overlay that has the evaporate property, which is
2373 not supposed to happen.
2374
1068fe4d
PE
2375 Fix minor GTK3 problems found by static checking.
2376 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2377 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2378 (struct _EmacsFixedClass, emacs_fixed_get_type):
2379 Move decls here from emacsgtkfixed.h, since they needn't be public.
2380 (emacs_fixed_get_type): Now static.
2381 (emacs_fixed_class_init): Omit unused local.
2382 (emacs_fixed_child_type): Remove; unused.
2383 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2384 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2385 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2386 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2387 (EMACS_FIXED_GET_CLASS): Remove; unused.
2388 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2389
888bec30
PE
2390 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2391 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2392
de85e130
PE
23932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2394
d0baac98 2395 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2396 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2397 (__malloc_size_t, __malloc_ptrdiff_t):
2398 Remove. All uses removed, replaced by the definiens if needed,
2399 since we can assume C89 or better now.
2400 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2401 (protect_malloc_state, align, get_contiguous_space)
2402 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2403 (malloc_atfork_handler_child, malloc_enable_thread)
2404 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2405 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2406 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2407 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2408 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2409 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2410 Define using prototypes, not old style.
2411 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2412 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2413 (align): Don't assume that signed integer overflow wraps around.
2414 Omit unused local var.
2415 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2416 (_free_internal_nolock, memalign, mallochook, reallochook):
2417 Omit no-longer-needed casts.
2418 (valloc): Use getpagesize, not __getpagesize.
2419 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2420 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2421
de85e130
PE
2422 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2423
dcbf5805
MA
24242012-04-22 Michael Albinus <michael.albinus@gmx.de>
2425
2426 Move functions from C to Lisp. Make non-blocking method calls
2427 the default. Implement further D-Bus standard interfaces.
2428
2429 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2430 (QCdbus_request_name_allow_replacement)
2431 (QCdbus_request_name_replace_existing)
2432 (QCdbus_request_name_do_not_queue)
2433 (QCdbus_request_name_reply_primary_owner)
2434 (QCdbus_request_name_reply_in_queue)
2435 (QCdbus_request_name_reply_exists)
2436 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2437 (QCdbus_registered_serial, QCdbus_registered_method)
2438 (QCdbus_registered_signal): New Lisp objects.
2439 (XD_DEBUG_MESSAGE): Use sizeof.
2440 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2441 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2442 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2443 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2444 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2445 (xd_signature, xd_append_arg): Allow float for integer types.
2446 (xd_get_connection_references): New function.
b593d6a9
AH
2447 (xd_get_connection_address): Rename from xd_initialize.
2448 Return cached address.
dcbf5805
MA
2449 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2450 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2451 level.
2452 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2453 Return number of refcounts.
dcbf5805
MA
2454 (Fdbus_get_unique_name): Make stronger parameter check.
2455 (Fdbus_message_internal): New defun.
2456 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2457 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2458 (Fdbus_send_signal, Fdbus_register_service)
2459 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2460 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2461 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2462 (Vdbus_compiled_version, Vdbus_runtime_version)
2463 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2464 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2465 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2466 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2467 Adapt docstring.
dcbf5805 2468
52828e02
PE
24692012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2470
da05bc4c
PE
2471 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2472 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2473 Do not assume ptrdiff_t is the same width as 'int'.
2474
52828e02
PE
2475 * alloc.c: Handle unusual debugging option combinations.
2476 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2477 since the two debugging options are incompatible.
2478 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2479 is defined.
2480 (mem_init, mem_insert, mem_insert_fixup):
2481 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2482 (NEED_MEM_INSERT): Remove; no longer needed.
2483
f01769f9
LL
24842012-04-22 Leo Liu <sdl.web@gmail.com>
2485
2486 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2487
5790543d
PE
24882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 * sysdep.c [__FreeBSD__]: Minor cleanups.
2491 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2492 Use Emacs indenting style more consistently. Avoid some casts.
2493 Use 'double' consistently rather than mixing 'float' and 'double'.
2494
b91b7e4d
EW
24952012-04-21 Eduard Wiebe <usenet@pusto.de>
2496
b593d6a9
AH
2497 * sysdep.c (list_system_processes, system_process_attributes):
2498 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2499
6114eb15
AS
25002012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2501
2502 * lisp.mk (lisp): Update.
2503
2f38dff7
PE
25042012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2505
2506 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2507 It is never used otherwise.
2508
4ae29f89
SM
25092012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2510
2511 * print.c (print_preprocess): Only check print_depth if print-circle
2512 is nil.
2513 (print_object): Check for cycles even when print-circle is nil and
2514 print-gensym is t, but only check print_depth if print-circle is nil.
2515
f30d612a
CY
25162012-04-20 Chong Yidong <cyd@gnu.org>
2517
2518 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2519 set the status to "failed" and ensure that sentinel is run.
2520
c07a4c0b 25212012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2522
2523 * process.c (Fset_process_inherit_coding_system_flag)
2524 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2525 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2526
c07a4c0b 25272012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2528
2529 * xdisp.c (string_buffer_position_lim): Limit starting position to
2530 BEGV.
2531 (set_cursor_from_row): If called for a mode-line or header-line
2532 row, return zero immediately.
2533 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2534 farther than the first row after the header line, if any.
2535 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2536 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2537
c07a4c0b 25382012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2539
4ae29f89
SM
2540 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2541 (bug#11238).
ad3a2b41 2542
c07a4c0b 25432012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 25442012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2545
2546 configure: new option --enable-gcc-warnings (Bug#11207)
2547 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2548 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2549 (ALL_CFLAGS): Use new macros rather than old.
2550 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2551 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2552 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2553 -Wunused-result, -Wunused-variable. This should go away once
2554 the Emacs and Gnulib regex code is merged.
2555 (xmalloc, xrealloc): Now static.
2556
aba027e8
PE
25572012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 * dired.c (Fsystem_groups): Remove unused local.
2560
e5a36063
GM
25612012-04-17 Glenn Morris <rgm@gnu.org>
2562
2563 * dired.c (Fsystem_users): Doc fix.
2564
316411f0
DA
25652012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2566
2567 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2568 (syms_of_dired): Add them.
2569
9426aba4
PE
25702012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2571
b62a57be
PE
2572 Fix minor alloc.c problems found by static checking.
2573 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2574 New extern decls, to avoid calling undeclared functions.
2575 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2576 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2577 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2578 (NEED_MEM_INSERT): New macro.
2579 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2580 Remove one incorrect comment and fix another.
b62a57be 2581
3539f31f
PE
2582 Fix minor ralloc.c problems found by static checking.
2583 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2584 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2585 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2586 (r_alloc_sbrk): Now static.
2587
a041960a
PE
2588 Improve ralloc.c interface checking.
2589 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2590 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2591 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2592 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2593 [REL_ALLOC]: ... to here, to check interface.
2594 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2595 Remove decls. This fixes an "It stinks!".
2596
9426aba4
PE
2597 * alloc.c (which_symbols): Fix alignment issue / type clash.
2598
d55c12ed
AS
25992012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2600
2601 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2602 (struct Lisp_Misc_Any): Likewise.
2603 (struct Lisp_Free): Likewise.
2604 * alloc.c (union aligned_Lisp_Symbol): Define.
2605 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2606 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2607 (union aligned_Lisp_Misc): Define.
2608 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2609 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2610 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2611
b948ce8b
PE
26122012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2615 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2616 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2617 * s/netbsd.h, s/sol2-6.h:
2618 Remove definition of GC_MARK_STACK, since the default now works.
2619 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2620 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2621 no longer the default.
2622 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2623
35dc09a1 26242012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2625
35dc09a1
GM
2626 * lread.c (lisp_file_lexically_bound_p):
2627 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2628
35dc09a1
GM
26292012-04-14 Eli Zaretskii <eliz@gnu.org>
2630
2631 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2632 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2633
26342012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2635
2636 * nsterm.m (constrainFrameRect): Always constrain when there is only
2637 one screen (Bug#10962).
2638
bcd86815
KB
26392012-04-13 Ken Brown <kbrown@cornell.edu>
2640
2641 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2642
c25df26e
RT
26432012-04-13 Reuben Thomas <rrt@sc3d.org>
2644
2645 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2646
0fc59f1e
DC
26472012-04-11 Daniel Colascione <dancol@dancol.org>
2648
2649 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2650 against is gone. It's better to use vfork now so that when Cygwin
2651 gains a new, working vfork, we use it automatically (bug#10398).
2652
de8c03dc
SM
26532012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2654
2655 * window.c (save_window_save): Obey window-point-insertion-type.
2656
2f097256
GM
26572012-04-11 Glenn Morris <rgm@gnu.org>
2658
2659 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2660
453b951e
SM
26612012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2662
2663 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2664
75f1671a 26652012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2666
2667 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2668 (force_quit_count): New var.
2669 (handle_interrupt): Use it.
2670
2a8ce227
JB
26712012-04-10 Juanma Barranquero <lekktu@gmail.com>
2672
2673 * w32.c (w32_delayed_load): Record the full path of the library
2674 being loaded (bug#10424).
2675
935396c0
GM
26762012-04-09 Glenn Morris <rgm@gnu.org>
2677
05920a43
GM
2678 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2679 not just in the obarray, before snarfing them. (Bug#11036)
2680
935396c0
GM
2681 * Makefile.in ($(leimdir)/leim-list.el):
2682 Pass EMACS rather than BUILT_EMACS.
2683
a18ecafa
TZ
26842012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2685
2686 * process.c (make_process):
2687 * process.h: Add integer `gnutls_handshakes_tried' member to
2688 process struct.
2689
6bbef4e5
JC
2690 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2691 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2692
2693 * gnutls.c (gnutls_log_function2i): Convenience log function.
2694 (emacs_gnutls_read): Use new log functions,
2695 `gnutls_handshakes_tried' process member, and
2696 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2697 attempts per process (connection).
2698
b4d3bc10
CY
26992012-04-09 Chong Yidong <cyd@gnu.org>
2700
2701 * eval.c (Fuser_variable_p, user_variable_p_eh)
2702 (lisp_indirect_variable): Functions deleted.
2703 (Fdefvar): Caller changed.
2704
2705 * callint.c (Finteractive, Fcall_interactively):
2706 * minibuf.c (Fread_variable): Callers changed.
2707
70f4d973
EZ
27082012-04-09 Eli Zaretskii <eliz@gnu.org>
2709
2710 * xdisp.c (set_cursor_from_row): If the display string appears in
2711 the buffer at position that is closer to point than the position
2712 after the display string, display the cursor on the first glyph of
2713 the display string. Fixes cursor display when a 'display' text
2714 property immediately follows invisible text. (Bug#11094)
2715
cb3c2e3e
PE
27162012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 composite.c: use 'double' consistently
2719 * composite.c (get_composition_id): Use 'double' consistently
2720 instead of converting 'float' to 'double' and vice versa; this is
2721 easier to understand and avoids a GCC warning.
2722
fd06db5d
GM
27232012-04-09 Glenn Morris <rgm@gnu.org>
2724
50fe702a
GM
2725 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2726 preparation for dumping it with emacs. (Bug#4789)
2727 (leimdir): New variable.
2728 ($(leimdir)/leim-list.el): New rule.
2729 (emacs$(EXEEXT)): Depend on leim-list.el.
2730
fd06db5d
GM
2731 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2732 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2733 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2734
55c131ee
AS
27352012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2736
2737 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2738 proper alignment.
2739
9209588f
JB
27402012-04-07 Juanma Barranquero <lekktu@gmail.com>
2741
2742 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2743 Remove unused local variable.
2744
e3fb2efb
PE
27452012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2746
2747 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2748 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2749 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2750 objects, as mark_maybe_pointer will catch them otherwise.
2751 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2752 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2753
b5385551
PE
27542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 Fix typo that broke non-Windows builds.
2757 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2758
9078ead6
EZ
27592012-04-07 Eli Zaretskii <eliz@gnu.org>
2760
2761 Support building on MS-Windows with libxml2.
2762
2763 * makefile.w32-in (OBJ2): Add xml.$(O).
2764 (GLOBAL_SOURCES): Add xml.c.
2765 ($(BLD)/xml.$(O)): New dependency list.
2766
2767 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2768 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2769 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2770 [!WINDOWSNT]: New macros.
2771 (init_libxml2_functions, libxml2_loaded_p): New functions.
2772 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2773 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2774 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2775 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2776 linked in).
6bbef4e5
JC
2777 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2778 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2779 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2780
2781 * emacs.c: Don't include libxml/parser.h.
2782 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2783 xmlCleanupParser directly.
2784
2785 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2786
3811fdf3
EZ
27872012-04-07 Eli Zaretskii <eliz@gnu.org>
2788
2789 * indent.c (Fvertical_motion): If there is a display string at
2790 point, use it.vpos to compute how many lines to backtrack after
2791 move_it_to point. (Bug#11133)
2792
2f8e16b2
EZ
27932012-04-06 Eli Zaretskii <eliz@gnu.org>
2794
2795 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2796 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2797 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2798 macros related to unification of CJK characters. For the details,
2799 see the discussion following the message here:
2800 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2801
3d439cd1
CY
28022012-04-04 Chong Yidong <cyd@gnu.org>
2803
2804 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2805
8bc53d00
EZ
28062012-04-01 Eli Zaretskii <eliz@gnu.org>
2807
2808 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2809 instead of alloca. (Bug#11138)
2810
3b0512a3
AS
28112012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2812
2813 * w32menu.c (is_simple_dialog): Properly check lisp types.
2814 (Bug#11141)
2815
8427ddd2
EZ
28162012-03-31 Eli Zaretskii <eliz@gnu.org>
2817
979022ef
EZ
2818 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2819 position we get to after a call to move_it_to fails the
2820 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2821 only if we wind up in a string from display property. (Bug#11063)
2822
a6b1c7cc
EZ
2823 * window.c (Fdelete_other_windows_internal): Invalidate the row
2824 and column information about mouse highlight, so that redisplay
2825 restores it after reallocating the glyph matrices. (Bug#7464)
2826
8427ddd2
EZ
2827 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2828 string comes from a `display' text property, use the buffer
2829 position of that property as if we actually saw that position in
2830 the row's glyphs.
697ba24b
EZ
2831 (move_it_by_lines): Remove the assertion that
2832 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2833 violated when there's a before-string at the beginning of a line.
2834 (Bug#11063)
8427ddd2 2835
65a0a738
EZ
28362012-03-30 Eli Zaretskii <eliz@gnu.org>
2837
2838 * xdisp.c (append_space_for_newline): If the default face was
2839 remapped, use the remapped face for the appended newline.
2840 (extend_face_to_end_of_line): Use the remapped default face for
2841 extending the face to the end of the line.
2842 (display_line): Call extend_face_to_end_of_line when the default
2843 face was remapped. (Bug#11068)
2844
581355cc
EZ
28452012-03-29 Eli Zaretskii <eliz@gnu.org>
2846
2847 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2848
e8fc049f
SM
28492012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2850
2851 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2852
4fb9a543
GM
28532012-03-27 Glenn Morris <rgm@gnu.org>
2854
2855 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2856 Doc fixes.
2857
679910f1
KH
28582012-03-26 Kenichi Handa <handa@m17n.org>
2859
2860 * dispextern.h (struct glyph): Fix previous change. Change the
2861 bit length of glyphless.ch to 25 (Bug#11082).
2862
90d49b7f
CY
28632012-03-26 Chong Yidong <cyd@gnu.org>
2864
2865 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2866 (command_loop_1): Use it; inhibit selection update for
2867 handle-select-window too (Bug#8996).
2868
f514f6f0
FP
28692012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2870
e8fc049f 2871 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2872
bf43fa51
KH
28732012-03-25 Kenichi Handa <handa@m17n.org>
2874
2875 * dispextern.h (struct glyph): Change the bit length of
2876 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2877
8a0c01dd
EZ
28782012-03-24 Eli Zaretskii <eliz@gnu.org>
2879
2880 * s/ms-w32.h (tzname): Include time.h before redirecting to
2881 _tzname. Fixes the MSVC build. (Bug#9960)
2882
7d1c3a76
AS
28832012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2884
8ed79523
AS
2885 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2886 characters.
2887
7d1c3a76
AS
2888 * xterm.c (XTread_socket): Only modify handling_signal if
2889 !SYNC_INPUT. (Bug#11080)
2890
e99a9b8b
EZ
28912012-03-23 Eli Zaretskii <eliz@gnu.org>
2892
2893 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2894 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2895 when fetching a multibyte character consumes more bytes than
2896 CHAR_BYTES returns, due to unification of CJK characters in
2897 string_char. (Bug#11073)
2898
5063c0e1
TN
28992012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2900
2901 * process.c (wait_reading_process_output): Handle pty disconnect
2902 by refraining from sending oneself a SIGCHLD (bug#10933).
2903
9f851fbd
CY
29042012-03-22 Chong Yidong <cyd@gnu.org>
2905
2906 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2907
5063c0e1 2908 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2909 Mark string as coming from a prefix property.
2910 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2911 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2912
fb5b8aca
CY
29132012-03-21 Chong Yidong <cyd@gnu.org>
2914
2915 * xfaces.c (Vface_remapping_alist): Doc fix.
2916
62356a1b
EZ
29172012-03-20 Eli Zaretskii <eliz@gnu.org>
2918
2919 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2920 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2921 Doc fixes.
62356a1b 2922
025de85b
CY
29232012-03-20 Chong Yidong <cyd@gnu.org>
2924
2925 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2926 to reflect default non-nil value of redisplay-dont-pause.
2927
4827f94e
KH
29282012-03-19 Kenichi Handa <handa@m17n.org>
2929
2930 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2931 it fit in a valid range (Bug#11003).
2932
e50a24a2
EZ
29332012-03-18 Eli Zaretskii <eliz@gnu.org>
2934
2935 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2936 that is not from display property, accept the row as a "cursor
2937 row" if one of the string's character has a non-nil `cursor'
2938 property. Fixes cursor positioning when there are newlines in
2939 overlay strings, e.g. in icomplete.el. (Bug#11035)
2940
9af5ed87
PE
29412012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2944
d1f55f16
CY
29452012-03-12 Chong Yidong <cyd@gnu.org>
2946
2947 * eval.c (inhibit_lisp_code): Rename from
2948 inhibit_window_configuration_change_hook; move from window.c.
2949
2950 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2951 * window.c (run_window_configuration_change_hook)
2952 (syms_of_window): Callers changed.
2953
66c5eebd
CY
29542012-03-11 Chong Yidong <cyd@gnu.org>
2955
413df973
CY
2956 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2957
66c5eebd
CY
2958 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2959
1de11f56
CY
29602012-03-10 Chong Yidong <cyd@gnu.org>
2961
2962 * frame.c (other_visible_frames): Don't assume the selected frame
2963 is visible (Bug#10955).
2964
cae07000
SM
29652012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2966
2967 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2968
89c94350
JD
29692012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2970
2971 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2972 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2973 zero (Bug#10954).
2974
999dd333
GM
29752012-03-03 Glenn Morris <rgm@gnu.org>
2976
01a6dcc8 2977 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2978
de0100f2
EZ
29792012-03-02 Eli Zaretskii <eliz@gnu.org>
2980
2981 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2982 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2983 (redisplay_window, next_element_from_string): Fix typos in
2984 comments.
3e441275
EZ
2985 (redisplay_window): Pass to move_it_vertically the margin in
2986 pixels, not in screen lines.
de0100f2 2987
96a72ee9
GM
29882012-03-02 Glenn Morris <rgm@gnu.org>
2989
2990 * buffer.c (buffer-list-update-hook): Doc fix.
2991
312508d7
EZ
29922012-02-29 Eli Zaretskii <eliz@gnu.org>
2993
2994 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2995 push_it before setting up the iterator for the first overlay
2996 string, even if we have an empty string loaded.
2997 (next_overlay_string): If there's an empty string on the iterator
2998 stack, pop the stack. (Bug#10903)
2999
27f3c637
PE
30002012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3001
3002 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3003 Suggested by Stefan Monnier in
3004 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3005 * alloc.c (widen_to_Lisp_Object): New static function.
3006 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3007 and widening them to Lisp_Objects. This would work even if
3008 USE_LSB_TAG is defined and wide integers are used, which might
3009 happen in a future version of Emacs.
3010
3c9dfce6
CY
30112012-02-25 Chong Yidong <cyd@gnu.org>
3012
fa74b241
CY
3013 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3014 Doc fix.
3015
3c9dfce6
CY
3016 * xselect.c (Fx_selection_exists_p): Doc fix.
3017 (x_clipboard_manager_save_all): Print an informative message
3018 before saving to clipboard manager.
3019
9486df08
CY
30202012-02-24 Chong Yidong <cyd@gnu.org>
3021
3022 * keyboard.c (process_special_events): Handle all X selection
3023 requests in kbd_buffer, not just the next one (Bug#8869).
3024
f01d3321
CY
30252012-02-23 Chong Yidong <cyd@gnu.org>
3026
3027 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3028 call when setting menu-bar-lines and tool-bar-lines parameters.
3029 (unwind_create_frame_1): New helper function.
3030
3031 * window.c (inhibit_window_configuration_change_hook): New var.
3032 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3033 (syms_of_window): Initialize it.
f01d3321 3034
86b847b6
CY
30352012-02-22 Chong Yidong <cyd@gnu.org>
3036
3037 * xterm.c (x_draw_image_relief): Add missing type check for
3038 Vtool_bar_button_margin (Bug#10743).
3039
a59225b1
CY
30402012-02-21 Chong Yidong <cyd@gnu.org>
3041
3042 * fileio.c (Vfile_name_handler_alist): Doc fix.
3043
3044 * buffer.c (Fget_file_buffer): Protect against invalid file
3045 handler return value.
3046
310f5bd4
PE
30472012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3048
cb3a28cc
PE
3049 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3050 when computing $valmask.
3051
310f5bd4
PE
3052 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3053 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3054 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3055 It's useless in that case, and it can cause problems on hosts
3056 that allocate halves of EMACS_INT values separately.
3057 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3058 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3059 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3060 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3061 it avoids undefined behavior on hosts where shifting right by more
3062 than the word width has undefined behavior.
3063
2375c96a
CY
30642012-02-19 Chong Yidong <cyd@gnu.org>
3065
3066 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3067 (Funhandled_file_name_directory, Ffile_name_as_directory)
3068 (Fdirectory_file_name, Fexpand_file_name)
3069 (Fsubstitute_in_file_name): Protect against invalid file handler
3070 return values (Bug#10845).
3071
3eb49e71
EZ
30722012-02-18 Eli Zaretskii <eliz@gnu.org>
3073
3074 * .gdbinit (pitx): Fix incorrect references to fields of the
3075 iterator stack.
3076
7b926f3f
CY
30772012-02-17 Chong Yidong <cyd@gnu.org>
3078
3079 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3080
11273115
PE
30812012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3084 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3085
c3a70e2b
CY
30862012-02-15 Chong Yidong <cyd@gnu.org>
3087
3088 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3089 marked as special. Also, starting docstrings with * is obsolete.
3090
0ca43699
AS
30912012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3092
3093 * gnutls.c (emacs_gnutls_write): Fix last change.
3094
2e8f3c56
LI
30952012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3096
3097 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3098 send_process.
3099
af70074f
SM
31002012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3101
3102 * keymap.c (Fsingle_key_description): Handle char ranges.
3103
95986d52
CY
31042012-02-12 Chong Yidong <cyd@gnu.org>
3105
afd83bd1
CY
3106 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3107 as that creates a dangerous corner case.
3108
95986d52
CY
3109 * window.c (Fdelete_window_internal): Invalidate the mouse
3110 highlight (Bug#9904).
3111
bd7da63e
GM
31122012-02-12 Glenn Morris <rgm@gnu.org>
3113
3114 * xselect.c (Fx_own_selection_internal)
3115 (Fx_get_selection_internal, Fx_disown_selection_internal)
3116 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3117 * nsselect.m (Fx_own_selection_internal)
3118 (Fx_disown_selection_internal, Fx_selection_exists_p)
3119 (Fx_selection_owner_p, Fx_get_selection_internal):
3120 Sync docs and argument specs with the xselect.c versions.
3121
77abcbc2
LI
31222012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3123
3124 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3125
90b671e2
EZ
31262012-02-11 Eli Zaretskii <eliz@gnu.org>
3127
1c0ca0b7
EZ
3128 * w32select.c (Fx_selection_exists_p): Sync doc string and
3129 argument list with xselect.c. (Bug#10783)
3130
3131 * w16select.c (Fx_selection_exists_p): Sync doc string and
3132 argument list with xselect.c. (Bug#10783)
90b671e2 3133
49241268
GM
31342012-02-10 Glenn Morris <rgm@gnu.org>
3135
3136 * fns.c (Fsecure_hash): Doc fix.
3137
f998bbe7 31382012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3139
3140 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3141
0992bd9c
CY
31422012-02-07 Chong Yidong <cyd@gnu.org>
3143
3144 * buffer.c (Fbuffer_local_variables)
3145 (buffer_lisp_local_variables): Handle unbound vars correctly;
3146 don't let Qunbound leak into Lisp.
3147
af008560
GM
31482012-02-07 Glenn Morris <rgm@gnu.org>
3149
dd605cc4
GM
3150 * image.c (Fimagemagick_types): Doc fix.
3151
af008560
GM
3152 * image.c (imagemagick-render-type): Change it from a lisp object
3153 to an integer. Move the doc here from the lisp manual.
3154 Treat all values not equal to 0 the same.
3155
1449fa1d
CY
31562012-02-06 Chong Yidong <cyd@gnu.org>
3157
3158 * doc.c (store_function_docstring): Avoid applying docstring of
3159 alias to base function (Bug#2603).
3160
3723ec07
AS
31612012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3162
3163 * .gdbinit (pp1, pv1): Remove redundant defines.
3164 (pr): Use pp.
3165
79c1cc1e
CY
31662012-02-04 Chong Yidong <cyd@gnu.org>
3167
3168 * nsterm.m: Declare a global (Bug#10694).
3169
d7f29f8e
EZ
31702012-02-04 Eli Zaretskii <eliz@gnu.org>
3171
cae07000
SM
3172 * w32.c (get_emacs_configuration_options):
3173 Include --enable-checking, if specified, in the return value.
d7f29f8e 3174
3b95a6f9
MR
31752012-02-04 Martin Rudalics <rudalics@gmx.at>
3176
3177 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3178 after rounding frame sizes. (Bug#9723)
3179
d6fa96a6
EZ
31802012-02-04 Eli Zaretskii <eliz@gnu.org>
3181
3182 * keyboard.c (adjust_point_for_property): Don't position point
3183 before BEGV. (Bug#10696)
3184
df0b2940
PE
31852012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3186
3187 Handle overflow when computing char display width (Bug#9496).
3188 * character.c (char_width): Return EMACS_INT, not int.
3189 (char_width, c_string_width): Check for overflow when
3190 computing the width; this is possible now that individual
3191 characters can have unbounded width. Problem introduced
3192 by merge from Emacs 23 on 2012-01-19.
3193
6bee44d6
MA
31942012-02-02 Michael Albinus <michael.albinus@gmx.de>
3195
3196 * dbusbind.c (Fdbus_register_method): Mention the return value
3197 :ignore in the docstring.
3198
44f92739
GM
31992012-02-02 Glenn Morris <rgm@gnu.org>
3200
1b9f60cc
GM
3201 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3202
44f92739
GM
3203 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3204 Unconditionally set to t. (Bug#10673)
3205 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3206 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3207 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3208
c5d3843c
KH
32092012-02-02 Kenichi Handa <handa@m17n.org>
3210
3211 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3212 0, do not call append_composite_glyph.
3213
159462d4 32142012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3215
3216 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3217 NULL (Bug#6988).
3218 (x_produce_glyphs): If the component of a composition is a null
3219 string, set it->pixel_width to 1 to avoid zero-width glyph.
3220
78cef877
EZ
32212012-02-01 Eli Zaretskii <eliz@gnu.org>
3222
3223 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3224 first 2 arguments are identical. This makes inserting large
3225 output from a subprocess an order of magnitude faster on
3226 MS-Windows, where all sbrk'ed memory is always contiguous.
3227
97897668
GM
32282012-01-31 Glenn Morris <rgm@gnu.org>
3229
3230 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3231 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3232 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3233
31fd3586
GM
32342012-01-29 Glenn Morris <rgm@gnu.org>
3235
3236 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3237
0e24a8b2
CY
32382012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3239
3240 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3241
cc0adcb0
CY
32422012-01-28 Chong Yidong <cyd@gnu.org>
3243
3244 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3245
acc28cb9
CY
32462012-01-26 Chong Yidong <cyd@gnu.org>
3247
9c69cfb7
CY
3248 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3249
acc28cb9
CY
3250 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3251 repeat counts (Bug#10507).
3252
48da7392
GM
32532012-01-26 Glenn Morris <rgm@gnu.org>
3254
3255 * lread.c (syms_of_lread): Doc fix.
3256
14af5f7f
CY
32572012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3258
3259 * coding.c (encode_designation_at_bol): Change return value to
3260 EMACS_INT.
3261
0b21c100
CY
32622012-01-25 Chong Yidong <cyd@gnu.org>
3263
3264 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3265
3c2907f7
CY
32662012-01-21 Chong Yidong <cyd@gnu.org>
3267
3268 * floatfns.c (Fcopysign): Make the second argument non-optional,
3269 since nil is not allowed anyway.
3270
959ad23f
AS
32712012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3272
3273 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3274 (send_process): Likewise.
3275
34a02f46
MR
32762012-01-19 Martin Rudalics <rudalics@gmx.at>
3277
3278 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3279 (Vwindow_persistent_parameters): Do not use Qstate.
3280 Rewrite doc-strings.
34a02f46 3281
1259009a 32822012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3283
3284 * character.c (char_width): New function.
70d4fdf6
GM
3285 (Fchar_width, c_string_width, lisp_string_width):
3286 Use char_width (Bug#9496).
25ed9e61 3287
6a6ee00d
MR
32882012-01-16 Martin Rudalics <rudalics@gmx.at>
3289
3290 * window.c (Vwindow_persistent_parameters): New variable.
3291 (Fset_window_configuration, save_window_save): Handle persistent
3292 window parameters.
3293
c85efaf7
EZ
32942012-01-14 Eli Zaretskii <eliz@gnu.org>
3295
3296 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3297 thrashing the stack of the thread. (Bug#9087)
3298
5944709e
PE
32992012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3302
e71f5d99
EZ
33032012-01-11 Eli Zaretskii <eliz@gnu.org>
3304
3305 * xdisp.c (rows_from_pos_range): Handle the case where the
3306 highlight ends on a newline. (Bug#10464)
3307 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3308 he end column for display of highlight that ends on a newline
3309 before a R2L line.
3310
ce316182
GM
33112012-01-11 Glenn Morris <rgm@gnu.org>
3312
3313 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3314 from load-path also when installation-directory is nil. (Bug#10208)
3315
5b43da69
GM
33162012-01-10 Glenn Morris <rgm@gnu.org>
3317
74cc8ff9
GM
3318 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3319
7d8d6e4e
GM
3320 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3321 Update template values to be closer to their typical values these days.
5b43da69 3322
a0db8d43
EZ
33232012-01-09 Eli Zaretskii <eliz@gnu.org>
3324
3325 * xdisp.c (rows_from_pos_range): Accept additional argument
3326 DISP_STRING, and accept any glyph in a row whose object is that
3327 string as eligible for mouse highlight. Fixes mouse highlight of
3328 display strings from overlays. (Bug#10464)
3329
9a0115ab 33302012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3331
b9110d6a 3332 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3333 * fileio.c (auto_saving_dir_umask): New static var.
3334 (Fmake_directory_internal): Use it.
3335 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3336 creating the directory. The old code temporarily assigns
3337 too-generous permissions to the directory.
3338 (do_auto_save_eh): Clear it.
b9110d6a 3339 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3340 that the var is always cleared.
3341
6c1bd3f3
EZ
33422012-01-07 Eli Zaretskii <eliz@gnu.org>
3343
3344 * search.c (scan_buffer): Pass character positions to
3345 know_region_cache, not byte positions. (Bug#6540)
3346
069d2b50
L
33472012-01-07 LynX <_LynX@bk.ru> (tiny change)
3348
3349 * w32.c (sys_rename): Report EXDEV when rename of a directory
3350 fails because the target is on another logical disk. (Bug#10284)
3351
75bf0d33
DB
33522012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3353
3354 * xterm.c (x_embed_request_focus): New function.
3355
3356 * xterm.h: Add prototype.
3357
3358 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3359
1c6e5a32
GM
33602012-01-05 Glenn Morris <rgm@gnu.org>
3361
3362 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3363
651e947e
EZ
33642012-01-01 Eli Zaretskii <eliz@gnu.org>
3365
3366 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3367 Load gnutls_transport_set_lowat only if GnuTLS version is below
3368 2.11.1.
3369 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3370 GnuTLS versions below 2.11.1.
3371
3778cdd8
AL
33722011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3373
3374 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3375 to the doc string advising against its use for altering the way
3376 windows are scrolled.
3377
0e5317f7
KH
33782011-12-28 Kenichi Handa <handa@m17n.org>
3379
3380 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3381 coding-system ASCII compatible only when it does not produce BOM
3382 on encoding (Bug#10383).
3383
93d5ca1f
JD
33842011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3385
3386 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3387 can scroll.
3388 (create_and_show_popup_menu): Always use menu_position_func for
3389 Gtk3 (Bug#10361).
3390
ca22b785
AS
33912011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3392
3393 * callint.c (Fcall_interactively): Don't truncate prompt string.
3394
d048e1e6
EZ
33952011-12-23 Eli Zaretskii <eliz@gnu.org>
3396
3397 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3398 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3399 resumed from there (after widening). (Bug#10360)
d048e1e6 3400
5ccaba1f
JD
34012011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3402
3403 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3404
204ee57f
JD
34052011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3406
b81d40f0
JB
3407 * nsterm.m (x_free_frame_resources):
3408 Release f->output_data.ns->miniimage.
204ee57f
JD
3409 (ns_index_color): Fix indentation. Do not retain
3410 color_table->colors[i].
3411
3412 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3413 before returning.
3414
3415 * nsfns.m (x_set_background_color): Assign return value from
3416 ns_index_color to face-background instead of NSColor*.
3417 (ns_implicitly_set_icon_type): Fix indentation.
3418 Change assignment in for loop to comparison.
3419
3420 * emacs.c (ns_pool): New variable.
3421 (main): Assign ns_pool.
3422 (Fkill_emacs): Call ns_release_autorelease_pool.
3423
3424 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3425 autorelease fdesc, release fdAttrs and tdict.
3426 (ns_get_covering_families): Release charset.
3427 (ns_findfonts): Release NSFontDescriptor created with new.
3428 (ns_uni_to_glyphs): Fix indentation.
3429 (setString): Release attrStr before assigning new value.
3430
c803b2b7
JD
34312011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3432
678f4426
JD
3433 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3434 and NS_IMPL_COCOA.
3435 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3436 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3437
cd394be1 34382011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3439
5fecd5fc
JD
3440 * nsterm.m (ns_term_init): Subscribe for notifications
3441 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3442 to method trackingNotification in EmacsMenu.
3443
3444 * nsmenu.m (trackingMenu): New variable.
3771cb17 3445 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3446 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3447 from Aquamacs (Bug#7030).
678f4426
JD
3448
34492011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3450
c803b2b7
JD
3451 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3452 (symbol_to_nsstring): Fix indentation.
3453 (ns_symbol_to_pb): New function.
cae07000
SM
3454 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3455 (Fns_rotate_cut_buffers_internal): Remove.
3456 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3457 Fns_store_cut_buffer_internal.
3458 (ns_get_foreign_selection, Fx_own_selection_internal)
3459 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3460 (Fns_get_selection_internal, Fns_store_selection_internal):
3461 Use ns_symbol_to_pb and check if return value is nil.
3462 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3463 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3464 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3465 renamed to Sns_store_selection_internal.
3466 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3467 and remove this function.
3468 (ns_handle_selection_clear): Remove, never used.
3469 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3470 here.
3471
e1b01a3a
KB
34722011-12-17 Ken Brown <kbrown@cornell.edu>
3473
3474 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3475 GID is unknown (Bug#10257).
3476
2adb6e85
PE
34772011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3480 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3481 which caused a build failure on GNU/Linux IA-64. This problem was
3482 introduced by my 2011-10-07 patch.
3483
d1d7b339
JL
34842011-12-15 Juri Linkov <juri@jurta.org>
3485
3486 * image.c (imagemagick_error): New function. (Bug#10112)
3487 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3488 Use `imagemagick_error' where ImageMagick functions return
3489 `MagickFalse'.
3490 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3491 proper order.
3492
100d5755
KH
34932011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3494
3495 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3496 fill background (Bug#8992).
3497
454592a6
MR
34982011-12-13 Martin Rudalics <rudalics@gmx.at>
3499
3500 * window.c (Vwindow_combination_resize)
3501 (Vwindow_combination_limit): Use t instead of non-nil in
3502 doc-strings.
61d4b438
MR
3503 (Vrecenter_redisplay): Add first sentence of doc-string on
3504 separate line.
53524d93 3505 (Frecenter): Fix doc-string typo.
454592a6 3506
3633e3aa
KH
35072011-12-11 Kenichi Handa <handa@m17n.org>
3508
3509 * coding.c (Funencodable_char_position): Pay attention to the
3510 buffer text relocation (Bug#9389).
3511
7b9d523a 35122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3513
7b9d523a
JD
3514 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3515 gtk_init (Bug#10100).
3516
b73189c6
EZ
35172011-12-10 Eli Zaretskii <eliz@gnu.org>
3518
3519 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3520 IT->string is nil. (Bug#10263)
3521
f7dfe5d6
JD
35222011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3523
83faebb4
JD
3524 * nsterm.h (x_free_frame_resources): Declare.
3525
f7dfe5d6
JD
3526 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3527 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3528
3529 * nsterm.h (ns_get_defaults_value): Declare.
3530
3531 * nsterm.m (ns_default): Call ns_get_defaults_value.
3532
7cd4e72c
EZ
35332011-12-09 Eli Zaretskii <eliz@gnu.org>
3534
3535 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3536 (Bug#10170)
3537
b34d7317
YM
35382011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3539
3540 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3541 that where the value of an _OBJC_* symbol points to is in the .bss
3542 section (Bug#10240).
3543
76470ad1
KH
35442011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3545
3546 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3547 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3548
745fff94
KH
35492011-12-08 Kenichi Handa <handa@m17n.org>
3550
3551 * ftfont.c (get_adstyle_property): Fix previous change
3552 (Bug#10233).
3553
6e44397c
JB
35542011-12-07 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3557 dirs from the default value of EMACSLOADPATH (bug#10208).
3558
7efa6272
GM
35592011-12-07 Glenn Morris <rgm@gnu.org>
3560
3561 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3562 installation and source directories as well. (Bug#10208)
3563
f6fc4d87
CY
35642011-12-06 Chong Yidong <cyd@gnu.org>
3565
3566 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3567
2bf26180
GM
35682011-12-06 Glenn Morris <rgm@gnu.org>
3569
3570 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3571 as an error, not just -1. (Bug#10217)
3572
3a6ad4f0
CY
35732011-12-05 Chong Yidong <cyd@gnu.org>
3574
3575 * keyboard.c (process_special_events): New function.
3576 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3577
75a3b399
PE
35782011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3579
3580 * coding.c (encode_designation_at_bol): Don't use uninitialized
3581 local variable (Bug#9318).
3582
c3c9e25e
KH
35832011-12-05 Kenichi Handa <handa@m17n.org>
3584
3585 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3586 return Qnil (Bug#8046, Bug#10193).
3587
5eb05ea3
KH
35882011-12-05 Kenichi Handa <handa@m17n.org>
3589
3590 * coding.c (encode_designation_at_bol): New args charbuf_end and
3591 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3592 (coding_set_source): Return how many bytes coding->source was
3593 relocated.
3594 (coding_set_destination): Return how many bytes
3595 coding->destination was relocated.
3596 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3597 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3598
35992011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3600
3601 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3602 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3603 macro (Bug#9318).
3604
36052011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3606
3607 The following changes are to fix Bug#9318.
3608
a79703f5 3609 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3610 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3611 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3612 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3613
7dbda6df
JB
36142011-12-05 Juanma Barranquero <lekktu@gmail.com>
3615
3616 * lisp.h (process_quit_flag): Fix external declaration.
3617
6d5eb5b0
SM
36182011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3619
3620 Don't macro-inline non-performance-critical code.
3621 * eval.c (process_quit_flag): New function.
3622 * lisp.h (QUIT): Use it.
3623
a0c3fad0
JD
36242011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3625
3626 * nsfns.m (get_geometry_from_preferences): New function.
3627 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3628
6c07aac2
AS
36292011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3630
3631 * emacs.c (Qkill_emacs): Define.
3632 (syms_of_emacs): Initialize it.
3633 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3634 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3635 (quit_throw_to_read_char): Add parameter `from_signal'.
3636 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3637 * lisp.h (QUIT): Call Fkill_emacs if requested.
3638
c052ead4
JD
36392011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3640
3641 * widget.c (update_wm_hints): Return if wmshell is null.
3642 (widget_update_wm_size_hints): New function.
3643
3644 * widget.h (widget_update_wm_size_hints): Declare.
3645
3646 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3647 widget_update_wm_size_hints (Bug#10104).
3648
9e49252b
EZ
36492011-12-03 Eli Zaretskii <eliz@gnu.org>
3650
3651 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3652 before a newline, prepare the bidi iterator for consuming the
3653 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3654 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3655
02b16839
JL
36562011-12-02 Juri Linkov <juri@jurta.org>
3657
3658 * search.c (Fword_search_regexp): New Lisp function created from
3659 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3660 (Fword_search_backward, Fword_search_forward)
3661 (Fword_search_backward_lax, Fword_search_forward_lax):
3662 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3663 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3664
0068070e
SM
36652011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3666
3667 * fileio.c (Finsert_file_contents): Move after-change-function call
3668 to before the "handled:" label, since all "goto handled" appear in
3669 cases where the *-change-functions have already been properly called
3670 (bug#10117).
3671
3360a3fc
AS
36722011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3673
3674 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3675 waiting for input. (Bug#10169)
3676
73d6c093
EZ
36772011-11-30 Eli Zaretskii <eliz@gnu.org>
3678
3679 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3680 verifies glyph row's hash code--we have just reallocated the
3681 glyphs, so their contents can be complete garbage. (Bug#10164)
3682
febe6bea
JB
36832011-11-30 Juanma Barranquero <lekktu@gmail.com>
3684
3685 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3686
801a4313
EZ
36872011-11-30 Eli Zaretskii <eliz@gnu.org>
3688
3689 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3690 attributes are tested _before_ calling verify_row_hash, to protect
3691 against GCC re-ordering of the tests. (Bug#10164)
3692
2b56b87e
JD
36932011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3694
3695 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3696
3697 * xterm.c (handle_one_xevent): Only set async_visible and friends
3698 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3699 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3700 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3701
dbf31225
PE
37022011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3705 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3706 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3707 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3708 All uses changed to use GCPRO1 etc.
3709 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3710 Revert to old implementation (i.e., before 2011-03-11).
3711
1305621b
YM
37122011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3713
3714 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3715 of scroll runs so as to avoid assigning disabled bogus rows and
3716 unnecessary graphics copy operations.
3717
8c9afb46
EZ
37182011-11-27 Eli Zaretskii <eliz@gnu.org>
3719
3720 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3721 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3722 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3723 (malloc, free, realloc, calloc): Redirect to e_* only when
3724 compiling Emacs.
3725
3726 * lisp.h (GCTYPEBITS): Move before first use.
3727 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3728 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3729 this macro definition.
3730
3731 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3732 _MSC_VER.
3733
54e9e3bf
JD
37342011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3735
6d5eb5b0
SM
3736 * gtkutil.c (xg_create_frame_widgets):
3737 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3738 present with Gtk+ 2.0.
3739
83aca1cb
PE
37402011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3741
3742 * fileio.c (Finsert_file_contents): Undo previous change; see
3743 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3744
5b76caa4
PE
37452011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3746
3747 Rename locals to avoid shadowing.
3748 * fileio.c (Finsert_file_contents):
3749 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3750 * process.c (wait_reading_process_output):
3751 Rename inner 'proc' to 'p' to avoid shadowing.
3752 Indent for consistency with usual Emacs style.
3753
8c535114
EZ
37542011-11-25 Eli Zaretskii <eliz@gnu.org>
3755
3756 * xdisp.c (redisplay_window): If cursor row is not fully visible
3757 after recentering, and scroll-conservatively is set to a large
3758 number, scroll window by a few more lines to make the cursor fully
3759 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3760 (start_display): Don't move to the next line if the display should
3761 start at a newline that is part of a display vector or an overlay
3762 string. (Bug#10119)
8c535114 3763
fa4fdb5c
JL
37642011-11-24 Juri Linkov <juri@jurta.org>
3765
3766 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3767 after the `MagickPingImage' call. (Bug#10112)
3768
90ec88df
CY
37692011-11-23 Chong Yidong <cyd@gnu.org>
3770
3771 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3772
56e2e794
MR
37732011-11-23 Martin Rudalics <rudalics@gmx.at>
3774
3775 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3776 making another buffer current. (Bug#10114)
3777
b6e64c41
GM
37782011-11-23 Glenn Morris <rgm@gnu.org>
3779
3780 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3781
6b21de18
CY
37822011-11-23 Chong Yidong <cyd@gnu.org>
3783
3784 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3785 using it (Bug#5984).
3786
b12cd789
EZ
37872011-11-22 Eli Zaretskii <eliz@gnu.org>
3788
3789 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3790 and header-lines, as they don't have one computed for them.
3791 (Bug#10098)
3792
3793 * .gdbinit (prow): Make displayed values more self-explaining.
3794 Add row's hash code.
3795
261b6fd4
LMI
37962011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3797
3798 * process.c (wait_reading_process_output): Fix asynchrounous
3799 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3800 (wait_reading_process_output): Add comment and URL.
261b6fd4 3801
e7cfd277
JD
38022011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3803
3804 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3805
a9b9b7f5
CY
38062011-11-21 Chong Yidong <cyd@gnu.org>
3807
3808 * window.c (Fnext_window, Fprevious_window): Doc fix.
3809
b0d15b4f
SM
38102011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3811
3812 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3813
fe7a3057
JB
38142011-11-20 Juanma Barranquero <lekktu@gmail.com>
3815
3816 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3817
d2999b1a
MR
38182011-11-20 Martin Rudalics <rudalics@gmx.at>
3819
3820 * window.c (Fset_window_combination_limit): Rename argument
3821 STATUS to LIMIT.
3822 (Vwindow_combination_limit): Remove "status" from doc-string.
3823
d5ff9cd0
AS
38242011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3825
3826 * m/ibms390.h: Remove.
3827 * m/ibms390x.h: Don't include "ibms390.h".
3828
a5bb9bd3
SM
38292011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3830
3831 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3832 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3833
cd1181db
JB
38342011-11-20 Juanma Barranquero <lekktu@gmail.com>
3835
3836 * casetab.c (Fset_case_table):
3837 * charset.c (Fcharset_after): Fix typos.
3838
615a3b8d 38392011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3840
17e845af
PE
3841 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3842 Otherwise, valgrind does not work on some platforms.
3843 Problem reported by Andreas Schwab in
6a0bf43d
PE
3844 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3845 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3846 is set, removing the need for VIRT_ADDRESS_VARIES.
3847 (PURE_P): Use a more-efficient implementation that needs just one
3848 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3849 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3850 to 4 (xorl, subq, cmpq, setbe).
3851 * alloc.c (pure): Always extern now, since that's the
3852 VIRT_ADDR_VARIES behavior.
3853 (PURE_POINTER_P): Use a single comparison, not two, for
3854 consistency with the new puresize.h.
3855 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3856 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3857 Remove VIRT_ADDR_VARIES no longer needed.
3858
f8fe6f96
EZ
38592011-11-19 Eli Zaretskii <eliz@gnu.org>
3860
3861 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3862 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3863 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3864 behave as if the cursor position were at the window margin.
3865
3866 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3867 and the cursor position is out of bounds, behave as if the cursor
3868 position were at the window margin. (Bug#10075)
3869
df05a53c
CY
38702011-11-18 Chong Yidong <cyd@gnu.org>
3871
3872 * window.c (Fwindow_combination_limit): Make first argument
3873 non-optional, since it is meaningless for live windows like the
3874 selected window.
61ccba97 3875
2071918e
DA
38762011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3877
3878 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3879
b50a28de
SM
38802011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3881
3882 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3883 (graft_intervals_into_buffer): Simplify.
3884
015137db
EZ
38852011-11-18 Eli Zaretskii <eliz@gnu.org>
3886
3887 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3888 hash values of the two rows.
3889 (copy_row_except_pointers): Preserve the used[] arrays and the
3890 hash values of the two rows. (Bug#10035)
68c95424 3891 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3892
3893 * xdisp.c (row_hash): New function, body extracted from
3894 compute_line_metrics.
3895 (compute_line_metrics): Call row_hash, instead of computing the
3896 hash code inline.
3897
3898 * dispnew.c (verify_row_hash): Call row_hash for computing the
3899 hash code of a row, instead of duplicating code from xdisp.c.
3900
3901 * dispextern.h (row_hash): Add prototype.
3902
a2addb04
TH
39032011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3904
3905 * frame.c (delete_frame): Don't delete the terminal when the last
3906 X frame is closed if emacs is built with GTK toolkit.
3907
df85d315
JB
39082011-11-17 Juanma Barranquero <lekktu@gmail.com>
3909
3910 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3911
a0c2d0ae
MR
39122011-11-17 Martin Rudalics <rudalics@gmx.at>
3913
3914 * window.c (Vwindow_splits): Rename to
3915 Vwindow_combination_resize. Suggested by Juri Linkov.
3916 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3917 of Vwindow_splits.
3918
58179cce
JB
39192011-11-16 Juanma Barranquero <lekktu@gmail.com>
3920
7877f373
JB
3921 * nsfns.m (Fns_font_name):
3922 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3923
b6f67890
MR
39242011-11-16 Martin Rudalics <rudalics@gmx.at>
3925
3926 * window.h (window): Rename slot "nest" to "combination_limit".
3927 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3928 (Fset_window_nest): Rename to Fset_window_combination_limit.
3929 (Vwindow_nest): Rename to Vwindow_combination_limit.
3930 (recombine_windows, make_parent_window, make_window)
3931 (Fsplit_window_internal, saved_window)
3932 (Fset_window_configuration, save_window_save): Rename all
3933 occurrences of window_nest to window_combination_limit.
3934
c7015153
JB
39352011-11-15 Juanma Barranquero <lekktu@gmail.com>
3936
3937 * image.c (imagemagick_load_image): Fix typo.
3938
322ad6ec
EZ
39392011-11-14 Eli Zaretskii <eliz@gnu.org>
3940
3941 * xdisp.c (display_line): Move the call to
3942 highlight_trailing_whitespace before the call to
3943 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3944 faces of all the glyphs to compute ROW's hash value.
3945 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3946
f067b8ec
JB
39472011-11-14 Juanma Barranquero <lekktu@gmail.com>
3948
3949 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3950 just return (bug#10044).
3951
1e5b2111
EZ
39522011-11-12 Eli Zaretskii <eliz@gnu.org>
3953
7ef3cbd5
EZ
3954 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3955 with user-defined heap size. Bump the default size of the temacs
3956 heap to 27MB, to avoid memory warning when running temacs.
3957 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3958
1e5b2111
EZ
3959 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3960 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3961 (verify_row_hash) [XASSERTS]: New function.
3962 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3963 that the hash value of glyph rows is correct.
1e5b2111 3964
89d61221
MR
39652011-11-12 Martin Rudalics <rudalics@gmx.at>
3966
3967 * window.h (window): Remove splits slot.
3968 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3969 (Fdelete_other_windows_internal, make_parent_window)
3970 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3971 (Fset_window_configuration, save_window_save): Don't deal with
3972 split status of windows.
3973 (saved_window): Remove splits slot.
3974 (Vwindow_splits): Rewrite doc-string.
3975
97f18cc8
JD
39762011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3977
3978 * xfns.c (unwind_create_frame):
3979 * nsfns.m (unwind_create_frame):
3980 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3981 Vframe_list (Bug#9999).
3982
22a648b4
DA
39832011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3984
0b381c7e 3985 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3986
659afede
KH
39872011-11-11 Kenichi Handa <handa@m17n.org>
3988
3989 * callproc.c (Fcall_process): Set the member dst_multibyte of
3990 process_coding.
3991
9ac0394b
KH
39922011-11-11 Johan Bockgård <bojohan@gnu.org>
3993
3994 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3995 avoid a crash (bug#9496).
3996
2fbdc249
CY
39972011-11-09 Chong Yidong <cyd@gnu.org>
3998
3999 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4000 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4001
ac6b1f81
PE
40022011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4005
09db192c
PE
40062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4007
4008 Avoid some portability problems by eschewing 'extern inline' functions.
4009 The trivial performance wins aren't worth the portability hassles; see
4010 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4011 et seq.
4012 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4013 (window_box_width, window_box_left, window_box_left_offset)
4014 (window_box_right, window_box_right_offset): Undo previous change,
4015 by removing the "extern"s.
4016 * intervals.c (adjust_intervals_for_insertion)
4017 (adjust_intervals_for_deletion): Undo previous change,
4018 making these static again.
4019 (offset_intervals, temp_set_point_both, temp_set_point)
4020 (copy_intervals_to_string): No longer inline.
4021 * xdisp.c (window_text_bottom_y, window_box_width)
4022 (window_box_height, window_box_left_offset)
4023 (window_box_right_offset, window_box_left, window_box_right)
4024 (window_box): No longer inline.
4025
105216ed
CY
40262011-11-08 Chong Yidong <cyd@gnu.org>
4027
4028 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4029 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4030 Signal an error if not a live window.
105216ed
CY
4031 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4032 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4033
ae9e237f
JB
40342011-11-07 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * lisp.h (syms_of_abbrev): Remove declaration.
4037 Reported by CHENG Gao <chenggao@royau.me>.
4038
c7aa8333
EZ
40392011-11-07 Eli Zaretskii <eliz@gnu.org>
4040
4041 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4042 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4043 of temacs in GUI mode.
4044
be7f5545
MR
40452011-11-07 Martin Rudalics <rudalics@gmx.at>
4046
4047 * window.h: Declare delete_all_child_windows instead of
4048 delete_all_subwindows.
4049 * window.c (Fwindow_nest, Fset_window_nest)
4050 (Fset_window_new_total, Fset_window_new_normal)
4051 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4052 (delete_all_subwindows): Rename to delete_all_child_windows.
4053 (Fdelete_other_windows_internal, Fset_window_configuration):
4054 Call delete_all_child_windows instead of delete_all_subwindows.
4055 * frame.c (delete_frame): Call delete_all_child_windows instead
4056 of delete_all_subwindows.
4057
ca78dc43
PE
40582011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4059
4060 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4061 This is also needed for porting to any host where GC_MARK_STACK is
4062 not GC_MAKE_GCPROS_NOOPS.
4063 (which_symbols): Use it.
4064
a0241d01
KH
40652011-11-07 Kenichi Handa <handa@m17n.org>
4066
4067 * coding.c (coding_set_destination): Check coding->src_pos only
4068 when coding->src_object is a buffer (bug#9910).
4069
4070 * process.c (send_process): Set the member src_multibyte of coding
4071 to 0 (bug#9911) when sending a unibyte text.
4072
4073 * callproc.c (Fcall_process): Set the member src_multibyte of
4074 process_coding to 0 (bug#9912).
4075
a64bfdfa 40762011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4077
4078 * xmenu.c (cleanup_widget_value_tree): New function.
4079 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4080 calling free_menubar_widget_value_tree directly (Bug#9830).
4081
cb41b32a
PE
40822011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4083
4084 Fix some portability problems with 'inline'.
4085 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4086 (window_box_width, window_box_left, window_box_left_offset)
4087 (window_box_right, window_box_right_offset): Declare extern.
4088 Otherwise, these inline functions do not conform to C99 and
4089 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4090 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4091 * intervals.c (adjust_intervals_for_insertion)
4092 (adjust_intervals_for_deletion): Now extern, because otherwise the
4093 extern inline functions 'offset_intervals' couldn't refer to it.
4094 (static_offset_intervals): Remove.
4095 (offset_intervals): Rewrite using the old contents of
4096 static_offset_intervals. The old version didn't conform to C99
4097 because an extern inline function contained a reference to an
4098 identifier with static linkage.
4099
b7041366
AS
41002011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4101
4102 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4103 GC.
4104
88a37c4d
EZ
41052011-11-06 Eli Zaretskii <eliz@gnu.org>
4106
4107 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4108 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4109 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4110 return Qleft_to_right.
4111
49745b39
CY
41122011-11-06 Chong Yidong <cyd@gnu.org>
4113
4114 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4115 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4116 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4117 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4118 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4119 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4120 (Fwindow_vscroll): Doc fix.
4121 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4122 argument, since it makes no sense to pass a live window and for
4123 consistency with window-child.
4124
1f05cd82
CS
41252011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4126
4127 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4128 support MSVC.
4129
22610910
JR
41302011-11-05 Jason Rumney <jasonr@gnu.org>
4131
4132 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4133 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4134 fonts (Bug#6029).
4135 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4136 bitwise arithmetic preventing use of unicode-sip and non-truetype
4137 opentype fonts.
4138
a06776b2
EZ
41392011-11-05 Eli Zaretskii <eliz@gnu.org>
4140
3ad924ba
EZ
4141 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4142 "emacs"-only part.
4143
a06776b2
EZ
4144 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4145 initialization code to keep similarity to xfns.c after changes
4146 from 2011-11-05.
4147
c9e7db78
JD
41482011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4149
a97f8f3f
JD
4150 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4151 (unwind_create_frame): New function (Bug#9943).
4152 (Fx_create_frame): Restructure code to be more similar to the one in
4153 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4154 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4155 Move terminal->reference_count++ just before making the frame official
4156 (Bug#9943).
4157
4158 * nsterm.m (x_free_frame_resources): New function.
4159 (x_destroy_window): Move code to x_free_frame_resources.
4160
c9e7db78 4161 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4162 (Fx_create_frame, x_create_tip_frame):
4163 Move terminal->reference_count++ just before making the frame
75f1671a 4164 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4165 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4166
a6fc3b5c
EZ
41672011-11-05 Eli Zaretskii <eliz@gnu.org>
4168
4169 Support MSVC build with newer versions of Visual Studio.
4170 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4171 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4172 nt/gmake.defs.
4173
4174 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4175 which are not supported by MSVC.
4176 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4177 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4178 bitfields.
4179 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4180 types in bitfields.
4181 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4182
4183 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4184
58179cce 41852011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4186
4187 Support MSVC build with newer versions of Visual Studio.
4188 * w32.c: Don't include w32api.h for MSVC.
4189 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4190
4191 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4192 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4193 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4194 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4195 e_* cousins.
4196 (alloca) [_MSC_VER]: Define to _alloca.
4197
4198 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4199
4200 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4201
a58c13ed
EZ
42022011-11-04 Eli Zaretskii <eliz@gnu.org>
4203
4204 * xdisp.c (note_mouse_highlight): If either of
4205 previous/next-single-property-change returns nil, treat that as
4206 the beginning or the end of the buffer. (Bug#9955)
4207
fe0b6370
JD
42082011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4209
a58c13ed 4210 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4211 label is not null (Bug#9951).
4212 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4213 may be NULL.
4214
89bd5ee1
EZ
42152011-11-04 Eli Zaretskii <eliz@gnu.org>
4216
4217 * window.c (Fwindow_body_size): Mention in the doc string that the
4218 return value is in frame's canonical units. (Bug#9949)
4219
84c3edb9
EZ
42202011-11-03 Eli Zaretskii <eliz@gnu.org>
4221
4e2fb5c7
EZ
4222 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4223
84c3edb9 4224 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4225 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4226 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4227
bc17a887
EZ
42282011-11-01 Eli Zaretskii <eliz@gnu.org>
4229
4230 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4231 Don't stop backward scan on the continuation glyph, even though
4232 its CHARPOS is positive.
6d5eb5b0
SM
4233 (mouse_face_from_buffer_pos, note_mouse_highlight):
4234 Rename cover_string to disp_string.
bc17a887 4235
4ee88440
MR
42362011-11-01 Martin Rudalics <rudalics@gmx.at>
4237
4238 * window.c (temp_output_buffer_show): Don't use
4239 Vtemp_buffer_show_specifiers.
4240 (Vtemp_buffer_show_specifiers): Remove unused variable.
4241
c2ff3c02
EZ
42422011-10-30 Eli Zaretskii <eliz@gnu.org>
4243
4244 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4245 past the beginning of the current glyph matrix.
4246
58179cce 42472011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4248
4249 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4250 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4251 HAVE_GTK3 (Bug#9869).
b77a6a7f 4252
3b574623
JD
4253 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4254 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4255
b77a6a7f
JD
4256 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4257
4258 * xterm.c: Declare x_handle_net_wm_state to return int.
4259 (handle_one_xevent): Check if we are iconified but don't have
4260 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4261 (get_current_wm_state): Return non-zero if not hidden,
4262 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4263 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4264 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4265 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4266
196e41e4
PE
42672011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4268
4269 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4270 so that this new function doesn't get optimized away by a
4271 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4272
021f2e1a
AS
42732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4274
4275 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4276
8b058d44
EZ
42772011-10-29 Eli Zaretskii <eliz@gnu.org>
4278
4279 Fix the `xbytecode' command.
4280 * .gdbinit (xprintbytestr): New command.
b50a28de 4281 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4282 (xbytecode): Print the byte-code string as well.
4283
4452fb80
EZ
42842011-10-29 Kim Storm <storm@cua.dk>
4285
8b058d44
EZ
4286 * alloc.c (which_symbols): New function.
4287
21b72067
AS
42882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4289
4290 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4291 line. (Bug#9903)
4292
83ed7b5c
GM
42932011-10-29 Glenn Morris <rgm@gnu.org>
4294
4295 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4296 Not clear what it was for, and it causes various bugs. (Bug#9839)
4297
5a7a728b
EZ
42982011-10-28 Eli Zaretskii <eliz@gnu.org>
4299
4300 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4301 possible random value that matches one of those tested as
4302 condition to clear the mouse face.
4303
d3d0842f
CY
43042011-10-28 Chong Yidong <cyd@gnu.org>
4305
4306 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4307
31b39d13
DN
43082011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4309
4310 * window.c (make_window): Initialize phys_cursor_on_p.
4311
9aba6043
SM
43122011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4313
4314 * lisp.h (struct Lisp_Symbol): Update comments.
4315
c20992f4
JB
43162011-10-28 Juanma Barranquero <lekktu@gmail.com>
4317
4318 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4319
db4f02f2
EZ
43202011-10-28 Eli Zaretskii <eliz@gnu.org>
4321
4322 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4323 <oslsachem@gmail.com> for helping to debug this.
4324
4325 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4326 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4327 (g_b_init_get_glyph_outline_w): New static variables.
4328 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4329 (GetGlyphOutlineW_Proc): New typedefs.
4330 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4331 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4332 New functions.
4333 (w32font_open_internal, compute_metrics):
4334 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4335 instead of calling the "wide" APIs directly.
4336
4337 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4338
4339 * w32.h (syms_of_w32font): Add prototype.
4340
87e68db4
JB
43412011-10-27 Juanma Barranquero <lekktu@gmail.com>
4342
4343 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4344 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4345 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4346 (Fmove_to_window_line): Doc fix.
4347
435c1d67
CY
43482011-10-27 Chong Yidong <cyd@gnu.org>
4349
4350 * process.c (make_process): Set gnutls_state to NULL.
4351
4352 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4353 non-NULL, regardless of GNUTLS_INITSTAGE.
4354 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4355 an error. Set process slots as soon as we allocate them.
4356
4357 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4358
9c6c6f49
CY
43592011-10-27 Chong Yidong <cyd@gnu.org>
4360
9aba6043
SM
4361 * gnutls.c (emacs_gnutls_deinit): New function.
4362 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4363 (Fgnutls_deinit, Fgnutls_boot): Use it.
4364
4365 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4366 (deactivate_process): Call emacs_gnutls_deinit.
4367
657d08d3
JB
43682011-10-27 Juanma Barranquero <lekktu@gmail.com>
4369
4370 * image.c (x_create_x_image_and_pixmap):
4371 * w32.c (sys_rename, w32_delayed_load):
4372 * w32font.c (fill_in_logfont):
4373 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4374
5430d399
JB
43752011-10-26 Juanma Barranquero <lekktu@gmail.com>
4376
4377 * w32fns.c (w32_default_color_map): New function,
4378 extracted from Fw32_default_color_map.
a7ef684b 4379 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4380
fe0055fa
PE
43812011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4382
4383 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4384
e6346438
SM
43852011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4386
4387 * keyboard.c (test_undefined): New function (bug#9751).
4388 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4389
e112cc37
ET
43902011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4391
4392 * sysdep.c (init_sys_modes): Fix the check for the controlling
4393 terminal (Bug#6649).
4394
7b5d6677
EZ
43952011-10-20 Eli Zaretskii <eliz@gnu.org>
4396
4397 * dispextern.h (struct bidi_it): New member next_en_type.
4398
4399 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4400 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4401 current character, check also for next_en_type being WEAK_EN.
4402 (bidi_resolve_weak): Don't enter the expensive loop if the current
4403 position is before next_en_pos. Record the bidi type of the first
4404 non-ET, non-BN character we find, in addition to its position.
4405 (bidi_level_of_next_char): Invalidate next_en_type when
4406 next_en_pos is over-stepped.
4407
7da0b018
PE
44082011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4411 * editfns.c: Rewrite current-time-zone so that it invokes
4412 the equivalent of (format-time-string "%Z") to get the time zone name.
4413 This fixes a bug when the time zone name contains characters that
4414 need converting from the system time locale to Emacs internal format.
4415 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4416 that patch fixed format-time-string to do the conversion, but
4417 I forgot to fix current-time-zone.
4418 (format_time_string): New function, containing most of
4419 what Fformat_time_string used to contain.
4420 (Fformat_time_string): Rewrite in terms of format_time_string.
4421 This doesn't change this function's behavior.
4422 (current-time-zone): Rewrite to use format_time_string.
4423 This fixes the bug reported by Michael Schierl in
4424 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4425 Jason Rumney's 2007-06-07 change worked around this bug, but
4426 didn't fix it.
4427 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4428
8547b010
EZ
44292011-10-19 Eli Zaretskii <eliz@gnu.org>
4430
4431 * xdisp.c (start_display): If the character at POS is displayed
4432 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4433 (try_window_reusing_current_matrix): If a line ends in a display
4434 vector or the next line starts in a display vector, continue
4435 redrawing the window even though the character position of
4436 start_row was reached.
8547b010
EZ
4437 (Bug#9771, part 2)
4438
4e948d15
CY
44392011-10-18 Chong Yidong <cyd@gnu.org>
4440
4441 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4442 with nobreak-char-display too.
4443
4787455f
EZ
44442011-10-18 Eli Zaretskii <eliz@gnu.org>
4445
4446 Fix part 3 of bug#9771.
4447 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4448 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4449 non-neutral characters if the current character is a paragraph
4450 separator (a.k.a. Newline). This avoids running the same
4451 expensive loop twice, once when we consume the preceding newline
4452 and the other time when the line actually needs to be displayed.
4453 Avoid the loop when we see neutrals on the base embedding level
4454 following a character whose directionality is the same as the
4455 paragraph's. This avoids running the expensive loop when a line
4456 ends in a long sequence of neutrals, like control characters.
4457 Add assertion against STRONG_AL type. Slightly rearrange code
4458 that determines the type of a neutral given the first non-neutral
4459 that follows it.
4460 (bidi_level_of_next_char): Set next_en_pos to zero when
4461 invalidating its info.
4462
2c91f553
EZ
44632011-10-17 Eli Zaretskii <eliz@gnu.org>
4464
4465 * xdisp.c (push_display_prop): Determine whether to record string
4466 or buffer position by IT->string, not by IT->method. Allow
4467 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4468 (move_it_vertically_backward): Don't look for character position
4469 immediately after the newline when in a continuation line.
4470 (Bug#9771, part 1)
2c91f553 4471
c7b08b0d
MR
44722011-10-15 Martin Rudalics <rudalics@gmx.at>
4473
4474 * window.c (coordinates_in_window): Rewrite and delabelize
4475 vertical border check. (Bug#5357) (Bug#9618)
4476
6b02f655
SM
44772011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4478
4479 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4480 errors in XSetWindowBorder (bug#9310).
4481
81d40c92
DA
44822011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4483
4484 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4485 avoid crash when xmalloc overrun checking is enabled.
4486
d4172c3b
EZ
44872011-10-13 Eli Zaretskii <eliz@gnu.org>
4488
4489 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4490 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4491 cursor motion with <left> and <right> arrow keys.
4492
4493 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4494 some callers set that themselves.
4495
b00eea75
EZ
44962011-10-12 Eli Zaretskii <eliz@gnu.org>
4497
4498 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4499 display string and the previous row comes from the same string and
4500 is empty. (Bug#9739) (Bug#9738)
4501
8fe012c4
SM
45022011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4503
4504 * doc.c (get_doc_string): Encode file name (bug#9735).
4505
0074aef2
EZ
45062011-10-12 Eli Zaretskii <eliz@gnu.org>
4507
79beb178
EZ
4508 * bidi.c (bidi_level_of_next_char):
4509 * xdisp.c (get_visually_first_element): Remove old incorrect
4510 comments regarding the Unicode Line Separator character.
4511
0074aef2
EZ
4512 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4513
6e4b3fbe
DA
45142011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4515
4516 * alloc.c (Fgc_status): Do not access beyond zombies array
4517 boundary if nzombies > MAX_ZOMBIES.
4518 * alloc.c (dump_zombies): Add missing format specifier.
4519
0324f3af
PE
45202011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4521
b5525cac
PE
4522 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4523 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4524
0324f3af
PE
4525 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4526 Some packages use them to denote characters with modifiers.
4527
e9b5f888
AS
45282011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4529
4530 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4531 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4532 matching a pp-number. Rename parameter var to var1.
4533
127827c0
SM
45342011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4535
4536 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4537
c8fd3bd0
GM
45382011-10-08 Glenn Morris <rgm@gnu.org>
4539
4540 * callint.c (Fcall_interactively): Give a more explicit error for the
4541 'c' case with a non-character input. (Bug#8479)
4542
352ec8ff
EZ
45432011-10-08 Eli Zaretskii <eliz@gnu.org>
4544
03669ccb
EZ
4545 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4546 lines.
7061c986
EZ
4547 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4548 lines that are hscrolled on the left.
03669ccb 4549
352ec8ff
EZ
4550 * dispnew.c (buffer_posn_from_coords): Account for a possible
4551 presence of header-line. (Bug#4426)
4552
a66cfb1c
SM
45532011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4554
6b02f655
SM
4555 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4556 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4557
7c5ee88e
PE
45582011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4559
4560 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4561 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4562 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4563 this makes Emacs dump core during garbage collection on rare
4564 occasions. sizeof is obviously inferior to offsetof here, so
4565 stick with offsetof.
4566 (GC_POINTER_ALIGNMENT): New macro.
4567 (mark_memory): Omit 3rd (offset) arg; caller changed.
4568 Don't assume EMACS_INT alignment is the same as pointer alignment.
4569
df1bbe5b
SM
45702011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4571
4572 * keyboard.c (read_key_sequence_remapped): New var.
4573 (read_key_sequence): Compute remapping in the right buffer.
4574 (command_loop_1): Use read_key_sequence's remapping directly.
4575
51553db6
SM
45762011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4577
32c1fffd
SM
4578 * dired.c (file_name_completion): Don't expand file name.
4579 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4580 before checking file name handler.
4581
51553db6
SM
4582 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4583 they've been requested explicitly (bug#9591).
4584
b6bd1599 45852011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4586
4587 * keymap.c (Fsingle_key_description): Use make_specified_string
4588 instead of build_string to build string from push_key_description.
4589 (Bug#5193)
4590
f701dc2a
PE
45912011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4592
4222c55d
PE
4593 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4594 This fixes a Y2038 bug on 64-bit hosts.
4595 * buffer.c (reset_buffer):
4596 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4597 (Fclear_buffer_auto_save_failure):
4598 Use 0, not -1, to represent an unset failure time, since time_t
4599 might not be signed.
4600
f701dc2a
PE
4601 Remove dependency on glibc malloc internals.
4602 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4603 Move back here from lisp.h, but with their new implementations.
4604 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4605 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4606 * charset.c (charset_table_init): New static var.
4607 (syms_of_charset): Use it instead of xmalloc. This removes a
4608 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4609 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4610 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4611 Move back to alloc.c.
4612 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4613 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4614
9ceebf39
JD
46152011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4616
4617 * nsterm.m (windowDidResize): Call x_set_window_size only when
4618 ns_in_resize is true. Otherwise set pixelwidth/height and
4619 call change_frame_size (Bug#9628).
4620
cb993c58
PE
46212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4622
3930c88b
PE
4623 Port --enable-checking=all to Fedora 14 x86-64.
4624 * charset.c (syms_of_charset): Also account for glibc malloc's
4625 internal overhead when calculating the initial malloc maximum.
4626
cb993c58
PE
4627 Port --enable-checking=all to Fedora 14 x86.
4628 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4629 Move to lisp.h.
4630 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4631 (overrun_check_realloc, overrun_check_free):
4632 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4633 That way, xmalloc returns a properly-aligned pointer even if
4634 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4635 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4636 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4637 into account when calculating the initial malloc maximum.
4638 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4639 Move here from alloc.c, so that charset.c can use it too.
4640 Properly align; the old code wasn't right for common 32-bit hosts
4641 when configured with --enable-checking=all.
4642 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4643 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4644
31bed486
EZ
46452011-09-29 Eli Zaretskii <eliz@gnu.org>
4646
04c70788 4647 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4648 use EDOM.
4649
fbcaa2f3
EZ
46502011-09-28 Eli Zaretskii <eliz@gnu.org>
4651
4652 * xdisp.c (compute_display_string_end): If there's no display
4653 string at CHARPOS, return -1.
4654
4655 * bidi.c (bidi_fetch_char): When compute_display_string_end
4656 returns a negative value, treat the character as a normal
4657 character not covered by a display string. (Bug#9624)
4658
a239d4e9
JB
46592011-09-28 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * lread.c (Fread_from_string): Fix typo in docstring.
4662
88652fd5
EZ
46632011-09-27 Eli Zaretskii <eliz@gnu.org>
4664
4665 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4666 newline, reseat the iterator instead of bidi-iterating there one
4667 character at a time. (Bug#9610)
32c1fffd
SM
4668 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4669 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4670
ed497dd4
AS
46712011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4672
4673 * lread.c (readevalloop): Use correct code for NBSP.
4674 (read1): Likewise. (Bug#9608)
4675
b2bf61aa
MA
46762011-09-25 Michael Albinus <michael.albinus@gmx.de>
4677
4678 * dbusbind.c (Fdbus_register_signal): When service is not
4679 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4680
32bbb17c
GM
46812011-09-25 Glenn Morris <rgm@gnu.org>
4682
4683 * buffer.c (truncate-lines): Doc fix.
4684
94e0933e
CY
46852011-09-24 Chong Yidong <cyd@stupidchicken.com>
4686
4687 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4688 (Fset_window_next_buffers): Doc fix.
4689
cddde921
GM
46902011-09-24 Glenn Morris <rgm@gnu.org>
4691
4692 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4693
1260aef1
PE
46942011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4695
25b4bfa0
PE
4696 Fix minor problems found by static checking.
4697 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4698 * indent.c (Fvertical_motion): Fix == vs = typo.
4699
e3cbd34b
EZ
47002011-09-24 Eli Zaretskii <eliz@gnu.org>
4701
a66cfb1c
SM
4702 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4703 Default value is now t. Doc fix.
6bf7006f 4704
e3cbd34b 4705 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4706 logic when moving up, not only when moving down. Fix the
e3cbd34b 4707 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4708 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4709
4710 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4711 CHARPOS is covered by a display string which includes newlines.
4712 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4713 is covered by a display string with embedded newlines.
4714
a3de0cbd
MA
47152011-09-24 Michael Albinus <michael.albinus@gmx.de>
4716
4717 * dbusbind.c (Fdbus_register_signal): Add match rule to
4718 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4719 (Fdbus_register_method, Vdbus_registered_objects_table):
4720 Fix docstring.
a3de0cbd 4721
b260039d
JM
47222011-09-24 Jim Meyering <meyering@redhat.com>
4723
32c1fffd 4724 do not ignore write error for any output size
b260039d
JM
4725 The previous change was incomplete.
4726 While it makes emacs --batch detect the vast majority of stdout
4727 write failures, errors were still ignored whenever the output size is
4728 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4729 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4730 && echo FAIL: ignored write error
4731 FAIL: ignored write error
4732 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4733 && echo FAIL: ignored write error
4734 FAIL: ignored write error
4735 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4736
8eca8a7c
AS
47372011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4738
4739 * emacs.c (Fkill_emacs): In noninteractive mode exit
4740 non-successfully if a write error occurred on stdout. (Bug#9574)
4741
3341db62
EZ
47422011-09-21 Eli Zaretskii <eliz@gnu.org>
4743
4744 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4745 the xassert test.
4746
4747 * dispextern.h (struct it): Update the comment documenting what
4748 can it->OBJECT be.
4749
8c203dbf
EZ
47502011-09-20 Eli Zaretskii <eliz@gnu.org>
4751
4752 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4753 a display string, extend search for cursor position to end of row.
4754 (find_row_edges): If the row ends in a newline from a display
4755 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4756 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4757 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4758 non-empty line. Fixes confusing cursor motion with arrow keys at
4759 the beginning of a line that starts with whitespace.
8c203dbf 4760
a4824228
LMI
47612011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4762
4763 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4764 (bug#9493).
4765
33ed493b
CY
47662011-09-18 Chong Yidong <cyd@stupidchicken.com>
4767
4768 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4769 boolean (Bug#9154).
4770
56cd55c8
EZ
47712011-09-18 Eli Zaretskii <eliz@gnu.org>
4772
4773 * xdisp.c (display_line): Record maximum and minimum buffer
4774 positions even if no glyphs were produced (e.g., by a zero-width
4775 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4776 buffer positions that will be removed from the glyph row because
4777 they don't fit.
c02dcedf
EZ
4778 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4779 column is beyond frame width: don't subtract 1 "pixel" when
4780 computing width of the stretch.
3e62b7e0
EZ
4781 (reseat_at_next_visible_line_start): Undo the change made on
4782 2011-09-17 that saved paragraph information and restored it after
4783 the call to `reseat'. (Bug#9545)
56cd55c8 4784
5ed99d36 47852011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4786
4787 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4788 and turn window cursor on if cleared (Bug#9415).
4789
5ed99d36 47902011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4791
4792 * search.c (boyer_moore): Take unibyte characters from pattern
4793 literally. (Bug#9458)
4794
9bade7b2
EZ
47952011-09-18 Eli Zaretskii <eliz@gnu.org>
4796
4797 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4798
e5e9d610
PE
47992011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4800
87e4427a
PE
4801 Fix minor problem found by static checking.
4802 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4803 initialized, to pacify gcc -Wuninitialized.
4804
e5e9d610
PE
4805 * fileio.c: Report proper errno when syscall falls.
4806 (Finsert_file_contents): Save and restore errno,
4807 so that report_file_error outputs the correct diagnostic.
4808 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4809
a1674f0b
EZ
48102011-09-18 Eli Zaretskii <eliz@gnu.org>
4811
4812 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4813
fbfb6dd4
EZ
48142011-09-17 Eli Zaretskii <eliz@gnu.org>
4815
4816 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4817 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4818
bb187662
EZ
48192011-09-17 Eli Zaretskii <eliz@gnu.org>
4820
1137e8b8 4821 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4822 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4823
4824 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4825 (bidi_find_paragraph_start): Search back for paragraph beginning
4826 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4827 (bidi_move_to_visually_next): Only trigger paragraph-related
4828 computations when the last character is a newline or at EOB, not
4829 just any NEUTRAL_B. (Bug#9470)
4830
bb187662
EZ
4831 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4832 truncated lines if point is covered by a display string. (Bug#9524)
4833
2e621251
PE
48342011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4837 (cons_to_x_long): New function.
4838 (lisp_data_to_selection_data): Use it. Correct the test for
4839 short-versus-long data; it was negated. Break out of vector
4840 loop, for efficiency, when a long datum is discovered.
4841
91a15bc6
SM
48422011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4843
4844 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4845
b41c3a35
EZ
48462011-09-16 Eli Zaretskii <eliz@gnu.org>
4847
4848 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4849 GCC PR/17406) by declaring this function with external scope.
4850
7812ba2d
PE
48512011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4852
4853 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4854 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4855
cf7edc2a
AS
48562011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4857
4858 * editfns.c (Fformat): Correctly handle text properties on "%%".
4859
bd01620e
EZ
48602011-09-15 Eli Zaretskii <eliz@gnu.org>
4861
4862 * xterm.c (x_draw_composite_glyph_string_foreground):
4863 * w32term.c (x_draw_composite_glyph_string_foreground):
4864 * term.c (encode_terminal_code):
4865 * composite.c (composition_update_it, get_composition_id):
4866 * xdisp.c (get_next_display_element)
4867 (fill_composite_glyph_string): Add comments about special meaning
4868 of TAB characters in a composition.
4869
a02719a3
PE
48702011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4871
4872 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4873 This occurs when processing a multibyte format.
4874 Problem reported by Wolfgang Jenker.
a02719a3 4875
72589a3c
JB
48762011-09-15 Johan Bockgård <bojohan@gnu.org>
4877
4878 * xdisp.c (try_cursor_movement): Only check for exact match if
4879 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4880
1c14176c
PE
48812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4882
4883 Remove unused external symbols.
4884 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4885 * xdisp.c (calc_pixel_width_or_height): Now static.
4886 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4887 * indent.c (check_display_width):
4888 * w32term.c: Fix comment to match code.
4889 * xterm.c, xterm.h (x_catching_errors): Remove.
4890
d2eea5b5
PE
48912011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 * xselect.c: Use signed conversions more consistently (Bug#9498).
4894 (selection_data_to_lisp_data): Assume incoming selection data are
4895 signed integers, not unsigned. This is to be consistent with
4896 outgoing selection data, which was modified to use signed integers
4897 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4898 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4899 expects long, not unsigned long.
4900
46888499
EZ
49012011-09-14 Eli Zaretskii <eliz@gnu.org>
4902
4903 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4904 computation of loop end. Reported by Johan Bockgård
4905 <bojohan@gnu.org>.
4906
ef8ef9fb
CY
49072011-09-13 Chong Yidong <cyd@stupidchicken.com>
4908
4909 * frame.c (Fother_visible_frames_p): Function deleted.
4910
fa819fed
EZ
49112011-09-12 Eli Zaretskii <eliz@gnu.org>
4912
4913 * indent.c (compute_motion): Process display vector front to back
4914 rather than the other way around. (Bug#2496)
4915
2ba8e008
SM
49162011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4917
4918 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4919
20f53c69
CY
49202011-09-11 Chong Yidong <cyd@stupidchicken.com>
4921
4922 * minibuf.c (Fread_from_minibuffer): Doc fix.
4923
d562d7a4
EZ
49242011-09-11 Eli Zaretskii <eliz@gnu.org>
4925
4926 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4927 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4928
1c4d7f3d
LMI
49292011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4930
4931 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4932 value for non-existent files.
4933
b885bf36
EZ
49342011-09-11 Eli Zaretskii <eliz@gnu.org>
4935
4936 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4937 set its "size" to -1. This will set the modtime_size field of
4938 the corresponding buffer to -1, which is what
4939 verify-visited-file-modtime expects for files that do not exist.
4940 (Bug#9139)
4941
6612f0bf
PE
49422011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4943
4944 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4945 here ...
4946 * lisp.h: ... from here. push_key_description is no longer
4947 defined in keyboard.c, so its declaration should not be in
4948 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4949 logically belongs with push_key_description.
4950
dfb3f755
PE
49512011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 * buffer.h: Include <sys/types.h> instead of <time.h>.
4954 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4955 Problem reported by Herbert J. Skuhra.
4956
3134906c
LMI
49572011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4958
4959 * xml.c (parse_region): Make the parsing work for
4960 non-comment-starting XML files again (bug#9144).
4961
8d903f4e
AS
49622011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4963
4964 * image.c (gif_load): Fix calculation of bottom and right corner.
4965 (Bug#9468)
4966
80ad64f4
EZ
49672011-09-10 Eli Zaretskii <eliz@gnu.org>
4968
4969 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4970 redisplay in small windows.
4971
208a048d
EZ
49722011-09-09 Eli Zaretskii <eliz@gnu.org>
4973
4974 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4975
9b1c252e
MR
49762011-09-08 Martin Rudalics <rudalics@gmx.at>
4977
4978 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4979 Operate on live windows only.
4980
2949f33b
JB
49812011-09-08 Juanma Barranquero <lekktu@gmail.com>
4982
4983 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4984
e08dcafd
EZ
49852011-09-07 Eli Zaretskii <eliz@gnu.org>
4986
4987 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4988 only under bidi iteration.
4989
115b96bd
JD
49902011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4991
4992 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4993
c8199d0f
PE
49942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4995
4996 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4997 Without this fix, the command to link temacs failed due to an
4998 undefined symbol __builtin_isnan. This is because
4999 /usr/include/iso/math_c99.h #defines isnan(x) to
5000 __builtin_isnan(x), but the bundled gcc, which identifies itself
5001 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5002 a __builtin_isnan.
5003 * floatfns.c (isnan): #undef, and then #define to a clone of
5004 what's in data.c.
5005 (Fisnan): Always define, since it's always available now.
5006 (syms_of_floatfns): Always define isnan at the Lisp level.
5007
e39b275c 50082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5009
5010 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5011
b2db44d9 50122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5013
f4af5137 5014 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5015 The previous code assumed that file offsets (off_t values) fit in
5016 EMACS_INT variables, which is not true on typical 32-bit hosts.
5017 The code messed up by falsely reporting buffer overflow in cases
5018 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5019 when "big" contains more than 2**29 bytes, even though this
5020 inserts just one byte and does not overflow the buffer.
5021 (Finsert_file_contents): Store file offsets as off_t
5022 values, not as EMACS_INT values. Check for overflow when
5023 converting between EMACS_INT and off_t. When checking for
5024 buffer overflow or for overlap, take the offsets into account.
5025 Don't use EMACS_INT for small values where int suffices.
5026 When checking for overlap, fix a typo: ZV was used where
5027 ZV_BYTE was intended.
5028 (Fwrite_region): Don't assume off_t fits into 'long'.
5029 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5030
ecfc0a49
MA
50312011-09-05 Michael Albinus <michael.albinus@gmx.de>
5032
5033 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5034
6511acf2 50352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5036
0999621a 5037 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5038
5039 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5040 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5041 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5042 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5043 (modify_event_symbol): Do not assume that the length of
5044 name_alist_or_stem is safe to alloca and fits in int.
5045 (Fexecute_extended_command): Likewise for function name and binding.
5046 (Frecursion_depth): Wrap around reliably on integer overflow.
5047 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5048 since some callers pass EMACS_INT values.
5049 (Fsingle_key_description): Don't crash if symbol name contains more
5050 than MAX_ALLOCA bytes.
5051 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5052 (get_minibuffer): Arg is now EMACS_INT, not int.
5053 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5054 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5055 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5056
2be7d702
PE
5057 * dbusbind.c (signature_cat): New function.
5058 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5059 Do not overrun buffer; instead, report string overflow.
5060
9d1df220
PE
5061 * dispnew.c (add_window_display_history): Don't overrun buffer.
5062 Truncate instead; this is OK since it's just a log.
5063
33ef5c64
PE
5064 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5065 even if the time zone offset is outlandishly large.
5066 Don't mishandle offset == INT_MIN.
5067
66c6fdd5
PE
5068 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5069 when creating daemon; the previous buffer-overflow check was incorrect.
5070
d749b01b
PE
5071 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5072 which has the guts of the old verror function.
5073
b5cd1905
PE
5074 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5075 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5076
6e1a67fb
PE
5077 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5078 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5079 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5080 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5081 length of string rather than counting it via multiple sprintfs;
5082 that's simpler and more reliable.
c21721cc
PE
5083 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5084 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5085 sprintf, in case result does not fit in int.
5086
c57b67fc
PE
5087 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5088 (fontset_from_font): Print it.
5089
8a401434
PE
5090 * frame.c (tty_frame_count): Now printmax_t, not int.
5091 (make_terminal_frame, set_term_frame_name): Print it.
5092 (x_report_frame_params): In X, window IDs are unsigned long,
5093 not signed long, so print them as unsigned.
5094 (validate_x_resource_name): Check for implausibly long names,
5095 and don't assume name length fits in 'int'.
5096 (x_get_resource_string): Don't blindly alloca invocation name;
5097 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5098 not fit in int.
5099
6e1a67fb
PE
5100 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5101 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5102 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5103
0df02bf3
PE
5104 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5105 Use esprintf, not sprintf, in case result does not fit in int.
5106
48e30793
PE
5107 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5108 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5109 it as a large positive number.
5110 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5111 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5112
a66ff6d8
PE
5113 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5114 in case result does not fit in int.
5115
aca216ff
PE
5116 * print.c (float_to_string): Detect width overflow more reliably.
5117 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5118 buffer overrun. Don't assume list length fits in 'int'. Treat
5119 print length of 0 as 0, not as infinity; to be consistent with other
5120 uses of print length in this function. Don't overflow print length
5121 index. Don't assume hash table size fits in 'long', or that
5122 vectorlike size fits in 'unsigned long'.
5123
31c286f7
PE
5124 * process.c (make_process): Use printmax_t, not int, to format
5125 process-name gensyms.
5126
55e5faa1
PE
5127 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5128
80f2e268
PE
5129 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5130 to avoid potential buffer overrun.
5131
670741ab
PE
5132 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5133 if X resource line is longer than 512 bytes.
5134
b7163a50
PE
5135 * xfns.c (x_window): Make sprintf buffer a bit bigger
5136 to avoid potential buffer overrun.
5137
ae58ff1f
PE
5138 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5139
c43c8a6a
PE
5140 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5141
3f8236f4
PE
51422011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5143
53e9fe90 5144 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5145 Without these, Emacs silently mishandles large integers sometimes.
5146 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5147 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5148
6511acf2
PE
5149 * xdisp.c (try_window_id): Check Emacs fixnum range before
5150 converting to 'int'.
806add1d 5151
6511acf2 5152 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5153 Check that an Emacs fixnum is in range before assigning it to 'int'.
5154 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5155 values converted from Emacs fixnums.
5156 (Frecenter): Don't wrap around a line count if it is out of 'int'
5157 range; instead, treat it as an extreme value.
5158 (Fset_window_configuration, compare_window_configurations):
5159 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5160
6511acf2
PE
5161 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5162 that can exceed INT_MAX. Check that EMACS_INT value is in range
5163 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5164 (match_limit): Don't assume that a fixnum can fit in 'int'.
5165
6511acf2 5166 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5167 exceed INT_MAX.
5168
6511acf2 5169 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5170 (Fvertical_motion): Don't wrap around LINES values that don't fit
5171 in 'int'. Instead, treat them as extreme values. This is good
5172 enough for windows, which can't have more than INT_MAX lines anyway.
5173
fcb901a7
LMI
51742011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5175
0f2f6b6d
LMI
5176 * Require libxml/parser.h to avoid compilation warning.
5177
fcb901a7
LMI
5178 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5179
5180 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5181 since this reportedly can destroy thread storage.
5182
6e20a0d4
CY
51832011-08-30 Chong Yidong <cyd@stupidchicken.com>
5184
5185 * syntax.c (find_defun_start): Update all cache variables if
5186 exiting early (Bug#9401).
5187
148ae00e
EZ
51882011-08-30 Eli Zaretskii <eliz@gnu.org>
5189
f6cfbd8f
EZ
5190 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5191
148ae00e
EZ
5192 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5193 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5194 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5195
5196 * term.c (tty_append_glyph): New function.
5197 (produce_stretch_glyph): Static function and its prototype deleted.
5198
a66cfb1c
SM
5199 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5200 Add prototypes.
148ae00e 5201
c4a07a4c
PE
52022011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5203
5204 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5205 when checking :margin (Bug#9390).
5206 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5207 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5208 so that the name doesn't mislead. All uses changed.
5209
6bc8cd65
JB
52102011-08-28 Johan Bockgård <bojohan@gnu.org>
5211
5212 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5213 set_tty_hooks.
5214
dca4927e
EZ
52152011-08-27 Eli Zaretskii <eliz@gnu.org>
5216
5217 * xdisp.c (move_it_to): Don't bail out early when reaching
5218 position beyond to_charpos, if we are scanning backwards.
5219 (move_it_vertically_backward): When DY == 0, make sure we get to
5220 the first character in the line after the newline.
5221
f2cad773
PE
52222011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5223
5224 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5225 (ccl_driver): Do not generate an out-of-range pointer.
5226 (Fccl_execute_on_string): Remove unnecessary check for
5227 integer overflow, noted by Stefan Monnier in
5228 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5229 Remove a FIXME that didn't need fixing.
5230 Simplify the newly-introduced buffer reallocation code.
5231
0cae2cdb
JB
52322011-08-27 Juanma Barranquero <lekktu@gmail.com>
5233
5234 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5235
5fc295a4 52362011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5237
70c60eb2 5238 Integer and memory overflow issues (Bug#9196).
726e0ab1 5239
d31850da
PE
5240 * doc.c (get_doc_string): Rework so that
5241 get_doc_string_buffer_size is the actual buffer size, rather than
5242 being 1 less than the actual buffer size; this makes xpalloc more
5243 convenient.
5244
a69fbedb
PE
5245 * image.c (x_allocate_bitmap_record, cache_image):
5246 * xselect.c (Fx_register_dnd_atom):
5247 Simplify previous changes by using xpalloc.
5248
fe5c5d37
PE
5249 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5250 since either will do and ptrdiff_t is convenient with xpalloc.
5251
0065d054
PE
5252 * charset.c (charset_table_size)
5253 (struct charset_sort_data.priority): Now ptrdiff_t.
5254 (charset_compare): Don't overflow if priorities differ greatly.
5255 (Fsort_charsets): Don't assume list length fits in int.
5256 Check for size-calculation overflow when allocating sort data.
5257 (syms_of_charset): Allocate an initial charset table that is
5258 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5259
5260 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5261
5262 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5263 The actual value is always <= INT_MAX, and leaving it unsigned made
5264 overflow checking harder.
5265
5266 * dispextern.h (struct glyph_matrix.rows_allocated)
5267 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5268 with xpalloc. The values are still always <= INT_MAX.
5269
5270 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5271
5272 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5273 (SAFE_NALLOCA): New macro.
5274
5275 * region-cache.c (struct boundary.pos, find_cache_boundary)
5276 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5277 (set_cache_region, invalidate_region_cache)
5278 (revalidate_region_cache, know_region_cache, region_cache_forward)
5279 (region_cache_backward, pp_cache):
5280 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5281 so that ptrdiff_t * can be passed to xpalloc.
5282 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5283 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5284 (pp_cache): Don't assume cache_len fits in int.
5285 * region-cache.h: Adjust extern decls to match.
5286
5287 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5288 EMACS_INT, since either will do, for xpalloc.
5289
5290 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5291 (xnmalloc, xnrealloc, xpalloc): New functions.
5292
726e0ab1
PE
5293 * bidi.c (bidi_shelve_header_size): New constant.
5294 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5295 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5296
51f30bc5 5297 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5298 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5299 (overlay_strings):
5300 Don't update size of array until after memory allocation succeeds,
5301 because xmalloc/xrealloc may not return.
0065d054
PE
5302 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5303 now that we have proper integer overflow checking.
5304 (record_overlay_string, overlay_strings): Catch overflows when
5305 calculating size of overlay_str_buf.
726e0ab1 5306
0065d054
PE
5307 * callproc.c (Fcall_process): Check for size overflow when
5308 calculating size of args2.
5309 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5310 Normally we prefer signed values, but sticking with ptrdiff_t would
5311 require adding more-complicated checks.
726e0ab1
PE
5312
5313 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5314 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5315 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5316 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5317
5318 * character.c (Fstring): Check for size-calculation overflow.
5319
5320 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5321 unnecessary integer overflow. Check for size overflow.
5322 (encode_coding_object): Don't update size until xmalloc succeeds.
5323
5324 * composite.c (get_composition_id): Check for overflow in glyph
5325 length calculations.
5326
5327 Integer and memory overflow fixes for display code.
5328 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5329 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5330 (scrolling_window): Check for overflow in size calculations.
5331 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5332 Don't assume glyph table len fits in int.
5333 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5334 (row_table_size): Now ptrdiff_t, not int.
5335 (scrolling_window): Avoid overflow in size calculations.
5336 Don't update size until allocation succeeds.
5337 * fns.c (concat): Check for overflow in size calculations.
5338 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5339 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5340 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5341
5342 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5343 (get_doc_string): Check for size calculation overflow.
5344 Don't update size until allocation succeeds.
5345 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5346 EMACS_INT, where ptrdiff_t will do.
5347 (Fsubstitute_command_keys): Check for string overflow.
5348
5349 * editfns.c (set_time_zone_rule): Don't assume environment length
5350 fits in int.
5351 (message_length): Now ptrdiff_t, not int.
5352 (Fmessage_box): Don't update size until allocation succeeds.
5353 Don't assume message length fits in int.
5354 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5355
0065d054
PE
5356 * emacs.c (main): Do not reallocate argv, since there is a null at
5357 the end that can be overwritten, and this way there's no need to
5358 worry about size-calculation overflow.
5359 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5360
5361 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5362 alloc succeeds.
5363 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5364
5365 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5366 (x_set_scroll_bar_width, x_figure_window_size):
5367 Check for integer overflow.
5368 (x_set_alpha): Do not assume XINT fits in int.
5369
5370 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5371 This is for the members text_lines, text_cols, total_lines, total_cols,
5372 where the system imposes an 'int' limit.
5373
5374 * fringe.c (Fdefine_fringe_bitmap):
5375 Don't update size until alloc works.
5376
5377 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5378 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5379
5380 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5381 Check for size-calculation overflow.
5382 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5383 do, as we prefer signed integers.
5384 (id_to_widget.max_size, id_to_widget.used)
5385 (xg_store_widget_in_map, xg_remove_widget_from_map)
5386 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5387 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5388 Use and return ptrdiff_t, not int.
5389 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5390 * gtkutil.h: Change prototypes to match the above.
5391
5392 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5393 are duplicate now that they've been promoted to lisp.h.
5394 (x_allocate_bitmap_record, x_alloc_image_color)
5395 (make_image_cache, cache_image, xpm_load):
5396 Don't update size until alloc is done.
5397 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5398 (x_detect_edges):
3256efce 5399 Check for size calculation overflow.
726e0ab1
PE
5400 (ct_colors_allocated_max): New constant.
5401 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5402 overflow.
3256efce 5403
726e0ab1
PE
5404 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5405 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5406 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5407 Use ptrdiff_t, not int, to count maps.
5408 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5409 calculations. Don't update size until allocation succeeds.
5410 Redo calculations to avoid overflow.
726e0ab1
PE
5411 * keyboard.h: Change prototypes to match the above.
5412
5413 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5414 to count maps.
5415 (current_minor_maps): Check for size calculation overflow.
5416 * keymap.h: Change prototypes to match the above.
5417
5418 * lread.c (read1, init_obarray): Don't update size until alloc done.
5419
5420 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5421 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5422
726e0ab1
PE
5423 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5424 Now ptrdiff_t, not int.
5425 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5426 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5427
5428 * process.c (Fnetwork_interface_list): Check for overflow
5429 in size calculation.
5430
5431 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5432
5433 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5434 overflow. Don't bother calling xmalloc when xrealloc will do.
5435
5436 * search.c (Freplace_match): Check for size calculation overflow.
5437 (Fset_match_data): Don't assume list lengths fit in 'int'.
5438
5439 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5440 for command line length. Do not attempt to address one before the
5441 beginning of an array, as that's not portable.
5442
5443 * term.c (max_frame_lines): Remove; unused.
5444 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5445 not int.
5446 (encode_terminal_code, calculate_costs): Check for size
5447 calculation overflow.
5448 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5449 table lengths and related sizes. Don't update size until alloc
5450 done. Redo calculations to avoid overflow.
5451 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5452
5453 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5454 subtracting pointers.
5455 (gobble_line): Check for overflow more carefully. Don't update size
5456 until alloc done.
5457
5458 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5459 Don't update size until alloc done.
5460 Redo size calculations to avoid overflow.
5461 Check for size calculation overflow.
0065d054 5462 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5463
5464 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5465 Use ptrdiff_t, not int, for sizes.
5466 (store_mode_line_noprop_char): Don't update size until alloc done.
5467
0065d054
PE
5468 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5469 Use ptrdiff_t, not int, for sizes.
5470 (Finternal_make_lisp_face, cache_face):
5471 Check for size calculation overflow.
5472 (cache_face): Treat size calculation overflows as if they were
5473 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5474
5475 * xfns.c (x_encode_text, x_set_name_internal)
5476 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5477 sizes, since they can exceed INT_MAX in size. Check for size
5478 calculation overflow.
5479
0065d054
PE
5480 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5481 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5482 Don't update size until alloc done.
5483
0065d054 5484 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5485 as sprintf is limited to int lengths.
1d526e2f 5486
252c5ee1
PE
5487 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5488 (X_LONG_MIN): New macros.
864d7ce7
PE
5489 Use them to make the following changes clearer.
5490 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5491 This change doesn't affect the value now, but it may help remind
5492 future maintainers not to raise the value too much later.
5493 (SELECTION_QUANTUM): Remove, replacing with ...
5494 (selection_quantum): ... new function, which avoids overflow.
5495 All uses changed.
5496 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5497 assumption that selection length fits in 'int'.
5498 (x_reply_selection_request, x_handle_selection_request)
5499 (x_get_window_property, receive_incremental_selection)
5500 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5501 (lisp_data_to_selection_data, clean_local_selection_data):
5502 Use ptrdiff_t, not int, to record length of selection.
5503 (x_reply_selection_request, x_get_window_property)
5504 (receive_incremental_selection, x_property_data_to_lisp):
5505 Redo calculations to avoid overflow.
5506 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5507 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5508 something.
5509 (x_get_window_property, receive_incremental_selection)
5510 (lisp_data_to_selection_data, x_property_data_to_lisp):
5511 Check for size-calculation overflow.
5512 (x_get_window_property, receive_incremental_selection)
5513 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5514 Don't store size until memory allocation succeeds.
5515 (x_get_window_property): Plug memory leak on memory exhaustion.
5516 Don't double-block input; malloc is safe here. Don't assume 2**34
5517 - 4 fits in unsigned long. Add an xassert to check
5518 XGetWindowProperty overflow. Be more careful about overflow
5519 calculations, and distinguish size from memory overflow better.
5520 (receive_incremental_selection): When tracing, don't assume
5521 unsigned int is less than INT_MAX.
5522 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5523 harmful) conversions of unsigned short to int.
5524 (lisp_data_to_selection_data): Don't assume that integers
5525 in the range -65535 through -1 fit in an X unsigned short.
5526 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5527 result parameters unless successful. Rely on cons_to_unsigned
5528 to report problems with elements; the old code wasn't right anyway.
5529 (x_check_property_data): Check for int overflow; we cannot use
5530 a wider type due to X limits.
5531 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5532
726e0ab1 5533 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5534
0065d054
PE
5535 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5536 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5537 (x_color_cells): Don't store size until memory allocation succeeds.
5538 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5539 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5540 (x_term_init): Don't assume length fits in int (sprintf is limited
5541 to int size).
bc18e09d 5542
ebfa62c0
PE
5543 Use ptrdiff_t for composition IDs.
5544 * character.c (lisp_string_width):
5545 * composite.c (composition_table_size, n_compositions)
5546 (get_composition_id, composition_gstring_from_id):
5547 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5548 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5549 * window.c (Frecenter):
5550 Use ptrdiff_t, not int, for composition IDs.
5551 * composite.c (get_composition_id): Check for integer overflow.
5552 * composite.h: Adjust prototypes to match the above changes.
5553
d3411f89
PE
5554 Use ptrdiff_t for hash table indexes.
5555 * category.c (hash_get_category_set):
5556 * ccl.c (ccl_driver):
5557 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5558 * coding.c (coding_system_charset_list, detect_coding_system):
5559 * coding.h (struct coding_system.id):
5560 * composite.c (get_composition_id, gstring_lookup_cache):
5561 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5562 * image.c (xpm_get_color_table_h):
5563 * lisp.h (hash_lookup, hash_put):
5564 * minibuf.c (Ftest_completion):
5565 Use ptrdiff_t for hash table indexes, not int (which is too
5566 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5567 32-bit --with-wide-int hosts).
5568
e097a6fa
PE
5569 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5570 Add a FIXME comment about memory leaks.
5571 (syms_of_charset): Don't assume xmalloc returns.
5572
5637687f
PE
5573 Don't assume that stated character widths fit in int.
5574 * character.c (Fchar_width, c_string_width, lisp_string_width):
5575 * character.h (CHAR_WIDTH):
5576 * indent.c (MULTIBYTE_BYTES_WIDTH):
5577 Use sanitize_char_width to avoid undefined and/or bad behavior
5578 with outlandish widths.
a66cfb1c 5579 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5580 now that we have two such functions. All uses changed.
5581 (sanitize_char_width): New inline function.
5582
a2271ba2
PE
5583 Don't assume that tab-width fits in int.
5584 * character.h (sanitize_width): New inline function.
5585 (SANE_TAB_WIDTH): New macro.
5586 (ASCII_CHAR_WIDTH): Use it.
5587 * indent.c (sane_tab_width): Remove. All uses replaced by
5588 SANE_TAB_WIDTH (current_buffer).
5589 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5590
18c52557
PE
5591 * fileio.c: Integer overflow issues with file modes.
5592 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5593
caeeedc1
PE
5594 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5595 Remove unreachable code.
5596 (read_hex, load_charset_map_from_file): Check for integer overflow.
5597
6df6ae42 5598 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5599 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5600 (x_send_scroll_bar_event): Likewise. Check that the size does not
5601 exceed limits imposed by XClientMessageEvent, as well as the usual
5602 ptrdiff_t and size_t limits.
5603
b13995db
PE
5604 * keyboard.c: Overflow, signedness and related fixes.
5605 (make_lispy_movement): Use same integer type in forward decl
5606 that is used in the definition.
5607 (read_key_sequence, keyremap_step):
5608 Change bufsize argument back to int, undoing my 2011-03-30 change.
5609 We prefer signed types, and int is wide enough here.
5610 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5611 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5612 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5613 length, not size_t. Use ptrdiff_t for index, not int.
5614 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5615 possibility of integer overflow.
5616
13464394
PE
5617 Overflow, signedness and related fixes for images.
5618
5619 * dispextern.h (struct it.stack[0].u.image.image_id)
5620 (struct_it.image_id, struct image.id, struct image_cache.size)
5621 (struct image_cache.used, struct image_cache.ref_count):
5622 * gtkutil.c (update_frame_tool_bar):
5623 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5624 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5625 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5626 * nsmenu.m (update_frame_tool_bar):
5627 * xdisp.c (calc_pixel_width_or_height):
5628 * xfns.c (image_cache_refcount):
5629 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5630 on typical 64-bit hosts.
5631
5632 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5633 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5634 Omit unnecessary casts to int.
5635 (parse_image_spec): Check that integers fall into 'int' range
5636 when the callers expect that.
5637 (image_ascent): Redo ascent calculation to avoid int overflow.
5638 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5639 (lookup_image): Remove unnecessary tests.
5640 (xbm_image_p): Locals are now of int, not EMACS_INT,
5641 since parse_image_check makes sure they fit into int.
5642 (png_load, gif_load, svg_load_image):
5643 Prefer int to unsigned where either will do.
5644 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5645 old tiff_error_handler and tiff_warning_handler.
5646 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5647 stack buffer overflows. It uses only the features of vsnprintf
5648 that are common to both POSIX and native Microsoft.
5649 (tiff_error_handler, tiff_warning_handler): Use it.
5650 (tiff_load, gif_load, imagemagick_load_image):
5651 Don't assume :index value fits in 'int'.
5652 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5653 (imagemagick_load_image): Check that crop parameters fit into
5654 the integer types that MagickCropImage accepts. Don't assume
5655 Vimagemagick_render_type has a nonnegative value. Don't assume
5656 size_t fits in 'long'.
5657 (gs_load): Use printmax_t to print the widest integers possible.
5658 Check for integer overflow when computing image height and width.
5659
c11821d4
EZ
56602011-08-26 Eli Zaretskii <eliz@gnu.org>
5661
5662 * xdisp.c (redisplay_window): Don't force window start if point
5663 will be invisible in the resulting window. (Bug#9324)
5664
0c95fcf7
EZ
56652011-08-25 Eli Zaretskii <eliz@gnu.org>
5666
5667 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5668 the display spec is of the form `(space ...)'.
5669 (handle_display_spec): Return the value returned by
5670 handle_single_display_spec, not just 1 or zero.
5671 (handle_single_display_spec): If the display spec is of the form
5672 `(space ...)', and specifies display in the text area, return 2
5673 rather than 1.
fee65a97 5674 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5675 accurately, and prefer exact match for point under bidi.
5676 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5677
5678 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5679 into disp_prop; all users changed.
5680
5681 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5682 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5683 for the text covered by the display property.
5684
e4ed06f1
CY
56852011-08-25 Chong Yidong <cyd@stupidchicken.com>
5686
5687 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5688 Change return value to nil.
5689 (Frecord_buffer): Delete unused function.
5690
f67cdd7f
EZ
56912011-08-24 Eli Zaretskii <eliz@gnu.org>
5692
5980d4c6
EZ
5693 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5694 buffers, return left-to-right.
8610fe8b
EZ
5695 (set_cursor_from_row): Consider candidate row a win if its glyph
5696 represents a newline and point is on that newline. Fixes cursor
5697 positioning on the newline at EOL of R2L text within L2R
5698 paragraph, and vice versa.
5699 (try_cursor_movement): Check continued rows, in addition to
5700 continuation rows. Fixes unwarranted scroll when point enters a
5701 continued line of R2L text within an L2R paragraph, or vice versa.
5702 (cursor_row_p): Consider the case of point being equal to
5703 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5704 from the end of a short line to the beginning of a continued line
5705 of R2L text within L2R paragraph.
5706 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5707 composed characters.
5980d4c6 5708
f67cdd7f
EZ
5709 * bidi.c (bidi_check_type): Use xassert.
5710 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5711 members.
5712
bca633fb
EZ
57132011-08-23 Eli Zaretskii <eliz@gnu.org>
5714
5715 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5716 a character.
5717
4a5885a7
CY
57182011-08-23 Chong Yidong <cyd@stupidchicken.com>
5719
5720 * nsfont.m (ns_otf_to_script): Fix typo.
5721
0902a04e
KH
57222011-08-22 Kenichi Handa <handa@m17n.org>
5723
5724 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5725 extra slot even if the purpose is char-code-property-table.
5726
1a2e6670
EZ
57272011-08-23 Eli Zaretskii <eliz@gnu.org>
5728
8ddde651
EZ
5729 * xdisp.c (redisplay_window): When computing centering_position,
5730 account for the height of the header line. (Bug#8874)
5731
425cc014
EZ
5732 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5733 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5734 candidate is selected by the mouse, and that candidate has a
5735 composed character under the mouse.
5736
1a2e6670
EZ
5737 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5738 coordinates reported by pos-visible-in-window-p for a composed
5739 character in column zero.
5740
8b76d6f8
SM
57412011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5742
5743 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5744
dac347dd
EZ
57452011-08-22 Eli Zaretskii <eliz@gnu.org>
5746
5747 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5748 consider it a hit if to_charpos is anywhere in the range of the
5749 composed buffer positions.
5750
e013fb34
CY
57512011-08-22 Chong Yidong <cyd@stupidchicken.com>
5752
5753 * image.c (gif_load): Don't assume that each subimage has the same
5754 dimensions as the base image. Handle disposal method that is
5755 "undefined" by the gif spec (Bug#9335).
5756
bd1ba3e8
CY
57572011-08-20 Chong Yidong <cyd@stupidchicken.com>
5758
5759 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5760 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5761
54a1215b
EZ
57622011-08-19 Eli Zaretskii <eliz@gnu.org>
5763
823564e5
EZ
5764 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5765 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5766 from an Org mode buffer to a Speedbar frame.
5767
54a1215b
EZ
5768 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5769 a composition, take its buffer position from IT->cmp_it.charpos.
5770 Fixes cursor positioning at the beginning of a line that begins
5771 with a composed character.
5772
9778ebcc
EZ
57732011-08-18 Eli Zaretskii <eliz@gnu.org>
5774
0be6ee06
EZ
5775 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5776 character bidirectional type, use STRONG_L instead. Fixes crashes
5777 in a buffer produced by `describe-categories'.
5778
9778ebcc
EZ
5779 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5780 members before the level stack, so they would be saved and
5781 restored when copying iterator state. Fixes incorrect reordering
5782 around TABs covered by display properties.
5783
156bffbe
AS
57842011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5785
6b02f655 5786 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5787
72ad093b
CY
57882011-08-17 Chong Yidong <cyd@stupidchicken.com>
5789
5790 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5791 (internal_condition_case_2, internal_condition_case_n):
5792 Remove unnecessary aborts (Bug#9081).
72ad093b 5793
35774242
EZ
57942011-08-17 Eli Zaretskii <eliz@gnu.org>
5795
5796 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5797 has no `load' handler, try opening the file locally. (Bug#9311)
5798
db76dd85
KB
57992011-08-16 Ken Brown <kbrown@cornell.edu>
5800
5801 * gmalloc.c: Expand comment.
5802
b215eee5
EZ
58032011-08-16 Eli Zaretskii <eliz@gnu.org>
5804
5805 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5806 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5807
a4579d33
KB
58082011-08-16 Ken Brown <kbrown@cornell.edu>
5809
5810 Fix memory allocation problems in Cygwin build (Bug#9273).
5811
5812 * unexcw.c ( __malloc_initialized): Declare external variable.
5813 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5814
8b76d6f8
SM
5815 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5816 New variables.
a4579d33
KB
5817 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5818 dumped emacs.
5819 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5820 in the static heap.
5821 [CYGWIN] (special_realloc): New function.
5822 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5823 requests to realloc storage in the static heap.
5824
3ebec551
PE
58252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5826
5827 * bidi.c (bidi_initialize): Remove unused local.
5828
9fd8be00
EZ
58292011-08-15 Eli Zaretskii <eliz@gnu.org>
5830
6b02f655
SM
5831 * bidimirror.h:
5832 * biditype.h: Remove file.
5833 * makefile.w32-in ($(BLD)/bidi.$(O)):
5834 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5835
5836 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5837
5838 * chartab.c: Improve commentary for the uniprop_table API.
5839
32413314
EZ
5840 * bidi.c (bidi_paragraph_init): Support zero value of
5841 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5842 (bidi_initialize): Use uniprop_table instead of including
5843 biditype.h and bidimirror.h.
32413314 5844
9fd8be00
EZ
5845 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5846 coordinates of the iterator when restoring from ppos_it.
5847 (Bug#9296)
5848
5cf2b69b
KH
58492011-08-14 Kenichi Handa <handa@m17n.org>
5850
5851 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5852 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5853
daf17d00
EZ
58542011-08-14 Eli Zaretskii <eliz@gnu.org>
5855
5856 * xdisp.c (move_it_in_display_line_to): Don't invoke
5857 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5858 ppos_it. Fixes vertical cursor motion when line beginning is
5859 covered by an image. (Bug#9296)
5860
08e3161a
JD
58612011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5862
5863 * nsterm.h (ns_run_ascript): Declare.
5864 (NSAPP_DATA2_RUNASSCRIPT): Define.
5865
5866 * nsfns.m (as_script, as_result, as_status): New static variables.
5867 (ns_run_ascript): New function.
5e617bc2 5868 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5869 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5870 the event loop. Get status from as_status (Bug#7276).
5871
5872 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5873 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5874 the event loop (Bug#7276).
5875
a3720aa2
AS
58762011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5877
5878 * gnutls.c (QCgnutls_bootprop_priority)
5879 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5880 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5881 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5882 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5883 (QCgnutls_bootprop_verify_hostname_error)
5884 (QCgnutls_bootprop_callbacks_verify): Rename from
5885 Qgnutls_bootprop_..., all uses changed.
5886
5887 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5888 uses changed.
5889
0a0d27fb
PE
58902011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5891
19d5c50c
PE
5892 * xfaces.c (Qframe_set_background_mode): Now static.
5893 * dispextern.h (Qframe_set_background_mode): Remove decl.
5894
0a0d27fb
PE
5895 * process.c (Fnetwork_interface_info): Declare local only if needed.
5896
377538cb
JD
58972011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5898
5899 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5900 (Fnetwork_interface_list): Allocate in increments of bytes instead
5901 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5902 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5903 sockaddr.
5904 (struct ifflag_def): notrailers is smart on OSX.
5905 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5906 Get hardware address with getifaddrs if available.
5907
08fff70c
EZ
59082011-08-12 Eli Zaretskii <eliz@gnu.org>
5909
5910 * xdisp.c (iterate_out_of_display_property): xassert that
5911 IT->position is set to within IT->object's boundaries. Break from
5912 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5913 when IT->position is set up wrongly due to some bug.
5914 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5915 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5916 entry. Force push_it to save on the stack the current
5917 buffer/string position, to be restored by pop_it. Fix flags in
5918 the iterator structure wrt the object coming from a display
5919 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5920 properties. (Bug#9284)
5921
7be1c708 59222011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5923
7be1c708
CY
5924 * fontset.c (fontset_get_font_group): Add proper type checks.
5925 (Bug#9172)
aac0c6e3 5926
7be1c708 59272011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5928
7be1c708
CY
5929 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5930 and LC_VERSION_MIN_MACOSX.
5931 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5932 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5933
97bb72a6
EZ
59342011-08-08 Eli Zaretskii <eliz@gnu.org>
5935
5936 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5937 no-display-properties-and-no-overlays under bidi display.
5938 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5939 properties and overlays.
97bb72a6 5940
d5617611
CY
59412011-08-08 Chong Yidong <cyd@stupidchicken.com>
5942
37e11a63
CY
5943 * editfns.c (Fset_time_zone_rule): Document relationship with the
5944 setenv function.
5945
d5617611
CY
5946 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5947 the font entity extracted from the cache (Bug#8109).
5948
58872834
CY
59492011-08-07 Chong Yidong <cyd@stupidchicken.com>
5950
5951 * composite.c (autocmp_chars): Don't reset point. That is done by
5952 restore_point_unwind (Bug#5984).
5953
75bfc667
JL
59542011-08-07 Juri Linkov <juri@jurta.org>
5955
5956 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5957 to show the arg `TIME' instead of `TIMEVAL'.
5958
d1410150
EZ
59592011-08-06 Eli Zaretskii <eliz@gnu.org>
5960
5961 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5962 display property strides EOL and includes a newline, as in
5963 longlines-mode. (Bug#9254)
75b771e4
EZ
5964 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5965 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5966
5967 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5968 is non-zero, even if the data buffer is NULL. Fixes a crash in
5969 vertical-motion with longlines-mode. (Bug#9254)
5970
35928349
EZ
59712011-08-05 Eli Zaretskii <eliz@gnu.org>
5972
ec7cc85b
EZ
5973 * bidi.c <bidi_cache_total_alloc>: Now static.
5974 (bidi_initialize): Initialize bidi_cache_total_alloc.
5975
8b76d6f8 5976 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5977 cache. (Bug#9221)
5978
5979 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5980 amount allocated this far in `bidi_cache_total_alloc'.
5981 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5982 non-zero, only free the data buffer without restoring the cache
5983 contents. All callers changed.
5984
5985 * dispextern.h (bidi_unshelve_cache): Update prototype.
5986
5987 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5988 (move_it_in_display_line, move_it_to)
5989 (move_it_vertically_backward, move_it_by_lines): Replace the call
5990 to xfree to an equivalent call to bidi_unshelve_cache.
5991 (move_it_in_display_line_to): Fix logic of returning
412b6358 5992 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5993
e2e2423b
EZ
59942011-08-05 Eli Zaretskii <eliz@gnu.org>
5995
5996 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5997 came from a string character with a `cursor' property. (Bug#9229)
5998
ae9e757a
JD
59992011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6000
6001 * Makefile.in (LIB_PTHREAD): New variable.
6002 (LIBES): Add LIB_PTHREAD (Bug#9216).
6003
6004 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6005 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6006
213bd7f2
AS
60072011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6008
6b02f655 6009 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6010
99aaf75f
JD
60112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6012
6013 * xterm.c (x_find_topmost_parent): New function.
6014 (x_set_frame_alpha): Find topmost parent window with
6015 x_find_topmost_parent and set the property there also (bug#9181).
6016 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6017
c74e9d86
PE
60182011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6019
6020 * callproc.c (Fcall_process): Avoid vfork clobbering
6021 the local vars buffer, coding_systems, current_dir.
6022
640c8776
SM
60232011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6024
6025 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6026
f26d0e4c
PE
60272011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6028
8a10d76c
PE
6029 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6030 so that it is not optimized away.
6031
f26d0e4c
PE
6032 * xdisp.c (compute_display_string_pos): Remove unused local.
6033
55439c61
EZ
60342011-08-02 Eli Zaretskii <eliz@gnu.org>
6035
6036 Fix slow cursor motion and scrolling in large buffers with
6037 selective display, like Org Mode buffers. (Bug#9218)
6038
6039 * dispextern.h (struct bidi_it): New member disp_prop_p.
6040
6041 * xdisp.c: Remove one-slot cache of display string positions.
6042 (compute_display_string_pos): Accept an additional argument
5e617bc2 6043 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6044 for a display string or property. If found, set DISP_PROP_P
6045 non-zero.
6046
6047 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6048 DISP_PROP_P, and pass it to compute_display_string_pos.
6049 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6050 non-zero. All callers of bidi_fetch_char changed.
6051
fb33fa43
SM
60522011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6053
6054 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6055
b099e063
DM
60562010-12-03 Don March <don@ohspite.net>
6057
6058 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6059 last character M-[char] is translated to ESC [char] (bug#7541).
6060
5cc7f7af
KH
60612011-08-02 Kenichi Handa <handa@m17n.org>
6062
d0fffa3f 6063 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6064
6065 * chartab.c (uniprop_table): Make it non-static.
6066
525d5e6e
EZ
60672011-08-01 Eli Zaretskii <eliz@gnu.org>
6068
6069 * xdisp.c (forward_to_next_line_start): Accept additional argument
6070 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6071 on the newline.
6072 (reseat_at_next_visible_line_start): Use the bidi iterator state
6073 returned by forward_to_next_line_start to restore the state of
6074 it->bidi_it after backing up to previous newline. (Bug#9212)
6075
31011111
AS
60762011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6077
6078 * regex.c (re_comp): Protoize.
6079 (re_exec): Fix return type.
6080 (regexec): Fix type of `ret'. (Bug#9203)
6081
476371c4
PE
60822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6083
e5d76069
PE
6084 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6085 This is needed if max-image-size is a floating-point number.
6086
9a79b20c
AS
60872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6088
6089 * print.c (print_object): Print empty symbol as ##.
6090
6091 * lread.c (read1): Read ## as empty symbol.
6092
d8c2fa78
AA
60932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6094
6095 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6096 setting frame foreground color (Bug#9175).
6097 (x_set_background_color): Likewise.
6098
ffe57a7a
AA
6099 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6100 contents (Bug#9176).
6101 (EmacsTooltip -init): Remove bezels and add shadows to
6102 tooltip windows.
6103
bf3492a5
AA
6104 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6105 or scroll bar (Bug#8470).
6106
d55e9c53
AA
6107 * nsfont.m (nsfont_open): Remove assignment to voffset and
6108 unnecessary vars hshink, expand, hd, full_height, min_height.
6109 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6110
6111 * nsterm.h (nsfont_info): Remove voffset field.
6112
d8c2fa78 61132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6114
6115 Implement strike-through and overline on NextStep (Bug#8863).
6116
6117 * nsfont.m (nsfont_open): Use underline position provided by font,
6118 instead of hard-coded value of 2.
6119 (nsfont_draw): Call ns_draw_text_decoration instead.
6120
6121 * nsterm.h: Add declaration for ns_draw_text_decoration.
6122
6123 * nsterm.m (ns_draw_text_decoration): New function for drawing
6124 underline, overline, and strike-through.
6125 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6126 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6127 accommodate underlining, etc.
4843aac3 6128
4cc60b9b
EZ
61292011-07-28 Eli Zaretskii <eliz@gnu.org>
6130
bc7ece87
EZ
6131 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6132 default.
4cc60b9b 6133
476371c4
PE
61342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6135
66606eea
PE
6136 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6137 Without this fix, if a signal arrives just after memory fills up,
6138 'malloc' might be invoked reentrantly.
6139
476371c4
PE
6140 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6141 In other words, assume that every image size is allowed, on non-X
6142 hosts. This assumption is probably wrong, but it lets Emacs compile.
6143
f3fcc40d
AS
61442011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6145
6146 * regex.c (re_iswctype): Convert return values to boolean.
6147
350c992f
EZ
61482011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6149
6150 * xdisp.c (compute_display_string_pos): Don't use cached display
6151 string position if the buffer had its restriction changed.
6152 (Bug#9184)
6153
5266b4bb
PE
61542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6155
6156 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6157
2573a837 61582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6159
41f55ccd 6160 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6161
39e378da
PE
6162 * bidi.c: Integer size and overflow fixes.
6163 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6164 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6165 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6166 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6167 (bidi_find_other_level_edge):
6168 Use ptrdiff_t instead of EMACS_INT where either will do.
6169 This works better on 32-bit hosts configured --with-wide-int.
6170 (bidi_cache_ensure_space): Check for size-calculation overflow.
6171 Use % rather than repeated addition, for better worst-case speed.
6172 Don't set bidi_cache_size until after xrealloc returns, because it
6173 might not return.
6174 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6175 (bidi_cache_ensure_space): Also check that the bidi cache size
6176 does not exceed that of the largest Lisp string or buffer. See Eli
6177 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6178
5e927815
PE
6179 * alloc.c (__malloc_size_t): Remove.
6180 All uses replaced by size_t. See Andreas Schwab's note
6181 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6182
ca4aa935
PE
6183 * image.c: Improve checking for integer overflow.
6184 (check_image_size): Assume that f is nonnull, since
6185 it is always nonnull in practice. This is one less thing to
6186 worry about when checking for integer overflow later.
6187 (x_check_image_size): New function, which checks for integer
6188 overflow issues inside X.
6189 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6190 This removes the need for a memory_full check.
6191 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6192 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6193 (xbm_read_bitmap_data): Change locals back to 'int', since
6194 their values must fit in 'int'.
6195 (xpm_load_image, png_load, tiff_load):
6196 Invoke x_create_x_image_and_pixmap earlier,
6197 to avoid much needless work if the image is too large.
6198 (tiff_load): Treat overly large images as if
6199 x_create_x_image_and_pixmap failed, not as malloc failures.
6200 (gs_load): Use x_check_image_size.
6201
5f8f9cc2
PE
6202 * gtkutil.c: Omit integer casts.
6203 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6204 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6205
5adf60bc
PE
6206 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6207
c8907a93
PE
6208 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6209 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6210 would wrongly return t on a 64-bit host.
6211
e3c25c68
PE
6212 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6213 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6214 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6215 and therefore cause GCC to emit a bogus diagnostic in some cases.
6216
3f791afe
PE
6217 * image.c: Integer signedness and overflow and related fixes.
6218 This is not an exhaustive set of fixes, but it's time to
6219 record what I've got.
6220 (lookup_pixel_color, check_image_size): Remove redundant decls.
6221 (check_image_size): Don't assume that arbitrary EMACS_INT values
6222 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6223 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6224 (tiff_load, imagemagick_load_image):
6225 Check for overflow in size calculations.
6226 (x_create_x_image_and_pixmap): Remove unnecessary test for
6227 xmalloc returning NULL; that can't happen.
6228 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6229 (xpm_color_bucket): Use better integer hashing function.
6230 (xpm_cache_color): Don't possibly over-allocate memory.
6231 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6232 (gif_memory_source):
6233 Use ptrdiff_t, not int or size_t, to record sizes.
6234 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6235 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6236 either works, as we prefer signed integers.
6237 (tiff_read_from_memory, tiff_write_from_memory):
6238 Return tsize_t, not size_t, since that's what the TIFF API wants.
6239 (tiff_read_from_memory): Don't fail simply because the read would
6240 go past EOF; instead, return a short read.
6241 (tiff_load): Omit no-longer-needed casts.
6242 (Fimagemagick_types): Don't assume size fits into 'int'.
6243
3cc5a532
PE
6244 Improve hashing quality when configured --with-wide-int.
6245 * fns.c (hash_string): New function, taken from sxhash_string.
6246 Do not discard information about ASCII character case; this
6247 discarding is no longer needed.
6248 (sxhash-string): Use it. Change sig to match it. Caller changed.
6249 * lisp.h: Declare it.
6250 * lread.c (hash_string): Remove, since we now use fns.c's version.
6251 The fns.c version returns a wider integer if --with-wide-int is
6252 specified, so this should help the quality of the hashing a bit.
6253
b312a492
PE
6254 * emacs.c: Integer overflow minor fix.
6255 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6256 Define only if GNU_LINUX.
6257 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6258
dfd153ae
PE
6259 * dispnew.c: Integer signedness and overflow fixes.
6260 Remove unnecessary forward decls, that were a maintenance hassle.
6261 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6262 All uses changed.
6263 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6264 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6265 (prepare_desired_row, line_draw_cost):
6266 Use int, not unsigned, where either works.
6267 (save_current_matrix, restore_current_matrix):
6268 Use ptrdiff_t, not size_t, where either works.
6269 (init_display): Check for overflow more accurately, and without
6270 relying on undefined behavior.
6271
a81d11a3
PE
6272 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6273 Remove, replacing with the new symbols in lisp.h. All uses changed.
6274 * fileio.c (make_temp_name):
6275 * filelock.c (lock_file_1, lock_file):
6276 * xdisp.c (message_dolog):
6277 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6278 Use pMd etc. instead.
6279 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6280 replacing the pWIDE etc. symbols removed from editfns.c.
6281
3300e6fd
PE
6282 * keyboard.h (num_input_events): Now uintmax_t.
6283 This is (very slightly) less likely to mess up due to wraparound.
6284 All uses changed.
6285
fd05c7e9
PE
6286 * buffer.c: Integer signedness fixes.
6287 (alloc_buffer_text, enlarge_buffer_text):
6288 Use ptrdiff_t rather than size_t when either will do, as we prefer
6289 signed integers.
6290
903fe15d
PE
6291 * alloc.c: Integer signedness and overflow fixes.
6292 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6293 (__malloc_size_t): Default to size_t, not to int.
6294 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6295 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6296 Prefer ptrdiff_t to size_t when either would do, as we prefer
6297 signed integers.
6298 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6299 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6300 Now const. Initialize with values that are in range even if char
6301 is signed.
6302 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6303 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6304 These functions do the right thing with sizes > 2**32.
6305 (check_depth): Now ptrdiff_t, not int.
6306 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6307 Adjust to new way of storing sizes. Check for size overflow bugs
6308 in rest of code.
6309 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6310 slightly wrong anyway, as it missed one instance of
6311 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6312 (refill_memory_reserve): Omit needless cast to size_t.
6313 (mark_object_loop_halt): Mark as externally visible.
6314
ac82cc6a
PE
6315 * xselect.c: Integer signedness and overflow fixes.
6316 (Fx_register_dnd_atom, x_handle_dnd_message):
6317 Use ptrdiff_t, not size_t, since we prefer signed.
6318 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6319 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6320 x_dnd_atoms_size and x_dnd_atoms_length.
6321
c2d1e36d
PE
6322 * doprnt.c: Prefer signed to unsigned when either works.
6323 * eval.c (verror):
6324 * doprnt.c (doprnt):
6325 * lisp.h (doprnt):
6326 * xdisp.c (vmessage):
6327 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6328 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6329 prefer signed arithmetic to avoid comparison confusion.
6330 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6331 but is a bit tricky.
6332
0e926e56
PE
6333 Assume freestanding C89 headers, string.h, stdlib.h.
6334 * data.c, doprnt.c, floatfns.c, print.c:
6335 Include float.h unconditionally.
6336 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6337 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6338 * regex.c: Likewise for stddef.h, string.h.
6339 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6340 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6341 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6342 (STDC_HEADERS): Remove obsolete defines.
6343 * sysdep.c: Include limits.h unconditionally.
6344
9cfdb3ec
PE
6345 Assume support for memcmp, memcpy, memmove, memset.
6346 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6347 * regex.c (memcmp, memcpy):
6348 Remove; we assume C89 now.
6349
6350 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6351 (__malloc_safe_bcopy): Remove; no longer needed.
6352
cf950e6b 6353 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6354 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6355 well either way, and we prefer signed to unsigned.
6356
dbf38e02
LMI
63572011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6358
6359 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6360 closes the connection while we're reading (bug#9182).
6361
d6f0886c 63622011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6363
d6f0886c
JD
6364 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6365 are specified (Bug#9168).
24e0f6b1 6366
2eb1f9e6
PE
63672011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6368
6369 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6370 Found by GCC static checking and --with-wide-int on a 32-bit host.
6371
22381272 63722011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6373
6374 * xdisp.c (compute_display_string_pos): Fix logic of caching
6375 previous display string position. Initialize cached_prev_pos to
6376 -1. Fixes slow-down at the beginning of a buffer.
6377
f25e39b4
EZ
63782011-07-24 Eli Zaretskii <eliz@gnu.org>
6379
6380 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6381 for attrs[LFACE_FONTSET_INDEX].
6382
04c4b52e
PE
63832011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6384
6385 * xml.c (parse_region): Remove unused local
6386 that was recently introduced.
6387
c1734fbd
EZ
63882011-07-23 Eli Zaretskii <eliz@gnu.org>
6389
be18c5a5
EZ
6390 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6391 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6392
c1734fbd
EZ
6393 * xdisp.c (move_it_in_display_line_to): Record the best matching
6394 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6395 exit if none of the characters scanned was an exact match.
6396 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6397 when exact match is impossible due to invisible text, and the
6398 lines are truncated.
6399
a258d627
JD
64002011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6401
6402 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6403 for OSX >= 10.7.
6404
b6d5a689
EZ
64052011-07-22 Eli Zaretskii <eliz@gnu.org>
6406
0f74f785
EZ
6407 Fix a significant slow-down of cursor motion with C-n, C-p,
6408 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6409 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6410 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6411 (next_element_from_buffer): Call compute_stop_pos_backwards to
6412 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6413 base_level_stop.
6414 (reseat): Don't look for prev_stop, as that could mean a very long
6415 run.
6416 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6417 <cached_disp_overlay_modiff>: Cache for last found display string
6418 position.
551918c1 6419 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6420 about the same buffer in the same area of character positions, and
6421 the buffer wasn't changed since the time the display string
6422 position was cached.
551918c1 6423
b2d0c91a
EZ
64242011-07-22 Eli Zaretskii <eliz@gnu.org>
6425
6426 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6427 is an integer, which is important for empty lines. (Bug#9149)
6428
043604ee
CY
64292011-07-22 Chong Yidong <cyd@stupidchicken.com>
6430
6431 * frame.c (Fmodify_frame_parameters): In tty case, update the
6432 default face if necessary (Bug#4238).
6433
da4adb04
CY
64342011-07-21 Chong Yidong <cyd@stupidchicken.com>
6435
6436 * editfns.c (Fstring_to_char): No need to explain what a character
6437 is in the docstring (Bug#6576).
6438
9abd0532
LMI
64392011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6440
6441 * xml.c (parse_region): Make sure we always return a tree.
6442
36881d16
HK
64432011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6444
6445 * xml.c (parse_region): If a document contains only comments,
6446 return that, too.
6447
1e98674d
LMI
64482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6449
6450 * xml.c (make_dom): Return comments, too.
6451
590bd467
PE
64522011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6453
6454 Port to OpenBSD.
6455 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6456 and the surrounding thread.
6457 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6458 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6459 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6460 timer goes off.
6461 * s/openbsd.h (BROKEN_SIGIO): Define.
6462 * unexelf.c (unexec) [__OpenBSD__]:
6463 Don't update the .mdebug section of the Alpha COFF symbol table.
6464
f41628b2
LMI
64652011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6466
6467 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6468 (bug#8460).
6469
b59b67c5
PE
64702011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6471
15e3a074
PE
6472 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6473 This fixes some race conditions on the permissions of any newly
6474 created file.
6475
41bed37d
PE
6476 * alloc.c (valid_pointer_p): Use pipe, not open.
6477 This fixes some permissions issues when debugging.
6478
b59b67c5
PE
6479 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6480 If fchown fails to set both uid and gid, try to set just gid,
6481 as that is sometimes allowed. Adjust the file's mode to eliminate
6482 setuid or setgid bits that are inappropriate if fchown fails.
6483
925a6be7
SM
64842011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6485
6486 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6487 to compare Lisp_Objects.
6488 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6489 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6490 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6491
52968808
AS
64922011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6493
0a6a104b
AS
6494 * lread.c (read_integer): Unread even EOF character.
6495 (read1): Likewise. Properly record start position of symbol.
6496
52968808
AS
6497 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6498 symbol character follows.
6499
9e381cdd
PE
65002011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6501
6502 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6503 This works around a problem with the previous change to Fcopy_file.
6504 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6505 and without this change, GCC might complain about discarding
6506 fchown's return value.
6507
b5641435
JB
65082011-07-16 Juanma Barranquero <lekktu@gmail.com>
6509
6510 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6511
a8031457
PE
65122011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6513
6514 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6515
dd889327
LMI
65162011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6517
750c33f7
LMI
6518 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6519 it's used from the C level.
6520
dd889327
LMI
6521 * process.c: Use the same condition for POLL_FOR_INPUT in both
6522 keyboard.c and process.c (bug#1858).
6523
87e86684
LM
65242011-07-09 Lawrence Mitchell <wence@gmx.li>
6525
6526 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6527 (Fgnutls_boot): Use it.
6528
64348f40
AS
65292011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6530
6531 * doc.c (Fsubstitute_command_keys): Revert last change.
6532
1d698799
LMI
65332011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6534
f863868c
LMI
6535 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6536 quotes the next character, and doesn't affect other longer
6537 sequences (bug#8935).
6538
1d698799
LMI
6539 * lread.c (syms_of_lread): Clarify that is isn't only
6540 `eval-buffer' and `eval-defun' that's affected by
6541 `lexical-binding' (bug#8460).
6542
aa4b6df6
EZ
65432011-07-15 Eli Zaretskii <eliz@gnu.org>
6544
6545 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6546 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6547
5d856da6
PE
65482011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6549
ad6042bb
PE
6550 Fix minor problems found by static checking.
6551 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6552 (elsz): Now a signed constant, not a size_t var. We prefer signed
6553 types to unsigned, to avoid integer comparison confusion. Without
6554 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6555 "cannot optimize loop, the loop counter may overflow", a symptom
6556 of the confusion.
f00bbb22 6557 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6558 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6559
6468f31c
LMI
65602011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6561
49080b10
LMI
6562 * search.c (Fre_search_backward): Mention `case-fold-search' in
6563 all the re_search_* functions (bug#8138).
6564
6468f31c
LMI
6565 * keyboard.c (Fopen_dribble_file): Document when the file is
6566 closed (bug#8056).
6567
c965adc5
EZ
65682011-07-14 Eli Zaretskii <eliz@gnu.org>
6569
df9733bf
EZ
6570 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6571 bidi_cache_idx.
6572
0bb23927
EZ
6573 Support bidi reordering of display and overlay strings.
6574 * xdisp.c (compute_display_string_pos)
6575 (compute_display_string_end): Accept additional argument STRING.
6576 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6577 (reseat_to_string): Initialize bidi_it->string.s and
6578 bidi_it->string.schars.
6579 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6580 NULL (avoids a crash in bidi_paragraph_init).
6581 Initialize itb.string.lstring.
0bb23927
EZ
6582 (init_iterator): Call bidi_init_it only of a valid
6583 buffer position was specified. Initialize paragraph_embedding to
6584 L2R.
6585 (reseat_to_string): Initialize the bidi iterator.
6586 (display_string): If we need to ignore text properties of
6587 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6588 original value of -1 will not work with bidi.)
6589 (compute_display_string_pos): First arg is now struct
6590 `text_pos *'; all callers changed. Support display properties on
6591 Lisp strings.
6592 (compute_display_string_end): Support display properties on Lisp
6593 strings.
6594 (init_iterator, reseat_1, reseat_to_string): Initialize the
6595 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6596 when iterating on a string not from display properties).
640c8776
SM
6597 (compute_display_string_pos, compute_display_string_end):
6598 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6599 arrow keys.
6600 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6601 base_level_stop; instead, set base_level_stop to BEGV.
6602 Fixes crashes in vertical-motion.
0bb23927
EZ
6603 (next_element_from_buffer): Improve commentary for when
6604 the iterator is before prev_stop.
6605 (init_iterator): Initialize bidi_p from the default value of
6606 bidi-display-reordering, not from buffer-local value. Use the
6607 buffer-local value only if initializing for buffer iteration.
6608 (handle_invisible_prop): Support invisible properties on strings
6609 that are being bidi-reordered.
6610 (set_iterator_to_next): Support bidi reordering of C strings and
6611 Lisp strings.
6612 (next_element_from_string): Support bidi reordering of Lisp
6613 strings.
6614 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6615 (display_string): Support display of R2L glyph rows.
6616 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6617 (init_iterator): Don't initialize it->bidi_p for strings
6618 here.
6619 (reseat_to_string): Initialize it->bidi_p for strings here.
6620 (next_element_from_string, next_element_from_c_string)
6621 (next_element_from_buffer): Add xassert's for correspondence
6622 between IT's object being iterated and it->bidi_it.string
6623 structure.
6624 (face_before_or_after_it_pos): Support bidi iteration.
6625 (next_element_from_c_string): Handle the case of the first string
6626 character that is not the first one in the visual order.
6627 (get_visually_first_element): New function, refactored from common
6628 parts of next_element_from_buffer, next_element_from_string, and
6629 next_element_from_c_string.
6630 (tool_bar_lines_needed, redisplay_tool_bar)
6631 (display_menu_bar): Force left-to-right direction. Add a FIXME
6632 comment for making that be controlled by a user option.
6633 (push_it, pop_it): Save and restore the state of the
6634 bidi iterator. Save and restore the bidi_p flag.
6635 (pop_it): Iterate out of display property for string iteration as
6636 well.
6637 (iterate_out_of_display_property): Support iteration over strings.
6638 (handle_single_display_spec): Set up it->bidi_it for iteration
6639 over a display string, and call bidi_init_it.
6640 (handle_single_display_spec, next_overlay_string)
6641 (get_overlay_strings_1, push_display_prop): Set up the bidi
6642 iterator for displaying display or overlay strings.
6643 (forward_to_next_line_start): Don't use the shortcut if
6644 bidi-iterating.
6645 (back_to_previous_visible_line_start): If handle_display_prop
6646 pushed the iterator stack, restore the internal state of the bidi
6647 iterator by calling bidi_pop_it same number of times.
6648 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6649 and we are bidi-iterating, don't decrement the iterator position;
6650 instead, set the first_elt flag in the bidi iterator, to produce
6651 the same effect.
6652 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6653 (push_display_prop): xassert that we are iterating a buffer.
6654 (push_it, pop_it): Save and restore paragraph_embedding member.
6655 (handle_single_display_spec, next_overlay_string)
6656 (get_overlay_strings_1, reseat_1, reseat_to_string)
6657 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6658 correctly. Don't assume unibyte strings are not bidi-reordered.
6659 (compute_display_string_pos)
6660 (compute_display_string_end): Fix handling the case of C string.
6661 (push_it, pop_it): Save and restore from_disp_prop_p.
6662 (handle_single_display_spec, push_display_prop): Set the
6663 from_disp_prop_p flag.
6664 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6665 (pop_it): Call iterate_out_of_display_property only if we are
6666 popping after iteration over a string that came from a display
6667 property. Fix a typo in popping stretch info. Add an assertion
6668 for verifying that the iterator position is in sync with the bidi
6669 iterator.
6670 (handle_single_display_spec, get_overlay_strings_1)
6671 (push_display_prop): Fix initialization of paragraph direction for
6672 string when that of the parent object is not yet determined.
6673 (reseat_1): Call bidi_init_it to resync the bidi
6674 iterator with IT's position. (Bug#7616)
6675 (find_row_edges): If ROW->start.pos gives position
6676 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6677 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6678 Reset the from_disp_prop_p flag.
6679 (SAVE_IT, RESTORE_IT): New macros.
6680 (pos_visible_p, face_before_or_after_it_pos)
6681 (back_to_previous_visible_line_start)
6682 (move_it_in_display_line_to, move_it_in_display_line)
6683 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6684 (try_scrolling, redisplay_window, display_line): Use them when
6685 saving a temporary copy of the iterator and restoring it back.
6686 (back_to_previous_visible_line_start, reseat_1)
6687 (init_iterator): Empty the bidi cache "stack".
6688 (move_it_in_display_line_to): If iterator ended up at
6689 EOL, but we never saw any buffer positions smaller than
6690 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6691 motion in bidi-reordered lines.
6692 (move_it_in_display_line_to): Record prev_method and prev_pos
6693 immediately before the call to set_iterator_to_next. Fixes cursor
6694 motion in bidi-reordered lines with stretch glyphs and strings
6695 displayed in margins. (Bug#8133) (Bug#8867)
6696 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6697 TO_CHARPOS.
640c8776
SM
6698 (pos_visible_p): Support positions in bidi-reordered lines.
6699 Save and restore bidi cache.
0bb23927
EZ
6700
6701 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6702 (bidi_paragraph_info): Delete unused struct.
6703 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6704 (bidi_cache_start): New variable.
6705 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6706 to zero.
6707 (bidi_cache_fetch_state, bidi_cache_search)
6708 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6709 (bidi_cache_find, bidi_peek_at_next_level)
6710 (bidi_level_of_next_char, bidi_find_other_level_edge)
6711 (bidi_move_to_visually_next): Compare cache index with
6712 bidi_cache_start rather than with zero.
6713 (bidi_fetch_char): Accept new argument STRING; all callers
6714 changed. Support iteration over a string. Support strings with
6715 display properties. Support unibyte strings. Fix the type of
6716 `len' according to what STRING_CHAR_AND_LENGTH expects.
6717 (bidi_paragraph_init, bidi_resolve_explicit_1)
6718 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6719 (bidi_level_of_next_char, bidi_move_to_visually_next):
6720 Support iteration over a string.
0bb23927
EZ
6721 (bidi_set_sor_type, bidi_resolve_explicit_1)
6722 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6723 can now be zero (for strings); special values 0 and -1 were
6724 changed to -1 and -2, respectively.
6725 (bidi_char_at_pos): New function.
6726 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6727 Call it instead of FETCH_MULTIBYTE_CHAR.
6728 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6729 initialized to valid values.
6730 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6731 values.
6732 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6733 the test for valid cached positions. Fix the logic for looking up
6734 the sentinel state in the cache. GCPRO the Lisp string we are
6735 iterating.
6736 (bidi_push_it, bidi_pop_it): New functions.
6737 (bidi_initialize): Initialize the bidi cache start stack pointer.
6738 (bidi_cache_ensure_space): New function, refactored from part of
6739 bidi_cache_iterator_state. Don't assume the required size is just
6740 one BIDI_CACHE_CHUNK away.
6741 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6742 (bidi_count_bytes, bidi_char_at_pos): New functions.
6743 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6744 always valid if bidi_cache_idx is valid.
6745 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6746 is valid if it's going to be used.
6747 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6748 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6749 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6750 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6751 (bidi_find_other_level_edge, bidi_cache_start_stack):
6752 All variables related to cache indices are now EMACS_INT.
c965adc5 6753
0bb23927
EZ
6754 * dispextern.h (struct bidi_string_data): New structure.
6755 (struct bidi_it): New member `string'. Make flag members be 1-bit
6756 fields, and put them last in the struct.
640c8776
SM
6757 (compute_display_string_pos, compute_display_string_end):
6758 Update prototypes.
0bb23927
EZ
6759 (bidi_push_it, bidi_pop_it): Add prototypes.
6760 (struct iterator_stack_entry): New members bidi_p,
6761 paragraph_embedding, and from_disp_prop_p.
6762 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6763 (bidi_shelve_cache, bidi_unshelve_cache):
6764 Declare prototypes.
0bb23927
EZ
6765
6766 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6767 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6768 and vector-like objects.
6769
6770 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6771 cache around display iteration.
6772
6773 * window.c (Fwindow_end, window_scroll_pixel_based)
6774 (displayed_window_lines, Frecenter): Save and restore the bidi
6775 cache around display iteration.
6776
3bbd2265
LMI
67772011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6778
6779 * editfns.c (Fdelete_region): Clarify the use of the named
6780 parameters (bug#6788).
6781
adc47434
MR
67822011-07-14 Martin Rudalics <rudalics@gmx.at>
6783
6784 * indent.c (Fvertical_motion): Set and restore w->pointm when
6785 saving and restoring the window's buffer (Bug#9006).
6786
837c31f8
LMI
67872011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6788
6789 * editfns.c (Fstring_to_char): Clarify just what is returned
6790 (bug#6576). Text by Eli Zaretskii.
6791
ac389d0c
JB
67922011-07-13 Juanma Barranquero <lekktu@gmail.com>
6793
6794 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6795
0be0ce47
EZ
67962011-07-13 Eli Zaretskii <eliz@gnu.org>
6797
6798 * buffer.c (mmap_find): Fix a typo.
6799
cd18e7e3
JB
68002011-07-13 Johan Bockgård <bojohan@gnu.org>
6801
6802 Fix execution of x selection hooks.
6803 * xselect.c (Qx_lost_selection_functions)
6804 (Qx_sent_selection_functions): New vars.
6805 (syms_of_xselect): DEFSYM them.
6806 (x_handle_selection_request): Pass Qx_sent_selection_functions
6807 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6808 (x_handle_selection_clear,x_clear_frame_selections):
6809 Pass Qx_lost_selection_functions rather than
6810 Vx_lost_selection_functions to Frun_hook_with_args.
6811
47ea7f44
PE
68122011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6813
ac389d0c 6814 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6815 The old code sometimes used this field without initializing it.
6816
47ea7f44
PE
6817 * alloc.c (gc_sweep): Don't read past end of array.
6818 In theory, the old code could also have corrupted Emacs internals,
6819 though it'd be very unlikely.
6820
bc985c87
AS
68212011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6822
6823 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6824 argument. (Bug#4026)
bc985c87 6825
0cf34688
LMI
68262011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6827
b3dadd76
LMI
6828 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6829 key" (bug#4257).
6830
0cf34688
LMI
6831 * window.c (Fset_window_start): Doc fix (bug#4199).
6832 (Fset_window_hscroll): Ditto.
6833
270768cd
PE
68342011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6835
077e3dda 6836 Fix minor new problems caught by GCC 4.6.1.
270768cd 6837 * term.c (init_tty): Remove unused local.
490011a6 6838 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6839 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6840 not used otherwise.
270768cd 6841
b1f58454
CY
68422011-07-12 Chong Yidong <cyd@stupidchicken.com>
6843
6844 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6845
22b9578d
LMI
68462011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6847
6e70ab07
LMI
6848 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6849 are the mini-buffer and the echo area (bug#3320).
6850
22b9578d
LMI
6851 * term.c (init_tty): Remove support for supdup, c10 and perq
6852 terminals, which are no longer supported (bug#1482).
6853
8974cc9f
JB
68542011-07-10 Johan Bockgård <bojohan@gnu.org>
6855
6856 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6857
a560d974
JD
68582011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6859
6860 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6861 for non-popups (Bug#3642).
6862
1dae0f0a
AS
68632011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6864
268c2c36 6865 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6866 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6867 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6868 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6869 * data.c (fmod): Likewise.
6870 * dispnew.c (swap_glyphs_in_rows): Likewise.
6871 * emacs.c (memory_warning_signal): Likewise.
6872 * floatfns.c (float_error): Likewise.
6873 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6874 (otf_open, font_otf_capability, generate_otf_features)
6875 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6876 Likewise.
6877 * image.c (pbm_read_file): Likewise.
6878 * indent.c (string_display_width): Likewise.
6879 * intervals.c (check_for_interval, search_for_interval)
6880 (inc_interval_count, count_intervals, root_interval)
6881 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6882 * lread.c (defalias): Likewise.
268c2c36 6883 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6884 * regex.c (set_image_of_range_1, set_image_of_range)
6885 (regex_grow_registers): Likewise.
6886 * sysdep.c (strerror): Likewise.
6887 * termcap.c (valid_filename_p, tprint, main): Likewise.
6888 * tparam.c (main): Likewise.
6889 * unexhp9k800.c (run_time_remap, save_data_space)
6890 (update_file_ptrs, read_header, write_header, calculate_checksum)
6891 (copy_file, copy_rest, display_header): Likewise.
6892 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6893 Likewise.
6894 * xdisp.c (check_it): Likewise.
6895 * xfaces.c (register_color, unregister_color, unregister_colors):
6896 Likewise.
6897 * xfns.c (print_fontset_result): Likewise.
6898 * xrdb.c (member, fatal, main): Likewise.
6899
99033785
PE
69002011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6901
6902 Fix minor problems found by static checking (Bug#9031).
6903 * chartab.c (char_table_set_range, map_sub_char_table):
6904 Remove unused locals.
6905 (uniprop_table): Now static.
6906 * composite.c (_work_char): Remove unused static var.
6907
9cb2ac56
JB
69082011-07-09 Juanma Barranquero <lekktu@gmail.com>
6909
6910 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6911
f25661f0
JD
69122011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6913
6914 * gtkutil.c (qttip_cb): Remove code without function.
6915
8278c4fe
EZ
69162011-07-09 Eli Zaretskii <eliz@gnu.org>
6917
6918 * w32.c (pthread_sigmask): New stub.
6919
1692ae2d 69202011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6921
8a6ebd58 6922 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6923 sigprocmask is portable only for single-threaded applications, and
6924 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6925 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6926 (LIBES): Use it.
6927 * callproc.c (Fcall_process):
6928 * process.c (create_process):
6929 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6930 Use pthread_sigmask, not sigprocmask.
123403e4 6931
1b854618
JD
69322011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6933
6934 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6935 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6936 wrong (Bug#8591).
6937
3fe4b549
JD
69382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6939
0ce7e563
JD
6940 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6941 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6942 (xg_hide_tooltip): Fix comment.
6943
3fe4b549
JD
6944 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6945 in registerServicesMenuSendTypes.
6946 (validRequestorForSendType): Don't check ns_return_types.
6947
6948 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6949 ns_return_type.
6950
5df75e47
JR
69512011-07-08 Jason Rumney <jasonr@gnu.org>
6952
22610910
JR
6953 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6954 SH_SHOW for hidden windows (Bug#5482).
6955
5df75e47
JR
6956 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6957 frame struct members of non-existent frames (Bug#6284).
6958
699c10bd
JD
69592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6960
4393663b
JD
6961 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6962 variable firstTime not needed on OSX >= 10.6.
6963 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6964 >= 10.5. Use setKnobProportion, setDoubleValue.
6965
6966 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6967 (MAC_OS_X_VERSION_10_5): Define if not defined.
6968 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6969 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6970 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6971
6972 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6973 cString and lossyCString on OSX >= 10.4
6974
58179cce 6975 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6976 sizeToFit on OSX >= 10.2.
6977
6978 * nsimage.m (allocInitFromFile): Don't use deprecated method
6979 bestRepresentationForDevice on OSX >= 10.6.
6980
6981 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6982 to avoid warning.
6983
6984 * emacs.c: Declare unexec_init_emacs_zone.
6985
a63e0781
JD
6986 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6987
699c10bd
JD
6988 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6989
6990 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6991 on svcsMenu (Bug#8842).
6992
6993 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6994 ns_return_types.
6995 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6996
6997 * nsterm.m (QUTF8_STRING): Declare.
6998 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6999 (validRequestorForSendType): Return type is (id).
7000 Change indexOfObjectIdenticalTo to indexOfObject.
7001 Check if we have local selection before returning self (Bug#8842).
7002 (writeSelectionToPasteboard): Put local selection into paste board
7003 if we have a local selection (Bug#8842).
7004 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7005
7006 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7007 (ns_get_local_selection): Declare.
7008
54e10184
LMI
70092011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7010
9888ff71
LMI
7011 * keymap.c (describe_map_tree): Don't insert a double newline at
7012 the end of the buffer (bug#1169) and return whether we inserted
7013 something.
7014
54e10184
LMI
7015 * callint.c (Fcall_interactively): Change "reading args" to
7016 "providing args" to try to clarify what it does (bug#1010).
7017
15fa4783
KH
70182011-07-07 Kenichi Handa <handa@m17n.org>
7019
7020 * composite.c (composition_compute_stop_pos): Ignore a static
7021 composition starting before CHARPOS (Bug#8915).
7022
7023 * xdisp.c (handle_composition_prop): Likewise.
7024
a8815b00
EZ
70252011-07-07 Eli Zaretskii <eliz@gnu.org>
7026
7027 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7028 (Bug#9015)
7029
ef7b981d 70302011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7031
7032 * character.h (unicode_category_t): New enum type.
7033
7034 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7035 (Qchar_code_property_table): New variable.
7036 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7037 (UNIPROP_COMPRESSED_FORM_P): New macros.
7038 (char_table_ascii): Uncompress the compressed values.
7039 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7040 Uncompress the compressed values.
ac389d0c 7041 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7042 (char_table_ref_and_range): Uncompress the compressed values.
7043 (sub_char_table_set): New arg is_uniprop. Callers changed.
7044 Uncompress the compressed values.
7045 (sub_char_table_set_range): Args changed. Callers changed.
7046 (char_table_set_range): Adjuted for the above change.
7047 (map_sub_char_table): Delete args default_val and parent. Add arg
7048 top. Give decoded values to a Lisp function.
640c8776 7049 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7050 values to a Lisp function. Gcpro more variables.
7051 (uniprop_table_uncompress)
7052 (uniprop_decode_value_run_length): New functions.
7053 (uniprop_decoder, uniprop_decoder_count): New variables.
7054 (uniprop_get_decoder, uniprop_encode_value_character)
7055 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7056 New functions.
7057 (uniprop_encoder, uniprop_encoder_count): New variables.
7058 (uniprop_get_encoder, uniprop_table)
7059 (Funicode_property_table_internal, Fget_unicode_property_internal)
7060 (Fput_unicode_property_internal): New functions.
7061 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7062 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7063 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7064 char-code-property-alist.
7065
640c8776 7066 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7067 Vunicode_category_table.
7068
640c8776 7069 * font.c (font_range): Adjust for the change of
c805dec0
KH
7070 Vunicode_category_table.
7071
76b397fb
DN
70722011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7073
7074 * m/iris4d.h: Remove file, move contents ...
7075 * s/irix6-5.h: ... here.
7076
22b4128e
PE
70772011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7078
7079 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7080 * alloc.c (mark_buffer):
7081 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7082 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7083 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7084 This isn't true in general, and it's particularly not true
7085 if Emacs is configured with --with-wide-int.
7086 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7087 New macros, used in the buffer.c change.
7088
869795d6
JD
70892011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7090
7091 * xsettings.c: Use both GConf and GSettings if both are available.
7092 (store_config_changed_event): Add comment.
7093 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7094 (store_tool_bar_style_changed): New functions.
5e617bc2 7095 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7096 (struct xsettings): Move font inside HAVE_XFT.
7097 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7098 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7099 Move inside HAVE_XFT.
640c8776 7100 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7101 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7102 also.
7103 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7104 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7105 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7106 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7107 (parse_settings): Move check for font inside HAVE_XFT.
7108 (read_settings, apply_xft_settings): Add comment.
7109 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7110 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7111 call store_font_name_changed.
7112 (xft_settings_event): Add comment.
7113 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7114 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7115 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7116 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7117 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7118 (xsettings_get_system_font, xsettings_get_system_normal_font):
7119 Add comment.
869795d6 7120
d8ed26bd
PE
71212011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7122
7123 Random fixes. E.g., (random) never returned negative values.
7124 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7125 subseconds part to the entropy, as that's a bit more random.
7126 Prefer signed to unsigned, since the signedness doesn't matter and
7127 in general we prefer signed. When given a limit, use a
7128 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7129 latter isn't right if USE_2_TAGS_FOR_INTS.
7130 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7131 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7132
cabf1cac
SM
71332011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7134
7135 * textprop.c (text_property_stickiness):
7136 Obey Vtext_property_default_nonsticky.
7137 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7138 * w32fns.c (syms_of_w32fns):
7139 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7140
6e9b2be9
PE
71412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7142
7143 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7144 This is more efficient than Ffile_directory_p and avoids a minor race.
7145
90186c68
LMI
71462011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7147
7c301272
LMI
7148 * buffer.c (Foverlay_put): Say what the return value is
7149 (bug#7835).
7150
c4f2d8d4
LMI
7151 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7152 is a directory before asking whether to use the file name
7153 (bug#7564).
ad637907
LMI
7154 (barf_or_query_if_file_exists): Make the "File is a directory"
7155 error be more correct.
c4f2d8d4 7156
90186c68
LMI
7157 * fns.c (Frequire): Remove the mention of the .gz files, since
7158 that's installation-specific, but keep the mention of
7159 `get-load-suffixes'.
7160
da64016e
PE
71612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7162
7163 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7164 Report string overflow if the output is too long.
7165
7d47b580
JB
71662011-07-04 Juanma Barranquero <lekktu@gmail.com>
7167
a555cb87
JB
7168 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7169 (syms_of_gnutls): Remove duplicate DEFSYM for
7170 Qgnutls_bootprop_verify_hostname_error, an error for
7171 Qgnutls_bootprop_verify_error (which is no longer used).
7172
7d47b580
JB
7173 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7174 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7175 Also (re)move comments that are misplaced or no longer relevant.
7176
1e49bfab
LMI
71772011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7178
7179 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7180
1485f4c0
CY
71812011-07-03 Chong Yidong <cyd@stupidchicken.com>
7182
7183 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7184 and background color parameters if they have been changed.
7185
a9ab721e
LMI
71862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7187
7188 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7189
cf7cff57
PE
71902011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7191
2e13213d
PE
7192 * xsettings.c (SYSTEM_FONT): Define only when used.
7193 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7194
cf7cff57
PE
7195 * keymap.c (access_keymap_1): Now static.
7196
7a8e04f7
CY
71972011-07-02 Chong Yidong <cyd@stupidchicken.com>
7198
7199 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7200 leave any prefix arg for the up event (Bug#1586).
7201
61352f62
LMI
72022011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7203
69bb1ef7
LMI
7204 * lread.c (syms_of_lread): Mention single symbols defined by
7205 `defvar' or `defconst' (bug#7154).
7206
61352f62 7207 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7208 (Frequire): Mention get-load-suffixes.
61352f62 7209
28545e04
MR
72102011-07-02 Martin Rudalics <rudalics@gmx.at>
7211
7212 * window.h (window): Remove clone_number slot.
7213 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7214 Remove.
7215 (make_parent_window, make_window, saved_window)
7216 (Fset_window_configuration, save_window_save): Don't deal with
7217 clone numbers.
7218 * buffer.c (Qclone_number): Remove declaration.
7219 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7220
3349e122
SM
72212011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7222
7223 Add multiple inheritance to keymaps.
7224 * keymap.c (Fmake_composed_keymap): New function.
7225 (Fset_keymap_parent): Simplify.
7226 (fix_submap_inheritance): Remove.
7227 (access_keymap_1): New function extracted from access_keymap to handle
7228 embedded parents and handle lists of maps.
7229 (access_keymap): Use it.
7230 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7231 (Fcopy_keymap): Handle embedded parents.
7232 (Fcommand_remapping, define_as_prefix): Simplify.
7233 (Fkey_binding): Simplify.
7234 (syms_of_keymap): Move minibuffer-local-completion-map,
7235 minibuffer-local-filename-completion-map,
7236 minibuffer-local-must-match-map, and
7237 minibuffer-local-filename-must-match-map to Elisp.
7238 (syms_of_keymap): Defsubr make-composed-keymap.
7239 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7240 (parse_menu_item): Trivial simplification.
7241
3279eb87
GM
72422011-07-01 Glenn Morris <rgm@gnu.org>
7243
7244 * Makefile.in (SETTINGS_LIBS): Fix typo.
7245
4550efdf
KI
72462011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7247
7248 * coding.c (Fencode_coding_string): Record the last coding system
7249 used, as the function doc string says (bug#8738).
7250
0949d2b6
JD
72512011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7252
7253 * xsettings.c (store_monospaced_changed): Take new font as arg and
7254 check for change against current_mono_font.
7255 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7256 (emacs_settings_constructor, emacs_settings_get_property)
7257 (emacs_settings_set_property, emacs_settings_class_init)
7258 (emacs_settings_init, gsettings_obj): Remove.
7259 (something_changedCB): New function for HAVE_GSETTINGS.
7260 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7261 with value as argument.
7262 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7263 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7264 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7265 "changed".
7266
7267 * xgselect.c: Add defined (HAVE_GSETTINGS).
7268 (xgselect_initialize): Ditto.
7269
7270 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7271 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7272 xg_select.
7273
bbc6b304
PE
72742011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7275
7276 * eval.c (struct backtrace): Simplify and port the data structure.
7277 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7278 signed bit field, as this assumption is not portable and it makes
7279 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7280 "char debug_on_exit : 1" as this is not portable either; instead,
7281 use the portable "unsigned int debug_on_exit : 1". Remove unused
7282 member evalargs. Remove obsolete comments about cc bombing out.
7283
9851bfc5
JD
72842011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7285
51bb811f 7286 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7287 Let HAVE_GSETTINGS override HAVE_GCONF.
7288 (store_monospaced_changed): New function.
7289 (EMACS_SETTINGS): A new type derived from GObject to handle
7290 GSettings notifications.
7291 (emacs_settings_constructor, emacs_settings_get_property)
7292 (emacs_settings_set_property, emacs_settings_class_init):
7293 New functions.
7294 (gsettings_client, gsettings_obj): New variables.
7295 (GSETTINGS_SCHEMA): New define.
7296 (something_changedCB): Call store_monospaced_changed.
7297 (init_gsettings): New function.
7298 (xsettings_initialize): Call init_gsettings.
7299 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7300 to NULL.
7301
640c8776 7302 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7303 GCONF_CFLAGS/LIBS.
7304
5386012d
MR
73052011-06-29 Martin Rudalics <rudalics@gmx.at>
7306
7307 * window.c (resize_root_window, grow_mini_window)
7308 (shrink_mini_window): Rename Qresize_root_window to
7309 Qwindow_resize_root_window and Qresize_root_window_vertically to
7310 Qwindow_resize_root_window_vertically.
7311
f13e0b08
PE
73122011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7313
7314 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7315
94515237
JB
73162011-06-27 Juanma Barranquero <lekktu@gmail.com>
7317
7318 * makefile.w32-in: Redesign dependencies so they reflect more
7319 clearly which files are directly included by each source file,
7320 and not through other includes.
7321
e43b6e43
MR
73222011-06-27 Martin Rudalics <rudalics@gmx.at>
7323
7324 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7325 (sort_overlays, overlay_strings): When an overlay's clone number
7326 matches the window's clone number process the overlay even if
7327 the overlay's window property doesn't match the current window.
7328
d68443dc
MR
7329 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7330 (Fwindow_hchild): Rename to Fwindow_left_child.
7331 (Fwindow_next): Rename to Fwindow_next_sibling.
7332 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7333 (resize_window_check): Rename to window_resize_check.
7334 (resize_window_apply): Rename to window_resize_apply.
7335 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7336 (Fdelete_other_windows_internal, resize_frame_windows)
7337 (Fsplit_window_internal, Fdelete_window_internal)
7338 (grow_mini_window, shrink_mini_window)
7339 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7340
c7e73be5
JD
73412011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7342
7343 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7344 (emacs_fixed_set_min_size): Remove.
7345 (emacs_fixed_new): Take frame as argument.
7346
7347 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7348 (_EmacsFixedPrivate): Remove minwidth/height.
7349 Add struct frame *f.
7350 (emacs_fixed_init): Initialize priv->f.
7351 (get_parent_class, emacs_fixed_set_min_size): Remove.
7352 (emacs_fixed_new): Set priv->f to argument.
7353 (emacs_fixed_get_preferred_width)
7354 (emacs_fixed_get_preferred_height): Use min_width/height from
7355 frames size_hint to set minimum and natural (Bug#8919).
7356 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7357 and use min_width/height from frames size_hint to set
7358 min_width/height (Bug#8919).
7359
7360 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7361 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7362 Fix indentation.
c7e73be5 7363
cf99dcf8
EZ
73642011-06-26 Eli Zaretskii <eliz@gnu.org>
7365
7366 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7367 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7368 called at ZV.
7369
029529ac
CY
73702011-06-26 Chong Yidong <cyd@stupidchicken.com>
7371
7372 * process.c (wait_reading_process_output): Bypass select if
7373 waiting for a cell while ignoring keyboard input, and input is
7374 pending. Suggested by Jan Djärv (Bug#8869).
7375
7a7ef429
PE
73762011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7377
7378 Use gnulib's dup2 module instead of rolling our own.
7379 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7380
11fdef7d 73812011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7382
7383 * dispnew.c (scrolling_window): Before scrolling, turn off a
7384 mouse-highlight in the window being scrolled.
7385
cd3520a4
JB
73862011-06-24 Juanma Barranquero <lekktu@gmail.com>
7387
7388 Move DEFSYM to lisp.h and use everywhere.
7389
7390 * character.h (DEFSYM): Move declaration...
7391 * lisp.h (DEFSYM): ...here.
7392
7393 * gnutls.c:
7394 * minibuf.c:
7395 * w32menu.c:
7396 * w32proc.c:
7397 * w32select.c: Don't include character.h.
7398
7399 * alloc.c (syms_of_alloc):
7400 * buffer.c (syms_of_buffer):
7401 * bytecode.c (syms_of_bytecode):
7402 * callint.c (syms_of_callint):
7403 * casefiddle.c (syms_of_casefiddle):
7404 * casetab.c (init_casetab_once):
7405 * category.c (init_category_once, syms_of_category):
7406 * ccl.c (syms_of_ccl):
7407 * cmds.c (syms_of_cmds):
7408 * composite.c (syms_of_composite):
7409 * dbusbind.c (syms_of_dbusbind):
7410 * dired.c (syms_of_dired):
7411 * dispnew.c (syms_of_display):
7412 * doc.c (syms_of_doc):
7413 * editfns.c (syms_of_editfns):
7414 * emacs.c (syms_of_emacs):
7415 * eval.c (syms_of_eval):
7416 * fileio.c (syms_of_fileio):
7417 * fns.c (syms_of_fns):
7418 * frame.c (syms_of_frame):
7419 * fringe.c (syms_of_fringe):
7420 * insdel.c (syms_of_insdel):
7421 * keymap.c (syms_of_keymap):
7422 * lread.c (init_obarray, syms_of_lread):
7423 * macros.c (syms_of_macros):
7424 * msdos.c (syms_of_msdos):
7425 * print.c (syms_of_print):
7426 * process.c (syms_of_process):
7427 * search.c (syms_of_search):
7428 * sound.c (syms_of_sound):
7429 * syntax.c (init_syntax_once, syms_of_syntax):
7430 * terminal.c (syms_of_terminal):
7431 * textprop.c (syms_of_textprop):
7432 * undo.c (syms_of_undo):
7433 * w32.c (globals_of_w32):
7434 * window.c (syms_of_window):
7435 * xdisp.c (syms_of_xdisp):
7436 * xfaces.c (syms_of_xfaces):
7437 * xfns.c (syms_of_xfns):
7438 * xmenu.c (syms_of_xmenu):
7439 * xsettings.c (syms_of_xsettings):
7440 * xterm.c (syms_of_xterm): Use DEFSYM.
7441
4228cf16
TZ
74422011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7443
cd3520a4 7444 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7445
7fcccf1e
PE
74462011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7447
7efb4e0e
PE
7448 Integer and buffer overflow fixes (Bug#8873).
7449
ff5844ad
PE
7450 * print.c (printchar, strout): Check for string overflow.
7451 (PRINTPREPARE, printchar, strout):
7452 Don't set size unless allocation succeeds.
7453
90532f02
PE
7454 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7455 for sizes. Check for string overflow more accurately.
7456 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7457
6d84508d
PE
7458 * macros.c: Integer and buffer overflow fixes.
7459 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7460 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7461 Use ptrdiff_t, not int, for sizes.
7462 Don't increment bufsize until after realloc succeeds.
7463 Check for size-calculation overflow.
7464 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7465
437b2cb4
PE
7466 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7467
8b9ac8b4
PE
7468 * lread.c: Integer overflow fixes.
7469 (read_integer): Radix is now EMACS_INT, not int,
7470 to improve quality of diagnostics for out-of-range radices.
7471 Calculate buffer size correctly for out-of-range radices.
7472 (read1): Check for integer overflow in radices, and in
7473 read-circle numbers.
82cb60d3
PE
7474 (read_escape): Avoid int overflow.
7475 (Fload, openp, read_buffer_size, read1)
7476 (substitute_object_recurse, read_vector, read_list, map_obarray):
7477 Use ptrdiff_t, not int, for sizes.
7478 (read1): Use EMACS_INT, not int, for sizes.
20270765 7479 Check for size overflow.
8b9ac8b4 7480
7fcccf1e
PE
7481 * image.c (cache_image): Check for size arithmetic overflow.
7482
bfbbd7e7
PE
7483 * lread.c: Integer overflow issues.
7484 (saved_doc_string_size, saved_doc_string_length)
7485 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7486 Now ptrdiff_t, not int.
7487 (read1): Don't assume doc string length fits in int. Check for
7488 out-of-range doc string lengths.
7489 (read_list): Don't assume file position fits in int.
39019e54 7490 (read_escape): Check for hex character overflow.
bfbbd7e7 7491
4e323265
LL
74922011-06-22 Leo Liu <sdl.web@gmail.com>
7493
7494 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7495 Move to minibuffer.el.
7496
85fece3e
PE
74972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7498
20b84ce9 7499 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7500 The following patches are for when GLYPH_DEBUG && !XASSERT.
7501 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7502 * dispnew.c (flush_stdout):
7503 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7504 Mark as externally visible.
7505 * dispnew.c (check_window_matrix_pointers): Now static.
7506 * dispnew.c (window_to_frame_vpos):
7507 * xfns.c (unwind_create_frame):
7508 * xterm.c (x_check_font): Remove unused local.
7509 * scroll.c (CHECK_BOUNDS):
7510 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7511 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7512 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7513 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7514 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7515 Now static.
7516 (debug_method_add): Use va_list and vsprintf rather than relying
7517 on undefined behavior with wrong number of arguments.
7518 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7519 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7520 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7521 since we're not interested in debugging glyphs with old libraries.
7522 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7523 GCC 4.6.0's static checking.
7524
0766b489
PE
75252011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7526
31fd4b32
PE
7527 Integer overflow and signedness fixes (Bug#8873).
7528 A few related buffer overrun fixes, too.
7529
b79e8648
PE
7530 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7531
0766b489
PE
7532 * dispextern.h (struct face.stipple):
7533 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7534 (x_bitmap_mask, x_allocate_bitmap_record)
7535 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7536 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7537 (x_create_bitmap_from_xpm_data):
7538 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7539 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7540 (.bitmaps_last):
7541 * xfaces.c (load_pixmap):
7542 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7543 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7544 (.bitmaps_last, struct x_output.icon_bitmap):
7545 Use ptrdiff_t, not int, for bitmap indexes.
7546 (x_allocate_bitmap_record): Check for size overflow.
7547 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7548
b081724f
PE
7549 Use ptrdiff_t, not int, for overlay counts.
7550 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7551 * editfns.c (overlays_around, get_pos_property):
7552 * textprop.c (get_char_property_and_overlay):
7553 * xdisp.c (next_overlay_change, note_mouse_highlight):
7554 * xfaces.c (face_at_buffer_position):
21514da7
PE
7555 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7556 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7557 (Fnext_overlay_change, Fprevious_overlay_change)
7558 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7559 Use ptrdiff_t, not int, for sizes.
21514da7 7560 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7561
3de73e5e
PE
7562 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7563
2606c57b
PE
7564 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7565 (x_session_initialize): Do not assume string length fits in int.
7566
aaafe47a
PE
7567 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7568 This is unlikely, but can occur if DPI is outlandish.
7569
2674ddc8 7570 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7571 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7572
28154962
PE
7573 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7574 * xrdb.c (magic_file_p, search_magic_path):
7575 Omit last arg SUFFIX; it was always 0. All callers changed.
7576 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7577
7de51af5
PE
7578 * xfont.c (xfont_match): Avoid need for strlen.
7579
25ed6cc3
PE
7580 * xfns.c: Don't assume strlen fits in int.
7581 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7582
4eab31dd
PE
7583 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7584 not unsigned long, as we prefer signed integers. All callers changed.
7585 Detect integer overflow in repeat count.
7586 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7587 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7588
171e2a58
PE
7589 * termcap.c: Don't assume sizes fit in int and never overflow.
7590 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7591 (gobble_line): Check for size-calculation overflow.
7592
ad39faca 7593 * minibuf.c (Fread_buffer):
6e5bb2dc 7594 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7595 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7596 Don't assume string length fits in int.
7597
52c61c22 7598 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7599 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7600
b5b8c9e5
PE
7601 * font.c: Don't assume string length fits in int.
7602 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7603 Use ptrdiff_t, not int.
ccd6111c
PE
7604 (font_intern_prop): Don't assume string length fits in int.
7605 Don't assume integer property fits in fixnum.
7606 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7607
882f0d81 7608 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7609 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7610 Reformulate so as not to need the command string.
7611 Invoke gzip -cd rather than gunzip, as it's more portable.
7612 (lock_info_type, lock_file_1, lock_file):
7613 Don't assume pid_t and time_t fit in unsigned long.
7614 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7615 (current_lock_owner): Prefer signed type for sizes.
7616 Use memcpy, not strncpy, where memcpy is what is really wanted.
7617 Don't assume (via atoi) that time_t and pid_t fit in int.
7618 Check for time_t and/or pid_t out of range, e.g., via a network share.
7619 Don't alloca where an auto var works fine.
7620
93f4cf88
PE
7621 * fileio.c: Fix some integer overflow issues.
7622 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7623 Don't assume string length fits in int.
7624 (directory_file_name): Don't assume string length fits in long.
7625 (make_temp_name): Don't assume pid fits in int, or that its print
7626 length is less than 20.
7627
f3e92b69
PE
7628 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7629
1bfdaf10
PE
7630 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7631
35016e9a
PE
7632 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7633
3d1e65a1
PE
7634 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7635 We prefer signed integers, even for size calculations.
7636
0b963a93
PE
7637 * emacs.c: Don't assume string length fits in 'int'.
7638 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7639 (main): Don't invoke strlen when not needed.
7640
573f4b54
PE
7641 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7642 (XD_DEBUG_MESSAGE): Don't waste a byte.
7643
989f33ba
PE
7644 * callproc.c (getenv_internal_1, getenv_internal)
7645 (Fgetenv_internal):
965d34eb
PE
7646 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7647
e4d29b33
PE
7648 * lread.c (invalid_syntax): Omit length argument.
7649 All uses changed. This doesn't fix a bug, but it simplifies the
7650 code away from its former Hollerith-constant appearance, and it's
7651 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7652 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7653
eb49b136
PE
7654 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7655 This didn't break anything, but it didn't help either.
7656 It's confusing to put a bogus integer in a place where the actual
7657 value does not matter.
9f62aeb1 7658 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7659 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7660
15375a22
PE
7661 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7662 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7663 implementation.
b61cc01c
PE
7664 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7665 We prefer signed types, and the value cannot exceed the EMACS_INT
7666 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7667 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7668 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7669 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7670
53b2623d
PE
7671 * indent.c (sane_tab_width): New function.
7672 (current_column, scan_for_column, Findent_to, position_indentation)
7673 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7674 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7675
51cab52b 7676 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7677
f2ed8a70
PE
7678 * lisp.h (lint_assume): New macro.
7679 * composite.c (composition_gstring_put_cache):
7680 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7681
abe80cc6
PE
7682 * editfns.c, insdel.c:
7683 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7684
b02c740e
PE
7685 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7686
ebc96716
PE
7687 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7688
b4e50fa0 7689 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7690 Use much-faster test for byte-length change.
311d5d7c 7691 Don't assume string byte-length fits in 'int'.
a4cf38e4 7692 Check that character arg fits in 'int'.
85461888 7693 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7694
c0c1ee9f
PE
7695 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7696
a498d7f4
PE
7697 * fns.c (concat): Catch string overflow earlier.
7698 Do not rely on integer wraparound.
7699
51cab52b
PE
7700 * dispextern.h (struct it.overlay_strings_charpos)
7701 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7702 * xdisp.c (forward_to_next_line_start)
7703 (back_to_previous_visible_line_start)
7704 (reseat_at_next_visible_line_start, next_element_from_buffer):
7705 Don't arbitrarily truncate the value of 'selective' to int.
7706
76031fad
PE
7707 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7708
5eb55db9
PE
7709 * composite.c: Don't truncate sizes to 'int'.
7710 (composition_gstring_p, composition_reseat_it)
7711 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7712 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7713 not EMACS_UINT, for indexes.
5eb55db9 7714
0703a717
PE
7715 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7716
d6202519
PE
7717 * buffer.c: Include <verify.h>.
7718 (struct sortvec.priority, struct sortstr.priority):
8961a454 7719 Now EMACS_INT, not int.
c20998a7 7720 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7721 (struct sortstr.size, record_overlay_string)
7722 (struct sortstrlist.size, struct sortlist.used):
7723 Don't truncate size to int.
7724 (record_overlay_string): Check for size-calculation overflow.
d6202519 7725 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7726
d5a19415
JM
77272011-06-22 Jim Meyering <meyering@redhat.com>
7728
029529ac 7729 Don't leak an XBM-image-sized buffer
d5a19415
JM
7730 * image.c (xbm_load): Free the image buffer after using it.
7731
a9041e6c
PE
77322011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7733
7734 Port to Sun C.
7735 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7736 that Sun C diagnosed.
7737 * fns.c (secure_hash): Fix pointer signedness issue.
7738 * intervals.c (static_offset_intervals): New function.
7739 (offset_intervals): Use it.
7740
7f3f739f
LL
77412011-06-21 Leo Liu <sdl.web@gmail.com>
7742
7743 * deps.mk (fns.o):
7744 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7745 sha512.h.
7746
7747 * fns.c (secure_hash): Rename from crypto_hash_function and change
7748 the first arg to accept symbols.
5b66d427 7749 (Fsecure_hash): New primitive.
7f3f739f
LL
7750 (syms_of_fns): New symbols.
7751
76147d94
DD
77522011-06-20 Deniz Dogan <deniz@dogan.se>
7753
7754 * process.c (Fset_process_buffer): Clarify return value in
7755 docstring.
7756
7d7d0045
CY
77572011-06-18 Chong Yidong <cyd@stupidchicken.com>
7758
7759 * dispnew.c (add_window_display_history): Use BVAR.
7760
7761 * xdisp.c (debug_method_add): Use BVAR.
7762 (check_window_end, dump_glyph_matrix, dump_glyph)
7763 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7764
7765 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7766 Likewise.
7767
7768 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7769 check till after the cache is created in init_frame_faces.
7770
ff2bc410
SM
77712011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7772
7773 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7774
28177add
PE
77752011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7776
dd3482fe
PE
7777 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7778 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7779 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7780
393d71f3 7781 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7782 * fileio.c (Finsert_file_contents):
7783 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7784 Remove the old (too-loose) buffer overflow checks.
7785 They weren't needed, since make_gap checks for buffer overflow.
7786 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7787 The old code merely checked for Emacs fixnum overflow, and relied
7788 on undefined (wraparound) behavior. The new code avoids undefined
7789 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7790
2e6813b0 7791 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7792 Tune. Don't use wider integers than needed. Don't use alloca.
7793 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7794
599a9e4f
PE
7795 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7796
99561444
PE
7797 * insdel.c, lisp.h (buffer_overflow): New function.
7798 (insert_from_buffer_1, replace_range, replace_range_2):
7799 * insdel.c (make_gap_larger):
7800 * editfns.c (Finsert_char):
7801 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7802
28177add
PE
7803 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7804
e69dafad
PE
78052011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7806
4baa020d 7807 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7808
b1c46f02
PE
7809 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7810 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7811
e69dafad
PE
7812 * fileio.c: Don't assume EMACS_INT fits in off_t.
7813 (emacs_lseek): New static function.
7814 (Finsert_file_contents, Fwrite_region): Use it.
7815 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7816
566684ea
PE
7817 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7818
e6966cd6
PE
7819 * fns.c: Don't overflow int when computing a list length.
7820 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7821 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7822 truncation on 64-bit hosts. Check for QUIT every
7823 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7824 faster and is responsive enough.
7825 (Flength): Report an error instead of overflowing an integer.
7826 (Fsafe_length): Return a float if the value is not representable
7827 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7828 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7829 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7830
dd0b0efb
PE
7831 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7832 (header_size, word_size): New constants.
7833 (allocate_vectorlike): Don't check size overflow here.
7834 (allocate_vector): Check it here instead, since this is the only
7835 caller of allocate_vectorlike that could cause overflow.
7836 Check that the new vector's length is representable as a fixnum.
7837
86fe5cfe
PE
7838 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7839 The previous code was bogus. For example, next_almost_prime (32)
7840 returned 39, which is undesirable as it is a multiple of 3; and
7841 next_almost_prime (24) returned 25, which is a multiple of 5 so
7842 why was the code bothering to check for multiples of 7?
7843
80e88859
PE
7844 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7845
4a2f0ad6
PE
7846 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7847
f66c7cf8
PE
7848 Variadic C functions now count arguments with ptrdiff_t.
7849 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7850 Back then I didn't know that the Emacs coding style prefers signed int.
7851 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7852 were being counted with int, which may truncate counts on 64-bit
7853 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7854 * lisp.h (struct Lisp_Subr.function.aMANY)
7855 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7856 Arg counts are now ptrdiff_t, not size_t.
7857 All variadic functions and their callers changed accordingly.
7858 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7859 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7860 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7861 * callint.c (Fcall_interactively): Check arg count for overflow,
7862 to avoid potential buffer overrun. Use signed char, not 'int',
7863 for 'varies' array, so that we needn't bother to check its size
7864 calculation for overflow.
7865 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7866 * eval.c (apply_lambda):
7867 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7868 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7869 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7870
a1759b76
PE
7871 * callint.c (Fcall_interactively): Don't use index var as event count.
7872
d96be9fc
PE
7873 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7874 * mem-limits.h (SIZE): Remove; no longer used.
7875
a690a978 7876 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7877
578c21e6
PE
7878 Remove unnecessary casts.
7879 * xterm.c (x_term_init):
7880 * xfns.c (x_set_border_pixel):
7881 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7882 These aren't needed now that we assume ANSI C.
7883
96f53c6c
PE
7884 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7885 It's more likely to cause problems (due to unsigned overflow)
7886 than to cure them.
7887
83c77d31
PE
7888 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7889
ee2079f1
PE
7890 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7891
6da65536
PE
7892 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7893
7147c4a4
PE
7894 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7895
193e32d9
PE
7896 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7897
e5533da6
PE
7898 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7899
9910e595
PE
7900 GLYPH_CODE_FACE returns EMACS_INT, not int.
7901 * dispextern.h (merge_faces):
7902 * xfaces.c (merge_faces):
01103c44
PE
7903 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7904 Don't assume EMACS_INT fits in int.
9910e595 7905
2638320e
PE
7906 * character.h (CHAR_VALID_P): Remove unused parameter.
7907 * fontset.c, lisp.h, xdisp.c: All uses changed.
7908
045eb8d9
PE
7909 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7910
c1f134b5
PE
7911 * fns.c (concat): Minor tuning based on overflow analysis.
7912 This doesn't fix any bugs. Use int to hold character, instead
7913 of constantly refetching from Emacs object. Use XFASTINT, not
7914 XINT, for value known to be a character. Don't bother comparing
7915 a single byte to 0400, as it's always less.
7916
395fcb93 7917 * floatfns.c (Fexpt):
327eeec8
PE
7918 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7919
abbd3d23
PE
7920 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7921 for characters.
7922
684a03ef
PE
7923 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7924
0fed43f3
PE
7925 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7926 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7927 incorrectly succeed when S was a string, because 4294967386 was
7928 truncated before it was used.
7929
8fd02eb7
PE
7930 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7931 Otherwise, an out-of-range integer could cause undefined behavior
7932 on a 64-bit host.
7933
f8c86b69
PE
7934 * composite.c: Use int, not EMACS_INT, for characters.
7935 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7936 EMACS_INT, for values that are known to be in character range.
7937 This doesn't fix any bugs but is the usual style inside Emacs and
7938 may generate better code on 32-bit machines.
7939
34206dd2
PE
7940 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7941 This is for reasons similar to the recent CHAR_STRING fix.
7942 * charset.c (Fencode_char): Check that character arg is actually
7943 a character. Pass an int to ENCODE_CHAR.
7944 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7945 wider than 'int', as a compile-time check to prevent future regressions
7946 in this area.
7947
c5958d4c 7948 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7949
7950 Make sure a 64-bit char is never passed to CHAR_STRING.
7951 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7952 by silently ignoring the top 32 bits, allowing some values
7953 that were far too large to be valid characters.
7954 * character.h: Include <verify.h>.
7955 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7956 arguments are no wider than unsigned, as a compile-time check
7957 to prevent future regressions in this area.
7958 * data.c (Faset):
01103c44 7959 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7960 (Fsubst_char_in_region):
7961 * fns.c (concat):
7962 * xdisp.c (decode_mode_spec_coding):
7963 Adjust to CHAR_STRING's new requirement.
7964 * editfns.c (Finsert_char, Fsubst_char_in_region):
7965 * fns.c (concat): Check that character args are actually
7966 characters. Without this test, these functions did the wrong
7967 thing with wildly out-of-range values on 64-bit hosts.
7968
d37ca623
PE
7969 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7970 These casts should not be needed on 32-bit hosts, either.
7971 * keyboard.c (read_char):
7972 * lread.c (Fload): Remove casts to unsigned.
7973
ea204efb
PE
7974 * lisp.h (UNSIGNED_CMP): New macro.
7975 This fixes comparison bugs on 64-bit hosts.
7976 (ASCII_CHAR_P): Use it.
7977 * casefiddle.c (casify_object):
01103c44 7978 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7979 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7980 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7981 * dispextern.h (FACE_FROM_ID):
7982 * keyboard.c (read_char): Use UNSIGNED_CMP.
7983
41cb286c
PE
7984 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7985 not to EMACS_INT, to avoid GCC warning.
7986
4a1b9832
PE
7987 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7988
55daad71
PE
7989 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7990 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7991 isn't needed on 32-bit machines.
8f95c75c 7992
01103c44
PE
7993 * buffer.c (Fgenerate_new_buffer_name):
7994 Use EMACS_INT for count, not int.
0ceccced 7995 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7996
7997 * data.c (Qcompiled_function): Now static.
7998
c6f072e7
PE
7999 * window.c (window_body_lines): Now static.
8000
20ce5912
PE
8001 * image.c (gif_load): Rename local to avoid shadowing.
8002
9c4c5f81
PE
8003 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8004 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8005 * alloc.c (make_save_value): Integer argument is now of type
8006 ptrdiff_t, not int.
8007 (mark_object): Use ptrdiff_t, not int.
8008 * lisp.h (pD): New macro.
8009 * print.c (print_object): Use it.
8010
c0c5c8ae
PE
8011 * alloc.c: Use EMACS_INT, not int, to count objects.
8012 (total_conses, total_markers, total_symbols, total_vector_size)
8013 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8014 (total_free_floats, total_floats, total_free_intervals)
8015 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8016 Now EMACS_INT, not int. All uses changed.
8017 (Fgarbage_collect): Compute overall total using a double, so that
8018 integer overflow is less likely to be a problem. Check for overflow
8019 when converting back to an integer.
5a25e253
PE
8020 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8021 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8022 These were 'int' variables that could overflow on 64-bit hosts;
8023 they were never used, so remove them instead of repairing them.
211a0b2a 8024 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8025 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8026 Previously, this ceilinged at INT_MAX, but that doesn't work on
8027 64-bit machines.
e46bb31a 8028 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8029
c78baabf 8030 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8031 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8032 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8033 when a (possibly-narrower) signed value would do just as well.
8034 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8035
c9d624c6
PE
8036 * alloc.c: Catch some string size overflows that we were missing.
8037 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8038 for convenience in STRING_BYTES_MAX.
8039 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8040 The definition here is exact; the one in lisp.h was approximate.
8041 (allocate_string_data): Check for string overflow. This catches
8042 some instances we weren't catching before. Also, it catches
8043 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8044 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8045 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8046
c9d624c6
PE
8047 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8048 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8049 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8050
353032ce
PE
8051 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8052
2bccce07
PE
8053 * alloc.c (Fmake_string): Check for out-of-range init.
8054
0ac30604
SM
80552011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8056
8057 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8058
c195f2de
JD
80592011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8060
8061 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8062 xg_get_default_scrollbar_width.
8063
8064 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8065 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8066 (style_changed_cb): Call update_theme_scrollbar_width and call
8067 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8068 all frames (Bug#8505).
8069 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8070 Call gtk_window_set_resizable if HAVE_GTK3.
8071 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8072 and height if HAVE_GTK3 (Bug#8505).
8073 (scroll_bar_width_for_theme): New variable.
8074 (update_theme_scrollbar_width): New function.
8075 (xg_get_default_scrollbar_width): Move code to
8076 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8077 (xg_initialize): Call update_theme_scrollbar_width.
8078
8079 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8080
8081 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8082
e10ac9f1
MR
80832011-06-12 Martin Rudalics <rudalics@gmx.at>
8084
8085 * frame.c (make_frame): Call other_buffer_safely instead of
8086 other_buffer.
8087
8088 * window.c (temp_output_buffer_show): Call display_buffer with
8089 second argument Vtemp_buffer_show_specifiers and reset latter
8090 immediately after the call.
8091 (Vtemp_buffer_show_specifiers): New variable.
8092 (auto_window_vscroll_p, next_screen_context_lines)
8093 (Vscroll_preserve_screen_position): Remove leading asterisks from
8094 doc-strings.
8095
2d3c217e 80962011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8097
7b7f97e8 8098 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8099 * buffer.c (Qclone_number): Remove for now, as it's unused.
8100 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8101 (record_buffer): Remove unused local.
8102 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8103 (set_frame_buffer_list): Remove; unused.
8104 * frame.h (other_visible_frames): Remove decl.
8105 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8106 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8107 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8108 if HAVE_GPM.
8109 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8110 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8111 Define only if HAVE_GPM.
8112 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8113 (update_hints_inhibit): Remove; never set. All uses removed.
8114 * widgetprv.h (emacsFrameClassRec): Remove decl.
8115 * window.c (delete_deletable_window): Now returns void, since it
8116 wasn't returning anything.
8117 (compare_window_configurations): Remove unused locals.
8118 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8119 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8120 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8121 the same widths as pointers. This follows up on the 2011-05-06 patch.
8122 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8123 * xterm.h: Likewise.
8124 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8125
1384b89e
JB
81262011-06-12 Juanma Barranquero <lekktu@gmail.com>
8127
8128 * makefile.w32-in: Update dependencies.
8129 (LISP_H): Add lib/intprops.h.
8130
1100a63c
CY
81312011-06-11 Chong Yidong <cyd@stupidchicken.com>
8132
8133 * image.c (gif_load): Add animation frame delay to the metadata.
8134 (syms_of_image): Use DEFSYM. New symbol `delay'.
8135
6198ccd0
MR
81362011-06-11 Martin Rudalics <rudalics@gmx.at>
8137
8138 * window.c (delete_deletable_window): Re-add.
8139 (Fset_window_configuration): Rewrite to handle dead buffers and
8140 consequently deletable windows.
8141 (window_tree, Fwindow_tree): Remove. Supply functionality in
8142 window.el.
8143 (compare_window_configurations): Simplify code.
8144
b6e3633c
AS
81452011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8146
1ab0dee5
AS
8147 * image.c (imagemagick_load_image): Fix type mismatch.
8148 (Fimagemagick_types): Likewise.
8149
b6e3633c
AS
8150 * window.h (replace_buffer_in_windows): Declare.
8151
9397e56f
MR
81522011-06-11 Martin Rudalics <rudalics@gmx.at>
8153
8154 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8155 Qclone_number. Remove external declaration of Qdelete_window.
8156 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8157 code.
640c8776
SM
8158 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8159 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8160 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8161 buffer list implementation.
8162 (other_buffer_safely): New function.
8163 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8164 calls to replace_buffer_in_windows and
8165 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8166 if allowed.
8167 (record_buffer): Inhibit quitting and rewrite using quittable
8168 functions. Run Qbuffer_list_update_hook if allowed.
8169 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8170 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8171 Move switch-to-buffer to window.el.
9397e56f
MR
8172 (bury-buffer): Move to window.el.
8173 (Vbuffer_list_update_hook): New variable.
8174
8175 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8176 section.
8177
8178 * window.h (resize_frame_windows): Move up in code.
8179 (Fwindow_frame): Remove EXFUN.
8180 (replace_buffer_in_all_windows): Remove prototype.
8181 (replace_buffer_in_windows_safely): Add prototype.
8182
8183 * window.c: Declare Qdelete_window static again. Move down
8184 declaration of select_count.
8185 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8186 (Fother_window): Move to window.el.
8187 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8188 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8189 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8190 window.el.
8191 (replace_buffer_in_windows): Implement by calling
8192 Qreplace_buffer_in_windows.
8193 (replace_buffer_in_all_windows): Remove with some functionality
8194 moved into replace_buffer_in_windows_safely.
8195 (replace_buffer_in_windows_safely): New function.
8196 (select_window_norecord, select_frame_norecord): Move in front
8197 of run_window_configuration_change_hook. Remove now obsolete
8198 declarations.
640c8776
SM
8199 (Fset_window_buffer): Rewrite doc-string.
8200 Call Qrecord_window_buffer.
9397e56f
MR
8201 (keys_of_window): Move binding for other-window to window.el.
8202
b50691aa
CY
82032011-06-11 Chong Yidong <cyd@stupidchicken.com>
8204
8205 * dispextern.h (struct image): Replace data member, whose int_val
8206 and ptr_val fields were not used by anything, with a single
8207 lisp_val object.
8208
8209 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8210 (gif_clear_image, gif_load, imagemagick_load_image)
8211 (gs_clear_image, gs_load): Callers changed.
8212
3f754b86
PE
82132011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8214
cca69397
PE
8215 * buffer.h: Include <time.h>, for time_t.
8216 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8217
109e28d0
PE
8218 Fix minor problems found by static checking.
8219
60737f02
PE
8220 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8221
4b66faf3
PE
8222 Make identifiers static if they are not used in other modules.
8223 * data.c (Qcompiled_function, Qframe, Qvector):
8224 * image.c (QimageMagick, Qsvg):
8225 * minibuf.c (Qmetadata):
8226 * window.c (resize_window_check, resize_root_window): Now static.
8227 * window.h (resize_window_check, resize_root_window): Remove decls.
8228
109e28d0
PE
8229 * window.c (window_deletion_count, delete_deletable_window):
8230 Remove; unused.
46a4ce9e
PE
8231 (window_body_lines): Now static.
8232 (Fdelete_other_windows_internal): Mark vars as initialized.
8233 Make sure 'resize_failed' is initialized.
8234 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8235 (resize_window_apply): Remove unused local.
8236 * window.h (delete_deletable_window): Remove decl.
8237
109e28d0 8238 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8239 (imagemagick_load_image): Fix pointer signedness problem by changing
8240 last arg from unsigned char * to char *. All uses changed.
8241 Also, fix a local for similar reasons.
8242 Remove unused locals. Remove locals to avoid shadowing.
8243 (fn_rsvg_handle_free): Remove; unused.
8244 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8245 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8246
3f754b86
PE
8247 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8248
2547adb1
CY
82492011-06-10 Chong Yidong <cyd@stupidchicken.com>
8250
8251 * image.c (gif_load): Fix omitted cast error introduced by
8252 2011-06-06 change.
8253
2c8e37d4
MR
82542011-06-10 Martin Rudalics <rudalics@gmx.at>
8255
8256 * window.h (resize_proportionally, orig_total_lines)
8257 (orig_top_line): Remove from window structure.
8258 (set_window_height, set_window_width, change_window_heights)
8259 (Fdelete_window): Remove prototypes.
8260 (resize_frame_windows): Remove duplicate declaration.
8261
440a42e3
EZ
82622011-06-10 Eli Zaretskii <eliz@gnu.org>
8263
8264 * window.h (resize_frame_windows, resize_window_check)
8265 (delete_deletable_window, resize_root_window)
8266 (resize_frame_windows): Declare prototypes.
8267
8268 * window.c (resize_window_apply): Make definition be "static" to
8269 match the prototype.
8270
562dd5e9
MR
82712011-06-10 Martin Rudalics <rudalics@gmx.at>
8272
8273 * window.c: Remove declarations of Qwindow_size_fixed,
8274 window_min_size_1, window_min_size_2, window_min_size,
8275 size_window, window_fixed_size_p, enlarge_window, delete_window.
8276 Remove static from declaration of Qdelete_window, it's
8277 temporarily needed by Fbury_buffer.
8278 (replace_window): Don't assign orig_top_line and
8279 orig_total_lines.
8280 (Fdelete_window, delete_window): Remove. Window deletion is
8281 handled by window.el.
640c8776
SM
8282 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8283 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8284 (Fdelete_other_windows): Remove. Deleting other windows is
8285 handled by window.el.
8286 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8287 handled in window.el.
8288 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8289 Window minimum sizes are handled in window.el.
8290 (shrink_windows, size_window, set_window_height)
8291 (set_window_width, change_window_heights, window_height)
8292 (window_width, CURBEG, CURSIZE, enlarge_window)
8293 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8294 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8295 handled in window.el.
8296 (make_dummy_parent): Rename to make_parent_window and give it a
8297 second argument horflag.
8298 (make_window): Don't set resize_proportionally any more.
8299 (Fsplit_window): Remove. Windows are split in window.el.
8300 (save_restore_action, save_restore_orig_size)
8301 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8302 Resize mini windows in window.el.
8303 (grow_mini_window, shrink_mini_window): Implement by calling
8304 Qresize_root_window_vertically, resize_window_check and
8305 resize_window_apply.
640c8776
SM
8306 (saved_window, Fset_window_configuration, save_window_save):
8307 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8308 resize_proportionally.
8309 (window_min_height, window_min_width): Move to window.el.
8310 (keys_of_window): Move bindings for delete-other-windows,
8311 split-window, delete-window and enlarge-window to window.el.
8312
8313 * buffer.c: Temporarily extern Qdelete_window.
8314 (Fbury_buffer): Temporarily call Qdelete_window instead of
8315 Fdelete_window (Fbury_buffer will move to window.el soon).
8316
8317 * frame.c (set_menu_bar_lines_1): Remove code handling
8318 orig_top_line and orig_total_lines.
8319
8320 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8321 set_window_height but set heights directly.
8322 (change_frame_size_1): Use resize_frame_windows.
8323
8324 * xdisp.c (init_xdisp): Don't use set_window_height but set
8325 heights directly.
8326
640c8776
SM
8327 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8328 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8329 run_window_configuration_change_hook.
8330
8331 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8332 instead of change_window_heights and run
8333 run_window_configuration_change_hook.
8334
1a13852e
MR
83352011-06-09 Martin Rudalics <rudalics@gmx.at>
8336
8337 * window.c (replace_window): Rename second argument REPLACEMENT to
8338 NEW. New third argument SETFLAG. Rewrite.
8339 (delete_window, make_dummy_parent): Call replace_window with
8340 third argument 1.
8341 (window_list_1): Move down in code.
8342 (run_window_configuration_change_hook): Move set_buffer part
8343 before select_frame_norecord part in order to unwind correctly.
8344 Rename count1 to count.
8345 (recombine_windows, delete_deletable_window, resize_root_window)
8346 (Fdelete_other_windows_internal)
8347 (Frun_window_configuration_change_hook, make_parent_window)
8348 (resize_window_check, resize_window_apply, Fresize_window_apply)
8349 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8350 (Fdelete_window_internal, Fresize_mini_window_internal):
8351 New functions.
1a13852e
MR
8352 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8353
f3d1777e
MR
83542011-06-08 Martin Rudalics <rudalics@gmx.at>
8355
496e208e
MR
8356 * window.h (window): Add some new members to window structure -
8357 normal_lines, normal_cols, new_total, new_normal, clone_number,
8358 splits, nest, prev_buffers, next_buffers.
8359 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8360 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8361
f3d1777e
MR
8362 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8363 Remove.
496e208e
MR
8364 (make_dummy_parent): Set new members of windows structure.
8365 (make_window): Move down in code. Handle new members of window
8366 structure.
8367 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8368 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8369 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8370 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8371 (Fset_window_next_buffers, Fset_window_clone_number):
8372 New functions.
496e208e
MR
8373 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8374 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8375 Doc-string fixes.
8376 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8377 Argument WINDOW can be now internal window too.
8378 (Fwindow_use_time): Move up in code.
8379 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8380 Rewrite doc-string.
8381 (Fset_window_configuration, saved_window)
8382 (Fcurrent_window_configuration, save_window_save): Handle new
8383 members of window structure.
b9e809c2
MR
8384 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8385 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8386 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8387 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8388 Qget_mru_window, Qresize_root_window,
8389 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8390 Qauto_buffer_name; staticpro them.
f3d1777e 8391
abde8f8c
MR
83922011-06-07 Martin Rudalics <rudalics@gmx.at>
8393
8394 * window.c (Fwindow_total_size, Fwindow_left_column)
8395 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8396 (Fwindow_list_1): New functions.
8397 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8398 (Fwindow_width, Fscroll_left, Fscroll_right):
8399 Use window_body_cols instead of window_box_text_cols.
8400 (delete_window, Fset_window_configuration):
8401 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8402 (delete_all_subwindows): Take a window as argument and not a
8403 structure. Rewrite.
190b47e6
MR
8404 (window_loop): Remove handling of GET_LRU_WINDOW and
8405 GET_LARGEST_WINDOW.
8406 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8407
8408 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8409 window_box_text_cols. delete_all_subwindows now takes a
8410 Lisp_Object as argument.
abde8f8c 8411
640c8776
SM
8412 * indent.c (compute_motion, Fcompute_motion):
8413 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8414
fa8a67e6
MR
8415 * frame.c (delete_frame): Call delete_all_subwindows with root
8416 window as argument.
8417
a54e3482
DC
84182011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8419
8420 * fns.c (Fputhash): Document return value.
8421
60002bf5
CY
84222011-06-06 Chong Yidong <cyd@stupidchicken.com>
8423
8424 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8425
0c671da6 84262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8427
b862a52a 8428 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8429
be44ca6c
PE
8430 Check for overflow when converting integer to cons and back.
8431 * charset.c (Fdefine_charset_internal, Fdecode_char):
8432 Use cons_to_unsigned to catch overflow.
8433 (Fencode_char): Use INTEGER_TO_CONS.
8434 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8435 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8436 * data.c (long_to_cons, cons_to_long): Remove.
8437 (cons_to_unsigned, cons_to_signed): New functions.
8438 These signal an error for invalid or out-of-range values.
8439 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8440 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8441 * font.c (Ffont_variation_glyphs):
8442 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8443 * lisp.h: Include <intprops.h>.
8444 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8445 (cons_to_signed, cons_to_unsigned): New decls.
8446 (long_to_cons, cons_to_long): Remove decls.
8447 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8448 (Fprimitive_undo): Use CONS_TO_INTEGER.
8449 * xfns.c (Fx_window_property): Likewise.
8450 * xselect.c: Include <limits.h>.
8451 (x_own_selection, selection_data_to_lisp_data):
8452 Use INTEGER_TO_CONS.
8453 (x_handle_selection_request, x_handle_selection_clear)
8454 (x_get_foreign_selection, Fx_disown_selection_internal)
8455 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8456 (lisp_data_to_selection_data): Use cons_to_unsigned.
8457 (x_fill_property_data): Use cons_to_signed.
8458 Report values out of range.
8459
d1f3d2af
PE
8460 Check for buffer and string overflow more precisely.
8461 * buffer.h (BUF_BYTES_MAX): New macro.
8462 * lisp.h (STRING_BYTES_MAX): New macro.
8463 * alloc.c (Fmake_string):
8464 * character.c (string_escape_byte8):
8465 * coding.c (coding_alloc_by_realloc):
8466 * doprnt.c (doprnt):
8467 * editfns.c (Fformat):
8468 * eval.c (verror):
8469 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8470 since they may not be the same number.
8471 * editfns.c (Finsert_char):
8472 * fileio.c (Finsert_file_contents):
8473 Likewise for BUF_BYTES_MAX.
8474
dd52fcea
PE
8475 * image.c: Use ptrdiff_t, not int, for sizes.
8476 (slurp_file): Switch from int to ptrdiff_t.
8477 All uses changed.
8478 (slurp_file): Check that file size fits in both size_t (for
8479 malloc) and ptrdiff_t (for sanity and safety).
8480
7f9bbdbb
PE
8481 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8482 if b->modtime has its maximal value.
8483
dfe18f82
PE
8484 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8485
84acfcf0
PE
8486 Don't assume time_t can fit into int.
8487 * buffer.h (struct buffer.modtime): Now time_t, not int.
8488 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8489 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8490
ccd9a01a
PE
8491 Minor fixes for signed vs unsigned integers.
8492 * character.h (MAYBE_UNIFY_CHAR):
8493 * charset.c (maybe_unify_char):
8494 * keyboard.c (read_char, reorder_modifiers):
8495 XINT -> XFASTINT, since the integer must be nonnegative.
8496 * ftfont.c (ftfont_spec_pattern):
8497 * keymap.c (access_keymap, silly_event_symbol_error):
8498 XUINT -> XFASTINT, since the integer must be nonnegative.
8499 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8500 since it makes no difference and we prefer signed.
8501 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8502 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8503 nonnegative.
8504
d6d100dd
SM
85052011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8506
8507 * window.h (Fwindow_frame): Declare.
8508
2b6148e4
PE
85092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8510
8511 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8512 (SPARE_MEMORY): Always define.
8513 (LARGE_REQUEST): Remove.
8514 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8515
f230ecc9
MR
85162011-06-06 Martin Rudalics <rudalics@gmx.at>
8517
727e958e
MR
8518 * lisp.h: Move EXFUNS for Fframe_root_window,
8519 Fframe_first_window and Fset_frame_selected_window to window.h.
8520
8521 * window.h: Move EXFUNS for Fframe_root_window,
8522 Fframe_first_window and Fset_frame_selected_window here from
8523 lisp.h.
8524
8525 * frame.c (Fwindow_frame, Fframe_first_window)
8526 (Fframe_root_window, Fframe_selected_window)
8527 (Fset_frame_selected_window): Move to window.c.
8528 (Factive_minibuffer_window): Move to minibuf.c.
8529 (Fother_visible_frames_p): New function.
8530
8531 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8532
f230ecc9
MR
8533 * window.c (decode_window, decode_any_window): Move up in code.
8534 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8535 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8536 (Fwindow_buffer): Move up and rewrite doc-string.
8537 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8538 (Fwindow_prev): New functions.
727e958e
MR
8539 (Fwindow_frame): Move here from frame.c. Accept any window as
8540 argument.
8541 (Fframe_root_window, Fframe_first_window)
8542 (Fframe_selected_window): Move here from frame.c. Accept frame
8543 or arbitrary window as argument. Update doc-strings.
8544 (Fminibuffer_window): Move up in code.
8545 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8546 (Fset_frame_selected_window): Move here from frame.c.
8547 Marginal rewrite.
727e958e
MR
8548 (Fselected_window, select_window, Fselect_window): Move up in
8549 code. Minor doc-string fixes.
f230ecc9 8550
4d09bcf6
PE
85512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8552
8553 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8554 Do not assume that spare memory exists; that assumption is valid
8555 only if SYSTEM_MALLOC.
8556 (LARGE_REQUEST): New macro, so that the issue of large requests
8557 is separated from the issue of spare memory.
8558
810928a2
AS
85592011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8560
172418ad
AS
8561 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8562 format. (Bug#8806)
8563
43f862f7
AS
8564 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8565
810928a2
AS
8566 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8567 before statements.
8568
a059fe24
JD
85692011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8570
8571 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8572
8573 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8574
8575 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8576 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8577
989bf368
JB
85782011-06-05 Juanma Barranquero <lekktu@gmail.com>
8579
8580 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8581
4b80f674
CY
85822011-06-04 Chong Yidong <cyd@stupidchicken.com>
8583
8584 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8585 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8586 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8587 New error handlers.
4b80f674
CY
8588 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8589 Obey Vx_select_enable_clipboard_manager. Catch errors in
8590 x_clipboard_manager_save (Bug#8779).
8591 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8592 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8593
99a33b77 85942011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8595
8596 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8597
99a33b77 85982011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8599
8600 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8601 in the current matrix if keep_current_p is non-zero.
8602
8264569d
EZ
86032011-06-04 Eli Zaretskii <eliz@gnu.org>
8604
8605 * bidi.c (bidi_level_of_next_char): Fix last change.
8606
57f97249
EZ
86072011-06-03 Eli Zaretskii <eliz@gnu.org>
8608
fec2107c 8609 Support bidi reordering of text covered by display properties.
57f97249 8610
fec2107c
EZ
8611 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8612 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8613 (bidi_cache_search, bidi_cache_iterator_state)
8614 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8615 (bidi_level_of_next_char, bidi_move_to_visually_next):
8616 Support character positions inside a run of characters covered by a
fec2107c
EZ
8617 display string.
8618 (bidi_paragraph_init, bidi_resolve_explicit_1)
8619 (bidi_level_of_next_char): Call bidi_fetch_char and
8620 bidi_fetch_char_advance instead of FETCH_CHAR and
8621 FETCH_CHAR_ADVANCE.
8622 (bidi_init_it): Initialize new members.
8623 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8624 definitions.
8625 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8626 instead of using explicit *_CHAR codes.
d6d100dd
SM
8627 (bidi_resolve_explicit, bidi_resolve_weak):
8628 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8629 bidirectional text is supported only in multibyte buffers.
8630 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8631 it to initialize the frame_window_p member of struct bidi_it.
8632 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8633 (bidi_resolve_explicit, bidi_resolve_weak)
8634 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8635 bidi_it->nchars is non-positive.
8636 (bidi_level_of_next_char): Don't try to lookup the cache for the
8637 next/previous character if nothing is cached there yet, or if we
8638 were just reseat()'ed to a new position.
c40e2fb2 8639
0e14fe90
EZ
8640 * xdisp.c (set_cursor_from_row): Set start and stop points
8641 according to the row's direction when priming the loop that looks
8642 for the glyph on which to display cursor.
8643 (single_display_spec_intangible_p): Function deleted.
8644 (display_prop_intangible_p): Reimplement to call
8645 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8646 Accept 3 additional arguments needed by handle_display_spec.
8647 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8648 values: lists, `(when COND...)' forms, etc.
8649 (single_display_spec_string_p): Support property values that are
8650 lists with the argument STRING its top-level element.
8651 (display_prop_string_p): Fix the condition for processing a
8652 property that is a list to be consistent with handle_display_spec.
fec2107c 8653 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8654 last portion of handle_display_prop.
8655 (compute_display_string_pos): Accept additional argument
8656 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8657 value of a `display' property is a "replacing spec".
8658 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8659 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8660 the display property, but just return a value indicating whether
8661 the display property will replace the characters it covers.
8662 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8663 frame_window_p members of struct bidi_it.
d6d100dd
SM
8664 (compute_display_string_pos, compute_display_string_end):
8665 New functions.
fec2107c
EZ
8666 (push_it): Accept second argument POSITION, where pop_it should
8667 jump to continue iteration.
8668 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8669
fec2107c
EZ
8670 * keyboard.c (adjust_point_for_property): Adjust the call to
8671 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8672
8673 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8674 (bidi_init_it): Update prototypes.
8675 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8676 (compute_display_string_pos, compute_display_string_end):
8677 Declare prototypes.
fec2107c
EZ
8678 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8679 EMACS_INT.
fc6f18ce 8680
40087514 86812011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8682
57f53182
PE
8683 Malloc failure behavior now depends on size of allocation.
8684 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8685 * lisp.h: Change signatures accordingly.
8686 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8687 All callers changed. (Bug#8762)
8688
8689 * gnutls.c: Use Emacs's memory allocators.
8690 Without this change, the gnutls library would invoke malloc etc.
8691 directly, which causes problems on non-SYNC_INPUT hosts, and which
8692 runs afoul of improving memory_full behavior. (Bug#8761)
8693 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8694 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8695 xfree instead of the default malloc, realloc, free.
8696 (Fgnutls_boot): No need to check for memory allocation failure,
8697 since xmalloc does that for us.
8698
ac32cd99 8699 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8700 * category.c (hash_get_category_set):
8701 * ccl.c (ccl_driver):
8702 * charset.c (Fdefine_charset_internal):
8703 * charset.h (struct charset.hash_index):
8704 * composite.c (get_composition_id, gstring_lookup_cache)
8705 (composition_gstring_put_cache):
8706 * composite.h (struct composition.hash_index):
8707 * dispextern.h (struct image.hash):
8708 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8709 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8710 (hashfn_equal, hashfn_user_defined, make_hash_table)
8711 (maybe_resize_hash_table, hash_lookup, hash_put)
8712 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8713 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8714 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8715 * image.c (make_image, search_image_cache, lookup_image)
8716 (xpm_put_color_table_h):
8717 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8718 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8719 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8720 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8721 * alloc.c (allocate_vectorlike):
8722 Check for overflow in vector size calculations.
8723 * ccl.c (ccl_driver):
8724 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8725 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8726 need to be updated by these changes.
40087514
PE
8727 * fns.c (make_hash_table, maybe_resize_hash_table):
8728 Check for integer overflow with large hash tables.
0de4bb68
PE
8729 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8730 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8731 (SXHASH_REDUCE): New macro.
8732 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8733 Use it instead of discarding useful hash info with large hash values.
8734 (sxhash_float): New function.
8735 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8736 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8737 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8738 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8739 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8740 Adjust signatures to match updated version of code.
8741 (consing_since_gc): Now EMACS_INT, since a single hash table can
8742 use more than INT_MAX bytes.
8743
698d32e2
DN
87442011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8745
8746 Make it possible to build with GCC-4.6+ -O2 -flto.
8747
8748 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8749
fd6fa53f
SM
87502011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8751
8752 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8753 Call minibuffer-inactive-mode.
8754
864db017
JB
87552011-05-31 Juanma Barranquero <lekktu@gmail.com>
8756
8757 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8758 Update dependencies.
8759
2ad0baf4
DN
87602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8761
8762 * data.c (init_data): Remove code for UTS, this system is not
8763 supported anymore.
8764
4fcc2638
DN
87652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8766
8767 Don't force ./temacs to start in terminal mode.
8768
8769 * frame.c (make_initial_frame): Initialize faces in all cases, not
8770 only when CANNOT_DUMP is defined.
8771 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8772
c56e0fd5
DN
87732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8774
8775 * dispnew.c (add_window_display_history): Use const for the string
8776 pointer. Remove declaration, not needed.
8777
333d54da 87782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8779
55d4c1b2 8780 Use 'inline', not 'INLINE'.
333d54da 8781 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8782 * alloc.c, fontset.c (INLINE): Remove.
8783 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8784 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8785 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8786 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8787 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8788
738db178
DN
87892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8790
8791 Make it possible to run ./temacs.
8792
8793 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8794 syms_of_callproc does the same thing. Remove test for
8795 "initialized", do it in the caller.
8796 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8797
620c53a6
SM
87982011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8799
8800 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8801 (read_minibuf): Use get_minibuffer.
8802 (syms_of_minibuf): Use DEFSYM.
8803 (Qmetadata): New var.
8804 * data.c (Qbuffer): Don't make it static.
8805 (syms_of_data): Use DEFSYM.
8806
e003a292
PE
88072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8808
8809 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8810 (CCL_CODE_MIN): New macro.
8811
ed008a6d
PE
88122011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8813
3687c2ef
PE
8814 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8815
ed008a6d
PE
8816 * eval.c (Qdebug): Now static.
8817 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8818 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8819 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8820
d66c4c7c
CY
88212011-05-29 Chong Yidong <cyd@stupidchicken.com>
8822
8823 * image.c: Various fixes to ImageMagick code comments.
8824 (Fimagemagick_types): Doc fix.
8825
5fbc2025
PE
88262011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8827
0196f88a
PE
8828 Minor fixes prompted by GCC 4.6.0 warnings.
8829
8830 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8831
5fbc2025
PE
8832 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8833 (x_clipboard_manager_save_all): Move extern decl to ...
8834 * xterm.h: ... here, so that it can be checked for consistency.
8835
1dd3c2d9
CY
88362011-05-29 Chong Yidong <cyd@stupidchicken.com>
8837
8838 * xselect.c (x_clipboard_manager_save_frame)
8839 (x_clipboard_manager_save_all): New functions.
8840 (Fx_clipboard_manager_save): Lisp function deleted.
8841
8842 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8843 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8844
8845 * xterm.h: Update prototype.
8846
5ba6571d
WX
88472011-05-28 William Xu <william.xwl@gmail.com>
8848
8849 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8850 exiting (Bug#8239).
8851
3eaff834
JM
88522011-05-28 Jim Meyering <meyering@redhat.com>
8853
e1900994 8854 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8855 * fns.c (to_uchar): Define.
8856 (crypto_hash_function): Use it to convert some newly-signed
8857 variables to unsigned, to avoid sign-extension bugs. For example,
8858 without this change, (md5 "truc") would evaluate to
8859 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8860 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8861 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8862
0f6990a7
PE
88632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8864
8865 Integer overflow fixes.
c8a9ca5a 8866
08686060
PE
8867 * dbusbind.c: Serial number integer overflow fixes.
8868 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8869 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8870 to hold a serial number that is too large for a fixnum.
8871 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8872 Check for serial numbers out of range. Decode any serial number
59568bf0 8873 that was so large that it became a float. (Bug#8722)
08686060 8874
2d1fc3c7
PE
8875 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8876 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8877 Use XFASTINT rather than XUINT when numbers are nonnegative.
8878 (xd_append_arg, Fdbus_method_return_internal):
8879 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8880 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8881 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8882 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8883 (Bug#8722)
2d1fc3c7 8884
c8a9ca5a
PE
8885 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8886
519e1d69
PE
8887 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8888
6df6ae42 8889 ccl: Add integer overflow checks.
30569699
PE
8890 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8891 (IN_INT_RANGE): New macros.
8892 (ccl_driver): Use them to check for integer overflow when
8893 decoding a CCL program. Many of the new checks are whether XINT (x)
8894 fits in int; it doesn't always, on 64-bit hosts. The new version
8895 doesn't catch all possible integer overflows, but it's an
847044ea 8896 improvement. (Bug#8719)
30569699 8897
c11285dc
PE
8898 * alloc.c (make_event_array): Use XINT, not XUINT.
8899 There's no need for unsigned here.
8900
fdccd48e
PE
8901 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8902 This follows up to the 2011-05-06 change that substituted uintptr_t
8903 for EMACS_INT. This case wasn't caught back then.
8904
37910ab2
PE
8905 Rework Fformat to avoid integer overflow issues.
8906 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8907 now (part of C89). Include <verify.h>.
8908 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8909 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8910 (Fformat): Avoid the prepass trying to compute sizes; it was only
8911 approximate and thus did not catch overflow reliably. Instead, walk
8912 through the format just once, formatting and computing sizes as we go,
8913 checking for integer overflow at every step, and allocating a larger
8914 buffer as needed. Keep track separately whether the format is
8915 multibyte. Keep only the most-recently calculated precision, rather
8916 than them all. Record whether each argument has been converted to
8917 string. Use EMACS_INT, not int, for byte and char and arg counts.
8918 Support field widths and precisions larger than INT_MAX. Avoid
8919 sprintf's undefined behavior with conversion specifications such as %#d
8920 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8921 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8922 formatting out-of-range floating point numbers with int
9173deec 8923 formats. (Bug#8668)
37910ab2 8924
2e6578fb
PE
8925 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8926
0ae6bdee
PE
8927 * data.c: Avoid integer truncation in expressions involving floats.
8928 * data.c: Include <intprops.h>.
8929 (arith_driver): When there's an integer overflow in an expression
8930 involving floating point, convert the integers to floating point
8931 so that the resulting value does not suffer from catastrophic
8932 integer truncation. For example, on a 64-bit host (* 4
8933 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8934 Do not rely on undefined behavior after integer overflow.
8935
de883a70
PE
8936 merge count_size_as_multibyte, parse_str_to_multibyte
8937 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8938 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8939 Check for integer overflow.
8940 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8941 since it's now a duplicate of the other. This is more of
8942 a character than a buffer op, so better that it's in character.c.
8943 * fns.c, print.c: Adjust to above changes.
8944
2ff916cb
PE
89452011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8946
8947 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8948
f1b54466
PE
89492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8950
fb1ac845
PE
8951 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8952 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8953 (x_clipboard_manager_save): Now static.
8954 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8955
f1b54466
PE
8956 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8957 (crypto_hash_function): Now static.
8958 Fix pointer signedness problems. Avoid unnecessary initializations.
8959
a9f737ee
CY
89602011-05-27 Chong Yidong <cyd@stupidchicken.com>
8961
8962 * termhooks.h (Vselection_alist): Make it terminal-local.
8963
8964 * terminal.c (create_terminal): Initialize it.
8965
8966 * xselect.c: Support for clipboard managers.
8967 (Vselection_alist): Move to termhooks.h as terminal-local var.
8968 (LOCAL_SELECTION): New macro.
8969 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8970 (symbol_to_x_atom): Remove gratuitous arg.
8971 (x_handle_selection_request, lisp_data_to_selection_data)
8972 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8973 (x_own_selection, x_get_local_selection, x_convert_selection):
8974 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8975 (some_frame_on_display): Delete unused function.
8976 (Fx_own_selection_internal, Fx_get_selection_internal)
8977 (Fx_disown_selection_internal, Fx_selection_owner_p)
8978 (Fx_selection_exists_p): New optional frame arg.
8979 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8980 (x_handle_selection_clear): Don't treat other terminals with the
8981 same keyboard specially. Use the terminal-local Vselection_alist.
8982 (x_clear_frame_selections): Use Frun_hook_with_args.
8983
8984 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8985
8986 * xterm.h: Add support for those atoms.
8987
e067f0c1
CY
89882011-05-26 Chong Yidong <cyd@stupidchicken.com>
8989
8990 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8991 (converted_selections, conversion_fail_tag): New global variables.
8992 (x_selection_request_lisp_error): Free the above.
8993 (x_get_local_selection): Remove unnecessary code.
8994 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8995 of converted selections stored in converted_selections.
8996 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8997 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8998 (x_convert_selection): New function.
8999 (x_handle_selection_event): Simplify.
9000 (x_get_foreign_selection): Don't ignore incoming requests while
9001 waiting for an answer; this will fail when we implement
9002 SAVE_TARGETS, and seems unnecessary anyway.
9003 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9004 (Vx_sent_selection_functions): Doc fix.
9005
0f4aebc0
LL
90062011-05-26 Leo Liu <sdl.web@gmail.com>
9007
9008 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9009
e61124cd
YM
90102011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9011
9012 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9013
9014 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9015 for fringe update if it has periodic bitmap.
ac389d0c 9016 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9017 and fringe_bitmap_periodic_p.
9018
9019 * fringe.c (get_fringe_bitmap_data): New function.
9020 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9021 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9022 row. Mark glyph row for fringe update if periodicity changed.
9023
9024 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9025 for fringe update unless it has periodic bitmap.
9026
f16d9837
KH
90272011-05-25 Kenichi Handa <handa@m17n.org>
9028
9029 * xdisp.c (get_next_display_element): Set correct it->face_id for
9030 a static composition.
9031
e1b90ef6
LL
90322011-05-24 Leo Liu <sdl.web@gmail.com>
9033
9034 * deps.mk (fns.o):
9035 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9036
9037 * fns.c (crypto_hash_function, Fsha1): New function.
9038 (Fmd5): Use crypto_hash_function.
9039 (syms_of_fns): Add Ssha1.
9040
7400048f
PE
90412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9042
9043 * gnutls.c: Remove unused macros.
9044 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9045 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9046 Remove macros that are defined and never used.
9047 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9048
abb71cf4
CY
90492011-05-22 Chong Yidong <cyd@stupidchicken.com>
9050
9051 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9052 (Fx_get_selection_internal): Minor cleanup.
9053 (Fx_own_selection_internal): Rename arguments for consistency with
9054 select.el.
9055
6307db39
PE
90562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9057
9058 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9059
f3d4e0a4
CY
90602011-05-22 Chong Yidong <cyd@stupidchicken.com>
9061
9062 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9063
4d8ade89
YM
90642011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9065
9066 * dispnew.c (scrolling_window): Don't exclude the case that the
9067 last enabled row in the desired matrix touches the bottom boundary.
9068
32078c8d
GM
90692011-05-21 Glenn Morris <rgm@gnu.org>
9070
9071 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9072 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9073 and add some more files.
32078c8d 9074
7285dc67
EZ
90752011-05-20 Eli Zaretskii <eliz@gnu.org>
9076
9077 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9078 report_file_error introduced by the change from 2011-05-07.
9079
89d1bd22
PE
90802011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9081
9082 * systime.h (Time): Define only if emacs is defined.
9083 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9084 where the include path doesn't have X11/X.h by default. See
9085 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9086
cd394be1 90872011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9088
9089 * composite.c (find_automatic_composition): Fix previous change.
9090
b9704ad9
GM
90912011-05-20 Glenn Morris <rgm@gnu.org>
9092
9093 * lisp.mk: New file, split from Makefile.in.
9094 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9095 (shortlisp): Remove.
9096 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9097
4a720484
GM
90982011-05-19 Glenn Morris <rgm@gnu.org>
9099
9100 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9101 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9102 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9103 (lisp): Set the order to that of loadup.el.
9104 (shortlisp): Make it a copy of $lisp.
9105 (SOME_MACHINE_LISP): Remove.
9106 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9107 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9108
a28d4396
KH
91092011-05-18 Kenichi Handa <handa@m17n.org>
9110
9111 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9112 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9113 (find_automatic_composition): Mostly rewrite for efficiency.
9114
a2b1fa8e
JB
91152011-05-18 Juanma Barranquero <lekktu@gmail.com>
9116
9117 * makefile.w32-in: Update dependencies.
9118
8e1f5610
CS
91192011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9120
9121 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9122 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9123
7025ee00 91242011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9125
cdfa6eab
PE
9126 Fix some integer overflow issues, such as string length overflow.
9127
06d6db33
PE
9128 * insdel.c (count_size_as_multibyte): Check for string overflow.
9129
2b4560a8
PE
9130 * character.c (lisp_string_width): Check for string overflow.
9131 Use EMACS_INT, not int, for string indexes and lengths; in
9132 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9133 the resulting string length overflows an EMACS_INT; instead,
9134 report a string overflow if no precision given. When checking for
9135 precision exhaustion, use a check that cannot possibly have
9136 integer overflow. (Bug#8675)
9137 * character.h (lisp_string_width): Adjust to new signature.
9138
cb93f9be
PE
9139 * alloc.c (string_overflow): New function.
9140 (Fmake_string): Use it. This doesn't change behavior, but saves
9141 a few bytes and will simplify future changes.
9142 * character.c (string_escape_byte8): Likewise.
9143 * lisp.h (string_overflow): New decl.
9144
1a1f3366
PE
9145 Fixups, following up to the user-interface timestamp change.
9146 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9147 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9148 * msdos.c (mouse_get_pos): Likewise.
9149 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9150 * w32gui.h (Time): Define by including "systime.h" rather than by
9151 declaring it ourselves. (Bug#8664)
9152
d4e3e4d3
PE
9153 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9154 * image.c (clear_image_cache): Likewise.
9155
f6a24d19
PE
9156 * term.c (term_mouse_position): Don't assume time_t wraparound.
9157
08dc5ae6
PE
9158 Be more systematic about user-interface timestamps.
9159 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9160 and sometimes 'EMACS_UINT', to represent these timestamps.
9161 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9162 This makes the code easier to follow, and makes it easier to catch
9163 integer overflow bugs such as Bug#8664.
9164 * frame.c (Fmouse_position, Fmouse_pixel_position):
9165 Use Time, not unsigned long, for user-interface timestamps.
9166 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9167 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9168 * keyboard.h (last_event_timestamp): Likewise.
9169 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9170 * menu.h (xmenu_show): Likewise.
9171 * term.c (term_mouse_position): Likewise.
9172 * termhooks.h (struct input_event.timestamp): Likewise.
9173 (struct terminal.mouse_position_hook): Likewise.
9174 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9175 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9176 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9177 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9178 what it was before.
9179 * menu.h, termhooks.h: Include "systime.h", for Time.
9180
8e55734a
PE
9181 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9182 Don't assume that the difference between two unsigned long values
9183 can fit into an integer. At this point, we know button_down_time
9184 <= event->timestamp, so the difference must be nonnegative, so
9185 there's no need to cast the result if double-click-time is
9186 nonnegative, as it should be; check that it's nonnegative, just in
9187 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9188 apart (about 25 days). (Bug#8664)
8e55734a 9189
841f1b75 9190 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9191 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9192
3e26f69c
PE
9193 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9194 that always fit in int. Use a sentinel instead of a counter, to
9195 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9196 * frame.h (struct frame): Use int for menu_bar_items_used
9197 instead of EMACS_INT, since it always fits in int.
3e26f69c 9198
5cc152c0
PE
9199 * menu.c (grow_menu_items): Check for int overflow.
9200
d89eb65e
PE
9201 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9202
5235bd3e
PE
9203 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9204 Before, the code was not consistent. These values cannot exceed
9205 2**31 - 1 so there's no need to make them unsigned.
9206 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9207 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9208 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9209 as modifiers.
9210 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9211
bc827e23
PE
9212 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9213 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9214 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9215 presumably because the widths might not match.
9216
78eb494e
PE
9217 * window.c (size_window): Avoid needless test at loop start.
9218
04f2d78b
CB
92192011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9220
9221 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9222
d2fc7e3d 92232011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9224
9225 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9226
d2fc7e3d 92272011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9228
9229 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9230 `width' to `bar_area_x' and `bar_area_width', respectively.
9231 (x_scroll_run): Take account of fringe background extension.
9232
04f2d78b
CB
9233 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9234 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9235 `bar_area_width', respectively.
9236 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9237 background extension.
9238
79b70037
GM
92392011-05-10 Jim Meyering <meyering@redhat.com>
9240
9241 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9242
2f142cc5
JB
92432011-05-10 Juanma Barranquero <lekktu@gmail.com>
9244
9245 * image.c (Finit_image_library): Return t for built-in image types,
9246 like pbm and xbm. (Bug#8640)
9247
57679c86
AS
92482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9249
9250 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9251
888c9e86
EZ
92522011-05-07 Eli Zaretskii <eliz@gnu.org>
9253
b0512a1d
EZ
9254 * w32console.c (Fset_screen_color): Doc fix.
9255 (Fget_screen_color): New function.
9256 (syms_of_ntterm): Defsubr it.
9257
7285dc67
EZ
9258 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9259 unlink the temporary file if Fcall_process didn't create it in the
9260 first place.
9261 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9262 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9263 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9264 cue to call_process_cleanup not to close that handle.
9265
4d3fcc8e
BK
92662011-05-07 Ben Key <bkey76@gmail.com>
9267
9268 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9269 one of two shell specific rules, either bootstrap-temacs-CMD or
9270 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9271 to the previous implementation of the bootstrap-temacs rule.
9272 The bootstrap-temacs-CMD rule is similar to the previous
9273 implementation of the bootstrap-temacs rule except that it
9274 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9275 variable.
9276
9277 These changes, along with some changes to nt/configure.bat,
9278 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9279 earlier fix to add support for --cflags and --ldflags options
9280 that include quotes so that it works whether make uses cmd or
9281 sh as the shell.
9282
b4289b64
MA
92832011-05-06 Michael Albinus <michael.albinus@gmx.de>
9284
9285 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9286 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9287 is a constant.
9288 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9289 a string. Handle both cases.
9290 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9291 (Fdbus_register_method): Use Qinvalid_function.
9292
af4c0e28
JB
92932011-05-06 Juanma Barranquero <lekktu@gmail.com>
9294
9295 * makefile.w32-in: Update dependencies.
9296 (LISP_H): Add inttypes.h and stdin.h.
9297 (PROCESS_H): Add unistd.h.
9298
c51453d9
EZ
92992011-05-06 Eli Zaretskii <eliz@gnu.org>
9300
9301 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9302 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9303
8ff0ac3c 93042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9305
4c4b566b
PE
9306 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9307
aab2b9b5
PE
9308 * term.c (vfatal): Remove stray call to va_end.
9309 It's not needed and the C Standard doesn't allow it here anyway.
9310
c378da0b
PE
9311 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9312 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9313
288b08c7
PE
9314 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9315 bytes.
9316
e3601888
PE
9317 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9318
db6c0e74
PE
9319 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9320
dd5963ea
PE
9321 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9322
88c9450f
PE
9323 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9324
2f9442b8
PE
9325 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9326
c032b5f8
PE
9327 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9328 * charset.c (Fdefine_charset_internal): Don't initialize
9329 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9330 32-bit int (Bug#8600).
a108c10b
PE
9331
9332 * lread.c (read_integer): Be more consistent with string-to-number.
9333 Use string_to_number to do the actual conversion; this avoids
9334 rounding errors and fixes some other screwups. Without this fix,
9335 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9336 (digit_to_number): Move earlier, for benefit of read_integer.
9337 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9338 not a digit in any supported base. (Bug#8602)
a108c10b 9339
ad5f9eea
PE
9340 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9341
aec1708a
PE
9342 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9343 to match comment at start of function. This also removes a
9344 GCC warning about overflow in a 32+64-bit port.
9345
47be4ab5
PE
9346 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9347
371cac43
PE
9348 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9349 Reported by Stefan Monnier in
9350 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9351 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9352 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9353
d01a7826
PE
9354 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9355 (EMACS_UINTPTR): Likewise, with uintptr_t.
9356
7fd47d5c
PE
9357 * lisp.h: Prefer 64-bit EMACS_INT if available.
9358 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9359 on 32-bit hosts that have 64-bit int, so that they can access
9360 large files.
122b0c86
PE
9361 However, temporarily disable this change unless the temporary
9362 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9363
8727937b
PE
9364 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9365
8ac068ac
PE
9366 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9367 This removes an assumption that EMACS_INT and long are the same
9368 width as pointers. The assumption is true for Emacs porting targets
9369 now, but we want to make other targets possible.
9370 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9371 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9372 In the rest of the code, change types of integers that hold casted
9373 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9374 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9375 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9376 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9377 No need to cast type when ORing.
9378 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9379 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9380 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9381 assume EMACS_INT is the same width as char *.
9382 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9383 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9384 Remove no-longer-needed casts.
9385 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9386 (xg_tool_bar_help_callback, xg_make_tool_item):
9387 Use EMACS_INTPTR to hold an integer
9388 that will be cast to void *; this can avoid a GCC warning
9389 if EMACS_INT is not the same width as void *.
9390 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9391 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9392 (current_message_1, set_message_1):
9393 Use a local to convert to proper width without a cast.
9394 * xmenu.c (dialog_selection_callback): Likewise.
9395
ede49d71
PE
9396 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9397 Also, don't assume VALBITS / RAND_BITS is less than 5,
9398 and don't rely on undefined behavior when shifting a 1 left into
9399 the sign bit.
9400 * lisp.h (get_random): Change signature to match.
9401
2f30ecd0
PE
9402 * lread.c (hash_string): Use size_t, not int, for hash computation.
9403 Normally we prefer signed values; but hashing is special, because
9404 it's better to use unsigned division on hash table sizes so that
9405 the remainder is nonnegative. Also, size_t is the natural width
9406 for hashing into memory. The previous code used 'int', which doesn't
9407 retain enough info to hash well into very large tables.
9408 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9409
2a866e7b
PE
9410 * dbusbind.c: Don't possibly lose pointer info when converting.
9411 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9412 Use XPNTR rather than XHASH, so that the high-order bits of
9413 the pointer aren't lost when converting through void *.
9414
51639eac
PE
9415 * eval.c (Fautoload): Don't double-shift a pointer.
9416
92394119
PE
9417 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9418
dbdb9a7c
JB
94192011-05-06 Juanma Barranquero <lekktu@gmail.com>
9420
9421 * gnutls.c (DEF_GNUTLS_FN):
9422 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9423
db7a0b4f
AS
94242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9425
9426 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9427 marker. (Bug#8610)
9428
cd394be1 94292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9430
9431 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9432 New version that can reserve upto 2GB of heap space.
9433
f7ff1b0f 94342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9435
9436 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9437
639c109b
TZ
94382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9439
9440 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9441 `gnutls_certificate_set_x509_key_file'.
9442
d2127135
JB
94432011-05-05 Juanma Barranquero <lekktu@gmail.com>
9444
9445 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9446 Update dependencies.
9447
e968f4f3
JB
94482011-05-04 Juanma Barranquero <lekktu@gmail.com>
9449
9450 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9451 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9452 Remove unused parameter `fildes'.
9453 * process.c (read_process_output, send_process): Don't pass it.
9454
84d358f0
JB
94552011-05-04 Juanma Barranquero <lekktu@gmail.com>
9456
9457 Fix previous change: the library cache is defined in w32.c.
9458 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9459 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9460
0898ca10
JB
94612011-05-04 Juanma Barranquero <lekktu@gmail.com>
9462
9463 Implement dynamic loading of GnuTLS on Windows.
9464
9465 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9466 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9467 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9468 Declare.
9469
9470 * gnutls.c (Qgnutls_dll): Define.
9471 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9472 (gnutls_*): Declare function pointers.
9473 (init_gnutls_functions): New function to initialize function pointers.
9474 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9475 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9476 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9477 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9478 (emacs_gnutls_write, emacs_gnutls_read)
9479 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9480 (Fgnutls_available_p): New function.
9481 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9482 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9483 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9484
9485 * image.c: Include w32.h.
9486 (Vimage_type_cache): Delete.
9487 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9488 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9489 (w32_delayed_load): Move to w32.c.
9490
9491 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9492
9493 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9494 (w32_delayed_load): Move from image.c. When loading a library, record
9495 its filename in the :loaded-from property of the library id.
9496 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9497 Initialize and staticpro them.
9498 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9499
9500 * process.c: Include lisp.h before w32.h, not after.
9501 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9502 instead of gnutls_record_check_pending.
9503
9504 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9505
ff4de4aa
TZ
95062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9507
9508 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9509 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9510 as passed in.
9511
abe95abb
JD
95122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9513
9514 * xterm.c (x_set_frame_alpha): Do not set property on anything
9515 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9516
e16e55d4
JB
95172011-05-02 Juanma Barranquero <lekktu@gmail.com>
9518
9519 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9520
bafcf6a5
JB
95212011-05-02 Juanma Barranquero <lekktu@gmail.com>
9522
9523 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9524 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9525 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9526 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9527 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9528 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9529 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9530 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9531 (Qgnutls_bootprop_callbacks_verify): Make static.
9532
e7a6747f
AS
95332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9534
19ed11ba
AS
9535 * callproc.c: Indentation fixup.
9536
e7a6747f 9537 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9538 (wait_for_termination, interruptible_wait_for_termination):
9539 Move after wait_for_termination_1.
e7a6747f 9540
1ef14cb4
LMI
95412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9542
9543 * sysdep.c (interruptible_wait_for_termination): New function
9544 which is like wait_for_termination, but allows keyboard
9545 interruptions.
9546
9547 * callproc.c (Fcall_process): Add (:file "file") as an option for
9548 the STDOUT buffer.
9549 (Fcall_process_region): Ditto.
9550
330d880c
EZ
95512011-04-30 Eli Zaretskii <eliz@gnu.org>
9552
8db90b73
EZ
9553 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9554 rather than `XVECTOR (FOO)->size'.
9555
330d880c
EZ
9556 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9557 inttypes.h, as a gnulib replacement is used if it not available in
9558 system headers.
9559
15cbd324
EZ
95602011-04-21 Eli Zaretskii <eliz@gnu.org>
9561
9562 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9563 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9564 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9565
9566 * coding.c (coding_alloc_by_realloc): Error out if destination
9567 will grow beyond MOST_POSITIVE_FIXNUM.
9568 (decode_coding_emacs_mule): Abort if there isn't enough place in
9569 charbuf for the composition carryover bytes. Reserve an extra
9570 space for up to 2 characters produced in a loop.
9571 (decode_coding_iso_2022): Abort if there isn't enough place in
9572 charbuf for the composition carryover bytes.
9573
95742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9575
ae940cca
EZ
9576 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9577 aborting when %lld or %lll format is passed.
9578 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9579 %llo or %llx format is passed. (Bug#8545)
9580
03ab8921
EZ
9581 * window.c (window_scroll_line_based): Use a marker instead of
9582 simple variables to record original value of point. (Bug#7952)
9583
afda1437
EZ
9584 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9585 produced by %s or %c overflows available buffer space. (Bug#8545)
9586
f76dee0c
PE
95872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9588
9589 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9590 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9591
fdc5744d
JB
95922011-04-28 Juanma Barranquero <lekktu@gmail.com>
9593
9594 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9595
638f053a
JB
95962011-04-28 Juanma Barranquero <lekktu@gmail.com>
9597
9598 * keyboard.c (Qdelayed_warnings_hook): Define.
9599 (command_loop_1): Run `delayed-warnings-hook'
9600 if Vdelayed_warnings_list is non-nil.
9601 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9602 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9603
d178f871
EZ
96042011-04-28 Eli Zaretskii <eliz@gnu.org>
9605
9606 * doprnt.c (doprnt): Don't return value smaller than the buffer
9607 size if the message was truncated. (Bug#8545).
9608
b124fd93
JB
96092011-04-28 Juanma Barranquero <lekktu@gmail.com>
9610
9611 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9612 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9613
e810457d
PE
96142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9615
9616 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9617
ea51cceb
JB
96182011-04-27 Juanma Barranquero <lekktu@gmail.com>
9619
9620 * makefile.w32-in: Update dependencies.
9621
94dcfacf
EZ
96222011-04-27 Eli Zaretskii <eliz@gnu.org>
9623
9624 Improve `doprnt' and its usage. (Bug#8545)
9625 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9626 `format_end'. Remove support for %l as a conversion specifier.
9627 Don't use xrealloc. Improve diagnostics when the %l size modifier
9628 is used. Update the commentary.
9629
9630 * eval.c (verror): Simplify calculation of size_t.
9631
9632 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9633 messages.
9634
f61f41d7
PE
96352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9636
9637 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9638 change.
9639
96fb4434
PE
96402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9641
9642 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9643 This makes this file independent of the recent pseudovector change.
9644
671875da 96452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9646
69e9b5a3
PE
9647 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9648
b5f869a7 9649 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9650 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9651 Remove unused local.
c8926152 9652 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9653
841a1577 9654 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9655 GCC 4.6.0 optimizes based on type-based alias analysis.
9656 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9657 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9658 != &v->size, and therefore "v->size = 1; b->size = 2; return
9659 v->size;" must therefore return 1. This assumption is incorrect
9660 for Emacs, since it type-puns struct Lisp_Vector * with many other
9661 types. To fix this problem, this patch adds a new type struct
f904488f 9662 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9663 and pseudovectors, and helps optimizing compilers not get fooled
9664 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9665 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9666 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9667 the size member.
eab3844f
PE
9668 (XSETPVECTYPE): Rewrite in terms of new macro.
9669 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9670 This is a bit clearer, and further avoids the possibility of
9671 undesirable aliasing.
9672 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9673 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9674 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9675 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9676 (ASIZE): Now uses header.size rather than size.
9677 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9678 to avoid the hassle of writing XVECTOR (foo)->header.size.
9679 (struct vectorlike_header): New type.
eab3844f
PE
9680 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9681 object, to help avoid aliasing.
9682 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9683 (SUBRP): Likewise, since Lisp_Subr is a special case.
9684 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9685 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9686 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9687 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9688 changed to be "header.size" and "header.next".
9689 * buffer.h (struct buffer): Likewise.
9690 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9691 * frame.h (struct frame): Likewise.
9692 * process.h (struct Lisp_Process): Likewise.
9693 * termhooks.h (struct terminal): Likewise.
9694 * window.c (struct save_window_data, struct saved_window): Likewise.
9695 * window.h (struct window): Likewise.
9696 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9697 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9698 * buffer.c (init_buffer_once): Likewise.
9699 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9700 special case.
9701 * process.c (Fformat_network_address): Use local var for size,
9702 for brevity.
9703
0df1eac5
PE
9704 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9705
847ab9d1 9706 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9707 * data.c (atof): Remove decl; no longer used or needed.
9708 (digit_to_number): Move to lread.c.
9709 (Fstring_to_number): Use new string_to_number function, to be
9710 consistent with how the Lisp reader treats infinities and NaNs.
9711 Do not assume that floating-point numbers represent EMACS_INT
9712 without losing information; this is not true on most 64-bit hosts.
9713 Avoid double-rounding errors, by insisting on integers when
9714 parsing non-base-10 numbers, as the documentation specifies.
9715 * lisp.h (string_to_number): New decl, replacing ...
9716 (isfloat_string): Remove.
bc0a5c13 9717 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9718 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9719 appears to have been a coding error. Similarly, do not accept
9720 strings like +-1e0 as floating point numbers. Do not report
9721 overflow for integer overflows unless the base is not 10 which
9722 means we have no simple and reliable way to continue.
9723 Break out the floating-point parsing into a new
9724 function string_to_number, so that Fstring_to_number parses
9725 floating point numbers consistently with the Lisp reader.
04f2d78b 9726 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9727 (E_CHAR, EXP_INT): Remove, replacing with ...
9728 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9729 (string_to_number): New function, replacing isfloat_string.
9730 This function checks for valid syntax and produces the resulting
9731 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9732 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9733 so that overflow for non-base-10 numbers is reported only when
9734 there's no portable and simple way to convert to floating point.
452f4150 9735
67769ffc
PE
9736 * textprop.c (set_text_properties_1): Rewrite for clarity,
9737 and to avoid GCC warning about integer overflow.
9738
c20db43f
PE
9739 * intervals.h (struct interval): Use EMACS_INT for members
9740 where EMACS_UINT might cause problems. See
9741 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9742 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9743 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9744 All uses changed.
37aa2f85
PE
9745 (offset_intervals): Tell GCC not to worry about length overflow
9746 when negating a negative length.
c20db43f 9747
2538aa2f
PE
9748 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9749 (overrun_check_free): Likewise.
9750
f2d3008d
PE
9751 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9752 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9753 word size.
9754
ec8df744
PE
9755 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9756 (gnutls_make_error): Rename local to avoid shadowing.
9757 (gnutls_emacs_global_deinit): ifdef out; not used.
9758 (Fgnutls_boot): Use const for pointer to readonly storage.
9759 Comment out unused local. Fix pointer signedness problems.
9760
640ee02d
PE
9761 * lread.c (openp): Don't stuff size_t into an 'int'.
9762 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9763 about possible signed overflow.
9764
6048fb2a
PE
9765 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9766 (GDK_KEY_g): Don't define if already defined.
9767 (xg_prepare_tooltip): Avoid pointer signedness problem.
9768 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9769
fa3c87e1
PE
9770 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9771 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9772
2172544b
PE
9773 * xfns.c (Fx_window_property): Simplify a bit,
9774 to make a bit faster and to avoid GCC 4.6.0 warning.
9775 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9776
9b821a21
PE
9777 * fns.c (internal_equal): Don't assume size_t fits in int.
9778
3c616cfa
PE
9779 * alloc.c (compact_small_strings): Tighten assertion a little.
9780
c2982e87
PE
9781 Replace pEd with more-general pI, and fix some printf arg casts.
9782 * lisp.h (pI): New macro, generalizing old pEd macro to other
9783 conversion specifiers. For example, use "...%"pI"d..." rather
9784 than "...%"pEd"...".
9785 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9786 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9787 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9788 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9789 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9790 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9791 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9792 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9793 64-bit hosts.
9794 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9795 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9796 * print.c (safe_debug_print, print_object): Likewise.
9797 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9798 to int.
6f04d126
PE
9799 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9800 avoiding the 0 flag, which is not portable.
c2982e87
PE
9801 * process.c (Fmake_network_process): Use pI to avoid cast.
9802 * region-cache.c (pp_cache): Likewise.
9803 * xdisp.c (decode_mode_spec): Likewise.
9804 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9805 behavior on 64-bit hosts with printf arg.
6f04d126 9806 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9807 (x_stop_queuing_selection_requests): Likewise.
9808 (x_get_window_property): Don't truncate byte count to an 'int'
9809 when tracing.
0b432f21 9810
5e073ec7
PE
9811 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9812 here, since it parses constructs like leading '-' and spaces,
9813 which are not wanted; and it overflows with large numbers.
9814 Instead, simply match F[0-9]+, which is what is wanted anyway.
9815
36372bf9
PE
9816 * alloc.c: Remove unportable assumptions about struct layout.
9817 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9818 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9819 (allocate_vectorlike, make_pure_vector): Use the new macros,
9820 plus offsetof, to remove unportable assumptions about struct layout.
9821 These assumptions hold on all porting targets that I know of, but
9822 they are not guaranteed, they're easy to remove, and removing them
9823 makes further changes easier.
9824
0b432f21
PE
9825 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9826 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9827 (string_overrun_cookie): Now const. Use initializers that
9828 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9829 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9830 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9831 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9832 multiple of sizeof (EMACS_INT); it need not be, if
9833 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9834 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9835
895009e1
JB
98362011-04-26 Juanma Barranquero <lekktu@gmail.com>
9837
9838 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9839
6a7a1b0b
TZ
98402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9841
9842 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9843 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9844 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9845
841a1577 98462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9847
9848 * lisp.h (Qdebug): List symbol.
895009e1 9849 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9850 * keyboard.c (debug-on-event): New variable.
9851 (handle_user_signal): Break into debugger when debug-on-event
9852 matches the current signal symbol.
9853
f2d3ba6f
DN
98542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9855
9856 * alloc.c (check_sblock, check_string_bytes)
9857 (check_string_free_list): Convert to standard C.
9858
42ce4c63
TZ
98592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9860
9861 * w32.c (emacs_gnutls_push): Fix typo.
9862
825cd63c
EZ
98632011-04-25 Eli Zaretskii <eliz@gnu.org>
9864
fb11d64d
EZ
9865 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9866 "cast to pointer from integer of different size".
9867
825cd63c
EZ
9868 Improve doprnt and its use in verror. (Bug#8545)
9869 * doprnt.c (doprnt): Document the set of format control sequences
9870 supported by the function. Use SAFE_ALLOCA instead of always
9871 using `alloca'.
9872
9873 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9874 is one byte too soon. Don't use xrealloc; instead xfree and
9875 xmalloc anew.
9876
e061a11b
TZ
98772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9878
9879 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9880 callbacks stage.
9881
9882 * gnutls.c: Renamed global_initialized to
9883 gnutls_global_initialized. Added internals for the
9884 :verify-hostname-error, :verify-error, and :verify-flags
9885 parameters of `gnutls-boot' and documented those parameters in the
9886 docstring. Start callback support.
9173deec
JB
9887 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9888 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9889 on error. Return error code.
e061a11b
TZ
9890 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9891 (emacs_gnutls_read): Likewise.
9892 (Fgnutls_boot): Return handshake error code.
9893 (emacs_gnutls_handle_error): New function.
9894 (wsaerror_to_errno): Likewise.
9895
9896 * w32.h (emacs_gnutls_pull): Add prototype.
9897 (emacs_gnutls_push): Likewise.
9898
9899 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9900 (emacs_gnutls_push): Likewise.
9901
99022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9903
9904 * process.c (wait_reading_process_output): Check if GnuTLS
9905 buffered some data internally if no FDs are set for TLS
9906 connections.
9907
9908 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9909 (LIBS): Link to USER_LIBS.
9910 ($(BLD)/gnutls.$(0)): New target.
9911
fa6996bc
EZ
99122011-04-24 Eli Zaretskii <eliz@gnu.org>
9913
eb35682e
EZ
9914 * xdisp.c (handle_single_display_spec): Rename the
9915 display_replaced_before_p argument into display_replaced_p, to
9916 make it consistent with the commentary. Fix typos in the
9917 commentary.
9918
e2ad650c
EZ
9919 * textprop.c (syms_of_textprop): Remove dead code.
9920 (copy_text_properties): Delete obsolete commentary about an
9921 interface that was deleted long ago. Fix typos in the description
9922 of arguments.
9923
1b2de274
EZ
9924 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9925 to changes in oldXMenu/XMenu.h from 2011-04-16.
9926 <menu_help_message, prev_menu_help_message>: Constify.
9927 (IT_menu_make_room): menu->help_text is now `const char **';
9928 adjust.
9929
9930 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9931 to changes in oldXMenu/XMenu.h from 2011-04-16.
9932 (struct XMenu): Declare `help_text' `const char **'.
9933
9934 * xfaces.c <Qunspecified>: Make extern again.
9935
9936 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9937 required by POSIX.
1b2de274 9938
762b15be
EZ
9939 * doc.c (get_doc_string): Improve the format passed to `error'.
9940
9941 * doprnt.c (doprnt): Improve commentary.
9942
9943 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9944
9945 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9946 them with etags.
9947
f1052e5d
EZ
9948 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9949 changes in globals.h immediately force recompilation.
762b15be
EZ
9950 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9951 $(CURDIR)/s/ms-w32.h.
9952 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9953
fa6996bc
EZ
9954 * character.c (Fchar_direction): Function deleted.
9955 (syms_of_character): Don't defsubr it.
9956 <char-direction-table>: Deleted.
9957
e6c3da20
EZ
99582011-04-23 Eli Zaretskii <eliz@gnu.org>
9959
9960 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9961 * doprnt.c: Include limits.h.
9962 (SIZE_MAX): New macro.
04f2d78b
CB
9963 (doprnt): Return a size_t value. 2nd arg is now size_t.
9964 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9965 Improve overflow protection. Support `l' modifier for integer
9966 conversions. Support %l conversion. Don't assume an EMACS_INT
9967 argument for integer conversions and for %c.
9968
9969 * lisp.h (doprnt): Restore prototype.
9970
9971 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9972 $(SRC)/character.h.
9973
9974 * Makefile.in (base_obj): Add back doprnt.o.
9975
9976 * deps.mk (doprnt.o): Add back prerequisites.
9977 (callint.o): Depend on character.h.
9978
9979 * eval.c (internal_lisp_condition_case): Include the handler
9980 representation in the error message.
9981 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9982 when breaking from the loop.
9983
9984 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9985
9986 * callint.c (Fcall_interactively): When displaying error message
9987 about invalid control letter, pass the character's codepoint, not
9988 a pointer to its multibyte form. Improve display of the character
9989 in octal and display also its hex code.
9990
9991 * character.c (char_string): Use %x to display the (unsigned)
9992 codepoint of an invalid character, to avoid displaying a bogus
9993 negative value.
9994
9995 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9996 `error', not SYMBOL_NAME itself.
9997
9998 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9999 character arguments to `error'.
10000
10001 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10002 to `error' in error message about FINAL_CHAR argument. Make sure
10003 FINAL_CHAR is a character, and use %c when it is passed as
10004 argument to `error'.
10005
4ffd0d6b 100062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10007
10008 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10009
10010 * w32.c: Include <time.h>.
10011 (sys_localtime): New function.
10012
4ffd0d6b 100132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10014
10015 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10016
4ffd0d6b 10017 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10018
4ffd0d6b 100192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10020
4ffd0d6b
GM
10021 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10022 zombies (Bug#8467).
aac0c6e3 10023
04c56954
EZ
100242011-04-19 Eli Zaretskii <eliz@gnu.org>
10025
10026 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10027 gl_state.e_property when gl_state.object is Qt.
10028
10029 * insdel.c (make_gap_larger): Remove limitation of buffer size
10030 to <= INT_MAX.
10031
16a43933
CY
100322011-04-18 Chong Yidong <cyd@stupidchicken.com>
10033
10034 * xdisp.c (lookup_glyphless_char_display)
10035 (produce_glyphless_glyph): Handle cons cell entry in
10036 glyphless-char-display.
10037 (Vglyphless_char_display): Document it.
10038
10039 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10040 glyphless-char-display.
10041
4581706e
CY
100422011-04-17 Chong Yidong <cyd@stupidchicken.com>
10043
10044 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10045
10046 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10047
10048 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10049 definition for no-X builds.
10050
4887c6e2 100512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10052
fd35b6f9
PE
10053 Static checks with GCC 4.6.0 and non-default toolkits.
10054
5c1ccb01
PE
10055 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10056
006c5daa
PE
10057 * process.c (keyboard_bit_set): Define only if SIGIO.
10058 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10059 (send_process): Repair possible setjmp clobbering.
10060
efc736d3
PE
10061 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10062
4e2fe2e6
PE
10063 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10064
f97334a2
PE
10065 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10066
4e75f29d
PE
10067 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10068 Define only if needed.
10069
90efadd1
PE
10070 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10071 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10072 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10073
3c647824
PE
10074 * dispextern.h (struct redisplay_interface): Rename param
10075 to avoid shadowing.
e264f262 10076 * termhooks.h (struct terminal): Likewise.
761383f4 10077 * xterm.c (xembed_send_message): Likewise.
3c647824 10078
b58c5c4a
PE
10079 * insdel.c (make_gap_smaller): Define only if
10080 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10081
cad59032
PE
10082 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10083 it.
10084
c339dc2e
PE
10085 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10086 so that we aren't warned about unused symbols.
10087
91a3e27b
PE
10088 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10089
399c71d3 10090 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10091
8ffc96f5
PE
10092 * xfns.c (x_real_positions): Mark locals as initialized.
10093
eef9bc79
PE
10094 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10095
098db9dd
PE
10096 * xterm.c: Fix problems found by static analysis with other toolkits.
10097 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10098 (x_dispatch_event): Declare static if USE_GTK, and
10099 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10100 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10101 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10102 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10103 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10104
eb18f6cc
PE
10105 * xmenu.c (menu_help_callback): Pointer type fixes.
10106 Use const pointers when pointing at readonly data. Avoid pointer
10107 signedness clashes.
10108 (FALSE): Remove unused macro.
10109 (update_frame_menubar): Remove unused decl.
10110
1fe72bf8
PE
10111 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10112
60d9e1db
PE
10113 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10114 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10115 (single_menu_item): Rename local to avoid shadowing.
10116
39261c26
PE
10117 * keyboard.c (make_lispy_event): Remove unused local var.
10118
018c5e19
PE
10119 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10120 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10121
63d2b86e
PE
10122 * bitmaps: Change bitmaps from unsigned char back to the X11
10123 compatible char. Avoid the old compiler warnings about
10124 out-of-range initializers by using, for example, '\xab' rather
10125 than 0xab.
10126
aefd87e1
PE
10127 * xgselect.c (xgselect_initialize): Check vs interface
10128 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10129
bf501fb9
PE
10130 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10131
e9829fdf
PE
10132 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10133 to read-only memory.
10134
1086c095
PE
10135 * fns.c (vector): Remove; this old hack is no longer needed.
10136
2baccd04 10137 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10138 Remove unused var.
dde42981 10139 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10140
72391843 10141 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10142
436c16df 10143 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10144 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10145 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10146
92bb796d 10147 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10148 (x_term_init): Remove local to avoid shadowing.
92bb796d 10149
764430a3 10150 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10151
10152 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10153 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10154
d1dfb56c
EZ
101552011-04-16 Eli Zaretskii <eliz@gnu.org>
10156
c4354cb4
EZ
10157 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10158
d1dfb56c
EZ
10159 Fix regex.c, syntax.c and friends for buffers > 2GB.
10160 * syntax.h (struct gl_state_s): Declare character position members
10161 EMACS_INT.
10162
10163 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10164
04f2d78b
CB
10165 * textprop.c (verify_interval_modification, interval_of):
10166 Declare arguments EMACS_INT.
d1dfb56c
EZ
10167
10168 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10169 EMACS_INT.
10170
10171 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10172
10173 * indent.c (Fvertical_motion): Local variable it_start is now
10174 EMACS_INT.
10175
10176 * regex.c (re_match, re_match_2, re_match_2_internal)
10177 (bcmp_translate, regcomp, regexec, print_double_string)
10178 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10179 (re_compile_pattern, re_exec): Declare arguments and local
10180 variables `size_t' and `ssize_t' and return values `regoff_t', as
10181 appropriate.
10182 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10183 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10184 <compile_stack_type>: `size' and `avail' are now `size_t'.
10185
10186 * regex.h <regoff_t>: Use ssize_t, not int.
10187 (re_search, re_search_2, re_match, re_match_2): Arguments that
10188 specify buffer/string position and length are now ssize_t and
10189 size_t. Return type is regoff_t.
10190
613052cd
BK
101912011-04-16 Ben Key <bkey76@gmail.com>
10192
10193 * nsfont.m: Fixed bugs in ns_get_family and
10194 ns_descriptor_to_entity that were caused by using free to
10195 deallocate memory blocks that were allocated by xmalloc (via
10196 xstrdup). This caused Emacs to crash when compiled with
10197 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10198 --enable-checking=xmallocoverrun). xfree is now used to
10199 deallocate these memory blocks.
10200
4170f62f 102012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10202
71b41406
PE
10203 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10204
9587a89d
PE
10205 emacs_write: Accept and return EMACS_INT for sizes.
10206 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10207 et seq.
10208 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10209 Accept and return EMACS_INT.
10210 (emacs_gnutls_write): Return the number of bytes written on
10211 partial writes.
10212 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10213 (emacs_read, emacs_write): Remove check for negative size, as the
10214 Emacs source code has been audited now.
9587a89d
PE
10215 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10216 (emacs_read, emacs_write): Use it.
273a5f82
PE
10217 * process.c (send_process): Adjust to the new signatures of
10218 emacs_write and emacs_gnutls_write. Do not attempt to store
10219 a byte offset into an 'int'; it might overflow.
9587a89d 10220 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10221
3e047f51
PE
10222 * sound.c: Don't assume sizes fit in 'int'.
10223 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10224 Return EMACS_INT, not int.
3e047f51 10225 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10226 Accept EMACS_INT, not int.
10227 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10228 record read return values.
10229
cc39a9db
BK
102302011-04-15 Ben Key <bkey76@gmail.com>
10231
c9d0ec6d
JB
10232 * keyboard.c (Qundefined): Don't declare static since it is used
10233 in nsfns.m.
10234 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10235 static since they are used in nsfont.m.
cc39a9db 10236
6c60eb9f
SM
102372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10238
10239 * process.c (Qprocessp): Don't declare static.
10240 * lisp.h (Qprocessp): Declare again.
10241
7990b61a
JB
102422011-04-15 Juanma Barranquero <lekktu@gmail.com>
10243
10244 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10245
5d4cb038
PE
102462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10247
8bd7b830 10248 Improve C-level modularity by making more things 'static'.
cd64ea1d 10249
e3b27b31
PE
10250 Don't publish debugger-only interfaces to other modules.
10251 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10252 (verify_bytepos, count_markers): Move decls to the only modules
10253 that need them.
10254 * region-cache.h (pp_cache): Likewise.
10255 * window.h (check_all_windows): Likewise.
10256 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10257
5d4cb038
PE
10258 * sysdep.c (croak): Now static, if
10259 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10260 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10261
10262 * alloc.c (refill_memory_reserve): Now static if
10263 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10264 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10265
e87b6180
PE
10266 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10267 Define only if USE_LUCID.
10268
ac64929e
PE
10269 * xrdb.c (x_customization_string, x_rm_string): Now static.
10270
6f37259d
PE
10271 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10272 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10273
1683e3ab
PE
10274 * xdisp.c (draw_row_with_mouse_face): Now static.
10275 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10276
de9c2632
PE
10277 * window.h (check_all_windows): Mark externally visible.
10278
2b96acb7
PE
10279 * window.c (window_deletion_count): Now static.
10280
10281 * undo.c: Make symbols static if they're not exported.
10282 (last_undo_buffer, last_boundary_position, pending_boundary):
10283 Now static.
10284
50436f33
PE
10285 * textprop.c (interval_insert_behind_hooks): Now static.
10286 (interval_insert_in_front_hooks): Likewise.
10287
64520e5c
PE
10288 * term.c: Make symbols static if they're not exported.
10289 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10290 (max_frame_lines, tty_set_terminal_modes):
10291 (tty_reset_terminal_modes, tty_turn_off_highlight):
10292 (get_tty_terminal): Now static.
10293 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10294 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10295 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10296 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10297 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10298
1fa53021
PE
10299 * sysdep.c: Make symbols static if they're not exported.
10300 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10301 Now static.
10302 (sigprocmask_set, full_mask): Remove; unused.
10303 (wait_debugging): Mark as visible.
10304 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10305 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10306
d4b43b22
PE
10307 * syntax.c (syntax_temp): Define only if !__GNUC__.
10308
b7c513d0
PE
10309 * sound.c (current_sound_device, current_sound): Now static.
10310
989b29ad
PE
10311 * search.c (searchbufs, searchbuf_head): Now static.
10312
13a55a78
PE
10313 * scroll.c (scroll_cost): Remove; unused.
10314 * dispextern.h (scroll_cost): Remove decl.
10315
de68a1fc
PE
10316 * region-cache.h (pp_cache): Mark as externally visible.
10317
40ccffa6
PE
10318 * process.c: Make symbols static if they're not exported.
10319 (process_tick, update_tick, create_process, chan_process):
10320 (Vprocess_alist, proc_buffered_char, datagram_access):
10321 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10322 (deactivate_process): Mark defn as static, as well as decl.
10323 * lisp.h (create_process): Remove decl.
10324 * process.h (chan_process, Vprocess_alist): Remove decls.
10325
ad64fc97
PE
10326 * print.c: Make symbols static if they're not exported.
10327 (print_depth, new_backquote_output, being_printed, print_buffer):
10328 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10329 (print_interval, print_number_index, initial_stderr_stream):
10330 Now static.
10331 * lisp.h (Fprinc): Remove decl.
10332 (debug_output_compilation_hack): Mark as externally visible.
10333
adddb265
PE
10334 * sysdep.c (croak): Move decl from here to syssignal.h.
10335 * syssignal.h (croak): Put it here, so the API can be checked when
10336 'croak' is called from dissociate_if_controlling_tty.
10337
1717ede2
PE
10338 * minibuf.c: Make symbols static if they're not exported.
10339 (minibuf_save_list, choose_minibuf_frame): Now static.
10340 * lisp.h (choose_minibuf_frame): Remove decl.
10341
fa5fb2bc
PE
10342 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10343
1e3890d1
PE
10344 * lread.c: Make symbols static if they're not exported.
10345 (read_objects, initial_obarray, oblookup_last_bucket_number):
10346 Now static.
10347 (make_symbol): Remove; unused.
10348 * lisp.h (initial_obarray, make_symbol): Remove decls.
10349
8a1414fa
PE
10350 * keyboard.c: Make symbols static if they're not exported.
10351 (single_kboard, recent_keys_index, total_keys, recent_keys):
10352 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10353 (this_single_command_key_start, echoing, last_auto_save):
10354 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10355 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10356 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10357 (Vlispy_mouse_stem, double_click_count):
10358 Now static.
10359 (force_auto_save_soon): Define only if SIGDANGER.
10360 (ignore_mouse_drag_p): Now static if
10361 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10362 (print_help): Remove; unused.
10363 (stop_character, last_timer_event): Mark as externally visible.
10364 * keyboard.h (ignore_mouse_drag_p): Declare only if
10365 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10366 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10367 * lisp.h (echoing): Remove decl.
10368 (force_auto_save_soon): Declare only if SIGDANGER.
10369 * xdisp.c (redisplay_window): Simplify code, to make it more
10370 obvious that ignore_mouse_drag_p is not accessed if !defined
10371 USE_GTK && !defined HAVE_NS.
10372
93ea6e8f
PE
10373 * intervals.c: Make symbols static if they're not exported.
10374 (merge_properties_sticky, merge_interval_right, delete_interval):
10375 Now static.
10376 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10377
77382fcc
PE
10378 * insdel.c: Make symbols static if they're not exported.
10379 However, leave prepare_to_modify_buffer alone. It's never
10380 called from outside this function, but that appears to be a bug.
10381 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10382 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10383 (adjust_after_replace_noundo): Remove; unused.
10384 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10385 (signal_before_change): Remove decls.
77382fcc 10386
9306c32e
PE
10387 * indent.c (val_compute_motion, val_vmotion): Now static.
10388
cd44d2eb
PE
10389 * image.c: Make symbols static if they're not exported.
10390 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10391 if USE_GTK.
10392 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10393 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10394
ad9a7a06
PE
10395 * fringe.c (standard_bitmaps): Now static.
10396 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10397
81626931
PE
10398 * frame.c: Make symbols static if they're not exported.
10399 (x_report_frame_params, make_terminal_frame): Now static.
10400 (get_frame_param): Now static, unless HAVE_NS.
10401 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10402 (x_get_resource_string): Remove; not used.
10403 * frame.h (make_terminal_frame, x_report_frame_params):
10404 (x_get_resource_string); Remove decls.
10405 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10406 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10407
239f9db9
PE
10408 * font.c, fontset.c: Make symbols static if they're not exported.
10409 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10410 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10411 * font.c (font_close_object): Now static.
10412 * font.h (font_close_object): Remove.
10413 * fontset.c (FONTSET_OBJLIST): Remove.
10414 (free_realized_fontset) #if-0 the body, which does nothing.
10415 (face_suitable_for_char_p): #if-0, as it's never called.
10416 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10417 * xfaces.c (face_at_string_position):
10418 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10419 since 0 is always ASCII.
10420
dfcf3579
PE
10421 * fns.c (weak_hash_tables): Now static.
10422
5045092b
PE
10423 * fileio.c: Make symbols static if they're not exported.
10424 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10425 (Vwrite_region_annotation_buffers): Now static.
10426
57a96f5c
PE
10427 * eval.c: Make symbols static if they're not exported.
10428 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10429 * lisp.h (backtrace_list): Remove decl.
10430
35f08c38
PE
10431 * emacs.c: Make symbols static if they're not exported.
10432 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10433 (fatal_error_code, fatal_error_signal_hook, standard_args):
10434 Now static.
10435 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10436 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10437 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10438 * lisp.h (fatal_error_signal_hook): Remove decl.
10439 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10440
f44bd759
PE
10441 * editfns.c: Move a (normally-unused) function to its only use.
10442 * editfns.c, lisp.h (get_operating_system_release): Remove.
10443 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10444 worth the hassle of breaking this out.
10445
b532497d
PE
10446 * xterm.c: Make symbols static if they're not exported.
10447 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10448 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10449 (x_destroy_window, x_delete_display):
10450 Now static.
10451 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10452 (x_mouse_leave): Remove; unused.
10453 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10454 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10455 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10456 Remove decls.
10457 (x_mouse_leave): Declare only if WINDOWSNT.
10458 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10459 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10460 USE_X_TOOLKIT.
10461
1675728f
PE
10462 * ftxfont.c: Make symbols static if they're not exported.
10463 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10464 HAVE_FREETYPE.
10465 * font.h (ftxfont_driver): Likewise.
10466
e4cebfca
PE
10467 * xfns.c: Make symbols static if they're not exported.
10468 (x_last_font_name, x_display_info_for_name):
10469 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10470 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10471 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10472 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10473 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10474 (last_show_tip_args): Now static.
10475 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10476 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10477 (x_screen_planes): Remove; unused.
10478 * dispextern.h (x_screen_planes): Remove decl.
10479
5bf46f05
PE
10480 * dispnew.c: Make symbols static if they're not exported.
10481 * dispextern.h (redraw_garbaged_frames, scrolling):
10482 (increment_row_positions): Remove.
10483 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10484 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10485 Now static.
10486 (redraw_garbaged_frames): Remove; unused.
10487
435f4c28
PE
10488 * xfaces.c: Make symbols static if they're not exported.
10489 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10490 Remove decls.
10491 * xterm.h (defined_color): Remove decls.
10492 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10493 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10494 (menu_face_changed_default, defined_color, free_realized_face):
10495 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10496 (ascii_face_of_lisp_face): Remove; unused.
10497
8524aef3
PE
10498 * xdisp.c: Make symbols static if they're not exported.
10499 * dispextern.h (scratch_glyph_row, window_box_edges):
10500 (glyph_to_pixel_coords, set_cursor_from_row):
10501 (get_next_display_element, set_iterator_to_next):
10502 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10503 (show_mouse_face): Remove decls
10504 * frame.h (message_buf_print): Likewise.
10505 * lisp.h (pop_message, set_message, check_point_in_composition):
10506 Likewise.
10507 * xterm.h (set_vertical_scroll_bar): Likewise.
10508 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10509 (message_buf_print, scratch_glyph_row, displayed_buffer):
10510 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10511 (get_next_display_element, show_mouse_face, window_box_edges):
10512 (frame_to_window_pixel_xy, check_point_in_composition):
10513 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10514 (glyph_to_pixel_coords): Remove; unused.
10515
16390cd2
PE
10516 * dired.c (file_name_completion): Now static.
10517
10518 * dbusbind.c (xd_in_read_queued_messages): Now static.
10519
a25f4dfa
PE
10520 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10521 * data.c (circular_list_error): Remove.
10522
14a9c8df
PE
10523 * commands.h (last_point_position, last_point_position_buffer):
10524 (last_point_position_window): Remove decls.
10525 * keyboard.c: Make these variables static.
10526
04f2d78b
CB
10527 * coding.h (coding, code_convert_region, encode_coding_gap):
10528 Remove decls.
74ab6df5
PE
10529 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10530 (iso_code_class, detect_coding, code_convert_region): Now static.
10531 (encode_coding_gap): Remove; unused.
10532
38dfbee1
PE
10533 * chartab.c (chartab_chars, chartab_bits): Now static.
10534
a2cb4e63
PE
10535 * charset.h (charset_iso_8859_1): Remove decl.
10536 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10537 Now static.
10538
127198fd
PE
10539 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10540 * ccl.c (Vccl_program_table): Now static.
10541 (check_ccl_update): Remove; unused.
10542
d85b608f
PE
10543 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10544 * category.h: ... from here.
10545 * category.c (check_category_table, set_category_set): Now static.
10546
31cd66f3
PE
10547 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10548 * lisp.h: Remove these decls.
10549
c358e587
PE
10550 * buffer.c (buffer_count): Remove unused var.
10551
e78aecca
PE
10552 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10553 so that it's not optimized away.
10554 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10555 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10556 exported only to the debugger.
10557
e192d7d3 10558 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10559 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10560
92470028
PE
10561 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10562 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10563 was inaccessible from Lisp.
10564 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10565 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10566
244ed907
PE
10567 alloc.c: Import and export fewer symbols, and remove unused items.
10568 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10569 is defined.
10570 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10571 it's not optimized away by whole-program optimization.
10572 (message_enable_multibyte, free_misc): Remove.
10573 (catchlist, handlerlist, mark_backtrace):
10574 Declare only if BYTE_MARK_STACK.
10575 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10576 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10577 (message_enable_multibyte): Remove decl.
10578 (free_misc, interval_free_list, float_block, float_block_index):
10579 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10580 (cons_free_list, last_marked_index):
10581 Now static.
10582 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10583 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10584 (mark_backtrace): Define only if BYTE_MARK_STACK.
10585 * xdisp.c (message_enable_multibyte): Now static.
10586
61c2b50e 10587 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10588 This makes it easier for human readers (and static analyzers)
10589 to see whether these variables are used from other modules.
10590 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10591 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10592 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10593 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10594 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10595 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10596 * xmenu.c, xselect.c:
10597 Declare Q* vars static if they are not used in other modules.
10598 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10599 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10600 Remove decls of unexported vars.
10601 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10602
95c82688
PE
10603 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10604
16a97296
PE
10605 Make Emacs functions such as Fatom 'static' by default.
10606 This makes it easier for human readers (and static analyzers)
10607 to see whether these functions can be called from other modules.
10608 DEFUN now defines a static function. To make the function external
10609 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10610 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10611 (Finit_image_library):
16a97296
PE
10612 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10613 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10614 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10615 Remove decls, since these functions are now static.
10616 (Funintern, Fget_internal_run_time): New decls, since these functions
10617 were already external.
95c82688 10618
16a97296
PE
10619 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10620 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10621 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10622 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10623 * keyboard.c, keymap.c, lread.c:
10624 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10625 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10626 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10627 Mark functions with DEFUE instead of DEFUN,
10628 if they are used in other modules.
10629 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10630 decls for now-static functions.
10631 * buffer.h (Fdelete_overlay): Remove decl.
10632 * callproc.c (Fgetenv_internal): Mark as internal.
10633 * composite.c (Fremove_list_of_text_properties): Remove decl.
10634 (Fcomposition_get_gstring): New forward static decl.
10635 * composite.h (Fcomposite_get_gstring): Remove decl.
10636 * dired.c (Ffile_attributes): New forward static decl.
10637 * doc.c (Fdocumntation_property): New forward static decl.
10638 * eval.c (Ffetch_bytecode): New forward static decl.
10639 (Funintern): Remove extern decl; now in .h file where it belongs.
10640 * fileio.c (Fmake_symbolic_link): New forward static decl.
10641 * image.c (Finit_image_library): New forward static decl.
10642 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10643 * intervals.h (Fprevious_property_change):
10644 (Fremove_list_of_text_properties): Remove decls.
10645 * keyboard.c (Fthis_command_keys): Remove decl.
10646 (Fcommand_execute): New forward static decl.
10647 * keymap.c (Flookup_key): New forward static decl.
10648 (Fcopy_keymap): Now static.
10649 * keymap.h (Flookup_key): Remove decl.
10650 * process.c (Fget_process): New forward static decl.
10651 (Fprocess_datagram_address): Mark as internal.
10652 * syntax.c (Fsyntax_table_p): New forward static decl.
10653 (skip_chars): Remove duplicate decl.
10654 * textprop.c (Fprevious_property_change): New forward static decl.
10655 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10656 Now internal.
10657 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10658 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10659
785bbd42
PE
10660 * editfns.c (Fformat): Remove unreachable code.
10661
8b913b57
AS
106622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10663
10664 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10665 change. (Bug#8496)
10666
a6744a35
EZ
106672011-04-13 Eli Zaretskii <eliz@gnu.org>
10668
10669 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10670 when at ZV. (Bug#8487)
10671
e7974947
AS
106722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10673
baad03f0
AS
10674 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10675 (Bug#8437)
10676 * keyboard.c (parse_tool_bar_item): Likewise.
10677 * sound.c (sound_cleanup, alsa_close): Likewise.
10678 * termcap.c (tgetent): Likewise.
10679 * xfns.c (x_default_font_parameter): Likewise.
10680 * xsettings.c (read_and_apply_settings): Likewise.
10681
e7974947
AS
10682 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10683 (overrun_check_free): Protoize.
10684
28272684
PE
106852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10686
10687 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10688 since callers should never pass a negative size.
10689 Change the signature to match that of plain 'read' and 'write'; see
10690 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10691 * lisp.h: Update prototypes of emacs_write and emacs_read.
10692
11997c76
EZ
106932011-04-11 Eli Zaretskii <eliz@gnu.org>
10694
10695 * xdisp.c (redisplay_window): Don't try to determine the character
10696 position of the scroll margin if the window start point w->startp
e896f03c 10697 is outside the buffer's accessible region. (Bug#8468)
11997c76 10698
8a2cbd72
EZ
106992011-04-10 Eli Zaretskii <eliz@gnu.org>
10700
10701 Fix write-region and its subroutines for buffers > 2GB.
10702 * fileio.c (a_write, e_write): Modify declaration of arguments and
10703 local variables to support buffers larger than 2GB.
10704 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10705
10706 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10707 argument, local variables, and return value.
10708
10709 * lisp.h: Update prototypes of emacs_write and emacs_read.
10710
10711 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10712
4073e537 107132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10714
1ebfdcb6
PE
10715 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10716
b2ded58d
PE
10717 Fix more problems found by GCC 4.6.0's static checks.
10718
7d66342c
PE
10719 * xdisp.c (vmessage): Use a better test for character truncation.
10720
bbf47d44
PE
10721 * charset.c (load_charset_map): <, not <=, for optimization,
10722 and to avoid potential problems with integer overflow.
9248994d 10723 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10724 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10725 * editfns.c (Fformat): Likewise.
1e69125e 10726 * syntax.c (skip_chars): Likewise.
3befa583 10727
e3019616
PE
10728 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10729 This also lets GCC 4.6.0 generate slightly better loop code.
10730
becfa255
PE
10731 * callint.c (Fcall_interactively): <, not <=, for optimization.
10732 (Fcall_interactively): Count the number of arguments produced,
10733 not the number of arguments given. This is simpler and lets GCC
10734 4.6.0 generate slightly better code.
10735
dae0cd48
PE
10736 * ftfont.c: Distingish more carefully between FcChar8 and char.
10737 The previous code passed unsigned char * to a functions like
10738 strlen and xstrcasecmp that expect char *, which does not
10739 conform to the C standard.
10740 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10741 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10742 char * when the C standard requires it.
10743
76032d70
PE
10744 * keyboard.c (read_char): Remove unused var.
10745
eb3f1cc8
PE
10746 * eval.c: Port to Windows vsnprintf (Bug#8435).
10747 Include <limits.h>.
10748 (SIZE_MAX): Define if the headers do not.
10749 (verror): Do not give up if vsnprintf returns a negative count.
10750 Instead, grow the buffer. This ports to Windows vsnprintf, which
10751 does not conform to C99. Problem reported by Eli Zaretskii.
10752 Also, simplify the allocation scheme, by avoiding the need for
10753 calling realloc, and removing the ALLOCATED variable.
10754
70476b54
PE
10755 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10756
12020a9e
PE
10757 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10758 But keep the doprint source code for now, as we might revamp it
10759 and use it again (Bug#8435).
ea6c7ae6
PE
10760 * lisp.h (doprnt): Remove.
10761 * Makefile.in (base_obj): Remove doprnt.o.
10762 * deps.mk (doprnt.o): Remove.
10763
5fdb398c
PE
10764 error: Print 32- and 64-bit integers portably (Bug#8435).
10765 Without this change, on typical 64-bit hosts error ("...%d...", N)
10766 was used to print both 32- and 64-bit integers N, which relied on
10767 undefined behavior.
61bdb816 10768 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10769 * lisp.h (error, verror): Mark as printf-like functions.
10770 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10771 Report overflow in size calculations when allocating printf buffer.
10772 Do not truncate output string at its first null byte.
10773 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10774 Truncate the output at a character boundary, since vsnprintf does not
10775 do that.
10776 * charset.c (check_iso_charset_parameter): Convert internal
10777 character to string before calling 'error', since %c now has the
10778 printf meaning.
10779 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10780 overflow when computing char to be passed to 'error'. Do not
10781 pass Lisp_Object to 'error'; pass the integer instead.
10782 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10783 formatted with plain %d.
10784
b189fa66
PE
10785 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10786
bff87ef0
PE
10787 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10788
7e2cac20
PE
10789 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10790
ce4d90b5
PE
10791 * xterm.c (x_catch_errors): Remove duplicate declaration.
10792
266c9547
PE
10793 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10794
79c49ad2
PE
10795 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10796
368f4090
JM
107972011-04-10 Jim Meyering <meyering@redhat.com>
10798
10799 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10800 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10801 return ssize_t not "int", and use size_t as the buffer length.
10802 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10803 * gnutls.h: Update declarations.
10804 * process.c (read_process_output): Use ssize_t, to match.
10805 (send_process): Likewise.
10806
a32d4040
CY
108072011-04-09 Chong Yidong <cyd@stupidchicken.com>
10808
10809 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10810
8546720e 108112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10812
04f2d78b
CB
10813 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10814 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10815
8546720e
GM
10816 * xterm.c (handle_one_xevent):
10817 * xmenu.c (create_and_show_popup_menu):
10818 * xselect.c (x_decline_selection_request)
10819 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10820
0a2f5c1a 108212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10822
10823 Fix some uses of `int' instead of EMACS_INT.
10824 * search.c (string_match_1, fast_string_match)
10825 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10826 (scan_buffer, find_next_newline_no_quit)
10827 (find_before_next_newline, search_command, Freplace_match)
10828 (Fmatch_data): Make some `int' variables be EMACS_INT.
10829
10830 * xdisp.c (display_count_lines): 3rd argument and return value now
10831 EMACS_INT. All callers changed.
10832 (pint2hrstr): Last argument is now EMACS_INT.
10833
10834 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10835 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10836 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10837 (decode_coding_utf_16, decode_coding_emacs_mule)
10838 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10839 (decode_coding_ccl, decode_coding_charset)
10840 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10841 (decode_coding_iso_2022, decode_coding_emacs_mule)
10842 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10843 <char_offset, last_offset>: Declare EMACS_INT.
10844 (encode_coding_utf_8, encode_coding_utf_16)
10845 (encode_coding_emacs_mule, encode_invocation_designation)
10846 (encode_designation_at_bol, encode_coding_iso_2022)
10847 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10848 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10849 Declare EMACS_INT.
10850 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10851 (encode_invocation_designation): Last argument P_NCHARS is now
10852 EMACS_INT.
10853 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10854 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10855
10856 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10857 All users changed.
10858
10859 * ccl.c (Fccl_execute_on_string): Declare some variables
10860 EMACS_INT.
10861
8546720e 108622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10863
10864 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10865
4e19a977
CS
108662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10867
10868 * process.c (Fformat_network_address): Doc fix.
10869
87302331
R
108702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10871
ee7683eb 10872 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10873
cbb59342
CY
108742011-04-08 Chong Yidong <cyd@stupidchicken.com>
10875
10876 * keyboard.c (read_char): Call Lisp function help-form-show,
10877 instead of using internal_with_output_to_temp_buffer.
10878 (Qhelp_form_show): New var.
e0d38eeb 10879 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10880
10881 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10882
10883 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10884
e67a13ab
CY
108852011-04-06 Chong Yidong <cyd@stupidchicken.com>
10886
04f2d78b
CB
10887 * process.c (Flist_processes): Remove to Lisp.
10888 (list_processes_1): Delete.
e67a13ab 10889
973f782d
EZ
108902011-04-06 Eli Zaretskii <eliz@gnu.org>
10891
7c106b1e
EZ
10892 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10893
973f782d
EZ
10894 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10895
41cf7d1a 108962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10897
ca23cc88
PE
10898 Fix more problems found by GCC 4.6.0's static checks.
10899
f390e2d5
PE
10900 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10901
42eea0d0
PE
10902 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10903
b69769da 10904 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10905
f9541e84
PE
10906 * xdisp.c (vmessage): Mark as a printf-like function.
10907
13841b55
PE
10908 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10909
c136c10f
PE
10910 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10911
5e2d4a30
PE
10912 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10913 printf-like functions.
10914 (tiff_load): Add casts to remove these marks before passing them
10915 to system-supplied API.
10916
583f48b9
PE
10917 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10918
b25d760e
PE
10919 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10920 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10921 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10922 directly, rather than having caller test rule sign. This avoids
10923 some unnecessary tests.
10924 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10925 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10926 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10927
bc7b6697 10928 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10929 (xfont_open): Avoid unnecessary tests.
bc7b6697 10930
27ccc379
PE
10931 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10932
dcd5c89a
PE
10933 * composite.h, composite.c (composition_gstring_put_cache):
10934 Use EMACS_INT, not int, for length.
10935
b13a45c6
PE
10936 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10937 breaking out part of COMPOSITION_DECODE_RULE.
10938 (COMPOSITION_DECODE_RULE): Use it.
10939 * composite.c (get_composition_id): Remove unused local vars,
10940 by using the new macro.
10941
1e792e4d
PE
10942 * textprop.c (set_text_properties_1): Change while to do-while,
10943 since the condition is always true at first.
10944
dc6c6455 10945 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10946 (interval_deletion_adjustment): Return unsigned value.
10947 All uses changed.
dc6c6455 10948
aba7731a
PE
10949 * process.c (list_processes_1, create_pty, read_process_output):
10950 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10951 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10952 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10953 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10954 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10955
fdfc4bf3
PE
10956 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10957
fca8fe46 10958 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10959 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10960
06a0259a 10961 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10962 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10963 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10964
e7b9e80f
PE
10965 * print.c (print_error_message): Avoid int overflow.
10966
56201685
PE
10967 * font.c (font_list_entities): Redo for clarity,
10968 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10969
78834453 10970 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10971 (font_score): Avoid potential overflow in diff calculation.
78834453 10972
0bc0b309 10973 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10974 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10975
e610eaca
PE
10976 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10977
b895abce
PE
10978 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10979 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10980 can always succeed if overflow has undefined behavior.
10981
1f1d9321 10982 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10983 (wordify): Omit three unnecessary tests.
1f1d9321 10984
c59478bc
PE
10985 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10986 All callers changed. This avoids the need for an unused var.
10987
79b73827
PE
10988 * casefiddle.c (casify_region): Remove var that is set but not used.
10989
a4db5dfe
PE
10990 * dired.c (file_name_completion): Remove var that is set but not used.
10991
43aae36e
PE
10992 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10993
2a47c44d 10994 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10995 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10996
a37c69bf
PE
10997 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10998 Check for integer overflow on size calculations.
10999
328ab8e7
PE
11000 * buffer.c (Fprevious_overlay_change): Remove var that is set
11001 but not used.
11002
e5a2a5cb
PE
11003 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11004 Remove vars that are set but not used.
8d84a6eb 11005 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11006 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11007
a60e5f68
PE
11008 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11009
f661cb61 11010 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11011 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11012
f0397f5a
PE
11013 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11014 that are set but not used.
11015
8664db06 11016 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11017 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11018
6abdaa4a
PE
11019 * xselect.c (x_get_local_selection, x_handle_property_notify):
11020 Remove vars that are set but not used.
11021
0ce7538d 11022 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11023 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11024
9ae848fc
PE
11025 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11026 Remove var that is set but not used.
0b918413
PE
11027 (scroll_bar_windows_size): Now size_t, not int.
11028 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11029 Check for overflow.
9ae848fc 11030
a5a62657
PE
11031 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11032 (map_tty_color) [!defined MSDOS]: Likewise.
11033
5c5cdd39
PE
11034 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11035
66ebf983
PE
11036 * coding.c: Remove vars that are set but not used.
11037 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11038 All callers changed.
11039 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11040 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11041 (decode_coding_charset): Remove vars that are set but not used.
11042
1be4d761
PE
11043 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11044 that is set but not used.
11045
47553fa8
PE
11046 * print.c (print_object): Remove var that is set but not used.
11047
1f7196bf 11048 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11049 The gnulib version avoids calling malloc in the usual case,
11050 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11051 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11052 * filelock.c (current_lock_owner): Likewise.
11053 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11054 * sysdep.c: Include allocator.h, careadlinkat.h.
11055 (emacs_no_realloc_allocator): New static constant.
11056 (emacs_readlink): New function.
fdb61804
PE
11057 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11058 ../lib/careadlinkat.h.
d1fdcab7 11059
f84c17c7
SM
110602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11061
11062 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11063 first non-nil return value).
11064
ef3862ad
JD
110652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11066
11067 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11068 if not defined (Bug#8403).
11069
376a7006
JB
110702011-04-02 Juanma Barranquero <lekktu@gmail.com>
11071
11072 * xdisp.c (display_count_lines): Remove parameter `start',
11073 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11074 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11075 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11076 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11077 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11078 and thereabouts. All callers changed.
11079 (get_per_char_metric): Remove parameter `f', unused since
11080 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11081
6ca3801d
JM
110822011-04-02 Jim Meyering <meyering@redhat.com>
11083
11084 do not dereference NULL upon failed strdup
11085 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11086 (ns_get_family): Likewise.
11087
d8e2b5ba
JB
110882011-04-02 Juanma Barranquero <lekktu@gmail.com>
11089
11090 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11091
8c74fcbd
JD
110922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11093
11094 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11095 later (Bug#8403).
11096
7200d79c
SM
110972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11098
03408648 11099 Add lexical binding.
7200d79c 11100
03408648
SM
11101 * window.c (Ftemp_output_buffer_show): New fun.
11102 (Fsave_window_excursion):
11103 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11104
11105 * lread.c (lisp_file_lexically_bound_p): New function.
11106 (Fload): Bind Qlexical_binding.
11107 (readevalloop): Remove `evalfun' arg.
11108 Bind Qinternal_interpreter_environment.
11109 (Feval_buffer): Bind Qlexical_binding.
11110 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11111 Mark as dynamic.
11112 (syms_of_lread): Declare `lexical-binding'.
11113
11114 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11115
11116 * keyboard.c (eval_dyn): New fun.
11117 (menu_item_eval_property): Use it.
ca105506
SM
11118
11119 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11120
03408648
SM
11121 * fns.c (concat, mapcar1): Accept byte-code-functions.
11122
11123 * eval.c (Fsetq): Handle lexical vars.
11124 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11125 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11126 (FletX, Flet): Obey lexical binding.
11127 (Fcommandp): Handle closures.
11128 (Feval): New `lexical' arg.
11129 (eval_sub): New function extracted from Feval. Use it almost
11130 everywhere where Feval was used. Look up vars in lexical env.
11131 Handle closures.
11132 (Ffunctionp): Move from subr.el.
11133 (Ffuncall): Handle closures.
11134 (apply_lambda): Remove `eval_flags'.
11135 (funcall_lambda): Handle closures and new byte-code-functions.
11136 (Fspecial_variable_p): New function.
11137 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11138 but without exporting it to Lisp.
23aba0ea 11139
23aba0ea 11140 * doc.c (Fdocumentation, store_function_docstring):
03408648 11141 * data.c (Finteractive_form): Handle closures.
23aba0ea 11142
03408648
SM
11143 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11144 interactive spec.
ba83908c 11145
04f2d78b
CB
11146 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11147 New byte-codes.
03408648
SM
11148 (exec_byte_code): New function extracted from Fbyte_code to handle new
11149 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11150
03408648 11151 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11152
03408648 11153 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11154
e2abce01
JB
111552011-03-31 Juanma Barranquero <lekktu@gmail.com>
11156
11157 * xdisp.c (redisplay_internal): Fix prototype.
11158
63696a73 111592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11160
63696a73 11161 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11162 (try_scrolling): Use it when setting scroll_limit.
11163 Limit scrolling to 100 screen lines.
63696a73
EZ
11164 (redisplay_window): Even when falling back on "recentering",
11165 position point in the window according to scroll-conservatively,
11166 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11167
11168 (try_scrolling): When point is above the window, allow searching
11169 as far as scroll_max, or one screenful, to compute vertical
11170 distance from PT to the scroll margin position. This prevents
11171 try_scrolling from unnecessarily failing when
11172 scroll-conservatively is set to a value slightly larger than the
11173 window height. Clean up the case of PT below the margin at bottom
11174 of window: scroll_max can no longer be INT_MAX. When aggressive
11175 scrolling is in use, don't let point enter the opposite scroll
11176 margin as result of the scroll.
11177 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11178 threshold of 100 lines for never-recentering scrolling.
11179
e4cc2dfc
JB
111802011-03-31 Juanma Barranquero <lekktu@gmail.com>
11181
11182 * dispextern.h (move_it_by_lines):
11183 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11184 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11185 (message_log_check_duplicate): Remove parameters `prev_bol' and
11186 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11187 (redisplay_internal): Remove parameter `preserve_echo_area',
11188 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11189
11190 * indent.c (Fvertical_motion):
11191 * window.c (window_scroll_pixel_based, Frecenter):
11192 Don't pass `need_y_p' to `move_it_by_lines'.
11193
1c470562
SM
111942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11195
44f230aa
SM
11196 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11197 steal a few bits to be more compact.
11198 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11199 Remove unneeded casts.
11200
1c470562
SM
11201 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11202
888adce9
ZK
112032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11204
11205 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11206 binding" message (bug#7967).
11207
f838ed7b
PE
112082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11209
77861b95
PE
11210 Fix more problems found by GCC 4.6.0's static checks.
11211
de6dbc14
PE
11212 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11213 Remove unused local var.
11214
f838ed7b
PE
11215 * editfns.c (Fmessage_box): Remove unused local var.
11216
792c7b2b
PE
11217 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11218 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11219 Omit unused local vars.
c499e557 11220 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11221 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11222 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11223 Omit unused local var.
11224
ba0165e1
PE
11225 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11226 Don't assume string length fits in int.
32ad8845 11227 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11228 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11229
3c59b4c9
PE
11230 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11231 instead of alloca (Bug#8344).
11232
a3eed478 11233 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11234 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11235
eb4d412d
PE
11236 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11237
1658b401
PE
11238 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11239 concerns.
11240
11241 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11242
11243 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11244
9a2c6e05
PE
11245 * keyboard.c (syms_of_keyboard): Use the same style as later
11246 in this function when indexing through an array. This also
11247 works around GCC bug 48267.
11248
03d0a109
PE
11249 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11250
44f730c8
PE
11251 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11252
fe75f926
PE
11253 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11254 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11255
ffa8c828
PE
11256 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11257 This avoids undefined behavior on integer overflow, and is a bit
11258 more convenient anyway since it is compared to a size_t variable.
11259
c5101a77
PE
11260 Variadic C functions now count arguments with size_t, not int.
11261 This avoids an unnecessary limitation on 64-bit machines, which
11262 caused (substring ...) to crash on large vectors (Bug#8344).
11263 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11264 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11265 All variadic functions and their callers changed accordingly.
c5101a77
PE
11266 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11267 * data.c (arith_driver, float_arith_driver): Likewise.
11268 * editfns.c (general_insert_function): Likewise.
11269 * eval.c (struct backtrace.nargs, interactive_p)
11270 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11271 (funcall_lambda, mark_backtrace): Likewise.
11272 * fns.c (concat): Likewise.
11273 * frame.c (x_set_frame_parameters): Likewise.
11274 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11275 0 if not found, not -1. All callers changed.
11276
dd3f25f7
PE
11277 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11278 (stack_copy_size): Now size_t, not int.
11279 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11280
461c2ab9
JB
112812011-03-28 Juanma Barranquero <lekktu@gmail.com>
11282
11283 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11284 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11285 All callers changed.
11286
11287 * lisp.h (multibyte_char_to_unibyte):
11288 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11289 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11290 * character.h (CHAR_TO_BYTE8):
11291 * cmds.c (internal_self_insert):
11292 * editfns.c (general_insert_function):
11293 * keymap.c (push_key_description):
11294 * search.c (Freplace_match):
11295 * xdisp.c (message_dolog, set_message_1): All callers changed.
11296
f6d62986
SM
112972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11298
11299 * keyboard.c (safe_run_hook_funcall): New function.
11300 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11301 don't set the hook to nil, but remove the offending function instead.
11302 (Qcommand_hook_internal): Remove, unused.
11303 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11304 Vcommand_hook_internal.
11305
11306 * eval.c (enum run_hooks_condition): Remove.
11307 (funcall_nil, funcall_not): New functions.
11308 (run_hook_with_args): Call each function through a `funcall' argument.
11309 Remove `cond' argument, now redundant.
11310 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11311 (Frun_hook_with_args_until_failure): Adjust accordingly.
11312 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11313
1db5b1ad
JB
113142011-03-28 Juanma Barranquero <lekktu@gmail.com>
11315
11316 * dispextern.h (string_buffer_position): Remove declaration.
11317
11318 * print.c (strout): Remove parameter `multibyte', unused since
11319 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11320
11321 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11322 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11323 All callers changed.
11324
11325 * w32.c (_wsa_errlist): Use braces for struct initializers.
11326
11327 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11328 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11329 All callers changed.
11330 (string_buffer_position): Likewise. Also, make static (it's never
11331 used outside xdisp.c).
11332 (cursor_row_p): Remove parameter `w', unused since
11333 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11334 (decode_mode_spec): Remove parameter `precision', introduced during
11335 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11336 All callers changed.
11337
5ffb62aa
JD
113382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11339
11340 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11341
461c2ab9 113422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11343
11344 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11345 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11346 (ns_update_auto_hide_menu_bar): New functions.
11347 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11348 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11349 ns_constrain_all_frames.
11350 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11351 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11352
5c380ffb
JD
113532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11354
11355 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11356
9af30bdf
GM
113572011-03-27 Glenn Morris <rgm@gnu.org>
11358
11359 * syssignal.h: Replace RETSIGTYPE with void.
11360 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11361 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11362 Replace SIGTYPE with void everywhere.
11363 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11364 * s/template.h (SIGTYPE): Remove commented out definition.
11365
e2abce01
JB
113662011-03-26 Eli Zaretskii <eliz@gnu.org>
11367
11368 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11369 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11370
f868cd8a
JB
113712011-03-26 Juanma Barranquero <lekktu@gmail.com>
11372
59eb0929
JB
11373 * w32.c (read_unc_volume): Use parameter `henum', instead of
11374 global variable `wget_enum_handle'.
11375
11376 * keymap.c (describe_vector): Remove parameters `indices' and
11377 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11378 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11379
f868cd8a
JB
11380 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11381
11382 * keyboard.c (timer_check): Remove parameter `do_it_now',
11383 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11384 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11385 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11386
11387 * keyboard.c (read_char):
11388 * w32menu.c (w32_menu_display_help):
11389 * xmenu.c (show_help_event, menu_help_callback):
11390 Adjust calls to `show_help_echo'.
11391
11392 * gtkutil.c (xg_maybe_add_timer):
11393 * keyboard.c (readable_events):
11394 * process.c (wait_reading_process_output):
11395 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11396
11397 * insdel.c (adjust_markers_gap_motion):
11398 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11399 (gap_left, gap_right): Don't call it.
11400
2ecf6fdb
CY
114012011-03-25 Chong Yidong <cyd@stupidchicken.com>
11402
11403 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11404 incurred during fontification.
11405
6b1f9ba4
JB
114062011-03-25 Juanma Barranquero <lekktu@gmail.com>
11407
11408 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11409 (DEFVAR_PER_BUFFER): Don't pass it.
11410
11411 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11412 (scrolling_window): Don't pass it.
11413
0f4a96b5
JB
114142011-03-25 Juanma Barranquero <lekktu@gmail.com>
11415
11416 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11417
11418 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11419 and `suffix'.
11420 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11421 of variables specific to SELinux and computation of `encoded_absname'.
11422
11423 * image.c (XPutPixel): Remove unused variable `height'.
11424
11425 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11426
11427 * unexw32.c (get_section_info): Remove unused variable `section'.
11428
11429 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11430 (system_process_attributes): Remove unused variable `sess'.
11431 (sys_read): Remove unused variable `err'.
11432
11433 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11434 (w32_wnd_proc): Remove unused variable `isdead'.
11435 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11436 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11437 (x_create_tip_frame): Remove unused variable `tem'.
11438
11439 * w32inevt.c (w32_console_read_socket):
11440 Remove unused variable `no_events'.
11441
11442 * w32term.c (x_draw_composite_glyph_string_foreground):
11443 Remove unused variable `width'.
11444
1149507c
JB
114452011-03-24 Juanma Barranquero <lekktu@gmail.com>
11446
11447 * w32term.c (x_set_glyph_string_clipping):
11448 Don't pass uninitialized region to CombineRgn.
11449
9c88f339
JB
114502011-03-23 Juanma Barranquero <lekktu@gmail.com>
11451
11452 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11453 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11454 (Fx_close_connection): Remove unused variable `i'.
11455
11456 * w32font.c (w32font_draw): Return number of glyphs.
11457 (w32font_open_internal): Remove unused variable `i'.
11458 (w32font_driver): Add missing initializer.
11459
11460 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11461 (fill_in_menu): Remove unused variable `items_added'.
11462
11463 * w32term.c (last_mouse_press_frame): Remove static global variable.
11464 (w32_clip_to_row): Remove unused variable `f'.
11465 (x_delete_terminal): Remove unused variable `i'.
11466
11467 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11468 (NOTHING): Remove unused static global variable.
11469 (uniscribe_check_otf): Remove unused variable `table'.
11470 (uniscribe_font_driver): Add missing initializers.
11471
dee091a3
JD
114722011-03-23 Julien Danjou <julien@danjou.info>
11473
11474 * term.c (Fsuspend_tty, Fresume_tty):
11475 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11476 * window.c (temp_output_buffer_show):
11477 * insdel.c (signal_before_change):
11478 * frame.c (Fhandle_switch_frame):
11479 * fileio.c (Fdo_auto_save):
11480 * emacs.c (Fkill_emacs):
11481 * editfns.c (save_excursion_restore):
11482 * cmds.c (internal_self_insert):
11483 * callint.c (Fcall_interactively):
11484 * buffer.c (Fkill_all_local_variables):
11485 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11486 Use Frun_hooks.
0f4a96b5 11487 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11488 unconditionally since it does the check itself.
dee091a3 11489
2c520ab5 114902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11491
c9c49752
PE
11492 Fix more problems found by GCC 4.5.2's static checks.
11493
8abc3f12
PE
11494 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11495 the first time through the loop, since we know p0 < p1 then.
11496 This also avoids a gcc -Wstrict-overflow warning.
11497
a2d26660
PE
11498 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11499 leading to a memory leak, possible in functions like
11500 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11501 of objects (Bug#8318).
a2d26660 11502
916c72e9
PE
11503 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11504 that could (at least in theory) be that large.
11505
19ab8a18
PE
11506 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11507 This is less likely to overflow, and avoids undefined behavior if
11508 overflow does occur. All callers changed. Use strtoul to scan
11509 for the unsigned long integer.
b7cbbd6f
PE
11510 (pint2hrstr): Simplify and tune code slightly.
11511 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11512
f0641eff
PE
11513 * scroll.c (do_scrolling): Work around GCC bug 48228.
11514 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11515
7f650bb9
PE
11516 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11517 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11518 (validate_x_resource_name): Simplify count usage.
11519 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11520
37dd57d1
PE
11521 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11522 fail (Bug#8306).
81e56e61 11523
699979fc 11524 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11525
401bf9b4
PE
11526 * process.c (Fmake_network_process): Use socklen_t, not int,
11527 where POSIX says socklen_t is required in portable programs.
11528 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11529 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11530 (Fmake_network_process, server_accept_connection):
11531 (wait_reading_process_output, read_process_output):
11532 Likewise.
11533
b93aacde
PE
11534 * process.c: Rename or move locals to avoid shadowing.
11535 (list_processes_1, Fmake_network_process):
11536 (read_process_output_error_handler, exec_sentinel_error_handler):
11537 Rename or move locals.
4dc343ee 11538 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11539 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11540 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11541 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11542 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11543
af8a867c 11544 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11545 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11546 Include tparam.h instead, since it declares them.
af8a867c
PE
11547 * cm.h (PC): Remove extern decl; tparam.h now does this.
11548 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11549 * terminfo.c: Include tparam.h, to check interfaces.
11550 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11551 (tparam): Adjust signature to match interface in tparam.h;
11552 this removes some undefined behavior. Check that outstring and len
11553 are zero, which they always are with Emacs.
11554 * tparam.h (PC, BC, UP): New extern decls.
11555
0248044d 11556 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11557 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11558
8ff096c1 11559 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11560 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11561 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11562 (ftfont_list): Remove unused local.
49eaafba
PE
11563 (get_adstyle_property, ftfont_pattern_entity):
11564 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11565 Rename locals to avoid shadowing.
8ff096c1 11566
e2be39f6
PE
11567 * xfont.c (xfont_list_family): Mark var as initialized.
11568
c9735e30
PE
11569 * xml.c (make_dom): Now static.
11570
8f5201ae
PE
11571 * composite.c (composition_compute_stop_pos): Rename local to
11572 avoid shadowing.
b246f932
PE
11573 (composition_reseat_it): Remove unused locals.
11574 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11575 (composition_update_it): Mark var as initialized.
11b61122
PE
11576 (find_automatic_composition): Mark vars as initialized,
11577 with a FIXME (Bug#8290).
8f5201ae 11578
760fbc2c
PE
11579 character.h: Rename locals to avoid shadowing.
11580 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11581 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11582 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11583 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11584 to avoid shadowing.
11585
ff08eb85
PE
11586 * textprop.c (property_change_between_p): Remove; unused.
11587
fc7bf025
PE
11588 * intervals.c (interval_start_pos): Now static.
11589
235d7abc
PE
11590 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11591
44f230aa
SM
11592 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11593 Rename locals to avoid shadowing.
3e7d6594 11594
50060332
PE
11595 * sound.c (wav_play, au_play, Fplay_sound_internal):
11596 Fix pointer signedness.
d01f234b 11597 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11598 (wav_play): Initialize a variable to 0, to prevent undefined
11599 behavior (Bug#8278).
50060332 11600
c4fc4e30
PE
11601 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11602
918436ed
PE
11603 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11604
c939f91b
PE
11605 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11606 clobbering (Bug#8298).
b9c7f648
PE
11607 * sysdep.c (sys_subshell): Likewise.
11608 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11609
6bd8c144
PE
11610 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11611 This should get cleaned up, so that child_setup has the
11612 same signature on all platforms.
11613
7710357c 11614 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11615 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11616
c59da222
CY
116172011-03-22 Chong Yidong <cyd@stupidchicken.com>
11618
11619 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11620 not to be necessary, and produces flickering.
11621
66b87493
GM
116222011-03-20 Glenn Morris <rgm@gnu.org>
11623
11624 * config.in: Remove file.
11625
45b6f6d5
JB
116262011-03-20 Juanma Barranquero <lekktu@gmail.com>
11627
11628 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11629 are now in src/globals.h.
11630 (syms_of_minibuf): Remove spurious & from previous change.
11631
cd394be1 116322011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11633
11634 * minibuf.c (completing-read-function): New variable.
11635 (completing-read-default): Rename from completing-read.
11636 (completing-read): Call completing-read-function.
11637
b14e3e21
CY
116382011-03-19 Juanma Barranquero <lekktu@gmail.com>
11639
11640 * xfaces.c (Fx_load_color_file):
11641 Read color file from absolute filename (bug#8250).
11642
f2b726e6
JB
116432011-03-19 Juanma Barranquero <lekktu@gmail.com>
11644
11645 * makefile.w32-in: Update dependencies.
11646
09f6ff02
EZ
116472011-03-17 Eli Zaretskii <eliz@gnu.org>
11648
11649 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11650
29a6015a
PE
116512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11652
a3a6c54e
PE
11653 Fix more problems found by GCC 4.5.2's static checks.
11654
b766f867
PE
11655 * process.c (make_serial_process_unwind, send_process_trap):
11656 (sigchld_handler): Now static.
11657
be02381c
PE
11658 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11659 That way, the code declares only the vars that it needs.
11660 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11661 * s/cygwin.h (PTY_ITERATION): Likewise.
11662 * s/darwin.h (PTY_ITERATION): Likewise.
11663 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11664
57048744
PE
11665 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11666 * process.c (allocate_pty): Don't declare stb unless it's needed.
11667
7914961c 11668 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11669 (CONSTANTLIM): Remove; unused.
11670 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11671 Define only if needed.
7914961c 11672
b3967b18
PE
11673 * unexelf.c (unexec): Name an expression,
11674 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11675 Use a different way to cause a compilation error if anyone uses
11676 n rather than nn, a way that does not involve shadowing.
73366a00 11677 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11678
29a6015a
PE
11679 * deps.mk (unexalpha.o): Remove; unused.
11680
43cfc33e 11681 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11682 * unexec.h: New file.
ce701a33
PE
11683 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11684 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11685 Depend on unexec.h.
11686 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11687 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11688 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11689 Change as necessary to match prototype in unexec.h.
ce701a33 11690
01f44d5a
PE
11691 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11692 shadowing.
4f63c6bb 11693 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11694
a6670b0b
PE
11695 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11696 Rename locals to avoid shadowing.
11697
cef2010d 11698 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11699 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11700
d4d7173a
PE
11701 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11702
f08b802a
PE
11703 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11704 warning when compiling print.c.
11705
3ddb0639
PE
11706 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11707 instead of using an uninitialized var.
5ad03b97 11708 (font_sort_entities): Mark var as initialized.
3ddb0639 11709
170a2692
PE
11710 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11711
e663c700
PE
11712 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11713 pointers to constants.
89bc529a 11714 (font_parse_fcname): Remove unused vars.
7b81e2d0 11715 (font_delete_unmatched): Now static.
ea838e10 11716 (font_get_spec): Remove; unused.
13a547c6
PE
11717 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11718 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11719 Rename or move locals to avoid shadowing.
e663c700 11720
2a80c887 11721 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11722 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11723
1384fa33 11724 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11725 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11726
8b2c52e9
PE
11727 * alloc.c (mark_backtrace): Move decl from here ...
11728 * lisp.h: ... to here, so that it can be checked.
11729
475545b5 11730 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11731 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11732 (lisp_indirect_variable): Name an expression,
11733 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11734 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11735
b1349114 11736 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11737 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11738 Use const pointer when appropriate.
b1349114 11739
a2928364
PE
11740 * lisp.h (get_system_name, get_operating_system_release):
11741 Move decls here, to check interfaces.
11742 * process.c (get_operating_system_release): Move decl to lisp.h.
11743 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11744 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11745 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11746 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11747 (Fformat_time_string, Fencode_time, Finsert_char):
11748 (Ftranslate_region_internal, Fformat):
11749 Rename or remove local vars to avoid shadowing.
9710023e 11750 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11751
a415e694
PE
11752 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11753 avoid shadowing.
11754
8ef4622d
PE
11755 * lisp.h (eassert): Check that the argument compiles, even if
11756 ENABLE_CHECKING is not defined.
11757
946f9a5b
PE
11758 * data.c (Findirect_variable): Name an expression, to avoid
11759 gcc -Wbad-function-cast warning.
112396d6 11760 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11761 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11762 (Fmake_variable_buffer_local, Fmake_local_variable):
11763 Mark variables as initialized.
52746918 11764 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11765
e5aab7e7 11766 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11767 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11768 Rename locals to avoid shadowing.
dff45157
PE
11769 (mark_stack): Move local variables into the #ifdef region where
11770 they're used.
7bc26fdb
PE
11771 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11772 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11773 needed otherwise.
11774 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11775 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11776 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11777
e5aab7e7
PE
11778 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11779 avoids undefined behavior in theory.
11780
4da60324
PE
11781 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11782
88043301
PE
11783 Use functions, not macros, for up- and down-casing (Bug#8254).
11784 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11785 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11786 to use the following functions instead of these macros.
11787 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11788 EMACS_INT, since callers assume the returned value fits in int.
11789 (upcase1): Likewise, for UPCASE_TABLE.
11790 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11791 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11792 the race-condition problem in the old DOWNCASE.
88043301 11793
19ed5445
PE
11794 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11795 Rename locals to avoid shadowing.
11796 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11797 (regex_compile, re_search_2, re_match_2_internal):
11798 Remove unused local vars.
952db0d7
PE
11799 (FREE_VAR): Rewrite so as not to use empty "else",
11800 which gcc can warn about.
da053e48 11801 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11802 (RETALLOC_IF): Define only if needed.
11803 (WORDCHAR_P): Likewise. This one is never needed, but is used
11804 only in a comment talking about a compiler bug, so put inside
11805 the #if 0 of that comment.
11806 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11807 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11808 Remove; unused.
19ed5445 11809
1f3561e4 11810 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11811 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11812 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11813
ded6f8f7
PE
11814 * search.c (simple_search): Remove unused var.
11815
dbd37a95
PE
11816 * dired.c (compile_pattern): Move decl from here ...
11817 * lisp.h: ... to here, so that it can be checked.
11818 (struct re_registers): New forward decl.
11819
7e47afad
PE
11820 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11821
85f24f61
PE
11822 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11823 All uses changed.
11824 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11825 Rename locals to avoid shadowing.
5671df8f 11826 (Fvertical_motion): Mark locals as initialized.
85f24f61 11827
181aa2be 11828 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11829 (casify_region): Mark local as initialized.
181aa2be 11830
930d429c
PE
11831 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11832
7082eac6
PE
11833 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11834 New macros, so that the caller can use some names other than
11835 gcpro1, gcpro2, etc.
11836 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11837 of the new macros.
11838 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11839 argument, for consistency with GCPRO2_VAR, etc: it is now the
11840 prefix of the variable, not the variable itself. All uses
11841 changed.
38b2c076
PE
11842 * dired.c (directory_files_internal, file_name_completion):
11843 Rename locals to avoid shadowing.
11844
15206ed9
PE
11845 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11846 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11847 dired.c's scmp function, had undefined behavior.
11848 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11849 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11850 * buffer.h: ... to here, because these macros use current_buffer,
11851 and the new implementation with inline functions needs to have
11852 current_buffer in scope now, rather than later when the macros
11853 are used.
11854 (downcase, upcase1): New static inline functions.
11855 (DOWNCASE, UPCASE1): Reimplement using these functions.
11856 This avoids undefined behavior in expressions like
11857 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11858 from race conditions in accessing the global variables
11859 case_temp1 and case_temp2.
11860 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11861 * lisp.h (case_temp1, case_temp2): Remove their decls.
11862 * character.h (ASCII_CHAR_P): Move from here ...
11863 * lisp.h: ... to here, so that the inline functions mentioned
11864 above can use them.
11865
4a6bea26
PE
11866 * dired.c (directory_files_internal_unwind): Now static.
11867
f14b7e14
PE
11868 * fileio.c (file_name_as_directory, directory_file_name):
11869 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11870 Now static.
2893f146
PE
11871 (file_name_as_directory): Use const pointers when appropriate.
11872 (Fexpand_file_name): Likewise. In particular, newdir might
11873 point at constant storage, so make it a const pointer.
fd4ead52 11874 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11875 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11876 signedness issues.
f839df0c
PE
11877 (Fset_file_times, Finsert_file_contents, auto_save_error):
11878 Rename locals to avoid shadowing.
f14b7e14 11879
5716756e 11880 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11881 (Ftry_completion, Fall_completions): Rename or remove locals
11882 to avoid shadowing.
5716756e 11883
b4c3046a
PE
11884 * marker.c (bytepos_to_charpos): Remove; unused.
11885
b45db522
PE
11886 * lisp.h (verify_bytepos, count_markers): New decls,
11887 so that gcc does not warn that these functions aren't declared.
11888
85876d07
PE
11889 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11890 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11891 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11892 (copy_text): Remove unused local var.
85876d07 11893
03d78a21 11894 * filelock.c (within_one_second): Now static.
b3dd38ab 11895 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11896
5df8f01b
PE
11897 * buffer.c (fix_overlays_before): Mark locals as initialized.
11898 (fix_start_end_in_overlays): Likewise. This function should be
11899 simplified by using pointers-to-pointers, but that's a different
11900 matter.
b1d876f1 11901 (switch_to_buffer_1): Now static.
8f54f30a
PE
11902 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11903 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11904
a70072c9 11905 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11906 Fix pointer signedness issue.
edced198
PE
11907 (sys_subshell): Mark local as volatile if checking for lint,
11908 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11909 (MAXPATHLEN): Define only if needed.
a70072c9 11910
a0977c44
PE
11911 * process.c (serial_open, serial_configure): Move decls from here ...
11912 * systty.h: ... to here, so that they can be checked.
11913
a884fdcc
PE
11914 * fns.c (get_random, seed_random): Move extern decls from here ...
11915 * lisp.h: ... to here, so that they can be checked.
11916
604efe86 11917 * sysdep.c (reset_io): Now static.
b8950c94 11918 (wait_for_termination_signal): Remove; unused.
604efe86 11919
38fc62d9
PE
11920 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11921 (copy_keymap_item, append_key, push_text_char_description):
11922 Now static.
1004a21a 11923 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11924 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11925 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11926 (describe_map_tree):
11927 Rename locals to avoid shadowing.
38fc62d9 11928
2f2650da
PE
11929 * keyboard.c: Declare functions static if they are not used elsewhere.
11930 (echo_char, echo_dash, cmd_error, top_level_2):
11931 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11932 (read_char, kbd_buffer_get_event, make_lispy_position):
11933 (make_lispy_event, make_lispy_movement, apply_modifiers):
11934 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11935 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11936 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11937 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11938 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11939
a053e86c 11940 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11941 (mark_kboards): Move decl here ...
11942 * alloc.c (mark_kboards): ... from here.
a053e86c 11943
4752793e
PE
11944 * lisp.h (force_auto_save_soon): New decl.
11945
74f10ca7 11946 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11947 (DEFINE_DUMMY_FUNCTION): New macro.
11948 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11949 Use it.
c03cd23f
PE
11950 (main): Add casts to avoid warnings
11951 if GCC considers string literals to be constants.
74f10ca7 11952
022e70d4
PE
11953 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11954
59d6fe83
PE
11955 * dbusbind.c: Pointer signedness fixes.
11956 (xd_signature, xd_append_arg, xd_initialize):
11957 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11958 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11959 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11960 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11961
78320123
PE
11962 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11963 if GCC considers string literals to be constants.
49cebcca 11964 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11965
35ac2a97
SM
119662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11967
fb103ca9
SM
11968 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11969 (print_preprocess, print_object): New macro to fix last change.
11970
35ac2a97
SM
11971 * print.c (print_preprocess): Don't forget font objects.
11972
62973b41
JB
119732011-03-16 Juanma Barranquero <lekktu@gmail.com>
11974
11975 * emacs.c (USAGE3): Doc fixes.
11976
0e48bb22
AS
119772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11978
11979 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11980 structure.
11981
7684e57b
JB
119822011-03-14 Juanma Barranquero <lekktu@gmail.com>
11983
11984 * lisp.h (VWindow_system, Qfile_name_history):
11985 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11986 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11987 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11988
11989 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11990 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11991
11992 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11993 * w32console.c (detect_input_pending, read_input_pending)
11994 (encode_terminal_code):
11995 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11996 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11997 (w32_system_caret_y, Qfile_name_history):
11998 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11999 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12000 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12001 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12002 * w32proc.c (Qlocal, report_file_error):
12003 * w32term.c (Vwindow_system, updating_frame):
12004 * w32uniscribe.c (initialized, uniscribe_font_driver):
12005 Remove unneeded extern declarations.
12006
2aa46d6c
CY
120072011-03-14 Chong Yidong <cyd@stupidchicken.com>
12008
c96bbc66 12009 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12010
cffc6f3b
CY
120112011-03-13 Chong Yidong <cyd@stupidchicken.com>
12012
12013 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12014 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12015 These macros can no longer be used for assignment.
12016
44f230aa
SM
12017 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12018 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12019 (record_buffer_markers, fetch_buffer_markers): New functions for
12020 recording and fetching special buffer markers.
12021 (set_buffer_internal_1, set_buffer_temp): Use them.
12022
12023 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12024
12025 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12026
12027 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12028 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12029
12030 * xdisp.c (hscroll_window_tree):
12031 (reconsider_clip_changes): Use PT instead of BUF_PT.
12032
d251f04b
EZ
120332011-03-13 Eli Zaretskii <eliz@gnu.org>
12034
12035 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12036 $(EMACS_ROOT)/lib/intprops.h.
12037
f0c77cd1
PE
120382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12039
3eca4629
PE
12040 Fix more problems found by GCC 4.5.2's static checks.
12041
7c86ee98
PE
12042 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12043 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12044 (xg_free_frame_widgets): Make it clear that a local variable is
12045 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12046 (gdk_window_get_screen): Make it clear that this macro is needed
12047 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12048 (int_gtk_range_get_value): New function, which avoids a diagnostic
12049 from gcc -Wbad-function-cast.
12050 (xg_set_toolkit_scroll_bar_thumb): Use it.
12051 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12052 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12053 (get_utf8_string, xg_get_file_with_chooser):
12054 Rename locals to avoid shadowing.
12055 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12056
41729b81
PE
12057 * xgselect.c (xg_select): Remove unused var.
12058
f0c77cd1
PE
12059 * image.c (four_corners_best): Mark locals as initialized.
12060 (gif_load): Initialize transparent_p to zero (Bug#8238).
12061 Mark another local as initialized.
ec6cf4c6 12062 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12063
ce0ad53d 12064 * image.c (clear_image_cache): Now static.
d5d5a617 12065 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12066 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12067 (x_edge_detection): Remove unnecessary cast that
12068 gcc -Wbad-function-cast diagnoses.
2037898d 12069 (gif_load): Fix pointer signedness.
6ae141d6
PE
12070 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12071 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12072
33383987 120732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12074
d32df629
PE
12075 Improve quality of tests for time stamp overflow.
12076 For example, without this patch (encode-time 0 0 0 1 1
12077 1152921504606846976) returns the obviously-bogus value (-948597
12078 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12079 reports time overflow. See
12080 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12081 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12082 * editfns.c: Include limits.h and intprops.h.
12083 (TIME_T_MIN, TIME_T_MAX): New macros.
12084 (time_overflow): Move earlier, to before first use.
12085 (hi_time, lo_time): New functions, for an accurate test for
12086 out-of-range times.
12087 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12088 (Fget_internal_run_time): Don't assume time_t fits in int.
12089 (make_time): Use list2 instead of Fcons twice.
12090 (Fdecode_time): More accurate test for out-of-range times.
12091 (check_tm_member): New function.
12092 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12093 (lisp_time_argument): Don't rely on undefined left-shift and
12094 right-shift behavior when checking for time stamp overflow.
8be6f318 12095
fe31d94c
PE
12096 * editfns.c (time_overflow): New function, refactoring common code.
12097 (Fformat_time_string, Fdecode_time, Fencode_time):
12098 (Fcurrent_time_string): Use it.
12099
8be6f318
PE
12100 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12101 * dired.c (make_time): Move to ...
12102 * editfns.c (make_time): ... here.
12103 * systime.h: Note the move.
12104
09d9db2c 121052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12106
126bc0dc
YM
12107 * fringe.c (update_window_fringes): Remove unused variables.
12108
c47cbdfd
YM
12109 * unexmacosx.c (copy_data_segment): Also copy __got section.
12110 (Bug#8223)
12111
7ac80be9
EZ
121122011-03-12 Eli Zaretskii <eliz@gnu.org>
12113
c96bbc66 12114 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12115 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12116 Constify `char *' arguments and their references according to
12117 prototypes in tparam.h.
12118
ecb0f94d 12119 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12120
7ac80be9
EZ
12121 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12122 Adapt all references accordingly.
12123
12124 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12125
ef1fd07e
TT
121262011-03-11 Tom Tromey <tromey@redhat.com>
12127
12128 * buffer.c (syms_of_buffer): Remove obsolete comment.
12129
7ef4b50c
EZ
121302011-03-11 Eli Zaretskii <eliz@gnu.org>
12131
12132 * termhooks.h (encode_terminal_code): Declare prototype.
12133
12134 * msdos.c (encode_terminal_code): Don't declare prototype.
12135
12136 * term.c (encode_terminal_code): Now external again, used by
12137 w32console.c and msdos.c.
12138
44f230aa
SM
12139 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12140 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12141
4b1ec863 121422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12143
1714f52b 12144 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12145
4b1ec863
PE
12146 * fringe.c (update_window_fringes): Mark locals as initialized
12147 (Bug#8227).
12148 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12149
524c7aa6
PE
12150 * alloc.c (mark_fringe_data): Move decl from here ...
12151 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12152 to check its interface.
12153 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12154
a5c0af81 12155 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12156 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12157 (fontset_font): Mark local as initialized.
a9a06e0b 12158 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12159
b4716021
PE
12160 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12161
811e9bac 12162 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12163 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12164 (x_own_selection, Fx_disown_selection_internal): Rename locals
12165 to avoid shadowing.
12166 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12167
7e3ab302
PE
12168 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12169 so that the caller can use some name other than gcpro1.
12170 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12171 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12172 (Fx_backspace_delete_keys_p):
12173 Use them to avoid shadowing, and rename vars to avoid shadowing.
12174 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12175 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12176 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12177 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12178 Remove unused locals.
7e3ab302
PE
12179 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12180 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12181 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12182 macros.
f78faa98 12183
e2b13473
PE
12184 * xterm.h (x_mouse_leave): New decl.
12185
77f23912
PE
12186 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12187 Remove unused functions.
cdf4ba58
PE
12188 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12189 (x_calc_absolute_position): Now static.
7411c686 12190 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12191 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12192 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12193 unless they are used.
38d0b34a
PE
12194 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12195 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12196 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12197 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12198 (x_error_catcher, x_connection_closed, x_error_handler):
12199 (x_error_quitter, xembed_send_message, x_iconify_frame):
12200 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12201 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12202 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12203
44f230aa
SM
12204 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12205 Rename or move locals to avoid shadowing.
6b463e58 12206 (tty_defined_color, merge_face_heights): Now static.
5967d051 12207 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12208 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12209 does not deduce is never used uninitialized.
73719eba
PE
12210 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12211 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12212
426994c3 12213 * terminal.c (store_terminal_param): Now static.
5489860b 12214
032f1620 12215 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12216 (set_frame_menubar): Remove unused local.
d4323972 12217 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12218 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12219 since they might point to immutable storage.
281585b0
PE
12220 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12221 since it's unused otherwise.
032f1620 12222
367c19e5 12223 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12224 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12225 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12226 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12227 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12228 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12229 does not deduce are never used uninitialized.
70739cbe 12230
07b48fa9
PE
12231 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12232
8868a238 12233 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12234 * window.c (window_loop, size_window):
12235 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12236
7e5cf297 12237 * window.c (display_buffer): Now static.
d6550a9f
PE
12238 (size_window): Mark variables that gcc -Wuninitialized
12239 does not deduce are never used uninitialized.
a586633d
PE
12240 * window.h (check_all_windows): New decl, to forestall
12241 gcc -Wmissing-prototypes diagnostic.
5b555da1 12242 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12243
f6095868
PE
12244 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12245 shadowing.
12246 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12247 Include <limits.h>.
12248 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12249 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12250 (load_charset_map): Mark variables that gcc -Wuninitialized
12251 does not deduce are never used uninitialized.
53df7c11 12252 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12253
f38b440c
PE
12254 * coding.c (coding_set_source, coding_set_destination):
12255 Use "else { /* comment */ }" rather than "else /* comment */;"
12256 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12257 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12258 a block, when the outer 'i' will do.
12259 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12260 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12261 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12262 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12263 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12264 Rename locals to avoid shadowing.
12265 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12266 * coding.c (emacs_mule_char, encode_invocation_designation):
12267 Now static, since they're not used elsewhere.
413bb2db 12268 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12269 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12270 (decode_coding_emacs_mule): Mark variables that gcc
12271 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12272 (detect_coding_iso_2022): Initialize a local variable that might
12273 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12274 this initialization is needed. (Bug#8211)
5f58e762
PE
12275 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12276 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12277 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12278 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12279 Remove unused macros.
f38b440c 12280
232b38b9 12281 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12282 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12283 * character.c (string_count_byte8): Likewise.
232b38b9 12284
fb90da1b
PE
12285 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12286 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12287
fb93dbc2
PE
12288 * chartab.c (copy_sub_char_table): Now static, since it's not used
12289 elsewhere.
5c156ace
PE
12290 (sub_char_table_ref_and_range, char_table_ref_and_range):
12291 Rename locals to avoid shadowing.
bbcd0949 12292 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12293
7d3b3862 12294 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12295 (BIDI_BOB): Remove unused macro.
7d3b3862 12296
6be7d3da
PE
12297 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12298 deduce are never used uninitialized.
c2ed9c8b 12299 * term.c (encode_terminal_code): Likewise.
6be7d3da 12300
75f8807f 12301 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12302
50938595
PE
12303 * tparam.h: New file.
12304 * term.c, tparam.h: Include it.
12305 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12306 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12307 Move these decls to tparam.h, and make them agree with what
12308 is actually in tparam.c. The previous trick of using incompatible
12309 decls in different modules does not conform to the C standard.
12310 All callers of tparam changed to use tparam's actual API.
12311 * tparam.c (tparam1, tparam, tgoto):
12312 Use const pointers where appropriate.
12313
fbceeba2
PE
12314 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12315 * cm.h (struct cm): Likewise.
12316 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12317 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12318 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12319 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12320 (turn_on_face, init_tty): Likewise.
12321 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12322
7f3f1250
PE
12323 * term.c (term_mouse_position): Rename local to avoid shadowing.
12324
e6ca6543
PE
12325 * alloc.c (mark_ttys): Move decl from here ...
12326 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12327
c40f8d15
AS
123282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12329
12330 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12331
cfe0661d
JB
123322011-03-09 Juanma Barranquero <lekktu@gmail.com>
12333
12334 * search.c (compile_pattern_1): Remove argument regp, unused since
12335 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12336 (compile_pattern): Don't pass it.
12337
0afb4571
J
123382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12339
12340 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12341 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12342 for ! HAVE_GTK3.
12343 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12344
12345 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12346
12347 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12348 gdk_window_get_screen, gdk_window_get_geometry,
12349 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12350 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12351 (xg_get_pixbuf_from_pixmap): New function.
12352 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12353 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12354 Call xg_get_pixbuf_from_pixmap instead of
12355 gdk_pixbuf_get_from_drawable.
12356 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12357 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12358 (xg_check_special_colors): Use GtkStyleContext and its functions
12359 for HAVE_GTK3.
12360 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12361 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12362 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12363 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12364 Call gtk_widget_get_preferred_size.
0afb4571
J
12365 (xg_frame_resized): gdk_window_get_geometry only takes 5
12366 parameters.
44f230aa
SM
12367 (xg_win_to_widget, xg_event_is_for_menubar):
12368 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12369 (xg_set_widget_bg): New function.
12370 (delete_cb): New function.
895009e1 12371 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12372 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12373 (xg_set_background_color): Call xg_set_widget_bg.
12374 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12375 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12376 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12377 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12378 if ! HAVE_GTK3.
12379 (update_frame_tool_bar): Call gtk_widget_hide.
12380 (xg_initialize): Use GDK_KEY_g.
12381
12382 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12383 if ! HAVE_GTK3
12384 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12385
12386 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12387 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12388 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12389
1c2cc4ef
JB
123902011-03-08 Juanma Barranquero <lekktu@gmail.com>
12391
12392 * w32xfns.c (select_palette): Check success of RealizePalette against
12393 GDI_ERROR, not zero.
12394
33383987 12395See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12396
12397;; Local Variables:
12398;; coding: utf-8
aac0c6e3
MR
12399;; End:
12400
2f097256 12401 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12402
12403 This file is part of GNU Emacs.
12404
12405 GNU Emacs is free software: you can redistribute it and/or modify
12406 it under the terms of the GNU General Public License as published by
12407 the Free Software Foundation, either version 3 of the License, or
12408 (at your option) any later version.
12409
12410 GNU Emacs is distributed in the hope that it will be useful,
12411 but WITHOUT ANY WARRANTY; without even the implied warranty of
12412 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12413 GNU General Public License for more details.
12414
12415 You should have received a copy of the GNU General Public License
12416 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.