Merge from mainline.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7025ee00 12011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2
06d6db33
PE
3 * insdel.c (count_size_as_multibyte): Check for string overflow.
4
2b4560a8
PE
5 * character.c (lisp_string_width): Check for string overflow.
6 Use EMACS_INT, not int, for string indexes and lengths; in
7 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8 the resulting string length overflows an EMACS_INT; instead,
9 report a string overflow if no precision given. When checking for
10 precision exhaustion, use a check that cannot possibly have
11 integer overflow. (Bug#8675)
12 * character.h (lisp_string_width): Adjust to new signature.
13
cb93f9be
PE
14 * alloc.c (string_overflow): New function.
15 (Fmake_string): Use it. This doesn't change behavior, but saves
16 a few bytes and will simplify future changes.
17 * character.c (string_escape_byte8): Likewise.
18 * lisp.h (string_overflow): New decl.
19
1a1f3366
PE
20 Fixups, following up to the user-interface timestamp change.
21 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
22 for UI timestamps, instead of unsigned long.
9fbd6841
PE
23 * msdos.c (mouse_get_pos): Likewise.
24 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
25 * w32gui.h (Time): Define by including "systime.h" rather than by
26 declaring it ourselves. (Bug#8664)
27
d4e3e4d3
PE
28 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
29 * image.c (clear_image_cache): Likewise.
30
f6a24d19
PE
31 * term.c (term_mouse_position): Don't assume time_t wraparound.
32
08dc5ae6
PE
33 Be more systematic about user-interface timestamps.
34 Before, the code sometimes used 'Time', sometimes 'unsigned long',
35 and sometimes 'EMACS_UINT', to represent these timestamps. This
36 change causes it to use 'Time' uniformly, as that's what X uses.
37 This makes the code easier to follow, and makes it easier to catch
38 integer overflow bugs such as Bug#8664.
39 * frame.c (Fmouse_position, Fmouse_pixel_position):
40 Use Time, not unsigned long, for user-interface timestamps.
41 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
42 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
43 * keyboard.h (last_event_timestamp): Likewise.
44 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
45 * menu.h (xmenu_show): Likewise.
46 * term.c (term_mouse_position): Likewise.
47 * termhooks.h (struct input_event.timestamp): Likewise.
48 (struct terminal.mouse_position_hook): Likewise.
49 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
50 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
51 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
52 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
53 what it was before.
54 * menu.h, termhooks.h: Include "systime.h", for Time.
55
8e55734a
PE
56 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
57 Don't assume that the difference between two unsigned long values
58 can fit into an integer. At this point, we know button_down_time
59 <= event->timestamp, so the difference must be nonnegative, so
60 there's no need to cast the result if double-click-time is
61 nonnegative, as it should be; check that it's nonnegative, just in
62 case. This bug is triggered when events are more than 2**31 ms
86db42d2 63 apart (about 25 days). (Bug#8664)
8e55734a 64
841f1b75 65 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 66 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 67
3e26f69c
PE
68 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
69 that always fit in int. Use a sentinel instead of a counter, to
70 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
71 * frame.h (struct frame): Use int for menu_bar_items_used
72 instead of EMACS_INT, since it always fits in int.
3e26f69c 73
5cc152c0
PE
74 * menu.c (grow_menu_items): Check for int overflow.
75
d89eb65e
PE
76 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
77
5235bd3e
PE
78 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
79 Before, the code was not consistent. These values cannot exceed
80 2**31 - 1 so there's no need to make them unsigned.
81 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
82 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
83 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
84 as modifiers.
85 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
86
bc827e23
PE
87 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
88 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
89 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
90 presumably because the widths might not match.
91
78eb494e
PE
92 * window.c (size_window): Avoid needless test at loop start.
93
04f2d78b
CB
942011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
95
96 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
97
d2fc7e3d 982011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
99
100 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
101
d2fc7e3d 1022011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
103
104 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
105 `width' to `bar_area_x' and `bar_area_width', respectively.
106 (x_scroll_run): Take account of fringe background extension.
107
04f2d78b
CB
108 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
109 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
110 `bar_area_width', respectively.
111 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
112 background extension.
113
79b70037
GM
1142011-05-10 Jim Meyering <meyering@redhat.com>
115
116 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
117
2f142cc5
JB
1182011-05-10 Juanma Barranquero <lekktu@gmail.com>
119
120 * image.c (Finit_image_library): Return t for built-in image types,
121 like pbm and xbm. (Bug#8640)
122
57679c86
AS
1232011-05-09 Andreas Schwab <schwab@linux-m68k.org>
124
125 * w32menu.c (set_frame_menubar): Fix submenu allocation.
126
888c9e86
EZ
1272011-05-07 Eli Zaretskii <eliz@gnu.org>
128
b0512a1d
EZ
129 * w32console.c (Fset_screen_color): Doc fix.
130 (Fget_screen_color): New function.
131 (syms_of_ntterm): Defsubr it.
132
888c9e86
EZ
133 * callproc.c (call_process_cleanup): Don't close and unlink the
134 temporary file if Fcall_process didn't create it in the first
135 place.
136 (Fcall_process): Don't create tempfile if stdout of the child
137 process will be redirected to a file specified with `:file'.
138 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
139 cue to call_process_cleanup not to close that handle.
140
4d3fcc8e
BK
1412011-05-07 Ben Key <bkey76@gmail.com>
142
143 * makefile.w32-in: The bootstrap-temacs rule now makes use of
144 one of two shell specific rules, either bootstrap-temacs-CMD or
145 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
146 to the previous implementation of the bootstrap-temacs rule.
147 The bootstrap-temacs-CMD rule is similar to the previous
148 implementation of the bootstrap-temacs rule except that it
149 makes use of the ESC_CFLAGS variable instead of the CFLAGS
150 variable.
151
152 These changes, along with some changes to nt/configure.bat,
153 nt/gmake.defs, and nt/nmake.defs, are required to extend my
154 earlier fix to add support for --cflags and --ldflags options
155 that include quotes so that it works whether make uses cmd or
156 sh as the shell.
157
b4289b64
MA
1582011-05-06 Michael Albinus <michael.albinus@gmx.de>
159
160 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
161 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
162 is a constant.
163 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
164 a string. Handle both cases.
165 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
166 (Fdbus_register_method): Use Qinvalid_function.
167
af4c0e28
JB
1682011-05-06 Juanma Barranquero <lekktu@gmail.com>
169
170 * makefile.w32-in: Update dependencies.
171 (LISP_H): Add inttypes.h and stdin.h.
172 (PROCESS_H): Add unistd.h.
173
c51453d9
EZ
1742011-05-06 Eli Zaretskii <eliz@gnu.org>
175
176 * lread.c: Include limits.h (fixes the MS-Windows build broken by
177 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
178
8ff0ac3c 1792011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 180
4c4b566b
PE
181 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
182
aab2b9b5
PE
183 * term.c (vfatal): Remove stray call to va_end.
184 It's not needed and the C Standard doesn't allow it here anyway.
185
c378da0b
PE
186 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
187 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
188
288b08c7
PE
189 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
190 bytes.
191
e3601888
PE
192 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
193
db6c0e74
PE
194 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
195
dd5963ea
PE
196 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
197
88c9450f
PE
198 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
199
2f9442b8
PE
200 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
201
c032b5f8
PE
202 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
203 * charset.c (Fdefine_charset_internal): Don't initialize
204 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 205 32-bit int (Bug#8600).
a108c10b
PE
206
207 * lread.c (read_integer): Be more consistent with string-to-number.
208 Use string_to_number to do the actual conversion; this avoids
209 rounding errors and fixes some other screwups. Without this fix,
210 for example, #x1fffffffffffffff was misread as -2305843009213693952.
211 (digit_to_number): Move earlier, for benefit of read_integer.
212 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 213 not a digit in any supported base. (Bug#8602)
a108c10b 214
ad5f9eea
PE
215 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
216
aec1708a
PE
217 * dispnew.c (scrolling_window): Return 1 if we scrolled,
218 to match comment at start of function. This also removes a
219 GCC warning about overflow in a 32+64-bit port.
220
47be4ab5
PE
221 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
222
371cac43
PE
223 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
224 Reported by Stefan Monnier in
225 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
226 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
227 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 228
d01a7826
PE
229 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
230 (EMACS_UINTPTR): Likewise, with uintptr_t.
231
7fd47d5c
PE
232 * lisp.h: Prefer 64-bit EMACS_INT if available.
233 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
234 on 32-bit hosts that have 64-bit int, so that they can access
235 large files.
122b0c86
PE
236 However, temporarily disable this change unless the temporary
237 symbol WIDE_EMACS_INT is defined.
7fd47d5c 238
8727937b
PE
239 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
240
8ac068ac
PE
241 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
242 This removes an assumption that EMACS_INT and long are the same
243 width as pointers. The assumption is true for Emacs porting targets
244 now, but we want to make other targets possible.
245 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
246 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
247 In the rest of the code, change types of integers that hold casted
248 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
249 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
250 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
251 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
252 No need to cast type when ORing.
253 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
254 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
255 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
256 assume EMACS_INT is the same width as char *.
257 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
258 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
259 Remove no-longer-needed casts.
260 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
261 (xg_tool_bar_help_callback, xg_make_tool_item):
262 Use EMACS_INTPTR to hold an integer
263 that will be cast to void *; this can avoid a GCC warning
264 if EMACS_INT is not the same width as void *.
265 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
266 * xdisp.c (display_echo_area_1, resize_mini_window_1):
267 (current_message_1, set_message_1):
268 Use a local to convert to proper width without a cast.
269 * xmenu.c (dialog_selection_callback): Likewise.
270
ede49d71
PE
271 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
272 Also, don't assume VALBITS / RAND_BITS is less than 5,
273 and don't rely on undefined behavior when shifting a 1 left into
274 the sign bit.
275 * lisp.h (get_random): Change signature to match.
276
2f30ecd0
PE
277 * lread.c (hash_string): Use size_t, not int, for hash computation.
278 Normally we prefer signed values; but hashing is special, because
279 it's better to use unsigned division on hash table sizes so that
280 the remainder is nonnegative. Also, size_t is the natural width
281 for hashing into memory. The previous code used 'int', which doesn't
282 retain enough info to hash well into very large tables.
283 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
284
2a866e7b
PE
285 * dbusbind.c: Don't possibly lose pointer info when converting.
286 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
287 Use XPNTR rather than XHASH, so that the high-order bits of
288 the pointer aren't lost when converting through void *.
289
51639eac
PE
290 * eval.c (Fautoload): Don't double-shift a pointer.
291
92394119
PE
292 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
293
dbdb9a7c
JB
2942011-05-06 Juanma Barranquero <lekktu@gmail.com>
295
296 * gnutls.c (DEF_GNUTLS_FN):
297 * image.c (DEF_IMGLIB_FN): Make function pointers static.
298
db7a0b4f
AS
2992011-05-05 Andreas Schwab <schwab@linux-m68k.org>
300
301 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
302 marker. (Bug#8610)
303
f7ff1b0f 3042011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
305
306 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
307 New version that can reserve upto 2GB of heap space.
308
f7ff1b0f 3092011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
310
311 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
312
639c109b
TZ
3132011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
314
315 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
316 `gnutls_certificate_set_x509_key_file'.
317
d2127135
JB
3182011-05-05 Juanma Barranquero <lekktu@gmail.com>
319
320 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
321 Update dependencies.
322
e968f4f3
JB
3232011-05-04 Juanma Barranquero <lekktu@gmail.com>
324
325 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
326 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
327 Remove unused parameter `fildes'.
328 * process.c (read_process_output, send_process): Don't pass it.
329
84d358f0
JB
3302011-05-04 Juanma Barranquero <lekktu@gmail.com>
331
332 Fix previous change: the library cache is defined in w32.c.
333 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
334 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
335
0898ca10
JB
3362011-05-04 Juanma Barranquero <lekktu@gmail.com>
337
338 Implement dynamic loading of GnuTLS on Windows.
339
340 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
341 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
342 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
343 Declare.
344
345 * gnutls.c (Qgnutls_dll): Define.
346 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
347 (gnutls_*): Declare function pointers.
348 (init_gnutls_functions): New function to initialize function pointers.
349 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
350 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
351 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
352 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
353 (emacs_gnutls_write, emacs_gnutls_read)
354 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
355 (Fgnutls_available_p): New function.
356 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
357 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
358 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
359
360 * image.c: Include w32.h.
361 (Vimage_type_cache): Delete.
362 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
363 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
364 (w32_delayed_load): Move to w32.c.
365
366 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
367
368 * w32.c (QCloaded_from, Vlibrary_cache): Define.
369 (w32_delayed_load): Move from image.c. When loading a library, record
370 its filename in the :loaded-from property of the library id.
371 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
372 Initialize and staticpro them.
373 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
374
375 * process.c: Include lisp.h before w32.h, not after.
376 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
377 instead of gnutls_record_check_pending.
378
379 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
380
ff4de4aa
TZ
3812011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
382
383 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
384 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
385 as passed in.
386
abe95abb
JD
3872011-05-03 Jan Djärv <jan.h.d@swipnet.se>
388
389 * xterm.c (x_set_frame_alpha): Do not set property on anything
390 else than FRAME_X_OUTER_WINDOW (Bug#8608).
391
e16e55d4
JB
3922011-05-02 Juanma Barranquero <lekktu@gmail.com>
393
394 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
395
bafcf6a5
JB
3962011-05-02 Juanma Barranquero <lekktu@gmail.com>
397
398 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
399 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
400 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
401 (gnutls_global_initialized, Qgnutls_bootprop_priority)
402 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
403 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
404 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
405 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
406 (Qgnutls_bootprop_callbacks_verify): Make static.
407
e7a6747f
AS
4082011-05-01 Andreas Schwab <schwab@linux-m68k.org>
409
19ed11ba
AS
410 * callproc.c: Indentation fixup.
411
e7a6747f 412 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
413 (wait_for_termination, interruptible_wait_for_termination):
414 Move after wait_for_termination_1.
e7a6747f 415
1ef14cb4
LMI
4162011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
417
418 * sysdep.c (interruptible_wait_for_termination): New function
419 which is like wait_for_termination, but allows keyboard
420 interruptions.
421
422 * callproc.c (Fcall_process): Add (:file "file") as an option for
423 the STDOUT buffer.
424 (Fcall_process_region): Ditto.
425
330d880c
EZ
4262011-04-30 Eli Zaretskii <eliz@gnu.org>
427
8db90b73
EZ
428 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
429 rather than `XVECTOR (FOO)->size'.
430
330d880c
EZ
431 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
432 inttypes.h, as a gnulib replacement is used if it not available in
433 system headers.
434
15cbd324
EZ
4352011-04-21 Eli Zaretskii <eliz@gnu.org>
436
437 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
438 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
439 of MOST_POSITIVE_FIXNUM. (Bug#8528)
440
441 * coding.c (coding_alloc_by_realloc): Error out if destination
442 will grow beyond MOST_POSITIVE_FIXNUM.
443 (decode_coding_emacs_mule): Abort if there isn't enough place in
444 charbuf for the composition carryover bytes. Reserve an extra
445 space for up to 2 characters produced in a loop.
446 (decode_coding_iso_2022): Abort if there isn't enough place in
447 charbuf for the composition carryover bytes.
448
4492011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 450
ae940cca
EZ
451 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
452 aborting when %lld or %lll format is passed.
453 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
454 %llo or %llx format is passed. (Bug#8545)
455
03ab8921
EZ
456 * window.c (window_scroll_line_based): Use a marker instead of
457 simple variables to record original value of point. (Bug#7952)
458
afda1437
EZ
459 * doprnt.c (doprnt): Fix the case where a multibyte sequence
460 produced by %s or %c overflows available buffer space. (Bug#8545)
461
f76dee0c
PE
4622011-04-28 Paul Eggert <eggert@cs.ucla.edu>
463
464 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 465 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 466
fdc5744d
JB
4672011-04-28 Juanma Barranquero <lekktu@gmail.com>
468
469 * w32.c (init_environment): Warn about defaulting HOME to C:\.
470
638f053a
JB
4712011-04-28 Juanma Barranquero <lekktu@gmail.com>
472
473 * keyboard.c (Qdelayed_warnings_hook): Define.
474 (command_loop_1): Run `delayed-warnings-hook'
475 if Vdelayed_warnings_list is non-nil.
476 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
477 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
478
d178f871
EZ
4792011-04-28 Eli Zaretskii <eliz@gnu.org>
480
481 * doprnt.c (doprnt): Don't return value smaller than the buffer
482 size if the message was truncated. (Bug#8545).
483
b124fd93
JB
4842011-04-28 Juanma Barranquero <lekktu@gmail.com>
485
486 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
487 (Fx_window_property): #if-0 the whole functions, not just the bodies.
488
e810457d
PE
4892011-04-27 Paul Eggert <eggert@cs.ucla.edu>
490
491 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
492
ea51cceb
JB
4932011-04-27 Juanma Barranquero <lekktu@gmail.com>
494
495 * makefile.w32-in: Update dependencies.
496
94dcfacf
EZ
4972011-04-27 Eli Zaretskii <eliz@gnu.org>
498
499 Improve `doprnt' and its usage. (Bug#8545)
500 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
501 `format_end'. Remove support for %l as a conversion specifier.
502 Don't use xrealloc. Improve diagnostics when the %l size modifier
503 is used. Update the commentary.
504
505 * eval.c (verror): Simplify calculation of size_t.
506
507 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
508 messages.
509
f61f41d7
PE
5102011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
511
512 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
513 change.
514
96fb4434
PE
5152011-04-27 Paul Eggert <eggert@cs.ucla.edu>
516
517 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
518 This makes this file independent of the recent pseudovector change.
519
671875da 5202011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 521
69e9b5a3
PE
522 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
523
b5f869a7 524 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 525 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 526 Remove unused local.
c8926152 527 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 528
841a1577 529 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
530 GCC 4.6.0 optimizes based on type-based alias analysis.
531 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
532 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
533 != &v->size, and therefore "v->size = 1; b->size = 2; return
534 v->size;" must therefore return 1. This assumption is incorrect
535 for Emacs, since it type-puns struct Lisp_Vector * with many other
536 types. To fix this problem, this patch adds a new type struct
f904488f 537 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
538 and pseudovectors, and helps optimizing compilers not get fooled
539 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
540 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
541 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
542 the size member.
eab3844f
PE
543 (XSETPVECTYPE): Rewrite in terms of new macro.
544 (XSETPVECTYPESIZE): New macro, specifying both type and size.
545 This is a bit clearer, and further avoids the possibility of
546 undesirable aliasing.
547 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 548 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
549 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
550 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
551 (ASIZE): Now uses header.size rather than size.
552 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
553 to avoid the hassle of writing XVECTOR (foo)->header.size.
554 (struct vectorlike_header): New type.
eab3844f
PE
555 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
556 object, to help avoid aliasing.
557 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
558 (SUBRP): Likewise, since Lisp_Subr is a special case.
559 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
560 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
561 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 562 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
563 changed to be "header.size" and "header.next".
564 * buffer.h (struct buffer): Likewise.
565 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
566 * frame.h (struct frame): Likewise.
567 * process.h (struct Lisp_Process): Likewise.
568 * termhooks.h (struct terminal): Likewise.
569 * window.c (struct save_window_data, struct saved_window): Likewise.
570 * window.h (struct window): Likewise.
571 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
572 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
573 * buffer.c (init_buffer_once): Likewise.
574 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
575 special case.
576 * process.c (Fformat_network_address): Use local var for size,
577 for brevity.
578
0df1eac5
PE
579 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
580
847ab9d1 581 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
582 * data.c (atof): Remove decl; no longer used or needed.
583 (digit_to_number): Move to lread.c.
584 (Fstring_to_number): Use new string_to_number function, to be
585 consistent with how the Lisp reader treats infinities and NaNs.
586 Do not assume that floating-point numbers represent EMACS_INT
587 without losing information; this is not true on most 64-bit hosts.
588 Avoid double-rounding errors, by insisting on integers when
589 parsing non-base-10 numbers, as the documentation specifies.
590 * lisp.h (string_to_number): New decl, replacing ...
591 (isfloat_string): Remove.
bc0a5c13 592 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 593 (read1): Do not accept +. and -. as integers; this
452f4150
PE
594 appears to have been a coding error. Similarly, do not accept
595 strings like +-1e0 as floating point numbers. Do not report
596 overflow for integer overflows unless the base is not 10 which
597 means we have no simple and reliable way to continue.
598 Break out the floating-point parsing into a new
599 function string_to_number, so that Fstring_to_number parses
600 floating point numbers consistently with the Lisp reader.
04f2d78b 601 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
602 (E_CHAR, EXP_INT): Remove, replacing with ...
603 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
604 (string_to_number): New function, replacing isfloat_string.
605 This function checks for valid syntax and produces the resulting
606 Lisp float number too. Rework it so that string-to-number
bc0a5c13 607 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
608 so that overflow for non-base-10 numbers is reported only when
609 there's no portable and simple way to convert to floating point.
452f4150 610
67769ffc
PE
611 * textprop.c (set_text_properties_1): Rewrite for clarity,
612 and to avoid GCC warning about integer overflow.
613
c20db43f
PE
614 * intervals.h (struct interval): Use EMACS_INT for members
615 where EMACS_UINT might cause problems. See
616 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
617 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
618 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
619 All uses changed.
37aa2f85
PE
620 (offset_intervals): Tell GCC not to worry about length overflow
621 when negating a negative length.
c20db43f 622
2538aa2f
PE
623 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
624 (overrun_check_free): Likewise.
625
f2d3008d
PE
626 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
627 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
628 word size.
629
ec8df744
PE
630 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
631 (gnutls_make_error): Rename local to avoid shadowing.
632 (gnutls_emacs_global_deinit): ifdef out; not used.
633 (Fgnutls_boot): Use const for pointer to readonly storage.
634 Comment out unused local. Fix pointer signedness problems.
635
640ee02d
PE
636 * lread.c (openp): Don't stuff size_t into an 'int'.
637 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
638 about possible signed overflow.
639
6048fb2a
PE
640 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
641 (GDK_KEY_g): Don't define if already defined.
642 (xg_prepare_tooltip): Avoid pointer signedness problem.
643 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
644
fa3c87e1
PE
645 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
646 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
647
2172544b
PE
648 * xfns.c (Fx_window_property): Simplify a bit,
649 to make a bit faster and to avoid GCC 4.6.0 warning.
650 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
651
9b821a21
PE
652 * fns.c (internal_equal): Don't assume size_t fits in int.
653
3c616cfa
PE
654 * alloc.c (compact_small_strings): Tighten assertion a little.
655
c2982e87
PE
656 Replace pEd with more-general pI, and fix some printf arg casts.
657 * lisp.h (pI): New macro, generalizing old pEd macro to other
658 conversion specifiers. For example, use "...%"pI"d..." rather
659 than "...%"pEd"...".
660 (pEd): Remove. All uses replaced with similar uses of pI.
661 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
662 * alloc.c (check_pure_size): Don't overflow by converting size to int.
663 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
664 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
665 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
666 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
667 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
668 64-bit hosts.
669 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
670 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
671 * print.c (safe_debug_print, print_object): Likewise.
672 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
673 to int.
6f04d126
PE
674 Use pI instead of if-then-else-abort. Use %p to avoid casts,
675 avoiding the 0 flag, which is not portable.
c2982e87
PE
676 * process.c (Fmake_network_process): Use pI to avoid cast.
677 * region-cache.c (pp_cache): Likewise.
678 * xdisp.c (decode_mode_spec): Likewise.
679 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
680 behavior on 64-bit hosts with printf arg.
6f04d126 681 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
682 (x_stop_queuing_selection_requests): Likewise.
683 (x_get_window_property): Don't truncate byte count to an 'int'
684 when tracing.
0b432f21 685
5e073ec7
PE
686 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
687 here, since it parses constructs like leading '-' and spaces,
688 which are not wanted; and it overflows with large numbers.
689 Instead, simply match F[0-9]+, which is what is wanted anyway.
690
36372bf9
PE
691 * alloc.c: Remove unportable assumptions about struct layout.
692 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
693 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
694 (allocate_vectorlike, make_pure_vector): Use the new macros,
695 plus offsetof, to remove unportable assumptions about struct layout.
696 These assumptions hold on all porting targets that I know of, but
697 they are not guaranteed, they're easy to remove, and removing them
698 makes further changes easier.
699
0b432f21
PE
700 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
701 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
702 (string_overrun_cookie): Now const. Use initializers that
703 don't formally overflow signed char, to avoid warnings.
000098c1
PE
704 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
705 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
706 (allocate_buffer): Don't assume sizeof (struct buffer) is a
707 multiple of sizeof (EMACS_INT); it need not be, if
708 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 709 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 710
895009e1
JB
7112011-04-26 Juanma Barranquero <lekktu@gmail.com>
712
713 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
714
6a7a1b0b
TZ
7152011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
716
717 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 718 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
719 Reported by Paul Eggert <eggert@cs.ucla.edu>.
720
841a1577 7212011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
722
723 * lisp.h (Qdebug): List symbol.
895009e1 724 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
725 * keyboard.c (debug-on-event): New variable.
726 (handle_user_signal): Break into debugger when debug-on-event
727 matches the current signal symbol.
728
f2d3ba6f
DN
7292011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
730
731 * alloc.c (check_sblock, check_string_bytes)
732 (check_string_free_list): Convert to standard C.
733
42ce4c63
TZ
7342011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
735
736 * w32.c (emacs_gnutls_push): Fix typo.
737
825cd63c
EZ
7382011-04-25 Eli Zaretskii <eliz@gnu.org>
739
fb11d64d
EZ
740 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
741 "cast to pointer from integer of different size".
742
825cd63c
EZ
743 Improve doprnt and its use in verror. (Bug#8545)
744 * doprnt.c (doprnt): Document the set of format control sequences
745 supported by the function. Use SAFE_ALLOCA instead of always
746 using `alloca'.
747
748 * eval.c (verror): Don't limit the buffer size at size_max-1, that
749 is one byte too soon. Don't use xrealloc; instead xfree and
750 xmalloc anew.
751
e061a11b
TZ
7522011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
753
754 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
755 callbacks stage.
756
757 * gnutls.c: Renamed global_initialized to
758 gnutls_global_initialized. Added internals for the
759 :verify-hostname-error, :verify-error, and :verify-flags
760 parameters of `gnutls-boot' and documented those parameters in the
761 docstring. Start callback support.
762 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
763 unless a fatal error occured. Call gnutls_alert_send_appropriate
764 on error. Return error code.
765 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
766 (emacs_gnutls_read): Likewise.
767 (Fgnutls_boot): Return handshake error code.
768 (emacs_gnutls_handle_error): New function.
769 (wsaerror_to_errno): Likewise.
770
771 * w32.h (emacs_gnutls_pull): Add prototype.
772 (emacs_gnutls_push): Likewise.
773
774 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
775 (emacs_gnutls_push): Likewise.
776
7772011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
778
779 * process.c (wait_reading_process_output): Check if GnuTLS
780 buffered some data internally if no FDs are set for TLS
781 connections.
782
783 * makefile.w32-in (OBJ2): Add gnutls.$(O).
784 (LIBS): Link to USER_LIBS.
785 ($(BLD)/gnutls.$(0)): New target.
786
fa6996bc
EZ
7872011-04-24 Eli Zaretskii <eliz@gnu.org>
788
eb35682e
EZ
789 * xdisp.c (handle_single_display_spec): Rename the
790 display_replaced_before_p argument into display_replaced_p, to
791 make it consistent with the commentary. Fix typos in the
792 commentary.
793
e2ad650c
EZ
794 * textprop.c (syms_of_textprop): Remove dead code.
795 (copy_text_properties): Delete obsolete commentary about an
796 interface that was deleted long ago. Fix typos in the description
797 of arguments.
798
1b2de274
EZ
799 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
800 to changes in oldXMenu/XMenu.h from 2011-04-16.
801 <menu_help_message, prev_menu_help_message>: Constify.
802 (IT_menu_make_room): menu->help_text is now `const char **';
803 adjust.
804
805 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
806 to changes in oldXMenu/XMenu.h from 2011-04-16.
807 (struct XMenu): Declare `help_text' `const char **'.
808
809 * xfaces.c <Qunspecified>: Make extern again.
810
811 * syntax.c: Include sys/types.h before including regex.h, as
812 required by Posix.
813
762b15be
EZ
814 * doc.c (get_doc_string): Improve the format passed to `error'.
815
816 * doprnt.c (doprnt): Improve commentary.
817
818 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
819
820 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
821 them with etags.
822
f1052e5d
EZ
823 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
824 changes in globals.h immediately force recompilation.
762b15be
EZ
825 (TAGS): Depend on $(CURDIR)/m/intel386.h and
826 $(CURDIR)/s/ms-w32.h.
827 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 828
fa6996bc
EZ
829 * character.c (Fchar_direction): Function deleted.
830 (syms_of_character): Don't defsubr it.
831 <char-direction-table>: Deleted.
832
e6c3da20
EZ
8332011-04-23 Eli Zaretskii <eliz@gnu.org>
834
835 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
836 * doprnt.c: Include limits.h.
837 (SIZE_MAX): New macro.
04f2d78b
CB
838 (doprnt): Return a size_t value. 2nd arg is now size_t.
839 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
840 Improve overflow protection. Support `l' modifier for integer
841 conversions. Support %l conversion. Don't assume an EMACS_INT
842 argument for integer conversions and for %c.
843
844 * lisp.h (doprnt): Restore prototype.
845
846 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
847 $(SRC)/character.h.
848
849 * Makefile.in (base_obj): Add back doprnt.o.
850
851 * deps.mk (doprnt.o): Add back prerequisites.
852 (callint.o): Depend on character.h.
853
854 * eval.c (internal_lisp_condition_case): Include the handler
855 representation in the error message.
856 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
857 when breaking from the loop.
858
859 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
860
861 * callint.c (Fcall_interactively): When displaying error message
862 about invalid control letter, pass the character's codepoint, not
863 a pointer to its multibyte form. Improve display of the character
864 in octal and display also its hex code.
865
866 * character.c (char_string): Use %x to display the (unsigned)
867 codepoint of an invalid character, to avoid displaying a bogus
868 negative value.
869
870 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
871 `error', not SYMBOL_NAME itself.
872
873 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
874 character arguments to `error'.
875
876 * charset.c (check_iso_charset_parameter): Fix incorrect argument
877 to `error' in error message about FINAL_CHAR argument. Make sure
878 FINAL_CHAR is a character, and use %c when it is passed as
879 argument to `error'.
880
4ffd0d6b 8812011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
882
883 * s/ms-w32.h (localtime): Redirect to sys_localtime.
884
885 * w32.c: Include <time.h>.
886 (sys_localtime): New function.
887
4ffd0d6b 8882011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
889
890 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
891
4ffd0d6b 892 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 893
4ffd0d6b 8942011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 895
4ffd0d6b
GM
896 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
897 zombies (Bug#8467).
aac0c6e3 898
04c56954
EZ
8992011-04-19 Eli Zaretskii <eliz@gnu.org>
900
901 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
902 gl_state.e_property when gl_state.object is Qt.
903
904 * insdel.c (make_gap_larger): Remove limitation of buffer size
905 to <= INT_MAX.
906
16a43933
CY
9072011-04-18 Chong Yidong <cyd@stupidchicken.com>
908
909 * xdisp.c (lookup_glyphless_char_display)
910 (produce_glyphless_glyph): Handle cons cell entry in
911 glyphless-char-display.
912 (Vglyphless_char_display): Document it.
913
914 * term.c (produce_glyphless_glyph): Handle cons cell entry in
915 glyphless-char-display.
916
4581706e
CY
9172011-04-17 Chong Yidong <cyd@stupidchicken.com>
918
919 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
920
921 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
922
923 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
924 definition for no-X builds.
925
4887c6e2 9262011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 927
fd35b6f9
PE
928 Static checks with GCC 4.6.0 and non-default toolkits.
929
5c1ccb01
PE
930 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
931
006c5daa
PE
932 * process.c (keyboard_bit_set): Define only if SIGIO.
933 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
934 (send_process): Repair possible setjmp clobbering.
935
efc736d3
PE
936 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
937
4e2fe2e6
PE
938 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
939
f97334a2
PE
940 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
941
4e75f29d
PE
942 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
943 Define only if needed.
944
90efadd1
PE
945 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
946 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 947 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 948
3c647824
PE
949 * dispextern.h (struct redisplay_interface): Rename param
950 to avoid shadowing.
e264f262 951 * termhooks.h (struct terminal): Likewise.
761383f4 952 * xterm.c (xembed_send_message): Likewise.
3c647824 953
b58c5c4a
PE
954 * insdel.c (make_gap_smaller): Define only if
955 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
956
cad59032
PE
957 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
958 it.
959
c339dc2e
PE
960 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
961 so that we aren't warned about unused symbols.
962
91a3e27b
PE
963 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
964
399c71d3 965 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 966
8ffc96f5
PE
967 * xfns.c (x_real_positions): Mark locals as initialized.
968
eef9bc79
PE
969 * xmenu.c (xmenu_show): Don't use uninitialized vars.
970
098db9dd
PE
971 * xterm.c: Fix problems found by static analysis with other toolkits.
972 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
973 (x_dispatch_event): Declare static if USE_GTK, and
974 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 975 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 976 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
977 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
978 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 979
eb18f6cc
PE
980 * xmenu.c (menu_help_callback): Pointer type fixes.
981 Use const pointers when pointing at readonly data. Avoid pointer
982 signedness clashes.
983 (FALSE): Remove unused macro.
984 (update_frame_menubar): Remove unused decl.
985
1fe72bf8
PE
986 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
987
60d9e1db
PE
988 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
989 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
990 (single_menu_item): Rename local to avoid shadowing.
991
39261c26
PE
992 * keyboard.c (make_lispy_event): Remove unused local var.
993
018c5e19
PE
994 * frame.c, frame.h (x_get_resource_string): Bring this back, but
995 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
996
63d2b86e
PE
997 * bitmaps: Change bitmaps from unsigned char back to the X11
998 compatible char. Avoid the old compiler warnings about
999 out-of-range initializers by using, for example, '\xab' rather
1000 than 0xab.
1001
aefd87e1
PE
1002 * xgselect.c (xgselect_initialize): Check vs interface
1003 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1004
bf501fb9
PE
1005 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1006
e9829fdf
PE
1007 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1008 to read-only memory.
1009
1086c095
PE
1010 * fns.c (vector): Remove; this old hack is no longer needed.
1011
2baccd04 1012 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1013 Remove unused var.
dde42981 1014 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1015
72391843 1016 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1017
436c16df 1018 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1019 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1020 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1021
92bb796d 1022 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1023 (x_term_init): Remove local to avoid shadowing.
92bb796d 1024
764430a3 1025 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1026
1027 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1028 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1029
d1dfb56c
EZ
10302011-04-16 Eli Zaretskii <eliz@gnu.org>
1031
c4354cb4
EZ
1032 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1033
d1dfb56c
EZ
1034 Fix regex.c, syntax.c and friends for buffers > 2GB.
1035 * syntax.h (struct gl_state_s): Declare character position members
1036 EMACS_INT.
1037
1038 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1039
04f2d78b
CB
1040 * textprop.c (verify_interval_modification, interval_of):
1041 Declare arguments EMACS_INT.
d1dfb56c
EZ
1042
1043 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1044 EMACS_INT.
1045
1046 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1047
1048 * indent.c (Fvertical_motion): Local variable it_start is now
1049 EMACS_INT.
1050
1051 * regex.c (re_match, re_match_2, re_match_2_internal)
1052 (bcmp_translate, regcomp, regexec, print_double_string)
1053 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1054 (re_compile_pattern, re_exec): Declare arguments and local
1055 variables `size_t' and `ssize_t' and return values `regoff_t', as
1056 appropriate.
1057 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1058 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1059 <compile_stack_type>: `size' and `avail' are now `size_t'.
1060
1061 * regex.h <regoff_t>: Use ssize_t, not int.
1062 (re_search, re_search_2, re_match, re_match_2): Arguments that
1063 specify buffer/string position and length are now ssize_t and
1064 size_t. Return type is regoff_t.
1065
613052cd
BK
10662011-04-16 Ben Key <bkey76@gmail.com>
1067
1068 * nsfont.m: Fixed bugs in ns_get_family and
1069 ns_descriptor_to_entity that were caused by using free to
1070 deallocate memory blocks that were allocated by xmalloc (via
1071 xstrdup). This caused Emacs to crash when compiled with
1072 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1073 --enable-checking=xmallocoverrun). xfree is now used to
1074 deallocate these memory blocks.
1075
4170f62f 10762011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1077
71b41406
PE
1078 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1079
9587a89d
PE
1080 emacs_write: Accept and return EMACS_INT for sizes.
1081 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1082 et seq.
1083 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1084 Accept and return EMACS_INT.
1085 (emacs_gnutls_write): Return the number of bytes written on
1086 partial writes.
1087 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1088 (emacs_read, emacs_write): Remove check for negative size, as the
1089 Emacs source code has been audited now.
9587a89d
PE
1090 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1091 (emacs_read, emacs_write): Use it.
273a5f82
PE
1092 * process.c (send_process): Adjust to the new signatures of
1093 emacs_write and emacs_gnutls_write. Do not attempt to store
1094 a byte offset into an 'int'; it might overflow.
9587a89d 1095 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1096
3e047f51
PE
1097 * sound.c: Don't assume sizes fit in 'int'.
1098 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1099 Return EMACS_INT, not int.
3e047f51 1100 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1101 Accept EMACS_INT, not int.
1102 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1103 record read return values.
1104
cc39a9db
BK
11052011-04-15 Ben Key <bkey76@gmail.com>
1106
c9d0ec6d
JB
1107 * keyboard.c (Qundefined): Don't declare static since it is used
1108 in nsfns.m.
1109 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1110 static since they are used in nsfont.m.
cc39a9db 1111
6c60eb9f
SM
11122011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1113
1114 * process.c (Qprocessp): Don't declare static.
1115 * lisp.h (Qprocessp): Declare again.
1116
7990b61a
JB
11172011-04-15 Juanma Barranquero <lekktu@gmail.com>
1118
1119 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1120
5d4cb038
PE
11212011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1122
8bd7b830 1123 Improve C-level modularity by making more things 'static'.
cd64ea1d 1124
e3b27b31
PE
1125 Don't publish debugger-only interfaces to other modules.
1126 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1127 (verify_bytepos, count_markers): Move decls to the only modules
1128 that need them.
1129 * region-cache.h (pp_cache): Likewise.
1130 * window.h (check_all_windows): Likewise.
1131 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1132
5d4cb038
PE
1133 * sysdep.c (croak): Now static, if
1134 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1135 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1136
1137 * alloc.c (refill_memory_reserve): Now static if
1138 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1139 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1140
e87b6180
PE
1141 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1142 Define only if USE_LUCID.
1143
ac64929e
PE
1144 * xrdb.c (x_customization_string, x_rm_string): Now static.
1145
6f37259d
PE
1146 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1147 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1148
1683e3ab
PE
1149 * xdisp.c (draw_row_with_mouse_face): Now static.
1150 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1151
de9c2632
PE
1152 * window.h (check_all_windows): Mark externally visible.
1153
2b96acb7
PE
1154 * window.c (window_deletion_count): Now static.
1155
1156 * undo.c: Make symbols static if they're not exported.
1157 (last_undo_buffer, last_boundary_position, pending_boundary):
1158 Now static.
1159
50436f33
PE
1160 * textprop.c (interval_insert_behind_hooks): Now static.
1161 (interval_insert_in_front_hooks): Likewise.
1162
64520e5c
PE
1163 * term.c: Make symbols static if they're not exported.
1164 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1165 (max_frame_lines, tty_set_terminal_modes):
1166 (tty_reset_terminal_modes, tty_turn_off_highlight):
1167 (get_tty_terminal): Now static.
1168 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1169 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1170 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1171 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1172 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1173
1fa53021
PE
1174 * sysdep.c: Make symbols static if they're not exported.
1175 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1176 Now static.
1177 (sigprocmask_set, full_mask): Remove; unused.
1178 (wait_debugging): Mark as visible.
1179 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1180 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1181
d4b43b22
PE
1182 * syntax.c (syntax_temp): Define only if !__GNUC__.
1183
b7c513d0
PE
1184 * sound.c (current_sound_device, current_sound): Now static.
1185
989b29ad
PE
1186 * search.c (searchbufs, searchbuf_head): Now static.
1187
13a55a78
PE
1188 * scroll.c (scroll_cost): Remove; unused.
1189 * dispextern.h (scroll_cost): Remove decl.
1190
de68a1fc
PE
1191 * region-cache.h (pp_cache): Mark as externally visible.
1192
40ccffa6
PE
1193 * process.c: Make symbols static if they're not exported.
1194 (process_tick, update_tick, create_process, chan_process):
1195 (Vprocess_alist, proc_buffered_char, datagram_access):
1196 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1197 (deactivate_process): Mark defn as static, as well as decl.
1198 * lisp.h (create_process): Remove decl.
1199 * process.h (chan_process, Vprocess_alist): Remove decls.
1200
ad64fc97
PE
1201 * print.c: Make symbols static if they're not exported.
1202 (print_depth, new_backquote_output, being_printed, print_buffer):
1203 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1204 (print_interval, print_number_index, initial_stderr_stream):
1205 Now static.
1206 * lisp.h (Fprinc): Remove decl.
1207 (debug_output_compilation_hack): Mark as externally visible.
1208
adddb265
PE
1209 * sysdep.c (croak): Move decl from here to syssignal.h.
1210 * syssignal.h (croak): Put it here, so the API can be checked when
1211 'croak' is called from dissociate_if_controlling_tty.
1212
1717ede2
PE
1213 * minibuf.c: Make symbols static if they're not exported.
1214 (minibuf_save_list, choose_minibuf_frame): Now static.
1215 * lisp.h (choose_minibuf_frame): Remove decl.
1216
fa5fb2bc
PE
1217 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1218
1e3890d1
PE
1219 * lread.c: Make symbols static if they're not exported.
1220 (read_objects, initial_obarray, oblookup_last_bucket_number):
1221 Now static.
1222 (make_symbol): Remove; unused.
1223 * lisp.h (initial_obarray, make_symbol): Remove decls.
1224
8a1414fa
PE
1225 * keyboard.c: Make symbols static if they're not exported.
1226 (single_kboard, recent_keys_index, total_keys, recent_keys):
1227 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1228 (this_single_command_key_start, echoing, last_auto_save):
1229 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1230 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1231 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1232 (Vlispy_mouse_stem, double_click_count):
1233 Now static.
1234 (force_auto_save_soon): Define only if SIGDANGER.
1235 (ignore_mouse_drag_p): Now static if
1236 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1237 (print_help): Remove; unused.
1238 (stop_character, last_timer_event): Mark as externally visible.
1239 * keyboard.h (ignore_mouse_drag_p): Declare only if
1240 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1241 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1242 * lisp.h (echoing): Remove decl.
1243 (force_auto_save_soon): Declare only if SIGDANGER.
1244 * xdisp.c (redisplay_window): Simplify code, to make it more
1245 obvious that ignore_mouse_drag_p is not accessed if !defined
1246 USE_GTK && !defined HAVE_NS.
1247
93ea6e8f
PE
1248 * intervals.c: Make symbols static if they're not exported.
1249 (merge_properties_sticky, merge_interval_right, delete_interval):
1250 Now static.
1251 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1252
77382fcc
PE
1253 * insdel.c: Make symbols static if they're not exported.
1254 However, leave prepare_to_modify_buffer alone. It's never
1255 called from outside this function, but that appears to be a bug.
1256 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1257 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1258 (adjust_after_replace_noundo): Remove; unused.
1259 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1260 (signal_before_change): Remove decls.
77382fcc 1261
9306c32e
PE
1262 * indent.c (val_compute_motion, val_vmotion): Now static.
1263
cd44d2eb
PE
1264 * image.c: Make symbols static if they're not exported.
1265 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1266 if USE_GTK.
1267 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1268 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1269
ad9a7a06
PE
1270 * fringe.c (standard_bitmaps): Now static.
1271 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1272
81626931
PE
1273 * frame.c: Make symbols static if they're not exported.
1274 (x_report_frame_params, make_terminal_frame): Now static.
1275 (get_frame_param): Now static, unless HAVE_NS.
1276 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1277 (x_get_resource_string): Remove; not used.
1278 * frame.h (make_terminal_frame, x_report_frame_params):
1279 (x_get_resource_string); Remove decls.
1280 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1281 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1282
239f9db9
PE
1283 * font.c, fontset.c: Make symbols static if they're not exported.
1284 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1285 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1286 * font.c (font_close_object): Now static.
1287 * font.h (font_close_object): Remove.
1288 * fontset.c (FONTSET_OBJLIST): Remove.
1289 (free_realized_fontset) #if-0 the body, which does nothing.
1290 (face_suitable_for_char_p): #if-0, as it's never called.
1291 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1292 * xfaces.c (face_at_string_position):
1293 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1294 since 0 is always ASCII.
1295
dfcf3579
PE
1296 * fns.c (weak_hash_tables): Now static.
1297
5045092b
PE
1298 * fileio.c: Make symbols static if they're not exported.
1299 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1300 (Vwrite_region_annotation_buffers): Now static.
1301
57a96f5c
PE
1302 * eval.c: Make symbols static if they're not exported.
1303 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1304 * lisp.h (backtrace_list): Remove decl.
1305
35f08c38
PE
1306 * emacs.c: Make symbols static if they're not exported.
1307 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1308 (fatal_error_code, fatal_error_signal_hook, standard_args):
1309 Now static.
1310 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1311 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1312 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1313 * lisp.h (fatal_error_signal_hook): Remove decl.
1314 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1315
f44bd759
PE
1316 * editfns.c: Move a (normally-unused) function to its only use.
1317 * editfns.c, lisp.h (get_operating_system_release): Remove.
1318 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1319 worth the hassle of breaking this out.
1320
b532497d
PE
1321 * xterm.c: Make symbols static if they're not exported.
1322 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1323 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1324 (x_destroy_window, x_delete_display):
1325 Now static.
1326 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1327 (x_mouse_leave): Remove; unused.
1328 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1329 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1330 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1331 Remove decls.
1332 (x_mouse_leave): Declare only if WINDOWSNT.
1333 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1334 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1335 USE_X_TOOLKIT.
1336
1675728f
PE
1337 * ftxfont.c: Make symbols static if they're not exported.
1338 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1339 HAVE_FREETYPE.
1340 * font.h (ftxfont_driver): Likewise.
1341
e4cebfca
PE
1342 * xfns.c: Make symbols static if they're not exported.
1343 (x_last_font_name, x_display_info_for_name):
1344 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1345 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1346 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1347 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1348 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1349 (last_show_tip_args): Now static.
1350 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1351 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1352 (x_screen_planes): Remove; unused.
1353 * dispextern.h (x_screen_planes): Remove decl.
1354
5bf46f05
PE
1355 * dispnew.c: Make symbols static if they're not exported.
1356 * dispextern.h (redraw_garbaged_frames, scrolling):
1357 (increment_row_positions): Remove.
1358 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1359 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1360 Now static.
1361 (redraw_garbaged_frames): Remove; unused.
1362
435f4c28
PE
1363 * xfaces.c: Make symbols static if they're not exported.
1364 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1365 Remove decls.
1366 * xterm.h (defined_color): Remove decls.
1367 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1368 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1369 (menu_face_changed_default, defined_color, free_realized_face):
1370 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1371 (ascii_face_of_lisp_face): Remove; unused.
1372
8524aef3
PE
1373 * xdisp.c: Make symbols static if they're not exported.
1374 * dispextern.h (scratch_glyph_row, window_box_edges):
1375 (glyph_to_pixel_coords, set_cursor_from_row):
1376 (get_next_display_element, set_iterator_to_next):
1377 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1378 (show_mouse_face): Remove decls
1379 * frame.h (message_buf_print): Likewise.
1380 * lisp.h (pop_message, set_message, check_point_in_composition):
1381 Likewise.
1382 * xterm.h (set_vertical_scroll_bar): Likewise.
1383 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1384 (message_buf_print, scratch_glyph_row, displayed_buffer):
1385 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1386 (get_next_display_element, show_mouse_face, window_box_edges):
1387 (frame_to_window_pixel_xy, check_point_in_composition):
1388 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1389 (glyph_to_pixel_coords): Remove; unused.
1390
16390cd2
PE
1391 * dired.c (file_name_completion): Now static.
1392
1393 * dbusbind.c (xd_in_read_queued_messages): Now static.
1394
a25f4dfa
PE
1395 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1396 * data.c (circular_list_error): Remove.
1397
14a9c8df
PE
1398 * commands.h (last_point_position, last_point_position_buffer):
1399 (last_point_position_window): Remove decls.
1400 * keyboard.c: Make these variables static.
1401
04f2d78b
CB
1402 * coding.h (coding, code_convert_region, encode_coding_gap):
1403 Remove decls.
74ab6df5
PE
1404 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1405 (iso_code_class, detect_coding, code_convert_region): Now static.
1406 (encode_coding_gap): Remove; unused.
1407
38dfbee1
PE
1408 * chartab.c (chartab_chars, chartab_bits): Now static.
1409
a2cb4e63
PE
1410 * charset.h (charset_iso_8859_1): Remove decl.
1411 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1412 Now static.
1413
127198fd
PE
1414 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1415 * ccl.c (Vccl_program_table): Now static.
1416 (check_ccl_update): Remove; unused.
1417
d85b608f
PE
1418 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1419 * category.h: ... from here.
1420 * category.c (check_category_table, set_category_set): Now static.
1421
31cd66f3
PE
1422 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1423 * lisp.h: Remove these decls.
1424
c358e587
PE
1425 * buffer.c (buffer_count): Remove unused var.
1426
e78aecca
PE
1427 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1428 so that it's not optimized away.
1429 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1430 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1431 exported only to the debugger.
1432
e192d7d3 1433 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1434 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1435
92470028
PE
1436 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1437 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1438 was inaccessible from Lisp.
1439 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1440 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1441
244ed907
PE
1442 alloc.c: Import and export fewer symbols, and remove unused items.
1443 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1444 is defined.
1445 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1446 it's not optimized away by whole-program optimization.
1447 (message_enable_multibyte, free_misc): Remove.
1448 (catchlist, handlerlist, mark_backtrace):
1449 Declare only if BYTE_MARK_STACK.
1450 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1451 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1452 (message_enable_multibyte): Remove decl.
1453 (free_misc, interval_free_list, float_block, float_block_index):
1454 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1455 (cons_free_list, last_marked_index):
1456 Now static.
1457 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1458 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1459 (mark_backtrace): Define only if BYTE_MARK_STACK.
1460 * xdisp.c (message_enable_multibyte): Now static.
1461
61c2b50e 1462 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1463 This makes it easier for human readers (and static analyzers)
1464 to see whether these variables are used from other modules.
1465 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1466 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1467 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1468 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1469 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1470 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1471 * xmenu.c, xselect.c:
1472 Declare Q* vars static if they are not used in other modules.
1473 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1474 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1475 Remove decls of unexported vars.
1476 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1477
95c82688
PE
1478 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1479
16a97296
PE
1480 Make Emacs functions such as Fatom 'static' by default.
1481 This makes it easier for human readers (and static analyzers)
1482 to see whether these functions can be called from other modules.
1483 DEFUN now defines a static function. To make the function external
1484 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1485 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1486 (Finit_image_library):
16a97296
PE
1487 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1488 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1489 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1490 Remove decls, since these functions are now static.
1491 (Funintern, Fget_internal_run_time): New decls, since these functions
1492 were already external.
95c82688 1493
16a97296
PE
1494 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1495 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1496 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1497 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1498 * keyboard.c, keymap.c, lread.c:
1499 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1500 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1501 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1502 Mark functions with DEFUE instead of DEFUN,
1503 if they are used in other modules.
1504 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1505 decls for now-static functions.
1506 * buffer.h (Fdelete_overlay): Remove decl.
1507 * callproc.c (Fgetenv_internal): Mark as internal.
1508 * composite.c (Fremove_list_of_text_properties): Remove decl.
1509 (Fcomposition_get_gstring): New forward static decl.
1510 * composite.h (Fcomposite_get_gstring): Remove decl.
1511 * dired.c (Ffile_attributes): New forward static decl.
1512 * doc.c (Fdocumntation_property): New forward static decl.
1513 * eval.c (Ffetch_bytecode): New forward static decl.
1514 (Funintern): Remove extern decl; now in .h file where it belongs.
1515 * fileio.c (Fmake_symbolic_link): New forward static decl.
1516 * image.c (Finit_image_library): New forward static decl.
1517 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1518 * intervals.h (Fprevious_property_change):
1519 (Fremove_list_of_text_properties): Remove decls.
1520 * keyboard.c (Fthis_command_keys): Remove decl.
1521 (Fcommand_execute): New forward static decl.
1522 * keymap.c (Flookup_key): New forward static decl.
1523 (Fcopy_keymap): Now static.
1524 * keymap.h (Flookup_key): Remove decl.
1525 * process.c (Fget_process): New forward static decl.
1526 (Fprocess_datagram_address): Mark as internal.
1527 * syntax.c (Fsyntax_table_p): New forward static decl.
1528 (skip_chars): Remove duplicate decl.
1529 * textprop.c (Fprevious_property_change): New forward static decl.
1530 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1531 Now internal.
1532 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1533 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1534
785bbd42
PE
1535 * editfns.c (Fformat): Remove unreachable code.
1536
8b913b57
AS
15372011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1538
1539 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1540 change. (Bug#8496)
1541
a6744a35
EZ
15422011-04-13 Eli Zaretskii <eliz@gnu.org>
1543
1544 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1545 when at ZV. (Bug#8487)
1546
e7974947
AS
15472011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1548
baad03f0
AS
1549 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1550 (Bug#8437)
1551 * keyboard.c (parse_tool_bar_item): Likewise.
1552 * sound.c (sound_cleanup, alsa_close): Likewise.
1553 * termcap.c (tgetent): Likewise.
1554 * xfns.c (x_default_font_parameter): Likewise.
1555 * xsettings.c (read_and_apply_settings): Likewise.
1556
e7974947
AS
1557 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1558 (overrun_check_free): Protoize.
1559
28272684
PE
15602011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1563 since callers should never pass a negative size.
1564 Change the signature to match that of plain 'read' and 'write'; see
1565 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1566 * lisp.h: Update prototypes of emacs_write and emacs_read.
1567
11997c76
EZ
15682011-04-11 Eli Zaretskii <eliz@gnu.org>
1569
1570 * xdisp.c (redisplay_window): Don't try to determine the character
1571 position of the scroll margin if the window start point w->startp
e896f03c 1572 is outside the buffer's accessible region. (Bug#8468)
11997c76 1573
8a2cbd72
EZ
15742011-04-10 Eli Zaretskii <eliz@gnu.org>
1575
1576 Fix write-region and its subroutines for buffers > 2GB.
1577 * fileio.c (a_write, e_write): Modify declaration of arguments and
1578 local variables to support buffers larger than 2GB.
1579 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1580
1581 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1582 argument, local variables, and return value.
1583
1584 * lisp.h: Update prototypes of emacs_write and emacs_read.
1585
1586 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1587
4073e537 15882011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1589
1ebfdcb6
PE
1590 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1591
b2ded58d
PE
1592 Fix more problems found by GCC 4.6.0's static checks.
1593
7d66342c
PE
1594 * xdisp.c (vmessage): Use a better test for character truncation.
1595
bbf47d44
PE
1596 * charset.c (load_charset_map): <, not <=, for optimization,
1597 and to avoid potential problems with integer overflow.
9248994d 1598 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1599 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1600 * editfns.c (Fformat): Likewise.
1e69125e 1601 * syntax.c (skip_chars): Likewise.
3befa583 1602
e3019616
PE
1603 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1604 This also lets GCC 4.6.0 generate slightly better loop code.
1605
becfa255
PE
1606 * callint.c (Fcall_interactively): <, not <=, for optimization.
1607 (Fcall_interactively): Count the number of arguments produced,
1608 not the number of arguments given. This is simpler and lets GCC
1609 4.6.0 generate slightly better code.
1610
dae0cd48
PE
1611 * ftfont.c: Distingish more carefully between FcChar8 and char.
1612 The previous code passed unsigned char * to a functions like
1613 strlen and xstrcasecmp that expect char *, which does not
1614 conform to the C standard.
1615 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1616 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1617 char * when the C standard requires it.
1618
76032d70
PE
1619 * keyboard.c (read_char): Remove unused var.
1620
eb3f1cc8
PE
1621 * eval.c: Port to Windows vsnprintf (Bug#8435).
1622 Include <limits.h>.
1623 (SIZE_MAX): Define if the headers do not.
1624 (verror): Do not give up if vsnprintf returns a negative count.
1625 Instead, grow the buffer. This ports to Windows vsnprintf, which
1626 does not conform to C99. Problem reported by Eli Zaretskii.
1627 Also, simplify the allocation scheme, by avoiding the need for
1628 calling realloc, and removing the ALLOCATED variable.
1629
70476b54
PE
1630 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1631
12020a9e
PE
1632 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1633 But keep the doprint source code for now, as we might revamp it
1634 and use it again (Bug#8435).
ea6c7ae6
PE
1635 * lisp.h (doprnt): Remove.
1636 * Makefile.in (base_obj): Remove doprnt.o.
1637 * deps.mk (doprnt.o): Remove.
1638
5fdb398c
PE
1639 error: Print 32- and 64-bit integers portably (Bug#8435).
1640 Without this change, on typical 64-bit hosts error ("...%d...", N)
1641 was used to print both 32- and 64-bit integers N, which relied on
1642 undefined behavior.
1643 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1644 New macro.
1645 * lisp.h (error, verror): Mark as printf-like functions.
1646 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1647 Report overflow in size calculations when allocating printf buffer.
1648 Do not truncate output string at its first null byte.
1649 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1650 Truncate the output at a character boundary, since vsnprintf does not
1651 do that.
1652 * charset.c (check_iso_charset_parameter): Convert internal
1653 character to string before calling 'error', since %c now has the
1654 printf meaning.
1655 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1656 overflow when computing char to be passed to 'error'. Do not
1657 pass Lisp_Object to 'error'; pass the integer instead.
1658 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1659 formatted with plain %d.
1660
b189fa66
PE
1661 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1662
bff87ef0
PE
1663 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1664
7e2cac20
PE
1665 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1666
ce4d90b5
PE
1667 * xterm.c (x_catch_errors): Remove duplicate declaration.
1668
266c9547
PE
1669 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1670
79c49ad2
PE
1671 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1672
368f4090
JM
16732011-04-10 Jim Meyering <meyering@redhat.com>
1674
1675 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1676 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1677 return ssize_t not "int", and use size_t as the buffer length.
1678 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1679 * gnutls.h: Update declarations.
1680 * process.c (read_process_output): Use ssize_t, to match.
1681 (send_process): Likewise.
1682
a32d4040
CY
16832011-04-09 Chong Yidong <cyd@stupidchicken.com>
1684
1685 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1686
8546720e 16872011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1688
04f2d78b
CB
1689 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1690 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1691
8546720e
GM
1692 * xterm.c (handle_one_xevent):
1693 * xmenu.c (create_and_show_popup_menu):
1694 * xselect.c (x_decline_selection_request)
1695 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1696
0a2f5c1a 16972011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1698
1699 Fix some uses of `int' instead of EMACS_INT.
1700 * search.c (string_match_1, fast_string_match)
1701 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1702 (scan_buffer, find_next_newline_no_quit)
1703 (find_before_next_newline, search_command, Freplace_match)
1704 (Fmatch_data): Make some `int' variables be EMACS_INT.
1705
1706 * xdisp.c (display_count_lines): 3rd argument and return value now
1707 EMACS_INT. All callers changed.
1708 (pint2hrstr): Last argument is now EMACS_INT.
1709
1710 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1711 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1712 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1713 (decode_coding_utf_16, decode_coding_emacs_mule)
1714 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1715 (decode_coding_ccl, decode_coding_charset)
1716 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1717 (decode_coding_iso_2022, decode_coding_emacs_mule)
1718 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1719 <char_offset, last_offset>: Declare EMACS_INT.
1720 (encode_coding_utf_8, encode_coding_utf_16)
1721 (encode_coding_emacs_mule, encode_invocation_designation)
1722 (encode_designation_at_bol, encode_coding_iso_2022)
1723 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1724 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1725 Declare EMACS_INT.
1726 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1727 (encode_invocation_designation): Last argument P_NCHARS is now
1728 EMACS_INT.
1729 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1730 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1731
1732 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1733 All users changed.
1734
1735 * ccl.c (Fccl_execute_on_string): Declare some variables
1736 EMACS_INT.
1737
8546720e 17382011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1739
1740 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1741
4e19a977
CS
17422011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1743
1744 * process.c (Fformat_network_address): Doc fix.
1745
87302331
R
17462011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1747
1748 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1749
cbb59342
CY
17502011-04-08 Chong Yidong <cyd@stupidchicken.com>
1751
1752 * keyboard.c (read_char): Call Lisp function help-form-show,
1753 instead of using internal_with_output_to_temp_buffer.
1754 (Qhelp_form_show): New var.
e0d38eeb 1755 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1756
1757 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1758
1759 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1760
e67a13ab
CY
17612011-04-06 Chong Yidong <cyd@stupidchicken.com>
1762
04f2d78b
CB
1763 * process.c (Flist_processes): Remove to Lisp.
1764 (list_processes_1): Delete.
e67a13ab 1765
973f782d
EZ
17662011-04-06 Eli Zaretskii <eliz@gnu.org>
1767
7c106b1e
EZ
1768 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1769
973f782d
EZ
1770 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1771
41cf7d1a 17722011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1773
ca23cc88
PE
1774 Fix more problems found by GCC 4.6.0's static checks.
1775
f390e2d5
PE
1776 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1777
42eea0d0
PE
1778 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1779
b69769da 1780 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1781
f9541e84
PE
1782 * xdisp.c (vmessage): Mark as a printf-like function.
1783
13841b55
PE
1784 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1785
c136c10f
PE
1786 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1787
5e2d4a30
PE
1788 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1789 printf-like functions.
1790 (tiff_load): Add casts to remove these marks before passing them
1791 to system-supplied API.
1792
583f48b9
PE
1793 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1794
b25d760e
PE
1795 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1796 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1797 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1798 directly, rather than having caller test rule sign. This avoids
1799 some unnecessary tests.
1800 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1801 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1802 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1803
bc7b6697 1804 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1805 (xfont_open): Avoid unnecessary tests.
bc7b6697 1806
27ccc379
PE
1807 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1808
dcd5c89a
PE
1809 * composite.h, composite.c (composition_gstring_put_cache):
1810 Use EMACS_INT, not int, for length.
1811
b13a45c6
PE
1812 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1813 breaking out part of COMPOSITION_DECODE_RULE.
1814 (COMPOSITION_DECODE_RULE): Use it.
1815 * composite.c (get_composition_id): Remove unused local vars,
1816 by using the new macro.
1817
1e792e4d
PE
1818 * textprop.c (set_text_properties_1): Change while to do-while,
1819 since the condition is always true at first.
1820
dc6c6455 1821 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1822 (interval_deletion_adjustment): Return unsigned value.
1823 All uses changed.
dc6c6455 1824
aba7731a
PE
1825 * process.c (list_processes_1, create_pty, read_process_output):
1826 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1827 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1828 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1829 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1830 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1831
fdfc4bf3
PE
1832 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1833
fca8fe46 1834 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1835 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1836
06a0259a 1837 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1838 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1839 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1840
e7b9e80f
PE
1841 * print.c (print_error_message): Avoid int overflow.
1842
56201685
PE
1843 * font.c (font_list_entities): Redo for clarity,
1844 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1845
78834453 1846 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1847 (font_score): Avoid potential overflow in diff calculation.
78834453 1848
0bc0b309 1849 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1850 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1851
e610eaca
PE
1852 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1853
b895abce
PE
1854 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1855 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1856 can always succeed if overflow has undefined behavior.
1857
1f1d9321 1858 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1859 (wordify): Omit three unnecessary tests.
1f1d9321 1860
c59478bc
PE
1861 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1862 All callers changed. This avoids the need for an unused var.
1863
79b73827
PE
1864 * casefiddle.c (casify_region): Remove var that is set but not used.
1865
a4db5dfe
PE
1866 * dired.c (file_name_completion): Remove var that is set but not used.
1867
43aae36e
PE
1868 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1869
2a47c44d 1870 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1871 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1872
a37c69bf
PE
1873 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1874 Check for integer overflow on size calculations.
1875
328ab8e7
PE
1876 * buffer.c (Fprevious_overlay_change): Remove var that is set
1877 but not used.
1878
e5a2a5cb
PE
1879 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1880 Remove vars that are set but not used.
8d84a6eb 1881 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1882 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1883
a60e5f68
PE
1884 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1885
f661cb61 1886 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1887 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1888
f0397f5a
PE
1889 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1890 that are set but not used.
1891
8664db06 1892 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1893 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1894
6abdaa4a
PE
1895 * xselect.c (x_get_local_selection, x_handle_property_notify):
1896 Remove vars that are set but not used.
1897
0ce7538d 1898 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1899 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1900
9ae848fc
PE
1901 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1902 Remove var that is set but not used.
0b918413
PE
1903 (scroll_bar_windows_size): Now size_t, not int.
1904 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1905 Check for overflow.
9ae848fc 1906
a5a62657
PE
1907 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1908 (map_tty_color) [!defined MSDOS]: Likewise.
1909
5c5cdd39
PE
1910 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1911
66ebf983
PE
1912 * coding.c: Remove vars that are set but not used.
1913 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1914 All callers changed.
1915 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1916 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1917 (decode_coding_charset): Remove vars that are set but not used.
1918
1be4d761
PE
1919 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1920 that is set but not used.
1921
47553fa8
PE
1922 * print.c (print_object): Remove var that is set but not used.
1923
1f7196bf 1924 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1925 The gnulib version avoids calling malloc in the usual case,
1926 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1927 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1928 * filelock.c (current_lock_owner): Likewise.
1929 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1930 * sysdep.c: Include allocator.h, careadlinkat.h.
1931 (emacs_no_realloc_allocator): New static constant.
1932 (emacs_readlink): New function.
fdb61804
PE
1933 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1934 ../lib/careadlinkat.h.
d1fdcab7 1935
f84c17c7
SM
19362011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1937
1938 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1939 first non-nil return value).
1940
ef3862ad
JD
19412011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1942
1943 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1944 if not defined (Bug#8403).
1945
376a7006
JB
19462011-04-02 Juanma Barranquero <lekktu@gmail.com>
1947
1948 * xdisp.c (display_count_lines): Remove parameter `start',
1949 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1950 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1951 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1952 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1953 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1954 and thereabouts. All callers changed.
1955 (get_per_char_metric): Remove parameter `f', unused since
1956 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1957
6ca3801d
JM
19582011-04-02 Jim Meyering <meyering@redhat.com>
1959
1960 do not dereference NULL upon failed strdup
1961 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1962 (ns_get_family): Likewise.
1963
d8e2b5ba
JB
19642011-04-02 Juanma Barranquero <lekktu@gmail.com>
1965
1966 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1967
8c74fcbd
JD
19682011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1969
1970 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1971 later (Bug#8403).
1972
7200d79c
SM
19732011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1974
03408648 1975 Add lexical binding.
7200d79c 1976
03408648
SM
1977 * window.c (Ftemp_output_buffer_show): New fun.
1978 (Fsave_window_excursion):
1979 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1980
1981 * lread.c (lisp_file_lexically_bound_p): New function.
1982 (Fload): Bind Qlexical_binding.
1983 (readevalloop): Remove `evalfun' arg.
1984 Bind Qinternal_interpreter_environment.
1985 (Feval_buffer): Bind Qlexical_binding.
1986 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1987 Mark as dynamic.
1988 (syms_of_lread): Declare `lexical-binding'.
1989
1990 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1991
1992 * keyboard.c (eval_dyn): New fun.
1993 (menu_item_eval_property): Use it.
ca105506
SM
1994
1995 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1996
03408648
SM
1997 * fns.c (concat, mapcar1): Accept byte-code-functions.
1998
1999 * eval.c (Fsetq): Handle lexical vars.
2000 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2001 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2002 (FletX, Flet): Obey lexical binding.
2003 (Fcommandp): Handle closures.
2004 (Feval): New `lexical' arg.
2005 (eval_sub): New function extracted from Feval. Use it almost
2006 everywhere where Feval was used. Look up vars in lexical env.
2007 Handle closures.
2008 (Ffunctionp): Move from subr.el.
2009 (Ffuncall): Handle closures.
2010 (apply_lambda): Remove `eval_flags'.
2011 (funcall_lambda): Handle closures and new byte-code-functions.
2012 (Fspecial_variable_p): New function.
2013 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2014 but without exporting it to Lisp.
23aba0ea 2015
23aba0ea 2016 * doc.c (Fdocumentation, store_function_docstring):
03408648 2017 * data.c (Finteractive_form): Handle closures.
23aba0ea 2018
03408648
SM
2019 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2020 interactive spec.
ba83908c 2021
04f2d78b
CB
2022 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2023 New byte-codes.
03408648
SM
2024 (exec_byte_code): New function extracted from Fbyte_code to handle new
2025 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2026
03408648 2027 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2028
03408648 2029 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2030
e2abce01
JB
20312011-03-31 Juanma Barranquero <lekktu@gmail.com>
2032
2033 * xdisp.c (redisplay_internal): Fix prototype.
2034
63696a73 20352011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2036
63696a73 2037 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2038 (try_scrolling): Use it when setting scroll_limit.
2039 Limit scrolling to 100 screen lines.
63696a73
EZ
2040 (redisplay_window): Even when falling back on "recentering",
2041 position point in the window according to scroll-conservatively,
2042 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2043
2044 (try_scrolling): When point is above the window, allow searching
2045 as far as scroll_max, or one screenful, to compute vertical
2046 distance from PT to the scroll margin position. This prevents
2047 try_scrolling from unnecessarily failing when
2048 scroll-conservatively is set to a value slightly larger than the
2049 window height. Clean up the case of PT below the margin at bottom
2050 of window: scroll_max can no longer be INT_MAX. When aggressive
2051 scrolling is in use, don't let point enter the opposite scroll
2052 margin as result of the scroll.
2053 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2054 threshold of 100 lines for never-recentering scrolling.
2055
e4cc2dfc
JB
20562011-03-31 Juanma Barranquero <lekktu@gmail.com>
2057
2058 * dispextern.h (move_it_by_lines):
2059 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2060 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2061 (message_log_check_duplicate): Remove parameters `prev_bol' and
2062 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2063 (redisplay_internal): Remove parameter `preserve_echo_area',
2064 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2065
2066 * indent.c (Fvertical_motion):
2067 * window.c (window_scroll_pixel_based, Frecenter):
2068 Don't pass `need_y_p' to `move_it_by_lines'.
2069
1c470562
SM
20702011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2071
44f230aa
SM
2072 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2073 steal a few bits to be more compact.
2074 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2075 Remove unneeded casts.
2076
1c470562
SM
2077 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2078
888adce9
ZK
20792011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2080
2081 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2082 binding" message (bug#7967).
2083
f838ed7b
PE
20842011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2085
77861b95
PE
2086 Fix more problems found by GCC 4.6.0's static checks.
2087
de6dbc14
PE
2088 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2089 Remove unused local var.
2090
f838ed7b
PE
2091 * editfns.c (Fmessage_box): Remove unused local var.
2092
792c7b2b
PE
2093 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2094 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2095 Omit unused local vars.
c499e557 2096 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2097 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2098 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2099 Omit unused local var.
2100
ba0165e1
PE
2101 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2102 Don't assume string length fits in int.
32ad8845 2103 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2104 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2105
3c59b4c9
PE
2106 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2107 instead of alloca (Bug#8344).
2108
a3eed478 2109 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2110 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2111
eb4d412d
PE
2112 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2113
1658b401
PE
2114 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2115 concerns.
2116
2117 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2118
2119 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2120
9a2c6e05
PE
2121 * keyboard.c (syms_of_keyboard): Use the same style as later
2122 in this function when indexing through an array. This also
2123 works around GCC bug 48267.
2124
03d0a109
PE
2125 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2126
44f730c8
PE
2127 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2128
fe75f926
PE
2129 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2130 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2131
ffa8c828
PE
2132 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2133 This avoids undefined behavior on integer overflow, and is a bit
2134 more convenient anyway since it is compared to a size_t variable.
2135
c5101a77
PE
2136 Variadic C functions now count arguments with size_t, not int.
2137 This avoids an unnecessary limitation on 64-bit machines, which
2138 caused (substring ...) to crash on large vectors (Bug#8344).
2139 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2140 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2141 All variadic functions and their callers changed accordingly.
c5101a77
PE
2142 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2143 * data.c (arith_driver, float_arith_driver): Likewise.
2144 * editfns.c (general_insert_function): Likewise.
2145 * eval.c (struct backtrace.nargs, interactive_p)
2146 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2147 (funcall_lambda, mark_backtrace): Likewise.
2148 * fns.c (concat): Likewise.
2149 * frame.c (x_set_frame_parameters): Likewise.
2150 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2151 0 if not found, not -1. All callers changed.
2152
dd3f25f7
PE
2153 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2154 (stack_copy_size): Now size_t, not int.
2155 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2156
461c2ab9
JB
21572011-03-28 Juanma Barranquero <lekktu@gmail.com>
2158
2159 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2160 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2161 All callers changed.
2162
2163 * lisp.h (multibyte_char_to_unibyte):
2164 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2165 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2166 * character.h (CHAR_TO_BYTE8):
2167 * cmds.c (internal_self_insert):
2168 * editfns.c (general_insert_function):
2169 * keymap.c (push_key_description):
2170 * search.c (Freplace_match):
2171 * xdisp.c (message_dolog, set_message_1): All callers changed.
2172
f6d62986
SM
21732011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2174
2175 * keyboard.c (safe_run_hook_funcall): New function.
2176 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2177 don't set the hook to nil, but remove the offending function instead.
2178 (Qcommand_hook_internal): Remove, unused.
2179 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2180 Vcommand_hook_internal.
2181
2182 * eval.c (enum run_hooks_condition): Remove.
2183 (funcall_nil, funcall_not): New functions.
2184 (run_hook_with_args): Call each function through a `funcall' argument.
2185 Remove `cond' argument, now redundant.
2186 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2187 (Frun_hook_with_args_until_failure): Adjust accordingly.
2188 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2189
1db5b1ad
JB
21902011-03-28 Juanma Barranquero <lekktu@gmail.com>
2191
2192 * dispextern.h (string_buffer_position): Remove declaration.
2193
2194 * print.c (strout): Remove parameter `multibyte', unused since
2195 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2196
2197 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2198 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2199 All callers changed.
2200
2201 * w32.c (_wsa_errlist): Use braces for struct initializers.
2202
2203 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2204 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2205 All callers changed.
2206 (string_buffer_position): Likewise. Also, make static (it's never
2207 used outside xdisp.c).
2208 (cursor_row_p): Remove parameter `w', unused since
2209 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2210 (decode_mode_spec): Remove parameter `precision', introduced during
2211 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2212 All callers changed.
2213
5ffb62aa
JD
22142011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2215
2216 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2217
461c2ab9 22182011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2219
2220 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2221 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2222 (ns_update_auto_hide_menu_bar): New functions.
2223 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2224 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2225 ns_constrain_all_frames.
2226 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2227 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2228
5c380ffb
JD
22292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2230
2231 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2232
9af30bdf
GM
22332011-03-27 Glenn Morris <rgm@gnu.org>
2234
2235 * syssignal.h: Replace RETSIGTYPE with void.
2236 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2237 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2238 Replace SIGTYPE with void everywhere.
2239 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2240 * s/template.h (SIGTYPE): Remove commented out definition.
2241
e2abce01
JB
22422011-03-26 Eli Zaretskii <eliz@gnu.org>
2243
2244 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2245 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2246
f868cd8a
JB
22472011-03-26 Juanma Barranquero <lekktu@gmail.com>
2248
59eb0929
JB
2249 * w32.c (read_unc_volume): Use parameter `henum', instead of
2250 global variable `wget_enum_handle'.
2251
2252 * keymap.c (describe_vector): Remove parameters `indices' and
2253 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2254 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2255
f868cd8a
JB
2256 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2257
2258 * keyboard.c (timer_check): Remove parameter `do_it_now',
2259 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2260 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2261 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2262
2263 * keyboard.c (read_char):
2264 * w32menu.c (w32_menu_display_help):
2265 * xmenu.c (show_help_event, menu_help_callback):
2266 Adjust calls to `show_help_echo'.
2267
2268 * gtkutil.c (xg_maybe_add_timer):
2269 * keyboard.c (readable_events):
2270 * process.c (wait_reading_process_output):
2271 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2272
2273 * insdel.c (adjust_markers_gap_motion):
2274 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2275 (gap_left, gap_right): Don't call it.
2276
2ecf6fdb
CY
22772011-03-25 Chong Yidong <cyd@stupidchicken.com>
2278
2279 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2280 incurred during fontification.
2281
6b1f9ba4
JB
22822011-03-25 Juanma Barranquero <lekktu@gmail.com>
2283
2284 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2285 (DEFVAR_PER_BUFFER): Don't pass it.
2286
2287 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2288 (scrolling_window): Don't pass it.
2289
0f4a96b5
JB
22902011-03-25 Juanma Barranquero <lekktu@gmail.com>
2291
2292 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2293
2294 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2295 and `suffix'.
2296 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2297 of variables specific to SELinux and computation of `encoded_absname'.
2298
2299 * image.c (XPutPixel): Remove unused variable `height'.
2300
2301 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2302
2303 * unexw32.c (get_section_info): Remove unused variable `section'.
2304
2305 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2306 (system_process_attributes): Remove unused variable `sess'.
2307 (sys_read): Remove unused variable `err'.
2308
2309 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2310 (w32_wnd_proc): Remove unused variable `isdead'.
2311 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2312 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2313 (x_create_tip_frame): Remove unused variable `tem'.
2314
2315 * w32inevt.c (w32_console_read_socket):
2316 Remove unused variable `no_events'.
2317
2318 * w32term.c (x_draw_composite_glyph_string_foreground):
2319 Remove unused variable `width'.
2320
1149507c
JB
23212011-03-24 Juanma Barranquero <lekktu@gmail.com>
2322
2323 * w32term.c (x_set_glyph_string_clipping):
2324 Don't pass uninitialized region to CombineRgn.
2325
9c88f339
JB
23262011-03-23 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2329 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2330 (Fx_close_connection): Remove unused variable `i'.
2331
2332 * w32font.c (w32font_draw): Return number of glyphs.
2333 (w32font_open_internal): Remove unused variable `i'.
2334 (w32font_driver): Add missing initializer.
2335
2336 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2337 (fill_in_menu): Remove unused variable `items_added'.
2338
2339 * w32term.c (last_mouse_press_frame): Remove static global variable.
2340 (w32_clip_to_row): Remove unused variable `f'.
2341 (x_delete_terminal): Remove unused variable `i'.
2342
2343 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2344 (NOTHING): Remove unused static global variable.
2345 (uniscribe_check_otf): Remove unused variable `table'.
2346 (uniscribe_font_driver): Add missing initializers.
2347
dee091a3
JD
23482011-03-23 Julien Danjou <julien@danjou.info>
2349
2350 * term.c (Fsuspend_tty, Fresume_tty):
2351 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2352 * window.c (temp_output_buffer_show):
2353 * insdel.c (signal_before_change):
2354 * frame.c (Fhandle_switch_frame):
2355 * fileio.c (Fdo_auto_save):
2356 * emacs.c (Fkill_emacs):
2357 * editfns.c (save_excursion_restore):
2358 * cmds.c (internal_self_insert):
2359 * callint.c (Fcall_interactively):
2360 * buffer.c (Fkill_all_local_variables):
2361 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2362 Use Frun_hooks.
0f4a96b5 2363 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2364 unconditionnaly since it does the check itself.
2365
2c520ab5 23662011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2367
c9c49752
PE
2368 Fix more problems found by GCC 4.5.2's static checks.
2369
8abc3f12
PE
2370 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2371 the first time through the loop, since we know p0 < p1 then.
2372 This also avoids a gcc -Wstrict-overflow warning.
2373
a2d26660
PE
2374 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2375 leading to a memory leak, possible in functions like
2376 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2377 of objects (Bug#8318).
a2d26660 2378
916c72e9
PE
2379 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2380 that could (at least in theory) be that large.
2381
19ab8a18
PE
2382 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2383 This is less likely to overflow, and avoids undefined behavior if
2384 overflow does occur. All callers changed. Use strtoul to scan
2385 for the unsigned long integer.
b7cbbd6f
PE
2386 (pint2hrstr): Simplify and tune code slightly.
2387 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2388
f0641eff
PE
2389 * scroll.c (do_scrolling): Work around GCC bug 48228.
2390 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2391
7f650bb9
PE
2392 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2393 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2394 (validate_x_resource_name): Simplify count usage.
2395 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2396
37dd57d1
PE
2397 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2398 fail (Bug#8306).
81e56e61 2399
699979fc 2400 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2401
401bf9b4
PE
2402 * process.c (Fmake_network_process): Use socklen_t, not int,
2403 where POSIX says socklen_t is required in portable programs.
2404 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2405 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2406 (Fmake_network_process, server_accept_connection):
2407 (wait_reading_process_output, read_process_output):
2408 Likewise.
2409
b93aacde
PE
2410 * process.c: Rename or move locals to avoid shadowing.
2411 (list_processes_1, Fmake_network_process):
2412 (read_process_output_error_handler, exec_sentinel_error_handler):
2413 Rename or move locals.
4dc343ee 2414 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2415 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2416 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2417 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2418 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2419
af8a867c 2420 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2421 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2422 Include tparam.h instead, since it declares them.
af8a867c
PE
2423 * cm.h (PC): Remove extern decl; tparam.h now does this.
2424 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2425 * terminfo.c: Include tparam.h, to check interfaces.
2426 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2427 (tparam): Adjust signature to match interface in tparam.h;
2428 this removes some undefined behavior. Check that outstring and len
2429 are zero, which they always are with Emacs.
2430 * tparam.h (PC, BC, UP): New extern decls.
2431
0248044d 2432 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2433 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2434
8ff096c1 2435 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2436 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2437 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2438 (ftfont_list): Remove unused local.
49eaafba
PE
2439 (get_adstyle_property, ftfont_pattern_entity):
2440 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2441 Rename locals to avoid shadowing.
8ff096c1 2442
e2be39f6
PE
2443 * xfont.c (xfont_list_family): Mark var as initialized.
2444
c9735e30
PE
2445 * xml.c (make_dom): Now static.
2446
8f5201ae
PE
2447 * composite.c (composition_compute_stop_pos): Rename local to
2448 avoid shadowing.
b246f932
PE
2449 (composition_reseat_it): Remove unused locals.
2450 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2451 (composition_update_it): Mark var as initialized.
11b61122
PE
2452 (find_automatic_composition): Mark vars as initialized,
2453 with a FIXME (Bug#8290).
8f5201ae 2454
760fbc2c
PE
2455 character.h: Rename locals to avoid shadowing.
2456 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2457 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2458 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2459 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2460 to avoid shadowing.
2461
ff08eb85
PE
2462 * textprop.c (property_change_between_p): Remove; unused.
2463
fc7bf025
PE
2464 * intervals.c (interval_start_pos): Now static.
2465
235d7abc
PE
2466 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2467
44f230aa
SM
2468 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2469 Rename locals to avoid shadowing.
3e7d6594 2470
50060332
PE
2471 * sound.c (wav_play, au_play, Fplay_sound_internal):
2472 Fix pointer signedness.
d01f234b 2473 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2474 (wav_play): Initialize a variable to 0, to prevent undefined
2475 behavior (Bug#8278).
50060332 2476
c4fc4e30
PE
2477 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2478
918436ed
PE
2479 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2480
c939f91b
PE
2481 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2482 clobbering (Bug#8298).
b9c7f648
PE
2483 * sysdep.c (sys_subshell): Likewise.
2484 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2485
6bd8c144
PE
2486 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2487 This should get cleaned up, so that child_setup has the
2488 same signature on all platforms.
2489
7710357c 2490 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2491 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2492
c59da222
CY
24932011-03-22 Chong Yidong <cyd@stupidchicken.com>
2494
2495 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2496 not to be necessary, and produces flickering.
2497
66b87493
GM
24982011-03-20 Glenn Morris <rgm@gnu.org>
2499
2500 * config.in: Remove file.
2501
45b6f6d5
JB
25022011-03-20 Juanma Barranquero <lekktu@gmail.com>
2503
2504 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2505 are now in src/globals.h.
2506 (syms_of_minibuf): Remove spurious & from previous change.
2507
3ec03f7e
LL
25082011-03-20 Leo <sdl.web@gmail.com>
2509
2510 * minibuf.c (completing-read-function): New variable.
2511 (completing-read-default): Rename from completing-read.
2512 (completing-read): Call completing-read-function.
2513
b14e3e21
CY
25142011-03-19 Juanma Barranquero <lekktu@gmail.com>
2515
2516 * xfaces.c (Fx_load_color_file):
2517 Read color file from absolute filename (bug#8250).
2518
f2b726e6
JB
25192011-03-19 Juanma Barranquero <lekktu@gmail.com>
2520
2521 * makefile.w32-in: Update dependencies.
2522
09f6ff02
EZ
25232011-03-17 Eli Zaretskii <eliz@gnu.org>
2524
2525 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2526
29a6015a
PE
25272011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2528
a3a6c54e
PE
2529 Fix more problems found by GCC 4.5.2's static checks.
2530
b766f867
PE
2531 * process.c (make_serial_process_unwind, send_process_trap):
2532 (sigchld_handler): Now static.
2533
be02381c
PE
2534 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2535 That way, the code declares only the vars that it needs.
2536 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2537 * s/cygwin.h (PTY_ITERATION): Likewise.
2538 * s/darwin.h (PTY_ITERATION): Likewise.
2539 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2540
57048744
PE
2541 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2542 * process.c (allocate_pty): Don't declare stb unless it's needed.
2543
7914961c 2544 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2545 (CONSTANTLIM): Remove; unused.
2546 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2547 Define only if needed.
7914961c 2548
b3967b18
PE
2549 * unexelf.c (unexec): Name an expression,
2550 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2551 Use a different way to cause a compilation error if anyone uses
2552 n rather than nn, a way that does not involve shadowing.
73366a00 2553 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2554
29a6015a
PE
2555 * deps.mk (unexalpha.o): Remove; unused.
2556
43cfc33e 2557 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2558 * unexec.h: New file.
ce701a33
PE
2559 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2560 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2561 Depend on unexec.h.
2562 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2563 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2564 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2565 Change as necessary to match prototype in unexec.h.
ce701a33 2566
01f44d5a
PE
2567 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2568 shadowing.
4f63c6bb 2569 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2570
a6670b0b
PE
2571 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2572 Rename locals to avoid shadowing.
2573
cef2010d 2574 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2575 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2576
d4d7173a
PE
2577 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2578
f08b802a
PE
2579 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2580 warning when compiling print.c.
2581
3ddb0639
PE
2582 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2583 instead of using an uninitialized var.
5ad03b97 2584 (font_sort_entities): Mark var as initialized.
3ddb0639 2585
170a2692
PE
2586 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2587
e663c700
PE
2588 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2589 pointers to constants.
89bc529a 2590 (font_parse_fcname): Remove unused vars.
7b81e2d0 2591 (font_delete_unmatched): Now static.
ea838e10 2592 (font_get_spec): Remove; unused.
13a547c6
PE
2593 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2594 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2595 Rename or move locals to avoid shadowing.
e663c700 2596
2a80c887 2597 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2598 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2599
1384fa33 2600 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2601 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2602
8b2c52e9
PE
2603 * alloc.c (mark_backtrace): Move decl from here ...
2604 * lisp.h: ... to here, so that it can be checked.
2605
475545b5 2606 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2607 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2608 (lisp_indirect_variable): Name an expression,
2609 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2610 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2611
b1349114 2612 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2613 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2614 Use const pointer when appropriate.
b1349114 2615
a2928364
PE
2616 * lisp.h (get_system_name, get_operating_system_release):
2617 Move decls here, to check interfaces.
2618 * process.c (get_operating_system_release): Move decl to lisp.h.
2619 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2620 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2621 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2622 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2623 (Fformat_time_string, Fencode_time, Finsert_char):
2624 (Ftranslate_region_internal, Fformat):
2625 Rename or remove local vars to avoid shadowing.
9710023e 2626 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2627
a415e694
PE
2628 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2629 avoid shadowing.
2630
8ef4622d
PE
2631 * lisp.h (eassert): Check that the argument compiles, even if
2632 ENABLE_CHECKING is not defined.
2633
946f9a5b
PE
2634 * data.c (Findirect_variable): Name an expression, to avoid
2635 gcc -Wbad-function-cast warning.
112396d6 2636 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2637 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2638 (Fmake_variable_buffer_local, Fmake_local_variable):
2639 Mark variables as initialized.
52746918 2640 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2641
e5aab7e7 2642 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2643 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2644 Rename locals to avoid shadowing.
dff45157
PE
2645 (mark_stack): Move local variables into the #ifdef region where
2646 they're used.
7bc26fdb
PE
2647 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2648 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2649 needed otherwise.
2650 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2651 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2652 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2653
e5aab7e7
PE
2654 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2655 avoids undefined behavior in theory.
2656
4da60324
PE
2657 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2658
88043301
PE
2659 Use functions, not macros, for up- and down-casing (Bug#8254).
2660 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2661 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2662 to use the following functions instead of these macros.
2663 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2664 EMACS_INT, since callers assume the returned value fits in int.
2665 (upcase1): Likewise, for UPCASE_TABLE.
2666 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2667 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2668 the race-condition problem in the old DOWNCASE.
88043301 2669
19ed5445
PE
2670 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2671 Rename locals to avoid shadowing.
2672 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2673 (regex_compile, re_search_2, re_match_2_internal):
2674 Remove unused local vars.
952db0d7
PE
2675 (FREE_VAR): Rewrite so as not to use empty "else",
2676 which gcc can warn about.
da053e48 2677 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2678 (RETALLOC_IF): Define only if needed.
2679 (WORDCHAR_P): Likewise. This one is never needed, but is used
2680 only in a comment talking about a compiler bug, so put inside
2681 the #if 0 of that comment.
2682 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2683 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2684 Remove; unused.
19ed5445 2685
1f3561e4 2686 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2687 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2688 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2689
ded6f8f7
PE
2690 * search.c (simple_search): Remove unused var.
2691
dbd37a95
PE
2692 * dired.c (compile_pattern): Move decl from here ...
2693 * lisp.h: ... to here, so that it can be checked.
2694 (struct re_registers): New forward decl.
2695
7e47afad
PE
2696 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2697
85f24f61
PE
2698 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2699 All uses changed.
2700 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2701 Rename locals to avoid shadowing.
5671df8f 2702 (Fvertical_motion): Mark locals as initialized.
85f24f61 2703
181aa2be 2704 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2705 (casify_region): Mark local as initialized.
181aa2be 2706
930d429c
PE
2707 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2708
7082eac6
PE
2709 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2710 New macros, so that the caller can use some names other than
2711 gcpro1, gcpro2, etc.
2712 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2713 of the new macros.
2714 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2715 argument, for consistency with GCPRO2_VAR, etc: it is now the
2716 prefix of the variable, not the variable itself. All uses
2717 changed.
38b2c076
PE
2718 * dired.c (directory_files_internal, file_name_completion):
2719 Rename locals to avoid shadowing.
2720
15206ed9
PE
2721 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2722 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2723 dired.c's scmp function, had undefined behavior.
2724 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2725 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2726 * buffer.h: ... to here, because these macros use current_buffer,
2727 and the new implementation with inline functions needs to have
2728 current_buffer in scope now, rather than later when the macros
2729 are used.
2730 (downcase, upcase1): New static inline functions.
2731 (DOWNCASE, UPCASE1): Reimplement using these functions.
2732 This avoids undefined behavior in expressions like
2733 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2734 from race conditions in accessing the global variables
2735 case_temp1 and case_temp2.
2736 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2737 * lisp.h (case_temp1, case_temp2): Remove their decls.
2738 * character.h (ASCII_CHAR_P): Move from here ...
2739 * lisp.h: ... to here, so that the inline functions mentioned
2740 above can use them.
2741
4a6bea26
PE
2742 * dired.c (directory_files_internal_unwind): Now static.
2743
f14b7e14
PE
2744 * fileio.c (file_name_as_directory, directory_file_name):
2745 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2746 Now static.
2893f146
PE
2747 (file_name_as_directory): Use const pointers when appropriate.
2748 (Fexpand_file_name): Likewise. In particular, newdir might
2749 point at constant storage, so make it a const pointer.
fd4ead52 2750 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2751 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2752 signedness issues.
f839df0c
PE
2753 (Fset_file_times, Finsert_file_contents, auto_save_error):
2754 Rename locals to avoid shadowing.
f14b7e14 2755
5716756e 2756 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2757 (Ftry_completion, Fall_completions): Rename or remove locals
2758 to avoid shadowing.
5716756e 2759
b4c3046a
PE
2760 * marker.c (bytepos_to_charpos): Remove; unused.
2761
b45db522
PE
2762 * lisp.h (verify_bytepos, count_markers): New decls,
2763 so that gcc does not warn that these functions aren't declared.
2764
85876d07
PE
2765 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2766 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2767 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2768 (copy_text): Remove unused local var.
85876d07 2769
03d78a21 2770 * filelock.c (within_one_second): Now static.
b3dd38ab 2771 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2772
5df8f01b
PE
2773 * buffer.c (fix_overlays_before): Mark locals as initialized.
2774 (fix_start_end_in_overlays): Likewise. This function should be
2775 simplified by using pointers-to-pointers, but that's a different
2776 matter.
b1d876f1 2777 (switch_to_buffer_1): Now static.
8f54f30a
PE
2778 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2779 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2780
a70072c9 2781 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2782 Fix pointer signedness issue.
edced198
PE
2783 (sys_subshell): Mark local as volatile if checking for lint,
2784 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2785 (MAXPATHLEN): Define only if needed.
a70072c9 2786
a0977c44
PE
2787 * process.c (serial_open, serial_configure): Move decls from here ...
2788 * systty.h: ... to here, so that they can be checked.
2789
a884fdcc
PE
2790 * fns.c (get_random, seed_random): Move extern decls from here ...
2791 * lisp.h: ... to here, so that they can be checked.
2792
604efe86 2793 * sysdep.c (reset_io): Now static.
b8950c94 2794 (wait_for_termination_signal): Remove; unused.
604efe86 2795
38fc62d9
PE
2796 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2797 (copy_keymap_item, append_key, push_text_char_description):
2798 Now static.
1004a21a 2799 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2800 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2801 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2802 (describe_map_tree):
2803 Rename locals to avoid shadowing.
38fc62d9 2804
2f2650da
PE
2805 * keyboard.c: Declare functions static if they are not used elsewhere.
2806 (echo_char, echo_dash, cmd_error, top_level_2):
2807 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2808 (read_char, kbd_buffer_get_event, make_lispy_position):
2809 (make_lispy_event, make_lispy_movement, apply_modifiers):
2810 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2811 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2812 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2813 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2814 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2815
a053e86c 2816 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2817 (mark_kboards): Move decl here ...
2818 * alloc.c (mark_kboards): ... from here.
a053e86c 2819
4752793e
PE
2820 * lisp.h (force_auto_save_soon): New decl.
2821
74f10ca7 2822 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2823 (DEFINE_DUMMY_FUNCTION): New macro.
2824 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2825 Use it.
c03cd23f
PE
2826 (main): Add casts to avoid warnings
2827 if GCC considers string literals to be constants.
74f10ca7 2828
022e70d4
PE
2829 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2830
59d6fe83
PE
2831 * dbusbind.c: Pointer signedness fixes.
2832 (xd_signature, xd_append_arg, xd_initialize):
2833 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2834 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2835 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2836 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2837
78320123
PE
2838 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2839 if GCC considers string literals to be constants.
49cebcca 2840 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2841
35ac2a97
SM
28422011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2843
fb103ca9
SM
2844 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2845 (print_preprocess, print_object): New macro to fix last change.
2846
35ac2a97
SM
2847 * print.c (print_preprocess): Don't forget font objects.
2848
62973b41
JB
28492011-03-16 Juanma Barranquero <lekktu@gmail.com>
2850
2851 * emacs.c (USAGE3): Doc fixes.
2852
0e48bb22
AS
28532011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2854
2855 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2856 structure.
2857
7684e57b
JB
28582011-03-14 Juanma Barranquero <lekktu@gmail.com>
2859
2860 * lisp.h (VWindow_system, Qfile_name_history):
2861 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2862 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2863 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2864
2865 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2866 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2867
2868 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2869 * w32console.c (detect_input_pending, read_input_pending)
2870 (encode_terminal_code):
2871 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2872 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2873 (w32_system_caret_y, Qfile_name_history):
2874 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2875 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2876 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2877 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2878 * w32proc.c (Qlocal, report_file_error):
2879 * w32term.c (Vwindow_system, updating_frame):
2880 * w32uniscribe.c (initialized, uniscribe_font_driver):
2881 Remove unneeded extern declarations.
2882
2aa46d6c
CY
28832011-03-14 Chong Yidong <cyd@stupidchicken.com>
2884
c96bbc66 2885 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2886
cffc6f3b
CY
28872011-03-13 Chong Yidong <cyd@stupidchicken.com>
2888
2889 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2890 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2891 These macros can no longer be used for assignment.
2892
44f230aa
SM
2893 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2894 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2895 (record_buffer_markers, fetch_buffer_markers): New functions for
2896 recording and fetching special buffer markers.
2897 (set_buffer_internal_1, set_buffer_temp): Use them.
2898
2899 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2900
2901 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2902
2903 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2904 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2905
2906 * xdisp.c (hscroll_window_tree):
2907 (reconsider_clip_changes): Use PT instead of BUF_PT.
2908
d251f04b
EZ
29092011-03-13 Eli Zaretskii <eliz@gnu.org>
2910
2911 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2912 $(EMACS_ROOT)/lib/intprops.h.
2913
f0c77cd1
PE
29142011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2915
3eca4629
PE
2916 Fix more problems found by GCC 4.5.2's static checks.
2917
7c86ee98
PE
2918 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2919 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2920 (xg_free_frame_widgets): Make it clear that a local variable is
2921 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2922 (gdk_window_get_screen): Make it clear that this macro is needed
2923 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2924 (int_gtk_range_get_value): New function, which avoids a diagnostic
2925 from gcc -Wbad-function-cast.
2926 (xg_set_toolkit_scroll_bar_thumb): Use it.
2927 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2928 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2929 (get_utf8_string, xg_get_file_with_chooser):
2930 Rename locals to avoid shadowing.
2931 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2932
41729b81
PE
2933 * xgselect.c (xg_select): Remove unused var.
2934
f0c77cd1
PE
2935 * image.c (four_corners_best): Mark locals as initialized.
2936 (gif_load): Initialize transparent_p to zero (Bug#8238).
2937 Mark another local as initialized.
ec6cf4c6 2938 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2939
ce0ad53d 2940 * image.c (clear_image_cache): Now static.
d5d5a617 2941 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2942 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2943 (x_edge_detection): Remove unnecessary cast that
2944 gcc -Wbad-function-cast diagnoses.
2037898d 2945 (gif_load): Fix pointer signedness.
6ae141d6
PE
2946 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2947 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2948
33383987 29492011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2950
d32df629
PE
2951 Improve quality of tests for time stamp overflow.
2952 For example, without this patch (encode-time 0 0 0 1 1
2953 1152921504606846976) returns the obviously-bogus value (-948597
2954 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2955 reports time overflow. See
2956 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2957 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2958 * editfns.c: Include limits.h and intprops.h.
2959 (TIME_T_MIN, TIME_T_MAX): New macros.
2960 (time_overflow): Move earlier, to before first use.
2961 (hi_time, lo_time): New functions, for an accurate test for
2962 out-of-range times.
2963 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2964 (Fget_internal_run_time): Don't assume time_t fits in int.
2965 (make_time): Use list2 instead of Fcons twice.
2966 (Fdecode_time): More accurate test for out-of-range times.
2967 (check_tm_member): New function.
2968 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2969 (lisp_time_argument): Don't rely on undefined left-shift and
2970 right-shift behavior when checking for time stamp overflow.
8be6f318 2971
fe31d94c
PE
2972 * editfns.c (time_overflow): New function, refactoring common code.
2973 (Fformat_time_string, Fdecode_time, Fencode_time):
2974 (Fcurrent_time_string): Use it.
2975
8be6f318
PE
2976 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2977 * dired.c (make_time): Move to ...
2978 * editfns.c (make_time): ... here.
2979 * systime.h: Note the move.
2980
09d9db2c 29812011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2982
126bc0dc
YM
2983 * fringe.c (update_window_fringes): Remove unused variables.
2984
c47cbdfd
YM
2985 * unexmacosx.c (copy_data_segment): Also copy __got section.
2986 (Bug#8223)
2987
7ac80be9
EZ
29882011-03-12 Eli Zaretskii <eliz@gnu.org>
2989
c96bbc66 2990 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2991 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2992 Constify `char *' arguments and their references according to
2993 prototypes in tparam.h.
2994
ecb0f94d 2995 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2996
7ac80be9
EZ
2997 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2998 Adapt all references accordingly.
2999
3000 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3001
ef1fd07e
TT
30022011-03-11 Tom Tromey <tromey@redhat.com>
3003
3004 * buffer.c (syms_of_buffer): Remove obsolete comment.
3005
7ef4b50c
EZ
30062011-03-11 Eli Zaretskii <eliz@gnu.org>
3007
3008 * termhooks.h (encode_terminal_code): Declare prototype.
3009
3010 * msdos.c (encode_terminal_code): Don't declare prototype.
3011
3012 * term.c (encode_terminal_code): Now external again, used by
3013 w32console.c and msdos.c.
3014
44f230aa
SM
3015 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3016 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3017
4b1ec863 30182011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3019
1714f52b 3020 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3021
4b1ec863
PE
3022 * fringe.c (update_window_fringes): Mark locals as initialized
3023 (Bug#8227).
3024 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3025
524c7aa6
PE
3026 * alloc.c (mark_fringe_data): Move decl from here ...
3027 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3028 to check its interface.
3029 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3030
a5c0af81 3031 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3032 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3033 (fontset_font): Mark local as initialized.
a9a06e0b 3034 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3035
b4716021
PE
3036 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3037
811e9bac 3038 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3039 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3040 (x_own_selection, Fx_disown_selection_internal): Rename locals
3041 to avoid shadowing.
3042 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3043
7e3ab302
PE
3044 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3045 so that the caller can use some name other than gcpro1.
3046 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3047 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3048 (Fx_backspace_delete_keys_p):
3049 Use them to avoid shadowing, and rename vars to avoid shadowing.
3050 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3051 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3052 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3053 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3054 Remove unused locals.
7e3ab302
PE
3055 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3056 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3057 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3058 macros.
f78faa98 3059
e2b13473
PE
3060 * xterm.h (x_mouse_leave): New decl.
3061
77f23912
PE
3062 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3063 Remove unused functions.
cdf4ba58
PE
3064 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3065 (x_calc_absolute_position): Now static.
7411c686 3066 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3067 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3068 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3069 unless they are used.
38d0b34a
PE
3070 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3071 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3072 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3073 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3074 (x_error_catcher, x_connection_closed, x_error_handler):
3075 (x_error_quitter, xembed_send_message, x_iconify_frame):
3076 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3077 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3078 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3079
44f230aa
SM
3080 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3081 Rename or move locals to avoid shadowing.
6b463e58 3082 (tty_defined_color, merge_face_heights): Now static.
5967d051 3083 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3084 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3085 does not deduce is never used uninitialized.
73719eba
PE
3086 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3087 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3088
426994c3 3089 * terminal.c (store_terminal_param): Now static.
5489860b 3090
032f1620 3091 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3092 (set_frame_menubar): Remove unused local.
d4323972 3093 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3094 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3095 since they might point to immutable storage.
281585b0
PE
3096 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3097 since it's unused otherwise.
032f1620 3098
367c19e5 3099 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3100 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3101 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3102 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3103 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3104 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3105 does not deduce are never used uninitialized.
70739cbe 3106
07b48fa9
PE
3107 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3108
8868a238 3109 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3110 * window.c (window_loop, size_window):
3111 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3112
7e5cf297 3113 * window.c (display_buffer): Now static.
d6550a9f
PE
3114 (size_window): Mark variables that gcc -Wuninitialized
3115 does not deduce are never used uninitialized.
a586633d
PE
3116 * window.h (check_all_windows): New decl, to forestall
3117 gcc -Wmissing-prototypes diagnostic.
5b555da1 3118 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3119
f6095868
PE
3120 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3121 shadowing.
3122 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3123 Include <limits.h>.
3124 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3125 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3126 (load_charset_map): Mark variables that gcc -Wuninitialized
3127 does not deduce are never used uninitialized.
53df7c11 3128 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3129
f38b440c
PE
3130 * coding.c (coding_set_source, coding_set_destination):
3131 Use "else { /* comment */ }" rather than "else /* comment */;"
3132 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3133 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3134 a block, when the outer 'i' will do.
3135 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3136 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3137 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3138 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3139 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3140 Rename locals to avoid shadowing.
3141 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3142 * coding.c (emacs_mule_char, encode_invocation_designation):
3143 Now static, since they're not used elsewhere.
413bb2db 3144 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3145 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3146 (decode_coding_emacs_mule): Mark variables that gcc
3147 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3148 (detect_coding_iso_2022): Initialize a local variable that might
3149 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3150 this initialization is needed. (Bug#8211)
5f58e762
PE
3151 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3152 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3153 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3154 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3155 Remove unused macros.
f38b440c 3156
232b38b9 3157 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3158 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3159 * character.c (string_count_byte8): Likewise.
232b38b9 3160
fb90da1b
PE
3161 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3162 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3163
fb93dbc2
PE
3164 * chartab.c (copy_sub_char_table): Now static, since it's not used
3165 elsewhere.
5c156ace
PE
3166 (sub_char_table_ref_and_range, char_table_ref_and_range):
3167 Rename locals to avoid shadowing.
bbcd0949 3168 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3169
7d3b3862 3170 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3171 (BIDI_BOB): Remove unused macro.
7d3b3862 3172
6be7d3da
PE
3173 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3174 deduce are never used uninitialized.
c2ed9c8b 3175 * term.c (encode_terminal_code): Likewise.
6be7d3da 3176
75f8807f 3177 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3178
50938595
PE
3179 * tparam.h: New file.
3180 * term.c, tparam.h: Include it.
3181 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3182 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3183 Move these decls to tparam.h, and make them agree with what
3184 is actually in tparam.c. The previous trick of using incompatible
3185 decls in different modules does not conform to the C standard.
3186 All callers of tparam changed to use tparam's actual API.
3187 * tparam.c (tparam1, tparam, tgoto):
3188 Use const pointers where appropriate.
3189
fbceeba2
PE
3190 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3191 * cm.h (struct cm): Likewise.
3192 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3193 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3194 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3195 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3196 (turn_on_face, init_tty): Likewise.
3197 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3198
7f3f1250
PE
3199 * term.c (term_mouse_position): Rename local to avoid shadowing.
3200
e6ca6543
PE
3201 * alloc.c (mark_ttys): Move decl from here ...
3202 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3203
c40f8d15
AS
32042011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3205
3206 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3207
cfe0661d
JB
32082011-03-09 Juanma Barranquero <lekktu@gmail.com>
3209
3210 * search.c (compile_pattern_1): Remove argument regp, unused since
3211 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3212 (compile_pattern): Don't pass it.
3213
0afb4571
J
32142011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3215
3216 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3217 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3218 for ! HAVE_GTK3.
3219 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3220
3221 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3222
3223 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3224 gdk_window_get_screen, gdk_window_get_geometry,
3225 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3226 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3227 (xg_get_pixbuf_from_pixmap): New function.
3228 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3229 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3230 Call xg_get_pixbuf_from_pixmap instead of
3231 gdk_pixbuf_get_from_drawable.
3232 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3233 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3234 (xg_check_special_colors): Use GtkStyleContext and its functions
3235 for HAVE_GTK3.
3236 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3237 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3238 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3239 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3240 Call gtk_widget_get_preferred_size.
0afb4571
J
3241 (xg_frame_resized): gdk_window_get_geometry only takes 5
3242 parameters.
44f230aa
SM
3243 (xg_win_to_widget, xg_event_is_for_menubar):
3244 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3245 (xg_set_widget_bg): New function.
3246 (delete_cb): New function.
895009e1 3247 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3248 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3249 (xg_set_background_color): Call xg_set_widget_bg.
3250 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3251 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3252 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3253 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3254 if ! HAVE_GTK3.
3255 (update_frame_tool_bar): Call gtk_widget_hide.
3256 (xg_initialize): Use GDK_KEY_g.
3257
3258 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3259 if ! HAVE_GTK3
3260 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3261
3262 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3263 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3264 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3265
1c2cc4ef
JB
32662011-03-08 Juanma Barranquero <lekktu@gmail.com>
3267
3268 * w32xfns.c (select_palette): Check success of RealizePalette against
3269 GDI_ERROR, not zero.
3270
33383987 3271See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3272
3273;; Local Variables:
3274;; coding: utf-8
aac0c6e3
MR
3275;; End:
3276
33383987 3277 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3278
3279 This file is part of GNU Emacs.
3280
3281 GNU Emacs is free software: you can redistribute it and/or modify
3282 it under the terms of the GNU General Public License as published by
3283 the Free Software Foundation, either version 3 of the License, or
3284 (at your option) any later version.
3285
3286 GNU Emacs is distributed in the hope that it will be useful,
3287 but WITHOUT ANY WARRANTY; without even the implied warranty of
3288 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3289 GNU General Public License for more details.
3290
3291 You should have received a copy of the GNU General Public License
3292 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.