Remove references to s/ and m/ files in INSTALL
[bpt/emacs.git] / src / ChangeLog
CommitLineData
14c114ae
JD
12012-07-31 Jan Djärv <jan.h.d@swipnet.se>
2
3 * nsterm.m (openFiles): Fix previous checkin.
4
3bd21e82
PE
52012-07-31 Paul Eggert <eggert@cs.ucla.edu>
6
7 * indent.c (compute_motion): Remove unused local.
8
c1529ded
GM
92012-07-31 Glenn Morris <rgm@gnu.org>
10
400d5621
GM
11 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
12
268e2432
GM
13 * conf_post.h [USG5_4]:
14 Move remaining contents of s/usg5-4-common.h here.
15 * s/usg5-4-common.h: Remove file.
16
7552f3ee
GM
17 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
18 * s/irix6-5.h: Remove file.
19
6a381852
GM
20 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
21 * s/darwin.h: Remove file.
22
c1529ded
GM
23 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
24 * s/hpux10-20.h: Remove file, which is now empty.
25
b429a4ee
GM
262012-07-30 Glenn Morris <rgm@gnu.org>
27
28 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
29 * Makefile.in (config_h): Add conf_post.h.
30 * makefile.w32-in (CONFIG_H): Add conf_post.h.
31
adff3182
JD
322012-07-30 Jan Djärv <jan.h.d@swipnet.se>
33
34 * nsterm.m (ns_do_open_file): New variable.
35 (ns_term_init): Set ns_do_open_file to NO after run returns.
36 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
37 files only if ns_do_open_file.
38
c32af1e4
PE
392012-07-30 Paul Eggert <eggert@cs.ucla.edu>
40
7393bcbb
PE
41 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
42 This no-op macro hasn't been needed for many years.
43 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
44
c32af1e4
PE
45 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
46 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
47 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
48 gdb_make_enums_visible.
49 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
50 (DIRECTORY_SEP): Now a constant, not a macro.
51
302fc036
EZ
522012-07-30 Eli Zaretskii <eliz@gnu.org>
53
54 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
55 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
56
57 * w32term.c <w32_keyboard_codepage>: Renamed from
58 keyboard_codepage and now external. All users changed.
59
60 * w32term.h: Add declaration of w32_keyboard_codepage.
61
62 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
63 the codepage to translate keys to Unicode. If this argument is
64 -1, use the value returned by GetConsoleCP. All callers changed.
65
88fb40b4
PE
662012-07-30 Paul Eggert <eggert@cs.ucla.edu>
67
0aee6912
PE
68 Update .PHONY listings in makefiles.
69 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
70 bootstrap-clean, distclean, maintainer-clean, versioclean,
71 extraclean, frc.
72
88fb40b4
PE
73 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
74 This is a bit clearer. Fix some commentary typos.
75
0a763bd1
GM
762012-07-30 Glenn Morris <rgm@gnu.org>
77
32bac6d6
GM
78 * s/netbsd.h: Let configure include signal.h if needed.
79 Remove file, which is now empty.
80
b65e7c46
GM
81 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
82 Let configure set them.
83 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
84 No more need to undefine.
0a763bd1 85
169304bd
AS
862012-07-30 Andreas Schwab <schwab@linux-m68k.org>
87
88 * keymap.c (Fkey_description): Don't remove 0x80 bit from
89 non-single-byte char when adding meta modifier. (Bug#12090)
90
6cd7a139
DA
912012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
92
93 Convert safe_call to use variable number of arguments.
94 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
95 (safe_call2): Fix comment.
96 * lisp.h (safe_call): Adjust prototype.
97 * coding.c (encode_coding_object): Change to use safe_call2.
98 * xfaces.c (merge_face_heights): Change to use safe_call1.
99
d34d6ffc
GM
1002012-07-30 Glenn Morris <rgm@gnu.org>
101
7b8a48e4 102 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 103 does that unconditionally. Remove file, which is now empty.
7b8a48e4 104
d34d6ffc
GM
105 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
106 Remove empty files.
107
03a660a6
PE
1082012-07-30 Paul Eggert <eggert@cs.ucla.edu>
109
110 Export to GDB most of lisp.h's remaining object-like macros.
111 * lisp.h (min, max): Move earlier, because they're used earlier now.
112 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
113 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
114 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
115 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
116 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
117 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
118 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
119 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
120 Now constants, for GDB. They need not be macros.
121 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
122 Now constants, for GDB, as well as macros, for static initializers.
123 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
124 Move to after the definition of struct Lisp_Char_Table,
125 since the former now needs that type defined.
126 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
127 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
128 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
129 New enums, for gdb_make_enums_visible.
130 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 131 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
132 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
133 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
134 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
135 enum maxargs, enum MAX_ALLOCA.
136 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
137 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
138 no longer needed, now that they are done in lisp.h.
139
e499d0ee
DA
1402012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
141
142 Cleanup string bytes checking.
143 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
144 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
145 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
146 (check_sblock, compact_small_strings): Simplify.
147
d5040d2d
PE
1482012-07-29 Paul Eggert <eggert@cs.ucla.edu>
149
150 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
151 These macros are confusing and no longer need to be defined, as
152 the enum values now suffice. All uses replaced with definiens.
153 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
154
7f259ae6
JB
1552012-07-29 Juanma Barranquero <lekktu@gmail.com>
156
157 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
158 ($(BLD)/w32console.$(O)): Update dependencies.
159
7e63e0c3
DA
1602012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
161
162 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
163 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
164 time. Adjust users.
165 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
166
ffd817eb
JD
1672012-07-29 Jan Djärv <jan.h.d@swipnet.se>
168
169 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
170 setting sitelisp (Bug#12010).
171
417a7a0e
EZ
1722012-07-29 Eli Zaretskii <eliz@gnu.org>
173
174 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
175
176 * w32heap.c (cache_system_info):
177 * w32.c (sys_rename):
178 * w32proc.c (find_child_console, sys_kill): All users changed.
179
387d4d92
PE
1802012-07-29 Paul Eggert <eggert@cs.ucla.edu>
181
182 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
183
55a6cca6
EZ
1842012-07-29 Eli Zaretskii <eliz@gnu.org>
185
186 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
187
dbcf001c
DA
1882012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Cleanup statistics calculation in Fgarbage_collect.
191 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
192 zombies percentage calculation. Simplify elapsed time calculation.
193
e2688e4a
DA
1942012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
195
196 Generalize marker debugging code under MARKER_DEBUG and use eassert.
197 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
198 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
199 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
200 (replace_range, replace_range_2, del_range_2): Change to eassert.
201 * marker.c (byte_char_debug_check): Adjust style.
202
b46a6a83
PE
2032012-07-29 Paul Eggert <eggert@cs.ucla.edu>
204
205 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
206 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
207 long-ago-commented-out code that talks about "WIN32".
208 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
209 All uses changed.
210
e32a5799
PE
2112012-07-28 Paul Eggert <eggert@cs.ucla.edu>
212
213 Use Gnulib stdalign module (Bug#9772, Bug#9960).
214 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
215 Simplify by using alignof.
216 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
217 * lisp.h: Include <stdalign.h>.
218 (GCALIGNMENT): New macro and constant.
219 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
220 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
221 (stdalign): New macro, if not already defined.
222
df81cd29
EZ
2232012-07-28 Eli Zaretskii <eliz@gnu.org>
224
01bd1b0d
EZ
225 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
226 * w32inevt.c: Include w32inevt.h.
227 (w32_read_console_input): New inline function, calls either
228 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
229 w32_console_unicode_input.
230 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
231 (w32_kbd_patch_key, key_event): Use the codepage returned by
232 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
233 (key_event): use uChar.UnicodeChar only if
234 w32_console_unicode_input is non-zero.
235
236 * w32console.c: Include w32heap.h.
237 <w32_console_unicode_input>: New global variable.
238 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
239 family of Windows, zero otherwise.
240
241 * w32inevt.h: Declare w32_console_unicode_input.
242
df81cd29
EZ
243 * xdisp.c (init_iterator): Don't reference tip_frame in a build
244 --without-x. (Bug#11742)
245
c20fdd9e
PE
2462012-07-27 Paul Eggert <eggert@cs.ucla.edu>
247
248 Adjust GDB to reflect pvec_type changes (Bug#12036).
249 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
250 2012-07-04 changes to pseudovector representation. Problem
251 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
252
32770973 2532012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
254
255 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
256 bus address.
257 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
258
3438fe21
EZ
2592012-07-27 Eli Zaretskii <eliz@gnu.org>
260
bcfbc9de
EZ
261 * alloc.c (listn): Fix the order the arguments are consed onto the
262 list.
263
3438fe21
EZ
264 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
265 enumeration constants, as PURE and HEAP are too general, and clash
266 with other headers and sources, such as gmalloc.c and the
267 MS-Windows system headers. All users changed.
268
eeaea515
DA
2692012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Revert last save_excursion_save and save_excursion_restore changes.
272 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
273 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
274
073c88c2
DA
2752012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
276
277 Fix recently-introduced typos in Windows port.
278 Reported by Martin Rudalics <rudalics@gmx.at>.
279 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 280 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 281
4706125e
PE
2822012-07-27 Paul Eggert <eggert@cs.ucla.edu>
283
284 Improve GDB symbol export (Bug#12036).
285 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
286 arms of an 'if', not using conditional expressions; otherwise GDB
287 complains about the types in the unevaluated arm when the argument
288 is an integer literal.
289 (xgetint): Simplify expression.
290 * alloc.c (gdb_make_enums_visible): New constant. This ports to
291 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
292 Zaretskii in <http://bugs.gnu.org/12036#13>.
293 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
294 needed now that we have gdb_make_enums_visible.
295 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
296 (enum enum_USE_LSB_TAG):
297 New enum types, packaging up enums that need to be exported to GDB.
298
694b6c97
DA
2992012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
300
301 Utility function to make a list from specified amount of objects.
302 * lisp.h (enum constype): New datatype.
303 (listn): New prototype.
304 * alloc.c (listn): New function.
305 (Fmemory_use_count, syms_of_alloc): Use it.
306 * buffer.c (syms_of_buffer): Likewise.
307 * callint.c (syms_of_callint): Likewise.
308 * charset.c (define_charset_internal): Likewise.
309 * coding.c (syms_of_coding): Likewise.
310 * keymap.c (syms_of_keymap): Likewise.
311 * search.c (syms_of_search): Likewise.
312 * syntax.c (syms_of_syntax): Likewise.
313 * w32.c (init_environment): Likewise.
314 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
315 * xdisp.c (syms_of_xdisp): Likewise.
316 * xfns.c (syms_of_xfns): Likewise.
317
6195f384
DA
3182012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
319
320 Fast save_excursion_save and save_excursion_restore.
321 * lisp.h (struct Lisp_Excursion): New data type.
322 (PVEC_EXCURSION): New pseudovector type.
323 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
324 to deal with it. Adjust comments.
325 (init_marker, attach_marker): New prototype.
326 (unchain_marker): Adjust prototype.
327 * marker.c (attach_marker): Change to global.
328 (init_marker): New function.
329 * alloc.c (Fmake_marker, build_marker): Use it.
330 (build_marker): More easserts.
331 (mark_object): Handle struct Lisp_Excursion.
332 * editfns.c (save_excursion_save, save_excursion_restore):
333 Reimplement to use struct Lisp_Excursion. Add comments.
334
5eceb8fb
PE
3352012-07-26 Paul Eggert <eggert@cs.ucla.edu>
336
337 Fix export of symbols to GDB (Bug#12036).
338 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
339 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
340 emacs.c, as this is a more-suitable home. Had this been done earlier
341 the fix for 12036 would have avoided some of the problems noted in
342 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
343 would have been more obvious.
562157c8
PE
344 * emacs.c: Do not include <verify.h>; no longer needed.
345 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
346 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
347 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
348 Remove; now done in lisp.h.
349 * lisp.h (PUBLISH_TO_GDB): New macro.
350 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
351 (DATA_SEG_BITS): Use it.
352 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
353 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
354 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
355 not be usable in #if. This simplifies things.
356
d6749401
JB
3572012-07-26 Juanma Barranquero <lekktu@gmail.com>
358
359 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
360
1781b9e9
PE
3612012-07-26 Paul Eggert <eggert@cs.ucla.edu>
362
d89518db 363 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
364 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
365 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
366 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
367 Adjust to changes in lisp.h and emacs.c, by using
368 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
369 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
370 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
371 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
372 instead of gdb_valbits.
373 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
374 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
375 instead of gdb_array_mark_flag.
376 (xboolvector): Get size from $->size, not $->header.size.
377 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
378 (xreload, hook-run, hookpost-run): Remove.
379 * emacs.c: Include <verify.h>.
380 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
381 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
382 Remove.
383 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
384 (gdb_USE_LSB_TAG): New enum constants.
385 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
386 Also define these as enum constants, so they're visible to GDB.
387 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
388 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
389 as constants, so they're visible to GDB.
390 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
391 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
392 Now enum constants, not macros, so they're visible to GDB.
393 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
394 more convenient now. All uses changed.
395 (VALMASK) [USE_LSB_TAG]: Also define in this case.
396 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
397
3628596a
DA
3982012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
399
400 Explicitly free restriction data that are not needed anymore.
401 * editfns.c (save_restriction_restore): Free restriction data.
402
7abaf5cc
SM
4032012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
404
405 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
406 add argument, tune behavior, and adjust all callers.
407
71f88e00
PE
4082012-07-25 Paul Eggert <eggert@cs.ucla.edu>
409
410 Use typedef for EMACS_INT, EMACS_UINT.
411 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
412 than macros. This simplifies debugging in the usual case, since
413 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
414 and it allows expressions involving EMACS_INT casts.
415 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
416
57ec3034
JD
4172012-07-25 Jan Djärv <jan.h.d@swipnet.se>
418
419 * nsterm.m (ns_read_socket): Return early if there is a modal
420 window (Bug#12043).
421
8137e7b3
MR
4222012-07-25 Martin Rudalics <rudalics@gmx.at>
423
424 * frame.c (Fredirect_frame_focus): In doc-string don't mention
425 that FOCUS-FRAME can be omitted.
426
04e9897c
DA
4272012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
428
429 Adjust buffer text indirection counters at the end of Fkill_buffer.
430 * buffer.c (Fkill_buffer): Adjust indirection counters when the
431 buffer is definitely dead. This should really fix an issue reported
432 by Christoph Scholtes again. (Bug#12007).
433 (init_buffer_once): Initialize indirection counters of
434 buffer_defaults and buffer_local_symbols (for sanity and safety).
435
8a0484e1
EZ
4362012-07-24 Eli Zaretskii <eliz@gnu.org>
437
438 * xdisp.c (init_iterator): Don't compute dimensions of truncation
439 and continuation glyphs on tooltip frames, leave them at zero.
440 Avoids continued lines in tooltips. (Bug#11832)
441
fa691a83
DA
4422012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
443
444 Simplify copy_overlay.
04e9897c 445 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
446 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
447
436bc8e0
EZ
4482012-07-23 Eli Zaretskii <eliz@gnu.org>
449
450 * print.c (print_object): Don't crash when a frame's name is nil
451 or invalid. (Bug#12025)
452
453 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
454 it signals an error when a tooltip frame is being created.
455
d7a7fda3
DA
4562012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
457
458 Cleanup miscellaneous objects allocation and initialization.
459 * alloc.c (allocate_misc): Change to static. Add argument to
460 specify the subtype. Adjust comment and users.
461 (build_overlay): New function.
462 * buffer.c (copy_overlays, Fmake_overlay): Use it.
463 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
464 (allocate_misc): Remove prototype.
465 (build_overlay): Add prototype.
466
4672012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
468
469 Swap buffer text indirection counters in Fbuffer_swap_text.
470 * buffer.c (Fbuffer_swap_text): Swap indirections too.
471 This avoids crash reported by Christoph Scholtes at
472 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
473
9d7fa573
JD
4742012-07-22 Jan Djärv <jan.h.d@swipnet.se>
475
476 * nsmenu.m (Popdown_data): New struct.
477 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
478 free Popdown_data.
479 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
480 (initWithContentRect): Make imgView and contentView non-static
481 and autorelease them. Also autorelease img and matrix (Bug#12005).
482 (dealloc): Remove (Bug#12005).
483
0dd6d66d
DA
4842012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
485
486 Adjust consing_since_gc when objects are explicitly freed.
487 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
488 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
489 (free_cons, free_misc): Subtract object size from consing_since_gc.
490
d36d71df
DA
4912012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
492
493 Simplify and cleanup markers positioning code.
494 * marker.c (attach_marker): More useful eassert.
495 (live_buffer, set_marker_internal): New function.
496 (Fset_marker, set_marker_restricted): Use set_marker_internal.
497 (set_marker_both, set_marker_restricted_both): Use live_buffer.
498
fb9ea40f
PE
4992012-07-22 Paul Eggert <eggert@cs.ucla.edu>
500
501 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
502 as it's limited by the amount of memory, not by INT_MAX.
503
2d5c5f7d
EZ
5042012-07-21 Eli Zaretskii <eliz@gnu.org>
505
07fb592e
EZ
506 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
507 in special-event-map. See the discussion at
508 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
509 for the reasons.
510
37a9eac8 511 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
512 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
513 Fabrice Popineau <fabrice.popineau@supelec.fr>.
514
c4328746
JD
5152012-07-21 Jan Djärv <jan.h.d@swipnet.se>
516
517 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 518 (conversationIdentifier): Return value is NSInteger.
784051c4 519 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 520
6e5d1c12
CY
5212012-07-21 Chong Yidong <cyd@gnu.org>
522
523 * window.c (decode_any_window): Signal an error if the window is
524 on a dead frame (Bug#11984).
525
9928463d
DA
5262012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
527
528 Add indirection counting to speed up Fkill_buffer.
529 * buffer.h (struct buffer): New member.
530 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
531 (Fmake_indirect_buffer): Set indirection counter to -1, increment
532 base buffer indirection counter.
533 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
534 (Fkill_buffer): Adjust indirection counters as needed, don't walk
535 through buffer list if indirection counter is 0.
536
f8643a6b
DA
5372012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
538
539 Extend the value returned by Fgarbage_collect with heap statistics.
540 * alloc.c (Qheap): New symbol.
541 (syms_of_alloc): DEFSYM it.
542 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
543 (Fmemory_free): Remove.
544 (syms_of_alloc): Don't defsubr it.
545 * buffer.c (Fcompact_buffer): Remove.
546 (syms_of_buffer): Don't defsubr it.
547
dac616ff
DA
5482012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
549
550 Make maybe_gc inline.
551 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
552 * lisp.h (consing_since_gc, gc_relative_threshold)
553 (memory_full_cons_threshold): Revert declaration.
554 (maybe_gc): Remove prototype, define as inline.
555 * alloc.c: Remove old commented-out code.
556 (consing_since_gc, gc_relative_threshold)
557 (memory_full_cons_threshold): Revert to global.
558 (maybe_gc): Remove.
559
d7ea76b4
DA
5602012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
561
562 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
563 * lisp.h (build_unibyte_string): New function.
564 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
565 * sysdep.c, w32fns.c, xfns.c: Use it.
566 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
567 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
568 Adjust users accordingly.
569 * font.h (font_open_by_name): Adjust prototype.
570
765e61e3
DA
5712012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
572
573 Cleanup calls to Fgarbage_collect.
574 * lisp.h (maybe_gc): New prototype.
575 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
576 Remove declarations.
577 * alloc.c (maybe_gc): New function.
578 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
579 Make them static.
580 * bytecode.c (MAYBE_GC): Use maybe_gc.
581 * eval.c (eval_sub, Ffuncall): Likewise.
582 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
583 to avoid dependency from auto-save feature.
584
52b852c7
PE
5852012-07-19 Paul Eggert <eggert@cs.ucla.edu>
586
587 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
588 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
589 'for_each_per_buffer_object_at'.
590 All uses changed. It's better to use upper-case for macros that
591 cannot be implemented as functions, to give the reader a clue
592 that they're special.
593
5db81e33
SM
5942012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
595
596 * alloc.c (Fgarbage_collect): Tweak docstring.
597
5b835e1d
DA
5982012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
599
600 Tweak the value returned from Fgarbage_collect again.
601 * alloc.c (Fgarbage_collect): New return value, as confirmed in
602 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
603 Adjust documentation.
604 (total_vector_bytes): Rename to total_vector_slots, adjust
605 accounting.
606 (total_free_vector_bytes): Rename to total_free_vector_slots,
607 adjust accounting.
608 (Qstring_bytes, Qvector_slots): New symbols.
609 (syms_of_alloc): DEFSYM them.
610
9cd47b72
DA
6112012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
612
613 Buffer compaction primitive which may be used from Lisp.
614 * buffer.c (compact_buffer, Fcompact_buffer): New function.
615 (syms_of_buffer): Register Fcompact_buffer.
616 * alloc.c (Fgarbage_collect): Use compact_buffer.
617 * buffer.h (compact_buffer): New prototype.
618 (struct buffer_text): New member.
619
d17337e5
DA
6202012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
621
622 New macro to iterate over all buffers, miscellaneous cleanups.
623 * lisp.h (all_buffers): Remove declaration.
624 * buffer.h (all_buffers): Add declaration, with comment.
625 (for_each_buffer): New macro.
626 * alloc.c (Fgarbage_collect, mark_object): Use it.
627 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
628 (init_buffer): Likewise.
629 * data.c (Fset_default): Likewise.
630 * coding.c (code_conversion_restore): Remove redundant check
631 for dead buffer.
632 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
633
60cfd278
AS
6342012-07-18 Andreas Schwab <schwab@linux-m68k.org>
635
636 Fix bug that created negative-length intervals.
637 * intervals.c (merge_interval_right, merge_interval_left):
638 Do not zero out this interval if it is absorbed by its children,
639 as this interval's total length doesn't change in that case. See
640 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
641
d06714cb
PE
6422012-07-18 Paul Eggert <eggert@cs.ucla.edu>
643
83713154
PE
644 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
645 when invoking (make-bool-vector N t) and N is a positive
646 multiple of 8 -- the last 8 bits were mistakenly cleared.
647
d06714cb
PE
648 Remove some struct layout assumptions in bool vectors.
649 * alloc.c (bool_header_size): New constant.
650 (header_size, word_size): Move earlier, as they're now used earlier.
651 Use 'word_size' in a few more places, where it's appropriate.
652 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
653 padding before the data member of a bool vector.
654 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
655 than doing the check by hand with an abort ().
656
464d5a5e
SM
6572012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
658
5fbc0409
SM
659 * eval.c (Fdefvar): Don't check constants since we only set the var if
660 it's not yet defined anyway (bug#11904).
661
464d5a5e
SM
662 * lisp.h (last_undo_boundary): Declare new var.
663 * keyboard.c (command_loop_1): Set it.
664 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
665 were auto-added by the command loop (bug#11774).
666
8dc2e44a
AS
6672012-07-18 Andreas Schwab <schwab@linux-m68k.org>
668
669 * w32font.c (Qsymbol): Remove local definition.
670 (syms_of_w32font): Don't DEFSYM it.
671
169925ec
DA
6722012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
673
674 Fix sweep_vectors to handle large bool vectors correctly.
675 * alloc.c (sweep_vectors): Account total_vector_bytes for
676 bool vectors larger than VBLOCK_BYTES_MAX.
677
5fbfb018
CY
6782012-07-18 Chong Yidong <cyd@gnu.org>
679
680 * frame.c (x_set_frame_parameters): Revert bogus change introduced
681 in 2012-05-25 commit by Paul Eggert (Bug#11738).
682
3ab6e069
DA
6832012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
684
685 Return more descriptive data from Fgarbage_collect.
686 Suggested by Stefan Monnier in
687 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
688 * alloc.c (bounded_number): New function.
689 (total_buffers, total_vectors): New variable.
690 (total_string_size): Rename to total_string_bytes, adjust users.
691 (total_vector_size): Rename to total_vector_bytes, adjust users.
692 (sweep_vectors): Account total_vectors and total_vector_bytes.
693 (Fgarbage_collect): New return value. Adjust documentation.
694 (gc_sweep): Account total_buffers.
695 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
696 (VECTOR_SIZE): Remove.
697 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
698 (Qinterval, Qmisc): New symbols.
699 (syms_of_data): Initialize them.
700 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
701 (Qcons, Qbuffer): New declarations.
702
6d02fe5b
PE
7032012-07-17 Paul Eggert <eggert@cs.ucla.edu>
704
705 * alloc.c (Fmemory_free): Account for memory-free's own storage.
706 Round up, not down. Improve doc.
707
b7ffe040
DA
7082012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
709
710 Restore old code in allocate_string_data to avoid Faset breakage.
711 Reported by Julien Danjou <julien@danjou.info> in
712 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
713 * alloc.c (allocate_string_data): Restore old code with minor
714 adjustments, fix comment to explain this subtle issue.
715
4dc7c8d5
SM
7162012-07-17 Eli Zaretskii <eliz@gnu.org>
717
718 Remove FILE_SYSTEM_CASE.
719 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
720
721 * fileio.c (FILE_SYSTEM_CASE): Don't define.
722 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
723 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
724 call-process-region passes it through expand-file-name.
725
726 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
727
7282012-07-17 Andreas Schwab <schwab@linux-m68k.org>
729
730 Fix crash when creating indirect buffer (Bug#11917)
731 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
732 Don't handle unbound variables specially if non-zero.
733 (Fbuffer_local_variables): Pass zero.
734 (clone_per_buffer_values): Pass non-zero.
735
7362012-07-17 Andreas Schwab <schwab@linux-m68k.org>
737
738 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
739 to make the loop interruptible.
740
7412012-07-17 Andreas Schwab <schwab@linux-m68k.org>
742
743 * gnutls.c (emacs_gnutls_handshake): Only retry if
744 GNUTLS_E_INTERRUPTED.
745
cce7fefc
DA
7462012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
747
748 Cleanup and convert miscellaneous checks to eassert.
749 * alloc.c (mark_interval): Fix comment, partially rephrase
750 old comment from intervals.h (see below).
751 * intervals.c (find_interval, adjust_intervals_for_insertion)
752 (delete_interval, adjust_intervals_for_deletion)
753 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
754 Convert to eassert.
755 (adjust_intervals_for_insertion, make_new_interval):
756 Remove obsolete and unused code.
757 * intervals.h (struct interval): Remove obsolete comment.
758 * textprotp.c (erase_properties): Remove unused code.
759 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
760 (Fremove_list_of_text_properties): Convert to eassert.
761
9ea10cc3
CY
7622012-07-17 Chong Yidong <cyd@gnu.org>
763
764 * editfns.c (Finsert_char): Doc fix.
765
3900d5de
DA
7662012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
767
768 Fix previous change to make Fmemory_free always accurate.
769 * alloc.c (make_interval): Update total_free_intervals.
770 (make_float): Likewise for total_free_floats.
771 (free_cons, Fcons): Likewise for total_free_conses.
772 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
773 Likewise for total_free_vector_bytes.
774 (Fmake_symbol): Likewise for total_free_symbols.
775 (bytes_free): Remove.
776
7098646f
DA
7772012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
778
779 Simple free memory accounting feature.
780 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
781 (sweep_vectors): Accumulate size of free vectors.
782 (Fgarbage_collect): Setup bytes_free.
783 (Fmemory_free): New function.
784 (syms_of_alloc): Register it.
785
22657b40
DA
7862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Cleanup overlays checking.
789 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
790 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
791 eassert and OVERLAYP.
792 (sort_overlays): Change to use OVERLAYP.
793
ddfc8813
RK
7942012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
795
796 * editfns.c (Finsert_char): Make it interactive, and make the
797 second arg optional. Copy interactive spec and docstring from
798 ucs-insert.
799
7c26cf3c
PE
8002012-07-17 Paul Eggert <eggert@cs.ucla.edu>
801
802 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
803 Unlike the other wrapped functions, fabs has an unspecified
804 effect on errno.
805
5d127af9
JD
8062012-07-16 Jan Djärv <jan.h.d@swipnet.se>
807
808 * nsterm.m (keyDown): Interpret flags without left/right bits
809 as the left key (Bug#11670).
810
6a0dd1d7
DA
8112012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
812
813 Remove empty and useless init functions.
814 * lisp.h (init_character_once, init_fns, init_image)
815 (init_filelock, init_sound): Remove prototype.
816 * character.c (init_character_once): Remove.
817 * filelock.c (init_filelock): Likewise.
818 * fns.c (init_fns): Likewise.
819 * image.c (init_image): Likewise.
820 * sound.c (init_sound): Likewise.
821 * emacs.c (main): Adjust accordingly.
822
7a6136fd
DA
8232012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
824
825 * gtkutil.h: Tiny cleanups.
826 (use_old_gtk_file_dialog): Remove useless declaration.
827 (xg_uses_old_file_dialog): Add suggested const attribute.
828
ce811ad9
EZ
8292012-07-15 Eli Zaretskii <eliz@gnu.org>
830
831 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
832 (bidi_paragraph_init): Use it to limit search forward for a strong
833 directional character in abnormally large paragraphs full of
834 neutral or weak characters. (Bug#11943)
835
c9adfeaa
SF
8362012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
837
838 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
839 the toolbar (Bug#9451).
840 (xg_make_tool_item): Give the widget event box a transparent
841 background.
842
fff62aa9
DA
8432012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
844
845 Cleanup basic allocation variables and functions.
846 * alloc.c (ignore_warnings, init_intervals, init_float)
847 (init_cons, init_symbol, init_marker): Remove.
848 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
849 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
850 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
851 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
852 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
853 (staticidx, init_alloc_once, init_strings, free_ablock):
854 Remove redundant initialization.
855 * fns.c (init_weak_hash_tables): Remove.
856 * lisp.h (init_weak_hash_tables): Remove prototype.
857
9730daca
DA
8582012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
859
860 Use zero_vector where appropriate.
861 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
862 accordingly.
863 * lisp.h (zero_vector): New declaration.
864 * font.c (null_vector): Remove.
865 (syms_of_font): Remove initialization and staticpro.
866 (font_list_entities, font_find_for_lface): Change to use zero_vector.
867 * keymap.c (Faccessible_keymaps): Likewise.
868
2e2d2a13
LL
8692012-07-15 Leo Liu <sdl.web@gmail.com>
870
871 * fringe.c: Fix typo in comments.
872
cd276f6e
LL
8732012-07-14 Leo Liu <sdl.web@gmail.com>
874
875 * fringe.c: Add a new bitmap exclamation-mark.
876
5a1131d9
EZ
8772012-07-14 Eli Zaretskii <eliz@gnu.org>
878
879 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
880
881 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
882 (HAVE_MENUS): Don't define, defined by editing config.in with
883 msdos/sed2v2.inp.
884 (GMALLOC_INHIBIT_VALLOC): Don't define.
885 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
886
22e983b7
JB
8872012-07-14 Juanma Barranquero <lekktu@gmail.com>
888
889 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
890
5b3f250f
GM
8912012-07-14 Glenn Morris <rgm@gnu.org>
892
893 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
894 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
895 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
896
33d63ff4
GM
8972012-07-13 Glenn Morris <rgm@gnu.org>
898
5b633342
GM
899 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
900
33d63ff4
GM
901 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
902 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
903
b55b9f85
JD
9042012-07-13 Jan Djärv <jan.h.d@swipnet.se>
905
0dc8cf50
JD
906 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
907 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
908 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
909 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
910 where appropriate.
911 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
912 as boolean expression.
913 (x_set_window_size): Remove unused variable toolbar.
914 (ns_get_color_default, ns_mod_to_lisp): Remove.
915 (ns_mouse_position): Remove unused variables xchar and ychar.
916 (ns_compute_glyph_string_overhangs): Remove unused variable face.
917 (ns_set_vertical_scroll_bar): Remove unused variable count.
918 (ns_delete_terminal): Remove unused variable i.
919 (ns_term_init): Remove unused variables r, g and b.
920 (mouseDown): Remove unused variable window.
921 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
922 (initFrameFromEmacs): Remove unused variable vbextra.
923 (mouseEntered): Remove unused variables p and dpyinfo.
924 (mouseExited): Remove unused variables p and r.
925 (ns_define_frame_cursor, ns_clear_frame_area)
926 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
927 (menuDown): Assign [sender tag] to variable and cast the variable.
928
929 * nsterm.h (menuDown): Add id as type to argument sender.
930 (ns_display_info_for_name): Add Lisp_Object argument.
931 (ns_term_init): Add Lisp_Object argument.
932 (ns_map_event_to_object): Add void argument.
933 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
934 prototype with arguments and only declare if __OBJC__.
935 (nxatoms_of_nsselect): Add void argument.
936 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
937 (ns_alloc_autorelease_pool): Add void argument.
938 (ns_release_autorelease_pool): Add void* argument.
939 (ns_get_defaults_value): Add const char* argument.
940
941 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
942 (initFromContents): Use SSDATA where appropriate.
943 (ns_update_menubar): Add braces to ambigous if-else.
944 (initWithTitle): Put () around assignment in if statement.
945 (ns_menu_show): Remove unused variables window and keymap.
946 (update_frame_tool_bar): Remove unused variable selected_p.
947 (initWithContentRect): Remove unused variable this_cmd_name.
948
949 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
950 appropriate.
951 (setXBMColor): Remove unused variable len.
952 (setPixmapData): Put () around assignment in loop statement.
953
954 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
955 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
956 where appropriate.
957 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
958 around assignment in loop statement.
959 (nsfont_open): Remove unused variable i.
960 (nsfont_open): Remove unused variable len.
961 (nsfont_draw): Remove unused variable cs.
962
963 * nsfns.m (x_set_icon_name, ns_set_name_internal)
964 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
965 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
966 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
967 (Fns_font_name, Fns_perform_service)
968 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
969 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
970 (ns_set_name): Remove unused variable view.
971 (x_set_menu_bar_lines): Remove unused variable olines.
972 (x_set_tool_bar_lines): Remove unused variable root_window.
973 (Fns_list_colors): Put () around assignment in while statement.
974 (Fns_perform_service): Remove unused variable len.
975 (Fns_display_usable_bounds): Remove unused variable top.
976 (syms_of_nsfns): Remove unused variable i.
977
b55b9f85
JD
978 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
979 memcpy (Bug#11907).
980
ed9265fc 9812012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
982
983 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
984 and free it with DestroyExceptionInfo (Bug#11558).
985
ef099b57
JB
9862012-07-13 Juanma Barranquero <lekktu@gmail.com>
987
988 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
989 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
990 Set here, not in nt/config.nt.
991
ea814a5d
EZ
9922012-07-13 Eli Zaretskii <eliz@gnu.org>
993
994 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
995 cursor overflow into the last glyph on display line when the right
996 fringe is off. (Bug#11832)
997
1a952767
PE
9982012-07-13 Paul Eggert <eggert@cs.ucla.edu>
999
1000 * xdisp.c (produce_special_glyphs): Now static.
1001 * dispextern.h (produce_special_glyphs): Remove decl.
1002
983188fd
GM
10032012-07-13 Glenn Morris <rgm@gnu.org>
1004
32fb4bb6
GM
1005 * s/bsd-common, s/cygwin.h: Remove empty files.
1006 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1007
983188fd
GM
1008 * s/usg5-4-common.h (USG, USG5):
1009 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1010 * s/sol2-6.h (SOLARIS2):
1011 * s/irix6-5.h (IRIX6_5):
1012 * s/hpux10-20.h (USG, USG5, HPUX):
1013 * s/gnu-linux.h (USG, GNU_LINUX):
1014 * s/freebsd.h (BSD_SYSTEM):
1015 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1016 * s/cygwin.h (CYGWIN):
1017 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1018 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1019
d1e68667 10202012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1021
1022 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1023
6de0e799
GM
10242012-07-13 Glenn Morris <rgm@gnu.org>
1025
739ae010
GM
1026 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1027
dbee5793
GM
1028 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1029
6de0e799
GM
1030 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1031 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1032
b82da769
GM
10332012-07-12 Glenn Morris <rgm@gnu.org>
1034
4fae5a7a 1035 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1036
1037 * process.c (init_process_emacs): Rename from init_process.
1038 The old name is also the name of a Mach system call.
1039 * lisp.h, emacs.c: Update for this name change.
1040 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1041 longer needed.
1042
5a979817
EZ
10432012-07-12 Eli Zaretskii <eliz@gnu.org>
1044
1045 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1046 memmove call that removes glyphs covered by the left truncation
1047 glyph. Improve commentary.
1048 (display_line): Fix display of continuation glyphs on GUI frames
1049 when the right fringe is turned off and variable-size fonts are
1050 used in the window. Move the code that appends a stretch glyph to
1051 produce_special_glyphs, so that it could be used for truncation
1052 and continuation glyphs alike.
1053 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1054 glyph of a suitably computed width, to align the special glyphs at
1055 the window margin. Code moved from display_line. (Bug#11832)
1056
3e91a053
GM
10572012-07-12 Glenn Morris <rgm@gnu.org>
1058
ba9e4b84
GM
1059 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1060
1061 * s/gnu-linux.h, s/hpux10-20.h:
1062 Do not unconditionally define HAVE_XRMSETDATABASE.
1063
3e91a053
GM
1064 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1065
b300b1f4
PE
10662012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 Fix typos that broke OS X build.
1069 Reported by Randal L. Schwartz in
1070 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1071 * nsterm.m (ns_timeout): Add missing local decl.
1072 (ns_get_color): snprintf -> sprintf, to fix typo.
1073
6e777848
GM
10742012-07-12 Glenn Morris <rgm@gnu.org>
1075
3f922c37
GM
1076 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1077 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1078 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1079 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1080
0ab7b23a
GM
1081 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1082 Move PTY_OPEN to configure.
1083
6e777848
GM
1084 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1085 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1086 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1087
4a7edc24
DA
10882012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1089
1090 Use empty_unibyte_string where applicable.
1091 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1092 * lread.c (read1): Likewise.
1093 * xsettings.c (syms_of_xsettings): Likewise.
1094
308aab79
GM
10952012-07-12 Glenn Morris <rgm@gnu.org>
1096
42bd1719
GM
1097 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1098 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1099 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1100 * s/hpux10-20.h (RUN_TIME_REMAP):
1101 * s/bsd-common.h (TABDLY): Move to configure.
1102
1103 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1104
1105 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1106
ea0bbd17 1107 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1108 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1109
1110 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1111
308aab79
GM
1112 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1113 * s/template.h: Move NARROWPROTO to configure.
1114
ee1cf5cf
GM
11152012-07-11 Glenn Morris <rgm@gnu.org>
1116
30fe9bf4
GM
1117 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1118 unused since 2011-01-17 change to systty.h.
1119
ee1cf5cf
GM
1120 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1121 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1122 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1123
63e47e07
PE
11242012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1125
1126 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1127
c43fb4c3
GM
11282012-07-11 Glenn Morris <rgm@gnu.org>
1129
1130 * s/darwin.h, s/gnu-linux.h, s/template.h:
1131 Move INTERRUPT_INPUT to configure.
1132
e8df9267
DA
11332012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1134
1135 Minor adjustments to interning code.
1136 * lisp.h (intern, intern_c_string): Redefine as static inline
1137 wrappers for intern_1 and intern_c_string_1, respectively.
1138 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1139 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1140 Vobarray checking.
e8df9267
DA
1141 * font.c (font_intern_prop): Likewise. Adjust comment.
1142 * w32font.c (intern_font_name): Likewise.
1143
34348bd4
AS
11442012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1145
d96a1e0c
AS
1146 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1147
34348bd4
AS
1148 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1149 of Fcar/Fcdr if possible.
1150 * font.c (check_otf_features): Likewise.
1151 * fontset.c (Fnew_fontset): Likewise.
1152 * gnutls.c (Fgnutls_boot): Likewise.
1153 * minibuf.c (read_minibuf): Likewise.
1154 * msdos.c (IT_set_frame_parameters): Likewise.
1155 * xmenu.c (Fx_popup_dialog): Likewise.
1156 * w32menu.c (Fx_popup_dialog): Likewise.
1157
c8add24e
GM
11582012-07-11 Glenn Morris <rgm@gnu.org>
1159
4b575b3c
GM
1160 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1161 since nothing has defined it on these platforms.
1162
09f4e3b0
GM
1163 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1164 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1165
172bedef
GM
1166 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1167 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1168 Move CLASH_DETECTION to configure.
1169
249685df
GM
1170 * s/gnu.h: Remove file, which is now empty.
1171
c8add24e
GM
1172 * s/gnu.h, s/gnu-linux.h:
1173 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1174
b41253a3
JW
11752012-07-11 John Wiegley <johnw@newartisans.com>
1176
1177 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1178 function attribute, so we only use it if it exists in the
1179 compiler.
1180
d923b542
DA
11812012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 Avoid call to strlen in fast_c_string_match_ignore_case.
1184 * search.c (fast_c_string_match_ignore_case): Change to use
1185 length argument. Adjust users accordingly.
1186 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1187
5ebbef1d
PE
11882012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1189
bb352260
PE
1190 Assume mkdir, rmdir.
1191 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1192 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1193
57054ddd
PE
1194 Assume rename.
1195 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1196
b747d3f7
PE
1197 Assume perror.
1198 * s/hpux10-20.h (HAVE_PERROR): Remove.
1199 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1200 Remove dummy definition, as this problem was obsolete long ago.
1201
5ebbef1d
PE
1202 Assume strerror.
1203 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1204
984e7f30
DA
12052012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Avoid calls to strlen in font processing functions.
1208 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1209 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1210 users accordingly.
d923b542
DA
1211 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1212 Adjust prototypes.
1213 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1214 Change to return ptrdiff_t.
984e7f30
DA
1215 (xfont_list_pattern, xfont_match): Use length returned by
1216 xfont_decode_coding_xlfd.
1217 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1218
20e94fdd
GM
12192012-07-11 Glenn Morris <rgm@gnu.org>
1220
9d596af3
GM
1221 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1222 Move DONT_REOPEN_PTY to configure.
1223
20e94fdd
GM
1224 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1225 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1226
e99a530f
PE
12272012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1228
22ffb973
PE
1229 Remove "#define unix" that is no longer needed (Bug#11905).
1230 * s/aix4-2.h (unix): Remove; no longer needed.
1231
e9a9ae03
PE
1232 EMACS_TIME simplification (Bug#11875).
1233 This replaces macros (which typically do not work in GDB)
1234 with functions, typedefs and enums, making the code easier to debug.
1235 The functional style also makes code easier to read and maintain.
1236 * systime.h: Include <sys/time.h> on all hosts, not just if
1237 WINDOWSNT, since 'struct timeval' is needed in general.
1238 (EMACS_TIME): Now a typedef, not a macro.
1239 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1240 not macros.
1241 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1242 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1243 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1244 (EMACS_TIME_LE): Now functions, not macros.
1245 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1246 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1247 which are not functions. All uses rewritten to use:
1248 (make_emacs_time): New function.
1249 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1250 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1251 not functions. All uses rewritten to use the following, respectively:
1252 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1253 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1254 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1255 * fileio.c (Fcopy_file):
1256 * xterm.c (XTflash): Get the current time closer to when it's used.
1257 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1258
ffacb126
PE
1259 * bytecode.c (targets): Suppress -Woverride-init warnings.
1260
e99a530f
PE
1261 Simplify by avoiding confusing use of strncpy etc.
1262 * doc.c (Fsnarf_documentation):
1263 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1264 * frame.c (Fmake_terminal_frame):
1265 * gtkutil.c (get_utf8_string):
1266 * lread.c (openp):
1267 * nsmenu.m (ns_update_menubar):
1268 * regex.c (regerror):
1269 Prefer memcpy to strncpy and strncat when either will do.
1270 * fileio.c (Fsubstitute_in_file_name):
1271 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1272 (menu_separator_name_p):
1273 * nsmenu.m (ns_update_menubar):
1274 Prefer memcmp to strncmp when either will do.
1275 * nsterm.m: Include <ftoastr.h>.
1276 (ns_get_color):
1277 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1278 Prefer snprintf to strncpy.
1279 * nsterm.m (ns_term_init):
1280 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1281 * nsterm.m (ns_term_init):
1282 Avoid the need for strncpy, by using build_string or
1283 make_unibyte_string directly. Use dtoastr, not snprintf.
1284 * process.c (Fmake_network_process): Diagnose service names that
1285 are too long, rather than silently truncating them or creating
1286 non-null-terminated names.
1287 (Fnetwork_interface_info): Likewise, for interface names.
1288 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1289 Prefer sprintf to strncat.
1290 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1291 Prefer vsnprintf to vsprintf + strncpy.
1292
c59592b3
GM
12932012-07-10 Glenn Morris <rgm@gnu.org>
1294
1295 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1296 Clarify fallback case.
1297
7d7bbefd
DA
12982012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1299
1300 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1301 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1302 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1303 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1304 where argument type is known to be a Lisp_Cons.
1305
3a4c8000
TT
13062012-07-10 Tom Tromey <tromey@redhat.com>
1307
1308 * bytecode.c (BYTE_CODE_THREADED): New macro.
1309 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1310 (enum byte_code_op): New type.
1311 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1312 (exec_byte_code): Use them. Use token threading when applicable.
1313
2a0213a6
DA
13142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1315
1316 Optimize pure C strings initialization.
1317 * lisp.h (make_pure_string): Fix prototype.
1318 (build_pure_c_string): New function, defined as static inline. This
1319 provides a better opportunity to optimize away calls to strlen when
1320 the function is called with compile-time constant argument.
1321 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1322 argument, adjust users accordingly. Use build_pure_c_string where
1323 appropriate.
1324 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1325 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1326 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1327
cb1caeaf
DA
13282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1329
1330 Avoid calls to strlen in miscellaneous functions.
1331 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1332 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1333 * lread.c (openp): Likewise.
1334
c293e30c
DA
13352012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 Avoid calls to strlen in path processing functions.
1338 * fileio.c (file_name_as_directory): Add comment. Change to add
1339 srclen argument and return the length of result. Adjust users
1340 accordingly.
1341 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1342 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1343 users accordingly.
1344 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1345
9e059e3f
GM
13462012-07-10 Glenn Morris <rgm@gnu.org>
1347
d02eb359
GM
1348 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1349 Move PENDING_OUTPUT_COUNT definition to configure.
1350
882cf227
GM
1351 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1352 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1353 * s/gnu.h (DATA_START): Move definitions to configure.
1354
af6e839f
GM
1355 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1356 We include usg5-4-common.h, which defines them both.
1357
40289a12
GM
1358 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1359 O_RDONLY already includes it).
1360
9e059e3f
GM
1361 Stop ns builds setting the EMACSLOADPATH environment variable.
1362 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1363 Now it does not set EMACSLOADPATH, just returns the load-path string.
1364 * nsterm.h: Update accordingly.
1365 * lread.c [HAVE_NS]: Include nsterm.h.
1366 (init_lread) [HAVE_NS]: Use ns_load_path.
1367 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1368
7c4e8ec0
GM
13692012-07-09 Glenn Morris <rgm@gnu.org>
1370
d4f600ff
GM
1371 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1372 since the included bsd-common.h does so.
1373
cbb31951
GM
1374 Stop ns builds setting the EMACSPATH environment variable.
1375 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1376 (ns_init_paths): Do not set EMACSPATH.
1377 * nsterm.h (ns_exec_path): Add it.
1378 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1379 Use ns_exec_path.
1380
7c4e8ec0
GM
1381 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1382
26bccfae
PE
13832012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1384
a0bee46f
PE
1385 * process.c (wait_reading_process_output): 'waitchannels' was unset
1386 when read_kbd || !NILP (wait_for_cell); fix this.
1387
5994c183
PE
1388 Add GCC-style 'const' attribute to functions that can use it.
1389 * character.h (char_resolve_modifier_mask):
1390 * keyboard.h (make_ctrl_char):
1391 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1392 (init_character_once, next_almost_prime, init_fns, init_image)
1393 (flush_pending_output, init_sound):
1394 * mem-limits.h (start_of_data):
1395 * menu.h (finish_menu_items):
1396 Add ATTRIBUTE_CONST.
1397 * emacs.c (DEFINE_DUMMY_FUNCTION):
1398 Declare the dummy function with ATTRIBUTE_CONST.
1399 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1400 Add decls with ATTRIBUTE_CONST.
1401
26bccfae
PE
1402 Minor improvements to make_formatted_string.
1403 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1404 where int is good enough, as vsprintf returns an int.
1405 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1406
a8290ec3
DA
14072012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1408
1409 Use make_formatted_string to avoid double length calculation.
1410 * lisp.h (make_formatted_string): New prototype.
1411 * alloc.c (make_formatted_string): New function.
1412 * buffer.c (Fgenerate_new_buffer_name): Use it.
1413 * dbus.c (syms_of_dbusbind): Likewise.
1414 * editfns.c (Fcurrent_time_zone): Likewise.
1415 * filelock.c (get_boot_time): Likewise.
1416 * frame.c (make_terminal_frame, set_term_frame_name)
1417 (x_report_frame_params): Likewise.
1418 * image.c (gs_load): Likewise.
1419 * minibuf.c (get_minibuffer): Likewise.
1420 * msdos.c (dos_set_window_size): Likewise.
1421 * process.c (make_process): Likewise.
1422 * xdisp.c (ensure_echo_area_buffers): Likewise.
1423 * xsettings.c (apply_xft_settings): Likewise.
1424
d01ba2f1
GM
14252012-07-09 Glenn Morris <rgm@gnu.org>
1426
1427 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1428 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1429 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1430 * nsterm.h (ns_etc_directory): Add it.
1431 * callproc.c [HAVE_NS]: Include nsterm.h.
1432 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1433
f1f924b6
DA
14342012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 Move marker debugging code under MARKER_DEBUG.
1437 * marker.c (MARKER_DEBUG): Move marker debugging code under
1438 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1439 for bootstrap with --enable-checking (~3x slowdown reported
1440 by Juanma Barranquero <lekktu@gmail.com>).
1441 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1442
ab531b66
PE
14432012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1446 See <http://bugs.gnu.org/11825#29>.
1447
c4b3bc8a
EZ
14482012-07-08 Eli Zaretskii <eliz@gnu.org>
1449
1450 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1451 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1452 (display_line): Add commentary about displaying truncation glyphs
1453 on GUI frames.
1454 (produce_special_glyphs): Move here from term.c.
1455
1456 * term.c (produce_special_glyphs): Move to xdisp.c.
1457
1458 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1459 section.
c4b3bc8a 1460
b676b881
AS
14612012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1462
f17c5273
AS
1463 * xdisp.c (display_line): Avoid warning about implicit declaration
1464 of FRAME_FONT.
1465
298819b9
AS
1466 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1467
b676b881
AS
1468 * lisp.h: Remove empty conditional.
1469
6045c4fd
PE
14702012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1471
b3350bf9
PE
1472 * lread.c (load_path_check): Now static.
1473
6045c4fd
PE
1474 Fix some minor --with-ns problems found by static checking.
1475 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1476 (x_set_font) [!HAVE_X_WINDOWS]:
1477 * image.c (xpm_load_image) [HAVE_NS]:
1478 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1479 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1480 Remove unused local.
1481 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1482 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1483 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1484 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1485 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1486 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1487 Fix pointer signedness problem.
1488 * xfaces.c (FRAME_X_FONT_TABLE):
1489 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1490
929e7845
GM
14912012-07-07 Glenn Morris <rgm@gnu.org>
1492
1493 * lread.c (load_path_check): New function, split from init_lread.
1494 (init_lread): Reorganize. Motivation:
1495 If EMACSLOADPATH is set, check/warn about that rather than the
1496 defaults, which we are not going to use. Hence we can remove
1497 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1498 Don't warn if site-lisp directories are missing.
1499 If not installed, start from a blank load-path, since
1500 PATH_LOADSEARCH refers to the eventual installation directories.
1501
58dd0aa4
EZ
15022012-07-07 Eli Zaretskii <eliz@gnu.org>
1503
1504 Support truncation and continuation glyphs on GUI frames, when
1505 fringes are disabled. (Bug#11832)
1506 * xdisp.c (init_iterator): Get dimensions of truncation and
1507 continuation glyphs even if on GUI frames. Adjust
1508 it->last_visible_x on GUI frames when the left or right fringes,
1509 or both, are absent.
1510 (start_display, move_it_in_display_line_to): Handle the case of a
1511 GUI frame without a fringe to display continuation or truncation
1512 glyphs.
1513 (insert_left_trunc_glyphs): Support GUI frames: make sure
1514 truncation glyphs overwrite enough glyphs from the current line to
1515 have sufficient space in pixels.
1516 (display_line): Support truncation and continuation glyphs on GUI
1517 frames. If some spare pixels are left on the line after inserting
1518 the truncation glyphs, fill that space with a stretch glyph of a
1519 suitably computed width.
1520
1521 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1522 produce_glyphs, to support GUI sessions.
1523
31571fd7
PE
15242012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1525
5a16b9bc
PE
1526 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1527
f3047c75
PE
1528 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1529
31571fd7
PE
1530 Do not require float-time's arg to fit in time_t (Bug#11825).
1531 This works better on hosts where time_t is unsigned, and where
1532 float-time is applied to the (negative) difference between two times.
1533 * editfns.c (decode_time_components): Last arg is now double *,
1534 not int *, and means to store all the result as a double, without
1535 worrying about whether the seconds part fits in time_t.
1536 All callers changed.
1537 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1538 All callers changed.
1539 (Ffloat_time): Do not fail merely because the specified time falls
1540 outside of time_t range.
1541
4516fbef
GM
15422012-07-07 Glenn Morris <rgm@gnu.org>
1543
1544 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1545 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1546 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1547
07adc2c6
JB
15482012-07-07 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1551 Update dependencies.
1552
1553 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1554
fd573f31
PE
15552012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1556
fee5959d
PE
1557 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1558 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1559 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1560 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1561 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1562 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1563
fd573f31
PE
1564 * xfont.c (compare_font_names): Redo to omit the need for casts.
1565
ddadbc0e
AS
15662012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1567
fca8d6b6
AS
1568 * xfns.c (Fx_change_window_property): Doc fix.
1569 * w32fns.c (Fx_change_window_property): Doc fix.
1570
ddadbc0e
AS
1571 * w32fns.c (Fx_window_property): Accept the same arguments as the
1572 X Windows version. Doc fix.
1573 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1574
ed9265fc 15752012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1576 Eli Zaretskii <eliz@gnu.org>
1577
1578 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1579 Windows-specific code from nt/config.nt moved here.
1580 Obsolete settings removed.
1581
216ee680
PE
15822012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1583
1584 * process.c: Avoid unnecessary calls to gettime.
1585 (wait_reading_process_output): Don't get the time of day
1586 when gobbling data immediately and not waiting, as there's no need
1587 for it in that case. This removes a FIXME.
1588
bdd091e4
JD
15892012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1590
1591 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1592 is defined (Bug#11768).
1593
9d44f8ce
DA
15942012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1595
1596 Fix marker debugging code.
1597 * marker.c (byte_char_debug_check): Do not perform the check
1598 if buffer is not multibyte.
090bd7cb
JB
1599 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1600 Call byte_char_debug_check with correct arguments.
9d44f8ce 1601
90fc4786
DA
16022012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1603
1604 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1605 * marker.c (byte_char_debug_check, count_markers):
1606 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1607 (byte_debug_flag): Remove.
1608 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1609 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1610
7b7ae965
DA
16112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1612
4e57b342
DA
1613 Avoid code repetition in marker-related functions.
1614 * marker.c (attach_marker): New function.
1615 (Fset_marker, set_marker_restricted, set_marker_both)
1616 (set_marker_restricted_both): Use it.
1617 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1618 Consistently rename charno to charpos.
1619 (marker_position): Add eassert.
1620 (marker_byte_position): Convert to eassert.
1621
16222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1623
1624 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1625 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1626 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1627
657924ff
DA
16282012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1629
1630 Introduce fast path for the widely used marker operation.
1631 * alloc.c (build_marker): New function.
1632 * lisp.h (build_marker): New prototype.
1633 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1634 * composite.c (autocmp_chars): Likewise.
1635 * editfns.c (buildmark): Remove.
1636 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1637 (save_restriction_save): Use build_marker.
1638 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1639 * window.c (save_window_save): Likewise.
1640
041a49a6
DA
16412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1642
1643 Do not use Fdelete_overlay in delete_all_overlays
1644 to avoid redundant calls to unchain_overlay.
1645 * buffer.c (drop_overlay): New function.
1646 (delete_all_overlays, Fdelete_overlay): Use it.
1647 * minibuf.c (get_minibuffer): Fix comment.
1648
7dca65a4
PE
16492012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 Port to OpenBSD 5.1 amd64.
1652 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1653 This is needed for OpenBSD, and should be harmless on all BSD systems.
1654 Also, include <sys/sysctl.h>, as it should be available on all
1655 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1656 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1657 use p_pid member, not kp_proc.pid.
1658
8eb876e2
GM
16592012-07-06 Glenn Morris <rgm@gnu.org>
1660
1661 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1662
38182d90
PE
16632012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 More xmalloc and related cleanup.
1666 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1667 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1668 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1669 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1670 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1671 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1672 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1673 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1674 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1675 * xterm.c:
1676 Omit needless casts involving void * pointers and allocation.
1677 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1678 as the former is more robust if P's type is changed.
1679 Prefer xzalloc to xmalloc + memset 0.
1680 Simplify malloc-or-realloc to realloc.
1681 Don't worry about xmalloc returning a null pointer.
1682 Prefer xstrdup to xmalloc + strcpy.
1683 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1684 growing it.
1685 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1686 alloca of a constant.
1687
6dd5a677
EZ
16882012-07-05 Eli Zaretskii <eliz@gnu.org>
1689
1690 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1691 hscroll is larger than the line width. Fixes long and futile
1692 looping inside extend_face_to_end_of_line (on a TTY) producing
1693 glyphs that are not needed and thrown away.
1694
6b312f0f
DA
16952012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1696
1697 * marker.c (set_marker_restricted_both): Simplify by using
1698 clip_to_bounds.
1699
f520ef9b
PE
17002012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1701
1702 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1703
383b7c95
JD
17042012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1705
1706 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1707 not defined (Bug#11768).
1708 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1709 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1710 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1711 followed by gtk_box_set_homogeneous (Bug#11768).
1712 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1713 (update_theme_scrollbar_width, xg_create_scroll_bar):
1714 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1715 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1716 (is_box_type): New function (Bug#11768).
1717 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1718 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1719 with default display (Bug#11768).
1720
d6e7bf45
EZ
17212012-07-05 Eli Zaretskii <eliz@gnu.org>
1722
1723 * xdisp.c (window_hscroll_limited): New function.
1724 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1725 coordinates when window's hscroll is set to insanely large
1726 values. (Bug#11857)
1727
431391ec
JB
17282012-07-05 Juanma Barranquero <lekktu@gmail.com>
1729
1730 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1731 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1732
23f86fce
DA
17332012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1734
1735 Cleanup xmalloc.
1736 * lisp.h (xzalloc): New prototype. Omit needless casts.
1737 * alloc.c (xzalloc): New function. Omit needless casts.
1738 * charset.c: Omit needless casts. Convert all calls to
1739 xmalloc with following memset to xzalloc.
1740 * dispnew.c: Likewise.
1741 * fringe.c: Likewise.
1742 * image.c: Likewise.
1743 * sound.c: Likewise.
1744 * term.c: Likewise.
1745 * w32fns.c: Likewise.
1746 * w32font.c: Likewise.
1747 * w32term.c: Likewise.
1748 * xfaces.c: Likewise.
1749 * xfns.c: Likewise.
1750 * xterm.c: Likewise.
1751 * atimer.c: Omit needless casts.
1752 * buffer.c: Likewise.
1753 * callproc.c: Likewise.
1754 * ccl.c: Likewise.
1755 * coding.c: Likewise.
1756 * composite.c: Likewise.
1757 * doc.c: Likewise.
1758 * doprnt.c: Likewise.
1759 * editfns.c: Likewise.
1760 * emacs.c: Likewise.
1761 * eval.c: Likewise.
1762 * filelock.c: Likewise.
1763 * fns.c: Likewise.
1764 * gtkutil.c: Likewise.
1765 * keyboard.c: Likewise.
1766 * lisp.h: Likewise.
1767 * lread.c: Likewise.
1768 * minibuf.c: Likewise.
1769 * msdos.c: Likewise.
1770 * print.c: Likewise.
1771 * process.c: Likewise.
1772 * region-cache.c: Likewise.
1773 * search.c: Likewise.
1774 * sysdep.c: Likewise.
1775 * termcap.c: Likewise.
1776 * terminal.c: Likewise.
1777 * tparam.c: Likewise.
1778 * w16select.c: Likewise.
1779 * w32.c: Likewise.
1780 * w32reg.c: Likewise.
1781 * w32select.c: Likewise.
1782 * w32uniscribe.c: Likewise.
1783 * widget.c: Likewise.
1784 * xdisp.c: Likewise.
1785 * xmenu.c: Likewise.
1786 * xrdb.c: Likewise.
1787 * xselect.c: Likewise.
1788
0497dc44
PE
17892012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 * fileio.c (time_error_value): Check the right error number.
1792 Problem reported by Troels Nielsen in
1793 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1794
356e7178
PE
17952012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1796
4e71fd89
PE
1797 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1798 This should be fixed in a better way; see Eli Zaretskii in
1799 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1800 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1801
f0941253
PE
1802 * fileio.c (time_error_value): Rename from special_mtime.
1803 The old name's problems were noted by Eli Zaretskii in
1804 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1805
065c9eb4
PE
1806 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1807 This variable's comment says Emacs needs at least one GDB-visible
1808 symbol of type enum pvec_type, to work around GDB problems.
1809 The symbol's value doesn't matter.
1810
356e7178
PE
1811 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1812 that causes compilation to fail on pre-C99 compilers.
1813
ed9265fc 18142012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1815
1816 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1817 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1818
3884d954
DA
18192012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1820
d209e2fb 1821 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1822 headers for buffer_defaults and buffer_local_symbols.
1823 Reported by Juanma Barranquero <lekktu@gmail.com>.
1824
ee28be33
SM
18252012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1826
1827 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1828 * lisp.h (enum pvec_type): Use fewer bits.
1829 (PSEUDOVECTOR_SIZE_BITS): New constant.
1830 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1831 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1832 change in pvec_type.
1833 (PSEUDOVECTOR_TYPEP): New macro.
1834 (TYPED_PSEUDOVECTORP): Use it.
1835 * fns.c (internal_equal): Adapt code to extract pvectype.
1836 * emacs.c (gdb_pvec_type): Update type.
1837 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1838 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1839 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1840 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1841 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1842 abusing vector->header.next.nbytes.
1843 (live_vector_p): Use PVEC_TYPE.
1844 (mark_object): Adapt code to extract pvectype. Use switch.
1845
c7f2cd7f
PE
18462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1849 Tighten new eassert a bit.
1850
8ce70ed2
DA
18512012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1852
1853 Fix compilation with --enable-gcc-warnings and -O1
1854 optimization level.
1855 * doprnt.c (doprnt): Change type of tem to int, initialize
1856 to avoid compiler warning. Add eassert.
1857 * search.c (simple_search): Initialize match_byte to avoid
1858 compiler warning. Add eassert.
1859
dea7f1e5
PE
18602012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1861
24a212eb
PE
1862 Avoid weird behavior with large horizontal scrolls.
1863 Without this change, for example, large hscroll values would
1864 mess up Emacs's display on Fedora 15 x86, presumably due to
1865 overflows in int calculations in the display code.
1866 Also, if buffers had long lines, Emacs would freeze.
1867 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1868 (set_window_hscroll): New function, containing the old guts of
1869 Fset_window_hscroll. Return the clipped value.
1870 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1871 This avoids the need to check against PTRDIFF_MAX.
1872
dea7f1e5
PE
1873 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1874
76046526
DA
18752012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1876
1877 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1878
39adff0d
PE
18792012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1880
63807d47
PE
1881 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1882 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1883 since GCC 4.4.6 issues a bogus warning for them.
1884
39adff0d
PE
1885 Fix bugs in file timestamp newness comparisons.
1886 * fileio.c (Ffile_newer_than_file_p):
1887 * lread.c (Fload): Use full timestamp resolution of files,
1888 not just the 1-second resolution, so that files that are only
1889 slightly newer still count as newer.
1890 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1891 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1892
dbeed9a6
PE
18932012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * fileio.c: Improve handling of file time marker. (Bug#11852)
1896 (special_mtime): New function.
1897 (Finsert_file_contents, Fverify_visited_file_modtime):
1898 Use it to set special mtime values consistently.
1899
636334d6
AS
19002012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1901
1902 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1903 marker for non-existing file. (Bug#11852)
1904
e2017fe2
GM
19052012-07-03 Glenn Morris <rgm@gnu.org>
1906
1907 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1908 and did not make it into globals.h).
1909
404dbd37
TT
19102012-07-03 Tom Tromey <tromey@redhat.com>
1911
1912 * window.c (Fset_window_margins, Fset_window_fringes)
1913 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1914 * textprop.c (Fprevious_property_change): No longer static.
1915 * syntax.c (Fsyntax_table_p): No longer static.
1916 * process.c (Fget_process, Fprocess_datagram_address): No longer
1917 static.
1918 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1919 * keyboard.c (Fcommand_execute): No longer static.
1920 Remove EXFUN.
1921 * insdel.c (Fcombine_after_change_execute): No longer static.
1922 * image.c (Finit_image_library): No longer static.
1923 * fileio.c (Fmake_symbolic_link): No longer static.
1924 * eval.c (Ffetch_bytecode): No longer static.
1925 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1926 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1927 No longer static.
404dbd37
TT
1928 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1929 static.
1930 * dired.c (Ffile_attributes): No longer static.
1931 * composite.c (Fcomposition_get_gstring): No longer static.
1932 * callproc.c (Fgetenv_internal): No longer static.
1933
1934 * ccl.h: Remove EXFUNs.
1935 * buffer.h: Remove EXFUNs.
1936 * dispextern.h: Remove EXFUNs.
1937 * intervals.h: Remove EXFUNs.
1938 * fontset.h: Remove EXFUN.
1939 * font.h: Remove EXFUNs.
1940 * dosfns.c (system_process_attributes): Remove EXFUN.
1941 * keymap.h: Remove EXFUNs.
1942 * lisp.h: Remove EXFUNs.
1943 * w32term.h: Remove EXFUNs.
1944 * window.h: Remove EXFUNs.
1945 * xsettings.h: Remove EXFUN.
1946 * xterm.h: Remove EXFUN.
1947
8e4fd1e1
GM
19482012-07-03 Glenn Morris <rgm@gnu.org>
1949
1950 * lisp.h (Frandom): Make it visible to C.
1951 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1952 buffer for invisible buffers. (Bug#1229)
1953
ca95b3eb
DA
19542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1955
1956 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1957 values which aren't power of 2.
1958 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1959 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1960 accordingly.
1961
7555c33f
SM
19622012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1963
1964 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1965
1966 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1967
d12e8f5a
DA
19682012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1969
1970 * alloc.c (allocate_vector_block): Remove redundant
1971 calls to mallopt if DOUG_LEA_MALLOC is defined.
1972 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1973 avoid calls to mallopt if zero_vector is returned.
1974
296094c3
DA
19752012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1976
1977 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1978 is enabled, avoid dereferencing NULL current_sblock if
1979 running undumped.
1980
36429c89
DA
19812012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1982
1983 Cleanup basic buffer management.
1984 * buffer.h (struct buffer): Change layout to use generic vector
1985 marking code. Fix some comments. Change type of 'clip_changed'
1986 to bitfield. Remove unused #ifndef old.
1987 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1988 (GET_OVERLAYS_AT): Fix indentation.
1989 (for_each_per_buffer_object_at): New macro.
1990 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1991 (Fbuffer_local_variables): Use it.
1992 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1993 * alloc.c (allocate_buffer): Adjust to match new layout of
1994 struct buffer. Fix comment.
1995 (mark_overlay): New function.
1996 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1997 Lisp area of struct buffer.
1998 (mark_object): Use it. Adjust marking of misc objects
1999 and related comments.
2000
3b3e4cac
PE
20012012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2004 wrapper that is not needed because the wrapped code is a no-op (zero
2005 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2006 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2007
cf5c0175
DA
20082012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2009
2010 * alloc.c (mark_buffer): Simplify. Remove prototype.
2011 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2012 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2013 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2014 redundant calls to mark_vectorlike for bool vectors.
2015
ca26824c
GM
20162012-06-30 Glenn Morris <rgm@gnu.org>
2017
2e4c5312
GM
2018 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2019
ca26824c
GM
2020 * epaths.in (PATH_SITELOADSEARCH): New.
2021 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2022 This is rather than relying on --enable-locallisppath elements
2023 having "site-lisp" in their names. (Bug#10208#25, 11658)
2024
0d23c240
EZ
20252012-06-30 Eli Zaretskii <eliz@gnu.org>
2026
c9240d7a
EZ
2027 * w32proc.c (sys_select): Accept and ignore one more argument.
2028
2029 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2030
0d23c240 2031 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2032 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2033
2034 * sysdep.c: Don't include dos.h and dosfns.h.
2035
2036 * process.c (sys_select):
2037 * msdos.c (sys_select): Accept one more argument and ignore it.
2038
2039 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2040 adapt data types and code to that.
2041
2042 * dosfns.c:
2043 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2044 which clashes with the gnulib function of the same name.
2045
af5a5a98
AS
20462012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2047
c5e4379c
AS
2048 * font.c (font_style_to_value, font_style_symbolic)
2049 (font_prop_validate_style): Add type checks for values in
2050 font_style_table.
2051
af5a5a98
AS
2052 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2053 argument.
2054 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2055 uses.
2056
8d38f461
EZ
20572012-06-29 Eli Zaretskii <eliz@gnu.org>
2058
2e5a6631
EZ
2059 * xdisp.c (try_window_id): Undo last change.
2060
8d38f461
EZ
2061 * w32.c (getwd): Adjust commentary about startup_dir.
2062 (init_environment): Always call sys_access, even in non-MSVC
2063 builds. Don't chdir to the directory of the Emacs executable.
2064 This undoes code from 1997 which was justified by the need to
2065 "avoid conflicts when removing and renaming directories". But its
2066 downside was that every relative file name was being interpreted
2067 relative to the directory of the Emacs executable, which can never
2068 be TRT. In particular, it broke sys_access when called with
2069 relative file names.
2070 (sys_access): Map GetLastError to errno.
2071
2af3565e
DA
20722012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2073
2074 * window.h (struct window): Change type of 'fringes_outside_margins'
2075 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2076 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2077 Adjust comment.
2078 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2079 to ptrdiff_t.
2080
c8d3a25c 20812012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2082
c8d3a25c
GM
2083 * gnutls.c (emacs_gnutls_handshake):
2084 Add QUIT to make the loop interruptible.
57570cd3 2085
c8d3a25c 20862012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2087
c8d3a25c
GM
2088 * charset.c (init_charset): Make lack of etc/charsets fatal.
2089
3e984ee8
DA
20902012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2091
2092 * editfns.c (region_limit): Fix type mismatch.
2093
ef884f23
DA
20942012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2095
2096 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2097 undefined. Convert from xassert to eassert.
2098 * nsmenu.m: Convert from xassert to eassert.
2099 * nsterm.m: Likewise.
2100
7d7e0027
SM
21012012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2102
2103 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2104
aa754e6a
PE
21052012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2106
2107 Avoid integer overflow on scroll-left and scroll-right.
2108 * window.c (HSCROLL_MAX): New macro.
2109 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2110 overflow when requested scroll falls outside ptrdiff_t range.
2111
80b00b08
DA
21122012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2113
2114 * window.h (struct window): Change type of 'hscroll',
2115 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2116 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2117 Adjust users accordingly.
2118 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2119 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2120 from EMACS_INT to ptrdiff_t.
2121 (make_window): Omit redundant initialization.
2122
62b2bcf6
JB
21232012-06-28 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2126
45942c7d
DA
21272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2128
2129 * window.h (struct window): Change type of 'use_time' and
2130 'sequence_number' from Lisp_Object to int.
2131 * frame.c (make_frame): Adjust users accordingly.
2132 * print.c (print_object): Likewise.
2133 * window.c (select_window, Fwindow_use_time, make_parent_window)
2134 (make_window): Likewise.
2135
e509cfa6
DA
21362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2139 enabled with --enable-checking=[all,glyphs] configure option.
2140 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2141 adjust comments accordingly.
2142 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2143 undefined, adjust comments accordingly.
2144 * image.c: Likewise.
2145 * scroll.c: Likewise.
2146 * w32fns.c: Likewise.
2147 * w32term.c: Likewise.
2148 * xdisp.c: Likewise.
2149 * xfaces.c: Likewise.
2150 * xfns.c: Likewise.
2151 * xterm.c: Likewise.
2152
a54e2c05
DA
21532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2154
2155 Generalize run-time debugging checks.
2156 * dispextern.h (XASSERTS): Remove.
2157 * fontset.c (xassert): Remove.
2158 Convert from xassert to eassert.
2159 * alloc.c: Convert from xassert to eassert.
2160 * bidi.c: Likewise.
2161 * dispnew.c: Likewise.
2162 * fns.c: Likewise.
2163 * fringe.c: Likewise.
2164 * ftfont.c: Likewise.
2165 * gtkutil.c: Likewise.
2166 * image.c: Likewise.
2167 * keyboard.c: Likewise.
2168 * menu.c: Likewise.
2169 * process.c: Likewise.
2170 * scroll.c: Likewise.
2171 * sound.c: Likewise.
2172 * term.c: Likewise.
2173 * w32console.c: Likewise.
2174 * w32fns.c: Likewise.
2175 * w32term.c: Likewise.
2176 * window.c: Likewise.
2177 * xdisp.c: Likewise.
2178 * xfaces.c: Likewise.
2179 * xfns.c: Likewise.
2180 * xselect.c: Likewise.
2181 * xterm.c: Likewise.
2182
1ec4b7b2
SM
21832012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2184
2185 * fns.c (maybe_resize_hash_table): Output message when growing the
2186 purify-hashtable.
2187
2014308a
DA
21882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2189
2190 * alloc.c (allocate_string_data): Remove dead code.
2191 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2192 avoid GCC warning about unused macro.
2193
246155eb
DA
21942012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2195
2196 * alloc.c (allocate_string): Omit intervals initialization.
2197 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2198 as in make_pure_string and make_pure_c_string.
2199
43184b7b
DA
22002012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2201
d209e2fb 2202 * alloc.c (allocate_string): Fix last change.
43184b7b 2203
3fe6dd74
DA
22042012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2205
d209e2fb 2206 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2207 to memset, add explicit initialization where appropriate.
2208
1ba6038a
GM
22092012-06-27 Glenn Morris <rgm@gnu.org>
2210
2211 * lisp.mk (lisp): Remove paths.elc.
2212
c89926a5
CY
22132012-06-27 Chong Yidong <cyd@gnu.org>
2214
2215 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2216
ed6b3510
JW
22172012-06-26 John Wiegley <johnw@newartisans.com>
2218
1ec4b7b2 2219 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2220 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2221
ed6b3510
JW
2222 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2223 when building with Clang.
2224
8edd4a2b
SM
22252012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2226
2227 * eval.c (Fapply): Allow calling it with a single argument.
2228
f6f62d1b
EZ
22292012-06-26 Eli Zaretskii <eliz@gnu.org>
2230
2231 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2232 _stricmp and _strnicmp.
2233 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2234
62efea5e
DA
22352012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2236
2237 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2238 allocated window.
2239 (allocate_process): Likewise for new process.
8edd4a2b 2240 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2241 (allocate_frame): Likewise.
2242 * frame.c (make_frame): Omit redundant initialization.
2243 * window.c (make_parent_window): Use memset.
2244 (make_window): Omit redundant initialization.
2245 * process.c (make_process): Omit redundant initialization.
2246 * terminal.c (create_terminal): Likewise.
2247
42997f4d
DA
22482012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2249
2250 * term.c (delete_tty): Remove redundant call to memset.
2251
1130ecfc
DA
22522012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2253
2254 * alloc.c: Remove build_string.
2255 * lisp.h: Define build_string as static inline. This provides
2256 a better opportunity to optimize away calls to strlen when the
2257 function is called with compile-time constant argument.
2258 * image.c (imagemagick_error): Convert to build_string.
2259 * w32proc.c (sys_spawnve): Likewise.
2260 * xterm.c (x_term_init): Likewise.
2261
cf38a720
PE
22622012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2263
99027bdd
PE
2264 Use sprintf return value instead of invoking strlen on result.
2265 In the old days this wasn't portable, since some sprintf
2266 implementations returned char *. But they died out years ago and
2267 Emacs already assumes sprintf returns int.
2268 Similarly for float_to_string.
2269 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2270 * ccl.c (ccl_driver):
2271 * character.c (string_escape_byte8):
2272 * data.c (Fnumber_to_string):
2273 * doprnt.c (doprnt):
2274 * print.c (print_object):
2275 * xdisp.c (message_dolog):
2276 * xfns.c (syms_of_xfns):
2277 Use sprintf or float_to_string result to avoid need to call strlen.
2278 * data.c (Fnumber_to_string):
2279 Use make_unibyte_string, since the string must be ASCII.
2280 * lisp.h, print.c (float_to_string): Now returns int length.
2281 * term.c (produce_glyphless_glyph):
2282 Use sprintf result rather than recomputing it.
2283
cf38a720
PE
2284 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2285 * Makefile.in (ALL_CFLAGS):
2286 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2287 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2288
3511c784
DA
22892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2290
0a08eb21 2291 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2292 strcasecmp if available.
2293 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2294
fb7da12e
AS
22952012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2296
2297 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2298 Avoid comma operator.
2299 * menu.c (push_submenu_start, push_submenu_end)
2300 (push_left_right_boundary, push_menu_pane): Likewise.
2301 * msdos.c (dos_rawgetc): Likewise.
2302
afa2ffd8
DA
23032012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2304
2305 * xfns.c (xic_create_fontsetname): Remove redundant calls
2306 to memset.
2307
b3b4476b
PE
23082012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2309
4495ff38
PE
2310 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2311 sprintf already null-terminates its output.
2312
b3b4476b
PE
2313 * xfns.c (x_window): Remove redundant cast.
2314
b00876c9
DA
23152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2316
2317 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2318 `const char *' to `char *' to avoid compiler warning.
2319
d188e26b
PE
23202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2321
885d1d74
PE
2322 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2323 instead of truncating it to 63 (admittedly a generous limit).
2324
d188e26b
PE
2325 * process.c: Fix spelling and caps in comments.
2326
e2f560b1
DN
23272012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2328
e86db54b 2329 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2330 * sysdep.c (setpgrp): Remove definition, not used in this file.
2331
7583a3a1
JB
23322012-06-24 Juanma Barranquero <lekktu@gmail.com>
2333
2334 * makefile.w32-in: Update dependencies.
2335
696056c2
EZ
23362012-06-24 Eli Zaretskii <eliz@gnu.org>
2337
2338 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2339 (SYSTIME_H): Add nt/inc/sys/time.h.
2340
2341 * systime.h [WINDOWSNT]: Include sys/time.h.
2342
2343 * s/ms-w32.h (struct timespec): Definition moved from
2344 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2345
845ca893
PE
23462012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2347
2348 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2349 * buffer.h (buffer_slot_type_mismatch):
2350 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2351 * eval.c (unwind_to_catch):
2352 * image.c (my_png_error, my_error_exit):
2353 * keyboard.c (quit_throw_to_read_char, user_error)
2354 (Fexit_recursive_edit, Fabort_recursive_edit):
2355 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2356 (wrong_type_argument, buffer_overflow, __executable_start)
2357 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2358 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2359 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2360 (fatal):
2361 (child_setup) [!DOS_NT]:
2362 * lread.c (end_of_file_error, invalid_syntax):
2363 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2364 * puresize.h (pure_write_error):
2365 * search.c (matcher_overflow):
2366 * sound.c (sound_perror, alsa_sound_perror):
2367 * sysdep.c, syssignal.h (croak):
2368 * term.c (maybe_fatal, vfatal):
2369 * textprop.c (text_read_only):
2370 * undo.c (user_error):
2371 * unexmacosx.c (unexec_error):
2372 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2373 Use _Noreturn rather than NO_RETURN.
2374 No need for separate decl merely because of _Noreturn.
2375 * sound.c (sound_warning, parse_sound):
2376 Remove unnecessary forward decls.
2377
f1dd8073
PE
23782012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2381 * lisp.h (WAIT_READING_MAX): New macro.
2382 * dispnew.c (Fsleep_for, sit_for):
2383 * keyboard.c (kbd_buffer_get_event):
2384 * process.c (Faccept_process_output):
2385 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2386 This improves on the previous patch, which introduced a bug
2387 when time_t is unsigned and as wide as intmax_t.
2388 See <http://bugs.gnu.org/9000#51>.
2389
b82c1755
EZ
23902012-06-23 Eli Zaretskii <eliz@gnu.org>
2391
2392 * dispnew.c (sit_for, Fsleep_for):
2393 * keyboard.c (kbd_buffer_get_event):
2394 * process.c (Faccept_process_output): Avoid compiler warnings when
2395 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2396
ca300656
JB
23972012-06-23 Juanma Barranquero <lekktu@gmail.com>
2398
049ec95b
JB
2399 * makefile.w32-in: Update dependencies.
2400
ca300656
JB
2401 * w32.c (ltime): Add return type and declare static.
2402 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2403
db7b8d06
PE
24042012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2405
2406 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2407 Privately reported by Herbert J. Skuhra.
2408 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2409 All uses changed.
2410 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2411 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2412
0bd8297f
EZ
24132012-06-23 Eli Zaretskii <eliz@gnu.org>
2414
96512555
EZ
2415 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2416 last argument of make_unibyte_string.
2417
0bd8297f
EZ
2418 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2419 language ID in the event parameters.
2420
2421 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2422 event.code, not the obscure "character set ID".
2423
63def6b6
CY
24242012-06-23 Chong Yidong <cyd@gnu.org>
2425
2426 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2427
e8a02204
EZ
24282012-06-23 Eli Zaretskii <eliz@gnu.org>
2429
388cdec0
EZ
2430 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2431 * w32.c (fdutimens): New function.
2432
2433 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2434
2435 * s/ms-w32.h (pselect): Redirect to sys_select.
2436
2437 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2438
e8a02204
EZ
2439 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2440 in the logic of incrementing and decrementing the value of
2441 use_relocatable_buffers.
2442
d054f3fb
PE
24432012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2446 Privately reported by Herbert J. Skuhra.
2447 [__FreeBSD__]: Remove "*/" typo after "#include".
2448 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2449 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2450 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2451 Don't assume EMACS_TIME and struct timeval are the same type.
2452
d35af63c
PE
24532012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 Support higher-resolution time stamps (Bug#9000).
2456 The time stamps are only nanosecond-resolution at the C level,
2457 since that's the best that any real-world system supports now.
2458 But they are picosecond-resolution at the Lisp level, as that's
2459 easy, and leaves room for future OS improvements.
2460
2461 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2462 (LIBES): Use it.
2463
2464 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2465 Don't get current time unless it's needed.
2466
2467 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2468 now provides it if it's absent.
2469 (start_atimer): Port to higher-res time stamps.
2470 Check for time stamp overflow. Don't get current time more
2471 often than is needed.
2472
2473 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2474 Include systime.h, not time.h.
2475 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2476
2477 * dired.c: Include stat-time.h.
2478 (Ffile-attributes): File times now have higher resolution.
2479
2480 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2481 (struct image): Timestamp now has higher resolution.
2482
2483 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2484 has at least microseconds now. All uses removed.
2485 (update_frame, update_single_window, update_window, update_frame_1)
2486 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2487
2488 * editfns.c (time_overflow): Now extern.
2489 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2490 (float-time, Fformat_time_string, Fcurrent_time_string)
2491 (Fcurrent_time_zone): Accept and generate higher-resolution
2492 time stamps.
2493 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2494 (decode_time_components, lisp_seconds_argument): New functions.
2495 (make_time): Now static.
2496 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2497 Report an error if the time is invalid, rather than having the caller
2498 do that.
2499
2500 * fileio.c: Include <stat-time.h>
2501 (Fcopy_file): Copy higher-resolution time stamps.
2502 Prefer to set the time stamp via a file descriptor if that works.
2503 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2504 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2505 (Fvisited_file_modtime, Fset_visited_file_modtime):
2506 Support higher-resolution time stamps.
2507
2508 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2509
2510 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2511
2512 * image.c (prepare_image_for_display, clear_image_cache)
2513 (lookup_image): Port to higer-resolution time stamps.
2514
2515 * keyboard.c (start_polling, bind_polling_period):
2516 Check for time stamp overflow.
2517 (read_char, kbd_buffer_get_event, timer_start_idle)
2518 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2519 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2520 Port to higher-resolution time stamps. Do not assume time_t is signed.
2521 (decode_timer): New function. Timers are now vectors of length 9,
2522 not 8, to accommodate the picosecond component.
2523 (timer_check_2): Use it.
2524
2525 * nsterm.m (select_timeout, timeval_subtract): Remove.
2526 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2527 as they're a bit more accurate and handle overflow better.
2528 (ns_select): Change prototype to be compatible with pselect.
2529 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2530 * nsterm.h (ns_select): Adjust prototype.
2531
2532 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2533 us-resolution time stamps.
2534 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2535
2536 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2537
2538 * lisp.h (time_overflow): New decl.
2539 (wait_reading_process_output): First arg is now intmax_t, not int,
2540 to accommodate larger waits.
2541
2542 * process.h (struct Lisp_Process.read_output_delay):
2543 Now counts nanoseconds, not microseconds.
2544 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2545 EMACS_HAS_USECS.
2546 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2547 (wait_reading_process_output):
2548 Port to ns-resolution time stamps.
2549 (Faccept_process_output, wait_reading_process_output):
2550 Check for time stamp overflow. Do not assume time_t is signed.
2551 (select_wrapper): Remove; we now use pselect.
2552 (Fprocess_attributes): Now generates ns-resolution time stamps.
2553
2554 * sysdep.c: Include utimens.h. Don't include utime.h
2555 or worry about struct utimbuf; gnulib does that for us now.
2556 (gettimeofday): Remove; gnulib provides a substitute.
2557 (make_timeval): New function.
2558 (set_file_times): Now sets ns-resolution time stamps.
2559 New arg FD; all uses changed.
2560 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2561 (system_process_attributes):
2562 Now returns ns-resolution time stamp. All uses changed.
2563 Check for time stamp overflow.
2564
2565 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2566 provides a substitute now.
2567
2568 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2569 since it guarantees struct timespec.
2570 (EMACS_TIME): Now struct timespec, so that we can support
2571 ns-resolution time stamps.
2572 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2573 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2574 (EMACS_USECS): Remove.
2575 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2576 so multiply the arg by 1000 before storing it.
2577 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2578 New macros.
2579 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2580 Port to ns-resolution time stamps.
2581 (EMACS_TIME_NEG_P): Remove; replaced by....
2582 (EMACS_TIME_SIGN): New macro.
2583 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2584 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2585 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2586 (make_timeval, make_lisp_time, decode_time_components): New decls.
2587 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2588 that it mishandled time_t overflow. You can't compare by subtracting!
2589 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2590 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2591
2592 * term.c: Include <sys/time.h>.
2593 (timeval_to_Time): New function, for proper overflow wraparound.
2594 (term_mouse_position, term_mouse_click): Use it.
2595
2596 * undo.c (record_first_change): Support higher-resolution time stamps
2597 in the undo buffer.
2598 (Fprimitive_undo): Use them when restoring time stamps.
2599
2600 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2601 (w32_get_internal_run_time):
2602 Port to higher-resolution Emacs time stamps.
2603 (ltime): Now accepts single 64-bit integer, as that's more convenient
2604 for callers.
2605
2606 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2607
2608 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2609 for compatibility with pselect. Support ns-resolution time stamps.
2610
2611 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2612
2613 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2614 Check for time stamp overflow, and support ns-resolution time stamps.
2615
2616 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2617 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2618 (timeval_subtract): Remove; no longer needed.
2619 (XTflash, XTring_bell, x_wait_for_event):
2620 Port to ns-resolution time stamps. Don't assume time_t is signed.
2621
b6a92dfe
CY
26222012-06-22 Chong Yidong <cyd@gnu.org>
2623
2624 * xdisp.c (x_consider_frame_title): Revert last change.
2625
d251c37c
EZ
26262012-06-22 Eli Zaretskii <eliz@gnu.org>
2627
2628 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2629 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2630 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2631 staticidx goes up to 1597 out of 1600 = 0x640.)
2632
f10deafb
PE
26332012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2634
2635 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2636 Otherwise, the umask might be mistakenly 0 while handling input signals.
2637
ec6de1e2
SM
26382012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2639
2640 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2641
28be1ada
DA
26422012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2643
2644 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2645 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2646 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2647 access to `contents' member of Lisp_Vector objects with AREF and ASET
2648 where appropriate.
2649
c6bf3022
CY
26502012-06-19 Chong Yidong <cyd@gnu.org>
2651
2652 * frame.c (delete_frame): When selecting a frame on a different
2653 text terminal, do not alter the terminal's top-frame.
2654
2655 * xdisp.c (format_mode_line_unwind_data): Record the target
2656 frame's selected window and its terminal's top-frame.
2657 (unwind_format_mode_line): Restore them.
2658 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2659 Callers changed.
2660 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2661 since tty frames can be explicitly named.
2662 (prepare_menu_bars): Likewise.
2663
2664 * term.c (Ftty_top_frame): New function.
2665
defd4196
PE
26662012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 Port byte-code-meter to modern targets.
2669 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2670 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2671 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2672 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2673 (METER_1, METER_2): Simplify.
2674
1053a871
SM
26752012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2676
2677 * data.c (Fdefalias): Return `symbol' (bug#11686).
2678
b7e8d081
MR
26792012-06-18 Martin Rudalics <rudalics@gmx.at>
2680
2681 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2682 gets killed during executing of this function (Bug#11665).
2683 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2684 (Vkill_buffer_query_functions): In doc-string say that functions
2685 run by this hook should not change the current buffer.
2686
7ea2b339
PE
26872012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2688
2689 Fix recently-introduced process.c problems found by static checking.
2690 * process.c (write_queue_push, write_queue_pop, send_process):
2691 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2692 (write_queue_pop): Fix pointer signedness problem.
2693 (send_process): Remove unused local.
2694
96a313a1
CY
26952012-06-17 Chong Yidong <cyd@gnu.org>
2696
2697 * xdisp.c (redisplay_internal): No need to redisplay terminal
2698 frames that are not on top.
2699
20ca2e94
TN
27002012-06-17 Troels Nielsen <bn.troels@gmail.com>
2701
2702 * process.c (make_process): Initialize write_queue.
2703 (write_queue_push, write_queue_pop): New functions.
2704 (send_process): Use them to maintain correct ordering of process
2705 writes (Bug#10815).
2706
9a900ca9
PE
27072012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2708
310fbfa8
PE
2709 * lisp.h (eassert): Assume C89 or later.
2710 This removes the need for CHECK.
2711 (CHECK): Remove. Its comments about always evaluating its
2712 argument were confusing, as 'eassert' typically does not evaluate
2713 its argument.
2714
27bb1ca4
PE
2715 * coding.c (produce_chars): Use ptrdiff_t, not int.
2716
9a900ca9
PE
2717 * xterm.c (x_draw_underwave): Check for integer overflow.
2718 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2719
41b7f8bc 27202012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2721
2722 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2723 referenced (Bug#11583).
2724
9b0e3eba
AA
27252012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2726
2727 Implement wave-style variant of underlining.
2728 * dispextern.h (face_underline_type): New enum.
2729 (face): Add field for underline type.
2730 * nsterm.m (ns_draw_underwave): New function.
2731 (ns_draw_text_decoration): Use it.
2732 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2733 New functions.
2734 (x_draw_glyph_string): Use them.
2735 * xfaces.c (Qline, Qwave): New Lisp objects.
2736 (check_lface_attrs, merge_face_ref)
1053a871
SM
2737 (Finternal_set_lisp_face_attribute, realize_x_face):
2738 Handle wave-style underline face attributes.
9b0e3eba
AA
2739 * xterm.c (x_draw_underwave): New function.
2740 (x_draw_glyph_string): Use it.
2741
0fb52f11
JB
27422012-06-16 Juanma Barranquero <lekktu@gmail.com>
2743
2744 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2745 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2746 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2747 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2748 ($(BLD)/w32select.$(O)): Update dependencies.
2749
e5560ff7
AS
27502012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2751
2752 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2753 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2754 * character.c (_fetch_multibyte_char_p): Remove.
2755 * alloc.c: Include "character.h" before "buffer.h".
2756 * bidi.c: Likewise.
2757 * buffer.c: Likewise.
2758 * bytecode.c: Likewise.
2759 * callint.c: Likewise.
2760 * callproc.c: Likewise.
2761 * casefiddle.c: Likewise.
2762 * casetab.c: Likewise.
2763 * category.c: Likewise.
2764 * cmds.c: Likewise.
2765 * coding.c: Likewise.
2766 * composite.c: Likewise.
2767 * dired.c: Likewise.
2768 * dispnew.c: Likewise.
2769 * doc.c: Likewise.
2770 * dosfns.c: Likewise.
2771 * editfns.c: Likewise.
2772 * emacs.c: Likewise.
2773 * fileio.c: Likewise.
2774 * filelock.c: Likewise.
2775 * font.c: Likewise.
2776 * fontset.c: Likewise.
2777 * fringe.c: Likewise.
2778 * indent.c: Likewise.
2779 * insdel.c: Likewise.
2780 * intervals.c: Likewise.
2781 * keyboard.c: Likewise.
2782 * keymap.c: Likewise.
2783 * lread.c: Likewise.
2784 * macros.c: Likewise.
2785 * marker.c: Likewise.
2786 * minibuf.c: Likewise.
2787 * nsfns.m: Likewise.
2788 * nsmenu.m: Likewise.
2789 * print.c: Likewise.
2790 * process.c: Likewise.
2791 * regex.c: Likewise.
2792 * region-cache.c: Likewise.
2793 * search.c: Likewise.
2794 * syntax.c: Likewise.
2795 * term.c: Likewise.
2796 * textprop.c: Likewise.
2797 * undo.c: Likewise.
2798 * unexsol.c: Likewise.
2799 * w16select.c: Likewise.
2800 * w32fns.c: Likewise.
2801 * w32menu.c: Likewise.
2802 * window.c: Likewise.
2803 * xdisp.c: Likewise.
2804 * xfns.c: Likewise.
2805 * xmenu.c: Likewise.
2806 * xml.c: Likewise.
2807 * xselect.c: Likewise.
2808
2f07e6af
EZ
28092012-06-16 Eli Zaretskii <eliz@gnu.org>
2810
1053a871
SM
2811 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2812 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2813 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2814 row.
2815 (handle_face_prop): Use chunk-relative overlay string index when
2816 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2817 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2818 the rightmost. (Bug#11720)
2f07e6af 2819
29b83cec
AS
28202012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2821
2822 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2823 (CATEGORY_MEMBER): Enforce 1/0 value.
2824 * category.c (_temp_category_set): Remove.
2825
4c5501e9
EZ
28262012-06-16 Eli Zaretskii <eliz@gnu.org>
2827
2828 * window.c (Fdelete_other_windows_internal)
2829 (Fdelete_window_internal): Don't access frame's mouse highlight
2830 info of the initial frame. (Bug#11677)
2831
2b570124
PE
28322012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2833
e93864f9
PE
2834 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2835 Assume USE_2_TAGS_FOR_INTS.
2836 (xreload): Adjust $tagmask width to match recent lisp.h change.
2837
2b570124
PE
2838 Simplify lisp.h in minor ways that should not affect code.
2839 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2840 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2841 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2842 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2843 (INTTYPEBITS): New macro, for clarity.
2844 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2845 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2846 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2847 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2848 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2849
81755f69
JB
28502012-06-13 Juanma Barranquero <lekktu@gmail.com>
2851
2852 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2853
16192a57
GM
28542012-06-13 Glenn Morris <rgm@gnu.org>
2855
2856 * s/bsd-common.h (BSD4_3):
2857 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2858
646b5f55
AS
28592012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2860
2861 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2862 instead of union.
2863 (XLI, XIL): Define.
1053a871
SM
2864 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2865 Use them.
2866 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2867 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2868 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2869 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2870 * frame.c (delete_frame): Remove outdated comment.
2871 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2872 USE_LISP_UNION_TYPE.
2873 (Fw32_unregister_hot_key): Likewise.
2874 (Fw32_toggle_lock_key): Likewise.
2875 * w32menu.c (add_menu_item): Likewise.
2876 (w32_menu_display_help): Use XIL instead of checking
2877 USE_LISP_UNION_TYPE.
2878 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2879 (init_heap): Likewise.
2880 * w32term.c (w32_read_socket): Update comment.
2881
1d3823c9
GM
28822012-06-13 Glenn Morris <rgm@gnu.org>
2883
c62ff706
GM
2884 * s/usg5-4-common.h, src/s/unixware.h:
2885 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2886
1d3823c9
GM
2887 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2888
bfe3e0a2
PE
28892012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2890
2891 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2892 * alloc.c (make_number) [!defined make_number]:
2893 Remove, as lisp.h always defines this now.
2894 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2895 (roundup_size): Verify that it is a power of 2.
2896 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2897 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2898 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2899 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2900 USE_LSB_TAG now is always defined to be either 0 or 1.
2901 All uses changed.
2902 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2903 code works fine either way, and efficiency is not a concern here,
2904 as the union type is for debugging, not for production.
2905 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2906 Use an inline function on all platforms when using the union type,
2907 since this is simpler and 'static inline' can be used portably
2908 within Emacs now.
2909 (LISP_INITIALLY_ZERO): New macro.
2910 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2911 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2912
45fa9c0f
GM
29132012-06-12 Glenn Morris <rgm@gnu.org>
2914
b4492cba
GM
2915 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2916
2917 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2918
45fa9c0f
GM
2919 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2920 Move BROKEN_SIGIO to configure.
2921
2922 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2923 Move NO_TERMIO to configure.
2924
0e25d334
CY
29252012-06-12 Chong Yidong <cyd@gnu.org>
2926
2927 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2928 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2929 MagickExportImagePixels is undefined.
2930
43682bb6
PE
29312012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2932
2933 * image.c (imagemagick_load_image): Remove unused label.
2934
a9be7d2b
GM
29352012-06-11 Glenn Morris <rgm@gnu.org>
2936
2937 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2938 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2939 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2940 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2941
3017f87f
SM
29422012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2943
2944 * alloc.c (make_byte_code): New function.
2945 (Fmake_byte_code): Use it. Don't purify here.
2946 * lread.c (read1): Use it as well to avoid extra allocation.
2947
1b9b4cf4
CY
29482012-06-11 Chong Yidong <cyd@gnu.org>
2949
2950 * image.c (imagemagick_load_image): Implement transparency.
2951
95988fcf
AS
29522012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2953
2954 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2955 account for preceding backslashes. (Bug#11663)
2956
cd4eb164
CY
29572012-06-09 Chong Yidong <cyd@gnu.org>
2958
2959 * term.c: Support italics in capable terminals (Bug#9652).
2960 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2961 (turn_on_face): Output using TS_enter_italic_mode if available.
2962 Don't handle unused blinking and alt-charset cases.
2963 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2964 and tty_alt_charset_p cases.
2965 (tty_capable_p, init_tty): Support italics.
2966
2967 * termchar.h (struct tty_display_info): Add field for italics.
2968 Remove unused blink field.
2969
2970 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2971 Handle slant.
2972
2973 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2974 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2975 tty_alt_charset_p. Add tty_italic_p.
2976
ff88beb8
MA
29772012-06-09 Michael Albinus <michael.albinus@gmx.de>
2978
2979 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2980 dbus_type_is_basic if available.
2981 (xd_extract_signed, xd_extract_unsigned): Rename from
2982 extract_signed and extract_unsigned, respectively. Adapt callers.
2983
44286096
CY
29842012-06-09 Chong Yidong <cyd@gnu.org>
2985
1682701f
CY
2986 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2987
44286096
CY
2988 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2989 case (Bug#9752).
2990
d86feb17
PE
29912012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2992
2993 * xdisp.c (vmessage): Treat frame message as multibyte.
2994 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2995 would generate the diagnostic "Making \302\247 buffer-local while
2996 let-bound!".
2997
d5c20fe8
EZ
29982012-06-08 Eli Zaretskii <eliz@gnu.org>
2999
3000 * dispnew.c (showing_window_margins_p): Undo last change, which
3001 was done due to an inadvertent commit.
3002 (adjust_frame_glyphs_for_frame_redisplay): Do call
3003 showing_window_margins_p.
3004
513749ee
SM
30052012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3006
3007 * eval.c (Fmake_var_non_special): New primitive.
3008 (syms_of_eval): Defsubr it.
3009 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3010
d4a8f5c1
JB
30112012-06-08 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3014 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3015
8bbbc977
EZ
30162012-06-08 Eli Zaretskii <eliz@gnu.org>
3017
3018 * alloc.c (allocate_vectorlike): Fix last change.
3019
f3372c87
DA
30202012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3021
3022 Block-based vector allocation of small vectors.
3023 * lisp.h (struct vectorlike_header): New field `nbytes',
3024 adjust comment accordingly.
3025 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3026 to denote vector blocks. Adjust users (live_vector_p,
3027 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3028 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3029 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3030 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3031 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3032 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3033 (roundup_size): New constant.
3034 (struct vector_block): New data type.
3035 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3036 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3037 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3038 (sweep_vectors): New functions.
3039 (allocate_vectorlike): Return `zero_vector' as the only vector of
3040 0 items. Allocate new vector from block if vector size is less than
3041 or equal to VBLOCK_BYTES_MAX.
3042 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3043 (init_alloc_once): Add call to init_vectors.
3044
4f18a4ed
SM
30452012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3046
3047 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3048
86f158bc
PE
30492012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 * doprnt.c (doprnt): Truncate multibyte char correctly.
3052 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3053 would mishandle a string argument "Xc" if X was a multibyte
3054 character of length 2: it would truncate after X's first byte
3055 rather than including all of X.
3056
c5cfcbe0
CY
30572012-06-06 Chong Yidong <cyd@gnu.org>
3058
3059 * buffer.c (word_wrap): Doc fix.
3060
c05cf390
PE
30612012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3062
3063 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3064
0c3461de
GM
30652012-06-03 Glenn Morris <rgm@gnu.org>
3066
3067 * xdisp.c (tool-bar-style): Doc fix.
3068
c71232db
UM
30692012-06-03 Ulrich Müller <ulm@gentoo.org>
3070
3071 * Makefile.in (PAXCTL): Define.
3072 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3073 binary via PaX flags if the paxctl utility is available.
3074 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3075 Restore PaX flags to their default. (Bug#11398)
3076
383f7350
CY
30772012-06-03 Chong Yidong <cyd@gnu.org>
3078
3079 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3080 buffer (Bug#11226).
3081
5f2c76c6
CY
30822012-06-03 Chong Yidong <cyd@gnu.org>
3083
3084 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3085 (note_mode_line_or_margin_highlight): If there is no help echo,
3086 use mode-line-default-help-echo. Handle the case where the mouse
3087 position is past the end of the mode line string.
3088
3089 * buffer.c (buffer_local_value_1): New function, split from
3090 Fbuffer_local_value; can return Qunbound.
3091 (Fbuffer_local_value): Use it.
3092 (Vmode_line_format): Docstring tweaks.
3093
773d47f6
PE
30942012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 * sysdep.c (system_process_attributes): Improve comment.
3097
f2d6a3df
SM
30982012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3099
3100 * keyboard.c: Export real-this-command to Elisp.
3101 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3102 and DEFVAR it. Update all users.
3103
63810350
PE
31042012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3105
7bd5c1f4
PE
3106 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3107
63810350
PE
3108 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3109 Convert pctcpu and pctmem to Lisp float properly.
3110 Let the compiler fold better, as 100.0/0x8000 is exact.
3111
a2821611
AS
31122012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3113
3114 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3115 cons_block.
3116
5fceba1d
PE
31172012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3120
c98ff5dd
DA
31212012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3122
3123 For a 'struct window', replace some Lisp_Object fields to
3124 bitfields where appropriate, remove unused fields.
3125 * window.h (struct window): Remove unused 'last_mark_x' and
3126 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3127 change it's type from Lisp_Object to bitfield.
3128 Change type of 'force_start', 'optional_new_start',
3129 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3130 fields from Lisp_Object to bitfield. Adjust users accordingly.
3131
ca34e0be
PE
31322012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3133
3134 Pacify gcc -Wdouble-precision when using Xaw.
3135 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3136 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3137 Use 'float' consistently, rather than 'float' in most places
3138 and 'double' in a couple of places.
3139
efc00ab1 31402012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3141
3142 * xdisp.c (handle_stop): Detect whether we have overlay strings
3143 loaded by testing it->current.overlay_string_index to be
3144 non-negative, instead of checking whether n_overlay_strings is
3145 positive. (Bug#11587)
3146
efc00ab1 31472012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3148
3149 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3150
3151 * doc.c (Fsubstitute_command_keys): Doc fix.
3152
efc00ab1 31532012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3154
3155 * search.c (search_buffer): Remove calls to
3156 r_alloc_inhibit_buffer_relocation, as it is now called by
3157 maybe_unify_char, which was the cause of relocation of buffer text
3158 in bug#11519.
3159
efc00ab1 31602012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3161
3162 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3163 for the duration of call to load_charset, to avoid problems with
3164 callers of maybe_unify_char that access buffer text through C
3165 pointers.
3166
3167 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3168 decrement the inhibition flag, instead of just setting or
3169 resetting it.
3170
ba93a187
PE
31712012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3172
3173 Remove obsolete '#define static' cruft.
3174 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3175 This #undef was "temporary" in 2000; it is no longer needed
3176 now that '#define static' has gone away.
3177 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3178 (gray_bitmap_bits): Remove; no longer needed.
3179 All uses replaced with definiens.
3180 * xterm.c: Include "bitmaps/gray.xbm".
3181
9e4bf381
PE
31822012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3183
3184 Clean up __executable_start, monstartup when --enable-profiling.
3185 The following changes affect the code only when profiling.
3186 * dispnew.c (__executable_start): Rename from safe_bcopy.
3187 Define only on platforms that need it.
3188 * emacs.c: Include <sys/gmon.h> when profiling.
3189 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3190 (__executable_start): Remove decl, since lisp.h does it now.
3191 (safe_bcopy): Remove decl; no longer has that name.
3192 (main): Coalesce #if into single bit of code, for simplicity.
3193 Cast pointers to uintptr_t, since standard libraries want integers
3194 and not pointers.
3195 * lisp.h (__executable_start): New decl.
3196
32d72c2f
GM
31972012-05-31 Glenn Morris <rgm@gnu.org>
3198
3199 * image.c (Fimagemagick_types): Doc fix.
3200
baac5bc7
JM
32012012-05-30 Jim Meyering <meyering@redhat.com>
3202
3203 * callproc.c (Fcall_process_region): Include directory component
3204 in mkstemp error message (Bug#11586).
3205
72cb32cf
PE
32062012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3207
3208 * alloc.c, lisp.h (make_pure_vector): Now static.
3209
61b108cc
SM
32102012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3211
3212 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3213 Move to byte-run.el.
3214 (Fautoload): Do the hash-doc more carefully.
3215 * data.c (Fdefalias): Purify definition, except for keymaps.
3216 (Qdefun): Move from eval.c.
3217 * lisp.h (Qdefun): Remove.
3218 * lread.c (read1): Tiny simplification.
3219
471fe23d
TN
32202012-05-29 Troels Nielsen <bn.troels@gmail.com>
3221
934f3f58 3222 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3223 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3224 Bug#9642, but explicitly check that the buffer the overlay would
3225 be moved to is live and rearrange lines to make sure that errors
3226 will not put the overlay in an inconsistent state.
3227 (Fdelete_overlay): Cosmetics.
3228
85d0efd1
EZ
32292012-05-28 Eli Zaretskii <eliz@gnu.org>
3230
3231 * w32term.c (my_bring_window_to_top): New function.
3232 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3233 could be different from the original one.
3234 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3235 (Bug#11513)
3236
3237 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3238 by calling BringWindowToTop.
3239
3240 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3241 (WM_EMACS_END): Increase by one.
3242
da92a98c
PE
32432012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3246 This avoids undefined behavior that might cause the eassert
3247 to not catch an out-of-range value.
3248
74d1f848
JB
32492012-05-28 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3252 Update dependencies.
3253
9e1a06fc
EZ
32542012-05-27 Eli Zaretskii <eliz@gnu.org>
3255
3256 * bidi.c (bidi_mirror_char): Fix last change.
3257
f3dd7312
AS
32582012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3259
3260 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3261 when referring to sectname field in printf format.
3262
81899c91
PE
32632012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3264
57b81a9f
PE
3265 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3266 Only r_alloc_inhibit_buffer_relocation needed to be added;
3267 the others were already declared.
3268
81899c91
PE
3269 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3270 before checking whether it's out of range. Put the check inside
3271 eassert. See
3272 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3273
33017faf 32742012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3275
3276 * callproc.c (Fcall_process): Restore a line that was accidentally
3277 commented out in the 2011-02-13 change (bug#11547).
3278
33017faf 32792012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3280
3281 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3282 defined on ralloc.c.
3283
3284 * buffer.c [REL_ALLOC]: Remove prototypes of
3285 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3286 they are now on lisp.h.
3287
3288 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3289
3290 * search.c (search_buffer): Use it to inhibit relocation of buffer
3291 text while re_search_2 is doing its job, because re_search_2 is
3292 passed C pointers to buffer text. (Bug#11519)
3293
23415acf
EZ
3294 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3295 Update value to 24.
3296
44e27368
EZ
3297 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3298 state after an additional call to move_it_in_display_line_to, keep
3299 the values of it->max_ascent and it->max_descent found for the
3300 entire line.
3301 (pos_visible_p): Revert the comparison against bottom_y to what it
3302 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3303 (Bug#11464)
3304
c1892f11
PE
33052012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3306
3307 Fix coding-related core dumps with gcc -ftrapv.
3308 The code was computing A - B, where A and B are pointers, and B is
3309 random garbage. This can lead to core dumps on platforms that
3310 have special pointer registers, and it also leads to core dumps on
3311 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3312 A - B only when B is initialized properly.
3313 * coding.c (coding_set_source, coding_set_destination): Return void.
3314 (coding_change_source, coding_change_destinations): New functions,
3315 with the old behaviors of coding_set_source and coding_set_destination.
3316 All callers that need an offset changed to use these new functions.
3317
eb7afdad
GM
33182012-05-26 Glenn Morris <rgm@gnu.org>
3319
3320 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3321
f12fdf02
EZ
33222012-05-26 Eli Zaretskii <eliz@gnu.org>
3323
53a63be6 3324 Extend mouse support on W32 text-mode console.
61b108cc
SM
3325 * xdisp.c (draw_row_with_mouse_face):
3326 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3327
eb3f6f01 3328 * w32console.c: Include window.h.
61b108cc
SM
3329 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3330 New functions.
eb3f6f01
EZ
3331 (initialize_w32_display): Initialize mouse-highlight data.
3332
53a63be6
EZ
3333 * w32inevt.c: Include termchar.h and window.h.
3334 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3335 moves, call note_mouse_highlight. If help_echo changed, call
3336 gen_help_event to produce help-echo message in the echo area.
3337 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3338 highlight info.
3339
4cfd81f6
PE
33402012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * lread.c (read1): Simplify slightly to avoid an overflow warning
3343 with GCC 4.7.0 on x86-64.
3344
4446092a
EZ
33452012-05-26 Eli Zaretskii <eliz@gnu.org>
3346
3347 * bidi.c (bidi_mirror_char): Revert last change: an int is
3348 definitely wide enough here.
3349
42b2a986 33502012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3351
42b2a986 3352 Fix integer width and related bugs (Bug#9874).
eb106a49 3353 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3354 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3355 (string_bytes, check_sblock, allocate_string_data):
3356 (compact_small_strings, Fmake_bool_vector, make_string)
3357 (make_unibyte_string, make_multibyte_string)
3358 (make_string_from_bytes, make_specified_string)
3359 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3360 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3361 (mark_vectorlike):
3362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3363 (allocate_pseudovector):
3364 Use int, not EMACS_INT, where int is wide enough.
3365 (inhibit_garbage_collection, Fgarbage_collect):
3366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3367 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3368 int might not be wide enough.
3369 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3370 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3371 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3372 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3373 (bidi_level_of_next_char, bidi_move_to_visually_next):
3374 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3375 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3376 (Fkill_buffer, Fset_buffer_major_mode)
3377 (advance_to_char_boundary, Fbuffer_swap_text)
3378 (Fset_buffer_multibyte, overlays_at, overlays_in)
3379 (overlay_touches_p, struct sortvec, record_overlay_string)
3380 (overlay_strings, recenter_overlay_lists)
3381 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3382 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3383 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3384 (Foverlay_recenter, last_overlay_modification_hooks_used)
3385 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3387 (validate_region): Omit unnecessary test for b <= e,
3388 since that's guaranteed by the previous test.
d311d28c
PE
3389 (adjust_overlays_for_delete): Avoid pos + length overflow.
3390 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3391 (report_overlay_modification):
3392 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3393 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3394 Omit pointer cast, which isn't needed anyway, and doesn't work
3395 after the EMACS_INT -> ptrdiff_t change.
02481186 3396 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3397 * buffer.h: Adjust decls to match defn changes elsewhere.
3398 (struct buffer_text, struct buffer):
3399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3400 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3401 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3402 not int, to avoid needless 32-bit limit on 64-bit hosts.
3403 (exec_byte_code): Use tighter memory-full test, one that checks
3404 for alloca overflow. Don't compute the address of the object just
3405 before an array, as that's not portable. Use EMACS_INT, not
3406 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3407 * callint.c (Fcall_interactively):
3408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3409 * callproc.c (call_process_kill, Fcall_process):
3410 Don't assume pid_t fits into an Emacs fixnum.
3411 (call_process_cleanup, Fcall_process, child_setup):
3412 Don't assume pid_t fits into int.
3413 (call_process_cleanup, Fcall_process, delete_temp_file)
3414 (Fcall_process_region):
3415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3416 (Fcall_process): Simplify handling of volatile integers.
3417 Use int, not EMACS_INT, where int will do.
3418 * casefiddle.c (casify_object, casify_region, operate_on_word)
3419 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3421 (casify_object): Avoid integer overflow when overallocating buffer.
3422 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3423 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3424 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3425 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3426 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3427 integers are now checked earlier. All uses replaced with XINT.
3428 (ccl_driver):
3429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3430 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3431 (ccl_driver, Fregister_code_conversion_map):
3432 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3433 (resolve_symbol_ccl_program): Check that vector header is in range.
3434 Always copy the vector, so that we can check its contents reliably
3435 now rather than having to recheck each instruction as it's being
3436 executed. Check that vector words fit in 'int'.
3437 (ccl_get_compiled_code, Fregister_ccl_program)
3438 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3439 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3440 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3441 contents are in range.
3442 (Fccl_execute_on_string): Check that status is in range.
3443 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3444 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3445 Accept and return EMACS_INT, not int, because callers can pass values
3446 out of 'int' range.
3447 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3448 (multibyte_chars_in_text, parse_str_as_multibyte)
3449 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3450 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3451 (string_escape_byte8, Fget_byte):
3452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3453 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3454 avoid mishandling large integers.
3455 * character.h: Adjust decls to match defn changes elsewhere.
3456 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3457 (Ffind_charset_region):
3458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3459 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3460 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3461 Don't assume fixnum fits in int.
d311d28c
PE
3462 (load_charset_map_from_vector, Fmap_charset_chars):
3463 Remove now-unnecessary CHECK_NATNUMs.
3464 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3465 Don't rely on undefined behavior with signed left shift overflow.
3466 Don't assume unsigned int fits into fixnum, or that fixnum fits
3467 into unsigned int. Don't require max_code to be a valid fixnum;
3468 that's not true for gb10830 4-byte on a 32-bit host. Allow
3469 invalid_code to be a cons, for the same reason. Require code_offset
3470 to be a character. Avoid int overflow if max_char is close
3471 to INT_MAX.
3472 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3473 this is intended anyway and avoids some undefined behavior.
3474 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3475 INDEX_TO_CODE_POINT, as that's what it expects.
3476 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3477 * charset.h (DECODE_CHAR): Return int, not unsigned;
3478 this is what was intended anyway, and it avoids undefined behavior.
3479 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3480 integer-overflow issues.
3481 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3482 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3483 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3484 * chartab.c (Fmake_char_table, Fset_char_table_range)
3485 (uniprop_get_decoder, uniprop_get_encoder):
3486 Don't assume fixnum fits in int.
3487 * cmds.c (move_point): New function, that does the gist of
3488 Fforward_char and Fbackward_char, but does so while checking
3489 for integer overflow more accurately.
c96e5d6a 3490 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3491 (Fforward_line, Fend_of_line, internal_self_insert)
3492 (internal_self_insert):
3493 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3494 Fix a FIXME, by checking for integer overflow when calculating
3495 target_clm and actual_clm.
3496 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3497 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3498 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3499 (coding_alloc_by_making_gap, alloc_destination)
3500 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3501 (encode_coding_utf_16, detect_coding_emacs_mule)
3502 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3503 (detect_coding_iso_2022, decode_coding_iso_2022)
3504 (encode_invocation_designation, encode_designation_at_bol)
3505 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3506 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3507 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3508 (encode_coding_ccl, encode_coding_raw_text)
3509 (detect_coding_charset, decode_coding_charset)
3510 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3511 (produce_composition, produce_charset, produce_annotation)
3512 (decode_coding, handle_composition_annotation)
3513 (handle_charset_annotation, consume_chars, decode_coding_gap)
3514 (decode_coding_object, encode_coding_object, detect_coding_system)
3515 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3516 (code_convert_region, code_convert_string)
8f50130c
PE
3517 (Fdefine_coding_system_internal)
3518 (coding_set_source, coding_set_destination):
d311d28c
PE
3519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3520 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3521 (Fdefine_coding_system_internal):
3522 Don't assume fixnums fit in int.
3523 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3524 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3525 (Funencodable_char_position, Fcheck_coding_systems_region)
3526 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3528 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3529 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3530 Don't access memory outside of the args array.
d311d28c 3531 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3532 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3533 result of ENCODE_CHAR.
d311d28c
PE
3534 * coding.h: Adjust decls to match defn changes elsewhere.
3535 (struct coding_system):
3536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3537 * composite.c (get_composition_id, find_composition)
3538 (run_composition_function, update_compositions)
3539 (compose_text, composition_gstring_put_cache)
3540 (composition_gstring_p, composition_gstring_width)
3541 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3542 (composition_compute_stop_pos, composition_reseat_it)
3543 (composition_update_it, struct position_record)
3544 (find_automatic_composition, composition_adjust_point)
3545 (Fcomposition_get_gstring, Ffind_composition_internal):
3546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3547 (update_compositions):
3548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3549 * composite.h: Adjust decls to match defn changes elsewhere.
3550 (struct composition):
3551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3552 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3553 Do not attempt to compute the address of the object just before a
3554 buffer; this is not portable.
3555 (Faref, Faset):
3556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3557 (Faset): Use int, not EMACS_INT, where int is wide enough.
3558 (Fstring_to_number): Don't assume fixnums fit in int.
3559 (Frem): Don't assume arg is nonnegative.
3560 * dbusbind.c (xd_append_arg): Check for integers out of range.
3561 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3562 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3563 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3564 (xd_get_connection_references): Return ptrdiff_t, not int.
3565 All uses changed.
3566 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3567 (xd_read_message_1):
3568 Use int, not unsigned, where the dbus API uses int.
3569 (Fdbus_message_internal): Don't overflow mtype.
3570 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3571 * dired.c (directory_files_internal, file_name_completion, scmp)
3572 (file_name_completion_stat):
3573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3574 (file_name_completion): Don't overflow matchcount.
3575 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3576 * dispextern.h: Adjust decls to match defn changes elsewhere.
3577 (struct text_pos, struct glyph, struct bidi_saved_info)
3578 (struct bidi_string_data, struct bidi_it, struct composition_it)
3579 (struct it):
3580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3581 (struct display_pos, struct composition_it, struct it):
3582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3583 * dispnew.c (increment_matrix_positions)
3584 (increment_row_positions, mode_line_string)
3585 (marginal_area_string):
3586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3587 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3588 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3589 (duration_to_sec_usec): New function, to check for overflow better.
3590 (Fsleep_for, sit_for): Use it.
3591 * doc.c (get_doc_string, store_function_docstring):
3592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3593 (get_doc_string, Fsnarf_documentation):
3594 Use int, not EMACS_INT, where int is wide enough.
3595 (get_doc_string):
3596 Use SAFE_ALLOCA, not alloca.
3597 Check for overflow when converting EMACS_INT to off_t.
3598 * doprnt.c (doprnt):
3599 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3600 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3601 Don't assume uid_t fits into fixnum.
3602 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3603 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3604 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3605 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3606 (general_insert_function)
3607 (Finsert_char, make_buffer_string, make_buffer_string_both)
3608 (update_buffer_properties, Fbuffer_substring)
3609 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3610 (Fsubst_char_in_region, check_translation)
3611 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3612 (transpose_markers, Ftranspose_regions):
3613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3614 (clip_to_bounds): Move to lisp.h as an inline function).
3615 (Fconstrain_to_field): Don't assume integers are nonnegative.
3616 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3617 (Fsubst_char_in_region, Fsave_restriction):
3618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3619 (Femacs_pid): Don't assume pid_t fits into fixnum.
3620 (lo_time): Use int, not EMACS_INT, when int suffices.
3621 (lisp_time_argument): Check for usec out of range.
3622 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3623 (Fuser_login_name, Fuser_full_name): Signal an error
3624 if a uid argument is out of range, rather than relying on
3625 undefined behavior.
c8d5c857
PE
3626 (Fformat_time_string): Remove now-unnecessary check.
3627 lisp_time_argument checks for out-of-range usec now.
243e0530 3628 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3629 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3630 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3631 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3632 (init_cmdargs, Fdump_emacs):
3633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3634 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3635 the bottom (typically) 32 bits of the fixnum.
3636 * eval.c (specpdl_size, call_debugger):
3637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3638 (when_entered_debugger, Fbacktrace_debug):
3639 Don't assume fixnum can fit in int.
3640 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3641 the object just before a buffer; this is not portable.
3642 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3643 (grow_specpdl, unbind_to):
3644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3645 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3646 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3647 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3648 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3649 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3651 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3652 (a_write, e_write):
3653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3654 (Fcopy_file, non_regular_nbytes, read_non_regular)
3655 (Finsert_file_contents):
3656 Use int, not EMACS_INT, where int is wide enough.
3657 (READ_BUF_SIZE): Verify that it fits in int.
3658 (Finsert_file_contents): Check that counts are in proper range,
3659 rather than assuming fixnums fit into ptrdiff_t etc.
3660 Don't assume fixnums fit into int.
125b3835 3661 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3662 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3663 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3664 (string_char_to_byte, string_byte_to_char)
3665 (string_make_multibyte, string_to_multibyte)
3666 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3667 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3668 (substring_both, Fdelete, internal_equal, Ffillarray)
3669 (Fclear_string, mapcar1)
3670 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3671 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3672 (larger_vector, make_hash_table, maybe_resize_hash_table)
3673 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3674 (Fmaphash, secure_hash):
3675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3676 (concat): Check for string index and length overflow.
3677 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3678 (Frequire):
3679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3680 (larger_vector): New API (vec, incr_min, size_max) replaces old
3681 one (vec, new_size, init). This catches size overflow.
3682 INIT was removed because it was always Qnil.
3683 All callers changed.
3684 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3685 the upper bound on a hash table index size.
3686 (make_hash_table, maybe_resize_hash_table): Use it.
3687 (secure_hash): Computer start_byte and end_byte only after
3688 they're known to be in ptrdiff_t range.
3689 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3690 (Ffont_get_glyphs, Ffont_at):
3691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3692 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3693 (Flist_fonts, Fopen_font):
3694 Don't assume fixnum can fit in int.
3695 (check_gstring): Don't assume index can fit in int.
3696 (font_match_p): Check that fixnum is a character, not a nonnegative
3697 fixnum, since the later code needs to stuff it into an int.
3698 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3699 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3700 conversion overflow issues.
3701 (Fopen_font): Check for integer out of range.
3702 (Ffont_get_glyphs): Don't assume index can fit in int.
3703 * font.h: Adjust decls to match defn changes elsewhere.
3704 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3705 integer overflow.
3706 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3707 printmax_t, where ptrdiff_t is wide enough.
3708 (Finternal_char_font):
3709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3710 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3711 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3712 (Fset_frame_position, x_set_frame_parameters)
3713 (x_set_line_spacing, x_set_border_width)
3714 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3715 Check that fixnums are in proper range for system types.
3716 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3718 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3719 Use SAFE_ALLOCA_LISP, not alloca.
3720 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3721 intptr_t is wide enough.
3722 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3723 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3724 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3725 Check for fixnum out of range.
3726 * ftfont.c (ftfont_list): Don't assume index fits in int.
3727 Check that fixnums are in proper range for system types.
3728 (ftfont_shape_by_flt):
3729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3730 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3732 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3733 Check that fixnums are in proper range for system types.
3734 * gnutls.h: Adjust decls to match defn changes elsewhere.
3735 * gtkutil.c (xg_dialog_run):
3736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3737 (update_frame_tool_bar):
3738 Check that fixnums are in proper range for system types.
3739 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3740 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3741 * indent.c (last_known_column, last_known_column_point):
3742 (current_column_bol_cache):
3743 (skip_invisible, current_column, check_display_width):
3744 (check_display_width, scan_for_column, current_column_1)
3745 (Findent_to, Fcurrent_indentation, position_indentation)
3746 (indented_beyond_p, Fmove_to_column, compute_motion):
3747 (Fcompute_motion, Fvertical_motion):
3748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3749 (last_known_column_modified): Use EMACS_INT, not int.
3750 (check_display_width):
3751 (Fcompute_motion):
3752 Check that fixnums and floats are in proper range for system types.
3753 (compute_motion): Don't assume index or fixnum fits in int.
3754 (compute_motion, Fcompute_motion):
3755 Use int, not EMACS_INT, when it is wide enough.
3756 (vmotion): Omit local var start_hpos that is always 0; that way
3757 we don't need to worry about overflow in expressions involving it.
3758 * indent.h: Adjust decls to match defn changes elsewhere.
3759 (struct position):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 Use int, not EMACS_INT, where int is wide enough.
3762 Remove unused members ovstring_chars_done and tab_offset;
3763 all uses removed.
3764 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3765 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3766 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3767 (make_gap, copy_text, insert, insert_and_inherit)
3768 (insert_before_markers, insert_before_markers_and_inherit)
3769 (insert_1, count_combining_before, count_combining_after)
3770 (insert_1_both, insert_from_string)
3771 (insert_from_string_before_markers, insert_from_string_1)
3772 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3773 (adjust_after_replace, adjust_after_insert, replace_range)
3774 (replace_range_2, del_range, del_range_1, del_range_byte)
3775 (del_range_both, del_range_2, modify_region)
3776 (prepare_to_modify_buffer, signal_before_change)
3777 (signal_after_change, Fcombine_after_change_execute):
3778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3779 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3780 (balance_an_interval, split_interval_right, split_interval_left)
3781 (find_interval, next_interval, update_interval)
3782 (adjust_intervals_for_insertion, delete_node, delete_interval)
3783 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3784 (static_offset_intervals, offset_intervals)
3785 (merge_interval_right, merge_interval_left, make_new_interval)
3786 (graft_intervals_into_buffer, temp_set_point_both)
3787 (temp_set_point, set_point, adjust_for_invis_intang)
3788 (set_point_both, move_if_not_intangible, get_property_and_range)
3789 (get_local_map, copy_intervals, copy_intervals_to_string)
3790 (compare_string_intervals, set_intervals_multibyte_1):
3791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3792 * intervals.h: Adjust decls to match defn changes elsewhere.
3793 (struct interval):
3794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3795 * keyboard.c (this_command_key_count, this_single_command_key_start)
3796 (before_command_key_count, before_command_echo_length, echo_now)
3797 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3798 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3799 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3800 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3802 (last_non_minibuf_size, last_point_position, echo_truncate)
3803 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3804 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3805 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3806 (stuff_buffered_input):
3807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3808 (last_auto_save, command_loop_1, read_char):
3809 Use EMACS_INT, not int, to avoid integer overflow.
3810 (record_char): Avoid overflow in total_keys computation.
3811 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3812 * keyboard.h: Adjust decls to match defn changes elsewhere.
3813 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3814 (Fkey_description, Fdescribe_vector, Flookup_key):
3815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3816 (click_position): New function, to check that positions are in range.
3817 (Fcurrent_active_maps):
3818 (describe_command):
3819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3820 (Faccessible_keymaps, Fkey_description):
3821 (preferred_sequence_p):
3822 Don't assume fixnum can fit into int.
3823 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3824 Check for integer overflow in size calculations.
3825 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3826 avoid mishandling large integers.
3827 * lisp.h: Adjust decls to match defn changes elsewhere.
3828 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3829 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3830 (struct Lisp_Marker):
3831 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3832 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3833 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3834 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3835 All callers changed.
3836 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3837 Assume the arg has valid form, since it always does.
3838 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3839 unsigned integer system type.
3840 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3841 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3843 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3844 (duration_to_sec_usec): New decl.
3845 * lread.c (read_from_string_index, read_from_string_index_byte)
3846 (read_from_string_limit, readchar, unreadchar, openp)
3847 (read_internal_start, read1, oblookup):
3848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3849 (Fload, readevalloop, Feval_buffer, Feval_region):
3850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3851 (openp): Check for out-of-range argument to 'access'.
3852 (read1): Use int, not EMACS_INT, where int is wide enough.
3853 Don't assume fixnum fits into int.
6efdadfd 3854 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3855 (read_filtered_event): Use duration_to_sec_usec
3856 to do proper overflow checking on durations.
d311d28c
PE
3857 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3858 in size calculation.
3859 (Fexecute_kbd_macro):
3860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3861 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3862 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3863 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3864 (set_marker_both, set_marker_restricted_both, marker_position)
3865 (marker_byte_position, Fbuffer_has_markers_at):
3866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3867 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3868 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3869 It now merely ensures that the menu is large enough, without
3870 necessarily growing it, as this avoids some integer overflow issues.
3871 All callers changed.
3872 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3874 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3875 Use SAFE_ALLOCA_LISP, not alloca.
3876 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3877 to EMACS_INT. Check that fixnums are in proper range for system types.
3878 * minibuf.c (minibuf_prompt_width, string_to_object)
3879 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3880 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3882 (get_minibuffer, read_minibuf_unwind):
3883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3884 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3885 this simplifies overflow checking. All callers changed.
3886 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3887 (Ftest_completion):
3888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3889 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3890 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3891 Check that fixnums are in proper range for system types.
3892 (Fx_create_frame, Fx_show_tip):
3893 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3894 * nsfont.m (ns_findfonts, nsfont_list_family):
3895 Don't assume fixnum fits in long.
3896 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3898 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3899 wide enough.
17fdb222 3900 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3903 (PRINTDECLARE, PRINTPREPARE):
3904 (strout, print_string):
3905 (print, print_preprocess, print_check_string_charset_prop)
3906 (print_object):
3907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3908 (PRINTDECLARE):
3909 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3911 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3912 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3913 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3914 (print_error_message): Use SAFE_ALLOCA, not alloca.
3915 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3916 (print_depth, new_backquote_output, print_number_index):
3917 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3918 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3919 (Fset_process_window_size, Fformat_network_address)
3920 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3921 (sigchld_handler):
d311d28c 3922 Check that fixnums are in proper range for system types.
d44287d4 3923 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3924 Check for process-ids out of pid_t range rather than relying on
3925 undefined behavior.
e4d81efc 3926 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3927 (Fformat_network_address, read_process_output, send_process)
3928 (Fprocess_send_region, status_notify):
3929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3930 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3931 (wait_reading_process_output, read_process_output, exec_sentinel):
3932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3933 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3934 (Faccept_process_output): Use duration_to_sec_usec to do proper
3935 overflow checking on durations.
dde14581
PE
3936 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3937 Don't assume pid_t fits in int.
02481186
PE
3938 * process.h (struct Lisp_Process): Members tick and update_tick
3939 are now of type EMACS_INT, not int.
b62b53e8
PE
3940 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3941 configured --with-wide-int.
d311d28c
PE
3942 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3943 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3944 * search.c (looking_at_1, string_match_1):
3945 (fast_string_match, fast_c_string_match_ignore_case)
3946 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3947 (scan_newline, find_before_next_newline, search_command)
3948 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3949 (set_search_regs, wordify):
3950 (Freplace_match):
3951 (Fmatch_data):
3952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3953 (string_match_1, search_buffer, set_search_regs):
3954 (Fmatch_data):
3955 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3956 (wordify): Check for overflow in size calculation.
3957 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3958 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3959 Check that fixnums are in proper range for system types.
3960 * sound.c (struct sound_device)
3961 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3963 (Fplay_sound_internal):
3964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3965 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3966 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3967 (Fparse_partial_sexp):
3968 Don't assume fixnums can fit in int.
3969 (struct lisp_parse_state, find_start_pos, find_start_value)
3970 (find_start_value_byte, find_start_begv)
3971 (update_syntax_table, char_quoted, dec_bytepos)
3972 (find_defun_start, prev_char_comend_first, back_comment):
3973 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3974 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3976 (Finternal_describe_syntax_value): Check that match_lisp is a
3977 character, not an integer, since the code stuffs it into int.
3978 (scan_words, scan_sexps_forward):
3979 Check that fixnums are in proper range for system types.
3980 (Fforward_word):
3981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3982 (scan_sexps_forward):
3983 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3984 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3985 * syntax.h: Adjust decls to match defn changes elsewhere.
3986 (struct gl_state_s):
3987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3988 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3989 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3990 * sysdep.c (wait_for_termination_1, wait_for_termination)
3991 (interruptible_wait_for_termination, mkdir):
3992 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3993 (emacs_read, emacs_write):
3994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3995 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3996 and double all fit in int.
d311d28c
PE
3997 * term.c (set_tty_color_mode):
3998 Check that fixnums are in proper range for system types.
3999 * termhooks.h (struct input_event):
4000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4001 * textprop.c (validate_interval_range, interval_of)
4002 (Fadd_text_properties, set_text_properties_1)
4003 (Fremove_text_properties, Fremove_list_of_text_properties)
4004 (Ftext_property_any, Ftext_property_not_all)
4005 (copy_text_properties, text_property_list, extend_property_ranges)
4006 (verify_interval_modification):
4007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4008 (Fnext_single_char_property_change)
4009 (Fprevious_single_char_property_change):
4010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4011 (copy_text_properties):
4012 Check for integer overflow in index calculation.
d311d28c
PE
4013 * undo.c (last_boundary_position, record_point, record_insert)
4014 (record_delete, record_marker_adjustment, record_change)
4015 (record_property_change):
4016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4017 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4019 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4020 (Fx_hide_tip, Fx_file_dialog):
4021 * w32menu.c (set_frame_menubar):
4022 Use ptrdiff_t, not int, for consistency with rest of code.
4023 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4024 (select_window, Fdelete_other_windows_internal)
4025 (window_scroll_pixel_based, window_scroll_line_based)
4026 (Frecenter, Fset_window_configuration):
4027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4028 (Fset_window_hscroll, run_window_configuration_change_hook)
4029 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4030 (Fscroll_other_window, Frecenter):
d311d28c
PE
4031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4032 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4033 Don't assume fixnum fits in int.
4034 (Fset_window_scroll_bars):
4035 Check that fixnums are in proper range for system types.
4036 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4037 (string_pos, c_string_pos, number_of_chars, init_iterator)
4038 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4039 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4040 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4041 (face_before_or_after_it_pos, handle_invisible_prop)
4042 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4043 (display_prop_intangible_p, string_buffer_position_lim)
4044 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4045 (get_overlay_strings_1, get_overlay_strings)
4046 (iterate_out_of_display_property, forward_to_next_line_start)
4047 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4048 (get_next_display_element, set_iterator_to_next)
4049 (get_visually_first_element, compute_stop_pos_backwards)
4050 (handle_stop_backwards, next_element_from_buffer)
4051 (move_it_in_display_line_to, move_it_in_display_line)
4052 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4053 (add_to_log, message_dolog, message_log_check_duplicate)
4054 (message2, message2_nolog, message3, message3_nolog
4055 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4056 (current_message_1, truncate_echo_area, truncate_message_1)
4057 (set_message, set_message_1, store_mode_line_noprop)
4058 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4059 (text_outside_line_unchanged_p, check_point_in_composition)
4060 (reconsider_clip_changes)
4061 (redisplay_internal, set_cursor_from_row, try_scrolling)
4062 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4063 (redisplay_window, find_last_unchanged_at_beg_row)
4064 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4065 (trailing_whitespace_p, find_row_edges, display_line)
4066 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4067 (display_mode_element, store_mode_line_string)
4068 (pint2str, pint2hrstr, decode_mode_spec)
4069 (display_count_lines, display_string, draw_glyphs)
4070 (x_produce_glyphs, x_insert_glyphs)
4071 (rows_from_pos_range, mouse_face_from_buffer_pos)
4072 (fast_find_string_pos, mouse_face_from_string_pos)
4073 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4075 (safe_call, init_from_display_pos, handle_fontified_prop)
4076 (handle_single_display_spec, load_overlay_strings)
4077 (with_echo_area_buffer, setup_echo_area_for_printing)
4078 (display_echo_area, echo_area_display)
4079 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4080 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4081 (redisplay_window, dump_glyph_row, display_mode_line)
4082 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4083 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4085 (handle_single_display_spec, build_desired_tool_bar_string)
4086 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4087 (get_specified_cursor_type):
4088 Check that fixnums are in proper range for system types.
4089 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4090 (Flookup_image_map):
4091 Don't assume fixnums fit in int.
4092 (compare_overlay_entries):
4093 Avoid mishandling comparisons due to subtraction overflow.
4094 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4095 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4096 (handle_tool_bar_click):
4097 Use int, not unsigned, since we prefer signed and the signedness
4098 doesn't matter here.
4099 (get_next_display_element, next_element_from_display_vector):
4100 Use int, not EMACS_INT, when int is wide enough.
4101 (start_hourglass): Use duration_to_sec_usec to do proper
4102 overflow checking on durations.
4103 * xfaces.c (Fbitmap_spec_p):
4104 Check that fixnums are in proper range for system types.
4105 (compare_fonts_by_sort_order):
4106 Avoid mishandling comparisons due to subtraction overflow.
4107 (Fx_family_fonts, realize_basic_faces):
4108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4109 (Fx_family_fonts):
4110 Don't assume fixnum fits in int.
4111 Use SAFE_ALLOCA_LISP, not alloca.
4112 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4113 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4114 (face_at_buffer_position, face_for_overlay_string)
4115 (face_at_string_position):
4116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4117 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4118 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4119 (Fx_show_tip):
4120 Check that fixnums are in proper range for system types.
4121 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4122 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4124 (Fx_change_window_property): Don't assume fixnums fit in int.
4125 * xfont.c (xfont_chars_supported):
4126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4127 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4128 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4130 * xml.c (parse_region):
4131 * xrdb.c (magic_file_p):
4132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4133 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4134 (x_get_local_selection, x_reply_selection_request)
4135 (x_handle_selection_request, wait_for_property_change):
4136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4137 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4138 short is wide enough.
4139 (x_send_client_event): Don't assume fixnum fits in int.
4140 * xterm.c (x_x_to_emacs_modifiers):
4141 Don't assume EMACS_INT overflows nicely into int.
4142 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4143 may come from Lisp.
4144 (handle_one_xevent): NATNUMP can eval its arg twice.
4145 (x_connection_closed):
4146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4147 * xterm.h: Adjust decls to match defn changes elsewhere.
4148 (struct scroll_bar): Use struct vectorlike_header
4149 rather than rolling our own approximation.
4150 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4151
c6574eb5
GM
41522012-05-25 Glenn Morris <rgm@gnu.org>
4153
4154 * lisp.mk (lisp): Update for more files being compiled now.
4155
e8d32c7e
SM
41562012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4157
48def666
SM
4158 * lread.c: Remove `read_pure' which makes no difference.
4159 (read_pure): Remove var.
4160 (unreadpure): Remove function.
4161 (readevalloop): Don't call read_list with -1 flag.
4162 (read1, read_vector): Don't test read_pure any more.
4163 (read_list): Simplify.
4164
e8d32c7e
SM
4165 * fileio.c, character.h: Minor style tweaks.
4166
4b2addb7
DA
41672012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4168
4169 * window.h (clip_changed): Remove useless declaration.
4170
584461b2
JB
41712012-05-22 Juanma Barranquero <lekktu@gmail.com>
4172
4173 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4174 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4175
34374650
PE
41762012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4177
4178 Remove src/m/*.
4179 This directory predates autoconf and is no longer needed nowadays.
4180 Move its few remaining bits of functionality to where they're needed.
4181 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4182 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4183 * m/template.h: Remove.
4184 * Makefile.in (M_FILE): Remove. All uses removed.
4185 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4186 * lisp.h (USE_LSB_TAG):
4187 * mem-limits.h (EXCEEDS_LISP_PTR):
4188 Use VAL_MAX, not VALBITS, in #if.
4189 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4190 (EMACS_UINT): Define unconditionally now.
4191 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4192 (BITS_PER_EMACS_INT): New constants, replacing
4193 what used to be in config.h, but not useful in #if.
4194 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4195 define them any more.
4196 (VAL_MAX): New macro.
4197 (VALMASK): Use it.
4198 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4199 BITS_PER_EMACS_INT, in #if.
4200 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4201 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4202 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4203 * s/ms-w32.h (DATA_START):
4204 Move here from removed file m/intel386.h.
4205 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4206 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4207
261cb4bb
PE
42082012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4209
4210 Assume C89 or later.
4211 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4212 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4213 (xrealloc):
4214 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4215 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4216 * textprop.c, tparam.c (NULL): Remove.
4217 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4218 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4219 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4220 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4221 * xterm.c (input_signal_count): Assume volatile works.
4222
ff23cd9f
KB
42232012-05-21 Ken Brown <kbrown@cornell.edu>
4224
4225 * xgselect.c (xg_select): Fix first argument in call to 'select'
4226 (bug#11508).
4227
1b170bc6
KB
42282012-05-20 Ken Brown <kbrown@cornell.edu>
4229
4230 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4231 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4232
b2f4d39f
KB
42332012-05-19 Ken Brown <kbrown@cornell.edu>
4234
4235 * xfns.c (x_in_use): Remove `static' qualifier.
4236 * xterm.h (x_in_use): Declare.
4237 * xgselect.c: Include xterm.h.
4238 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4239 and `display_arg' (bug#9754).
4240
003fdae2
PE
42412012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4242
9232a6d9
PE
4243 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4244
003fdae2
PE
4245 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4246 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4247
784b56e2
EZ
42482012-05-18 Eli Zaretskii <eliz@gnu.org>
4249
4250 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4251
4252 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4253 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4254
4255 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4256 reference to image_cache->refcount.
4257 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4258
a0a79cde
JL
42592012-05-17 Juri Linkov <juri@jurta.org>
4260
4261 * search.c (Fword_search_regexp, Fword_search_backward)
4262 (Fword_search_forward, Fword_search_backward_lax)
4263 (Fword_search_forward_lax): Move functions to isearch.el
4264 (bug#10145, bug#11381).
4265
b0572523
PE
42662012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4267
4268 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4269
9660f5fc
SM
42702012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4271
4272 * lread.c (init_obarray): Declare Qt and Qnil as special.
4273
4374de83
GM
42742012-05-14 Glenn Morris <rgm@gnu.org>
4275
4276 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4277 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4278
dc44c39a
PE
42792012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4280
078c97cb
PE
4281 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4282
dc44c39a
PE
4283 * unexaix.c: Port to more-recent AIX compilers.
4284 (report_error, report_error_1, make_hdr, copy_sym)
4285 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4286 Make arguments const char *, not char *, to avoid violations of C
4287 standard and to fix some AIX warnings reported by Gilles Pion.
4288
e18afed7 42892012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4290
4291 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4292 already have overlays loaded.
4293 (handle_single_display_spec): Before returning without displaying
4294 fringe bitmap, synchronize the bidi iterator with the main display
4295 iterator, by calling iterate_out_of_display_property.
4296 (iterate_out_of_display_property): Detect buffer iteration by
4297 testing that it->string is a Lisp string.
4298 (get_next_display_element): When the current object is exhausted,
4299 and there's something on it->stack, call set_iterator_to_next to
4300 proceed with what's on the stack, instead of returning zero.
4301 (set_iterator_to_next): If called at the end of a Lisp string,
4302 proceed to consider_string_end without incrementing string
4303 position. Don't increment display vector index past the end of
4304 the display vector. (Bug#11417)
c8fb9dc6
EZ
4305 (pos_visible_p): Don't report a position visible when move_it_to
4306 stopped at the last line of window, which happens to be scanned
4307 backwards by the bidi iteration. (Bug#11464)
ac268e67 4308
e18afed7 43092012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4310
4311 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4312 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4313 are on a TTY, and thus unable to display on the fringes.
4314 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4315 so we need to signal to the caller that this is a "replacing"
4316 display spec. This fixes display when the spec is invalid or we
4317 are on a TTY.
4318
e18afed7 43192012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4320
4321 * unexaix.c (make_hdr): Fix typo in prototype.
4322 This bug broke the build on AIX. Problem reported by Gilles Pion.
4323
9d0a235a
MA
43242012-05-14 Michael Albinus <michael.albinus@gmx.de>
4325
4326 * keyboard.c (kbd_buffer_get_event): Read special events also in
4327 batch mode. (Bug#11415)
4328
9e6b06ed
GM
43292012-05-12 Glenn Morris <rgm@gnu.org>
4330
4331 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4332
c1a1d7a3
EZ
43332012-05-12 Eli Zaretskii <eliz@gnu.org>
4334
4335 * lisp.mk (lisp): Add newcomment.elc.
4336
3fe7cdc8
GM
43372012-05-12 Glenn Morris <rgm@gnu.org>
4338
4339 * Makefile.in (MKDIR_P): New, set by configure.
4340 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4341
53f7d2c0
PE
43422012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 Remove unused function hourglass_started.
4345 * dispextern.h (hourglass_started):
4346 * w32fns.c (hourglass_started):
4347 * xdisp.c (hourglass_started): Remove.
4348
75aafb17
JB
43492012-05-10 Juanma Barranquero <lekktu@gmail.com>
4350
4351 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4352 Update dependencies.
4353
12959e8e
PE
43542012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4355
97107e2e
PE
4356 * xgselect.c (xg_select): Put maxfds+1 into a var.
4357 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4358
12959e8e
PE
4359 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4360
836d29b3
DA
43612012-05-10 Dave Abrahams <dave@boostpro.com>
4362
4363 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4364 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4365
5cb67954
MA
43662012-05-09 Michael Albinus <michael.albinus@gmx.de>
4367
4368 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4369 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4370 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4371 Initialize xd_registered_buses.
4372
3478ec45
PE
43732012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4374
b263a6b0
PE
4375 Untag more efficiently if USE_LSB_TAG.
4376 This is based on a proposal by YAMAMOTO Mitsuharu in
4377 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4378 For an admittedly artificial (nth 8000 longlist) benchmark on
4379 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4380 Emacs's overall text size by 1%.
4381 * lisp.h (XUNTAG): New macro.
4382 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4383 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4384 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4385 * eval.c (Fautoload):
4386 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4387 * frame.h (XFRAME): Use XUNTAG.
4388
3478ec45
PE
4389 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4390 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4391 Remove unportable assumptions about print widths of types like
4392 dbus_uint32_t.
4393 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4394 intptr_t when converting between pointer and integer, to avoid GCC
4395 warnings about wrong width.
4396
666b903b 43972012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4398
4399 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4400 stack for each reader_thread, instead of defaulting to 8MB
4401 determined by the linker. This avoids failures in creating
4402 subprocesses on Windows 7, see the discussion in this thread:
4403 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4404
b120cc17
JC
44052012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4406
4407 Fix up display of the *Minibuf-0* buffer in the mini window.
4408 * keyboard.c (read_char): Don't clear the echo area if there's no
4409 message to clear.
4410 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4411 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4412
9a4b36f8
MA
44132012-05-07 Michael Albinus <michael.albinus@gmx.de>
4414
4415 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4416 batch mode.
4417
e5f9458f
CY
44182012-05-06 Chong Yidong <cyd@gnu.org>
4419
4420 * lisp.mk (lisp): Update.
4421
eceeb5fc 44222012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4423
4424 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4425
71873e2b
SM
44262012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4427
4428 * data.c (PUT_ERROR): New macro.
4429 (syms_of_data): Use it. Add new error type `user-error'.
4430 * undo.c (user_error): New function.
4431 (Fprimitive_undo): Use it.
4432 * print.c (print_error_message): Adjust print style for `user-error'.
4433 * keyboard.c (user_error): New function.
4434 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4435
ab0fa4e4
PE
44362012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4437
4438 Do not limit current-time-string to years 1000..9999.
4439 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4440 (Fcurrent_time_string): Support any year that is supported by the
4441 underlying localtime representation. Don't use asctime, as it
4442 has undefined behavior for years outside the range -999..9999.
4443
7ed806a7
PE
44442012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4445
4446 Fix race conditions involving setenv, gmtime, localtime, asctime.
4447 Without this fix, interrupts could mess up code that uses these
4448 nonreentrant functions, since setting TZ invalidates existing
4449 tm_zone or tzname values, and since most of these functions return
4450 pointers to static storage.
4451 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4452 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4453 Grow the critical sections to include not just invoking
4454 localtime/gmtime, but also accessing these functions' results
4455 including their tm_zone values if any, and any related TZ setting.
4456 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4457 so that the struct tm is saved in the critical section.
4458 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4459 motivated by the fact that memory allocation needs to be outside
4460 the critical section.
4461
0c16dfed
DA
44622012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4463
4464 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4465 with RESET_INTERVAL.
4466
4467 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4468 Remove duplicated buffer name initialization.
4469
3f83ace8
JM
44702012-05-02 Jim Meyering <jim@meyering.net>
4471
4472 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4473
c7b8541e
JM
4474 * xfns.c (x_window): Use xstrdup (Bug#11375).
4475
90207a15 44762012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4477
4478 * xdisp.c (pos_visible_p): If already at a newline from the
4479 display string before the 'while' loop, don't walk back the glyphs
4480 from it3.glyph_row. Solves assertion violation when the display
4481 string begins with a newline (egg.el). (Bug#11367)
4482
b593d6a9
AH
44832012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4484
4485 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4486 Move to simple.el.
4487
4737362e
GM
44882012-05-01 Glenn Morris <rgm@gnu.org>
4489
99cf43f9
GM
4490 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4491 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4492 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4493 All were removed before 23.1.
4494
9311dcff
GM
4495 * dispnew.c: Remove HAVE_LIBNCURSES test;
4496 it is always true on relevant platforms.
4497
4d5c6349
GM
4498 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4499 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4500
4737362e
GM
4501 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4502
74dd3a6b
AS
45032012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4504
4505 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4506 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4507 Remove.
4508
13c379ee
PE
45092012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4510
4511 Do not avoid creating empty evaporating overlays (Bug#9642).
4512 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4513 That is, do not delete an evaporating overlay if it becomes
4514 empty after its bounds are adjusted to fit within its buffer.
4515 This fix caused other problems, and I'm reverting it until we get
4516 to the bottom of them.
4517
a8e7d6d7 45182012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4519
4520 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4521
a8e7d6d7 45222012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4523
4524 * xdisp.c (pos_visible_p): If the window start position is beyond
4525 ZV, start the display from buffer beginning. Prevents assertion
4526 violation in init_iterator when the minibuffer window is scrolled
4527 via the scroll bar.
4528
4529 * window.c (window_scroll_pixel_based): Likewise.
4530
a8e7d6d7 45312012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4532
4533 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4534
a8e7d6d7 45352012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4536
4537 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4538 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4539
a8e7d6d7 45402012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4541
b593d6a9
AH
4542 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4543 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4544
1c6900d9
EZ
45452012-04-26 Eli Zaretskii <eliz@gnu.org>
4546
4c3fa1d9
EZ
4547 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4548 display element, check also the underlying string or buffer
4549 character. (Bug#11341)
4550
1c6900d9
EZ
4551 * w32menu.c: Include w32heap.h.
4552 (add_menu_item): If the call to AppendMenuW (via
4553 unicode_append_menu) fails, disable Unicode menus only if we are
4554 running on Windows 9X/Me.
4555
42bf8205
AS
45562012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4557
4558 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4559 (xgetint): Add missing shift for LSB tags.
4560
b1bac16e
MR
45612012-04-24 Martin Rudalics <rudalics@gmx.at>
4562
4563 * keyboard.c (read_char): Don't wipe echo area for select window
4564 events: These might get delayed via `mouse-autoselect-window'
4565 (Bug#11304).
4566
d69621cc
JB
45672012-04-24 Juanma Barranquero <lekktu@gmail.com>
4568
4569 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4570 manipulation of :loaded-from data.
4571
02fd101b
JB
45722012-04-23 Juanma Barranquero <lekktu@gmail.com>
4573
4574 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4575 now a cons (bug#11311).
4576
888bec30
PE
45772012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4578
89a438bd
PE
4579 Do not create empty overlays with the evaporate property (Bug#9642).
4580 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4581 if it becomes empty after its bounds are adjusted to fit within
4582 its buffer. Without this fix, in a nonempty buffer (let ((o
4583 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4584 yields an empty overlay that has the evaporate property, which is
4585 not supposed to happen.
4586
1068fe4d
PE
4587 Fix minor GTK3 problems found by static checking.
4588 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4589 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4590 (struct _EmacsFixedClass, emacs_fixed_get_type):
4591 Move decls here from emacsgtkfixed.h, since they needn't be public.
4592 (emacs_fixed_get_type): Now static.
4593 (emacs_fixed_class_init): Omit unused local.
4594 (emacs_fixed_child_type): Remove; unused.
4595 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4596 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4597 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4598 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4599 (EMACS_FIXED_GET_CLASS): Remove; unused.
4600 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4601
888bec30
PE
4602 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4603 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4604
de85e130
PE
46052012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4606
d0baac98 4607 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4608 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4609 (__malloc_size_t, __malloc_ptrdiff_t):
4610 Remove. All uses removed, replaced by the definiens if needed,
4611 since we can assume C89 or better now.
4612 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4613 (protect_malloc_state, align, get_contiguous_space)
4614 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4615 (malloc_atfork_handler_child, malloc_enable_thread)
4616 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4617 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4618 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4619 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4620 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4621 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4622 Define using prototypes, not old style.
4623 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4624 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4625 (align): Don't assume that signed integer overflow wraps around.
4626 Omit unused local var.
4627 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4628 (_free_internal_nolock, memalign, mallochook, reallochook):
4629 Omit no-longer-needed casts.
4630 (valloc): Use getpagesize, not __getpagesize.
4631 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4632 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4633
de85e130
PE
4634 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4635
dcbf5805
MA
46362012-04-22 Michael Albinus <michael.albinus@gmx.de>
4637
4638 Move functions from C to Lisp. Make non-blocking method calls
4639 the default. Implement further D-Bus standard interfaces.
4640
4641 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4642 (QCdbus_request_name_allow_replacement)
4643 (QCdbus_request_name_replace_existing)
4644 (QCdbus_request_name_do_not_queue)
4645 (QCdbus_request_name_reply_primary_owner)
4646 (QCdbus_request_name_reply_in_queue)
4647 (QCdbus_request_name_reply_exists)
4648 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4649 (QCdbus_registered_serial, QCdbus_registered_method)
4650 (QCdbus_registered_signal): New Lisp objects.
4651 (XD_DEBUG_MESSAGE): Use sizeof.
4652 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4653 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4654 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4655 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4656 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4657 (xd_signature, xd_append_arg): Allow float for integer types.
4658 (xd_get_connection_references): New function.
b593d6a9
AH
4659 (xd_get_connection_address): Rename from xd_initialize.
4660 Return cached address.
dcbf5805
MA
4661 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4662 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4663 level.
4664 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4665 Return number of refcounts.
dcbf5805
MA
4666 (Fdbus_get_unique_name): Make stronger parameter check.
4667 (Fdbus_message_internal): New defun.
4668 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4669 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4670 (Fdbus_send_signal, Fdbus_register_service)
4671 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4672 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4673 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4674 (Vdbus_compiled_version, Vdbus_runtime_version)
4675 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4676 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4677 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4678 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4679 Adapt docstring.
dcbf5805 4680
52828e02
PE
46812012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4682
da05bc4c
PE
4683 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4684 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4685 Do not assume ptrdiff_t is the same width as 'int'.
4686
52828e02
PE
4687 * alloc.c: Handle unusual debugging option combinations.
4688 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4689 since the two debugging options are incompatible.
4690 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4691 is defined.
4692 (mem_init, mem_insert, mem_insert_fixup):
4693 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4694 (NEED_MEM_INSERT): Remove; no longer needed.
4695
f01769f9
LL
46962012-04-22 Leo Liu <sdl.web@gmail.com>
4697
4698 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4699
5790543d
PE
47002012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4701
4702 * sysdep.c [__FreeBSD__]: Minor cleanups.
4703 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4704 Use Emacs indenting style more consistently. Avoid some casts.
4705 Use 'double' consistently rather than mixing 'float' and 'double'.
4706
b91b7e4d
EW
47072012-04-21 Eduard Wiebe <usenet@pusto.de>
4708
b593d6a9
AH
4709 * sysdep.c (list_system_processes, system_process_attributes):
4710 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4711
6114eb15
AS
47122012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4713
4714 * lisp.mk (lisp): Update.
4715
2f38dff7
PE
47162012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4717
4718 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4719 It is never used otherwise.
4720
4ae29f89
SM
47212012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4722
4723 * print.c (print_preprocess): Only check print_depth if print-circle
4724 is nil.
4725 (print_object): Check for cycles even when print-circle is nil and
4726 print-gensym is t, but only check print_depth if print-circle is nil.
4727
f30d612a
CY
47282012-04-20 Chong Yidong <cyd@gnu.org>
4729
4730 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4731 set the status to "failed" and ensure that sentinel is run.
4732
c07a4c0b 47332012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4734
4735 * process.c (Fset_process_inherit_coding_system_flag)
4736 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4737 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4738
c07a4c0b 47392012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4740
4741 * xdisp.c (string_buffer_position_lim): Limit starting position to
4742 BEGV.
4743 (set_cursor_from_row): If called for a mode-line or header-line
4744 row, return zero immediately.
4745 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4746 farther than the first row after the header line, if any.
4747 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4748 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4749
c07a4c0b 47502012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4751
4ae29f89
SM
4752 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4753 (bug#11238).
ad3a2b41 4754
c07a4c0b 47552012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47562012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4757
4758 configure: new option --enable-gcc-warnings (Bug#11207)
4759 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4760 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4761 (ALL_CFLAGS): Use new macros rather than old.
4762 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4763 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4764 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4765 -Wunused-result, -Wunused-variable. This should go away once
4766 the Emacs and Gnulib regex code is merged.
4767 (xmalloc, xrealloc): Now static.
4768
aba027e8
PE
47692012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 * dired.c (Fsystem_groups): Remove unused local.
4772
e5a36063
GM
47732012-04-17 Glenn Morris <rgm@gnu.org>
4774
4775 * dired.c (Fsystem_users): Doc fix.
4776
316411f0
DA
47772012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4778
4779 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4780 (syms_of_dired): Add them.
4781
9426aba4
PE
47822012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4783
b62a57be
PE
4784 Fix minor alloc.c problems found by static checking.
4785 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4786 New extern decls, to avoid calling undeclared functions.
4787 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4788 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4789 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4790 (NEED_MEM_INSERT): New macro.
4791 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4792 Remove one incorrect comment and fix another.
b62a57be 4793
3539f31f
PE
4794 Fix minor ralloc.c problems found by static checking.
4795 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4796 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4797 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4798 (r_alloc_sbrk): Now static.
4799
a041960a
PE
4800 Improve ralloc.c interface checking.
4801 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4802 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4803 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4804 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4805 [REL_ALLOC]: ... to here, to check interface.
4806 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4807 Remove decls. This fixes an "It stinks!".
4808
9426aba4
PE
4809 * alloc.c (which_symbols): Fix alignment issue / type clash.
4810
d55c12ed
AS
48112012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4812
4813 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4814 (struct Lisp_Misc_Any): Likewise.
4815 (struct Lisp_Free): Likewise.
4816 * alloc.c (union aligned_Lisp_Symbol): Define.
4817 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4818 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4819 (union aligned_Lisp_Misc): Define.
4820 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4821 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4822 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4823
b948ce8b
PE
48242012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4825
4826 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4827 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4828 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4829 * s/netbsd.h, s/sol2-6.h:
4830 Remove definition of GC_MARK_STACK, since the default now works.
4831 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4832 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4833 no longer the default.
4834 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4835
35dc09a1 48362012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4837
35dc09a1
GM
4838 * lread.c (lisp_file_lexically_bound_p):
4839 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4840
35dc09a1
GM
48412012-04-14 Eli Zaretskii <eliz@gnu.org>
4842
4843 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4844 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4845
48462012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4847
4848 * nsterm.m (constrainFrameRect): Always constrain when there is only
4849 one screen (Bug#10962).
4850
bcd86815
KB
48512012-04-13 Ken Brown <kbrown@cornell.edu>
4852
4853 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4854
c25df26e
RT
48552012-04-13 Reuben Thomas <rrt@sc3d.org>
4856
4857 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4858
0fc59f1e
DC
48592012-04-11 Daniel Colascione <dancol@dancol.org>
4860
4861 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4862 against is gone. It's better to use vfork now so that when Cygwin
4863 gains a new, working vfork, we use it automatically (bug#10398).
4864
de8c03dc
SM
48652012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4866
4867 * window.c (save_window_save): Obey window-point-insertion-type.
4868
2f097256
GM
48692012-04-11 Glenn Morris <rgm@gnu.org>
4870
4871 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4872
453b951e
SM
48732012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4874
4875 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4876
75f1671a 48772012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4878
4879 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4880 (force_quit_count): New var.
4881 (handle_interrupt): Use it.
4882
2a8ce227
JB
48832012-04-10 Juanma Barranquero <lekktu@gmail.com>
4884
4885 * w32.c (w32_delayed_load): Record the full path of the library
4886 being loaded (bug#10424).
4887
935396c0
GM
48882012-04-09 Glenn Morris <rgm@gnu.org>
4889
05920a43
GM
4890 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4891 not just in the obarray, before snarfing them. (Bug#11036)
4892
935396c0
GM
4893 * Makefile.in ($(leimdir)/leim-list.el):
4894 Pass EMACS rather than BUILT_EMACS.
4895
a18ecafa
TZ
48962012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4897
4898 * process.c (make_process):
4899 * process.h: Add integer `gnutls_handshakes_tried' member to
4900 process struct.
4901
6bbef4e5
JC
4902 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4903 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4904
4905 * gnutls.c (gnutls_log_function2i): Convenience log function.
4906 (emacs_gnutls_read): Use new log functions,
4907 `gnutls_handshakes_tried' process member, and
4908 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4909 attempts per process (connection).
4910
b4d3bc10
CY
49112012-04-09 Chong Yidong <cyd@gnu.org>
4912
4913 * eval.c (Fuser_variable_p, user_variable_p_eh)
4914 (lisp_indirect_variable): Functions deleted.
4915 (Fdefvar): Caller changed.
4916
4917 * callint.c (Finteractive, Fcall_interactively):
4918 * minibuf.c (Fread_variable): Callers changed.
4919
70f4d973
EZ
49202012-04-09 Eli Zaretskii <eliz@gnu.org>
4921
4922 * xdisp.c (set_cursor_from_row): If the display string appears in
4923 the buffer at position that is closer to point than the position
4924 after the display string, display the cursor on the first glyph of
4925 the display string. Fixes cursor display when a 'display' text
4926 property immediately follows invisible text. (Bug#11094)
4927
cb3c2e3e
PE
49282012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4929
4930 composite.c: use 'double' consistently
4931 * composite.c (get_composition_id): Use 'double' consistently
4932 instead of converting 'float' to 'double' and vice versa; this is
4933 easier to understand and avoids a GCC warning.
4934
fd06db5d
GM
49352012-04-09 Glenn Morris <rgm@gnu.org>
4936
50fe702a
GM
4937 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4938 preparation for dumping it with emacs. (Bug#4789)
4939 (leimdir): New variable.
4940 ($(leimdir)/leim-list.el): New rule.
4941 (emacs$(EXEEXT)): Depend on leim-list.el.
4942
fd06db5d
GM
4943 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4944 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4945 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4946
55c131ee
AS
49472012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4948
4949 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4950 proper alignment.
4951
9209588f
JB
49522012-04-07 Juanma Barranquero <lekktu@gmail.com>
4953
4954 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4955 Remove unused local variable.
4956
e3fb2efb
PE
49572012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4960 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4961 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4962 objects, as mark_maybe_pointer will catch them otherwise.
4963 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4964 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4965
b5385551
PE
49662012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 Fix typo that broke non-Windows builds.
4969 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4970
9078ead6
EZ
49712012-04-07 Eli Zaretskii <eliz@gnu.org>
4972
4973 Support building on MS-Windows with libxml2.
4974
4975 * makefile.w32-in (OBJ2): Add xml.$(O).
4976 (GLOBAL_SOURCES): Add xml.c.
4977 ($(BLD)/xml.$(O)): New dependency list.
4978
4979 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4980 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4981 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4982 [!WINDOWSNT]: New macros.
4983 (init_libxml2_functions, libxml2_loaded_p): New functions.
4984 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4985 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4986 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4987 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4988 linked in).
6bbef4e5
JC
4989 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4990 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4991 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4992
4993 * emacs.c: Don't include libxml/parser.h.
4994 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4995 xmlCleanupParser directly.
4996
4997 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4998
3811fdf3
EZ
49992012-04-07 Eli Zaretskii <eliz@gnu.org>
5000
5001 * indent.c (Fvertical_motion): If there is a display string at
5002 point, use it.vpos to compute how many lines to backtrack after
5003 move_it_to point. (Bug#11133)
5004
2f8e16b2
EZ
50052012-04-06 Eli Zaretskii <eliz@gnu.org>
5006
5007 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5008 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5009 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5010 macros related to unification of CJK characters. For the details,
5011 see the discussion following the message here:
5012 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5013
3d439cd1
CY
50142012-04-04 Chong Yidong <cyd@gnu.org>
5015
5016 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5017
8bc53d00
EZ
50182012-04-01 Eli Zaretskii <eliz@gnu.org>
5019
5020 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5021 instead of alloca. (Bug#11138)
5022
3b0512a3
AS
50232012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5024
5025 * w32menu.c (is_simple_dialog): Properly check lisp types.
5026 (Bug#11141)
5027
8427ddd2
EZ
50282012-03-31 Eli Zaretskii <eliz@gnu.org>
5029
979022ef
EZ
5030 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5031 position we get to after a call to move_it_to fails the
5032 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5033 only if we wind up in a string from display property. (Bug#11063)
5034
a6b1c7cc
EZ
5035 * window.c (Fdelete_other_windows_internal): Invalidate the row
5036 and column information about mouse highlight, so that redisplay
5037 restores it after reallocating the glyph matrices. (Bug#7464)
5038
8427ddd2
EZ
5039 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5040 string comes from a `display' text property, use the buffer
5041 position of that property as if we actually saw that position in
5042 the row's glyphs.
697ba24b
EZ
5043 (move_it_by_lines): Remove the assertion that
5044 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5045 violated when there's a before-string at the beginning of a line.
5046 (Bug#11063)
8427ddd2 5047
65a0a738
EZ
50482012-03-30 Eli Zaretskii <eliz@gnu.org>
5049
5050 * xdisp.c (append_space_for_newline): If the default face was
5051 remapped, use the remapped face for the appended newline.
5052 (extend_face_to_end_of_line): Use the remapped default face for
5053 extending the face to the end of the line.
5054 (display_line): Call extend_face_to_end_of_line when the default
5055 face was remapped. (Bug#11068)
5056
581355cc
EZ
50572012-03-29 Eli Zaretskii <eliz@gnu.org>
5058
5059 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5060
e8fc049f
SM
50612012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5062
5063 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5064
4fb9a543
GM
50652012-03-27 Glenn Morris <rgm@gnu.org>
5066
5067 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5068 Doc fixes.
5069
679910f1
KH
50702012-03-26 Kenichi Handa <handa@m17n.org>
5071
5072 * dispextern.h (struct glyph): Fix previous change. Change the
5073 bit length of glyphless.ch to 25 (Bug#11082).
5074
90d49b7f
CY
50752012-03-26 Chong Yidong <cyd@gnu.org>
5076
5077 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5078 (command_loop_1): Use it; inhibit selection update for
5079 handle-select-window too (Bug#8996).
5080
f514f6f0
FP
50812012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5082
e8fc049f 5083 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5084
bf43fa51
KH
50852012-03-25 Kenichi Handa <handa@m17n.org>
5086
5087 * dispextern.h (struct glyph): Change the bit length of
5088 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5089
8a0c01dd
EZ
50902012-03-24 Eli Zaretskii <eliz@gnu.org>
5091
5092 * s/ms-w32.h (tzname): Include time.h before redirecting to
5093 _tzname. Fixes the MSVC build. (Bug#9960)
5094
7d1c3a76
AS
50952012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5096
8ed79523
AS
5097 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5098 characters.
5099
7d1c3a76
AS
5100 * xterm.c (XTread_socket): Only modify handling_signal if
5101 !SYNC_INPUT. (Bug#11080)
5102
e99a9b8b
EZ
51032012-03-23 Eli Zaretskii <eliz@gnu.org>
5104
5105 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5106 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5107 when fetching a multibyte character consumes more bytes than
5108 CHAR_BYTES returns, due to unification of CJK characters in
5109 string_char. (Bug#11073)
5110
5063c0e1
TN
51112012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5112
5113 * process.c (wait_reading_process_output): Handle pty disconnect
5114 by refraining from sending oneself a SIGCHLD (bug#10933).
5115
9f851fbd
CY
51162012-03-22 Chong Yidong <cyd@gnu.org>
5117
5118 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5119
5063c0e1 5120 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5121 Mark string as coming from a prefix property.
5122 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5123 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5124
fb5b8aca
CY
51252012-03-21 Chong Yidong <cyd@gnu.org>
5126
5127 * xfaces.c (Vface_remapping_alist): Doc fix.
5128
62356a1b
EZ
51292012-03-20 Eli Zaretskii <eliz@gnu.org>
5130
5131 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5132 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5133 Doc fixes.
62356a1b 5134
025de85b
CY
51352012-03-20 Chong Yidong <cyd@gnu.org>
5136
5137 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5138 to reflect default non-nil value of redisplay-dont-pause.
5139
4827f94e
KH
51402012-03-19 Kenichi Handa <handa@m17n.org>
5141
5142 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5143 it fit in a valid range (Bug#11003).
5144
e50a24a2
EZ
51452012-03-18 Eli Zaretskii <eliz@gnu.org>
5146
5147 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5148 that is not from display property, accept the row as a "cursor
5149 row" if one of the string's character has a non-nil `cursor'
5150 property. Fixes cursor positioning when there are newlines in
5151 overlay strings, e.g. in icomplete.el. (Bug#11035)
5152
9af5ed87
PE
51532012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5154
5155 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5156
d1f55f16
CY
51572012-03-12 Chong Yidong <cyd@gnu.org>
5158
5159 * eval.c (inhibit_lisp_code): Rename from
5160 inhibit_window_configuration_change_hook; move from window.c.
5161
5162 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5163 * window.c (run_window_configuration_change_hook)
5164 (syms_of_window): Callers changed.
5165
66c5eebd
CY
51662012-03-11 Chong Yidong <cyd@gnu.org>
5167
413df973
CY
5168 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5169
66c5eebd
CY
5170 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5171
1de11f56
CY
51722012-03-10 Chong Yidong <cyd@gnu.org>
5173
5174 * frame.c (other_visible_frames): Don't assume the selected frame
5175 is visible (Bug#10955).
5176
cae07000
SM
51772012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5178
5179 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5180
89c94350
JD
51812012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5182
5183 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5184 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5185 zero (Bug#10954).
5186
999dd333
GM
51872012-03-03 Glenn Morris <rgm@gnu.org>
5188
01a6dcc8 5189 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5190
de0100f2
EZ
51912012-03-02 Eli Zaretskii <eliz@gnu.org>
5192
5193 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5194 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5195 (redisplay_window, next_element_from_string): Fix typos in
5196 comments.
3e441275
EZ
5197 (redisplay_window): Pass to move_it_vertically the margin in
5198 pixels, not in screen lines.
de0100f2 5199
96a72ee9
GM
52002012-03-02 Glenn Morris <rgm@gnu.org>
5201
5202 * buffer.c (buffer-list-update-hook): Doc fix.
5203
312508d7
EZ
52042012-02-29 Eli Zaretskii <eliz@gnu.org>
5205
5206 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5207 push_it before setting up the iterator for the first overlay
5208 string, even if we have an empty string loaded.
5209 (next_overlay_string): If there's an empty string on the iterator
5210 stack, pop the stack. (Bug#10903)
5211
27f3c637
PE
52122012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5213
5214 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5215 Suggested by Stefan Monnier in
5216 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5217 * alloc.c (widen_to_Lisp_Object): New static function.
5218 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5219 and widening them to Lisp_Objects. This would work even if
5220 USE_LSB_TAG is defined and wide integers are used, which might
5221 happen in a future version of Emacs.
5222
3c9dfce6
CY
52232012-02-25 Chong Yidong <cyd@gnu.org>
5224
fa74b241
CY
5225 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5226 Doc fix.
5227
3c9dfce6
CY
5228 * xselect.c (Fx_selection_exists_p): Doc fix.
5229 (x_clipboard_manager_save_all): Print an informative message
5230 before saving to clipboard manager.
5231
9486df08
CY
52322012-02-24 Chong Yidong <cyd@gnu.org>
5233
5234 * keyboard.c (process_special_events): Handle all X selection
5235 requests in kbd_buffer, not just the next one (Bug#8869).
5236
f01d3321
CY
52372012-02-23 Chong Yidong <cyd@gnu.org>
5238
5239 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5240 call when setting menu-bar-lines and tool-bar-lines parameters.
5241 (unwind_create_frame_1): New helper function.
5242
5243 * window.c (inhibit_window_configuration_change_hook): New var.
5244 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5245 (syms_of_window): Initialize it.
f01d3321 5246
86b847b6
CY
52472012-02-22 Chong Yidong <cyd@gnu.org>
5248
5249 * xterm.c (x_draw_image_relief): Add missing type check for
5250 Vtool_bar_button_margin (Bug#10743).
5251
a59225b1
CY
52522012-02-21 Chong Yidong <cyd@gnu.org>
5253
5254 * fileio.c (Vfile_name_handler_alist): Doc fix.
5255
5256 * buffer.c (Fget_file_buffer): Protect against invalid file
5257 handler return value.
5258
310f5bd4
PE
52592012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5260
cb3a28cc
PE
5261 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5262 when computing $valmask.
5263
310f5bd4
PE
5264 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5265 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5266 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5267 It's useless in that case, and it can cause problems on hosts
5268 that allocate halves of EMACS_INT values separately.
5269 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5270 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5271 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5272 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5273 it avoids undefined behavior on hosts where shifting right by more
5274 than the word width has undefined behavior.
5275
2375c96a
CY
52762012-02-19 Chong Yidong <cyd@gnu.org>
5277
5278 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5279 (Funhandled_file_name_directory, Ffile_name_as_directory)
5280 (Fdirectory_file_name, Fexpand_file_name)
5281 (Fsubstitute_in_file_name): Protect against invalid file handler
5282 return values (Bug#10845).
5283
3eb49e71
EZ
52842012-02-18 Eli Zaretskii <eliz@gnu.org>
5285
5286 * .gdbinit (pitx): Fix incorrect references to fields of the
5287 iterator stack.
5288
7b926f3f
CY
52892012-02-17 Chong Yidong <cyd@gnu.org>
5290
5291 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5292
11273115
PE
52932012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5294
5295 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5296 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5297
c3a70e2b
CY
52982012-02-15 Chong Yidong <cyd@gnu.org>
5299
5300 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5301 marked as special. Also, starting docstrings with * is obsolete.
5302
0ca43699
AS
53032012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5304
5305 * gnutls.c (emacs_gnutls_write): Fix last change.
5306
2e8f3c56
LI
53072012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5308
5309 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5310 send_process.
5311
af70074f
SM
53122012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5313
5314 * keymap.c (Fsingle_key_description): Handle char ranges.
5315
95986d52
CY
53162012-02-12 Chong Yidong <cyd@gnu.org>
5317
afd83bd1
CY
5318 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5319 as that creates a dangerous corner case.
5320
95986d52
CY
5321 * window.c (Fdelete_window_internal): Invalidate the mouse
5322 highlight (Bug#9904).
5323
bd7da63e
GM
53242012-02-12 Glenn Morris <rgm@gnu.org>
5325
5326 * xselect.c (Fx_own_selection_internal)
5327 (Fx_get_selection_internal, Fx_disown_selection_internal)
5328 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5329 * nsselect.m (Fx_own_selection_internal)
5330 (Fx_disown_selection_internal, Fx_selection_exists_p)
5331 (Fx_selection_owner_p, Fx_get_selection_internal):
5332 Sync docs and argument specs with the xselect.c versions.
5333
77abcbc2
LI
53342012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5335
5336 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5337
90b671e2
EZ
53382012-02-11 Eli Zaretskii <eliz@gnu.org>
5339
1c0ca0b7
EZ
5340 * w32select.c (Fx_selection_exists_p): Sync doc string and
5341 argument list with xselect.c. (Bug#10783)
5342
5343 * w16select.c (Fx_selection_exists_p): Sync doc string and
5344 argument list with xselect.c. (Bug#10783)
90b671e2 5345
49241268
GM
53462012-02-10 Glenn Morris <rgm@gnu.org>
5347
5348 * fns.c (Fsecure_hash): Doc fix.
5349
f998bbe7 53502012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5351
5352 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5353
0992bd9c
CY
53542012-02-07 Chong Yidong <cyd@gnu.org>
5355
5356 * buffer.c (Fbuffer_local_variables)
5357 (buffer_lisp_local_variables): Handle unbound vars correctly;
5358 don't let Qunbound leak into Lisp.
5359
af008560
GM
53602012-02-07 Glenn Morris <rgm@gnu.org>
5361
dd605cc4
GM
5362 * image.c (Fimagemagick_types): Doc fix.
5363
af008560
GM
5364 * image.c (imagemagick-render-type): Change it from a lisp object
5365 to an integer. Move the doc here from the lisp manual.
5366 Treat all values not equal to 0 the same.
5367
1449fa1d
CY
53682012-02-06 Chong Yidong <cyd@gnu.org>
5369
5370 * doc.c (store_function_docstring): Avoid applying docstring of
5371 alias to base function (Bug#2603).
5372
3723ec07
AS
53732012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5374
5375 * .gdbinit (pp1, pv1): Remove redundant defines.
5376 (pr): Use pp.
5377
79c1cc1e
CY
53782012-02-04 Chong Yidong <cyd@gnu.org>
5379
5380 * nsterm.m: Declare a global (Bug#10694).
5381
d7f29f8e
EZ
53822012-02-04 Eli Zaretskii <eliz@gnu.org>
5383
cae07000
SM
5384 * w32.c (get_emacs_configuration_options):
5385 Include --enable-checking, if specified, in the return value.
d7f29f8e 5386
3b95a6f9
MR
53872012-02-04 Martin Rudalics <rudalics@gmx.at>
5388
5389 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5390 after rounding frame sizes. (Bug#9723)
5391
d6fa96a6
EZ
53922012-02-04 Eli Zaretskii <eliz@gnu.org>
5393
5394 * keyboard.c (adjust_point_for_property): Don't position point
5395 before BEGV. (Bug#10696)
5396
df0b2940
PE
53972012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5398
5399 Handle overflow when computing char display width (Bug#9496).
5400 * character.c (char_width): Return EMACS_INT, not int.
5401 (char_width, c_string_width): Check for overflow when
5402 computing the width; this is possible now that individual
5403 characters can have unbounded width. Problem introduced
5404 by merge from Emacs 23 on 2012-01-19.
5405
6bee44d6
MA
54062012-02-02 Michael Albinus <michael.albinus@gmx.de>
5407
5408 * dbusbind.c (Fdbus_register_method): Mention the return value
5409 :ignore in the docstring.
5410
44f92739
GM
54112012-02-02 Glenn Morris <rgm@gnu.org>
5412
1b9f60cc
GM
5413 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5414
44f92739
GM
5415 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5416 Unconditionally set to t. (Bug#10673)
5417 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5418 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5419 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5420
c5d3843c
KH
54212012-02-02 Kenichi Handa <handa@m17n.org>
5422
5423 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5424 0, do not call append_composite_glyph.
5425
159462d4 54262012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5427
5428 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5429 NULL (Bug#6988).
5430 (x_produce_glyphs): If the component of a composition is a null
5431 string, set it->pixel_width to 1 to avoid zero-width glyph.
5432
78cef877
EZ
54332012-02-01 Eli Zaretskii <eliz@gnu.org>
5434
5435 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5436 first 2 arguments are identical. This makes inserting large
5437 output from a subprocess an order of magnitude faster on
5438 MS-Windows, where all sbrk'ed memory is always contiguous.
5439
97897668
GM
54402012-01-31 Glenn Morris <rgm@gnu.org>
5441
5442 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5443 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5444 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5445
31fd3586
GM
54462012-01-29 Glenn Morris <rgm@gnu.org>
5447
5448 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5449
0e24a8b2
CY
54502012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5451
5452 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5453
cc0adcb0
CY
54542012-01-28 Chong Yidong <cyd@gnu.org>
5455
5456 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5457
acc28cb9
CY
54582012-01-26 Chong Yidong <cyd@gnu.org>
5459
9c69cfb7
CY
5460 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5461
acc28cb9
CY
5462 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5463 repeat counts (Bug#10507).
5464
48da7392
GM
54652012-01-26 Glenn Morris <rgm@gnu.org>
5466
5467 * lread.c (syms_of_lread): Doc fix.
5468
14af5f7f
CY
54692012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5470
5471 * coding.c (encode_designation_at_bol): Change return value to
5472 EMACS_INT.
5473
0b21c100
CY
54742012-01-25 Chong Yidong <cyd@gnu.org>
5475
5476 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5477
3c2907f7
CY
54782012-01-21 Chong Yidong <cyd@gnu.org>
5479
5480 * floatfns.c (Fcopysign): Make the second argument non-optional,
5481 since nil is not allowed anyway.
5482
959ad23f
AS
54832012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5484
5485 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5486 (send_process): Likewise.
5487
34a02f46
MR
54882012-01-19 Martin Rudalics <rudalics@gmx.at>
5489
5490 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5491 (Vwindow_persistent_parameters): Do not use Qstate.
5492 Rewrite doc-strings.
34a02f46 5493
1259009a 54942012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5495
5496 * character.c (char_width): New function.
70d4fdf6
GM
5497 (Fchar_width, c_string_width, lisp_string_width):
5498 Use char_width (Bug#9496).
25ed9e61 5499
6a6ee00d
MR
55002012-01-16 Martin Rudalics <rudalics@gmx.at>
5501
5502 * window.c (Vwindow_persistent_parameters): New variable.
5503 (Fset_window_configuration, save_window_save): Handle persistent
5504 window parameters.
5505
c85efaf7
EZ
55062012-01-14 Eli Zaretskii <eliz@gnu.org>
5507
5508 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5509 thrashing the stack of the thread. (Bug#9087)
5510
5944709e
PE
55112012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5512
5513 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5514
e71f5d99
EZ
55152012-01-11 Eli Zaretskii <eliz@gnu.org>
5516
5517 * xdisp.c (rows_from_pos_range): Handle the case where the
5518 highlight ends on a newline. (Bug#10464)
5519 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5520 he end column for display of highlight that ends on a newline
5521 before a R2L line.
5522
ce316182
GM
55232012-01-11 Glenn Morris <rgm@gnu.org>
5524
5525 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5526 from load-path also when installation-directory is nil. (Bug#10208)
5527
5b43da69
GM
55282012-01-10 Glenn Morris <rgm@gnu.org>
5529
74cc8ff9
GM
5530 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5531
7d8d6e4e
GM
5532 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5533 Update template values to be closer to their typical values these days.
5b43da69 5534
a0db8d43
EZ
55352012-01-09 Eli Zaretskii <eliz@gnu.org>
5536
5537 * xdisp.c (rows_from_pos_range): Accept additional argument
5538 DISP_STRING, and accept any glyph in a row whose object is that
5539 string as eligible for mouse highlight. Fixes mouse highlight of
5540 display strings from overlays. (Bug#10464)
5541
9a0115ab 55422012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5543
b9110d6a 5544 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5545 * fileio.c (auto_saving_dir_umask): New static var.
5546 (Fmake_directory_internal): Use it.
5547 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5548 creating the directory. The old code temporarily assigns
5549 too-generous permissions to the directory.
5550 (do_auto_save_eh): Clear it.
b9110d6a 5551 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5552 that the var is always cleared.
5553
6c1bd3f3
EZ
55542012-01-07 Eli Zaretskii <eliz@gnu.org>
5555
5556 * search.c (scan_buffer): Pass character positions to
5557 know_region_cache, not byte positions. (Bug#6540)
5558
069d2b50
L
55592012-01-07 LynX <_LynX@bk.ru> (tiny change)
5560
5561 * w32.c (sys_rename): Report EXDEV when rename of a directory
5562 fails because the target is on another logical disk. (Bug#10284)
5563
75bf0d33
DB
55642012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5565
5566 * xterm.c (x_embed_request_focus): New function.
5567
5568 * xterm.h: Add prototype.
5569
5570 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5571
1c6e5a32
GM
55722012-01-05 Glenn Morris <rgm@gnu.org>
5573
5574 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5575
651e947e
EZ
55762012-01-01 Eli Zaretskii <eliz@gnu.org>
5577
5578 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5579 Load gnutls_transport_set_lowat only if GnuTLS version is below
5580 2.11.1.
5581 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5582 GnuTLS versions below 2.11.1.
5583
3778cdd8
AL
55842011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5585
5586 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5587 to the doc string advising against its use for altering the way
5588 windows are scrolled.
5589
0e5317f7
KH
55902011-12-28 Kenichi Handa <handa@m17n.org>
5591
5592 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5593 coding-system ASCII compatible only when it does not produce BOM
5594 on encoding (Bug#10383).
5595
93d5ca1f
JD
55962011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5597
5598 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5599 can scroll.
5600 (create_and_show_popup_menu): Always use menu_position_func for
5601 Gtk3 (Bug#10361).
5602
ca22b785
AS
56032011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5604
5605 * callint.c (Fcall_interactively): Don't truncate prompt string.
5606
d048e1e6
EZ
56072011-12-23 Eli Zaretskii <eliz@gnu.org>
5608
5609 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5610 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5611 resumed from there (after widening). (Bug#10360)
d048e1e6 5612
5ccaba1f
JD
56132011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5614
5615 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5616
204ee57f
JD
56172011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5618
b81d40f0
JB
5619 * nsterm.m (x_free_frame_resources):
5620 Release f->output_data.ns->miniimage.
204ee57f
JD
5621 (ns_index_color): Fix indentation. Do not retain
5622 color_table->colors[i].
5623
5624 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5625 before returning.
5626
5627 * nsfns.m (x_set_background_color): Assign return value from
5628 ns_index_color to face-background instead of NSColor*.
5629 (ns_implicitly_set_icon_type): Fix indentation.
5630 Change assignment in for loop to comparison.
5631
5632 * emacs.c (ns_pool): New variable.
5633 (main): Assign ns_pool.
5634 (Fkill_emacs): Call ns_release_autorelease_pool.
5635
5636 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5637 autorelease fdesc, release fdAttrs and tdict.
5638 (ns_get_covering_families): Release charset.
5639 (ns_findfonts): Release NSFontDescriptor created with new.
5640 (ns_uni_to_glyphs): Fix indentation.
5641 (setString): Release attrStr before assigning new value.
5642
c803b2b7
JD
56432011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5644
678f4426
JD
5645 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5646 and NS_IMPL_COCOA.
5647 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5648 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5649
cd394be1 56502011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5651
5fecd5fc
JD
5652 * nsterm.m (ns_term_init): Subscribe for notifications
5653 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5654 to method trackingNotification in EmacsMenu.
5655
5656 * nsmenu.m (trackingMenu): New variable.
3771cb17 5657 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5658 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5659 from Aquamacs (Bug#7030).
678f4426
JD
5660
56612011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5662
c803b2b7
JD
5663 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5664 (symbol_to_nsstring): Fix indentation.
5665 (ns_symbol_to_pb): New function.
cae07000
SM
5666 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5667 (Fns_rotate_cut_buffers_internal): Remove.
5668 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5669 Fns_store_cut_buffer_internal.
5670 (ns_get_foreign_selection, Fx_own_selection_internal)
5671 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5672 (Fns_get_selection_internal, Fns_store_selection_internal):
5673 Use ns_symbol_to_pb and check if return value is nil.
5674 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5675 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5676 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5677 renamed to Sns_store_selection_internal.
5678 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5679 and remove this function.
5680 (ns_handle_selection_clear): Remove, never used.
5681 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5682 here.
5683
e1b01a3a
KB
56842011-12-17 Ken Brown <kbrown@cornell.edu>
5685
5686 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5687 GID is unknown (Bug#10257).
5688
2adb6e85
PE
56892011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5690
5691 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5692 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5693 which caused a build failure on GNU/Linux IA-64. This problem was
5694 introduced by my 2011-10-07 patch.
5695
d1d7b339
JL
56962011-12-15 Juri Linkov <juri@jurta.org>
5697
5698 * image.c (imagemagick_error): New function. (Bug#10112)
5699 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5700 Use `imagemagick_error' where ImageMagick functions return
5701 `MagickFalse'.
5702 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5703 proper order.
5704
100d5755
KH
57052011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5706
5707 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5708 fill background (Bug#8992).
5709
454592a6
MR
57102011-12-13 Martin Rudalics <rudalics@gmx.at>
5711
5712 * window.c (Vwindow_combination_resize)
5713 (Vwindow_combination_limit): Use t instead of non-nil in
5714 doc-strings.
61d4b438
MR
5715 (Vrecenter_redisplay): Add first sentence of doc-string on
5716 separate line.
53524d93 5717 (Frecenter): Fix doc-string typo.
454592a6 5718
3633e3aa
KH
57192011-12-11 Kenichi Handa <handa@m17n.org>
5720
5721 * coding.c (Funencodable_char_position): Pay attention to the
5722 buffer text relocation (Bug#9389).
5723
7b9d523a 57242011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5725
7b9d523a
JD
5726 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5727 gtk_init (Bug#10100).
5728
b73189c6
EZ
57292011-12-10 Eli Zaretskii <eliz@gnu.org>
5730
5731 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5732 IT->string is nil. (Bug#10263)
5733
f7dfe5d6
JD
57342011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5735
83faebb4
JD
5736 * nsterm.h (x_free_frame_resources): Declare.
5737
f7dfe5d6
JD
5738 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5739 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5740
5741 * nsterm.h (ns_get_defaults_value): Declare.
5742
5743 * nsterm.m (ns_default): Call ns_get_defaults_value.
5744
7cd4e72c
EZ
57452011-12-09 Eli Zaretskii <eliz@gnu.org>
5746
5747 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5748 (Bug#10170)
5749
b34d7317
YM
57502011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5751
5752 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5753 that where the value of an _OBJC_* symbol points to is in the .bss
5754 section (Bug#10240).
5755
76470ad1
KH
57562011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5757
5758 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5759 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5760
745fff94
KH
57612011-12-08 Kenichi Handa <handa@m17n.org>
5762
5763 * ftfont.c (get_adstyle_property): Fix previous change
5764 (Bug#10233).
5765
6e44397c
JB
57662011-12-07 Juanma Barranquero <lekktu@gmail.com>
5767
5768 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5769 dirs from the default value of EMACSLOADPATH (bug#10208).
5770
7efa6272
GM
57712011-12-07 Glenn Morris <rgm@gnu.org>
5772
5773 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5774 installation and source directories as well. (Bug#10208)
5775
f6fc4d87
CY
57762011-12-06 Chong Yidong <cyd@gnu.org>
5777
5778 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5779
2bf26180
GM
57802011-12-06 Glenn Morris <rgm@gnu.org>
5781
5782 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5783 as an error, not just -1. (Bug#10217)
5784
3a6ad4f0
CY
57852011-12-05 Chong Yidong <cyd@gnu.org>
5786
5787 * keyboard.c (process_special_events): New function.
5788 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5789
75a3b399
PE
57902011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5791
5792 * coding.c (encode_designation_at_bol): Don't use uninitialized
5793 local variable (Bug#9318).
5794
c3c9e25e
KH
57952011-12-05 Kenichi Handa <handa@m17n.org>
5796
5797 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5798 return Qnil (Bug#8046, Bug#10193).
5799
5eb05ea3
KH
58002011-12-05 Kenichi Handa <handa@m17n.org>
5801
5802 * coding.c (encode_designation_at_bol): New args charbuf_end and
5803 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5804 (coding_set_source): Return how many bytes coding->source was
5805 relocated.
5806 (coding_set_destination): Return how many bytes
5807 coding->destination was relocated.
5808 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5809 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5810
58112011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5812
5813 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5814 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5815 macro (Bug#9318).
5816
58172011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5818
5819 The following changes are to fix Bug#9318.
5820
a79703f5 5821 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5822 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5823 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5824 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5825
7dbda6df
JB
58262011-12-05 Juanma Barranquero <lekktu@gmail.com>
5827
5828 * lisp.h (process_quit_flag): Fix external declaration.
5829
6d5eb5b0
SM
58302011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5831
5832 Don't macro-inline non-performance-critical code.
5833 * eval.c (process_quit_flag): New function.
5834 * lisp.h (QUIT): Use it.
5835
a0c3fad0
JD
58362011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5837
5838 * nsfns.m (get_geometry_from_preferences): New function.
5839 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5840
6c07aac2
AS
58412011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5842
5843 * emacs.c (Qkill_emacs): Define.
5844 (syms_of_emacs): Initialize it.
5845 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5846 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5847 (quit_throw_to_read_char): Add parameter `from_signal'.
5848 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5849 * lisp.h (QUIT): Call Fkill_emacs if requested.
5850
c052ead4
JD
58512011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5852
5853 * widget.c (update_wm_hints): Return if wmshell is null.
5854 (widget_update_wm_size_hints): New function.
5855
5856 * widget.h (widget_update_wm_size_hints): Declare.
5857
5858 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5859 widget_update_wm_size_hints (Bug#10104).
5860
9e49252b
EZ
58612011-12-03 Eli Zaretskii <eliz@gnu.org>
5862
5863 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5864 before a newline, prepare the bidi iterator for consuming the
5865 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5866 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5867
02b16839
JL
58682011-12-02 Juri Linkov <juri@jurta.org>
5869
5870 * search.c (Fword_search_regexp): New Lisp function created from
5871 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5872 (Fword_search_backward, Fword_search_forward)
5873 (Fword_search_backward_lax, Fword_search_forward_lax):
5874 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5875 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5876
0068070e
SM
58772011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5878
5879 * fileio.c (Finsert_file_contents): Move after-change-function call
5880 to before the "handled:" label, since all "goto handled" appear in
5881 cases where the *-change-functions have already been properly called
5882 (bug#10117).
5883
3360a3fc
AS
58842011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5885
5886 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5887 waiting for input. (Bug#10169)
5888
73d6c093
EZ
58892011-11-30 Eli Zaretskii <eliz@gnu.org>
5890
5891 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5892 verifies glyph row's hash code--we have just reallocated the
5893 glyphs, so their contents can be complete garbage. (Bug#10164)
5894
febe6bea
JB
58952011-11-30 Juanma Barranquero <lekktu@gmail.com>
5896
5897 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5898
801a4313
EZ
58992011-11-30 Eli Zaretskii <eliz@gnu.org>
5900
5901 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5902 attributes are tested _before_ calling verify_row_hash, to protect
5903 against GCC re-ordering of the tests. (Bug#10164)
5904
2b56b87e
JD
59052011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5906
5907 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5908
5909 * xterm.c (handle_one_xevent): Only set async_visible and friends
5910 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5911 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5912 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5913
dbf31225
PE
59142011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5915
5916 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5917 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5918 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5919 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5920 All uses changed to use GCPRO1 etc.
5921 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5922 Revert to old implementation (i.e., before 2011-03-11).
5923
1305621b
YM
59242011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5925
5926 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5927 of scroll runs so as to avoid assigning disabled bogus rows and
5928 unnecessary graphics copy operations.
5929
8c9afb46
EZ
59302011-11-27 Eli Zaretskii <eliz@gnu.org>
5931
5932 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5933 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5934 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5935 (malloc, free, realloc, calloc): Redirect to e_* only when
5936 compiling Emacs.
5937
5938 * lisp.h (GCTYPEBITS): Move before first use.
5939 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5940 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5941 this macro definition.
5942
5943 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5944 _MSC_VER.
5945
54e9e3bf
JD
59462011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5947
6d5eb5b0
SM
5948 * gtkutil.c (xg_create_frame_widgets):
5949 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5950 present with Gtk+ 2.0.
5951
83aca1cb
PE
59522011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5953
5954 * fileio.c (Finsert_file_contents): Undo previous change; see
5955 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5956
5b76caa4
PE
59572011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5958
5959 Rename locals to avoid shadowing.
5960 * fileio.c (Finsert_file_contents):
5961 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5962 * process.c (wait_reading_process_output):
5963 Rename inner 'proc' to 'p' to avoid shadowing.
5964 Indent for consistency with usual Emacs style.
5965
8c535114
EZ
59662011-11-25 Eli Zaretskii <eliz@gnu.org>
5967
5968 * xdisp.c (redisplay_window): If cursor row is not fully visible
5969 after recentering, and scroll-conservatively is set to a large
5970 number, scroll window by a few more lines to make the cursor fully
5971 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5972 (start_display): Don't move to the next line if the display should
5973 start at a newline that is part of a display vector or an overlay
5974 string. (Bug#10119)
8c535114 5975
fa4fdb5c
JL
59762011-11-24 Juri Linkov <juri@jurta.org>
5977
5978 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5979 after the `MagickPingImage' call. (Bug#10112)
5980
90ec88df
CY
59812011-11-23 Chong Yidong <cyd@gnu.org>
5982
5983 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5984
56e2e794
MR
59852011-11-23 Martin Rudalics <rudalics@gmx.at>
5986
5987 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5988 making another buffer current. (Bug#10114)
5989
b6e64c41
GM
59902011-11-23 Glenn Morris <rgm@gnu.org>
5991
5992 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5993
6b21de18
CY
59942011-11-23 Chong Yidong <cyd@gnu.org>
5995
5996 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5997 using it (Bug#5984).
5998
b12cd789
EZ
59992011-11-22 Eli Zaretskii <eliz@gnu.org>
6000
6001 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6002 and header-lines, as they don't have one computed for them.
6003 (Bug#10098)
6004
6005 * .gdbinit (prow): Make displayed values more self-explaining.
6006 Add row's hash code.
6007
261b6fd4
LMI
60082011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6009
6010 * process.c (wait_reading_process_output): Fix asynchrounous
6011 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6012 (wait_reading_process_output): Add comment and URL.
261b6fd4 6013
e7cfd277
JD
60142011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6015
6016 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6017
a9b9b7f5
CY
60182011-11-21 Chong Yidong <cyd@gnu.org>
6019
6020 * window.c (Fnext_window, Fprevious_window): Doc fix.
6021
b0d15b4f
SM
60222011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6023
6024 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6025
fe7a3057
JB
60262011-11-20 Juanma Barranquero <lekktu@gmail.com>
6027
6028 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6029
d2999b1a
MR
60302011-11-20 Martin Rudalics <rudalics@gmx.at>
6031
6032 * window.c (Fset_window_combination_limit): Rename argument
6033 STATUS to LIMIT.
6034 (Vwindow_combination_limit): Remove "status" from doc-string.
6035
d5ff9cd0
AS
60362011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6037
6038 * m/ibms390.h: Remove.
6039 * m/ibms390x.h: Don't include "ibms390.h".
6040
a5bb9bd3
SM
60412011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6042
6043 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6044 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6045
cd1181db
JB
60462011-11-20 Juanma Barranquero <lekktu@gmail.com>
6047
6048 * casetab.c (Fset_case_table):
6049 * charset.c (Fcharset_after): Fix typos.
6050
615a3b8d 60512011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6052
17e845af
PE
6053 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6054 Otherwise, valgrind does not work on some platforms.
6055 Problem reported by Andreas Schwab in
6a0bf43d
PE
6056 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6057 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6058 is set, removing the need for VIRT_ADDRESS_VARIES.
6059 (PURE_P): Use a more-efficient implementation that needs just one
6060 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6061 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6062 to 4 (xorl, subq, cmpq, setbe).
6063 * alloc.c (pure): Always extern now, since that's the
6064 VIRT_ADDR_VARIES behavior.
6065 (PURE_POINTER_P): Use a single comparison, not two, for
6066 consistency with the new puresize.h.
6067 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6068 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6069 Remove VIRT_ADDR_VARIES no longer needed.
6070
f8fe6f96
EZ
60712011-11-19 Eli Zaretskii <eliz@gnu.org>
6072
6073 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6074 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6075 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6076 behave as if the cursor position were at the window margin.
6077
6078 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6079 and the cursor position is out of bounds, behave as if the cursor
6080 position were at the window margin. (Bug#10075)
6081
df05a53c
CY
60822011-11-18 Chong Yidong <cyd@gnu.org>
6083
6084 * window.c (Fwindow_combination_limit): Make first argument
6085 non-optional, since it is meaningless for live windows like the
6086 selected window.
61ccba97 6087
2071918e
DA
60882011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6089
6090 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6091
b50a28de
SM
60922011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6093
6094 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6095 (graft_intervals_into_buffer): Simplify.
6096
015137db
EZ
60972011-11-18 Eli Zaretskii <eliz@gnu.org>
6098
6099 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6100 hash values of the two rows.
6101 (copy_row_except_pointers): Preserve the used[] arrays and the
6102 hash values of the two rows. (Bug#10035)
68c95424 6103 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6104
6105 * xdisp.c (row_hash): New function, body extracted from
6106 compute_line_metrics.
6107 (compute_line_metrics): Call row_hash, instead of computing the
6108 hash code inline.
6109
6110 * dispnew.c (verify_row_hash): Call row_hash for computing the
6111 hash code of a row, instead of duplicating code from xdisp.c.
6112
6113 * dispextern.h (row_hash): Add prototype.
6114
a2addb04
TH
61152011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6116
6117 * frame.c (delete_frame): Don't delete the terminal when the last
6118 X frame is closed if emacs is built with GTK toolkit.
6119
df85d315
JB
61202011-11-17 Juanma Barranquero <lekktu@gmail.com>
6121
6122 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6123
a0c2d0ae
MR
61242011-11-17 Martin Rudalics <rudalics@gmx.at>
6125
6126 * window.c (Vwindow_splits): Rename to
6127 Vwindow_combination_resize. Suggested by Juri Linkov.
6128 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6129 of Vwindow_splits.
6130
58179cce
JB
61312011-11-16 Juanma Barranquero <lekktu@gmail.com>
6132
7877f373
JB
6133 * nsfns.m (Fns_font_name):
6134 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6135
b6f67890
MR
61362011-11-16 Martin Rudalics <rudalics@gmx.at>
6137
6138 * window.h (window): Rename slot "nest" to "combination_limit".
6139 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6140 (Fset_window_nest): Rename to Fset_window_combination_limit.
6141 (Vwindow_nest): Rename to Vwindow_combination_limit.
6142 (recombine_windows, make_parent_window, make_window)
6143 (Fsplit_window_internal, saved_window)
6144 (Fset_window_configuration, save_window_save): Rename all
6145 occurrences of window_nest to window_combination_limit.
6146
c7015153
JB
61472011-11-15 Juanma Barranquero <lekktu@gmail.com>
6148
6149 * image.c (imagemagick_load_image): Fix typo.
6150
322ad6ec
EZ
61512011-11-14 Eli Zaretskii <eliz@gnu.org>
6152
6153 * xdisp.c (display_line): Move the call to
6154 highlight_trailing_whitespace before the call to
6155 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6156 faces of all the glyphs to compute ROW's hash value.
6157 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6158
f067b8ec
JB
61592011-11-14 Juanma Barranquero <lekktu@gmail.com>
6160
6161 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6162 just return (bug#10044).
6163
1e5b2111
EZ
61642011-11-12 Eli Zaretskii <eliz@gnu.org>
6165
7ef3cbd5
EZ
6166 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6167 with user-defined heap size. Bump the default size of the temacs
6168 heap to 27MB, to avoid memory warning when running temacs.
6169 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6170
1e5b2111
EZ
6171 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6172 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6173 (verify_row_hash) [XASSERTS]: New function.
6174 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6175 that the hash value of glyph rows is correct.
1e5b2111 6176
89d61221
MR
61772011-11-12 Martin Rudalics <rudalics@gmx.at>
6178
6179 * window.h (window): Remove splits slot.
6180 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6181 (Fdelete_other_windows_internal, make_parent_window)
6182 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6183 (Fset_window_configuration, save_window_save): Don't deal with
6184 split status of windows.
6185 (saved_window): Remove splits slot.
6186 (Vwindow_splits): Rewrite doc-string.
6187
97f18cc8
JD
61882011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6189
6190 * xfns.c (unwind_create_frame):
6191 * nsfns.m (unwind_create_frame):
6192 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6193 Vframe_list (Bug#9999).
6194
22a648b4
DA
61952011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6196
0b381c7e 6197 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6198
659afede
KH
61992011-11-11 Kenichi Handa <handa@m17n.org>
6200
6201 * callproc.c (Fcall_process): Set the member dst_multibyte of
6202 process_coding.
6203
9ac0394b
KH
62042011-11-11 Johan Bockgård <bojohan@gnu.org>
6205
6206 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6207 avoid a crash (bug#9496).
6208
2fbdc249
CY
62092011-11-09 Chong Yidong <cyd@gnu.org>
6210
6211 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6212 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6213
ac6b1f81
PE
62142011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6215
6216 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6217
09db192c
PE
62182011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6219
6220 Avoid some portability problems by eschewing 'extern inline' functions.
6221 The trivial performance wins aren't worth the portability hassles; see
6222 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6223 et seq.
6224 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6225 (window_box_width, window_box_left, window_box_left_offset)
6226 (window_box_right, window_box_right_offset): Undo previous change,
6227 by removing the "extern"s.
6228 * intervals.c (adjust_intervals_for_insertion)
6229 (adjust_intervals_for_deletion): Undo previous change,
6230 making these static again.
6231 (offset_intervals, temp_set_point_both, temp_set_point)
6232 (copy_intervals_to_string): No longer inline.
6233 * xdisp.c (window_text_bottom_y, window_box_width)
6234 (window_box_height, window_box_left_offset)
6235 (window_box_right_offset, window_box_left, window_box_right)
6236 (window_box): No longer inline.
6237
105216ed
CY
62382011-11-08 Chong Yidong <cyd@gnu.org>
6239
6240 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6241 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6242 Signal an error if not a live window.
105216ed
CY
6243 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6244 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6245
ae9e237f
JB
62462011-11-07 Juanma Barranquero <lekktu@gmail.com>
6247
6248 * lisp.h (syms_of_abbrev): Remove declaration.
6249 Reported by CHENG Gao <chenggao@royau.me>.
6250
c7aa8333
EZ
62512011-11-07 Eli Zaretskii <eliz@gnu.org>
6252
6253 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6254 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6255 of temacs in GUI mode.
6256
be7f5545
MR
62572011-11-07 Martin Rudalics <rudalics@gmx.at>
6258
6259 * window.h: Declare delete_all_child_windows instead of
6260 delete_all_subwindows.
6261 * window.c (Fwindow_nest, Fset_window_nest)
6262 (Fset_window_new_total, Fset_window_new_normal)
6263 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6264 (delete_all_subwindows): Rename to delete_all_child_windows.
6265 (Fdelete_other_windows_internal, Fset_window_configuration):
6266 Call delete_all_child_windows instead of delete_all_subwindows.
6267 * frame.c (delete_frame): Call delete_all_child_windows instead
6268 of delete_all_subwindows.
6269
ca78dc43
PE
62702011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6271
6272 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6273 This is also needed for porting to any host where GC_MARK_STACK is
6274 not GC_MAKE_GCPROS_NOOPS.
6275 (which_symbols): Use it.
6276
a0241d01
KH
62772011-11-07 Kenichi Handa <handa@m17n.org>
6278
6279 * coding.c (coding_set_destination): Check coding->src_pos only
6280 when coding->src_object is a buffer (bug#9910).
6281
6282 * process.c (send_process): Set the member src_multibyte of coding
6283 to 0 (bug#9911) when sending a unibyte text.
6284
6285 * callproc.c (Fcall_process): Set the member src_multibyte of
6286 process_coding to 0 (bug#9912).
6287
a64bfdfa 62882011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6289
6290 * xmenu.c (cleanup_widget_value_tree): New function.
6291 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6292 calling free_menubar_widget_value_tree directly (Bug#9830).
6293
cb41b32a
PE
62942011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6295
6296 Fix some portability problems with 'inline'.
6297 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6298 (window_box_width, window_box_left, window_box_left_offset)
6299 (window_box_right, window_box_right_offset): Declare extern.
6300 Otherwise, these inline functions do not conform to C99 and
6301 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6302 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6303 * intervals.c (adjust_intervals_for_insertion)
6304 (adjust_intervals_for_deletion): Now extern, because otherwise the
6305 extern inline functions 'offset_intervals' couldn't refer to it.
6306 (static_offset_intervals): Remove.
6307 (offset_intervals): Rewrite using the old contents of
6308 static_offset_intervals. The old version didn't conform to C99
6309 because an extern inline function contained a reference to an
6310 identifier with static linkage.
6311
b7041366
AS
63122011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6313
6314 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6315 GC.
6316
88a37c4d
EZ
63172011-11-06 Eli Zaretskii <eliz@gnu.org>
6318
6319 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6320 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6321 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6322 return Qleft_to_right.
6323
49745b39
CY
63242011-11-06 Chong Yidong <cyd@gnu.org>
6325
6326 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6327 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6328 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6329 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6330 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6331 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6332 (Fwindow_vscroll): Doc fix.
6333 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6334 argument, since it makes no sense to pass a live window and for
6335 consistency with window-child.
6336
1f05cd82
CS
63372011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6338
6339 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6340 support MSVC.
6341
22610910
JR
63422011-11-05 Jason Rumney <jasonr@gnu.org>
6343
6344 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6345 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6346 fonts (Bug#6029).
6347 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6348 bitwise arithmetic preventing use of unicode-sip and non-truetype
6349 opentype fonts.
6350
a06776b2
EZ
63512011-11-05 Eli Zaretskii <eliz@gnu.org>
6352
3ad924ba
EZ
6353 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6354 "emacs"-only part.
6355
a06776b2
EZ
6356 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6357 initialization code to keep similarity to xfns.c after changes
6358 from 2011-11-05.
6359
c9e7db78
JD
63602011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6361
a97f8f3f
JD
6362 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6363 (unwind_create_frame): New function (Bug#9943).
6364 (Fx_create_frame): Restructure code to be more similar to the one in
6365 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6366 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6367 Move terminal->reference_count++ just before making the frame official
6368 (Bug#9943).
6369
6370 * nsterm.m (x_free_frame_resources): New function.
6371 (x_destroy_window): Move code to x_free_frame_resources.
6372
c9e7db78 6373 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6374 (Fx_create_frame, x_create_tip_frame):
6375 Move terminal->reference_count++ just before making the frame
75f1671a 6376 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6377 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6378
a6fc3b5c
EZ
63792011-11-05 Eli Zaretskii <eliz@gnu.org>
6380
6381 Support MSVC build with newer versions of Visual Studio.
6382 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6383 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6384 nt/gmake.defs.
6385
6386 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6387 which are not supported by MSVC.
6388 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6389 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6390 bitfields.
6391 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6392 types in bitfields.
6393 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6394
6395 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6396
58179cce 63972011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6398
6399 Support MSVC build with newer versions of Visual Studio.
6400 * w32.c: Don't include w32api.h for MSVC.
6401 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6402
6403 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6404 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6405 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6406 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6407 e_* cousins.
6408 (alloca) [_MSC_VER]: Define to _alloca.
6409
6410 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6411
6412 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6413
a58c13ed
EZ
64142011-11-04 Eli Zaretskii <eliz@gnu.org>
6415
6416 * xdisp.c (note_mouse_highlight): If either of
6417 previous/next-single-property-change returns nil, treat that as
6418 the beginning or the end of the buffer. (Bug#9955)
6419
fe0b6370
JD
64202011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6421
a58c13ed 6422 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6423 label is not null (Bug#9951).
6424 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6425 may be NULL.
6426
89bd5ee1
EZ
64272011-11-04 Eli Zaretskii <eliz@gnu.org>
6428
6429 * window.c (Fwindow_body_size): Mention in the doc string that the
6430 return value is in frame's canonical units. (Bug#9949)
6431
84c3edb9
EZ
64322011-11-03 Eli Zaretskii <eliz@gnu.org>
6433
4e2fb5c7
EZ
6434 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6435
84c3edb9 6436 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6437 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6438 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6439
bc17a887
EZ
64402011-11-01 Eli Zaretskii <eliz@gnu.org>
6441
6442 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6443 Don't stop backward scan on the continuation glyph, even though
6444 its CHARPOS is positive.
6d5eb5b0
SM
6445 (mouse_face_from_buffer_pos, note_mouse_highlight):
6446 Rename cover_string to disp_string.
bc17a887 6447
4ee88440
MR
64482011-11-01 Martin Rudalics <rudalics@gmx.at>
6449
6450 * window.c (temp_output_buffer_show): Don't use
6451 Vtemp_buffer_show_specifiers.
6452 (Vtemp_buffer_show_specifiers): Remove unused variable.
6453
c2ff3c02
EZ
64542011-10-30 Eli Zaretskii <eliz@gnu.org>
6455
6456 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6457 past the beginning of the current glyph matrix.
6458
58179cce 64592011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6460
6461 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6462 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6463 HAVE_GTK3 (Bug#9869).
b77a6a7f 6464
3b574623
JD
6465 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6466 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6467
b77a6a7f
JD
6468 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6469
6470 * xterm.c: Declare x_handle_net_wm_state to return int.
6471 (handle_one_xevent): Check if we are iconified but don't have
6472 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6473 (get_current_wm_state): Return non-zero if not hidden,
6474 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6475 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6476 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6477 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6478
196e41e4
PE
64792011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6480
6481 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6482 so that this new function doesn't get optimized away by a
6483 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6484
021f2e1a
AS
64852011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6486
6487 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6488
8b058d44
EZ
64892011-10-29 Eli Zaretskii <eliz@gnu.org>
6490
6491 Fix the `xbytecode' command.
6492 * .gdbinit (xprintbytestr): New command.
b50a28de 6493 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6494 (xbytecode): Print the byte-code string as well.
6495
4452fb80
EZ
64962011-10-29 Kim Storm <storm@cua.dk>
6497
8b058d44
EZ
6498 * alloc.c (which_symbols): New function.
6499
21b72067
AS
65002011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6501
6502 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6503 line. (Bug#9903)
6504
83ed7b5c
GM
65052011-10-29 Glenn Morris <rgm@gnu.org>
6506
6507 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6508 Not clear what it was for, and it causes various bugs. (Bug#9839)
6509
5a7a728b
EZ
65102011-10-28 Eli Zaretskii <eliz@gnu.org>
6511
6512 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6513 possible random value that matches one of those tested as
6514 condition to clear the mouse face.
6515
d3d0842f
CY
65162011-10-28 Chong Yidong <cyd@gnu.org>
6517
6518 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6519
31b39d13
DN
65202011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6521
6522 * window.c (make_window): Initialize phys_cursor_on_p.
6523
9aba6043
SM
65242011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6525
6526 * lisp.h (struct Lisp_Symbol): Update comments.
6527
c20992f4
JB
65282011-10-28 Juanma Barranquero <lekktu@gmail.com>
6529
6530 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6531
db4f02f2
EZ
65322011-10-28 Eli Zaretskii <eliz@gnu.org>
6533
6534 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6535 <oslsachem@gmail.com> for helping to debug this.
6536
6537 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6538 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6539 (g_b_init_get_glyph_outline_w): New static variables.
6540 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6541 (GetGlyphOutlineW_Proc): New typedefs.
6542 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6543 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6544 New functions.
6545 (w32font_open_internal, compute_metrics):
6546 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6547 instead of calling the "wide" APIs directly.
6548
6549 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6550
6551 * w32.h (syms_of_w32font): Add prototype.
6552
87e68db4
JB
65532011-10-27 Juanma Barranquero <lekktu@gmail.com>
6554
6555 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6556 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6557 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6558 (Fmove_to_window_line): Doc fix.
6559
435c1d67
CY
65602011-10-27 Chong Yidong <cyd@gnu.org>
6561
6562 * process.c (make_process): Set gnutls_state to NULL.
6563
6564 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6565 non-NULL, regardless of GNUTLS_INITSTAGE.
6566 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6567 an error. Set process slots as soon as we allocate them.
6568
6569 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6570
9c6c6f49
CY
65712011-10-27 Chong Yidong <cyd@gnu.org>
6572
9aba6043
SM
6573 * gnutls.c (emacs_gnutls_deinit): New function.
6574 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6575 (Fgnutls_deinit, Fgnutls_boot): Use it.
6576
6577 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6578 (deactivate_process): Call emacs_gnutls_deinit.
6579
657d08d3
JB
65802011-10-27 Juanma Barranquero <lekktu@gmail.com>
6581
6582 * image.c (x_create_x_image_and_pixmap):
6583 * w32.c (sys_rename, w32_delayed_load):
6584 * w32font.c (fill_in_logfont):
6585 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6586
5430d399
JB
65872011-10-26 Juanma Barranquero <lekktu@gmail.com>
6588
6589 * w32fns.c (w32_default_color_map): New function,
6590 extracted from Fw32_default_color_map.
a7ef684b 6591 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6592
fe0055fa
PE
65932011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6594
6595 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6596
e6346438
SM
65972011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6598
6599 * keyboard.c (test_undefined): New function (bug#9751).
6600 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6601
e112cc37
ET
66022011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6603
6604 * sysdep.c (init_sys_modes): Fix the check for the controlling
6605 terminal (Bug#6649).
6606
7b5d6677
EZ
66072011-10-20 Eli Zaretskii <eliz@gnu.org>
6608
6609 * dispextern.h (struct bidi_it): New member next_en_type.
6610
6611 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6612 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6613 current character, check also for next_en_type being WEAK_EN.
6614 (bidi_resolve_weak): Don't enter the expensive loop if the current
6615 position is before next_en_pos. Record the bidi type of the first
6616 non-ET, non-BN character we find, in addition to its position.
6617 (bidi_level_of_next_char): Invalidate next_en_type when
6618 next_en_pos is over-stepped.
6619
7da0b018
PE
66202011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6621
6622 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6623 * editfns.c: Rewrite current-time-zone so that it invokes
6624 the equivalent of (format-time-string "%Z") to get the time zone name.
6625 This fixes a bug when the time zone name contains characters that
6626 need converting from the system time locale to Emacs internal format.
6627 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6628 that patch fixed format-time-string to do the conversion, but
6629 I forgot to fix current-time-zone.
6630 (format_time_string): New function, containing most of
6631 what Fformat_time_string used to contain.
6632 (Fformat_time_string): Rewrite in terms of format_time_string.
6633 This doesn't change this function's behavior.
6634 (current-time-zone): Rewrite to use format_time_string.
6635 This fixes the bug reported by Michael Schierl in
6636 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6637 Jason Rumney's 2007-06-07 change worked around this bug, but
6638 didn't fix it.
6639 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6640
8547b010
EZ
66412011-10-19 Eli Zaretskii <eliz@gnu.org>
6642
6643 * xdisp.c (start_display): If the character at POS is displayed
6644 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6645 (try_window_reusing_current_matrix): If a line ends in a display
6646 vector or the next line starts in a display vector, continue
6647 redrawing the window even though the character position of
6648 start_row was reached.
8547b010
EZ
6649 (Bug#9771, part 2)
6650
4e948d15
CY
66512011-10-18 Chong Yidong <cyd@gnu.org>
6652
6653 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6654 with nobreak-char-display too.
6655
4787455f
EZ
66562011-10-18 Eli Zaretskii <eliz@gnu.org>
6657
6658 Fix part 3 of bug#9771.
6659 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6660 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6661 non-neutral characters if the current character is a paragraph
6662 separator (a.k.a. Newline). This avoids running the same
6663 expensive loop twice, once when we consume the preceding newline
6664 and the other time when the line actually needs to be displayed.
6665 Avoid the loop when we see neutrals on the base embedding level
6666 following a character whose directionality is the same as the
6667 paragraph's. This avoids running the expensive loop when a line
6668 ends in a long sequence of neutrals, like control characters.
6669 Add assertion against STRONG_AL type. Slightly rearrange code
6670 that determines the type of a neutral given the first non-neutral
6671 that follows it.
6672 (bidi_level_of_next_char): Set next_en_pos to zero when
6673 invalidating its info.
6674
2c91f553
EZ
66752011-10-17 Eli Zaretskii <eliz@gnu.org>
6676
6677 * xdisp.c (push_display_prop): Determine whether to record string
6678 or buffer position by IT->string, not by IT->method. Allow
6679 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6680 (move_it_vertically_backward): Don't look for character position
6681 immediately after the newline when in a continuation line.
6682 (Bug#9771, part 1)
2c91f553 6683
c7b08b0d
MR
66842011-10-15 Martin Rudalics <rudalics@gmx.at>
6685
6686 * window.c (coordinates_in_window): Rewrite and delabelize
6687 vertical border check. (Bug#5357) (Bug#9618)
6688
6b02f655
SM
66892011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6690
6691 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6692 errors in XSetWindowBorder (bug#9310).
6693
81d40c92
DA
66942011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6695
6696 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6697 avoid crash when xmalloc overrun checking is enabled.
6698
d4172c3b
EZ
66992011-10-13 Eli Zaretskii <eliz@gnu.org>
6700
6701 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6702 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6703 cursor motion with <left> and <right> arrow keys.
6704
6705 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6706 some callers set that themselves.
6707
b00eea75
EZ
67082011-10-12 Eli Zaretskii <eliz@gnu.org>
6709
6710 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6711 display string and the previous row comes from the same string and
6712 is empty. (Bug#9739) (Bug#9738)
6713
8fe012c4
SM
67142011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6715
6716 * doc.c (get_doc_string): Encode file name (bug#9735).
6717
0074aef2
EZ
67182011-10-12 Eli Zaretskii <eliz@gnu.org>
6719
79beb178
EZ
6720 * bidi.c (bidi_level_of_next_char):
6721 * xdisp.c (get_visually_first_element): Remove old incorrect
6722 comments regarding the Unicode Line Separator character.
6723
0074aef2
EZ
6724 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6725
6e4b3fbe
DA
67262011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6727
6728 * alloc.c (Fgc_status): Do not access beyond zombies array
6729 boundary if nzombies > MAX_ZOMBIES.
6730 * alloc.c (dump_zombies): Add missing format specifier.
6731
0324f3af
PE
67322011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6733
b5525cac
PE
6734 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6735 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6736
0324f3af
PE
6737 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6738 Some packages use them to denote characters with modifiers.
6739
e9b5f888
AS
67402011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6741
6742 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6743 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6744 matching a pp-number. Rename parameter var to var1.
6745
127827c0
SM
67462011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6747
6748 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6749
c8fd3bd0
GM
67502011-10-08 Glenn Morris <rgm@gnu.org>
6751
6752 * callint.c (Fcall_interactively): Give a more explicit error for the
6753 'c' case with a non-character input. (Bug#8479)
6754
352ec8ff
EZ
67552011-10-08 Eli Zaretskii <eliz@gnu.org>
6756
03669ccb
EZ
6757 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6758 lines.
7061c986
EZ
6759 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6760 lines that are hscrolled on the left.
03669ccb 6761
352ec8ff
EZ
6762 * dispnew.c (buffer_posn_from_coords): Account for a possible
6763 presence of header-line. (Bug#4426)
6764
a66cfb1c
SM
67652011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6766
6b02f655
SM
6767 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6768 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6769
7c5ee88e
PE
67702011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6771
6772 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6773 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6774 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6775 this makes Emacs dump core during garbage collection on rare
6776 occasions. sizeof is obviously inferior to offsetof here, so
6777 stick with offsetof.
6778 (GC_POINTER_ALIGNMENT): New macro.
6779 (mark_memory): Omit 3rd (offset) arg; caller changed.
6780 Don't assume EMACS_INT alignment is the same as pointer alignment.
6781
df1bbe5b
SM
67822011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6783
6784 * keyboard.c (read_key_sequence_remapped): New var.
6785 (read_key_sequence): Compute remapping in the right buffer.
6786 (command_loop_1): Use read_key_sequence's remapping directly.
6787
51553db6
SM
67882011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6789
32c1fffd
SM
6790 * dired.c (file_name_completion): Don't expand file name.
6791 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6792 before checking file name handler.
6793
51553db6
SM
6794 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6795 they've been requested explicitly (bug#9591).
6796
b6bd1599 67972011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6798
6799 * keymap.c (Fsingle_key_description): Use make_specified_string
6800 instead of build_string to build string from push_key_description.
6801 (Bug#5193)
6802
f701dc2a
PE
68032011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6804
4222c55d
PE
6805 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6806 This fixes a Y2038 bug on 64-bit hosts.
6807 * buffer.c (reset_buffer):
6808 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6809 (Fclear_buffer_auto_save_failure):
6810 Use 0, not -1, to represent an unset failure time, since time_t
6811 might not be signed.
6812
f701dc2a
PE
6813 Remove dependency on glibc malloc internals.
6814 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6815 Move back here from lisp.h, but with their new implementations.
6816 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6817 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6818 * charset.c (charset_table_init): New static var.
6819 (syms_of_charset): Use it instead of xmalloc. This removes a
6820 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6821 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6822 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6823 Move back to alloc.c.
6824 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6825 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6826
9ceebf39
JD
68272011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6828
6829 * nsterm.m (windowDidResize): Call x_set_window_size only when
6830 ns_in_resize is true. Otherwise set pixelwidth/height and
6831 call change_frame_size (Bug#9628).
6832
cb993c58
PE
68332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6834
3930c88b
PE
6835 Port --enable-checking=all to Fedora 14 x86-64.
6836 * charset.c (syms_of_charset): Also account for glibc malloc's
6837 internal overhead when calculating the initial malloc maximum.
6838
cb993c58
PE
6839 Port --enable-checking=all to Fedora 14 x86.
6840 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6841 Move to lisp.h.
6842 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6843 (overrun_check_realloc, overrun_check_free):
6844 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6845 That way, xmalloc returns a properly-aligned pointer even if
6846 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6847 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6848 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6849 into account when calculating the initial malloc maximum.
6850 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6851 Move here from alloc.c, so that charset.c can use it too.
6852 Properly align; the old code wasn't right for common 32-bit hosts
6853 when configured with --enable-checking=all.
6854 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6855 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6856
31bed486
EZ
68572011-09-29 Eli Zaretskii <eliz@gnu.org>
6858
04c70788 6859 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6860 use EDOM.
6861
fbcaa2f3
EZ
68622011-09-28 Eli Zaretskii <eliz@gnu.org>
6863
6864 * xdisp.c (compute_display_string_end): If there's no display
6865 string at CHARPOS, return -1.
6866
6867 * bidi.c (bidi_fetch_char): When compute_display_string_end
6868 returns a negative value, treat the character as a normal
6869 character not covered by a display string. (Bug#9624)
6870
a239d4e9
JB
68712011-09-28 Juanma Barranquero <lekktu@gmail.com>
6872
6873 * lread.c (Fread_from_string): Fix typo in docstring.
6874
88652fd5
EZ
68752011-09-27 Eli Zaretskii <eliz@gnu.org>
6876
6877 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6878 newline, reseat the iterator instead of bidi-iterating there one
6879 character at a time. (Bug#9610)
32c1fffd
SM
6880 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6881 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6882
ed497dd4
AS
68832011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6884
6885 * lread.c (readevalloop): Use correct code for NBSP.
6886 (read1): Likewise. (Bug#9608)
6887
b2bf61aa
MA
68882011-09-25 Michael Albinus <michael.albinus@gmx.de>
6889
6890 * dbusbind.c (Fdbus_register_signal): When service is not
6891 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6892
32bbb17c
GM
68932011-09-25 Glenn Morris <rgm@gnu.org>
6894
6895 * buffer.c (truncate-lines): Doc fix.
6896
94e0933e
CY
68972011-09-24 Chong Yidong <cyd@stupidchicken.com>
6898
6899 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6900 (Fset_window_next_buffers): Doc fix.
6901
cddde921
GM
69022011-09-24 Glenn Morris <rgm@gnu.org>
6903
6904 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6905
1260aef1
PE
69062011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6907
25b4bfa0
PE
6908 Fix minor problems found by static checking.
6909 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6910 * indent.c (Fvertical_motion): Fix == vs = typo.
6911
e3cbd34b
EZ
69122011-09-24 Eli Zaretskii <eliz@gnu.org>
6913
a66cfb1c
SM
6914 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6915 Default value is now t. Doc fix.
6bf7006f 6916
e3cbd34b 6917 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6918 logic when moving up, not only when moving down. Fix the
e3cbd34b 6919 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6920 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6921
6922 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6923 CHARPOS is covered by a display string which includes newlines.
6924 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6925 is covered by a display string with embedded newlines.
6926
a3de0cbd
MA
69272011-09-24 Michael Albinus <michael.albinus@gmx.de>
6928
6929 * dbusbind.c (Fdbus_register_signal): Add match rule to
6930 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6931 (Fdbus_register_method, Vdbus_registered_objects_table):
6932 Fix docstring.
a3de0cbd 6933
b260039d
JM
69342011-09-24 Jim Meyering <meyering@redhat.com>
6935
32c1fffd 6936 do not ignore write error for any output size
b260039d
JM
6937 The previous change was incomplete.
6938 While it makes emacs --batch detect the vast majority of stdout
6939 write failures, errors were still ignored whenever the output size is
6940 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6941 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6942 && echo FAIL: ignored write error
6943 FAIL: ignored write error
6944 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6945 && echo FAIL: ignored write error
6946 FAIL: ignored write error
6947 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6948
8eca8a7c
AS
69492011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6950
6951 * emacs.c (Fkill_emacs): In noninteractive mode exit
6952 non-successfully if a write error occurred on stdout. (Bug#9574)
6953
3341db62
EZ
69542011-09-21 Eli Zaretskii <eliz@gnu.org>
6955
6956 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6957 the xassert test.
6958
6959 * dispextern.h (struct it): Update the comment documenting what
6960 can it->OBJECT be.
6961
8c203dbf
EZ
69622011-09-20 Eli Zaretskii <eliz@gnu.org>
6963
6964 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6965 a display string, extend search for cursor position to end of row.
6966 (find_row_edges): If the row ends in a newline from a display
6967 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6968 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6969 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6970 non-empty line. Fixes confusing cursor motion with arrow keys at
6971 the beginning of a line that starts with whitespace.
8c203dbf 6972
a4824228
LMI
69732011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6974
6975 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6976 (bug#9493).
6977
33ed493b
CY
69782011-09-18 Chong Yidong <cyd@stupidchicken.com>
6979
6980 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6981 boolean (Bug#9154).
6982
56cd55c8
EZ
69832011-09-18 Eli Zaretskii <eliz@gnu.org>
6984
6985 * xdisp.c (display_line): Record maximum and minimum buffer
6986 positions even if no glyphs were produced (e.g., by a zero-width
6987 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6988 buffer positions that will be removed from the glyph row because
6989 they don't fit.
c02dcedf
EZ
6990 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6991 column is beyond frame width: don't subtract 1 "pixel" when
6992 computing width of the stretch.
3e62b7e0
EZ
6993 (reseat_at_next_visible_line_start): Undo the change made on
6994 2011-09-17 that saved paragraph information and restored it after
6995 the call to `reseat'. (Bug#9545)
56cd55c8 6996
5ed99d36 69972011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6998
6999 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7000 and turn window cursor on if cleared (Bug#9415).
7001
5ed99d36 70022011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7003
7004 * search.c (boyer_moore): Take unibyte characters from pattern
7005 literally. (Bug#9458)
7006
9bade7b2
EZ
70072011-09-18 Eli Zaretskii <eliz@gnu.org>
7008
7009 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7010
e5e9d610
PE
70112011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7012
87e4427a
PE
7013 Fix minor problem found by static checking.
7014 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7015 initialized, to pacify gcc -Wuninitialized.
7016
e5e9d610
PE
7017 * fileio.c: Report proper errno when syscall falls.
7018 (Finsert_file_contents): Save and restore errno,
7019 so that report_file_error outputs the correct diagnostic.
7020 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7021
a1674f0b
EZ
70222011-09-18 Eli Zaretskii <eliz@gnu.org>
7023
7024 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7025
fbfb6dd4
EZ
70262011-09-17 Eli Zaretskii <eliz@gnu.org>
7027
7028 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7029 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7030
bb187662
EZ
70312011-09-17 Eli Zaretskii <eliz@gnu.org>
7032
1137e8b8 7033 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7034 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7035
7036 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7037 (bidi_find_paragraph_start): Search back for paragraph beginning
7038 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7039 (bidi_move_to_visually_next): Only trigger paragraph-related
7040 computations when the last character is a newline or at EOB, not
7041 just any NEUTRAL_B. (Bug#9470)
7042
bb187662
EZ
7043 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7044 truncated lines if point is covered by a display string. (Bug#9524)
7045
2e621251
PE
70462011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7049 (cons_to_x_long): New function.
7050 (lisp_data_to_selection_data): Use it. Correct the test for
7051 short-versus-long data; it was negated. Break out of vector
7052 loop, for efficiency, when a long datum is discovered.
7053
91a15bc6
SM
70542011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7055
7056 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7057
b41c3a35
EZ
70582011-09-16 Eli Zaretskii <eliz@gnu.org>
7059
7060 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7061 GCC PR/17406) by declaring this function with external scope.
7062
7812ba2d
PE
70632011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7064
7065 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7066 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7067
cf7edc2a
AS
70682011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7069
7070 * editfns.c (Fformat): Correctly handle text properties on "%%".
7071
bd01620e
EZ
70722011-09-15 Eli Zaretskii <eliz@gnu.org>
7073
7074 * xterm.c (x_draw_composite_glyph_string_foreground):
7075 * w32term.c (x_draw_composite_glyph_string_foreground):
7076 * term.c (encode_terminal_code):
7077 * composite.c (composition_update_it, get_composition_id):
7078 * xdisp.c (get_next_display_element)
7079 (fill_composite_glyph_string): Add comments about special meaning
7080 of TAB characters in a composition.
7081
a02719a3
PE
70822011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7083
7084 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7085 This occurs when processing a multibyte format.
7086 Problem reported by Wolfgang Jenker.
a02719a3 7087
72589a3c
JB
70882011-09-15 Johan Bockgård <bojohan@gnu.org>
7089
7090 * xdisp.c (try_cursor_movement): Only check for exact match if
7091 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7092
1c14176c
PE
70932011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7094
7095 Remove unused external symbols.
7096 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7097 * xdisp.c (calc_pixel_width_or_height): Now static.
7098 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7099 * indent.c (check_display_width):
7100 * w32term.c: Fix comment to match code.
7101 * xterm.c, xterm.h (x_catching_errors): Remove.
7102
d2eea5b5
PE
71032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7104
7105 * xselect.c: Use signed conversions more consistently (Bug#9498).
7106 (selection_data_to_lisp_data): Assume incoming selection data are
7107 signed integers, not unsigned. This is to be consistent with
7108 outgoing selection data, which was modified to use signed integers
7109 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7110 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7111 expects long, not unsigned long.
7112
46888499
EZ
71132011-09-14 Eli Zaretskii <eliz@gnu.org>
7114
7115 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7116 computation of loop end. Reported by Johan Bockgård
7117 <bojohan@gnu.org>.
7118
ef8ef9fb
CY
71192011-09-13 Chong Yidong <cyd@stupidchicken.com>
7120
7121 * frame.c (Fother_visible_frames_p): Function deleted.
7122
fa819fed
EZ
71232011-09-12 Eli Zaretskii <eliz@gnu.org>
7124
7125 * indent.c (compute_motion): Process display vector front to back
7126 rather than the other way around. (Bug#2496)
7127
2ba8e008
SM
71282011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7129
7130 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7131
20f53c69
CY
71322011-09-11 Chong Yidong <cyd@stupidchicken.com>
7133
7134 * minibuf.c (Fread_from_minibuffer): Doc fix.
7135
d562d7a4
EZ
71362011-09-11 Eli Zaretskii <eliz@gnu.org>
7137
7138 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7139 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7140
1c4d7f3d
LMI
71412011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7142
7143 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7144 value for non-existent files.
7145
b885bf36
EZ
71462011-09-11 Eli Zaretskii <eliz@gnu.org>
7147
7148 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7149 set its "size" to -1. This will set the modtime_size field of
7150 the corresponding buffer to -1, which is what
7151 verify-visited-file-modtime expects for files that do not exist.
7152 (Bug#9139)
7153
6612f0bf
PE
71542011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7155
7156 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7157 here ...
7158 * lisp.h: ... from here. push_key_description is no longer
7159 defined in keyboard.c, so its declaration should not be in
7160 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7161 logically belongs with push_key_description.
7162
dfb3f755
PE
71632011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7164
7165 * buffer.h: Include <sys/types.h> instead of <time.h>.
7166 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7167 Problem reported by Herbert J. Skuhra.
7168
3134906c
LMI
71692011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7170
7171 * xml.c (parse_region): Make the parsing work for
7172 non-comment-starting XML files again (bug#9144).
7173
8d903f4e
AS
71742011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7175
7176 * image.c (gif_load): Fix calculation of bottom and right corner.
7177 (Bug#9468)
7178
80ad64f4
EZ
71792011-09-10 Eli Zaretskii <eliz@gnu.org>
7180
7181 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7182 redisplay in small windows.
7183
208a048d
EZ
71842011-09-09 Eli Zaretskii <eliz@gnu.org>
7185
7186 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7187
9b1c252e
MR
71882011-09-08 Martin Rudalics <rudalics@gmx.at>
7189
7190 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7191 Operate on live windows only.
7192
2949f33b
JB
71932011-09-08 Juanma Barranquero <lekktu@gmail.com>
7194
7195 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7196
e08dcafd
EZ
71972011-09-07 Eli Zaretskii <eliz@gnu.org>
7198
7199 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7200 only under bidi iteration.
7201
115b96bd
JD
72022011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7203
7204 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7205
c8199d0f
PE
72062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7207
7208 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7209 Without this fix, the command to link temacs failed due to an
7210 undefined symbol __builtin_isnan. This is because
7211 /usr/include/iso/math_c99.h #defines isnan(x) to
7212 __builtin_isnan(x), but the bundled gcc, which identifies itself
7213 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7214 a __builtin_isnan.
7215 * floatfns.c (isnan): #undef, and then #define to a clone of
7216 what's in data.c.
7217 (Fisnan): Always define, since it's always available now.
7218 (syms_of_floatfns): Always define isnan at the Lisp level.
7219
e39b275c 72202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7221
7222 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7223
b2db44d9 72242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7225
f4af5137 7226 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7227 The previous code assumed that file offsets (off_t values) fit in
7228 EMACS_INT variables, which is not true on typical 32-bit hosts.
7229 The code messed up by falsely reporting buffer overflow in cases
7230 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7231 when "big" contains more than 2**29 bytes, even though this
7232 inserts just one byte and does not overflow the buffer.
7233 (Finsert_file_contents): Store file offsets as off_t
7234 values, not as EMACS_INT values. Check for overflow when
7235 converting between EMACS_INT and off_t. When checking for
7236 buffer overflow or for overlap, take the offsets into account.
7237 Don't use EMACS_INT for small values where int suffices.
7238 When checking for overlap, fix a typo: ZV was used where
7239 ZV_BYTE was intended.
7240 (Fwrite_region): Don't assume off_t fits into 'long'.
7241 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7242
ecfc0a49
MA
72432011-09-05 Michael Albinus <michael.albinus@gmx.de>
7244
7245 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7246
6511acf2 72472011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7248
0999621a 7249 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7250
7251 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7252 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7253 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7254 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7255 (modify_event_symbol): Do not assume that the length of
7256 name_alist_or_stem is safe to alloca and fits in int.
7257 (Fexecute_extended_command): Likewise for function name and binding.
7258 (Frecursion_depth): Wrap around reliably on integer overflow.
7259 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7260 since some callers pass EMACS_INT values.
7261 (Fsingle_key_description): Don't crash if symbol name contains more
7262 than MAX_ALLOCA bytes.
7263 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7264 (get_minibuffer): Arg is now EMACS_INT, not int.
7265 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7266 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7267 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7268
2be7d702
PE
7269 * dbusbind.c (signature_cat): New function.
7270 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7271 Do not overrun buffer; instead, report string overflow.
7272
9d1df220
PE
7273 * dispnew.c (add_window_display_history): Don't overrun buffer.
7274 Truncate instead; this is OK since it's just a log.
7275
33ef5c64
PE
7276 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7277 even if the time zone offset is outlandishly large.
7278 Don't mishandle offset == INT_MIN.
7279
66c6fdd5
PE
7280 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7281 when creating daemon; the previous buffer-overflow check was incorrect.
7282
d749b01b
PE
7283 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7284 which has the guts of the old verror function.
7285
b5cd1905
PE
7286 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7287 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7288
6e1a67fb
PE
7289 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7290 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7291 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7292 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7293 length of string rather than counting it via multiple sprintfs;
7294 that's simpler and more reliable.
c21721cc
PE
7295 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7296 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7297 sprintf, in case result does not fit in int.
7298
c57b67fc
PE
7299 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7300 (fontset_from_font): Print it.
7301
8a401434
PE
7302 * frame.c (tty_frame_count): Now printmax_t, not int.
7303 (make_terminal_frame, set_term_frame_name): Print it.
7304 (x_report_frame_params): In X, window IDs are unsigned long,
7305 not signed long, so print them as unsigned.
7306 (validate_x_resource_name): Check for implausibly long names,
7307 and don't assume name length fits in 'int'.
7308 (x_get_resource_string): Don't blindly alloca invocation name;
7309 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7310 not fit in int.
7311
6e1a67fb
PE
7312 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7313 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7314 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7315
0df02bf3
PE
7316 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7317 Use esprintf, not sprintf, in case result does not fit in int.
7318
48e30793
PE
7319 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7320 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7321 it as a large positive number.
7322 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7323 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7324
a66ff6d8
PE
7325 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7326 in case result does not fit in int.
7327
aca216ff
PE
7328 * print.c (float_to_string): Detect width overflow more reliably.
7329 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7330 buffer overrun. Don't assume list length fits in 'int'. Treat
7331 print length of 0 as 0, not as infinity; to be consistent with other
7332 uses of print length in this function. Don't overflow print length
7333 index. Don't assume hash table size fits in 'long', or that
7334 vectorlike size fits in 'unsigned long'.
7335
31c286f7
PE
7336 * process.c (make_process): Use printmax_t, not int, to format
7337 process-name gensyms.
7338
55e5faa1
PE
7339 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7340
80f2e268
PE
7341 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7342 to avoid potential buffer overrun.
7343
670741ab
PE
7344 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7345 if X resource line is longer than 512 bytes.
7346
b7163a50
PE
7347 * xfns.c (x_window): Make sprintf buffer a bit bigger
7348 to avoid potential buffer overrun.
7349
ae58ff1f
PE
7350 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7351
c43c8a6a
PE
7352 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7353
3f8236f4
PE
73542011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7355
53e9fe90 7356 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7357 Without these, Emacs silently mishandles large integers sometimes.
7358 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7359 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7360
6511acf2
PE
7361 * xdisp.c (try_window_id): Check Emacs fixnum range before
7362 converting to 'int'.
806add1d 7363
6511acf2 7364 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7365 Check that an Emacs fixnum is in range before assigning it to 'int'.
7366 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7367 values converted from Emacs fixnums.
7368 (Frecenter): Don't wrap around a line count if it is out of 'int'
7369 range; instead, treat it as an extreme value.
7370 (Fset_window_configuration, compare_window_configurations):
7371 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7372
6511acf2
PE
7373 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7374 that can exceed INT_MAX. Check that EMACS_INT value is in range
7375 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7376 (match_limit): Don't assume that a fixnum can fit in 'int'.
7377
6511acf2 7378 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7379 exceed INT_MAX.
7380
6511acf2 7381 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7382 (Fvertical_motion): Don't wrap around LINES values that don't fit
7383 in 'int'. Instead, treat them as extreme values. This is good
7384 enough for windows, which can't have more than INT_MAX lines anyway.
7385
fcb901a7
LMI
73862011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7387
0f2f6b6d
LMI
7388 * Require libxml/parser.h to avoid compilation warning.
7389
fcb901a7
LMI
7390 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7391
7392 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7393 since this reportedly can destroy thread storage.
7394
6e20a0d4
CY
73952011-08-30 Chong Yidong <cyd@stupidchicken.com>
7396
7397 * syntax.c (find_defun_start): Update all cache variables if
7398 exiting early (Bug#9401).
7399
148ae00e
EZ
74002011-08-30 Eli Zaretskii <eliz@gnu.org>
7401
f6cfbd8f
EZ
7402 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7403
148ae00e
EZ
7404 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7405 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7406 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7407
7408 * term.c (tty_append_glyph): New function.
7409 (produce_stretch_glyph): Static function and its prototype deleted.
7410
a66cfb1c
SM
7411 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7412 Add prototypes.
148ae00e 7413
c4a07a4c
PE
74142011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7415
7416 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7417 when checking :margin (Bug#9390).
7418 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7419 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7420 so that the name doesn't mislead. All uses changed.
7421
6bc8cd65
JB
74222011-08-28 Johan Bockgård <bojohan@gnu.org>
7423
7424 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7425 set_tty_hooks.
7426
dca4927e
EZ
74272011-08-27 Eli Zaretskii <eliz@gnu.org>
7428
7429 * xdisp.c (move_it_to): Don't bail out early when reaching
7430 position beyond to_charpos, if we are scanning backwards.
7431 (move_it_vertically_backward): When DY == 0, make sure we get to
7432 the first character in the line after the newline.
7433
f2cad773
PE
74342011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7435
7436 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7437 (ccl_driver): Do not generate an out-of-range pointer.
7438 (Fccl_execute_on_string): Remove unnecessary check for
7439 integer overflow, noted by Stefan Monnier in
7440 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7441 Remove a FIXME that didn't need fixing.
7442 Simplify the newly-introduced buffer reallocation code.
7443
0cae2cdb
JB
74442011-08-27 Juanma Barranquero <lekktu@gmail.com>
7445
7446 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7447
5fc295a4 74482011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7449
70c60eb2 7450 Integer and memory overflow issues (Bug#9196).
726e0ab1 7451
d31850da
PE
7452 * doc.c (get_doc_string): Rework so that
7453 get_doc_string_buffer_size is the actual buffer size, rather than
7454 being 1 less than the actual buffer size; this makes xpalloc more
7455 convenient.
7456
a69fbedb
PE
7457 * image.c (x_allocate_bitmap_record, cache_image):
7458 * xselect.c (Fx_register_dnd_atom):
7459 Simplify previous changes by using xpalloc.
7460
fe5c5d37
PE
7461 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7462 since either will do and ptrdiff_t is convenient with xpalloc.
7463
0065d054
PE
7464 * charset.c (charset_table_size)
7465 (struct charset_sort_data.priority): Now ptrdiff_t.
7466 (charset_compare): Don't overflow if priorities differ greatly.
7467 (Fsort_charsets): Don't assume list length fits in int.
7468 Check for size-calculation overflow when allocating sort data.
7469 (syms_of_charset): Allocate an initial charset table that is
7470 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7471
7472 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7473
7474 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7475 The actual value is always <= INT_MAX, and leaving it unsigned made
7476 overflow checking harder.
7477
7478 * dispextern.h (struct glyph_matrix.rows_allocated)
7479 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7480 with xpalloc. The values are still always <= INT_MAX.
7481
7482 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7483
7484 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7485 (SAFE_NALLOCA): New macro.
7486
7487 * region-cache.c (struct boundary.pos, find_cache_boundary)
7488 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7489 (set_cache_region, invalidate_region_cache)
7490 (revalidate_region_cache, know_region_cache, region_cache_forward)
7491 (region_cache_backward, pp_cache):
7492 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7493 so that ptrdiff_t * can be passed to xpalloc.
7494 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7495 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7496 (pp_cache): Don't assume cache_len fits in int.
7497 * region-cache.h: Adjust extern decls to match.
7498
7499 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7500 EMACS_INT, since either will do, for xpalloc.
7501
7502 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7503 (xnmalloc, xnrealloc, xpalloc): New functions.
7504
726e0ab1
PE
7505 * bidi.c (bidi_shelve_header_size): New constant.
7506 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7507 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7508
51f30bc5 7509 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7510 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7511 (overlay_strings):
7512 Don't update size of array until after memory allocation succeeds,
7513 because xmalloc/xrealloc may not return.
0065d054
PE
7514 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7515 now that we have proper integer overflow checking.
7516 (record_overlay_string, overlay_strings): Catch overflows when
7517 calculating size of overlay_str_buf.
726e0ab1 7518
0065d054
PE
7519 * callproc.c (Fcall_process): Check for size overflow when
7520 calculating size of args2.
7521 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7522 Normally we prefer signed values, but sticking with ptrdiff_t would
7523 require adding more-complicated checks.
726e0ab1
PE
7524
7525 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7526 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7527 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7528 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7529
7530 * character.c (Fstring): Check for size-calculation overflow.
7531
7532 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7533 unnecessary integer overflow. Check for size overflow.
7534 (encode_coding_object): Don't update size until xmalloc succeeds.
7535
7536 * composite.c (get_composition_id): Check for overflow in glyph
7537 length calculations.
7538
7539 Integer and memory overflow fixes for display code.
7540 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7541 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7542 (scrolling_window): Check for overflow in size calculations.
7543 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7544 Don't assume glyph table len fits in int.
7545 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7546 (row_table_size): Now ptrdiff_t, not int.
7547 (scrolling_window): Avoid overflow in size calculations.
7548 Don't update size until allocation succeeds.
7549 * fns.c (concat): Check for overflow in size calculations.
7550 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7551 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7552 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7553
7554 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7555 (get_doc_string): Check for size calculation overflow.
7556 Don't update size until allocation succeeds.
7557 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7558 EMACS_INT, where ptrdiff_t will do.
7559 (Fsubstitute_command_keys): Check for string overflow.
7560
7561 * editfns.c (set_time_zone_rule): Don't assume environment length
7562 fits in int.
7563 (message_length): Now ptrdiff_t, not int.
7564 (Fmessage_box): Don't update size until allocation succeeds.
7565 Don't assume message length fits in int.
7566 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7567
0065d054
PE
7568 * emacs.c (main): Do not reallocate argv, since there is a null at
7569 the end that can be overwritten, and this way there's no need to
7570 worry about size-calculation overflow.
7571 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7572
7573 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7574 alloc succeeds.
7575 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7576
7577 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7578 (x_set_scroll_bar_width, x_figure_window_size):
7579 Check for integer overflow.
7580 (x_set_alpha): Do not assume XINT fits in int.
7581
7582 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7583 This is for the members text_lines, text_cols, total_lines, total_cols,
7584 where the system imposes an 'int' limit.
7585
7586 * fringe.c (Fdefine_fringe_bitmap):
7587 Don't update size until alloc works.
7588
7589 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7590 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7591
7592 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7593 Check for size-calculation overflow.
7594 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7595 do, as we prefer signed integers.
7596 (id_to_widget.max_size, id_to_widget.used)
7597 (xg_store_widget_in_map, xg_remove_widget_from_map)
7598 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7599 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7600 Use and return ptrdiff_t, not int.
7601 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7602 * gtkutil.h: Change prototypes to match the above.
7603
7604 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7605 are duplicate now that they've been promoted to lisp.h.
7606 (x_allocate_bitmap_record, x_alloc_image_color)
7607 (make_image_cache, cache_image, xpm_load):
7608 Don't update size until alloc is done.
7609 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7610 (x_detect_edges):
3256efce 7611 Check for size calculation overflow.
726e0ab1
PE
7612 (ct_colors_allocated_max): New constant.
7613 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7614 overflow.
3256efce 7615
726e0ab1
PE
7616 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7617 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7618 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7619 Use ptrdiff_t, not int, to count maps.
7620 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7621 calculations. Don't update size until allocation succeeds.
7622 Redo calculations to avoid overflow.
726e0ab1
PE
7623 * keyboard.h: Change prototypes to match the above.
7624
7625 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7626 to count maps.
7627 (current_minor_maps): Check for size calculation overflow.
7628 * keymap.h: Change prototypes to match the above.
7629
7630 * lread.c (read1, init_obarray): Don't update size until alloc done.
7631
7632 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7633 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7634
726e0ab1
PE
7635 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7636 Now ptrdiff_t, not int.
7637 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7638 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7639
7640 * process.c (Fnetwork_interface_list): Check for overflow
7641 in size calculation.
7642
7643 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7644
7645 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7646 overflow. Don't bother calling xmalloc when xrealloc will do.
7647
7648 * search.c (Freplace_match): Check for size calculation overflow.
7649 (Fset_match_data): Don't assume list lengths fit in 'int'.
7650
7651 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7652 for command line length. Do not attempt to address one before the
7653 beginning of an array, as that's not portable.
7654
7655 * term.c (max_frame_lines): Remove; unused.
7656 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7657 not int.
7658 (encode_terminal_code, calculate_costs): Check for size
7659 calculation overflow.
7660 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7661 table lengths and related sizes. Don't update size until alloc
7662 done. Redo calculations to avoid overflow.
7663 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7664
7665 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7666 subtracting pointers.
7667 (gobble_line): Check for overflow more carefully. Don't update size
7668 until alloc done.
7669
7670 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7671 Don't update size until alloc done.
7672 Redo size calculations to avoid overflow.
7673 Check for size calculation overflow.
0065d054 7674 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7675
7676 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7677 Use ptrdiff_t, not int, for sizes.
7678 (store_mode_line_noprop_char): Don't update size until alloc done.
7679
0065d054
PE
7680 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7681 Use ptrdiff_t, not int, for sizes.
7682 (Finternal_make_lisp_face, cache_face):
7683 Check for size calculation overflow.
7684 (cache_face): Treat size calculation overflows as if they were
7685 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7686
7687 * xfns.c (x_encode_text, x_set_name_internal)
7688 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7689 sizes, since they can exceed INT_MAX in size. Check for size
7690 calculation overflow.
7691
0065d054
PE
7692 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7693 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7694 Don't update size until alloc done.
7695
0065d054 7696 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7697 as sprintf is limited to int lengths.
1d526e2f 7698
252c5ee1
PE
7699 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7700 (X_LONG_MIN): New macros.
864d7ce7
PE
7701 Use them to make the following changes clearer.
7702 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7703 This change doesn't affect the value now, but it may help remind
7704 future maintainers not to raise the value too much later.
7705 (SELECTION_QUANTUM): Remove, replacing with ...
7706 (selection_quantum): ... new function, which avoids overflow.
7707 All uses changed.
7708 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7709 assumption that selection length fits in 'int'.
7710 (x_reply_selection_request, x_handle_selection_request)
7711 (x_get_window_property, receive_incremental_selection)
7712 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7713 (lisp_data_to_selection_data, clean_local_selection_data):
7714 Use ptrdiff_t, not int, to record length of selection.
7715 (x_reply_selection_request, x_get_window_property)
7716 (receive_incremental_selection, x_property_data_to_lisp):
7717 Redo calculations to avoid overflow.
7718 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7719 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7720 something.
7721 (x_get_window_property, receive_incremental_selection)
7722 (lisp_data_to_selection_data, x_property_data_to_lisp):
7723 Check for size-calculation overflow.
7724 (x_get_window_property, receive_incremental_selection)
7725 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7726 Don't store size until memory allocation succeeds.
7727 (x_get_window_property): Plug memory leak on memory exhaustion.
7728 Don't double-block input; malloc is safe here. Don't assume 2**34
7729 - 4 fits in unsigned long. Add an xassert to check
7730 XGetWindowProperty overflow. Be more careful about overflow
7731 calculations, and distinguish size from memory overflow better.
7732 (receive_incremental_selection): When tracing, don't assume
7733 unsigned int is less than INT_MAX.
7734 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7735 harmful) conversions of unsigned short to int.
7736 (lisp_data_to_selection_data): Don't assume that integers
7737 in the range -65535 through -1 fit in an X unsigned short.
7738 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7739 result parameters unless successful. Rely on cons_to_unsigned
7740 to report problems with elements; the old code wasn't right anyway.
7741 (x_check_property_data): Check for int overflow; we cannot use
7742 a wider type due to X limits.
7743 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7744
726e0ab1 7745 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7746
0065d054
PE
7747 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7748 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7749 (x_color_cells): Don't store size until memory allocation succeeds.
7750 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7751 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7752 (x_term_init): Don't assume length fits in int (sprintf is limited
7753 to int size).
bc18e09d 7754
ebfa62c0
PE
7755 Use ptrdiff_t for composition IDs.
7756 * character.c (lisp_string_width):
7757 * composite.c (composition_table_size, n_compositions)
7758 (get_composition_id, composition_gstring_from_id):
7759 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7760 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7761 * window.c (Frecenter):
7762 Use ptrdiff_t, not int, for composition IDs.
7763 * composite.c (get_composition_id): Check for integer overflow.
7764 * composite.h: Adjust prototypes to match the above changes.
7765
d3411f89
PE
7766 Use ptrdiff_t for hash table indexes.
7767 * category.c (hash_get_category_set):
7768 * ccl.c (ccl_driver):
7769 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7770 * coding.c (coding_system_charset_list, detect_coding_system):
7771 * coding.h (struct coding_system.id):
7772 * composite.c (get_composition_id, gstring_lookup_cache):
7773 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7774 * image.c (xpm_get_color_table_h):
7775 * lisp.h (hash_lookup, hash_put):
7776 * minibuf.c (Ftest_completion):
7777 Use ptrdiff_t for hash table indexes, not int (which is too
7778 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7779 32-bit --with-wide-int hosts).
7780
e097a6fa
PE
7781 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7782 Add a FIXME comment about memory leaks.
7783 (syms_of_charset): Don't assume xmalloc returns.
7784
5637687f
PE
7785 Don't assume that stated character widths fit in int.
7786 * character.c (Fchar_width, c_string_width, lisp_string_width):
7787 * character.h (CHAR_WIDTH):
7788 * indent.c (MULTIBYTE_BYTES_WIDTH):
7789 Use sanitize_char_width to avoid undefined and/or bad behavior
7790 with outlandish widths.
a66cfb1c 7791 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7792 now that we have two such functions. All uses changed.
7793 (sanitize_char_width): New inline function.
7794
a2271ba2
PE
7795 Don't assume that tab-width fits in int.
7796 * character.h (sanitize_width): New inline function.
7797 (SANE_TAB_WIDTH): New macro.
7798 (ASCII_CHAR_WIDTH): Use it.
7799 * indent.c (sane_tab_width): Remove. All uses replaced by
7800 SANE_TAB_WIDTH (current_buffer).
7801 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7802
18c52557
PE
7803 * fileio.c: Integer overflow issues with file modes.
7804 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7805
caeeedc1
PE
7806 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7807 Remove unreachable code.
7808 (read_hex, load_charset_map_from_file): Check for integer overflow.
7809
6df6ae42 7810 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7811 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7812 (x_send_scroll_bar_event): Likewise. Check that the size does not
7813 exceed limits imposed by XClientMessageEvent, as well as the usual
7814 ptrdiff_t and size_t limits.
7815
b13995db
PE
7816 * keyboard.c: Overflow, signedness and related fixes.
7817 (make_lispy_movement): Use same integer type in forward decl
7818 that is used in the definition.
7819 (read_key_sequence, keyremap_step):
7820 Change bufsize argument back to int, undoing my 2011-03-30 change.
7821 We prefer signed types, and int is wide enough here.
7822 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7823 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7824 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7825 length, not size_t. Use ptrdiff_t for index, not int.
7826 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7827 possibility of integer overflow.
7828
13464394
PE
7829 Overflow, signedness and related fixes for images.
7830
7831 * dispextern.h (struct it.stack[0].u.image.image_id)
7832 (struct_it.image_id, struct image.id, struct image_cache.size)
7833 (struct image_cache.used, struct image_cache.ref_count):
7834 * gtkutil.c (update_frame_tool_bar):
7835 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7836 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7837 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7838 * nsmenu.m (update_frame_tool_bar):
7839 * xdisp.c (calc_pixel_width_or_height):
7840 * xfns.c (image_cache_refcount):
7841 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7842 on typical 64-bit hosts.
7843
7844 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7845 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7846 Omit unnecessary casts to int.
7847 (parse_image_spec): Check that integers fall into 'int' range
7848 when the callers expect that.
7849 (image_ascent): Redo ascent calculation to avoid int overflow.
7850 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7851 (lookup_image): Remove unnecessary tests.
7852 (xbm_image_p): Locals are now of int, not EMACS_INT,
7853 since parse_image_check makes sure they fit into int.
7854 (png_load, gif_load, svg_load_image):
7855 Prefer int to unsigned where either will do.
7856 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7857 old tiff_error_handler and tiff_warning_handler.
7858 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7859 stack buffer overflows. It uses only the features of vsnprintf
7860 that are common to both POSIX and native Microsoft.
7861 (tiff_error_handler, tiff_warning_handler): Use it.
7862 (tiff_load, gif_load, imagemagick_load_image):
7863 Don't assume :index value fits in 'int'.
7864 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7865 (imagemagick_load_image): Check that crop parameters fit into
7866 the integer types that MagickCropImage accepts. Don't assume
7867 Vimagemagick_render_type has a nonnegative value. Don't assume
7868 size_t fits in 'long'.
7869 (gs_load): Use printmax_t to print the widest integers possible.
7870 Check for integer overflow when computing image height and width.
7871
c11821d4
EZ
78722011-08-26 Eli Zaretskii <eliz@gnu.org>
7873
7874 * xdisp.c (redisplay_window): Don't force window start if point
7875 will be invisible in the resulting window. (Bug#9324)
7876
0c95fcf7
EZ
78772011-08-25 Eli Zaretskii <eliz@gnu.org>
7878
7879 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7880 the display spec is of the form `(space ...)'.
7881 (handle_display_spec): Return the value returned by
7882 handle_single_display_spec, not just 1 or zero.
7883 (handle_single_display_spec): If the display spec is of the form
7884 `(space ...)', and specifies display in the text area, return 2
7885 rather than 1.
fee65a97 7886 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7887 accurately, and prefer exact match for point under bidi.
7888 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7889
7890 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7891 into disp_prop; all users changed.
7892
7893 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7894 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7895 for the text covered by the display property.
7896
e4ed06f1
CY
78972011-08-25 Chong Yidong <cyd@stupidchicken.com>
7898
7899 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7900 Change return value to nil.
7901 (Frecord_buffer): Delete unused function.
7902
f67cdd7f
EZ
79032011-08-24 Eli Zaretskii <eliz@gnu.org>
7904
5980d4c6
EZ
7905 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7906 buffers, return left-to-right.
8610fe8b
EZ
7907 (set_cursor_from_row): Consider candidate row a win if its glyph
7908 represents a newline and point is on that newline. Fixes cursor
7909 positioning on the newline at EOL of R2L text within L2R
7910 paragraph, and vice versa.
7911 (try_cursor_movement): Check continued rows, in addition to
7912 continuation rows. Fixes unwarranted scroll when point enters a
7913 continued line of R2L text within an L2R paragraph, or vice versa.
7914 (cursor_row_p): Consider the case of point being equal to
7915 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7916 from the end of a short line to the beginning of a continued line
7917 of R2L text within L2R paragraph.
7918 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7919 composed characters.
5980d4c6 7920
f67cdd7f
EZ
7921 * bidi.c (bidi_check_type): Use xassert.
7922 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7923 members.
7924
bca633fb
EZ
79252011-08-23 Eli Zaretskii <eliz@gnu.org>
7926
7927 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7928 a character.
7929
4a5885a7
CY
79302011-08-23 Chong Yidong <cyd@stupidchicken.com>
7931
7932 * nsfont.m (ns_otf_to_script): Fix typo.
7933
0902a04e
KH
79342011-08-22 Kenichi Handa <handa@m17n.org>
7935
7936 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7937 extra slot even if the purpose is char-code-property-table.
7938
1a2e6670
EZ
79392011-08-23 Eli Zaretskii <eliz@gnu.org>
7940
8ddde651
EZ
7941 * xdisp.c (redisplay_window): When computing centering_position,
7942 account for the height of the header line. (Bug#8874)
7943
425cc014
EZ
7944 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7945 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7946 candidate is selected by the mouse, and that candidate has a
7947 composed character under the mouse.
7948
1a2e6670
EZ
7949 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7950 coordinates reported by pos-visible-in-window-p for a composed
7951 character in column zero.
7952
8b76d6f8
SM
79532011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7954
7955 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7956
dac347dd
EZ
79572011-08-22 Eli Zaretskii <eliz@gnu.org>
7958
7959 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7960 consider it a hit if to_charpos is anywhere in the range of the
7961 composed buffer positions.
7962
e013fb34
CY
79632011-08-22 Chong Yidong <cyd@stupidchicken.com>
7964
7965 * image.c (gif_load): Don't assume that each subimage has the same
7966 dimensions as the base image. Handle disposal method that is
7967 "undefined" by the gif spec (Bug#9335).
7968
bd1ba3e8
CY
79692011-08-20 Chong Yidong <cyd@stupidchicken.com>
7970
7971 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7972 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7973
54a1215b
EZ
79742011-08-19 Eli Zaretskii <eliz@gnu.org>
7975
823564e5
EZ
7976 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7977 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7978 from an Org mode buffer to a Speedbar frame.
7979
54a1215b
EZ
7980 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7981 a composition, take its buffer position from IT->cmp_it.charpos.
7982 Fixes cursor positioning at the beginning of a line that begins
7983 with a composed character.
7984
9778ebcc
EZ
79852011-08-18 Eli Zaretskii <eliz@gnu.org>
7986
0be6ee06
EZ
7987 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7988 character bidirectional type, use STRONG_L instead. Fixes crashes
7989 in a buffer produced by `describe-categories'.
7990
9778ebcc
EZ
7991 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7992 members before the level stack, so they would be saved and
7993 restored when copying iterator state. Fixes incorrect reordering
7994 around TABs covered by display properties.
7995
156bffbe
AS
79962011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7997
6b02f655 7998 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7999
72ad093b
CY
80002011-08-17 Chong Yidong <cyd@stupidchicken.com>
8001
8002 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8003 (internal_condition_case_2, internal_condition_case_n):
8004 Remove unnecessary aborts (Bug#9081).
72ad093b 8005
35774242
EZ
80062011-08-17 Eli Zaretskii <eliz@gnu.org>
8007
8008 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8009 has no `load' handler, try opening the file locally. (Bug#9311)
8010
db76dd85
KB
80112011-08-16 Ken Brown <kbrown@cornell.edu>
8012
8013 * gmalloc.c: Expand comment.
8014
b215eee5
EZ
80152011-08-16 Eli Zaretskii <eliz@gnu.org>
8016
8017 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8018 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8019
a4579d33
KB
80202011-08-16 Ken Brown <kbrown@cornell.edu>
8021
8022 Fix memory allocation problems in Cygwin build (Bug#9273).
8023
8024 * unexcw.c ( __malloc_initialized): Declare external variable.
8025 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8026
8b76d6f8
SM
8027 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8028 New variables.
a4579d33
KB
8029 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8030 dumped emacs.
8031 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8032 in the static heap.
8033 [CYGWIN] (special_realloc): New function.
8034 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8035 requests to realloc storage in the static heap.
8036
3ebec551
PE
80372011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8038
8039 * bidi.c (bidi_initialize): Remove unused local.
8040
9fd8be00
EZ
80412011-08-15 Eli Zaretskii <eliz@gnu.org>
8042
6b02f655
SM
8043 * bidimirror.h:
8044 * biditype.h: Remove file.
8045 * makefile.w32-in ($(BLD)/bidi.$(O)):
8046 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8047
8048 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8049
8050 * chartab.c: Improve commentary for the uniprop_table API.
8051
32413314
EZ
8052 * bidi.c (bidi_paragraph_init): Support zero value of
8053 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8054 (bidi_initialize): Use uniprop_table instead of including
8055 biditype.h and bidimirror.h.
32413314 8056
9fd8be00
EZ
8057 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8058 coordinates of the iterator when restoring from ppos_it.
8059 (Bug#9296)
8060
5cf2b69b
KH
80612011-08-14 Kenichi Handa <handa@m17n.org>
8062
8063 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8064 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8065
daf17d00
EZ
80662011-08-14 Eli Zaretskii <eliz@gnu.org>
8067
8068 * xdisp.c (move_it_in_display_line_to): Don't invoke
8069 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8070 ppos_it. Fixes vertical cursor motion when line beginning is
8071 covered by an image. (Bug#9296)
8072
08e3161a
JD
80732011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8074
8075 * nsterm.h (ns_run_ascript): Declare.
8076 (NSAPP_DATA2_RUNASSCRIPT): Define.
8077
8078 * nsfns.m (as_script, as_result, as_status): New static variables.
8079 (ns_run_ascript): New function.
5e617bc2 8080 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8081 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8082 the event loop. Get status from as_status (Bug#7276).
8083
8084 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8085 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8086 the event loop (Bug#7276).
8087
a3720aa2
AS
80882011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8089
8090 * gnutls.c (QCgnutls_bootprop_priority)
8091 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8092 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8093 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8094 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8095 (QCgnutls_bootprop_verify_hostname_error)
8096 (QCgnutls_bootprop_callbacks_verify): Rename from
8097 Qgnutls_bootprop_..., all uses changed.
8098
8099 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8100 uses changed.
8101
0a0d27fb
PE
81022011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8103
19d5c50c
PE
8104 * xfaces.c (Qframe_set_background_mode): Now static.
8105 * dispextern.h (Qframe_set_background_mode): Remove decl.
8106
0a0d27fb
PE
8107 * process.c (Fnetwork_interface_info): Declare local only if needed.
8108
377538cb
JD
81092011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8110
8111 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8112 (Fnetwork_interface_list): Allocate in increments of bytes instead
8113 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8114 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8115 sockaddr.
8116 (struct ifflag_def): notrailers is smart on OSX.
8117 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8118 Get hardware address with getifaddrs if available.
8119
08fff70c
EZ
81202011-08-12 Eli Zaretskii <eliz@gnu.org>
8121
8122 * xdisp.c (iterate_out_of_display_property): xassert that
8123 IT->position is set to within IT->object's boundaries. Break from
8124 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8125 when IT->position is set up wrongly due to some bug.
8126 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8127 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8128 entry. Force push_it to save on the stack the current
8129 buffer/string position, to be restored by pop_it. Fix flags in
8130 the iterator structure wrt the object coming from a display
8131 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8132 properties. (Bug#9284)
8133
7be1c708 81342011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8135
7be1c708
CY
8136 * fontset.c (fontset_get_font_group): Add proper type checks.
8137 (Bug#9172)
aac0c6e3 8138
7be1c708 81392011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8140
7be1c708
CY
8141 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8142 and LC_VERSION_MIN_MACOSX.
8143 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8144 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8145
97bb72a6
EZ
81462011-08-08 Eli Zaretskii <eliz@gnu.org>
8147
8148 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8149 no-display-properties-and-no-overlays under bidi display.
8150 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8151 properties and overlays.
97bb72a6 8152
d5617611
CY
81532011-08-08 Chong Yidong <cyd@stupidchicken.com>
8154
37e11a63
CY
8155 * editfns.c (Fset_time_zone_rule): Document relationship with the
8156 setenv function.
8157
d5617611
CY
8158 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8159 the font entity extracted from the cache (Bug#8109).
8160
58872834
CY
81612011-08-07 Chong Yidong <cyd@stupidchicken.com>
8162
8163 * composite.c (autocmp_chars): Don't reset point. That is done by
8164 restore_point_unwind (Bug#5984).
8165
75bfc667
JL
81662011-08-07 Juri Linkov <juri@jurta.org>
8167
8168 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8169 to show the arg `TIME' instead of `TIMEVAL'.
8170
d1410150
EZ
81712011-08-06 Eli Zaretskii <eliz@gnu.org>
8172
8173 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8174 display property strides EOL and includes a newline, as in
8175 longlines-mode. (Bug#9254)
75b771e4
EZ
8176 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8177 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8178
8179 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8180 is non-zero, even if the data buffer is NULL. Fixes a crash in
8181 vertical-motion with longlines-mode. (Bug#9254)
8182
35928349
EZ
81832011-08-05 Eli Zaretskii <eliz@gnu.org>
8184
ec7cc85b
EZ
8185 * bidi.c <bidi_cache_total_alloc>: Now static.
8186 (bidi_initialize): Initialize bidi_cache_total_alloc.
8187
8b76d6f8 8188 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8189 cache. (Bug#9221)
8190
8191 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8192 amount allocated this far in `bidi_cache_total_alloc'.
8193 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8194 non-zero, only free the data buffer without restoring the cache
8195 contents. All callers changed.
8196
8197 * dispextern.h (bidi_unshelve_cache): Update prototype.
8198
8199 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8200 (move_it_in_display_line, move_it_to)
8201 (move_it_vertically_backward, move_it_by_lines): Replace the call
8202 to xfree to an equivalent call to bidi_unshelve_cache.
8203 (move_it_in_display_line_to): Fix logic of returning
412b6358 8204 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8205
e2e2423b
EZ
82062011-08-05 Eli Zaretskii <eliz@gnu.org>
8207
8208 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8209 came from a string character with a `cursor' property. (Bug#9229)
8210
ae9e757a
JD
82112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8212
8213 * Makefile.in (LIB_PTHREAD): New variable.
8214 (LIBES): Add LIB_PTHREAD (Bug#9216).
8215
8216 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8217 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8218
213bd7f2
AS
82192011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8220
6b02f655 8221 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8222
99aaf75f
JD
82232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8224
8225 * xterm.c (x_find_topmost_parent): New function.
8226 (x_set_frame_alpha): Find topmost parent window with
8227 x_find_topmost_parent and set the property there also (bug#9181).
8228 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8229
c74e9d86
PE
82302011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8231
8232 * callproc.c (Fcall_process): Avoid vfork clobbering
8233 the local vars buffer, coding_systems, current_dir.
8234
640c8776
SM
82352011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8236
8237 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8238
f26d0e4c
PE
82392011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8240
8a10d76c
PE
8241 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8242 so that it is not optimized away.
8243
f26d0e4c
PE
8244 * xdisp.c (compute_display_string_pos): Remove unused local.
8245
55439c61
EZ
82462011-08-02 Eli Zaretskii <eliz@gnu.org>
8247
8248 Fix slow cursor motion and scrolling in large buffers with
8249 selective display, like Org Mode buffers. (Bug#9218)
8250
8251 * dispextern.h (struct bidi_it): New member disp_prop_p.
8252
8253 * xdisp.c: Remove one-slot cache of display string positions.
8254 (compute_display_string_pos): Accept an additional argument
5e617bc2 8255 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8256 for a display string or property. If found, set DISP_PROP_P
8257 non-zero.
8258
8259 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8260 DISP_PROP_P, and pass it to compute_display_string_pos.
8261 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8262 non-zero. All callers of bidi_fetch_char changed.
8263
fb33fa43
SM
82642011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8265
8266 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8267
b099e063
DM
82682010-12-03 Don March <don@ohspite.net>
8269
8270 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8271 last character M-[char] is translated to ESC [char] (bug#7541).
8272
5cc7f7af
KH
82732011-08-02 Kenichi Handa <handa@m17n.org>
8274
d0fffa3f 8275 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8276
8277 * chartab.c (uniprop_table): Make it non-static.
8278
525d5e6e
EZ
82792011-08-01 Eli Zaretskii <eliz@gnu.org>
8280
8281 * xdisp.c (forward_to_next_line_start): Accept additional argument
8282 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8283 on the newline.
8284 (reseat_at_next_visible_line_start): Use the bidi iterator state
8285 returned by forward_to_next_line_start to restore the state of
8286 it->bidi_it after backing up to previous newline. (Bug#9212)
8287
31011111
AS
82882011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8289
8290 * regex.c (re_comp): Protoize.
8291 (re_exec): Fix return type.
8292 (regexec): Fix type of `ret'. (Bug#9203)
8293
476371c4
PE
82942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8295
e5d76069
PE
8296 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8297 This is needed if max-image-size is a floating-point number.
8298
9a79b20c
AS
82992011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8300
8301 * print.c (print_object): Print empty symbol as ##.
8302
8303 * lread.c (read1): Read ## as empty symbol.
8304
d8c2fa78
AA
83052011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8306
8307 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8308 setting frame foreground color (Bug#9175).
8309 (x_set_background_color): Likewise.
8310
ffe57a7a
AA
8311 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8312 contents (Bug#9176).
8313 (EmacsTooltip -init): Remove bezels and add shadows to
8314 tooltip windows.
8315
bf3492a5
AA
8316 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8317 or scroll bar (Bug#8470).
8318
d55e9c53
AA
8319 * nsfont.m (nsfont_open): Remove assignment to voffset and
8320 unnecessary vars hshink, expand, hd, full_height, min_height.
8321 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8322
8323 * nsterm.h (nsfont_info): Remove voffset field.
8324
d8c2fa78 83252011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8326
8327 Implement strike-through and overline on NextStep (Bug#8863).
8328
8329 * nsfont.m (nsfont_open): Use underline position provided by font,
8330 instead of hard-coded value of 2.
8331 (nsfont_draw): Call ns_draw_text_decoration instead.
8332
8333 * nsterm.h: Add declaration for ns_draw_text_decoration.
8334
8335 * nsterm.m (ns_draw_text_decoration): New function for drawing
8336 underline, overline, and strike-through.
8337 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8338 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8339 accommodate underlining, etc.
4843aac3 8340
4cc60b9b
EZ
83412011-07-28 Eli Zaretskii <eliz@gnu.org>
8342
bc7ece87
EZ
8343 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8344 default.
4cc60b9b 8345
476371c4
PE
83462011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8347
66606eea
PE
8348 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8349 Without this fix, if a signal arrives just after memory fills up,
8350 'malloc' might be invoked reentrantly.
8351
476371c4
PE
8352 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8353 In other words, assume that every image size is allowed, on non-X
8354 hosts. This assumption is probably wrong, but it lets Emacs compile.
8355
f3fcc40d
AS
83562011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8357
8358 * regex.c (re_iswctype): Convert return values to boolean.
8359
350c992f
EZ
83602011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8361
8362 * xdisp.c (compute_display_string_pos): Don't use cached display
8363 string position if the buffer had its restriction changed.
8364 (Bug#9184)
8365
5266b4bb
PE
83662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8367
8368 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8369
2573a837 83702011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8371
41f55ccd 8372 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8373
39e378da
PE
8374 * bidi.c: Integer size and overflow fixes.
8375 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8376 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8377 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8378 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8379 (bidi_find_other_level_edge):
8380 Use ptrdiff_t instead of EMACS_INT where either will do.
8381 This works better on 32-bit hosts configured --with-wide-int.
8382 (bidi_cache_ensure_space): Check for size-calculation overflow.
8383 Use % rather than repeated addition, for better worst-case speed.
8384 Don't set bidi_cache_size until after xrealloc returns, because it
8385 might not return.
8386 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8387 (bidi_cache_ensure_space): Also check that the bidi cache size
8388 does not exceed that of the largest Lisp string or buffer. See Eli
8389 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8390
5e927815
PE
8391 * alloc.c (__malloc_size_t): Remove.
8392 All uses replaced by size_t. See Andreas Schwab's note
8393 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8394
ca4aa935
PE
8395 * image.c: Improve checking for integer overflow.
8396 (check_image_size): Assume that f is nonnull, since
8397 it is always nonnull in practice. This is one less thing to
8398 worry about when checking for integer overflow later.
8399 (x_check_image_size): New function, which checks for integer
8400 overflow issues inside X.
8401 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8402 This removes the need for a memory_full check.
8403 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8404 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8405 (xbm_read_bitmap_data): Change locals back to 'int', since
8406 their values must fit in 'int'.
8407 (xpm_load_image, png_load, tiff_load):
8408 Invoke x_create_x_image_and_pixmap earlier,
8409 to avoid much needless work if the image is too large.
8410 (tiff_load): Treat overly large images as if
8411 x_create_x_image_and_pixmap failed, not as malloc failures.
8412 (gs_load): Use x_check_image_size.
8413
5f8f9cc2
PE
8414 * gtkutil.c: Omit integer casts.
8415 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8416 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8417
5adf60bc
PE
8418 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8419
c8907a93
PE
8420 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8421 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8422 would wrongly return t on a 64-bit host.
8423
e3c25c68
PE
8424 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8425 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8426 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8427 and therefore cause GCC to emit a bogus diagnostic in some cases.
8428
3f791afe
PE
8429 * image.c: Integer signedness and overflow and related fixes.
8430 This is not an exhaustive set of fixes, but it's time to
8431 record what I've got.
8432 (lookup_pixel_color, check_image_size): Remove redundant decls.
8433 (check_image_size): Don't assume that arbitrary EMACS_INT values
8434 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8435 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8436 (tiff_load, imagemagick_load_image):
8437 Check for overflow in size calculations.
8438 (x_create_x_image_and_pixmap): Remove unnecessary test for
8439 xmalloc returning NULL; that can't happen.
8440 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8441 (xpm_color_bucket): Use better integer hashing function.
8442 (xpm_cache_color): Don't possibly over-allocate memory.
8443 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8444 (gif_memory_source):
8445 Use ptrdiff_t, not int or size_t, to record sizes.
8446 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8447 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8448 either works, as we prefer signed integers.
8449 (tiff_read_from_memory, tiff_write_from_memory):
8450 Return tsize_t, not size_t, since that's what the TIFF API wants.
8451 (tiff_read_from_memory): Don't fail simply because the read would
8452 go past EOF; instead, return a short read.
8453 (tiff_load): Omit no-longer-needed casts.
8454 (Fimagemagick_types): Don't assume size fits into 'int'.
8455
3cc5a532
PE
8456 Improve hashing quality when configured --with-wide-int.
8457 * fns.c (hash_string): New function, taken from sxhash_string.
8458 Do not discard information about ASCII character case; this
8459 discarding is no longer needed.
8460 (sxhash-string): Use it. Change sig to match it. Caller changed.
8461 * lisp.h: Declare it.
8462 * lread.c (hash_string): Remove, since we now use fns.c's version.
8463 The fns.c version returns a wider integer if --with-wide-int is
8464 specified, so this should help the quality of the hashing a bit.
8465
b312a492
PE
8466 * emacs.c: Integer overflow minor fix.
8467 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8468 Define only if GNU_LINUX.
8469 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8470
dfd153ae
PE
8471 * dispnew.c: Integer signedness and overflow fixes.
8472 Remove unnecessary forward decls, that were a maintenance hassle.
8473 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8474 All uses changed.
8475 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8476 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8477 (prepare_desired_row, line_draw_cost):
8478 Use int, not unsigned, where either works.
8479 (save_current_matrix, restore_current_matrix):
8480 Use ptrdiff_t, not size_t, where either works.
8481 (init_display): Check for overflow more accurately, and without
8482 relying on undefined behavior.
8483
a81d11a3
PE
8484 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8485 Remove, replacing with the new symbols in lisp.h. All uses changed.
8486 * fileio.c (make_temp_name):
8487 * filelock.c (lock_file_1, lock_file):
8488 * xdisp.c (message_dolog):
8489 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8490 Use pMd etc. instead.
8491 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8492 replacing the pWIDE etc. symbols removed from editfns.c.
8493
3300e6fd
PE
8494 * keyboard.h (num_input_events): Now uintmax_t.
8495 This is (very slightly) less likely to mess up due to wraparound.
8496 All uses changed.
8497
fd05c7e9
PE
8498 * buffer.c: Integer signedness fixes.
8499 (alloc_buffer_text, enlarge_buffer_text):
8500 Use ptrdiff_t rather than size_t when either will do, as we prefer
8501 signed integers.
8502
903fe15d
PE
8503 * alloc.c: Integer signedness and overflow fixes.
8504 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8505 (__malloc_size_t): Default to size_t, not to int.
8506 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8507 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8508 Prefer ptrdiff_t to size_t when either would do, as we prefer
8509 signed integers.
8510 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8511 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8512 Now const. Initialize with values that are in range even if char
8513 is signed.
8514 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8515 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8516 These functions do the right thing with sizes > 2**32.
8517 (check_depth): Now ptrdiff_t, not int.
8518 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8519 Adjust to new way of storing sizes. Check for size overflow bugs
8520 in rest of code.
8521 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8522 slightly wrong anyway, as it missed one instance of
8523 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8524 (refill_memory_reserve): Omit needless cast to size_t.
8525 (mark_object_loop_halt): Mark as externally visible.
8526
ac82cc6a
PE
8527 * xselect.c: Integer signedness and overflow fixes.
8528 (Fx_register_dnd_atom, x_handle_dnd_message):
8529 Use ptrdiff_t, not size_t, since we prefer signed.
8530 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8531 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8532 x_dnd_atoms_size and x_dnd_atoms_length.
8533
c2d1e36d
PE
8534 * doprnt.c: Prefer signed to unsigned when either works.
8535 * eval.c (verror):
8536 * doprnt.c (doprnt):
8537 * lisp.h (doprnt):
8538 * xdisp.c (vmessage):
8539 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8540 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8541 prefer signed arithmetic to avoid comparison confusion.
8542 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8543 but is a bit tricky.
8544
0e926e56
PE
8545 Assume freestanding C89 headers, string.h, stdlib.h.
8546 * data.c, doprnt.c, floatfns.c, print.c:
8547 Include float.h unconditionally.
8548 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8549 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8550 * regex.c: Likewise for stddef.h, string.h.
8551 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8552 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8553 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8554 (STDC_HEADERS): Remove obsolete defines.
8555 * sysdep.c: Include limits.h unconditionally.
8556
9cfdb3ec
PE
8557 Assume support for memcmp, memcpy, memmove, memset.
8558 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8559 * regex.c (memcmp, memcpy):
8560 Remove; we assume C89 now.
8561
8562 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8563 (__malloc_safe_bcopy): Remove; no longer needed.
8564
cf950e6b 8565 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8566 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8567 well either way, and we prefer signed to unsigned.
8568
dbf38e02
LMI
85692011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8570
8571 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8572 closes the connection while we're reading (bug#9182).
8573
d6f0886c 85742011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8575
d6f0886c
JD
8576 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8577 are specified (Bug#9168).
24e0f6b1 8578
2eb1f9e6
PE
85792011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8580
8581 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8582 Found by GCC static checking and --with-wide-int on a 32-bit host.
8583
22381272 85842011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8585
8586 * xdisp.c (compute_display_string_pos): Fix logic of caching
8587 previous display string position. Initialize cached_prev_pos to
8588 -1. Fixes slow-down at the beginning of a buffer.
8589
f25e39b4
EZ
85902011-07-24 Eli Zaretskii <eliz@gnu.org>
8591
8592 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8593 for attrs[LFACE_FONTSET_INDEX].
8594
04c4b52e
PE
85952011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8596
8597 * xml.c (parse_region): Remove unused local
8598 that was recently introduced.
8599
c1734fbd
EZ
86002011-07-23 Eli Zaretskii <eliz@gnu.org>
8601
be18c5a5
EZ
8602 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8603 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8604
c1734fbd
EZ
8605 * xdisp.c (move_it_in_display_line_to): Record the best matching
8606 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8607 exit if none of the characters scanned was an exact match.
8608 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8609 when exact match is impossible due to invisible text, and the
8610 lines are truncated.
8611
a258d627
JD
86122011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8613
8614 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8615 for OSX >= 10.7.
8616
b6d5a689
EZ
86172011-07-22 Eli Zaretskii <eliz@gnu.org>
8618
0f74f785
EZ
8619 Fix a significant slow-down of cursor motion with C-n, C-p,
8620 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8621 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8622 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8623 (next_element_from_buffer): Call compute_stop_pos_backwards to
8624 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8625 base_level_stop.
8626 (reseat): Don't look for prev_stop, as that could mean a very long
8627 run.
8628 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8629 <cached_disp_overlay_modiff>: Cache for last found display string
8630 position.
551918c1 8631 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8632 about the same buffer in the same area of character positions, and
8633 the buffer wasn't changed since the time the display string
8634 position was cached.
551918c1 8635
b2d0c91a
EZ
86362011-07-22 Eli Zaretskii <eliz@gnu.org>
8637
8638 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8639 is an integer, which is important for empty lines. (Bug#9149)
8640
043604ee
CY
86412011-07-22 Chong Yidong <cyd@stupidchicken.com>
8642
8643 * frame.c (Fmodify_frame_parameters): In tty case, update the
8644 default face if necessary (Bug#4238).
8645
da4adb04
CY
86462011-07-21 Chong Yidong <cyd@stupidchicken.com>
8647
8648 * editfns.c (Fstring_to_char): No need to explain what a character
8649 is in the docstring (Bug#6576).
8650
9abd0532
LMI
86512011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8652
8653 * xml.c (parse_region): Make sure we always return a tree.
8654
36881d16
HK
86552011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8656
8657 * xml.c (parse_region): If a document contains only comments,
8658 return that, too.
8659
1e98674d
LMI
86602011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8661
8662 * xml.c (make_dom): Return comments, too.
8663
590bd467
PE
86642011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8665
8666 Port to OpenBSD.
8667 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8668 and the surrounding thread.
8669 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8670 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8671 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8672 timer goes off.
8673 * s/openbsd.h (BROKEN_SIGIO): Define.
8674 * unexelf.c (unexec) [__OpenBSD__]:
8675 Don't update the .mdebug section of the Alpha COFF symbol table.
8676
f41628b2
LMI
86772011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8678
8679 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8680 (bug#8460).
8681
b59b67c5
PE
86822011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8683
15e3a074
PE
8684 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8685 This fixes some race conditions on the permissions of any newly
8686 created file.
8687
41bed37d
PE
8688 * alloc.c (valid_pointer_p): Use pipe, not open.
8689 This fixes some permissions issues when debugging.
8690
b59b67c5
PE
8691 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8692 If fchown fails to set both uid and gid, try to set just gid,
8693 as that is sometimes allowed. Adjust the file's mode to eliminate
8694 setuid or setgid bits that are inappropriate if fchown fails.
8695
925a6be7
SM
86962011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8697
8698 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8699 to compare Lisp_Objects.
8700 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8701 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8702 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8703
52968808
AS
87042011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8705
0a6a104b
AS
8706 * lread.c (read_integer): Unread even EOF character.
8707 (read1): Likewise. Properly record start position of symbol.
8708
52968808
AS
8709 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8710 symbol character follows.
8711
9e381cdd
PE
87122011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8713
8714 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8715 This works around a problem with the previous change to Fcopy_file.
8716 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8717 and without this change, GCC might complain about discarding
8718 fchown's return value.
8719
b5641435
JB
87202011-07-16 Juanma Barranquero <lekktu@gmail.com>
8721
8722 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8723
a8031457
PE
87242011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8725
8726 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8727
dd889327
LMI
87282011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8729
750c33f7
LMI
8730 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8731 it's used from the C level.
8732
dd889327
LMI
8733 * process.c: Use the same condition for POLL_FOR_INPUT in both
8734 keyboard.c and process.c (bug#1858).
8735
87e86684
LM
87362011-07-09 Lawrence Mitchell <wence@gmx.li>
8737
8738 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8739 (Fgnutls_boot): Use it.
8740
64348f40
AS
87412011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8742
8743 * doc.c (Fsubstitute_command_keys): Revert last change.
8744
1d698799
LMI
87452011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8746
f863868c
LMI
8747 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8748 quotes the next character, and doesn't affect other longer
8749 sequences (bug#8935).
8750
1d698799
LMI
8751 * lread.c (syms_of_lread): Clarify that is isn't only
8752 `eval-buffer' and `eval-defun' that's affected by
8753 `lexical-binding' (bug#8460).
8754
aa4b6df6
EZ
87552011-07-15 Eli Zaretskii <eliz@gnu.org>
8756
8757 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8758 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8759
5d856da6
PE
87602011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8761
ad6042bb
PE
8762 Fix minor problems found by static checking.
8763 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8764 (elsz): Now a signed constant, not a size_t var. We prefer signed
8765 types to unsigned, to avoid integer comparison confusion. Without
8766 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8767 "cannot optimize loop, the loop counter may overflow", a symptom
8768 of the confusion.
f00bbb22 8769 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8770 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8771
6468f31c
LMI
87722011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8773
49080b10
LMI
8774 * search.c (Fre_search_backward): Mention `case-fold-search' in
8775 all the re_search_* functions (bug#8138).
8776
6468f31c
LMI
8777 * keyboard.c (Fopen_dribble_file): Document when the file is
8778 closed (bug#8056).
8779
c965adc5
EZ
87802011-07-14 Eli Zaretskii <eliz@gnu.org>
8781
df9733bf
EZ
8782 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8783 bidi_cache_idx.
8784
0bb23927
EZ
8785 Support bidi reordering of display and overlay strings.
8786 * xdisp.c (compute_display_string_pos)
8787 (compute_display_string_end): Accept additional argument STRING.
8788 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8789 (reseat_to_string): Initialize bidi_it->string.s and
8790 bidi_it->string.schars.
8791 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8792 NULL (avoids a crash in bidi_paragraph_init).
8793 Initialize itb.string.lstring.
0bb23927
EZ
8794 (init_iterator): Call bidi_init_it only of a valid
8795 buffer position was specified. Initialize paragraph_embedding to
8796 L2R.
8797 (reseat_to_string): Initialize the bidi iterator.
8798 (display_string): If we need to ignore text properties of
8799 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8800 original value of -1 will not work with bidi.)
8801 (compute_display_string_pos): First arg is now struct
8802 `text_pos *'; all callers changed. Support display properties on
8803 Lisp strings.
8804 (compute_display_string_end): Support display properties on Lisp
8805 strings.
8806 (init_iterator, reseat_1, reseat_to_string): Initialize the
8807 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8808 when iterating on a string not from display properties).
640c8776
SM
8809 (compute_display_string_pos, compute_display_string_end):
8810 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8811 arrow keys.
8812 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8813 base_level_stop; instead, set base_level_stop to BEGV.
8814 Fixes crashes in vertical-motion.
0bb23927
EZ
8815 (next_element_from_buffer): Improve commentary for when
8816 the iterator is before prev_stop.
8817 (init_iterator): Initialize bidi_p from the default value of
8818 bidi-display-reordering, not from buffer-local value. Use the
8819 buffer-local value only if initializing for buffer iteration.
8820 (handle_invisible_prop): Support invisible properties on strings
8821 that are being bidi-reordered.
8822 (set_iterator_to_next): Support bidi reordering of C strings and
8823 Lisp strings.
8824 (next_element_from_string): Support bidi reordering of Lisp
8825 strings.
8826 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8827 (display_string): Support display of R2L glyph rows.
8828 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8829 (init_iterator): Don't initialize it->bidi_p for strings
8830 here.
8831 (reseat_to_string): Initialize it->bidi_p for strings here.
8832 (next_element_from_string, next_element_from_c_string)
8833 (next_element_from_buffer): Add xassert's for correspondence
8834 between IT's object being iterated and it->bidi_it.string
8835 structure.
8836 (face_before_or_after_it_pos): Support bidi iteration.
8837 (next_element_from_c_string): Handle the case of the first string
8838 character that is not the first one in the visual order.
8839 (get_visually_first_element): New function, refactored from common
8840 parts of next_element_from_buffer, next_element_from_string, and
8841 next_element_from_c_string.
8842 (tool_bar_lines_needed, redisplay_tool_bar)
8843 (display_menu_bar): Force left-to-right direction. Add a FIXME
8844 comment for making that be controlled by a user option.
8845 (push_it, pop_it): Save and restore the state of the
8846 bidi iterator. Save and restore the bidi_p flag.
8847 (pop_it): Iterate out of display property for string iteration as
8848 well.
8849 (iterate_out_of_display_property): Support iteration over strings.
8850 (handle_single_display_spec): Set up it->bidi_it for iteration
8851 over a display string, and call bidi_init_it.
8852 (handle_single_display_spec, next_overlay_string)
8853 (get_overlay_strings_1, push_display_prop): Set up the bidi
8854 iterator for displaying display or overlay strings.
8855 (forward_to_next_line_start): Don't use the shortcut if
8856 bidi-iterating.
8857 (back_to_previous_visible_line_start): If handle_display_prop
8858 pushed the iterator stack, restore the internal state of the bidi
8859 iterator by calling bidi_pop_it same number of times.
8860 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8861 and we are bidi-iterating, don't decrement the iterator position;
8862 instead, set the first_elt flag in the bidi iterator, to produce
8863 the same effect.
8864 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8865 (push_display_prop): xassert that we are iterating a buffer.
8866 (push_it, pop_it): Save and restore paragraph_embedding member.
8867 (handle_single_display_spec, next_overlay_string)
8868 (get_overlay_strings_1, reseat_1, reseat_to_string)
8869 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8870 correctly. Don't assume unibyte strings are not bidi-reordered.
8871 (compute_display_string_pos)
8872 (compute_display_string_end): Fix handling the case of C string.
8873 (push_it, pop_it): Save and restore from_disp_prop_p.
8874 (handle_single_display_spec, push_display_prop): Set the
8875 from_disp_prop_p flag.
8876 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8877 (pop_it): Call iterate_out_of_display_property only if we are
8878 popping after iteration over a string that came from a display
8879 property. Fix a typo in popping stretch info. Add an assertion
8880 for verifying that the iterator position is in sync with the bidi
8881 iterator.
8882 (handle_single_display_spec, get_overlay_strings_1)
8883 (push_display_prop): Fix initialization of paragraph direction for
8884 string when that of the parent object is not yet determined.
8885 (reseat_1): Call bidi_init_it to resync the bidi
8886 iterator with IT's position. (Bug#7616)
8887 (find_row_edges): If ROW->start.pos gives position
8888 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8889 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8890 Reset the from_disp_prop_p flag.
8891 (SAVE_IT, RESTORE_IT): New macros.
8892 (pos_visible_p, face_before_or_after_it_pos)
8893 (back_to_previous_visible_line_start)
8894 (move_it_in_display_line_to, move_it_in_display_line)
8895 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8896 (try_scrolling, redisplay_window, display_line): Use them when
8897 saving a temporary copy of the iterator and restoring it back.
8898 (back_to_previous_visible_line_start, reseat_1)
8899 (init_iterator): Empty the bidi cache "stack".
8900 (move_it_in_display_line_to): If iterator ended up at
8901 EOL, but we never saw any buffer positions smaller than
8902 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8903 motion in bidi-reordered lines.
8904 (move_it_in_display_line_to): Record prev_method and prev_pos
8905 immediately before the call to set_iterator_to_next. Fixes cursor
8906 motion in bidi-reordered lines with stretch glyphs and strings
8907 displayed in margins. (Bug#8133) (Bug#8867)
8908 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8909 TO_CHARPOS.
640c8776
SM
8910 (pos_visible_p): Support positions in bidi-reordered lines.
8911 Save and restore bidi cache.
0bb23927
EZ
8912
8913 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8914 (bidi_paragraph_info): Delete unused struct.
8915 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8916 (bidi_cache_start): New variable.
8917 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8918 to zero.
8919 (bidi_cache_fetch_state, bidi_cache_search)
8920 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8921 (bidi_cache_find, bidi_peek_at_next_level)
8922 (bidi_level_of_next_char, bidi_find_other_level_edge)
8923 (bidi_move_to_visually_next): Compare cache index with
8924 bidi_cache_start rather than with zero.
8925 (bidi_fetch_char): Accept new argument STRING; all callers
8926 changed. Support iteration over a string. Support strings with
8927 display properties. Support unibyte strings. Fix the type of
8928 `len' according to what STRING_CHAR_AND_LENGTH expects.
8929 (bidi_paragraph_init, bidi_resolve_explicit_1)
8930 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8931 (bidi_level_of_next_char, bidi_move_to_visually_next):
8932 Support iteration over a string.
0bb23927
EZ
8933 (bidi_set_sor_type, bidi_resolve_explicit_1)
8934 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8935 can now be zero (for strings); special values 0 and -1 were
8936 changed to -1 and -2, respectively.
8937 (bidi_char_at_pos): New function.
8938 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8939 Call it instead of FETCH_MULTIBYTE_CHAR.
8940 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8941 initialized to valid values.
8942 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8943 values.
8944 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8945 the test for valid cached positions. Fix the logic for looking up
8946 the sentinel state in the cache. GCPRO the Lisp string we are
8947 iterating.
8948 (bidi_push_it, bidi_pop_it): New functions.
8949 (bidi_initialize): Initialize the bidi cache start stack pointer.
8950 (bidi_cache_ensure_space): New function, refactored from part of
8951 bidi_cache_iterator_state. Don't assume the required size is just
8952 one BIDI_CACHE_CHUNK away.
8953 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8954 (bidi_count_bytes, bidi_char_at_pos): New functions.
8955 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8956 always valid if bidi_cache_idx is valid.
8957 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8958 is valid if it's going to be used.
8959 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8960 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8961 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8962 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8963 (bidi_find_other_level_edge, bidi_cache_start_stack):
8964 All variables related to cache indices are now EMACS_INT.
c965adc5 8965
0bb23927
EZ
8966 * dispextern.h (struct bidi_string_data): New structure.
8967 (struct bidi_it): New member `string'. Make flag members be 1-bit
8968 fields, and put them last in the struct.
640c8776
SM
8969 (compute_display_string_pos, compute_display_string_end):
8970 Update prototypes.
0bb23927
EZ
8971 (bidi_push_it, bidi_pop_it): Add prototypes.
8972 (struct iterator_stack_entry): New members bidi_p,
8973 paragraph_embedding, and from_disp_prop_p.
8974 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8975 (bidi_shelve_cache, bidi_unshelve_cache):
8976 Declare prototypes.
0bb23927
EZ
8977
8978 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8979 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8980 and vector-like objects.
8981
8982 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8983 cache around display iteration.
8984
8985 * window.c (Fwindow_end, window_scroll_pixel_based)
8986 (displayed_window_lines, Frecenter): Save and restore the bidi
8987 cache around display iteration.
8988
3bbd2265
LMI
89892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8990
8991 * editfns.c (Fdelete_region): Clarify the use of the named
8992 parameters (bug#6788).
8993
adc47434
MR
89942011-07-14 Martin Rudalics <rudalics@gmx.at>
8995
8996 * indent.c (Fvertical_motion): Set and restore w->pointm when
8997 saving and restoring the window's buffer (Bug#9006).
8998
837c31f8
LMI
89992011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9000
9001 * editfns.c (Fstring_to_char): Clarify just what is returned
9002 (bug#6576). Text by Eli Zaretskii.
9003
ac389d0c
JB
90042011-07-13 Juanma Barranquero <lekktu@gmail.com>
9005
9006 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9007
0be0ce47
EZ
90082011-07-13 Eli Zaretskii <eliz@gnu.org>
9009
9010 * buffer.c (mmap_find): Fix a typo.
9011
cd18e7e3
JB
90122011-07-13 Johan Bockgård <bojohan@gnu.org>
9013
9014 Fix execution of x selection hooks.
9015 * xselect.c (Qx_lost_selection_functions)
9016 (Qx_sent_selection_functions): New vars.
9017 (syms_of_xselect): DEFSYM them.
9018 (x_handle_selection_request): Pass Qx_sent_selection_functions
9019 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9020 (x_handle_selection_clear,x_clear_frame_selections):
9021 Pass Qx_lost_selection_functions rather than
9022 Vx_lost_selection_functions to Frun_hook_with_args.
9023
47ea7f44
PE
90242011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9025
ac389d0c 9026 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9027 The old code sometimes used this field without initializing it.
9028
47ea7f44
PE
9029 * alloc.c (gc_sweep): Don't read past end of array.
9030 In theory, the old code could also have corrupted Emacs internals,
9031 though it'd be very unlikely.
9032
bc985c87
AS
90332011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9034
9035 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9036 argument. (Bug#4026)
bc985c87 9037
0cf34688
LMI
90382011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9039
b3dadd76
LMI
9040 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9041 key" (bug#4257).
9042
0cf34688
LMI
9043 * window.c (Fset_window_start): Doc fix (bug#4199).
9044 (Fset_window_hscroll): Ditto.
9045
270768cd
PE
90462011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9047
077e3dda 9048 Fix minor new problems caught by GCC 4.6.1.
270768cd 9049 * term.c (init_tty): Remove unused local.
490011a6 9050 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9051 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9052 not used otherwise.
270768cd 9053
b1f58454
CY
90542011-07-12 Chong Yidong <cyd@stupidchicken.com>
9055
9056 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9057
22b9578d
LMI
90582011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9059
6e70ab07
LMI
9060 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9061 are the mini-buffer and the echo area (bug#3320).
9062
22b9578d
LMI
9063 * term.c (init_tty): Remove support for supdup, c10 and perq
9064 terminals, which are no longer supported (bug#1482).
9065
8974cc9f
JB
90662011-07-10 Johan Bockgård <bojohan@gnu.org>
9067
9068 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9069
a560d974
JD
90702011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9071
9072 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9073 for non-popups (Bug#3642).
9074
1dae0f0a
AS
90752011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9076
268c2c36 9077 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9078 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9079 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9080 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9081 * data.c (fmod): Likewise.
9082 * dispnew.c (swap_glyphs_in_rows): Likewise.
9083 * emacs.c (memory_warning_signal): Likewise.
9084 * floatfns.c (float_error): Likewise.
9085 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9086 (otf_open, font_otf_capability, generate_otf_features)
9087 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9088 Likewise.
9089 * image.c (pbm_read_file): Likewise.
9090 * indent.c (string_display_width): Likewise.
9091 * intervals.c (check_for_interval, search_for_interval)
9092 (inc_interval_count, count_intervals, root_interval)
9093 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9094 * lread.c (defalias): Likewise.
268c2c36 9095 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9096 * regex.c (set_image_of_range_1, set_image_of_range)
9097 (regex_grow_registers): Likewise.
9098 * sysdep.c (strerror): Likewise.
9099 * termcap.c (valid_filename_p, tprint, main): Likewise.
9100 * tparam.c (main): Likewise.
9101 * unexhp9k800.c (run_time_remap, save_data_space)
9102 (update_file_ptrs, read_header, write_header, calculate_checksum)
9103 (copy_file, copy_rest, display_header): Likewise.
9104 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9105 Likewise.
9106 * xdisp.c (check_it): Likewise.
9107 * xfaces.c (register_color, unregister_color, unregister_colors):
9108 Likewise.
9109 * xfns.c (print_fontset_result): Likewise.
9110 * xrdb.c (member, fatal, main): Likewise.
9111
99033785
PE
91122011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9113
9114 Fix minor problems found by static checking (Bug#9031).
9115 * chartab.c (char_table_set_range, map_sub_char_table):
9116 Remove unused locals.
9117 (uniprop_table): Now static.
9118 * composite.c (_work_char): Remove unused static var.
9119
9cb2ac56
JB
91202011-07-09 Juanma Barranquero <lekktu@gmail.com>
9121
9122 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9123
f25661f0
JD
91242011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9125
9126 * gtkutil.c (qttip_cb): Remove code without function.
9127
8278c4fe
EZ
91282011-07-09 Eli Zaretskii <eliz@gnu.org>
9129
9130 * w32.c (pthread_sigmask): New stub.
9131
1692ae2d 91322011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9133
8a6ebd58 9134 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9135 sigprocmask is portable only for single-threaded applications, and
9136 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9137 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9138 (LIBES): Use it.
9139 * callproc.c (Fcall_process):
9140 * process.c (create_process):
9141 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9142 Use pthread_sigmask, not sigprocmask.
123403e4 9143
1b854618
JD
91442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9145
9146 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9147 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9148 wrong (Bug#8591).
9149
3fe4b549
JD
91502011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9151
0ce7e563
JD
9152 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9153 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9154 (xg_hide_tooltip): Fix comment.
9155
3fe4b549
JD
9156 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9157 in registerServicesMenuSendTypes.
9158 (validRequestorForSendType): Don't check ns_return_types.
9159
9160 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9161 ns_return_type.
9162
5df75e47
JR
91632011-07-08 Jason Rumney <jasonr@gnu.org>
9164
22610910
JR
9165 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9166 SH_SHOW for hidden windows (Bug#5482).
9167
5df75e47
JR
9168 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9169 frame struct members of non-existent frames (Bug#6284).
9170
699c10bd
JD
91712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9172
4393663b
JD
9173 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9174 variable firstTime not needed on OSX >= 10.6.
9175 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9176 >= 10.5. Use setKnobProportion, setDoubleValue.
9177
9178 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9179 (MAC_OS_X_VERSION_10_5): Define if not defined.
9180 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9181 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9182 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9183
9184 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9185 cString and lossyCString on OSX >= 10.4.
4393663b 9186
58179cce 9187 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9188 sizeToFit on OSX >= 10.2.
9189
9190 * nsimage.m (allocInitFromFile): Don't use deprecated method
9191 bestRepresentationForDevice on OSX >= 10.6.
9192
9193 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9194 to avoid warning.
9195
9196 * emacs.c: Declare unexec_init_emacs_zone.
9197
a63e0781
JD
9198 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9199
699c10bd
JD
9200 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9201
9202 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9203 on svcsMenu (Bug#8842).
9204
9205 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9206 ns_return_types.
9207 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9208
9209 * nsterm.m (QUTF8_STRING): Declare.
9210 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9211 (validRequestorForSendType): Return type is (id).
9212 Change indexOfObjectIdenticalTo to indexOfObject.
9213 Check if we have local selection before returning self (Bug#8842).
9214 (writeSelectionToPasteboard): Put local selection into paste board
9215 if we have a local selection (Bug#8842).
9216 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9217
9218 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9219 (ns_get_local_selection): Declare.
9220
54e10184
LMI
92212011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9222
9888ff71
LMI
9223 * keymap.c (describe_map_tree): Don't insert a double newline at
9224 the end of the buffer (bug#1169) and return whether we inserted
9225 something.
9226
54e10184
LMI
9227 * callint.c (Fcall_interactively): Change "reading args" to
9228 "providing args" to try to clarify what it does (bug#1010).
9229
15fa4783
KH
92302011-07-07 Kenichi Handa <handa@m17n.org>
9231
9232 * composite.c (composition_compute_stop_pos): Ignore a static
9233 composition starting before CHARPOS (Bug#8915).
9234
9235 * xdisp.c (handle_composition_prop): Likewise.
9236
a8815b00
EZ
92372011-07-07 Eli Zaretskii <eliz@gnu.org>
9238
9239 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9240 (Bug#9015)
9241
ef7b981d 92422011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9243
9244 * character.h (unicode_category_t): New enum type.
9245
9246 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9247 (Qchar_code_property_table): New variable.
9248 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9249 (UNIPROP_COMPRESSED_FORM_P): New macros.
9250 (char_table_ascii): Uncompress the compressed values.
9251 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9252 Uncompress the compressed values.
ac389d0c 9253 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9254 (char_table_ref_and_range): Uncompress the compressed values.
9255 (sub_char_table_set): New arg is_uniprop. Callers changed.
9256 Uncompress the compressed values.
9257 (sub_char_table_set_range): Args changed. Callers changed.
9258 (char_table_set_range): Adjuted for the above change.
9259 (map_sub_char_table): Delete args default_val and parent. Add arg
9260 top. Give decoded values to a Lisp function.
640c8776 9261 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9262 values to a Lisp function. Gcpro more variables.
9263 (uniprop_table_uncompress)
9264 (uniprop_decode_value_run_length): New functions.
9265 (uniprop_decoder, uniprop_decoder_count): New variables.
9266 (uniprop_get_decoder, uniprop_encode_value_character)
9267 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9268 New functions.
9269 (uniprop_encoder, uniprop_encoder_count): New variables.
9270 (uniprop_get_encoder, uniprop_table)
9271 (Funicode_property_table_internal, Fget_unicode_property_internal)
9272 (Fput_unicode_property_internal): New functions.
9273 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9274 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9275 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9276 char-code-property-alist.
9277
640c8776 9278 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9279 Vunicode_category_table.
9280
640c8776 9281 * font.c (font_range): Adjust for the change of
c805dec0
KH
9282 Vunicode_category_table.
9283
76b397fb
DN
92842011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9285
9286 * m/iris4d.h: Remove file, move contents ...
9287 * s/irix6-5.h: ... here.
9288
22b4128e
PE
92892011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9290
9291 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9292 * alloc.c (mark_buffer):
9293 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9294 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9295 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9296 This isn't true in general, and it's particularly not true
9297 if Emacs is configured with --with-wide-int.
9298 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9299 New macros, used in the buffer.c change.
9300
869795d6
JD
93012011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9302
9303 * xsettings.c: Use both GConf and GSettings if both are available.
9304 (store_config_changed_event): Add comment.
9305 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9306 (store_tool_bar_style_changed): New functions.
5e617bc2 9307 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9308 (struct xsettings): Move font inside HAVE_XFT.
9309 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9310 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9311 Move inside HAVE_XFT.
640c8776 9312 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9313 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9314 also.
9315 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9316 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9317 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9318 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9319 (parse_settings): Move check for font inside HAVE_XFT.
9320 (read_settings, apply_xft_settings): Add comment.
9321 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9322 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9323 call store_font_name_changed.
9324 (xft_settings_event): Add comment.
9325 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9326 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9327 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9328 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9329 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9330 (xsettings_get_system_font, xsettings_get_system_normal_font):
9331 Add comment.
869795d6 9332
d8ed26bd
PE
93332011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9334
9335 Random fixes. E.g., (random) never returned negative values.
9336 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9337 subseconds part to the entropy, as that's a bit more random.
9338 Prefer signed to unsigned, since the signedness doesn't matter and
9339 in general we prefer signed. When given a limit, use a
9340 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9341 latter isn't right if USE_2_TAGS_FOR_INTS.
9342 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9343 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9344
cabf1cac
SM
93452011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9346
9347 * textprop.c (text_property_stickiness):
9348 Obey Vtext_property_default_nonsticky.
9349 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9350 * w32fns.c (syms_of_w32fns):
9351 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9352
6e9b2be9
PE
93532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9354
9355 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9356 This is more efficient than Ffile_directory_p and avoids a minor race.
9357
90186c68
LMI
93582011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9359
7c301272
LMI
9360 * buffer.c (Foverlay_put): Say what the return value is
9361 (bug#7835).
9362
c4f2d8d4
LMI
9363 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9364 is a directory before asking whether to use the file name
9365 (bug#7564).
ad637907
LMI
9366 (barf_or_query_if_file_exists): Make the "File is a directory"
9367 error be more correct.
c4f2d8d4 9368
90186c68
LMI
9369 * fns.c (Frequire): Remove the mention of the .gz files, since
9370 that's installation-specific, but keep the mention of
9371 `get-load-suffixes'.
9372
da64016e
PE
93732011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9374
9375 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9376 Report string overflow if the output is too long.
9377
7d47b580
JB
93782011-07-04 Juanma Barranquero <lekktu@gmail.com>
9379
a555cb87
JB
9380 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9381 (syms_of_gnutls): Remove duplicate DEFSYM for
9382 Qgnutls_bootprop_verify_hostname_error, an error for
9383 Qgnutls_bootprop_verify_error (which is no longer used).
9384
7d47b580
JB
9385 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9386 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9387 Also (re)move comments that are misplaced or no longer relevant.
9388
1e49bfab
LMI
93892011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9390
9391 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9392
1485f4c0
CY
93932011-07-03 Chong Yidong <cyd@stupidchicken.com>
9394
9395 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9396 and background color parameters if they have been changed.
9397
a9ab721e
LMI
93982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9399
9400 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9401
cf7cff57
PE
94022011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9403
2e13213d
PE
9404 * xsettings.c (SYSTEM_FONT): Define only when used.
9405 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9406
cf7cff57
PE
9407 * keymap.c (access_keymap_1): Now static.
9408
7a8e04f7
CY
94092011-07-02 Chong Yidong <cyd@stupidchicken.com>
9410
9411 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9412 leave any prefix arg for the up event (Bug#1586).
9413
61352f62
LMI
94142011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9415
69bb1ef7
LMI
9416 * lread.c (syms_of_lread): Mention single symbols defined by
9417 `defvar' or `defconst' (bug#7154).
9418
61352f62 9419 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9420 (Frequire): Mention get-load-suffixes.
61352f62 9421
28545e04
MR
94222011-07-02 Martin Rudalics <rudalics@gmx.at>
9423
9424 * window.h (window): Remove clone_number slot.
9425 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9426 Remove.
9427 (make_parent_window, make_window, saved_window)
9428 (Fset_window_configuration, save_window_save): Don't deal with
9429 clone numbers.
9430 * buffer.c (Qclone_number): Remove declaration.
9431 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9432
3349e122
SM
94332011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9434
9435 Add multiple inheritance to keymaps.
9436 * keymap.c (Fmake_composed_keymap): New function.
9437 (Fset_keymap_parent): Simplify.
9438 (fix_submap_inheritance): Remove.
9439 (access_keymap_1): New function extracted from access_keymap to handle
9440 embedded parents and handle lists of maps.
9441 (access_keymap): Use it.
9442 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9443 (Fcopy_keymap): Handle embedded parents.
9444 (Fcommand_remapping, define_as_prefix): Simplify.
9445 (Fkey_binding): Simplify.
9446 (syms_of_keymap): Move minibuffer-local-completion-map,
9447 minibuffer-local-filename-completion-map,
9448 minibuffer-local-must-match-map, and
9449 minibuffer-local-filename-must-match-map to Elisp.
9450 (syms_of_keymap): Defsubr make-composed-keymap.
9451 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9452 (parse_menu_item): Trivial simplification.
9453
3279eb87
GM
94542011-07-01 Glenn Morris <rgm@gnu.org>
9455
9456 * Makefile.in (SETTINGS_LIBS): Fix typo.
9457
4550efdf
KI
94582011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9459
9460 * coding.c (Fencode_coding_string): Record the last coding system
9461 used, as the function doc string says (bug#8738).
9462
0949d2b6
JD
94632011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9464
9465 * xsettings.c (store_monospaced_changed): Take new font as arg and
9466 check for change against current_mono_font.
9467 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9468 (emacs_settings_constructor, emacs_settings_get_property)
9469 (emacs_settings_set_property, emacs_settings_class_init)
9470 (emacs_settings_init, gsettings_obj): Remove.
9471 (something_changedCB): New function for HAVE_GSETTINGS.
9472 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9473 with value as argument.
9474 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9475 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9476 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9477 "changed".
9478
9479 * xgselect.c: Add defined (HAVE_GSETTINGS).
9480 (xgselect_initialize): Ditto.
9481
9482 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9483 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9484 xg_select.
9485
bbc6b304
PE
94862011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9487
9488 * eval.c (struct backtrace): Simplify and port the data structure.
9489 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9490 signed bit field, as this assumption is not portable and it makes
9491 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9492 "char debug_on_exit : 1" as this is not portable either; instead,
9493 use the portable "unsigned int debug_on_exit : 1". Remove unused
9494 member evalargs. Remove obsolete comments about cc bombing out.
9495
9851bfc5
JD
94962011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9497
51bb811f 9498 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9499 Let HAVE_GSETTINGS override HAVE_GCONF.
9500 (store_monospaced_changed): New function.
9501 (EMACS_SETTINGS): A new type derived from GObject to handle
9502 GSettings notifications.
9503 (emacs_settings_constructor, emacs_settings_get_property)
9504 (emacs_settings_set_property, emacs_settings_class_init):
9505 New functions.
9506 (gsettings_client, gsettings_obj): New variables.
9507 (GSETTINGS_SCHEMA): New define.
9508 (something_changedCB): Call store_monospaced_changed.
9509 (init_gsettings): New function.
9510 (xsettings_initialize): Call init_gsettings.
9511 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9512 to NULL.
9513
640c8776 9514 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9515 GCONF_CFLAGS/LIBS.
9516
5386012d
MR
95172011-06-29 Martin Rudalics <rudalics@gmx.at>
9518
9519 * window.c (resize_root_window, grow_mini_window)
9520 (shrink_mini_window): Rename Qresize_root_window to
9521 Qwindow_resize_root_window and Qresize_root_window_vertically to
9522 Qwindow_resize_root_window_vertically.
9523
f13e0b08
PE
95242011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9525
9526 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9527
94515237
JB
95282011-06-27 Juanma Barranquero <lekktu@gmail.com>
9529
9530 * makefile.w32-in: Redesign dependencies so they reflect more
9531 clearly which files are directly included by each source file,
9532 and not through other includes.
9533
e43b6e43
MR
95342011-06-27 Martin Rudalics <rudalics@gmx.at>
9535
9536 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9537 (sort_overlays, overlay_strings): When an overlay's clone number
9538 matches the window's clone number process the overlay even if
9539 the overlay's window property doesn't match the current window.
9540
d68443dc
MR
9541 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9542 (Fwindow_hchild): Rename to Fwindow_left_child.
9543 (Fwindow_next): Rename to Fwindow_next_sibling.
9544 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9545 (resize_window_check): Rename to window_resize_check.
9546 (resize_window_apply): Rename to window_resize_apply.
9547 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9548 (Fdelete_other_windows_internal, resize_frame_windows)
9549 (Fsplit_window_internal, Fdelete_window_internal)
9550 (grow_mini_window, shrink_mini_window)
9551 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9552
c7e73be5
JD
95532011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9554
9555 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9556 (emacs_fixed_set_min_size): Remove.
9557 (emacs_fixed_new): Take frame as argument.
9558
9559 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9560 (_EmacsFixedPrivate): Remove minwidth/height.
9561 Add struct frame *f.
9562 (emacs_fixed_init): Initialize priv->f.
9563 (get_parent_class, emacs_fixed_set_min_size): Remove.
9564 (emacs_fixed_new): Set priv->f to argument.
9565 (emacs_fixed_get_preferred_width)
9566 (emacs_fixed_get_preferred_height): Use min_width/height from
9567 frames size_hint to set minimum and natural (Bug#8919).
9568 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9569 and use min_width/height from frames size_hint to set
9570 min_width/height (Bug#8919).
9571
9572 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9573 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9574 Fix indentation.
c7e73be5 9575
cf99dcf8
EZ
95762011-06-26 Eli Zaretskii <eliz@gnu.org>
9577
9578 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9579 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9580 called at ZV.
9581
029529ac
CY
95822011-06-26 Chong Yidong <cyd@stupidchicken.com>
9583
9584 * process.c (wait_reading_process_output): Bypass select if
9585 waiting for a cell while ignoring keyboard input, and input is
9586 pending. Suggested by Jan Djärv (Bug#8869).
9587
7a7ef429
PE
95882011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9589
9590 Use gnulib's dup2 module instead of rolling our own.
9591 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9592
11fdef7d 95932011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9594
9595 * dispnew.c (scrolling_window): Before scrolling, turn off a
9596 mouse-highlight in the window being scrolled.
9597
cd3520a4
JB
95982011-06-24 Juanma Barranquero <lekktu@gmail.com>
9599
9600 Move DEFSYM to lisp.h and use everywhere.
9601
9602 * character.h (DEFSYM): Move declaration...
9603 * lisp.h (DEFSYM): ...here.
9604
9605 * gnutls.c:
9606 * minibuf.c:
9607 * w32menu.c:
9608 * w32proc.c:
9609 * w32select.c: Don't include character.h.
9610
9611 * alloc.c (syms_of_alloc):
9612 * buffer.c (syms_of_buffer):
9613 * bytecode.c (syms_of_bytecode):
9614 * callint.c (syms_of_callint):
9615 * casefiddle.c (syms_of_casefiddle):
9616 * casetab.c (init_casetab_once):
9617 * category.c (init_category_once, syms_of_category):
9618 * ccl.c (syms_of_ccl):
9619 * cmds.c (syms_of_cmds):
9620 * composite.c (syms_of_composite):
9621 * dbusbind.c (syms_of_dbusbind):
9622 * dired.c (syms_of_dired):
9623 * dispnew.c (syms_of_display):
9624 * doc.c (syms_of_doc):
9625 * editfns.c (syms_of_editfns):
9626 * emacs.c (syms_of_emacs):
9627 * eval.c (syms_of_eval):
9628 * fileio.c (syms_of_fileio):
9629 * fns.c (syms_of_fns):
9630 * frame.c (syms_of_frame):
9631 * fringe.c (syms_of_fringe):
9632 * insdel.c (syms_of_insdel):
9633 * keymap.c (syms_of_keymap):
9634 * lread.c (init_obarray, syms_of_lread):
9635 * macros.c (syms_of_macros):
9636 * msdos.c (syms_of_msdos):
9637 * print.c (syms_of_print):
9638 * process.c (syms_of_process):
9639 * search.c (syms_of_search):
9640 * sound.c (syms_of_sound):
9641 * syntax.c (init_syntax_once, syms_of_syntax):
9642 * terminal.c (syms_of_terminal):
9643 * textprop.c (syms_of_textprop):
9644 * undo.c (syms_of_undo):
9645 * w32.c (globals_of_w32):
9646 * window.c (syms_of_window):
9647 * xdisp.c (syms_of_xdisp):
9648 * xfaces.c (syms_of_xfaces):
9649 * xfns.c (syms_of_xfns):
9650 * xmenu.c (syms_of_xmenu):
9651 * xsettings.c (syms_of_xsettings):
9652 * xterm.c (syms_of_xterm): Use DEFSYM.
9653
4228cf16
TZ
96542011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9655
cd3520a4 9656 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9657
7fcccf1e
PE
96582011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9659
7efb4e0e
PE
9660 Integer and buffer overflow fixes (Bug#8873).
9661
ff5844ad
PE
9662 * print.c (printchar, strout): Check for string overflow.
9663 (PRINTPREPARE, printchar, strout):
9664 Don't set size unless allocation succeeds.
9665
90532f02
PE
9666 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9667 for sizes. Check for string overflow more accurately.
9668 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9669
6d84508d
PE
9670 * macros.c: Integer and buffer overflow fixes.
9671 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9672 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9673 Use ptrdiff_t, not int, for sizes.
9674 Don't increment bufsize until after realloc succeeds.
9675 Check for size-calculation overflow.
9676 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9677
437b2cb4
PE
9678 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9679
8b9ac8b4
PE
9680 * lread.c: Integer overflow fixes.
9681 (read_integer): Radix is now EMACS_INT, not int,
9682 to improve quality of diagnostics for out-of-range radices.
9683 Calculate buffer size correctly for out-of-range radices.
9684 (read1): Check for integer overflow in radices, and in
9685 read-circle numbers.
82cb60d3
PE
9686 (read_escape): Avoid int overflow.
9687 (Fload, openp, read_buffer_size, read1)
9688 (substitute_object_recurse, read_vector, read_list, map_obarray):
9689 Use ptrdiff_t, not int, for sizes.
9690 (read1): Use EMACS_INT, not int, for sizes.
20270765 9691 Check for size overflow.
8b9ac8b4 9692
7fcccf1e
PE
9693 * image.c (cache_image): Check for size arithmetic overflow.
9694
bfbbd7e7
PE
9695 * lread.c: Integer overflow issues.
9696 (saved_doc_string_size, saved_doc_string_length)
9697 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9698 Now ptrdiff_t, not int.
9699 (read1): Don't assume doc string length fits in int. Check for
9700 out-of-range doc string lengths.
9701 (read_list): Don't assume file position fits in int.
39019e54 9702 (read_escape): Check for hex character overflow.
bfbbd7e7 9703
4e323265
LL
97042011-06-22 Leo Liu <sdl.web@gmail.com>
9705
9706 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9707 Move to minibuffer.el.
9708
85fece3e
PE
97092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9710
20b84ce9 9711 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9712 The following patches are for when GLYPH_DEBUG && !XASSERT.
9713 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9714 * dispnew.c (flush_stdout):
9715 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9716 Mark as externally visible.
9717 * dispnew.c (check_window_matrix_pointers): Now static.
9718 * dispnew.c (window_to_frame_vpos):
9719 * xfns.c (unwind_create_frame):
9720 * xterm.c (x_check_font): Remove unused local.
9721 * scroll.c (CHECK_BOUNDS):
9722 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9723 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9724 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9725 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9726 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9727 Now static.
9728 (debug_method_add): Use va_list and vsprintf rather than relying
9729 on undefined behavior with wrong number of arguments.
9730 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9731 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9732 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9733 since we're not interested in debugging glyphs with old libraries.
9734 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9735 GCC 4.6.0's static checking.
9736
0766b489
PE
97372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9738
31fd4b32
PE
9739 Integer overflow and signedness fixes (Bug#8873).
9740 A few related buffer overrun fixes, too.
9741
b79e8648
PE
9742 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9743
0766b489
PE
9744 * dispextern.h (struct face.stipple):
9745 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9746 (x_bitmap_mask, x_allocate_bitmap_record)
9747 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9748 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9749 (x_create_bitmap_from_xpm_data):
9750 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9751 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9752 (.bitmaps_last):
9753 * xfaces.c (load_pixmap):
9754 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9755 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9756 (.bitmaps_last, struct x_output.icon_bitmap):
9757 Use ptrdiff_t, not int, for bitmap indexes.
9758 (x_allocate_bitmap_record): Check for size overflow.
9759 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9760
b081724f
PE
9761 Use ptrdiff_t, not int, for overlay counts.
9762 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9763 * editfns.c (overlays_around, get_pos_property):
9764 * textprop.c (get_char_property_and_overlay):
9765 * xdisp.c (next_overlay_change, note_mouse_highlight):
9766 * xfaces.c (face_at_buffer_position):
21514da7
PE
9767 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9768 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9769 (Fnext_overlay_change, Fprevious_overlay_change)
9770 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9771 Use ptrdiff_t, not int, for sizes.
21514da7 9772 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9773
3de73e5e
PE
9774 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9775
2606c57b
PE
9776 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9777 (x_session_initialize): Do not assume string length fits in int.
9778
aaafe47a
PE
9779 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9780 This is unlikely, but can occur if DPI is outlandish.
9781
2674ddc8 9782 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9783 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9784
28154962
PE
9785 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9786 * xrdb.c (magic_file_p, search_magic_path):
9787 Omit last arg SUFFIX; it was always 0. All callers changed.
9788 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9789
7de51af5
PE
9790 * xfont.c (xfont_match): Avoid need for strlen.
9791
25ed6cc3
PE
9792 * xfns.c: Don't assume strlen fits in int.
9793 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9794
4eab31dd
PE
9795 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9796 not unsigned long, as we prefer signed integers. All callers changed.
9797 Detect integer overflow in repeat count.
9798 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9799 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9800
171e2a58
PE
9801 * termcap.c: Don't assume sizes fit in int and never overflow.
9802 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9803 (gobble_line): Check for size-calculation overflow.
9804
ad39faca 9805 * minibuf.c (Fread_buffer):
6e5bb2dc 9806 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9807 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9808 Don't assume string length fits in int.
9809
52c61c22 9810 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9811 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9812
b5b8c9e5
PE
9813 * font.c: Don't assume string length fits in int.
9814 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9815 Use ptrdiff_t, not int.
ccd6111c
PE
9816 (font_intern_prop): Don't assume string length fits in int.
9817 Don't assume integer property fits in fixnum.
9818 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9819
882f0d81 9820 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9821 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9822 Reformulate so as not to need the command string.
9823 Invoke gzip -cd rather than gunzip, as it's more portable.
9824 (lock_info_type, lock_file_1, lock_file):
9825 Don't assume pid_t and time_t fit in unsigned long.
9826 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9827 (current_lock_owner): Prefer signed type for sizes.
9828 Use memcpy, not strncpy, where memcpy is what is really wanted.
9829 Don't assume (via atoi) that time_t and pid_t fit in int.
9830 Check for time_t and/or pid_t out of range, e.g., via a network share.
9831 Don't alloca where an auto var works fine.
9832
93f4cf88
PE
9833 * fileio.c: Fix some integer overflow issues.
9834 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9835 Don't assume string length fits in int.
9836 (directory_file_name): Don't assume string length fits in long.
9837 (make_temp_name): Don't assume pid fits in int, or that its print
9838 length is less than 20.
9839
f3e92b69
PE
9840 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9841
1bfdaf10
PE
9842 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9843
35016e9a
PE
9844 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9845
3d1e65a1
PE
9846 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9847 We prefer signed integers, even for size calculations.
9848
0b963a93
PE
9849 * emacs.c: Don't assume string length fits in 'int'.
9850 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9851 (main): Don't invoke strlen when not needed.
9852
573f4b54
PE
9853 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9854 (XD_DEBUG_MESSAGE): Don't waste a byte.
9855
989f33ba
PE
9856 * callproc.c (getenv_internal_1, getenv_internal)
9857 (Fgetenv_internal):
965d34eb
PE
9858 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9859
e4d29b33
PE
9860 * lread.c (invalid_syntax): Omit length argument.
9861 All uses changed. This doesn't fix a bug, but it simplifies the
9862 code away from its former Hollerith-constant appearance, and it's
9863 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9864 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9865
eb49b136
PE
9866 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9867 This didn't break anything, but it didn't help either.
9868 It's confusing to put a bogus integer in a place where the actual
9869 value does not matter.
9f62aeb1 9870 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9871 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9872
15375a22
PE
9873 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9874 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9875 implementation.
b61cc01c
PE
9876 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9877 We prefer signed types, and the value cannot exceed the EMACS_INT
9878 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9879 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9880 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9881 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9882
53b2623d
PE
9883 * indent.c (sane_tab_width): New function.
9884 (current_column, scan_for_column, Findent_to, position_indentation)
9885 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9886 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9887
51cab52b 9888 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9889
f2ed8a70
PE
9890 * lisp.h (lint_assume): New macro.
9891 * composite.c (composition_gstring_put_cache):
9892 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9893
abe80cc6
PE
9894 * editfns.c, insdel.c:
9895 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9896
b02c740e
PE
9897 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9898
ebc96716
PE
9899 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9900
b4e50fa0 9901 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9902 Use much-faster test for byte-length change.
311d5d7c 9903 Don't assume string byte-length fits in 'int'.
a4cf38e4 9904 Check that character arg fits in 'int'.
85461888 9905 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9906
c0c1ee9f
PE
9907 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9908
a498d7f4
PE
9909 * fns.c (concat): Catch string overflow earlier.
9910 Do not rely on integer wraparound.
9911
51cab52b
PE
9912 * dispextern.h (struct it.overlay_strings_charpos)
9913 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9914 * xdisp.c (forward_to_next_line_start)
9915 (back_to_previous_visible_line_start)
9916 (reseat_at_next_visible_line_start, next_element_from_buffer):
9917 Don't arbitrarily truncate the value of 'selective' to int.
9918
76031fad
PE
9919 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9920
5eb55db9
PE
9921 * composite.c: Don't truncate sizes to 'int'.
9922 (composition_gstring_p, composition_reseat_it)
9923 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9924 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9925 not EMACS_UINT, for indexes.
5eb55db9 9926
0703a717
PE
9927 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9928
d6202519
PE
9929 * buffer.c: Include <verify.h>.
9930 (struct sortvec.priority, struct sortstr.priority):
8961a454 9931 Now EMACS_INT, not int.
c20998a7 9932 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9933 (struct sortstr.size, record_overlay_string)
9934 (struct sortstrlist.size, struct sortlist.used):
9935 Don't truncate size to int.
9936 (record_overlay_string): Check for size-calculation overflow.
d6202519 9937 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9938
d5a19415
JM
99392011-06-22 Jim Meyering <meyering@redhat.com>
9940
029529ac 9941 Don't leak an XBM-image-sized buffer
d5a19415
JM
9942 * image.c (xbm_load): Free the image buffer after using it.
9943
a9041e6c
PE
99442011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9945
9946 Port to Sun C.
9947 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9948 that Sun C diagnosed.
9949 * fns.c (secure_hash): Fix pointer signedness issue.
9950 * intervals.c (static_offset_intervals): New function.
9951 (offset_intervals): Use it.
9952
7f3f739f
LL
99532011-06-21 Leo Liu <sdl.web@gmail.com>
9954
9955 * deps.mk (fns.o):
9956 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9957 sha512.h.
9958
9959 * fns.c (secure_hash): Rename from crypto_hash_function and change
9960 the first arg to accept symbols.
5b66d427 9961 (Fsecure_hash): New primitive.
7f3f739f
LL
9962 (syms_of_fns): New symbols.
9963
76147d94
DD
99642011-06-20 Deniz Dogan <deniz@dogan.se>
9965
9966 * process.c (Fset_process_buffer): Clarify return value in
9967 docstring.
9968
7d7d0045
CY
99692011-06-18 Chong Yidong <cyd@stupidchicken.com>
9970
9971 * dispnew.c (add_window_display_history): Use BVAR.
9972
9973 * xdisp.c (debug_method_add): Use BVAR.
9974 (check_window_end, dump_glyph_matrix, dump_glyph)
9975 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9976
9977 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9978 Likewise.
9979
9980 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9981 check till after the cache is created in init_frame_faces.
9982
ff2bc410
SM
99832011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9984
9985 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9986
28177add
PE
99872011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9988
dd3482fe
PE
9989 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9990 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9991 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9992
393d71f3 9993 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9994 * fileio.c (Finsert_file_contents):
9995 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9996 Remove the old (too-loose) buffer overflow checks.
9997 They weren't needed, since make_gap checks for buffer overflow.
9998 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9999 The old code merely checked for Emacs fixnum overflow, and relied
10000 on undefined (wraparound) behavior. The new code avoids undefined
10001 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10002
2e6813b0 10003 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10004 Tune. Don't use wider integers than needed. Don't use alloca.
10005 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10006
599a9e4f
PE
10007 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10008
99561444
PE
10009 * insdel.c, lisp.h (buffer_overflow): New function.
10010 (insert_from_buffer_1, replace_range, replace_range_2):
10011 * insdel.c (make_gap_larger):
10012 * editfns.c (Finsert_char):
10013 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10014
28177add
PE
10015 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10016
e69dafad
PE
100172011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10018
4baa020d 10019 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10020
b1c46f02
PE
10021 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10022 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10023
e69dafad
PE
10024 * fileio.c: Don't assume EMACS_INT fits in off_t.
10025 (emacs_lseek): New static function.
10026 (Finsert_file_contents, Fwrite_region): Use it.
10027 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10028
566684ea
PE
10029 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10030
e6966cd6
PE
10031 * fns.c: Don't overflow int when computing a list length.
10032 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10033 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10034 truncation on 64-bit hosts. Check for QUIT every
10035 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10036 faster and is responsive enough.
10037 (Flength): Report an error instead of overflowing an integer.
10038 (Fsafe_length): Return a float if the value is not representable
10039 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10040 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10041 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10042
dd0b0efb
PE
10043 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10044 (header_size, word_size): New constants.
10045 (allocate_vectorlike): Don't check size overflow here.
10046 (allocate_vector): Check it here instead, since this is the only
10047 caller of allocate_vectorlike that could cause overflow.
10048 Check that the new vector's length is representable as a fixnum.
10049
86fe5cfe
PE
10050 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10051 The previous code was bogus. For example, next_almost_prime (32)
10052 returned 39, which is undesirable as it is a multiple of 3; and
10053 next_almost_prime (24) returned 25, which is a multiple of 5 so
10054 why was the code bothering to check for multiples of 7?
10055
80e88859
PE
10056 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10057
4a2f0ad6
PE
10058 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10059
f66c7cf8
PE
10060 Variadic C functions now count arguments with ptrdiff_t.
10061 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10062 Back then I didn't know that the Emacs coding style prefers signed int.
10063 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10064 were being counted with int, which may truncate counts on 64-bit
10065 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10066 * lisp.h (struct Lisp_Subr.function.aMANY)
10067 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10068 Arg counts are now ptrdiff_t, not size_t.
10069 All variadic functions and their callers changed accordingly.
10070 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10071 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10072 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10073 * callint.c (Fcall_interactively): Check arg count for overflow,
10074 to avoid potential buffer overrun. Use signed char, not 'int',
10075 for 'varies' array, so that we needn't bother to check its size
10076 calculation for overflow.
10077 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10078 * eval.c (apply_lambda):
10079 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10080 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10081 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10082
a1759b76
PE
10083 * callint.c (Fcall_interactively): Don't use index var as event count.
10084
d96be9fc
PE
10085 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10086 * mem-limits.h (SIZE): Remove; no longer used.
10087
a690a978 10088 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10089
578c21e6
PE
10090 Remove unnecessary casts.
10091 * xterm.c (x_term_init):
10092 * xfns.c (x_set_border_pixel):
10093 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10094 These aren't needed now that we assume ANSI C.
10095
96f53c6c
PE
10096 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10097 It's more likely to cause problems (due to unsigned overflow)
10098 than to cure them.
10099
83c77d31
PE
10100 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10101
ee2079f1
PE
10102 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10103
6da65536
PE
10104 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10105
7147c4a4
PE
10106 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10107
193e32d9
PE
10108 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10109
e5533da6
PE
10110 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10111
9910e595
PE
10112 GLYPH_CODE_FACE returns EMACS_INT, not int.
10113 * dispextern.h (merge_faces):
10114 * xfaces.c (merge_faces):
01103c44
PE
10115 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10116 Don't assume EMACS_INT fits in int.
9910e595 10117
2638320e
PE
10118 * character.h (CHAR_VALID_P): Remove unused parameter.
10119 * fontset.c, lisp.h, xdisp.c: All uses changed.
10120
045eb8d9
PE
10121 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10122
c1f134b5
PE
10123 * fns.c (concat): Minor tuning based on overflow analysis.
10124 This doesn't fix any bugs. Use int to hold character, instead
10125 of constantly refetching from Emacs object. Use XFASTINT, not
10126 XINT, for value known to be a character. Don't bother comparing
10127 a single byte to 0400, as it's always less.
10128
395fcb93 10129 * floatfns.c (Fexpt):
327eeec8
PE
10130 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10131
abbd3d23
PE
10132 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10133 for characters.
10134
684a03ef
PE
10135 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10136
0fed43f3
PE
10137 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10138 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10139 incorrectly succeed when S was a string, because 4294967386 was
10140 truncated before it was used.
10141
8fd02eb7
PE
10142 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10143 Otherwise, an out-of-range integer could cause undefined behavior
10144 on a 64-bit host.
10145
f8c86b69
PE
10146 * composite.c: Use int, not EMACS_INT, for characters.
10147 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10148 EMACS_INT, for values that are known to be in character range.
10149 This doesn't fix any bugs but is the usual style inside Emacs and
10150 may generate better code on 32-bit machines.
10151
34206dd2
PE
10152 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10153 This is for reasons similar to the recent CHAR_STRING fix.
10154 * charset.c (Fencode_char): Check that character arg is actually
10155 a character. Pass an int to ENCODE_CHAR.
10156 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10157 wider than 'int', as a compile-time check to prevent future regressions
10158 in this area.
10159
c5958d4c 10160 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10161
10162 Make sure a 64-bit char is never passed to CHAR_STRING.
10163 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10164 by silently ignoring the top 32 bits, allowing some values
10165 that were far too large to be valid characters.
10166 * character.h: Include <verify.h>.
10167 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10168 arguments are no wider than unsigned, as a compile-time check
10169 to prevent future regressions in this area.
10170 * data.c (Faset):
01103c44 10171 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10172 (Fsubst_char_in_region):
10173 * fns.c (concat):
10174 * xdisp.c (decode_mode_spec_coding):
10175 Adjust to CHAR_STRING's new requirement.
10176 * editfns.c (Finsert_char, Fsubst_char_in_region):
10177 * fns.c (concat): Check that character args are actually
10178 characters. Without this test, these functions did the wrong
10179 thing with wildly out-of-range values on 64-bit hosts.
10180
d37ca623
PE
10181 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10182 These casts should not be needed on 32-bit hosts, either.
10183 * keyboard.c (read_char):
10184 * lread.c (Fload): Remove casts to unsigned.
10185
ea204efb
PE
10186 * lisp.h (UNSIGNED_CMP): New macro.
10187 This fixes comparison bugs on 64-bit hosts.
10188 (ASCII_CHAR_P): Use it.
10189 * casefiddle.c (casify_object):
01103c44 10190 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10191 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10192 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10193 * dispextern.h (FACE_FROM_ID):
10194 * keyboard.c (read_char): Use UNSIGNED_CMP.
10195
41cb286c
PE
10196 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10197 not to EMACS_INT, to avoid GCC warning.
10198
4a1b9832
PE
10199 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10200
55daad71
PE
10201 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10202 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10203 isn't needed on 32-bit machines.
8f95c75c 10204
01103c44
PE
10205 * buffer.c (Fgenerate_new_buffer_name):
10206 Use EMACS_INT for count, not int.
0ceccced 10207 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10208
10209 * data.c (Qcompiled_function): Now static.
10210
c6f072e7
PE
10211 * window.c (window_body_lines): Now static.
10212
20ce5912
PE
10213 * image.c (gif_load): Rename local to avoid shadowing.
10214
9c4c5f81
PE
10215 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10216 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10217 * alloc.c (make_save_value): Integer argument is now of type
10218 ptrdiff_t, not int.
10219 (mark_object): Use ptrdiff_t, not int.
10220 * lisp.h (pD): New macro.
10221 * print.c (print_object): Use it.
10222
c0c5c8ae
PE
10223 * alloc.c: Use EMACS_INT, not int, to count objects.
10224 (total_conses, total_markers, total_symbols, total_vector_size)
10225 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10226 (total_free_floats, total_floats, total_free_intervals)
10227 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10228 Now EMACS_INT, not int. All uses changed.
10229 (Fgarbage_collect): Compute overall total using a double, so that
10230 integer overflow is less likely to be a problem. Check for overflow
10231 when converting back to an integer.
5a25e253
PE
10232 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10233 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10234 These were 'int' variables that could overflow on 64-bit hosts;
10235 they were never used, so remove them instead of repairing them.
211a0b2a 10236 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10237 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10238 Previously, this ceilinged at INT_MAX, but that doesn't work on
10239 64-bit machines.
e46bb31a 10240 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10241
c78baabf 10242 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10243 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10244 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10245 when a (possibly-narrower) signed value would do just as well.
10246 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10247
c9d624c6
PE
10248 * alloc.c: Catch some string size overflows that we were missing.
10249 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10250 for convenience in STRING_BYTES_MAX.
10251 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10252 The definition here is exact; the one in lisp.h was approximate.
10253 (allocate_string_data): Check for string overflow. This catches
10254 some instances we weren't catching before. Also, it catches
10255 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10256 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10257 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10258
c9d624c6
PE
10259 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10260 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10261 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10262
353032ce
PE
10263 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10264
2bccce07
PE
10265 * alloc.c (Fmake_string): Check for out-of-range init.
10266
0ac30604
SM
102672011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10268
10269 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10270
c195f2de
JD
102712011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10272
10273 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10274 xg_get_default_scrollbar_width.
10275
10276 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10277 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10278 (style_changed_cb): Call update_theme_scrollbar_width and call
10279 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10280 all frames (Bug#8505).
10281 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10282 Call gtk_window_set_resizable if HAVE_GTK3.
10283 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10284 and height if HAVE_GTK3 (Bug#8505).
10285 (scroll_bar_width_for_theme): New variable.
10286 (update_theme_scrollbar_width): New function.
10287 (xg_get_default_scrollbar_width): Move code to
10288 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10289 (xg_initialize): Call update_theme_scrollbar_width.
10290
10291 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10292
10293 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10294
e10ac9f1
MR
102952011-06-12 Martin Rudalics <rudalics@gmx.at>
10296
10297 * frame.c (make_frame): Call other_buffer_safely instead of
10298 other_buffer.
10299
10300 * window.c (temp_output_buffer_show): Call display_buffer with
10301 second argument Vtemp_buffer_show_specifiers and reset latter
10302 immediately after the call.
10303 (Vtemp_buffer_show_specifiers): New variable.
10304 (auto_window_vscroll_p, next_screen_context_lines)
10305 (Vscroll_preserve_screen_position): Remove leading asterisks from
10306 doc-strings.
10307
2d3c217e 103082011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10309
7b7f97e8 10310 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10311 * buffer.c (Qclone_number): Remove for now, as it's unused.
10312 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10313 (record_buffer): Remove unused local.
10314 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10315 (set_frame_buffer_list): Remove; unused.
10316 * frame.h (other_visible_frames): Remove decl.
10317 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10318 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10319 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10320 if HAVE_GPM.
10321 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10322 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10323 Define only if HAVE_GPM.
10324 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10325 (update_hints_inhibit): Remove; never set. All uses removed.
10326 * widgetprv.h (emacsFrameClassRec): Remove decl.
10327 * window.c (delete_deletable_window): Now returns void, since it
10328 wasn't returning anything.
10329 (compare_window_configurations): Remove unused locals.
10330 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10331 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10332 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10333 the same widths as pointers. This follows up on the 2011-05-06 patch.
10334 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10335 * xterm.h: Likewise.
10336 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10337
1384b89e
JB
103382011-06-12 Juanma Barranquero <lekktu@gmail.com>
10339
10340 * makefile.w32-in: Update dependencies.
10341 (LISP_H): Add lib/intprops.h.
10342
1100a63c
CY
103432011-06-11 Chong Yidong <cyd@stupidchicken.com>
10344
10345 * image.c (gif_load): Add animation frame delay to the metadata.
10346 (syms_of_image): Use DEFSYM. New symbol `delay'.
10347
6198ccd0
MR
103482011-06-11 Martin Rudalics <rudalics@gmx.at>
10349
10350 * window.c (delete_deletable_window): Re-add.
10351 (Fset_window_configuration): Rewrite to handle dead buffers and
10352 consequently deletable windows.
10353 (window_tree, Fwindow_tree): Remove. Supply functionality in
10354 window.el.
10355 (compare_window_configurations): Simplify code.
10356
b6e3633c
AS
103572011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10358
1ab0dee5
AS
10359 * image.c (imagemagick_load_image): Fix type mismatch.
10360 (Fimagemagick_types): Likewise.
10361
b6e3633c
AS
10362 * window.h (replace_buffer_in_windows): Declare.
10363
9397e56f
MR
103642011-06-11 Martin Rudalics <rudalics@gmx.at>
10365
10366 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10367 Qclone_number. Remove external declaration of Qdelete_window.
10368 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10369 code.
640c8776
SM
10370 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10371 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10372 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10373 buffer list implementation.
10374 (other_buffer_safely): New function.
10375 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10376 calls to replace_buffer_in_windows and
10377 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10378 if allowed.
10379 (record_buffer): Inhibit quitting and rewrite using quittable
10380 functions. Run Qbuffer_list_update_hook if allowed.
10381 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10382 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10383 Move switch-to-buffer to window.el.
9397e56f
MR
10384 (bury-buffer): Move to window.el.
10385 (Vbuffer_list_update_hook): New variable.
10386
10387 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10388 section.
10389
10390 * window.h (resize_frame_windows): Move up in code.
10391 (Fwindow_frame): Remove EXFUN.
10392 (replace_buffer_in_all_windows): Remove prototype.
10393 (replace_buffer_in_windows_safely): Add prototype.
10394
10395 * window.c: Declare Qdelete_window static again. Move down
10396 declaration of select_count.
10397 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10398 (Fother_window): Move to window.el.
10399 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10400 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10401 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10402 window.el.
10403 (replace_buffer_in_windows): Implement by calling
10404 Qreplace_buffer_in_windows.
10405 (replace_buffer_in_all_windows): Remove with some functionality
10406 moved into replace_buffer_in_windows_safely.
10407 (replace_buffer_in_windows_safely): New function.
10408 (select_window_norecord, select_frame_norecord): Move in front
10409 of run_window_configuration_change_hook. Remove now obsolete
10410 declarations.
640c8776
SM
10411 (Fset_window_buffer): Rewrite doc-string.
10412 Call Qrecord_window_buffer.
9397e56f
MR
10413 (keys_of_window): Move binding for other-window to window.el.
10414
b50691aa
CY
104152011-06-11 Chong Yidong <cyd@stupidchicken.com>
10416
10417 * dispextern.h (struct image): Replace data member, whose int_val
10418 and ptr_val fields were not used by anything, with a single
10419 lisp_val object.
10420
10421 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10422 (gif_clear_image, gif_load, imagemagick_load_image)
10423 (gs_clear_image, gs_load): Callers changed.
10424
3f754b86
PE
104252011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10426
cca69397
PE
10427 * buffer.h: Include <time.h>, for time_t.
10428 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10429
109e28d0
PE
10430 Fix minor problems found by static checking.
10431
60737f02
PE
10432 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10433
4b66faf3
PE
10434 Make identifiers static if they are not used in other modules.
10435 * data.c (Qcompiled_function, Qframe, Qvector):
10436 * image.c (QimageMagick, Qsvg):
10437 * minibuf.c (Qmetadata):
10438 * window.c (resize_window_check, resize_root_window): Now static.
10439 * window.h (resize_window_check, resize_root_window): Remove decls.
10440
109e28d0
PE
10441 * window.c (window_deletion_count, delete_deletable_window):
10442 Remove; unused.
46a4ce9e
PE
10443 (window_body_lines): Now static.
10444 (Fdelete_other_windows_internal): Mark vars as initialized.
10445 Make sure 'resize_failed' is initialized.
10446 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10447 (resize_window_apply): Remove unused local.
10448 * window.h (delete_deletable_window): Remove decl.
10449
109e28d0 10450 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10451 (imagemagick_load_image): Fix pointer signedness problem by changing
10452 last arg from unsigned char * to char *. All uses changed.
10453 Also, fix a local for similar reasons.
10454 Remove unused locals. Remove locals to avoid shadowing.
10455 (fn_rsvg_handle_free): Remove; unused.
10456 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10457 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10458
3f754b86
PE
10459 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10460
2547adb1
CY
104612011-06-10 Chong Yidong <cyd@stupidchicken.com>
10462
10463 * image.c (gif_load): Fix omitted cast error introduced by
10464 2011-06-06 change.
10465
2c8e37d4
MR
104662011-06-10 Martin Rudalics <rudalics@gmx.at>
10467
10468 * window.h (resize_proportionally, orig_total_lines)
10469 (orig_top_line): Remove from window structure.
10470 (set_window_height, set_window_width, change_window_heights)
10471 (Fdelete_window): Remove prototypes.
10472 (resize_frame_windows): Remove duplicate declaration.
10473
440a42e3
EZ
104742011-06-10 Eli Zaretskii <eliz@gnu.org>
10475
10476 * window.h (resize_frame_windows, resize_window_check)
10477 (delete_deletable_window, resize_root_window)
10478 (resize_frame_windows): Declare prototypes.
10479
10480 * window.c (resize_window_apply): Make definition be "static" to
10481 match the prototype.
10482
562dd5e9
MR
104832011-06-10 Martin Rudalics <rudalics@gmx.at>
10484
10485 * window.c: Remove declarations of Qwindow_size_fixed,
10486 window_min_size_1, window_min_size_2, window_min_size,
10487 size_window, window_fixed_size_p, enlarge_window, delete_window.
10488 Remove static from declaration of Qdelete_window, it's
10489 temporarily needed by Fbury_buffer.
10490 (replace_window): Don't assign orig_top_line and
10491 orig_total_lines.
10492 (Fdelete_window, delete_window): Remove. Window deletion is
10493 handled by window.el.
640c8776
SM
10494 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10495 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10496 (Fdelete_other_windows): Remove. Deleting other windows is
10497 handled by window.el.
10498 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10499 handled in window.el.
10500 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10501 Window minimum sizes are handled in window.el.
10502 (shrink_windows, size_window, set_window_height)
10503 (set_window_width, change_window_heights, window_height)
10504 (window_width, CURBEG, CURSIZE, enlarge_window)
10505 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10506 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10507 handled in window.el.
10508 (make_dummy_parent): Rename to make_parent_window and give it a
10509 second argument horflag.
10510 (make_window): Don't set resize_proportionally any more.
10511 (Fsplit_window): Remove. Windows are split in window.el.
10512 (save_restore_action, save_restore_orig_size)
10513 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10514 Resize mini windows in window.el.
10515 (grow_mini_window, shrink_mini_window): Implement by calling
10516 Qresize_root_window_vertically, resize_window_check and
10517 resize_window_apply.
640c8776
SM
10518 (saved_window, Fset_window_configuration, save_window_save):
10519 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10520 resize_proportionally.
10521 (window_min_height, window_min_width): Move to window.el.
10522 (keys_of_window): Move bindings for delete-other-windows,
10523 split-window, delete-window and enlarge-window to window.el.
10524
10525 * buffer.c: Temporarily extern Qdelete_window.
10526 (Fbury_buffer): Temporarily call Qdelete_window instead of
10527 Fdelete_window (Fbury_buffer will move to window.el soon).
10528
10529 * frame.c (set_menu_bar_lines_1): Remove code handling
10530 orig_top_line and orig_total_lines.
10531
10532 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10533 set_window_height but set heights directly.
10534 (change_frame_size_1): Use resize_frame_windows.
10535
10536 * xdisp.c (init_xdisp): Don't use set_window_height but set
10537 heights directly.
10538
640c8776
SM
10539 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10540 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10541 run_window_configuration_change_hook.
10542
10543 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10544 instead of change_window_heights and run
10545 run_window_configuration_change_hook.
10546
1a13852e
MR
105472011-06-09 Martin Rudalics <rudalics@gmx.at>
10548
10549 * window.c (replace_window): Rename second argument REPLACEMENT to
10550 NEW. New third argument SETFLAG. Rewrite.
10551 (delete_window, make_dummy_parent): Call replace_window with
10552 third argument 1.
10553 (window_list_1): Move down in code.
10554 (run_window_configuration_change_hook): Move set_buffer part
10555 before select_frame_norecord part in order to unwind correctly.
10556 Rename count1 to count.
10557 (recombine_windows, delete_deletable_window, resize_root_window)
10558 (Fdelete_other_windows_internal)
10559 (Frun_window_configuration_change_hook, make_parent_window)
10560 (resize_window_check, resize_window_apply, Fresize_window_apply)
10561 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10562 (Fdelete_window_internal, Fresize_mini_window_internal):
10563 New functions.
1a13852e
MR
10564 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10565
f3d1777e
MR
105662011-06-08 Martin Rudalics <rudalics@gmx.at>
10567
496e208e
MR
10568 * window.h (window): Add some new members to window structure -
10569 normal_lines, normal_cols, new_total, new_normal, clone_number,
10570 splits, nest, prev_buffers, next_buffers.
10571 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10572 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10573
f3d1777e
MR
10574 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10575 Remove.
496e208e
MR
10576 (make_dummy_parent): Set new members of windows structure.
10577 (make_window): Move down in code. Handle new members of window
10578 structure.
10579 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10580 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10581 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10582 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10583 (Fset_window_next_buffers, Fset_window_clone_number):
10584 New functions.
496e208e
MR
10585 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10586 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10587 Doc-string fixes.
10588 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10589 Argument WINDOW can be now internal window too.
10590 (Fwindow_use_time): Move up in code.
10591 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10592 Rewrite doc-string.
10593 (Fset_window_configuration, saved_window)
10594 (Fcurrent_window_configuration, save_window_save): Handle new
10595 members of window structure.
b9e809c2
MR
10596 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10597 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10598 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10599 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10600 Qget_mru_window, Qresize_root_window,
10601 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10602 Qauto_buffer_name; staticpro them.
f3d1777e 10603
abde8f8c
MR
106042011-06-07 Martin Rudalics <rudalics@gmx.at>
10605
10606 * window.c (Fwindow_total_size, Fwindow_left_column)
10607 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10608 (Fwindow_list_1): New functions.
10609 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10610 (Fwindow_width, Fscroll_left, Fscroll_right):
10611 Use window_body_cols instead of window_box_text_cols.
10612 (delete_window, Fset_window_configuration):
10613 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10614 (delete_all_subwindows): Take a window as argument and not a
10615 structure. Rewrite.
190b47e6
MR
10616 (window_loop): Remove handling of GET_LRU_WINDOW and
10617 GET_LARGEST_WINDOW.
10618 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10619
10620 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10621 window_box_text_cols. delete_all_subwindows now takes a
10622 Lisp_Object as argument.
abde8f8c 10623
640c8776
SM
10624 * indent.c (compute_motion, Fcompute_motion):
10625 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10626
fa8a67e6
MR
10627 * frame.c (delete_frame): Call delete_all_subwindows with root
10628 window as argument.
10629
a54e3482
DC
106302011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10631
10632 * fns.c (Fputhash): Document return value.
10633
60002bf5
CY
106342011-06-06 Chong Yidong <cyd@stupidchicken.com>
10635
10636 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10637
0c671da6 106382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10639
b862a52a 10640 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10641
be44ca6c
PE
10642 Check for overflow when converting integer to cons and back.
10643 * charset.c (Fdefine_charset_internal, Fdecode_char):
10644 Use cons_to_unsigned to catch overflow.
10645 (Fencode_char): Use INTEGER_TO_CONS.
10646 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10647 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10648 * data.c (long_to_cons, cons_to_long): Remove.
10649 (cons_to_unsigned, cons_to_signed): New functions.
10650 These signal an error for invalid or out-of-range values.
10651 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10652 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10653 * font.c (Ffont_variation_glyphs):
10654 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10655 * lisp.h: Include <intprops.h>.
10656 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10657 (cons_to_signed, cons_to_unsigned): New decls.
10658 (long_to_cons, cons_to_long): Remove decls.
10659 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10660 (Fprimitive_undo): Use CONS_TO_INTEGER.
10661 * xfns.c (Fx_window_property): Likewise.
10662 * xselect.c: Include <limits.h>.
10663 (x_own_selection, selection_data_to_lisp_data):
10664 Use INTEGER_TO_CONS.
10665 (x_handle_selection_request, x_handle_selection_clear)
10666 (x_get_foreign_selection, Fx_disown_selection_internal)
10667 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10668 (lisp_data_to_selection_data): Use cons_to_unsigned.
10669 (x_fill_property_data): Use cons_to_signed.
10670 Report values out of range.
10671
d1f3d2af
PE
10672 Check for buffer and string overflow more precisely.
10673 * buffer.h (BUF_BYTES_MAX): New macro.
10674 * lisp.h (STRING_BYTES_MAX): New macro.
10675 * alloc.c (Fmake_string):
10676 * character.c (string_escape_byte8):
10677 * coding.c (coding_alloc_by_realloc):
10678 * doprnt.c (doprnt):
10679 * editfns.c (Fformat):
10680 * eval.c (verror):
10681 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10682 since they may not be the same number.
10683 * editfns.c (Finsert_char):
10684 * fileio.c (Finsert_file_contents):
10685 Likewise for BUF_BYTES_MAX.
10686
dd52fcea
PE
10687 * image.c: Use ptrdiff_t, not int, for sizes.
10688 (slurp_file): Switch from int to ptrdiff_t.
10689 All uses changed.
10690 (slurp_file): Check that file size fits in both size_t (for
10691 malloc) and ptrdiff_t (for sanity and safety).
10692
7f9bbdbb
PE
10693 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10694 if b->modtime has its maximal value.
10695
dfe18f82
PE
10696 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10697
84acfcf0
PE
10698 Don't assume time_t can fit into int.
10699 * buffer.h (struct buffer.modtime): Now time_t, not int.
10700 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10701 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10702
ccd9a01a
PE
10703 Minor fixes for signed vs unsigned integers.
10704 * character.h (MAYBE_UNIFY_CHAR):
10705 * charset.c (maybe_unify_char):
10706 * keyboard.c (read_char, reorder_modifiers):
10707 XINT -> XFASTINT, since the integer must be nonnegative.
10708 * ftfont.c (ftfont_spec_pattern):
10709 * keymap.c (access_keymap, silly_event_symbol_error):
10710 XUINT -> XFASTINT, since the integer must be nonnegative.
10711 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10712 since it makes no difference and we prefer signed.
10713 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10714 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10715 nonnegative.
10716
d6d100dd
SM
107172011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10718
10719 * window.h (Fwindow_frame): Declare.
10720
2b6148e4
PE
107212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10722
10723 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10724 (SPARE_MEMORY): Always define.
10725 (LARGE_REQUEST): Remove.
10726 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10727
f230ecc9
MR
107282011-06-06 Martin Rudalics <rudalics@gmx.at>
10729
727e958e
MR
10730 * lisp.h: Move EXFUNS for Fframe_root_window,
10731 Fframe_first_window and Fset_frame_selected_window to window.h.
10732
10733 * window.h: Move EXFUNS for Fframe_root_window,
10734 Fframe_first_window and Fset_frame_selected_window here from
10735 lisp.h.
10736
10737 * frame.c (Fwindow_frame, Fframe_first_window)
10738 (Fframe_root_window, Fframe_selected_window)
10739 (Fset_frame_selected_window): Move to window.c.
10740 (Factive_minibuffer_window): Move to minibuf.c.
10741 (Fother_visible_frames_p): New function.
10742
10743 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10744
f230ecc9
MR
10745 * window.c (decode_window, decode_any_window): Move up in code.
10746 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10747 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10748 (Fwindow_buffer): Move up and rewrite doc-string.
10749 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10750 (Fwindow_prev): New functions.
727e958e
MR
10751 (Fwindow_frame): Move here from frame.c. Accept any window as
10752 argument.
10753 (Fframe_root_window, Fframe_first_window)
10754 (Fframe_selected_window): Move here from frame.c. Accept frame
10755 or arbitrary window as argument. Update doc-strings.
10756 (Fminibuffer_window): Move up in code.
10757 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10758 (Fset_frame_selected_window): Move here from frame.c.
10759 Marginal rewrite.
727e958e
MR
10760 (Fselected_window, select_window, Fselect_window): Move up in
10761 code. Minor doc-string fixes.
f230ecc9 10762
4d09bcf6
PE
107632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10764
10765 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10766 Do not assume that spare memory exists; that assumption is valid
10767 only if SYSTEM_MALLOC.
10768 (LARGE_REQUEST): New macro, so that the issue of large requests
10769 is separated from the issue of spare memory.
10770
810928a2
AS
107712011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10772
172418ad
AS
10773 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10774 format. (Bug#8806)
10775
43f862f7
AS
10776 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10777
810928a2
AS
10778 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10779 before statements.
10780
a059fe24
JD
107812011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10782
10783 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10784
10785 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10786
10787 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10788 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10789
989bf368
JB
107902011-06-05 Juanma Barranquero <lekktu@gmail.com>
10791
10792 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10793
4b80f674
CY
107942011-06-04 Chong Yidong <cyd@stupidchicken.com>
10795
10796 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10797 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10798 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10799 New error handlers.
4b80f674
CY
10800 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10801 Obey Vx_select_enable_clipboard_manager. Catch errors in
10802 x_clipboard_manager_save (Bug#8779).
10803 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10804 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10805
99a33b77 108062011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10807
10808 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10809
99a33b77 108102011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10811
10812 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10813 in the current matrix if keep_current_p is non-zero.
10814
8264569d
EZ
108152011-06-04 Eli Zaretskii <eliz@gnu.org>
10816
10817 * bidi.c (bidi_level_of_next_char): Fix last change.
10818
57f97249
EZ
108192011-06-03 Eli Zaretskii <eliz@gnu.org>
10820
fec2107c 10821 Support bidi reordering of text covered by display properties.
57f97249 10822
fec2107c
EZ
10823 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10824 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10825 (bidi_cache_search, bidi_cache_iterator_state)
10826 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10827 (bidi_level_of_next_char, bidi_move_to_visually_next):
10828 Support character positions inside a run of characters covered by a
fec2107c
EZ
10829 display string.
10830 (bidi_paragraph_init, bidi_resolve_explicit_1)
10831 (bidi_level_of_next_char): Call bidi_fetch_char and
10832 bidi_fetch_char_advance instead of FETCH_CHAR and
10833 FETCH_CHAR_ADVANCE.
10834 (bidi_init_it): Initialize new members.
10835 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10836 definitions.
10837 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10838 instead of using explicit *_CHAR codes.
d6d100dd
SM
10839 (bidi_resolve_explicit, bidi_resolve_weak):
10840 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10841 bidirectional text is supported only in multibyte buffers.
10842 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10843 it to initialize the frame_window_p member of struct bidi_it.
10844 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10845 (bidi_resolve_explicit, bidi_resolve_weak)
10846 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10847 bidi_it->nchars is non-positive.
10848 (bidi_level_of_next_char): Don't try to lookup the cache for the
10849 next/previous character if nothing is cached there yet, or if we
10850 were just reseat()'ed to a new position.
c40e2fb2 10851
0e14fe90
EZ
10852 * xdisp.c (set_cursor_from_row): Set start and stop points
10853 according to the row's direction when priming the loop that looks
10854 for the glyph on which to display cursor.
10855 (single_display_spec_intangible_p): Function deleted.
10856 (display_prop_intangible_p): Reimplement to call
10857 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10858 Accept 3 additional arguments needed by handle_display_spec.
10859 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10860 values: lists, `(when COND...)' forms, etc.
10861 (single_display_spec_string_p): Support property values that are
10862 lists with the argument STRING its top-level element.
10863 (display_prop_string_p): Fix the condition for processing a
10864 property that is a list to be consistent with handle_display_spec.
fec2107c 10865 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10866 last portion of handle_display_prop.
10867 (compute_display_string_pos): Accept additional argument
10868 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10869 value of a `display' property is a "replacing spec".
10870 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10871 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10872 the display property, but just return a value indicating whether
10873 the display property will replace the characters it covers.
10874 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10875 frame_window_p members of struct bidi_it.
d6d100dd
SM
10876 (compute_display_string_pos, compute_display_string_end):
10877 New functions.
fec2107c
EZ
10878 (push_it): Accept second argument POSITION, where pop_it should
10879 jump to continue iteration.
10880 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10881
fec2107c
EZ
10882 * keyboard.c (adjust_point_for_property): Adjust the call to
10883 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10884
10885 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10886 (bidi_init_it): Update prototypes.
10887 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10888 (compute_display_string_pos, compute_display_string_end):
10889 Declare prototypes.
fec2107c
EZ
10890 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10891 EMACS_INT.
fc6f18ce 10892
40087514 108932011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10894
57f53182
PE
10895 Malloc failure behavior now depends on size of allocation.
10896 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10897 * lisp.h: Change signatures accordingly.
10898 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10899 All callers changed. (Bug#8762)
10900
10901 * gnutls.c: Use Emacs's memory allocators.
10902 Without this change, the gnutls library would invoke malloc etc.
10903 directly, which causes problems on non-SYNC_INPUT hosts, and which
10904 runs afoul of improving memory_full behavior. (Bug#8761)
10905 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10906 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10907 xfree instead of the default malloc, realloc, free.
10908 (Fgnutls_boot): No need to check for memory allocation failure,
10909 since xmalloc does that for us.
10910
ac32cd99 10911 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10912 * category.c (hash_get_category_set):
10913 * ccl.c (ccl_driver):
10914 * charset.c (Fdefine_charset_internal):
10915 * charset.h (struct charset.hash_index):
10916 * composite.c (get_composition_id, gstring_lookup_cache)
10917 (composition_gstring_put_cache):
10918 * composite.h (struct composition.hash_index):
10919 * dispextern.h (struct image.hash):
10920 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10921 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10922 (hashfn_equal, hashfn_user_defined, make_hash_table)
10923 (maybe_resize_hash_table, hash_lookup, hash_put)
10924 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10925 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10926 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10927 * image.c (make_image, search_image_cache, lookup_image)
10928 (xpm_put_color_table_h):
10929 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10930 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10931 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10932 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10933 * alloc.c (allocate_vectorlike):
10934 Check for overflow in vector size calculations.
10935 * ccl.c (ccl_driver):
10936 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10937 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10938 need to be updated by these changes.
40087514
PE
10939 * fns.c (make_hash_table, maybe_resize_hash_table):
10940 Check for integer overflow with large hash tables.
0de4bb68
PE
10941 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10942 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10943 (SXHASH_REDUCE): New macro.
10944 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10945 Use it instead of discarding useful hash info with large hash values.
10946 (sxhash_float): New function.
10947 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10948 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10949 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10950 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10951 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10952 Adjust signatures to match updated version of code.
10953 (consing_since_gc): Now EMACS_INT, since a single hash table can
10954 use more than INT_MAX bytes.
10955
698d32e2
DN
109562011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10957
10958 Make it possible to build with GCC-4.6+ -O2 -flto.
10959
10960 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10961
fd6fa53f
SM
109622011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10963
10964 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10965 Call minibuffer-inactive-mode.
10966
864db017
JB
109672011-05-31 Juanma Barranquero <lekktu@gmail.com>
10968
10969 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10970 Update dependencies.
10971
2ad0baf4
DN
109722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10973
10974 * data.c (init_data): Remove code for UTS, this system is not
10975 supported anymore.
10976
4fcc2638
DN
109772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10978
10979 Don't force ./temacs to start in terminal mode.
10980
10981 * frame.c (make_initial_frame): Initialize faces in all cases, not
10982 only when CANNOT_DUMP is defined.
10983 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10984
c56e0fd5
DN
109852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10986
10987 * dispnew.c (add_window_display_history): Use const for the string
10988 pointer. Remove declaration, not needed.
10989
333d54da 109902011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10991
55d4c1b2 10992 Use 'inline', not 'INLINE'.
333d54da 10993 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10994 * alloc.c, fontset.c (INLINE): Remove.
10995 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10996 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10997 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10998 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10999 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11000
738db178
DN
110012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11002
11003 Make it possible to run ./temacs.
11004
11005 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11006 syms_of_callproc does the same thing. Remove test for
11007 "initialized", do it in the caller.
11008 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11009
620c53a6
SM
110102011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11011
11012 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11013 (read_minibuf): Use get_minibuffer.
11014 (syms_of_minibuf): Use DEFSYM.
11015 (Qmetadata): New var.
11016 * data.c (Qbuffer): Don't make it static.
11017 (syms_of_data): Use DEFSYM.
11018
e003a292
PE
110192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11020
11021 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11022 (CCL_CODE_MIN): New macro.
11023
ed008a6d
PE
110242011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11025
3687c2ef
PE
11026 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11027
ed008a6d
PE
11028 * eval.c (Qdebug): Now static.
11029 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11030 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11031 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11032
d66c4c7c
CY
110332011-05-29 Chong Yidong <cyd@stupidchicken.com>
11034
11035 * image.c: Various fixes to ImageMagick code comments.
11036 (Fimagemagick_types): Doc fix.
11037
5fbc2025
PE
110382011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11039
0196f88a
PE
11040 Minor fixes prompted by GCC 4.6.0 warnings.
11041
11042 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11043
5fbc2025
PE
11044 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11045 (x_clipboard_manager_save_all): Move extern decl to ...
11046 * xterm.h: ... here, so that it can be checked for consistency.
11047
1dd3c2d9
CY
110482011-05-29 Chong Yidong <cyd@stupidchicken.com>
11049
11050 * xselect.c (x_clipboard_manager_save_frame)
11051 (x_clipboard_manager_save_all): New functions.
11052 (Fx_clipboard_manager_save): Lisp function deleted.
11053
11054 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11055 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11056
11057 * xterm.h: Update prototype.
11058
5ba6571d
WX
110592011-05-28 William Xu <william.xwl@gmail.com>
11060
11061 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11062 exiting (Bug#8239).
11063
3eaff834
JM
110642011-05-28 Jim Meyering <meyering@redhat.com>
11065
e1900994 11066 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11067 * fns.c (to_uchar): Define.
11068 (crypto_hash_function): Use it to convert some newly-signed
11069 variables to unsigned, to avoid sign-extension bugs. For example,
11070 without this change, (md5 "truc") would evaluate to
11071 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11072 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11073 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11074
0f6990a7
PE
110752011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11076
11077 Integer overflow fixes.
c8a9ca5a 11078
08686060
PE
11079 * dbusbind.c: Serial number integer overflow fixes.
11080 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11081 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11082 to hold a serial number that is too large for a fixnum.
11083 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11084 Check for serial numbers out of range. Decode any serial number
59568bf0 11085 that was so large that it became a float. (Bug#8722)
08686060 11086
2d1fc3c7
PE
11087 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11088 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11089 Use XFASTINT rather than XUINT when numbers are nonnegative.
11090 (xd_append_arg, Fdbus_method_return_internal):
11091 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11092 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11093 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11094 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11095 (Bug#8722)
2d1fc3c7 11096
c8a9ca5a
PE
11097 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11098
519e1d69
PE
11099 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11100
6df6ae42 11101 ccl: Add integer overflow checks.
30569699
PE
11102 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11103 (IN_INT_RANGE): New macros.
11104 (ccl_driver): Use them to check for integer overflow when
11105 decoding a CCL program. Many of the new checks are whether XINT (x)
11106 fits in int; it doesn't always, on 64-bit hosts. The new version
11107 doesn't catch all possible integer overflows, but it's an
847044ea 11108 improvement. (Bug#8719)
30569699 11109
c11285dc
PE
11110 * alloc.c (make_event_array): Use XINT, not XUINT.
11111 There's no need for unsigned here.
11112
fdccd48e
PE
11113 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11114 This follows up to the 2011-05-06 change that substituted uintptr_t
11115 for EMACS_INT. This case wasn't caught back then.
11116
37910ab2
PE
11117 Rework Fformat to avoid integer overflow issues.
11118 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11119 now (part of C89). Include <verify.h>.
11120 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11121 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11122 (Fformat): Avoid the prepass trying to compute sizes; it was only
11123 approximate and thus did not catch overflow reliably. Instead, walk
11124 through the format just once, formatting and computing sizes as we go,
11125 checking for integer overflow at every step, and allocating a larger
11126 buffer as needed. Keep track separately whether the format is
11127 multibyte. Keep only the most-recently calculated precision, rather
11128 than them all. Record whether each argument has been converted to
11129 string. Use EMACS_INT, not int, for byte and char and arg counts.
11130 Support field widths and precisions larger than INT_MAX. Avoid
11131 sprintf's undefined behavior with conversion specifications such as %#d
11132 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11133 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11134 formatting out-of-range floating point numbers with int
9173deec 11135 formats. (Bug#8668)
37910ab2 11136
2e6578fb
PE
11137 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11138
0ae6bdee
PE
11139 * data.c: Avoid integer truncation in expressions involving floats.
11140 * data.c: Include <intprops.h>.
11141 (arith_driver): When there's an integer overflow in an expression
11142 involving floating point, convert the integers to floating point
11143 so that the resulting value does not suffer from catastrophic
11144 integer truncation. For example, on a 64-bit host (* 4
11145 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11146 Do not rely on undefined behavior after integer overflow.
11147
de883a70
PE
11148 merge count_size_as_multibyte, parse_str_to_multibyte
11149 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11150 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11151 Check for integer overflow.
11152 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11153 since it's now a duplicate of the other. This is more of
11154 a character than a buffer op, so better that it's in character.c.
11155 * fns.c, print.c: Adjust to above changes.
11156
2ff916cb
PE
111572011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11158
11159 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11160
f1b54466
PE
111612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11162
fb1ac845
PE
11163 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11164 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11165 (x_clipboard_manager_save): Now static.
11166 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11167
f1b54466
PE
11168 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11169 (crypto_hash_function): Now static.
11170 Fix pointer signedness problems. Avoid unnecessary initializations.
11171
a9f737ee
CY
111722011-05-27 Chong Yidong <cyd@stupidchicken.com>
11173
11174 * termhooks.h (Vselection_alist): Make it terminal-local.
11175
11176 * terminal.c (create_terminal): Initialize it.
11177
11178 * xselect.c: Support for clipboard managers.
11179 (Vselection_alist): Move to termhooks.h as terminal-local var.
11180 (LOCAL_SELECTION): New macro.
11181 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11182 (symbol_to_x_atom): Remove gratuitous arg.
11183 (x_handle_selection_request, lisp_data_to_selection_data)
11184 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11185 (x_own_selection, x_get_local_selection, x_convert_selection):
11186 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11187 (some_frame_on_display): Delete unused function.
11188 (Fx_own_selection_internal, Fx_get_selection_internal)
11189 (Fx_disown_selection_internal, Fx_selection_owner_p)
11190 (Fx_selection_exists_p): New optional frame arg.
11191 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11192 (x_handle_selection_clear): Don't treat other terminals with the
11193 same keyboard specially. Use the terminal-local Vselection_alist.
11194 (x_clear_frame_selections): Use Frun_hook_with_args.
11195
11196 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11197
11198 * xterm.h: Add support for those atoms.
11199
e067f0c1
CY
112002011-05-26 Chong Yidong <cyd@stupidchicken.com>
11201
11202 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11203 (converted_selections, conversion_fail_tag): New global variables.
11204 (x_selection_request_lisp_error): Free the above.
11205 (x_get_local_selection): Remove unnecessary code.
11206 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11207 of converted selections stored in converted_selections.
11208 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11209 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11210 (x_convert_selection): New function.
11211 (x_handle_selection_event): Simplify.
11212 (x_get_foreign_selection): Don't ignore incoming requests while
11213 waiting for an answer; this will fail when we implement
11214 SAVE_TARGETS, and seems unnecessary anyway.
11215 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11216 (Vx_sent_selection_functions): Doc fix.
11217
0f4aebc0
LL
112182011-05-26 Leo Liu <sdl.web@gmail.com>
11219
11220 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11221
e61124cd
YM
112222011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11223
11224 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11225
11226 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11227 for fringe update if it has periodic bitmap.
ac389d0c 11228 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11229 and fringe_bitmap_periodic_p.
11230
11231 * fringe.c (get_fringe_bitmap_data): New function.
11232 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11233 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11234 row. Mark glyph row for fringe update if periodicity changed.
11235
11236 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11237 for fringe update unless it has periodic bitmap.
11238
f16d9837
KH
112392011-05-25 Kenichi Handa <handa@m17n.org>
11240
11241 * xdisp.c (get_next_display_element): Set correct it->face_id for
11242 a static composition.
11243
e1b90ef6
LL
112442011-05-24 Leo Liu <sdl.web@gmail.com>
11245
11246 * deps.mk (fns.o):
11247 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11248
11249 * fns.c (crypto_hash_function, Fsha1): New function.
11250 (Fmd5): Use crypto_hash_function.
11251 (syms_of_fns): Add Ssha1.
11252
7400048f
PE
112532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11254
11255 * gnutls.c: Remove unused macros.
11256 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11257 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11258 Remove macros that are defined and never used.
11259 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11260
abb71cf4
CY
112612011-05-22 Chong Yidong <cyd@stupidchicken.com>
11262
11263 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11264 (Fx_get_selection_internal): Minor cleanup.
11265 (Fx_own_selection_internal): Rename arguments for consistency with
11266 select.el.
11267
6307db39
PE
112682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11269
11270 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11271
f3d4e0a4
CY
112722011-05-22 Chong Yidong <cyd@stupidchicken.com>
11273
11274 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11275
4d8ade89
YM
112762011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11277
11278 * dispnew.c (scrolling_window): Don't exclude the case that the
11279 last enabled row in the desired matrix touches the bottom boundary.
11280
32078c8d
GM
112812011-05-21 Glenn Morris <rgm@gnu.org>
11282
11283 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11284 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11285 and add some more files.
32078c8d 11286
7285dc67
EZ
112872011-05-20 Eli Zaretskii <eliz@gnu.org>
11288
11289 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11290 report_file_error introduced by the change from 2011-05-07.
11291
89d1bd22
PE
112922011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11293
11294 * systime.h (Time): Define only if emacs is defined.
11295 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11296 where the include path doesn't have X11/X.h by default. See
11297 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11298
cd394be1 112992011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11300
11301 * composite.c (find_automatic_composition): Fix previous change.
11302
b9704ad9
GM
113032011-05-20 Glenn Morris <rgm@gnu.org>
11304
11305 * lisp.mk: New file, split from Makefile.in.
11306 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11307 (shortlisp): Remove.
11308 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11309
4a720484
GM
113102011-05-19 Glenn Morris <rgm@gnu.org>
11311
11312 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11313 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11314 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11315 (lisp): Set the order to that of loadup.el.
11316 (shortlisp): Make it a copy of $lisp.
11317 (SOME_MACHINE_LISP): Remove.
11318 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11319 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11320
a28d4396
KH
113212011-05-18 Kenichi Handa <handa@m17n.org>
11322
11323 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11324 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11325 (find_automatic_composition): Mostly rewrite for efficiency.
11326
a2b1fa8e
JB
113272011-05-18 Juanma Barranquero <lekktu@gmail.com>
11328
11329 * makefile.w32-in: Update dependencies.
11330
8e1f5610
CS
113312011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11332
11333 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11334 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11335
7025ee00 113362011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11337
cdfa6eab
PE
11338 Fix some integer overflow issues, such as string length overflow.
11339
06d6db33
PE
11340 * insdel.c (count_size_as_multibyte): Check for string overflow.
11341
2b4560a8
PE
11342 * character.c (lisp_string_width): Check for string overflow.
11343 Use EMACS_INT, not int, for string indexes and lengths; in
11344 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11345 the resulting string length overflows an EMACS_INT; instead,
11346 report a string overflow if no precision given. When checking for
11347 precision exhaustion, use a check that cannot possibly have
11348 integer overflow. (Bug#8675)
11349 * character.h (lisp_string_width): Adjust to new signature.
11350
cb93f9be
PE
11351 * alloc.c (string_overflow): New function.
11352 (Fmake_string): Use it. This doesn't change behavior, but saves
11353 a few bytes and will simplify future changes.
11354 * character.c (string_escape_byte8): Likewise.
11355 * lisp.h (string_overflow): New decl.
11356
1a1f3366
PE
11357 Fixups, following up to the user-interface timestamp change.
11358 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11359 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11360 * msdos.c (mouse_get_pos): Likewise.
11361 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11362 * w32gui.h (Time): Define by including "systime.h" rather than by
11363 declaring it ourselves. (Bug#8664)
11364
d4e3e4d3
PE
11365 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11366 * image.c (clear_image_cache): Likewise.
11367
f6a24d19
PE
11368 * term.c (term_mouse_position): Don't assume time_t wraparound.
11369
08dc5ae6
PE
11370 Be more systematic about user-interface timestamps.
11371 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11372 and sometimes 'EMACS_UINT', to represent these timestamps.
11373 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11374 This makes the code easier to follow, and makes it easier to catch
11375 integer overflow bugs such as Bug#8664.
11376 * frame.c (Fmouse_position, Fmouse_pixel_position):
11377 Use Time, not unsigned long, for user-interface timestamps.
11378 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11379 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11380 * keyboard.h (last_event_timestamp): Likewise.
11381 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11382 * menu.h (xmenu_show): Likewise.
11383 * term.c (term_mouse_position): Likewise.
11384 * termhooks.h (struct input_event.timestamp): Likewise.
11385 (struct terminal.mouse_position_hook): Likewise.
11386 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11387 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11388 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11389 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11390 what it was before.
11391 * menu.h, termhooks.h: Include "systime.h", for Time.
11392
8e55734a
PE
11393 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11394 Don't assume that the difference between two unsigned long values
11395 can fit into an integer. At this point, we know button_down_time
11396 <= event->timestamp, so the difference must be nonnegative, so
11397 there's no need to cast the result if double-click-time is
11398 nonnegative, as it should be; check that it's nonnegative, just in
11399 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11400 apart (about 25 days). (Bug#8664)
8e55734a 11401
841f1b75 11402 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11403 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11404
3e26f69c
PE
11405 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11406 that always fit in int. Use a sentinel instead of a counter, to
11407 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11408 * frame.h (struct frame): Use int for menu_bar_items_used
11409 instead of EMACS_INT, since it always fits in int.
3e26f69c 11410
5cc152c0
PE
11411 * menu.c (grow_menu_items): Check for int overflow.
11412
d89eb65e
PE
11413 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11414
5235bd3e
PE
11415 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11416 Before, the code was not consistent. These values cannot exceed
11417 2**31 - 1 so there's no need to make them unsigned.
11418 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11419 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11420 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11421 as modifiers.
11422 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11423
bc827e23
PE
11424 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11425 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11426 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11427 presumably because the widths might not match.
11428
78eb494e
PE
11429 * window.c (size_window): Avoid needless test at loop start.
11430
04f2d78b
CB
114312011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11432
11433 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11434
d2fc7e3d 114352011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11436
11437 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11438
d2fc7e3d 114392011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11440
11441 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11442 `width' to `bar_area_x' and `bar_area_width', respectively.
11443 (x_scroll_run): Take account of fringe background extension.
11444
04f2d78b
CB
11445 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11446 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11447 `bar_area_width', respectively.
11448 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11449 background extension.
11450
79b70037
GM
114512011-05-10 Jim Meyering <meyering@redhat.com>
11452
11453 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11454
2f142cc5
JB
114552011-05-10 Juanma Barranquero <lekktu@gmail.com>
11456
11457 * image.c (Finit_image_library): Return t for built-in image types,
11458 like pbm and xbm. (Bug#8640)
11459
57679c86
AS
114602011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11461
11462 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11463
888c9e86
EZ
114642011-05-07 Eli Zaretskii <eliz@gnu.org>
11465
b0512a1d
EZ
11466 * w32console.c (Fset_screen_color): Doc fix.
11467 (Fget_screen_color): New function.
11468 (syms_of_ntterm): Defsubr it.
11469
7285dc67
EZ
11470 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11471 unlink the temporary file if Fcall_process didn't create it in the
11472 first place.
11473 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11474 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11475 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11476 cue to call_process_cleanup not to close that handle.
11477
4d3fcc8e
BK
114782011-05-07 Ben Key <bkey76@gmail.com>
11479
11480 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11481 one of two shell specific rules, either bootstrap-temacs-CMD or
11482 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11483 to the previous implementation of the bootstrap-temacs rule.
11484 The bootstrap-temacs-CMD rule is similar to the previous
11485 implementation of the bootstrap-temacs rule except that it
11486 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11487 variable.
11488
11489 These changes, along with some changes to nt/configure.bat,
11490 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11491 earlier fix to add support for --cflags and --ldflags options
11492 that include quotes so that it works whether make uses cmd or
11493 sh as the shell.
11494
b4289b64
MA
114952011-05-06 Michael Albinus <michael.albinus@gmx.de>
11496
11497 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11498 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11499 is a constant.
11500 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11501 a string. Handle both cases.
11502 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11503 (Fdbus_register_method): Use Qinvalid_function.
11504
af4c0e28
JB
115052011-05-06 Juanma Barranquero <lekktu@gmail.com>
11506
11507 * makefile.w32-in: Update dependencies.
11508 (LISP_H): Add inttypes.h and stdin.h.
11509 (PROCESS_H): Add unistd.h.
11510
c51453d9
EZ
115112011-05-06 Eli Zaretskii <eliz@gnu.org>
11512
11513 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11514 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11515
8ff0ac3c 115162011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11517
4c4b566b
PE
11518 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11519
aab2b9b5
PE
11520 * term.c (vfatal): Remove stray call to va_end.
11521 It's not needed and the C Standard doesn't allow it here anyway.
11522
c378da0b
PE
11523 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11524 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11525
288b08c7
PE
11526 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11527 bytes.
11528
e3601888
PE
11529 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11530
db6c0e74
PE
11531 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11532
dd5963ea
PE
11533 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11534
88c9450f
PE
11535 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11536
2f9442b8
PE
11537 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11538
c032b5f8
PE
11539 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11540 * charset.c (Fdefine_charset_internal): Don't initialize
11541 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11542 32-bit int (Bug#8600).
a108c10b
PE
11543
11544 * lread.c (read_integer): Be more consistent with string-to-number.
11545 Use string_to_number to do the actual conversion; this avoids
11546 rounding errors and fixes some other screwups. Without this fix,
11547 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11548 (digit_to_number): Move earlier, for benefit of read_integer.
11549 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11550 not a digit in any supported base. (Bug#8602)
a108c10b 11551
ad5f9eea
PE
11552 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11553
aec1708a
PE
11554 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11555 to match comment at start of function. This also removes a
11556 GCC warning about overflow in a 32+64-bit port.
11557
47be4ab5
PE
11558 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11559
371cac43
PE
11560 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11561 Reported by Stefan Monnier in
11562 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11563 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11564 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11565
d01a7826
PE
11566 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11567 (EMACS_UINTPTR): Likewise, with uintptr_t.
11568
7fd47d5c
PE
11569 * lisp.h: Prefer 64-bit EMACS_INT if available.
11570 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11571 on 32-bit hosts that have 64-bit int, so that they can access
11572 large files.
122b0c86
PE
11573 However, temporarily disable this change unless the temporary
11574 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11575
8727937b
PE
11576 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11577
8ac068ac
PE
11578 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11579 This removes an assumption that EMACS_INT and long are the same
11580 width as pointers. The assumption is true for Emacs porting targets
11581 now, but we want to make other targets possible.
11582 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11583 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11584 In the rest of the code, change types of integers that hold casted
11585 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11586 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11587 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11588 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11589 No need to cast type when ORing.
11590 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11591 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11592 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11593 assume EMACS_INT is the same width as char *.
11594 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11595 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11596 Remove no-longer-needed casts.
11597 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11598 (xg_tool_bar_help_callback, xg_make_tool_item):
11599 Use EMACS_INTPTR to hold an integer
11600 that will be cast to void *; this can avoid a GCC warning
11601 if EMACS_INT is not the same width as void *.
11602 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11603 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11604 (current_message_1, set_message_1):
11605 Use a local to convert to proper width without a cast.
11606 * xmenu.c (dialog_selection_callback): Likewise.
11607
ede49d71
PE
11608 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11609 Also, don't assume VALBITS / RAND_BITS is less than 5,
11610 and don't rely on undefined behavior when shifting a 1 left into
11611 the sign bit.
11612 * lisp.h (get_random): Change signature to match.
11613
2f30ecd0
PE
11614 * lread.c (hash_string): Use size_t, not int, for hash computation.
11615 Normally we prefer signed values; but hashing is special, because
11616 it's better to use unsigned division on hash table sizes so that
11617 the remainder is nonnegative. Also, size_t is the natural width
11618 for hashing into memory. The previous code used 'int', which doesn't
11619 retain enough info to hash well into very large tables.
11620 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11621
2a866e7b
PE
11622 * dbusbind.c: Don't possibly lose pointer info when converting.
11623 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11624 Use XPNTR rather than XHASH, so that the high-order bits of
11625 the pointer aren't lost when converting through void *.
11626
51639eac
PE
11627 * eval.c (Fautoload): Don't double-shift a pointer.
11628
92394119
PE
11629 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11630
dbdb9a7c
JB
116312011-05-06 Juanma Barranquero <lekktu@gmail.com>
11632
11633 * gnutls.c (DEF_GNUTLS_FN):
11634 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11635
db7a0b4f
AS
116362011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11637
11638 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11639 marker. (Bug#8610)
11640
cd394be1 116412011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11642
11643 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11644 New version that can reserve upto 2GB of heap space.
11645
f7ff1b0f 116462011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11647
11648 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11649
639c109b
TZ
116502011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11651
11652 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11653 `gnutls_certificate_set_x509_key_file'.
11654
d2127135
JB
116552011-05-05 Juanma Barranquero <lekktu@gmail.com>
11656
11657 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11658 Update dependencies.
11659
e968f4f3
JB
116602011-05-04 Juanma Barranquero <lekktu@gmail.com>
11661
11662 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11663 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11664 Remove unused parameter `fildes'.
11665 * process.c (read_process_output, send_process): Don't pass it.
11666
84d358f0
JB
116672011-05-04 Juanma Barranquero <lekktu@gmail.com>
11668
11669 Fix previous change: the library cache is defined in w32.c.
11670 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11671 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11672
0898ca10
JB
116732011-05-04 Juanma Barranquero <lekktu@gmail.com>
11674
11675 Implement dynamic loading of GnuTLS on Windows.
11676
11677 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11678 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11679 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11680 Declare.
11681
11682 * gnutls.c (Qgnutls_dll): Define.
11683 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11684 (gnutls_*): Declare function pointers.
11685 (init_gnutls_functions): New function to initialize function pointers.
11686 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11687 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11688 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11689 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11690 (emacs_gnutls_write, emacs_gnutls_read)
11691 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11692 (Fgnutls_available_p): New function.
11693 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11694 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11695 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11696
11697 * image.c: Include w32.h.
11698 (Vimage_type_cache): Delete.
11699 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11700 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11701 (w32_delayed_load): Move to w32.c.
11702
11703 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11704
11705 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11706 (w32_delayed_load): Move from image.c. When loading a library, record
11707 its filename in the :loaded-from property of the library id.
11708 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11709 Initialize and staticpro them.
11710 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11711
11712 * process.c: Include lisp.h before w32.h, not after.
11713 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11714 instead of gnutls_record_check_pending.
11715
11716 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11717
ff4de4aa
TZ
117182011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11719
11720 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11721 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11722 as passed in.
11723
abe95abb
JD
117242011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11725
11726 * xterm.c (x_set_frame_alpha): Do not set property on anything
11727 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11728
e16e55d4
JB
117292011-05-02 Juanma Barranquero <lekktu@gmail.com>
11730
11731 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11732
bafcf6a5
JB
117332011-05-02 Juanma Barranquero <lekktu@gmail.com>
11734
11735 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11736 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11737 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11738 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11739 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11740 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11741 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11742 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11743 (Qgnutls_bootprop_callbacks_verify): Make static.
11744
e7a6747f
AS
117452011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11746
19ed11ba
AS
11747 * callproc.c: Indentation fixup.
11748
e7a6747f 11749 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11750 (wait_for_termination, interruptible_wait_for_termination):
11751 Move after wait_for_termination_1.
e7a6747f 11752
1ef14cb4
LMI
117532011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11754
11755 * sysdep.c (interruptible_wait_for_termination): New function
11756 which is like wait_for_termination, but allows keyboard
11757 interruptions.
11758
11759 * callproc.c (Fcall_process): Add (:file "file") as an option for
11760 the STDOUT buffer.
11761 (Fcall_process_region): Ditto.
11762
330d880c
EZ
117632011-04-30 Eli Zaretskii <eliz@gnu.org>
11764
8db90b73
EZ
11765 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11766 rather than `XVECTOR (FOO)->size'.
11767
330d880c
EZ
11768 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11769 inttypes.h, as a gnulib replacement is used if it not available in
11770 system headers.
11771
15cbd324
EZ
117722011-04-21 Eli Zaretskii <eliz@gnu.org>
11773
11774 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11775 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11776 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11777
11778 * coding.c (coding_alloc_by_realloc): Error out if destination
11779 will grow beyond MOST_POSITIVE_FIXNUM.
11780 (decode_coding_emacs_mule): Abort if there isn't enough place in
11781 charbuf for the composition carryover bytes. Reserve an extra
11782 space for up to 2 characters produced in a loop.
11783 (decode_coding_iso_2022): Abort if there isn't enough place in
11784 charbuf for the composition carryover bytes.
11785
117862011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11787
ae940cca
EZ
11788 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11789 aborting when %lld or %lll format is passed.
11790 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11791 %llo or %llx format is passed. (Bug#8545)
11792
03ab8921
EZ
11793 * window.c (window_scroll_line_based): Use a marker instead of
11794 simple variables to record original value of point. (Bug#7952)
11795
afda1437
EZ
11796 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11797 produced by %s or %c overflows available buffer space. (Bug#8545)
11798
f76dee0c
PE
117992011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11800
11801 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11802 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11803
fdc5744d
JB
118042011-04-28 Juanma Barranquero <lekktu@gmail.com>
11805
11806 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11807
638f053a
JB
118082011-04-28 Juanma Barranquero <lekktu@gmail.com>
11809
11810 * keyboard.c (Qdelayed_warnings_hook): Define.
11811 (command_loop_1): Run `delayed-warnings-hook'
11812 if Vdelayed_warnings_list is non-nil.
11813 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11814 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11815
d178f871
EZ
118162011-04-28 Eli Zaretskii <eliz@gnu.org>
11817
11818 * doprnt.c (doprnt): Don't return value smaller than the buffer
11819 size if the message was truncated. (Bug#8545).
11820
b124fd93
JB
118212011-04-28 Juanma Barranquero <lekktu@gmail.com>
11822
11823 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11824 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11825
e810457d
PE
118262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11827
11828 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11829
ea51cceb
JB
118302011-04-27 Juanma Barranquero <lekktu@gmail.com>
11831
11832 * makefile.w32-in: Update dependencies.
11833
94dcfacf
EZ
118342011-04-27 Eli Zaretskii <eliz@gnu.org>
11835
11836 Improve `doprnt' and its usage. (Bug#8545)
11837 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11838 `format_end'. Remove support for %l as a conversion specifier.
11839 Don't use xrealloc. Improve diagnostics when the %l size modifier
11840 is used. Update the commentary.
11841
11842 * eval.c (verror): Simplify calculation of size_t.
11843
11844 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11845 messages.
11846
f61f41d7
PE
118472011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11848
11849 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11850 change.
11851
96fb4434
PE
118522011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11853
11854 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11855 This makes this file independent of the recent pseudovector change.
11856
671875da 118572011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11858
69e9b5a3
PE
11859 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11860
b5f869a7 11861 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11862 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11863 Remove unused local.
c8926152 11864 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11865
841a1577 11866 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11867 GCC 4.6.0 optimizes based on type-based alias analysis.
11868 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11869 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11870 != &v->size, and therefore "v->size = 1; b->size = 2; return
11871 v->size;" must therefore return 1. This assumption is incorrect
11872 for Emacs, since it type-puns struct Lisp_Vector * with many other
11873 types. To fix this problem, this patch adds a new type struct
f904488f 11874 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11875 and pseudovectors, and helps optimizing compilers not get fooled
11876 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11877 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11878 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11879 the size member.
eab3844f
PE
11880 (XSETPVECTYPE): Rewrite in terms of new macro.
11881 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11882 This is a bit clearer, and further avoids the possibility of
11883 undesirable aliasing.
11884 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11885 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11886 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11887 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11888 (ASIZE): Now uses header.size rather than size.
11889 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11890 to avoid the hassle of writing XVECTOR (foo)->header.size.
11891 (struct vectorlike_header): New type.
eab3844f
PE
11892 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11893 object, to help avoid aliasing.
11894 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11895 (SUBRP): Likewise, since Lisp_Subr is a special case.
11896 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11897 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11898 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11899 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11900 changed to be "header.size" and "header.next".
11901 * buffer.h (struct buffer): Likewise.
11902 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11903 * frame.h (struct frame): Likewise.
11904 * process.h (struct Lisp_Process): Likewise.
11905 * termhooks.h (struct terminal): Likewise.
11906 * window.c (struct save_window_data, struct saved_window): Likewise.
11907 * window.h (struct window): Likewise.
11908 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11909 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11910 * buffer.c (init_buffer_once): Likewise.
11911 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11912 special case.
11913 * process.c (Fformat_network_address): Use local var for size,
11914 for brevity.
11915
0df1eac5
PE
11916 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11917
847ab9d1 11918 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11919 * data.c (atof): Remove decl; no longer used or needed.
11920 (digit_to_number): Move to lread.c.
11921 (Fstring_to_number): Use new string_to_number function, to be
11922 consistent with how the Lisp reader treats infinities and NaNs.
11923 Do not assume that floating-point numbers represent EMACS_INT
11924 without losing information; this is not true on most 64-bit hosts.
11925 Avoid double-rounding errors, by insisting on integers when
11926 parsing non-base-10 numbers, as the documentation specifies.
11927 * lisp.h (string_to_number): New decl, replacing ...
11928 (isfloat_string): Remove.
bc0a5c13 11929 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11930 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11931 appears to have been a coding error. Similarly, do not accept
11932 strings like +-1e0 as floating point numbers. Do not report
11933 overflow for integer overflows unless the base is not 10 which
11934 means we have no simple and reliable way to continue.
11935 Break out the floating-point parsing into a new
11936 function string_to_number, so that Fstring_to_number parses
11937 floating point numbers consistently with the Lisp reader.
04f2d78b 11938 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11939 (E_CHAR, EXP_INT): Remove, replacing with ...
11940 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11941 (string_to_number): New function, replacing isfloat_string.
11942 This function checks for valid syntax and produces the resulting
11943 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11944 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11945 so that overflow for non-base-10 numbers is reported only when
11946 there's no portable and simple way to convert to floating point.
452f4150 11947
67769ffc
PE
11948 * textprop.c (set_text_properties_1): Rewrite for clarity,
11949 and to avoid GCC warning about integer overflow.
11950
c20db43f
PE
11951 * intervals.h (struct interval): Use EMACS_INT for members
11952 where EMACS_UINT might cause problems. See
11953 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11954 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11955 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11956 All uses changed.
37aa2f85
PE
11957 (offset_intervals): Tell GCC not to worry about length overflow
11958 when negating a negative length.
c20db43f 11959
2538aa2f
PE
11960 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11961 (overrun_check_free): Likewise.
11962
f2d3008d
PE
11963 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11964 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11965 word size.
11966
ec8df744
PE
11967 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11968 (gnutls_make_error): Rename local to avoid shadowing.
11969 (gnutls_emacs_global_deinit): ifdef out; not used.
11970 (Fgnutls_boot): Use const for pointer to readonly storage.
11971 Comment out unused local. Fix pointer signedness problems.
11972
640ee02d
PE
11973 * lread.c (openp): Don't stuff size_t into an 'int'.
11974 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11975 about possible signed overflow.
11976
6048fb2a
PE
11977 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11978 (GDK_KEY_g): Don't define if already defined.
11979 (xg_prepare_tooltip): Avoid pointer signedness problem.
11980 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11981
fa3c87e1
PE
11982 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11983 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11984
2172544b
PE
11985 * xfns.c (Fx_window_property): Simplify a bit,
11986 to make a bit faster and to avoid GCC 4.6.0 warning.
11987 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11988
9b821a21
PE
11989 * fns.c (internal_equal): Don't assume size_t fits in int.
11990
3c616cfa
PE
11991 * alloc.c (compact_small_strings): Tighten assertion a little.
11992
c2982e87
PE
11993 Replace pEd with more-general pI, and fix some printf arg casts.
11994 * lisp.h (pI): New macro, generalizing old pEd macro to other
11995 conversion specifiers. For example, use "...%"pI"d..." rather
11996 than "...%"pEd"...".
11997 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11998 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11999 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12000 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12001 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12002 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12003 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12004 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12005 64-bit hosts.
12006 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12007 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12008 * print.c (safe_debug_print, print_object): Likewise.
12009 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12010 to int.
6f04d126
PE
12011 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12012 avoiding the 0 flag, which is not portable.
c2982e87
PE
12013 * process.c (Fmake_network_process): Use pI to avoid cast.
12014 * region-cache.c (pp_cache): Likewise.
12015 * xdisp.c (decode_mode_spec): Likewise.
12016 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12017 behavior on 64-bit hosts with printf arg.
6f04d126 12018 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12019 (x_stop_queuing_selection_requests): Likewise.
12020 (x_get_window_property): Don't truncate byte count to an 'int'
12021 when tracing.
0b432f21 12022
5e073ec7
PE
12023 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12024 here, since it parses constructs like leading '-' and spaces,
12025 which are not wanted; and it overflows with large numbers.
12026 Instead, simply match F[0-9]+, which is what is wanted anyway.
12027
36372bf9
PE
12028 * alloc.c: Remove unportable assumptions about struct layout.
12029 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12030 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12031 (allocate_vectorlike, make_pure_vector): Use the new macros,
12032 plus offsetof, to remove unportable assumptions about struct layout.
12033 These assumptions hold on all porting targets that I know of, but
12034 they are not guaranteed, they're easy to remove, and removing them
12035 makes further changes easier.
12036
0b432f21
PE
12037 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12038 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12039 (string_overrun_cookie): Now const. Use initializers that
12040 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12041 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12042 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12043 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12044 multiple of sizeof (EMACS_INT); it need not be, if
12045 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12046 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12047
895009e1
JB
120482011-04-26 Juanma Barranquero <lekktu@gmail.com>
12049
12050 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12051
6a7a1b0b
TZ
120522011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12053
12054 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12055 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12056 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12057
841a1577 120582011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12059
12060 * lisp.h (Qdebug): List symbol.
895009e1 12061 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12062 * keyboard.c (debug-on-event): New variable.
12063 (handle_user_signal): Break into debugger when debug-on-event
12064 matches the current signal symbol.
12065
f2d3ba6f
DN
120662011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12067
12068 * alloc.c (check_sblock, check_string_bytes)
12069 (check_string_free_list): Convert to standard C.
12070
42ce4c63
TZ
120712011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12072
12073 * w32.c (emacs_gnutls_push): Fix typo.
12074
825cd63c
EZ
120752011-04-25 Eli Zaretskii <eliz@gnu.org>
12076
fb11d64d
EZ
12077 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12078 "cast to pointer from integer of different size".
12079
825cd63c
EZ
12080 Improve doprnt and its use in verror. (Bug#8545)
12081 * doprnt.c (doprnt): Document the set of format control sequences
12082 supported by the function. Use SAFE_ALLOCA instead of always
12083 using `alloca'.
12084
12085 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12086 is one byte too soon. Don't use xrealloc; instead xfree and
12087 xmalloc anew.
12088
e061a11b
TZ
120892011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12090
12091 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12092 callbacks stage.
12093
12094 * gnutls.c: Renamed global_initialized to
12095 gnutls_global_initialized. Added internals for the
12096 :verify-hostname-error, :verify-error, and :verify-flags
12097 parameters of `gnutls-boot' and documented those parameters in the
12098 docstring. Start callback support.
9173deec
JB
12099 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12100 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12101 on error. Return error code.
e061a11b
TZ
12102 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12103 (emacs_gnutls_read): Likewise.
12104 (Fgnutls_boot): Return handshake error code.
12105 (emacs_gnutls_handle_error): New function.
12106 (wsaerror_to_errno): Likewise.
12107
12108 * w32.h (emacs_gnutls_pull): Add prototype.
12109 (emacs_gnutls_push): Likewise.
12110
12111 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12112 (emacs_gnutls_push): Likewise.
12113
121142011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12115
12116 * process.c (wait_reading_process_output): Check if GnuTLS
12117 buffered some data internally if no FDs are set for TLS
12118 connections.
12119
12120 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12121 (LIBS): Link to USER_LIBS.
12122 ($(BLD)/gnutls.$(0)): New target.
12123
fa6996bc
EZ
121242011-04-24 Eli Zaretskii <eliz@gnu.org>
12125
eb35682e
EZ
12126 * xdisp.c (handle_single_display_spec): Rename the
12127 display_replaced_before_p argument into display_replaced_p, to
12128 make it consistent with the commentary. Fix typos in the
12129 commentary.
12130
e2ad650c
EZ
12131 * textprop.c (syms_of_textprop): Remove dead code.
12132 (copy_text_properties): Delete obsolete commentary about an
12133 interface that was deleted long ago. Fix typos in the description
12134 of arguments.
12135
1b2de274
EZ
12136 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12137 to changes in oldXMenu/XMenu.h from 2011-04-16.
12138 <menu_help_message, prev_menu_help_message>: Constify.
12139 (IT_menu_make_room): menu->help_text is now `const char **';
12140 adjust.
12141
12142 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12143 to changes in oldXMenu/XMenu.h from 2011-04-16.
12144 (struct XMenu): Declare `help_text' `const char **'.
12145
12146 * xfaces.c <Qunspecified>: Make extern again.
12147
12148 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12149 required by POSIX.
1b2de274 12150
762b15be
EZ
12151 * doc.c (get_doc_string): Improve the format passed to `error'.
12152
12153 * doprnt.c (doprnt): Improve commentary.
12154
12155 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12156
12157 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12158 them with etags.
12159
f1052e5d
EZ
12160 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12161 changes in globals.h immediately force recompilation.
762b15be
EZ
12162 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12163 $(CURDIR)/s/ms-w32.h.
12164 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12165
fa6996bc
EZ
12166 * character.c (Fchar_direction): Function deleted.
12167 (syms_of_character): Don't defsubr it.
12168 <char-direction-table>: Deleted.
12169
e6c3da20
EZ
121702011-04-23 Eli Zaretskii <eliz@gnu.org>
12171
12172 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12173 * doprnt.c: Include limits.h.
12174 (SIZE_MAX): New macro.
04f2d78b
CB
12175 (doprnt): Return a size_t value. 2nd arg is now size_t.
12176 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12177 Improve overflow protection. Support `l' modifier for integer
12178 conversions. Support %l conversion. Don't assume an EMACS_INT
12179 argument for integer conversions and for %c.
12180
12181 * lisp.h (doprnt): Restore prototype.
12182
12183 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12184 $(SRC)/character.h.
12185
12186 * Makefile.in (base_obj): Add back doprnt.o.
12187
12188 * deps.mk (doprnt.o): Add back prerequisites.
12189 (callint.o): Depend on character.h.
12190
12191 * eval.c (internal_lisp_condition_case): Include the handler
12192 representation in the error message.
12193 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12194 when breaking from the loop.
12195
12196 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12197
12198 * callint.c (Fcall_interactively): When displaying error message
12199 about invalid control letter, pass the character's codepoint, not
12200 a pointer to its multibyte form. Improve display of the character
12201 in octal and display also its hex code.
12202
12203 * character.c (char_string): Use %x to display the (unsigned)
12204 codepoint of an invalid character, to avoid displaying a bogus
12205 negative value.
12206
12207 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12208 `error', not SYMBOL_NAME itself.
12209
12210 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12211 character arguments to `error'.
12212
12213 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12214 to `error' in error message about FINAL_CHAR argument. Make sure
12215 FINAL_CHAR is a character, and use %c when it is passed as
12216 argument to `error'.
12217
4ffd0d6b 122182011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12219
12220 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12221
12222 * w32.c: Include <time.h>.
12223 (sys_localtime): New function.
12224
4ffd0d6b 122252011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12226
12227 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12228
4ffd0d6b 12229 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12230
4ffd0d6b 122312011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12232
4ffd0d6b
GM
12233 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12234 zombies (Bug#8467).
aac0c6e3 12235
04c56954
EZ
122362011-04-19 Eli Zaretskii <eliz@gnu.org>
12237
12238 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12239 gl_state.e_property when gl_state.object is Qt.
12240
12241 * insdel.c (make_gap_larger): Remove limitation of buffer size
12242 to <= INT_MAX.
12243
16a43933
CY
122442011-04-18 Chong Yidong <cyd@stupidchicken.com>
12245
12246 * xdisp.c (lookup_glyphless_char_display)
12247 (produce_glyphless_glyph): Handle cons cell entry in
12248 glyphless-char-display.
12249 (Vglyphless_char_display): Document it.
12250
12251 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12252 glyphless-char-display.
12253
4581706e
CY
122542011-04-17 Chong Yidong <cyd@stupidchicken.com>
12255
12256 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12257
12258 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12259
12260 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12261 definition for no-X builds.
12262
4887c6e2 122632011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12264
fd35b6f9
PE
12265 Static checks with GCC 4.6.0 and non-default toolkits.
12266
5c1ccb01
PE
12267 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12268
006c5daa
PE
12269 * process.c (keyboard_bit_set): Define only if SIGIO.
12270 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12271 (send_process): Repair possible setjmp clobbering.
12272
efc736d3
PE
12273 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12274
4e2fe2e6
PE
12275 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12276
f97334a2
PE
12277 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12278
4e75f29d
PE
12279 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12280 Define only if needed.
12281
90efadd1
PE
12282 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12283 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12284 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12285
3c647824
PE
12286 * dispextern.h (struct redisplay_interface): Rename param
12287 to avoid shadowing.
e264f262 12288 * termhooks.h (struct terminal): Likewise.
761383f4 12289 * xterm.c (xembed_send_message): Likewise.
3c647824 12290
b58c5c4a
PE
12291 * insdel.c (make_gap_smaller): Define only if
12292 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12293
cad59032
PE
12294 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12295 it.
12296
c339dc2e
PE
12297 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12298 so that we aren't warned about unused symbols.
12299
91a3e27b
PE
12300 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12301
399c71d3 12302 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12303
8ffc96f5
PE
12304 * xfns.c (x_real_positions): Mark locals as initialized.
12305
eef9bc79
PE
12306 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12307
098db9dd
PE
12308 * xterm.c: Fix problems found by static analysis with other toolkits.
12309 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12310 (x_dispatch_event): Declare static if USE_GTK, and
12311 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12312 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12313 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12314 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12315 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12316
eb18f6cc
PE
12317 * xmenu.c (menu_help_callback): Pointer type fixes.
12318 Use const pointers when pointing at readonly data. Avoid pointer
12319 signedness clashes.
12320 (FALSE): Remove unused macro.
12321 (update_frame_menubar): Remove unused decl.
12322
1fe72bf8
PE
12323 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12324
60d9e1db
PE
12325 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12326 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12327 (single_menu_item): Rename local to avoid shadowing.
12328
39261c26
PE
12329 * keyboard.c (make_lispy_event): Remove unused local var.
12330
018c5e19
PE
12331 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12332 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12333
63d2b86e
PE
12334 * bitmaps: Change bitmaps from unsigned char back to the X11
12335 compatible char. Avoid the old compiler warnings about
12336 out-of-range initializers by using, for example, '\xab' rather
12337 than 0xab.
12338
aefd87e1
PE
12339 * xgselect.c (xgselect_initialize): Check vs interface
12340 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12341
bf501fb9
PE
12342 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12343
e9829fdf
PE
12344 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12345 to read-only memory.
12346
1086c095
PE
12347 * fns.c (vector): Remove; this old hack is no longer needed.
12348
2baccd04 12349 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12350 Remove unused var.
dde42981 12351 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12352
72391843 12353 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12354
436c16df 12355 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12356 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12357 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12358
92bb796d 12359 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12360 (x_term_init): Remove local to avoid shadowing.
92bb796d 12361
764430a3 12362 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12363
12364 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12365 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12366
d1dfb56c
EZ
123672011-04-16 Eli Zaretskii <eliz@gnu.org>
12368
c4354cb4
EZ
12369 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12370
d1dfb56c
EZ
12371 Fix regex.c, syntax.c and friends for buffers > 2GB.
12372 * syntax.h (struct gl_state_s): Declare character position members
12373 EMACS_INT.
12374
12375 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12376
04f2d78b
CB
12377 * textprop.c (verify_interval_modification, interval_of):
12378 Declare arguments EMACS_INT.
d1dfb56c
EZ
12379
12380 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12381 EMACS_INT.
12382
12383 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12384
12385 * indent.c (Fvertical_motion): Local variable it_start is now
12386 EMACS_INT.
12387
12388 * regex.c (re_match, re_match_2, re_match_2_internal)
12389 (bcmp_translate, regcomp, regexec, print_double_string)
12390 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12391 (re_compile_pattern, re_exec): Declare arguments and local
12392 variables `size_t' and `ssize_t' and return values `regoff_t', as
12393 appropriate.
12394 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12395 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12396 <compile_stack_type>: `size' and `avail' are now `size_t'.
12397
12398 * regex.h <regoff_t>: Use ssize_t, not int.
12399 (re_search, re_search_2, re_match, re_match_2): Arguments that
12400 specify buffer/string position and length are now ssize_t and
12401 size_t. Return type is regoff_t.
12402
613052cd
BK
124032011-04-16 Ben Key <bkey76@gmail.com>
12404
12405 * nsfont.m: Fixed bugs in ns_get_family and
12406 ns_descriptor_to_entity that were caused by using free to
12407 deallocate memory blocks that were allocated by xmalloc (via
12408 xstrdup). This caused Emacs to crash when compiled with
12409 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12410 --enable-checking=xmallocoverrun). xfree is now used to
12411 deallocate these memory blocks.
12412
4170f62f 124132011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12414
71b41406
PE
12415 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12416
9587a89d
PE
12417 emacs_write: Accept and return EMACS_INT for sizes.
12418 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12419 et seq.
12420 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12421 Accept and return EMACS_INT.
12422 (emacs_gnutls_write): Return the number of bytes written on
12423 partial writes.
12424 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12425 (emacs_read, emacs_write): Remove check for negative size, as the
12426 Emacs source code has been audited now.
9587a89d
PE
12427 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12428 (emacs_read, emacs_write): Use it.
273a5f82
PE
12429 * process.c (send_process): Adjust to the new signatures of
12430 emacs_write and emacs_gnutls_write. Do not attempt to store
12431 a byte offset into an 'int'; it might overflow.
9587a89d 12432 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12433
3e047f51
PE
12434 * sound.c: Don't assume sizes fit in 'int'.
12435 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12436 Return EMACS_INT, not int.
3e047f51 12437 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12438 Accept EMACS_INT, not int.
12439 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12440 record read return values.
12441
cc39a9db
BK
124422011-04-15 Ben Key <bkey76@gmail.com>
12443
c9d0ec6d
JB
12444 * keyboard.c (Qundefined): Don't declare static since it is used
12445 in nsfns.m.
12446 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12447 static since they are used in nsfont.m.
cc39a9db 12448
6c60eb9f
SM
124492011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12450
12451 * process.c (Qprocessp): Don't declare static.
12452 * lisp.h (Qprocessp): Declare again.
12453
7990b61a
JB
124542011-04-15 Juanma Barranquero <lekktu@gmail.com>
12455
12456 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12457
5d4cb038
PE
124582011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12459
8bd7b830 12460 Improve C-level modularity by making more things 'static'.
cd64ea1d 12461
e3b27b31
PE
12462 Don't publish debugger-only interfaces to other modules.
12463 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12464 (verify_bytepos, count_markers): Move decls to the only modules
12465 that need them.
12466 * region-cache.h (pp_cache): Likewise.
12467 * window.h (check_all_windows): Likewise.
12468 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12469
5d4cb038
PE
12470 * sysdep.c (croak): Now static, if
12471 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12472 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12473
12474 * alloc.c (refill_memory_reserve): Now static if
12475 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12476 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12477
e87b6180
PE
12478 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12479 Define only if USE_LUCID.
12480
ac64929e
PE
12481 * xrdb.c (x_customization_string, x_rm_string): Now static.
12482
6f37259d
PE
12483 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12484 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12485
1683e3ab
PE
12486 * xdisp.c (draw_row_with_mouse_face): Now static.
12487 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12488
de9c2632
PE
12489 * window.h (check_all_windows): Mark externally visible.
12490
2b96acb7
PE
12491 * window.c (window_deletion_count): Now static.
12492
12493 * undo.c: Make symbols static if they're not exported.
12494 (last_undo_buffer, last_boundary_position, pending_boundary):
12495 Now static.
12496
50436f33
PE
12497 * textprop.c (interval_insert_behind_hooks): Now static.
12498 (interval_insert_in_front_hooks): Likewise.
12499
64520e5c
PE
12500 * term.c: Make symbols static if they're not exported.
12501 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12502 (max_frame_lines, tty_set_terminal_modes):
12503 (tty_reset_terminal_modes, tty_turn_off_highlight):
12504 (get_tty_terminal): Now static.
12505 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12506 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12507 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12508 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12509 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12510
1fa53021
PE
12511 * sysdep.c: Make symbols static if they're not exported.
12512 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12513 Now static.
12514 (sigprocmask_set, full_mask): Remove; unused.
12515 (wait_debugging): Mark as visible.
12516 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12517 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12518
d4b43b22
PE
12519 * syntax.c (syntax_temp): Define only if !__GNUC__.
12520
b7c513d0
PE
12521 * sound.c (current_sound_device, current_sound): Now static.
12522
989b29ad
PE
12523 * search.c (searchbufs, searchbuf_head): Now static.
12524
13a55a78
PE
12525 * scroll.c (scroll_cost): Remove; unused.
12526 * dispextern.h (scroll_cost): Remove decl.
12527
de68a1fc
PE
12528 * region-cache.h (pp_cache): Mark as externally visible.
12529
40ccffa6
PE
12530 * process.c: Make symbols static if they're not exported.
12531 (process_tick, update_tick, create_process, chan_process):
12532 (Vprocess_alist, proc_buffered_char, datagram_access):
12533 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12534 (deactivate_process): Mark defn as static, as well as decl.
12535 * lisp.h (create_process): Remove decl.
12536 * process.h (chan_process, Vprocess_alist): Remove decls.
12537
ad64fc97
PE
12538 * print.c: Make symbols static if they're not exported.
12539 (print_depth, new_backquote_output, being_printed, print_buffer):
12540 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12541 (print_interval, print_number_index, initial_stderr_stream):
12542 Now static.
12543 * lisp.h (Fprinc): Remove decl.
12544 (debug_output_compilation_hack): Mark as externally visible.
12545
adddb265
PE
12546 * sysdep.c (croak): Move decl from here to syssignal.h.
12547 * syssignal.h (croak): Put it here, so the API can be checked when
12548 'croak' is called from dissociate_if_controlling_tty.
12549
1717ede2
PE
12550 * minibuf.c: Make symbols static if they're not exported.
12551 (minibuf_save_list, choose_minibuf_frame): Now static.
12552 * lisp.h (choose_minibuf_frame): Remove decl.
12553
fa5fb2bc
PE
12554 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12555
1e3890d1
PE
12556 * lread.c: Make symbols static if they're not exported.
12557 (read_objects, initial_obarray, oblookup_last_bucket_number):
12558 Now static.
12559 (make_symbol): Remove; unused.
12560 * lisp.h (initial_obarray, make_symbol): Remove decls.
12561
8a1414fa
PE
12562 * keyboard.c: Make symbols static if they're not exported.
12563 (single_kboard, recent_keys_index, total_keys, recent_keys):
12564 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12565 (this_single_command_key_start, echoing, last_auto_save):
12566 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12567 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12568 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12569 (Vlispy_mouse_stem, double_click_count):
12570 Now static.
12571 (force_auto_save_soon): Define only if SIGDANGER.
12572 (ignore_mouse_drag_p): Now static if
12573 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12574 (print_help): Remove; unused.
12575 (stop_character, last_timer_event): Mark as externally visible.
12576 * keyboard.h (ignore_mouse_drag_p): Declare only if
12577 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12578 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12579 * lisp.h (echoing): Remove decl.
12580 (force_auto_save_soon): Declare only if SIGDANGER.
12581 * xdisp.c (redisplay_window): Simplify code, to make it more
12582 obvious that ignore_mouse_drag_p is not accessed if !defined
12583 USE_GTK && !defined HAVE_NS.
12584
93ea6e8f
PE
12585 * intervals.c: Make symbols static if they're not exported.
12586 (merge_properties_sticky, merge_interval_right, delete_interval):
12587 Now static.
12588 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12589
77382fcc
PE
12590 * insdel.c: Make symbols static if they're not exported.
12591 However, leave prepare_to_modify_buffer alone. It's never
12592 called from outside this function, but that appears to be a bug.
12593 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12594 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12595 (adjust_after_replace_noundo): Remove; unused.
12596 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12597 (signal_before_change): Remove decls.
77382fcc 12598
9306c32e
PE
12599 * indent.c (val_compute_motion, val_vmotion): Now static.
12600
cd44d2eb
PE
12601 * image.c: Make symbols static if they're not exported.
12602 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12603 if USE_GTK.
12604 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12605 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12606
ad9a7a06
PE
12607 * fringe.c (standard_bitmaps): Now static.
12608 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12609
81626931
PE
12610 * frame.c: Make symbols static if they're not exported.
12611 (x_report_frame_params, make_terminal_frame): Now static.
12612 (get_frame_param): Now static, unless HAVE_NS.
12613 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12614 (x_get_resource_string): Remove; not used.
12615 * frame.h (make_terminal_frame, x_report_frame_params):
12616 (x_get_resource_string); Remove decls.
12617 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12618 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12619
239f9db9
PE
12620 * font.c, fontset.c: Make symbols static if they're not exported.
12621 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12622 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12623 * font.c (font_close_object): Now static.
12624 * font.h (font_close_object): Remove.
12625 * fontset.c (FONTSET_OBJLIST): Remove.
12626 (free_realized_fontset) #if-0 the body, which does nothing.
12627 (face_suitable_for_char_p): #if-0, as it's never called.
12628 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12629 * xfaces.c (face_at_string_position):
12630 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12631 since 0 is always ASCII.
12632
dfcf3579
PE
12633 * fns.c (weak_hash_tables): Now static.
12634
5045092b
PE
12635 * fileio.c: Make symbols static if they're not exported.
12636 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12637 (Vwrite_region_annotation_buffers): Now static.
12638
57a96f5c
PE
12639 * eval.c: Make symbols static if they're not exported.
12640 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12641 * lisp.h (backtrace_list): Remove decl.
12642
35f08c38
PE
12643 * emacs.c: Make symbols static if they're not exported.
12644 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12645 (fatal_error_code, fatal_error_signal_hook, standard_args):
12646 Now static.
12647 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12648 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12649 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12650 * lisp.h (fatal_error_signal_hook): Remove decl.
12651 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12652
f44bd759
PE
12653 * editfns.c: Move a (normally-unused) function to its only use.
12654 * editfns.c, lisp.h (get_operating_system_release): Remove.
12655 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12656 worth the hassle of breaking this out.
12657
b532497d
PE
12658 * xterm.c: Make symbols static if they're not exported.
12659 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12660 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12661 (x_destroy_window, x_delete_display):
12662 Now static.
12663 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12664 (x_mouse_leave): Remove; unused.
12665 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12666 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12667 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12668 Remove decls.
12669 (x_mouse_leave): Declare only if WINDOWSNT.
12670 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12671 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12672 USE_X_TOOLKIT.
12673
1675728f
PE
12674 * ftxfont.c: Make symbols static if they're not exported.
12675 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12676 HAVE_FREETYPE.
12677 * font.h (ftxfont_driver): Likewise.
12678
e4cebfca
PE
12679 * xfns.c: Make symbols static if they're not exported.
12680 (x_last_font_name, x_display_info_for_name):
12681 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12682 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12683 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12684 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12685 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12686 (last_show_tip_args): Now static.
12687 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12688 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12689 (x_screen_planes): Remove; unused.
12690 * dispextern.h (x_screen_planes): Remove decl.
12691
5bf46f05
PE
12692 * dispnew.c: Make symbols static if they're not exported.
12693 * dispextern.h (redraw_garbaged_frames, scrolling):
12694 (increment_row_positions): Remove.
12695 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12696 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12697 Now static.
12698 (redraw_garbaged_frames): Remove; unused.
12699
435f4c28
PE
12700 * xfaces.c: Make symbols static if they're not exported.
12701 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12702 Remove decls.
12703 * xterm.h (defined_color): Remove decls.
12704 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12705 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12706 (menu_face_changed_default, defined_color, free_realized_face):
12707 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12708 (ascii_face_of_lisp_face): Remove; unused.
12709
8524aef3
PE
12710 * xdisp.c: Make symbols static if they're not exported.
12711 * dispextern.h (scratch_glyph_row, window_box_edges):
12712 (glyph_to_pixel_coords, set_cursor_from_row):
12713 (get_next_display_element, set_iterator_to_next):
12714 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12715 (show_mouse_face): Remove decls
12716 * frame.h (message_buf_print): Likewise.
12717 * lisp.h (pop_message, set_message, check_point_in_composition):
12718 Likewise.
12719 * xterm.h (set_vertical_scroll_bar): Likewise.
12720 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12721 (message_buf_print, scratch_glyph_row, displayed_buffer):
12722 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12723 (get_next_display_element, show_mouse_face, window_box_edges):
12724 (frame_to_window_pixel_xy, check_point_in_composition):
12725 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12726 (glyph_to_pixel_coords): Remove; unused.
12727
16390cd2
PE
12728 * dired.c (file_name_completion): Now static.
12729
12730 * dbusbind.c (xd_in_read_queued_messages): Now static.
12731
a25f4dfa
PE
12732 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12733 * data.c (circular_list_error): Remove.
12734
14a9c8df
PE
12735 * commands.h (last_point_position, last_point_position_buffer):
12736 (last_point_position_window): Remove decls.
12737 * keyboard.c: Make these variables static.
12738
04f2d78b
CB
12739 * coding.h (coding, code_convert_region, encode_coding_gap):
12740 Remove decls.
74ab6df5
PE
12741 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12742 (iso_code_class, detect_coding, code_convert_region): Now static.
12743 (encode_coding_gap): Remove; unused.
12744
38dfbee1
PE
12745 * chartab.c (chartab_chars, chartab_bits): Now static.
12746
a2cb4e63
PE
12747 * charset.h (charset_iso_8859_1): Remove decl.
12748 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12749 Now static.
12750
127198fd
PE
12751 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12752 * ccl.c (Vccl_program_table): Now static.
12753 (check_ccl_update): Remove; unused.
12754
d85b608f
PE
12755 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12756 * category.h: ... from here.
12757 * category.c (check_category_table, set_category_set): Now static.
12758
31cd66f3
PE
12759 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12760 * lisp.h: Remove these decls.
12761
c358e587
PE
12762 * buffer.c (buffer_count): Remove unused var.
12763
e78aecca
PE
12764 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12765 so that it's not optimized away.
12766 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12767 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12768 exported only to the debugger.
12769
e192d7d3 12770 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12771 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12772
92470028
PE
12773 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12774 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12775 was inaccessible from Lisp.
12776 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12777 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12778
244ed907
PE
12779 alloc.c: Import and export fewer symbols, and remove unused items.
12780 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12781 is defined.
12782 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12783 it's not optimized away by whole-program optimization.
12784 (message_enable_multibyte, free_misc): Remove.
12785 (catchlist, handlerlist, mark_backtrace):
12786 Declare only if BYTE_MARK_STACK.
12787 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12788 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12789 (message_enable_multibyte): Remove decl.
12790 (free_misc, interval_free_list, float_block, float_block_index):
12791 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12792 (cons_free_list, last_marked_index):
12793 Now static.
12794 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12795 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12796 (mark_backtrace): Define only if BYTE_MARK_STACK.
12797 * xdisp.c (message_enable_multibyte): Now static.
12798
61c2b50e 12799 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12800 This makes it easier for human readers (and static analyzers)
12801 to see whether these variables are used from other modules.
12802 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12803 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12804 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12805 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12806 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12807 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12808 * xmenu.c, xselect.c:
12809 Declare Q* vars static if they are not used in other modules.
12810 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12811 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12812 Remove decls of unexported vars.
12813 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12814
95c82688
PE
12815 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12816
16a97296
PE
12817 Make Emacs functions such as Fatom 'static' by default.
12818 This makes it easier for human readers (and static analyzers)
12819 to see whether these functions can be called from other modules.
12820 DEFUN now defines a static function. To make the function external
12821 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12822 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12823 (Finit_image_library):
16a97296
PE
12824 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12825 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12826 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12827 Remove decls, since these functions are now static.
12828 (Funintern, Fget_internal_run_time): New decls, since these functions
12829 were already external.
95c82688 12830
16a97296
PE
12831 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12832 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12833 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12834 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12835 * keyboard.c, keymap.c, lread.c:
12836 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12837 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12838 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12839 Mark functions with DEFUE instead of DEFUN,
12840 if they are used in other modules.
12841 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12842 decls for now-static functions.
12843 * buffer.h (Fdelete_overlay): Remove decl.
12844 * callproc.c (Fgetenv_internal): Mark as internal.
12845 * composite.c (Fremove_list_of_text_properties): Remove decl.
12846 (Fcomposition_get_gstring): New forward static decl.
12847 * composite.h (Fcomposite_get_gstring): Remove decl.
12848 * dired.c (Ffile_attributes): New forward static decl.
12849 * doc.c (Fdocumntation_property): New forward static decl.
12850 * eval.c (Ffetch_bytecode): New forward static decl.
12851 (Funintern): Remove extern decl; now in .h file where it belongs.
12852 * fileio.c (Fmake_symbolic_link): New forward static decl.
12853 * image.c (Finit_image_library): New forward static decl.
12854 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12855 * intervals.h (Fprevious_property_change):
12856 (Fremove_list_of_text_properties): Remove decls.
12857 * keyboard.c (Fthis_command_keys): Remove decl.
12858 (Fcommand_execute): New forward static decl.
12859 * keymap.c (Flookup_key): New forward static decl.
12860 (Fcopy_keymap): Now static.
12861 * keymap.h (Flookup_key): Remove decl.
12862 * process.c (Fget_process): New forward static decl.
12863 (Fprocess_datagram_address): Mark as internal.
12864 * syntax.c (Fsyntax_table_p): New forward static decl.
12865 (skip_chars): Remove duplicate decl.
12866 * textprop.c (Fprevious_property_change): New forward static decl.
12867 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12868 Now internal.
12869 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12870 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12871
785bbd42
PE
12872 * editfns.c (Fformat): Remove unreachable code.
12873
8b913b57
AS
128742011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12875
12876 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12877 change. (Bug#8496)
12878
a6744a35
EZ
128792011-04-13 Eli Zaretskii <eliz@gnu.org>
12880
12881 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12882 when at ZV. (Bug#8487)
12883
e7974947
AS
128842011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12885
baad03f0
AS
12886 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12887 (Bug#8437)
12888 * keyboard.c (parse_tool_bar_item): Likewise.
12889 * sound.c (sound_cleanup, alsa_close): Likewise.
12890 * termcap.c (tgetent): Likewise.
12891 * xfns.c (x_default_font_parameter): Likewise.
12892 * xsettings.c (read_and_apply_settings): Likewise.
12893
e7974947
AS
12894 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12895 (overrun_check_free): Protoize.
12896
28272684
PE
128972011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12898
12899 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12900 since callers should never pass a negative size.
12901 Change the signature to match that of plain 'read' and 'write'; see
12902 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12903 * lisp.h: Update prototypes of emacs_write and emacs_read.
12904
11997c76
EZ
129052011-04-11 Eli Zaretskii <eliz@gnu.org>
12906
12907 * xdisp.c (redisplay_window): Don't try to determine the character
12908 position of the scroll margin if the window start point w->startp
e896f03c 12909 is outside the buffer's accessible region. (Bug#8468)
11997c76 12910
8a2cbd72
EZ
129112011-04-10 Eli Zaretskii <eliz@gnu.org>
12912
12913 Fix write-region and its subroutines for buffers > 2GB.
12914 * fileio.c (a_write, e_write): Modify declaration of arguments and
12915 local variables to support buffers larger than 2GB.
12916 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12917
12918 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12919 argument, local variables, and return value.
12920
12921 * lisp.h: Update prototypes of emacs_write and emacs_read.
12922
12923 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12924
4073e537 129252011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12926
1ebfdcb6
PE
12927 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12928
b2ded58d
PE
12929 Fix more problems found by GCC 4.6.0's static checks.
12930
7d66342c
PE
12931 * xdisp.c (vmessage): Use a better test for character truncation.
12932
bbf47d44
PE
12933 * charset.c (load_charset_map): <, not <=, for optimization,
12934 and to avoid potential problems with integer overflow.
9248994d 12935 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12936 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12937 * editfns.c (Fformat): Likewise.
1e69125e 12938 * syntax.c (skip_chars): Likewise.
3befa583 12939
e3019616
PE
12940 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12941 This also lets GCC 4.6.0 generate slightly better loop code.
12942
becfa255
PE
12943 * callint.c (Fcall_interactively): <, not <=, for optimization.
12944 (Fcall_interactively): Count the number of arguments produced,
12945 not the number of arguments given. This is simpler and lets GCC
12946 4.6.0 generate slightly better code.
12947
dae0cd48
PE
12948 * ftfont.c: Distingish more carefully between FcChar8 and char.
12949 The previous code passed unsigned char * to a functions like
12950 strlen and xstrcasecmp that expect char *, which does not
12951 conform to the C standard.
12952 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12953 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12954 char * when the C standard requires it.
12955
76032d70
PE
12956 * keyboard.c (read_char): Remove unused var.
12957
eb3f1cc8
PE
12958 * eval.c: Port to Windows vsnprintf (Bug#8435).
12959 Include <limits.h>.
12960 (SIZE_MAX): Define if the headers do not.
12961 (verror): Do not give up if vsnprintf returns a negative count.
12962 Instead, grow the buffer. This ports to Windows vsnprintf, which
12963 does not conform to C99. Problem reported by Eli Zaretskii.
12964 Also, simplify the allocation scheme, by avoiding the need for
12965 calling realloc, and removing the ALLOCATED variable.
12966
70476b54
PE
12967 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12968
12020a9e
PE
12969 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12970 But keep the doprint source code for now, as we might revamp it
12971 and use it again (Bug#8435).
ea6c7ae6
PE
12972 * lisp.h (doprnt): Remove.
12973 * Makefile.in (base_obj): Remove doprnt.o.
12974 * deps.mk (doprnt.o): Remove.
12975
5fdb398c
PE
12976 error: Print 32- and 64-bit integers portably (Bug#8435).
12977 Without this change, on typical 64-bit hosts error ("...%d...", N)
12978 was used to print both 32- and 64-bit integers N, which relied on
12979 undefined behavior.
61bdb816 12980 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12981 * lisp.h (error, verror): Mark as printf-like functions.
12982 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12983 Report overflow in size calculations when allocating printf buffer.
12984 Do not truncate output string at its first null byte.
12985 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12986 Truncate the output at a character boundary, since vsnprintf does not
12987 do that.
12988 * charset.c (check_iso_charset_parameter): Convert internal
12989 character to string before calling 'error', since %c now has the
12990 printf meaning.
12991 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12992 overflow when computing char to be passed to 'error'. Do not
12993 pass Lisp_Object to 'error'; pass the integer instead.
12994 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12995 formatted with plain %d.
12996
b189fa66
PE
12997 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12998
bff87ef0
PE
12999 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13000
7e2cac20
PE
13001 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13002
ce4d90b5
PE
13003 * xterm.c (x_catch_errors): Remove duplicate declaration.
13004
266c9547
PE
13005 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13006
79c49ad2
PE
13007 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13008
368f4090
JM
130092011-04-10 Jim Meyering <meyering@redhat.com>
13010
13011 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13012 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13013 return ssize_t not "int", and use size_t as the buffer length.
13014 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13015 * gnutls.h: Update declarations.
13016 * process.c (read_process_output): Use ssize_t, to match.
13017 (send_process): Likewise.
13018
a32d4040
CY
130192011-04-09 Chong Yidong <cyd@stupidchicken.com>
13020
13021 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13022
8546720e 130232011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13024
04f2d78b
CB
13025 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13026 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13027
8546720e
GM
13028 * xterm.c (handle_one_xevent):
13029 * xmenu.c (create_and_show_popup_menu):
13030 * xselect.c (x_decline_selection_request)
13031 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13032
0a2f5c1a 130332011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13034
13035 Fix some uses of `int' instead of EMACS_INT.
13036 * search.c (string_match_1, fast_string_match)
13037 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13038 (scan_buffer, find_next_newline_no_quit)
13039 (find_before_next_newline, search_command, Freplace_match)
13040 (Fmatch_data): Make some `int' variables be EMACS_INT.
13041
13042 * xdisp.c (display_count_lines): 3rd argument and return value now
13043 EMACS_INT. All callers changed.
13044 (pint2hrstr): Last argument is now EMACS_INT.
13045
13046 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13047 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13048 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13049 (decode_coding_utf_16, decode_coding_emacs_mule)
13050 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13051 (decode_coding_ccl, decode_coding_charset)
13052 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13053 (decode_coding_iso_2022, decode_coding_emacs_mule)
13054 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13055 <char_offset, last_offset>: Declare EMACS_INT.
13056 (encode_coding_utf_8, encode_coding_utf_16)
13057 (encode_coding_emacs_mule, encode_invocation_designation)
13058 (encode_designation_at_bol, encode_coding_iso_2022)
13059 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13060 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13061 Declare EMACS_INT.
13062 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13063 (encode_invocation_designation): Last argument P_NCHARS is now
13064 EMACS_INT.
13065 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13066 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13067
13068 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13069 All users changed.
13070
13071 * ccl.c (Fccl_execute_on_string): Declare some variables
13072 EMACS_INT.
13073
8546720e 130742011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13075
13076 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13077
4e19a977
CS
130782011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13079
13080 * process.c (Fformat_network_address): Doc fix.
13081
87302331
R
130822011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13083
ee7683eb 13084 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13085
cbb59342
CY
130862011-04-08 Chong Yidong <cyd@stupidchicken.com>
13087
13088 * keyboard.c (read_char): Call Lisp function help-form-show,
13089 instead of using internal_with_output_to_temp_buffer.
13090 (Qhelp_form_show): New var.
e0d38eeb 13091 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13092
13093 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13094
13095 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13096
e67a13ab
CY
130972011-04-06 Chong Yidong <cyd@stupidchicken.com>
13098
04f2d78b
CB
13099 * process.c (Flist_processes): Remove to Lisp.
13100 (list_processes_1): Delete.
e67a13ab 13101
973f782d
EZ
131022011-04-06 Eli Zaretskii <eliz@gnu.org>
13103
7c106b1e
EZ
13104 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13105
973f782d
EZ
13106 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13107
41cf7d1a 131082011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13109
ca23cc88
PE
13110 Fix more problems found by GCC 4.6.0's static checks.
13111
f390e2d5
PE
13112 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13113
42eea0d0
PE
13114 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13115
b69769da 13116 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13117
f9541e84
PE
13118 * xdisp.c (vmessage): Mark as a printf-like function.
13119
13841b55
PE
13120 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13121
c136c10f
PE
13122 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13123
5e2d4a30
PE
13124 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13125 printf-like functions.
13126 (tiff_load): Add casts to remove these marks before passing them
13127 to system-supplied API.
13128
583f48b9
PE
13129 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13130
b25d760e
PE
13131 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13132 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13133 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13134 directly, rather than having caller test rule sign. This avoids
13135 some unnecessary tests.
13136 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13137 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13138 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13139
bc7b6697 13140 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13141 (xfont_open): Avoid unnecessary tests.
bc7b6697 13142
27ccc379
PE
13143 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13144
dcd5c89a
PE
13145 * composite.h, composite.c (composition_gstring_put_cache):
13146 Use EMACS_INT, not int, for length.
13147
b13a45c6
PE
13148 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13149 breaking out part of COMPOSITION_DECODE_RULE.
13150 (COMPOSITION_DECODE_RULE): Use it.
13151 * composite.c (get_composition_id): Remove unused local vars,
13152 by using the new macro.
13153
1e792e4d
PE
13154 * textprop.c (set_text_properties_1): Change while to do-while,
13155 since the condition is always true at first.
13156
dc6c6455 13157 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13158 (interval_deletion_adjustment): Return unsigned value.
13159 All uses changed.
dc6c6455 13160
aba7731a
PE
13161 * process.c (list_processes_1, create_pty, read_process_output):
13162 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13163 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13164 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13165 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13166 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13167
fdfc4bf3
PE
13168 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13169
fca8fe46 13170 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13171 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13172
06a0259a 13173 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13174 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13175 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13176
e7b9e80f
PE
13177 * print.c (print_error_message): Avoid int overflow.
13178
56201685
PE
13179 * font.c (font_list_entities): Redo for clarity,
13180 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13181
78834453 13182 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13183 (font_score): Avoid potential overflow in diff calculation.
78834453 13184
0bc0b309 13185 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13186 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13187
e610eaca
PE
13188 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13189
b895abce
PE
13190 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13191 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13192 can always succeed if overflow has undefined behavior.
13193
1f1d9321 13194 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13195 (wordify): Omit three unnecessary tests.
1f1d9321 13196
c59478bc
PE
13197 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13198 All callers changed. This avoids the need for an unused var.
13199
79b73827
PE
13200 * casefiddle.c (casify_region): Remove var that is set but not used.
13201
a4db5dfe
PE
13202 * dired.c (file_name_completion): Remove var that is set but not used.
13203
43aae36e
PE
13204 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13205
2a47c44d 13206 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13207 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13208
a37c69bf
PE
13209 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13210 Check for integer overflow on size calculations.
13211
328ab8e7
PE
13212 * buffer.c (Fprevious_overlay_change): Remove var that is set
13213 but not used.
13214
e5a2a5cb
PE
13215 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13216 Remove vars that are set but not used.
8d84a6eb 13217 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13218 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13219
a60e5f68
PE
13220 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13221
f661cb61 13222 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13223 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13224
f0397f5a
PE
13225 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13226 that are set but not used.
13227
8664db06 13228 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13229 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13230
6abdaa4a
PE
13231 * xselect.c (x_get_local_selection, x_handle_property_notify):
13232 Remove vars that are set but not used.
13233
0ce7538d 13234 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13235 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13236
9ae848fc
PE
13237 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13238 Remove var that is set but not used.
0b918413
PE
13239 (scroll_bar_windows_size): Now size_t, not int.
13240 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13241 Check for overflow.
9ae848fc 13242
a5a62657
PE
13243 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13244 (map_tty_color) [!defined MSDOS]: Likewise.
13245
5c5cdd39
PE
13246 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13247
66ebf983
PE
13248 * coding.c: Remove vars that are set but not used.
13249 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13250 All callers changed.
13251 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13252 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13253 (decode_coding_charset): Remove vars that are set but not used.
13254
1be4d761
PE
13255 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13256 that is set but not used.
13257
47553fa8
PE
13258 * print.c (print_object): Remove var that is set but not used.
13259
1f7196bf 13260 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13261 The gnulib version avoids calling malloc in the usual case,
13262 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13263 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13264 * filelock.c (current_lock_owner): Likewise.
13265 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13266 * sysdep.c: Include allocator.h, careadlinkat.h.
13267 (emacs_no_realloc_allocator): New static constant.
13268 (emacs_readlink): New function.
fdb61804
PE
13269 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13270 ../lib/careadlinkat.h.
d1fdcab7 13271
f84c17c7
SM
132722011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13273
13274 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13275 first non-nil return value).
13276
ef3862ad
JD
132772011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13278
13279 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13280 if not defined (Bug#8403).
13281
376a7006
JB
132822011-04-02 Juanma Barranquero <lekktu@gmail.com>
13283
13284 * xdisp.c (display_count_lines): Remove parameter `start',
13285 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13286 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13287 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13288 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13289 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13290 and thereabouts. All callers changed.
13291 (get_per_char_metric): Remove parameter `f', unused since
13292 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13293
6ca3801d
JM
132942011-04-02 Jim Meyering <meyering@redhat.com>
13295
13296 do not dereference NULL upon failed strdup
13297 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13298 (ns_get_family): Likewise.
13299
d8e2b5ba
JB
133002011-04-02 Juanma Barranquero <lekktu@gmail.com>
13301
13302 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13303
8c74fcbd
JD
133042011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13305
13306 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13307 later (Bug#8403).
13308
7200d79c
SM
133092011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13310
03408648 13311 Add lexical binding.
7200d79c 13312
03408648
SM
13313 * window.c (Ftemp_output_buffer_show): New fun.
13314 (Fsave_window_excursion):
13315 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13316
13317 * lread.c (lisp_file_lexically_bound_p): New function.
13318 (Fload): Bind Qlexical_binding.
13319 (readevalloop): Remove `evalfun' arg.
13320 Bind Qinternal_interpreter_environment.
13321 (Feval_buffer): Bind Qlexical_binding.
13322 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13323 Mark as dynamic.
13324 (syms_of_lread): Declare `lexical-binding'.
13325
13326 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13327
13328 * keyboard.c (eval_dyn): New fun.
13329 (menu_item_eval_property): Use it.
ca105506
SM
13330
13331 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13332
03408648
SM
13333 * fns.c (concat, mapcar1): Accept byte-code-functions.
13334
13335 * eval.c (Fsetq): Handle lexical vars.
13336 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13337 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13338 (FletX, Flet): Obey lexical binding.
13339 (Fcommandp): Handle closures.
13340 (Feval): New `lexical' arg.
13341 (eval_sub): New function extracted from Feval. Use it almost
13342 everywhere where Feval was used. Look up vars in lexical env.
13343 Handle closures.
13344 (Ffunctionp): Move from subr.el.
13345 (Ffuncall): Handle closures.
13346 (apply_lambda): Remove `eval_flags'.
13347 (funcall_lambda): Handle closures and new byte-code-functions.
13348 (Fspecial_variable_p): New function.
13349 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13350 but without exporting it to Lisp.
23aba0ea 13351
23aba0ea 13352 * doc.c (Fdocumentation, store_function_docstring):
03408648 13353 * data.c (Finteractive_form): Handle closures.
23aba0ea 13354
03408648
SM
13355 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13356 interactive spec.
ba83908c 13357
04f2d78b
CB
13358 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13359 New byte-codes.
03408648
SM
13360 (exec_byte_code): New function extracted from Fbyte_code to handle new
13361 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13362
03408648 13363 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13364
03408648 13365 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13366
e2abce01
JB
133672011-03-31 Juanma Barranquero <lekktu@gmail.com>
13368
13369 * xdisp.c (redisplay_internal): Fix prototype.
13370
63696a73 133712011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13372
63696a73 13373 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13374 (try_scrolling): Use it when setting scroll_limit.
13375 Limit scrolling to 100 screen lines.
63696a73
EZ
13376 (redisplay_window): Even when falling back on "recentering",
13377 position point in the window according to scroll-conservatively,
13378 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13379
13380 (try_scrolling): When point is above the window, allow searching
13381 as far as scroll_max, or one screenful, to compute vertical
13382 distance from PT to the scroll margin position. This prevents
13383 try_scrolling from unnecessarily failing when
13384 scroll-conservatively is set to a value slightly larger than the
13385 window height. Clean up the case of PT below the margin at bottom
13386 of window: scroll_max can no longer be INT_MAX. When aggressive
13387 scrolling is in use, don't let point enter the opposite scroll
13388 margin as result of the scroll.
13389 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13390 threshold of 100 lines for never-recentering scrolling.
13391
e4cc2dfc
JB
133922011-03-31 Juanma Barranquero <lekktu@gmail.com>
13393
13394 * dispextern.h (move_it_by_lines):
13395 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13396 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13397 (message_log_check_duplicate): Remove parameters `prev_bol' and
13398 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13399 (redisplay_internal): Remove parameter `preserve_echo_area',
13400 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13401
13402 * indent.c (Fvertical_motion):
13403 * window.c (window_scroll_pixel_based, Frecenter):
13404 Don't pass `need_y_p' to `move_it_by_lines'.
13405
1c470562
SM
134062011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13407
44f230aa
SM
13408 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13409 steal a few bits to be more compact.
13410 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13411 Remove unneeded casts.
13412
1c470562
SM
13413 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13414
888adce9
ZK
134152011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13416
13417 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13418 binding" message (bug#7967).
13419
f838ed7b
PE
134202011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13421
77861b95
PE
13422 Fix more problems found by GCC 4.6.0's static checks.
13423
de6dbc14
PE
13424 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13425 Remove unused local var.
13426
f838ed7b
PE
13427 * editfns.c (Fmessage_box): Remove unused local var.
13428
792c7b2b
PE
13429 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13430 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13431 Omit unused local vars.
c499e557 13432 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13433 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13434 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13435 Omit unused local var.
13436
ba0165e1
PE
13437 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13438 Don't assume string length fits in int.
32ad8845 13439 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13440 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13441
3c59b4c9
PE
13442 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13443 instead of alloca (Bug#8344).
13444
a3eed478 13445 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13446 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13447
eb4d412d
PE
13448 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13449
1658b401
PE
13450 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13451 concerns.
13452
13453 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13454
13455 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13456
9a2c6e05
PE
13457 * keyboard.c (syms_of_keyboard): Use the same style as later
13458 in this function when indexing through an array. This also
13459 works around GCC bug 48267.
13460
03d0a109
PE
13461 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13462
44f730c8
PE
13463 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13464
fe75f926
PE
13465 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13466 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13467
ffa8c828
PE
13468 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13469 This avoids undefined behavior on integer overflow, and is a bit
13470 more convenient anyway since it is compared to a size_t variable.
13471
c5101a77
PE
13472 Variadic C functions now count arguments with size_t, not int.
13473 This avoids an unnecessary limitation on 64-bit machines, which
13474 caused (substring ...) to crash on large vectors (Bug#8344).
13475 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13476 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13477 All variadic functions and their callers changed accordingly.
c5101a77
PE
13478 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13479 * data.c (arith_driver, float_arith_driver): Likewise.
13480 * editfns.c (general_insert_function): Likewise.
13481 * eval.c (struct backtrace.nargs, interactive_p)
13482 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13483 (funcall_lambda, mark_backtrace): Likewise.
13484 * fns.c (concat): Likewise.
13485 * frame.c (x_set_frame_parameters): Likewise.
13486 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13487 0 if not found, not -1. All callers changed.
13488
dd3f25f7
PE
13489 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13490 (stack_copy_size): Now size_t, not int.
13491 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13492
461c2ab9
JB
134932011-03-28 Juanma Barranquero <lekktu@gmail.com>
13494
13495 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13496 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13497 All callers changed.
13498
13499 * lisp.h (multibyte_char_to_unibyte):
13500 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13501 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13502 * character.h (CHAR_TO_BYTE8):
13503 * cmds.c (internal_self_insert):
13504 * editfns.c (general_insert_function):
13505 * keymap.c (push_key_description):
13506 * search.c (Freplace_match):
13507 * xdisp.c (message_dolog, set_message_1): All callers changed.
13508
f6d62986
SM
135092011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13510
13511 * keyboard.c (safe_run_hook_funcall): New function.
13512 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13513 don't set the hook to nil, but remove the offending function instead.
13514 (Qcommand_hook_internal): Remove, unused.
13515 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13516 Vcommand_hook_internal.
13517
13518 * eval.c (enum run_hooks_condition): Remove.
13519 (funcall_nil, funcall_not): New functions.
13520 (run_hook_with_args): Call each function through a `funcall' argument.
13521 Remove `cond' argument, now redundant.
13522 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13523 (Frun_hook_with_args_until_failure): Adjust accordingly.
13524 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13525
1db5b1ad
JB
135262011-03-28 Juanma Barranquero <lekktu@gmail.com>
13527
13528 * dispextern.h (string_buffer_position): Remove declaration.
13529
13530 * print.c (strout): Remove parameter `multibyte', unused since
13531 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13532
13533 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13534 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13535 All callers changed.
13536
13537 * w32.c (_wsa_errlist): Use braces for struct initializers.
13538
13539 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13540 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13541 All callers changed.
13542 (string_buffer_position): Likewise. Also, make static (it's never
13543 used outside xdisp.c).
13544 (cursor_row_p): Remove parameter `w', unused since
13545 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13546 (decode_mode_spec): Remove parameter `precision', introduced during
13547 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13548 All callers changed.
13549
5ffb62aa
JD
135502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13551
13552 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13553
461c2ab9 135542011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13555
13556 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13557 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13558 (ns_update_auto_hide_menu_bar): New functions.
13559 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13560 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13561 ns_constrain_all_frames.
13562 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13563 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13564
5c380ffb
JD
135652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13566
13567 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13568
9af30bdf
GM
135692011-03-27 Glenn Morris <rgm@gnu.org>
13570
13571 * syssignal.h: Replace RETSIGTYPE with void.
13572 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13573 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13574 Replace SIGTYPE with void everywhere.
13575 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13576 * s/template.h (SIGTYPE): Remove commented out definition.
13577
e2abce01
JB
135782011-03-26 Eli Zaretskii <eliz@gnu.org>
13579
13580 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13581 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13582
f868cd8a
JB
135832011-03-26 Juanma Barranquero <lekktu@gmail.com>
13584
59eb0929
JB
13585 * w32.c (read_unc_volume): Use parameter `henum', instead of
13586 global variable `wget_enum_handle'.
13587
13588 * keymap.c (describe_vector): Remove parameters `indices' and
13589 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13590 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13591
f868cd8a
JB
13592 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13593
13594 * keyboard.c (timer_check): Remove parameter `do_it_now',
13595 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13596 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13597 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13598
13599 * keyboard.c (read_char):
13600 * w32menu.c (w32_menu_display_help):
13601 * xmenu.c (show_help_event, menu_help_callback):
13602 Adjust calls to `show_help_echo'.
13603
13604 * gtkutil.c (xg_maybe_add_timer):
13605 * keyboard.c (readable_events):
13606 * process.c (wait_reading_process_output):
13607 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13608
13609 * insdel.c (adjust_markers_gap_motion):
13610 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13611 (gap_left, gap_right): Don't call it.
13612
2ecf6fdb
CY
136132011-03-25 Chong Yidong <cyd@stupidchicken.com>
13614
13615 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13616 incurred during fontification.
13617
6b1f9ba4
JB
136182011-03-25 Juanma Barranquero <lekktu@gmail.com>
13619
13620 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13621 (DEFVAR_PER_BUFFER): Don't pass it.
13622
13623 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13624 (scrolling_window): Don't pass it.
13625
0f4a96b5
JB
136262011-03-25 Juanma Barranquero <lekktu@gmail.com>
13627
13628 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13629
13630 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13631 and `suffix'.
13632 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13633 of variables specific to SELinux and computation of `encoded_absname'.
13634
13635 * image.c (XPutPixel): Remove unused variable `height'.
13636
13637 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13638
13639 * unexw32.c (get_section_info): Remove unused variable `section'.
13640
13641 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13642 (system_process_attributes): Remove unused variable `sess'.
13643 (sys_read): Remove unused variable `err'.
13644
13645 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13646 (w32_wnd_proc): Remove unused variable `isdead'.
13647 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13648 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13649 (x_create_tip_frame): Remove unused variable `tem'.
13650
13651 * w32inevt.c (w32_console_read_socket):
13652 Remove unused variable `no_events'.
13653
13654 * w32term.c (x_draw_composite_glyph_string_foreground):
13655 Remove unused variable `width'.
13656
1149507c
JB
136572011-03-24 Juanma Barranquero <lekktu@gmail.com>
13658
13659 * w32term.c (x_set_glyph_string_clipping):
13660 Don't pass uninitialized region to CombineRgn.
13661
9c88f339
JB
136622011-03-23 Juanma Barranquero <lekktu@gmail.com>
13663
13664 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13665 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13666 (Fx_close_connection): Remove unused variable `i'.
13667
13668 * w32font.c (w32font_draw): Return number of glyphs.
13669 (w32font_open_internal): Remove unused variable `i'.
13670 (w32font_driver): Add missing initializer.
13671
13672 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13673 (fill_in_menu): Remove unused variable `items_added'.
13674
13675 * w32term.c (last_mouse_press_frame): Remove static global variable.
13676 (w32_clip_to_row): Remove unused variable `f'.
13677 (x_delete_terminal): Remove unused variable `i'.
13678
13679 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13680 (NOTHING): Remove unused static global variable.
13681 (uniscribe_check_otf): Remove unused variable `table'.
13682 (uniscribe_font_driver): Add missing initializers.
13683
dee091a3
JD
136842011-03-23 Julien Danjou <julien@danjou.info>
13685
13686 * term.c (Fsuspend_tty, Fresume_tty):
13687 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13688 * window.c (temp_output_buffer_show):
13689 * insdel.c (signal_before_change):
13690 * frame.c (Fhandle_switch_frame):
13691 * fileio.c (Fdo_auto_save):
13692 * emacs.c (Fkill_emacs):
13693 * editfns.c (save_excursion_restore):
13694 * cmds.c (internal_self_insert):
13695 * callint.c (Fcall_interactively):
13696 * buffer.c (Fkill_all_local_variables):
13697 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13698 Use Frun_hooks.
0f4a96b5 13699 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13700 unconditionally since it does the check itself.
dee091a3 13701
2c520ab5 137022011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13703
c9c49752
PE
13704 Fix more problems found by GCC 4.5.2's static checks.
13705
8abc3f12
PE
13706 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13707 the first time through the loop, since we know p0 < p1 then.
13708 This also avoids a gcc -Wstrict-overflow warning.
13709
a2d26660
PE
13710 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13711 leading to a memory leak, possible in functions like
13712 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13713 of objects (Bug#8318).
a2d26660 13714
916c72e9
PE
13715 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13716 that could (at least in theory) be that large.
13717
19ab8a18
PE
13718 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13719 This is less likely to overflow, and avoids undefined behavior if
13720 overflow does occur. All callers changed. Use strtoul to scan
13721 for the unsigned long integer.
b7cbbd6f
PE
13722 (pint2hrstr): Simplify and tune code slightly.
13723 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13724
f0641eff
PE
13725 * scroll.c (do_scrolling): Work around GCC bug 48228.
13726 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13727
7f650bb9
PE
13728 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13729 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13730 (validate_x_resource_name): Simplify count usage.
13731 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13732
37dd57d1
PE
13733 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13734 fail (Bug#8306).
81e56e61 13735
699979fc 13736 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13737
401bf9b4
PE
13738 * process.c (Fmake_network_process): Use socklen_t, not int,
13739 where POSIX says socklen_t is required in portable programs.
13740 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13741 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13742 (Fmake_network_process, server_accept_connection):
13743 (wait_reading_process_output, read_process_output):
13744 Likewise.
13745
b93aacde
PE
13746 * process.c: Rename or move locals to avoid shadowing.
13747 (list_processes_1, Fmake_network_process):
13748 (read_process_output_error_handler, exec_sentinel_error_handler):
13749 Rename or move locals.
4dc343ee 13750 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13751 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13752 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13753 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13754 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13755
af8a867c 13756 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13757 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13758 Include tparam.h instead, since it declares them.
af8a867c
PE
13759 * cm.h (PC): Remove extern decl; tparam.h now does this.
13760 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13761 * terminfo.c: Include tparam.h, to check interfaces.
13762 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13763 (tparam): Adjust signature to match interface in tparam.h;
13764 this removes some undefined behavior. Check that outstring and len
13765 are zero, which they always are with Emacs.
13766 * tparam.h (PC, BC, UP): New extern decls.
13767
0248044d 13768 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13769 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13770
8ff096c1 13771 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13772 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13773 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13774 (ftfont_list): Remove unused local.
49eaafba
PE
13775 (get_adstyle_property, ftfont_pattern_entity):
13776 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13777 Rename locals to avoid shadowing.
8ff096c1 13778
e2be39f6
PE
13779 * xfont.c (xfont_list_family): Mark var as initialized.
13780
c9735e30
PE
13781 * xml.c (make_dom): Now static.
13782
8f5201ae
PE
13783 * composite.c (composition_compute_stop_pos): Rename local to
13784 avoid shadowing.
b246f932
PE
13785 (composition_reseat_it): Remove unused locals.
13786 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13787 (composition_update_it): Mark var as initialized.
11b61122
PE
13788 (find_automatic_composition): Mark vars as initialized,
13789 with a FIXME (Bug#8290).
8f5201ae 13790
760fbc2c
PE
13791 character.h: Rename locals to avoid shadowing.
13792 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13793 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13794 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13795 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13796 to avoid shadowing.
13797
ff08eb85
PE
13798 * textprop.c (property_change_between_p): Remove; unused.
13799
fc7bf025
PE
13800 * intervals.c (interval_start_pos): Now static.
13801
235d7abc
PE
13802 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13803
44f230aa
SM
13804 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13805 Rename locals to avoid shadowing.
3e7d6594 13806
50060332
PE
13807 * sound.c (wav_play, au_play, Fplay_sound_internal):
13808 Fix pointer signedness.
d01f234b 13809 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13810 (wav_play): Initialize a variable to 0, to prevent undefined
13811 behavior (Bug#8278).
50060332 13812
c4fc4e30
PE
13813 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13814
918436ed
PE
13815 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13816
c939f91b
PE
13817 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13818 clobbering (Bug#8298).
b9c7f648
PE
13819 * sysdep.c (sys_subshell): Likewise.
13820 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13821
6bd8c144
PE
13822 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13823 This should get cleaned up, so that child_setup has the
13824 same signature on all platforms.
13825
7710357c 13826 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13827 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13828
c59da222
CY
138292011-03-22 Chong Yidong <cyd@stupidchicken.com>
13830
13831 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13832 not to be necessary, and produces flickering.
13833
66b87493
GM
138342011-03-20 Glenn Morris <rgm@gnu.org>
13835
13836 * config.in: Remove file.
13837
45b6f6d5
JB
138382011-03-20 Juanma Barranquero <lekktu@gmail.com>
13839
13840 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13841 are now in src/globals.h.
13842 (syms_of_minibuf): Remove spurious & from previous change.
13843
cd394be1 138442011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13845
13846 * minibuf.c (completing-read-function): New variable.
13847 (completing-read-default): Rename from completing-read.
13848 (completing-read): Call completing-read-function.
13849
b14e3e21
CY
138502011-03-19 Juanma Barranquero <lekktu@gmail.com>
13851
13852 * xfaces.c (Fx_load_color_file):
13853 Read color file from absolute filename (bug#8250).
13854
f2b726e6
JB
138552011-03-19 Juanma Barranquero <lekktu@gmail.com>
13856
13857 * makefile.w32-in: Update dependencies.
13858
09f6ff02
EZ
138592011-03-17 Eli Zaretskii <eliz@gnu.org>
13860
13861 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13862
29a6015a
PE
138632011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13864
a3a6c54e
PE
13865 Fix more problems found by GCC 4.5.2's static checks.
13866
b766f867
PE
13867 * process.c (make_serial_process_unwind, send_process_trap):
13868 (sigchld_handler): Now static.
13869
be02381c
PE
13870 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13871 That way, the code declares only the vars that it needs.
13872 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13873 * s/cygwin.h (PTY_ITERATION): Likewise.
13874 * s/darwin.h (PTY_ITERATION): Likewise.
13875 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13876
57048744
PE
13877 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13878 * process.c (allocate_pty): Don't declare stb unless it's needed.
13879
7914961c 13880 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13881 (CONSTANTLIM): Remove; unused.
13882 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13883 Define only if needed.
7914961c 13884
b3967b18
PE
13885 * unexelf.c (unexec): Name an expression,
13886 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13887 Use a different way to cause a compilation error if anyone uses
13888 n rather than nn, a way that does not involve shadowing.
73366a00 13889 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13890
29a6015a
PE
13891 * deps.mk (unexalpha.o): Remove; unused.
13892
43cfc33e 13893 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13894 * unexec.h: New file.
ce701a33
PE
13895 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13896 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13897 Depend on unexec.h.
13898 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13899 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13900 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13901 Change as necessary to match prototype in unexec.h.
ce701a33 13902
01f44d5a
PE
13903 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13904 shadowing.
4f63c6bb 13905 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13906
a6670b0b
PE
13907 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13908 Rename locals to avoid shadowing.
13909
cef2010d 13910 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13911 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13912
d4d7173a
PE
13913 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13914
f08b802a
PE
13915 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13916 warning when compiling print.c.
13917
3ddb0639
PE
13918 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13919 instead of using an uninitialized var.
5ad03b97 13920 (font_sort_entities): Mark var as initialized.
3ddb0639 13921
170a2692
PE
13922 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13923
e663c700
PE
13924 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13925 pointers to constants.
89bc529a 13926 (font_parse_fcname): Remove unused vars.
7b81e2d0 13927 (font_delete_unmatched): Now static.
ea838e10 13928 (font_get_spec): Remove; unused.
13a547c6
PE
13929 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13930 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13931 Rename or move locals to avoid shadowing.
e663c700 13932
2a80c887 13933 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13934 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13935
1384fa33 13936 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13937 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13938
8b2c52e9
PE
13939 * alloc.c (mark_backtrace): Move decl from here ...
13940 * lisp.h: ... to here, so that it can be checked.
13941
475545b5 13942 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13943 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13944 (lisp_indirect_variable): Name an expression,
13945 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13946 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13947
b1349114 13948 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13949 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13950 Use const pointer when appropriate.
b1349114 13951
a2928364
PE
13952 * lisp.h (get_system_name, get_operating_system_release):
13953 Move decls here, to check interfaces.
13954 * process.c (get_operating_system_release): Move decl to lisp.h.
13955 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13956 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13957 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13958 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13959 (Fformat_time_string, Fencode_time, Finsert_char):
13960 (Ftranslate_region_internal, Fformat):
13961 Rename or remove local vars to avoid shadowing.
9710023e 13962 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13963
a415e694
PE
13964 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13965 avoid shadowing.
13966
8ef4622d
PE
13967 * lisp.h (eassert): Check that the argument compiles, even if
13968 ENABLE_CHECKING is not defined.
13969
946f9a5b
PE
13970 * data.c (Findirect_variable): Name an expression, to avoid
13971 gcc -Wbad-function-cast warning.
112396d6 13972 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13973 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13974 (Fmake_variable_buffer_local, Fmake_local_variable):
13975 Mark variables as initialized.
52746918 13976 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13977
e5aab7e7 13978 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13979 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13980 Rename locals to avoid shadowing.
dff45157
PE
13981 (mark_stack): Move local variables into the #ifdef region where
13982 they're used.
7bc26fdb
PE
13983 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13984 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13985 needed otherwise.
13986 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13987 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13988 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13989
e5aab7e7
PE
13990 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13991 avoids undefined behavior in theory.
13992
4da60324
PE
13993 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13994
88043301
PE
13995 Use functions, not macros, for up- and down-casing (Bug#8254).
13996 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13997 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13998 to use the following functions instead of these macros.
13999 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14000 EMACS_INT, since callers assume the returned value fits in int.
14001 (upcase1): Likewise, for UPCASE_TABLE.
14002 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14003 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14004 the race-condition problem in the old DOWNCASE.
88043301 14005
19ed5445
PE
14006 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14007 Rename locals to avoid shadowing.
14008 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14009 (regex_compile, re_search_2, re_match_2_internal):
14010 Remove unused local vars.
952db0d7
PE
14011 (FREE_VAR): Rewrite so as not to use empty "else",
14012 which gcc can warn about.
da053e48 14013 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14014 (RETALLOC_IF): Define only if needed.
14015 (WORDCHAR_P): Likewise. This one is never needed, but is used
14016 only in a comment talking about a compiler bug, so put inside
14017 the #if 0 of that comment.
14018 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14019 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14020 Remove; unused.
19ed5445 14021
1f3561e4 14022 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14023 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14024 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14025
ded6f8f7
PE
14026 * search.c (simple_search): Remove unused var.
14027
dbd37a95
PE
14028 * dired.c (compile_pattern): Move decl from here ...
14029 * lisp.h: ... to here, so that it can be checked.
14030 (struct re_registers): New forward decl.
14031
7e47afad
PE
14032 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14033
85f24f61
PE
14034 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14035 All uses changed.
14036 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14037 Rename locals to avoid shadowing.
5671df8f 14038 (Fvertical_motion): Mark locals as initialized.
85f24f61 14039
181aa2be 14040 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14041 (casify_region): Mark local as initialized.
181aa2be 14042
930d429c
PE
14043 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14044
7082eac6
PE
14045 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14046 New macros, so that the caller can use some names other than
14047 gcpro1, gcpro2, etc.
14048 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14049 of the new macros.
14050 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14051 argument, for consistency with GCPRO2_VAR, etc: it is now the
14052 prefix of the variable, not the variable itself. All uses
14053 changed.
38b2c076
PE
14054 * dired.c (directory_files_internal, file_name_completion):
14055 Rename locals to avoid shadowing.
14056
15206ed9
PE
14057 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14058 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14059 dired.c's scmp function, had undefined behavior.
14060 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14061 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14062 * buffer.h: ... to here, because these macros use current_buffer,
14063 and the new implementation with inline functions needs to have
14064 current_buffer in scope now, rather than later when the macros
14065 are used.
14066 (downcase, upcase1): New static inline functions.
14067 (DOWNCASE, UPCASE1): Reimplement using these functions.
14068 This avoids undefined behavior in expressions like
14069 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14070 from race conditions in accessing the global variables
14071 case_temp1 and case_temp2.
14072 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14073 * lisp.h (case_temp1, case_temp2): Remove their decls.
14074 * character.h (ASCII_CHAR_P): Move from here ...
14075 * lisp.h: ... to here, so that the inline functions mentioned
14076 above can use them.
14077
4a6bea26
PE
14078 * dired.c (directory_files_internal_unwind): Now static.
14079
f14b7e14
PE
14080 * fileio.c (file_name_as_directory, directory_file_name):
14081 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14082 Now static.
2893f146
PE
14083 (file_name_as_directory): Use const pointers when appropriate.
14084 (Fexpand_file_name): Likewise. In particular, newdir might
14085 point at constant storage, so make it a const pointer.
fd4ead52 14086 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14087 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14088 signedness issues.
f839df0c
PE
14089 (Fset_file_times, Finsert_file_contents, auto_save_error):
14090 Rename locals to avoid shadowing.
f14b7e14 14091
5716756e 14092 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14093 (Ftry_completion, Fall_completions): Rename or remove locals
14094 to avoid shadowing.
5716756e 14095
b4c3046a
PE
14096 * marker.c (bytepos_to_charpos): Remove; unused.
14097
b45db522
PE
14098 * lisp.h (verify_bytepos, count_markers): New decls,
14099 so that gcc does not warn that these functions aren't declared.
14100
85876d07
PE
14101 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14102 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14103 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14104 (copy_text): Remove unused local var.
85876d07 14105
03d78a21 14106 * filelock.c (within_one_second): Now static.
b3dd38ab 14107 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14108
5df8f01b
PE
14109 * buffer.c (fix_overlays_before): Mark locals as initialized.
14110 (fix_start_end_in_overlays): Likewise. This function should be
14111 simplified by using pointers-to-pointers, but that's a different
14112 matter.
b1d876f1 14113 (switch_to_buffer_1): Now static.
8f54f30a
PE
14114 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14115 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14116
a70072c9 14117 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14118 Fix pointer signedness issue.
edced198
PE
14119 (sys_subshell): Mark local as volatile if checking for lint,
14120 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14121 (MAXPATHLEN): Define only if needed.
a70072c9 14122
a0977c44
PE
14123 * process.c (serial_open, serial_configure): Move decls from here ...
14124 * systty.h: ... to here, so that they can be checked.
14125
a884fdcc
PE
14126 * fns.c (get_random, seed_random): Move extern decls from here ...
14127 * lisp.h: ... to here, so that they can be checked.
14128
604efe86 14129 * sysdep.c (reset_io): Now static.
b8950c94 14130 (wait_for_termination_signal): Remove; unused.
604efe86 14131
38fc62d9
PE
14132 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14133 (copy_keymap_item, append_key, push_text_char_description):
14134 Now static.
1004a21a 14135 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14136 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14137 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14138 (describe_map_tree):
14139 Rename locals to avoid shadowing.
38fc62d9 14140
2f2650da
PE
14141 * keyboard.c: Declare functions static if they are not used elsewhere.
14142 (echo_char, echo_dash, cmd_error, top_level_2):
14143 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14144 (read_char, kbd_buffer_get_event, make_lispy_position):
14145 (make_lispy_event, make_lispy_movement, apply_modifiers):
14146 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14147 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14148 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14149 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14150 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14151
a053e86c 14152 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14153 (mark_kboards): Move decl here ...
14154 * alloc.c (mark_kboards): ... from here.
a053e86c 14155
4752793e
PE
14156 * lisp.h (force_auto_save_soon): New decl.
14157
74f10ca7 14158 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14159 (DEFINE_DUMMY_FUNCTION): New macro.
14160 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14161 Use it.
c03cd23f
PE
14162 (main): Add casts to avoid warnings
14163 if GCC considers string literals to be constants.
74f10ca7 14164
022e70d4
PE
14165 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14166
59d6fe83
PE
14167 * dbusbind.c: Pointer signedness fixes.
14168 (xd_signature, xd_append_arg, xd_initialize):
14169 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14170 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14171 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14172 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14173
78320123
PE
14174 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14175 if GCC considers string literals to be constants.
49cebcca 14176 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14177
35ac2a97
SM
141782011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14179
fb103ca9
SM
14180 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14181 (print_preprocess, print_object): New macro to fix last change.
14182
35ac2a97
SM
14183 * print.c (print_preprocess): Don't forget font objects.
14184
62973b41
JB
141852011-03-16 Juanma Barranquero <lekktu@gmail.com>
14186
14187 * emacs.c (USAGE3): Doc fixes.
14188
0e48bb22
AS
141892011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14190
14191 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14192 structure.
14193
7684e57b
JB
141942011-03-14 Juanma Barranquero <lekktu@gmail.com>
14195
14196 * lisp.h (VWindow_system, Qfile_name_history):
14197 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14198 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14199 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14200
14201 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14202 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14203
14204 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14205 * w32console.c (detect_input_pending, read_input_pending)
14206 (encode_terminal_code):
14207 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14208 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14209 (w32_system_caret_y, Qfile_name_history):
14210 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14211 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14212 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14213 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14214 * w32proc.c (Qlocal, report_file_error):
14215 * w32term.c (Vwindow_system, updating_frame):
14216 * w32uniscribe.c (initialized, uniscribe_font_driver):
14217 Remove unneeded extern declarations.
14218
2aa46d6c
CY
142192011-03-14 Chong Yidong <cyd@stupidchicken.com>
14220
c96bbc66 14221 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14222
cffc6f3b
CY
142232011-03-13 Chong Yidong <cyd@stupidchicken.com>
14224
14225 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14226 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14227 These macros can no longer be used for assignment.
14228
44f230aa
SM
14229 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14230 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14231 (record_buffer_markers, fetch_buffer_markers): New functions for
14232 recording and fetching special buffer markers.
14233 (set_buffer_internal_1, set_buffer_temp): Use them.
14234
14235 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14236
14237 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14238
14239 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14240 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14241
14242 * xdisp.c (hscroll_window_tree):
14243 (reconsider_clip_changes): Use PT instead of BUF_PT.
14244
d251f04b
EZ
142452011-03-13 Eli Zaretskii <eliz@gnu.org>
14246
14247 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14248 $(EMACS_ROOT)/lib/intprops.h.
14249
f0c77cd1
PE
142502011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14251
3eca4629
PE
14252 Fix more problems found by GCC 4.5.2's static checks.
14253
7c86ee98
PE
14254 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14255 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14256 (xg_free_frame_widgets): Make it clear that a local variable is
14257 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14258 (gdk_window_get_screen): Make it clear that this macro is needed
14259 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14260 (int_gtk_range_get_value): New function, which avoids a diagnostic
14261 from gcc -Wbad-function-cast.
14262 (xg_set_toolkit_scroll_bar_thumb): Use it.
14263 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14264 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14265 (get_utf8_string, xg_get_file_with_chooser):
14266 Rename locals to avoid shadowing.
14267 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14268
41729b81
PE
14269 * xgselect.c (xg_select): Remove unused var.
14270
f0c77cd1
PE
14271 * image.c (four_corners_best): Mark locals as initialized.
14272 (gif_load): Initialize transparent_p to zero (Bug#8238).
14273 Mark another local as initialized.
ec6cf4c6 14274 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14275
ce0ad53d 14276 * image.c (clear_image_cache): Now static.
d5d5a617 14277 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14278 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14279 (x_edge_detection): Remove unnecessary cast that
14280 gcc -Wbad-function-cast diagnoses.
2037898d 14281 (gif_load): Fix pointer signedness.
6ae141d6
PE
14282 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14283 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14284
33383987 142852011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14286
d32df629
PE
14287 Improve quality of tests for time stamp overflow.
14288 For example, without this patch (encode-time 0 0 0 1 1
14289 1152921504606846976) returns the obviously-bogus value (-948597
14290 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14291 reports time overflow. See
14292 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14293 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14294 * editfns.c: Include limits.h and intprops.h.
14295 (TIME_T_MIN, TIME_T_MAX): New macros.
14296 (time_overflow): Move earlier, to before first use.
14297 (hi_time, lo_time): New functions, for an accurate test for
14298 out-of-range times.
14299 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14300 (Fget_internal_run_time): Don't assume time_t fits in int.
14301 (make_time): Use list2 instead of Fcons twice.
14302 (Fdecode_time): More accurate test for out-of-range times.
14303 (check_tm_member): New function.
14304 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14305 (lisp_time_argument): Don't rely on undefined left-shift and
14306 right-shift behavior when checking for time stamp overflow.
8be6f318 14307
fe31d94c
PE
14308 * editfns.c (time_overflow): New function, refactoring common code.
14309 (Fformat_time_string, Fdecode_time, Fencode_time):
14310 (Fcurrent_time_string): Use it.
14311
8be6f318
PE
14312 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14313 * dired.c (make_time): Move to ...
14314 * editfns.c (make_time): ... here.
14315 * systime.h: Note the move.
14316
09d9db2c 143172011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14318
126bc0dc
YM
14319 * fringe.c (update_window_fringes): Remove unused variables.
14320
c47cbdfd
YM
14321 * unexmacosx.c (copy_data_segment): Also copy __got section.
14322 (Bug#8223)
14323
7ac80be9
EZ
143242011-03-12 Eli Zaretskii <eliz@gnu.org>
14325
c96bbc66 14326 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14327 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14328 Constify `char *' arguments and their references according to
14329 prototypes in tparam.h.
14330
ecb0f94d 14331 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14332
7ac80be9
EZ
14333 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14334 Adapt all references accordingly.
14335
14336 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14337
ef1fd07e
TT
143382011-03-11 Tom Tromey <tromey@redhat.com>
14339
14340 * buffer.c (syms_of_buffer): Remove obsolete comment.
14341
7ef4b50c
EZ
143422011-03-11 Eli Zaretskii <eliz@gnu.org>
14343
14344 * termhooks.h (encode_terminal_code): Declare prototype.
14345
14346 * msdos.c (encode_terminal_code): Don't declare prototype.
14347
14348 * term.c (encode_terminal_code): Now external again, used by
14349 w32console.c and msdos.c.
14350
44f230aa
SM
14351 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14352 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14353
4b1ec863 143542011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14355
1714f52b 14356 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14357
4b1ec863
PE
14358 * fringe.c (update_window_fringes): Mark locals as initialized
14359 (Bug#8227).
14360 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14361
524c7aa6
PE
14362 * alloc.c (mark_fringe_data): Move decl from here ...
14363 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14364 to check its interface.
14365 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14366
a5c0af81 14367 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14368 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14369 (fontset_font): Mark local as initialized.
a9a06e0b 14370 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14371
b4716021
PE
14372 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14373
811e9bac 14374 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14375 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14376 (x_own_selection, Fx_disown_selection_internal): Rename locals
14377 to avoid shadowing.
14378 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14379
7e3ab302
PE
14380 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14381 so that the caller can use some name other than gcpro1.
14382 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14383 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14384 (Fx_backspace_delete_keys_p):
14385 Use them to avoid shadowing, and rename vars to avoid shadowing.
14386 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14387 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14388 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14389 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14390 Remove unused locals.
7e3ab302
PE
14391 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14392 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14393 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14394 macros.
f78faa98 14395
e2b13473
PE
14396 * xterm.h (x_mouse_leave): New decl.
14397
77f23912
PE
14398 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14399 Remove unused functions.
cdf4ba58
PE
14400 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14401 (x_calc_absolute_position): Now static.
7411c686 14402 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14403 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14404 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14405 unless they are used.
38d0b34a
PE
14406 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14407 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14408 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14409 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14410 (x_error_catcher, x_connection_closed, x_error_handler):
14411 (x_error_quitter, xembed_send_message, x_iconify_frame):
14412 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14413 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14414 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14415
44f230aa
SM
14416 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14417 Rename or move locals to avoid shadowing.
6b463e58 14418 (tty_defined_color, merge_face_heights): Now static.
5967d051 14419 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14420 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14421 does not deduce is never used uninitialized.
73719eba
PE
14422 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14423 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14424
426994c3 14425 * terminal.c (store_terminal_param): Now static.
5489860b 14426
032f1620 14427 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14428 (set_frame_menubar): Remove unused local.
d4323972 14429 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14430 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14431 since they might point to immutable storage.
281585b0
PE
14432 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14433 since it's unused otherwise.
032f1620 14434
367c19e5 14435 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14436 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14437 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14438 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14439 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14440 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14441 does not deduce are never used uninitialized.
70739cbe 14442
07b48fa9
PE
14443 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14444
8868a238 14445 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14446 * window.c (window_loop, size_window):
14447 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14448
7e5cf297 14449 * window.c (display_buffer): Now static.
d6550a9f
PE
14450 (size_window): Mark variables that gcc -Wuninitialized
14451 does not deduce are never used uninitialized.
a586633d
PE
14452 * window.h (check_all_windows): New decl, to forestall
14453 gcc -Wmissing-prototypes diagnostic.
5b555da1 14454 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14455
f6095868
PE
14456 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14457 shadowing.
14458 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14459 Include <limits.h>.
14460 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14461 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14462 (load_charset_map): Mark variables that gcc -Wuninitialized
14463 does not deduce are never used uninitialized.
53df7c11 14464 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14465
f38b440c
PE
14466 * coding.c (coding_set_source, coding_set_destination):
14467 Use "else { /* comment */ }" rather than "else /* comment */;"
14468 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14469 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14470 a block, when the outer 'i' will do.
14471 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14472 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14473 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14474 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14475 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14476 Rename locals to avoid shadowing.
14477 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14478 * coding.c (emacs_mule_char, encode_invocation_designation):
14479 Now static, since they're not used elsewhere.
413bb2db 14480 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14481 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14482 (decode_coding_emacs_mule): Mark variables that gcc
14483 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14484 (detect_coding_iso_2022): Initialize a local variable that might
14485 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14486 this initialization is needed. (Bug#8211)
5f58e762
PE
14487 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14488 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14489 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14490 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14491 Remove unused macros.
f38b440c 14492
232b38b9 14493 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14494 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14495 * character.c (string_count_byte8): Likewise.
232b38b9 14496
fb90da1b
PE
14497 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14498 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14499
fb93dbc2
PE
14500 * chartab.c (copy_sub_char_table): Now static, since it's not used
14501 elsewhere.
5c156ace
PE
14502 (sub_char_table_ref_and_range, char_table_ref_and_range):
14503 Rename locals to avoid shadowing.
bbcd0949 14504 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14505
7d3b3862 14506 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14507 (BIDI_BOB): Remove unused macro.
7d3b3862 14508
6be7d3da
PE
14509 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14510 deduce are never used uninitialized.
c2ed9c8b 14511 * term.c (encode_terminal_code): Likewise.
6be7d3da 14512
75f8807f 14513 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14514
50938595
PE
14515 * tparam.h: New file.
14516 * term.c, tparam.h: Include it.
14517 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14518 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14519 Move these decls to tparam.h, and make them agree with what
14520 is actually in tparam.c. The previous trick of using incompatible
14521 decls in different modules does not conform to the C standard.
14522 All callers of tparam changed to use tparam's actual API.
14523 * tparam.c (tparam1, tparam, tgoto):
14524 Use const pointers where appropriate.
14525
fbceeba2
PE
14526 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14527 * cm.h (struct cm): Likewise.
14528 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14529 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14530 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14531 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14532 (turn_on_face, init_tty): Likewise.
14533 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14534
7f3f1250
PE
14535 * term.c (term_mouse_position): Rename local to avoid shadowing.
14536
e6ca6543
PE
14537 * alloc.c (mark_ttys): Move decl from here ...
14538 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14539
c40f8d15
AS
145402011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14541
14542 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14543
cfe0661d
JB
145442011-03-09 Juanma Barranquero <lekktu@gmail.com>
14545
14546 * search.c (compile_pattern_1): Remove argument regp, unused since
14547 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14548 (compile_pattern): Don't pass it.
14549
0afb4571
J
145502011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14551
14552 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14553 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14554 for ! HAVE_GTK3.
14555 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14556
14557 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14558
14559 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14560 gdk_window_get_screen, gdk_window_get_geometry,
14561 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14562 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14563 (xg_get_pixbuf_from_pixmap): New function.
14564 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14565 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14566 Call xg_get_pixbuf_from_pixmap instead of
14567 gdk_pixbuf_get_from_drawable.
14568 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14569 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14570 (xg_check_special_colors): Use GtkStyleContext and its functions
14571 for HAVE_GTK3.
14572 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14573 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14574 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14575 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14576 Call gtk_widget_get_preferred_size.
0afb4571
J
14577 (xg_frame_resized): gdk_window_get_geometry only takes 5
14578 parameters.
44f230aa
SM
14579 (xg_win_to_widget, xg_event_is_for_menubar):
14580 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14581 (xg_set_widget_bg): New function.
14582 (delete_cb): New function.
895009e1 14583 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14584 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14585 (xg_set_background_color): Call xg_set_widget_bg.
14586 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14587 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14588 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14589 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14590 if ! HAVE_GTK3.
14591 (update_frame_tool_bar): Call gtk_widget_hide.
14592 (xg_initialize): Use GDK_KEY_g.
14593
14594 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14595 if ! HAVE_GTK3
14596 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14597
14598 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14599 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14600 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14601
1c2cc4ef
JB
146022011-03-08 Juanma Barranquero <lekktu@gmail.com>
14603
14604 * w32xfns.c (select_palette): Check success of RealizePalette against
14605 GDI_ERROR, not zero.
14606
33383987 14607See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14608
14609;; Local Variables:
14610;; coding: utf-8
aac0c6e3
MR
14611;; End:
14612
2f097256 14613 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14614
14615 This file is part of GNU Emacs.
14616
14617 GNU Emacs is free software: you can redistribute it and/or modify
14618 it under the terms of the GNU General Public License as published by
14619 the Free Software Foundation, either version 3 of the License, or
14620 (at your option) any later version.
14621
14622 GNU Emacs is distributed in the hope that it will be useful,
14623 but WITHOUT ANY WARRANTY; without even the implied warranty of
14624 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14625 GNU General Public License for more details.
14626
14627 You should have received a copy of the GNU General Public License
14628 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.