Update from gnulib.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bff87ef0
PE
12011-04-07 Paul Eggert <eggert@cs.ucla.edu>
2
70476b54
PE
3 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4
ea6c7ae6
PE
5 Remove the doprnt implementation, as Emacs now uses vsnprintf.
6 * doprnt.c: Remove.
7 * lisp.h (doprnt): Remove.
8 * Makefile.in (base_obj): Remove doprnt.o.
9 * deps.mk (doprnt.o): Remove.
10
5fdb398c
PE
11 error: Print 32- and 64-bit integers portably (Bug#8435).
12 Without this change, on typical 64-bit hosts error ("...%d...", N)
13 was used to print both 32- and 64-bit integers N, which relied on
14 undefined behavior.
15 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
16 New macro.
17 * lisp.h (error, verror): Mark as printf-like functions.
18 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
19 Report overflow in size calculations when allocating printf buffer.
20 Do not truncate output string at its first null byte.
21 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
22 Truncate the output at a character boundary, since vsnprintf does not
23 do that.
24 * charset.c (check_iso_charset_parameter): Convert internal
25 character to string before calling 'error', since %c now has the
26 printf meaning.
27 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
28 overflow when computing char to be passed to 'error'. Do not
29 pass Lisp_Object to 'error'; pass the integer instead.
30 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
31 formatted with plain %d.
32
b189fa66
PE
33 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
34
bff87ef0
PE
35 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
36
79c49ad2
PE
372011-04-06 Paul Eggert <eggert@cs.ucla.edu>
38
7e2cac20
PE
39 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
40
ce4d90b5
PE
41 * xterm.c (x_catch_errors): Remove duplicate declaration.
42
266c9547
PE
43 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
44
79c49ad2
PE
45 * xdisp.c, lisp.h (message_nolog): Remove; unused.
46
973f782d
EZ
472011-04-06 Eli Zaretskii <eliz@gnu.org>
48
7c106b1e
EZ
49 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
50
973f782d
EZ
51 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
52
41cf7d1a 532011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 54
ca23cc88
PE
55 Fix more problems found by GCC 4.6.0's static checks.
56
f390e2d5
PE
57 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
58
42eea0d0
PE
59 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
60
b69769da 61 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 62
f9541e84
PE
63 * xdisp.c (vmessage): Mark as a printf-like function.
64
13841b55
PE
65 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
66
c136c10f
PE
67 * sound.c (sound_warning): Don't crash if arg contains a printf format.
68
5e2d4a30
PE
69 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
70 printf-like functions.
71 (tiff_load): Add casts to remove these marks before passing them
72 to system-supplied API.
73
583f48b9
PE
74 * eval.c (Fsignal): Remove excess argument to 'fatal'.
75
b25d760e
PE
76 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
77 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
78 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
79 directly, rather than having caller test rule sign. This avoids
80 some unnecessary tests.
81 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
82 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
83 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 84
bc7b6697 85 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 86 (xfont_open): Avoid unnecessary tests.
bc7b6697 87
27ccc379
PE
88 * composite.c (composition_gstring_put_cache): Use unsigned integer.
89
dcd5c89a
PE
90 * composite.h, composite.c (composition_gstring_put_cache):
91 Use EMACS_INT, not int, for length.
92
b13a45c6
PE
93 * composite.h (COMPOSITION_DECODE_REFS): New macro,
94 breaking out part of COMPOSITION_DECODE_RULE.
95 (COMPOSITION_DECODE_RULE): Use it.
96 * composite.c (get_composition_id): Remove unused local vars,
97 by using the new macro.
98
1e792e4d
PE
99 * textprop.c (set_text_properties_1): Change while to do-while,
100 since the condition is always true at first.
101
dc6c6455 102 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
103 (interval_deletion_adjustment): Return unsigned value.
104 All uses changed.
dc6c6455 105
aba7731a
PE
106 * process.c (list_processes_1, create_pty, read_process_output):
107 (exec_sentinel): Remove vars that were set but not used.
afd4052b 108 (create_pty): Remove unnecessary "volatile"s.
bc57d757 109 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 110 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 111 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 112
fdfc4bf3
PE
113 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
114
fca8fe46 115 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 116 (update_syntax_table): Use unsigned instead of int.
fca8fe46 117
06a0259a 118 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 119 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 120 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 121
e7b9e80f
PE
122 * print.c (print_error_message): Avoid int overflow.
123
56201685
PE
124 * font.c (font_list_entities): Redo for clarity,
125 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
126
78834453 127 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 128 (font_score): Avoid potential overflow in diff calculation.
78834453 129
0bc0b309 130 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 131 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 132
e610eaca
PE
133 * eval.c (funcall_lambda): Rename local to avoid shadowing.
134
b895abce
PE
135 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
136 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
137 can always succeed if overflow has undefined behavior.
138
1f1d9321 139 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 140 (wordify): Omit three unnecessary tests.
1f1d9321 141
c59478bc
PE
142 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
143 All callers changed. This avoids the need for an unused var.
144
79b73827
PE
145 * casefiddle.c (casify_region): Remove var that is set but not used.
146
a4db5dfe
PE
147 * dired.c (file_name_completion): Remove var that is set but not used.
148
43aae36e
PE
149 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
150
2a47c44d 151 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 152 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 153
a37c69bf
PE
154 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
155 Check for integer overflow on size calculations.
156
328ab8e7
PE
157 * buffer.c (Fprevious_overlay_change): Remove var that is set
158 but not used.
159
e5a2a5cb
PE
160 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
161 Remove vars that are set but not used.
8d84a6eb 162 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 163 (timer_check_2): Mark vars as initialized.
e5a2a5cb 164
a60e5f68
PE
165 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
166
f661cb61 167 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 168 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 169
f0397f5a
PE
170 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
171 that are set but not used.
172
8664db06 173 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 174 if XCreateBitmapFromData fails (Bug#8410).
8664db06 175
6abdaa4a
PE
176 * xselect.c (x_get_local_selection, x_handle_property_notify):
177 Remove vars that are set but not used.
178
0ce7538d 179 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 180 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 181
9ae848fc
PE
182 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
183 Remove var that is set but not used.
0b918413
PE
184 (scroll_bar_windows_size): Now size_t, not int.
185 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
186 Check for overflow.
9ae848fc 187
a5a62657
PE
188 * xfaces.c (realize_named_face): Remove vars that are set but not used.
189 (map_tty_color) [!defined MSDOS]: Likewise.
190
5c5cdd39
PE
191 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
192
66ebf983
PE
193 * coding.c: Remove vars that are set but not used.
194 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
195 All callers changed.
196 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
197 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
198 (decode_coding_charset): Remove vars that are set but not used.
199
1be4d761
PE
200 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
201 that is set but not used.
202
47553fa8
PE
203 * print.c (print_object): Remove var that is set but not used.
204
1f7196bf 205 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
206 The gnulib version avoids calling malloc in the usual case,
207 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
208 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
209 * filelock.c (current_lock_owner): Likewise.
210 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
211 * sysdep.c: Include allocator.h, careadlinkat.h.
212 (emacs_no_realloc_allocator): New static constant.
213 (emacs_readlink): New function.
fdb61804
PE
214 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
215 ../lib/careadlinkat.h.
d1fdcab7 216
f84c17c7
SM
2172011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
218
219 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
220 first non-nil return value).
221
ef3862ad
JD
2222011-04-03 Jan Djärv <jan.h.d@swipnet.se>
223
224 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
225 if not defined (Bug#8403).
226
376a7006
JB
2272011-04-02 Juanma Barranquero <lekktu@gmail.com>
228
229 * xdisp.c (display_count_lines): Remove parameter `start',
230 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
231 (get_char_face_and_encoding): Remove parameter `multibyte_p',
232 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
233 (fill_stretch_glyph_string): Remove parameters `row' and `area',
234 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
235 and thereabouts. All callers changed.
236 (get_per_char_metric): Remove parameter `f', unused since
237 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
238
6ca3801d
JM
2392011-04-02 Jim Meyering <meyering@redhat.com>
240
241 do not dereference NULL upon failed strdup
242 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
243 (ns_get_family): Likewise.
244
d8e2b5ba
JB
2452011-04-02 Juanma Barranquero <lekktu@gmail.com>
246
247 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
248
8c74fcbd
JD
2492011-04-02 Jan Djärv <jan.h.d@swipnet.se>
250
251 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
252 later (Bug#8403).
253
7200d79c
SM
2542011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
255
03408648 256 Add lexical binding.
7200d79c 257
03408648
SM
258 * window.c (Ftemp_output_buffer_show): New fun.
259 (Fsave_window_excursion):
260 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
261
262 * lread.c (lisp_file_lexically_bound_p): New function.
263 (Fload): Bind Qlexical_binding.
264 (readevalloop): Remove `evalfun' arg.
265 Bind Qinternal_interpreter_environment.
266 (Feval_buffer): Bind Qlexical_binding.
267 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
268 Mark as dynamic.
269 (syms_of_lread): Declare `lexical-binding'.
270
271 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
272
273 * keyboard.c (eval_dyn): New fun.
274 (menu_item_eval_property): Use it.
ca105506
SM
275
276 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 277
03408648
SM
278 * fns.c (concat, mapcar1): Accept byte-code-functions.
279
280 * eval.c (Fsetq): Handle lexical vars.
281 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
282 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
283 (FletX, Flet): Obey lexical binding.
284 (Fcommandp): Handle closures.
285 (Feval): New `lexical' arg.
286 (eval_sub): New function extracted from Feval. Use it almost
287 everywhere where Feval was used. Look up vars in lexical env.
288 Handle closures.
289 (Ffunctionp): Move from subr.el.
290 (Ffuncall): Handle closures.
291 (apply_lambda): Remove `eval_flags'.
292 (funcall_lambda): Handle closures and new byte-code-functions.
293 (Fspecial_variable_p): New function.
294 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
295 but without exporting it to Lisp.
23aba0ea 296
23aba0ea 297 * doc.c (Fdocumentation, store_function_docstring):
03408648 298 * data.c (Finteractive_form): Handle closures.
23aba0ea 299
03408648
SM
300 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
301 interactive spec.
ba83908c 302
03408648
SM
303 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
304 byte-codes.
305 (exec_byte_code): New function extracted from Fbyte_code to handle new
306 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 307
03408648 308 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 309
03408648 310 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 311
e2abce01
JB
3122011-03-31 Juanma Barranquero <lekktu@gmail.com>
313
314 * xdisp.c (redisplay_internal): Fix prototype.
315
63696a73 3162011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 317
63696a73
EZ
318 * xdisp.c (SCROLL_LIMIT): New macro.
319 (try_scrolling): Use it when setting scroll_limit. Limit
320 scrolling to 100 screen lines.
321 (redisplay_window): Even when falling back on "recentering",
322 position point in the window according to scroll-conservatively,
323 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
324
325 (try_scrolling): When point is above the window, allow searching
326 as far as scroll_max, or one screenful, to compute vertical
327 distance from PT to the scroll margin position. This prevents
328 try_scrolling from unnecessarily failing when
329 scroll-conservatively is set to a value slightly larger than the
330 window height. Clean up the case of PT below the margin at bottom
331 of window: scroll_max can no longer be INT_MAX. When aggressive
332 scrolling is in use, don't let point enter the opposite scroll
333 margin as result of the scroll.
334 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
335 threshold of 100 lines for never-recentering scrolling.
336
e4cc2dfc
JB
3372011-03-31 Juanma Barranquero <lekktu@gmail.com>
338
339 * dispextern.h (move_it_by_lines):
340 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
341 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
342 (message_log_check_duplicate): Remove parameters `prev_bol' and
343 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
344 (redisplay_internal): Remove parameter `preserve_echo_area',
345 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
346
347 * indent.c (Fvertical_motion):
348 * window.c (window_scroll_pixel_based, Frecenter):
349 Don't pass `need_y_p' to `move_it_by_lines'.
350
1c470562
SM
3512011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
352
44f230aa
SM
353 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
354 steal a few bits to be more compact.
355 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
356 Remove unneeded casts.
357
1c470562
SM
358 * bytecode.c (Fbyte_code): CAR and CDR can GC.
359
888adce9
ZK
3602011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
361
362 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
363 binding" message (bug#7967).
364
f838ed7b
PE
3652011-03-30 Paul Eggert <eggert@cs.ucla.edu>
366
77861b95
PE
367 Fix more problems found by GCC 4.6.0's static checks.
368
de6dbc14
PE
369 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
370 Remove unused local var.
371
f838ed7b
PE
372 * editfns.c (Fmessage_box): Remove unused local var.
373
792c7b2b
PE
374 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
375 (note_mode_line_or_margin_highlight, note_mouse_highlight):
376 Omit unused local vars.
c499e557 377 * window.c (shrink_windows): Omit unused local var.
b01a1c29 378 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
379 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
380 Omit unused local var.
381
ba0165e1
PE
382 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
383 Don't assume string length fits in int.
32ad8845 384 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 385 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 386
3c59b4c9
PE
387 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
388 instead of alloca (Bug#8344).
389
a3eed478 390 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 391 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 392
eb4d412d
PE
393 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
394
1658b401
PE
395 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
396 concerns.
397
398 * term.c (produce_glyphless_glyph): Remove unnecessary test.
399
400 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 401
9a2c6e05
PE
402 * keyboard.c (syms_of_keyboard): Use the same style as later
403 in this function when indexing through an array. This also
404 works around GCC bug 48267.
405
03d0a109
PE
406 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
407
44f730c8
PE
408 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
409
fe75f926
PE
410 * chartab.c (sub_char_table_ref_and_range): Redo for slight
411 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
412
ffa8c828
PE
413 * keyboard.c, keyboard.h (num_input_events): Now size_t.
414 This avoids undefined behavior on integer overflow, and is a bit
415 more convenient anyway since it is compared to a size_t variable.
416
c5101a77
PE
417 Variadic C functions now count arguments with size_t, not int.
418 This avoids an unnecessary limitation on 64-bit machines, which
419 caused (substring ...) to crash on large vectors (Bug#8344).
420 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
421 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 422 All variadic functions and their callers changed accordingly.
c5101a77
PE
423 (struct gcpro.nvars): Now size_t, not int. All uses changed.
424 * data.c (arith_driver, float_arith_driver): Likewise.
425 * editfns.c (general_insert_function): Likewise.
426 * eval.c (struct backtrace.nargs, interactive_p)
427 (internal_condition_case_n, run_hook_with_args, apply_lambda)
428 (funcall_lambda, mark_backtrace): Likewise.
429 * fns.c (concat): Likewise.
430 * frame.c (x_set_frame_parameters): Likewise.
431 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
432 0 if not found, not -1. All callers changed.
433
dd3f25f7
PE
434 * alloc.c (garbage_collect): Don't assume stack size fits in int.
435 (stack_copy_size): Now size_t, not int.
436 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
437
461c2ab9
JB
4382011-03-28 Juanma Barranquero <lekktu@gmail.com>
439
440 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
441 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
442 All callers changed.
443
444 * lisp.h (multibyte_char_to_unibyte):
445 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
446 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
447 * character.h (CHAR_TO_BYTE8):
448 * cmds.c (internal_self_insert):
449 * editfns.c (general_insert_function):
450 * keymap.c (push_key_description):
451 * search.c (Freplace_match):
452 * xdisp.c (message_dolog, set_message_1): All callers changed.
453
f6d62986
SM
4542011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
455
456 * keyboard.c (safe_run_hook_funcall): New function.
457 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
458 don't set the hook to nil, but remove the offending function instead.
459 (Qcommand_hook_internal): Remove, unused.
460 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
461 Vcommand_hook_internal.
462
463 * eval.c (enum run_hooks_condition): Remove.
464 (funcall_nil, funcall_not): New functions.
465 (run_hook_with_args): Call each function through a `funcall' argument.
466 Remove `cond' argument, now redundant.
467 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
468 (Frun_hook_with_args_until_failure): Adjust accordingly.
469 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
470
1db5b1ad
JB
4712011-03-28 Juanma Barranquero <lekktu@gmail.com>
472
473 * dispextern.h (string_buffer_position): Remove declaration.
474
475 * print.c (strout): Remove parameter `multibyte', unused since
476 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
477
478 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
479 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
480 All callers changed.
481
482 * w32.c (_wsa_errlist): Use braces for struct initializers.
483
484 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
485 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
486 All callers changed.
487 (string_buffer_position): Likewise. Also, make static (it's never
488 used outside xdisp.c).
489 (cursor_row_p): Remove parameter `w', unused since
490 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
491 (decode_mode_spec): Remove parameter `precision', introduced during
492 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
493 All callers changed.
494
5ffb62aa
JD
4952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
496
497 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
498
461c2ab9 4992011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
500
501 * nsterm.m (ns_menu_bar_is_hidden): New variable.
502 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
503 (ns_update_auto_hide_menu_bar): New functions.
504 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
505 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
506 ns_constrain_all_frames.
507 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
508 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
509
5c380ffb
JD
5102011-03-27 Jan Djärv <jan.h.d@swipnet.se>
511
512 * nsmenu.m (runDialogAt): Remove argument to timer_check.
513
9af30bdf
GM
5142011-03-27 Glenn Morris <rgm@gnu.org>
515
516 * syssignal.h: Replace RETSIGTYPE with void.
517 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
518 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
519 Replace SIGTYPE with void everywhere.
520 * s/usg5-4-common.h (SIGTYPE): Remove definition.
521 * s/template.h (SIGTYPE): Remove commented out definition.
522
e2abce01
JB
5232011-03-26 Eli Zaretskii <eliz@gnu.org>
524
525 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
526 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
527
f868cd8a
JB
5282011-03-26 Juanma Barranquero <lekktu@gmail.com>
529
59eb0929
JB
530 * w32.c (read_unc_volume): Use parameter `henum', instead of
531 global variable `wget_enum_handle'.
532
533 * keymap.c (describe_vector): Remove parameters `indices' and
534 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
535 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
536
f868cd8a
JB
537 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
538
539 * keyboard.c (timer_check): Remove parameter `do_it_now',
540 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
541 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
542 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
543
544 * keyboard.c (read_char):
545 * w32menu.c (w32_menu_display_help):
546 * xmenu.c (show_help_event, menu_help_callback):
547 Adjust calls to `show_help_echo'.
548
549 * gtkutil.c (xg_maybe_add_timer):
550 * keyboard.c (readable_events):
551 * process.c (wait_reading_process_output):
552 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
553
554 * insdel.c (adjust_markers_gap_motion):
555 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
556 (gap_left, gap_right): Don't call it.
557
2ecf6fdb
CY
5582011-03-25 Chong Yidong <cyd@stupidchicken.com>
559
560 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
561 incurred during fontification.
562
6b1f9ba4
JB
5632011-03-25 Juanma Barranquero <lekktu@gmail.com>
564
565 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
566 (DEFVAR_PER_BUFFER): Don't pass it.
567
568 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
569 (scrolling_window): Don't pass it.
570
0f4a96b5
JB
5712011-03-25 Juanma Barranquero <lekktu@gmail.com>
572
573 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
574
575 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
576 and `suffix'.
577 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
578 of variables specific to SELinux and computation of `encoded_absname'.
579
580 * image.c (XPutPixel): Remove unused variable `height'.
581
582 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
583
584 * unexw32.c (get_section_info): Remove unused variable `section'.
585
586 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
587 (system_process_attributes): Remove unused variable `sess'.
588 (sys_read): Remove unused variable `err'.
589
590 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
591 (w32_wnd_proc): Remove unused variable `isdead'.
592 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
593 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
594 (x_create_tip_frame): Remove unused variable `tem'.
595
596 * w32inevt.c (w32_console_read_socket):
597 Remove unused variable `no_events'.
598
599 * w32term.c (x_draw_composite_glyph_string_foreground):
600 Remove unused variable `width'.
601
1149507c
JB
6022011-03-24 Juanma Barranquero <lekktu@gmail.com>
603
604 * w32term.c (x_set_glyph_string_clipping):
605 Don't pass uninitialized region to CombineRgn.
606
9c88f339
JB
6072011-03-23 Juanma Barranquero <lekktu@gmail.com>
608
609 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
610 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
611 (Fx_close_connection): Remove unused variable `i'.
612
613 * w32font.c (w32font_draw): Return number of glyphs.
614 (w32font_open_internal): Remove unused variable `i'.
615 (w32font_driver): Add missing initializer.
616
617 * w32menu.c (utf8to16): Remove unused variable `utf16'.
618 (fill_in_menu): Remove unused variable `items_added'.
619
620 * w32term.c (last_mouse_press_frame): Remove static global variable.
621 (w32_clip_to_row): Remove unused variable `f'.
622 (x_delete_terminal): Remove unused variable `i'.
623
624 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
625 (NOTHING): Remove unused static global variable.
626 (uniscribe_check_otf): Remove unused variable `table'.
627 (uniscribe_font_driver): Add missing initializers.
628
dee091a3
JD
6292011-03-23 Julien Danjou <julien@danjou.info>
630
631 * term.c (Fsuspend_tty, Fresume_tty):
632 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
633 * window.c (temp_output_buffer_show):
634 * insdel.c (signal_before_change):
635 * frame.c (Fhandle_switch_frame):
636 * fileio.c (Fdo_auto_save):
637 * emacs.c (Fkill_emacs):
638 * editfns.c (save_excursion_restore):
639 * cmds.c (internal_self_insert):
640 * callint.c (Fcall_interactively):
641 * buffer.c (Fkill_all_local_variables):
642 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
643 Use Frun_hooks.
0f4a96b5 644 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
645 unconditionnaly since it does the check itself.
646
2c520ab5 6472011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 648
c9c49752
PE
649 Fix more problems found by GCC 4.5.2's static checks.
650
8abc3f12
PE
651 * coding.c (encode_coding_raw_text): Avoid unnecessary test
652 the first time through the loop, since we know p0 < p1 then.
653 This also avoids a gcc -Wstrict-overflow warning.
654
a2d26660
PE
655 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
656 leading to a memory leak, possible in functions like
657 load_charset_map_from_file that can allocate an unbounded number
b12ef411 658 of objects (Bug#8318).
a2d26660 659
916c72e9
PE
660 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
661 that could (at least in theory) be that large.
662
19ab8a18
PE
663 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
664 This is less likely to overflow, and avoids undefined behavior if
665 overflow does occur. All callers changed. Use strtoul to scan
666 for the unsigned long integer.
b7cbbd6f
PE
667 (pint2hrstr): Simplify and tune code slightly.
668 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 669
f0641eff
PE
670 * scroll.c (do_scrolling): Work around GCC bug 48228.
671 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
672
7f650bb9
PE
673 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
674 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
675 (validate_x_resource_name): Simplify count usage.
676 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 677
37dd57d1
PE
678 * fileio.c (Fcopy_file): Report error if fchown or fchmod
679 fail (Bug#8306).
81e56e61 680
699979fc 681 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 682
401bf9b4
PE
683 * process.c (Fmake_network_process): Use socklen_t, not int,
684 where POSIX says socklen_t is required in portable programs.
685 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 686 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
687 (Fmake_network_process, server_accept_connection):
688 (wait_reading_process_output, read_process_output):
689 Likewise.
690
b93aacde
PE
691 * process.c: Rename or move locals to avoid shadowing.
692 (list_processes_1, Fmake_network_process):
693 (read_process_output_error_handler, exec_sentinel_error_handler):
694 Rename or move locals.
4dc343ee 695 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 696 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 697 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 698 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 699 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 700
af8a867c 701 Make tparam.h and terminfo.c consistent.
44f230aa
SM
702 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
703 Include tparam.h instead, since it declares them.
af8a867c
PE
704 * cm.h (PC): Remove extern decl; tparam.h now does this.
705 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
706 * terminfo.c: Include tparam.h, to check interfaces.
707 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
708 (tparam): Adjust signature to match interface in tparam.h;
709 this removes some undefined behavior. Check that outstring and len
710 are zero, which they always are with Emacs.
711 * tparam.h (PC, BC, UP): New extern decls.
712
0248044d 713 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 714 (xftfont_open): Rename locals to avoid shadowing.
0248044d 715
8ff096c1 716 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
717 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
718 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 719 (ftfont_list): Remove unused local.
49eaafba
PE
720 (get_adstyle_property, ftfont_pattern_entity):
721 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
722 Rename locals to avoid shadowing.
8ff096c1 723
e2be39f6
PE
724 * xfont.c (xfont_list_family): Mark var as initialized.
725
c9735e30
PE
726 * xml.c (make_dom): Now static.
727
8f5201ae
PE
728 * composite.c (composition_compute_stop_pos): Rename local to
729 avoid shadowing.
b246f932
PE
730 (composition_reseat_it): Remove unused locals.
731 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 732 (composition_update_it): Mark var as initialized.
11b61122
PE
733 (find_automatic_composition): Mark vars as initialized,
734 with a FIXME (Bug#8290).
8f5201ae 735
760fbc2c
PE
736 character.h: Rename locals to avoid shadowing.
737 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
738 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
739 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
740 (BUF_DEC_POS): Be more systematic about renaming local temporaries
741 to avoid shadowing.
742
ff08eb85
PE
743 * textprop.c (property_change_between_p): Remove; unused.
744
fc7bf025
PE
745 * intervals.c (interval_start_pos): Now static.
746
235d7abc
PE
747 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
748
44f230aa
SM
749 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
750 Rename locals to avoid shadowing.
3e7d6594 751
50060332
PE
752 * sound.c (wav_play, au_play, Fplay_sound_internal):
753 Fix pointer signedness.
d01f234b 754 (alsa_choose_format): Remove unused local var.
c83b8872
PE
755 (wav_play): Initialize a variable to 0, to prevent undefined
756 behavior (Bug#8278).
50060332 757
c4fc4e30
PE
758 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
759
918436ed
PE
760 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
761
c939f91b
PE
762 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
763 clobbering (Bug#8298).
b9c7f648
PE
764 * sysdep.c (sys_subshell): Likewise.
765 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 766
6bd8c144
PE
767 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
768 This should get cleaned up, so that child_setup has the
769 same signature on all platforms.
770
7710357c 771 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 772 (relocate_fd): Rename locals to avoid shadowing.
7710357c 773
c59da222
CY
7742011-03-22 Chong Yidong <cyd@stupidchicken.com>
775
776 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
777 not to be necessary, and produces flickering.
778
66b87493
GM
7792011-03-20 Glenn Morris <rgm@gnu.org>
780
781 * config.in: Remove file.
782
45b6f6d5
JB
7832011-03-20 Juanma Barranquero <lekktu@gmail.com>
784
785 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
786 are now in src/globals.h.
787 (syms_of_minibuf): Remove spurious & from previous change.
788
3ec03f7e
LL
7892011-03-20 Leo <sdl.web@gmail.com>
790
791 * minibuf.c (completing-read-function): New variable.
792 (completing-read-default): Rename from completing-read.
793 (completing-read): Call completing-read-function.
794
b14e3e21
CY
7952011-03-19 Juanma Barranquero <lekktu@gmail.com>
796
797 * xfaces.c (Fx_load_color_file):
798 Read color file from absolute filename (bug#8250).
799
f2b726e6
JB
8002011-03-19 Juanma Barranquero <lekktu@gmail.com>
801
802 * makefile.w32-in: Update dependencies.
803
09f6ff02
EZ
8042011-03-17 Eli Zaretskii <eliz@gnu.org>
805
806 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
807
29a6015a
PE
8082011-03-17 Paul Eggert <eggert@cs.ucla.edu>
809
a3a6c54e
PE
810 Fix more problems found by GCC 4.5.2's static checks.
811
b766f867
PE
812 * process.c (make_serial_process_unwind, send_process_trap):
813 (sigchld_handler): Now static.
814
be02381c
PE
815 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
816 That way, the code declares only the vars that it needs.
817 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
818 * s/cygwin.h (PTY_ITERATION): Likewise.
819 * s/darwin.h (PTY_ITERATION): Likewise.
820 * s/gnu-linux.h (PTY_ITERATION): Likewise.
821
57048744
PE
822 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
823 * process.c (allocate_pty): Don't declare stb unless it's needed.
824
7914961c 825 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
826 (CONSTANTLIM): Remove; unused.
827 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
828 Define only if needed.
7914961c 829
b3967b18
PE
830 * unexelf.c (unexec): Name an expression,
831 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
832 Use a different way to cause a compilation error if anyone uses
833 n rather than nn, a way that does not involve shadowing.
73366a00 834 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 835
29a6015a
PE
836 * deps.mk (unexalpha.o): Remove; unused.
837
43cfc33e 838 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 839 * unexec.h: New file.
ce701a33
PE
840 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
841 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
842 Depend on unexec.h.
843 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
844 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
845 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 846 Change as necessary to match prototype in unexec.h.
ce701a33 847
01f44d5a
PE
848 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
849 shadowing.
4f63c6bb 850 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 851
a6670b0b
PE
852 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
853 Rename locals to avoid shadowing.
854
cef2010d 855 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 856 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 857
d4d7173a
PE
858 * print.c (Fredirect_debugging_output): Fix pointer signedess.
859
f08b802a
PE
860 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
861 warning when compiling print.c.
862
3ddb0639
PE
863 * font.c (font_unparse_fcname): Abort in an "impossible" situation
864 instead of using an uninitialized var.
5ad03b97 865 (font_sort_entities): Mark var as initialized.
3ddb0639 866
170a2692
PE
867 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
868
e663c700
PE
869 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
870 pointers to constants.
89bc529a 871 (font_parse_fcname): Remove unused vars.
7b81e2d0 872 (font_delete_unmatched): Now static.
ea838e10 873 (font_get_spec): Remove; unused.
13a547c6
PE
874 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
875 (font_update_drivers, Ffont_get_glyphs, font_add_log):
876 Rename or move locals to avoid shadowing.
e663c700 877
2a80c887 878 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 879 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 880
1384fa33 881 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 882 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 883
8b2c52e9
PE
884 * alloc.c (mark_backtrace): Move decl from here ...
885 * lisp.h: ... to here, so that it can be checked.
886
475545b5 887 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 888 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
889 (lisp_indirect_variable): Name an expression,
890 to avoid gcc -Wbad-function-cast warning.
1faed8ae 891 (Fdefvar): Rename locals to avoid shadowing.
475545b5 892
b1349114 893 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 894 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 895 Use const pointer when appropriate.
b1349114 896
a2928364
PE
897 * lisp.h (get_system_name, get_operating_system_release):
898 Move decls here, to check interfaces.
899 * process.c (get_operating_system_release): Move decl to lisp.h.
900 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
901 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
902 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
903 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
904 (Fformat_time_string, Fencode_time, Finsert_char):
905 (Ftranslate_region_internal, Fformat):
906 Rename or remove local vars to avoid shadowing.
9710023e 907 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 908
a415e694
PE
909 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
910 avoid shadowing.
911
8ef4622d
PE
912 * lisp.h (eassert): Check that the argument compiles, even if
913 ENABLE_CHECKING is not defined.
914
946f9a5b
PE
915 * data.c (Findirect_variable): Name an expression, to avoid
916 gcc -Wbad-function-cast warning.
112396d6 917 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 918 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
919 (Fmake_variable_buffer_local, Fmake_local_variable):
920 Mark variables as initialized.
52746918 921 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 922
e5aab7e7 923 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
924 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
925 Rename locals to avoid shadowing.
dff45157
PE
926 (mark_stack): Move local variables into the #ifdef region where
927 they're used.
7bc26fdb
PE
928 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
929 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
930 needed otherwise.
931 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
932 (GC_STRING_CHARS): Remove; not used.
d40d4be1 933 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 934
e5aab7e7
PE
935 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
936 avoids undefined behavior in theory.
937
4da60324
PE
938 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
939
88043301
PE
940 Use functions, not macros, for up- and down-casing (Bug#8254).
941 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
942 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
943 to use the following functions instead of these macros.
944 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
945 EMACS_INT, since callers assume the returned value fits in int.
946 (upcase1): Likewise, for UPCASE_TABLE.
947 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 948 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 949 the race-condition problem in the old DOWNCASE.
88043301 950
19ed5445
PE
951 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
952 Rename locals to avoid shadowing.
953 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
954 (regex_compile, re_search_2, re_match_2_internal):
955 Remove unused local vars.
952db0d7
PE
956 (FREE_VAR): Rewrite so as not to use empty "else",
957 which gcc can warn about.
da053e48 958 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
959 (RETALLOC_IF): Define only if needed.
960 (WORDCHAR_P): Likewise. This one is never needed, but is used
961 only in a comment talking about a compiler bug, so put inside
962 the #if 0 of that comment.
963 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
964 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
965 Remove; unused.
19ed5445 966
1f3561e4 967 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
968 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
969 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 970
ded6f8f7
PE
971 * search.c (simple_search): Remove unused var.
972
dbd37a95
PE
973 * dired.c (compile_pattern): Move decl from here ...
974 * lisp.h: ... to here, so that it can be checked.
975 (struct re_registers): New forward decl.
976
7e47afad
PE
977 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
978
85f24f61
PE
979 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
980 All uses changed.
981 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
982 Rename locals to avoid shadowing.
5671df8f 983 (Fvertical_motion): Mark locals as initialized.
85f24f61 984
181aa2be 985 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 986 (casify_region): Mark local as initialized.
181aa2be 987
930d429c
PE
988 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
989
7082eac6
PE
990 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
991 New macros, so that the caller can use some names other than
992 gcpro1, gcpro2, etc.
993 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
994 of the new macros.
995 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
996 argument, for consistency with GCPRO2_VAR, etc: it is now the
997 prefix of the variable, not the variable itself. All uses
998 changed.
38b2c076
PE
999 * dired.c (directory_files_internal, file_name_completion):
1000 Rename locals to avoid shadowing.
1001
15206ed9
PE
1002 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1003 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1004 dired.c's scmp function, had undefined behavior.
1005 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1006 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1007 * buffer.h: ... to here, because these macros use current_buffer,
1008 and the new implementation with inline functions needs to have
1009 current_buffer in scope now, rather than later when the macros
1010 are used.
1011 (downcase, upcase1): New static inline functions.
1012 (DOWNCASE, UPCASE1): Reimplement using these functions.
1013 This avoids undefined behavior in expressions like
1014 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1015 from race conditions in accessing the global variables
1016 case_temp1 and case_temp2.
1017 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1018 * lisp.h (case_temp1, case_temp2): Remove their decls.
1019 * character.h (ASCII_CHAR_P): Move from here ...
1020 * lisp.h: ... to here, so that the inline functions mentioned
1021 above can use them.
1022
4a6bea26
PE
1023 * dired.c (directory_files_internal_unwind): Now static.
1024
f14b7e14
PE
1025 * fileio.c (file_name_as_directory, directory_file_name):
1026 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1027 Now static.
2893f146
PE
1028 (file_name_as_directory): Use const pointers when appropriate.
1029 (Fexpand_file_name): Likewise. In particular, newdir might
1030 point at constant storage, so make it a const pointer.
fd4ead52 1031 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1032 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1033 signedness issues.
f839df0c
PE
1034 (Fset_file_times, Finsert_file_contents, auto_save_error):
1035 Rename locals to avoid shadowing.
f14b7e14 1036
5716756e 1037 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1038 (Ftry_completion, Fall_completions): Rename or remove locals
1039 to avoid shadowing.
5716756e 1040
b4c3046a
PE
1041 * marker.c (bytepos_to_charpos): Remove; unused.
1042
b45db522
PE
1043 * lisp.h (verify_bytepos, count_markers): New decls,
1044 so that gcc does not warn that these functions aren't declared.
1045
85876d07
PE
1046 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1047 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1048 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1049 (copy_text): Remove unused local var.
85876d07 1050
03d78a21 1051 * filelock.c (within_one_second): Now static.
b3dd38ab 1052 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1053
5df8f01b
PE
1054 * buffer.c (fix_overlays_before): Mark locals as initialized.
1055 (fix_start_end_in_overlays): Likewise. This function should be
1056 simplified by using pointers-to-pointers, but that's a different
1057 matter.
b1d876f1 1058 (switch_to_buffer_1): Now static.
8f54f30a
PE
1059 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1060 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1061
a70072c9 1062 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1063 Fix pointer signedness issue.
edced198
PE
1064 (sys_subshell): Mark local as volatile if checking for lint,
1065 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1066 (MAXPATHLEN): Define only if needed.
a70072c9 1067
a0977c44
PE
1068 * process.c (serial_open, serial_configure): Move decls from here ...
1069 * systty.h: ... to here, so that they can be checked.
1070
a884fdcc
PE
1071 * fns.c (get_random, seed_random): Move extern decls from here ...
1072 * lisp.h: ... to here, so that they can be checked.
1073
604efe86 1074 * sysdep.c (reset_io): Now static.
b8950c94 1075 (wait_for_termination_signal): Remove; unused.
604efe86 1076
38fc62d9
PE
1077 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1078 (copy_keymap_item, append_key, push_text_char_description):
1079 Now static.
1004a21a 1080 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1081 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1082 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1083 (describe_map_tree):
1084 Rename locals to avoid shadowing.
38fc62d9 1085
2f2650da
PE
1086 * keyboard.c: Declare functions static if they are not used elsewhere.
1087 (echo_char, echo_dash, cmd_error, top_level_2):
1088 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1089 (read_char, kbd_buffer_get_event, make_lispy_position):
1090 (make_lispy_event, make_lispy_movement, apply_modifiers):
1091 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1092 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1093 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1094 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1095 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1096
a053e86c 1097 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1098 (mark_kboards): Move decl here ...
1099 * alloc.c (mark_kboards): ... from here.
a053e86c 1100
4752793e
PE
1101 * lisp.h (force_auto_save_soon): New decl.
1102
74f10ca7 1103 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1104 (DEFINE_DUMMY_FUNCTION): New macro.
1105 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1106 Use it.
c03cd23f
PE
1107 (main): Add casts to avoid warnings
1108 if GCC considers string literals to be constants.
74f10ca7 1109
022e70d4
PE
1110 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1111
59d6fe83
PE
1112 * dbusbind.c: Pointer signedness fixes.
1113 (xd_signature, xd_append_arg, xd_initialize):
1114 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1115 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1116 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1117 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1118
78320123
PE
1119 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1120 if GCC considers string literals to be constants.
49cebcca 1121 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1122
35ac2a97
SM
11232011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1124
fb103ca9
SM
1125 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1126 (print_preprocess, print_object): New macro to fix last change.
1127
35ac2a97
SM
1128 * print.c (print_preprocess): Don't forget font objects.
1129
62973b41
JB
11302011-03-16 Juanma Barranquero <lekktu@gmail.com>
1131
1132 * emacs.c (USAGE3): Doc fixes.
1133
0e48bb22
AS
11342011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1135
1136 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1137 structure.
1138
7684e57b
JB
11392011-03-14 Juanma Barranquero <lekktu@gmail.com>
1140
1141 * lisp.h (VWindow_system, Qfile_name_history):
1142 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1143 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1144 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1145
1146 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1147 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1148
1149 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1150 * w32console.c (detect_input_pending, read_input_pending)
1151 (encode_terminal_code):
1152 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1153 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1154 (w32_system_caret_y, Qfile_name_history):
1155 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1156 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1157 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1158 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1159 * w32proc.c (Qlocal, report_file_error):
1160 * w32term.c (Vwindow_system, updating_frame):
1161 * w32uniscribe.c (initialized, uniscribe_font_driver):
1162 Remove unneeded extern declarations.
1163
2aa46d6c
CY
11642011-03-14 Chong Yidong <cyd@stupidchicken.com>
1165
c96bbc66 1166 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1167
cffc6f3b
CY
11682011-03-13 Chong Yidong <cyd@stupidchicken.com>
1169
1170 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1171 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1172 These macros can no longer be used for assignment.
1173
44f230aa
SM
1174 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1175 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1176 (record_buffer_markers, fetch_buffer_markers): New functions for
1177 recording and fetching special buffer markers.
1178 (set_buffer_internal_1, set_buffer_temp): Use them.
1179
1180 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1181
1182 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1183
1184 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1185 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1186
1187 * xdisp.c (hscroll_window_tree):
1188 (reconsider_clip_changes): Use PT instead of BUF_PT.
1189
d251f04b
EZ
11902011-03-13 Eli Zaretskii <eliz@gnu.org>
1191
1192 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1193 $(EMACS_ROOT)/lib/intprops.h.
1194
f0c77cd1
PE
11952011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1196
3eca4629
PE
1197 Fix more problems found by GCC 4.5.2's static checks.
1198
7c86ee98
PE
1199 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1200 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1201 (xg_free_frame_widgets): Make it clear that a local variable is
1202 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1203 (gdk_window_get_screen): Make it clear that this macro is needed
1204 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1205 (int_gtk_range_get_value): New function, which avoids a diagnostic
1206 from gcc -Wbad-function-cast.
1207 (xg_set_toolkit_scroll_bar_thumb): Use it.
1208 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1209 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1210 (get_utf8_string, xg_get_file_with_chooser):
1211 Rename locals to avoid shadowing.
1212 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1213
41729b81
PE
1214 * xgselect.c (xg_select): Remove unused var.
1215
f0c77cd1
PE
1216 * image.c (four_corners_best): Mark locals as initialized.
1217 (gif_load): Initialize transparent_p to zero (Bug#8238).
1218 Mark another local as initialized.
ec6cf4c6 1219 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1220
ce0ad53d 1221 * image.c (clear_image_cache): Now static.
d5d5a617 1222 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1223 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1224 (x_edge_detection): Remove unnecessary cast that
1225 gcc -Wbad-function-cast diagnoses.
2037898d 1226 (gif_load): Fix pointer signedness.
6ae141d6
PE
1227 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1228 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1229
33383987 12302011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1231
d32df629
PE
1232 Improve quality of tests for time stamp overflow.
1233 For example, without this patch (encode-time 0 0 0 1 1
1234 1152921504606846976) returns the obviously-bogus value (-948597
1235 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1236 reports time overflow. See
1237 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1238 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1239 * editfns.c: Include limits.h and intprops.h.
1240 (TIME_T_MIN, TIME_T_MAX): New macros.
1241 (time_overflow): Move earlier, to before first use.
1242 (hi_time, lo_time): New functions, for an accurate test for
1243 out-of-range times.
1244 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1245 (Fget_internal_run_time): Don't assume time_t fits in int.
1246 (make_time): Use list2 instead of Fcons twice.
1247 (Fdecode_time): More accurate test for out-of-range times.
1248 (check_tm_member): New function.
1249 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1250 (lisp_time_argument): Don't rely on undefined left-shift and
1251 right-shift behavior when checking for time stamp overflow.
8be6f318 1252
fe31d94c
PE
1253 * editfns.c (time_overflow): New function, refactoring common code.
1254 (Fformat_time_string, Fdecode_time, Fencode_time):
1255 (Fcurrent_time_string): Use it.
1256
8be6f318
PE
1257 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1258 * dired.c (make_time): Move to ...
1259 * editfns.c (make_time): ... here.
1260 * systime.h: Note the move.
1261
09d9db2c 12622011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1263
126bc0dc
YM
1264 * fringe.c (update_window_fringes): Remove unused variables.
1265
c47cbdfd
YM
1266 * unexmacosx.c (copy_data_segment): Also copy __got section.
1267 (Bug#8223)
1268
7ac80be9
EZ
12692011-03-12 Eli Zaretskii <eliz@gnu.org>
1270
c96bbc66 1271 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1272 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1273 Constify `char *' arguments and their references according to
1274 prototypes in tparam.h.
1275
ecb0f94d 1276 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1277
7ac80be9
EZ
1278 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1279 Adapt all references accordingly.
1280
1281 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1282
ef1fd07e
TT
12832011-03-11 Tom Tromey <tromey@redhat.com>
1284
1285 * buffer.c (syms_of_buffer): Remove obsolete comment.
1286
7ef4b50c
EZ
12872011-03-11 Eli Zaretskii <eliz@gnu.org>
1288
1289 * termhooks.h (encode_terminal_code): Declare prototype.
1290
1291 * msdos.c (encode_terminal_code): Don't declare prototype.
1292
1293 * term.c (encode_terminal_code): Now external again, used by
1294 w32console.c and msdos.c.
1295
44f230aa
SM
1296 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1297 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1298
4b1ec863 12992011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1300
1714f52b 1301 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1302
4b1ec863
PE
1303 * fringe.c (update_window_fringes): Mark locals as initialized
1304 (Bug#8227).
1305 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1306
524c7aa6
PE
1307 * alloc.c (mark_fringe_data): Move decl from here ...
1308 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1309 to check its interface.
1310 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1311
a5c0af81 1312 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1313 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1314 (fontset_font): Mark local as initialized.
a9a06e0b 1315 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1316
b4716021
PE
1317 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1318
811e9bac 1319 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1320 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1321 (x_own_selection, Fx_disown_selection_internal): Rename locals
1322 to avoid shadowing.
1323 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1324
7e3ab302
PE
1325 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1326 so that the caller can use some name other than gcpro1.
1327 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1328 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1329 (Fx_backspace_delete_keys_p):
1330 Use them to avoid shadowing, and rename vars to avoid shadowing.
1331 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1332 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1333 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1334 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1335 Remove unused locals.
7e3ab302
PE
1336 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1337 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1338 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1339 macros.
f78faa98 1340
e2b13473
PE
1341 * xterm.h (x_mouse_leave): New decl.
1342
77f23912
PE
1343 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1344 Remove unused functions.
cdf4ba58
PE
1345 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1346 (x_calc_absolute_position): Now static.
7411c686 1347 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1348 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1349 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1350 unless they are used.
38d0b34a
PE
1351 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1352 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1353 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1354 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1355 (x_error_catcher, x_connection_closed, x_error_handler):
1356 (x_error_quitter, xembed_send_message, x_iconify_frame):
1357 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1358 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1359 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1360
44f230aa
SM
1361 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1362 Rename or move locals to avoid shadowing.
6b463e58 1363 (tty_defined_color, merge_face_heights): Now static.
5967d051 1364 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1365 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1366 does not deduce is never used uninitialized.
73719eba
PE
1367 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1368 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1369
426994c3 1370 * terminal.c (store_terminal_param): Now static.
5489860b 1371
032f1620 1372 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1373 (set_frame_menubar): Remove unused local.
d4323972 1374 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1375 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1376 since they might point to immutable storage.
281585b0
PE
1377 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1378 since it's unused otherwise.
032f1620 1379
367c19e5 1380 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1381 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1382 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1383 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1384 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1385 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1386 does not deduce are never used uninitialized.
70739cbe 1387
07b48fa9
PE
1388 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1389
8868a238 1390 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1391 * window.c (window_loop, size_window):
1392 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1393
7e5cf297 1394 * window.c (display_buffer): Now static.
d6550a9f
PE
1395 (size_window): Mark variables that gcc -Wuninitialized
1396 does not deduce are never used uninitialized.
a586633d
PE
1397 * window.h (check_all_windows): New decl, to forestall
1398 gcc -Wmissing-prototypes diagnostic.
5b555da1 1399 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1400
f6095868
PE
1401 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1402 shadowing.
1403 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1404 Include <limits.h>.
1405 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1406 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1407 (load_charset_map): Mark variables that gcc -Wuninitialized
1408 does not deduce are never used uninitialized.
53df7c11 1409 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1410
f38b440c
PE
1411 * coding.c (coding_set_source, coding_set_destination):
1412 Use "else { /* comment */ }" rather than "else /* comment */;"
1413 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1414 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1415 a block, when the outer 'i' will do.
1416 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1417 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1418 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1419 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1420 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1421 Rename locals to avoid shadowing.
1422 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1423 * coding.c (emacs_mule_char, encode_invocation_designation):
1424 Now static, since they're not used elsewhere.
413bb2db 1425 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1426 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1427 (decode_coding_emacs_mule): Mark variables that gcc
1428 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1429 (detect_coding_iso_2022): Initialize a local variable that might
1430 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1431 this initialization is needed. (Bug#8211)
5f58e762
PE
1432 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1433 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1434 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1435 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1436 Remove unused macros.
f38b440c 1437
232b38b9 1438 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1439 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1440 * character.c (string_count_byte8): Likewise.
232b38b9 1441
fb90da1b
PE
1442 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1443 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1444
fb93dbc2
PE
1445 * chartab.c (copy_sub_char_table): Now static, since it's not used
1446 elsewhere.
5c156ace
PE
1447 (sub_char_table_ref_and_range, char_table_ref_and_range):
1448 Rename locals to avoid shadowing.
bbcd0949 1449 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1450
7d3b3862 1451 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1452 (BIDI_BOB): Remove unused macro.
7d3b3862 1453
6be7d3da
PE
1454 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1455 deduce are never used uninitialized.
c2ed9c8b 1456 * term.c (encode_terminal_code): Likewise.
6be7d3da 1457
75f8807f 1458 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1459
50938595
PE
1460 * tparam.h: New file.
1461 * term.c, tparam.h: Include it.
1462 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1463 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1464 Move these decls to tparam.h, and make them agree with what
1465 is actually in tparam.c. The previous trick of using incompatible
1466 decls in different modules does not conform to the C standard.
1467 All callers of tparam changed to use tparam's actual API.
1468 * tparam.c (tparam1, tparam, tgoto):
1469 Use const pointers where appropriate.
1470
fbceeba2
PE
1471 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1472 * cm.h (struct cm): Likewise.
1473 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1474 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1475 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1476 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1477 (turn_on_face, init_tty): Likewise.
1478 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1479
7f3f1250
PE
1480 * term.c (term_mouse_position): Rename local to avoid shadowing.
1481
e6ca6543
PE
1482 * alloc.c (mark_ttys): Move decl from here ...
1483 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1484
c40f8d15
AS
14852011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1486
1487 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1488
cfe0661d
JB
14892011-03-09 Juanma Barranquero <lekktu@gmail.com>
1490
1491 * search.c (compile_pattern_1): Remove argument regp, unused since
1492 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1493 (compile_pattern): Don't pass it.
1494
0afb4571
J
14952011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1496
1497 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1498 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1499 for ! HAVE_GTK3.
1500 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1501
1502 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1503
1504 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1505 gdk_window_get_screen, gdk_window_get_geometry,
1506 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1507 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1508 (xg_get_pixbuf_from_pixmap): New function.
1509 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1510 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1511 Call xg_get_pixbuf_from_pixmap instead of
1512 gdk_pixbuf_get_from_drawable.
1513 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1514 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1515 (xg_check_special_colors): Use GtkStyleContext and its functions
1516 for HAVE_GTK3.
1517 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1518 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1519 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1520 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1521 Call gtk_widget_get_preferred_size.
0afb4571
J
1522 (xg_frame_resized): gdk_window_get_geometry only takes 5
1523 parameters.
44f230aa
SM
1524 (xg_win_to_widget, xg_event_is_for_menubar):
1525 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1526 (xg_set_widget_bg): New function.
1527 (delete_cb): New function.
1528 (xg_create_frame_widgets): connect delete-event to delete_cb.
1529 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1530 (xg_set_background_color): Call xg_set_widget_bg.
1531 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1532 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1533 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1534 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1535 if ! HAVE_GTK3.
1536 (update_frame_tool_bar): Call gtk_widget_hide.
1537 (xg_initialize): Use GDK_KEY_g.
1538
1539 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1540 if ! HAVE_GTK3
1541 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1542
1543 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1544 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1545 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1546
1c2cc4ef
JB
15472011-03-08 Juanma Barranquero <lekktu@gmail.com>
1548
1549 * w32xfns.c (select_palette): Check success of RealizePalette against
1550 GDI_ERROR, not zero.
1551
33383987 1552See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1553
1554;; Local Variables:
1555;; coding: utf-8
aac0c6e3
MR
1556;; End:
1557
33383987 1558 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1559
1560 This file is part of GNU Emacs.
1561
1562 GNU Emacs is free software: you can redistribute it and/or modify
1563 it under the terms of the GNU General Public License as published by
1564 the Free Software Foundation, either version 3 of the License, or
1565 (at your option) any later version.
1566
1567 GNU Emacs is distributed in the hope that it will be useful,
1568 but WITHOUT ANY WARRANTY; without even the implied warranty of
1569 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1570 GNU General Public License for more details.
1571
1572 You should have received a copy of the GNU General Public License
1573 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.