* gtkutil.c: Integer overflow fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bc18e09d
PE
12011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2
0eb0f318
PE
3 * gtkutil.c: Integer overflow fixes.
4 (get_utf8_string, xg_store_widget_in_map):
5 Check for size-calculation overflow.
6 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7 do, as we prefer signed integers.
8 (id_to_widget.max_size, id_to_widget.used)
9 (xg_store_widget_in_map, xg_remove_widget_from_map)
10 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
12 Use and return ptrdiff_t, not int.
13 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
14 * gtkutil.h: Change prototypes to match the above.
15
1ffd9c92
PE
16 * ftfont.c: Check for size overflow.
17 (ftfont_get_open_type_spec, setup_otf_gstring, ftfont_shape_by_flt):
18 Check for integer overflow in size calculations.
19
483a9e21
PE
20 * fringe.c (Fdefine_fringe_bitmap): Don't update size until alloc works.
21
2f645268
PE
22 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
23 This is for the members text_lines, text_cols, total_lines, total_cols,
24 where the system imposes an 'int' limit.
25
b8898fda
PE
26 * frame.c: Integer overflow fixes.
27 (set_menu_bar_lines, x_set_frame_parameters, x_set_scroll_bar_width)
28 (x_figure_window_size): Check for integer overflow.
29 (x_set_alpha): Do not assume XINT fits in int.
30
98e8eae1
PE
31 * eval.c: Integer and memory overflow fixes.
32 (init_eval_once, grow_specpdl): Don't update size until alloc succeeds.
33 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
34
b4fb6314
PE
35 * emacs.c (main, sort_args): Check for size-calculation overflow.
36
c9f8d652
PE
37 * editfns.c: Integer and memory overflow fixes.
38 (set_time_zone_rule): Don't assume environment length fits in int.
39 (message_length): Now ptrdiff_t, not int.
40 (Fmessage_box): Don't update size until allocation succeeds.
41 Don't assume message length fits in int.
42 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
43
3d0c92a2
PE
44 * doc.c: Integer and memory overflow fixes.
45 (get_doc_string_buffer_size): Now ptrdiff_t, not int.
46 (get_doc_string): Check for size calculation overflow.
47 Don't update size until allocation succeeds.
48 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
49 EMACS_INT, where ptrdiff_t will do.
50 (Fsubstitute_command_keys): Check for string overflow.
51
ca9ce8f2
PE
52 Integer and memory overflow fixes for display code.
53 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
54 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool, scrolling_window):
55 Check for overflow in size calculations.
56 (line_draw_cost, realloc_glyph_pool, add_row_entry):
57 Don't assume glyph table len fits in int.
58 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
59 (row_table_size): Now ptrdiff_t, not int.
60 (scrolling_window): Avoid overflow in size calculations.
61 Don't update size until allocation succeeds.
62 * fns.c (concat): Check for overflow in size calculations.
63 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
64 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
65 (NEXT_ALMOST_PRIME_LIMIT): New constant.
66
d86d0d74
PE
67 * composite.c: Integer overflow fixes.
68 (get_composition_id): Check for overflow in glyph length calculations.
69
5d009b3a
PE
70 * coding.c: Integer and memory overflow fixes.
71 (produce_chars): Redo buffer-overflow calculations to avoid
72 unnecessary integer overflow. Check for size overflow.
73 (encode_coding_object): Don't update size until xmalloc succeeds.
74
17828df2
PE
75 * character.c (Fstring): Check for size-calculation overflow.
76
69e8622f
PE
77 * ccl.c: Integer and memory overflow fixes.
78 (Fccl_execute_on_string): Check for memory overflow.
79 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
80 Redo buffer-overflow calculations to avoid integer overflow.
81
860887db
PE
82 * callproc.c (child_setup): Don't assume strlen fits in int.
83
6e1fc452
PE
84 * buffer.c: Memory overflow fixes.
85 (overlays_at, overlays_in, record_overlay_string, overlay_strings):
86 Don't update size of array until after memory allocation succeeds,
87 because xmalloc/xrealloc may not return.
88
bc18e09d
PE
89 * bidi.c: Integer overflow fix.
90 (bidi_shelve_header_size): New constant.
91 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
92 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
93
5637687f
PE
942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
95
ebfa62c0
PE
96 Use ptrdiff_t for composition IDs.
97 * character.c (lisp_string_width):
98 * composite.c (composition_table_size, n_compositions)
99 (get_composition_id, composition_gstring_from_id):
100 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
101 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
102 * window.c (Frecenter):
103 Use ptrdiff_t, not int, for composition IDs.
104 * composite.c (get_composition_id): Check for integer overflow.
105 * composite.h: Adjust prototypes to match the above changes.
106
d3411f89
PE
107 Use ptrdiff_t for hash table indexes.
108 * category.c (hash_get_category_set):
109 * ccl.c (ccl_driver):
110 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
111 * coding.c (coding_system_charset_list, detect_coding_system):
112 * coding.h (struct coding_system.id):
113 * composite.c (get_composition_id, gstring_lookup_cache):
114 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
115 * image.c (xpm_get_color_table_h):
116 * lisp.h (hash_lookup, hash_put):
117 * minibuf.c (Ftest_completion):
118 Use ptrdiff_t for hash table indexes, not int (which is too
119 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
120 32-bit --with-wide-int hosts).
121
e097a6fa
PE
122 * charset.c (Fdefine_charset_internal): Check for integer overflow.
123 Add a FIXME comment about memory leaks.
124 (syms_of_charset): Don't assume xmalloc returns.
125
5637687f
PE
126 Don't assume that stated character widths fit in int.
127 * character.c (Fchar_width, c_string_width, lisp_string_width):
128 * character.h (CHAR_WIDTH):
129 * indent.c (MULTIBYTE_BYTES_WIDTH):
130 Use sanitize_char_width to avoid undefined and/or bad behavior
131 with outlandish widths.
132 * character.h (sanitize_tab_width): Renamed from sanitize_width,
133 now that we have two such functions. All uses changed.
134 (sanitize_char_width): New inline function.
135
a2271ba2
PE
136 Don't assume that tab-width fits in int.
137 * character.h (sanitize_width): New inline function.
138 (SANE_TAB_WIDTH): New macro.
139 (ASCII_CHAR_WIDTH): Use it.
140 * indent.c (sane_tab_width): Remove. All uses replaced by
141 SANE_TAB_WIDTH (current_buffer).
142 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
143
18c52557
PE
144 * fileio.c: Integer overflow issues with file modes.
145 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
146
caeeedc1
PE
147 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
148 Remove unreachable code.
149 (read_hex, load_charset_map_from_file): Check for integer overflow.
150
50849c52
PE
151 * xterm.c: don't go over XClientMessageEvent limit
152 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
153 (x_send_scroll_bar_event): Likewise. Check that the size does not
154 exceed limits imposed by XClientMessageEvent, as well as the usual
155 ptrdiff_t and size_t limits.
156
b13995db
PE
157 * keyboard.c: Overflow, signedness and related fixes.
158 (make_lispy_movement): Use same integer type in forward decl
159 that is used in the definition.
160 (read_key_sequence, keyremap_step):
161 Change bufsize argument back to int, undoing my 2011-03-30 change.
162 We prefer signed types, and int is wide enough here.
163 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
164 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
165 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
166 length, not size_t. Use ptrdiff_t for index, not int.
167 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
168 possibility of integer overflow.
169
13464394
PE
170 Overflow, signedness and related fixes for images.
171
172 * dispextern.h (struct it.stack[0].u.image.image_id)
173 (struct_it.image_id, struct image.id, struct image_cache.size)
174 (struct image_cache.used, struct image_cache.ref_count):
175 * gtkutil.c (update_frame_tool_bar):
176 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
177 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
178 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
179 * nsmenu.m (update_frame_tool_bar):
180 * xdisp.c (calc_pixel_width_or_height):
181 * xfns.c (image_cache_refcount):
182 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
183 on typical 64-bit hosts.
184
185 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
186 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
187 Omit unnecessary casts to int.
188 (parse_image_spec): Check that integers fall into 'int' range
189 when the callers expect that.
190 (image_ascent): Redo ascent calculation to avoid int overflow.
191 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
192 (lookup_image): Remove unnecessary tests.
193 (xbm_image_p): Locals are now of int, not EMACS_INT,
194 since parse_image_check makes sure they fit into int.
195 (png_load, gif_load, svg_load_image):
196 Prefer int to unsigned where either will do.
197 (tiff_handler): New function, combining the cores of the
198 old tiff_error_handler and tiff_warning_handler. This
199 function is rewritten to use vsnprintf and thereby avoid
200 stack buffer overflows. It uses only the features of vsnprintf
201 that are common to both POSIX and native Microsoft.
202 (tiff_error_handler, tiff_warning_handler): Use it.
203 (tiff_load, gif_load, imagemagick_load_image):
204 Don't assume :index value fits in 'int'.
205 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
206 (imagemagick_load_image): Check that crop parameters fit into
207 the integer types that MagickCropImage accepts. Don't assume
208 Vimagemagick_render_type has a nonnegative value. Don't assume
209 size_t fits in 'long'.
210 (gs_load): Use printmax_t to print the widest integers possible.
211 Check for integer overflow when computing image height and width.
212
0d8de0fd 2132011-07-19 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 214
41f55ccd 215 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 216
39e378da
PE
217 * bidi.c: Integer size and overflow fixes.
218 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
219 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
220 (bidi_cache_find_level_change, bidi_cache_ensure_space)
221 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
222 (bidi_find_other_level_edge):
223 Use ptrdiff_t instead of EMACS_INT where either will do.
224 This works better on 32-bit hosts configured --with-wide-int.
225 (bidi_cache_ensure_space): Check for size-calculation overflow.
226 Use % rather than repeated addition, for better worst-case speed.
227 Don't set bidi_cache_size until after xrealloc returns, because it
228 might not return.
229 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
230 (bidi_cache_ensure_space): Also check that the bidi cache size
231 does not exceed that of the largest Lisp string or buffer. See Eli
232 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 233
5e927815
PE
234 * alloc.c (__malloc_size_t): Remove.
235 All uses replaced by size_t. See Andreas Schwab's note
236 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
237
ca4aa935
PE
238 * image.c: Improve checking for integer overflow.
239 (check_image_size): Assume that f is nonnull, since
240 it is always nonnull in practice. This is one less thing to
241 worry about when checking for integer overflow later.
242 (x_check_image_size): New function, which checks for integer
243 overflow issues inside X.
244 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
245 This removes the need for a memory_full check.
246 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
247 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
248 (xbm_read_bitmap_data): Change locals back to 'int', since
249 their values must fit in 'int'.
250 (xpm_load_image, png_load, tiff_load):
251 Invoke x_create_x_image_and_pixmap earlier,
252 to avoid much needless work if the image is too large.
253 (tiff_load): Treat overly large images as if
254 x_create_x_image_and_pixmap failed, not as malloc failures.
255 (gs_load): Use x_check_image_size.
256
5f8f9cc2
PE
257 * gtkutil.c: Omit integer casts.
258 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
259 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
260
5adf60bc
PE
261 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
262
c8907a93
PE
263 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
264 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
265 would wrongly return t on a 64-bit host.
266
e3c25c68
PE
267 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
268 The plain *_OVERFLOW macros run afoul of GCC bug 49705
269 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
270 and therefore cause GCC to emit a bogus diagnostic in some cases.
271
3f791afe
PE
272 * image.c: Integer signedness and overflow and related fixes.
273 This is not an exhaustive set of fixes, but it's time to
274 record what I've got.
275 (lookup_pixel_color, check_image_size): Remove redundant decls.
276 (check_image_size): Don't assume that arbitrary EMACS_INT values
277 fit in 'int', or that arbitrary 'double' values fit in 'int'.
278 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
279 (tiff_load, imagemagick_load_image):
280 Check for overflow in size calculations.
281 (x_create_x_image_and_pixmap): Remove unnecessary test for
282 xmalloc returning NULL; that can't happen.
283 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
284 (xpm_color_bucket): Use better integer hashing function.
285 (xpm_cache_color): Don't possibly over-allocate memory.
286 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
287 (gif_memory_source):
288 Use ptrdiff_t, not int or size_t, to record sizes.
289 (png_load): Don't assume values greater than 2**31 fit in 'int'.
290 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
291 either works, as we prefer signed integers.
292 (tiff_read_from_memory, tiff_write_from_memory):
293 Return tsize_t, not size_t, since that's what the TIFF API wants.
294 (tiff_read_from_memory): Don't fail simply because the read would
295 go past EOF; instead, return a short read.
296 (tiff_load): Omit no-longer-needed casts.
297 (Fimagemagick_types): Don't assume size fits into 'int'.
298
3cc5a532
PE
299 Improve hashing quality when configured --with-wide-int.
300 * fns.c (hash_string): New function, taken from sxhash_string.
301 Do not discard information about ASCII character case; this
302 discarding is no longer needed.
303 (sxhash-string): Use it. Change sig to match it. Caller changed.
304 * lisp.h: Declare it.
305 * lread.c (hash_string): Remove, since we now use fns.c's version.
306 The fns.c version returns a wider integer if --with-wide-int is
307 specified, so this should help the quality of the hashing a bit.
308
b312a492
PE
309 * emacs.c: Integer overflow minor fix.
310 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
311 Define only if GNU_LINUX.
312 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
313
dfd153ae
PE
314 * dispnew.c: Integer signedness and overflow fixes.
315 Remove unnecessary forward decls, that were a maintenance hassle.
316 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
317 All uses changed.
318 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
319 (scrolling_window): Use ptrdiff_t, not int, for byte count.
320 (prepare_desired_row, line_draw_cost):
321 Use int, not unsigned, where either works.
322 (save_current_matrix, restore_current_matrix):
323 Use ptrdiff_t, not size_t, where either works.
324 (init_display): Check for overflow more accurately, and without
325 relying on undefined behavior.
326
a81d11a3
PE
327 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
328 Remove, replacing with the new symbols in lisp.h. All uses changed.
329 * fileio.c (make_temp_name):
330 * filelock.c (lock_file_1, lock_file):
331 * xdisp.c (message_dolog):
332 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
333 Use pMd etc. instead.
334 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
335 replacing the pWIDE etc. symbols removed from editfns.c.
336
3300e6fd
PE
337 * keyboard.h (num_input_events): Now uintmax_t.
338 This is (very slightly) less likely to mess up due to wraparound.
339 All uses changed.
340
fd05c7e9
PE
341 * buffer.c: Integer signedness fixes.
342 (alloc_buffer_text, enlarge_buffer_text):
343 Use ptrdiff_t rather than size_t when either will do, as we prefer
344 signed integers.
345
903fe15d
PE
346 * alloc.c: Integer signedness and overflow fixes.
347 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
348 (__malloc_size_t): Default to size_t, not to int.
349 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
350 (Fgarbage_collect, mark_object_loop_halt, mark_object):
351 Prefer ptrdiff_t to size_t when either would do, as we prefer
352 signed integers.
353 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
354 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
355 Now const. Initialize with values that are in range even if char
356 is signed.
357 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
358 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
359 These functions do the right thing with sizes > 2**32.
360 (check_depth): Now ptrdiff_t, not int.
361 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
362 Adjust to new way of storing sizes. Check for size overflow bugs
363 in rest of code.
364 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
365 slightly wrong anyway, as it missed one instance of
366 XMALLOC_OVERRUN_CHECK_OVERHEAD.
367 (refill_memory_reserve): Omit needless cast to size_t.
368 (mark_object_loop_halt): Mark as externally visible.
369
ac82cc6a
PE
370 * xselect.c: Integer signedness and overflow fixes.
371 (Fx_register_dnd_atom, x_handle_dnd_message):
372 Use ptrdiff_t, not size_t, since we prefer signed.
373 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
374 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
375 x_dnd_atoms_size and x_dnd_atoms_length.
376
c2d1e36d
PE
377 * doprnt.c: Prefer signed to unsigned when either works.
378 * eval.c (verror):
379 * doprnt.c (doprnt):
380 * lisp.h (doprnt):
381 * xdisp.c (vmessage):
382 Use ptrdiff_t, not size_t, when using or implementing doprnt,
383 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
384 prefer signed arithmetic to avoid comparison confusion.
385 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
386 but is a bit tricky.
387
0e926e56
PE
388 Assume freestanding C89 headers, string.h, stdlib.h.
389 * data.c, doprnt.c, floatfns.c, print.c:
390 Include float.h unconditionally.
391 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
392 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
393 * regex.c: Likewise for stddef.h, string.h.
394 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
395 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
396 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
397 (STDC_HEADERS): Remove obsolete defines.
398 * sysdep.c: Include limits.h unconditionally.
399
9cfdb3ec
PE
400 Assume support for memcmp, memcpy, memmove, memset.
401 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
402 * regex.c (memcmp, memcpy):
403 Remove; we assume C89 now.
404
405 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
406 (__malloc_safe_bcopy): Remove; no longer needed.
407
cf950e6b 408 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
409 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
410 well either way, and we prefer signed to unsigned.
411
590bd467
PE
4122011-07-19 Paul Eggert <eggert@cs.ucla.edu>
413
414 Port to OpenBSD.
415 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
416 and the surrounding thread.
417 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
418 rather than fgets, and retry after EINTR. Otherwise, 'emacs
419 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
420 timer goes off.
421 * s/openbsd.h (BROKEN_SIGIO): Define.
422 * unexelf.c (unexec) [__OpenBSD__]:
423 Don't update the .mdebug section of the Alpha COFF symbol table.
424
f41628b2
LMI
4252011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
426
427 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
428 (bug#8460).
429
b59b67c5
PE
4302011-07-18 Paul Eggert <eggert@cs.ucla.edu>
431
15e3a074
PE
432 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
433 This fixes some race conditions on the permissions of any newly
434 created file.
435
41bed37d
PE
436 * alloc.c (valid_pointer_p): Use pipe, not open.
437 This fixes some permissions issues when debugging.
438
b59b67c5
PE
439 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
440 If fchown fails to set both uid and gid, try to set just gid,
441 as that is sometimes allowed. Adjust the file's mode to eliminate
442 setuid or setgid bits that are inappropriate if fchown fails.
443
925a6be7
SM
4442011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
445
446 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
447 to compare Lisp_Objects.
448 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
449 global_gnutls_log_level, don't mistake it for a Lisp_Object.
450 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
451
52968808
AS
4522011-07-17 Andreas Schwab <schwab@linux-m68k.org>
453
0a6a104b
AS
454 * lread.c (read_integer): Unread even EOF character.
455 (read1): Likewise. Properly record start position of symbol.
456
52968808
AS
457 * lread.c (read1): Read `#:' as empty uninterned symbol if no
458 symbol character follows.
459
9e381cdd
PE
4602011-07-17 Paul Eggert <eggert@cs.ucla.edu>
461
462 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
463 This works around a problem with the previous change to Fcopy_file.
464 Recent glibc declares fchown with __attribute__((warn_unused_result)),
465 and without this change, GCC might complain about discarding
466 fchown's return value.
467
b5641435
JB
4682011-07-16 Juanma Barranquero <lekktu@gmail.com>
469
470 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
471
a8031457
PE
4722011-07-16 Paul Eggert <eggert@cs.ucla.edu>
473
474 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
475
dd889327
LMI
4762011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
477
750c33f7
LMI
478 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
479 it's used from the C level.
480
dd889327
LMI
481 * process.c: Use the same condition for POLL_FOR_INPUT in both
482 keyboard.c and process.c (bug#1858).
483
87e86684
LM
4842011-07-09 Lawrence Mitchell <wence@gmx.li>
485
486 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
487 (Fgnutls_boot): Use it.
488
64348f40
AS
4892011-07-15 Andreas Schwab <schwab@linux-m68k.org>
490
491 * doc.c (Fsubstitute_command_keys): Revert last change.
492
1d698799
LMI
4932011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
494
f863868c
LMI
495 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
496 quotes the next character, and doesn't affect other longer
497 sequences (bug#8935).
498
1d698799
LMI
499 * lread.c (syms_of_lread): Clarify that is isn't only
500 `eval-buffer' and `eval-defun' that's affected by
501 `lexical-binding' (bug#8460).
502
aa4b6df6
EZ
5032011-07-15 Eli Zaretskii <eliz@gnu.org>
504
505 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
506 bidi redisplay when a line includes both an image and is
507 truncated.
508
5d856da6
PE
5092011-07-14 Paul Eggert <eggert@cs.ucla.edu>
510
ad6042bb
PE
511 Fix minor problems found by static checking.
512 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
513 (elsz): Now a signed constant, not a size_t var. We prefer signed
514 types to unsigned, to avoid integer comparison confusion. Without
515 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
516 "cannot optimize loop, the loop counter may overflow", a symptom
517 of the confusion.
f00bbb22 518 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
519 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
520
6468f31c
LMI
5212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
522
49080b10
LMI
523 * search.c (Fre_search_backward): Mention `case-fold-search' in
524 all the re_search_* functions (bug#8138).
525
6468f31c
LMI
526 * keyboard.c (Fopen_dribble_file): Document when the file is
527 closed (bug#8056).
528
c965adc5
EZ
5292011-07-14 Eli Zaretskii <eliz@gnu.org>
530
df9733bf
EZ
531 * bidi.c (bidi_dump_cached_states): Fix format of displaying
532 bidi_cache_idx.
533
0bb23927
EZ
534 Support bidi reordering of display and overlay strings.
535 * xdisp.c (compute_display_string_pos)
536 (compute_display_string_end): Accept additional argument STRING.
537 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
538 (reseat_to_string): Initialize bidi_it->string.s and
539 bidi_it->string.schars.
540 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
541 NULL (avoids a crash in bidi_paragraph_init). Initialize
542 itb.string.lstring.
543 (init_iterator): Call bidi_init_it only of a valid
544 buffer position was specified. Initialize paragraph_embedding to
545 L2R.
546 (reseat_to_string): Initialize the bidi iterator.
547 (display_string): If we need to ignore text properties of
548 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
549 original value of -1 will not work with bidi.)
550 (compute_display_string_pos): First arg is now struct
551 `text_pos *'; all callers changed. Support display properties on
552 Lisp strings.
553 (compute_display_string_end): Support display properties on Lisp
554 strings.
555 (init_iterator, reseat_1, reseat_to_string): Initialize the
556 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
557 when iterating on a string not from display properties).
558 (compute_display_string_pos, compute_display_string_end): Fix
559 calculation of the object to scan. Fixes an error when using
560 arrow keys.
561 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
562 base_level_stop; instead, set base_level_stop to BEGV. Fixes
563 crashes in vertical-motion.
564 (next_element_from_buffer): Improve commentary for when
565 the iterator is before prev_stop.
566 (init_iterator): Initialize bidi_p from the default value of
567 bidi-display-reordering, not from buffer-local value. Use the
568 buffer-local value only if initializing for buffer iteration.
569 (handle_invisible_prop): Support invisible properties on strings
570 that are being bidi-reordered.
571 (set_iterator_to_next): Support bidi reordering of C strings and
572 Lisp strings.
573 (next_element_from_string): Support bidi reordering of Lisp
574 strings.
575 (handle_stop_backwards): Support Lisp strings as well.
576 (display_string): Support display of R2L glyph rows. Use
577 IT_STRING_CHARPOS when displaying from a Lisp string.
578 (init_iterator): Don't initialize it->bidi_p for strings
579 here.
580 (reseat_to_string): Initialize it->bidi_p for strings here.
581 (next_element_from_string, next_element_from_c_string)
582 (next_element_from_buffer): Add xassert's for correspondence
583 between IT's object being iterated and it->bidi_it.string
584 structure.
585 (face_before_or_after_it_pos): Support bidi iteration.
586 (next_element_from_c_string): Handle the case of the first string
587 character that is not the first one in the visual order.
588 (get_visually_first_element): New function, refactored from common
589 parts of next_element_from_buffer, next_element_from_string, and
590 next_element_from_c_string.
591 (tool_bar_lines_needed, redisplay_tool_bar)
592 (display_menu_bar): Force left-to-right direction. Add a FIXME
593 comment for making that be controlled by a user option.
594 (push_it, pop_it): Save and restore the state of the
595 bidi iterator. Save and restore the bidi_p flag.
596 (pop_it): Iterate out of display property for string iteration as
597 well.
598 (iterate_out_of_display_property): Support iteration over strings.
599 (handle_single_display_spec): Set up it->bidi_it for iteration
600 over a display string, and call bidi_init_it.
601 (handle_single_display_spec, next_overlay_string)
602 (get_overlay_strings_1, push_display_prop): Set up the bidi
603 iterator for displaying display or overlay strings.
604 (forward_to_next_line_start): Don't use the shortcut if
605 bidi-iterating.
606 (back_to_previous_visible_line_start): If handle_display_prop
607 pushed the iterator stack, restore the internal state of the bidi
608 iterator by calling bidi_pop_it same number of times.
609 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
610 and we are bidi-iterating, don't decrement the iterator position;
611 instead, set the first_elt flag in the bidi iterator, to produce
612 the same effect.
613 (reseat_1): Remove redundant setting of string_from_display_prop_p.
614 (push_display_prop): xassert that we are iterating a buffer.
615 (push_it, pop_it): Save and restore paragraph_embedding member.
616 (handle_single_display_spec, next_overlay_string)
617 (get_overlay_strings_1, reseat_1, reseat_to_string)
618 (push_display_prop): Set up the `unibyte' member of bidi_it.string
619 correctly. Don't assume unibyte strings are not bidi-reordered.
620 (compute_display_string_pos)
621 (compute_display_string_end): Fix handling the case of C string.
622 (push_it, pop_it): Save and restore from_disp_prop_p.
623 (handle_single_display_spec, push_display_prop): Set the
624 from_disp_prop_p flag.
625 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
626 (pop_it): Call iterate_out_of_display_property only if we are
627 popping after iteration over a string that came from a display
628 property. Fix a typo in popping stretch info. Add an assertion
629 for verifying that the iterator position is in sync with the bidi
630 iterator.
631 (handle_single_display_spec, get_overlay_strings_1)
632 (push_display_prop): Fix initialization of paragraph direction for
633 string when that of the parent object is not yet determined.
634 (reseat_1): Call bidi_init_it to resync the bidi
635 iterator with IT's position. (Bug#7616)
636 (find_row_edges): If ROW->start.pos gives position
637 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
638 (handle_stop, back_to_previous_visible_line_start, reseat_1):
639 Reset the from_disp_prop_p flag.
640 (SAVE_IT, RESTORE_IT): New macros.
641 (pos_visible_p, face_before_or_after_it_pos)
642 (back_to_previous_visible_line_start)
643 (move_it_in_display_line_to, move_it_in_display_line)
644 (move_it_to, move_it_vertically_backward, move_it_by_lines)
645 (try_scrolling, redisplay_window, display_line): Use them when
646 saving a temporary copy of the iterator and restoring it back.
647 (back_to_previous_visible_line_start, reseat_1)
648 (init_iterator): Empty the bidi cache "stack".
649 (move_it_in_display_line_to): If iterator ended up at
650 EOL, but we never saw any buffer positions smaller than
651 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
652 motion in bidi-reordered lines.
653 (move_it_in_display_line_to): Record prev_method and prev_pos
654 immediately before the call to set_iterator_to_next. Fixes cursor
655 motion in bidi-reordered lines with stretch glyphs and strings
656 displayed in margins. (Bug#8133) (Bug#8867)
657 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
658 TO_CHARPOS.
659 (pos_visible_p): Support positions in bidi-reordered lines. Save
660 and restore bidi cache.
661
662 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
663 (bidi_paragraph_info): Delete unused struct.
664 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
665 (bidi_cache_start): New variable.
666 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
667 to zero.
668 (bidi_cache_fetch_state, bidi_cache_search)
669 (bidi_cache_find_level_change, bidi_cache_iterator_state)
670 (bidi_cache_find, bidi_peek_at_next_level)
671 (bidi_level_of_next_char, bidi_find_other_level_edge)
672 (bidi_move_to_visually_next): Compare cache index with
673 bidi_cache_start rather than with zero.
674 (bidi_fetch_char): Accept new argument STRING; all callers
675 changed. Support iteration over a string. Support strings with
676 display properties. Support unibyte strings. Fix the type of
677 `len' according to what STRING_CHAR_AND_LENGTH expects.
678 (bidi_paragraph_init, bidi_resolve_explicit_1)
679 (bidi_resolve_explicit, bidi_resolve_weak)
680 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
681 iteration over a string.
682 (bidi_set_sor_type, bidi_resolve_explicit_1)
683 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
684 can now be zero (for strings); special values 0 and -1 were
685 changed to -1 and -2, respectively.
686 (bidi_char_at_pos): New function.
687 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
688 Call it instead of FETCH_MULTIBYTE_CHAR.
689 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
690 initialized to valid values.
691 (bidi_init_it): Don't initialize charpos and bytepos with invalid
692 values.
693 (bidi_level_of_next_char): Allow the sentinel "position" to pass
694 the test for valid cached positions. Fix the logic for looking up
695 the sentinel state in the cache. GCPRO the Lisp string we are
696 iterating.
697 (bidi_push_it, bidi_pop_it): New functions.
698 (bidi_initialize): Initialize the bidi cache start stack pointer.
699 (bidi_cache_ensure_space): New function, refactored from part of
700 bidi_cache_iterator_state. Don't assume the required size is just
701 one BIDI_CACHE_CHUNK away.
702 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
703 (bidi_count_bytes, bidi_char_at_pos): New functions.
704 (bidi_cache_search): Don't assume bidi_cache_last_idx is
705 always valid if bidi_cache_idx is valid.
706 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
707 is valid if it's going to be used.
708 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
709 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
710 (bidi_cache_find_level_change, bidi_cache_ensure_space)
711 (bidi_cache_iterator_state, bidi_cache_find)
712 (bidi_find_other_level_edge, bidi_cache_start_stack): All
713 variables related to cache indices are now EMACS_INT.
714
0bb23927
EZ
715 * dispextern.h (struct bidi_string_data): New structure.
716 (struct bidi_it): New member `string'. Make flag members be 1-bit
717 fields, and put them last in the struct.
718 (compute_display_string_pos, compute_display_string_end): Update
719 prototypes.
720 (bidi_push_it, bidi_pop_it): Add prototypes.
721 (struct iterator_stack_entry): New members bidi_p,
722 paragraph_embedding, and from_disp_prop_p.
723 (struct it): Member bidi_p is now a bit field 1 bit wide.
724 (bidi_shelve_cache, bidi_unshelve_cache): Declare
725 prototypes.
726
727 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
728 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
729 and vector-like objects.
730
731 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
732 cache around display iteration.
733
734 * window.c (Fwindow_end, window_scroll_pixel_based)
735 (displayed_window_lines, Frecenter): Save and restore the bidi
736 cache around display iteration.
737
3bbd2265
LMI
7382011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
739
740 * editfns.c (Fdelete_region): Clarify the use of the named
741 parameters (bug#6788).
742
adc47434
MR
7432011-07-14 Martin Rudalics <rudalics@gmx.at>
744
745 * indent.c (Fvertical_motion): Set and restore w->pointm when
746 saving and restoring the window's buffer (Bug#9006).
747
837c31f8
LMI
7482011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
749
750 * editfns.c (Fstring_to_char): Clarify just what is returned
751 (bug#6576). Text by Eli Zaretskii.
752
ac389d0c
JB
7532011-07-13 Juanma Barranquero <lekktu@gmail.com>
754
755 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
756
0be0ce47
EZ
7572011-07-13 Eli Zaretskii <eliz@gnu.org>
758
759 * buffer.c (mmap_find): Fix a typo.
760
cd18e7e3
JB
7612011-07-13 Johan Bockgård <bojohan@gnu.org>
762
763 Fix execution of x selection hooks.
764 * xselect.c (Qx_lost_selection_functions)
765 (Qx_sent_selection_functions): New vars.
766 (syms_of_xselect): DEFSYM them.
767 (x_handle_selection_request): Pass Qx_sent_selection_functions
768 rather than Vx_sent_selection_functions to Frun_hook_with_args.
769 (x_handle_selection_clear,x_clear_frame_selections):
770 Pass Qx_lost_selection_functions rather than
771 Vx_lost_selection_functions to Frun_hook_with_args.
772
47ea7f44
PE
7732011-07-13 Paul Eggert <eggert@cs.ucla.edu>
774
ac389d0c 775 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
776 The old code sometimes used this field without initializing it.
777
47ea7f44
PE
778 * alloc.c (gc_sweep): Don't read past end of array.
779 In theory, the old code could also have corrupted Emacs internals,
780 though it'd be very unlikely.
781
bc985c87
AS
7822011-07-12 Andreas Schwab <schwab@linux-m68k.org>
783
784 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 785 argument. (Bug#4026)
bc985c87 786
0cf34688
LMI
7872011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
788
b3dadd76
LMI
789 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
790 key" (bug#4257).
791
0cf34688
LMI
792 * window.c (Fset_window_start): Doc fix (bug#4199).
793 (Fset_window_hscroll): Ditto.
794
270768cd
PE
7952011-07-12 Paul Eggert <eggert@cs.ucla.edu>
796
077e3dda 797 Fix minor new problems caught by GCC 4.6.1.
270768cd 798 * term.c (init_tty): Remove unused local.
490011a6 799 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 800 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 801 not used otherwise.
270768cd 802
b1f58454
CY
8032011-07-12 Chong Yidong <cyd@stupidchicken.com>
804
805 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
806
22b9578d
LMI
8072011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
808
6e70ab07
LMI
809 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
810 are the mini-buffer and the echo area (bug#3320).
811
22b9578d
LMI
812 * term.c (init_tty): Remove support for supdup, c10 and perq
813 terminals, which are no longer supported (bug#1482).
814
8974cc9f
JB
8152011-07-10 Johan Bockgård <bojohan@gnu.org>
816
817 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
818
a560d974
JD
8192011-07-10 Jan Djärv <jan.h.d@swipnet.se>
820
821 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
822 for non-popups (Bug#3642).
823
1dae0f0a
AS
8242011-07-10 Andreas Schwab <schwab@linux-m68k.org>
825
268c2c36 826 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 827 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
828 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
829 * cm.c (losecursor): Likewise.
1dae0f0a
AS
830 * data.c (fmod): Likewise.
831 * dispnew.c (swap_glyphs_in_rows): Likewise.
832 * emacs.c (memory_warning_signal): Likewise.
833 * floatfns.c (float_error): Likewise.
834 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
835 (otf_open, font_otf_capability, generate_otf_features)
836 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
837 Likewise.
838 * image.c (pbm_read_file): Likewise.
839 * indent.c (string_display_width): Likewise.
840 * intervals.c (check_for_interval, search_for_interval)
841 (inc_interval_count, count_intervals, root_interval)
842 (adjust_intervals_for_insertion, make_new_interval): Likewise.
843 * lread.c (defalias): Likewise.
268c2c36 844 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
845 * regex.c (set_image_of_range_1, set_image_of_range)
846 (regex_grow_registers): Likewise.
847 * sysdep.c (strerror): Likewise.
848 * termcap.c (valid_filename_p, tprint, main): Likewise.
849 * tparam.c (main): Likewise.
850 * unexhp9k800.c (run_time_remap, save_data_space)
851 (update_file_ptrs, read_header, write_header, calculate_checksum)
852 (copy_file, copy_rest, display_header): Likewise.
853 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
854 Likewise.
855 * xdisp.c (check_it): Likewise.
856 * xfaces.c (register_color, unregister_color, unregister_colors):
857 Likewise.
858 * xfns.c (print_fontset_result): Likewise.
859 * xrdb.c (member, fatal, main): Likewise.
860
99033785
PE
8612011-07-10 Paul Eggert <eggert@cs.ucla.edu>
862
863 Fix minor problems found by static checking (Bug#9031).
864 * chartab.c (char_table_set_range, map_sub_char_table):
865 Remove unused locals.
866 (uniprop_table): Now static.
867 * composite.c (_work_char): Remove unused static var.
868
9cb2ac56
JB
8692011-07-09 Juanma Barranquero <lekktu@gmail.com>
870
871 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
872
f25661f0
JD
8732011-07-09 Jan Djärv <jan.h.d@swipnet.se>
874
875 * gtkutil.c (qttip_cb): Remove code without function.
876
8278c4fe
EZ
8772011-07-09 Eli Zaretskii <eliz@gnu.org>
878
879 * w32.c (pthread_sigmask): New stub.
880
1692ae2d 8812011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 882
8a6ebd58 883 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
884 sigprocmask is portable only for single-threaded applications, and
885 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
886 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
887 (LIBES): Use it.
888 * callproc.c (Fcall_process):
889 * process.c (create_process):
890 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
891 Use pthread_sigmask, not sigprocmask.
123403e4 892
1b854618
JD
8932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
894
895 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
896 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
897 wrong (Bug#8591).
898
3fe4b549
JD
8992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
900
0ce7e563
JD
901 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
902 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
903 (xg_hide_tooltip): Fix comment.
904
3fe4b549
JD
905 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
906 in registerServicesMenuSendTypes.
907 (validRequestorForSendType): Don't check ns_return_types.
908
909 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
910 ns_return_type.
911
5df75e47
JR
9122011-07-08 Jason Rumney <jasonr@gnu.org>
913
914 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
915 frame struct members of non-existent frames (Bug#6284).
916
699c10bd
JD
9172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
918
4393663b
JD
919 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
920 variable firstTime not needed on OSX >= 10.6.
921 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
922 >= 10.5. Use setKnobProportion, setDoubleValue.
923
924 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
925 (MAC_OS_X_VERSION_10_5): Define if not defined.
926 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
927 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
928 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
929
930 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
931 cString and lossyCString on OSX >= 10.4
932
933 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
934 sizeToFit on OSX >= 10.2.
935
936 * nsimage.m (allocInitFromFile): Don't use deprecated method
937 bestRepresentationForDevice on OSX >= 10.6.
938
939 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
940 to avoid warning.
941
942 * emacs.c: Declare unexec_init_emacs_zone.
943
a63e0781
JD
944 * nsgui.h: Fix compiler warning about gnulib redefining verify.
945
699c10bd
JD
946 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
947
948 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
949 on svcsMenu (Bug#8842).
950
951 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
952 ns_return_types.
953 (Fns_list_services): Just return Qnil on 10.6, code not working there.
954
955 * nsterm.m (QUTF8_STRING): Declare.
956 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
957 (validRequestorForSendType): Return type is (id).
958 Change indexOfObjectIdenticalTo to indexOfObject.
959 Check if we have local selection before returning self (Bug#8842).
960 (writeSelectionToPasteboard): Put local selection into paste board
961 if we have a local selection (Bug#8842).
962 (syms_of_nsterm): DEFSYM QUTF8_STRING.
963
964 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
965 (ns_get_local_selection): Declare.
966
54e10184
LMI
9672011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
968
9888ff71
LMI
969 * keymap.c (describe_map_tree): Don't insert a double newline at
970 the end of the buffer (bug#1169) and return whether we inserted
971 something.
972
54e10184
LMI
973 * callint.c (Fcall_interactively): Change "reading args" to
974 "providing args" to try to clarify what it does (bug#1010).
975
15fa4783
KH
9762011-07-07 Kenichi Handa <handa@m17n.org>
977
978 * composite.c (composition_compute_stop_pos): Ignore a static
979 composition starting before CHARPOS (Bug#8915).
980
981 * xdisp.c (handle_composition_prop): Likewise.
982
a8815b00
EZ
9832011-07-07 Eli Zaretskii <eliz@gnu.org>
984
985 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
986 (Bug#9015)
987
ef7b981d 9882011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
989
990 * character.h (unicode_category_t): New enum type.
991
992 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
993 (Qchar_code_property_table): New variable.
994 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
995 (UNIPROP_COMPRESSED_FORM_P): New macros.
996 (char_table_ascii): Uncompress the compressed values.
997 (sub_char_table_ref): New arg is_uniprop. Callers changed.
998 Uncompress the compressed values.
ac389d0c 999 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1000 (char_table_ref_and_range): Uncompress the compressed values.
1001 (sub_char_table_set): New arg is_uniprop. Callers changed.
1002 Uncompress the compressed values.
1003 (sub_char_table_set_range): Args changed. Callers changed.
1004 (char_table_set_range): Adjuted for the above change.
1005 (map_sub_char_table): Delete args default_val and parent. Add arg
1006 top. Give decoded values to a Lisp function.
1007 (map_char_table): Adjusted for the above change. Give decoded
1008 values to a Lisp function. Gcpro more variables.
1009 (uniprop_table_uncompress)
1010 (uniprop_decode_value_run_length): New functions.
1011 (uniprop_decoder, uniprop_decoder_count): New variables.
1012 (uniprop_get_decoder, uniprop_encode_value_character)
1013 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1014 New functions.
1015 (uniprop_encoder, uniprop_encoder_count): New variables.
1016 (uniprop_get_encoder, uniprop_table)
1017 (Funicode_property_table_internal, Fget_unicode_property_internal)
1018 (Fput_unicode_property_internal): New functions.
1019 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1020 Sunicode_property_table_internal, Sget_unicode_property_internal,
1021 and Sput_unicode_property_internal. Defvar_lisp
1022 char-code-property-alist.
1023
1024 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1025 Vunicode_category_table.
1026
1027 * font.c (font_range): Adjusted for the change of
1028 Vunicode_category_table.
1029
76b397fb
DN
10302011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1031
1032 * m/iris4d.h: Remove file, move contents ...
1033 * s/irix6-5.h: ... here.
1034
22b4128e
PE
10352011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1038 * alloc.c (mark_buffer):
1039 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1040 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1041 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1042 This isn't true in general, and it's particularly not true
1043 if Emacs is configured with --with-wide-int.
1044 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1045 New macros, used in the buffer.c change.
1046
869795d6
JD
10472011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1048
1049 * xsettings.c: Use both GConf and GSettings if both are available.
1050 (store_config_changed_event): Add comment.
1051 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1052 (store_tool_bar_style_changed): New functions.
1053 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1054 (struct xsettings): Move font inside HAVE_XFT.
1055 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1056 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1057 Move inside HAVE_XFT.
1058 (something_changed_gsettingsCB): Renamed from something_changedCB.
1059 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1060 also.
1061 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1062 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1063 (something_changed_gconfCB): Renamed from something_changedCB.
1064 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1065 (parse_settings): Move check for font inside HAVE_XFT.
1066 (read_settings, apply_xft_settings): Add comment.
1067 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1068 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1069 call store_font_name_changed.
1070 (xft_settings_event): Add comment.
1071 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1072 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1073 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1074 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1075 (xsettings_initialize): Call init_gsettings last.
1076 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1077 comment.
1078
d8ed26bd
PE
10792011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Random fixes. E.g., (random) never returned negative values.
1082 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1083 subseconds part to the entropy, as that's a bit more random.
1084 Prefer signed to unsigned, since the signedness doesn't matter and
1085 in general we prefer signed. When given a limit, use a
1086 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1087 latter isn't right if USE_2_TAGS_FOR_INTS.
1088 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1089 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1090
cabf1cac
SM
10912011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1092
1093 * textprop.c (text_property_stickiness):
1094 Obey Vtext_property_default_nonsticky.
1095 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1096 * w32fns.c (syms_of_w32fns):
1097 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1098
6e9b2be9
PE
10992011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1102 This is more efficient than Ffile_directory_p and avoids a minor race.
1103
90186c68
LMI
11042011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1105
7c301272
LMI
1106 * buffer.c (Foverlay_put): Say what the return value is
1107 (bug#7835).
1108
c4f2d8d4
LMI
1109 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1110 is a directory before asking whether to use the file name
1111 (bug#7564).
ad637907
LMI
1112 (barf_or_query_if_file_exists): Make the "File is a directory"
1113 error be more correct.
c4f2d8d4 1114
90186c68
LMI
1115 * fns.c (Frequire): Remove the mention of the .gz files, since
1116 that's installation-specific, but keep the mention of
1117 `get-load-suffixes'.
1118
da64016e
PE
11192011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1122 Report string overflow if the output is too long.
1123
7d47b580
JB
11242011-07-04 Juanma Barranquero <lekktu@gmail.com>
1125
a555cb87
JB
1126 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1127 (syms_of_gnutls): Remove duplicate DEFSYM for
1128 Qgnutls_bootprop_verify_hostname_error, an error for
1129 Qgnutls_bootprop_verify_error (which is no longer used).
1130
7d47b580
JB
1131 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1132 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1133 Also (re)move comments that are misplaced or no longer relevant.
1134
1e49bfab
LMI
11352011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1136
1137 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1138
1485f4c0
CY
11392011-07-03 Chong Yidong <cyd@stupidchicken.com>
1140
1141 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1142 and background color parameters if they have been changed.
1143
a9ab721e
LMI
11442011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1145
1146 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1147
cf7cff57
PE
11482011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1149
2e13213d
PE
1150 * xsettings.c (SYSTEM_FONT): Define only when used.
1151 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1152
cf7cff57
PE
1153 * keymap.c (access_keymap_1): Now static.
1154
7a8e04f7
CY
11552011-07-02 Chong Yidong <cyd@stupidchicken.com>
1156
1157 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1158 leave any prefix arg for the up event (Bug#1586).
1159
61352f62
LMI
11602011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1161
69bb1ef7
LMI
1162 * lread.c (syms_of_lread): Mention single symbols defined by
1163 `defvar' or `defconst' (bug#7154).
1164
61352f62 1165 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1166 (Frequire): Mention get-load-suffixes.
61352f62 1167
28545e04
MR
11682011-07-02 Martin Rudalics <rudalics@gmx.at>
1169
1170 * window.h (window): Remove clone_number slot.
1171 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1172 Remove.
1173 (make_parent_window, make_window, saved_window)
1174 (Fset_window_configuration, save_window_save): Don't deal with
1175 clone numbers.
1176 * buffer.c (Qclone_number): Remove declaration.
1177 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1178
3349e122
SM
11792011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1180
1181 Add multiple inheritance to keymaps.
1182 * keymap.c (Fmake_composed_keymap): New function.
1183 (Fset_keymap_parent): Simplify.
1184 (fix_submap_inheritance): Remove.
1185 (access_keymap_1): New function extracted from access_keymap to handle
1186 embedded parents and handle lists of maps.
1187 (access_keymap): Use it.
1188 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1189 (Fcopy_keymap): Handle embedded parents.
1190 (Fcommand_remapping, define_as_prefix): Simplify.
1191 (Fkey_binding): Simplify.
1192 (syms_of_keymap): Move minibuffer-local-completion-map,
1193 minibuffer-local-filename-completion-map,
1194 minibuffer-local-must-match-map, and
1195 minibuffer-local-filename-must-match-map to Elisp.
1196 (syms_of_keymap): Defsubr make-composed-keymap.
1197 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1198 (parse_menu_item): Trivial simplification.
1199
3279eb87
GM
12002011-07-01 Glenn Morris <rgm@gnu.org>
1201
1202 * Makefile.in (SETTINGS_LIBS): Fix typo.
1203
4550efdf
KI
12042011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1205
1206 * coding.c (Fencode_coding_string): Record the last coding system
1207 used, as the function doc string says (bug#8738).
1208
0949d2b6
JD
12092011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1210
1211 * xsettings.c (store_monospaced_changed): Take new font as arg and
1212 check for change against current_mono_font.
1213 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1214 (emacs_settings_constructor, emacs_settings_get_property)
1215 (emacs_settings_set_property, emacs_settings_class_init)
1216 (emacs_settings_init, gsettings_obj): Remove.
1217 (something_changedCB): New function for HAVE_GSETTINGS.
1218 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1219 with value as argument.
1220 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1221 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1222 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1223 "changed".
1224
1225 * xgselect.c: Add defined (HAVE_GSETTINGS).
1226 (xgselect_initialize): Ditto.
1227
1228 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1229 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1230 xg_select.
1231
bbc6b304
PE
12322011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 * eval.c (struct backtrace): Simplify and port the data structure.
1235 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1236 signed bit field, as this assumption is not portable and it makes
1237 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1238 "char debug_on_exit : 1" as this is not portable either; instead,
1239 use the portable "unsigned int debug_on_exit : 1". Remove unused
1240 member evalargs. Remove obsolete comments about cc bombing out.
1241
9851bfc5
JD
12422011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1243
51bb811f 1244 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1245 Let HAVE_GSETTINGS override HAVE_GCONF.
1246 (store_monospaced_changed): New function.
1247 (EMACS_SETTINGS): A new type derived from GObject to handle
1248 GSettings notifications.
1249 (emacs_settings_constructor, emacs_settings_get_property)
1250 (emacs_settings_set_property, emacs_settings_class_init):
1251 New functions.
1252 (gsettings_client, gsettings_obj): New variables.
1253 (GSETTINGS_SCHEMA): New define.
1254 (something_changedCB): Call store_monospaced_changed.
1255 (init_gsettings): New function.
1256 (xsettings_initialize): Call init_gsettings.
1257 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1258 to NULL.
1259
1260 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1261 GCONF_CFLAGS/LIBS.
1262
5386012d
MR
12632011-06-29 Martin Rudalics <rudalics@gmx.at>
1264
1265 * window.c (resize_root_window, grow_mini_window)
1266 (shrink_mini_window): Rename Qresize_root_window to
1267 Qwindow_resize_root_window and Qresize_root_window_vertically to
1268 Qwindow_resize_root_window_vertically.
1269
f13e0b08
PE
12702011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1271
1272 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1273
94515237
JB
12742011-06-27 Juanma Barranquero <lekktu@gmail.com>
1275
1276 * makefile.w32-in: Redesign dependencies so they reflect more
1277 clearly which files are directly included by each source file,
1278 and not through other includes.
1279
e43b6e43
MR
12802011-06-27 Martin Rudalics <rudalics@gmx.at>
1281
1282 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1283 (sort_overlays, overlay_strings): When an overlay's clone number
1284 matches the window's clone number process the overlay even if
1285 the overlay's window property doesn't match the current window.
1286
d68443dc
MR
1287 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1288 (Fwindow_hchild): Rename to Fwindow_left_child.
1289 (Fwindow_next): Rename to Fwindow_next_sibling.
1290 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1291 (resize_window_check): Rename to window_resize_check.
1292 (resize_window_apply): Rename to window_resize_apply.
1293 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1294 (Fdelete_other_windows_internal, resize_frame_windows)
1295 (Fsplit_window_internal, Fdelete_window_internal)
1296 (grow_mini_window, shrink_mini_window)
1297 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1298
c7e73be5
JD
12992011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1300
1301 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1302 (emacs_fixed_set_min_size): Remove.
1303 (emacs_fixed_new): Take frame as argument.
1304
1305 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1306 (_EmacsFixedPrivate): Remove minwidth/height.
1307 Add struct frame *f.
1308 (emacs_fixed_init): Initialize priv->f.
1309 (get_parent_class, emacs_fixed_set_min_size): Remove.
1310 (emacs_fixed_new): Set priv->f to argument.
1311 (emacs_fixed_get_preferred_width)
1312 (emacs_fixed_get_preferred_height): Use min_width/height from
1313 frames size_hint to set minimum and natural (Bug#8919).
1314 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1315 and use min_width/height from frames size_hint to set
1316 min_width/height (Bug#8919).
1317
1318 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1319 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1320 Fix indentation.
c7e73be5 1321
cf99dcf8
EZ
13222011-06-26 Eli Zaretskii <eliz@gnu.org>
1323
1324 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1325 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1326 called at ZV.
1327
029529ac
CY
13282011-06-26 Chong Yidong <cyd@stupidchicken.com>
1329
1330 * process.c (wait_reading_process_output): Bypass select if
1331 waiting for a cell while ignoring keyboard input, and input is
1332 pending. Suggested by Jan Djärv (Bug#8869).
1333
7a7ef429
PE
13342011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 Use gnulib's dup2 module instead of rolling our own.
1337 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1338
11fdef7d 13392011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1340
1341 * dispnew.c (scrolling_window): Before scrolling, turn off a
1342 mouse-highlight in the window being scrolled.
1343
cd3520a4
JB
13442011-06-24 Juanma Barranquero <lekktu@gmail.com>
1345
1346 Move DEFSYM to lisp.h and use everywhere.
1347
1348 * character.h (DEFSYM): Move declaration...
1349 * lisp.h (DEFSYM): ...here.
1350
1351 * gnutls.c:
1352 * minibuf.c:
1353 * w32menu.c:
1354 * w32proc.c:
1355 * w32select.c: Don't include character.h.
1356
1357 * alloc.c (syms_of_alloc):
1358 * buffer.c (syms_of_buffer):
1359 * bytecode.c (syms_of_bytecode):
1360 * callint.c (syms_of_callint):
1361 * casefiddle.c (syms_of_casefiddle):
1362 * casetab.c (init_casetab_once):
1363 * category.c (init_category_once, syms_of_category):
1364 * ccl.c (syms_of_ccl):
1365 * cmds.c (syms_of_cmds):
1366 * composite.c (syms_of_composite):
1367 * dbusbind.c (syms_of_dbusbind):
1368 * dired.c (syms_of_dired):
1369 * dispnew.c (syms_of_display):
1370 * doc.c (syms_of_doc):
1371 * editfns.c (syms_of_editfns):
1372 * emacs.c (syms_of_emacs):
1373 * eval.c (syms_of_eval):
1374 * fileio.c (syms_of_fileio):
1375 * fns.c (syms_of_fns):
1376 * frame.c (syms_of_frame):
1377 * fringe.c (syms_of_fringe):
1378 * insdel.c (syms_of_insdel):
1379 * keymap.c (syms_of_keymap):
1380 * lread.c (init_obarray, syms_of_lread):
1381 * macros.c (syms_of_macros):
1382 * msdos.c (syms_of_msdos):
1383 * print.c (syms_of_print):
1384 * process.c (syms_of_process):
1385 * search.c (syms_of_search):
1386 * sound.c (syms_of_sound):
1387 * syntax.c (init_syntax_once, syms_of_syntax):
1388 * terminal.c (syms_of_terminal):
1389 * textprop.c (syms_of_textprop):
1390 * undo.c (syms_of_undo):
1391 * w32.c (globals_of_w32):
1392 * window.c (syms_of_window):
1393 * xdisp.c (syms_of_xdisp):
1394 * xfaces.c (syms_of_xfaces):
1395 * xfns.c (syms_of_xfns):
1396 * xmenu.c (syms_of_xmenu):
1397 * xsettings.c (syms_of_xsettings):
1398 * xterm.c (syms_of_xterm): Use DEFSYM.
1399
4228cf16
TZ
14002011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1401
cd3520a4 1402 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1403
7fcccf1e
PE
14042011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1405
7efb4e0e
PE
1406 Integer and buffer overflow fixes (Bug#8873).
1407
ff5844ad
PE
1408 * print.c (printchar, strout): Check for string overflow.
1409 (PRINTPREPARE, printchar, strout):
1410 Don't set size unless allocation succeeds.
1411
90532f02
PE
1412 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1413 for sizes. Check for string overflow more accurately.
1414 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1415
6d84508d
PE
1416 * macros.c: Integer and buffer overflow fixes.
1417 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1418 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1419 Use ptrdiff_t, not int, for sizes.
1420 Don't increment bufsize until after realloc succeeds.
1421 Check for size-calculation overflow.
1422 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1423
437b2cb4
PE
1424 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1425
8b9ac8b4
PE
1426 * lread.c: Integer overflow fixes.
1427 (read_integer): Radix is now EMACS_INT, not int,
1428 to improve quality of diagnostics for out-of-range radices.
1429 Calculate buffer size correctly for out-of-range radices.
1430 (read1): Check for integer overflow in radices, and in
1431 read-circle numbers.
82cb60d3
PE
1432 (read_escape): Avoid int overflow.
1433 (Fload, openp, read_buffer_size, read1)
1434 (substitute_object_recurse, read_vector, read_list, map_obarray):
1435 Use ptrdiff_t, not int, for sizes.
1436 (read1): Use EMACS_INT, not int, for sizes.
20270765 1437 Check for size overflow.
8b9ac8b4 1438
7fcccf1e
PE
1439 * image.c (cache_image): Check for size arithmetic overflow.
1440
bfbbd7e7
PE
1441 * lread.c: Integer overflow issues.
1442 (saved_doc_string_size, saved_doc_string_length)
1443 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1444 Now ptrdiff_t, not int.
1445 (read1): Don't assume doc string length fits in int. Check for
1446 out-of-range doc string lengths.
1447 (read_list): Don't assume file position fits in int.
39019e54 1448 (read_escape): Check for hex character overflow.
bfbbd7e7 1449
4e323265
LL
14502011-06-22 Leo Liu <sdl.web@gmail.com>
1451
1452 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1453 Move to minibuffer.el.
1454
85fece3e
PE
14552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1456
20b84ce9 1457 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1458 The following patches are for when GLYPH_DEBUG && !XASSERT.
1459 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1460 * dispnew.c (flush_stdout):
1461 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1462 Mark as externally visible.
1463 * dispnew.c (check_window_matrix_pointers): Now static.
1464 * dispnew.c (window_to_frame_vpos):
1465 * xfns.c (unwind_create_frame):
1466 * xterm.c (x_check_font): Remove unused local.
1467 * scroll.c (CHECK_BOUNDS):
1468 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1469 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1470 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1471 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1472 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1473 Now static.
1474 (debug_method_add): Use va_list and vsprintf rather than relying
1475 on undefined behavior with wrong number of arguments.
1476 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1477 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1478 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1479 since we're not interested in debugging glyphs with old libraries.
1480 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1481 GCC 4.6.0's static checking.
1482
0766b489
PE
14832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1484
31fd4b32
PE
1485 Integer overflow and signedness fixes (Bug#8873).
1486 A few related buffer overrun fixes, too.
1487
b79e8648
PE
1488 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1489
0766b489
PE
1490 * dispextern.h (struct face.stipple):
1491 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1492 (x_bitmap_mask, x_allocate_bitmap_record)
1493 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1494 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1495 (x_create_bitmap_from_xpm_data):
1496 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1497 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1498 (.bitmaps_last):
1499 * xfaces.c (load_pixmap):
1500 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1501 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1502 (.bitmaps_last, struct x_output.icon_bitmap):
1503 Use ptrdiff_t, not int, for bitmap indexes.
1504 (x_allocate_bitmap_record): Check for size overflow.
1505 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1506
b081724f
PE
1507 Use ptrdiff_t, not int, for overlay counts.
1508 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1509 * editfns.c (overlays_around, get_pos_property):
1510 * textprop.c (get_char_property_and_overlay):
1511 * xdisp.c (next_overlay_change, note_mouse_highlight):
1512 * xfaces.c (face_at_buffer_position):
21514da7
PE
1513 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1514 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1515 (Fnext_overlay_change, Fprevious_overlay_change)
1516 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1517 Use ptrdiff_t, not int, for sizes.
21514da7 1518 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1519
3de73e5e
PE
1520 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1521
2606c57b
PE
1522 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1523 (x_session_initialize): Do not assume string length fits in int.
1524
aaafe47a
PE
1525 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1526 This is unlikely, but can occur if DPI is outlandish.
1527
2674ddc8 1528 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1529 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1530
28154962
PE
1531 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1532 * xrdb.c (magic_file_p, search_magic_path):
1533 Omit last arg SUFFIX; it was always 0. All callers changed.
1534 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1535
7de51af5
PE
1536 * xfont.c (xfont_match): Avoid need for strlen.
1537
25ed6cc3
PE
1538 * xfns.c: Don't assume strlen fits in int.
1539 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1540
4eab31dd
PE
1541 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1542 not unsigned long, as we prefer signed integers. All callers changed.
1543 Detect integer overflow in repeat count.
1544 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1545 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1546
171e2a58
PE
1547 * termcap.c: Don't assume sizes fit in int and never overflow.
1548 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1549 (gobble_line): Check for size-calculation overflow.
1550
ad39faca 1551 * minibuf.c (Fread_buffer):
6e5bb2dc 1552 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1553 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1554 Don't assume string length fits in int.
1555
52c61c22 1556 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1557 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1558
b5b8c9e5
PE
1559 * font.c: Don't assume string length fits in int.
1560 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1561 Use ptrdiff_t, not int.
ccd6111c
PE
1562 (font_intern_prop): Don't assume string length fits in int.
1563 Don't assume integer property fits in fixnum.
1564 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1565
882f0d81 1566 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1567 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1568 Reformulate so as not to need the command string.
1569 Invoke gzip -cd rather than gunzip, as it's more portable.
1570 (lock_info_type, lock_file_1, lock_file):
1571 Don't assume pid_t and time_t fit in unsigned long.
1572 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1573 (current_lock_owner): Prefer signed type for sizes.
1574 Use memcpy, not strncpy, where memcpy is what is really wanted.
1575 Don't assume (via atoi) that time_t and pid_t fit in int.
1576 Check for time_t and/or pid_t out of range, e.g., via a network share.
1577 Don't alloca where an auto var works fine.
1578
93f4cf88
PE
1579 * fileio.c: Fix some integer overflow issues.
1580 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1581 Don't assume string length fits in int.
1582 (directory_file_name): Don't assume string length fits in long.
1583 (make_temp_name): Don't assume pid fits in int, or that its print
1584 length is less than 20.
1585
f3e92b69
PE
1586 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1587
1bfdaf10
PE
1588 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1589
35016e9a
PE
1590 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1591
3d1e65a1
PE
1592 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1593 We prefer signed integers, even for size calculations.
1594
0b963a93
PE
1595 * emacs.c: Don't assume string length fits in 'int'.
1596 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1597 (main): Don't invoke strlen when not needed.
1598
573f4b54
PE
1599 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1600 (XD_DEBUG_MESSAGE): Don't waste a byte.
1601
989f33ba
PE
1602 * callproc.c (getenv_internal_1, getenv_internal)
1603 (Fgetenv_internal):
965d34eb
PE
1604 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1605
e4d29b33
PE
1606 * lread.c (invalid_syntax): Omit length argument.
1607 All uses changed. This doesn't fix a bug, but it simplifies the
1608 code away from its former Hollerith-constant appearance, and it's
1609 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1610 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1611
eb49b136
PE
1612 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1613 This didn't break anything, but it didn't help either.
1614 It's confusing to put a bogus integer in a place where the actual
1615 value does not matter.
9f62aeb1 1616 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1617 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1618
15375a22
PE
1619 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1620 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1621 implementation.
b61cc01c
PE
1622 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1623 We prefer signed types, and the value cannot exceed the EMACS_INT
1624 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1625 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1626 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1627 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1628
53b2623d
PE
1629 * indent.c (sane_tab_width): New function.
1630 (current_column, scan_for_column, Findent_to, position_indentation)
1631 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1632 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1633
51cab52b 1634 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1635
f2ed8a70
PE
1636 * lisp.h (lint_assume): New macro.
1637 * composite.c (composition_gstring_put_cache):
1638 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1639
abe80cc6
PE
1640 * editfns.c, insdel.c:
1641 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1642
b02c740e
PE
1643 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1644
ebc96716
PE
1645 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1646
b4e50fa0 1647 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1648 Use much-faster test for byte-length change.
311d5d7c 1649 Don't assume string byte-length fits in 'int'.
a4cf38e4 1650 Check that character arg fits in 'int'.
85461888 1651 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1652
c0c1ee9f
PE
1653 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1654
a498d7f4
PE
1655 * fns.c (concat): Catch string overflow earlier.
1656 Do not rely on integer wraparound.
1657
51cab52b
PE
1658 * dispextern.h (struct it.overlay_strings_charpos)
1659 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1660 * xdisp.c (forward_to_next_line_start)
1661 (back_to_previous_visible_line_start)
1662 (reseat_at_next_visible_line_start, next_element_from_buffer):
1663 Don't arbitrarily truncate the value of 'selective' to int.
1664
76031fad
PE
1665 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1666
5eb55db9
PE
1667 * composite.c: Don't truncate sizes to 'int'.
1668 (composition_gstring_p, composition_reseat_it)
1669 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1670 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1671 not EMACS_UINT, for indexes.
5eb55db9 1672
0703a717
PE
1673 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1674
d6202519
PE
1675 * buffer.c: Include <verify.h>.
1676 (struct sortvec.priority, struct sortstr.priority):
8961a454 1677 Now EMACS_INT, not int.
c20998a7 1678 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1679 (struct sortstr.size, record_overlay_string)
1680 (struct sortstrlist.size, struct sortlist.used):
1681 Don't truncate size to int.
1682 (record_overlay_string): Check for size-calculation overflow.
d6202519 1683 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1684
d5a19415
JM
16852011-06-22 Jim Meyering <meyering@redhat.com>
1686
029529ac 1687 Don't leak an XBM-image-sized buffer
d5a19415
JM
1688 * image.c (xbm_load): Free the image buffer after using it.
1689
a9041e6c
PE
16902011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 Port to Sun C.
1693 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1694 that Sun C diagnosed.
1695 * fns.c (secure_hash): Fix pointer signedness issue.
1696 * intervals.c (static_offset_intervals): New function.
1697 (offset_intervals): Use it.
1698
7f3f739f
LL
16992011-06-21 Leo Liu <sdl.web@gmail.com>
1700
1701 * deps.mk (fns.o):
1702 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1703 sha512.h.
1704
1705 * fns.c (secure_hash): Rename from crypto_hash_function and change
1706 the first arg to accept symbols.
5b66d427 1707 (Fsecure_hash): New primitive.
7f3f739f
LL
1708 (syms_of_fns): New symbols.
1709
76147d94
DD
17102011-06-20 Deniz Dogan <deniz@dogan.se>
1711
1712 * process.c (Fset_process_buffer): Clarify return value in
1713 docstring.
1714
7d7d0045
CY
17152011-06-18 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * dispnew.c (add_window_display_history): Use BVAR.
1718
1719 * xdisp.c (debug_method_add): Use BVAR.
1720 (check_window_end, dump_glyph_matrix, dump_glyph)
1721 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1722
1723 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1724 Likewise.
1725
1726 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1727 check till after the cache is created in init_frame_faces.
1728
ff2bc410
SM
17292011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1730
1731 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1732
28177add
PE
17332011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1734
dd3482fe
PE
1735 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1736 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1737 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1738
393d71f3 1739 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1740 * fileio.c (Finsert_file_contents):
1741 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1742 Remove the old (too-loose) buffer overflow checks.
1743 They weren't needed, since make_gap checks for buffer overflow.
1744 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1745 The old code merely checked for Emacs fixnum overflow, and relied
1746 on undefined (wraparound) behavior. The new code avoids undefined
1747 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1748
2e6813b0 1749 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1750 Tune. Don't use wider integers than needed. Don't use alloca.
1751 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1752
599a9e4f
PE
1753 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1754
99561444
PE
1755 * insdel.c, lisp.h (buffer_overflow): New function.
1756 (insert_from_buffer_1, replace_range, replace_range_2):
1757 * insdel.c (make_gap_larger):
1758 * editfns.c (Finsert_char):
1759 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1760
28177add
PE
1761 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1762
e69dafad
PE
17632011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1764
a7af7fde 1765 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1766
b1c46f02
PE
1767 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1768 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1769
e69dafad
PE
1770 * fileio.c: Don't assume EMACS_INT fits in off_t.
1771 (emacs_lseek): New static function.
1772 (Finsert_file_contents, Fwrite_region): Use it.
1773 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1774
566684ea
PE
1775 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1776
e6966cd6
PE
1777 * fns.c: Don't overflow int when computing a list length.
1778 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1779 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1780 truncation on 64-bit hosts. Check for QUIT every
1781 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1782 faster and is responsive enough.
1783 (Flength): Report an error instead of overflowing an integer.
1784 (Fsafe_length): Return a float if the value is not representable
1785 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1786 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1787 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1788
dd0b0efb
PE
1789 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1790 (header_size, word_size): New constants.
1791 (allocate_vectorlike): Don't check size overflow here.
1792 (allocate_vector): Check it here instead, since this is the only
1793 caller of allocate_vectorlike that could cause overflow.
1794 Check that the new vector's length is representable as a fixnum.
1795
86fe5cfe
PE
1796 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1797 The previous code was bogus. For example, next_almost_prime (32)
1798 returned 39, which is undesirable as it is a multiple of 3; and
1799 next_almost_prime (24) returned 25, which is a multiple of 5 so
1800 why was the code bothering to check for multiples of 7?
1801
80e88859
PE
1802 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1803
4a2f0ad6
PE
1804 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1805
f66c7cf8
PE
1806 Variadic C functions now count arguments with ptrdiff_t.
1807 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1808 Back then I didn't know that the Emacs coding style prefers signed int.
1809 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1810 were being counted with int, which may truncate counts on 64-bit
1811 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1812 * lisp.h (struct Lisp_Subr.function.aMANY)
1813 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1814 Arg counts are now ptrdiff_t, not size_t.
1815 All variadic functions and their callers changed accordingly.
1816 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1817 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1818 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1819 * callint.c (Fcall_interactively): Check arg count for overflow,
1820 to avoid potential buffer overrun. Use signed char, not 'int',
1821 for 'varies' array, so that we needn't bother to check its size
1822 calculation for overflow.
1823 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1824 * eval.c (apply_lambda):
1825 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1826 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1827 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1828
a1759b76
PE
1829 * callint.c (Fcall_interactively): Don't use index var as event count.
1830
d96be9fc
PE
1831 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1832 * mem-limits.h (SIZE): Remove; no longer used.
1833
a690a978 1834 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1835
578c21e6
PE
1836 Remove unnecessary casts.
1837 * xterm.c (x_term_init):
1838 * xfns.c (x_set_border_pixel):
1839 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1840 These aren't needed now that we assume ANSI C.
1841
96f53c6c
PE
1842 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1843 It's more likely to cause problems (due to unsigned overflow)
1844 than to cure them.
1845
83c77d31
PE
1846 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1847
ee2079f1
PE
1848 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1849
6da65536
PE
1850 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1851
7147c4a4
PE
1852 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1853
193e32d9
PE
1854 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1855
e5533da6
PE
1856 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1857
9910e595
PE
1858 GLYPH_CODE_FACE returns EMACS_INT, not int.
1859 * dispextern.h (merge_faces):
1860 * xfaces.c (merge_faces):
01103c44
PE
1861 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1862 Don't assume EMACS_INT fits in int.
9910e595 1863
2638320e
PE
1864 * character.h (CHAR_VALID_P): Remove unused parameter.
1865 * fontset.c, lisp.h, xdisp.c: All uses changed.
1866
045eb8d9
PE
1867 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1868
c1f134b5
PE
1869 * fns.c (concat): Minor tuning based on overflow analysis.
1870 This doesn't fix any bugs. Use int to hold character, instead
1871 of constantly refetching from Emacs object. Use XFASTINT, not
1872 XINT, for value known to be a character. Don't bother comparing
1873 a single byte to 0400, as it's always less.
1874
395fcb93 1875 * floatfns.c (Fexpt):
327eeec8
PE
1876 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1877
abbd3d23
PE
1878 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1879 for characters.
1880
684a03ef
PE
1881 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1882
0fed43f3
PE
1883 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1884 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1885 incorrectly succeed when S was a string, because 4294967386 was
1886 truncated before it was used.
1887
8fd02eb7
PE
1888 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1889 Otherwise, an out-of-range integer could cause undefined behavior
1890 on a 64-bit host.
1891
f8c86b69
PE
1892 * composite.c: Use int, not EMACS_INT, for characters.
1893 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1894 EMACS_INT, for values that are known to be in character range.
1895 This doesn't fix any bugs but is the usual style inside Emacs and
1896 may generate better code on 32-bit machines.
1897
34206dd2
PE
1898 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1899 This is for reasons similar to the recent CHAR_STRING fix.
1900 * charset.c (Fencode_char): Check that character arg is actually
1901 a character. Pass an int to ENCODE_CHAR.
1902 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1903 wider than 'int', as a compile-time check to prevent future regressions
1904 in this area.
1905
c5958d4c 1906 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1907
1908 Make sure a 64-bit char is never passed to CHAR_STRING.
1909 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1910 by silently ignoring the top 32 bits, allowing some values
1911 that were far too large to be valid characters.
1912 * character.h: Include <verify.h>.
1913 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1914 arguments are no wider than unsigned, as a compile-time check
1915 to prevent future regressions in this area.
1916 * data.c (Faset):
01103c44 1917 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1918 (Fsubst_char_in_region):
1919 * fns.c (concat):
1920 * xdisp.c (decode_mode_spec_coding):
1921 Adjust to CHAR_STRING's new requirement.
1922 * editfns.c (Finsert_char, Fsubst_char_in_region):
1923 * fns.c (concat): Check that character args are actually
1924 characters. Without this test, these functions did the wrong
1925 thing with wildly out-of-range values on 64-bit hosts.
1926
d37ca623
PE
1927 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1928 These casts should not be needed on 32-bit hosts, either.
1929 * keyboard.c (read_char):
1930 * lread.c (Fload): Remove casts to unsigned.
1931
ea204efb
PE
1932 * lisp.h (UNSIGNED_CMP): New macro.
1933 This fixes comparison bugs on 64-bit hosts.
1934 (ASCII_CHAR_P): Use it.
1935 * casefiddle.c (casify_object):
01103c44 1936 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1937 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1938 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1939 * dispextern.h (FACE_FROM_ID):
1940 * keyboard.c (read_char): Use UNSIGNED_CMP.
1941
41cb286c
PE
1942 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1943 not to EMACS_INT, to avoid GCC warning.
1944
4a1b9832
PE
1945 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1946
55daad71
PE
1947 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1948 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1949 isn't needed on 32-bit machines.
8f95c75c 1950
01103c44
PE
1951 * buffer.c (Fgenerate_new_buffer_name):
1952 Use EMACS_INT for count, not int.
0ceccced 1953 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1954
1955 * data.c (Qcompiled_function): Now static.
1956
c6f072e7
PE
1957 * window.c (window_body_lines): Now static.
1958
20ce5912
PE
1959 * image.c (gif_load): Rename local to avoid shadowing.
1960
9c4c5f81
PE
1961 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1962 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1963 * alloc.c (make_save_value): Integer argument is now of type
1964 ptrdiff_t, not int.
1965 (mark_object): Use ptrdiff_t, not int.
1966 * lisp.h (pD): New macro.
1967 * print.c (print_object): Use it.
1968
c0c5c8ae
PE
1969 * alloc.c: Use EMACS_INT, not int, to count objects.
1970 (total_conses, total_markers, total_symbols, total_vector_size)
1971 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1972 (total_free_floats, total_floats, total_free_intervals)
1973 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1974 Now EMACS_INT, not int. All uses changed.
1975 (Fgarbage_collect): Compute overall total using a double, so that
1976 integer overflow is less likely to be a problem. Check for overflow
1977 when converting back to an integer.
5a25e253
PE
1978 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1979 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1980 These were 'int' variables that could overflow on 64-bit hosts;
1981 they were never used, so remove them instead of repairing them.
211a0b2a 1982 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1983 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1984 Previously, this ceilinged at INT_MAX, but that doesn't work on
1985 64-bit machines.
e46bb31a 1986 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1987
c78baabf 1988 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1989 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1990 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1991 when a (possibly-narrower) signed value would do just as well.
1992 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1993
c9d624c6
PE
1994 * alloc.c: Catch some string size overflows that we were missing.
1995 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1996 for convenience in STRING_BYTES_MAX.
1997 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1998 The definition here is exact; the one in lisp.h was approximate.
1999 (allocate_string_data): Check for string overflow. This catches
2000 some instances we weren't catching before. Also, it catches
2001 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2002 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2003 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2004
c9d624c6
PE
2005 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2006 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2007 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2008
353032ce
PE
2009 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2010
2bccce07
PE
2011 * alloc.c (Fmake_string): Check for out-of-range init.
2012
0ac30604
SM
20132011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2014
2015 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2016
c195f2de
JD
20172011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2018
2019 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2020 xg_get_default_scrollbar_width.
2021
2022 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2023 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2024 (style_changed_cb): Call update_theme_scrollbar_width and call
2025 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2026 all frames (Bug#8505).
2027 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2028 Call gtk_window_set_resizable if HAVE_GTK3.
2029 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2030 and height if HAVE_GTK3 (Bug#8505).
2031 (scroll_bar_width_for_theme): New variable.
2032 (update_theme_scrollbar_width): New function.
2033 (xg_get_default_scrollbar_width): Move code to
2034 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2035 (xg_initialize): Call update_theme_scrollbar_width.
2036
2037 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2038
2039 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2040
e10ac9f1
MR
20412011-06-12 Martin Rudalics <rudalics@gmx.at>
2042
2043 * frame.c (make_frame): Call other_buffer_safely instead of
2044 other_buffer.
2045
2046 * window.c (temp_output_buffer_show): Call display_buffer with
2047 second argument Vtemp_buffer_show_specifiers and reset latter
2048 immediately after the call.
2049 (Vtemp_buffer_show_specifiers): New variable.
2050 (auto_window_vscroll_p, next_screen_context_lines)
2051 (Vscroll_preserve_screen_position): Remove leading asterisks from
2052 doc-strings.
2053
2d3c217e 20542011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2055
7b7f97e8 2056 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2057 * buffer.c (Qclone_number): Remove for now, as it's unused.
2058 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2059 (record_buffer): Remove unused local.
2060 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2061 (set_frame_buffer_list): Remove; unused.
2062 * frame.h (other_visible_frames): Remove decl.
2063 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2064 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2065 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2066 if HAVE_GPM.
2067 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2068 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2069 Define only if HAVE_GPM.
2070 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2071 (update_hints_inhibit): Remove; never set. All uses removed.
2072 * widgetprv.h (emacsFrameClassRec): Remove decl.
2073 * window.c (delete_deletable_window): Now returns void, since it
2074 wasn't returning anything.
2075 (compare_window_configurations): Remove unused locals.
2076 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2077 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2078 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2079 the same widths as pointers. This follows up on the 2011-05-06 patch.
2080 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2081 * xterm.h: Likewise.
2082 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2083
1384b89e
JB
20842011-06-12 Juanma Barranquero <lekktu@gmail.com>
2085
2086 * makefile.w32-in: Update dependencies.
2087 (LISP_H): Add lib/intprops.h.
2088
1100a63c
CY
20892011-06-11 Chong Yidong <cyd@stupidchicken.com>
2090
2091 * image.c (gif_load): Add animation frame delay to the metadata.
2092 (syms_of_image): Use DEFSYM. New symbol `delay'.
2093
6198ccd0
MR
20942011-06-11 Martin Rudalics <rudalics@gmx.at>
2095
2096 * window.c (delete_deletable_window): Re-add.
2097 (Fset_window_configuration): Rewrite to handle dead buffers and
2098 consequently deletable windows.
2099 (window_tree, Fwindow_tree): Remove. Supply functionality in
2100 window.el.
2101 (compare_window_configurations): Simplify code.
2102
b6e3633c
AS
21032011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2104
1ab0dee5
AS
2105 * image.c (imagemagick_load_image): Fix type mismatch.
2106 (Fimagemagick_types): Likewise.
2107
b6e3633c
AS
2108 * window.h (replace_buffer_in_windows): Declare.
2109
9397e56f
MR
21102011-06-11 Martin Rudalics <rudalics@gmx.at>
2111
2112 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2113 Qclone_number. Remove external declaration of Qdelete_window.
2114 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2115 code.
2116 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2117 Qbuffer_list_update_hook if allowed.
2118 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2119 buffer list implementation.
2120 (other_buffer_safely): New function.
2121 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2122 calls to replace_buffer_in_windows and
2123 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2124 if allowed.
2125 (record_buffer): Inhibit quitting and rewrite using quittable
2126 functions. Run Qbuffer_list_update_hook if allowed.
2127 (Frecord_buffer, Funrecord_buffer): New functions.
2128 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2129 switch-to-buffer to window.el.
2130 (bury-buffer): Move to window.el.
2131 (Vbuffer_list_update_hook): New variable.
2132
2133 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2134 section.
2135
2136 * window.h (resize_frame_windows): Move up in code.
2137 (Fwindow_frame): Remove EXFUN.
2138 (replace_buffer_in_all_windows): Remove prototype.
2139 (replace_buffer_in_windows_safely): Add prototype.
2140
2141 * window.c: Declare Qdelete_window static again. Move down
2142 declaration of select_count.
2143 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2144 (Fother_window): Move to window.el.
2145 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2146 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2147 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2148 window.el.
2149 (replace_buffer_in_windows): Implement by calling
2150 Qreplace_buffer_in_windows.
2151 (replace_buffer_in_all_windows): Remove with some functionality
2152 moved into replace_buffer_in_windows_safely.
2153 (replace_buffer_in_windows_safely): New function.
2154 (select_window_norecord, select_frame_norecord): Move in front
2155 of run_window_configuration_change_hook. Remove now obsolete
2156 declarations.
2157 (Fset_window_buffer): Rewrite doc-string. Call
2158 Qrecord_window_buffer.
2159 (keys_of_window): Move binding for other-window to window.el.
2160
b50691aa
CY
21612011-06-11 Chong Yidong <cyd@stupidchicken.com>
2162
2163 * dispextern.h (struct image): Replace data member, whose int_val
2164 and ptr_val fields were not used by anything, with a single
2165 lisp_val object.
2166
2167 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2168 (gif_clear_image, gif_load, imagemagick_load_image)
2169 (gs_clear_image, gs_load): Callers changed.
2170
3f754b86
PE
21712011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2172
cca69397
PE
2173 * buffer.h: Include <time.h>, for time_t.
2174 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2175
109e28d0
PE
2176 Fix minor problems found by static checking.
2177
60737f02
PE
2178 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2179
4b66faf3
PE
2180 Make identifiers static if they are not used in other modules.
2181 * data.c (Qcompiled_function, Qframe, Qvector):
2182 * image.c (QimageMagick, Qsvg):
2183 * minibuf.c (Qmetadata):
2184 * window.c (resize_window_check, resize_root_window): Now static.
2185 * window.h (resize_window_check, resize_root_window): Remove decls.
2186
109e28d0
PE
2187 * window.c (window_deletion_count, delete_deletable_window):
2188 Remove; unused.
46a4ce9e
PE
2189 (window_body_lines): Now static.
2190 (Fdelete_other_windows_internal): Mark vars as initialized.
2191 Make sure 'resize_failed' is initialized.
2192 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2193 (resize_window_apply): Remove unused local.
2194 * window.h (delete_deletable_window): Remove decl.
2195
109e28d0 2196 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2197 (imagemagick_load_image): Fix pointer signedness problem by changing
2198 last arg from unsigned char * to char *. All uses changed.
2199 Also, fix a local for similar reasons.
2200 Remove unused locals. Remove locals to avoid shadowing.
2201 (fn_rsvg_handle_free): Remove; unused.
2202 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2203 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2204
3f754b86
PE
2205 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2206
2547adb1
CY
22072011-06-10 Chong Yidong <cyd@stupidchicken.com>
2208
2209 * image.c (gif_load): Fix omitted cast error introduced by
2210 2011-06-06 change.
2211
2c8e37d4
MR
22122011-06-10 Martin Rudalics <rudalics@gmx.at>
2213
2214 * window.h (resize_proportionally, orig_total_lines)
2215 (orig_top_line): Remove from window structure.
2216 (set_window_height, set_window_width, change_window_heights)
2217 (Fdelete_window): Remove prototypes.
2218 (resize_frame_windows): Remove duplicate declaration.
2219
440a42e3
EZ
22202011-06-10 Eli Zaretskii <eliz@gnu.org>
2221
2222 * window.h (resize_frame_windows, resize_window_check)
2223 (delete_deletable_window, resize_root_window)
2224 (resize_frame_windows): Declare prototypes.
2225
2226 * window.c (resize_window_apply): Make definition be "static" to
2227 match the prototype.
2228
562dd5e9
MR
22292011-06-10 Martin Rudalics <rudalics@gmx.at>
2230
2231 * window.c: Remove declarations of Qwindow_size_fixed,
2232 window_min_size_1, window_min_size_2, window_min_size,
2233 size_window, window_fixed_size_p, enlarge_window, delete_window.
2234 Remove static from declaration of Qdelete_window, it's
2235 temporarily needed by Fbury_buffer.
2236 (replace_window): Don't assign orig_top_line and
2237 orig_total_lines.
2238 (Fdelete_window, delete_window): Remove. Window deletion is
2239 handled by window.el.
2240 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2241 Fdelete_window calls with calls to Qdelete_window.
2242 (Fdelete_other_windows): Remove. Deleting other windows is
2243 handled by window.el.
2244 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2245 handled in window.el.
2246 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2247 Window minimum sizes are handled in window.el.
2248 (shrink_windows, size_window, set_window_height)
2249 (set_window_width, change_window_heights, window_height)
2250 (window_width, CURBEG, CURSIZE, enlarge_window)
2251 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2252 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2253 handled in window.el.
2254 (make_dummy_parent): Rename to make_parent_window and give it a
2255 second argument horflag.
2256 (make_window): Don't set resize_proportionally any more.
2257 (Fsplit_window): Remove. Windows are split in window.el.
2258 (save_restore_action, save_restore_orig_size)
2259 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2260 Resize mini windows in window.el.
2261 (grow_mini_window, shrink_mini_window): Implement by calling
2262 Qresize_root_window_vertically, resize_window_check and
2263 resize_window_apply.
2264 (saved_window, Fset_window_configuration, save_window_save): Do
2265 not handle orig_top_line, orig_total_lines, and
2266 resize_proportionally.
2267 (window_min_height, window_min_width): Move to window.el.
2268 (keys_of_window): Move bindings for delete-other-windows,
2269 split-window, delete-window and enlarge-window to window.el.
2270
2271 * buffer.c: Temporarily extern Qdelete_window.
2272 (Fbury_buffer): Temporarily call Qdelete_window instead of
2273 Fdelete_window (Fbury_buffer will move to window.el soon).
2274
2275 * frame.c (set_menu_bar_lines_1): Remove code handling
2276 orig_top_line and orig_total_lines.
2277
2278 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2279 set_window_height but set heights directly.
2280 (change_frame_size_1): Use resize_frame_windows.
2281
2282 * xdisp.c (init_xdisp): Don't use set_window_height but set
2283 heights directly.
2284
2285 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2286 resize_frame_windows instead of change_window_heights and run
2287 run_window_configuration_change_hook.
2288
2289 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2290 instead of change_window_heights and run
2291 run_window_configuration_change_hook.
2292
1a13852e
MR
22932011-06-09 Martin Rudalics <rudalics@gmx.at>
2294
2295 * window.c (replace_window): Rename second argument REPLACEMENT to
2296 NEW. New third argument SETFLAG. Rewrite.
2297 (delete_window, make_dummy_parent): Call replace_window with
2298 third argument 1.
2299 (window_list_1): Move down in code.
2300 (run_window_configuration_change_hook): Move set_buffer part
2301 before select_frame_norecord part in order to unwind correctly.
2302 Rename count1 to count.
2303 (recombine_windows, delete_deletable_window, resize_root_window)
2304 (Fdelete_other_windows_internal)
2305 (Frun_window_configuration_change_hook, make_parent_window)
2306 (resize_window_check, resize_window_apply, Fresize_window_apply)
2307 (resize_frame_windows, Fsplit_window_internal)
2308 (Fdelete_window_internal, Fresize_mini_window_internal): New
2309 functions.
2310 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2311
f3d1777e
MR
23122011-06-08 Martin Rudalics <rudalics@gmx.at>
2313
496e208e
MR
2314 * window.h (window): Add some new members to window structure -
2315 normal_lines, normal_cols, new_total, new_normal, clone_number,
2316 splits, nest, prev_buffers, next_buffers.
2317 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2318 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2319
f3d1777e
MR
2320 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2321 Remove.
496e208e
MR
2322 (make_dummy_parent): Set new members of windows structure.
2323 (make_window): Move down in code. Handle new members of window
2324 structure.
2325 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2326 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2327 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2328 (Fset_window_prev_buffers, Fwindow_next_buffers)
2329 (Fset_window_next_buffers, Fset_window_clone_number): New
2330 functions.
2331 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2332 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2333 Doc-string fixes.
2334 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2335 Argument WINDOW can be now internal window too.
2336 (Fwindow_use_time): Move up in code.
2337 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2338 Rewrite doc-string.
2339 (Fset_window_configuration, saved_window)
2340 (Fcurrent_window_configuration, save_window_save): Handle new
2341 members of window structure.
b9e809c2
MR
2342 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2343 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2344 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2345 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2346 Qget_mru_window, Qresize_root_window,
2347 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2348 Qauto_buffer_name; staticpro them.
f3d1777e 2349
abde8f8c
MR
23502011-06-07 Martin Rudalics <rudalics@gmx.at>
2351
2352 * window.c (Fwindow_total_size, Fwindow_left_column)
2353 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2354 (Fwindow_list_1): New functions.
2355 (window_box_text_cols): Replace with window_body_cols.
2356 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2357 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2358 (delete_window, Fset_window_configuration): Call
2359 delete_all_subwindows with window as argument.
2360 (delete_all_subwindows): Take a window as argument and not a
2361 structure. Rewrite.
190b47e6
MR
2362 (window_loop): Remove handling of GET_LRU_WINDOW and
2363 GET_LARGEST_WINDOW.
2364 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2365
2366 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2367 window_box_text_cols. delete_all_subwindows now takes a
2368 Lisp_Object as argument.
abde8f8c
MR
2369
2370 * indent.c (compute_motion, Fcompute_motion): Use
2371 window_body_cols instead of window_box_text_cols.
2372
fa8a67e6
MR
2373 * frame.c (delete_frame): Call delete_all_subwindows with root
2374 window as argument.
2375
a54e3482
DC
23762011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2377
2378 * fns.c (Fputhash): Document return value.
2379
60002bf5
CY
23802011-06-06 Chong Yidong <cyd@stupidchicken.com>
2381
2382 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2383
0c671da6 23842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2385
b862a52a 2386 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2387
be44ca6c
PE
2388 Check for overflow when converting integer to cons and back.
2389 * charset.c (Fdefine_charset_internal, Fdecode_char):
2390 Use cons_to_unsigned to catch overflow.
2391 (Fencode_char): Use INTEGER_TO_CONS.
2392 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2393 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2394 * data.c (long_to_cons, cons_to_long): Remove.
2395 (cons_to_unsigned, cons_to_signed): New functions.
2396 These signal an error for invalid or out-of-range values.
2397 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2398 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2399 * font.c (Ffont_variation_glyphs):
2400 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2401 * lisp.h: Include <intprops.h>.
2402 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2403 (cons_to_signed, cons_to_unsigned): New decls.
2404 (long_to_cons, cons_to_long): Remove decls.
2405 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2406 (Fprimitive_undo): Use CONS_TO_INTEGER.
2407 * xfns.c (Fx_window_property): Likewise.
2408 * xselect.c: Include <limits.h>.
2409 (x_own_selection, selection_data_to_lisp_data):
2410 Use INTEGER_TO_CONS.
2411 (x_handle_selection_request, x_handle_selection_clear)
2412 (x_get_foreign_selection, Fx_disown_selection_internal)
2413 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2414 (lisp_data_to_selection_data): Use cons_to_unsigned.
2415 (x_fill_property_data): Use cons_to_signed.
2416 Report values out of range.
2417
d1f3d2af
PE
2418 Check for buffer and string overflow more precisely.
2419 * buffer.h (BUF_BYTES_MAX): New macro.
2420 * lisp.h (STRING_BYTES_MAX): New macro.
2421 * alloc.c (Fmake_string):
2422 * character.c (string_escape_byte8):
2423 * coding.c (coding_alloc_by_realloc):
2424 * doprnt.c (doprnt):
2425 * editfns.c (Fformat):
2426 * eval.c (verror):
2427 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2428 since they may not be the same number.
2429 * editfns.c (Finsert_char):
2430 * fileio.c (Finsert_file_contents):
2431 Likewise for BUF_BYTES_MAX.
2432
dd52fcea
PE
2433 * image.c: Use ptrdiff_t, not int, for sizes.
2434 (slurp_file): Switch from int to ptrdiff_t.
2435 All uses changed.
2436 (slurp_file): Check that file size fits in both size_t (for
2437 malloc) and ptrdiff_t (for sanity and safety).
2438
7f9bbdbb
PE
2439 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2440 if b->modtime has its maximal value.
2441
dfe18f82
PE
2442 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2443
84acfcf0
PE
2444 Don't assume time_t can fit into int.
2445 * buffer.h (struct buffer.modtime): Now time_t, not int.
2446 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2447 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2448
ccd9a01a
PE
2449 Minor fixes for signed vs unsigned integers.
2450 * character.h (MAYBE_UNIFY_CHAR):
2451 * charset.c (maybe_unify_char):
2452 * keyboard.c (read_char, reorder_modifiers):
2453 XINT -> XFASTINT, since the integer must be nonnegative.
2454 * ftfont.c (ftfont_spec_pattern):
2455 * keymap.c (access_keymap, silly_event_symbol_error):
2456 XUINT -> XFASTINT, since the integer must be nonnegative.
2457 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2458 since it makes no difference and we prefer signed.
2459 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2460 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2461 nonnegative.
2462
d6d100dd
SM
24632011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2464
2465 * window.h (Fwindow_frame): Declare.
2466
2b6148e4
PE
24672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2470 (SPARE_MEMORY): Always define.
2471 (LARGE_REQUEST): Remove.
2472 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2473
f230ecc9
MR
24742011-06-06 Martin Rudalics <rudalics@gmx.at>
2475
727e958e
MR
2476 * lisp.h: Move EXFUNS for Fframe_root_window,
2477 Fframe_first_window and Fset_frame_selected_window to window.h.
2478
2479 * window.h: Move EXFUNS for Fframe_root_window,
2480 Fframe_first_window and Fset_frame_selected_window here from
2481 lisp.h.
2482
2483 * frame.c (Fwindow_frame, Fframe_first_window)
2484 (Fframe_root_window, Fframe_selected_window)
2485 (Fset_frame_selected_window): Move to window.c.
2486 (Factive_minibuffer_window): Move to minibuf.c.
2487 (Fother_visible_frames_p): New function.
2488
2489 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2490
f230ecc9
MR
2491 * window.c (decode_window, decode_any_window): Move up in code.
2492 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2493 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2494 (Fwindow_buffer): Move up and rewrite doc-string.
2495 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2496 (Fwindow_prev): New functions.
727e958e
MR
2497 (Fwindow_frame): Move here from frame.c. Accept any window as
2498 argument.
2499 (Fframe_root_window, Fframe_first_window)
2500 (Fframe_selected_window): Move here from frame.c. Accept frame
2501 or arbitrary window as argument. Update doc-strings.
2502 (Fminibuffer_window): Move up in code.
2503 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2504 (Fset_frame_selected_window): Move here from frame.c.
2505 Marginal rewrite.
727e958e
MR
2506 (Fselected_window, select_window, Fselect_window): Move up in
2507 code. Minor doc-string fixes.
f230ecc9 2508
4d09bcf6
PE
25092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2512 Do not assume that spare memory exists; that assumption is valid
2513 only if SYSTEM_MALLOC.
2514 (LARGE_REQUEST): New macro, so that the issue of large requests
2515 is separated from the issue of spare memory.
2516
810928a2
AS
25172011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2518
172418ad
AS
2519 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2520 format. (Bug#8806)
2521
43f862f7
AS
2522 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2523
810928a2
AS
2524 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2525 before statements.
2526
a059fe24
JD
25272011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2528
2529 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2530
2531 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2532
2533 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2534 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2535
989bf368
JB
25362011-06-05 Juanma Barranquero <lekktu@gmail.com>
2537
2538 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2539
4b80f674
CY
25402011-06-04 Chong Yidong <cyd@stupidchicken.com>
2541
2542 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2543 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2544 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2545 New error handlers.
4b80f674
CY
2546 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2547 Obey Vx_select_enable_clipboard_manager. Catch errors in
2548 x_clipboard_manager_save (Bug#8779).
2549 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2550 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2551
99a33b77 25522011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2553
2554 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2555
99a33b77 25562011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2557
2558 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2559 in the current matrix if keep_current_p is non-zero.
2560
8264569d
EZ
25612011-06-04 Eli Zaretskii <eliz@gnu.org>
2562
2563 * bidi.c (bidi_level_of_next_char): Fix last change.
2564
57f97249
EZ
25652011-06-03 Eli Zaretskii <eliz@gnu.org>
2566
fec2107c 2567 Support bidi reordering of text covered by display properties.
57f97249 2568
fec2107c
EZ
2569 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2570 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2571 (bidi_cache_search, bidi_cache_iterator_state)
2572 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2573 (bidi_level_of_next_char, bidi_move_to_visually_next):
2574 Support character positions inside a run of characters covered by a
fec2107c
EZ
2575 display string.
2576 (bidi_paragraph_init, bidi_resolve_explicit_1)
2577 (bidi_level_of_next_char): Call bidi_fetch_char and
2578 bidi_fetch_char_advance instead of FETCH_CHAR and
2579 FETCH_CHAR_ADVANCE.
2580 (bidi_init_it): Initialize new members.
2581 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2582 definitions.
2583 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2584 instead of using explicit *_CHAR codes.
d6d100dd
SM
2585 (bidi_resolve_explicit, bidi_resolve_weak):
2586 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2587 bidirectional text is supported only in multibyte buffers.
2588 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2589 it to initialize the frame_window_p member of struct bidi_it.
2590 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2591 (bidi_resolve_explicit, bidi_resolve_weak)
2592 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2593 bidi_it->nchars is non-positive.
2594 (bidi_level_of_next_char): Don't try to lookup the cache for the
2595 next/previous character if nothing is cached there yet, or if we
2596 were just reseat()'ed to a new position.
c40e2fb2 2597
0e14fe90
EZ
2598 * xdisp.c (set_cursor_from_row): Set start and stop points
2599 according to the row's direction when priming the loop that looks
2600 for the glyph on which to display cursor.
2601 (single_display_spec_intangible_p): Function deleted.
2602 (display_prop_intangible_p): Reimplement to call
2603 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2604 Accept 3 additional arguments needed by handle_display_spec.
2605 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2606 values: lists, `(when COND...)' forms, etc.
2607 (single_display_spec_string_p): Support property values that are
2608 lists with the argument STRING its top-level element.
2609 (display_prop_string_p): Fix the condition for processing a
2610 property that is a list to be consistent with handle_display_spec.
fec2107c 2611 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2612 last portion of handle_display_prop.
2613 (compute_display_string_pos): Accept additional argument
2614 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2615 value of a `display' property is a "replacing spec".
2616 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2617 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2618 the display property, but just return a value indicating whether
2619 the display property will replace the characters it covers.
2620 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2621 frame_window_p members of struct bidi_it.
d6d100dd
SM
2622 (compute_display_string_pos, compute_display_string_end):
2623 New functions.
fec2107c
EZ
2624 (push_it): Accept second argument POSITION, where pop_it should
2625 jump to continue iteration.
2626 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2627
fec2107c
EZ
2628 * keyboard.c (adjust_point_for_property): Adjust the call to
2629 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2630
2631 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2632 (bidi_init_it): Update prototypes.
2633 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2634 (compute_display_string_pos, compute_display_string_end):
2635 Declare prototypes.
fec2107c
EZ
2636 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2637 EMACS_INT.
fc6f18ce 2638
40087514 26392011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2640
57f53182
PE
2641 Malloc failure behavior now depends on size of allocation.
2642 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2643 * lisp.h: Change signatures accordingly.
2644 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2645 All callers changed. (Bug#8762)
2646
2647 * gnutls.c: Use Emacs's memory allocators.
2648 Without this change, the gnutls library would invoke malloc etc.
2649 directly, which causes problems on non-SYNC_INPUT hosts, and which
2650 runs afoul of improving memory_full behavior. (Bug#8761)
2651 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2652 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2653 xfree instead of the default malloc, realloc, free.
2654 (Fgnutls_boot): No need to check for memory allocation failure,
2655 since xmalloc does that for us.
2656
ac32cd99 2657 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2658 * category.c (hash_get_category_set):
2659 * ccl.c (ccl_driver):
2660 * charset.c (Fdefine_charset_internal):
2661 * charset.h (struct charset.hash_index):
2662 * composite.c (get_composition_id, gstring_lookup_cache)
2663 (composition_gstring_put_cache):
2664 * composite.h (struct composition.hash_index):
2665 * dispextern.h (struct image.hash):
2666 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2667 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2668 (hashfn_equal, hashfn_user_defined, make_hash_table)
2669 (maybe_resize_hash_table, hash_lookup, hash_put)
2670 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2671 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2672 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2673 * image.c (make_image, search_image_cache, lookup_image)
2674 (xpm_put_color_table_h):
2675 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2676 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2677 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2678 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2679 * alloc.c (allocate_vectorlike):
2680 Check for overflow in vector size calculations.
2681 * ccl.c (ccl_driver):
2682 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2683 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2684 need to be updated by these changes.
40087514
PE
2685 * fns.c (make_hash_table, maybe_resize_hash_table):
2686 Check for integer overflow with large hash tables.
0de4bb68
PE
2687 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2688 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2689 (SXHASH_REDUCE): New macro.
2690 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2691 Use it instead of discarding useful hash info with large hash values.
2692 (sxhash_float): New function.
2693 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2694 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2695 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2696 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2697 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2698 Adjust signatures to match updated version of code.
2699 (consing_since_gc): Now EMACS_INT, since a single hash table can
2700 use more than INT_MAX bytes.
2701
698d32e2
DN
27022011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2703
2704 Make it possible to build with GCC-4.6+ -O2 -flto.
2705
2706 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2707
fd6fa53f
SM
27082011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2709
2710 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2711 Call minibuffer-inactive-mode.
2712
864db017
JB
27132011-05-31 Juanma Barranquero <lekktu@gmail.com>
2714
2715 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2716 Update dependencies.
2717
2ad0baf4
DN
27182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2719
2720 * data.c (init_data): Remove code for UTS, this system is not
2721 supported anymore.
2722
4fcc2638
DN
27232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2724
2725 Don't force ./temacs to start in terminal mode.
2726
2727 * frame.c (make_initial_frame): Initialize faces in all cases, not
2728 only when CANNOT_DUMP is defined.
2729 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2730
c56e0fd5
DN
27312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2732
2733 * dispnew.c (add_window_display_history): Use const for the string
2734 pointer. Remove declaration, not needed.
2735
333d54da 27362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2737
55d4c1b2 2738 Use 'inline', not 'INLINE'.
333d54da 2739 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2740 * alloc.c, fontset.c (INLINE): Remove.
2741 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2742 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2743 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2744 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2745 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2746
738db178
DN
27472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2748
2749 Make it possible to run ./temacs.
2750
2751 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2752 syms_of_callproc does the same thing. Remove test for
2753 "initialized", do it in the caller.
2754 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2755
620c53a6
SM
27562011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2757
2758 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2759 (read_minibuf): Use get_minibuffer.
2760 (syms_of_minibuf): Use DEFSYM.
2761 (Qmetadata): New var.
2762 * data.c (Qbuffer): Don't make it static.
2763 (syms_of_data): Use DEFSYM.
2764
e003a292
PE
27652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2766
2767 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2768 (CCL_CODE_MIN): New macro.
2769
ed008a6d
PE
27702011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2771
3687c2ef
PE
2772 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2773
ed008a6d
PE
2774 * eval.c (Qdebug): Now static.
2775 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2776 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2777 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2778
d66c4c7c
CY
27792011-05-29 Chong Yidong <cyd@stupidchicken.com>
2780
2781 * image.c: Various fixes to ImageMagick code comments.
2782 (Fimagemagick_types): Doc fix.
2783
5fbc2025
PE
27842011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2785
0196f88a
PE
2786 Minor fixes prompted by GCC 4.6.0 warnings.
2787
2788 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2789
5fbc2025
PE
2790 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2791 (x_clipboard_manager_save_all): Move extern decl to ...
2792 * xterm.h: ... here, so that it can be checked for consistency.
2793
1dd3c2d9
CY
27942011-05-29 Chong Yidong <cyd@stupidchicken.com>
2795
2796 * xselect.c (x_clipboard_manager_save_frame)
2797 (x_clipboard_manager_save_all): New functions.
2798 (Fx_clipboard_manager_save): Lisp function deleted.
2799
2800 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2801 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2802
2803 * xterm.h: Update prototype.
2804
5ba6571d
WX
28052011-05-28 William Xu <william.xwl@gmail.com>
2806
2807 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2808 exiting (Bug#8239).
2809
3eaff834
JM
28102011-05-28 Jim Meyering <meyering@redhat.com>
2811
e1900994 2812 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2813 * fns.c (to_uchar): Define.
2814 (crypto_hash_function): Use it to convert some newly-signed
2815 variables to unsigned, to avoid sign-extension bugs. For example,
2816 without this change, (md5 "truc") would evaluate to
2817 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2818 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2819 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2820
0f6990a7
PE
28212011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 Integer overflow fixes.
c8a9ca5a 2824
08686060
PE
2825 * dbusbind.c: Serial number integer overflow fixes.
2826 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2827 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2828 to hold a serial number that is too large for a fixnum.
2829 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2830 Check for serial numbers out of range. Decode any serial number
59568bf0 2831 that was so large that it became a float. (Bug#8722)
08686060 2832
2d1fc3c7
PE
2833 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2834 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2835 Use XFASTINT rather than XUINT when numbers are nonnegative.
2836 (xd_append_arg, Fdbus_method_return_internal):
2837 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2838 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2839 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2840 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2841 (Bug#8722)
2d1fc3c7 2842
c8a9ca5a
PE
2843 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2844
519e1d69
PE
2845 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2846
30569699
PE
2847 ccl: add integer overflow checks
2848 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2849 (IN_INT_RANGE): New macros.
2850 (ccl_driver): Use them to check for integer overflow when
2851 decoding a CCL program. Many of the new checks are whether XINT (x)
2852 fits in int; it doesn't always, on 64-bit hosts. The new version
2853 doesn't catch all possible integer overflows, but it's an
847044ea 2854 improvement. (Bug#8719)
30569699 2855
c11285dc
PE
2856 * alloc.c (make_event_array): Use XINT, not XUINT.
2857 There's no need for unsigned here.
2858
fdccd48e
PE
2859 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2860 This follows up to the 2011-05-06 change that substituted uintptr_t
2861 for EMACS_INT. This case wasn't caught back then.
2862
37910ab2
PE
2863 Rework Fformat to avoid integer overflow issues.
2864 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2865 now (part of C89). Include <verify.h>.
2866 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2867 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2868 (Fformat): Avoid the prepass trying to compute sizes; it was only
2869 approximate and thus did not catch overflow reliably. Instead, walk
2870 through the format just once, formatting and computing sizes as we go,
2871 checking for integer overflow at every step, and allocating a larger
2872 buffer as needed. Keep track separately whether the format is
2873 multibyte. Keep only the most-recently calculated precision, rather
2874 than them all. Record whether each argument has been converted to
2875 string. Use EMACS_INT, not int, for byte and char and arg counts.
2876 Support field widths and precisions larger than INT_MAX. Avoid
2877 sprintf's undefined behavior with conversion specifications such as %#d
2878 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2879 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2880 formatting out-of-range floating point numbers with int
9173deec 2881 formats. (Bug#8668)
37910ab2 2882
2e6578fb
PE
2883 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2884
0ae6bdee
PE
2885 * data.c: Avoid integer truncation in expressions involving floats.
2886 * data.c: Include <intprops.h>.
2887 (arith_driver): When there's an integer overflow in an expression
2888 involving floating point, convert the integers to floating point
2889 so that the resulting value does not suffer from catastrophic
2890 integer truncation. For example, on a 64-bit host (* 4
2891 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2892 Do not rely on undefined behavior after integer overflow.
2893
de883a70
PE
2894 merge count_size_as_multibyte, parse_str_to_multibyte
2895 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2896 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2897 Check for integer overflow.
2898 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2899 since it's now a duplicate of the other. This is more of
2900 a character than a buffer op, so better that it's in character.c.
2901 * fns.c, print.c: Adjust to above changes.
2902
2ff916cb
PE
29032011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2904
2905 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2906
f1b54466
PE
29072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2908
fb1ac845
PE
2909 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2910 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2911 (x_clipboard_manager_save): Now static.
2912 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2913
f1b54466
PE
2914 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2915 (crypto_hash_function): Now static.
2916 Fix pointer signedness problems. Avoid unnecessary initializations.
2917
a9f737ee
CY
29182011-05-27 Chong Yidong <cyd@stupidchicken.com>
2919
2920 * termhooks.h (Vselection_alist): Make it terminal-local.
2921
2922 * terminal.c (create_terminal): Initialize it.
2923
2924 * xselect.c: Support for clipboard managers.
2925 (Vselection_alist): Move to termhooks.h as terminal-local var.
2926 (LOCAL_SELECTION): New macro.
2927 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2928 (symbol_to_x_atom): Remove gratuitous arg.
2929 (x_handle_selection_request, lisp_data_to_selection_data)
2930 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2931 (x_own_selection, x_get_local_selection, x_convert_selection):
2932 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2933 (some_frame_on_display): Delete unused function.
2934 (Fx_own_selection_internal, Fx_get_selection_internal)
2935 (Fx_disown_selection_internal, Fx_selection_owner_p)
2936 (Fx_selection_exists_p): New optional frame arg.
2937 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2938 (x_handle_selection_clear): Don't treat other terminals with the
2939 same keyboard specially. Use the terminal-local Vselection_alist.
2940 (x_clear_frame_selections): Use Frun_hook_with_args.
2941
2942 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2943
2944 * xterm.h: Add support for those atoms.
2945
e067f0c1
CY
29462011-05-26 Chong Yidong <cyd@stupidchicken.com>
2947
2948 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2949 (converted_selections, conversion_fail_tag): New global variables.
2950 (x_selection_request_lisp_error): Free the above.
2951 (x_get_local_selection): Remove unnecessary code.
2952 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2953 of converted selections stored in converted_selections.
2954 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2955 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2956 (x_convert_selection): New function.
2957 (x_handle_selection_event): Simplify.
2958 (x_get_foreign_selection): Don't ignore incoming requests while
2959 waiting for an answer; this will fail when we implement
2960 SAVE_TARGETS, and seems unnecessary anyway.
2961 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2962 (Vx_sent_selection_functions): Doc fix.
2963
0f4aebc0
LL
29642011-05-26 Leo Liu <sdl.web@gmail.com>
2965
2966 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2967
e61124cd
YM
29682011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2969
2970 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2971
2972 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2973 for fringe update if it has periodic bitmap.
ac389d0c 2974 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2975 and fringe_bitmap_periodic_p.
2976
2977 * fringe.c (get_fringe_bitmap_data): New function.
2978 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2979 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2980 row. Mark glyph row for fringe update if periodicity changed.
2981
2982 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2983 for fringe update unless it has periodic bitmap.
2984
f16d9837
KH
29852011-05-25 Kenichi Handa <handa@m17n.org>
2986
2987 * xdisp.c (get_next_display_element): Set correct it->face_id for
2988 a static composition.
2989
e1b90ef6
LL
29902011-05-24 Leo Liu <sdl.web@gmail.com>
2991
2992 * deps.mk (fns.o):
2993 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2994
2995 * fns.c (crypto_hash_function, Fsha1): New function.
2996 (Fmd5): Use crypto_hash_function.
2997 (syms_of_fns): Add Ssha1.
2998
7400048f
PE
29992011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 * gnutls.c: Remove unused macros.
3002 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3003 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3004 Remove macros that are defined and never used.
3005 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3006
abb71cf4
CY
30072011-05-22 Chong Yidong <cyd@stupidchicken.com>
3008
3009 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3010 (Fx_get_selection_internal): Minor cleanup.
3011 (Fx_own_selection_internal): Rename arguments for consistency with
3012 select.el.
3013
6307db39
PE
30142011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3015
3016 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3017
f3d4e0a4
CY
30182011-05-22 Chong Yidong <cyd@stupidchicken.com>
3019
3020 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3021
4d8ade89
YM
30222011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3023
3024 * dispnew.c (scrolling_window): Don't exclude the case that the
3025 last enabled row in the desired matrix touches the bottom boundary.
3026
32078c8d
GM
30272011-05-21 Glenn Morris <rgm@gnu.org>
3028
3029 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3030 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3031 and add some more files.
32078c8d 3032
7285dc67
EZ
30332011-05-20 Eli Zaretskii <eliz@gnu.org>
3034
3035 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3036 report_file_error introduced by the change from 2011-05-07.
3037
89d1bd22
PE
30382011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 * systime.h (Time): Define only if emacs is defined.
3041 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3042 where the include path doesn't have X11/X.h by default. See
3043 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3044
e23640bb 30452011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3046
3047 * composite.c (find_automatic_composition): Fix previous change.
3048
b9704ad9
GM
30492011-05-20 Glenn Morris <rgm@gnu.org>
3050
3051 * lisp.mk: New file, split from Makefile.in.
3052 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3053 (shortlisp): Remove.
3054 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3055
4a720484
GM
30562011-05-19 Glenn Morris <rgm@gnu.org>
3057
3058 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3059 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3060 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3061 (lisp): Set the order to that of loadup.el.
3062 (shortlisp): Make it a copy of $lisp.
3063 (SOME_MACHINE_LISP): Remove.
3064 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3065 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3066
a28d4396
KH
30672011-05-18 Kenichi Handa <handa@m17n.org>
3068
3069 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3070 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3071 (find_automatic_composition): Mostly rewrite for efficiency.
3072
a2b1fa8e
JB
30732011-05-18 Juanma Barranquero <lekktu@gmail.com>
3074
3075 * makefile.w32-in: Update dependencies.
3076
8e1f5610
CS
30772011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3078
3079 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3080 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3081
7025ee00 30822011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3083
cdfa6eab
PE
3084 Fix some integer overflow issues, such as string length overflow.
3085
06d6db33
PE
3086 * insdel.c (count_size_as_multibyte): Check for string overflow.
3087
2b4560a8
PE
3088 * character.c (lisp_string_width): Check for string overflow.
3089 Use EMACS_INT, not int, for string indexes and lengths; in
3090 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3091 the resulting string length overflows an EMACS_INT; instead,
3092 report a string overflow if no precision given. When checking for
3093 precision exhaustion, use a check that cannot possibly have
3094 integer overflow. (Bug#8675)
3095 * character.h (lisp_string_width): Adjust to new signature.
3096
cb93f9be
PE
3097 * alloc.c (string_overflow): New function.
3098 (Fmake_string): Use it. This doesn't change behavior, but saves
3099 a few bytes and will simplify future changes.
3100 * character.c (string_escape_byte8): Likewise.
3101 * lisp.h (string_overflow): New decl.
3102
1a1f3366
PE
3103 Fixups, following up to the user-interface timestamp change.
3104 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3105 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3106 * msdos.c (mouse_get_pos): Likewise.
3107 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3108 * w32gui.h (Time): Define by including "systime.h" rather than by
3109 declaring it ourselves. (Bug#8664)
3110
d4e3e4d3
PE
3111 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3112 * image.c (clear_image_cache): Likewise.
3113
f6a24d19
PE
3114 * term.c (term_mouse_position): Don't assume time_t wraparound.
3115
08dc5ae6
PE
3116 Be more systematic about user-interface timestamps.
3117 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3118 and sometimes 'EMACS_UINT', to represent these timestamps.
3119 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3120 This makes the code easier to follow, and makes it easier to catch
3121 integer overflow bugs such as Bug#8664.
3122 * frame.c (Fmouse_position, Fmouse_pixel_position):
3123 Use Time, not unsigned long, for user-interface timestamps.
3124 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3125 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3126 * keyboard.h (last_event_timestamp): Likewise.
3127 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3128 * menu.h (xmenu_show): Likewise.
3129 * term.c (term_mouse_position): Likewise.
3130 * termhooks.h (struct input_event.timestamp): Likewise.
3131 (struct terminal.mouse_position_hook): Likewise.
3132 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3133 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3134 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3135 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3136 what it was before.
3137 * menu.h, termhooks.h: Include "systime.h", for Time.
3138
8e55734a
PE
3139 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3140 Don't assume that the difference between two unsigned long values
3141 can fit into an integer. At this point, we know button_down_time
3142 <= event->timestamp, so the difference must be nonnegative, so
3143 there's no need to cast the result if double-click-time is
3144 nonnegative, as it should be; check that it's nonnegative, just in
3145 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3146 apart (about 25 days). (Bug#8664)
8e55734a 3147
841f1b75 3148 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3149 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3150
3e26f69c
PE
3151 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3152 that always fit in int. Use a sentinel instead of a counter, to
3153 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3154 * frame.h (struct frame): Use int for menu_bar_items_used
3155 instead of EMACS_INT, since it always fits in int.
3e26f69c 3156
5cc152c0
PE
3157 * menu.c (grow_menu_items): Check for int overflow.
3158
d89eb65e
PE
3159 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3160
5235bd3e
PE
3161 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3162 Before, the code was not consistent. These values cannot exceed
3163 2**31 - 1 so there's no need to make them unsigned.
3164 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3165 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3166 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3167 as modifiers.
3168 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3169
bc827e23
PE
3170 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3171 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3172 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3173 presumably because the widths might not match.
3174
78eb494e
PE
3175 * window.c (size_window): Avoid needless test at loop start.
3176
04f2d78b
CB
31772011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3178
3179 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3180
d2fc7e3d 31812011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3182
3183 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3184
d2fc7e3d 31852011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3186
3187 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3188 `width' to `bar_area_x' and `bar_area_width', respectively.
3189 (x_scroll_run): Take account of fringe background extension.
3190
04f2d78b
CB
3191 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3192 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3193 `bar_area_width', respectively.
3194 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3195 background extension.
3196
79b70037
GM
31972011-05-10 Jim Meyering <meyering@redhat.com>
3198
3199 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3200
2f142cc5
JB
32012011-05-10 Juanma Barranquero <lekktu@gmail.com>
3202
3203 * image.c (Finit_image_library): Return t for built-in image types,
3204 like pbm and xbm. (Bug#8640)
3205
57679c86
AS
32062011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3207
3208 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3209
888c9e86
EZ
32102011-05-07 Eli Zaretskii <eliz@gnu.org>
3211
b0512a1d
EZ
3212 * w32console.c (Fset_screen_color): Doc fix.
3213 (Fget_screen_color): New function.
3214 (syms_of_ntterm): Defsubr it.
3215
7285dc67
EZ
3216 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3217 unlink the temporary file if Fcall_process didn't create it in the
3218 first place.
3219 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3220 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3221 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3222 cue to call_process_cleanup not to close that handle.
3223
4d3fcc8e
BK
32242011-05-07 Ben Key <bkey76@gmail.com>
3225
3226 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3227 one of two shell specific rules, either bootstrap-temacs-CMD or
3228 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3229 to the previous implementation of the bootstrap-temacs rule.
3230 The bootstrap-temacs-CMD rule is similar to the previous
3231 implementation of the bootstrap-temacs rule except that it
3232 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3233 variable.
3234
3235 These changes, along with some changes to nt/configure.bat,
3236 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3237 earlier fix to add support for --cflags and --ldflags options
3238 that include quotes so that it works whether make uses cmd or
3239 sh as the shell.
3240
b4289b64
MA
32412011-05-06 Michael Albinus <michael.albinus@gmx.de>
3242
3243 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3244 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3245 is a constant.
3246 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3247 a string. Handle both cases.
3248 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3249 (Fdbus_register_method): Use Qinvalid_function.
3250
af4c0e28
JB
32512011-05-06 Juanma Barranquero <lekktu@gmail.com>
3252
3253 * makefile.w32-in: Update dependencies.
3254 (LISP_H): Add inttypes.h and stdin.h.
3255 (PROCESS_H): Add unistd.h.
3256
c51453d9
EZ
32572011-05-06 Eli Zaretskii <eliz@gnu.org>
3258
3259 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3260 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3261
8ff0ac3c 32622011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3263
4c4b566b
PE
3264 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3265
aab2b9b5
PE
3266 * term.c (vfatal): Remove stray call to va_end.
3267 It's not needed and the C Standard doesn't allow it here anyway.
3268
c378da0b
PE
3269 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3270 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3271
288b08c7
PE
3272 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3273 bytes.
3274
e3601888
PE
3275 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3276
db6c0e74
PE
3277 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3278
dd5963ea
PE
3279 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3280
88c9450f
PE
3281 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3282
2f9442b8
PE
3283 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3284
c032b5f8
PE
3285 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3286 * charset.c (Fdefine_charset_internal): Don't initialize
3287 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3288 32-bit int (Bug#8600).
a108c10b
PE
3289
3290 * lread.c (read_integer): Be more consistent with string-to-number.
3291 Use string_to_number to do the actual conversion; this avoids
3292 rounding errors and fixes some other screwups. Without this fix,
3293 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3294 (digit_to_number): Move earlier, for benefit of read_integer.
3295 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3296 not a digit in any supported base. (Bug#8602)
a108c10b 3297
ad5f9eea
PE
3298 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3299
aec1708a
PE
3300 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3301 to match comment at start of function. This also removes a
3302 GCC warning about overflow in a 32+64-bit port.
3303
47be4ab5
PE
3304 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3305
371cac43
PE
3306 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3307 Reported by Stefan Monnier in
3308 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3309 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3310 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3311
d01a7826
PE
3312 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3313 (EMACS_UINTPTR): Likewise, with uintptr_t.
3314
7fd47d5c
PE
3315 * lisp.h: Prefer 64-bit EMACS_INT if available.
3316 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3317 on 32-bit hosts that have 64-bit int, so that they can access
3318 large files.
122b0c86
PE
3319 However, temporarily disable this change unless the temporary
3320 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3321
8727937b
PE
3322 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3323
8ac068ac
PE
3324 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3325 This removes an assumption that EMACS_INT and long are the same
3326 width as pointers. The assumption is true for Emacs porting targets
3327 now, but we want to make other targets possible.
3328 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3329 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3330 In the rest of the code, change types of integers that hold casted
3331 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3332 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3333 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3334 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3335 No need to cast type when ORing.
3336 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3337 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3338 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3339 assume EMACS_INT is the same width as char *.
3340 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3341 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3342 Remove no-longer-needed casts.
3343 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3344 (xg_tool_bar_help_callback, xg_make_tool_item):
3345 Use EMACS_INTPTR to hold an integer
3346 that will be cast to void *; this can avoid a GCC warning
3347 if EMACS_INT is not the same width as void *.
3348 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3349 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3350 (current_message_1, set_message_1):
3351 Use a local to convert to proper width without a cast.
3352 * xmenu.c (dialog_selection_callback): Likewise.
3353
ede49d71
PE
3354 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3355 Also, don't assume VALBITS / RAND_BITS is less than 5,
3356 and don't rely on undefined behavior when shifting a 1 left into
3357 the sign bit.
3358 * lisp.h (get_random): Change signature to match.
3359
2f30ecd0
PE
3360 * lread.c (hash_string): Use size_t, not int, for hash computation.
3361 Normally we prefer signed values; but hashing is special, because
3362 it's better to use unsigned division on hash table sizes so that
3363 the remainder is nonnegative. Also, size_t is the natural width
3364 for hashing into memory. The previous code used 'int', which doesn't
3365 retain enough info to hash well into very large tables.
3366 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3367
2a866e7b
PE
3368 * dbusbind.c: Don't possibly lose pointer info when converting.
3369 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3370 Use XPNTR rather than XHASH, so that the high-order bits of
3371 the pointer aren't lost when converting through void *.
3372
51639eac
PE
3373 * eval.c (Fautoload): Don't double-shift a pointer.
3374
92394119
PE
3375 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3376
dbdb9a7c
JB
33772011-05-06 Juanma Barranquero <lekktu@gmail.com>
3378
3379 * gnutls.c (DEF_GNUTLS_FN):
3380 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3381
db7a0b4f
AS
33822011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3383
3384 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3385 marker. (Bug#8610)
3386
f7ff1b0f 33872011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3388
3389 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3390 New version that can reserve upto 2GB of heap space.
3391
f7ff1b0f 33922011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3393
3394 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3395
639c109b
TZ
33962011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3397
3398 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3399 `gnutls_certificate_set_x509_key_file'.
3400
d2127135
JB
34012011-05-05 Juanma Barranquero <lekktu@gmail.com>
3402
3403 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3404 Update dependencies.
3405
e968f4f3
JB
34062011-05-04 Juanma Barranquero <lekktu@gmail.com>
3407
3408 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3409 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3410 Remove unused parameter `fildes'.
3411 * process.c (read_process_output, send_process): Don't pass it.
3412
84d358f0
JB
34132011-05-04 Juanma Barranquero <lekktu@gmail.com>
3414
3415 Fix previous change: the library cache is defined in w32.c.
3416 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3417 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3418
0898ca10
JB
34192011-05-04 Juanma Barranquero <lekktu@gmail.com>
3420
3421 Implement dynamic loading of GnuTLS on Windows.
3422
3423 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3424 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3425 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3426 Declare.
3427
3428 * gnutls.c (Qgnutls_dll): Define.
3429 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3430 (gnutls_*): Declare function pointers.
3431 (init_gnutls_functions): New function to initialize function pointers.
3432 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3433 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3434 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3435 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3436 (emacs_gnutls_write, emacs_gnutls_read)
3437 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3438 (Fgnutls_available_p): New function.
3439 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3440 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3441 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3442
3443 * image.c: Include w32.h.
3444 (Vimage_type_cache): Delete.
3445 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3446 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3447 (w32_delayed_load): Move to w32.c.
3448
3449 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3450
3451 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3452 (w32_delayed_load): Move from image.c. When loading a library, record
3453 its filename in the :loaded-from property of the library id.
3454 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3455 Initialize and staticpro them.
3456 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3457
3458 * process.c: Include lisp.h before w32.h, not after.
3459 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3460 instead of gnutls_record_check_pending.
3461
3462 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3463
ff4de4aa
TZ
34642011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3465
3466 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3467 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3468 as passed in.
3469
abe95abb
JD
34702011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3471
3472 * xterm.c (x_set_frame_alpha): Do not set property on anything
3473 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3474
e16e55d4
JB
34752011-05-02 Juanma Barranquero <lekktu@gmail.com>
3476
3477 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3478
bafcf6a5
JB
34792011-05-02 Juanma Barranquero <lekktu@gmail.com>
3480
3481 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3482 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3483 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3484 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3485 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3486 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3487 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3488 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3489 (Qgnutls_bootprop_callbacks_verify): Make static.
3490
e7a6747f
AS
34912011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3492
19ed11ba
AS
3493 * callproc.c: Indentation fixup.
3494
e7a6747f 3495 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3496 (wait_for_termination, interruptible_wait_for_termination):
3497 Move after wait_for_termination_1.
e7a6747f 3498
1ef14cb4
LMI
34992011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3500
3501 * sysdep.c (interruptible_wait_for_termination): New function
3502 which is like wait_for_termination, but allows keyboard
3503 interruptions.
3504
3505 * callproc.c (Fcall_process): Add (:file "file") as an option for
3506 the STDOUT buffer.
3507 (Fcall_process_region): Ditto.
3508
330d880c
EZ
35092011-04-30 Eli Zaretskii <eliz@gnu.org>
3510
8db90b73
EZ
3511 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3512 rather than `XVECTOR (FOO)->size'.
3513
330d880c
EZ
3514 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3515 inttypes.h, as a gnulib replacement is used if it not available in
3516 system headers.
3517
15cbd324
EZ
35182011-04-21 Eli Zaretskii <eliz@gnu.org>
3519
3520 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3521 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3522 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3523
3524 * coding.c (coding_alloc_by_realloc): Error out if destination
3525 will grow beyond MOST_POSITIVE_FIXNUM.
3526 (decode_coding_emacs_mule): Abort if there isn't enough place in
3527 charbuf for the composition carryover bytes. Reserve an extra
3528 space for up to 2 characters produced in a loop.
3529 (decode_coding_iso_2022): Abort if there isn't enough place in
3530 charbuf for the composition carryover bytes.
3531
35322011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3533
ae940cca
EZ
3534 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3535 aborting when %lld or %lll format is passed.
3536 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3537 %llo or %llx format is passed. (Bug#8545)
3538
03ab8921
EZ
3539 * window.c (window_scroll_line_based): Use a marker instead of
3540 simple variables to record original value of point. (Bug#7952)
3541
afda1437
EZ
3542 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3543 produced by %s or %c overflows available buffer space. (Bug#8545)
3544
f76dee0c
PE
35452011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3546
3547 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3548 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3549
fdc5744d
JB
35502011-04-28 Juanma Barranquero <lekktu@gmail.com>
3551
3552 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3553
638f053a
JB
35542011-04-28 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * keyboard.c (Qdelayed_warnings_hook): Define.
3557 (command_loop_1): Run `delayed-warnings-hook'
3558 if Vdelayed_warnings_list is non-nil.
3559 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3560 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3561
d178f871
EZ
35622011-04-28 Eli Zaretskii <eliz@gnu.org>
3563
3564 * doprnt.c (doprnt): Don't return value smaller than the buffer
3565 size if the message was truncated. (Bug#8545).
3566
b124fd93
JB
35672011-04-28 Juanma Barranquero <lekktu@gmail.com>
3568
3569 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3570 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3571
e810457d
PE
35722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3573
3574 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3575
ea51cceb
JB
35762011-04-27 Juanma Barranquero <lekktu@gmail.com>
3577
3578 * makefile.w32-in: Update dependencies.
3579
94dcfacf
EZ
35802011-04-27 Eli Zaretskii <eliz@gnu.org>
3581
3582 Improve `doprnt' and its usage. (Bug#8545)
3583 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3584 `format_end'. Remove support for %l as a conversion specifier.
3585 Don't use xrealloc. Improve diagnostics when the %l size modifier
3586 is used. Update the commentary.
3587
3588 * eval.c (verror): Simplify calculation of size_t.
3589
3590 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3591 messages.
3592
f61f41d7
PE
35932011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3594
3595 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3596 change.
3597
96fb4434
PE
35982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3599
3600 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3601 This makes this file independent of the recent pseudovector change.
3602
671875da 36032011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3604
69e9b5a3
PE
3605 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3606
b5f869a7 3607 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3608 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3609 Remove unused local.
c8926152 3610 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3611
841a1577 3612 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3613 GCC 4.6.0 optimizes based on type-based alias analysis.
3614 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3615 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3616 != &v->size, and therefore "v->size = 1; b->size = 2; return
3617 v->size;" must therefore return 1. This assumption is incorrect
3618 for Emacs, since it type-puns struct Lisp_Vector * with many other
3619 types. To fix this problem, this patch adds a new type struct
f904488f 3620 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3621 and pseudovectors, and helps optimizing compilers not get fooled
3622 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3623 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3624 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3625 the size member.
eab3844f
PE
3626 (XSETPVECTYPE): Rewrite in terms of new macro.
3627 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3628 This is a bit clearer, and further avoids the possibility of
3629 undesirable aliasing.
3630 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3631 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3632 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3633 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3634 (ASIZE): Now uses header.size rather than size.
3635 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3636 to avoid the hassle of writing XVECTOR (foo)->header.size.
3637 (struct vectorlike_header): New type.
eab3844f
PE
3638 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3639 object, to help avoid aliasing.
3640 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3641 (SUBRP): Likewise, since Lisp_Subr is a special case.
3642 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3643 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3644 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3645 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3646 changed to be "header.size" and "header.next".
3647 * buffer.h (struct buffer): Likewise.
3648 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3649 * frame.h (struct frame): Likewise.
3650 * process.h (struct Lisp_Process): Likewise.
3651 * termhooks.h (struct terminal): Likewise.
3652 * window.c (struct save_window_data, struct saved_window): Likewise.
3653 * window.h (struct window): Likewise.
3654 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3655 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3656 * buffer.c (init_buffer_once): Likewise.
3657 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3658 special case.
3659 * process.c (Fformat_network_address): Use local var for size,
3660 for brevity.
3661
0df1eac5
PE
3662 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3663
847ab9d1 3664 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3665 * data.c (atof): Remove decl; no longer used or needed.
3666 (digit_to_number): Move to lread.c.
3667 (Fstring_to_number): Use new string_to_number function, to be
3668 consistent with how the Lisp reader treats infinities and NaNs.
3669 Do not assume that floating-point numbers represent EMACS_INT
3670 without losing information; this is not true on most 64-bit hosts.
3671 Avoid double-rounding errors, by insisting on integers when
3672 parsing non-base-10 numbers, as the documentation specifies.
3673 * lisp.h (string_to_number): New decl, replacing ...
3674 (isfloat_string): Remove.
bc0a5c13 3675 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3676 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3677 appears to have been a coding error. Similarly, do not accept
3678 strings like +-1e0 as floating point numbers. Do not report
3679 overflow for integer overflows unless the base is not 10 which
3680 means we have no simple and reliable way to continue.
3681 Break out the floating-point parsing into a new
3682 function string_to_number, so that Fstring_to_number parses
3683 floating point numbers consistently with the Lisp reader.
04f2d78b 3684 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3685 (E_CHAR, EXP_INT): Remove, replacing with ...
3686 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3687 (string_to_number): New function, replacing isfloat_string.
3688 This function checks for valid syntax and produces the resulting
3689 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3690 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3691 so that overflow for non-base-10 numbers is reported only when
3692 there's no portable and simple way to convert to floating point.
452f4150 3693
67769ffc
PE
3694 * textprop.c (set_text_properties_1): Rewrite for clarity,
3695 and to avoid GCC warning about integer overflow.
3696
c20db43f
PE
3697 * intervals.h (struct interval): Use EMACS_INT for members
3698 where EMACS_UINT might cause problems. See
3699 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3700 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3701 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3702 All uses changed.
37aa2f85
PE
3703 (offset_intervals): Tell GCC not to worry about length overflow
3704 when negating a negative length.
c20db43f 3705
2538aa2f
PE
3706 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3707 (overrun_check_free): Likewise.
3708
f2d3008d
PE
3709 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3710 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3711 word size.
3712
ec8df744
PE
3713 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3714 (gnutls_make_error): Rename local to avoid shadowing.
3715 (gnutls_emacs_global_deinit): ifdef out; not used.
3716 (Fgnutls_boot): Use const for pointer to readonly storage.
3717 Comment out unused local. Fix pointer signedness problems.
3718
640ee02d
PE
3719 * lread.c (openp): Don't stuff size_t into an 'int'.
3720 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3721 about possible signed overflow.
3722
6048fb2a
PE
3723 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3724 (GDK_KEY_g): Don't define if already defined.
3725 (xg_prepare_tooltip): Avoid pointer signedness problem.
3726 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3727
fa3c87e1
PE
3728 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3729 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3730
2172544b
PE
3731 * xfns.c (Fx_window_property): Simplify a bit,
3732 to make a bit faster and to avoid GCC 4.6.0 warning.
3733 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3734
9b821a21
PE
3735 * fns.c (internal_equal): Don't assume size_t fits in int.
3736
3c616cfa
PE
3737 * alloc.c (compact_small_strings): Tighten assertion a little.
3738
c2982e87
PE
3739 Replace pEd with more-general pI, and fix some printf arg casts.
3740 * lisp.h (pI): New macro, generalizing old pEd macro to other
3741 conversion specifiers. For example, use "...%"pI"d..." rather
3742 than "...%"pEd"...".
3743 (pEd): Remove. All uses replaced with similar uses of pI.
3744 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3745 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3746 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3747 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3748 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3749 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3750 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3751 64-bit hosts.
3752 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3753 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3754 * print.c (safe_debug_print, print_object): Likewise.
3755 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3756 to int.
6f04d126
PE
3757 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3758 avoiding the 0 flag, which is not portable.
c2982e87
PE
3759 * process.c (Fmake_network_process): Use pI to avoid cast.
3760 * region-cache.c (pp_cache): Likewise.
3761 * xdisp.c (decode_mode_spec): Likewise.
3762 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3763 behavior on 64-bit hosts with printf arg.
6f04d126 3764 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3765 (x_stop_queuing_selection_requests): Likewise.
3766 (x_get_window_property): Don't truncate byte count to an 'int'
3767 when tracing.
0b432f21 3768
5e073ec7
PE
3769 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3770 here, since it parses constructs like leading '-' and spaces,
3771 which are not wanted; and it overflows with large numbers.
3772 Instead, simply match F[0-9]+, which is what is wanted anyway.
3773
36372bf9
PE
3774 * alloc.c: Remove unportable assumptions about struct layout.
3775 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3776 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3777 (allocate_vectorlike, make_pure_vector): Use the new macros,
3778 plus offsetof, to remove unportable assumptions about struct layout.
3779 These assumptions hold on all porting targets that I know of, but
3780 they are not guaranteed, they're easy to remove, and removing them
3781 makes further changes easier.
3782
0b432f21
PE
3783 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3784 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3785 (string_overrun_cookie): Now const. Use initializers that
3786 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3787 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3788 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3789 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3790 multiple of sizeof (EMACS_INT); it need not be, if
3791 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3792 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3793
895009e1
JB
37942011-04-26 Juanma Barranquero <lekktu@gmail.com>
3795
3796 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3797
6a7a1b0b
TZ
37982011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3799
3800 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3801 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3802 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3803
841a1577 38042011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3805
3806 * lisp.h (Qdebug): List symbol.
895009e1 3807 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3808 * keyboard.c (debug-on-event): New variable.
3809 (handle_user_signal): Break into debugger when debug-on-event
3810 matches the current signal symbol.
3811
f2d3ba6f
DN
38122011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3813
3814 * alloc.c (check_sblock, check_string_bytes)
3815 (check_string_free_list): Convert to standard C.
3816
42ce4c63
TZ
38172011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3818
3819 * w32.c (emacs_gnutls_push): Fix typo.
3820
825cd63c
EZ
38212011-04-25 Eli Zaretskii <eliz@gnu.org>
3822
fb11d64d
EZ
3823 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3824 "cast to pointer from integer of different size".
3825
825cd63c
EZ
3826 Improve doprnt and its use in verror. (Bug#8545)
3827 * doprnt.c (doprnt): Document the set of format control sequences
3828 supported by the function. Use SAFE_ALLOCA instead of always
3829 using `alloca'.
3830
3831 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3832 is one byte too soon. Don't use xrealloc; instead xfree and
3833 xmalloc anew.
3834
e061a11b
TZ
38352011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3836
3837 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3838 callbacks stage.
3839
3840 * gnutls.c: Renamed global_initialized to
3841 gnutls_global_initialized. Added internals for the
3842 :verify-hostname-error, :verify-error, and :verify-flags
3843 parameters of `gnutls-boot' and documented those parameters in the
3844 docstring. Start callback support.
9173deec
JB
3845 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3846 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3847 on error. Return error code.
e061a11b
TZ
3848 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3849 (emacs_gnutls_read): Likewise.
3850 (Fgnutls_boot): Return handshake error code.
3851 (emacs_gnutls_handle_error): New function.
3852 (wsaerror_to_errno): Likewise.
3853
3854 * w32.h (emacs_gnutls_pull): Add prototype.
3855 (emacs_gnutls_push): Likewise.
3856
3857 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3858 (emacs_gnutls_push): Likewise.
3859
38602011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3861
3862 * process.c (wait_reading_process_output): Check if GnuTLS
3863 buffered some data internally if no FDs are set for TLS
3864 connections.
3865
3866 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3867 (LIBS): Link to USER_LIBS.
3868 ($(BLD)/gnutls.$(0)): New target.
3869
fa6996bc
EZ
38702011-04-24 Eli Zaretskii <eliz@gnu.org>
3871
eb35682e
EZ
3872 * xdisp.c (handle_single_display_spec): Rename the
3873 display_replaced_before_p argument into display_replaced_p, to
3874 make it consistent with the commentary. Fix typos in the
3875 commentary.
3876
e2ad650c
EZ
3877 * textprop.c (syms_of_textprop): Remove dead code.
3878 (copy_text_properties): Delete obsolete commentary about an
3879 interface that was deleted long ago. Fix typos in the description
3880 of arguments.
3881
1b2de274
EZ
3882 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3883 to changes in oldXMenu/XMenu.h from 2011-04-16.
3884 <menu_help_message, prev_menu_help_message>: Constify.
3885 (IT_menu_make_room): menu->help_text is now `const char **';
3886 adjust.
3887
3888 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3889 to changes in oldXMenu/XMenu.h from 2011-04-16.
3890 (struct XMenu): Declare `help_text' `const char **'.
3891
3892 * xfaces.c <Qunspecified>: Make extern again.
3893
3894 * syntax.c: Include sys/types.h before including regex.h, as
3895 required by Posix.
3896
762b15be
EZ
3897 * doc.c (get_doc_string): Improve the format passed to `error'.
3898
3899 * doprnt.c (doprnt): Improve commentary.
3900
3901 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3902
3903 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3904 them with etags.
3905
f1052e5d
EZ
3906 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3907 changes in globals.h immediately force recompilation.
762b15be
EZ
3908 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3909 $(CURDIR)/s/ms-w32.h.
3910 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3911
fa6996bc
EZ
3912 * character.c (Fchar_direction): Function deleted.
3913 (syms_of_character): Don't defsubr it.
3914 <char-direction-table>: Deleted.
3915
e6c3da20
EZ
39162011-04-23 Eli Zaretskii <eliz@gnu.org>
3917
3918 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3919 * doprnt.c: Include limits.h.
3920 (SIZE_MAX): New macro.
04f2d78b
CB
3921 (doprnt): Return a size_t value. 2nd arg is now size_t.
3922 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3923 Improve overflow protection. Support `l' modifier for integer
3924 conversions. Support %l conversion. Don't assume an EMACS_INT
3925 argument for integer conversions and for %c.
3926
3927 * lisp.h (doprnt): Restore prototype.
3928
3929 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3930 $(SRC)/character.h.
3931
3932 * Makefile.in (base_obj): Add back doprnt.o.
3933
3934 * deps.mk (doprnt.o): Add back prerequisites.
3935 (callint.o): Depend on character.h.
3936
3937 * eval.c (internal_lisp_condition_case): Include the handler
3938 representation in the error message.
3939 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3940 when breaking from the loop.
3941
3942 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3943
3944 * callint.c (Fcall_interactively): When displaying error message
3945 about invalid control letter, pass the character's codepoint, not
3946 a pointer to its multibyte form. Improve display of the character
3947 in octal and display also its hex code.
3948
3949 * character.c (char_string): Use %x to display the (unsigned)
3950 codepoint of an invalid character, to avoid displaying a bogus
3951 negative value.
3952
3953 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3954 `error', not SYMBOL_NAME itself.
3955
3956 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3957 character arguments to `error'.
3958
3959 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3960 to `error' in error message about FINAL_CHAR argument. Make sure
3961 FINAL_CHAR is a character, and use %c when it is passed as
3962 argument to `error'.
3963
4ffd0d6b 39642011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3965
3966 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3967
3968 * w32.c: Include <time.h>.
3969 (sys_localtime): New function.
3970
4ffd0d6b 39712011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3972
3973 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3974
4ffd0d6b 3975 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3976
4ffd0d6b 39772011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3978
4ffd0d6b
GM
3979 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3980 zombies (Bug#8467).
aac0c6e3 3981
04c56954
EZ
39822011-04-19 Eli Zaretskii <eliz@gnu.org>
3983
3984 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3985 gl_state.e_property when gl_state.object is Qt.
3986
3987 * insdel.c (make_gap_larger): Remove limitation of buffer size
3988 to <= INT_MAX.
3989
16a43933
CY
39902011-04-18 Chong Yidong <cyd@stupidchicken.com>
3991
3992 * xdisp.c (lookup_glyphless_char_display)
3993 (produce_glyphless_glyph): Handle cons cell entry in
3994 glyphless-char-display.
3995 (Vglyphless_char_display): Document it.
3996
3997 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3998 glyphless-char-display.
3999
4581706e
CY
40002011-04-17 Chong Yidong <cyd@stupidchicken.com>
4001
4002 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4003
4004 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4005
4006 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4007 definition for no-X builds.
4008
4887c6e2 40092011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4010
fd35b6f9
PE
4011 Static checks with GCC 4.6.0 and non-default toolkits.
4012
5c1ccb01
PE
4013 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4014
006c5daa
PE
4015 * process.c (keyboard_bit_set): Define only if SIGIO.
4016 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4017 (send_process): Repair possible setjmp clobbering.
4018
efc736d3
PE
4019 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4020
4e2fe2e6
PE
4021 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4022
f97334a2
PE
4023 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4024
4e75f29d
PE
4025 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4026 Define only if needed.
4027
90efadd1
PE
4028 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4029 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4030 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4031
3c647824
PE
4032 * dispextern.h (struct redisplay_interface): Rename param
4033 to avoid shadowing.
e264f262 4034 * termhooks.h (struct terminal): Likewise.
761383f4 4035 * xterm.c (xembed_send_message): Likewise.
3c647824 4036
b58c5c4a
PE
4037 * insdel.c (make_gap_smaller): Define only if
4038 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4039
cad59032
PE
4040 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4041 it.
4042
c339dc2e
PE
4043 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4044 so that we aren't warned about unused symbols.
4045
91a3e27b
PE
4046 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4047
399c71d3 4048 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4049
8ffc96f5
PE
4050 * xfns.c (x_real_positions): Mark locals as initialized.
4051
eef9bc79
PE
4052 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4053
098db9dd
PE
4054 * xterm.c: Fix problems found by static analysis with other toolkits.
4055 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4056 (x_dispatch_event): Declare static if USE_GTK, and
4057 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4058 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4059 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4060 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4061 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4062
eb18f6cc
PE
4063 * xmenu.c (menu_help_callback): Pointer type fixes.
4064 Use const pointers when pointing at readonly data. Avoid pointer
4065 signedness clashes.
4066 (FALSE): Remove unused macro.
4067 (update_frame_menubar): Remove unused decl.
4068
1fe72bf8
PE
4069 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4070
60d9e1db
PE
4071 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4072 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4073 (single_menu_item): Rename local to avoid shadowing.
4074
39261c26
PE
4075 * keyboard.c (make_lispy_event): Remove unused local var.
4076
018c5e19
PE
4077 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4078 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4079
63d2b86e
PE
4080 * bitmaps: Change bitmaps from unsigned char back to the X11
4081 compatible char. Avoid the old compiler warnings about
4082 out-of-range initializers by using, for example, '\xab' rather
4083 than 0xab.
4084
aefd87e1
PE
4085 * xgselect.c (xgselect_initialize): Check vs interface
4086 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4087
bf501fb9
PE
4088 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4089
e9829fdf
PE
4090 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4091 to read-only memory.
4092
1086c095
PE
4093 * fns.c (vector): Remove; this old hack is no longer needed.
4094
2baccd04 4095 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4096 Remove unused var.
dde42981 4097 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4098
72391843 4099 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4100
436c16df 4101 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4102 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4103 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4104
92bb796d 4105 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4106 (x_term_init): Remove local to avoid shadowing.
92bb796d 4107
764430a3 4108 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4109
4110 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4111 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4112
d1dfb56c
EZ
41132011-04-16 Eli Zaretskii <eliz@gnu.org>
4114
c4354cb4
EZ
4115 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4116
d1dfb56c
EZ
4117 Fix regex.c, syntax.c and friends for buffers > 2GB.
4118 * syntax.h (struct gl_state_s): Declare character position members
4119 EMACS_INT.
4120
4121 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4122
04f2d78b
CB
4123 * textprop.c (verify_interval_modification, interval_of):
4124 Declare arguments EMACS_INT.
d1dfb56c
EZ
4125
4126 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4127 EMACS_INT.
4128
4129 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4130
4131 * indent.c (Fvertical_motion): Local variable it_start is now
4132 EMACS_INT.
4133
4134 * regex.c (re_match, re_match_2, re_match_2_internal)
4135 (bcmp_translate, regcomp, regexec, print_double_string)
4136 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4137 (re_compile_pattern, re_exec): Declare arguments and local
4138 variables `size_t' and `ssize_t' and return values `regoff_t', as
4139 appropriate.
4140 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4141 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4142 <compile_stack_type>: `size' and `avail' are now `size_t'.
4143
4144 * regex.h <regoff_t>: Use ssize_t, not int.
4145 (re_search, re_search_2, re_match, re_match_2): Arguments that
4146 specify buffer/string position and length are now ssize_t and
4147 size_t. Return type is regoff_t.
4148
613052cd
BK
41492011-04-16 Ben Key <bkey76@gmail.com>
4150
4151 * nsfont.m: Fixed bugs in ns_get_family and
4152 ns_descriptor_to_entity that were caused by using free to
4153 deallocate memory blocks that were allocated by xmalloc (via
4154 xstrdup). This caused Emacs to crash when compiled with
4155 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4156 --enable-checking=xmallocoverrun). xfree is now used to
4157 deallocate these memory blocks.
4158
4170f62f 41592011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4160
71b41406
PE
4161 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4162
9587a89d
PE
4163 emacs_write: Accept and return EMACS_INT for sizes.
4164 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4165 et seq.
4166 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4167 Accept and return EMACS_INT.
4168 (emacs_gnutls_write): Return the number of bytes written on
4169 partial writes.
4170 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4171 (emacs_read, emacs_write): Remove check for negative size, as the
4172 Emacs source code has been audited now.
9587a89d
PE
4173 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4174 (emacs_read, emacs_write): Use it.
273a5f82
PE
4175 * process.c (send_process): Adjust to the new signatures of
4176 emacs_write and emacs_gnutls_write. Do not attempt to store
4177 a byte offset into an 'int'; it might overflow.
9587a89d 4178 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4179
3e047f51
PE
4180 * sound.c: Don't assume sizes fit in 'int'.
4181 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4182 Return EMACS_INT, not int.
3e047f51 4183 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4184 Accept EMACS_INT, not int.
4185 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4186 record read return values.
4187
cc39a9db
BK
41882011-04-15 Ben Key <bkey76@gmail.com>
4189
c9d0ec6d
JB
4190 * keyboard.c (Qundefined): Don't declare static since it is used
4191 in nsfns.m.
4192 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4193 static since they are used in nsfont.m.
cc39a9db 4194
6c60eb9f
SM
41952011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4196
4197 * process.c (Qprocessp): Don't declare static.
4198 * lisp.h (Qprocessp): Declare again.
4199
7990b61a
JB
42002011-04-15 Juanma Barranquero <lekktu@gmail.com>
4201
4202 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4203
5d4cb038
PE
42042011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4205
8bd7b830 4206 Improve C-level modularity by making more things 'static'.
cd64ea1d 4207
e3b27b31
PE
4208 Don't publish debugger-only interfaces to other modules.
4209 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4210 (verify_bytepos, count_markers): Move decls to the only modules
4211 that need them.
4212 * region-cache.h (pp_cache): Likewise.
4213 * window.h (check_all_windows): Likewise.
4214 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4215
5d4cb038
PE
4216 * sysdep.c (croak): Now static, if
4217 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4218 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4219
4220 * alloc.c (refill_memory_reserve): Now static if
4221 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4222 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4223
e87b6180
PE
4224 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4225 Define only if USE_LUCID.
4226
ac64929e
PE
4227 * xrdb.c (x_customization_string, x_rm_string): Now static.
4228
6f37259d
PE
4229 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4230 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4231
1683e3ab
PE
4232 * xdisp.c (draw_row_with_mouse_face): Now static.
4233 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4234
de9c2632
PE
4235 * window.h (check_all_windows): Mark externally visible.
4236
2b96acb7
PE
4237 * window.c (window_deletion_count): Now static.
4238
4239 * undo.c: Make symbols static if they're not exported.
4240 (last_undo_buffer, last_boundary_position, pending_boundary):
4241 Now static.
4242
50436f33
PE
4243 * textprop.c (interval_insert_behind_hooks): Now static.
4244 (interval_insert_in_front_hooks): Likewise.
4245
64520e5c
PE
4246 * term.c: Make symbols static if they're not exported.
4247 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4248 (max_frame_lines, tty_set_terminal_modes):
4249 (tty_reset_terminal_modes, tty_turn_off_highlight):
4250 (get_tty_terminal): Now static.
4251 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4252 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4253 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4254 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4255 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4256
1fa53021
PE
4257 * sysdep.c: Make symbols static if they're not exported.
4258 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4259 Now static.
4260 (sigprocmask_set, full_mask): Remove; unused.
4261 (wait_debugging): Mark as visible.
4262 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4263 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4264
d4b43b22
PE
4265 * syntax.c (syntax_temp): Define only if !__GNUC__.
4266
b7c513d0
PE
4267 * sound.c (current_sound_device, current_sound): Now static.
4268
989b29ad
PE
4269 * search.c (searchbufs, searchbuf_head): Now static.
4270
13a55a78
PE
4271 * scroll.c (scroll_cost): Remove; unused.
4272 * dispextern.h (scroll_cost): Remove decl.
4273
de68a1fc
PE
4274 * region-cache.h (pp_cache): Mark as externally visible.
4275
40ccffa6
PE
4276 * process.c: Make symbols static if they're not exported.
4277 (process_tick, update_tick, create_process, chan_process):
4278 (Vprocess_alist, proc_buffered_char, datagram_access):
4279 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4280 (deactivate_process): Mark defn as static, as well as decl.
4281 * lisp.h (create_process): Remove decl.
4282 * process.h (chan_process, Vprocess_alist): Remove decls.
4283
ad64fc97
PE
4284 * print.c: Make symbols static if they're not exported.
4285 (print_depth, new_backquote_output, being_printed, print_buffer):
4286 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4287 (print_interval, print_number_index, initial_stderr_stream):
4288 Now static.
4289 * lisp.h (Fprinc): Remove decl.
4290 (debug_output_compilation_hack): Mark as externally visible.
4291
adddb265
PE
4292 * sysdep.c (croak): Move decl from here to syssignal.h.
4293 * syssignal.h (croak): Put it here, so the API can be checked when
4294 'croak' is called from dissociate_if_controlling_tty.
4295
1717ede2
PE
4296 * minibuf.c: Make symbols static if they're not exported.
4297 (minibuf_save_list, choose_minibuf_frame): Now static.
4298 * lisp.h (choose_minibuf_frame): Remove decl.
4299
fa5fb2bc
PE
4300 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4301
1e3890d1
PE
4302 * lread.c: Make symbols static if they're not exported.
4303 (read_objects, initial_obarray, oblookup_last_bucket_number):
4304 Now static.
4305 (make_symbol): Remove; unused.
4306 * lisp.h (initial_obarray, make_symbol): Remove decls.
4307
8a1414fa
PE
4308 * keyboard.c: Make symbols static if they're not exported.
4309 (single_kboard, recent_keys_index, total_keys, recent_keys):
4310 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4311 (this_single_command_key_start, echoing, last_auto_save):
4312 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4313 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4314 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4315 (Vlispy_mouse_stem, double_click_count):
4316 Now static.
4317 (force_auto_save_soon): Define only if SIGDANGER.
4318 (ignore_mouse_drag_p): Now static if
4319 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4320 (print_help): Remove; unused.
4321 (stop_character, last_timer_event): Mark as externally visible.
4322 * keyboard.h (ignore_mouse_drag_p): Declare only if
4323 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4324 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4325 * lisp.h (echoing): Remove decl.
4326 (force_auto_save_soon): Declare only if SIGDANGER.
4327 * xdisp.c (redisplay_window): Simplify code, to make it more
4328 obvious that ignore_mouse_drag_p is not accessed if !defined
4329 USE_GTK && !defined HAVE_NS.
4330
93ea6e8f
PE
4331 * intervals.c: Make symbols static if they're not exported.
4332 (merge_properties_sticky, merge_interval_right, delete_interval):
4333 Now static.
4334 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4335
77382fcc
PE
4336 * insdel.c: Make symbols static if they're not exported.
4337 However, leave prepare_to_modify_buffer alone. It's never
4338 called from outside this function, but that appears to be a bug.
4339 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4340 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4341 (adjust_after_replace_noundo): Remove; unused.
4342 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4343 (signal_before_change): Remove decls.
77382fcc 4344
9306c32e
PE
4345 * indent.c (val_compute_motion, val_vmotion): Now static.
4346
cd44d2eb
PE
4347 * image.c: Make symbols static if they're not exported.
4348 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4349 if USE_GTK.
4350 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4351 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4352
ad9a7a06
PE
4353 * fringe.c (standard_bitmaps): Now static.
4354 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4355
81626931
PE
4356 * frame.c: Make symbols static if they're not exported.
4357 (x_report_frame_params, make_terminal_frame): Now static.
4358 (get_frame_param): Now static, unless HAVE_NS.
4359 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4360 (x_get_resource_string): Remove; not used.
4361 * frame.h (make_terminal_frame, x_report_frame_params):
4362 (x_get_resource_string); Remove decls.
4363 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4364 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4365
239f9db9
PE
4366 * font.c, fontset.c: Make symbols static if they're not exported.
4367 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4368 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4369 * font.c (font_close_object): Now static.
4370 * font.h (font_close_object): Remove.
4371 * fontset.c (FONTSET_OBJLIST): Remove.
4372 (free_realized_fontset) #if-0 the body, which does nothing.
4373 (face_suitable_for_char_p): #if-0, as it's never called.
4374 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4375 * xfaces.c (face_at_string_position):
4376 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4377 since 0 is always ASCII.
4378
dfcf3579
PE
4379 * fns.c (weak_hash_tables): Now static.
4380
5045092b
PE
4381 * fileio.c: Make symbols static if they're not exported.
4382 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4383 (Vwrite_region_annotation_buffers): Now static.
4384
57a96f5c
PE
4385 * eval.c: Make symbols static if they're not exported.
4386 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4387 * lisp.h (backtrace_list): Remove decl.
4388
35f08c38
PE
4389 * emacs.c: Make symbols static if they're not exported.
4390 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4391 (fatal_error_code, fatal_error_signal_hook, standard_args):
4392 Now static.
4393 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4394 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4395 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4396 * lisp.h (fatal_error_signal_hook): Remove decl.
4397 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4398
f44bd759
PE
4399 * editfns.c: Move a (normally-unused) function to its only use.
4400 * editfns.c, lisp.h (get_operating_system_release): Remove.
4401 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4402 worth the hassle of breaking this out.
4403
b532497d
PE
4404 * xterm.c: Make symbols static if they're not exported.
4405 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4406 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4407 (x_destroy_window, x_delete_display):
4408 Now static.
4409 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4410 (x_mouse_leave): Remove; unused.
4411 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4412 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4413 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4414 Remove decls.
4415 (x_mouse_leave): Declare only if WINDOWSNT.
4416 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4417 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4418 USE_X_TOOLKIT.
4419
1675728f
PE
4420 * ftxfont.c: Make symbols static if they're not exported.
4421 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4422 HAVE_FREETYPE.
4423 * font.h (ftxfont_driver): Likewise.
4424
e4cebfca
PE
4425 * xfns.c: Make symbols static if they're not exported.
4426 (x_last_font_name, x_display_info_for_name):
4427 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4428 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4429 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4430 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4431 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4432 (last_show_tip_args): Now static.
4433 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4434 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4435 (x_screen_planes): Remove; unused.
4436 * dispextern.h (x_screen_planes): Remove decl.
4437
5bf46f05
PE
4438 * dispnew.c: Make symbols static if they're not exported.
4439 * dispextern.h (redraw_garbaged_frames, scrolling):
4440 (increment_row_positions): Remove.
4441 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4442 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4443 Now static.
4444 (redraw_garbaged_frames): Remove; unused.
4445
435f4c28
PE
4446 * xfaces.c: Make symbols static if they're not exported.
4447 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4448 Remove decls.
4449 * xterm.h (defined_color): Remove decls.
4450 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4451 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4452 (menu_face_changed_default, defined_color, free_realized_face):
4453 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4454 (ascii_face_of_lisp_face): Remove; unused.
4455
8524aef3
PE
4456 * xdisp.c: Make symbols static if they're not exported.
4457 * dispextern.h (scratch_glyph_row, window_box_edges):
4458 (glyph_to_pixel_coords, set_cursor_from_row):
4459 (get_next_display_element, set_iterator_to_next):
4460 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4461 (show_mouse_face): Remove decls
4462 * frame.h (message_buf_print): Likewise.
4463 * lisp.h (pop_message, set_message, check_point_in_composition):
4464 Likewise.
4465 * xterm.h (set_vertical_scroll_bar): Likewise.
4466 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4467 (message_buf_print, scratch_glyph_row, displayed_buffer):
4468 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4469 (get_next_display_element, show_mouse_face, window_box_edges):
4470 (frame_to_window_pixel_xy, check_point_in_composition):
4471 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4472 (glyph_to_pixel_coords): Remove; unused.
4473
16390cd2
PE
4474 * dired.c (file_name_completion): Now static.
4475
4476 * dbusbind.c (xd_in_read_queued_messages): Now static.
4477
a25f4dfa
PE
4478 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4479 * data.c (circular_list_error): Remove.
4480
14a9c8df
PE
4481 * commands.h (last_point_position, last_point_position_buffer):
4482 (last_point_position_window): Remove decls.
4483 * keyboard.c: Make these variables static.
4484
04f2d78b
CB
4485 * coding.h (coding, code_convert_region, encode_coding_gap):
4486 Remove decls.
74ab6df5
PE
4487 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4488 (iso_code_class, detect_coding, code_convert_region): Now static.
4489 (encode_coding_gap): Remove; unused.
4490
38dfbee1
PE
4491 * chartab.c (chartab_chars, chartab_bits): Now static.
4492
a2cb4e63
PE
4493 * charset.h (charset_iso_8859_1): Remove decl.
4494 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4495 Now static.
4496
127198fd
PE
4497 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4498 * ccl.c (Vccl_program_table): Now static.
4499 (check_ccl_update): Remove; unused.
4500
d85b608f
PE
4501 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4502 * category.h: ... from here.
4503 * category.c (check_category_table, set_category_set): Now static.
4504
31cd66f3
PE
4505 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4506 * lisp.h: Remove these decls.
4507
c358e587
PE
4508 * buffer.c (buffer_count): Remove unused var.
4509
e78aecca
PE
4510 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4511 so that it's not optimized away.
4512 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4513 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4514 exported only to the debugger.
4515
e192d7d3 4516 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4517 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4518
92470028
PE
4519 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4520 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4521 was inaccessible from Lisp.
4522 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4523 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4524
244ed907
PE
4525 alloc.c: Import and export fewer symbols, and remove unused items.
4526 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4527 is defined.
4528 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4529 it's not optimized away by whole-program optimization.
4530 (message_enable_multibyte, free_misc): Remove.
4531 (catchlist, handlerlist, mark_backtrace):
4532 Declare only if BYTE_MARK_STACK.
4533 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4534 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4535 (message_enable_multibyte): Remove decl.
4536 (free_misc, interval_free_list, float_block, float_block_index):
4537 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4538 (cons_free_list, last_marked_index):
4539 Now static.
4540 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4541 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4542 (mark_backtrace): Define only if BYTE_MARK_STACK.
4543 * xdisp.c (message_enable_multibyte): Now static.
4544
61c2b50e 4545 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4546 This makes it easier for human readers (and static analyzers)
4547 to see whether these variables are used from other modules.
4548 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4549 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4550 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4551 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4552 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4553 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4554 * xmenu.c, xselect.c:
4555 Declare Q* vars static if they are not used in other modules.
4556 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4557 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4558 Remove decls of unexported vars.
4559 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4560
95c82688
PE
4561 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4562
16a97296
PE
4563 Make Emacs functions such as Fatom 'static' by default.
4564 This makes it easier for human readers (and static analyzers)
4565 to see whether these functions can be called from other modules.
4566 DEFUN now defines a static function. To make the function external
4567 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4568 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4569 (Finit_image_library):
16a97296
PE
4570 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4571 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4572 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4573 Remove decls, since these functions are now static.
4574 (Funintern, Fget_internal_run_time): New decls, since these functions
4575 were already external.
95c82688 4576
16a97296
PE
4577 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4578 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4579 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4580 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4581 * keyboard.c, keymap.c, lread.c:
4582 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4583 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4584 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4585 Mark functions with DEFUE instead of DEFUN,
4586 if they are used in other modules.
4587 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4588 decls for now-static functions.
4589 * buffer.h (Fdelete_overlay): Remove decl.
4590 * callproc.c (Fgetenv_internal): Mark as internal.
4591 * composite.c (Fremove_list_of_text_properties): Remove decl.
4592 (Fcomposition_get_gstring): New forward static decl.
4593 * composite.h (Fcomposite_get_gstring): Remove decl.
4594 * dired.c (Ffile_attributes): New forward static decl.
4595 * doc.c (Fdocumntation_property): New forward static decl.
4596 * eval.c (Ffetch_bytecode): New forward static decl.
4597 (Funintern): Remove extern decl; now in .h file where it belongs.
4598 * fileio.c (Fmake_symbolic_link): New forward static decl.
4599 * image.c (Finit_image_library): New forward static decl.
4600 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4601 * intervals.h (Fprevious_property_change):
4602 (Fremove_list_of_text_properties): Remove decls.
4603 * keyboard.c (Fthis_command_keys): Remove decl.
4604 (Fcommand_execute): New forward static decl.
4605 * keymap.c (Flookup_key): New forward static decl.
4606 (Fcopy_keymap): Now static.
4607 * keymap.h (Flookup_key): Remove decl.
4608 * process.c (Fget_process): New forward static decl.
4609 (Fprocess_datagram_address): Mark as internal.
4610 * syntax.c (Fsyntax_table_p): New forward static decl.
4611 (skip_chars): Remove duplicate decl.
4612 * textprop.c (Fprevious_property_change): New forward static decl.
4613 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4614 Now internal.
4615 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4616 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4617
785bbd42
PE
4618 * editfns.c (Fformat): Remove unreachable code.
4619
8b913b57
AS
46202011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4621
4622 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4623 change. (Bug#8496)
4624
a6744a35
EZ
46252011-04-13 Eli Zaretskii <eliz@gnu.org>
4626
4627 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4628 when at ZV. (Bug#8487)
4629
e7974947
AS
46302011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4631
baad03f0
AS
4632 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4633 (Bug#8437)
4634 * keyboard.c (parse_tool_bar_item): Likewise.
4635 * sound.c (sound_cleanup, alsa_close): Likewise.
4636 * termcap.c (tgetent): Likewise.
4637 * xfns.c (x_default_font_parameter): Likewise.
4638 * xsettings.c (read_and_apply_settings): Likewise.
4639
e7974947
AS
4640 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4641 (overrun_check_free): Protoize.
4642
28272684
PE
46432011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4644
4645 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4646 since callers should never pass a negative size.
4647 Change the signature to match that of plain 'read' and 'write'; see
4648 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4649 * lisp.h: Update prototypes of emacs_write and emacs_read.
4650
11997c76
EZ
46512011-04-11 Eli Zaretskii <eliz@gnu.org>
4652
4653 * xdisp.c (redisplay_window): Don't try to determine the character
4654 position of the scroll margin if the window start point w->startp
e896f03c 4655 is outside the buffer's accessible region. (Bug#8468)
11997c76 4656
8a2cbd72
EZ
46572011-04-10 Eli Zaretskii <eliz@gnu.org>
4658
4659 Fix write-region and its subroutines for buffers > 2GB.
4660 * fileio.c (a_write, e_write): Modify declaration of arguments and
4661 local variables to support buffers larger than 2GB.
4662 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4663
4664 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4665 argument, local variables, and return value.
4666
4667 * lisp.h: Update prototypes of emacs_write and emacs_read.
4668
4669 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4670
4073e537 46712011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4672
1ebfdcb6
PE
4673 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4674
b2ded58d
PE
4675 Fix more problems found by GCC 4.6.0's static checks.
4676
7d66342c
PE
4677 * xdisp.c (vmessage): Use a better test for character truncation.
4678
bbf47d44
PE
4679 * charset.c (load_charset_map): <, not <=, for optimization,
4680 and to avoid potential problems with integer overflow.
9248994d 4681 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4682 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4683 * editfns.c (Fformat): Likewise.
1e69125e 4684 * syntax.c (skip_chars): Likewise.
3befa583 4685
e3019616
PE
4686 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4687 This also lets GCC 4.6.0 generate slightly better loop code.
4688
becfa255
PE
4689 * callint.c (Fcall_interactively): <, not <=, for optimization.
4690 (Fcall_interactively): Count the number of arguments produced,
4691 not the number of arguments given. This is simpler and lets GCC
4692 4.6.0 generate slightly better code.
4693
dae0cd48
PE
4694 * ftfont.c: Distingish more carefully between FcChar8 and char.
4695 The previous code passed unsigned char * to a functions like
4696 strlen and xstrcasecmp that expect char *, which does not
4697 conform to the C standard.
4698 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4699 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4700 char * when the C standard requires it.
4701
76032d70
PE
4702 * keyboard.c (read_char): Remove unused var.
4703
eb3f1cc8
PE
4704 * eval.c: Port to Windows vsnprintf (Bug#8435).
4705 Include <limits.h>.
4706 (SIZE_MAX): Define if the headers do not.
4707 (verror): Do not give up if vsnprintf returns a negative count.
4708 Instead, grow the buffer. This ports to Windows vsnprintf, which
4709 does not conform to C99. Problem reported by Eli Zaretskii.
4710 Also, simplify the allocation scheme, by avoiding the need for
4711 calling realloc, and removing the ALLOCATED variable.
4712
70476b54
PE
4713 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4714
12020a9e
PE
4715 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4716 But keep the doprint source code for now, as we might revamp it
4717 and use it again (Bug#8435).
ea6c7ae6
PE
4718 * lisp.h (doprnt): Remove.
4719 * Makefile.in (base_obj): Remove doprnt.o.
4720 * deps.mk (doprnt.o): Remove.
4721
5fdb398c
PE
4722 error: Print 32- and 64-bit integers portably (Bug#8435).
4723 Without this change, on typical 64-bit hosts error ("...%d...", N)
4724 was used to print both 32- and 64-bit integers N, which relied on
4725 undefined behavior.
4726 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4727 New macro.
4728 * lisp.h (error, verror): Mark as printf-like functions.
4729 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4730 Report overflow in size calculations when allocating printf buffer.
4731 Do not truncate output string at its first null byte.
4732 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4733 Truncate the output at a character boundary, since vsnprintf does not
4734 do that.
4735 * charset.c (check_iso_charset_parameter): Convert internal
4736 character to string before calling 'error', since %c now has the
4737 printf meaning.
4738 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4739 overflow when computing char to be passed to 'error'. Do not
4740 pass Lisp_Object to 'error'; pass the integer instead.
4741 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4742 formatted with plain %d.
4743
b189fa66
PE
4744 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4745
bff87ef0
PE
4746 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4747
7e2cac20
PE
4748 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4749
ce4d90b5
PE
4750 * xterm.c (x_catch_errors): Remove duplicate declaration.
4751
266c9547
PE
4752 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4753
79c49ad2
PE
4754 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4755
368f4090
JM
47562011-04-10 Jim Meyering <meyering@redhat.com>
4757
4758 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4759 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4760 return ssize_t not "int", and use size_t as the buffer length.
4761 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4762 * gnutls.h: Update declarations.
4763 * process.c (read_process_output): Use ssize_t, to match.
4764 (send_process): Likewise.
4765
a32d4040
CY
47662011-04-09 Chong Yidong <cyd@stupidchicken.com>
4767
4768 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4769
8546720e 47702011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4771
04f2d78b
CB
4772 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4773 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4774
8546720e
GM
4775 * xterm.c (handle_one_xevent):
4776 * xmenu.c (create_and_show_popup_menu):
4777 * xselect.c (x_decline_selection_request)
4778 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4779
0a2f5c1a 47802011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4781
4782 Fix some uses of `int' instead of EMACS_INT.
4783 * search.c (string_match_1, fast_string_match)
4784 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4785 (scan_buffer, find_next_newline_no_quit)
4786 (find_before_next_newline, search_command, Freplace_match)
4787 (Fmatch_data): Make some `int' variables be EMACS_INT.
4788
4789 * xdisp.c (display_count_lines): 3rd argument and return value now
4790 EMACS_INT. All callers changed.
4791 (pint2hrstr): Last argument is now EMACS_INT.
4792
4793 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4794 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4795 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4796 (decode_coding_utf_16, decode_coding_emacs_mule)
4797 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4798 (decode_coding_ccl, decode_coding_charset)
4799 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4800 (decode_coding_iso_2022, decode_coding_emacs_mule)
4801 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4802 <char_offset, last_offset>: Declare EMACS_INT.
4803 (encode_coding_utf_8, encode_coding_utf_16)
4804 (encode_coding_emacs_mule, encode_invocation_designation)
4805 (encode_designation_at_bol, encode_coding_iso_2022)
4806 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4807 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4808 Declare EMACS_INT.
4809 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4810 (encode_invocation_designation): Last argument P_NCHARS is now
4811 EMACS_INT.
4812 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4813 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4814
4815 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4816 All users changed.
4817
4818 * ccl.c (Fccl_execute_on_string): Declare some variables
4819 EMACS_INT.
4820
8546720e 48212011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4822
4823 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4824
4e19a977
CS
48252011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4826
4827 * process.c (Fformat_network_address): Doc fix.
4828
87302331
R
48292011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4830
4831 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4832
cbb59342
CY
48332011-04-08 Chong Yidong <cyd@stupidchicken.com>
4834
4835 * keyboard.c (read_char): Call Lisp function help-form-show,
4836 instead of using internal_with_output_to_temp_buffer.
4837 (Qhelp_form_show): New var.
e0d38eeb 4838 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4839
4840 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4841
4842 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4843
e67a13ab
CY
48442011-04-06 Chong Yidong <cyd@stupidchicken.com>
4845
04f2d78b
CB
4846 * process.c (Flist_processes): Remove to Lisp.
4847 (list_processes_1): Delete.
e67a13ab 4848
973f782d
EZ
48492011-04-06 Eli Zaretskii <eliz@gnu.org>
4850
7c106b1e
EZ
4851 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4852
973f782d
EZ
4853 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4854
41cf7d1a 48552011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4856
ca23cc88
PE
4857 Fix more problems found by GCC 4.6.0's static checks.
4858
f390e2d5
PE
4859 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4860
42eea0d0
PE
4861 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4862
b69769da 4863 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4864
f9541e84
PE
4865 * xdisp.c (vmessage): Mark as a printf-like function.
4866
13841b55
PE
4867 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4868
c136c10f
PE
4869 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4870
5e2d4a30
PE
4871 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4872 printf-like functions.
4873 (tiff_load): Add casts to remove these marks before passing them
4874 to system-supplied API.
4875
583f48b9
PE
4876 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4877
b25d760e
PE
4878 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4879 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4880 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4881 directly, rather than having caller test rule sign. This avoids
4882 some unnecessary tests.
4883 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4884 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4885 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4886
bc7b6697 4887 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4888 (xfont_open): Avoid unnecessary tests.
bc7b6697 4889
27ccc379
PE
4890 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4891
dcd5c89a
PE
4892 * composite.h, composite.c (composition_gstring_put_cache):
4893 Use EMACS_INT, not int, for length.
4894
b13a45c6
PE
4895 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4896 breaking out part of COMPOSITION_DECODE_RULE.
4897 (COMPOSITION_DECODE_RULE): Use it.
4898 * composite.c (get_composition_id): Remove unused local vars,
4899 by using the new macro.
4900
1e792e4d
PE
4901 * textprop.c (set_text_properties_1): Change while to do-while,
4902 since the condition is always true at first.
4903
dc6c6455 4904 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4905 (interval_deletion_adjustment): Return unsigned value.
4906 All uses changed.
dc6c6455 4907
aba7731a
PE
4908 * process.c (list_processes_1, create_pty, read_process_output):
4909 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4910 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4911 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4912 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4913 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4914
fdfc4bf3
PE
4915 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4916
fca8fe46 4917 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4918 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4919
06a0259a 4920 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4921 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4922 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4923
e7b9e80f
PE
4924 * print.c (print_error_message): Avoid int overflow.
4925
56201685
PE
4926 * font.c (font_list_entities): Redo for clarity,
4927 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4928
78834453 4929 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4930 (font_score): Avoid potential overflow in diff calculation.
78834453 4931
0bc0b309 4932 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4933 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4934
e610eaca
PE
4935 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4936
b895abce
PE
4937 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4938 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4939 can always succeed if overflow has undefined behavior.
4940
1f1d9321 4941 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4942 (wordify): Omit three unnecessary tests.
1f1d9321 4943
c59478bc
PE
4944 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4945 All callers changed. This avoids the need for an unused var.
4946
79b73827
PE
4947 * casefiddle.c (casify_region): Remove var that is set but not used.
4948
a4db5dfe
PE
4949 * dired.c (file_name_completion): Remove var that is set but not used.
4950
43aae36e
PE
4951 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4952
2a47c44d 4953 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4954 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4955
a37c69bf
PE
4956 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4957 Check for integer overflow on size calculations.
4958
328ab8e7
PE
4959 * buffer.c (Fprevious_overlay_change): Remove var that is set
4960 but not used.
4961
e5a2a5cb
PE
4962 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4963 Remove vars that are set but not used.
8d84a6eb 4964 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4965 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4966
a60e5f68
PE
4967 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4968
f661cb61 4969 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4970 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4971
f0397f5a
PE
4972 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4973 that are set but not used.
4974
8664db06 4975 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4976 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4977
6abdaa4a
PE
4978 * xselect.c (x_get_local_selection, x_handle_property_notify):
4979 Remove vars that are set but not used.
4980
0ce7538d 4981 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4982 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4983
9ae848fc
PE
4984 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4985 Remove var that is set but not used.
0b918413
PE
4986 (scroll_bar_windows_size): Now size_t, not int.
4987 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4988 Check for overflow.
9ae848fc 4989
a5a62657
PE
4990 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4991 (map_tty_color) [!defined MSDOS]: Likewise.
4992
5c5cdd39
PE
4993 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4994
66ebf983
PE
4995 * coding.c: Remove vars that are set but not used.
4996 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4997 All callers changed.
4998 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4999 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5000 (decode_coding_charset): Remove vars that are set but not used.
5001
1be4d761
PE
5002 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5003 that is set but not used.
5004
47553fa8
PE
5005 * print.c (print_object): Remove var that is set but not used.
5006
1f7196bf 5007 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5008 The gnulib version avoids calling malloc in the usual case,
5009 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5010 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5011 * filelock.c (current_lock_owner): Likewise.
5012 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5013 * sysdep.c: Include allocator.h, careadlinkat.h.
5014 (emacs_no_realloc_allocator): New static constant.
5015 (emacs_readlink): New function.
fdb61804
PE
5016 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5017 ../lib/careadlinkat.h.
d1fdcab7 5018
f84c17c7
SM
50192011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5020
5021 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5022 first non-nil return value).
5023
ef3862ad
JD
50242011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5025
5026 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5027 if not defined (Bug#8403).
5028
376a7006
JB
50292011-04-02 Juanma Barranquero <lekktu@gmail.com>
5030
5031 * xdisp.c (display_count_lines): Remove parameter `start',
5032 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5033 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5034 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5035 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5036 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5037 and thereabouts. All callers changed.
5038 (get_per_char_metric): Remove parameter `f', unused since
5039 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5040
6ca3801d
JM
50412011-04-02 Jim Meyering <meyering@redhat.com>
5042
5043 do not dereference NULL upon failed strdup
5044 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5045 (ns_get_family): Likewise.
5046
d8e2b5ba
JB
50472011-04-02 Juanma Barranquero <lekktu@gmail.com>
5048
5049 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5050
8c74fcbd
JD
50512011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5052
5053 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5054 later (Bug#8403).
5055
7200d79c
SM
50562011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5057
03408648 5058 Add lexical binding.
7200d79c 5059
03408648
SM
5060 * window.c (Ftemp_output_buffer_show): New fun.
5061 (Fsave_window_excursion):
5062 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5063
5064 * lread.c (lisp_file_lexically_bound_p): New function.
5065 (Fload): Bind Qlexical_binding.
5066 (readevalloop): Remove `evalfun' arg.
5067 Bind Qinternal_interpreter_environment.
5068 (Feval_buffer): Bind Qlexical_binding.
5069 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5070 Mark as dynamic.
5071 (syms_of_lread): Declare `lexical-binding'.
5072
5073 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5074
5075 * keyboard.c (eval_dyn): New fun.
5076 (menu_item_eval_property): Use it.
ca105506
SM
5077
5078 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5079
03408648
SM
5080 * fns.c (concat, mapcar1): Accept byte-code-functions.
5081
5082 * eval.c (Fsetq): Handle lexical vars.
5083 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5084 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5085 (FletX, Flet): Obey lexical binding.
5086 (Fcommandp): Handle closures.
5087 (Feval): New `lexical' arg.
5088 (eval_sub): New function extracted from Feval. Use it almost
5089 everywhere where Feval was used. Look up vars in lexical env.
5090 Handle closures.
5091 (Ffunctionp): Move from subr.el.
5092 (Ffuncall): Handle closures.
5093 (apply_lambda): Remove `eval_flags'.
5094 (funcall_lambda): Handle closures and new byte-code-functions.
5095 (Fspecial_variable_p): New function.
5096 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5097 but without exporting it to Lisp.
23aba0ea 5098
23aba0ea 5099 * doc.c (Fdocumentation, store_function_docstring):
03408648 5100 * data.c (Finteractive_form): Handle closures.
23aba0ea 5101
03408648
SM
5102 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5103 interactive spec.
ba83908c 5104
04f2d78b
CB
5105 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5106 New byte-codes.
03408648
SM
5107 (exec_byte_code): New function extracted from Fbyte_code to handle new
5108 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5109
03408648 5110 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5111
03408648 5112 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5113
e2abce01
JB
51142011-03-31 Juanma Barranquero <lekktu@gmail.com>
5115
5116 * xdisp.c (redisplay_internal): Fix prototype.
5117
63696a73 51182011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5119
63696a73 5120 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5121 (try_scrolling): Use it when setting scroll_limit.
5122 Limit scrolling to 100 screen lines.
63696a73
EZ
5123 (redisplay_window): Even when falling back on "recentering",
5124 position point in the window according to scroll-conservatively,
5125 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5126
5127 (try_scrolling): When point is above the window, allow searching
5128 as far as scroll_max, or one screenful, to compute vertical
5129 distance from PT to the scroll margin position. This prevents
5130 try_scrolling from unnecessarily failing when
5131 scroll-conservatively is set to a value slightly larger than the
5132 window height. Clean up the case of PT below the margin at bottom
5133 of window: scroll_max can no longer be INT_MAX. When aggressive
5134 scrolling is in use, don't let point enter the opposite scroll
5135 margin as result of the scroll.
5136 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5137 threshold of 100 lines for never-recentering scrolling.
5138
e4cc2dfc
JB
51392011-03-31 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * dispextern.h (move_it_by_lines):
5142 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5143 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5144 (message_log_check_duplicate): Remove parameters `prev_bol' and
5145 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5146 (redisplay_internal): Remove parameter `preserve_echo_area',
5147 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5148
5149 * indent.c (Fvertical_motion):
5150 * window.c (window_scroll_pixel_based, Frecenter):
5151 Don't pass `need_y_p' to `move_it_by_lines'.
5152
1c470562
SM
51532011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5154
44f230aa
SM
5155 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5156 steal a few bits to be more compact.
5157 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5158 Remove unneeded casts.
5159
1c470562
SM
5160 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5161
888adce9
ZK
51622011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5163
5164 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5165 binding" message (bug#7967).
5166
f838ed7b
PE
51672011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5168
77861b95
PE
5169 Fix more problems found by GCC 4.6.0's static checks.
5170
de6dbc14
PE
5171 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5172 Remove unused local var.
5173
f838ed7b
PE
5174 * editfns.c (Fmessage_box): Remove unused local var.
5175
792c7b2b
PE
5176 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5177 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5178 Omit unused local vars.
c499e557 5179 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5180 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5181 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5182 Omit unused local var.
5183
ba0165e1
PE
5184 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5185 Don't assume string length fits in int.
32ad8845 5186 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5187 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5188
3c59b4c9
PE
5189 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5190 instead of alloca (Bug#8344).
5191
a3eed478 5192 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5193 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5194
eb4d412d
PE
5195 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5196
1658b401
PE
5197 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5198 concerns.
5199
5200 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5201
5202 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5203
9a2c6e05
PE
5204 * keyboard.c (syms_of_keyboard): Use the same style as later
5205 in this function when indexing through an array. This also
5206 works around GCC bug 48267.
5207
03d0a109
PE
5208 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5209
44f730c8
PE
5210 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5211
fe75f926
PE
5212 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5213 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5214
ffa8c828
PE
5215 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5216 This avoids undefined behavior on integer overflow, and is a bit
5217 more convenient anyway since it is compared to a size_t variable.
5218
c5101a77
PE
5219 Variadic C functions now count arguments with size_t, not int.
5220 This avoids an unnecessary limitation on 64-bit machines, which
5221 caused (substring ...) to crash on large vectors (Bug#8344).
5222 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5223 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5224 All variadic functions and their callers changed accordingly.
c5101a77
PE
5225 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5226 * data.c (arith_driver, float_arith_driver): Likewise.
5227 * editfns.c (general_insert_function): Likewise.
5228 * eval.c (struct backtrace.nargs, interactive_p)
5229 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5230 (funcall_lambda, mark_backtrace): Likewise.
5231 * fns.c (concat): Likewise.
5232 * frame.c (x_set_frame_parameters): Likewise.
5233 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5234 0 if not found, not -1. All callers changed.
5235
dd3f25f7
PE
5236 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5237 (stack_copy_size): Now size_t, not int.
5238 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5239
461c2ab9
JB
52402011-03-28 Juanma Barranquero <lekktu@gmail.com>
5241
5242 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5243 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5244 All callers changed.
5245
5246 * lisp.h (multibyte_char_to_unibyte):
5247 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5248 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5249 * character.h (CHAR_TO_BYTE8):
5250 * cmds.c (internal_self_insert):
5251 * editfns.c (general_insert_function):
5252 * keymap.c (push_key_description):
5253 * search.c (Freplace_match):
5254 * xdisp.c (message_dolog, set_message_1): All callers changed.
5255
f6d62986
SM
52562011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5257
5258 * keyboard.c (safe_run_hook_funcall): New function.
5259 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5260 don't set the hook to nil, but remove the offending function instead.
5261 (Qcommand_hook_internal): Remove, unused.
5262 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5263 Vcommand_hook_internal.
5264
5265 * eval.c (enum run_hooks_condition): Remove.
5266 (funcall_nil, funcall_not): New functions.
5267 (run_hook_with_args): Call each function through a `funcall' argument.
5268 Remove `cond' argument, now redundant.
5269 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5270 (Frun_hook_with_args_until_failure): Adjust accordingly.
5271 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5272
1db5b1ad
JB
52732011-03-28 Juanma Barranquero <lekktu@gmail.com>
5274
5275 * dispextern.h (string_buffer_position): Remove declaration.
5276
5277 * print.c (strout): Remove parameter `multibyte', unused since
5278 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5279
5280 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5281 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5282 All callers changed.
5283
5284 * w32.c (_wsa_errlist): Use braces for struct initializers.
5285
5286 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5287 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5288 All callers changed.
5289 (string_buffer_position): Likewise. Also, make static (it's never
5290 used outside xdisp.c).
5291 (cursor_row_p): Remove parameter `w', unused since
5292 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5293 (decode_mode_spec): Remove parameter `precision', introduced during
5294 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5295 All callers changed.
5296
5ffb62aa
JD
52972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5298
5299 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5300
461c2ab9 53012011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5302
5303 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5304 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5305 (ns_update_auto_hide_menu_bar): New functions.
5306 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5307 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5308 ns_constrain_all_frames.
5309 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5310 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5311
5c380ffb
JD
53122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5313
5314 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5315
9af30bdf
GM
53162011-03-27 Glenn Morris <rgm@gnu.org>
5317
5318 * syssignal.h: Replace RETSIGTYPE with void.
5319 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5320 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5321 Replace SIGTYPE with void everywhere.
5322 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5323 * s/template.h (SIGTYPE): Remove commented out definition.
5324
e2abce01
JB
53252011-03-26 Eli Zaretskii <eliz@gnu.org>
5326
5327 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5328 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5329
f868cd8a
JB
53302011-03-26 Juanma Barranquero <lekktu@gmail.com>
5331
59eb0929
JB
5332 * w32.c (read_unc_volume): Use parameter `henum', instead of
5333 global variable `wget_enum_handle'.
5334
5335 * keymap.c (describe_vector): Remove parameters `indices' and
5336 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5337 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5338
f868cd8a
JB
5339 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5340
5341 * keyboard.c (timer_check): Remove parameter `do_it_now',
5342 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5343 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5344 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5345
5346 * keyboard.c (read_char):
5347 * w32menu.c (w32_menu_display_help):
5348 * xmenu.c (show_help_event, menu_help_callback):
5349 Adjust calls to `show_help_echo'.
5350
5351 * gtkutil.c (xg_maybe_add_timer):
5352 * keyboard.c (readable_events):
5353 * process.c (wait_reading_process_output):
5354 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5355
5356 * insdel.c (adjust_markers_gap_motion):
5357 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5358 (gap_left, gap_right): Don't call it.
5359
2ecf6fdb
CY
53602011-03-25 Chong Yidong <cyd@stupidchicken.com>
5361
5362 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5363 incurred during fontification.
5364
6b1f9ba4
JB
53652011-03-25 Juanma Barranquero <lekktu@gmail.com>
5366
5367 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5368 (DEFVAR_PER_BUFFER): Don't pass it.
5369
5370 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5371 (scrolling_window): Don't pass it.
5372
0f4a96b5
JB
53732011-03-25 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5376
5377 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5378 and `suffix'.
5379 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5380 of variables specific to SELinux and computation of `encoded_absname'.
5381
5382 * image.c (XPutPixel): Remove unused variable `height'.
5383
5384 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5385
5386 * unexw32.c (get_section_info): Remove unused variable `section'.
5387
5388 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5389 (system_process_attributes): Remove unused variable `sess'.
5390 (sys_read): Remove unused variable `err'.
5391
5392 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5393 (w32_wnd_proc): Remove unused variable `isdead'.
5394 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5395 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5396 (x_create_tip_frame): Remove unused variable `tem'.
5397
5398 * w32inevt.c (w32_console_read_socket):
5399 Remove unused variable `no_events'.
5400
5401 * w32term.c (x_draw_composite_glyph_string_foreground):
5402 Remove unused variable `width'.
5403
1149507c
JB
54042011-03-24 Juanma Barranquero <lekktu@gmail.com>
5405
5406 * w32term.c (x_set_glyph_string_clipping):
5407 Don't pass uninitialized region to CombineRgn.
5408
9c88f339
JB
54092011-03-23 Juanma Barranquero <lekktu@gmail.com>
5410
5411 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5412 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5413 (Fx_close_connection): Remove unused variable `i'.
5414
5415 * w32font.c (w32font_draw): Return number of glyphs.
5416 (w32font_open_internal): Remove unused variable `i'.
5417 (w32font_driver): Add missing initializer.
5418
5419 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5420 (fill_in_menu): Remove unused variable `items_added'.
5421
5422 * w32term.c (last_mouse_press_frame): Remove static global variable.
5423 (w32_clip_to_row): Remove unused variable `f'.
5424 (x_delete_terminal): Remove unused variable `i'.
5425
5426 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5427 (NOTHING): Remove unused static global variable.
5428 (uniscribe_check_otf): Remove unused variable `table'.
5429 (uniscribe_font_driver): Add missing initializers.
5430
dee091a3
JD
54312011-03-23 Julien Danjou <julien@danjou.info>
5432
5433 * term.c (Fsuspend_tty, Fresume_tty):
5434 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5435 * window.c (temp_output_buffer_show):
5436 * insdel.c (signal_before_change):
5437 * frame.c (Fhandle_switch_frame):
5438 * fileio.c (Fdo_auto_save):
5439 * emacs.c (Fkill_emacs):
5440 * editfns.c (save_excursion_restore):
5441 * cmds.c (internal_self_insert):
5442 * callint.c (Fcall_interactively):
5443 * buffer.c (Fkill_all_local_variables):
5444 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5445 Use Frun_hooks.
0f4a96b5 5446 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5447 unconditionnaly since it does the check itself.
5448
2c520ab5 54492011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5450
c9c49752
PE
5451 Fix more problems found by GCC 4.5.2's static checks.
5452
8abc3f12
PE
5453 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5454 the first time through the loop, since we know p0 < p1 then.
5455 This also avoids a gcc -Wstrict-overflow warning.
5456
a2d26660
PE
5457 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5458 leading to a memory leak, possible in functions like
5459 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5460 of objects (Bug#8318).
a2d26660 5461
916c72e9
PE
5462 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5463 that could (at least in theory) be that large.
5464
19ab8a18
PE
5465 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5466 This is less likely to overflow, and avoids undefined behavior if
5467 overflow does occur. All callers changed. Use strtoul to scan
5468 for the unsigned long integer.
b7cbbd6f
PE
5469 (pint2hrstr): Simplify and tune code slightly.
5470 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5471
f0641eff
PE
5472 * scroll.c (do_scrolling): Work around GCC bug 48228.
5473 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5474
7f650bb9
PE
5475 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5476 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5477 (validate_x_resource_name): Simplify count usage.
5478 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5479
37dd57d1
PE
5480 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5481 fail (Bug#8306).
81e56e61 5482
699979fc 5483 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5484
401bf9b4
PE
5485 * process.c (Fmake_network_process): Use socklen_t, not int,
5486 where POSIX says socklen_t is required in portable programs.
5487 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5488 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5489 (Fmake_network_process, server_accept_connection):
5490 (wait_reading_process_output, read_process_output):
5491 Likewise.
5492
b93aacde
PE
5493 * process.c: Rename or move locals to avoid shadowing.
5494 (list_processes_1, Fmake_network_process):
5495 (read_process_output_error_handler, exec_sentinel_error_handler):
5496 Rename or move locals.
4dc343ee 5497 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5498 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5499 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5500 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5501 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5502
af8a867c 5503 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5504 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5505 Include tparam.h instead, since it declares them.
af8a867c
PE
5506 * cm.h (PC): Remove extern decl; tparam.h now does this.
5507 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5508 * terminfo.c: Include tparam.h, to check interfaces.
5509 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5510 (tparam): Adjust signature to match interface in tparam.h;
5511 this removes some undefined behavior. Check that outstring and len
5512 are zero, which they always are with Emacs.
5513 * tparam.h (PC, BC, UP): New extern decls.
5514
0248044d 5515 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5516 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5517
8ff096c1 5518 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5519 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5520 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5521 (ftfont_list): Remove unused local.
49eaafba
PE
5522 (get_adstyle_property, ftfont_pattern_entity):
5523 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5524 Rename locals to avoid shadowing.
8ff096c1 5525
e2be39f6
PE
5526 * xfont.c (xfont_list_family): Mark var as initialized.
5527
c9735e30
PE
5528 * xml.c (make_dom): Now static.
5529
8f5201ae
PE
5530 * composite.c (composition_compute_stop_pos): Rename local to
5531 avoid shadowing.
b246f932
PE
5532 (composition_reseat_it): Remove unused locals.
5533 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5534 (composition_update_it): Mark var as initialized.
11b61122
PE
5535 (find_automatic_composition): Mark vars as initialized,
5536 with a FIXME (Bug#8290).
8f5201ae 5537
760fbc2c
PE
5538 character.h: Rename locals to avoid shadowing.
5539 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5540 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5541 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5542 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5543 to avoid shadowing.
5544
ff08eb85
PE
5545 * textprop.c (property_change_between_p): Remove; unused.
5546
fc7bf025
PE
5547 * intervals.c (interval_start_pos): Now static.
5548
235d7abc
PE
5549 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5550
44f230aa
SM
5551 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5552 Rename locals to avoid shadowing.
3e7d6594 5553
50060332
PE
5554 * sound.c (wav_play, au_play, Fplay_sound_internal):
5555 Fix pointer signedness.
d01f234b 5556 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5557 (wav_play): Initialize a variable to 0, to prevent undefined
5558 behavior (Bug#8278).
50060332 5559
c4fc4e30
PE
5560 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5561
918436ed
PE
5562 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5563
c939f91b
PE
5564 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5565 clobbering (Bug#8298).
b9c7f648
PE
5566 * sysdep.c (sys_subshell): Likewise.
5567 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5568
6bd8c144
PE
5569 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5570 This should get cleaned up, so that child_setup has the
5571 same signature on all platforms.
5572
7710357c 5573 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5574 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5575
c59da222
CY
55762011-03-22 Chong Yidong <cyd@stupidchicken.com>
5577
5578 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5579 not to be necessary, and produces flickering.
5580
66b87493
GM
55812011-03-20 Glenn Morris <rgm@gnu.org>
5582
5583 * config.in: Remove file.
5584
45b6f6d5
JB
55852011-03-20 Juanma Barranquero <lekktu@gmail.com>
5586
5587 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5588 are now in src/globals.h.
5589 (syms_of_minibuf): Remove spurious & from previous change.
5590
3ec03f7e
LL
55912011-03-20 Leo <sdl.web@gmail.com>
5592
5593 * minibuf.c (completing-read-function): New variable.
5594 (completing-read-default): Rename from completing-read.
5595 (completing-read): Call completing-read-function.
5596
b14e3e21
CY
55972011-03-19 Juanma Barranquero <lekktu@gmail.com>
5598
5599 * xfaces.c (Fx_load_color_file):
5600 Read color file from absolute filename (bug#8250).
5601
f2b726e6
JB
56022011-03-19 Juanma Barranquero <lekktu@gmail.com>
5603
5604 * makefile.w32-in: Update dependencies.
5605
09f6ff02
EZ
56062011-03-17 Eli Zaretskii <eliz@gnu.org>
5607
5608 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5609
29a6015a
PE
56102011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5611
a3a6c54e
PE
5612 Fix more problems found by GCC 4.5.2's static checks.
5613
b766f867
PE
5614 * process.c (make_serial_process_unwind, send_process_trap):
5615 (sigchld_handler): Now static.
5616
be02381c
PE
5617 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5618 That way, the code declares only the vars that it needs.
5619 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5620 * s/cygwin.h (PTY_ITERATION): Likewise.
5621 * s/darwin.h (PTY_ITERATION): Likewise.
5622 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5623
57048744
PE
5624 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5625 * process.c (allocate_pty): Don't declare stb unless it's needed.
5626
7914961c 5627 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5628 (CONSTANTLIM): Remove; unused.
5629 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5630 Define only if needed.
7914961c 5631
b3967b18
PE
5632 * unexelf.c (unexec): Name an expression,
5633 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5634 Use a different way to cause a compilation error if anyone uses
5635 n rather than nn, a way that does not involve shadowing.
73366a00 5636 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5637
29a6015a
PE
5638 * deps.mk (unexalpha.o): Remove; unused.
5639
43cfc33e 5640 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5641 * unexec.h: New file.
ce701a33
PE
5642 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5643 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5644 Depend on unexec.h.
5645 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5646 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5647 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5648 Change as necessary to match prototype in unexec.h.
ce701a33 5649
01f44d5a
PE
5650 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5651 shadowing.
4f63c6bb 5652 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5653
a6670b0b
PE
5654 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5655 Rename locals to avoid shadowing.
5656
cef2010d 5657 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5658 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5659
d4d7173a
PE
5660 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5661
f08b802a
PE
5662 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5663 warning when compiling print.c.
5664
3ddb0639
PE
5665 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5666 instead of using an uninitialized var.
5ad03b97 5667 (font_sort_entities): Mark var as initialized.
3ddb0639 5668
170a2692
PE
5669 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5670
e663c700
PE
5671 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5672 pointers to constants.
89bc529a 5673 (font_parse_fcname): Remove unused vars.
7b81e2d0 5674 (font_delete_unmatched): Now static.
ea838e10 5675 (font_get_spec): Remove; unused.
13a547c6
PE
5676 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5677 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5678 Rename or move locals to avoid shadowing.
e663c700 5679
2a80c887 5680 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5681 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5682
1384fa33 5683 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5684 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5685
8b2c52e9
PE
5686 * alloc.c (mark_backtrace): Move decl from here ...
5687 * lisp.h: ... to here, so that it can be checked.
5688
475545b5 5689 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5690 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5691 (lisp_indirect_variable): Name an expression,
5692 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5693 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5694
b1349114 5695 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5696 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5697 Use const pointer when appropriate.
b1349114 5698
a2928364
PE
5699 * lisp.h (get_system_name, get_operating_system_release):
5700 Move decls here, to check interfaces.
5701 * process.c (get_operating_system_release): Move decl to lisp.h.
5702 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5703 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5704 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5705 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5706 (Fformat_time_string, Fencode_time, Finsert_char):
5707 (Ftranslate_region_internal, Fformat):
5708 Rename or remove local vars to avoid shadowing.
9710023e 5709 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5710
a415e694
PE
5711 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5712 avoid shadowing.
5713
8ef4622d
PE
5714 * lisp.h (eassert): Check that the argument compiles, even if
5715 ENABLE_CHECKING is not defined.
5716
946f9a5b
PE
5717 * data.c (Findirect_variable): Name an expression, to avoid
5718 gcc -Wbad-function-cast warning.
112396d6 5719 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5720 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5721 (Fmake_variable_buffer_local, Fmake_local_variable):
5722 Mark variables as initialized.
52746918 5723 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5724
e5aab7e7 5725 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5726 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5727 Rename locals to avoid shadowing.
dff45157
PE
5728 (mark_stack): Move local variables into the #ifdef region where
5729 they're used.
7bc26fdb
PE
5730 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5731 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5732 needed otherwise.
5733 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5734 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5735 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5736
e5aab7e7
PE
5737 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5738 avoids undefined behavior in theory.
5739
4da60324
PE
5740 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5741
88043301
PE
5742 Use functions, not macros, for up- and down-casing (Bug#8254).
5743 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5744 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5745 to use the following functions instead of these macros.
5746 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5747 EMACS_INT, since callers assume the returned value fits in int.
5748 (upcase1): Likewise, for UPCASE_TABLE.
5749 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5750 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5751 the race-condition problem in the old DOWNCASE.
88043301 5752
19ed5445
PE
5753 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5754 Rename locals to avoid shadowing.
5755 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5756 (regex_compile, re_search_2, re_match_2_internal):
5757 Remove unused local vars.
952db0d7
PE
5758 (FREE_VAR): Rewrite so as not to use empty "else",
5759 which gcc can warn about.
da053e48 5760 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5761 (RETALLOC_IF): Define only if needed.
5762 (WORDCHAR_P): Likewise. This one is never needed, but is used
5763 only in a comment talking about a compiler bug, so put inside
5764 the #if 0 of that comment.
5765 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5766 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5767 Remove; unused.
19ed5445 5768
1f3561e4 5769 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5770 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5771 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5772
ded6f8f7
PE
5773 * search.c (simple_search): Remove unused var.
5774
dbd37a95
PE
5775 * dired.c (compile_pattern): Move decl from here ...
5776 * lisp.h: ... to here, so that it can be checked.
5777 (struct re_registers): New forward decl.
5778
7e47afad
PE
5779 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5780
85f24f61
PE
5781 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5782 All uses changed.
5783 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5784 Rename locals to avoid shadowing.
5671df8f 5785 (Fvertical_motion): Mark locals as initialized.
85f24f61 5786
181aa2be 5787 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5788 (casify_region): Mark local as initialized.
181aa2be 5789
930d429c
PE
5790 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5791
7082eac6
PE
5792 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5793 New macros, so that the caller can use some names other than
5794 gcpro1, gcpro2, etc.
5795 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5796 of the new macros.
5797 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5798 argument, for consistency with GCPRO2_VAR, etc: it is now the
5799 prefix of the variable, not the variable itself. All uses
5800 changed.
38b2c076
PE
5801 * dired.c (directory_files_internal, file_name_completion):
5802 Rename locals to avoid shadowing.
5803
15206ed9
PE
5804 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5805 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5806 dired.c's scmp function, had undefined behavior.
5807 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5808 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5809 * buffer.h: ... to here, because these macros use current_buffer,
5810 and the new implementation with inline functions needs to have
5811 current_buffer in scope now, rather than later when the macros
5812 are used.
5813 (downcase, upcase1): New static inline functions.
5814 (DOWNCASE, UPCASE1): Reimplement using these functions.
5815 This avoids undefined behavior in expressions like
5816 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5817 from race conditions in accessing the global variables
5818 case_temp1 and case_temp2.
5819 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5820 * lisp.h (case_temp1, case_temp2): Remove their decls.
5821 * character.h (ASCII_CHAR_P): Move from here ...
5822 * lisp.h: ... to here, so that the inline functions mentioned
5823 above can use them.
5824
4a6bea26
PE
5825 * dired.c (directory_files_internal_unwind): Now static.
5826
f14b7e14
PE
5827 * fileio.c (file_name_as_directory, directory_file_name):
5828 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5829 Now static.
2893f146
PE
5830 (file_name_as_directory): Use const pointers when appropriate.
5831 (Fexpand_file_name): Likewise. In particular, newdir might
5832 point at constant storage, so make it a const pointer.
fd4ead52 5833 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5834 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5835 signedness issues.
f839df0c
PE
5836 (Fset_file_times, Finsert_file_contents, auto_save_error):
5837 Rename locals to avoid shadowing.
f14b7e14 5838
5716756e 5839 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5840 (Ftry_completion, Fall_completions): Rename or remove locals
5841 to avoid shadowing.
5716756e 5842
b4c3046a
PE
5843 * marker.c (bytepos_to_charpos): Remove; unused.
5844
b45db522
PE
5845 * lisp.h (verify_bytepos, count_markers): New decls,
5846 so that gcc does not warn that these functions aren't declared.
5847
85876d07
PE
5848 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5849 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5850 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5851 (copy_text): Remove unused local var.
85876d07 5852
03d78a21 5853 * filelock.c (within_one_second): Now static.
b3dd38ab 5854 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5855
5df8f01b
PE
5856 * buffer.c (fix_overlays_before): Mark locals as initialized.
5857 (fix_start_end_in_overlays): Likewise. This function should be
5858 simplified by using pointers-to-pointers, but that's a different
5859 matter.
b1d876f1 5860 (switch_to_buffer_1): Now static.
8f54f30a
PE
5861 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5862 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5863
a70072c9 5864 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5865 Fix pointer signedness issue.
edced198
PE
5866 (sys_subshell): Mark local as volatile if checking for lint,
5867 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5868 (MAXPATHLEN): Define only if needed.
a70072c9 5869
a0977c44
PE
5870 * process.c (serial_open, serial_configure): Move decls from here ...
5871 * systty.h: ... to here, so that they can be checked.
5872
a884fdcc
PE
5873 * fns.c (get_random, seed_random): Move extern decls from here ...
5874 * lisp.h: ... to here, so that they can be checked.
5875
604efe86 5876 * sysdep.c (reset_io): Now static.
b8950c94 5877 (wait_for_termination_signal): Remove; unused.
604efe86 5878
38fc62d9
PE
5879 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5880 (copy_keymap_item, append_key, push_text_char_description):
5881 Now static.
1004a21a 5882 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5883 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5884 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5885 (describe_map_tree):
5886 Rename locals to avoid shadowing.
38fc62d9 5887
2f2650da
PE
5888 * keyboard.c: Declare functions static if they are not used elsewhere.
5889 (echo_char, echo_dash, cmd_error, top_level_2):
5890 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5891 (read_char, kbd_buffer_get_event, make_lispy_position):
5892 (make_lispy_event, make_lispy_movement, apply_modifiers):
5893 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5894 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5895 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5896 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5897 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5898
a053e86c 5899 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5900 (mark_kboards): Move decl here ...
5901 * alloc.c (mark_kboards): ... from here.
a053e86c 5902
4752793e
PE
5903 * lisp.h (force_auto_save_soon): New decl.
5904
74f10ca7 5905 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5906 (DEFINE_DUMMY_FUNCTION): New macro.
5907 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5908 Use it.
c03cd23f
PE
5909 (main): Add casts to avoid warnings
5910 if GCC considers string literals to be constants.
74f10ca7 5911
022e70d4
PE
5912 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5913
59d6fe83
PE
5914 * dbusbind.c: Pointer signedness fixes.
5915 (xd_signature, xd_append_arg, xd_initialize):
5916 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5917 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5918 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5919 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5920
78320123
PE
5921 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5922 if GCC considers string literals to be constants.
49cebcca 5923 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5924
35ac2a97
SM
59252011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5926
fb103ca9
SM
5927 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5928 (print_preprocess, print_object): New macro to fix last change.
5929
35ac2a97
SM
5930 * print.c (print_preprocess): Don't forget font objects.
5931
62973b41
JB
59322011-03-16 Juanma Barranquero <lekktu@gmail.com>
5933
5934 * emacs.c (USAGE3): Doc fixes.
5935
0e48bb22
AS
59362011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5937
5938 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5939 structure.
5940
7684e57b
JB
59412011-03-14 Juanma Barranquero <lekktu@gmail.com>
5942
5943 * lisp.h (VWindow_system, Qfile_name_history):
5944 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5945 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5946 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5947
5948 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5949 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5950
5951 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5952 * w32console.c (detect_input_pending, read_input_pending)
5953 (encode_terminal_code):
5954 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5955 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5956 (w32_system_caret_y, Qfile_name_history):
5957 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5958 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5959 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5960 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5961 * w32proc.c (Qlocal, report_file_error):
5962 * w32term.c (Vwindow_system, updating_frame):
5963 * w32uniscribe.c (initialized, uniscribe_font_driver):
5964 Remove unneeded extern declarations.
5965
2aa46d6c
CY
59662011-03-14 Chong Yidong <cyd@stupidchicken.com>
5967
c96bbc66 5968 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5969
cffc6f3b
CY
59702011-03-13 Chong Yidong <cyd@stupidchicken.com>
5971
5972 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5973 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5974 These macros can no longer be used for assignment.
5975
44f230aa
SM
5976 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5977 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5978 (record_buffer_markers, fetch_buffer_markers): New functions for
5979 recording and fetching special buffer markers.
5980 (set_buffer_internal_1, set_buffer_temp): Use them.
5981
5982 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5983
5984 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5985
5986 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5987 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5988
5989 * xdisp.c (hscroll_window_tree):
5990 (reconsider_clip_changes): Use PT instead of BUF_PT.
5991
d251f04b
EZ
59922011-03-13 Eli Zaretskii <eliz@gnu.org>
5993
5994 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5995 $(EMACS_ROOT)/lib/intprops.h.
5996
f0c77cd1
PE
59972011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5998
3eca4629
PE
5999 Fix more problems found by GCC 4.5.2's static checks.
6000
7c86ee98
PE
6001 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6002 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6003 (xg_free_frame_widgets): Make it clear that a local variable is
6004 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6005 (gdk_window_get_screen): Make it clear that this macro is needed
6006 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6007 (int_gtk_range_get_value): New function, which avoids a diagnostic
6008 from gcc -Wbad-function-cast.
6009 (xg_set_toolkit_scroll_bar_thumb): Use it.
6010 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6011 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6012 (get_utf8_string, xg_get_file_with_chooser):
6013 Rename locals to avoid shadowing.
6014 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6015
41729b81
PE
6016 * xgselect.c (xg_select): Remove unused var.
6017
f0c77cd1
PE
6018 * image.c (four_corners_best): Mark locals as initialized.
6019 (gif_load): Initialize transparent_p to zero (Bug#8238).
6020 Mark another local as initialized.
ec6cf4c6 6021 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6022
ce0ad53d 6023 * image.c (clear_image_cache): Now static.
d5d5a617 6024 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6025 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6026 (x_edge_detection): Remove unnecessary cast that
6027 gcc -Wbad-function-cast diagnoses.
2037898d 6028 (gif_load): Fix pointer signedness.
6ae141d6
PE
6029 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6030 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6031
33383987 60322011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6033
d32df629
PE
6034 Improve quality of tests for time stamp overflow.
6035 For example, without this patch (encode-time 0 0 0 1 1
6036 1152921504606846976) returns the obviously-bogus value (-948597
6037 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6038 reports time overflow. See
6039 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6040 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6041 * editfns.c: Include limits.h and intprops.h.
6042 (TIME_T_MIN, TIME_T_MAX): New macros.
6043 (time_overflow): Move earlier, to before first use.
6044 (hi_time, lo_time): New functions, for an accurate test for
6045 out-of-range times.
6046 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6047 (Fget_internal_run_time): Don't assume time_t fits in int.
6048 (make_time): Use list2 instead of Fcons twice.
6049 (Fdecode_time): More accurate test for out-of-range times.
6050 (check_tm_member): New function.
6051 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6052 (lisp_time_argument): Don't rely on undefined left-shift and
6053 right-shift behavior when checking for time stamp overflow.
8be6f318 6054
fe31d94c
PE
6055 * editfns.c (time_overflow): New function, refactoring common code.
6056 (Fformat_time_string, Fdecode_time, Fencode_time):
6057 (Fcurrent_time_string): Use it.
6058
8be6f318
PE
6059 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6060 * dired.c (make_time): Move to ...
6061 * editfns.c (make_time): ... here.
6062 * systime.h: Note the move.
6063
09d9db2c 60642011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6065
126bc0dc
YM
6066 * fringe.c (update_window_fringes): Remove unused variables.
6067
c47cbdfd
YM
6068 * unexmacosx.c (copy_data_segment): Also copy __got section.
6069 (Bug#8223)
6070
7ac80be9
EZ
60712011-03-12 Eli Zaretskii <eliz@gnu.org>
6072
c96bbc66 6073 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6074 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6075 Constify `char *' arguments and their references according to
6076 prototypes in tparam.h.
6077
ecb0f94d 6078 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6079
7ac80be9
EZ
6080 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6081 Adapt all references accordingly.
6082
6083 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6084
ef1fd07e
TT
60852011-03-11 Tom Tromey <tromey@redhat.com>
6086
6087 * buffer.c (syms_of_buffer): Remove obsolete comment.
6088
7ef4b50c
EZ
60892011-03-11 Eli Zaretskii <eliz@gnu.org>
6090
6091 * termhooks.h (encode_terminal_code): Declare prototype.
6092
6093 * msdos.c (encode_terminal_code): Don't declare prototype.
6094
6095 * term.c (encode_terminal_code): Now external again, used by
6096 w32console.c and msdos.c.
6097
44f230aa
SM
6098 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6099 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6100
4b1ec863 61012011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6102
1714f52b 6103 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6104
4b1ec863
PE
6105 * fringe.c (update_window_fringes): Mark locals as initialized
6106 (Bug#8227).
6107 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6108
524c7aa6
PE
6109 * alloc.c (mark_fringe_data): Move decl from here ...
6110 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6111 to check its interface.
6112 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6113
a5c0af81 6114 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6115 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6116 (fontset_font): Mark local as initialized.
a9a06e0b 6117 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6118
b4716021
PE
6119 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6120
811e9bac 6121 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6122 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6123 (x_own_selection, Fx_disown_selection_internal): Rename locals
6124 to avoid shadowing.
6125 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6126
7e3ab302
PE
6127 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6128 so that the caller can use some name other than gcpro1.
6129 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6130 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6131 (Fx_backspace_delete_keys_p):
6132 Use them to avoid shadowing, and rename vars to avoid shadowing.
6133 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6134 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6135 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6136 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6137 Remove unused locals.
7e3ab302
PE
6138 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6139 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6140 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6141 macros.
f78faa98 6142
e2b13473
PE
6143 * xterm.h (x_mouse_leave): New decl.
6144
77f23912
PE
6145 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6146 Remove unused functions.
cdf4ba58
PE
6147 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6148 (x_calc_absolute_position): Now static.
7411c686 6149 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6150 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6151 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6152 unless they are used.
38d0b34a
PE
6153 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6154 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6155 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6156 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6157 (x_error_catcher, x_connection_closed, x_error_handler):
6158 (x_error_quitter, xembed_send_message, x_iconify_frame):
6159 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6160 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6161 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6162
44f230aa
SM
6163 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6164 Rename or move locals to avoid shadowing.
6b463e58 6165 (tty_defined_color, merge_face_heights): Now static.
5967d051 6166 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6167 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6168 does not deduce is never used uninitialized.
73719eba
PE
6169 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6170 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6171
426994c3 6172 * terminal.c (store_terminal_param): Now static.
5489860b 6173
032f1620 6174 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6175 (set_frame_menubar): Remove unused local.
d4323972 6176 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6177 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6178 since they might point to immutable storage.
281585b0
PE
6179 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6180 since it's unused otherwise.
032f1620 6181
367c19e5 6182 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6183 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6184 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6185 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6186 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6187 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6188 does not deduce are never used uninitialized.
70739cbe 6189
07b48fa9
PE
6190 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6191
8868a238 6192 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6193 * window.c (window_loop, size_window):
6194 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6195
7e5cf297 6196 * window.c (display_buffer): Now static.
d6550a9f
PE
6197 (size_window): Mark variables that gcc -Wuninitialized
6198 does not deduce are never used uninitialized.
a586633d
PE
6199 * window.h (check_all_windows): New decl, to forestall
6200 gcc -Wmissing-prototypes diagnostic.
5b555da1 6201 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6202
f6095868
PE
6203 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6204 shadowing.
6205 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6206 Include <limits.h>.
6207 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6208 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6209 (load_charset_map): Mark variables that gcc -Wuninitialized
6210 does not deduce are never used uninitialized.
53df7c11 6211 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6212
f38b440c
PE
6213 * coding.c (coding_set_source, coding_set_destination):
6214 Use "else { /* comment */ }" rather than "else /* comment */;"
6215 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6216 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6217 a block, when the outer 'i' will do.
6218 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6219 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6220 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6221 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6222 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6223 Rename locals to avoid shadowing.
6224 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6225 * coding.c (emacs_mule_char, encode_invocation_designation):
6226 Now static, since they're not used elsewhere.
413bb2db 6227 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6228 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6229 (decode_coding_emacs_mule): Mark variables that gcc
6230 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6231 (detect_coding_iso_2022): Initialize a local variable that might
6232 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6233 this initialization is needed. (Bug#8211)
5f58e762
PE
6234 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6235 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6236 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6237 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6238 Remove unused macros.
f38b440c 6239
232b38b9 6240 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6241 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6242 * character.c (string_count_byte8): Likewise.
232b38b9 6243
fb90da1b
PE
6244 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6245 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6246
fb93dbc2
PE
6247 * chartab.c (copy_sub_char_table): Now static, since it's not used
6248 elsewhere.
5c156ace
PE
6249 (sub_char_table_ref_and_range, char_table_ref_and_range):
6250 Rename locals to avoid shadowing.
bbcd0949 6251 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6252
7d3b3862 6253 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6254 (BIDI_BOB): Remove unused macro.
7d3b3862 6255
6be7d3da
PE
6256 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6257 deduce are never used uninitialized.
c2ed9c8b 6258 * term.c (encode_terminal_code): Likewise.
6be7d3da 6259
75f8807f 6260 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6261
50938595
PE
6262 * tparam.h: New file.
6263 * term.c, tparam.h: Include it.
6264 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6265 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6266 Move these decls to tparam.h, and make them agree with what
6267 is actually in tparam.c. The previous trick of using incompatible
6268 decls in different modules does not conform to the C standard.
6269 All callers of tparam changed to use tparam's actual API.
6270 * tparam.c (tparam1, tparam, tgoto):
6271 Use const pointers where appropriate.
6272
fbceeba2
PE
6273 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6274 * cm.h (struct cm): Likewise.
6275 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6276 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6277 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6278 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6279 (turn_on_face, init_tty): Likewise.
6280 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6281
7f3f1250
PE
6282 * term.c (term_mouse_position): Rename local to avoid shadowing.
6283
e6ca6543
PE
6284 * alloc.c (mark_ttys): Move decl from here ...
6285 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6286
c40f8d15
AS
62872011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6288
6289 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6290
cfe0661d
JB
62912011-03-09 Juanma Barranquero <lekktu@gmail.com>
6292
6293 * search.c (compile_pattern_1): Remove argument regp, unused since
6294 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6295 (compile_pattern): Don't pass it.
6296
0afb4571
J
62972011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6298
6299 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6300 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6301 for ! HAVE_GTK3.
6302 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6303
6304 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6305
6306 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6307 gdk_window_get_screen, gdk_window_get_geometry,
6308 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6309 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6310 (xg_get_pixbuf_from_pixmap): New function.
6311 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6312 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6313 Call xg_get_pixbuf_from_pixmap instead of
6314 gdk_pixbuf_get_from_drawable.
6315 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6316 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6317 (xg_check_special_colors): Use GtkStyleContext and its functions
6318 for HAVE_GTK3.
6319 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6320 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6321 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6322 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6323 Call gtk_widget_get_preferred_size.
0afb4571
J
6324 (xg_frame_resized): gdk_window_get_geometry only takes 5
6325 parameters.
44f230aa
SM
6326 (xg_win_to_widget, xg_event_is_for_menubar):
6327 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6328 (xg_set_widget_bg): New function.
6329 (delete_cb): New function.
895009e1 6330 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6331 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6332 (xg_set_background_color): Call xg_set_widget_bg.
6333 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6334 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6335 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6336 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6337 if ! HAVE_GTK3.
6338 (update_frame_tool_bar): Call gtk_widget_hide.
6339 (xg_initialize): Use GDK_KEY_g.
6340
6341 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6342 if ! HAVE_GTK3
6343 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6344
6345 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6346 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6347 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6348
1c2cc4ef
JB
63492011-03-08 Juanma Barranquero <lekktu@gmail.com>
6350
6351 * w32xfns.c (select_palette): Check success of RealizePalette against
6352 GDI_ERROR, not zero.
6353
33383987 6354See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6355
6356;; Local Variables:
6357;; coding: utf-8
aac0c6e3
MR
6358;; End:
6359
33383987 6360 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6361
6362 This file is part of GNU Emacs.
6363
6364 GNU Emacs is free software: you can redistribute it and/or modify
6365 it under the terms of the GNU General Public License as published by
6366 the Free Software Foundation, either version 3 of the License, or
6367 (at your option) any later version.
6368
6369 GNU Emacs is distributed in the hope that it will be useful,
6370 but WITHOUT ANY WARRANTY; without even the implied warranty of
6371 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6372 GNU General Public License for more details.
6373
6374 You should have received a copy of the GNU General Public License
6375 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.