* emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
356e7178
PE
12012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
065c9eb4
PE
3 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
4 This variable's comment says Emacs needs at least one GDB-visible
5 symbol of type enum pvec_type, to work around GDB problems.
6 The symbol's value doesn't matter.
7
356e7178
PE
8 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
9 that causes compilation to fail on pre-C99 compilers.
10
95f61aa2
JB
112012-07-04 Juanma Barranquero <lekktu@gmail.com>
12
13 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
14 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
15
3884d954
DA
162012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
17
d209e2fb 18 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
19 headers for buffer_defaults and buffer_local_symbols.
20 Reported by Juanma Barranquero <lekktu@gmail.com>.
21
ee28be33
SM
222012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
23
24 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
25 * lisp.h (enum pvec_type): Use fewer bits.
26 (PSEUDOVECTOR_SIZE_BITS): New constant.
27 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
28 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
29 change in pvec_type.
30 (PSEUDOVECTOR_TYPEP): New macro.
31 (TYPED_PSEUDOVECTORP): Use it.
32 * fns.c (internal_equal): Adapt code to extract pvectype.
33 * emacs.c (gdb_pvec_type): Update type.
34 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
35 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
36 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
37 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
38 (sweep_vectors): Use it. Use local var `total_bytes' instead of
39 abusing vector->header.next.nbytes.
40 (live_vector_p): Use PVEC_TYPE.
41 (mark_object): Adapt code to extract pvectype. Use switch.
42
c7f2cd7f
PE
432012-07-04 Paul Eggert <eggert@cs.ucla.edu>
44
45 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
46 Tighten new eassert a bit.
47
8ce70ed2
DA
482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
49
50 Fix compilation with --enable-gcc-warnings and -O1
51 optimization level.
52 * doprnt.c (doprnt): Change type of tem to int, initialize
53 to avoid compiler warning. Add eassert.
54 * search.c (simple_search): Initialize match_byte to avoid
55 compiler warning. Add eassert.
56
dea7f1e5
PE
572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
58
24a212eb
PE
59 Avoid weird behavior with large horizontal scrolls.
60 Without this change, for example, large hscroll values would
61 mess up Emacs's display on Fedora 15 x86, presumably due to
62 overflows in int calculations in the display code.
63 Also, if buffers had long lines, Emacs would freeze.
64 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
65 (set_window_hscroll): New function, containing the old guts of
66 Fset_window_hscroll. Return the clipped value.
67 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
68 This avoids the need to check against PTRDIFF_MAX.
69
dea7f1e5
PE
70 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
71
76046526
DA
722012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
73
74 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
75
39adff0d
PE
762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
77
63807d47
PE
78 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
79 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
80 since GCC 4.4.6 issues a bogus warning for them.
81
39adff0d
PE
82 Fix bugs in file timestamp newness comparisons.
83 * fileio.c (Ffile_newer_than_file_p):
84 * lread.c (Fload): Use full timestamp resolution of files,
85 not just the 1-second resolution, so that files that are only
86 slightly newer still count as newer.
87 * fileio.c (Ffile_newer_than_file_p): Don't assume file
88 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
89
dbeed9a6
PE
902012-07-03 Paul Eggert <eggert@cs.ucla.edu>
91
92 * fileio.c: Improve handling of file time marker. (Bug#11852)
93 (special_mtime): New function.
94 (Finsert_file_contents, Fverify_visited_file_modtime):
95 Use it to set special mtime values consistently.
96
636334d6
AS
972012-07-03 Andreas Schwab <schwab@linux-m68k.org>
98
99 * fileio.c (Finsert_file_contents): Properly handle st_mtime
100 marker for non-existing file. (Bug#11852)
101
e2017fe2
GM
1022012-07-03 Glenn Morris <rgm@gnu.org>
103
104 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
105 and did not make it into globals.h).
106
404dbd37
TT
1072012-07-03 Tom Tromey <tromey@redhat.com>
108
109 * window.c (Fset_window_margins, Fset_window_fringes)
110 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
111 * textprop.c (Fprevious_property_change): No longer static.
112 * syntax.c (Fsyntax_table_p): No longer static.
113 * process.c (Fget_process, Fprocess_datagram_address): No longer
114 static.
115 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
116 * keyboard.c (Fcommand_execute): No longer static.
117 Remove EXFUN.
118 * insdel.c (Fcombine_after_change_execute): No longer static.
119 * image.c (Finit_image_library): No longer static.
120 * fileio.c (Fmake_symbolic_link): No longer static.
121 * eval.c (Ffetch_bytecode): No longer static.
122 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
123 * doc.c (Fdocumentation_property, Fsnarf_documentation):
124 No longer static.
404dbd37
TT
125 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
126 static.
127 * dired.c (Ffile_attributes): No longer static.
128 * composite.c (Fcomposition_get_gstring): No longer static.
129 * callproc.c (Fgetenv_internal): No longer static.
130
131 * ccl.h: Remove EXFUNs.
132 * buffer.h: Remove EXFUNs.
133 * dispextern.h: Remove EXFUNs.
134 * intervals.h: Remove EXFUNs.
135 * fontset.h: Remove EXFUN.
136 * font.h: Remove EXFUNs.
137 * dosfns.c (system_process_attributes): Remove EXFUN.
138 * keymap.h: Remove EXFUNs.
139 * lisp.h: Remove EXFUNs.
140 * w32term.h: Remove EXFUNs.
141 * window.h: Remove EXFUNs.
142 * xsettings.h: Remove EXFUN.
143 * xterm.h: Remove EXFUN.
144
8e4fd1e1
GM
1452012-07-03 Glenn Morris <rgm@gnu.org>
146
147 * lisp.h (Frandom): Make it visible to C.
148 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
149 buffer for invisible buffers. (Bug#1229)
150
ca95b3eb
DA
1512012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
152
153 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
154 values which aren't power of 2.
155 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
156 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
157 accordingly.
158
7555c33f
SM
1592012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
160
161 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
162
163 * alloc.c (mark_object): Revert part of last patch to use `switch'.
164
d12e8f5a
DA
1652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
166
167 * alloc.c (allocate_vector_block): Remove redundant
168 calls to mallopt if DOUG_LEA_MALLOC is defined.
169 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
170 avoid calls to mallopt if zero_vector is returned.
171
296094c3
DA
1722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
173
174 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
175 is enabled, avoid dereferencing NULL current_sblock if
176 running undumped.
177
36429c89
DA
1782012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
179
180 Cleanup basic buffer management.
181 * buffer.h (struct buffer): Change layout to use generic vector
182 marking code. Fix some comments. Change type of 'clip_changed'
183 to bitfield. Remove unused #ifndef old.
184 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
185 (GET_OVERLAYS_AT): Fix indentation.
186 (for_each_per_buffer_object_at): New macro.
187 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
188 (Fbuffer_local_variables): Use it.
189 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
190 * alloc.c (allocate_buffer): Adjust to match new layout of
191 struct buffer. Fix comment.
192 (mark_overlay): New function.
193 (mark_buffer): Use it. Use mark_vectorlike to mark normal
194 Lisp area of struct buffer.
195 (mark_object): Use it. Adjust marking of misc objects
196 and related comments.
197
3b3e4cac
PE
1982012-07-02 Paul Eggert <eggert@cs.ucla.edu>
199
200 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
201 wrapper that is not needed because the wrapped code is a no-op (zero
202 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
203 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
204
cf5c0175
DA
2052012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
206
207 * alloc.c (mark_buffer): Simplify. Remove prototype.
208 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 209 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
210 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
211 redundant calls to mark_vectorlike for bool vectors.
212
ca26824c
GM
2132012-06-30 Glenn Morris <rgm@gnu.org>
214
2e4c5312
GM
215 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
216
ca26824c
GM
217 * epaths.in (PATH_SITELOADSEARCH): New.
218 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
219 This is rather than relying on --enable-locallisppath elements
220 having "site-lisp" in their names. (Bug#10208#25, 11658)
221
0d23c240
EZ
2222012-06-30 Eli Zaretskii <eliz@gnu.org>
223
c9240d7a
EZ
224 * w32proc.c (sys_select): Accept and ignore one more argument.
225
226 * w32.c (emacs_gnutls_pull): Call select with one more argument.
227
0d23c240 228 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 229 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
230
231 * sysdep.c: Don't include dos.h and dosfns.h.
232
233 * process.c (sys_select):
234 * msdos.c (sys_select): Accept one more argument and ignore it.
235
236 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
237 adapt data types and code to that.
238
239 * dosfns.c:
240 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
241 which clashes with the gnulib function of the same name.
242
af5a5a98
AS
2432012-06-30 Andreas Schwab <schwab@linux-m68k.org>
244
c5e4379c
AS
245 * font.c (font_style_to_value, font_style_symbolic)
246 (font_prop_validate_style): Add type checks for values in
247 font_style_table.
248
af5a5a98
AS
249 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
250 argument.
251 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
252 uses.
253
8d38f461
EZ
2542012-06-29 Eli Zaretskii <eliz@gnu.org>
255
2e5a6631
EZ
256 * xdisp.c (try_window_id): Undo last change.
257
8d38f461
EZ
258 * w32.c (getwd): Adjust commentary about startup_dir.
259 (init_environment): Always call sys_access, even in non-MSVC
260 builds. Don't chdir to the directory of the Emacs executable.
261 This undoes code from 1997 which was justified by the need to
262 "avoid conflicts when removing and renaming directories". But its
263 downside was that every relative file name was being interpreted
264 relative to the directory of the Emacs executable, which can never
265 be TRT. In particular, it broke sys_access when called with
266 relative file names.
267 (sys_access): Map GetLastError to errno.
268
2af3565e
DA
2692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
270
271 * window.h (struct window): Change type of 'fringes_outside_margins'
272 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 273 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
274 Adjust comment.
275 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
276 to ptrdiff_t.
277
c8d3a25c 2782012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 279
c8d3a25c
GM
280 * gnutls.c (emacs_gnutls_handshake):
281 Add QUIT to make the loop interruptible.
57570cd3 282
c8d3a25c 2832012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 284
c8d3a25c
GM
285 * charset.c (init_charset): Make lack of etc/charsets fatal.
286
3e984ee8
DA
2872012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
288
289 * editfns.c (region_limit): Fix type mismatch.
290
ef884f23
DA
2912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
292
293 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
294 undefined. Convert from xassert to eassert.
295 * nsmenu.m: Convert from xassert to eassert.
296 * nsterm.m: Likewise.
297
7d7e0027
SM
2982012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
299
300 * editfns.c (region_limit): Clip to narrowing (bug#11770).
301
aa754e6a
PE
3022012-06-28 Paul Eggert <eggert@cs.ucla.edu>
303
304 Avoid integer overflow on scroll-left and scroll-right.
305 * window.c (HSCROLL_MAX): New macro.
306 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
307 overflow when requested scroll falls outside ptrdiff_t range.
308
80b00b08
DA
3092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
310
311 * window.h (struct window): Change type of 'hscroll',
312 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
313 'last_modified' and 'last_overlay_modified' to EMACS_INT.
314 Adjust users accordingly.
315 * xdisp.c (try_cursor_movement): Replace type check with eassert.
316 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
317 from EMACS_INT to ptrdiff_t.
318 (make_window): Omit redundant initialization.
319
62b2bcf6
JB
3202012-06-28 Juanma Barranquero <lekktu@gmail.com>
321
322 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
323
45942c7d
DA
3242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
325
326 * window.h (struct window): Change type of 'use_time' and
327 'sequence_number' from Lisp_Object to int.
328 * frame.c (make_frame): Adjust users accordingly.
329 * print.c (print_object): Likewise.
330 * window.c (select_window, Fwindow_use_time, make_parent_window)
331 (make_window): Likewise.
332
e509cfa6
DA
3332012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
334
335 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
336 enabled with --enable-checking=[all,glyphs] configure option.
337 Fix GLYPH_DEBUG usage assuming that it may be undefined,
338 adjust comments accordingly.
339 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
340 undefined, adjust comments accordingly.
341 * image.c: Likewise.
342 * scroll.c: Likewise.
343 * w32fns.c: Likewise.
344 * w32term.c: Likewise.
345 * xdisp.c: Likewise.
346 * xfaces.c: Likewise.
347 * xfns.c: Likewise.
348 * xterm.c: Likewise.
349
a54e2c05
DA
3502012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Generalize run-time debugging checks.
353 * dispextern.h (XASSERTS): Remove.
354 * fontset.c (xassert): Remove.
355 Convert from xassert to eassert.
356 * alloc.c: Convert from xassert to eassert.
357 * bidi.c: Likewise.
358 * dispnew.c: Likewise.
359 * fns.c: Likewise.
360 * fringe.c: Likewise.
361 * ftfont.c: Likewise.
362 * gtkutil.c: Likewise.
363 * image.c: Likewise.
364 * keyboard.c: Likewise.
365 * menu.c: Likewise.
366 * process.c: Likewise.
367 * scroll.c: Likewise.
368 * sound.c: Likewise.
369 * term.c: Likewise.
370 * w32console.c: Likewise.
371 * w32fns.c: Likewise.
372 * w32term.c: Likewise.
373 * window.c: Likewise.
374 * xdisp.c: Likewise.
375 * xfaces.c: Likewise.
376 * xfns.c: Likewise.
377 * xselect.c: Likewise.
378 * xterm.c: Likewise.
379
1ec4b7b2
SM
3802012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * fns.c (maybe_resize_hash_table): Output message when growing the
383 purify-hashtable.
384
2014308a
DA
3852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
386
387 * alloc.c (allocate_string_data): Remove dead code.
388 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
389 avoid GCC warning about unused macro.
390
246155eb
DA
3912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
392
393 * alloc.c (allocate_string): Omit intervals initialization.
394 * alloc.c (make_uninit_multibyte_string): Initialize intervals
395 as in make_pure_string and make_pure_c_string.
396
43184b7b
DA
3972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
398
d209e2fb 399 * alloc.c (allocate_string): Fix last change.
43184b7b 400
3fe6dd74
DA
4012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
402
d209e2fb 403 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
404 to memset, add explicit initialization where appropriate.
405
1ba6038a
GM
4062012-06-27 Glenn Morris <rgm@gnu.org>
407
408 * lisp.mk (lisp): Remove paths.elc.
409
c89926a5
CY
4102012-06-27 Chong Yidong <cyd@gnu.org>
411
412 * doc.c (Fsubstitute_command_keys): Fix punctuation.
413
ed6b3510
JW
4142012-06-26 John Wiegley <johnw@newartisans.com>
415
1ec4b7b2 416 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
417 on Mac OS X Lion: __mod_init_func and __mod_term_func.
418
ed6b3510
JW
419 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
420 when building with Clang.
421
8edd4a2b
SM
4222012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
423
424 * eval.c (Fapply): Allow calling it with a single argument.
425
f6f62d1b
EZ
4262012-06-26 Eli Zaretskii <eliz@gnu.org>
427
428 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
429 _stricmp and _strnicmp.
430 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
431
62efea5e
DA
4322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
433
434 * alloc.c (allocate_window): Zero out non-Lisp part of newly
435 allocated window.
436 (allocate_process): Likewise for new process.
8edd4a2b 437 (allocate_terminal): Change to use offsetof.
62efea5e
DA
438 (allocate_frame): Likewise.
439 * frame.c (make_frame): Omit redundant initialization.
440 * window.c (make_parent_window): Use memset.
441 (make_window): Omit redundant initialization.
442 * process.c (make_process): Omit redundant initialization.
443 * terminal.c (create_terminal): Likewise.
444
42997f4d
DA
4452012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
446
447 * term.c (delete_tty): Remove redundant call to memset.
448
1130ecfc
DA
4492012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
450
451 * alloc.c: Remove build_string.
452 * lisp.h: Define build_string as static inline. This provides
453 a better opportunity to optimize away calls to strlen when the
454 function is called with compile-time constant argument.
455 * image.c (imagemagick_error): Convert to build_string.
456 * w32proc.c (sys_spawnve): Likewise.
457 * xterm.c (x_term_init): Likewise.
458
cf38a720
PE
4592012-06-26 Paul Eggert <eggert@cs.ucla.edu>
460
99027bdd
PE
461 Use sprintf return value instead of invoking strlen on result.
462 In the old days this wasn't portable, since some sprintf
463 implementations returned char *. But they died out years ago and
464 Emacs already assumes sprintf returns int.
465 Similarly for float_to_string.
466 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
467 * ccl.c (ccl_driver):
468 * character.c (string_escape_byte8):
469 * data.c (Fnumber_to_string):
470 * doprnt.c (doprnt):
471 * print.c (print_object):
472 * xdisp.c (message_dolog):
473 * xfns.c (syms_of_xfns):
474 Use sprintf or float_to_string result to avoid need to call strlen.
475 * data.c (Fnumber_to_string):
476 Use make_unibyte_string, since the string must be ASCII.
477 * lisp.h, print.c (float_to_string): Now returns int length.
478 * term.c (produce_glyphless_glyph):
479 Use sprintf result rather than recomputing it.
480
cf38a720
PE
481 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
482 * Makefile.in (ALL_CFLAGS):
483 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
484 * gmalloc.c, regex.c: Include <config.h> unconditionally.
485
3511c784
DA
4862012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
487
0a08eb21 488 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
489 strcasecmp if available.
490 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
491
fb7da12e
AS
4922012-06-25 Andreas Schwab <schwab@linux-m68k.org>
493
494 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
495 Avoid comma operator.
496 * menu.c (push_submenu_start, push_submenu_end)
497 (push_left_right_boundary, push_menu_pane): Likewise.
498 * msdos.c (dos_rawgetc): Likewise.
499
afa2ffd8
DA
5002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
501
502 * xfns.c (xic_create_fontsetname): Remove redundant calls
503 to memset.
504
b3b4476b
PE
5052012-06-25 Paul Eggert <eggert@cs.ucla.edu>
506
4495ff38
PE
507 * gtkutil.c (get_utf8_string): Remove redundant assignment.
508 sprintf already null-terminates its output.
509
b3b4476b
PE
510 * xfns.c (x_window): Remove redundant cast.
511
b00876c9
DA
5122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
513
514 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
515 `const char *' to `char *' to avoid compiler warning.
516
d188e26b
PE
5172012-06-24 Paul Eggert <eggert@cs.ucla.edu>
518
885d1d74
PE
519 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
520 instead of truncating it to 63 (admittedly a generous limit).
521
d188e26b
PE
522 * process.c: Fix spelling and caps in comments.
523
e2f560b1
DN
5242012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
525
e86db54b 526 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
527 * sysdep.c (setpgrp): Remove definition, not used in this file.
528
7583a3a1
JB
5292012-06-24 Juanma Barranquero <lekktu@gmail.com>
530
531 * makefile.w32-in: Update dependencies.
532
696056c2
EZ
5332012-06-24 Eli Zaretskii <eliz@gnu.org>
534
535 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
536 (SYSTIME_H): Add nt/inc/sys/time.h.
537
538 * systime.h [WINDOWSNT]: Include sys/time.h.
539
540 * s/ms-w32.h (struct timespec): Definition moved from
541 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
542
845ca893
PE
5432012-06-24 Paul Eggert <eggert@cs.ucla.edu>
544
545 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
546 * buffer.h (buffer_slot_type_mismatch):
547 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
548 * eval.c (unwind_to_catch):
549 * image.c (my_png_error, my_error_exit):
550 * keyboard.c (quit_throw_to_read_char, user_error)
551 (Fexit_recursive_edit, Fabort_recursive_edit):
552 * lisp.h (die, args_out_of_range, args_out_of_range_3)
553 (wrong_type_argument, buffer_overflow, __executable_start)
554 (memory_full, buffer_memory_full, string_overflow, Fthrow)
555 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
556 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
557 (fatal):
558 (child_setup) [!DOS_NT]:
559 * lread.c (end_of_file_error, invalid_syntax):
560 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
561 * puresize.h (pure_write_error):
562 * search.c (matcher_overflow):
563 * sound.c (sound_perror, alsa_sound_perror):
564 * sysdep.c, syssignal.h (croak):
565 * term.c (maybe_fatal, vfatal):
566 * textprop.c (text_read_only):
567 * undo.c (user_error):
568 * unexmacosx.c (unexec_error):
569 * xterm.c (x_ins_del_lines, x_delete_glyphs):
570 Use _Noreturn rather than NO_RETURN.
571 No need for separate decl merely because of _Noreturn.
572 * sound.c (sound_warning, parse_sound):
573 Remove unnecessary forward decls.
574
f1dd8073
PE
5752012-06-24 Paul Eggert <eggert@cs.ucla.edu>
576
577 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
578 * lisp.h (WAIT_READING_MAX): New macro.
579 * dispnew.c (Fsleep_for, sit_for):
580 * keyboard.c (kbd_buffer_get_event):
581 * process.c (Faccept_process_output):
582 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
583 This improves on the previous patch, which introduced a bug
584 when time_t is unsigned and as wide as intmax_t.
585 See <http://bugs.gnu.org/9000#51>.
586
b82c1755
EZ
5872012-06-23 Eli Zaretskii <eliz@gnu.org>
588
589 * dispnew.c (sit_for, Fsleep_for):
590 * keyboard.c (kbd_buffer_get_event):
591 * process.c (Faccept_process_output): Avoid compiler warnings when
592 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
593
ca300656
JB
5942012-06-23 Juanma Barranquero <lekktu@gmail.com>
595
049ec95b
JB
596 * makefile.w32-in: Update dependencies.
597
ca300656
JB
598 * w32.c (ltime): Add return type and declare static.
599 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
600
db7b8d06
PE
6012012-06-23 Paul Eggert <eggert@cs.ucla.edu>
602
603 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
604 Privately reported by Herbert J. Skuhra.
605 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
606 All uses changed.
607 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
608 not make_lisp_timeval, when the argument is of type EMACS_TIME.
609
0bd8297f
EZ
6102012-06-23 Eli Zaretskii <eliz@gnu.org>
611
96512555
EZ
612 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
613 last argument of make_unibyte_string.
614
0bd8297f
EZ
615 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
616 language ID in the event parameters.
617
618 * w32term.c (w32_read_socket): Put the new keyboard codepage into
619 event.code, not the obscure "character set ID".
620
63def6b6
CY
6212012-06-23 Chong Yidong <cyd@gnu.org>
622
623 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
624
e8a02204
EZ
6252012-06-23 Eli Zaretskii <eliz@gnu.org>
626
388cdec0
EZ
627 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
628 * w32.c (fdutimens): New function.
629
630 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
631
632 * s/ms-w32.h (pselect): Redirect to sys_select.
633
634 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
635
e8a02204
EZ
636 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
637 in the logic of incrementing and decrementing the value of
638 use_relocatable_buffers.
639
d054f3fb
PE
6402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
641
642 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
643 Privately reported by Herbert J. Skuhra.
644 [__FreeBSD__]: Remove "*/" typo after "#include".
645 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
646 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
647 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
648 Don't assume EMACS_TIME and struct timeval are the same type.
649
d35af63c
PE
6502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
651
652 Support higher-resolution time stamps (Bug#9000).
653 The time stamps are only nanosecond-resolution at the C level,
654 since that's the best that any real-world system supports now.
655 But they are picosecond-resolution at the Lisp level, as that's
656 easy, and leaves room for future OS improvements.
657
658 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
659 (LIBES): Use it.
660
661 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
662 Don't get current time unless it's needed.
663
664 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
665 now provides it if it's absent.
666 (start_atimer): Port to higher-res time stamps.
667 Check for time stamp overflow. Don't get current time more
668 often than is needed.
669
670 * buffer.h (struct buffer): Buffer modtime now has high resolution.
671 Include systime.h, not time.h.
672 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
673
674 * dired.c: Include stat-time.h.
675 (Ffile-attributes): File times now have higher resolution.
676
677 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
678 (struct image): Timestamp now has higher resolution.
679
680 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
681 has at least microseconds now. All uses removed.
682 (update_frame, update_single_window, update_window, update_frame_1)
683 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
684
685 * editfns.c (time_overflow): Now extern.
686 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
687 (float-time, Fformat_time_string, Fcurrent_time_string)
688 (Fcurrent_time_zone): Accept and generate higher-resolution
689 time stamps.
690 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
691 (decode_time_components, lisp_seconds_argument): New functions.
692 (make_time): Now static.
693 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
694 Report an error if the time is invalid, rather than having the caller
695 do that.
696
697 * fileio.c: Include <stat-time.h>
698 (Fcopy_file): Copy higher-resolution time stamps.
699 Prefer to set the time stamp via a file descriptor if that works.
700 (Fset_file_times, Finsert_file_contents, Fwrite_region)
701 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
702 (Fvisited_file_modtime, Fset_visited_file_modtime):
703 Support higher-resolution time stamps.
704
705 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
706
707 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
708
709 * image.c (prepare_image_for_display, clear_image_cache)
710 (lookup_image): Port to higer-resolution time stamps.
711
712 * keyboard.c (start_polling, bind_polling_period):
713 Check for time stamp overflow.
714 (read_char, kbd_buffer_get_event, timer_start_idle)
715 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
716 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
717 Port to higher-resolution time stamps. Do not assume time_t is signed.
718 (decode_timer): New function. Timers are now vectors of length 9,
719 not 8, to accommodate the picosecond component.
720 (timer_check_2): Use it.
721
722 * nsterm.m (select_timeout, timeval_subtract): Remove.
723 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
724 as they're a bit more accurate and handle overflow better.
725 (ns_select): Change prototype to be compatible with pselect.
726 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
727 * nsterm.h (ns_select): Adjust prototype.
728
729 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
730 us-resolution time stamps.
731 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
732
733 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
734
735 * lisp.h (time_overflow): New decl.
736 (wait_reading_process_output): First arg is now intmax_t, not int,
737 to accommodate larger waits.
738
739 * process.h (struct Lisp_Process.read_output_delay):
740 Now counts nanoseconds, not microseconds.
741 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
742 EMACS_HAS_USECS.
743 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
744 (wait_reading_process_output):
745 Port to ns-resolution time stamps.
746 (Faccept_process_output, wait_reading_process_output):
747 Check for time stamp overflow. Do not assume time_t is signed.
748 (select_wrapper): Remove; we now use pselect.
749 (Fprocess_attributes): Now generates ns-resolution time stamps.
750
751 * sysdep.c: Include utimens.h. Don't include utime.h
752 or worry about struct utimbuf; gnulib does that for us now.
753 (gettimeofday): Remove; gnulib provides a substitute.
754 (make_timeval): New function.
755 (set_file_times): Now sets ns-resolution time stamps.
756 New arg FD; all uses changed.
757 (time_from_jiffies, ltime_from_jiffies, get_up_time)
758 (system_process_attributes):
759 Now returns ns-resolution time stamp. All uses changed.
760 Check for time stamp overflow.
761
762 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
763 provides a substitute now.
764
765 * systime.h: Include timespec.h rather than sys/time.h and time.h,
766 since it guarantees struct timespec.
767 (EMACS_TIME): Now struct timespec, so that we can support
768 ns-resolution time stamps.
769 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
770 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
771 (EMACS_USECS): Remove.
772 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
773 so multiply the arg by 1000 before storing it.
774 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
775 New macros.
776 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
777 Port to ns-resolution time stamps.
778 (EMACS_TIME_NEG_P): Remove; replaced by....
779 (EMACS_TIME_SIGN): New macro.
780 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
781 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
782 (set_file_times, make_time, lisp_time_argument): Adjust signature.
783 (make_timeval, make_lisp_time, decode_time_components): New decls.
784 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
785 that it mishandled time_t overflow. You can't compare by subtracting!
786 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
787 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
788
789 * term.c: Include <sys/time.h>.
790 (timeval_to_Time): New function, for proper overflow wraparound.
791 (term_mouse_position, term_mouse_click): Use it.
792
793 * undo.c (record_first_change): Support higher-resolution time stamps
794 in the undo buffer.
795 (Fprimitive_undo): Use them when restoring time stamps.
796
797 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
798 (w32_get_internal_run_time):
799 Port to higher-resolution Emacs time stamps.
800 (ltime): Now accepts single 64-bit integer, as that's more convenient
801 for callers.
802
803 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
804
805 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
806 for compatibility with pselect. Support ns-resolution time stamps.
807
808 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
809
810 * xselect.c (wait_for_property_change, x_get_foreign_selection):
811 Check for time stamp overflow, and support ns-resolution time stamps.
812
813 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
814 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
815 (timeval_subtract): Remove; no longer needed.
816 (XTflash, XTring_bell, x_wait_for_event):
817 Port to ns-resolution time stamps. Don't assume time_t is signed.
818
b6a92dfe
CY
8192012-06-22 Chong Yidong <cyd@gnu.org>
820
821 * xdisp.c (x_consider_frame_title): Revert last change.
822
d251c37c
EZ
8232012-06-22 Eli Zaretskii <eliz@gnu.org>
824
825 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
826 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
827 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
828 staticidx goes up to 1597 out of 1600 = 0x640.)
829
f10deafb
PE
8302012-06-20 Paul Eggert <eggert@cs.ucla.edu>
831
832 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
833 Otherwise, the umask might be mistakenly 0 while handling input signals.
834
ec6de1e2
SM
8352012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
836
837 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
838
28be1ada
DA
8392012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
840
841 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
842 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
843 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
844 access to `contents' member of Lisp_Vector objects with AREF and ASET
845 where appropriate.
846
c6bf3022
CY
8472012-06-19 Chong Yidong <cyd@gnu.org>
848
849 * frame.c (delete_frame): When selecting a frame on a different
850 text terminal, do not alter the terminal's top-frame.
851
852 * xdisp.c (format_mode_line_unwind_data): Record the target
853 frame's selected window and its terminal's top-frame.
854 (unwind_format_mode_line): Restore them.
855 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
856 Callers changed.
857 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
858 since tty frames can be explicitly named.
859 (prepare_menu_bars): Likewise.
860
861 * term.c (Ftty_top_frame): New function.
862
defd4196
PE
8632012-06-18 Paul Eggert <eggert@cs.ucla.edu>
864
865 Port byte-code-meter to modern targets.
866 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
867 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 868 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
869 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
870 (METER_1, METER_2): Simplify.
871
1053a871
SM
8722012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
873
874 * data.c (Fdefalias): Return `symbol' (bug#11686).
875
b7e8d081
MR
8762012-06-18 Martin Rudalics <rudalics@gmx.at>
877
878 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
879 gets killed during executing of this function (Bug#11665).
880 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
881 (Vkill_buffer_query_functions): In doc-string say that functions
882 run by this hook should not change the current buffer.
883
7ea2b339
PE
8842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
885
886 Fix recently-introduced process.c problems found by static checking.
887 * process.c (write_queue_push, write_queue_pop, send_process):
888 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
889 (write_queue_pop): Fix pointer signedness problem.
890 (send_process): Remove unused local.
891
96a313a1
CY
8922012-06-17 Chong Yidong <cyd@gnu.org>
893
894 * xdisp.c (redisplay_internal): No need to redisplay terminal
895 frames that are not on top.
896
20ca2e94
TN
8972012-06-17 Troels Nielsen <bn.troels@gmail.com>
898
899 * process.c (make_process): Initialize write_queue.
900 (write_queue_push, write_queue_pop): New functions.
901 (send_process): Use them to maintain correct ordering of process
902 writes (Bug#10815).
903
9a900ca9
PE
9042012-06-17 Paul Eggert <eggert@cs.ucla.edu>
905
310fbfa8
PE
906 * lisp.h (eassert): Assume C89 or later.
907 This removes the need for CHECK.
908 (CHECK): Remove. Its comments about always evaluating its
909 argument were confusing, as 'eassert' typically does not evaluate
910 its argument.
911
27bb1ca4
PE
912 * coding.c (produce_chars): Use ptrdiff_t, not int.
913
9a900ca9
PE
914 * xterm.c (x_draw_underwave): Check for integer overflow.
915 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
916
41b7f8bc 9172012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
918
919 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
920 referenced (Bug#11583).
921
9b0e3eba
AA
9222012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
923
924 Implement wave-style variant of underlining.
925 * dispextern.h (face_underline_type): New enum.
926 (face): Add field for underline type.
927 * nsterm.m (ns_draw_underwave): New function.
928 (ns_draw_text_decoration): Use it.
929 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
930 New functions.
931 (x_draw_glyph_string): Use them.
932 * xfaces.c (Qline, Qwave): New Lisp objects.
933 (check_lface_attrs, merge_face_ref)
1053a871
SM
934 (Finternal_set_lisp_face_attribute, realize_x_face):
935 Handle wave-style underline face attributes.
9b0e3eba
AA
936 * xterm.c (x_draw_underwave): New function.
937 (x_draw_glyph_string): Use it.
938
0fb52f11
JB
9392012-06-16 Juanma Barranquero <lekktu@gmail.com>
940
941 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
942 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
943 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
944 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
945 ($(BLD)/w32select.$(O)): Update dependencies.
946
e5560ff7
AS
9472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
948
949 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
950 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
951 * character.c (_fetch_multibyte_char_p): Remove.
952 * alloc.c: Include "character.h" before "buffer.h".
953 * bidi.c: Likewise.
954 * buffer.c: Likewise.
955 * bytecode.c: Likewise.
956 * callint.c: Likewise.
957 * callproc.c: Likewise.
958 * casefiddle.c: Likewise.
959 * casetab.c: Likewise.
960 * category.c: Likewise.
961 * cmds.c: Likewise.
962 * coding.c: Likewise.
963 * composite.c: Likewise.
964 * dired.c: Likewise.
965 * dispnew.c: Likewise.
966 * doc.c: Likewise.
967 * dosfns.c: Likewise.
968 * editfns.c: Likewise.
969 * emacs.c: Likewise.
970 * fileio.c: Likewise.
971 * filelock.c: Likewise.
972 * font.c: Likewise.
973 * fontset.c: Likewise.
974 * fringe.c: Likewise.
975 * indent.c: Likewise.
976 * insdel.c: Likewise.
977 * intervals.c: Likewise.
978 * keyboard.c: Likewise.
979 * keymap.c: Likewise.
980 * lread.c: Likewise.
981 * macros.c: Likewise.
982 * marker.c: Likewise.
983 * minibuf.c: Likewise.
984 * nsfns.m: Likewise.
985 * nsmenu.m: Likewise.
986 * print.c: Likewise.
987 * process.c: Likewise.
988 * regex.c: Likewise.
989 * region-cache.c: Likewise.
990 * search.c: Likewise.
991 * syntax.c: Likewise.
992 * term.c: Likewise.
993 * textprop.c: Likewise.
994 * undo.c: Likewise.
995 * unexsol.c: Likewise.
996 * w16select.c: Likewise.
997 * w32fns.c: Likewise.
998 * w32menu.c: Likewise.
999 * window.c: Likewise.
1000 * xdisp.c: Likewise.
1001 * xfns.c: Likewise.
1002 * xmenu.c: Likewise.
1003 * xml.c: Likewise.
1004 * xselect.c: Likewise.
1005
2f07e6af
EZ
10062012-06-16 Eli Zaretskii <eliz@gnu.org>
1007
1053a871
SM
1008 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1009 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1010 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1011 row.
1012 (handle_face_prop): Use chunk-relative overlay string index when
1013 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1014 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1015 the rightmost. (Bug#11720)
2f07e6af 1016
29b83cec
AS
10172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1018
1019 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1020 (CATEGORY_MEMBER): Enforce 1/0 value.
1021 * category.c (_temp_category_set): Remove.
1022
4c5501e9
EZ
10232012-06-16 Eli Zaretskii <eliz@gnu.org>
1024
1025 * window.c (Fdelete_other_windows_internal)
1026 (Fdelete_window_internal): Don't access frame's mouse highlight
1027 info of the initial frame. (Bug#11677)
1028
2b570124
PE
10292012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1030
e93864f9
PE
1031 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1032 Assume USE_2_TAGS_FOR_INTS.
1033 (xreload): Adjust $tagmask width to match recent lisp.h change.
1034
2b570124
PE
1035 Simplify lisp.h in minor ways that should not affect code.
1036 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1037 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1038 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1039 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1040 (INTTYPEBITS): New macro, for clarity.
1041 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1042 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1043 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1044 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1045 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1046
81755f69
JB
10472012-06-13 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1050
16192a57
GM
10512012-06-13 Glenn Morris <rgm@gnu.org>
1052
1053 * s/bsd-common.h (BSD4_3):
1054 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1055
646b5f55
AS
10562012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1057
1058 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1059 instead of union.
1060 (XLI, XIL): Define.
1053a871
SM
1061 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1062 Use them.
1063 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1064 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1065 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1066 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1067 * frame.c (delete_frame): Remove outdated comment.
1068 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1069 USE_LISP_UNION_TYPE.
1070 (Fw32_unregister_hot_key): Likewise.
1071 (Fw32_toggle_lock_key): Likewise.
1072 * w32menu.c (add_menu_item): Likewise.
1073 (w32_menu_display_help): Use XIL instead of checking
1074 USE_LISP_UNION_TYPE.
1075 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1076 (init_heap): Likewise.
1077 * w32term.c (w32_read_socket): Update comment.
1078
1d3823c9
GM
10792012-06-13 Glenn Morris <rgm@gnu.org>
1080
c62ff706
GM
1081 * s/usg5-4-common.h, src/s/unixware.h:
1082 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1083
1d3823c9
GM
1084 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1085
bfe3e0a2
PE
10862012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1089 * alloc.c (make_number) [!defined make_number]:
1090 Remove, as lisp.h always defines this now.
1091 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1092 (roundup_size): Verify that it is a power of 2.
1093 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1094 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1095 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1096 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1097 USE_LSB_TAG now is always defined to be either 0 or 1.
1098 All uses changed.
1099 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1100 code works fine either way, and efficiency is not a concern here,
1101 as the union type is for debugging, not for production.
1102 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1103 Use an inline function on all platforms when using the union type,
1104 since this is simpler and 'static inline' can be used portably
1105 within Emacs now.
1106 (LISP_INITIALLY_ZERO): New macro.
1107 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1108 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1109
45fa9c0f
GM
11102012-06-12 Glenn Morris <rgm@gnu.org>
1111
b4492cba
GM
1112 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1113
1114 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1115
45fa9c0f
GM
1116 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1117 Move BROKEN_SIGIO to configure.
1118
1119 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1120 Move NO_TERMIO to configure.
1121
0e25d334
CY
11222012-06-12 Chong Yidong <cyd@gnu.org>
1123
1124 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1125 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1126 MagickExportImagePixels is undefined.
1127
43682bb6
PE
11282012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * image.c (imagemagick_load_image): Remove unused label.
1131
a9be7d2b
GM
11322012-06-11 Glenn Morris <rgm@gnu.org>
1133
1134 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1135 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1136 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1137 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1138
3017f87f
SM
11392012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1140
1141 * alloc.c (make_byte_code): New function.
1142 (Fmake_byte_code): Use it. Don't purify here.
1143 * lread.c (read1): Use it as well to avoid extra allocation.
1144
1b9b4cf4
CY
11452012-06-11 Chong Yidong <cyd@gnu.org>
1146
1147 * image.c (imagemagick_load_image): Implement transparency.
1148
95988fcf
AS
11492012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1150
1151 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1152 account for preceding backslashes. (Bug#11663)
1153
cd4eb164
CY
11542012-06-09 Chong Yidong <cyd@gnu.org>
1155
1156 * term.c: Support italics in capable terminals (Bug#9652).
1157 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1158 (turn_on_face): Output using TS_enter_italic_mode if available.
1159 Don't handle unused blinking and alt-charset cases.
1160 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1161 and tty_alt_charset_p cases.
1162 (tty_capable_p, init_tty): Support italics.
1163
1164 * termchar.h (struct tty_display_info): Add field for italics.
1165 Remove unused blink field.
1166
1167 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1168 Handle slant.
1169
1170 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1171 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1172 tty_alt_charset_p. Add tty_italic_p.
1173
ff88beb8
MA
11742012-06-09 Michael Albinus <michael.albinus@gmx.de>
1175
1176 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1177 dbus_type_is_basic if available.
1178 (xd_extract_signed, xd_extract_unsigned): Rename from
1179 extract_signed and extract_unsigned, respectively. Adapt callers.
1180
44286096
CY
11812012-06-09 Chong Yidong <cyd@gnu.org>
1182
1682701f
CY
1183 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1184
44286096
CY
1185 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1186 case (Bug#9752).
1187
d86feb17
PE
11882012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 * xdisp.c (vmessage): Treat frame message as multibyte.
1191 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1192 would generate the diagnostic "Making \302\247 buffer-local while
1193 let-bound!".
1194
d5c20fe8
EZ
11952012-06-08 Eli Zaretskii <eliz@gnu.org>
1196
1197 * dispnew.c (showing_window_margins_p): Undo last change, which
1198 was done due to an inadvertent commit.
1199 (adjust_frame_glyphs_for_frame_redisplay): Do call
1200 showing_window_margins_p.
1201
513749ee
SM
12022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1203
1204 * eval.c (Fmake_var_non_special): New primitive.
1205 (syms_of_eval): Defsubr it.
1206 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1207
d4a8f5c1
JB
12082012-06-08 Juanma Barranquero <lekktu@gmail.com>
1209
1210 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1211 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1212
8bbbc977
EZ
12132012-06-08 Eli Zaretskii <eliz@gnu.org>
1214
1215 * alloc.c (allocate_vectorlike): Fix last change.
1216
f3372c87
DA
12172012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1218
1219 Block-based vector allocation of small vectors.
1220 * lisp.h (struct vectorlike_header): New field `nbytes',
1221 adjust comment accordingly.
1222 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1223 to denote vector blocks. Adjust users (live_vector_p,
1224 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1225 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1226 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1227 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1228 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1229 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1230 (roundup_size): New constant.
1231 (struct vector_block): New data type.
1232 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1233 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1234 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1235 (sweep_vectors): New functions.
1236 (allocate_vectorlike): Return `zero_vector' as the only vector of
1237 0 items. Allocate new vector from block if vector size is less than
1238 or equal to VBLOCK_BYTES_MAX.
1239 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1240 (init_alloc_once): Add call to init_vectors.
1241
4f18a4ed
SM
12422012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1243
1244 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1245
86f158bc
PE
12462012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1247
1248 * doprnt.c (doprnt): Truncate multibyte char correctly.
1249 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1250 would mishandle a string argument "Xc" if X was a multibyte
1251 character of length 2: it would truncate after X's first byte
1252 rather than including all of X.
1253
c5cfcbe0
CY
12542012-06-06 Chong Yidong <cyd@gnu.org>
1255
1256 * buffer.c (word_wrap): Doc fix.
1257
c05cf390
PE
12582012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1259
1260 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1261
0c3461de
GM
12622012-06-03 Glenn Morris <rgm@gnu.org>
1263
1264 * xdisp.c (tool-bar-style): Doc fix.
1265
c71232db
UM
12662012-06-03 Ulrich Müller <ulm@gentoo.org>
1267
1268 * Makefile.in (PAXCTL): Define.
1269 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1270 binary via PaX flags if the paxctl utility is available.
1271 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1272 Restore PaX flags to their default. (Bug#11398)
1273
383f7350
CY
12742012-06-03 Chong Yidong <cyd@gnu.org>
1275
1276 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1277 buffer (Bug#11226).
1278
5f2c76c6
CY
12792012-06-03 Chong Yidong <cyd@gnu.org>
1280
1281 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1282 (note_mode_line_or_margin_highlight): If there is no help echo,
1283 use mode-line-default-help-echo. Handle the case where the mouse
1284 position is past the end of the mode line string.
1285
1286 * buffer.c (buffer_local_value_1): New function, split from
1287 Fbuffer_local_value; can return Qunbound.
1288 (Fbuffer_local_value): Use it.
1289 (Vmode_line_format): Docstring tweaks.
1290
773d47f6
PE
12912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1292
1293 * sysdep.c (system_process_attributes): Improve comment.
1294
f2d6a3df
SM
12952012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1296
1297 * keyboard.c: Export real-this-command to Elisp.
1298 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1299 and DEFVAR it. Update all users.
1300
63810350
PE
13012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1302
7bd5c1f4
PE
1303 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1304
63810350
PE
1305 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1306 Convert pctcpu and pctmem to Lisp float properly.
1307 Let the compiler fold better, as 100.0/0x8000 is exact.
1308
a2821611
AS
13092012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1310
1311 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1312 cons_block.
1313
5fceba1d
PE
13142012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1317
c98ff5dd
DA
13182012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1319
1320 For a 'struct window', replace some Lisp_Object fields to
1321 bitfields where appropriate, remove unused fields.
1322 * window.h (struct window): Remove unused 'last_mark_x' and
1323 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1324 change it's type from Lisp_Object to bitfield.
1325 Change type of 'force_start', 'optional_new_start',
1326 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1327 fields from Lisp_Object to bitfield. Adjust users accordingly.
1328
ca34e0be
PE
13292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 Pacify gcc -Wdouble-precision when using Xaw.
1332 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1333 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1334 Use 'float' consistently, rather than 'float' in most places
1335 and 'double' in a couple of places.
1336
efc00ab1 13372012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1338
1339 * xdisp.c (handle_stop): Detect whether we have overlay strings
1340 loaded by testing it->current.overlay_string_index to be
1341 non-negative, instead of checking whether n_overlay_strings is
1342 positive. (Bug#11587)
1343
efc00ab1 13442012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1345
1346 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1347
1348 * doc.c (Fsubstitute_command_keys): Doc fix.
1349
efc00ab1 13502012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1351
1352 * search.c (search_buffer): Remove calls to
1353 r_alloc_inhibit_buffer_relocation, as it is now called by
1354 maybe_unify_char, which was the cause of relocation of buffer text
1355 in bug#11519.
1356
efc00ab1 13572012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1358
1359 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1360 for the duration of call to load_charset, to avoid problems with
1361 callers of maybe_unify_char that access buffer text through C
1362 pointers.
1363
1364 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1365 decrement the inhibition flag, instead of just setting or
1366 resetting it.
1367
ba93a187
PE
13682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 Remove obsolete '#define static' cruft.
1371 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1372 This #undef was "temporary" in 2000; it is no longer needed
1373 now that '#define static' has gone away.
1374 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1375 (gray_bitmap_bits): Remove; no longer needed.
1376 All uses replaced with definiens.
1377 * xterm.c: Include "bitmaps/gray.xbm".
1378
9e4bf381
PE
13792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 Clean up __executable_start, monstartup when --enable-profiling.
1382 The following changes affect the code only when profiling.
1383 * dispnew.c (__executable_start): Rename from safe_bcopy.
1384 Define only on platforms that need it.
1385 * emacs.c: Include <sys/gmon.h> when profiling.
1386 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1387 (__executable_start): Remove decl, since lisp.h does it now.
1388 (safe_bcopy): Remove decl; no longer has that name.
1389 (main): Coalesce #if into single bit of code, for simplicity.
1390 Cast pointers to uintptr_t, since standard libraries want integers
1391 and not pointers.
1392 * lisp.h (__executable_start): New decl.
1393
32d72c2f
GM
13942012-05-31 Glenn Morris <rgm@gnu.org>
1395
1396 * image.c (Fimagemagick_types): Doc fix.
1397
baac5bc7
JM
13982012-05-30 Jim Meyering <meyering@redhat.com>
1399
1400 * callproc.c (Fcall_process_region): Include directory component
1401 in mkstemp error message (Bug#11586).
1402
72cb32cf
PE
14032012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1404
1405 * alloc.c, lisp.h (make_pure_vector): Now static.
1406
61b108cc
SM
14072012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1408
1409 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1410 Move to byte-run.el.
1411 (Fautoload): Do the hash-doc more carefully.
1412 * data.c (Fdefalias): Purify definition, except for keymaps.
1413 (Qdefun): Move from eval.c.
1414 * lisp.h (Qdefun): Remove.
1415 * lread.c (read1): Tiny simplification.
1416
471fe23d
TN
14172012-05-29 Troels Nielsen <bn.troels@gmail.com>
1418
934f3f58 1419 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1420 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1421 Bug#9642, but explicitly check that the buffer the overlay would
1422 be moved to is live and rearrange lines to make sure that errors
1423 will not put the overlay in an inconsistent state.
1424 (Fdelete_overlay): Cosmetics.
1425
85d0efd1
EZ
14262012-05-28 Eli Zaretskii <eliz@gnu.org>
1427
1428 * w32term.c (my_bring_window_to_top): New function.
1429 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1430 could be different from the original one.
1431 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1432 (Bug#11513)
1433
1434 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1435 by calling BringWindowToTop.
1436
1437 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1438 (WM_EMACS_END): Increase by one.
1439
da92a98c
PE
14402012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1443 This avoids undefined behavior that might cause the eassert
1444 to not catch an out-of-range value.
1445
74d1f848
JB
14462012-05-28 Juanma Barranquero <lekktu@gmail.com>
1447
1448 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1449 Update dependencies.
1450
9e1a06fc
EZ
14512012-05-27 Eli Zaretskii <eliz@gnu.org>
1452
1453 * bidi.c (bidi_mirror_char): Fix last change.
1454
f3dd7312
AS
14552012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1456
1457 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1458 when referring to sectname field in printf format.
1459
81899c91
PE
14602012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1461
57b81a9f
PE
1462 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1463 Only r_alloc_inhibit_buffer_relocation needed to be added;
1464 the others were already declared.
1465
81899c91
PE
1466 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1467 before checking whether it's out of range. Put the check inside
1468 eassert. See
1469 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1470
33017faf 14712012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1472
1473 * callproc.c (Fcall_process): Restore a line that was accidentally
1474 commented out in the 2011-02-13 change (bug#11547).
1475
33017faf 14762012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1477
1478 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1479 defined on ralloc.c.
1480
1481 * buffer.c [REL_ALLOC]: Remove prototypes of
1482 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1483 they are now on lisp.h.
1484
1485 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1486
1487 * search.c (search_buffer): Use it to inhibit relocation of buffer
1488 text while re_search_2 is doing its job, because re_search_2 is
1489 passed C pointers to buffer text. (Bug#11519)
1490
23415acf
EZ
1491 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1492 Update value to 24.
1493
44e27368
EZ
1494 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1495 state after an additional call to move_it_in_display_line_to, keep
1496 the values of it->max_ascent and it->max_descent found for the
1497 entire line.
1498 (pos_visible_p): Revert the comparison against bottom_y to what it
1499 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1500 (Bug#11464)
1501
c1892f11
PE
15022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 Fix coding-related core dumps with gcc -ftrapv.
1505 The code was computing A - B, where A and B are pointers, and B is
1506 random garbage. This can lead to core dumps on platforms that
1507 have special pointer registers, and it also leads to core dumps on
1508 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1509 A - B only when B is initialized properly.
1510 * coding.c (coding_set_source, coding_set_destination): Return void.
1511 (coding_change_source, coding_change_destinations): New functions,
1512 with the old behaviors of coding_set_source and coding_set_destination.
1513 All callers that need an offset changed to use these new functions.
1514
eb7afdad
GM
15152012-05-26 Glenn Morris <rgm@gnu.org>
1516
1517 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1518
f12fdf02
EZ
15192012-05-26 Eli Zaretskii <eliz@gnu.org>
1520
53a63be6 1521 Extend mouse support on W32 text-mode console.
61b108cc
SM
1522 * xdisp.c (draw_row_with_mouse_face):
1523 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1524
eb3f6f01 1525 * w32console.c: Include window.h.
61b108cc
SM
1526 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1527 New functions.
eb3f6f01
EZ
1528 (initialize_w32_display): Initialize mouse-highlight data.
1529
53a63be6
EZ
1530 * w32inevt.c: Include termchar.h and window.h.
1531 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1532 moves, call note_mouse_highlight. If help_echo changed, call
1533 gen_help_event to produce help-echo message in the echo area.
1534 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1535 highlight info.
1536
4cfd81f6
PE
15372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1538
1539 * lread.c (read1): Simplify slightly to avoid an overflow warning
1540 with GCC 4.7.0 on x86-64.
1541
4446092a
EZ
15422012-05-26 Eli Zaretskii <eliz@gnu.org>
1543
1544 * bidi.c (bidi_mirror_char): Revert last change: an int is
1545 definitely wide enough here.
1546
42b2a986 15472012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1548
42b2a986 1549 Fix integer width and related bugs (Bug#9874).
eb106a49 1550 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1551 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1552 (string_bytes, check_sblock, allocate_string_data):
1553 (compact_small_strings, Fmake_bool_vector, make_string)
1554 (make_unibyte_string, make_multibyte_string)
1555 (make_string_from_bytes, make_specified_string)
1556 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1557 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1558 (mark_vectorlike):
1559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1560 (allocate_pseudovector):
1561 Use int, not EMACS_INT, where int is wide enough.
1562 (inhibit_garbage_collection, Fgarbage_collect):
1563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1564 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1565 int might not be wide enough.
1566 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1567 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1568 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1569 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1570 (bidi_level_of_next_char, bidi_move_to_visually_next):
1571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1572 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1573 (Fkill_buffer, Fset_buffer_major_mode)
1574 (advance_to_char_boundary, Fbuffer_swap_text)
1575 (Fset_buffer_multibyte, overlays_at, overlays_in)
1576 (overlay_touches_p, struct sortvec, record_overlay_string)
1577 (overlay_strings, recenter_overlay_lists)
1578 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1579 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1580 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1581 (Foverlay_recenter, last_overlay_modification_hooks_used)
1582 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1584 (validate_region): Omit unnecessary test for b <= e,
1585 since that's guaranteed by the previous test.
d311d28c
PE
1586 (adjust_overlays_for_delete): Avoid pos + length overflow.
1587 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1588 (report_overlay_modification):
1589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1590 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1591 Omit pointer cast, which isn't needed anyway, and doesn't work
1592 after the EMACS_INT -> ptrdiff_t change.
02481186 1593 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1594 * buffer.h: Adjust decls to match defn changes elsewhere.
1595 (struct buffer_text, struct buffer):
1596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1597 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1598 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1599 not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 (exec_byte_code): Use tighter memory-full test, one that checks
1601 for alloca overflow. Don't compute the address of the object just
1602 before an array, as that's not portable. Use EMACS_INT, not
1603 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1604 * callint.c (Fcall_interactively):
1605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1606 * callproc.c (call_process_kill, Fcall_process):
1607 Don't assume pid_t fits into an Emacs fixnum.
1608 (call_process_cleanup, Fcall_process, child_setup):
1609 Don't assume pid_t fits into int.
1610 (call_process_cleanup, Fcall_process, delete_temp_file)
1611 (Fcall_process_region):
1612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1613 (Fcall_process): Simplify handling of volatile integers.
1614 Use int, not EMACS_INT, where int will do.
1615 * casefiddle.c (casify_object, casify_region, operate_on_word)
1616 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1618 (casify_object): Avoid integer overflow when overallocating buffer.
1619 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1620 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1621 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1622 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1623 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1624 integers are now checked earlier. All uses replaced with XINT.
1625 (ccl_driver):
1626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1627 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1628 (ccl_driver, Fregister_code_conversion_map):
1629 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1630 (resolve_symbol_ccl_program): Check that vector header is in range.
1631 Always copy the vector, so that we can check its contents reliably
1632 now rather than having to recheck each instruction as it's being
1633 executed. Check that vector words fit in 'int'.
1634 (ccl_get_compiled_code, Fregister_ccl_program)
1635 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1636 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1637 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1638 contents are in range.
1639 (Fccl_execute_on_string): Check that status is in range.
1640 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1641 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1642 Accept and return EMACS_INT, not int, because callers can pass values
1643 out of 'int' range.
1644 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1645 (multibyte_chars_in_text, parse_str_as_multibyte)
1646 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1647 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1648 (string_escape_byte8, Fget_byte):
1649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1650 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1651 avoid mishandling large integers.
1652 * character.h: Adjust decls to match defn changes elsewhere.
1653 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1654 (Ffind_charset_region):
1655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1656 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1657 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1658 Don't assume fixnum fits in int.
d311d28c
PE
1659 (load_charset_map_from_vector, Fmap_charset_chars):
1660 Remove now-unnecessary CHECK_NATNUMs.
1661 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1662 Don't rely on undefined behavior with signed left shift overflow.
1663 Don't assume unsigned int fits into fixnum, or that fixnum fits
1664 into unsigned int. Don't require max_code to be a valid fixnum;
1665 that's not true for gb10830 4-byte on a 32-bit host. Allow
1666 invalid_code to be a cons, for the same reason. Require code_offset
1667 to be a character. Avoid int overflow if max_char is close
1668 to INT_MAX.
1669 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1670 this is intended anyway and avoids some undefined behavior.
1671 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1672 INDEX_TO_CODE_POINT, as that's what it expects.
1673 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1674 * charset.h (DECODE_CHAR): Return int, not unsigned;
1675 this is what was intended anyway, and it avoids undefined behavior.
1676 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1677 integer-overflow issues.
1678 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1679 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1680 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1681 * chartab.c (Fmake_char_table, Fset_char_table_range)
1682 (uniprop_get_decoder, uniprop_get_encoder):
1683 Don't assume fixnum fits in int.
1684 * cmds.c (move_point): New function, that does the gist of
1685 Fforward_char and Fbackward_char, but does so while checking
1686 for integer overflow more accurately.
c96e5d6a 1687 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1688 (Fforward_line, Fend_of_line, internal_self_insert)
1689 (internal_self_insert):
1690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1691 Fix a FIXME, by checking for integer overflow when calculating
1692 target_clm and actual_clm.
1693 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1694 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1695 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1696 (coding_alloc_by_making_gap, alloc_destination)
1697 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1698 (encode_coding_utf_16, detect_coding_emacs_mule)
1699 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1700 (detect_coding_iso_2022, decode_coding_iso_2022)
1701 (encode_invocation_designation, encode_designation_at_bol)
1702 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1703 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1704 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1705 (encode_coding_ccl, encode_coding_raw_text)
1706 (detect_coding_charset, decode_coding_charset)
1707 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1708 (produce_composition, produce_charset, produce_annotation)
1709 (decode_coding, handle_composition_annotation)
1710 (handle_charset_annotation, consume_chars, decode_coding_gap)
1711 (decode_coding_object, encode_coding_object, detect_coding_system)
1712 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1713 (code_convert_region, code_convert_string)
8f50130c
PE
1714 (Fdefine_coding_system_internal)
1715 (coding_set_source, coding_set_destination):
d311d28c
PE
1716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1717 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1718 (Fdefine_coding_system_internal):
1719 Don't assume fixnums fit in int.
1720 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1721 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1722 (Funencodable_char_position, Fcheck_coding_systems_region)
1723 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1725 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1726 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1727 Don't access memory outside of the args array.
d311d28c 1728 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1729 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1730 result of ENCODE_CHAR.
d311d28c
PE
1731 * coding.h: Adjust decls to match defn changes elsewhere.
1732 (struct coding_system):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 * composite.c (get_composition_id, find_composition)
1735 (run_composition_function, update_compositions)
1736 (compose_text, composition_gstring_put_cache)
1737 (composition_gstring_p, composition_gstring_width)
1738 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1739 (composition_compute_stop_pos, composition_reseat_it)
1740 (composition_update_it, struct position_record)
1741 (find_automatic_composition, composition_adjust_point)
1742 (Fcomposition_get_gstring, Ffind_composition_internal):
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 (update_compositions):
1745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1746 * composite.h: Adjust decls to match defn changes elsewhere.
1747 (struct composition):
1748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1749 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1750 Do not attempt to compute the address of the object just before a
1751 buffer; this is not portable.
1752 (Faref, Faset):
1753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1754 (Faset): Use int, not EMACS_INT, where int is wide enough.
1755 (Fstring_to_number): Don't assume fixnums fit in int.
1756 (Frem): Don't assume arg is nonnegative.
1757 * dbusbind.c (xd_append_arg): Check for integers out of range.
1758 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1759 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1760 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1761 (xd_get_connection_references): Return ptrdiff_t, not int.
1762 All uses changed.
1763 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1764 (xd_read_message_1):
1765 Use int, not unsigned, where the dbus API uses int.
1766 (Fdbus_message_internal): Don't overflow mtype.
1767 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1768 * dired.c (directory_files_internal, file_name_completion, scmp)
1769 (file_name_completion_stat):
1770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1771 (file_name_completion): Don't overflow matchcount.
1772 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1773 * dispextern.h: Adjust decls to match defn changes elsewhere.
1774 (struct text_pos, struct glyph, struct bidi_saved_info)
1775 (struct bidi_string_data, struct bidi_it, struct composition_it)
1776 (struct it):
1777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1778 (struct display_pos, struct composition_it, struct it):
1779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1780 * dispnew.c (increment_matrix_positions)
1781 (increment_row_positions, mode_line_string)
1782 (marginal_area_string):
1783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1784 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1786 (duration_to_sec_usec): New function, to check for overflow better.
1787 (Fsleep_for, sit_for): Use it.
1788 * doc.c (get_doc_string, store_function_docstring):
1789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1790 (get_doc_string, Fsnarf_documentation):
1791 Use int, not EMACS_INT, where int is wide enough.
1792 (get_doc_string):
1793 Use SAFE_ALLOCA, not alloca.
1794 Check for overflow when converting EMACS_INT to off_t.
1795 * doprnt.c (doprnt):
1796 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1797 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1798 Don't assume uid_t fits into fixnum.
1799 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1800 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1801 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1802 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1803 (general_insert_function)
1804 (Finsert_char, make_buffer_string, make_buffer_string_both)
1805 (update_buffer_properties, Fbuffer_substring)
1806 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1807 (Fsubst_char_in_region, check_translation)
1808 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1809 (transpose_markers, Ftranspose_regions):
1810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1811 (clip_to_bounds): Move to lisp.h as an inline function).
1812 (Fconstrain_to_field): Don't assume integers are nonnegative.
1813 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1814 (Fsubst_char_in_region, Fsave_restriction):
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 (Femacs_pid): Don't assume pid_t fits into fixnum.
1817 (lo_time): Use int, not EMACS_INT, when int suffices.
1818 (lisp_time_argument): Check for usec out of range.
1819 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1820 (Fuser_login_name, Fuser_full_name): Signal an error
1821 if a uid argument is out of range, rather than relying on
1822 undefined behavior.
c8d5c857
PE
1823 (Fformat_time_string): Remove now-unnecessary check.
1824 lisp_time_argument checks for out-of-range usec now.
243e0530 1825 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1826 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1827 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1828 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1829 (init_cmdargs, Fdump_emacs):
1830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1831 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1832 the bottom (typically) 32 bits of the fixnum.
1833 * eval.c (specpdl_size, call_debugger):
1834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1835 (when_entered_debugger, Fbacktrace_debug):
1836 Don't assume fixnum can fit in int.
1837 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1838 the object just before a buffer; this is not portable.
1839 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1840 (grow_specpdl, unbind_to):
1841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1842 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1843 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1844 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1845 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1846 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1847 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1848 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1849 (a_write, e_write):
1850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1851 (Fcopy_file, non_regular_nbytes, read_non_regular)
1852 (Finsert_file_contents):
1853 Use int, not EMACS_INT, where int is wide enough.
1854 (READ_BUF_SIZE): Verify that it fits in int.
1855 (Finsert_file_contents): Check that counts are in proper range,
1856 rather than assuming fixnums fit into ptrdiff_t etc.
1857 Don't assume fixnums fit into int.
125b3835 1858 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1859 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1860 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1861 (string_char_to_byte, string_byte_to_char)
1862 (string_make_multibyte, string_to_multibyte)
1863 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1864 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1865 (substring_both, Fdelete, internal_equal, Ffillarray)
1866 (Fclear_string, mapcar1)
1867 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1868 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1869 (larger_vector, make_hash_table, maybe_resize_hash_table)
1870 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1871 (Fmaphash, secure_hash):
1872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1873 (concat): Check for string index and length overflow.
1874 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1875 (Frequire):
1876 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1877 (larger_vector): New API (vec, incr_min, size_max) replaces old
1878 one (vec, new_size, init). This catches size overflow.
1879 INIT was removed because it was always Qnil.
1880 All callers changed.
1881 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1882 the upper bound on a hash table index size.
1883 (make_hash_table, maybe_resize_hash_table): Use it.
1884 (secure_hash): Computer start_byte and end_byte only after
1885 they're known to be in ptrdiff_t range.
1886 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1887 (Ffont_get_glyphs, Ffont_at):
1888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1889 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1890 (Flist_fonts, Fopen_font):
1891 Don't assume fixnum can fit in int.
1892 (check_gstring): Don't assume index can fit in int.
1893 (font_match_p): Check that fixnum is a character, not a nonnegative
1894 fixnum, since the later code needs to stuff it into an int.
1895 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1896 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1897 conversion overflow issues.
1898 (Fopen_font): Check for integer out of range.
1899 (Ffont_get_glyphs): Don't assume index can fit in int.
1900 * font.h: Adjust decls to match defn changes elsewhere.
1901 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1902 integer overflow.
1903 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1904 printmax_t, where ptrdiff_t is wide enough.
1905 (Finternal_char_font):
1906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1907 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1908 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1909 (Fset_frame_position, x_set_frame_parameters)
1910 (x_set_line_spacing, x_set_border_width)
1911 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1912 Check that fixnums are in proper range for system types.
1913 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1915 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1916 Use SAFE_ALLOCA_LISP, not alloca.
1917 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1918 intptr_t is wide enough.
1919 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1920 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1921 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1922 Check for fixnum out of range.
1923 * ftfont.c (ftfont_list): Don't assume index fits in int.
1924 Check that fixnums are in proper range for system types.
1925 (ftfont_shape_by_flt):
1926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1927 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1929 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1930 Check that fixnums are in proper range for system types.
1931 * gnutls.h: Adjust decls to match defn changes elsewhere.
1932 * gtkutil.c (xg_dialog_run):
1933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1934 (update_frame_tool_bar):
1935 Check that fixnums are in proper range for system types.
1936 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1937 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1938 * indent.c (last_known_column, last_known_column_point):
1939 (current_column_bol_cache):
1940 (skip_invisible, current_column, check_display_width):
1941 (check_display_width, scan_for_column, current_column_1)
1942 (Findent_to, Fcurrent_indentation, position_indentation)
1943 (indented_beyond_p, Fmove_to_column, compute_motion):
1944 (Fcompute_motion, Fvertical_motion):
1945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1946 (last_known_column_modified): Use EMACS_INT, not int.
1947 (check_display_width):
1948 (Fcompute_motion):
1949 Check that fixnums and floats are in proper range for system types.
1950 (compute_motion): Don't assume index or fixnum fits in int.
1951 (compute_motion, Fcompute_motion):
1952 Use int, not EMACS_INT, when it is wide enough.
1953 (vmotion): Omit local var start_hpos that is always 0; that way
1954 we don't need to worry about overflow in expressions involving it.
1955 * indent.h: Adjust decls to match defn changes elsewhere.
1956 (struct position):
1957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1958 Use int, not EMACS_INT, where int is wide enough.
1959 Remove unused members ovstring_chars_done and tab_offset;
1960 all uses removed.
1961 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1962 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1963 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1964 (make_gap, copy_text, insert, insert_and_inherit)
1965 (insert_before_markers, insert_before_markers_and_inherit)
1966 (insert_1, count_combining_before, count_combining_after)
1967 (insert_1_both, insert_from_string)
1968 (insert_from_string_before_markers, insert_from_string_1)
1969 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1970 (adjust_after_replace, adjust_after_insert, replace_range)
1971 (replace_range_2, del_range, del_range_1, del_range_byte)
1972 (del_range_both, del_range_2, modify_region)
1973 (prepare_to_modify_buffer, signal_before_change)
1974 (signal_after_change, Fcombine_after_change_execute):
1975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1976 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1977 (balance_an_interval, split_interval_right, split_interval_left)
1978 (find_interval, next_interval, update_interval)
1979 (adjust_intervals_for_insertion, delete_node, delete_interval)
1980 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1981 (static_offset_intervals, offset_intervals)
1982 (merge_interval_right, merge_interval_left, make_new_interval)
1983 (graft_intervals_into_buffer, temp_set_point_both)
1984 (temp_set_point, set_point, adjust_for_invis_intang)
1985 (set_point_both, move_if_not_intangible, get_property_and_range)
1986 (get_local_map, copy_intervals, copy_intervals_to_string)
1987 (compare_string_intervals, set_intervals_multibyte_1):
1988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1989 * intervals.h: Adjust decls to match defn changes elsewhere.
1990 (struct interval):
1991 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1992 * keyboard.c (this_command_key_count, this_single_command_key_start)
1993 (before_command_key_count, before_command_echo_length, echo_now)
1994 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1995 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1996 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1997 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1999 (last_non_minibuf_size, last_point_position, echo_truncate)
2000 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2001 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2002 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2003 (stuff_buffered_input):
2004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2005 (last_auto_save, command_loop_1, read_char):
2006 Use EMACS_INT, not int, to avoid integer overflow.
2007 (record_char): Avoid overflow in total_keys computation.
2008 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2009 * keyboard.h: Adjust decls to match defn changes elsewhere.
2010 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2011 (Fkey_description, Fdescribe_vector, Flookup_key):
2012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2013 (click_position): New function, to check that positions are in range.
2014 (Fcurrent_active_maps):
2015 (describe_command):
2016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2017 (Faccessible_keymaps, Fkey_description):
2018 (preferred_sequence_p):
2019 Don't assume fixnum can fit into int.
2020 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2021 Check for integer overflow in size calculations.
2022 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2023 avoid mishandling large integers.
2024 * lisp.h: Adjust decls to match defn changes elsewhere.
2025 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2026 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2027 (struct Lisp_Marker):
2028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2029 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2030 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2031 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2032 All callers changed.
2033 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2034 Assume the arg has valid form, since it always does.
2035 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2036 unsigned integer system type.
2037 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2038 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2040 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2041 (duration_to_sec_usec): New decl.
2042 * lread.c (read_from_string_index, read_from_string_index_byte)
2043 (read_from_string_limit, readchar, unreadchar, openp)
2044 (read_internal_start, read1, oblookup):
2045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2046 (Fload, readevalloop, Feval_buffer, Feval_region):
2047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2048 (openp): Check for out-of-range argument to 'access'.
2049 (read1): Use int, not EMACS_INT, where int is wide enough.
2050 Don't assume fixnum fits into int.
6efdadfd 2051 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2052 (read_filtered_event): Use duration_to_sec_usec
2053 to do proper overflow checking on durations.
d311d28c
PE
2054 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2055 in size calculation.
2056 (Fexecute_kbd_macro):
2057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2058 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2059 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2060 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2061 (set_marker_both, set_marker_restricted_both, marker_position)
2062 (marker_byte_position, Fbuffer_has_markers_at):
2063 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2064 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2065 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2066 It now merely ensures that the menu is large enough, without
2067 necessarily growing it, as this avoids some integer overflow issues.
2068 All callers changed.
2069 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2070 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2071 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2072 Use SAFE_ALLOCA_LISP, not alloca.
2073 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2074 to EMACS_INT. Check that fixnums are in proper range for system types.
2075 * minibuf.c (minibuf_prompt_width, string_to_object)
2076 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2077 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2079 (get_minibuffer, read_minibuf_unwind):
2080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2081 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2082 this simplifies overflow checking. All callers changed.
2083 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2084 (Ftest_completion):
2085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2086 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2087 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2088 Check that fixnums are in proper range for system types.
2089 (Fx_create_frame, Fx_show_tip):
2090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2091 * nsfont.m (ns_findfonts, nsfont_list_family):
2092 Don't assume fixnum fits in long.
2093 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2095 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2096 wide enough.
17fdb222 2097 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2099 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2100 (PRINTDECLARE, PRINTPREPARE):
2101 (strout, print_string):
2102 (print, print_preprocess, print_check_string_charset_prop)
2103 (print_object):
2104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2105 (PRINTDECLARE):
2106 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2108 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2109 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2110 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2111 (print_error_message): Use SAFE_ALLOCA, not alloca.
2112 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2113 (print_depth, new_backquote_output, print_number_index):
2114 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2115 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2116 (Fset_process_window_size, Fformat_network_address)
2117 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2118 (sigchld_handler):
d311d28c 2119 Check that fixnums are in proper range for system types.
d44287d4 2120 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2121 Check for process-ids out of pid_t range rather than relying on
2122 undefined behavior.
e4d81efc 2123 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2124 (Fformat_network_address, read_process_output, send_process)
2125 (Fprocess_send_region, status_notify):
2126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2127 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2128 (wait_reading_process_output, read_process_output, exec_sentinel):
2129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2130 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2131 (Faccept_process_output): Use duration_to_sec_usec to do proper
2132 overflow checking on durations.
dde14581
PE
2133 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2134 Don't assume pid_t fits in int.
02481186
PE
2135 * process.h (struct Lisp_Process): Members tick and update_tick
2136 are now of type EMACS_INT, not int.
b62b53e8
PE
2137 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2138 configured --with-wide-int.
d311d28c
PE
2139 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2140 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2141 * search.c (looking_at_1, string_match_1):
2142 (fast_string_match, fast_c_string_match_ignore_case)
2143 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2144 (scan_newline, find_before_next_newline, search_command)
2145 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2146 (set_search_regs, wordify):
2147 (Freplace_match):
2148 (Fmatch_data):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2150 (string_match_1, search_buffer, set_search_regs):
2151 (Fmatch_data):
2152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2153 (wordify): Check for overflow in size calculation.
2154 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2155 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2156 Check that fixnums are in proper range for system types.
2157 * sound.c (struct sound_device)
2158 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2160 (Fplay_sound_internal):
2161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2162 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2163 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2164 (Fparse_partial_sexp):
2165 Don't assume fixnums can fit in int.
2166 (struct lisp_parse_state, find_start_pos, find_start_value)
2167 (find_start_value_byte, find_start_begv)
2168 (update_syntax_table, char_quoted, dec_bytepos)
2169 (find_defun_start, prev_char_comend_first, back_comment):
2170 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2171 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2173 (Finternal_describe_syntax_value): Check that match_lisp is a
2174 character, not an integer, since the code stuffs it into int.
2175 (scan_words, scan_sexps_forward):
2176 Check that fixnums are in proper range for system types.
2177 (Fforward_word):
2178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2179 (scan_sexps_forward):
2180 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2181 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2182 * syntax.h: Adjust decls to match defn changes elsewhere.
2183 (struct gl_state_s):
2184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2185 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2186 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2187 * sysdep.c (wait_for_termination_1, wait_for_termination)
2188 (interruptible_wait_for_termination, mkdir):
2189 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2190 (emacs_read, emacs_write):
2191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2192 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2193 and double all fit in int.
d311d28c
PE
2194 * term.c (set_tty_color_mode):
2195 Check that fixnums are in proper range for system types.
2196 * termhooks.h (struct input_event):
2197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2198 * textprop.c (validate_interval_range, interval_of)
2199 (Fadd_text_properties, set_text_properties_1)
2200 (Fremove_text_properties, Fremove_list_of_text_properties)
2201 (Ftext_property_any, Ftext_property_not_all)
2202 (copy_text_properties, text_property_list, extend_property_ranges)
2203 (verify_interval_modification):
2204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2205 (Fnext_single_char_property_change)
2206 (Fprevious_single_char_property_change):
2207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2208 (copy_text_properties):
2209 Check for integer overflow in index calculation.
d311d28c
PE
2210 * undo.c (last_boundary_position, record_point, record_insert)
2211 (record_delete, record_marker_adjustment, record_change)
2212 (record_property_change):
2213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2214 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2216 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2217 (Fx_hide_tip, Fx_file_dialog):
2218 * w32menu.c (set_frame_menubar):
2219 Use ptrdiff_t, not int, for consistency with rest of code.
2220 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2221 (select_window, Fdelete_other_windows_internal)
2222 (window_scroll_pixel_based, window_scroll_line_based)
2223 (Frecenter, Fset_window_configuration):
2224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2225 (Fset_window_hscroll, run_window_configuration_change_hook)
2226 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2227 (Fscroll_other_window, Frecenter):
d311d28c
PE
2228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2229 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2230 Don't assume fixnum fits in int.
2231 (Fset_window_scroll_bars):
2232 Check that fixnums are in proper range for system types.
2233 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2234 (string_pos, c_string_pos, number_of_chars, init_iterator)
2235 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2236 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2237 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2238 (face_before_or_after_it_pos, handle_invisible_prop)
2239 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2240 (display_prop_intangible_p, string_buffer_position_lim)
2241 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2242 (get_overlay_strings_1, get_overlay_strings)
2243 (iterate_out_of_display_property, forward_to_next_line_start)
2244 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2245 (get_next_display_element, set_iterator_to_next)
2246 (get_visually_first_element, compute_stop_pos_backwards)
2247 (handle_stop_backwards, next_element_from_buffer)
2248 (move_it_in_display_line_to, move_it_in_display_line)
2249 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2250 (add_to_log, message_dolog, message_log_check_duplicate)
2251 (message2, message2_nolog, message3, message3_nolog
2252 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2253 (current_message_1, truncate_echo_area, truncate_message_1)
2254 (set_message, set_message_1, store_mode_line_noprop)
2255 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2256 (text_outside_line_unchanged_p, check_point_in_composition)
2257 (reconsider_clip_changes)
2258 (redisplay_internal, set_cursor_from_row, try_scrolling)
2259 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2260 (redisplay_window, find_last_unchanged_at_beg_row)
2261 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2262 (trailing_whitespace_p, find_row_edges, display_line)
2263 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2264 (display_mode_element, store_mode_line_string)
2265 (pint2str, pint2hrstr, decode_mode_spec)
2266 (display_count_lines, display_string, draw_glyphs)
2267 (x_produce_glyphs, x_insert_glyphs)
2268 (rows_from_pos_range, mouse_face_from_buffer_pos)
2269 (fast_find_string_pos, mouse_face_from_string_pos)
2270 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2272 (safe_call, init_from_display_pos, handle_fontified_prop)
2273 (handle_single_display_spec, load_overlay_strings)
2274 (with_echo_area_buffer, setup_echo_area_for_printing)
2275 (display_echo_area, echo_area_display)
2276 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2277 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2278 (redisplay_window, dump_glyph_row, display_mode_line)
2279 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2280 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2282 (handle_single_display_spec, build_desired_tool_bar_string)
2283 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2284 (get_specified_cursor_type):
2285 Check that fixnums are in proper range for system types.
2286 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2287 (Flookup_image_map):
2288 Don't assume fixnums fit in int.
2289 (compare_overlay_entries):
2290 Avoid mishandling comparisons due to subtraction overflow.
2291 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2292 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2293 (handle_tool_bar_click):
2294 Use int, not unsigned, since we prefer signed and the signedness
2295 doesn't matter here.
2296 (get_next_display_element, next_element_from_display_vector):
2297 Use int, not EMACS_INT, when int is wide enough.
2298 (start_hourglass): Use duration_to_sec_usec to do proper
2299 overflow checking on durations.
2300 * xfaces.c (Fbitmap_spec_p):
2301 Check that fixnums are in proper range for system types.
2302 (compare_fonts_by_sort_order):
2303 Avoid mishandling comparisons due to subtraction overflow.
2304 (Fx_family_fonts, realize_basic_faces):
2305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2306 (Fx_family_fonts):
2307 Don't assume fixnum fits in int.
2308 Use SAFE_ALLOCA_LISP, not alloca.
2309 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2310 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2311 (face_at_buffer_position, face_for_overlay_string)
2312 (face_at_string_position):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2315 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2316 (Fx_show_tip):
2317 Check that fixnums are in proper range for system types.
2318 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2319 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2321 (Fx_change_window_property): Don't assume fixnums fit in int.
2322 * xfont.c (xfont_chars_supported):
2323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2324 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2325 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2326 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2327 * xml.c (parse_region):
2328 * xrdb.c (magic_file_p):
2329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2330 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2331 (x_get_local_selection, x_reply_selection_request)
2332 (x_handle_selection_request, wait_for_property_change):
2333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2334 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2335 short is wide enough.
2336 (x_send_client_event): Don't assume fixnum fits in int.
2337 * xterm.c (x_x_to_emacs_modifiers):
2338 Don't assume EMACS_INT overflows nicely into int.
2339 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2340 may come from Lisp.
2341 (handle_one_xevent): NATNUMP can eval its arg twice.
2342 (x_connection_closed):
2343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2344 * xterm.h: Adjust decls to match defn changes elsewhere.
2345 (struct scroll_bar): Use struct vectorlike_header
2346 rather than rolling our own approximation.
2347 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2348
c6574eb5
GM
23492012-05-25 Glenn Morris <rgm@gnu.org>
2350
2351 * lisp.mk (lisp): Update for more files being compiled now.
2352
e8d32c7e
SM
23532012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2354
48def666
SM
2355 * lread.c: Remove `read_pure' which makes no difference.
2356 (read_pure): Remove var.
2357 (unreadpure): Remove function.
2358 (readevalloop): Don't call read_list with -1 flag.
2359 (read1, read_vector): Don't test read_pure any more.
2360 (read_list): Simplify.
2361
e8d32c7e
SM
2362 * fileio.c, character.h: Minor style tweaks.
2363
4b2addb7
DA
23642012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2365
2366 * window.h (clip_changed): Remove useless declaration.
2367
584461b2
JB
23682012-05-22 Juanma Barranquero <lekktu@gmail.com>
2369
2370 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2371 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2372
34374650
PE
23732012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2374
2375 Remove src/m/*.
2376 This directory predates autoconf and is no longer needed nowadays.
2377 Move its few remaining bits of functionality to where they're needed.
2378 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2379 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2380 * m/template.h: Remove.
2381 * Makefile.in (M_FILE): Remove. All uses removed.
2382 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2383 * lisp.h (USE_LSB_TAG):
2384 * mem-limits.h (EXCEEDS_LISP_PTR):
2385 Use VAL_MAX, not VALBITS, in #if.
2386 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2387 (EMACS_UINT): Define unconditionally now.
2388 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2389 (BITS_PER_EMACS_INT): New constants, replacing
2390 what used to be in config.h, but not useful in #if.
2391 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2392 define them any more.
2393 (VAL_MAX): New macro.
2394 (VALMASK): Use it.
2395 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2396 BITS_PER_EMACS_INT, in #if.
2397 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2398 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2399 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2400 * s/ms-w32.h (DATA_START):
2401 Move here from removed file m/intel386.h.
2402 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2403 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2404
261cb4bb
PE
24052012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2406
2407 Assume C89 or later.
2408 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2409 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2410 (xrealloc):
2411 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2412 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2413 * textprop.c, tparam.c (NULL): Remove.
2414 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2415 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2416 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2417 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2418 * xterm.c (input_signal_count): Assume volatile works.
2419
ff23cd9f
KB
24202012-05-21 Ken Brown <kbrown@cornell.edu>
2421
2422 * xgselect.c (xg_select): Fix first argument in call to 'select'
2423 (bug#11508).
2424
1b170bc6
KB
24252012-05-20 Ken Brown <kbrown@cornell.edu>
2426
2427 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2428 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2429
b2f4d39f
KB
24302012-05-19 Ken Brown <kbrown@cornell.edu>
2431
2432 * xfns.c (x_in_use): Remove `static' qualifier.
2433 * xterm.h (x_in_use): Declare.
2434 * xgselect.c: Include xterm.h.
2435 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2436 and `display_arg' (bug#9754).
2437
003fdae2
PE
24382012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2439
9232a6d9
PE
2440 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2441
003fdae2
PE
2442 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2443 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2444
784b56e2
EZ
24452012-05-18 Eli Zaretskii <eliz@gnu.org>
2446
2447 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2448
2449 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2450 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2451
2452 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2453 reference to image_cache->refcount.
2454 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2455
a0a79cde
JL
24562012-05-17 Juri Linkov <juri@jurta.org>
2457
2458 * search.c (Fword_search_regexp, Fword_search_backward)
2459 (Fword_search_forward, Fword_search_backward_lax)
2460 (Fword_search_forward_lax): Move functions to isearch.el
2461 (bug#10145, bug#11381).
2462
b0572523
PE
24632012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2466
9660f5fc
SM
24672012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2468
2469 * lread.c (init_obarray): Declare Qt and Qnil as special.
2470
4374de83
GM
24712012-05-14 Glenn Morris <rgm@gnu.org>
2472
2473 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2474 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2475
dc44c39a
PE
24762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2477
078c97cb
PE
2478 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2479
dc44c39a
PE
2480 * unexaix.c: Port to more-recent AIX compilers.
2481 (report_error, report_error_1, make_hdr, copy_sym)
2482 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2483 Make arguments const char *, not char *, to avoid violations of C
2484 standard and to fix some AIX warnings reported by Gilles Pion.
2485
e18afed7 24862012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2487
2488 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2489 already have overlays loaded.
2490 (handle_single_display_spec): Before returning without displaying
2491 fringe bitmap, synchronize the bidi iterator with the main display
2492 iterator, by calling iterate_out_of_display_property.
2493 (iterate_out_of_display_property): Detect buffer iteration by
2494 testing that it->string is a Lisp string.
2495 (get_next_display_element): When the current object is exhausted,
2496 and there's something on it->stack, call set_iterator_to_next to
2497 proceed with what's on the stack, instead of returning zero.
2498 (set_iterator_to_next): If called at the end of a Lisp string,
2499 proceed to consider_string_end without incrementing string
2500 position. Don't increment display vector index past the end of
2501 the display vector. (Bug#11417)
c8fb9dc6
EZ
2502 (pos_visible_p): Don't report a position visible when move_it_to
2503 stopped at the last line of window, which happens to be scanned
2504 backwards by the bidi iteration. (Bug#11464)
ac268e67 2505
e18afed7 25062012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2507
2508 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2509 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2510 are on a TTY, and thus unable to display on the fringes.
2511 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2512 so we need to signal to the caller that this is a "replacing"
2513 display spec. This fixes display when the spec is invalid or we
2514 are on a TTY.
2515
e18afed7 25162012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2517
2518 * unexaix.c (make_hdr): Fix typo in prototype.
2519 This bug broke the build on AIX. Problem reported by Gilles Pion.
2520
9d0a235a
MA
25212012-05-14 Michael Albinus <michael.albinus@gmx.de>
2522
2523 * keyboard.c (kbd_buffer_get_event): Read special events also in
2524 batch mode. (Bug#11415)
2525
9e6b06ed
GM
25262012-05-12 Glenn Morris <rgm@gnu.org>
2527
2528 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2529
c1a1d7a3
EZ
25302012-05-12 Eli Zaretskii <eliz@gnu.org>
2531
2532 * lisp.mk (lisp): Add newcomment.elc.
2533
3fe7cdc8
GM
25342012-05-12 Glenn Morris <rgm@gnu.org>
2535
2536 * Makefile.in (MKDIR_P): New, set by configure.
2537 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2538
53f7d2c0
PE
25392012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2540
2541 Remove unused function hourglass_started.
2542 * dispextern.h (hourglass_started):
2543 * w32fns.c (hourglass_started):
2544 * xdisp.c (hourglass_started): Remove.
2545
75aafb17
JB
25462012-05-10 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2549 Update dependencies.
2550
12959e8e
PE
25512012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2552
97107e2e
PE
2553 * xgselect.c (xg_select): Put maxfds+1 into a var.
2554 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2555
12959e8e
PE
2556 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2557
836d29b3
DA
25582012-05-10 Dave Abrahams <dave@boostpro.com>
2559
2560 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2561 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2562
5cb67954
MA
25632012-05-09 Michael Albinus <michael.albinus@gmx.de>
2564
2565 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2566 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2567 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2568 Initialize xd_registered_buses.
2569
3478ec45
PE
25702012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2571
b263a6b0
PE
2572 Untag more efficiently if USE_LSB_TAG.
2573 This is based on a proposal by YAMAMOTO Mitsuharu in
2574 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2575 For an admittedly artificial (nth 8000 longlist) benchmark on
2576 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2577 Emacs's overall text size by 1%.
2578 * lisp.h (XUNTAG): New macro.
2579 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2580 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2581 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2582 * eval.c (Fautoload):
2583 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2584 * frame.h (XFRAME): Use XUNTAG.
2585
3478ec45
PE
2586 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2587 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2588 Remove unportable assumptions about print widths of types like
2589 dbus_uint32_t.
2590 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2591 intptr_t when converting between pointer and integer, to avoid GCC
2592 warnings about wrong width.
2593
666b903b 25942012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2595
2596 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2597 stack for each reader_thread, instead of defaulting to 8MB
2598 determined by the linker. This avoids failures in creating
2599 subprocesses on Windows 7, see the discussion in this thread:
2600 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2601
b120cc17
JC
26022012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2603
2604 Fix up display of the *Minibuf-0* buffer in the mini window.
2605 * keyboard.c (read_char): Don't clear the echo area if there's no
2606 message to clear.
2607 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2608 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2609
9a4b36f8
MA
26102012-05-07 Michael Albinus <michael.albinus@gmx.de>
2611
2612 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2613 batch mode.
2614
e5f9458f
CY
26152012-05-06 Chong Yidong <cyd@gnu.org>
2616
2617 * lisp.mk (lisp): Update.
2618
eceeb5fc 26192012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2620
2621 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2622
71873e2b
SM
26232012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2624
2625 * data.c (PUT_ERROR): New macro.
2626 (syms_of_data): Use it. Add new error type `user-error'.
2627 * undo.c (user_error): New function.
2628 (Fprimitive_undo): Use it.
2629 * print.c (print_error_message): Adjust print style for `user-error'.
2630 * keyboard.c (user_error): New function.
2631 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2632
ab0fa4e4
PE
26332012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2634
2635 Do not limit current-time-string to years 1000..9999.
2636 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2637 (Fcurrent_time_string): Support any year that is supported by the
2638 underlying localtime representation. Don't use asctime, as it
2639 has undefined behavior for years outside the range -999..9999.
2640
7ed806a7
PE
26412012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Fix race conditions involving setenv, gmtime, localtime, asctime.
2644 Without this fix, interrupts could mess up code that uses these
2645 nonreentrant functions, since setting TZ invalidates existing
2646 tm_zone or tzname values, and since most of these functions return
2647 pointers to static storage.
2648 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2649 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2650 Grow the critical sections to include not just invoking
2651 localtime/gmtime, but also accessing these functions' results
2652 including their tm_zone values if any, and any related TZ setting.
2653 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2654 so that the struct tm is saved in the critical section.
2655 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2656 motivated by the fact that memory allocation needs to be outside
2657 the critical section.
2658
0c16dfed
DA
26592012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2660
2661 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2662 with RESET_INTERVAL.
2663
2664 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2665 Remove duplicated buffer name initialization.
2666
3f83ace8
JM
26672012-05-02 Jim Meyering <jim@meyering.net>
2668
2669 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2670
c7b8541e
JM
2671 * xfns.c (x_window): Use xstrdup (Bug#11375).
2672
90207a15 26732012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2674
2675 * xdisp.c (pos_visible_p): If already at a newline from the
2676 display string before the 'while' loop, don't walk back the glyphs
2677 from it3.glyph_row. Solves assertion violation when the display
2678 string begins with a newline (egg.el). (Bug#11367)
2679
b593d6a9
AH
26802012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2681
2682 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2683 Move to simple.el.
2684
4737362e
GM
26852012-05-01 Glenn Morris <rgm@gnu.org>
2686
99cf43f9
GM
2687 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2688 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2689 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2690 All were removed before 23.1.
2691
9311dcff
GM
2692 * dispnew.c: Remove HAVE_LIBNCURSES test;
2693 it is always true on relevant platforms.
2694
4d5c6349
GM
2695 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2696 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2697
4737362e
GM
2698 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2699
74dd3a6b
AS
27002012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2701
2702 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2703 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2704 Remove.
2705
13c379ee
PE
27062012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2707
2708 Do not avoid creating empty evaporating overlays (Bug#9642).
2709 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2710 That is, do not delete an evaporating overlay if it becomes
2711 empty after its bounds are adjusted to fit within its buffer.
2712 This fix caused other problems, and I'm reverting it until we get
2713 to the bottom of them.
2714
a8e7d6d7 27152012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2716
2717 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2718
a8e7d6d7 27192012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2720
2721 * xdisp.c (pos_visible_p): If the window start position is beyond
2722 ZV, start the display from buffer beginning. Prevents assertion
2723 violation in init_iterator when the minibuffer window is scrolled
2724 via the scroll bar.
2725
2726 * window.c (window_scroll_pixel_based): Likewise.
2727
a8e7d6d7 27282012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2729
2730 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2731
a8e7d6d7 27322012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2733
2734 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2735 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2736
a8e7d6d7 27372012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2738
b593d6a9
AH
2739 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2740 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2741
1c6900d9
EZ
27422012-04-26 Eli Zaretskii <eliz@gnu.org>
2743
4c3fa1d9
EZ
2744 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2745 display element, check also the underlying string or buffer
2746 character. (Bug#11341)
2747
1c6900d9
EZ
2748 * w32menu.c: Include w32heap.h.
2749 (add_menu_item): If the call to AppendMenuW (via
2750 unicode_append_menu) fails, disable Unicode menus only if we are
2751 running on Windows 9X/Me.
2752
42bf8205
AS
27532012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2754
2755 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2756 (xgetint): Add missing shift for LSB tags.
2757
b1bac16e
MR
27582012-04-24 Martin Rudalics <rudalics@gmx.at>
2759
2760 * keyboard.c (read_char): Don't wipe echo area for select window
2761 events: These might get delayed via `mouse-autoselect-window'
2762 (Bug#11304).
2763
d69621cc
JB
27642012-04-24 Juanma Barranquero <lekktu@gmail.com>
2765
2766 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2767 manipulation of :loaded-from data.
2768
02fd101b
JB
27692012-04-23 Juanma Barranquero <lekktu@gmail.com>
2770
2771 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2772 now a cons (bug#11311).
2773
888bec30
PE
27742012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2775
89a438bd
PE
2776 Do not create empty overlays with the evaporate property (Bug#9642).
2777 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2778 if it becomes empty after its bounds are adjusted to fit within
2779 its buffer. Without this fix, in a nonempty buffer (let ((o
2780 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2781 yields an empty overlay that has the evaporate property, which is
2782 not supposed to happen.
2783
1068fe4d
PE
2784 Fix minor GTK3 problems found by static checking.
2785 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2786 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2787 (struct _EmacsFixedClass, emacs_fixed_get_type):
2788 Move decls here from emacsgtkfixed.h, since they needn't be public.
2789 (emacs_fixed_get_type): Now static.
2790 (emacs_fixed_class_init): Omit unused local.
2791 (emacs_fixed_child_type): Remove; unused.
2792 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2793 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2794 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2795 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2796 (EMACS_FIXED_GET_CLASS): Remove; unused.
2797 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2798
888bec30
PE
2799 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2800 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2801
de85e130
PE
28022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2803
d0baac98 2804 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2805 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2806 (__malloc_size_t, __malloc_ptrdiff_t):
2807 Remove. All uses removed, replaced by the definiens if needed,
2808 since we can assume C89 or better now.
2809 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2810 (protect_malloc_state, align, get_contiguous_space)
2811 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2812 (malloc_atfork_handler_child, malloc_enable_thread)
2813 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2814 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2815 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2816 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2817 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2818 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2819 Define using prototypes, not old style.
2820 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2821 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2822 (align): Don't assume that signed integer overflow wraps around.
2823 Omit unused local var.
2824 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2825 (_free_internal_nolock, memalign, mallochook, reallochook):
2826 Omit no-longer-needed casts.
2827 (valloc): Use getpagesize, not __getpagesize.
2828 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2829 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2830
de85e130
PE
2831 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2832
dcbf5805
MA
28332012-04-22 Michael Albinus <michael.albinus@gmx.de>
2834
2835 Move functions from C to Lisp. Make non-blocking method calls
2836 the default. Implement further D-Bus standard interfaces.
2837
2838 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2839 (QCdbus_request_name_allow_replacement)
2840 (QCdbus_request_name_replace_existing)
2841 (QCdbus_request_name_do_not_queue)
2842 (QCdbus_request_name_reply_primary_owner)
2843 (QCdbus_request_name_reply_in_queue)
2844 (QCdbus_request_name_reply_exists)
2845 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2846 (QCdbus_registered_serial, QCdbus_registered_method)
2847 (QCdbus_registered_signal): New Lisp objects.
2848 (XD_DEBUG_MESSAGE): Use sizeof.
2849 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2850 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2851 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2852 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2853 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2854 (xd_signature, xd_append_arg): Allow float for integer types.
2855 (xd_get_connection_references): New function.
b593d6a9
AH
2856 (xd_get_connection_address): Rename from xd_initialize.
2857 Return cached address.
dcbf5805
MA
2858 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2859 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2860 level.
2861 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2862 Return number of refcounts.
dcbf5805
MA
2863 (Fdbus_get_unique_name): Make stronger parameter check.
2864 (Fdbus_message_internal): New defun.
2865 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2866 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2867 (Fdbus_send_signal, Fdbus_register_service)
2868 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2869 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2870 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2871 (Vdbus_compiled_version, Vdbus_runtime_version)
2872 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2873 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2874 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2875 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2876 Adapt docstring.
dcbf5805 2877
52828e02
PE
28782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2879
da05bc4c
PE
2880 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2881 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2882 Do not assume ptrdiff_t is the same width as 'int'.
2883
52828e02
PE
2884 * alloc.c: Handle unusual debugging option combinations.
2885 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2886 since the two debugging options are incompatible.
2887 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2888 is defined.
2889 (mem_init, mem_insert, mem_insert_fixup):
2890 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2891 (NEED_MEM_INSERT): Remove; no longer needed.
2892
f01769f9
LL
28932012-04-22 Leo Liu <sdl.web@gmail.com>
2894
2895 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2896
5790543d
PE
28972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2898
2899 * sysdep.c [__FreeBSD__]: Minor cleanups.
2900 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2901 Use Emacs indenting style more consistently. Avoid some casts.
2902 Use 'double' consistently rather than mixing 'float' and 'double'.
2903
b91b7e4d
EW
29042012-04-21 Eduard Wiebe <usenet@pusto.de>
2905
b593d6a9
AH
2906 * sysdep.c (list_system_processes, system_process_attributes):
2907 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2908
6114eb15
AS
29092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2910
2911 * lisp.mk (lisp): Update.
2912
2f38dff7
PE
29132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2916 It is never used otherwise.
2917
4ae29f89
SM
29182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2919
2920 * print.c (print_preprocess): Only check print_depth if print-circle
2921 is nil.
2922 (print_object): Check for cycles even when print-circle is nil and
2923 print-gensym is t, but only check print_depth if print-circle is nil.
2924
f30d612a
CY
29252012-04-20 Chong Yidong <cyd@gnu.org>
2926
2927 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2928 set the status to "failed" and ensure that sentinel is run.
2929
c07a4c0b 29302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2931
2932 * process.c (Fset_process_inherit_coding_system_flag)
2933 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2934 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2935
c07a4c0b 29362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2937
2938 * xdisp.c (string_buffer_position_lim): Limit starting position to
2939 BEGV.
2940 (set_cursor_from_row): If called for a mode-line or header-line
2941 row, return zero immediately.
2942 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2943 farther than the first row after the header line, if any.
2944 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2945 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2946
c07a4c0b 29472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2948
4ae29f89
SM
2949 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2950 (bug#11238).
ad3a2b41 2951
c07a4c0b 29522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 29532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2954
2955 configure: new option --enable-gcc-warnings (Bug#11207)
2956 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2957 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2958 (ALL_CFLAGS): Use new macros rather than old.
2959 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2960 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2961 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2962 -Wunused-result, -Wunused-variable. This should go away once
2963 the Emacs and Gnulib regex code is merged.
2964 (xmalloc, xrealloc): Now static.
2965
aba027e8
PE
29662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 * dired.c (Fsystem_groups): Remove unused local.
2969
e5a36063
GM
29702012-04-17 Glenn Morris <rgm@gnu.org>
2971
2972 * dired.c (Fsystem_users): Doc fix.
2973
316411f0
DA
29742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2975
2976 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2977 (syms_of_dired): Add them.
2978
9426aba4
PE
29792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2980
b62a57be
PE
2981 Fix minor alloc.c problems found by static checking.
2982 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2983 New extern decls, to avoid calling undeclared functions.
2984 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2985 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2986 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2987 (NEED_MEM_INSERT): New macro.
2988 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2989 Remove one incorrect comment and fix another.
b62a57be 2990
3539f31f
PE
2991 Fix minor ralloc.c problems found by static checking.
2992 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2993 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2994 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2995 (r_alloc_sbrk): Now static.
2996
a041960a
PE
2997 Improve ralloc.c interface checking.
2998 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2999 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3000 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3001 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3002 [REL_ALLOC]: ... to here, to check interface.
3003 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3004 Remove decls. This fixes an "It stinks!".
3005
9426aba4
PE
3006 * alloc.c (which_symbols): Fix alignment issue / type clash.
3007
d55c12ed
AS
30082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3009
3010 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3011 (struct Lisp_Misc_Any): Likewise.
3012 (struct Lisp_Free): Likewise.
3013 * alloc.c (union aligned_Lisp_Symbol): Define.
3014 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3015 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3016 (union aligned_Lisp_Misc): Define.
3017 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3018 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3019 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3020
b948ce8b
PE
30212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3024 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3025 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3026 * s/netbsd.h, s/sol2-6.h:
3027 Remove definition of GC_MARK_STACK, since the default now works.
3028 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3029 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3030 no longer the default.
3031 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3032
35dc09a1 30332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3034
35dc09a1
GM
3035 * lread.c (lisp_file_lexically_bound_p):
3036 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3037
35dc09a1
GM
30382012-04-14 Eli Zaretskii <eliz@gnu.org>
3039
3040 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3041 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3042
30432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3044
3045 * nsterm.m (constrainFrameRect): Always constrain when there is only
3046 one screen (Bug#10962).
3047
bcd86815
KB
30482012-04-13 Ken Brown <kbrown@cornell.edu>
3049
3050 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3051
c25df26e
RT
30522012-04-13 Reuben Thomas <rrt@sc3d.org>
3053
3054 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3055
0fc59f1e
DC
30562012-04-11 Daniel Colascione <dancol@dancol.org>
3057
3058 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3059 against is gone. It's better to use vfork now so that when Cygwin
3060 gains a new, working vfork, we use it automatically (bug#10398).
3061
de8c03dc
SM
30622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3063
3064 * window.c (save_window_save): Obey window-point-insertion-type.
3065
2f097256
GM
30662012-04-11 Glenn Morris <rgm@gnu.org>
3067
3068 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3069
453b951e
SM
30702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3071
3072 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3073
75f1671a 30742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3075
3076 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3077 (force_quit_count): New var.
3078 (handle_interrupt): Use it.
3079
2a8ce227
JB
30802012-04-10 Juanma Barranquero <lekktu@gmail.com>
3081
3082 * w32.c (w32_delayed_load): Record the full path of the library
3083 being loaded (bug#10424).
3084
935396c0
GM
30852012-04-09 Glenn Morris <rgm@gnu.org>
3086
05920a43
GM
3087 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3088 not just in the obarray, before snarfing them. (Bug#11036)
3089
935396c0
GM
3090 * Makefile.in ($(leimdir)/leim-list.el):
3091 Pass EMACS rather than BUILT_EMACS.
3092
a18ecafa
TZ
30932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3094
3095 * process.c (make_process):
3096 * process.h: Add integer `gnutls_handshakes_tried' member to
3097 process struct.
3098
6bbef4e5
JC
3099 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3100 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3101
3102 * gnutls.c (gnutls_log_function2i): Convenience log function.
3103 (emacs_gnutls_read): Use new log functions,
3104 `gnutls_handshakes_tried' process member, and
3105 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3106 attempts per process (connection).
3107
b4d3bc10
CY
31082012-04-09 Chong Yidong <cyd@gnu.org>
3109
3110 * eval.c (Fuser_variable_p, user_variable_p_eh)
3111 (lisp_indirect_variable): Functions deleted.
3112 (Fdefvar): Caller changed.
3113
3114 * callint.c (Finteractive, Fcall_interactively):
3115 * minibuf.c (Fread_variable): Callers changed.
3116
70f4d973
EZ
31172012-04-09 Eli Zaretskii <eliz@gnu.org>
3118
3119 * xdisp.c (set_cursor_from_row): If the display string appears in
3120 the buffer at position that is closer to point than the position
3121 after the display string, display the cursor on the first glyph of
3122 the display string. Fixes cursor display when a 'display' text
3123 property immediately follows invisible text. (Bug#11094)
3124
cb3c2e3e
PE
31252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 composite.c: use 'double' consistently
3128 * composite.c (get_composition_id): Use 'double' consistently
3129 instead of converting 'float' to 'double' and vice versa; this is
3130 easier to understand and avoids a GCC warning.
3131
fd06db5d
GM
31322012-04-09 Glenn Morris <rgm@gnu.org>
3133
50fe702a
GM
3134 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3135 preparation for dumping it with emacs. (Bug#4789)
3136 (leimdir): New variable.
3137 ($(leimdir)/leim-list.el): New rule.
3138 (emacs$(EXEEXT)): Depend on leim-list.el.
3139
fd06db5d
GM
3140 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3141 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3142 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3143
55c131ee
AS
31442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3145
3146 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3147 proper alignment.
3148
9209588f
JB
31492012-04-07 Juanma Barranquero <lekktu@gmail.com>
3150
3151 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3152 Remove unused local variable.
3153
e3fb2efb
PE
31542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3157 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3158 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3159 objects, as mark_maybe_pointer will catch them otherwise.
3160 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3161 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3162
b5385551
PE
31632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 Fix typo that broke non-Windows builds.
3166 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3167
9078ead6
EZ
31682012-04-07 Eli Zaretskii <eliz@gnu.org>
3169
3170 Support building on MS-Windows with libxml2.
3171
3172 * makefile.w32-in (OBJ2): Add xml.$(O).
3173 (GLOBAL_SOURCES): Add xml.c.
3174 ($(BLD)/xml.$(O)): New dependency list.
3175
3176 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3177 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3178 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3179 [!WINDOWSNT]: New macros.
3180 (init_libxml2_functions, libxml2_loaded_p): New functions.
3181 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3182 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3183 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3184 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3185 linked in).
6bbef4e5
JC
3186 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3187 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3188 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3189
3190 * emacs.c: Don't include libxml/parser.h.
3191 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3192 xmlCleanupParser directly.
3193
3194 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3195
3811fdf3
EZ
31962012-04-07 Eli Zaretskii <eliz@gnu.org>
3197
3198 * indent.c (Fvertical_motion): If there is a display string at
3199 point, use it.vpos to compute how many lines to backtrack after
3200 move_it_to point. (Bug#11133)
3201
2f8e16b2
EZ
32022012-04-06 Eli Zaretskii <eliz@gnu.org>
3203
3204 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3205 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3206 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3207 macros related to unification of CJK characters. For the details,
3208 see the discussion following the message here:
3209 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3210
3d439cd1
CY
32112012-04-04 Chong Yidong <cyd@gnu.org>
3212
3213 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3214
8bc53d00
EZ
32152012-04-01 Eli Zaretskii <eliz@gnu.org>
3216
3217 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3218 instead of alloca. (Bug#11138)
3219
3b0512a3
AS
32202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3221
3222 * w32menu.c (is_simple_dialog): Properly check lisp types.
3223 (Bug#11141)
3224
8427ddd2
EZ
32252012-03-31 Eli Zaretskii <eliz@gnu.org>
3226
979022ef
EZ
3227 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3228 position we get to after a call to move_it_to fails the
3229 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3230 only if we wind up in a string from display property. (Bug#11063)
3231
a6b1c7cc
EZ
3232 * window.c (Fdelete_other_windows_internal): Invalidate the row
3233 and column information about mouse highlight, so that redisplay
3234 restores it after reallocating the glyph matrices. (Bug#7464)
3235
8427ddd2
EZ
3236 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3237 string comes from a `display' text property, use the buffer
3238 position of that property as if we actually saw that position in
3239 the row's glyphs.
697ba24b
EZ
3240 (move_it_by_lines): Remove the assertion that
3241 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3242 violated when there's a before-string at the beginning of a line.
3243 (Bug#11063)
8427ddd2 3244
65a0a738
EZ
32452012-03-30 Eli Zaretskii <eliz@gnu.org>
3246
3247 * xdisp.c (append_space_for_newline): If the default face was
3248 remapped, use the remapped face for the appended newline.
3249 (extend_face_to_end_of_line): Use the remapped default face for
3250 extending the face to the end of the line.
3251 (display_line): Call extend_face_to_end_of_line when the default
3252 face was remapped. (Bug#11068)
3253
581355cc
EZ
32542012-03-29 Eli Zaretskii <eliz@gnu.org>
3255
3256 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3257
e8fc049f
SM
32582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3259
3260 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3261
4fb9a543
GM
32622012-03-27 Glenn Morris <rgm@gnu.org>
3263
3264 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3265 Doc fixes.
3266
679910f1
KH
32672012-03-26 Kenichi Handa <handa@m17n.org>
3268
3269 * dispextern.h (struct glyph): Fix previous change. Change the
3270 bit length of glyphless.ch to 25 (Bug#11082).
3271
90d49b7f
CY
32722012-03-26 Chong Yidong <cyd@gnu.org>
3273
3274 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3275 (command_loop_1): Use it; inhibit selection update for
3276 handle-select-window too (Bug#8996).
3277
f514f6f0
FP
32782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3279
e8fc049f 3280 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3281
bf43fa51
KH
32822012-03-25 Kenichi Handa <handa@m17n.org>
3283
3284 * dispextern.h (struct glyph): Change the bit length of
3285 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3286
8a0c01dd
EZ
32872012-03-24 Eli Zaretskii <eliz@gnu.org>
3288
3289 * s/ms-w32.h (tzname): Include time.h before redirecting to
3290 _tzname. Fixes the MSVC build. (Bug#9960)
3291
7d1c3a76
AS
32922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3293
8ed79523
AS
3294 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3295 characters.
3296
7d1c3a76
AS
3297 * xterm.c (XTread_socket): Only modify handling_signal if
3298 !SYNC_INPUT. (Bug#11080)
3299
e99a9b8b
EZ
33002012-03-23 Eli Zaretskii <eliz@gnu.org>
3301
3302 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3303 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3304 when fetching a multibyte character consumes more bytes than
3305 CHAR_BYTES returns, due to unification of CJK characters in
3306 string_char. (Bug#11073)
3307
5063c0e1
TN
33082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3309
3310 * process.c (wait_reading_process_output): Handle pty disconnect
3311 by refraining from sending oneself a SIGCHLD (bug#10933).
3312
9f851fbd
CY
33132012-03-22 Chong Yidong <cyd@gnu.org>
3314
3315 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3316
5063c0e1 3317 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3318 Mark string as coming from a prefix property.
3319 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3320 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3321
fb5b8aca
CY
33222012-03-21 Chong Yidong <cyd@gnu.org>
3323
3324 * xfaces.c (Vface_remapping_alist): Doc fix.
3325
62356a1b
EZ
33262012-03-20 Eli Zaretskii <eliz@gnu.org>
3327
3328 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3329 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3330 Doc fixes.
62356a1b 3331
025de85b
CY
33322012-03-20 Chong Yidong <cyd@gnu.org>
3333
3334 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3335 to reflect default non-nil value of redisplay-dont-pause.
3336
4827f94e
KH
33372012-03-19 Kenichi Handa <handa@m17n.org>
3338
3339 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3340 it fit in a valid range (Bug#11003).
3341
e50a24a2
EZ
33422012-03-18 Eli Zaretskii <eliz@gnu.org>
3343
3344 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3345 that is not from display property, accept the row as a "cursor
3346 row" if one of the string's character has a non-nil `cursor'
3347 property. Fixes cursor positioning when there are newlines in
3348 overlay strings, e.g. in icomplete.el. (Bug#11035)
3349
9af5ed87
PE
33502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3351
3352 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3353
d1f55f16
CY
33542012-03-12 Chong Yidong <cyd@gnu.org>
3355
3356 * eval.c (inhibit_lisp_code): Rename from
3357 inhibit_window_configuration_change_hook; move from window.c.
3358
3359 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3360 * window.c (run_window_configuration_change_hook)
3361 (syms_of_window): Callers changed.
3362
66c5eebd
CY
33632012-03-11 Chong Yidong <cyd@gnu.org>
3364
413df973
CY
3365 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3366
66c5eebd
CY
3367 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3368
1de11f56
CY
33692012-03-10 Chong Yidong <cyd@gnu.org>
3370
3371 * frame.c (other_visible_frames): Don't assume the selected frame
3372 is visible (Bug#10955).
3373
cae07000
SM
33742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3375
3376 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3377
89c94350
JD
33782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3379
3380 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3381 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3382 zero (Bug#10954).
3383
999dd333
GM
33842012-03-03 Glenn Morris <rgm@gnu.org>
3385
01a6dcc8 3386 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3387
de0100f2
EZ
33882012-03-02 Eli Zaretskii <eliz@gnu.org>
3389
3390 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3391 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3392 (redisplay_window, next_element_from_string): Fix typos in
3393 comments.
3e441275
EZ
3394 (redisplay_window): Pass to move_it_vertically the margin in
3395 pixels, not in screen lines.
de0100f2 3396
96a72ee9
GM
33972012-03-02 Glenn Morris <rgm@gnu.org>
3398
3399 * buffer.c (buffer-list-update-hook): Doc fix.
3400
312508d7
EZ
34012012-02-29 Eli Zaretskii <eliz@gnu.org>
3402
3403 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3404 push_it before setting up the iterator for the first overlay
3405 string, even if we have an empty string loaded.
3406 (next_overlay_string): If there's an empty string on the iterator
3407 stack, pop the stack. (Bug#10903)
3408
27f3c637
PE
34092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3410
3411 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3412 Suggested by Stefan Monnier in
3413 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3414 * alloc.c (widen_to_Lisp_Object): New static function.
3415 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3416 and widening them to Lisp_Objects. This would work even if
3417 USE_LSB_TAG is defined and wide integers are used, which might
3418 happen in a future version of Emacs.
3419
3c9dfce6
CY
34202012-02-25 Chong Yidong <cyd@gnu.org>
3421
fa74b241
CY
3422 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3423 Doc fix.
3424
3c9dfce6
CY
3425 * xselect.c (Fx_selection_exists_p): Doc fix.
3426 (x_clipboard_manager_save_all): Print an informative message
3427 before saving to clipboard manager.
3428
9486df08
CY
34292012-02-24 Chong Yidong <cyd@gnu.org>
3430
3431 * keyboard.c (process_special_events): Handle all X selection
3432 requests in kbd_buffer, not just the next one (Bug#8869).
3433
f01d3321
CY
34342012-02-23 Chong Yidong <cyd@gnu.org>
3435
3436 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3437 call when setting menu-bar-lines and tool-bar-lines parameters.
3438 (unwind_create_frame_1): New helper function.
3439
3440 * window.c (inhibit_window_configuration_change_hook): New var.
3441 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3442 (syms_of_window): Initialize it.
f01d3321 3443
86b847b6
CY
34442012-02-22 Chong Yidong <cyd@gnu.org>
3445
3446 * xterm.c (x_draw_image_relief): Add missing type check for
3447 Vtool_bar_button_margin (Bug#10743).
3448
a59225b1
CY
34492012-02-21 Chong Yidong <cyd@gnu.org>
3450
3451 * fileio.c (Vfile_name_handler_alist): Doc fix.
3452
3453 * buffer.c (Fget_file_buffer): Protect against invalid file
3454 handler return value.
3455
310f5bd4
PE
34562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3457
cb3a28cc
PE
3458 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3459 when computing $valmask.
3460
310f5bd4
PE
3461 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3462 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3463 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3464 It's useless in that case, and it can cause problems on hosts
3465 that allocate halves of EMACS_INT values separately.
3466 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3467 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3468 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3469 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3470 it avoids undefined behavior on hosts where shifting right by more
3471 than the word width has undefined behavior.
3472
2375c96a
CY
34732012-02-19 Chong Yidong <cyd@gnu.org>
3474
3475 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3476 (Funhandled_file_name_directory, Ffile_name_as_directory)
3477 (Fdirectory_file_name, Fexpand_file_name)
3478 (Fsubstitute_in_file_name): Protect against invalid file handler
3479 return values (Bug#10845).
3480
3eb49e71
EZ
34812012-02-18 Eli Zaretskii <eliz@gnu.org>
3482
3483 * .gdbinit (pitx): Fix incorrect references to fields of the
3484 iterator stack.
3485
7b926f3f
CY
34862012-02-17 Chong Yidong <cyd@gnu.org>
3487
3488 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3489
11273115
PE
34902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3493 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3494
c3a70e2b
CY
34952012-02-15 Chong Yidong <cyd@gnu.org>
3496
3497 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3498 marked as special. Also, starting docstrings with * is obsolete.
3499
0ca43699
AS
35002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3501
3502 * gnutls.c (emacs_gnutls_write): Fix last change.
3503
2e8f3c56
LI
35042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3505
3506 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3507 send_process.
3508
af70074f
SM
35092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3510
3511 * keymap.c (Fsingle_key_description): Handle char ranges.
3512
95986d52
CY
35132012-02-12 Chong Yidong <cyd@gnu.org>
3514
afd83bd1
CY
3515 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3516 as that creates a dangerous corner case.
3517
95986d52
CY
3518 * window.c (Fdelete_window_internal): Invalidate the mouse
3519 highlight (Bug#9904).
3520
bd7da63e
GM
35212012-02-12 Glenn Morris <rgm@gnu.org>
3522
3523 * xselect.c (Fx_own_selection_internal)
3524 (Fx_get_selection_internal, Fx_disown_selection_internal)
3525 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3526 * nsselect.m (Fx_own_selection_internal)
3527 (Fx_disown_selection_internal, Fx_selection_exists_p)
3528 (Fx_selection_owner_p, Fx_get_selection_internal):
3529 Sync docs and argument specs with the xselect.c versions.
3530
77abcbc2
LI
35312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3532
3533 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3534
90b671e2
EZ
35352012-02-11 Eli Zaretskii <eliz@gnu.org>
3536
1c0ca0b7
EZ
3537 * w32select.c (Fx_selection_exists_p): Sync doc string and
3538 argument list with xselect.c. (Bug#10783)
3539
3540 * w16select.c (Fx_selection_exists_p): Sync doc string and
3541 argument list with xselect.c. (Bug#10783)
90b671e2 3542
49241268
GM
35432012-02-10 Glenn Morris <rgm@gnu.org>
3544
3545 * fns.c (Fsecure_hash): Doc fix.
3546
f998bbe7 35472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3548
3549 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3550
0992bd9c
CY
35512012-02-07 Chong Yidong <cyd@gnu.org>
3552
3553 * buffer.c (Fbuffer_local_variables)
3554 (buffer_lisp_local_variables): Handle unbound vars correctly;
3555 don't let Qunbound leak into Lisp.
3556
af008560
GM
35572012-02-07 Glenn Morris <rgm@gnu.org>
3558
dd605cc4
GM
3559 * image.c (Fimagemagick_types): Doc fix.
3560
af008560
GM
3561 * image.c (imagemagick-render-type): Change it from a lisp object
3562 to an integer. Move the doc here from the lisp manual.
3563 Treat all values not equal to 0 the same.
3564
1449fa1d
CY
35652012-02-06 Chong Yidong <cyd@gnu.org>
3566
3567 * doc.c (store_function_docstring): Avoid applying docstring of
3568 alias to base function (Bug#2603).
3569
3723ec07
AS
35702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3571
3572 * .gdbinit (pp1, pv1): Remove redundant defines.
3573 (pr): Use pp.
3574
79c1cc1e
CY
35752012-02-04 Chong Yidong <cyd@gnu.org>
3576
3577 * nsterm.m: Declare a global (Bug#10694).
3578
d7f29f8e
EZ
35792012-02-04 Eli Zaretskii <eliz@gnu.org>
3580
cae07000
SM
3581 * w32.c (get_emacs_configuration_options):
3582 Include --enable-checking, if specified, in the return value.
d7f29f8e 3583
3b95a6f9
MR
35842012-02-04 Martin Rudalics <rudalics@gmx.at>
3585
3586 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3587 after rounding frame sizes. (Bug#9723)
3588
d6fa96a6
EZ
35892012-02-04 Eli Zaretskii <eliz@gnu.org>
3590
3591 * keyboard.c (adjust_point_for_property): Don't position point
3592 before BEGV. (Bug#10696)
3593
df0b2940
PE
35942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3595
3596 Handle overflow when computing char display width (Bug#9496).
3597 * character.c (char_width): Return EMACS_INT, not int.
3598 (char_width, c_string_width): Check for overflow when
3599 computing the width; this is possible now that individual
3600 characters can have unbounded width. Problem introduced
3601 by merge from Emacs 23 on 2012-01-19.
3602
6bee44d6
MA
36032012-02-02 Michael Albinus <michael.albinus@gmx.de>
3604
3605 * dbusbind.c (Fdbus_register_method): Mention the return value
3606 :ignore in the docstring.
3607
44f92739
GM
36082012-02-02 Glenn Morris <rgm@gnu.org>
3609
1b9f60cc
GM
3610 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3611
44f92739
GM
3612 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3613 Unconditionally set to t. (Bug#10673)
3614 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3615 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3616 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3617
c5d3843c
KH
36182012-02-02 Kenichi Handa <handa@m17n.org>
3619
3620 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3621 0, do not call append_composite_glyph.
3622
159462d4 36232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3624
3625 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3626 NULL (Bug#6988).
3627 (x_produce_glyphs): If the component of a composition is a null
3628 string, set it->pixel_width to 1 to avoid zero-width glyph.
3629
78cef877
EZ
36302012-02-01 Eli Zaretskii <eliz@gnu.org>
3631
3632 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3633 first 2 arguments are identical. This makes inserting large
3634 output from a subprocess an order of magnitude faster on
3635 MS-Windows, where all sbrk'ed memory is always contiguous.
3636
97897668
GM
36372012-01-31 Glenn Morris <rgm@gnu.org>
3638
3639 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3640 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3641 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3642
31fd3586
GM
36432012-01-29 Glenn Morris <rgm@gnu.org>
3644
3645 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3646
0e24a8b2
CY
36472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3648
3649 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3650
cc0adcb0
CY
36512012-01-28 Chong Yidong <cyd@gnu.org>
3652
3653 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3654
acc28cb9
CY
36552012-01-26 Chong Yidong <cyd@gnu.org>
3656
9c69cfb7
CY
3657 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3658
acc28cb9
CY
3659 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3660 repeat counts (Bug#10507).
3661
48da7392
GM
36622012-01-26 Glenn Morris <rgm@gnu.org>
3663
3664 * lread.c (syms_of_lread): Doc fix.
3665
14af5f7f
CY
36662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3667
3668 * coding.c (encode_designation_at_bol): Change return value to
3669 EMACS_INT.
3670
0b21c100
CY
36712012-01-25 Chong Yidong <cyd@gnu.org>
3672
3673 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3674
3c2907f7
CY
36752012-01-21 Chong Yidong <cyd@gnu.org>
3676
3677 * floatfns.c (Fcopysign): Make the second argument non-optional,
3678 since nil is not allowed anyway.
3679
959ad23f
AS
36802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3681
3682 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3683 (send_process): Likewise.
3684
34a02f46
MR
36852012-01-19 Martin Rudalics <rudalics@gmx.at>
3686
3687 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3688 (Vwindow_persistent_parameters): Do not use Qstate.
3689 Rewrite doc-strings.
34a02f46 3690
1259009a 36912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3692
3693 * character.c (char_width): New function.
70d4fdf6
GM
3694 (Fchar_width, c_string_width, lisp_string_width):
3695 Use char_width (Bug#9496).
25ed9e61 3696
6a6ee00d
MR
36972012-01-16 Martin Rudalics <rudalics@gmx.at>
3698
3699 * window.c (Vwindow_persistent_parameters): New variable.
3700 (Fset_window_configuration, save_window_save): Handle persistent
3701 window parameters.
3702
c85efaf7
EZ
37032012-01-14 Eli Zaretskii <eliz@gnu.org>
3704
3705 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3706 thrashing the stack of the thread. (Bug#9087)
3707
5944709e
PE
37082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3709
3710 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3711
e71f5d99
EZ
37122012-01-11 Eli Zaretskii <eliz@gnu.org>
3713
3714 * xdisp.c (rows_from_pos_range): Handle the case where the
3715 highlight ends on a newline. (Bug#10464)
3716 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3717 he end column for display of highlight that ends on a newline
3718 before a R2L line.
3719
ce316182
GM
37202012-01-11 Glenn Morris <rgm@gnu.org>
3721
3722 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3723 from load-path also when installation-directory is nil. (Bug#10208)
3724
5b43da69
GM
37252012-01-10 Glenn Morris <rgm@gnu.org>
3726
74cc8ff9
GM
3727 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3728
7d8d6e4e
GM
3729 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3730 Update template values to be closer to their typical values these days.
5b43da69 3731
a0db8d43
EZ
37322012-01-09 Eli Zaretskii <eliz@gnu.org>
3733
3734 * xdisp.c (rows_from_pos_range): Accept additional argument
3735 DISP_STRING, and accept any glyph in a row whose object is that
3736 string as eligible for mouse highlight. Fixes mouse highlight of
3737 display strings from overlays. (Bug#10464)
3738
9a0115ab 37392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3740
b9110d6a 3741 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3742 * fileio.c (auto_saving_dir_umask): New static var.
3743 (Fmake_directory_internal): Use it.
3744 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3745 creating the directory. The old code temporarily assigns
3746 too-generous permissions to the directory.
3747 (do_auto_save_eh): Clear it.
b9110d6a 3748 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3749 that the var is always cleared.
3750
6c1bd3f3
EZ
37512012-01-07 Eli Zaretskii <eliz@gnu.org>
3752
3753 * search.c (scan_buffer): Pass character positions to
3754 know_region_cache, not byte positions. (Bug#6540)
3755
069d2b50
L
37562012-01-07 LynX <_LynX@bk.ru> (tiny change)
3757
3758 * w32.c (sys_rename): Report EXDEV when rename of a directory
3759 fails because the target is on another logical disk. (Bug#10284)
3760
75bf0d33
DB
37612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3762
3763 * xterm.c (x_embed_request_focus): New function.
3764
3765 * xterm.h: Add prototype.
3766
3767 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3768
1c6e5a32
GM
37692012-01-05 Glenn Morris <rgm@gnu.org>
3770
3771 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3772
651e947e
EZ
37732012-01-01 Eli Zaretskii <eliz@gnu.org>
3774
3775 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3776 Load gnutls_transport_set_lowat only if GnuTLS version is below
3777 2.11.1.
3778 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3779 GnuTLS versions below 2.11.1.
3780
3778cdd8
AL
37812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3782
3783 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3784 to the doc string advising against its use for altering the way
3785 windows are scrolled.
3786
0e5317f7
KH
37872011-12-28 Kenichi Handa <handa@m17n.org>
3788
3789 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3790 coding-system ASCII compatible only when it does not produce BOM
3791 on encoding (Bug#10383).
3792
93d5ca1f
JD
37932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3794
3795 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3796 can scroll.
3797 (create_and_show_popup_menu): Always use menu_position_func for
3798 Gtk3 (Bug#10361).
3799
ca22b785
AS
38002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3801
3802 * callint.c (Fcall_interactively): Don't truncate prompt string.
3803
d048e1e6
EZ
38042011-12-23 Eli Zaretskii <eliz@gnu.org>
3805
3806 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3807 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3808 resumed from there (after widening). (Bug#10360)
d048e1e6 3809
5ccaba1f
JD
38102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3811
3812 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3813
204ee57f
JD
38142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3815
b81d40f0
JB
3816 * nsterm.m (x_free_frame_resources):
3817 Release f->output_data.ns->miniimage.
204ee57f
JD
3818 (ns_index_color): Fix indentation. Do not retain
3819 color_table->colors[i].
3820
3821 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3822 before returning.
3823
3824 * nsfns.m (x_set_background_color): Assign return value from
3825 ns_index_color to face-background instead of NSColor*.
3826 (ns_implicitly_set_icon_type): Fix indentation.
3827 Change assignment in for loop to comparison.
3828
3829 * emacs.c (ns_pool): New variable.
3830 (main): Assign ns_pool.
3831 (Fkill_emacs): Call ns_release_autorelease_pool.
3832
3833 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3834 autorelease fdesc, release fdAttrs and tdict.
3835 (ns_get_covering_families): Release charset.
3836 (ns_findfonts): Release NSFontDescriptor created with new.
3837 (ns_uni_to_glyphs): Fix indentation.
3838 (setString): Release attrStr before assigning new value.
3839
c803b2b7
JD
38402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3841
678f4426
JD
3842 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3843 and NS_IMPL_COCOA.
3844 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3845 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3846
cd394be1 38472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3848
5fecd5fc
JD
3849 * nsterm.m (ns_term_init): Subscribe for notifications
3850 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3851 to method trackingNotification in EmacsMenu.
3852
3853 * nsmenu.m (trackingMenu): New variable.
3771cb17 3854 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3855 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3856 from Aquamacs (Bug#7030).
678f4426
JD
3857
38582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3859
c803b2b7
JD
3860 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3861 (symbol_to_nsstring): Fix indentation.
3862 (ns_symbol_to_pb): New function.
cae07000
SM
3863 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3864 (Fns_rotate_cut_buffers_internal): Remove.
3865 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3866 Fns_store_cut_buffer_internal.
3867 (ns_get_foreign_selection, Fx_own_selection_internal)
3868 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3869 (Fns_get_selection_internal, Fns_store_selection_internal):
3870 Use ns_symbol_to_pb and check if return value is nil.
3871 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3872 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3873 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3874 renamed to Sns_store_selection_internal.
3875 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3876 and remove this function.
3877 (ns_handle_selection_clear): Remove, never used.
3878 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3879 here.
3880
e1b01a3a
KB
38812011-12-17 Ken Brown <kbrown@cornell.edu>
3882
3883 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3884 GID is unknown (Bug#10257).
3885
2adb6e85
PE
38862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3887
3888 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3889 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3890 which caused a build failure on GNU/Linux IA-64. This problem was
3891 introduced by my 2011-10-07 patch.
3892
d1d7b339
JL
38932011-12-15 Juri Linkov <juri@jurta.org>
3894
3895 * image.c (imagemagick_error): New function. (Bug#10112)
3896 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3897 Use `imagemagick_error' where ImageMagick functions return
3898 `MagickFalse'.
3899 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3900 proper order.
3901
100d5755
KH
39022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3903
3904 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3905 fill background (Bug#8992).
3906
454592a6
MR
39072011-12-13 Martin Rudalics <rudalics@gmx.at>
3908
3909 * window.c (Vwindow_combination_resize)
3910 (Vwindow_combination_limit): Use t instead of non-nil in
3911 doc-strings.
61d4b438
MR
3912 (Vrecenter_redisplay): Add first sentence of doc-string on
3913 separate line.
53524d93 3914 (Frecenter): Fix doc-string typo.
454592a6 3915
3633e3aa
KH
39162011-12-11 Kenichi Handa <handa@m17n.org>
3917
3918 * coding.c (Funencodable_char_position): Pay attention to the
3919 buffer text relocation (Bug#9389).
3920
7b9d523a 39212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3922
7b9d523a
JD
3923 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3924 gtk_init (Bug#10100).
3925
b73189c6
EZ
39262011-12-10 Eli Zaretskii <eliz@gnu.org>
3927
3928 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3929 IT->string is nil. (Bug#10263)
3930
f7dfe5d6
JD
39312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3932
83faebb4
JD
3933 * nsterm.h (x_free_frame_resources): Declare.
3934
f7dfe5d6
JD
3935 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3936 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3937
3938 * nsterm.h (ns_get_defaults_value): Declare.
3939
3940 * nsterm.m (ns_default): Call ns_get_defaults_value.
3941
7cd4e72c
EZ
39422011-12-09 Eli Zaretskii <eliz@gnu.org>
3943
3944 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3945 (Bug#10170)
3946
b34d7317
YM
39472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3948
3949 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3950 that where the value of an _OBJC_* symbol points to is in the .bss
3951 section (Bug#10240).
3952
76470ad1
KH
39532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3954
3955 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3956 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3957
745fff94
KH
39582011-12-08 Kenichi Handa <handa@m17n.org>
3959
3960 * ftfont.c (get_adstyle_property): Fix previous change
3961 (Bug#10233).
3962
6e44397c
JB
39632011-12-07 Juanma Barranquero <lekktu@gmail.com>
3964
3965 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3966 dirs from the default value of EMACSLOADPATH (bug#10208).
3967
7efa6272
GM
39682011-12-07 Glenn Morris <rgm@gnu.org>
3969
3970 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3971 installation and source directories as well. (Bug#10208)
3972
f6fc4d87
CY
39732011-12-06 Chong Yidong <cyd@gnu.org>
3974
3975 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3976
2bf26180
GM
39772011-12-06 Glenn Morris <rgm@gnu.org>
3978
3979 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3980 as an error, not just -1. (Bug#10217)
3981
3a6ad4f0
CY
39822011-12-05 Chong Yidong <cyd@gnu.org>
3983
3984 * keyboard.c (process_special_events): New function.
3985 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3986
75a3b399
PE
39872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3988
3989 * coding.c (encode_designation_at_bol): Don't use uninitialized
3990 local variable (Bug#9318).
3991
c3c9e25e
KH
39922011-12-05 Kenichi Handa <handa@m17n.org>
3993
3994 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3995 return Qnil (Bug#8046, Bug#10193).
3996
5eb05ea3
KH
39972011-12-05 Kenichi Handa <handa@m17n.org>
3998
3999 * coding.c (encode_designation_at_bol): New args charbuf_end and
4000 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4001 (coding_set_source): Return how many bytes coding->source was
4002 relocated.
4003 (coding_set_destination): Return how many bytes
4004 coding->destination was relocated.
4005 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4006 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4007
40082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4009
4010 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4011 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4012 macro (Bug#9318).
4013
40142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4015
4016 The following changes are to fix Bug#9318.
4017
a79703f5 4018 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4019 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4020 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4021 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4022
7dbda6df
JB
40232011-12-05 Juanma Barranquero <lekktu@gmail.com>
4024
4025 * lisp.h (process_quit_flag): Fix external declaration.
4026
6d5eb5b0
SM
40272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4028
4029 Don't macro-inline non-performance-critical code.
4030 * eval.c (process_quit_flag): New function.
4031 * lisp.h (QUIT): Use it.
4032
a0c3fad0
JD
40332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4034
4035 * nsfns.m (get_geometry_from_preferences): New function.
4036 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4037
6c07aac2
AS
40382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4039
4040 * emacs.c (Qkill_emacs): Define.
4041 (syms_of_emacs): Initialize it.
4042 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4043 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4044 (quit_throw_to_read_char): Add parameter `from_signal'.
4045 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4046 * lisp.h (QUIT): Call Fkill_emacs if requested.
4047
c052ead4
JD
40482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4049
4050 * widget.c (update_wm_hints): Return if wmshell is null.
4051 (widget_update_wm_size_hints): New function.
4052
4053 * widget.h (widget_update_wm_size_hints): Declare.
4054
4055 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4056 widget_update_wm_size_hints (Bug#10104).
4057
9e49252b
EZ
40582011-12-03 Eli Zaretskii <eliz@gnu.org>
4059
4060 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4061 before a newline, prepare the bidi iterator for consuming the
4062 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4063 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4064
02b16839
JL
40652011-12-02 Juri Linkov <juri@jurta.org>
4066
4067 * search.c (Fword_search_regexp): New Lisp function created from
4068 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4069 (Fword_search_backward, Fword_search_forward)
4070 (Fword_search_backward_lax, Fword_search_forward_lax):
4071 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4072 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4073
0068070e
SM
40742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4075
4076 * fileio.c (Finsert_file_contents): Move after-change-function call
4077 to before the "handled:" label, since all "goto handled" appear in
4078 cases where the *-change-functions have already been properly called
4079 (bug#10117).
4080
3360a3fc
AS
40812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4082
4083 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4084 waiting for input. (Bug#10169)
4085
73d6c093
EZ
40862011-11-30 Eli Zaretskii <eliz@gnu.org>
4087
4088 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4089 verifies glyph row's hash code--we have just reallocated the
4090 glyphs, so their contents can be complete garbage. (Bug#10164)
4091
febe6bea
JB
40922011-11-30 Juanma Barranquero <lekktu@gmail.com>
4093
4094 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4095
801a4313
EZ
40962011-11-30 Eli Zaretskii <eliz@gnu.org>
4097
4098 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4099 attributes are tested _before_ calling verify_row_hash, to protect
4100 against GCC re-ordering of the tests. (Bug#10164)
4101
2b56b87e
JD
41022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4103
4104 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4105
4106 * xterm.c (handle_one_xevent): Only set async_visible and friends
4107 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4108 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4109 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4110
dbf31225
PE
41112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4114 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4115 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4116 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4117 All uses changed to use GCPRO1 etc.
4118 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4119 Revert to old implementation (i.e., before 2011-03-11).
4120
1305621b
YM
41212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4122
4123 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4124 of scroll runs so as to avoid assigning disabled bogus rows and
4125 unnecessary graphics copy operations.
4126
8c9afb46
EZ
41272011-11-27 Eli Zaretskii <eliz@gnu.org>
4128
4129 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4130 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4131 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4132 (malloc, free, realloc, calloc): Redirect to e_* only when
4133 compiling Emacs.
4134
4135 * lisp.h (GCTYPEBITS): Move before first use.
4136 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4137 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4138 this macro definition.
4139
4140 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4141 _MSC_VER.
4142
54e9e3bf
JD
41432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4144
6d5eb5b0
SM
4145 * gtkutil.c (xg_create_frame_widgets):
4146 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4147 present with Gtk+ 2.0.
4148
83aca1cb
PE
41492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4150
4151 * fileio.c (Finsert_file_contents): Undo previous change; see
4152 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4153
5b76caa4
PE
41542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 Rename locals to avoid shadowing.
4157 * fileio.c (Finsert_file_contents):
4158 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4159 * process.c (wait_reading_process_output):
4160 Rename inner 'proc' to 'p' to avoid shadowing.
4161 Indent for consistency with usual Emacs style.
4162
8c535114
EZ
41632011-11-25 Eli Zaretskii <eliz@gnu.org>
4164
4165 * xdisp.c (redisplay_window): If cursor row is not fully visible
4166 after recentering, and scroll-conservatively is set to a large
4167 number, scroll window by a few more lines to make the cursor fully
4168 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4169 (start_display): Don't move to the next line if the display should
4170 start at a newline that is part of a display vector or an overlay
4171 string. (Bug#10119)
8c535114 4172
fa4fdb5c
JL
41732011-11-24 Juri Linkov <juri@jurta.org>
4174
4175 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4176 after the `MagickPingImage' call. (Bug#10112)
4177
90ec88df
CY
41782011-11-23 Chong Yidong <cyd@gnu.org>
4179
4180 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4181
56e2e794
MR
41822011-11-23 Martin Rudalics <rudalics@gmx.at>
4183
4184 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4185 making another buffer current. (Bug#10114)
4186
b6e64c41
GM
41872011-11-23 Glenn Morris <rgm@gnu.org>
4188
4189 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4190
6b21de18
CY
41912011-11-23 Chong Yidong <cyd@gnu.org>
4192
4193 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4194 using it (Bug#5984).
4195
b12cd789
EZ
41962011-11-22 Eli Zaretskii <eliz@gnu.org>
4197
4198 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4199 and header-lines, as they don't have one computed for them.
4200 (Bug#10098)
4201
4202 * .gdbinit (prow): Make displayed values more self-explaining.
4203 Add row's hash code.
4204
261b6fd4
LMI
42052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4206
4207 * process.c (wait_reading_process_output): Fix asynchrounous
4208 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4209 (wait_reading_process_output): Add comment and URL.
261b6fd4 4210
e7cfd277
JD
42112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4212
4213 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4214
a9b9b7f5
CY
42152011-11-21 Chong Yidong <cyd@gnu.org>
4216
4217 * window.c (Fnext_window, Fprevious_window): Doc fix.
4218
b0d15b4f
SM
42192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4220
4221 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4222
fe7a3057
JB
42232011-11-20 Juanma Barranquero <lekktu@gmail.com>
4224
4225 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4226
d2999b1a
MR
42272011-11-20 Martin Rudalics <rudalics@gmx.at>
4228
4229 * window.c (Fset_window_combination_limit): Rename argument
4230 STATUS to LIMIT.
4231 (Vwindow_combination_limit): Remove "status" from doc-string.
4232
d5ff9cd0
AS
42332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4234
4235 * m/ibms390.h: Remove.
4236 * m/ibms390x.h: Don't include "ibms390.h".
4237
a5bb9bd3
SM
42382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4239
4240 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4241 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4242
cd1181db
JB
42432011-11-20 Juanma Barranquero <lekktu@gmail.com>
4244
4245 * casetab.c (Fset_case_table):
4246 * charset.c (Fcharset_after): Fix typos.
4247
615a3b8d 42482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4249
17e845af
PE
4250 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4251 Otherwise, valgrind does not work on some platforms.
4252 Problem reported by Andreas Schwab in
6a0bf43d
PE
4253 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4254 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4255 is set, removing the need for VIRT_ADDRESS_VARIES.
4256 (PURE_P): Use a more-efficient implementation that needs just one
4257 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4258 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4259 to 4 (xorl, subq, cmpq, setbe).
4260 * alloc.c (pure): Always extern now, since that's the
4261 VIRT_ADDR_VARIES behavior.
4262 (PURE_POINTER_P): Use a single comparison, not two, for
4263 consistency with the new puresize.h.
4264 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4265 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4266 Remove VIRT_ADDR_VARIES no longer needed.
4267
f8fe6f96
EZ
42682011-11-19 Eli Zaretskii <eliz@gnu.org>
4269
4270 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4271 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4272 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4273 behave as if the cursor position were at the window margin.
4274
4275 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4276 and the cursor position is out of bounds, behave as if the cursor
4277 position were at the window margin. (Bug#10075)
4278
df05a53c
CY
42792011-11-18 Chong Yidong <cyd@gnu.org>
4280
4281 * window.c (Fwindow_combination_limit): Make first argument
4282 non-optional, since it is meaningless for live windows like the
4283 selected window.
61ccba97 4284
2071918e
DA
42852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4286
4287 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4288
b50a28de
SM
42892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4290
4291 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4292 (graft_intervals_into_buffer): Simplify.
4293
015137db
EZ
42942011-11-18 Eli Zaretskii <eliz@gnu.org>
4295
4296 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4297 hash values of the two rows.
4298 (copy_row_except_pointers): Preserve the used[] arrays and the
4299 hash values of the two rows. (Bug#10035)
68c95424 4300 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4301
4302 * xdisp.c (row_hash): New function, body extracted from
4303 compute_line_metrics.
4304 (compute_line_metrics): Call row_hash, instead of computing the
4305 hash code inline.
4306
4307 * dispnew.c (verify_row_hash): Call row_hash for computing the
4308 hash code of a row, instead of duplicating code from xdisp.c.
4309
4310 * dispextern.h (row_hash): Add prototype.
4311
a2addb04
TH
43122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4313
4314 * frame.c (delete_frame): Don't delete the terminal when the last
4315 X frame is closed if emacs is built with GTK toolkit.
4316
df85d315
JB
43172011-11-17 Juanma Barranquero <lekktu@gmail.com>
4318
4319 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4320
a0c2d0ae
MR
43212011-11-17 Martin Rudalics <rudalics@gmx.at>
4322
4323 * window.c (Vwindow_splits): Rename to
4324 Vwindow_combination_resize. Suggested by Juri Linkov.
4325 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4326 of Vwindow_splits.
4327
58179cce
JB
43282011-11-16 Juanma Barranquero <lekktu@gmail.com>
4329
7877f373
JB
4330 * nsfns.m (Fns_font_name):
4331 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4332
b6f67890
MR
43332011-11-16 Martin Rudalics <rudalics@gmx.at>
4334
4335 * window.h (window): Rename slot "nest" to "combination_limit".
4336 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4337 (Fset_window_nest): Rename to Fset_window_combination_limit.
4338 (Vwindow_nest): Rename to Vwindow_combination_limit.
4339 (recombine_windows, make_parent_window, make_window)
4340 (Fsplit_window_internal, saved_window)
4341 (Fset_window_configuration, save_window_save): Rename all
4342 occurrences of window_nest to window_combination_limit.
4343
c7015153
JB
43442011-11-15 Juanma Barranquero <lekktu@gmail.com>
4345
4346 * image.c (imagemagick_load_image): Fix typo.
4347
322ad6ec
EZ
43482011-11-14 Eli Zaretskii <eliz@gnu.org>
4349
4350 * xdisp.c (display_line): Move the call to
4351 highlight_trailing_whitespace before the call to
4352 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4353 faces of all the glyphs to compute ROW's hash value.
4354 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4355
f067b8ec
JB
43562011-11-14 Juanma Barranquero <lekktu@gmail.com>
4357
4358 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4359 just return (bug#10044).
4360
1e5b2111
EZ
43612011-11-12 Eli Zaretskii <eliz@gnu.org>
4362
7ef3cbd5
EZ
4363 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4364 with user-defined heap size. Bump the default size of the temacs
4365 heap to 27MB, to avoid memory warning when running temacs.
4366 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4367
1e5b2111
EZ
4368 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4369 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4370 (verify_row_hash) [XASSERTS]: New function.
4371 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4372 that the hash value of glyph rows is correct.
1e5b2111 4373
89d61221
MR
43742011-11-12 Martin Rudalics <rudalics@gmx.at>
4375
4376 * window.h (window): Remove splits slot.
4377 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4378 (Fdelete_other_windows_internal, make_parent_window)
4379 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4380 (Fset_window_configuration, save_window_save): Don't deal with
4381 split status of windows.
4382 (saved_window): Remove splits slot.
4383 (Vwindow_splits): Rewrite doc-string.
4384
97f18cc8
JD
43852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4386
4387 * xfns.c (unwind_create_frame):
4388 * nsfns.m (unwind_create_frame):
4389 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4390 Vframe_list (Bug#9999).
4391
22a648b4
DA
43922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4393
0b381c7e 4394 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4395
659afede
KH
43962011-11-11 Kenichi Handa <handa@m17n.org>
4397
4398 * callproc.c (Fcall_process): Set the member dst_multibyte of
4399 process_coding.
4400
9ac0394b
KH
44012011-11-11 Johan Bockgård <bojohan@gnu.org>
4402
4403 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4404 avoid a crash (bug#9496).
4405
2fbdc249
CY
44062011-11-09 Chong Yidong <cyd@gnu.org>
4407
4408 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4409 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4410
ac6b1f81
PE
44112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4412
4413 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4414
09db192c
PE
44152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4416
4417 Avoid some portability problems by eschewing 'extern inline' functions.
4418 The trivial performance wins aren't worth the portability hassles; see
4419 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4420 et seq.
4421 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4422 (window_box_width, window_box_left, window_box_left_offset)
4423 (window_box_right, window_box_right_offset): Undo previous change,
4424 by removing the "extern"s.
4425 * intervals.c (adjust_intervals_for_insertion)
4426 (adjust_intervals_for_deletion): Undo previous change,
4427 making these static again.
4428 (offset_intervals, temp_set_point_both, temp_set_point)
4429 (copy_intervals_to_string): No longer inline.
4430 * xdisp.c (window_text_bottom_y, window_box_width)
4431 (window_box_height, window_box_left_offset)
4432 (window_box_right_offset, window_box_left, window_box_right)
4433 (window_box): No longer inline.
4434
105216ed
CY
44352011-11-08 Chong Yidong <cyd@gnu.org>
4436
4437 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4438 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4439 Signal an error if not a live window.
105216ed
CY
4440 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4441 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4442
ae9e237f
JB
44432011-11-07 Juanma Barranquero <lekktu@gmail.com>
4444
4445 * lisp.h (syms_of_abbrev): Remove declaration.
4446 Reported by CHENG Gao <chenggao@royau.me>.
4447
c7aa8333
EZ
44482011-11-07 Eli Zaretskii <eliz@gnu.org>
4449
4450 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4451 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4452 of temacs in GUI mode.
4453
be7f5545
MR
44542011-11-07 Martin Rudalics <rudalics@gmx.at>
4455
4456 * window.h: Declare delete_all_child_windows instead of
4457 delete_all_subwindows.
4458 * window.c (Fwindow_nest, Fset_window_nest)
4459 (Fset_window_new_total, Fset_window_new_normal)
4460 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4461 (delete_all_subwindows): Rename to delete_all_child_windows.
4462 (Fdelete_other_windows_internal, Fset_window_configuration):
4463 Call delete_all_child_windows instead of delete_all_subwindows.
4464 * frame.c (delete_frame): Call delete_all_child_windows instead
4465 of delete_all_subwindows.
4466
ca78dc43
PE
44672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4468
4469 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4470 This is also needed for porting to any host where GC_MARK_STACK is
4471 not GC_MAKE_GCPROS_NOOPS.
4472 (which_symbols): Use it.
4473
a0241d01
KH
44742011-11-07 Kenichi Handa <handa@m17n.org>
4475
4476 * coding.c (coding_set_destination): Check coding->src_pos only
4477 when coding->src_object is a buffer (bug#9910).
4478
4479 * process.c (send_process): Set the member src_multibyte of coding
4480 to 0 (bug#9911) when sending a unibyte text.
4481
4482 * callproc.c (Fcall_process): Set the member src_multibyte of
4483 process_coding to 0 (bug#9912).
4484
a64bfdfa 44852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4486
4487 * xmenu.c (cleanup_widget_value_tree): New function.
4488 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4489 calling free_menubar_widget_value_tree directly (Bug#9830).
4490
cb41b32a
PE
44912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4492
4493 Fix some portability problems with 'inline'.
4494 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4495 (window_box_width, window_box_left, window_box_left_offset)
4496 (window_box_right, window_box_right_offset): Declare extern.
4497 Otherwise, these inline functions do not conform to C99 and
4498 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4499 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4500 * intervals.c (adjust_intervals_for_insertion)
4501 (adjust_intervals_for_deletion): Now extern, because otherwise the
4502 extern inline functions 'offset_intervals' couldn't refer to it.
4503 (static_offset_intervals): Remove.
4504 (offset_intervals): Rewrite using the old contents of
4505 static_offset_intervals. The old version didn't conform to C99
4506 because an extern inline function contained a reference to an
4507 identifier with static linkage.
4508
b7041366
AS
45092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4510
4511 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4512 GC.
4513
88a37c4d
EZ
45142011-11-06 Eli Zaretskii <eliz@gnu.org>
4515
4516 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4517 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4518 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4519 return Qleft_to_right.
4520
49745b39
CY
45212011-11-06 Chong Yidong <cyd@gnu.org>
4522
4523 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4524 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4525 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4526 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4527 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4528 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4529 (Fwindow_vscroll): Doc fix.
4530 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4531 argument, since it makes no sense to pass a live window and for
4532 consistency with window-child.
4533
1f05cd82
CS
45342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4535
4536 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4537 support MSVC.
4538
22610910
JR
45392011-11-05 Jason Rumney <jasonr@gnu.org>
4540
4541 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4542 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4543 fonts (Bug#6029).
4544 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4545 bitwise arithmetic preventing use of unicode-sip and non-truetype
4546 opentype fonts.
4547
a06776b2
EZ
45482011-11-05 Eli Zaretskii <eliz@gnu.org>
4549
3ad924ba
EZ
4550 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4551 "emacs"-only part.
4552
a06776b2
EZ
4553 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4554 initialization code to keep similarity to xfns.c after changes
4555 from 2011-11-05.
4556
c9e7db78
JD
45572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4558
a97f8f3f
JD
4559 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4560 (unwind_create_frame): New function (Bug#9943).
4561 (Fx_create_frame): Restructure code to be more similar to the one in
4562 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4563 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4564 Move terminal->reference_count++ just before making the frame official
4565 (Bug#9943).
4566
4567 * nsterm.m (x_free_frame_resources): New function.
4568 (x_destroy_window): Move code to x_free_frame_resources.
4569
c9e7db78 4570 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4571 (Fx_create_frame, x_create_tip_frame):
4572 Move terminal->reference_count++ just before making the frame
75f1671a 4573 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4574 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4575
a6fc3b5c
EZ
45762011-11-05 Eli Zaretskii <eliz@gnu.org>
4577
4578 Support MSVC build with newer versions of Visual Studio.
4579 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4580 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4581 nt/gmake.defs.
4582
4583 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4584 which are not supported by MSVC.
4585 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4586 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4587 bitfields.
4588 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4589 types in bitfields.
4590 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4591
4592 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4593
58179cce 45942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4595
4596 Support MSVC build with newer versions of Visual Studio.
4597 * w32.c: Don't include w32api.h for MSVC.
4598 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4599
4600 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4601 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4602 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4603 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4604 e_* cousins.
4605 (alloca) [_MSC_VER]: Define to _alloca.
4606
4607 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4608
4609 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4610
a58c13ed
EZ
46112011-11-04 Eli Zaretskii <eliz@gnu.org>
4612
4613 * xdisp.c (note_mouse_highlight): If either of
4614 previous/next-single-property-change returns nil, treat that as
4615 the beginning or the end of the buffer. (Bug#9955)
4616
fe0b6370
JD
46172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4618
a58c13ed 4619 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4620 label is not null (Bug#9951).
4621 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4622 may be NULL.
4623
89bd5ee1
EZ
46242011-11-04 Eli Zaretskii <eliz@gnu.org>
4625
4626 * window.c (Fwindow_body_size): Mention in the doc string that the
4627 return value is in frame's canonical units. (Bug#9949)
4628
84c3edb9
EZ
46292011-11-03 Eli Zaretskii <eliz@gnu.org>
4630
4e2fb5c7
EZ
4631 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4632
84c3edb9 4633 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4634 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4635 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4636
bc17a887
EZ
46372011-11-01 Eli Zaretskii <eliz@gnu.org>
4638
4639 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4640 Don't stop backward scan on the continuation glyph, even though
4641 its CHARPOS is positive.
6d5eb5b0
SM
4642 (mouse_face_from_buffer_pos, note_mouse_highlight):
4643 Rename cover_string to disp_string.
bc17a887 4644
4ee88440
MR
46452011-11-01 Martin Rudalics <rudalics@gmx.at>
4646
4647 * window.c (temp_output_buffer_show): Don't use
4648 Vtemp_buffer_show_specifiers.
4649 (Vtemp_buffer_show_specifiers): Remove unused variable.
4650
c2ff3c02
EZ
46512011-10-30 Eli Zaretskii <eliz@gnu.org>
4652
4653 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4654 past the beginning of the current glyph matrix.
4655
58179cce 46562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4657
4658 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4659 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4660 HAVE_GTK3 (Bug#9869).
b77a6a7f 4661
3b574623
JD
4662 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4663 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4664
b77a6a7f
JD
4665 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4666
4667 * xterm.c: Declare x_handle_net_wm_state to return int.
4668 (handle_one_xevent): Check if we are iconified but don't have
4669 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4670 (get_current_wm_state): Return non-zero if not hidden,
4671 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4672 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4673 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4674 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4675
196e41e4
PE
46762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4679 so that this new function doesn't get optimized away by a
4680 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4681
021f2e1a
AS
46822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4683
4684 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4685
8b058d44
EZ
46862011-10-29 Eli Zaretskii <eliz@gnu.org>
4687
4688 Fix the `xbytecode' command.
4689 * .gdbinit (xprintbytestr): New command.
b50a28de 4690 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4691 (xbytecode): Print the byte-code string as well.
4692
4452fb80
EZ
46932011-10-29 Kim Storm <storm@cua.dk>
4694
8b058d44
EZ
4695 * alloc.c (which_symbols): New function.
4696
21b72067
AS
46972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4698
4699 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4700 line. (Bug#9903)
4701
83ed7b5c
GM
47022011-10-29 Glenn Morris <rgm@gnu.org>
4703
4704 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4705 Not clear what it was for, and it causes various bugs. (Bug#9839)
4706
5a7a728b
EZ
47072011-10-28 Eli Zaretskii <eliz@gnu.org>
4708
4709 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4710 possible random value that matches one of those tested as
4711 condition to clear the mouse face.
4712
d3d0842f
CY
47132011-10-28 Chong Yidong <cyd@gnu.org>
4714
4715 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4716
31b39d13
DN
47172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4718
4719 * window.c (make_window): Initialize phys_cursor_on_p.
4720
9aba6043
SM
47212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4722
4723 * lisp.h (struct Lisp_Symbol): Update comments.
4724
c20992f4
JB
47252011-10-28 Juanma Barranquero <lekktu@gmail.com>
4726
4727 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4728
db4f02f2
EZ
47292011-10-28 Eli Zaretskii <eliz@gnu.org>
4730
4731 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4732 <oslsachem@gmail.com> for helping to debug this.
4733
4734 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4735 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4736 (g_b_init_get_glyph_outline_w): New static variables.
4737 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4738 (GetGlyphOutlineW_Proc): New typedefs.
4739 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4740 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4741 New functions.
4742 (w32font_open_internal, compute_metrics):
4743 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4744 instead of calling the "wide" APIs directly.
4745
4746 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4747
4748 * w32.h (syms_of_w32font): Add prototype.
4749
87e68db4
JB
47502011-10-27 Juanma Barranquero <lekktu@gmail.com>
4751
4752 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4753 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4754 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4755 (Fmove_to_window_line): Doc fix.
4756
435c1d67
CY
47572011-10-27 Chong Yidong <cyd@gnu.org>
4758
4759 * process.c (make_process): Set gnutls_state to NULL.
4760
4761 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4762 non-NULL, regardless of GNUTLS_INITSTAGE.
4763 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4764 an error. Set process slots as soon as we allocate them.
4765
4766 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4767
9c6c6f49
CY
47682011-10-27 Chong Yidong <cyd@gnu.org>
4769
9aba6043
SM
4770 * gnutls.c (emacs_gnutls_deinit): New function.
4771 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4772 (Fgnutls_deinit, Fgnutls_boot): Use it.
4773
4774 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4775 (deactivate_process): Call emacs_gnutls_deinit.
4776
657d08d3
JB
47772011-10-27 Juanma Barranquero <lekktu@gmail.com>
4778
4779 * image.c (x_create_x_image_and_pixmap):
4780 * w32.c (sys_rename, w32_delayed_load):
4781 * w32font.c (fill_in_logfont):
4782 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4783
5430d399
JB
47842011-10-26 Juanma Barranquero <lekktu@gmail.com>
4785
4786 * w32fns.c (w32_default_color_map): New function,
4787 extracted from Fw32_default_color_map.
a7ef684b 4788 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4789
fe0055fa
PE
47902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4791
4792 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4793
e6346438
SM
47942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4795
4796 * keyboard.c (test_undefined): New function (bug#9751).
4797 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4798
e112cc37
ET
47992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4800
4801 * sysdep.c (init_sys_modes): Fix the check for the controlling
4802 terminal (Bug#6649).
4803
7b5d6677
EZ
48042011-10-20 Eli Zaretskii <eliz@gnu.org>
4805
4806 * dispextern.h (struct bidi_it): New member next_en_type.
4807
4808 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4809 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4810 current character, check also for next_en_type being WEAK_EN.
4811 (bidi_resolve_weak): Don't enter the expensive loop if the current
4812 position is before next_en_pos. Record the bidi type of the first
4813 non-ET, non-BN character we find, in addition to its position.
4814 (bidi_level_of_next_char): Invalidate next_en_type when
4815 next_en_pos is over-stepped.
4816
7da0b018
PE
48172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4818
4819 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4820 * editfns.c: Rewrite current-time-zone so that it invokes
4821 the equivalent of (format-time-string "%Z") to get the time zone name.
4822 This fixes a bug when the time zone name contains characters that
4823 need converting from the system time locale to Emacs internal format.
4824 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4825 that patch fixed format-time-string to do the conversion, but
4826 I forgot to fix current-time-zone.
4827 (format_time_string): New function, containing most of
4828 what Fformat_time_string used to contain.
4829 (Fformat_time_string): Rewrite in terms of format_time_string.
4830 This doesn't change this function's behavior.
4831 (current-time-zone): Rewrite to use format_time_string.
4832 This fixes the bug reported by Michael Schierl in
4833 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4834 Jason Rumney's 2007-06-07 change worked around this bug, but
4835 didn't fix it.
4836 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4837
8547b010
EZ
48382011-10-19 Eli Zaretskii <eliz@gnu.org>
4839
4840 * xdisp.c (start_display): If the character at POS is displayed
4841 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4842 (try_window_reusing_current_matrix): If a line ends in a display
4843 vector or the next line starts in a display vector, continue
4844 redrawing the window even though the character position of
4845 start_row was reached.
8547b010
EZ
4846 (Bug#9771, part 2)
4847
4e948d15
CY
48482011-10-18 Chong Yidong <cyd@gnu.org>
4849
4850 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4851 with nobreak-char-display too.
4852
4787455f
EZ
48532011-10-18 Eli Zaretskii <eliz@gnu.org>
4854
4855 Fix part 3 of bug#9771.
4856 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4857 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4858 non-neutral characters if the current character is a paragraph
4859 separator (a.k.a. Newline). This avoids running the same
4860 expensive loop twice, once when we consume the preceding newline
4861 and the other time when the line actually needs to be displayed.
4862 Avoid the loop when we see neutrals on the base embedding level
4863 following a character whose directionality is the same as the
4864 paragraph's. This avoids running the expensive loop when a line
4865 ends in a long sequence of neutrals, like control characters.
4866 Add assertion against STRONG_AL type. Slightly rearrange code
4867 that determines the type of a neutral given the first non-neutral
4868 that follows it.
4869 (bidi_level_of_next_char): Set next_en_pos to zero when
4870 invalidating its info.
4871
2c91f553
EZ
48722011-10-17 Eli Zaretskii <eliz@gnu.org>
4873
4874 * xdisp.c (push_display_prop): Determine whether to record string
4875 or buffer position by IT->string, not by IT->method. Allow
4876 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4877 (move_it_vertically_backward): Don't look for character position
4878 immediately after the newline when in a continuation line.
4879 (Bug#9771, part 1)
2c91f553 4880
c7b08b0d
MR
48812011-10-15 Martin Rudalics <rudalics@gmx.at>
4882
4883 * window.c (coordinates_in_window): Rewrite and delabelize
4884 vertical border check. (Bug#5357) (Bug#9618)
4885
6b02f655
SM
48862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4887
4888 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4889 errors in XSetWindowBorder (bug#9310).
4890
81d40c92
DA
48912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4892
4893 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4894 avoid crash when xmalloc overrun checking is enabled.
4895
d4172c3b
EZ
48962011-10-13 Eli Zaretskii <eliz@gnu.org>
4897
4898 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4899 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4900 cursor motion with <left> and <right> arrow keys.
4901
4902 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4903 some callers set that themselves.
4904
b00eea75
EZ
49052011-10-12 Eli Zaretskii <eliz@gnu.org>
4906
4907 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4908 display string and the previous row comes from the same string and
4909 is empty. (Bug#9739) (Bug#9738)
4910
8fe012c4
SM
49112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4912
4913 * doc.c (get_doc_string): Encode file name (bug#9735).
4914
0074aef2
EZ
49152011-10-12 Eli Zaretskii <eliz@gnu.org>
4916
79beb178
EZ
4917 * bidi.c (bidi_level_of_next_char):
4918 * xdisp.c (get_visually_first_element): Remove old incorrect
4919 comments regarding the Unicode Line Separator character.
4920
0074aef2
EZ
4921 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4922
6e4b3fbe
DA
49232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4924
4925 * alloc.c (Fgc_status): Do not access beyond zombies array
4926 boundary if nzombies > MAX_ZOMBIES.
4927 * alloc.c (dump_zombies): Add missing format specifier.
4928
0324f3af
PE
49292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4930
b5525cac
PE
4931 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4932 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4933
0324f3af
PE
4934 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4935 Some packages use them to denote characters with modifiers.
4936
e9b5f888
AS
49372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4938
4939 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4940 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4941 matching a pp-number. Rename parameter var to var1.
4942
127827c0
SM
49432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4944
4945 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4946
c8fd3bd0
GM
49472011-10-08 Glenn Morris <rgm@gnu.org>
4948
4949 * callint.c (Fcall_interactively): Give a more explicit error for the
4950 'c' case with a non-character input. (Bug#8479)
4951
352ec8ff
EZ
49522011-10-08 Eli Zaretskii <eliz@gnu.org>
4953
03669ccb
EZ
4954 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4955 lines.
7061c986
EZ
4956 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4957 lines that are hscrolled on the left.
03669ccb 4958
352ec8ff
EZ
4959 * dispnew.c (buffer_posn_from_coords): Account for a possible
4960 presence of header-line. (Bug#4426)
4961
a66cfb1c
SM
49622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4963
6b02f655
SM
4964 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4965 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4966
7c5ee88e
PE
49672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4968
4969 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4970 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4971 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4972 this makes Emacs dump core during garbage collection on rare
4973 occasions. sizeof is obviously inferior to offsetof here, so
4974 stick with offsetof.
4975 (GC_POINTER_ALIGNMENT): New macro.
4976 (mark_memory): Omit 3rd (offset) arg; caller changed.
4977 Don't assume EMACS_INT alignment is the same as pointer alignment.
4978
df1bbe5b
SM
49792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4980
4981 * keyboard.c (read_key_sequence_remapped): New var.
4982 (read_key_sequence): Compute remapping in the right buffer.
4983 (command_loop_1): Use read_key_sequence's remapping directly.
4984
51553db6
SM
49852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4986
32c1fffd
SM
4987 * dired.c (file_name_completion): Don't expand file name.
4988 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4989 before checking file name handler.
4990
51553db6
SM
4991 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4992 they've been requested explicitly (bug#9591).
4993
b6bd1599 49942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4995
4996 * keymap.c (Fsingle_key_description): Use make_specified_string
4997 instead of build_string to build string from push_key_description.
4998 (Bug#5193)
4999
f701dc2a
PE
50002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5001
4222c55d
PE
5002 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5003 This fixes a Y2038 bug on 64-bit hosts.
5004 * buffer.c (reset_buffer):
5005 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5006 (Fclear_buffer_auto_save_failure):
5007 Use 0, not -1, to represent an unset failure time, since time_t
5008 might not be signed.
5009
f701dc2a
PE
5010 Remove dependency on glibc malloc internals.
5011 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5012 Move back here from lisp.h, but with their new implementations.
5013 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5014 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5015 * charset.c (charset_table_init): New static var.
5016 (syms_of_charset): Use it instead of xmalloc. This removes a
5017 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5018 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5019 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5020 Move back to alloc.c.
5021 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5022 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5023
9ceebf39
JD
50242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5025
5026 * nsterm.m (windowDidResize): Call x_set_window_size only when
5027 ns_in_resize is true. Otherwise set pixelwidth/height and
5028 call change_frame_size (Bug#9628).
5029
cb993c58
PE
50302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5031
3930c88b
PE
5032 Port --enable-checking=all to Fedora 14 x86-64.
5033 * charset.c (syms_of_charset): Also account for glibc malloc's
5034 internal overhead when calculating the initial malloc maximum.
5035
cb993c58
PE
5036 Port --enable-checking=all to Fedora 14 x86.
5037 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5038 Move to lisp.h.
5039 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5040 (overrun_check_realloc, overrun_check_free):
5041 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5042 That way, xmalloc returns a properly-aligned pointer even if
5043 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5044 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5045 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5046 into account when calculating the initial malloc maximum.
5047 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5048 Move here from alloc.c, so that charset.c can use it too.
5049 Properly align; the old code wasn't right for common 32-bit hosts
5050 when configured with --enable-checking=all.
5051 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5052 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5053
31bed486
EZ
50542011-09-29 Eli Zaretskii <eliz@gnu.org>
5055
04c70788 5056 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5057 use EDOM.
5058
fbcaa2f3
EZ
50592011-09-28 Eli Zaretskii <eliz@gnu.org>
5060
5061 * xdisp.c (compute_display_string_end): If there's no display
5062 string at CHARPOS, return -1.
5063
5064 * bidi.c (bidi_fetch_char): When compute_display_string_end
5065 returns a negative value, treat the character as a normal
5066 character not covered by a display string. (Bug#9624)
5067
a239d4e9
JB
50682011-09-28 Juanma Barranquero <lekktu@gmail.com>
5069
5070 * lread.c (Fread_from_string): Fix typo in docstring.
5071
88652fd5
EZ
50722011-09-27 Eli Zaretskii <eliz@gnu.org>
5073
5074 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5075 newline, reseat the iterator instead of bidi-iterating there one
5076 character at a time. (Bug#9610)
32c1fffd
SM
5077 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5078 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5079
ed497dd4
AS
50802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5081
5082 * lread.c (readevalloop): Use correct code for NBSP.
5083 (read1): Likewise. (Bug#9608)
5084
b2bf61aa
MA
50852011-09-25 Michael Albinus <michael.albinus@gmx.de>
5086
5087 * dbusbind.c (Fdbus_register_signal): When service is not
5088 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5089
32bbb17c
GM
50902011-09-25 Glenn Morris <rgm@gnu.org>
5091
5092 * buffer.c (truncate-lines): Doc fix.
5093
94e0933e
CY
50942011-09-24 Chong Yidong <cyd@stupidchicken.com>
5095
5096 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5097 (Fset_window_next_buffers): Doc fix.
5098
cddde921
GM
50992011-09-24 Glenn Morris <rgm@gnu.org>
5100
5101 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5102
1260aef1
PE
51032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5104
25b4bfa0
PE
5105 Fix minor problems found by static checking.
5106 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5107 * indent.c (Fvertical_motion): Fix == vs = typo.
5108
e3cbd34b
EZ
51092011-09-24 Eli Zaretskii <eliz@gnu.org>
5110
a66cfb1c
SM
5111 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5112 Default value is now t. Doc fix.
6bf7006f 5113
e3cbd34b 5114 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5115 logic when moving up, not only when moving down. Fix the
e3cbd34b 5116 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5117 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5118
5119 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5120 CHARPOS is covered by a display string which includes newlines.
5121 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5122 is covered by a display string with embedded newlines.
5123
a3de0cbd
MA
51242011-09-24 Michael Albinus <michael.albinus@gmx.de>
5125
5126 * dbusbind.c (Fdbus_register_signal): Add match rule to
5127 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5128 (Fdbus_register_method, Vdbus_registered_objects_table):
5129 Fix docstring.
a3de0cbd 5130
b260039d
JM
51312011-09-24 Jim Meyering <meyering@redhat.com>
5132
32c1fffd 5133 do not ignore write error for any output size
b260039d
JM
5134 The previous change was incomplete.
5135 While it makes emacs --batch detect the vast majority of stdout
5136 write failures, errors were still ignored whenever the output size is
5137 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5138 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5139 && echo FAIL: ignored write error
5140 FAIL: ignored write error
5141 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5142 && echo FAIL: ignored write error
5143 FAIL: ignored write error
5144 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5145
8eca8a7c
AS
51462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5147
5148 * emacs.c (Fkill_emacs): In noninteractive mode exit
5149 non-successfully if a write error occurred on stdout. (Bug#9574)
5150
3341db62
EZ
51512011-09-21 Eli Zaretskii <eliz@gnu.org>
5152
5153 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5154 the xassert test.
5155
5156 * dispextern.h (struct it): Update the comment documenting what
5157 can it->OBJECT be.
5158
8c203dbf
EZ
51592011-09-20 Eli Zaretskii <eliz@gnu.org>
5160
5161 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5162 a display string, extend search for cursor position to end of row.
5163 (find_row_edges): If the row ends in a newline from a display
5164 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5165 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5166 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5167 non-empty line. Fixes confusing cursor motion with arrow keys at
5168 the beginning of a line that starts with whitespace.
8c203dbf 5169
a4824228
LMI
51702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5171
5172 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5173 (bug#9493).
5174
33ed493b
CY
51752011-09-18 Chong Yidong <cyd@stupidchicken.com>
5176
5177 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5178 boolean (Bug#9154).
5179
56cd55c8
EZ
51802011-09-18 Eli Zaretskii <eliz@gnu.org>
5181
5182 * xdisp.c (display_line): Record maximum and minimum buffer
5183 positions even if no glyphs were produced (e.g., by a zero-width
5184 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5185 buffer positions that will be removed from the glyph row because
5186 they don't fit.
c02dcedf
EZ
5187 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5188 column is beyond frame width: don't subtract 1 "pixel" when
5189 computing width of the stretch.
3e62b7e0
EZ
5190 (reseat_at_next_visible_line_start): Undo the change made on
5191 2011-09-17 that saved paragraph information and restored it after
5192 the call to `reseat'. (Bug#9545)
56cd55c8 5193
5ed99d36 51942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5195
5196 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5197 and turn window cursor on if cleared (Bug#9415).
5198
5ed99d36 51992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5200
5201 * search.c (boyer_moore): Take unibyte characters from pattern
5202 literally. (Bug#9458)
5203
9bade7b2
EZ
52042011-09-18 Eli Zaretskii <eliz@gnu.org>
5205
5206 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5207
e5e9d610
PE
52082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5209
87e4427a
PE
5210 Fix minor problem found by static checking.
5211 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5212 initialized, to pacify gcc -Wuninitialized.
5213
e5e9d610
PE
5214 * fileio.c: Report proper errno when syscall falls.
5215 (Finsert_file_contents): Save and restore errno,
5216 so that report_file_error outputs the correct diagnostic.
5217 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5218
a1674f0b
EZ
52192011-09-18 Eli Zaretskii <eliz@gnu.org>
5220
5221 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5222
fbfb6dd4
EZ
52232011-09-17 Eli Zaretskii <eliz@gnu.org>
5224
5225 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5226 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5227
bb187662
EZ
52282011-09-17 Eli Zaretskii <eliz@gnu.org>
5229
1137e8b8 5230 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5231 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5232
5233 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5234 (bidi_find_paragraph_start): Search back for paragraph beginning
5235 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5236 (bidi_move_to_visually_next): Only trigger paragraph-related
5237 computations when the last character is a newline or at EOB, not
5238 just any NEUTRAL_B. (Bug#9470)
5239
bb187662
EZ
5240 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5241 truncated lines if point is covered by a display string. (Bug#9524)
5242
2e621251
PE
52432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5244
5245 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5246 (cons_to_x_long): New function.
5247 (lisp_data_to_selection_data): Use it. Correct the test for
5248 short-versus-long data; it was negated. Break out of vector
5249 loop, for efficiency, when a long datum is discovered.
5250
91a15bc6
SM
52512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5252
5253 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5254
b41c3a35
EZ
52552011-09-16 Eli Zaretskii <eliz@gnu.org>
5256
5257 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5258 GCC PR/17406) by declaring this function with external scope.
5259
7812ba2d
PE
52602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5261
5262 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5263 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5264
cf7edc2a
AS
52652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5266
5267 * editfns.c (Fformat): Correctly handle text properties on "%%".
5268
bd01620e
EZ
52692011-09-15 Eli Zaretskii <eliz@gnu.org>
5270
5271 * xterm.c (x_draw_composite_glyph_string_foreground):
5272 * w32term.c (x_draw_composite_glyph_string_foreground):
5273 * term.c (encode_terminal_code):
5274 * composite.c (composition_update_it, get_composition_id):
5275 * xdisp.c (get_next_display_element)
5276 (fill_composite_glyph_string): Add comments about special meaning
5277 of TAB characters in a composition.
5278
a02719a3
PE
52792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5282 This occurs when processing a multibyte format.
5283 Problem reported by Wolfgang Jenker.
a02719a3 5284
72589a3c
JB
52852011-09-15 Johan Bockgård <bojohan@gnu.org>
5286
5287 * xdisp.c (try_cursor_movement): Only check for exact match if
5288 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5289
1c14176c
PE
52902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5291
5292 Remove unused external symbols.
5293 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5294 * xdisp.c (calc_pixel_width_or_height): Now static.
5295 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5296 * indent.c (check_display_width):
5297 * w32term.c: Fix comment to match code.
5298 * xterm.c, xterm.h (x_catching_errors): Remove.
5299
d2eea5b5
PE
53002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5301
5302 * xselect.c: Use signed conversions more consistently (Bug#9498).
5303 (selection_data_to_lisp_data): Assume incoming selection data are
5304 signed integers, not unsigned. This is to be consistent with
5305 outgoing selection data, which was modified to use signed integers
5306 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5307 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5308 expects long, not unsigned long.
5309
46888499
EZ
53102011-09-14 Eli Zaretskii <eliz@gnu.org>
5311
5312 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5313 computation of loop end. Reported by Johan Bockgård
5314 <bojohan@gnu.org>.
5315
ef8ef9fb
CY
53162011-09-13 Chong Yidong <cyd@stupidchicken.com>
5317
5318 * frame.c (Fother_visible_frames_p): Function deleted.
5319
fa819fed
EZ
53202011-09-12 Eli Zaretskii <eliz@gnu.org>
5321
5322 * indent.c (compute_motion): Process display vector front to back
5323 rather than the other way around. (Bug#2496)
5324
2ba8e008
SM
53252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5326
5327 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5328
20f53c69
CY
53292011-09-11 Chong Yidong <cyd@stupidchicken.com>
5330
5331 * minibuf.c (Fread_from_minibuffer): Doc fix.
5332
d562d7a4
EZ
53332011-09-11 Eli Zaretskii <eliz@gnu.org>
5334
5335 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5336 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5337
1c4d7f3d
LMI
53382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5339
5340 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5341 value for non-existent files.
5342
b885bf36
EZ
53432011-09-11 Eli Zaretskii <eliz@gnu.org>
5344
5345 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5346 set its "size" to -1. This will set the modtime_size field of
5347 the corresponding buffer to -1, which is what
5348 verify-visited-file-modtime expects for files that do not exist.
5349 (Bug#9139)
5350
6612f0bf
PE
53512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5352
5353 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5354 here ...
5355 * lisp.h: ... from here. push_key_description is no longer
5356 defined in keyboard.c, so its declaration should not be in
5357 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5358 logically belongs with push_key_description.
5359
dfb3f755
PE
53602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5361
5362 * buffer.h: Include <sys/types.h> instead of <time.h>.
5363 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5364 Problem reported by Herbert J. Skuhra.
5365
3134906c
LMI
53662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5367
5368 * xml.c (parse_region): Make the parsing work for
5369 non-comment-starting XML files again (bug#9144).
5370
8d903f4e
AS
53712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5372
5373 * image.c (gif_load): Fix calculation of bottom and right corner.
5374 (Bug#9468)
5375
80ad64f4
EZ
53762011-09-10 Eli Zaretskii <eliz@gnu.org>
5377
5378 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5379 redisplay in small windows.
5380
208a048d
EZ
53812011-09-09 Eli Zaretskii <eliz@gnu.org>
5382
5383 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5384
9b1c252e
MR
53852011-09-08 Martin Rudalics <rudalics@gmx.at>
5386
5387 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5388 Operate on live windows only.
5389
2949f33b
JB
53902011-09-08 Juanma Barranquero <lekktu@gmail.com>
5391
5392 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5393
e08dcafd
EZ
53942011-09-07 Eli Zaretskii <eliz@gnu.org>
5395
5396 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5397 only under bidi iteration.
5398
115b96bd
JD
53992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5400
5401 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5402
c8199d0f
PE
54032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5404
5405 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5406 Without this fix, the command to link temacs failed due to an
5407 undefined symbol __builtin_isnan. This is because
5408 /usr/include/iso/math_c99.h #defines isnan(x) to
5409 __builtin_isnan(x), but the bundled gcc, which identifies itself
5410 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5411 a __builtin_isnan.
5412 * floatfns.c (isnan): #undef, and then #define to a clone of
5413 what's in data.c.
5414 (Fisnan): Always define, since it's always available now.
5415 (syms_of_floatfns): Always define isnan at the Lisp level.
5416
e39b275c 54172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5418
5419 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5420
b2db44d9 54212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5422
f4af5137 5423 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5424 The previous code assumed that file offsets (off_t values) fit in
5425 EMACS_INT variables, which is not true on typical 32-bit hosts.
5426 The code messed up by falsely reporting buffer overflow in cases
5427 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5428 when "big" contains more than 2**29 bytes, even though this
5429 inserts just one byte and does not overflow the buffer.
5430 (Finsert_file_contents): Store file offsets as off_t
5431 values, not as EMACS_INT values. Check for overflow when
5432 converting between EMACS_INT and off_t. When checking for
5433 buffer overflow or for overlap, take the offsets into account.
5434 Don't use EMACS_INT for small values where int suffices.
5435 When checking for overlap, fix a typo: ZV was used where
5436 ZV_BYTE was intended.
5437 (Fwrite_region): Don't assume off_t fits into 'long'.
5438 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5439
ecfc0a49
MA
54402011-09-05 Michael Albinus <michael.albinus@gmx.de>
5441
5442 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5443
6511acf2 54442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5445
0999621a 5446 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5447
5448 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5449 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5450 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5451 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5452 (modify_event_symbol): Do not assume that the length of
5453 name_alist_or_stem is safe to alloca and fits in int.
5454 (Fexecute_extended_command): Likewise for function name and binding.
5455 (Frecursion_depth): Wrap around reliably on integer overflow.
5456 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5457 since some callers pass EMACS_INT values.
5458 (Fsingle_key_description): Don't crash if symbol name contains more
5459 than MAX_ALLOCA bytes.
5460 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5461 (get_minibuffer): Arg is now EMACS_INT, not int.
5462 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5463 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5464 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5465
2be7d702
PE
5466 * dbusbind.c (signature_cat): New function.
5467 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5468 Do not overrun buffer; instead, report string overflow.
5469
9d1df220
PE
5470 * dispnew.c (add_window_display_history): Don't overrun buffer.
5471 Truncate instead; this is OK since it's just a log.
5472
33ef5c64
PE
5473 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5474 even if the time zone offset is outlandishly large.
5475 Don't mishandle offset == INT_MIN.
5476
66c6fdd5
PE
5477 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5478 when creating daemon; the previous buffer-overflow check was incorrect.
5479
d749b01b
PE
5480 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5481 which has the guts of the old verror function.
5482
b5cd1905
PE
5483 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5484 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5485
6e1a67fb
PE
5486 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5487 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5488 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5489 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5490 length of string rather than counting it via multiple sprintfs;
5491 that's simpler and more reliable.
c21721cc
PE
5492 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5493 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5494 sprintf, in case result does not fit in int.
5495
c57b67fc
PE
5496 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5497 (fontset_from_font): Print it.
5498
8a401434
PE
5499 * frame.c (tty_frame_count): Now printmax_t, not int.
5500 (make_terminal_frame, set_term_frame_name): Print it.
5501 (x_report_frame_params): In X, window IDs are unsigned long,
5502 not signed long, so print them as unsigned.
5503 (validate_x_resource_name): Check for implausibly long names,
5504 and don't assume name length fits in 'int'.
5505 (x_get_resource_string): Don't blindly alloca invocation name;
5506 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5507 not fit in int.
5508
6e1a67fb
PE
5509 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5510 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5511 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5512
0df02bf3
PE
5513 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5514 Use esprintf, not sprintf, in case result does not fit in int.
5515
48e30793
PE
5516 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5517 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5518 it as a large positive number.
5519 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5520 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5521
a66ff6d8
PE
5522 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5523 in case result does not fit in int.
5524
aca216ff
PE
5525 * print.c (float_to_string): Detect width overflow more reliably.
5526 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5527 buffer overrun. Don't assume list length fits in 'int'. Treat
5528 print length of 0 as 0, not as infinity; to be consistent with other
5529 uses of print length in this function. Don't overflow print length
5530 index. Don't assume hash table size fits in 'long', or that
5531 vectorlike size fits in 'unsigned long'.
5532
31c286f7
PE
5533 * process.c (make_process): Use printmax_t, not int, to format
5534 process-name gensyms.
5535
55e5faa1
PE
5536 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5537
80f2e268
PE
5538 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5539 to avoid potential buffer overrun.
5540
670741ab
PE
5541 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5542 if X resource line is longer than 512 bytes.
5543
b7163a50
PE
5544 * xfns.c (x_window): Make sprintf buffer a bit bigger
5545 to avoid potential buffer overrun.
5546
ae58ff1f
PE
5547 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5548
c43c8a6a
PE
5549 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5550
3f8236f4
PE
55512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5552
53e9fe90 5553 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5554 Without these, Emacs silently mishandles large integers sometimes.
5555 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5556 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5557
6511acf2
PE
5558 * xdisp.c (try_window_id): Check Emacs fixnum range before
5559 converting to 'int'.
806add1d 5560
6511acf2 5561 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5562 Check that an Emacs fixnum is in range before assigning it to 'int'.
5563 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5564 values converted from Emacs fixnums.
5565 (Frecenter): Don't wrap around a line count if it is out of 'int'
5566 range; instead, treat it as an extreme value.
5567 (Fset_window_configuration, compare_window_configurations):
5568 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5569
6511acf2
PE
5570 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5571 that can exceed INT_MAX. Check that EMACS_INT value is in range
5572 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5573 (match_limit): Don't assume that a fixnum can fit in 'int'.
5574
6511acf2 5575 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5576 exceed INT_MAX.
5577
6511acf2 5578 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5579 (Fvertical_motion): Don't wrap around LINES values that don't fit
5580 in 'int'. Instead, treat them as extreme values. This is good
5581 enough for windows, which can't have more than INT_MAX lines anyway.
5582
fcb901a7
LMI
55832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5584
0f2f6b6d
LMI
5585 * Require libxml/parser.h to avoid compilation warning.
5586
fcb901a7
LMI
5587 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5588
5589 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5590 since this reportedly can destroy thread storage.
5591
6e20a0d4
CY
55922011-08-30 Chong Yidong <cyd@stupidchicken.com>
5593
5594 * syntax.c (find_defun_start): Update all cache variables if
5595 exiting early (Bug#9401).
5596
148ae00e
EZ
55972011-08-30 Eli Zaretskii <eliz@gnu.org>
5598
f6cfbd8f
EZ
5599 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5600
148ae00e
EZ
5601 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5602 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5603 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5604
5605 * term.c (tty_append_glyph): New function.
5606 (produce_stretch_glyph): Static function and its prototype deleted.
5607
a66cfb1c
SM
5608 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5609 Add prototypes.
148ae00e 5610
c4a07a4c
PE
56112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5612
5613 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5614 when checking :margin (Bug#9390).
5615 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5616 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5617 so that the name doesn't mislead. All uses changed.
5618
6bc8cd65
JB
56192011-08-28 Johan Bockgård <bojohan@gnu.org>
5620
5621 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5622 set_tty_hooks.
5623
dca4927e
EZ
56242011-08-27 Eli Zaretskii <eliz@gnu.org>
5625
5626 * xdisp.c (move_it_to): Don't bail out early when reaching
5627 position beyond to_charpos, if we are scanning backwards.
5628 (move_it_vertically_backward): When DY == 0, make sure we get to
5629 the first character in the line after the newline.
5630
f2cad773
PE
56312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5632
5633 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5634 (ccl_driver): Do not generate an out-of-range pointer.
5635 (Fccl_execute_on_string): Remove unnecessary check for
5636 integer overflow, noted by Stefan Monnier in
5637 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5638 Remove a FIXME that didn't need fixing.
5639 Simplify the newly-introduced buffer reallocation code.
5640
0cae2cdb
JB
56412011-08-27 Juanma Barranquero <lekktu@gmail.com>
5642
5643 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5644
5fc295a4 56452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5646
70c60eb2 5647 Integer and memory overflow issues (Bug#9196).
726e0ab1 5648
d31850da
PE
5649 * doc.c (get_doc_string): Rework so that
5650 get_doc_string_buffer_size is the actual buffer size, rather than
5651 being 1 less than the actual buffer size; this makes xpalloc more
5652 convenient.
5653
a69fbedb
PE
5654 * image.c (x_allocate_bitmap_record, cache_image):
5655 * xselect.c (Fx_register_dnd_atom):
5656 Simplify previous changes by using xpalloc.
5657
fe5c5d37
PE
5658 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5659 since either will do and ptrdiff_t is convenient with xpalloc.
5660
0065d054
PE
5661 * charset.c (charset_table_size)
5662 (struct charset_sort_data.priority): Now ptrdiff_t.
5663 (charset_compare): Don't overflow if priorities differ greatly.
5664 (Fsort_charsets): Don't assume list length fits in int.
5665 Check for size-calculation overflow when allocating sort data.
5666 (syms_of_charset): Allocate an initial charset table that is
5667 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5668
5669 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5670
5671 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5672 The actual value is always <= INT_MAX, and leaving it unsigned made
5673 overflow checking harder.
5674
5675 * dispextern.h (struct glyph_matrix.rows_allocated)
5676 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5677 with xpalloc. The values are still always <= INT_MAX.
5678
5679 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5680
5681 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5682 (SAFE_NALLOCA): New macro.
5683
5684 * region-cache.c (struct boundary.pos, find_cache_boundary)
5685 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5686 (set_cache_region, invalidate_region_cache)
5687 (revalidate_region_cache, know_region_cache, region_cache_forward)
5688 (region_cache_backward, pp_cache):
5689 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5690 so that ptrdiff_t * can be passed to xpalloc.
5691 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5692 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5693 (pp_cache): Don't assume cache_len fits in int.
5694 * region-cache.h: Adjust extern decls to match.
5695
5696 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5697 EMACS_INT, since either will do, for xpalloc.
5698
5699 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5700 (xnmalloc, xnrealloc, xpalloc): New functions.
5701
726e0ab1
PE
5702 * bidi.c (bidi_shelve_header_size): New constant.
5703 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5704 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5705
51f30bc5 5706 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5707 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5708 (overlay_strings):
5709 Don't update size of array until after memory allocation succeeds,
5710 because xmalloc/xrealloc may not return.
0065d054
PE
5711 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5712 now that we have proper integer overflow checking.
5713 (record_overlay_string, overlay_strings): Catch overflows when
5714 calculating size of overlay_str_buf.
726e0ab1 5715
0065d054
PE
5716 * callproc.c (Fcall_process): Check for size overflow when
5717 calculating size of args2.
5718 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5719 Normally we prefer signed values, but sticking with ptrdiff_t would
5720 require adding more-complicated checks.
726e0ab1
PE
5721
5722 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5723 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5724 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5725 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5726
5727 * character.c (Fstring): Check for size-calculation overflow.
5728
5729 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5730 unnecessary integer overflow. Check for size overflow.
5731 (encode_coding_object): Don't update size until xmalloc succeeds.
5732
5733 * composite.c (get_composition_id): Check for overflow in glyph
5734 length calculations.
5735
5736 Integer and memory overflow fixes for display code.
5737 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5738 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5739 (scrolling_window): Check for overflow in size calculations.
5740 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5741 Don't assume glyph table len fits in int.
5742 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5743 (row_table_size): Now ptrdiff_t, not int.
5744 (scrolling_window): Avoid overflow in size calculations.
5745 Don't update size until allocation succeeds.
5746 * fns.c (concat): Check for overflow in size calculations.
5747 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5748 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5749 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5750
5751 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5752 (get_doc_string): Check for size calculation overflow.
5753 Don't update size until allocation succeeds.
5754 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5755 EMACS_INT, where ptrdiff_t will do.
5756 (Fsubstitute_command_keys): Check for string overflow.
5757
5758 * editfns.c (set_time_zone_rule): Don't assume environment length
5759 fits in int.
5760 (message_length): Now ptrdiff_t, not int.
5761 (Fmessage_box): Don't update size until allocation succeeds.
5762 Don't assume message length fits in int.
5763 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5764
0065d054
PE
5765 * emacs.c (main): Do not reallocate argv, since there is a null at
5766 the end that can be overwritten, and this way there's no need to
5767 worry about size-calculation overflow.
5768 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5769
5770 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5771 alloc succeeds.
5772 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5773
5774 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5775 (x_set_scroll_bar_width, x_figure_window_size):
5776 Check for integer overflow.
5777 (x_set_alpha): Do not assume XINT fits in int.
5778
5779 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5780 This is for the members text_lines, text_cols, total_lines, total_cols,
5781 where the system imposes an 'int' limit.
5782
5783 * fringe.c (Fdefine_fringe_bitmap):
5784 Don't update size until alloc works.
5785
5786 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5787 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5788
5789 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5790 Check for size-calculation overflow.
5791 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5792 do, as we prefer signed integers.
5793 (id_to_widget.max_size, id_to_widget.used)
5794 (xg_store_widget_in_map, xg_remove_widget_from_map)
5795 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5796 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5797 Use and return ptrdiff_t, not int.
5798 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5799 * gtkutil.h: Change prototypes to match the above.
5800
5801 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5802 are duplicate now that they've been promoted to lisp.h.
5803 (x_allocate_bitmap_record, x_alloc_image_color)
5804 (make_image_cache, cache_image, xpm_load):
5805 Don't update size until alloc is done.
5806 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5807 (x_detect_edges):
3256efce 5808 Check for size calculation overflow.
726e0ab1
PE
5809 (ct_colors_allocated_max): New constant.
5810 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5811 overflow.
3256efce 5812
726e0ab1
PE
5813 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5814 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5815 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5816 Use ptrdiff_t, not int, to count maps.
5817 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5818 calculations. Don't update size until allocation succeeds.
5819 Redo calculations to avoid overflow.
726e0ab1
PE
5820 * keyboard.h: Change prototypes to match the above.
5821
5822 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5823 to count maps.
5824 (current_minor_maps): Check for size calculation overflow.
5825 * keymap.h: Change prototypes to match the above.
5826
5827 * lread.c (read1, init_obarray): Don't update size until alloc done.
5828
5829 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5830 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5831
726e0ab1
PE
5832 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5833 Now ptrdiff_t, not int.
5834 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5835 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5836
5837 * process.c (Fnetwork_interface_list): Check for overflow
5838 in size calculation.
5839
5840 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5841
5842 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5843 overflow. Don't bother calling xmalloc when xrealloc will do.
5844
5845 * search.c (Freplace_match): Check for size calculation overflow.
5846 (Fset_match_data): Don't assume list lengths fit in 'int'.
5847
5848 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5849 for command line length. Do not attempt to address one before the
5850 beginning of an array, as that's not portable.
5851
5852 * term.c (max_frame_lines): Remove; unused.
5853 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5854 not int.
5855 (encode_terminal_code, calculate_costs): Check for size
5856 calculation overflow.
5857 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5858 table lengths and related sizes. Don't update size until alloc
5859 done. Redo calculations to avoid overflow.
5860 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5861
5862 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5863 subtracting pointers.
5864 (gobble_line): Check for overflow more carefully. Don't update size
5865 until alloc done.
5866
5867 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5868 Don't update size until alloc done.
5869 Redo size calculations to avoid overflow.
5870 Check for size calculation overflow.
0065d054 5871 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5872
5873 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5874 Use ptrdiff_t, not int, for sizes.
5875 (store_mode_line_noprop_char): Don't update size until alloc done.
5876
0065d054
PE
5877 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5878 Use ptrdiff_t, not int, for sizes.
5879 (Finternal_make_lisp_face, cache_face):
5880 Check for size calculation overflow.
5881 (cache_face): Treat size calculation overflows as if they were
5882 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5883
5884 * xfns.c (x_encode_text, x_set_name_internal)
5885 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5886 sizes, since they can exceed INT_MAX in size. Check for size
5887 calculation overflow.
5888
0065d054
PE
5889 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5890 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5891 Don't update size until alloc done.
5892
0065d054 5893 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5894 as sprintf is limited to int lengths.
1d526e2f 5895
252c5ee1
PE
5896 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5897 (X_LONG_MIN): New macros.
864d7ce7
PE
5898 Use them to make the following changes clearer.
5899 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5900 This change doesn't affect the value now, but it may help remind
5901 future maintainers not to raise the value too much later.
5902 (SELECTION_QUANTUM): Remove, replacing with ...
5903 (selection_quantum): ... new function, which avoids overflow.
5904 All uses changed.
5905 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5906 assumption that selection length fits in 'int'.
5907 (x_reply_selection_request, x_handle_selection_request)
5908 (x_get_window_property, receive_incremental_selection)
5909 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5910 (lisp_data_to_selection_data, clean_local_selection_data):
5911 Use ptrdiff_t, not int, to record length of selection.
5912 (x_reply_selection_request, x_get_window_property)
5913 (receive_incremental_selection, x_property_data_to_lisp):
5914 Redo calculations to avoid overflow.
5915 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5916 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5917 something.
5918 (x_get_window_property, receive_incremental_selection)
5919 (lisp_data_to_selection_data, x_property_data_to_lisp):
5920 Check for size-calculation overflow.
5921 (x_get_window_property, receive_incremental_selection)
5922 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5923 Don't store size until memory allocation succeeds.
5924 (x_get_window_property): Plug memory leak on memory exhaustion.
5925 Don't double-block input; malloc is safe here. Don't assume 2**34
5926 - 4 fits in unsigned long. Add an xassert to check
5927 XGetWindowProperty overflow. Be more careful about overflow
5928 calculations, and distinguish size from memory overflow better.
5929 (receive_incremental_selection): When tracing, don't assume
5930 unsigned int is less than INT_MAX.
5931 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5932 harmful) conversions of unsigned short to int.
5933 (lisp_data_to_selection_data): Don't assume that integers
5934 in the range -65535 through -1 fit in an X unsigned short.
5935 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5936 result parameters unless successful. Rely on cons_to_unsigned
5937 to report problems with elements; the old code wasn't right anyway.
5938 (x_check_property_data): Check for int overflow; we cannot use
5939 a wider type due to X limits.
5940 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5941
726e0ab1 5942 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5943
0065d054
PE
5944 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5945 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5946 (x_color_cells): Don't store size until memory allocation succeeds.
5947 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5948 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5949 (x_term_init): Don't assume length fits in int (sprintf is limited
5950 to int size).
bc18e09d 5951
ebfa62c0
PE
5952 Use ptrdiff_t for composition IDs.
5953 * character.c (lisp_string_width):
5954 * composite.c (composition_table_size, n_compositions)
5955 (get_composition_id, composition_gstring_from_id):
5956 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5957 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5958 * window.c (Frecenter):
5959 Use ptrdiff_t, not int, for composition IDs.
5960 * composite.c (get_composition_id): Check for integer overflow.
5961 * composite.h: Adjust prototypes to match the above changes.
5962
d3411f89
PE
5963 Use ptrdiff_t for hash table indexes.
5964 * category.c (hash_get_category_set):
5965 * ccl.c (ccl_driver):
5966 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5967 * coding.c (coding_system_charset_list, detect_coding_system):
5968 * coding.h (struct coding_system.id):
5969 * composite.c (get_composition_id, gstring_lookup_cache):
5970 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5971 * image.c (xpm_get_color_table_h):
5972 * lisp.h (hash_lookup, hash_put):
5973 * minibuf.c (Ftest_completion):
5974 Use ptrdiff_t for hash table indexes, not int (which is too
5975 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5976 32-bit --with-wide-int hosts).
5977
e097a6fa
PE
5978 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5979 Add a FIXME comment about memory leaks.
5980 (syms_of_charset): Don't assume xmalloc returns.
5981
5637687f
PE
5982 Don't assume that stated character widths fit in int.
5983 * character.c (Fchar_width, c_string_width, lisp_string_width):
5984 * character.h (CHAR_WIDTH):
5985 * indent.c (MULTIBYTE_BYTES_WIDTH):
5986 Use sanitize_char_width to avoid undefined and/or bad behavior
5987 with outlandish widths.
a66cfb1c 5988 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5989 now that we have two such functions. All uses changed.
5990 (sanitize_char_width): New inline function.
5991
a2271ba2
PE
5992 Don't assume that tab-width fits in int.
5993 * character.h (sanitize_width): New inline function.
5994 (SANE_TAB_WIDTH): New macro.
5995 (ASCII_CHAR_WIDTH): Use it.
5996 * indent.c (sane_tab_width): Remove. All uses replaced by
5997 SANE_TAB_WIDTH (current_buffer).
5998 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5999
18c52557
PE
6000 * fileio.c: Integer overflow issues with file modes.
6001 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6002
caeeedc1
PE
6003 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6004 Remove unreachable code.
6005 (read_hex, load_charset_map_from_file): Check for integer overflow.
6006
6df6ae42 6007 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6008 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6009 (x_send_scroll_bar_event): Likewise. Check that the size does not
6010 exceed limits imposed by XClientMessageEvent, as well as the usual
6011 ptrdiff_t and size_t limits.
6012
b13995db
PE
6013 * keyboard.c: Overflow, signedness and related fixes.
6014 (make_lispy_movement): Use same integer type in forward decl
6015 that is used in the definition.
6016 (read_key_sequence, keyremap_step):
6017 Change bufsize argument back to int, undoing my 2011-03-30 change.
6018 We prefer signed types, and int is wide enough here.
6019 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6020 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6021 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6022 length, not size_t. Use ptrdiff_t for index, not int.
6023 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6024 possibility of integer overflow.
6025
13464394
PE
6026 Overflow, signedness and related fixes for images.
6027
6028 * dispextern.h (struct it.stack[0].u.image.image_id)
6029 (struct_it.image_id, struct image.id, struct image_cache.size)
6030 (struct image_cache.used, struct image_cache.ref_count):
6031 * gtkutil.c (update_frame_tool_bar):
6032 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6033 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6034 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6035 * nsmenu.m (update_frame_tool_bar):
6036 * xdisp.c (calc_pixel_width_or_height):
6037 * xfns.c (image_cache_refcount):
6038 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6039 on typical 64-bit hosts.
6040
6041 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6042 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6043 Omit unnecessary casts to int.
6044 (parse_image_spec): Check that integers fall into 'int' range
6045 when the callers expect that.
6046 (image_ascent): Redo ascent calculation to avoid int overflow.
6047 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6048 (lookup_image): Remove unnecessary tests.
6049 (xbm_image_p): Locals are now of int, not EMACS_INT,
6050 since parse_image_check makes sure they fit into int.
6051 (png_load, gif_load, svg_load_image):
6052 Prefer int to unsigned where either will do.
6053 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6054 old tiff_error_handler and tiff_warning_handler.
6055 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6056 stack buffer overflows. It uses only the features of vsnprintf
6057 that are common to both POSIX and native Microsoft.
6058 (tiff_error_handler, tiff_warning_handler): Use it.
6059 (tiff_load, gif_load, imagemagick_load_image):
6060 Don't assume :index value fits in 'int'.
6061 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6062 (imagemagick_load_image): Check that crop parameters fit into
6063 the integer types that MagickCropImage accepts. Don't assume
6064 Vimagemagick_render_type has a nonnegative value. Don't assume
6065 size_t fits in 'long'.
6066 (gs_load): Use printmax_t to print the widest integers possible.
6067 Check for integer overflow when computing image height and width.
6068
c11821d4
EZ
60692011-08-26 Eli Zaretskii <eliz@gnu.org>
6070
6071 * xdisp.c (redisplay_window): Don't force window start if point
6072 will be invisible in the resulting window. (Bug#9324)
6073
0c95fcf7
EZ
60742011-08-25 Eli Zaretskii <eliz@gnu.org>
6075
6076 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6077 the display spec is of the form `(space ...)'.
6078 (handle_display_spec): Return the value returned by
6079 handle_single_display_spec, not just 1 or zero.
6080 (handle_single_display_spec): If the display spec is of the form
6081 `(space ...)', and specifies display in the text area, return 2
6082 rather than 1.
fee65a97 6083 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6084 accurately, and prefer exact match for point under bidi.
6085 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6086
6087 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6088 into disp_prop; all users changed.
6089
6090 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6091 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6092 for the text covered by the display property.
6093
e4ed06f1
CY
60942011-08-25 Chong Yidong <cyd@stupidchicken.com>
6095
6096 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6097 Change return value to nil.
6098 (Frecord_buffer): Delete unused function.
6099
f67cdd7f
EZ
61002011-08-24 Eli Zaretskii <eliz@gnu.org>
6101
5980d4c6
EZ
6102 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6103 buffers, return left-to-right.
8610fe8b
EZ
6104 (set_cursor_from_row): Consider candidate row a win if its glyph
6105 represents a newline and point is on that newline. Fixes cursor
6106 positioning on the newline at EOL of R2L text within L2R
6107 paragraph, and vice versa.
6108 (try_cursor_movement): Check continued rows, in addition to
6109 continuation rows. Fixes unwarranted scroll when point enters a
6110 continued line of R2L text within an L2R paragraph, or vice versa.
6111 (cursor_row_p): Consider the case of point being equal to
6112 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6113 from the end of a short line to the beginning of a continued line
6114 of R2L text within L2R paragraph.
6115 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6116 composed characters.
5980d4c6 6117
f67cdd7f
EZ
6118 * bidi.c (bidi_check_type): Use xassert.
6119 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6120 members.
6121
bca633fb
EZ
61222011-08-23 Eli Zaretskii <eliz@gnu.org>
6123
6124 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6125 a character.
6126
4a5885a7
CY
61272011-08-23 Chong Yidong <cyd@stupidchicken.com>
6128
6129 * nsfont.m (ns_otf_to_script): Fix typo.
6130
0902a04e
KH
61312011-08-22 Kenichi Handa <handa@m17n.org>
6132
6133 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6134 extra slot even if the purpose is char-code-property-table.
6135
1a2e6670
EZ
61362011-08-23 Eli Zaretskii <eliz@gnu.org>
6137
8ddde651
EZ
6138 * xdisp.c (redisplay_window): When computing centering_position,
6139 account for the height of the header line. (Bug#8874)
6140
425cc014
EZ
6141 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6142 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6143 candidate is selected by the mouse, and that candidate has a
6144 composed character under the mouse.
6145
1a2e6670
EZ
6146 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6147 coordinates reported by pos-visible-in-window-p for a composed
6148 character in column zero.
6149
8b76d6f8
SM
61502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6151
6152 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6153
dac347dd
EZ
61542011-08-22 Eli Zaretskii <eliz@gnu.org>
6155
6156 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6157 consider it a hit if to_charpos is anywhere in the range of the
6158 composed buffer positions.
6159
e013fb34
CY
61602011-08-22 Chong Yidong <cyd@stupidchicken.com>
6161
6162 * image.c (gif_load): Don't assume that each subimage has the same
6163 dimensions as the base image. Handle disposal method that is
6164 "undefined" by the gif spec (Bug#9335).
6165
bd1ba3e8
CY
61662011-08-20 Chong Yidong <cyd@stupidchicken.com>
6167
6168 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6169 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6170
54a1215b
EZ
61712011-08-19 Eli Zaretskii <eliz@gnu.org>
6172
823564e5
EZ
6173 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6174 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6175 from an Org mode buffer to a Speedbar frame.
6176
54a1215b
EZ
6177 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6178 a composition, take its buffer position from IT->cmp_it.charpos.
6179 Fixes cursor positioning at the beginning of a line that begins
6180 with a composed character.
6181
9778ebcc
EZ
61822011-08-18 Eli Zaretskii <eliz@gnu.org>
6183
0be6ee06
EZ
6184 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6185 character bidirectional type, use STRONG_L instead. Fixes crashes
6186 in a buffer produced by `describe-categories'.
6187
9778ebcc
EZ
6188 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6189 members before the level stack, so they would be saved and
6190 restored when copying iterator state. Fixes incorrect reordering
6191 around TABs covered by display properties.
6192
156bffbe
AS
61932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6194
6b02f655 6195 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6196
72ad093b
CY
61972011-08-17 Chong Yidong <cyd@stupidchicken.com>
6198
6199 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6200 (internal_condition_case_2, internal_condition_case_n):
6201 Remove unnecessary aborts (Bug#9081).
72ad093b 6202
35774242
EZ
62032011-08-17 Eli Zaretskii <eliz@gnu.org>
6204
6205 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6206 has no `load' handler, try opening the file locally. (Bug#9311)
6207
db76dd85
KB
62082011-08-16 Ken Brown <kbrown@cornell.edu>
6209
6210 * gmalloc.c: Expand comment.
6211
b215eee5
EZ
62122011-08-16 Eli Zaretskii <eliz@gnu.org>
6213
6214 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6215 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6216
a4579d33
KB
62172011-08-16 Ken Brown <kbrown@cornell.edu>
6218
6219 Fix memory allocation problems in Cygwin build (Bug#9273).
6220
6221 * unexcw.c ( __malloc_initialized): Declare external variable.
6222 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6223
8b76d6f8
SM
6224 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6225 New variables.
a4579d33
KB
6226 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6227 dumped emacs.
6228 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6229 in the static heap.
6230 [CYGWIN] (special_realloc): New function.
6231 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6232 requests to realloc storage in the static heap.
6233
3ebec551
PE
62342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6235
6236 * bidi.c (bidi_initialize): Remove unused local.
6237
9fd8be00
EZ
62382011-08-15 Eli Zaretskii <eliz@gnu.org>
6239
6b02f655
SM
6240 * bidimirror.h:
6241 * biditype.h: Remove file.
6242 * makefile.w32-in ($(BLD)/bidi.$(O)):
6243 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6244
6245 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6246
6247 * chartab.c: Improve commentary for the uniprop_table API.
6248
32413314
EZ
6249 * bidi.c (bidi_paragraph_init): Support zero value of
6250 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6251 (bidi_initialize): Use uniprop_table instead of including
6252 biditype.h and bidimirror.h.
32413314 6253
9fd8be00
EZ
6254 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6255 coordinates of the iterator when restoring from ppos_it.
6256 (Bug#9296)
6257
5cf2b69b
KH
62582011-08-14 Kenichi Handa <handa@m17n.org>
6259
6260 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6261 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6262
daf17d00
EZ
62632011-08-14 Eli Zaretskii <eliz@gnu.org>
6264
6265 * xdisp.c (move_it_in_display_line_to): Don't invoke
6266 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6267 ppos_it. Fixes vertical cursor motion when line beginning is
6268 covered by an image. (Bug#9296)
6269
08e3161a
JD
62702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6271
6272 * nsterm.h (ns_run_ascript): Declare.
6273 (NSAPP_DATA2_RUNASSCRIPT): Define.
6274
6275 * nsfns.m (as_script, as_result, as_status): New static variables.
6276 (ns_run_ascript): New function.
5e617bc2 6277 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6278 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6279 the event loop. Get status from as_status (Bug#7276).
6280
6281 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6282 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6283 the event loop (Bug#7276).
6284
a3720aa2
AS
62852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6286
6287 * gnutls.c (QCgnutls_bootprop_priority)
6288 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6289 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6290 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6291 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6292 (QCgnutls_bootprop_verify_hostname_error)
6293 (QCgnutls_bootprop_callbacks_verify): Rename from
6294 Qgnutls_bootprop_..., all uses changed.
6295
6296 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6297 uses changed.
6298
0a0d27fb
PE
62992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6300
19d5c50c
PE
6301 * xfaces.c (Qframe_set_background_mode): Now static.
6302 * dispextern.h (Qframe_set_background_mode): Remove decl.
6303
0a0d27fb
PE
6304 * process.c (Fnetwork_interface_info): Declare local only if needed.
6305
377538cb
JD
63062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6307
6308 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6309 (Fnetwork_interface_list): Allocate in increments of bytes instead
6310 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6311 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6312 sockaddr.
6313 (struct ifflag_def): notrailers is smart on OSX.
6314 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6315 Get hardware address with getifaddrs if available.
6316
08fff70c
EZ
63172011-08-12 Eli Zaretskii <eliz@gnu.org>
6318
6319 * xdisp.c (iterate_out_of_display_property): xassert that
6320 IT->position is set to within IT->object's boundaries. Break from
6321 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6322 when IT->position is set up wrongly due to some bug.
6323 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6324 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6325 entry. Force push_it to save on the stack the current
6326 buffer/string position, to be restored by pop_it. Fix flags in
6327 the iterator structure wrt the object coming from a display
6328 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6329 properties. (Bug#9284)
6330
7be1c708 63312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6332
7be1c708
CY
6333 * fontset.c (fontset_get_font_group): Add proper type checks.
6334 (Bug#9172)
aac0c6e3 6335
7be1c708 63362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6337
7be1c708
CY
6338 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6339 and LC_VERSION_MIN_MACOSX.
6340 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6341 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6342
97bb72a6
EZ
63432011-08-08 Eli Zaretskii <eliz@gnu.org>
6344
6345 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6346 no-display-properties-and-no-overlays under bidi display.
6347 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6348 properties and overlays.
97bb72a6 6349
d5617611
CY
63502011-08-08 Chong Yidong <cyd@stupidchicken.com>
6351
37e11a63
CY
6352 * editfns.c (Fset_time_zone_rule): Document relationship with the
6353 setenv function.
6354
d5617611
CY
6355 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6356 the font entity extracted from the cache (Bug#8109).
6357
58872834
CY
63582011-08-07 Chong Yidong <cyd@stupidchicken.com>
6359
6360 * composite.c (autocmp_chars): Don't reset point. That is done by
6361 restore_point_unwind (Bug#5984).
6362
75bfc667
JL
63632011-08-07 Juri Linkov <juri@jurta.org>
6364
6365 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6366 to show the arg `TIME' instead of `TIMEVAL'.
6367
d1410150
EZ
63682011-08-06 Eli Zaretskii <eliz@gnu.org>
6369
6370 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6371 display property strides EOL and includes a newline, as in
6372 longlines-mode. (Bug#9254)
75b771e4
EZ
6373 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6374 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6375
6376 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6377 is non-zero, even if the data buffer is NULL. Fixes a crash in
6378 vertical-motion with longlines-mode. (Bug#9254)
6379
35928349
EZ
63802011-08-05 Eli Zaretskii <eliz@gnu.org>
6381
ec7cc85b
EZ
6382 * bidi.c <bidi_cache_total_alloc>: Now static.
6383 (bidi_initialize): Initialize bidi_cache_total_alloc.
6384
8b76d6f8 6385 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6386 cache. (Bug#9221)
6387
6388 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6389 amount allocated this far in `bidi_cache_total_alloc'.
6390 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6391 non-zero, only free the data buffer without restoring the cache
6392 contents. All callers changed.
6393
6394 * dispextern.h (bidi_unshelve_cache): Update prototype.
6395
6396 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6397 (move_it_in_display_line, move_it_to)
6398 (move_it_vertically_backward, move_it_by_lines): Replace the call
6399 to xfree to an equivalent call to bidi_unshelve_cache.
6400 (move_it_in_display_line_to): Fix logic of returning
412b6358 6401 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6402
e2e2423b
EZ
64032011-08-05 Eli Zaretskii <eliz@gnu.org>
6404
6405 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6406 came from a string character with a `cursor' property. (Bug#9229)
6407
ae9e757a
JD
64082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6409
6410 * Makefile.in (LIB_PTHREAD): New variable.
6411 (LIBES): Add LIB_PTHREAD (Bug#9216).
6412
6413 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6414 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6415
213bd7f2
AS
64162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6417
6b02f655 6418 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6419
99aaf75f
JD
64202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6421
6422 * xterm.c (x_find_topmost_parent): New function.
6423 (x_set_frame_alpha): Find topmost parent window with
6424 x_find_topmost_parent and set the property there also (bug#9181).
6425 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6426
c74e9d86
PE
64272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6428
6429 * callproc.c (Fcall_process): Avoid vfork clobbering
6430 the local vars buffer, coding_systems, current_dir.
6431
640c8776
SM
64322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6433
6434 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6435
f26d0e4c
PE
64362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6437
8a10d76c
PE
6438 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6439 so that it is not optimized away.
6440
f26d0e4c
PE
6441 * xdisp.c (compute_display_string_pos): Remove unused local.
6442
55439c61
EZ
64432011-08-02 Eli Zaretskii <eliz@gnu.org>
6444
6445 Fix slow cursor motion and scrolling in large buffers with
6446 selective display, like Org Mode buffers. (Bug#9218)
6447
6448 * dispextern.h (struct bidi_it): New member disp_prop_p.
6449
6450 * xdisp.c: Remove one-slot cache of display string positions.
6451 (compute_display_string_pos): Accept an additional argument
5e617bc2 6452 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6453 for a display string or property. If found, set DISP_PROP_P
6454 non-zero.
6455
6456 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6457 DISP_PROP_P, and pass it to compute_display_string_pos.
6458 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6459 non-zero. All callers of bidi_fetch_char changed.
6460
fb33fa43
SM
64612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6462
6463 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6464
b099e063
DM
64652010-12-03 Don March <don@ohspite.net>
6466
6467 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6468 last character M-[char] is translated to ESC [char] (bug#7541).
6469
5cc7f7af
KH
64702011-08-02 Kenichi Handa <handa@m17n.org>
6471
d0fffa3f 6472 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6473
6474 * chartab.c (uniprop_table): Make it non-static.
6475
525d5e6e
EZ
64762011-08-01 Eli Zaretskii <eliz@gnu.org>
6477
6478 * xdisp.c (forward_to_next_line_start): Accept additional argument
6479 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6480 on the newline.
6481 (reseat_at_next_visible_line_start): Use the bidi iterator state
6482 returned by forward_to_next_line_start to restore the state of
6483 it->bidi_it after backing up to previous newline. (Bug#9212)
6484
31011111
AS
64852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6486
6487 * regex.c (re_comp): Protoize.
6488 (re_exec): Fix return type.
6489 (regexec): Fix type of `ret'. (Bug#9203)
6490
476371c4
PE
64912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6492
e5d76069
PE
6493 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6494 This is needed if max-image-size is a floating-point number.
6495
9a79b20c
AS
64962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6497
6498 * print.c (print_object): Print empty symbol as ##.
6499
6500 * lread.c (read1): Read ## as empty symbol.
6501
d8c2fa78
AA
65022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6503
6504 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6505 setting frame foreground color (Bug#9175).
6506 (x_set_background_color): Likewise.
6507
ffe57a7a
AA
6508 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6509 contents (Bug#9176).
6510 (EmacsTooltip -init): Remove bezels and add shadows to
6511 tooltip windows.
6512
bf3492a5
AA
6513 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6514 or scroll bar (Bug#8470).
6515
d55e9c53
AA
6516 * nsfont.m (nsfont_open): Remove assignment to voffset and
6517 unnecessary vars hshink, expand, hd, full_height, min_height.
6518 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6519
6520 * nsterm.h (nsfont_info): Remove voffset field.
6521
d8c2fa78 65222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6523
6524 Implement strike-through and overline on NextStep (Bug#8863).
6525
6526 * nsfont.m (nsfont_open): Use underline position provided by font,
6527 instead of hard-coded value of 2.
6528 (nsfont_draw): Call ns_draw_text_decoration instead.
6529
6530 * nsterm.h: Add declaration for ns_draw_text_decoration.
6531
6532 * nsterm.m (ns_draw_text_decoration): New function for drawing
6533 underline, overline, and strike-through.
6534 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6535 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6536 accommodate underlining, etc.
4843aac3 6537
4cc60b9b
EZ
65382011-07-28 Eli Zaretskii <eliz@gnu.org>
6539
bc7ece87
EZ
6540 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6541 default.
4cc60b9b 6542
476371c4
PE
65432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6544
66606eea
PE
6545 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6546 Without this fix, if a signal arrives just after memory fills up,
6547 'malloc' might be invoked reentrantly.
6548
476371c4
PE
6549 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6550 In other words, assume that every image size is allowed, on non-X
6551 hosts. This assumption is probably wrong, but it lets Emacs compile.
6552
f3fcc40d
AS
65532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6554
6555 * regex.c (re_iswctype): Convert return values to boolean.
6556
350c992f
EZ
65572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6558
6559 * xdisp.c (compute_display_string_pos): Don't use cached display
6560 string position if the buffer had its restriction changed.
6561 (Bug#9184)
6562
5266b4bb
PE
65632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6564
6565 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6566
2573a837 65672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6568
41f55ccd 6569 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6570
39e378da
PE
6571 * bidi.c: Integer size and overflow fixes.
6572 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6573 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6574 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6575 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6576 (bidi_find_other_level_edge):
6577 Use ptrdiff_t instead of EMACS_INT where either will do.
6578 This works better on 32-bit hosts configured --with-wide-int.
6579 (bidi_cache_ensure_space): Check for size-calculation overflow.
6580 Use % rather than repeated addition, for better worst-case speed.
6581 Don't set bidi_cache_size until after xrealloc returns, because it
6582 might not return.
6583 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6584 (bidi_cache_ensure_space): Also check that the bidi cache size
6585 does not exceed that of the largest Lisp string or buffer. See Eli
6586 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6587
5e927815
PE
6588 * alloc.c (__malloc_size_t): Remove.
6589 All uses replaced by size_t. See Andreas Schwab's note
6590 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6591
ca4aa935
PE
6592 * image.c: Improve checking for integer overflow.
6593 (check_image_size): Assume that f is nonnull, since
6594 it is always nonnull in practice. This is one less thing to
6595 worry about when checking for integer overflow later.
6596 (x_check_image_size): New function, which checks for integer
6597 overflow issues inside X.
6598 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6599 This removes the need for a memory_full check.
6600 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6601 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6602 (xbm_read_bitmap_data): Change locals back to 'int', since
6603 their values must fit in 'int'.
6604 (xpm_load_image, png_load, tiff_load):
6605 Invoke x_create_x_image_and_pixmap earlier,
6606 to avoid much needless work if the image is too large.
6607 (tiff_load): Treat overly large images as if
6608 x_create_x_image_and_pixmap failed, not as malloc failures.
6609 (gs_load): Use x_check_image_size.
6610
5f8f9cc2
PE
6611 * gtkutil.c: Omit integer casts.
6612 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6613 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6614
5adf60bc
PE
6615 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6616
c8907a93
PE
6617 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6618 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6619 would wrongly return t on a 64-bit host.
6620
e3c25c68
PE
6621 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6622 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6623 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6624 and therefore cause GCC to emit a bogus diagnostic in some cases.
6625
3f791afe
PE
6626 * image.c: Integer signedness and overflow and related fixes.
6627 This is not an exhaustive set of fixes, but it's time to
6628 record what I've got.
6629 (lookup_pixel_color, check_image_size): Remove redundant decls.
6630 (check_image_size): Don't assume that arbitrary EMACS_INT values
6631 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6632 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6633 (tiff_load, imagemagick_load_image):
6634 Check for overflow in size calculations.
6635 (x_create_x_image_and_pixmap): Remove unnecessary test for
6636 xmalloc returning NULL; that can't happen.
6637 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6638 (xpm_color_bucket): Use better integer hashing function.
6639 (xpm_cache_color): Don't possibly over-allocate memory.
6640 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6641 (gif_memory_source):
6642 Use ptrdiff_t, not int or size_t, to record sizes.
6643 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6644 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6645 either works, as we prefer signed integers.
6646 (tiff_read_from_memory, tiff_write_from_memory):
6647 Return tsize_t, not size_t, since that's what the TIFF API wants.
6648 (tiff_read_from_memory): Don't fail simply because the read would
6649 go past EOF; instead, return a short read.
6650 (tiff_load): Omit no-longer-needed casts.
6651 (Fimagemagick_types): Don't assume size fits into 'int'.
6652
3cc5a532
PE
6653 Improve hashing quality when configured --with-wide-int.
6654 * fns.c (hash_string): New function, taken from sxhash_string.
6655 Do not discard information about ASCII character case; this
6656 discarding is no longer needed.
6657 (sxhash-string): Use it. Change sig to match it. Caller changed.
6658 * lisp.h: Declare it.
6659 * lread.c (hash_string): Remove, since we now use fns.c's version.
6660 The fns.c version returns a wider integer if --with-wide-int is
6661 specified, so this should help the quality of the hashing a bit.
6662
b312a492
PE
6663 * emacs.c: Integer overflow minor fix.
6664 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6665 Define only if GNU_LINUX.
6666 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6667
dfd153ae
PE
6668 * dispnew.c: Integer signedness and overflow fixes.
6669 Remove unnecessary forward decls, that were a maintenance hassle.
6670 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6671 All uses changed.
6672 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6673 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6674 (prepare_desired_row, line_draw_cost):
6675 Use int, not unsigned, where either works.
6676 (save_current_matrix, restore_current_matrix):
6677 Use ptrdiff_t, not size_t, where either works.
6678 (init_display): Check for overflow more accurately, and without
6679 relying on undefined behavior.
6680
a81d11a3
PE
6681 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6682 Remove, replacing with the new symbols in lisp.h. All uses changed.
6683 * fileio.c (make_temp_name):
6684 * filelock.c (lock_file_1, lock_file):
6685 * xdisp.c (message_dolog):
6686 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6687 Use pMd etc. instead.
6688 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6689 replacing the pWIDE etc. symbols removed from editfns.c.
6690
3300e6fd
PE
6691 * keyboard.h (num_input_events): Now uintmax_t.
6692 This is (very slightly) less likely to mess up due to wraparound.
6693 All uses changed.
6694
fd05c7e9
PE
6695 * buffer.c: Integer signedness fixes.
6696 (alloc_buffer_text, enlarge_buffer_text):
6697 Use ptrdiff_t rather than size_t when either will do, as we prefer
6698 signed integers.
6699
903fe15d
PE
6700 * alloc.c: Integer signedness and overflow fixes.
6701 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6702 (__malloc_size_t): Default to size_t, not to int.
6703 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6704 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6705 Prefer ptrdiff_t to size_t when either would do, as we prefer
6706 signed integers.
6707 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6708 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6709 Now const. Initialize with values that are in range even if char
6710 is signed.
6711 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6712 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6713 These functions do the right thing with sizes > 2**32.
6714 (check_depth): Now ptrdiff_t, not int.
6715 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6716 Adjust to new way of storing sizes. Check for size overflow bugs
6717 in rest of code.
6718 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6719 slightly wrong anyway, as it missed one instance of
6720 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6721 (refill_memory_reserve): Omit needless cast to size_t.
6722 (mark_object_loop_halt): Mark as externally visible.
6723
ac82cc6a
PE
6724 * xselect.c: Integer signedness and overflow fixes.
6725 (Fx_register_dnd_atom, x_handle_dnd_message):
6726 Use ptrdiff_t, not size_t, since we prefer signed.
6727 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6728 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6729 x_dnd_atoms_size and x_dnd_atoms_length.
6730
c2d1e36d
PE
6731 * doprnt.c: Prefer signed to unsigned when either works.
6732 * eval.c (verror):
6733 * doprnt.c (doprnt):
6734 * lisp.h (doprnt):
6735 * xdisp.c (vmessage):
6736 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6737 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6738 prefer signed arithmetic to avoid comparison confusion.
6739 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6740 but is a bit tricky.
6741
0e926e56
PE
6742 Assume freestanding C89 headers, string.h, stdlib.h.
6743 * data.c, doprnt.c, floatfns.c, print.c:
6744 Include float.h unconditionally.
6745 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6746 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6747 * regex.c: Likewise for stddef.h, string.h.
6748 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6749 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6750 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6751 (STDC_HEADERS): Remove obsolete defines.
6752 * sysdep.c: Include limits.h unconditionally.
6753
9cfdb3ec
PE
6754 Assume support for memcmp, memcpy, memmove, memset.
6755 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6756 * regex.c (memcmp, memcpy):
6757 Remove; we assume C89 now.
6758
6759 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6760 (__malloc_safe_bcopy): Remove; no longer needed.
6761
cf950e6b 6762 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6763 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6764 well either way, and we prefer signed to unsigned.
6765
dbf38e02
LMI
67662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6767
6768 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6769 closes the connection while we're reading (bug#9182).
6770
d6f0886c 67712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6772
d6f0886c
JD
6773 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6774 are specified (Bug#9168).
24e0f6b1 6775
2eb1f9e6
PE
67762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6777
6778 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6779 Found by GCC static checking and --with-wide-int on a 32-bit host.
6780
22381272 67812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6782
6783 * xdisp.c (compute_display_string_pos): Fix logic of caching
6784 previous display string position. Initialize cached_prev_pos to
6785 -1. Fixes slow-down at the beginning of a buffer.
6786
f25e39b4
EZ
67872011-07-24 Eli Zaretskii <eliz@gnu.org>
6788
6789 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6790 for attrs[LFACE_FONTSET_INDEX].
6791
04c4b52e
PE
67922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6793
6794 * xml.c (parse_region): Remove unused local
6795 that was recently introduced.
6796
c1734fbd
EZ
67972011-07-23 Eli Zaretskii <eliz@gnu.org>
6798
be18c5a5
EZ
6799 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6800 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6801
c1734fbd
EZ
6802 * xdisp.c (move_it_in_display_line_to): Record the best matching
6803 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6804 exit if none of the characters scanned was an exact match.
6805 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6806 when exact match is impossible due to invisible text, and the
6807 lines are truncated.
6808
a258d627
JD
68092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6810
6811 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6812 for OSX >= 10.7.
6813
b6d5a689
EZ
68142011-07-22 Eli Zaretskii <eliz@gnu.org>
6815
0f74f785
EZ
6816 Fix a significant slow-down of cursor motion with C-n, C-p,
6817 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6818 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6819 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6820 (next_element_from_buffer): Call compute_stop_pos_backwards to
6821 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6822 base_level_stop.
6823 (reseat): Don't look for prev_stop, as that could mean a very long
6824 run.
6825 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6826 <cached_disp_overlay_modiff>: Cache for last found display string
6827 position.
551918c1 6828 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6829 about the same buffer in the same area of character positions, and
6830 the buffer wasn't changed since the time the display string
6831 position was cached.
551918c1 6832
b2d0c91a
EZ
68332011-07-22 Eli Zaretskii <eliz@gnu.org>
6834
6835 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6836 is an integer, which is important for empty lines. (Bug#9149)
6837
043604ee
CY
68382011-07-22 Chong Yidong <cyd@stupidchicken.com>
6839
6840 * frame.c (Fmodify_frame_parameters): In tty case, update the
6841 default face if necessary (Bug#4238).
6842
da4adb04
CY
68432011-07-21 Chong Yidong <cyd@stupidchicken.com>
6844
6845 * editfns.c (Fstring_to_char): No need to explain what a character
6846 is in the docstring (Bug#6576).
6847
9abd0532
LMI
68482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6849
6850 * xml.c (parse_region): Make sure we always return a tree.
6851
36881d16
HK
68522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6853
6854 * xml.c (parse_region): If a document contains only comments,
6855 return that, too.
6856
1e98674d
LMI
68572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6858
6859 * xml.c (make_dom): Return comments, too.
6860
590bd467
PE
68612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6862
6863 Port to OpenBSD.
6864 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6865 and the surrounding thread.
6866 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6867 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6868 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6869 timer goes off.
6870 * s/openbsd.h (BROKEN_SIGIO): Define.
6871 * unexelf.c (unexec) [__OpenBSD__]:
6872 Don't update the .mdebug section of the Alpha COFF symbol table.
6873
f41628b2
LMI
68742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6875
6876 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6877 (bug#8460).
6878
b59b67c5
PE
68792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6880
15e3a074
PE
6881 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6882 This fixes some race conditions on the permissions of any newly
6883 created file.
6884
41bed37d
PE
6885 * alloc.c (valid_pointer_p): Use pipe, not open.
6886 This fixes some permissions issues when debugging.
6887
b59b67c5
PE
6888 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6889 If fchown fails to set both uid and gid, try to set just gid,
6890 as that is sometimes allowed. Adjust the file's mode to eliminate
6891 setuid or setgid bits that are inappropriate if fchown fails.
6892
925a6be7
SM
68932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6894
6895 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6896 to compare Lisp_Objects.
6897 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6898 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6899 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6900
52968808
AS
69012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6902
0a6a104b
AS
6903 * lread.c (read_integer): Unread even EOF character.
6904 (read1): Likewise. Properly record start position of symbol.
6905
52968808
AS
6906 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6907 symbol character follows.
6908
9e381cdd
PE
69092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6910
6911 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6912 This works around a problem with the previous change to Fcopy_file.
6913 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6914 and without this change, GCC might complain about discarding
6915 fchown's return value.
6916
b5641435
JB
69172011-07-16 Juanma Barranquero <lekktu@gmail.com>
6918
6919 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6920
a8031457
PE
69212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6922
6923 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6924
dd889327
LMI
69252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6926
750c33f7
LMI
6927 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6928 it's used from the C level.
6929
dd889327
LMI
6930 * process.c: Use the same condition for POLL_FOR_INPUT in both
6931 keyboard.c and process.c (bug#1858).
6932
87e86684
LM
69332011-07-09 Lawrence Mitchell <wence@gmx.li>
6934
6935 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6936 (Fgnutls_boot): Use it.
6937
64348f40
AS
69382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6939
6940 * doc.c (Fsubstitute_command_keys): Revert last change.
6941
1d698799
LMI
69422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6943
f863868c
LMI
6944 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6945 quotes the next character, and doesn't affect other longer
6946 sequences (bug#8935).
6947
1d698799
LMI
6948 * lread.c (syms_of_lread): Clarify that is isn't only
6949 `eval-buffer' and `eval-defun' that's affected by
6950 `lexical-binding' (bug#8460).
6951
aa4b6df6
EZ
69522011-07-15 Eli Zaretskii <eliz@gnu.org>
6953
6954 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6955 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6956
5d856da6
PE
69572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6958
ad6042bb
PE
6959 Fix minor problems found by static checking.
6960 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6961 (elsz): Now a signed constant, not a size_t var. We prefer signed
6962 types to unsigned, to avoid integer comparison confusion. Without
6963 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6964 "cannot optimize loop, the loop counter may overflow", a symptom
6965 of the confusion.
f00bbb22 6966 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6967 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6968
6468f31c
LMI
69692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6970
49080b10
LMI
6971 * search.c (Fre_search_backward): Mention `case-fold-search' in
6972 all the re_search_* functions (bug#8138).
6973
6468f31c
LMI
6974 * keyboard.c (Fopen_dribble_file): Document when the file is
6975 closed (bug#8056).
6976
c965adc5
EZ
69772011-07-14 Eli Zaretskii <eliz@gnu.org>
6978
df9733bf
EZ
6979 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6980 bidi_cache_idx.
6981
0bb23927
EZ
6982 Support bidi reordering of display and overlay strings.
6983 * xdisp.c (compute_display_string_pos)
6984 (compute_display_string_end): Accept additional argument STRING.
6985 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6986 (reseat_to_string): Initialize bidi_it->string.s and
6987 bidi_it->string.schars.
6988 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6989 NULL (avoids a crash in bidi_paragraph_init).
6990 Initialize itb.string.lstring.
0bb23927
EZ
6991 (init_iterator): Call bidi_init_it only of a valid
6992 buffer position was specified. Initialize paragraph_embedding to
6993 L2R.
6994 (reseat_to_string): Initialize the bidi iterator.
6995 (display_string): If we need to ignore text properties of
6996 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6997 original value of -1 will not work with bidi.)
6998 (compute_display_string_pos): First arg is now struct
6999 `text_pos *'; all callers changed. Support display properties on
7000 Lisp strings.
7001 (compute_display_string_end): Support display properties on Lisp
7002 strings.
7003 (init_iterator, reseat_1, reseat_to_string): Initialize the
7004 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7005 when iterating on a string not from display properties).
640c8776
SM
7006 (compute_display_string_pos, compute_display_string_end):
7007 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7008 arrow keys.
7009 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7010 base_level_stop; instead, set base_level_stop to BEGV.
7011 Fixes crashes in vertical-motion.
0bb23927
EZ
7012 (next_element_from_buffer): Improve commentary for when
7013 the iterator is before prev_stop.
7014 (init_iterator): Initialize bidi_p from the default value of
7015 bidi-display-reordering, not from buffer-local value. Use the
7016 buffer-local value only if initializing for buffer iteration.
7017 (handle_invisible_prop): Support invisible properties on strings
7018 that are being bidi-reordered.
7019 (set_iterator_to_next): Support bidi reordering of C strings and
7020 Lisp strings.
7021 (next_element_from_string): Support bidi reordering of Lisp
7022 strings.
7023 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7024 (display_string): Support display of R2L glyph rows.
7025 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7026 (init_iterator): Don't initialize it->bidi_p for strings
7027 here.
7028 (reseat_to_string): Initialize it->bidi_p for strings here.
7029 (next_element_from_string, next_element_from_c_string)
7030 (next_element_from_buffer): Add xassert's for correspondence
7031 between IT's object being iterated and it->bidi_it.string
7032 structure.
7033 (face_before_or_after_it_pos): Support bidi iteration.
7034 (next_element_from_c_string): Handle the case of the first string
7035 character that is not the first one in the visual order.
7036 (get_visually_first_element): New function, refactored from common
7037 parts of next_element_from_buffer, next_element_from_string, and
7038 next_element_from_c_string.
7039 (tool_bar_lines_needed, redisplay_tool_bar)
7040 (display_menu_bar): Force left-to-right direction. Add a FIXME
7041 comment for making that be controlled by a user option.
7042 (push_it, pop_it): Save and restore the state of the
7043 bidi iterator. Save and restore the bidi_p flag.
7044 (pop_it): Iterate out of display property for string iteration as
7045 well.
7046 (iterate_out_of_display_property): Support iteration over strings.
7047 (handle_single_display_spec): Set up it->bidi_it for iteration
7048 over a display string, and call bidi_init_it.
7049 (handle_single_display_spec, next_overlay_string)
7050 (get_overlay_strings_1, push_display_prop): Set up the bidi
7051 iterator for displaying display or overlay strings.
7052 (forward_to_next_line_start): Don't use the shortcut if
7053 bidi-iterating.
7054 (back_to_previous_visible_line_start): If handle_display_prop
7055 pushed the iterator stack, restore the internal state of the bidi
7056 iterator by calling bidi_pop_it same number of times.
7057 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7058 and we are bidi-iterating, don't decrement the iterator position;
7059 instead, set the first_elt flag in the bidi iterator, to produce
7060 the same effect.
7061 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7062 (push_display_prop): xassert that we are iterating a buffer.
7063 (push_it, pop_it): Save and restore paragraph_embedding member.
7064 (handle_single_display_spec, next_overlay_string)
7065 (get_overlay_strings_1, reseat_1, reseat_to_string)
7066 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7067 correctly. Don't assume unibyte strings are not bidi-reordered.
7068 (compute_display_string_pos)
7069 (compute_display_string_end): Fix handling the case of C string.
7070 (push_it, pop_it): Save and restore from_disp_prop_p.
7071 (handle_single_display_spec, push_display_prop): Set the
7072 from_disp_prop_p flag.
7073 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7074 (pop_it): Call iterate_out_of_display_property only if we are
7075 popping after iteration over a string that came from a display
7076 property. Fix a typo in popping stretch info. Add an assertion
7077 for verifying that the iterator position is in sync with the bidi
7078 iterator.
7079 (handle_single_display_spec, get_overlay_strings_1)
7080 (push_display_prop): Fix initialization of paragraph direction for
7081 string when that of the parent object is not yet determined.
7082 (reseat_1): Call bidi_init_it to resync the bidi
7083 iterator with IT's position. (Bug#7616)
7084 (find_row_edges): If ROW->start.pos gives position
7085 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7086 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7087 Reset the from_disp_prop_p flag.
7088 (SAVE_IT, RESTORE_IT): New macros.
7089 (pos_visible_p, face_before_or_after_it_pos)
7090 (back_to_previous_visible_line_start)
7091 (move_it_in_display_line_to, move_it_in_display_line)
7092 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7093 (try_scrolling, redisplay_window, display_line): Use them when
7094 saving a temporary copy of the iterator and restoring it back.
7095 (back_to_previous_visible_line_start, reseat_1)
7096 (init_iterator): Empty the bidi cache "stack".
7097 (move_it_in_display_line_to): If iterator ended up at
7098 EOL, but we never saw any buffer positions smaller than
7099 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7100 motion in bidi-reordered lines.
7101 (move_it_in_display_line_to): Record prev_method and prev_pos
7102 immediately before the call to set_iterator_to_next. Fixes cursor
7103 motion in bidi-reordered lines with stretch glyphs and strings
7104 displayed in margins. (Bug#8133) (Bug#8867)
7105 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7106 TO_CHARPOS.
640c8776
SM
7107 (pos_visible_p): Support positions in bidi-reordered lines.
7108 Save and restore bidi cache.
0bb23927
EZ
7109
7110 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7111 (bidi_paragraph_info): Delete unused struct.
7112 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7113 (bidi_cache_start): New variable.
7114 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7115 to zero.
7116 (bidi_cache_fetch_state, bidi_cache_search)
7117 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7118 (bidi_cache_find, bidi_peek_at_next_level)
7119 (bidi_level_of_next_char, bidi_find_other_level_edge)
7120 (bidi_move_to_visually_next): Compare cache index with
7121 bidi_cache_start rather than with zero.
7122 (bidi_fetch_char): Accept new argument STRING; all callers
7123 changed. Support iteration over a string. Support strings with
7124 display properties. Support unibyte strings. Fix the type of
7125 `len' according to what STRING_CHAR_AND_LENGTH expects.
7126 (bidi_paragraph_init, bidi_resolve_explicit_1)
7127 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7128 (bidi_level_of_next_char, bidi_move_to_visually_next):
7129 Support iteration over a string.
0bb23927
EZ
7130 (bidi_set_sor_type, bidi_resolve_explicit_1)
7131 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7132 can now be zero (for strings); special values 0 and -1 were
7133 changed to -1 and -2, respectively.
7134 (bidi_char_at_pos): New function.
7135 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7136 Call it instead of FETCH_MULTIBYTE_CHAR.
7137 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7138 initialized to valid values.
7139 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7140 values.
7141 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7142 the test for valid cached positions. Fix the logic for looking up
7143 the sentinel state in the cache. GCPRO the Lisp string we are
7144 iterating.
7145 (bidi_push_it, bidi_pop_it): New functions.
7146 (bidi_initialize): Initialize the bidi cache start stack pointer.
7147 (bidi_cache_ensure_space): New function, refactored from part of
7148 bidi_cache_iterator_state. Don't assume the required size is just
7149 one BIDI_CACHE_CHUNK away.
7150 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7151 (bidi_count_bytes, bidi_char_at_pos): New functions.
7152 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7153 always valid if bidi_cache_idx is valid.
7154 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7155 is valid if it's going to be used.
7156 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7157 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7158 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7159 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7160 (bidi_find_other_level_edge, bidi_cache_start_stack):
7161 All variables related to cache indices are now EMACS_INT.
c965adc5 7162
0bb23927
EZ
7163 * dispextern.h (struct bidi_string_data): New structure.
7164 (struct bidi_it): New member `string'. Make flag members be 1-bit
7165 fields, and put them last in the struct.
640c8776
SM
7166 (compute_display_string_pos, compute_display_string_end):
7167 Update prototypes.
0bb23927
EZ
7168 (bidi_push_it, bidi_pop_it): Add prototypes.
7169 (struct iterator_stack_entry): New members bidi_p,
7170 paragraph_embedding, and from_disp_prop_p.
7171 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7172 (bidi_shelve_cache, bidi_unshelve_cache):
7173 Declare prototypes.
0bb23927
EZ
7174
7175 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7176 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7177 and vector-like objects.
7178
7179 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7180 cache around display iteration.
7181
7182 * window.c (Fwindow_end, window_scroll_pixel_based)
7183 (displayed_window_lines, Frecenter): Save and restore the bidi
7184 cache around display iteration.
7185
3bbd2265
LMI
71862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7187
7188 * editfns.c (Fdelete_region): Clarify the use of the named
7189 parameters (bug#6788).
7190
adc47434
MR
71912011-07-14 Martin Rudalics <rudalics@gmx.at>
7192
7193 * indent.c (Fvertical_motion): Set and restore w->pointm when
7194 saving and restoring the window's buffer (Bug#9006).
7195
837c31f8
LMI
71962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7197
7198 * editfns.c (Fstring_to_char): Clarify just what is returned
7199 (bug#6576). Text by Eli Zaretskii.
7200
ac389d0c
JB
72012011-07-13 Juanma Barranquero <lekktu@gmail.com>
7202
7203 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7204
0be0ce47
EZ
72052011-07-13 Eli Zaretskii <eliz@gnu.org>
7206
7207 * buffer.c (mmap_find): Fix a typo.
7208
cd18e7e3
JB
72092011-07-13 Johan Bockgård <bojohan@gnu.org>
7210
7211 Fix execution of x selection hooks.
7212 * xselect.c (Qx_lost_selection_functions)
7213 (Qx_sent_selection_functions): New vars.
7214 (syms_of_xselect): DEFSYM them.
7215 (x_handle_selection_request): Pass Qx_sent_selection_functions
7216 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7217 (x_handle_selection_clear,x_clear_frame_selections):
7218 Pass Qx_lost_selection_functions rather than
7219 Vx_lost_selection_functions to Frun_hook_with_args.
7220
47ea7f44
PE
72212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7222
ac389d0c 7223 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7224 The old code sometimes used this field without initializing it.
7225
47ea7f44
PE
7226 * alloc.c (gc_sweep): Don't read past end of array.
7227 In theory, the old code could also have corrupted Emacs internals,
7228 though it'd be very unlikely.
7229
bc985c87
AS
72302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7231
7232 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7233 argument. (Bug#4026)
bc985c87 7234
0cf34688
LMI
72352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7236
b3dadd76
LMI
7237 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7238 key" (bug#4257).
7239
0cf34688
LMI
7240 * window.c (Fset_window_start): Doc fix (bug#4199).
7241 (Fset_window_hscroll): Ditto.
7242
270768cd
PE
72432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7244
077e3dda 7245 Fix minor new problems caught by GCC 4.6.1.
270768cd 7246 * term.c (init_tty): Remove unused local.
490011a6 7247 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7248 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7249 not used otherwise.
270768cd 7250
b1f58454
CY
72512011-07-12 Chong Yidong <cyd@stupidchicken.com>
7252
7253 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7254
22b9578d
LMI
72552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7256
6e70ab07
LMI
7257 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7258 are the mini-buffer and the echo area (bug#3320).
7259
22b9578d
LMI
7260 * term.c (init_tty): Remove support for supdup, c10 and perq
7261 terminals, which are no longer supported (bug#1482).
7262
8974cc9f
JB
72632011-07-10 Johan Bockgård <bojohan@gnu.org>
7264
7265 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7266
a560d974
JD
72672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7268
7269 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7270 for non-popups (Bug#3642).
7271
1dae0f0a
AS
72722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7273
268c2c36 7274 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7275 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7276 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7277 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7278 * data.c (fmod): Likewise.
7279 * dispnew.c (swap_glyphs_in_rows): Likewise.
7280 * emacs.c (memory_warning_signal): Likewise.
7281 * floatfns.c (float_error): Likewise.
7282 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7283 (otf_open, font_otf_capability, generate_otf_features)
7284 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7285 Likewise.
7286 * image.c (pbm_read_file): Likewise.
7287 * indent.c (string_display_width): Likewise.
7288 * intervals.c (check_for_interval, search_for_interval)
7289 (inc_interval_count, count_intervals, root_interval)
7290 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7291 * lread.c (defalias): Likewise.
268c2c36 7292 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7293 * regex.c (set_image_of_range_1, set_image_of_range)
7294 (regex_grow_registers): Likewise.
7295 * sysdep.c (strerror): Likewise.
7296 * termcap.c (valid_filename_p, tprint, main): Likewise.
7297 * tparam.c (main): Likewise.
7298 * unexhp9k800.c (run_time_remap, save_data_space)
7299 (update_file_ptrs, read_header, write_header, calculate_checksum)
7300 (copy_file, copy_rest, display_header): Likewise.
7301 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7302 Likewise.
7303 * xdisp.c (check_it): Likewise.
7304 * xfaces.c (register_color, unregister_color, unregister_colors):
7305 Likewise.
7306 * xfns.c (print_fontset_result): Likewise.
7307 * xrdb.c (member, fatal, main): Likewise.
7308
99033785
PE
73092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7310
7311 Fix minor problems found by static checking (Bug#9031).
7312 * chartab.c (char_table_set_range, map_sub_char_table):
7313 Remove unused locals.
7314 (uniprop_table): Now static.
7315 * composite.c (_work_char): Remove unused static var.
7316
9cb2ac56
JB
73172011-07-09 Juanma Barranquero <lekktu@gmail.com>
7318
7319 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7320
f25661f0
JD
73212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7322
7323 * gtkutil.c (qttip_cb): Remove code without function.
7324
8278c4fe
EZ
73252011-07-09 Eli Zaretskii <eliz@gnu.org>
7326
7327 * w32.c (pthread_sigmask): New stub.
7328
1692ae2d 73292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7330
8a6ebd58 7331 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7332 sigprocmask is portable only for single-threaded applications, and
7333 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7334 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7335 (LIBES): Use it.
7336 * callproc.c (Fcall_process):
7337 * process.c (create_process):
7338 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7339 Use pthread_sigmask, not sigprocmask.
123403e4 7340
1b854618
JD
73412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7342
7343 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7344 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7345 wrong (Bug#8591).
7346
3fe4b549
JD
73472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7348
0ce7e563
JD
7349 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7350 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7351 (xg_hide_tooltip): Fix comment.
7352
3fe4b549
JD
7353 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7354 in registerServicesMenuSendTypes.
7355 (validRequestorForSendType): Don't check ns_return_types.
7356
7357 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7358 ns_return_type.
7359
5df75e47
JR
73602011-07-08 Jason Rumney <jasonr@gnu.org>
7361
22610910
JR
7362 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7363 SH_SHOW for hidden windows (Bug#5482).
7364
5df75e47
JR
7365 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7366 frame struct members of non-existent frames (Bug#6284).
7367
699c10bd
JD
73682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7369
4393663b
JD
7370 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7371 variable firstTime not needed on OSX >= 10.6.
7372 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7373 >= 10.5. Use setKnobProportion, setDoubleValue.
7374
7375 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7376 (MAC_OS_X_VERSION_10_5): Define if not defined.
7377 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7378 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7379 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7380
7381 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7382 cString and lossyCString on OSX >= 10.4
7383
58179cce 7384 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7385 sizeToFit on OSX >= 10.2.
7386
7387 * nsimage.m (allocInitFromFile): Don't use deprecated method
7388 bestRepresentationForDevice on OSX >= 10.6.
7389
7390 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7391 to avoid warning.
7392
7393 * emacs.c: Declare unexec_init_emacs_zone.
7394
a63e0781
JD
7395 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7396
699c10bd
JD
7397 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7398
7399 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7400 on svcsMenu (Bug#8842).
7401
7402 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7403 ns_return_types.
7404 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7405
7406 * nsterm.m (QUTF8_STRING): Declare.
7407 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7408 (validRequestorForSendType): Return type is (id).
7409 Change indexOfObjectIdenticalTo to indexOfObject.
7410 Check if we have local selection before returning self (Bug#8842).
7411 (writeSelectionToPasteboard): Put local selection into paste board
7412 if we have a local selection (Bug#8842).
7413 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7414
7415 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7416 (ns_get_local_selection): Declare.
7417
54e10184
LMI
74182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7419
9888ff71
LMI
7420 * keymap.c (describe_map_tree): Don't insert a double newline at
7421 the end of the buffer (bug#1169) and return whether we inserted
7422 something.
7423
54e10184
LMI
7424 * callint.c (Fcall_interactively): Change "reading args" to
7425 "providing args" to try to clarify what it does (bug#1010).
7426
15fa4783
KH
74272011-07-07 Kenichi Handa <handa@m17n.org>
7428
7429 * composite.c (composition_compute_stop_pos): Ignore a static
7430 composition starting before CHARPOS (Bug#8915).
7431
7432 * xdisp.c (handle_composition_prop): Likewise.
7433
a8815b00
EZ
74342011-07-07 Eli Zaretskii <eliz@gnu.org>
7435
7436 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7437 (Bug#9015)
7438
ef7b981d 74392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7440
7441 * character.h (unicode_category_t): New enum type.
7442
7443 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7444 (Qchar_code_property_table): New variable.
7445 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7446 (UNIPROP_COMPRESSED_FORM_P): New macros.
7447 (char_table_ascii): Uncompress the compressed values.
7448 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7449 Uncompress the compressed values.
ac389d0c 7450 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7451 (char_table_ref_and_range): Uncompress the compressed values.
7452 (sub_char_table_set): New arg is_uniprop. Callers changed.
7453 Uncompress the compressed values.
7454 (sub_char_table_set_range): Args changed. Callers changed.
7455 (char_table_set_range): Adjuted for the above change.
7456 (map_sub_char_table): Delete args default_val and parent. Add arg
7457 top. Give decoded values to a Lisp function.
640c8776 7458 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7459 values to a Lisp function. Gcpro more variables.
7460 (uniprop_table_uncompress)
7461 (uniprop_decode_value_run_length): New functions.
7462 (uniprop_decoder, uniprop_decoder_count): New variables.
7463 (uniprop_get_decoder, uniprop_encode_value_character)
7464 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7465 New functions.
7466 (uniprop_encoder, uniprop_encoder_count): New variables.
7467 (uniprop_get_encoder, uniprop_table)
7468 (Funicode_property_table_internal, Fget_unicode_property_internal)
7469 (Fput_unicode_property_internal): New functions.
7470 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7471 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7472 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7473 char-code-property-alist.
7474
640c8776 7475 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7476 Vunicode_category_table.
7477
640c8776 7478 * font.c (font_range): Adjust for the change of
c805dec0
KH
7479 Vunicode_category_table.
7480
76b397fb
DN
74812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7482
7483 * m/iris4d.h: Remove file, move contents ...
7484 * s/irix6-5.h: ... here.
7485
22b4128e
PE
74862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7487
7488 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7489 * alloc.c (mark_buffer):
7490 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7491 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7492 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7493 This isn't true in general, and it's particularly not true
7494 if Emacs is configured with --with-wide-int.
7495 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7496 New macros, used in the buffer.c change.
7497
869795d6
JD
74982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7499
7500 * xsettings.c: Use both GConf and GSettings if both are available.
7501 (store_config_changed_event): Add comment.
7502 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7503 (store_tool_bar_style_changed): New functions.
5e617bc2 7504 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7505 (struct xsettings): Move font inside HAVE_XFT.
7506 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7507 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7508 Move inside HAVE_XFT.
640c8776 7509 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7510 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7511 also.
7512 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7513 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7514 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7515 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7516 (parse_settings): Move check for font inside HAVE_XFT.
7517 (read_settings, apply_xft_settings): Add comment.
7518 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7519 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7520 call store_font_name_changed.
7521 (xft_settings_event): Add comment.
7522 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7523 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7524 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7525 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7526 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7527 (xsettings_get_system_font, xsettings_get_system_normal_font):
7528 Add comment.
869795d6 7529
d8ed26bd
PE
75302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7531
7532 Random fixes. E.g., (random) never returned negative values.
7533 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7534 subseconds part to the entropy, as that's a bit more random.
7535 Prefer signed to unsigned, since the signedness doesn't matter and
7536 in general we prefer signed. When given a limit, use a
7537 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7538 latter isn't right if USE_2_TAGS_FOR_INTS.
7539 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7540 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7541
cabf1cac
SM
75422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7543
7544 * textprop.c (text_property_stickiness):
7545 Obey Vtext_property_default_nonsticky.
7546 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7547 * w32fns.c (syms_of_w32fns):
7548 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7549
6e9b2be9
PE
75502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7551
7552 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7553 This is more efficient than Ffile_directory_p and avoids a minor race.
7554
90186c68
LMI
75552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7556
7c301272
LMI
7557 * buffer.c (Foverlay_put): Say what the return value is
7558 (bug#7835).
7559
c4f2d8d4
LMI
7560 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7561 is a directory before asking whether to use the file name
7562 (bug#7564).
ad637907
LMI
7563 (barf_or_query_if_file_exists): Make the "File is a directory"
7564 error be more correct.
c4f2d8d4 7565
90186c68
LMI
7566 * fns.c (Frequire): Remove the mention of the .gz files, since
7567 that's installation-specific, but keep the mention of
7568 `get-load-suffixes'.
7569
da64016e
PE
75702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7571
7572 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7573 Report string overflow if the output is too long.
7574
7d47b580
JB
75752011-07-04 Juanma Barranquero <lekktu@gmail.com>
7576
a555cb87
JB
7577 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7578 (syms_of_gnutls): Remove duplicate DEFSYM for
7579 Qgnutls_bootprop_verify_hostname_error, an error for
7580 Qgnutls_bootprop_verify_error (which is no longer used).
7581
7d47b580
JB
7582 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7583 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7584 Also (re)move comments that are misplaced or no longer relevant.
7585
1e49bfab
LMI
75862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7587
7588 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7589
1485f4c0
CY
75902011-07-03 Chong Yidong <cyd@stupidchicken.com>
7591
7592 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7593 and background color parameters if they have been changed.
7594
a9ab721e
LMI
75952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7596
7597 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7598
cf7cff57
PE
75992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7600
2e13213d
PE
7601 * xsettings.c (SYSTEM_FONT): Define only when used.
7602 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7603
cf7cff57
PE
7604 * keymap.c (access_keymap_1): Now static.
7605
7a8e04f7
CY
76062011-07-02 Chong Yidong <cyd@stupidchicken.com>
7607
7608 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7609 leave any prefix arg for the up event (Bug#1586).
7610
61352f62
LMI
76112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7612
69bb1ef7
LMI
7613 * lread.c (syms_of_lread): Mention single symbols defined by
7614 `defvar' or `defconst' (bug#7154).
7615
61352f62 7616 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7617 (Frequire): Mention get-load-suffixes.
61352f62 7618
28545e04
MR
76192011-07-02 Martin Rudalics <rudalics@gmx.at>
7620
7621 * window.h (window): Remove clone_number slot.
7622 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7623 Remove.
7624 (make_parent_window, make_window, saved_window)
7625 (Fset_window_configuration, save_window_save): Don't deal with
7626 clone numbers.
7627 * buffer.c (Qclone_number): Remove declaration.
7628 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7629
3349e122
SM
76302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7631
7632 Add multiple inheritance to keymaps.
7633 * keymap.c (Fmake_composed_keymap): New function.
7634 (Fset_keymap_parent): Simplify.
7635 (fix_submap_inheritance): Remove.
7636 (access_keymap_1): New function extracted from access_keymap to handle
7637 embedded parents and handle lists of maps.
7638 (access_keymap): Use it.
7639 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7640 (Fcopy_keymap): Handle embedded parents.
7641 (Fcommand_remapping, define_as_prefix): Simplify.
7642 (Fkey_binding): Simplify.
7643 (syms_of_keymap): Move minibuffer-local-completion-map,
7644 minibuffer-local-filename-completion-map,
7645 minibuffer-local-must-match-map, and
7646 minibuffer-local-filename-must-match-map to Elisp.
7647 (syms_of_keymap): Defsubr make-composed-keymap.
7648 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7649 (parse_menu_item): Trivial simplification.
7650
3279eb87
GM
76512011-07-01 Glenn Morris <rgm@gnu.org>
7652
7653 * Makefile.in (SETTINGS_LIBS): Fix typo.
7654
4550efdf
KI
76552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7656
7657 * coding.c (Fencode_coding_string): Record the last coding system
7658 used, as the function doc string says (bug#8738).
7659
0949d2b6
JD
76602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7661
7662 * xsettings.c (store_monospaced_changed): Take new font as arg and
7663 check for change against current_mono_font.
7664 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7665 (emacs_settings_constructor, emacs_settings_get_property)
7666 (emacs_settings_set_property, emacs_settings_class_init)
7667 (emacs_settings_init, gsettings_obj): Remove.
7668 (something_changedCB): New function for HAVE_GSETTINGS.
7669 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7670 with value as argument.
7671 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7672 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7673 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7674 "changed".
7675
7676 * xgselect.c: Add defined (HAVE_GSETTINGS).
7677 (xgselect_initialize): Ditto.
7678
7679 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7680 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7681 xg_select.
7682
bbc6b304
PE
76832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7684
7685 * eval.c (struct backtrace): Simplify and port the data structure.
7686 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7687 signed bit field, as this assumption is not portable and it makes
7688 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7689 "char debug_on_exit : 1" as this is not portable either; instead,
7690 use the portable "unsigned int debug_on_exit : 1". Remove unused
7691 member evalargs. Remove obsolete comments about cc bombing out.
7692
9851bfc5
JD
76932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7694
51bb811f 7695 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7696 Let HAVE_GSETTINGS override HAVE_GCONF.
7697 (store_monospaced_changed): New function.
7698 (EMACS_SETTINGS): A new type derived from GObject to handle
7699 GSettings notifications.
7700 (emacs_settings_constructor, emacs_settings_get_property)
7701 (emacs_settings_set_property, emacs_settings_class_init):
7702 New functions.
7703 (gsettings_client, gsettings_obj): New variables.
7704 (GSETTINGS_SCHEMA): New define.
7705 (something_changedCB): Call store_monospaced_changed.
7706 (init_gsettings): New function.
7707 (xsettings_initialize): Call init_gsettings.
7708 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7709 to NULL.
7710
640c8776 7711 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7712 GCONF_CFLAGS/LIBS.
7713
5386012d
MR
77142011-06-29 Martin Rudalics <rudalics@gmx.at>
7715
7716 * window.c (resize_root_window, grow_mini_window)
7717 (shrink_mini_window): Rename Qresize_root_window to
7718 Qwindow_resize_root_window and Qresize_root_window_vertically to
7719 Qwindow_resize_root_window_vertically.
7720
f13e0b08
PE
77212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7722
7723 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7724
94515237
JB
77252011-06-27 Juanma Barranquero <lekktu@gmail.com>
7726
7727 * makefile.w32-in: Redesign dependencies so they reflect more
7728 clearly which files are directly included by each source file,
7729 and not through other includes.
7730
e43b6e43
MR
77312011-06-27 Martin Rudalics <rudalics@gmx.at>
7732
7733 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7734 (sort_overlays, overlay_strings): When an overlay's clone number
7735 matches the window's clone number process the overlay even if
7736 the overlay's window property doesn't match the current window.
7737
d68443dc
MR
7738 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7739 (Fwindow_hchild): Rename to Fwindow_left_child.
7740 (Fwindow_next): Rename to Fwindow_next_sibling.
7741 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7742 (resize_window_check): Rename to window_resize_check.
7743 (resize_window_apply): Rename to window_resize_apply.
7744 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7745 (Fdelete_other_windows_internal, resize_frame_windows)
7746 (Fsplit_window_internal, Fdelete_window_internal)
7747 (grow_mini_window, shrink_mini_window)
7748 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7749
c7e73be5
JD
77502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7751
7752 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7753 (emacs_fixed_set_min_size): Remove.
7754 (emacs_fixed_new): Take frame as argument.
7755
7756 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7757 (_EmacsFixedPrivate): Remove minwidth/height.
7758 Add struct frame *f.
7759 (emacs_fixed_init): Initialize priv->f.
7760 (get_parent_class, emacs_fixed_set_min_size): Remove.
7761 (emacs_fixed_new): Set priv->f to argument.
7762 (emacs_fixed_get_preferred_width)
7763 (emacs_fixed_get_preferred_height): Use min_width/height from
7764 frames size_hint to set minimum and natural (Bug#8919).
7765 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7766 and use min_width/height from frames size_hint to set
7767 min_width/height (Bug#8919).
7768
7769 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7770 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7771 Fix indentation.
c7e73be5 7772
cf99dcf8
EZ
77732011-06-26 Eli Zaretskii <eliz@gnu.org>
7774
7775 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7776 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7777 called at ZV.
7778
029529ac
CY
77792011-06-26 Chong Yidong <cyd@stupidchicken.com>
7780
7781 * process.c (wait_reading_process_output): Bypass select if
7782 waiting for a cell while ignoring keyboard input, and input is
7783 pending. Suggested by Jan Djärv (Bug#8869).
7784
7a7ef429
PE
77852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7786
7787 Use gnulib's dup2 module instead of rolling our own.
7788 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7789
11fdef7d 77902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7791
7792 * dispnew.c (scrolling_window): Before scrolling, turn off a
7793 mouse-highlight in the window being scrolled.
7794
cd3520a4
JB
77952011-06-24 Juanma Barranquero <lekktu@gmail.com>
7796
7797 Move DEFSYM to lisp.h and use everywhere.
7798
7799 * character.h (DEFSYM): Move declaration...
7800 * lisp.h (DEFSYM): ...here.
7801
7802 * gnutls.c:
7803 * minibuf.c:
7804 * w32menu.c:
7805 * w32proc.c:
7806 * w32select.c: Don't include character.h.
7807
7808 * alloc.c (syms_of_alloc):
7809 * buffer.c (syms_of_buffer):
7810 * bytecode.c (syms_of_bytecode):
7811 * callint.c (syms_of_callint):
7812 * casefiddle.c (syms_of_casefiddle):
7813 * casetab.c (init_casetab_once):
7814 * category.c (init_category_once, syms_of_category):
7815 * ccl.c (syms_of_ccl):
7816 * cmds.c (syms_of_cmds):
7817 * composite.c (syms_of_composite):
7818 * dbusbind.c (syms_of_dbusbind):
7819 * dired.c (syms_of_dired):
7820 * dispnew.c (syms_of_display):
7821 * doc.c (syms_of_doc):
7822 * editfns.c (syms_of_editfns):
7823 * emacs.c (syms_of_emacs):
7824 * eval.c (syms_of_eval):
7825 * fileio.c (syms_of_fileio):
7826 * fns.c (syms_of_fns):
7827 * frame.c (syms_of_frame):
7828 * fringe.c (syms_of_fringe):
7829 * insdel.c (syms_of_insdel):
7830 * keymap.c (syms_of_keymap):
7831 * lread.c (init_obarray, syms_of_lread):
7832 * macros.c (syms_of_macros):
7833 * msdos.c (syms_of_msdos):
7834 * print.c (syms_of_print):
7835 * process.c (syms_of_process):
7836 * search.c (syms_of_search):
7837 * sound.c (syms_of_sound):
7838 * syntax.c (init_syntax_once, syms_of_syntax):
7839 * terminal.c (syms_of_terminal):
7840 * textprop.c (syms_of_textprop):
7841 * undo.c (syms_of_undo):
7842 * w32.c (globals_of_w32):
7843 * window.c (syms_of_window):
7844 * xdisp.c (syms_of_xdisp):
7845 * xfaces.c (syms_of_xfaces):
7846 * xfns.c (syms_of_xfns):
7847 * xmenu.c (syms_of_xmenu):
7848 * xsettings.c (syms_of_xsettings):
7849 * xterm.c (syms_of_xterm): Use DEFSYM.
7850
4228cf16
TZ
78512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7852
cd3520a4 7853 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7854
7fcccf1e
PE
78552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7856
7efb4e0e
PE
7857 Integer and buffer overflow fixes (Bug#8873).
7858
ff5844ad
PE
7859 * print.c (printchar, strout): Check for string overflow.
7860 (PRINTPREPARE, printchar, strout):
7861 Don't set size unless allocation succeeds.
7862
90532f02
PE
7863 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7864 for sizes. Check for string overflow more accurately.
7865 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7866
6d84508d
PE
7867 * macros.c: Integer and buffer overflow fixes.
7868 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7869 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7870 Use ptrdiff_t, not int, for sizes.
7871 Don't increment bufsize until after realloc succeeds.
7872 Check for size-calculation overflow.
7873 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7874
437b2cb4
PE
7875 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7876
8b9ac8b4
PE
7877 * lread.c: Integer overflow fixes.
7878 (read_integer): Radix is now EMACS_INT, not int,
7879 to improve quality of diagnostics for out-of-range radices.
7880 Calculate buffer size correctly for out-of-range radices.
7881 (read1): Check for integer overflow in radices, and in
7882 read-circle numbers.
82cb60d3
PE
7883 (read_escape): Avoid int overflow.
7884 (Fload, openp, read_buffer_size, read1)
7885 (substitute_object_recurse, read_vector, read_list, map_obarray):
7886 Use ptrdiff_t, not int, for sizes.
7887 (read1): Use EMACS_INT, not int, for sizes.
20270765 7888 Check for size overflow.
8b9ac8b4 7889
7fcccf1e
PE
7890 * image.c (cache_image): Check for size arithmetic overflow.
7891
bfbbd7e7
PE
7892 * lread.c: Integer overflow issues.
7893 (saved_doc_string_size, saved_doc_string_length)
7894 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7895 Now ptrdiff_t, not int.
7896 (read1): Don't assume doc string length fits in int. Check for
7897 out-of-range doc string lengths.
7898 (read_list): Don't assume file position fits in int.
39019e54 7899 (read_escape): Check for hex character overflow.
bfbbd7e7 7900
4e323265
LL
79012011-06-22 Leo Liu <sdl.web@gmail.com>
7902
7903 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7904 Move to minibuffer.el.
7905
85fece3e
PE
79062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7907
20b84ce9 7908 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7909 The following patches are for when GLYPH_DEBUG && !XASSERT.
7910 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7911 * dispnew.c (flush_stdout):
7912 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7913 Mark as externally visible.
7914 * dispnew.c (check_window_matrix_pointers): Now static.
7915 * dispnew.c (window_to_frame_vpos):
7916 * xfns.c (unwind_create_frame):
7917 * xterm.c (x_check_font): Remove unused local.
7918 * scroll.c (CHECK_BOUNDS):
7919 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7920 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7921 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7922 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7923 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7924 Now static.
7925 (debug_method_add): Use va_list and vsprintf rather than relying
7926 on undefined behavior with wrong number of arguments.
7927 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7928 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7929 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7930 since we're not interested in debugging glyphs with old libraries.
7931 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7932 GCC 4.6.0's static checking.
7933
0766b489
PE
79342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7935
31fd4b32
PE
7936 Integer overflow and signedness fixes (Bug#8873).
7937 A few related buffer overrun fixes, too.
7938
b79e8648
PE
7939 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7940
0766b489
PE
7941 * dispextern.h (struct face.stipple):
7942 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7943 (x_bitmap_mask, x_allocate_bitmap_record)
7944 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7945 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7946 (x_create_bitmap_from_xpm_data):
7947 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7948 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7949 (.bitmaps_last):
7950 * xfaces.c (load_pixmap):
7951 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7952 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7953 (.bitmaps_last, struct x_output.icon_bitmap):
7954 Use ptrdiff_t, not int, for bitmap indexes.
7955 (x_allocate_bitmap_record): Check for size overflow.
7956 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7957
b081724f
PE
7958 Use ptrdiff_t, not int, for overlay counts.
7959 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7960 * editfns.c (overlays_around, get_pos_property):
7961 * textprop.c (get_char_property_and_overlay):
7962 * xdisp.c (next_overlay_change, note_mouse_highlight):
7963 * xfaces.c (face_at_buffer_position):
21514da7
PE
7964 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7965 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7966 (Fnext_overlay_change, Fprevious_overlay_change)
7967 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7968 Use ptrdiff_t, not int, for sizes.
21514da7 7969 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7970
3de73e5e
PE
7971 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7972
2606c57b
PE
7973 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7974 (x_session_initialize): Do not assume string length fits in int.
7975
aaafe47a
PE
7976 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7977 This is unlikely, but can occur if DPI is outlandish.
7978
2674ddc8 7979 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7980 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7981
28154962
PE
7982 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7983 * xrdb.c (magic_file_p, search_magic_path):
7984 Omit last arg SUFFIX; it was always 0. All callers changed.
7985 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7986
7de51af5
PE
7987 * xfont.c (xfont_match): Avoid need for strlen.
7988
25ed6cc3
PE
7989 * xfns.c: Don't assume strlen fits in int.
7990 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7991
4eab31dd
PE
7992 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7993 not unsigned long, as we prefer signed integers. All callers changed.
7994 Detect integer overflow in repeat count.
7995 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7996 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7997
171e2a58
PE
7998 * termcap.c: Don't assume sizes fit in int and never overflow.
7999 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8000 (gobble_line): Check for size-calculation overflow.
8001
ad39faca 8002 * minibuf.c (Fread_buffer):
6e5bb2dc 8003 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8004 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8005 Don't assume string length fits in int.
8006
52c61c22 8007 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8008 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8009
b5b8c9e5
PE
8010 * font.c: Don't assume string length fits in int.
8011 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8012 Use ptrdiff_t, not int.
ccd6111c
PE
8013 (font_intern_prop): Don't assume string length fits in int.
8014 Don't assume integer property fits in fixnum.
8015 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8016
882f0d81 8017 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8018 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8019 Reformulate so as not to need the command string.
8020 Invoke gzip -cd rather than gunzip, as it's more portable.
8021 (lock_info_type, lock_file_1, lock_file):
8022 Don't assume pid_t and time_t fit in unsigned long.
8023 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8024 (current_lock_owner): Prefer signed type for sizes.
8025 Use memcpy, not strncpy, where memcpy is what is really wanted.
8026 Don't assume (via atoi) that time_t and pid_t fit in int.
8027 Check for time_t and/or pid_t out of range, e.g., via a network share.
8028 Don't alloca where an auto var works fine.
8029
93f4cf88
PE
8030 * fileio.c: Fix some integer overflow issues.
8031 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8032 Don't assume string length fits in int.
8033 (directory_file_name): Don't assume string length fits in long.
8034 (make_temp_name): Don't assume pid fits in int, or that its print
8035 length is less than 20.
8036
f3e92b69
PE
8037 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8038
1bfdaf10
PE
8039 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8040
35016e9a
PE
8041 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8042
3d1e65a1
PE
8043 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8044 We prefer signed integers, even for size calculations.
8045
0b963a93
PE
8046 * emacs.c: Don't assume string length fits in 'int'.
8047 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8048 (main): Don't invoke strlen when not needed.
8049
573f4b54
PE
8050 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8051 (XD_DEBUG_MESSAGE): Don't waste a byte.
8052
989f33ba
PE
8053 * callproc.c (getenv_internal_1, getenv_internal)
8054 (Fgetenv_internal):
965d34eb
PE
8055 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8056
e4d29b33
PE
8057 * lread.c (invalid_syntax): Omit length argument.
8058 All uses changed. This doesn't fix a bug, but it simplifies the
8059 code away from its former Hollerith-constant appearance, and it's
8060 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8061 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8062
eb49b136
PE
8063 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8064 This didn't break anything, but it didn't help either.
8065 It's confusing to put a bogus integer in a place where the actual
8066 value does not matter.
9f62aeb1 8067 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8068 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8069
15375a22
PE
8070 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8071 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8072 implementation.
b61cc01c
PE
8073 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8074 We prefer signed types, and the value cannot exceed the EMACS_INT
8075 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8076 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8077 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8078 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8079
53b2623d
PE
8080 * indent.c (sane_tab_width): New function.
8081 (current_column, scan_for_column, Findent_to, position_indentation)
8082 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8083 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8084
51cab52b 8085 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8086
f2ed8a70
PE
8087 * lisp.h (lint_assume): New macro.
8088 * composite.c (composition_gstring_put_cache):
8089 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8090
abe80cc6
PE
8091 * editfns.c, insdel.c:
8092 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8093
b02c740e
PE
8094 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8095
ebc96716
PE
8096 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8097
b4e50fa0 8098 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8099 Use much-faster test for byte-length change.
311d5d7c 8100 Don't assume string byte-length fits in 'int'.
a4cf38e4 8101 Check that character arg fits in 'int'.
85461888 8102 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8103
c0c1ee9f
PE
8104 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8105
a498d7f4
PE
8106 * fns.c (concat): Catch string overflow earlier.
8107 Do not rely on integer wraparound.
8108
51cab52b
PE
8109 * dispextern.h (struct it.overlay_strings_charpos)
8110 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8111 * xdisp.c (forward_to_next_line_start)
8112 (back_to_previous_visible_line_start)
8113 (reseat_at_next_visible_line_start, next_element_from_buffer):
8114 Don't arbitrarily truncate the value of 'selective' to int.
8115
76031fad
PE
8116 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8117
5eb55db9
PE
8118 * composite.c: Don't truncate sizes to 'int'.
8119 (composition_gstring_p, composition_reseat_it)
8120 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8121 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8122 not EMACS_UINT, for indexes.
5eb55db9 8123
0703a717
PE
8124 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8125
d6202519
PE
8126 * buffer.c: Include <verify.h>.
8127 (struct sortvec.priority, struct sortstr.priority):
8961a454 8128 Now EMACS_INT, not int.
c20998a7 8129 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8130 (struct sortstr.size, record_overlay_string)
8131 (struct sortstrlist.size, struct sortlist.used):
8132 Don't truncate size to int.
8133 (record_overlay_string): Check for size-calculation overflow.
d6202519 8134 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8135
d5a19415
JM
81362011-06-22 Jim Meyering <meyering@redhat.com>
8137
029529ac 8138 Don't leak an XBM-image-sized buffer
d5a19415
JM
8139 * image.c (xbm_load): Free the image buffer after using it.
8140
a9041e6c
PE
81412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8142
8143 Port to Sun C.
8144 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8145 that Sun C diagnosed.
8146 * fns.c (secure_hash): Fix pointer signedness issue.
8147 * intervals.c (static_offset_intervals): New function.
8148 (offset_intervals): Use it.
8149
7f3f739f
LL
81502011-06-21 Leo Liu <sdl.web@gmail.com>
8151
8152 * deps.mk (fns.o):
8153 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8154 sha512.h.
8155
8156 * fns.c (secure_hash): Rename from crypto_hash_function and change
8157 the first arg to accept symbols.
5b66d427 8158 (Fsecure_hash): New primitive.
7f3f739f
LL
8159 (syms_of_fns): New symbols.
8160
76147d94
DD
81612011-06-20 Deniz Dogan <deniz@dogan.se>
8162
8163 * process.c (Fset_process_buffer): Clarify return value in
8164 docstring.
8165
7d7d0045
CY
81662011-06-18 Chong Yidong <cyd@stupidchicken.com>
8167
8168 * dispnew.c (add_window_display_history): Use BVAR.
8169
8170 * xdisp.c (debug_method_add): Use BVAR.
8171 (check_window_end, dump_glyph_matrix, dump_glyph)
8172 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8173
8174 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8175 Likewise.
8176
8177 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8178 check till after the cache is created in init_frame_faces.
8179
ff2bc410
SM
81802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8181
8182 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8183
28177add
PE
81842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8185
dd3482fe
PE
8186 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8187 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8188 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8189
393d71f3 8190 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8191 * fileio.c (Finsert_file_contents):
8192 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8193 Remove the old (too-loose) buffer overflow checks.
8194 They weren't needed, since make_gap checks for buffer overflow.
8195 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8196 The old code merely checked for Emacs fixnum overflow, and relied
8197 on undefined (wraparound) behavior. The new code avoids undefined
8198 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8199
2e6813b0 8200 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8201 Tune. Don't use wider integers than needed. Don't use alloca.
8202 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8203
599a9e4f
PE
8204 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8205
99561444
PE
8206 * insdel.c, lisp.h (buffer_overflow): New function.
8207 (insert_from_buffer_1, replace_range, replace_range_2):
8208 * insdel.c (make_gap_larger):
8209 * editfns.c (Finsert_char):
8210 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8211
28177add
PE
8212 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8213
e69dafad
PE
82142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8215
4baa020d 8216 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8217
b1c46f02
PE
8218 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8219 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8220
e69dafad
PE
8221 * fileio.c: Don't assume EMACS_INT fits in off_t.
8222 (emacs_lseek): New static function.
8223 (Finsert_file_contents, Fwrite_region): Use it.
8224 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8225
566684ea
PE
8226 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8227
e6966cd6
PE
8228 * fns.c: Don't overflow int when computing a list length.
8229 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8230 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8231 truncation on 64-bit hosts. Check for QUIT every
8232 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8233 faster and is responsive enough.
8234 (Flength): Report an error instead of overflowing an integer.
8235 (Fsafe_length): Return a float if the value is not representable
8236 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8237 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8238 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8239
dd0b0efb
PE
8240 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8241 (header_size, word_size): New constants.
8242 (allocate_vectorlike): Don't check size overflow here.
8243 (allocate_vector): Check it here instead, since this is the only
8244 caller of allocate_vectorlike that could cause overflow.
8245 Check that the new vector's length is representable as a fixnum.
8246
86fe5cfe
PE
8247 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8248 The previous code was bogus. For example, next_almost_prime (32)
8249 returned 39, which is undesirable as it is a multiple of 3; and
8250 next_almost_prime (24) returned 25, which is a multiple of 5 so
8251 why was the code bothering to check for multiples of 7?
8252
80e88859
PE
8253 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8254
4a2f0ad6
PE
8255 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8256
f66c7cf8
PE
8257 Variadic C functions now count arguments with ptrdiff_t.
8258 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8259 Back then I didn't know that the Emacs coding style prefers signed int.
8260 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8261 were being counted with int, which may truncate counts on 64-bit
8262 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8263 * lisp.h (struct Lisp_Subr.function.aMANY)
8264 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8265 Arg counts are now ptrdiff_t, not size_t.
8266 All variadic functions and their callers changed accordingly.
8267 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8268 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8269 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8270 * callint.c (Fcall_interactively): Check arg count for overflow,
8271 to avoid potential buffer overrun. Use signed char, not 'int',
8272 for 'varies' array, so that we needn't bother to check its size
8273 calculation for overflow.
8274 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8275 * eval.c (apply_lambda):
8276 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8277 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8278 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8279
a1759b76
PE
8280 * callint.c (Fcall_interactively): Don't use index var as event count.
8281
d96be9fc
PE
8282 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8283 * mem-limits.h (SIZE): Remove; no longer used.
8284
a690a978 8285 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8286
578c21e6
PE
8287 Remove unnecessary casts.
8288 * xterm.c (x_term_init):
8289 * xfns.c (x_set_border_pixel):
8290 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8291 These aren't needed now that we assume ANSI C.
8292
96f53c6c
PE
8293 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8294 It's more likely to cause problems (due to unsigned overflow)
8295 than to cure them.
8296
83c77d31
PE
8297 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8298
ee2079f1
PE
8299 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8300
6da65536
PE
8301 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8302
7147c4a4
PE
8303 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8304
193e32d9
PE
8305 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8306
e5533da6
PE
8307 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8308
9910e595
PE
8309 GLYPH_CODE_FACE returns EMACS_INT, not int.
8310 * dispextern.h (merge_faces):
8311 * xfaces.c (merge_faces):
01103c44
PE
8312 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8313 Don't assume EMACS_INT fits in int.
9910e595 8314
2638320e
PE
8315 * character.h (CHAR_VALID_P): Remove unused parameter.
8316 * fontset.c, lisp.h, xdisp.c: All uses changed.
8317
045eb8d9
PE
8318 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8319
c1f134b5
PE
8320 * fns.c (concat): Minor tuning based on overflow analysis.
8321 This doesn't fix any bugs. Use int to hold character, instead
8322 of constantly refetching from Emacs object. Use XFASTINT, not
8323 XINT, for value known to be a character. Don't bother comparing
8324 a single byte to 0400, as it's always less.
8325
395fcb93 8326 * floatfns.c (Fexpt):
327eeec8
PE
8327 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8328
abbd3d23
PE
8329 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8330 for characters.
8331
684a03ef
PE
8332 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8333
0fed43f3
PE
8334 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8335 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8336 incorrectly succeed when S was a string, because 4294967386 was
8337 truncated before it was used.
8338
8fd02eb7
PE
8339 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8340 Otherwise, an out-of-range integer could cause undefined behavior
8341 on a 64-bit host.
8342
f8c86b69
PE
8343 * composite.c: Use int, not EMACS_INT, for characters.
8344 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8345 EMACS_INT, for values that are known to be in character range.
8346 This doesn't fix any bugs but is the usual style inside Emacs and
8347 may generate better code on 32-bit machines.
8348
34206dd2
PE
8349 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8350 This is for reasons similar to the recent CHAR_STRING fix.
8351 * charset.c (Fencode_char): Check that character arg is actually
8352 a character. Pass an int to ENCODE_CHAR.
8353 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8354 wider than 'int', as a compile-time check to prevent future regressions
8355 in this area.
8356
c5958d4c 8357 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8358
8359 Make sure a 64-bit char is never passed to CHAR_STRING.
8360 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8361 by silently ignoring the top 32 bits, allowing some values
8362 that were far too large to be valid characters.
8363 * character.h: Include <verify.h>.
8364 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8365 arguments are no wider than unsigned, as a compile-time check
8366 to prevent future regressions in this area.
8367 * data.c (Faset):
01103c44 8368 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8369 (Fsubst_char_in_region):
8370 * fns.c (concat):
8371 * xdisp.c (decode_mode_spec_coding):
8372 Adjust to CHAR_STRING's new requirement.
8373 * editfns.c (Finsert_char, Fsubst_char_in_region):
8374 * fns.c (concat): Check that character args are actually
8375 characters. Without this test, these functions did the wrong
8376 thing with wildly out-of-range values on 64-bit hosts.
8377
d37ca623
PE
8378 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8379 These casts should not be needed on 32-bit hosts, either.
8380 * keyboard.c (read_char):
8381 * lread.c (Fload): Remove casts to unsigned.
8382
ea204efb
PE
8383 * lisp.h (UNSIGNED_CMP): New macro.
8384 This fixes comparison bugs on 64-bit hosts.
8385 (ASCII_CHAR_P): Use it.
8386 * casefiddle.c (casify_object):
01103c44 8387 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8388 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8389 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8390 * dispextern.h (FACE_FROM_ID):
8391 * keyboard.c (read_char): Use UNSIGNED_CMP.
8392
41cb286c
PE
8393 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8394 not to EMACS_INT, to avoid GCC warning.
8395
4a1b9832
PE
8396 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8397
55daad71
PE
8398 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8399 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8400 isn't needed on 32-bit machines.
8f95c75c 8401
01103c44
PE
8402 * buffer.c (Fgenerate_new_buffer_name):
8403 Use EMACS_INT for count, not int.
0ceccced 8404 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8405
8406 * data.c (Qcompiled_function): Now static.
8407
c6f072e7
PE
8408 * window.c (window_body_lines): Now static.
8409
20ce5912
PE
8410 * image.c (gif_load): Rename local to avoid shadowing.
8411
9c4c5f81
PE
8412 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8413 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8414 * alloc.c (make_save_value): Integer argument is now of type
8415 ptrdiff_t, not int.
8416 (mark_object): Use ptrdiff_t, not int.
8417 * lisp.h (pD): New macro.
8418 * print.c (print_object): Use it.
8419
c0c5c8ae
PE
8420 * alloc.c: Use EMACS_INT, not int, to count objects.
8421 (total_conses, total_markers, total_symbols, total_vector_size)
8422 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8423 (total_free_floats, total_floats, total_free_intervals)
8424 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8425 Now EMACS_INT, not int. All uses changed.
8426 (Fgarbage_collect): Compute overall total using a double, so that
8427 integer overflow is less likely to be a problem. Check for overflow
8428 when converting back to an integer.
5a25e253
PE
8429 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8430 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8431 These were 'int' variables that could overflow on 64-bit hosts;
8432 they were never used, so remove them instead of repairing them.
211a0b2a 8433 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8434 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8435 Previously, this ceilinged at INT_MAX, but that doesn't work on
8436 64-bit machines.
e46bb31a 8437 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8438
c78baabf 8439 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8440 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8441 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8442 when a (possibly-narrower) signed value would do just as well.
8443 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8444
c9d624c6
PE
8445 * alloc.c: Catch some string size overflows that we were missing.
8446 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8447 for convenience in STRING_BYTES_MAX.
8448 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8449 The definition here is exact; the one in lisp.h was approximate.
8450 (allocate_string_data): Check for string overflow. This catches
8451 some instances we weren't catching before. Also, it catches
8452 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8453 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8454 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8455
c9d624c6
PE
8456 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8457 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8458 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8459
353032ce
PE
8460 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8461
2bccce07
PE
8462 * alloc.c (Fmake_string): Check for out-of-range init.
8463
0ac30604
SM
84642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8465
8466 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8467
c195f2de
JD
84682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8469
8470 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8471 xg_get_default_scrollbar_width.
8472
8473 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8474 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8475 (style_changed_cb): Call update_theme_scrollbar_width and call
8476 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8477 all frames (Bug#8505).
8478 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8479 Call gtk_window_set_resizable if HAVE_GTK3.
8480 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8481 and height if HAVE_GTK3 (Bug#8505).
8482 (scroll_bar_width_for_theme): New variable.
8483 (update_theme_scrollbar_width): New function.
8484 (xg_get_default_scrollbar_width): Move code to
8485 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8486 (xg_initialize): Call update_theme_scrollbar_width.
8487
8488 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8489
8490 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8491
e10ac9f1
MR
84922011-06-12 Martin Rudalics <rudalics@gmx.at>
8493
8494 * frame.c (make_frame): Call other_buffer_safely instead of
8495 other_buffer.
8496
8497 * window.c (temp_output_buffer_show): Call display_buffer with
8498 second argument Vtemp_buffer_show_specifiers and reset latter
8499 immediately after the call.
8500 (Vtemp_buffer_show_specifiers): New variable.
8501 (auto_window_vscroll_p, next_screen_context_lines)
8502 (Vscroll_preserve_screen_position): Remove leading asterisks from
8503 doc-strings.
8504
2d3c217e 85052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8506
7b7f97e8 8507 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8508 * buffer.c (Qclone_number): Remove for now, as it's unused.
8509 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8510 (record_buffer): Remove unused local.
8511 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8512 (set_frame_buffer_list): Remove; unused.
8513 * frame.h (other_visible_frames): Remove decl.
8514 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8515 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8516 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8517 if HAVE_GPM.
8518 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8519 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8520 Define only if HAVE_GPM.
8521 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8522 (update_hints_inhibit): Remove; never set. All uses removed.
8523 * widgetprv.h (emacsFrameClassRec): Remove decl.
8524 * window.c (delete_deletable_window): Now returns void, since it
8525 wasn't returning anything.
8526 (compare_window_configurations): Remove unused locals.
8527 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8528 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8529 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8530 the same widths as pointers. This follows up on the 2011-05-06 patch.
8531 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8532 * xterm.h: Likewise.
8533 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8534
1384b89e
JB
85352011-06-12 Juanma Barranquero <lekktu@gmail.com>
8536
8537 * makefile.w32-in: Update dependencies.
8538 (LISP_H): Add lib/intprops.h.
8539
1100a63c
CY
85402011-06-11 Chong Yidong <cyd@stupidchicken.com>
8541
8542 * image.c (gif_load): Add animation frame delay to the metadata.
8543 (syms_of_image): Use DEFSYM. New symbol `delay'.
8544
6198ccd0
MR
85452011-06-11 Martin Rudalics <rudalics@gmx.at>
8546
8547 * window.c (delete_deletable_window): Re-add.
8548 (Fset_window_configuration): Rewrite to handle dead buffers and
8549 consequently deletable windows.
8550 (window_tree, Fwindow_tree): Remove. Supply functionality in
8551 window.el.
8552 (compare_window_configurations): Simplify code.
8553
b6e3633c
AS
85542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8555
1ab0dee5
AS
8556 * image.c (imagemagick_load_image): Fix type mismatch.
8557 (Fimagemagick_types): Likewise.
8558
b6e3633c
AS
8559 * window.h (replace_buffer_in_windows): Declare.
8560
9397e56f
MR
85612011-06-11 Martin Rudalics <rudalics@gmx.at>
8562
8563 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8564 Qclone_number. Remove external declaration of Qdelete_window.
8565 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8566 code.
640c8776
SM
8567 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8568 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8569 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8570 buffer list implementation.
8571 (other_buffer_safely): New function.
8572 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8573 calls to replace_buffer_in_windows and
8574 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8575 if allowed.
8576 (record_buffer): Inhibit quitting and rewrite using quittable
8577 functions. Run Qbuffer_list_update_hook if allowed.
8578 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8579 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8580 Move switch-to-buffer to window.el.
9397e56f
MR
8581 (bury-buffer): Move to window.el.
8582 (Vbuffer_list_update_hook): New variable.
8583
8584 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8585 section.
8586
8587 * window.h (resize_frame_windows): Move up in code.
8588 (Fwindow_frame): Remove EXFUN.
8589 (replace_buffer_in_all_windows): Remove prototype.
8590 (replace_buffer_in_windows_safely): Add prototype.
8591
8592 * window.c: Declare Qdelete_window static again. Move down
8593 declaration of select_count.
8594 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8595 (Fother_window): Move to window.el.
8596 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8597 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8598 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8599 window.el.
8600 (replace_buffer_in_windows): Implement by calling
8601 Qreplace_buffer_in_windows.
8602 (replace_buffer_in_all_windows): Remove with some functionality
8603 moved into replace_buffer_in_windows_safely.
8604 (replace_buffer_in_windows_safely): New function.
8605 (select_window_norecord, select_frame_norecord): Move in front
8606 of run_window_configuration_change_hook. Remove now obsolete
8607 declarations.
640c8776
SM
8608 (Fset_window_buffer): Rewrite doc-string.
8609 Call Qrecord_window_buffer.
9397e56f
MR
8610 (keys_of_window): Move binding for other-window to window.el.
8611
b50691aa
CY
86122011-06-11 Chong Yidong <cyd@stupidchicken.com>
8613
8614 * dispextern.h (struct image): Replace data member, whose int_val
8615 and ptr_val fields were not used by anything, with a single
8616 lisp_val object.
8617
8618 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8619 (gif_clear_image, gif_load, imagemagick_load_image)
8620 (gs_clear_image, gs_load): Callers changed.
8621
3f754b86
PE
86222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8623
cca69397
PE
8624 * buffer.h: Include <time.h>, for time_t.
8625 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8626
109e28d0
PE
8627 Fix minor problems found by static checking.
8628
60737f02
PE
8629 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8630
4b66faf3
PE
8631 Make identifiers static if they are not used in other modules.
8632 * data.c (Qcompiled_function, Qframe, Qvector):
8633 * image.c (QimageMagick, Qsvg):
8634 * minibuf.c (Qmetadata):
8635 * window.c (resize_window_check, resize_root_window): Now static.
8636 * window.h (resize_window_check, resize_root_window): Remove decls.
8637
109e28d0
PE
8638 * window.c (window_deletion_count, delete_deletable_window):
8639 Remove; unused.
46a4ce9e
PE
8640 (window_body_lines): Now static.
8641 (Fdelete_other_windows_internal): Mark vars as initialized.
8642 Make sure 'resize_failed' is initialized.
8643 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8644 (resize_window_apply): Remove unused local.
8645 * window.h (delete_deletable_window): Remove decl.
8646
109e28d0 8647 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8648 (imagemagick_load_image): Fix pointer signedness problem by changing
8649 last arg from unsigned char * to char *. All uses changed.
8650 Also, fix a local for similar reasons.
8651 Remove unused locals. Remove locals to avoid shadowing.
8652 (fn_rsvg_handle_free): Remove; unused.
8653 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8654 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8655
3f754b86
PE
8656 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8657
2547adb1
CY
86582011-06-10 Chong Yidong <cyd@stupidchicken.com>
8659
8660 * image.c (gif_load): Fix omitted cast error introduced by
8661 2011-06-06 change.
8662
2c8e37d4
MR
86632011-06-10 Martin Rudalics <rudalics@gmx.at>
8664
8665 * window.h (resize_proportionally, orig_total_lines)
8666 (orig_top_line): Remove from window structure.
8667 (set_window_height, set_window_width, change_window_heights)
8668 (Fdelete_window): Remove prototypes.
8669 (resize_frame_windows): Remove duplicate declaration.
8670
440a42e3
EZ
86712011-06-10 Eli Zaretskii <eliz@gnu.org>
8672
8673 * window.h (resize_frame_windows, resize_window_check)
8674 (delete_deletable_window, resize_root_window)
8675 (resize_frame_windows): Declare prototypes.
8676
8677 * window.c (resize_window_apply): Make definition be "static" to
8678 match the prototype.
8679
562dd5e9
MR
86802011-06-10 Martin Rudalics <rudalics@gmx.at>
8681
8682 * window.c: Remove declarations of Qwindow_size_fixed,
8683 window_min_size_1, window_min_size_2, window_min_size,
8684 size_window, window_fixed_size_p, enlarge_window, delete_window.
8685 Remove static from declaration of Qdelete_window, it's
8686 temporarily needed by Fbury_buffer.
8687 (replace_window): Don't assign orig_top_line and
8688 orig_total_lines.
8689 (Fdelete_window, delete_window): Remove. Window deletion is
8690 handled by window.el.
640c8776
SM
8691 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8692 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8693 (Fdelete_other_windows): Remove. Deleting other windows is
8694 handled by window.el.
8695 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8696 handled in window.el.
8697 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8698 Window minimum sizes are handled in window.el.
8699 (shrink_windows, size_window, set_window_height)
8700 (set_window_width, change_window_heights, window_height)
8701 (window_width, CURBEG, CURSIZE, enlarge_window)
8702 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8703 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8704 handled in window.el.
8705 (make_dummy_parent): Rename to make_parent_window and give it a
8706 second argument horflag.
8707 (make_window): Don't set resize_proportionally any more.
8708 (Fsplit_window): Remove. Windows are split in window.el.
8709 (save_restore_action, save_restore_orig_size)
8710 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8711 Resize mini windows in window.el.
8712 (grow_mini_window, shrink_mini_window): Implement by calling
8713 Qresize_root_window_vertically, resize_window_check and
8714 resize_window_apply.
640c8776
SM
8715 (saved_window, Fset_window_configuration, save_window_save):
8716 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8717 resize_proportionally.
8718 (window_min_height, window_min_width): Move to window.el.
8719 (keys_of_window): Move bindings for delete-other-windows,
8720 split-window, delete-window and enlarge-window to window.el.
8721
8722 * buffer.c: Temporarily extern Qdelete_window.
8723 (Fbury_buffer): Temporarily call Qdelete_window instead of
8724 Fdelete_window (Fbury_buffer will move to window.el soon).
8725
8726 * frame.c (set_menu_bar_lines_1): Remove code handling
8727 orig_top_line and orig_total_lines.
8728
8729 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8730 set_window_height but set heights directly.
8731 (change_frame_size_1): Use resize_frame_windows.
8732
8733 * xdisp.c (init_xdisp): Don't use set_window_height but set
8734 heights directly.
8735
640c8776
SM
8736 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8737 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8738 run_window_configuration_change_hook.
8739
8740 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8741 instead of change_window_heights and run
8742 run_window_configuration_change_hook.
8743
1a13852e
MR
87442011-06-09 Martin Rudalics <rudalics@gmx.at>
8745
8746 * window.c (replace_window): Rename second argument REPLACEMENT to
8747 NEW. New third argument SETFLAG. Rewrite.
8748 (delete_window, make_dummy_parent): Call replace_window with
8749 third argument 1.
8750 (window_list_1): Move down in code.
8751 (run_window_configuration_change_hook): Move set_buffer part
8752 before select_frame_norecord part in order to unwind correctly.
8753 Rename count1 to count.
8754 (recombine_windows, delete_deletable_window, resize_root_window)
8755 (Fdelete_other_windows_internal)
8756 (Frun_window_configuration_change_hook, make_parent_window)
8757 (resize_window_check, resize_window_apply, Fresize_window_apply)
8758 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8759 (Fdelete_window_internal, Fresize_mini_window_internal):
8760 New functions.
1a13852e
MR
8761 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8762
f3d1777e
MR
87632011-06-08 Martin Rudalics <rudalics@gmx.at>
8764
496e208e
MR
8765 * window.h (window): Add some new members to window structure -
8766 normal_lines, normal_cols, new_total, new_normal, clone_number,
8767 splits, nest, prev_buffers, next_buffers.
8768 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8769 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8770
f3d1777e
MR
8771 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8772 Remove.
496e208e
MR
8773 (make_dummy_parent): Set new members of windows structure.
8774 (make_window): Move down in code. Handle new members of window
8775 structure.
8776 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8777 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8778 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8779 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8780 (Fset_window_next_buffers, Fset_window_clone_number):
8781 New functions.
496e208e
MR
8782 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8783 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8784 Doc-string fixes.
8785 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8786 Argument WINDOW can be now internal window too.
8787 (Fwindow_use_time): Move up in code.
8788 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8789 Rewrite doc-string.
8790 (Fset_window_configuration, saved_window)
8791 (Fcurrent_window_configuration, save_window_save): Handle new
8792 members of window structure.
b9e809c2
MR
8793 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8794 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8795 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8796 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8797 Qget_mru_window, Qresize_root_window,
8798 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8799 Qauto_buffer_name; staticpro them.
f3d1777e 8800
abde8f8c
MR
88012011-06-07 Martin Rudalics <rudalics@gmx.at>
8802
8803 * window.c (Fwindow_total_size, Fwindow_left_column)
8804 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8805 (Fwindow_list_1): New functions.
8806 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8807 (Fwindow_width, Fscroll_left, Fscroll_right):
8808 Use window_body_cols instead of window_box_text_cols.
8809 (delete_window, Fset_window_configuration):
8810 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8811 (delete_all_subwindows): Take a window as argument and not a
8812 structure. Rewrite.
190b47e6
MR
8813 (window_loop): Remove handling of GET_LRU_WINDOW and
8814 GET_LARGEST_WINDOW.
8815 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8816
8817 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8818 window_box_text_cols. delete_all_subwindows now takes a
8819 Lisp_Object as argument.
abde8f8c 8820
640c8776
SM
8821 * indent.c (compute_motion, Fcompute_motion):
8822 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8823
fa8a67e6
MR
8824 * frame.c (delete_frame): Call delete_all_subwindows with root
8825 window as argument.
8826
a54e3482
DC
88272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8828
8829 * fns.c (Fputhash): Document return value.
8830
60002bf5
CY
88312011-06-06 Chong Yidong <cyd@stupidchicken.com>
8832
8833 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8834
0c671da6 88352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8836
b862a52a 8837 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8838
be44ca6c
PE
8839 Check for overflow when converting integer to cons and back.
8840 * charset.c (Fdefine_charset_internal, Fdecode_char):
8841 Use cons_to_unsigned to catch overflow.
8842 (Fencode_char): Use INTEGER_TO_CONS.
8843 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8844 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8845 * data.c (long_to_cons, cons_to_long): Remove.
8846 (cons_to_unsigned, cons_to_signed): New functions.
8847 These signal an error for invalid or out-of-range values.
8848 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8849 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8850 * font.c (Ffont_variation_glyphs):
8851 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8852 * lisp.h: Include <intprops.h>.
8853 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8854 (cons_to_signed, cons_to_unsigned): New decls.
8855 (long_to_cons, cons_to_long): Remove decls.
8856 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8857 (Fprimitive_undo): Use CONS_TO_INTEGER.
8858 * xfns.c (Fx_window_property): Likewise.
8859 * xselect.c: Include <limits.h>.
8860 (x_own_selection, selection_data_to_lisp_data):
8861 Use INTEGER_TO_CONS.
8862 (x_handle_selection_request, x_handle_selection_clear)
8863 (x_get_foreign_selection, Fx_disown_selection_internal)
8864 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8865 (lisp_data_to_selection_data): Use cons_to_unsigned.
8866 (x_fill_property_data): Use cons_to_signed.
8867 Report values out of range.
8868
d1f3d2af
PE
8869 Check for buffer and string overflow more precisely.
8870 * buffer.h (BUF_BYTES_MAX): New macro.
8871 * lisp.h (STRING_BYTES_MAX): New macro.
8872 * alloc.c (Fmake_string):
8873 * character.c (string_escape_byte8):
8874 * coding.c (coding_alloc_by_realloc):
8875 * doprnt.c (doprnt):
8876 * editfns.c (Fformat):
8877 * eval.c (verror):
8878 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8879 since they may not be the same number.
8880 * editfns.c (Finsert_char):
8881 * fileio.c (Finsert_file_contents):
8882 Likewise for BUF_BYTES_MAX.
8883
dd52fcea
PE
8884 * image.c: Use ptrdiff_t, not int, for sizes.
8885 (slurp_file): Switch from int to ptrdiff_t.
8886 All uses changed.
8887 (slurp_file): Check that file size fits in both size_t (for
8888 malloc) and ptrdiff_t (for sanity and safety).
8889
7f9bbdbb
PE
8890 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8891 if b->modtime has its maximal value.
8892
dfe18f82
PE
8893 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8894
84acfcf0
PE
8895 Don't assume time_t can fit into int.
8896 * buffer.h (struct buffer.modtime): Now time_t, not int.
8897 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8898 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8899
ccd9a01a
PE
8900 Minor fixes for signed vs unsigned integers.
8901 * character.h (MAYBE_UNIFY_CHAR):
8902 * charset.c (maybe_unify_char):
8903 * keyboard.c (read_char, reorder_modifiers):
8904 XINT -> XFASTINT, since the integer must be nonnegative.
8905 * ftfont.c (ftfont_spec_pattern):
8906 * keymap.c (access_keymap, silly_event_symbol_error):
8907 XUINT -> XFASTINT, since the integer must be nonnegative.
8908 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8909 since it makes no difference and we prefer signed.
8910 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8911 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8912 nonnegative.
8913
d6d100dd
SM
89142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8915
8916 * window.h (Fwindow_frame): Declare.
8917
2b6148e4
PE
89182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8919
8920 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8921 (SPARE_MEMORY): Always define.
8922 (LARGE_REQUEST): Remove.
8923 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8924
f230ecc9
MR
89252011-06-06 Martin Rudalics <rudalics@gmx.at>
8926
727e958e
MR
8927 * lisp.h: Move EXFUNS for Fframe_root_window,
8928 Fframe_first_window and Fset_frame_selected_window to window.h.
8929
8930 * window.h: Move EXFUNS for Fframe_root_window,
8931 Fframe_first_window and Fset_frame_selected_window here from
8932 lisp.h.
8933
8934 * frame.c (Fwindow_frame, Fframe_first_window)
8935 (Fframe_root_window, Fframe_selected_window)
8936 (Fset_frame_selected_window): Move to window.c.
8937 (Factive_minibuffer_window): Move to minibuf.c.
8938 (Fother_visible_frames_p): New function.
8939
8940 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8941
f230ecc9
MR
8942 * window.c (decode_window, decode_any_window): Move up in code.
8943 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8944 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8945 (Fwindow_buffer): Move up and rewrite doc-string.
8946 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8947 (Fwindow_prev): New functions.
727e958e
MR
8948 (Fwindow_frame): Move here from frame.c. Accept any window as
8949 argument.
8950 (Fframe_root_window, Fframe_first_window)
8951 (Fframe_selected_window): Move here from frame.c. Accept frame
8952 or arbitrary window as argument. Update doc-strings.
8953 (Fminibuffer_window): Move up in code.
8954 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8955 (Fset_frame_selected_window): Move here from frame.c.
8956 Marginal rewrite.
727e958e
MR
8957 (Fselected_window, select_window, Fselect_window): Move up in
8958 code. Minor doc-string fixes.
f230ecc9 8959
4d09bcf6
PE
89602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8961
8962 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8963 Do not assume that spare memory exists; that assumption is valid
8964 only if SYSTEM_MALLOC.
8965 (LARGE_REQUEST): New macro, so that the issue of large requests
8966 is separated from the issue of spare memory.
8967
810928a2
AS
89682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8969
172418ad
AS
8970 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8971 format. (Bug#8806)
8972
43f862f7
AS
8973 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8974
810928a2
AS
8975 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8976 before statements.
8977
a059fe24
JD
89782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8979
8980 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8981
8982 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8983
8984 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8985 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8986
989bf368
JB
89872011-06-05 Juanma Barranquero <lekktu@gmail.com>
8988
8989 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8990
4b80f674
CY
89912011-06-04 Chong Yidong <cyd@stupidchicken.com>
8992
8993 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8994 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8995 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8996 New error handlers.
4b80f674
CY
8997 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8998 Obey Vx_select_enable_clipboard_manager. Catch errors in
8999 x_clipboard_manager_save (Bug#8779).
9000 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9001 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9002
99a33b77 90032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9004
9005 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9006
99a33b77 90072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9008
9009 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9010 in the current matrix if keep_current_p is non-zero.
9011
8264569d
EZ
90122011-06-04 Eli Zaretskii <eliz@gnu.org>
9013
9014 * bidi.c (bidi_level_of_next_char): Fix last change.
9015
57f97249
EZ
90162011-06-03 Eli Zaretskii <eliz@gnu.org>
9017
fec2107c 9018 Support bidi reordering of text covered by display properties.
57f97249 9019
fec2107c
EZ
9020 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9021 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9022 (bidi_cache_search, bidi_cache_iterator_state)
9023 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9024 (bidi_level_of_next_char, bidi_move_to_visually_next):
9025 Support character positions inside a run of characters covered by a
fec2107c
EZ
9026 display string.
9027 (bidi_paragraph_init, bidi_resolve_explicit_1)
9028 (bidi_level_of_next_char): Call bidi_fetch_char and
9029 bidi_fetch_char_advance instead of FETCH_CHAR and
9030 FETCH_CHAR_ADVANCE.
9031 (bidi_init_it): Initialize new members.
9032 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9033 definitions.
9034 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9035 instead of using explicit *_CHAR codes.
d6d100dd
SM
9036 (bidi_resolve_explicit, bidi_resolve_weak):
9037 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9038 bidirectional text is supported only in multibyte buffers.
9039 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9040 it to initialize the frame_window_p member of struct bidi_it.
9041 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9042 (bidi_resolve_explicit, bidi_resolve_weak)
9043 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9044 bidi_it->nchars is non-positive.
9045 (bidi_level_of_next_char): Don't try to lookup the cache for the
9046 next/previous character if nothing is cached there yet, or if we
9047 were just reseat()'ed to a new position.
c40e2fb2 9048
0e14fe90
EZ
9049 * xdisp.c (set_cursor_from_row): Set start and stop points
9050 according to the row's direction when priming the loop that looks
9051 for the glyph on which to display cursor.
9052 (single_display_spec_intangible_p): Function deleted.
9053 (display_prop_intangible_p): Reimplement to call
9054 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9055 Accept 3 additional arguments needed by handle_display_spec.
9056 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9057 values: lists, `(when COND...)' forms, etc.
9058 (single_display_spec_string_p): Support property values that are
9059 lists with the argument STRING its top-level element.
9060 (display_prop_string_p): Fix the condition for processing a
9061 property that is a list to be consistent with handle_display_spec.
fec2107c 9062 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9063 last portion of handle_display_prop.
9064 (compute_display_string_pos): Accept additional argument
9065 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9066 value of a `display' property is a "replacing spec".
9067 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9068 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9069 the display property, but just return a value indicating whether
9070 the display property will replace the characters it covers.
9071 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9072 frame_window_p members of struct bidi_it.
d6d100dd
SM
9073 (compute_display_string_pos, compute_display_string_end):
9074 New functions.
fec2107c
EZ
9075 (push_it): Accept second argument POSITION, where pop_it should
9076 jump to continue iteration.
9077 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9078
fec2107c
EZ
9079 * keyboard.c (adjust_point_for_property): Adjust the call to
9080 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9081
9082 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9083 (bidi_init_it): Update prototypes.
9084 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9085 (compute_display_string_pos, compute_display_string_end):
9086 Declare prototypes.
fec2107c
EZ
9087 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9088 EMACS_INT.
fc6f18ce 9089
40087514 90902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9091
57f53182
PE
9092 Malloc failure behavior now depends on size of allocation.
9093 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9094 * lisp.h: Change signatures accordingly.
9095 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9096 All callers changed. (Bug#8762)
9097
9098 * gnutls.c: Use Emacs's memory allocators.
9099 Without this change, the gnutls library would invoke malloc etc.
9100 directly, which causes problems on non-SYNC_INPUT hosts, and which
9101 runs afoul of improving memory_full behavior. (Bug#8761)
9102 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9103 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9104 xfree instead of the default malloc, realloc, free.
9105 (Fgnutls_boot): No need to check for memory allocation failure,
9106 since xmalloc does that for us.
9107
ac32cd99 9108 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9109 * category.c (hash_get_category_set):
9110 * ccl.c (ccl_driver):
9111 * charset.c (Fdefine_charset_internal):
9112 * charset.h (struct charset.hash_index):
9113 * composite.c (get_composition_id, gstring_lookup_cache)
9114 (composition_gstring_put_cache):
9115 * composite.h (struct composition.hash_index):
9116 * dispextern.h (struct image.hash):
9117 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9118 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9119 (hashfn_equal, hashfn_user_defined, make_hash_table)
9120 (maybe_resize_hash_table, hash_lookup, hash_put)
9121 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9122 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9123 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9124 * image.c (make_image, search_image_cache, lookup_image)
9125 (xpm_put_color_table_h):
9126 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9127 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9128 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9129 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9130 * alloc.c (allocate_vectorlike):
9131 Check for overflow in vector size calculations.
9132 * ccl.c (ccl_driver):
9133 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9134 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9135 need to be updated by these changes.
40087514
PE
9136 * fns.c (make_hash_table, maybe_resize_hash_table):
9137 Check for integer overflow with large hash tables.
0de4bb68
PE
9138 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9139 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9140 (SXHASH_REDUCE): New macro.
9141 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9142 Use it instead of discarding useful hash info with large hash values.
9143 (sxhash_float): New function.
9144 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9145 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9146 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9147 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9148 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9149 Adjust signatures to match updated version of code.
9150 (consing_since_gc): Now EMACS_INT, since a single hash table can
9151 use more than INT_MAX bytes.
9152
698d32e2
DN
91532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9154
9155 Make it possible to build with GCC-4.6+ -O2 -flto.
9156
9157 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9158
fd6fa53f
SM
91592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9160
9161 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9162 Call minibuffer-inactive-mode.
9163
864db017
JB
91642011-05-31 Juanma Barranquero <lekktu@gmail.com>
9165
9166 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9167 Update dependencies.
9168
2ad0baf4
DN
91692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9170
9171 * data.c (init_data): Remove code for UTS, this system is not
9172 supported anymore.
9173
4fcc2638
DN
91742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9175
9176 Don't force ./temacs to start in terminal mode.
9177
9178 * frame.c (make_initial_frame): Initialize faces in all cases, not
9179 only when CANNOT_DUMP is defined.
9180 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9181
c56e0fd5
DN
91822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9183
9184 * dispnew.c (add_window_display_history): Use const for the string
9185 pointer. Remove declaration, not needed.
9186
333d54da 91872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9188
55d4c1b2 9189 Use 'inline', not 'INLINE'.
333d54da 9190 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9191 * alloc.c, fontset.c (INLINE): Remove.
9192 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9193 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9194 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9195 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9196 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9197
738db178
DN
91982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9199
9200 Make it possible to run ./temacs.
9201
9202 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9203 syms_of_callproc does the same thing. Remove test for
9204 "initialized", do it in the caller.
9205 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9206
620c53a6
SM
92072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9208
9209 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9210 (read_minibuf): Use get_minibuffer.
9211 (syms_of_minibuf): Use DEFSYM.
9212 (Qmetadata): New var.
9213 * data.c (Qbuffer): Don't make it static.
9214 (syms_of_data): Use DEFSYM.
9215
e003a292
PE
92162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9217
9218 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9219 (CCL_CODE_MIN): New macro.
9220
ed008a6d
PE
92212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9222
3687c2ef
PE
9223 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9224
ed008a6d
PE
9225 * eval.c (Qdebug): Now static.
9226 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9227 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9228 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9229
d66c4c7c
CY
92302011-05-29 Chong Yidong <cyd@stupidchicken.com>
9231
9232 * image.c: Various fixes to ImageMagick code comments.
9233 (Fimagemagick_types): Doc fix.
9234
5fbc2025
PE
92352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9236
0196f88a
PE
9237 Minor fixes prompted by GCC 4.6.0 warnings.
9238
9239 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9240
5fbc2025
PE
9241 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9242 (x_clipboard_manager_save_all): Move extern decl to ...
9243 * xterm.h: ... here, so that it can be checked for consistency.
9244
1dd3c2d9
CY
92452011-05-29 Chong Yidong <cyd@stupidchicken.com>
9246
9247 * xselect.c (x_clipboard_manager_save_frame)
9248 (x_clipboard_manager_save_all): New functions.
9249 (Fx_clipboard_manager_save): Lisp function deleted.
9250
9251 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9252 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9253
9254 * xterm.h: Update prototype.
9255
5ba6571d
WX
92562011-05-28 William Xu <william.xwl@gmail.com>
9257
9258 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9259 exiting (Bug#8239).
9260
3eaff834
JM
92612011-05-28 Jim Meyering <meyering@redhat.com>
9262
e1900994 9263 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9264 * fns.c (to_uchar): Define.
9265 (crypto_hash_function): Use it to convert some newly-signed
9266 variables to unsigned, to avoid sign-extension bugs. For example,
9267 without this change, (md5 "truc") would evaluate to
9268 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9269 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9270 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9271
0f6990a7
PE
92722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9273
9274 Integer overflow fixes.
c8a9ca5a 9275
08686060
PE
9276 * dbusbind.c: Serial number integer overflow fixes.
9277 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9278 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9279 to hold a serial number that is too large for a fixnum.
9280 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9281 Check for serial numbers out of range. Decode any serial number
59568bf0 9282 that was so large that it became a float. (Bug#8722)
08686060 9283
2d1fc3c7
PE
9284 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9285 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9286 Use XFASTINT rather than XUINT when numbers are nonnegative.
9287 (xd_append_arg, Fdbus_method_return_internal):
9288 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9289 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9290 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9291 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9292 (Bug#8722)
2d1fc3c7 9293
c8a9ca5a
PE
9294 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9295
519e1d69
PE
9296 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9297
6df6ae42 9298 ccl: Add integer overflow checks.
30569699
PE
9299 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9300 (IN_INT_RANGE): New macros.
9301 (ccl_driver): Use them to check for integer overflow when
9302 decoding a CCL program. Many of the new checks are whether XINT (x)
9303 fits in int; it doesn't always, on 64-bit hosts. The new version
9304 doesn't catch all possible integer overflows, but it's an
847044ea 9305 improvement. (Bug#8719)
30569699 9306
c11285dc
PE
9307 * alloc.c (make_event_array): Use XINT, not XUINT.
9308 There's no need for unsigned here.
9309
fdccd48e
PE
9310 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9311 This follows up to the 2011-05-06 change that substituted uintptr_t
9312 for EMACS_INT. This case wasn't caught back then.
9313
37910ab2
PE
9314 Rework Fformat to avoid integer overflow issues.
9315 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9316 now (part of C89). Include <verify.h>.
9317 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9318 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9319 (Fformat): Avoid the prepass trying to compute sizes; it was only
9320 approximate and thus did not catch overflow reliably. Instead, walk
9321 through the format just once, formatting and computing sizes as we go,
9322 checking for integer overflow at every step, and allocating a larger
9323 buffer as needed. Keep track separately whether the format is
9324 multibyte. Keep only the most-recently calculated precision, rather
9325 than them all. Record whether each argument has been converted to
9326 string. Use EMACS_INT, not int, for byte and char and arg counts.
9327 Support field widths and precisions larger than INT_MAX. Avoid
9328 sprintf's undefined behavior with conversion specifications such as %#d
9329 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9330 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9331 formatting out-of-range floating point numbers with int
9173deec 9332 formats. (Bug#8668)
37910ab2 9333
2e6578fb
PE
9334 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9335
0ae6bdee
PE
9336 * data.c: Avoid integer truncation in expressions involving floats.
9337 * data.c: Include <intprops.h>.
9338 (arith_driver): When there's an integer overflow in an expression
9339 involving floating point, convert the integers to floating point
9340 so that the resulting value does not suffer from catastrophic
9341 integer truncation. For example, on a 64-bit host (* 4
9342 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9343 Do not rely on undefined behavior after integer overflow.
9344
de883a70
PE
9345 merge count_size_as_multibyte, parse_str_to_multibyte
9346 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9347 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9348 Check for integer overflow.
9349 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9350 since it's now a duplicate of the other. This is more of
9351 a character than a buffer op, so better that it's in character.c.
9352 * fns.c, print.c: Adjust to above changes.
9353
2ff916cb
PE
93542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9355
9356 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9357
f1b54466
PE
93582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9359
fb1ac845
PE
9360 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9361 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9362 (x_clipboard_manager_save): Now static.
9363 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9364
f1b54466
PE
9365 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9366 (crypto_hash_function): Now static.
9367 Fix pointer signedness problems. Avoid unnecessary initializations.
9368
a9f737ee
CY
93692011-05-27 Chong Yidong <cyd@stupidchicken.com>
9370
9371 * termhooks.h (Vselection_alist): Make it terminal-local.
9372
9373 * terminal.c (create_terminal): Initialize it.
9374
9375 * xselect.c: Support for clipboard managers.
9376 (Vselection_alist): Move to termhooks.h as terminal-local var.
9377 (LOCAL_SELECTION): New macro.
9378 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9379 (symbol_to_x_atom): Remove gratuitous arg.
9380 (x_handle_selection_request, lisp_data_to_selection_data)
9381 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9382 (x_own_selection, x_get_local_selection, x_convert_selection):
9383 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9384 (some_frame_on_display): Delete unused function.
9385 (Fx_own_selection_internal, Fx_get_selection_internal)
9386 (Fx_disown_selection_internal, Fx_selection_owner_p)
9387 (Fx_selection_exists_p): New optional frame arg.
9388 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9389 (x_handle_selection_clear): Don't treat other terminals with the
9390 same keyboard specially. Use the terminal-local Vselection_alist.
9391 (x_clear_frame_selections): Use Frun_hook_with_args.
9392
9393 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9394
9395 * xterm.h: Add support for those atoms.
9396
e067f0c1
CY
93972011-05-26 Chong Yidong <cyd@stupidchicken.com>
9398
9399 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9400 (converted_selections, conversion_fail_tag): New global variables.
9401 (x_selection_request_lisp_error): Free the above.
9402 (x_get_local_selection): Remove unnecessary code.
9403 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9404 of converted selections stored in converted_selections.
9405 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9406 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9407 (x_convert_selection): New function.
9408 (x_handle_selection_event): Simplify.
9409 (x_get_foreign_selection): Don't ignore incoming requests while
9410 waiting for an answer; this will fail when we implement
9411 SAVE_TARGETS, and seems unnecessary anyway.
9412 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9413 (Vx_sent_selection_functions): Doc fix.
9414
0f4aebc0
LL
94152011-05-26 Leo Liu <sdl.web@gmail.com>
9416
9417 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9418
e61124cd
YM
94192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9420
9421 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9422
9423 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9424 for fringe update if it has periodic bitmap.
ac389d0c 9425 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9426 and fringe_bitmap_periodic_p.
9427
9428 * fringe.c (get_fringe_bitmap_data): New function.
9429 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9430 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9431 row. Mark glyph row for fringe update if periodicity changed.
9432
9433 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9434 for fringe update unless it has periodic bitmap.
9435
f16d9837
KH
94362011-05-25 Kenichi Handa <handa@m17n.org>
9437
9438 * xdisp.c (get_next_display_element): Set correct it->face_id for
9439 a static composition.
9440
e1b90ef6
LL
94412011-05-24 Leo Liu <sdl.web@gmail.com>
9442
9443 * deps.mk (fns.o):
9444 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9445
9446 * fns.c (crypto_hash_function, Fsha1): New function.
9447 (Fmd5): Use crypto_hash_function.
9448 (syms_of_fns): Add Ssha1.
9449
7400048f
PE
94502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9451
9452 * gnutls.c: Remove unused macros.
9453 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9454 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9455 Remove macros that are defined and never used.
9456 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9457
abb71cf4
CY
94582011-05-22 Chong Yidong <cyd@stupidchicken.com>
9459
9460 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9461 (Fx_get_selection_internal): Minor cleanup.
9462 (Fx_own_selection_internal): Rename arguments for consistency with
9463 select.el.
9464
6307db39
PE
94652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9466
9467 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9468
f3d4e0a4
CY
94692011-05-22 Chong Yidong <cyd@stupidchicken.com>
9470
9471 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9472
4d8ade89
YM
94732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9474
9475 * dispnew.c (scrolling_window): Don't exclude the case that the
9476 last enabled row in the desired matrix touches the bottom boundary.
9477
32078c8d
GM
94782011-05-21 Glenn Morris <rgm@gnu.org>
9479
9480 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9481 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9482 and add some more files.
32078c8d 9483
7285dc67
EZ
94842011-05-20 Eli Zaretskii <eliz@gnu.org>
9485
9486 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9487 report_file_error introduced by the change from 2011-05-07.
9488
89d1bd22
PE
94892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9490
9491 * systime.h (Time): Define only if emacs is defined.
9492 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9493 where the include path doesn't have X11/X.h by default. See
9494 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9495
cd394be1 94962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9497
9498 * composite.c (find_automatic_composition): Fix previous change.
9499
b9704ad9
GM
95002011-05-20 Glenn Morris <rgm@gnu.org>
9501
9502 * lisp.mk: New file, split from Makefile.in.
9503 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9504 (shortlisp): Remove.
9505 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9506
4a720484
GM
95072011-05-19 Glenn Morris <rgm@gnu.org>
9508
9509 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9510 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9511 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9512 (lisp): Set the order to that of loadup.el.
9513 (shortlisp): Make it a copy of $lisp.
9514 (SOME_MACHINE_LISP): Remove.
9515 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9516 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9517
a28d4396
KH
95182011-05-18 Kenichi Handa <handa@m17n.org>
9519
9520 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9521 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9522 (find_automatic_composition): Mostly rewrite for efficiency.
9523
a2b1fa8e
JB
95242011-05-18 Juanma Barranquero <lekktu@gmail.com>
9525
9526 * makefile.w32-in: Update dependencies.
9527
8e1f5610
CS
95282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9529
9530 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9531 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9532
7025ee00 95332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9534
cdfa6eab
PE
9535 Fix some integer overflow issues, such as string length overflow.
9536
06d6db33
PE
9537 * insdel.c (count_size_as_multibyte): Check for string overflow.
9538
2b4560a8
PE
9539 * character.c (lisp_string_width): Check for string overflow.
9540 Use EMACS_INT, not int, for string indexes and lengths; in
9541 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9542 the resulting string length overflows an EMACS_INT; instead,
9543 report a string overflow if no precision given. When checking for
9544 precision exhaustion, use a check that cannot possibly have
9545 integer overflow. (Bug#8675)
9546 * character.h (lisp_string_width): Adjust to new signature.
9547
cb93f9be
PE
9548 * alloc.c (string_overflow): New function.
9549 (Fmake_string): Use it. This doesn't change behavior, but saves
9550 a few bytes and will simplify future changes.
9551 * character.c (string_escape_byte8): Likewise.
9552 * lisp.h (string_overflow): New decl.
9553
1a1f3366
PE
9554 Fixups, following up to the user-interface timestamp change.
9555 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9556 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9557 * msdos.c (mouse_get_pos): Likewise.
9558 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9559 * w32gui.h (Time): Define by including "systime.h" rather than by
9560 declaring it ourselves. (Bug#8664)
9561
d4e3e4d3
PE
9562 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9563 * image.c (clear_image_cache): Likewise.
9564
f6a24d19
PE
9565 * term.c (term_mouse_position): Don't assume time_t wraparound.
9566
08dc5ae6
PE
9567 Be more systematic about user-interface timestamps.
9568 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9569 and sometimes 'EMACS_UINT', to represent these timestamps.
9570 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9571 This makes the code easier to follow, and makes it easier to catch
9572 integer overflow bugs such as Bug#8664.
9573 * frame.c (Fmouse_position, Fmouse_pixel_position):
9574 Use Time, not unsigned long, for user-interface timestamps.
9575 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9576 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9577 * keyboard.h (last_event_timestamp): Likewise.
9578 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9579 * menu.h (xmenu_show): Likewise.
9580 * term.c (term_mouse_position): Likewise.
9581 * termhooks.h (struct input_event.timestamp): Likewise.
9582 (struct terminal.mouse_position_hook): Likewise.
9583 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9584 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9585 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9586 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9587 what it was before.
9588 * menu.h, termhooks.h: Include "systime.h", for Time.
9589
8e55734a
PE
9590 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9591 Don't assume that the difference between two unsigned long values
9592 can fit into an integer. At this point, we know button_down_time
9593 <= event->timestamp, so the difference must be nonnegative, so
9594 there's no need to cast the result if double-click-time is
9595 nonnegative, as it should be; check that it's nonnegative, just in
9596 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9597 apart (about 25 days). (Bug#8664)
8e55734a 9598
841f1b75 9599 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9600 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9601
3e26f69c
PE
9602 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9603 that always fit in int. Use a sentinel instead of a counter, to
9604 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9605 * frame.h (struct frame): Use int for menu_bar_items_used
9606 instead of EMACS_INT, since it always fits in int.
3e26f69c 9607
5cc152c0
PE
9608 * menu.c (grow_menu_items): Check for int overflow.
9609
d89eb65e
PE
9610 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9611
5235bd3e
PE
9612 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9613 Before, the code was not consistent. These values cannot exceed
9614 2**31 - 1 so there's no need to make them unsigned.
9615 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9616 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9617 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9618 as modifiers.
9619 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9620
bc827e23
PE
9621 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9622 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9623 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9624 presumably because the widths might not match.
9625
78eb494e
PE
9626 * window.c (size_window): Avoid needless test at loop start.
9627
04f2d78b
CB
96282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9629
9630 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9631
d2fc7e3d 96322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9633
9634 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9635
d2fc7e3d 96362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9637
9638 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9639 `width' to `bar_area_x' and `bar_area_width', respectively.
9640 (x_scroll_run): Take account of fringe background extension.
9641
04f2d78b
CB
9642 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9643 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9644 `bar_area_width', respectively.
9645 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9646 background extension.
9647
79b70037
GM
96482011-05-10 Jim Meyering <meyering@redhat.com>
9649
9650 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9651
2f142cc5
JB
96522011-05-10 Juanma Barranquero <lekktu@gmail.com>
9653
9654 * image.c (Finit_image_library): Return t for built-in image types,
9655 like pbm and xbm. (Bug#8640)
9656
57679c86
AS
96572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9658
9659 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9660
888c9e86
EZ
96612011-05-07 Eli Zaretskii <eliz@gnu.org>
9662
b0512a1d
EZ
9663 * w32console.c (Fset_screen_color): Doc fix.
9664 (Fget_screen_color): New function.
9665 (syms_of_ntterm): Defsubr it.
9666
7285dc67
EZ
9667 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9668 unlink the temporary file if Fcall_process didn't create it in the
9669 first place.
9670 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9671 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9672 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9673 cue to call_process_cleanup not to close that handle.
9674
4d3fcc8e
BK
96752011-05-07 Ben Key <bkey76@gmail.com>
9676
9677 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9678 one of two shell specific rules, either bootstrap-temacs-CMD or
9679 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9680 to the previous implementation of the bootstrap-temacs rule.
9681 The bootstrap-temacs-CMD rule is similar to the previous
9682 implementation of the bootstrap-temacs rule except that it
9683 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9684 variable.
9685
9686 These changes, along with some changes to nt/configure.bat,
9687 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9688 earlier fix to add support for --cflags and --ldflags options
9689 that include quotes so that it works whether make uses cmd or
9690 sh as the shell.
9691
b4289b64
MA
96922011-05-06 Michael Albinus <michael.albinus@gmx.de>
9693
9694 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9695 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9696 is a constant.
9697 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9698 a string. Handle both cases.
9699 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9700 (Fdbus_register_method): Use Qinvalid_function.
9701
af4c0e28
JB
97022011-05-06 Juanma Barranquero <lekktu@gmail.com>
9703
9704 * makefile.w32-in: Update dependencies.
9705 (LISP_H): Add inttypes.h and stdin.h.
9706 (PROCESS_H): Add unistd.h.
9707
c51453d9
EZ
97082011-05-06 Eli Zaretskii <eliz@gnu.org>
9709
9710 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9711 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9712
8ff0ac3c 97132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9714
4c4b566b
PE
9715 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9716
aab2b9b5
PE
9717 * term.c (vfatal): Remove stray call to va_end.
9718 It's not needed and the C Standard doesn't allow it here anyway.
9719
c378da0b
PE
9720 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9721 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9722
288b08c7
PE
9723 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9724 bytes.
9725
e3601888
PE
9726 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9727
db6c0e74
PE
9728 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9729
dd5963ea
PE
9730 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9731
88c9450f
PE
9732 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9733
2f9442b8
PE
9734 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9735
c032b5f8
PE
9736 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9737 * charset.c (Fdefine_charset_internal): Don't initialize
9738 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9739 32-bit int (Bug#8600).
a108c10b
PE
9740
9741 * lread.c (read_integer): Be more consistent with string-to-number.
9742 Use string_to_number to do the actual conversion; this avoids
9743 rounding errors and fixes some other screwups. Without this fix,
9744 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9745 (digit_to_number): Move earlier, for benefit of read_integer.
9746 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9747 not a digit in any supported base. (Bug#8602)
a108c10b 9748
ad5f9eea
PE
9749 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9750
aec1708a
PE
9751 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9752 to match comment at start of function. This also removes a
9753 GCC warning about overflow in a 32+64-bit port.
9754
47be4ab5
PE
9755 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9756
371cac43
PE
9757 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9758 Reported by Stefan Monnier in
9759 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9760 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9761 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9762
d01a7826
PE
9763 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9764 (EMACS_UINTPTR): Likewise, with uintptr_t.
9765
7fd47d5c
PE
9766 * lisp.h: Prefer 64-bit EMACS_INT if available.
9767 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9768 on 32-bit hosts that have 64-bit int, so that they can access
9769 large files.
122b0c86
PE
9770 However, temporarily disable this change unless the temporary
9771 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9772
8727937b
PE
9773 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9774
8ac068ac
PE
9775 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9776 This removes an assumption that EMACS_INT and long are the same
9777 width as pointers. The assumption is true for Emacs porting targets
9778 now, but we want to make other targets possible.
9779 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9780 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9781 In the rest of the code, change types of integers that hold casted
9782 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9783 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9784 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9785 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9786 No need to cast type when ORing.
9787 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9788 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9789 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9790 assume EMACS_INT is the same width as char *.
9791 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9792 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9793 Remove no-longer-needed casts.
9794 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9795 (xg_tool_bar_help_callback, xg_make_tool_item):
9796 Use EMACS_INTPTR to hold an integer
9797 that will be cast to void *; this can avoid a GCC warning
9798 if EMACS_INT is not the same width as void *.
9799 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9800 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9801 (current_message_1, set_message_1):
9802 Use a local to convert to proper width without a cast.
9803 * xmenu.c (dialog_selection_callback): Likewise.
9804
ede49d71
PE
9805 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9806 Also, don't assume VALBITS / RAND_BITS is less than 5,
9807 and don't rely on undefined behavior when shifting a 1 left into
9808 the sign bit.
9809 * lisp.h (get_random): Change signature to match.
9810
2f30ecd0
PE
9811 * lread.c (hash_string): Use size_t, not int, for hash computation.
9812 Normally we prefer signed values; but hashing is special, because
9813 it's better to use unsigned division on hash table sizes so that
9814 the remainder is nonnegative. Also, size_t is the natural width
9815 for hashing into memory. The previous code used 'int', which doesn't
9816 retain enough info to hash well into very large tables.
9817 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9818
2a866e7b
PE
9819 * dbusbind.c: Don't possibly lose pointer info when converting.
9820 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9821 Use XPNTR rather than XHASH, so that the high-order bits of
9822 the pointer aren't lost when converting through void *.
9823
51639eac
PE
9824 * eval.c (Fautoload): Don't double-shift a pointer.
9825
92394119
PE
9826 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9827
dbdb9a7c
JB
98282011-05-06 Juanma Barranquero <lekktu@gmail.com>
9829
9830 * gnutls.c (DEF_GNUTLS_FN):
9831 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9832
db7a0b4f
AS
98332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9834
9835 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9836 marker. (Bug#8610)
9837
cd394be1 98382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9839
9840 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9841 New version that can reserve upto 2GB of heap space.
9842
f7ff1b0f 98432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9844
9845 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9846
639c109b
TZ
98472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9848
9849 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9850 `gnutls_certificate_set_x509_key_file'.
9851
d2127135
JB
98522011-05-05 Juanma Barranquero <lekktu@gmail.com>
9853
9854 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9855 Update dependencies.
9856
e968f4f3
JB
98572011-05-04 Juanma Barranquero <lekktu@gmail.com>
9858
9859 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9860 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9861 Remove unused parameter `fildes'.
9862 * process.c (read_process_output, send_process): Don't pass it.
9863
84d358f0
JB
98642011-05-04 Juanma Barranquero <lekktu@gmail.com>
9865
9866 Fix previous change: the library cache is defined in w32.c.
9867 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9868 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9869
0898ca10
JB
98702011-05-04 Juanma Barranquero <lekktu@gmail.com>
9871
9872 Implement dynamic loading of GnuTLS on Windows.
9873
9874 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9875 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9876 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9877 Declare.
9878
9879 * gnutls.c (Qgnutls_dll): Define.
9880 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9881 (gnutls_*): Declare function pointers.
9882 (init_gnutls_functions): New function to initialize function pointers.
9883 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9884 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9885 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9886 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9887 (emacs_gnutls_write, emacs_gnutls_read)
9888 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9889 (Fgnutls_available_p): New function.
9890 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9891 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9892 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9893
9894 * image.c: Include w32.h.
9895 (Vimage_type_cache): Delete.
9896 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9897 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9898 (w32_delayed_load): Move to w32.c.
9899
9900 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9901
9902 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9903 (w32_delayed_load): Move from image.c. When loading a library, record
9904 its filename in the :loaded-from property of the library id.
9905 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9906 Initialize and staticpro them.
9907 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9908
9909 * process.c: Include lisp.h before w32.h, not after.
9910 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9911 instead of gnutls_record_check_pending.
9912
9913 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9914
ff4de4aa
TZ
99152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9916
9917 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9918 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9919 as passed in.
9920
abe95abb
JD
99212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9922
9923 * xterm.c (x_set_frame_alpha): Do not set property on anything
9924 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9925
e16e55d4
JB
99262011-05-02 Juanma Barranquero <lekktu@gmail.com>
9927
9928 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9929
bafcf6a5
JB
99302011-05-02 Juanma Barranquero <lekktu@gmail.com>
9931
9932 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9933 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9934 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9935 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9936 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9937 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9938 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9939 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9940 (Qgnutls_bootprop_callbacks_verify): Make static.
9941
e7a6747f
AS
99422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9943
19ed11ba
AS
9944 * callproc.c: Indentation fixup.
9945
e7a6747f 9946 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9947 (wait_for_termination, interruptible_wait_for_termination):
9948 Move after wait_for_termination_1.
e7a6747f 9949
1ef14cb4
LMI
99502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9951
9952 * sysdep.c (interruptible_wait_for_termination): New function
9953 which is like wait_for_termination, but allows keyboard
9954 interruptions.
9955
9956 * callproc.c (Fcall_process): Add (:file "file") as an option for
9957 the STDOUT buffer.
9958 (Fcall_process_region): Ditto.
9959
330d880c
EZ
99602011-04-30 Eli Zaretskii <eliz@gnu.org>
9961
8db90b73
EZ
9962 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9963 rather than `XVECTOR (FOO)->size'.
9964
330d880c
EZ
9965 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9966 inttypes.h, as a gnulib replacement is used if it not available in
9967 system headers.
9968
15cbd324
EZ
99692011-04-21 Eli Zaretskii <eliz@gnu.org>
9970
9971 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9972 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9973 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9974
9975 * coding.c (coding_alloc_by_realloc): Error out if destination
9976 will grow beyond MOST_POSITIVE_FIXNUM.
9977 (decode_coding_emacs_mule): Abort if there isn't enough place in
9978 charbuf for the composition carryover bytes. Reserve an extra
9979 space for up to 2 characters produced in a loop.
9980 (decode_coding_iso_2022): Abort if there isn't enough place in
9981 charbuf for the composition carryover bytes.
9982
99832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9984
ae940cca
EZ
9985 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9986 aborting when %lld or %lll format is passed.
9987 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9988 %llo or %llx format is passed. (Bug#8545)
9989
03ab8921
EZ
9990 * window.c (window_scroll_line_based): Use a marker instead of
9991 simple variables to record original value of point. (Bug#7952)
9992
afda1437
EZ
9993 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9994 produced by %s or %c overflows available buffer space. (Bug#8545)
9995
f76dee0c
PE
99962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9997
9998 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9999 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10000
fdc5744d
JB
100012011-04-28 Juanma Barranquero <lekktu@gmail.com>
10002
10003 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10004
638f053a
JB
100052011-04-28 Juanma Barranquero <lekktu@gmail.com>
10006
10007 * keyboard.c (Qdelayed_warnings_hook): Define.
10008 (command_loop_1): Run `delayed-warnings-hook'
10009 if Vdelayed_warnings_list is non-nil.
10010 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10011 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10012
d178f871
EZ
100132011-04-28 Eli Zaretskii <eliz@gnu.org>
10014
10015 * doprnt.c (doprnt): Don't return value smaller than the buffer
10016 size if the message was truncated. (Bug#8545).
10017
b124fd93
JB
100182011-04-28 Juanma Barranquero <lekktu@gmail.com>
10019
10020 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10021 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10022
e810457d
PE
100232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10024
10025 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10026
ea51cceb
JB
100272011-04-27 Juanma Barranquero <lekktu@gmail.com>
10028
10029 * makefile.w32-in: Update dependencies.
10030
94dcfacf
EZ
100312011-04-27 Eli Zaretskii <eliz@gnu.org>
10032
10033 Improve `doprnt' and its usage. (Bug#8545)
10034 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10035 `format_end'. Remove support for %l as a conversion specifier.
10036 Don't use xrealloc. Improve diagnostics when the %l size modifier
10037 is used. Update the commentary.
10038
10039 * eval.c (verror): Simplify calculation of size_t.
10040
10041 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10042 messages.
10043
f61f41d7
PE
100442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10045
10046 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10047 change.
10048
96fb4434
PE
100492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10050
10051 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10052 This makes this file independent of the recent pseudovector change.
10053
671875da 100542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10055
69e9b5a3
PE
10056 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10057
b5f869a7 10058 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10059 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10060 Remove unused local.
c8926152 10061 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10062
841a1577 10063 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10064 GCC 4.6.0 optimizes based on type-based alias analysis.
10065 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10066 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10067 != &v->size, and therefore "v->size = 1; b->size = 2; return
10068 v->size;" must therefore return 1. This assumption is incorrect
10069 for Emacs, since it type-puns struct Lisp_Vector * with many other
10070 types. To fix this problem, this patch adds a new type struct
f904488f 10071 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10072 and pseudovectors, and helps optimizing compilers not get fooled
10073 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10074 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10075 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10076 the size member.
eab3844f
PE
10077 (XSETPVECTYPE): Rewrite in terms of new macro.
10078 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10079 This is a bit clearer, and further avoids the possibility of
10080 undesirable aliasing.
10081 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10082 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10083 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10084 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10085 (ASIZE): Now uses header.size rather than size.
10086 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10087 to avoid the hassle of writing XVECTOR (foo)->header.size.
10088 (struct vectorlike_header): New type.
eab3844f
PE
10089 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10090 object, to help avoid aliasing.
10091 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10092 (SUBRP): Likewise, since Lisp_Subr is a special case.
10093 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10094 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10095 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10096 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10097 changed to be "header.size" and "header.next".
10098 * buffer.h (struct buffer): Likewise.
10099 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10100 * frame.h (struct frame): Likewise.
10101 * process.h (struct Lisp_Process): Likewise.
10102 * termhooks.h (struct terminal): Likewise.
10103 * window.c (struct save_window_data, struct saved_window): Likewise.
10104 * window.h (struct window): Likewise.
10105 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10106 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10107 * buffer.c (init_buffer_once): Likewise.
10108 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10109 special case.
10110 * process.c (Fformat_network_address): Use local var for size,
10111 for brevity.
10112
0df1eac5
PE
10113 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10114
847ab9d1 10115 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10116 * data.c (atof): Remove decl; no longer used or needed.
10117 (digit_to_number): Move to lread.c.
10118 (Fstring_to_number): Use new string_to_number function, to be
10119 consistent with how the Lisp reader treats infinities and NaNs.
10120 Do not assume that floating-point numbers represent EMACS_INT
10121 without losing information; this is not true on most 64-bit hosts.
10122 Avoid double-rounding errors, by insisting on integers when
10123 parsing non-base-10 numbers, as the documentation specifies.
10124 * lisp.h (string_to_number): New decl, replacing ...
10125 (isfloat_string): Remove.
bc0a5c13 10126 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10127 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10128 appears to have been a coding error. Similarly, do not accept
10129 strings like +-1e0 as floating point numbers. Do not report
10130 overflow for integer overflows unless the base is not 10 which
10131 means we have no simple and reliable way to continue.
10132 Break out the floating-point parsing into a new
10133 function string_to_number, so that Fstring_to_number parses
10134 floating point numbers consistently with the Lisp reader.
04f2d78b 10135 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10136 (E_CHAR, EXP_INT): Remove, replacing with ...
10137 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10138 (string_to_number): New function, replacing isfloat_string.
10139 This function checks for valid syntax and produces the resulting
10140 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10141 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10142 so that overflow for non-base-10 numbers is reported only when
10143 there's no portable and simple way to convert to floating point.
452f4150 10144
67769ffc
PE
10145 * textprop.c (set_text_properties_1): Rewrite for clarity,
10146 and to avoid GCC warning about integer overflow.
10147
c20db43f
PE
10148 * intervals.h (struct interval): Use EMACS_INT for members
10149 where EMACS_UINT might cause problems. See
10150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10151 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10152 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10153 All uses changed.
37aa2f85
PE
10154 (offset_intervals): Tell GCC not to worry about length overflow
10155 when negating a negative length.
c20db43f 10156
2538aa2f
PE
10157 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10158 (overrun_check_free): Likewise.
10159
f2d3008d
PE
10160 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10161 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10162 word size.
10163
ec8df744
PE
10164 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10165 (gnutls_make_error): Rename local to avoid shadowing.
10166 (gnutls_emacs_global_deinit): ifdef out; not used.
10167 (Fgnutls_boot): Use const for pointer to readonly storage.
10168 Comment out unused local. Fix pointer signedness problems.
10169
640ee02d
PE
10170 * lread.c (openp): Don't stuff size_t into an 'int'.
10171 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10172 about possible signed overflow.
10173
6048fb2a
PE
10174 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10175 (GDK_KEY_g): Don't define if already defined.
10176 (xg_prepare_tooltip): Avoid pointer signedness problem.
10177 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10178
fa3c87e1
PE
10179 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10180 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10181
2172544b
PE
10182 * xfns.c (Fx_window_property): Simplify a bit,
10183 to make a bit faster and to avoid GCC 4.6.0 warning.
10184 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10185
9b821a21
PE
10186 * fns.c (internal_equal): Don't assume size_t fits in int.
10187
3c616cfa
PE
10188 * alloc.c (compact_small_strings): Tighten assertion a little.
10189
c2982e87
PE
10190 Replace pEd with more-general pI, and fix some printf arg casts.
10191 * lisp.h (pI): New macro, generalizing old pEd macro to other
10192 conversion specifiers. For example, use "...%"pI"d..." rather
10193 than "...%"pEd"...".
10194 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10195 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10196 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10197 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10198 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10199 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10200 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10201 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10202 64-bit hosts.
10203 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10204 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10205 * print.c (safe_debug_print, print_object): Likewise.
10206 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10207 to int.
6f04d126
PE
10208 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10209 avoiding the 0 flag, which is not portable.
c2982e87
PE
10210 * process.c (Fmake_network_process): Use pI to avoid cast.
10211 * region-cache.c (pp_cache): Likewise.
10212 * xdisp.c (decode_mode_spec): Likewise.
10213 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10214 behavior on 64-bit hosts with printf arg.
6f04d126 10215 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10216 (x_stop_queuing_selection_requests): Likewise.
10217 (x_get_window_property): Don't truncate byte count to an 'int'
10218 when tracing.
0b432f21 10219
5e073ec7
PE
10220 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10221 here, since it parses constructs like leading '-' and spaces,
10222 which are not wanted; and it overflows with large numbers.
10223 Instead, simply match F[0-9]+, which is what is wanted anyway.
10224
36372bf9
PE
10225 * alloc.c: Remove unportable assumptions about struct layout.
10226 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10227 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10228 (allocate_vectorlike, make_pure_vector): Use the new macros,
10229 plus offsetof, to remove unportable assumptions about struct layout.
10230 These assumptions hold on all porting targets that I know of, but
10231 they are not guaranteed, they're easy to remove, and removing them
10232 makes further changes easier.
10233
0b432f21
PE
10234 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10235 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10236 (string_overrun_cookie): Now const. Use initializers that
10237 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10238 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10239 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10240 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10241 multiple of sizeof (EMACS_INT); it need not be, if
10242 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10243 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10244
895009e1
JB
102452011-04-26 Juanma Barranquero <lekktu@gmail.com>
10246
10247 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10248
6a7a1b0b
TZ
102492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10250
10251 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10252 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10253 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10254
841a1577 102552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10256
10257 * lisp.h (Qdebug): List symbol.
895009e1 10258 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10259 * keyboard.c (debug-on-event): New variable.
10260 (handle_user_signal): Break into debugger when debug-on-event
10261 matches the current signal symbol.
10262
f2d3ba6f
DN
102632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10264
10265 * alloc.c (check_sblock, check_string_bytes)
10266 (check_string_free_list): Convert to standard C.
10267
42ce4c63
TZ
102682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10269
10270 * w32.c (emacs_gnutls_push): Fix typo.
10271
825cd63c
EZ
102722011-04-25 Eli Zaretskii <eliz@gnu.org>
10273
fb11d64d
EZ
10274 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10275 "cast to pointer from integer of different size".
10276
825cd63c
EZ
10277 Improve doprnt and its use in verror. (Bug#8545)
10278 * doprnt.c (doprnt): Document the set of format control sequences
10279 supported by the function. Use SAFE_ALLOCA instead of always
10280 using `alloca'.
10281
10282 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10283 is one byte too soon. Don't use xrealloc; instead xfree and
10284 xmalloc anew.
10285
e061a11b
TZ
102862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10287
10288 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10289 callbacks stage.
10290
10291 * gnutls.c: Renamed global_initialized to
10292 gnutls_global_initialized. Added internals for the
10293 :verify-hostname-error, :verify-error, and :verify-flags
10294 parameters of `gnutls-boot' and documented those parameters in the
10295 docstring. Start callback support.
9173deec
JB
10296 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10297 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10298 on error. Return error code.
e061a11b
TZ
10299 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10300 (emacs_gnutls_read): Likewise.
10301 (Fgnutls_boot): Return handshake error code.
10302 (emacs_gnutls_handle_error): New function.
10303 (wsaerror_to_errno): Likewise.
10304
10305 * w32.h (emacs_gnutls_pull): Add prototype.
10306 (emacs_gnutls_push): Likewise.
10307
10308 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10309 (emacs_gnutls_push): Likewise.
10310
103112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10312
10313 * process.c (wait_reading_process_output): Check if GnuTLS
10314 buffered some data internally if no FDs are set for TLS
10315 connections.
10316
10317 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10318 (LIBS): Link to USER_LIBS.
10319 ($(BLD)/gnutls.$(0)): New target.
10320
fa6996bc
EZ
103212011-04-24 Eli Zaretskii <eliz@gnu.org>
10322
eb35682e
EZ
10323 * xdisp.c (handle_single_display_spec): Rename the
10324 display_replaced_before_p argument into display_replaced_p, to
10325 make it consistent with the commentary. Fix typos in the
10326 commentary.
10327
e2ad650c
EZ
10328 * textprop.c (syms_of_textprop): Remove dead code.
10329 (copy_text_properties): Delete obsolete commentary about an
10330 interface that was deleted long ago. Fix typos in the description
10331 of arguments.
10332
1b2de274
EZ
10333 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10334 to changes in oldXMenu/XMenu.h from 2011-04-16.
10335 <menu_help_message, prev_menu_help_message>: Constify.
10336 (IT_menu_make_room): menu->help_text is now `const char **';
10337 adjust.
10338
10339 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10340 to changes in oldXMenu/XMenu.h from 2011-04-16.
10341 (struct XMenu): Declare `help_text' `const char **'.
10342
10343 * xfaces.c <Qunspecified>: Make extern again.
10344
10345 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10346 required by POSIX.
1b2de274 10347
762b15be
EZ
10348 * doc.c (get_doc_string): Improve the format passed to `error'.
10349
10350 * doprnt.c (doprnt): Improve commentary.
10351
10352 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10353
10354 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10355 them with etags.
10356
f1052e5d
EZ
10357 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10358 changes in globals.h immediately force recompilation.
762b15be
EZ
10359 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10360 $(CURDIR)/s/ms-w32.h.
10361 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10362
fa6996bc
EZ
10363 * character.c (Fchar_direction): Function deleted.
10364 (syms_of_character): Don't defsubr it.
10365 <char-direction-table>: Deleted.
10366
e6c3da20
EZ
103672011-04-23 Eli Zaretskii <eliz@gnu.org>
10368
10369 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10370 * doprnt.c: Include limits.h.
10371 (SIZE_MAX): New macro.
04f2d78b
CB
10372 (doprnt): Return a size_t value. 2nd arg is now size_t.
10373 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10374 Improve overflow protection. Support `l' modifier for integer
10375 conversions. Support %l conversion. Don't assume an EMACS_INT
10376 argument for integer conversions and for %c.
10377
10378 * lisp.h (doprnt): Restore prototype.
10379
10380 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10381 $(SRC)/character.h.
10382
10383 * Makefile.in (base_obj): Add back doprnt.o.
10384
10385 * deps.mk (doprnt.o): Add back prerequisites.
10386 (callint.o): Depend on character.h.
10387
10388 * eval.c (internal_lisp_condition_case): Include the handler
10389 representation in the error message.
10390 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10391 when breaking from the loop.
10392
10393 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10394
10395 * callint.c (Fcall_interactively): When displaying error message
10396 about invalid control letter, pass the character's codepoint, not
10397 a pointer to its multibyte form. Improve display of the character
10398 in octal and display also its hex code.
10399
10400 * character.c (char_string): Use %x to display the (unsigned)
10401 codepoint of an invalid character, to avoid displaying a bogus
10402 negative value.
10403
10404 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10405 `error', not SYMBOL_NAME itself.
10406
10407 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10408 character arguments to `error'.
10409
10410 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10411 to `error' in error message about FINAL_CHAR argument. Make sure
10412 FINAL_CHAR is a character, and use %c when it is passed as
10413 argument to `error'.
10414
4ffd0d6b 104152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10416
10417 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10418
10419 * w32.c: Include <time.h>.
10420 (sys_localtime): New function.
10421
4ffd0d6b 104222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10423
10424 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10425
4ffd0d6b 10426 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10427
4ffd0d6b 104282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10429
4ffd0d6b
GM
10430 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10431 zombies (Bug#8467).
aac0c6e3 10432
04c56954
EZ
104332011-04-19 Eli Zaretskii <eliz@gnu.org>
10434
10435 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10436 gl_state.e_property when gl_state.object is Qt.
10437
10438 * insdel.c (make_gap_larger): Remove limitation of buffer size
10439 to <= INT_MAX.
10440
16a43933
CY
104412011-04-18 Chong Yidong <cyd@stupidchicken.com>
10442
10443 * xdisp.c (lookup_glyphless_char_display)
10444 (produce_glyphless_glyph): Handle cons cell entry in
10445 glyphless-char-display.
10446 (Vglyphless_char_display): Document it.
10447
10448 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10449 glyphless-char-display.
10450
4581706e
CY
104512011-04-17 Chong Yidong <cyd@stupidchicken.com>
10452
10453 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10454
10455 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10456
10457 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10458 definition for no-X builds.
10459
4887c6e2 104602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10461
fd35b6f9
PE
10462 Static checks with GCC 4.6.0 and non-default toolkits.
10463
5c1ccb01
PE
10464 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10465
006c5daa
PE
10466 * process.c (keyboard_bit_set): Define only if SIGIO.
10467 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10468 (send_process): Repair possible setjmp clobbering.
10469
efc736d3
PE
10470 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10471
4e2fe2e6
PE
10472 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10473
f97334a2
PE
10474 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10475
4e75f29d
PE
10476 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10477 Define only if needed.
10478
90efadd1
PE
10479 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10480 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10481 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10482
3c647824
PE
10483 * dispextern.h (struct redisplay_interface): Rename param
10484 to avoid shadowing.
e264f262 10485 * termhooks.h (struct terminal): Likewise.
761383f4 10486 * xterm.c (xembed_send_message): Likewise.
3c647824 10487
b58c5c4a
PE
10488 * insdel.c (make_gap_smaller): Define only if
10489 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10490
cad59032
PE
10491 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10492 it.
10493
c339dc2e
PE
10494 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10495 so that we aren't warned about unused symbols.
10496
91a3e27b
PE
10497 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10498
399c71d3 10499 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10500
8ffc96f5
PE
10501 * xfns.c (x_real_positions): Mark locals as initialized.
10502
eef9bc79
PE
10503 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10504
098db9dd
PE
10505 * xterm.c: Fix problems found by static analysis with other toolkits.
10506 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10507 (x_dispatch_event): Declare static if USE_GTK, and
10508 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10509 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10510 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10511 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10512 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10513
eb18f6cc
PE
10514 * xmenu.c (menu_help_callback): Pointer type fixes.
10515 Use const pointers when pointing at readonly data. Avoid pointer
10516 signedness clashes.
10517 (FALSE): Remove unused macro.
10518 (update_frame_menubar): Remove unused decl.
10519
1fe72bf8
PE
10520 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10521
60d9e1db
PE
10522 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10523 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10524 (single_menu_item): Rename local to avoid shadowing.
10525
39261c26
PE
10526 * keyboard.c (make_lispy_event): Remove unused local var.
10527
018c5e19
PE
10528 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10529 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10530
63d2b86e
PE
10531 * bitmaps: Change bitmaps from unsigned char back to the X11
10532 compatible char. Avoid the old compiler warnings about
10533 out-of-range initializers by using, for example, '\xab' rather
10534 than 0xab.
10535
aefd87e1
PE
10536 * xgselect.c (xgselect_initialize): Check vs interface
10537 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10538
bf501fb9
PE
10539 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10540
e9829fdf
PE
10541 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10542 to read-only memory.
10543
1086c095
PE
10544 * fns.c (vector): Remove; this old hack is no longer needed.
10545
2baccd04 10546 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10547 Remove unused var.
dde42981 10548 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10549
72391843 10550 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10551
436c16df 10552 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10553 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10554 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10555
92bb796d 10556 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10557 (x_term_init): Remove local to avoid shadowing.
92bb796d 10558
764430a3 10559 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10560
10561 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10562 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10563
d1dfb56c
EZ
105642011-04-16 Eli Zaretskii <eliz@gnu.org>
10565
c4354cb4
EZ
10566 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10567
d1dfb56c
EZ
10568 Fix regex.c, syntax.c and friends for buffers > 2GB.
10569 * syntax.h (struct gl_state_s): Declare character position members
10570 EMACS_INT.
10571
10572 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10573
04f2d78b
CB
10574 * textprop.c (verify_interval_modification, interval_of):
10575 Declare arguments EMACS_INT.
d1dfb56c
EZ
10576
10577 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10578 EMACS_INT.
10579
10580 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10581
10582 * indent.c (Fvertical_motion): Local variable it_start is now
10583 EMACS_INT.
10584
10585 * regex.c (re_match, re_match_2, re_match_2_internal)
10586 (bcmp_translate, regcomp, regexec, print_double_string)
10587 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10588 (re_compile_pattern, re_exec): Declare arguments and local
10589 variables `size_t' and `ssize_t' and return values `regoff_t', as
10590 appropriate.
10591 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10592 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10593 <compile_stack_type>: `size' and `avail' are now `size_t'.
10594
10595 * regex.h <regoff_t>: Use ssize_t, not int.
10596 (re_search, re_search_2, re_match, re_match_2): Arguments that
10597 specify buffer/string position and length are now ssize_t and
10598 size_t. Return type is regoff_t.
10599
613052cd
BK
106002011-04-16 Ben Key <bkey76@gmail.com>
10601
10602 * nsfont.m: Fixed bugs in ns_get_family and
10603 ns_descriptor_to_entity that were caused by using free to
10604 deallocate memory blocks that were allocated by xmalloc (via
10605 xstrdup). This caused Emacs to crash when compiled with
10606 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10607 --enable-checking=xmallocoverrun). xfree is now used to
10608 deallocate these memory blocks.
10609
4170f62f 106102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10611
71b41406
PE
10612 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10613
9587a89d
PE
10614 emacs_write: Accept and return EMACS_INT for sizes.
10615 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10616 et seq.
10617 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10618 Accept and return EMACS_INT.
10619 (emacs_gnutls_write): Return the number of bytes written on
10620 partial writes.
10621 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10622 (emacs_read, emacs_write): Remove check for negative size, as the
10623 Emacs source code has been audited now.
9587a89d
PE
10624 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10625 (emacs_read, emacs_write): Use it.
273a5f82
PE
10626 * process.c (send_process): Adjust to the new signatures of
10627 emacs_write and emacs_gnutls_write. Do not attempt to store
10628 a byte offset into an 'int'; it might overflow.
9587a89d 10629 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10630
3e047f51
PE
10631 * sound.c: Don't assume sizes fit in 'int'.
10632 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10633 Return EMACS_INT, not int.
3e047f51 10634 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10635 Accept EMACS_INT, not int.
10636 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10637 record read return values.
10638
cc39a9db
BK
106392011-04-15 Ben Key <bkey76@gmail.com>
10640
c9d0ec6d
JB
10641 * keyboard.c (Qundefined): Don't declare static since it is used
10642 in nsfns.m.
10643 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10644 static since they are used in nsfont.m.
cc39a9db 10645
6c60eb9f
SM
106462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10647
10648 * process.c (Qprocessp): Don't declare static.
10649 * lisp.h (Qprocessp): Declare again.
10650
7990b61a
JB
106512011-04-15 Juanma Barranquero <lekktu@gmail.com>
10652
10653 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10654
5d4cb038
PE
106552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10656
8bd7b830 10657 Improve C-level modularity by making more things 'static'.
cd64ea1d 10658
e3b27b31
PE
10659 Don't publish debugger-only interfaces to other modules.
10660 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10661 (verify_bytepos, count_markers): Move decls to the only modules
10662 that need them.
10663 * region-cache.h (pp_cache): Likewise.
10664 * window.h (check_all_windows): Likewise.
10665 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10666
5d4cb038
PE
10667 * sysdep.c (croak): Now static, if
10668 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10669 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10670
10671 * alloc.c (refill_memory_reserve): Now static if
10672 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10673 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10674
e87b6180
PE
10675 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10676 Define only if USE_LUCID.
10677
ac64929e
PE
10678 * xrdb.c (x_customization_string, x_rm_string): Now static.
10679
6f37259d
PE
10680 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10681 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10682
1683e3ab
PE
10683 * xdisp.c (draw_row_with_mouse_face): Now static.
10684 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10685
de9c2632
PE
10686 * window.h (check_all_windows): Mark externally visible.
10687
2b96acb7
PE
10688 * window.c (window_deletion_count): Now static.
10689
10690 * undo.c: Make symbols static if they're not exported.
10691 (last_undo_buffer, last_boundary_position, pending_boundary):
10692 Now static.
10693
50436f33
PE
10694 * textprop.c (interval_insert_behind_hooks): Now static.
10695 (interval_insert_in_front_hooks): Likewise.
10696
64520e5c
PE
10697 * term.c: Make symbols static if they're not exported.
10698 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10699 (max_frame_lines, tty_set_terminal_modes):
10700 (tty_reset_terminal_modes, tty_turn_off_highlight):
10701 (get_tty_terminal): Now static.
10702 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10703 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10704 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10705 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10706 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10707
1fa53021
PE
10708 * sysdep.c: Make symbols static if they're not exported.
10709 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10710 Now static.
10711 (sigprocmask_set, full_mask): Remove; unused.
10712 (wait_debugging): Mark as visible.
10713 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10714 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10715
d4b43b22
PE
10716 * syntax.c (syntax_temp): Define only if !__GNUC__.
10717
b7c513d0
PE
10718 * sound.c (current_sound_device, current_sound): Now static.
10719
989b29ad
PE
10720 * search.c (searchbufs, searchbuf_head): Now static.
10721
13a55a78
PE
10722 * scroll.c (scroll_cost): Remove; unused.
10723 * dispextern.h (scroll_cost): Remove decl.
10724
de68a1fc
PE
10725 * region-cache.h (pp_cache): Mark as externally visible.
10726
40ccffa6
PE
10727 * process.c: Make symbols static if they're not exported.
10728 (process_tick, update_tick, create_process, chan_process):
10729 (Vprocess_alist, proc_buffered_char, datagram_access):
10730 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10731 (deactivate_process): Mark defn as static, as well as decl.
10732 * lisp.h (create_process): Remove decl.
10733 * process.h (chan_process, Vprocess_alist): Remove decls.
10734
ad64fc97
PE
10735 * print.c: Make symbols static if they're not exported.
10736 (print_depth, new_backquote_output, being_printed, print_buffer):
10737 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10738 (print_interval, print_number_index, initial_stderr_stream):
10739 Now static.
10740 * lisp.h (Fprinc): Remove decl.
10741 (debug_output_compilation_hack): Mark as externally visible.
10742
adddb265
PE
10743 * sysdep.c (croak): Move decl from here to syssignal.h.
10744 * syssignal.h (croak): Put it here, so the API can be checked when
10745 'croak' is called from dissociate_if_controlling_tty.
10746
1717ede2
PE
10747 * minibuf.c: Make symbols static if they're not exported.
10748 (minibuf_save_list, choose_minibuf_frame): Now static.
10749 * lisp.h (choose_minibuf_frame): Remove decl.
10750
fa5fb2bc
PE
10751 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10752
1e3890d1
PE
10753 * lread.c: Make symbols static if they're not exported.
10754 (read_objects, initial_obarray, oblookup_last_bucket_number):
10755 Now static.
10756 (make_symbol): Remove; unused.
10757 * lisp.h (initial_obarray, make_symbol): Remove decls.
10758
8a1414fa
PE
10759 * keyboard.c: Make symbols static if they're not exported.
10760 (single_kboard, recent_keys_index, total_keys, recent_keys):
10761 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10762 (this_single_command_key_start, echoing, last_auto_save):
10763 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10764 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10765 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10766 (Vlispy_mouse_stem, double_click_count):
10767 Now static.
10768 (force_auto_save_soon): Define only if SIGDANGER.
10769 (ignore_mouse_drag_p): Now static if
10770 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10771 (print_help): Remove; unused.
10772 (stop_character, last_timer_event): Mark as externally visible.
10773 * keyboard.h (ignore_mouse_drag_p): Declare only if
10774 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10775 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10776 * lisp.h (echoing): Remove decl.
10777 (force_auto_save_soon): Declare only if SIGDANGER.
10778 * xdisp.c (redisplay_window): Simplify code, to make it more
10779 obvious that ignore_mouse_drag_p is not accessed if !defined
10780 USE_GTK && !defined HAVE_NS.
10781
93ea6e8f
PE
10782 * intervals.c: Make symbols static if they're not exported.
10783 (merge_properties_sticky, merge_interval_right, delete_interval):
10784 Now static.
10785 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10786
77382fcc
PE
10787 * insdel.c: Make symbols static if they're not exported.
10788 However, leave prepare_to_modify_buffer alone. It's never
10789 called from outside this function, but that appears to be a bug.
10790 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10791 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10792 (adjust_after_replace_noundo): Remove; unused.
10793 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10794 (signal_before_change): Remove decls.
77382fcc 10795
9306c32e
PE
10796 * indent.c (val_compute_motion, val_vmotion): Now static.
10797
cd44d2eb
PE
10798 * image.c: Make symbols static if they're not exported.
10799 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10800 if USE_GTK.
10801 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10802 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10803
ad9a7a06
PE
10804 * fringe.c (standard_bitmaps): Now static.
10805 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10806
81626931
PE
10807 * frame.c: Make symbols static if they're not exported.
10808 (x_report_frame_params, make_terminal_frame): Now static.
10809 (get_frame_param): Now static, unless HAVE_NS.
10810 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10811 (x_get_resource_string): Remove; not used.
10812 * frame.h (make_terminal_frame, x_report_frame_params):
10813 (x_get_resource_string); Remove decls.
10814 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10815 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10816
239f9db9
PE
10817 * font.c, fontset.c: Make symbols static if they're not exported.
10818 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10819 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10820 * font.c (font_close_object): Now static.
10821 * font.h (font_close_object): Remove.
10822 * fontset.c (FONTSET_OBJLIST): Remove.
10823 (free_realized_fontset) #if-0 the body, which does nothing.
10824 (face_suitable_for_char_p): #if-0, as it's never called.
10825 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10826 * xfaces.c (face_at_string_position):
10827 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10828 since 0 is always ASCII.
10829
dfcf3579
PE
10830 * fns.c (weak_hash_tables): Now static.
10831
5045092b
PE
10832 * fileio.c: Make symbols static if they're not exported.
10833 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10834 (Vwrite_region_annotation_buffers): Now static.
10835
57a96f5c
PE
10836 * eval.c: Make symbols static if they're not exported.
10837 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10838 * lisp.h (backtrace_list): Remove decl.
10839
35f08c38
PE
10840 * emacs.c: Make symbols static if they're not exported.
10841 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10842 (fatal_error_code, fatal_error_signal_hook, standard_args):
10843 Now static.
10844 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10845 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10846 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10847 * lisp.h (fatal_error_signal_hook): Remove decl.
10848 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10849
f44bd759
PE
10850 * editfns.c: Move a (normally-unused) function to its only use.
10851 * editfns.c, lisp.h (get_operating_system_release): Remove.
10852 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10853 worth the hassle of breaking this out.
10854
b532497d
PE
10855 * xterm.c: Make symbols static if they're not exported.
10856 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10857 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10858 (x_destroy_window, x_delete_display):
10859 Now static.
10860 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10861 (x_mouse_leave): Remove; unused.
10862 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10863 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10864 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10865 Remove decls.
10866 (x_mouse_leave): Declare only if WINDOWSNT.
10867 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10868 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10869 USE_X_TOOLKIT.
10870
1675728f
PE
10871 * ftxfont.c: Make symbols static if they're not exported.
10872 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10873 HAVE_FREETYPE.
10874 * font.h (ftxfont_driver): Likewise.
10875
e4cebfca
PE
10876 * xfns.c: Make symbols static if they're not exported.
10877 (x_last_font_name, x_display_info_for_name):
10878 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10879 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10880 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10881 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10882 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10883 (last_show_tip_args): Now static.
10884 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10885 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10886 (x_screen_planes): Remove; unused.
10887 * dispextern.h (x_screen_planes): Remove decl.
10888
5bf46f05
PE
10889 * dispnew.c: Make symbols static if they're not exported.
10890 * dispextern.h (redraw_garbaged_frames, scrolling):
10891 (increment_row_positions): Remove.
10892 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10893 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10894 Now static.
10895 (redraw_garbaged_frames): Remove; unused.
10896
435f4c28
PE
10897 * xfaces.c: Make symbols static if they're not exported.
10898 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10899 Remove decls.
10900 * xterm.h (defined_color): Remove decls.
10901 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10902 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10903 (menu_face_changed_default, defined_color, free_realized_face):
10904 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10905 (ascii_face_of_lisp_face): Remove; unused.
10906
8524aef3
PE
10907 * xdisp.c: Make symbols static if they're not exported.
10908 * dispextern.h (scratch_glyph_row, window_box_edges):
10909 (glyph_to_pixel_coords, set_cursor_from_row):
10910 (get_next_display_element, set_iterator_to_next):
10911 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10912 (show_mouse_face): Remove decls
10913 * frame.h (message_buf_print): Likewise.
10914 * lisp.h (pop_message, set_message, check_point_in_composition):
10915 Likewise.
10916 * xterm.h (set_vertical_scroll_bar): Likewise.
10917 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10918 (message_buf_print, scratch_glyph_row, displayed_buffer):
10919 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10920 (get_next_display_element, show_mouse_face, window_box_edges):
10921 (frame_to_window_pixel_xy, check_point_in_composition):
10922 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10923 (glyph_to_pixel_coords): Remove; unused.
10924
16390cd2
PE
10925 * dired.c (file_name_completion): Now static.
10926
10927 * dbusbind.c (xd_in_read_queued_messages): Now static.
10928
a25f4dfa
PE
10929 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10930 * data.c (circular_list_error): Remove.
10931
14a9c8df
PE
10932 * commands.h (last_point_position, last_point_position_buffer):
10933 (last_point_position_window): Remove decls.
10934 * keyboard.c: Make these variables static.
10935
04f2d78b
CB
10936 * coding.h (coding, code_convert_region, encode_coding_gap):
10937 Remove decls.
74ab6df5
PE
10938 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10939 (iso_code_class, detect_coding, code_convert_region): Now static.
10940 (encode_coding_gap): Remove; unused.
10941
38dfbee1
PE
10942 * chartab.c (chartab_chars, chartab_bits): Now static.
10943
a2cb4e63
PE
10944 * charset.h (charset_iso_8859_1): Remove decl.
10945 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10946 Now static.
10947
127198fd
PE
10948 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10949 * ccl.c (Vccl_program_table): Now static.
10950 (check_ccl_update): Remove; unused.
10951
d85b608f
PE
10952 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10953 * category.h: ... from here.
10954 * category.c (check_category_table, set_category_set): Now static.
10955
31cd66f3
PE
10956 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10957 * lisp.h: Remove these decls.
10958
c358e587
PE
10959 * buffer.c (buffer_count): Remove unused var.
10960
e78aecca
PE
10961 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10962 so that it's not optimized away.
10963 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10964 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10965 exported only to the debugger.
10966
e192d7d3 10967 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10968 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10969
92470028
PE
10970 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10971 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10972 was inaccessible from Lisp.
10973 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10974 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10975
244ed907
PE
10976 alloc.c: Import and export fewer symbols, and remove unused items.
10977 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10978 is defined.
10979 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10980 it's not optimized away by whole-program optimization.
10981 (message_enable_multibyte, free_misc): Remove.
10982 (catchlist, handlerlist, mark_backtrace):
10983 Declare only if BYTE_MARK_STACK.
10984 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10985 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10986 (message_enable_multibyte): Remove decl.
10987 (free_misc, interval_free_list, float_block, float_block_index):
10988 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10989 (cons_free_list, last_marked_index):
10990 Now static.
10991 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10992 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10993 (mark_backtrace): Define only if BYTE_MARK_STACK.
10994 * xdisp.c (message_enable_multibyte): Now static.
10995
61c2b50e 10996 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10997 This makes it easier for human readers (and static analyzers)
10998 to see whether these variables are used from other modules.
10999 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11000 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11001 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11002 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11003 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11004 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11005 * xmenu.c, xselect.c:
11006 Declare Q* vars static if they are not used in other modules.
11007 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11008 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11009 Remove decls of unexported vars.
11010 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11011
95c82688
PE
11012 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11013
16a97296
PE
11014 Make Emacs functions such as Fatom 'static' by default.
11015 This makes it easier for human readers (and static analyzers)
11016 to see whether these functions can be called from other modules.
11017 DEFUN now defines a static function. To make the function external
11018 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11019 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11020 (Finit_image_library):
16a97296
PE
11021 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11022 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11023 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11024 Remove decls, since these functions are now static.
11025 (Funintern, Fget_internal_run_time): New decls, since these functions
11026 were already external.
95c82688 11027
16a97296
PE
11028 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11029 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11030 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11031 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11032 * keyboard.c, keymap.c, lread.c:
11033 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11034 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11035 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11036 Mark functions with DEFUE instead of DEFUN,
11037 if they are used in other modules.
11038 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11039 decls for now-static functions.
11040 * buffer.h (Fdelete_overlay): Remove decl.
11041 * callproc.c (Fgetenv_internal): Mark as internal.
11042 * composite.c (Fremove_list_of_text_properties): Remove decl.
11043 (Fcomposition_get_gstring): New forward static decl.
11044 * composite.h (Fcomposite_get_gstring): Remove decl.
11045 * dired.c (Ffile_attributes): New forward static decl.
11046 * doc.c (Fdocumntation_property): New forward static decl.
11047 * eval.c (Ffetch_bytecode): New forward static decl.
11048 (Funintern): Remove extern decl; now in .h file where it belongs.
11049 * fileio.c (Fmake_symbolic_link): New forward static decl.
11050 * image.c (Finit_image_library): New forward static decl.
11051 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11052 * intervals.h (Fprevious_property_change):
11053 (Fremove_list_of_text_properties): Remove decls.
11054 * keyboard.c (Fthis_command_keys): Remove decl.
11055 (Fcommand_execute): New forward static decl.
11056 * keymap.c (Flookup_key): New forward static decl.
11057 (Fcopy_keymap): Now static.
11058 * keymap.h (Flookup_key): Remove decl.
11059 * process.c (Fget_process): New forward static decl.
11060 (Fprocess_datagram_address): Mark as internal.
11061 * syntax.c (Fsyntax_table_p): New forward static decl.
11062 (skip_chars): Remove duplicate decl.
11063 * textprop.c (Fprevious_property_change): New forward static decl.
11064 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11065 Now internal.
11066 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11067 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11068
785bbd42
PE
11069 * editfns.c (Fformat): Remove unreachable code.
11070
8b913b57
AS
110712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11072
11073 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11074 change. (Bug#8496)
11075
a6744a35
EZ
110762011-04-13 Eli Zaretskii <eliz@gnu.org>
11077
11078 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11079 when at ZV. (Bug#8487)
11080
e7974947
AS
110812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11082
baad03f0
AS
11083 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11084 (Bug#8437)
11085 * keyboard.c (parse_tool_bar_item): Likewise.
11086 * sound.c (sound_cleanup, alsa_close): Likewise.
11087 * termcap.c (tgetent): Likewise.
11088 * xfns.c (x_default_font_parameter): Likewise.
11089 * xsettings.c (read_and_apply_settings): Likewise.
11090
e7974947
AS
11091 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11092 (overrun_check_free): Protoize.
11093
28272684
PE
110942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11095
11096 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11097 since callers should never pass a negative size.
11098 Change the signature to match that of plain 'read' and 'write'; see
11099 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11100 * lisp.h: Update prototypes of emacs_write and emacs_read.
11101
11997c76
EZ
111022011-04-11 Eli Zaretskii <eliz@gnu.org>
11103
11104 * xdisp.c (redisplay_window): Don't try to determine the character
11105 position of the scroll margin if the window start point w->startp
e896f03c 11106 is outside the buffer's accessible region. (Bug#8468)
11997c76 11107
8a2cbd72
EZ
111082011-04-10 Eli Zaretskii <eliz@gnu.org>
11109
11110 Fix write-region and its subroutines for buffers > 2GB.
11111 * fileio.c (a_write, e_write): Modify declaration of arguments and
11112 local variables to support buffers larger than 2GB.
11113 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11114
11115 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11116 argument, local variables, and return value.
11117
11118 * lisp.h: Update prototypes of emacs_write and emacs_read.
11119
11120 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11121
4073e537 111222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11123
1ebfdcb6
PE
11124 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11125
b2ded58d
PE
11126 Fix more problems found by GCC 4.6.0's static checks.
11127
7d66342c
PE
11128 * xdisp.c (vmessage): Use a better test for character truncation.
11129
bbf47d44
PE
11130 * charset.c (load_charset_map): <, not <=, for optimization,
11131 and to avoid potential problems with integer overflow.
9248994d 11132 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11133 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11134 * editfns.c (Fformat): Likewise.
1e69125e 11135 * syntax.c (skip_chars): Likewise.
3befa583 11136
e3019616
PE
11137 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11138 This also lets GCC 4.6.0 generate slightly better loop code.
11139
becfa255
PE
11140 * callint.c (Fcall_interactively): <, not <=, for optimization.
11141 (Fcall_interactively): Count the number of arguments produced,
11142 not the number of arguments given. This is simpler and lets GCC
11143 4.6.0 generate slightly better code.
11144
dae0cd48
PE
11145 * ftfont.c: Distingish more carefully between FcChar8 and char.
11146 The previous code passed unsigned char * to a functions like
11147 strlen and xstrcasecmp that expect char *, which does not
11148 conform to the C standard.
11149 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11150 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11151 char * when the C standard requires it.
11152
76032d70
PE
11153 * keyboard.c (read_char): Remove unused var.
11154
eb3f1cc8
PE
11155 * eval.c: Port to Windows vsnprintf (Bug#8435).
11156 Include <limits.h>.
11157 (SIZE_MAX): Define if the headers do not.
11158 (verror): Do not give up if vsnprintf returns a negative count.
11159 Instead, grow the buffer. This ports to Windows vsnprintf, which
11160 does not conform to C99. Problem reported by Eli Zaretskii.
11161 Also, simplify the allocation scheme, by avoiding the need for
11162 calling realloc, and removing the ALLOCATED variable.
11163
70476b54
PE
11164 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11165
12020a9e
PE
11166 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11167 But keep the doprint source code for now, as we might revamp it
11168 and use it again (Bug#8435).
ea6c7ae6
PE
11169 * lisp.h (doprnt): Remove.
11170 * Makefile.in (base_obj): Remove doprnt.o.
11171 * deps.mk (doprnt.o): Remove.
11172
5fdb398c
PE
11173 error: Print 32- and 64-bit integers portably (Bug#8435).
11174 Without this change, on typical 64-bit hosts error ("...%d...", N)
11175 was used to print both 32- and 64-bit integers N, which relied on
11176 undefined behavior.
61bdb816 11177 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11178 * lisp.h (error, verror): Mark as printf-like functions.
11179 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11180 Report overflow in size calculations when allocating printf buffer.
11181 Do not truncate output string at its first null byte.
11182 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11183 Truncate the output at a character boundary, since vsnprintf does not
11184 do that.
11185 * charset.c (check_iso_charset_parameter): Convert internal
11186 character to string before calling 'error', since %c now has the
11187 printf meaning.
11188 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11189 overflow when computing char to be passed to 'error'. Do not
11190 pass Lisp_Object to 'error'; pass the integer instead.
11191 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11192 formatted with plain %d.
11193
b189fa66
PE
11194 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11195
bff87ef0
PE
11196 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11197
7e2cac20
PE
11198 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11199
ce4d90b5
PE
11200 * xterm.c (x_catch_errors): Remove duplicate declaration.
11201
266c9547
PE
11202 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11203
79c49ad2
PE
11204 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11205
368f4090
JM
112062011-04-10 Jim Meyering <meyering@redhat.com>
11207
11208 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11209 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11210 return ssize_t not "int", and use size_t as the buffer length.
11211 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11212 * gnutls.h: Update declarations.
11213 * process.c (read_process_output): Use ssize_t, to match.
11214 (send_process): Likewise.
11215
a32d4040
CY
112162011-04-09 Chong Yidong <cyd@stupidchicken.com>
11217
11218 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11219
8546720e 112202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11221
04f2d78b
CB
11222 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11223 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11224
8546720e
GM
11225 * xterm.c (handle_one_xevent):
11226 * xmenu.c (create_and_show_popup_menu):
11227 * xselect.c (x_decline_selection_request)
11228 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11229
0a2f5c1a 112302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11231
11232 Fix some uses of `int' instead of EMACS_INT.
11233 * search.c (string_match_1, fast_string_match)
11234 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11235 (scan_buffer, find_next_newline_no_quit)
11236 (find_before_next_newline, search_command, Freplace_match)
11237 (Fmatch_data): Make some `int' variables be EMACS_INT.
11238
11239 * xdisp.c (display_count_lines): 3rd argument and return value now
11240 EMACS_INT. All callers changed.
11241 (pint2hrstr): Last argument is now EMACS_INT.
11242
11243 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11244 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11245 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11246 (decode_coding_utf_16, decode_coding_emacs_mule)
11247 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11248 (decode_coding_ccl, decode_coding_charset)
11249 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11250 (decode_coding_iso_2022, decode_coding_emacs_mule)
11251 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11252 <char_offset, last_offset>: Declare EMACS_INT.
11253 (encode_coding_utf_8, encode_coding_utf_16)
11254 (encode_coding_emacs_mule, encode_invocation_designation)
11255 (encode_designation_at_bol, encode_coding_iso_2022)
11256 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11257 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11258 Declare EMACS_INT.
11259 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11260 (encode_invocation_designation): Last argument P_NCHARS is now
11261 EMACS_INT.
11262 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11263 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11264
11265 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11266 All users changed.
11267
11268 * ccl.c (Fccl_execute_on_string): Declare some variables
11269 EMACS_INT.
11270
8546720e 112712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11272
11273 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11274
4e19a977
CS
112752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11276
11277 * process.c (Fformat_network_address): Doc fix.
11278
87302331
R
112792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11280
ee7683eb 11281 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11282
cbb59342
CY
112832011-04-08 Chong Yidong <cyd@stupidchicken.com>
11284
11285 * keyboard.c (read_char): Call Lisp function help-form-show,
11286 instead of using internal_with_output_to_temp_buffer.
11287 (Qhelp_form_show): New var.
e0d38eeb 11288 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11289
11290 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11291
11292 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11293
e67a13ab
CY
112942011-04-06 Chong Yidong <cyd@stupidchicken.com>
11295
04f2d78b
CB
11296 * process.c (Flist_processes): Remove to Lisp.
11297 (list_processes_1): Delete.
e67a13ab 11298
973f782d
EZ
112992011-04-06 Eli Zaretskii <eliz@gnu.org>
11300
7c106b1e
EZ
11301 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11302
973f782d
EZ
11303 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11304
41cf7d1a 113052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11306
ca23cc88
PE
11307 Fix more problems found by GCC 4.6.0's static checks.
11308
f390e2d5
PE
11309 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11310
42eea0d0
PE
11311 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11312
b69769da 11313 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11314
f9541e84
PE
11315 * xdisp.c (vmessage): Mark as a printf-like function.
11316
13841b55
PE
11317 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11318
c136c10f
PE
11319 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11320
5e2d4a30
PE
11321 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11322 printf-like functions.
11323 (tiff_load): Add casts to remove these marks before passing them
11324 to system-supplied API.
11325
583f48b9
PE
11326 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11327
b25d760e
PE
11328 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11329 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11330 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11331 directly, rather than having caller test rule sign. This avoids
11332 some unnecessary tests.
11333 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11334 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11335 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11336
bc7b6697 11337 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11338 (xfont_open): Avoid unnecessary tests.
bc7b6697 11339
27ccc379
PE
11340 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11341
dcd5c89a
PE
11342 * composite.h, composite.c (composition_gstring_put_cache):
11343 Use EMACS_INT, not int, for length.
11344
b13a45c6
PE
11345 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11346 breaking out part of COMPOSITION_DECODE_RULE.
11347 (COMPOSITION_DECODE_RULE): Use it.
11348 * composite.c (get_composition_id): Remove unused local vars,
11349 by using the new macro.
11350
1e792e4d
PE
11351 * textprop.c (set_text_properties_1): Change while to do-while,
11352 since the condition is always true at first.
11353
dc6c6455 11354 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11355 (interval_deletion_adjustment): Return unsigned value.
11356 All uses changed.
dc6c6455 11357
aba7731a
PE
11358 * process.c (list_processes_1, create_pty, read_process_output):
11359 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11360 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11361 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11362 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11363 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11364
fdfc4bf3
PE
11365 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11366
fca8fe46 11367 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11368 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11369
06a0259a 11370 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11371 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11372 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11373
e7b9e80f
PE
11374 * print.c (print_error_message): Avoid int overflow.
11375
56201685
PE
11376 * font.c (font_list_entities): Redo for clarity,
11377 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11378
78834453 11379 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11380 (font_score): Avoid potential overflow in diff calculation.
78834453 11381
0bc0b309 11382 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11383 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11384
e610eaca
PE
11385 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11386
b895abce
PE
11387 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11388 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11389 can always succeed if overflow has undefined behavior.
11390
1f1d9321 11391 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11392 (wordify): Omit three unnecessary tests.
1f1d9321 11393
c59478bc
PE
11394 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11395 All callers changed. This avoids the need for an unused var.
11396
79b73827
PE
11397 * casefiddle.c (casify_region): Remove var that is set but not used.
11398
a4db5dfe
PE
11399 * dired.c (file_name_completion): Remove var that is set but not used.
11400
43aae36e
PE
11401 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11402
2a47c44d 11403 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11404 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11405
a37c69bf
PE
11406 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11407 Check for integer overflow on size calculations.
11408
328ab8e7
PE
11409 * buffer.c (Fprevious_overlay_change): Remove var that is set
11410 but not used.
11411
e5a2a5cb
PE
11412 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11413 Remove vars that are set but not used.
8d84a6eb 11414 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11415 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11416
a60e5f68
PE
11417 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11418
f661cb61 11419 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11420 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11421
f0397f5a
PE
11422 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11423 that are set but not used.
11424
8664db06 11425 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11426 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11427
6abdaa4a
PE
11428 * xselect.c (x_get_local_selection, x_handle_property_notify):
11429 Remove vars that are set but not used.
11430
0ce7538d 11431 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11432 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11433
9ae848fc
PE
11434 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11435 Remove var that is set but not used.
0b918413
PE
11436 (scroll_bar_windows_size): Now size_t, not int.
11437 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11438 Check for overflow.
9ae848fc 11439
a5a62657
PE
11440 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11441 (map_tty_color) [!defined MSDOS]: Likewise.
11442
5c5cdd39
PE
11443 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11444
66ebf983
PE
11445 * coding.c: Remove vars that are set but not used.
11446 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11447 All callers changed.
11448 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11449 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11450 (decode_coding_charset): Remove vars that are set but not used.
11451
1be4d761
PE
11452 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11453 that is set but not used.
11454
47553fa8
PE
11455 * print.c (print_object): Remove var that is set but not used.
11456
1f7196bf 11457 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11458 The gnulib version avoids calling malloc in the usual case,
11459 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11460 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11461 * filelock.c (current_lock_owner): Likewise.
11462 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11463 * sysdep.c: Include allocator.h, careadlinkat.h.
11464 (emacs_no_realloc_allocator): New static constant.
11465 (emacs_readlink): New function.
fdb61804
PE
11466 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11467 ../lib/careadlinkat.h.
d1fdcab7 11468
f84c17c7
SM
114692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11470
11471 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11472 first non-nil return value).
11473
ef3862ad
JD
114742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11475
11476 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11477 if not defined (Bug#8403).
11478
376a7006
JB
114792011-04-02 Juanma Barranquero <lekktu@gmail.com>
11480
11481 * xdisp.c (display_count_lines): Remove parameter `start',
11482 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11483 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11484 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11485 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11486 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11487 and thereabouts. All callers changed.
11488 (get_per_char_metric): Remove parameter `f', unused since
11489 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11490
6ca3801d
JM
114912011-04-02 Jim Meyering <meyering@redhat.com>
11492
11493 do not dereference NULL upon failed strdup
11494 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11495 (ns_get_family): Likewise.
11496
d8e2b5ba
JB
114972011-04-02 Juanma Barranquero <lekktu@gmail.com>
11498
11499 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11500
8c74fcbd
JD
115012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11502
11503 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11504 later (Bug#8403).
11505
7200d79c
SM
115062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11507
03408648 11508 Add lexical binding.
7200d79c 11509
03408648
SM
11510 * window.c (Ftemp_output_buffer_show): New fun.
11511 (Fsave_window_excursion):
11512 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11513
11514 * lread.c (lisp_file_lexically_bound_p): New function.
11515 (Fload): Bind Qlexical_binding.
11516 (readevalloop): Remove `evalfun' arg.
11517 Bind Qinternal_interpreter_environment.
11518 (Feval_buffer): Bind Qlexical_binding.
11519 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11520 Mark as dynamic.
11521 (syms_of_lread): Declare `lexical-binding'.
11522
11523 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11524
11525 * keyboard.c (eval_dyn): New fun.
11526 (menu_item_eval_property): Use it.
ca105506
SM
11527
11528 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11529
03408648
SM
11530 * fns.c (concat, mapcar1): Accept byte-code-functions.
11531
11532 * eval.c (Fsetq): Handle lexical vars.
11533 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11534 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11535 (FletX, Flet): Obey lexical binding.
11536 (Fcommandp): Handle closures.
11537 (Feval): New `lexical' arg.
11538 (eval_sub): New function extracted from Feval. Use it almost
11539 everywhere where Feval was used. Look up vars in lexical env.
11540 Handle closures.
11541 (Ffunctionp): Move from subr.el.
11542 (Ffuncall): Handle closures.
11543 (apply_lambda): Remove `eval_flags'.
11544 (funcall_lambda): Handle closures and new byte-code-functions.
11545 (Fspecial_variable_p): New function.
11546 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11547 but without exporting it to Lisp.
23aba0ea 11548
23aba0ea 11549 * doc.c (Fdocumentation, store_function_docstring):
03408648 11550 * data.c (Finteractive_form): Handle closures.
23aba0ea 11551
03408648
SM
11552 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11553 interactive spec.
ba83908c 11554
04f2d78b
CB
11555 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11556 New byte-codes.
03408648
SM
11557 (exec_byte_code): New function extracted from Fbyte_code to handle new
11558 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11559
03408648 11560 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11561
03408648 11562 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11563
e2abce01
JB
115642011-03-31 Juanma Barranquero <lekktu@gmail.com>
11565
11566 * xdisp.c (redisplay_internal): Fix prototype.
11567
63696a73 115682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11569
63696a73 11570 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11571 (try_scrolling): Use it when setting scroll_limit.
11572 Limit scrolling to 100 screen lines.
63696a73
EZ
11573 (redisplay_window): Even when falling back on "recentering",
11574 position point in the window according to scroll-conservatively,
11575 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11576
11577 (try_scrolling): When point is above the window, allow searching
11578 as far as scroll_max, or one screenful, to compute vertical
11579 distance from PT to the scroll margin position. This prevents
11580 try_scrolling from unnecessarily failing when
11581 scroll-conservatively is set to a value slightly larger than the
11582 window height. Clean up the case of PT below the margin at bottom
11583 of window: scroll_max can no longer be INT_MAX. When aggressive
11584 scrolling is in use, don't let point enter the opposite scroll
11585 margin as result of the scroll.
11586 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11587 threshold of 100 lines for never-recentering scrolling.
11588
e4cc2dfc
JB
115892011-03-31 Juanma Barranquero <lekktu@gmail.com>
11590
11591 * dispextern.h (move_it_by_lines):
11592 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11593 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11594 (message_log_check_duplicate): Remove parameters `prev_bol' and
11595 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11596 (redisplay_internal): Remove parameter `preserve_echo_area',
11597 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11598
11599 * indent.c (Fvertical_motion):
11600 * window.c (window_scroll_pixel_based, Frecenter):
11601 Don't pass `need_y_p' to `move_it_by_lines'.
11602
1c470562
SM
116032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11604
44f230aa
SM
11605 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11606 steal a few bits to be more compact.
11607 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11608 Remove unneeded casts.
11609
1c470562
SM
11610 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11611
888adce9
ZK
116122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11613
11614 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11615 binding" message (bug#7967).
11616
f838ed7b
PE
116172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11618
77861b95
PE
11619 Fix more problems found by GCC 4.6.0's static checks.
11620
de6dbc14
PE
11621 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11622 Remove unused local var.
11623
f838ed7b
PE
11624 * editfns.c (Fmessage_box): Remove unused local var.
11625
792c7b2b
PE
11626 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11627 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11628 Omit unused local vars.
c499e557 11629 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11630 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11631 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11632 Omit unused local var.
11633
ba0165e1
PE
11634 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11635 Don't assume string length fits in int.
32ad8845 11636 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11637 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11638
3c59b4c9
PE
11639 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11640 instead of alloca (Bug#8344).
11641
a3eed478 11642 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11643 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11644
eb4d412d
PE
11645 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11646
1658b401
PE
11647 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11648 concerns.
11649
11650 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11651
11652 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11653
9a2c6e05
PE
11654 * keyboard.c (syms_of_keyboard): Use the same style as later
11655 in this function when indexing through an array. This also
11656 works around GCC bug 48267.
11657
03d0a109
PE
11658 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11659
44f730c8
PE
11660 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11661
fe75f926
PE
11662 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11663 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11664
ffa8c828
PE
11665 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11666 This avoids undefined behavior on integer overflow, and is a bit
11667 more convenient anyway since it is compared to a size_t variable.
11668
c5101a77
PE
11669 Variadic C functions now count arguments with size_t, not int.
11670 This avoids an unnecessary limitation on 64-bit machines, which
11671 caused (substring ...) to crash on large vectors (Bug#8344).
11672 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11673 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11674 All variadic functions and their callers changed accordingly.
c5101a77
PE
11675 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11676 * data.c (arith_driver, float_arith_driver): Likewise.
11677 * editfns.c (general_insert_function): Likewise.
11678 * eval.c (struct backtrace.nargs, interactive_p)
11679 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11680 (funcall_lambda, mark_backtrace): Likewise.
11681 * fns.c (concat): Likewise.
11682 * frame.c (x_set_frame_parameters): Likewise.
11683 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11684 0 if not found, not -1. All callers changed.
11685
dd3f25f7
PE
11686 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11687 (stack_copy_size): Now size_t, not int.
11688 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11689
461c2ab9
JB
116902011-03-28 Juanma Barranquero <lekktu@gmail.com>
11691
11692 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11693 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11694 All callers changed.
11695
11696 * lisp.h (multibyte_char_to_unibyte):
11697 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11698 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11699 * character.h (CHAR_TO_BYTE8):
11700 * cmds.c (internal_self_insert):
11701 * editfns.c (general_insert_function):
11702 * keymap.c (push_key_description):
11703 * search.c (Freplace_match):
11704 * xdisp.c (message_dolog, set_message_1): All callers changed.
11705
f6d62986
SM
117062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11707
11708 * keyboard.c (safe_run_hook_funcall): New function.
11709 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11710 don't set the hook to nil, but remove the offending function instead.
11711 (Qcommand_hook_internal): Remove, unused.
11712 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11713 Vcommand_hook_internal.
11714
11715 * eval.c (enum run_hooks_condition): Remove.
11716 (funcall_nil, funcall_not): New functions.
11717 (run_hook_with_args): Call each function through a `funcall' argument.
11718 Remove `cond' argument, now redundant.
11719 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11720 (Frun_hook_with_args_until_failure): Adjust accordingly.
11721 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11722
1db5b1ad
JB
117232011-03-28 Juanma Barranquero <lekktu@gmail.com>
11724
11725 * dispextern.h (string_buffer_position): Remove declaration.
11726
11727 * print.c (strout): Remove parameter `multibyte', unused since
11728 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11729
11730 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11731 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11732 All callers changed.
11733
11734 * w32.c (_wsa_errlist): Use braces for struct initializers.
11735
11736 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11737 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11738 All callers changed.
11739 (string_buffer_position): Likewise. Also, make static (it's never
11740 used outside xdisp.c).
11741 (cursor_row_p): Remove parameter `w', unused since
11742 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11743 (decode_mode_spec): Remove parameter `precision', introduced during
11744 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11745 All callers changed.
11746
5ffb62aa
JD
117472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11748
11749 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11750
461c2ab9 117512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11752
11753 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11754 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11755 (ns_update_auto_hide_menu_bar): New functions.
11756 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11757 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11758 ns_constrain_all_frames.
11759 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11760 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11761
5c380ffb
JD
117622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11763
11764 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11765
9af30bdf
GM
117662011-03-27 Glenn Morris <rgm@gnu.org>
11767
11768 * syssignal.h: Replace RETSIGTYPE with void.
11769 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11770 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11771 Replace SIGTYPE with void everywhere.
11772 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11773 * s/template.h (SIGTYPE): Remove commented out definition.
11774
e2abce01
JB
117752011-03-26 Eli Zaretskii <eliz@gnu.org>
11776
11777 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11778 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11779
f868cd8a
JB
117802011-03-26 Juanma Barranquero <lekktu@gmail.com>
11781
59eb0929
JB
11782 * w32.c (read_unc_volume): Use parameter `henum', instead of
11783 global variable `wget_enum_handle'.
11784
11785 * keymap.c (describe_vector): Remove parameters `indices' and
11786 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11787 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11788
f868cd8a
JB
11789 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11790
11791 * keyboard.c (timer_check): Remove parameter `do_it_now',
11792 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11793 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11794 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11795
11796 * keyboard.c (read_char):
11797 * w32menu.c (w32_menu_display_help):
11798 * xmenu.c (show_help_event, menu_help_callback):
11799 Adjust calls to `show_help_echo'.
11800
11801 * gtkutil.c (xg_maybe_add_timer):
11802 * keyboard.c (readable_events):
11803 * process.c (wait_reading_process_output):
11804 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11805
11806 * insdel.c (adjust_markers_gap_motion):
11807 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11808 (gap_left, gap_right): Don't call it.
11809
2ecf6fdb
CY
118102011-03-25 Chong Yidong <cyd@stupidchicken.com>
11811
11812 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11813 incurred during fontification.
11814
6b1f9ba4
JB
118152011-03-25 Juanma Barranquero <lekktu@gmail.com>
11816
11817 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11818 (DEFVAR_PER_BUFFER): Don't pass it.
11819
11820 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11821 (scrolling_window): Don't pass it.
11822
0f4a96b5
JB
118232011-03-25 Juanma Barranquero <lekktu@gmail.com>
11824
11825 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11826
11827 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11828 and `suffix'.
11829 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11830 of variables specific to SELinux and computation of `encoded_absname'.
11831
11832 * image.c (XPutPixel): Remove unused variable `height'.
11833
11834 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11835
11836 * unexw32.c (get_section_info): Remove unused variable `section'.
11837
11838 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11839 (system_process_attributes): Remove unused variable `sess'.
11840 (sys_read): Remove unused variable `err'.
11841
11842 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11843 (w32_wnd_proc): Remove unused variable `isdead'.
11844 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11845 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11846 (x_create_tip_frame): Remove unused variable `tem'.
11847
11848 * w32inevt.c (w32_console_read_socket):
11849 Remove unused variable `no_events'.
11850
11851 * w32term.c (x_draw_composite_glyph_string_foreground):
11852 Remove unused variable `width'.
11853
1149507c
JB
118542011-03-24 Juanma Barranquero <lekktu@gmail.com>
11855
11856 * w32term.c (x_set_glyph_string_clipping):
11857 Don't pass uninitialized region to CombineRgn.
11858
9c88f339
JB
118592011-03-23 Juanma Barranquero <lekktu@gmail.com>
11860
11861 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11862 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11863 (Fx_close_connection): Remove unused variable `i'.
11864
11865 * w32font.c (w32font_draw): Return number of glyphs.
11866 (w32font_open_internal): Remove unused variable `i'.
11867 (w32font_driver): Add missing initializer.
11868
11869 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11870 (fill_in_menu): Remove unused variable `items_added'.
11871
11872 * w32term.c (last_mouse_press_frame): Remove static global variable.
11873 (w32_clip_to_row): Remove unused variable `f'.
11874 (x_delete_terminal): Remove unused variable `i'.
11875
11876 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11877 (NOTHING): Remove unused static global variable.
11878 (uniscribe_check_otf): Remove unused variable `table'.
11879 (uniscribe_font_driver): Add missing initializers.
11880
dee091a3
JD
118812011-03-23 Julien Danjou <julien@danjou.info>
11882
11883 * term.c (Fsuspend_tty, Fresume_tty):
11884 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11885 * window.c (temp_output_buffer_show):
11886 * insdel.c (signal_before_change):
11887 * frame.c (Fhandle_switch_frame):
11888 * fileio.c (Fdo_auto_save):
11889 * emacs.c (Fkill_emacs):
11890 * editfns.c (save_excursion_restore):
11891 * cmds.c (internal_self_insert):
11892 * callint.c (Fcall_interactively):
11893 * buffer.c (Fkill_all_local_variables):
11894 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11895 Use Frun_hooks.
0f4a96b5 11896 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11897 unconditionally since it does the check itself.
dee091a3 11898
2c520ab5 118992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11900
c9c49752
PE
11901 Fix more problems found by GCC 4.5.2's static checks.
11902
8abc3f12
PE
11903 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11904 the first time through the loop, since we know p0 < p1 then.
11905 This also avoids a gcc -Wstrict-overflow warning.
11906
a2d26660
PE
11907 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11908 leading to a memory leak, possible in functions like
11909 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11910 of objects (Bug#8318).
a2d26660 11911
916c72e9
PE
11912 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11913 that could (at least in theory) be that large.
11914
19ab8a18
PE
11915 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11916 This is less likely to overflow, and avoids undefined behavior if
11917 overflow does occur. All callers changed. Use strtoul to scan
11918 for the unsigned long integer.
b7cbbd6f
PE
11919 (pint2hrstr): Simplify and tune code slightly.
11920 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11921
f0641eff
PE
11922 * scroll.c (do_scrolling): Work around GCC bug 48228.
11923 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11924
7f650bb9
PE
11925 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11926 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11927 (validate_x_resource_name): Simplify count usage.
11928 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11929
37dd57d1
PE
11930 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11931 fail (Bug#8306).
81e56e61 11932
699979fc 11933 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11934
401bf9b4
PE
11935 * process.c (Fmake_network_process): Use socklen_t, not int,
11936 where POSIX says socklen_t is required in portable programs.
11937 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11938 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11939 (Fmake_network_process, server_accept_connection):
11940 (wait_reading_process_output, read_process_output):
11941 Likewise.
11942
b93aacde
PE
11943 * process.c: Rename or move locals to avoid shadowing.
11944 (list_processes_1, Fmake_network_process):
11945 (read_process_output_error_handler, exec_sentinel_error_handler):
11946 Rename or move locals.
4dc343ee 11947 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11948 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11949 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11950 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11951 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11952
af8a867c 11953 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11954 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11955 Include tparam.h instead, since it declares them.
af8a867c
PE
11956 * cm.h (PC): Remove extern decl; tparam.h now does this.
11957 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11958 * terminfo.c: Include tparam.h, to check interfaces.
11959 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11960 (tparam): Adjust signature to match interface in tparam.h;
11961 this removes some undefined behavior. Check that outstring and len
11962 are zero, which they always are with Emacs.
11963 * tparam.h (PC, BC, UP): New extern decls.
11964
0248044d 11965 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11966 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11967
8ff096c1 11968 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11969 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11970 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11971 (ftfont_list): Remove unused local.
49eaafba
PE
11972 (get_adstyle_property, ftfont_pattern_entity):
11973 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11974 Rename locals to avoid shadowing.
8ff096c1 11975
e2be39f6
PE
11976 * xfont.c (xfont_list_family): Mark var as initialized.
11977
c9735e30
PE
11978 * xml.c (make_dom): Now static.
11979
8f5201ae
PE
11980 * composite.c (composition_compute_stop_pos): Rename local to
11981 avoid shadowing.
b246f932
PE
11982 (composition_reseat_it): Remove unused locals.
11983 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11984 (composition_update_it): Mark var as initialized.
11b61122
PE
11985 (find_automatic_composition): Mark vars as initialized,
11986 with a FIXME (Bug#8290).
8f5201ae 11987
760fbc2c
PE
11988 character.h: Rename locals to avoid shadowing.
11989 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11990 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11991 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11992 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11993 to avoid shadowing.
11994
ff08eb85
PE
11995 * textprop.c (property_change_between_p): Remove; unused.
11996
fc7bf025
PE
11997 * intervals.c (interval_start_pos): Now static.
11998
235d7abc
PE
11999 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12000
44f230aa
SM
12001 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12002 Rename locals to avoid shadowing.
3e7d6594 12003
50060332
PE
12004 * sound.c (wav_play, au_play, Fplay_sound_internal):
12005 Fix pointer signedness.
d01f234b 12006 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12007 (wav_play): Initialize a variable to 0, to prevent undefined
12008 behavior (Bug#8278).
50060332 12009
c4fc4e30
PE
12010 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12011
918436ed
PE
12012 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12013
c939f91b
PE
12014 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12015 clobbering (Bug#8298).
b9c7f648
PE
12016 * sysdep.c (sys_subshell): Likewise.
12017 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12018
6bd8c144
PE
12019 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12020 This should get cleaned up, so that child_setup has the
12021 same signature on all platforms.
12022
7710357c 12023 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12024 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12025
c59da222
CY
120262011-03-22 Chong Yidong <cyd@stupidchicken.com>
12027
12028 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12029 not to be necessary, and produces flickering.
12030
66b87493
GM
120312011-03-20 Glenn Morris <rgm@gnu.org>
12032
12033 * config.in: Remove file.
12034
45b6f6d5
JB
120352011-03-20 Juanma Barranquero <lekktu@gmail.com>
12036
12037 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12038 are now in src/globals.h.
12039 (syms_of_minibuf): Remove spurious & from previous change.
12040
cd394be1 120412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12042
12043 * minibuf.c (completing-read-function): New variable.
12044 (completing-read-default): Rename from completing-read.
12045 (completing-read): Call completing-read-function.
12046
b14e3e21
CY
120472011-03-19 Juanma Barranquero <lekktu@gmail.com>
12048
12049 * xfaces.c (Fx_load_color_file):
12050 Read color file from absolute filename (bug#8250).
12051
f2b726e6
JB
120522011-03-19 Juanma Barranquero <lekktu@gmail.com>
12053
12054 * makefile.w32-in: Update dependencies.
12055
09f6ff02
EZ
120562011-03-17 Eli Zaretskii <eliz@gnu.org>
12057
12058 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12059
29a6015a
PE
120602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12061
a3a6c54e
PE
12062 Fix more problems found by GCC 4.5.2's static checks.
12063
b766f867
PE
12064 * process.c (make_serial_process_unwind, send_process_trap):
12065 (sigchld_handler): Now static.
12066
be02381c
PE
12067 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12068 That way, the code declares only the vars that it needs.
12069 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12070 * s/cygwin.h (PTY_ITERATION): Likewise.
12071 * s/darwin.h (PTY_ITERATION): Likewise.
12072 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12073
57048744
PE
12074 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12075 * process.c (allocate_pty): Don't declare stb unless it's needed.
12076
7914961c 12077 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12078 (CONSTANTLIM): Remove; unused.
12079 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12080 Define only if needed.
7914961c 12081
b3967b18
PE
12082 * unexelf.c (unexec): Name an expression,
12083 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12084 Use a different way to cause a compilation error if anyone uses
12085 n rather than nn, a way that does not involve shadowing.
73366a00 12086 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12087
29a6015a
PE
12088 * deps.mk (unexalpha.o): Remove; unused.
12089
43cfc33e 12090 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12091 * unexec.h: New file.
ce701a33
PE
12092 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12093 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12094 Depend on unexec.h.
12095 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12096 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12097 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12098 Change as necessary to match prototype in unexec.h.
ce701a33 12099
01f44d5a
PE
12100 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12101 shadowing.
4f63c6bb 12102 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12103
a6670b0b
PE
12104 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12105 Rename locals to avoid shadowing.
12106
cef2010d 12107 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12108 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12109
d4d7173a
PE
12110 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12111
f08b802a
PE
12112 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12113 warning when compiling print.c.
12114
3ddb0639
PE
12115 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12116 instead of using an uninitialized var.
5ad03b97 12117 (font_sort_entities): Mark var as initialized.
3ddb0639 12118
170a2692
PE
12119 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12120
e663c700
PE
12121 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12122 pointers to constants.
89bc529a 12123 (font_parse_fcname): Remove unused vars.
7b81e2d0 12124 (font_delete_unmatched): Now static.
ea838e10 12125 (font_get_spec): Remove; unused.
13a547c6
PE
12126 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12127 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12128 Rename or move locals to avoid shadowing.
e663c700 12129
2a80c887 12130 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12131 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12132
1384fa33 12133 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12134 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12135
8b2c52e9
PE
12136 * alloc.c (mark_backtrace): Move decl from here ...
12137 * lisp.h: ... to here, so that it can be checked.
12138
475545b5 12139 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12140 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12141 (lisp_indirect_variable): Name an expression,
12142 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12143 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12144
b1349114 12145 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12146 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12147 Use const pointer when appropriate.
b1349114 12148
a2928364
PE
12149 * lisp.h (get_system_name, get_operating_system_release):
12150 Move decls here, to check interfaces.
12151 * process.c (get_operating_system_release): Move decl to lisp.h.
12152 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12153 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12154 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12155 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12156 (Fformat_time_string, Fencode_time, Finsert_char):
12157 (Ftranslate_region_internal, Fformat):
12158 Rename or remove local vars to avoid shadowing.
9710023e 12159 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12160
a415e694
PE
12161 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12162 avoid shadowing.
12163
8ef4622d
PE
12164 * lisp.h (eassert): Check that the argument compiles, even if
12165 ENABLE_CHECKING is not defined.
12166
946f9a5b
PE
12167 * data.c (Findirect_variable): Name an expression, to avoid
12168 gcc -Wbad-function-cast warning.
112396d6 12169 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12170 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12171 (Fmake_variable_buffer_local, Fmake_local_variable):
12172 Mark variables as initialized.
52746918 12173 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12174
e5aab7e7 12175 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12176 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12177 Rename locals to avoid shadowing.
dff45157
PE
12178 (mark_stack): Move local variables into the #ifdef region where
12179 they're used.
7bc26fdb
PE
12180 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12181 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12182 needed otherwise.
12183 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12184 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12185 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12186
e5aab7e7
PE
12187 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12188 avoids undefined behavior in theory.
12189
4da60324
PE
12190 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12191
88043301
PE
12192 Use functions, not macros, for up- and down-casing (Bug#8254).
12193 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12194 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12195 to use the following functions instead of these macros.
12196 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12197 EMACS_INT, since callers assume the returned value fits in int.
12198 (upcase1): Likewise, for UPCASE_TABLE.
12199 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12200 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12201 the race-condition problem in the old DOWNCASE.
88043301 12202
19ed5445
PE
12203 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12204 Rename locals to avoid shadowing.
12205 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12206 (regex_compile, re_search_2, re_match_2_internal):
12207 Remove unused local vars.
952db0d7
PE
12208 (FREE_VAR): Rewrite so as not to use empty "else",
12209 which gcc can warn about.
da053e48 12210 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12211 (RETALLOC_IF): Define only if needed.
12212 (WORDCHAR_P): Likewise. This one is never needed, but is used
12213 only in a comment talking about a compiler bug, so put inside
12214 the #if 0 of that comment.
12215 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12216 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12217 Remove; unused.
19ed5445 12218
1f3561e4 12219 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12220 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12221 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12222
ded6f8f7
PE
12223 * search.c (simple_search): Remove unused var.
12224
dbd37a95
PE
12225 * dired.c (compile_pattern): Move decl from here ...
12226 * lisp.h: ... to here, so that it can be checked.
12227 (struct re_registers): New forward decl.
12228
7e47afad
PE
12229 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12230
85f24f61
PE
12231 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12232 All uses changed.
12233 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12234 Rename locals to avoid shadowing.
5671df8f 12235 (Fvertical_motion): Mark locals as initialized.
85f24f61 12236
181aa2be 12237 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12238 (casify_region): Mark local as initialized.
181aa2be 12239
930d429c
PE
12240 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12241
7082eac6
PE
12242 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12243 New macros, so that the caller can use some names other than
12244 gcpro1, gcpro2, etc.
12245 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12246 of the new macros.
12247 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12248 argument, for consistency with GCPRO2_VAR, etc: it is now the
12249 prefix of the variable, not the variable itself. All uses
12250 changed.
38b2c076
PE
12251 * dired.c (directory_files_internal, file_name_completion):
12252 Rename locals to avoid shadowing.
12253
15206ed9
PE
12254 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12255 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12256 dired.c's scmp function, had undefined behavior.
12257 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12258 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12259 * buffer.h: ... to here, because these macros use current_buffer,
12260 and the new implementation with inline functions needs to have
12261 current_buffer in scope now, rather than later when the macros
12262 are used.
12263 (downcase, upcase1): New static inline functions.
12264 (DOWNCASE, UPCASE1): Reimplement using these functions.
12265 This avoids undefined behavior in expressions like
12266 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12267 from race conditions in accessing the global variables
12268 case_temp1 and case_temp2.
12269 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12270 * lisp.h (case_temp1, case_temp2): Remove their decls.
12271 * character.h (ASCII_CHAR_P): Move from here ...
12272 * lisp.h: ... to here, so that the inline functions mentioned
12273 above can use them.
12274
4a6bea26
PE
12275 * dired.c (directory_files_internal_unwind): Now static.
12276
f14b7e14
PE
12277 * fileio.c (file_name_as_directory, directory_file_name):
12278 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12279 Now static.
2893f146
PE
12280 (file_name_as_directory): Use const pointers when appropriate.
12281 (Fexpand_file_name): Likewise. In particular, newdir might
12282 point at constant storage, so make it a const pointer.
fd4ead52 12283 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12284 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12285 signedness issues.
f839df0c
PE
12286 (Fset_file_times, Finsert_file_contents, auto_save_error):
12287 Rename locals to avoid shadowing.
f14b7e14 12288
5716756e 12289 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12290 (Ftry_completion, Fall_completions): Rename or remove locals
12291 to avoid shadowing.
5716756e 12292
b4c3046a
PE
12293 * marker.c (bytepos_to_charpos): Remove; unused.
12294
b45db522
PE
12295 * lisp.h (verify_bytepos, count_markers): New decls,
12296 so that gcc does not warn that these functions aren't declared.
12297
85876d07
PE
12298 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12299 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12300 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12301 (copy_text): Remove unused local var.
85876d07 12302
03d78a21 12303 * filelock.c (within_one_second): Now static.
b3dd38ab 12304 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12305
5df8f01b
PE
12306 * buffer.c (fix_overlays_before): Mark locals as initialized.
12307 (fix_start_end_in_overlays): Likewise. This function should be
12308 simplified by using pointers-to-pointers, but that's a different
12309 matter.
b1d876f1 12310 (switch_to_buffer_1): Now static.
8f54f30a
PE
12311 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12312 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12313
a70072c9 12314 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12315 Fix pointer signedness issue.
edced198
PE
12316 (sys_subshell): Mark local as volatile if checking for lint,
12317 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12318 (MAXPATHLEN): Define only if needed.
a70072c9 12319
a0977c44
PE
12320 * process.c (serial_open, serial_configure): Move decls from here ...
12321 * systty.h: ... to here, so that they can be checked.
12322
a884fdcc
PE
12323 * fns.c (get_random, seed_random): Move extern decls from here ...
12324 * lisp.h: ... to here, so that they can be checked.
12325
604efe86 12326 * sysdep.c (reset_io): Now static.
b8950c94 12327 (wait_for_termination_signal): Remove; unused.
604efe86 12328
38fc62d9
PE
12329 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12330 (copy_keymap_item, append_key, push_text_char_description):
12331 Now static.
1004a21a 12332 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12333 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12334 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12335 (describe_map_tree):
12336 Rename locals to avoid shadowing.
38fc62d9 12337
2f2650da
PE
12338 * keyboard.c: Declare functions static if they are not used elsewhere.
12339 (echo_char, echo_dash, cmd_error, top_level_2):
12340 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12341 (read_char, kbd_buffer_get_event, make_lispy_position):
12342 (make_lispy_event, make_lispy_movement, apply_modifiers):
12343 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12344 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12345 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12346 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12347 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12348
a053e86c 12349 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12350 (mark_kboards): Move decl here ...
12351 * alloc.c (mark_kboards): ... from here.
a053e86c 12352
4752793e
PE
12353 * lisp.h (force_auto_save_soon): New decl.
12354
74f10ca7 12355 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12356 (DEFINE_DUMMY_FUNCTION): New macro.
12357 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12358 Use it.
c03cd23f
PE
12359 (main): Add casts to avoid warnings
12360 if GCC considers string literals to be constants.
74f10ca7 12361
022e70d4
PE
12362 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12363
59d6fe83
PE
12364 * dbusbind.c: Pointer signedness fixes.
12365 (xd_signature, xd_append_arg, xd_initialize):
12366 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12367 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12368 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12369 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12370
78320123
PE
12371 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12372 if GCC considers string literals to be constants.
49cebcca 12373 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12374
35ac2a97
SM
123752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12376
fb103ca9
SM
12377 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12378 (print_preprocess, print_object): New macro to fix last change.
12379
35ac2a97
SM
12380 * print.c (print_preprocess): Don't forget font objects.
12381
62973b41
JB
123822011-03-16 Juanma Barranquero <lekktu@gmail.com>
12383
12384 * emacs.c (USAGE3): Doc fixes.
12385
0e48bb22
AS
123862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12387
12388 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12389 structure.
12390
7684e57b
JB
123912011-03-14 Juanma Barranquero <lekktu@gmail.com>
12392
12393 * lisp.h (VWindow_system, Qfile_name_history):
12394 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12395 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12396 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12397
12398 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12399 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12400
12401 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12402 * w32console.c (detect_input_pending, read_input_pending)
12403 (encode_terminal_code):
12404 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12405 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12406 (w32_system_caret_y, Qfile_name_history):
12407 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12408 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12409 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12410 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12411 * w32proc.c (Qlocal, report_file_error):
12412 * w32term.c (Vwindow_system, updating_frame):
12413 * w32uniscribe.c (initialized, uniscribe_font_driver):
12414 Remove unneeded extern declarations.
12415
2aa46d6c
CY
124162011-03-14 Chong Yidong <cyd@stupidchicken.com>
12417
c96bbc66 12418 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12419
cffc6f3b
CY
124202011-03-13 Chong Yidong <cyd@stupidchicken.com>
12421
12422 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12423 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12424 These macros can no longer be used for assignment.
12425
44f230aa
SM
12426 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12427 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12428 (record_buffer_markers, fetch_buffer_markers): New functions for
12429 recording and fetching special buffer markers.
12430 (set_buffer_internal_1, set_buffer_temp): Use them.
12431
12432 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12433
12434 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12435
12436 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12437 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12438
12439 * xdisp.c (hscroll_window_tree):
12440 (reconsider_clip_changes): Use PT instead of BUF_PT.
12441
d251f04b
EZ
124422011-03-13 Eli Zaretskii <eliz@gnu.org>
12443
12444 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12445 $(EMACS_ROOT)/lib/intprops.h.
12446
f0c77cd1
PE
124472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12448
3eca4629
PE
12449 Fix more problems found by GCC 4.5.2's static checks.
12450
7c86ee98
PE
12451 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12452 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12453 (xg_free_frame_widgets): Make it clear that a local variable is
12454 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12455 (gdk_window_get_screen): Make it clear that this macro is needed
12456 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12457 (int_gtk_range_get_value): New function, which avoids a diagnostic
12458 from gcc -Wbad-function-cast.
12459 (xg_set_toolkit_scroll_bar_thumb): Use it.
12460 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12461 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12462 (get_utf8_string, xg_get_file_with_chooser):
12463 Rename locals to avoid shadowing.
12464 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12465
41729b81
PE
12466 * xgselect.c (xg_select): Remove unused var.
12467
f0c77cd1
PE
12468 * image.c (four_corners_best): Mark locals as initialized.
12469 (gif_load): Initialize transparent_p to zero (Bug#8238).
12470 Mark another local as initialized.
ec6cf4c6 12471 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12472
ce0ad53d 12473 * image.c (clear_image_cache): Now static.
d5d5a617 12474 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12475 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12476 (x_edge_detection): Remove unnecessary cast that
12477 gcc -Wbad-function-cast diagnoses.
2037898d 12478 (gif_load): Fix pointer signedness.
6ae141d6
PE
12479 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12480 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12481
33383987 124822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12483
d32df629
PE
12484 Improve quality of tests for time stamp overflow.
12485 For example, without this patch (encode-time 0 0 0 1 1
12486 1152921504606846976) returns the obviously-bogus value (-948597
12487 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12488 reports time overflow. See
12489 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12490 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12491 * editfns.c: Include limits.h and intprops.h.
12492 (TIME_T_MIN, TIME_T_MAX): New macros.
12493 (time_overflow): Move earlier, to before first use.
12494 (hi_time, lo_time): New functions, for an accurate test for
12495 out-of-range times.
12496 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12497 (Fget_internal_run_time): Don't assume time_t fits in int.
12498 (make_time): Use list2 instead of Fcons twice.
12499 (Fdecode_time): More accurate test for out-of-range times.
12500 (check_tm_member): New function.
12501 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12502 (lisp_time_argument): Don't rely on undefined left-shift and
12503 right-shift behavior when checking for time stamp overflow.
8be6f318 12504
fe31d94c
PE
12505 * editfns.c (time_overflow): New function, refactoring common code.
12506 (Fformat_time_string, Fdecode_time, Fencode_time):
12507 (Fcurrent_time_string): Use it.
12508
8be6f318
PE
12509 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12510 * dired.c (make_time): Move to ...
12511 * editfns.c (make_time): ... here.
12512 * systime.h: Note the move.
12513
09d9db2c 125142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12515
126bc0dc
YM
12516 * fringe.c (update_window_fringes): Remove unused variables.
12517
c47cbdfd
YM
12518 * unexmacosx.c (copy_data_segment): Also copy __got section.
12519 (Bug#8223)
12520
7ac80be9
EZ
125212011-03-12 Eli Zaretskii <eliz@gnu.org>
12522
c96bbc66 12523 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12524 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12525 Constify `char *' arguments and their references according to
12526 prototypes in tparam.h.
12527
ecb0f94d 12528 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12529
7ac80be9
EZ
12530 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12531 Adapt all references accordingly.
12532
12533 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12534
ef1fd07e
TT
125352011-03-11 Tom Tromey <tromey@redhat.com>
12536
12537 * buffer.c (syms_of_buffer): Remove obsolete comment.
12538
7ef4b50c
EZ
125392011-03-11 Eli Zaretskii <eliz@gnu.org>
12540
12541 * termhooks.h (encode_terminal_code): Declare prototype.
12542
12543 * msdos.c (encode_terminal_code): Don't declare prototype.
12544
12545 * term.c (encode_terminal_code): Now external again, used by
12546 w32console.c and msdos.c.
12547
44f230aa
SM
12548 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12549 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12550
4b1ec863 125512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12552
1714f52b 12553 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12554
4b1ec863
PE
12555 * fringe.c (update_window_fringes): Mark locals as initialized
12556 (Bug#8227).
12557 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12558
524c7aa6
PE
12559 * alloc.c (mark_fringe_data): Move decl from here ...
12560 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12561 to check its interface.
12562 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12563
a5c0af81 12564 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12565 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12566 (fontset_font): Mark local as initialized.
a9a06e0b 12567 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12568
b4716021
PE
12569 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12570
811e9bac 12571 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12572 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12573 (x_own_selection, Fx_disown_selection_internal): Rename locals
12574 to avoid shadowing.
12575 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12576
7e3ab302
PE
12577 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12578 so that the caller can use some name other than gcpro1.
12579 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12580 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12581 (Fx_backspace_delete_keys_p):
12582 Use them to avoid shadowing, and rename vars to avoid shadowing.
12583 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12584 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12585 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12586 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12587 Remove unused locals.
7e3ab302
PE
12588 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12589 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12590 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12591 macros.
f78faa98 12592
e2b13473
PE
12593 * xterm.h (x_mouse_leave): New decl.
12594
77f23912
PE
12595 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12596 Remove unused functions.
cdf4ba58
PE
12597 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12598 (x_calc_absolute_position): Now static.
7411c686 12599 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12600 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12601 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12602 unless they are used.
38d0b34a
PE
12603 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12604 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12605 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12606 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12607 (x_error_catcher, x_connection_closed, x_error_handler):
12608 (x_error_quitter, xembed_send_message, x_iconify_frame):
12609 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12610 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12611 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12612
44f230aa
SM
12613 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12614 Rename or move locals to avoid shadowing.
6b463e58 12615 (tty_defined_color, merge_face_heights): Now static.
5967d051 12616 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12617 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12618 does not deduce is never used uninitialized.
73719eba
PE
12619 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12620 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12621
426994c3 12622 * terminal.c (store_terminal_param): Now static.
5489860b 12623
032f1620 12624 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12625 (set_frame_menubar): Remove unused local.
d4323972 12626 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12627 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12628 since they might point to immutable storage.
281585b0
PE
12629 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12630 since it's unused otherwise.
032f1620 12631
367c19e5 12632 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12633 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12634 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12635 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12636 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12637 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12638 does not deduce are never used uninitialized.
70739cbe 12639
07b48fa9
PE
12640 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12641
8868a238 12642 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12643 * window.c (window_loop, size_window):
12644 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12645
7e5cf297 12646 * window.c (display_buffer): Now static.
d6550a9f
PE
12647 (size_window): Mark variables that gcc -Wuninitialized
12648 does not deduce are never used uninitialized.
a586633d
PE
12649 * window.h (check_all_windows): New decl, to forestall
12650 gcc -Wmissing-prototypes diagnostic.
5b555da1 12651 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12652
f6095868
PE
12653 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12654 shadowing.
12655 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12656 Include <limits.h>.
12657 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12658 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12659 (load_charset_map): Mark variables that gcc -Wuninitialized
12660 does not deduce are never used uninitialized.
53df7c11 12661 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12662
f38b440c
PE
12663 * coding.c (coding_set_source, coding_set_destination):
12664 Use "else { /* comment */ }" rather than "else /* comment */;"
12665 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12666 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12667 a block, when the outer 'i' will do.
12668 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12669 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12670 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12671 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12672 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12673 Rename locals to avoid shadowing.
12674 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12675 * coding.c (emacs_mule_char, encode_invocation_designation):
12676 Now static, since they're not used elsewhere.
413bb2db 12677 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12678 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12679 (decode_coding_emacs_mule): Mark variables that gcc
12680 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12681 (detect_coding_iso_2022): Initialize a local variable that might
12682 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12683 this initialization is needed. (Bug#8211)
5f58e762
PE
12684 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12685 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12686 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12687 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12688 Remove unused macros.
f38b440c 12689
232b38b9 12690 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12691 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12692 * character.c (string_count_byte8): Likewise.
232b38b9 12693
fb90da1b
PE
12694 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12695 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12696
fb93dbc2
PE
12697 * chartab.c (copy_sub_char_table): Now static, since it's not used
12698 elsewhere.
5c156ace
PE
12699 (sub_char_table_ref_and_range, char_table_ref_and_range):
12700 Rename locals to avoid shadowing.
bbcd0949 12701 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12702
7d3b3862 12703 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12704 (BIDI_BOB): Remove unused macro.
7d3b3862 12705
6be7d3da
PE
12706 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12707 deduce are never used uninitialized.
c2ed9c8b 12708 * term.c (encode_terminal_code): Likewise.
6be7d3da 12709
75f8807f 12710 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12711
50938595
PE
12712 * tparam.h: New file.
12713 * term.c, tparam.h: Include it.
12714 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12715 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12716 Move these decls to tparam.h, and make them agree with what
12717 is actually in tparam.c. The previous trick of using incompatible
12718 decls in different modules does not conform to the C standard.
12719 All callers of tparam changed to use tparam's actual API.
12720 * tparam.c (tparam1, tparam, tgoto):
12721 Use const pointers where appropriate.
12722
fbceeba2
PE
12723 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12724 * cm.h (struct cm): Likewise.
12725 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12726 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12727 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12728 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12729 (turn_on_face, init_tty): Likewise.
12730 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12731
7f3f1250
PE
12732 * term.c (term_mouse_position): Rename local to avoid shadowing.
12733
e6ca6543
PE
12734 * alloc.c (mark_ttys): Move decl from here ...
12735 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12736
c40f8d15
AS
127372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12738
12739 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12740
cfe0661d
JB
127412011-03-09 Juanma Barranquero <lekktu@gmail.com>
12742
12743 * search.c (compile_pattern_1): Remove argument regp, unused since
12744 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12745 (compile_pattern): Don't pass it.
12746
0afb4571
J
127472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12748
12749 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12750 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12751 for ! HAVE_GTK3.
12752 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12753
12754 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12755
12756 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12757 gdk_window_get_screen, gdk_window_get_geometry,
12758 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12759 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12760 (xg_get_pixbuf_from_pixmap): New function.
12761 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12762 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12763 Call xg_get_pixbuf_from_pixmap instead of
12764 gdk_pixbuf_get_from_drawable.
12765 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12766 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12767 (xg_check_special_colors): Use GtkStyleContext and its functions
12768 for HAVE_GTK3.
12769 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12770 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12771 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12772 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12773 Call gtk_widget_get_preferred_size.
0afb4571
J
12774 (xg_frame_resized): gdk_window_get_geometry only takes 5
12775 parameters.
44f230aa
SM
12776 (xg_win_to_widget, xg_event_is_for_menubar):
12777 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12778 (xg_set_widget_bg): New function.
12779 (delete_cb): New function.
895009e1 12780 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12781 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12782 (xg_set_background_color): Call xg_set_widget_bg.
12783 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12784 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12785 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12786 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12787 if ! HAVE_GTK3.
12788 (update_frame_tool_bar): Call gtk_widget_hide.
12789 (xg_initialize): Use GDK_KEY_g.
12790
12791 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12792 if ! HAVE_GTK3
12793 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12794
12795 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12796 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12797 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12798
1c2cc4ef
JB
127992011-03-08 Juanma Barranquero <lekktu@gmail.com>
12800
12801 * w32xfns.c (select_palette): Check success of RealizePalette against
12802 GDI_ERROR, not zero.
12803
33383987 12804See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12805
12806;; Local Variables:
12807;; coding: utf-8
aac0c6e3
MR
12808;; End:
12809
2f097256 12810 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12811
12812 This file is part of GNU Emacs.
12813
12814 GNU Emacs is free software: you can redistribute it and/or modify
12815 it under the terms of the GNU General Public License as published by
12816 the Free Software Foundation, either version 3 of the License, or
12817 (at your option) any later version.
12818
12819 GNU Emacs is distributed in the hope that it will be useful,
12820 but WITHOUT ANY WARRANTY; without even the implied warranty of
12821 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12822 GNU General Public License for more details.
12823
12824 You should have received a copy of the GNU General Public License
12825 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.